This is just for clarity, no logical change.


For clarity.


A virtual source has no datamodel.


Hi Ryan,

Yes, thanks. After having played with 'repo forall' for a while now, I actually prefer having the remotes uniquely named. It makes it a lot easier to perform quick chores on a all projects tied to a single remote. For your wish (to have all projects refer to origin), a fix would likely be welcomed upstream. I guess the feature is mostly unused, or someone else would already have noticed it.

Regards,
Pieter


I don't understand the Rails sytnax here, but will this still ensure that we are fetching only the correct records? Remember that jobsworth is a multi-tennant system and so it is essential that fetches are only for the right company and don't drag in data from other companies.


Oh, actually I remove the comment just to push a new version to check if panda was still not working


Alright, but what about the other colors, according to the guidelines most of them should be combinations of alpha + black or white (sometimes also a greyscale). Seems like you are using something like "pre-rendert" colors here.
Sorry, it's late here and I don't know how to formulate that exactly now :D


@Vzor-, so the thread sleep wasn't need in this case?


remove space


Thiss is the readme
![untitled](https://cloud.githubusercontent.com/assets/12978593/12693267/aac91018-c6d3-11e5-9dc1-73045f59b1b6.png)


Hmm rasanya coin change kurang tepat buat demonstrasi, karena analisisnya cukup "greedy" dan straight forward.
Ada saran untuk soal lain? Contoh soal yg enak dibahas itu hitung angka 0 dari N!, cek "kisi-kisi materi uji olimpiade komputer"


Hey there is an awful lot going on here it should look more like this...
```
class WikiPolicy < ApplicationPolicy

  def index?
    true
  end

  def show?
    Wiki.where(:id => record.id).exists? && (record.public? || update?)
  end

  def update?
    user.present? && (
      record.public? || (
        user.admin? ||
        record.user == user ||
        record.users.include?(user)
      )
    )
  end

  def edit?
    update?
  end

  def create?
    user.present?
  end

  def create_wiki_from_link?
    create?
  end

  def new?
    create?
  end

  class Scope < Scope
    def resolve
      if !user.present?
        wikis = public_records
      elsif user.standard?
        wikis = (public_records + shared_records).uniq
      elsif user.admin?
        wikis = scope.all
      elsif user.premium?
        wikis = (public_records + private_and_owned_records + shared_records).uniq
      end
      return sorted_by_last_updated(wikis)
    end

    private

    def private_and_owned_records
      scope.where(:private => true).where(:user_id => user.id)
    end

    def public_records
      scope.where(:private => false)
    end

    def shared_records
      scope.joins(:collaborations).where("collaborations.user_id = #{user.id}")
    end

    def sorted_by_last_updated(records)
      records.sort_by{|e| e.updated_at }.reverse!
    end

  end

end
```


Beberapa masukan langsung di source code


spacing funk


- Although hitting multiple issues with one commit is not 'wrong', you ideally want separate commits for unrelated changes. That way its easier to relate the code change to the commit message.
- I just noticed that in your commit message since you have used the #<number> syntax for adding the issues, it auto-links to the issue and you can click on it! Stick with this format -- I didn't even know it existed.


@kduraiswami Was there a special reason why you did that? :)


Just a thought and minor: Can these two php tags not be merged into one?

<?php $result = get_role();
 while ($row = ...) ?>


5429_ConstructionInternalSource (mitchute) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


develop (lefticus) - i386-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


develop (lefticus) - Win64-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Very Minor:  In your commit message, it should be '_SESSION' not 'SESSION'


Kinda weird that it thinks you added all those files, but the part you changed looks good. I like the clean up btw. APPROVAL


:clap: :clap:


It mightn't be necessary, however it will probably help editor syntax parsers and pretty printers if present.


There is a misspelled "canola" as "canols".


Just tested Edge: it is consistent with Firefox.


Lll


nice work!


 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:679](../blob/7f4ef8d8fd43fd786ff7a43401b263debedb6bec/include/chaiscript/language/chaiscript_parser.hpp#L679) Expression is always false because 'else if' condition matches previous condition at line 677. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:683](../blob/7f4ef8d8fd43fd786ff7a43401b263debedb6bec/include/chaiscript/language/chaiscript_parser.hpp#L683) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/7f4ef8d8fd43fd786ff7a43401b263debedb6bec/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/7f4ef8d8fd43fd786ff7a43401b263debedb6bec/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 683. (multiCondition)
 - __information__: [src/chaiscript_stdlib.cpp:1](../blob/7f4ef8d8fd43fd786ff7a43401b263debedb6bec/src/chaiscript_stdlib.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __information__: [src/main.cpp:0](../blob/7f4ef8d8fd43fd786ff7a43401b263debedb6bec/src/main.cpp#L0) Too many #ifdef configurations - cppcheck only checks 12 of 13 configurations. Use --force to check all configurations. (toomanyconfigs)
 - __information__: [src/main.cpp:1](../blob/7f4ef8d8fd43fd786ff7a43401b263debedb6bec/src/main.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/7f4ef8d8fd43fd786ff7a43401b263debedb6bec/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/7f4ef8d8fd43fd786ff7a43401b263debedb6bec/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/7f4ef8d8fd43fd786ff7a43401b263debedb6bec/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/7f4ef8d8fd43fd786ff7a43401b263debedb6bec/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/7f4ef8d8fd43fd786ff7a43401b263debedb6bec/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


[Martin Fowler - Tolerant Reader]


I'd try fewer. How many processors does the build bot have assigned? 2, 4?


Ment to say should be formatted with colons not underscores, sorry.


develop (lefticus) - i386-Windows-7-VisualStudio-12: OK (383 of 384 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13589](https://teamcity.mesosphere.io/viewLog.html?buildId=118232&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:08:20


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-AddressSanitizer: OK (3042 of 3042 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I thought it was a typo.. sorry!


You don't have to be very specific like this or have links to PRs. Think from a user perspective, what is really important here is that:

    - SDK now uses go-autorest v3.0.0.

that's all they need to know.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13588](https://teamcity.mesosphere.io/viewLog.html?buildId=118231&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:08:56


public interface EventHandler {
		-    public void handleEvent(Handle work) ;
		+  public void handleEvent(Handle work);
		 }


also this is not a (') it is a backtick: (`).


This loses testing the case where d->want <= d->got.
I'll fix it.


If we call `file_.Close()` before `_close(fd_)` it would cause the crash in #4258, seems that we are trapped here...

I'll try to work around both crashes, thanks for the head up.


We fixed it in a different way. If you want to send in the PR with an issue, please go ahead and we'll evaluate it (though I believe the above caused problems, which is part of the reason we backed it out and fixed it another way).


Yea this might work, as there's now only 1 insanely big fish left (render_markers_symbolizer.cpp) instead of 4.


@phamdaniel Interested in doing a PR? :)


the various LICENSE files are automatically generated.  in fact we don't need one for docs since they aren't distributed.  but useful to have this info.

for more info look in:

* `brooklyn-dist/dist/licensing`
* `brooklyn-docs/_licensing` (i just created this, to store the metadata you've extracted below)


develop (lefticus) - Win64-Windows-7-VisualStudio-12: OK (383 of 384 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


I stated my case.  WebDav isn't HTTP, it's an addition to it.
I could have killed the PR but I really wanted to leave it up to you (although I don't recommend or approve) and I'm not going to argue.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: OK (384 of 384 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


5429_ConstructionInternalSource (mitchute) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (956 of 956 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.85%25-green.svg)


|number|comment|


Yep, that's it!

--
@adarshp <http://www.twitter.com/adarshp>
313.454.1515 (mobile)
See when I am free: http://bit.ly/adarshcal

On Fri, Jan 29, 2016 at 6:57 PM, Bailey Ling <notifications@github.com>
wrote:

> sorry, typo, it's theme*s*, not theme
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vim-airline/vim-airline/commit/3cd278ad088620ea454d74c19698c9866e44c104#commitcomment-15777252>
> .
>


Heh, "Reinstante" ... no idea how that got in there.


think u meant **interested**. I'm attempting to help now, but need help my "Cough up blood" issue to be able to advise others further. Professional developer (multi-decade) with some JS experience, but no ```coffee``` which holds me back with this project. Have some go-forward ideas, as I think this project serves a real need, but if I can't make my part work, I can't explain it to others. Happy to discuss ideas with you.


That should read: "Reinstate var bindings in refutable patterns"


@xDemonessx is it ok with you if I use your scrot above in the Readme?


Why change all of these to be static?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-NoThreads: OK (384 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.71%25-yellow.svg)


Why ```i1``` rather than ```i```?


Mas [instantes](https://en.wiktionary.org/wiki/instante#Spanish)!


n,,,


@plroebuck  I'm glad you can help, let's solve your "Cough up blood" issue first.


bnbnbnbnbnbnbnbnbnbnbnbnbnbnbn


Thanks for the feed back I fixed it in my latest commit


halo


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (390 of 390 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


what are you 弄啥哩


ja


LGTM 👍


After talking with Yifeng and testing the old `git://` it's quite simply because it'll work then. :P

NeoBundle has deprecated the `git://` protocol as there's no kind of security at all on it. Susceptible for MITM and the like.

Since all the repos are actually completely open you can just press enter on the user/password prompt to get past it. Today there are some random disconnects happening, guessing GitHub is still being DDOSed, so you might've to restart.


Shouldn't string be uppercase?


Looks like you forgot to include ExclusiveReinforcement type?

Also double check that you have the test in every place where a reinforcement might get created, pretty sure its more then one place.


Should you append to the existing file?


Is this related to the latest issue that I just logged? If so, could you please release a new version (v0.0.10) to rubygems?


I would disagree with doing this because:

1. You are overloading the version field with other data; rather than using the version number for the version number, it is now including a version number and a date
2. You are excluding information the version number provides, e.g., how many patches there are for each minor version
3. The semantic versioning method for doing this is to add metadata with a plus sign after the patch number, e.g., `0.5.26+20160128` (http://semver.org/#spec-item-10)
4. This is the only gem I've seen do this, and you'll be answering this question over and over


Sure, I'll even do it now :smile:


Should I change this to use the allowedQuestions property?


I thought Z was the tickle packet?
<z d="id of person to tickle" u="your id" t="/l" />


develop (lefticus) - i386-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


develop (lefticus) - Win64-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:679](../blob/bde2a453849d4cc89b537d8314b2effcfee59f4f/include/chaiscript/language/chaiscript_parser.hpp#L679) Expression is always false because 'else if' condition matches previous condition at line 677. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:683](../blob/bde2a453849d4cc89b537d8314b2effcfee59f4f/include/chaiscript/language/chaiscript_parser.hpp#L683) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/bde2a453849d4cc89b537d8314b2effcfee59f4f/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/bde2a453849d4cc89b537d8314b2effcfee59f4f/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 683. (multiCondition)
 - __information__: [src/chaiscript_stdlib.cpp:1](../blob/bde2a453849d4cc89b537d8314b2effcfee59f4f/src/chaiscript_stdlib.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __information__: [src/main.cpp:0](../blob/bde2a453849d4cc89b537d8314b2effcfee59f4f/src/main.cpp#L0) Too many #ifdef configurations - cppcheck only checks 12 of 13 configurations. Use --force to check all configurations. (toomanyconfigs)
 - __information__: [src/main.cpp:1](../blob/bde2a453849d4cc89b537d8314b2effcfee59f4f/src/main.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/bde2a453849d4cc89b537d8314b2effcfee59f4f/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/bde2a453849d4cc89b537d8314b2effcfee59f4f/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/bde2a453849d4cc89b537d8314b2effcfee59f4f/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/bde2a453849d4cc89b537d8314b2effcfee59f4f/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/bde2a453849d4cc89b537d8314b2effcfee59f4f/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


I think it should be explicit in the steps. The scenario name is really just a convenient short-form alias for the steps themselves.


Beberapa masukan:

1. Sebenarnya kontes Compfest, NPC, ILPC termasuk kontes tingkat nasional. Buat aja pembagiannya nasional dan internasional. Boleh juga ditambah sedikit deskripsi kontes ini, misalnya siapa yg mengadakan.
2. Untuk tanda baca `:`, tidak perlu ada spasi di awalnya.

Selebihnya di bagian `Demonstrasi Problem Solving`, soalnya perlu diganti jadi yg kurang straight forward. Tapi ini tidak wajib untuk dikerjakan di pull request ini.


This lock also protects the PrintCertInfo, PerformHandshake, ReadHandshakeData. Removing this lock you're making troubles for these method. Locks should inside those methods too,


We usually call this a handle.  A pipe is a thing that still has both ends locally.


LGTM :+1:


Is that defined by the mojom?  In that case, the autogenerated code will validate that for you.


In fact, you could use `xcrun simctl erase all` rather than Apple Script. :smile:


Can you break this up into smaller commits for review purposes?  GitHub isn't showing some of the files, such that I can't comment on them.  I noticed, for example, that the TestCtor_CharPtr_Invalid test is doing some bad things that could easily AV.


s/engine/mojom/


Good job bro :+1:  #kada


Is the `server` just dropped on the floor?  Should we remove it?


develop (lefticus) - i386-Windows-7-VisualStudio-12: OK (384 of 385 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


Obviously don't land this part.  :)


Are you changing includes order manually or this is done by clang format? It seems to me that this is done automatically. In this case you're using wrong version of the clang-format. Include order is changed in formatter starting from 3.8. But sources are  formatted with 3.7. And soon sources will be reformatted with 3.6 since we have to sync versions with other repos.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (390 of 390 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I'm happy to see Herocraft carrying on my fork! Down to the problems... @mibby I just fixed this in the latest commit (https://github.com/Lactem/Lottery/commit/455482ff54b79275e3d10a478b284be766930e84) on my fork (https://github.com/Lactem/Lottery). I also made a PR (https://github.com/Herocraft/Lottery/pull/1) into your fork @Kainzo so you can keep your own development rolling there.

In response to the "crazy amount of the same users winning," I haven't noticed anything like that since this commit. I "fixed" the random logic incorrectly the first time, but this commit should've made it work again. Is it possible that a few users on your server are just buying more tickets than everyone else?


typo. "bee" -> "been"


Please take another look


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13601](https://teamcity.mesosphere.io/viewLog.html?buildId=118349&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 218 Build time: 00:09:08


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13600](https://teamcity.mesosphere.io/viewLog.html?buildId=118355&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:09:19


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13599](https://teamcity.mesosphere.io/viewLog.html?buildId=118356&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:09:20


It looks like mapbox-maps depends on the interface of `Backend.getTile` to call back with a vector tile, rather than a `mapnik.Image`. Here is the code that pulls in `('tilelive-vector').Backend`: https://github.com/mapbox/mapbox-maps/blob/master/lib/tilelive-multivector.js#L6-L33 and here is the code that calls `backend.getTile` and tries to call `vtile.composite` with the results, but errors when it finds an image: https://github.com/mapbox/mapbox-maps/blob/master/lib/tilelive-multivector.js#L173-L211.

Should we add checks downstream in `mapbox-maps` to check if the returned object is a `mapnik.Image` and then create a vector tile, add an image to it, and then call `vtile.composite` with that? Or should we call `addImage` within `Backend.getTile` and return the expected vector tile? cc/ @yhahn @springmeyer


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13602](https://teamcity.mesosphere.io/viewLog.html?buildId=118354&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:09:51


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13598](https://teamcity.mesosphere.io/viewLog.html?buildId=118345&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:10:41


Propose to set this flag to false at the very beginning of the method to handle next case. set_certificate is called twice. first call is ok so flag is true. second call fails, thus there will be the return , no flag reset. Thus  IsCertificateUpdateRequired will not handle missing cert.


develop (lefticus) - Win64-Windows-7-VisualStudio-12: OK (384 of 385 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


@paulirish Good point, I added 6c45a0a to address this. Thanks! :bow:


Whoa, thanks @egeland! I completely forgot that the information was still visible in the previous commit.


I had assumed the problem was that the layout styles weren't being added
for the digest. It turn out that adding the layout styles does solve some
problems, but then it causes some other ones. The rendering of html emails
is very inconsistent. I have a good setup now for testing the email digest.

On Fri, Jan 29, 2016 at 8:37 AM, Simon Cossar <scossar3@gmail.com> wrote:

> That doesn't look good! I'll try to figure out why it's doing that.
>
> On Fri, Jan 29, 2016 at 2:13 AM, Régis Hanol <notifications@github.com>
> wrote:
>
>> Oh my... @scossar <https://github.com/scossar> can you have a look?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/discourse/discourse/commit/9832bb4103994f147e7386416e930f037326d938#commitcomment-15757227>
>> .
>>
>
>


Yeah, agree: probably too much. OSX boxes only have 2 cores and 3 GB (https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments). I think those 2 cores might be hyperthreaded but not sure.


wow many adarsh....including me


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


1. I don't consider it is a problem as long as it is machine-readable.  I don't have a reason to strictly comply with "the" semver here.
2. As for the PSL database, it matters how up-to-date it is, now how many times it has been updated.
3. A database version cannot be considered as build metadata because it should matter in version comparison, and to begin with, RubyGems simply does not support build metadata in Gem::Version.
4. At least I know of [mime-types-data](https://github.com/mime-types/mime-types-data), which adopts a modified version of semver, without getting any objection on its versioning policy.


there is now `mesh.partition.size`


Thanks! BitHub has sent payment of  $25.54USD for this commit.


This script


5429_ConstructionInternalSource (mitchute) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1507 of 1507 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


we don't need to make it bold...


This simply followed the example of oniguruma/regint.h, and there is no need to put "bogus" labels on trivial code changes.


An error has been encountered in accessing this page.

1. Server: nipy.sourceforge.net
2. URL path: /nipype/users/pipeline_tutorial.html
3. Error notes: NONE
4. Error type: 404
5. Request method: GET
6. Request query string: NONE
7. Time: 2016-01-30 04:25:04 UTC (1454127904)

Reporting this problem: The problem you have encountered is with a project web site hosted by SourceForge.net. This issue should be reported to the SourceForge.net-hosted project (not to SourceForge.net).


This commit shouldn't be in the PR at all. Can you squash it somehow?


I mean that conflict artifacts (<<<<<, =====, >>>>>) should be removed somehow from the PR.


Awww yiss, DSE 5.0 looms!


I don't think it is needed. As far as I know it is somewhat common to have just a while loop in a thread, though a sleep may help lower cpu overhead. The threads aren't stepping on each other's heels here because there is now only ever one thread.


That's what I'll do then.  I thought you guys recently updated some 1.10 packages, so I figured I'd ask. Thanks.


Is GIN index enabled in MASTER?


We almost certainly want `--interactive` here. Every docker example I've seen pairs `--interactive` with `--tty`. It keeps stdin open, which is how the `bundle` command would normally be run. I guess `bundle` doesn't care, but it still seems out of place to me.


__attribute__((unused)) is specific to gcc.


Props! Clear and the logic flows. I've modified the question to be "to the Nth number" to avoid the ambiguity. Won't affect your pseudocode.


change param name to 'temperature'


if type is uint then change 0->0u


I guess what's confusing me is the choice of terminology. What's a "table property" vs a "table parameter"?


we don't use one-liners


In `Traversal`, `NO_CHILD_NODES` is an array of symbols. The array here should also be an array of symbols, to properly check which members are also in `NO_CHILD_NODES`.


Fixed in #1581 (https://github.com/wso2/carbon-apimgt/commit/0e5a93cca133738cc74a26863424e20db485892d)


Why casting is needed ?


The performance benefit here is not much. I can remove this commit.


I think `vtile.addImage` requires a layer name as the second parameter


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (391 of 391 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


develop (lefticus) - i386-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


develop (lefticus) - Win64-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


I don't think that casting is needed. And for _beginthread(), I leaved it on purpose.


I don't like change of the interface. Turn back return by value. This is not only looks much better, but it's also efficient.
Here will be the NRVO. so no extra copy. Usage of the return by value allows to write in c++ something like this
```
auto result = createPTforLoad();
```
But passing out arg by ref will require from the caller to write type explicitly and init var somehow.


Wouldn't it just be easier to copy "0.0" into the string here?


100 -> 100u


The comment doesn't match the code here (double vs number_float_t, and saying that it's a constant 15 when it's based on digits10, which could possibly be other than 15).


Octree (DeadParrot) - x86_64-MacOS-10.9-clang: OK (2062 of 2062 tests passed, 3 test warnings)

 * 3 tests had: AUD diffs.
 * 2 tests had: EIO diffs.
 * 2 tests had: ESO small diffs.
 * 1 test had: SHD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


develop (lefticus) - i386-Windows-7-VisualStudio-12: OK (380 of 385 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.7%25-yellow.svg)


Likely you did it crash mssing a synthetic


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (385 of 385 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:679](../blob/7688c14d43456af5a12f618e7cd1f3531c015413/include/chaiscript/language/chaiscript_parser.hpp#L679) Expression is always false because 'else if' condition matches previous condition at line 677. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:683](../blob/7688c14d43456af5a12f618e7cd1f3531c015413/include/chaiscript/language/chaiscript_parser.hpp#L683) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/7688c14d43456af5a12f618e7cd1f3531c015413/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/7688c14d43456af5a12f618e7cd1f3531c015413/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 683. (multiCondition)
 - __information__: [src/chaiscript_stdlib.cpp:1](../blob/7688c14d43456af5a12f618e7cd1f3531c015413/src/chaiscript_stdlib.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __information__: [src/main.cpp:0](../blob/7688c14d43456af5a12f618e7cd1f3531c015413/src/main.cpp#L0) Too many #ifdef configurations - cppcheck only checks 12 of 13 configurations. Use --force to check all configurations. (toomanyconfigs)
 - __information__: [src/main.cpp:1](../blob/7688c14d43456af5a12f618e7cd1f3531c015413/src/main.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/7688c14d43456af5a12f618e7cd1f3531c015413/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/7688c14d43456af5a12f618e7cd1f3531c015413/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/7688c14d43456af5a12f618e7cd1f3531c015413/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/7688c14d43456af5a12f618e7cd1f3531c015413/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/7688c14d43456af5a12f618e7cd1f3531c015413/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


Favor corrigir


Fixed


do you really need this?

This will invalidate the buffer and rebuild the ByteBuffer on the message.


This was by accident. I auto-imported… so that's probably why it changed it from * to GL11


So the display partials can / should go in new, or other appropriate views. Only the form partials need to be embedded in_form


It looks good otherwise.. I just don't like using the property as it will rebuild the message body.


防止生成小于四位的验证码


AddWarningWhenDElightAndShading (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2089 of 2089 tests passed, 0 test warnings)

 * 6 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


lightlevel is used to reduce the moon's RGB values (not Alpha) based on bglight. This is so it makes an accurate "Pale Moon" during the day.


develop (lefticus) - Win64-Windows-7-VisualStudio-12: OK (380 of 385 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.7%25-yellow.svg)


I don't quite understand the usage of the signal_event. Seems this is win native specific flag. I see no it's usage in the Qt branch below. So I propose to change here the ifdef and define and use signal_event  only for win native.


@cliffom It seems like the `request_array` is actually an `object`, is that correct?


I removed the WeatherEffect from affecting the Star's Brightness directly before being processed for Alpha… because f4 is based on the RainStrength. (I apply it again later, after the star's Alpha has been calculated).


what is new


redundant


corrigido


There's probably a better way to express (1-weathereff)/1. I just couldn't think of it at the time.


This is simply a copy-paste process I put onto this script, that keeps the same code for the movement of the player, but also includes the rotation of the capsule GameObject itself, so that the movement direction as the camera changes direction also changes the direction the capsule faces, so the directional keys move in relation to where you are facing in the particular moment.


at the moment we don't use hierarchy. Plus there should be no space in any case. There should be dot.


Do you mean that I should pass the argument as dummy of pointer, for example index of array of go pointers? I don't get understanding clearly. If you are okay, could you please give me your patch?


wrong name


Language, please.


Removed weathereff here because it is added earlier.


Same as above. Alpha is affected by weathereff.


AddWarningWhenDElightAndShading (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Not sure it will allow email address in there. There is contact info in the ARP property set IIRC


The moon's phase was actually backwards… so I inverted it to correct it.


This is a good default Contrast, now that Planet Alpha is fixed for Venus's Mag.


Sure!


isCompleted is the current value so we just set it to the opposite


Version will be $(var.MajorVersion).$(var.MinorVersion).$(var.BuildVersion).$(var.Revision), not the simpler X.Y.Z. Not sure what @version is


This is revised Turbulence so that all stars flicker approximately the same. Before, Sirius would Flicker too much compared to Faint stars.


Sirius Offset.


### Breaking changes

@cliffom Would like your thoughts on this

**Specs will fail and will need to be rewritten** based on the changes that all response errors will be thrown inside of the new `check_response` method

Since `send_request` is always called before it's decided to throw an error or not, I think it might make more sense to check whether the response is valid inside the `send_request` method.

The case inside the renamed `check_response` method will handle throwing all of the errors.
[Line 116](https://github.com/RadPad/tokenex-gem/blob/refactor/lib/tokenex/environment.rb#L116) will need to be looked at and renamed appropriately. I'll need test keys to see what could possibly happen if the response is not a success, or what error should be thrown. Possibly just a rename of the thrown error is needed.


You define it like that. If we only have low normal and hight we might want to keep it at 0, 1, 2(I changed the THOUGHT_TYPE values to be 0, 1, 2 in my branch)


This is our custom WiX UI dialog set. WixUI_InstallDir is the default provided one, that we customized. Any project that wants to change dialog order, dialog content, etc, will have to make a set like this. In short, no.


We are template-ing a template system, there are going to be a lot of modification points. :(

Ideally strings like this are kept in localization files so that multi-lingual installers can be made, but as is we stored them in the wxs itself.


I don't beleive there is a restriction, but this will change the backing store (cabinet file, think archive) file name. While this isn't a user surface-able thing, its a break from the existing MSI


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-AddressSanitizer: OK (3043 of 3043 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yes, its puppet-agent specific. Artifact of copy paste, sorry. It has to be repeated because its a build time condition (if/else), not an install time condition (CDATA)


I just tested this.  Although the multiple threads/lockup is fixed, the CPU still spikes to 25% on port open, which is too high.


I removed this action since it is confusing to report a EventReference diagnostic when encounter an EventAssignmentExpression.


what is you mean


No, that way leads to ruin. `TARGETDIR`, `INSTALLDIR`, and related directory type things are special WIX variables and are best left as is. There is complicated logic to determine placement of files based on these variables, complicated 'Remember' functionality for upgrades, and other semi-documented dependencies. As well, in order for use to specify the `Directory` elements in other wxs files and have them brought in, we need a known Directory ID for the 'root' to use `DirectoryRef`'s for.  In short, no touchy.


I like the xml pretty. I guess for auto-generated xml, it's not so important. :)


for loops like this aren't very reliable in javascript. Its one of the many nuances of javascript. Arrays are just glorified objects in JS. Use the native array methods like...

    thoughtIds.forEach(function (thoughtId) {
        // code
    });

instead.


Any project that has MajorUpgrade (which got lost in the copy paste, TODO: add it back) needs to use a `*` for ProductCode. If all our projects will (which is generally what I recommend), then yes.


Yes, you are right, but not only tickle. It's also private message packet.
Try it yourself, if you don't yet! Send pm to another chat and look at the traffic.


`filters`  ->  `filterCondition`


I just pushed a change in 90cd412 that reverts some of this minification.   It was causing too many merge conflicts with the generated .json files.

Now:
1. we `.gitignore` more of the files generated by `build.js`
2. we restore some of the space in `JSON.stringify`, so merge conflicts don't happen


Actually there is a Honda in teal that could also be a suspect, which is eliminated by interviewing.


seems the `expectedAnswer` is always `df.filter(filters).sortBy(df.output: _*)` ?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: OK (385 of 385 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


AddWarningWhenDElightAndShading (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (957 of 957 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.88%25-green.svg)


@TR4Android the only problem I see otherwise is the fact that the `view` reference will be cleared, and it's needed later.

Even setting `view` to another variable will maintain the reference, so setting it something else will prevent the tag processor from targeting the correct view.


I think this should be `r = self.send_int...`


Where is "payload" defined?  Is there a missing `payload = b` statement?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-NoThreads: OK (385 of 390 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.72%25-yellow.svg)


Add this assertion back


What the deal removing this assertion?


I was torn in the middle, but because the change was so small. I gave it the benefit of the doubt. After your comment I created #276 where the code can move after you restructured the base. (Is also a good input what kind of extensions must be easy to do ;-) )


test


why not use
```c
#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 2, 0)
#endif
```
to support different kernel versions


Shouldn't the function be called "attemptsLeft"?


ObjexxFCL41 (DeadParrot) - x86_64-MacOS-10.9-clang: OK (2062 of 2062 tests passed, 0 test warnings)

 * 3 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Code will not read this return statement


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13615](https://teamcity.mesosphere.io/viewLog.html?buildId=118394&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:11:47


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (391 of 391 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@josephsavona any update on this particular issue ? Thanks!


What if you call nc.unsub here? this was a question i was asking before in #114


Well, it isn't. The failure was probably coming from Travis's silly virtualenv setup instead: https://docs.travis-ci.com/user/languages/python/


The assertion was failing and I don't see a deps file being generated by publish in the general case.

Is a deps file expected to be generated here?


I think these static_casts make things very hard to read.

How about instead of static casting, where possible we use something like

CHECK_EQ(2u, outputs.size()) ?


any reason why? :)


Yes.


This patch not correct.
Error request code translation (RILJ -> RILQ).
Examples:
1) RIL_REQUEST_SIM_TRANSMIT_APDU_BASIC -> RIL_REQUEST_GET_RADIO_CAPABILITY
2) RIL_REQUEST_NV_READ_ITEM -> RIL_REQUEST_PULL_LCEDATA


Addresses Issue #180.


this is probably the best example I can think of as to how the android framework makes it easy to leave objects hanging around never to be garbage collected, especially for people who haven't used it a fair bit


gotta be careful passing around that activity


Struct RIL_SIM_IO_v4 not used in RILQ from Huawei.
For SIM_IO operations used struct RIL_SIM_IO_v6 with "cla" field.
See this commit: https://github.com/jsr-d9/android_hardware_ril-legacy/commit/9f56728bb23388c6891f10ac668d3de5e23c93b2


This looks great!


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (391 of 391 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


nice. I wonder if we could split some of this code out for easy unit testing


Looks better, great job :+1:


DRY - don't repeat yourself https://en.wikipedia.org/wiki/Don%27t_repeat_yourself


commit add


I thought `size_t` is more portable.


In general, `2u` may not be the same type with `size_t` of outputs.size(). Isn't it?


it is, but the majority of our users are on 64-bit platforms nowadays, and I'd rather make the code readable and warning-free for our majority of users and live with the warnings for these relatively inoccuous CHECKs for those on 32 bit platforms.


If you think so, I have no objection for that. :) I'll change that into `2u` and other things, too.


In documentation we need mentioned all the available option this will help us to use easily.


Yes.


Another option might be brace initialization like: size_t{0}.  Slightly less readable than it is today but better than static_cast


can you rename this one as well `checkpointAllMarkedAncestors`


Мы не только h1 оборачиваем, но вместе с ним и хлебные крошки. По макету видно, что от меню вниз отступ и от хлебных крошек вниз. так вот я предложил обернуть блоком h1 и хлебные крошки, чтобы потом этому большому оберточному блоку задать внутренние отступы. И код так более структурированней. Это шапка контента, ниже сам контент, под ним может идти низ контента


.gitignore


# ☺ ☻

I'm GabeAl and I approve this message


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


We have another issue which is the page for localhost/callback is opened in the same time *loadstart* is triggered, I don't know where to fix it, someone can advice?

Thank!


Блок .content - необходим так как у тебя внутри него будут элементы с float:left и float: right, а у float-элементов, обязательно должен быть родитель у которого будет задана распорка, чтобы они сквозь него не вываливались и ниже идущие блоки видел их.


Removed.


不发pr这样提交我是很难关注到的


What's up with this? Why not just resolve the log location? The logs should all be in the same location so there shouldn't be a reason for any logic here.


Nevermind https://github.com/afollestad/app-theme-engine/commit/fe75fece818a65af190d676f8f60c345823b48dd


Thank you so much for fixing this!


Thanks buddy, was going to fix it anyway errors had popped up on my pico with this one.


a try


Нет. Мы можем дать блоку img - display:block и он станет блочным. Оборачиваем для того, чтобы сделать решение универсальным. Универсальность заключается в следующем. Мы обернули img в блок и дали блоку фиксированные размеры height и width по размеру картинки на макете. Потом для img мы пишем следующие правила: img {max-width: 100%; max-height:100%; height: auto; vertical-align: middle; display: inline-block;}. И теперь в независимости от того какого размера картинку забросит пользователь или мы, для нее всегда будет зарезервировано, то место, которое по макету и картинка не вывалится из блока в который мы ее обернули и не сломает сетку. А если мы так не сделаем, то картинка может быть большего размера чем блок и сломает нам сетку, будет наползать на другие блоки. Можно конечно задать картинке ограничивающие размеры, но я считаю это не универсальным решением.


No clue why this change is here, I've tried to revert it locally. Can't get it to leave me alone.


AddWarningWhenDElightAndShading (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1508 of 1508 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


I have one question. Is this *readability* guideline is applicable for other existing `static_cast<>`? I've read some of them in recent commits.


is there PPA source for ubuntu ?


> a few night in

haha, typo.


Можете оставить, но валидатор вероятнее всего напишет вам предупреждение, не ошибку!


Looks good.


Я предполагаю, что вы будете делать эти 2 блока через float. один float: left, другой float: right, а если так, то им необходим блок обертка с классом .clearfix. В clearfix будет следующие правила .clearfix::after{content: ""; displat:table; clear: both;} - это называется распоркой, и она не дает флоат-элементам вываливаться из своего родителя.


Отписал выше про float-элементы. В данному случае та же проблема!


Нет, они решают, что будет заголовком, а что нет. Ведь заголовки участвуют в поисковых запроса. Поэтому неправильно поставленный заголовок, может быть изменен на тег div и тогда стили слетят.


@TheStrix this will end up having distortion in voice calls. Set back to stock to avoid.


I'm just waiting to test this with real burned items (so close to burning new vocab!)


The reason for the logic is because if the log location is relative e.g ./logs/myLog.log resolving the path name would return ./background/logs/myLog.log. I've not worked with Bunyan before though so I may be doing something wrong.


Isn't there an error in msm8994-asoc-snd fe034000.sound after update to 3.10.96?
It shows this error message when init process.

https://github.com/jollaman999/jolla-kernel_bullhead/commit/0f72db56d5dd5c095233441d2032d38a5d6f29e9


Да, все верно. Можно не спан, а просто ссылку убрать! Но это уже не наша забота будет, а забота backend-программиста, или CMS (Content Managment System), которая будет либо сама удалять ссылки, либо будет на активные ссылки (те на которых мы сейчас находимся), просто отменяется действие по умолчанию (т.е. при нажатии на ссылку не будет перезагрузки этой же страницы)


Remember that this document is an rst in sphinx_doc branch that has been modified. Now they are diverging.


This is not the correct license header.


Great, thanks!


Instead of needing to put CLSCompliant=false on all the types just put it in the project file. There isn't any real need to have this library CLSCompliant.


@ArsenShnurkov https://devmanual.gentoo.org/ebuild-writing/eapi/

easy can be googled by "gentoo usex" for example though


Неверно. value, который введен в поле это у input type="text" или input type="password", textarea, а в данном случае, это значение которое отправится на сервер. На сервер отправятся пары ключ=значение в нашем случае name=value


What file do we expect to not be found?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (387 of 391 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.98%25-yellow.svg)


Декорируются одинаково) Я же не настаиваю) Я просто написал, что возможен такой вариант. Я использую его, потому что он короче)))) и не нужен закрывающий тег))))


Откомментировал!


This should still be CompositionContainer as opposed to var.


??? What are we catching all and then re-throwing?


This method should probably be renamed to GetCompoisitionHost.


If we still plan to keep an AssemblyInfo.cs file then we should probably keep the old strings here.


The Dark Steel quest in Chapter 3 has an unfinished task and needs a reward applied.  Chapter 2 is pretty light on quests, and definitely needs some food preparation quest work.  Chapter 5 has the starter quests available but they don't lead anywhere, yet.  I'd like to find out if I can make quests invisible if Faction is less than a certain amount.  If not, I can make them invisible until they complete a quest in the magic line that gets them to the desired faction rating.

Other than that, just need some proof reading on the quests I completed.


Why did this change from private to public?


Du bist nicht mehr in einem Namespace :)


Why private -> public? is this because of the MEF change?


+testing for the github repository...


NOTE TO SELF: This is actually supposed to be 152. My mistake.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (381 of 385 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.96%25-yellow.svg)


yangbingxing


增加注释


testing purpose..


hahahha


Думаю скобки тут нужны?


Haha, sorry mate. No idea why that specifically was commented out. I have not written any Haskell in months anyway though :(


Script is no longer working for me in Discogs ;(


Can you say some more.


Pressurestat (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2088 of 2088 tests passed, 0 test warnings)

 * 6 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


rename


rtutyuuy


fadsf


A couple of notes for polishing up the polish, tomorrow AM
* should mention at the top of this section that this should not be used without handling the obvious edge case browsers, this hotness is not going to work on ie 8 and 9
* run through strategy of custom validation using regex
* method of adding classes/checking classes to determine if all valid and ok to submit
* describe how to set a pending class (or state) for async calls to 3rd party validation services


Looks like when you moved the MINECRAFT_HOME environment variable, it made it not available during a build. Adding that back into the Dockerfile corrects the issue


Pressurestat (lgu1234) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


ss


哈哈哈，傻逼！


hello


Hello


Also this script is no longer working for me (Firefox 43.04 - wait a moment - as of typing, when search in About box, Firefox started to download update... will try again with updated version). * I get this message "mb-enhancer.js loaded - version 1.2"  and a blank page.


 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:679](../blob/579636f8042bf3193989797225ee8558e7170d8d/include/chaiscript/language/chaiscript_parser.hpp#L679) Expression is always false because 'else if' condition matches previous condition at line 677. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:683](../blob/579636f8042bf3193989797225ee8558e7170d8d/include/chaiscript/language/chaiscript_parser.hpp#L683) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/579636f8042bf3193989797225ee8558e7170d8d/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/579636f8042bf3193989797225ee8558e7170d8d/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 683. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:1786](../blob/579636f8042bf3193989797225ee8558e7170d8d/include/chaiscript/language/chaiscript_parser.hpp#L1786) The scope of the variable 'ranged_for' can be reduced. (variableScope)
 - __information__: [src/chaiscript_stdlib.cpp:1](../blob/579636f8042bf3193989797225ee8558e7170d8d/src/chaiscript_stdlib.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __information__: [src/main.cpp:0](../blob/579636f8042bf3193989797225ee8558e7170d8d/src/main.cpp#L0) Too many #ifdef configurations - cppcheck only checks 12 of 13 configurations. Use --force to check all configurations. (toomanyconfigs)
 - __information__: [src/main.cpp:1](../blob/579636f8042bf3193989797225ee8558e7170d8d/src/main.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/579636f8042bf3193989797225ee8558e7170d8d/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/579636f8042bf3193989797225ee8558e7170d8d/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/579636f8042bf3193989797225ee8558e7170d8d/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/579636f8042bf3193989797225ee8558e7170d8d/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/579636f8042bf3193989797225ee8558e7170d8d/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


asasasas


My apologies about the reversions I was trying to change my commit comment


Comment


I cannot tell whether "encoding" is specific to CSV according to https://cloud.google.com/bigquery/docs/reference/v2/jobs#configuration.load, so double check...


Extra "operation" in both error messages


correction


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-AddressSanitizer: OK (3007 of 3043 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.82%25-yellow.svg)


Can you make the title the same as this?


add_ranged_for (lefticus) - i386-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


add_ranged_for (lefticus) - Win64-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


`t =>`


add_ranged_for (lefticus) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.26%25-red.svg)


add_ranged_for (lefticus) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.26%25-red.svg)


@kamilkisiela hey dude how many coverage it have after this commit?


It's possible, i don't have debbuged for now .... to busy with childs. :)


The minimum version of Windows required to build/run rustc is Windows 7 which supports hard links and hard links don't need administrator privileges.


@mcdonnelldean I'm pretty sure it works in a `seneca.ready(() => { //here }`.


Why is this an option at all? Just only use https:// :)


去掉svn版本资源


asasas


Hi,

I was wondering why did you changed to this as I can't compile with **@LIBCURL_CFLAGS@** in the Makefile.am. Using WIndows 10 64bit, Mingw (latest I guess), GCC v4.3.3. I am getting this error:
`gcc.exe: @CPPFLAG_CURL_STATICLIB@: No such file or directory`

Thanks,
theLosers106.


aaaaa


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: OK (381 of 385 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.96%25-yellow.svg)


Great!


Pressurestat (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (956 of 956 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.85%25-green.svg)


So why is THREDDS faster?  Isn't doing the same network call (albeit to a local process) and data conversion?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13626](https://teamcity.mesosphere.io/viewLog.html?buildId=118441&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:08:41


Thanks for refactoring this.

The graph that I get with some tools (I forgot their name) showed a very tangled mess of interdependencies. I guess that we should work a bit more on that soon.


Great documentation! This is superb!


xcxc


What's the reasoning behind removing default:nil?


Great work and an even better commit message.

This is the kind of commit that I love to see when I read a project's history!


Future Chef 13 warnings


It works


What's the issue with use_automatic_resource_name?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-NoThreads: OK (381 of 390 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.69%25-yellow.svg)


aaa


dsadss


Great work.

I'm being paid to work through this specialization and I saw some links in the next course needing redirects (at least when seeing them on my browser). I wonder if `requests` will follow the redirects for us automatically (I hope so).

Once again, amazing work.


Thanks a lot!


greppability


The old code would put x == 0 to bin 0, but x == 0 + infinitesimal to bin 1.
it is close to numpy.digitize(... right=True).

But notice that before numpy 1.10 digitize is a linear search and very slow -- what about using searchsorted instead?


Hmm I saw a discussion on that. I think there was talk about being able to use nil somehow still? My only concern is docker uses nil and trying to keep the API calls matching between the cookbook and CLI.

Heading to Cabo tomorrow so I'll take another look over the discussion on it while at the airport.


Mi4 LTE's raw id is 1972, I think this line need add $RAW_ID == 1972 so it can remove nfc on Mi4 LTE too. @jrizzoli


yeah, deleted in https://github.com/JuliaLang/julia/pull/14777/files


Excellent detective work.

BTW, If you have suggestions on how to improve our travis config, I'd love to know. All that I have seen are examples and I don't know a grammar of what is expected to be fed in `.travis.yml`; for instance, I don't know exactly when lists are expected or lists of lists are expected (in particular, in the matrix section).

@iemejia, @mxamin, others: opinions?


nil is the effective default anyway when undefined

On Sat, Jan 30, 2016 at 2:22 AM, Chase Bolt <notifications@github.com>
wrote:

> Hmm I saw a discussion on that. I think there was talk about being able to
> use nil somehow still? My only concern is docker uses nil and trying to
> keep the API calls matching between the cookbook and CLI.
>
> Heading to Cabo tomorrow so I'll take another look over the discussion on
> it while at the airport.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/chef-cookbooks/docker/commit/b743e8b609c9fd809399e19d2f4e164a24226e22#commitcomment-15778682>
> .
>


Yes the logs should always be relative to the root path.


Excellent refactoring!

I guess that we need a similar one for the mess that is `coursera_dl.py`.


The `@subpackage` tag is deprecated in draft PSR-5.
`@package Alpha\Templates` indicates that this is part of Templates in Alpha.


Ok well that satisfies my requirements then


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (387 of 391 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.98%25-yellow.svg)


This is required for the way I have set up ARTIQ here, and does not break anything AFAICT.


Another great refactoring!


sorry for the language, our front-end developer is still developing his vocabulary


Excellent work!


Km


Much nicer naming.


apologies for the politically incorrect mental disorder comment, our front-end developer didn't think about this one for too long


I like the simpler, more explicit coding.


Great!


Great work!


On 30/01/16 06:32, Ivan Novick wrote:
> Is GIN index enabled in MASTER?

postgres=# create index foo_gin on foo using gin (t);
ERROR:  GIN indexes are not supported

Nope.

- Heikki


Correct, thanks


You're renaming an variable!


I would like an application with few and small options (run easily from terminal). I will also change this option as a vector<int> in order to generate a set of partitioned mesh in "odir" directory.


how to run the script.?
I installed tftpd64 ..
I splitted the bin file with dd
I am at the last phase of running tpft to upload the firmware into the router...
Your flash is great but how to upload it?
Thanks


cool!


Fleur-de-lis Trail
@ua747sp, I bet this might be more useful for you than HilRd. Yes? :D


I think I want to flip this function around a little to make it clearer


Yes, I have a mental note on fixing that and some copyright years I forgot to update.


This looks like a totally different test case even if it triggers the same issue. I would prefer if we left the fuzzers as is and added new reduced test cases to test/{Sema,decl,type}


@Ignotus-CN （我们到底为什么需要这个……）


It works...


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (387 of 391 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.98%25-yellow.svg)


Did you mean to put 'var' in the declaration, instead of changing the indentation?


Yep! Thank you for that.


Looks like you added back an overload we removed.  Please remove it.


Used the following script to generate these .ps1 files from the .psm1:

```PowerShell
(get-content F5-LTM.psm1 -Raw) -split '\nFunction ' | select -skip 1 | ForEach-Object {
    $FunctionName = [Regex]::Match($_, '^[^ {]*').Value
    "Function $($_.Trim())" -replace '\r\n',"`r" -replace '\t','    ' | Out-File -FilePath (Join-Path (Resolve-Path '~\Source\Repos\POSH-LTM-Rest\Public') "$FunctionName.ps1") -NoNewline
}
```


Hi guys,
below are my potential interviewee and interview questions

Potential Interviewee:
Name: Yongai Xu
Occupation: financial analyst
Available time: after work, around 6 pm.
Working location: down town, near Mcgill campus

Working in the field of finance, she's dealing with numbers and calculations and uses calculator frequently every day. So she has a lot of experience with using calculator and has some own opinion on it.

Potential Interview questions:
1)	Does your career need you to use calculator frequently? If yes, how often do you use it?
2)	What functions on a calculator do you use most?
3)	What kind of calculation do you use your calculator for? Simple operation or complex equation?
4)	Would you prefer to use a calculator that display an answer every time you enter a calculation step or a calculator that takes the whole equation and delivers the final answer directly?
5)	How many digits to the right of the decimal point do you need normally in your work?
6)	What's the range of order of magnitude that you regularly deal with in your work?
7)	What features on a calculator that you are not happy with during your daily usage?
8)	Do you tend to use a physical calculator or a calculator app on a cell phone or computer?
9)	When you're working on your computer, if you need to use calculator, which option will you chose? a) calculator software installed on your computer b) online calculator c) calculator app on your cell phone
10)	Do you need a remember function on a calculator in your work? If yes, normally how many numbers do you need a calculator to remember when you do your calculation?
11)	When you chose a calculator, does the style of the interface (color, font, shape of the icon etc.) influence you?
12)	Is a calculator with self-customizable user-interface appealing to you? / To what extend would you like to customize your calculator
13)	When you're off work do you still need to use the complex functions that you use in your work?
14)	Would you prefer a calculator that is capable of switching between simple and complex mode? If yes, do you prefer to conduct the switch through clicking an existing icon on the calculator or through other gestures (eg. place the cell phone horizontally)


Why reduce the indentation?


Didn't you mean to put the 'var' in the declaration?


Looks like you don't really need this binding.


We should keep these variables in constants file right ?


I wonder if the shader compiler should do this, with desktop Opengl I know sometimes it works sometimes it doesn't http://stackoverflow.com/questions/18557694/glsl-shader-not-unrolling-loop-when-needed#comment27302112_18557694


1. 前后关联的话，函数参数可以设置一个标志参数来解决
2. 注释中的空行也作为注释，也可以另外新增一个统计指标


VyosFwRpcManager name should be renamed to FwBasicConfigRpcManager. Right ?


This scope doesn't introduce any benefits, as it contains only one expression. Could you assign the expression directly?


Nothing to see here.


In the old fw agent code, for topic name is 'FIREWALL-sm-topic' ? Are we changing topic name here ?


Me plz.


echo*ing* in file clears the previous contents of the file, I think you need to concatenate, don't you?


This topic is to receive rpc from Config Agent right ? Earlier it was OC_FW_AGENT_TOPIC = 'oc-firewall-agent'. Please verify this once


Just one observation: can you use longer names for the variables and document the purpose of the snippet of code above in a future pull request?

This will make the maintenance easier. I can understand the code today, but now a few months from now...


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Having an explicit `StoreId` (or, in this case, a function which returns a `StoreId`) would be more expressive, and give us the freedom to replacing the actual implementation of `StoreId` in the backend without having to rewrite this.


`filters` might not be always identical. See the following case: https://github.com/gatorsmile/spark/commit/0b128a90eb792aefe9ddc823f35cc2f43eac3e80#diff-75164dfeac2c1507ae828d2ba5529470R184

As you said, we can simplify it. The callers does not need to specify the `sortBy`. We can generate it automatically. Let me fix this part.


I think this shouldn't be a "binary" addon, but a kodi.resource addon that can be installed (and hopefully be depended on by) from addon manager.


These functions are implemented for ASAV only. Need to see how to implement here


update Bitdeli


oh. cool. i was in a branch. that reminds me.. i need to set up git aware prompt on my personal laptop. :)


why mb_strlen instead of strlen ?


das ist aber schwul


Should not raise the exception. Log error and say event done and keep the event in ResponseEventQ also. Right ?


Same as above, log error and enqueue the event with fw status as ERROR


Marconi Trail, rather.


This was a mistake.


合并多个txt文件于一个文件


* Añadida nueva funcionalidad en la conexión para conectar con el Docbroker y nos devuelva la lista de Repositorios disponibles


This function is awfully long and nested. Care to split it up?


Jst learning


I believe there was a conflict around here so I just opted to break it out since I'm going to make the warning -> error change momentarily.


OK - thanks.


Ahh, never mind. #still a noob


This should be (context or firewall) right. ? We should log error if either of them is not available


add_ranged_for (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Do u want to say (floating_ip and vendor) here ? Also plz change condition to 'or'  instead of 'and'


add_ranged_for (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


So, Matura is going to take a snapshot of the `error_reporting` value when you initialize it. Your modification is using the live value, which may be modified during test execution.

Looking at the PHP docs here: http://php.net/manual/en/language.operators.errorcontrol.php it appears that what PHP is doing when you use `@` is momentarily setting the `error_reporting` value to 0. Ideally, Matura uses a fixed value that isn't affected by the code being tested.

I think to be strictly compatible with the previous behavior, an `allow_error_supression` flag could be added and propagated to the error handler which when it's [initialized](https://github.com/jacobstr/matura/blob/393e0f3676f502454cc6823cac8ce9cef2ea7bff/lib/Matura.php#L97) via the Test [command](https://github.com/jacobstr/matura/blob/393e0f3676f502454cc6823cac8ce9cef2ea7bff/lib/Console/Commands/Test.php#L144).

`error_reporting() === 0 ...` becomes `$this->allow_error_suppression && error_reporting() === 0` at which point I think it's golden.

It's possible that a regression may result in Matura logging the error as a failure without stopping execution. Instead of the check on #L222, we could verify that `$ctx->suite_runner->getResultSet()->getFailures();` is empty - as per similar tests in the file.

Otherwise I think this is a nice, subtle use case and appreciate the patch :) I'm curious how you came across the project?


Pressurestat (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1507 of 1507 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


add_ranged_for (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-AddressSanitizer: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Could you expand the commit message to explain why you did this?


I believe we can delete the last file "src/pemberley/Pemberley.java" because this is just a test file. A new main.java file can be created in NB pretty easily. - sw


@kentcdodds Hey dude i really need your feedback about this, after 2 weeks stuck i found the error which demonstrated [here](http://jsbin.com/lotito/edit?js,console,output). If this is ok i will make PR, if not give me feedback i will revise it, i really want make PR to formly then merged. i just realize that being open-source contribution is really awesome :smile_cat:


add_ranged_for (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


add_ranged_for (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-NoThreads: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


add_ranged_for (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


add_ranged_for (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Not better, but I will fix it myself


Cherry-picked into master as 67df983bb8ad29a5fef9083310a1ff472dc71cb3.


❤ _David liked your comment_


Should not raise exception


Same as above, should not raise exception


Ok, will test it...


doClose不生效吗？


You use this function in code committed before this. It would be nice to reorder the commits so that this function is already declared at that point?


Plz remove raise exception statement


:heart: *Dmitri liked your commit*


If you want to submit a PR I'd be happy to merge this into the main repo.


インデント揃えておいてー！


Lets add try except block here. So when exception us raised it will be caught here and also firewall status can be changed to ERROR and finally say event done


не) Я имел в виду, что основной шрифт "PT Sans" (это его название), далее идут альтернативные шрифты, а в конце — семейство шрифтов.


так что жду ещё поправок)


连接工厂是静态化的，而NettyClient是多实例的，当一个实例close的时候 bootstrap释放会释放静态共享的连接池。
应该在所有client关闭后再释放连接工厂，最后释放。

对应51行的注释，所以doClose不能直接将bootstrap 释放.


A better way to get the ASTContext here is ```tc.Context```


Hi irmgrx, I'm very like your Agar Tool to use for my clan. Please update your chat & team map smooth. Some time we has Disconnect team and lagging delay/ freeze when Split. Thanks you for dev good agar team tool.


apakah `itu` ?


single-quotesは「単一引用符」が普通かなと思います。


add_ranged_for (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


add_ranged_for (lefticus) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


changes


変更部分について確認しました。


Java class file.


This comment doesn't match the code; you only check for overlap.


Nvidia Shield Tablet: http://forum.xda-developers.com/shield-tablet/development/rom-temasek-s-unofficial-cyanogenmod-13-t3303843


Java source file


Damn I missed my chance
On Jan 30, 2016 5:21 PM, "Trafalgar-Square" <notifications@github.com>
wrote:

> Nvidia Shield Tablet:
> http://forum.xda-developers.com/shield-tablet/development/rom-temasek-s-unofficial-cyanogenmod-13-t3303843
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/temasek/android/commit/86968597412b6a9c1954d8cd1e83ab8b100d855c#commitcomment-15778902>
> .
>


Given that `rgb_cmap` basically redoes everything that the constructor did, I think it's better to make it an abstract method that constructs a ColorMap.


Shouldn't this be `c >= 1`?


Now that we have merged your refactor of `_plot()` and `_plot_concat()`, this belongs to _resolve() in `StaticPlot`.  Can you rebase this on top of master and fix it?


Reserved for arter97


@floridemai yes and not. We are using Vidi/Concorda in the following way:
- one base mesh node
- Concorda - which exposes over mesh the {role: 'user'} actions
- Vidi - which wants to register the user

So seneca.ready in Vidi might be OK to let us know that Vidi is connected to mesh (I will test it) but do not let me know that Concorda is connected or not to the mesh. Only when Concorda is connected I should try to register the user from Vidi. So we might need something else here, a mesh notification that new patterns are available or something like this.


Yay!


Lol no
Go for it. I'm not yet interested in CM for my K1.
On Jan 30, 2016 5:24 PM, "Janson Kang" <notifications@github.com> wrote:

> Reserved for arter97
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/temasek/android/commit/86968597412b6a9c1954d8cd1e83ab8b100d855c#commitcomment-15778910>
> .
>


добавлен код для шифра Виженера-Тритемия-Кардано (лаба 2);
шифр Цезаря перемещен во вкладку "Курсовой проект. Симметричные алгоритмы";
Подсчет энтропии вынесен в отдельный класс;


This looks good and tests well. I committed this to the main codebase.


I just committed your commit with split change and the static change to the main codebase. Let me know when you are done testing your deprecated constructor commit.


@lactem - basically I think thats a correct assumption, there's a handful that buy every time they can and the max amount, but there's still a select few in that, that win more often than those who also buy max.


Let me know when you are done testing this commit.


Reserved canceled. Lol


I'd like to know what this header does. Especially the `token realm` part. :smile:


html


Also @Lactem - thanks for keeping up the fork, I didnt want to do it and my team is really busy, hopefully you'll pick up other things


Just thinking that this could be in a `do...end` block. As a `styling` convention.


%red.exe should not be appended to the file path. Because due to the encapper issue, I have the file named red-exe.exe . Someone else might have it with some other name.


my file


ResortedSurfaces (amirroth) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2061 of 2088 tests passed, 454 test warnings)

 * 334 tests had: DXF diffs.
 * 381 tests had: EIO diffs.
 * 460 tests had: ESO small diffs.
 * 357 tests had: MTR small diffs.
 * 481 tests had: SHD diffs.
 * 6 tests had: AUD diffs.
 * 42 tests had: Table small diffs.
 * 15 tests had: Table big diffs.
 * 19 tests had: ESO big diffs.
 * 24 tests had: ZSZ small diffs.
 * 21 tests had: SSZ small diffs.
 * 6 tests had: MTR big diffs.
 * 12 tests had: ERR diffs.
 * 22 tests had: RDD diffs.
 * 3 tests had: ZSZ big diffs.
 * 1 test had: SSZ big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.71%25-yellow.svg)


Currently there won't be an error on duplicates, but the duplicates are silently dropped.  Come to think of it, that's necessary to protect security of personas (or the service could probe for personas that belong to the same user).  I'll fix this in here.


Thanks @desalesouche :)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13631](https://teamcity.mesosphere.io/viewLog.html?buildId=118500&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 218 Build time: 00:08:43


Yes of course. I had thought about it as well. Shall I create a new pull request?


Niiiiiice.


I am going to make this a bit more rigorous.  See upcoming commit.


@fengmk2 这次是失误了，下次走 pr


Hm.  Changed my mind.  I thought this an internal issue, but html is exposed to the rest api.  I'll leave it as is then.


Sorry, it doesn't look good - Route class should be very abstract, away from React and Navigator implementation. So please pass needed property within ExRouter class that is bridge between Router/Route and ExNavigator.


ResortedSurfaces (amirroth) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


嗯，如果今天我还没发布，你微信提醒我，我给你owner 权限


how to reproduce bug:
two users: 1 and 2
1 connecting to chat (clientId == 1)
2 connecting to chat (tempid <- clientId == 1, so @clients[client.id] = client is @client[1] = client)
error: first user is overwritten by second


I just want to note (maybe other people will the same issue) that this change means .gitignore entries must be relative paths.

A lot of the .gitignore entries on Vidio are absolute **from the project root**, and that seems to be common; [github's example](https://github.com/github/gitignore/blob/master/Rails.gitignore).

so
```.git
/.bundle
/.vagrant
/.zeus.sock
```

needs to become
```.git
.bundle
.vagrant
.zeus.sock
```

For `ag` to ignore it.  I don't know why that is exactly... running the raw `ag %s -l -i ...` command doesn't include the .gitignore'd files


`percents`


I'm OK for doing the Classic backports, but I'd like to have push rights  to ACID first because doing and handling dozen of pull requests will quickly become very annoying for everyone. ;)


`;` on a different line is more visible...


this is not equivalent to old code with `genForBBox=false`, why?


What is this?  This looks wrong.


今天是 16年1月30号


Marcel,

The new skin settings are amazing.  Awesome work - Wow.

The only issue I saw was the bordersize for focused and unfocused thumb/tiles was not populated (displayed) in the skin settings display (once I selected and chose an option it was)

and maybe a cosmetic issue - when I am using the arrow keys to move past the "play tv theme songs..." in Media library views the toggle moves to enabled when highlighted and then back to my setting of disabled when I move past/off it.

the new custom color section is great - so much easier to use when working on a new (or old color theme).

you rock sir!

Thanks :)

Mario