@franzliedke In this specific integration, the Flarum password is randomly-generated when a new WP user signs up.

@Luceos Nope, it just expires the `flarum_remember` cookie. Good point though. There's no API endpoint to invalidate a token currently. And the /logout route requires a CSRF token. Maybe it's worth making the /logout route accept an `Authorization: Token` header without the need for a CSRF token, that way the cookie can be unset directly. Same thing for the /login route so we don't need to use the /api/token endpoint at all.


no, know we will have to update this test every time we cut a release, its just annoying more than anything else.


As far as this change is concerned, shouldn't this all happen only for a non-anonymous endpoints and for every other endpoint including the default bridge network endpoints shouldn't we retain the old behavior? I think the same comment holds true for when we try to setup the resolver and start the resolver. It should only happen for non-anonymous endpoints I guess. That would be a general comment as a whole. I don't see any code to check for that.


This log message confused me when trying to [debug the notifications](https://bugzilla.mozilla.org/show_bug.cgi?id=1237035).

It is false. This is just the entry point of a click handler. This function can exit early without actually "sending message"


approve


I'm not sure how to test it or what this means in practice.  Since you're the expert in this area, can you please go ahead and do what you think is right?


This test case was not just checking for /etc/hosts content but it was checking our svcRecords caching logic. Since we are retaining the caching logic I don't think we can remove this test altogether. It may have to be adjusted for the change in design.


Perhaps missing

    setMaxTimeBin(maxTb)


This looks wrong.


more_clear_state (mbadams5) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


This commit was a mistake and was replaced this commit with https://github.com/adufilie/flex-falcon/commit/6d72b8b7dbcf15055a378acb0b919062561cf39a in the patch.

This is generating ActionScript code, and in ActionScript you can define a public toString() without using the AS3 namespace.


If opam is not available, this will probably cause failures later on. The following checks the variable doesn't end up empty.

    ifeq ($(LIBDIR),)
    $(error Without opam, LIBDIR must be set manually)
    endif

Also, if you want, you can provide the same defaults as before for when opam isn't available:

    LIBDIR ?= $(shell opam config var lib 2>/dev/null || echo $$(ocamlc -where)/..)


Thanks!


This probably could have just been typed as `protobufLocator` and not need the interface. Still reading though.


IIRC, you have to do the basics on the automation, but then expend a good
large number of hours tweaking and optimizing the output to do a fair job.
The thing, If I get this correctly is: Yasim does a better out of the box
simulation, but JSBsim allows you to manipulate much more of the FDM
parameters in a finer way. So the long run of JSBsim pays off, but, the
off-the-box product is really underscored.

IH-COL

On Tue, Jan 5, 2016 at 12:33 PM, Jan Hudec <notifications@github.com> wrote:

> @legoboyvdlp <https://github.com/legoboyvdlp>, yes, I found it now. It
> does look better (asks more parameters, too), but it still does not seem to
> estimate all phenomena YASim does.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/FGMEMBERS/737-100/commit/2b7a17738ad58f225792ff316c7c12e92a97eb33#commitcomment-15273977>
> .
>


Плохая практика передавать функции изменяемый массив и изменять его, даже если ты этот массив возвращаешь. Да и название как то не соответствует тому что функция возвращает, да и уверен что в джанге всё уже есть для выполнения подобных действий.


CC @fred-wang


I'll add a FIXME, thanks!


It is still not changing the values in Elgato EVE when it updates values.


Many casual modpack players probably don't know how to use OPIS.

Suggest amendment to the effect of "if you don't know how to get this, give logs instead."


TeamCity Open-source Libraries :: ConfigInjector :: CI [Build 2.0.443.0](http://build01:8888/viewLog.html?buildId=13761&buildTypeId=ConfigInjector_CI) is now running


LGTM

Is the WeakPtrFactory really needed given that g_core is leaked? Can't we assume that the Node instance never goes away?


TeamCity Open-source Libraries :: ConfigInjector :: CI [Build 2.0.443.0](http://build01:8888/viewLog.html?buildId=13761&buildTypeId=ConfigInjector_CI) outcome was **SUCCESS**
Summary: Tests passed: 38 Build time: 00:00:37


LGTM


SZVAV-Fan-Control (rraustad) - x86_64-MacOS-10.9-clang: OK (1980 of 1980 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Are there plans to eventually make this an actual error instead of relying on people seeing this in generated code?


With the (void) tls/dtls, why did you put tls in the block, and why not move the first (void)dtls to just after the conditional-block where the unused assignment is made?


Or in general if you can't provide the following basic information you shouldn't be playing a modpack...


Bleach crash sur le menu maintenant c'est normal ? :/ pile au moment ou il doit affiché les personnage 3d


ich habe bei mir ein "getConfig" eingebaut. Es liefert zurück ob die messagetype enable oder disabled sind, in der folgenden Form:
MSenable, MUdisable, MCdisable

In der  RF_Receiver.ino habe ich folgendes zugefügt:

void getConfig();
void enDisPrint(bool enDis);

Am Ende der void HandleCommand():
  // get config
  else if (cmdstring.charAt(0) == cmd_getConfig) {
     getConfig();
  }

void getConfig()
{
   Serial.print(F("MS"));
   enDisPrint(musterDec.MSenabled);
   Serial.print(F(", MU"));
   enDisPrint(musterDec.MUenabled);
   Serial.print(F(", MC"));
   enDisPrint(musterDec.MCenabled);
   Serial.println("");
}

void enDisPrint(bool enDis)
{
   if (enDis) {
      Serial.print(F("enable"));
   }
   else {
      Serial.print(F("disable"));
   }
}


I'll change it totally. And no, it won't support meta

> Am 05.01.2016 um 21:53 schrieb XxDXM-hippiexX <notifications@github.com>:
>
> Awesome!  can you make it so it supports ids like 17.4: false?
>
> —
> Reply to this email directly or view it on GitHub.
>


Is this needed?


I have never used OPIS and would probably have to find instructions for it, but I can read crash reports and understand them to some extent.


Тут вообще что то страшное происходит. Что это :smile:  :question:


Since the only difference that could have a sensible effect is:
```
sw/airborne/peripherals/mpu60x0_spi.c
179:      if (mpu_spi->config.nb_slave_init < mpu_spi->config.nb_slaves && mpu_spi->config.nb_slave_init < MPU60X0_I2C_NB_SLAVES) {
```
can you try to modify it to only have
```
      if (mpu_spi->config.nb_slave_init < mpu_spi->config.nb_slaves) {
```
like in @flixr commit ?

Did you see anything else not working ? only uplink is failing while telemetry downlink is working ?


Not sure, but this seem to break alignement of save/publish action buttons at the bottom of the cms by adding a "field" class to the ``<fieldset>`` tag

<img width="364" alt="capture d ecran 2016-01-05 a 22 02 07" src="https://cloud.githubusercontent.com/assets/11061711/12127525/ff72b4d2-b3f7-11e5-9d39-bd89825970fc.png">


Too bad it's my work email address


for the sake of testing, can you change all the `window.` to `$window.`?


wieso machst Du nicht mal ein commit?

cmd_getConfig muss ja auch definiert sein, damit es klappt.


The CoFH_at.cfg probably shouldn't be here. I hope I've not gone and done anything wrong by including it.


https://github.com/ZoneMinder/ZoneMinder/blob/master/docs/conf.py#L104

I build a deb off 1.29.0 the other day, I was screwing around trying to upload to my ppa and didn't finish it but binary build didn't complain.


I don't think it's a stable API just yet. I think we should have the @Unstable notion also on UIX because for the same reason we have them on APIs: it's just too hard to design an API with iteration. In any case it's just been introduced recently and I feel it should be ok to break it at this point.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10752](https://teamcity.mesosphere.io/viewLog.html?buildId=100450&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 207 Build time: 00:04:05


Can you also add the corresponding translation strings in `app/locale/en.coffee`?


Well getStartPath is usual the path of the executable or set by '--http-path'
but it is also used by Ssdpserver.cpp to store the bootID.

My point is the naming is not correct anymore.. I think.

But you made a nice solution for storing the files.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10753](https://teamcity.mesosphere.io/viewLog.html?buildId=100451&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:06:51


Wow this is great, thanks for the pr. I'll test this and get it in asap. I'd just like to warn you though that this isn't the offical drupal project. I sent a request on drupal.org to find out the status of the module maintainer but have not heard back. I would like to eventually get this back into the main project or become a maintainer but I haven't not created a plan or gotten a response from the owner of that project. https://www.drupal.org/node/2388873

Like I said, I'm very happy for the pr and I plan on using this as long as it's needed but I wanted to give you fair warning about the non-existent community path.


This is a bit confusing for a couple reasons. First, pointers to interface values are rarely used like this. The exception is when you pass in an initialized value to something that is decoding a value into it such as the following:

```go
// assume arbitrary bytes
b := []byte{...}

// use interface value since we don't know what we are getting
var v interface{}

// pass a pointer to the value (location of memory) so the unmarshaler
// will populated that location.
if err := json.Unmarshal([]byte(`100`), &v); err != nil {
    log.Fatal(err)
}
```

In this case, you are initializing setting `io.Writer` based on what `out` is. It is more idiomatic have a function that returns an `io.Writer`:

```go
func createOutputWriter(out string) (io.Writer, error) {
    // logic
    return w, nil
}
```

Also there is no need to have a separate `io.Closer`. Either you expect the `io.Writer` to be *closeable* in which case `createOutputWriter` should return an [`io.WriteCloser`](https://golang.org/pkg/io/#WriteCloser) or it is optional in which case you can do a type assertion on the value assigned to `writer`:

```go
// Attempt to type assert the underlying value of the writer as a io.Closer
// so you can call Close().
if c, ok := writer.(io.Closer); ok {
    defer c.Close()
}
```

This applies to the functions `addEncryption` and `addCompression` below. Those functions should be easily composeable. Ignoring the fact that each function returns an error, it should theoretically be as easy as:

```go
writer, err = addCompression(addEncryption(createWriter(out), keyPath), initComp)
```


That's a lot of code to run the container with a different user, while I understand the motivation to do so in some cases, is it really that important for a development image of Caffe?


Why do you need to substract timeAlreadySpent? To make timing more precise?


A `"tabs"` permission triggers scary warnings on [Google chrome](https://developer.chrome.com/extensions/permission_warnings#warnings) and should be avoided at all costs.

In fact, it is not really needed here as it only gives access to ['priviledged' properties on a Tab object](https://developer.chrome.com/extensions/declare_permissions#tabs) which are obviously not needed here.


If you intent to ignore an exeption you should add a comment  and don't need to print the stack trace.

Something simple like:
`// Ignore Exception`


I wouldn't break this code into a function here---this function isn't called anywhere else and the code doesn't look that complicated to my eye.  That said, if I were to do it, I'd probably create one function that's called twice, once for the keys and once for the items.  It's not a huge issue either way.  Note that when I refactor the node constructors, I'm going to have to change this code again, and from my perspective I'm most interested in at the moment making the code easy for an automated refactoring tool, not easy for a human to read, until after I do that.


A good practice is to declare all the variables at the top of the method.


this is serious proof I should not be even touching Instrumentality
actually, scratch that - this is serious proof I should have my invisible granted-by-default programmer's license removed


Hey @alecdwm, I've looked into your concerns.

Could you explain how it breaks the OSX build?
It feels a lot cleaner and more reliable using SDL to retrieve information.
As for error checking, github.com/kardianos/osext actually doesn't report errors on some systems....


I will follow-up on these requests - however, keep in mind that some of the changes that exist are only because of "beautifying" and pre-existed.  I plan on doing actual code refactoring after this defect is fully validated and resolved.

Annotations left for queries are still required, where left.  Only the repo functions related to a "maximum change date" were moved to use SpringBoot query syntax explicitly.


Avoid using System.out to debug things. Setup a proper log system to do it. http://developer.android.com/reference/android/util/Log.html


I will remove the comments as suggested


ck values are very low here, but let's see.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10754](https://teamcity.mesosphere.io/viewLog.html?buildId=100452&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:10:13


Avoid two variables in the same line.


I'm sorry, that should read `ritual.BloodMagic.waterRitual=Ritual der vollen Quelle`. I forgot to change that. I don't think it's worth another PR.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1171.4cbfb41da66c507ea5dd1e4a272dc80a00dd6a59](http://build.palaso.org/viewLog.html?buildId=67554&buildTypeId=bt431) outcome was **FAILURE**
Summary: Execution timeout (new); tests failed: 2 (1 new), passed: 813, ignored: 7 Build time: 00:35:32
### Failed tests
```
GlyssenTests.dll: GlyssenTests.ProjectTests.UpdateProjectFromBundleData_BundleDoesNotContainLdmlFile_MaintainsOriginalQuoteSystem: <no details avaliable>

GlyssenTests.dll: GlyssenTests.Rules.CharacterGroupGeneratorTestsWithLotsOfBooks.GenerateCharacterGroups_NumberOfNarratorsMatchAuthors_NarratorsGroupedByAuthor: <no details avaliable>

```


Good catch!


1722-HXAssistSPM (kbenne) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-79.27%25-red.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10751](https://teamcity.mesosphere.io/viewLog.html?buildId=100449&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:12:19


minor nit cause I thought this was an error at first: could you use `k` instead of `v` to refer to the key field cast type?


Meh, worry about it next time there's more stuff to translate


Да конечно ```import *``` - not good, но в данном случае уж лучше старый вариант (IMHO). Кстати, а где сам ```emails.py```. В репе его нет, как быть другому разработчику?


TeamCity pull requests :: netty [Build 975](https://garage.netty.io/teamcity/viewLog.html?buildId=4540&buildTypeId=pulls_netty&guest=1) is now running


Aren't transient always stored in object cache when it is available??
https://codex.wordpress.org/Transients_API


Please, can you explain why we have hardcoded UUID for a beacon here?
Do we need to use regions?


There are some tricks, I usually go nowadays for an already tweaked JSB file instead of doing it all from a basic aeromatic file. But then I have already ground effect and some sideslip effect in it and some other goodies and need only to adapt. Aeromatic is just well, very basic. And of course, if you want to add pishback or a fuel system, JSB has everything to do it in the FDM, no extra Nasal needed.


dead code?


I wouldn't mind a function that's been called twice, although that will mean two passes instead of one and two function calls instead of one. I like this version more than what was previously, I can't get my head around nested for in list comprehensions.


It frees up vertical space so a short comment can be added. :)

"Below we strip the string "true" from the variable $(NATIVE) and if we nd up with the empty string (and therefore if $(NATIVE) is "true"), we prepend $(INSTALL_LIB_OPT) to the ocamlfind command."

My main concern here is really that I've found multi-line escapes in makefiles to be very brittle in practice and I really like to avoid them when possible.

As for what is a gnu-ism, there are probably 3 rules that cover 99% of cases: "ifeq" is a gnu-ism, the "$(some_function ...)" syntax is a gnu-ism and finally, everything that involves logic or is smarter than "if foo isn't up-to-date, then redo bar" is likely a gnu-ism or a bsd-ism (posix make is really barebones).

Also note that GNU make is powerful enough to cover most tasks usually done in configure scripts.

Also, it is actually funny because the most-criticized GNU projects (autoconf/automake) are actually mostly useful when building for non-GNU userlands.


Why do you need automated refactoring tool for this anyway?


It was noted. See [\#547 (comment)](https://github.com/WayofTime/BloodMagic/pull/547#discussion_r48867928)


That's fine by me, @jponge. I don't know where my head was when I was thinking that this should be in Maven Central - Gradle plugins are now [published to the plugin portal](https://plugins.gradle.org/docs/submit). I will ask the Gradle folks to grant me access to be able to publish a new version [here](https://plugins.gradle.org/plugin/org.golo-lang.golo) as the publishing workflow has changed since I last published the plugin.


5156-HeatExchanger (Nigusse) - i386-Windows-7-VisualStudio-12: OK (2002 of 2002 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


As per [MDN](https://developer.mozilla.org/en-US/docs/Web/API/Window/postMessage) it would be best not to use a wild-card origin when the URL is known.


There was some reason why I added this in but I can't remember now :)


Už jsem to začal přepisovat do HTML. A narazil jsem na konec bodu 1) kde máš tři tečky. Nevím, zda by tam něměla být spíše dvojtečka. Já jsem si prvně myslel, že ten bod 1) budeš chtít ještě dopisovat :smile: a teď jsem si všiml, že to znamená, že pak s vyprávěním přecházíš do bodu 2)


Reviewed.


thank you for your answer, you have an alternative?
Le 5 janv. 2016 20:19, "Stephen L. Blum" <notifications@github.com> a
écrit :

> hi! we had customers who reported regressions. we had to revert.
>
> On Tue, Jan 5, 2016 at 9:35 AM, davidjimdo <notifications@github.com>
> wrote:
>
> > why you clear the option to change the media?
> > how do we now change the media?
> > Thank you
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/stephenlb/webrtc-sdk/commit/b9cefc1de27897d5abe67b3b6def172c0fae88bd#commitcomment-15270451
> >
> > .
> >
>
>
>
> --
> Cheers!
> Stephen Blum - CTO
> http://twitter.com/PubNub
> https://github.com/pubnub/pubnub-api - GitHub
> https://help.pubnub.com/ - Help Desk
> www.pubnub.com
> +1-425-830-6711
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stephenlb/webrtc-sdk/commit/b9cefc1de27897d5abe67b3b6def172c0fae88bd#commitcomment-15271357>
> .
>


A pak ještě u bodu 2) máš na začátku toto "tohle všechno je skvělé. Pro webové aplikace.". Tato formulace na mě také nepůsobí dobře. Asi bych to spojil do jedné věty. Co myslíš?


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1172.4cbfb41da66c507ea5dd1e4a272dc80a00dd6a59](http://build.palaso.org/viewLog.html?buildId=67555&buildTypeId=bt431) outcome was **FAILURE**
Summary: Execution timeout; tests failed: 1, passed: 814, ignored: 7 Build time: 00:35:27
### Failed tests
```
GlyssenTests.dll: GlyssenTests.ProjectTests.UpdateProjectFromBundleData_BundleDoesNotContainLdmlFile_MaintainsOriginalQuoteSystem: <no details avaliable>

```


All right. A 2GHz processor executes it is 0.000000000000000000000000 seconds.


I didn't understand the why are you changing the background. What is this suppose to do?


Nice)


@alecdwm, I've looked into it further now,
I believe the issue is that on windows SDL_GetBasePath will return the absolute path with backslashes,
And every other system will return the absolute path with forward slashes.
Error checking is also possible.

Should I write a fix and implement error checking, or just revert?


generated comment, please remove


After reading through this, one recommendation is to encapsulate all of this functionality as fields or methods on the`packer.CompressingWriter` type since it feels like boilerplate. Also it is not apparent at what point the value assigned to `writer` became a `*package.CompressionWriter` value. If that is the type that will ultimately be passed into `makeFilePacker` that does the actual packing, then it should be the primary value be used in this block.


Oh >.> Well meh... You'll need to submit some more stuff soon thanks to all the LivingArmor work Way is doing anyways.


possible better fix

```php
$valid = filter_var($value, FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE);
// Bug workaround PHP <5.4.8
// https://bugs.php.net/bug.php?id=49510
if ($valid === null && ($value === null || $value === false || $value === ''))
{
    $valid = false;
}
if ($valid === null)
{
    $errorMessage = $gL10n->get('SYS_INVALID_PAGE_VIEW');
}
$value = $valid;
```


i think array_replace might be safer here?


Like you said, WP core already applies the same check https://core.trac.wordpress.org/browser/tags/4.4/src/wp-includes/option.php#L629


You're opening then closing the `keyReaderFile` without doing anything?


I would move this below the next constructor, so the constructors are in an order that each adds a single new arg to the end.


Be aware that giving the return values names, initializes them in the function block so you don't have to actually return anything. Personally I think this is confusing and explicit returns are better.


Interesting. I'm thinking of what cascade of defaults could be acceptable. In #41 I stopped trying to access opam variable because of the "failures later on" problem you mention, but with your cascading strategy this may come back. I think that, in decreasing order, the best guesses would be

1. `opam config var lib`
2. `ocamlfind printconf destdir`
3. either `$(PREFIX)/lib` or `$LIBDIR`, I'm not sure which is best. (I thought `$(PREFIX)/lib` was better when I did #41, and it is better in opam-land, but it seems to be a worse guess on Fedora and Debian, so if we tested OPAM first we may as well make a distro-convenient choice)


I'm using similar technic. The reason is that in the future you could easier invalidate when using the object cache. Which currently isn't really possible. You could make the group a variable so then invalidation is possible.


I've fixed the mistake here: https://github.com/adriaanm/sbt/compare/0.13.8-backports...inc-comp-stable-self%5E


don't abbreviate


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10755](https://teamcity.mesosphere.io/viewLog.html?buildId=100454&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:10


I recommend we expand a bit on this point and remind the user that they still can start on user login. We can add this later on.


Please, define [Access level](http://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html) for all class variables.


@Sumith1896 @certik  This line is causing segfault .


Nice catch!! I changed some stuff and forgot to account for that. I think originally I had "exit" in the debug option (instead of shift) but that would break if the order of the args in the command line had `-d` before the other options. I never remembered to go fix it... Ooops!

Love your clean solution! :+1:


THIS is the fixed regex. I need to learn how to git more better.


 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:679](../blob/21048b9e65f89708357519c0667d68f2384103f5/include/chaiscript/language/chaiscript_parser.hpp#L679) Expression is always false because 'else if' condition matches previous condition at line 677. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:683](../blob/21048b9e65f89708357519c0667d68f2384103f5/include/chaiscript/language/chaiscript_parser.hpp#L683) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/21048b9e65f89708357519c0667d68f2384103f5/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/21048b9e65f89708357519c0667d68f2384103f5/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 683. (multiCondition)
 - __information__: [src/chaiscript_stdlib.cpp:1](../blob/21048b9e65f89708357519c0667d68f2384103f5/src/chaiscript_stdlib.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __information__: [src/main.cpp:0](../blob/21048b9e65f89708357519c0667d68f2384103f5/src/main.cpp#L0) Too many #ifdef configurations - cppcheck only checks 12 of 13 configurations. Use --force to check all configurations. (toomanyconfigs)
 - __information__: [src/main.cpp:1](../blob/21048b9e65f89708357519c0667d68f2384103f5/src/main.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/21048b9e65f89708357519c0667d68f2384103f5/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/21048b9e65f89708357519c0667d68f2384103f5/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/21048b9e65f89708357519c0667d68f2384103f5/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/21048b9e65f89708357519c0667d68f2384103f5/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/21048b9e65f89708357519c0667d68f2384103f5/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


I'm fixing this on master https://github.com/zachmayer/caretEnsemble/pull/181


you should update the GenericPageProcessor also


I need to add an option to clean trailing white-space to my Vim config... :X Thank you! :100:


Why are you first storing the address of `syscall` here and not in `munmap_internal`?


delete?


@aeligature  ^


No issue here but makes me think of something that should interest you.

There is no portable way to have "echo" interpret things in its arguments (à la gnu's "echo -e"). The reason is wonderful: the day people tried to standardize on a behaviour for echo, the existing implementations were already behaving differently enough that standardization was hopeless. In order to handle '\n' or anything similar, printf should be used.

Actually, you can avoid some escapes by using simple quotes for the whole string, e.g:

    echo '  "ocamlbuild.byte" {"ocamlbuild.byte"}' >> ocamlbuild.install


virtImageXml function seems to be useless now - why to keep it then?


Please, refactor to a new method


A quick check doesn't find any such cases, but I'm not completely sure. I still don't understand the targeting system very well. Is there a way to make it work in both cases?


This is because the signature of syscall, which is int(*)(...).

mmap returns void* and munmap returns int and the function
pointer trick allows me to avoid the data loss on mmap.


FrSky D4R-II use the green RX-cable on the extra connector
set up on Flip32+ :
- green RX-cable to RC2 -signal
- black to GND on same bank

Gruss


Why 'ls' the directory during uninstall?


Hi Jonah,

The short answer is, not really :)

However if this would be really helpful I can try. I'm still waiting on internal confirmation regarding the Facebook corporate CLA though.


maybe just non-pointer type?


nice solution, i like it


might want to check `message.command` here first


I think this will be painful to maintain.  Maybe we can strip of the last parameter with `params.subList(0, params.length() - 1)`, or maybe have two separate param lists.


Here we have a bug, because result is never set.


Please, clean the code


wfm
https://github.com/npm/npm/issues/5340


What are you doing with the email?


ta oublier un dossier pour le Projet : rpcs3-tests


We track inter and intra search in GA by passing an additional parameter. For this case, it is inter search only so we should add "qInter" param. Please see app/extensions/wikia/GlobalNavigation/scripts/GoogleSearchAPI.js. Because of the additional search param, we can see Google inter search on Japanese wikia in "All Japanese communities (Google inter search)" in GA.


A short trick:

    : > ocamlbuild.install

To be honest, I'm not sure it's worth using because it is quite unreadable to most people (the ':' builtin exists does nothing and here it makes it possible to truncate the ocamlbuild.install file).


Result is null here...


`<Widget>[...]`


replace vegetable oil with canola oil


@borshop retry


We already have an existing error and note; why make a new one here?


Not a problem! some people feel it clutters a PR, so i just didn't know how you felt.

Looks like you can add this to your `.vimrc` to have an auto command run to remove on saves http://vim.wikia.com/wiki/Remove_unwanted_spaces#Automatically_removing_all_trailing_whitespace


fabs(min(dphi,2.9416) will not give the correct result in cases where dphi < -2.9416.  Please fix.


@borshop: retry


changed the title


removed the address


Do you want to make these private and make AsyncCallbackScope a friend?


Remove dead code


Alternatively, a popup has direct access to the global of `background.js` via `chrome.extension.getBackgroundPage` (synchronous) or `chrome.runtime.getBackgroundPage` (asynchronous).


Looks like the "EX:" here was unintentional?


I believe this is only needed in `ifFalse`


We should make images that already tiled. This only has to be done once per image.


You can move the url to a constant for now. But we need a way to properly defined [config constants](http://stackoverflow.com/questions/11150701/which-is-best-way-to-define-constants-in-android-either-static-class-interface).


If you are ignoring this exception. Please, comment it and remove printStackTrace


remove "as"


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10756](https://teamcity.mesosphere.io/viewLog.html?buildId=100459&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:20


Thank you for sharing this amazing job with us Bunny67. I hope that one day you will find some free time and continue your work or even create something new!


I don't remember why I've used such a complicated way to copy a file. Usage of 'scp' here would look better.


SZVAV-Fan-Control (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (912 of 912 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.83%25-green.svg)


Looks good. Note that in `udp-sender.cc`, you could have actually connected the socket to the peer (using `socket.connect( peer )`), and then to send the payload, you could have just written `socket.send( "Hello, world." )`. Connecting the socket is a little bit better because it means you will get better error messages if something goes wrong (e.g. if the peer sends back an "ICMP port unreachable" message to indicate that no receiver application is listening on that port, a subsequent `send` on the same socket can return an error, or with these C++ classes, can throw an exception).


Cascading works but watch out for over-safety and really-long lines of code. ;-)

Also, my system doesn't use "lib" but "lib64". For multilib, being able to append a string is usually needed and for multiarch (which is what you get in at least debian now), the whole path needs to be set by the packaging system, meaning you probably want $LIBDIR.


you can rewrite this as an unconditional get to avoid two lookups:
```java
outputIdentifier.set(dictionaryIdentifiers.invoke("get", Object.class, inputIdentifier.cast(Object.class)).cast(UUID.class));
IfStatement updateDictionaryIdentifiers = new IfStatement()
        .condition(equal(dictionaryIdentifiers, constantNull(UUID.class))
        .ifFalse(....);
```


This should be moved to the Map class, and make an instance of Map to call loadBitmap from. loadBitmap should take in an integer argument (or final value: public static int FOREST_TILE = 1) instead of being random, but this can happen later.


Yes, exactly. (I had the issue during testing as opam will install an `opam.config` file in the package directory.)


@mbellew Does that look correct to you?


Uh... I thought the Map class holds a list of all the terrain objects. Why would it need x, y, width, and height?


I commited a patch to use this quoting suggestion on top of #41: 1ecde89.


Download


This is a work around for node js issue nodejs/node/#4417


For future reference, Job is a new-style class and subclasses of it should therefore use the super() built-in to invoke the overridden method. I've seen more cases like this so we don't need to fix it for this PR.


I'd rename this to something like `getDictionarySourceId` so it is clear what the identifier is for.


I think this should be renamed to HasScrollDirection or some such.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10760](https://teamcity.mesosphere.io/viewLog.html?buildId=100472&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:10


LGTM


That makes sense. I’d suggest moving the `typedef` inside the function and commenting about the return type, since this pattern doesn’t seem to be used elsewhere in Mono.


this weird styling causes scrollbars to appear for me:
![scrollbars](http://i.imgur.com/b0I6Uny.png)

fixed with:
```cs
margin: 0 auto;
padding: 8% 5% 0 5%;
```


this bug is `NaN`obvious at first glance :wink:


You're right, let's keep it your way.


unsplit.


You can't ignore this exception. You should do something, like show an error message to the user asking to try again.


reworked segment.


The case I really care about for our early-testing release is opam usage; in this case the optional setting is ignored entirely, so I'm not worried of cascading poisoning the well. The use of the default value of the variable is for contributors checking out the source and deciding to just run `make` without looking at the details first, and it's best if it works for them as often as possible, so I'd argue that a good cascading strategy is actually worth the effort. I'll see how horrible it looks in Make syntax, though.


removed proc/mounts lookup and redid mount logic.


Wording nitpick, I would instead output

    "this safety check, pass CHECK_NOT_PREINSTALLED=false to make"


grep & cut replaced with awk.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10759](https://teamcity.mesosphere.io/viewLog.html?buildId=100463&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:03:50


Why not tho?..wouldn't be that hard right? and would be nice to be able to remove other blocks from the tick list.


Since these only apply to the text widget annotation, please put them in the text widget annotation class (above https://github.com/KamiHQ/pdf.js/blob/a4f9bae08d38a0abb7ff7d4890d052fb09eb2f71/src/display/annotation_layer.js#L413).


more_clear_state (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (927 of 927 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.13%25-green.svg)


Nit: align this with the `'` after `warn(`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10763](https://teamcity.mesosphere.io/viewLog.html?buildId=100484&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:49


Nit: remove the comment here


What is the syntax of `(ip)` mean in `git remote add pi git@(ip):source.git`?


I'm thinking it would be better to do a PR for all WARNINGs rather than adding echo_color to these now???

Also, is it okay to leave these WARNINGs in a function or should I try to move them into `main.sh`?


Add a description of the function, just like in the rest of the file.


Could you add a test that uses two different versions of Miniconda to exercise this new feature?


We need to make sure that this does not cause any regressions. The regular Widget annotation class used to be a fallback that did render something, whereas now it does nothing.


this patch has serious whitespace problems :(


Also needs a small patch to libgit2:

```diff
diff --git a/libgit2.pc.in b/libgit2.pc.in
index 880266a..c574cd3 100644
--- a/libgit2.pc.in
+++ b/libgit2.pc.in
@@ -6,7 +6,7 @@ Name: libgit2
 Description: The git library, take 2
 Version: @LIBGIT2_VERSION_STRING@

-Libs: -L${libdir} -lgit2
+Libs: "-L${libdir}" -lgit2
 Libs.private: @LIBGIT2_PC_LIBS@
 Requires.private: @LIBGIT2_PC_REQUIRES@
```


Let's call this `hasFlag`.


Also fixed loading OBJs without an object name in them.


Let's make this `@private` and add an underscore to the method name.


Add a description here, just like the other classes.


Wouldn't it make sense to keep that promise around such that if you try to send before it's connected it would implicitly "await" on it? The way it is now, it opens for a subtle bug that only appears when the connection is slower than the developer had in the testing environment (because the developer never realizes that he didn't await for the connection to finish), but it just happened to work by accident on his test environment.


This logic is broken. If you have any problem with the request the Exception will be ignored and the response will never be set.

1. You should proper check the exceptions
2. You should check the status of the response, if that's not 200 the login is not valid and you should show a message to the user.
3. Avoid to just return response.toString, because you have to check the status and the body content properly


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10761](https://teamcity.mesosphere.io/viewLog.html?buildId=100474&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:04:33


dead code?


@fr0stbyte hi. i had a doubt about `threadCount` that i thought i can ask you about. I want to speed up my consumption rate and was wondering if making `threadCount` configurable will help with that. I have made 5 partitions of the topic. Simply running many collector instances is not helping and all are still reading from a single partition.


Isn't this already defined globally in `login.js`?


Nit: indentation is off here, remove two spaces


@caseywebdev so, what we will do? Does `error.name === "CssSyntaxError"` is enough for you?


Shouldn't this be `KeyValueStore[A, B, Option[B]]`?


change this method to private


View logic.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1121](http://teamcity.monogame.net/viewLog.html?buildId=13349&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


I tried to change the flow so that this function was no longer needed, but perhaps I missed something.  If `downloadPathPreference` is not set, it should use the default value.  It is fine to always use the default value, and never set the preference to the default value.


Any chance you could use magic so we aren't dark gray on the graph? Thanks :)
![image](https://cloud.githubusercontent.com/assets/4943487/12128585/29585b78-b3f6-11e5-9317-96c6cd92e93d.png)


I believe that you forgot to push some changes, because this code looks to be incomplete and is not running.

Please, create a branch and a pull request to be reviewed when the code is done and ready to test. And make local tests to be sure that everything is working properly before delivering the code.


I think we will also need to specify the version field in each RPC call, for example

         self.fanout_cast(
            ....
            topic=TOPIC_APIC_SERVICE,
            version=self. RPC_API_VERSION)


With the next 1.1.14 release candidate (hopefully this week), I'm going to follow DavidKrupl's suggestions with the exception of not renaming pacemakerNotification (to maintain backward compatibility). So there will be a new pacemakerTrap with oid { pacemaker 2 } and pacemakerNotificationTrap will be changed to oid { pacemakerTrap 1 }.


Should be deleted?


The default value should be set in DownloadDialog line 78 above


Hmm, once I figured out how the order works (the order of the variables in a nested comprehension is the same as if the `for`s were written out over multiple lines), I don't have trouble reading nested comprehensions.  Regardless, I want to write one function that should be able to eliminate most of the comprehensions in raw_building, but the signature of the function depends on the implementation of the node constructors so I've been holding off until I get those done.  As for why I need an automated refactoring tool: I need to merge *every* call to a node constructor followed by the paired call to postinit(), if that exists, while simultaneously changing the signature of every call, eliminating parent at least and in some cases changing the order of other arguments.  I could this by hand, but it will take less of my time and be less error-prone if I write code to do it for me.


more_clear_state (mbadams5) - x86_64-MacOS-10.9-clang: OK (1995 of 1995 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Restarting failed Travis jobs now


Indeed, please give real credits to omnirom (hey! https://raw.githubusercontent.com/omnirom/android_device_oppo_find7/android-4.4/liblight/lights.c) and please @MasterAwesome stop claiming everything that you didn't coded, it's useless and very very very annoying indeed


this should be an assertion


Well, AFAIK it's not used by any runner included in JUnit 4 and there is no getter for it. So I deliberately skipped it for now.


Well for my use case I need to return a proper instance of `Error`. My workaround was

```js
try {
  // run postcss parser, etc...
} catch (er) {
  // er instance of Error => false
  er = _.extend(new Error(), er);
  // er instance of Error => true
  throw er;
}
```

which isn't pretty, but works well enough.


Thanks for finding & fixing this issue -- this looks great!


This method is never called...


TeamCity pull requests :: netty [Build 975](https://garage.netty.io/teamcity/viewLog.html?buildId=4540&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6365, ignored: 23 Build time: 00:42:45


OK, now I see I could make more simple code, but I guess it's not important for tuning.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10762](https://teamcity.mesosphere.io/viewLog.html?buildId=100475&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:11:06


Nice catch! This is really something that should be detected by a script...


Nitpicking, but maybe it'd be better to create a parent test class with helper methods? Same code was in previous commits :)


I wouldn't use empty brackets for constructors, Scala convention is that you are allowed to leave out empty brackets on methods without side effects (like property access, constructors or things like `zipWithIndex`)


Will do :)


This is not needed


@caseywebdev
```js
catch(err) {
  throw Error(err.toString());
}
```


Yes. I caught that in a later commit, I guess.


Again, don't give credits to you. First, it's useless and secondly it's someone else's work
(https://github.com/h2o64/android_device_oneplus_onyx/blob/cm-12.1/init/init_onyx.c made on the 15 Nov 2015
and this
https://github.com/Grarak/android_device_oneplus_oneplus2/commit/ae986a4870a039810ce1f9f8877dd65abfc7a136 29/09/2015)


`CssSyntaxError` has more helpful fields than just the message, so I want to pass though through too.


You may want multiple levels of currying here (have you tried constructing an instance?) as I suspect the implicit evidence for `Inject[Coyoneda[KeyValueStore[A, B, ?], ?], S]` won't be found due to the multiple, nested, type lambdas. Though, if it works as-is, I'll be pleasantly surprised.

Maybe something like the following:

```scala
class Ops[A, B] {
  type KVS[C]  = KeyValueStore[A, B, C]
  type KVSF[C] = Coyoneda[KVS, C]

  class Aux[S[_]](implicit S: Functor[S], S0: KVSF :<: S) {
    ...
  }

  object Aux {
    def apply[S[_]](implicit S: Functor[S], S0: KVSF :<: S): Aux[S] =
      new Aux[S]
  }
}
```


@TrySound it will remove origin error `stack` and many special properties.

@caseywebdev it looks like to hacky solution. Why you even need to check `err instanceof Error`? What also can be throwed if it is not error?


nope you need to leave them all as es6 otherwise they will not be treated as es6 ... have a look at:

https://github.com/discourse/discourse-tagging/tree/master/assets/javascripts/discourse

to see how files are meant to be structured in es6


@adnasa no worries! Thank you for your contributions to Keystone :)


c0de5b8..54a0473

Thanks alot!


There is a thread on stackoverflow targerting your problem.
tl;dr you have to escape the " with a \ .
it.buildConfigField 'String', 'OPEN_WEATHER_MAP_API_KEY', "\"xxxx-xxx-xxx-xxxx\""


Ah, apologies, I'll make sure to read ahead further then =/


Mmmm not sure about this one - why do you think the original characters are incorrect? The shape looks correct, and they are also more common than the variant you are suggesting (Rikaichan for instance can parse the original version but not your replacement).


@Mrtcndkn Please create an issue ticket as well next time, here is the one;

#94


There's a whole lot of practically identical code here and below.  Can't it be DRYed a bit?


I implemented cascading in 28758bc02f82 , I think it's fairly readable.


add "Belarusian" translated


Indeed; I rebased #41 with this new wording, thanks.


In the context of embedded DNS server I wanted to avoid special cases for anonymous EPs/default bridge.

For add-host and --link the entries are added directly to /etc/hosts. So the embedded server will not involved. We already have a clean mechanism to not update the svcDB for bridge network and anonymous EPs. For the containers on the bridge network svcDB won't have anything and any successful resolution will be through external servers. For anonymous EPs on custom networks, svcDB will serve any other named EPs on the same network and forward other queries. So we maintain the same behavior as it is currently. Please let me know if there are specific cases they may not work.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10764](https://teamcity.mesosphere.io/viewLog.html?buildId=100487&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:09


Under what circumstances can IndexError or TypeError be thrown here?  I'm concerned this might also end up concealing bugs, particularly because TypeError is the most common type of exception in my experience.


Merged here.


Ensuring errors that get passed around are actually `Error`s provides an agreement that fields like `name` and `message` are expected to exist along with other potentially helpful fields like `line`, `col`, etc. When you know all real errors with be instances of `Error`, you're also protected against accidentally returning what you meant to be a successful result as an error. For example...

```js
function (er, result) {
  if (er != null && !(er instanceof Error)) {
    throw new Error('Expected an error but received something else!');
  }
}
```

That sort of generic error check isn't possible unless custom errors subclass `Error`.


0 means disable


Ich wollte schon ein Commit machen, aber als ich beim mir hier local ein diff machte, ist mir aufgefallen, daß alle Zeilen ein Windows Zeilenende haben.
Hätte ich ein Commit gemacht, dann hätten alle Zeilen ein Linux Zeilenende gehabt und beim Commit wären die Änderungen nicht zu erkennen gewesen.
Da habe ich es gelassen, weil ich Deine RF_Receiver.ino nicht durcheinander bringen wollte.
Wie hättest Du es gerne, soll ich versuchen ob ich meinen KDE Editor umstellen kann, daß er im Windows Format speichert.
Oder speicherst Du die Datei mit Linux Zeilenenden?


@jwittenbach Nice! I'll give it a try. The format looks really nice on the iPad. I'll send you a screenshot in a minute.


Also this doesn't fix anything.


A short remark: It seems that this change works fine because GAP will not run into an error when AutPGrp is not loaded.

But the reason for the change given in the commit message is not correct: since quite some time it is no longer true that a certain list of packages are always loaded.

In `lib/system.g` the content of `GAPInfo.Dependencies.NeededPackages` is set, GAP will not start without these packages.

In `lib/package.gi` the user preference `"PackagesToLoad"` is defined together with a default list of packages (currently containing AutPGrp). But this list can be overwritten by any user in the personal `gap.ini` file. So, it can happen that some users always start GAP without loading AutPGrp.


But we still start an embedded DNS server for those endpoints right? Which means one extra socket and one extra go routine for the cases where we don't need them. Also these containers will incur one extra hop into the embedded DNS server for all DNS queries unnecessarily.


when the command is inserted it will be 0 by default, so only put field that the user would change/ screen realestate.


The `xargs` and `stat` calls need to be slightly different on Darwin.


I would throw an API exception instead of NPE (without these lines line 43 already throws NPE if concept is null).


callbacks is not the best name here, as callbacks are mostly executable function. These are just channels with a timestamp, so maybe something like watchers, notifiers,


Is this really necessary?

It seems SpongeDocs is becoming documentation for more than Sponge, with things like https://docs.spongepowered.org/en-GB/plugin/workspace/index.html and this tutorial.


@JasperBRiedel The forward/backward slashes shouldn't be an issue. Although you're right that it's probably better if we use the slash for whichever system we're on.

As for error checking, I'm fairly sure you just have to check that the returned value is neither a blank string nor nil, if I'm understanding the SDL docs correctly.

I was more referring to how the behaviour for SDL_GetBasePath is different on OSX and iOS to other OSes.
When the resource path for windows is
`appdir/resources`
the resource path for mac becomes
`appdir/../resources/resources`

I'd immediately prefer to make this just `appdir/../resources/`, i.e. 'clean', but this requires adding OS-aware stuff to the code which is determining the resources directory within the fauxbox engine.

This is doable but will end up being IMHO more complicated than what originally existed: to just use the executable's location to determine the resources path.

Ultimately it's no big deal though, feel free to go with whichever method you'd prefer. I'll get it working on Mac again if you want to keep the SDL function at the core.


That line looks good to me. Can you post the whole stacktrace?


@Aokromes Thank you for suggestion, i don't use that option anymore since a few weeks ago


Good point -- fixed in amended version.


For the following sets of functions you are applying a function to each item of the `moodData.array`, and pushing the result to another temp array. Can you think of another array method that captures this purchase better than `.forEach()`?


Strange - Node is OK - but in the browser I get a `Uncaught TypeError: rightfns is not a function(…)` for the same code.


How come? It seems to work in my dumb test. We're using the same `coreutils` and `findutils` nowadays.


I think so, we can do the same as shaderc_cpp_test.cc


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10765](https://teamcity.mesosphere.io/viewLog.html?buildId=100488&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:12:16


I still think we can avoid the nil pointer by using time.Time instead of *time.Time in the cache struct.

We can use `IsZero() bool` to test if the timestamp is set.


this is a really neat way of doing this :smile:


missing `@since`


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1121](http://teamcity.monogame.net/viewLog.html?buildId=13349&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:22:55


Would it be obvious to the user that the default of 0 will deactivate their parachute?  It would be bad if somebody doesn't realize this, and then they deactivate their parachute when they actually wanted to release it.


We asked about this on Pop Quiz, almost all answers back then requested the addition of some basic Git(Hub) examples. We discussed about it and the final decision was that having this on the Docs won't hurt.


kannst Du nicht einfach mit linux Zeilenende speichern?


Is there any particular reason to force libmraa to be built as a shared object library (or as a static one)?

Does it make sense to let the standard infrastrure provided by CMake [1,2] driving this?

The only disadvantage of using the CMake flag `BUILD_SHARED_LIBS` is that its default value is `OFF` , even on Linux system; so one has to set it every time he/she configure the project (or add some CMake code to change this behavior).

[1] https://cmake.org/cmake/help/v3.3/manual/cmake-buildsystem.7.html?highlight=build_shared_libs#binary-library-types
[2] https://cmake.org/cmake/help/v3.3/command/add_library.html?highlight=build_shared_libs#normal-libraries

BR,


12: test_is_quad_residue(): ntheory
12: -------------------------------------------------------------------------------
12: /Users/akash/symengine/symengine/tests/ntheory/test_ntheory.cpp:669
12: ...............................................................................
12:
12: /Users/akash/symengine/symengine/tests/ntheory/test_ntheory.cpp:669: FAILED:
12:   {Unknown expression after the reported line}
12: due to a fatal error condition:
12:   SIGABRT - Abort (abnormal termination) signal
12:   Traceback (most recent call last):
12:
12:
12: ===============================================================================
12: test cases:  26 |  25 passed | 1 failed
12: assertions: 237 | 236 passed | 1 failed
12:
12/19 Test #12: test_ntheory .....................***Failed    0.04 sec


this else can be removed.


Why is `moodView.makeChart()` called twice here?


testing github comments .. for timestamps.


wait..have desctructors always raised exceptions or is this a C++11 thing? I should probably be looking into this also.


Don't forget to change getVersion() in ImmPortModule.java to return 15.32


@certik changing this line to `a_final = 0`(or any other integer) removes the segfault.


@nim-odoo
I think this is wrong.
It still works most of the time because the uom onchange is triggered too, but this doesn't compute the price right. Should'nt it be ```_fix_tax_included_price(new_list_price, ...``` ?

Also, if that is needed, I think it's also needed in the product_uom_change method


@Dashed yes, absolutely. I'm debating whether it will be a 6.0.1 or 7.0.0 first.


Thanks!


Done


no se pue hacer nada


can't see ;)


object within an object


I think JavaScript is not a Java or other class OOP language to be based on classes ;).

It is much safer to check `error.name` and `error.stack`. JS is dynamic language and duck typing is better way. It object looks like error and interacts like error, it is a error.


This is the OceanSITES logo I would suggest.  @Lukecampbell I will get you a short paragraph to add.


We need the default value inside downloadPathPreference, otherwise SettingsActivity would not show path.


so 0 is enough cash?


It throw exception not fatal error so no worries if it is invalid format


oh sara
ina hame ye commit hayi k mikhastam befrestam dishbe
merge shode in tori shode
file e k 2bare mifrestamo rush kar kon


Yeah you got typo there :D


5156-HeatExchanger (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (2002 of 2002 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


array of objects,  item in the index file is one object instance from the loop


They don't follow the same structure also most of the test cases is 1 line so it is readable


Hi @stephenlb @davidjimdo . I fixed the issues with the change media functionality. Created this PR with the fix: https://github.com/stephenlb/webrtc-sdk/pull/19.
I tested it with the demo and seems to be working. It is also working for my app.


Not that important but I've seen explicit casts before (for [bools as well](https://github.com/doctrine/mongodb/blob/f488230ee6f070383ef3fd95782d01d015fead14/lib/Doctrine/MongoDB/Aggregation/Stage/GeoNear.php#L217))


This does not update the chart but creates an entirely new chart. The code in `modView.makeChart()` gets around this by removing and re-appending a new canvas element each time `moodView.makeChart()` is called. For the method to update an existing chart, check out the documentation here:

http://www.chartjs.org/docs/#line-chart-prototype-methods


Maybe a good example for useful use of cat like

```
cat /etc/sysctl.d/*.conf /etc/sysctl.conf | sysctl -e -p -
```

(like /etc/init/procps-instance.conf on Ubuntu 15.04)


Is there any `@see` to add?


I don't see the need for this comment anymore - this looks a fine example to me. ;)


saw approval from javajolt
at https://github.com/basho/riak_kv/commit/b2ee2709e5101936cb8ce0f40ec3d4a4395c2d8b


merging basho/riak_kv/bk-rts-753-negation = b2ee2709 into borshop-integration-1319-bk-rts-753-negation


basho/riak_kv/bk-rts-753-negation = b2ee2709 merged ok, testing candidate = 50ad0094


Good job here. Grabbing a template and holding onto to that data for the view could fit in controller code.


Can we poll something here?

    while not finished:
        sleep(1)


Kann es sein, daß ich fürs commit im guthub keine Rechte habe?


```json
"path": "/:searchTerm/s"
```


I was wondering… When I organize spaces by color in an array, should I do it like this:

var redSpaces = [“5”, ”10”, ”15”, ”20”]

OR like this:

var redSpaces = [[“5”], [”10”], [”15”], [”20”]]

Thanks,
Olivia

> On Jan 3, 2016, at 5:29 PM, Ricky C. <notifications@github.com> wrote:
>
> We don't need the

 here, we can actually just set a height to the td.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/InspectorElement/Quelf/commit/824368f87bd8e12cb653e7cd1826697bee8a956f#commitcomment-15235523>.
>


Done


Agree.  I can change it to verify using ping failure or use nslookup/dig.


Yeah something can be done in the library maybe have a retry?


I meant i > j, not i < j as I wrote in the commit.


True


You declare an array of 6 pipe_shader_buffer, so why this is 5? Should be 6 IMHO.
You did the same thing at other places.


@runico, ok it's know  -DWITH_COREDEBUG to break pdump.


o- okay


Raising exceptions in a destructor is a very dirty thing to do. I wouldn't recommend doing that. The problem with this is, when an expection is raised by something, then all variables upon the catch-clause are destroyed and thus the destructor is called. When a destructor now raises an expection, then you basically have an exception while raising an exceptions.
It does sounds a bit confusing, I know.


There is a window between getIfNewerThan and addCallback.
Imagine the cache is updated in that window, the listener on the channel will not be notified.


Td.watchdog622 (true)


Hmmm, not sure if I'm really keen on using Sequencer.  I think it reduces transparency, which I think I need when I'm learning how to use the code.  I think maybe it could be useful to have two examples perhaps, or two versions, one using Sequencer, one without?


Nice idea! Here are some more thoughts on this:

http://stackoverflow.com/questions/21470267/interpret-html-string-using-handlebars-but-escape-script-tags


why was this removed?


This should be `uap10.0` or NuGet will interpret this as UAP 1.0.


lint?


I think we'll just continue with osext for now.


It does _not_ work, actually. I fiddled with it for a while but ended up not needing it for the view transformer which does something different anyway and therefore nobody is using this at present.


TeamCity LabKey :: Trunk :: Premium :: Git postgres 9.4 [Build 915](https://teamcity.labkey.org/viewLog.html?buildId=295082&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:01:28


TeamCity LabKey :: Trunk :: Premium :: Git postgres 9.4 [Build 915](https://teamcity.labkey.org/viewLog.html?buildId=295082&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:01:30


Remember to remove commented out code that you no longer need.


Please add an "optional" tag and a comment on what this does.


Where?


Compute is funny. Don't want to think about it for now.


How? It will only input one command, and the previous command will be overwritten if you put another command.


Okay, I'll change this locally for arb_compute_shader. :-)


Волшебное значение 500 вынеси в класс `ValidationRules` где как раз вот такие значения и собраны.


@nmerket I updated this url. Is there a commit hook that pushes this out to readthedocs?


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 174](https://teamcity.labkey.org/viewLog.html?buildId=295084&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:05:39


saw approval from javajolt
at https://github.com/basho/riak_kv/commit/b2ee2709e5101936cb8ce0f40ec3d4a4395c2d8b


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 174](https://teamcity.labkey.org/viewLog.html?buildId=295084&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:05:42


merging basho/riak_kv/bk-rts-753-negation = b2ee2709 into borshop-integration-1319-bk-rts-753-negation


basho/riak_kv/bk-rts-753-negation = b2ee2709 merged ok, testing candidate = 2a138071


Ah, that's good to know.  I thought I saw somewhere that uap10 was supposed to be equivalent to uap10.0.  I'll go through and make sure I'm using this correctly.


oh man sargije gereftam fek konam ax aval mikhastam hamino vasat befrestam


stimmt, habe ich jetzt aber erteilt


We might want to rebase off the original gem occasionally
> https://github.com/lisinge/valid_email2 is at version 1.1.13 as of now


Interesting approach!


Looks good. In general, you probably don't want the `stoi` around port -- we generally want the user to be able to use "named" services (like "http") in addition to numerical ones (like "80"). And we probably want the user to be able to use named hosts (like "www.stanford.edu") instead of just numerical IP addresses. The `Address` constructor that resolves both is the one that takes two strings: https://github.com/cs344g/ps1/blob/master/src/address.hh#L33-L34

Implementation here: https://github.com/cs344g/ps1/blob/master/src/address.cc#L46-L83


Copyright (C) 2011-2016 Angel Leon, Alden Torres, Marcelina Knitter


sho nuff


В новых файлах не хватает стандартных комментариев с лицензией. Запусти `mvn license:format`


@k00ni why did you revert 385b0be289a53c9fb6a53cf28864759a4c0a1a03 was there any problem with setting the version to `"*"`?


Looking back through my git history (in a different repo), it looks like it was something to do with, I wanted more transparent control of when `forget()` is called (this was in a radically different codebase actually).


We might call in the cavalry (you) in the next few weeks, if you're available. We are very close to getting a CA image! The goal for now is to image the beam and compare to the detector beam image, and if that works I definitely want to sit down with you and go over the decoder again.


Yo


Can do the above by running e.g.:

```bash
git remote add original git@github.com:lisinge/valid_email2.git
git fetch original

# Replace with the appropriate tag.
git rebase v1.1.13
```


In related news, I think it'd be nice if there could be a 'magic code' one could embed in a training sample, that would reset the state during that step, just for that sample, so you could feed through a batch of unequal sequences, and the state would be correct at the start of each sequence.  I think I remember seeing a pull request recently-ish that implemented something like that in fact?


yes, if I figure it out :)


Давай попробуем выдержать стилистику остальных сообщений: `Размер файла должен быть не более {value} ${unit.name()}`


prueba


SZVAV-Fan-Control (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1450 of 1450 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.41%25-green.svg)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1122](http://teamcity.monogame.net/viewLog.html?buildId=13353&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


`File size must be less than {value} ${unit.name()}`


Thank you! That is very un-fatal.


so let's see what this constructor is about, maybe it's the `null` parameter, meaning no tracks...?

```
/**
 * Created on 12/18/14.
 *
 * This action is built to show the name of a playlist, when used it will
 * add the given file descriptors to the current playlist.
 *
 * @author gubatron
 * @author aldenml
 */
public class AddToThisPlaylistMenuAction extends MenuAction {
    //private final Logger logger = Logger.getLogger(AddToPlaylistMenuAction.class);
    private final long playlistId;
    private final long[] fileDescriptors;

    public AddToThisPlaylistMenuAction(Context context, long playlistId, String playlistName, long[] fileDescriptors) {
        super(context, getIconResourceId(context), playlistName);
        this.playlistId = playlistId;
        this.fileDescriptors = fileDescriptors;
    }
```


Why you call it InvalidMessageBodyException, when it's about invalide request? Maybe InvalideRequestBodyException would be better?


@danielbachhuber Can the CI prevent synopsis curruption?


@ShawnieBoy this reverted [this fix](https://github.com/magarena/magarena/commit/7fe2faf673e4cec3015f65e895efb924c24bbded#diff-1b9e349060367f0c359446b1595c8dc9). Mixing operators and relying on operator precendence is hard core! :metal: Judicious use of brackets makes it easier to read and maintain.


@szepeviktor This PR was a mistake on my part. Ignore it. Part of an internal fix we're doing here at wpengine


Раз ты уже целые классы создаешь, то не забывай указывать свое авторство:

```java
/**
 * @author Sergey Chechenev
 **/
```


Добавь комментарий с авторством.


Yeah seems like you completely forgot about it. We could add it anytime. :)


So problem here is also that the dialog that it brings about is the same one as when you try a song from My Files section of the app. Which is different than in Apollo. I would like for it to look the same as when you add to playlist by long pressing any song in Apollo instead.


ASIHPdev (shenb) - x86_64-MacOS-10.9-clang: OK (1980 of 1980 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


so your code uses a constructor that does not exist, probably because you are mimmicking the code above.

The actual constructor takes more things:

The context,
A playlist id number (because this is the one for existing playlists I believe)
A playlist name (not sure why, but the parent needs it, perhaps we put it there for convenience)
And then an array with the list of file descriptors to be added.

So when you're in a situation like this, it's always good to use the Cmd+Shift+G (Find All Ocurrences, in my [keymap](http://www.gubatron.com/blog/2015/12/27/my-intellij-keymap-shortcuts/), which I suggest you copy manually for now)

Then you will see some examples of the constructor in use, and why it might be the way it is.

The code is the best documentation.

So I'm taken to a single place in the entire project:
`AddToPlaylistMenuAction.java:line 83`

```java
private List<MenuAction> getMenuActions() {
        List<MenuAction> actions = new ArrayList<MenuAction>();

        actions.add(new CreateNewPlaylistMenuAction(getContext(), fds));

        List<Playlist> playlists = MusicUtils.getPlaylists(getContext());
        for (int i = 0; i < playlists.size(); i++) {
            final Playlist playlist = playlists.get(i);
            actions.add(new AddToThisPlaylistMenuAction(getContext(), playlist.mPlaylistId, playlist.mPlaylistName, fds));
        }

        return actions;
    }
```


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/3049


@cbeer: seem reasonable?


Is it a Fix or a Workaround ?
it is not possible to run the managed sgen in this environment ?
but thank you for now it works


Oh greatest of the Blender artists, @IAHM-COL, remember the days of thy youth (in Blender), and take pity on a child!
/end joke
Joking aside, you may not think it extra 'detailed', but it is the most detailed building I have built yet. I will keep working on the cargo apron, then I'll see about textures...


It is already merged.


Hi !

This was a temporary regression because we try to avoid this kind of checks. We have merged some new fixes available from PHP 5.2 to PHP 7 here: https://github.com/PrestaShop/PrestaShop/pull/4503/files

Thank you.


do you have the husky precommit hook for semistandard linting disabled? when I try to commit, I get this error:

![image](https://cloud.githubusercontent.com/assets/203725/12129983/0970a2aa-b3bc-11e5-934d-3325a655b51d.png)


Type Hint plz :)


It seems this was some kind of preparation before the [next commit](https://github.com/jukkah/umzug/blob/issue-39/test/helper.js#L131-L134) where I have changed it to join `prepareMigrations` and `prepareSquashes`.


OK, merging shortly, then I'll get the other PRs merged - I'm really not sure why the `code-block` notation was not working before.


There's not a good reason for this, I've never really thought about it to be honest and I obviously missed that part of the add_library documentation :). I've a fix here 16da6ef004dca29f8fc325af6ae34be197b12857 in a branch - does that look good? I don't want the default to be a static lib.


For this project, the first one. Having an array of arrays is redundant.
Let's take a closer look at it.

For the first example: redSpaces[0] to get "5"
For the second, you would have to do redSpaces[0][0] to get "5"

1) redSpaces[1] = "10"
2) redSpaces[1][0] = "10"

Do you notice the pattern? For the second example, you're adding [0] to get
the same result as the first way. That's basically redundant, the idea is
to write less code, not more.

---

When you ask questions, add what you think the solution should be :)

On Tue, Jan 5, 2016 at 5:28 PM Olivia Steger <notifications@github.com>
wrote:

> I was wondering… When I organize spaces by color in an array, should I do
> it like this:
>
> var redSpaces = [“5”, ”10”, ”15”, ”20”]
>
> OR like this:
>
> var redSpaces = [[“5”], [”10”], [”15”], [”20”]]
>
> Thanks,
> Olivia
>
>
> > On Jan 3, 2016, at 5:29 PM, Ricky C. <notifications@github.com> wrote:
> >
> > We don't need the

 here, we can actually just set a height to
> the td.
> >
> > —
> > Reply to this email directly or view it on GitHub <
> https://github.com/InspectorElement/Quelf/commit/824368f87bd8e12cb653e7cd1826697bee8a956f#commitcomment-15235523
> >.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/InspectorElement/Quelf/commit/824368f87bd8e12cb653e7cd1826697bee8a956f#commitcomment-15276195>
> .
>


@Pictor13 Why did you remove the title translations?


Well, the comment is about not checking the existing balance (not about the use of `compareTo`) xD


Take a look at `MusicUtils` there might be some useful stuff there.

Whatever the case we need to ask now, what are the songs available to us in this content.

So before making any calls to the `AddToThisPlaylistMenuAction` your algorithm needs to fetch the tracks at hand, `isAlbum()`? what Album is being displayed? give me the tracks to that album.

If you take a look at  MusicUtils you will get a big smile on your face. I won't spoil the rest so that you figure it out. It should be easier from here on now.


![Uploading Sarah Shiny Eyes.jpg…]()
"You can do it ciocia Malina" -Sarah


pre-generate your world.


reversing


If you only have two fields to initialize, I would just do:
linfo->channels[0].id = 0
linfo->channels[0].cfg = channel_red

and same for linfo->channels[1]. No need for an extra "cinfo" pointer which is quite confusing for readability.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10766](https://teamcity.mesosphere.io/viewLog.html?buildId=100492&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:09:46


Я не уверен, что будет лучше, но хочется "засунуть" эти константы в качестве члена перечисления: http://javarevisited.blogspot.cz/2011/08/enum-in-java-example-tutorial.html (см. пример 3). Тогда получится нечто типа такого:

```java
enum Unit {
    b(1),
    Kb(1024),
    Mb(1024 * 1024),
    Gb(1024 * 1024 * 1024);

    private long size;

    private Unit(long size) {
        this.size = size;
    }
}
```

Соответственно мы сможем избавиться от `switch` и упростить код инициалиации:

```java
maxFileSizeInBytes = constraintAnnotation.value() * unit.value();
```

Я такое ни разу не делал и код примерный, поправь по месту.


I think the only reason to promote `service` over `factory` is that its a little more in-line with what angular2 services will look like (using classes). IMO, angular1 probably should not have included both of these, and we should promote the use of one over the other. Since we're already promoting the use of factory, I think its best we stick with that.


Smalltalk comments don't work here :smile:


Usually, in open/remove, we deal with the state of the device: for example most of the devices can be only opened once.


s/Id/ID


s/Userinfo/UserInfo


Could you explain the motivation for this change? Using "Reply-To" could break how it works for many people that are expecting the value of "sender". It should probably look at the sender param first.


@pitr-ch @eregon @nirvdrum are people in favour of this?


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 175](https://teamcity.labkey.org/viewLog.html?buildId=295096&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:02:21


I would print the message before the driver initialization.


Use lowsyslog() instead of printf


Hi,
This change is exactly what I need to get my testsuite to work with the latest version of react-bootstrap

when running my testsuite in phantomJS I get a "TypeError: 'null' is not an object (evaluating 'node.scrollHeight')" when dealing with modals.

Any idea when this change is going to be available in the form of a new npm package?

R


Do you need that?


I use -q 99% of the time for my maven builds. I even made an `alias m='mvn -q'` in my shell.

Only down side is that it silences important info you might need to fix a broken build, so I frequently have to go back to a full `mvn` for that. You wouldn't be able to do that through this change.


ROFL
Dont go Shakespearean on me, Lego :pager:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10767](https://teamcity.mesosphere.io/viewLog.html?buildId=100495&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:25


Here, you can deactivate everything that is not control protocol and the light protocol


Not needed


Where does message-url come from? I don't see it mentioned in the mailgun api docs. https://documentation.mailgun.com/user_manual.html#routes

I've considered having a way to pass along mailgun specific params, however, there isn't a way yet. If that happens that could be a place to handle message-url. It shouldn't be in extract_headers because it isn't in the headers.


I know that this is not really pythonic. But it works for me. If someone has suggestions on a better implementation, be my guest!


1. Keyword is already displayed as you see
2. I don't want to make to many details hide/show on demand


nit: might be good to specify when we can deprecate this, e.g., Remove this when we drop support for v1.1


Latest box for PHP 5.6 should be `0.3.3`, this clause would make it not use the latest compatible version.

```
config.vm.box_version = settings["version"] ||= "< 0.4.0"
```


das commit hat jetzt zwar geklappt, aber irgendwas stimmt noch nicht.
Im commit wird die RF_Receiver.ino als BIN angezeigt!


Now works with dotnet cli


Should it be
```scheme
(define (geneartor . args) (list->geneartor args))
```
not? It seems SRFI-121 renamed make-generator to generator as well.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1122](http://teamcity.monogame.net/viewLog.html?buildId=13353&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:21:53


@jeffwen Good job explaining xargs. :+1:


LGTM, thanks!


Thanks! That really helped!

> On Jan 5, 2016, at 5:54 PM, Ricky C. <notifications@github.com> wrote:
>
> For this project, the first one. Having an array of arrays is redundant.
> Let's take a closer look at it.
>
> For the first example: redSpaces[0] to get "5"
> For the second, you would have to do redSpaces[0][0] to get "5"
>
> 1) redSpaces[1] = "10"
> 2) redSpaces[1][0] = "10"
>
> Do you notice the pattern? For the second example, you're adding [0] to get
> the same result as the first way. That's basically redundant, the idea is
> to write less code, not more.
>
> ---
>
> When you ask questions, add what you think the solution should be :)
>
> On Tue, Jan 5, 2016 at 5:28 PM Olivia Steger <notifications@github.com>
> wrote:
>
> > I was wondering… When I organize spaces by color in an array, should I do
> > it like this:
> >
> > var redSpaces = [“5”, ”10”, ”15”, ”20”]
> >
> > OR like this:
> >
> > var redSpaces = [[“5”], [”10”], [”15”], [”20”]]
> >
> > Thanks,
> > Olivia
> >
> >
> > > On Jan 3, 2016, at 5:29 PM, Ricky C. <notifications@github.com> wrote:
> > >
> > > We don't need the

 here, we can actually just set a height to
> > the td.
> > >
> > > —
> > > Reply to this email directly or view it on GitHub <
> > https://github.com/InspectorElement/Quelf/commit/824368f87bd8e12cb653e7cd1826697bee8a956f#commitcomment-15235523
> > >.
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/InspectorElement/Quelf/commit/824368f87bd8e12cb653e7cd1826697bee8a956f#commitcomment-15276195>
> > .
> >
> —
> Reply to this email directly or view it on GitHub <https://github.com/InspectorElement/Quelf/commit/824368f87bd8e12cb653e7cd1826697bee8a956f#commitcomment-15276622>.
>


True. Reworking to allow override of TTL.


Make autoDoc a function and call it here.


Sounds good. If I add address, port, and ttl as args to Ping, we're well on our way to having Ping be a classmethod instead of needing to instantiate a MulticastAgent to use it.


more_clear_state (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1465 of 1465 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.62%25-green.svg)


yes, thats right, already made pull request.

2016-01-05 23:06 GMT+00:00 Mior Muhammad Zaki <notifications@github.com>:

> Latest box for PHP 5.6 should be 0.3.3, this clause would make it not use
> the latest compatible version.
>
> config.vm.box_version = settings["version"] ||= "< 0.4.0"
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/laravel/homestead/commit/74c7eac7bf3772cd4767fc4d3442a60d664cab61#commitcomment-15276793>
> .
>


@bstraa
:smirk: good choice of emoji!


I'd prefer if `autoDoc.R` was a function defined in `preprocessData` and called as such rather than copied from extdata and sourced.


Creating a new socket inside Ping is the final step towards making it a classmethod. Let me try refactoring to do this, then we'll see how it looks.


2012-GlareSensorFix (rpg777) - i386-Windows-7-VisualStudio-12: OK (2337 of 2373 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.48%25-yellow.svg)


how come?


Will put the brackets back, hehe
Been staring at operators so much recently it became second nature, but give it a month and I'll be scratching my head again.


I was talking about the "f" prefix.

... but maybe I'm missing the actual point. In any case, I'll let you clue me in later.


Can you add a couple of tests with more complex filters like a>=val1 and b=val2?


Ahh - a tidier fix


@bstraa Good job!
Check python version by using either one of the following:
```
$ python -V
$ python --version
```


no need for this check, i think.

> If path is already a directory, MkdirAll does nothing and returns nil.


Why "TankDrive"?


All of the prints to console were for testing purposes.


Since there are actually two entrypoints we care about (framework's and frontend's), I'll meet you halfway by making MulticastAgent more general (moving these to its c'tor), but keep the flags in this module, and have them used when Server instantiates MulticastAgent instead. Since the frontend imports this module, it should still be able to get at these flags for Ping() to use. How does that sound?


I like this idea. I made a couple of line item comments.


Looks like the OIDC notifications will also need a parameter/property standardisation (not for this PR, of course)


ObjexxFCL41 (DeadParrot) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-74.19%25-red.svg)


You should be clearer here. What are these the axes of? They are not the robot axes - robot is x forward, y left.


> Why don't we lookup based on the whole name rather than parts[0] so that when we later support self fully qualified names (to resolve container's self name using fully qualified name it will just work) it will just work?

Resolving container's self name (in short form or qualified with nw name) already works.

Since we treat every network as a domain and we maintain the DB per network I think naturally it follows to do the lookup only by the service name. In fact we can remove all the service_name_dot_nw_name entries from the svcDB. It will reduce the hash table size by half.


Good catch. I should probably just make this blocking by always following up with a join.


Is there any discussion around this anywhere public?


Good catch.


@bstraa Good job! I agree the three modes in vim is definitely tricky.


But the response is. Which I thought disposed the stream?


Hope we can bring back the default ids :-)


Here you are remapping the joystick axes to the robot axes. I think it is confusing to do that - because now when you call getRightStickY() it doesn't actually return the value of the right stick's Y axis!
I would do the remapping in the robot drive command.


Good to know. Will add '!' at the head of the format string.


add comments as to why these should fail.


@trueadm Here you are importing recycling, but where are you passing it into the root nodes as argument?


If you no longer want the line, delete it.


These aren't actually being used in the Chassis class!


Reformat to keep the line length under control!


Edit error : [].concat(words) is better ?


We started by building an array here but settled on using a hash table.  We forgot to change the name to reflect that.


What if I didn't have the response or stream in a using and jut return the stream from ReadAsStream? Do you think thats better?


don't add "-j9" here, it would be nice to detect this from the system or inherit from parent make (see MAKEOPTS or some other make-exported variables). Another alternative is to call `$(nproc)`


The zeroing functionality was implemented via [MaskZero](https://github.com/Element-Research/rnn#rnn.MaskZero). It doesn't forget as you say though. It's more for padding the beginning of variable length sequences.

For more transparent control over forget, there is the [Sequencer:remember()](https://github.com/Element-Research/rnn#remembermode) method. You could call `seq:remember('neither')` and then make manual calls to `seq:forget()` as needed. In any case, we could still add a switch to allow training without the Sequencer. This, like you say, would allow for better visualization of what is happening.

Next step for me is to try to match the performance of char-rnn package and implement an evaluation loop (cross-validation, early-stopping). I am trying to keep to training script as concise as possible to facilitate understanding. I also want it to be evident how using the rnn package results in concise elegant code.


Is line 1073 correct? The comment mentions never less than 2 but the assert has >= 2.

I'm probably just not understanding the code though, but better play it safe and ask.


`raw_input` is invalid in Python 3


it ain't even 0.8sec...


@bstraa  Good xargs example.  Make sure you check the preview section before submitting. Github markdown are different sometimes than regular md. Or did you intend to make your answers in the header format?


Don't rely on a method in the class under test to reset things for you.
Modify it directly:
chassis._modules[0]._direction = 0.0 ... etc


this is bad, why can't we rely on chrpath OR exporting `LD_LIBRARY_PATH` before these tests?


Rezero before each test to make sure you get the correct answer, and aren't affected by the previous tests.


Didn't remove the empty constructor? :stuck_out_tongue:


In production mode no, only on default.


You no longer need this.


@demmer @davidvgalbraith @go-oleg propagating errors from the serializer like this ? bueno or no bueno ?


From a given starting point (which we always do in our tests!) you will always get one answer. So no need for the "or".
If you are using an "and" in your assert, it means you have two tests - so use two asserts.


@bvaughn still getting ```Cannot read property 'requestAnimationFrame' of undefined```


This can be removed now.


Same as above.


:+1: Will remove


This `using` can be removed.


`config_filename` is set int the pam_configuration, this is parsed at line 1449 and then the "default" magic value is checked at line 1378.


Should be "scaling_min_freq, min" not "ren_min_freq, min"


Beautiful!


fast-forwarding end-to-end/timeseries to borshop-integration-1319-bk-rts-753-negation = 2a138071


Maybe consider breaking the one massive test into separate test methods. That way if it fails parts, it might still pass others. Makes fixing the bugs faster.


ACK.


you can replace the sleeps and the `# Verify swarm detects node failure` bloc after a stop by

```
# Wait for Swarm to detect the node failure.
retry 5 1 eval "docker_swarm info | grep -q 'Unhealthy'"
```


I'm sure we can find something similar for start


not at all, if the object is a lot or a conflict emerges error biome decorator


Please review.

I think it looks much better now.
Can you confirm?


why 40 here ?


Probably for something like this: [1, 2, 3][4] and [1,2, 3, 4]["a"], since .getitem will look in the underlying elements for doing the operation.


Yeah that would be better. But it should be documented on the interface that the caller has to dispose of the stream.


The following needs to be amended to this commit when backporting:

```diff
diff --git a/lib/tty.js b/lib/tty.js
index 82b8e62..f3f84ca 100644
--- a/lib/tty.js
+++ b/lib/tty.js
@@ -1,6 +1,7 @@
 'use strict';

 const util = require('util');
+const internalUtil = require('internal/util');
 const net = require('net');
 const TTY = process.binding('tty_wrap').TTY;
 const isTTY = process.binding('tty_wrap').isTTY;
```


I don't know if it disposes the stream or not. I'm not sure... Should double check.


ASIHPdev (shenb) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


True...


If this is being run from Maven, use the system property `basedir` to find the base directory for the project that is under test (works reliably in a multi module builds, jenkins/hudson builds, and even in various IDE based builds).  Use the `user.dir` system property as a fallback, don't use "." here.


RoslynTester shouldn't be a dependency on any of these projects -- only on VSDiagnostics.Test


This line seems to duplicate the one above it.


Everything should still work by removing RoslynTester from these, right?


should be fixed per discussion in Discord


Hey @frankleng,

Yeah. Sorry to hear that you've been burned by this too. Follow along on issue #41 if you'd like to stay up to date about it. I'll work on it some more this evening after work.


Oh :-) I only tried it on the command line...


Pending engines are validated with a minimum of 30 seconds interval. It's a static value.


It's a timeout for finding dynamic created DOM element. 10s is just for safe. For successful cases, the finding will finish quickly.


`nix-shell -p` :grin:

```
propumpkin:nixpkgs copumpkin$ nix-shell -p

[nix-shell:~/Sandbox/nixpkgs]$ find . -type f -print0 | xargs -0 -r stat -c '%Y %n' | grep -v '\.git' | head -n 50
1452022911 ./.DS_Store
1450989410 ./.mention-bot
1447668689 ./.travis.yml
1447668689 ./.version
1450989410 ./CONTRIBUTING.md
1450989410 ./COPYING
1449281517 ./default.nix
1447668689 ./doc/coding-conventions.xml
1450148467 ./doc/configuration.xml
1447668689 ./doc/contributing.xml
1450989410 ./doc/default.nix
1450989410 ./doc/functions.xml
1450989410 ./doc/haskell-users-guide.md
1447668689 ./doc/introduction.xml
1450989410 ./doc/languages-frameworks/coq.xml
1450989410 ./doc/languages-frameworks/go.xml
1450989410 ./doc/languages-frameworks/index.xml
1450989410 ./doc/languages-frameworks/java.xml
1450989410 ./doc/languages-frameworks/lua.xml
1450989410 ./doc/languages-frameworks/perl.xml
1450989410 ./doc/languages-frameworks/python.xml
1450989410 ./doc/languages-frameworks/qt.xml
1450989410 ./doc/languages-frameworks/ruby.xml
1450989410 ./doc/manual.xml
1449149938 ./doc/meta.xml
1447668689 ./doc/old/cross.txt
1447668689 ./doc/old/update-upstream-data.txt
1447668689 ./doc/package-notes.xml
1447668689 ./doc/quick-start.xml
1447668689 ./doc/release-notes.xml
1447668689 ./doc/stdenv.xml
1447668689 ./doc/style.css
1450989410 ./doc/submitting-changes.xml
1451440714 ./lib/attrsets.nix
1447668689 ./lib/composable-derivation.nix
1447668689 ./lib/customisation.nix
1447668689 ./lib/debug.nix
1449149938 ./lib/default.nix
1449149938 ./lib/deprecated.nix
1450989410 ./lib/licenses.nix
1447668689 ./lib/lists.nix
1451870764 ./lib/maintainers.nix
1447668689 ./lib/meta.nix
1449281517 ./lib/minver.nix
1447668689 ./lib/modules.nix
1447668689 ./lib/options.nix
1449331195 ./lib/platforms.nix
1449149938 ./lib/sandbox.nix
1447668689 ./lib/sources.nix
1447668689 ./lib/strings-with-deps.nix
xargs: stat: terminated by signal 13

```


ok.... :(

let's at least use a `retry syntax` so it might take less than 40


A few comments after playing around on a local instance:

* IMO it makes more sense for the teams in an organization's project to be per organization, not per project.
* Where's the "owner" team?
* A user that's not in the organization can be added to the team.
* Some of the permissions ought to be per organization, not per project - such as "project.create".


I had it disabled because it was not working on Windows. I realized that problem was the standard-reporter. Got rid of it and renabled the linter. This errors got through by mistake. Can we run the linter in travis?


Closes issues #1, #2, #4 and #5


Hi Carsten, Thank you for the contribution. We accept the modification and will publish to live at 1/14.
Acom Doc Center Loc team


Thanks, and glad you like it!


* `aa_rx_sg_get_tf()` should take the precomputed array of absolute transforms
* If `from` or` to` is the root, you don't need a multiply, just a memcpy or an inverse
* See functions `aa_tf_qutr_mul()` and `aa_tf_qutr_conj()`


Sakra, omylem jsem ti to poslal nejak spatne. Nicmene ten cely kod, vcetne posledních (ale nezvyraznenych) zmen je tady.


ASIHPdev (shenb) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1986 of 1986 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The EntitySpawnEvent should handle every exp orb spawn, so hopefully thats all we'll need for the fix... I'll remove the redundant exp cancelling later and review/test some stuff later.


I commented out these lines rather than deleting them so people in the future will be able to look and know how to import stuff, same situation below in Stongholdrobot automomousinit


@SubJunk  :+1:

Did everything work out fine, or does the instructions need any improvements?


Added what it is now!


Is makemigrations necessary to getting started?


Found this bug. Please review


Note that the datapackage.json is not included here.


Eh. What's signal 13 on Darwin?


Why are the tables all weird here?


:clap: indentation.


yay, quests

Now I'm going to have to recraft a bunch of stuff...


Let's move away from URI.join. It's too problematic for joining > 2 elements.


Good point. This is redundant if we use getBackgroundPage though.


Why split the entire string to get the first word?


I've tried using flex for a (hopefully) less fragile way to lay this out: https://github.com/mdn/webextensions-examples/pull/25


reworked here: https://github.com/ffnord/nord-startseite/commit/1de3c5167afcb141c6d387d9f2df448b72d905c2


Very nice! https://github.com/mdn/webextensions-examples/pull/25


This paired with some jquery in js.js makes the form return all units if dates are not selected.


In index_controller.rb, Case statement 4 is slightly different than the others ("_p tag_Your numerology number..") because of a preset rspec test requirement from a coding tutorial.


Note that we treat this as a warning in the table view:
https://github.com/juttle/juttle/blob/master/lib/views/table.js#L179

Warning seems more appropriate.


Overall the approach seems good.


using !empty fixes the issue of the 1970 default


* Organizations have teams too, they're separate (intentionally), sort of like how GitHub has project collaborators and organizational teams
* The owner team on projects is pointless and should be removed (oops), it's only for organizations that it makes sense
* How exactly do you propose adding a user to an organization if not by adding them to a team?!? :stuck_out_tongue:
* The list displayed includes the permissions which only actually apply to organisations (at the moment) - they won't do anything - need a better UX for permissions selection, since a lot of permissions rely on other permissions being granted - for instance, project.team.create doesn't make any sense without project.edit - I want to remove some of these dependencies anyway

Basically: I'm not done yet, but this is technically usable so I figured I'd push it


Two space additions:
if (!...
)) {


@oifland can you check the README to see what the minimum version of Vagrant the cookbook specifies and if the new site supports that version?


I guess the `/refactor/refactoring_files` folder is redundant and could be reduced to just one?


This removes the showall once a date is selected


Because of the links. They are displayed correctly within spacemacs.


Here is some indent style enlightenment:  https://en.wikipedia.org/wiki/Indent_style

We are following K&R style. Closing brace on new line.


this creates a date picker using our query names rather than needing a specific id. this also help with theme matching


beauty :+1: