Why i in 1..3, is this correct?
RM0090 Page 1443:
OTG device endpoint-x control register (OTG_HS_DIEPCTLx) (x = 0..7, where
x = Endpoint_number)


Yeah, probably about time. Check out #6400.


The `path` bit is actually just a dirty hack. The `community_id` can be either a string (the community name) or an int (community identifier), but I couldn't make flask accept a single function as handler for both these types. Out of despair, I tried with `path` and that worked.


As we discussed in #36. I divided between obligate and optional parameters.

Isn't possible to make date_from/to also an optional parameter and plot the whole time range if no dates are given?


kk


Is running "pip install" on each run a problem? Would it update gitpython if a new version is published?


it should be
```cpp
T1L = (pwm_steps[current_step] * pwm_multiplier);
```


6087 :)


It's in the commit message. When it is resolved to null then Unicode throws up.

In other news, this is just a fork I made to get a PR merged. I don't use this library anymore. Check the upstream


Having seen this idiom a lot in PR 2006, I don't like it; it requires ~identical "boilerplate" ~everywhere. I didn't comment on it before because I couldn't think of a better way.

Now I think I have.

Recall PR #1977 and [my `StructLayout` example](https://gist.github.com/jonpryor/f121ba42e12742e172b40), in which we can use `[StructLayout(LayoutKind.Explicit)]` on a subclass and the subclass fully controls how things get marshaled to native code.

We can (ab)use this; instead of:

    unsafe struct _SockaddrDynamic

You can instead do:

    [StructLayout(LayoutKind.Explicit)]
    unsafe class _SockaddrDynamic : Sockaddr {
        ...
    }

This makes `_SockaddrDynamic` a `Sockaddr`. We can thus update `Sockaddr`:

    partial class Sockaddr {
        internal virtual Sockaddr ToNative ()
        {
            if (NeedsWrapper) {
                return new _SockaddrDynamic (...);
            }
            return this;
        }
    }

This removes the need for *every* call site to check for `address.NeedsWrapper` and instead means you can "just" call `.ToNative()`.


Well spotted! Yes, absolutely `start_zoom` should be < `end_zoom`. I have fixed that in 72a6441.


Shouldn't this be `require('lodash').cloneDeep`?. Same goes for the 3rd line.


I don't think we have a gitcache on the master and if we keep the workspace, do we need it?


To be more precise, the functionality that we need from the UI is to search for a community when we only know its name or its ID.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1140](http://teamcity.monogame.net/viewLog.html?buildId=13465&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:26:41


This should likely be `callback(new Error(response.statusMessage))`. Bare strings should not be passed as error arguments.


Please move this to the top of the file under `(in-ns...)`.


Should we use "git remote update" also? Does fetch get the tags?


Hi, I don't think it's only 64-bit but 32-bit as well... I'm preparing the 0.7.8 release right now!


You should favor anonymous functions in these cases since they won't pollute the local scope.


Might this be "better" as an instance method on `Msghdr`? I'm not sure...


what oil


Do you really mean "roots" here?


I'm afraid this won't work as expected. When FPM's source type is set to "python", it has the side effect that the modules that your application depends on are actually turned into package dependencies. Meaning that when you have a dependency on say "Flask==0.10.1" in your setup.py, FPM will automagically determine that your OS package now gets a dependency on a package called "python-Flask", version 0.10.1; Next to that package (and less likely its version) probably isn't even available, it also results in a package that isn't self contained. We'll need to find a different way for this.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 188](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=649&buildTypeId=XbimEssentials_XbimEssentials) is now running


page 377


改了，
[root@RHEL65 wechat-deleted-friends]# python wdf.py
  File "wdf.py", line 58
    cookie_support = urllib2.HTTPCookieProcessor(cj)
    ^
IndentationError: unexpected indent
会有这个报错，求解。。


I see we're back to `info` again :)


we do now :)

But you have a good point. Will flush it  and simply clone from artifacts.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 188](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=649&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:53


(In particular, this is referencing the leaf state, but there's a separate notion of roots. I haven't read through all the code yet but this is already a bit confusing.)


OK for now

On Fri, Jan 8, 2016 at 11:03 AM, Jonah Gabry <notifications@github.com>
wrote:

> temporary stan_glmer vignette
>
> @bgoodri Feel free to make any changes, but does this look more or less
> ok as a placeholder for a real stan_glmer vignette? For the next
> release we can beef it up with actual examples.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/stan-dev/rstanarm/commit/f28d918798def8c94966dbb5e88cef87e9dfaee5
>


OK, have fun.

However, please note that stuff in pawns.cpp is only computed only once, when a new pawn or king configuration appear on the board.

Because of this, you should not refer to minors or majors in pawns.cpp


Can you open a discussion on the list instead? Thanks!

On Tue, Dec 8, 2015 at 9:19 PM, Mickey Reiss <notifications@github.com>
wrote:

> @hanwen <https://github.com/hanwen> Can you share context as to why
> jvm_flags does not support $(location)? Am I mistaken in that
> understanding?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bazelbuild/bazel/commit/d08b27fa9701fecfdb69e1b0d1ac2459efc2129b#commitcomment-14857491>
> .
>

--
Han-Wen Nienhuys
Google Munich
hanwen@google.com


Why error code 166? Because I needed some distinctive value between 1 and 255, and 166 is the ASCII code for the character `v`.


Thank you indeed!


git remote update is simply git fetch on all remote. we could do git fetch --tags to only fetch the tag.


Don't ever modify native objects prototype!


whoops copy/paste fail. Reverting since it had the correct file to begin with.


could use pip install --upgrade


**Code Quality: Nitpick**

You should use some other tag in place of this since this is not actually a form. It might be very hard for whoever is going to maintain your code to understand that this was just a fix ¯\_(ツ)_/¯.


For reference, here's how you `bundle update` RSpec 2.

```
BUNDLE_GEMFILE=gemfiles/rspec2.gemfile bundle update
```


Wouldn't "rm -f" be cleaner?


s/error error/error state/


@ckaldemeyer : Your wish from #36. Now it is possible to create a stacked plot in two steps:

```python
# Creation of a multi-indexed pandas dataframe
es_df = tpd.EnergySystemDataFrame(energy_system=energysystem,
                                  idx_start_date="2016-01-01 00:00:00",
                                  ixd_date_freq="H")

# Plotting a combined stacked plot
es_df.stackplot("bel", "2016-06-01 00:00:00", "2016-06-8 00:00:00",
                title="Electricity bus",
                ylabel="Power in MW", xlabel="Date",
                linewidth=4,
                tick_distance=24)
```
![figure_1](https://cloud.githubusercontent.com/assets/4760584/12204684/f7bc484e-b635-11e5-8897-14c71c6e14f5.png)

But it is still possible to create your own combined plot using stackplot_part:

```python
# Creation of a multi-indexed pandas dataframe
es_df = tpd.EnergySystemDataFrame(energy_system=energysystem,
                                  idx_start_date="2016-01-01 00:00:00",
                                  ixd_date_freq="H")

## Plotting a combined stacked plot
#es_df.stackplot("bel", "2016-06-01 00:00:00", "2016-06-8 00:00:00",
#                title="Electricity bus",
#                ylabel="Power in MW", xlabel="Date",
#                linewidth=4,
#                tick_distance=24)

fig = plt.figure(figsize=(24, 14))
plt.rc('legend', **{'fontsize': 19})
plt.rcParams.update({'font.size': 14})
plt.style.use('grayscale')

ax = fig.add_subplot(2, 1, 1)
es_df.stackplot_part(
    "bel", "2016-06-01 00:00:00", "2016-06-8 00:00:00", ax,
    title="Electricity bus",
    ylabel="Power in MW", xlabel="Date",
    linewidth=4,
    tick_distance=24)

ax = fig.add_subplot(2, 1, 2)
es_df.stackplot_part(
    "bus_distr_heat", "2016-06-01 00:00:00", "2016-06-8 00:00:00",
    ax, title="District heating bus",
    ylabel="Power in MW", xlabel="Date",
    linewidth=4,
    tick_distance=24)
plt.show()
```
![figure_2](https://cloud.githubusercontent.com/assets/4760584/12204689/02874346-b636-11e5-94c0-fc6c8732fa45.png)


I'm not sure this is correct. #ifdef takes a flag, not a condition. #if is more correct as that handles expressions.


confirmed working :heavy_check_mark:


Maybe we could just make this branch our default branch to use in `package.json` until we have webpack integrated on topcoder-app?


The format should be
> <map_name>,<x>,<y>{:<map_name>,<x>,<y>...}

isn't it?


hi, this modification causes on meizu mx4 black screen, you can take photo but preview screen is black.


@leobalter
It doesn`t support `W033` option in CI. But It is fine in my computer.  How can i resolve it?


Well you can put comments to where you assign the attribute in `__init__()`, but AFAIK no documentation generator reads that. You can add a class-level attribute and put comments before that, and Sphinx does take that into account, but you usually don't want to do that.

You usually put the attribute documentation in the docstrings of the class.

```python
class Foo(object):
  ''' This is Foo class.

  .. attribute:: bar

    List of spam and eggs.
  '''
```

What do you think of the docs at http://craftr.readthedocs.org ?


Some comments here would be helpful. I didn't find the names/types to be quite enough to immediately understand what was going on here.


**Code Quality: Nitpick**

indentation on this file needs to be consistent. Keep it at 2 space for CSS file (I think).


@thatoddmailbox The roach still hasn't died


@nywillb I KILLED IT NOW


Feel free to add a commit to fix all the formatting, but let's keep it separate from unrelated changes.


Sweet! Why you tag me?


Wrong doc comment (copy-paste problem).


@ntustison fyi


You asked about selfie instructions for gimp!


Any reason you don't use T_VOID here or something similar?


if we want a one-liner:
```c++
return boost::trim_copy(node.value);
```


Space between if and (.


@RealDavidoff I replied to your ticket. :-)


compiled?


Tis true, this is nice. I'll do selfies next time!


hey Tucker,
I know we're far past this, but I just want to take a moment to address this error in your code.
A favorited post is a post that a user has "favorited", correct?  And several users can favorite an individual post, correct?  So that means, an individual post can have many favorites.  In fact, that's exactly what's in the post.rb class: `has_many :favorites, dependent: :destroy`.
In the code here, you're trying to call a method called `favorite` on a collection of posts.  But it should be the other way around...for each post, we want to render its collection of favorites.  That's where you've run into the problem and why you were getting error messages.


I totally a agree, especially as the bus type is kind of an arbitrary attribute or just a info. If you like to plot all electrical buses you can just get their uids by a quick list comprehension...


This commit used an incorrect approach and has been reset out.  It no longer appears in the branch.


i do not even no if it is a necessary index in the pandas dataframe because ids are unique...


**Code Quality: Nitpick**

It might be helpful to always make use of a Beautify Plugin before shipping code.


Same as you, exact same error with 5.3 toolchain (self compiled) I will also try to fix it now. See if I can get anything


This is redundant. Consider:

``` js
returnsAPromise() // returns a promise containing value 'x'
```

That returns a promise that when fulfilled will contain the value 'x'.

``` js
returnsAPromise()
  .then(function(x) { return returnOtherPromise(x); });
```

That is the same thing, but then when the promise is fulfilled and the value 'x' is obtained, pass that value to another function that returns a different promise which is constructed in some way given the value 'x', essentially replacing the original promise with the one returned by `returnOtherPromise`.

Be sure you understand, then, why this is entirely redundant:

``` js
somepromise.then(function(x) { return Promise.resolve(x); });
```

You're basically saying: "once `somepromise` is fulfilled, get the value 'x' and create a promise from it, then replace the original promise with it." That's redundant because you already _had_ a promise with the value 'x' and now you're replacing it with another promise with the same value 'x'. There's no reason to do this because you didn't change the value inside the promise ('x').

In other words:

``` js
somepromise == somepromise.then(function(x) { return Promise.resolve(x); });
```

they're equivalent, except you're doing more, unnecessary work with the second. You're basically unwrapping the promise and wrapping it back up exactly the same way.


@thatoddmailbox YAY


Same thing here. You're capturing the error and rewrapping it exactly the same way. Simply get rid of this `catch` handler entirely, same with the above `then`.


I'm just playing around with the textures.  Feel free to dump them for something nicer.


It looks cool.


Sorry to nitpick but I personally find this parameter name not very descriptive. How about `exchange-delete-in-progress`?


Yes, I see the same behavior on all my servers with wmf 5 installed. I must be missing an update or three. Cold you provide me with the output from your $psversiontable ? Here is mine:

Name                           Value
----                           -----
PSVersion                      5.0.10586.51
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.10586.51
CLRVersion                     4.0.30319.34014
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Thanks,
Hugh

---------------------------------------------------
http://www.twowheelsgood.net

--------------------------------------------
On Thu, 1/7/16, eslesar <notifications@github.com> wrote:

 Subject: Re: [PowerShell-Docs] The instructions using a self signed certificate to setup the pull sever were incorrect. (0cdaba0)
 To: "hcaldwell/PowerShell-Docs" <PowerShell-Docs@noreply.github.com>
 Cc: "hcaldwell" <hughtwg@yahoo.com>
 Date: Thursday, January 7, 2016, 7:35 PM

 Have you run update-help
 recently?

 —
 Reply to this email directly or view
 it on GitHub.


**Code Quality: Awesome**

It is always good to make use of data dumps like this to test your application before actually plugging it with external APIs or Backend services. This is a sign of a great programmer in the making. Great Job!!


test fixed in pull #274


See [this other line](https://github.com/drakemain/steamsig/commit/7a82add30021fb11658355347249493190727636#diff-98c47855acfc897d6780742f62edb3c3R20) from a different commit you made which makes more sense. You wanted to do something with the error (i.e. print it) so you did need a catch handler, so you must re-wrap it again since catch/then expect a promise to be returned. But if you're not doing anything with the error/value anyways, then no need for a handler to begin with: just leave the value/error in the promise as it is.


the WORK_DIR is now src/work. It should probably still be just work/


This is a use of runtime parameters that I personally didn't foresee but it is not really different from using a separate table, so why not.


This closes #13 since we're now using the passenger bound to the ruby we're using.


Yeah it should be. I changed the format and forgot to adjust this!

I have another commit to apply anyways to fix `@go`.


yes .... today will be a long day


Yep, added it back here because it might be useful to track deployments. It does not cause too much noise because the events are filtered.


In recent Django versions, third-party app tests are not triggered by the test command, as the new default test discovery utility only search in the files of the current project. It is very difficult to test properly an app without knowing the exact settings used (aka integration tests), that's why Django made this move.

Are you still maintaining your comment?


**Code Quality: Critiical**

It is not very good practice to leave out semicolons from the end of a line of Javascript. See [this article](http://cjihrig.com/blog/the-dangers-of-javascripts-automatic-semicolon-insertion/) to see the potential dangers of this especially with a rapidly growing code base.


T_VOID doesn't already exist, and I didn't want to have to add a new token and also modify the code relating to void typehints; that would have made this patch much more complicated. This seemed the simpler implementation (at least for a proof-of-concept, anyway).


Looking at it now, it's decidedly odd.
This is essentially what @contextmanager does though.

I haven't a clue why I did it.
Maybe it can be made more reasonable.


No reason. I can change it.


Thanks @tylerbodway just working on a sass compiling issue and I can get this out! F6 will move onto Master when that happens.


We didn't need this line since we have the next line that override it :
pinholeIntrinsic->updateFromParams(mvg_intrinsicParams);


+1 The code change looks good, and all current unit tests pass (both debug and release builds); not sure how to unit test this specific case, though.


> Any experiences with such tools ?

Here is an example of what can be done with io.springfox and swagger-ui - I'll set up a demo next week so we can discuss it

![image](https://cloud.githubusercontent.com/assets/1701393/12205010/3755dc3e-b638-11e5-96b2-6195234b5914.png)


Thanks, will do.


It does not cause much noise for a single deployment, but when you consider having over 150 projects managed by Samson things could easily get out of hand.


111303866_ATSingleDuctReheat (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (946 of 946 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.63%25-green.svg)


Well, this make it easier if anything failed in the middle, I don't have to 'drop' those tables again. :). I prefer to keep this. Thoughts?


This is correct in that you're catching it, logging it, and then rewrapping it. However, this is unnecessary because if the promise's error isn't caught (i.e. no catch handler) then the error will automatically be printed, and in a better way, with a stack trace that should pinpoint the context. You're simulating the same thing because you re-reject it, and there is no further catch handler, but it's doing unnecessary work because the error will already be printed automatically without this handler.


@3rd-Eden I don't think it works with Browserify, unless I'm mistaken, it tries to bundle it anyway and fails on missing `bufferutil` and `utf-8-validate`.

It would be nice if you could keep the `browser` and `component` entries in your `package.json` even if they just point to `module.exports = global.WebSocket || global.MozWebSocket`…


shall we instead assert if `map->rules[r]` is not NULL?


@jakcron Debian unstable w/ gcc 5.3.1 installed from apt
(And I assume only MinGW gcc needs this change to build?)


I find that adding **padding-top: 60px;** does not fix this problem. What does fix it is removing **position: absolute;**. This is with 16 monitors on the page. The padding-top: 60px moves the image down but the footer still covers the last item which makes clicking on the links for that monitor impossible.


Here again, unwrapping and re-wrapping a promise unnecessarily.


**Code Quality: Nitpick**

Get rid of all debugging code in your file before submission.


Here again, unwrapping and re-wrapping a promise unnecessarily. omit this and previous handlers, you just need `return resolveVanityName(...);`. That's how short and concise it is, awesome!


@neobuddy89 in arch/arm/mm there are only 3 files which have "iommu_ops" in their files (xx.o comiled files) and this files are:
arch/arm/mm/fault.o
arch/arm/mm/dma-mapping.o (and also dma-mapping.c)
arch/arm/mm/iomap.o
and arch/arm/mm/built-in.o of course, I would focus on them


Is there a need to restore the original handlers so the test doesn't have side effects?


In that case, maybe we should just modify `canCoerce` to fail loudly if it ever gets a parametric type without parameters specified. Otherwise, it can mask subtle errors.


Where was the mixup? In general, we can always expect to have multiple unique identifier types that include "ID" in their name: tile IDs, layer IDs, source IDs, glyph IDs, sprite icon IDs. I'd rather be consistent and call them "X ID" everywhere instead of sometimes calling them IDs and sometimes names. Where necessary we can disambiguate, e.g. name a variable `tileID` rather than `id`.


Correct. Although you should clean up the formatting. I'd just do it like this:

``` js
} else {
  return Promise.resolve(trimmedInput);
}
```


Actually, this file should be renamed to partition_full_outer_join. It will be fixed.


Good work.


Name is not correct, should be "Mr. Brus Andrey"


strings.TrimSpace(pattern)


I might recommend renamign:

- `NodeState` to `ObligationState`
- `Leaf` to `Pending`
- `num_children` to `num_pending_children`


Directs for anonymous?

We should fail early if no user instead, like above functions.


lol


Can you create a branch off a 1.x.x tag?


@josevalim why was this necessary? Not having the host displayed in the output is a (minor) UI annoyance.


This is effectively only safe to run after compression, yes?


**Code Quality: Nitpick**

Always default to using the `===` operator when comparing values in Javascript. The difference between the two is that one checks for value while the other, `===`, checks for type as well.


so the fact that the node is null is synonymous of a "new" snapshot, correct?


Vervloekt! Had gehoopt dat subtiel te kunnen doorvoeren! :D


DOHH This is totally the wrong file.. I'll be destroying this clone in order to try again on the correct file.


**Code Quality: Nitpick**

Ensure to always use camel case for variable names. See [here](https://github.com/andela/code-review-guidelines/tree/master/coding-style-guides) for more information on this.


@brikr maybe just add a reference to : http://docs.ansible.com/ansible/playbooks_best_practices.html


I'm not one to usually nitpick about a little variable abbreviation here and there, but the block above has a lot of very similar and abbreviated variables, which makes them hard to read. Please consider using more explicit names.


Good to know it's working for everyone.


This was the only change made to the correct file, the rest of the changes are against the wrong file and will be discarded soon...


saw approval from javajolt
at https://github.com/basho/riak_core/commit/3fe6c86c74e2582a1b4d33da4015c0463490baee


merging basho/riak_core/fix/az/reintroduce-create_plan/5 = 3fe6c86c into borshop-integration-802-fix/az/reintroduce-create_plan/5


basho/riak_core/fix/az/reintroduce-create_plan/5 = 3fe6c86c merged ok, testing candidate = cc8f5471


Meaning I wonder if a more explicit model like below would help lisibility

```
neo4jTupleSnapshot.isNewSnapshot();

public boolean isNewSnapshot() {
    this.node == null;
}
```

could be used in the dialect and in Neo4jTupleSnapshot itself


Made also an request at https://bugzilla.mozilla.org/show_bug.cgi?id=504937#c23 to get this kind of messages dynamical directly from the API.

At least I haven't found any possibility to query that terms. :-(


The first incidence was originally a mistake; however, I left it because it
seemed easier to read. :)

On Tue, Jan 5, 2016 at 3:22 PM, Lingqiang Kong <notifications@github.com>
wrote:

> @bstraa <https://github.com/bstraa> Good xargs example. Make sure you
> check the preview section before submitting. Github markdown are different
> sometimes than regular md. Or did you intend to make your answers in the
> header format?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bstraa/dsp/commit/bb7178bc55ea8fb78aa052d7c24d24963559524e#commitcomment-15277072>
> .
>


please sms incoming receive work? thank you awesome dev ;)


not working for me 2.1 1.5 sdk
T1L = (pwm_steps[current_step] * pwm_multiplier);

and working 2.0 but stable sdk 1.3
i use pwm ILI9341 Lcd Screen LED.
if lcd screen write text pwm lcd led flicker


Good point. Was thinking on a single deployment. I'll revert it back to debug.


my phone autocorrects `JavaScript`. camel case it is!


tp


Yes


personally, I would be fine with a static boolean beenThere; property inside the AttributeConverter impls that can be checked by the test.


Why is this in CMake? Isn't this much easier to do inside flatbuffers.h (does not require running gcc)?


Done


do we still need these even after your fix?


Maybe add some comments on this type of formatting?


Ok, this looks great, although the logic seems a bit convoluted with all these branches. I'm trying to think of ways of how this could fail and we and the user might end up with no messages logged at all.


Good point, looks like we missed that. Will update soon.


Lets make these as simple as possible. First, make them structs (no need for public/private), and second, declare them inline next to their use (just above the std::sort call).


Oh well, I've used Doxygen for C/C++ and it allows you to document class
members at the declaration/definition site. Doxygen can generate Python,
but I've never tried, so it may not do what I'd want, but you might check
the it out.

The generated docs look good. I just started looking at it and and two
suggestions.

1) I think the "Craftfile" should be "Craftfile" (add the 'r').

2) In Getting Started example remove the emacs line and your copyright so
the craftr_module() stands out.

3) Change "Every Craftfile must have a module name declaration in its
head." to something like "Every Craftrfile must have a module name
declaration, craftr_module(my_module_name), anywhere in the first comment
block at the beginning of the file. Craftr will parse the comment and
amongst other things create some global objects such as project_name."

4) I'd move the Note to the end of the "Getting Started" section.

As usual take my suggestions with a large grain of salt!

On Fri, Jan 8, 2016, 7:34 AM Niklas Rosenstein <notifications@github.com>
wrote:

> Well you can put comments to where you assign the attribute in __init__(),
> but AFAIK no documentation generator reads that. You can add a class-level
> attribute and put comments before that, and Sphinx does take that into
> account, but you usually don't want to do that.
>
> You usually put the attribute documentation in the docstrings of the class.
>
> class Foo(object):
>   ''' This is Foo class.  .. attribute:: bar    List of spam and eggs.  '''
>
> What do you think of the docs at http://craftr.readthedocs.org ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/craftr-build/craftr/commit/470dc825565f1016975fd72af8e5456694382f70#commitcomment-15344666>
> .
>


yes, you're right


This is a strange edit


83811630_ReheatCoilSizingImprove (rongpengzhang) - x86_64-MacOS-10.9-clang: OK (1916 of 2042 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-93.83%25-yellow.svg)


@tontito I'm not sure I understood. Is it working with that change or not?
or do you say it's working on 1.3 but not on 1.5?


You might want to indicate that "Rosetta code" is a community that compares how algorithms/snippets of code are written in different languages.


Don't understand why don't use != ?


I don't think you should decref these. The input parameters are normally borrowed, meaning that you don't manipulate their refcounts at all. The cblas_innerproduct function was a bit funny about that (really confused me at first).
If you are still stuck, can you push it to the PR and notify me? I will run it through valgrind or gdb.


add `?w=1` to the end of the url to see the actual change


**Code Quality: Nitpick**

Indentation all over this file needs to be fixed. Please attend to everything as required.


Now, which log stream is that? Why not log it, so the user of that API knows which wrong value he/she has selected by mistake?


@yasuhiroki @yiufung @rileyjshaw @picasso250 @mitogh @m-takagi @lukeyeager @lsrom  @kumon @jameskolce @hyojin @fnzv @b-jazz @angel1a fyi -- you are now in the credits file :)


Thanks!


Nu, blame only @srisurya95
I haven't touched Flayr source :v


why does begin need to be copied here?


@srisurya95  y u do this ;-;


what about this empty test?


OK, I see now that in terms of the public api, there's an invariant: the forest is always compressed by the time control is returned to the client. Would be good to make note of that somewhere.


@softr8 I think you might put some code here or remove it otherwise


> the WORK_DIR is now src/work. It should probably still be just work/

I don't really care either way, src/work seems fine :)


did you intend to just compare against begin rather than use an extra variable (first)?


@tonito Make sure you are changing line 106 not 97..


Is this temporary? Because I'd expect that [stdout] would go to result.stdout.


These tutorials are a great resource, but the description doesn't do it justice. I would write something more like `[Control Tutorials for MATLAB and Simulink](URL) - This site contains quite a bit control theory, some practical applications and how to implement these in MATLAB and SimuLink.`


111303866_ATSingleDuctReheat (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2052 of 2052 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


That actually was excerpt:

http://dictionary.reference.com/browse/excerpt

Not a typo :)


> Op 8 jan. 2016, om 18:44 heeft Claude Paroz <notifications@github.com> het volgende geschreven:
>
> In recent Django versions, third-party app tests are not triggered by the test command, as the new default test discovery utility only search in the files of the current project. It is very difficult to test properly an app without knowing the exact settings used (aka integration tests), that's why Django made this move.
Yay for that.

> Are you still maintaining your comment?
Push that merge button!


For some feked up reason
https://github.com/SlimRoms/vendor_slim/blob/mm6.0/config/common.mk#L81
This is slim vendor, not AOSPB
Nearly same thing, just these few things :'3


What?


Leave a new comment


y u nu add me here beeches ;_________;


FlayOS :D


Ok, once again, app output is going to stderr. I'm assuming this is temporary.


@awelzel, if I understand the above exchange correctly, ordering of `nowait=False` (synchronous) requests/responses is not guaranteed, so there is nothing that can be done to improve this situation on the pika end, correct?


Hmm, what happens when a node is out of disk? I *think* we allow pods on it to continue running but just reject new pods. If that's the case, we want to continue including the out of disk node in the loadbalancer set, because the endpoints on it can still receive traffic.


`Staility` -> `Stability`.

Also, here again, I think the descriptions could be improved quite a bit. E.g. why is the second one called "BV78" (I guess those are the authors), what is RK 7-8, ...


OK


same here, make them structs, place them inline next to the call of GenPadding. Also no need for the Helper, instead, pass code and padding_id to GenPadding, that way none of these need constructors and instance variables.


@cmelchior awesome :smile: thanks for the update


Ok, yeah, I was really unsure of where I should decref or not. `cblas_matrixproduct` seems to do this, as well. There seem to be lots of those scattered about, but if we are not suppose to do them on `op*` I will remove them. I think I did try removing all the decrefs at one point, but I don't think it made a difference as far as the seg fault is concerned.

Yes, will do. It should be soon. Ok, thanks, please let me know if anything sticks out at you.


Not really the best place to ask, but this is the comment tied with `v0.15.1 For debian packaging`.

Debian still ships an ancient version 0.13 both for `scanmem` and `GameConqueror`, which have tons of issues I suppose have already been fixed.

I can compile it easily for myself (and I will), but I wanted to ask, if a v0.15.1 is "ready for Debian packaging", what happened that prevented this combing to Debian? Or at least the building of a `.deb`?

I'm on Debian Sid+Experimental, AFAIK you cannot be more bleeding edge in Debian.


Thanks! BTW, If at some time you need help with the Spanish translation just give me a mention.


Please adhere to the Google C++ StyleGuide: { on previous line, 2 space indent.


@WhiteNeo- That'd explain my Xperia T running out of memory frequently nowadays. Any idea how I could make the setting for Chrome only?


The discussion about this invariant should probably live with the data structure itself.


can you please make this (and other instances that might have the same nit) api.NamespaceDefault?


I am confused why this says you and I commited this together...  I am not familiar with this change...


> 1) I think the "Craftfile" should be "Craftfile" (add the 'r').

Could you go into more detail? I can't find a wrong spelling of "Craftfile" in the docs and your two examples are equal.

Thanks for the suggestions.


develop (mjwitte) - x86_64-MacOS-10.9-clang: OK (1495 of 1495 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I'm not sure if this is correct... If we _have_ the Forge plugin you set the mapping type to `NOTCH`?


It's unsafe to use `$.trim` here:

- It's valid for Markdown lines to begin with multiple spaces (nested lists, etc)
- It's valid for Markdown lines to end in multiple whitespace characters, such as when you end a line with two spaces to create a `<br>`. You need to insert the before/after syntax inside of the surrounding whitespace.


Addddiiiiiinnnggg


@BryanEngler @chriskian Is there a possibility that both "if (PropsValues.SEARCH_USE_DEEP_SEARCH && (searchContextGroupId == 0)) {" and "if (ListUtil.isEmpty(groupIds)) {" are true? If so, we need to refactor this to only call "groups.addAll(_groupLocalService.getUserGroups(userId, true));" once.


Space before paren


Should be `const char *`?


make this thing a regular function with these as parameters instead of a struct/class


Correct, missed that, thanks.


This is incorrect -- isNullable should have no effect on the MAX column width -- the easiest fix is to hard-code false for the isNullible parameter when calculating max.


Can you use an `ImmutableList.Builder` here?


ok, I'll update to specifically strip newline chars


But it makes no sense.
On Fri, Jan 8, 2016 at 12:41 PM Crowe <notifications@github.com> wrote:

> It looks cool.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/L0neKitsune/Botanical-Addons/commit/a260e77bd79dca6a3e8d2abf7e1c1450c9cea28a#commitcomment-15344806>
> .
>


bingo 2.1 sdk 1.5 only change 106 working :)


wew :'3


What's the difference between
```
 ${mpv_ldflags[@]}   versus  ${mpv_ldflags[*]}  ?


Just recognized that the action behind the button actually allows creating a certificate, as well as importing existing ones, so I've changed it to "assign or create certificate".


Borrowing was the only way to use this incredibly needed function


I see two concerns

> My most concern will be to load different maps for different players, don't know how this can be combined with per game maps.

What you're talking about is per-player button maps, not per-game button maps. This is an entirely separate issue and will probably have to be solved by some sort of player manager

> Also while the idea to map "jump" and "special" etc I often don't know how often a certain skill is to be used and if my buttonmap makes sense before actually playing it.

We're not mapping "jump" and "special" to the user's controller. We're mapping it to the N64 controller, which is constant and doesn't rely on the user. Is this what you're talking about?


丁寧なソースレビューのコメントありがとうございます！
わからない部分はひとつずつ調べながら問題点を確かめさせていただきます。

研究の抄録提出締め切りが来週の木曜に迫り、返信が少しおくれてしまうかもしれません。
すいません！


Agreed here - bindings should not mandate the policy (because these bindings are public and useful for other projects too)


My python is rusty... What happens if the number of lines in the actual vs. expected differs?


Ops, got the wrong (121) number from the previous line.
P.S. Thanks for the big round of updates.


Blya, suk. Oce zahkvar. Yak na takomu mozhno pisati?


Name                           Value
----                           -----
PSVersion                      5.0.10586.0
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.10586.0
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

This is on a Win10 machine.
Anyway...it is clear that there will be some people who don't have a version of New-SelfSignedCertificate that supports -Subject, so your change makes sense in the documentation. Go ahead and submit a pull request, and I'll merge it into our live docs.

Thanks again for your contribution!


Getting crash on startup:
```
F/libc    (17858): Fatal signal 6 (SIGABRT), code -6 in tid 17921 (ostwire.android)
W/libc    (17858): Security Level: (1), Debug inforamtion is controlled by the DUMPABLE flag.
I/DEBUG   (  457): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
I/DEBUG   (  457): Build fingerprint: 'htc/cingular_us/htc_m8:5.0.2/LRX22G/511189.2:user/release-keys'
I/DEBUG   (  457): Revision: '0'
I/DEBUG   (  457): ABI: 'arm'
I/DEBUG   (  457): pid: 17858, tid: 17921, name: ostwire.android  >>> com.frostwire.android <<<
I/DEBUG   (  457): signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
I/DEBUG   (  457):     r0 00000000  r1 00004601  r2 00000006  r3 00000000
I/DEBUG   (  457):     r4 b00dadd8  r5 00000006  r6 00000000  r7 0000010c
I/DEBUG   (  457):     r8 00000001  r9 000000a9  sl b00daa90  fp b8cc1da8
I/DEBUG   (  457):     ip 00004601  sp b00da758  lr b6f0a7b5  pc b6f313c8  cpsr 60000010
I/DEBUG   (  457):
I/DEBUG   (  457): backtrace:
I/DEBUG   (  457):     #00 pc 0003a3c8  /system/lib/libc.so (tgkill+12)
I/DEBUG   (  457):     #01 pc 000137b1  /system/lib/libc.so (pthread_kill+52)
I/DEBUG   (  457):     #02 pc 000143cf  /system/lib/libc.so (raise+10)
I/DEBUG   (  457):     #03 pc 00010cd5  /system/lib/libc.so (__libc_android_abort+36)
I/DEBUG   (  457):     #04 pc 0000f460  /system/lib/libc.so (abort+4)
I/DEBUG   (  457):     #05 pc 0026cf78  /data/app/com.frostwire.android-1/lib/arm/libjlibtorrent.so (boost::throw_exception(std::exception const&)+4)
I/DEBUG   (  457):     #06 pc 00455544  /data/app/com.frostwire.android-1/lib/arm/libjlibtorrent.so (libtorrent::dht::node_entry::node_entry(libtorrent::sha1_hash const&, boost::asio::ip::basic_endpoint<boost::asio::ip::udp>, int, bool)+140)
I/DEBUG   (  457):     #07 pc 003babfc  /data/app/com.frostwire.android-1/lib/arm/libjlibtorrent.so (libtorrent::dht::routing_table::node_seen(libtorrent::sha1_hash const&, boost::asio::ip::basic_endpoint<boost::asio::ip::udp>, int)+72)
I/DEBUG   (  457):     #08 pc 003bffc4  /data/app/com.frostwire.android-1/lib/arm/libjlibtorrent.so (libtorrent::dht::rpc_manager::incoming(libtorrent::dht::msg const&, libtorrent::sha1_hash*)+2268)
I/DEBUG   (  457):     #09 pc 003b20a0  /data/app/com.frostwire.android-1/lib/arm/libjlibtorrent.so (libtorrent::dht::node::incoming(libtorrent::dht::msg const&)+588)
I/DEBUG   (  457):     #10 pc 003a93e0  /data/app/com.frostwire.android-1/lib/arm/libjlibtorrent.so (libtorrent::dht::dht_tracker::incoming_packet(boost::system::error_code const&, boost::asio::ip::basic_endpoint<boost::asio::ip::udp> const&, char const*, int)+1200)
I/DEBUG   (  457):     #11 pc 00348d28  /data/app/com.frostwire.android-1/lib/arm/libjlibtorrent.so (libtorrent::udp_socket::call_handler(boost::system::error_code const&, boost::asio::ip::basic_endpoint<boost::asio::ip::udp> const&, char const*, int)+92)
I/DEBUG   (  457):     #12 pc 00349848  /data/app/com.frostwire.android-1/lib/arm/libjlibtorrent.so (libtorrent::udp_socket::on_read_impl(boost::asio::ip::basic_endpoint<boost::asio::ip::udp> const&, boost::system::error_code const&, unsigned int)+408)
I/DEBUG   (  457):     #13 pc 00349b78  /data/app/com.frostwire.android-1/lib/arm/libjlibtorrent.so (libtorrent::udp_socket::on_read(boost::system::error_code const&, boost::asio::basic_datagram_socket<boost::asio::ip::udp, boost::asio::datagram_socket_service<boost::asio::ip::udp> >*)+460)
I/DEBUG   (  457):     #14 pc 0034a284  /data/app/com.frostwire.android-1/lib/arm/libjlibtorrent.so (boost::asio::detail::reactive_null_buffers_op<libtorrent::aux::allocating_handler<boost::_bi::bind_t<void, boost::_mfi::mf2<void, libtorrent::udp_socket, boost::system::error_code const&, boost::asio::basic_datagram_socket<boost::asio::ip::udp, boost::asio::datagram_socket_service<boost::asio::ip::udp> >*>, boost::_bi::list3<boost::_bi::value<libtorrent::udp_socket*>, boost::arg<1>, boost::_bi::value<boost::asio::basic_datagr
I/DEBUG   (  457):     #15 pc 00291df8  /data/app/com.frostwire.android-1/lib/arm/libjlibtorrent.so (boost::asio::detail::epoll_reactor::descriptor_state::do_complete(boost::asio::detail::task_io_service*, boost::asio::detail::task_io_service_operation*, boost::system::error_code const&, unsigned int)+252)
I/DEBUG   (  457):     #16 pc 002593dc  /data/app/com.frostwire.android-1/lib/arm/libjlibtorrent.so (boost::asio::io_service::run()+1024)
I/DEBUG   (  457):     #17 pc 00258c44  /data/app/com.frostwire.android-1/lib/arm/libjlibtorrent.so (boost::asio::detail::posix_thread::func<boost::_bi::bind_t<unsigned int, boost::_mfi::mf0<unsigned int, boost::asio::io_service>, boost::_bi::list1<boost::_bi::value<boost::asio::io_service*> > > >::run()+32)
I/DEBUG   (  457):     #18 pc 00258b70  /data/app/com.frostwire.android-1/lib/arm/libjlibtorrent.so (boost_asio_detail_posix_thread_function+16)
I/DEBUG   (  457):     #19 pc 00012f7b  /system/lib/libc.so (__pthread_start(void*)+30)
I/DEBUG   (  457):     #20 pc 0001103f  /system/lib/libc.so (__start_thread+6)
E/libc    (  457): mmap fail (pid 457, tid 457, size 0, flags 0x2, errno 22(Invalid argument))
E/libc    (  457): mmap fail (pid 457, tid 457, size 0, flags 0x2, errno 22(Invalid argument))
E/libc    (  457): mmap fail (pid 457, tid 457, size 0, flags 0x2, errno 22(Invalid argument))
E/ActivityManager(  940): App crashed! Process: com.frostwire.android
```


Should this be expected to pass? The actual output has foo, bar, baz on 3 lines. The expected only expects foo and bar... Is the expected output required to completely match all the lines in the actual only only the leading lines?


I'd list these in desired order of installation (so Rcpp first). The reason is that if we end up using embedded dependencies (sometimes we have to bundle the development version of a package for a period of time) then they are installed using an alternate method that requires us to install them in order.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11045](https://teamcity.mesosphere.io/viewLog.html?buildId=102322&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:08:58


http://stackoverflow.com/questions/3348443/a-confusion-about-array-versus-array-in-the-context-of-a-bash-comple/3355375#3355375

It's the proper way to explode arrays to a string, basically.


Great Idea @krishnan-viswanathan – I know I've struggled with this as have many others.
Suggest looping in [Kendra Levine](https://twitter.com/tranlib) as the CRC for [ABJ30](https://www.mytrb.org/CommitteeDetails.aspx?CMTID=1141).


all tests pass:
success: http://buildbot.bos1/builders/test-riak_core/builds/1830


I'm not quite sure specifically where in the sentence you want to replace
what text with what text; any chance I can get you to propose a full
sentence or a full paragraph? I can take it as a GitHub comment and turn it
into a patch; you don't have to submit it as a pull request unless you want
to.


I guess I'm missing it.  where's the .(period)?


Could you add a corresponding tag? Thanks!


Ah, ok. Will fix.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11046](https://teamcity.mesosphere.io/viewLog.html?buildId=102323&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:09:14


Leftover?


**Code Quality: Critiical**

The function is redundant here. It is not needed except you need to modify the context variables before they are being passed into the template that is to be rendered.


Why split this into a separate module?


Yep. Just failed to push the tag, I guess. It's up now.


I wonder if there shouldn't be a `xapian_database_new_with_offset` convenience method in xapian-glib for this


Hopefully it will be possible to use any of the options found in the html-minifier module https://www.npmjs.com/package/html-minifier

Setting it to default collapse all whitespaces without a way to turn it off, is obviously not going to work well for many users.


Right :)


@Aaron1011 pointed out last night that SpongeVanilla is actually in SEARGE as well, I had assumed it was NOTCH because of the odd way you were setting `primarySrg` before. This part just needs deleting basically and then it'll be fine.


these are no good.. cut out on angler


Can we have a way to specify if the html is using an encoding other than utf8?


So where is your reply?
It's neither visible above, nor an email, nor in spam folder (checked it of course), nowhere. :-(
Could you maybe send it (again) or post it here?


yep


The same class name in different libraries makes this macro generate the same symbol name


This one means something else... I didn't put too much thought into this,
this is more "wasSSLSessionReused", or we could make it similar to
https://github.com/facebook/folly/blob/master/folly/io/async/AsyncSSLSocket.h#L365

On Wed, Jan 6, 2016 at 1:51 PM, Fred Emmott <notifications@github.com>
wrote:

> no return types?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/facebook/hhvm/commit/5331a1e7bbf39edb7270079b7cc66ec3b77bf19c#commitcomment-15302919>
> .
>


good


109626134b-AvailabilityManagerOutputUnits (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (2019 of 2020 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


Yes, I was just discussing with @ahmedshuhel We are going to provide a way to configure the options through our bundle config.


I see. And you're right on the timeline.

I guess I was hoping a more active approach from Rails to recommend how and what to render these JSON responses, since it's a necessity once you're in API mode (so to me this is same importance as promoting REST, erb and CoffeeScripts over others). It doesn't need to come in the form of selecting a gem even - say something like ActiveJob abstraction to enforce JSONAPI responses would be a step in that direction (if Rails endorses JSONAPI, for example).

Anyway, thanks for your time in explaining the decision process. :beers:


Seems to be a typo here!


closes issue #25


Looks good to me.


What was the purpose of this change? Unused here, and cannot replace [this code](https://github.com/jenkinsci/workflow-plugin/blob/1c87228afa7943b2ca578a066d166c14c2bc0d51/cps/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThreadDump.java#L75-L77).


I don't think this is possible.  Unless the user doesn't belong to any group, only one or none of these conditions will be met.  Also, I'm pretty sure which ever site the user is searching from will we added here: https://github.com/BryanEngler/liferay-portal/commit/4df18404eee95c20278e360b0186d2780a453743#diff-9196984b1b360235f6d9e32b7c598f94R217


copy-paste error with the comment here, I think.


Is this formatting intentional


I believe that this constant never changed, so we don't need to externalize it.


wtf mode change ?


@calvinatintel please merge


**Code Quality: Nitpick**

This function call is repeated three times and with each call makes a request to the database. This is not very optimal. Take advantage of more creative logic to ensure that this call happens just once.


Yeah, I assume the syntax you're using was added in https://github.com/MinecraftForge/ForgeGradle/commit/55e57ddf62e58031296494f3a42693e471ce951c, this was written before that commit existed. What is the current state of MixinGradle / Mixin 0.4.10? I'm planning to do some other general Gradle changes but I'd rather wait for the merge of this branch before starting with that so we don't get tons of conflicts.


You can just do:

```
let history, clock;

beforeEach(() => {
  clock = sinon.useFakeTimers(Number(moment('2013-10-20').zone(0).startOf('day').toDate()), 'Date');
});
```


You could directly use:
``
downgraded = (firmmajor <= 2 and firmminor <= 46 and firmrev <= 0)
``


Slick.


But it better describes validation logic, or not?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11047](https://teamcity.mesosphere.io/viewLog.html?buildId=102325&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:10:51


Let's rename it to clarify to what object if applies. I suggest `ReleaseDateNotInFuture`.


don't know why I didn't think of that...


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11050](https://teamcity.mesosphere.io/viewLog.html?buildId=102329&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:05


Actually, it doesn't matter whether only caller method is synchronized or not since `ConcurrentModificationException` can occur in a single thread too. Even you have described how can it occur with this sentence; `Need to check if region is null in case it was removed from the collection by another thread during iteration` because `foreach` does not allow you to remove an element from a collection (from any thread). If you wish you can check [this](http://stackoverflow.com/a/1196612).
By the way, I am not saying that it will cause exception but it can because I thought that is why an iterator used in the first place.


fast-forwarding end-to-end/timeseries to borshop-integration-802-fix/az/reintroduce-create_plan/5 = cc8f5471


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11048](https://teamcity.mesosphere.io/viewLog.html?buildId=102327&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:08:51


Damn


I'm new to all of this since I added travis to KeePassKit for testing so the documentation was still fresh in my mind :)


Where would the names go?

On 1/8/2016 10:09 AM, josephsl wrote:
>
> If you want, you could add two names: mine and yours, as both of us
> have worked on this and this is a good time to get recognized for your
> work (just my thoughts).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/derekriemer/nvda/commit/33189af8de2d73ee7bcd44ab21e21d40abedd45d#commitcomment-15344152>.
>

--
------------------------------------------------------------------------

    Derek Riemer

  * Department of computer science, third year undergraduate student.
  * Proud user of the NVDA screen reader.
  * Open source enthusiast.
  * Member of Bridge Cu
  * Avid skiier.

Websites:
Honors portfolio <http://derekriemer.drupalgardens.com>
Non-proffessional website. <http://derekriemer.pythonanywhere.com/personal>
Awesome little hand built weather app that rocks!
<http://derekriemer.pythonanywhere.com/weather>

email me at derek.riemer@colorado.edu <mailto:derek.riemer@colorado.edu>
Phone: (303) 906-2194


It too bad this line is needed.  In the normal use of createBroker the caller is the one that updates the broker list and knows where the created broker is stored.  After this change, the createBroker function is now tangled up a bit more about the state of the client than it was before (by duplicating some logic from another method).

Given the way that code is structured, it feels like the logic to re-create the broker when errors happen should be moved up to brokerForLeader().  That would keep this method with limited visibility into the state of the client and it would consolidate the logic for updating the broker list into a single method.


I'll write this method...


Hm...it is more common annotation. It checks any object, containing data information, not only release date. It is designed so you can define any data field names.


It's not a validation logic IMHO. The first day of the months is always 1 and it relates to our environment not to our validation rules. See also how I declared these fields:

```java
 	@Range(min = 1, max = MAX_DAYS_IN_MONTH, message = "{day.invalid}")
 	private Integer day;

	@Range(min = 1, max = MAX_MONTHS_IN_YEAR, message = "{month.invalid}")
 	private Integer month;
```
Probably, these constants also a bit obvious... Hm... AFAIR I've added them to fix CheckStyle's complains about magic numbers :)


memory_file=args.memory is still needed


111303866_ATSingleDuctReheat (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (2020 of 2020 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Should we be detecting the distribution from something in the source tree, or in the deb itself? For instance, if the deb depends on conjur-appliance-4.6.x then the distribution should be 4.6. Is it possible to do this automatically so that mistakes don't happen? It's kind of a DRY thing.


Just a thought, may be spell "dhollywood"?


>Hm...it is more common annotation. It checks any object, containing data information, not only release date. It is designed so you can define any data field names.

Yeah, that's my next point: let's make it specific :)


I though `copy_from` only worked on version 1 of the glance api.


I don't think that per user and per game are different issues.
Because when we talk about a per game map we imply that it is for the first player port.
But you are right and this shouldn't be combined, because it doesn't make sense to have 4 different maps for the same game stored along with a player port.

That's right we map to the n64 controller, but we are still talking about per game mappings, right?


"fuctional"?


Awesome thank you @jlevy


I had a brainlag regarding the second point


`true` is the default for both of these.


See https://docs.docker.com/engine/reference/api/docker_remote_api_v1.19/#create-a-container


Yes and it is still present, however, now that retries is in the call *memory_file* no longer needs to be a key word argument, it's a positional argument like *cookies*, *config* and *retries*.


What does `debian-local` mean?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1500 of 1500 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yes, you _could_ also wrap it in a promise yourself, that would work too. Don't forget to catch/reject errors as well.
My code allows you to just write:
```js
var files = [];
filewalker(dir, opts)
   .on('file', function (f) {
          files.push({
              some: f.path
              other: f.size
           });
   })
  .walk()
.then(function() { /* use files here */})
.catch(function(err) { /* use error here */ })
```


@jrjohnson IMO, it would be useful to have your commit message as a code comment in here.

```
Students do not have enough information to block together published as
TBD events on the calendar.  Instead anything with a ‘Scheduled’ title
and the same time block gets pushed together.
```

please add. thanks!


For the other commands, there is also a `:dir` option


Nice !!


I could never get this to work!


Let's validate not an `Object` but `AddSeriesForm`. This give us: 1) type-safety 2) less properties in annotation 3) don't need to use reflection


Maybe it's `follow` that's the key.


I forgot to remove my twitter username here, sorry for that. You might wanna edit it.


I thought about it, but as the default is sys.stdout (which avoids unnecessary `import sys` everywhere it's called from) I left it there. Those who supply different klass need to pay attention to it, though...

passing `**kwargs` seems like overhead to me. I thought about `args` but as the default is sys.stdout I think this is sufficient...


We may as well add a `secrets.yml`


Sure


develop (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1498 of 1498 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It's not really removed...


well it's app_logger, app_handler and app_error_handler, I can change it in the v2


Whoops, I'm suggesting "Craftrfile" as the default not that there was a misspelling.


Only the descriptor is ever used here, can we locally store this instead?


I didn't know about `Integer.parseUnsignedInt()` :)


line 215 can use either the attribute set or descriptor from 204


Is there a reason not to set to 'inherited' when the `project.sourceCompatibility` does match the `IdeaProject` value?


Oh, good point.

```
>>> zip([1, 2, 3], ['a', 'b'])
[(1, 'a'), (2, 'b')]
```

So here, if the number of lines in `actual` and `expected` differ, the common lines are checked. As you alluded to above, this causes the following example to pass:

Input:

```
foo
bar
baz
```

Expectation:

```
CHECK: foo
CHECK: bar
```

I think we should verify that *all* lines match; I'll amend this behavior such that the number of lines in `actual` and `expected` must match.


Actually he can if he specifies `--log none` (or `run ... -s`).


The Craftr ("crafter") is **craft**ing using **Craft**files. :)


True, I'll add it in the next version


Thanks a lot !

On Fri, Jan 8, 2016 at 12:03 AM, Nicolas Martinelli <
notifications@github.com> wrote:

> Fixed with 54be29f
> <https://github.com/odoo/odoo/commit/54be29f0bc3b757330e0e624983c6c8e614cd888>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/odoo/odoo/commit/3ebc2f4722830a22dd1fb57e18dd228f80b6fa2e#commitcomment-15334384>
> .
>


@vitaly-krugl Yes, I'm afraid it's not guaranteed.


i = 0


I'll continue review after you'll change the validator to use concrete object, because it should make code more readable...


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


or in `co`:

```js
co(function *() {
 var files = [];
 try {
  var fw = filewalker(dir, opts)
   .on('file', function (f) {
          files.push({
              some: f.path
              other: f.size
           });
   });
  yield fw.walk();
  // use files here
  // ...
 } catch (err) { /* use err here */ }
});
```


It's definitely not general enough. Authentication schemes are like snowflakes, each with their own special failure cases. For example:

- expired auth tokens
- invalid auth tokens
- invalid grant (oauth)

I think what you have is really solid for Basic Auth and provides a good usage example for others.


LGTM


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11051](https://teamcity.mesosphere.io/viewLog.html?buildId=102333&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:11:59


502 no?


overhaul*


In commit message, use revision instead of SHA1. Since at some point, we will rewrite the git history to remove binary data, SVN revisions are ensured to be valid.


Does `IdeaModule.jdk` setting have any impact here?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11049](https://teamcity.mesosphere.io/viewLog.html?buildId=102328&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:12:24


I will take care of the revision when integrating.


This needs to be done for Xcode7.2. There is a bug in Xcode7.2 if we compile the code it gives error `Hashable` not implemented.  But test was passing on linux.


I thought about that, but I think it complicates the library and starts to obfuscate what secrets a project needs. I can add a secrets.yml in the project root as an example though


These test cases should be more explicit about the expected behaviour: what value is present in the `.iml` file in each case?


Haha, I was wondering where this commit came from.


111303866_ATSingleDuctReheat (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1484 of 1484 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.63%25-green.svg)


Those two comments are for the two clauses I think.

```
 +        # we don't want to permanently cache something we'll edit
 +        not req.editable and
 +        # people expect `pip install .` to work without bumping the version
 +        not is_local_directory(req.url)
```


This shouldn't happen if there's no bugs.


That's right, but in this case the code is not modifying the collection used in the iteration.  It is simply iterating through `regions` (which is synchronized externally to this method ensuring it will not change), and inside the iteration loop it is conditionally adding elements to a different collection called `matched`.  So I don't think a `ConcurrentModificationException` can happen, and the `if (region != null)` check and corresponding comment can be removed.  Agree?


Again, maybe locally store the descriptor instead?


It's intentional. The difference is that it's the `test stdout`, but when you enable avocado test output, the test output goes to `stderr`. I changed it to this because this way you can simply filter `avocado.app` vs. everything else:

```
avocado run --log app,test run passtest
avocado run --log app,test run passtest 2>/dev/null
avocado run --log app,test run passtest >/dev/null
```

But of course I can change it. By my preference is definitely `avocado.app` in `stdout` (an errors to `stderr`) and all other streams (like `avocado.test`, `paramiko`, `''`, `avocado.app.debug`, ...) to `stderr`.


I expected that code will looks like this pseudo code:
```java
if (yearInFuture()) {
    return false
}

if (monthInFuture()) {
    return false
}

if (dayInFuture()) {
    return false
}

return true
```


Yeah i found that buried in the project's closed issues - with `follow` it behaves correctly


why the dots are there


A thousand thanks


We can handle it in a separate PR. I wasn't able to test the changes without that commit though. It is rather trivial, i think.


Btw the message is in `$results/stdout`, only when `--show-job-log` is specified it's logged in terminal as stderr.


That's the name of the repository on Artifactory


Hi, They would go on the copyright line.

From: derekriemer [mailto:notifications@github.com]
Sent: Friday, January 8, 2016 10:39 AM
To: derekriemer/nvda <nvda@noreply.github.com>
Cc: josephsl <joseph.lee22590@gmail.com>
Subject: Re: [nvda] The case sensitivity of the last find is remembered when searching using NVDA's find dialog. For Example, if Food is searched for with case sensitivity on Food will be found when pressing NVDA+f3, but food will not. (33189af)

Where would the names go?

On 1/8/2016 10:09 AM, josephsl wrote:
>
> If you want, you could add two names: mine and yours, as both of us
> have worked on this and this is a good time to get recognized for your
> work (just my thoughts).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/derekriemer/nvda/commit/33189af8de2d73ee7bcd44ab21e21d40abedd45d#commitcomment-15344152>.
>

--
------------------------------------------------------------------------

Derek Riemer

* Department of computer science, third year undergraduate student.
* Proud user of the NVDA screen reader.
* Open source enthusiast.
* Member of Bridge Cu
* Avid skiier.

Websites:
Honors portfolio <http://derekriemer.drupalgardens.com>
Non-proffessional website. <http://derekriemer.pythonanywhere.com/personal>
Awesome little hand built weather app that rocks!
<http://derekriemer.pythonanywhere.com/weather>

email me at derek.riemer@colorado.edu <mailto:derek.riemer@colorado.edu>
Phone: (303) 906-2194

—
Reply to this email directly or view it on GitHub <https://github.com/derekriemer/nvda/commit/33189af8de2d73ee7bcd44ab21e21d40abedd45d#commitcomment-15346027> .


OK, sure.


I think #581


im very sorry bro
i dont know about spamming etc
really i dont know


good thx for the tip


Oh I see, sorry about this, I'll fix it. (Although msg would suit me better :smile: )


`dir` doesn't make as much sense here because we're basically passing a string to `art` that it will interpolate in the Go globbing style - so if `package=dist/*.deb` it will handle that, we don't need to in Ruby


Plz dont comment on this page..aapav01 said that.


vvv


@harpalmsu @bhargav247 @RonakKosamia @jainishshah17 Do we have any weblink to see the webpage? Or user guide on how to run in local environment? I see bootstrap README but its more generic? Thanks


If u want to tell u something plz comment on xda thread page of this rom


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11055](https://teamcity.mesosphere.io/viewLog.html?buildId=102343&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:08


"they usually provide improved performance when executing large numbers of asynchronous tasks"
There is one thread per world, it isn't large number.

ThreadPoolExecutor is very useful when you have got a lot of small tasks. Now it doesn't make diffrence.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11054](https://teamcity.mesosphere.io/viewLog.html?buildId=102342&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:20


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11053](https://teamcity.mesosphere.io/viewLog.html?buildId=102339&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:20


Is the compiler clever enough to generate good code? I.e. the ROR function. Otherwise intrinsic could be a nice alternative. And maybe it could work for everybody.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11056](https://teamcity.mesosphere.io/viewLog.html?buildId=102344&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 174 Build time: 00:03:40


@DisposaBoy I added `{}` to the user config (it was just empty and panicing apparently), so now third-party packages work, but stdlib packages don't (no errors in console, GOPATH etc is unchanged from before).


`conjur-appliance` (the metapackage) depends on the service debs, the inverse relationship won't work. We could put a marker file in the project source if you like - at this point it's unclear how we're going to approach backwards-compatibility w/ debs and Conjur versions so I'd like to keep it as simple as possible and DRY it up when we know more


Won't this line leak memory if `latency_samples` is already allocated (and same below)?


thanks, removing the args


Note to the previous `@NotNullIfFirstField` validators. We should be validated after them to be sure that the values provided in the right combination.


Can we use %{swiftc} (etc.) as the substitutions? I have generally been doing this for all new lit test suites I create, and I think it is more readable and maintainable over time, this prevents ambiguities when starting to use substitutions which are part of other arguments, and may be something lit should move to requiring at some point.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11057](https://teamcity.mesosphere.io/viewLog.html?buildId=102345&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:08


mmmm, don't get wehre the error might be... I get this, now with gnuplot:

![sphere](https://dl.dropboxusercontent.com/u/16526900/Screenshot%20from%202016-01-08%2019%3A53%3A28.png)

I used to get Nans, and it was due to bad parameters of the covariance function. I'm using a sphere of radius 10 for points in f(x)=0, of radius 20 for outside, and of radius 1 for one single point inside. And using the gaussian kernel (I'm now trying with another kernel, but don't think that is it), with sigma = 2.0 and length = 3.0.


This should use lit_config.fatal() to report the diagnostic, and I would recommend splitting each check out into an individual statement for readability.

This will result in slightly better error messages, should this ever be triggered.


lit has a builtin substitution for the output directory (%t), why not use that?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11060](https://teamcity.mesosphere.io/viewLog.html?buildId=102358&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:03:57


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11059](https://teamcity.mesosphere.io/viewLog.html?buildId=102357&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:24


powercycle does not run on OpenStack (not implemented)


I should add, if the goal here is to ensure things are kept outside the source tree, then what you can do is set "config.test_exec_root" to a temporary directory. That will cause lit to produce a shadow tree mirroring the tree in the source root and use that directory for test outputs.


count: 1


If indices contains an out of range size_t, this seems to forward to a vector erase in AttributeSet::dropAttributes with an undefined position. dropAttributes called with a vector of names checks for name validity which would avoid this


@adityadalal924 This isn’t in the `dmg` (or have I missed it?).


Great work @szaghi and @jacobwilliams as always! I will review the code and update the make build over the weekend.

Can you describe what kind of issues do you notice with emd_rk solvers?


Will do! Thanks for the tip, I wasn't aware of `lit_config.fatal()`.


We should also `:delete` whatever it is it adds.


That's weird. My font was fine in 1.7.1. When using setFontScale(0.5f) my font looked like this:
![image](https://cloud.githubusercontent.com/assets/1280342/12206678/7fdaade2-b5ff-11e5-8aa9-c415eaac34f6.png)

Now, after upgrading to 1.7.2, it looks like this:
![image](https://cloud.githubusercontent.com/assets/1280342/12206720/b5fce1ce-b5ff-11e5-98c9-630b2b1a7e74.png)

...which is not nice.


At least we can discard plotting errors :+1:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11052](https://teamcity.mesosphere.io/viewLog.html?buildId=102338&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:11:13


I think this should still be create() since that's what we call it in other inner Factory classes ...

it seems like the convention is to use create() for inner Factory classes and get() for regular factory methods


Yes, I agree. I had to do so in https://github.com/apple/swift/pull/778/files#diff-f913ebb5bc611de19290c715fcdad913R275 when adding `%{python}`, since that conflicted with `%p`.


`BUG` -> `STYLE`


Let's show the date in the messages. Something like this: `Date (${value.getDay() != null ? value.getDay() +'.' : ''}${value.getMonth() != null ? value.getMonth() +'.' : ''}${value.getYear()}) must not be in future`


@plone/framework-team a new release would be awesome :-)


count: 3


Once 4.6 is out and we start working on the Jenkins matrix for appliance, it will be more clear how to construct this flow


`This commit update the ...` -> `This commit updates the ...`

And adds line return in the text.


there are lots of these files while tests are running which is annoying if you're trying to work with git at the same time

i'll remove it


this doesn't work..... ;c


Oh, derp, thanks!


Calling `resize(0)` two lines above should make sure that `rttest_sample_buffer` uses no allocation.


Ok, I managed to replicate the issue in small scale on lab.
I am gonna dig into that next week.


BTW I don't see any reasons why you define variables before it's usage. I always tries to define variables close to the place where are they used.


109626134b-AvailabilityManagerOutputUnits (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2013 of 2014 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


:+1:
Thanks postgres team for your amazing work


Why not memset. Easier to read. You need to cast it because effu.fnptr is an int not a pointer.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11058](https://teamcity.mesosphere.io/viewLog.html?buildId=102356&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:12:21


Gonzalo, felicitaciones......esto va por buen camino.
Gracias por el apoyo


change from timer to points system based off speed


fixed a small bug in latest commit


count: 2


Right, I was thinking of another situation which can't actually happen here.


Can we just hard code the number and save ourselves even having it in the template?


I want to name it create but I feel like that would be an issue if we wanted to later move to a cached instance.


stray print statement


Thousands separators might vary depending on the locale. But I like your thinking!


clusters/8-osd.yaml should have disk: 60 count: 1
clusters/3-osd-1-machine.yaml should have disk: 60 count 3
clusters/16-osd.yaml should have disk: 60 count 1


```
STYLE: Add test for CLI Node status update

This commit adds a test checking that CLI status has the expected
value following StatusModifiedEvent.

Possible status are the following:

    Idle
    Scheduled
    Running
    Cancelling
    Cancelled
    Completing
    Completed
    ErrorsMask
    CompletedWithErrors
    BusyMask
```


don't we want the backwards ones to set `None` to `[]` or `u'[]'`?


Je voudrais vous présenter le plan de mon sujet, en esperant qu'il obtiendra votre satisfaction:
1- Qu'est ce que raspberry pi 2.
2- Structure ( USB, HDMI, RAM, Micro SD, GPIO ...).
3- GPIO (détails).
4- SE ( Raspbian ...).
5- Programation (Scratch - Python).
6- Exemple pratique.
Je vous remercie d' avance, dans l' attente de votre acceptation.


These names should be generated by randomly choosing a noun and an adjective. Create a list of nouns, and another list of adjectives, randomly choose a word from each and concatenate the two.


The massive rewrite is done now, check out the SpectatorPlus repo, you are 71 commits behind :) .


Will this be going into the 0.6.5.4 point release?


but i don't know how to insert lolcats to text files


By the same logic, should all Factory inner classes create methods be called get()?


closes #110


good to know


Any reason why you're printing get_drink() twice?


I added in detection for ogres so that ogres wouldn't walk on goblins or other ogres.  The hit detection area was getting wordy and repetitive, so I cleaned it up and stuffed it inside a loop.

Hit "o" on the keyboard to spawn an ogre.


Actually on purpose so first line printed starts on a new line


I thought, year, month and day are unsigned, aren't they? :-)


Also, Localiztion now requires .Net 4.5


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1185.e3ea1677f25f24950ecebd117b8aeeb3c234b1d6](http://build.palaso.org/viewLog.html?buildId=67690&buildTypeId=bt431) outcome was **FAILURE**
Summary: Execution timeout; tests failed: 1, passed: 811, ignored: 7 Build time: 00:35:27
### Failed tests
```
GlyssenTests.dll: GlyssenTests.ProjectTests.UpdateProjectFromBundleData_BundleDoesNotContainLdmlFile_MaintainsOriginalQuoteSystem: <no details avaliable>

```


change


junk


I had that initially. But it gets converted to `None` by when `clean` is called. But `None` is a valid value today, hence the comment "reverse migration unnecessary since NULL is already a valid value for a multichoice field"


Nothing to ignore right now


Might be confusing to say "product card" then "card"


"The each product" typo


Let's make this a major version bump, as the underlying JAVA version is bumped from 7 to 8.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11061](https://teamcity.mesosphere.io/viewLog.html?buildId=102365&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:26


Comment block added below, if uncommented, presumably fixes that. But I like it the way it already is.


good catch, I've pushed a fix for it

On Fri, Jan 8, 2016 at 11:52 AM, Tim Graham <notifications@github.com>
wrote:

> Is there a need to restore the original handlers so the test doesn't have
> side effects?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fcurella/django/commit/120955c6c482977698c54fec2be644cbe0295080#commitcomment-15345085>
> .
>


это тоже должны быть ссылки


je potreba aby 'citation_record_type' byl 'indexed"?


OK do you mind waiting until tomorrow night until I do this or doing it yourself? I am going to be away from my computer for the night. Because I'll be in the mountains.

Sent from my iPhone
Please disregard errors as this is a smaller device.

> On Jan 8, 2016, at 11:53, josephsl <notifications@github.com> wrote:
>
> Hi, They would go on the copyright line.
>
>
>
> From: derekriemer [mailto:notifications@github.com]
> Sent: Friday, January 8, 2016 10:39 AM
> To: derekriemer/nvda <nvda@noreply.github.com>
> Cc: josephsl <joseph.lee22590@gmail.com>
> Subject: Re: [nvda] The case sensitivity of the last find is remembered when searching using NVDA's find dialog. For Example, if Food is searched for with case sensitivity on Food will be found when pressing NVDA+f3, but food will not. (33189af)
>
>
>
> Where would the names go?
>
> On 1/8/2016 10:09 AM, josephsl wrote:
> >
> > If you want, you could add two names: mine and yours, as both of us
> > have worked on this and this is a good time to get recognized for your
> > work (just my thoughts).
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/derekriemer/nvda/commit/33189af8de2d73ee7bcd44ab21e21d40abedd45d#commitcomment-15344152>.
> >
>
> --
> ------------------------------------------------------------------------
>
>
> Derek Riemer
>
> * Department of computer science, third year undergraduate student.
> * Proud user of the NVDA screen reader.
> * Open source enthusiast.
> * Member of Bridge Cu
> * Avid skiier.
>
> Websites:
> Honors portfolio <http://derekriemer.drupalgardens.com>
> Non-proffessional website. <http://derekriemer.pythonanywhere.com/personal>
> Awesome little hand built weather app that rocks!
> <http://derekriemer.pythonanywhere.com/weather>
>
> email me at derek.riemer@colorado.edu <mailto:derek.riemer@colorado.edu>
> Phone: (303) 906-2194
>
>
>
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/derekriemer/nvda/commit/33189af8de2d73ee7bcd44ab21e21d40abedd45d#commitcomment-15346027> .
>
> —
> Reply to this email directly or view it on GitHub.
>


Yay :dancer: :dancer: :dancer:


For #4


Why are you keeping it commented out rather than deleting it? :smile:


On Jan 8, 2016 11:20 AM, "Simo Sorce" <notifications@github.com> wrote:
>
> @frenche do you have any opinion on this ?
>

I'll try to have another look tomorrow as my Internet connection is
unstable (traveling in the US).
But I got a few comments.

It doesn't seem the problem is related to SPNEGO negotiations as for that
it would suffice to disable connection-bound or set only KRB5 mechanism.
So I guess the issue is generic, you don't want the browser to prompt if
authentication has failed (maybe u want to present a form-base auth
instead).
In other words, you don't want to re-auth if auth failed (any www-auth
header will cause browser to prompt for creds).

I think it would be nice to have such a feature but I suspect that RFC wise
u must set a WWW-Authenticate header when replying with 401 code (I'll have
to check though).

So maybe we can return 403 instead, as if we say you are nobody if you have
failed auth.
This is somewhat similar to AuthzSendForbiddenOnFailure (code wise is
simple, if auth failed set ret=403).


accidentally wrote ```#5``` instead of #6 :cry:


what are your thoughts on whether this comment should stay here or move to the `const`? to verify that this is 1 ms one might have to go up to the `const` anyway. And someone looking at just the `const` and contemplating whether to change it might not understand any constraints on the value.

Maybe it should go in both places?

This is me admitting I haven't thought a lot about whether constants should be documented at use sites or definition sites


Did you even try this? Coverity does not work with VS2015 yet.


They must have removed it from the docs. I cannot find why. Anyway, it's still there in [2.x](https://github.com/datastax/nodejs-driver/blob/2.2/lib/client.js#L161) and in  [3.x](https://github.com/datastax/nodejs-driver/blob/3.0/lib/client.js#L169).


added Scala Santa and link to Santa Giovanni in Laterano


Like an expiration date?


Cái này chạy đc chưa e ?


does this mean this isnt dead?


File SQL nằm ở đâu nè ?


Нельзя h1 вставить в параграф, вот как браузер это интерпретирует: http://prntscr.com/9nnjsu. Если очень нужно, можно заменить параграф дивом, но в этом нет необходимости, так что нужно просто убрать <p> и все


Por el formato, tienen que ser URL's. Los validators estaban ahí, lo que no estaba era que se mostrara el mensaje cuando el usuario pone otra cosa que no sea una url.


@kisom Hi, what kind of yubikey support did this configuration add?


109626134b-AvailabilityManagerOutputUnits (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (2019 of 2020 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


Yup.


so shouldn't this be included in the `if` block that the print statement appears in, to avoid an unnecessary newline?


Was this line intending to use the new class level annotation?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11062](https://teamcity.mesosphere.io/viewLog.html?buildId=102371&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:03:56


this should probably be `this._heroService.getHeroes().then(heroes => this.heroes = heroes);`


@ccrs if static analysis complains about an impossible case then ASSERT() is the way to go, the current mixed code is confusing to me too (not just to any static analysis tool). So can we remove the null check ?


and remove sudo


this should probably be `this._heroService.getHeroes().subcribe(heroes => this.heroes = heroes);`


Whoops I forgot to add it. Fixed thanks ^^


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (946 of 946 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.63%25-green.svg)


I add my favorite Code School pathes


You raise a good point.  I think the comment should be in the context where it can be understood and kept consistent.  That isn't here.  Offhand, I can't think of an example of where it makes more sense to define a constant in one place and explain the choice in the other.

I'll move the comment up to the definition site.


Of course I haven't tried it. I didn't want to build something that is not on main repo. I will revert.


Hi, Take time (the code looks fine to me; in effect, you are extending my own work (#4584)).

From: derekriemer [mailto:notifications@github.com]
Sent: Friday, January 8, 2016 11:25 AM
To: derekriemer/nvda <nvda@noreply.github.com>
Cc: josephsl <joseph.lee22590@gmail.com>
Subject: Re: [nvda] The case sensitivity of the last find is remembered when searching using NVDA's find dialog. For Example, if Food is searched for with case sensitivity on Food will be found when pressing NVDA+f3, but food will not. (33189af)

OK do you mind waiting until tomorrow night until I do this or doing it yourself? I am going to be away from my computer for the night. Because I'll be in the mountains.

Sent from my iPhone
Please disregard errors as this is a smaller device.

> On Jan 8, 2016, at 11:53, josephsl <notifications@github.com> wrote:
>
> Hi, They would go on the copyright line.
>
>
>
> From: derekriemer [mailto:notifications@github.com]
> Sent: Friday, January 8, 2016 10:39 AM
> To: derekriemer/nvda <nvda@noreply.github.com>
> Cc: josephsl <joseph.lee22590@gmail.com>
> Subject: Re: [nvda] The case sensitivity of the last find is remembered when searching using NVDA's find dialog. For Example, if Food is searched for with case sensitivity on Food will be found when pressing NVDA+f3, but food will not. (33189af)
>
>
>
> Where would the names go?
>
> On 1/8/2016 10:09 AM, josephsl wrote:
> >
> > If you want, you could add two names: mine and yours, as both of us
> > have worked on this and this is a good time to get recognized for your
> > work (just my thoughts).
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/derekriemer/nvda/commit/33189af8de2d73ee7bcd44ab21e21d40abedd45d#commitcomment-15344152>.
> >
>
> --
> ------------------------------------------------------------------------
>
>
> Derek Riemer
>
> * Department of computer science, third year undergraduate student.
> * Proud user of the NVDA screen reader.
> * Open source enthusiast.
> * Member of Bridge Cu
> * Avid skiier.
>
> Websites:
> Honors portfolio <http://derekriemer.drupalgardens.com>
> Non-proffessional website. <http://derekriemer.pythonanywhere.com/personal>
> Awesome little hand built weather app that rocks!
> <http://derekriemer.pythonanywhere.com/weather>
>
> email me at derek.riemer@colorado.edu <mailto:derek.riemer@colorado.edu>
> Phone: (303) 906-2194
>
>
>
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/derekriemer/nvda/commit/33189af8de2d73ee7bcd44ab21e21d40abedd45d#commitcomment-15346027> .
>
> —
> Reply to this email directly or view it on GitHub.
>

—
Reply to this email directly or view it on GitHub <https://github.com/derekriemer/nvda/commit/33189af8de2d73ee7bcd44ab21e21d40abedd45d#commitcomment-15346891> .


What's the reasoning behind making this Serializable? Shouldn't all instances of this trait be transient and stateless?


Well, you could have tried it beforehand.

Anyway, just revert and when they finally fix it we'll change it.


It looks like this should be a focus on a different type of technical debt that causes wear on the developer: when you push your developers too hard, don't listen to their concerns, etc


s/[stage1_mm] Modified unnecessary HSCTLR register setting/[stage1_mm] Removed unnecessary code/


develop (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1498 of 1498 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


добавь еще сюда правило для всех ссылок, убирающее подчеркивание, чтоб не было вот этого: http://prntscr.com/9nnng8 http://prntscr.com/9nnnmd http://prntscr.com/9nnnvj


You do not change any configuration for HSCTLR.


duplicated `returned`


agreed ;)


s/Moved hypervisor initialization related codes from vm_main to core/Moved initialization codes of hypervisor into core.[ch]/


also ...`subcribe` should be `subscribe`


s/Removed SMP related codes in vm_main.c/[VM_MAIN.C] Removed unused SMP related codes/


On occasion, you might need `lfe_io:format/2` or similar. Does this preclude that?


@davidyan74 :  I think this will cause issues because this buffer has been removed from the bufferIterator line 250 and then may not be processed


Also changed Type of image in book from bitmap to a string representing the URL of the image. Used Picasso Library to load and cache the image.


Other than this change (which only affects SpongeVanilla anyway afaict) I think it's basically ready to merge notwithstanding getting people to test it to make sure I didn't miss something stupid. Most critically it addresses the problem described in SpongePowered/Mixin#81 and in my testing of that issue it seems to be fine. It's really just a case of whether it broke anything else.

If it passes muster with people then I'll merge it later this evening.


Previously, in line 27, `count2` was `count`.  It overrode the X-point `count `in line 17, erroneously set it to 1, and returned it in `result.n_xpoint`.  Now `count2` in line 27 is a distinct counter.


I guess I'll revert that then. :-)


s/Modified some comments in vm_main.c/[vm_main.c] Modified some comments or [VM_MAIN.C] Modified some comments


Could this change be the issue of test case failing with following exceptions?

2016-01-08 19:18:24,466 [ProcessWideEventLoop] INFO  server.Server onMessage - Received subscriber request: SubscribeRequestTuple{version=1.0, identifier=tcp://testing-worker-linux-docker-99285560-3189-linux-4:58129/3.output.1, windowId=56900b7b, type=delay_to_operator/2.input, upstreamIdentifier=3.output.1, mask=0, partitions=null, bufferSize=0}

2016-01-08 19:18:24,467 [2/FIB:FailableFibonacciOperator] ERROR engine.GenericNode run - Catastrophic Error: Out of sequence BEGIN_WINDOW tuple 56900b7800000016 on port input while expecting 56900b7800000014


Commented out the color check when the player is jumping on platforms for now, makes it easier to test gameplay.


TeamCity LabKey :: LabkeyModules15.3 :: Git sqlserver 2014 [Build 88](https://teamcity.labkey.org/viewLog.html?buildId=295853&buildTypeId=LabkeyModules153_GitSqlserver2014) outcome was **SUCCESS**
Summary: Tests passed: 218 Build time: 00:16:17


"Removed unnecessary definition" is full enough.


Yep, I turned away from the keyboard while that part was not even half way finished ;)


:+1: Agree about the tangliness though, thanks for following up with more


조사를 좀 해보니... [http://androidhuman.com/560] 여기 나온 대로 하면 될 것 같은데... 그럼 MainActivity에 툴바부터 공사를 해야함...


Good catch!  That's what happens when I don't write tests!  Or even have that in a working sample.


I just tried it and it works fine.


s/Removed aligned(4KB) when declare level1 pagetable of stage1 translation/Removed aligned(4KB) attribute for level-1 page table of stage1 translation


Argument checks missing.


It won't work in a release because lfe won't be included.


I approve...I approve..


@carlosjoserg
Would you kindly do the same plot with radius 0.05 (the one i'm using) and also translate all points (inner,outer,model) to 1 along z axis ? (0,0,0 is kinect origin, you would never get an object there)  Also my outer sphere is 0.4 radius. I'm also using sigma=0.02 and length=0.03 (tried also with 2 and 3 before changing them)


If we want to capture the the function `T => SomeMethods[T]` where `SomeMethods[T] <: MethodExtensions[T]` into some implicit parameter that we can send into a map task, it'll have to be serializable.


It didn't work in a release before this commit anyway. I had to manually include it.

The following works fine.

lfe-cowboy-examples/upload/relx.config:
```erlang
{release, {'upload-example', "1"}, [upload, lfe, 'lone-ranger']}.
{extended_start_script, true}.
```

lfe-cowboy-examples/upload/Makefile:
```make
PROJECT     = $(notdir $(CURDIR))
DEPS        = cowboy lone-ranger
BUILD_DEPS  = lfe lfe.mk
DEP_PLUGINS = lfe.mk
dep_lfe.mk  = git https://github.com/ninenines/lfe.mk master
dep_cowboy  = git https://github.com/ninenines/cowboy master
dep_lone-ranger = git https://github.com/quasiquoting/lone-ranger master
include ../resources/make/erlang.mk
include ../resources/make/dev.mk
```


Anyway this commit is missing something. When we want to remove '__attribute((__aligned__(4096)))', before we should configure VTCR register, am I right? So this commit have to include that information.


Yay! Only the rdd diff.  I'll merge this.


:+1: , though it's starting to become a little hard to follow where you are going. :)


I think the usage model looks different here, instead of ansible ssh to lifeguard, then proxmoxer ssh root@localhost, this would have to be used as run local, then proxmoxer ssh with lifeguard@remoteHost . . . right?  This may be quicker to leverage in the short term though . . I think the interesting model would be ansible to remote host then proxmoxer (don't even need user/host!) sudo


that's the theoretical term (google tonal functional harmony). meaning that relative chords and notes play a specific role within the key. There is music in which this tonal functions are softened or completely abolished, and those are the cases in which this profile could be useful.


[...] **P**latoon **does** not [...]


Well yes, but it's still the server that need to respond with the correct CORS headers. I have the feeling too few people actually know about how JSONP actually works behind the scenes (by injecting `<script>` tags) so I felt a little background information wouldn't hurt.


We are going to initialize virtual machine before hypervisor or vmm init?


Also really, I need to configure my FTP properly in order to start finally using it


Hmm you had lfe in DEPS and lfe wasn't in the release?


@kaustavdm Thanks, that worked.  I grabbed the latest and can confirm my extra markdown from the specification files is rendering in the reports accurately, good job!


would `if default_variable` work?


guideline (pas de 's')


Yeah, I think so. I'll follow up.


Inconsistent alignment (if it was the only issue, I wouldn't have mentioned it but since there are a few typos anyway)


You should add unit-test for the new method.


Right. Same with `'lone-ranger'`.


Typo amound -> amount


I think what I wanted to point out is that even if we have to use two different services for `jsonp` vs `XMLHttpRequest` based communication they mostly share the same interface and in fact the `Jsonp` service inherits from the `Http` service.


OK I need to look at this.


update-copyright-year (jasondegraw) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


relx.config:
```erlang
{release, {'upload-example', "1"}, [upload]}.
{extended_start_script, true}.
```

Makefile:
```make
PROJECT     = $(notdir $(CURDIR))
DEPS        = lfe cowboy lone-ranger
BUILD_DEPS  = lfe.mk
DEP_PLUGINS = lfe.mk
dep_lfe.mk  = git https://github.com/ninenines/lfe.mk master
dep_cowboy  = git https://github.com/ninenines/cowboy master
dep_lone-ranger = git https://github.com/quasiquoting/lone-ranger master
include ../resources/make/erlang.mk
include ../resources/make/dev.mk
```

```fish
ls -1 _rel/upload-example/lib
```

```
cowboy-2.0.0-pre.2
cowlib-1.3.0
crypto-3.6.2
kernel-4.1.1
ranch-1.1.0
stdlib-2.7
upload-1
```


oops, the return -1 should just be return, doesn't matter a lot as the return from this sub is ignored.


oops, should NOT be reading ti a second time, will fix.


```erlang
=INFO REPORT==== 8-Jan-2016::13:52:14 ===
    application: upload
    exited: {bad_return,
                {{'upload-app',start,[normal,[]]},
                 {'EXIT',
                     {undef,
                         [{'lone-ranger','priv-file',[upload,"index.html"],[]},
                          {'upload-app',start,2,
                              [{file,"src/upload-app.lfe"},{line,13}]},
                          {application_master,start_it_old,4,
                              [{file,"application_master.erl"},
                               {line,273}]}]}}}}
    type: permanent
Eshell V7.2.1  (abort with ^G)
(upload-example@127.0.0.1)1> {"Kernel pid terminated",application_controller,"{application_start_failure,upload,{bad_return,{{'upload-app',start,[normal,[]]},{'EXIT',{undef,[{'lone-ranger','priv-file',[upload,\"index.html\"],[]},{'upload-app',start,2,[{file,\"src/upload-app.lfe\"},{line,13}]},{application_master,start_it_old,4,[{file,\"application_master.erl\"},{line,
```


This will be a new `semver` accurate release of the SDK, so let's just remove `getMap()` instead of Deprecate.


Oversight on my part. This was causing a bug discovered by @fezick. It should might resolve PD-2003.