> Another build dependency: libp11 currently only requires OpenSSL.

Well how useful is libp11 as a generic library? I'd simply consider it as an internal part of engine_pkcs11. If engine_pkcs11 is used with openssl there is no reason to use libp11.

> Limited portability: AFAIK p11-kit only builds/works on Unix-based operating systems, so making it a dependency would also limit the platforms supported by libp11. Conditional compilation (supporting the current code for loading PKCS#11 modules and the p11-kit API) would break the KISS principle.

gnutls uses p11-kit and that works in windows as well. Granted p11-kit's configuration in windows is manual (there is no automatic discovery of modules there), but it works.

> Limited flexibility: Some end-users prefer simplicity for their (possibly embedded) hardware, over the advanced features of p11-kit.

That could be true, but p11-kit is quite small comparing to openssl overall. Embedded systems are tricky, and whatever you do you may not please them. If space is an issue they would most likely skip libp11 and engine_pkcs11 completely and use plain PKCS#11 calls.

> No apparent benefits: We already achieved identical (please correct me if I'm wrong about it) functionality with p11-kit-proxy.

There are few disadvantages of the proxy module; it bundles all the available modules in the system as one, and places them into different slots. It also requires real-time function generation which doesn't work well with some selinux environments.

> dwmn2: If we're going to have a discussion along those lines, what I would actually like to do is kill libp11 and engine_pkcs11 completely. OpenSSL should support PKCS#11 as a first-class citizen. The APIs which currently take filenames for certificates and keys should accept PKCS#11 URIs seamlessly in place of those filenames.

I am for it, and we should plan for that, but should keep that as an ultimate goal. engine_pkcs11 has to be transformed step by step, so that it can be added in openssl, and then propose to include it, and then enable it transparently.


I like living dangerously.


I believe so, the 3px radius is defined for `pre` globally iirc


What does the API returns? Is the "url" a path to the audio file on the server? And what about "thumbnail_url">


I'd be in favor of dropping the commit in that case.


Maybe then ``try/except``. Besides of catching also subclasses, it's also faster and has an advantage in multithreading environments (maybe not that important in this case, but anyways.).
For beeing faster, the ``try`` clause should contain the more frequent case because the ``except`` case is more expensive. See: http://stackoverflow.com/questions/8107695/python-faq-how-fast-are-exceptions


fix the comment as well


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11838](https://teamcity.mesosphere.io/viewLog.html?buildId=107031&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:03:34


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11840](https://teamcity.mesosphere.io/viewLog.html?buildId=107033&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:03:31


removing unneeded  unified function as save_node_selector_parts_inventory is removed completely


Yes, dropping it sounds to me the best.


this is perhaps confsing since the inception of concept. conferencetype property defines that conference is either Audio, Audio/Web, Web etc. Having recurring/onetime/instant nature is another dimension of conference type. Merging these additional properties with conferebcetype propery will make things confusing that's why we need these types of flags to mark this type of additional conference nature explicitly.


sneaky


oh, just did see your comments above. mine is obsolete, except if this is a performance critical path and one case is much more frequent than the other.


If your interested in some free lancing work for RF hacks.I'm paying good money if you can recode the HS bypass and auto login script in case of dc. Comment your email or a ez way to contact if interested or I can just message you on Skype.


@HHS81 Gosh, I haven't seen this huge commit of yours, thanks for the work, Heiko! I will add texture to
the three main levers (fixing https://github.com/HHS81/c182/issues/15) in `Models/PanelTexturing-MainPanel.png` and then push all my textures today, okay? But here is a question: the file `Models/PanelTexturing-MainPanel.png` was 2048x1024 pixels long, now you resized it to 2048x2048. Is that intentional? If so, is that really necessary? I can just resize my work of course, but I think the original ratio was much better, particularly since the only addition to the paintkit is the three levers. Let me know so I can push everything today, okay?


```go
return start.StartAPI(openshiftConfig, kubeMasterConfig)
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11839](https://teamcity.mesosphere.io/viewLog.html?buildId=107032&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:06:44


Done


Scenarios Ok


v další úpravě na to budu myslet


`replaceExpressions` ?


@tazmanska Just merged ActivitySegmentTimeComparisonModifier.js to my develop branch !

Thanks again for your work... I can just say thanks again and again ;) :p

Little question... i've seen that ActivitySegmentTimeComparisonModifier.js is requiring lot of cpu ressources and block execution of the rest of the page. Have a look to: https://github.com/thomaschampagne/stravistix/issues/177#issuecomment-172387896

Is there a way to easily introduce webworker into **ActivitySegmentTimeComparison**. To process in another thread the heavy work of this feature? Just need to know where have i to lean on.

Thanks again for all !

Tom


nebudu není to možné, musel bych objekt vytáhnout 2x


check for the error


Thanks for the comments @rogerhutchings Fair point, I was just playing but it doesn't seem worth using the plugin. I'll try to use standard markup


Please revert to previous versions
https://github.com/Thinstation/thinstation/commit/8c55f731915135521661439ef44370d028fe4ef4

Tested with latest versions and usbdevice is mounted with
ts:~# df -h
Filesystem                Size      Used Available Use% Mounted on
rootfs                 1007.1M    772.0K   1006.3M   0% /
/dev/root                76.3M     76.3M         0 100% /oldroot
tmpfs                  1007.1M    772.0K   1006.3M   0% /oldroot/mnt/dynamic
none                   1007.1M    772.0K   1006.3M   0% /
dev                     968.7M         0    968.7M   0% /dev
tmpfs                  1007.1M     32.0K   1007.0M   0% /tmp
tmpfs                  1007.1M     72.0K   1007.0M   0% /dev/shm
/dev/sda1               979.1M     80.3M    898.9M   8% /mnt/mnt/usbdevice/sda1


Macedonia is not former anymore. It is Republic of Macedonia

Official name for Iran is Islamic Republic of Iran

These translations, when implemented, should be in front AND back-end.


What is the problem when methods with __forceinline are placed into different module? It can't compile code or there is penalty or what?


yep you are right @alecpl ! thanks for noticing that stupidly i've applied it only to the first variable only.


Do you notice any improvement in battery/performance?  (One thing I'd really like to do is get the kernel up to date with caf.  @zion959 was working on this...)


You continue PR to this branch until it is PERFECT


Yeah, i was searching the changes in Habbo.swf and i was sending a Pull Request for this. But you already changed. Good job!


We should not remove it as 'haspassword' defines the property of a conference that whether  the conference is password protected or not. if we remove then all existing and new clients will not be able to detect this particular nature of a conference. Let us revert this change.


the function test was a test to see if there is no majore error


semiJoinResult?


It is not evident why you substitude `NULL` with `-1`?


remove?


There's always a trade-off between 'adding a extra dependency' and 're-inventing the wheel'... what's your plan for this area, it's listing classrooms but will it be doing anything else?


Please make sure it should not be a regression due to refactoring.


@brentvatne `ViewPager` should already be removing / recycling offscreen pages, but I'm not familiar with it.


This will work. It involves a copy of the lambda object, and every by-value capture, at step 3 to a std::function object. It the lambda is captureless this can be done without any memory allocations, as the lambda decays to a function pointer. If it does have captures, than the std::function object constructed for the scedular may have to allocate dydnamic memory to store the captures.


personalid and access code(one for leader and one for participant) are different properties of a conference.
personalid identifies a user and access code identity that if the joining party is a leader or a participant.
We should not remove this property seeing we will have an impact on calling parties at present and in future.


When listing the imported functions/types explicitly, I would usually just import them unqualified (unless there are name clashes). There is no need to change this here (it concerns several files), just a general observation.


`--user`?


Did this work for switching the `Action` namespace?


user select the digits in this access code as opposed to system generates the access code for a conference,


@aseemk @rauchg Adding ```"browser": {"ws": false}``` fixes it for webpack but not for react-native (which uses babel) see https://github.com/SocketCluster/socketcluster-client/issues/40#issuecomment-172470753

I'm also starting to think that forking may be the only full solution for now. It seems that these old settings: https://github.com/websockets/ws/blob/49b11093e9a009e5305dcde7003d3a896b2811dc/package.json#L37-L42 are compatible with browserify, babel and webpack but the new solution https://github.com/socketio/engine.io-client/blob/master/package.json#L56 is only compatible with browserify and webpack.


In build 2648 adding a new skill (example at index 58) will cause problems to the server.

The skillmenu will not open anymore.
Setting values to the new skill crash the server(if the new skill has also  the SKF_SCRIPTED flag, it will not crash but just throw errors)
Doing .allskills value  will not crash the server but will throws error in the Sphere's console
Using .show newSkillKey doesn't display the value at all.

In previous build new custom skills were working fine :D


@Alefas That doesn't sound good. I hope it gets better. I was suggesting this because I can see things like `false` became `true`, and some subtle conditions changed. It looks like the kind of changes that fix whatever you're looking at right now, then break something you're not looking at.


should be "if selected already".


> I guess your main issue is that the functionality just isn't useful if one doesn't use Pocket, right? If so, would only showing it if the user is logged in to Pocket perhaps make it ok?

I'm not using Pocket, so I'm biased in that sense, and I thus don't have a particular broad view of what Pocket users would want from this. I also don't have a better idea for a shorter label, so I was trying to find alternatives without the length being a problem at all. At the very least, yes, not showing it for non-Pocket users would be better. I guess that would mechanically make it work on ESR38 which doesn't have Pocket, too.


yepp.. merging these and more. Thanks.


This is the first activity. The login in.


@artpol84 any plan to PR to v2.x ?
without this, there is a warning at line 635 iirc


Thanks for your kindly reminding:).


@talevy can we also have a quick test that tests the default separator please? see https://github.com/elastic/elasticsearch/pull/15968#discussion_r49843809 . I think it's good to test a custom separator but now we don't test using the default one, which will be used in most of the cases.


The only other thing it'll do is having a "New" button for creating a new classroom.


if some of the functions change interface, it won't be detected by the compiler.  Now, refactoring is possible as if you change any function prototype, it will be checked elsewhere.


Shouldn't this be `#ifndef`?


No need for pos_start anymore, as we are en/decoding the whole message.


@angelblue05 it should now be fixed altough I don't have an android device to test it with


Couldn't this fail if "allow_ips" is already listed in `thentosTestConfigSources`?


> Widgets added to this region will appear beneath the header and above the main content.

How is that not clear?


https://github.com/open-mpi/ompi-release/pull/888

2016-01-18 17:02 GMT+06:00 Gilles Gouaillardet <notifications@github.com>:

> @artpol84 <https://github.com/artpol84> any plan to PR to v2.x ?
> without this, there is a warning at line 635 iirc
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/open-mpi/ompi/commit/6a791c30267a50d79d164b8b78ae19ff692b2867#commitcomment-15504132>
> .
>

--
С Уважением, Поляков Артем Юрьевич
Best regards, Artem Y. Polyakov


Same here.


This revision is clean.


We are no appending decoded message anymore, so no need to append it to the end.


I can't shut up... there's a TAB here! :-p


hi @SidFerreira, @jBenes,

What does this syntax mean?
`'/'. ImgCache.options.localCacheFolder`
I try this in the JS console and get 'undefined', was it supposed to be:
`'/' + ImgCache.options.localCacheFolder`

Anyway, I'm trying this with code with the latest *imgcache* and *angular* and in fact `dest` is already a string and not an object, resulting in dest.fullPath == undefined. So, I changed my code to:
`                    var img_src = (dest.fullPath) ? dest.fullPath.replace('/'. ImgCache.options.localCacheFolder, ImgCache.getCacheFolderURI()) : dest;
`

thanks,
Fernando


As discussed, the alias `__me__` should be supported for logins in the 3 web services, as it's done in api/issues/search. This alias should be documented, including "since 5.4"


pos_encode is no more needed after this patch.


Ok, won't change it then.  In general I agree, but in this instance doing both explicit and qualified import made sense to me.  More of a gut decision.


I've worked my way through the code and fixed the remaining unicode issues I could find.


The `raise_plugins` logic already sprawls through a lot of sosreport code; if we are changing this I would prefer to have this refactored such that we have the list of "raise conditions" in a single location (and with a comment and an adequate explanation in the commit message as I already indicated - a change like this still warrants more than a single sentence of explanation).

E.g. one way to handle this would be to introduce a new function that indicates whether plugin exceptions should be raised or not (and that evaluates the debug and exit controls appropriately).


Can you please break the line


DONE! all from 4.5.y :)
https://github.com/dorimanx/DORIMANX_LG_STOCK_LP_KERNEL/commits/master


I think this line also needs libtool->libtoolize; I'll push an update.


yes it should


The log level set by `withLogger'` is still DEBUG?


This is a shortcut for:

```C++
#if defined(YOTTA_CONFIG_CORE_UTIL_FUNCTIONAL_FUNCTORFP_INITIAL) && YOTTA_CONFIG_CORE_UTIL_FUNCTIONAL_FUNCTORFP_INITIAL
```

I am concerned, however, about whether or not this will generate ```-Wundef``` warnings.  I haven't seen any so far, but that's no guarantee.


Yes, these are very simplistic tests that I was using to prove out functionality. A much more complete set is necessary; they won't use things like this.


I would have preferred names such as `createCmd`, `wipeCmd` instead of trailing underscores.


Something tells me this will get messy the more features are added. Maybe this should rather be under a `supports` object hash?
Could you please add a property for telling VS Code that breaking on "all" (caught) exceptions is not supported, so that checkbox can be greyed out?


Yes, the current ref doesn't require overriding in the copy constructor, whereas it's important to decrement the reference before overwrite in the assignment operator.


its an additional layer of security seeing access codes(or custom access code -used seldom) are easily propagated in emails.
there is an option to send or not meeting password in the system generated meeting invite email.


@AndrKlesh @Omennight
Этот файл также следует добавить в .gitignore


Protecting against `0` is perfectly fine in this case, but maybe somewhere else you only want to allow power-of-two values here.
That's already quite complex and probably should be done more generically in a JSON schema.


Should be "canola" oil!


breakpontList -> rename to breakpointList


the configifier source monoid is defined to allow for overrides: if something is defined on the left, it can be overwritten on the right.

what configifier doesn't have an answer for is the question of how to remove previously defined values.  not sure if `allow_ips:` would delete previous values, do nothing, or cause some error.  but i think that's not the question you are asking, and it's not relevant in this particular piece of code.


There is a gem https://github.com/jclay/bootstrap-notify-gem


Will this work for both lower & upper case?


@ANiknejad, yiu reintroduced a typo:
Lines 172 to 207, the platform is neither `Illumina Genome Analyzer Iix`, no `Illumina Genome Analyzer Ilx"`, but `"Illumina Genome Analyzer IIx` (2 capital "i", not a small "L")


While provisioning AWV server you can create departments to segregate users in groups across the organization.
Having this feature is useful to get a department wise view in some of the reports or cdr.


No. Do we expect upper case values?


Keep only on function with $(".export_tomtom a"), refactor the code.


copied wrong file


all of these properties are used in SOAP APIs as well and will be useful in many existing client scenarios and ones coming in future.
You can think of a mapping that all REST APIs should provide all options to a client which user gets in web page while scheduling a conference manually. Ultimately we are just mapping users actions with API calls.


What is the working dir was changed since the last call to `thentosTestConfig`? We would then stay in that directory instead of returning to the one defined in the config.


missing `times`: either ` x%f %s than` of `%f times %s than`


Переключалки сейчас не добавляем. Но код оставил, чтобы не восстанавливать его потом заново.


You're right. I'll add one in.


Oh the joy =D
There are some approaches you can follow here: in the first moment, you could have two nodes, one for 'illuminance' and other for 'intensity'.
Then, we could change our IIO API to deal with '_input' channels as well. Maybe a change to `sol_iio_channel_config` to state that a channel is actually a processed channel - instead of raw - and on read do not apply scale or offset.


I don't know may be, I mean we can't really predict what users can do, can we? I think it is safe to just assume people might use caps.


竹井くん

レビューを確認してくれてありがとう!
返信してもらった内容を見ていますが、修正した内容をこちらで確認したいので、プルリクエストを出してもらいたいと思います。

修正する範囲は、こちらでレビューがあった箇所です。自分で気づいた箇所があれば、追加で修正してもらって構いません。
※ レビュー内で「修正不要」等の旨が書かれているものは無理して修正しなくて結構です。
現在のブランチが「master」になっていますが、修正内容は「master」から新しいブランチを作って、その新しいブランチに反映し、「master」と新しいブランチの差分をプルリクエストとして提出してください。
こちらのレビューが分かりづらかったり、プルリクエストの出し方が分からない場合は、気軽に質問してください。

今月末を目安と考えていますが、プルリクエストの提出がいつまでに可能か、教えてもらえますか？
再提出後、もう少し修正が必要な場合は、再度直してもらう可能性がありますので、1回で終わるように頑張ってみてください！

よろしくお願いします。


yes it does


Fixed in ad7396c84ba32ea7d5c47cfcd2a4ef661facaaa4


`this` -> `these`


@felixfbecker Why do you think that nesting the features under "supports" makes it less messy?

All options for the setExceptionsBreakpoints will be provided through this mechanism in the Feb drop. We are just not sure how to deal with this in the UI.


`on` -> `of`
`argument` -> `arguments`


On a side note, the stack increase that snuck into this commit did not fix the mingw-w64 crash with ms-compress, it turned out to be an unrelated issue (coderforlife/ms-compress/issues/28).


For now, we would reject and force them to use lower case. Would that be good enough? :)


just wonder if this should be LOGGER.error level?


It seems using static imports is good for this place, as there are 10+ imports


this is needed to ensure that dialout happens for when scheduling an "instant conference".
We need to merge properties of instant and a scheduled conference at some point hence this field is needed.
will update the swagger documents for all such cases. its an option property.


LOGGER.error level?


no longer relevant.  see b9a5c2c.


same here .error ?


will fix.


ddd


Within the importer, the validation of the transactionjournal is still used (see https://github.com/JC5/firefly-iii/blob/develop/app/Helpers/Csv/Importer.php#L272), and therefore importing doesn't work right now. I would suggest either removing the validation code from the importer or reintroduce the validation rules in the transaction journal object.

However, I'm not sure which option would be appropriate.


http://jenkins.imagicalcorp.ml:8080/job/ImagicalMine/504/console
Build had an error...


基本的にblade内だったら{{-- コメント --}}で揃えちゃっていいかな、と思います。
外部にコメントが見えていて都合が良い時ってあまり無いですからね。

あとは、以前あった事例として、http://allabout-japan.com/en/ みたいに、多言語サイトを取り扱う時は
```html
<html lang="zh-tw">
```
というような言語別の設定を入れるのだけど、この設定が入っているのに、htmlのソースに日本語コメントが入っているのは都合が悪いということでコメントが全てレンダリングされないようにしたことがあります。


I would suggest: `Slow down or accelerate the simulation relative to real-time (default behaviour: real-time simulation) by modifying the *time scale* of the simulation.`


I guess this is a PEP8 fix?  Technically it belongs in a separate commit, but I'm OK if you don't want to bother changing it on this occasion ;-)


Fixed :)


ごめん、もう少ししっかりと書いておけばよかった。

CommentsControllerのstore()にある下記の処理はCommentのfillableに影響するから、fillableを正しく設定しないとコメント投稿でアプリケーションが落ちると思う。

```
$this->comments->create()
```

現状のソースだとコメント投稿ができていないから確認してみて。


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/25657/testReport/) for this commit**


I would suggest: `factor by which the simulation should be slowed down, relative to real-time`


Sure
thanks


I would suggest: `factor by which the simulation should be accelerated, relative to real-time`


 > Why do you think that nesting the features under "supports" makes it less messy?

Personal preference.
```ts
supports: {
  configurationDoneRequest?: boolean;
  evaluateForHovers?: boolean;
  breakOnCaughtExceptions?: boolean;
}
```

 > All options for the setExceptionsBreakpoints will be provided through this mechanism in the Feb drop. We are just not sure how to deal with this in the UI.

:+1:


You can put the png into your features directory, then reference it using kango.io.getResourceUrl() which returns a specific URL for each browser.

Docs: http://kangoextensions.com/docs/api-reference/kango-io.html#kango-io-getresourceurl

Now as for a clean way to inject this into the CSS, I'd just set this property with $('.inspector-resize-handle').attr('background', 'your property') immediately after you call $('section').resizable(). Nothing else is going to be messing with your DOM.


@AGaliuzov please read PR description


Unit tests failure unrelated (JsonFormatTest::testStructureMatchingWithLazyLoad)


The `NOINLINE` makes sure that three is only ever one call to this function.


Thanks a lot for splitting lines like I requested :-)  As with the PEP8 nitpick, I'm fine with this change, but in future it would make reviews a bit easier if you kept the line-splitting refactoring (i.e. no functionality change) in a separate commit, and then made any change in functionality in a subsequent commit, so it's easy to see what changed (IIUC it is the extra int parameter at the end, right?) rather than mixing them up together.


> Well how useful is libp11 as a generic library?

Ubuntu 15.10 (via `apt-rdepends -r libp11-2`) indicates libp11 is also used by:

* libdigidocpp0
* libpam-p11
* qdigidoc
* qesteidutil

I guess there are also other products, not packaged in Ubuntu.

> There are few disadvantages of the proxy module; it bundles all the available modules in the system as one, and places them into different slots.

How does it affect engine_pkcs11?

> It also requires real-time function generation which doesn't work well with some selinux environments.

How critical is this issue?


for example dialing out to multiple UCA users in a group chat inside UCA. so better to keep it with this request itself and document properly.


Thanks!


Hadn't seen the `integrity` and `crossorigin` attrs used before.
Looked them up after seeing this and that is some very cool stuff.


not sure about this one, because i don't want to overwrite the current value if the user has left it blank. e.g. if the activity config has
"total_time": 3600
and the user config has
"total_time":
then I want it to keep the activity config, so it's not as simple as try except. It probably does want documenting and testing


Same [comment](https://github.com/abel-navarro/automation/commit/6cea4778ff76fbc18a06b1dce039d23eb4b09ae0#commitcomment-15504631) I made in #764.


@thomaschampagne I will look into it.


This fixed bug https://bugzilla.xamarin.com/show_bug.cgi?id=37649


I think it will be confusing. Just think of the message "Unexpected value TRUE  set as the value of boolean. Boolean (true or false), ConceptService.getTrueConcept or ConceptService.getFalseConcept expected". I guess some people might realize it is case issue but some may not. It is not such a big change anyway, is it?


OK.. fair enough. I think actually the error re: prematurely quitting can only have occurred if one platform had finished before the other one started, right ?


yeah.


I think we can achieve thread-safety with an inline cache like this <http://random-state.net/log/3507100003.html> without depending on bordeaux threads. The inline cache would be in the body returned by `ffcall-body-libffi`. In any case, you should start by reverting this commit. :-)


Command to replace `function ob_callback(&$buffer)` with `function ob_callback($buffer)`
sed -i.bak 's/function ob_callback(&/function ob_callback(/g' /path/to/public_html/wp-content/plugins/w3-total-cache/lib/W3/Plugin/TotalCache.php

You can skip the -i.bak option to prevent a backup file from being created.


```
_.forEach(array, function(key, value){
   // your cool code
})
```


Hi Chris,
Apologies if this is a really silly question but I am unfortunately not a coding/python/nipype person!

I am having problems with EpiReg and I think it is because of this issue you found - i.e. it thinks that the fieldmap is a mandatory input/output.

Am I correct in assuming that the solution is what you posted above? I.e. delete the lines in red and add in the lines that you have highlighted in green?

I just want to double check before I change scripts that my colleagues also use.....

Thanks,
Sara


Maybe we can optimize performance: by filtering and returning zero when the code is not "mrp_operation". That way, the system does not do any calculations when it is not a manufacturing picking type.


Please change snake-case to camel-case. Like this `new_password `>> `newPassword`


it is not an order, but a picking type


I've added `#line NN` and `#NN` parsing.

The C parser already understands GCC `__attribute((packed))__` and MSVC `#pragma`. I might consider adding the less popular `__pragma` or `_Pragma` (difficult, requires parser hacks), if I get a PR.


Correct. That one didn't occur in CI, but locally the tests on Android run sometimes so fast that iOS devices hadn't yet connected when Android completed.


I didn't see that (otherwise I wouldn't have done it) as it has nothing to do with this change. But it also does not hurt, as it only affects the IntelliJ project configuration and not the code.


This line breaks startup for sites with custom image models. See traceback below:

```
Traceback (most recent call last):
  File "manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/home/karl/projects/wagtaildemo/venv/lib/python3.5/site-packages/django/core/management/__init__.py", line 338, in execute_from_command_line
    utility.execute()
  File "/home/karl/projects/wagtaildemo/venv/lib/python3.5/site-packages/django/core/management/__init__.py", line 312, in execute
    django.setup()
  File "/home/karl/projects/wagtaildemo/venv/lib/python3.5/site-packages/django/__init__.py", line 18, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/home/karl/projects/wagtaildemo/venv/lib/python3.5/site-packages/django/apps/registry.py", line 108, in populate
    app_config.import_models(all_models)
  File "/home/karl/projects/wagtaildemo/venv/lib/python3.5/site-packages/django/apps/config.py", line 198, in import_models
    self.models_module = import_module(models_module_name)
  File "/home/karl/projects/wagtaildemo/venv/lib/python3.5/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 986, in _gcd_import
  File "<frozen importlib._bootstrap>", line 969, in _find_and_load
  File "<frozen importlib._bootstrap>", line 958, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 662, in exec_module
  File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
  File "/home/karl/projects/wagtail/wagtail/wagtailimages/models.py", line 355, in <module>
    get_image_model(),
  File "/home/karl/projects/wagtail/wagtail/wagtailimages/models.py", line 345, in get_image_model
    image_model = apps.get_model(app_label, model_name)
  File "/home/karl/projects/wagtaildemo/venv/lib/python3.5/site-packages/django/apps/registry.py", line 199, in get_model
    self.check_models_ready()
  File "/home/karl/projects/wagtaildemo/venv/lib/python3.5/site-packages/django/apps/registry.py", line 131, in check_models_ready
    raise AppRegistryNotReady("Models aren't loaded yet.")
django.core.exceptions.AppRegistryNotReady: Models aren't loaded yet.
```


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 214](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=688&buildTypeId=XbimEssentials_XbimEssentials) is now running


Really? Hardcoding `/home/$USER`?


not simpler with an in ('incoming', 'outgoing', ...)?


Please return these migrations


fixed in: https://github.com/openpgpjs/openpgpjs/commit/1f995bea22697150db5d7c8885b81e8e285dc090


Thank a lot!

But I think issues https://github.com/ReOpen/ioarena2/issues/2, https://github.com/ReOpen/ioarena2/issues/3 and https://github.com/ReOpen/ioarena2/issues/4 should be also "merged" into ioarena.


Shouldn't this be 'DistVoxel& distVoxel = ...' for efficiency? Currently, a copy of the voxel is created.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 214](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=688&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:46


Needs a instanceof check before casting because there are many types of editors-inputs is used (and may hit at this point)


You're right. I'm wrong - a widget called "header" that appears "beneath the header" makes perfect sense to me. Good luck with your theme.


Thanks


Omg... I hope now one (outside testing code) will ever feel like programming like this...


`else` is not needed here


No, definitely this patch will go in (once unit documentation is updated). It was just a heads up =D


comment


We shouldn't escape html ;-)


`request` seems unused


This change is kind of unecessary (and the concept behind somewhat broken IMO), as the name (AFAIK) is generated from but not directly related to the SDK or Api level in question.
But as future SDK references created by people switching to IntelliJ will likely also contain this new name, it might be sensible to switch anyway


... is set


:+1: Thanks


A horrid problem.

I think the timeline in your rant is a bit off. The differing treatment of 0 allocations goes back to C89. Before C89, malloc and related functions were very badly specified, and realloc in particular was a disaster area - AIUI the straightforward correspondence between realloc and malloc and free was invented by the ANSI C committee. See for example the pre-standard man page http://www.tuhs.org/cgi-bin/utree.pl?file=4.3BSD-Reno/src/lib/libc/stdlib/malloc.3

The C standards (all versions) are quite clear that realloc(p,0) has to free p and return NULL; detecting failure of realloc is not completely trivial and that wrong example code should not be supported.


@guchaojie You could leave this patch for later - this way the others could enter once their minor issues are fixed.


this is strange. why?


@m-kuhn
> The generated request should just combine all top-level rules (Or simply return 1 if there is an else clause). Does that sound plausible?

Yes, that should fix it.


ack, I must've just missed that!


oh, it’s temporary, thanks!


Yes, this is working.


inotify-tools is both in depends and recommends whence pbuilder removed it from Recommends when building the package, leaving only the depends entry. I suppose this is not intended?


Argument `request.form` is not needed here


To cleanup the repo before implementing the new rules.


by now, yes ;)


Could you please change this to `Enable YouToube JavaScript API` so this one is perfectly clear? Thx.


dont see the link


it is rather verbose isn't it! See what you meant by ugh


right.


I forgot what the exact issue with self-reloading was, but will look at it again.


DONE


@yprez from looking at the Travis console it looks like all tests are run on python 3.5. Are you sure we're still testing each env like its tox configuration says? Perhaps we should be using something like https://pypi.python.org/pypi/tox-travis?


I think name `check_password` is more suitable here.


This actually fixes what https://github.com/akka/akka/pull/19477 wants to fix too. So if we merge here no need for https://github.com/akka/akka/pull/19477


@dd721411 Vietnamese  is included in [latest release](https://github.com/syncthing/syncthing-gtk/releases/tag/v0.8.2) and I added possibility to use LANGAUGE=vi environment variable on Windows as well.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11841](https://teamcity.mesosphere.io/viewLog.html?buildId=107042&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:08:14


I wasn't sure if we were storing the lambdas as values, as references or as pointers. If the scheduler used references or pointers, it would avoid the extraneous copies but would fail when the lambda goes out of scope.

Right now, there are two issues:
- If the lambda has a by-ref capture, it becomes invalid as the referenced object goes out of scope (This is is direct contrast with Lua's callback closures, which we're using extensively in Cuberite). You can see this in the `data` value being reported.
- The callback class needs to support copying. If there's any value that cannot be copied (the `MovedTask` class in the code), the code fails to compile.


`check_on_equality` what exactly you are checking here?


Hahahaha. :)
How about this? https://github.com/openmrs/openmrs-module-webservices.rest/commit/6f2c1b6805bca2094e9d0262188b52e72856368b
By the way, thanks for reviewing. Please keep it up! :+1:


Okay 1. That's an antithesis, Because were writing code, and there is no such thing as perfect code.
2. I'm currently waiting on feedback on the JS code, or the rewrite. Also a code review wouldn't hurt. So these are currently blocking for any progress.


Password does not


It's not a very good idea to compare with current user. What if admin will have functionality to change someone's password ?
Or you're changing forgotten password via recovery page, but are not logged in?


going to roll back this one, much easier to add

[spotify_tunigo]
enabled = false

to config.ini to disable the browse service at service start


For this version they look ok to me, maybe later we need to review the homogenized stress but please go ahead.


We should pass `@outgoing_message` to `send_followup` since it's just a helper method.

It would be even better if we checked validity inside `send_followup` and returned truthy or falsey from it.

```ruby
if send_followup(@outgoing_message)
  msg = if @outgoing_message.what_doing == 'internal_review'
    _("Your internal review request has been sent on its way.")
  else
    _("Your follow up message has been sent on its way.")
  end

  redirect_to request_url(@info_request), :notice => msg
else
  flash[:error] = 'some msg'
  render :action => 'new_followup'
end


Do we have a new guy in the team? :)


Please revert this commit! It breaks the existing PostgreSQL, HAWQ and GreenplumDB functionality.


Why do you need a timeout here ?


that's good idea..


We could add a constant for the tarball checksum to avoid changing it everywhere in the future.


Possible typo in your commit message `Rails has some called the "flash".` should probably read `Rails has something called the "flash".`.


In this error console, please type `Promise.defer()` and press enter. I am not sure why the global `Promise` object is not accessible by the toolbar function.


[R/connections.R:2:7:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/R/connections.R#L2) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(cred$engine == "MySQL"){
      ^
```
[R/connections.R:8:32:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/R/connections.R#L8) *style:* **Put spaces around all infix operators.**
```r
                         dbname= cred$dbname)
                              ~^
```
[R/connections.R:15:30:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/R/connections.R#L15) *style:* **Put spaces around all infix operators.**
```r
                       dbname= cred$dbname)
                            ~^
```
[R/cred.R:51:19:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/R/cred.R#L51) *style:* **Put spaces around all infix operators.**
```r
             class="db_credentials", show_warn = .show_warn, force_log = .qlog)
                 ~^~
```
[R/cred.R:70:7:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/R/cred.R#L70) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(show_password){
      ^
```
[R/cred.R:73:13:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/R/cred.R#L73) *style:* **Commas should always have a space after.**
```r
    cat(res,"\n")
            ^
```
[R/cred.R:91:50:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/R/cred.R#L91) *style:* **Put spaces around all infix operators.**
```r
    j <- tryCatch(jsonlite::fromJSON(json), error=function(e){
                                                ~^~
```
[R/cred.R:96:33:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/R/cred.R#L96) *style:* **Commas should always have a space after.**
```r
    required_fields <- c("user","password","dbname", "host")
                                ^
```
[R/cred.R:96:44:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/R/cred.R#L96) *style:* **Commas should always have a space after.**
```r
    required_fields <- c("user","password","dbname", "host")
                                           ^
```
[R/cred.R:108:38:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/R/cred.R#L108) *style:* **Put spaces around all infix operators.**
```r
    plyr::l_ply(optional_fields, .fun= function(x) {
                                    ~^
```
[R/cred.R:109:11:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/R/cred.R#L109) *style:* **Place a space before left parenthesis, except in a function call.**
```r
        if(is.null(j[[x]])) j[[x]] <<- NA
          ^
```
[R/cred.R:133:7:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/R/cred.R#L133) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!file.exists(file)){
      ^
```
[tests/testthat/test_connections.R:5:7:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_connections.R#L5) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(json_string != ""){
      ^
```
[tests/testthat/test_connections.R:9:14:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_connections.R#L9) *style:* **Put spaces around all infix operators.**
```r
        error=function(e){
            ~^~
```
[tests/testthat/test_connections.R:16:14:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_connections.R#L16) *style:* **Put spaces around all infix operators.**
```r
        error=function(e){
            ~^~
```
[tests/testthat/test_connections.R:17:47:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_connections.R#L17) *style:* **Commas should always have a space after.**
```r
            fail(paste0("Unable to connect. ",capture.output(print(.cred))))
                                              ^
```
[tests/testthat/test_connections.R:26:7:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_connections.R#L26) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(json_string != ""){
      ^
```
[tests/testthat/test_connections.R:30:14:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_connections.R#L30) *style:* **Put spaces around all infix operators.**
```r
        error=function(e){
            ~^~
```
[tests/testthat/test_connections.R:37:14:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_connections.R#L37) *style:* **Put spaces around all infix operators.**
```r
        error=function(e){
            ~^~
```
[tests/testthat/test_connections.R:38:47:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_connections.R#L38) *style:* **Commas should always have a space after.**
```r
            fail(paste0("Unable to connect. ",capture.output(print(.cred))))
                                              ^
```
[tests/testthat/test_cred_file.R:17:41:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred_file.R#L17) *style:* **Commas should always have a space after.**
```r
test_that("cred_file reads from a file",{
                                        ^
```
[tests/testthat/test_cred_file.R:18:45:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred_file.R#L18) *style:* **Put spaces around all infix operators.**
```r
    writeLines(jsonlite::toJSON(clst, pretty=TRUE), path)
                                           ~^~
```
[tests/testthat/test_cred_file.R:26:18:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred_file.R#L26) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred_json.R:19:18:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred_json.R#L19) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred_json.R:31:52:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred_json.R#L31) *style:* **Put spaces around all infix operators.**
```r
        '"engine":"MySQL",".qlog": true}', collapse="")
                                                  ~^~
```
[tests/testthat/test_cred_json.R:39:18:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred_json.R#L39) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = TRUE)
                ~^~
```
[tests/testthat/test_cred_json.R:46:57:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred_json.R#L46) *style:* **Put spaces around all infix operators.**
```r
        '"engine":"MySQL",".show_warn": true}', collapse="")
                                                       ~^~
```
[tests/testthat/test_cred_json.R:54:18:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred_json.R#L54) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = TRUE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred_json.R:61:38:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred_json.R#L61) *style:* **Put spaces around all infix operators.**
```r
        '"engine":"MySQL"}', collapse="")
                                    ~^~
```
[tests/testthat/test_cred_json.R:69:18:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred_json.R#L69) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:11:47:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred.R#L11) *style:* **Commas should always have a space after.**
```r
test_that("cred creates a credentials object",{
                                              ^
```
[tests/testthat/test_cred.R:20:18:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred.R#L20) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:25:69:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred.R#L25) *style:* **Commas should always have a space after.**
```r
test_that("cred creates a credentials object with a character port",{
                                                                    ^
```
[tests/testthat/test_cred.R:36:18:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred.R#L36) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:49:18:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred.R#L49) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:62:18:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred.R#L62) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:75:18:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred.R#L75) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = TRUE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:88:18:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred.R#L88) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = TRUE)
                ~^~
```
[tests/testthat/test_cred.R:101:18:](https://github.com/acjackman/dbezr/blob/2034c372ee0d71774a084b09662cf604b830dcd1/tests/testthat/test_cred.R#L101) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = FALSE)
                ~^~
```


Local tests success


仿探探六宫格相册。
初学iOS,有不足之处，请各位大牛指点。


@marijnh Probably this `arr[i] <= ch` is the reason - although if items are sorted, then binary search would make more sense. Anyway, this is just a build script, so I believe, speed is not critical.


do you have this issue with the stable version of Opera as well?


This means you cannot use the RFS in the pre download event.


@xiangzhai 在getbatchcontact时

根据请求的数据形式不同，看到有时候会返回encrychatroomid，不知道是什么东西。开始以为群里的单个用户名字是这个，后来发现就是username。。。

群信息这些。。。先学习下看您怎么做的。。


s


ok


Using the ShapeBasic constructor directly is not a good idea.
This means you are working around the framework, and on the GraalVM, the optimized object model cannot be used.


[R/connections.R:2:7:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/R/connections.R#L2) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(cred$engine == "MySQL"){
      ^
```
[R/connections.R:8:32:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/R/connections.R#L8) *style:* **Put spaces around all infix operators.**
```r
                         dbname= cred$dbname)
                              ~^
```
[R/connections.R:15:30:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/R/connections.R#L15) *style:* **Put spaces around all infix operators.**
```r
                       dbname= cred$dbname)
                            ~^
```
[R/cred.R:51:19:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/R/cred.R#L51) *style:* **Put spaces around all infix operators.**
```r
             class="db_credentials", show_warn = .show_warn, force_log = .qlog)
                 ~^~
```
[R/cred.R:70:7:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/R/cred.R#L70) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(show_password){
      ^
```
[R/cred.R:73:13:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/R/cred.R#L73) *style:* **Commas should always have a space after.**
```r
    cat(res,"\n")
            ^
```
[R/cred.R:91:50:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/R/cred.R#L91) *style:* **Put spaces around all infix operators.**
```r
    j <- tryCatch(jsonlite::fromJSON(json), error=function(e){
                                                ~^~
```
[R/cred.R:96:33:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/R/cred.R#L96) *style:* **Commas should always have a space after.**
```r
    required_fields <- c("user","password","dbname", "host")
                                ^
```
[R/cred.R:96:44:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/R/cred.R#L96) *style:* **Commas should always have a space after.**
```r
    required_fields <- c("user","password","dbname", "host")
                                           ^
```
[R/cred.R:108:38:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/R/cred.R#L108) *style:* **Put spaces around all infix operators.**
```r
    plyr::l_ply(optional_fields, .fun= function(x) {
                                    ~^
```
[R/cred.R:109:11:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/R/cred.R#L109) *style:* **Place a space before left parenthesis, except in a function call.**
```r
        if(is.null(j[[x]])) j[[x]] <<- NA
          ^
```
[R/cred.R:133:7:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/R/cred.R#L133) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!file.exists(file)){
      ^
```
[tests/testthat/test_connections.R:5:7:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_connections.R#L5) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(json_string != ""){
      ^
```
[tests/testthat/test_connections.R:9:14:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_connections.R#L9) *style:* **Put spaces around all infix operators.**
```r
        error=function(e){
            ~^~
```
[tests/testthat/test_connections.R:16:14:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_connections.R#L16) *style:* **Put spaces around all infix operators.**
```r
        error=function(e){
            ~^~
```
[tests/testthat/test_connections.R:17:47:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_connections.R#L17) *style:* **Commas should always have a space after.**
```r
            skip(paste0("Unable to connect. ",capture.output(print(.cred))))
                                              ^
```
[tests/testthat/test_connections.R:26:7:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_connections.R#L26) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(json_string != ""){
      ^
```
[tests/testthat/test_connections.R:30:14:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_connections.R#L30) *style:* **Put spaces around all infix operators.**
```r
        error=function(e){
            ~^~
```
[tests/testthat/test_connections.R:37:14:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_connections.R#L37) *style:* **Put spaces around all infix operators.**
```r
        error=function(e){
            ~^~
```
[tests/testthat/test_connections.R:38:47:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_connections.R#L38) *style:* **Commas should always have a space after.**
```r
            skip(paste0("Unable to connect. ",capture.output(print(.cred))))
                                              ^
```
[tests/testthat/test_cred_file.R:17:41:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred_file.R#L17) *style:* **Commas should always have a space after.**
```r
test_that("cred_file reads from a file",{
                                        ^
```
[tests/testthat/test_cred_file.R:18:45:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred_file.R#L18) *style:* **Put spaces around all infix operators.**
```r
    writeLines(jsonlite::toJSON(clst, pretty=TRUE), path)
                                           ~^~
```
[tests/testthat/test_cred_file.R:26:18:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred_file.R#L26) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred_json.R:19:18:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred_json.R#L19) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred_json.R:31:52:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred_json.R#L31) *style:* **Put spaces around all infix operators.**
```r
        '"engine":"MySQL",".qlog": true}', collapse="")
                                                  ~^~
```
[tests/testthat/test_cred_json.R:39:18:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred_json.R#L39) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = TRUE)
                ~^~
```
[tests/testthat/test_cred_json.R:46:57:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred_json.R#L46) *style:* **Put spaces around all infix operators.**
```r
        '"engine":"MySQL",".show_warn": true}', collapse="")
                                                       ~^~
```
[tests/testthat/test_cred_json.R:54:18:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred_json.R#L54) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = TRUE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred_json.R:61:38:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred_json.R#L61) *style:* **Put spaces around all infix operators.**
```r
        '"engine":"MySQL"}', collapse="")
                                    ~^~
```
[tests/testthat/test_cred_json.R:69:18:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred_json.R#L69) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:11:47:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred.R#L11) *style:* **Commas should always have a space after.**
```r
test_that("cred creates a credentials object",{
                                              ^
```
[tests/testthat/test_cred.R:20:18:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred.R#L20) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:25:69:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred.R#L25) *style:* **Commas should always have a space after.**
```r
test_that("cred creates a credentials object with a character port",{
                                                                    ^
```
[tests/testthat/test_cred.R:36:18:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred.R#L36) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:49:18:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred.R#L49) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:62:18:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred.R#L62) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:75:18:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred.R#L75) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = TRUE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:88:18:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred.R#L88) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = TRUE)
                ~^~
```
[tests/testthat/test_cred.R:101:18:](https://github.com/acjackman/dbezr/blob/ecea02768b01f19af5a983b73a34376bb5b62560/tests/testthat/test_cred.R#L101) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = FALSE)
                ~^~
```


It is no really evident when you use some type with suffics `Ref` and in the same time use `&` sign


Ah, it's a short-circuit search? That still doesn't seem like it would be worth it (only halves complexity, and as you pointed out, this is a build script ran maybe twice a year)


This shouldn't be necessary. I just tested this: http://ix.io/nvO/python
In `waflib.Node`, there's heavily use of `Utils.split_path`, which is set to the correct function depending on the OS.


@Alexander01998 Really, will there be ads?


You have identical code from line 36 to line 77. Please move this code in separate function. copypaste is not cool :-1:


Instead of the text just being "Game Over" we should write "Game Over. Press the Space-bar to Restart".
We should then use:
 if self.input.is_key_down('spacebar'):
    self._state = STATE_COUNTDOWN


Personally I would have used String.equalsIgnoreCase() :-)


改行


Darn, I only checked the usage of the save() method. I'll revert some of the changes tonight.


if (path.sep !== '/') source.replace('/', path.sep);?


And what about True/False (mixed case) ?  Maybe we shouldn't be too strict and allow any combination that seems logical like  BooleanUtils.toBoolean:
https://commons.apache.org/proper/commons-lang/javadocs/api-3.1/org/apache/commons/lang3/BooleanUtils.html#toBoolean%28java.lang.String%29


Accepting the changes to allow password entry


After this commit, you probably should reinstall the app, as all NFC tags scans will be forwarded to `WifiNetworkActivity` (see http://stackoverflow.com/a/8146212).


a


BUG


URLs are .. ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11842](https://teamcity.mesosphere.io/viewLog.html?buildId=107053&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:06:59


"blaat ]" ?


Missing in docblock @param


TeamCity pull requests :: netty [Build 1048](https://garage.netty.io/teamcity/viewLog.html?buildId=4843&buildTypeId=pulls_netty&guest=1) outcome was **UNKNOWN**
Summary: Canceled (Tests passed: 5593, ignored: 19) Build time: 01:34:22


TeamCity pull requests :: netty [Build 1049](https://garage.netty.io/teamcity/viewLog.html?buildId=4855&buildTypeId=pulls_netty&guest=1) is now running


oops, I missed that ...
thanks !


I think we should maybe drop this from this pull request, since currently this will be benign while the webui doesn't support opening a per-context query. Hopefully soon the webui will have some way of viewing per-context metrics and we'll need to remember to make a change like this.


Possible typo in your commit message `Now, modify the models so the the User model knows about Post, and vice` should probably read `Now, modify the models so that the User model knows about Post, and vice`.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1187](http://teamcity.monogame.net/viewLog.html?buildId=13723&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


The following line clears 'errno' on Windows.
- ScmVM *vm = Scm_VM();

So, 'get_errno' should be called before the line.


I have put this in the setter method because very often I'm seeing a proxied object being passed to it.

It's a lot safer imo to keep this as isType and maybe optimise the isType function more (if possible) but moving back to isinstance is going to risk introducing the bugs I hoped to avoid by using it here.


Maybe use TYPO3_OS constant instead? Is "WIN" if windows, otherwise empty.


There are two possible cases here
1) we pass JsonValueRef to the ctor. thus using the const ref we avoid the creation of the temp object just for reading.
2) we pass JsonValue to the ctor. There is the conversion operator to the JsonValueRef. Thus there will temp JsonValueRef object. Since there is const ref, the life time will be prolonged.

Usually there are JsonValueRef used in the code. Since JsonValue is usually the root node only.
So using const ref to the JsonValueRef  will safe from creation of the one temp JsonValueRef  object.

I prefer to keep this.


If you would prefer isinstance over isType for speed then I'd advise using stripProxy as well to be 100% sure that you're not comparing proxied and unproxied objects which often has unexpected behaviour


Please split such long lines in several lines. Otherwise one might overlook the unless part.


This is required to have github parse the file as markdown (which is fairly more convenient for writing a piece of doc than plain text). @tru7: since there is no strict "README" file anymore, there may be issues with autoconf. Can you please give it a try and let me know? If needed, we can symlink README->README.md to work around that.


It's not empty if NOT windows, but it's not containing the string "WIN" at that position.


I'm happy to move to this as it's much simpler to read. I'm assuming that there aren't any function which still pass a string to this?


Not sure. I understood that the base Python that tox runs with it 3.5, but tox then install it's own versions of Python each one into a venv. The reason I added this is because I couldn't get Python3.5 to work on travis without it...


ok


This looks like something that should be stored in a fixture file. Like https://github.com/openSUSE/open-build-service/blob/master/src/api/test/fixtures/backend/bugzilla_get_0815.xml


NP!

2016-01-18 18:10 GMT+06:00 Gilles Gouaillardet <notifications@github.com>:

> oops, I missed that ...
> thanks !
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/open-mpi/ompi/commit/6a791c30267a50d79d164b8b78ae19ff692b2867#commitcomment-15505497>
> .
>

--
С Уважением, Поляков Артем Юрьевич
Best regards, Artem Y. Polyakov


Looks like there is an error regarding creating recovery from boot.img. in that case, just remove the BOARD_CUSTOM_BOOTIMG_MK.


did we just add 3 blank lines?


Well, I think it's the same. Maybe just looks better. Check https://nodejs.org/api/path.html#path_path_sep


I had a quick go at replicating this with the previous commit checked out and couldn't. Not quite sure what message it duplicates or how it does that/


s/int/uint/


minor nit-pick about the version numbers. 2.0 = jethro.


It returns the same json a the  like in the document-response (hence the link).
And just to be clear: I didn't make this page, Oliver did. All I did was add the audio formats, fix 2 typos.
I really don't have time to add further clarifications here (10 working days at UCL left).


I'm assuming this has been removed as setNodeAttribute now assigns the parent?

Should setNodeAttribute in this case also call setDirty as this should still be called I think


maybe add javadocs with description of those two Rewriters?


What do you mean by this?


That this should have been in here forever. But hasn't :)


That part looks fine to me. Though [@project.store](https://github.com/openSUSE/open-build-service/blob/master/src/api/app/models/project.rb#L872) could fail and raise an exception. We probably should handle this too.


Сделал: uint32_t mwmChildCounter = 0;


This is my commit


The only one I found was in RegistrySlice.py which I fixed in this same commit.

Actually, I just found another in Job.py which I will fix and push to this branch.


Yeah, that much I figured and logically it seems to work that way but Travis doesn't give any indication, why I thought maybe try tox-travis.


Change the colour to purple.


TeamCity ReOpenLDAP :: devel [Build 225](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=1697&buildTypeId=ReOpenLDAP_Devel&guest=1) outcome was **SUCCESS**
Summary: Tests passed Build time: 01:46:23


Could we get that "inline" meaning: IsStalled for both? That would make it much more clear if you check on one side: if Getlevel is zero, but on the other side that Audio is blocked cause of something else.

Without your explanation via email I would not have known why this is handled differently.


Yeah, looks like same since we have only unixes and win now. I'd say it's more correct :smirk_cat: but who cares.


Please make it a named constant. By the way, upstream [uses 32 bytes](https://github.com/docker/distribution/blob/master/registry/handlers/app.go#L527).


If we're assigning objects to the current repo we explicitly want to stop it from running the auto-flushing here until the object has been assigned!
This was the bottleneck caused by calling flush multiple times every time a large list object is set in a GangaList


Please note, you must create a branch from the develop branch. Not master.


shouldn't this still have been enabled above?


This does not look right: the interpolation axis has already been rolled to zero position.


thanks :smile:


Was this an existing bug, or should this be a fixup to a previous commit?


What is "Win32 graphics mode"? Is it GDI or DirectDraw or ... ?


fix bug in BTagWeightCalculator logic, now Stats uncert. properly decorrelated between HF and LF


Yeah, it should be.

—
Connor Hudson
On Jan 18, 2016 01:05, "Michael Ball" <notifications@github.com> wrote:

> Is this the same file that's on snap.b.e?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/technoboy10/snapmotion/commit/33296b48df40eba76a68b9eaad9f5fa825086076#commitcomment-15500883>
> .
>


The cleanest solution is to make the dependency optional (that way both package imports become optional). The compile time dependency should be
* osgi.cmpn in version 6.0 (for AEM 6.1)
* org.apache.felix.scr 1.8.2 (for AEM 6.0)
The you should have two service implementations. One for OSGi one for Felix. By making both dependencies optional either one service implementation or the other is bound here.


Why do those 2 relations have to be sync? Download_repositories and architectures


That was quick..thanks @l3pp4rd !


Please keep in mind that those commands in DragonProxy only available from the console.


strip metadata


Interesting. If no one objects, i will switch to that. :)


It already gets a value above: in line 292 - why saving that in between if not used here?


Are we CERTAIN that the cache and data are never set to None now?

They used to be within the repo and I haven't tested that these values are never set to None at bad times. (This is obviously bad behaviour I'm just wondering if it's gone away yet?)


assertEquals(200, response.statusCode())


This block of code will never run since it's doing `if hasattr(stripProxy(self), '_getRegistry')` where `self` is a `Descriptor` object which does not have the `_getRegistry` function.


It seems that distinguishing not-a-knot and None adds complexity for not too much gain. So maybe here it's an instance where practicality beats purity and all that.


+1 for @lluismf approach


OK, I didn't think there were any left I was just checking :+1:


wrap i try catch


Might be a good idea.
This is the travis issue: https://github.com/travis-ci/travis-ci/issues/4794
and here's a failed build: https://travis-ci.org/yprez/django-rest-assured/jobs/103095471


As mentioned previously, I think I need another iteration on the APIs to embed Auth. Would like to wait until we have our Auth strategy defined.
In this specific case : should not we define or change the initially created bearer token with personalid instead of display name?


@RandomAltThingy I was talking about the start arguments (example: the debug command)


Hello ..
Can you please help me to set up testimonial showcase in my shopify store.
This works exactly same as i want. just need to edit this testimonial showcase code like  dont want slider effect, i want the fade in and out effect and the the picture loading in left side of the testimonial i dont need that.

Thanks
Help please !appreciated


sometimes you use vert.x unit some times "Vert.x unit", etc... shouldn't it should be always "Vert.x Unit" ?


Is the dod intended or a typo?


Because of materialize toast which disappear after 4 sec(after succeed)


did you encounter test failures with the default? (just checking they're something expected due to how the test works etc)


Don't think tox-travis will help here...


Just because I was trying to fix the issue :( (And I got it to work, but every player was invisible but you could see the nametag)


True. Fixed it in https://github.com/composer/composer/commit/33c123e


PCHR-748: Used a constant `self::CANCELLED_LEAVE_TYPE_ID` for better readability.


self.data_types was not initialized ,and it was resulting in null pointer exception .


It teaches Python2. :(


I saw a serious performance hit when I implemented this version of stripProxy, I agree it's much nicer and simpler but do we still see the performance hit with this over the simpler version?
(If we no longer see a performance hit from doing it this way I'm very happy to go in this direction :+1: )


Indeed. Perhaps it should call `_setDirty` or perhaps it should be called by `_setParent`?


To resolve GH-79


With the comment that Matt made on the AccessKey"F8" line - Spoon won't start until that's fixed - so the nightly is broken right now...


Yo, that padding looks awful imho. The text inside the button is not vcentered any more.


(Upon reading the code in context)
Yes you're correct, in that case I'm happy for this to be culled :)


fix the wrong header file name in zerg_predefine.h


DONE


Here personal id is an optional parameter as the participant request might be coming from a registered user who has a system generated personalid stored in the system.
Its not random always hence this is another optional property which can be provided by the participant sometimes.
Note that for a guest user personalid will only change if his/her sessions gets timed out and user rejoins into the conference. So in a nutshell this property is not that random and not changing(i.e. within a session)
Again I need another iteration to define Auth strategy accross AWV REST APIs.


I see, so it's Travis thing. Well then, this will have to do for now. Thanks!


Yes, but surely if we've just changed an object in the schema (hence called setNodeAttribute) I think the _setDirty method should be called here if not in the setter method as we want the change to be preserved


@chelmuth please put this fixup commit on top of staging. It solves the "unknown MMU exception" problems shown by the buildbot. Thanks in advance!


Er dette meningen


PCHR-748: Filter out cancelled leaves.


@thedanotto It looks like you wanted to take a stab at this.  Do you want to work on this feature?


I added a quick hack adding "python -V" to the tox script: https://travis-ci.org/yprez/django-rest-assured/jobs/103097531#L112

Seems that tox is running the correct Python version.


`Node.__init__` does:
```python
def __init__(self, parent):
    self._data = {}
    self._parent = parent
    self._index_cache = {}
    self._proxyObject = None
    super(Node, self).__init__()
```
and so as long as the constructor is called we seem to be ok. The majority of the old issues seemed to stem from `GangaObject`s being created using just `__new__` without a call to `__init__` so this code was never called.

`_data` and `_index_cache` are now protected behind function calls (the ones you recently added) so we can be quite sure that as long as no-one is going around them that we're safe.

Perhaps an `assert` in `setNodeIndexCache` and `setNodeData` for their arguments being `None` would be useful?


Indeed, now I remember they are a leftover from the Blender S3O importer that once existed.

I'll ready the nukes then.


`File.exist?(@vide.content.file.path)` o.Ä., falls nicht geprüft wird?


*waves*


Where is com.android.internal.R.integer.def_wifi_idle_ms? This break my build.


seems ok.
Perhaps a request can be made to cmake developers to support arm?


This is an issue that has to be resolved somehow: upstream "Lua mode DynASM" expects to load its C support code as a shared object but in Snabb Switch we statically link that. This commit is backing out the local change that I made to "Lua mode DynASM" so that this would work (and will cause breakage as a result).

@capr suggested patching LuaJIT's `ffi.load()` to return `ffi.C` when it fails to find a library. This seems a bit too magical to me though because it has the potential to surprised people who call that function expecting the normal behavior (error if shared library not found).

The most direct solution would seem to be keeping the local modification that I had made (skip the `ffi.load()` call) but this would probably lead us into exactly this situation again the next time we pull an update. Anyone have a better solution? If not we can think about it between now and the next update.


For me it provides a significant speed increase in my tests. I think the best way to reduce the effect of any remaining performance problems is to not call the function as often.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/25670/testReport/) for this commit**


@bkemper-pentaho , that was fixed here: https://github.com/pentaho/pentaho-kettle/pull/2058


... Generally perhaps we should be tracking the upstream in a more controlled way e.g. with `git subtree` so that any local changes we make are not quietly clobbered?


This commit should also remove `.jscsrc`, right?


Good catch.  Thanks.


Thanks @breskeby


I dont understand why this issue doesn`t appear on supercollider compilation also.


Thanks,but i don't apply this patch at all.

https://github.com/Tkkg1994/Nova-Kernel/commit/97a4d323e8ee44c67e9b158440e7e85b016f6d6e


I would presume that we have samples and user-guide content demonstrating this. If not we should add it. If so, it's often better to just link from the release notes to the user guide, rather than having lots of example code in the release notes.


The whole handling of add / update requests via an action variable looks like a hack to me. Shouldn't it be enough to check whether I have a repository?


Continue?


Oh, understood.
Could you please add it as a comment to code ?


At this point the size of the card image displayed in the explorer, deck editor and duel decks screens is now determined by the Preferred Image size setting. The Large Card images setting is ignored and will eventually be removed. The default size of a CardBuilder generated card has been added to the presets. View at this size for optimum clarity.


OK, so we need to ensure that de-duplication doesn't violate this constraint. I think this should be possible. @bmuschko @lhotari Please take note.


Hi,
I propose these two references:
1. Jin, Y., & Branke, J. (2005). Evolutionary optimization in uncertain
environments-a survey. *Evolutionary Computation, IEEE Transactions
on*, *9*(3),
303-317.
--> It tackles the problems of "noisy fitness evaluations", "imprecise
fitness (quality) evaluations",  "time-varying fitness function" and "the
design variables or the environmental parameters are subject to stochastic
or deterministic changes".
2. Hansen, N., Niederberger, A. S., Guzzella, L., & Koumoutsakos, P.
(2009). A method for handling uncertainty in evolutionary optimization with
an application to feedback control of combustion. *Evolutionary
Computation, IEEE Transactions on*, *13*(1), 180-197.

2016-01-17 19:19 GMT+01:00 Pedro A. Castillo Valdivieso <
notifications@github.com>:

> Also, we should reference the following one:
>
> In [Flores2011] a new Rank Based Selection operator and a new variation of
> a Rank Based Mutation are proposed to evolve the neural network topology
> used as a controller for a robot. The operators were suitable for this kind
> of problems where the fitness landscape is noisy.
> ------------------------------
>
> @inproceedings{Flores2011,
> title={Rank Based Evolution of Real Parameters on Noisy Fitness Functions:
> Evolving a Robot Neurocontroller},
> author={D. Flores},
> booktitle={10th Mexican International Conference on Artificial
> Intelligence (MICAI)},
> pages={72--76},
> year={2011},
> organization={IEEE},
> doi={10.1109/MICAI.2011.40}
> }
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/geneura-papers/2015-ECTA/commit/0364af0fefa3c1f72120eabcf7e3e97e65fa9234#commitcomment-15496028>
> .
>


Are you referring to line 587 with the first comment above? If so, then I changed:
```python
stripProxy(_val)._setDirty()
```
to
```python
val._setDirty()
```
but note that `val = stripProxy(_val)` is done in a later commit https://github.com/ganga-devs/ganga/commit/93ef47c9c63df851d1b2568f15c90dbe30aaf66b#diff-3a5f5ed88f274eb570dccbab85337abfR535

It's my mistake that these got out of order but the `_setDirty()` is indeed being run on a stripped object still.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1187](http://teamcity.monogame.net/viewLog.html?buildId=13723&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:29:11


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1188](http://teamcity.monogame.net/viewLog.html?buildId=13727&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Calm down @ChangePlaces it's not about being right or wrong. It's about interpretation.

In over a year of the theme being available you're the only person who has been confused by this so far and while we really appreciate any contributions we have to think of the wider community.

Do you have an answer to my question? What part of the description makes it unclear as to where the widgets will appear?

What would you rename the region to? 'Below Header'? 'Beneath Header'?


@valbooth28: I missed this detail; isSame check if everything about the two objects is the same, including time. Since we only care about dates here, isSame can just look at the date value.


Test med skrivninger fra flere tråde


Test med negative tal


Why is this here?


Is it possible to push 0.16 to the Cinnamon Spices page?


I made these comments in Slack, but I thought I'd put them here so they didn't get lost.

In general, the README could use some revamping.  Right now, it's essentially a placeholder. A few points:

 * The "Running the App" section should be removed or updated.
     * "dunno yet" isn't really worth checking in, and I would have instead left it out entirely until I had something to add.
 * It’s definitely worth mentioning that you need to open “TicTacToeApp.xcworkspace” instead of the default “TicTacToeApp.xcodeproj.” It's something that deviates from the normal iOS app.
 * “My java server” is also a bit ambiguous.
     * It's also not 100% correct. Technically, all you need is a server with an API that conforms to a given contract.
     * That said, it would certainly be a nice addition to link to one that works though, or even just have it deployed somewhere public, so that they don’t even need to build/run a server themselves.

Making sure to keep the README up to date as the project evolves is definitely important.


that's two different stories and have to be handled differently. if you have any ideas, let me know.


is this because argv[0] is normally 'ganga' I'm not sure how python deals with this?


@adrianschroeter You should do pull requests to find such things before pushing them to master;-)


thank you @modus75


Seems the latest version is WA-GUEST-OS-4.27_201512-02 with No support for .NET 4.5.2 ?
When can we expect the WA-GUEST-OS-4.27_201512-01 version with support for .NET 4.5.2 ??


2016-01-18 13:40 GMT+01:00 Zeineb <notifications@github.com>:

> Hi,
> I propose these two references:
> 1. Jin, Y., & Branke, J. (2005). Evolutionary optimization in uncertain
> environments-a survey. *Evolutionary Computation, IEEE Transactions
> on*, *9*(3),
> 303-317.
> --> It tackles the problems of "noisy fitness evaluations", "imprecise
> fitness (quality) evaluations", "time-varying fitness function" and "the
> design variables or the environmental parameters are subject to stochastic
> or deterministic changes".
>

It is already in the bibliography and extensively commented in the state of
the art area.

> 2. Hansen, N., Niederberger, A. S., Guzzella, L., & Koumoutsakos, P.
> (2009). A method for handling uncertainty in evolutionary optimization with
> an application to feedback control of combustion. *Evolutionary
> Computation, IEEE Transactions on*, *13*(1), 180-197.
>

It's there too, not so extensively commented, but there anyway.


please rephrase you question. not sure what you mean?


0m -> default


Probably want to continue verifying recaptcha submissions?


Hi @trhermans ,
Would you be able to submit a pull request on my repository for the simulation commits? It looks like you've made some really cool changes and it would be great to share those back with the world.
You may also be interested in a new python client I wrote to directly interface with the hand (see the new allegro_hand package in my repo).
Thanks,
Felix


`c_str()` is not necessary as the constructor can take a `std::string` too


@parkr of course, please feel free to include my guide there. Thanks for the link and kind words!


I think it would be better to mark only specific files with an environment, otherwise we are not guarded against (some cases of) using Node.js-specific functionality in files which could go into the browser bundle.


`stdbool.h` itself has this. Do you really think it's necessary ? if yes i'll change all the other headers that are including it.


h


The problem is: One does not get what happens here when reading the api Definition of GetLevel() vs. IsStalled(). One could think: GetLevel  == 0 would mean the same as "isStalled" cause no new data is there to process.

Concerning the interface documentation: https://github.com/FernetMenta/xbmc/blob/cdbf9a77b3a428ca6b8d3b1d519c903761d4fb51/xbmc/cores/VideoPlayer/IVideoPlayer.h :-)


I'll do a quick grep for these methods with an explicit None argument but I think things like this have gone.
In this case I'm happy :)
As you mention though, the use of ```__new__``` in the VStreamer was a major source of woe for these functions


done!


In the main SuperCollider project, there are SSE and SSE2 cmake options that can be turned off. I'm afraid I simply compiled with those turned off. It would be neat if the main project automatically deactivated those flags on ARM.


Why?


Please, add some named const for this `-1` with descriptive name to simplify understanding why we need this magic value. Even better if there will some comment near this const with more detailed description of the logic.


Why `"args": "none"`?


Fixes #157


For by-ref captures, thats just something you have to be aware of in a non-gc language. Functor classes with pointer and reference members have the same issues. The only way of solving that is a GC, or a linear type system (Rust).

The copyable requirement is a limitation of std::function. The only real alternatives are to implement a move only version of std::function, or wrap the move only type in a copyable type by pointer.


to -> of


Maybe we should just delete the entire driver:P


Just `[ 0 ]` is enough, no?


If the performance hit it's not present for you then I think it's gone. I was seeing some exceptions thrown within Ganga when functions were being called for getattr which it was swallowing which made debugging what was going wrong a painful exercise.
I would expect this to be much faster in the form you propose and I'm all for moving to this implementation :)


Needed?


FTR: I've manually renamed locally the JDK entry just after publishing this diff.


feel free to submit a pr with enhancements :)


We're still calling `val._setDirty()` on the line below so the object should correctly register that it's changed.


No, they kicked me from the team for apparently "Deleting everything". It's all bs.


how


When creating conference , I want this conference owner to be some one other. I need to mention loginid of the MCA user in this owner field, to delegating the conference.

In this case conference will be listed under  both user as  a conference creator.  This is the case of Delegate.


https://github.com/FernetMenta/xbmc/blob/37aeb08c14a0a49364e86c7cf717cb0012c13be6/xbmc/cores/VideoPlayer/VideoPlayerAudio.cpp#L498 <- you call the above DecodeFrame method, so a packet already has m_clock value but you overwrite it never the less when setting the msg.timestamp.


Lol :-) chicken  / egg again :p


+ WholeSeconds


SVN is soo 90s


It's more of a general statement toward the use of ```isintance``` being potentially unsafe around potentially proxied objects.
I'm happy to fix this elsewhere but I just fear that any problems caused by:
```isinstance(myObject, myProxiedObjectClass)``` failing when you expect ```isinstance(myObject, myObjectClass)``` to pass would be difficult to track down and/or fix.


Ahh, you might be right. That makes sense as I bet `optparse` strips the first entry. I'll update the code to reflect this.


Hej Richard


Experiment with wrapping before `>`. Anybody: Is this too ugly? @domenic ?


Do you recall what problem existed before you added that flag?
Any step to reproduce?


whats this route for?


Enabling this by default does pull in a dependency on the `audit` package. What does this do by the way?


According here const char is required http://www.cplusplus.com/reference/fstream/ifstream/ifstream/


> you call the above DecodeFrame method, so a packet already has m_clock

where is this?


Rate per step


awesome :+1: , send a PR!


sorry for poor English. i should fix elementary to mandatory


can you explain this for me?


In owner emailid or loginid of owner will be returned . By default this will conference creator email/loginid. For the conference where there is delegate nominated during conference creation, delegate's emailid will be returned.


yes but it has also the string version
`explicit ifstream (const string& filename, ...`


I was thinking of the few other places where we make use of ```setNodeAttribute``` possibly falling into the trap of not having an object marked dirty when you would expect this to happen. Plus I would argue since the ```_dirty``` is managed by the Node it should be handled there.


請輸入第一個整數:22
請輸入第二個整數:25
22 > 25 = false


Ah ! Finally.


Why did you add the user list and list list to the list editor?


welcome


Sorry, out of sync codebase cause my error!


Add comment why we call cleanup only here.


Don't forget about the README or Travis. One detail I would definitely include in the README is a link to the deployed version and instructions on how to deploy (assuming either or both of those can be made public).


ah ok for c++11... But isn't it set by default now when compiling openMVG?


About.


Call: https://github.com/FernetMenta/xbmc/blob/37aeb08c14a0a49364e86c7cf717cb0012c13be6/xbmc/cores/VideoPlayer/VideoPlayerAudio.cpp#L498

https://github.com/FernetMenta/xbmc/blob/37aeb08c14a0a49364e86c7cf717cb0012c13be6/xbmc/cores/VideoPlayer/VideoPlayerAudio.cpp#L292 overwrite if not existing to current clock. So _no_ packet should come out there with an invalid packet.

Now in the process part, you overwrite the "valid" pts with an updated value of the clock, right? But the one that did not have a valid pts before the mentioned "workaround" you reassign NOPTS.

Why?


@artur-shaik which os do you use?


a


OK, that all makes sense. Prefixing the #defines with TEMP_STYLE_ is a good idea. So is setting them to 1.0. I'll keep using other values to test and to give Giuliano a version of Verovio he can actually use in the near future, but I'll try to push only versions of style.h with settings of 1.0.


They aren't necessarily interdependent. Many people have several unrelated projects open in their workspace. There are two main issues that could arise:

1. One project is misbehaved (slow configuration phase or errors in the build script) => Whole workspace would suffer
2. Dependency substitution creates a project cycle (e.g. A depends on B and B is implemented using an earlier version of A)


Hvordan kan denne give den værdi som de giver når man har overskredet step størrelse


Can be simply to single line.
boolean c = a>b;


I removed the comment. When parsing input that is in punycode form, after decoding it may not be normalized.
Without this check it fails for xn--u-ccb.


omformuler


We should use @BRANDING_COMPANY_NAME_LEGAL@ instead of "@BRANDING_COMPANY_NAME_SHORT@ Systems, Inc."


這裡可以貼圖, 你可以把測試畫面貼進來..
![2016-01-18 21_00_20-](https://cloud.githubusercontent.com/assets/12655494/12391976/7ef64bd2-be26-11e5-9fc4-73ebcaf911d8.png)

這題我OK..過關.


aaaaaaa


Reducing Versions?


:rocket:


Reducing Version Again o_O


@theirishpenguin: not sure this is the correct procedure, but to push to production I had to fix a few issues which I did by pushing straight to `master`. :blush:

1. Cedar-10 is deprecated
```
remote: !	Cedar-10 is deprecated. Please update to Cedar-14: https://devcenter.heroku.com/articles/cedar-14-migration
```
2.  i18n requires Ruby version >= 1.9.3
```
remote:        Gem::InstallError: i18n requires Ruby version >= 1.9.3.
remote:        An error occurred while installing i18n (0.7.0), and Bundler cannot continue.
remote:        Make sure that `gem install i18n -v '0.7.0'` succeeds before bundling.
remote:  !
remote:  !     Failed to install gems via Bundler.
```
3. deprecation in gem `pg`
```
remote:        ruby: symbol lookup error: /tmp/build_98c46756da1905f2c4f8ef8261af934d/vendor/bundle/ruby/2.2.0/extensions/x86_64-linux/2.2.0-static/pg-0.14.1/pg_ext.so: undefined symbol: rb_thread_select
remote:  !
remote:  !     Precompiling assets failed.
```


Prøv at ændre denne til et sekund


Many more like this(Reducing Version)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11843](https://teamcity.mesosphere.io/viewLog.html?buildId=107093&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:08:49


hehe


这逗号的位置。。我的强迫症。。


NIT: 'adjust' is the mechanism for tracking retention, not the topic itself.

Use a more descriptive topic name.


Maybe PCAP export should be a PRO feature.


I'd like wrapping to occur where there would otherwise be spaces, so that it matches what my text editor's "hard wrap" feature does without manual tweaks.


You think? I just wanted to make sure that it runs with the correct Python... are there any upsides to showing the python version in every tox build?


ahh, that answers my qa finding... I'll add them back in in a second


From the [javadocs](https://docs.oracle.com/javase/7/docs/api/java/util/Comparator.html):
Note: It is generally a good idea for comparators to also implement java.io.Serializable, as they may be used as ordering methods in serializable data structures (like TreeSet, TreeMap). In order for the data structure to serialize successfully, the comparator (if provided) must implement Serializable.


PCAP export is for debugging only


fix the commit message:
"Add a plan verifier which checks if there are subqueries present. In case it finds a subquery it will raise a semantic error. It is intended to run this verifier after all rewrites assert that all subqueries were rewritten."

or something similar to indicate that this tool doesn't actually verify is the subqueries were rewritten, it only checks that the subquery is not present


With my 'native speaker' hat on (I'm from England), I'd probably err towards the singular form, such as:

The 'Turnout Table' being a table of Turnout Objects (a.k.a. Turnouts).
The 'Sensor Table' being a table of Sensor Objects (a.k.a. Sensors).
The 'Logix Table' being a table of Logix objects (a.k.a. Logixes, or, even, Logix, Logi, Logices,... - not entirely sure how I'd pluralise that, but the initial form is probably the closest!)

Now I know that I did merge this PR as I'd not considered the pluralisation at the time - it's more this conversation that has prompted me to give it some further thought.


Oh okay. I just noticed it cause there was an (!) when i did a `brew cask list`.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11844](https://teamcity.mesosphere.io/viewLog.html?buildId=107094&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 206 Build time: 00:04:03


Food for thought. ;)


Done, thanks.


Perfect, thanks.


Sounds good :+1:


@abbradar Hm, we should probably install those, but auto-starting of dbus services seems to work regardless (probably via the old *.service files in share/dbus-1/system-services). For example, stopping systemd-logind manually and them sending a message like
```
$ dbus-send --system --print-reply --dest=org.freedesktop.login1 /org/freedesktop/login1 "org.freedesktop.login1.Manager.ListSeats"
```
does trigger a start of systemd-logind:
```
Jan 18 13:06:43 machine dbus[242]: [system] Activating via systemd: service name='org.freedesktop.login1' unit='dbus-org.freedesktop.login1.service'
Jan 18 13:06:43 machine systemd[1]: Starting Login Service...
Jan 18 13:06:43 machine dbus[242]: [system] Successfully activated service 'org.freedesktop.login1'
Jan 18 13:06:43 machine systemd[1]: Started Login Service.
```


I think that would make most sense. (Linux measurements are not all that necessary, as the impact will be less, but if you can do that, that's a nice bonus.)


the change seems ok to me, please go ahead and merge it back to `master`


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1188](http://teamcity.monogame.net/viewLog.html?buildId=13727&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:29:04


I dont think that msg is intended for me.
Op 18 jan. 2016 14:08 schreef "Carlo Sciolla" <notifications@github.com>:

> the change seems ok to me, please go ahead and merge it back to master
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sytac/resumator/commit/ce52299f4c29bcd327263437133b46fee0c5a74f#commitcomment-15506509>
> .
>


Right, but it explains why I used the c_str... because of the old standard ;-)


AAA linjeskift


Not DONE => Verwende OAuth Anmeldung


That should read "Engine ID matches"


That should read "Engine ID does not match"


You're right. Keeping this, thanks.


just buy domain name


ROFL.


Is this correct?


Is this a configuration issue?