This will
  * run `git` as root on the host system (meh....)
  * add files to your OctoPi checkout folder that will still be there on consecutive builds, making this step fail ("destination path ... already exists and is not an empty directory") and might even cause old files to be included on the image
  * force the use of external git on environments where the qemu-static binary doesn't die on smart-http calls

Better option:
  * roll back to old gitclone usage within the `chroot_script`
  * create buildserver-specific (!) pre-build script that manages the git mirror and injects it into the filesystem and also cleans up after itself ([Example](https://gist.github.com/foosel/c7a80ce9cb571f6dedd4))

Build-environment specific things (like necessary mirroring or whatever needed on Jenkins, Travis, etc) should not be part of the regular build pipeline, otherwise you risk making the build pipeline unusable for other build pipelines.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1148](http://teamcity.monogame.net/viewLog.html?buildId=13507&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


This commit was used as a snapshot, not meant to be reviewed. Sorry.


same thing here


as before: would be set to False


`if (empty($validationErrors) &&`


서버를 키려고 하니 안되면서 요걸 넣으라고 하길래 추가했습니다.


マージ


comment is outdated, no it doesn't crash anymore thanks to the fix in commit 5be217f  .


About the last paragraph of the commit message: We *must* traverse pre-order since the children *will* re-use the paths of a parent StyleSet that they find when traversing up. Therefore, we must ensure that this path is up-to-date before refreshing the children.

Can we be sure that this is correct regarding the "visual parent vs. QObject parent" issue? We're preferring the visual parent when traversing up and we're doing the same when propagating down, so a StyleSet that's refreshing its path should always encounter an up-to-date path.

Thinking about this, I think it's not entirely correct; consider a hierarchy like this:

```js
Item {
  id: root
  property var someProperty: StyleSet.props.number("foo")
  Item {
    id: itemOwner

    function getItem() {
      return SomeComponent.createObject(itemOwner, {});
    }
  }

  Item {
    id: someItem
    property var someProperty: StyleSet.props.number("foo")
    Item {
      id: itemUser

      property var item
      Component.onCompleted: {
        itemUser.item = itemOwner.getItem();
        itemUser.item.parent = itemUser;
      }
    }
  }
}
```
When `root` gets reparented, the objects are traversed in the order `root`, `itemOwner`, `<dynamically created item owned by itemOwner>`, `someItem`, `itemUser`, right? In that case, the dynamically created item owned by `itemOwner` will see the not-yet-refreshed path that's cached in the `StyleSet` instance attached to `someItem`.

To fix this, I guess we'll need to traverse the complete visual hierarchy, then go back to the root item and traverse the QObject hierarchy. I think this also means that we'll need to traverse the QObject hierarchy even if we've already seen a particular object while traversing the visual hierarchy since it might have QObject children that we haven't seen yet. Alternatively, we could maybe collect in a vector the QObject children in the order we would visit them, then visit them (skipping the ones we've already visited while traversing the visual hierarchy) after having traversed the visual hierarchy.

Ugh, this is ugly. I'm not at all sure if this approach would be safe in all cases -- my hunch is that you could construct a scenario where this one fails as well.


This is odd -- these lines already exist in the current .gitignore.  I don't know why they appear here.  But I also see other diff's in this file with CoreFx that we may need, so I suspect you may want to recopy from CoreFx.  If feels like this branch is based on an out-of-sync master and probably needs a rebase (after syncing master).


to remove


Needs to be `$root`


Not sure. But it is more important that before that, my completion on this project didn't work properly.
Anyway, need to test it on windows.


Because past is before future? :-)
I agree.


test GitHub test


removed afterward


OMG that hide and seek program :D


I get this error here:
unit-gbuilder-0[994]: 2016-01-12 13:24:10 INFO unit.gbuilder/0.install logger.go:40 Traceback (most recent call last):
unit-gbuilder-0[994]: 2016-01-12 13:24:10 INFO unit.gbuilder/0.install logger.go:40   File "/var/lib/juju/agents/unit-gbuilder-0/charm/hooks/install", line 8, in <module>
unit-gbuilder-0[994]: 2016-01-12 13:24:10 INFO unit.gbuilder/0.install logger.go:40     bootstrap_charm_deps()
unit-gbuilder-0[994]: 2016-01-12 13:24:10 INFO unit.gbuilder/0.install logger.go:40   File "lib/charms/bootstrap.py", line 12, in bootstrap_charm_deps
unit-gbuilder-0[994]: 2016-01-12 13:24:10 INFO unit.gbuilder/0.install logger.go:40     apt_install(['python3-pip', 'python3-yaml'])
unit-gbuilder-0[994]: 2016-01-12 13:24:10 INFO unit.gbuilder/0.install logger.go:40   File "lib/charms/bootstrap.py", line 36, in apt_install
unit-gbuilder-0[994]: 2016-01-12 13:24:10 INFO unit.gbuilder/0.install logger.go:40     if isinstance(packages, basestring):
unit-gbuilder-0[994]: 2016-01-12 13:24:10 INFO unit.gbuilder/0.install logger.go:40 NameError: name 'basestring' is not defined
unit-gbuilder-0[994]: 2016-01-12 13:24:10 ERROR juju.worker.uniter.operation runhook.go:107 hook "install" failed: exit status 1


New problem arises: now the window `on_pbTransportationList` is shown at the same time as `kgo` and this is confusing!
Also, the get removed. Can't we put in a `wait until transportationlist-finished` ???

Solution: split function in two separate functions. We first finish `on_pbTransportationList` and later call the function that removes all markers and runs `kgo`.

When user presses NO in messagebox, go to this new function immediately.


テスト　GitHub　テスト


Nitpick: It would be nice to add the test beforehand to see how it fails.


Nitpick again: It would be nice to add the test beforehand to see how it fails.


Is a balance of 10 needed if we are recreating this user every time?


I have just test the latest version ,everthing works well ,but what is you issue?


Hi @EugenMaysyuk ,

I have created the test, I'm going to create the jira issue.

Thanks


"Do. Or do not. There is no try."


It's looks fine in my vim editor :-) So this is probably due to  the unequal translation of tabs between vim and GitHub, I guess.


Do we need this test in addition to the above test?


yes


It's a balance that says "more gems than I need". Probably should extract that out into a variable.


agreed


Damn, i just thought about sending you a pull request with this function (i need this in my project), but then i discovered it here ;D
It would be awesome if you could release 3.7.2 in near future :)


In fact there are many tries, in case you don't have a docker image of your cd :dart:


Because check the single field is faster than 3 fields + getting the current date and compare them.


Can we not merge the tests with the `creates a group` test?


ok


my bad


ah derp forgot to add permissions for the sysfs


I think so. The test above says "a type is required". This test says "passing in an unsupported type will return an error"


Can we not also merge this test with `creates a party` ?


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/22679/testReport/) for this commit**


will do, in this PR https://github.com/aduprat/james-project/pull/3/commits


OK


Isn't `ProcedureCall` slightly more understandable?


God morgon bror. Hörde att din mobil dött.


@andrerom: ok, changed.


Done in this PR https://github.com/aduprat/james-project/pull/3/commits


```php
$cmd = sprintf(
    '%s/wiff context %s module %s --force --unattended %s 2>&1',
    escapeshellarg(__DIR__),
    escapeshellarg($contextName),
    escapeshellarg($action),
    escapeshellarg($modulePath)
);
```


Done


Remove empty line


dataservices is used by surnia for radio internet access


AddNetAreaColumnToEnvelopeSummary (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (951 of 951 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.64%25-green.svg)


`|encodeJS`


> Hm... Maybe you are right, but I'm still not sure what exactly may be wrong in this case. The message will be serialised just without subject and body.

If I understand things correctly, assuming you serialize a message object, unserialize it and then call `send`, then there are the following cases:

`render` | `template_name` given | rendering done … deserialization
-------- | --------------------- | --------------------------------
False | no | after
False | yes | after
True | no | after (!)
True | yes | before

My suggestion is to handle the last case differently: Not allowing it in the first place. Rendering after deserialization may make the program behave differently (different system time or different system altogether). See also https://github.com/artemrizhov/django-mail-templated/issues/7#issuecomment-62869503


Release Note:
Added set_trunk_groups() method to the switchports API


Bad indentation.


@alebastrov What do you see as the problem here? It looks okay to me. That is to say that `createTempCollection` will  acquire a WRITE lock for the transaction if it has to create the collection, if the collection was not created because it already exists, then we acquire a WRITE lock for the transaction here, before we store the document resource.


Good!


only whitespaces changes here, please undo these changes


:+1: Didn't check that!


If you only use the var once, why even bother setting it?

```javascript
<% for (var l=0, ll = query.languages.length; l < ll; l++) { %>
    <th><%= query.languages[l] %></th>
<% } %>
```


never used ?


Greg: I have to make an exception to the above convention as the `BEST/bestof/API` feature in the repository, uses a different set of Gems. Therefore I left the directory structure for this part unchanged. I added a comment to the confluence web page https://confluence.gannett.com/display/AUTO/Write%2C+Run%2C+and+Push+our+1st+Test.


Good feedback, I'll extract a new object.


Remove extra space. Please rebase/fixup.


unused ?


duplicate not copy... duplicate share the same memory (which may be byte[]) but have different reader / writer index.


changed


this seems identical to `-[WMFGenericHomeSectionController homeDetailViewControllerForItemAtIndex:]`. maybe it should be moved into the main protocol (`WMFHomeSectionController`) and used here?


Déclarer l'autoloader ? Voir peut-être à refactoriser pour déclarer ça dans un `autoloader.php` qui serait aussi utilisé par les autres scripts qui déclarent actuellement l'autoloader (wiff, wiff.php, etc.).


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/22680/testReport/) for this commit**


@masterkain postgres does NOT always use schemas, it has both options. The goal is to allow different physical servers to be switched against.

Note that this hasn't been released yet. I believe there's another PR that needs some cleaning up to deal with threading issues.

If you want to play with this you'll have to reference github directly.

Also note that I didn't write this so open to hearing feedback on what you find and, if it needs any cleanup, happy to accept PRs


Not sure if it would or I got it wrong, just tried with end of string notifier here https://regex101.com/r/hR0pZ5/2, it ends up with few additional steps. Not the bestest of regexes to come up with but it does the job.

Will move the dateformat to constant.


Whenever we take something out of ex, we need to leave it there as an alias for X minor releases.  @liggitt @deads2k impose in reviews.


equality on json looks like a bad idea


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11295](https://teamcity.mesosphere.io/viewLog.html?buildId=103408&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:04:25


setAttribute returns Void, and map does not like them


500 ?


@malirod  ti pobedil,
see 5013380


should be in the right profile


Huh? An empty commit?


111411352_ATDeprecateFields (Nigusse) - x86_64-MacOS-10.9-clang: OK (2048 of 2048 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Déclarer WIFF_ROOT ?

Tant qu'a y être il faudrait peut être refactoriser ça pour le faire à un seul endroit ou s'assurer qu'on soit indépendant de WIFF_ROOT dans la construction de l'instance WIFF.

Le WIFF_ROOT ne devrait alors être que exporté pour les sous-process de WIFF et pas nécessaire pour utiliser WIFF (__DIR__ permettant de récupérer le répertoire racine de WIFF sans ambiguité)...


Just a shot in the dark, but the parameters look inversed opposed to the old version


пофиксил в ветке images


Supprimer `$modulePath` à la fin ?


:thumbsup:


Ran `greenkeeper enable` this morning :)


Do you think it would be a good idea to set target='_blank' on the COI link to open it in a new tab?


should be findFirst to respect strategy ordering. You lack at least one test on this case


Sure, I'll add.


It should be 'cm overlay'.....


options snd-usb-audio nrpacks=1 was definitely needed on a C1 (version 1.55) with certain usb audio cards. Example was the FiO E18. With certain 24bit flac files, it would crash the system otherwise.
I will verify this asap for 2.0


Why reject code instead of just making it work? What do you mean with "does not support such use" anyways? Is the output not correct?


yes


don't commit comment


You're right, I missed commiting a change that adds it to sys/conf/files. Soon we'll introduce another driver, that makes use of e6000sw - by then I'll export it as device and add a note here.


Pourquoi ne pas inclure ça dans wiff.php ? Il est peut-être prévu de livrer `deploy.php` de manière autonome (j'aurais du poser cette question dés le début je pense) ?


This is not the correct place to update version.
Instead following instance variable needs to update:
@friends_path = '/v2.5/me/friends'
@family_path = 'v2.5/me/family'
@self_path = '/v2.5/me'


`break`s are unecessary (unreachable) after a return. I wouldn't normally care but you are inconsistent in this switch statement. I'd suggest removing them.


r should be initialized really.


rebased and added back for gtk2


what does that mean? "you shall not use the same name for a func param and a closure var?"


Great, thanks! Feel free to add it to the NOTES file then as well.


This section should be using consistent version numbers.  I'm also testing the guide with a far more up to date current version, which may need to be reflected in adjustments to the guide itself.


isn't this as good as returning "*"?


This isn't valid JSON.


:black_large_square: :sheep:


What's with the caps? Are you trying to do constants?


dir_is_empty() returns negative on error. I am pretty sure this shouldn't be considered equal to "dir is empty". Please hence change the check to `dir_is_empty(...) > 0` instead.


Can these changes please be forwarded to cm-13.0?

Thank you very much!


Double spacing... Boooo...


Yeah, I didn't realize that would happen. You're right. I'll unpublish 6.2.0 and 6.2.1, and make it v7 instead.


@AkihiroSuda
If there is any problem about this issue, please feel free to discuss with me. Thanks!


Done. Thanks for the heads-up!


Be careful not to over-comment. Any developer knows an `if` and a `forEach`.

Only comment when something needs context or does something unexpected.


Well, the sense of this parameter is to change the behaviour. When passing ``render=True``, the ``True`` value means "yes, render it right now if possible". This is for the case you want to force the rendering before serialization. You can either call ``render()`` or pass ``render=True`` (the short variant).
This is probably good idea for more explanations in the README file. Will do now. Thanks a lot :) I've realised recently that my README contained too less info. Working on it now.


noticed on line 17 too :s
https://github.com/bentidy/nowtv-react-toolkit/commit/453047bfdb554a7416c16b67a5ac28781c9d9095#diff-04c6e90faac2675aa89e2176d2eec7d8R17


No sounds like a tab versus space issue.


this is a "bool", hence should be assigned "true" rather than "1"...


Since you're only using `tl` once, there's no reason to declare it as a variable.

```coffeescript
t = 0
while t < tags.length
    # Do something...
```


According to the w3c spec [1], and the mozilla wiki [2], "The string "*" cannot be used for a resource that supports credentials".

[1]: https://www.w3.org/TR/cors/#resource-requests
[2]: https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#Requests_with_credentials


can this be passed in a designated initializer?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1148](http://teamcity.monogame.net/viewLog.html?buildId=13507&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:27:10


We used "log_" as prefix for the calls in log.[ch]. Maybe call this event_log_delays() or so?


Fixed


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1212.cb10ddda97a92927e8c176f36584ad0de1bbc538](http://build.palaso.org/viewLog.html?buildId=67863&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 824, ignored: 7 Build time: 00:20:08


@Minecrell thanks to the fact that I'm in the commit title, I get pinged every time someone forks this!


Enabled.


[R/exa.createScript.R:101:1:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L101) *style:* **Variable and function names should be all lowercase.**
```r
exa.createScript <- function(channel, name, func = NA,
^~~~~~~~~~~~~~~~
```
[R/exa.createScript.R:103:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L103) *style:* **Variable and function names should be all lowercase.**
```r
                             initCode = NA,
                             ^~~~~~~~
```
[R/exa.createScript.R:104:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L104) *style:* **Variable and function names should be all lowercase.**
```r
                             cleanCode = NA,
                             ^~~~~~~~~
```
[R/exa.createScript.R:105:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L105) *style:* **Variable and function names should be all lowercase.**
```r
                             inType = SET,
                             ^~~~~~
```
[R/exa.createScript.R:106:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L106) *style:* **Variable and function names should be all lowercase.**
```r
                             inArgs = list(),
                             ^~~~~~
```
[R/exa.createScript.R:107:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L107) *style:* **Variable and function names should be all lowercase.**
```r
                             outType = EMITS,
                             ^~~~~~~
```
[R/exa.createScript.R:108:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L108) *style:* **Variable and function names should be all lowercase.**
```r
                             outArgs = list(),
                             ^~~~~~~
```
[R/exa.createScript.R:109:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L109) *style:* **Variable and function names should be all lowercase.**
```r
                             outputAddress = NA,
                             ^~~~~~~~~~~~~
```
[R/exa.createScript.R:110:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L110) *style:* **Variable and function names should be all lowercase.**
```r
                             replaceIfExists = TRUE,
                             ^~~~~~~~~~~~~~~
```
[R/exa.createScript.R:111:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L111) *style:* **Variable and function names should be all lowercase.**
```r
                             mockOnly = FALSE
                             ^~~~~~~~
```
[R/exa.createScript.R:115:3:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L115) *style:* **Variable and function names should be all lowercase.**
```r
  initCode <- m$initCode
  ^~~~~~~~
```
[R/exa.createScript.R:115:17:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L115) *style:* **Variable and function names should be all lowercase.**
```r
  initCode <- m$initCode
                ^~~~~~~~
```
[R/exa.createScript.R:116:3:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L116) *style:* **Variable and function names should be all lowercase.**
```r
  cleanCode <- m$cleanCode
  ^~~~~~~~~
```
[R/exa.createScript.R:116:18:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L116) *style:* **Variable and function names should be all lowercase.**
```r
  cleanCode <- m$cleanCode
                 ^~~~~~~~~
```
[R/exa.createScript.R:118:3:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L118) *style:* **Variable and function names should be all lowercase.**
```r
  inType <- match.arg(inType, ALLOWED_UDF_IN_TYPES)
  ^~~~~~
```
[R/exa.createScript.R:118:23:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L118) *style:* **Variable and function names should be all lowercase.**
```r
  inType <- match.arg(inType, ALLOWED_UDF_IN_TYPES)
                      ^~~~~~
```
[R/exa.createScript.R:118:31:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L118) *warning:* **no visible binding for global variable ‘ALLOWED_UDF_IN_TYPES’**
```r
  inType <- match.arg(inType, ALLOWED_UDF_IN_TYPES)
                              ^~~~~~~~~~~~~~~~~~~~
```
[R/exa.createScript.R:119:3:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L119) *style:* **Variable and function names should be all lowercase.**
```r
  outType <- match.arg(outType, ALLOWED_UDF_OUT_TYPES)
  ^~~~~~~
```
[R/exa.createScript.R:119:24:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L119) *style:* **Variable and function names should be all lowercase.**
```r
  outType <- match.arg(outType, ALLOWED_UDF_OUT_TYPES)
                       ^~~~~~~
```
[R/exa.createScript.R:119:33:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L119) *warning:* **no visible binding for global variable ‘ALLOWED_UDF_OUT_TYPES’**
```r
  outType <- match.arg(outType, ALLOWED_UDF_OUT_TYPES)
                                ^~~~~~~~~~~~~~~~~~~~~
```
[R/exa.createScript.R:121:3:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L121) *style:* **Variable and function names should be all lowercase.**
```r
  inArgs <- do.call(paste, c(as.list(inArgs), sep = ", "))
  ^~~~~~
```
[R/exa.createScript.R:121:38:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L121) *style:* **Variable and function names should be all lowercase.**
```r
  inArgs <- do.call(paste, c(as.list(inArgs), sep = ", "))
                                     ^~~~~~
```
[R/exa.createScript.R:123:7:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L123) *style:* **Variable and function names should be all lowercase.**
```r
  if (outType == EMITS) {
      ^~~~~~~
```
[R/exa.createScript.R:124:19:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L124) *style:* **Variable and function names should be all lowercase.**
```r
    if (is.null(m$outArgs)) {
                  ^~~~~~~
```
[R/exa.createScript.R:127:5:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L127) *style:* **Variable and function names should be all lowercase.**
```r
    outArgs <- paste("(",
    ^~~~~~~
```
[R/exa.createScript.R:128:47:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L128) *style:* **Variable and function names should be all lowercase.**
```r
                     do.call(paste, c(as.list(outArgs), sep = ", ")),
                                              ^~~~~~~
```
[R/exa.createScript.R:131:5:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L131) *style:* **Variable and function names should be all lowercase.**
```r
    outType <- RETURNS
    ^~~~~~~
```
[R/exa.createScript.R:131:16:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L131) *warning:* **no visible binding for global variable ‘RETURNS’**
```r
    outType <- RETURNS
               ^~~~~~~
```
[R/exa.createScript.R:132:5:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L132) *style:* **Variable and function names should be all lowercase.**
```r
    outArgs <- as.character(outArgs)
    ^~~~~~~
```
[R/exa.createScript.R:132:29:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L132) *style:* **Variable and function names should be all lowercase.**
```r
    outArgs <- as.character(outArgs)
                            ^~~~~~~
```
[R/exa.createScript.R:135:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L135) *style:* **Variable and function names should be all lowercase.**
```r
  sql <- paste("CREATE", if (replaceIfExists) "OR REPLACE" else "", "R",
                             ^~~~~~~~~~~~~~~
```
[R/exa.createScript.R:136:16:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L136) *style:* **Variable and function names should be all lowercase.**
```r
               inType, "SCRIPT", name,
               ^~~~~~
```
[R/exa.createScript.R:137:21:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L137) *style:* **Variable and function names should be all lowercase.**
```r
               "(", inArgs, ")",
                    ^~~~~~
```
[R/exa.createScript.R:138:16:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L138) *style:* **Variable and function names should be all lowercase.**
```r
               outType, outArgs, "AS")
               ^~~~~~~
```
[R/exa.createScript.R:138:25:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L138) *style:* **Variable and function names should be all lowercase.**
```r
               outType, outArgs, "AS")
                        ^~~~~~~
```
[R/exa.createScript.R:140:18:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L140) *style:* **Variable and function names should be all lowercase.**
```r
  if (!is.null(m$outputAddress))
                 ^~~~~~~~~~~~~
```
[R/exa.createScript.R:144:24:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L144) *style:* **Variable and function names should be all lowercase.**
```r
                       outputAddress[[1]], "', ", outputAddress[[2]], ")",
                       ^~~~~~~~~~~~~
```
[R/exa.createScript.R:144:51:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L144) *style:* **Variable and function names should be all lowercase.**
```r
                       outputAddress[[1]], "', ", outputAddress[[2]], ")",
                                                  ^~~~~~~~~~~~~
```
[R/exa.createScript.R:157:16:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L157) *style:* **Variable and function names should be all lowercase.**
```r
  if (!is.null(initCode)) {
               ^~~~~~~~
```
[R/exa.createScript.R:159:10:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L159) *style:* **Variable and function names should be all lowercase.**
```r
    for (codeLine in deparse(initCode)) {
         ^~~~~~~~
```
[R/exa.createScript.R:159:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L159) *style:* **Variable and function names should be all lowercase.**
```r
    for (codeLine in deparse(initCode)) {
                             ^~~~~~~~
```
[R/exa.createScript.R:160:25:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L160) *style:* **Variable and function names should be all lowercase.**
```r
      sql <- paste(sql, codeLine, sep = "\n")
                        ^~~~~~~~
```
[R/exa.createScript.R:165:16:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L165) *style:* **Variable and function names should be all lowercase.**
```r
  if (!is.null(cleanCode)) {
               ^~~~~~~~~
```
[R/exa.createScript.R:167:10:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L167) *style:* **Variable and function names should be all lowercase.**
```r
    for (codeLine in deparse(cleanCode)) {
         ^~~~~~~~
```
[R/exa.createScript.R:167:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L167) *style:* **Variable and function names should be all lowercase.**
```r
    for (codeLine in deparse(cleanCode)) {
                             ^~~~~~~~~
```
[R/exa.createScript.R:168:25:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L168) *style:* **Variable and function names should be all lowercase.**
```r
      sql <- paste(sql, codeLine, sep = "\n")
                        ^~~~~~~~
```
[R/exa.createScript.R:173:8:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L173) *style:* **Variable and function names should be all lowercase.**
```r
  for (codeLine in deparse(code)) {
       ^~~~~~~~
```
[R/exa.createScript.R:174:23:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L174) *style:* **Variable and function names should be all lowercase.**
```r
    sql <- paste(sql, codeLine, sep = "\n")
                      ^~~~~~~~
```
[R/exa.createScript.R:178:8:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L178) *style:* **Variable and function names should be all lowercase.**
```r
  if (!mockOnly) {
       ^~~~~~~~
```
[R/exa.createScript.R:179:9:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L179) *style:* **Variable and function names should be all lowercase.**
```r
    if (odbcQuery(channel, sql) == -1) {
        ^~~~~~~~~
```
[R/exa.createScript.R:180:12:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L180) *style:* **Variable and function names should be all lowercase.**
```r
      stop(odbcGetErrMsg(channel)[[1]])
           ^~~~~~~~~~~~~
```
[R/exa.createScript.R:180:12:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L180) *warning:* **no visible global function definition for ‘odbcGetErrMsg’**
```r
      stop(odbcGetErrMsg(channel)[[1]])
           ^~~~~~~~~~~~~
```
[R/exa.createScript.R:185:36:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L185) *style:* **Variable and function names should be all lowercase.**
```r
  function(..., table, where = "", groupBy = "", restQuery = "",
                                   ^~~~~~~
```
[R/exa.createScript.R:185:50:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L185) *style:* **Variable and function names should be all lowercase.**
```r
  function(..., table, where = "", groupBy = "", restQuery = "",
                                                 ^~~~~~~~~
```
[R/exa.createScript.R:186:12:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L186) *style:* **Variable and function names should be all lowercase.**
```r
           returnSQL = FALSE, reader = NA, server = NA) {
           ^~~~~~~~~
```
[R/exa.createScript.R:189:5:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L189) *warning:* **no visible global function definition for ‘assert_that’**
```r
    assert_that(is.character(table))
    ^~~~~~~~~~~
```
[R/exa.createScript.R:190:5:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L190) *warning:* **no visible global function definition for ‘assert_that’**
```r
    assert_that(length(where) == 1)
    ^~~~~~~~~~~
```
[R/exa.createScript.R:192:5:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L192) *warning:* **no visible global function definition for ‘assert_that’**
```r
    assert_that(is.character(where))
    ^~~~~~~~~~~
```
[R/exa.createScript.R:193:5:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L193) *warning:* **no visible global function definition for ‘assert_that’**
```r
    assert_that(length(where) == 1)
    ^~~~~~~~~~~
```
[R/exa.createScript.R:195:5:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L195) *warning:* **no visible global function definition for ‘assert_that’**
```r
    assert_that(is.character(groupBy))
    ^~~~~~~~~~~
```
[R/exa.createScript.R:195:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L195) *style:* **Variable and function names should be all lowercase.**
```r
    assert_that(is.character(groupBy))
                             ^~~~~~~
```
[R/exa.createScript.R:196:5:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L196) *warning:* **no visible global function definition for ‘assert_that’**
```r
    assert_that(length(groupBy) == 1)
    ^~~~~~~~~~~
```
[R/exa.createScript.R:196:24:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L196) *style:* **Variable and function names should be all lowercase.**
```r
    assert_that(length(groupBy) == 1)
                       ^~~~~~~
```
[R/exa.createScript.R:198:5:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L198) *warning:* **no visible global function definition for ‘assert_that’**
```r
    assert_that(is.character(restQuery))
    ^~~~~~~~~~~
```
[R/exa.createScript.R:198:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L198) *style:* **Variable and function names should be all lowercase.**
```r
    assert_that(is.character(restQuery))
                             ^~~~~~~~~
```
[R/exa.createScript.R:199:5:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L199) *warning:* **no visible global function definition for ‘assert_that’**
```r
    assert_that(length(restQuery) == 1)
    ^~~~~~~~~~~
```
[R/exa.createScript.R:199:24:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L199) *style:* **Variable and function names should be all lowercase.**
```r
    assert_that(length(restQuery) == 1)
                       ^~~~~~~~~
```
[R/exa.createScript.R:213:9:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L213) *style:* **Variable and function names should be all lowercase.**
```r
    if (groupBy != "") {
        ^~~~~~~
```
[R/exa.createScript.R:214:7:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L214) *style:* **Variable and function names should be all lowercase.**
```r
      groupBy <- paste(" GROUP BY", groupBy, sep = " ")
      ^~~~~~~
```
[R/exa.createScript.R:214:37:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L214) *style:* **Variable and function names should be all lowercase.**
```r
      groupBy <- paste(" GROUP BY", groupBy, sep = " ")
                                    ^~~~~~~
```
[R/exa.createScript.R:218:32:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L218) *style:* **Variable and function names should be all lowercase.**
```r
                 table, where, groupBy, sep = "")
                               ^~~~~~~
```
[R/exa.createScript.R:219:47:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L219) *style:* **Variable and function names should be all lowercase.**
```r
    sql <- paste("SELECT * FROM (", sql, ")", restQuery, sep = "")
                                              ^~~~~~~~~
```
[R/exa.createScript.R:221:9:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L221) *style:* **Variable and function names should be all lowercase.**
```r
    if (returnSQL) {
        ^~~~~~~~~
```
[R/exa.createScript.R:224:7:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L224) *style:* **Variable and function names should be all lowercase.**
```r
      execArgs <- list(channel, sql)
      ^~~~~~~~
```
[R/exa.createScript.R:226:9:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L226) *style:* **Variable and function names should be all lowercase.**
```r
        execArgs <- c(execArgs, reader = reader)
        ^~~~~~~~
```
[R/exa.createScript.R:226:23:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L226) *style:* **Variable and function names should be all lowercase.**
```r
        execArgs <- c(execArgs, reader = reader)
                      ^~~~~~~~
```
[R/exa.createScript.R:229:9:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L229) *style:* **Variable and function names should be all lowercase.**
```r
        execArgs <- c(execArgs, server = server)
        ^~~~~~~~
```
[R/exa.createScript.R:229:23:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L229) *style:* **Variable and function names should be all lowercase.**
```r
        execArgs <- c(execArgs, server = server)
                      ^~~~~~~~
```
[R/exa.createScript.R:231:12:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L231) *style:* **Variable and function names should be all lowercase.**
```r
      if (!mockOnly) {
           ^~~~~~~~
```
[R/exa.createScript.R:232:17:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L232) *style:* **Variable and function names should be all lowercase.**
```r
        do.call(exa.readData, execArgs)
                ^~~~~~~~~~~~
```
[R/exa.createScript.R:232:17:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L232) *warning:* **no visible binding for global variable ‘exa.readData’**
```r
        do.call(exa.readData, execArgs)
                ^~~~~~~~~~~~
```
[R/exa.createScript.R:232:31:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/exa.createScript.R#L232) *style:* **Variable and function names should be all lowercase.**
```r
        do.call(exa.readData, execArgs)
                              ^~~~~~~~
```
[R/EXADBI.R:6:2:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L6) *style:* **Commented code should be removed.**
```r
## First version written in 2015 by Marcel Boldt <marcel.boldt@exasol.com>
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:7:2:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L7) *style:* **Commented code should be removed.**
```r
## as part of the EXASOL R interface & SDK package. It may be used, changed and distributed freely with no further restrictions than
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:54:23:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L54) *style:* **Commas should always have a space after.**
```r
setMethod("dbGetInfo","EXAObject",
                      ^
```
[R/EXADBI.R:55:14:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L55) *style:* **Put spaces around all infix operators.**
```r
          def= function(dbObj) {
            ~^
```
[R/EXADBI.R:55:25:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L55) *style:* **Variable and function names should be all lowercase.**
```r
          def= function(dbObj) {
                        ^~~~~
```
[R/EXADBI.R:63:52:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L63) *style:* **Commas should always have a space after.**
```r
            NextMethod(generic = "summary", object,...)
                                                   ^
```
[R/EXADBI.R:68:1:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L68) *style:* **lines should not be more than 80 characters.**
```r
setOldClass("RODBC") # the S3 class RODBC will be registered as a superclass of EXAConnection
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:79:23:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L79) *style:* **Commas should always have a space after.**
```r
setMethod("dbGetInfo","EXADriver",
                      ^
```
[R/EXADBI.R:80:14:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L80) *style:* **Put spaces around all infix operators.**
```r
          def= function(dbObj) {
            ~^
```
[R/EXADBI.R:80:25:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L80) *style:* **Variable and function names should be all lowercase.**
```r
          def= function(dbObj) {
                        ^~~~~
```
[R/EXADBI.R:93:52:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L93) *style:* **Commas should always have a space after.**
```r
            NextMethod(generic = "summary", object,...)
                                                   ^
```
[R/EXADBI.R:124:63:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L124) *style:* **Put spaces around all infix operators.**
```r
                              slots = c(init_connection_string="character",
                                                             ~^~
```
[R/EXADBI.R:125:55:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L125) *style:* **Put spaces around all infix operators.**
```r
                                        current_schema="character",
                                                     ~^~
```
[R/EXADBI.R:126:56:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L126) *style:* **Put spaces around all infix operators.**
```r
                                        autocom_default="logical",
                                                      ~^~
```
[R/EXADBI.R:127:48:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L127) *style:* **Put spaces around all infix operators.**
```r
                                        db_host="character",
                                              ~^~
```
[R/EXADBI.R:128:48:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L128) *style:* **Put spaces around all infix operators.**
```r
                                        db_port="numeric",
                                              ~^~
```
[R/EXADBI.R:129:48:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L129) *style:* **Put spaces around all infix operators.**
```r
                                        db_user="character",
                                              ~^~
```
[R/EXADBI.R:130:48:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L130) *style:* **Put spaces around all infix operators.**
```r
                                        db_name="character",
                                              ~^~
```
[R/EXADBI.R:131:53:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L131) *style:* **Put spaces around all infix operators.**
```r
                                        db_prod_name="character",
                                                   ~^~
```
[R/EXADBI.R:132:51:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L132) *style:* **Put spaces around all infix operators.**
```r
                                        db_version="character",
                                                 ~^~
```
[R/EXADBI.R:133:49:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L133) *style:* **Put spaces around all infix operators.**
```r
                                        drv_name="character"
                                               ~^~
```
[R/EXADBI.R:135:71:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L135) *style:* **Commas should always have a space after.**
```r
                            contains = c("DBIConnection", "EXAObject","RODBC")
                                                                      ^
```
[R/EXADBI.R:140:23:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L140) *style:* **Commas should always have a space after.**
```r
setMethod("dbGetInfo","EXAConnection",
                      ^
```
[R/EXADBI.R:141:14:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L141) *style:* **Put spaces around all infix operators.**
```r
          def= function(dbObj) {
            ~^
```
[R/EXADBI.R:141:25:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L141) *style:* **Variable and function names should be all lowercase.**
```r
          def= function(dbObj) {
                        ^~~~~
```
[R/EXADBI.R:142:18:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L142) *style:* **Variable and function names should be all lowercase.**
```r
            if (!dbIsValid(dbObj)) stop("Connection exipired.")
                 ^~~~~~~~~
```
[R/EXADBI.R:142:28:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L142) *style:* **Variable and function names should be all lowercase.**
```r
            if (!dbIsValid(dbObj)) stop("Connection exipired.")
                           ^~~~~
```
[R/EXADBI.R:144:28:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L144) *style:* **Put spaces around all infix operators.**
```r
            list(db.version=paste(dbObj@db_prod_name, dbObj@db_version),
                          ~^~
```
[R/EXADBI.R:144:35:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L144) *style:* **Variable and function names should be all lowercase.**
```r
            list(db.version=paste(dbObj@db_prod_name, dbObj@db_version),
                                  ^~~~~
```
[R/EXADBI.R:144:55:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L144) *style:* **Variable and function names should be all lowercase.**
```r
            list(db.version=paste(dbObj@db_prod_name, dbObj@db_version),
                                                      ^~~~~
```
[R/EXADBI.R:145:24:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L145) *style:* **Put spaces around all infix operators.**
```r
                 dbname=dbObj@db_name,
                      ~^~
```
[R/EXADBI.R:145:25:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L145) *style:* **Variable and function names should be all lowercase.**
```r
                 dbname=dbObj@db_name,
                        ^~~~~
```
[R/EXADBI.R:146:26:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L146) *style:* **Put spaces around all infix operators.**
```r
                 username=dbObj@db_user,
                        ~^~
```
[R/EXADBI.R:146:27:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L146) *style:* **Variable and function names should be all lowercase.**
```r
                 username=dbObj@db_user,
                          ^~~~~
```
[R/EXADBI.R:147:22:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L147) *style:* **Put spaces around all infix operators.**
```r
                 host=dbObj@db_host,
                    ~^~
```
[R/EXADBI.R:147:23:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L147) *style:* **Variable and function names should be all lowercase.**
```r
                 host=dbObj@db_host,
                      ^~~~~
```
[R/EXADBI.R:148:22:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L148) *style:* **Put spaces around all infix operators.**
```r
                 port=dbObj@db_port)
                    ~^~
```
[R/EXADBI.R:148:23:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L148) *style:* **Variable and function names should be all lowercase.**
```r
                 port=dbObj@db_port)
                      ^~~~~
```
[R/EXADBI.R:154:52:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L154) *style:* **Commas should always have a space after.**
```r
            NextMethod(generic = "summary", object,...)
                                                   ^
```
[R/EXADBI.R:178:47:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L178) *style:* **Put spaces around all infix operators.**
```r
                         fields = c(connection="EXAConnection",
                                             ~^~
```
[R/EXADBI.R:179:42:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L179) *style:* **Put spaces around all infix operators.**
```r
                                statement="character",
                                        ~^~
```
[R/EXADBI.R:180:45:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L180) *style:* **Put spaces around all infix operators.**
```r
                                rows_fetched="numeric",
                                           ~^~
```
[R/EXADBI.R:181:46:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L181) *style:* **Put spaces around all infix operators.**
```r
                                rows_affected="numeric",
                                            ~^~
```
[R/EXADBI.R:182:44:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L182) *style:* **Put spaces around all infix operators.**
```r
                                is_complete="logical",
                                          ~^~
```
[R/EXADBI.R:183:44:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L183) *style:* **Put spaces around all infix operators.**
```r
                                with_output="logical",
                                          ~^~
```
[R/EXADBI.R:184:40:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L184) *style:* **Put spaces around all infix operators.**
```r
                                profile="data.frame",
                                      ~^~
```
[R/EXADBI.R:185:40:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L185) *style:* **Put spaces around all infix operators.**
```r
                                columns="data.frame",
                                      ~^~
```
[R/EXADBI.R:186:48:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L186) *style:* **Put spaces around all infix operators.**
```r
                                temp_result_tbl="character",
                                              ~^~
```
[R/EXADBI.R:187:48:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L187) *style:* **Put spaces around all infix operators.**
```r
                                query_sent_time="POSIXct",
                                              ~^~
```
[R/EXADBI.R:188:39:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L188) *style:* **Put spaces around all infix operators.**
```r
                                errors="character",
                                     ~^~
```
[R/EXADBI.R:189:50:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L189) *style:* **Put spaces around all infix operators.**
```r
                                default_fetch_rec="numeric"
                                                ~^~
```
[R/EXADBI.R:199:1:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L199) *style:* **lines should not be more than 80 characters.**
```r
            "Add an int (the length of a newly fetched result set) to rows_fetched."
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:203:1:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L203) *style:* **lines should not be more than 80 characters.**
```r
#         close = function(commit=TRUE) {                              # dbClearResult is in row 880
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:204:1:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L204) *style:* **lines should not be more than 80 characters.**
```r
#           "Frees up all resources, in particular drops the temporary table in the DB."
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:207:17:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L207) *style:* **Commented code should be removed.**
```r
#               warning("Connection seems exipired.\n    ...it's gone...")
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:208:17:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L208) *style:* **Commented code should be removed.**
```r
#               return(FALSE)
                ^~~~~~~~~~~~~
```
[R/EXADBI.R:212:19:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L212) *style:* **Commented code should be removed.**
```r
#                 if(commit) message("Changes commited.")
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:213:1:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L213) *style:* **lines should not be more than 80 characters.**
```r
#             } else stop("Commit failed. Changes NOT commited. Closing aborted.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:214:13:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L214) *style:* **Commented code should be removed.**
```r
#           message("Closing connection...")
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:215:15:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L215) *style:* **Commented code should be removed.**
```r
#             res <- try(odbcClose(connection),silent=TRUE)
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:217:19:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L217) *style:* **Commented code should be removed.**
```r
#                 message("Connection closed.")
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:218:19:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L218) *style:* **Commented code should be removed.**
```r
#                 return(TRUE)
                  ^~~~~~~~~~~~
```
[R/EXADBI.R:220:19:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L220) *style:* **Commented code should be removed.**
```r
#                 warning("Closing not successful.")
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:221:19:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L221) *style:* **Commented code should be removed.**
```r
#                 return(FALSE)
                  ^~~~~~~~~~~~~
```
[R/EXADBI.R:223:23:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L223) *style:* **Commented code should be removed.**
```r
#                     warning(res)
                      ^~~~~~~~~~~~
```
[R/EXADBI.R:224:23:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L224) *style:* **Commented code should be removed.**
```r
#                     return(FALSE)
                      ^~~~~~~~~~~~~
```
[R/EXADBI.R:229:14:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L229) *style:* **Commented code should be removed.**
```r
            #close()
             ^~~~~~~
```
[R/EXADBI.R:235:23:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L235) *style:* **Commas should always have a space after.**
```r
setMethod("dbGetInfo","EXAResult",
                      ^
```
[R/EXADBI.R:236:14:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L236) *style:* **Put spaces around all infix operators.**
```r
          def= function(dbObj) {
            ~^
```
[R/EXADBI.R:236:25:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L236) *style:* **Variable and function names should be all lowercase.**
```r
          def= function(dbObj) {
                        ^~~~~
```
[R/EXADBI.R:239:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L239) *style:* **Variable and function names should be all lowercase.**
```r
            list(statement = dbObj$statement,
                             ^~~~~
```
[R/EXADBI.R:240:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L240) *style:* **Variable and function names should be all lowercase.**
```r
                 row.count = dbObj$rows_fetched,
                             ^~~~~
```
[R/EXADBI.R:241:34:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L241) *style:* **Variable and function names should be all lowercase.**
```r
                 rows.affected = dbObj$rows_affected,
                                 ^~~~~
```
[R/EXADBI.R:242:34:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L242) *style:* **Variable and function names should be all lowercase.**
```r
                 has.completed = dbObj$is_complete,
                                 ^~~~~
```
[R/EXADBI.R:243:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L243) *style:* **Variable and function names should be all lowercase.**
```r
                 is.select = dbObj$with_output
                             ^~~~~
```
[R/EXADBI.R:250:52:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L250) *style:* **Commas should always have a space after.**
```r
            NextMethod(generic = "summary", object,...)
                                                   ^
```
[R/EXADBI.R:260:5:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L260) *warning:* **no visible global function definition for ‘new’, Did you mean 'news'?**
```r
    new("EXADriver")
    ^~~
```
[R/EXADBI.R:265:3:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L265) *warning:* **no visible global function definition for ‘new’, Did you mean 'news'?**
```r
  new("EXADriver")
  ^~~
```
[R/EXADBI.R:274:14:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L274) *style:* **Put spaces around all infix operators.**
```r
          def=function(dbObj) {
            ~^~
```
[R/EXADBI.R:274:24:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L274) *style:* **Variable and function names should be all lowercase.**
```r
          def=function(dbObj) {
                       ^~~~~
```
[R/EXADBI.R:284:47:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L284) *style:* **Variable and function names should be all lowercase.**
```r
setMethod("dbDataType", "EXAObject", function(dbObj, obj, ...) {
                                              ^~~~~
```
[R/EXADBI.R:285:3:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L285) *style:* **Variable and function names should be all lowercase.**
```r
  EXADataType(obj)
  ^~~~~~~~~~~
```
[R/EXADBI.R:289:13:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L289) *style:* **Variable and function names should be all lowercase.**
```r
  vapply(x, EXADataType, FUN.VALUE = character(1), USE.NAMES = FALSE)
            ^~~~~~~~~~~
```
[R/EXADBI.R:302:13:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L302) *style:* **Variable and function names should be all lowercase.**
```r
  vapply(x, EXADataType, FUN.VALUE = character(1), USE.NAMES = FALSE)
            ^~~~~~~~~~~
```
[R/EXADBI.R:309:36:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L309) *style:* **Variable and function names should be all lowercase.**
```r
          def = function(drv, ...) dbGetInfo(drv, "connectionIds")[[1]]
                                   ^~~~~~~~~
```
[R/EXADBI.R:359:1:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L359) *style:* **lines should not be more than 80 characters.**
```r
                             exalogfile=tempfile(pattern="EXAODBC_",fileext = ".log"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:359:57:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L359) *style:* **Put spaces around all infix operators.**
```r
                             exalogfile=tempfile(pattern="EXAODBC_",fileext = ".log"),
                                                       ~^~
```
[R/EXADBI.R:359:69:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L359) *style:* **Commas should always have a space after.**
```r
                             exalogfile=tempfile(pattern="EXAODBC_",fileext = ".log"),
                                                                    ^
```
[R/EXADBI.R:364:1:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L364) *style:* **lines should not be more than 80 characters.**
```r
                             connectionlcctype=Sys.getlocale(category="LC_CTYPE"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:364:70:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L364) *style:* **Put spaces around all infix operators.**
```r
                             connectionlcctype=Sys.getlocale(category="LC_CTYPE"),
                                                                    ~^~
```
[R/EXADBI.R:365:1:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L365) *style:* **lines should not be more than 80 characters.**
```r
                             connectionlcnumeric=Sys.getlocale(category="LC_NUMERIC"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:365:72:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L365) *style:* **Put spaces around all infix operators.**
```r
                             connectionlcnumeric=Sys.getlocale(category="LC_NUMERIC"),
                                                                      ~^~
```
[R/EXADBI.R:369:11:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L369) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
          {
          ^
```
[R/EXADBI.R:370:11:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L370) *style:* **Variable and function names should be all lowercase.**
```r
          EXANewConnection(drv = drv,
          ^~~~~~~~~~~~~~~~
```
[R/EXADBI.R:395:36:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L395) *style:* **Variable and function names should be all lowercase.**
```r
          def = function(drv, ...) EXANewConnection(drv=dbDriver(drv), ...),
                                   ^~~~~~~~~~~~~~~~
```
[R/EXADBI.R:395:56:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L395) *style:* **Put spaces around all infix operators.**
```r
          def = function(drv, ...) EXANewConnection(drv=dbDriver(drv), ...),
                                                      ~^~
```
[R/EXADBI.R:395:57:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L395) *style:* **Variable and function names should be all lowercase.**
```r
          def = function(drv, ...) EXANewConnection(drv=dbDriver(drv), ...),
                                                        ^~~~~~~~
```
[R/EXADBI.R:404:36:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L404) *style:* **Variable and function names should be all lowercase.**
```r
          def = function(drv, ...) EXACloneConnection(drv, ...),
                                   ^~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:416:1:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L416) *style:* **Variable and function names should be all lowercase.**
```r
dbCurrentSchema <- function(con) {
^~~~~~~~~~~~~~~
```
[R/EXADBI.R:418:12:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L418) *style:* **Variable and function names should be all lowercase.**
```r
    res <- sqlQuery(con, "select current_schema")
           ^~~~~~~~
```
[R/EXADBI.R:418:12:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L418) *warning:* **no visible global function definition for ‘sqlQuery’**
```r
    res <- sqlQuery(con, "select current_schema")
           ^~~~~~~~
```
[R/EXADBI.R:419:46:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L419) *style:* **Commas should always have a space after.**
```r
    con@current_schema <- as.character(res[1,1])
                                             ^
```
[R/EXADBI.R:420:30:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L420) *style:* **Commas should always have a space after.**
```r
    message(paste("Schema: ",con@current_schema))
                             ^
```
[R/EXADBI.R:427:1:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L427) *style:* **Variable and function names should be all lowercase.**
```r
EXANewConnection <- function( # change defaults also above
^~~~~~~~~~~~~~~~
```
[R/EXADBI.R:433:32:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L433) *style:* **Put spaces around all infix operators.**
```r
    exalogfile=tempfile(pattern="EXAODBC_",fileext = ".log"),
                              ~^~
```
[R/EXADBI.R:433:44:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L433) *style:* **Commas should always have a space after.**
```r
    exalogfile=tempfile(pattern="EXAODBC_",fileext = ".log"),
                                           ^
```
[R/EXADBI.R:438:45:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L438) *style:* **Put spaces around all infix operators.**
```r
    connectionlcctype=Sys.getlocale(category="LC_CTYPE"),
                                           ~^~
```
[R/EXADBI.R:439:47:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L439) *style:* **Put spaces around all infix operators.**
```r
    connectionlcnumeric=Sys.getlocale(category="LC_NUMERIC"),
                                             ~^~
```
[R/EXADBI.R:447:7:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L447) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(connection_string != ""){
      ^
```
[R/EXADBI.R:451:11:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L451) *style:* **Place a space before left parenthesis, except in a function call.**
```r
        if(dsn!="") {
          ^
```
[R/EXADBI.R:451:15:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L451) *style:* **Put spaces around all infix operators.**
```r
        if(dsn!="") {
             ~^~~
```
[R/EXADBI.R:452:38:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L452) *style:* **Commas should always have a space after.**
```r
            con_str <- paste0("DSN=",dsn)
                                     ^
```
[R/EXADBI.R:454:25:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L454) *style:* **Put spaces around all infix operators.**
```r
        else if (exahost!="" & uid!="") {
                       ~^~~
```
[R/EXADBI.R:454:35:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L454) *style:* **Put spaces around all infix operators.**
```r
        else if (exahost!="" & uid!="") {
                                 ~^~~
```
[R/EXADBI.R:455:70:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L455) *style:* **Commas should always have a space after.**
```r
            con_str <- paste0("DRIVER={EXASolution Driver};EXAHOST=",exahost)
                                                                     ^
```
[R/EXADBI.R:458:1:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L458) *style:* **lines should not be more than 80 characters.**
```r
            stop("Connect failed. Either DSN, host & db_user or a connection string must be given.\n
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:459:1:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L459) *style:* **lines should not be more than 80 characters.**
```r
                 Hint: No lazy declaration of onnection parameters - these have to be stated ' dsn=...'.\n
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:463:11:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L463) *style:* **Place a space before left parenthesis, except in a function call.**
```r
        if(uid!="") {
          ^
```
[R/EXADBI.R:463:15:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L463) *style:* **Put spaces around all infix operators.**
```r
        if(uid!="") {
             ~^~~
```
[R/EXADBI.R:464:39:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L464) *style:* **Commas should always have a space after.**
```r
            con_str <- paste0(con_str,";UID=",uid,";PWD=",pwd)
                                      ^
```
[R/EXADBI.R:464:47:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L464) *style:* **Commas should always have a space after.**
```r
            con_str <- paste0(con_str,";UID=",uid,";PWD=",pwd)
                                              ^
```
[R/EXADBI.R:464:51:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L464) *style:* **Commas should always have a space after.**
```r
            con_str <- paste0(con_str,";UID=",uid,";PWD=",pwd)
                                                  ^
```
[R/EXADBI.R:464:59:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L464) *style:* **Commas should always have a space after.**
```r
            con_str <- paste0(con_str,";UID=",uid,";PWD=",pwd)
                                                          ^
```
[R/EXADBI.R:467:11:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L467) *style:* **Place a space before left parenthesis, except in a function call.**
```r
        if(exaschema!="SYS") {
          ^
```
[R/EXADBI.R:467:21:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L467) *style:* **Put spaces around all infix operators.**
```r
        if(exaschema!="SYS") {
                   ~^~~
```
[R/EXADBI.R:468:39:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L468) *style:* **Commas should always have a space after.**
```r
            con_str <- paste0(con_str,";EXASCHEMA=",exaschema)
                                      ^
```
[R/EXADBI.R:468:53:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L468) *style:* **Commas should always have a space after.**
```r
            con_str <- paste0(con_str,";EXASCHEMA=",exaschema)
                                                    ^
```
[R/EXADBI.R:471:35:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L471) *style:* **Commas should always have a space after.**
```r
        con_str <- paste0(con_str,";EXALOGFILE=",exalogfile)
                                  ^
```
[R/EXADBI.R:471:50:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L471) *style:* **Commas should always have a space after.**
```r
        con_str <- paste0(con_str,";EXALOGFILE=",exalogfile)
                                                 ^
```
[R/EXADBI.R:474:35:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L474) *style:* **Commas should always have a space after.**
```r
        con_str <- paste0(con_str,";LOGMODE=",logmode)
                                  ^
```
[R/EXADBI.R:474:47:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L474) *style:* **Commas should always have a space after.**
```r
        con_str <- paste0(con_str,";LOGMODE=",logmode)
                                              ^
```
[R/EXADBI.R:477:1:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L477) *style:* **lines should not be more than 80 characters.**
```r
        con_str <- paste0(con_str,";CONNECTIONLCCTYPE=",connectionlcctype,";CONNECTIONLCNUMERIC=",connectionlcnumeric)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:477:35:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L477) *style:* **Commas should always have a space after.**
```r
        con_str <- paste0(con_str,";CONNECTIONLCCTYPE=",connectionlcctype,";CONNECTIONLCNUMERIC=",connectionlcnumeric)
                                  ^
```
[R/EXADBI.R:477:57:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L477) *style:* **Commas should always have a space after.**
```r
        con_str <- paste0(con_str,";CONNECTIONLCCTYPE=",connectionlcctype,";CONNECTIONLCNUMERIC=",connectionlcnumeric)
                                                        ^
```
[R/EXADBI.R:477:75:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L477) *style:* **Commas should always have a space after.**
```r
        con_str <- paste0(con_str,";CONNECTIONLCCTYPE=",connectionlcctype,";CONNECTIONLCNUMERIC=",connectionlcnumeric)
                                                                          ^
```
[R/EXADBI.R:477:99:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L477) *style:* **Commas should always have a space after.**
```r
        con_str <- paste0(con_str,";CONNECTIONLCCTYPE=",connectionlcctype,";CONNECTIONLCNUMERIC=",connectionlcnumeric)
                                                                                ^
```
[R/EXADBI.R:481:35:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L481) *style:* **Commas should always have a space after.**
```r
        con_str <- paste0(con_str,";autocommit=",autocommit)
                                  ^
```
[R/EXADBI.R:481:50:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L481) *style:* **Commas should always have a space after.**
```r
        con_str <- paste0(con_str,";autocommit=",autocommit)
                                                 ^
```
[R/EXADBI.R:485:25:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L485) *style:* **Put spaces around all infix operators.**
```r
        while (length(d)>0) {
                       ~^~
```
[R/EXADBI.R:486:39:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L486) *style:* **Commas should always have a space after.**
```r
            con_str <- paste0(con_str,";", names(d[1]),"=",d[1])
                                      ^
```
[R/EXADBI.R:486:56:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L486) *style:* **Commas should always have a space after.**
```r
            con_str <- paste0(con_str,";", names(d[1]),"=",d[1])
                                                       ^
```
[R/EXADBI.R:486:60:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L486) *style:* **Commas should always have a space after.**
```r
            con_str <- paste0(con_str,";", names(d[1]),"=",d[1])
                                                           ^
```
[R/EXADBI.R:491:12:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L491) *style:* **Variable and function names should be all lowercase.**
```r
    con <- odbcDriverConnect(con_str)
           ^~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:491:12:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L491) *warning:* **no visible global function definition for ‘odbcDriverConnect’**
```r
    con <- odbcDriverConnect(con_str)
           ^~~~~~~~~~~~~~~~~
```
[R/EXADBI.R:492:21:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L492) *style:* **Variable and function names should be all lowercase.**
```r
    exa_metadata <- odbcGetInfo(con)
                    ^~~~~~~~~~~
```
[R/EXADBI.R:492:21:](https://github.com/vsimko/r-exasol/blob/64fa54d744dae14d27cd4eac8cc2fad83975cd50/R/EXADBI.R#L492) *warning:* **no visible global function definition for ‘odbcGetInfo’**
```r
    exa_metadata <- odbcGetInfo(con)
                    ^~~~~~~~~~~
```


no problem, thanks.
Thanks to greenkeeper/travis for notifying me it broke my build - ;)


Hmm, I feel like yes, I *did* mean roots. Which will still be leaves at this point. I'll try to clarify.


Do we really need this? What is default selection?


Done in b14909c


Will it remove all selector elements and event handlers from the DOM?


Consider doing this via CSS and classes instead. Inline CSS is a nono.


I support this function (and three functions below) should be implicit, why do we need it in the public interface?


We discussed that this was needed a long time ago I thought I put that back. Let me check if I need to push.


Just ran into this by accident. But isn't there a space in between the "chalk & cheese"?


AddNetAreaColumnToEnvelopeSummary (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (2051 of 2051 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


And a few more things as well


rnb.run.import(data.source=data.source, data.type="infinium.idat.dir", dir.reports=report.dir)
2016-01-12 16:08:59     0.3  STATUS STARTED Loading Data
2016-01-12 16:08:59     0.3    INFO     Number of cores: 1
2016-01-12 16:08:59     0.3    INFO     Loading data of type "infinium.idat.dir"
2016-01-12 16:09:00     0.3  STATUS     STARTED Loading Data from IDAT Files
Error in rnb.get.annotation(platform) : unsupported annotation type


I'm sure I changed this...


shouldn't this rather be log_debug()?

Also, wouldn't it be useful to add explanations about what is shown? Something terse, but that gives an indication what the 64 integers shown mean. Could be something like "Logarithmic histogram of event loop iteration durations" or so?


There is inconsistency in output rendering, input colours (Mesh ambient, diffuse and Light ambient, diffuse) don't give the same output as in the codepen generator. See issue #11


if i understand correctly, the base class uses a setter to support VC's w/ a nib/storyboard. VC's should be immutable and inject dependencies via their designated initializer wherever possible


This table summarizes the behavior of `extract(expand=False)`


This would be a good place for a comment.


is this warning message ok?


Be careful of automatically running `brew cleanup` - in the case of a postgresql upgrade (e.g., from 9.4 to 9.5) the previous version of postgresql is needed to run [pg_upgrade].

[pg_upgrade]: http://www.postgresql.org/docs/current/static/pgupgrade.html


also changed on my local.


Does this get uncommented in a later commit?


the point is
getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN, WindowManager.LayoutParams.FLAG_FULLSCREEN);
in MainActivity.java


```
printf "1\t2\n"
```
is probably the most portable.


Should be assigned "true" again, not "1".

But, do we actually need the variable at all? last_run should be 0 initially, as we 0-initialize all our objects on allocation, including sd_event. That should suffice as check whether thing are initialized yet, no?


@rkuhn do you intentionally omit the project prefix in the commit msg?


전역변수의 경우는 _를 붙이는 걸로 합시다
_delayTime으로 수정해주세요


kay thx for the research
fix for the remove would be:

```c++
        LfgPlayerRewardData data = LfgPlayerRewardData(dungeon->Entry(), GetDungeon(gguid, false), done, quest);
        player->GetSession()->SendLfgPlayerReward(data);
        player->RemoveAurasDueToSpell(LFG_SPELL_DUNGEON_COOLDOWN);
    }
```


What does this function name stand for and why isn't it documented?


Oh yeah! I hurried :)


Please document all functions.


я бы засунул регексп, пожалуй, в переменную


Needs documentation.


Yeah, could we perhaps add a channel that watchServices() can wait on until we have read all the Namespaces?  That was one very nice thing about the GetNamespaces + update pattern before.  This sleep is pretty fragile.


Consider changing this ctor to accept byte arrays instead of integers.


WM_GREAT_ECHO is a Chorus skill, so it should get flagged by:
```
bool is_chorus = ( skill_get_inf2(skill_id)&INF2_CHORUS_SKILL );
```
And return:
```
	if ((inf2&INF2_CHORUS_SKILL || skill_id == WL_COMET) && *c == MAX_PARTY)
		return 0; // Entire party accounted for.
```

I left out the miscellaneous case because we pretty much have all the other cases checked. If we just have:
```
	if (*c >= 1)
		return 0;
```
It would be more of a fail safe check I guess.

You are correct about WL_COMET and AB_ADORAMUS though. Thanks!


I know I asked you to do this, but now I realized I asked you to use Doxygen markup. Does this work with RDoc? (I'm really, really sorry if it doesn't. SORRY.)


Ah, yes, someone commented that that was never good for anything. Maybe we should formalize that after some discussion.


We have <key> and <value> colours.
Also add a semicolon from key to value.


Just import the map entry.


Yeap, it will reset current selection.


docs.


:P


Yes, it supposed to be a destroy method.


This seems repetitive from getNameInner


unSerscore?


I didn't want to clutter up the output of every print, and figured wherever someone discovered the environment variable would have informed them on what to expect...

The function name printed here is the context of the delays, not the function doing the logging.


"a map" not "the map". Also add a dot.


Sure, that part needs to be cleaned too. This PR isn't a complete replacement for yours - I just wanted for it to be tested first :smile:


I don't remember what was the decision but it was written down AFAIK. Was it only to drop the `+=!` prefixes or the project prefix altogether?


@massenz do you mind to point me to where the ApiController above came from?


&& not &


Ok,let's leave it... I think also I'll move it to individual device files, so we can add also the audio modules for each devices...


let’s discuss in a more discoverable place, I’ll open an issue about this


Based on the screenshot in #2550, are you sure this is even the commit that introduced most of the changes people were upset about? Going solely off of that screenshot, it looks like those changes were already in place before this commit.


This should be `mv ../superpowers-web systems/web`, see superpowers/superpowers#27


Can we use IRC instead? Getting everyone at the same table helps coordination :)


I actually agree with importing and calling reload that way instead of directly, but if you're going to do that, you should remove the direct import above. :P


The key should be nullable. Use this.getInnerType().getName() which handles null.


Alright!


Yup, look like some translation pb with shortest name


First Commit


sure


This should be `mv ../superpowers-game systems/game`, see superpowers/superpowers#27


The key should be nullable. Use this.getSecondInnerType().getName() which handles null.


For existing users, it is as simple as saveUser(u)


Should we use six.u('none'), or does this work across py2 and py3?


Use the EMPTY constant.


知乎观光团


removed


Good


Really this should be simplified to "if user not in self.jira:" right?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11296](https://teamcity.mesosphere.io/viewLog.html?buildId=103420&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:13


здесь можно что-то типа getVimeoApiUrl добавить, а вообще, если аякс потребуется и дальше, лучше отдельный скрипт для него сделать


I believe we could simplify some things if we had an TypeEntry and wrapped some methods as a set (perhaps list) of entries.


if user not in self.jira:


I wonder if you imagine how many projects were using METADATA.json which you've removed now.


Yeah, that, a lot of times. There's a lot of cleanup that could be done in this code... Thanks for tackling some of it.


ObjexxFCL41 (DeadParrot) - x86_64-MacOS-10.9-clang: Tests Failed (1598 of 2056 tests passed, 72 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-77.72%25-red.svg)


Please use the variables for this, you want $white here I think.


Perhaps getKeyType and getValueType?


__API description syntax error on line undefined__:  (Autogenerated message from apiary.io)


shouldn't this be 54?


Awesome!


/cc @SeanFeldman


cc @jrgm


:-1: unfortunately "Read More" has empty, default cells with this change because `WMFSelfSizingArticleListTableViewController` doesn't know how to configure cells:

![image](https://cloud.githubusercontent.com/assets/444217/12267530/8bf2a8b8-b916-11e5-8590-b7f874383807.png)

seems like the options are:

- Make a VC dedicated to "Read More"
  - pro: more options for customization down the line
  - con: code duplication in the short term—but this could be mitigated w/ a category on `WMFArticlePreviewCell` that populates it w/ data from a `MWKSearchResult`
- Make the "related title list" VC have two factory methods: `+newSelfSizingReadMoreViewController` and `+newDefaultReadMoreViewController` which use different table views internally
  - pro: DRY
  - con: need to be careful about making it too generic/monolithic if "Read More" spec becomes too divergent from related articles in the feed


hi, @JoshRosen , when i compiled spark with "hadoop.version 2.6.0-cdh5.4.7", it could not download "hadoop-client-2.6.0-cdh5.4.7.pom" from "https://repo1.maven.org/maven2", i  visited url  "https://repo1.maven.org/maven2/org/apache/hadoop/hadoop-client/2.6.0-cdh5.4.7/hadoop-client-2.6.0-cdh5.4.7.pom" directly, it displayed 404 not found.
maybe, compile with mapr, there is same errors.


Use a char rather than a string, if just a single character. Also add a colon between a key and a value.


This threw an error for me. Not sure what to change it to though. Thoughts? Should it be a field instead? @rdingwell


if 'request' not in self.tokens[user]:


Thanks for tackling this! Would you mind doing some of those updates?


Can you not use `g_clear_object`?


But what's difference between this and calls to close-init?


nullptr


can you try with https://github.com/simnalamburt/vim-mundo, this is an active fork of gundo,also support neovim ,as you know gundo do not support neovim


Using variabels: @base-margin @base-padding? In the complete less file are a mix of em and px values

Maybe we should create a refactoring task to unify this and colors?


mnbvcxzlkjhgfdsapoiuytrewq


nullptr nullptr nullptr :)


no, i'll set it back.  i think this was a merge issue i had.


Couldn't this name be a bit simpler.
Perhaps such as "Player->Role"?


@SecUpwN No


i added "Cloudera Repository" in pom.xml, then compiled successfully.


ObjexxFCL41 (DeadParrot) - i386-Windows-7-VisualStudio-12: OK (2062 of 2062 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Same assert as line 337.


The environments are so similar that I would guess so. I don't understand why any of those packages are there though in the Travis setup - why aren't they installed by Pkg.build?


Is there some documentation about this?


Hi @wsdjeg, thanks for the suggestion!
I'm right now building my neovim configuration in which vim-mundo is being used.
You can checkout here:
https://github.com/ronisbr/nvim
It is still incomplete, but it is getting there :)


It's not allowed to add the 'f' in WebKit, see https://webkit.org/code-style-guidelines/#floating-point-literals

I don't see any value in avoiding the cast; surely there's not going to be any real performance benefit to that?


I don't get what this function does? I mean I understand that you want to apply the "slider" change, move selection up or down the element parents, but the interface looks too unclear.

Also why do you need a callback function here? This is a synchronous action.


Split the arg into an array. If the length is divisible by 2 then use the key type otherwise use the value type.


`$temp = sprintf("

Ratio of Glyphs Implemented: %d\% (%d glyphs implemented, %d pending)

", int($implemented / ($unimplemented + $implemented) * 100), $implemented, $unimplemented);`


Well, later eel-gdk-pixbuf-extensions was complete removed from nautilus, and this commit is just a preparation for it.
Ok, i will use this for gtk2 too.


I disagree. I know that's what we use everywhere in WebKit, but this is chromium and specifically in this file there's no single usage of 'nullptr', but of NULL (everywhere, actually), so I'd rather keep it like that as it would not buy us anything anyway.


See my previous comment :)


Spelling error - please fix


getValueType is already taken and I am not sure if it is wise to override its behaviour.


LGTM to this commit.
1. Is this a standard you saw somewhere else or you just thought it's a good idea to reflect the NuGet packages on the project name?
2. Why on Portable projects you also added a Portable folder? I would recommend removing it, because the name itself already includes it. What do you think?


`$temp2 = sprintf("Rate of Implemented Glyphs : %d\% [%d glyphs done, %d glyphs pending]", int($implemented / ($unimplemented + $implemented) * 100), $implemented, $unimplemented);


I suggest to have another function instead. Something like "selectElement(element)".

Call to this function should change the current selection and trigger **onElementSelected** callback. Looks pretty clear to me.


@dLobatog appears to be at http://projects.theforeman.org/projects/foreman/wiki/How_to_Create_a_Plugin#Adding-a-Pagelet and the linked page.


LGTM to this commit


:cool:


OK. In WebKit we require it for new code even when old-style NULL is used elsewhere nearby, and it's recommended in Chromium too, but it doesn't really matter, especially not in a downstream patch.


`$buffer .= qq|<li>Font file is generating now.|;`


Is this really needed? `rails_helper` requires `spec_helper`, so everything should work out of the box.


Also use -1 as the modified (or whatever it is called) when splitting. Just as in https://github.com/magnusulf/MassiveCore/blob/master/src/com/massivecraft/massivecore/command/type/collection/TypeCollection.java#L169
or simply call that method.


`$buffer .= qq|<h2>Character Code-point Information</h2>|;`


It will not unbind event handlers etc. It will simply reset current selection.


I don't have any issue, for now.


players can learn all spells for all spec on dalaran trainer.


That's a great point


we have and colors?


Right. I was lazy and did not use it because I thought the version of glib bundled in chromium was not recent enough, but I've checked and it's available. I'll change it, thanks.


It's common practice, but only because it's so easy to make this mistake!


@monsta
rebased and and used for both toolkit versions


So, with this change:
1. The 1st build is still going to fail on VS but the 2nd will work, right? (like the current status...)
2. Using MSBuild the build will fail until you manually call to restore packages?


Callback function can be used to change slider state.


$buffer .= qq|

Existing VersionYour Edits (unsaved)

|;


I have in mind one more thing about it.

I believe that it may be useful to change selection style. We may want to use different styles on different platforms. Just don't know what can be done about this.

Maybe something like optional "drawSelectionFunction" parameter for init method? If it is not set - we'll use default function.


You've included it in `spec_helper` line 20, so this file is not needed. Documentation only showed example of usage for every possible situation (i.e. you're not using Cucumber, Spinach, and Minitest)


>> I suggest to have another function instead. Something like "selectElement(element)".

This is too unclear!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11297](https://teamcity.mesosphere.io/viewLog.html?buildId=103425&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:13