;-P Lolz
The "delay" that there once was when you add an e-mail to google analytics seems to be gone.
No more waiting when you are trying to add a "marketing" account.


I don't see the collection being marked as stale here.


you don't use projections like on previous tests ?


Good catch, cheers


TeamCity Civic Assembly :: Build backend + frontend [Build 147](http://54.229.176.143/tc/viewLog.html?buildId=408&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


or maybe you do (see my previous comment)


as far as I know this is valid [semver](http://semver.org/) syntax, which scripts do you mean?


prolly slap a copyright notice on top here and call it good.


This commit is being reviewed as a part of review issue #156.


Haha yeah. Bingo! Works. :beers:


@dg Should not be there FALSE?


misspelling


:tada:


I tried using block.equals and it did not work.


Adapters are a runtime concept, not a compile-time one, so I think ideally the compiler shouldn’t be aware of them. Seeing `require('../runtime/adapters')` in the semantic pass just feels odd. It also decreases flexibility (until now you could e.g. compile the code on one machine and send it over to another for execution; this becomes impossible now unless they share exactly the same adapter configuration).

I think a more proper place for this check would be code generated for `ReadProc`/`WriteProc`in `GraphCompiler` — instead of `Juttle.adapters.get` it could e.g. call a utility function which would check the adapter validity and load it.

(As a side note, the last paragraph makes me want to model the adapters not as whole procs, but as separate entities used by procs, like we do for views. Then the check would be in `Juttle.proc.{read,write}`, which seems the most proper place really.)


TeamCity Civic Assembly :: Build backend + frontend [Build 147](http://54.229.176.143/tc/viewLog.html?buildId=408&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:25


好的、感谢！基本很少写rst ;)

发自我的 iPhone

> 在 2016年1月11日，下午7:15，黄健宏 <notifications@github.com> 写道：
>
> @mitnk 引用代码的时候要后跟一个空行，这样代码才会正确地显示出现。现在我已经全部修正了，不过今后写 Sphinx 的时候请注意。 ：）
>
> —
> Reply to this email directly or view it on GitHub.
>


You have to choose a Locale for this


Why did you clear the ext_tables.sql file? After installing the extension I get the error that the table is missing!?


well I have a script that checks the forge API, and they expect integers. look at what the foreman does
https://github.com/theforeman/puppet-puppet/commit/16745028f9af06a32089984bca13db43e0f07e98

no -rc


you already do it in constructor


(puppetlabs does not use -rc as well)


@jonashaag
Thank you for the feedback.
> Imho his should have gone to a separate sub class as it changes behavior of the class quite a bit

It would be nice if you add some test that fails because of changed behaviour for both cases:

> 1) serialization works differently

Can't see any difference for a while.

> 2) you can't use late template initialization anymore

Why not? There is 'render' parameter which is False by default (probably a note should be added to the docstring).


Which ones required more than 100%?


Tabs instead of spaces for indentation :-)


Here tabs should be used too.


Yes!


Also did some beautify


fixed


I don't like the name of this function


Nit: Space after `,`.

I also think this would be worth extracting into a top-level const (this is pretty important list to be buried here).


It saves a Sets.union. Anyway, the code is rewritten later.


I haven't checked yet whether bAlways actually implies being a stacked sector anywhere. If it's safe to set this for regular skyboxes, yes, it can be used here.


No MessagePropertyTest class ?


It seems like we should have an invariant that after evaluating `setFilterField('foo', 'value'); unsetFilterField('foo')`, `hasFilterField('foo') === false`. It looks like that isn't the case, though, since this is checking if `fieldName` has ever been added to `this.filterFields` and I don't see a way that keys get removed from the object. Is this intended behavior?


Feeling so stupid… just after I launched the push, I saw those spaces :'( so sorry…


@shnode 草 今天啥也没写，不让我打个卡了啊


This code is added to verify the random:uniform/1 output range questioned in https://github.com/jj1bdx/sfmt-erlang/issues/21


Got it, thanks Joe.


Are you sure? The branding is still either **sonar-gnome** or **sonar-mate**.


Hey, don't worry :) Just change the settings in your IDE to use tabs


@pynicolas thanks, fixed in ecfb7c5dab5f5033f497dc931a32d504242a5c72


Would it make sense to explicity delete `fieldName` from `this.queryParams`, or is that effectively equivalent to returning `null` on line 307?


not `inner_locus` here?


Also it makes no sense at all to add **write_calamares_branding_desc()** since **Sonar** will get soon or later a complete branding with slideshows.


wiki updated


Modify the error


Hum, it doesn't seem as easy, because I have to fork both lib and bundle and change all namespace which is not very convenient.


Please note: this code is currently UNTESTED


@shnode 挪一下，是为了更合理。


use relative path


I really prefer the `Builder fromMessage(Message message)` followed by `.header(filteredHeaders).build()` pattern


Okay. Can you make a PR for this?


That's because I'm using the same IDE for different projects with different settings :) Anyway, that's not an excuse, I'll take care of the IDE settings next time, I promise :)


右端の赤文字の記号はどういう意味ですか？


Well, the thought is, since the branding pkg is only installled in live layer, we can manipulate it, ie writing a branding.desc.
I decided, one sonar branding package is enough, instead of 2 pkg which only differ in desc file.
Can be changed at any time, if sonar mate has different images for example.


test


These 2 lines can be replaced by:
```c#
trackHeaders ["Authorization"] = authToken;
```


Ah, ok. Makes sense now.


This could just be `_.each(_.keys(this.filterFields), _.bind(this.unsetFilterField, this))`. The logic for both looping and unsetting the field can be abstracted out.


This commit is being reviewed as a part of review issue #132.


You are able to name with simple description.
e.g. name="All tests for google translation"


Just done the same thing and was about to post


also one to not merge while the integrations format is not final....

but the compile time is far faster

slow on first rake run, but each one thereafter is way sub 1 second


There seems to be a bug with sdbus (or we don't know how to use it correctly).  Do not open the system bus.  Make a call to get the existing bus connection...  sd_bus *ipmid_get_sd_bus_connection(void);


Just a temporary measure as long as sonar has no different branding.
I think it'd be best if calamares would simply installe a sonar branding.

Can the branding be overridden in /etc/calamares too?


Sounds good. Had a feeling you did it for a reason.

Cheers.


The "skyboxification" logic has been made dependent on it, and it's needed for SkyCamCompat skyboxes. [It is set for stack points](https://github.com/rheit/zdoom/blob/011385a20e24f6590bf6e992695ab614d9e1a7a1/src/g_shared/a_skies.cpp#L156) but not for SkyCamCompat. So with this commit, there's a [change that has been introduced for StackPoint behavior](https://github.com/rheit/zdoom/blob/011385a20e24f6590bf6e992695ab614d9e1a7a1/src/p_spec.cpp#L1000) and removed for SkyCamCompat behavior.


このファイルの最終行に改行がないってことです。
今後管理外のファイルを扱う際はこの下に1行ずつ追加でいいかなっておもったので。


I don't think so, however we will see. We need some great slideshows anyway. Any artists in mind?


Caught this in the next commit.  I'll rework this when rebasing later.


materialIdDictionaryの為だけに使われる（アカンやつだと思う）


Если про редактированиии юзера задать имя меньше 4 символов, вылетаем с исключением AttributeError: 'EditStaffManageHandler' object has no attribute 'username'


no need to unref the bus once you add the call to the api to get the bus


Sperriger Name


No, I am no art wizzard at all, O like cool artwork, but that's it.
I think we should draft artwork team in forums, perhaps from the people who created some very nice icons.


Thanks :)


don't mix qt and our include


Yep, it's either "" or None. I'm not sure which is more explicit, "" makes sense to me, but None is fine too...


一不小心 直接就提上来了，orz


It's useless here. Just delete from here.


test


Do we already have this fix for docker-1.10?


here i have some inline comment


Wieso der ist doch gut!


what if shtruck was 0 here?


You're right that we cannot anticipate future accesses, so the situation that a bucket may accessed just after removal is unavoidable.

Btw, I mistyped the name -- I meant java.util.PriorityQueue (there is no java.util.PriorityHeap). Not sure why you feel you need to clear and add items again; could you elaborate ?


it does not return always `maxAvailable`:
 - maxAvailable = 16
 - immediatelyAvailable = 5
 - elements = 15

max(immediatelyAvailable, elements) = 15
min(maxAvailable, 15) = 15


ok, after some discussion, there's nothing to fix, every looks ok


It's usually bad form to access `.parameters` directly.

What you should do is something like this (you might have to play with the exact syntax a little bit)

```julia
@generated function eval_UC_spline!{T,N}(a, b, orders, C::Type{Array{T,N}}, S, V, Ad, dAd)
    d = N
    #...
end
```


I'd still keep it in our guide to couple Analytics. It's better to warn about a delay and not have one, then the other way around.


问下，怎么每次都全部删除，然后重新增加呢，是git的配置问题？这样不太好看出修改了哪里。


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11176](https://teamcity.mesosphere.io/viewLog.html?buildId=102866&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:00


hmm, so here you write UINT64_C(-1), but below...


Bonjour @videlec

1)A dataset is a type of data produced to make the project work -> As far as I undersand it, the production of deliverables in ODK is directly linked to the improvement of softwares. In order to improve these softwares, you need to create the appropriate data. This data is divided into datasets

In OpenDreamKit a dataset can be some code written in order to improve a software. The data set is different according to the language in which the code is written for example.

2) It is not a problem if the data is not stored by the university itself. The purpose of such a plan is simply to collect all information about how the project manages its data, not how it should manage its data.
Plus as Viviane said it is only the first version of the Data Management Plan, so it does not need to be perfect.

You can have a look at what Southampton and UpSud have already written to give you a clearer idea.
Thanks @VivianePons  and @fangohr  by the way.


just a heads up, I released 3.0.0-rc1 today ;)


BTW, this commit goes to branch 2.x which definitely are not going to be compatible with 1.x. But anyway I'm wondering if I missed something in this commit.


:P


Hi Marius,
the event "near by" is triggered when beacon goes from Far to Immediate or Near, next time it only triggered when beacon go out or far. Important: background scan and action triggering works only in background, when UI is not foreground, you need to close UI. with open UI you only can scan and locate beacons, without actions as it will be annoying


one thing we can add right now is a toggle for displaying the app on the lockscreen


Looks good


If the InterruptedException occurs here, should we not go back and wait for isPaused to clear ?


I somehow miss the shoulder buttons here. I suppose the thumb buttons are the clicks of the thumb sticks? And what about controllers that support more buttons, like the 4 additional buttons at the bottom of the XBOX One elite controller http://www.xbox.com/en-US/xbox-one/accessories/controllers/elite-wireless-controller ?


:D


If that's the only thing, no problem. It may just as well use 'mate'  instead of 'bAlways' to determine what it is. I meant dependencies in the rest of the code.


I tested 0576c2f by running the demo script on **hw_x86_64_muen**. Interrupt handling does not work any more because of the PIC changes. The log is filled with *Unknown interrupt 0* messages.

This is because in the previous implementation **irq_occurred** marks the given IRQ as pending in the PIC on Muen. It needs to be called prior to the invocation of **_interrupt** since **take_request** will return False otherwise and the interrupt will be dropped. So the order is important and the call is more like a **prepare_request** function if it were present in the generic PIC implementation.


It should contain an example using etcshells::addshell


yeah, thanks


Minor point but you can avoid the function call and conversion to float and back with:
numBuckets = (expireBefore.getMillis() + bucketSpan - 1) / bucketSpan;


@sbeaver-netgate This looks like debug code accidentally included in this commit.


He subido las ecuaciones a integrar, están corregidas y pasan los test.


Maybe it even makes sense to cherry-pick this commit into v1.x. I think so because I can't see any incompatibility now. Not sure what I was thinking about when working on this last night :)


remove `-SNAPSHOT` since that's technically part of the version string as well


...you write simply -1.

I think we should add a new macro for this, maybe called CAP_ALL or so, and it should be defined as `(UINT64_C(1) << (cap_last_cap() + 1)) -1` or something like that: i.e. set only the bits actually known on the system? (Or actually, it might be better to make this a static inline function cap_all() or so, after all it'd be a bit confusing to name this uppercase because people might assume it does not involve a function call that way...)

Of course the earlier != check should then be changed from this:
```c
if (context->capability_bounding_set != UINT64_C(-1))
```
into this:
```c
if (context->capability_bounding_set & cap_all() = cap_all())
```

or something like that


Propose to add `std::` to `ssize_t` and `size_t`. we are using `c++` but not `c`.


Lol.


If you'd like to get back on the mainstream package, I released this support in 0.3.0. Upgrade info is [here](https://github.com/blimmer/node-ember-cli-deploy-redis/blob/develop/CHANGELOG.md#030---2015-11-07).


Could the synchronized block be narrowed to just the startTime/endTime assignments ?


see above


better replace 1ULL by UINT64_C(1)?


@nk0leg, please reformat the code with the new config. From now on one-liners are not allowed


Hello, do you mean that you get both "documentCreated" and "documentModified" events for a single upload?
With a plain Nuxeo Drive when creating a new file or updating an existing file locally I only get 1 event back from the server at next call to GetChangeSummary: respectively "documentCreated" and "documentModified".

Not "needing to mark te document as remotely_created" is a point, but why is that an issue for you? This case is handled by the `_synchronize_remotely_modified` function in the `Processor` class, displaying the following message:

    No local impact of metadata update on document 'test doc.doc'.


ok


Hey Demee, In fact, It is configurable , You will need to add "selected-items"  as an attribute into <ad-table-ajax> if you want to use this feature. If you don't , you only don't add it .


@luistinygod Let's not hard-code this type of thing; is there a way to refactor it to be more re-usable?


Perhaps it serves no purpose, but is also has no downsides IMHO.

I'd rather keep the suggested changes minimal. Being able to say "it signs
the exact same thing as before, except structured differently, and
including the spent amount." makes reasoning for it being secure easy.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 194](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=656&buildTypeId=XbimEssentials_XbimEssentials) is now running


@felipemontoya -- can you include a docstring describing the scenario we are validating here?


I'm actually the other way around, I really do not like it when sites open links in the current tab. Especially if the links are to external sites.


@roidelapluie we don't deploy the -rcs on the forge
we explicitly check against that: https://github.com/voxpupuli/voxpupuli-release-gem/blob/master/lib/voxpupuli/release/rake_tasks.rb#L13-L14


Thank you. :)
Now, you can call the function directly at line 510 and safe the variable.


I already removed it


9f03c1e8f4df018b062e853c5fb930b94001ea92 fixes it


@Chrysostomus for you information: git-packages receive new **pkgver** when they are updated, so pkgrel can always stay at 1, except when there has to be a rebuild for some other reason. **brandr** was already at 0.2-2 just my update had not been pushed, yet ;)


change to `if (!pipe_)`


Are these values used in the  WUAction.actiontype field? If so are the new names necessary? Would this change break clients using WUAction as an API?


Change here too


Aquí están los test de las funciones que en realidad son las ecuaciones dinámicas y cinemáticas.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 194](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=656&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:50


hmm, so my suggestion above of introducing a static inline call cap_all() would not cover this case...

Maybe on top of cap_all() above we should have CAP_ALL defined as (uint64_t) -1 after all, and then use this ehre?

(I am really not comfortable with simply assigning -1 to a unsigned variable, here. This looks like an error to me on first glance, only on the second look I really what is meant here. And if I find this surprising, then static checkers will find this weird too. Hence please, let's at least explicitly cast the -1 to (uint64_t) here, to clarify the intention here.)


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 129](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=657&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


I would be supportive of something like this

`function collapse{T,N,D}(ta::TimeArray{T,N,D}, f::Function; period::Function=week, timestamp::Symbol=:last)`

And then it would be a matter of implementing it ...


Hmm, this change to `$document-id` doesn't look quite right: shouldn't it be derived from `util:document-name()`, not `util:collection-name()`?


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 129](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=657&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:21


You will only see -rc# when cloning from git. If you observe an -rc# version on the forge, for any voxpupuli module, please report it!


When the user specifies a non-existent semantics it is better to throw exception rather than silently using the default.


It looks like this provides support for generating .aar files, as required by the latest Android Studio / gradle / build system--thanks! Any advice on when this (i.e. .aar package) might show up in Maven?


Define the constant in the anonymous namespace at the top of the file. Just `pipe` is too short. I propose to use something like `SDL_streaming_pipe`.


basically the same thing here


Lol nice catch. Is this actually happening for you guys with Encoder?


:-D


Remove /hammerhead


It's broken with newer versions of debbuild because `%_topdir` is now properly defined as [`%{getenv:HOME}/debbuild`](https://github.com/ascherer/debbuild/blob/master/macros/macros.in#L156) just like in rpm. Older versions of debbuild support `.debmacros` to define this variable, but you can't do `debbuild --eval` (that was introduced in debbuild 15.12.0).


Build a new class validateFunction.java in roemetz.core package.
Move doSimulationAnalysis and doNumericalAnalysis out of button listener.


This Is Shit BuT i ACCEPT MERGED.


Lol. I have a PR to upgrade to consul 0.6.1. Check out the changes to `consul.json` in that PR por favor.


applied changes


> The current design should be free of GC allocations in the syscall wrappers

Indeed. I hadn't noticed that all of the `DynamicData()` overrides return a field, not a `new byte[]{...}` (or throw an exception).

This is an excellent point.

> there will be a GC allocation for _SockaddrDynamic (which then would be a class) and another allocation for data (because the ToNative() function can't make sure that DynamicData() stays pinned after it returns).

I don't understand this. Why does the data need to say pinned? Even with the current code, the data is only `fixed` for the duration of e.g. `sys_recvmsg()`; after that point, the array can be moved. A `_SockaddrDynamic` would be no different.

You make a good point that using `_SockaddrDynamic` would force a heap allocation for `SockaddrUn` and `SockaddrStorage`. What I don't know is whether that's actually a problem.

There is thus a question here: which is "worse", possible extra GC allocations or extra code needed at every syscall boundary to check for and "manually marshal" the data via `.DynamicData()`.

I'm inclined to say that the extra code is worse -- more opportunities for mistakes to happen, introducing obscure bugs -- but that's more a gut feeling than anything.

How important do you feel it is to reduce GCs in this codepath? Are the GCs an actual problem, or a theoretical one?


ha, cool - thanks max


yes but even in git PL/foreman/any other vendor does not use -rc, why should we?


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.632.81511e533d2649e6292f0d1b3c836137211769c4](http://build.palaso.org/viewLog.html?buildId=67780&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3324, ignored: 125 Build time: 00:08:19


After reviewing a few different options for modifying the transition styling, I felt that the existing transition was solid enough to stick with. Investigating the addition of a progressive delay is the next option (so each element appears obviously offset from the previous one), but I'll add that via javascript in the future if I still like the effect.


mention eager to master this and git tool soon!


I'm not sure if this is the correct location. If network is slow this could happen before content finished loading... maybe it belongs in function fetchContent (line 331 below appendContent())


This commit is being reviewed as a part of review issue #134.


TeamCity libpalaso :: palaso-precise64-libpalaso-2.6 Continuous [Build 2.6.1014.81511e533d2649e6292f0d1b3c836137211769c4](http://build.palaso.org/viewLog.html?buildId=67778&buildTypeId=PalasoPrecise64v26Cont) outcome was **SUCCESS**
Summary: Tests passed: 3303, ignored: 106 Build time: 00:10:00


:+1: Thanks for the fix!


please separate impl declaration and definition from the main class implementation with some comment. Make the code more readable. I can propose something like this
```
////////////////////////////////////////////////////////////////////////////////
/// class utils::Pipe::Impl
////////////////////////////////////////////////////////////////////////////////
```
and similar for the  utils::Pipe itself.


Looks mostly good, but I really don't like the -1 thing without casts.

I think a cap_all() call or so would be useful, but as admitted above not cover all cases nicely, since it's a variable function, not a constant.

Hence here's another suggestion, different from what I suggested above: instead of introducing cap_all(), introduce:

1. A macro CAP_ALL that simply is defined a (uint64_t) -1
2. A static inline function returning bool, that checks whether a uint64_t has all caps bit that exist on the local kernel set. Something like this: ```c
static inline bool cap_test_all(uint64_t caps) {
uint64_t m;
m = (1 << (()cap_last_cap() + 1)) - 1;
return caps & m == m;
}
```

Then, whenever we have to initialize the bounding set to all bits set we use CAP_ALL, and if we test if all bits are set we use cap_test_all(). That way we might end up setting more caps than actually available, but we only ever check for the caps that exist...

Or something like this...


Published and I've added you as a contributor. Thanks for all your help with the Android side of this!


done


+1 Thanks for the edit @zepner! See 06c32a4 for example of using HTML anchor tags within `<div>` tags


Hi,
I'll try to create that but I have additional fixes to commit so I need some time to put them in.
Bye


I don't understand. If name is `arducopter` and destdir is `bin`, then the name set here will be `arducopter` (relative to bin, I guess). But, if destdir is `example`, then the name set here will be `.../examples/arducopter`? (relative to toplevel build directory).

Am I missing something?

I think this patch is confusing. If `bin` is default, we shouldn't need to have this extra `if` here. I might be missing some other place where `bin` is special.


(update: I figured out this might not be such a great idea after all, see further down...)


Seems you don' need this ctor. And why pipe is passed by value?


@tim-evans @lukemelia this seems to break quite badly in my current attempts to test the latest ecd

any reason why we didn't put `./lib/tasks/read-config` ?


yes it is broken currently :(


Commit message could summarize what is being done and why.


Is what actually happening? This was just correcting my mistake, not yours


Довольно примитивно, но щито поделать


I now committed the working version including the case with the Haunted Creepers as a unit test.

By the way, I really hope that I have not insulted you by this change. In some aspect your solution is even cleaner than mine, as using a custom.SomethingSpell class is a sign that the current system of Spells cannot map the card in question. However, for me Poison Seeds is quite a special case; this becomes even more evident when reading articles on the Hearthstone wiki or some other sites - and thus I prefer keeping the 'ugly' code inside a spell which is just used by one card in this specific case.


My favorite PR ever. LGTM.


It clearly marks the version as a pre-release, as SemVer describes. It also has special meaning in the build pipeline, to protect accidental production builds and deploys against release candidates until the version is bumped.

What kind of problem(s) is it causing, specifically?


Reuse `Valid()` in all similar cases.


I think he means that we need to actually go into the Full exception??

Something weird is happening with packets when we try to use Encoders and Motors at the same time. It seems like continuous mode / updating at too fast of a frequency fills up the buffer too much and motor commands start piling up and not going through. I spent most of this weekend trying to debug it and while rate limiting the Encoder update rate works, that's not ideal


Is this name automatic name setting related to the rest of the patch?


Here's another comment!


590 stars today, great work


We don't need this change :)


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.644.81511e533d2649e6292f0d1b3c836137211769c4](http://build.palaso.org/viewLog.html?buildId=67779&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3303, ignored: 106 Build time: 00:06:00


Add check for `is valid` to all methods.


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


as @rnelson0 stresses (and as i already pointed out) -rcX versions should never end up on the forge
if somehow such a version *is* deployed to the forge, i would personally much rather prefer your foreman tools explode than that people can install those accidental non-releases.


So, sketches contain the legacy defines and non-sketches doesn't?

When writing the first versions, I was assuming we would eventually remove the legacy defines, and that the current binaries could live with them in the meanwhile. Isn't that the case?


Faltou mencionar a inclusão do módulo de settings evitando erro NameError: global name 'settings' is not defined, pois o settings é utilizado para chamar o email principal do sistema (settings.SERVER_EMAIL).


Other way around  - changed toolbar to tabbar


今天测试，查不到通讯录了
-----------------------------------------------
请使用微信扫描二维码以登录
成功扫描,请在手机上点击确认以登录
正在登录...
Ret: 0, ErrMsg:
通讯录共0位好友
开始查找...


This `elif` and `else` seem unrelated to the patch... (because I'm not familiar with what you mean by `sketch`, I might be failing to see their importance...)


You're still creating the `Year` instance. Instead of `dto.getYear() > today.get(ChronoField.YEAR)`


yes


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11177](https://teamcity.mesosphere.io/viewLog.html?buildId=102868&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:20


It is not about a foreman tool, it is the way the puppet community works, I have never seen -rc deployed in metadata.json before, and I was wondering why we would do so and diverging from the rest of the world ?


fixed #80 in this commit


@drewhk I had to change this method to accommodate for the change to `unfold` iso `unfoldInf` (there are no longer 2 `named`, i.e. less nesting)


ack


I'm *REALLY* surprised that you can get rid of all these styles. Really really. Did you check these with a Condition or Action type that actually uses the placeholder?


putting this as a static method in GenericBatchSystem instead, produces a circular dependencies nightmare!


What is meant by -255 and 255 PWM?


There is nothing specially wrong about that, I just find it strange that this is not used in all the modules :-)


One more thought: One nice side-effect of the combination of CAP_ALL and cap_test_all()  as in my most recent proposal above is actually that we can distuingish two interesting cases while parsing:

1. The capability bounding set is uninitialized, and thus capability_bounding_set is actually CAP_ALL
2. The user has previously configured the full capability bounding set, by listing really all known caps in CapabilityBoundingSet=. In this case capability_bounding_set will only have the bits set that actually exist, instead of really all.

Being able to distuingish these two is useful when deciding whether new settings should override what was set before (case 1 above) or should extend them (case 2 above).

(Of course, this all will eventually fall flat, as the 64th capability is defined, but in that case we can revisit things...)


Este commit adicionou 2 pequenos bugs corrigidos nos commits posteriores:
 - No arquivo helios_auth/models.py linha 90 (faltou importar o settings);
 - No arquivo server_ui/templates/base.html linha 24 (faltou remover as aspas duplas);
 - No arquivo helios/templates/election_questions.html linha 83 (por erro de atalho no teclado foi inserido inadivertidamente um trecho de código inválido);


@drewhk @rkuhn I think this should be standard practice.


Question: is this form preferred?

If this is not necessary for the commit, I would separate it, because it is larger than the actual change in the commit.


When applying this in my app, the original list item I am dragging (the from element), disappears after 2 drags. The "_css(cloneEl, 'display', 'none');" seems to be applied to the original item the second time.

The original code works well for me.


This is what keeps the buttons from having cruft appear when they are moused over. How in the world could your changes have removed the need for this style?


Keeping things where they belong (`initialAttributes`) means that we don't need to remember to do this whenever `Unfold` is used.


Typo in commit message: _It_ makes...


looks ok.


We should probably make this file global, like globals.tf and remove provider (region) re-definitions from everywhere else.


max-width was used to prevent overflow. You'll need both, perhaps.


Clirr is not enabled on this module. However, I might have break this API since this abstract class is not in the "internal" package.


Hi,

This exact same issue can also be found on:
https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/interfaces_bridge_edit.php#L434
https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/interfaces_bridge_edit.php#L444
https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/interfaces_bridge_edit.php#L465
https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/interfaces_bridge_edit.php#L476
https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/interfaces_bridge_edit.php#L487
https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/interfaces_bridge_edit.php#L523
https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/interfaces_groups_edit.php#L262

Not sure if code needs changes. So I don't feel 100% confident in changing.

Thanks :)


Hey Tiago,

nice that you have fixed that code. In future, please do not comment out the old code, but remove it, so that it doesn't clutter the working code. It also simplifies the diff view.
That's what we have revision control for. :-)


-rcX is never deployed to the forge.
the version bump in master is explicitly done to a version that would never be deployed.
(this was a request from @nibalizer )


Nitpick: So far in most of systemd's sources we check return values of syscalls with only checking whether they are negative or no, but not by explicitly comparing with -1... We should probably continue to do that here. i.e. write >= 0 rather than != -1...


Ok. Can you link me what you're downloading? I can take a look at it.


Please remove the test image `out0.png` from the repo.


:+1:, I'm going to tackle this in a separate PR/story.


superfluous comment :)


75+25 = 100. That's 100% width. Now where does the space for the button group come from? (I made a similar comment above)


On 11 January 2016 17:39:02 EET, Daniel Gustafsson <notifications@github.com> wrote:
>not `inner_locus` here?

Ah yes,  good catch.


#include <stdio.h>


ack though


okay. I hope we can then use that on every other module as well ?


yeah I read that on the wiki and was wondering if the queue was actually throwing Full for you guys. Are you guys regulating the ratio of packetcontroller loops and sketch loops? Maybe one possibility is that your control loop is queueing packets faster than the packet controller can pop them and the packet controller never gets the chance to send the encoder continuous request. Try a SyncedSketch with a ratio of >2?. Probably have to play with its arguments too.


ack


Tere,
Tegin

Head,
Ardo

On Mon, Jan 11, 2016 at 11:19 AM, Romil Rõbtšenkov <notifications@github.com
> wrote:

> @ardobirk <https://github.com/ardobirk> Ole hea tee repositooriumis pull
> request, siis saan arvestatuks lugeda.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ardobirk/1.kodutoo-II-ruhm/commit/54d741eb1cac0328cc98f3afb45240e682fb593e#commitcomment-15365968>
> .
>


copy ctor and assign operator and not needed in the Impl at all. Just swap impl_ pointers in the Pipe ctor and assign operator.


I'm not a big fan of this change. I feel like it doesn't improve the clarity of the code and handles some edge cases in a function which should simply return a path.

In the case of `Paypal` we don't care about stale data since the whole app is going to reload anyway. So we can ignore this case.
I think it would make sense to me that the code responsible for making the payment request would itself trigger the invalidation (not necessarily handle it but notify of a possible modification in the site data).

For instance this could be handled in `SecurePaymentForm.componentWillReceiveProps`, once `this.props.transaction.step.name === 'received-wpcom-response'`


was it not `=` instead of `==`?


suggest 'resumd' or 'isResumed' instead of 'unpaused'


better specify const, add padding


propose to extract name creation to the separate free function or method


const addr


hmm why is clirr not enabled? that looks like a bug. We need to enable it :) Indeed this broken an API. We need to decide if it's ok or not.


Fix for #19


Extremely cool!


yup.
as new modules are released, they are migrated to that pattern.


I think we should keep this in  because it is useful when you don't want to run DBConnection inside a pool, which seems to be what the moebius folks wants to do.


small note: I'd prefer getDocumentVersion instead of getDocVersion (to follow our practice of using full names in APIs).


This breaks the entry point here in Arch.

```
$ sshuttle
Traceback (most recent call last):
  File "/usr/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2388, in resolve
    return functools.reduce(getattr, self.attrs, module)
AttributeError: module 'sshuttle' has no attribute '__main__'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/sshuttle", line 9, in <module>
    load_entry_point('sshuttle==0.74', 'console_scripts', 'sshuttle')()
  File "/usr/lib/python3.5/site-packages/pkg_resources/__init__.py", line 568, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2720, in load_entry_point
    return ep.load()
  File "/usr/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2380, in load
    return self.resolve()
  File "/usr/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2390, in resolve
    raise ImportError(str(exc))
ImportError: module 'sshuttle' has no attribute '__main__'
```


missing passing "e" in parameter of LOGGER.Error


We may have lost this piece of it.  @lsm5 gave me a heads-up earlier today that we were hitting build errors here, and this cleared them up for me.


Haha, nah I'm never insulted by the changes. I take them as challenges,
really. If your code appears superior, then I take it as a learning
opportunity. If not, then I'll argue my side. Sometimes, I'm missing
something; sometimes, you are.

My goal is that everything that I made corrections for is understood with
the changes, so that the intent stands, even if the code doesn't. I was
just making sure that the reason why it was changed was understood, which I
mistakenly thought you hadn't at first, but I am okay with those changes
for now.

It can always be looked at sometime in the future, but a working custom
class is fine for now. This isn't a final product in the slightest, so if
it can do everything it sets out to do, namely follow Hearthstone's
unwritten rules, then it can start being fine-tuned. If I figure out a
better way to do it (I honestly thought my code was far too hacked together
this iteration) then I'll try again in the future.
On Jan 11, 2016 10:12 AM, "demilich1" <notifications@github.com> wrote:

> I now committed the working version including the case with the Haunted
> Creepers as a unit test.
>
> By the way, I really hope that I have not insulted you by this change. In
> some aspect your solution is even cleaner than mine, as using a
> custom.SomethingSpell class is a sign that the current system of Spells
> cannot map the card in question. However, for me Poison Seeds is quite a
> special case; this becomes even more evident when reading articles on the
> Hearthstone wiki or some other sites - and thus I prefer keeping the 'ugly'
> code inside a spell which is just used by one card in this specific case.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/webadict/metastone/commit/395dcb0fbf589f3e82f7c0804d95ebf0894ddf64#commitcomment-15373774>
> .
>


Return value should not be ignored


What is this statement doing exactly?


ack


Very good that you use named constants instead magic literal constants. But instead them better use settings object with configuration keys. For example:

```javascript
var settings = {
  sideSize: 4,
  borderPart: 0.125,
  fieldContainerId: field
};
```


ok, check latest version


const…


Correct me if I'm wrong but it appears that the whole point of the isPaused, unpaused, pauseLock machinery is to ensure that the listener callbacks happen only within beginWindow-endWindow timeframe. However, if this thread is at this point and we get an endWindow() call, the rest of the code below gets executed outside that timeframe. Is this not a problem ?


What's the "create" step this refers to? I'm a bit confused why this change is necessary. I only see the `SendInvite` form used in a single place. Thanks!


This could be a `switch`.


Is there a reason "jc" is bound to evil-avy-goto-char-2 instead of evil-avy-goto-char?
The latter is the one I would expect for "jump to char"


Good practice is a pure DOM, when you don't modify DOM tree and DOM elements. Instad this you can create own objects, and pass dom elements to methods of this objects or properties.


Strictly speaking, you don't need to use CodecRegistry to use OptionalCodec. Just create a codec and use it directly:

```java
OptionalCodec<String> codec = new OptionalCodec<>(TypeCodec.varchar());
Row row = ...;
Optional<String> s = row.get("some_string", codec);
````

Now if you want to register it, no problem:

```java
OptionalCodec<String> codec = new OptionalCodec<>(TypeCodec.varchar());
cluster.getConfiguration().getCodecRegistry().register(codec);
Row row = ...;
Optional<String> s = row.get("some_string", new TypeToken<Optional<String>>(){});
```

If you want to use OptionalCodec with and UDT, you first need to retrieve the UDT:

```java
UserType udt = cluster.getMetadata().getKeyspace("ks").getUserType("udt");
OptionalCodec<UserType> codec = new OptionalCodec<>(udt);
Row row = ...;
Optional<UserType> u = row.get("some_udt", codec);
```


I think the config, elastic and receiver prefixes for the imports are redundant


Of course :)


Please explain why set pin to sourcing state? It's external (for short lines even internal) pullup responsible for recharging the line.
TIA


Initial commit


Ok, although it seems you have a duplicated code block in writer.go (line 222 to 224).


Global variables is EVIL!


We could use a `move_iterator` here. (Unrelated to this PR, but it caught my eye. I'd put that in a different PR if we do it).


Looks like you're missing the "4.9" after "arm-linux-androideabi-".


Le label doit changer en fonction de la page : **Mon profil**…


label…


@puevigreven have you looked at other changesets in this file, that also check for existence of data?


Les boutons étant conditionnels, le label doit l'être aussi.


1. You need to move this code in function with well mean name. For example: `generateField`.
2. I can't see where you define `i` and `j` variables.


hmm do we really need this method to be protected instead of private()?


Thanks @gabrielle27! I have an odd habit of using whatever song is stuck in my head for commit messages.


Missing // NOLINT here.


Misisng // NOLINT here


missing @since annotations for protected methods (they're APIs)


double wp-content dir


Fix spacing here in comments.


I don't quite understand why you're calling abort on each write? And why we have to connect each write? Also I propose to add debug logging. E.g. `on connected`, `on error`, `on data written`, `on waiting`. Also please process the result of the `waitForBytesWritten`.


Fix spacing before //.


Nit-pick to be fixed post-merge, "null", not "nil"


Also you don't `go build init.go main.go`. Either call `go build` or `go run foo.go bar.go`


I don't think this method should return a leading "&". That should be added in CssSkinExtensionPlugin


2015 -> 2016


if provider is `None` ???


Hmm I wonder about docVersion vs using just "version"... This is important to decide as it becomes public.


vilain !
`is_update = username is not None`


no


Since this is essentially a revert, for the record the original code in the driver was

```
		return $this->GetOne($this->identitySQL);
```

Any particular reason for not reverting this as well (other than storing $this->lastInsertID) ?


Does not cost much to keep the existing method and just add a protected boolean isAccessible(DocumentReference documentReference, XWikiContext context) called by the first one.


@DavidWalz I haven't seen this before I updated the code with 7c13961. Do you want me to revert to previous values?


it makes sure the `pyprint/VERSION` gets distributed


I'd use String.format("...") here instead (with the "&" being in there)


ack


nom de variable: `redirect_view`


Also if we have a getDocumentVersionQueryString() then we should also have a getLanguageQueryString() too I guess, wdyt?


We also need to delete the `.default` queues (which incidentally have unconsumed messages).


Instead difficult if condition you can use function with good name that mean what condition do.


Need double space before //


Немного накладка вышла с русскими буквами в сообщении


Cool! It seems to work very well, just not with invalid instruction. I've attached a MWE.
I didn't have too much time to investigate, but it seems related to the ds->retry flag.

[test.zip](https://github.com/radare/radare2/files/86037/test.zip)


For the "&", I just followed some existing behavior (see https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/plugin/skinx/AbstractSkinExtensionPlugin.java#L293-293).

I have picked "docVersion" to be quite sure this parameter name won't be used by any resource in an extension. However it's a bit long.


Learn switch/case control structure.


I think this collection of defaults in one place only makes sense if each of the default values is used in more than one place—otherwise it makes more sense to keep it with the thing it applies to, i.e. to inline them in this method.


Same here. Not a big fan of XWiki 1.0 style method naming.


@choquette33 - This is something of a losing battle that you're fighting here. We could rework the logic to something like "if the answer _includes_ 'yes' or 'no'", but there is a small risk of false positives (like if someone says "yes, but only bandages"). Whaddaya think?


Missing space before ||


Yes, this is definitely true.


Doing it.


Should be private IMO.


@ccx-testerbot runtests master


Doing it. Yes, it could be private.


definitely a good idea, since it might be common for job tasks and jobs to have "_" in their names.


as we no longer do the expensive non-qs sort this is no longer necessary.

we can just get `first()` and return based on whether that exists


Thank you for the request. It has been added to the queue (id: 144). To see the progress you can go to the [status](http://ccextractor.canihavesome.coffee/test/144) page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.


I Need to remove this, seems like my commit messed up again


No worries! I didn't either until your PR. :)


Pretty cool!


It doesn't use html anymore.


SQS behaves differently than *MQ in many respects. It's important to be able to test it. As you can see, it uses different queues in dev.


I'm reviewing all of them. Thanks!


I don't know as much about the overall context.  Can you put in a comment explaining why the above code is no longer needed?


`getLanguageQueryString()`: why not.
`getLanguageQueryString()`: it's a public API, I cannot change its name.


yes. one change set looks for View Encounters in role_privilege.(line 4224)  how will it affect this code?


While you are looking at this, is this issue also relevant?
UTF-16 and UTF-32 JSON support: https://github.com/OpenDataServices/cove/issues/79


At the top of the [releases page](http://pandoc.org/releases.html) the version number 1.16.0.1 is missing. I'm wondering if it's manually added to that page? Would it be useful to include the release dates here?


@Alberto97 Yes, surnia has this issue.


@dtenenba I didn't realize SQS was that much different than *MQ implementations.  Agreed it's important to test, but do we want automated tests and developers sending untold traffic to our SQS?


tst


should be timeOut right?


On second thought, I'd prefer to leave the code as it is.
The way skyboxes are used can otherwise cause major problems with Boom's deep water hack. To make this work properly a lot more checks would have to be added to handle skyboxes above deep sectors.

R_FakeFlat currently contains nothing about portals, and I'm not even sure how portals above Boom deep water is being handled.


this should prob. be conditional on if there is an order-by clause.  linked hash sets can chew up memory pretty fast.  i like it overall tho.


Wollte nur GitHub Kommentare ausprobieren ;-)
Wann kommst du wieder?

Am 11. Januar 2016 16:47:29 MEZ, schrieb "Stimpson J. Katzwinkel" <notifications@github.com>:
>Wieso der ist doch gut!
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/Cutuchiqueno/kathaireo/commit/c9131ba537ec4caa53fc5b4ae188ef4a6663bfe9#commitcomment-15373084


Во-первых, удалять может только админ
Во-вторых, удалить самого себя нельзя

Ну и теперь есть отправка сообщений с ошибкой или об успешном удалении


>> I doubt that.
>
> Item 32: Use EnumSet instead of bit fields.

Well, an array of enums is not a bit field.

> I think so, and the same pattern is applied throughout the whole Java NIO API.
>
> Do you have a quick link to any particular class or interface?

Many methods in [Files](https://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html) use this pattern, even in an extended variant where not the enum class itself is the parameter type, but only interfaces that have enums implementing them (for extensibility).


Did you intentionally choose to do your sql differently from these others?


I just tried this out and it doesn't seem to work. I get the following message. "App Transport Security has blocked a cleartext HTTP (http://) resource load since it is insecure. Temporary exceptions can be configured via your app's Info.plist file.
 ... something went wrong: The resource could not be loaded because the App Transport Security policy requires the use of a secure connection."


ack


Don't we need to interpret a `null` group to consume from the `.default` queue?


Not sure if I check that case.. but if you take a close look to what Im removing is pretty much margins and the margins in the rows I'm doing it differently now.


`length` is `uint32_t`, the only possible value where condition is true is when `length` equals 0.


I think these documents have complex types in them. In particular I'm thinking `ObjectId` `bson.Binary` maybe an int etc.


The change was done already, see latest commits.


I am not sure how but you should completely remove your `id` and `secret`. Even from git logs. Perhaps a `rebase` would be helpful?


@caprenter That issue is primarily about JSON files, whereas this commit is w.r.t. the encodings of CSVs.


morgen.


Maybe I "clean up" a little too much :)

That's why I love code reviews xD


@gidili yeah, agreed


i had to chose <sql> because there is no way to insert the such these privilege


Want to add a separate line for yourself? Also, it's 2016 now :)


closes #19


ok, looks like this is documented in "Parental Reassignment", in the PR.


Be careful about leaving unused code. Its not very clean and it could complicate maintenance on the project.


needs more magic


INTEGRATION TESTING_2016-01-11 18:51:17


I check it on lines 151-154 above.


INTEGRATION TESTING_2016-01-11 18:51:19


Weird, I see no new [tag on your ngWYSIWG repo](https://github.com/psergus/ngWYSIWYG/tags). Are you sure you pushed it?


There should be a unit test for this (and for all methods), but this in particular looks risky.


Was going to ask a question, but it looks like my question was answered in the "Cloning" section of the PR.


please look into PR at https://github.com/openmrs/openmrs-core/pull/1660/files , i have made changes there. i considered few cases there which i missed!


Yeah, I missed that `localQueue` was a field and not a local variable. Never mind.


it's a kind of magic


This change to `PulseAudioGetStreamWriteAvailableBlock` was unrelated - have I got it the right way around?


This is actually handled in librbd.cc, RefreshParentRequest.cc, etc.


what about thread safety?


s/SpongAPI/SpongeAPI


"recieved" above is misspelled


Is this supposed to be `for i in range(1, m + 1)`?  Plugging in `i = 0` below gives you a zero denominator.


@chelmuth: Consider adding this to staging. @alex-ab suggested to submit this portion of the Muen AHCI/MSI workaround (13fadd5) for upstream inclusion.


Where will we most likely see the delimiter? In the Dagobah logs?  Do you think this is sufficient, or something more human understandable (like "%__NESTED_JOB_TASK__%")?


Alignments have been changed to replace Ns with gaps ("-"), the way the sequences appear in the XML. This is to make sure the strain matching on the basis of sequence identity works.


I also suggest to try 'codespell' tool to find common misspellings. It is what the tool says

```
./plugins/provisioners/puppet/provisioner/puppet.rb:62: doesnt  ==> doesn't
./plugins/communicators/winrm/communicator.rb:128: equivilant  ==> equivalent
./plugins/communicators/winrm/communicator.rb:152: equivilant  ==> equivalent
./plugins/commands/powershell/command.rb:58: succesfully  ==> successfully
./plugins/providers/virtualbox/action/clear_network_interfaces.rb:15: upto  ==> up to
./test/support/isolated_environment.rb:20: runing  ==> running
./test/unit/plugins/provisioners/salt/config_test.rb:36: dont  ==> don't
./test/unit/plugins/commands/global-status/command_test.rb:46: dont  ==> don't
./test/unit/plugins/providers/docker/config_test.rb:239: shouldnt  ==> shouldn't
./test/unit/plugins/synced_folders/rsync/synced_folder_test.rb:32: cant  ==> can't
./website/www/source/javascripts/less-1.3.0.min.js:9: substract  ==> subtract
./website/www/source/vmware/index.html.erb:380: Occassionally  ==> Occasionally
./website/www/source/vmware/reseller.html.md:30: Althought  ==> Although
./website/docs/source/javascripts/less-1.3.0.min.js:9: substract  ==> subtract
./website/docs/source/v2/vagrantfile/ssh_settings.html.md:72: paramter  ==> parameter
./website/docs/source/v2/other/environmental-variables.html.md:34: surpress  ==> suppress
./website/docs/source/v2/synced-folders/rsync.html.md:39: appropiate  ==> appropriate
./website/docs/source/v2/vmware/index.html.md:24: compatability  ==> compatibility
./lib/vagrant/box_collection.rb:145: doesnt  ==> doesn't
./lib/vagrant/capability_host.rb:8: inheritence  ==> inheritance
./lib/vagrant/config/loader.rb:127: upto  ==> up to
```


Actually, could you squash (fixup) this into the parent commit?


Can we use the same constant throughout, as opposed to 256 in one place, and UINT8_MAX in another one?


It may cause circular set issue. @Malathi seems we are using only getAssessmentEffectiveInstallment method from propertyservice, this can be moved locally or in this method place one of the method from installmentdao can be used. @Subhash please review once.


@huacnlee you should be able to see the author's name in the FROM field of the email.


Actually, it is important that we do not show `0` in a cell if there was no value for it in the input, to distinguish between cases where the value is `0` and where there is no such value.


TeamCity Civic Assembly :: Build backend + frontend [Build 148](http://54.229.176.143/tc/viewLog.html?buildId=409&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


I moved the EndCpuLoad call up here so it still runs if the streamCallback returns something other than `paContinue`.


Is it possible that Fail() be called multiple times? Each call will override SyncError. Is that intended?


This commit is redundant except for 8916/8939 targets.


node 0.10 is pretty old now, try upgrading your node or if that's not a possibility just upgrade your npm


Also TODO - I haven't checked whether not calling `mainloop_signal` here affects callback mode.


Because that connection is used for a Queue Purger that is used for the acceptance tests. Perhaps "Queue Purger for Acceptance Tests" instead?

I added that while tracking down the source of all the open connections to verify that's where they were coming from.


The test suite finished running the test files. Below is a summary of the test results:

| Report name | Tests passed |
| ----------- | ------------ |
| _Broken | **10/15** |
| _DVB | **4/5** |
| _DVD | **0/3** |
| _DVR-MS | 2/2 |
| _General | **6/24** |
| _Hauppage | **2/3** |
| _MP4 | 2/2 |
| _NoCC | **1/10** |
| _Teletext | **6/21** |
| _WTV | 13/13 |
| _XDS | **16/34** |
| _Options | **76/87** |
| _DTVCC | **11/14** |
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Please check the [results](http://ccextractor.canihavesome.coffee/reports/144) page, and verify those files. If you have a question about this report, please contact @canihavesomecoffee.


what are these? seems strange


saw approval from javajolt
at https://github.com/basho/riak-python-client/commit/6f169a7bd58fa0de3d8152c0239f34dde6ac2691


merging basho/riak-python-client/features/lrb/rts-667-796-ts-1.1 = 6f169a7b into borshop-integration-422-features/lrb/rts-667-796-ts-1.1


basho/riak-python-client/features/lrb/rts-667-796-ts-1.1 = 6f169a7b merged ok, testing candidate = 561a1dcd


here too


@rkuhn I agree with the sentiment, but I'd rather not allocate a new attribute for each invocation :)


s/Ok/OK

It's preferred to use all upper/lower-case for abbreviation.


As an aside - this classloader stuff is no longer needed - the SMLC doesn't use the context classloader when creating the proxy - per XD-2079.


Does this version already give accurate results for tests in Table B.1 from the paper? (except cases when all methods they tried fail).


Mach mal bitte ein Issue auf, wenn du einen Bug findest. Da kann derjenige, der das auch programmiert hat besser einpflegen. Ist besser als wenn man erstmal irgendwie was ändert. Das Feature ist eigentlich schon drin. Ich muss da nur noch bisschen Feintuning machen …


:+1: looks good!


This appears to be resolved.


I can also check if `Error()` is non-nil to know if the sync is successful or not. What value does this method add?


Why not simple: "Telnet"?

Console, File, Telnet ...


DId you actually mean to make changes to the Pathfinder-Neceros sheet?


Couldn't you define the destination by the name instead of the id? This works for me: ```-destination 'platform=iOS Simulator,name=iPhone 6'```.
Maybe I could even drop the platform, as it seems redundant, but didn't try.


Technically could be considered as our `DataView`.


Whoops -- never mind.


I think should check does orginal mapSateToProps function depends on ownProps here, since react-redux do some ｀[optimization](https://github.com/rackt/react-redux/blob/master/src%2Fcomponents%2Fconnect.js#L205-L207) for mapSateToProps which don't depends on ownProps.


Likewise our `MemoryDataView`


`MemoryDataContainer`?


You are technically right but I'd rather not change that list :)

That list uses uppercase and full official names, as in ISO-8859-1. In general you can always use lowercase and skip the [first] dash, as in koi8r or iso8859-1. But I don't want to list every possible alternative there.

Not sure what is best. Perhaps we should just mention the general shortening alternatives in the docs. IIRC you can also skip "ISO-" and just say "8859-1" but that doesn't apply to encodings starting with "CP".


I think the ``+``s shouldn't be here, since it doesn't seem to match MPB v0.4.0


This would still be the MessagePump instance that handles the main queue, so it seemed descriptive enough to me. If you had multiple instances, you'd be able to track the connections back to them via ip address.

I suppose we could try and grab the name of the secondary queue if it's enabled and include it in there too.


Openjdk 8 has version info like this:

    /usr/lib/jvm/java-8-openjdk/bin/java -version
    openjdk version "1.8.0_66"
    OpenJDK Runtime Environment (build 1.8.0_66-b17)
    OpenJDK 64-Bit Server VM (build 25.66-b17, mixed mode)


Done: 626a11073828b059b742a461d74223fd45c1962a

I couldn't get this to work without splitting things off into a separate file, but maybe wescheme-specific tests are best done in their own file anyway.


Ok, there is no extra line after if block start. I got confused with the way github was showing the diff. Ignore the comment.


Might as well follow the convention for go documenting: http://blog.golang.org/godoc-documenting-go-code
E.g.,
```
// Error returns an error summarizing all the errors in PodSyncResult.
```


*Tarea 1*
*<Nombre de tu grupo>  - Martha Patricia Lucero Pineda Corona**
***Desarrollo de aplicaciones web***
Practica de _HTML5_ y _CSS_.


TeamCity Civic Assembly :: Build backend + frontend [Build 148](http://54.229.176.143/tc/viewLog.html?buildId=409&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new); exit code 1 Build time: 00:05:25


Good point, so my reasoning translates to a value in the companion object of each GraphStage. WDYT?


`MinecartFurnace`.


There seems to be a performance hit, for which I have not investigated the reason, with the use of getOne compared with calling the sqlsrv functions


Yep, in 85d359e9cbde71d739fdd2da4e17d4862e66b542


`Human`.


duplicate of above.


I realise that, it's for CI and other users, not myself. Having CI upgrade NPM beforehand would work though.


👌👀👌👀👌👀👌👀👌👀 good chopsticks go౦ԁ cHopsticks👌 thats ✔ some good👌👌chopsticks right👌👌there👌👌👌 right✔there ✔✔if i do pick up those chopsticks my self 💯 i say so 💯 thats what im talking about right there right there (chorus: ʳᶦᵍʰᵗ ᵗʰᵉʳᵉ) mMMMMᎷМ💯 👌👌 👌НO0ОଠOOOOOОଠଠOoooᵒᵒᵒᵒᵒᵒᵒᵒᵒ👌 👌👌 👌 💯 👌 👀 👀 👀 👌👌Good chopsticks


"#offCanvas"ad>Menu</a>?


Yes. Good call. [`redux-form` does that](https://github.com/erikras/redux-form/blob/8cd3ce67473c2963aa949db62d6b1fe2267592f1/src/createHigherOrderComponent.js#L195-L216). Please implement this, @jsdmc. It's a matter of checking `.length` on the `mapStateToProps` and `mapDispatchToProps` functions.


> git commit -a is a bad idea

That command should default to be an alias for `rm -rf /`


`DispenseItemEvent` with a `BlockSnapshot` as a cause more than likely.


SyncronizedSet is deprecated in 2.11:

```
[warn] /Users/rob/proj/gt/geotrellis/spark/src/main/scala/geotrellis/spark/io/RDDFilter.scala:120: trait SynchronizedSet in package mutable is deprecated: Synchronization via traits is deprecated as it is inherently unreliable.  Consider java.util.concurrent.ConcurrentHashMap[A,Unit] as an alternative.
[warn]         val tiles = new mutable.HashSet[(Int, Int)] with mutable.SynchronizedSet[(Int, Int)]
```

We should move to using something else.


Nice one brilliant, have merged into my own repo :)


If easy to do, please re-add the `0` in all places except in the table cell itself (for example, in the tooltip values of the statistics it does not make sense to remove it).

Or should it be like this for consistency?


Fixed


Sorry, I meant with `render=True` serialization works differently and late template loading doesn't work.


Now that I can live with :)


Checkmarx scan results 11 Jan 2016 17:11 UTC +00:00

High
Medium
Low
Info

New
0
4
33
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

ad030f7b673e3ef26e01d1ede8d18e7229e0908c	@macxil


@naisanza No, changing those values in /usbkey/config won't result in anything being updated. We've discussed a little bit and I believe that most of those "FOO_root_pw" vars are throwback cruft: not used by anything. Originally I think those passwords were for ssh'ing into the SDC core zones (e.g. vmapi, imgapi, ...) as the 'root' user. For years, however, sshd has been disabled in the SDC core zones. Instead zlogin from the GZ is used to login to those zones, for which a root passwd isn't applicable.

https://smartos.org/bugview/TOOLS-544 is an open ticket to add the ability for an operator to reset an account password via "sdc-useradm".


The PR link shouldn't have the query string: `?utf8=%E2%9C%93&q=is%3Apr`.


9f8ea4c2fae162d42131777c4a1df9f3a20bc5da @Freddyleon Freddyleon committed 12 days ago


Sorry - I see you did it in the super.


For #13


No backbone or require.js should be used.


The utf8 field is unnecessary, but the query is there to show closed (merged) PR's as well @SquidDev.


Prefer lodash in favor of underscore if using.


technically `TextColors`, no?


Hi I have tried to incorporate this in my project. Hence I am using timelineDay with resources in it. But when I use your code its not working, All went blank. Can you please tell me how to make it in timelineDay view?

Regards
Dina


Okay, will-do


Sans mettre à jour la var, au final l'autocmd se lançait mais il ne se passait rien vu que la var date_modif était pas actualisée


@jamesdabbs Let's go with your suggestion. I think its best to error on the side of easier UX for the masses.


Also update variance formula for average catch.


so confusing :disappointed:


Les autocmd avaient pas l'air de se mettre en place si on ouvrait un fichier existant, d'où l'ajout de BufEnter


Ack! This should probably be reverted. I didn't notice that the `obsoletes` part had been removed in that PR.


Відсортуй, будь ласка, за алфавітом, і вмісти кожен рядок в межі 80 символів.


With pleasure !


Whoops! I thought it was intentional. I'll change it back right away.


For noninteger `a` and negative `z`, this produces `ValueError: negative number cannot be raised to a fractional power`


The queue was not throwing Full for us. We'll try playing around with a Synced Sketch and see what we get


TeamCity Civic Assembly :: Build backend + frontend [Build 149](http://54.229.176.143/tc/viewLog.html?buildId=410&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


This fails to build since the `useradd` line is missing a `\` -- however, adding `VOLUME` below will auto-create both `/app` and `/app/uploads`, so I'm not sure I fully understand what the goal of these two lines is?


1722-HXAssistSPM (kbenne) - i386-Windows-7-VisualStudio-12: OK (2337 of 2373 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.48%25-yellow.svg)


@michaelklishin, I now get the part about lack of support for pipelining of the "nowait=False" synchronous methods. However, I am having a difficult time reconciling your two statements. Can you help me get a better handle on it? I tried to research "synchronous" in RabbitMQ's AMQP specification, but ended up without enhancing my understanding. When you say

> Other synchronous protocol methods must be responded to in the same order they were received on a channel

which "other synchronous protocol methods" are you referring to? (example?) How are those synchronous protocol methods different from the "nowait=False" synchronous methods?


Another missing `\` :wink:


Yes.  The PR that was merged 2 days ago should have been v19 of the
neceros sheet.  I used notepad++ recently used when I pasted changes to
my local repo.  ;-(
The plain pathfinder.html sheet was overwritten by v19 neceros html.  I
know, I know.
50 lashes.

On 1/11/2016 9:03 AM, Riley Dutton wrote:
>
> DId you actually mean to make changes to the Pathfinder-Neceros sheet?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vince-roll20/roll20-character-sheets/commit/d7bf8b0b7acab1b45a3eff71eafbeba5d5e4454b#commitcomment-15375125>.
>


I agree with this, maybe we could make a function that takes a numerical prefix argument and dispatch to the correct avy function (if evil-avy-goto-char does not do this already).

cc @justbur


Wena falta ver la ventana de partido también XD


This isn't stylistically consistent

```
const char *nvd_uri = URI_PREFIX;
```


Cool!


GitHub doesn't show this well, but I added a new line to the end of each of these two files


Pocketkine?


Looks good. We also have `update_app_identifier` as an action from fastlane which can help make these things pretty easy as we can change the bungle identifier on the fly as we build.....


It turns out that for `hyp1f1` (unlike, say, for `besselj`), it is no longer necessary to manually increase dps to guarantee convergence: see http://fredrik-j.blogspot.com/2010/01/accurate-hypergeometric-functions-for.html


ooo valya karyayii


Ooops, sorry :(


Are you going to add those stuff that exists in SpongeAPI but not in Bukkit API?


By adding @Service without Scope making it non-threadsafe and will surely break in concurrent environment due to the following class variable
```
        private SimpleDateFormat dateFormatter = new SimpleDateFormat("dd/MM/yyyy");
	private BasicProperty basicProperty;
	private Map<Installment, BigDecimal> installmentWiseDemand;
	private Map<Installment, BigDecimal> installmentWiseCollection;
	private Map<String, Date> installmentAndLatestCollDate;
	private Map<Installment, EgDemandDetails> installmentWisePenaltyDemandDetail;
```
If these class variables to be maintained then add @Scope to prototype


Not sure we need the **get_details** thing for the demo, if so, we need timer(0) hack to make it work !
and would be more interesting with the actual width and height of the widget (width and height methods on svg widget)


`item.FireworkEffect`


`data.type.ShrubType`


#Tarea 1#

##Universidad Tecnologica de Tecamac - Martha Patricia Lucero Pineda Corona##

###Desarrollo de Aplicaciones Web###

Practica de _HTML5_ y _CSS_


All I see is a spacing change here. What am I missing?


msvc doent like std::log(numberOfPoints):
```
[0m\home\openturns\distcheck\workdir\lib\src\Uncertainty\Distribution\Normal.cxx(257) : error C2668: 'std::log' : ambiguous call to overloaded function
        C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\math.h(120): could be 'double log(double)'
        C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\math.h(527): or       'float log(float)'
        C:\Program Files\Microsoft Visual Studio 10.0\VC\INCLUDE\math.h(575): or       'long double log(long double)'
        while trying to match the argument list '(const OT::UnsignedInteger)'
\home\openturns\distcheck\workdir\lib\src\Uncertainty\Distribution\Normal.cxx(257) : fatal error C1903: unable to recover from previous error(s); stopping compilation
NormalFactory.cxx
```


@syl20bnr I don't care if you change this. I just tried to pick reasonable defaults, but I don't have a strong opinion. To me the difference between char and char-2 is whether you are narrowing candidates by asdf... or the characters surrounding the point you want to jump to. I find the latter a little more natural but am open to either.


In the current implementation, `_getSortedTagMarks` returns a new array for every call, so unless that changes it should be fine. So I'll do the change.


Mentioned this at https://github.com/chocolatey/chocolatey-coreteampackages/issues/106


rightArmDev->close() is missing


`world.Location`


`data.manipulator.mutable.block.GrowthData`


Are you ok with the default transport setting (POST via sendBeacon or XHR on supported browsers)? If you'd prefer to always send these as GET requests, the following should be added

  `'transport': {'beacon': false, 'xhrpost': false, 'image': true},`


My initial idea was to provide a list for devs coming from Bukkit. It might be a great idea to add Sponge only stuff too, yes. Haven't thought about the exact scope of this yet, though ;)


`util.Rotation`


Oh and I think the dispatch thing is a waste of time. There's no sense to me in having to remember a prefix argument to get a slightly more efficient way of getting to a character, but that's just my opinion.


TeamCity Civic Assembly :: Build backend + frontend [Build 149](http://54.229.176.143/tc/viewLog.html?buildId=410&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests failed: 14 (1 new), passed: 121, ignored: 4 Build time: 00:07:52
### Failed tests
```
Media type tests: Should delete media type: <no details avaliable>

Document type tests: Should not create new document type if cancelled: <no details avaliable>

Media type tests: Should add new media type: <no details avaliable>

Media type tests: Should not change media type: <no details avaliable>

Media type tests: Should change media type: <no details avaliable>

Media type tests: Should not delete media type if cancel pressed: <no details avaliable>

User Management: Should submit a form for user creation: <no details avaliable>

Basic Events CRUD Actions: Should Create an Event: <no details avaliable>

Basic Events CRUD Actions: Should Edit an Event: <no details avaliable>

Basic Events CRUD Actions: Should Delete an Event: <no details avaliable>

Organization tests: Should not create new organization if cancelled: <no details avaliable>

##### there are 4 more failed tests, see build details
```


@monkiibiz I don't have anything to do with the creation of that, I'm just a user who has been happy with how things were working, moved over to that fork when the whole mess went down, and have continued enjoying a perfectly working SickRage installation. A new name is being created in https://github.com/SickRage/sickrage-issues/issues/26, but one hasn't been decided on yet.

When I see others having major problems with the "original" here I try to help out by pointing them to where everyone moved to (while laughing at the continual screwups by @echel0n). It's _completely_ up to you whether you want to stick around with this version, but seeing as it's now a one man show that has majorly broken several times now...


**Code Quality - Nitpick**

Please remove unused code.


Is `json_encode` being used somewhere else here? If not, can we get a cleaner multiline `if`/`else` statement here?


Could you please update the help message as well? :)


`world.gen.type.BiomeTreeType`


Since the output of the `filter` function is a `function` that can be used with an Array's `filter` function, I think it would be reasonable to use a similar function definition to the one used for Array:

```ts
//lib.d.ts: 1130
filter(callbackfn: (value: T, index: number, array: T[]) => boolean, thisArg?: any): T[];
```

As `callbackfn` uses generics, I think it would be best to use generics here, ergo:

```ts
type MatchFunction<T> = (value: T) => boolean;
```


HAHAHA WHOOPS


and I had tried to just disable the video-tracking plugin on pre-2.4 OpenCV, but had apparently failed.


name.present? ? name : email


Here you repeat large parts of the code, which is not necessary.
Just do:
```
bool okEncArm;
if(part_arm=="left_arm") {
    okEncArm = encsLeftArm->...
} else if(part_arm=="right_arm") {
    okEncArm = encsRightArm-> ...
}
if(!okEncArm) {
    ERROR
} else {
    doStuff
}
```


if(part==...) is missing


It looks like the first char is lower case?


@dvv Vladimir, can you please make comments on the dev branch?  There's no point in entering into a discussion on an 0.96 commit  Let's discuss and fix current if needed.


This depreciation should have been noted in the change log.


This is a simple program that flashes a light on pin 17.


Again big code repetition


LGTM, @3XX0?
Before accepting a contribution from you, you need to sign and send us the [CLA](https://github.com/NVIDIA/nvidia-docker/blob/master/CLA).
Or, since it's a small enough change, we can author the fix ourself based on your bug report.


I disagree, we shouldn't say that configuration is now data. The `configuration` package is replaced by configurate for the most part.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Not that this shouldn't be merged but... ultimately there is a more fundamental problem here.  The **assignment-client** has not been equipped with a **PhysicsEngine** which means, when it is wearing its "scripted agent" hat, it can't offer to simulate the consequences of its actions.  The "usefulness" of a scripted agent is limited to scripted actions that are not governed by physics.  When one starts to change physical properties then the results will not only be non-physical, but they will be broken and undefined in certain situations: in particular when a user-interface has simulation ownership of the object being changed (I believe that position/velocity changes by the scripted agent will be rejected by the entity-server).

Also, since the scripted agent

We can imagine a scenario where the scripted agent process is fully equipped to perform the physics simulation near the object(s) that it is driving, however such a process would need to declare a "view" into the world so that it can store the physics properties of nearby objects and get updates from the entity-server when things change.  It would need to have capabilities that are closer to a full **interface-client** than an **assignment-client**.


Will this respond to the offline switch? I am a little concerned that this could trigger network requests in some cases.


LGTM


first-time contributors: 新的参与者


What is causing the requirement to depend on impl?


Duplicate, but should be retained.


`TextColor` and `TextStyle`.


Is this `@simd` over a codegen loop? If so, it shouldn't do anything.

The `@simd` loop should go on the inner most loop that does the arithmetic


True. But we should then instead state that it's still available as `ConfigurationNode`.


No.  This does nothing for the performance of mutable images on iOS.  It simply adds support for transforms (e.g. rotation and scale) on iOS mutable images graphics contexts.  This was necessary to allow the charts API to be drawn on mutable images properly.


Replaced by the `flow-math` library.


We don't normally document depreciation of private API unless we feel there's a good reason to believe it is used in the wild by a sensible number of projects.


Sure. I just got here via a standard blame procedure. How do I comment on the dev?


ack


frontend loading indicator

https://github.com/policycompass/policycompass/issues/73


No replacement.


Haha I'm sorry but tfw typos


comment here


actually, it should be arm-eabi-, arm-linux-androideabi- is for building the ROM not the kernel.


This aims upgrade scenarios and should (if I understand correctly) solve the migration of data from `SYSTEM` user's profile used on versions 0.13-0.15, to the current user profile location. We still have pending the issue of how is KA Lite going to be started, right?


LGTM


@lukegb


Yes, but it should be noted that our `Villager` is not a `Human` - Bukkit's `Villager` extends `NPC`.


Also part of issue #208


Tried playing with this patch..but the the hwdec for main10 hevc is not working:

[dxva2] No decoder device for codec found
[dxva2] Error creating the DXVA2 decoder

the ffmpeg already patched though:
https://goo.gl/Cb6GZh
https://goo.gl/yrzzTX


Part of issue #206


Part of Issue #206


`org.spongepowered.api.network.status.Favicon`


OH RIGHT! this thing is dumb.


Part of Issue #18 & #208


@TerryE Please reconsider the condition. Do we really forbid using DHT on pin 0? (I so far put it here)


LOL.


Just an FYI while I have your attention:

The code that will reject the scripted agent lives in EntityTree::updateEntityWithElement().  When the object's simulation is owned by InterfaceA and AgentB tries to edit certain properties (position and derivatives) those changes will be rejected because **simulationBlocked** will compute to **true**.


@cjwest


already did


The syntax is fine.  But why the or with cortex?  And the "arm" I presume should only match if the value starts with "arm", and in that case you should rather use arg_value.startswith("arm").

But generally, when doing anything but dead simple string matching, regular expression is usually the best way.

Anyway, the syntax look right, but I cannot judge if it exactly matches what you expect.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1517 of 1517 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hardcoded bait


*Intended feature


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1498 of 1498 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


For this event, you will want to listen for changes that happen to the selected inventory slot.  In the last week I made some improvements in this area in the engine,  you could probably use something like this:

```
@ReceiveEvent
public void onSelectedSlotChanged(OnChangedComponent event, EntityRef character, SelectedInventorySlotComponent selectedInventorySlotComponent) {
    // make sure this character is the local player
    if (CoreRegistry.get(LocalPlayer.class).getCharacterEntity().equals(character)) {
        // ... do other logic here with the selectedInventorySlotComponent.slot
    }
}
```


will this commit fix https://github.com/hexojs/hexo/issues/1705 ?


Probably want to limit this to the client side only like this:
```@RegisterSystem(RegisterMode.CLIENT)```


Does this introduce an ABI break for users that did not manually specify an alternate type for that type parameter? (and/or does it explain why I had issues getting 32-bit and 64-bit apps to talk to one another on Windows?)


*Undocumented intended feature


*Easteregg


Add:
```
Thread Safety: Not thread safe
```


Add: `Thread Safety: Not thread safe`


For a UI widget,  it does not need to be a system.  The class will get created by ```nuiManager.getHUD().addHUDElement("TooltipNameShow:TooltipNameShow")```.


I think we need to apply a Kummer transformation (DLMF 13.2.39) when the real part of `z` is negative. That's what Zhang and Jin do in the current specfun implementation: see https://github.com/tpudlik/scipy/blob/master/scipy/special/specfun/specfun.f, line 6080.


Ok, I can address this at post-merge phase or send rebase tomorrow.


Ok, not a problem.


These should get called in 'onClose' this just causes  them to get called twice.


this is probably overkill


:lollipop: for you, @stufkan !


Great news. Thanks for all your work!


Not sure if modules have access to System.currentTimeMillis().  Inject the ```Time``` system so that you could then call ```Time.getRealTimeInMs()```


Without really knowing about what this does in detail i wonder, if there might be one '='-Sign to much in line 50. Was this intended or might it be an editing-error?


Log?


And with this (and 968ce0f) nhentai is parsed by making use of their json api - which fixes #72 - nhentai cover images occasionally cannot be downloaded.


Switch to https the Wikipedia login


Nice!


Site updated continually.


arai ah ?


@Nuanda can you explain why this is needed?


sites should be filtered by institution only


I think it is best if we assume that whoever sets scissor, or viewport, restores it when done. Otherwise, we need to set these properties everywhere, all the time, which we do not do.

Using that line of "optimistic" thinking, setting scissor test at the bottom seems right to me.

But `clear` is not affected by the viewport setting, so there is no need to set viewport at the top.

Yes, there is no "right" answer here. Whatever you want is fine. : - )


why is it called "trim"? I don't see any trimming going on.


(If you need this still,  you will want to initialize the variable using the ```Time``` system possibly in the ```initialise()``` method)


I think this should be `false, false` -- the metadata checkpoint session doesn't need to open the metadata itself because it is given a handle to operate on.  Does that make sense?


I would have thought the same thing, but that was definitely not happening (onClose was not being called). Pretty easy to test, open any modal that closes itself via a positive action (file browser was the one I saw this behavior with), browse to a path and click OK, modal closes and the backdrop disappears. Then revert this change and do the same thing and the backdrop will still be there. Clicking on the backdrop will close the modal and trigger the `onClose` method.


perfect, thanks


Ад и погибель


if you step forward through inOperators (Rather than backward) I think you can get rid of the "trimAppend" call, and just construct new Function objects directly.


Can you explain how this addresses the problem that the code and long XXX comment it replaced addressed?  In particular, setting PYTHONPATH at *installation* time does nothing to set PYTHONPATH at *run* time.  But deleting the python2.7 executable in the virtualenv -- which, by the way, isn't a hard link on Linux, so I would be surprised if it were on OS X -- and replacing it by a symlink defeats the virtualenv's built-in assignment of sys.path inside Python.

Or, more generally: Can you explain what problem you solved, and how this solved it?  I can't figure that out from the commit message or the change itself.


again, perfectly fine to just hold this as an object. Pointer is not that much faster and definitely less safe.


@tarelli ok for the flag, yeah but should it propagate also for select / deselect and setGeometryType? I don't remember if that's the case now.


Thanks for the heads up!


там декоратор надо запилить "\@only_admin" по аналогии с "@tornado.web.authenticated"


Hi, 不知道为什么移除了Async相关的代码？如果考虑多线程的话，我推荐 [tomorrow](https://github.com/madisonmay/Tomorrow)库，非常便捷。


@gidili yes


It's not a very good reason: because if head is Empty() we trim it and return tail. But I agree the name would be better without the "trim" part, so I'll change it


ttt


I would write this as

```
for (auto& term: operators)
    result = ODB::Term...
```


@tafia Ok.


It is intended. == will return *true* when comparing 0 and null, while === will return *false*. See the [PHP docs](http://php.net/manual/de/types.comparisons.php) for more explations.


When you are ready, welcome pull your request~, and do not forget to rebase your code.


Think this should be just "registry"


I think there's a way to write

```
for (const auto& term: std::reverse(members))
   ...
```

or something similar.


It's being all the time a list of addresses, but it was wrongly named as `address`. Now I change it to make it explicit, as in a latter commit I will add support for the active address in `EncryptionKey`.


Oh and I just remembered the comment you had made about putting these functions in their own file. I'll do that too.


Yes Greg, something similar to the Web Standard Apps.


Как никак, но показывает борду


LGTM. Is there anywhere this is used that takes a long too?


Could be a wribg implemention of the equals method?


Да я заодно так проверку добавил, основной целью были flash-сообщения. Или уже есть декоратор?


more succinct would be

```
match ObjectDefinitionTermWithMetadata(*i)
  -| Member(name, depth) ->> { }
```

which will also throw an exception if it doesn't get a match. calling "getMember" doesn't check, and will segfault if it's something other than a member.


:+1: woot!


Hi don't know why isn't working. I'll try to replicate your use case and report back


TeamCity libpalaso :: palaso-precise64-libpalaso-2.6 Continuous [Build 2.6.1015.16b9473b080488a8b6a1b8348f3fb411e01fc193](http://build.palaso.org/viewLog.html?buildId=67797&buildTypeId=PalasoPrecise64v26Cont) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:25


Yeah.  I like where we're at structurally, but awkward names abound: inconsistency about `stage`, `connection`, and `client` is another.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.633.16b9473b080488a8b6a1b8348f3fb411e01fc193](http://build.palaso.org/viewLog.html?buildId=67798&buildTypeId=bt223) outcome was **FAILURE**
Summary: Compilation error: SIL.Windows.Forms\SIL.Windows.Forms.csproj (new) Build time: 00:01:25


@cmarcelo
The idea here is to allow users to just type `waf --target ArduCopter` for example, i.e., stuff that go into `bin`. As for the others, the 'destdir` must be in the argument of `--target`, e.g. `waf --target tests/test_vectors`.

It's a bit strange that waf uses option `--target` to reference task generators names, there may be some historical reason for that.


Ups, but you are right, the change to `uuids` as name happends in a latter commit. I'll remove it from here.


generally looks good. Just a few stylistic points on using cppml stuff...


If so, this should not break existent code. This may be assumed as optional feature.


I'm not seeing this section on my gh-pages branch?

At any rate, agree this should move out of the general sprite declaration section here to around line 4658 (just above this icons block). Can you move it (rather than delete it)?


this should be

```
o.x is 10 and o..x is 20 and o...x is 30
```

otherwise, the first two checks could fail, but as they are just expressions (not assertions), the test would still pass.


Other than the tower thing, LGTM.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.645.16b9473b080488a8b6a1b8348f3fb411e01fc193](http://build.palaso.org/viewLog.html?buildId=67799&buildTypeId=bt322) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:26


There is no implementation of the equals method in GlowBlock. It uses the one in Object.


Yes - that makes sense to me, I wasn't sure it always had a metadata available. I'll push that change.


this?
http://pastebin.com/s5vTQgvG


y u no gitignore


it is not, is it? :-) It is ValidateXmlFilesRuleProvider


Right now the SQS branch is just an experiment to see if it is more stable than *MQ/stomp.

If it proves to be worth pursuing then we can look into automation. If you google mock sqs there is a fake java implementation, not sure how good it is. Also it's very cheap so it may not be an issue.


space after ampersand (I'll fix this in the merge).


If I recall it correctly, Schema schema = schemaFactory.newSchema(schemaFile); will throw SAXException in case the connection is not valid.


space after ampersand


ohh you should then consider implementing one, HashMaps and Sets of plugins will break because of no "right" equals methods


LGTM, but would be good to add a test case for this.


You shouldn't need a constraint here; Map.empty ought to do.


We shouldn't be translating "selected", this is part of the option tag syntax


Awesome!

Sorry it took so long to reply :/

--
Chris Albon

e: chris.albon@gmail.com
t: @ChrisAlbon
w: chrisalbon.com

On Tuesday, November 24, 2015 at 1:38 PM, suntong wrote:

> Hi Chris,
> I just found your well-documented Python snippits series, and think it is very valuable, to me at least. So that's why I'm writing to comment on this code, which the one that brings me here.
> The last chart should be "the color determined by sex", but the result is not. If you want to fix it, please take a look at my updated version (https://gist.github.com/suntong/995e3c4e027e042287a4).
> Cheers
>
> —
> Reply to this email directly or view it on GitHub (https://github.com/chrisalbon/code_py/commit/fd68c1935532ecac9062c4d0487687fb77fad8b1#commitcomment-14599974).
>
>
>
>
>


Here is a useful resource that breaks down different retirement plan options - https://www.fidelity.com/viewpoints/retirement-plan-small-business


Same comment as above, don't translate "selected" in the below lines


@ezuk The ErgoDox from Indiegogo has bluetooth capabilities? backlight? I'm guessing not, but wanted to be sure.


I still don't understand why you add a _new_ event for this


working version that supported the old weibull output schema - a single table, hardcoded weibull distribution and comparison to exponential, one field per parameter


Do not translate "selected"


What are the blank lines in this initialization list for?


@shaun965 can you update the email text to be more specific since the action being taken is to specifically transfer the founder?

----

Hi `@name`,

You have been made a founder of the project `Project Name`

Thanks for using UC NeXt!


hey @math-u, sorry for the delay I've been meaning to get to this, will try and finish it up this week! Thanks :)


In working on #3374, I actually started to push the `SourceInfo` and `TileID` dependencies further inward, to `FileSource`:

```
virtual std::unique_ptr<FileRequest> requestTile(const SourceInfo&, const TileID&, float pixelRatio, Callback) = 0;
```

We'll definitely need to pass `TileID` through for offline, and we also need something that can satisfy both of the following requirements:

* Uniquely identifies a tileset
* Can be combined with `TileID` and pixel ratio to generate a tile URL

I was using `SourceInfo` for that, but if we are happy with never supporting host sharding, this could be a single URL template instead.


check.


It needs cheating cause it allows to change visuals in a fundamental way, and allows stuff similar to wall hacks in other genres.
For the same reason all Sun properties should be synced, too. I.e. when the game says it is night, then it should really be night for all players.


Not sure exactly why these are hard-coded like they are here and below, but this is just demo data, and shouldn't be translated.


where is the win here?


All I am suggesting is that you are commenting on a obsolete branch.  Please use dev.


No linefeed before '{' please


redundant `return;`


Ditto - do not translate "selected"


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (950 of 950 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.63%25-green.svg)


More "selected" translations to remove


Looks good. Let's consider using 401 (Unauthorized) and 404 (Forbidden) in the future when we start implementing features which require a valid user login session.


nope, arm-eabi is the 4.8 toolchain, arm-linux-androideabi- is the 4.9

this commit is correct


Right it is really important


There's a typo in the commit message. This fixes visionmedia/page.js#306. Not visionmedia/page.js#304


Fixed in

commit 5e3f4765a35bd494bb0861a654855394b14b5de3
Author: Nathaniel Kelso <nvkelso@gmail.com>
Date:   Mon Jan 11 10:11:13 2016 -0800

    restore tower label_placement styling


You don't have to (shouldn't) address root relative like this, it's hard to read (where does it actually go) and fragile. you can use `Table/TableView` see the requires :arrow_down:


This change looks unnecessary? it doesn't change anything except for new line and space.


use relatives in the current parent tree only.


Thanks, much appreciated!


redundant


Oh nice, wasn't aware, definitely MUCH better.


I have merged your pull request. Thanks for reminding us!


wauw kang


kangkangkang


Overall looks good and thanks for doing this (very tedious) work!  I made a few comments - mostly there is just one major issue that needs to be corrected in several places.  One other issue is that a couple of pages were removed in a recent commit, so please be sure to merge master up to your branch before sending a new pull request so that we can automatically merge if all looks good.  Thanks!