It may be also interesting to explain what happen in a few other cases, like:

- **Case 1**: I want a faster-than-realtime simulation, so I simply do:

```python
from morse.builder import *

robot = Morsy()

pose = Pose()
robot.append(pose)

env = Environment(...)
env.set_time_scale(accelerated_by = 20.0)
```

- **Case 2**: I need to copy my real IMU that spits data at 200Hz, so I simply do:

```python
from morse.builder import *

robot = Morsy()

pose = Pose()
pose.frequency(200)
robot.append(pose)

env = Environment(...)
```

Actually, it would be nice if those example would 'work well' (ie, have a predictable behaviour) out of the box.


Still doesn't solve the issue for invalid spreadsheets.
Excel still complains about invalid files, LibreOffice only shows an blank sheet.


merged


*fork


I tried this build, but ended up getting the rainbow pattern again. I'll look into it a bit more.


わかりました。

```cpp
DXLE_NOEXCEPT_IF_EXPR((l.x /= r))
```

する方向で行きましょう。ああ、またVSバグりそう。


add braces


@dterweij What do you mean by "OpenSourceLicense"


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1235](http://teamcity.monogame.net/viewLog.html?buildId=13995&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 583, ignored: 6 Build time: 00:21:27
### Failed tests
```
MonoGameTests.exe: MonoGame.Tests.Visual.ViewportTest.Affects_draw_origin: <no details avaliable>

```


Function mat_log can be provided by the user through Mat_LogInitFunc in which case it is implementation dependent and your added comment `/* Does not return, calls abort() */` does no longer hold. I'd propose to modify it to `/* Shall never return to the calling function */` and provide some new description to function mat_log.


Hell yeah


Partially. I mean reverts partially, aware fully am I ;)

It keeps the initialization to -1, so gcc doesn't complain.


Hi @ibelyaevjcvi , the pydocs look really nice! You should document how you generated these. Here is a live version of the docs rendered from GitHub: http://rawgit.com/Arabidopsis-Information-Portal/hrgrn_webservices/master/doc/api/subnetwork_by_locus/index.html


¿? Remove...


merge conflict


is it possible to combine protocol_handler_ related actions behind single `if` check?


Can do this for all the lookups here, inline them as statics, i considered this yes. The data will not move, just change visibility from module level to scope level, a good change probably.


2333333 谁知道以后会怎样 ╮(￣▽￣")╭


@Arthur2e5 还有就是 bot 如果能 access group message 也不会收到么？


Your welcome @colinmollenhour .


It was a test of a transition receiver but it is worthless now. I just forgot to remove, will do so.


@makoto26 here are new apis!!
1) How to make shortcut from url
2) How to fetch/create/update course registration
3) How to fetch featured courses
4) How to fetch wishlist courses
5) How to fetch/create/delete Course contents

see the docs! :)


Good to know, I will fix that.


It would be nice to also test using a valid ledger hash "ledger_hash".


IMO we should always point to a particular commit where we know everything works fine (as we've doing with the editor and the CartoDB.js submodule). I just merged a PR that broke something in `v4` and now examples are not working here :(

cc: @xavijam @viddo


Will do


ddddd


@akhayrutdinov  Are you sure these need to be set for every test in this class?


(suspect this will become clear further down)


And what is the purpose of storing temporary files inside `lib/private` dir anyway?


import should be in the header
Do not introduce reform_to_test
reform = allocations_familiales_imposables.build_reform(base.france_data_tax_benefit_system)


@kurtwalker, now, there is the only test in the class, thus I don't pay attention to it


Please try this at LTC also. I guess we lose one elo point, but I think we can trade that for 70 lines less code...


Ahh, I did not check the computations, but 3600 should have given away that it is somehow related to hours.

My compiler (`avr-gcc (GCC) 5.3.0`) compiles this and previous commit identically for the product I have (Turnigy 50W).


We may want to reconsider having the master recipe in _base longterm.  I won't hold up this merge but if we ever add _slave functionality having the master recipe in _base might be misplaced.


+1 for reverting this.  Looking forward to seeing this move forward under new leadership.


Not at the moment, here's a preview though ;D ![](https://i.imgur.com/INASFTe.jpg)


The override happens in two commits.

This commit just copies the file from the `curation_concerns` gem.

[This commit](https://github.com/WGBH/hydradam2/commit/d6257d0ca00af2abe8afe13ab6e0ece2c75a3387) makes the HydraDAM-specific changes.

Both commits are part of PR #46.


Nice. :)


any reason for there to be both `SQL_FORM` and `FORM_SQL`? should we keep the convention the same?


Better use `::File.file?(...)` ?


Yepp, it should be cleaned up.


Hi @davecarter & @nahuelsotelo !! Aquí tenéis la versión definitiva de la guía de estilo, aunque a lo mejor apuro unos minutos más para retocar alguna cosilla... ;)


This seems like a bug `https://github.com/gogo/protobuf/issues/107`


Commit message talks about parser settings, but it probably means this one, right?


I thought it would be an extra complication. If you think it's desirable to have this extra path, I can bring it back.


Those last two, loitering and responsiveness?


Yea, that makes more sense, I will change that.


Originally there was additional logic in the unwrap method, it wasn't cleaned up properly.


Hmm alright, one other way I had it was to check the endDate using similar code to the endDate code that is now but under the transition receive class. Is that better?


service


Not exactly. This check ensures there aren't other entries and exercises the deepequals method, whilst the check below tests the lookup positive and negative cases. All these test were directed by coverage.


Anton,

Here is the result of my last build of Traccar source code v3.2, using Netbeans 8.1, after I did modified the three java classes of  Kenji protocol.

-----------------------------------------------------------------------
BUILD SUCCESS
------------------------------------------------------------------------
Total time: 2:10.752s
Finished at: Mon Jan 25 12:46:59 CLT 2016
Final Memory: 53M/298M
------------------------------------------------------------------------

Thanks a lot for your kind support Anton !!!


It's not completely untested, Kingdom Hearts 2 works with this change and no existing hack :)


Copy and paste, will fix.


Very nice. One question: since you already added the script folder, could you add the boot.lua file so we can fix this?

https://github.com/VideahGams/LovePotion/issues/19

It would be as easy as putting the function there and calling it.


Pourquoi dans le constructeur de Layer tu rajoute une méthode d'initialisation ( InitLayer() ) à la fin ?


https://github.com/dimagi/commcare-hq/commit/7aad43d0d0f677405649b0d720e486d9b76dd8ea?w=1 in case anyone else is looking


I agree that it's convenient, but there's another use-case here, and that's still broken ;)
Consider building a noarch package. You don't want to specify `BUILD_DEPENDS = cross/python [..]`, because you're not cross-compiling (more importantly: you categorically don't _want_ to cross-compile for `noarch`)

The current code doesn't handle that gracefully. If modules with optional speedups are encountered and there's no cross-compiled Python around, the build will fail.
A better solution is having the buildprocess automatically disable speedups in that case, and keep the wheel pure-python. That's one of the reasons for the refactoring in my branch.

Same for setting `PIP`: if `cross/python` isn't compiled, you don't have a python-cc.mk. Using native/python's pip makes sense in that case, and should probably be the default.

The question is if can we consolidate both plans: use a cross-compiled Python when it exists, and if not, fallback to native Python and do only pure-python stuff. `spksrc.wheel.mk` would get more complex, but if we can pull it off, I think it's worth it.


Sigh, this is dump. Their stuff seems to be so fragile :/

But doesn't goimports take care of this?


Each setup already includes the service recipe?


Yup, that's the plan!


> the way I'd solve this would be to put the logic in Auth.prototype.authorise()

So the main reason I suggested putting it in getTimestamp was just that it seemed DRYer -- rather than having to put logic to check whether serverTimeOffset is null just before every use of getTimestamp (once in `authorise`, once in `createTokenRequest`, and having to remember to do it if we use getTimestamp anywhere else in the future), I was thinking we could just do it once, something like
```js
Auth.prototype.getTimestamp = function(callback) {
	callback = callback || noop;
	if(this.rest.serverTimeOffset === null) {
		/* This will result in Rest#serverTimeOffset getting set for future use */
		rest.time(function(err, time) {
			if(err) {callback(err); return;}
			return time;
		});
	}
	return Date.now() + this.rest.serverTimeOffset;
};
```
But: it's your PR, and you should feel free to do it in the way you judge is best :)

The decision is ultimately @paddybyers's - and in any case, you may want to wait for him to chip in on whether he's happy with the basic idea of the change before doing any more work on it.


This will work; use what makes you feel comfortable.  Though consider making it flatter.

    {
        "podcast": {
            "title": "Joe Rogan Experience",
            "name": "Joe Rogan Experience",
            "imageURL": "http://static.libsyn.com/p/assets/0/8/6/8/08688b90de11f9ab/JREiTunesImage.jpg"
        },

        "episode": {
            "title": "#646 - Dr. Dan Engle & Aubrey Marcus",
            "pubDate": "Tue, 12 May 2015",
            "mediaURL": "http://traffic.libsyn.com/joeroganexp/p646.mp3"
        },

        "clip": {
            "title": "Study shows that believing your work is 'good exercise' makes you healthier",
            "startTime": "9381",
            "endTime": "9507",
            "duration": "126"
        }
    }

In the template, you could write `{{ clip.endTime }}` instead of `{{ podcast.episode.clip.endTime}}`. There is no referential loss with this simpler structure.


I've done some research since first using `unicode_literals` (there is blobdb code that uses it), and now I'm on the fence as to whether it's a good practice or not. Would be interesting to have others read http://python-future.org/unicode_literals.html and make a decision together about whether we want to use it or not.

Notably: "To avoid confusion, we recommend using `unicode_literals` everywhere across a code-base or not at all, instead of turning on for only some modules."


Thanks Man those lines of code solved the problem


No, it's impossible becaise will broke logic. See 6b8bb48e5bf4f62e77fb5a39f5a6e075767340b0


See 6b8bb48e5bf4f62e77fb5a39f5a6e075767340b0


not sure. Want and have are struts containing a pointer, and I don't think the pointer will point to the same empty ps map, I think we will have copies of the empty ps map.  Will test.


Since the test isn't explicitly about native evaluation, I think it should work in both cases.  So, there may be a real bug that a failed configuration is surfacing here.


Day 4 assignment


This will be annoying with the provisioner automatic updates. When running with the chef-client in the run list, we want the environments to auto-upgrade nightly to the latest nightly build, and we need the upgrade recipe in the run list.


This gets changed back in a different commit.

At WGBH, we only plan on having 1 technical metadata file (e.g. either FITS or EXIFTOOL, but not both). That is why I changed it from `:fits` to `:techincal_metadata`.

But this gets changed back to `:fits` in a later PR #57, because IU needs to accommodate multiple technical metadata files at the same time. Plus, we are pulling them out into their own separate modules, so it makes more sense to be specific about which type of metadata the module supports.


I'm brewing a healthy hatred at Xcode for inserting unnecessary `-> Void`s when autocompleting blocks. I usually try to remove.  But as far as the argument, I like keeping the type declaration. I know the compiler would infer the correct type regardless, but I'm not sure it would be obvious to human eyes.


Yeah there were a lot of break changes. Goimports doesn't handle named
import paths I think.

On Mon, Jan 25, 2016, 07:54 Jonathan Boulle <notifications@github.com>
wrote:

> Sigh, this is dump. Their stuff seems to be so fragile :/
>
> But doesn't goimports take care of this?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gyuho/etcd/commit/a65ab93c57a1979564ad445cbcef325f3a608cb2#commitcomment-15653077>
> .
>
--
Sincerely,
Gyu-Ho Lee


This was an existing test case.  It's merging two edge metadata with a common key.


Two edge metadata with disjoint keys.


break will never called, no need here


不會。
我追到這裏來是因爲你的 fffbot 不支持……


We'll talk about this more when we cover Sass in class, but what's the reasoning behind these variables here?


Using a subdirectory like that is what I had intended, so that the libglvnd headers would follow the same pattern as the GL and EGL headers. Vendor libraries would include `<glvnd/libglxabi.h>`, just like they would include `<GL/gl.h>` for OpenGL, `<EGL/egl.h>` for EGL, and so on.

Also, libglxabi.h itself includes the GLdispatch header as `"glvnd/GLdispatch.h"`, so using `<prefix>/include/glvnd` as your include search path would break anything that tries to use it.


不支持啥


Then, I'd rather have an explicit test for there being no other entries.

If you want coverage of the deepequals method that should be done in `TestCountersDeepEquals`.


do you happen to know why?


Where is this $tablet-breakpoint defined?


Created #101 to fix this


where is this $desktop-breakpoint defined?


Ok, so let's rename it to that.


Done!


That's correct. What's the best to way to add myself in the log as comitter? Currently, I'm rebasing a commit  before merging it into master. For the docs branch I cherry-pick commit. The last method should do the trick.


Pet peeve: Using the auto-generated comment format, but leaving stuff in there that's empty. Better just to remove the blank stuff.


What does this div class = container give me that the parent element doesn't? Would be nice to reduce here...


This makes me die a little inside.


That sounds like a more explanatory name


@kurtwalker, the data in CSV file is not correct -- aggregation numbers do not match sums from fact_table. The goal of the test is to verify handling invalid roles, but not computations.

The are two options: neglect precise data and force the test to always use the same routines (native evaluation) or enrich CSV file with missing data. I'm following the first, as it is simplier


Yes, thanks :) I figured that out like 2 minutes after I pushed this live...


Great addition, without this feature I wasn't able to create a discoverable REST API using this library.
The `getLinks()` method would have to be added to the `SerializerInterface` too, and it should probably get a ({@inheritdoc}) doc comment like the other methods.


Yes.  Alternatively, you can also add something like:

MyModel.es.search('value').extra({'size': 100})


grrrrrrrrr


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 226](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=712&buildTypeId=XbimEssentials_XbimEssentials) is now running


Shouldn't these use htmlspecialchars() ?


should be a shell problem.
bash over here...


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 226](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=712&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:00


Thank you! Tested both portals and search functionality is back online.


Sure. `Asset` in this case is the name of the "work" I had created, using the code generator `rails generate curation_concerns:work Asset`.

This generator creates several boilerplate files, including the views for displaying the `Asset` objects in search result pages. The view partial for this was saved to `./app/views/curation_concerns/assets/_asset.html.erb`.

However, there was an update in the `curation_concerns` gem that changed where the views were expected to be. The `curation_concerns` gem no longer looked for the view partial in the `./app/views/curation_concerns/` directory, but rather just the `./app/views/` directory. So basically, that commit just gets rid of the intermediary directory `./app/views/curation_concerns`, and moves all the content up one level.

I've run into this type of bug before, where you have code that was created by a generator, but then an update happens to the gem that breaks the previously generated code. It's annoying, but its a hard problem to prevent. The real solution would be to make sure that CurationConcerns has a robust update script to catch (or fix) these types of errors. But nobody is working on that right now.


Is this supposed to be `data_criteria`, as opposed to `source_data_criteria`? @dehall


yes. this shift is a bug (that these changes caught, which wasnt the failure I was looking for). -q had no argument.


`N` should be changed to `poolSize`.


I wasn't quite sure if I should do it there or not, but I'm going to put in that check in all of the classes to be uniform. I was at a meeting last night when I pushed that, so I just removed the offensive code and pushed it to stabalize the build, knowing I would be going in today and fixing the rest of it.

Kaleb Stumbaugh

Ball State University

Computer Science, 2016

kcstumbaugh@bsu.edu;

________________________________
From: Paul Gestwicki <notifications@github.com>
Sent: Monday, January 25, 2016 6:48 AM
To: doctor-g/social-startup-game
Cc: Stumbaugh, Kaleb
Subject: Re: [social-startup-game] Removed logging from ScriptKiddieEventAttack to sabalize build. (09e025f)

@KalebStumbaugh<https://github.com/KalebStumbaugh> Unit tests will fail when trying to access SimGame.game because it is uninitialized--there's no Platform instance. You can prevent this from causing trouble in the tests by putting a guard around the log, as I have in ... another event class I think, I cannot remember which. It looks like this:

if (SimGame.game != null) {
  SimGame.game.plat.log().info(...);
}

-
Reply to this email directly or view it on GitHub<https://github.com/doctor-g/social-startup-game/commit/09e025fad86022fbd82a193b8606a7be48aadc7d#commitcomment-15647663>.


prefer to use `poolSize` instead of 500 in the comment.


> In the chain, there has to be at least 2 levels

I suggest making it configurable with default option set to `2`.

> where at least one of those has to be a function call.

Yes.

> just x.y would not be affected, even if both x and y are function calls (i.e. x().y())

Would depend on the config.


@benjello Not sure that it should be since it imports the specific reform that is in the if __main__ section as a default input variable. But ok if you want to be an absolute pep8ist. But for me it would also mean that you should define all the default values just after the imports. I think it is the bas option.

> Do not introduce reform_to_test

Why ? It allows to change only the import instead of the import and the xxx.build_reform()

(Bon c'est du petit détail et je pinaille, ferme la PR si t'es pas convaincu :) )


I added this so that I can see more precisely where the intermittent failures are coming from.


I don't like the fact that you use the `instance()`. Why not to use cached value in the `transport_manager_`? With your approach you're creating singleton object even if it wasn't created yet.


One thing I am confused about, your test here seems reads as if a language has only a single mime-type associate with it. Is this true? My reading of the code was different. That's why I have the two levels of maps.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 135](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=713&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


TeamCity pull requests :: netty-tcnative [Build 43](https://garage.netty.io/teamcity/viewLog.html?buildId=5046&buildTypeId=pulls_netty_tcnative&guest=1) is now running


I can take this out and add a few more echo's where I think the problem areas might be (external servers are unavailable, usually packer) to be less intrusive. WDYT?


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 135](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=713&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Compilation error: Xbim.COBie\Xbim.COBie.csproj; compilation error: Xbim.COBieLiteUK.Client\Xbim.COBieLiteUK.Client.csproj Build time: 00:00:55


This commit message has nothing to do with the content of the commit. What's going on?


I do not understand why this scenario fails, as the other two do not. This scenario was migrated as a straight copy from `test-end-to-end-docker`. It fails here as it never is able to connect to `healthz`


TeamCity pull requests :: netty-tcnative [Build 43](https://garage.netty.io/teamcity/viewLog.html?buildId=5046&buildTypeId=pulls_netty_tcnative&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:50


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12609](https://teamcity.mesosphere.io/viewLog.html?buildId=112028&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:26


:+1: I'll probably pull this into my repo at some point


Ok I see. It's a bit odd to have Rails randomly upgrading to 4.1.6 in this commit though - if you can't run `bundle update` then how did it change? But in general I can see how it's hard to structure these commits in a consistent way. What about doing all the gem version changes in a single commit (so one mega commit with Gemfile/Gemfile.lock/slices.gemspec changes) and then further separate commits as you make the changes required for each gem upgrade. So it would end up like this:

```
* Update rails/mongoid/devise/etc gems
* Update mongoid config for new version
* Add `mongoid-observers` (same commit as https://github.com/withassociates/slices/commit/0bd3d2c05cebcba6f3fcb1ade4d8ed452ce92c24 - this isn't a gem update so can live separately I think (I assume `bundle update` runs ok without this gem))
* Update rspec config for new version
* Update capybara config for new version
* Update devise config for new version

That way at least everything is consistent (even if the gem is "broken" for a while, until the update-y commits have been done). It didn't shouldn't be too tricky to do the git munging - I'll happily do it if you like (you know I love this stuff...).

Maybe I've labouring this too much. I just think it would be nice to have a clean upgrade trail - I can imagine we and others will have to go back through this in the future to see what happened.


J'ai pas vu que l'on était dans le __main__ pour l'import
D'ailleurs on peut virer complètement le main mais cela est pratique en interactif
Ne pas introduire de variable qui ne sert à rien qu'à surcharger le code.


This way to get the docker image is pretty awkward. Why not put the docker image name into some env var directly from marathon.json? It would be much more direct.


Changed for mobile Update


I'll try to dig into it.


@AGritsevich, can you, please, double check the possibility? At least for me it looks that there should be no problem. There is removal of the observers. I see no problem in removing all of them at once.


Looks like a better name.


Christoph,

the server needs to wait for all the processes to start. So I modified lines 622-625 (in ubuntu it did not work without it). Will commit later today

 ```
while True:
        try:
            c = ipyparallel.Client()
            if len(c) < ncpus:
                sys.stdout.write(".")
                sys.stdout.flush()
                raise ipyparallel.error.TimeoutError
            c.close()
            break
        except (IOError, ipyparallel.error.TimeoutError):
            sys.stdout.write(".")
            sys.stdout.flush()
            time.sleep(1)
```


@sgillies I am undecided -0 on versioning myself, but wanted to hint not to use MUST. In OData we use some min/max version mojo combined with policies like ignore not yet understood "vocabulary" inside the keys ... to offer generic interoperability and sqlite also has this concept quite nicely in place. But stability (for a proven thing like GeoJSON) would be far better, if possible IMO at least.


@franticpsyx I have created a mockup on what I think the subscriptions section for a simple product should look like. It's based on how the variations section looks. I thought keeping the interface similar would help keep it clear and easy to understand. Also allow the user to save the subscription options without needing to save the whole product. What do you think?

https://cloudup.com/ii08EwTqJP0


Hey @Pierstoval I'm curious why the bundle tests are not here anymore. Is the good practice now to make all tests under the tests directory? If yes we should also remove the Tests directory from the bundle generator tool!


love the changes your making!


:fireworks: :star2: :stars:


这个地方多余了


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1237](http://teamcity.monogame.net/viewLog.html?buildId=14003&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


r+


These changes are great, but let's try to keep changes to such different files in different commits.


我移到了devDependencies


saw approval from jedmccaleb
at https://github.com/stellar/stellar-core/commit/07772fcff2dc8aaca505dbcc92092460c03f10ea


merging stellar/stellar-core/dm/update-xdrpp = 07772fcf into auto


stellar/stellar-core/dm/update-xdrpp = 07772fcf merged ok, testing candidate = 8c2d9885


We are doing the computation over one simulated second (``self._nb_call == self._frequency <=> self._nb_call * self._time_period == 1``). It allows to approach better frequencies which are not a pure fraction.


需要吧react放到stage之前


hmm, didn't read the article yet but that's interesting. happy to decide not to (I think we would all agree that python 3 is a long way off so I imagine we wouldn't get to the "everywhere" state anytime soon).

I have noticed that it can introduce unexpected bugs, for example, in some functions that explicitly require non-unicode strings like `csv` delimiters...


love the new artboard!


initial commit


@franticpsyx I forgot the "Add Option" button.

Here is the updated mockup. https://cloudup.com/izsM1W_Aoqf


Fix for issue found here
https://trello.com/c/cRedNhfe/972-ux-user-requests-missing-template-form-1

@ghislaineguerin @alex-deaconu


TeamCity Gitversioner :: Build [Build 13](https://tc.phome.cz/viewLog.html?buildId=42&buildTypeId=Gitversioner_Build) is now running


Ouvre un ticket poru ne pas oublier.


> Quickly googling, apparently in MingW the function is `inet_pton4`
> instead. I guess we should put that in a MingW specific #ifdef.

Alternatively, the use of getnameinfo() seems to be encouraged.


加入对jsx文件的解析


thx, man.


TeamCity Gitversioner :: Build [Build master-1.0.1-5-ge6169c9](https://tc.phome.cz/viewLog.html?buildId=42&buildTypeId=Gitversioner_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:39


@evanweaver thanks for pulling these builds together so quick! we are ready to go ahead and release


Specifically we're talking about "lookup" here, not syntax for invocation. `{{blog.post}}` would be an invocation of a contextual component on the property `post` when `blog` is yielded. `{{blog/post}}` would not lookup a component since there is no dash. `{{blog-post}}` would lookup a component.

Fwiw, core notes probably isn't a good spot to ask for clarification on an item.


```printf hello world;``` 单行代码高亮

```
printf hello world;
```


Looks good.


Nein, nein nicht so. So lauft es nicht hier...


I see, thanks for the explanation. I came across this as I was doing the packaging work for Debian, and given the usual pattern is to have the subdir in the pkg-config's cflag I thought it wasn't intentional :-)
 Dropped.


ERROR: Name 'Asdadadada_VERY_LONG_LINE' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.


ERROR: Utility classes should not have a public or default constructor.


ERROR: Name 'fincorrectUtilsClass' must match pattern '^[A-Z][_a-zA-Z0-9]*$'.


ERROR: [ClassNamingConventions] Class names should begin with an uppercase character
http://pmd.sourceforge.net/pmd-5.2.3/pmd-java/rules/java/naming.html#ClassNamingConventions


ERROR: [MethodNamingConventions] Method names should not contain underscores
http://pmd.sourceforge.net/pmd-5.2.3/pmd-java/rules/java/naming.html#MethodNamingConventions


Hi Imayoda
No reason, this is a bug! I will update, thank you.


Is that what the "not allowing to replace content id definition" error means?


I never looked at get{I,V}out(), so I did not know they were smaller integers.

I think casting them (i.e. `uint32_t P = (uint32_t)getIout() * (uint32_t)getVout();`) would be more readable, but I see that splitting the operations is common throughout the codebase, so fine by me.


This should rather be upgraded in the parent https://github.com/hawkular/hawkular-parent-pom/blob/master/pom.xml#L260 should it not?


Should we also add `status => :200`


Manged in parent already https://github.com/hawkular/hawkular-parent-pom/blob/master/pom.xml#L373-L377


If you do not use ‘MUST’ then it is perfectly possible to produce a json with a pair labeled ‘version’ where the value refers to, say, the version of the object described, etc.

That would be a bit silly. Just like one would state that in order to produce a valid geo json one MUST use such and such coordinate system.

Dw.


Because we use `python-future` you can simply use:
```python
Python 2.7.11 (default, Jan 12 2016, 10:33:51)
[GCC 5.2.1 20151028] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import html.parser
>>> html.parser.HTMLParser
<class HTMLParser.HTMLParser at 0x7f3394fc56d0>
```


Vai su Google+


Nice, I like the API on this.


Thanks @ramirezd42. Looks good, I'll pull it in. :+1:


I think my current position is "don't use `unicode_literals`," but I've been too lazy to go back and change code that I previously wrote that uses it.


May be add wrapper?


`urllib.unquote` is not available in Python3, you should use urllib.parse here. See [this cheatsheet](http://python-future.org/compatible_idioms.html#urllib-module) for using it :+1:


Any chance for a "patch" of code for me to use on my version? I don't know if you have any other patches in your code that might conflict with mine. So I'm just asking for the Slack integration.


`pad.regex` is not imported here


You're right, but the bundle generator is here to generate a bundle! Indeed the good practice is to move all tests to the eponym directory, but generating a bundle means that you would create something "standalone", so tests should be in the bundle's directory in case you put the bundle to github as an open-source project.
If @symfony guys have another idea of this concept, they may share it /cc @fabpot @tobion @stof


Great idea :+1:


TeamCity Gitversioner :: Build [Build 14](https://tc.phome.cz/viewLog.html?buildId=43&buildTypeId=Gitversioner_Build) is now running


ERROR: Name 'Asdadadada_VERY_LONG_LINE' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.


Alright. Could you comment the code accordingly?


TeamCity Gitversioner :: Build [Build master-1.0.1-5-ge6169c9](https://tc.phome.cz/viewLog.html?buildId=43&buildTypeId=Gitversioner_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:18


TeamCity Gitversioner :: Build [Build 15](https://tc.phome.cz/viewLog.html?buildId=44&buildTypeId=Gitversioner_Build) is now running


Aha! This looks relevant to my interests. Was this change made with the collections stuff in mind, or is it just coincidentally convenient?


TeamCity Gitversioner :: Build [Build Refactorings-1.0.1-9-gd796be5](https://tc.phome.cz/viewLog.html?buildId=44&buildTypeId=Gitversioner_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:21


Very good idea with moving emoji switch to separate component. I wanted to do that but didn't have time.


Missing ending parenthesis.


Is the motivation behind this to prevent re-assignment of these fields?


The comment is actually incorrect. I'm also still not decided on whether we should have the sync marks or not (probably not).


In general it's better to use python3 when testing, since this is the main platform to support for us. So print statements should be in the new form `print("test")` instead of `print "test"` with the corresponding `from __future__` import.

However we don't need any prints here, so please remove them and add a debug log if you think it's useful.


TeamCity Gitversioner :: Build [Build 16](https://tc.phome.cz/viewLog.html?buildId=45&buildTypeId=Gitversioner_Build) is now running


TeamCity Gitversioner :: Build [Build master-1.0.1-5-ge6169c9](https://tc.phome.cz/viewLog.html?buildId=45&buildTypeId=Gitversioner_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:17


112331505_SurfaceHeightRange (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (2056 of 2056 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


By the way, @AGaliuzov, @LuxoftAKutsan why we are not using `SPtr` here?


I don't see a need for creating the method `get_user`. Also the name of the method is  `get_user` but the method is returning only the user_id. You can just replace the method `get_user` at this point with `JsonWebToken.decode(token)["user_id"]`. Finally, you don't need to need `user_id = get_user(token)` in the condition. You can just assign `JsonWebToken.decode(token)["user_id"]` to @current_user(which should be renamed to something like `@current_user_id`)


FYI, the cheatsheet has a pretty demotivational start there for urllib:

> urllib is the hardest module to use from Python 2/3 compatible code. You may like to use Requests (http://python-requests.org) instead.

I don't think we should use requests for this as the usage here is pretty simple.


TeamCity Gitversioner :: Build [Build 17](https://tc.phome.cz/viewLog.html?buildId=46&buildTypeId=Gitversioner_Build) is now running


lol, didn't even notice this. will change


You should always remove commented out code.


TeamCity Gitversioner :: Build [Build Refactorings-1.0.1-9-gd796be5](https://tc.phome.cz/viewLog.html?buildId=46&buildTypeId=Gitversioner_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:19


TeamCity Gitversioner :: Build [Build 18](https://tc.phome.cz/viewLog.html?buildId=47&buildTypeId=Gitversioner_Build) is now running


Has vtolfollower_fsm_control.c been changed so it does not sit at low altitude+1.5m for 10s when RTH is triggered?


An early return would reduce the indentation depth a bit:

```
if (!_devices_matches)
  return
```

Another idea would be to introduce a private `_gen_device_xml` function that takes `xml`. `entry`, and `node` as arguments. In my opinion, this would make the code easier to understand.


TeamCity Gitversioner :: Build [Build Refactorings-1.0.1-9-gd796be5](https://tc.phome.cz/viewLog.html?buildId=47&buildTypeId=Gitversioner_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:19


TeamCity Gitversioner :: Build [Build 19](https://tc.phome.cz/viewLog.html?buildId=48&buildTypeId=Gitversioner_Build) is now running


TeamCity Gitversioner :: Build [Build pull/2/merge-1.0.1-10-g3e9c49f](https://tc.phome.cz/viewLog.html?buildId=48&buildTypeId=Gitversioner_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:23


Hello, and sorry for taking that long to answer back to you.

This is my personal fork of the project and I wouldn't suggest to use it.

The story of this fix is actually that AWS is broken in `0.39.0` so I had to proceed with this fix. The original cocoapods team rejected my pull request.

This version of AWS is very old and is not supported anymore. I would suggest you update to ASW2.0, but it has API breaking changes. In case you can not, then monkey patch with this version of cocoa pods https://github.com/hexahedron/MSM_Cocoapods_Specs which is what I personally use until I move to ASW2.x

in your Podfile add

     source 'https://github.com/CocoaPods/Specs.git'
     source 'https://github.com/hexahedron/MSM_Cocoapods_Specs.git'

and instead load the pod like this

     pod 'MSM_AWSiOSSDK/Runtime', :inhibit_warnings => true

@rk-yen I couldn't go with 1.7.2 because the number refers to the project's release tag there is no tag 1.7.2 in AWS.


Yes, and to allow these methods to be overridden by subclasses. E.g. with graph tests one could have an overloaded method `GraphSession session()`.


May be just `return QString::fromUtf8(utf8_str.c_str()).toStdWString()` ?


:+1: on the approach you took in verifying the token. Creating a Token model solved a real security issue here.


Only responsiveness, loiteringDelay is needed for Dwell transition.


@SimonWoolf Yes, like I said earlier, your solution had to become asynchronous; you're passing a callback to `getTimestamp()`. That's a totally different function than something that returns a value that can be checked by an expression such as `token.expires > this.getTimestamp()`. So in any case, `Auth.prototype.authorise()` needs its control flow changed. As it is currently, `getTimestamp()` is used  in two locations - authorise and create token, and both pieces of code will have to be changed as well. I shouldn't have a problem implementing this.

I see now what you mean, but I will wait for @paddybyers's input like you said.


could remove the last `[]`.


Are you referring to merging the `retu /=` statements in both of the `#if` cases?

I do not really see how both cases of the `#if` are suppose to give the same results, but maybe that is why there is a warning in the generic case.


The locking is not necessary nor explicit closing of the channel. All you need is close the Selector and have NIO take care of the rest (i.e., deregistering and closing channels etc.)


achso klar, man kann natürlich auch den Zentroid nehmen.


Awesome: Nice use of DRY methodology on the switch. Try to investigate the use of multi-dimensional arrays at you leisure.


NitPick: Please, kindly find time to go through this link by clicking on the image
Basically, the screenshot says it all you don't have to always vertical whitespace as it here currently.
[<img width="1074" alt="screen shot 2016-01-25 at 5 23 49 pm" src="https://cloud.githubusercontent.com/assets/7859083/12556925/a4671100-c388-11e5-9091-cc20cc885308.png">](https://google.github.io/styleguide/javaguide.html#s4.6.1-vertical-whitespace)


This looks good to me! Weird that this was here?


TeamCity Gitversioner :: Build [Build 20](https://tc.phome.cz/viewLog.html?buildId=49&buildTypeId=Gitversioner_Build) is now running


Assuming the row_size is not defined in the scope (which will happen if the value is not passed trough the template) and the "fixed_row_size" is set to false (and no images) it will pass this condition and set it to 3. It's a bit irrelevant in this scenario because there's no images to be rendered (I think).
If you then add one, it will again accept this condition because there's no value passed as size. And this is where it's wrong, because it should only pass the next condition (where the size is bigger than the length of the image array which is 1).
I think if I keep parseInt($scope.ionGalleryRowSize) || ionGalleryConfig.row_size on the function call of the controller, it will work as expected because there will be a int defined.
It's been a long day, so I might be wrong on the way I'm seeing this :)


When a querySelector doesn't find an element, the result isn't `undefined`, it's `null`.


OK I get it. I'm not sure it'll get that much more complex. Let's start using a default pip and override it in python-cc.mk if needed. If the file is present it'll automatically use the correct PIP, if not the default PIP is used.
Same for some kind of cross-compile flag, we can add `CROSS_COMPILE_WHEELS?=1` in python-cc.mk, it'll get evaluated and checked. ENV will then need to be cleaned if the value isn't 1.

I'll update the branch with those changes this evening.

On a side note, I think `--no-use-wheel` should be used, we want to make the wheels ourselves in most cases and not download what pip think is good for us or we might end up downloading some x86_64 wheels from index...


TeamCity Gitversioner :: Build [Build Refactorings-1.0.1-9-gd796be5](https://tc.phome.cz/viewLog.html?buildId=49&buildTypeId=Gitversioner_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:35


TeamCity Gitversioner :: Build [Build 21](https://tc.phome.cz/viewLog.html?buildId=50&buildTypeId=Gitversioner_Build) is now running


Also, I'd think we'd be using `this.ref*` for this


TeamCity Gitversioner :: Build [Build Refactorings-1.0.1-9-gd796be5](https://tc.phome.cz/viewLog.html?buildId=50&buildTypeId=Gitversioner_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:18


Test


@rosswalk  We'll need to do some testing on this function to make sure it works properly. We likely only want to target timelogs from the current day rather than all of them. Also use parentheses to wrap the inner query.


angular.extend will only update the properties that are on the scope object copied. So if it's not defined, it will keep the default value of 3


Glad to be usefull, I'm having a hard time adapting deauth code to plain arduino ide method (with no esp timers), can't wait to see your implementation.
In the meanwhile I attract your attention to this commit new method.. https://github.com/willemwouters/esp8266-injection-example/commit/739bddb30ba47880aa397b999727971bf272c93d

thank you again


Thank you for that job, but
sectionHeaderItemViewType != convertView.getTag()
isn't working because int and Object types are incomparable


This example shows how to use `ref`, and not have to trust document.querySelector to exist: https://facebook.github.io/react/docs/more-about-refs.html#a-complete-example


Why not add the images to the repo? Why have an external dependency?


May be `QString::fromUTF8(path)`?


**Code Quality - Nitpick**

There should be a newline space between line 1 and 2


@NealJMD can you look at this, please? By caching data we slash our db requests. This is a first sketch, so if you're happy with it, i'll iterate on it a little.


I would create `getExpireTime()` method which calculate expireTime based on `endDate` or returns `NEVER_EXPIRE` (constant value)[https://developers.google.com/android/reference/com/google/android/gms/location/Geofence#NEVER_EXPIRE]


Are we just handing over the keys at this point to anyone who will drive this project?


interesting, will make a note to follow up on that when we need to support archived/deleted forms


fixed


For security reasons, it makes sense to decode a token with a server provided algorithm as against one stored in the token header. Check out (https://auth0.com/blog/2015/03/31/critical-vulnerabilities-in-json-web-token-libraries/)[this] for more info.


**Code Quality - Nitpick**

According to PSR-2, there should be a newline space between namespace and your imports `use`


I see this magic string not the first time.
Amye be extrect with a undestandable naming?


BTW, you should set your email address in your git client to match the one on github. Otherwise your changes appear to have been commited by @invalid-email-address. See [this article](https://help.github.com/articles/setting-your-email-in-git/)


Your lines use spaces instead of tabs.


ref : #13


> is that required?

Probably not. I guess that editors, loaders and the embedded Lua readline will handle it properly. But if you start to concatenate files it can be a pain.


mkdir -p $build_dir


find the number of procs

don't hard code this.


cmake $build_dir/..


no need.


check if Makefile is here.


I think the function can be static.
Can you add a small doxygen comment to explain what "expansion" and "pitch modifier" is ?
It's obvious when reading function body but I'm not sure one can understand them while looking at the name only.


why is the api.depends removed?


mixing spaces and tabs here.


Logic in that if statement should be in for example `getExpireTime()` function. It would be much cleaner to see `.setExpirationDuration(getExpireTime())`


NitPick: Generally when declaring constants, it is better to use enum in place of classes.

Here are few links for you to go through
[Stackoverflow](http://stackoverflow.com/questions/9067769/java-enum-or-class-with-few-constants-which-one-is-advantageous)
[Oracle-doc](http://docs.oracle.com/javase/1.5.0/docs/guide/language/enums.html)


LGTM


(fixed! ignore me!)


I feel some of your controller actions do not need this method(eg create action).


FYI, there is still an occurrence of product_type_id being =6 in the includes/functions/extra_functions file in one of the new functions created somewhere in this repo.

BTW, looking at how this can be incorporated as an add-on to EP4.  Revision 4.0.32 will have some notifier actions that can be used to introduce/incorporate the additional code that has been written here.  When/if I have some time I see some other minor things that can be improved upon (example when inserting items that have an _id and are expected to be a number, they should be cast as an integer (int) or should use $db->bindVars function to force the data to be an integer.  At the moment, anything could be in the original datafile and that information will be processed regardless of numeric, text, etc...

Still not sure I see the value of the additional "deletion" status (10) as compared to the standard 9, but perhaps there is something there of value... :) Looks good though otherwise.


Boom :boom:. TDD for the win.


the better way `&data[0]`.
Also Is't okey to call `write` with NUll/0?


Is it valid coffeescript? Will result be a string?


I meant getaddrinfo().


:smile:


I'll amend the commit and add one anyway. Found out that the C language standard mandates this but couldn't find anything for Lua.


I see that the deprecation warning has been removed from the page for the `_ttl` field; should I understand that to mean that the deprecation has been reversed?


Can you remove the `== null`.


Spaces... ?


Indeed, it prints the username correctly but it got lost of in a long stream of `printf's` from debugging unicorn. My bad!


you could but in this example we're also splitting the file into a chuck that is loaded only when the user navigates to `/about`


I see 4 the same methods?
May be extract to the one?


Yeah, I just noticed that. It's because I copied and pasted for some of the setup details


Nice ! I was sure it was no more needed :-)


This query belong to the User model. Also refactor this query to make a single call to the db as against 2 or 3 called calls currently been made.


Cool


Typo: jshit.


Not all your action method need to call this method. Please refactor.


I note all your remarks concerning the documentation. I need to rework on it as I fixed the frequency issue. Moreover, turning vsync to 'OFF' offers some interesting alternative. The difficulty at this point is that is hard to choose a default configuration, because I have no way to make sure it really helps in the general way (and not make the situation worse).

Otherwise, to guess about your scenario.

Scenario 1 may work if you have a 'enough-powerful' computer. But without syncer, you have a risk to miss some data. If the computer is not powerful-enough, you will get pose value at a lower-frequency.

Scenario 2 will just give you pose data at 60Hz. Through, now that frequency stuff is fixed, it is easy to automatically rise the fps at the right level (in this case 200 for example) and start internal_syncer. The only question is what do you with other sensors / actuators. Do we are running them at the maximum frequency ? Or do we keep them at default / configured frequency (i.e 60 Hz). What do we do if user force a fps < 200 (stupid user, kill him?)) ?


NPE incoming. Please verify that not null before trying to invoke .toLowerCase()
Another solution could be to use `equalsIgnoreCase` instead.


Awesome: Nice work.


Remove spaces inside brackets.


@whyrusleeping why is this allowed?


There should be a Push option somewhere in a list of Actions. (the opposite
action to pull, which you did originally).

You'll likely need to *commit* your existing changes, then *push. *

This might be helpful:
https://guides.github.com/activities/hello-world/#commit

On Mon, Jan 25, 2016 at 9:08 AM, David Johnson <notifications@github.com>
wrote:

> Hmmm. The only change I made was removing the ::. I uploaded the
> change to the server. Do I have to push them to the public? How do I
> do that?
>
> David
>
> Quoting Derek Braid <notifications@github.com>:
>
> > Hmm, do you have local changes on your machine (uploaded to the
> > server) which hasn't been pushed to the public repo?
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/DeBraid/puck/commit/de1909d3ae22fdb1bf805fae188504f44e1c6632#commitcomment-15649408
>
>
>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DeBraid/puck/commit/de1909d3ae22fdb1bf805fae188504f44e1c6632#commitcomment-15650240>
> .
>


Example ping output:
![image](https://cloud.githubusercontent.com/assets/1998970/12557530/2415d59a-c383-11e5-9249-c58412a4e6c0.png)


Is this a fix for a bug you ran into?


I agree to the licences GNU Affero v. 3  or any later version

a link to the license would be nice


My take on `doublereal` is this: It's a useless typedef, and shouldn't be used in any new code, but I'm not sure it's worth the churn of changing it in the existing code, especially in a piecemeal manner like this. If we're going to do it, I would do it en masse.

One reason I haven't done that is because I am somewhat anticipating that we may eventually want to support automatic differentiation, in which case many of the instances of `double` and `doublereal` will need to be converted into a templated type, in which case replacing `doublereal` with `double` now would be a waste of effort.


Darn trailing whitespace


@vlj You mean to make both mandates_expansion and get_pitch_modifier to static member functions, right? Coming from a C and assembly background, C++ is a bit confusing at times


Not used yet


Please remove the composer.lock file. This is a package, so it's not need.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1237](http://teamcity.monogame.net/viewLog.html?buildId=14003&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:33:09


I don't think that a `project` is a valid type for `triggers`. I got this error when running this YAML locally:

```
jenkins_jobs.errors.JenkinsJobsException: Unknown entry point or macro 'project' for component type: 'trigger'.
```


I hope you don't mind that I went ahead and created the PR for this: https://github.com/tobscure/json-api/pull/79


seems like you forgot to update `compiler_vendor` section in config


Yeah, even though Linux wheels don't exist on PyPI yet, those will come eventually. There's no way to tell pip to not to download wheels from PyPI, but only download source files afaik.

So we'd need to  remove those cross-compiled wheels from requirements, and adjust the installers wheel install command?
If you're basing off of my branch (right?), that means that python-wheel.mk should probably drop the wheels directly into `$(STAGING_INSTALL_PREFIX)/share/wheelhouse/` on [L35](https://github.com/SynoCommunity/spksrc/compare/master...Dr-Bean:wheel_refactor?expand=1#diff-c95dfcd1d9ff0ebea64695b4633e43a5R35).


Yeah it's because the UserInfo alias used to point to \Concrete\Core\User\UserInfo but now points elsewhere. In general whenever you want to type hint against a core class that has an alias, you should use the original core class. (This is something we have absolutely done incorrectly in the core, and should clean up.)

So

    use UserInfo;

becomes

   use Concrete\Core\User\UserInfo;


Спасибо!:)


Why do we call the software adhocracy3? maybe we will have other versions.


I don't find this super readable. Can you add a comment. I'm not sure what "a" is doing. I always have lots of questions when it comes to lamda().


Great idea!


don't know how it spells better. the full stack of software is the full stack, including low-level high-frequency sensor / actuator, contrary to high-level software, which get a high-level / low-frequency information sensing / actuating information.


I see.. Having the core as a good example would definitely help. This also broke an add-on by Antti, pretty sure it's not the only one.


This is a newer version of https://github.com/vuntz/crowbar-openstack/commit/2488791676c5812d77527c1500648ea1a66784f6#commitcomment-15607081 - what was the rationale for the changes?  I'll continue our unfinished discussion over there for now.


-1 = unknown = unlimited


Very nice. So unmapped properties are unchanged.


But now it doesn't conform to the cargo docs http://doc.crates.io/manifest.html

They need to be updated too?


Could this property be optional and default to null / empty?


ack


qMax？


the test uses a different data source with native turned on?


Note that `transform` will currently stomp on the map if both are specified.


I'd s/starting/continuing/ as we started growing a year ago.


We should name the fields with a unique name relating to it's contents.

Ex.
bottom_content_1


@Deprecated should specify the release and also recommend an alternative.


The label field should correlate to the name.


Woo! Except I am still having trouble pushing changes to webhook... More
investigation today after a long hiatus, but I may have a few questions for
you later if that's ok.

Hope you're doing really well -- we love the exhibit boards, and really all
the work you've done for us : )

Best,
Kris

On Sun, Jan 10, 2016 at 5:08 PM, Steve Sunderland <notifications@github.com>
wrote:

> Check you out! [image: :+1:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/KrisWSO/WSO/commit/99f959966f6fe69797dd21ce10fa3190ce1b9fc6#commitcomment-15362494>
> .
>

--
Kris Williams
Data Analyst
Water Systems Optimization, Inc
www.wso.us

290 Division St., Suite 311, San Francisco, CA 94103
Cell: 585.298.3655
Email: k <http://goog_2007057986>ris.williams@wsoglobal.com


@artsmc this commit introduces a bug. If the user has never passed in `customButtons` as a function, this is going to cause a continue complaint in the console about the `buttons()` function not existing.

I've been running master lately and noticed this in my app this morning.

I think the easiest solution would likely be to check for `customButtons` existence before trying to execute the function but you may have a better idea!


Awesome, thanks. I wasn't sure about the ins & outs of how to organize this code; your patch looks good.


Could be, but note that the consumer never sees this directly. This is the relevant piece here:
https://github.com/SamGraber/TypeScript-Angular-Utilities/commit/8337d8c73257ae30b7fa793567001420e661b3ab#diff-76aa87c0886e65c2cb83451bc2d5709cR37


The label's should be capitalized unless there is a specific reason for them to be lower cased.


I really doubt anybody besides me wants it, but this does help editing
init for example, and it's more like a learning tool for the newbies
but I guess the code got a little big and complex.. no one have said a
word about the other pull requests and I have trouble guessing which
branches are free to use, so I'll be closing some of them and I'll
focus on fixes,

I have 2 here:
http://www.murga-linux.com/puppy/viewtopic.php?p=883851#883851


Isn't this something that can be determined from the portletId? (which I guess is really a portletInstanceKey)


@someara, shouldn't this change have also been done to the `package "iptables"` at the top of `iptables::disabled`?


Add line break to separate between block level elements.


Would it make sense to use PrincipalThreadLocal instead to avoid adding a dependency with javax.servlet?


Given that only `transform` OR `map` is used... What do you think about dynamic typing? i.e., if the param is a function, call it to transform. If it is an object, assume it is a map and map the object? This is almost exactly how lodash behaves and is very *javascripty* for better and / or worse.


Some parts of the documentation is now obsolete : Look for `ToSingleFromPrefab`.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/104672657


You could combine this into `if Post.create(post_params)...`


Use a gem, there is many for pnotify


HTML attributes should be wrapped in double quotes.


This line breaks my deployment (see #105)


Please remove this line. As I understand the [upgrade guide](http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-4-1-to-rails-4-2#error-handling-in-transaction-callbacks), this will become relevant for the next rails version. If we add this line now, we won't see the deprecation warnings if we use ``after_rollback`` or ``after_commit``!


Line 60 is dead code.


Is this line ending OK in .php? It's marked in red on GitHub web, and I would expect a comment to end in --> instead.


I don't know, is it? :D


bash on OS X as well.  But see my later checkin -- I already had code in SConscript.mightyboard to do the correct quoting once it detected any WSP in the parameter.  So, the ultimate change was to just put spaces after the commas.  (Which was my initial knee-jerk reaction to do, but I figured I'd leave your style of no spaces intact.)


Can you make the commit message explain why each part of the colocation needs a location constraint?  IIUC it's because as you said in https://github.com/vuntz/crowbar-openstack/commit/2488791676c5812d77527c1500648ea1a66784f6#commitcomment-15607081 we start the fs primitive before the service, in order to prepare the filesystem for use?


Awesome: Nice work


That could be cool


Done.


Remove bootstrap naming, this is not bootstrap


Did some reading. I think I need to do a 'Sync' in the Windows app.
Can do when I get home tonight.

David

Quoting Derek Braid <notifications@github.com>:

> There should be a Push option somewhere in a list of Actions. (the opposite
> action to pull, which you did originally).
>
> You'll likely need to *commit* your existing changes, then *push. *
>
> This might be helpful:
> https://guides.github.com/activities/hello-world/#commit
>
> On Mon, Jan 25, 2016 at 9:08 AM, David Johnson <notifications@github.com>
> wrote:
>
>> Hmmm. The only change I made was removing the ::. I uploaded the
>> change to the server. Do I have to push them to the public? How do I
>> do that?
>>
>> David
>>
>> Quoting Derek Braid <notifications@github.com>:
>>
>> > Hmm, do you have local changes on your machine (uploaded to the
>> > server) which hasn't been pushed to the public repo?
>> >
>> > ---
>> > Reply to this email directly or view it on GitHub:
>> >
>> https://github.com/DeBraid/puck/commit/de1909d3ae22fdb1bf805fae188504f44e1c6632#commitcomment-15649408
>>
>>
>>
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/DeBraid/puck/commit/de1909d3ae22fdb1bf805fae188504f44e1c6632#commitcomment-15650240>
>> .
>>
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/DeBraid/puck/commit/de1909d3ae22fdb1bf805fae188504f44e1c6632#commitcomment-15654640


`filepath.Separator` is a constant. Thus it would be better to make them also constants.


I figured `map` was a good property name for the object mapper anyway


Same for this! Please remove, otherwise we won't see a deprecation warning.


What's the naming scheme supposed to be?  I just used that name since it's used in all the transaction task tests and the set session task test.


"this." should not be here


@chrisseto I created an async generator from scratch for my own edification. Then switched to use agent. Nifty! Also very helpful for me to more fully understand async generators. I committed both so if there is any advantage to the from scratch it's in the repo.

  Thanks, Tom


Nice use of lodash map on object... :grinning:


I think the new version is https://github.com/vuntz/crowbar-openstack/commit/9b05c3030d9b18e5bafa807aa1c1120bd5e005e7 - right?


This is why I like working in utilities. Because anything you do here is a perfect candidate for TDD


Well, except they are *both* objects because transform has toServer / fromServer...


These look a bit big to me.
Could we make the <h4> to <p> and <p> to <small> ?


Where is this from?


Also, why is setCustomizablePortletInstance() a public method if it's only invoked from here. Shouldn't it be a private or protected method?
Alternatively, chouldn't this value be obtained at runtime?


> Scenario 1 may work if you have a 'enough-powerful' computer. But without syncer, you have a risk to miss some data. If the computer is not powerful-enough, you will get pose value at a lower-frequency.

Then, if we can know that we are not fast enough, can we send a warning
to the user: 'You have requested a simulation frequency of 1200Hz: 60Hz
(base frequency) X 20 (speed multiplier). MORSE can not reach this speed
(currently running at ~83Hz). Consider setting the base frequency
(env.set_base_frequency) or the speed (env.set_simulation_speed) to
lower values.

> Scenario 2 will just give you pose data at 60Hz. Through, now that frequency stuff is fixed, it is easy to automatically rise the fps at the right level (in this case 200 for example) and start internal_syncer.
> The only question is what do you with other sensors / actuators. Do we are running them at the maximum frequency ? Or do we keep them at default / configured frequency (i.e 60 Hz).

I would use a MORSE-wide default frequency for components (possibly
below 60Hz -> 30Hz?)

> What do we do if user force a fps < 200 (stupid user, kill him?)) ?

Do you mean:

```python
#...
pose.frequency(200)

#...
env.set_speed(20)
```

Well, in that case I would send an error: You are requesting sensor
'pose' to read values at 200Hz, but you have set the frequency of the
main loop at 20Hz.

________________________________
[http://www.plymouth.ac.uk/images/email_footer.gif]<http://www.plymouth.ac.uk/worldclass>

This email and any files with it are confidential and intended solely for the use of the recipient to whom it is addressed. If you are not the intended recipient then copying, distribution or other use of the information contained is strictly prohibited and you should not rely on it. If you have received this email in error please let the sender know immediately and delete it from your system(s). Internet emails are not necessarily secure. While we take every care, Plymouth University accepts no responsibility for viruses and it is your responsibility to scan emails and their attachments. Plymouth University does not accept responsibility for any changes made after it was sent. Nothing in this email or its attachments constitutes an order for goods or services unless accompanied by an official order form.


why does it need to be json? the cache won't serialize/deserialze a ruby hash properly?


Isn't using `@` with a function problematic, in case there is a critical error, which you suppress with using `@`?


I'm assuming this is just for sketching and you'll go back to using a constant?


だいぶ修正が抜けてますね...


> for the last two, see my reply to your comment for postgresql.

I didn't understand your reply either ;-)  (For reference that thread is [here](https://github.com/vuntz/crowbar-openstack/commit/ab750c4d404bf03ab5812a087a62290a04f07bdf#commitcomment-15605008))

I'm still a bit confused by all this, mainly because my brain is absolutely fried with excessive multi-tasking at the moment.  An explanation in the commit message body would be a big help.


This was my attempt to break the update into separate commits, I've had a merge here 80762fce2dc7f4cdd772800d033e1505383cac8b


Actually fixes #12.


The name of this method is a bit weird. Why does it say "FromPortletPreferences"? Isn't that an implementation detail?


fast-forwarding master to auto = 8c2d9885


I am not sure write$tun is correct. please check it..


Ah nice, didn't even think about that!   Can you override the signature of:

```java
Session session()
```

with

```java
GraphSession session()
```

thought?  I would think you would have to generalize CCMTestsSupport for that to work, but I might be wrong (trying that out quick).


Use && instead of nested if clauses


correct


Maybe it would be sufficient to place the constants ad hoc. (`"vendor"+filepath.Separator` instead of `vendorDirPrefix` ...)


not RED color! Black :(


I'm also not sure what you mean by "ms vs fs primitive".


i do not get the poin for this.

@Undergrounder i think as for flowjs this should be changed simply to dist/fusty-flow.js and this file should be generated by the build and archived in /dist both as original and minified version with the following names:
dist/fusty-flow.js
dist/fusty-flow.min.js

whould you please take care of integrating this in your pull request?


I should not say "not needed".

Of course that warning would be good.. however the severity for that must be "portability".


The new domain is right, but the site structure also changed as part of the changeover, so these new URLs are broken again. Handling in #43907.


This is mirrored in README. So, please, update it there too.


Можно положить в пакет widget


Oh cool, that does seem to work, nice!


Hmm, okay. It might be caused by a new armor in 2.5.6 (1.5.6, I mislabeled).
I'll look into it.

> On Jan 25, 2016, at 4:18 AM, Bogdan <notifications@github.com> wrote:
>
> @cleverpanda regular armor, too, has no texture, no armor mod has no texture, but in the older version of the armor textures from there (the one that has already been added, leather, metal, diamond).
>
> The log Forge says that it can not download the file texture, despite the fact that he is there, for example iron armor.
>
> —
> Reply to this email directly or view it on GitHub.
>


nice! i agree with this simplification :)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1238](http://teamcity.monogame.net/viewLog.html?buildId=14007&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


awesome! :+1: merge


Would something like that do:
`You want to have faster-than-real-time simulation, that accordingly simulates faster sensing and faster actuation. For instance, while your robot was initially moving at 1 m/s^-1 with a pose sensor sending reading at 10Hz, you now want to simulate it twice as fast: you will see the robot moving at 2 m/s^-1, and you will receive pose readings at 20Hz.`


Crap, thank you.


`ItemList` is actually never used.

I like the fact that item lists can actually be treated like `IItem[]` when it is convenient. All ItemList adds is the ability to look up enums by value...


Glad to hear it! You should be able to deploy to webhook by running "wh
deploy". Let me know if you have any issues!

On Monday, January 25, 2016, KrisWSO <notifications@github.com> wrote:

> Woo! Except I am still having trouble pushing changes to webhook... More
> investigation today after a long hiatus, but I may have a few questions for
> you later if that's ok.
>
> Hope you're doing really well -- we love the exhibit boards, and really all
> the work you've done for us : )
>
> Best,
> Kris
>
> On Sun, Jan 10, 2016 at 5:08 PM, Steve Sunderland <
> notifications@github.com
> <javascript:_e(%7B%7D,'cvml','notifications@github.com');>>
> wrote:
>
> > Check you out! [image: :+1:]
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/KrisWSO/WSO/commit/99f959966f6fe69797dd21ce10fa3190ce1b9fc6#commitcomment-15362494
> >
> > .
> >
>
>
>
> --
> Kris Williams
> Data Analyst
> Water Systems Optimization, Inc
> www.wso.us
>
> 290 Division St., Suite 311, San Francisco, CA 94103
> Cell: 585.298.3655
> Email: k <http://goog_2007057986>ris.williams@wsoglobal.com
> <javascript:_e(%7B%7D,'cvml','ris.williams@wsoglobal.com');>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/KrisWSO/WSO/commit/99f959966f6fe69797dd21ce10fa3190ce1b9fc6#commitcomment-15654836>
> .
>

--
ss

sunderlandstudio <http://www.sunderlandstudio.com> | schedule a meeting
<https://calendly.com/stevesunderland>


maybe using grunt-browserify+babelify would be better?


Critical: No test to test the app. asserting "assertEquals(4, 2 + 2);" this is just a normal arithmetic assertion.


Fix link to other how-to article.


Extends ItemList here: https://github.com/SamGraber/TypeScript-Angular-Utilities/commit/111a95d281827b1e26fa328d2acd905554f78d68#diff-e18f0367556cc9bbb734b06b829fff2aR11

Which invalidates the above comment


@vitalivanov -- nice find.

So I take it on your local build machine you have a directory called "/.config" (at the root of the file system)? Is that correct?

It is likely no one else has seen this because they do not have a "/.config" directory.

Anyway, nice find.

This Makefile was initially ported from Broadcom.  Looking at it now using `-include` to pull in extra configuration seems kind of wrong.  A quick grep of the entire Linux drivers directory for `-include` shows no other drivers doing this.

I think the fix here is to just remove the `-include` line.  We are not using nor relying on this mechanism.


I'm not using es6. So babelify isn't necesary. Why browserify when using webpack?


These should drop the 'experimental', right?


Please move the  new 'parameterDefaults' argument immediately after 'parameterNames', like it is in the upstream.


I splited this in two, because someone may want my_vendor/ package


:+1:. Strong typing for the win!


Personally, I kind of like no spaces after the commas when the variables are all single letter. And PEP8 doesn't actually have anything to say about spaces after commas (only that spaces before are bad).


IIRC `DecompressionBombWarning` is not raised as a exception by default, so you will need to use the `warnings` module to do that:

```python
    with warnings.catch_warnings():
        warnings.filterwarnings("error",
                                category=PIL.Image.DecompressionBombWarning)
```


Correct!, let me change it


Yup, makes sense.  Thanks, man

Sent from my iPhone

> On Jan 25, 2016, at 12:19 AM, flaw1313 <notifications@github.com> wrote:
>
> I love this.
>
> The only thing you might want to check out is reread the task again, there might be some days you are forgetting in your equation.
>
> Your thought on how to account for the leap year is quite smart and not something I considered. You have actually touched on a subject we haven't discussed but will in the lecture. By doing 39/4, you get 9.75 but it actually considers it 9 because you are dividing an integer by an integer. Since they are both integers it just lops off the decimals. If you had done 39/4.0 the answer would have been 9.75 and there would have been a fractional day on your result. Let me know if that makes sense.
>
> —
> Reply to this email directly or view it on GitHub.
>


ahh your right I thought I checked it. honest mistake, I'll commit a new one in a few hours unless someone can go ahead and make that pull request for me.


:joy: :joy: :joy: :joy: :joy: :sob::sob::sob::sob::sob::sob::sob::sob::sob:


@shighucd I'd suggestest if you are going to split the address into 1 and 2, then keep/add a property, maybe just a getter to join the two.


ah ok i was thinking this polifill was simply for using es6 environment.

what is its reason?


You don't need to search for the user again, it should already be attached to the comment. Plus it's also generally a bad practice to make queries happen from your view


I'm trying to have basic support for linear math so I can finally have C function in the Bullet core API.
Do you want to help? Any would be welcomed.


Done


We got a temperature node namespace already, no? Just the temperature/converter one there yet, but I guess this one belongs there too.


Hi @dscho, thanks for the mention. One minor quibble:

`Since MSYS2 converts any directory other than the root directory without
a trailing slash, we do not need any more special handling.`

To be precise, on MSYS2, we preserve *any* trailing slashes found in input paths:

```
arg-echoer.exe  /etc/
C:/msys64/etc/
```


Well, had to become `_.mapValues`. :grinning: https://github.com/SamGraber/TypeScript-Angular-Utilities/commit/ca526158e2fa26fb122a21107a570f83217dcafb


Yeah, that's true too


fixed.


But I could look for toServer and fromServer properties, to determine if it's a full transform or a mapping object


It can't be constant becouse it's not const on every system and I want to keep it simple
./main.go:35: const initializer fmt.Sprintf("vendor%c", filepath.Separator) is not a constant
./main.go:36: const initializer fmt.Sprintf("%cvendor%c", filepath.Separator, filepath.Separator) is not a constant


Whats was wrong with a `MakeAbsolutePath`? The checking before seems redundant, but updating with this method was clearer/


Why... thank you!


It does work, but not for the right reasons.
At this point in the code, forego already knows the process has stopped/crashed.
This is trying to open stderr on a process that doesn't exist anymore, giving us the impression that it is working fine.

After checking process.go, this might be a better alternative
`ps.ProcessState.Success()`

https://golang.org/pkg/os/exec/#Cmd
https://golang.org/pkg/os/#ProcessState


Update KC reference to HowTo and fix links.


Matt, this is brilliant. I never thought of it.


Is this needed when the application is running?


Yes please, even `root` is by default unable to run `sudo`, which could be a source of potential problems...


Sure.. why not.


New line


I will make the changes as soon as possible.


Maybe have a single if(eventsEnabled) ?


The following doc(s) have been deployed to the [gh-comment](http://gh-comment-static-docs.pantheon.io/docs) Multidev environment:[docs/articles/sites/code](http://gh-comment-static-docs.pantheon.io/docs/articles/sites/code)[docs/articles/local/cli](http://gh-comment-static-docs.pantheon.io/docs/articles/local/cli)


Just so you know, this doesn't disable App Standby, only Doze.


Beyond the scope of this PR.


`trigger_webhook` should not be get called until after the commit anyway.  Another solution would be to call `trigger_webhook` from `backend.py` immediately after the `commit()` which would commit the status update to the database anyway.  This would ensure external side-effects would only occur if the status update was successfully committed.


Not all credentials consist of a username and password. x509 certificate-based authentication does not use either, for example.


Absolutely! Let core do everything core can do.


The following doc(s) have been deployed to the [gh-comment](http://gh-comment-static-docs.pantheon.io/docs) Multidev environment:\n[docs/articles/sites/code](http://gh-comment-static-docs.pantheon.io/docs/articles/sites/code)\n[docs/articles/local/cli](http://gh-comment-static-docs.pantheon.io/docs/articles/local/cli)


If you look at a commit in GitHub's web interface, you will see the branch it is part of directly under the commit message, on the left side. This branch you can fetch and check out.

In this particular case, there is no branch, because this commit was rewritten and is now obsolete. The current version is here: https://github.com/dscho/build-extra/commit/3cff05e6bba261444cdf54d43bff82e75543a6fe


Sorry now i understand... Webpack requires this polyfill to work. It's not used in production.


Typo (magnetometer).


Yes -- but mooted by your fix, correct?


It's not really an app.


consider it work in progress :)

in the end i aim to use the addon language files to provide the translations.
that way everyone can make sure translations/capitalization are correct for their own language.


Ops!


Looks good.

I'm guessing that you've lost the last item from your display for the active build menu.  There's an itemCount value for the menu which indicates how many menu items there are.  The code in  ActiveBuildMenu::resetState() needs to have itemCount increased by 1 when eeprom::hasHBP() is true.  I can add that but won't be able to test it until tonight.  Anyhow, just thought I'd mention that aspect of the menu code.


The following doc(s) have been deployed to the [gh-comment](http://gh-comment-static-docs.pantheon.io/docs) Multidev environment:
[docs/articles/sites/code](http://gh-comment-static-docs.pantheon.io/docs/articles/sites/code)
[docs/articles/local/cli](http://gh-comment-static-docs.pantheon.io/docs/articles/local/cli)


I also thought about it in the first place, but after playing/pausing some videos to test that the change *doesn't* seem to affect the non-MSE player I decided to keep it in the non-MSE player superclass.

Moving it down in the hierarchy would mean to override the pause() method in the MSE player, change the attribute there and then call the superclass method.

I can do it if it gives you more comfidence.


much more helpful!


no return check?


A quick fix:

```js
var buttons = this.getWithDefault('customButtons', Ember.K);
buttons();
```

or

```js
var buttons = this.get('customButtons') || Ember.K;
buttons();
```


The following doc(s) have been deployed to the [gh-comment](http://gh-comment-static-docs.pantheon.io/docs) Multidev environment:
-[docs/articles/sites/code](http://gh-comment-static-docs.pantheon.io/docs/articles/sites/code)
[docs/articles/local/cli](http://gh-comment-static-docs.pantheon.io/docs/articles/local/cli)


The following doc(s) have been deployed to the [gh-comment](http://gh-comment-static-docs.pantheon.io/docs) Multidev environment:
-%x20[docs/articles/sites/code](http://gh-comment-static-docs.pantheon.io/docs/articles/sites/code)
[docs/articles/local/cli](http://gh-comment-static-docs.pantheon.io/docs/articles/local/cli)


It's always `false`, as it's a timeout callback.


Yeah, but as you can easily see, in contrast to other directories, with the root directory you do not have a *choice*. You cannot *strip* the trailing slash.


... This means you always have to have one layer of indentation?


oops hmm thanks


Another nitpick: the more correct statement would be "the base class method will throw an exception if not overridden".


If we are fixing crash only by recreating the Singletonit's bad news.


You should use the same strategy as for the production key. Even though FB keys are not that dangerous to be public, it's still a good idea to always hide any keys just in case


That's great, thanks!


You should make sure your test suite cleans up after itself because now it's creating images every time you run your tests


Should the ```alt``` attribute be added to the structure?


for each ES6 module you import, but the semantics won't be compatible if ES7 straps on top level await otherwise. This is compatible, crappy, but compatible. If you use ES6 modules you won't have this issue since `import` will hide the magic.


Add line break between block level elements.


@jSylvestre: how aboot something like this?


You can use the `Photo.create(photo_params` for the conditional as it already calls save. Now you are essentially calling save twice


https://github.com/CyanogenMod/android_frameworks_base/blob/cm-13.0/core/res/res/values/config.xml#L162
On Jan 25, 2016 9:10 AM, "Alex Naidis" <notifications@github.com> wrote:

> Just so you know, this doesn't disable App Standby, only Doze.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sultanxda/android_device_oneplus_bacon/commit/ea36bcaed30fe65ab8449952981cfe2066467a2e#commitcomment-15655364>
> .
>


:+1: If there are several of these untranslated strings, we should probably make a hotfix with them.


The ```<script>``` tags should be on their own line.


Nitpick: Here are few examples and link to builder design pattern that will make your test more. http://www.javacodegeeks.com/2013/01/the-builder-pattern-in-practice.html
http://www.journaldev.com/1425/builder-design-pattern-in-java

It is generally used when you have to build objects.


Add a space between comment and text.


I would rather avoid mostly the -x maybe make it a switch . . . .


No line break required between import statements.


For both American and British Gut sites, it is http://microbio.me, not www.microbio.me


@gdementen I'd like to include these changes in conda-build.  Would you like to submit a PR, or shall I cherry-pick them from you?


Since this is not at all performance critical, may be you could have reused sha1_unreverse() and initialize hash[4] afterwards, getting rid of reverse3().
```
sha1_unreverse(hash)
if (algo == AX_FORMAT) hash[4] = 0:
```


Yes, I've a local dir for /.config

I can remove it.


First nsbcore commit? :)


You are right. I never checked "man aha" this far. Thanks!


Sure. I was nit-picking `converts any directory other than the root directory without
a trailing slash` since it's not technically true, that's all.


We can use SASS to take care of this like:

```css
a {
    &, &:hover {
        ...
    }
}
```


This was earlier set to `XFormInstanceSQL`, right?  It does seem like it makes the most sense to drop that.


Awesome: Godd job.


@shighucd That works for me. We just have to make sure @jpknoll doesn't write to it.


@petebacondarwin Recommendations is that the DOM structure should be arranged for SEO. For instance

 should be used. If this article is a component, it was possible to add the component as attribute

 but now you need to destroy DOM structure with <component></component>

Or have I missed something?


Add line break after CSS blocks to space next selector.


Do we need to call out the distinction between Pro and OSS being it's in both? I feel like we can say "A default installation of Repository Manager".


You do not need libopus


Add line break between CSS blocks to space next selector.


It *can* convert any other directory than the root directory without a trailing slash, sure, but it's not the only way :-)


Seems like we read pass one char and read 12 bytes.


Correct image layout.


yeah that's kind of what i was thinking too.


Surely output of a function cannot be a constant. But it could be done by `const A = "vendor"+string(filepath.Separator)`. `filepath.Separator` is a constant on every system.
http://play.golang.org/p/EgDNzkN8Op


I understand. I meant that the variables (soon to be constants) `vendorDirPrefix` and `vendorDirInPath` could be replaced by their actual values. But it's not so important, I guess.


delicately crafted


Very sneaky! :athletic_shoe: :cat2:


Yep seems so simple, but when I run that command, it doesn't actually do
anything... I'll have some time later today to investigate more and if I
can't resolve the issue, I will reach out!

On Mon, Jan 25, 2016 at 9:03 AM, Steve Sunderland <notifications@github.com>
wrote:

> Glad to hear it! You should be able to deploy to webhook by running "wh
> deploy". Let me know if you have any issues!
>
> On Monday, January 25, 2016, KrisWSO <notifications@github.com> wrote:
>
> > Woo! Except I am still having trouble pushing changes to webhook... More
> > investigation today after a long hiatus, but I may have a few questions
> for
> > you later if that's ok.
> >
> > Hope you're doing really well -- we love the exhibit boards, and really
> all
> > the work you've done for us : )
> >
> > Best,
> > Kris
> >
> > On Sun, Jan 10, 2016 at 5:08 PM, Steve Sunderland <
> > notifications@github.com
> > <javascript:_e(%7B%7D,'cvml','notifications@github.com');>>
> > wrote:
> >
> > > Check you out! [image: :+1:]
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/KrisWSO/WSO/commit/99f959966f6fe69797dd21ce10fa3190ce1b9fc6#commitcomment-15362494
> > >
> > > .
> > >
> >
> >
> >
> > --
> > Kris Williams
> > Data Analyst
> > Water Systems Optimization, Inc
> > www.wso.us
> >
> > 290 Division St., Suite 311, San Francisco, CA 94103
> > Cell: 585.298.3655
> > Email: k <http://goog_2007057986>ris.williams@wsoglobal.com
> > <javascript:_e(%7B%7D,'cvml','ris.williams@wsoglobal.com');>
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/KrisWSO/WSO/commit/99f959966f6fe69797dd21ce10fa3190ce1b9fc6#commitcomment-15654836
> >
> > .
> >
>
>
> --
> ss
>
> sunderlandstudio <http://www.sunderlandstudio.com> | schedule a meeting
> <https://calendly.com/stevesunderland>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/KrisWSO/WSO/commit/99f959966f6fe69797dd21ce10fa3190ce1b9fc6#commitcomment-15655196>
> .
>

--
Kris Williams
Data Analyst
Water Systems Optimization, Inc
www.wso.us

290 Division St., Suite 311, San Francisco, CA 94103
Cell: 585.298.3655
Email: k <http://goog_2007057986>ris.williams@wsoglobal.com


May be use the previous method?


You should use tabs instead of spaces for indentation.


@deads2k this is the earliest point at which I can find `$VOLUME_DIR`. @mfojtik what is it good for and why do we download it to Jenkins as an artifact?


No problem, you have push rights to my fork in case you want to add editor features avoiding a double pull request to david.


We should SASS this differently.

```css
&:active, &:focus, &:hover {
    .caret {
        ...
    }
}
```


Nitpick: Actually, this could have been written in a better way.
public boolean bookIsAvailable(Book book) {
 return clubBooks.contains(book)
}


TeamCity Civic Assembly :: Build backend + frontend [Build 24](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=443&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


Чисто стилевое замечание, а зачем столько пустых строк между тегами?


:tada:


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 227](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=714&buildTypeId=XbimEssentials_XbimEssentials) is now running


Это именно то, о чем я говорил. Супер! :)


Coverage was agreed to be pushed directly to master since it is a higher priority. There is also the added problem that every change which is made without the coverage being implemented has the opportunity to add more code which isn't covered. It is preferable to make changes which might break a project entirely outside of production than continue without coverage and create more work for myself or others by creating the need to reestablish context and edit code that has been merged without coverage. I entirely agree that, for a project in production, push to master is undesirable and I feel as though I have yet to violate that convention and it is frustrating to be chastised in a commit message which is performing the action it purports to be bad.

It seems odd that this commit was not made in a pull request.

`--omit` isn't necessary here since the coverage command will not be able to ignore a file which hasn't been coverage tested and therefore `subprocess.call('coverage html'.split())` would have been preferable for ease of understanding.

You also added JavaScript files without ignoring them in the settings.

Good idea, that pull request thing.

Somewhat in jest,
Austin


The following doc(s) have been deployed to the [gh-comment](http://gh-comment-static-docs.pantheon.io/docs) Multidev environment:
[docs/articles/sites/code](http://gh-comment-static-docs.pantheon.io/docs/articles/sites/code)
[docs/articles/local/cli](http://gh-comment-static-docs.pantheon.io/docs/articles/local/cli)


OK, I don't understand this commit.  It looks like you renamed ``General`` in the files but not the module?


And what's about `std::for_each`?
Some kind of
`std::for_each(begin(), end(), std::bind1st(std::mem_fun(&Test::RemoveConnection), this));`


А зачем здесь анонимная функция? без неё разве не будет работать? ;)


Remove spacing when the JS variables are similar.

Ex.
```javascript
var childMenuExists = A.one('.child-menu');
var parentOfChildExists = A.one('.drop-menu');
```

```javascript
var childMenuExists = A.one('.child-menu');

var parentOfChildExists = instance.get('.drop-menu');
```


I think this is great. I think this will cut like 80% of the processing and data retrieval for a typical request. Just little stuff to change and definitely could use some specs.


Ok cool, this works for me. But there is still some weirdness with the `Gemfile.lock` - it doesn't look like it's in sync with the Gemfile/gemspec - rspec is upgraded, `uglifier` and other assets gems are added, etc. If you rebase and edit this commit and then when rebase stops on the commit do:

```
git checkout head~1 -- Gemfile.lock
bundle update rails
```

Then it looks better.

Also I don't get why rspec/capybara have commented-out versions in the `Gemfile`. Can they just be left as they were, and then upgraded in the subsequent commits (1b6a2e9ea6ce70bc5b10765ac6a4987f04d8778d, a40c01ee2f75c7c1726dc0f84be9104272840e9f)?


@silverwind , you mean `jslint` tool? Yes, it is clean for `*.js` files.


Thanks for catching that, will fix


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 227](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=714&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:41


Before this change, the dropdown button didnt seem to respond


final :)


It actually was that way to begin with, but we ran into issues where long array literals were bloating code.


After further research, this was the correct method for using dropdowns in navbars. The dropdown does work now.


The recommended Apt Repo should be added, though

Also, some do need it, for some strange reason. I recall a few cases....


We either use the full names (Nexus Repository Manager and Nexus Repository Manager OSS) or only one of them where applicable. When talking about both in a generic manner in the docs we use the normal word "repository manager". This might be fine here .. although less explicit. Considering this is the start of the chapter it is imho good to be explicit. Also note that the {inall} macro right after the chapter title is used and required for each chapter/section.


fixed


@aeschli the content provider is not a service as our other injectable services, so I suggest to move it into the /src/vs/workbench/parts/ namespace and create a new folder there where you can leverage the `IWorkbenchContribution`. See for example the file tracker:

`(<IWorkbenchContributionsRegistry>Registry.as(WorkbenchExtensions.Workbench)).registerWorkbenchContribution(
	FileTracker
);`

Workbench contributions are being created on startup of the workbench, so you do not even have to call start() from the outside.


Maybe we should make an internal redirect (forward)? Doing it like this will send 302 to the browser, which then re-requests.


And... this PR is NOT ready for review yet ;-)


> in the end i aim to use the addon language files to provide the translations.

makes perfect sense


ha, thats funny, because in my branch, the folder name was changed too. Looks like that was not recognized during the pull?!?


:dancer:


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1238](http://teamcity.monogame.net/viewLog.html?buildId=14007&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:29:24


I'd suggest you do:

```js
"'#{theme.slug}' : { colors: '#{theme.colors}', name: '#{theme.name}' }"
```
instead. That way, you can access these as `themes[$scope.slug].colors` and `themes[$scope.slug].name` down below.


I meant `eslint`, which can be run through `vcbuild jslint` on Windows, but it's included in `vcbuild test` too :)


Added.


Der Code kompiliert nicht. (siehe https://travis-ci.org/aschuman/CoBaB/builds/104665370)
Compilerfehler führen dazu, dass der Code des gesamten Projekts nicht vernünftig auf kompilierbarkeit und schon gar nicht durch Komponententests oder manuelles Testen geprüft werden kann.
Bitte checke nur kompilierbaren Code ein.


The following doc(s) have been deployed to the [gh-comment](http://gh-comment-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/sites/code](http://gh-comment-static-docs.pantheon.io/docs/articles/sites/code)
- [docs/articles/local/cli](http://gh-comment-static-docs.pantheon.io/docs/articles/local/cli)


Maybe we don't want two separate control loops for local and global bears, maybe we just make a single one?


Successfully created the [1270-code](http://1270-code-static-docs.pantheon.io/docs) environment. New commits to this branch will automatically be deployed.


Probably better named as `name` instead of `names` since it is **the** name of a single theme.


This commit is not up to date. This line no longer exists.


good catch


`learned.....clause`  :)


Some help text describing the options would be useful.


не закрыла section (нет закрывающего тега), тот что с классом content


updated index.HTML


Copyright missing.


@bucaran any reason to **not** go back to a flyjs organization?


Doc comment for file is missing.


To clarify, it's a flag indicating whether or not this is a learned clause


Copyright.


давай этот блок content-title тоже сделаем через тег section


File doc comments.


An error occurred while I was writing the commit message. The message was supposed to say that I changed the username internal identification from ID to username. Users are now recognized by the application.


Some of the questions are really opinion seeking. Just curious as to what you answered.


Hi!  I'm reviewing this for the Coursera course.  Can you please update the comments so I can review it with comments updated?


This change looks good. Feel free to cherry pick it ahead of the rest of the PR. If you want, you can force-push to this branch after this change is in.


Yep, i meant same too. I was referring `jslint` label instead of `eslint` that it runs. :)


Don't do anything about it.  I am going to check some stuff in soon and that hopefully will correct it?


Если говорить о стилях, которые применяются к компонентам, то они не должны распростроняться за пределы этих самых компонентов на столько, на сколько это возможно. По-этому желательно организововать их вокруг какого-то рутового элемента компонента. Ты можешь добавить в дивы с классом "todoListXXX" новый класс, к примеру, "todo". Тогда все стили в этом файле будут формироваться вокруг todo стиля:
```css
.todo {
    ...
}
.todo input {
    ...
}
```


Еще, было бы логичным называть файл стиля так же, как компонент, к которому он принадлежит ;)


I think this still isn't quite right.

alignment: units of bytes
ri & wi: units of bytes
update_[read|write]_pointer() argument: units of items

Wouldn't the correct expressions be:
(alignment - ri)/itemsize and
(alignment -wi)/itemsize ?

A made up example:

alignment = 64 bytes
itemsize = 8 bytes/item  // i.e. gr-complex
r = N*64 + 8                 // so 7 items until the next alignment boundary
ri = r % alignment = 8 bytes
alignment - ri = 56 bytes
(alignment - ri)/itemsize =  56 bytes / 8 bytes/item = 7 items


Is it your intention that this photo is supposed to actually exist at the specified URL? As far as I know, it does not exist.


вот этот див лишний - у нас есть секция section class="content", в котором два блока div class="item-gallery" и div class="item-description"


yeah, i figured we would try this for a bit and see how bad it would be (i use clang mostly, so don't usually see the different). you might want to try changing to `-Og` also – apparently that's supposed to improve debug info over `-O0`


Yeah it's :hankey:

[Pretty easy to convert between UTF-8 and UTF-16 though.](https://github.com/origamicomet/yeti/blob/master/src/yeti/window.cc#L74)


TeamCity DNN JavaScript Libraries :: CI [Build 136](http://teamcity.engagesoftware.com/viewLog.html?buildId=414&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 136](http://teamcity.engagesoftware.com/viewLog.html?buildId=414&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:8


Где используется Input?


done


Slider is broken in this commit due to a merge conflict that @zurbchris will resolve.


Ack. Let me investigate this.


done.


Thanks, it took a little while to figure out how WP's installer system works (your code helped a lot too) :smile:


див div class="item-description" у нас обертка для всей информации по товару, то есть внеси в него не только спаны, но и все последующие блочки item-info, item-buy, set-info


Did you do this with `git revert 04acce6` ?


Indeed, I get your point!

The only current problem is after generating a bundle the tests are not being called, that's why I came here to check the source of the change!

I appreciate your answer, lets see what's the final adjustment for this!


And I was wrong again. Fixed now to be unambiguous. This is now `learned_clause`. `Clause.learned` is still a boolean flag.


Following the docstring, would `strip_learned_clauses` be an accurate name ?


TeamCity Civic Assembly :: Build backend + frontend [Build 24](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=443&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests failed: 2 (1 new), passed: 1729, ignored: 7 Build time: 00:20:30
### Failed tests
```
Venue tests: Venue type: Should Not Edit a Venue: <no details avaliable>

User Management: Should submit a form for user creation: <no details avaliable>

```


Uh oh.


Good catch @nixel2007


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12614](https://teamcity.mesosphere.io/viewLog.html?buildId=112050&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:08:53


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12617](https://teamcity.mesosphere.io/viewLog.html?buildId=112055&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:09:22


The hell of perfectionist =)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12616](https://teamcity.mesosphere.io/viewLog.html?buildId=112054&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:09:48


The hell of perfectionist detected =)


Do you know of a way to write a test for this?