Can you tell me why I'm getting this email?
On Jan 30, 2016 2:29 AM, deceivedagain <notifications@github.com> wrote:Km

—Reply to this email directly or view it on GitHub.


educational


TeamCity pull requests :: netty [Build 1158](https://garage.netty.io/teamcity/viewLog.html?buildId=5263&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6402, ignored: 23 Build time: 00:42:40


いま１行になってるところを、まずは二段表示にして、ボタンをやめてアイコンにするなどすれば、ある程度救われるのではないでしょうか


- 'and to the right'


This is more of a code style change than refactoring, so maybe it could have been done in the previous commit to keep logical changes grouped together.


@danielstuart14, Sorry went out for dinner. There ya go, basically what I'm using. It's on tab, not sure what you want it set to by default. Probably could add it it to the briefing.


remove this whole section and point instead to a new article that will summarise how to use ruby and current support


まずはボタンをアイコン化してみたらいいと思います。そうすれば横に並べられますよ


Yeah, definitely. I will do it on Monday


Well.... I got it to give an error 405!


Because this is the only line using bracket syntax in the file, so I thought it would be good to keep them consistent.
We could switch to bracket syntax in the future commit.


うむむ。。


さっき突っ込めよって話なんですが、StringBuffer を使う意図ってなんでしょう。


m prefix なー


Agreed!


Hello. I was in doubt if the best approach was `performBlockAndWait` or `performBlock`. Do you have a test case for this?


Not needed.


Hello. Any PR for this? ;-)


@jonathascarrijo você fez um ótimo trabalho! Parabéns!


耒大，当初你的Express 2008是安装在C盘吗？我的是安装在D盘，重装后原先的激活会不会无效？


Just some details: Please make this method private as so far it's in private use. Also there is no need to prefix it with an underscore, we don't have such a requirement.


Hey


this file was changed before you finished, please pull upstream and add your  $route line below the new ones.


we can start with declare main fucntion :)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13732](https://teamcity.mesosphere.io/viewLog.html?buildId=119072&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:03:43


Thanks for pointing it out! :smile:   Fixed in c0613c9


@lembacon seems like you can't run `xcrun simctl erase all` while a sim is booted? And if you first shutdown that simulator, and try to boot it afterwards it freezes?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13729](https://teamcity.mesosphere.io/viewLog.html?buildId=119058&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:08:00


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13730](https://teamcity.mesosphere.io/viewLog.html?buildId=119057&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:08:39


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13731](https://teamcity.mesosphere.io/viewLog.html?buildId=119063&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:09:06


@alishagianoulos You probably have the git/git repository marked as "watching", which will generate notifications for any comments on it. You can go to https://github.com/git/git/commit/9a6f1287fb69c46c7895f987ffea558b13ae79d1 and click "unwatch" at the top of the page.


Phibes es Wekereke le gusta la verga gorda, saludos perrita.
XD


Valid point. Will fix it right now.


I sent a pull request at https://github.com/mattn/go-sqlite3/pull/268 which shows the approach I mean.


Is this option not ready for roll out? Macro doesn't seem to be a definition for this macro anywhere


Why not also specify

const char* CONST sep = " \t,;";

?


Hi @vmartinelli ,

Sorry I don't have a test case for this. I'm not 100% sure this is the cause of a dealock. I made this modification because this is the only suspicious code I found out. The deadlock happended when these conditions were met:

1. A FetchRequestController (another class in this framework) is fetching entities on a main queue context.
2. Two private queue child contexts (DataContext) are saving at the same time (In my app, I have multiple networking operations running simultaneously, and their results are saved in their respective child context, sharing the same RootSavingContext).

When the deadlock occurred, I click the pause button in xcode, and I found execution was always paused at the same places (which determined this is a deadlock):

1. The main queue FRC is fetching.
2. A private queue child context is saving.
3. Another private queue child context is merging from a merge notification (where I made the modification).

Fortunately, the deadlock has not been seen again after the modification. Hope this would be helpful.


Should this `packages-funcs.el`


Two spaces after the last character create a new empty line. Have a look [here](https://daringfireball.net/projects/markdown/syntax) for a reference.


心寒


danke


重裝VC#可能會失效 :sob:


Hi @vmartinelli ,

Sure, let me add some documentation first.


While testing a function I made from this code, found it did not work as I think it was meant to.


Thank you. It was very helpful. Can you make a PR to the `develop` branch with this modification?


StatsMain.php L102  appears to be another reference btw


commento aggiunto successivamente


This commit appears to have caused bbatsov/prelude#964


TeamCity pull requests :: netty [Build 1159](https://garage.netty.io/teamcity/viewLog.html?buildId=5264&buildTypeId=pulls_netty&guest=1) is now running


so it is.


It made jss files not be identified as JavaScript but they no longer contribute to the percentage so it shows 74% NSIS and 26% BatchFile.


@Codemazk/developers :+1:  lets take a look


Slick!


@quequotion  this is not a typo, but there seems to be a regression with how qvariants work across qt4, python3, and qt5.  http://pyqt.sourceforge.net/Docs/PyQt5/pyqt_qvariant.html .  In short, that used to be the correct way to do it, but now it tries to do it automatically... I prefer the previous method since QVariant's would be more useful.

I will try to address this soon.


I do not exactly understand why it's required here. It's strange - add `Proxy` as a dependency for `Array#includes` test. It can be added without hard `Proxy` dependency - just getters. AFAIK all engines correct with internal `[[Get]]` call, just most hasn't `Proxy`.


I wonder why does rootPackage always have to be build? Doesn't this condition invalidate the [examples on the spec page](http://code.dlang.org/package-format?lang=json#standard-settings)?.


Bai, I can't find the upstream project…


The dims array on: https://github.com/Ensembles/ert/blob/master/devel/libecl/src/smspec_node.c#L398 is only used when actually needed; I therefor suggest that the signature is changed to:
```C
static void smspec_node_set_num( smspec_node_type * index , const int * , int num)
```
then the `well_var`and `group_var` "constructors" can pass 'NULL instead of the dummy vector `{-1,-1,-1}`.


aws-cli


I know, but I don't want any to go offline when the screen goes off due to a bug in demand-based governors.  I could get rid of the fb_notifier and all the other overhead, but I'm really busy and this was an easy fix.


mix(vec4, vec4, bool) is a GLSL 4.5 function. This fails to build on AMD (for good reason, it only supports GLSL 4.4).

The two options are to change this to stay at least at GLSL 4.4, or revert commit 8c0614b2025c8d5c4d819510ad67c9e1e25a0a5b.


The upstream suggests using pot from git master, so I did. And we would need to send an email to request a merge, at least so as their documentations suggest.


能增加中国大学MOOC的链接处理么(＾o＾)ﾉ
譬如(　ﾟ 3ﾟ)... http://www.icourse163.org/course/whu-23003
谢谢大触(*ﾟ∇ﾟ)


@forresst All changes are updated :+1:


Thank you @mvayngrib


I agree - in an engine with native `Proxy` support, these tests are excellent - but having a failing grade for an engine for `Array#includes` simply because it doesn't implement Proxies seems pretty useless, and against the convention we've established that tests for a feature should not be dependent on other features not present in the baseline.


Hmm - excuse my ignorance; but this I do not fully understand:

1. `struct deleter` - is that a C++ construction I should know of?
2. Where did `operator()` come from?

In the ert library there is a 100% rule creating typedefs as:
```
typedef struct some_struct some_type;
```
i.e. the `struct smspec_node_struct` is available as `smspec_node_type` - using that I would assume the private part of the class could be written:

```C++
private:
     std::unique_ptr< smspec_node_type , smspec_node_free> node;
```


I think that a `if (typeof Proxy !== 'function') { return true; }` would be fine here tho.


@DREAMWORLDVOID 上一个commit写错的，这个commit里改回来的


I'm glad you are starting on the `s/shared_ptr/unique_ptr/` crusade.


nama commitnya seharusnya convert user.email to lowercase, agar tidak dobel email karna perbedaan besar dan kecil huruf


Use a single empty line at the end of every file.


Hmmm - some funny character introduced?


@flavour Please review


@flavour A sample of json

```
[{
status: "Draft",
identifier: "Biplov--20160131-047-alert",
sender: "Biplov/10",
msg_type: "Alert",
cap_info.certainty: null,
cap_info.event_type_id: 25,
cap_info.category: [
"Met"
],
cap_area.name: null,
cap_info.headline: [
"ျမစ္ေရႀကီးျခင္း သတိေပးခ်က္ (မေကြး)",
"Flood Warning in Effect for Magway City"
],
cap_info.priority: null,
cap_info.urgency: null,
scope: "Restricted",
cap_info.severity: null,
id: 47,
sent: "2016-01-31 06:25:03"
}]
```

Everything seems to work but I still have cap_info.event_type_id: 25, id here instead of name.
The default event_type_id has translate=True

What is the problem here?


@flavour Please review this logic...Can you suggest some better logic than this one?


Well, this fixes symbol error


Adding files to unit test api.


Fix in #4893


I do like this new structure :)


xiu gai


if (true) ?
Why do you use an if condition if it is always true? Nothing to check here so the if doesn't make sense.


Is that from libEGL or similar? A clean build would help :)


RC already? :O


Moved up since it will be used in the first shareRender.rect method


Cached newSize * 2 since it will be used multiple times later


I would recommend using a QScopedPointer. QScopedPointer has no overhead!


No need to call `recursions - 1` eight times in the succeeding lines of code


It is frustrating you know, I tried it several times, clean build many times, finally, remove those option make me happy. Wish you too.


TeamCity pull requests :: netty [Build 1159](https://garage.netty.io/teamcity/viewLog.html?buildId=5264&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6402, ignored: 23 Build time: 00:42:54


TeamCity pull requests :: netty [Build 1160](https://garage.netty.io/teamcity/viewLog.html?buildId=5265&buildTypeId=pulls_netty&guest=1) is now running


No... the -DNEEDS_VECTORIMPL_SYMBOLS fixes symbol error
Btw, why xposed doesn't work with CM11?


This gives a read error if path or orig_path have been escaped


Moved `newSize` up since it is used already in the `shapeRenderer.rect` method call.


Yes, I am talking both of them. About xposed, I haven't tried it yet.


o.O team = 0 implies that it is a nee initialization. In Line 559 you compare it to Attacker.
Attackers can be "TEAM_ALLIANCE"(0) or "TEAM_HORDE"(1).
To prevent confusion do not use magic numbers. Use uint32 team = TEAM_ALLIANCE;

At the end the new var "team" makes no sense, because we have already a variable which defines the "team" in form of Attackers.
So you can use in line 559:
PlaySoundToAll( Attackers == TEAM_ALLIANCE ? SOTA_SOUND_VICTORY_HORDE : SOTA_SOUND_VICTORY_ALLIANCE );


Cached `newSize * 2` to avoid computing it in the next 8 lines of codes


I think you mean "team == Attackers" instead overwriting "team = Attackers"


So where does the Transifex thing come from?


I usually don't use `.gitignore` in my projects, but it tends to put people off, so I will happily accept it.


Dreaming of this https://www.youtube.com/watch?v=OfscbJldcAI


decrement `recursions` to avoid subtracting ones in the next 8 lines of codes


:-) really lucky that xterm is so late, behind xfce and xmonad and probably all others that we have.


Build CM around an hour.


I suggest how about `render` instead of `redirect_to` here? Because it's only showing error message


Hmm.... i does that too :D
Fixing these was a real PITA


Made a small error error, should be:

`(check-tail-exn fixnum-overflow-exception? (lambda () (fx- ##min-fixnum 0)))`


npc[i] != NULL ~.~
Compare pointers always with nullptr instead of this obsolete makro.


Yeah, that doesn't seem a good description.


@DDoS  I am getting this error: null value in column "date" violates not-null constraint while inserting into db, can you please check?


좋은 기능이었는데 revert해버리셨네요 ㅠㅠ


demolisher[i] != NULL ~.~
Compare pointers always with nullptr instead of this obsolete makro.


It's available on Linux 3.4+ only, so it needs a fairly recent glibc and kernel combo.


(updated to version 3.4.110)


@kijin 여러 부작용들이 많아서 어쩔 수 없었습니다.  함부로 건드릴 수 없는 부분..ㅠㅠ

그럼에도 나중에 재도전해보겠습니다.


but why?!?!?!?


yay


What a good weather!


Do we lose the location information by doing this? What if an annotation is a default for one code location but not another? If the location information is somehow being respected when removing the annotations to be ignored, please add a comment to removeIgnoredAnnosFromScene or to removeIgnoredAnnosFromATypeElement explaining how that works.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13734](https://teamcity.mesosphere.io/viewLog.html?buildId=119089&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:09:30


Missing an end backtick here


No, I think committing it was fine! Pushing it was fine too. Inside the
branches we can live a little wild. =)

On Saturday, January 30, 2016, mattCasanova <notifications@github.com>
wrote:

> Thanks for letting me know. I know it was bad design but I didn't know
> where the functions were being called, so I wanted to see if I could get
> the math. In general I just shouldn't have committed the code until it was
> bug free and cleaned up.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OpenPersonalFinance/RetireCalc/commit/b22f9c3b41c84e8435c9be55f26d3c5d6f53d62f#commitcomment-15783659>
> .
>


やってみます！


Разметка: в данном макете обернуть все блоки в один контейнер не получится.
Как это понять? Смотришь на блоки в макете, видишь что у них фоновый цвет (ну например синий у самого верхнего меню, серый у того блока что пониже и т.д.) тянется на всю ширину макета, а контент внутри этого фона - центрирован, значит у тебя должен быть для каждого из таких блоков обёртка тянущаяся на 100% ширины body, чтобы всегда растягиваться до краёв браузера, и внутри неё должен быть центрированное содержимое.
В таком случае получается как-то так: например я считаю что синий и серый блоки наверху относятся к хэдеру, тогда делаю header.main-header вкладываю в него эти блоки, ну например вот так тупо:
header.main-header > .header-top + .header-bottom  (у одного будет синий фон, у другого серый)
И дальше внутрь каждого из них кладу .container, чтобы центрировать содержимое.
Ну и дальше по аналогии.


So, unless I'm missing the intent here, and the `loadConfiguration` function will walk up the tree, this seems like it might be a mistake.

For example, that path might be something like `/path/to/thing/lib/bins/main-script/command-line.js` but the package.json file might be in `/path/to/thing/package.json`.

So, you'd want to *start* with `/path/to/thing/lib/bins/main-script/package.json` for sure.  But don't stop there.


Unfortunately I dont get the same result (Magento 1.9.2.1). Using your code.
![payex_rounding_1](https://cloud.githubusercontent.com/assets/6286270/12700850/f1daeb7c-c7f3-11e5-9f11-dedbcebf13e1.png)
![order_view_magento](https://cloud.githubusercontent.com/assets/6286270/12700853/ffd77a60-c7f3-11e5-9288-e2ec9b64e2d2.png)
![magento_settings_1](https://cloud.githubusercontent.com/assets/6286270/12700854/079bd2a0-c7f4-11e5-8c8e-99816b7b248c.png)
![magento_settings_2](https://cloud.githubusercontent.com/assets/6286270/12700857/0d462a84-c7f4-11e5-8a18-06256066c041.png)


With or without ET Currency manager, gives same error.


Shoot accidentally used a bunch of double quotes instead of single quotes. I'll fix those eventually.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13736](https://teamcity.mesosphere.io/viewLog.html?buildId=119091&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:03:28


About "Get AutoRemove is deprecated." It is very useful and practical feature. What are the reasons for this depreciation? For example, I constantly use this feature, and get a bunch of unnecessary messages in the log.


new


Great, thanks!


"At higher client counts"が「上位のクライアントにおいて」と訳されていますが、「クライアント数が多い状況では」という意味ではないでしょうか。
なお、"gangway effect"が訳出されていませんが、できれば翻訳したいところ。しかし、私も意味が分かりません。
お役に立たなくてすみません。


It is kind of pointless though since network would be similar but the same for everyone, it makes more sense to have their current gold.


.global-panel  - не очень говорящее название, по моим ощущениям. Вот читая его я не могу догадаться даже примерно что там будет. Сам бы я тут использовал что-то вроде .user-actions или .site-actions или .user-controls ... Не знаю, попробуй подумать, может что-то получше придумаешь.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13735](https://teamcity.mesosphere.io/viewLog.html?buildId=119090&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:07:42


I think this change is very useful, but I'm fairly sure that setting `live:true` will still get all docs if no specific sequence number is provided.


@feeley , what's this for?


@MNoya The sound event for Hero_Axe.Culling_Blade_Success needs to be remade so it can be played with EmitGlobalSound. Currently it will not play at all since it is a 3d sound.


TeamCity pull requests :: netty [Build 1160](https://garage.netty.io/teamcity/viewLog.html?buildId=5265&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6402, ignored: 23 Build time: 00:42:39


Имена классам в смысле модульности заданы хорошо )


もう少し自然に訳すとすると、
「しかし、回転待ち時間が長い場合は、この設定はわずか二つのクライアントにおいてさえ、トランザクションのスループットを向上させる効果があります」でしょうか。


Вот я бы кстати тут h1 использовал, мне кажется это прям идеальный текст для поискового запроса )))
Но так как ты сделал - тоже можно.


Am now doubting if this was a Good Thing™; you can use the group to shield off non-members from accessing the TLS Pool.  Still, this is dependent on the way the TLS Pool is being setup, and this setting certainly helps with quickly getting it going (typically the application done without reading much, to get a quick feel) so I support I'll leave it at 0666.


Этому блоку нам понадобится белый бордер и внутренние отступы, так что его скорее всего придётся делать блочным элементом. Например <p> или <div>


a


tool/pgp11-genkey.c holds pieces of old code; still need to clean it up.  More importantly, its output does not import properly into GnuPG.


I suggest to refactor the code to have more readable code like [this](https://github.com/moneymanagerex/moneymanagerex/blob/v1.2.x/src/mmhomepagepanel.cpp#L671) from line 673


В макете страницы каталога и в Styleguide.psd показано, как этот блок должен выглядеть, если пользователь вошел. Надо это здесь учесть. Переключение будет достигаться скрытием ненужных элементов добавлением класса .hidden или лучше .is-hidden


Dat green archer.... Somehow this is becoming like... Power rangers? Colourful names. Lololololol...


Thanks, that will certainly save me time. I also found a bug in bctdump that I kinda fixed. Not sure if it is right but I can upload those changes too if you would like to have a look. The binary would die when it tried to read the rsa signed signature parameter.


Всё же я бы обернул слово Материалы во что-то, например в тег b (так для единообразия лучше, я считаю) и уже ему, я бы задал класс .promo-title.  А сейчас получилось что у тебя просто текст и промо-кнопка находятся внутри названия промо-блока


OK


That leads me to the question: When is it required? I was under the impression Navitia needs an authorization token with each request.


`parse_args` fails when you run the unit tests. It does not like the `-m unittest` present in the sys.argv list when running unittest. I could not find a good solution to this so I used `parse_known_args`.

I guess we could write our own test initiator and pass a valid arg list to each test but that seemed a bit excessive to me.


>endpoint has been added back (as **deprecated**)

In this case we should use the new way (string listen_interface()).


I take it the API has no means for saying "give me all you can tell, distance doesn't matter"? What's the behaviour of the API if the "distance" parameter is omitted from the URL?


В макете есть скрытый блок, на котором изображён второй слайд. Т.е. внутри promo-slider'а будет slide slide-perforators и slide slide-drills . Как-то так.
И у тебя Перфораторы и Настоящие мужские игрушки сделаны разным шрифтом. Т.е. их не надо в один P объединять. Это два отдельных элемента. Причём Перфораторы это тоже нормальное слово для поиска в браузере, можно и заголовок использовать. А Настоящие мужские игрушки - просто абзац текста.


HAHAHA


< /li> закрывающий надо перенести на новую строку, чтобы все < li> были на одном уровне


@quequotion  I'm unable to test this myself at the moment - please give this copy of the script a try:

https://raw.githubusercontent.com/nevion/pulseaudio/master/src/utils/qpaeq


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13737](https://teamcity.mesosphere.io/viewLog.html?buildId=119092&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:10


> There is no official release yet
Just because of the 404 link in the readme


typo


fkm


+++++++++++++++++++++++++++++++++++++++++++
运行环境：
1、python 版本 < 3.0
2、仅在windows 系统测试
3、命令行main.py运行
+++++++++++++++++++++++++++++++++++++++++++


Лучше .products


А тут стало быть лучше .products-popular


`G:\ApkSecurityAnalysis>main.py
       d8888   888b    888   8888888b.    Y88b   d88P
      d88888   8888b   888   888  "Y88b    Y88b d88P
     d88P888   88888b  888   888    888     Y88o88P
    d88P 888   888Y88b 888   888    888      Y888P
   d88P  888   888 Y88b888   888    888       888
  d88P   888   888  Y88888   888    888       888
 d8888888888   888   Y8888   888  .d88P       888
d88P     888   888    Y888   8888888P"        888

Do you want to examine:
[1] APK
[2] APKS
[3] QUIT

Enter your choice:`
可以检测单个APK，也可进行批量检测。检测结果保存在APK所在文件下。


атрибут href потерялся


@nhaesler Feel free to revert this, but right now it is quite helpful for me & the web server, and does not really bother anyone, I guess…


Oh, you accepted my addition :)


```mkdir -p bin/jni/{arm64-v8a,armeabi{,-v7a},mips{,64},x86{,_64}}{,/stripped}```


Because ERB is far more disgusting than SLIM


я бы назвал это .products-title или .products-caption а не .item


we increment ptr inside the lambda body + a pointer is small enough. I would capture it by value.


Preliminary. General direction.
Intend to
- use cros-ec as a base for nvec on the ac100 using code from an older u-boot port.
- break out ec code to an appropriate ene driver/whatever.
- clean up the booting functionality to allow, usb, sdcard, secondary sdcard, and mmc boot
   -mmc boot will become a backup os store, as it is soldered to the pcb


but i havent provided anything


And exactly that is the reason why I hate some people. Tell a java-newbie to attach debug code and that is what happens...
Lessons have been learned, I need to look over the code more often again.


@rpatterson nothing to worry about, that was jenkins.plone.org (using my account) that automatically reports to **all** branches when you start monitoring a github repository.


same here, is copy of the value enough ?


.vendors


And the cleanup is already in a pull request: #22


Соответственно тут скорее .vendors-popular


Та же история с .item и href что наверху.


The docs seems not right ;)


Finish read-me


isort parses it with configparser so I guess is totally safe.


Why is this reverted?


This is only called once *ever*. We are calling this function *for every required path* actually, so this one call can't account for any kind of slowdown.


It's possible to cross-build images for ARM on a `amd64` host, using `qemu`: https://resin.io/blog/building-arm-containers-on-any-x86-machine-even-dockerhub/
Maybe one could add
```
export DEBIAN_IMAGE=armhf/debian:jessie
export UBUNTU_IMAGE=armhf/ubuntu:15.04
```
or something to `.arm.docker.env` and remove the `.sample` at the end
And in the same way add a `.amd64.docker.env` with `amd64` values.


ну а li можно задать класс .product и у последнего li будет модификатор, потому что в макете на нём стоит отметка New - т.е. надо будет ему дополнительно повесить класс .product-new


Я бы тут сделал так:
< li class="product product-new" >


Have a look at how the other group is linking their images.
[Parsnip Example](https://raw.githubusercontent.com/FabLabWgtn/Parsnip/gh-pages/_posts/2015-01-22-test.md)


Если мы добавим li класс .product то здесь можем все классы переписать на более  короткие - product-name, product-price и так далее.
Ведь по-сути у нас где-то будет список обычных товаров (не обязательно популярных) и в плане вёрстки их карточки врядли будут отличаться. Т.е. карточки товаров - просто описывают товар, а не популярный товар. Популярный товар - это просто выборка из всех товаров, отфильтрованая по критерию популярности.


just use TIME_REPRESENTS_DEFAULT_TIMESTAMP ? It can be used for any time stamps for any entity.


Hi, sorry about taking forever to review this.

Unfortunately, it seems you've modified the built `dist` files directly, instead of the source in `L.Routing.Localization.js`.

Would it be possible for you to fix this? Improved localization is of course always very welcome.


если мне память не изменяет, то у тебя в проекте папка для картинок называется img/ а не image/


I like this simplification. I don't understand why I should not support it considering that fully removes an evaluation layer.


May have broken "statusbar lock in secure lock screen". It's no longer working.


Это просто абзац текста, b - для особо выделенного текста, тут она не нужна. Во всём макете это самый мелкий и базовый шрифт.
так что вёрстка такая примерно должна быть:

    Хороший интернет-магазин отличается от плохого не только ценами!
    Мы стараемся изо всех сил, чтобы сделать ваши покурки приятными.


Это просто абзац текста, b - для особо выделенного текста, тут она не нужна. Во всём макете это самый мелкий и базовый шрифт.
так что вёрстка такая примерно должна быть:

    Хороший интернет-магазин отличается от плохого не только ценами!
    Мы стараемся изо всех сил, чтобы сделать ваши покуРки приятными.

/* после открывающей скобки тега я поставил пробел, чтобы гитхаб теги не съедал.
Тебе так не надо делать ))) */


So no more full browser swipe to go back on iPad using the in-app browser?


I don't like you will, you will.  Sounds like order.


тогда уж .services-button-1-content
Но я бы сделал просто .delivery


I think this paragraph is too verbose after my edits but the original data miss some content too.


@Bjornadal / @Jore ... have you got an open issue, or JSFiddle to help demonstrate this? ... I would like to see if I can get to the bottom of it...


update read-me


sdofus


Дим, немного запутался в гитхабе, делал много коммитов и не уверен, что коммитилось и все же дошло до центрального репозитория, а что нет. В любом случае, это версия к проверке


注意命名规范问题，类的方法应该是驼峰命名


Double taps no longer work. Why was gestureRecognizer gutted? It doesn't show in this commit log but wasn't all of this necessary for gestures?

```
-//    NSLog(@"Gesture: %d - %d", (unsigned long)touch.tapCount, gestureRecognizer.state);
-    inDoubleTap = (touch.tapCount == 2);
-
-    CGPoint pt = [self pointForGesture:gestureRecognizer];
-    if (pt.x == CGPointZero.x && pt.y == CGPointZero.y) return YES;
-//    NSLog(@"Tapped point: %@", NSStringFromCGPoint(pt));
-    NSString *tagName = [webView stringByEvaluatingJavaScriptFromString:
-                         [NSString stringWithFormat:@"linkAt(%li, %li, 'tagName');",
-                          (long)pt.x,(long)pt.y]];
-
-    if ([tagName isEqualToString:@"IMG"] && !inDoubleTap) {
-        return NO;
-    }
-
-    if (inDoubleTap) {
-        self.webView.scrollView.scrollEnabled = NO;
-        [self performSelector:@selector(deferredEnableScrolling) withObject:nil afterDelay:0.0];
-    }
-
```


Just learning how to use github.


@saily Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.recipe.codeanalysis/2//violations
```
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/__init__.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/__init__.py:0:1: I001 found unsorted imports
plone/recipe/codeanalysis/__init__.py:200:13: T001 print function found.
plone/recipe/codeanalysis/__init__.py:210:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:219:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:252:9: T001 print function found.
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/analyser.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/analyser.py:0:1: I001 found unsorted imports
plone/recipe/codeanalysis/analyser.py:58:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:65:13: T001 print function found.
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/clean_lines.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/clean_lines.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/csslint.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/csslint.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/flake8.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/flake8.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/imports.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/imports.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/jscs.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/jscs.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/jshint.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/jshint.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/python_utf8_header.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/python_utf8_header.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/tests/test_cleanlines.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/tests/test_cleanlines.py:0:1: I001 found unsorted imports
plone/recipe/codeanalysis/tests/test_csslint.py:28:13: P103 other string does contain unindexed parameters
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/tests/test_docs.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/tests/test_docs.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/tests/test_hasattr.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/tests/test_hasattr.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/tests/test_i18ndude.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/tests/test_i18ndude.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/tests/test_imports.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/tests/test_imports.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/tests/test_jscs.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/tests/test_jscs.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/tests/test_jshint.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/tests/test_jshint.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/tests/test_tslint.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/tests/test_tslint.py:0:1: I001 found unsorted imports
plone/recipe/codeanalysis/tests/test_tslint.py:31:0: P103 other string does contain unindexed parameters
plone/recipe/codeanalysis/tests/test_tslint.py:34:0: P103 other string does contain unindexed parameters
plone/recipe/codeanalysis/tests/test_tslint.py:37:0: P103 other string does contain unindexed parameters
ERROR: /home/jenkins/workspace/package-plone.recipe.codeanalysis@2/plone/recipe/codeanalysis/tests/test_zptlint.py Imports are incorrectly sorted.
plone/recipe/codeanalysis/tests/test_zptlint.py:0:1: I001 found unsorted imports
```
You can run that yourself using buildout.coredev ``experimental/qa.cfg`` config file.


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.recipe.codeanalysis/4//violations
```
plone/recipe/codeanalysis/__init__.py:172:13: T001 print function found.
plone/recipe/codeanalysis/__init__.py:187:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:196:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:243:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:59:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:66:13: T001 print function found.
plone/recipe/codeanalysis/entry_points.py:20:13: T001 print function found.
plone/recipe/codeanalysis/entry_points.py:22:9: T001 print function found.
plone/recipe/codeanalysis/tests/test_csslint.py:24:0: P103 other string does contain unindexed parameters
```
You can run that yourself using buildout.coredev ``experimental/qa.cfg`` config file.


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.recipe.codeanalysis/5//violations
```
plone/recipe/codeanalysis/__init__.py:172:13: T001 print function found.
plone/recipe/codeanalysis/__init__.py:187:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:196:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:244:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:59:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:66:13: T001 print function found.
plone/recipe/codeanalysis/tests/test_csslint.py:24:0: P103 other string does contain unindexed parameters
```
You can run that yourself using buildout.coredev ``experimental/qa.cfg`` config file.


@do3cc Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.recipe.codeanalysis/3//violations
```
plone/recipe/codeanalysis/__init__.py:172:13: T001 print function found.
plone/recipe/codeanalysis/__init__.py:187:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:196:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:243:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:59:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:66:13: T001 print function found.
plone/recipe/codeanalysis/tests/test_csslint.py:24:0: P103 other string does contain unindexed parameters
```
You can run that yourself using buildout.coredev ``experimental/qa.cfg`` config file.


hey sorry for the late reply. `update` runs "updaters" to keep a project up-to-date with your latest preferences and conventions. I'm about to push up major refactors for verb, generate and update. Wait until that's done before you spend time on verb. (fwiw, the code I'm about to push up is the most exciting thing I've worked on, ever. It's going to be fun :)

I've been working on [base-generators](https://github.com/node-base/base-generators) (project generators, not es6). The goal is to use `base-generators` to enable verb, update, generate and assemble to all have "generators".

Here's how it will work:

1. If the `verbfile.js`, `assemblefile.js`, `updatefile.js` etc exports a function, it can be used as a "generator"
2. generators can be globally installed (or in local `node_modules`), and optionally have sub-generators and/or be composed with other generators

The `generate` lib will have richer built-in project generator functionality, while the other three projects will have generator functionality that is distinguished by the types of things they do (verb builds project docs, assemble builds web projects, etc).

The goal is to allow assemble, verb and update to run `generate` generators, but not the other way around.

I'm running this all locally, can't wait to share this with my friends on github!


ok


Looks mostly good, though take a round of clang-format, also some more newlines would make the code less annoying to read (like you've done in the `case LOGIN` section already).

It should also reuse the QNAM used by the rest of the program.

`m_window` is never used. Take a look at the includes in general (`QtCore/qfile.h`, `QMessageBox`, `QBuffer`, `QtCore/qurlquery.h`, `QtNetwork/qhttpmultipart.h`).

`skinData` should probably be passed in as a std::unique_ptr since this class indirectly destroys it.

I wonder if it might be worth extracting the website login part. Are there any other things on their site that we might want to interact with in the not too distant future?


Ah-ha, if its just the folder selector then this would be fine.


The folder selector needs to be scrollable, by the way. I have way more folders than vertical space.


Changing to GPL makes sense as Affero isn't really relevant to things that aren't software-as-a-service.  Could you clarify which version of GPL you're placing the source under?  Popular options include:
* GPL 2
* GPL 2 or later
* GPL 3
* GPL 3 or later


Такие штуковины обычно называют Табами - они работают примерно аналогично вкладкам в браузере.
Так что я бы этот список, с кнопками для переключения, и список с контентными блоками обернул бы в ещё одного родителя, дал бы ему имя .tab
Дальше список с кнопками назвал бы .tab-controls, только я бы наверное тут использовал не кнопки, а ссылки с якорями на айдишники табов.
А список с блоками содержимого - .tab-content
И внутри .tab-content Были бы .tab-1 .delivery   .tab-2 .guarantee  .tab-3 .creadit  и всем им дал бы айдишники, на которые бы привязал управляющие ссылки.

Вот можешь посмотреть на типичную реализацию таба в bootstrap[она работает не без помощи JS , конечно]:
http://getbootstrap.com/javascript/#tabs

Вообще я думаю в одном из последних вебинаров будет подробно разобран способ как сделать табы на CSS.


замени на ~3.0


Здесь тоже абзац.


Prefix 'the' for variables is not common for our codebase. Please considrer dropping it.


Are premium fonts working as well?


It was moduleComp previously, is this childComp now? Is this correct?


@sledgehammer999 I've added proto to log message. Example:
>qBittorrent failed listening on interface 127.0.0.1:6881 [UDP]. Reason: No such device.

I think it is enough to begin. I don't want to mess with `operation` (honestly, I don't want at all).


Marco, I think Joerg was being serious...


Even if m_window was used, there should be no use of GUI related stuff in the logic library.

There still are a few such things in it (use of QDesktopServices, for example). But I'd like to get rid of them soon.


Two things: we use spaces in boolean comparision "p > 0" and second: tenary operator would be more readable here.


У тебя в фотошопе в папке слоёв service есть три папки, две из них скрыты - там как раз содержимое оставшихся двух блоков нарисовано. Надо это заполнить


сеттеры использовать в принципе тоже плохая практика, позволяет модифицируемому объекту гулять по разному коду. а это плохо, т.к. код становится очень хрупким.


This part gets more complicated now. Please provide a unit test for this with at least two situations: one-level and multi-level directory.


внутреннее состояние объекта надо стараться всегда делать файнал.
http://stackoverflow.com/questions/137868/using-final-modifier-whenever-applicable-in-java


@martinheidegger I'm so happy to see that my stuff is used by NodeSchool. :grin:


This does not work in Postgres, since PGSQL has no such function.


Isn't that supposed to say SoundScrape instead of SoundCloud?


Это должен быть абзац, блочный тег P а не строчный b.
Саша в вебинаре исопльзовал< b> для коротенького куска текста, который не был целым предложением, и не был заголовком, просто макете был сделан крупно и жирно, т.е. был важен с точки зрения оформления.
Если у тебя есть целое предложение - его по-любому нужно обернуть в < p>, и если внутри этого предложения есть выделенные слова - тогда их можно обернуть в < b>


dsafadfafadad


asdfasfdaf


Это тоже абзац. И если у тебя открывающий и закрывающий теги на разных строках - то они должны быть на одном уровне, в смысле отступов.
Т.е. у тебя тут с точки зрения читабельности должно было быть так:

    Мы можем доставить ваш товар в самые отдаленные точки России!

    Техномарт работает со многими транспортными компаниями:

А с точки зрения правильной разметки вообще вот так:

    Мы можем доставить ваш товар в самые отдаленные точки России!

    Техномарт работает со многими транспортными компаниями:


bad code


aaa


bbb


You might meet bootloop(CPU cannot online anymore) with this commit.
I reverted commits related to this.
https://github.com/Dev-in-Advance/android_kernel_samsung_apq8084/commit/32ed734fabdcd6351a26cccf264f50ad5f7a318a
https://github.com/Dev-in-Advance/android_kernel_samsung_apq8084/commit/fc74d4004bdda85ee2664de76639804bb918554d
https://github.com/Dev-in-Advance/android_kernel_samsung_apq8084/commit/4afada164fc5a7e1e981870459b9a7c9374bb16c


Этот список выглядит достаточно нетривиально, возможно где-то на сайте он понадобится ещё не раз, так что лучше ему дать какой-то особый класс, например .list-important


@rjmccall Can you review this if you have the time?

This code really needs some refactoring, renaming, and commenting, but for now I've done a targeted fix for this specific bug.


Вариант. А можно ещё более понятно - .about-us


I tried as you said , and it was run good.
Thanks Levak


Full code


Тут этот класс не нужен, либо переименуй его как-то более очевидно


ok


Лучше переименовать в CollectionPrinter. (Имена классов должны быть существительными. )
Почитай про именование классов вот тут:
http://ru.stackoverflow.com/questions/168987/%D0%9F%D0%BE%D1%87%D0%B5%D0%BC%D1%83-%D0%B2-java-%D1%80%D0%B5%D0%BA%D0%BE%D0%BC%D0%B5%D0%BD%D0%B4%D1%83%D0%B5%D1%82%D1%81%D1%8F-%D0%BD%D0%B0%D0%B7%D1%8B%D0%B2%D0%B0%D1%82%D1%8C-%D0%BA%D0%BB%D0%B0%D1%81%D1%81-%D1%81-%D0%B1%D0%BE%D0%BB%D1%8C%D1%88%D0%BE%D0%B9-%D0%B1%D1%83%D0%BA%D0%B2%D1%8B


Метод стоит переименовать в print


OK, that seems reasonable :-) Let's merge it!


Corrected


href потерялся.  Лучше .company-details  или .about-us-more


then は無くても動く


What was the bug?


В Коллекции есть дженерный тип. Его здесь тоже стоит использовать вот так:
public <T> T void print(Collection<T> collection) {
for(T obj : collection) {...}
}


bad code


Hi, just to let you know: Alpaka can mix shared mem / vectorization. Each level of parallelization that does not exist on a certain hardware can be serialized by adjusting the mapping to the hardware and the work division.
On CUDA hardware only little vectorization gives performance increase  (2 elements) while on CPUs 128 elements make sense.


Класс .item меняем или убираем. b меняем на абзац, делаем аккуратные отступы, картинки у нас в папке img/  кнопку .item-button тоже переименовываем
:)


Зачем тебе здесь сеттеры? сделай все поля final и поудаляй сеттеры.


Done


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13739](https://teamcity.mesosphere.io/viewLog.html?buildId=119120&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:08:15


Логотип будет сделан средствами CSS, так что Img можно смело убирать.


You may want to consider this change to be a breaking change for those that do not want 4.6.1 installed.  The version number needs to be updated to reflect that.


Added readme.txt
yo?


А где ссылочки?)


Либо абзац, либо отдельно span и b


Removed


Bad code


htmlacademy.ru Должен ссылаться на сайт академии, оберни в ссылку


@items.find{|item| item.name = name}
@items[find]
としたほうが簡潔です。


Corrected. Used a separate class for this image.


изменяемые коллекции делать паблик очень не хорошо.
Во-первых, поле должно быть final (чтобы никто снаружи не подменил тебе ссылку на коллекцию)
Во-вторых, коллекция должна быть неизменяемой (immutable). для этого в джаве, наример, коллекцию можешь обернуть в Collections.unmodifiableList(твоя коллекция). Тогда уже никто использующий объект MusicShop не сможет случайно модифицировать коллекцию. (будет выброшен иксепшн о том, что коллекцию изменять нельзя)


Could you please add the .nuspec file how you want it so others can easily make new NuGet files for inclusion into other projects without a dependency of you uploading it to Nuget.org?


С обёрткой та же история что на главной странице. Общая обёртка для всего сайта не прокатит. Нужно делать её внутри каждого блока отдельно.


обе коллекции должны быть аргументами конструктора.


Надо описать выше динамику, которая используется для траекторий


вот это о чем я говорила. Здесь ты должен создать коллекцию из инструментов и только потом засунуть их в MusicShop. а так у тебя недоинициализированный MusicShop в середине программы.


то же самое касается и этой коллекции.


Я бы объединил первые две ссылки, которые видны когда пользователь не залогинен - в блок .user-unlogged и в данный момент на нём должен висеть класс .is-hidden или .hidden
А ту часть которая сейчас видна обернул бы в блок .user-logged


Dave, you read my mind. Was going to suggest doing this!


Good Code


названия полей очень плохие. представь что это будет читать другой человек -- очень тяжело ему будет)
лучше называть полностью -- musicalInstruments.


Надо описать, что за вес. Т.е. ввести какой-нибудь значок для критерия и указать, что сейчас, для моделирования, используется сумма абсолютных отклонений


Тут не нужна ни ссылка ни картинка, это будет сделано фоном псевдоэлемента твоей ссылки a.username


The idea with using `os.path.join` was to make it OS agnostic. However I suspect there may be other parts  in the code base that does not run on Windows. :smile: . Still, the isn't the IPC path always an OS path?

While I prefer to pass values around -- it increases testability -- I've now changed the solution so that it saves the value in `Bot`. I mean, we don't test this code anyway -- right? :wink:


Тут тоже не нужна картинка, это будет сделано фоном, но ссылку можно оставить.


@cmelchior It's now fixed as you pointed. An issue is, I have now a constructor throws `RuntimeException` ugh...
This is done b/c 1) `TableQuery` has a `final` reference to `TableView`, and 2) we can sequentially close a native view in case something goes wrong in `getCopy()`.


ой, а зачем здесь аж 2 поля? достаточно какой-то одной коллекции. в данном случае у тебя ограничение на сортировку -- можно оставить sortedset только


зачем оставлять комментарий //1method если можно просто эту длинную колбасу вынести в метод ?)
то же самое касается комментария //2 method
оставляй комментарии только в самых необходимых случаях. чаще всего наличие комментариев в коде признак того, что что-то нужно переименовать, выделить метод, улучшить читаемость


I am serious too : I like this patch


Good job with this, you did it better than I could, that's for sure.


extends Object писать не надо. все классы в джаве экстендят обджект)


если элемент внутри коллекции налл, то здесь уадет NullPointerException
нужно делать String.valueOf(element)


I've had 4 people contacting me with issues because they ran it shared


@mcostalba Marco, there was really no sarcasm nor any pun intended. I just remembered a comment of yours when the Threat weight was being removed. Hence the twinker ...


This brings problems #12710.


Checks for two consecutive characters "=>" (instead of checking for just ">")


what for do need get topic? I thought you need only "redirect". TopicId you can get from url. So you don't need to fix TransactionalTypeAwarePluginTopicService.java and spring-dispatcher-servlet.xml


Ойойой что-то тут совсем не то. Коллекция TreeSet читал как работает?
http://stackoverflow.com/questions/7776203/java-using-treeset


Yay!


Сортировку необходимо выполнить встроенной коллекцией в джаве.
http://stackoverflow.com/questions/7776203/java-using-treeset


Какой же это getFile, если это getFiles?


You could simply `m_dismiss(std::exchange(rhs.m_dismiss, false))` :smirk:


Вместо этого можно испольхзовать Arrays.asList(files)


TeamCity LabKey :: Trunk :: Community :: CDS postgres 9.5 [Build 84](https://teamcity.labkey.org/viewLog.html?buildId=300143&buildTypeId=LabkeyTrunk_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 15, passed: 33 Build time: 01:06:11
### Failed tests
```
org.labkey.test.tests.CDSSecurityTest.verifyUserPermissions: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyCounts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterPane: <no details avaliable>

org.labkey.test.tests.CDSHelpCenterTest.verifyHelpCenter: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

##### there are 5 more failed tests, see build details
```


сеттер здесь не нужен.


If we get topic with invalid type, this method throw error.  without it we can get topic at "/topics/anystring/topicid"


Done


Почему статический?


Thanks @AlbertoFuente


Whoops, changing this line is actually not necessary - I was getting fooled by trying to run `make check` in a build tree where I ran `./configure` before having `g++` installed.


Have you tried mali as built-in module?


I deleted all *.ko and the phone is fully functional!


Without fix I get http://localhost:8080/topics/question/7 I get http://localhost:8080/topics/7 with enabled QnA plugin


OH!!!
So the build process is no need to get modpost
But needs editing init.vivalto3gvn_base or scx15 to remove that insmod


Да, верно. Вот только конструкция "this->" здесь и во всех остальных местах этого файла избыточна.


I will cleanup those *.rc files some day...


Саша в вебинаре сказал что все кнопки сортировки лучше сделать ссылками, думаю это на защите проекта может усложнить жизнь всем тем кто сделал баттонами, так что имеет смысл переделать эти кнопки в ссылки.


Во всех базовых классах(Observer, Subject, DisplayElement) должны быть виртуальные деструкторы!


тогда уж .sort-py-price  .sort-by-type .sort-by-function , а последние две стрелочки я бы объединил общей обёрткой .sort-direction и там были бы .sort-direction-up и .sort-direction-down


`no changes` implies that there where no changes made, which is not true. It is possible that a developer did some changes in the Drupal and now want's to export them, but it is possible that these changes are already reflected in the export directory and so the message is wrong. With saying that there are no differences between the active and export directory it is clearer


Thank you.


thanks!

if you want another relatively quick project, eventually i wanted to just run this every 5 minutes (all the time) and convert ocf-suspend to Python and use ocflib to determine if the lab is open or not.

so the new ocf-suspend would just check if the lab is open at the top and exit if so, otherwise try to suspend (with similar checks to make sure we don't suspend while users are logged in or apt is running).

there's an actual benefit (not just a bash -> python micro-benefit): there's a file pestilence:/opt/ocf-nowakeup which we're supposed to create/remove when breaks start/end, but frequently we forget and we waste power with machines running over winter break. (I only remembered 1.5 weeks into break unfortunately this time, and just remembered to delete it now.)

it's currently only used in lab-wakeup on pestilence
https://github.com/ocf/utils/blob/master/staff/lab/lab-wakeup

ideally that would use ocflib as well


There is no tracking at all happening between exports, so this is wrong.
Example:
1. Developer exports config adds to git
2. Developer pulls changes from git remote, some changes in the config directory happen
3. Developer exports again, developer assumes that the message `no changes since last export` appears, because he did no changes in the active directory, but actually there are changes. Result: confused developer.
So we remove the `since last` completely and just say that there are differences between active config and the one in the export directory.


it's true, the export directory will be deleted, but also overridden again with the current active config. Had situations where developers stopped a config-export because they where worried about loosing something.


[Netmera] (http://www.netmera.com/) Cloud based mobile customers engagement platform. Provides Push Notifications, In-App Popups, Geolocation, Beacon Management, Users' Segmentation and Targeting, Users Engagement Analytics.
![netmera 7](https://cloud.githubusercontent.com/assets/16984262/12701275/6795aaa2-c7fc-11e5-89e4-ea6b0f5ae798.jpg)


Remove AwesomePinch, @OutOfYourMind


Очень советую использовать ключевое слово "override" при замещении виртуальных функций и тогда ключевое слово "virtual" лучше опускать.


if you do convert it we also usually prefer the puppet cron type:

```puppet
cron { 'lab-wakeup':
    command => '/usr/local/sbin/ocf-suspend',
    minute  => '*/5',
}
```

this is old code that I don't think i've even touched

and then you don't have to make the file in `/etc/cron.d` at all.


@renfredxh looks like CI has been breaking since this commit?


神


What does this do?
https://github.com/m-labs/artiq/blob/d05d720b19a5fc65f000c373bf011f9f218925b5/artiq/test/hardware_testbench.py#L49


lol


Ok, sounds like a good idea, I'll try and work on that. Also thanks for your write-up, that's a lot to work with.


У нас в макете слово фильтр - в блоке, это видно по тому как вокруг неё располагается фон.
Т.е. надо использовать блочный тег, например div.catalog-filters-caption
И да, кстати сказать name тут тоже не очень говорящее название класса, во первых оно слишком общее, и можно случайно цепануть лишних стилей отуда-то еще, и кроме того name - больше подходит когда мы хотим сообщить имя какой-то конкретной сущности, конкретного объекта, а не название обобщающей абстракции.
[ у нас блок Фильтры Каталога - это абстракное название, для группы конкретных фильтров, и слово Фильтр это не его имя, а скорее описание того, что в нём находится.]
Короче для названия абстракции лучше использовать слово .caption :)))


This is not the cause of deadphone, but just leave this here because it have the same values as in Settings anyway.


Do not use ``terminate`` on Python process objects, it is not portable. The only things that are portable are:
* requesting termination through the usual communication channel
* the ``kill`` method of process objects

You should put this RPC termination request into ``stop_controller``, to replace ``proc.terminate``.


looks good as far as i can see.
Just a little note: In the hashCode and equals method you can directly assess key and value instead of using the getters.


Что то тут не так, не подставляется значение, возможно на этом этапе еще не работает связь?


I thought the problem was with the Silverlight build, not the NETCF build?


я бы транслитом написал имя, всё-таки оно в бэкэнд пойдёт.


Обьяснение: зачем я это сделал?


lkknlkjnl


follow code style


Thanks for the catch Mario, just fixed the issue with the button in weather.

About the RSS line. Can you send me a skin backup so I can test this on my machine ?


can be simplified to "return ports.contains(port) && cangame;"


No need to allocate a variable, just ```return game.canPlayDevelopmentCard(playerID, dc);```


can be simplified to ```return cangame && canmap;```


simplify to ```return playerID == turn;```


.catalog-products-list т.к. item это один элемент из группы элементов. А у тебя список. Но вообще я бы наверно оставил тут ul без класса, а li задал бы класс .product, и чтобы вёрстка карточек продукта была такой же как и на главной странице.


simplify to ```return cangame && canmap;```


Without these two improvements this code does not work. Controllers have to be set  in each case.
`Router.route('/new/:postsLimit?', {
  name: 'newPosts',
  controller: NewPostsListController
});`
and
`Router.route('/best/:postsLimit?', {
  name: 'bestPosts',
  controller: BestPostsListController
});`


controller: BestPostsListController


thats a big ass commit :8ball:


controller: NewPostsListController


@Simn I'm getting an error on php which does not seem related, is it some regression with haxe devel ?


Почему не используешь "умные указатели"? С их помощью и delete самому не нужно вызывать и в случае возбуждения исключения память корректно освободится. Вот так же намного лучше:
    auto weatherData = std::make_unique< WeatherData >();
    auto currentDisplay = std::make_unique< CurrentConditionsDisplay >( weatherData.get() );


:heart:


Вместо этого дива с классом sticker у тебя просто будет на li иногда навешиваться дополнительный класс, типо .product-new и он будет добавлять фоновой картинкой надпись New
Так что удаляй этот дивак.


I think it's better to settle on one way of specifying the values.  Personally, I'd go for 0-255.


cool :+1:


Эти две кнопки лучше обернуть в общую обёртку, придумать ей подходящее название, и дополнительно повесить класс .is-hidden т.к. у этого элемента кнопки пока не видны


Для чего этот метод, если вместо него можно сразу вызвать "notifyObservers"?


Das hatte ich in develop schon gefixt in ad74c0a25d142eadcd16006ddae44219ec4fb4cd


right, but this is small and acceptable disadvantage of Local dates. Maybe I'll add this information to JaVadoc.

In SQL databases there is no standard for storing zoned timestamp.
Local dates have many advantages in non-distributed systems...


I think I figured out the RSS issue... I am using 1 row small tiles and that seems to disable RSS.
Just tested with 2 and 3 rows small tiles - same issue.... RSS doesn't display.

do you see this same behaviour on your system with small tiles on home?


感觉这块的翻译没有强调出后者更好一点。
`但更好的做法是我们我可以将所有的都只实现一次，然后将实现好的代码。。。。`
觉得这样翻译会更好一点。


You're totally right!


I will take a look later today once Im back home


不知道你文章接口的意义何在 :joy:


It should be enough to copy the value, yes


**SUCCESS** - TeamCity HotRod C++ Client :: Pull requests monitor - RHEL [Build 353](http://ci.infinispan.org/viewLog.html?buildId=34713&buildTypeId=HotRodCpp_PullRequestsMonitorRhel6&guest=1) for 01582fca79a75e550f577c2123d6de885aac0c93
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:08:49


It is set, but to an old value that might be invalid during `toggle_off()`. See issue  #394.


Will be added manually.


hostPath, nfs, and gluster volume types all call this `path`, rather that `subdir`.


ok that's perfect !
have a good day

> Christian Hermann <mailto:notifications@github.com>
> dimanche 31 janvier 2016 09:55
> New language
>
> - Added france translation (@didihu)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/bitbeans/SimpleDnsCrypt/commit/8d5f1cca4ad32217a1088e087730ac18f99f13db
>

--
Envoyé avec Postbox
<https://www.postbox-inc.com/?utm_source=email&utm_medium=siglink&utm_campaign=reach>


A strange commit and author is a strange guy, never heard of him.


adding multiple checks and scenarios


这块好像少翻译了一句
`so that its first parameter is the object we read p from and the second parameter holds a description of p itself`


dont make this optional, just make default 0


no rush - it was just bugging me that I hadn't found a cause - now that I think I have it doesn't :-)


:+1: Nishant, Looks good.


Feel free to fix the text.


This is related to issue #36. It at least makes sure that the script won't crash and will be able to continue if the notes are rewritten.


RoboCar
RoboCar project is to create a small car driven by another way than using wire.

This project is based on the Arduino platform and its aim is to encourage more people to develop the device. The goal is to use only commercially available components and show what one can build.

Gradually will be edited description and instructions for development.

At this time it is controlled via the RC, and the driver reacts to the distance of obstacles ahead of the vehicle. .

The project consists of a chassis, Arduino Nano, RC transmitters / receivers, managing H bridge motor control and ultrasonic sensors,

In the future, the car had driven over wifi. The plan is such that it will generate the web page. through which the car will be controlled. This will on the one hand, ensure easy connection and on the other hand, the management multiplatfom. In the future it is planned to have a camera and solar panels, and more.


Если посмотреть внимательно, то кнопка с текстом не отличается от кнопки с цифрами, просто у неё содержимое длиннее. Так что тут тоже .btn-light


hscript travis fails on 3.2.1 too so it doesn't look very regressive.


//这是啥意思？


Указывать цвет дизайна в классе элемента - это слишком специфично. Я про .btn-red
Вдруг дизайнер в какой-то момент решит перекрасить все эти кнопки в синий? В css это будет сделано заменой 1 строки, а тебе потом придётся по всему html бегать и менять название класса на .btn-blue
Так что придумай какой-то другой вариант модификатора...