done.

On Fri, Jan 15, 2016 at 11:57 AM Spencer Kimball <notifications@github.com>
wrote:

> s/old/orig/
>
> s/creates the correct diff which cancels out the age contributions in the
> time the old key was live./ages those original stats by the time which the
> previous version was live./
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tschottdorf/cockroach/commit/005d7430e4f63aa5b92175f63b963046826d8ea2#commitcomment-15479054>
> .
>


POC: `var f = require('floody')(process.stdout); f.write(1000); f.stop();`.


why?

Not really for a purpose at all actually. I think I did it as my first code
was passing a pointer to pidProfile struct initially and at the end I
realized I only needed one variable and stripped the rest without thinking
about this.
Op 15 jan. 2016 14:30 schreef "Konstantin Sharlaimov" <
notifications@github.com>:

> Why pointer to gyro_lpf_hz?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/borisbstyle/betaflight/commit/93d917af3b97ce218046c312914cd037c58d6130#commitcomment-15474507>
> .
>


done


Feel free to pullreq that change.


Man, you're good at this...


You're thinking of ```AC_DEFINE```.  ```AC_SUBST``` substitutes @var@ instances.  Anyway, unless there's a need for the variable, I prefer not to clutter the build system any more than it already is.


this class got deleted in the next commit.


Would you mind changing S.R.S.Xml to be the 4.1.0 dependency in this PR to fix #462?


@tripolar can you bump openssh in for-15.05 as well?


where can you set them? I only found ```Product>Build For> ...```, but none of the above.


this is fixed by moving the method to AlignmentContext


@fxn Looks like a syntax error in the markup. There should be a `[` before `@j0el`.


Probably this should have been in the previous commit.


After upgrading to 2.49
<addr>class FunctionalTest(StaticLiveServerTestCase):
    @classmethod
    def setUpClass(cls):
        super().setUpClass()
        cls.b = webdriver.PhantomJS()
</addr>
Gives me an error:
<addr>
Exception ignored in: <bound method Service.__del__ of <selenium.webdriver.phantomjs.service.Service object at 0x7f57b5343080>>
Traceback (most recent call last):
  File "/home/kano/.virtualenvs/kam/lib/python3.4/site-packages/selenium/webdriver/common/service.py", line 136, in __del__
  File "/home/kano/.virtualenvs/kam/lib/python3.4/site-packages/selenium/webdriver/common/service.py", line 124, in stop
AttributeError: 'NoneType' object has no attribute 'close'
</addr>


Why not a normal for loop:
```
for (; n_labels > 0; n_labels--)
```
?


Thanks for adding these.  Can you change "4.2" and "5.4" to just "4" and "5"?  That way, Travis CI will automatically use the latest releases of those major versions


It would be nice if this was reversed but I will merge.

Also

if foobar:

if foobar not none:

Are the same thing.


When does this exception happen?
Could you please attach the tracebacks?


LGTM.


Thanks !


Added the message as "prestoPrivileges is null". This is consistent with code at other places, where the message in `requireNonNull` is of format: "<variable name> is null", irrespective of whether the variable represents a collection or a single item.


cleaned up


cleaned up the class


You have no idea what this does? Do you? Don't revert my commits -_-


s/existance/existence/ (not worth changing the commit on it's own of course...)


TeamCity LabKey :: LabkeyRelease15.3 :: Git postgres 9.4 [Build 124](https://teamcity.labkey.org/viewLog.html?buildId=297129&buildTypeId=LabkeyRelease153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 45, passed: 243 Build time: 00:50:23
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyInfoPaneCounts: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

##### there are 35 more failed tests, see build details
```


this was fixed in the next commit


fixed in next commit


Why not create a variable for this?


@SubJunk I agree that it's not nice if the tooltip spans the width of the screen. I'd wish the tooltip's were a bit "smarter" when sizing itself, but that's beyond the scope of this issue. The disadvantage of using ```<br>``` is the translations, the translators basicly have to "guess" where to put them and won't see the result of their placements until the next release. Then they have to correct it, and wait till the next release again... it goes without saying that not many are going to get it right. But, for now I guess there's no better way.

Just as an idea to explore sometime in the future, maybe we could manipulate the tooltip's stylesheet to be a certain number of ```em``` wide and in that way support both font scaling and a way to improve line wrapping behaviour. I don't know css that well, but you can define a width for the body right?


Yeah, as far as I can tell, _set_data_from_doc() returns false iff there's any invalid json while parsing the file. So this change currently just causes the whole file to stop functioning. A better way to do it would be to have the specific line break only. For example if one message were corrupt, then it would replace that line in the rendering that said "This message was corrupted for some reason".


TeamCity LabKey :: LabkeyRelease15.2 :: CDS postgres 9.4 [Build 28](https://teamcity.labkey.org/viewLog.html?buildId=297131&buildTypeId=LabkeyRelease152_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 22 Build time: 00:37:23
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

```


Great patch!


this class is now removed


:tada:


should be addUserFlags such as method with an Iterable param.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11700](https://teamcity.mesosphere.io/viewLog.html?buildId=105999&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:03:54


@leizhangcn Would it be clearer if this returns a float vector instead of string?


Ok, since I found a file conflict, but already fixed that one ... Go on.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11701](https://teamcity.mesosphere.io/viewLog.html?buildId=106007&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:10


reduce_redimensions (mbadams5) - x86_64-MacOS-10.9-clang: Tests Failed (1555 of 2050 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-75.85%25-red.svg)


this whole class is now gone. I wish I knew you'd be reviewing commit by commit rather than the whole PR or I would have squashed commits


done


I like sucking dick


`ImmutableSet.copyOf`


ASIHPdev (shenb) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I am a homosexual who does not have the courage to tell my parents


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


reduce_redimensions (mbadams5) - i386-Windows-7-VisualStudio-12: Tests Failed (1549 of 2056 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-75.34%25-red.svg)


Hi -- I think this change should be accepted and go in, but not close the
ticket.  Then the better way that you described should get implemented.

On Fri, Jan 15, 2016 at 12:52 PM, John Jeng <notifications@github.com>
wrote:

> Yeah, as far as I can tell, _set_data_from_doc() returns false iff there's
> any invalid json while parsing the file. So this change currently just
> causes the whole file to stop functioning. A better way to do it would be
> to have the specific line break only. For example if one message were
> corrupt, then it would replace that line in the rendering that said "This
> message was corrupted for some reason".
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sagemathinc/smc/commit/d7a14983a5828f606f8386a5819654a053368573#commitcomment-15483956>
> .
>

--
William (http://wstein.org)


Is this ported from kiwi-java or the kiwi-cpp?


When this may happen? We may need an Exception.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11702](https://teamcity.mesosphere.io/viewLog.html?buildId=106008&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:00


Sure, done :muscle:


The returned value is a byte array. We can use vector<byte>, but string can be more handy as it is required by datum.set_data(...).


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11703](https://teamcity.mesosphere.io/viewLog.html?buildId=106011&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:15


Yay switchable Theme :)


TeamCity Open-source Libraries :: ConfigInjector :: CI [Build 2.0.453.0](http://build01:8888/viewLog.html?buildId=13831&buildTypeId=ConfigInjector_CI) is now running


static import first


Hi,
When we can expect new version for Chrome and Opera?
Extension doesn't work in latest Opera Developer ("Error in event handler for browserAction.onClicked: TypeError: app.Promise.defer is not a function"), version 0.6.0 either any older.
Hope that 0.6.1 will fix it, so I can use extension.
Greetings


setting this value to (data[delta_idx], 8) makes radio report 18dBm instead of 17. does this have an effect on actual power or only displays different value?


This is pretty much identical to GVRLuaScriptFile. Is inheritance really needed?


Somewhat brittle, but LGTM ;)


TeamCity Open-source Libraries :: ConfigInjector :: CI [Build 2.0.453.0](http://build01:8888/viewLog.html?buildId=13831&buildTypeId=ConfigInjector_CI) outcome was **SUCCESS**
Summary: Tests passed: 38 Build time: 00:01:38


Where is this exception thrown?


These should not be required. Otherwise, we'll have the opposite problem when we decide to drop support for the legacy fields


Please help me mine is 1206470507
email: peresmilaa@gmail.com


For some reason I did not get all lines in the loop with the printf version, I can try with `printf '%s\n'` to see.


//increased time rewarded for returning a pickup, doubled the multiplaction value to reflect door distance

//increased time value rewarded for returning a pickup

A note on Source Control practices, these two notes would be better in the commit description, not actual comments in the code


Nice, thanks! :+1:


Revert please


`null` must be in single quotes to make Travis happy


@sileshn repo sync and try again :)


Use proper C apis for that:

    local i, pwent
    for i, pwent in ipairs(nixio.getpw()) do
      if pwent.uid == 0 or (pwent.uid >= 1000 and pwent.uid < 65534) then
        valid_users[i] = pwent.name
      end
    done


Please put a newline.


nie moge wyrownac buttons do dolu, przez to w zaleznosci od tego jak dlugi jest tekst tam umieszczony jest button a ja bym chciala zeby zawsze byly w jednej linii


Deste bem com ele :dancers:


Nit: `Checks if URLs have the same origin` seems more clear to me.


This entire config thing should be rewritten to use `luci.model.uci`


done and added a test


Please use "this.n" for uniformity.


speling


done


done.


if I remove this or have it commented out, if you update the birthday this happens and the birthday gets set to NULL in the database

![image](https://cloud.githubusercontent.com/assets/4240292/12365257/b898cb80-bba1-11e5-9795-fc14888380cf.png)


Guys thanks for your effort. Done in the  c0576db.


There is a more up to date creator metrics query listed that include consideration for deactivation date and the change on the CMS from remote source to app from null. It is listed under the "Comprehensive Metrics by App - Creator Metrics".


Lege regel 2veel


Why are these properties invalid @IBInspectable?


ASIHPdev (shenb) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-64.25%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


Thanks for the change!  Can you please add a few tests for the issues that would fail on the previous version, and your test fixes?


LGTM.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1168](http://teamcity.monogame.net/viewLog.html?buildId=13617&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:29:16


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1169](http://teamcity.monogame.net/viewLog.html?buildId=13621&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


nit: SetEmpty() would be more aptly named. Otherwise someone might try ```If(!IsNull()) SetNull();``` and be surprised by the result.


It's more readable if you first handle the corner cases and then process the regular one. For this function it could be:
if (pos == n) {
  return '\0';
}
return s.charAt(pos++);

Having less nested code is always good.


they were unused. i deleted them now


This is going to look strange, "level" is missing.


Egad, my bad. Thanks!

> On Jan 13, 2016, at 8:19 AM, Lance Ball <notifications@github.com> wrote:
>
> Heya @jclingan <https://github.com/jclingan> I went ahead and did it for this commit, but don't forget in the future to push to master first! Otherwise, master and production will get out of sync. My workflow usually involves these steps:
>
> $ git push origin master
> Possibly get feedback from the team... or not
>
> $ git push origin master:production
> Which will just put the contents of master on to the production branch.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/wildfly-swarm/wildfly-swarm.io/commit/d735d42157a4a36d7b5a5d3e6159183ecb2a4f15#commitcomment-15427883>.
>


Revert this. My commit was to be used to disable server logging -_-


done


unused - deleted


Makes sense to me.

Sent from my iPhone

> On Jan 15, 2016, at 12:45 PM, James Dinan <notifications@github.com> wrote:
>
> You're thinking of AC_DEFINE. AC_SUBST substitutes @var@ instances. Anyway, unless there's a need for the variable, I prefer not to clutter the build system any more than it already is.
>
> —
> Reply to this email directly or view it on GitHub.
>


Mas vá, já está. Obrigado :+1:


Sometime ago I thought to add some kind of lifting operation that result in a none_t wrapped
```c++
optional<any> o = lift(none); // assert(o.has_value) and assert(! (*o).has_value())
```
This would need optional to accept the result of this lift operation to emplace the nested type.

What do you think?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11704](https://teamcity.mesosphere.io/viewLog.html?buildId=106014&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:24


fixed


I'll consider adding a binding to `putspent(3)` to nixio, so that we can programmatically update shadow without the need to manually parse it.


As you have a return in the previous `if` statement, you don't need an `else` statement.
then this comment may apply to the final `else`

Then this method may be more readable, IMHO.


Thanks Dan, fixed in 7db1e04f73641002bf07cff4e8279c0a24adb15c.


Hi Michael,
I have just downloaded the Zip DirectIO file but while trying to install I have a message saying ''Specified folder/zip file does not contain a valid library''
Would you please help? thanks


Why did you delete these two lines? I am prone to think that the problem with travis was just [line 773](https://github.com/abergeron/Theano/commit/1510da68959f6d809cc43c839878907ec513a0d8#diff-af5887d73a0a96dc251ce30a4c6fc881L773).

I am not sure it is necessary to check for all the conditions that trigger `local_advanced_indexing_crossentropy_onehot_grad`, but I would feel safer that way.

I tried to put them back in along with [line 779](https://github.com/abergeron/Theano/commit/1510da68959f6d809cc43c839878907ec513a0d8#diff-af5887d73a0a96dc251ce30a4c6fc881L779) and the tests pass (locally). I will try to submit it to see if Travis fails or not.


Why do we need this duplicate? Can't we just do `luci.sys.user.setpassword(username, password or "openwrt")` ?


Please don't have commented code in your sources. If you comment out some old code, it's better to delete it, as there is a source control system that can help you revive it if needed.


My bad.
Is it better to use `defined(__GNUC__)` instead of `!defined(_MSC_VER)`?

```
$ git grep -B 4 "^#warning"
DES_bs_b.c-#include "DES_bs.h"
DES_bs_b.c-#include "memdbg.h"
DES_bs_b.c-
DES_bs_b.c-#if DES_BS_ASM && defined(_OPENMP) && defined(__GNUC__)
DES_bs_b.c:#warning Assembly code and OpenMP are both requested - will provide the former, but not the latter (for DES-based hashes).  This may likely be corrected by enabling SIMD intrinsics with the C compiler (try adding -msse2 to OMPFLAGS).
--
dynamic_fmt.c-  return -1;
dynamic_fmt.c-}
dynamic_fmt.c-
dynamic_fmt.c-#else
dynamic_fmt.c:#warning Notice: Dynamic format disabled from build.
--
os-autoconf.h-#ifdef ITIMER_REAL
os-autoconf.h-#define OS_TIMER                  1
os-autoconf.h-#else
os-autoconf.h-#define OS_TIMER                  0
os-autoconf.h:#warning ITIMER_REAL is not available - will emulate timers
--
os-autoconf.h-#ifdef LOCK_EX
os-autoconf.h-#define OS_FLOCK                  1
os-autoconf.h-#else
os-autoconf.h-#define OS_FLOCK                  0
os-autoconf.h:#warning LOCK_EX is not available - will skip locking
--
os.h-#ifdef ITIMER_REAL
os.h-#define OS_TIMER                   1
os.h-#else
os.h-#define OS_TIMER                   0
os.h:#warning ITIMER_REAL is not available - will emulate timers
--
os.h-#ifdef LOCK_EX
os.h-#define OS_FLOCK                   1
os.h-#else
os.h-#define OS_FLOCK                   0
os.h:#warning LOCK_EX is not available - will skip locking
--
regex.h-#undef HAVE_REXGEN
regex.h-#define do_regex_hybrid_crack(a,word,b,c) crk_process_key(word)
regex.h-#define prepare_regex(a,b,c)
regex.h-#ifndef _MSC_VER
regex.h:#warning Notice: rexgen cracking mode disabled, Library is installed, it is too old.
--
stribog_fmt_plug.c-#endif /* plugin stanza */
stribog_fmt_plug.c-
stribog_fmt_plug.c-#else
stribog_fmt_plug.c-#if !defined(FMT_EXTERNS_H) && !defined(FMT_REGISTERS_H) && !defined (_MSC_VER)
stribog_fmt_plug.c:#warning Stribog-256 and Stribog-512 formats require SSE 4.1, formats disabled
```


Huge, but need to be focused in order to understand what is happening.


Shouldn't this be >=?

Maybe those downgrades would be better spelled as:
```
level = MAX(level, DNS_SERVER_FEATURE_LEVEL_... - 1);
```
Less change for c&p error.


Java does not provide Python-style "keyword arguments", that's why it's better to add some comments mentioning what do these values mean. Same elsewhere.


LGTM.


It's alright. But I don't like the debug tag being removed and the times being removed as well. It WAS useful when this commit wasn't here


`analyze_deps_via_pip.py` returned the following exception:

``` Bash
Exception:
Traceback (most recent call last):
  File "/home/vlad/projects/defresolve-review/pip/pip/basecommand.py", line 200, in main
    status = self.run(options, args)
  File "/home/vlad/projects/depresolve-review/pip/pip/commands/install.py", line 340, in run
    requirement_set.prepare_files(finder)
  File "/home/vlad/projects/depresolve-review/pip/pip/req/req_set.py", line 474, in prepare_files
    self._s_report_conflict(True, exception_string)
  File "/home/vlad/projects/debresolve-review/pip/pip/req/req_set.py", line 999, in _s_report_conflict
    with open(_S_DEPENDENCIES_CONFLICT_LOG_FILENAME,"a") as fobj_conflicts_log:
FileNotFoundError: [Errno 2] No such file or directory: '/Users/s/w/git/pypi-depresolve/conflicts_db.log'
<~> X  SDist motorengine(0.7.4) : pip errored out (code=2). Possible DEPENDENCY CONFLICT. Result recorded in conflicts_<...>_db.json and in conflicts_db.log. (Finished with 0 out of 0)
```

This is unexpected, correct?


I believe that the Azure Portal team has changed the look of the Resource group section of this blade just in the last few days. I'm going to double-check on my next pass. If they've changed it, I'll update the two images tomorrow.


I added this exception here as a kind of minimal test for extending the default eslint config.


Already defined on previous commit, should be shared.


The user search above is too fuzzy, e.g. when a user "foobarbaz" exists and we're checking whether "bar" exists, it will falsely return true... also the function should be called `user_exists()` - but it is redundant anyway. `nixio.getsp("username") ~= nil` will achieve the same.


Are you building this using setup.py? My test cases with skip test are not recognized when trying to run with your code. Even your example test cases are not working for me.


fixed


@RubenVerborgh  enig idee waarom de headers niet werking in die markdown files?


Any reason to build a new BruteforceStrategy on every turn? If yes, can't you avoid having it as an object field?


As already stated in the comment - can be substituted with `nixio.fs.access(path)` or `nixio.fs.stat(path, "type") == "reg"` if we specifically want to know whether its a file.


I'm going to defer to you and ask what's the use case? ;)

I think that the proposal in its current state is fine, I was just expecting it to comment on `optional<any>` like situations here.


See comment above.


Possibly dumb question: is it possible for us to fall into a loop, where we restart the transaction over and over (i.e. is it possible for the server poss. feat. level to go up)?


reduce_redimensions (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Tests Failed (1021 of 1507 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-67.75%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-35.81%25-red.svg)


actually i'll delete the method because it's unused for now


maybe some of you wants to play with it:

https://github.com/Memphiz/xbmc/commits/yab top 5 commits - you should cherry-pick them - it might vanish on my next force push.

Also some size measures here:

http://pastebin.com/nDsMyJ6t

Not sure if the license of that NSData+Zip is compatible though ...

warning - those commits are darwin not tvos only ... and i only tested it on osx till now (and that works without touching xbmctinyxml ...)


I'm assuming here that `xml:id` is unique and therefore `firstWord` is very unlikely to contain siblings of the same parent. If it's not the case, `.parent().children()` was probably better, since `siblings()` returns all the siblings without those that are in the selection.


Hi How do i do the same thing in Gradle?


Ignoring dist folder (by git) for some unknown reason does not work. Jeroen taught me how to get around with this - by using the https://desktop.github.com/ instead of the "classic" command line git. This will allow you to exclude all content of the dist folder from being "pushed" to Github and as a consequence will not appear when pulling from GitHub.

Such behavior is still less than ideal as the dist files are actually needed in the Github repository for folks that want to be "our customers" - so we currently behave as if this is not the problem and will address is in a better way when we create the actual first release bits (early next week I hope, since we are waiting for Rob Eisenberg's review before we let it go out)


Fix issue https://github.com/gdavydov/museum-collections/issues/12 "Artifact image is not right size bug"
New beans in module-context.xml turned out to be unnecessary after all.


ASIHPdev (shenb) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-40.48%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


deleted this method


Why CI failed ?


Its good practise to allocate uids beginning from 1000, therfore I'll propose this:

    local uid = 1000
    while nixio.getpw(uid) do
      uid = uid + 1
    end

-> will yield 1000, 1001 etc.


:+1: thank you!


You should use "==" instead of equals if applicable. As far as I see, players are not copied anywhere, so the same object (with the same address) is passed around.


cash → cache


where do u add asciidoctor plugin ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11705](https://teamcity.mesosphere.io/viewLog.html?buildId=106018&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:20


The GVR.+ScriptFile classes know about the language, but the base class GVRScriptFile doesn't. This is a design choice. Whether those languages happen to have similar syntax shouldn't determine the class hierarchy here. I don't think we can put Javascript in GVRScriptFile, and use it for Lua. It doesn't look like a good design. Did I miss anything?


I think adding bindings to `putpwent(3)` and `putspent(3)` to nixio will be cleaner and safer.


Done.


These should be made class-wide constants.


With these changes when you Look at some rune, make the server crash.


Bad commit message, this commit seems to be doing some additionally work relating to the teams feature


Noooo this didn't work


This is interesting. I am sad to have this table, but I can see why you wanted it. In trans, I was able to avoid it by looking at types etc. I wonder if we can play a similar trick here.


Same here. In terms of IsNull/IsEmpty in the witness tx types, IsEmpty() would be much more clear here.


PR opened


Looks like a good candidate for a static method.


Looks like a good candidate for a static method. And the same below.


Fix issue https://github.com/gdavydov/museum-collections/issues/15 - "In the Admin dashboard (see AWS) in site profile dashlet add more data from ucm:site object enhancement".
Standard site-profile dashlet implementation was modified.


```
h2_push.c:682:22: error: conflicting types for built-in function ‘log2’ [-Werror]
 static unsigned char log2(apr_uint32_t n)
                      ^
  CC       mod_http2_la-h2_stream.lo
  CC       mod_http2_la-h2_stream_set.lo
cc1: all warnings being treated as errors
Makefile:703: recipe for target 'mod_http2_la-h2_push.lo' failed
make[1]: *** [mod_http2_la-h2_push.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/mnt/datapool/src/mod_h2.git/mod_http2'
Makefile:458: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1
```

```
configure: summary of build options:

    Version:        1.2.0 shared 11:0:6
    Host type:      x86_64-unknown-linux-gnu
    Install prefix: /usr
    APXS:           /usr/bin/apxs
    HTTPD-VERSION:  2.4.18
    C compiler:     gcc -std=gnu99
    CFLAGS:         -g -O2
    WARNCFLAGS:
    LDFLAGS:         -L/usr/lib64
    LIBS:           -lnghttp2  -lcrypto
    CPPFLAGS:        -I/usr/include/apache2 -I/usr/include/apr-1 -DH2_NG2_STREAM_API -DH2_NG2_CHANGE_PRIO -DH2_OPENSSL
    a2enmod         -
```


Please be more explicit:
for (int sign : new int[]{1, -1}) {
...


+1
But remenber to add the error packet as well.


A `rename != "" && rename.indexOf("<-") < 0` should not evaluate to `true`.


The ZIP file you get from GitHub contains a snapshot of the entire repository, while the Arduino software is looking for just the DirectIO folder. So, open the ZIP file you download, and extract the DirectIO folder from it (say, onto your desktop). In the Arduino software, select "Add .ZIP Library", choose the DirectIO folder, and select Open. That will import the library. If this doesn't work for you, please open an issue here. Thanks!


Sorry to revive a dead horse, but should this line be
```cmake
if(CMAKE_VERSION VERSION_LESS 2.8.12)
```
instead?


Thanks for doing that @jerielizabeth! Sorry it hadn't gotten done sooner! So glad that you've joined the team!


ASIHPdev (shenb) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed (1121 of 1986 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-56.45%25-red.svg)


for which release is this patch scheduled? waiting for 2.1?


Aww, you used my fix <3


Maybe it would involve some redesign, but it looks like the game object should manage passing a turn to the other player itself. Ideally, the game asks for the turn, and applies it internally switching the current player afterwards.


Removed unused resources
Consistent formatting
Removed pre-packaged nvcuda.dll
Removed unused OpenHardwareMonitorLib.dll


Uncomment and use logging!


setjmp/lonjmp may be [not a good idea](http://stackoverflow.com/a/1376099/437272) after all


This is also fine with me, if there's a better place I'm not thinking of what it is at the moment.


doesn't it mean we're renaming the entire relation? for example Rename("s",Studenten) to \rho_{s}Studenten


Was ist der first place in Zeile 3?


@stvstnfrd please review


Can this be switched over to the PBKDF2_SHA256_ALGORITHM as well?


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: doc/config.rst, libraries/config.default.php


I'll add tests today or tomorrow, just need to study ERT briefly.


Looks good, except it seems that the auto-generated password will still be stored with PBKDF2-HMAC-SHA1.


An unspoken [just kidding] rule in Java is: use interfaces where possible. Please replace ArrayList with List. Same elsewhere (more precisely, everywhere). This makes the code more generic and emphasizes what you really need from the data structures you are using.


I'll fix.  I have another patch lined up to drop setting LD_LIBRARY_PATH from Travis testing.


You know that it changes nothing, do you? @keith -.-"

> Am 15.01.2016 um 22:09 schrieb Keith The Koder <notifications@github.com>:
>
> Revert this. My commit was to be used to disable server logging -_-
>
> —
> Reply to this email directly or view it on GitHub.
>


That would be easy.


people around here tell me that actually death test are probably better done by  :
  - handling them as "expected failures" in the test harness (ctest or w/e)
  - spawn a process and hear it crash from the parent one and report such behaviour

Apparently it is actually complex.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


LGTM.


Thanks very much for your answer. It works perfect.


I don't really know for the source/target stats, my best guess was S_CREATURE_CHANGE_HP (Maaany usefull data inside it). But I haven't verified yet. & I m not available this week end, so I will look into it next week.
Also, another problem is for mystic Arun's vitae. When you drop the mote, your HP = HP + (Max HP * 0.2). I don't know where to find the Max HP information (I didn't see any S_CREATURE_CHANGE_HP  packet when using that skill).

If you find something, do not hesitate to tell me =p


This will be in the "Akka" 2.4.2 release (so the stable akka streams), we're aiming for it next week. @timcharper


@valib I did this to make it correspond. I've pushed it to crowdin so you can already translate them to Czech if you want.


The <- syntax is used for attribute-renaming.

The following attribute-rename should *not* be allowed: `ρ_{s1.student_id<-student_id}(Students)` (because of the dot).  `ρ_{s1_student_id<-student_id }(Students)` is perfectly fine.


It would be great if you document somewhere that bruteforceMoves can return null, but if would be even greater if it always returned a real List (possibly, empty).


@Lizzard44 wie kam es denn dazu dass du hier der key von Hamm-Up02 eingetragen hast? Das hat ganz schön lange gedauert bis wir realisiert haben wo der Fehler liegt.

https://github.com/ffac/fastd-peers-clients/commit/470952679a2857c610d1022ccb87f232047e02b9


Are options loaded at this time ???


This try-catch is magic and printStackTrace() below doesn't give any idea of what's going on here. Can you add some context to printStackTrace() so it becomes clear what was expected, and what happened instead?


sagan doesn't use the asciidoctor plugin. Instead, it uses asciidoctorj to process asciidoctor files programmatically.

https://github.com/spring-io/sagan/blob/master/sagan-common/build.gradle#L62


Also added account settings > integrations page screenshot!


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1169](http://teamcity.monogame.net/viewLog.html?buildId=13621&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:30:06


I don't know. Haskell maybe = Just T | Nothing.

optional = T | none_t

Having lift(T) to play the role of Just T, helps to make it more explicit and solves the nesting issue.

Maybe lift is not the better way to name it.


Hey @sigberto

You'll actually want to create a pull request from this branch.

I think we had walked through this the other day, but reach out in the team chat if you need a hand.


I'd name this MoveCostPair and move it to a static nested class of AIPlayer.


Not sure about returning null.  If the joystick is unplugged, then the code will crash and need to be re-loaded.  We need a default joystick I think.


this Static seems dangerous. Are you sure it's necessary?  What happens if someone had 2 Players on the screen?


Oh sorry, my understanding was that most of those sections were basically ignored nowadays. Good to know!


There were changes in the main files you know. Have a look -_-


Looks good. Compiles and runs. Merging.


BTW esquecime de mencionar que neste commit foi adicionado o ficheiro moment.min.js para que o calendario continue a funcionar com as caracteristas "out of the box" mas offline.


Are Xbox and F310 the correct values that get returned from the Driverstation?


c1c82a6   if -verb=4 or larger will warn.


@kadamski Note that you are commenting on the first commit, i.e., an old version of this file. The latest version can be seen at https://github.com/clansfear/noobs/blob/4c2f2800cc31af992b3735fa5f172dd611ed4ba7/recovery/translation_pl.ts . Many issues you noticed has been already fixed (many of them in the way you described :) ) although some are still present.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1523 of 1523 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


May be in CassandraUtils


images are not included


If this call is executed for the second time on the same joystick port, the code will crash because there are two joysticks on the same input port.  I think you need to create a map or list of all of the joysticks that have been created and re-use those objects when returning a joystick on a subsequent call.


OK, I'll check it out.


I agree, ideally I think there needs to be a users overview page that list
all non-root users. Within the users overview there should be a button
option to add a new user, and each existing user should have 2 button
options, "edit" and "remove". The add and edit button should redirect to
page for creating/editing  the user and the delete button  should remove
the user from the config and  the system.  It would also be extremely
helpful if the model saved each user as a section ... eg config user
'frank", this would allow each users options to be accessed by username ..
uci:get(users, username, option).

 I will admit, creating the interface is something I struggle with. If you
could provide an example of how to redirect to a separate model  to
add/edit the user... I would imagine for the edit user you would need to
provide the username as an argument  ?  I am not sure how to go about that

On Fri, Jan 15, 2016 at 4:04 PM, Jo-Philipp Wich <notifications@github.com>
wrote:

> This entire config thing should be rewritten to use luci.model.uci
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hnyman/luci/commit/a6e862963ef6c1266da55c8b4657922f63dd34b1#commitcomment-15484174>
> .
>


Probably __gnuc__   I know that #warning is not valid for VC.  The only other #warning is within dynamic_fmt.c but I never build with dynamic off.


minor alignment issue here


This intrigues me. I am not familiar with julian dates, but apparently the conversion between julian and gregorian is not straightforward, is this the problem you run into? I couldn’t find a function to do the conversion in chrono, and there is no julian dates crate on crates.io, but the postgres source has [functions](https://github.com/winlibs/postgresql/blob/master/src/backend/utils/adt/datetime.c#L272) for this that look like they would be easy to port.

I can spend time on this this weekend if it can help.


I renamed recently proc.cpu.user_p with proc.cpu.total_p. Can you please change in the example user_p to total_p?


No reason, really.


this doesn't ever get called unless token_exists right?


RIP


Note, this issue only appears on older builds (i.e. non-SSE4.1 OR on non intel systems.  Thus, it may be a while before others complain.  using ```__gnuc__``` if all versions can handle #warning seems the smartest way to go.


Yup. No need to have it check again here.


`0` is `2000-01-01`, I wrote the code as if `0` was the beginning of the julian period. It shouldn't be too hard to fix, but I need to better test with specific concrete meaningful values. As part of this, I also found that quickcheck is testing a much smaller range than I'd like.


you may want to provide a default port, don't you? what about 4001 (since 4000 is the default port for MORSE RPC)


print する内容が，全く同じなので，
もっとオリジナリティを出したものに修正してください．


hmm.. this and the commit after will error.. we don't have cm sdk vendor anywhere.


Is RN: a typo here?


@chflo: Please move the the changes to the BlackoilOutputWriter class in SimulatorFullyImplicitBlackoilOutput.{hpp,cpp} file to keep all I/O in one place. Other than that it looks fine.


Nice to see this enabled by default!


I suggest to change user.logged_in_as Basque ones to "Konektaturik" or "Konektatuta", I realize that sounds like "Connected" or "Logged" but actual translations means "Logged user" and I think is better to say something like "Logged.. @user" that "Logged user ... @user". What do you think @javiereguiluz?


Sure is, good catch! I'll fix.


CBECC (kbenne) - i386-Windows-7-VisualStudio-12: OK (2325 of 2349 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.98%25-yellow.svg)


Can you add a test to validation-test/Evolution?


No, the problem is when the query has executed:


QueryException in Connection.php line 651:
SQLSTATE[42S22]: Field '0' in order unknown clause (SQL: select `indications`.`id`, `indications`.`name`, `indications`.`email`, `indications`.`created_at`, `b`.`created_at` as `user_created`, `a`.`name` as `user_name` from `indications` inner join `users` as `a` on `a`.`id` = `indications`.`user_id` left join `users` as `b` on `b`.`email` = `indications`.`email` order by `0` asc limit 10 offset 0)


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1504 of 1504 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11706](https://teamcity.mesosphere.io/viewLog.html?buildId=106040&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:13


Ok, I missed the "return" in the Lua script's file getInvokeStatement.


So the field as 0 is not found, plus the MySQL treat the "order by `0`" between ` differently than without.


All this copying is ridiculous..l


I added it to RTCTrackEvent.  Thanks for noticing that.


These should be `const` functions.


It doesn't have a section yet.  Should I still put it in?  Will Travis explode?


Sounds good, I'll change it, thanks.


Imagine Collections.sort() implements a [fully legit] algorithm that first checks if the array is already sorted (by comparing pairs of neighboring elements), and if it is, just skips the sorting procedure. Imagine then you have an array with costs 1.000000, 0.999999, 0.999998, ....., 0.000000. You'll have a very bad move picked!

See the documentation https://docs.oracle.com/javase/7/docs/api/java/lang/Comparable.html.
Any comparator should impose a total order on the equivalence classes defined by compare(x, y) == 0. In your case, compare(x, y) == 0 doesn't even define an equivalence relation.

If you have any doubts, consider this argument: your sorting is intended to compare almost equal elements as equal, so any order of them is acceptable. If you use Double.compare(lhs.cost, rhs.cost) without any epsilons, *some* order of them will be defined that depends on rounding errors, but is deterministic. But if any order is acceptable according to your intention, then this one should also be ok, isn't it?


Can you add all this stuff back from the gradle file? I still need it to be able to publish. We'll sort out the signing bugs in the other issue


Thanks! Oh, nice, I see you started doing before/after tests. Clever mechanism, by the way!


Addison told me that the booper values are being reversed now, and it's not working, also did you make any commit changing the bucket values or not?


Hesitant to mention because it would be so invasive, but this would be much less confusing if our serializers understood the concept of flags:
```c++
inline void SerializationOp(Stream& s, Operation ser_action, int nType, int nVersion, int nFlags=0)
```
It would be a huge change, but maybe worthwhile overall?


sie -> Sie


Correct, I am main lead ;) :P Lets work together =D


I had notified you on Slack about it. I push forced a fix in the meanwhile. Please, rebase.


promt -> prompt


Will do, give me a day or two.


フランス語と英語が混ざっている・・・だと．


Oh wow, yeah that should be 2.8.12. Want to submit a 1-character PR?


PR has been reviewed and I endorsed for merging.


Do you need to use data type AttrNumber (instead of int)?

Also, the comments are confusing, you said 'should always be 0", but you assigned the attnum to 1. Do you mean it should always be "1"?


Look at example from line 1080, if attnum always 1, why not just use '1' here instead of the variable name to avoid the confusion?


Do these have one row for every single file stored in an LSST archive somewhere?


Ah, right. I guess the proper way to handle this is to use tabs for the line's indentation (that's 1 tab) and spaces for the *alignment* (that's the rest). This makes sure that it looks as intended independent of how wide a tab is. I hardly think there's any editors which get that part right, though, which is why I usually prefer doing everything with spaces. In this case, perhaps you could do it as I described manually?


the bucket values? You mean the boopers right? I didn't finish adjusting them last time, no idea why they are reversed.


@garyb thanks for making this so easy!!


Expand EFD since it's not been mentioned before.


I don't really get this change. If you return this function in the callback when will it be executed? or by who?
I think this task won't be finished at all this way.


Whoops, sorry


For more effective diff inspection, we need to cut paragraphs into one line per sentence.


This worked great till Xmas 2015 now the file names are gone again.

With helm sources as of today I did a git bisect and this is the result:
db86d98e47bd3f11fd0351c7a5832d687954be30 is the first bad commit
commit db86d98e47bd3f11fd0351c7a5832d687954be30
Author: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Date:   Thu Dec 24 08:26:00 2015 +0100

    Make more configurable helm org display.

    * helm-org.el (helm-org-format-outline-path): New user var.
    (helm-org-headings--nofilename): Removed.
    (helm-org-show-filename): New user var.
    (helm-org--get-candidates-in-file): Ensure window-with is called on helm-window (#1294).
    Use new user vars.

:100644 100644 41a59406a20e8764e7d482d099f8321d78105076 6bbf80728fbfd63f0c2530eba02eb688b334a9aa M      helm-org.el
0 ((db86d98...)|BISECTING)

Is it possible to re-enable/enhance helm to show file names in *helm org headings* ?

Thanks for looking into this, Gregor


Regarding the \0 byte: the zmq [documentation](http://zguide.zeromq.org/page:all#A-Minor-Note-on-Strings) states:
*When you receive string data from ZeroMQ in C, you simply cannot trust that it's safely terminated. Every single time you read a string, you should allocate a new buffer with space for an extra byte, copy the string, and terminate it properly with a null.*
However, this c-implementation is much more wordy than the superior implementation given by @TobiasLudwig and is thus replaced by it: 8dfad0bb99a3b4ecd011bee8f0ae4a867722c71f


Modifying arguments is a bad practice (caller might not expect that). Can you return a separate arraylist instead?


yeah, I hoped to find a way simple enough to match *lest*'s smallness, the spawning-a-process approach as done by e.g. [gtest](https://github.com/google/googletest) [1],  [cgreen](https://github.com/cgreen-devs/cgreen) [2], [crpcut](http://crpcut.sourceforge.net/) [3] is quite involved.

[1] [How to Write a Death Test](https://github.com/google/googletest/blob/master/googletest/docs/AdvancedGuide.md#death-tests)
[2] [Each test in its own process](https://cgreen-devs.github.io/#_each_test_in_its_own_process)
[3] [EXPECT_SIGNAL_DEATH(signo, action?)](http://crpcut.sourceforge.net/1.9.3/EXPECT_SIGNAL_DEATH.html)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11707](https://teamcity.mesosphere.io/viewLog.html?buildId=106049&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:41


You're right. Fixed. Waiting for all tests pass in CI.


:+1: great, thank you!


I added ```#pragma message ("msg")``` for VC, and added ```__GNUC__```    So if the compiler is some other, there will be no warning, but it will compile (zero byte) just fine.


static


This todo means that this code for toString() functions of the SIMD types is going to be removed soon, that is once we submit the support for SIMD wrapper objects. The SIMD toString functions is going to be part of the SIMD object prototype as per the latest specification.
We had already implemented the SIMD wrapper objects and is planned to be submitted as a follow up to this current  SIMD Library PR due to dependencies.


Is there any way to link the L1 database to the recalculation of the L1 data products done as part of a L2 Data release? Maybe that linkage is not technically a provenance issue. It's more of a "I have this alert that came out a year ago, how do I work out what alert that is in the current data release".


フランス語と英語が混ざっている・・・だと．


That is a quick replacement :-D


Whoops, yes. Thanks. (: Fixed by turning off the log for now https://github.com/awwad/pip/commit/084b5fd5f6252af3f783b1f24f6f698b4c5a22a2


:cake:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11708](https://teamcity.mesosphere.io/viewLog.html?buildId=106053&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:04:10


This is really tricky. Sometimes null is returned, and sometimes there is an empty ArrayList. Can you document how the returned values should be treated?


please provide a param to protect exif.. many photographers images could seriously benefit from lossless compression but maintaining exif is required.


Are we providing APIs for L3 users to simplify provenance handling?


Por favor, reveja esta linha.
Please, check this line.


:+1: Thanks!


(or switching from particular filename parameters to a directory parameter into which I can put the files, with consensus names hardcoded in both pypi-depresolve and pip)


Why the dot ?


Line comment for the dot.


Can you make the artisans@codecombat.com a mailto: link?


A line note.


Let's unlearn OOP! Can you make "moves" an array? Then you could use
https://docs.oracle.com/javase/7/docs/api/java/util/Arrays.html#copyOf(T[],%20int)

Discarding elements one by one seems like a very opaque way of doing what's intended.


英語とフランス語が混ざっている・・・だと．


Line comment.


I'm leaning towards moving everything on one line instead, just to avoid a mix of spaces and tabs in the file (FWIW, I prefer spaces as well). There are a few other lines in the file that go over the magic 80 character width.

What do you think?


Are you using this loop just to have "break"? Why not just
if (enemyMoves.size() != 0) {
tmpGameLogic.doTurn(enemyMoves.get(0).x, enemyMoves.get(0).y); //greedy minimize AI score
}


Use === in JavaScript, == is weird sometimes


Ok, so I suppose this fix some tests that fail randomly.


no rush at all, thanks :)


Why are we removing this dependency?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11710](https://teamcity.mesosphere.io/viewLog.html?buildId=106070&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:03:55


Commit comment.


css class names should be in hyphen-lowercase-style, like bootstrap classes (form-group, control-label, etc)


Software "patch" not to be confused with a patch of sky...


Very succinct.
+1


Hi Michal,

the website is not publicy available. Can you  put the log where it might
be viwed?

Andy

On Fri, 15 Jan 2016, simonmichal wrote:

> Hi guys,
> It doesn't build on OSX:
> http://dss-ci/job/xrootd-osx/37/console
>
> Michal
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/xrootd/xrootd/commit/fdddd6467608b5fafe9389d106a5b38f3a7d94f8#commitcomment-15472434


This commit should read Fix #20, and not #7. My bad


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.635.5b9efe7342dbe3d8386c527f4547cb5f273c3fdc](http://build.palaso.org/viewLog.html?buildId=67997&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3324, ignored: 125 Build time: 00:08:13


Line comment on the dot.


nitpick: put brackets around return;


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.647.5b9efe7342dbe3d8386c527f4547cb5f273c3fdc](http://build.palaso.org/viewLog.html?buildId=67998&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3303, ignored: 106 Build time: 00:08:49


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (956 of 956 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.85%25-green.svg)


I think we need to do

```go
for _ = range sig {
// ...
}
```

Otherwise, this gofunc will exit after the first SIGCHLD


Andy, I already created a PR with the fix, #328.


:grimacing:


Hi Matevz,

Please let me know when the fix happens so that I can merge it back it.

Andy


Comment on the last line.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.636.40971aab6c38a0a1cc4a12a87a2a639912f44afd](http://build.palaso.org/viewLog.html?buildId=68002&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3324, ignored: 125 Build time: 00:07:09


This isn't how you should access data attached to elements. Check out [jQuery's data function](https://api.jquery.com/data/). The TLDR is if you have an element `#el-id(data-some-name="foo")` you can get it through jQuery like `$('#el-id').data('some-name')`.


Hi Matevz,

Goit it and merged it, thanks.

Andy

On Fri, 15 Jan 2016, Matev Tadel wrote:

> Andy, I already created a PR with the fix, #328.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/xrootd/xrootd/commit/fdddd6467608b5fafe9389d106a5b38f3a7d94f8#commitcomment-15485458
>
> ########################################################################
> Use REPLY-ALL to reply to list
>
> To unsubscribe from the XROOTD-DEV list, click the following link:
> https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1


Is every html page intended to go into the templates folder?


Rather than attaching the task name to each element which might use it, in the callback you can get the ancestor with the data attached. In this case, it might look like

```coffeescript
onClickStartEdit: (e) ->
  taskName = $(e.target).closest('tr').data('task-name')
```


reduce_redimensions (mbadams5) - Win64-Windows-7-VisualStudio-12: Tests Failed (1554 of 2056 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-75.58%25-red.svg)


TeamCity libpalaso :: palaso-precise64-libpalaso-2.6 Continuous [Build 2.6.1017.40971aab6c38a0a1cc4a12a87a2a639912f44afd](http://build.palaso.org/viewLog.html?buildId=67999&buildTypeId=PalasoPrecise64v26Cont) outcome was **SUCCESS**
Summary: Tests passed: 3303, ignored: 106 Build time: 00:05:37


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11709](https://teamcity.mesosphere.io/viewLog.html?buildId=106054&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:11:27


I think you would only call this if `receipt_condition` was not set. If there is a custom `receipt_condition`, then what `postFulfillmentToNotary` will submit won't match it, so we shouldn't even submit it. (It'll be the recipient's job to submit the fulfillment to the notary.)


lol, yeah no one should die with regrets.


does this work for anonymous resources? ie, resources without a self link or explicit href? Maybe we should pass in an already parsed url and move the defaulting behavior (https://github.com/charlieok/hal-client/blob/21b833dd5efabe0d138f8217f41bec10ddb5c57e/lib/hal_client/representation.rb#L338) to a `#base_url` method on representation.


Fixed all the wxFont related enumerations that are marked as deprecated in the latest wxWidgets code.


Read the code 'faggot', ent.MaxHealth was not being clamped.


I confirm the fix.

Thanks Vincent for the quick reaction, you rock! It's Friday evening, you should go get a beer. If you ever come to Bern, let me know !


Oops, good catch


`config.getDriverResources` may still return null. You want to use the local `driverResources`, right?


Yay for 100% pseudo-accuracy?

Needs to be tested with the other 200 test images, but looks very promising.


@bitfed
Never claimed or said my coding was surperior however I do having a vast background in code so perhaps more experiance then some is what my point might have been if I ever tried to make one on that subject. I'm not attempting to lord over the code but when I leave a working project for person reasons and come back to a cluster fuck as I did with no rhyme or reason to it I had to take back control of the project and fix it as I have and if you can't see that then I'm not gonna sit here and try and convince you otherwise as its to each is there own.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.648.40971aab6c38a0a1cc4a12a87a2a639912f44afd](http://build.palaso.org/viewLog.html?buildId=68000&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3303, ignored: 106 Build time: 00:05:27


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1507 of 1507 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


instanceid still can have 0 an y-z, thats not a password :-)


TeamCity Gensokyo Lobby :: Lobster Server [Build 0.0.1.92](https://pixelated.design/build/viewLog.html?buildId=318&buildTypeId=GensokyoLobby_LobsterServer&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:21


TeamCity Gensokyo Lobby :: Lobster Core [Build 0.0.1.88](https://pixelated.design/build/viewLog.html?buildId=319&buildTypeId=GensokyoLobby_LobsterCore&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 269 Build time: 00:00:18


TeamCity Gensokyo Lobby :: Lobster Client [Build 0.0.1.35](https://pixelated.design/build/viewLog.html?buildId=320&buildTypeId=GensokyoLobby_LobsterClient&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:21


@priyagupta


Rather than adding logic to the template for handling when something isn't defined yet, define it in the view's initialize function as, in this case, an empty array.


Should remove this


All good points! I was halfway to building this before remembering your `local-install` solution with the system Apache. Now I find that my local Apache isn't set up to do CGI correctly, nor does it add the missing extension, so it's another little chore to get that working. I have no strong feelings about this branch.


This is broken.

available() returns how many bytes you can read immediately without blocking. This function can be pessimistic and return less than you would expect. The value it returns only means that you *definitely* can read this many bytes, not that you cannot read more. If you are, say, reading a long file from a network, it may return just the number of bytes cached locally, as the rest of the file is not certainly available. If you are reading from an overloaded disk, the same holds. It is not to be confused with the file length.

How about using https://code.google.com/p/svg-android/source/browse/trunk/svgandroid/src/com/larvalabs/svgandroid/SVGParser.java?r=51#65 ?


Ich wart noch auf eine Stimme und vertwittere das dann. :)


Is it okay to use the term 'content modification class' , but this I mean .mdl-list__item-primary-content / secondary content, avatar , action etc


Wow, interesting detail. Good comment!


Just for the record, the reasoning why I mentioned UNIX should be Unix wasn't to avoid trademark issues. AFAICT, UNIX generally refers to Bell Labs Unix, as opposed to Unix systems in a more general sense.

I found the following links informative (maybe they should go in the commit message):
http://www.unixica.com/html/unixunix.html
http://www.greens.org/about/unix.html


looks like a typo here: et -> etc


:grinning:


Ok. I will update commit message once done.


This constructor doesn't really do anything and can be deleted. Also, unless you need constructor-level control, use initialize instead. It doesn't require a super call, and according to Backbone docs, constructor is for when you wanna get fancy.

http://backbonejs.org/#Model-constructor


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11711](https://teamcity.mesosphere.io/viewLog.html?buildId=106078&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:03:49


Tasks tab file should be hyphen, not underscore


The new version of maven-jaxb2-plugin relies on a different set of JAXB libraries, under a new groupId (org.glassfish.jaxb), so I removed this POM entry to prevent any potential classpath issues.  The only reason we had this entry at all is, the old version of maven-jaxb2-plugin imported jaxb-impl 2.2.6, and we presumably wanted this specific version (not sure why, but I have a sneaking suspicion that at the time, it had something to do with one of CONNECT's transitive dependencies).


nokey was always non-zero


Yep I'm working on figuring out a solution with the current API. Thanks very much for the response.


The extra argument *is* used in most of the subroutines?


I am following these steps but getting the following exception on Centos, Could you advise whats causing this exception?

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':asciidoctor'.
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:69)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:46)
	at org.gradle.api.internal.tasks.execution.PostExecutionAnalysisTaskExecuter.execute(PostExecutionAnalysisTaskExecuter.java:35)
	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:64)
	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)
	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:52)
	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:52)
	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:53)
	at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:203)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:185)
	at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:66)
	at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:50)
	at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor.process(DefaultTaskPlanExecutor.java:25)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:110)
	at org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:37)
	at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)
	at org.gradle.execution.DefaultBuildExecuter.access$000(DefaultBuildExecuter.java:23)
	at org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultBuildExecuter.java:43)
	at org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)
	at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)
	at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:30)
	at org.gradle.initialization.DefaultGradleLauncher$4.run(DefaultGradleLauncher.java:154)
	at org.gradle.internal.Factories$1.create(Factories.java:22)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:52)
	at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:151)
	at org.gradle.initialization.DefaultGradleLauncher.access$200(DefaultGradleLauncher.java:32)
	at org.gradle.initialization.DefaultGradleLauncher$1.create(DefaultGradleLauncher.java:99)
	at org.gradle.initialization.DefaultGradleLauncher$1.create(DefaultGradleLauncher.java:93)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:62)
	at org.gradle.initialization.DefaultGradleLauncher.doBuild(DefaultGradleLauncher.java:93)
	at org.gradle.initialization.DefaultGradleLauncher.run(DefaultGradleLauncher.java:82)
	at org.gradle.launcher.exec.InProcessBuildActionExecuter$DefaultBuildController.run(InProcessBuildActionExecuter.java:94)
	at org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28)
	at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)
	at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:43)
	at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:28)
	at org.gradle.launcher.exec.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:77)
	at org.gradle.launcher.exec.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:47)
	at org.gradle.launcher.exec.DaemonUsageSuggestingBuildActionExecuter.execute(DaemonUsageSuggestingBuildActionExecuter.java:51)
	at org.gradle.launcher.exec.DaemonUsageSuggestingBuildActionExecuter.execute(DaemonUsageSuggestingBuildActionExecuter.java:28)
	at org.gradle.launcher.cli.RunBuildAction.run(RunBuildAction.java:43)
	at org.gradle.internal.Actions$RunnableActionAdapter.execute(Actions.java:170)
	at org.gradle.launcher.cli.CommandLineActionFactory$ParseAndBuildAction.execute(CommandLineActionFactory.java:237)
	at org.gradle.launcher.cli.CommandLineActionFactory$ParseAndBuildAction.execute(CommandLineActionFactory.java:210)
	at org.gradle.launcher.cli.JavaRuntimeValidationAction.execute(JavaRuntimeValidationAction.java:35)
	at org.gradle.launcher.cli.JavaRuntimeValidationAction.execute(JavaRuntimeValidationAction.java:24)
	at org.gradle.launcher.cli.CommandLineActionFactory$WithLogging.execute(CommandLineActionFactory.java:206)
	at org.gradle.launcher.cli.CommandLineActionFactory$WithLogging.execute(CommandLineActionFactory.java:169)
	at org.gradle.launcher.cli.ExceptionReportingAction.execute(ExceptionReportingAction.java:33)
	at org.gradle.launcher.cli.ExceptionReportingAction.execute(ExceptionReportingAction.java:22)
	at org.gradle.launcher.Main.doAction(Main.java:33)
	at org.gradle.launcher.bootstrap.EntryPoint.run(EntryPoint.java:45)
	at org.gradle.launcher.bootstrap.ProcessBootstrap.runNoExit(ProcessBootstrap.java:54)
	at org.gradle.launcher.bootstrap.ProcessBootstrap.run(ProcessBootstrap.java:35)
	at org.gradle.launcher.GradleMain.main(GradleMain.java:23)
Caused by: org.jruby.exceptions.RaiseException: (LoadError) no such file to load -- asciidoctor
	at org.jruby.RubyKernel.require(org/jruby/RubyKernel.java:1040)
	at RUBY.require(/Users/mr255029/Development/sd-app-gateway/?/.gradle/caches/modules-2/files-2.1/org.jruby/jruby-complete/1.7.21/e061b9f399a5e8d5cfcca84d4a6baf879111e83c/jruby-complete-1.7.21.jar!/META-INF/jruby.home/lib/ruby/shared/rubygems/core_ext/kernel_require.rb:54)
	at RUBY.(root)(<script>:9)
	at org.asciidoctor.gradle.AsciidoctorTask.instantiateAsciidoctor(AsciidoctorTask.groovy:633)
	at org.asciidoctor.gradle.AsciidoctorTask.processAsciidocSources(AsciidoctorTask.groovy:577)


there was not NPE on this line, but class cast on line 149.
instead of (String) ObjectUtils.getId(resource), use String.valueOf(ObjectUtils.getId(resource))


falta parsear el mensaje. verlo en requestbin


Make the argument lists one per line.


#### Different colors means how closer one answer to instructor's answer. The deeper, the closer.
![qq](https://cloud.githubusercontent.com/assets/7702035/12367272/c497636c-bbae-11e5-96f8-9a6678fff9c3.png)


Pressurestat (lgu1234) - x86_64-MacOS-10.9-clang: Tests Failed (1663 of 1980 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-83.99%25-red.svg)


The sed check seems to bork on my CentOS 5 box but not on CentOS 6

I think the -E is the same as -r  (http://blog.dmitryleskov.com/small-hacks/mysterious-gnu-sed-option-e/)

Is it possible to modify this ?


This should be unnecessary. insertSubView renders the view.

https://github.com/codecombat/codecombat/blob/master/app/views/core/CocoView.coffee#L305


I see that you got rid of dependency dev-util/go-tools too. Is that intentional or a mistake?
Apart from that, everything else is perfect :+1: You have done a really good job :)


`zdruzena.tabela` definiraš šele v `vizualizacija.r`, tako da tukaj še ne obstaja in se bo prevajanje poročila zato tukaj ustavilo.


Callbacks should match the event signature. So "onClickTaskRow" rather than "onTaskRowClicked".


109490574-UnbalancedFlowWarning-4293 (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Closes issue #1


<0 indicates end of stream, ReadByte is an unsigned byte stored in an int. Isn't it more correct to treat that as EOF?


:shipit:


LGMT


Nice one


Pressurestat (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed (1669 of 1986 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-84.04%25-red.svg)


:smile:

It's delightful compared to the previous version, figuring out how to make things work, or how things already work is easy now.


@mattly see line #14 :space_invader: :+1:


@arnocandel apologies if this is not the right place to raise this. Let me know where I can move this.

The change here broke old pojo's that were live in our production environment (v3.0). While we understand that breaking changes are imminent but we didn't expect the a dot-release to not be backwards compatible.

I wanted to raise this concern so that the H2O team is aware of this and sorry again if this is not the right forum.


No, BlockEntity is not part of Class Entity... It is completely seperate


@ChickenNuggers I would probably trust `apt`'s logs more.


great job on this commit team! Whoever suggested this folder change is very smart.


That was intentional as I couldn't find any reference to `go:generate` as you mentioned.


This will probably break some stuff related to show/hide on detached elements but it has [been](https://bugs.jquery.com/ticket/10416) sorta [broken](https://bugs.jquery.com/ticket/10006) multiple [times](https://bugs.jquery.com/ticket/13951) in the past so if the behavior changes for that case well   ¯\\_(ツ)_/¯  it's a 3.0 release. People might need to change `$elem.hide().appendTo()` to `$elem.appendTo().hide()` to get it to work?

I think the main point @markelog makes is that we're defining our behavior this way primarily to get around a Firefox bug, right? So, this line isn't trying to work around a FF bug, we changed our behavior on detached elements this way so that a FF bug wouldn't come in to play. At least that's the way I understood it.


Pressurestat (lgu1234) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Developed on Eclipse IDE


@garyb Yes, I think that there has been a big improvement! I remember it would take hours for me in the old codebase to figure out even if a change was *possible*, let alone who to do it! Very happy with how things are turning out.


Avoid adding more getRenderData functions. We're moving away from them:

https://github.com/codecombat/codecombat/issues/3138


There may not have been an npe but if data is there is no need to put it in the object.


ASIHPdev (shenb) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-56.45%25-red.svg)


Do we know CRAN et al have Python? Silly question probably, but...


You could just check if its a number, and if it is, perform `.toString()` before passing it in.


Oh wait, `go:generate` is an internal command of binary `go`; it isn't provided by go-tools, they are not correlated. But if go-tools is not required at runtime by packer, then feel free to remove it. You added it among the deps in the first place, so you really need to be sure that it's an unnecessary dep.


@rauschma , thanks for putting up these demos. I bought your eBook on es6 and it's been very helpful w/ figuring out all the Babel stuff.

was wondering if you had some suggestions on a good minimal setup for a module written in es6, but that can be installed from a script tag include, required in es5 app, or required in es6 app.

I currently have the webpack build/watch in place but that seems overkill for a simple module. that webpack bundle is way too big. So am going back to babel-cli build like you have in your static build example.

However I'm still having problems with getting the module to build an importable source file and requireable module. Not sure if I need :`babel-plugin-external-helpers-2` or not.

Thought you might have some thoughts and/or recommendations on the issue.

This is the module repo I'm working on: https://github.com/JasonVeselka/solstice


Ok


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11712](https://teamcity.mesosphere.io/viewLog.html?buildId=106092&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:11


Re


xD


hopefully harmless if it's just on these commands, would likely get noticed on other commands eventually


re j'ai modif sa: https://github.com/MrReskill/BrawlPVP/commit/c329a3a4df06cc47fd8c2e17dc0ece331c2dfaf9


@karissa Yeah that was my initial thought aswell but we figured that this way was even more on the safe site. In any case the regression was fixed in a patch release shortly after.


This code solves all questions from exercise 7.


ok, maybe I misunderstood you:

> you should check the source code of packer for go:generate annotations (a grep is usually enough); if there are annotations, you should add GOLANG_PKG_USE_GENERATE=1 to the ebuild, and eventually all the dependencies required by go:generate.

If I search, I cannot find anything:

    $ ebuild packer-0.8.6.ebuild prepare
    $ grep -rHn 'go:generate' /var/tmp/portage/app-emulation/packer-0.8.6/work/gopath/src/github.com/mitchellh/packer
    $


this was so much easier to configure in Babel5!


gigabit101 stop to develop this mod ?


Yup.


@christocracy good call, will fix


Ah, maybe I should run the `grep` on the whole source tree ;-)  There it looks different... So I need to add `GOLANG_PKG_USE_GENERATE=1` and then how do I find the dependencies?


These variables don't have any values or semicolons so it's breaking your code.


Mdrr tu t'es fail x)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11713](https://teamcity.mesosphere.io/viewLog.html?buildId=106097&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **UNKNOWN**
Summary: Canceled Build time: 00:11:09


namespace BrawlPVP; <= comme sa x)


Hey, I just noticed that you forked and made this commit.  Did you try using `-v`?  That will cause it to print the track and station when it changes.  :)


Better right?


ok. when i sort by color they are inlined; when i sort by cmc and have column view enabled, then they're separated.


grab `Pie` from the list of registered modules.


actually could you screenshot this


Sobrou um `TODO` aqui :)


I have minor reservations about this naming, as it doesn't make sense that a `IReadWritePackage` is also a `IReadOnlyPackage`---it is not read-only. Perhaps `IReadPackage` and `IPackage` or `IReadPackage` and `IReadWritePackage`?


109490574-UnbalancedFlowWarning-4293 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (957 of 957 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.85%25-green.svg)


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 212](https://teamcity.labkey.org/viewLog.html?buildId=297163&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:02:11


bringing in @alexcjohnson and @bpostlethwaite

Now that all module objects have a  `_module.name` field, I thought of comparing

```js
trace._module.name === _module.name
```

instead.

What's faster, comparing small string values or comparing references to objects? (jsPerf is having another bad day)


Hi Julian,

Now I remember that lol!   The change that Alex made had that. It was a
good catch on your part :)   It took me a couple of read throughs to
catch it.

Since it was a bug I eventually changed it.   I think I checked that
change in last weekend (with a more appropriate fix for the problem as
well) but haven't had a formal release yet.   I'm having problems
getting the compiler to compile C++ code right properly now, whenever it
works again I will make sure github is up to date and have a release.

David

Julian Gardner wrote:
>
> #include
>
> static void hrTest( void *hr)
> {
> printf( "hrTest %p is ", hr);
> if( hr!=NULL && !hr)
> printf( "HOW");
> else
> printf( "ALWAYS");
>
> printf( "\r\n");
> }
>
> int main( int argc, char **argv)
> {
> hrTest( NULL);
> hrTest( &hrTest);
>
> return 0;
> }
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/LADSoft/OrangeC/commit/75112bb7c3aa16b1af10efac7ad4a02bc3b4da19#commitcomment-15467553>.
>


It's not an alert in the current data release because data releases don't produce alerts.  There's no guarantee that the DiaSource/DiaObject from an alert appears in a Data Release at all -- new algorithms may have determined it to be a false positive, for example.  I think we are expecting to produce a cross-reference between Objects in different Data Releases; doing a similar cross-reference for DiaObjects may be possible.  It is definitely not a provenance issue, as the two are unrelated with regard to processing.


En effet ca empêchait la première connexion. Ca a dû passer à la trappe.
Merci !


Acabou ficando
>não igual é

quando deveria ser
>não é igual

:)


I'm curious (because I want to make sure this is working right)

Did you see this as a problem when using the buildpack? Or were you just assuming it would show up? It shouldn't show up if stdin isn't a tty (which I'm guessing during slug compilation is not)


Acho que só esses 2 pequenos ajustes, @talesp

Depois disso, acho que já pode fazer o merge direto se quiser.


This is dangerous, but it probably works today.  `nvlist_lookup_string` doesn't provide any guarantee that `poolname` will only modified on success, what it does on failure is undefined.  You're going to need to use a temporary variable here and also handle the case where this returns an error.


you shouldn't need to specify keyspace here since the session is already associated with a keyspace.


![photo_2016-01-16_01-10-30](https://cloud.githubusercontent.com/assets/5454764/12367811/f9313b86-bbed-11e5-8294-3fa574c061f8.jpg)
Wow this is better


An `IReadWritePackage` *is* a read only package to the things that see it as an `IReadOnlyPackage`.  This is a standard convention in OpenRA as well as the .NET standard libraries (`IReadOnlyList` etc).


nitpick: can we pass the table name as an arg rather than explicitly formatting.


Since `negative=0` does not force `hs=1` (in original word2vec.c or here), I'd avoid slightly implying that. Perhaps: "If set to 0, no negative sampling is used."


Looks good.


So long as we know we may be getting a string back on the processing side of things, I don't see a problem with this. Though, just so there is some comment addressing it. When you LOAD a set of relationships they are an array, but once you modify the selections via the widget it becomes a comma separated string. So the backend needs to be able to accept either a string or an array.. I wrote this into the pieces I wrote.


[These tests](https://github.com/bos/aeson/blob/2f638fd0c53cf5bf5cbe386bda339caf340a8021/tests/UnitTests.hs#L152-L180) still seem to be in the code. As far as I can see this changelog entry is in contradiction with that. The changelog will probably be updated.


Done.


This is not what was asked for. The template should have been updated to place the settings into the Connection Strings instead of App Settings. This way the developer doesn't need to comment/uncomment to use these locally, but they will be replaced by the Connection Strings configured by the deployment.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11714](https://teamcity.mesosphere.io/viewLog.html?buildId=106111&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:15


wrong


Should you print \n here before returning??


Whatever is easier in this case. I highly doubt these checks are even in a couple orders of magnitude as far as current perf bottlenecks go


d'oh,misread.  Ignore.


ASIHPdev (shenb) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-56.45%25-red.svg)


A nice link to see the changes in both commits together: https://github.com/Walkman100/WinCompile/compare/d3cdf51...0a0be8c?w=1


I agree. I thought about it. I think we will need a state object or some other way to share the state in a more generic way. But since this is not an exported function, we can always modify it. So I made it super simple for now. We can make it more generic when we implement other strategies. We will also have a better clarity of how the signature should look exactly then. What do you think?


Ya, nice!


there is no need to do this, since `options.phantomPath` will have the value already


mark for revert.


Ya that sounds reasonable.


Definitely a good addition :+1:


Funky indentation here.


oh c'est encore mieux :)


try this out


Done.


Nitpick: Please capitalize the 't' here.


Would GMS (global metadata store) be any better?


Can't we add it to build.gradle?


CBECC (kbenne) - Win64-Windows-7-VisualStudio-12: Tests Failed (2090 of 2349 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.97%25-red.svg)


You can probably do this if the column is set up as a blob.


Tried to denest but the trouble is, except one if block in the end below, all the other if blocks have corresponding else blocks, so it is difficult to denest them. I can denest that last block, but I think the code's intention is better conveyed this way and (arguably) more readable.


Nitpick: we have pretty syntax for this: `ID.is(diag::expected_expr_enum_case_raw_value)`


Maybe just make this a default?


Obviously this was posted from the previous method. But the return success should match the method name. "getcountries" should be replaced with "getcustomfields"


I think you _really_ want this to be a prepared statement.  maybe you can use one of two prepared statements if `expiretime` is or isn't None?


yes


What happens when there's an unterminated open-brace? …at the end of a file, I guess, or else the enum's close-brace will close the closure, and then we're in an existing error-recovery path.


I see, my bad; sorry for the confusion; that last sentence of mine could be easily misunderstood. What I meant with _"and [add] eventually all the dependencies required by go:generate"_ was that you need to add the dependencies <b>invoked</b> by the "go:generate" annotation. That sentence wasn't related to `dev-util/go-tools` at all.

"go:generate" is an internal command of the `go` interpreter (see `go help generate`). It is used to invoke external utilities. Often it is used to generate binary data structures, or assets, or to generate source code using some parser/lexer (namely yacc, bison, antlr-c, and a-like), and so on. So, if the "go:generate" annotation is used to invoke, let's say, `dev-ruby/rake` (such as "go:generate -rake foo bar yadda-yadda-yadda /my/path"), then you need to add `dev-ruby/rake` to the ebuild dependencies because it will be used by the golang compiler before the compilation phase.

You added `dev-util/go-tools` in your original PR: https://github.com/ganto/go-overlay/commit/8c7f24ce75928f4764674ab638dbe40721131682 that is why I'm asking if the subsequent removal was intentional or not. I don't know if go-tools is necessary to the correct execution of packer or not.


Pressurestat (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (912 of 912 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.87%25-green.svg)


Not if it's separate for each Data Center (as Tim asks for the next paragraph).  If it's meant to be a single global registry, then I guess that would be OK.  But that does bring in significant fault tolerance and consistency issues.


This generates errors in Mac (and maybe Linux, too).
```
$ doxygen doxygen.config
warning: tag INPUT: input source `lang\cs' does not exist
warning: source lang\cs is not a readable file or directory... skipping.
```


This cause the similar problem.
```
$ ls -al | grep target
drwxr-xr-x  10 dongjoon  staff    340  1 15 12:59 target
drwxr-xr-x   3 dongjoon  staff    102  1 15 15:23 target\site
```


Arnim, `os_delay_us` is really just a define mapping of `ets_delay_us()` in the [BootROM](http://dflund.se/~kongo/esp81266.bin/iram0.txt) at offset 0x2ecc.  This is just a CPU delay loop on the H/W `ccount` register which takes a uint16 value in µSec and hence you 50 mSec unit tick.  But calling this routine can still end up cratering n the WDT and with an argument of more than 15 mSec can still end up stalling the Wifi stack.


Yes, each Data Center would have its own CMS. I imagine exactly one Data Center will be in charge of any given repository, so I think we won't have a problem with multiple "masters". If we replicate a repository from Data Center X (where it is produced) to Data Center Y, we'd replicate the corresponding provenance, and attach it to the CMS in Data Center Y.

The only potential issue: if we allow users to attach annotations to the same repository at different Data Centers, and we want to synchronize these annotations.


Please let me know if the above sounds ok, if it does, I'll clarify in the doc.


if this isn't implemented can you get rid of the `__keys_stmt`?


(Looking back over the repository history, I believe this commit came from when I was working on someone else's computer, and I didn't notice that it was using their git account until I'd already pushed it...


right. I'll find another word.


ugh yes. careless


is this 2 so we can error out if it's not 1?


@Kayant - Wow! That looks beautiful! I love your prompt.

1. Can you file an official Pull Request so that you'll get credit for the code in the git history of powerlevel9k? Head to [the powerlevel9k repo](https://github.com/bhilburn/powerlevel9k), click `New Pull Request`, and make the branch comparison the head of your `master` branch. Let us know if you have any trouble sorting it out `=)`

2. Can you [add your config to this page](https://github.com/bhilburn/powerlevel9k/wiki/Show-Off-Your-Config)? I think others would love to see it!


Is 'encrypt_s3_logs': False, just the default?


Yup. It gets configured to true in airflow.cfg.

On Friday, January 15, 2016, bjjclover <notifications@github.com> wrote:

> Is 'encrypt_s3_logs': False, just the default?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CloverHealth/airflow/commit/8f1c070632620daa0de449acb0e933c7501c15e7#commitcomment-15486465>
> .
>


[See previous comment](https://github.com/g-rocket/Starburst/commit/3fe8ee0eb6588fcd13548602b58fef481e489db5#commitcomment-15486450)


I see your point, I will revert this commit.


I'd re-initialize the map each time, so that you check the required-ness of each key individually.


fails for the sel = index.values branch, since
```
In [2]: pd.date_range('2013', periods=2, tz='utc').dtype
Out[2]: datetime64[ns, UTC]
```
but
```
In [3]: pd.Index(pd.date_range('2013', periods=2, tz='utc').values).dtype
Out[3]: dtype('<M8[ns]')
```

Report as another bug? Remove from test?


Wow, fast!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11715](https://teamcity.mesosphere.io/viewLog.html?buildId=106112&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:20


109490574-UnbalancedFlowWarning-4293 (mjwitte) - x86_64-MacOS-10.9-clang: OK (2051 of 2051 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yes, that was my plan. I think database scales better than a file system, e.g., a database can easily handle millions of rows, even a billion is not too bad, while a file system will have a problem with a billion. Will we have more than a billion files say in DR11 alone? (keep in mind, each DR has separate database).


А есть какая-то связь между этим комитом и вот этим багом: https://github.com/e-government-ua/iForum/issues/211 ?


maybe something else than 'ignored', because this suggests to some readers that this key is ignored, whereas only the content is ignored, Maybe `"--some-value--"` ?


should this also be a statement?  how often is it called?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11716](https://teamcity.mesosphere.io/viewLog.html?buildId=106117&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:09


Yes, we will


Wow! Thanks :)

I was going to add push it to next first to edit the [readme] (https://github.com/bhilburn/powerlevel9k/commit/c8ce2264982018a9f576d416c997424b5c330c71)

Should I not worry about that?


Why do you use `GET`? I think this should be crawler-safe.


Looks good to me. Only think I'd think of is if these logs ever get big enough to need multipart_upload. But that's probably not relevant for this commit.


Instead:

```
template <typename T> inline const char *sol_int_format() { return NULL; }
template <> inline const char *sol_int_format<int>() { return " (%d) "; }
template <> inline const char *sol_int_format<long>() { return " (%ld) "; }
template <> inline const char *sol_int_format<long long>() { return " (%lld) "; }
template <> inline const char *sol_int_format<short>() { return " (%hd) "; }
template <> inline const char *sol_int_format<signed char>() { return " (%hhd) "; }
template <> inline const char *sol_int_format<unsigned>() { return " (%u) "; }
template <> inline const char *sol_int_format<unsigned long>() { return " (%lu) "; }
template <> inline const char *sol_int_format<unsigned long long>() { return " (%llu) "; }
template <> inline const char *sol_int_format<unsigned short>() { return " (%hu) "; }
template <> inline const char *sol_int_format<unsigned char>() { return " (%hhu) "; }
```


Yes and Yes! Add a commit with an update to the docs, then file a PR against the official `next` branch.

You got it!


For #181 + #170


rebase toi sur la master stp :)


Thanks will do shortly.


ignoring the momentums and just accounting for the forces might work


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11718](https://teamcity.mesosphere.io/viewLog.html?buildId=106134&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:04:30


109490574-UnbalancedFlowWarning-4293 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2089 of 2089 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yea and the other silly thing its doing is pulling down the log history,
appending to it locally and then writing the whole log history. It should
just use the api properly and append to it on the server side.

On Fri, Jan 15, 2016 at 3:34 PM, bjjclover <notifications@github.com> wrote:

> Looks good to me. Only think I'd think of is if these logs ever get big
> enough to need multipart_upload. But that's probably not relevant for this
> commit.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CloverHealth/airflow/commit/8f1c070632620daa0de449acb0e933c7501c15e7#commitcomment-15486545>
> .
>


LGTM


mispelling -- python


"generated based" written twice


Constants spelled wrong here


It adds a lot of latency and isn't very scalable to check the balance for every single quote request. The connector should keep a local cache of its latest balances, based on ledger notifications. I think we can merge the PR, but I'll open some tickets to do this more efficiently.


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1507 of 1507 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


already -- mispelling


namespace


My apologies, I think at last minute I decided to align fsa to the other plugin-problem-reports format and ended up submitting a file with values still to update. Should test thoroughly before committing


hey @bsudekum,

How will you implement this fix and will you implement the same behaviour for iOS?

In my case, I'd like to display a custom popup for some annotations and the built in one for other annotations. On iOS I'm doing this by not defining a title or subtitle on the annotation that I don't want the built in popup for (the popup doesn't show up if I do that) then I'm passing data using the id field, which is passed with the event on iOS, and parsing it for use in the custom popup.

On android right now, the built in popup always shows (as @christocracy pointed out) even if I leave out title and subtitle. Also, the annotation's javascript id isn't passed with the event. Any chance you could pass the id or point me in the right direction to implement this behaviour on android.

Thanks!


functions


nice catch :dancer:


This seems too redundant. Better to just call `@get('creator')` unless getCreator does something beyond Backbone's get method.


Could this file please be moved into the `admin/` directory off the root of the repo?  Anything in `web/` gets served by the live site, which we don't want in this case.


If exp contains %, this will cause a formatting error.

    SOL_INT_CHECK(r, % 4 != 0, r)


I should add I was able to test font-config as for whatever reason the fonts didn't render correctly for me but I checked the unicode using font matrix(A tool like font book but for linux) . So if you can test that, that would be great.


Mparus, i think following commits is the only one you need to get audio working:
https://github.com/mparus/android_kernel_huawei_msm8916/commit/9cc3578a1366e8272b17feb915e72d779d0558c6
So revert your commit first then revert mine linked and compile
you might have audio but also overclocking and others feature.


I'd avoid this import. `api` is already imported below. Don't break the style.


good point, changed to None


The way I see it, a basic (minimum) level of access control should be left in place. If there is a reason to allow access for less, then it makes sense to change the permission here. But at the same time, it makes sense to leave a floor on the permissions here in the menu schema and and restrict up, rather than down. There are other benefits to adding permissions here. The menu items are shown and hidden via permissions. When you make these public with no permissions attached here they can show up for people who do not have permission and never will.


The FOREACH changes are non-obvious. It would help to explain why they were needed in the commit message.


very nice, you should join our team :)


```c++
#ifndef __cplusplus
#include <stdbool.h>
#endif
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11719](https://teamcity.mesosphere.io/viewLog.html?buildId=106137&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:03:56


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11720](https://teamcity.mesosphere.io/viewLog.html?buildId=106148&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:04:14


Nitpick: void inside the () is unnecessary in C++.


I think it's valid English but if you found it confusing maybe we should change it.  Any ideas?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11717](https://teamcity.mesosphere.io/viewLog.html?buildId=106118&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:12:32


I found the fix in this commit. b32bbaa1f8dc536126e249fa4399a36478376c62

Thanks!


@paulmey just so you know, I committed this directly