from my memory, there was an npm bot sending email at that time asking every package.json to incude a license. once i updated it, i had to upload a new version to npm registry to take this change into account


Ohh this looks great, will test soon!


Thanks for the patch. Can you provide a sample app or steps to reproduce your issue ?


I was wondering about this actually and was hoping you would comment on it. My first thought was a partial, but then we would have 3 files.

I think what might work would be to have one *vote.js.erb* and change the routes:
```
        post '/up-vote' =>'votes#up_vote', as: :vote
        post '/down-vote' =>'votes#down_vote', as: :vote
```


LGTM


You don't need to do @$el.find to turn e.target into a jQuery object. You can just do $(e.target).


I'm really glad travis is testing this commit.


Removed tags and added is_favorite test instead


Can you double-check the whitespace before merging please? Some of it looks odd.


Also, a handy Backbone shorthand is simply `@$` instead of `@$el.find`.


From http://crypto.stackexchange.com/a/31554/21442: It's not enough to verify the position here. You'd also need to verify that this chunk isn't from the same position in another message.


ah good thing we have code review :)


This one too.


???
Don't forget to clean your debug messages.


Could you also add `postfix` and `dovecot` services?


I don't think we should use 3rd party or copy-written things here. Can we change this to be about NiFi and Apache?


hey, can you try avoiding the backslash here? especially within the string


@sreilly Your so good for me ;). Ive updated this and pushed my changes. It's not so confusing.


Should we annotate tail recursive calls with @tailrec? code optimisations might kick in.

http://blog.richdougherty.com/2009/04/tail-calls-tailrec-and-trampolines.html


Not here, the line above.


what does this line do?


This is the best way to do this. Although the error message could be clearer IMO:

> 'enabled_rules' has been renamed to 'opt_in_rules' and will be completely removed in a future release.


Okay. The "is in this module" filter happens N times, where N is the number of top-level modules you have imported. If we ever support submodules, it'll be a problem then.


just "Wether or not to create .orig backup files." would suffice I think


string might contain 0 at an arbitrary location?  Isn't this just checking to see if string == '\x00'?


lgtm


Sorta weird to use `onCreate`; makes me want to assume that it'll be invoked somehow by the Android platform


@matcracker mi sai dire se funziona?


close Bauble/bauble.classic#59


Autoconf to the rescue.


Scusa ma non ho il PC e nessuno me lo può testare D:


@afollestad I think this should be `TextColorTagProcessor.HINT_PREFIX` here.


yo ro??


Should we mark the old IDs as deprecated?


oh, misplaced by mistake


np: parentheses around x are unnecessary.


I have it in my project RN. Maybe sometime this weekend I'll have some time to put it in a sample app. Might be able to shortcut to the issue by manually setting up and tearing down the render device on app launch.

The issue I saw was coming form tearing down audio -> route change -> session setup -> route change -> teardown audio -> etc. etc.


It was to be able to get rid of generators while enabling this library to be used in the browser


thought it would make it more readable, but seeing that there are just 2 arguments it wasn't need , thanks for pointing out :)


@afollestad You're duplicating a lot of code here, wouldn't it make sense to move the color value retrieval of the tag to a `TagColorUtil` class and reuse that. You're basically using the same colors everywhere anyway.


Non hai aggiunto praticamente nulla xD E manca il nome alla classe


Great, thanks for the quick reply :wink:


`router.get(url.getworkerslist.webinterface, function(req, res){
 -    //User.find();
 +    if(req.query.token && req.query.company){
 +        User.findOne({token: req.query.token}, function(err, user) {
 +            if (err) return console.error(err);
 +            if(user){
 +                if(user.info.company.name == req.query.company){
 +                    User.find({'info.company.name': req.query.company }, function(err, users){
 +                        if (err) return console.error(err);
 +                        res.send(users);
 +                        log.http('Sent users list!');
 +                    });
 +                } else {
 +                    res.send('ERROR');
 +                }
 +            } else {
 +                res.send('ERROR');
 +            }
 +        });
 +    } else {
 +        res.send('ERROR');
 +    }
  });`

too much complex...


Specifying no count gets you up to 100 records.  Specifying 20 < count < 100 gives you only 20 records, even if there are more.  So you can't get just 50 records, you can either get 1-20 or all up to 100.  No clue why it's that way.


Now that we are not using `@params_tag` in this template, we can change it from an instance variable to a local variable in the controller.


haha, okay Rails *really* didn't like that. What about throwing a ```render 'vote'``` at the end of the the ```up_vote``` and ```down_vote``` methods?


Replacing the common
```java
int newColor;
switch (suffix) {
    case TAG_NAME:
        newColor = ...;
}
```
with `TagColorUtils.getColorFromTag (suffix);


What the hell?


А в чем смысл делать лого-ссылку на саму себя?
На второстепенных страницах (не index.html) согласен с замечанием.
Но на главной не вижу смысла...


Hi @mjafin -  recently noticed this patch -- I symlinked paths in a few tricky ways and tested manta but can't reproduce the config mismatch. I realize this was a while ago, but if you recall well enough to describe a small recipe to fail the configure I'd be keen to fix.


@neoatomic here is that error, fixing quick


I haven't followed exactly what's going on in the jenkins mailing list, but I saw heaps of messages about account creation. Looks like the infra guys are having some problems there.

https://issues.jenkins-ci.org/browse/JENKINS-32680

Created JENKINS-32680. I organise my work when I start a development cycle using JIRA for Jenkins plug-ins. But you can comment here if you have problems logging in to Jenkins JIRA. The only problem is that I don't get e-mails from GitHub when there are changes here (though normally I check my GitHub notifications via github.com)


(nit) for consistency: containerInfoV2ToUserDefinedMetrics


No. I can't tun things like `self.lda.set_attenuation()` that block the (`Controllers`) event loop. It does work most of the time because the actual controller is in a subprocess but it is not correct at all. It would for example not handle crashing controllers correctly.
What I will do is the following: Split the code a bit and build tooling to (unit- !) test the `ctlmgr` stuff. And build tooling to test controllers in plain subprocesses without asyncio and threads.


I believe it's not necessary, es5id and es6id will remain valid as long as they refer to `es5` and `es6` specs respectively.


Yes, I think it's worth replacing spaces in all matches with any-whitespace match (`%s` in Lua). Comments are harder, maybe leave it to next ticket.


Could you refactor the logic a bit and move the private helper functions into GDBRemote/DebugSessionImpl.cpp? In general, the flow we have on receiving packets is to have the handler in Session.cpp, and then that handler calls helper functions in DebugSessionImpl.cpp (via _delegate). So probably better to go that route here too for the sake of consistency.


I've created an issue in our Mango public core repository for this as that is where we are most actively checking issues.  The issue is here: infiniteautomation/ma-core-public#623


I am fine with removing it.


@gforcada


(nit) remove this line (setting to default zero-value)


whats the difference between this am2 and mithion am2?


plz add empty line to all files - it's github convention


@gforcada
 plone/__init__.py:0:1: C101 Coding magic comment not found
plone/__init__.py:0:1: I002 no .isort.cfg file found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/__init__.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/catalog.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/catalog.py:81:17: Q000 Remove bad quotes.
plone/app/discussion/comment.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/comment.py:65:28: Q000 Remove bad quotes.
plone/app/discussion/comment.py:160:40: Q000 Remove bad quotes.
plone/app/discussion/comment.py:162:30: S001 found %s formatter
plone/app/discussion/comment.py:166:48: S001 found %s formatter
plone/app/discussion/comment.py:201:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
plone/app/discussion/comment.py:295:21: Q000 Remove bad quotes.
plone/app/discussion/contentrules.py:0:1: C101 Coding magic comment not found
plone/app/discussion/contentrules.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/contentrules.py:18:5: E731 do not assign a lambda expression, use a def
plone/app/discussion/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/conversation.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/conversation.py:57:27: Q000 Remove bad quotes.
plone/app/discussion/conversation.py:431:29: Q000 Remove bad quotes.
plone/app/discussion/events.py:0:1: C101 Coding magic comment not found
plone/app/discussion/events.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/interfaces.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/interfaces.py:133:17: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:159:65: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:213:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:239:21: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:257:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:261:23: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:268:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:271:23: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:279:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:296:25: Q000 Remove bad quotes.
plone/app/discussion/patches.py:0:1: C101 Coding magic comment not found
plone/app/discussion/patches.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/patches.py:25:46: Q000 Remove bad quotes.
plone/app/discussion/subscribers.py:0:1: C101 Coding magic comment not found
plone/app/discussion/subscribers.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/testing.py:0:1: C101 Coding magic comment not found
plone/app/discussion/testing.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/testing.py:17:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:18:1: B901 blind except: statement
plone/app/discussion/testing.py:19:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:80:14: Q000 Remove bad quotes.
plone/app/discussion/testing.py:110:10: Q000 Remove bad quotes.
plone/app/discussion/testing.py:113:10: Q000 Remove bad quotes.
plone/app/discussion/testing.py:119:10: Q000 Remove bad quotes.
plone/app/discussion/tool.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tool.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/upgrades.py:0:1: C101 Coding magic comment not found
plone/app/discussion/upgrades.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/vocabularies.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/__init__.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_catalog.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_catalog.py:77:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:95:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:102:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:123:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:130:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:146:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:161:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:179:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:187:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:200:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:212:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:223:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:231:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:238:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:265:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:284:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:292:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:332:40: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:365:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:371:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:414:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:421:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:435:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:435:49: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:538:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_comment.py:44:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:45:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:46:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:95:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:97:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:103:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:125:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:131:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:132:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:136:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:137:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:159:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:167:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:180:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:183:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:188:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:232:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:263:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:268:23: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:305:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:330:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:367:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:403:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:438:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:446:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:455:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:464:38: S001 found %s formatter
plone/app/discussion/tests/test_comments_viewlet.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_comments_viewlet.py:52:45: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:97:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:111:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:119:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:120:64: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:169:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:183:59: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:185:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_comments_viewlet.py:193:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:195:64: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:237:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:251:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:295:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:310:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:357:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:406:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:441:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:522:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:523:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:528:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:533:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:534:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:535:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:546:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:547:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:548:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:604:63: S001 found %s formatter
plone/app/discussion/tests/test_contentrules.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_contentrules.py:40:24: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:41:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:42:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:43:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:98:38: S001 found %s formatter
plone/app/discussion/tests/test_contentrules.py:102:38: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:103:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:104:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_controlpanel.py:32:18: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:39:56: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_conversation.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_conversation.py:27:1: B901 blind except: statement
plone/app/discussion/tests/test_conversation.py:85:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:87:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:90:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:437:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:442:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:447:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:452:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:842:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:846:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:851:38: S001 found %s formatter
plone/app/discussion/tests/test_events.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_events.py:89:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:142:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:155:38: S001 found %s formatter
plone/app/discussion/tests/test_events.py:175:38: S001 found %s formatter
plone/app/discussion/tests/test_functional.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_indexers.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_indexers.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_indexers.py:42:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:43:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:50:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:51:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:58:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:59:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:121:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:122:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:152:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:152:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_moderation_view.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_moderation_view.py:78:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:86:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:94:38: S001 found %s formatter
plone/app/discussion/tests/test_notifications.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_notifications.py:35:44: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:59:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:81:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:82:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:97:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:127:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:142:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:147:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:174:44: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:222:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:223:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:229:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:233:13: S001 found % formatter
plone/app/discussion/tests/test_robot.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_robot.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_workflow.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_workflow.py:90:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_workflow.py:129:38: S001 found %s formatter
plone/app/discussion/tests/test_workflow.py:195:38: S001 found %s formatter
plone/app/discussion/browser/__init__.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/captcha.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/captcha.py:54:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/comment.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/comment.py:49:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:49:20: S001 found %s formatter
plone/app/discussion/browser/comment.py:51:41: S001 found %s formatter
plone/app/discussion/browser/comment.py:57:10: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:96:52: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:99:40: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:99:58: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/comments.py:84:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:90:35: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:124:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:125:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:126:42: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:128:1: C901 'CommentForm.handleComment' is too complex (17)
plone/app/discussion/browser/comments.py:137:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:138:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:210:53: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:258:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:259:22: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:282:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:283:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:359:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:362:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:370:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:378:37: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:448:20: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:448:21: S001 found %s formatter
plone/app/discussion/browser/comments.py:494:17: S001 found %s formatter
plone/app/discussion/browser/controlpanel.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/controlpanel.py:26:10: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:84:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:85:48: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:90:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:91:40: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:91:41: S001 found %s formatter
plone/app/discussion/browser/controlpanel.py:107:46: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:113:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:120:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:122:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:125:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:128:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:132:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:138:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:164:46: Q000 Remove bad quotes.
plone/app/discussion/browser/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/conversation.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/conversation.py:15:1: B901 blind except: statement
plone/app/discussion/browser/conversation.py:27:1: C901 'ConversationView._enabled_for_archetypes' is too complex (14)
plone/app/discussion/browser/conversation.py:133:12: P002 found "hasattr", consider replacing it
plone/app/discussion/browser/conversation.py:133:29: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/migration.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/migration.py:31:1: C901 'View.__call__' is too complex (32)
plone/app/discussion/browser/migration.py:38:19: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:42:16: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:74:26: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:76:31: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:77:22: S001 found %s formatter
plone/app/discussion/browser/migration.py:175:25: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:175:26: S001 found %s formatter
plone/app/discussion/browser/migration.py:185:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:185:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:199:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:199:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:200:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:200:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:201:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:201:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:203:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:204:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:222:21: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:223:31: S001 found %s formatter
plone/app/discussion/browser/migration.py:231:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:232:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:233:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:233:28: S001 found %s formatter
plone/app/discussion/browser/migration.py:240:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:242:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:243:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:244:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:246:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:247:13: S001 found % formatter
plone/app/discussion/browser/migration.py:251:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:251:18: S001 found %s formatter
plone/app/discussion/browser/migration.py:255:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:256:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:260:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:261:17: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/moderation.py:104:19: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:105:22: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:138:17: W503 line break before binary operator
plone/app/discussion/browser/moderation.py:143:17: W503 line break before binary operator
plone/app/discussion/browser/moderation.py:182:15: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:183:18: Q000 Remove bad quotes.
plone/app/discussion/browser/traversal.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/traversal.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/traversal.py:32:20: Q000 Remove bad quotes.
plone/app/discussion/browser/validator.py:0:1: I002 no .isort.cfg file found


Here (and below), it might be better to name the function in a way that is descriptive of the functionality rather than including the packet name, in case the packets that need this function change in the future. For example, "encodeBrief" or "encodeTidAndReason" or something along those lines.


(nit) prefer: `floatVal := float64(value.IntValue)`


Lo so ma è la prima volta che lavoro con sta roba D:  di solito fixo non creo, ma mi interessa sapere se l'Inventario va, tra poco lo metto e copio un pò di codice dalla fornace


Or just `specVal.value = float64(value.IntValue)`


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26771/testReport/) for this commit**


@gforcada
 ```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/__init__.py:0:1: I002 no .isort.cfg file found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/__init__.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/catalog.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/catalog.py:81:17: Q000 Remove bad quotes.
plone/app/discussion/comment.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/comment.py:65:28: Q000 Remove bad quotes.
plone/app/discussion/comment.py:160:40: Q000 Remove bad quotes.
plone/app/discussion/comment.py:162:30: S001 found %s formatter
plone/app/discussion/comment.py:166:48: S001 found %s formatter
plone/app/discussion/comment.py:201:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
plone/app/discussion/comment.py:295:21: Q000 Remove bad quotes.
plone/app/discussion/contentrules.py:0:1: C101 Coding magic comment not found
plone/app/discussion/contentrules.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/contentrules.py:18:5: E731 do not assign a lambda expression, use a def
plone/app/discussion/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/conversation.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/conversation.py:57:27: Q000 Remove bad quotes.
plone/app/discussion/conversation.py:431:29: Q000 Remove bad quotes.
plone/app/discussion/events.py:0:1: C101 Coding magic comment not found
plone/app/discussion/events.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/interfaces.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/interfaces.py:133:17: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:159:65: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:213:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:239:21: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:257:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:261:23: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:268:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:271:23: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:279:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:296:25: Q000 Remove bad quotes.
plone/app/discussion/patches.py:0:1: C101 Coding magic comment not found
plone/app/discussion/patches.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/patches.py:25:46: Q000 Remove bad quotes.
plone/app/discussion/subscribers.py:0:1: C101 Coding magic comment not found
plone/app/discussion/subscribers.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/testing.py:0:1: C101 Coding magic comment not found
plone/app/discussion/testing.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/testing.py:17:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:18:1: B901 blind except: statement
plone/app/discussion/testing.py:19:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:80:14: Q000 Remove bad quotes.
plone/app/discussion/testing.py:110:10: Q000 Remove bad quotes.
plone/app/discussion/testing.py:113:10: Q000 Remove bad quotes.
plone/app/discussion/testing.py:119:10: Q000 Remove bad quotes.
plone/app/discussion/tool.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tool.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/upgrades.py:0:1: C101 Coding magic comment not found
plone/app/discussion/upgrades.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/vocabularies.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/__init__.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_catalog.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_catalog.py:77:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:95:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:102:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:123:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:130:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:146:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:161:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:179:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:187:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:200:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:212:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:223:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:231:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:238:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:265:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:284:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:292:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:332:40: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:365:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:371:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:414:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:421:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:435:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:435:49: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:538:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_comment.py:44:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:45:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:46:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:95:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:97:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:103:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:125:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:131:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:132:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:136:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:137:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:159:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:167:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:180:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:183:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:188:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:232:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:263:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:268:23: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:305:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:330:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:367:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:403:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:438:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:446:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:455:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:464:38: S001 found %s formatter
plone/app/discussion/tests/test_comments_viewlet.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_comments_viewlet.py:52:45: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:97:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:111:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:119:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:120:64: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:169:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:183:59: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:185:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_comments_viewlet.py:193:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:195:64: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:237:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:251:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:295:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:310:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:357:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:406:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:441:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:522:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:523:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:528:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:533:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:534:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:535:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:546:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:547:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:548:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:604:63: S001 found %s formatter
plone/app/discussion/tests/test_contentrules.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_contentrules.py:40:24: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:41:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:42:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:43:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:98:38: S001 found %s formatter
plone/app/discussion/tests/test_contentrules.py:102:38: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:103:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:104:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_controlpanel.py:32:18: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:39:56: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_conversation.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_conversation.py:27:1: B901 blind except: statement
plone/app/discussion/tests/test_conversation.py:85:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:87:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:90:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:437:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:442:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:447:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:452:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:842:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:846:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:851:38: S001 found %s formatter
plone/app/discussion/tests/test_events.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_events.py:89:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:142:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:155:38: S001 found %s formatter
plone/app/discussion/tests/test_events.py:175:38: S001 found %s formatter
plone/app/discussion/tests/test_functional.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_indexers.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_indexers.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_indexers.py:42:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:43:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:50:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:51:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:58:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:59:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:121:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:122:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:152:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:152:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_moderation_view.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_moderation_view.py:78:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:86:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:94:38: S001 found %s formatter
plone/app/discussion/tests/test_notifications.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_notifications.py:35:44: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:59:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:81:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:82:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:97:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:127:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:142:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:147:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:174:44: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:222:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:223:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:229:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:233:13: S001 found % formatter
plone/app/discussion/tests/test_robot.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_robot.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_workflow.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/tests/test_workflow.py:90:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_workflow.py:129:38: S001 found %s formatter
plone/app/discussion/tests/test_workflow.py:195:38: S001 found %s formatter
plone/app/discussion/browser/__init__.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/captcha.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/captcha.py:54:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/comment.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/comment.py:49:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:49:20: S001 found %s formatter
plone/app/discussion/browser/comment.py:51:41: S001 found %s formatter
plone/app/discussion/browser/comment.py:57:10: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:96:52: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:99:40: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:99:58: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/comments.py:84:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:90:35: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:124:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:125:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:126:42: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:128:1: C901 'CommentForm.handleComment' is too complex (17)
plone/app/discussion/browser/comments.py:137:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:138:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:210:53: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:258:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:259:22: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:282:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:283:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:359:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:362:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:370:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:378:37: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:448:20: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:448:21: S001 found %s formatter
plone/app/discussion/browser/comments.py:494:17: S001 found %s formatter
plone/app/discussion/browser/controlpanel.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/controlpanel.py:26:10: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:84:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:85:48: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:90:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:91:40: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:91:41: S001 found %s formatter
plone/app/discussion/browser/controlpanel.py:107:46: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:113:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:120:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:122:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:125:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:128:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:132:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:138:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:164:46: Q000 Remove bad quotes.
plone/app/discussion/browser/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/conversation.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/conversation.py:15:1: B901 blind except: statement
plone/app/discussion/browser/conversation.py:27:1: C901 'ConversationView._enabled_for_archetypes' is too complex (14)
plone/app/discussion/browser/conversation.py:133:12: P002 found "hasattr", consider replacing it
plone/app/discussion/browser/conversation.py:133:29: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/migration.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/migration.py:31:1: C901 'View.__call__' is too complex (32)
plone/app/discussion/browser/migration.py:38:19: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:42:16: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:74:26: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:76:31: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:77:22: S001 found %s formatter
plone/app/discussion/browser/migration.py:175:25: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:175:26: S001 found %s formatter
plone/app/discussion/browser/migration.py:185:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:185:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:199:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:199:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:200:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:200:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:201:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:201:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:203:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:204:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:222:21: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:223:31: S001 found %s formatter
plone/app/discussion/browser/migration.py:231:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:232:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:233:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:233:28: S001 found %s formatter
plone/app/discussion/browser/migration.py:240:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:242:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:243:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:244:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:246:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:247:13: S001 found % formatter
plone/app/discussion/browser/migration.py:251:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:251:18: S001 found %s formatter
plone/app/discussion/browser/migration.py:255:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:256:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:260:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:261:17: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/moderation.py:104:19: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:105:22: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:138:17: W503 line break before binary operator
plone/app/discussion/browser/moderation.py:143:17: W503 line break before binary operator
plone/app/discussion/browser/moderation.py:182:15: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:183:18: Q000 Remove bad quotes.
plone/app/discussion/browser/traversal.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/traversal.py:0:1: I002 no .isort.cfg file found
plone/app/discussion/browser/traversal.py:32:20: Q000 Remove bad quotes.
plone/app/discussion/browser/validator.py:0:1: I002 no .isort.cfg file found

```


Given that we don't have that many threads, we probably don't need to reserve the vector size ahead of time.


The following doc(s) have been deployed to the [evalbuild](http://evalbuild-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/drupal](http://evalbuild-static-docs.pantheon.io/docs/articles/drupal)


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#V-mhLgG5T5iwUfIRBmB3aA


Note that in NixOps you can already avoid a dependency on the channel state by doing `nixops create/modify -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/<commit>.tar.gz`.


(nit) I feel like `Spec` or `Descriptor` might be a more appropriate name than `Ref`


Grammatically fine. I don't know enough about interior point methods to know if it's also true :)


I'm not sure if there is any performance benefit but I know that using `:find` throws an error if not found whereas `:find_by` returns `nil`.


What's the difference between gauge and delta? Is it just how they're calculated? Do we really need both?


Should we rename this to `MetricCounter` to be more consistent with promtheus?


So easy! You may just have ruined the coming outdoors weekend! I want to make that graph more interesting, and see if I can do it without bloating the code.

The example worked straight outta the box, no fuss, including the interactivity! For reference, I'll report some boring details in case I or someone else struggle to reproduce on another computer.

You'll notice a missing node in the picture above, bottom left corner. I guess the first node? That one has coordinates 162, 742.

Currently on Julia 0.4.2 (0.4.3 seemed to have a very slow REPL on windows), using Atom editor with ink 0.3.2, julia-client 0.3.1. and language-julia 0.5.0. Windows 64 bit, NVIDIA Geforce GTX950 M

Ok, there is some insignifican noise. The one 'error' happens because you did't define a standard output for the type.
```
const gpu_position = point_robj[:position]    at graph_editing.jl:10
JuliaClient - Internal Error
BoundsError: attempt to access (50,)
at index [2]
```

And some redefinition warnings that you're probably aware of:
```
INFO: Recompiling stale cache file C:\Users\F\.julia\lib\v0.4\Images.ji for module Images.
WARNING: New definition
    _default
(GeometryTypes.HomogenousMesh{FixedSizeArrays.Point{3, Float32}, GeometryTypes.Face{3, UInt32, -1}, GeometryTypes.Normal{3, Float32}, Void, Void, Array{ColorTypes.RGBA{FixedPointNumbers.UFixed{UInt8, 8}}, 1}, Float32}, GLAbstraction.Style, Base.Dict) at C:\Users\F\.julia\v0.4\GLVisualize\src\visualize\mesh.jl:1
is ambiguous with:
    _default(Union{#G<:GeometryTypes.GeometryPrimitive, Reactive.Signal{#G<:GeometryTypes.GeometryPrimitive}}, GLAbstraction.Style{:lines}, Base.Dict) at C:\Users\F\.julia\v0.4\GLVisualize\src\visualize\lines.jl:85.
To fix, define
    _default(GeometryTypes.HomogenousMesh{FixedSizeArrays.Point{3, Float32}, GeometryTypes.Face{3, UInt32, -1}, GeometryTypes.Normal{3, Float32}, Void, Void, Array{ColorTypes.RGBA{FixedPointNumbers.UFixed{UInt8, 8}}, 1}, Float32}, GLAbstraction.Style{:lines}, Base.Dict)
before the new definition.
WARNING: New definition
    _default(GeometryTypes.HomogenousMesh{FixedSizeArrays.Point{3, Float32}, GeometryTypes.Face{3, UInt32, -1}, GeometryTypes.Normal{3, Float32}, Void, Void, Void, Void}, GLAbstraction.Style, Base.Dict) at C:\Users\F\.julia\v0.4\GLVisualize\src\visualize\mesh.jl:7
is ambiguous with:
    _default(Union{#G<:GeometryTypes.GeometryPrimitive, Reactive.Signal{#G<:GeometryTypes.GeometryPrimitive}}, GLAbstraction.Style{:lines}, Base.Dict) at C:\Users\F\.julia\v0.4\GLVisualize\src\visualize\lines.jl:85.
To fix, define
    _default(GeometryTypes.HomogenousMesh{FixedSizeArrays.Point{3, Float32}, GeometryTypes.Face{3, UInt32, -1}, GeometryTypes.Normal{3, Float32}, Void, Void, Void, Void}, GLAbstraction.Style{:lines}, Base.Dict)
before the new definition.
INFO: Recompiling stale cache file C:\Users\F\.julia\lib\v0.4\Compose.ji for module Compose.
WARNING: New definition
    map
(Any, Reactive.Signal...) at C:\Users\F\.julia\v0.4\Reactive\src\operators.jl:26
is ambiguous with:
    map(Function, Lazy.List...) at C:\Users\F\.julia\v0.4\Lazy\src\liblazy.jl:98.
To fix, define
    map(Function)
before the new definition.
WARNING: New definition
    map(Any, Reactive.Signal...) at C:\Users\F\.julia\v0.4\Reactive\src\operators.jl:26
is ambiguous with:
    map(DataType, Lazy.List...) at C:\Users\F\.julia\v0.4\Lazy\src\liblazy.jl:99.
To fix, define
    map(DataType)
before the new definition.
```


Small typo in _Plugin.php but I'll just fix it locally


Uh, this DOI export/registration is more and more complicated ;-)
I believe this is a buggy behavior because those articles seem to be exported/registered/updated however. Thus they should be considered here too.
The only concern I have is, if it was intended to omit the registered articles because of the money -- I believe that every update costs, or?
But, because they were actually not omitted, maybe to just change it here and consider/count also those registered articles. If the user sees that the number of articles is big (because it contains also those registered articles), he/she could still go and register those unregistered articles individually.
What do you think?


@elifoster Do you mind helping me test this? I don't have a configured Tilesheets / OreDict install anywhere in a dev environment currently, and it would be helpful if you don't mind.


@TR4Android good idea, did that for most of the tag processors using a base class instead of an interface.

However, this can't be applied to `TabLayout`'s or scrollable view edge glows, because they still have to be themed even if a tag isn't specified. The tag processors don't run unless the user explicitly sets tags.


I salute your keen observation. The active flag should be on the *users* table not on the *answers* table. I'll fix this _asap_


If the controller is always in a subprocess (which is what I was suggesting) then doing ``loop.run_until_complete(lda.set_attenuation(...))`` in the unittest with ``lda`` an asyncio RPC client is totally fine. Controllers crashing will result in RPC failures, at the latest when ``ctlmgr`` fails a ping and kills the controller, shutting down your unittest's connection.


Yes, was going to use my own stuff but then decided against it. Will change it to fake names and Apache/NiFi related things


Hello,
is it also possible to add a function that once a gallery has been played till end that it automatically starts showing from the first image in the gallery again.

like a Repeat function

kind regards,
Atal


The other option is fine too, with more fine-grained tests.


Agree, thanks!!! :-)


@lihaoyi lucky you, Lukas did it himself: https://github.com/scala/community-builds/pull/211, https://github.com/scala/community-builds/pull/212


Why link reference is empty?
For testing or development better use `<a href="#">...<a/>`


test


hum.. okay.


global comment


не нужно руками генерить события, т.к. события про изменение модификаторов всплывают совершенно аналогично — можно сразу подписываться на `search.on({ modName: 'opened', modVal: '*' }, callback)`, при этом в коллбек прилетит объект события, из которого будет возможность получить знание про текущее состояние модификатора


so fancy.


It's better to have empty line after end of file.


Для body настоятельно рекомендую задавать line-height через множитель, к примеру line-height: 1.5;


я предлагаю подписываться из `page`, выставлять модификатор на самом `page` и в CSS показывать  `sitemap` каскадом:
```css
.page_search_opened .sitemap {
    display: block;
}
```


Константы принято писать все буквы в Upper case, например: ConstantString.SUCCESS


@asmecher, you have eyes like a hawk :-)))


game_phase() cannot become smaller than PHASE_ENDGAME.


Can we call it build_dir or build? A think the readability benefit is probably worth making it a little longer.


I don't think that Rainloop has postfix and dovecot dependencies. It relies on other mail servers to operate.


wow nice


@Endarko
"Dead Or Alive" is actually the name of [a game](http://www.gamefaqs.com/psp/981957-dead-or-alive-paradise), you must not translate it...
Therefore this line should be the following :
```
Sound speed hack (DOA etc.) = Retas kacepetan swara (Dead Or Alive, lan sapiturute)
```


instead of `_.extend` you can use ES2015 ;)
`{ ...additionalProps, dangerouslySetInnerHTML: {__html: this.data.text}}`


Requiring an `AsyncioClient` would be a bit limiting since I would expect most use of controllers to be through synchronous `Client` in experiments. I'll split the stuff.


Эти строки излишни. putExtra() мы используем только тогда, если хотим передать какие-то данные в активность, которою вызываем.


Тут тоже.


Try this one and let me know if it helps. Hopefully it will.
```
diff --git a/cmake/genrev.cmake b/cmake/genrev.cmake
index 385e200..3cfa223 100644
--- a/cmake/genrev.cmake
+++ b/cmake/genrev.cmake
@@ -51,6 +51,7 @@ if(rev_unstaged_changes)
   if (CMAKE_BUILD_TYPE)
       message(STATUS "WARNING - Unstaged (uncommitted) changes were found.")
   endif()
+  set(rev_id "${rev_id_str}")
   set(rev_id_str "${rev_id_str}+")
   set(rev_hash_str "${rev_hash_str}+")
 endif()
```


Please add this also in the german version. `year: "Jahr"`


lgtm


Is this your last commit?


Both clients speak the exact same protocol, the controller doesn't know which one is used.


Delete the read me file.


Add comment to other methods


Very good! I think you'll be very good developer!!!
Take care!
[Like her? :cake:](https://vk.com/id42374517)


Такого шрифта нет, есть PT Sans. Regular, bold - в данном случае начертание, обычный и жирный.
Соответственно, пишем `font-family: "PT Sans";`
Кроме того, лучше сразу привыкать прописывать парочку запасных шрифтов, которые гарантированно будут на компе у пользователя, и семейство шрифтов.


@uty это поле называется volume_type.

У libcloud в RESOURCE_EXTRA_ATTRIBUTES_MAP уже есть аналогичное поле https://github.com/Scalr/libcloud/blob/8e5c42a11614c44874373a70dba96f61494cca4c/libcloud/compute/drivers/ec2.py#L1799, но для другого респонза - blockDeviceMapping

Надо будет следующим PR-ом (вместе в KMS) привести это в порядок


Heh. I'm terrible at naming things. Updated to use `checkSigs`. https://github.com/ximinez/rippled/commit/35e5e7a6c8b8fa1827a3a0621c4fb1afc6ea6dee


Cumulative matches [Google Cloud Monitoring API](https://cloud.google.com/monitoring/v2beta2/metricDescriptors#resource). WDYT?


Она будет вести на страницу продукта? Или просто увеличиваться?


Guage is usually instantaneous, whereas Delta signifies rate. I guess those are hints to the user of the API, not really a requirement to represent data in the API.


:+1: @andela-ooranagwa


SGTM. I tried to not use the keyword `Spec`.


But you would not be testing `Client` and you would not be testing stuff under typical conditions as they would be used in experiments.


Move to secure settings


I think we should put this exclusion in uberfire-api directly. That way it is done at one place and we don't need to exclude every module that uses it. WDYT?


This comparison assumes the pixel format is 8 bpp. It should query the 'format' member variable, then read and compare the correct number of bytes.


This is one such case of a misinformation by `github` :smile: notice that `github` isn't displaying the whole schema. Use the `view` button for a full display of the file content.


I had to rollback your change since it was causing problems with our Razor based website.
I had a colleague with a Mac test your scenario and using $* worked for him when he tested code 'a b' 'c d'.


Yeah, actually we should just try to maintain consistency with cAdvisor which uses Cumulative. Sorry for the distraction :)


``Client`` is already tested in another unittest. Anyway, I'm fine with splitting as I said.


Do we want to disable these or make them invisible? (i.e. `setVisible(false)`). Traditionally we make unavailable commands invisible (the notion being that they "light up" when the requisite version of R is installed.


Probably not needed


Obvious remove all the stuff that we don't include


Need to leave that in or we get a visual bug on the nav


This is a test util, so it shouldn't be called from anywhere real.


**TODO:** Adjust to `SHOP_DATA`  & `fedoraschestshop:shop_data`


We aren't PAC, besides lets use Settings Secure vs own special sauce


stragegy


I'm wondering if it even makes sense to have this here? It doesn't seem to have any practical use at this level, i.e. `http.client.reactive`. It becomes relevant at the higher `web.client` level so that points to having it there.

Another sign of this is seeing `RequestBuilder` extend `HttpRequestBuilder` s where the names suggest the opposite. So there it might naturally become `HttpRequestBuilder` with a `DefaultHttpRequestBuilder`.


LGTM


@realalexhomer what bug is that? Maybe there's an alternative workaround?


Same as above lets use Secure setting vs PAC


:smile:


**TODO:** Remove these things, it was just a test >.>


Названия картинок можно и покороче, зачем усложнять себе жизнь?) А то, что это "img", оно и так понятно


Probably should be removed


whitespace


**TODO:** OCD, make it look like `getEconomyService()` (i.e. on one line)


nit: I believe taking the texture from the surface implicitly flushes the canvas since it implicitly destroys the surface.  If not, I might just add a flush to ganesh_texture_surface.


We have PG in security not in settings dashboard


Cool!


very good css;
when you'll finish with your 'developer stuff' try to go deep in layout and try SASS. It's awesome - loops, ifs and more in css files :+1:


Move PG inside SecuritySettings, make sure names checkout


- Для начала, давай поселим модуль в отдельный файл. Он же все таки реюзабл компонент ;)
- Я бы еще структуру немного поменял. Добавил бы папки js, css, а в них файлы Todo.js и todo.css. Есть еще вариант делать отдельную папку на модуль и уже в нем делать js и css.


Testing my first repository


Since inside Security Settings no need all of this, besides names are incorrect


Away with you


Sorry for the massive diff, moved over to my mac and lots of the XML changed :file_folder:


nit: not needed


Pretty sure this isn't needed


Ack


Since we use Settings Secure, lets adjust the code in settings as well.


Many small fixes to do, m8.


Good catch! I've fixed the code -- it should propagate to GitHub in a few minutes.


Should this be copied into `public/fixtures/test-data.json`?


No you don't need the argument at all, the second one


This also assumes 8bpp. A fix would be:

Common::copy(srcP, srcP + srcBounds.width() * format.bytesPerPixel, destP);


Actually i never use apiMethods nor serializedApiMethod, this is master branch actual code, coming from accepted pull request https://github.com/chrisbjr/api-guard/pull/85


Hey there is some thing wrong in that code


Its an  invalid `JSON` also, i think it should be `head :no_content` or status 204 may be the best response here


Что-то мы поговорили, что тип гостиницы и цена - это разные данные и их нужно разделить, но не реализовал.


Oops. Misread the existing methods.


Здесь нужно немного оптимизнуть. Нужно найти элемент с id вот так:
```javascript
var rootEl = $(id);
var textEl = rootEl.find('.textBox');
...
```


@chrisbra This commit has introduced a bug. If I split windows vertically and try to move from right window to left, a red error appears on the status line. This error doesn't appear prior to this commit.
I'm in neovim and I don't use YouCompleteMe.


Done


Thank you!


这里添加了注释


We could probably just remove the Android bit here since this is QNX.


А вот здесь можно обойтись без абзаца - внутри этого дива только один элемент - текст, тут никаких сложностей не будет.


I had that line because the field was a pointer. Forgot to update it after I got rid of the pointer. Updated


这里


Do we really need this commit? Imagine in the future a bugfix patch for libjson appears, and we want to integrate it into our version (this is the reason why we created a patch file of my edits to support large integers). Applying it to our version will be painful, it will for sure conflict with this huge commit. All this just to fix the indentation of a library we are using, not maintaining? Really, I doubt this will be of any use.


Sure, will do though I didn't observe any performance impact from making this change. Do you like the approach? If so, I'll put it in the ruby and python 3 modules and re-submit this PR.


lgtm


I think we may have worked around this but the main reason you solution does not work is that we are running in a wordpress multisite setup site specific themes are something we avoid for maintenance reasons.


Ты можешь не создавать анонимную пустую функцию здесь и на click() ниже. Можно воспользоваться функцией Function.bind(). Она может принимать параметры, которые пойдут в функцию ;)


Ok, I have a question about this: By 'resulting list' you mean the resultSet field, right? If that's so, I should make public the resultSet field, or create a public method isEmpty that verifies if the resultSet is empty (the latter seems more appropriate).


also there is a `rails` method that now allows you to write a more elegant code `try`, here it would be `@question.try(:destroy)`
Also the variable ought to be a single resource therefore `@question` not `@questions`


@afollestad True, but you could still use the same static method, or is there anything preventing that?


Error:(79, 32) error: cannot find symbol variable success
Error:(88, 32) error: cannot find symbol variable wrongPassword
Error:(92, 32) error: cannot find symbol variable wrongLogin
Error:(96, 32) error: cannot find symbol variable error


I have a mild concern that a misformed R version number (e.g. one with 2 or 4 "places" returned by an R distro we don't see a lot of) could cause an exception to be thrown in ApplicationUtils.compareVersions thus making the product fail to load. We could either:

1) Make our code robust against this possibility
2) Try/catch and fail the version check if an exception is thrown ("rouge" version number automatically disqualifies)
3) Do the comparison on the server using `r::util::hasRequiredVersion` (which ends up calling into R to do the version comparison) then using this to set values in SessionInfo


final


@timstclair: I updated the patch. PTAL.


Здесь тоже можно заюзать bind() с параметрами.


@gforcada Jenkins CI reporting about code analysis
```
Traceback (most recent call last):
  File "/home/jenkins/workspace/package-plone.app.discussion/bin/flake8", line 30, in <module>
    sys.exit(flake8.main.main())
  File "/home/jenkins/.buildout/eggs/flake8-2.5.1-py2.7.egg/flake8/main.py", line 33, in main
    report = flake8_style.check_files()
  File "/home/jenkins/.buildout/eggs/flake8-2.5.1-py2.7.egg/flake8/engine.py", line 180, in check_files
    return self._retry_serial(self._styleguide.check_files, paths=paths)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.1-py2.7.egg/flake8/engine.py", line 171, in _retry_serial
    return func(*args, **kwargs)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1842, in check_files
    runner(path)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.1-py2.7.egg/flake8/engine.py", line 125, in input_file
    return fchecker.check_all(expected=expected, line_offset=line_offset)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1574, in check_all
    self.check_ast()
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1521, in check_ast
    for lineno, offset, text, check in checker.run():
  File "/home/jenkins/.buildout/eggs/flake8_debugger-1.4.0-py2.7.egg/flake8_debugger.py", line 23, in run
    with open(self.filename, 'r') as file_to_check:
IOError: [Errno 2] No such file or directory: '{top-level}'

```
You can always test the configuration using: qa.cfg


It's my favorite part of development!

Your comments, of cause)


HOW Long r u going to learn the git my dear friend.


This is Too much to say about that.


This would be a little bit shorter: `errors.push.apply(errors, ...)`, or do you have some other reason to do it this way?


Upgrade progress error:
Error Code(0): Error: Could not load model upgrade/1000!


You may want to leave this out for now, till the `votings` is implemented. We would be querying another table for the votes, so you may want to pause `chill` we have that in place


idem


@Andriamanitra https://github.com/weechat/scripts/pull/141


Этот метод можно упростить до:
```javascript
JSON.parse(localStorage[rootId]) || [];
```


yrt


unnecessary closing tag


It's good


Yeah, I noticed it as well. #960  should fix it. please test.


1. drawn_on関数でロックを取得
2. draw_func内で描画系関数を呼び出す
3. 描画系関数がロックを取得しようとする
4. ~~デッドロック~~と思ったらVisual Studioはエラー出して強制終了になった
#4


Useless empty line.


Is there any reason why you decided to add the main method back into the TimetableGUI class? Another class named TeamProject.java had already been created containing it.


Fixed PHPDoc


Minor: Perhaps we should put a newline at the end to appease this.