This whole file's changes are spurious - they are just duplicating lines already present - presumably a merge artefact.


Didn't want to send empty list to operator


And my dear brother, when the console is enabled, when will this callback be called?


Are there a specific example(s) of projects impeded by this change? - I am under the impression the METADATA.json files are not widely used.

The protobufs offer a cross-platform replacement but if someone really needs json it could easily be generated from the protobufs.


This test passes, it's broken.


Done.


Sweet. But this won't work on all cases, say if the user has tex unit 3 active, it will fetch sampler at that tex unit on save, then bind it to tex unit 0 on restore, mixing up all the state. This will only work if the user binds tex unit 0 before calling nifty.render().

What you need is:

On save:
- Store currently active tex unit. (could be any)
- Activate tex unit that Nifty will use. (GL_TEXTURE0 afaik).
- Store sampler bound at the tex unit Nifty will use.

On restore:
- Activate tex unit Nifty uses. (GL_TEXTURE0)
- Restore sampler bound at that tex unit.
- Activate tex unit that was bound before Nifty rendering. (could be any)


I see that this is only meant for arg5 and arg6 then why have arg1, arg2 for everything else?.


**Line is longer than allowed. (135 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 147 column 121 to line 147 column 136*.


**Line is longer than allowed. (135 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 148 column 121 to line 148 column 136*.


**Line is longer than allowed. (139 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 149 column 121 to line 149 column 140*.


**Line is longer than allowed. (135 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 153 column 121 to line 153 column 136*.


**Line is longer than allowed. (136 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 147 column 121 to line 147 column 137*.


True! I didn't know you could do that with Typescript.


This is really a breaking change and might be best targeted at 3.x.


Well, you could check for that during function creation also. The question is how much time/memory/etc it saves not setting it when the function ends up unused.


Created without error!


Кстати, ещё одна мелкая, но важная деталь — отступы. Ты по-прежнему используешь табы, и вот в гитхабе видно, что выглядит это эээ странно (потому что у гитхаба иное чем у тебя, представление о дефолтном размере таба).

Поскольку всё равно придётся переучиваться, как только начнёшь с кем-нибудь работать хоть в коммерческих, хоть в опенсорсных проектах, лучше сразу настроиться на то, что общепринятое форматирование — отступ в два пробела, именно пробелами.


This commit shouldn't be in here, a rebase and force push should get rid of it


reset to previous commit


I won't be working on this project anymore. Also there is nothing to "fix". It's just missing stuff because lack of interest.


Makes the tests start running, but they don't complete. Suspect it is something introduced since they were last run 2 months ago, but can't confirm.


I don't really understand this change... It isn't very clean to expose this as public, because users are forced to call it to have a complete object. And it is only called from ContentLoader unless I'm mistaken, which seems identical to having it called from the constructor, no?


Hello,
1. may I ask what the manually including is good for?
2. using #ifdef Q_OS_WIN instead #ifdef QT_OPENGL_ES_2, will make it harder to support OpenGL (not ES)  on windows in the future.
Regards,
Gunnar


Is this working implicitly now?


:trophy: thanks!


Checkmarx scan results 12 Jan 2016 17:35 UTC +00:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
4
33
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

ad030f7b673e3ef26e01d1ede8d18e7229e0908c	@macxil


updated


Hi @smartkid77

The timelineDay view is for the premium Scheduler add-on right? I don't have access to that. You better contact the developer of the project at http://arshaw.com/

Sorry :(


Методы, которые выполняют какую-то работу, в большинстве случаев принято называть «глагол» или «глагол_существительное» или в крайнем случае «глагол_существительное_уточнение», то есть в данном случае `parse_csv`.


> **messageRepeatCountUpdated**
> Is not issued. Will be gone in the future versions of the protocol.

See https://chromedevtools.github.io/debugger-protocol-viewer/Console/#event-messageRepeatCountUpdated


Olá,
Meu nome não está na lista, Everton Junior da Silva Costa.
Poderiam gerar um certificado para mim, obrigado!
Grande abraço!


leftover from previous CORS filter implemenation. removed.


OK, looks fine.


И, кстати, поскольку этот метод используется только самим же классом, прилично будет сделать его приватным (то есть недоступным никому, кроме самого же класса).


I am, but how does that work exactly? Just install the gem like on _http.rb line 22 and it drops the check code in place?


Thanks for the feedback. There's now a new and improved Nock repl that uses the new `nock_on` API to keep a persistent subject.


same thing


Maybe the name `console_handler` here is now a bit misleading?


Ah shoot! Let me fix this! :scream:


Why introduce this? Looks like a hack, sending this before the background is even restored. If REALLY needed please add a comment in the code for future reference.


Кстати, названия колонок таки хорошо бы символами сделать, а не строками (короткий синтаксис для массива символов без лишних `:` и `,` — `%i[]`).


ObjexxFCL41 (DeadParrot) - Win64-Windows-7-VisualStudio-12: OK (2062 of 2062 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Is ParallelsDesktop.munki dependent on any of the other Parallels recipes? After running it on a test machine I get "Parallels cannot start with Problem ID 15431"

Do I also need to run ParallelsDesktop.install recipe?


We should comment here why this is happening.


Seems like all the function does is setting a variable and maybe allocates a little space for certain function attributes, if not allocated yet.


Should this be `done` ? You are not returning the promise. Otherwise we will eat errors.


of course!
we should retrofit the whole code ;-)


Хз как просочился. надо его удалить, да и все что связано с Сассом


"Variable $a cannot be used both as a parameter and lexical variable"?


@ldoktor about sending the full exception, I think there was something to it. I don't have time to implement the solution you prefer, so if you don't like this I can keep this as a local workaround (although it'll force me to start rolling my own avocado rpms and tell my team to use it instead of upstream).

With the broad exception handling, I think it's safe to assume the queue is safe, though.


Why are these fat arrows? These are set up using listenToOnce, which binds to the listener, which is this modal instance.


Checkmarx scan results 12 Jan 2016 17:41 UTC +00:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
4
33
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

ad030f7b673e3ef26e01d1ede8d18e7229e0908c	@macxil


This looks good so far.


Лол
$ alembic upgrade head
/home/sly/work/echoba
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
ERROR [alembic.util.messaging] Can't locate revision identified by 'b76e2309cad5'
  FAILED: Can't locate revision identified by 'b76e2309cad5'


Здесь, про название метода, либо аналогично предыдущему (`select_by_genre`), либо — как раз тот случай, когда для читабельности можно и сократить название — просто `by_genre`. То есть в коде оно будет выглядеть `list.by_genre('Comedy')` — вполне читабельно. А вот `list.include_genre('Comedy')` — это получается что? «В список, включить жанр Комедия»?..


About the gmail address, I've been doing so many things I end up forgetting which one to use. It's fine either way.


Apparently, this is a known issue, the test for `floor` in Julia is commented: https://github.com/JuliaLang/julia/pull/13692


These methods are way too long for my taste. Smaller methods will help with self documentation IMO.

Up to you.


Так вот все работает


Don't follow the response: My suggestion simply avoids creating a new ArrayList if one is already present in order reduce GC pressure; other than that it should be exactly equivalent to what you had since the ArrayList will get populated the same way.


@Simn Please review, I'm not sure I did it right, since I just added a `TMeta Meta.Pure` case in all places where I found the `is_pure` check.


According to the docs, `logging.getLogger` should receive a logger name, not an instance. It looks like the instance `__str__` method is kicking in here and avoiding breakage.

The real question, though, is: why use that instead of `logger.addHandler` like it was before this change?


Removed this statement as it may not work in all the situation.


was pasted from sibling test fixtures. replaced with startsWith


@hpi1 fyi. If async is wanted, then the shift is wrong.


Это остроумный ход! Но лучше не лезть в кишки фильма (какие у него там instance_variables — это его приватное дело), а спросить «есть ли у него такой метод», при помощи `respond_to?`
И кода меньше получится :)


Bom, a primeira coisa é entender o que é repositório e o que é um serviço e porque um não pode implementar a interface do outro.

A segunda coisa é: Por que expor para o controller quais colunas ele quer e não retornar um objeto que ele possa manipular?

Acho que se você conseguir responder essas perguntas você vai seguir um caminho melhor. Se não conseguir eu faço uma PR e marcamos um dia pra fazer um hangout e codamos juntos, pode ser?


Тут less пытался подцепить - не хочет нормально бутстрап собирать, округляет проценты до целых и всё распадается


obvious and intuitive :)


В таких случаях (пользователь сделал что-то, чего делать нельзя) лучше бросать исключение (raise exception).


was ```step&7``` a typo here?


I saw an error when testing and wasn't sure if something might have gone wrong with that. Probably then instead the bug was that the modal was garbage-collected before this callback fired, which would be a separate bug insofar as our analytics wouldn't be right... why would that happen?


Hello World


Also, the official docs (which is what most people will read), still references SSH: https://github.com/discourse/discourse/blob/master/docs/INSTALL-cloud.md


There is the answer to my previous question: you're using the logger name. Then I'd recommend to change the docstring in `add_log_handler()`, that is:

```
:param logger: name of a given logger that will be retrieved with :func:logging.getLogger
```

Or something like that.


Checkmarx scan results 12 Jan 2016 17:45 UTC +00:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
4
33
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

ad030f7b673e3ef26e01d1ede8d18e7229e0908c	@macxil


The function should move to the next line to match up with the error handler.


On Tue, Jan 12, 2016 at 4:48 AM, Junki Kizuka <notifications@github.com>
wrote:

> By the way, HP EliteBook Folio *1020* G1 also have ForcePad.
> This is not supported yet ?
>

The issue with 1020 is that the touchpad is I2C device and we do not have
driver for I2C controller (Microtech?)  used in that laptop model.

Thanks.

--
Dmitry


Extra indent?


Because the PWM node is awkward to set up using ports.


Extra indent.


Since null and undefined are falsy you could simplify this check to this:
if (controllers[1]) {...}


I see your point. But if the $set operation is used as you suggested, the user anyway cannot submit a manipulated comment object.
Also I think going to the database to fetch the actual comment would be an overkill. Generally such frameworks have a csrf verification mechanism for each submit, such that malicious content can be blocked. I am not sure what Meteor has for csrf verification, but if it exists, it would be good practice to add it.


Why do we have a `then` here if we dont do anything?


Spelling error


Why are we not using map here?


А вот важное про разделение ответственности: мы предполагаем, что пишем какие-то Полезные Классы (допустим, с этого можно было бы начать разработку Личного Менеджера Просмотренных Фильмов или полезной Библиотеки для Хранения Видеотеки). Соответственно, ответственность класса MovieList — фильмы хранить и выдавать всякие списки. А вот красиво печатать эти списки должна вызывающая программа. В ней для этого можно сделать метод `print_films` и всё в сумме будет выглядеть как-то так:
```ruby
list = MovieList.new(...)
print_films list.by_genre('Comedy')
print_films list.sort_by(:title)
```


Not standard indentation.


Why do we have a `then`.


I think instead of throwing a TE if the objects aren't the types needed, we should have an if/else so we can add to it easily.


got it.. I will update it


Any reason why we return `undefined`?


Volume up and down on the Nvidia Shield Controller?


И вот в таких случаях тоже принято символы использовать (т.е. `sort_by(:title)`). Строка — это обычно _пользовательский контент_ (что может быть прочитано из файлов или из сети, введено пользователем и т.д.), а символ — внутренние обозначения сущностей в твоём коде (мы заранее знаем, какие поля есть у фильмов — значит, это символы).


Any reason why you are wrapping this function in anonymous fns?


Hvorfra ved du at den ikke har været brugt i lang tid?  Der er ingen tvivl om den bør rettes, men grundidéen er vel stadig fin til formålet?


Can this be removed?


FilteringTest is a model as it inherits from ProductTest .  It may be that it needs to have Mongoid::Document included in the file though


Any reason for the anon. fn wrapper?


No new line at the end of file!?!?


Space after curly.


Checkmarx scan results 12 Jan 2016 17:50 UTC +00:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
4
33
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

ad030f7b673e3ef26e01d1ede8d18e7229e0908c	@macxil


Are missing a return here?


Rodmappen var grim.  Hvis den skal bruges igen, må folk dykke ned i historikken.

Forresten vil jeg stadig gerne have en separat mappe til web, men det kræver lidt ændringer i Troels' lightttpd.conf-fil.


Might want to make 500 a constant.


Ужасно длинное название метода (продолжаем выбирать хорошие имена)! Во-первых, `top_longest` — это тавтология, достаточно `longest`. Во-вторых, список у тебя и так фильмов — ты ж не дописываешь к названию каждого метода `films`? То есть названия `longest` для этого метода будет достаточно :)


oui


It probably should be an & -- thanks!


A comment in the module pretty please.


Просто `directors` будет ок.


Does it have to be `v:version > 704 || v:version == 704` or couldn't it also be written as `v:version >= 704`?


This could use a test. @nwinter want to take a stab, or should I?


No, on any smartphone

On Tue, Jan 12, 2016 at 12:48 PM, diablodiab <notifications@github.com>
wrote:

> Volume up and down on the Nvidia Shield Controller?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/libretro/RetroArch/commit/f374af9dbc6392419b1cab39807be640ec984f06#commitcomment-15403673>
> .
>


ObjexxFCL41 (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (962 of 962 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.15%25-green.svg)


Idéen om en grundmappe til web er ingen dårlig idé, det har jeg sådan set været fortaler for.  Men du bør nok fjerne referencerne til denne graf fra hovedsiden.


How committed are you to making this change, given that vlans in another app comes at a non-trivial performance penalty? This change is essentially reverting to what we had for the alpha release.


Looks good.


Вот тут важное про разделение ответственности. Класс Movie у тебя отвечает за все данные о фильме — а значит, это его ответственность чтобы duration была в удобном формате (то есть целым числом).


Падает с ошибкой:
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-2: ordinal not in range(128)
если использовать русские буквы при создании треда. При этом создаёт запись в таблице thread, но не создаёт в message. В результате падает при попытке отобразить список тредов


AddNetAreaColumnToEnvelopeSummary (mbadams5) - x86_64-MacOS-10.9-clang: OK (2046 of 2046 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Аналогично замечанию про duration — это ответственность фильма, чтобы дата была объектом класса Date (либо nil, если известен только год).


LGTM, possibly excluding the decrement-TTL changes, which rely on the previous patch.


On 2016-01-12 09:51:33, svip wrote:
> Idéen om en grundmappe til web er ingen dårlig idé, det har jeg sådan set været fortaler for.  Men du bør nok fjerne referencerne til denne graf fra hovedsiden.

Der var ikke nogen referencer til lige den graf.


Based on a quick search, it looks like all environment variables we currently deal with are prefixed with `AVOCADO_`. I'd suggest we keep it like that, so, I'd name this `AVOCADO_DEBUG`.


And I'd name this `AVOCADO_DEBUG_EARLY`.


Hi @puckett15, I think that it is important to keep the `&` pass-by-reference symbol there. This way me make explicit we are passing it by reference.


This patch gets rid of debug information. Not ok.


Ok, I'll make sure to test for that besides the problem I noticed myself.

I hope the implementation is still welcome once I've found a solution, if not then please let me know and i'll just keep it in my own branch for my own use :)


Sorry, I'm almost ok with this. But this part (Exception) needs to be checked and completed first https://github.com/clearlinux/python-lkvm/blob/master/python_lkvm/lkvm.py#L33-L34 . There's no implementation for this yet.


Would a grunt task enforcing this style be sufficient?


please configure this appender to go to stderr.


Good catch!  While I know in general it is good to compare floats with floats rather than doubles, I would not have realized that this was an actual problem here!


Does this `__init__` method have to exist? It's only slightly different from the `__init__` that would otherwise be inherited, right?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11308](https://teamcity.mesosphere.io/viewLog.html?buildId=103508&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:09:25


copied from the solr project, I presume? Please include a reference to the source.


I think there should be a fallback to the old code if the callback function is unset. So that setting the callback has the effect of "replacing" the normal, built-in logic.


I think the functionality is great and will be very welcome once the few bugs/conflicts are worked out


This isn't working for me.  Shouldn't the "pebblejs://close#" not be included here, since it is in the 'return_to' variable, which is prepended to 'location' down on line 128?  Or, prepend it here rather than on line 128?


This function should be renamed. It's getting a payload offset, not a payload.


Typo: "Cythons'" -> "Cython's", right?


**Line is longer than allowed. (135 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 147 column 121 to line 147 column 136*.


Лол, а ещё понаоткрывал транзакций в postgres и оборвав соединение, в результате чего не смог в очередной раз нормально завершиться и освободить порт. Но это так, к слову


**Line is longer than allowed. (135 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 148 column 121 to line 148 column 136*.


**Line is longer than allowed. (139 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 149 column 121 to line 149 column 140*.


**Line is longer than allowed. (135 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 153 column 121 to line 153 column 136*.


**Line is longer than allowed. (136 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 147 column 121 to line 147 column 137*.


**Line is longer than allowed. (135 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 166 column 121 to line 166 column 136*.


If the modal was closed before the subscription call resolved, then that could be the source of the error.


Thanks Christian, make check works here.


> Can you confirm it works on old and new Borland? There's nothing worse than breaking something that used to work...

The C++Builder version I have access to are: XE2, XE5, XE6, XE7 and XE8. I was able to compile on C++Builder XE2, XE5 and XE6. I did not test yet on XE7 and XE8 with my last change, but XE8 was working before my last commit.

Here is the table of all C++Builder compilers and there support in each version:

Version         | BCC32 | BCC32C | BCC64 | BCCOSX | BCCIOSARM | BCCIOSARM64 | BCCAARM |
--------------- | ----- | ------ | ----- | ------ | --------- | ----------- | ------- |
2010 (14) 	    | yes   |        |       |        |           |             |         |
XE (15) 	    | yes   |        |       |        |           |             |         |
XE2 (16) 	    | yes   |        |       | yes    |           |             |         |
XE3 (17) 	    | yes   |        |       | yes    |           |             |         |
XE4 (18) 	    | yes   |        | yes   | yes    |           |             |         |
XE5 (19) 	    | yes   |        | yes   | yes    | yes       |             |         |
XE6 (20) 	    | yes   |        | yes   | yes    | yes       |             | yes     |
XE7 (21) 	    | yes   |        | yes   | yes    | yes       |             | yes     |
XE8 (22) 	    | yes   |        | yes   | yes    | yes       | yes         | yes     |
10 Seattle (23) | yes   | yes    | yes   | yes    | yes       | yes         | yes     |

It is impossible to test all this without CI.


(Looks good, but will probably be rebased?)


Also should be tested


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/22685/testReport/) for this commit**


LGTM in theory, but we really need a test for this code.


Checkmarx scan results 12 Jan 2016 17:58 UTC +00:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
4
33
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

ad030f7b673e3ef26e01d1ede8d18e7229e0908c	@macxil


I'd totally forgotten that was a thing.


Yessss...


Hm. Why is this unused? That merits looking into. If the non-use is not a lurking bug, this patch LGTM.


Should we make the scope "test"?


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/22686/testReport/) for this commit**


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/22687/testReport/) for this commit**


As in the other patch, this is a payload offset, not a payload.


Ok good, I'll return with an updated suggestion. Next time I make a pull request, I'm not in a hurry to have it merged, so please take your time to test and provide feedback :)

I understand that there are risks of breaking functionality such as the examples you have already found and some of you guys are able to test on a wider range of units than me.


Checkmarx scan results 12 Jan 2016 18:01 UTC +00:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
4
33
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

ad030f7b673e3ef26e01d1ede8d18e7229e0908c	@macxil


Там с миграциями все в норме? :) а то я все зафейлил


**Line is longer than allowed. (135 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 147 column 121 to line 147 column 136*.


**Line is longer than allowed. (135 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 148 column 121 to line 148 column 136*.


**Line is longer than allowed. (139 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 149 column 121 to line 149 column 140*.


**Line is longer than allowed. (135 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 153 column 121 to line 153 column 136*.


**Line is longer than allowed. (136 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 147 column 121 to line 147 column 137*.


**Line is longer than allowed. (135 > 120)**
*LineLengthBear, severity 1, section `default`.* *Related to file `babel/messages/extract.py`, line 166 column 121 to line 166 column 136*.


Судя по всему, какую-то версию найти не может:
$ alembic upgrade head
/home/sly/work/echoba
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
ERROR [alembic.util.messaging] Can't locate revision identified by 'b76e2309cad5'
  FAILED: Can't locate revision identified by 'b76e2309cad5'


Is this a gain over just calling pkt.free? Why?


Fixed in c34e94e4ebe035ca


What Spell? which Npc?


Finally,  :+1:


Sadly, no tracking issue yet -- have to accept the RFC first :)


LGTM


@alxndrsn wait but how does this equivalence check work `scope === _currentQueryScope` when they are objects (literals)?


well, building on android is such a pain that we usually merge and test
buildbot builds.
I think we should have a testing branch with automated builds, maybe even
with a different apk name to be able to have more people on board testing

On Tue, Jan 12, 2016 at 1:01 PM, diablodiab <notifications@github.com>
wrote:

> Ok good, I'll return with an updated suggestion. Next time I make a pull
> request, I'm not in a hurry to have it merged, so please take your time to
> test and provide feedback :)
>
> I understand that there are risks of breaking functionality such as the
> examples you have already found and some of you guys are able to test on a
> wider range of units than me.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/libretro/RetroArch/commit/f374af9dbc6392419b1cab39807be640ec984f06#commitcomment-15404002>
> .
>


новую БД пили :) там 3 миграции в директории
А и это... пость без пички пока, не рабоатет еще, завтра победить плнирую
http://sqlalchemy-imageattach.readthedocs.org/en/0.8.0/api/entity.html


Do we really need this as constructor parameters? It already has so many parameters. Can't we instead just make this a plain JournalFile field that can be set from the caller, after allocating the JournalFile(), i.e. after journal_file_open() returns?


It currently runs outside of trans due to assoc type projections, but this will be going away. I'm happy to refactor in the way you suggest.


I would write this as ```-0x80000```.
I think all velocities should be represented in hex, this is most likely how the original source did.


Literally checks if they're the same object.


Oh yes.


There's no `return` in this `except` branch - is continuing on after this point the intended behavior? Why is failing the overall `run` function not the right thing to do?


@nikomatsakis: Curious to get your feedback on these FIXMEs.


:p nothing clever going on here!


Noo, typos and i watched the wrong capacity value :(


I'd really like to keep the code of this function in journal-file.c... That way you can call it from journal_file_post_change() if the callback is not set.


I think this should be done in a separate migration as by changing an existing one you break the schemas of already existing databases which have the edited step/migration already applied (db-migrate will not be able to recognise that migration is needed) - or have I missed something?


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/22688/testReport/) for this commit**


Да похоже придётся новую.
Да, пикчу тоже заметил. Больше напрягла проблема с non-ascii символами в сообщениях, из-за которых отображение списка тредов ломается (помогает удаление записи в thread, для которой нет соответствующей в message)


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/22689/testReport/) for this commit**


Commit Third


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/22690/testReport/) for this commit**


Yay!


:+1: Wow, nice. Looking forward to how that feels to use in-game. Compile time! :smile:


Looks good otherwise. But I really don't like adding yet more arguments to the journal file constructor calls. And I'd like the callback to be something optional, that is not set by default in which case a default implementation would be called. In essence, the current internal journal file API would be fully retained, but if the callback ptr is set, then the post change code can be be replaced by something else.


Just check out my chef monitor cookbook fork.


Вообще я с третьим питоном подотвык от non-ascii-проблем :)


TeamCity pull requests :: netty [Build 1019](https://garage.netty.io/teamcity/viewLog.html?buildId=4702&buildTypeId=pulls_netty&guest=1) is now running


rebased here https://github.com/phenotips/phenotips/commit/670aee17c17f00aad425ee0a684580a09d224282


@maxbridges Looks good. Just a couple things to fix:

1) In the "Environment properties for build scripts" section, I think the second sentence should say "The properties," not "The variables."

2) In the following line, add "property" after "This:"

This is required for deployment and can be specified in the script itself, the deploy job configuration interface, or the project's `manifest.yml` file.


Ah undskyld, jeg forvirrer den med graph_timeline!  Jeg beklager.


Because protobuf is not *required* for the gRPC Python runtime, it seems like a bad thing if something as integral as `build_py` dies on it.


Without a ```fail()``` on the ```participants.delete()``` promise the test will only timeout in case of an error -> would be nice to just add ```.fail(fail)``` so whenever the promise comes back with an error we call jasmine's fail function.


Please revert this commit and come back with it when it's tested - installation-overview does not contain the possibility to save an autoyast profile in every case... Stagings for example do not have this option (and now are all nicely red)


Is updating SDWebImage part of this bug?


Would ```HTTP DELETE``` not be more suited for this (instead of a POST)?


111411352_ATDeprecateFields (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1505 of 1505 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.66%25-green.svg)


@scottoasis  thanks for suggestion, rebase complete and commit some new change.


I don't think we need it there. the $path there can only be the contents inside a `url()` statement (which is not `data:`) in CSS, so it can't be mistaken for content there.

But to be on the safe side, maybe I might as well check for it...


Und wann das wohl erscheint? :P


OK, `early_start()` looks sound.


Array#filter!


The .meta file is needed to avoid duplicating the .so file when importing a new version of the file.


Add bio for mlmallo


Does this commit is available on pypi?


Done: https://github.com/matthiasmullie/minify/commit/f69a620195fec215984fe51f6a9f17fb0f5784b5


@jkasten2 - That's a great idea! I'll work on getting it out there soon.


I'm trying to reconcile all of this mutation. Is it strictly needed? Can we observe in an immutable way when the store is updated? No push or setting items at indexes?


Maybe add UI or UX tags?


It's a good idea.  I thought about it, but I'm not sure how to implement it.  My ideas for it seem terribly inefficient.  I thought about reading through the entire fasta once, make a list of N number of unique barcodes, then loop over the fasta N number of times to parse each individually. But that could take 4x as long for 3 barcodes... How would you approach it?

The current IsoSeq sample prep protocol, you are limited to multiplexing 6 samples (barcodes 0-5). So I kept it simple for now.


thanks for this! I was looking for this function the other day and couldn't find it :smile:


Looks good.


all of these methods return undefined, which is a "smell". Should they return the observable bookmarks$, or ...?


Wow, this is a powerful library.  Thanks for the suggestion!


Add a couple of spaces to align `=` as same as previous lines.


Migration file looks good.


Update CSS


Ок, пересоздание базы решило проблему


first vervion


I confirm that the additions to the LOS file done here are GWT-compatible (no need to add any `@GwtIncompatible` annotation)


It could - but it felt weird setting the data source in the init. Really this goes into the refactor I was talking about - one of the issues is that we are "assuming" all location based lists are coupled to the users current location. That is about to be untrue when we remove the location section singleton (we will have "old" locations in the feed). So this really needs to be inited with a CLLocation - which requires us to refactor all the datasources, section controller, and the view model.

So kinda like my other comment - this makes me not want to do this now - and handle this when we do the other location work that is upcoming.


#396 that should do it.


You are not able to use those spells if require the specialization.


Didn't test... but looks great!  Appreciate the pull request!


Do you even test on standard gentoo configurations?  https://bugs.gentoo.org/show_bug.cgi?id=571680


(as people talk during review in docker/kubernetes/openshift tickets) LGTM! :)


I would expect those tags to correlate to content like @gusreiber's posts on Jenkins UI/UX experimentation, IMHO this doesn't fit in that bucket.


> Then its a bad idea to provide function overloading, the problem is Javascript doesn't support function overloading in its truest sense.

It is a standard practice in nodejs to not provide optional arguments
https://nodejs.org/api/fs.html#fs_fs_access_path_mode_callback
here `mode` is optional

Or take different types for an argument:
https://nodejs.org/api/fs.html#fs_fs_appendfile_file_data_options_callback
here `data` can be string or buffer.

Intention of this kind of `function-overloading` is to make the APIs more easy to use. Users are infact used to this pattern in JS.


true :) corrected in next commits


dont commit cards in future, no point lol


This make the synchronization after each batch, is that right? If so, I think it is way too frequent. In the LSTM example, we do this after 10 mini-batch. Ideally, it should be a parameter of the extension.

Is after_batch and after_epoch called after the last batch of an epoch? I suppose not, but would like a confirmation.


No strong opinion


dont commit changes to data.json it just generates on load anyway


@maxbridges I'm wondering if it's necessary to say "...click RUN to run a stage or CONFIGURE to configure a stage." Would it be enough to say something like this instead?

"You can also run, cancel, or configure a stage from the Stage History page. If you need to cancel a job while it is running, click the run number and then click CANCEL."


see above


thats what mysql is for eventually


A good practice is to start each sentence from new line


`&&` has precedence over `||`, so with the implicit pair of parentheses added it looks like this: `v:version > 704 || (v:version == 704 && has('patch42'))`.

(And `v:version >= 704 && has('patch42')` wouldn't work with `7.5.20` for example.)


@bgerstle seem like separate methods… one is for a specific controller for an item at an index - one is for showing more for the entire section. Unless I am missing something?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11310](https://teamcity.mesosphere.io/viewLog.html?buildId=103516&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:03:42


Should be in darbycomputerclub folder


If I got this right, `getvalue()` is present on a `StringIO` instance and you're printing out on stderr its (buffered, saved) stdout content.

Maybe I'm a bit slow to grasp this, but the function name and the docstring don't give me enough hints on why you send stdout content to stderr right before you revert stdout and stderr themselves.


This looks OK to me. Very happy you were able to navigate the schemagenerator / adapter easily.


It certainly makes more sense to use an unsigned here, but iirc, doesn't printf() expect an "int" here anyway? the o would have been cast to "(int) o" when passed as arg to log_debug, no? iirc gcc even complains about that...


What should?


otherwise looks great.


My rationale for opening the files after each write was so the program won't generate or open more files to write to than necessary.  E.g. I only have 3 barcodes in my file, so only 3 files are ever generated and written to.  But now that you brought it up, it does seem pretty inefficient opening and closing those three files thousands of times.  I think, if I could figure out a way to generalize to N barcodes efficiently, I think the code would lend itself better to only open N number of files, write, then close them all.


Nevermind. Missed a copy line.


not just arg5 and arg6.
arg3 arg4 arg5 can mean different things too depending on the context.
arg1 and arg2 are the only arguments whose meaning will not change.

I could name arg1 as bucketName and arg2 as objectName, I just named it arg1 and arg2 so that it looks consistent with the rest of the argument names.


From html-loader:

"You can specify which tag-attribute combination should be processed by this loader via the query parameter attrs. Pass an array or a space-separated list of <tag>:<attribute> combinations. (Default: attrs=img:src)"

Maybe this could solve your "the meta image problem":
```js
{
  test: /\.html$/,
  loader: 'html',
  query: {
    attrs: ['link:href'] // <-- You have to play around with this value
  }
}
```


This commit causes many warnings about not finding `name2`, and using the default.
```
 Warning: configHandler.py - IdleConf.GetOption -
 problem retrieving configuration option 'name2'
 from section 'Theme'.
 returning default value: ''

 Warning: configHandler.py - IdleConf.GetOption -
 problem retrieving configuration option 'name2'
 from section 'Theme'.
 returning default value: ''

 Warning: configHandler.py - IdleConf.GetOption -
 problem retrieving configuration option 'name2'
 from section 'Theme'.
 returning default value: ''

 Warning: configHandler.py - IdleConf.GetOption -
 problem retrieving configuration option 'name2'
 from section 'Theme'.
 returning default value: ''
Time to build GUI: 0.142096 seconds

 Warning: configHandler.py - IdleConf.GetOption -
 problem retrieving configuration option 'name2'
 from section 'Theme'.
 returning default value: ''
```
Is there a way to turn off these warnings?

This was first reported to me by @logan-nc


@bgerstle whoops - forgot to add that file - in there now


Yep something somewhere is missing, it fails to locate already existing quest children group and creates a new one.


`this._handleErrors()` doesn't need `this` so might as well just be a function


Haska

Er schlenderte gemächlich, versuchte, einen unscheinbaren Eindruck zu hinterlassen. Ein Handwerksgeselle, der mit seinen freien Tag nichts anzufangen hatte und sich die Stadt ansah. In Gedanken ging er seine Ressourcen durch. Er trug die robuste, in schlichten Brauntönen gehaltene Kleidung eines Handwerkers. Die blonden Locken hatte er schon vor Wochen abgeschnitten und mit einem Färbemittel zu einem unauffälligen Braun verwandelt. In seinem rechten Stiefel versteckte er ein Messer, in seinem Beutel einen dunklen Mantel und drei Wurfsterne. Mehr besaß er nicht mehr. Sein letztes Geld hatte er Kira gegeben. Ein Fehler, er hätte es gut gebrauchen können, aber andererseits konnte er Kira und deren Tochter auch nicht völlig mittellos zurück lassen. Haska überlegte, ob er nach ihnen sehen sollte. Niemand würde ihn mit den beiden in Verbindung bringen. Er schlug also den Weg in die Handwerksviertel ein.
Die Straßen im Viertel bestanden aus fest gestampfter Erde, mit Kieselsteinen bestückt. Nicht so praktisch wie die gepflasterten Wege in den reicheren Teilen der Stadt, aber dennoch bei einem Unwetter nicht so schlammig wie in dem Viertel, in dem Imur und Lavay gelebt hatten.
Haska erreichte die Schusterei, warf einen Blick auf den beschäftigten Schuster und schlüpfte an der schmalen Treppe, die sich am Rand des Gebäudes befand, hoch zum ersten Stock. Haska klopfte und lauschte den Schritten auf der anderen Seite der Tür.
Kira selbst öffnete. Sie trug ein Kleid aus ausgewaschenem, blauen Stoff, eine Schürze und das Haar hatte sie unter einer Haube versteckt. Eine mutige schwarze Locke lugte unter der Haube hervor. Sie musterte ihn aus blauen Augen und schüttelte den Kopf. „Der Schuster ist in der Werkstadt. Und wenn er dort nicht ist, auf dem Markt. Dann müsst Ihr warten, bis er wieder kommt. Aber bitte unten. Ich habe zu tun.“
Kira war schon dabei die Türe wieder zu schließen, da fügte sie noch hinzu: „Aber ich denke, die Wartezeit könnt Ihr Euch sparen. Der Schuster sucht keine neuen Gesellen.“
Haska lauschte ihrer Stimme fasziniert. Der sanfte, aber bestimmte Ton, die wohl gewählten Worte, das passte einfach nicht zu der Frau eines Handwerkers. Sie war von hoher Geburt und das konnte jeder gleich sehen, wenn er die Augen aufmachte.
„Kira“, sagte er leise und legte eine Hand auf die Türe, um sie offen zu halten.
Sie sah zu ihm auf. Haska hätte sie stundenlang nur anschauen können. Er lächelte unwillkürlich. Sie war vielleicht in den Augen eines subjektiven Betrachters ganz hübsch, Haska dagegen glaubte nicht daran, dass er je eine schönere Frau sehen würde. So sehr manche Schönheiten auch angepriesen wurden, Haska störte immer etwas an ihnen. Sie waren einfach nicht Kira.
Kira, die jetzt genauer hinsah und ihn erkannte, zog ihn in das Zimmer und verschloss eilig die Türe.
„Was machst du hier?“, fragte sie atemlos: „Du sagtest doch, du müsstest weg!“
„Ich war auch weg. Aber ich hab noch was zu erledigen.“
„Du kannst keine Ruhe geben, oder?“, fragte sie und schüttelte heftig den Kopf: „Du kannst nicht loslassen.“
Haskas Löwenaugen funkelten. „Nein. Ich will wissen, warum er sterben musste! Verstehst du nicht? Ich hätte an seiner Stelle sein können! Ursprünglich sollte ich zuerst rein... aber weil die Brüder abgesprungen sind, haben wir es kurzfristig geändert.“
Kira senkte den Blick. „Ach das hat dich zurück getrieben.“
Haska legte den Kopf schief. „Ich habe dich auch vermisst...“
Ihre Niedergeschlagenheit verflog. Stattdessen warf sie ihm einen spitzen Blick zu. „Du weißt genau, dass ich dich nicht will!“
Er war ihre harten Worte gewohnt, trotzdem waren sie nicht besonders angenehm. Mit dem Versucht sich das nicht anmerken zu lassen, lehnte er sich gegen den massiven Holztisch. „Das hast du mir klar gemacht. Sag, was hätte ich damals anders machen müssen, damit du mir einen liebevollen Blick geschenkt hättest?“
Kira lachte spöttisch. „Du bist ein Träumer! Warum hätte ich das tun sollen? Du warst nicht mehr als ein kleiner Taschendieb.“
„Und du bist nun nicht mehr als die Frau eines Handwerkers“, bemerkte Haska nüchtern.
Kira starrte ihn böse an. „Wage es nicht, mich zu beleidigen!“
„Du hast recht. Verzeih, du bist nicht mehr als die Witwe eines Handwerkers, die nun für einen alten Schuster putzt und kocht, näht und stopft.“
Wenn es ihr Spaß machte, Haska weh zu tun, dann konnte er das auch. „Ich habe es dir versucht zu sagen, Kira.“
„Woher hättest du wissen sollen, dass man Vater so viele Schulden hat?“, brauste sie auf.
„Ich kenne viele Leute“, erwiderte Haska: „Und dieses Thema haben wir schon oft genug besprochen. Du hättest mich heiraten sollen, Kira. Ich dachte, ich hätte dir deutlich genug gemacht, wie viel du mir bedeutest. Aber du warst zu stolz. Und heute bist du immer noch zu stolz.“
„Immerhin hast du die Bemühungen um mich aufgegeben.“
„Immerhin bin ich hier.“
„Nicht wegen mir“, sagte Kira und schüttelte den Kopf: „Wegen deinem Freund. Und wegen deiner Rache.“
„Du willst mich doch nicht.“
„Ich will keinen Dieb und Mörder.“
Haska seufzte. „Damals war ich weder das eine, noch das andere, Kira. Willst du damit sagen, dass ich dir vorher nicht genug war und heute zu falsch?“
Kira hob nur das Kinn und schwieg.
„Auch Soldaten morden, Kira. Und sie plündern Dörfer, rauben den Toten auf dem Schlachtfeld das letzte Hemd. Aber ja, sie reiten auch in Paraden und bekommen Medaillen. Ist es das, was du willst? Anerkennung? Bewunderung?“
„Ich will das zurück, was ich verloren habe.“
„Du hast nie etwas gehabt. Dein Vater konnte die Eintreiber nur lange genug beschwichtigen. Ich wünsche der Dame noch einen schönen Tag.“
Haska verließ seinen Platz am Tisch und verließ die Stube. Als er die Treppe hinunter trat, stand Kira in der Tür.
„Haska“, rief sie halblaut und als er sich ihr zu wand, fügte sie hinzu: „Schön, dass du da warst.“
Er nickte nur und machte sich auf den Weg in die schlechteren Viertel der Stadt. Es war immer das Selbe. Er wusste nicht mal, ob man das was sie beide Verband als Liebe bezeichnen konnte. Sie stritten, verfluchten einander mit Worten, und doch zog es sie immer wieder zueinander. Jedes Mal nahm er sich vor, dass er sie hinter sich lassen sollte. Warum er es nicht tat, konnte er selbst nicht sagen.

Er wartete bis die Nacht einbrach und zog sich seinen Mantel über. Er wollte möglichst vermeiden, dass seine neue Erscheinung im Dunklen Viertel, wie es so hübsch von den Einwohnern genannt wurde, gesichtet wurde. Außerdem hatte der Mantel in diesem Viertel die angenehme Folge, dass keiner es wagen würde, ihn anzusprechen. Diejenigen die nicht selbst in kriminelle Geschäftige verwickelt waren, hätten zu viel Angst, und die anderen trugen selbst meist welche.
Er betrat die Taverne „Silberei“ und suchte sich einen guten Beobachtungsposten in der südlichen Ecke. Haska betrachtete die Kunden, wie sie tranken, spielten und verhandelten. Bei den meisten Gesprächen ging es um ernste Dinge, viele andere, die grölenden, lauten, stammten von Betrunkenen. Er hatte gerne, wie viele andere, das Silberei benutzt um mit Kumpanen zu planen. Die lautstarken Saufgelage verhinderten gut, dass das eigene Gespräch belauscht werden konnte. Auch jetzt war es unmöglich, etwas anderes als die Beleidigungen, Flüche oder Rufe nach der Schankmaid zu hören. Viele der Anwesenden kannte Haska. Und durch deren flüchtige Blicke bemerkte er, dass er auch schon Aufmerksamkeit erregt hatte. Aber damit hatte er gerechnet. Jemand der still in einer solchen Umgebung stand, wurde von wissenden Augen schnell entdeckt. Aber die gefährlichen Männer fanden kein Interesse an ihm. Das war auch eines dieser Dinge, die Haska mochte. Jeder kümmerte sich um seinen eigenen Dreck. Niemand mischte sich ein.
Lange wartete Haska nicht, als die Brüder die Taverne betraten. Sie betranken sich und bald schon waren ihre Stimmen die lautesten in der Taverne. Unter der Kapuze verzog Haska das Gesicht zu einer verächtlichen Grimasse. Sie hätten sich nie auf die beiden Einlassen sollen.
„Gute Diebe erkennt man daran, dass man sie nicht hört“, zitierte er in Gedanken.
Die Verachtung die er gegenüber diesen Beiden empfand, wuchs mit jeder Minute, die er dort stand und den Brüdern zusah.
Jemand neben ihm räusperte sich plötzlich. Haska ließ die Brüder nicht aus den Augen.
„Suchst etwas?“, brummte der Mann.
Haska kannte ihn, Ergo, ein Verkäufer auf dem Schwarzmarkt des Viertels. Mit ihm selbst hatte Haska weniger zu tun gehabt. Seine gestohlenen Dinge hatte er eher an einen Mittelsmann verschachert, als direkt zu den Verkäufern zu gehen. Er wollte auf dem Schwarzmarkt nicht gesehen werden. Haska schüttelte den Kopf und hoffte, dass Ergo wieder abziehen würde. Doch der Verkäufer blieb hartnäckig.
„Ich kann dir alles besorgen!“
Jetzt sah Haska den Typen doch mal an. Einen Moment war er der Versuchung nahe. Er könnte das ein oder andere wirklich gebrauchen.
„Verschwinde!“, entgegnete er und richtete seine Aufmerksamkeit wieder auf die Brüder. Haska durfte keine Spuren in der Stadt hinterlassen. Es war einfach zu gefährlich.
Ergo sah wohl ein, dass er seine Waren Haskas Interesse nicht wecken konnten und zog leise brummend ab um auf weitere, vielleicht interessierter Männer Ausschau zu halten. Haska blickte ihm kurz hinterher, als sein Blick anschließend zurück zum Tisch wanderte, hatten sich die Brüder bereits erhoben. Er verließ das Gebäude kurz nach ihnen und hielt sich dicht an den Häuserwänden, möglichst im Schatten.


I am not sure if this is uploaded or not


global


Hello dRiduan  ,

I am vishal from india your splash screen is good but where is full code yaar


ditto


I'd prefer not to. IMO, it's a separate concern whether the party is created and whether the id gets added to the user.


Why do you have a lot of one letter parameters? I tried to guess how the letter comes from the meaning of parameter and get nothing. :) I know about minified versions, but mb we should use them in release?


This conflict with https://github.com/mila-udem/platoon/pull/21 that is a better fix. @mgermain is testing that PR. I think you should rebase this PR after gh-21 is merged and remove this commit.


Same answer as https://github.com/HabitRPG/habitrpg/commit/36cd9e94306e35339c06be07e433e24a77dabf5d#commitcomment-15404604


@TahaHachana I released a new version of FsLab which should work with the new Plotly API, but I have not done any testing. This looked like an obvious change, so I hope it does the trick :)


This pull request fixes the search problem in issue #31 and #32.


Ah, I see. Then yeah I guess the logic would be simplified then by moving it into trans.


The idea of a do-nothing backstore sounds fine so we don't need to check for nil everywhere, but it sounds awkward to surface error messages that talk about such details of the code implementation. I'd suggest something like:

    "cannot store assertions without a proper assertion backstore implementation"

It might also be wise to not surface this in the public API if we don't plan to keep it around for too long, assuming we get a memory-based backstore soonish. For that, we might just test for the nil case and set the `nullBackstore` ourselves while opening the database. `NewNullBackstore` might then go away, and the name becomes less relevant as nobody will see it, even when using it.


Skip to content
This repository

    Pull requests
    Issues
    Gist

    @TheOnlyOneSilverLight

1
0

    0

TheOnlyOneSilverLight/text
Code
Issues 0
Pull requests 0
Wiki
Pulse
Graphs
Settings

Initial commit

    master

0 parents commit cbfdfecdd81711b28275d236450c9ff5ffa7b9d3 @TheOnlyOneSilverLight TheOnlyOneSilverLight committed 36 minutes ago
Showing
with 1 addition and 0 deletions.
1 README.md
@@ -0,0 +1 @@
+# text
@TheOnlyOneSilverLight
Owner
TheOnlyOneSilverLight added a note a minute ago

Haska

Er schlenderte gemächlich, versuchte, einen unscheinbaren Eindruck zu hinterlassen. Ein Handwerksgeselle, der mit seinen freien Tag nichts anzufangen hatte und sich die Stadt ansah. In Gedanken ging er seine Ressourcen durch. Er trug die robuste, in schlichten Brauntönen gehaltene Kleidung eines Handwerkers. Die blonden Locken hatte er schon vor Wochen abgeschnitten und mit einem Färbemittel zu einem unauffälligen Braun verwandelt. In seinem rechten Stiefel versteckte er ein Messer, in seinem Beutel einen dunklen Mantel und drei Wurfsterne. Mehr besaß er nicht mehr. Sein letztes Geld hatte er Kira gegeben. Ein Fehler, er hätte es gut gebrauchen können, aber andererseits konnte er Kira und deren Tochter auch nicht völlig mittellos zurück lassen. Haska überlegte, ob er nach ihnen sehen sollte. Niemand würde ihn mit den beiden in Verbindung bringen. Er schlug also den Weg in die Handwerksviertel ein.
Die Straßen im Viertel bestanden aus fest gestampfter Erde, mit Kieselsteinen bestückt. Nicht so praktisch wie die gepflasterten Wege in den reicheren Teilen der Stadt, aber dennoch bei einem Unwetter nicht so schlammig wie in dem Viertel, in dem Imur und Lavay gelebt hatten.
Haska erreichte die Schusterei, warf einen Blick auf den beschäftigten Schuster und schlüpfte an der schmalen Treppe, die sich am Rand des Gebäudes befand, hoch zum ersten Stock. Haska klopfte und lauschte den Schritten auf der anderen Seite der Tür.
Kira selbst öffnete. Sie trug ein Kleid aus ausgewaschenem, blauen Stoff, eine Schürze und das Haar hatte sie unter einer Haube versteckt. Eine mutige schwarze Locke lugte unter der Haube hervor. Sie musterte ihn aus blauen Augen und schüttelte den Kopf. „Der Schuster ist in der Werkstadt. Und wenn er dort nicht ist, auf dem Markt. Dann müsst Ihr warten, bis er wieder kommt. Aber bitte unten. Ich habe zu tun.“
Kira war schon dabei die Türe wieder zu schließen, da fügte sie noch hinzu: „Aber ich denke, die Wartezeit könnt Ihr Euch sparen. Der Schuster sucht keine neuen Gesellen.“
Haska lauschte ihrer Stimme fasziniert. Der sanfte, aber bestimmte Ton, die wohl gewählten Worte, das passte einfach nicht zu der Frau eines Handwerkers. Sie war von hoher Geburt und das konnte jeder gleich sehen, wenn er die Augen aufmachte.
„Kira“, sagte er leise und legte eine Hand auf die Türe, um sie offen zu halten.
Sie sah zu ihm auf. Haska hätte sie stundenlang nur anschauen können. Er lächelte unwillkürlich. Sie war vielleicht in den Augen eines subjektiven Betrachters ganz hübsch, Haska dagegen glaubte nicht daran, dass er je eine schönere Frau sehen würde. So sehr manche Schönheiten auch angepriesen wurden, Haska störte immer etwas an ihnen. Sie waren einfach nicht Kira.
Kira, die jetzt genauer hinsah und ihn erkannte, zog ihn in das Zimmer und verschloss eilig die Türe.
„Was machst du hier?“, fragte sie atemlos: „Du sagtest doch, du müsstest weg!“
„Ich war auch weg. Aber ich hab noch was zu erledigen.“
„Du kannst keine Ruhe geben, oder?“, fragte sie und schüttelte heftig den Kopf: „Du kannst nicht loslassen.“
Haskas Löwenaugen funkelten. „Nein. Ich will wissen, warum er sterben musste! Verstehst du nicht? Ich hätte an seiner Stelle sein können! Ursprünglich sollte ich zuerst rein... aber weil die Brüder abgesprungen sind, haben wir es kurzfristig geändert.“
Kira senkte den Blick. „Ach das hat dich zurück getrieben.“
Haska legte den Kopf schief. „Ich habe dich auch vermisst...“
Ihre Niedergeschlagenheit verflog. Stattdessen warf sie ihm einen spitzen Blick zu. „Du weißt genau, dass ich dich nicht will!“
Er war ihre harten Worte gewohnt, trotzdem waren sie nicht besonders angenehm. Mit dem Versucht sich das nicht anmerken zu lassen, lehnte er sich gegen den massiven Holztisch. „Das hast du mir klar gemacht. Sag, was hätte ich damals anders machen müssen, damit du mir einen liebevollen Blick geschenkt hättest?“
Kira lachte spöttisch. „Du bist ein Träumer! Warum hätte ich das tun sollen? Du warst nicht mehr als ein kleiner Taschendieb.“
„Und du bist nun nicht mehr als die Frau eines Handwerkers“, bemerkte Haska nüchtern.
Kira starrte ihn böse an. „Wage es nicht, mich zu beleidigen!“
„Du hast recht. Verzeih, du bist nicht mehr als die Witwe eines Handwerkers, die nun für einen alten Schuster putzt und kocht, näht und stopft.“
Wenn es ihr Spaß machte, Haska weh zu tun, dann konnte er das auch. „Ich habe es dir versucht zu sagen, Kira.“
„Woher hättest du wissen sollen, dass man Vater so viele Schulden hat?“, brauste sie auf.
„Ich kenne viele Leute“, erwiderte Haska: „Und dieses Thema haben wir schon oft genug besprochen. Du hättest mich heiraten sollen, Kira. Ich dachte, ich hätte dir deutlich genug gemacht, wie viel du mir bedeutest. Aber du warst zu stolz. Und heute bist du immer noch zu stolz.“
„Immerhin hast du die Bemühungen um mich aufgegeben.“
„Immerhin bin ich hier.“
„Nicht wegen mir“, sagte Kira und schüttelte den Kopf: „Wegen deinem Freund. Und wegen deiner Rache.“
„Du willst mich doch nicht.“
„Ich will keinen Dieb und Mörder.“
Haska seufzte. „Damals war ich weder das eine, noch das andere, Kira. Willst du damit sagen, dass ich dir vorher nicht genug war und heute zu falsch?“
Kira hob nur das Kinn und schwieg.
„Auch Soldaten morden, Kira. Und sie plündern Dörfer, rauben den Toten auf dem Schlachtfeld das letzte Hemd. Aber ja, sie reiten auch in Paraden und bekommen Medaillen. Ist es das, was du willst? Anerkennung? Bewunderung?“
„Ich will das zurück, was ich verloren habe.“
„Du hast nie etwas gehabt. Dein Vater konnte die Eintreiber nur lange genug beschwichtigen. Ich wünsche der Dame noch einen schönen Tag.“
Haska verließ seinen Platz am Tisch und verließ die Stube. Als er die Treppe hinunter trat, stand Kira in der Tür.
„Haska“, rief sie halblaut und als er sich ihr zu wand, fügte sie hinzu: „Schön, dass du da warst.“
Er nickte nur und machte sich auf den Weg in die schlechteren Viertel der Stadt. Es war immer das Selbe. Er wusste nicht mal, ob man das was sie beide Verband als Liebe bezeichnen konnte. Sie stritten, verfluchten einander mit Worten, und doch zog es sie immer wieder zueinander. Jedes Mal nahm er sich vor, dass er sie hinter sich lassen sollte. Warum er es nicht tat, konnte er selbst nicht sagen.

Er wartete bis die Nacht einbrach und zog sich seinen Mantel über. Er wollte möglichst vermeiden, dass seine neue Erscheinung im Dunklen Viertel, wie es so hübsch von den Einwohnern genannt wurde, gesichtet wurde. Außerdem hatte der Mantel in diesem Viertel die angenehme Folge, dass keiner es wagen würde, ihn anzusprechen. Diejenigen die nicht selbst in kriminelle Geschäftige verwickelt waren, hätten zu viel Angst, und die anderen trugen selbst meist welche.
Er betrat die Taverne „Silberei“ und suchte sich einen guten Beobachtungsposten in der südlichen Ecke. Haska betrachtete die Kunden, wie sie tranken, spielten und verhandelten. Bei den meisten Gesprächen ging es um ernste Dinge, viele andere, die grölenden, lauten, stammten von Betrunkenen. Er hatte gerne, wie viele andere, das Silberei benutzt um mit Kumpanen zu planen. Die lautstarken Saufgelage verhinderten gut, dass das eigene Gespräch belauscht werden konnte. Auch jetzt war es unmöglich, etwas anderes als die Beleidigungen, Flüche oder Rufe nach der Schankmaid zu hören. Viele der Anwesenden kannte Haska. Und durch deren flüchtige Blicke bemerkte er, dass er auch schon Aufmerksamkeit erregt hatte. Aber damit hatte er gerechnet. Jemand der still in einer solchen Umgebung stand, wurde von wissenden Augen schnell entdeckt. Aber die gefährlichen Männer fanden kein Interesse an ihm. Das war auch eines dieser Dinge, die Haska mochte. Jeder kümmerte sich um seinen eigenen Dreck. Niemand mischte sich ein.
Lange wartete Haska nicht, als die Brüder die Taverne betraten. Sie betranken sich und bald schon waren ihre Stimmen die lautesten in der Taverne. Unter der Kapuze verzog Haska das Gesicht zu einer verächtlichen Grimasse. Sie hätten sich nie auf die beiden Einlassen sollen.
„Gute Diebe erkennt man daran, dass man sie nicht hört“, zitierte er in Gedanken.
Die Verachtung die er gegenüber diesen Beiden empfand, wuchs mit jeder Minute, die er dort stand und den Brüdern zusah.
Jemand neben ihm räusperte sich plötzlich. Haska ließ die Brüder nicht aus den Augen.
„Suchst etwas?“, brummte der Mann.
Haska kannte ihn, Ergo, ein Verkäufer auf dem Schwarzmarkt des Viertels. Mit ihm selbst hatte Haska weniger zu tun gehabt. Seine gestohlenen Dinge hatte er eher an einen Mittelsmann verschachert, als direkt zu den Verkäufern zu gehen. Er wollte auf dem Schwarzmarkt nicht gesehen werden. Haska schüttelte den Kopf und hoffte, dass Ergo wieder abziehen würde. Doch der Verkäufer blieb hartnäckig.
„Ich kann dir alles besorgen!“
Jetzt sah Haska den Typen doch mal an. Einen Moment war er der Versuchung nahe. Er könnte das ein oder andere wirklich gebrauchen.
„Verschwinde!“, entgegnete er und richtete seine Aufmerksamkeit wieder auf die Brüder. Haska durfte keine Spuren in der Stadt hinterlassen. Es war einfach zu gefährlich.
Ergo sah wohl ein, dass er seine Waren Haskas Interesse nicht wecken konnten und zog leise brummend ab um auf weitere, vielleicht interessierter Männer Ausschau zu halten. Haska blickte ihm kurz hinterher, als sein Blick anschließend zurück zum Tisch wanderte, hatten sich die Brüder bereits erhoben. Er verließ das Gebäude kurz nach ihnen und hielt sich dicht an den Häuserwänden, möglichst im Schatten.


Thanks, @lwhinson!


Needs - "Name:"


Needs - "Location:"


Why not?


yeah it was actually very straight forward. Only issue I think I hit was actually in the db.transaction and having to join the array with ";", vs just sending in the array (I might make a pr to fix that)

Okay I will kick a pr over


Git Demo

This is our test repository to test forking a repository and sending a pull request back to make changes to the original

 +

 -
 +
I am a student at Coding Dojo and my cohort is January 18th 2016 Seattle

 +

 +
 +
Damian Odoemena (Jr)

 +

 +
damucci

 +
Still working on a favorite, might be the mean stack, who knows!


I'm using a stock Google webfont so I can't really mess about with the serifs.


This is the same as the insets set in PostCardActionBar.m; not sure if there is a better way to do this (that doesn't require declaring it in two places).


„Kira“, sagte er leise und legte eine Hand auf die Türe, um sie offen zu halten.
Sie sah zu ihm auf. Haska hätte sie stundenlang nur anschauen können. Er lächelte unwillkürlich. Sie war vielleicht in den Augen eines subjektiven Betrachters ganz hübsch, Haska dagegen glaubte nicht daran, dass er je eine schönere Frau sehen würde. So sehr manche Schönheiten auch angepriesen wurden, Haska störte immer etwas an ihnen. Sie waren einfach nicht Kira.
Kira, die jetzt genauer hinsah und ihn erkannte, zog ihn in das Zimmer und verschloss eilig die Türe.
„Was machst du hier?“, fragte sie atemlos: „Du sagtest doch, du müsstest weg!“
„Ich war auch weg. Aber ich hab noch was zu erledigen.“
„Du kannst keine Ruhe geben, oder?“, fragte sie und schüttelte heftig den Kopf: „Du kannst nicht loslassen.“
Haskas Löwenaugen funkelten. „Nein. Ich will wissen, warum er sterben musste! Verstehst du nicht? Ich hätte an seiner Stelle sein können! Ursprünglich sollte ich zuerst rein... aber weil die Brüder abgesprungen sind, haben wir es kurzfristig geändert.“
Kira senkte den Blick. „Ach das hat dich zurück getrieben.“
Haska legte den Kopf schief. „Ich habe dich auch vermisst...“
Ihre Niedergeschlagenheit verflog. Stattdessen warf sie ihm einen spitzen Blick zu. „Du weißt genau, dass ich dich nicht will!“
Er war ihre harten Worte gewohnt, trotzdem waren sie nicht besonders angenehm. Mit dem Versucht sich das nicht anmerken zu lassen, lehnte er sich gegen den massiven Holztisch. „Das hast du mir klar gemacht. Sag, was hätte ich damals anders machen müssen, damit du mir einen liebevollen Blick geschenkt hättest?“
Kira lachte spöttisch. „Du bist ein Träumer! Warum hätte ich das tun sollen? Du warst nicht mehr als ein kleiner Taschendieb.“
„Und du bist nun nicht mehr als die Frau eines Handwerkers“, bemerkte Haska nüchtern.
Kira starrte ihn böse an. „Wage es nicht, mich zu beleidigen!“
„Du hast recht. Verzeih, du bist nicht mehr als die Witwe eines Handwerkers, die nun für einen alten Schuster putzt und kocht, näht und stopft.“
Wenn es ihr Spaß machte, Haska weh zu tun, dann konnte er das auch. „Ich habe es dir versucht zu sagen, Kira.“
„Woher hättest du wissen sollen, dass man Vater so viele Schulden hat?“, brauste sie auf.
„Ich kenne viele Leute“, erwiderte Haska: „Und dieses Thema haben wir schon oft genug besprochen. Du hättest mich heiraten sollen, Kira. Ich dachte, ich hätte dir deutlich genug gemacht, wie viel du mir bedeutest. Aber du warst zu stolz. Und heute bist du immer noch zu stolz.“
„Immerhin hast du die Bemühungen um mich aufgegeben.“
„Immerhin bin ich hier.“
„Nicht wegen mir“, sagte Kira und schüttelte den Kopf: „Wegen deinem Freund. Und wegen deiner Rache.“
„Du willst mich doch nicht.“
„Ich will keinen Dieb und Mörder.“
Haska seufzte. „Damals war ich weder das eine, noch das andere, Kira. Willst du damit sagen, dass ich dir vorher nicht genug war und heute zu falsch?“
Kira hob nur das Kinn und schwieg.
„Auch Soldaten morden, Kira. Und sie plündern Dörfer, rauben den Toten auf dem Schlachtfeld das letzte Hemd. Aber ja, sie reiten auch in Paraden und bekommen Medaillen. Ist es das, was du willst? Anerkennung? Bewunderung?“
„Ich will das zurück, was ich verloren habe.“
„Du hast nie etwas gehabt. Dein Vater konnte die Eintreiber nur lange genug beschwichtigen. Ich wünsche der Dame noch einen schönen Tag.“
Haska verließ seinen Platz am Tisch und verließ die Stube. Als er die Treppe hinunter trat, stand Kira in der Tür.
„Haska“, rief sie halblaut und als er sich ihr zu wand, fügte sie hinzu: „Schön, dass du da warst.“


Right, I know, but I didn't close it–it closed itself as part of the normal, successful process, and yet I saw the error, indicating some sort of double-close logic mistake. I'll look into it.


Oh, and the same change in the load script: https://github.com/fslaborg/FsLab/commit/934fc067abd9dc5960d13b862dacca6230f47fb8


New url location is https://coreos.com/os/docs/latest/cloud-config.html


Did you have a good weekend?


I see now I am missing this change.  I will report the problem to MacPorts.  Sorry for the noise.


What's your hobby?


@enzuru there's so much in the diff this is hard to compare.  there's a lot of code that is the same and should be common between the two.


Aren't units created by cloudinit put in /run by default?


i think that's orthogonal to whether the data source is in the initializer,
since you're talking specifically about how the data source itself is
created, not the VC—but i'm OK if this is addressed separately

On Tue, Jan 12, 2016 at 1:18 PM, Corey Floyd <notifications@github.com>
wrote:

> It could - but it felt weird setting the data source in the init. Really
> this goes into the refactor I was talking about - one of the issues is that
> we are "assuming" all location based lists are coupled to the users current
> location. That is about to be untrue when we remove the location section
> singleton (we will have "old" locations in the feed). So this really needs
> to be inited with a CLLocation - which requires us to refactor all the
> datasources, section controller, and the view model.
>
> So kinda like my other comment - this makes me not want to do this now -
> and handle this when we do the other location work that is upcoming.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wikimedia/wikipedia-ios/commit/541fbdf8ad821475568181f162bcfad88b4a70cc#commitcomment-15404420>
> .
>

--
EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle
IRC: bgerstle


请不要这样直接改动MakeFile会污染项目。回滚一下吧。
![image](https://cloud.githubusercontent.com/assets/6213976/12272901/be210d84-b99d-11e5-8fe7-5fdd1095ab8c.png)


@nehresma you may want to pull these changes when you start working on "Add Recipients to Email"


Pretty sure it actually does support arrays. But it assumes if your provide an array that you're giving it a query and parameters to escape within the query. We can add a bit of logic there so it supports what you're talking about.


Oh wait, I'm sorry!  The one I mentioned is for detail VC's _for an item in
the list_, not the "more like" footer. Never mind!

On Tue, Jan 12, 2016 at 1:21 PM, Corey Floyd <notifications@github.com>
wrote:

> @bgerstle <https://github.com/bgerstle> seem like separate methods… one
> is for a specific controller for an item at an index - one is for showing
> more for the entire section. Unless I am missing something?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wikimedia/wikipedia-ios/commit/5ad1e0a2f6813d95647dce61553bf6e8b0b13e51#commitcomment-15404498>
> .
>

--
EN Wikipedia user page: https://en.wikipedia.org/wiki/User:Brian.gerstle
IRC: bgerstle


Remove this empty line


Indeed, I've been hit by this lack of care not long ago; I wouldn't automate `brew cleanup`.


Great job. I am guessing that the bitmap caching will take longer once we get farther. Also what was the color thing when the loader was going on?


@lwhinson I think it's possible that someone might think they're running/configuring a selected job rather than the whole stage. Normally, I'd be against be so obvious, but I think the way the UI is laid out contributes to potential confusion here.


Now, with more science! Looks good.


Note: it greatly improves the rendering of Grandia3 FMV.


We have to be a bit careful here and not add too many words that are very rare and still potential misspellings of a more common word ("Kanon").


I'm suffering right now... Trying to run pg_upgrade after the old binary has been deleted. @sparksp, can you offer any insight as to what you did?

I've reinstalled 9.4 with `brew install homebrew/versions/postgresql94` and am now trying to migrate unsuccessfully...


oh right!  os.Stdout doesn't have a mutex on it.  golang log does.


Doh!. Fixed


ahh okay yeah thats right, I see that now


FYI @ljharb


I'll merge this in and re-evaluate.


By the way check the code for `TwbGroupRecord.AddElement`, it has some reference to google code issue, but I don't remember what was it. That code has explicitely checks for DIAL records.


111411352_ATDeprecateFields (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (2054 of 2054 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I love dogs & cats!


works! Thx!!


The .so file has been deleted - this meta file will be removed by unity
upon the next build as it references a file that does not exist in the
project.

On 12 January 2016 at 19:15, Clayton Wilkinson <notifications@github.com>
wrote:

> The .meta file is needed to avoid duplicating the .so file when importing
> a new version of the file.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/playgameservices/play-games-plugin-for-unity/commit/9e83e501fc8f1346a40404ed7d52b84c4879f7cd#commitcomment-15404326>
> .
>


Missing a closing parentheses here.


I noticed that there are some NPE's likely to happen with these changes. I made some specific line item comments to help point them out.

I would recommend re-expressing the code for this feature so that the TrafficRouter class changes as little as possible. When that's done it should allow for writing tests that would catch things like NPE's and so on.

The NPE problems stem from creating objects in TrafficRouter and passing them several calls deep into the enforce() method of RegionalGeo that is assuming it is getting parameters that are non-null. However there are some code paths that are indeed going to pass in null.

See if it is possible to have a method similar to enforce() that is responsible for creating the RegionalGeoResult object and returning it to the caller instead of accepting one as a parameter and modifying it.

Also see if it is possible to put the logic added to TrafficRouter into its own class and write tests for the new logic.

It is also very important to us to not introduce new code that causes PMD errors.
Some existing code does indeed have suppressed warnings, we may address it in the future.

Minor Items:
- Put blank lines between methods
- Do not use acronyms for variable names
- Do not add javadoc comments for private methods
- Use hamcrest matchers and assertions in tests (e.g. assertThat(foo, equalTo(bar))
- Please avoid introducing checked exceptions when possible
- Please don't use else clauses in conjunction with if clauses that return a value
- Please don't use Logger objects in tests, tests should ideally be silent unless they fail


Can you make this a pull request? Thanks for doing it!


Nice!


Minor
This setup method should be removed


kepgnar: You have a question about a recipe. I don't think making a comment on a commit is the best place to ask it.


Do not add logger objects to tests.
Tests need to produce zero output unless they fail


`env.MAV_MSG_DEFS` isn't defined at this point, it will be evaluated as an empty list in at the first configure (not sure about the others).

Anyway, I think this and the first check (`cfg.start_msg('Checking for mavlink submodule')`) could be just one check. In that case, we would just check if `modules/mavlink/message_definitions/v1.0/ardupilotmega.xml` is present. If not, we fail with the first message.

I'm suggesting that because, if `modules/mavlink/message_definitions/v1.0/ardupilotmega.xml` isn't present, then `modules/mavlink/` won't be either :-)


Use Hamcrest assertThat and hamcrest matchers for evaluating assertions.
They produce much better messages when there are test failures.


move this method out of the TrafficRouter class


You could remove what's below (the initial, default README content) and keep only the custom content that's above.


Move this logic out of the traffic router class


move this logic out of the traffic router class


Move this logic out of the TrafficRouter class


Passing in null here will cause an NPE in RegionalGeo.enforce


Вот, кстати, очень плохая практика — хранить API-ключи в коде. А если 1000 человек скачают библиотеку и одновременно Как Ломанутся? API-ключ — это личные данные _пользователя_ библиотеки; поэтому она должна предоставлять способ его подключить, а ключик для тестов хранить в твоём личном конфиге, который исключён из git.


I wouldn't have written if it hadn't shown up as an error after updating CSS.php to our linux preview server.


Minor
Please avoid logic constructs such as

```java
if (condition1) {
    return something;
} else if (condition2) {
    return somethingElse;
} else {
   // take another action
}
```

Instead use something more like
```java
if (condition1) {
    return something;
}

if (condition2) {
    return somethingElse;
}

// take some other action;
```


Please avoid introducing checked exceptions when possible.


Instead of throwing a checked exception it would be much better to just return null for matchRule and checking that condition.


There are a few problems here

1. We can't allow for new code with Cyclomatic Complexity problems
2. This routine assumes all of its arguments are non-null, but there are calls to it via the TrafficRouter class where some args are non-null. It is very likely you are going to experience NPE's
3. It is much more preferable for this method to return a RegionalGeoResult object or some other object as an answer to the caller


This could be re-expressed in a way that does not cause PMD cyclomatic complexity error


Nice commit typo :+1:


Please do not introduce code changes that cause PMD errors.


Thanks, I switched to that crate in a8dca8bec137193ebe1b5a7a39ab8f5d2f0afeee.

I'd like to change my build process so that I'm getting `libcore` from your phil-opp/nightly-libcore repo rather than from emk/rust, so that my build process is no longer tied to a specific Rust nightly build and I can build against the latest Rust nightlies; I just haven't gotten around to it yet.


@vkmagalhaes you might want to use a hash instead of the `case...when...then`, it's way faster as options grows:

```ruby
def status_action_from(response)
  if response['Classificacao'] && response['Classificacao']['Codigo']
    {
      1 => :authorize,
      2 => :initiate,
      3 => :wait_boleto,
      ....
    }[response['Classificacao']['Codigo']
  end
end
```


Minor:
Please do not add javadoc comments for private methods


Minor:
Please put blank lines between methods
Please do not use acronyms for variable names


Maybe we should also pull the app id into config?


@maxbridges k. I suspected that the wording might be a band-aid for unclear UI. In that case, I'm OK with keeping the current wording. Just one nit: I'd rearrange the last sentence like this, so that you're letting people know what they're doing before you tell them how to do it:

"While a stage is running, you can cancel it by clicking the run number and then clicking CANCEL."


Do we need to reset our token?


I think this should be:

Download counts: display, manifest and CSV [\#1430](https://github.com/18F/openFEC/issues/1430)


что-то нехорошее случилось с отступами в этом файле (и не исключено, что не только в нём!)


Should this be `schedule\_e` in `` ?


Because Spotless deleted the "include tag boundary comments" in the updated version of `FirstJUnit5Tests` that I committed in dd2a5515b5bbd8cbac74b2ba22063f8d321d98bb, and that automatic deletion of the comment caused the include in the user guide to break.


Schedule E


`use utf8` followed by `no utf8` is very odd, could you explain why that is necessary?


FECP? Should this be FEC?


This should probably `Seq(MutationScriptcommandResult.Uninteresting)`; the nils above are for operations that get deferred for batching.


I guess "lexical variable" is something which is not clear for a php dev


OK


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11314](https://teamcity.mesosphere.io/viewLog.html?buildId=103552&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:07:20


p.s. I made notes to these issue titles, but if these are all copy/pasted from the issue titles, we can ignore and leave them as is, so they accurately reflect what the issues are actually called.


@lwhinson Makes sense. Thanks!


CMS


Python


Can we get rid of `is_utf8` and unconditionally decode? See "Any use of utf8::is_utf8 is incorrect" http://stackoverflow.com/a/14584079


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11313](https://teamcity.mesosphere.io/viewLog.html?buildId=103551&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:08:36


Actually, I have another suggestion here (to replace my own previous suggestion). Shouldn't we map, 1:1, the available logging streams and environment variables? What I mean is:

`--log early` == `AVOCADO_LOG_EARLY=1`
`--log all` == `AVOCADO_LOG_DEBUG=1`

And so on.


spawns! NOT slots! :joy:


Fixes #28


Je had beter je bestaande repo gepusht naar een eigen repo.
Nu lijkt het of jij alles gedaan hebt

Het zou er professioneler uitzien.
Heb je ook ineens je commits van vroeger terug.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11315](https://teamcity.mesosphere.io/viewLog.html?buildId=103553&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:04:10


TeamCity pull requests :: netty-tcnative [Build 35](https://garage.netty.io/teamcity/viewLog.html?buildId=4703&buildTypeId=pulls_netty_tcnative&guest=1) is now running


No


> I don't understand this. Why does the data need to say pinned? Even with the current code, the data is only fixed for the duration of e.g. sys_recvmsg(); after that point, the array can be moved. A _SockaddrDynamic would be no different.

But ToNative() cannot make sure that the data stays pinned after ToNative() returns, i.e. the pointer must still be pinned in recvmsg(), not in ToNative().

> You make a good point that using _SockaddrDynamic would force a heap allocation for SockaddrUn and SockaddrStorage. What I don't know is whether that's actually a problem.
>
> There is thus a question here: which is "worse", possible extra GC allocations or extra code needed at every syscall boundary to check for and "manually marshal" the data via .DynamicData().
>
> I'm inclined to say that the extra code is worse -- more opportunities for mistakes to happen, introducing obscure bugs -- but that's more a gut feeling than anything.
>
> How important do you feel it is to reduce GCs in this codepath? Are the GCs an actual problem, or a theoretical one?

It might be important for SockaddrIn and SockaddrIn6 when it is used e.g. for recvmsg(), but should not be that important for SockaddrUn/SockaddrStorage.

Anyway, I've thought about this and have some other idea which I think shoud work:

    public static unsafe long sendto (int socket, void *message, ulong length, MessageFlags flags, Sockaddr address)
    {
      int _flags = NativeConvert.FromMessageFlags (flags);
      fixed (SockaddrType* addr = &address.type) fixed (byte* data = Sockaddr.GetData (address)) {
        var dyn = new _SockaddrDynamic (address, data, useMaxLength: false);
        return sys_sendto (socket, message, length, _flags, Sockaddr.GetNative (&dyn, addr));
      }
    }

    public static unsafe long recvfrom (int socket, void *buffer, ulong length, MessageFlags flags, Sockaddr address)
    {
      int _flags = NativeConvert.FromMessageFlags (flags);
      fixed (SockaddrType* addr = &address.type) fixed (byte* data = Sockaddr.GetData (address)) {
        var dyn = new _SockaddrDynamic (address, data, useMaxLength: true);
        long r = sys_recvfrom (socket, buffer, length, _flags, Sockaddr.GetNative (&dyn, addr));
        dyn.Update (address);
        return r;
      }
    }

`address.type` will point to the first field of `Sockaddr` and therefore can be passed to the native code as a pointer to the `Sockaddr`.
`Sockaddr.GetData(address)` will return `null` if no wrapper is needed (or `address` is `null`), meaning that `data` also will be `null`.
`Sockaddr.GetNative()` then will return `addr` if `dyn.data` is null and `&dyn` otherwise.

This way it the wrapper functions would be shorter (and with less opportunity to forget something which will break the code in a weird way), but everything should still be free of allocations.


TeamCity pull requests :: netty-tcnative [Build 35](https://garage.netty.io/teamcity/viewLog.html?buildId=4703&buildTypeId=pulls_netty_tcnative&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:56


It seems weird to me that this package would end up depending on `json` and its certainly weird for it have the name `NewCodecFactory`, given that the intent is to have muliptle different ones.


> Yes that's perfect. You can also move the ZmqNamedClientBus toAugmentors
> declared in the header file in the ZmqAugmentorInterface as it should not
> be needed anymore in the AugmentationLoop.
>
>
Well, there are a couple of lines that use the toAugmentors attr in the
AugmentationLoop that, in case I move it to the ZmqAugmentorInterface
would become somehow awkward. They are this two :

#1
https://github.com/Motrixi/rtbkit-public/blob/http-augmentors/rtbkit/core/router/augmentation_loop.cc#L392

#2
https://github.com/Motrixi/rtbkit-public/blob/http-augmentors/rtbkit/core/router/augmentation_loop.cc#L449

I would somehow have to make the ZmqNamedClientBus available when
those methods (doAugmentation and doConfig) are invoked. I can think of
couple nasty ways of doing so but ... they are nasty.

The not nasty way of doing it is moving all the attributes and logic
from the old AugmentationLoop into the ZmqAugmentorInterface class and
then ditch the AugmentationLoop class. Definitely more work but probably
the cleanest (I think this is what you wanted since the beginning).

Let me know what you think and I'll rework it.

—
> Reply to this email directly or view it on GitHub
> <https://github.com/Motrixi/rtbkit-public/commit/ddc27da16d547825bd94c1a34560df4d235b0ac0#commitcomment-15401874>
> .
>


Simple explanation: It's ported straight from the minified source for YNAB, and I haven't had time to clean it up or rewrite it yet. I will do that as soon as I have the time tho. My main focus was to get it working, and remove anything that wasn't used any more.


Well it's hard call. We have 2 streams `stdout` and `stderr`. I can either fake booth with custom `StringIO` object and respect where the message went, but the order would not be kept. Or (and that what's being used here) I can use single `StringIO` object and then print everything into one stream (`stderr` in this version).

To support my choice, let me notify that we are not suppose to use `print` or direct `stdout`/`stderr` writes in avocado, so I think it's safe to put everything into `stderr`.

That's actually something I did in this PR in general. Before we used to put several things into `stdout` and some in `stderr`. This PR unifies it so only `avocado.app` goes to `stdout` and everything else goes to `stderr`. Anyway as I already told Lucas, I don't have strong opinion. It just looked more systematic to me.


これまでの復習を兼ねて、タスクアプリ並びにブログアプリで学んだことを使用して年末に実装ができなかった新機能の実装を再度試みました。

★今回実装したのは、次の3つの機能になります。
1:完了･未完了を変更できるようにしたこと
2:詳細内容を確認できるようにしたこと
3:詳細内容を編集できるようにしたこと
の3点です。

★今回断念した機能:
1:詳細内容の削除
→これは、特定のカラム内における特定のデータというクエリ表記が分からなかったからです。ググッてそれらしいものがでてきましたが、何回かチャレンジしましたがどれもエラーとなったため今回は見送りました。

★今、悩んでいる機能
1:各タスク数をカウントする機能
→index.php上の完了および未完了のタスク数をカウントしようと試みました。
foreachを使用しているため上手くいかないことはわかるのですが、foreachを使用しない方針が思いつかずここで行き詰まりました。なにかアドバイスいただけると幸いです。

今回の作成にあたり、再度1から作りなおしました。
作成から上記機能を追加するまで約5時間ぐらいかかりました。

以上、ご確認のほど宜しくお願いいたします。


True


Could you use an article tag instead of div with class "news-block"?


It has been refactored in later code.


> It seems weird to me that this package would end up depending on json and its certainly weird for it have the name NewCodecFactory, given that the intent is to have muliptle different ones.

Oh, I see.  This is a centralized location.

I expected centralized decoding to be flexible on input, but I didn't expect to see centralized encoding.  Don't we know exactly what we want?


NOTE: This change also reverted https://github.com/McStasMcXtrace/McWeb/commit/28a82023a0bd9d9b9a2101b581a9baa6e6c77a07 - access to the folder/pymodule ../useradmin is handled by a symlink to this folder in mcsimrunner_ng


This is also a transitional class - bringing things together.


Do we have a test for when min == int.MaxValue? Looks like that would allow Capactity to be set > ArrayList.MaxArrayLength.


The .so is added from the Google Play Games C++ SDK when assembling the .unitypackage.  This is done to avoid checking in the same library in multiple places.  The .meta is maintained here since it is not part of the SDK.  If you are trying to build from source, please refer to the Gradle script: source/build.gradle.  It downloads the SDK and handles copying around the source code to assemble the package.


`case JString(s) => Right(new StrategyType(s))`


please don't ignore the chisel3 compatibility warnings!!  it's frustrating enough dealing with this stuff as it is.

[warn] frontend.scala:117: Bulk-connection to a node that has been procedurally assigned-to is deprecated. in class rocket.Frontend


TeamCity pull requests :: netty [Build 1019](https://garage.netty.io/teamcity/viewLog.html?buildId=4702&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6372, ignored: 23 Build time: 00:41:49


Yep, classes are also safe. I put there a list, which is not recommended to pass directly and end up using None instead to avoid warnings... I'll change it...

(I'll need to double check the `sys.stdout`, because if this gets imported before `early_logging`, the `sys.stdout` is the actual stdout and not the `StringIO)


@twoseat What?


yep


小数点，减号和退格可接受，别的一概不接受


Should be I adopted my own SF storm drain instead of I adopted my SF own strom drain


@thenickcox I assume you saw the replies? Looks like the maintainer has fixed the extension bug, and also provided a suggestion for covering the unrequired files.


Spotless deletes comments? WTF?


Excellent :) To summarize:

* Upon typing and validating the URL "http://…/contact" in your address bar, you instruct your browser to issue a request to a distant webserver (the … can be localhost:3000, cnn.com, etc. it's the base path for the website you're trying to access)
* That request is `GET http://…/contact`. It's sent over the internet and will eventually be handled by a web-server, *the* web-server responsible for the matching website. When the website is localhost:3000, the web-server is not distant, but local to your own computer, so you actually never "go outside", but the overall mechanism still holds.
* The web-server validates your requests, and if everything is in order, forwards it to your Rails web application.
* The first gateway the request goes through within the application is the router (config/routes.rb). Here, the incoming request is processed, and if a matching endpoint has been declared, the request is forwarded down to a controller's action (say, `def contact`). If there is no match, the application tells the web-server to return a 404 response (which means "Not Found").
* The role of a controller's action is to eventually render some HTML which should be sent back as the response to the initial request. Here, the controller's action, `contact`, is "empty". From Rails perspective, it means that there's nothing special to do but rendering the matching view, contact.html.erb
* The raw content of that view is internally processed and transformed into a fully-fledge HTML document (`<html><head>…</head><body>This is Lorbo's awesome Contact Page!!<h1>…</body></html>`). This text content is forwarded from the Rails app to the web-server, and which sends it back to the requesting client.
* That response will eventually be received by the requesting client (a browser, really), which will turn the HTML text into an actual page one can look at and interact with.


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-MacOS-10.9-clang: OK (2044 of 2045 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


Need apostrophe instead of single quote character for San Francisco's


Это. А script-то вовсе даже не executable! У него должны быть такие права, чтобы на юникс-системах можно было просто `bin/movie_rater` запускать (а установив гем — вообще просто `movie_rater` в любой папке), т.е. 755 (rwxr-xr-x или как оно там).


Thank you. :) My pleasure.


Consider that the end result is divided by 256...
This is not going anywhere.
Therefore I stopped the tuning.


Need apostrophe ' instead of single quote character


This was here because there were 2 places, where we had handler and used this function. With this refactor there are many places where I use this function, but don't have the handler available. So it's actually easier to get the logger here, than executing this method with `logging.getLogger` as argument.

anyway if you feel it's not right, I can change it back and call the `logging.getLogger` before....


Combine isOtherExistingFieldName and isExistingColumnName with Option[UserColumnId] and add some comment.


The original OpenGraph stuff used standard WordPress template tags, however these were never picked up because there is no WP query to pull this from. I realised `is_singular()` was returning false everywhere - all the queryng is done through the API call. The reason this was working sometimes was the `pagebuilder_tags()` function returning all the content and an image, and the `js_page_tags()` function adding a title (which wasn't formatting correctly eg "Speakers 90" or "News Video-contributing-to-the-wordpress-rest-api") and URL as every page was returning true for `is_404()`. I have removed the `js_page_tags()` function as I couldn't find any reference to the function anywhere else in the theme, and the 404 will use the default bloginfo instead.

In the `opengraph()` function, I've switched everything to use the post ID to pull through the data. The code is pretty rough but working, would love some feedback to get it cleaned up. A couple of points:

Lines 19-35:
- This is all geting the post ID based on the current page URL. It's pretty horrible code, I was wondering if there was a better way to get the ID at this point?
- Speakers seem to work differently from the other post types. There is an extra conditional for Speakers here, as the URL for them is the post ID rather than post name. I've also set up a post type variable for use later on.

Lines 37-63:
- Instead of checking for `is_singular()` etc, I've just tested to see if the title/permalink/image is available, and if it is, use it. If not, it will be set by the defaults.
- The excerpt was tricky, particularly with `get_the_excerpt()` not being available outside the loop. I've used `get_post_field()`, but this only pulls the excerpt from the database if there is one there. Any suggestions on how to create this if it is missing? A workaround is to manually add am excerpt in the back end.
- The speakers don't have an excerpt. This is because the post type doesn't have support for it. I've used the content instead here.

The `pagebuilder_tags()` function is now pulling through data based on the `$postid`. Changed `wp_trim_excerpt()` to just `trim()` as it wasn't doing anything.


Oh, forgot about that one.... thanks


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11316](https://teamcity.mesosphere.io/viewLog.html?buildId=103554&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:07:31


:+1: Looks good


This is enough reasoning to educate and convince me: *"only avocado.app goes to stdout and everything else goes to stderr"*


I am wondering if we still need the outer if check? Can we get rid of that. Can we just do following.

if device.baseFsSize > devices.BaseDeviceSize() {
    grow_device
} else if device.baseFsSize < devicesBaseDeviceSize() {
    return fmt.Errof("Can't shrink base device.")
}


Hi there,
I wonder if it is possible to use your library with the SHT21. I know that there are other libraries out there, which support I2C, but I need bit banging for connecting it to an ATtin84 RFM12B sensor node. Unfortunately I receive only negative values. I already tried pullups, but it didn't work. I guess that there must be a difference between SHT1x and SHT21 that spoils communication. Do you have a clue?
Cheers,
/luetzel


Кассеты в git не кладут обычно (это типа такая быстроживущая сущность — даже у себя локально полезно иногда кассеты стирать, чтобы извлеклись свежие данные и чтобы поймать, если вдруг у сайта радикально сменится API)


private struct with public fields looks weird.


Good idea, but it looks like the tag you want is `<<_git_basics_chapter>>` -- see the last paragraph of this file for a working reference to Chapter 2: https://github.com/progit/progit2/blob/master/book/01-introduction/sections/basics.asc


We should probably delete this third comma per FEC style. This is my bad :(


problem is, that we cant add the ```ON DELETE CASCADE``` to an already existing column. So I figured it wouldn't really matter. But I can add a migration that drops the thsirts table and adds it again


space in index: Long


Hey @sanchothefat @joehoyle, please can you review this commit and let me know what you think?

It's in relation to https://github.com/humanmade/feelingrestful-theme/issues/42

Thanks


How about moving all the functionality related to growing base device and fs and all the checks into one function say checkGrowBaseDeviceFS().

I want to keep setupBaseImage() as clean as possible. In the past also it had grown big with lots of if statements and I simplified it by breaking into smaller functions. Lets keep it that way. It makes understanding code easy. Lot of magic going around base device.


Looks good!


`sets.String`?


ObjexxFCL41 (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1513 of 1513 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.65%25-green.svg)


This line is causing some issue for Mocha. More discussion http://stackoverflow.com/a/34751711/153718


How about this, would you please modify this workaround so it handles booth `self.queue.get` calls (probably method to get from queue) and add the `logging.warn("...")` to test-logger informing about this? That should cover your problems, while I can add card to implement the second part, which should actually prevent those situations?


No, that is fine. That comment was made when I failed to realize (actually I was believing in the docstring) that logger would be a instance, rather than a name.


OK, I see. Thanks for the quick answer.


Кстати, обрати внимание, что если просто клонировать репозиторий ради интереса (и не устанавливать из него гем), то эти примеры выполняться не будут. А хорошо бы чтобы выполнялись (перед `require 'movie_rater'` изменить `$LOAD_PATH`)


Well there is one little but.... the `avocado.app`'s `error` level goes to `stdout`, which is the original behavior I did not wanted to break... (it actually makes sense as we use it to report failures)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11318](https://teamcity.mesosphere.io/viewLog.html?buildId=103560&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:23


I had mentioned over Slack to somehow test for the assembly plugin, but now I think we just need to document it. We could also test for it ourselves inside the wake command before we shell out to docker.


"Defaults to: %(default)s" usually works in the help string (not sure about here with this specific type).


You forget to fix /user/ links


Is it necessary to pass in all of these parameters?  I note from the two callsites that blocksize, replication, permission and bufferSize are the same.  If these values won't change perhaps they could be declared const or stored within the  `FileSystem` struct.


I have no idea - IntelliJ maybe? I'll be backing out that and the .iml changes before pushing to master