5420-OSCM-Docs (mitchute) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2088 of 2088 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Nit: no newline after `<p>` and possibly no paragraph


The function "error" here fails, should you be using "err"?


Nit: no newline after <p> and possibly no paragraph


TeamCity pull requests :: netty [Build 1050](https://garage.netty.io/teamcity/viewLog.html?buildId=4856&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6230, ignored: 21 Build time: 00:41:16


we require c++11 for other features, we can't build soletta without c++11 because we are using extended initializer lists a lot.

`#define SOL_BUFFER_INIT_EMPTY SOL_BUFFER_C_CAST { .data = NULL, .capacity = 0, .used = 0, .flags = SOL_BUFFER_FLAGS_DEFAULT }`


Fair point. I'll rename it.


Do we have a new bug open for block selection copy/paste being broken on windows?


Nice!


they are not required anymore with the upstream code, i've already changed it. Thanks for pointing it.


I think this won't work. See https://github.com/openSUSE/open-build-service/blob/a34cdfc1661f560ef8aee452112c1aadffe04877/src/api/test/test_helper.rb#L489

You could do a File.read directly were those xml files get used in the test.


add_custom_checks (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


true, fixed :)


awesome !! changed!


That should fix it.


Easy to constrain the block Y height below a certain level - depends how they are added in the world.
If they are added with the standard decorator there may well already be a height setting involved :P


il semble que tu n'a pas mergé index.js ^ ^


Couldn't find one so I filed https://bugzilla.xamarin.com/show_bug.cgi?id=37776


TeamCity pull requests :: netty [Build 1053](https://garage.netty.io/teamcity/viewLog.html?buildId=4859&buildTypeId=pulls_netty&guest=1) is now running


5420-OSCM-Docs (mitchute) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (956 of 956 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.85%25-green.svg)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/25735/testReport/) for this commit**


since you are using `self` everywhere, I don't think you want this to be a classmethod


The host port is on the left. (This needs to be updated in a few places.)

Also does tomcat use 8080 or 8090? Because here it has 8080 but at the top it has 8090


can you update the comment above to be consistent?


why wouldn't the templates be fields in the AlertSearch?


Minor, can you get the coefficients from R for this case, and have them in the test so in the future, people will not mess up this edge case? Also, should we `println` here? Why not `assert`? Thanks.


@carymrobbins Can you review this one?


I think I told you differently, but now that I see these diffs, you probably should add `.idea` and `out/` to your `.gitignore` for IntelliJ projects. All the gory details on gitignores here: https://git-scm.com/docs/gitignore, and here's a template for IntelliJ: https://github.com/github/gitignore/blob/master/Global/JetBrains.gitignore


My bad, you changed it to `assert`. Then I will merge this first. Can you submit a followup PR to add the coefficients?


Hello Niceyang,

I am  very interested in your NaoKinect Python Program. With your permission I would like to install and use the programs. I have a NAO V5 with NAOqi 2.1.4.13, and an Xbox Kinect hosted on Ubuntu 15.10 working with OpenNI v1.5.2.23.

Will this configuration work with your code?

Also can you share instructions for installing your code?

rdixey@comcast.net


add_custom_checks (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


What is simple mde


Very minor thing. Compare `=>` on line 8 with lines 6 and 7. Favor consistency and the `key: value` syntax when declaring Hashes.


For all three, wrap in assert_se(... >= 0).


you lack an 'endef' here, i reckon.


5420-OSCM-Docs (mitchute) - Win64-Windows-7-VisualStudio-12: OK (2056 of 2056 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Those declarations should go inside the for loop.


It's a markdown editor I'm trying to get working to make changing your about section and contract details easier. https://www.npmjs.com/package/simplemde


I was trying to figure out why cm-13 f2fs tools hang on format, and thought maybe it would be fixed in newest version.  It compiles but does not work.  Haven't worked on it at all since these commits.  It is my understanding this is a cm-12.1/13 global issue, so I am hoping the upstream is fixed soon. :)


I worry about duplicating this from nutrabolt_common. Anyway to do "after filter" like functionality here?


Ok cool


Physical elements removed


Aw, that's disappointing. It still hangs with clang disabled for mkfs as well? I would still recommend using 1.6.0 with Jaegeuk's android compatibility patch however, since there are a lot of other nice bug fixes.

Thanks!


@joprice - Nice, that looks like it should work well.  Also, I particularly like your use of `self`, I should have thought of that!


It is often hard to follow you because your words are not precise. i.e:

> why you have overwritten msg.timestamp

msg is a new object and msg.timestamp gets set not overwritten


You're absolutely right, the problem rises when you call the getInitialState directly in the method componentWillReceiveProps.


> el.namespaceURI ? el.namespaceURI + ':' : '')
>
> is not correct you should look up the namespace prefix:
https://www.w3.org/TR/DOM-Level-3-Core/namespaces-algorithms.html#lookupNamespacePrefixAlgo

After the DOM has been created, the prefix is irrelevant.

I found that the reason my tests were incorrectly  passing is that `xmlns:svg="http://www.w3.org/2000/svg"` is not recognized when using `innerHTML`, but `xmlns="http://www.w3.org/2000/svg"` is recognized correctly. This is causing the base from DOM node that is being used for comparison to be incorrect. I'm still investigating.


AddNetAreaColumnToEnvelopeSummary (JasonGlazer) - x86_64-MacOS-10.9-clang: OK (2052 of 2052 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


:D Excellent. I am interested in someone working out the difference between a couple of dungeons. Mostly spawn positioning and waypoints. This'll be a bit of time consuming bland work where you have to make sure you're not overwriting existing guids on OC with guids on TC etc. without replacing them. Making sure each creature has its correct addons deleted and recreated. Lot of work but I can see we're missing a 50+ spawns in first hellfire dungeon alone. Not to mention pathing.


TeamCity Gensokyo Lobby :: Lobster Core [Build 0.0.1.92](https://pixelated.design/build/viewLog.html?buildId=330&buildTypeId=GensokyoLobby_LobsterCore&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 267 Build time: 00:00:19


set-global (ktm) - i386-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


set-global (ktm) - Win64-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Bei Antragsgrün geht es zwar nicht um XSS, aber es trotzdem nicht `$I->click()` sonder `$I->submit()` verwendet. (https://github.com/CatoTH/antragsgruen/blob/v3/tests/acceptance/user/AccountCreateCept.php#L27)


The old value of msg.timestamp whatever it was gets overwritten  ... if you call it "gets set" or gets assigned won't change that

Happy nitpicking day ;-)


Yes, I'm interested! We can add that feature to tinylog 1.1.


Thanks, fixed in b63af3c49613d95ec1e680121c13cd95845744bf


it isn't visible in github's default view of the diff, but the previous paragraph defined the term SPoF already so I think it's OK to use the acronym here?


LGTM


I implemented above code. But not getting any inmobi ads on mopub. below is the log that i able to capture.

I/MoPub﹕ Performing custom event.
D/MoPub﹕ Loading custom event adapter.
D/MoPub﹕ Attempting to invoke custom event: com.mopub.mobileads.InMobiBan
InMobiBannerCustomEvent﹕ Reached native adapter
 D/[InMobi]﹕ Publisher device Id is xxxxx xxxxxxxx xxxx..,
InMobiBannerCustomEvent﹕ Ad failed to load
MoPub﹕ Third-party network timed out.
MoPub﹕ MoPubErrorCode: Third-party network failed to respond in a timely manner.

this logs keep repeating.. what could be the problem ?


@behlendorf
Sorry, I'm a bit late for this. This is racy and potentially use-after-free. If we only intend to use it in ASSERT, it will be fine, but maybe we should add comment to indicate so.


Hmm... thanks for the info.  I'll give that a try one of these days when I have some free time.


Yep, because is already added from cm build ... but I already removed , thanks !


Well, this scenario wouldn't arise. Either all the privileges get granted or none. The reason is that the ability to grant privilege doesn't depend on type of privilege; it depends upon whether the grantor has the "GRANT" privilege.

Thanks for brining this up though. It helped me realize that I was unnecessarily passing `privilege` argument to `checkCanGrantTablePrivilege` without actually using it. So I have refactored this code and moved the call to `checkCanGrantTablePrivilege` outside the `for` loop.


[parameter(Mandatory = $true)] needs to be altered to $false to allow existing users to continue using DSC configurations without specifying an install script.


Same as above


You just copied/pasted this, but we have a typo to fix: "of with the".


set-global (ktm) - i386-Windows-7-VisualStudio-12: OK (382 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


Ack.


It does work with gcc, and should never be reached on Microsoft Windows.


obrigado @pablomoises , seria interessante encontrar essa separata e tê-la para arquivo :)


This means we would have to store the file-list in the database. Otherwise a finja -u would index everything. And then we would have to add a way of editing that list. Having a editable list along the database seems easier. At least for now.


AddNetAreaColumnToEnvelopeSummary (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Sounds good. Keep up the awesome work! :+1:


Ugh! I introduced a subtle bug here in c830bae359ac28b7e4849151e1d0e49d5f1c79c9.

Before this fix:
![remove-character-before](https://cloud.githubusercontent.com/assets/5355/12399594/ff078036-bde8-11e5-8532-6ec816d1c835.gif)

After:
![remove-character-after](https://cloud.githubusercontent.com/assets/5355/12399600/07932b88-bde9-11e5-9048-96caee629bcf.gif)


I would make that a greedy reference. That way if both implementations are available the one with the higher service ranking is picked. Otherwise the first service which is started is used (which is not necessarily the one with the highest ranking).


Nit: returns id maybe?

A side question: are we somehow forced to call this (and the above) `parentXXX`? Wouldn't `zoneXXX` or `managedZoneXXX` be better?


You may prefer to use yaml.safe_load to avoid unwanted python code execution


Is this the way I can contribute? I want now to continue but it's kind of locked... I'll try another day.


Nit: no newline after `<p>` and possibly no paragraph


I think maybe no `!`. Don't want to be too excited about it.


Apologies, this line in the checkpoint has a mistake in it (since reported):

```
expect(:user).to_not be_nil
```

That expectation can never fail. `:user` is never `nil`.

The checkpoint ought to have this line:

```ruby
expect(assigns(:user)).to_not be_nil
```
This line can fail if the controller action does not assign a value to `@user`.


For some reason, I started getting this:
```
>> java.net.InetAddress.getLocalHost
Java exception occurred:
java.net.UnknownHostException: dimitris-pro.ad.bcm.edu: dimitris-pro.ad.bcm.edu:
nodename nor servname provided, or not known
	at java.net.InetAddress.getLocalHost(InetAddress.java:1473)
Caused by: java.net.UnknownHostException: dimitris-pro.ad.bcm.edu: nodename nor
servname provided, or not known
	at java.net.Inet6AddressImpl.lookupAllHostAddr(Native Method)
	at java.net.InetAddress$1.lookupAllHostAddr(InetAddress.java:901)
	at
        java.net.InetAddress.getAddressesFromNameService(InetAddress.java:1293)
	at java.net.InetAddress.getLocalHost(InetAddress.java:1469)
```

I will put a `try ... catch` around it and use the old method when java fails.


Rather add a proper callback for that, this is inflexible and slow.


Removendo a instalação dos icones e da tela de login do elementaryOS.


add_custom_checks (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-AddressSanitizer: OK (3041 of 3041 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


lower case, duh!


Hello Brad.
What do I have to now?
Thanks so much.
Aureliano


This service as well as the ComponentDisablerDriverFelix is resolvable in AEM 6.1 (as 1.8.3.R1658944, shipped with AEM 6.1, is implementing both APIs). I would prioritize one implementation to make the behaviour deterministic with the help of the service.ranking property.


Yeah, fuck you zsh!
Oh wait, I thought we were talking about something else.


typo ;)


to be fair i didn't try and do the nuget pack stuff.

In order to do that you need to update the nuget.exe.
Sorry, I didn't take any CI/CD concerns into account.

On 18 January 2016 at 16:47, Timothy Shields <notifications@github.com>
wrote:

> @MrTortoise <https://github.com/MrTortoise> Thanks a lot for this! I
> agree with the switch to System.Collections.Immutable. Could you comment
> on why you added all of these to packages.config as well?
>
>    - System.Collections
>    - System.Diagnostics.Debug
>    - System.Globalization
>    - System.Linq
>    - System.Resources.ResourceManager
>    - System.Runtime
>    - System.Runtime.Extensions
>    - System.Threading
>
> I don't see why those are listed in packages.config but maybe I am
> missing something. :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/MrTortoise/graphviz/commit/9aa0222c376070b31dfc48455fe639e0bf9f3bf6#commitcomment-15512078>
> .
>


set-global (ktm) - Win64-Windows-7-VisualStudio-12: OK (382 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


Hi Luke, as you can see the gallery has a three column grid which is as I wanted, but, with no gutters!
This because I didn't know how to add them without messing up with the alignement and keeping the images on the external column without external margins. How can I do that?


Static imports should go first, also avoid on demand imports and favor explicit ones.


See? We need a chimp in the team :(


I believe all you need to do is update the plugins that you have to the latest version. If you were using PB v3.1.1 and PBT v2.1.1 when you navigate to your network admin pages, it should indicate that there are new versions (3.1.2 and 2.1.2)


ololo


lalala


remove this cout


What's the suggested way to do timeout? thanks.


(Apologies, this mixed usage was demonstrated in the assignment)

Favor consistent hash syntax. These hashes use a mix of hash rockets and json/colon syntax:

```diff
+ <%= button_to "Yes", {:controller => "users", :action => "create", :params => params}, class: 'btn btn-success' %>
+ <%= button_to "No", options = {:controller => "users", :action => "new", }, html_options = { :method => :get, :class => 'btn' } %>
- <%= button_to "Yes", {controller: "users", action: "create", params: params}, class: 'btn btn-success' %>
- <%= button_to "No", options = {controller: "users", action: "new", }, html_options = { method: :get, class: 'btn' } %>
```


Seems better as just `except Exception:` (or ideally a more specific error class if possible, like `OSError`). And `except Exception as e:` (that is: using `as` instead of a comma) is the way to go if you need to do something with `e`.


Please remove trailing comma. :) Thanks!


помести этот метод перед private SourceInfo info. Статичные штуки идут первыми в классе по кодстайлу.
Скорее всего,  попросят написать javadoc для этого метода, где нужно описать, зачем это нужно делать.


See also
https://www.iso.org/obp/ui#iso:code:3166:MK


yiz


(view the previous feedback on GitHub rather than email as I made a mistake in the original comment that may have been emailed without the fix).


Can we make the app name configurable via CF_APP?


you can do
```go
if !affinityMatches {
	return false
}
```
here, since `affinityMatches && antiAffinityMatches` will be always false, the function can never return true in that case.


well no...
18445 - is for quest fixed here...
18369 - is for another quest "Corki's Ransom" ...
You just need to keep up with story line.


Можешь пожалуйста привести пример результирующего js? Мне интересно,  как будут объявлены переменные.
К тому же, разве unicode sequence нет слеша вначале? Типа \uXXXX ?


was a mistake. Look my second commit.


5420-OSCM-Docs (mitchute) - Win64-Windows-7-VisualStudio-12: OK (2056 of 2056 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


В этом пекедже нет никакого *Utils класса?


Se crea un presentador, pero prácticamente no se usa...


Nit: we break lines after the `=` symbol.


Why are you changing the version? 1.5.0-SNAPSHOT is just fine...


you can simply do `return antiAffinityMatches` here, with the change I mentioned above done.


Good point. Done in the new commit.


Bien aquí al crear el fragmento y pasar la lógica a este


Consider using ``super().__init__(statechart=statechart)``.


You may be right. The code needs at least a few tests like these before it can be merged into master anyway. I'll write a few tests and check out both the current code and yours.


Hello BradI'm doing so now. I'll let you know if something is wrong after update.God bless you.

BEST WISHES,
AURELIANO

Date: Mon, 18 Jan 2016 10:48:05 -0800
From: notifications@github.com
To: pressbooks@noreply.github.com
CC: ausapa2007@hotmail.com
Subject: Re: [pressbooks] Tagging and releasing version 3.1.2. (4879fe8)

I believe all you need to do is update the plugins that you have to the latest version. If you were using PB v3.1.1 and PBT v2.1.1 when you navigate to your network admin pages, it should indicate that there are new versions (3.1.2 and 2.1.2)

—
Reply to this email directly or view it on GitHub.


Неа


La idea de usar MVP es dejar la lógica de conexión en el presentador. Como el presentador no se usó, prácticamente no estamos cumpliendo con el patrón MVP.


This backported fix didn't work.  Turns out the results appeared so fast because it was only returning a small fraction of the full results :-(


Just going for some simple low-hanging-fruit here.  In my tests a query that was making this method block for 173s only blocked for 76s after this fix.


I believe ``self.type`` can be rewritten as a property that returns current class name, ie.:
```python
@property
def type(self):
  return self.__class__.__name__
```

But do we really need this if we already have distinct subclasses?


Also you should probably avoid using ``type`` as it shallows built-in ``type`` function.


Is this bundle development discontinued? Can't get the plugin to work =(


Nope


s/tru/true/


Hahahahah. Public in jokes are awesome!

On Tue, 19 Jan 2016 12:14 am Adi <notifications@github.com> wrote:

> Yeah, fuck you zsh!
> Oh wait, I thought we were talking about something else.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dufferzafar/dotfiles/commit/56547739a8e320de613313106c02d3c68cb99d88#commitcomment-15514324>
> .
>


add_custom_checks (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


cheguei aqui


@ezequielc I think we should add `apps.displays.alerts` here.

There is a potential (existing) issue where if you change companies while on Alerts it won't refresh the data.

Thanks.


In practice our queries always have a primary key ("id")


woot!


set-global (ktm) - i386-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


set-global (ktm) - Win64-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


ActRec


Please fix comment:
```
(gdb) print sizeof(ActRec)
$1 = 64
```
instead it's better to put `// Increase sp of 16 byte on top of Stub ABI so that it matches the architecture's minimal call frame structure according to ABI as a unwind can happen and the stub frame must follow the ActRec structure.`


Would be good to test these new methods in the passing_game_log_spec.rb.


Ok, I'll restore these builds


A general note for the future:
we probably want to refactor the namespace when functions are also used agent side. Some functions require a catalog (i.e used when compiling (using puppet terminology), but most of them are general (in the ruby version, the functions are under a "functions" namespace).

No need to change this now.


@alex-deaconu ok, I will add it. Thanks.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11863](https://teamcity.mesosphere.io/viewLog.html?buildId=107270&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:03:53


Done!


'Tom Brady' will be used for Jimmy's name too.

Try extracting the player's full name from the HTML page using the techniques you've learned. Put this name into a variable and use it on line 15 instead of `'Tom Brady'`


5420-OSCM-Docs (mitchute) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1507 of 1507 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


Yes. I stopped developing this a while ago, and deleted the original repository (it was well out of date) probably a few months ago. This appears to be a mirror/fork/whatever of the original code.


dałbym jeszcze if(dv>2)


Good ideas.  We should consider those when doing a larger overhaul of this email, including a properly designed email template.

This is a small change to address specific customer feedback at minimal cost, so I'm going to leave it as is for now.


I hope, that more test cases will make us more confident about applying this fix :) So, I'll create separate PR for that with more tests & checks


const char *


Probably you can make code look nicer by removing redundant using directives. It can be don easily in XS/VS with code refactoring tools.


My thinking is : msg_title and msg_body are fields in class Alert() and we should not muddle the AlertSearch model with msg related fields. So I want to keep these two separated. But we still need AlertSearch to build out the template with params passed-in via the celery task at the time of execution. So we will have a function to do that, but not the model entries.

I dont want AlertSearch, the ES query to explicitly have these


Remove line 8 as this overwriting the `url` variable set by `each` on line 7.


Don't forget docs and tests (test can be no-op, just to catch regressions)


TeamCity pull requests :: netty [Build 1053](https://garage.netty.io/teamcity/viewLog.html?buildId=4859&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6230, ignored: 21 Build time: 00:41:18


Así como le comenté a Carlos Polanco, esto debe ir en el presentador, por tanto no se cumple patrón MVP.


add_custom_checks (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


> Do you know where the icons from the sidebar come from? It would be nice to have a few more following a similar style.

Just looked up the corresponding patch in Geany and they come from KDevelop - and indeed, they have a few more similar-looking icons in the latest KDevelop release. I believe it would be nice to get a few more for the sidedebar - what do you think?


add_custom_checks (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


@btiwaree The theme is already online :) Soon connecting it to backend


This class don't have to be partial because all code is located in one file.


It's for TexImage2D calls, should be GL_TEXTURE_CUBE_MAP_ARB.


Google wallet


Why remove this?
Anyway, can you upload the migration file? Need to add a donation column.


It's pity... Anyway, thanks for the info!


These values comes from osprey stock ramdisk. I suppose they're right


hardcore


set-global (ktm) - i386-Windows-7-VisualStudio-12: OK (382 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


Credit: @quantum5


Reflow to 80 characters and capitalize?

  // We don't have an explicit location for the creds specified. Let's check to
  // see if any of the paths for an application default creds file exists and
  // read that.


duplicated


Ojo que esto hace que la aplicación haga crash, ya que el recyclerView no está en MainActivity, sino que se movió al fragmento. Aquí debieses de haber puesto el frameLayout.


dit is de License voor onze game


must it be all uppercase?


Hm, it looks like I’m using `flip()` for two different things: [this call](https://github.com/mapbox/mapbox-gl-native/commit/eaeef958a5357713dd19c7031789399d6a883a76#diff-ab28faca52ff082a59393dbf97ee6fe2R415) is only intended to flip the origin from the bottom-left to the top-left, but all the other call sites are using it to apply a negative offset.


@andyetitmoves I know your commit did not break it - but it seems make test actually fails (irrespective if built with gcc or clang) - Any chance you could have a look at that (I don't have access to OSX and am looking for a maintainer of that part :) )


Hinweis: Es fehlt noch ein Aufruf von \podlove_copy_post_capabilities_to_podcasts() in activate_for_current_blog()


We do! I forgot about it, but I think I might be excused by the fact that it's currently unused ;)
I don't think we want negative_errno here, because it adds an actual runtime check. We don't need that here. But negative_errno seems useful for the next commit.


Add project documentation


I have to say this is much more extensive than I imagined. I thought we would just be making the existing constructors `protected`, and adding a simple static factory method for each constructor that's currently used directly.

I'm guessing that you're including a `Throwable` as the the first argument in the constructor because you want to be able to make the new exception wrap that as the `cause` ? I'm not sure your changes do that and, although I think it's potentially useful, I think it would be a lower priority set of changes than the other functionality and stability-related changes that need to be done.


Break at 80 characters?

  INFO("write_gcm: json credentials parsed successfully. email=%s, project=%s",
       ctx->email, ctx->project_id);


See 7ba18d2


There are cases when the video doesn't fill the whole screen. E.g. letterboxing if the aspect ratio doesn't match, or things like `--video-zoom=-0.5`.


Didn't spot this one, [Key] needs to be changed to [write] to make the parameter optional.


`FinishedLaunching` method has no logic and can be removed. It will reduce amount of code in `AppDelegate` class and probably will concentrate customers' attention on actual feature. What do you think?

Same can be applied to:
* `OnResignActivation`
* `DidEnterBackground`
* `WillEnterForeground`
* `OnActivated`
* `WillTerminate`


How many records does this insert?


Hardcoded `4` is pretty ugly.


Remove comment.


My bad, I didn't add target for `py.test`. Rationale is - it is not required, because test directory doesn't contains any of these patterns. And if target is present, then recursion will be only in `tests` directory.
I'll create separate PR for py.test runner changes


Notice that the words `same` and `new` (in the button below) are bold in the design.


Why use a dash here and change a dash to slash at line 71?


Redundant using directives. This can be fixed with code refactoring tools.


Muy bien el refactor, aunque hubiese estado mejor manejar el asynctask desde el presentador.


This might not be needed if someone looks into why json can be blowing the stack. somewhere, in some json function, there is a large amount of stack space used.


Where is the sass equivalent? Notice that the styles are written in `lib/scss`, and they get compiled here by the gulp task automatically.


Missing newline


this line seems different than the c++ code, it turned out as a bug in kiwi-java, if you ported this line from java code, you probably should also take a look.


I think you have a couple of other fairly simple for loops that could be refactored like this as well.


Removed imports that weren't being used


set-global (ktm) - Win64-Windows-7-VisualStudio-12: OK (382 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


only clarck huh ;-)


Good job! I'll review and merge into legoboyvdlp/787-9.


This file use spaces instead of tabs.


add_custom_checks (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


add_custom_checks (lefticus) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Both `lat` and `lon` can be converted to constants.


As it was before, there was no way to read "any" configuration value at all.

How about reverting the inheritance and only wrapping `get` and `set`, excluding ArrayAccess?


This profiling was recently added as a response to PUP-5063. Should it really be removed now?


Agreed!


Good point, thank you.

Committed 3e3a8bbeb1d9e91901bbee25501f147059dd9978 as a temporary solution.


5420-OSCM-Docs (mitchute) - i386-Windows-7-VisualStudio-12: OK (2056 of 2056 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


How to visualize sentences through source code


missed this, should be `fmt.Fprintf(os.Stderr, "error: %s\n", err`)` or similar


That's not C++11's initializer_list. That's C99 designated initialisers and C++ does not have support for that  in any standard edition. GCC, Clang and ICC support them as an extension in the "-std=gnu++nn" modes, but they warn in strict modes (-std=c++nn) and other compilers may reject them outright.


`()` braces after `MKPointAnnotation` can be removed.


@montellese - any insights on stack usage in json?


Typo here. I wonder how the tests passed, but please add tests to cover this line.


Copy that. Cf. my comment on bloc.io


I understand your point but these configs aren't meant to be loaded from any external source. Moreover, I intend to load whole python objects with a custom yaml.Loader in a near future.


Buena implementación, aunque habría sido mejor poniendo el asynctask en el presentador


lol


Good spot. The /*exit section*/ sequence does some processing which doesn't happen otherwise.

However, I don't like the idea of re-introducing the "end" keyword as required... just hitting end-of-file should be enough.

Please do it this way:
 * Separate the close-section logic: http://www.rigsofrods.com/threads/120811-Dev-LuaPowertrain-project?p=1390652&viewfull=1#post1390652 to function _CloseCurrentSection() and call it from both here https://github.com/ulteq/rigs-of-rods/blob/7ae3bcdbd9a4df2ee66081d95b9b286fc11a4f5a/source/rig_file_input_output/RigDef_Parser.cpp#L763 and here (delete the highlighted section) https://github.com/ulteq/rigs-of-rods/blob/7ae3bcdbd9a4df2ee66081d95b9b286fc11a4f5a/source/rig_file_input_output/RigDef_Parser.cpp#L6055-L6059


I am a little nervous overloading a CUDA builtin function like `atomicAdd`. Suppose the NVIDIA compiler guys decide to implement this for us in the next version, we don't want to get compiler errors. Do you mind writing function template TF_AtomicAdd (choose a more name more sensible than that :) ), then overloading that function for double?


Adicionado sockets


:heart:


Please constrain the signature to `Vector{UInt8}`, just in case.


AddNetAreaColumnToEnvelopeSummary (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2090 of 2090 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Damn, thanks!


Sorry @nsuke , I usually do this
```
sh bootstrap.sh && ./configure && make check cross
# If you use Chrome, run:
# 	cd /home/roger/software/thrift/thrift-git/test/features
#	python -m SimpleHTTPServer 8001
# then browse:
# 	http://localhost:8001/test/result.html
```
I did not recognize the ``cd  /home/roger/software/thrift/thrift-git/test/features`` somehow and just started the SimpleHTTPServer and the webserver the URL did not present the test results, so from my point of view it was obviously wrong...
However it seems that you are doing it in different ways with different work directory...

Shall I revert my commit?
Or shall we modify so that the server always serves the root source tree?


project_Id can still be NULL here (because the project_id might not be specified in the config). Propose

  if (project_id == NULL) {
    ERROR("write_gcm: Failed to get project_id from credentials or config.");
    goto leave;
  }


Liggy is the best! :tada: :clap:


i think one could force the crash on other platforms by setting stacksize to some low value - @MrMC any idea what the stacksize is by default on tvos?


yeah. Will add.


I know


s/the  given/the given/


Maybe one new line will be enough here? ;)


Not sure if we really need this. I can't see any of these services in stock ramdisk.


Hi there, after a long journey thought the web i found this.

I lately had the idea of doing a chromecast by myself and discovered DIAL.

Ad you said, you can send youtube by sharing, I already did, but there are more and more apps running commercials before the content this doesn't work, so I wanted to have XMBC or esp. Kodi to act like a chromecast.

Because Chromecast support grows i think your efforts are useable, and i would like to help develop them.
I will be able to research onto kodi plugins to get this to work but you seem to have further knowledge about DIAL, so what are the minor changes you have mentioned and what would be next to does or can i simply update the first loop for other apps?

Would be nice if you get in touch with me, I'd really like to envolve this :-)


Ah right. I'll submit a PR for that soon.


I believe this is a typo in the slot. onScalertStopDwelling has an extra t between scaler and stop.


try add this line "props.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "earliest");"


my bad, removed the redundant file in latest commit


@infograf768
The official United Nations name remains as
former Yugoslav Republic of Macedonia
This has not changed.

The name 'Republic of Macedonia' is used in bilateral diplomatic relations but it's not the official UN name.

https://en.wikipedia.org/wiki/Macedonia_naming_dispute
http://www.un.org/en/members/countryinfo.asp?countryname=macedonia
http://www.un.org.mk/

This is a controversial matter and I suggest that we kept the UN name, not because I'm Greek, I really don't care about politics, but because it will inflict a controversy to the community on a sensitive subject.

Just a thought


Can you add the comment below to the changed class
Portions Copyright [2016] [C2B2 Consulting Limited and/or its affiliates]


Just wanted to shorten it as the configuration is accessed frequently. Thinking about it, I don't care ;)


thx


I see, well, that's a bug in my code then as well :)


For `scatter_update`, the doc says
> If indices contains duplicate entries, lexicographically later entries override earlier entries.
Do you think this achieves that semantics? In either case, I think this code is fine. We can consider changing the documentation, as I don't see anything useful about the currently stated semantics.


5420-OSCM-Docs (mitchute) - i386-Windows-7-VisualStudio-12: OK (2056 of 2056 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


hmm, how about replacing .isalnum() with "in _PATTERN_STYLE_BY_PREFIX"?

Would also simplify the below code a bit.


What about using a `@BeforClass` method?


Nit `// ok` -> `// expected`


Project Report


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11864](https://teamcity.mesosphere.io/viewLog.html?buildId=107273&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 207 Build time: 00:04:21


I think you're going to find that the inability to customize the alert title and body templates will be an issue.  What if the interesting thing about the query is a statistics aggregation?  The number of hits may not have any meaning.  Instead you'll want to indicate that some threshold was violated.


I'm a Haxe fan - but currently using your implementation as a reference implementation.  My colleague Yong is working on Haxe-Java issues - we are comparing your implementation with Haxe-Java to figure out where the implementations differ from Kiwi-cpp.    Have you shared your code with folks at http://snowkit.org/ ?  I recall their blog mentioned looking at a cassowary layout in an upcoming release of Mint.


This is the most beautiful commit ever.


AddNetAreaColumnToEnvelopeSummary (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (958 of 958 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.87%25-green.svg)


channel cannot be used there, as this poses a recursive problem (how to get the channel before decoding the charset) this is corrected in next commit.  modifier_data can only be constructed from `weechat_plugin->name` and `server->name`, but not from channel (we have not yet decoded it) and/or nick (at least domain mask, and channel name can be encoded with iso-8859-15 in `irc-hispano.org`)


Comment doesn't match the code. Propose:
```
  // If we got a project id from the credentials, use that one.
```
HOWEVER: maybe you meant for the config file to *override* the context (which would make sense to me)? If so, then maybe this should be

```
  // Try to get a project_id in order of preference:
  // 1. From the config file
  // 2. From the credential context
  const char * project_id = cb->project_id;
  if (project_id == NULL && build->cred_ctx != NULL) {
    project_id = build->cred_ctx->project_id;
  }
  if (project_id == NULL) {
    ERROR("write_gcm: Failed to get project_id from credentials or config.");
    goto leave;
  }
```


Isn't this redundant? If an exception is thrown the test should fail (also applies to the following)


`DualLocation` is an implementation class, and should not be referenced. `DualLocation.getObjectLocation()` is an implementation detail as well. This code should only use `TypedLocation` and on that one do a direct `get(..)`


add_custom_checks (lefticus) - x86_64-MacOS-10.9-clang: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hi, I just amended the commit comment to put 120 and not 284 as issue number.


you know that you do not need the () to create a tuple?


PR #97


Hi!

It would be very nice to have these changes in the core library. There are several changes in the core which are required in Android. But I'm not sure how these changes would work for other "Java-environments". Here is the list of changes:

* https://github.com/Doist/commonmark-android/commit/9cbd71c688f5ae7cd73577c8bcb57887c87b3a82#diff-f9610368ae6200bf9a708bc024007d2eL46

* https://github.com/Doist/commonmark-android/commit/9cbd71c688f5ae7cd73577c8bcb57887c87b3a82#diff-90d3d74e6691f74e4a6d42b9104e0f9fR82

* https://github.com/Doist/commonmark-android/commit/9cbd71c688f5ae7cd73577c8bcb57887c87b3a82#diff-d578d210c2502f36ce19937ea4fac22fL87

* https://github.com/Doist/commonmark-android/commit/9cbd71c688f5ae7cd73577c8bcb57887c87b3a82#diff-f614b637a03bbf10cf18537a6c2955daL67

If it's ok I can create PRs for these changes.

And if all these changes would work eventually then I would be happy to create (or try to create at least) the artifact with Android support 😄


Are "Casualties" from a different data-set? The couple I looked at don't add up (e.g. 1678 "injuries" in totals, but 1662 "injury collisions"?) 2014 says 160 "injuries" but only lists 159 "injury collisions"...?


cool :)


Any idea what `auto/config.h` is for? I removed it and everything still built.


Added quotes around URLs to allow addition of ftp servers username and password in the build-arg URL.


Regarding the `OWNERSHIP` -> `GRANT` change, yes, your interpretation is correct. Yeah, will re-arrange the commits.

Regarding the unit test, are you suggesting to add a general test for `GRANT`?


I should have rebased this next to this commit: [Move config loading to initialize method](https://github.com/nochso/php-semver-checker/commit/02f70f1a25b4ed274cbf77b2a21b315828f48bd9)

Simply wanted to re-use the main Command methods (initialize, interact and execute). I also thought about extracting a Command class to inherit from. It would take over the config/input preparation for any extended commands.


why is one of the above 3 variables being escaped but not the other two?


I see. I think the cast is to ConstantLocation in the last version.


wg_credential_ctx_destroy() needs a
```
   sfree(ctx->project_id)
```
at around line 414


"path prefixes"?


Q9923 - npc 18445 - credit - 18369
Q9955 - npc 18369 - credit - 18445
In my opinion there is not right
Sniff there ??)


couldn't the above data be added to the markup?


TeamCity Ppconsul :: Build (Linux) [Build 68](https://78.46.71.115/viewLog.html?buildId=656&buildTypeId=Ppconsul_BuildLinux&guest=1) is now running


set-global (ktm) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


gfgdgdg


here you say path prefix also.


I'd slightly prefer this to be an "else if" due to the hypothetical possibility of both 'ifs' firing for a really weirdly constructed string and thus causing a memory leak. :-)


5420-OSCM-Docs (mitchute) - x86_64-MacOS-10.9-clang: OK (2050 of 2050 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Not needed. Most of official CM device tree use LOCAL_PATH here. Take a look at lettuce device tree for exaple


remove double blank line


Looks like these cases had never been tested before, and segregating them out made them susceptible to the typo not getting caught.
I'll fix.


Yes, I will change them too.


This `this.` can be removed safely and according to mono guidelines:
> The use of “this.” as a prefix in code is discouraged, it is mostly redundant


Ok, makes sense.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11866](https://teamcity.mesosphere.io/viewLog.html?buildId=107279&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:04


Missed the WHERE


`pId` and `mId` can be converted to `const`


btw, if you write "...., fixes #361" as 1st line of commit comment, github will automatically close the issue.


Nope, sorry, I was hacking forgot to restore it.


I'll think about a new class or reverting it.


WHERE?


add_custom_checks (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Is this used?


Your right, this is racy.  How about we just pull the check itself under the z_hold_locks so this is safe.  The result of this kind of check is always racy anyway the calling task is the one holding the mutex.


I'd rather let the link point here http://rocha.la/JavaScript-bitwise-operators-in-practice @timjrobinson


Thanks h3h3 :kiss:


Do you know how long this suite would take to run? If it takes more than a couple of minutes then we have reconsider this.


`def fromConfiguration(custom:Option[Configuration]) = None`


I experimented since dependencies did not work. I did not remember what the correct way of declaring a dependency was, and I suspected the slash/hyphen was the cause. It was not, and they do not have to change to slashes. I should revert that change.


This broke pitch setting with A_Face*(0,0)


TeamCity Ppconsul :: Build (Linux) [Build 68](https://78.46.71.115/viewLog.html?buildId=656&buildTypeId=Ppconsul_BuildLinux&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 96 Build time: 00:05:10
### Failed tests
```
null: global.kv.index: CHECK: 317 > 319
at /var/TeamCity/buildAgent/work/b87bef787eb069fe/tests/kv/kv_tests.cpp:697

```


Indentation is messed up here because the ERROR line uses a tab rather than spaces. I also personally think TAB is poison. And the line is longer than 80 characters :hamster: :8ball: :santa:

Propose
```
      if (build->cred_ctx == NULL) {
        ERROR("write_gcm: wg_credential_ctx_create_from_json_file failed to "
              "parse %s", cred_path);
        goto leave;
      }
```


hey @twinaphex, I see you replaced the call to ```supportOtherAudioSessions``` with the explicit AVAudioSession code

```
#ifdef HAVE_AVFOUNDATION
   /*  Implicitly initializes your audio session */
   [[RetroArch_iOS get] supportOtherAudioSessions];
#endif
```
Was it causing the OS X project build to fail? (I couldn't really find anything in the buildbot logs)

Commenting to point out that a few lines above this code is the ```#if defined(HAVE_COCOATOUCH)```, so this block was already exclusive to the iOS app. Just an observation, it's not hurting anything so it's all good. :+1:


Type case is redundant. `(MKPinAnnotationView)` can be removed.


done


yes on line 52, also it could be used elsewhere I saw that pattern


Pourquoi avoir remplacé :
Bocal renforcé par Bocal conjuré ?
"conjuré" s'applique plus aux personnes non ?
De plus avant il y'avait les warded blocs, du même style.

Je trouve pas de définitions adéquat de ce mot pour le bocal. Peut tu m'expliquer ?


Yeah, HAVE_AVFOUNDATION is a define that can work for OSX too, so we need to make sure we don't have completely iOS-specific code grouped under that define.


What happens if for whatever reason the last `getOrElse` is `null`?


set-global (ktm) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11867](https://teamcity.mesosphere.io/viewLog.html?buildId=107280&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:17


You accidentialy removed that semicolon ;-)


fixed on line 71.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11865](https://teamcity.mesosphere.io/viewLog.html?buildId=107276&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:09:04


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


Move it to a common class / object / trait (preferred). No difference between scala versions.


from PR #17


@atlight This apparently breaks the outer `<nowiki>...</nowiki>`. When I went to update on-wiki the `~~~~` on line 2865 was transformed to my signature. Not sure how the `unbinder` works but maybe we could escape the `<` and `>`'s?


Did the change help?


fixed


> If we run into performance problems,

Did you mean to finish this thought?


your eye for detail never ceases to amaze me :+1:


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1192](http://teamcity.monogame.net/viewLog.html?buildId=13743&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


then the heuristics fails miserably...


Hello.

Just wanted to let you know that this works with a Q12HCPU with a QJ71E71-100 card beside it (using the setup instructions from the README).

Only issue so far was with:
``` 'R2000,2' ```
which threw: "MC Error response - Second byte is 88 and error code is undefined".


@americool  DWMR (done with my review) Looks good here.Press ahead!


I couldn't find examples of such negative tests that test broken SQL syntax for other SQL statements. I think this may not be necessary.


if you choose the type util.sets for namespaces, the function here can be improved
```go
func filterPodsByNameSpaces(names sets.String, pods []*api.Pod) []*api.Pod {
	if len(pods) == 0 || len(names) == 0 {
		return pods
	}

	result := []*api.Pod{}
	for _, pod := range pods {
		if names.Has(pod.Namespace) {
			result = append(result, pod)
		}
	}
	return result
}
```


I believe you're right.  I've got to seriously recheck what source my builds are using.  I'd done
```
./scripts/feeds uninstall mosquitto
./scripts/feeds install -p packages mosquitto
```
and rebuilt, and it wasn't complaining.  I'll look at this again tomorrow.


set-global (ktm) - x86_64-MacOS-10.9-clang: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Redundant using directive.


Okay Merged Nishant Narang


Please use tabs instead of spaces.


Der Kommentar war da absichtlich drin.


Why not just remove this and use `['color']` directly since memory allocations do not matter here?  Or just make this a file-scoped read-only scratch to tighten up the scope.


What's happening here?  Since this is an instancemethod, what is cls?


@m-gh [Dual licensing is redundant](http://programmers.stackexchange.com/a/105926) – you're free to relicense a copy under a GPL.


Same comment as for `GroundPrimitive._readOnlyInstanceAttributes`.


This was a poor title for this commit ("optional: output eigenvalues"). The commit message only applies to the changes in unifiormMT.m.

plotMT_TT.m was adapted to allow for vw as an alternative input to lune lon/lat.

The examples script run_uniformMT.m was reordered -- and I added the correlation matrices.


This property can be refactored to `public string Title { get; private set; }`


Yes, that would definitely do.


"init.onyx.ril.sh" and "init.onyx.bt.sh" are in /etc folder.


This property can be refactored to `public CLLocationCoordinate2D Coordinate { get; private set; }`


The safest option would be to default to `.`.


Rahul, regarding your comment on time taken by TPC-DS SF1 Original queries - I think they are well within the average. Did not see any issues. Will also monitor them for a few runs to be sure.


Instead of two separate loops here, why not concatenate `_readOnlyInstanceAttributes` in the constructor function from the array passed through `options` and the internal array.


Oh, and this should be `iconv` (the name of the C function).


Same here.


Not good. That would not reserve all two-character sequences followed by a colon for future extensions. Wouldn't have written this code the way it is if that wasn't my intention. :-)


I'm duplicating code here... ugh! But I haven't yet figured out how to prevent it! As written now, the method would have to return two values! Can I use "out" parameters? Or a class??


you're right these string markets are identical

we could also consider binding the variables too on the interpreter, it would probably better... but need to check how easy it would be


Listed device models should be either load_device_models_for_create   or the uniq selection over the device models of the devices below the navigation context.


You can sort `using`s to make them look good.


Cette méthode a le bénéfice ...


250 additions and 194 deletions
> Minor

:trollface:


Add `readonly` access modifier.


Yes, I know. I like to make the unpacking more explicit.


use head


Excessive new line


Oh you've just reminded me of browsing `features` result !
(I forgot to add the functionality)

The `cd <abspath for test dir>` is kind of implementation driven: i.e. the part of the code is not aware of the root dir.
Anything that makes it more readable would be fine for me.
Maybe `test/run-http-server.sh` that runs `python -m xxx` ?


This can be simplified to:
```
var cell = tableView.DequeueReusableCell (mapItemCellId) ?? new UITableViewCell ();
```


Zock greenlighted this


@dkayiwa this inserts variable number of record.
depending on whether a role has 'View Encounter' privilege or not. if yes then it'll add 'Get Visits' privilege, if no then it will not.


Needs a blurb. :-)


Pour la forme de la date, est ce la bonne ?
Chez moi la forme acceptée par MySQL est : "Y-d-m H:i:s" et non "d-m-Y H:i:s" !
Merci de bien vérifier


@danielwalters86: I tried your systemd script following your instruction (you also [PRed](https://github.com/Tavalin/openhab-distro/commit/d414de9979552e8ca05827e6aa99c34af6e0f570), however, on my Raspi 2 with Raspbian Jessie the command
`sudo systemctl enable openhab2`
always returns
`Failed to execute operation: No such file or directory`
assuming I've put my unit into a file openhab2.

As @jtmoderate876 suggested, I had to put the file not anywhere on the disk but exactly in /lib/systemd/system/ and had to suffix it with .service.


`this.` can be removed safely


It seems "init.onyx.ril.sh" and "init.onyx.bt.sh" are in /etc folder.
https://github.com/ashwinr64/android_device_oneplus_onyx/commit/2eb96dd41b989f7458416276dcf43964b127a6d0#diff-517ddbf954b0717917a1aac0cbd8ae8aR33


Hi Ryan,

Thanks for this! I have now integrated a slightly modified version of your patch into mainline libwdi (See pbatard/libwdi@e3e8a546655b6ab4a5fd0fcc355e199689461da8).

I did rename the driver files to `usbser` instead of `wdi_cdc` as this is the name of the driver listed by Windows after install, and edited the `.inf` a little bit as well.

I tested your patch against a reluctant Prolific Serial ↔ USB device I had on Windows 10 (looks like Prolific botched the driver they put on Windows Update, as it was failing to start), and it worked brilliantly, so thanks for adding this feature.


Ich habe das rausfiltern nochmals überarbeitet. Bei mehreren Signal Nachrichten hat die vorherige Routine nicht funktioniert.
Das "$idx = index("  und  "substr($mSIGNALduinodata, $idx+2);" läßt sich wahrscheinlich besser programmieren.

    if($buf) {
      Log3 $hash->{NAME}, 5, "$name/RAW (ReadAnswer): $buf";
      $mSIGNALduinodata .= $buf;
    }
    $mSIGNALduinodata = SIGNALduino_RFR_DelPrefix($mSIGNALduinodata) if($type eq "SIGNALduino_RFR");

    if($mSIGNALduinodata =~ m/\003\n/ ) {
      $idx = index($mSIGNALduinodata,"\003");
      Log3 $name, 3, "$name/RAW (ReadAnswerCut $idx): $mSIGNALduinodata";
      SIGNALduino_Parse($hash, $hash, $name, $mSIGNALduinodata);
      $mSIGNALduinodata = substr($mSIGNALduinodata, $idx+2);
      Log3 $name, 3, "$name/RAW (ReadAnswerCut): $mSIGNALduinodata";
    }

    # \n\n is socat special
    if($mSIGNALduinodata =~ m/\r\n$/ || $anydata || $mSIGNALduinodata =~ m/\n\n$/ ) {
      if(!defined($regexp) || $mSIGNALduinodata =~ m/$regexp/) {
        return (undef, $mSIGNALduinodata)
      }
    }


ou si l'utilisateur a une valeur de configuration mal formée, Git va simplement refuser d'exécuter beaucoup d'opérations.


thanks!


I think I'd prefer std::rename() here, not system("mv...")


I believe this one to be correct. The pural is on the “patterns”.


set-global (ktm) - x86_64-MacOS-10.9-clang-Debug: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Reply URL... is this the "SIGN-ON URL"?


dans un processus séparé, ce qui peut ajouter une complexité indésirable.


Target deleted


@gilbertohasnofb Hi, thanks a lot! I wanted to inform you after some more fixes and corrections I made.
 The size of `Models/PanelTexturing-MainPanel.png` was not intended, and has been fixed now.

Some changes I made and pushed today:
1.) correction of panel location - was not at the right station, now its is according POH
2.) added pedestal light housing - I have marked them on `Models/PanelTexturing-MainPanel.png`
3.) the biggest change: the baggage compartement has now the right size and shape. There was a whole lot missing I noticed looking at the drawing in the POH!
I added the new parts to the existing uvmap `Models/PanelTexturing-Interior.png`. Also there is only one dome light in the rear, so I changed this. I decided also to imrprove the uvmap of the seatbelt and buckles and dome lights. I have made Gimp-Paintkit with layers (`Models/Texturing-Interior.xcf`), so you should see the changes easily. The added textures are suggestions and from the DHC6.

I hope everything is o,k. now, and I hope the changes will not be too much work for you, but I think it was needed.


I think the three methods were better than this "generic" one. No need for `instanceof` and safer (someone might just implement `GenericFilter` and call `filter` with it).


Je trouvais ça bizarre que tu ais traduit "warded" par "renforcé", "renforcé" c'est plutôt "renforced", donc j'ai changé par "conjuré", ça me paressait plus logique. Après c'est vrai que pour les "warded" blocs la traduction par "renforcé" est plus logique. De toute façon c'est pas très grave, on peut toujours changer.


nice


Hey Piyush,
do you think this fragment of code could be improved? :)


@gtirloni I've removed one systemd unit in the commit 04079042 . The startup method is simpler now.


it's good. thanks


missing newline, but not sure if one should be there


good catch, thanks @tiago!


set-global (ktm) - x86_64-Linux-Ubuntu-14.04-clang-3.6-AddressSanitizer: OK (3041 of 3041 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


https://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/Multithreading/CreatingThreads/CreatingThreads.html

By default, iOS set a thread stack size with 512 Kbytes for secondary threads and 1024 Kbytes for the main thread. Note that the main thread is not the same under windows/linux as osx/ios/tvos spins out the kodi main thread to a secondary thread. But jason usage is always secondary threads.

My tests show that secondary threads matched docs and was 512 Kbytes.

Also note that debug will include stack usage and malloc debug enabled will increase it further. This issue can be replicated exactly on OSX by enabling the malloc debug flags in the schema in Xcode.

Odd thing is OSX is 64-bit as it tvOS (arm64), so why does tvOS blow the stack in json while OSX need malloc debug flags enabled to trigger it ?


en mémoire.


`jt test compiler` now runs all compiler tests and replaces `jt test pe`. To add a new compiler test put a script in `test/truffle/compiler/*.sh`. It will be run with `JAVACMD` set to Graal automatically and should return a non-zero exit code if whatever test it is fails.


dggdfgfssf
'f'
f;'
;f


i was just mentioning this because of the other word order, not because it was incorrect.


The `lifetime` variable in the `Krabll` class was necessary for selecting the longest survivors. I'm going to restore it.


Hi Jhobanny,

Thanks for this. But I just tested and worked fine. The reason that I changed html() to text() is that, if you have reserved html characters such as > or <, in the result html entity such as > or < is populated in the field on select.

Cheers,


This won't work, that's not a mod. Use `ModAPIManager`


ah, ok.


Nice! Now please add a `.gitignore` file to the repo so that it can ignore `.pyc` files, and also send a commit removing the bytecode file that was accidentally committed here.


You should mention going File > Make a copy and filling out the [HIGH SCHOOL] and [NEXT MEETING DAY] fields on slides 4 and 10.


:lollipop:  redirection of the feedback and collaboration preferences thru the employeeService and thus removing the svcfeedback
:lollipop: had to accommodate the ORM model changes for ORM


#### 编码
`var isPhotoOrVideo = Bool()` 建议改成 `var isPhotoOrVideo: Bool?`


haha good!


Then why do it? The header gets included at many places, the compiler has to parse and then discard the struct many times.


#### 编码
```
self.camera = LLSimpleCamera.init(quality: AVCaptureSessionPresetHigh, position: LLCameraPositionRear, videoEnabled: true)
``` swift
建议改成
``` swift
self.camera = LLSimpleCamera(quality: AVCaptureSessionPresetHigh, position: LLCameraPositionRear, videoEnabled: true)
```


are the "special" cases used at all?


By adding the 2 line code above on CsvView file, I am now able to export with datetime. Thanks!


prefix based probably will be more slower according to match based search


OK, got it. Sorry, I wasn't getting the separation. :laughing:


No copyright notice - should have ALA one


wow!
call me pinky, agent-orange!
pls reuse localised date in title  (see "Localized formats" in http://momentjs.com/docs/#/displaying/format/)

I put the week there mainly to make clear why it starts with Monday or Sunday - respectively why it doesn’t switch one exact month ore one exact year). I guess we can make it smaller...


`%String{}`


unnecessary whitespace between imports


I don't know of any model that uses these pieces, but no doubt ZK will prove the exception...


In [this section](https://github.com/mshang/python-elevator-challenge/blame/master/README.md#L142-L152) of the doctest's README.md it requires the (non-moving) elevator to service a `select_floor(5)` *before* servicing another call from a floor that was requested first:
```
Elevators want to keep going in the same direction. An elevator will serve as many requests in one direction as it can before going the other way. For example, if an elevator is going up, it won't stop to pick up passengers who want to go down until it's done with everything that requires it to go up.

    >>> e = Elevator(ElevatorLogic())
    1...
    >>> e.call(2, DOWN)
    >>> e.select_floor(5)

Even though the elevator was called at the second floor first, it will service the fifth floor...

    >>> e.run_until_stopped()
    2... 3... 4... 5...
```

How often have you stood inside of a stationary elevator without pressing a button?   If you have, you may notice the elevator beginning to move.  That's because someone else wants to use it.   Someone that knows how to push a button to achieve the desired result.


You have to create a README with sufficient explanation, proper installation steps and usage. You can refer to this [README](https://github.com/hsercanatli/tonic_identifier/blob/master/README.md) file.


前回コメントし忘れたのですが、プロトタイプの中でmain_thumbnail, sub_thumbnailのように管理するのではなく、captured_imagesテーブルを作成し、そこでプロトタイプの画像を管理しましょう( ˘ω˘)
今のままだとサブが一枚しか保存できない仕様になっています( ˘ω˘)


两步认证


あれ、これもいらないですよね？


I generally have some code to catch exceptions from service class here and then send the appropriate HTTP code - 400, 500, etc. If the webservice fails for some reason then this JSON service will still send a "200 OK", which is not OK. Or else it will get rendered as an HTML exception page, which is also not desirable.


**List of resources: Bibiliography, Source, and Notes**

For those who are not yet familiar with using Cabal for Haskell, see [How I start] (https://howistart.org/posts/haskell/1)

Butler Lampson's 1969 "Experience with Processes and Monitors in Mesa", with [parallel ideas to Unix, especially Processes and their role as Ops] (https://www.cs.berkeley.edu/~brewer/cs262/Mesa.pdf)

Neil Gershenfeld "When Things Start To Think", especially his Bill of Rights for Things

[The evolution of logic, from Brouwer Frege Russell Wittgensten Turing Post Gentzen LK LJ LJT -- natural deduction Church Curry - Howard (Proofs to Types)] ( https://en.wikipedia.org/wiki/History_of_logic) [ intuitionistic logic – direct, palpable experience: Per Martin-Lof |-](https://en.wikipedia.org/wiki/Intuitionistic_logic) and [Constructivism](https://en.wikipedia.org/wiki/Constructivism_%28mathematics%29) -- constructivism is  for builders and makers.

[Algol had no native I/O, just like C and Haskell](http://comjnl.oxfordjournals.org/content/5/4/349.full.pdf+html )

[ghci, dealing with exceptions] (https://donsbot.wordpress.com/2007/11/14/no-more-exceptions-debugging-haskell-code-with-ghci/)

[Girard-Reynolds isomorphism] (https://www.cs.st-andrews.ac.uk/files/2004-5-2%20Lecture3.pdf)
["Types →Programs" Wadler – It's true for GADTs] (http://wadler.blogspot.com/2007/04/google-tech-talk-
parametric.html) see [theorems for free] (http://ttic.uchicago.edu/~dreyer/course/papers/wadler.pdf)

[Haskell 98 tutorial](https://www.haskell.org/tutorial/haskell-98-tutorial.pdf) [Haskell 2010 report](https://www.haskell.org/tutorial/haskell-98-tutorial.pdf)

[Debugger commands – ghci> :browse] (http://dev.stephendiehl.com/hask/)
[Basic error messages](http://ics.p.lodz.pl/~stolarek/_media/pl:research:stolarek_understanding_basic_haskell_error_messages
.pdf)

[Data.Either.Either] (https://hackage.haskell.org/package/base-4.8.1.0/docs/Data-Either.html)
[need systematic handling] (https://www.haskell.org/definition/haskell2010.pdf) 7.3, ch.42

[Real World Haskell ch.19 error handling] (http://book.realworldhaskell.org/read/error-handling.html)
*NestedCallCC -- see MonOps/src
*concrete data either -- see  MonOps/src
*[Data.Text](https://hackage.haskell.org/package/text-1.2.2.0/docs/Data-Text.html)
*[Haxl SQL exception example]( https://github.com/facebook/Haxl/tree/master/example/sql)
Haxl https://github.com/facebook/Haxl/blob/master/Haxl/Core/Exception.hs
[Control.Exception notes] (https://hackage.haskell.org/package/base-4.8.1.0/docs/Control-Exception.html )


Does this mean we could migrate the code from ethereumjs-tx (https://github.com/ethereumjs/ethereumjs-tx/blob/master/index.js#L196-L211) to here?


Thanks for noticing me. Though his work is great, he based on his own patch which was send to Vim's mailng list and it was refactored by Bram, eg: `dobin, dooct, dohec` -> `what`. If #3919 is directory merged, it  is hard to port related patches.

BTW I don't know which way is better. How about you?


Should this be still be 0x81 or 0xC0? (from looking at the latest commit)


@oni-link Thanks for noticing me. Though his work is great, he based on his own patch which was send to Vim's mailng list and it was refactored by Bram, eg: dobin, dooct, dohec -> what. If #3919 is directory merged, it is hard to port related patches.

BTW I don't know which way is better. How about you?


I'm not sure. First, what do you mean, it can be achieved with SMuFL? And second, how exactly do my xxx_SIZE_FACTORs contradict the SMuFL specs? I assume you're thinking of the "Notes for implementers" in the specs, but it's not really clear to me that it contradicts that. Finally, as far as I know, notation in the Middle Ages was so far from being standardized that I can easily imagine a user wanting several different relative sizes for symbols (for use with diplomatic transcriptions of different manuscripts) but not wanting to use several fonts that differ only in the relative sizes of symbols. But I'm no expert on mensural notation; I could be wrong!


Might want to make this list configurable via ext config...


did you mean

```c++

class DensePolicy {
  // ...
  template <typename P>
  using mult = typename mult_policy_trait< DensePolicy, P>;
};

static_assert(std::is_same<DensePolicy::mult<SparsePolicy>::type, SparsePolicy>::value, "");

```

since `mult_policy_trait<DensePolicy,SparsePolicy>` should be defined next to `mult_policy_trait<SparsePolicy,DensePolicy>` they should be standalone...


I don't know 😢


Makes sense


xd


코멘트를 남겨봅니다.


@oni-link Thanks for noticing me. Though his work is great, he based on his own patch which was send to Vim's mailng list and it was refactored by Bram, eg: dobin, dooct, dohec -> what. If #3916 is directory merged, it is hard to port related patches.

BTW I don't know which way is better. How about you?

Sorry for misoperations.


there is a note about it, but nothing about its usage:

https://springrts.com/wiki/Assimp

for testing if used just add an log error message?

validation test runs zk, too.


The class should not be initialized with the distribution, tonic and makam. These are inputs, not initialization parameters.

Think the situation that you will consecutively process hundreds of audio files. In the initialization above, you have to re-instantiate an object from the class for each run.

For this class you don't have any parameters, so you init phase should assign nothing. See the instantiation of [tonicidentifier](https://github.com/hsercanatli/tonic_identifier/blob/master/tonic_identifier/tonic_identifier.py#L14-L24) as an example when you have parameters for particular method and how an object should be instantiated.

I will explain the inputs in the function headers.


See above


See two comments above


I don't believe this to be correct behavior for an elevator.  It requires the (non-moving) elevator to service a `select_floor(5)` *before* servicing another call from a floor that was requested first:
```
Elevators want to keep going in the same direction. An elevator will serve as many requests in one direction as it can before going the other way. For example, if an elevator is going up, it won't stop to pick up passengers who want to go down until it's done with everything that requires it to go up.

    >>> e = Elevator(ElevatorLogic())
    1...
    >>> e.call(2, DOWN)
    >>> e.select_floor(5)

Even though the elevator was called at the second floor first, it will service the fifth floor...

    >>> e.run_until_stopped()
    2... 3... 4... 5...
```

How often have you stood inside of a stationary elevator without pressing a button?   If you have, you may notice the elevator beginning to move.  That's because someone else wants to use it and they pressed the button before you did.   The elevator is unaware that it has a passenger because its doors are closed at this point.

If however there was a `e.call(1, UP)` beforehand, this would make sense.  The elevator would then open its doors and the following `e.select_floor(X)` would be serviced.


JavaRDD<String> lines = sc.textFile("hdfs://10.92.131.114/user/CNSHYQH/mnist_svmlight.txt",60000 / conf.getConf(0).getBatchSize());


throw exception from `webservice.doPost` here?


#### 疑问
这里为什么还有addSubview


We don't need to instantiate this. Remove...


part 2 actually. whoops.


JS(Java)doc here would be good


Ugh... going to need to retab more things...


This function should be static, because it will not need any parameters from the object to run, i.e. the results only depend on the inputs.

To make a method static you simply have to add "@staticmethod" to the start of the function and remove the "self" from the inputs. [Example](https://github.com/hsercanatli/tonic_identifier/blob/master/tonic_identifier/tonic_identifier.py#L26)


What about testing for a condition where the webservice returns: 0 results, bad request due to invalid params?


This cause a bug in compilation. You must load "build-all.bat" for know that I am saying.


Fixed at commit 20e6306ed2ef5ffd507c8556c7b04febe3d49070


嗯？ https://en.wikipedia.org/wiki/Two-factor_authentication 应该是都可以？


a = [1,2,3,4,5,6,]
print 'hello world'


I believed I did this right.


- [ ] Referring to the staticmethod case explained above, remove self
- [ ] The inputs "distribution, tonichz, makam" should be carried to here.

-> Simply change the lines to:

@staticmethod
calculate_notes(distribution, tonichz, makam)


カラムじゃなくて新しいテーブルです！


Add documentation


@danielgindi I don' t find a place talking about 'dynamic-data', is this a feature for people's asking 'add data dynamically (an animation is even better)' or just meaning 'realm support'?


#### 注释
函数头注释


update


You should make the file location "path independent." See the comment below:


os.path.join(os.path.dirname(os.path.abspath(__file__)), 'data', 'makam_extended.json')


No need to make these variables mutable. You probably just need to move the expect statements to the catch clause, and make the test fail if validate doesn't throw an exception.


Don't forget to remove all the "self."s before "distribution", "tonichz" and "makam"


It worked.


Thanks @sargken


You should cache the reference to the ToolService.


 固定ではなく、動的に値を受けとるように変更できますでしょうか？
画面からでもコマンドラインからでもどちらでも大丈夫です。


Opps. I mean assignment 2


You don't need the unit here, as the metric unit is defined by the metering config and unrelated to rating.


This should just be currentTool.


define  "c0 = 16.35" the line before and use it instead of "8.17579892 * 2" everywhere.


use c0


Fixed in 38c77bb72c9aec6f9e8ecb06a56032692de42e0c but I'd give it some time for testing in `master` until cherry-picking it to `15.09`, because I have not tested the flag combinations thoroughly.


Needs a space after the cast


Don't need the parameters that are not used.


why in the hell did this commit pop up as a notification... I just realized it's from july


define "performedNotes" before the for loop without the "self."

Remove all self's from this variable.


return without "self." as it should be removed from the class variables as explained above.


This was the solution to the saving bug. I guess "==" does not properly identify whether or not a string is equal to another sometimes.


<img width="832" alt="screen shot 2016-01-17 at 9 41 09 pm" src="https://cloud.githubusercontent.com/assets/46673/12382020/126509d6-bd63-11e5-9186-dd212f7f0d5c.png">


If I change `$0` to `$BASH_SOURCE` here, it resolves #40 for me, but I'm not sure what other implications this might have for other platforms, etc.


请参照现有风格修改文件名，改成communications.py吧


a callback is needed for asynchronous content changes


#### 规范
不要使用`print`改成`Log.Info`


@luigy Anything I got wrong? Any comments?


Here is what I was thinking for an interface

The problem I am having is achieving the functionality that is needed for
this style interface to work. Jow, would you be interested in creating the
interface ? I am certain you can do a much nicer job then I can. Once we
have a interface like this that saves each user as a section then I can
rewrite the entire back-end using uci.

On Sat, Jan 16, 2016 at 12:18 AM, Scott Mercer <hostle19@gmail.com> wrote:

> added all suggestions and removed admin group ...
>
>
> https://github.com/Hostle/luci/commit/ff01098f0aaaa210cd0e864ba039a63af0ba6b5a
>
> https://github.com/Hostle/luci/commit/e6a854ccb08fb24eb8e47cbccbeb07f1846fb301
>
> On Fri, Jan 15, 2016 at 4:42 PM, Scott Mercer <hostle19@gmail.com> wrote:
>
>> I agree, ideally I think there needs to be a users overview page that
>> list all non-root users. Within the users overview there should be a button
>> option to add a new user, and each existing user should have 2 button
>> options, "edit" and "remove". The add and edit button should redirect to
>> page for creating/editing  the user and the delete button  should remove
>> the user from the config and  the system.  It would also be extremely
>> helpful if the model saved each user as a section ... eg config user
>> 'frank", this would allow each users options to be accessed by username ..
>> uci:get(users, username, option).
>>
>>  I will admit, creating the interface is something I struggle with. If
>> you could provide an example of how to redirect to a separate model  to
>> add/edit the user... I would imagine for the edit user you would need to
>> provide the username as an argument  ?  I am not sure how to go about that
>>
>> On Fri, Jan 15, 2016 at 4:04 PM, Jo-Philipp Wich <
>> notifications@github.com> wrote:
>>
>>> This entire config thing should be rewritten to use luci.model.uci
>>>
>>> —
>>> Reply to this email directly or view it on GitHub
>>> <https://github.com/hnyman/luci/commit/a6e862963ef6c1266da55c8b4657922f63dd34b1#commitcomment-15484174>
>>> .
>>>
>>
>>
>


This commit originally was maintained as local divergences, so the lines number of the divergences is not accounted and reported.


#### 注释
加上函数注释


if iOS 7 should avoid supporting Realm, should we also not use all realm related code files under implementation/Realm?


只用了一个方法，没必要全导入。


#### 注释
函数注释


#### 注释

函数注释


You've got a memory leak because one of the three non-null exits from this function allocates memory but the other two don't.

I'd change this to

return strdup(env_creds_path);


if you're not sure about something, you can open a pr instead of committing. i'm just asking for a bit more effort. but if you only want to report bugs instead of fixing them, that's fine too.


请暂时不要用中文。


Fixed


return strdup(system_default_path);


1文字ではなく、2文字出力させることは可能でしょうか？
上記のif文も変えて挑戦してみてもらえますか？


FIXME, remove c style cast.


Fix #5


#### 规范

不要使用print


参数之间用空格


#### 规范

print


规范

print


Why not use https://github.com/matthew-andrews/isomorphic-fetch rather than axios which isn't following a standard?


Hi! I was trying to make Solarized better support Syntastic plugin, but I'm not pro with themes. So I'm just wondering what's the difference between `bg_base02` and `bg_none`? Does it become transparent when background is not specified?

Thanks!


これも動的でおねがいします。


ありがとうございます。動的というのは「$sと$nの値をブラウザ上から入力できるようにする」という理解でよろしいでしょうか?


请保持命名格式统一


I like it


Thanks


This dictionary is semantically meaningless. Make it a dict of dicts such as "B5b5": {'dist2c0': {'value':6986, 'unit':'cent'}, 'traditional_name': "s\u00fcnb\u00fcle"}}, ...


#### 注释

函数注释


请尽量避免使用跨模块全家变量。
另外， 全局变量请使用大写


実務だとこのようなロジックは関数を使用することが多いです。
関数を使用する方法も検討してみてもらえますか？


Understandable but :cry: . Thanks for all your effort!


I don't totally love the magic '53', nor the fact that strlen is called twice, nor the lack of error checking on malloc. Can I propose:

if (home_path != NULL) {
  static char suffix[] = "/.config/gcloud/application_default_credentials.json";
  size_t bytes_needed = strlen(home_path) + sizeof(suffix);
  char *home_config_path = malloc(bytes_needed);
  if (home_config_path == NULL) {
    ERROR("write_gcm: find_application_default_creds_path: malloc failed");
    return NULL;
  }
  int result = snprintf(home_config_path, bytes_needed, "%s%s", home_path, home_config_path);


そうですね。
コマンドラインから受けとる方が楽だと思います。


You have to give proper inline comments


You need to close the <strong> tag


yep a soon as this gets released


блин, не проверить же


char *cred_path = NULL;


Same here, closing tag is missing


Correct@AcadGild.


typo in "fixng"


Hi, is vp10 new features almost in this code now?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11815](https://teamcity.mesosphere.io/viewLog.html?buildId=106721&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:09:03


>  I have funerals and beginging of classess to focus on right now.

Sorry about that.

> If you can rebase on master, and then provide some proof that it compiles and passes tests, I could merge without doing the verification myself.

Just realized that this part of the changes i did wasn't compiled ... since Slicer is build without ANTS, they were not included. It explains the error you got. I will do a clean build enabling more option and report back.


char * cred_path = NULL;


Alas, I forgot about healing burns part. I wonder if it's really necessary, though (besides Mold Breaker Will'o Wisp)


#### 多语言

app 需要支持多语言 “ 返回” 和“相册” 不要写死。使用可以在Localizable.strings中定义


this is not necessary. can you check it?


Continuing to bang my head against this one.
http://www.hep.by/gnu/automake/maintainer_002dmode.html

The problem is because creation timestamps are not preserved via Git, and
so a rebuild is triggered.  A /full/ rebuild using autoreconf with work
file. but the automatic automake-only rebuild will fail if the local
automake version is different than the original maintainer.

Choices:
* Enable AM_MAINTAINER_MODE([enable]), allowing explicit use of
"--disable-maintainer-mode"
to prevent auto-rebuild (note that AM_MAINTAINER_MODE([disable]) is
apparently strongly frowned upon)
* Purge autoconf artifacts (configure, Makefile.in, etc) from the project
completely, so all builds must begin with autoreconf -ifv (@pames tried to
convince me of this path years ago, but I was stubborn)
* Provide a timestamp-updating script to fake out the build

I'm struggling with right answer.  For now, please start your rebuilds with
"autoreconf -ivf" to leverage your local auto* tools.  I will get this
figured out shortly, and then we'll release 1.1.

On Sun, Jan 10, 2016 at 3:48 PM, David Hawes <notifications@github.com>
wrote:

> The errors are during make:
>
> $ make
> CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/bash /home/dhawes/xx/mod_auth_cas/missing aclocal-1.15 -I m4
> /home/dhawes/xx/mod_auth_cas/missing: line 81: aclocal-1.15: command not found
> WARNING: 'aclocal-1.15' is missing on your system.
>          You should only need it if you modified 'acinclude.m4' or
>          'configure.ac' or m4 files included by 'configure.ac'.
>          The 'aclocal' program is part of the GNU Automake package:
>          <http://www.gnu.org/software/automake>
>          It also requires GNU Autoconf, GNU m4 and Perl in order to run:
>          <http://www.gnu.org/software/autoconf>
>          <http://www.gnu.org/software/m4/>
>          <http://www.perl.org/>
> make: *** [aclocal.m4] Error 127
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Jasig/mod_auth_cas/commit/38adbaec9b733bc74efb0c22e324c7b62e74380c#commitcomment-15361468>
> .
>

--
matt@forsetti.com
PGP: E2144AD8


後期は、前期に考えた案を捨て教育について考え直した。
->後期は、前期に考えたアプリ案を捨て教育について考え直した。

「案を捨て」
これも口語っぽいな〜


process() вызвается после регистрации полей формы. Переопределяй __init__


move the definition of cred_path to the top of the method, as I've done, so it can be properly cleaned up.

Then this line becomes

cred_path = find_application_default_creds_path();


What you're seeing in this diff is a different construct than what your line of bash is doing.

From [Effective Go](https://golang.org/doc/effective_go.html#if) (the official style guide):

> Since if and switch accept an initialization statement, it's common to see one used to set up a local variable.
> ```go
if err := file.Chmod(0664); err != nil {
    log.Print(err)
    return err
}
```

If statements allow an optional "simple statement" (`SimpleStmt`) before the predicate expression. From the [Go Specification](https://golang.org/ref/spec#If_statements):
> ```
IfStmt = "if" [ SimpleStmt ";" ] Expression Block [ "else" ( IfStmt | Block ) ] .
```
> ...
> The expression may be preceded by a simple statement, which executes before the expression is evaluated


add sfree(cred_path)


我认为如果这里是任意语言的话，任何打开文件类型都会完整载入插件，有点不合适，这里如果是适当语言不会完整载入的。


这里是true会不会很慢。。


5420-OSCM-Docs (mitchute) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2088 of 2088 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I've tried this twice and I don't see how I've done anything to change the lack of newline at the end of the file...


Le second bloc de code utilise ...
Mettre éventuellement rev-parse entre guillemets « ».


It's our policy to exactly pin Python packages and use `--no-site-packages` so that other deployments can (as close as possible) reproduce the dependencies. Since numpy at 1.9.1 is Python 3 compatible anyway and going by the commit message, I guess that you might be using a virtualenv created with `--system-site-packages` and this change is to allow the Debian-packaged numpy to be used?

The only code that uses numpy is the python bindings for OpenCV, which are only used by the face detection command called from crontab, `moderation_queue_detect_faces_in_queued_images`. To make this work (since Python's  OpenCV won't install in a virtualenv, sigh) we have to do [a horrid hack](https://github.com/mysociety/yournextrepresentative/blob/master/bin/pre-deploy#L37-L42) anyway, so if this dependency is causing a problem I'd suggest removing it entirely from requirements.txt (which would speed up the test runs on Travis too!) and switch its installation to `bin/pre-deploy`.


This section's UI is a little different now. Needs to be updated.


well the script that @HEGladios made for us was that it deletes the entries of the dungeon, then takes everything from TC, add it with incremental guid, so no overwriting should be possible, not even for the people that have spawns things on their own..

it deletes paths made by OC and makes new one based on the TC ones...

a short output on the script looks like this.

```sql

-- TC creature spawns on map 543: 101
-- OC creature spawns on map 543: 64
-- TC formations on map 543: 12
-- OC formations on map 543: 3

DELETE FROM `waypoint_data` WHERE `id` = 620120;
DELETE FROM `creature_addon` WHERE `guid` = 62012;
DELETE FROM `waypoint_data` WHERE `id` = 1411;
DELETE FROM `creature_addon` WHERE `guid` = 62013;
DELETE FROM `creature_addon` WHERE `guid` = 62015;
DELETE FROM `creature_addon` WHERE `guid` = 62020;
DELETE FROM `creature_addon` WHERE `guid` = 62064;
DELETE FROM `waypoint_data` WHERE `id` = 1412;
DELETE FROM `creature_addon` WHERE `guid` = 62065;
DELETE FROM `waypoint_data` WHERE `id` = 1413;
DELETE FROM `creature_addon` WHERE `guid` = 62066;
DELETE FROM `waypoint_data` WHERE `id` = 1414;
DELETE FROM `creature_addon` WHERE `guid` = 62083;
DELETE FROM `waypoint_data` WHERE `id` = 1415;
DELETE FROM `creature_addon` WHERE `guid` = 62088;
DELETE FROM `waypoint_data` WHERE `id` = 1416;
DELETE FROM `creature_addon` WHERE `guid` = 62089;
DELETE FROM `waypoint_data` WHERE `id` = 1817;
DELETE FROM `creature_addon` WHERE `guid` = 86360;
DELETE FROM `creature` WHERE `map` = 543;

INSERT INTO `creature` (`id`, `map`, `spawnMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`) VALUES
(17271, 543, 3, 0, 1, -1259.32, 1597.83, 92.1066, 5.49779, 7200, 0, 0, 1, 0, 0);

SET @CGUID := (SELECT `guid` FROM `creature` WHERE `id` = 17271 ORDER BY `guid` DESC LIMIT 1);

INSERT INTO `creature` (`id`, `map`, `spawnMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`) VALUES
(17271, 543, 3, 0, 1, -1244.97, 1646.42, 67.7663, 2.51327, 7200, 0, 0, 1, 0, 0);

SET @CGUID := (SELECT `guid` FROM `creature` WHERE `id` = 17271 ORDER BY `guid` DESC LIMIT 1);

INSERT INTO `creature` (`id`, `map`, `spawnMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`) VALUES
(17271, 543, 3, 0, 1, -1242.73, 1616.46, 68.5907, 3.35103, 7200, 0, 0, 1, 0, 0);

SET @CGUID := (SELECT `guid` FROM `creature` WHERE `id` = 17271 ORDER BY `guid` DESC LIMIT 1);

INSERT INTO `creature` (`id`, `map`, `spawnMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`) VALUES
(17271, 543, 3, 0, 1, -1199.85, 1440.53, 68.5998, 0.715585, 7200, 0, 0, 1, 0, 0);

SET @CGUID := (SELECT `guid` FROM `creature` WHERE `id` = 17271 ORDER BY `guid` DESC LIMIT 1);

INSERT INTO `creature` (`id`, `map`, `spawnMask`, `modelid`, `equipment_id`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `currentwaypoint`, `curhealth`, `curmana`, `MovementType`) VALUES
(17271, 543, 3, 0, 1, -1184.12, 1485.16, 68.5488, 6.02139, 7200, 0, 0, 1, 0, 0);

```


## Variable "lifetime" and "population" Array

Variable `lifetime`:
In my opinion, we don't need the variable `lifetime`. We could just simply delete every krabll, whose input `alive` is false. Afterwards, we could simply add an `if`-statement, which checks, if less than 10 krablls are alive.

`population` array:
We should rather use a list instead of an array for our `population`, so that we are able to remove specific elements.


just splitted :)


Btw. In the case you wonder about the position of the front seats: in Real Life they are moveable, and I thought to simulate this as well later affecting view position and weight position of the pilot.


Bonsoir,

Merci pour la PR !

Par contre je n'en ai pas bien compris l'objectif ?

Kevin.


@tvdeyen yes, it worked when switched.
@Sinetheta solid logic, any ideas on why it's overriding them for?
Can anyone confirm that it is working for them?


5420-OSCM-Docs (mitchute) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


unack, can you rather break after the comma? I think that'd look more readabl


Is this the best way to accomplish this?


@ohine do you know what problem this was trying to fix (from your dx1next branch)?  is it still needed?


`git_object` est en fait un type « parent » ... on peut forcer la conversion de type en toute sécurité.


could you apply the disable-everything-if-published to single results and make them accessible as well?


In my opinion, we don't need the variable `lifetime`. We could just simply delete every krabll, whose input `alive` is false. Afterwards, we could simply add an `if`-statement, which checks, if less than 10 krablls are alive. This should be a little bit more efficient.

Please visit #5 for more information.


Writerk?


Uzupelnilem stringi jezyka kazahskiego


hm, thinking about it while actually seeing the code I guess we'd rather just want to use `"filename"` here instead of `STR_PROJECT_WIDE`, it's a test string only and this way you can also get rid of the `.format` below


to make filterPodsByNameSpaces() efficient you can make the change here correspondingly
```go
	var names sets.String
	if podAffinityTerm.Namespaces == nil {
		names.Insert(pod.Namespace)
	} else if len(podAffinityTerm.Namespaces) != 0 {
		names.Insert(podAffinityTerm.Namespaces...)
	}
	allpods := filterPodsByNameSpaces(names, existingPods)
```


Interesting. I cherry picked this from a live instance myself. Your theory sounds right. The commit that I picked was authored by @migurski. Should I go back and correct it? I feel fine rewriting history.

It definitely needs some tests. I wrote some integration tests that wrap the whole export deal. I posted a [pull request](https://github.com/codeforamerica/cityvoice/pull/247). I'd love your feedback if you have a minute. It's a decent first go but it could be backfilled with some unit tests too.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11868](https://teamcity.mesosphere.io/viewLog.html?buildId=107284&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:03:52


@ohine was this for the 51 degrees removal, or something else?  is it still needed?


hey, about the commit message, these are our guidelines: http://coala.readthedocs.org/en/latest/Getting_Involved/Writing_Good_Commits/#how-to-write-good-commit-messages

Could you use the *full URL* for the bug and place the `Fixes` note without a colon into an own line like in the example in the documentation?


а почему это удалено?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11869](https://teamcity.mesosphere.io/viewLog.html?buildId=107293&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:11


and the package sets.String in is `"k8s.io/kubernetes/pkg/util/sets"`


il est donc permis de le convertir en un pointeur de `git_commit`.


Good call! I kept it a big vaguer than what you suggested, but I made the
change in my most recent push.

On Mon, Jan 18, 2016 at 11:59 AM, Andrew Downing <notifications@github.com>
wrote:

> You should mention going File > Make a copy and filling out the [HIGH
> SCHOOL] and [NEXT MEETING DAY] fields on slides 4 and 10.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zachlatta/hackclub/commit/b25db2e41dee941602777a20a63408a4b658f465#commitcomment-15515688>
> .
>

--
Zach Latta
https://zachlatta.com <http://zachlatta.com>


factored out the wrapping bit here (commenting so you can see the diff for this change after I squash)


@ohine do you know what this is supposed to fix?  is it important?


working here


You shouldn't put a html page in another folder, it's morally wrong.


:ok_hand: 51d193d63eee4675b891d53c91094ed176295e72


It's a lot easier to catch irregularities if you live in ordered world.


sure, tks!


add semicolons + ui-bootstrap dependency


MY FIRST COMMENT, HI MAN


CBECC (kbenne) - i386-Windows-7-VisualStudio-12: OK (2323 of 2349 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.89%25-yellow.svg)


It's probably because it's generically parsing the request and matching it against the JSON-RPC API definition which consists of multiple levels of JSON objects encapsulated within each other with references to other nested types and so on.


set-global (ktm) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Is this in preparation of makingthe gradle plugin incremental? (One can hope, right?)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1192](http://teamcity.monogame.net/viewLog.html?buildId=13743&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:28:52


Don't talk about efficiency while using Java!


please do this also for state evaluation finished and fix the message, something like `You are editing a course, for which the evaluation already finished. Please be careful to not destroy any results.`


This gets to server select but hangs on black screen when hitting play in normal client.
Nothing in Unity client.


Thanks!


Can you clarify the purpose of the changes and SimpleCov?


@tvdeyen switching worked, but switching back is working now too. Probably some sort of user error on my part.
@Sinetheta solid logic, nicely done


the return value order, should be (bool, error), to make it acts the same with other functions.


Whats missing that is preventing it from being 2.13?


Um... the screenshot includes a skype call. :)


`RandomAccessibleInterval`


Probably should not call it foo :)


remove this


m_ codestyle


you can just iterate over fields.values


La dernière ligne utilise un type


@bdukes Yes, this was to reduce exceptions when 51 degrees wasn't available (assembly removed from the bin directory)


AddNetAreaColumnToEnvelopeSummary (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1509 of 1509 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.7%25-green.svg)


s/or  podAffinity/or podAffinity/
2 whitespaces here