I'd like to make the command line arguments standard with the other example Python scripts included in cbapi. We have a simple helper module that handles a lot of this for you, see for example (I stole this from https://github.com/carbonblack/cbapi/blob/master/client_apis/python/example/process_search.py)

```
from cbapi.util.cli_helpers import main_helper

def main(cb, args):
    # here, cb will be populated with the cbapi instance associated with the
    #  Cb URL and API token specified on the command line, and
    #  args will contain the optional args specified by this script (see below)
    pass

if __name__ == "__main__":
    required_arg = ("-q", "--query", "store", None, "query", "Process search query")
    main_helper("Generic process search", main, custom_required=[required_arg])
```

This generates the following command line syntax:

```
Usage: process_search.py [options]

Generic process search

Options:
  -h, --help            show this help message and exit
  -c SERVER_URL, --cburl=SERVER_URL
                        CB server's URL.  e.g., http://127.0.0.1
  -a TOKEN, --apitoken=TOKEN
                        API Token for Carbon Black server
  -q QUERY, --query=QUERY
                        Process search query
  -n, --no-ssl-verify   Do not verify server SSL certificate.
```


Tu peux faire une seule ligne


Hmm ok, now this is causing the iOS app to crash with a `System.NullReferenceException` in Main.cs.


I did try with `.write` but I did not wrap the value in a `reinterpret_cast`. Thank you for this, I'm going to try this when I get home!


It doesn't change the visibility. Even if I used struct I have to put the `public:` here. I'd like to use struct only when it's a real POD.


Do all the tests still pass?


@xavierleune Can you explain this to me? :/


I'd like to keep whitespace/special chars out of the "keys" for compatibility with languages that may interpret JSON as a native struct; what about "SearchString"?


You don't need the brackets here; just `instanceID, destinationCIDR := getInstanceAndCidr(r)`.

Stylistically I don't think getInstanceAndCidr is buying you a lot, so I would probably eliminate the function.


Yay. xD.


minor issue: `seach_string` is misspelled (`search_string`)


Unless static typing (e.g. flow) becomes more common, this is really the only way to properly validate input. I think it is perfectly reasonable for a library like a linter.


Yass!


There's no "implicit this pointer" in go, so you need to do `a.getInstancesByIds`


Yay


Not sure what the convention is (if there is one), but as a matter of style, I prefer omitting the extension:

``` js
var thing = require('./some/thing');
```

Just noting you can do that if you prefer.


> That's because you don't have the model declaration of the type function in the model loader, right?

Yes, right. But the thing is that type constructors are a kind of type alias and while we never needed to emit anything for a local type alias, for a local type constructor we still need to support runtime type testing using `is`. Still, I didn't really want to go emitting a class just for that, hence why `toType()` has to go creating its own model. Then afterwards I needed to support type constructors in the `TypeParser`, and both of these places suffer the problem of needing to know the containing scope for the models they go creating. So maybe the right solution is just to go emitting a `.class` afterall, but as you say that requires us to name them etc.


What do you need this for? Can't you avoid factors with `stringsAsFactors = FALSE` in the appropriate places? Otherwise you simplify this function as
```r
df[] <- lapply(df, function(col) {
  if (is.factor(col)) as.character(col) else col
})
```


Hi @martinbomio I think the problem comes when those who call didnt webcam


`b.ref == 0` could really happen? Maybe assert on it not happening?


Avoid object types in variable names like you have in `@user_guess_array`. You could use `@user_guess`.


@defeo @VivianePons @vdelecroix @ClementPernet @pdehaye @stevelinton @JohnCremona @fangohr @dimpase @wdecker @fcayre @marcinofulus @lawrennd @martinal

Please fill this in before the end of January if you can.
Just a small paragraph per partner will do, it does not need to be exhaustive for the 1st version

There is a little example at the UPSud section.

I'm free to answer your questions if any!


@nthiery Thanks for showing me LateX language today Nicolas ;)


@benoitc I have described what I have figured out so far here:
https://github.com/Netflix/lemur/issues/204

For me this throws an error deep down in argparse.py still verifying if its a side effect of flask-script. I'm not positive it's a problem with gunicorn, but is an interesting side effect of this change.


Something feels off about this. Why have it if you're just redirecting? One reason would be backwards-compatibility, if clients were already using `/form-handler`, but that's not a problem here so I'm curious.


Not entirely sure an interlocked exchange is needed here; should probably look into this more.


Should be `with_log(repo, params, opts ++ default_opts)` as log can be set in default and not opts.


in the original algorithm, the link was collected after the recipe is used to split "submit" and collect link
I'm not a big fan of returning only a link to the content and not the recipe


I'm not particularly a texture artist.  That was more or less my best shot.


I mean it can be set in both!


typo


mergad


Got it. I'll take a quick stab at drafting up a more generic apology for our out of pocket database.


Read me.


Same here


I'd prefer the output file to be "proper" JSON; what about a structure similar to the following:

```
{
  "Author": "fill in",
  "ExportDate": "2015-01-06T10:00:00Z",
  "Description": "Watchlists" // do we want to have a "description" associated with the export itself?
  "Watchlists": [
    // this is an array of the "wl" dictionaries you've created above
  ]
}
```

This way we can natively import this into anything that understands JSON.


Should be `(r *ec2.Route)`.

Also, named return parameters are typically not used, in favor of explicit returns.  So
```
func getInstanceAndCIDR(r *ec2.Route) (string, string) {
instanceID := ...
destinationCIDR := ...
return instanceID, destinationCIDR
}
```


why you're avoiding the 304 error ?


Should this be a pointer instead (and I2CDevice hold a pointer)? I'm not sure it's "fine" to grab the address of a reference and delete it :-\


FYI: conventionally, log output keeps to one line if possible, especially the date, e.g. something like:

```
[2016-01-01-blahblahb]: /profile/lombax
[2016-01-01-blahblahb]: /profile/blaenk
```


progress bar原来的写法太复杂


Thanks for the quick reply. You're right about static typing, but what bothers me is the fact that all those approaches only help while developing yourself, but as you compile your code there is no validation injected which means that even if I would use flow to create this linter, users could still pass wrong input without noticing.
Still I am just not satisfied with all those input validations all the time... but perhaps as you mentioned it is the only way to keep a good DX right now.


For sure ! It  has been removed here : https://github.com/afup/web/commit/9c52d366754518cd04a1496df1b434888aa32a85

I used it to prevent PHP to process the posted files and to preserve the php://input stream (in case of the CFP called with curl from event.afup.org). But that was a miserable fail so I changed my mind.


it should go as a template in external repository


Side question, would a `Func.Simplifier` ever operate on a `LogicalPlan` other then `InvokeF`?


OK I've added my comments into the watchlist_exporter diff; of course the same applies to watchlist_importer as well.

Thanks!


The name of this field is confusing, since it doesn't reflect what the map contains. It'd be more accurate if it were called `handleResolvers` or, if you want to be more specific, `handleResolversByName`.


ok you change the retrieval on api side


crap, true... I'm dumb today :P
it has to be

`structureSize alignedTo:  OSPlatform current ffiAlignment`

I will commit a patch


To get this to compile, you need to do append `&instanceID`, because it is `[]*string` not `[]string`.

As a style point, I think having `[]string` would be easier (and mapping it inside of `getInstanceByIDs` - we have a helper function `stringPointerArray`


Hi, thanks for merging!
Unfortunately I have found three issues (one important and two minors):

1.) the airspeed_ets.c still gives this error when target is "sim":
modules/sensors/airspeed_ets.c:87:19: fatal error: sdLog.h: No such file or directory
 #include "sdLog.h"
                   ^
compilation terminated.

2.) The header in the first SDLOG write command /respectively for all sensors) includes a "H(usec)" which is actually not written in the following data write commands (don't know what it should mean, should be deleted as far as I can see).

3.) Also in the header: The unit of "lon", "lat" and "course" is degree not rad and there is a typo for "gpsspeed" which might also be named "gspeed".

I have no idea how to add the search path for airspeed_etc.c in "sim" target (for the others it works). If you have an idea I can try it for a new pull request.


It's a reference because it would be an error to call it with nullptr.


Seconding that it be mentioned in the upgrade guide the removal of ArtisanServiceProvider. We also had to remove ContainerServiceProvider from our app.php, but that gave us a friendly error and we were easily able to find it.


articolo sul test nucleare della Korea del Nord


hmmm...I would expect a slight speed up, wouldn't you?  Maybe the master is highly optimized.
I guess we will see what Fishtest have to say...


You've got `capitalize`... so does that mean the gem relies on `activesupport` already?

You should just be able to call `arg.to_s.camelize`!

Why not use that?


Not sure the error message is right. You could have no handlers in the notebook but still have /_api/source enabled right? And soon swagger?


Actually, generally the schemes we've used for identifiers have looked less like human-readable strings and more like IDs - perhaps just make the scheme `cedula-juridica` instead?


+1 Thanks @mbarkley


Needs to be `instances, err := s.getInstancesByIds(instanceIds)`  You have to assign all the return values.  You could do `instances, _ := s.getInstancesByIds...` if you didn't care about one of the return values, but you should always check errors in go :-)


@Shauren can you backport this to 3.3.5 ? We should have the same DB structure when possible


This body of this method could be:

```
party.identifiers.get_or_create({'identifier': id, 'scheme': u"Cédula Jurídica"})
```

... which I think should have the same semantics. However, is that the behaviour that you want, or should it update any existing identifier of the scheme? e.g. with

```
party.identifiers.update_or_create(scheme=u"Cédula Jurídica", defaults={'identifier': id})
```


Hmmm ... really I've met some problem here and fixed it, but I don't remember what particular ...


:tada:

Jacques Bodin-Hullin

--
Monsieur Biz <http://monsieurbiz.com>
@jacquesbh <https://twitter.com/jacquesbh>
+33 (0)6 75 54 11 97
GPG : https://keybase.io/jacquesbh

On Wed, Jan 6, 2016 at 6:35 PM, Xavier Leune <notifications@github.com>
wrote:

> For sure ! It has been removed here : 9c52d36
> <https://github.com/afup/web/commit/9c52d366754518cd04a1496df1b434888aa32a85>
>
> I used it to prevent PHP to process the posted files and to preserve the
> php://input stream (in case of the CFP called with curl from
> event.afup.org). But that was a miserable fail so I changed my mind.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/afup/web/commit/71279fe53a7295d130a4ad4fb85b41fd2c1a4df3#commitcomment-15295988>
> .
>


Idea: add a destructor to `Linux::I2CDeviceManager` that warns if there are any valid bus (with references).


can this be put back inside a pending block rather than commented as a todo?


I imagine you intended to make things more consistent (others are lower-case), but `promise` is actually a class/type, not a typical module object like say `express` is below. Types by convention are capitalized: `Promise`. Personally I import it as `Bluebird` because it would otherwise clash with es6's built-in `Promise` type.

``` js
var Promise = require('bluebird'); // or
var Bluebird = require('bluebird');
```


no need to comment these out, if they've been implemented you can just remove the line, would rather not have the dead code :smile_cat:


ack


Just curious, is this a manually-updated changelog, or do you have a script managing this?


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 120](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=628&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:15


I fixed a problem concerning this commit, if you want to have a look:
https://github.com/Tkkg1994/Nova-Kernel/commit/b0455e0dbb0da533ea2edc7f0096ce687324cd01


Good thinking, good intention, but this is unnecessary. The only reason a `catch` would run is because a promise was previously `reject`ed, so it's superfluous to only re-`reject` it. Simply omit this `catch` block and it'll have the same effect, without doing extra work.


We should check here in case the instance is not found.  I think it suffices to check `instance == nil` here, but you can also do `instance, found := instances[instanceID]` and then check `!found`. In this case it doesn't make a big difference.


Lots of little go-nnoyances, but definitely on the right track!


would this work considering most of the objects are static and we don't actually delete them... ? We just exit... if the destructors are called in a wrong order the warning would keep appearing.


Ah, yeah. Thanks for the heads up.


Super – thanks for the clarification.


原本的progress bar太复杂


That will be fine with me!


From my understanding it will be just the dynamics that will be wrong, but the steady state temperature should be correct? Since the current model has no dynamics at all I expect that the error will be on the same order of magnitude as what we have now.


You do not need to explicitly call return if you want to return the last statement in a method. The last statement is returned by default.


Also, I need to rename the DHL warehouse to ANA warehouse.


``SALT_ARGV`` only visible with ``-ltrace``


![how it looks](https://i.imgur.com/7A0utZA.png)


@tkelman RFC.


You do not need use `( )` when invoking a method that does not return a value. You can have something like this `BuildRecord::Sname.new.set_new_record @player_hash`


Michael, it's a leftover of an experiment. I'll remove it. As it's an experimental branch glitches like this would sneak in sometimes.


Yes that is intended. We mainly want to defer the write connection.

On Wed, Jan 6, 2016 at 11:02 AM, stevenmyhre <notifications@github.com>
wrote:

> This doesn't look like it defers the read connection (connects every time)
> - is that intended?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/laravel/framework/commit/f7062509d7e43e3d15d74db102008cf63ed90f89#commitcomment-15295166>
> .
>


Good catch! I have corrected it now.


Should be able to use the raw `organization` here, the same way division is done now. This hadn't worked before because of some weirdness related to how legacy model accessors worked and the messy custom foreign keys on all the models.


This is needed for python 2.7 installs. Could you add these to the versioneer generated cmdclass?


can you remove the print?


lets wait for deciding this, so you can work on a clean repo.
@mherweg, the master branch is ready to be switched now. Any objections?


If you don't care about the module in sim, you can just add `target="ap"` as an attribute of the `makefile` section of the module's xml file. This will just automatically unload it.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 121](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=629&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


What does this do?


@hellatan I'll try to do the same for `@pointerevents`. I would argue that we don't need to alias `@scss` and `@copy`. The `context` of webpack config is `dibs` directory where these files are located. Why do these need to be aliased in the first place? It seems we are doing it to avoid writing the full relative path:

In the example you gave @antialias:
```
require('@scss/bomt/subviews/_bomt-invoice.scss');

```
would become (if we got rid of `@scss` alias):
```
require('../../../scss/bomt/subviews/_bomt-invoice.scss')
```

Alias seems like overkill in that scenario. Perhaps there are cases where the path would be longer, but isn't that just a consequence of relative paths that we have to accept? Personally, I think these alias aren't necessary.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 121](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=629&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:15


maybe it will be better to call it pricelist_item_vals instead of pricelist_item_ids as it not a list of ids


I think that the check for whether the party already exists based should be based on the `party_id` rather than the name.


111101900_MSHeatPump (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1465 of 1465 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.62%25-green.svg)


Good call. I'll sort and resubmit.


That's a good point. On the API side of things, we maintain a few different conjugations of these keywords which will provide a little more flexibility here. My aim here was to just generate a list of our most successful keywords for a v1. If these are successful, we can always improve either the DuckDuckGo IA or the thumbtack API to improve keyword matches. How does that sound?


Same as the others, could you maybe mark these as pending rather than commenting them out? I don't know that this is something that we'll be implementing as part of translatable anymore, but I'd rather the specs be active and marked pending so that we know we still need to address them than commenting out the code in a way we might forget about it.


ack


so bad


LogFile class*


Whoa, that method name confused the heck out of me for a moment - I missed that it didn't have a trailing 's' and was like 'how the heck does it ever actually collect anything??'

Now I get how it works, but perhaps it could be renamed something like 'collectElementIfMatching'?

(We can chat about how to do the git surgery to propagate that through if you don't already have a handle on that - please do feel free to ping me!)


Solve the issue with negative authenticators


aw. you caught me! i am ashamed


Can ember-lodash be removed from the blueprint then?

https://github.com/samselikoff/ember-cli-mirage/blob/master/blueprints/ember-cli-mirage/index.js#L56


Any chance you can be bitten by a wrong match due to a prefix string. In the case v is a proper prefix of `abs_str_device` (you compare up to v size, but if you compared more, the match would fail). Or this case wouldn't happen due to the nature of data we are feeding?


First I don't consider this being an ideal scenario for inlining. The wrappers are not really that small (over 20 instructions), out of which we would save maybe 5 instructions or so by inlining. But more important, the wrappers do nothing with the arguments which should be the first motivation behind inlining. They just do something unrelated after which they pass on the arguments to the native function (so there is no forwarding of values, branch elimination etc.).

Secondly, I've run some microbenchmarks on arm. So inlining makes fconv 100% faster, fmod 100% faster, idiv 60% faster, iconv 50% faster while making lmul 66% slower, lshl/lshr 30% slower. I don't see an impressive improvement, having also regressions on very common ops, all with a significant code size impact.

Thirdly, looking into the reasons for the inlining performance improvements on these ops, I've noticed that it doesn't come from the act of inlining itself, but from not setting the thread local LMF when doing the managed to native transition, since the save_lmf flag of the method is discarded at inline time (the one for the parent method counts). If I were to cheat like this and also not set save_lmf for the emulation wrappers, the performance advantage of inlining is reduced by 75% to 90%, making inlining mostly useless performance  wise. fmod was the only opcode where I noticed an inlining improvement and it's probably not strictly related to inlining.


Oui, j'ai fait une recherche et htmlproofer n'a rien remonté non plus, Wordpress créeait plusieurs versions de vignettes lors de l'upload.


Manually updated.


Damn, you're right. I'll fix this directly on the master later on.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 183](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=630&buildTypeId=XbimEssentials_XbimEssentials) is now running


Delete in next change.


This commit causes a regression when both `extends` and multiple yaml files extend a service (example below). Was it officially supported?

docker-compose.yml:
```
app:
  build: .
  dockerfile: ./compose/app/Dockerfile
  command: /bin/true

web:
  extends:
    service: app
```

docker-compose.override.yml:
```
web:
  volumes:
   - .:/app
```


I left a comment


I think was needed for backuptool or something along those lines once upon a time


implement function to _transfer_ data. (typo on commit title)


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 183](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=630&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:30


@ricardokdz your website is 404 at now, can replace this for github or linkedin url?


One reasoning to defer the read connection also... I have noticed that when just running a simple ```php artisan``` command (e.g. ```php artisan route:list```) it still attempts to connect to the database.  This ends up resulting in very confusing error messages contextually, and an unneeded database connection.


Despite the standard package at https://projects.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/shairport-sync restricts to the supported Arch architectures it is still usable on any other platform.

On ARM one should build with `makepkg -A` where `-A` flag means ignore `arch=()` array and build the package. The people on ARM suppose to use the flag for packages in [community].

So my suggestion is to use the default package https://projects.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/shairport-sync for all platforms and add `makepkg -A` flag if needed.


why?


or _do_ like Archlinux? (missing verb)


I like this refactor in general, but I'm not sure about putting this temporary state on the AuditRule. Can you convince me? :smile:


Actually...it looks like this isn't available on hex.pm yet:

https://hex.pm/packages/excoveralls

Are you planning to cut a release today?


No packages should ever assume aliases exist.


Close #4


you could easily create an array containing all the input commands as items and refactor the the method like this.
```
def input_command?(guess)
  commands = [:cheat, :exit, :h, :c, :q, :quit]
  return true if commands.include? guess.to_sym
end
```


I see that you already accepted the pull request, but yes, I did choose setTimeout on purpose as it tends to be a more accepted practice than setInterval and will still update more than once. It will keep running till the end of time and because it always runs, the functionality survives when the user navigates away from the budget page and back.

I agree with another note of yours elsewhere that we need to find a way to check for updates to the app without continuously polling the DOM like this, but at least this seems to work for now. Cheers.


It's not bad, I just don't like the contrast.
On Wed, Jan 6, 2016 at 12:33 PM Crowe <notifications@github.com> wrote:

> I'm not particularly a texture artist. That was more or less my best shot.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/L0neKitsune/Botanical-Addons/commit/c430dea7976317115a0dbf20d230d6e0acb4a133#commitcomment-15295937>
> .
>


Thanks. Let me try that out...


you don't need `run`, you don't need `--debug` you need `--amazonec2-subnet-id` or the associated env variable.


fuck no you can't. Because `board` will be modified and it's not const. Then why pass in by ref? Ask leetcode motherfuckers.


now that we have extract text working, these files can probably start to be moved around to be more component-based instead. That would be one way to get around the relative paths.


use 'only_if_env' here


Either way it works. I prefer throwing exception ahahaha ni da wo ya


@vargaz  I understand why we used to assert. The problem is that, as you can see in the last commit of this PR, I need to get from an op_imm to its counterpart, without knowing if the opcode is an op_imm in the first place. Rather than having duplicated switch-cases, I chose to do this instead.


Good to know, thanks.


Couple things:

1. What is `setLocation`?
2. Was this deployed to the FTP?
3. Line 820


random number, and it means fuck you motherfucker.


Q: does the `ioctl()` we call later promise to not change the buf for this msg?


What is happening here?
These changes where already committed in 16afc3fb36a21e14d25185586403e5409dfa7034 and a18fbc7caf49441d124c4f816f3042b7ffaba465.


google told me to use memset. Fuck google.


Still this module is used by some in sim, so IMHO it would be better to only include the sdlog stuff `#ifndef SITL`


We should probably change the name of the `slug` field on `OrganizationExtra` and `PostExtra` classes to make this less confusing, but they're really the canonical ID rather than a slug - links to the party pages are normally generated with an ignored slug at the end, so the code here will result in some URLs like `/election/.../party/accesibilidad-sin-exclusion-pase/accesibilidad-sin-exclusion-pase`. I think the `OrganizationExtra.slug` should be `party_id` (or slugified party name where there is no Cédula Jurídica) so, where there is a proper ID, it'll be `/election/.../party/3-110-420985/accesibilidad-sin-exclusion-pase`.

(I think it would still be a good idea to add an `Identifier` with any Cédula Jurídica, even after switching as I suggested, incidentally.)


@lilianammmatos i wouldn't make `@pointerevents` a public npm package though. you should add a .npmrc file with the registry set properly. I would probably call it `dibs-pointerevents` as well since we don't want to have a potential conflict on the public registry.


added missing closing tr element


No failure sending/reading actually happened, should this be `return true` or is it more useful using false?


Is `sha` in scope here?


Adding repositories is not working from composer-local.json.
Example :

    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/evach-vf/monolog"
        }
    ],

I believe it's related to the array_merge adding my new repository with a key of "0".
var_dump of $repositories

    array(2) {
      'packagist' =>
      array(3) {
        'type' =>
        string(8) "composer"
        'url' =>
        string(22) "https?://packagist.org"
        'allow_ssl_downgrade' =>
        bool(true)
      }
      [0] =>
      array(2) {
        'type' =>
        string(3) "vcs"
        'url' =>
        string(35) "https://github.com/evach-vf/monolog"
      }
    }

Basically only `packagist` repo is being picked up and if I add the repo in `composer.json` instead, the array items are inversed and everything works properly.


Note that the JRE downloaded is different depending on platform, Mac OS X's launcher ships with 1.8_60.


Makes sense! Should I encapsulate the second div in a component and use this kind of syntax?

{ this.props.something ? <SomeComponent /> : null }


This doesn't make a lot of sense. But, it works.


cdot – there will be no duplication as Error has to go.

Jlevens – pure eval-based exception handling has worse readability. Don't like it very much. As to the return – yes, it complicates life a bit. But this is a feature of eval. return gets you out of the enclosing eval {} scope.


I didn't think about using `String.new` I will give it a shot.


Well, `if cluster_name.nil? || cluster_name.empty?` looks more readable to me...


wondering why this was not correlated with https://github.com/lattice/quda/commit/a9e0a435416d4815311531b7f4a866503978d268


Hmpf. I'll include a special Windows warning then.


It looks as if some of the party names have initialisms in brackets at the end (although sometimes things in brackets that aren't initialisms?) - what I did for Burkina Faso was to add the abbreviation as an `other_name` of the `Organization`, which is what people suggested when I [asked about this](https://github.com/popolo-project/popolo-spec/issues/113).


Hello Scott,

very much appreciated, but please (!!) make this configurable!. Please see this ticket
https://github.com/Zizaco/entrust/issues/470

Thanks!


I think this doesn't belong here ("update webpack configuration")

Most of all, you'd need a much newer revenge to write queries this way (and rewrites of other parts of the app). I'd consider this a separate issue and remove from this PR


Why bother adding a heading?


Thanks !
About quoting variables in [[  .... ]]
You 've corrected the line
```
if [[ -n "$alloptions" ]]; then
```
by adding quotes around the variable.
Did you ever had any problems because the variables were not quoted in a [[ .... ]] (double bracket) ?
I have stopped quoting anything as soon as I went from single brackets [ ....  ]  to double brackets [[ ...]].
AFAIK, quoting is no longer needed for [[ .... ]].


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10826](https://teamcity.mesosphere.io/viewLog.html?buildId=100876&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:18


SHhhhh... just do it.


Ah that's how you did it lol, I tried casting \0 to a u8 for some reason, but got some weird unescape error from Ark (which maybe we should look at).


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 114](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=631&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


@stulees Is the double assignment to `url` intentional?


This is a bit of crappy code. It would be in scope because `failures` would only exist when `sha` gets assigned. It would only assign the last one it finds though.


This too is weird.


I'm not even sure if this branch would ever make it into the master as-is even if the whole discussion on the topic would settle down The Plan. But even in this case it would serve as a good base and a proof of concept.


I would certainly be for restoring them. I will check whether they (seem to) work.


no


Rather than asking interactively about whether to create the party sets, maybe it would be better to create all 81 at the beginning? (The canton names can be sourced from http://international.mapit.mysociety.org/areas/CRCANTON now.)


finish meaning finish documenting, I still haven't written it


This should be `final` instead of `volatile`.


I understand removing things that aren't used and I understand the benefits of duck typing, as in we don't quite care if what we are passing in is a notification, however the 99% case is folks will want to pass in a notification. So if you want to remove the `:as` then I ask that you add a docstring saying that this fn expects a notification. Thoughts?


Oh, I see you've fixed this in a subsequent commit.


Unnecessary empty line.


Ah, with reference to my earlier comment, I guess this means they're not useful abbreviations.


Okay, cool. Yeah I think I'll probably push it to NPM as well, that way it gets pulled up automatically. Do you know if there are plans for ADV to host a bower repo at some point?


seems there's a consistent problem with this still, which I didn't think to check before (kind of edge case).

repro: enter combat with 2 vrykul and kill them next to each other. Use the banner on the first one = success. Use the banner on the 2nd one = failed.


Why this? I don't see any closures below?


Raté! T'as tapé Dcotrine et pas Doctrine dans tout le doc :)


That makes sense :)


Sure, why not. Docstrings are always good.

But to be clear, I added the `:as` in the first place in my first commit in here, but it was never used. So I'm not so much removing it as deciding not to add it in the first place.

And this fn doesn't really expect / care what you call the thing you pass it, so long as it's a map that has these 2 keys in it.

But I'll add a docstring and see what you think. :)


Please add an empty line after this.


No, not yet. You can add an issue for that.


lol was testing some git command xD


@justinsb Thank you for all the comments! I'll start going down the list right away


Thanks ;)


No reason in particular. Doesn't hurt.


You don't need event submission here.


111101900_MSHeatPump (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (2001 of 2001 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


this commit has broken the support for Eigen2 because the new file ```signature_of_eigen3_matrix_library``` is not available in the eigen2 tarball


This is also not needed.


@phenaproxima
The following assertion (Then I should see "media library") fails about 10% of the time when using selenium and about 80% of the time when using phantom. I can't find any pattern.

Is it possible that the assertion is happening before the modal is loaded some of the time causing the intermittent failures? I'm not familiar enough with JS testing to know how smart it is.


Please add an empty line after.


This is created by the versioneer installer for interveening when exporting the repo, as described here: https://git-scm.com/book/en/v2/Customizing-Git-Git-Attributes#Exporting-Your-Repository


The question is not 'Is it very readable in someone's opinion?", but is
```python p in PosRange(start, stop)``` more readable then ```python (0, 0) <= (1, 0) <= (1, 1)```
I think it is.
But that's not the only benefit. I'll commit some work in progress files later and you will see more examples, but just one of them

```python
class Position(object):

    def __init__(self, line, column):
        self.line = line
        self.column = column
        self.real_line = line - 1
```

And now we don't have to think about that we count lines from one and there is no need to put p.line - 1 everywhere.

```python
 class Content(object):

    def __init__(self, lines=[]):
        self.lines = lines

    def __getitem__(self, index):
        start_line_slice_start = index.start.column
        start_line_slice_stop = None
        first_line = []
        whole_lines = []
        end_line = []
        if index.start.real_line < index.stop.real_line:
            whole_lines.extend(
                self.lines[index.start.real_line + 1: index.stop.real_line]
            )
            end_line = [
                self.lines[index.stop.real_line][:index.stop.column + 1]
            ]
        else:
            start_line_slice_stop = index.stop.column + 1
        fst_selected_line = self.lines[index.start.real_line]
        first_line.append(
            fst_selected_line[start_line_slice_start:start_line_slice_stop]
        )
        return first_line + whole_lines + end_line

    def __setitem__(self, index, value):
        pass

    @classmethod
    def from_file(cls, path):
        lines = cls(splitlines(source_to_unicode(content(path))))
        return cls(lines)

```

Imagine what getitem would look like without PositionRange object which is used for indexing? I think the readability would be somewhat worse if index would be a tuple of tuples.

Also I'm not sure right now, but I think some methods would be beneficial to have in PositionRange to do stuff like extend range by position, or extend range up to new position.

Position should be a class which extends namedtuple though, so backward compatibility would be easier.

Don't get me wrong, I like the code to be as simple as possible. But I think in this case usage of tuples or even separate arguments (like in Script init method) is not beneficial. Maybe I'm wrong, but we'll see.


Retry count should never be -1.


wouldn't that semantic come from line 2128? and passed in as an err?


We don't want to enable event submission and reporting in tests.


I do not understand how end of day is set here ?


Cool, I learned something new about Python today


I guess we could make archive.extract to return the base directory already so one could do:

    self.srcdir = archive.extract(tarball_path, self.srcdir)

But of course, that has no bearing on your code, which looks nice.


All methods has no access tag


Regarding size, du counts size of the removed liveries 73.2 MB (69.8 MiB) out of 216 MB (206 MiB) or 33.8%. Without the liveries the directory has 143 MB (136 MiB).

The repository (`.git`) has additional 247 MB (236 MiB) and removing them obviously does not reduce it, because they are still part of the history.


Thanks. I'll check this.


With crappy Python code no less!


This deserves a separate private method.


111101900_MSHeatPump (Nigusse) - i386-Windows-7-VisualStudio-12: OK (2001 of 2001 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


add-default-build-type (nealkruis) - x86_64-MacOS-10.9-clang: OK (1995 of 1995 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It's unnecessary to create a promise out of a promise. You already have a promise, so you can just return that. This makes sense if you remember that `somepromise.then(function() { return otherpromise; })` is itself a promise, just one that does something once `somepromise` is fulfilled.

``` js
exports.renderProfile = function(key, steamid) {
  return validate.steamid(key, steamid)
    .then(function(steamid) {
      var URI = buildURI(key, steamid);
      return getUserData(URI);
    })
    .then(function(userInfo) {
      return imgProcess(userInfo);
    });
};
```


spice-html5 is does not include `spicearraybuffer` .. according to @martinpovolny, it's needed for IE - looks like a shim for `ArrayBuffer.slice`


I think your change here is still good. It is equally correct, and theoretically less bug-prone.

I think it is correct for this op to be a unary function.


add-default-build-type (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2033 of 2033 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Some whitespace went walkabout


yes. Which I dont think is a huge amount of bytes. it does have some images
but nothing I found concerning.

On Wed, Jan 6, 2016 at 10:13 AM, Jan Hudec <notifications@github.com> wrote:

> Regarding size, du counts size of the removed liveries 73.2 MB (69.8 MiB)
> out of 216 MB (206 MiB) or 33.8%. Without the liveries the directory has
> 143 MB (136 MiB).
>
> The repository (.git) has additional 247 MB (236 MiB) and removing them
> obviously does not reduce it, because they are still part of the history.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/FGMEMBERS/dhc6/commit/969d6f033cb3262e962cc11cc8362d8626ac21d8#commitcomment-15296873>
> .
>


Copy paste error, fixed.


Removed


Is this `steamid` different from the one that was already in the scope? I imagine the one already in the scope could've been a name, and this `steamid` is definitely an actual STEAM_ID? If they are indeed different, you should use a different name. Shadowing variables can lead to problems/confusion.


This change in variable order is not consistent with the order that is in toolkit.version file.  It was better the way it was.


Can you remove the added files from this commit to `public/` (like `jquery.js`, `moment.min.js`, etc...)

Those are copied from the build (from the source bower folders) so no need to check in - might have just been overlooked.

Otherwise looks good


Instead of now, you can prepare expected return for a specific dummy date, then match stored values with returned result


Why would avoiding the wrapper make any case slower ? Esp. the simple icalls like the one for lshl/lshr ?


Can you add a note to this comment explaining what the second argument is in each case?


It looks like this may have some tabs rather than spaces, but otherwise looks good. Can you resubmit with fixed whitespace?


Think this is what is causing my db issues?


They might reflect graceful shutdown because of container exit code? Removed for now, let me know if you think we should retain it.


I know this is old, but I was looking at this code and got curious about why you are constructing this 8 times, do you remember why?


when we initially installed them several liveries in the database actually
broke the plane (due to nasal issues with the xmls)
Now last time I checked, they all workd just fine

On Wed, Jan 6, 2016 at 10:15 AM, Israel Hernandez <
israel.a.hernandez@gmail.com> wrote:

> yes. Which I dont think is a huge amount of bytes. it does have some
> images but nothing I found concerning.
>
> On Wed, Jan 6, 2016 at 10:13 AM, Jan Hudec <notifications@github.com>
> wrote:
>
>> Regarding size, du counts size of the removed liveries 73.2 MB (69.8 MiB)
>> out of 216 MB (206 MiB) or 33.8%. Without the liveries the directory has
>> 143 MB (136 MiB).
>>
>> The repository (.git) has additional 247 MB (236 MiB) and removing them
>> obviously does not reduce it, because they are still part of the history.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/FGMEMBERS/dhc6/commit/969d6f033cb3262e962cc11cc8362d8626ac21d8#commitcomment-15296873>
>> .
>>
>
>


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10828](https://teamcity.mesosphere.io/viewLog.html?buildId=100883&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:08:37


There was no new file option so I did this. Still new to Github.


I have a feeling you can fold this into the `request` callback, notice there's an `err` parameter. Just add an `else` clause to the `if` and `reject` it there.

I recommend you use [`request-promise`](https://github.com/request/request-promise) though.


:heart:


This is only used once, so maybe inline on L160?


> Why lowerBound and not (also?) upperBound?

I think upperBound makes sense too.  We just needed lowerBound for our use case.


I was looking at a way to make this non-blocking... definitely possible, but more involved.


Added


Bck


oops ==> fixed and pushed.

On 06/01/2016 2:46 AM, MarcoFalke wrote:
>
> Nit: Excessive white space.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ptschip/bitcoin/commit/aeb33eeb2303bd4a89db497a4cdb7853832e9a27#commitcomment-15285069>.
>


See demo app for preview. Right toolbar icon set to animate.


you can remove those comments from this file


oh, that change from 40 to 60 was not intentional. I will revert that. The shorter time is better - more zing!


add-default-build-type (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


did you mean to change `GCLOUD_TRACE_CONFIG` to `GCLOUD_CONFIG`, as the commit comment indicates?


Ahh, is it because previously we started with `base`, so `extends` was copied over, where as now it starts with an empty dict, so we need to explicitly add `extends` to the keys to be copied over.

We've never really explicitly documented how these two should work together, but I think we can restore the old behaviour, I'll open a PR.


Added new lines


What should we do if we didn't find the instance?.... just log it?


Realistic behavior.


@bfontaine  yes...


Maybe move to `authkey_generator.rb` and `authkey_writer.rb`?
I understand that both are included from this one but here it looks bit confusing when not used in the recipe...


This does nor correctly handle "X-Forwarded-For" headers, because they can contain a comma separated list of ips, with the left most entry being the client ip. Many load balancers like ELB only provide X-Forwarded-For and no additional header like X-Real-IP which only contains the client ip.


where was the std_tag added in this commit ?


Instead of foreach, you can use assertion per each key and it's value ,avoiding logic in assertions and more lines of that code are not bad either


guess you can remove all but the spicearrybuffer and that can be remove if/when your PR on that is merged


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10829](https://teamcity.mesosphere.io/viewLog.html?buildId=100888&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:05


The degrees of success are not calculated like this in the Dark Heresy 2nd Edition. They are now done based on the tens digit of the roll and the target number. Makes it easier for pen&paper players to calculate them fast. I didn't figure out the formula that would do them automatically so I decided to not use the wrong one from the Dark Heresy 1st Edition which you added now.


one is enough, see line 52


@martinpovolny Have you confirmed that adding that actually fixed things on an appliance?


can't one calls the other ?


Actually, I thought this would be handled by `merge_service_dicts_from_files()`.  Can you include what you expect to see as a result of those two files, and what you get now?


Same thing here. Don't wrap a promise in another promise, it over-complicates things and creates unnecessary work. Just remove the promise wrapper, change it to `return getUserDirectory.then(...)` and replace the `reject/resolve` calls as needed. You might need a promise wrapper around `gm`'s `write()`, but that's less things to wrap than this entire block.


wtf ?


I guess, you have to write 0xFFFFFFFFL (with an L)


does fabs works on double too ?


Dt as variable name is used many times, and still not descriptive


Done.


i thought it was slow ?


What do you mean by is fluid ?


why do the assert- cases disappear ?


Looks like none of my renaming changes in any of the files made it into that commit. They should be there now.


Test cases has no docblocks


either use it or remove the using


why the incldue if nothing changes in the file ?


It was an unused import


Also, the download linked is entirely dependent on the user being from windows, you could just link the "download minecraft" webpage to handle platforms.


why there and not in options like all the other ??


r+


In the root of your website checkout there's a script called run-server.sh  If you run that, you'll have a full local copy of the website running at http://0.0.0.0:4567/

Yeah, we need to doc this better. :-)


ok, it's not needed for IE11, but it is needed for IE10. Still supporting IE10 in D-release, right?

Looking at the code, `mb.slice` happens at many places so we'd definitely hit that in IE10.


why adding includes if the code doesn't change ?


Fixed


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10827](https://teamcity.mesosphere.io/viewLog.html?buildId=100882&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:17:40


Previously the flattened `web` would amount to this:
```
  build: .
  dockerfile: ./compose/app/Dockerfile
  command: /bin/true
  volumes:
   - .:/app
```

Right now I get "ERROR: Validation failed, reason(s):
Service 'web' has neither an image nor a build path specified. Exactly one must be provided."


Done.


What is the point of this test case and the one before it ,if 'from now' test case cover main scenario ?


Ah! Ok. Perhaps add `hdr.split(" ").first` then?


It's because the feature/multigrid branch added a new copy constructor to SolverParam which wasn't present before:
```c++
SolverParam::SolverParam(const SolverParam &param)
```