@AndroPlus It seems to be a case of No-Fill from InMobi. Please check if you have included Google Play Services library dependency and your property id is in activated state.

If none of the above works out reach out to InMobi Support team. As the above code works fine and error which you are getting is not dependent on the Custom Event.


Only this patch works correctly.


The changes in the `main.c` file tie #2 and #8 to the admin menu.


initialize to null


if we come here post oAuthPostData failure, postData and buffer will be invalid. Check for their sanity before freeing them


strdup can fail with ENOMEM


Das interessiert mein script recht wenig. Ich lese doch keine keys mehr! :P


"results-directory" is of type="URI" , while "dir" is of type "string", but this doesn't seem to be en issue.
To handle this properly, maybe dir could also be an URI and the beanshell could convert it to String.


nope. this anchor will hold the link to a unit.


we can remove Ref. But it's clear that we have JsonValue as member. I don't think we should return Ref. There will be unneeded object creation. If the caller will really need Ref, then JsonValue  will be converted to Ref of the caller side.


Nope, the router feature was finished. I consider `api-templates` etc. different features.


`requests` is used in c2corg_api/security/discourse_sso_provider.py.

Added a parameter to trigger discourse login/logout.


dictionary() returns actually JsonValue.


TeamCity pull requests :: netty [Build 1054](https://garage.netty.io/teamcity/viewLog.html?buildId=4862&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6381, ignored: 23 Build time: 00:54:19


hi there,
we are building an app with the below mentioned stack and faced an issue wherein the ios build fails for various plugins [view issue](https://issues.apache.org/jira/browse/CB-10310). This fix handles the impediment for cordova ios 4.0.x.
please release an update as soon as possible.
cheers.


Hello,
Downloaded the latest code, and used the code given at:
https://github.com/WebDevStudios/CMB2/blob/trunk/example-functions.php#L518-L558
Still I can't see any metaboxes when visiting the taxonomy editing page.


Looks like INFO message for this module


Comment about line three


I don't think the ClickGui should be removed though.


:+1: @Kefta


Changed it to use a loose truthyness check in 3395766eb9ec3a8e072146bde878db73b1151c58.  @AutomatedTester can revert that with proper Python idioms if he’d like, but at least in this way the code does not behave in a surprising manner.


Don't commit unnecessary files such as `.DS_Store`.

You can should add stuff like this to your [`.gitignore` file](https://git-scm.com/docs/gitignore).


Yes I think you are right, I cannot discern of a difference (after reading up on what exactly '\zs' means :) ).  Seems like a duplicate function in that case, unless you see benefit of the name being one-to-one, and optionally using the builtin when available.


neat idea :)


@jeez, @ricardotk: How does this look?


r+


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11978](https://teamcity.mesosphere.io/viewLog.html?buildId=108266&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:08:29


LGTM


TeamCity pull requests :: netty [Build 1062](https://garage.netty.io/teamcity/viewLog.html?buildId=4883&buildTypeId=pulls_netty&guest=1) is now running


Confirmed that this does in fact work as expected in the older vim version I'm supporting.  Definitely looks like the better method!  I'm still pretty new to this autoloading thing. :)


ASIHPdev (shenb) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-64.25%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


Won't this notify for each missing property again and again?  You probably only won't to do this here, if `mMissingPropertiesFound` changed, or?


Damit muss GParserTest noch abgeändert werden. Dort wird der Parser noch nicht als Singelton verwendet


I added in Stephen's notes and am commenting here so we're all looking at the most recent commits.

I agree with a lot of @sgluckman  comparisons, though I think Moretti is looking at more than just the physical movement within one novel. He does want to be able to show how looking at maps together shows the forces right?

@LaurenSamblanet
Either is fine with me. If you wanted one of us could summarize his main point and the other could mention where he concludes? Or is that too much overlap? Should we split it so one summarizes main/abstract ideas and the other summarizes his concrete examples?


Thank you thank you I'm here all week


@ptvan , you may want to check this out.


`import ... 1.2`.  The same below: Since `1.2`.


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#AOnRz59YTGyv_g75Nc7zQw


The sections are not require to be in this order. There are some constraints, perhaps better noted for each section.


without writing tests for this, i'd be inclined to not change any of this logic, only updating the references for the constant lists.  though i do think we should eventually break this logic out into something reusable that has tests.

for instance, i'm not clear on why the `flatten` call was added (not to say it shouldn't be done, just that i don't see the need at first glance, and there's no explanation or test to help assuage my worry about it breaking things).

i do think this should get refactored out into something more testable and reusable, though that's definitely a different PR.


PlantCompBaseClassAgain (Myoldmopar) - i386-Windows-7-VisualStudio-12: Tests Failed (1727 of 2056 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-84.0%25-red.svg)


Some documentation on this would be good :-)


Could we please include the section codes rather than using an external reference.


why not make the return value of this function (and `size` make a `size_t`)?


Oh, this would be very helpful indeed. Thanks for implementing it !


To make the revision numbering proper this should be:
```
qmlRegisterType<aqt::stylesheets::StyleChecker>(pUri, 1, 2, "StyleChecker");
```
Or wait.  This is a brand new class. So this should be `1.3` I guess ...


Also note the maximum size is 1GB.


quite so.


TeamCity pull requests :: netty [Build 1060](https://garage.netty.io/teamcity/viewLog.html?buildId=4881&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6385, ignored: 23 Build time: 00:44:59


TeamCity pull requests :: netty [Build 1063](https://garage.netty.io/teamcity/viewLog.html?buildId=4884&buildTypeId=pulls_netty&guest=1) is now running


On Tue, Jan 19, 2016 at 4:20 PM, Scott Baker <vim-dev-github@256bit.org>
wrote:

I'm able to compile v7.4.1142, but v7.4.1143 fails to compile complaining
> about:
>
> gcc -c -I. -Iproto -DHAVE_CONFIG_H     -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1       -o objects/pathdef.o auto/pathdef.c
> ex_cmds.c: In function ‘ex_sort’:
> ex_cmds.c:560:48: error: ‘DBL_MAX’ undeclared (first use in this function)
>
> [...]

I'm seeing the same error.   I can get it to compile if I add this to
ex_cmds.c
#include <float.h>

--
Christian J. Robinson <heptite@gmail.com>


GeoLatam

Proyecto GeoLatam para las comunidades de OpenStreetMap de Latinoamerica

Este proyecto usa Mapbox GL JS con el servidor de teselas desarrollado por Geometa Lab HSR y Klokan Technologies GmbH (Más información en http://osm2vectortiles.org). Ambos sportan teselas vectoriales como fuente de los datos.

Tutorial para servir teselas vectoriales en http://osm2vectortiles.org

Basado en Mapbox-GL-JS: https://www.mapbox.com/mapbox-gl-js

Usando estilos de Mapbox styles: https://github.com/mapbox/mapbox-gl-styles
Requirimientos

    Apache webserver (con mod_rewrite / .htaccess soportados)
    PHP 5.2+ con módulo SQLite (php5-sqlite)

(o algún otro webserver que implemente reglas mod_rewrite y PHP)
Implementación (Ubuntu)

    Instalar Apache

sudo apt-get update
sudo apt-get install apache2

    Instalar PHP y módulo SQLite

sudo apt-get install php5 php5-sqlite libapache2-mod-php5
sudo service apache2 restart

    Clonar el proyecto en el directorio /var/www/html

    Descargar la base de datos de teselas vectoriales (archivos .MBtiles) en el directorio "vectiles" desde http://osm2vectortiles.org/downloads/ y renombrarla como "vectiles.mbtiles"

    Para mostrar areas determinadas al máximo nivel de zoom (porque el extracto del mundo de osm2vectortiles llega como máximo al nivel 8) pueden bajarse los extractos deseados al mismo directorio del punto anterior e importarlos en el archivo vectiles.mbtiles ejecutando el script que está ahí mismo mediante el siguiente comando:

sudo bash ./merge_mbtiles.sh [archivo_a_importar.mbtiles] vectiles.mbtiles

El proceso demora unos minutos dependiendo del tamaño del archivo a impor

tar. Al finalizar se generará un archivo "vectiles.mbtiles-journal" el cual puede ser eliminado sin afectar el funcionamiento del tileserver.

    Abrir http://127.0.0.1/geolatam y a disfrutar ;)


Could we please also include this table of LocalType codes.


Must only occur once.


@abbradar i'm using 3.5.0 version of tweepy which should fix this. also i made tests pass.


Maybe you could still continue to support plugins using a `*.Touch` namespace in addition to `*.iOS`?
This change forces internal plugins developed by MvvmCross users to apply the same refactoring as you did in MvvmCross


Oh, nice, haven't known about that 3.5.0 fixes it. Thank you!


stray outdated comment


A note on commit messages; For your own sake, you probably want start documenting your changes (your commits) with sane, well written messages around what changed as well as the motiviation for the change (the why).

Follow [this guide](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) and be relentless about following those standards.


@littledan Calls from JS now go through the JS constructor (albeit with a hack to get around the zero-fill limitation). Calls from C++ still use `Uint8Array::*` calls. This is unavoidable since they need to accept `char*`.


I did see the earlier commit, but figured it would be best to comment against the most recent one.

I've done some more looking.  There is information about this in the top-level `README` document, in the "File Locations" section.  That differs a *lot* from what's here (your `CONFIG_PATHS` has three identical strings, which is just weird for a start).

SA is a bit more complex, in that it has a Makefile and it'll choose different defaults based on what `PREFIX` is.  We have setup.py, but it doesn't seem very Pythonic to change the installed code's defaults based on how setup.py is run.

I still think that right now we should not look in *any* of these locations, and only look where we are explicitly told to.  This will make testing far cleaner, removing any chance of errors if someone mistakenly runs on a server where SA is installed.

We should have a discussion at some point about what the behaviour here should be.  In a distro's package (e.g. if there's a Debian package of this project) I would expect that the package would have the appropriate patches to look in the places that the maintainer believes is correct (from what I've seen, this is pretty common, and I think it's what's happening with SA as well).

Outside of that, I think we should be defaulting to a location that is for *this* project.  We could have an install-time option to copy across SA configuration files and rules, or we could also look in places SA would store that data, and might or might not want that as the default behaviour (i.e. we need to figure out exactly how "drop in replacement" works).


Could we please also include this flags table, Perhaps just the two bit used here.


Alyssa, I think one person should do the key points and the other should do the conclusion. I'm happy to do the conclusion if that works for you.


What are `ipynb` files? Are these essential to the project?


other than my concern about the rake task and the minor comment discrepancy, i'm :+1: on this.


Fair point!


Rewrite:
This is fairly hard to obtain in your typical home oven, but you can work around it with some oven steam hacks.


Could you move these functions to approval_polls/detail.js and keep minimum JS code in the HTML file ? Perhaps you could also source this js in header block of detail.html.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11980](https://teamcity.mesosphere.io/viewLog.html?buildId=108276&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:28


Alternatives to tough (used multiple times with multiple connotations):
challenging, tricky


Missing the `exported` flag.


Sure. Sounds good to me.


Rewrite:
Oven consistency is often the source of a lot of problems.


Your import statements should [follow Pep-8 rules](https://www.python.org/dev/peps/pep-0008/#imports).


spelling


Add comma: "If you have one, try weighing.."


Might it be worth adding a note that this is not just a check-size, rather the body forms need to be read until this many bytes have been read, which define the number of body top level expressions.


Probably don't need this, do a Flush()


Is there a specific reason for the capitalization of arg `X`?


Remove parenthetical?  "When working with wetter dough than the one we are working with here, a bench knife..."


This seems to be displaying only the last two digits of the days and should display the whole number. (eg '1365' days is displayed as '65')


Could we ignore this section. It's not really part of wasm yet, rather v8 support for asm.js.


I think this looks good and is more correct.


"Basically" used in paragraph before.


You don't need this method unless you plan on doing anything during intialization.


Are you using spaces or tabs? I'd recommend spaces (4).


Marek, we can discuss on this? we have this problem since September.

https://github.com/NancyFx/Nancy/issues/2193


Must only occur once.


109490574b-UnbalancedFlowWarning-4293-PlanB (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (957 of 957 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.85%25-green.svg)


Rewrite: "They are used to score the bread and make those pretty ears on, say, a baguette. Ears allow air to escape..."


Class names typically follow this pattern `CensusDataLoader` (remove the snake casing for class definitions).


You have been le trolled. hoooooooooooooooooooooooooooray


'in the linear memory'


You'll probably want to rename this class to not use snake_case.


Now that the SiCKRage.py file is in /sickrage, this change to the import doesn't seem to work. Now when I run SiCKRage.py I get an import error because it's trying to import main from package sickrage inside the sickrage package. At least, I think that's the issue.


@Arcanemagus any way I can get admin rights to this repo so I can have TravisCI watch this repo?


are you sure you want to use 2 litres of mosquito semen?


ASIHPdev (shenb) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-40.48%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


Also only once.


Is there any need to keep this commented line? If not, may as well clean it up.


Pruebas


Of course, this can also be done in `format_currency`, but I'm convinced, that at some point, the display context should be used.


Could you keep the date format the same as the 'Published date' on the home page ? (date:"N j, Y, P e")
I am assuming you kept it this way so that the size of the labels line up, but in a way i think having it the same format as the home page will be more consistent for voters. Let me know if you differ on this.


No vacuum emoji? :disappointed:


Same issue here


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11981](https://teamcity.mesosphere.io/viewLog.html?buildId=108281&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:03:48


apktool要不得,反编译回编译出来的flymelunch有问题,要discard这条commit


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11982](https://teamcity.mesosphere.io/viewLog.html?buildId=108282&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:23


`not_is_hprop_bool_eq_bool` and `is_hset_bool` are general facts about `bool`, so it might be better to move them to a different file for easier access.


cool stuff! I merged pulled it and then did some template formatting and optional param flag stuff. Check it out.


Travis is enabled, enjoy :wink:.


Might be worth a note that this 'index space' includes both the imports and function definitions, notable because this might conflict with the current wasm design. Perhaps also add 'zero-based index in the order specified'.


Given that we're storing the ARK id explicitly, would it be better to retrieve it from that attribute rather than reconstructing it? If we ever change shoulders, for example, this will break.


Whenever there is a datetime in the DOM, make sure you wrap it in a `<time>` element


git reset --hard HEAD^


@huangdijia  单元测试不走init


There might be a better name for `X_must_be_hset`. That name is what 3.8.5 means, but it doesn't follow Lean's naming convention.


@JeremyCSwain Great job on the HTML structure and the CSS selectors, including the naming of them.

:+1:


Hello, I am very interested in what is the latest news regarding this fix. We could really use this fix but it appears to not have been merged into the main branch yet.


Testing


Optional, and should be accepted in any order and multiple times. No semantic affect on the code and can be ignored for execution by the runtime. Size excludes the size itself.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11983](https://teamcity.mesosphere.io/viewLog.html?buildId=108304&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:00:38


Please reverse this pull request. It is currently has problem:

<4>[    3.202901] C0 [           init, 1] Mali: ERR: ../../../../../../kernel/samsung/vivalto3gvn/drivers/gpu/mali400/r4p0/common/mali_kernel_core.c
<4>[    3.202928] C0 [           init, 1]            mali_check_shared_interrupts() 614
<4>[    3.203012] C0 [           init, 1] Mali: ERR: ../../../../../../kernel/samsung/vivalto3gvn/drivers/gpu/mali400/r4p0/linux/mali_kernel_linux.c
<4>[    3.203029] C0 [           init, 1]            mali_probe() 498
<4>[    3.203029] C0 [           init, 1]            mali_probe(): Failed to initialize Mali device driver.
<4>[    3.203090] C0 [           init, 1] mali-utgard: probe of mali-utgard.0 failed with error -14
<4>[    3.203215] C0 [           init, 1] Mali: Mali device driver loaded


Not sure what to name `X_must_be_hset`. That name is what 3.8.5 means, but there may be a better alternative that follows Lean's naming convention.


'but it is not explicitly handled by the decoder' does not read well. The decoder does read data OOL from this area, all referenced by their offset so could have other blobs.


Currently it does not display the closing datetime after the poll has closed.
If the user has selected the 'Show poll close date' i think it would be good to show the user when the poll closed, even after the poll has closed. That way he/she can get an idea of the amount of time that has passed since the poll closed.


Let me know what you think about this commit. I'm totally winging it on this React stuff lol


Tole še vedno ne deluje pri meni, tako da prosim popravi (glej #1).


optString


Feel free to fix this


It should be noted that the incorrect type here would have been caught earlier if `Subscriber.prototype.destination` was statically typed, instead of being `Observer<any>`. An `Observer<T>` cannot accept an array of `T`, as is being passed on [line 32](https://github.com/masaeedu/RxJS/commit/88215b17ca937a167c2a0b5ee23067586037b997#diff-7e0b191ca95644f204904b496985b566R32)


LGTM.


Hmm...an environment variable could work. Although in cases where an EC2 instance isn't assigned an elastic IP the instances IP will change after a restart which means the run command must always change to reflect this new IP. This also means the docker `--restart=always` flag couldn't be used. Since the run command needs to change (if no elastic IP given to instance).

None of this applies if not using an EC2 instance, and the environment variable should be fine for those cases.

What do you think of this new block?
```
if [ ! -z $PASV_ADDRESS ]; then
  sed -i "s/^pasv_address=/pasv_address=$PASV_ADDRESS/" /etc/vsftpd.conf
elif curl -s http://instance-data.ec2.internal > /dev/null ; then
  IP=$(curl -s http://instance-data.ec2.internal/latest/meta-data/public-ipv4)
  sed -i "s/^pasv_address=/pasv_address=$IP/" /etc/vsftpd.conf
else
  echo "You need to set PASV_ADDRESS environment variable, or run in an EC2 instance. Aborting!"
  exit 1
fi
```

This will first check for an environment variable, or if it is an EC2 instance (I removed the `169.254.169.354` IP since it is just the EC2 instance meta-data address and equivalent to `instance-data.ec2.internal`), and if neither of those is found it will exit like all other environment variable checks.


Just thought of this. The [rand_s](https://msdn.microsoft.com/en-us/library/sxtz2fa8.aspx) can fail. Better to check for the failing return value and initialize the seed differently?


The current label design that you added does look good, and stands out from the other text on the page. Could you perhaps change the Creator: to also be a label-default so that all poll info is in the same style ? Perhaps something like this. Let me know if you differ on this.
![label](https://cloud.githubusercontent.com/assets/7693347/12436503/c5143698-beca-11e5-8d14-664750741a71.jpg)


:joy: :joy: :joy:


This doesn't do anything, is it unecessary, shouldn't be called and output null


I think it might be okay since Math.pow() returns a double (and varAdjust is itself a double). But maybe we should use a long?


Hi. hope you're fine. Do you have working camera with that commit?
if yes does it needs others commits?
thank you.
regard.


Should that be guarded by `debug_log_enabled?`?


You accepted my PR to (along with some node fixes) update tank costs and masses (#117), and then overwrote some of the cost and mass changes in this commit.  Was this intended?


This was meant to be an example of a question. Would it be after a plus, so like
+How would you set up a sendable chooser?
then we would either comment a link or give direction. Possible like a todo list overall? I guess I should look into markdown syntax


No issues that I can see. We will just have to wait and find out.


Thanks for this and the other errata, I'll try to go over it and make revisions tomorrow.


Windoww typo


Committed as 6f86c43237a32041d94470ead587995555dbe0e5.


Very minor but could you add an <hr> separator between the categories of settings to make a visual separation between 'voters for poll' vs 'poll closing date' related options ?


Massa, muito útil isso :+1:


It's my opinion that we don't need to do that because hand-assigned numbers are a stopgap. We previously committed to using names and having name->index tables.

But maybe I should lay out the enumerations as-is anyway, despite the fact that they are in flux. I'll think about it.


Hmm, I don't see it...

I was thinking ... drive( Robot.oi.getJoystick().getX, Robot.oi.getJoystick().getY * -1);


Committed as f277bad835c1c0f31d531d680891a64ec59b29ee.


The reason this isn't type safe is because we're propagating the optional `project` function into the operator, which changes the return type. If the `project` is present, we'll get `(T | U)[]`s out, if it isn't we'll get `R`s out. As a result, lifting produces an `Observable<(T | U)[] | R>`, which is similar, but not assignable, to `Observable<(T | U)[] | R>`. I couldn't see a way to fix this without a larger refactoring.


Are you tho?


Committed as 155824577039d37e02e7450cf945cb38eca7443c.


I think the 'in this order' language is a survivor from an older document, thanks for pointing it out. The constraints are in each section but I think as you mention in some of the other comments, I didn't put all the constraints in.


Exported is part of the decl bits, it's not a separate byte in the module, I thought? Maybe I need to reread that function.


got to clean my glasses :)


Time flies 😛


Could make this simpler by doing the if statement as a ternary operator for the return


Fixes issue #9


Much better- thanks @nywillb!


Fixes issue #12


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11984](https://teamcity.mesosphere.io/viewLog.html?buildId=108305&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:09


Fixes #11


Could be reduced to:

  return sellen > 4 && memcmp("set", selname, 3) == 0 && selname[sellen - 1] == ':'


Same happening for me as well. I had a VBS script running at startup that would launch SickBeard.py under C:\SickRage but even after updating that to C:\SickRage\sickrage\ or trying to run SickBeard.py, I get the same error as those above.


Fixes #4


assign_to_result_of_map (lefticus) - x86_64-MacOS-10.9-clang: OK (351 of 352 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


Maybe add in some comments to say what you are comparing each time, helps make it clearer when going over/when changing bits


In making a temporary change in how old processes were being removed manage to tack on some technical debt.  `free_process` was original added as permanent solution to alter the `process_list` while iterating over it (not a good idea).  The other part of this came as a temporary add-on in `update_process_list` but, the combination of using both resulted in segfaults.


No. This object is not used when in display lists mode. The main.cpp code uses original OpenCSG immediate mode objects DisplayListPrimitive to render in display list mode.


By convention this should be after the constructor


不就应该翻译成萤石嘛？


111639676-UniqueThermostats (kbenne) - i386-Windows-7-VisualStudio-12: Tests Failed (2119 of 2384 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.88%25-red.svg)


This is a very long method, may be easier to read if you separate it out to create each bit in a separate method


Minor - this comment needs update.


Hey, thanks for fixing that, I was just going to do that. (There are other methods where it still needs to be fixed, though--I'll do those.)


TeamCity pull requests :: netty [Build 1063](https://garage.netty.io/teamcity/viewLog.html?buildId=4884&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6385, ignored: 23 Build time: 00:43:52


109490574b-UnbalancedFlowWarning-4293-PlanB (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2088 of 2089 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


This is relevant. Regression tests tend to lose meaning/context after overhauls...


May be worth making it so that the exceptions do something except just print a stack trace unless they will never be called by the functionality of the program


This is a wrong description. The default output doesn't include labels' column but when you use your flag, you do show them. Please add something more descriptive.


You don't need to write "getter" methods explicitly.  You can do this:
````ruby
    attr_reader(:highest_wf_count, :highest_wf_words, :content, :line_number)
    # "attr_writer" if you want setters
    # "attr_accessor" if you want both
````
As a bonus, you wind up with a line near the top of your class that says what attributes you meant to be there.


Heikki,

The disk usage check is done for each FTS probe periodically, which is like
a cron job except that it is integrated with the RDBMS.

Shoaib

On Tue, Jan 19, 2016 at 3:48 PM, Heikki Linnakangas <
notifications@github.com> wrote:

> Why is this tied to fts_diskio_check guc? And why is this check performed
> as part of backend initialization? I would assume it to be periodic, like a
> cron job.
>
> (I have to wonder why you wouldn't just use a cron job for this whole
> thing, anyway..)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/slari-pivotal/gpdb/commit/eeaf3f1fcb581b3be52bf6fd35504ba669f54c5a#commitcomment-15544480>
> .
>


What are the obstacles to enabling this in development? it would be really handy if we could use VCR in development mode, so that new developers and volunteers didn't have to set up AWS credentials.


@mattbenjamin so basically if the --email param is passed with a non empty string then user cannot be modified? Does that mean a user cannot have its email changed?


Good use of loop to create the buttons together


When creating CSS class names, think about the purpose of the HTML elements to which you are applying them.  `.second` and `.third` are fragile, because the order of the HTML elements could very easily change in the future.

For example, you applied those class names to article sections. Create a class named `article-section`.


Minor - return BAD_VAR_NUM instead of zero for double protection.


Tukaj odstrani enačaje, pred vsakim elementom sledečega seznama pa postavi `*`, da se bo v poročilu dejansko izpisal seznam.


One question: Does using `ConcurrentMap` guarantee that this class is thread-safe? I'm a bit curious we need a concurrent collection just for `put` and `get` operations. Could you kindly explain if there are any concurrency issues we should take care of?


ta :D


Not sure this comment is relevant, is it meant to be in the initialise method


I think we do want to be testing the codepaths exercised by `CDO.use_dynamo_properties = true`, since that's the behavior used in production.


Thanks, that's better


Yeah, I know. Different way of doing things. If I continue working with Ruby I might prefer it.


This is entirely the wrong place for `deductPP` for so many different reasons.

If you use Sleep Talk to Calm Mind, you want to deduct Sleep Talk's PP, not Calm Mind (and so on for every other caller like Metronome). You don't want to deduct the move's PP on the second turn of a two-turn move...


@DrPizza , Currently I am doing search to bring libdispatch implementation in winObjc (based on your git libdispatch win32 port) up to date with Apples. and I noticed in your last comment that you mentioned you might have started similar effort since Last august.  I'd like to confirm with you if you are still continuing that effort?


isSetter may be


The latest update moved the startup files which has broken all the scripts to run this as a service


Is this meant to implement something from above, have struggled to work out the structure on code review but that could well be my fault


@k-takata, could you look at the commit log of this PR?
```
MSYS translates `/pattern/` to a path, so use `:pattern:` instead.
```

Is this expected behaviour?
If yes, I will replace all '/' with something else in files under optlib.


Typo in comment : ".. in the callers incoming arg stack space"


@KasperFranz did that work?


The update also now cannot find existing config.ini


```go
// Required. The effect of the taint, ref TaintEffect.
```


typo: "callee"


Please add a description on top of the function about what this function is doing and why.


Importing all the librarys is bad practise, should really try to import only the ones needed


Not sure these comments are in the correct places


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11988](https://teamcity.mesosphere.io/viewLog.html?buildId=108335&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:09


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11987](https://teamcity.mesosphere.io/viewLog.html?buildId=108313&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:12


This comment needs to be closer to the windows assert


assign_to_result_of_map (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (351 of 352 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


These comment lines could be deleted.


I'm not a big fan of the conditional splice here. The Escher functionality is done like this, because having Escher (a web framework) a requirement of Vega seemed odd. I'm fine with Interact/Patchwork being requirements, if the functionality truly is additive to building visualizations.

However, I think there's a better way of thinking about this PR in terms of a mutating function, perhaps called `interact!`, where interactivity could be added. Additionally, maybe also creating a `vcat` method would make sense, as you found. That would sort of meet the idea of #73


This is our first deliverable:
[DELIVERABLE.1.pdf](https://github.com/yemointer/COEN-6312-Project-Group/files/96800/DELIVERABLE.1.pdf)


This is an incompatible change (with the old universal-ctags itself).
However, I will accept this change because it is not in exuberant-ctags.


Oh, actually I was trying to mention `new VortexAggregateFuture<>(...)` instead of the variable type. Sorry for not being specific.


最好按照原格式加上空格，下面也是...


typo: ".. outgoing arg area on"


Could you remove this casting from this commit?


Also, why is `CDO.use_dynamo_tables` modified but not `CDO.use_dynamo_properties`?


Should have reference to _multipart_upload to describe what kwargs can be.


Thanks big man!


finally


Should use capital letters for the start of each word by convention, may be worth changing the names of one of the classes to differentiate between the creation of the window and the implementation behind it


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11986](https://teamcity.mesosphere.io/viewLog.html?buildId=108312&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:03:38


Thank you for spotting this.


typo: ".. always allocates stack slots (homing space) .."


Bad practise to catch generic exception, should try to specify and deal with each one


Argh, I see you remove this line later. Apologies, I am looking at individual commit diffs because the overall diff is too large to display.


Committed as 6f86c43237a32041d94470ead587995555dbe0e5.


I get an error with that code in line 6


For all of the below may be worth removing the TODO comments when you have filled them in, can then use them when coding to show you where sections of the code are which you still need to fill in


Naslova grafa ne moreš določiti s parametrom `title`, pač pa za to uporabiš funkcijo `ggtitle`, npr.
```R
zem1 <- ggplot() + geom_polygon(data = mst, aes(x=long, y=lat, group = group, fill=points),
                                color = "grey") + xlim(-10, 5) + ylim(35, 45) +
  scale_fill_continuous(low = "#69b8f6", high = "#142d45") + ggtitle("Spain")
```


How come this fix isn't showing up yet in production? Shouldn't method spec changes show up right away?
![screen shot 2016-01-19 at 5 03 28 pm](https://cloud.githubusercontent.com/assets/348704/12436965/9a1ca8cc-bece-11e5-9a37-b0e9763a086a.png)


I think I had a comment about this, and I remember you responding to it, but can't find it now.... this doesn't seem to be used anywhere.


Other than the above mentioned minor typos/corrections, looks good to me.


@sum2012 so there are three "levels" here:

CPU - 32 or 64 bit
OS - 32 or 64 bit
App - 32 or 64 bit

If the CPU is 32 bit, then the OS and App can only be 32 bit.  But if the CPU is 64 bit, then the OS can choose.

Most people shipping Intel phones are putting 32 bit Android on them - even when the CPU supports 64 bit.  And because the OS is 32 bit, the App can only be 32 bit.

So for this change to do anything, BOTH the CPU and OS must be 64 bit.  That's why @hrydgard said this:
https://github.com/hrydgard/ppsspp/issues/8325#issuecomment-167636744

It seems Remix OS is 64 bit, but it's a custom OS.

-[Unknown]


The variable naming is a bit weird here. It doesn't match what you did in +resolveInstanceMethod:. Why not use selname, settername instead setter_cstring?

Same for key_cstring, why not use propname?


TeamCity pull requests :: netty [Build 1062](https://garage.netty.io/teamcity/viewLog.html?buildId=4883&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4907, ignored: 23 Build time: 01:05:00


Why is this here? It's not used in the diff.


다음부턴 주의 하겠습니다 :dancers:


This is the same problem as #516, I think.
Setting `MSYS2_ARG_CONV_EXCL` avoids it.


strcmp(selname, propname) == 0, !strcmp(selname, propname) is confusing imo


@KasperFranz ancient gradle bug detected.


Same comment than previously


Overall the code is very good and functionality seems very good, the ability to flip between a graphical and command line interface is good and the encapsulation seems good. There is some extra whitespace which might make it easier to read if this was removed, if you put bits of relevant code together it can be easy to see. Sometimes there are extra comments left in, the code may be simpler if they were removed


I don't think Delimiter is exposed yet so, this would also need to be added to Type.


test


Not sure if you really care, but I already made a Mossbed texture a while ago. If you haven't made a texture yet, here you go: http://i.imgur.com/xSZQSUX.png


sss


UKIntsEqual(0, strcmp("setFoo:", setter) could be a bit better


Okay, feel free to add back


UKIntsEqual(0, strcmp("setFoo:", setter) could be a bit better here too


Oh, I should make this warning message more clear- this is only intended to guard against somehow running this helper with `rack_env` set to something other than `test`, since it truncates tables and whatnot. (e.g., i wanted to be extra sure something like `RAILS_ENV=production rake test` didn't somehow sneak in this code path and cause havoc).

It should still allow for running tests from developer workstations (since tests should get run in the `test` environment, even on developer workstations), this the handiest use-case as you mention. This may not have always been the case (or at least not consistently), which is what line 3 above (and consistent use of this helper) is supposed to address.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11989](https://teamcity.mesosphere.io/viewLog.html?buildId=108336&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:03:58


Just an English thing. I find the _NO at the end of this to be confusing. I would be inclined to just drop it and just us ALOGE_ERRNO  In general I find using no as abbreviation for number confusing, and prefer to use num. And since ERRNO already means error number, adding an additional "number" (abbreviated as _NO) at the end doesn't seem to add anything.


This is the same as getInput(), are they meant to have the same functionality


When concat any type value is not string, it will call meta __tostring automate.  so I think that is not necessary.


Yeah, so my original fix made this a public function. Then I saw Luke fixed the same problem, but I forgot to remove this prototype when I rebased my changes. I did remove this in a subsequent commit though.


Yup.


=== is better


Yes, the 'exported' flag is part of the decl bits, it's 'bit 3: the function is exported'.


@kuraga fixed, v1.2.1, https://github.com/zensh/route-trie/commit/ddf452dfbb0c53e4bdb22ddf80fc132cae41a5e4#diff-168726dbe96b3ce427e7fedce31bb0bcL17


### changes
- removed view-list-back.svg because we decided to use the simple view-list icon
- moved bowtie svg files out of version folder
- added icons for VSCOM
 - brand-visualstudio
 - brand-visualstudio-in-cloud
 - iot-chip
- added some drafts in wip files
- regenerated output files


It isn't really part of the B2G repository. Or did you mean the repo (the collection of 100 or so repositories that makes up B2G?)


imho, the problem wasn't the `unless`, it was the double negation.  When you're sticking something like `current_user` into an if- or unless- or whatever-clause, it automatically gets cast into a boolean, so there's no need for the double-negative.  (According to Jay's source, the problem is combining unless's with negation.)


I suppose commenting here means I ought to actually look at the rest of the code...


Stolpec, ki ga želiš, je `povprečna`.


@amis92 Oh, yeah, I just doubled it.

This is a band-aid solution I'm afraid (if it isn't obvious). The caching needs improvement (fixing, really) and we should probably move to taking snapshots of the GitHub data and actually storing it on AppEngine storage (rather than just keeping it in memory/cached), but... well, time.

We really need others to get in on maintaining the actual code here...


@peterborkuti, is this commit necessary?


nit: bits


nit: s/has/have


This whole encoding seems a stop-gap, so I think we might as well include it all so it's complete. We'll have to reconcile the differences later.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11994](https://teamcity.mesosphere.io/viewLog.html?buildId=108341&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:19


Sadly all the existing translations have to be updated :(


@palexander - Do you have time to look at these changes and tell me if you think they're reasonable?  It prevents display of a nested 404 error page where an ontology class tree is normally displayed.  You had suggested a change like this back in late October when we encountered an issue with a nested 404 error page getting rendered inside of a mappings table cell, which caused the whole UI to blank out.

![screenshot 2016-01-19 16 58 56](https://cloud.githubusercontent.com/assets/1696923/12437166/4441ad4c-bed0-11e5-9849-95f5bb075467.png)


Shouldn't be something like "where TDerived : Signal<TDerived>" to help users avoid some mistakes on the type ?


这会导致修改 `shadowsocks.conf`，应该好像是dnsmasq.conf吧
另外，刷了你2015-12-24版本DIR-505 A1固件，发现升级shadowsocks-libev_2.4.3到shadowsocks-libev_2.4.3-1后，不能翻墙了，求解决方法，谢谢!


please rename to "ignored"


done


@petester42 can we say it's by design of swift about the init & default value thing?


In line 30, you would want move to be evaluated first, the way you had it before.
Also, consider refactoring your getWinner() function using either switch case or ternary operator.

Overall GREAT job! Very clear! :100:


### changes
- added view-grid
- added auto-fill-template


nit: drop the second directly.


제거 부탁드립니다 앙~


Can you simplify this function? How about ternary operators?


Moved this discussion an existing similar PR - https://github.com/facebook/react-native/pull/4681


nit: drop the else


this check ==> config file existence


Are you going to push this latest version to npm?


109490574b-UnbalancedFlowWarning-4293-PlanB (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1508 of 1508 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1201](http://teamcity.monogame.net/viewLog.html?buildId=13789&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


check ===> ....


Thanks for catching. Fixed in a98d948a7d8d0583f7492c333a9b1756e323c4c0


Isn't the second if unreachable? I think you meant to make one of those 0.


The stylus test we've got in places is passing. Do you mean some other potential case? Could you demonstrate?


We don't do `#if` in the compiler.  Please do a runtime query based on the target.


Yeah this is true, that does help


When are you going to be pushing this latest version to Maven Central?


This looks great! Try reviewing the sections in the pre-work on ternary operators and switch cases and you could streamline your code a lot. I'd also like to see you try writing the playToX function. :+1:


@flibbles Now the filter only runs on nodes that are actually present in the map.


@Aeusman if your commit messages were more informative, that would help me.


Incorrect issue reference, this is part of issue #62.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11996](https://teamcity.mesosphere.io/viewLog.html?buildId=108343&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:09:00


fatalError() should be good enough, could we just use that directly without extra wrappers?

```
swift::fatalError("OpenProcess() failed")
```

seems equally clear to me.  If someone wants to know the caller, they are likely to need to start a debugger anyway.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11995](https://teamcity.mesosphere.io/viewLog.html?buildId=108342&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:10:19


I believe it is useful to have a test case that checks for an invalid uri


same as above, for test coverage we should test for invalid URIs still


can't fix the infamous com_maxfps lagscript though, but at least you can't move while doing that one


Don't think I agree with this change; we want to use the operation index when the request doesn't specify one or when the operation index is different to the request index.

In the case where the operation index is the same as the request index, it would be superfluous to send it through [as ES will use the request index](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-multi-search.html), so we can save a few bytes by not doing so


Overall this is a good start and I can see your logic.

a few pointers:
- Be careful with spacing/line breaks/etc so you don't lose track of your {}'s
- Think about how you could simplify some of your functions using ternary operators or switch cases.

Keep up the good work!


`swift::_swift_dl_iterate_phdr `, please.


Actually there are 3 down below testing several variations of invalid URI


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11992](https://teamcity.mesosphere.io/viewLog.html?buildId=108339&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:08


`if (!ProcHandle)`


Since it delegates to te same code in JmsFactory the 3 new tests above cover it


Please use a consistent naming style for variables: lowerCamelCase, like the rest of the runtime.


`fatalError` never returns, so no need to clean up.


:fu:
:fire:


Two spaces after `return`?  Please clang-format.


no u


Please pull in the failure path as a quick exit, to keep code straight-line:

```
if (!GetModule...) {
  fatalError(...);
}
```


genetic or generic?


这样修改虽然修复了 resize导致元素跳动的问题，但是同时拖拽元素的时候当鼠标脱离了元素就不能拖动了


Alternatively you could have uses [collection routes](http://guides.rubyonrails.org/routing.html#adding-collection-routes) to add this


[nits] 本サンプルが本利用になった場合はこのロードデータを別のfunctionにしたいですね


Files under optlib are translated into C code, so I don't have to think about them.
Units, @k-takata already worked #516.
This is about Tmain. I should do the same in Units.  units test harness set MSYS2_ARG_CONV_EXECL.
tmain should do the same.

@adoxa, thank you for updating the commit. I would like to take over your PR. Instead of updating the test cases, I would like to set MSYS2_ARG_CONV_EXECL as @k-takata did. I know well about Tmain test harness so I would like to take over this PR. Is it o.k.?


Hey! When you get back to this think about how you could use ternary operators and switch case statements to help streamline your code and take it to the next level. I'd like to see you polish this up and finish writing the playToFive function. :+1:


Similar comment to above


Is this a supported trick?


also we should talk about IterativeRobot vs CommandRobot
-thom


Would this ever fail in real cases?  If not, just `fatalError`.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11999](https://teamcity.mesosphere.io/viewLog.html?buildId=108351&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:09:47


Why not just implement the typical retry loop?


We should remove these two lines from this commit.


Yes, sorry I mixed this up with my Self-Aware Clone project.

Typo.....


this should be indented since its part of the `if`


@jadef <3


@lykkin :skull:


@olegz  - can you walk through the removal of this validator? I can understand the schema check being unnecessary, how about the expression language support? Should we have unit tests for the EL URI support?


DIR-505 SS文件修改成 sed -i 's/114.114.114.114/127.0.0.1#3210/...这样以后，在repeater模式下，如果上级路由能翻墙，此时停止DIR-505的SS能上国内网，但是不能翻墙。这个有办法解决吗？


same with above, need a white space here
```go
// Required. The effect of the taint, ref TaintEffect.
```


You could replace lines 31 and 32 with something like `for p in "$(dirname "$0")/../Testing/*.patch; do`.


This is great! I would challenge you to try writing your getWinner function in a way that's easier to read. It's not "wrong" but you could make it even better. I'd also like to see you push yourself even more and try writing the playToX function! :100:


LGTM.


@hawaii Looks like that profile image is broken. Is there another one you can provide a link to? Can also be from gravatar or any other stable hosting source.


This script checks for the existence of `./ds2` but then uses `/tmp/ds2`.


unnecessary empty line


Indeed. Thank you!


need to delete


Shouldn't this be >= ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12003](https://teamcity.mesosphere.io/viewLog.html?buildId=108355&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:03:58


wow


This is so clean, Great work! I want to push you to try simplifying your getWinner function and going for the playToX function. :100:


Hi, I noticed you dropped --parallel flags around the place - any particular reason for that? Thanks in advance


not bad


Closes #275.


It seems like you could move back these two lines to where they were before (line 24), and add `or os.getenv('LLGS_TESTS') == 1` to line 23. That would avoid adding this repo when we don't need it (all the Android/Tizen builds for instance).


# god job


I think this could be simplified to ```if (sizeof(addr->sun_path) < (NAME_OFFSET + siz)) {```


Note: I'd like to [dev with Meteor locally on my Android phone](https://github.com/meteor/meteor/issues/6033), but Android doesn't have `/usr`.


[IMO] 「GAME_OVER」に「GOAL」が入るのはちょっぴり違和感がありました。GAME_STATUSとかEND_STATUSとかなにかしら"ゲーム終了時の状態"とした変数名のがよいかもしれません。利用用途読み誤ってたらごめんなさい


nit: leading? or trailing?


Great use of the switch case! I would love to see you try writing the playToX function too. :100:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11998](https://teamcity.mesosphere.io/viewLog.html?buildId=108344&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:08:38


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11997](https://teamcity.mesosphere.io/viewLog.html?buildId=108345&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:08:52


I see that you're trying to make this script work for a dev environment (calling it multiple times in a row works), which is pretty cool. Maybe instead of checking for the existence of these directories and then using `cp -r` you can just do a single call to `rsync`, which would do both in one operation and might be a bit faster. You get the added benefit that if any one of these source directories is updated, the destination of the copy gets updated as well.


I love that you went for the extra credit and would love to see you try to simplify those if/else's in your getWinner function. Stellar job! :star2:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12001](https://teamcity.mesosphere.io/viewLog.html?buildId=108353&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:10:26


Not sure if I understand this 100% but is there a way to use ds2 directly from the build tree as we were doing before, or do we have to copy it to `/tmp`? Not copying seems cleaner in this case.


Add null check around ExoplayerWrapper in release method. Avoid
NullPointerException. Fixes issue #55
(#55)


sorry, more precisely, a test case that triggers a validation failure. There is still  ```addValidator(StandardValidators.URI_VALIDATOR)```


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1201](http://teamcity.monogame.net/viewLog.html?buildId=13789&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:28:03


diffs of diffs are horrible to review. I'm just gonna say this part of the change looks good :+1:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12004](https://teamcity.mesosphere.io/viewLog.html?buildId=108356&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:17


A really neat idiom!

May require a comment to explain what it does (I'll add it before merging).


> However, we can accommodate your Clojure logging framework by adding a public getter.

@ceki, @mattbishop: Can you suggest the best way to move forward with this please?

Perhaps using my proposed changes to `MDC.java` and `MarkerFactory.java`, but leaving the old `SINGLETON` fields public and non-deprecated would resolve your current objection to the PR?

Thanks again.


unnecessary break here.


辛苦了~赞一个！虽然姐姐眼瞎并不能看清~哈哈~


手稿很用心哦！加油！


You should use const refs. Also, it seems like it'd be better if both `host` and `port` were strings, instead of having one string and one int, as `Socket::connect` translates back the port to a string later on to be able to call `getaddrinfo`.

<persnickety>Also, in theory, a user could specify something like `localhost:http` which would then be resolved to port 80. IIRC, on Linux, the translation data between service name and numeric port is in `/etc/services`.</persnickety>


Right. The hash marks indicate a heading level. So under the major heading Questions, there is a question which can then have an answer as the text for the section. Like a FAQ.

View the README in github to see how the formatting works.


I went ahead and shipped it now, so it should be on Maven Central in a few hours.


Fragile indeed, but also necessary. The whole point of this effort is having stateful layout. The upside is dynamically creating layouts. The downside is housekeeping of the state instead of creating a new one each time. I will try to improve this to address your concerns.


shekhar:1st june


@adam3smith It surprised me too when I was researching for the Spanish locale and discovered it. According to the RAE (Real Academia Española de la Lengua, www.rae.es ), that is the only correct way for abbreviations:
- REAL ACADEMIA ESPAÑOLA, _Diccionario panhispánico de dudas_, 2005. "ORDINALES", § 8. (on line in http://lema.rae.es/dpd/?key=ordinales )
- REAL ACADEMIA ESPAÑOLA, _Ortografía de la lengua española_, 2010, Cap. V. § 3.3.2b: "**no debe omitirse nunca el punto abreviativo que ha de preceder a las letras voladas dentro de la abreviatura.**" p. 572. (on-line is not easy to find the exact page, go to http://aplica.rae.es/orweb/cgi-bin/buscar.cgi and search the words: "no debe omitirse nunca" )


Should we add a new feed builder like the blog has at the same time?


Hi, Ads are now loading from Inmobi, but its loading on Top my listview, but it has to load on bottom, and also i could not scroll, while Inmobi ads are shown.

Layout:-

<?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    xmlns:wheel="http://schemas.android.com/apk/res-auto"
    android:background="@android:color/transparent"
    android:orientation="vertical">

    <FrameLayout
        android:layout_width="match_parent"
        android:layout_height="match_parent">

        <ListView
            android:id="@+id/newsList"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:divider="@drawable/list_divider"
            android:dividerHeight="1dp"
            android:background="@android:color/transparent" />

        <com.pnikosis.materialishprogress.ProgressWheel
            android:id="@+id/progress_wheel"
            android:layout_width="80dp"
            android:layout_height="80dp"
            android:layout_gravity="center"
            wheel:matProg_barColor="#5588FF"
            wheel:matProg_progressIndeterminate="true" />

    </FrameLayout>

    <RelativeLayout
        android:id="@+id/adContainer"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_alignParentBottom="true"
        android:layout_centerHorizontal="true" />

</RelativeLayout>


Ok, great idea, but max twit length is 140 bytes (in English this should be the same number of characters), current message has 100 characters, so we cannot put information about 2 presentation in single twit


Let's not save them as separate keys in brain. What I have in mind is a key that contains a JSON having all of this.


Alright, I did some testing, and it looks like we can simply **remove** both of the `internal` methods in `DbContextExtensions`.  They are only needed if they were public and we want to call `context.ApplyChanges`, passing a list of interceptors.  Without this need, they should be removed.

If you feel differently, then please provide some tests demonstrating your case. :wink:


@josepjaume I used the singleton resource approach, what do you think?


wat


@ptomin: please test this to see if your issue goes away and communicate to me the results.


Now it should work.


As We discussed, The cookie shoud be passed as an env variable and this cookie should be invalidated


Ahh I see... Let's then stick with the current solution. Anyway, we should can that a particular twit/tweet is "publishable" - i.e. it contains only allowed characters and fits the max length.


Same Here


Fixed.


Ok I already understand these, and agreed that it is a security flaw. Thanks for fixing it. From the way it was implemented, as long as we pushed the user id check to the mayEditComment() method, it would be enough to fix the issue to a large extent.  Of course removing the subscription on discussions was also necessary.
As a side note next time we should **really** avoid assigning a task that already requires a reimplementation of the existing erroneous code (like the editing of comments), and spending hours reimplementing the task, only to discover that the issues from the first version are still persisting and having to reimplement everything again. This ends up in spending double time time on issues like this, so I suggest that whoever started working on a feature/issue in the first place, should finish it or clear it completely, even if this delays finalizing the issue.


`this.` won't be needed here after renaming the member variable to `_selector`.


@slawekPL Could you create a Pull Request today? Then I will be able to show running system tomorrow. We'll fix the bugs/miss things later - it is nice to have something working...


Is that a test for builtin `file` (a.k.a. open()) or a misnamed variable?


TeamCity LabKey :: LabkeyModules15.3 :: Git postgres 9.4 [Build 93](https://teamcity.labkey.org/viewLog.html?buildId=298148&buildTypeId=LabkeyModules153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 18 (1 new), passed: 275, muted: 1 Build time: 01:49:12
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.tests.CDSLoginTest.testSessionTimeoutIntercept: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStickyFinderFilterOnDataset: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

##### there are 8 more failed tests, see build details
```


Hello Swift ^_^


{{ site.owner.google.analytics }}


looks good, but shouldn't it go into Styles.cs? I think we have more places where alpha is applied on disabled icons.


I realize now that the non-generic version is not needed, because only one selector is stored per `StateChangeInterceptor`.  My bad. :blush:


@harshadyeola Why not use _scripts.html instead of creating new file ?


test


За такое я бы пиздил :)


As discussed, this is fine. However, would be nice to put a comment. This is racy, and it would be possible to avoid that, but it is not really worth it in this case. To avoid any race we would need a callback that would wait for the _get_setup_state() to return something else than "pending" and -ENODATA, and only then do `return strcmp(state, "unmanaged");`. In this case, if we allow NM (or whatever) to apply settings to a link which is later taken over by networkd, we will simply drop that config again, so there is no problem applying stuff eagerly.


this line should be std::string langId(LangId langName)


Created by SNACHEVA KSENIA, SEREBRENNIKOVA ALEXANDRA, FILATOV STEPAN


The only major issue that may remain is the removal of the `internal` methods from `DbContextExtensions`.  Once that is resolved and the other changes are made, we should be able to merge the PR. :relieved: