After using your script, I installed OpenVPN and got both working from the same server. Everything seems fine, but I'm always a little paranoid about security.

I'm not good at understanding Iptables.Could you tell me if my UFW and Iptables setup looks fine after the setup. I used your script before you added fail2ban, btw. Also, I'm using a non-standard SSH port. Thank you so much for this script. I spent forever trying to do this before I found this solution.

    $ sudo ufw status verbose
    Status: active
    Logging: on (low)
    Default: deny (incoming), allow (outgoing), allow (routed)
    New profiles: skip

    To                         Action      From
    --                         ------      ----
    22313                      LIMIT IN    Anywhere
    1194/udp                   ALLOW IN    Anywhere
    500                        ALLOW IN    Anywhere
    4500                       ALLOW IN    Anywhere
    22313 (v6)                 LIMIT IN    Anywhere (v6)
    1194/udp (v6)              ALLOW IN    Anywhere (v6)
    500 (v6)                   ALLOW IN    Anywhere (v6)
    4500 (v6)                  ALLOW IN    Anywhere (v6)

Here are my IPtables results

    $ sudo iptables -S
    -P INPUT DROP
    -P FORWARD ACCEPT
    -P OUTPUT ACCEPT
    -N ICMPALL
    -N fail2ban-courierauth
    -N fail2ban-couriersmtp
    -N fail2ban-dovecot
    -N fail2ban-dropbear
    -N fail2ban-pam-generic
    -N fail2ban-postfix
    -N fail2ban-sasl
    -N fail2ban-ssh
    -N fail2ban-ssh-ddos
    -N ufw-after-forward
    -N ufw-after-input
    -N ufw-after-logging-forward
    -N ufw-after-logging-input
    -N ufw-after-logging-output
    -N ufw-after-output
    -N ufw-before-forward
    -N ufw-before-input
    -N ufw-before-logging-forward
    -N ufw-before-logging-input
    -N ufw-before-logging-output
    -N ufw-before-output
    -N ufw-logging-allow
    -N ufw-logging-deny
    -N ufw-not-local
    -N ufw-reject-forward
    -N ufw-reject-input
    -N ufw-reject-output
    -N ufw-skip-to-policy-forward
    -N ufw-skip-to-policy-input
    -N ufw-skip-to-policy-output
    -N ufw-track-forward
    -N ufw-track-input
    -N ufw-track-output
    -N ufw-user-forward
    -N ufw-user-input
    -N ufw-user-limit
    -N ufw-user-limit-accept
    -N ufw-user-logging-forward
    -N ufw-user-logging-input
    -N ufw-user-logging-output
    -N ufw-user-output
    -A INPUT -p tcp -m multiport --dports 25,465,587,143,220,993,110,995 -j fail2ban-courierauth
    -A INPUT -p tcp -m multiport --dports 22 -j fail2ban-ssh-ddos
    -A INPUT -p tcp -m multiport --dports 25,465,587 -j fail2ban-postfix
    -A INPUT -p tcp -m multiport --dports 25,465,587,143,220,993,110,995 -j fail2ban-dovecot
    -A INPUT -p tcp -m multiport --dports 25,465,587,143,220,993,110,995 -j fail2ban-sasl
    -A INPUT -p tcp -m multiport --dports 25,465,587 -j fail2ban-couriersmtp
    -A INPUT -p tcp -m multiport --dports 22 -j fail2ban-dropbear
    -A INPUT -p tcp -j fail2ban-pam-generic
    -A INPUT -p tcp -m multiport --dports 22 -j fail2ban-ssh
    -A INPUT -p udp -m udp --dport 1194 -j ACCEPT
    -A INPUT -m conntrack --ctstate INVALID -j DROP
    -A INPUT -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT
    -A INPUT -i lo -j ACCEPT
    -A INPUT -p icmp -m icmp --icmp-type any -j ICMPALL
    -A INPUT -p udp -m udp --sport 67:68 --dport 67:68 -j ACCEPT
    -A INPUT -p tcp -m tcp --dport 22313 -j ACCEPT
    -A INPUT -p udp -m multiport --dports 500,4500 -j ACCEPT
    -A INPUT -p udp -m udp --dport 1701 -m policy --dir in --pol ipsec -j ACCEPT
    -A INPUT -p udp -m udp --dport 1701 -j DROP
    -A INPUT -j DROP
    -A INPUT -j ufw-before-logging-input
    -A INPUT -j ufw-before-input
    -A INPUT -j ufw-after-input
    -A INPUT -j ufw-after-logging-input
    -A INPUT -j ufw-reject-input
    -A INPUT -j ufw-track-input
    -A FORWARD -m state --state RELATED,ESTABLISHED -j ACCEPT
    -A FORWARD -s 10.8.0.0/24 -j ACCEPT
    -A FORWARD -m conntrack --ctstate INVALID -j DROP
    -A FORWARD -i eth+ -o ppp+ -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT
    -A FORWARD -i ppp+ -o eth+ -j ACCEPT
    -A FORWARD -j DROP
    -A FORWARD -j ufw-before-logging-forward
    -A FORWARD -j ufw-before-forward
    -A FORWARD -j ufw-after-forward
    -A FORWARD -j ufw-after-logging-forward
    -A FORWARD -j ufw-reject-forward
    -A FORWARD -j ufw-track-forward
    -A OUTPUT -j ufw-before-logging-output
    -A OUTPUT -j ufw-before-output
    -A OUTPUT -j ufw-after-output
    -A OUTPUT -j ufw-after-logging-output
    -A OUTPUT -j ufw-reject-output
    -A OUTPUT -j ufw-track-output
    -A ICMPALL -p icmp -f -j DROP
    -A ICMPALL -p icmp -m icmp --icmp-type 0 -j ACCEPT
    -A ICMPALL -p icmp -m icmp --icmp-type 3 -j ACCEPT
    -A ICMPALL -p icmp -m icmp --icmp-type 4 -j ACCEPT
    -A ICMPALL -p icmp -m icmp --icmp-type 8 -j ACCEPT
    -A ICMPALL -p icmp -m icmp --icmp-type 11 -j ACCEPT
    -A ICMPALL -p icmp -j DROP
    -A fail2ban-courierauth -j RETURN
    -A fail2ban-couriersmtp -j RETURN
    -A fail2ban-dovecot -j RETURN
    -A fail2ban-dropbear -j RETURN
    -A fail2ban-pam-generic -j RETURN
    -A fail2ban-postfix -j RETURN
    -A fail2ban-sasl -j RETURN
    -A fail2ban-ssh -j RETURN
    -A fail2ban-ssh-ddos -j RETURN
    -A ufw-after-input -p udp -m udp --dport 137 -j ufw-skip-to-policy-input
    -A ufw-after-input -p udp -m udp --dport 138 -j ufw-skip-to-policy-input
    -A ufw-after-input -p tcp -m tcp --dport 139 -j ufw-skip-to-policy-input
    -A ufw-after-input -p tcp -m tcp --dport 445 -j ufw-skip-to-policy-input
    -A ufw-after-input -p udp -m udp --dport 67 -j ufw-skip-to-policy-input
    -A ufw-after-input -p udp -m udp --dport 68 -j ufw-skip-to-policy-input
    -A ufw-after-input -m addrtype --dst-type BROADCAST -j ufw-skip-to-policy-input
    -A ufw-after-logging-input -m limit --limit 3/min --limit-burst 10 -j LOG --log-prefix "[UFW BLOCK] "
    -A ufw-before-forward -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT
    -A ufw-before-forward -p icmp -m icmp --icmp-type 3 -j ACCEPT
    -A ufw-before-forward -p icmp -m icmp --icmp-type 4 -j ACCEPT
    -A ufw-before-forward -p icmp -m icmp --icmp-type 11 -j ACCEPT
    -A ufw-before-forward -p icmp -m icmp --icmp-type 12 -j ACCEPT
    -A ufw-before-forward -p icmp -m icmp --icmp-type 8 -j ACCEPT
    -A ufw-before-forward -j ufw-user-forward
    -A ufw-before-input -i lo -j ACCEPT
    -A ufw-before-input -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT
    -A ufw-before-input -m conntrack --ctstate INVALID -j ufw-logging-deny
    -A ufw-before-input -m conntrack --ctstate INVALID -j DROP
    -A ufw-before-input -p icmp -m icmp --icmp-type 3 -j ACCEPT
    -A ufw-before-input -p icmp -m icmp --icmp-type 4 -j ACCEPT
    -A ufw-before-input -p icmp -m icmp --icmp-type 11 -j ACCEPT
    -A ufw-before-input -p icmp -m icmp --icmp-type 12 -j ACCEPT
    -A ufw-before-input -p icmp -m icmp --icmp-type 8 -j ACCEPT
    -A ufw-before-input -p udp -m udp --sport 67 --dport 68 -j ACCEPT
    -A ufw-before-input -j ufw-not-local
    -A ufw-before-input -d 224.0.0.251/32 -p udp -m udp --dport 5353 -j ACCEPT
    -A ufw-before-input -d 239.255.255.250/32 -p udp -m udp --dport 1900 -j ACCEPT
    -A ufw-before-input -j ufw-user-input
    -A ufw-before-output -o lo -j ACCEPT
    -A ufw-before-output -m conntrack --ctstate RELATED,ESTABLISHED -j ACCEPT
    -A ufw-before-output -j ufw-user-output
    -A ufw-logging-allow -m limit --limit 3/min --limit-burst 10 -j LOG --log-prefix "[UFW ALLOW] "
    -A ufw-logging-deny -m conntrack --ctstate INVALID -m limit --limit 3/min --limit-burst 10 -j RETURN
    -A ufw-logging-deny -m limit --limit 3/min --limit-burst 10 -j LOG --log-prefix "[UFW BLOCK] "
    -A ufw-not-local -m addrtype --dst-type LOCAL -j RETURN
    -A ufw-not-local -m addrtype --dst-type MULTICAST -j RETURN
    -A ufw-not-local -m addrtype --dst-type BROADCAST -j RETURN
    -A ufw-not-local -m limit --limit 3/min --limit-burst 10 -j ufw-logging-deny
    -A ufw-not-local -j DROP
    -A ufw-skip-to-policy-forward -j ACCEPT
    -A ufw-skip-to-policy-input -j DROP
    -A ufw-skip-to-policy-output -j ACCEPT
    -A ufw-track-forward -p tcp -m conntrack --ctstate NEW -j ACCEPT
    -A ufw-track-forward -p udp -m conntrack --ctstate NEW -j ACCEPT
    -A ufw-track-output -p tcp -m conntrack --ctstate NEW -j ACCEPT
    -A ufw-track-output -p udp -m conntrack --ctstate NEW -j ACCEPT
    -A ufw-user-input -p tcp -m tcp --dport 22313 -m conntrack --ctstate NEW -m recent --set --name DEFAULT --mask 255.255.255.255 --rsource
    -A ufw-user-input -p tcp -m tcp --dport 22313 -m conntrack --ctstate NEW -m recent --update --seconds 30 --hitcount 6 --name DEFAULT --mask 255.255.255.255 --rsource -j ufw-user-limit
    -A ufw-user-input -p tcp -m tcp --dport 22313 -j ufw-user-limit-accept
    -A ufw-user-input -p udp -m udp --dport 22313 -m conntrack --ctstate NEW -m recent --set --name DEFAULT --mask 255.255.255.255 --rsource
    -A ufw-user-input -p udp -m udp --dport 22313 -m conntrack --ctstate NEW -m recent --update --seconds 30 --hitcount 6 --name DEFAULT --mask 255.255.255.255 --rsource -j ufw-user-limit
    -A ufw-user-input -p udp -m udp --dport 22313 -j ufw-user-limit-accept
    -A ufw-user-input -p udp -m udp --dport 1194 -j ACCEPT
    -A ufw-user-input -p tcp -m tcp --dport 500 -j ACCEPT
    -A ufw-user-input -p udp -m udp --dport 500 -j ACCEPT
    -A ufw-user-input -p tcp -m tcp --dport 4500 -j ACCEPT
    -A ufw-user-input -p udp -m udp --dport 4500 -j ACCEPT
    -A ufw-user-limit -m limit --limit 3/min -j LOG --log-prefix "[UFW LIMIT BLOCK] "
    -A ufw-user-limit -j REJECT --reject-with icmp-port-unreachable
    -A ufw-user-limit-accept -j ACCEPT


We should also describe what happens if you call the API after the runtime has already started up.


accept


Capitalize names!


Lol


When you made your Minecraft Realm piano, did you actually read the thing they said to?


Looks like I spelt "canola" correctly!


I doubt it. I don't remember them telling me to.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11517](https://teamcity.mesosphere.io/viewLog.html?buildId=104848&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:04:02


I thought this was used for the number of stats counters, no?


I actually read it. It has a lot of annoying things, like the fact that you can't make any money for yourself using the server or for donations to the server.


This thread startup feels like something the RuntimeStartupHelper would handle within the call to Register. This forces the caller to know considerable detail about the implementation specifics of RuntimeStartupHelper.


Benchmark: https://gist.github.com/jirutka/cc271b3cdd2b65bf6b32


Отлично. Осталось ещё русские символы в форме для сообщений


Oh, if you're talking about the EULA, then yeah i've probably read it.


Oh okay.


this still isn't right. If the field schema is a nullable long for example, it will be seen as valid. It should be something like:

```
Schema fieldSchema = inputSchema.getField(fieldName).getSchema();
boolean fieldIsNullable = fieldSchema.isNullable();
if (!isNullable && fieldIsNullable) {
  throw new IllegalArgumentException("Field x cannot be nullable");
}
Schema.Type fieldType = fieldIsNullable ? fieldSchema.getNonNullable() : fieldSchema.getType();
if (fieldType != Schema.Type.STRING && fieldType != Schema.Type.BYTES) {
...
```


已解决


@dinohu 已解决


better to get the type once. More readable and avoids extra lookups


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11519](https://teamcity.mesosphere.io/viewLog.html?buildId=104858&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:00:44


Hrm... well, if it's changed to ALSA=${ALSA:-YES} as well, then it will continue to work with Alsa just fine assuming the system is configured properly. Not sure why I disabled alsa support in that commit - I suppose I should blame my autopilot mode :/

That said, I do think that everyone should settle down a bit and at least give PA a fair chance. I know, I know - "I tried it $time ago" and "I didn't like it in $other_distro" and whatever, but here's the deal: I didn't like the idea of even considering it either. It was with a very defeated attitude that even decided to look at it. However, after I got it all built and installed, with very little configuring (the /etc/asound.conf, which we provided for you, so there's no need to even research it), everything just worked. No fuss, no headache, just work. I had per-app volume control for the first time ever, and I could even turn my sound up to over 100%, which is a really good thing for these laptop speakers -- I can actually hear them now. None of us in our tested discovered *anything* that was at least as good as with alsa, and in many cases, it's better. I can assure you that we were actively looking for reasons to NOT include PA.

The point is this: you've trusted the Slackware team (primarily Pat, but also me and Eric and Heinz and the others) for a long time now, maybe just give us the benefit of the doubt and at least give *our* integration of PA a try. If you still don't like it, then let us know why and maybe we can fix it, but even if not, at least you'll have a valid reason for opposing it then.


Looks good,

the name arg help message should be updated, and flake8 points out a few style nits. I'll just add a follow up patch.

Thanks for the patch.


@daejunpark, please confirm this is the right way to add a negative test using your bash trick. thanks!


We should probably describe the exact synchronization semantics of this API relative to the callback. For example can it be called on the callback thread or not? Does it block until the callback is complete? Are you guaranteed no callbacks will be initiated after this function returns?


学习一下gson库，自己拼json不太好哦


コマンドラインから投稿してみた。


the last time I read terms for any programs OS's or anything was never

On 1/13/2016 8:42 PM, pianoman373 wrote:
>
> it's not that long. I've read probably half of it.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/TEAMModding/KalStuff/commit/56257d479f46fbed4ce613ea89b3b43349dccdcb#commitcomment-15440243>.
>


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11518](https://teamcity.mesosphere.io/viewLog.html?buildId=104853&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:03:51


BookMarkAdd这种类放在controller里的原因是什么？


コマンドラインから投稿してみた。
改行もしてみた。


if val is null, you can't call Bytes.toBytes() on it or it will throw a NPE


コマンドラインから投稿してみた。
改行もしてみた。
このコミットに関連するタスク
https://www.wrike.com/open.htm?id=73747707
https://www.wrike.com/open.htm?id=73747707


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11520](https://teamcity.mesosphere.io/viewLog.html?buildId=104859&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:03:59


get the type once, will make it more readable and avoid extra lookups


Thanks, @gparker42!


I was able to read ubuntu's privacy policy. It was like less than one page.

> On Jan 13, 2016, at 8:53 PM, ParkerMc01 <notifications@github.com> wrote:
>
> the last time I read terms for any programs OS's or anything was never
>
> On 1/13/2016 8:42 PM, pianoman373 wrote:
> >
> > it's not that long. I've read probably half of it.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/TEAMModding/KalStuff/commit/56257d479f46fbed4ce613ea89b3b43349dccdcb#commitcomment-15440243>.
> >
>
> —
> Reply to this email directly or view it on GitHub.
>


Joshua Teel


Gah, I need to get back into ricing. Amazing stuff, mate!


Git flow link missing.


Numbering is wrong


Oops, thanks!


FYI, you could also use `7.days.ago` here.  I actually prefer that as it will use `ActiveSupport::TimeWithZone` which will handle some time zone issues better.


it is not just copying and pasting if you start to make a file named
LICENSE on the web gui it has temples that you can choose.

On 1/13/2016 8:35 PM, pianoman373 wrote:
>
> Yeah, I just didn't think copying and pasting the document would make
> your software subject to those rules, without having to register a
> copyright or something.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/TEAMModding/KalStuff/commit/56257d479f46fbed4ce613ea89b3b43349dccdcb#commitcomment-15440181>.
>


unused


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (954 of 954 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.64%25-green.svg)


Clearly not :)


Both true.


Tu peux retirer le ``class="change-page"`` qu'on peut cibler via ``.next_page a`` et ``.previous_page a``.


Eckvitrine?!? :joy:


@leolux I'm confused. I don't seen the connection between the commit you commented and your comment. So I can only guess what you want to ask me. Do you want to know why we don't use the relaxed syntax in the starter template, or why we don't use it generally in the showcase?

Well, the answer is simple: most IDEs don't support the relaxed syntax. NetBeans, in particular, marks the relaxed syntax as erroneous (at least I'm told so). I don't see any point in annoying developers who love such a restrictive IDE, so I reluctantly use the ceremonious syntax.


Think :test-paths at the top level is for clojure instead of clojurescript. Maybe should change to ["spec/clj"] instead of ["spec/cljs"]


BT works fine for me now thanks again.


good call!


Probably can remove clojurescript.test from plugins


It's better to avoid having a null DataType. Mule 3.x is using a Object DataType when there's NullPayload. It seems better to use that instead of having to work with special cases for null DataType.


Anyway, that's a different problem; experiments should be able to log a long single-word message and it should be displayed correctly. What is Qt's rationale for not wrapping words that cannot fit? Right now they can never be fully displayed (and the other columns are broken) which is pretty stupid. Also, it seems to me that the column breakage also occurs intermittently in other situations.

What if the widget is too small to display a 30-character word?


nice and clean


As it stands
```
[
    '\nN\n',
    'q609\n',
    'Q203,26\n',
    ...
]
```
will _not_ be resolved, but
```
[
    { data: '\nN\n' },
    { data: 'q609\n' },
    { data: 'Q203,26\n' },
    ...
]
```
will be.
A bit of an oversight on my part. Fixed with 4b3364532631d6d5d047033464f1ccfccbe01033


'orgc' doesn't exist in the MYSQL.sql file (recently updated line 112). I solved a sql request error I got when i use filter by replacing 'orgc' by 'orgc_id'.


fixed


It is overly complex if you ask me too.


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (951 of 951 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.84%25-green.svg)


To be honest, neither do I ;-)

However, the configuration section is not valid in the pluginExecutionFilter. By looking at the commit where that was added, I'm sure it was copied from the actual configuration of the maven-hpi-plugin. Here, instead,  we're in the part where we exclude the goals of that plugin from the lifecycle of m2e. Similarly, we need to exclude the hpi goal otherwise m2e will complain about that.

Summarizing, this patch is needed to import successfully this maven project into Eclipse, it has nothing to do with the build itself.


I would suggest embedding commons-collections instead of importing it.


WOW.... THANK YOU SO MUCH!!!!  I love your review. You know.... I totally forgot to do a pass even of the spell corrector...what a shame!

Thank you!


thanks for including this. just a question... if the js code is to be inlined in index.html like that, shouldn't you delete the scripts/main.js? as it is now the js code is duplicated.


I did not need these 3 imports for the embedded provider. Did you try the external provider without them?  It might require them unlike embedded Solr.


Because jpg is best for images with lots of colours. Png is more suited to few-colour images, like icons.


now that we have this setter, could you make the dynamic reconfigure callback use it? That way if we do something special here when we set we'll catch the change no matter where the source is.


I know we are already checking for muleContext == null in a prexistent line of code. It seems to me that allowing null muleContext as parameter can lead to hide bugs in the code. Perhaps have two methods? Or Optional<MuleContext> as parameter?


Nice going mister!


Return the status of run_command, not the rm_rf


@jmwohl I don't know how to integrate this with the `src/` vs `dist/` stuff that happens...


On Thu, Jan 14, 2016 at 03:00:35AM -0800, Christian Brauner wrote:
> I suggest that `should_default_to_snapshot()` simply take another argument `char  *bdevtype` and we check if it actually is `btrfs` and bail if not. `copy_storage()` calls `should_default_to_snapshot()` and itself takes an argument `bdevtype` so we can just hand it down to `should_default_to_snapshot()`. I have two trivial fixes for `lxcbtrfs.c` and `lxcoverlay.c` in line (but that bug me).  If you're ok with this I'll just combine my trivial fixes with this.

Sounds good - thanks.


the place to change it is really at https://github.com/wafflejs/wafflejs.github.io/blob/master/index.css#L45


I wasn't able to break the columns even without my fix (Qt 5.5.1 here).

Qt's generic solution to overlong words is elision. Where do it sensible to wrap overlong words? With your example it seems like putting a ZWSP before every _ is the right choice, for example.

If it's too small to display a 30-character word then none of the logs are going to be readable anyway. What happens is the long words not being drawn at all rather than any of the columns being squashed under their minimum size.


@pmwmedia :+1: This would have been my next feedback, as I just encountered a situation where the new behaviour is desirable. Tested with 2.0.0-SNAPSHOT, working nicely. So thanks for addressing this even before I opened an issue ;-)


Shouldn't you throw a ResourceDoesNotSupportOperationException here?


Thanks. My mind is at ease now. :smile:


these have to match the envs in your deploy environment that you want in your pods enviroment


We used to check if the dir_num is nil to determine if this team has submitted any file or not. This is problematic because that the user can submit a file and then delete it. In this case this team is still holding a dir_num, but actually the folder is empty. If so, this team should be able to switch topic.


Should this be moved to emerald/scss/_settings.scss?


@gcapalbo This migration is blocking also on fresh installs (where presumably it's not relevant).  Would it be difficult to make this pass for new hq environments?


Don't all other packages that use binaries download them as a build step? Seems a bit strange to have building and installing as different steps imho.


Great, good to know that. I'll update it.


Rollback to messaging exception


These are just intermediate steps towards the final mule message vision. All I did was adding an overload which allows passing a MuleContext. How to handle these cases are outside the scope of this PR


TeamCity pull requests :: netty [Build 1035](https://garage.netty.io/teamcity/viewLog.html?buildId=4755&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6372, ignored: 23 Build time: 00:42:57


TeamCity pull requests :: netty [Build 1036](https://garage.netty.io/teamcity/viewLog.html?buildId=4756&buildTypeId=pulls_netty&guest=1) is now running


Start with an empty log, do not resize the log widget, and run the #187 example. Breaks the columns here with 5.5.1.


Ничего страшного :)


Серьезный такой коммит...


OK.  I see.  Thanks.

-----------------------------
Pablo Velasco, Ph.D.
Senior Research Scientist
Center for Brain Imaging
New York University
6 Washington Place, Room 156
New York, NY 10003
Lab: (212) 992-8748
Fax: (212) 995-4570
-----------------------------

On Thu, Jan 14, 2016 at 2:14 PM, Michael Hansen <notifications@github.com>
wrote:

> I know, but that this the syntax. It is not pretty, but we didn't make it.
>
> https://cmake.org/cmake/help/v3.0/command/if.html
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gadgetron/gadgetron/commit/c39d2f42dfdfbaeb255325b69893e3504dc722b6#commitcomment-15458369>
> .
>


That been said, when we add support for hte new MuleMessage in SDK I will control this case so that if the message has a null dataType I will maintain the message current one.


[R/feature_ignore_singletons.R:37:15:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/feature_ignore_singletons.R#L37) *style:* **Commas should never have a space before.**
```r
    segsites[ , !is_singleton]
             ~^
```
[R/feature_ignore_singletons.R:48:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/feature_ignore_singletons.R#L48) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_msms_arg.ign_singletons <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_ignore_singletons.R:52:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/feature_ignore_singletons.R#L52) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_scrm_arg.ign_singletons <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_ignore_singletons.R:56:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/feature_ignore_singletons.R#L56) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_seqgen_arg.ign_singletons <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_mutation.R:140:9:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/feature_mutation.R#L140) *style:* **Commented code should be removed.**
```r
#       model <- addFeature(model, "gamma.categories", parameter=categories.number)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_mutation.R:143:7:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/feature_mutation.R#L143) *style:* **Commented code should be removed.**
```r
#     return(model)
      ^~~~~~~~~~~~~
```
[R/feature_mutation.R:152:5:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/feature_mutation.R#L152) *style:* **Commented code should be removed.**
```r
#   model <- addFeature(model, 'mutation', parameter = middle_rate, group = group)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_recombination.R:47:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/feature_recombination.R#L47) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_seqgen_arg.recombination <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_selection.R:178:36:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/feature_selection.R#L178) *style:* **Commas should never have a space before.**
```r
                        n_pop, " " , paste(start_freq, collapse = " "), " ",
                                  ~^
```
[R/feature_selection.R:191:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/feature_selection.R#L191) *style:* **lines should not be more than 80 characters.**
```r
                         ifelse(feature$get_start(), 0, feature$get_time()), ", ",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_selection.R:202:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/feature_selection.R#L202) *style:* **lines should not be more than 80 characters.**
```r
                         ifelse(feature$get_start(), 0, feature$get_time()), ", ",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_sumstats.R:18:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/feature_sumstats.R#L18) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_msms_arg.seg_sites_feat <- conv_to_ms_arg.seg_sites_feat
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_sumstats.R:22:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/feature_sumstats.R#L22) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_scrm_arg.seg_sites_feat <- conv_to_ms_arg.seg_sites_feat
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_sumstats.R:26:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/feature_sumstats.R#L26) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_seqgen_arg.seg_sites_feat <- conv_to_ms_arg.seg_sites_feat
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/import_popgenome.R:17:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/import_popgenome.R#L17) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.segsites.GENOME <- function(data, only_synonymous = FALSE, ...) {
^~~~~~~~~~~~~~~~~~
```
[R/import_popgenome.R:41:43:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/import_popgenome.R#L41) *style:* **Commas should never have a space before.**
```r
      seg_sites <- bam[c(pops, outgroup), , drop = FALSE]
                                         ~^
```
[R/model_getters.R:74:21:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/model_getters.R#L74) *style:* **Commas should never have a space before.**
```r
  if (sum(llm[group , c(1:2, 4:5)]) == 0) return(llm[group , 3])
                   ~^
```
[R/model_getters.R:74:60:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/model_getters.R#L74) *style:* **Commas should never have a space before.**
```r
  if (sum(llm[group , c(1:2, 4:5)]) == 0) return(llm[group , 3])
                                                          ~^
```
[R/model_getters.R:81:25:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/model_getters.R#L81) *style:* **Commas should never have a space before.**
```r
  min(which(cumsum(llm[ , "number"]) >= locus))
                       ~^
```
[R/model_getters.R:124:46:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/model_getters.R#L124) *style:* **Commas should never have a space before.**
```r
  numbers <- get_locus_length_matrix(model)[ , "number"]
                                            ~^
```
[R/model.R:93:39:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/model.R#L93) *style:* **Commas should never have a space before.**
```r
  sum(get_locus_length_matrix(model)[ , c(1:2, 4:5)]) > 0
                                     ~^
```
[R/model_simulate.R:36:3:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/model_simulate.R#L36) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  }, mc.set.seed = TRUE, mc.cores = cores)
  ^
```
[R/parameter.R:132:11:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/parameter.R#L132) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      if ((!is.numeric(value)) || length(value) != 1) {
          ^
```
[R/segsites.R:18:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/segsites.R#L18) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.matrix.segsites <- function(x, ...) get_snps(x)
^~~~~~~~~~~~~~~~~~
```
[R/segsites.R:31:19:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/segsites.R#L31) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  create_segsites((matrix(c(1, 1, 0, 1, 1,
                  ^
```
[R/segsites.R:96:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/segsites.R#L96) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.segsites.default <- function(data, ...) {
^~~~~~~~~~~~~~~~~~~
```
[R/segsites.R:101:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/segsites.R#L101) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.segsites.list <- function(data, ...) {
^~~~~~~~~~~~~~~~
```
[R/simulator_class.R:55:3:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/simulator_class.R#L55) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  }, character(1L))
  ^
```
[R/simulator_class.R:67:44:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/simulator_class.R#L67) *style:* **Commas should never have a space before.**
```r
  grouped_commands <- unique(sim_commands[ , 2])
                                          ~^
```
[R/simulator_class.R:70:36:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/simulator_class.R#L70) *style:* **Commas should never have a space before.**
```r
    sum(sim_commands[sim_commands[ , 2] == cmd, 1])
                                  ~^
```
[R/simulator_msms.R:101:41:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/simulator_msms.R#L101) *style:* **Commas should never have a space before.**
```r
        paste("msms", sample_size, cmd[ , 1], cmd[ , 2])
                                       ~^
```
[R/simulator_msms.R:101:52:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/simulator_msms.R#L101) *style:* **Commas should never have a space before.**
```r
        paste("msms", sample_size, cmd[ , 1], cmd[ , 2])
                                                  ~^
```
[R/simulator_ms.R:71:9:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/simulator_ms.R#L71) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
        }, character(1))
        ^
```
[R/simulator_ms.R:86:39:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/simulator_ms.R#L86) *style:* **Commas should never have a space before.**
```r
        paste("ms", sample_size, cmd[ , 1], cmd[ , 2])
                                     ~^
```
[R/simulator_ms.R:86:50:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/simulator_ms.R#L86) *style:* **Commas should never have a space before.**
```r
        paste("ms", sample_size, cmd[ , 1], cmd[ , 2])
                                                ~^
```
[R/simulator_scrm.R:84:41:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/simulator_scrm.R#L84) *style:* **Commas should never have a space before.**
```r
        paste("scrm", sample_size, cmd[ , 1], cmd[ , 2])
                                       ~^
```
[R/simulator_scrm.R:84:52:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/simulator_scrm.R#L84) *style:* **Commas should never have a space before.**
```r
        paste("scrm", sample_size, cmd[ , 1], cmd[ , 2])
                                                  ~^
```
[R/simulator_seqgen.R:54:4:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/simulator_seqgen.R#L54) *style:* **Commented code should be removed.**
```r
  #print(cmd)
   ^~~~~~~~~~
```
[R/simulator_seqgen.R:129:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/simulator_seqgen.R#L129) *style:* **lines should not be more than 80 characters.**
```r
                                        sample_seed(length(trees[[locus_group]])))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simulator_seqgen.R:154:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/simulator_seqgen.R#L154) *style:* **lines should not be more than 80 characters.**
```r
                                                              ignore_variation = TRUE),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat_ihh.R:19:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/sumstat_ihh.R#L19) *style:* **lines should not be more than 80 characters.**
```r
    initialize = function(name, population, max_snps, calc_ihs, transformation) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat_ihh.R:52:45:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/sumstat_ihh.R#L52) *style:* **Commas should never have a space before.**
```r
                      iHS = data.frame(ihh[ , 1:2], iHS = rep(NA, n_snps))))
                                           ~^
```
[R/sumstat_ihh.R:54:15:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/sumstat_ihh.R#L54) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          if ((n_snps < 50)) freqbin <- 0.90
              ^
```
[R/sumstat_ihh.R:55:20:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/sumstat_ihh.R#L55) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          else if ((n_snps < 100)) freqbin <- 0.45
                   ^
```
[R/sumstat_ihh.R:56:20:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/sumstat_ihh.R#L56) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          else if ((n_snps < 200)) freqbin <- 0.225
                   ^
```
[R/sumstat_ihh.R:57:20:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/sumstat_ihh.R#L57) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          else if ((n_snps < 400)) freqbin <- 0.1
                   ^
```
[R/sumstat_ihh.R:60:55:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/sumstat_ihh.R#L60) *style:* **Commas should never have a space before.**
```r
            data.frame(ihh2ihs(ihh, freqbin)$res.ihs[ , -4])
                                                     ~^
```
[R/sumstat_omega.R:14:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/sumstat_omega.R#L14) *style:* **lines should not be more than 80 characters.**
```r
    initialize = function(name, min_win, max_win, grid, binary, transformation) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat.R:192:6:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/sumstat.R#L192) *style:* **Commented code should be removed.**
```r
    #assert_that(is.list(tree_list))
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat.R:193:6:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/sumstat.R#L193) *style:* **Commented code should be removed.**
```r
    #assert_that(length(tree_list) == get_locus_number(model))
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat_seg_sites.R:41:38:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/R/sumstat_seg_sites.R#L41) *style:* **Commas should never have a space before.**
```r
    trio_segsites <- seg_sites[[i]][ , left | middle | right]
                                    ~^
```
[tests/testthat/test-feature-ign-singletons.R:13:45:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-feature-ign-singletons.R#L13) *style:* **Commas should never have a space before.**
```r
               list(create_test_segsites()[ , -c(1, 3)],
                                           ~^
```
[tests/testthat/test-feature-ign-singletons.R:14:45:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-feature-ign-singletons.R#L14) *style:* **Commas should never have a space before.**
```r
                    create_test_segsites()[ , -c(1, 3)]))
                                           ~^
```
[tests/testthat/test-model-class.R:241:44:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-model-class.R#L241) *style:* **Commas should always have a space after.**
```r
               data.frame(name = c("theta","tau"),
                                           ^
```
[tests/testthat/test-search-executables.R:30:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-search-executables.R#L30) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-segsites-class.R:15:41:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-segsites-class.R#L15) *style:* **Put spaces around all infix operators.**
```r
  expect_error(create_segsites(snps, 1:4/10))
                                       ~^~
```
[tests/testthat/test-segsites-class.R:16:46:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-segsites-class.R#L16) *style:* **Put spaces around all infix operators.**
```r
  expect_error(create_segsites(snps, pos, 1:4/10))
                                            ~^~
```
[tests/testthat/test-segsites-class.R:22:40:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-segsites-class.R#L22) *style:* **Put spaces around all infix operators.**
```r
  segsites <- create_segsites(snps, 1:3/10)
                                      ~^~
```
[tests/testthat/test-segsites-class.R:30:31:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-segsites-class.R#L30) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  segsites <- create_segsites((matrix(c(1, 1, 0, 1, 1,
                              ^
```
[tests/testthat/test-segsites-class.R:36:26:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-segsites-class.R#L36) *style:* **Commas should never have a space before.**
```r
  ss_subset <- segsites[ , 1:2]
                        ~^
```
[tests/testthat/test-segsites-class.R:38:64:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-segsites-class.R#L38) *style:* **Commas should never have a space before.**
```r
  expect_equivalent(as.matrix(ss_subset), as.matrix(segsites)[ , 1:2])
                                                              ~^
```
[tests/testthat/test-segsites-class.R:41:30:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-segsites-class.R#L41) *style:* **Commas should never have a space before.**
```r
  expect_equal(dim(segsites[ , 1]), c(3, 1))
                            ~^
```
[tests/testthat/test-segsites-class.R:42:33:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-segsites-class.R#L42) *style:* **Commas should never have a space before.**
```r
  expect_equal(dim(segsites[1:2 , ]), c(2, 3))
                               ~^
```
[tests/testthat/test-segsites-class.R:43:32:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-segsites-class.R#L43) *style:* **Commas should never have a space before.**
```r
  expect_equal(dim(segsites[-2 , 1:3]), c(2, 2))
                              ~^
```
[tests/testthat/test-simulator-ms.R:7:73:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-simulator-ms.R#L7) *style:* **Put spaces around all infix operators.**
```r
  expect_equal(parse_ms_positions("positions: 0.1 0.2 0.3 0.4 0.5"), 1:5/10)
                                                                       ~^~
```
[tests/testthat/test-simulator-seqgen.R:213:6:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-simulator-seqgen.R#L213) *style:* **Commented code should be removed.**
```r
  #  model.addMutationRateHeterogenity(model.hky, 0.1, 5, categories.number = 5)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-simulator-seqgen.R:236:6:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-simulator-seqgen.R#L236) *style:* **Commented code should be removed.**
```r
    #feat_migration(par_zero_inflation(1, .5), symmetric = TRUE)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-simulator-seqgen.R:274:27:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-simulator-seqgen.R#L274) *style:* **Commas should always have a space after.**
```r
  model <- coal_model(c(5,5,2), 1, 100) +
                          ^
```
[tests/testthat/test-simulator-seqgen.R:274:29:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-simulator-seqgen.R#L274) *style:* **Commas should always have a space after.**
```r
  model <- coal_model(c(5,5,2), 1, 100) +
                            ^
```
[tests/testthat/test-sumstat-jsfs.R:4:3:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L4) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  seg.sites.3.pop <- list(create_segsites(matrix(c(1, 0, 1, 0,
  ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:10:60:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L10) *style:* **Commas should never have a space before.**
```r
                                                   1, 0, 1 ,0 ),
                                                          ~^
```
[tests/testthat/test-sumstat-jsfs.R:10:61:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L10) *style:* **Commas should always have a space after.**
```r
                                                   1, 0, 1 ,0 ),
                                                            ^
```
[tests/testthat/test-sumstat-jsfs.R:11:54:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L11) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                    ~^~
```
[tests/testthat/test-sumstat-jsfs.R:11:62:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L11) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                            ~^~
```
[tests/testthat/test-sumstat-jsfs.R:13:3:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L13) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1:2, 3:4, 5:7))
  ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:13:27:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L13) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1:2, 3:4, 5:7))
                          ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:14:13:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L14) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  expect_is(jsfs.3.pop, "array")
            ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:15:21:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L15) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  expect_equivalent(jsfs.3.pop, array(c(0, 0, 0, 0, 0, 0, 0, 0, 0,
                    ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:18:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **lines should not be more than 80 characters.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:18:73:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                       ~^~
```
[tests/testthat/test-sumstat-jsfs.R:18:78:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Commas should always have a space after.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                             ^
```
[tests/testthat/test-sumstat-jsfs.R:18:80:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Commas should always have a space after.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                               ^
```
[tests/testthat/test-sumstat-jsfs.R:18:82:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                                ~^~
```
[tests/testthat/test-sumstat-jsfs.R:21:3:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L21) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  seg.sites.3.pop <- list(create_segsites(matrix(c(1, 0, 1, 0,
  ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:27:60:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L27) *style:* **Commas should never have a space before.**
```r
                                                   1, 0, 1 ,0 ),
                                                          ~^
```
[tests/testthat/test-sumstat-jsfs.R:27:61:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L27) *style:* **Commas should always have a space after.**
```r
                                                   1, 0, 1 ,0 ),
                                                            ^
```
[tests/testthat/test-sumstat-jsfs.R:28:54:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L28) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                    ~^~
```
[tests/testthat/test-sumstat-jsfs.R:28:62:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L28) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                            ~^~
```
[tests/testthat/test-sumstat-jsfs.R:30:3:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L30) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1, 2:6, 7))
  ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:30:27:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L30) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1, 2:6, 7))
                          ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:31:21:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L31) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  expect_equivalent(jsfs.3.pop, array(c(0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0,
                    ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:32:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **lines should not be more than 80 characters.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:32:82:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Put spaces around all infix operators.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ~^~
```
[tests/testthat/test-sumstat-jsfs.R:32:87:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Commas should always have a space after.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:32:89:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Commas should always have a space after.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:32:91:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Put spaces around all infix operators.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ~^~
```
[tests/testthat/test-sumstat-jsfs.R:33:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L33) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test-sumstat-jsfs.R:53:41:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L53) *style:* **Commas should always have a space after.**
```r
  jsfs <- calc_jsfs(seg.sites, list(c(1,3), c(2,4)))
                                        ^
```
[tests/testthat/test-sumstat-jsfs.R:53:49:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L53) *style:* **Commas should always have a space after.**
```r
  jsfs <- calc_jsfs(seg.sites, list(c(1,3), c(2,4)))
                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:58:41:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L58) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,3), c(2,5)))
                                        ^
```
[tests/testthat/test-sumstat-jsfs.R:58:49:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L58) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,3), c(2,5)))
                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:59:41:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L59) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,7), c(2,3)))
                                        ^
```
[tests/testthat/test-sumstat-jsfs.R:59:49:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L59) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,7), c(2,3)))
                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:141:40:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-jsfs.R#L141) *style:* **Put spaces around all infix operators.**
```r
                                    1:4/4))
                                      ~^~
```
[tests/testthat/test-sumstat-mcmf.R:13:51:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-mcmf.R#L13) *style:* **Put spaces around all infix operators.**
```r
  expect_equal(calc_mcmf(seg_sites, 2:4, FALSE), 2/3)
                                                 ~^~
```
[tests/testthat/test-sumstat-mcmf.R:70:63:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-mcmf.R#L70) *style:* **Put spaces around all infix operators.**
```r
                              coal_model(4) + locus_trio()), 1/3)
                                                             ~^~
```
[tests/testthat/test-sumstat-omega.R:7:5:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-omega.R#L7) *style:* **Use two spaces to indent, never tabs.**
```r
1.11	1.000000
    ^
```
[tests/testthat/test-sumstat-omega.R:8:5:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-omega.R#L8) *style:* **Use two spaces to indent, never tabs.**
```r
2.22	0.200000
    ^
```
[tests/testthat/test-sumstat-omega.R:9:5:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-omega.R#L9) *style:* **Use two spaces to indent, never tabs.**
```r
3.33	0.030000
    ^
```
[tests/testthat/test-sumstat-pi.R:7:67:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-pi.R#L7) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 1, 1, 1), 5, 3), 1:3/5)
                                                                 ~^~
```
[tests/testthat/test-sumstat-pi.R:26:67:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-pi.R#L26) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 1, 1, 1), 5, 3), 1:3/5)
                                                                 ~^~
```
[tests/testthat/test-sumstat-segsites.R:28:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-segsites.R#L28) *style:* **lines should not be more than 80 characters.**
```r
  seg_sites_trio[[1]] <- create_segsites(get_snps(seg_sites_trio[[1]][ , c(1:2, 4:6, 8:9)]),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-segsites.R:28:72:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-segsites.R#L28) *style:* **Commas should never have a space before.**
```r
  seg_sites_trio[[1]] <- create_segsites(get_snps(seg_sites_trio[[1]][ , c(1:2, 4:6, 8:9)]),
                                                                      ~^
```
[tests/testthat/test-sumstat-sfs.R:62:40:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-sfs.R#L62) *style:* **Put spaces around all infix operators.**
```r
                                    1:4/4))
                                      ~^~
```
[tests/testthat/test-sumstat-tajimas-d.R:14:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-tajimas-d.R#L14) *style:* **lines should not be more than 80 characters.**
```r
                                 0, 0, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 0, 0, 0, 0),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-tajimas-d.R:27:1:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-tajimas-d.R#L27) *style:* **lines should not be more than 80 characters.**
```r
  expect_equal(tajd$calculate(list(create_empty_segsites(10)), NULL, NULL, model), NaN)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-trees.R:6:30:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-trees.R#L6) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_true(requires_trees((coal_model(5) + sumstat_trees())))
                             ^
```
[tests/testthat/test-sumstat-trees.R:7:30:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-trees.R#L7) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_true(requires_trees((coal_model(5) + sumstat_sg_trees())))
                             ^
```
[tests/testthat/test-sumstat-trees.R:8:34:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-trees.R#L8) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_false(requires_segsites((coal_model(5) + sumstat_trees())))
                                 ^
```
[tests/testthat/test-sumstat-trees.R:9:34:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-trees.R#L9) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_false(requires_segsites((coal_model(5) + sumstat_sg_trees())))
                                 ^
```
[tests/testthat/test-sumstat-trees.R:73:64:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-trees.R#L73) *style:* **Commas should always have a space after.**
```r
                                 locus_trio(locus_length = c(1,3,5),
                                                               ^
```
[tests/testthat/test-sumstat-trees.R:73:66:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-trees.R#L73) *style:* **Commas should always have a space after.**
```r
                                 locus_trio(locus_length = c(1,3,5),
                                                                 ^
```
[tests/testthat/test-sumstat-trees.R:74:60:](https://github.com/statgenlmu/coala/blob/b29cd89ed9e7aca06e8ac402855434e99c1f308c/tests/testthat/test-sumstat-trees.R#L74) *style:* **Commas should always have a space after.**
```r
                                            distance = c(2,4)))
                                                           ^
```


Comentarios al commit


try just putting <button class="browse-button">Browse files</button> and then in your CSS file on the browse-button block add background: transparent;


This is very good solution! Now we can handle drag event and exchange settings between swapped tabs. This is what was missing, when I tried to do this.


thanks!


Why don't you remove the previous line ?


Тут всё ок, замечания разберем на занятии


Probably yes. It was only included for PETSc solver to distinguish multiple solver configurations for different processes.


@mortonfox Thanks! I really like ```set curTerm to (current terminal)```
I'm going to merge the pull request but this got me thinking about the iTerm conditions we are handling.

1. iTerm is not open
2. iTerm app is running but no iTerm windows are open
3. iTerm app is running and we have iTerm windows open.

I'm not handling #2 correctly.

I'm going to completely rewrite this to verbosely handle all events. This will make the code easier to read and correctly handle what is going on.

Thanks for taking the time to contribute.


Not clear. Should a user be able to switch topic after the file has been
reviewed?  Or after the submission deadline but before the file has been
reviewed?  What is the right time to cut off the ability to switch topics?
We should discuss this.

On Thu, Jan 14, 2016 at 3:15 PM, Yang Song <notifications@github.com> wrote:

> We used to check if the dir_num is nil to determine if this team has
> submitted any file or not. This is problematic because that the user can
> submit a file and then delete it. In this case this team is still holding a
> dir_num, but actually the folder is empty. If so, this team should be able
> to switch topic.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/expertiza/expertiza/commit/c8024085ffd3d48ccb1a12da8fa3d46023c61c80#commitcomment-15459813>
> .
>


:tada:


Ok, tak třeba to FioAccount :)


Il manque seulement le merge ;-)


Looking at the code it seems this condition will always be false.


Yes, as gunrot said current default with Qt handling OpenGL includes should work. If not, please tell so we learn about that and can consider other options.


I like that. Nicely done.


Блин, я сюда еле долистал! Та нормально!)


Already did some time ago :) https://github.com/respectTheCode/node-cheddargetter/pulls


turns out FilterGridPanels are already stateful (using a custom state manager), and setting stateId breaks the stateful-ness by using ext's default state manager.


fixed


The PourTransaction constructor creates a pour proof right now, we want to just place the internal fields. (We're getting rid of PourTransaction if I have my druthers.)


See my answer in #326


Missing initial ` on encodeUrlComponent


I experienced the decribed behavior (leaving the client on stop and in idle for >=4 hours and then trying to make it play again) on my Raspberry Pi (Raspian) and my Debian x64 system. On both systems I got a BrokenPipeError using Python 3.4.4. This was reproducible.

However, I don't know if there may be another Exception that might be raised here under slightly different circumstances.

But let's ask the question the other way around: would it lead to unexpected behavior if we catch a more general exception type (like ConnectionError or OSError).


@bpostlethwaite this should do it. Right?


Ну почти правильно )) У тебя получается, что не зависимо от того, какой расход ввел пользователь - всегда выводится одно и тоже число. Ты точно уверена, что поняла условие задачи?


Oops sorry - I'm still trying to get work done and I forgot I wrote out this test data... I apologize


it `===` your fear of not knowing what to register


Lijkt me niet dat het klopt dat elke radar zo'n stomme radius erom heeft. Alles wordt simpel weggefiltert boven de radars. Lijkt me niet normaal.


@bberenz much obliged.  Our QuickStart guide uses ` var data = ['^XA^FO50,50^ADN,36,20^FDRAW ZPL EXAMPLE^FS^XZ'];` which I'm now realizing should've be fine.  :+1: Thanks for the patch as well.


Is there a better place to put this list?


developers.google.com URL 404's, but if it will be in place soon, then probably OK.


`white-space: nowrap` shifts comment text area that locates under line to be aligned with line


Thanks for the heads-up, it's fixed now and it will correctly pre-filter the organisations and feed the result into the orgc_id filter.


Haha, I just saw your message about https://github.com/dimagi/commcare-hq/blob/f320562823b153548f3e85d9be85057fd286e9d9/corehq/apps/sms/migration_status.py#L61
We should change the command in the README to:
```
env CCHQ_IS_FRESH_INSTALL=1 python manage.py migrate
```
and then use that in doctype_migrations too
@dannyroberts FYI


em/pt may be the proper way to go, but px may be easier to do given many things are in px, and may looks more consistent across different scalings? Not sure, need to test


Didn't we just do all of this stuff before calling display_alt_help?


Closes #80


done


yes fam


Здесь ты внес изменения, т.к. во всех остальных блоках цвет текста определяется классом .txt-white  или классом .link у ссылок. Селектор .is-sticky .txt-logo меняет цвет логотипа на #333


Vielleicht ist es besser statt mit Callbacks mit ES6 Promises zu arbeiten


Why is this line required here?


no, you could have a race condition in which another thread already replaced the connection with a new one


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1921 of 2048 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-93.8%25-yellow.svg)


Is there a reason why tox is added in test requirements? i have looked into test scripts but none of them use tox command :/


On Thu, Jan 14, 2016 at 12:07:38PM -0800, Serge Hallyn wrote:
> On Thu, Jan 14, 2016 at 03:00:35AM -0800, Christian Brauner wrote:
> > I suggest that `should_default_to_snapshot()` simply take another argument `char  *bdevtype` and we check if it actually is `btrfs` and bail if not. `copy_storage()` calls `should_default_to_snapshot()` and itself takes an argument `bdevtype` so we can just hand it down to `should_default_to_snapshot()`. I have two trivial fixes for `lxcbtrfs.c` and `lxcoverlay.c` in line (but that bug me).  If you're ok with this I'll just combine my trivial fixes with this.
>
> Sounds good - thanks.
Nope, we cannot do it this way. Callers like lxc-clone or lxc-copy may validly
pass in NULL to c->copy() and hence to copy_storage() which will just lead us to
segfault if we e.g. try strcmp. What we can do instead is have
should_default_to_snapshot() create the path for the two containers and call
is_btrfs_fs().


prolly, but first we should decide whether we want to keep that color etc. I think we should hold off on moving much up to emerald until most of the template is finished, then do it all at once


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1163](http://teamcity.monogame.net/viewLog.html?buildId=13593&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Mac) Build time: 00:00:01


OK ))


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1162](http://teamcity.monogame.net/viewLog.html?buildId=13597&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Mac) Build time: 00:00:00


this looks like a good recovery strategy.


Hm, doesn't look like it's maintained, thats why I made a fork and published as 'cg', instead of `cheddargetter`. So if you want to use new stuff and use npm you can make a PR to https://github.com/jamiter/node-cheddargetter if you like.


OK. Got it.
No, because it's called in `Process<>::initialize()`.
_This thread is closed._


What does it do?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11583](https://teamcity.mesosphere.io/viewLog.html?buildId=105404&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:03:46


Тут были внесены изменения, чтобы менюшка в блоке была красиво посерединке.


Can you fix the spacing here? This is some weird indenting going on


We should check this in the book


Ah, you are way ahead of me :)


Вот этот блок я так и не понял зачем нужен.


Thanks!


Yes, that (the addition "For Linux") makes it better.


Тут фиксируется общий размер блока, тоже для красоты.


Why would the bean be a prototype and not a singleton?


Тут всё ОК, вопросов нет


Наводим красоту при прокрутке странички вниз.


I'm missing how that module is being generated under the changes for #1353:  are we relying on it being importable from a dependency, somehow?


Меняем цвет текста при прокрутке


This is combining the 2 prerequisites into a single file. What would rsync set as the datestamp when merging two files?


The `test_load_table_fits` method doesn't require `sherpa-test-data`, since - for whatever reason - the file `sherpa/astro/ui/tests/data/two_column_x_y.fits.gz` is included within the Sherpa repository rather than the `sherpa-test-data` one (which is why there's the comment `# QUS: why is this not in the sherpa-test-data repository?`).

So this change (moving `requires_data`) means that - if `sherpa-test-data` is not available - then we will be running one less test than before. Choices include:

1. accept this
2. don't move the `requires_data` decorators for the members of `test_ui`
3. move `test_load_table_fits` into its own class

I think for now I'd be happy with 2 or 3.  I would prefer not to "lose" a test - even if it's not really adding much in itself.

Longer term we should work out whether we really want Sherpa to be carrying around test data (there's this file and a number of files in `sherpa/astro/datastack/tests/data/` that I know about, maybe more).


Okay. I wasn't sure if we wanted to put all the variables together like the other parts of the Makefile.


Центрируем текст по вертикали в состоянии прокрутки странички.


Except for the question about the source of `google.protos.timestamp_pb`, this commit LGTM.


I don't think this will work in the general case, because when the table mapper starts up, it won't contain any keys.
Therefore, this if statement will never return true, so queries related to tables will never be recorded.


Even though this is a testing extensions, it would be clearer if the message source has a message source like name.


Actually, don't we want a newer datestamp for the combined file so that Makefile knows to rebuild if either prerequisite is newer?


It ships with https://pypi.python.org/pypi/protobuf in the latest version (`3.0.0b2`). I should've updated `setup.py`, good find.


I don't think this is right


Very nice :smile:


Yes I did try that first but it wouldn't run without them.


>```
 - * Gate counts: 36 33 33 26 35 34 34 32
 - * Average: 32.875
 + * Gate counts: 49 44 46 33 48 46 46 41
 + * Average: 44.125
```

Wait, what?! I thought you were already using the ones from @DeepLearningJohnDoe for Maxwell.
```
 * Gate counts: 25 24 25 18 25 24 24 23
 * Average: 23.5
```


That's a good question. I guess I felt obliged to list tox somewhere since the tests are designed to be run under tox. However since it's not strictly required I guess it is redundant. If you agree it should be removed could you make a bug saying so, or do a pull request? Thanks.


does this even compile still


This edit has lost the "creation" of the `ui.beta2d.p1` model component. I'm surprised if it passes; if so, then it's presumably because somewhere in the system there's a test that creates a model component called `p1` and it hasn't been removed (e.g. if `ui.clean()` were added to `setUp` then I would expect it to fail).


I agree with option 3. Notice that we are not "losing a test", because setUp already requires the test data, so without test data the test method is not run, unless I am missing something in the way unittest works.


This only tests that any string is returned. It should validate the URL somehow, ideally with a `HEAD` request to the server. Other tests in this file only verify returned types, so that's what I did. ¯\_(ツ)_/¯


I mean, thanks for the pullreq


Could you possibly add a button to switch to scooters menu?


Ok I'll do that. Can you elaborate on why? I'm wondering if there are other imports where I should do the same.


But imma close this one


OK you do. They're in the "841 additions, 1,158 deletions not shown" above :laughing:


with a cactus tho 🌵


dunno


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11584](https://teamcity.mesosphere.io/viewLog.html?buildId=105435&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:09


I don't know if we want this prelude in the TOOLS directory or in the workspace. Ultimately we would probably need both but for now we are not providing default skylark rules, keep this one as being user specific, no?


In fact, it is not passing.


Убираем непонятный отступ слева.


Same here, no needs for those, is there?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1164](http://teamcity.monogame.net/viewLog.html?buildId=13601&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Mac) Build time: 00:00:00


honestly, not sure... THis is how devkit used to do it :)


Не совсем верно. По условию, price - это цена 1 литра бензина и формула price / km не будет средней стоимостью 1 км. Но если ты имела в виду, что price - это сколько ВСЕГО заплатили за бензин - то тогда это будет правильно.


Did we already pack the window package somewhere?


Да, это правильно, и строчка 3 - не нужна )


In that case it should be numbered in the TOC. @valexiev care to make a pull request?


Do something like what exactly? Create a config option? If that's the case, it isn't really a feature that needs to be configurable. A question to ask is, why wouldn't you want better formatted currency.

The reasoning behind NumberFormat was just the Locale. Not that it strongly affects the usability, but it also does everything according to the locale as opposed to having to define the format via the DecimalFormat pattern.


Does it make sense to use here static constants from ConnectionInterceptorTestCase?


`data.each do |name, count|` тоже будет работать.


this is a leftover from a prior approach. Fixed it


I just found another added benefit...

Different opening and closing braces makes it very easy to match.

```php
$this->function([
	$this->summarise([
		'key' => 'value'
	])
]);
```

Easy to see which of the closing braces is array and which is method.


Делаем так, чтобы у списка появились маркеры


great tests!


Great! This fixed driver.quit() breaking for me in 2.4.9.


И ещё один непонятный отступ справа


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1502 of 1502 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


Closes #138


/rebuild


Because we don't ever speculatively execute or parameterize write queries, I didn't write any code beto extract the constants from them. I would probably put a TODO comment above here that says that this always returns null because it is a write query, so later on we aren't confused :)


Can you put spaces in between the operands of &&?

`if( success && query.getParseTree() instanceof Select ){`


But since the image has text, you actually have a point since png is better for images with text.. But generally you can optimize jpg a lot more than png for photos without much quality loss.


no, what actually makes sense is to move the constants to this class and use them in the test case


Change the sql codestyle like this @Nevarian  https://github.com/TrinityCore/TrinityCore/commit/8dd072722ab523b611fa65e8bd6b84653dd7cacb


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11585](https://teamcity.mesosphere.io/viewLog.html?buildId=105437&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:03:45


@markhagan did you mean to commit this line?


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (2042 of 2052 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.51%25-yellow.svg)


Use constants for readability -> `20 * IN_MILLISECONDS`


@jcorcoran , @Benmw99  Don't delete old file logging fields, just add new ones for the BNO gyro. All other fields should remain untouched.


TeamCity pull requests :: netty-tcnative [Build 38](https://garage.netty.io/teamcity/viewLog.html?buildId=4757&buildTypeId=pulls_netty_tcnative&guest=1) is now running


TeamCity pull requests :: netty [Build 1034](https://garage.netty.io/teamcity/viewLog.html?buildId=4754&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6370, ignored: 23 Build time: 01:25:00


BTW the performance matrix at http://hashcat.net/oclhashcat/ isn't updated for oclHashcat 2.x


Is it possible to denest this with some well placed continue's?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1165](http://teamcity.monogame.net/viewLog.html?buildId=13605&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


+1 for readability


If you only update, doesn't this mean our CI plans will run on stale data from previous runs?


On lines 1807 and 1808 you specify the same icon for both functions. Probably should use larger versions of the icons found on the planet for these purposes. Also, I note that you open the menu by default. Please make a note of that in the pull request.


Sigur e ok să facem asta? Ce se întâmplă dacă pică netul înainte să facă save? Ar trebui să dăm eroarea cu autorizarea doar dacă prindem eroare 404.


d


TeamCity pull requests :: netty-tcnative [Build 38](https://garage.netty.io/teamcity/viewLog.html?buildId=4757&buildTypeId=pulls_netty_tcnative&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:58


TeamCity pull requests :: netty [Build 1037](https://garage.netty.io/teamcity/viewLog.html?buildId=4760&buildTypeId=pulls_netty&guest=1) is now running


Hey, sorry just caught wind of your comment! That's fantastic to hear - I apologize, I put together the changes pretty quickly as part of a Hackday project and never had a chance to clean it up for a formal PR. Will keep it in mind for next time! Thanks for the update!


к слову, `array[0..count]` лучше выглядит в виде `array.first(count)` (намерения виднее).


Yes people are reading those, and they are pretty useful for keeping track of changes which might break 'my' stuff. Your work is appreciated ;)


Fixes #97


Escalator, Ad-Hoc(lv2)


неплохо! но кстати, initial value тут не нужен, сработало бы и просто `reduce(:merge)`


Its a branch, nothing matters

Sent from mobile.


This needsUpdate(ds *extensions.DaemonSet, daemonPods []*api.Pod, numUnavailable, numNodes int) (*api.Pod, bool) signature seems to work for rolling update but does seem like it would be sufficient to implement other strategies.


Sir, for current code, we check two things:
* if there is a signup topic deadline and it has already passed, students cannot drop topics
* if there this team has already submitted something, students cannot drop topics.

So, it is possible that a team can still delete everything they submitted and drop the topic even in the review phase.

Shall we add one more check: if this team's work has already been reviewed, they cannot switch topic?


(впрочем, ещё чуть короче вариант — `map{|director, movies| [director, movies.count]}.to_h`)


This change was very sudden and quite confusing. I really preferred helm's M-x and `read-file` over the default. What was the motivation for this change?


Awesome naming!


Товарищ! С отступами по-прежнему беда, вот посмотри глазами как это на гитхабе выглядит. А мне это читать же.

Почини отступы, пожалуйста-пожалуйста.


To be very rigorous, \int_{\Omega}C(t,s)\phi_n(s)ds=\lambda_n\phi_n(t) \forall t \in \Omega


error string doesn't show up if `required-error` is absent?


`:build` – I think it's inappropriate boost will depend for the hhvm runtime (library).


Also file logging isn't working period.
Hence the gutting of code.

If we had done beta testing task 3 we would probably understand why.

Sent from mobile.


Discussion at [Error compiling using mingw](https://groups.google.com/forum/#!topic/cryptopp-users/LTU3u1Jlbqs)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11587](https://teamcity.mesosphere.io/viewLog.html?buildId=105451&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:03:52


The old `<i>` tag used to have `ng-show` but this went away, apparently in favor of a pure css solution. This means that public consumers will have to implement their own styles or the error span will always show up. I guess if it has no content that may not be an issue (empty string)


I'm so stupid! :laughing: Fixed. Thank you!


Looks like your editor is set up to use spaces instead of tabs, FYI


I added debug mode!


Then add a `\n` before it.


Sorry 'bout that.


TeamCity Open-source Libraries :: ConfigInjector :: CI [Build 2.0.452.0](http://build01:8888/viewLog.html?buildId=13824&buildTypeId=ConfigInjector_CI) is now running


See the "External Assembly References" section in the Contributions Guide.
http://dotnet.github.io/orleans/Contributing


TeamCity pull requests :: netty [Build 1036](https://garage.netty.io/teamcity/viewLog.html?buildId=4756&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6373, ignored: 23 Build time: 00:42:56


Hello Christian,
Thank you for the patch! I noticed that your patch is missing a commit title and signed off line. Can you please add a short title above the commit message describing what the patch is doing. Can you also add a signed off line. You can see this page for more details: http://wiki.qemu.org/Contribute/SubmitAPatch
Thanks,
Alistair


remove unused logs, especially, secure information


wiiu


TeamCity Open-source Libraries :: ConfigInjector :: CI [Build 2.0.452.0](http://build01:8888/viewLog.html?buildId=13824&buildTypeId=ConfigInjector_CI) outcome was **SUCCESS**
Summary: Tests passed: 38 Build time: 00:00:43


TeamCity pull requests :: netty [Build 1038](https://garage.netty.io/teamcity/viewLog.html?buildId=4770&buildTypeId=pulls_netty&guest=1) is now running


I realize its a branch, but, in order to do post processing of the data, it is easy to just pull the file the way it was in order to plot new data against old data.

Nothing in 2016 beta would have broken the file logging. I assume you running on the 2016 image, did you set file permissions to give Robot User permissions to create files/folders in the lvuser account from the webdash?


is equal to or exceeds


the depends.txt says ```mobs``` - its just because the ```mobs:lava_orb```


Please use the error_report() or qemu_log() function instead. Also no line should be over 80 characters


Given the new implementation below, do we still need to exclude the tests from the `sdist`?


Use a less then 0 and remove the cast


remove unused import


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11586](https://teamcity.mesosphere.io/viewLog.html?buildId=105442&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:09:01


logger достаточно.


I used another one to upload it anyway.


remove second ;


Really need some code docs for this, to preserve the knowledge of how this interfaces with xunit traits system for implement MsTest style TestCategory tags.


For 1.0.0 Final no?


And this is why you always leave a PR! \</j-walter-weatherman\>


Much better to show e.getMessage() as error message


111101900_MSHeatPump (Nigusse) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Having title, brief and full_text here means they will be in the db twice.  Once for  yes and once for no.  I would think this class would only have a FOR/OPPOSED field.


Please use constructor without spatialDimension. I should have deprecated them :-(


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1505 of 1505 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@codesnake: this is just a POC in that branch not necesarrily working or compiling. I removed the clock from the interface. The idea is to use SetVideoPtsSeconds and set the inital value to a high value so that nothing is output. After we decode the first time succesfully, we can set the PTS to to ptrsr + something. Later when GetPicture is called we normally set it to pcr + numberofbuffers * frametime.


Отключаем автоопределение высоты создаваемого скриптом контейнера (т.к. у нас размеры зафиксиованы парой  строчек выше)


thx


For extra context, `:` is a special character in YAML files - if you wanted to use it, just wrap the whole string in quotation marks and the parser won't look inside your string...


We still don't want to ship `/usr/local/lib/python2.7/dist-packages/system_tests/` to people


Probably worth adding comment here that an outstanding TODO item / secondary step [separate PR] would be required to remove this outstanding dependency on VS/MsTest libraries for eventual "pure" cross-platform test suite.

I would say best to keep the 2 changes separate if possible, so that the structural changes to xunit are more clearly visible.


`title` should be `FOR` or `OPPOSED` in most cases. `brief` and `full_text` ... right, I don't know what they're for, since we have `pro_statement`. I think they should just be removed. sound ok?


Won't you need to set up FactionImages for most of the other structures too?  (they'll otherwise default to Harkonnen).


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1505 of 1505 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.67%25-green.svg)


Holy hell, how did that happen?


die seite ist ein fork von http://eckvitrine.demont.is/


Тут вводится дополнительная абстракция, что скрывает детали - что конкретно тест проверяет, но нам в тесте это и интересно. И кода стало больше.


LGTM, modulo some minor comments above.


This looks really scary ... I don't know a better way atm, but we should consider this only as a workaround.


Это, насколько я понял, внутренний метод скрипта, автоматически устанавливающий высоту генерируемого родительского элемента. Ты его закомментил, т.к. в скрипте он участвует в нескольких процессах (чтобы он тупо ничего не делал). А высота этого элемента прописана вручную в CSS


👆Thats a feature!


This can be just date.


We can refactor back to a non-dynamic implementation once we retire 6.0 support. I think (but did not test) that the new way (using the ServiceComponentRuntime service) works on 6.1 OOTB. But I don't think it is worth cutting off 6.0 support just for this one thing.


Should be ref to a user


Right now both, jpg and png  have weird artefacts and looks really bad. [Images from PacktPub](https://www.packtpub.com/sites/default/files/8727OS%20Agile%20Web%20Application%20Development%20with%20Yii.jpg) looks much better:

![7abc2ed32bdd8a9d7f33b031091b](https://cloud.githubusercontent.com/assets/5972388/12337645/7a5a2878-bb0b-11e5-8114-01fab49fb854.png)


what are the limitations of a enum vs having a separate schema?


what is the difference between a cart and an order


1. MSDN https://msdn.microsoft.com/en-us/library/system.uri.escapedatastring%28v=vs.110%29.aspx states that limit is 32766, could you please update it to it?

2. As the code is coming from http://stackoverflow.com/questions/6695208/uri-escapedatastring-invalid-uri-the-uri-string-is-too-long, it would be good to have a link in comments to it.


It should be `shoop.__version__`.


programmatically


"it's makes it" ?


can you just reuse addToCart here?


Вот тут высота генерируемого контейнера и прописана (вместо setWrapperHeight())


We don't want to raise an error here. As the `atomic migrate import` was successful and we still need to ask the user to restart his/her docker daemon for the changes to take effect.


why callback and not a Promise?


I know, this one is the most up-to-date so far: https://docs.google.com/spreadsheets/d/1B1S_t1Z0KsqByH3pNkYUM-RCFMu860nlfSsYEqOoqco/edit#gid=0


111101900_MSHeatPump (Nigusse) - x86_64-MacOS-10.9-clang: OK (2049 of 2050 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


No worries! Anything interesting came out of Hackday?


There are two calls to the sortFile function, only the last couple of auxiliary files persist, the file comparisons seem to be done properly though


Can you do a & there?


Looks good, thank you!


I realize the BACKUP_CONFIG name is probably not the best place to contain the S3_CONFIG_PREFIX (as the S3_CONFIG_PREFIX refers to the path on the bucket for the shared config, rather than the path for backups of the shared config), but I felt that it was easier to see on the command line when the two options were adjacent.  I don't recall why I wanted/needed the full path to the web.xml file, but I think I may have encountered an error during testing when using arguments that I had copied from the command line of a running process but manually executed from a different directory.

Whether this gets merged into master, thanks so much for sharing your work!


Eliminando Archivo de Pruebas


Does hardcoding an id here actually work?


@popcornmix this does not apply anymore to master. could you resolve the conflicts please and pr again?


formating...


`.required-error` applies an asterisk to the label. The `.error-string` should be able to appear with or without it.

![required-error](https://cloud.githubusercontent.com/assets/13574057/12337767/f2111084-bad9-11e5-8136-689a135e3766.PNG)

You are correct about the `error-string`, it's going to need an ng-show. Since the validation icon will appear whether it is empty or not.


I'd call that rewriting!
Good job; even though I don't like coffee script! :stuck_out_tongue_winking_eye: :sweat_smile:


Why not? boost::container::flat_map is just sorted vector, it should be more effective than hashtable.
The code has already depends on Boost, so IMHO it's not a problem.


Добавляем тень в режиме прокрутки


As a side note, if we're using tempvars to name our function parameters, here is another legal way to do that:

```
+    my $result = $self->execute_workflow_for_operation($w, 'filter', my $inputs = {'status_file' => $input->{format_output}});
```

I make no warranty about the suitability of this style for any particular use.


Thanks ;)

> Am 14.01.2016 um 22:17 schrieb boni <notifications@github.com>:
>
> MinecraftForge/MinecraftForge#2375
>
> —
> Reply to this email directly or view it on GitHub.
>


These can be reduced to only a few beforeEach


Ну и цвет нижней границы по вкусу :)


+1.  You can merge


is done necessary here? and why not?


Done.


Done


What is this test missing?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1165](http://teamcity.monogame.net/viewLog.html?buildId=13605&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:29:54


Why would res.send(this.body) work here?


111101900_MSHeatPump (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (956 of 956 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-27.0%25-green.svg)


Haven't we seen this before?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11588](https://teamcity.mesosphere.io/viewLog.html?buildId=105468&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:03:44


Yes - garbage - ignore - I already pulled it from the PR


generating two responses