Hi Sean,

Thanks for this, I really appreciate your help.
As I am not english native, I am afraid that a large part of the documentation is written like that. Your contribution is more than useful !

In line in few minutes...


Тут баг. И the вероятно лучше убрать в таких фразах.


Выше есть Restore password, это не дублирование?
Вообще, нам нужен только один перевод - Reset Password (именно сброс пароля через сайт осма). Почему перевода два, да еще и Renew, не понятно.


Желательно проверять, что typeof this.container тот, что нужен. Теоретически пользователь может передать туда строку. Т.е. нужно написать что-то типа такого:
``
if(typeof this.container == 'string') {
document.getElementById(this.container) ...
} else {
// то что написано у Вас
}
``


Необязательная рекомендация: этому блоку можно ещё второй класс задать, чтобы смысловое значение придать, например .gallery, или сделать ещё один уровень вложенности, и вложенный блок назвать .gallery


:clap:


Looking good! Did config.yml get removed by accident tho?


Ниже есть Registration. Вероятно, это ошибка, и нужен только один перевод. Надо уточнить.


Поменяй на абсолютные ссылки, то есть чтобы начинались с /
Потому что когда-нибудь придётся делать ссылки типа **http://domain/path/to/file** второго третьего N-го уровня и тогда браузер относительные ссылки попытается открыть вот так **http://domain/path/to/file/js/jquery.min.js** и получит `404 Page Not Found`


Выше есть Register - это не дублирование?


合并


Replace "against standard" with "to standards" :)
Maybe also change "developers" to "designers and developers"?

May also be good to mention "ensure that designers and developers have the resources and tools to help them with their tasks" - with tools I don't mean software but something like "quickref". Maybe you can find a better word. Maybe just resources is sufficient?

On this last note, I wonder if "quickref" should be specifically mentioned inline in this paragraph, as a resource that is particularly helpful to designers and developers? I think we've highlighted particularly relevant resources in other sections, like business case and developing policies - this could take the same approach IMO.


Hello.

I recomend you to change name from DirectApi to YandexDirectApi. It is always better to know, where the roots are.


Выше был перевод Register with. Если есть полный перевод "с гуглом" и "с фейсбуком", то зачем тогда просто Register with?


Почему было не определить все обработчики прямо внутри класса?


Дублирование editor_register


TeamCity pull requests :: netty [Build 1126](https://garage.netty.io/teamcity/viewLog.html?buildId=5135&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6392, ignored: 23 Build time: 00:42:16


Here's a test case for you to try that requires looking at substitutions, rather than recursing into generic parameter types:

    protocol Holdable {
        typealias Holding
    }

    struct Holder<T : Holdable> {
        let x: T.Holding
    }

    struct NoStorage : Holdable {
        let Holding = Bad
    }

struct Bad {
    var s: Holder<NoStorage>
}

Note that 'Bad' and 'Holder' do not appear in the generic parameter list of the type of ```Bad.s```, or in the original type of ```Holder.x```. However the substitution T -> NoStorage in ```Holder<NoStorage>``` produces a stored property 'x' with type ```Bad```.


В текущей версии UI, вроде бы этот перевод не нужен.


Надо уточнить у Игоря.


This is nice :+1:


Наверное, неправильное место для этой надписи. А вдруг пользователь не имеет прав на изменение?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13153](https://teamcity.mesosphere.io/viewLog.html?buildId=115370&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:04


Эти строки пока тоже не нужны - у нас все происходит в браузере.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13154](https://teamcity.mesosphere.io/viewLog.html?buildId=115369&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:12


I'm thinking it could be a separate plugin maybe? Unsure


typo "arugument"


s/GrabTaxt/GrabTaxi 🤓


Это в каком кейзе встречается? @igrechuhin @yunikkk


Эти три картинки лежат внизу отдельно, в ряд, отличаются от первой. Значит надо либо задать им какой-то отличающийся класс, например .gallery-photo-small, либо обернуть в обёртку, например с классом .gallery-previews  и тогда на img можно будет повесить что-то вроде .gallery-previews-photo  (ну или оставить без класса, тогда придётся просто по селектору  .gallery-previews img в css обращаться).
Ремарка: кстати если делать обёртку, то можно задуматься о том, что это можно сделать и списком. Т.е. ul.gallery-previews > li.gallery-previews-photo


Actually I'm not sure why you're skipping these -- what if we synthesize an implicit stored property whose type makes the containing type recursive?


Такая же строка дублируется выше. Надо проверить все новые строки на дублирование.


I think it makes sense to have in selectors, although it could be named differently. autoNext?


add the values at the end of the line like others : (stable, unstable, nightly)


Замечание по читабельности: пустая строка, и после неё контент отодвинут на 4 пробела, вместо двух. Это не очень.


:sob: bye bye grabtaxi


Не припоминаю этого в дизайте. Вероятно, сейчас не используется, надо уточнить у Игоря.


:sob: :sob: and easytaxi!


Замечание по читабельности: не понятно зачем тут ul отодвинут на два лишних пробела, ведь он на одном уровне с h2


Вспомнил ) Все ок.


Oh, good call. It was development cruft.


Did it go through `gofmt`?


`!isset($_SESSION['right']) || $_SESSION['right'] != 1` на случай если страницу пытаются открыть не успев залогиниться


It's already been merged, so we'll just need to make a note of it and remove it later.


1 изменений? будут проблемы с падежами, но с этим мы быстро ничего не сможем сделать. Разве что поменять строку на Изменения: 2 в дизайне.


Could be solved via the separate form data plugin? If not, let's forget about form data in this plugin for now and make it work via files only.


@lassoan I wonder if some extension will break because of this change. I guess it should be pretty easy for the extension maintainer to fix the code. That said ... code for `4.5` and `Nightly` will have to be different.


at или все-таки with?


Обрати внимание: .article для артикула конечно подходит, но в html есть тег с тем же названием, и человека отсматривающего твою вёрстку это может запутать - может быть можно заменить этот класс на какой-нибудь .product-code или вроде того.


It is not possible to switch to next planet from fleet3
Well it is possible but then the fleet isn't sent, it's just like you go through to fleet3 and switch the planet manually


Наверное the тут тоже не нужно


I think we should explain in a comment why this is a good idea for posterity's sake.


So @mxw is @ptarjan in disguise?


This is sweet!!

No need for node_modiles/.bin tho I believe npm scripts will check there automatically 👍


<img src="http://pictures.gabrielecirulli.com/2048-20140309-234100.png" alt="Screenshot"/>


Потенциальная дыра в безопасности, проверка `if (isset($_COOKIE['user_id']))` - лишняя


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13152](https://teamcity.mesosphere.io/viewLog.html?buildId=115368&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:08:43


ln -rs apprtc/src/collider/collidermain $GOPATH/src/


Will soon update the algorithms in pseudo-code along with explanation


Would it make sense to move these in the base class ?


Этот запрос надо выполнить после того, как проверка `if ($dbc -> connect_error)` то есть когда коннект к базе успешный


I was having problems with the debugger no longer stopping at breakpoints in Idea just as @kolkov reported, after this commit. I reset delve to the previous one, rebuilt, and breakpoints worked again. Checked with Visual Studio Code with the vscode-go extension and it works even with the changes in this commit.


Ремарка: обрати внимание - ты на странице item, т.е. всё содержимое имеет отношения к item товара. Так что в принципе можно было давать префиксованые словом .item- классы. Т.е. .item-status, .item-article, .item-buy и так далее, на мой взгляд это выглядело бы единообразнее.


`!isset($_SESSION['right']) || $_SESSION['right'] != 1` на случай если страницу пытаются открыть не успев залогиниться


RUN ssh-keygen -q -t rsa -b 2048 -f /etc/ssh/ssh_host_rsa_key -N ''
RUN ssh-keygen -q -t ecdsa -f /etc/ssh/ssh_host_ecdsa_key -N ''
RUN sed -i '/^session\s\+required\s\+pam_loginuid.so/s/^/#/' /etc/pam.d/sshd
RUN mkdir -p /root/.ssh && chown root.root /root && chmod 700 /root/.ssh


好的提交


Последняя ссылка в хлебных корках - не должна быть ссылкой )


Замечание по читабельности: ul с лишним отступом, на самом деле он на том же уровне вложенности что и H2


sshd


comentario de commit se agrego jose


Замечание по читабельности: ul нужно вернуть на тот же уровень что h2


update sshd


sepertinya URL ini http://mirzailhami.com/iqra/data.php?catID=2 tidak mengeluarkan data json


Right! It should be there now.


Я такого не видел


Didn't notice when this was introduced, but we can have a better name than `nodec?`.


Замечание по разметке: атрибут for тега label может ссылаться только на id. А у тебя он ссылается на value, что не верно. Добавь id.


footer состоит из 2-х больших блоков: карта и нижний контент. Поэтому лучше назвать .map и .footer-contact. Внутри .map необходим .container, а внутри него уже идет блок .contacts-info


Это заголовок либо первого либо второго уровня!


Span не надо, текст перенесется от ширины блока


Prevent error: #3669 Error: Bad Input Size
The minimum size of the buffer is 32x32 pixels.
Description: http://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/flash/display3D/Context3D.html#configureBackBuffer()


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13155](https://teamcity.mesosphere.io/viewLog.html?buildId=115374&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:07


Этот блок вообще не нужен, карта вставится как background


Поправка насчёт `section`, его можно оставить.


Этот блок будет лежать в блоке .footer-contact


This fixes #5


Yes we need this check because the default value for the optional argument is not 'None'.


Вот тут бы по хорошему завершить обработку, но exit или die выглядят грубо


.footer-social-name и текст ниже должны идти в одном общем блоке. Это не тег b, это p. И ниже тоже p. Им надо дать классы. Тег b - это только для жирности, так что про него можем забыть. мы жирность можем сделать через css


removing the volatile here is not wise: Although you synchronized, this doesn't mean that the variable will be synchronized between the threads without a volatile. I'd also suggest going with a AtomicInteger or even generating something complete random (where you don't require any synchronization).


Немного подправить!


по хорошему перед обновлением надо проверить - есть ли такая запись

потому что есть две ошибки:
    не обновилось, потому что нечего обновлять
    и не обновилось потому что ошибка в SQL


надеюсь все будет хорошо


I'm going to do the setup of super-admin in another way.
But I need to have the DB from TSMR in order to reproduce and to fix.
Thank you,
regards,


Замечание по разметке: у тебя есть инпут для отправки формы. Хорошо. Теперь тебе нужна форма)))) Оберни всё в форму. Я бы дал ей класс .filters  . И потом ещё инпут переделай в button, Саша сказал на вебинаре что они сейчас идентично работают, а с точки зрения  логики странно, что Кнопка Отправки, называется input, как будто это поле ввода )))


проверь, как поведёт себя редактор, если в тексте поста появятся теги HTML или кавычки


提交


Мне кажется ты путаешься в куках и сессии


Great, thanks for helping out


ha!


У меня сомнения в существовании такого заголовка в протоколе HTTP


я бы не доверял куке, если у меня есть сессия


(that happened before the blackout)


а зачем для удаления нужен параметр `head` ?


Дублирование запроса, он у тебя выше в переменной `$query`


LGTM


@c0s I have fixed files as you mentioned. Also I checked the test using rat. Thanks for reviewing.


Замечание по разметке: в id лучше использовать для разделения либо - либо _


У тебя тут подтвеждение, это хорошо
Но больше нигде не проверяется, что confirm = Yes


Замечание по разметке: в id можно использовать для разделения либо - либо _


You better rename this function to getYear, cause it just return a number, it does nothing to do with drawing. Drawing is the process of creating gui elements.


There are two styles of braces/indentation getting mixed here making it unnecessarily hard to read. Can you stick to what the rest of the file is using?


Введите.
И вывеска заведения не всегда подойдет, я уже писал. Наверное лучше сказать Введите название, как на табличке.


Замечание по разметке: отдельная ссылка для img и отдельная внутри заголовка артикла, его кстати можно сделать H1


รวมไปกับ if ( socre < 0 && score > 100 ) return false; เลย
อ่านง่ายกว่า


Why `latin-1`?


Правильнее было бы `if ($_POST['confirm'] == 'Yes') { ... } else { /* redirect куда нибудь на index.php */ }`


Ошибся, проверяется


Замечание по разметке: классы .first-item .second-item и так далее бессмысленны, у нас у всех блоков этого типа - одинаковая стилизация, так что лучше задать им всем какой-то общий, например - .item  или .product или .product-item


У нас в переводах уже есть и show и hide. Они должны подойти (возможно, лучше обновить их свежими переводами отсюда, если там плохие).


hide уже есть в строках.


Замечание по разметке: пагинация это список ссылок, активная - элемент списка с классом .active, ссылка не нужна.


IMHO: If the use of `-fno-warn-orphans` can be avoided easily, I'd go for it... so I'd rather move all instance definitions near their type definition.


เขียนแบบนี้ไม่ค่อยดี การย้ายที่หรือลบ/เพื่มโค๊ดมีผลต่อผมลัพธ์

ควรเขียนไปเลยว่า if (socre >= 65 && score < 80) return 'B';


а ещё было бы неплохо отправить на страницу viewpost.php


Absolutely.  I've always learned it's best to minimize lines like this, so that's how I typically write code.  I'll change it right now.


Вероятно, тут имелось ввиду Номер Дома. Надо уточнить у Игоря контекст этого перевода.


thank you for the review Daniel


อาจจะเปลี่ยนเป็น raise exception แทน การ return false
ผมยังไม่ค่อยเม่นเหมือนกันเรื่องนี้ เดี้ยวลองดูให้


+50 ELO


Это обычный случай `404 Page Not Found`
Желательно показать красивой надписью
Желательно попытаться вернуть заголовок HTTP


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 134](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=726&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **SUCCESS**
Summary: Running Build time: 00:36:56


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 234](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=727&buildTypeId=XbimEssentials_XbimEssentials) is now running


love


น่าจะตั้งชื่อเป็น expectedValue / expectedResult แทน result


Тут многие строки не для редактора, а для Place Page. Лучше это сразу исправить. @igrechuhin @yunikkk поможете?


Thanks!


А это зачем?


I think if you do this there should be at least an option to enforce strict unicode.  One of the main reasons for the major python 3 changes was ambiguity in string types and I think its perfectly reasonable to enforce unicode by default.


Почтовый индекс


good


ใช้ toEqual น่าจะดีกว่า toBe เพื่อหลักหลีกปัญหา เหมือนที่เจอตอนเปรียบเทียบ Array


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.662.79af072d440d57331ebba4d490ae933333c1fe98](http://build.palaso.org/viewLog.html?buildId=68557&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3426, ignored: 125 Build time: 00:12:20


По-британски будет Post Code. Надо будет вводить отдельно британскую версию.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 234](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=727&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:02:25


เทส นี้ค่อยมีประโยชน์เท่าไร
เพราะเราเขียน score > 100 ทดลองเพียบ 101 ก็เพียงพอแล้ว


You are interested in the stack trace there?
++


Для простоты поддержки в будущем поля для INSERT надо перечислять полностью. Иначе у тебя завтра появится новое поле и что с чем именно "забиндится" - непонятно. Вот мне сейчас вообще не понятно.


++, why is everything sometimes null in Java ? :)


Yes, there was no verification on the Detonate Noder link and it worked,
so I didn't think about verification. Then later on found the
RequestHash stuff, which doesn't (work). I'll fix that, too.

On 28/01/16 04:29, Brian wrote:
> @JamesCrompton <https://github.com/JamesCrompton> I think you might need
> to add a call to |htmlcode('verifyRequestHash', 'polehash')| to add
> XSREF parameters. It looks like I messed up on *checking* the XSREF when
> I wrote The Old Hooked Pole, though, because that calls
> |verifyRequestHash| in its check where it /should/ call |verifyRequest|
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/everything2/everything2/commit/3ae5564f0366d712f1bda3318f12f23e74d8d2e0#commitcomment-15722696>.
>


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.672.79af072d440d57331ebba4d490ae933333c1fe98](http://build.palaso.org/viewLog.html?buildId=68556&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3406, ignored: 106 Build time: 00:15:36


Here's an odd thing that you can only see on GitHub, not locally. There's a gratuitous `<!-- -->` right after the figure. Example: https://github.com/jennybc/foo.


cod postal

Тут похоже все переводы поплыли, надо исправлять.


Поштовий індекс


`import path does not begin with hostname`


นอกจากทดสอบ ค่าของขอบบน ขอบล่างแล้ว ควรทดสอบค่ากลางด้วยเช่น

if( score >= 80 && score <= 100) return 'A';

ทดสอบที่ 80, 90, 100 return 'A';


Не очень понимаю, зачем `$_SESSION['postid']`


postnummer


Все эти переводы надо правильно переводить от английского Postal Code.


if(n<9)
sum = n; //You are right, fixed the bug


И тут везде надо заново переводить все строки.


Замечание по читабельности: <ul> находится на том же уровне вложенности что и <а>, они оба - дети блока .container - значит перед ними должно быть одинаковое количество отступов.


Замечание по читабельности:<h1> ребёнок .container, значит у него должен быть соответствующий отступ.


Do you think that we should try to move from using decimal to double?


https://github.com/webmozart/expression would have been great for this ;)


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1259.c1cb4c75078973ea35dd23d4072e55dc31991851](http://build.palaso.org/viewLog.html?buildId=68560&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 857, ignored: 7 Build time: 00:08:08


license header changed in https://github.com/wso2/esb-connectors/pull/516


I think guessit should work with native str types no need to convert to
Unicode.


Эти изменения видимо должны были попасть в самый первый коммит. Надо их вынести из этого коммита и вклеить в первый, я помогу, если нужно.


license header changed in
https://github.com/wso2/esb-connectors/pull/516


Ага, это тоже вынести в самый первый коммит.


Если нечего писать, то comment можно удалить.


It's all built into PHPStorm, the IDE that I use, combined with [Scrutinizer](https://scrutinizer-ci.com/) (and sometimes [Codeclimate](https://codeclimate.com/)). Most of it is semi-automated; PHPStorm aligns = signs because I think it looks better and I am pretty sure (but not quite) that I use four spaced tabs.

When I get home, I'll see if I can commit my PHPStorm configuration files and write something about them. That should at least give you some idea.

Just commit away, and don't bother with the whitespace / tab things. I'll get to it when I'm working with the code. It is usually a sign I can't bring myself to work on actual issues. ;)


Rename the css class from modal to popup.


why is it

```
Interface "/^veth.*/"
```

and not

```
Interface "/^eth.*/"
```


Замечание по разметке: если ты назвал класс .cover-img а потом хочешь сказать что у тебя будет то же самое, только меньше, т.е. ты как бы создаёшь некую модификацию этого класса - то этот модификатор лучше ставить в конце, т.е. .cover-img-small
Сравни css:
.cover-img { ... }
.small-cover-img  { ... }
или
.cover-img { ... }
.cover-img-small  { ... }

на мой взгляд - второй вариант читабельнее и как-то логичнее )))


@xiexingguo i think a better way to fix this is to remove the cast at https://github.com/xiexingguo/ceph/commit/53d068cf271056bdc0060b5e42bfbb6388c7ba37#diff-6d10a1d221da60f4fb9985631ce2125cR734 .


Просто информация: для обёртки картинок есть специальный тег figure, но если ты всё делаешь дивами, то не парься.


дублируется, уже есть выше.


I think we only want the location to show nothing for about:blank.  i.e. if the start page was brave.com from preferences latter, we don't want this blank.


Это переводы из редактора.


@paralen can you make sure the method is over loaded , as a second initialize function, leave the earlier one as it , make another initialize


Замечание по разметке: будет проблематично попасть в этот элемент с помощью css если ты не задашь ему класс. Я бы назвал .availability или вроде того.


Hi Feng
Thanks now build and run fine.

m.

On Thu, Jan 28, 2016 at 2:08 AM, Gao Feng <notifications@github.com> wrote:

> Hi m,
> you could try the patch
> https://github.com/gfreewind/linuximq-HighPerf/blob/master/kernel/v3.x/linux-3.2-imq.diff
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gfreewind/linuximq-HighPerf/commit/7ff578c40cebd1d640472a38c2e31133e785e830#commitcomment-15721762>
> .
>


I must be blind, there it is ;) Sorry for the noise.


@therearesomewhocallmetim префикс editor тут не подходит. Предлагаю простые строки так и называть [today]


first edit conf then put md5 file in md5file folder last run watchdog.sh


А для чего ты p обернул в div? Они оба блочные элементы. Если бы у тебя в этом месте было два абзаца, или больше - тогда бы ещё можно было, но так как сейчас - можно просто дать класс .composition твоему абзацу и сэкономить на обёртке.


В чем смысл:
```
 +                '  FOR SELECT id, parent FROM evt_object WHERE UPPER(objectname) = UPPER(:OBJECTNAME) '#13#10 +
+                '    INTO :LID, :LPARENT DO '#13#10 +
+                '  BEGIN '#13#10 +
+                '    ID = LID; '#13#10 +
+                '  END '#13#10 +
```

Если записей несколько запрос вернет, то какой ИД будет присвоен вообще не определено, так как порядок записей не определен.

Если одну запись, то причем тут цикл?


Думаю нужно пока убрать из коммита.


ควรตั้งชื่อ test ให้สามารถอ่านพร้อมกับ it ได้เลย

เช่น it get score 80 should return A.

ถ้าแบบนี้มันอ่าน it if score is 80, it should return A
มันดูขัดๆ

ตั้งชื่อแบบนี้เค้าเรียนก Domain Specific Languages (DSL) ผมก็ไม่ค่อยถนัดเท่าไร
ไว้เจอตัวอย่างดีๆ ค่อยส่งให้ดู


Merged. Thanks for the patch. Although there are many other issues with broadcasting. One i have just discovered while testing your fix.. https://igniterealtime.org/issues/browse/SPARK-1686


:+1: I love it!


@temasek what do Ya think? :yum:
http://gerrit.aicp-rom.com/#/c/22355/
http://gerrit.aicp-rom.com/#/c/22357/


Did not know that you could make a central R package page. This is rather handy!


I guess it's assumed that the demuxer handles the thread safety.


Этот вариант хуже предыдущего. Дело в том, что в большинстве случаев будет только извлечение, а не добавление записей. Т.е. простой SELECT отработает ГОРАЗДО быстрее чем тяжеловесный EXECUTE BLOCK.

Я просил всего лишь ИЗБАВИТЬСЯ ОТ СОЗДАНИЯ бизнес-объекта, т.е. реализовать функционал в функции класса.

ФУНКЦИИ КЛАССА! Понимаете, такая функция НЕ ТРЕБУЕТ СОЗДАНИЯ БО. И всего то.

Все. Не занимайтесь этой темой.

Займитесь пунктами, которые я вам скинул.


就是查询表里的 access-token 值，根据 access-token 确定是哪个用户，我所说的实现就是指这个。


Please use gst_bin_add_many()


เนื่องจากจะเห็นว่า แต่ละกรณีเราทดสอบค่อยข้างเยอะ

อาจจะแบ่งออกเป็น

-Check Grade A Testing
-Check Grade B Testing
-Check Grade C Testing
-Check Grade F Testing
- Check Invalid Score Testing

แทน เผื่อให้เทสอ่านได้ง่ายขึ้น
เนื่องจากชื่อไฟล์บอกอยู่แล้วเราทดสอบอะไร


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13156](https://teamcity.mesosphere.io/viewLog.html?buildId=115387&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 217 Build time: 00:04:01


My DB is a default installation of 0.90.1 version of GLPI with default users.
With orthagh & this commit
https://github.com/glpi-project/glpi/commit/1625c2fb768613f3cefb2e78c6cb8619a95be510
The installation is OK for me


@pg20 no, in here we have 2 diff name so it works correctly :)


All these g_object_set() calls can be merged in one.


Indeed, I will move this to a another patch.


IMO, this will not work. Access to m_dmx_active must be protected everywhere.


Ремарка: кнопка Купить на странице товара - может быть ссылкой, т.к. если у нас один товар, и мы хотим его купить - то нас имеет смысл перекинуть сразу в корзину, а вот на странице списка товаров, где таких кнопочек много - пользователю скорее будет удобно покликать сразу несколько, добавить все элементы которые он хочет, чем после каждого нажатия переходить на страницу корзины. Исходя из этой логики - кнопка там не должна вызывать переход на другую страницу, а значит её надо делать button'ом а не <a>.
Замечание по дизайну: для всех кнопочек Купить нужно подумать, что произойдёт после того как она будет нажата.
Например, вместо неё может появиться другая - корзина. Или Удалить. Ну короче тут надо будет обмозговать и предложить какое-то решение.
Я бы после этой кнопки добавил ещё пару кнопок, и дал бы им какой-то класс, означающий что они скрыты. Например .is-hidden.


I guess I had been assuming that `defaultUrl` would be `about:blank` or `about:newtab`, and the start page would just be the page shown when the browser is started (ex: https://support.google.com/chrome/answer/95314?hl=en). Do people actually set the new tab URL to be real websites? seems like that would be a hassle to load every time a tab is opened.


Thanks for this. I was just wondering what the advantage is in using `gather_` over `gather` and `aes_string` over `aes`?


V tomhle případě třeba active-layer
Viz [commity](https://github.com/osmcz/osmcz/commits/master) ;-)


Old syntax. `merchant: “myshop”` should work fine. Does this in anyway affect our smoke tests in auctionet?


Good info here <http://r-pkgs.had.co.nz/man.html#man-packages>


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13159](https://teamcity.mesosphere.io/viewLog.html?buildId=115393&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:03:56


I committed this to the codebase.


Да правильно, в Specification.md есть такие строки:
- В блоке с хлебными крошками активная страница (последний пункт) не является ссылкой и не реагирует на наведение.
- В пагинации активная страница не является ссылкой и не реагирует на наведение.


Since slick.js is removed, what is the proper way to add 3rd party carousel like that? Is it through the new frontend template structure and the coming theming capabilities?


Old hash syntax. I guess it’s not a big thing. Please tell me if I should refrain from making notes about it. :smile:


Thank you!


@Nadahar I committed a couple of MVP fixes for those other issues you mentioned. They're not perfect but can be improved upon over time depending on how much people use this feature.


to vidim:) ale asi bych potreboval tabulku kde bude - cast_aplikace:seznam souboru co k tomu patri
nebo tak neco


I think more thought needs to go into the smarty replacement since I think there are actually 3 different smarty modules in phpgacl, postnuke calendar, and within OpenEMR main codebase. Replacing these all would required very large amount of testing and would likely bring in many unknown bugs.


Did I break this? Ouch, yes I did, sorry.


Done with latest https://github.com/sqlmapproject/sqlmap/commit/4916f1b2b247b355a1a7f0cd90bd32c840f8eda3

Thx


`attack` doesn't take `errors` and `results` as input, see the updated sample attack.


In src/edu/stanford/nlp/naturalli/OpenIE.java

This commitment triggers the following exception:
```
if (enforceRequirements) {
        Set<Class<? extends CoreAnnotation>> allRequirements = an.requires();
        for (Class<? extends CoreAnnotation> requirement : allRequirements) {
          if (!requirementsSatisfied.contains(requirement)) {
            String fmt = "annotator \"%s\" requires annotation \"%s\"";
            throw new IllegalArgumentException(String.format(fmt, name, requirement));
          }
        }
        requirementsSatisfied.addAll(an.requirementsSatisfied());
      }
```

If we replace the added lines to either of the following, the exception is not thrown.
```
if (resolveCoref) {
 requirements.add(edu.stanford.nlp.hcoref.CorefCoreAnnotations.CorefChainAnnotation.class);
}
```
or
```
if (resolveCoref) {
 CorefCoreAnnotations.CorefChainAnnotation.class);
}
```


Hi,
I committed all of your work, except for the phpgacl smarty upgrade. I think more thought needs to go into the smarty replacement since I think there are actually 3 different smarty modules in phpgacl, postnuke calendar, and within OpenEMR main codebase. Replacing these all would require very large amount of testing and would likely bring in many unknown bugs; not saying it is impossible, but would be good to avoid if possible.
-brady


Can we validate 'body.doc' field as well?


I think it's a fairly used option but it seems reasonable to keep your assumption instead in this code.


я бы не стал value указывать русскими буквами, это же в запросе пойдёт... Скорее я был бы склонен сделать либо так:
  value = "accessories"
  value = "shaving-tools"
  value = "care-tools"
либо так:
  value = "1"
  value = "2"
  value = "3"
(Чтобы в запросе это выглядело &groups=1& ведь бэкэнду скорее всего наиболее удобно - просто получить порядковый номер группы, чтобы обработать этот запрос)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13158](https://teamcity.mesosphere.io/viewLog.html?buildId=115392&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:11:04


There's a general Hadleyverse principle that when programming you should avoid functions that use non-standard evaluation (NSE). Code in a package counts as "programming" vs, say, a script you mostly run interactively. Presumably you noticed all the check warnings about "no visible binding for ..." ? This also makes those go away, which you will need to do for CRAN submission.

TBH I'm not sure how well it's written up all in one place, but you can get more info in the [NSE vignette](https://cran.r-project.org/web/packages/dplyr/vignettes/nse.html) for `dplyr` or in this [SO thread](http://stackoverflow.com/questions/9439256/how-can-i-handle-r-cmd-check-no-visible-binding-for-global-variable-notes-when/12429344#12429344). So in `dplyr` and `tidyr`, when programming, you generally want to use the version of functions that have the trailing underscore.

That's also why I switched your `aes()` calls to `aes_string()`.


@hvelarde help needed here


Ok sounds good :) also I am committing deprecated constructor related commits to new branch "php7-deprecated-constructors"


Замечание по разметке: кстати, у нас в барбершопе много одинаковых кнопочек, чёрных, я бы дал им всем общий класс btn. и если предположить что у нас могут быть в будущем кнопочки другого цвета где-то, то я бы сделал чёрным вот так: .btn.btn-dark чтобы в дальнейшем можно было бы сделать .btn.btn-light
Т.е. класс .btn будет хранить общие стили кнопки, а в его модификаторе будем указывать цвет.


You're probably right


WIth the change, `/local p` becomes superfluous.


The following doc(s) have been deployed to the [machinetok](http://machinetok-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/local/cli/machine-tokens](http://machinetok-static-docs.pantheon.io/docs/articles/local/cli/machine-tokens)


Я тебя сейчас расстрою, но пока что давай без таблиц в базе для notes и notebooks :)


Yeah, I should not copy code without looking at it. Thanks.


Замечание по разметке: в specification.md написано:
- Карточка товара: изображение товара — это ссылка на страницу товара.
- Карточка товара: название товара — это ссылка на страницу товара (название состоит из 2 строк, но по сути является одним блоком).
- Карточка товара: кнопка «Купить» — по клику товар добавляется в корзину (макета корзины нет, не делать).
так что нужно это учесть )


Line spaces should only be used when starting a new code block. chained methods are considered on code block, therefore line spaces in line  9,17,24,35,43,44. are unnecessary.


Maybe. (?)
I was using "eager evaluation" as the opposite of "lazy evaluation". https://en.wikipedia.org/wiki/Eager_evaluation


вот тут всё отлично :)


BTW I don't love the way I excluded `rows` from `gather_()` but don't know a better way off the top of my head (`names(.)[-length(.)]`).

Conversely I used `mutate()` instead of `mutate_()` because it made using `row_number()` easier. So I'm not following the principle perfectly above myself.


В дальнейшем у нас вместо текста, внутри ссылок будут иконки, но пока всё в порядке.


> Is your intention that the LVM team actually makes this safer in the future or that there is some use case where this is indeed useful?

I hope it will be made safer at some point. As Zdenek (at least I think it was him) suggested, there should be some cleanup done that will make sure the pool can be reused without causing inconsistencies. It for example makes sense, from my point of view, to take the cache pool and attach it to a different device instead of destroying recreating it.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26661/testReport/) for this commit**


> Added a boolean destroy_cache with commit 0440cb6

Wonderful, thanks!


@andybalaam thanks for fixing that. I daresay I could have figured that out.


:hankey:


For update super-admin profile, a sql query like this one should be correct :
```sql
UPDATE `glpi_profilerights` rights
INNER JOIN `glpi_profiles` prof
   ON prof.id = rights.profiles_id
SET rights = rights + 128
WHERE name IN ('ticket', 'problem', 'computer'  ... )
   AND prof.name = 'super-admin'
```

We need to complete.


Замечание по разметке: лишняя вложенность, див тут незачем ставить.


third file additions...


Sounds good. I'm gonna start collecting/recording some details regarding the crazy smarty code in OpenEMR here to help clarify things a bit:
http://www.open-emr.org/wiki/index.php/Smarty_Module


Line spaces are part of coding best practices to make code readable. However, you should at all time ensure consistency. I recommend you use one line space after each code block.


comments to test2


Мы сейчас на странице магазина, надо как-то это учесть. Можно li добавить класс .active  И ещё ссылку на саму себя надо бы убрать из меню.


TeamCity LabKey :: LabkeyModules15.3 :: Git sqlserver 2014 [Build 101](https://teamcity.labkey.org/viewLog.html?buildId=299761&buildTypeId=LabkeyModules153_GitSqlserver2014) outcome was **SUCCESS**
Summary: Tests passed: 218 Build time: 00:13:48


TeamCity Chorus :: chorus-precise64-chorus-2.5 Continuous [Build 2.5.1015.bab9ad24dc6ac370cd6b01ef876ee8b815ba2fe8](http://build.palaso.org/viewLog.html?buildId=68570&buildTypeId=ChorusPrecise64v25Cont) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:17:20


Yeah, intentionally didn't clean up a lot of syntax since the future of this integration is uncertain. If I have reason to touch this lib again in a few months time when we know more, I'll fix these.

Guess we don't have any smoke tests that do this – nothing has failed :)


Заметка: стандартный паттерн - делать списки списками )) Ну и span тогда тебе не понадобится.


Yeah, intentional choice (as explained in previous comment) so no need to mention it :) But good that you notice :)


great.

2016-01-28 9:17 GMT+01:00 Mario Román <notifications@github.com>:

> Maybe. (?)
> I was using "eager evaluation" as the opposite of "lazy evaluation".
> https://en.wikipedia.org/wiki/Eager_evaluation
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/JJ/2016-ea-languages-wcci/commit/9426928709bd235dfde9c731d785b8f6ed08f797#commitcomment-15726247>
> .
>

--
JJ


Include only the dependencies you need in your functions, `toParams`, `fromState` and `fromParams` are unnecessary in this context. You code could look like this.
``` js
     $rootScope.$on('$stateChangeStart', function(event, toState) {
           // TODO
     }
```


nothing


You misspelled Richard Warburton's surname.


т.е. логотип вообще выходит из списка или просто спан в списке без ссылки?


Замечание по разметке: вообще трём мелким фоткам я бы всё же дал обёртку, но конечно можно и без этого. А вот по поводу имен классов, смотри, у тебя есть сущность photo, и у неё есть две модификации - маленькая и большая. Я рекомендую сначала указывать сущность, потом её модификатор.
Смотри как это бы выглядело в css:
.main-photo { ... }
.small-photo { ... }
или
.photo-main { ... }
.photo-small { ... }

Как тебе кажется, что лучше смотрится, читабельнее и понятнее? На мой вкус - второе )))


Remove the BucketListService injection since you are not using it in your `app.run` method


TBH I didn't test no.
But you are relying on the provider API not to fall over.
Would seem like a simple change  ... just in case a new provider or a future revision of the API isn't so accommodating.


Hahaha! Same thing. Portfolios were invented to never be finished I suppose! :smile:


maybe it is useful


done


Y a-t-il une différence entre pj et un autre `Character` ?
Est-ce que l'on ne pourrait pas imaginer qu'un monstre s'attaque à un autre ?


Actually, this change brings a natural way to deal with strings in both python 2 and python 3.

If running Python 2, a user giving `str` native strings will retrieve matches with `str` values. If a python 2 user gives u`unicode` strings, it will retrieves matches with `unicode` values. (And I want users on python 2 to be able to give unicode strings)

If running Python 3, a user giving `str` native strings will retrieve matches with `str` values. But it's unicode naturally, has it's python 3. It will even work with binary, but it's not recommanded.

Keys of the matches dict are always native `str` objects though.

Before this patch, we were forcing python 2 users to convert any str objet to unicode, but when trying to integrate guessit in subliminal, I really saw that it was a mess and overcomplicated for the user, so i've rethink the whole string handling in guessit and here's the result.

guessit internals always use native string of the platform (`str`), and guessit api function take cares of the conversions if user doesn't input a native string.


[kione - Germany](https://kione.de)


@badone, i am very sorry, just reallized that the prefix should be "common" but not "osd".


This method formats a unformatted XML string. Therefore a XML file is not given in the method. I updated the message as "Failed to parse the unformatted XML String. "  Shall we show the unformatted XML as well?


обертка в плане div wrapper?


me :-)


Gotcha, thanks for the catch!


я посчитала , вроде 10 на 10?


Non, ce n'est pas voulu.


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.169.8515507208c1539220ebee854cf5e7e479e1de6d](http://build.palaso.org/viewLog.html?buildId=68565&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 943, ignored: 50 Build time: 00:41:02


Контент забыл положить в блок


I did `git grep incab` in the auctionet repo and found:
`public/tools/AuctionetDibsManager.user.js:// @include      https://secure.incab.se/manager/debiadmin.jsp
smoke/debitech_spec.rb:    sleep 3 while current_url.include?("incab.se”)`
It might be due to something else tho…


In the first run for some element, the oldStyles is undefined which results in direct execution of the line ' elemWrapper.styles = styles;' and assigns reference of the actual css object. This unintentionally modifies, the actual css object. See this on fiddle:
http://jsfiddle.net/a7ow4Ljn/

See this on first run,
![1](https://cloud.githubusercontent.com/assets/14175871/12639077/b90e195e-c5c3-11e5-97e4-e30a2aaae42e.png)

On 2nd run:
![2](https://cloud.githubusercontent.com/assets/14175871/12639083/c686f286-c5c3-11e5-9f1a-166233c340ea.png)


Тогда уж в принципе можно и .item-to-cart мне кажется


Forgot about slash direction - My bad!


It could be worth noting: https://www.ruby-lang.org/en/news/2014/01/10/ruby-1-9-3-will-end-on-2015/ ("Support for Ruby version 1.9.3 will end on February 23, 2015”).


May be it should work not only for list? Also for any iterable objects.


thanks haha (:


:laughing:


It is known exactly.
 SecureRandom secureRandom = SecureRandom.getInstance(SHA_1_PRNG);
https://github.com/ChamaraPhilipsuom/carbon-identity/blob/0b739519190459baa7fe9ed4b9826cf1a1f41978/components/user-store/org.wso2.carbon.user.cassandra/src/main/java/org/wso2/carbon/user/cassandra/Util.java#L116


I don't think returning the `AerospikeClient` instance isn't a good idea, as that class exposes the old API that we want to replace. I think we should wrap the `AerospikeClient` C++ class with a lightweight JS class and implement all the `get`, `put`, ... commands on that class. The `Aerospike` object would then just hold an instance of that class in `_currentClient` and delegate all the commands to that client object. So the `Aerospike` object and the client instance returned by `Aerospike.client()` would have the same interface.


Ian,

I think you left this file out of your last commit. The project is present but the unit tests file is a dead link.

Can you push this file up also.

Thanks
~Eoin C


Ромбики вас научат на вебинаре. Псевдоэлемент скорее всего.
И да, ты понимаешь что тут классы - не обязательны? Разница между их наличием и отсутствием - у css селектора, если их не поставить, специфичность будет выше, т.е.
.item-components > li будет 11
а
.component будет 10
но вообще .component слишком общее название, я бы тогда уж использовал префикс .item-components-component, а это получилось бы громоздко. Тогда я бы принял решение оставить li без класса :)))


@cheeaun where is my "%"


I am not certain what the best defaults and behaviour for these two timeouts really are. I think I want to scrap the H2* variants and just use the values from ```Timeout``` and ```KeepAliveTimeout```.

The processing model for h2 connections is different from the http1 case. So it is not straightforward how to make best use of these timers.

Your site is a good case for the ones that need long timeouts for request processing, as it is using long polling where requests do not produce data for a minute. How would you prefer to configure this?


I wonder if this should be `acceptType`?

I tried to cross-reference what Cordova does for the system webview, and it's a bit complicated due to Android API changes between WebView versions. Allegedly in Android 5.0+ it will use the accept attribute value properly. For earlier versions, [they seem to hardcode](https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java#L252) `*/*` as the acceptType.

But does `acceptType` have the value of the accept HTML attribute?


**FAILURE** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 263](http://ci.infinispan.org/viewLog.html?buildId=34567&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for 9e23e9747b4aaa97f81d96ebb7f37b1a6efa3061
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:00:05

Process exited with code 1


Your indentation is way off in line 11-13. Indentation is core principle to best coding practises, you should ensure that your indentation is consistent all through your project. if you are using sublime install a [prettifier](https://github.com/victorporof/Sublime-HTMLPrettify) plugin to avoid inconsistency. Refer to [Udacity](https://udacity.github.io/frontend-nanodegree-styleguide/l) style guideline for more information.


But not on strings. The idea is to expand subparsers inside iterable object and leave other objects not touched. I'll investigate about other possibilities here.
Thank you


delete the line no 11.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.577.8515507208c1539220ebee854cf5e7e479e1de6d](http://build.palaso.org/viewLog.html?buildId=68571&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 931, ignored: 56 Build time: 00:17:22


Leave Comment1


Хороший подход!


Мы сейчас тут, нужно дать понять об этом ползователю. li.active и убрать ссылку - самый верный способ)))


lol


Let's add [debug](https://github.com/visionmedia/debug) so we don't have to remove this logs before publishing.


I'd agree. If anyone is running such an old version of ruby they are probably used to using their own forks of gems too.


Seems a bit odd to have `[None]` instead of `[]`


Заметка: стандартный паттерн - делать списки списками )) Ну и span тогда тебе не понадобится.


Тут играет роль отчасти общепринятый стандарт.


Handle PCH's first so we can get a complete set of the dependencies we'll need for the source files.


You don't need to set the version in the package.json. We have the scripts `patch/minor/major-release` for that.


Why is `TemplateHaskell` needed? If we do this, we can't build `aeson` w/ some GHC configurations anymore


save read


All source files depend on all PCH's.


:tennis:


What do you think https://github.com/pacoguzman/route_translator/commit/15666588bc3b825d82ffbcdc105f4bee4fdda3d8 ?


'node-stringify' is not a dev-dependency, but a dependency.


если назвать Форму .filters, то можно принять её за Блок, тогда дальше будут .filters-group-title (например)


cc: @Zoltrix


add a camera creative item


Thanks!


PCH's aren't actually object files, but it was easier to treat them as "object files with a twist" than to think of a better way to do it.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1255](http://teamcity.monogame.net/viewLog.html?buildId=14085&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


`<FONT COLOR="RED">`
htmlタグは下のhtmlをまとめているところで出した方がいい。

このhtmlタグは閉じられていないようです。
基本的にはタグを開始したら閉じましょう。
`<font>～</font>`

htmlタグは小文字で書かれることが多いので、
統一したほうがいいです。


Hilbert.


Turns out, this feature isn't supported in Chef `11.8.2`. :frowning:


Если коротко: через псевдо-элементы лэйблов можно, возможно это даже есть где-то в курсах... не помню с ходу


С комментарием понятно. По поводу создания новой сущности прошу пояснить. Само название метода говорит о старте существующей задачи. Следовательно, это смена стейта. Следовательно, изменений существующей задачи.
А любые создания через create метод.


Погугли alt-codes :)


C source files depend on the GCH file generated with the C compiler and flags; and C++ source files depend on the GCH file generated with the C++ compiler and flags. I put the include argument earlier than everything else so that it will still come before `compiler.cflags`, for use cases where you want to put something like `-include "common.h"` into `cflags`.


`BeanUtils#instantiateClass` ?


Тоже аргумент)


I don't have a problem with supporting native string types, but I think it would be nice to be able to enforce unicode as its the more correct way.


##### Code Quality critical
	You have variables that are not used in line 22 and 33. Ensure that all variables declared are used. if you want to give the user custom message use `if …else` to verify of the error actual exist. you code could look lie this.

``` js
    .catch(function(err){
       if(err)
          toastr.error('Invalid credentials');
       }
    });
```
The same applies to line 55, 62 107,115 and 124,145 and 169 in `bucketlistcontroller.js`


`BeanUtils#instantiateClass(constructor, args)` ?


Thanks for the PR. Wouldn't the badge be shown very large now? I guess the PR should set make sure it does not scale to large.


Ну, кстати, по поводу размера файла в задании не было речи. Но если сделано, то хорошо.


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/9312/testReport/) for this commit**


This totally belongs somewhere else, but this is where I put it.


My bad. Removed the debug log.


Mein Commit....


The idea seems positive. You should try a full update by calling update_stats with depth/2.


@username-from-outer-space Затраты по времени вверх)


The dual-language thing means we end up with two outputs from one input; so I made these methods return a list instead of a single item.


Thanks !


Don't try to send GCH files to the linker.


what is a persitency manager and why do you use it? is it the case here?


remove datarootdir


Correct! :smile: Removed.


Будет изменений: 1


Could you start splitting such patches up into several ?

Would be usefull to have a a commit which announces that the NotFoundException is setting the text per default now. And then the update according to this. If you would have written that into the commit msg everyone can see that there is a "logical" change, and noone needs to take a closer look on the diff to see this.


it is ok


@username-from-outer-space возражу.
Во-первых, общепринятая практика и конкретный паттерн для этого случая.
Во-вторых, решает проблему DRY через вынесение подготовки данных в фабрики и сиквинсы.
Да, лишние зависимости, но тесты не то место, где надо с этим заморачиваться.


@jasonkarns Do you mean create stand alone script files?


@Laizerox I'm glad to see you back. I was worried about you. Take care! :heart:


what is wrong?


@username-from-outer-space Хорошо!)


Метод RemoveByPattern надо перенести в \\Np.Core\Caching\Extensions.cs из \Nop.Core\Extensions.cs. там extension методы, относящиеся к кешированию


xzxczxc


But then I'd have to update it again if 1.8.10 comes around.


второе, но но только на первой странице


Я так понимаю, что тут вход происходит конкретно на сайте osm.


Замена

if (items == null)
     return;

на

if (items == null) return;

немного смутили. все-таки мы пишем имено так везде (return на отдельной строке)


Тут можно добавить кнопок, появление которых тебе кажется логичным после нажатия кнопки Купить.
Я бы добавил Корзина. и дал бы пока ей класс .is-hidden


hey, thank you for reporting.
I'm doing the HTML validation for the survey part (which is super important, more than for the admin part,  to be sure that the survey will display correctly on any screens). W3C validator doesn't allow 'disabled' on a element. But Carsten asked me to find a way to get the same result. So I'll work again on this one.


The way `struct ssl_connect_data {` is written, still gives the impression that no SSL back-ends are exclusive. Wasn't that the point in the PR?  If they're all exclusive, should this be written as:
```
struct ssl_connect_data {
#if defined(USE_OPENSSL)
  ...
#elif defined(USE_GNUTLS)
  ...
#elif defined(USE_SSL)
  #error Something is wrong here!
#endif
```


`$ope`のエラーチェックがないので、
この`default;`を活用してエラーチェックしてみましょう。

例えば`$ope`の`!`が入っていた場合とか


Can do that, thought it's small enough and anyway reviewed, because it's in a PR.


тогда надо установить плагин, расчесывать код, чтобы была видна вложенность


Arguments to use when precompiling headers, for C and C++ respectively.

`-MP` makes GCC emit additional phony Makefile targets for each of the depended-upon files, which isn't actually necessary, but it happens to make parsing them really trivially easy.

`-fpch-deps` is necessary to make GCC actually spew the precompiled header's dependencies when compiling a source file that includes it; without this, the build system fails to realize that the source files depend on the header itself, so they don't get rebuilt when it changes.

`-x c-header` and `-x c++-header` are probably not necessary, but they'll definitely make sure that the compiler chooses the correct language when parsing the header.


В общем-то пагинация (обычно её так и называют) всё-таки предполагает переход на другую страницу, и список я бы верстал списком.
т.е.
ul.pagination>li*4>a[href=#]  если говорить в нотации emmeta


ack


I guess this will entail some work correcting the checkstyle violations in the tests, e.g. unused imports etc.


ack, very good


`-fpch-deps` is necessary to make GCC actually spew the precompiled header's dependencies when compiling a source file that includes it; without this, the build system fails to realize that the source files depend on the header itself, so they don't get rebuilt when it changes.

Now that I think about it, I'm not sure if `-fpch-deps` actually needed to be in the PCH flags too, or just here... shouldn't hurt anything though.


Typo fixed in 1f3cd5cc27540fbc14a1ae27711eb72243e77f72


`$b`が`0`だった場合に、
0の除算が発生してしまいます。

環境によってはエラーになるので、
`$b`が`0`の時は計算しないように修正しましょう。

エラーメッセージも出してね。


1. Full-fill README file
2. This is not a complete project: Makefile missing


Hrm: I didn't intend to include this one. I put this because, because I think this comment is invalid as this function uses `impossible`.


Thats nothing you will see in a pr, since those are sqashing the commits into one (and nearly everyone just looks at the changed files).

Doesnt matter how small a patch is. One patch should change one thing. So you dont need "and" or a enumeration or changes in the commit message.


I think you are still missing `process.nextTick` here, don't you?


variable names should start with a lower-case letter, i.e. `errMsg`. I personally just use `msg`.


I think we should continue to test against Aerospike.status.AEROSPIKE_OK instead of hard-coding the status code 0 all throughout the code.


Yes, `mktemp` is deprecated, but all of the "secure" alternatives involve atomically creating and opening a file, when what I actually want is a damn FIFO.


ditto


Мне кажется, или отступ form от .container стал больше? Если не кажется, то надо сделать стандартные 2 пробела


this seems to break travis-ci


тут таки есть какой-то контент, в поле label ))))


There is a problem here.
Adding the space after the 'comma' and the 'and' will cause the split to separate words like `brown toast`.

We should add it as rule on its own before the `please order` rule


return would have worked the same, but shouldRespondWith takes a `WaiSession SResponse` but we've run the request already so pure makes it a `WaiSession` again.


Ah, I see you reverted this change in a later commit. In that case leave this code unchanged, we should leave the fix out of scope of this PR for later.


Hvorfor er ikke "espen.askeladd@eventyr.no" en godkjent e-post, ønsker du at e-postene bare skal bruke "ntnu.no" som domene?


#### Code Quality Critical

The front end is supposed to consume the API. Therefore only the user object supplied by the backend should be injected to the root scope and not the localStorage. Line 16 and 17 are redundant and leave you system vulnerable to attack. Your code could look like this.

``` js

  .then(function(response) {
     $rootScope.currentuser = response;
     // Avoid $localStorage.currentuser = $scope.user.username;
   });

```
LocalStorage should only be used to persist the token.


Using an environment variable lets us get away with not having to mess with the argv at this late stage, or scare the user with ugly temp file names in their compiler invocation. `SUNPRO_DEPENDENCIES` is the same as `DEPENDENCIES_OUTPUT`, but it doesn't suppress system header files. Basically, it does what we want.


ok


Does this really work for the ternary? Shouldn't this line
`$smarty->createTemplate($template, $cache_id, $compile_id, $parent ? $parent : $this, false);`
better be
`$smarty->createTemplate($template, $cache_id, $compile_id, ($parent ? $parent : $this), false);`?


done


Where is `IdName` coming from? Perhaps it should be `PKName` instead?


> We can always fix anything that breaks, right? (By we, I mean you of course, since I'm going up a mountain ;-)

Yes, you can fix things when you come back ;-)


Так не вариант делать. Тестовые данные должны быть всегда уникальны.


Need to handle `EWOULDBLOCK` here, so that if the compiler doesn't spew the dependencies (e.g. due to errors in the source file), the empty pipe won't crash the build system.


espen.askeladd@eventyr.no er godkjent som e-post isolert sett, men ikke for en person som ikke heter Espen Askeladd. Dette ble også kommentert på Piazza.

From: Kotlarz <notifications@github.com<mailto:notifications@github.com>>
Reply-To: hallvard/jexercise <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Thursday 28 January 2016 09:56
To: hallvard/jexercise <jexercise@noreply.github.com<mailto:jexercise@noreply.github.com>>
Cc: Hallvard Trætteberg <hal@idi.ntnu.no<mailto:hal@idi.ntnu.no>>
Subject: Re: [jexercise] Fjernet bruken av IllegalStateException, bruken og regelen var (75b9022)

Hvorfor er ikke "espen.askeladd@eventyr.no<mailto:espen.askeladd@eventyr.no>" en godkjent e-post, ønsker du at e-postene bare skal bruke "ntnu.no" som domene?

—
Reply to this email directly or view it on GitHub<https://github.com/hallvard/jexercise/commit/75b90222f506985e61215c98429bdbad35306b87#commitcomment-15727010>.


I would name it `AX_CHECK_GIR_SYMBOLS_GJS` instead, so that other versions could be `AX_CHECK_GIR_SYMBOLS_PYTHON` (for example) and hence only differ by suffix, making grepping for it easier.


`RAILS_ENV=development rake all:start`


...соответственно, я должен лезть в фабрику и смотреть, что мне там сгенерировалось.
Лучше сгенерить фабрику в before-методе и использовать @user.email при проверке. Мы отвязываемся от постоянных данных.


The temp file won't get cleaned up if we encounter a problem while it's open. I'm not a Python wizard so I don't know how to make that happen automagically.


Note: help has a use. Maybe the display should be improved, not removing the help.


Нормально) А я бы влепил список сюда, всё равно )


K


Much cleaner.


Right now bazel build //... does not [work](http://stackoverflow.com/questions/35043876/how-to-set-externalandroid-sdk-when-it-is-not-bound-to-anything/35048084#35048084). But it should been fixed in [e87849b](https://github.com/bazelbuild/bazel/commit/e87849b8d391af8f5d98e3a91e680e88a1264b64) so its only a matter of time before it works again.

`bazel build //shipshape/...` works right now though. (or I think I will get it working, have some gcc compilation issues, but that might be my fault)


`rake jobs:work` for development, I think.


Remove code line 6 and 9. When angular templates are loaded, the controllers associated with them are also run. This makes you `$(document).ready();` redundant.


Is `db:create` necessary?


This looks like a bug (datadog api expects 'points', not 'metrics'.


As does this.


Would be useful if this error message specified which symbol or symbols were not found.


What changed? Why the version bump?


Polariscope is a top-of-the-pyramid blackbox test management and execution app. _Polariscope uses the Web Action API, a repository which will be released later._


@uwetews I think it is an interesting question, why the 'global' was removed. Did you see the commit comment in smarty_internal_compile_include.php by @atippett ?


Might make sense to add some links to the documentation to define GIR and GJS.


Nope, it was just the simplest thing to do at the time. Happy for you to go with the mean distance, it sounds more robust anyway. Just checking though: it will still throw a warning if the slice separation isn't constant, right?


Wrong prefix in the example.


Сиквинсы использовать лучше в таких случаях.


`if(ctype_digit($num_1) === false){`
は
`if(!ctype_digit($num_1)){`
と書いても同じ意味になります。
下の方がよく見かけます。


Not that awesome.


fixed on gh-pages branch, Daniel already merged the code


@piton Точно, вчера похоже куда-то не туда смотрел и перепутал прикрепление документа с началом задачи:satisfied: Действительно PUT бы был уместнее:thumbsup:


Мне кажется, что с точки зрения логики здесь количество найденных отелей - это результат предыдущей фильтрации, и оно найдено не сортировкой а фильтрацией (т.е. слово found в сочетании с sort меня смущает), но с точки зрения компонентного подхода в именовании классов вполне нормально.
Сейчас ещё раз подумал как бы я сам назвал, наверное так:  .sort-elements а значение обернул бы в span.sort-elements-count


This attribute will only make sense for named_maps. It's basically what we're using now in CartoDB.js to differentiate between a "named map" and an "anymous map" (we check it `template_name` is present). What's the behaviour with this change? Will `CartoDB::NamedMapsWrapper::NamedMap.template_name(@visualization.id)` always return something (both for named and anonymous maps)?


```js
const { results, searchedValue } = this.props;
```
looks much better IMHO


Don’t think this belongs here. If you want backwards compatibility for within Endless projects, it’s probably best done from within the Endless code base, because it’s meaningless for everyone else.


玩转ThinkPHP框架！


I push another commit, `git grep -l 'map.*<$>'` caught some more


я бы назвал .hotel  или .hotels-item или .hotels-element


Thanks for review. I fixed it at db7ac2dd301cca38ad1451507a8c14c614a46143 .


@EmreTr1 You know theres no camera since MAAAANY versions of mcpe?


in this case here instead, probably destructuring doesn't add much:

```js
return { result: this.props.result }
```
or
```js
const { result } = this.props;
return { result };
```
are both better IMO


Nice work but wtf is going on with that octopus cat?


Complicated. You do not actually need to monitor subprocesses continuously, you can just start them at the beginning of the test, and request termination, wait and kill on timeout at the end. This won't require threads or asyncio.


В декоратор


@peter76111 what ?


same as https://github.com/nerder/gh-explorer/commit/d1d9a730d1a230e27a80f02163cd2e3de0d33d1e#commitcomment-15727167


I will push a fix in a few minutes


nothing more to be destructured here I think :P


Ну, в таком виде смотрится несколько громоздко, но когда это будет сеточный блок, просто для позиционирования, тогда это станет более нормально.


Yes, correct...than everything is fine :)


@scottdavis Do you plan to put this into a release soon ? Would really like to avoid running a github gem in production. :)


Если продолжать логику именования которую я предложил выше, то тут бы получилось: .hotel-info или .hotels-element-info или .hotels-item-info ))


This doesn't work for me (always getting the error when starting the server)

and also is not compatible with rails 3.2
https://travis-ci.org/enriclluelles/route_translator/builds/105368033

Please run `appraisal rake` (and fix `.rubocop.yml` accordingly) after any edit


TeamCity LabKey :: Trunk :: Community :: CDS postgres 9.5 [Build 81](https://teamcity.labkey.org/viewLog.html?buildId=299763&buildTypeId=LabkeyTrunk_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 14, passed: 34 Build time: 01:07:15
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogAndLinearScales: <no details avaliable>

org.labkey.test.tests.CDSHelpCenterTest.verifyHelpCenter: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyCounts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

##### there are 4 more failed tests, see build details
```


Thanks for this Eoin, I am not sure what happened here. I will recommit this file this evening when I get home. Not sure why there are missing files.


fixed the issue #5


文字列の連結時の`.`の前後には半角スペースを入れた方が見やすいです。
`htmlspecialchars(" = ".$answer."\n");`
↓
`htmlspecialchars(" = " . $answer . "\n");`


I did similiar replacements a while ago - https://github.com/kamk/electrum-server/commit/75eb7b9910802545056ac3b847bbdab5df6c6fdb


А что не через фабрику?


Indeed it is. That was probably the longest discussion when the new version of the note was discussed[1] and is also noted explicitly in the status section of the new version[2] (see last bullet point)

[1] https://github.com/w3c/microdata-rdf/issues/10
[2] https://www.w3.org/TR/microdata-rdf/#h2_sotd


##### Code Quality Nitpick

Code is like poetry, one should be able to understand what you are saying by reading your code. All the variables should be in camel case `BucketLists`. This line could have been structured like this.

``` js
       $scope.BucketLists = Bucket.lists.all();
```
This means, go to my bucket service `Bucket`, find my lists `.lists` and get me all the bucket lists `.all()`. Similar changes should be made in the bucket list service to conform to this structure. see comments in the BucketListService.


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/9313/testReport/) for this commit**


Intermittently!
Vermutlich je nach Timing der threads kommt es vor, dass ebusctl im Listen mode nicht mehr reagiert.
Das ist nicht auf Anhieb reproduzierbar und tritt evtl. nur auf, wenn es viele Messages auf dem Bus gibt (?).
Mit viel herumspielen bekommt man ein Gefühl dafür, den Fehler öfter zu provozieren.
Wenn man entweder in ebusd oder in ebusctl das Handling der trailing \r manipuliert, tritt das Problem nicht mehr auf.
Da die Veränderung der message durch Anhängen von \r in ebusctl geschieht, fix it there.


Det gir mening, takk :+1:


##### Code Quality Critical
 Ensure that you remove all the debugging code before you deploy, this may lead to disclosure of sensitive information which makes your system vulnerable


Am 27.01.2016 um 23:58 schrieb LLeny:
>
> On purpose?
>
still I dont like it.


It's a valid comment, so merging it.


Sure!


:trophy: :sparkle: :yellow_heart: :cool:


### (エラーメッセージの)配列について

配列はarray()で初期化してください(13行目)。
今の方法だと初期化できていないです。
○ `$error = array();`
× `$error[]  = "";`

また、今のままだと配列に不要な空文字が入ってしまっています。
例えば、23行目付近のエラーが発生した場合
* 13行目で `$error[] = "";`
* 24行目で `$error[] = 'Error : num_1 Please input number';`

と処理が行われ、最終的に以下のデータが入った配列となります。
本来は1番目の要素のみが入っているべきで、0番目の要素は不要です。
⇒配列の13行目の修正を行えば直ります。
```
array(2) {
  [0] => string(0) ""
  [1] => string(5) "Error : num_1 Please input number"
}
```


@ahmadseleem  C'mon, don't worry about such a minor thing. Glad to see a new version. Just updated and tested — works for me. Take care!


Нормально


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13162](https://teamcity.mesosphere.io/viewLog.html?buildId=115404&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 217 Build time: 00:07:59


This warning should rather apply to `runserver`: focusing on `--insecure` can give the false impression that using `runserver` is fine.


`!`は否定を表します。

```
if (is_numeric($b)) {
} else {
    hoge();
}
```
は
```
if (!is_numeric($b)) {
    hoge();
}
```
と等価です。

下の方が見やすいかと思います。


Is `boost` the `boost::format` referenced a few lines above? If yes please use the same naming `boost::format`.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13161](https://teamcity.mesosphere.io/viewLog.html?buildId=115405&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:08:18


Этого пункта, вроде как, сейчас в UI нет - есть вход с логином и паролем, и есть регистрация на сайте осма.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1255](http://teamcity.monogame.net/viewLog.html?buildId=14085&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:31:31


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1256](http://teamcity.monogame.net/viewLog.html?buildId=14089&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


На макетах в зеплине в РР как раз текст "Сегодня выходной". Больше я не знаю.


.. Rails are.. done. (Also this file actually is unneeded)


i revert this changes


#### suggestions

I recommend you use bower to install your front-end libraries. Only your native code should be published on GitHub


Seems there is a bug in dfmt. strings next to each other are merged without the need for ~


This doesn't work on all systems, unfortunately.   Having said that;

>dig -t NS +short +authority example.com

works for me on all the systems I've tried - does that work for you ?


Хорошо, согласен


ok, just wanted to make sure as this changes the "interface", meaning it's a new major revision of rdflib...


It is simpler to understand with `if c != '%':`.


Именно, но у дома может быть не номер.


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/9314/testReport/) for this commit**


@ZdrowyGosciu

U presently using temasek cm13?  If yes do a test and submit if it's working good. Thanks


Пока у нас нет этого поля насколько помню. Юра просил убрать его. Но перевод на будущее


So, having updated and added the necessary `Mutable` annotations, is it possible to not log a warning during validation? Maybe debug is sufficient since there's a good reason to actually use `@Mutable` because of what it signifies?


Стоит создавать через фабрику.


All the json files follows this pattern? bc-something-something.json? I feel that this is not robust and can easily fail when someone add an extra - in the name. Maybe add an extra check to make sure that this pattern is correct, and show an error message otherwise?


Дальше по коду повторение переданных параметров идёт, можно вынести в отдельную переменную-хеш и подставлять


FYI, `mod_time` allows us to import only those that changed after the previous import. Improved efficiency...

Thanks!


Это специальный кейз, когда целый день не работает заведение? И отдельно перевод, если сегодня работает, но в данный момент закрыто? Тогда ок.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26662/testReport/) for this commit**


fixed it! as usuall


do we need this again here?, i think this abvoe matches this almost too?


Ok, rewriting it.


* なにもPOSTで送られてきていないとき（初回アクセス時）はエラーを表示をせず、計算をしないようにしましょう。
* 計算をした後に、入力値が残っているように改善してみましょう。


Перевод все равно нужен правильный на будущее.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26663/testReport/) for this commit**


Как пользователь увяжет номер или имя дома с фразой Здание? Это не очень очевидно. Плюс мы в коде пока таки сохраняем это поле именно как номер дома.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26664/testReport/) for this commit**


/cc @bobsilverberg


1) I think this was dfix.
2) This is an anti-feature: `string[] arr = ["one", "two" "three", "four", "five" "six", "seven"];`


did you tested on 13.2, leap or tumbleweed?


I made this `2.1.5` as that's what comes packaged for Debian jessie


Angular `$resource` comes with its own methods to for all the HTTP verbs, However since you are using custom methods,
your identifiers in line 30, 33, 37, 41, 44 should look like this `create`, `all`, `find`, `update` and `delete` respectively to better suit your approach.


Boas,
tenho dúvidas em devices\settings linha 433 fala em Bluetooth será uma gralha?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26665/testReport/) for this commit**


not needed not unneeded...


Eleonore, can you write an explanation of the difference between normal and synthetic sensors, and also the period calculations PULSE, CULUMATIVE AND INSTANT please.


I used the cart-data from your test-script and set up the exact same order in magento, And got different results.
See the attached screens of the cart in magento, and the details in payex.

Note that both totals in payex match, and they also match what was shown in magentos cart.
However, I did notice another error with the tax percentage (24.99%). I'm guessing that it's because the tax of 989.17 is 197.834. the .004 difference is the issue.

![skarmbild fran 2016-01-28 09 58 24](https://cloud.githubusercontent.com/assets/11595785/12639941/905f7ad2-c5a7-11e5-9e1b-5e19c2048ac5.png)
![skarmbild fran 2016-01-28 10 04 32](https://cloud.githubusercontent.com/assets/11595785/12639940/90595738-c5a7-11e5-8e71-5a964831c2d2.png)
![skarmbild fran 2016-01-28 10 21 49](https://cloud.githubusercontent.com/assets/11595785/12640195/073d818e-c5a9-11e5-8f2a-07a87087ae59.png)


This last fix looks perfect. :+1:


this command is wrong. I've mentioned this already @
https://github.com/vivekdhayaal/cinder-HA/blob/master/how-tos/c-db-ha-how-to.txt


Can you write a brief explanation of rollups here please.


I agree, we should not hurry the fix, that usually leads to another bug... I'd be fine with not fixing it at all now and just create a trello card. One can review it and find the most appropriate solution (including unittest).


TeamCity pull requests :: netty [Build 1127](https://garage.netty.io/teamcity/viewLog.html?buildId=5140&buildTypeId=pulls_netty&guest=1) is now running


I guess default here is 0, 0, 0? Make it explicit?


BTW, `N_` is a bit unknown for many Yasters, would you mind commenting WHY we need it?


Sure, I don't mind, the important part is it does not have to be a `classmethod` and and it prepends sudo :smile:


配列の要素ひとつひとつに対して処理を行いたい(今はすべての要素をechoしたい)ときはforeachを使うと簡単でキレイです。
http://php.net/manual/ja/control-structures.foreach.php


I did it by hand because dfmt warned and I agreed.  Implicit string literal concatenation is unnecessary and harmful.


Bester Commit evoar
amenakoi


sure, I noticed it only because Eclipse underlined it...


Речь о переименовании тегов или о чём?


This is definitely not a satisfaying error message. If this fails in a stacktrace the message is absolutely useless.


Huehuehuehze


Can we please rename the variable here. This is deceptive, especially if we make an actual PID loop, that moves and stays at a specific angle.
Suggestions:
robotAnglePower
ClimberPower
ClimberAngleSpeed
rotationalPower
RotationalSpeed
movePower
SomethingActuallyCreative

or write it in one line.


I tried it, the skipIf skips even on exception, so you don't need to do any complex wrapper...


リポジトリ名の綴りが・・・


Для форм лучше использовать гем simple_form. Он имеет интеграцию с i18n, различные хелперы, отображение ошибок, чтобы не изобретать велосипед. И очень хорошо кастомиизируется


I'm not quite sure if it's suitable to expose render process ID here, as android is using a single process model; and render frame ID is also not suitable to expose I suppose, that's low level definitions.


remove pattern matching for:

(dimensionsValuesTime.copy(dimensionValues = dimensionsFiltered),
 +          InputFields(aggregationValues, UpdatedValues))


I would need to confirm it with CNR guys - it is always provided but `ObjectStore` API doesn't state explicitly whether I can fully rely on it.


А @task.save! зачем?


А гем aasm не предоставляет ничего подобного?


Да. Здесь, например, лучше просто назвать [details], если это просто показывается в плейс пейдже.


I don't remember exactly, I downloaded it many years ago, possibly from codeproject.com.


##### Code Quality Nitpick
Services and factories should be named without service prefix. They make using them in your controllers easier . Your service name should look this.
``` js
    .factory('Bucket', function($resource) {
       return {
          lists: $resource("/api/bucketlists/:id/", {id: "@id"}, {
            all: {
                method: 'GET'
            }
       }
    })
```

Then you can use it in your controller as.

``` js
   Bucket.lists.all();

```


It would be a problem if there were other uses of the variable which were not synchronized - but as this is the only use the synchronized block guarantees that other blocks synchronized on the same object will see its changes.

https://docs.oracle.com/javase/tutorial/essential/concurrency/syncmeth.html
> when a synchronized method exits, it automatically establishes a happens-before relationship with any subsequent invocation of a synchronized method for the same object. This guarantees that changes to the state of the object are visible to all threads.

Random would do - but it still uses AtomicLong - http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/util/Random.java#Random.next%28int%29


Message is pretty much useless... please make it meaningful so that in case of failure there won't be a required need to launch a debugger.


@keithkfng http://www.thesaurus.com/browse/unneeded


well ok then


Hey Marcos ;)

Do you plan to make any dolibarr core integration of your module ?


Please be more diligent next time, you missed space between `) {`. I'll fix the problem myself to speed things up.


We don't need this so as we must not hide our bags.


Префиксы - это хорошо, я за них. И это не текст из РР как я понимаю.


`with-eval-after-load` doesn't work with byte compilation (via cask) for me. As mentioned in this [blog post](http://www.lunaryorn.com/2013/06/25/introducing-with-eval-after-load.html) `with-eval-after-load` doesn't load required feature (in this case flycheck) during byte compilation, as a result `swift-mode` fails to load due to void variables. Wonder what will be the correct solution here @bbatsov @syohex ?


Could you use `xcb_randr_get_output_info_unchecked()` here? That way errors end up in the normal main loop and are printed to stderr. That could help debugging problems (if errors ever occur...).


matter of style but I would have a result initialized to null and assign to it and returning it in the end.
Only one return. That would also helps with the sonartech warning (but that's not a good reason)


опечатка?


А откуда тогда этот перевод?

Префиксы мешают переиспользовать готовые переводы. Например, у тебя будет раскидано по коду и по переводам editor_save, bookmarks_save, downloader_save ? Вместо этого просто и понятно использовать перевод [save]


ack


@martint I added a commit to handle backward compatibilty problem. Can you give it a try?


Если перевод есть - пускай он останется. Мы тратим сейчас время на это, а когда добавим диалог или ещё что, где этот перевод встречается - придётся снова его добавлять, тратить время по второму разу. Бесполезная работа.


Could you use `p_dup((char *)pointer, length)` here? That way embedded NULL bytes (shouldn't happen..) are handled and AFAIR allocation failures are handled, too.


lz4로압축을바꾸셨네요. 이압축이더좋은건가요?


So, both AtomiLong and synch make rabbit work as expected, now the problem shifted to babylon not processing the request somehow.

> On Jan 28, 2016, at 10:33 AM, Mike Bush <notifications@github.com> wrote:
>
> It would be a problem if there were other uses of the variable which were not synchronized - but as this is the only use the synchronized block guarantees that other blocks synchronized on the same object will see its changes.
>
> https://docs.oracle.com/javase/tutorial/essential/concurrency/syncmeth.html <https://docs.oracle.com/javase/tutorial/essential/concurrency/syncmeth.html>
> when a synchronized method exits, it automatically establishes a happens-before relationship with any subsequent invocation of a synchronized method for the same object. This guarantees that changes to the state of the object are visible to all threads.
>
> Random would do - but it still uses AtomicLong - http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/util/Random.java#Random.next%28int%29 <http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/util/Random.java#Random.next%28int%29>
> —
> Reply to this email directly or view it on GitHub <https://github.com/relayr/rabbitmq-scala-client/commit/f27cf43a51546695d0414c0698d31f0b4e26df65#commitcomment-15727728>.
>


Missed to correct it in README file. Corrected it.


I don't understand the method call `connector.getAllResourcesExcept(id())`. The idea is that if we do not find the resource with `name` in the local pool, we ask for the resource in remote pools. But in this case we should use the same pool id don't we ?

 What I understand is that a LocalResourcePool and all its corresponding distributed resource pools share the **same** pool id, is it correct ?

 Because the  `ResourceId` class suggests that a resource is uniquely identified by  the couple `(poolId, name)`. So the **same** resource located in 2 different pools (local and remote) should share the same `(poolId, name)`. Is it correct ?


Ah! Not me being careless then. Good!


Нууу как-то слабовато


Port 4040 is for Weave Scope, which is included in this demo.

The node port range was open cause I was using `NodePort` before, it's certainly not needed now, thanks for spotting that.


copy my settings from here: https://github.com/AKSW/RDFUnit/blob/master/pom.xml#L250-L259


What happened to the api folder? Had to roll back to 0.2.15


I haven't found that it is called anywhere, are we sure we need it?


Extract as constants those old values


Lascia come era prima, è stato messo cosi quando succede che si ha un tentativo :)


right


We need  a **null check** for `Object r` here otherwise `r.getClass()` will throw NPE


Cioè?

Inviato da iPad Pro

> Il giorno 28 gen 2016, alle ore 10:42, ale8530 <notifications@github.com> ha scritto:
>
> Lascia come era prima, è stato messo cosi quando succede che si ha un tentativo :)
>
> —
> Reply to this email directly or view it on GitHub.
>


Feng
Please add this : Merge "use core numbers as numqueues by default" to 3.18 patch

To 3.2 kernel


why we define hashCode like this? would you please elaborate?


calculatorの綴りが・・・
リポジトリ名も・・・


Sistemata quell'annotazione per me è ok :).

Fammi sapere appena hai sistemato.


@ppatierno What about adding simple interface+implementation of hello world service to demonstrate the actual binding?


Consider refactor the if block into

```java
if (isLocal() || isSerializable()) {
  return r;
} else {
   return null;
}
```


Sent two PR #408 and #409 to fix:
- #408 that some objects were never locked (the check of the rights was not with the correct right name)
- #409 added a query to set 'super-admin' UNLOCK rights to objects by default.


fix redis reconnect auth error


Actually we can remote that class. `io.rhiot.cloudplatform.runtime.spring.CloudPlatform` comes with main method, so you don't have to provide any bootstrap code.


bookkeeping is not a good name I suppose. and it is not followed the naming convention. I think we'd use session ID but not render frame host id as its key.


Leftover?


В NodeJS не принято так делать. Нужно стараться выносить функции в модули. Как это сделать узнаем сегодня


Nevermind.


From my perspective if we...

a) remove obsolete `RhiotCloudPlatform` class
b) add some helloworld service binding example

...then the quickstart will be perfect.


When you are ready to do a release please tag it via github.


I use it sometimes, example: `{"asdf":"efasedf"}` "\n"

On Thu, Jan 28, 2016 at 11:29 AM, Daniel Murphy <notifications@github.com>
wrote:

> I did it by hand because dfmt warned and I agreed. Implicit string literal
> concatenation is unnecessary and harmful.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/D-Programming-Language/dmd/commit/9ee26c7611d378044893a50926795e08983a14fa#commitcomment-15727657>
> .
>


část-aplikace je valstně vždycky soubor kde jsou převážné úpravy.
Typicky třeba něco dělám v guidpost a ještě upravím styly --> tak přestože tam jsou vlastně dvě části, volil bych něco jako `guideposts: add popup + styles #xx`.

Pokud by měl commit zasahovat fakt znatelně do více částí, je možná vhodné ho rozdělit na dva menší commity samostatně funkčních jednotek. Říká se tomu granulární commitování, zas to usnadňuje přehlednost a zejméne code-review


Scusa eh, ma se "<string name="pin_attempts">"
Hai ancora %d **tentativi** a disposizione."</string>" è così, perché  <string name="pin2_attempts">"
Sono rimasti %d tentativi."</string> deve essere "tentativo(i)"?


<form>タグ内の属性と値の間に半角スペースを入れるか入れないかを統一した方がキレイです。


не догнал :"Карточка товара: кнопка «Купить» — по клику товар добавляется в корзину (макета корзины нет, не делать). так что нужно это учесть )" - мне то что делать?


You're likely going to need some excludes for `/spec` and `/vendor`.. but we can get to that later.


good point. actually I am not sure here, can i name a proposal with a "-" in the name in cloud5 ? unfortunately i dont have a working cloud5 to test that


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13164](https://teamcity.mesosphere.io/viewLog.html?buildId=115407&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:03:42


I think that these commented out code should just be removed. Cleaner code. But its okay, just a minor thing


'#;k,mjibuyh


TeamCity Civic Assembly :: Build backend + frontend [Build 32](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=525&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1256](http://teamcity.monogame.net/viewLog.html?buildId=14089&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:32:56


Это перевод из редактора.
Используется как название секции полей.


No problem. I'll fix it tomorrow.


давай заменим & на `&`


Any reason you prefer this style over what you previously had? I kinda like the original syntax better.


Давайте выпилим переводы Индекс, Наташа закажет поправленные


rake db:setup is bundle that runs does db:create, db:schema:load, db:seed


the best method to tell girls how delete and clean their computer


TitleTip描述信息显示


I was wondering why my script inserted `ignore`s? ;)


to be consistent it should be:

```python
resp_headers = resp.headers
if  hasattr(resp_headers, "items"):
    resp_headers = resp_headers.items()
```

> side note: to explain a little this style: the "items" case is a particular case we should not expect, this is then not an if/else case but really a just in case "if" :)


In this case I suggest to check for this situation and shows an error message when the pattern is not correct, so during the cloud5 - cloud6 migration we can be alerted and point here.


https://msdn.microsoft.com/en-us/library/system.threading.tasks.task.completedtask(v=vs.110).aspx

.NET Framework
Available since 4.6

I don't think we can use this.


Forgot an s here.


add the exception object when logging the error


Lasciala uguale com'era prima :), la prima frase è troppo lunga e non entra poi.


What errors did you get ? I got no errors at loading byte-compiled file.


really ?


nice @ahgittin, thanks!


Really sorry for delay. Can you fix your tab width and commit again?


XWalkPresentationAPI is not a good name I suppose, it represents the host window which initiate the presentation process. Maybe XWalkPresentationHost?


로그인 인증 푸시 추가
call 클래스 추가
gcm 연동
prq에 토큰 아이디 생성
상점 클래스 수정


ты про что? Перефразируй непонятно


Ma così non c'è coerenza.
Comunque, fatto.

Inviato da iPad Pro

> Il giorno 28 gen 2016, alle ore 10:52, ale8530 <notifications@github.com> ha scritto:
>
> Lasciala uguale com'era prima :), la prima frase è troppo lunga e non entra poi.
>
> —
> Reply to this email directly or view it on GitHub.
>


OK


ты прав я делаю все дивами


@bradymiller I think there is a typo "It appears there are 3 separate Smarty libraries within phpgacl" within phpgacl should be within openemr isn't it?


@leudanielm You should have different commit for service impl outside the gulp migration scope


E' coerente perchè se tu sbaglio lui ti dice Hai a disposizione 3 tentativi , poi se continui a sbagliare ti dirà 1 tentativo, quindi il plurale prevale sul singolare :)


LoadProject for Project_v2 has other signature than Project_v3 and Project_v4. Is this code correct?


Ага, встречная проблема - а как различать переводы, которые различаются чуть-чуть? save_2?


do not call it `section-1.swift` ..
rename it please.


Why is the default priority 5 in `buildEnv`? Documentation for `nix-env -i` claims the default priority to be 0.


Чуть-чуть должно быть отражено в теге - [save_chut]


Please no cuddled `else`! I'm sorry if I had mistakenly used one.


@flavour What I am trying to do here is if there are other Lx than L0 (i.e. more specific polygon), I am taking them as locations. Does this logic not make sense?


`runAlgorithm` is a generic name. Any function could be called so. Better than "computeFinal", still needs improvement.


Fix merged to master.


Nit: `#clear_ppx` sounds much better.


No, but 'ccc' is just one of the "other recent versions" supported.


**Code Quality: Nitpick**

You need to put in comments on this class.


@leudanielm @Injectable() is only a Future proofing for now.
https://angular.io/docs/ts/latest/guide/dependency-injection.html -> Why @Injectable?


[![I Raro Te Oviri (Under the Pandanus)](http://api.artsmia.org/images/601/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=601)


[![View of Tangier from the Seashore](http://api.artsmia.org/images/799/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=799)


[![Olive Trees](http://api.artsmia.org/images/1218/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1218)


[![Snow, Boulevard de Clichy, Paris](http://api.artsmia.org/images/1414/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1414)


[![Study for Improvisation V](http://api.artsmia.org/images/1639/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1639)


[![Convulsionists of Tangier](http://api.artsmia.org/images/1978/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1978)


[![View of Tangier](http://api.artsmia.org/images/4578/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=4578)


[![Fields of Flowers in Bloom, near Caen](http://api.artsmia.org/images/115814/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=115814)


[!["Red-Blue" chair](http://api.artsmia.org/images/40451/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=40451)


[!["Berlin" chair](http://api.artsmia.org/images/40452/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=40452)


[!["Hogestoel" highback chair](http://api.artsmia.org/images/40454/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=40454)


[![End table](http://api.artsmia.org/images/40455/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=40455)


[![Child's chair](http://api.artsmia.org/images/40456/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=40456)


[!["Skyscraper" chair](http://api.artsmia.org/images/8374/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=8374)


[![Portrait of Catharina Van Keuren](http://api.artsmia.org/images/98953/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=98953)


[![Portrait of Richard John Cock](http://api.artsmia.org/images/106096/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=106096)


[![Captain Christopher Andrews](http://api.artsmia.org/images/120177/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120177)


[![Mrs. Ruth Andrews nÃ©e Polly](http://api.artsmia.org/images/120178/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120178)


[![Two Andrews Children](http://api.artsmia.org/images/120179/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120179)


[![Two Andrews Children](http://api.artsmia.org/images/120180/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120180)


[![Table from a nest of tables](http://api.artsmia.org/images/40457/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=40457)


[![I Raro Te Oviri (Under the Pandanus)](http://api.artsmia.org/images/601/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=601)


[![View of Tangier from the Seashore](http://api.artsmia.org/images/799/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=799)


[![Olive Trees](http://api.artsmia.org/images/1218/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1218)


[![Snow, Boulevard de Clichy, Paris](http://api.artsmia.org/images/1414/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1414)


[![Study for Improvisation V](http://api.artsmia.org/images/1639/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1639)


[![Convulsionists of Tangier](http://api.artsmia.org/images/1978/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1978)


[![View of Tangier](http://api.artsmia.org/images/4578/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=4578)


[!["Red-Blue" chair](http://api.artsmia.org/images/40451/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=40451)


[!["Berlin" chair](http://api.artsmia.org/images/40452/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=40452)


[![End table](http://api.artsmia.org/images/40455/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=40455)


[!["Hogestoel" highback chair](http://api.artsmia.org/images/40454/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=40454)


[![Child's chair](http://api.artsmia.org/images/40456/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=40456)


[![Portrait of Catharina Van Keuren](http://api.artsmia.org/images/98953/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=98953)


[![Portrait of Richard John Cock](http://api.artsmia.org/images/106096/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=106096)


[![Fields of Flowers in Bloom, near Caen](http://api.artsmia.org/images/115814/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=115814)


[![Captain Christopher Andrews](http://api.artsmia.org/images/120177/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120177)


[![Mrs. Ruth Andrews nÃ©e Polly](http://api.artsmia.org/images/120178/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120178)


[![Two Andrews Children](http://api.artsmia.org/images/120179/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120179)


[![Two Andrews Children](http://api.artsmia.org/images/120180/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120180)


Então porque alteraste my friend?
https://github.com/ingbrzy/MA-XML-7.0-PORTUGUESE/commit/e98f86f44a9dd7d1fc05f1586cf2ce01949ad472
Já resolvo...


Good questions, @springmeyer! I'm not entirely sure about the first, but the second, I think, is answered for us in the upcoming `node-mapnik`:

> Or, alternatively is it really important to this module to reject layers with no features?

As far as I can tell, this case will have already been thrown within `setData` itself, no matter if we wanted to keep the tile or not: modulehttps://github.com/mapbox/mapnik-vector-tile/blob/v2_spec/src/vector_tile_is_valid.hpp#L52


:sheep:


@mdelapenya something here does not smell right. This code is setting the portletInstanceKey (which is what _portlet.getPortletId() returns) into a method that is called setPortletName()


I'm not sure if this is correct. The p_p_id param contains a portletInstanceKey but the first parameter of assemblePortletId() is expecting a portletName


And....
Done...
:)


Tenho tudo engatado estou no mesmo sitio ia alterar apenas estava em consulta de dados para confirmar que tu e outra coisa universalmente número de serie tem dois pontos

Número de serie:
S/N:

A outra string em minuscula número de serie é

S/N


Completed task assigned to @AllNamesAlreadyTaken with extra time.


This path doesn't match the repo. `go get` fails.


time machine over here :)


How did you determine that it's really the portletName. It seems to be set as the portletInstanceKey in some cases (see comments in other commits)


doh, looks like I missed two characters.  I'll submit another fix and close this PR. =/


It's not totally fixed. The added portion doesn't show up yet.


>You'll notice a missing node in the picture above, bottom left corner. I guess the first node? That one has coordinates 162, 742.

Missing, or not connected? Is there actually a point not being rendered? Not all are connected, since the connections are random...
The warnings are indeed simply not taken care of yet since they're harmless...
Glad it works for you :)


I've stepped through the dispatcher in ntdll.dll (or one of the other system DLLs): there is a validation call that walks the exception chain, and one of the checks is that the end of the 8 bytes of each registration entry must be below the stack top, not identical.

> is it the extra offset by EXCEPTION_REGISTRATION.sizeof below that avoids triggering the issue?

Yes, the filler moves the top registration entry down by 4 byte. Maybe it's better to just change the offset below, but it's necessary to change it in multiple places there.


I know what it is and i know what i do ;)
The problem is that before this commit, everytime i got in a zone my game freezed for few seconds and all the players had some lag.
I decided to delay the patrol and traffic spawn because it doesn't really matter when they're spawned, their position is pretty far from the player, so it really doesn't affect anything


Nope...
https://www.asus.com/pt/support/article/566/
E no sítio onde isso está não faz sentido estar tudo sem : e aparecer um tresmalhado com :


OK so do current Odoo v9.0 installs use the OCA v8.0 modules (i've seen [youtube demos](https://www.youtube.com/watch?v=4NCifyzx3CU) specifying Odoo 9 + Magento connector)? Or do they use OCA v9.0 (versions from before this commit).