Why the malloc/memcpy/free? You can always use a std::string (or std::vector) as buffer or in this case even a QString.
(Is msg_content guaranteed to not contain any \0 bytes, i.e. does QString result(string); even work?)

zmq_msg_t msg;
const int rc = zmq_msg_init(&msg);
assert(rc == 0);
const int bytes = zmq_msg_recv(&msg, socket, 0);
auto string = QString::fromLocal8Bit(static_cast\<char*\>(zmq_msg_data(&msg)), bytes);
zmq_msg_close(&msg);
return string;

I'd also suggest to wrap zmq_msg_t in a RAII class to encapsulate the return code checks & closing.


**Code Quality: Nitpick**

You need to get rid of these bits of commented out code.


`pacan -S mingw-w64-x86_64-protobuf`
`pacman -S mingw-w64-x86_64-protobuf-c`
solves that error..
but after that i get stuck like i mentioned <a href="https://gitter.im/sashahilton00/spotify-connect-resources?at=5696db192bc35f6c1c19f231">here</href>


Unfortunately that word misses an 'r'. :)


Should be:

```javascript
hasCheckedAttribute = toEl.getAttribute('checked') != null;
```

The value of the `checked` attribute will be an empty string.


I had to add another flag because it starts outside of an activity


Similar to comment above. Use `!= null`


Might want to update the wiki to show we're just selecting the $a from 130 now. https://github.com/gwu-libraries/launchpad/wiki/MARC-Extraction


Ahh yes. Duh.

Thanks


Check out [this](https://github.com/JunoLab/atom-julia-client/commit/5069a6152aac3ae017a09e4225225efd27d67f15) and [this](https://github.com/JunoLab/Atom.jl/commit/074da20bc0a4157301944d7270ef03365ee18cc5). That patch means that Blink can reuse Atom's api to show windows rather than downloading another copy of electron. We basically need this to be non-default so that we can bundle Blink with Juno and not use up an extra 250mb :)


this is my first project in github。
加油.....


@Maijin can't we check for something else, then the filename? Im not into Windows buisness, but :)


Dat is beter @ramona-advalley :+1:


Ah right. Forgot about that.


You either keep the old static method but improve its name and add some parameter to specify the page to go to or you *override* (see Java) the existing ``rename()`` method inherited from BasePage in order to make it return a RenamePage.


`s/(reference #14)/(addresses #14)/`


Never publish your private keys.


Hahaha, ik leer het wel ;)

Van: henricus louwhoff [mailto:notifications@github.com]
Verzonden: vrijdag 15 januari 2016 16:27
Aan: advalley/lhck <lhck@noreply.github.com>
CC: Ramona Edeling <ramona@advalley.io>
Onderwerp: Re: [lhck] Nogmaals update arrangement Lindner (79787b0)

Dat is beter @ramona-advalley<https://github.com/ramona-advalley> [:+1:]

—
Reply to this email directly or view it on GitHub<https://github.com/advalley/lhck/commit/79787b06d5f751c9b860627bf737239de299adbc#commitcomment-15476944>.


pls fix the table name


@sideshowbarker The whole point of this change was to ensure that Java 8 gets used no matter what the user's workspace default JRE is set to. Luckily these days it's quite unlikely that it's anything else than Java 8, but things change. I had thought that ```JavaSE-1.8``` was available everywhere, but in case it's not (I hadn't run into problems with it anywhere before), please by all means ignore that part of the change.


Typically fields that are references should not be named with `ID`.


When you say `current_user.list` that looks for a list method on your User instance. Above you use `current_users.lists`, why the difference?


from Open Calais API: Every entity markup tag has one or more related instances.
I guess we are on the safe side with this


maybe: `sudo gem install bundle --no-rdoc --no-ri`


That sentence is hard to read. Can we split it up or something?


To me this is a question of : " What are the channels on which I need to send this out ? ". If I create an Alert object and ask this question, it seems to make sense to me.

But if I define an AlertSearch and ask this question, it does not make sense to me.

AlertSearch : Alert = 1 : 1 or 1:N ?


@dkayiwa  yes! If "View Visits" does not exists in privilege table but "View Encounters" exists in role_privilege table ( this implies that "View Encounters" exists in privilege table) then this chageset adds "View Visits" to role_privilege table and privilege table.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/25617/testReport/) for this commit**


@cummingsm can you provide an example to test?


Other than modifying the table name :+1:


of course. good catch.


The deployment is actually quite a bit faster if Ansible installs rebar beforehand. I am not sure why.


Jakie widzisz tego zastosowanie?


**Code Quality: Nitpick**

The pagination functionality created here might benefit from being created as a method within the model or as a private function within the view. You would then call this function along with the QuerySet and some parameters to get a trimmed down version of the resultset (this may or might not be in the response format). This way your code is less cluttered and much cleaner.


Maybe you are right. Let's revert the containsRefinedThis patch.


:bulb: this can be added as a `cronjob` to be executed from 20 to 20 minutes
Works like a charm on my `localhost`, and my current `Uptime: 1 day, 06:53:10`


Also, I changed some of the default values for the totals table - I forgot I'd done that.


Takie coś można zastąpić przez:
```php
extract($hook_data);
```


plz dont rename pocketmine.yml. Some of my plugins use "pocketmine.yml" in order to run


IIRC game == null does happen when lua is killed


แก้ทำแมวไร


Bro,

Upload 2 picture with credits

Sorry for muy english

Sent using CloudMagic Email
[https://cloudmagic.com/k/d/mailapp?ct=pa&cv=8.0.91&pv=6.0.1&source=email_footer_2] On jue., ene. 14, 2016 at 11:31 p. m., nikhil18 < notifications@github.com [notifications@github.com] > wrote:
Bro can you please give me better credits than all other kernel devs because you
have just taken 100% of my source I have done a lot of hard work putting those
3.10 and Linux patches commit like i have given to ak in my kernel thread thanks

—
Reply to this email directly or view it on GitHub
[https://github.com/Next-OS/android_kernel_oneplus_bacon/commit/66e746f7418aaf0eee719d89176a4e1bf224482a#commitcomment-15462706] .[https://github.com/notifications/beacon/AFNGpWrQdKNwSCVltZIPPDypxgPXlt4bks5paBksgaJpZM4HFTZF.gif]


Are you using the latest rust nightly?
It threw dozens of errors when I tried to compile it with a one week old rust. Those errors disappeared after the update.
Is pacman a part of cygwin, or also the mingw compilers?


nice man


uhu


อ้าวนี้ มัน diff ตรูนิหว่า


Yeah, keep UseSetting because it chains nicely.


Well the second is IMO proper way. Actually we should create fresh `avocado.app.json.uid` logger for each json logger and the ones with output to `-`  (stdout) should use `ConsoleHandler`, the rest should use `FileHandler`. In case `-` is created then it should actually imply `--log none` + `avocado.app.json` enabled to stdout. The rest could work the same way and all human plugins could use `avocado.app` logger, which would be `NullHandler` when some plugin replaces the `-`...


อันนี้ก็คุ้นๆนะ -*-


from java spec "Nested enum types are implicitly static."


This is the result of running the following command to get started:
`ember new animevox-client-web --skip-npm --skip-bower --skip-git`


from java spec "Nested enum types are implicitly static."

Also everything inside an interface is implicitly public


We should probably ask @apr-odoo what would be best in terms of usability? Disabling the Save button until the reload of the *implicit* save is finished might be the less annoying option. At least it's the closest to the existing behavior without the risk of double save.

I've just re-tested this behavior in 7.0 and 8.0 and it has always been the same: you could click on any action button, and while waiting, realize you did not save, and quickly click Save in parallel. If you do this after adding a o2m line in the form, you end up with 2 lines added, same in 8.0 and 7.0.


No, just by accident. Sorry.


* ปิดระบบภาษีตั้งร้าน


@maratkomarov  Объяснил ситуацию в пул-реквесте: https://github.com/coleifer/peewee/pull/822


'use strict';

//list of cars
//useful for ALL exercises
var cars = [{
  'id': 'p306',
  'vehicule': 'peugeot 306',
  'pricePerDay': 20,
  'pricePerKm': 0.10
}, {
  'id': 'rr-sport',
  'pricePerDay': 60,
  'pricePerKm': 0.30
}, {
  'id': 'p-boxster',
  'pricePerDay': 100,
  'pricePerKm': 0.45
}];

//list of rentals
//useful for ALL exercises
//The `price` is updated from exercice 1
//The `commission` is updated from exercice 3
//The `options` is useful from exercice 4
var rentals = [{
  'id': '1-pb-92',
  'driver': {
    'firstName': 'Paul',
    'lastName': 'Bismuth'
  },
  'carId': 'p306',
  'pickupDate': '2016-01-02',
  'returnDate': '2016-01-02',
  'distance': 100,
  'options': {
    'deductibleReduction': false
  },
  'price': 0,
  'commission': {
    'insurance': 0,
    'assistance': 0,
    'drivy': 0
  }
}, {
  'id': '2-rs-92',
  'driver': {
    'firstName': 'Rebecca',
    'lastName': 'Solanas'
  },
  'carId': 'rr-sport',
  'pickupDate': '2016-01-05',
  'returnDate': '2016-01-09',
  'distance': 300,
  'options': {
    'deductibleReduction': true
  },
  'price': 0,
  'commission': {
    'insurance': 0,
    'assistance': 0,
    'drivy': 0
  }
}, {
  'id': '3-sa-92',
  'driver': {
    'firstName': ' Sami',
    'lastName': 'Ameziane'
  },
  'carId': 'p-boxster',
  'pickupDate': '2015-12-01',
  'returnDate': '2015-12-15',
  'distance': 1000,
  'options': {
    'deductibleReduction': true
  },
  'price': 0,
  'commission': {
    'insurance': 0,
    'assistance': 0,
    'drivy': 0
  }
}];

//list of actors for payment
//useful from exercise 5
var actors = [{
  'rentalId': '1-pb-92',
  'payment': [{
    'who': 'driver',
    'type': 'debit',
    'amount': 0
  }, {
    'who': 'owner',
    'type': 'credit',
    'amount': 0
  }, {
    'who': 'insurance',
    'type': 'credit',
    'amount': 0
  }, {
    'who': 'assistance',
    'type': 'credit',
    'amount': 0
  }, {
    'who': 'drivy',
    'type': 'credit',
    'amount': 0
  }]
}, {
  'rentalId': '2-rs-92',
  'payment': [{
    'who': 'driver',
    'type': 'debit',
    'amount': 0
  }, {
    'who': 'owner',
    'type': 'credit',
    'amount': 0
  }, {
    'who': 'insurance',
    'type': 'credit',
    'amount': 0
  }, {
    'who': 'assistance',
    'type': 'credit',
    'amount': 0
  }, {
    'who': 'drivy',
    'type': 'credit',
    'amount': 0
  }]
}, {
  'rentalId': '3-sa-92',
  'payment': [{
    'who': 'driver',
    'type': 'debit',
    'amount': 0
  }, {
    'who': 'owner',
    'type': 'credit',
    'amount': 0
  }, {
    'who': 'insurance',
    'type': 'credit',
    'amount': 0
  }, {
    'who': 'assistance',
    'type': 'credit',
    'amount': 0
  }, {
    'who': 'drivy',
    'type': 'credit',
    'amount': 0
  }]
}];

//list of rental modifcation
//useful for exercise 6
var rentalModifications = [{
  'rentalId': '1-pb-92',
  'returnDate': '2016-01-04',
  'distance': 150
}, {
  'rentalId': '3-sa-92',
  'pickupDate': '2015-12-05'
}];

function exo_1()
{
	console.log("Exercise 1 : Generate the price for each driver");
	var time = 0;
	var distance = 0;
	var i = 0;
	var j = 0;
	var firstDay = new Date();
	var lastDay = new Date();
	var numDays = 0;
	for (i = 0; i < rentals.length; i++)
	{
		firstDay = new Date(rentals[i].pickupDate);
		lastDay = new Date(rentals[i].returnDate);
		numDays = (lastDay - firstDay) / 86400000 + 1;

		for (j = 0; j < cars.length; j++)
		{
			if (rentals[i].carId == cars[j].id)
			{
				time = numDays * cars[j].pricePerDay;
				distance = rentals[i].distance * cars[j].pricePerKm;
			}
		}
		rentals[i].price = time + distance;
	}
}

function exo_2()
{
	console.log("Exercise 2 : Decreasing pricing for longer rentals");
	var time = 0;
	var distance = 0;
	var i = 0;
	var j = 0;
	var firstDay = new Date();
	var lastDay = new Date();
	var numDays = 0;
	for (i = 0; i < rentals.length; i++)
	{
		firstDay = new Date(rentals[i].pickupDate);
		lastDay = new Date(rentals[i].returnDate);
		numDays = (lastDay - firstDay) / 86400000 + 1;

		for (j = 0; j < cars.length; j++)
		{
			if (rentals[i].carId == cars[j].id)
			{
				if (numDays >= 1 && numDays < 4)
				{
					cars[j].pricePerDay *= 0.9;
				}
				else if (numDays >= 4 && numDays < 10)
				{
					cars[j].pricePerDay *= 0.7;
				}
				else if (numDays >= 10)
				{
					cars[j].pricePerDay *= 0.5;
				}
				time = numDays * cars[j].pricePerDay;
				distance = rentals[i].distance * cars[j].pricePerKm;
			}
		}
		rentals[i].price = time + distance;
	}
}

function exo_3()
{
	console.log("Exercise 3 : Commission");
	var time = 0;
	var distance = 0;
	var i = 0;
	var j = 0;
	var firstDay = new Date();
	var lastDay = new Date();
	var numDays = 0;
	var commission = 0;
	for (i = 0; i < rentals.length; i++)
	{
		firstDay = new Date(rentals[i].pickupDate);
		lastDay = new Date(rentals[i].returnDate);
		numDays = (lastDay - firstDay) / 86400000 + 1;

		for (j = 0; j < cars.length; j++)
		{
			if (rentals[i].carId == cars[j].id)
			{
				if (numDays >= 1 && numDays < 4)
				{
					cars[j].pricePerDay *= 0.9;
				}
				else if (numDays >= 4 && numDays < 10)
				{
					cars[j].pricePerDay *= 0.7;
				}
				else if (numDays >= 10)
				{
					cars[j].pricePerDay *= 0.5;
				}
				time = numDays * cars[j].pricePerDay;
				distance = rentals[i].distance * cars[j].pricePerKm;
			}
		}
		rentals[i].price = time + distance;

		commission = 0.3 * rentals[i].price;
		rentals[i].commission.insurance = commission / 2;
		rentals[i].commission.assistance = numDays;
		rentals[i].commission.drivy = commission - (rentals[i].commission.insurance + rentals[i].commission.assistance);
	}
}

function exo_4()
{
	console.log("Exercise 4 : The deductible");
	var time = 0;
	var distance = 0;
	var i = 0;
	var j = 0;
	var firstDay = new Date();
	var lastDay = new Date();
	var numDays = 0;
	var commission = 0;
	var deductible = 0;
	for (i = 0; i < rentals.length; i++)
	{
		firstDay = new Date(rentals[i].pickupDate);
		lastDay = new Date(rentals[i].returnDate);
		numDays = (lastDay - firstDay) / 86400000 + 1;

		for (j = 0; j < cars.length; j++)
		{
			if (rentals[i].carId == cars[j].id)
			{
				if (numDays >= 1 && numDays < 4)
				{
					cars[j].pricePerDay *= 0.9;
				}
				else if (numDays >= 4 && numDays < 10)
				{
					cars[j].pricePerDay *= 0.7;
				}
				else if (numDays >= 10)
				{
					cars[j].pricePerDay *= 0.5;
				}
				time = numDays * cars[j].pricePerDay;
				distance = rentals[i].distance * cars[j].pricePerKm;
			}
		}
		rentals[i].price = time + distance;

		commission = 0.3 * rentals[i].price;
		rentals[i].commission.insurance = commission / 2;
		rentals[i].commission.assistance = numDays;
		rentals[i].commission.drivy = commission - (rentals[i].commission.insurance + rentals[i].commission.assistance);

		if (rentals[i].options.deductibleReduction == false)
		{
			//deductible = 800;
		}
		else
		{
			//deductible = 150 + numDays * 4;
			deductible = numDays * 4;
		}
		rentals[i].price += deductible;
	}
}

function exo_5()
{
	console.log("Exercise 5 : Pay the actors");
	var time = 0;
	var distance = 0;
	var i = 0;
	var j = 0;
	var k = 0;
	var l = 0;
	var firstDay = new Date();
	var lastDay = new Date();
	var numDays = 0;
	var commission = 0;
	var deductible = 0;
	for (i = 0; i < rentals.length; i++)
	{
		firstDay = new Date(rentals[i].pickupDate);
		lastDay = new Date(rentals[i].returnDate);
		numDays = (lastDay - firstDay) / 86400000 + 1;

		for (j = 0; j < cars.length; j++)
		{
			if (rentals[i].carId == cars[j].id)
			{
				if (numDays >= 1 && numDays < 4)
				{
					cars[j].pricePerDay *= 0.9;
				}
				else if (numDays >= 4 && numDays < 10)
				{
					cars[j].pricePerDay *= 0.7;
				}
				else if (numDays >= 10)
				{
					cars[j].pricePerDay *= 0.5;
				}
				time = numDays * cars[j].pricePerDay;
				distance = rentals[i].distance * cars[j].pricePerKm;
			}
		}
		rentals[i].price = time + distance;

		commission = 0.3 * rentals[i].price;
		rentals[i].commission.insurance = commission / 2;
		rentals[i].commission.assistance = numDays;
		rentals[i].commission.drivy = commission - (rentals[i].commission.insurance + rentals[i].commission.assistance);

		if (rentals[i].options.deductibleReduction == false)
		{
			//deductible = 800;
		}
		else
		{
			//deductible = 150 + numDays * 4;
			deductible = numDays * 4;
		}
		rentals[i].price += deductible;

		for (k = 0; k < actors.length; k++)
		{
			for (l = 0; l < rentals.length; l++)
			{
				if (actors[k].rentalId == rentals[l].id)
				{
					actors[k].payment[0].amount = rentals[l].price;
					actors[k].payment[2].amount = rentals[l].commission.insurance;
					actors[k].payment[3].amount = rentals[l].commission.assistance;
					if (rentals[l].options.deductibleReduction == true)
					{
						actors[k].payment[4].amount = rentals[l].commission.drivy + numDays * 4;
						actors[k].payment[1].amount = rentals[l].price * 0.7 - numDays * 4;
					}
					else
					{
						actors[k].payment[4].amount = rentals[l].commission.drivy;
						actors[k].payment[1].amount = rentals[l].price * 0.7;
					}
				}
			}
		}
	}
}

exo_5();

console.log(cars);
console.log(rentals);
console.log(actors);
console.log(rentalModifications);


(Still don't know why my previous comment used such a wide font).

Finally read AddElement.  :(
I don't remember either the actual issue, but I do remember writing that code as a series of if rather than a very big one. I would say that is most likely the code that fails as the 7 group type ends up a child of the child of the QUST rather than a child of the DIAL.


I also diff before update. I nevertheless missed this one.


Probably should be `required`.


This url has a leading '/' while the others in this factory do not. Does this route work?


Neither did I. And our evaluation does *not* check for added differently-named `meta` attributes, I believe.


Just as a matter of course, I would always, *always* check to see if something is `nil` or `0` before dividing by it... like so:
```
   UIImage *image = self.images[indexPath.row];
   if ( image && image.size.height > 0 )
   {
      return (CGRectGetWidth(self.view.frame) / image.size.height) * image.size.height;
   }
```


i was using rust 2016-01-11
pacman is part of mingw..
i managed to build on linux yesterday with rust 2016-01-13, didnt tried on windows yet


<p> tag isn't closed


Got it I think! The label of the current group is not 'DIAL' as this code expects.


@remotevase They just created a new imagicalmine.yml


We should consider implementing some way of testing these code snippets in the release notes similarly to how we do in the user guide.


Rust is just a bunch of breaking changes all duct taped together :)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/25620/testReport/) for this commit**


That's strange, but this operation has no effect on overall build process.


`string +=` on this one?


Not sure why you add these sed lines, python2 is default, so /usr/bin/python is python2
Unless this is just a blind copy/paste.......


@jimhester this test fails because the `package.rds` file gets written once on install, and `packageDescription` uses `readRDS`, not `read.dcf`.


TeamCity Civic Assembly :: Build all [Build 11](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=342&buildTypeId=CivicAssembly_BuildAll&guest=1) is now running


I like to change it


why?


Why do these need to have threading? 0.o


hello, Is it really your first project?


TeamCity Civic Assembly :: Build all [Build 11](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=342&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new); exit code 1 (new); exit code 123 (new) Build time: 00:01:08


`return exists('b:sy') && b:sy.active`


It looks like this block of specs has been removed without replacement.


Or is it just a bunch of duct tape with some breaking changes?


Not sure why this comment has been removed, as there's no diff to `ApplicationController.test_code_redirect_by_email_token`.


Are you fetching the category twice?


I spoke too quickly, I think South Africa is experiencing some slow speeds when talking to Github. I've tried again to build rebar (as a dedicated Ansible step) and it is dog slow.


That change creates a problem when the session storage is a symbolic link (ie. for a shared session handling on multiple servers). As it throw the exception in any cases there...


Cool


`response.length` should be `dialog_response.length`


This is quite a difficult commit to review, because it includes a big copy-paste-style move, _and_ modifications to the pasted code. I recommend changing the _minimum_ to get the specs to pass when doing this, and then making a new commit to improve the moved code.


is checking the import, not the filename


lol at the in-joke, but maybe its a bit obscure for contributors looking at our specs?


I tried really hard to separate this cleanup into an `@After`, but the problem is that the test actually runs asynchronously to the `@Test` test method and so cleanup tends to race with creation of the organisation. If anyone can solve this, great, but I'm out of ideas at the moment.


맞게 나와야 할 것 같은데 컴파일해보면 s의 지수가 -2가 아닌 -1이 나와버려요...


Instead of defining `PTERO_PETRI_HOST` and `PTERO_PETRI_PORT`, and then embedding logic in ptero-workflow to assemble these into the petri submission url, I think it would be an improvement to instead define a `PTERO_PETRI_SUBMISSION_URL`.  Ptero-workflow would still need to have logic to append the net-key on the end of the submission url, but it wold be similar to what we [do](https://github.com/genome/ptero-workflow/blob/7d39f3a694ef76da2a1b4485ffe18aca3bb500d1/ptero_workflow/implementation/models/methods/job.py#L178) for for submitting a job to a job service.


But yes, the test is far from being enough I definitely agree


I guess the key to understanding what I've done here is that when the user space thermal-engine starts, it disables polling by the kernel driver.  Normally, the check_temp work stops and everything is handled by user space.  With this modification, check_temp work continues, but only handles hotplugging.  User space thermal-engine handles everything else.


It's unfortunately unclear to me what `iron-node` is doing specifically to help with debugging ES6. Node/V8 provides the runtime on the Node side with ES6 features and DevTools debugging will support whatever the native version does. Is there something I'm missing?


Нет проблемы с кодировкой


@datapimp great timing to comment on this! Last night I landed one last commit to enable this on open-source. There're still a few high level things that need to be done and a few KPs but it's mostly working.

I'd love to get your feedback and help to get this to the finish line! Here're are some steps to give it a try:

1. `$ react-native init test; cd test`
2. Edit `RCTDevMenu.m` and return `YES` on the method `hotLoadingAvailable`.
3. Open Xcode and run the app, the option to enable/disable Hot Loading should be on the dev menu.
4. Have fun

I'll create issues for the high level tasks and KPs and cc you guys. Thanks a lot, and let's make React Native even more awesome!


* snap dodge (กระโดดหลบอาชู)


Hehe ;)


* trap ไม่ล่องหน


* trap หยุดทันที


Do not need .exec() to return a promis


감동하고 갑니다... 정말로 자세하네요


`UseSetting` is the most common use scenario. I doubt there are many use cases for using the raw `Settings`. Our usage case here is pretty irregular.


You could use <a href='http://api.rubyonrails.org/classes/ActionView/Helpers/FormTagHelper.html#method-i-radio_button_tag'>`radio_button_tag`</a> for this.


@fastest963 don't know where this should be added (in which test case), but this peace of course shows the error:

```go
package main

import (
	"fmt"

	"gopkg.in/validator.v2"
)

type Type1 struct {
	T *Type2 `validate:"nonzero"`
}

type Type2 struct {
	T string
}

func main() {
	v := validator.NewValidator()

	t := &Type1{
		T: &Type2{},
	}

	errs := v.Validate(t)

	for f, e := range errs.(validator.ErrorMap) {
		fmt.Printf("Result: %s - %v\n", f, e)
	}
}
```


I find its usually best to work with fixed dates in specs, unless you're using something like timecop

e.g.

```diff
- Time.zone.now - 30.days
+ Time.zone.parse('2010-12-12') - 30.days
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11669](https://teamcity.mesosphere.io/viewLog.html?buildId=105835&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:06


can probably return Product.find to avoid nested .thens


> we explicitly do not maintain any compatibility whatsoever with the MRI lexer...

OK. That is fine. However, the current behavior is inconsistent and illogical. I consider it to be buggy (though it's a very small bug, not a big one).

> Lexer tokens emitted by Parser are a stable interface too...

Since there is no specification for this interface, you can be judge of its correctness. If correctness is defined as "whatever the current implementation does", then I will have to concede that it is not buggy.

Your careful attention to maintaining backwards compatibility is admirable, but not if it means *not* fixing bugs.


今天任务没完成 淡淡忧伤2016-1-15


This shouldn't be cleaned up manually.  As @Zteve notes it should be placed in the appropriate bit of the existing cleanup.  You can tag it along [here](https://github.com/cloudfoundry/cf-java-client/blob/master/integration-test/src/test/java/org/cloudfoundry/AbstractIntegrationTest.java#L76-L78) ensuring that you [filter out](https://github.com/cloudfoundry/cf-java-client/blob/master/integration-test/src/test/java/org/cloudfoundry/AbstractIntegrationTest.java#L129-L132) the one created at startup.


How to use LIKE in datagrid.yml with %, eg link like “%word%”.
Native SQL looks

SELECT * FROM table WHERE link LIKE '%word%';

where:
        and: - referral.link LIKE '%key%'

doesn't work, because % reserved.


Are you sure `get_apc()` returns a valid list with at least 1 apc? Looking at [`get_apc()`](https://github.com/Apollo-Community/ApolloStation/blob/master/code/modules/power/powernet.dm#L153) it just runs `return apc`, but I can't find how apcs in areas are initialized so I couldn't check for myself what kind of `apc` is (in an area object)...


why are you finding the category you already have?


possibly - needed a fast alternative to the 'fancy dog request' and for some reason that was what sprung to mind


> Well, actually we are here only in case of stop()

Yes, but someone could call `flushIfNeeded()` while we're stopping and they'd possibly get a `CME`.

I don't think clearing in stop() adds much benefit; you could still get a concurrent `handleMessage()`.

As I said, I left this out because old entries in `fileState` won't hurt anything.


I just got De Morgan'd.


Ah, yes, you're absolutely correct that the behavior is internally inconsistent, so it is surely a bug. I was thrown off by the confusing comment about MRI... can you remove that and I'll merge?


Thanks for making this lib :+1:

Related: https://github.com/Joe-noh/japanese_holiday/issues/2


use _.merge to update an object


order.save should return the object you created


I think that we should consider moving this `url_for` into ptero-common.  Maybe outside the scope of this PR.


Just noticed that the `controller.test_code_redirect_by_email_token(mail_token, self) # TODO: hack to avoid having to call User controller for email link` lines have been removed.


Be careful about overwriting error messages


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/25623/testReport/) for this commit**


In fact, I think we should leave this (but synchronize it) - if someone uses this class without start(), we could get a memory leak without this code.


:laughing:


@drwetter I just recorded and added the client hello for imaps/pops mail on iOS9

Also OpenSSL is not exclusively a web browser and web browsers do ftps too.


I'll create another PR.


I'm not convinced Link should be a LinkedClassProperty, because if I remember correctly, Link does not point to a type. I am especially wary of changing code without any tests on it.


Sounds like a good idea. This code is all probably the oldest in the engine. Prior to this design I used to have more concrete classes and part of that design was the ability to parent any console to any other but it just felt messy. That's when I split things out to CellSurface and CellsRenderer and simplified attachment via the ConsoleList. After doing some animation/entity changes I want to go back to the consoles and totally redo LayeredConsole and GameConsole because they are total hacks and I hate them.


Please push this changes as new release, bower package is broken!
Thansk


why don't you do this before you create the Product?


its shadowHandler->ShadowsLoaded()
btw, CShadowHandler::shadowsLoaded is still public, i doubt you  want that now


Nice catch.  I had no idea this was going on.


shouldn't this check `processed_classes` rather than `seen_classes` from the enclosing scope?


This doesn’t seem to be used.


As the comment below says, I believe this can never be true since `validate` is only ever called from `uts46_processing` with the result of `some_string.nfc().collect().split('.')`.

Please remove either the comment or this chunk.


already have the product - you don't need to find it


You have...


hmm...


This cause a performance degradation according to http://trac.cppcheck.net/ticket/7314


history.py missing


remove .exec()


For this one, I suppose it's ok because it's only one line, but generally, all the menu sub-functions reside in different functions.


@pb00068 , perhaps also try swapping the 2 and 4 in this latest version?  (Meaning margin=4 for main thread, otherwise 2.)  For an example of my reasoning, suppose an access in the current setup with d = depth8-3 for both the main thread and a helper thread; the save request would be rejected from the main thread, but accepted from the helper.  Since helper threads are lower quality, it seems like they should be the ones with the higher bar.  This reasoning still needs to be reconciled with the benefit of 2 in the th=1 case, but I can see a few reasons for that...

Indeed just testing margin=3 for main and otherwise margin=2 seems to test a more aggressive sort of "main thread dominates" logic also present in the "pick move while preferring lower index threads".

Anyway just an idea... might be crap


This looks like it should be a mailer spec (`spec/mailers/request_mailer_spec.rb`). I'm not sure we need to actually follow the link in the email to make sure its correct.


Looks good tho


isn't this the default?


This will probably need to be of generic type instead of object.


Looks good. :+1:


Add explanation for why ordering in the database cannot be depended on. E.g. "because ALTER CLASS SUPERCLASS <class_with_higher_cluster_id>" are possible and valid statements.


think about moving this to a pre.save hook on the user model


This looks like it should be a mailer spec (`spec/mailers/request_mailer_spec.rb`) as its only the mail that is the subject under test.


Why delete the phone? :(


What is it you're trying to get it to do, with the formspecs?


This would not work for `@import url("foo")` syntax


You sir are a gentleman and a scolar.

Let's get this merged ASAP to avoid merge conflicts.


@radiodario I've tweaked this bit so it makes more sense in the warning and tells us how many hours out of date we are - ONE_HOUR should now work better


This is cool, I wasn't aware of `-I`.


`for r in registries`


Let's make this work for LESS too. They should work the same way


I don't think it does
On Fri, Jan 15, 2016 at 10:50 AM Vincent Lee <notifications@github.com>
wrote:

> Why do these need to have threading? 0.o
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Vazkii/Botania/commit/5438138c936e20a59559ee83b3ab3b7694d4ccac#commitcomment-15477439>
> .
>


> This change will prevent the harvester to import all the records if a server returns less records than requested (see also the warn on line 301).

In that case, you request for records from 1 to 20, the response contains 10 and you need to request next page starting from 10 to 30 ?
In GN, you may have ghost records in a page when the output format is not compatible with a record eg. ISO19110 records are not converted to ISO19139.

> I guess we should add some more harvester configs to deal with misbehaving CSW servers :(

Probably :( which implementation is doing that ?


@haarg does this same thing also need to be applied to Moo::Role::apply_roles_to_object?


> memory leak without this code

Right, that was one of my intention for this internal state of the handler.


You could leave the node in, and put it in the not_in_creative_inventory group.


Dear TF-Team and @vincentvanhoucke ,

where can I found the Udacity Deep Learning class with TensorFlow class?
Sounds really interesting, but I could not found any information about that.

Thanks,
Patrick


oke, but what do you mean with  in different functions.


Maybe `items` is a better name to avoid something like `products[0].product` which is a bit awkward.


:rocket:


Bein alors gwen, c'est quoi ce ptit projet oklm?


Should be pluralized


@rht It's already merged into master. rebase your branch onto master (so without that commit)


Thx!

IANAL but I do not see a conflict.  I added inline a remark stating where the data comes from and under which license this is. Besides I consider thisi in any case being a matter of friendliness the CC license ("BY") requires it.

Thx again.

Dirk


Any chance 0.1.2 will be published to maven central?


According to the representation in the schema it does. http://orientdb.com/docs/2.1/Types.html also says that (if you squint hard enough).
Also http://orientdb.com/docs/2.1/Tutorial-Using-schema-with-graphs.html seems to be one of a small number of examples that create link properties. and it definitely takes a linked class (NOT linked type btw)


The license file must not be deleted...


Please remove this.


That means to destroy my work. Moving it into filters is totally useless, since it only makes sense in direct combination and access with the select field. I am not amused! :anguished:


lovely job :shipit:


How would you elevate a user to admin?


Nope, we should remove it then (now).


But without .exec, it is not a real promise!


Good error handling! :+1:


Please pull this out into a function. You added the exact same code block in `build_mapping`


thingy


Really nice work! Looking forward to use this as soon as it gets merged upstream!


Can you explain what the issue is here? I'm not able to find the issue in the coverity UI


thanks to scoping it's the same thing here,but you are right


This looks like it should be a mailer spec (`spec/mailers/request_mailer_spec.rb`) as its only the mail that is the subject under test. I don't think we need to follow the URL to assert that its correct.


args are not needed here or?


Part of Issue #216


same here


Because there are no tags / no releases in `ember-dev`. I used the latest commit here in case a future commit in `ember-dev` breaks stuff here, which would then be harder to track down...

Will update the dependency once `ember-dev` has a release.


I kept all of this in for now, primary reason I've made the overwrite right now is that the injection broke because of some problems with mixin


yo add me here


Is it working fine or do you define this property somewhere?


If it is < 0 we should Sys::Drop as it is an invalid input from the server, likewise if it is more than svc_EOF? (Needs to be checked)


My naming might be crappy, but the following template makes the environment change into a positive for me. I'm also admittedly a glutton for low-level control.

```nim
# Makes the creation of the environment explicit, which I find quite nice.
template withEnv(body:untyped):auto =
  (proc () =
    body)()

proc outer =
  var s: seq[proc(): int {.closure.}] = @[]
  for i in 0 ..< 30:
    withEnv:
      let ii = i
      s.add(proc(): int = return ii*ii)
```


This is a strange route because it should be RESTfully returning a single category with a specific ID, but it returns products. Not a bad thing, but breaks REST a little. Maybe this functionality is better with a URL like `/products/category/:categoryId`.


it's the reverse....


Add guards against infinite loops and assert that they don't happen. Add a testcase with an infinite loop to test them.


Querying for the category itself is needless work since you use the category ID to find the products anyway.


line too long


two empty lines between top-level declarations


I mean we usually don't write the actual code directly into the menu code. We usualy wrap the whole thing in a separate function. If you run your eye down the different menu-item features, you'll see they're each wrapped up in their own "do-" function.

It's fine for this case, because the implementation of this function is just one line..


Any reason `dup` isn't implemented as `vec ++ vec`?


This looks like it should be a mailer spec (`spec/mailers/request_mailer_spec.rb`) as its only the mail that is the subject under test.


@cmbirk here's where the merge stepped on the downstream change.  Looks like git wasn't smart enough to realize that only one line had been changed, not two.  I'm making a patch for this now.


While I understand why you do it, it is weird to add extra arguments that are not being used, isn't there a nicer way to do it?


I am wondering why AMO changed the ID. There was some point where I had three versions of the extension at the same time.

Sebastian


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 205](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=674&buildTypeId=XbimEssentials_XbimEssentials) is now running


I'm trying to make the node open a formspec when you right click, the formspec it's similar to the one used by the furnace, but instead of fuel you use a glass of water/water bucket, and instead of cooking you humidify compressed dirt to make clay out of it.
I will revert the changes, then.


-> #417


nit: trailing comma


 init/init_millet.cpp
 @@ -39,36 +39,41 @@
 void init_msm_properties(unsigned long msm_id, unsigned long msm_ver, char *board_type)
 {
     char platform[PROP_VALUE_MAX];
     char bootloader[PROP_VALUE_MAX];
     char device[PROP_VALUE_MAX];
     char devicename[PROP_VALUE_MAX];
     int rc;

     UNUSED(msm_id);
     UNUSED(msm_ver);
     UNUSED(board_type);

     rc = property_get("ro.board.platform", platform);
     if (!rc || !ISMATCH(platform, ANDROID_TARGET))
         return;

     property_get("ro.bootloader", bootloader);

     if (strstr(bootloader, "T330")) {
       property_set("ro.build.fingerprint", "samsung/milletwifixx/milletwifi:5.0.2/LRX22G/T330XXU1BOD8:user/release-keys");
        property_set("ro.build.description", "milletwifixx-user 5.0.2 LRX22G T330XXU1BOD8 release-keys");
        property_set("ro.product.model", "SM-T330");
        property_set("ro.product.device", "milletwifi");
 +      property_set("ro.radio.noril", "1");
      } else if (strstr(bootloader, "T331")) {
        property_set("ro.build.fingerprint", "samsung/millet3gxx/millet3g:5.0.2/LRX22G/T331XXU1BOD8:user/release-keys");
        property_set("ro.build.description", "millet3gxx-user 5.0.2 LRX22G T331XXU1BOD8 release-keys");
        property_set("ro.product.model", "SM-T331");
        property_set("ro.product.device", "millet3g");
 +      property_set("telephony.lteOnGsmDevice", "0");
 +      property_set("ro.telephony.default_network", "0");
      } else if (strstr(bootloader, "T335")) {
        property_set("ro.build.fingerprint", "samsung/milletltexx/milletlte:5.0.2/LRX22G/T335XXU1BOD8:user/release-keys");
        property_set("ro.build.description", "milletltexx-user 5.0.2 LRX22G T335XXU1BOD8 release-keys");
        property_set("ro.product.model", "SM-T335");
        property_set("ro.product.device", "milletlte");
 +      property_set("telephony.lteOnGsmDevice", "0");
 +      property_set("ro.telephony.default_network", "0");
      }

      property_get("ro.product.device", device);
     strlcpy(devicename, device, sizeof(devicename));
     INFO("Found bootloader id %s setting build properties for %s device\n", bootloader, devicename);
 }
View 8  system.prop
@@ -1,7 +1 @@
 -# Radio 3g
 -# ro.telephony.default_network=0
 -# telephony.lteOnGsmDevice=0


`unit()` is not a static function in `Humidity` or `Pressure` ...


đây


@cryogenian Are these docs OK?


apply_roles_to_object uses create_class_with_roles to generate the class it uses.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 205](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=674&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:44


Try something like `findByIdAndUpdate`.


alo alo


This looks like it should be a mailer spec (`spec/mailers/request_mailer_spec.rb`). I'm not sure we need to actually follow the link in the email to make sure its correct.


Yes, thank you


You do realise that I added repcountset specifically for this


already have the cart


Makes sense.


Nice!


Can you implement the testcase with typed links and ensure it works? It's hard to argue that a new piece of code is better without a test that fails before and succeeds after.


I think, you can try to use `%%key%%`.


> 未整数→非整数

@Arthur2e5


Oh okay, totally makes sense -- only seemed strange in isolation ;)


Hmm, would be nice if Git credited me for my contributions :neutral_face:


why not just delete cart contents?


Yeah, that is a bit annyoing with ocamlfind remove/install... it should really print this to stdout...
Still I would rather see potential errors and live with some extra `Installed foo` lines.
In any case, for ocamlbuild it definitely makes more sense to use the `-quiet` option than suppressing all output.


identical lines


Probably you meant to call the variable @current_specialty?


Seems like both mysql and postgresql have the text type?


sorry, i made a lot of mistakes, i forget to run `git add youtube_dl/extractor/__init__.py`


@adamlerer Why did you remove this at the time? Didn't think about asking at the time, but now I'm wondering whether this was deliberate or not.


I spent a couple of hours debugging a race between an `@After` method and the creation of the test organisation. I am doing it inline until we find a robust alternative.


That's the OGMTypedEdgeTestCase


Use null in database if service_time is blank and vehicle::default_service_time_start / vehicle::default_service_time_stop


The [space-infix-ops](http://eslint.org/docs/rules/space-infix-ops.html) rule does not allow for `a===b` even in if statements, I'd argue makes things *less readable* in long if statements with many `&&`s as it has the disadvantage of removing the distinction between `===` comparisons and the `&&`s.

So, I put `( )` around the `===` comparisons to have to best of both worlds.


应该直接叫整型……


We brought back `project_before_remove_contributor` in 75983f1235366d73d0b6ef5a38c4427087f312b2. We should bring back this test, too. No?


@casey-collab


@itsjeyd We may just have to ditch the keyboard shortcut to display the help popup. What if there are other non-dndv2 XBlocks on the page that want to use '?' to display help? What if Studio or the LMS itself wants to do that? This code would conflict in those cases.


type needs to be an objectId reference - not a string


That's ok, keep up the great job.


Missing validators


I like this


@glyn This is a robust solution as all tests run blocking and the after runs blocking. There is currently no race and a properly implemented cleanup and test.  If you're having trouble why don't we pair on it.


Ya se te paso el tienpo tambien ati?


There is one more wily.cmake (Ubuntu 15.10).  I can add it with JIRA HPCC-14241 "Support Ubuntu 15.10...."
Looks good


Create a new graph for this test, you are inadvertently swapping out the registry for everyone, and the new registry isn't based off of the same node and relationship roots.


That's git for you ;), github remembers this lol.


I think this is fine, but for the record you can just throw the exceptions in unit tests rather than catching them. If a test throws an exception, it will automatically fail. The way this is written, even if we fail to parse everything we still pass the unit test.


These all look like mailer specs (`spec/mailers/request_mailer_spec.rb`)


indentation is off


is this really the way to test this? it seems that `t` can either be string or null.


why does this need to be `any`? can't it return `(this|string)`?


indentation; missing period


isn't stacked a function that returns a boolean? seems odd to say that it _is_ a boolean.


isn't this a getter? the comment indicates that it's a setter.


there are magic constants peppered throughout this file it seems. how about some comments, or descriptive constant names?


can you help me understand why this can be either type?


does this really need to be `any`?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11671](https://teamcity.mesosphere.io/viewLog.html?buildId=105847&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:20


The current code wouldn't fail for infinite loops. Which is probably a problem. I'm actually happy for the interpreter to throw runtime error and be done with it


I will backport stuff into `ember-dev` so it is more usable for ember addons; after that I think it would be a good time for a `1.0.0`...


this is not correct


@mdtusz I spoke too fast. We still need to register the scatter module in the core module as `scatter` is the fall back trace [`type`](https://github.com/plotly/plotly.js/blob/master/src/plots/attributes.js#L17).

We could, however, easily make the trace type default `allTypes[0]` instead [here](https://github.com/plotly/plotly.js/blob/master/src/plots/plots.js#L26). But that would be for a different PR.

Note that we would have to handle the case where someone tries to call `Plotly.plot` with only the core module without registering one trace module beforehand.


Could you add `{l s=""}` for the title ? We need to be able to translate it too :smile:


This could be made easier by putting `reviews` as a property on Product, so it can be populated.


Why does the construtor of ``HexDump`` take the data, if the data that is actually printed, is passed to the ``print_line`` method?
Why does the main code (last few lines of code) print the return value of the ``print_hexdump`` function?
``print_hexdump`` doesn't return anything? Also please use explicit keyword arguments.

But I think we don't actually need hexdumps. It's just pretty printing of binary data. For testing we can just assert on the bytes objects.


There will be a notice here if `$campaign->field_current_run` doesn't have a `$language_code` key. Please handle this case properly.


I've copied style from the existing code in this file :)


what?


We're assuming a 1-1 mapping between variant annotation sets and variant sets here. We'll want to generalise this to be more flexible at some point (not urgent though).


Put `var categories;` up here and reassign later on.


I think that's a bad idea because it propagates an exception that the library *caused* rather than one that it *raised*. The first is by definition a bug in the library, while the second is incorrect use of it.


The style in this file is inconsistent, so when in doubt, follow PEP.


Because there is no `return` here, if something goes wrong, your error handling will not catch it.


@fabricioflores no nos sirve? ^


I agree that this does break the chain.  Nice.


This assumes that we can only ever use these variants. It'll be better to store the variant set and generate the variants on the fly. Here, just set `self._variantSet = variantSet` and don't store variants.


Just testing email reply

*From:* Mykhailo Sulyma [mailto:notifications@github.com]
*Sent:* Friday, January 15, 2016 8:20 AM
*To:* orocrm/platform <platform@noreply.github.com>
*Subject:* Re: [platform] BB-1720: Make (Frontend) Product - Add to
Shopping List(s) an Action (d879d76)

I think, you can try to use %%key%%.

—
Reply to this email directly or view it on GitHub
<https://github.com/orocrm/platform/commit/d879d76cc61bdad32bb0d86a99e70319ba89f142#commitcomment-15478184>
.


Whoops, also has the fix for #2293 in it.


Should not this defines in os_test makefile instead?


on the list of: things which make no sense.


It does, but it still pushes the merge when I push.


Is there metadata in a VariantAnnotationSet?


Note that this test still fails for me:
```
  1) yargs dsl tests locale uses english as a default locale:

      AssertionError: expected 'de_DE' to equal 'en_US'
      + expected - actual

      -de_DE
      +en_US
```


Sorry, phrased it confusingly: Why should we remove this? I think setting the data (redundantly) will reduce errors because it eliminates the need to meticulously check whether the shared_ptr is set. We are retaining the existing response data anyway.


hard coded file path could be handled with an argument or parameter.


Okay, you can take a look at https://github.com/minetest/minetest_game/blob/master/mods/default/furnace.lua and start renaming and commenting out parts.  Or I will as I can.  Putting it it furnace.lua and using dofile(minetest.get_modpath() .. "/furnace.lua") enables you to easily comment out this file from init.lua.


Cool. Now we need to switch `nodesPrivacy.js` to use this, ya?


It does not. It even makes the option more powerful, codewise.

And also in the UI. This was an option internally called *toggle_dir* with the UI being a radiobox *strict yes* and *strict no* with no connection to the directory selector. Moving it into the filter and giving it a clear name you should regard as a favour I'm doing you, because only now it is comprehensible. That is something that was told to you before and you did not react.


I think this might be overriding the `gpl` parameter in the URL?


Yes I know python2 defaults to python here.

The package come from the AUR. I copy-pasted it but actually wondered whether to keep those two lines or not.
Being a python developer myself, I think it is a good practice to use ``pythonX`` instead of ``python`` for scripts that are tied to a specific version of the interpreter (I prefer explicit over implicit and I think ``python`` should only be used for scripts that can be interpreted by both interpreters). So I decided to keep them. Do you want me to remove those two lines?


Sure. Will correct that.

FTPS: Which  browsers still do that?
IMAPS/POPS: for the client I only see for OS9 on the client side with Safari.


neat.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11670](https://teamcity.mesosphere.io/viewLog.html?buildId=105846&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:08:47


This is the entry point, and should look something like
```python
def getVariantAnnotations(self, referenceName, start, end):
    for variant in self._variantSet.getVariants(referenceName, start, end):
         yield self.generateVariantAnnotation(variant)
````


I fear, that would not help. If the default behavior is not changed, all Module functions, which return Poly objects would not change. Example: polyfit. I think it not efficient to change these functions as well.
Introducing two new fields into Poly does not look like a good idea because of memory overhead.
The idea of relative tolerance is not bad, but it does not account for the scaling properties of polynomials, that means because the coeff[k] has to be multiplied by x^k the dependency on x is very important, even more than the relation to the other coefficients.
I still favour the proposal #39, maybe adding the relative tolerance idea into the new truncate function.
This proposal has much more code changes than #39.
I have the conviction, the default behaviour as it is now is a serious mathematical error which should be eliminated.


Un petit projet pour m’entraîner sur Angular et Less, je vais pas mal commit ces prochains jours tu pourra garder un oeil dessus ;)
Et si je suis content du résultat, je mettrais en prod mais bon j'en suis pas encore là


The reason why `ExtendablePoolAllocator` doesn't call `int` directly is that `init` ends up allocating memory, so it can fail. If that happens in a constructor, there's no way to propagate this failure to the caller.
Also, you should probably call the `ExtendablePoolAllocator` constructor explicitly.


No, as long as there is a reason to have them, and not just copy/paste


Why `bool` ?


I guess it's just an issue of us having in-progress commits when we do a git pull with staged commits.


Because you can still use this factory to create an enterprise/advanced database.


I think @niklas-arm is right, this belongs in `compiler-polyfill`.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11672](https://teamcity.mesosphere.io/viewLog.html?buildId=105859&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:09


according to the docs, setUp is called before every single test https://docs.python.org/2/library/unittest.html#unittest.TestCase.setUp


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11674](https://teamcity.mesosphere.io/viewLog.html?buildId=105861&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:15


This should use the atomic_ops in `core-util`, so that it can work on various platforms.


It would


سلام این چیه ممد ؟


All of `prop`, `prover9`, and `insert` should be tactics, not tacticals.  You usually only want to apply them to the current goal (otherwise you can always write `repeat { prover9 }`).

The reason for this is that for example `prop` can only solve very simple goals, and for some goals it might not even terminate (in a reasonable time).  So you only want to apply these tactics to the current goal, which you have already sufficiently simplified.


i srsly dnt like this thing verymuch :P


What happens if `alloc()` returns NULL? (same observation below).


I guess that might work, I will experiment with furnace.lua and see if it works for me.


Hi,
when will you set the disableDiff as false in xml file?


OK, here we generate the actual annotation. This'll be something like
```python
def generateVariantAnnotation(self, variant):
     # To make this reproducable, make a seed based on this specific variant.
     seed = self._randomSeed + variant.start + variant.end
     randomGenerator = random.Random()
     randomNumberGenerator.seed(seed)
     # etc
```


Ok. Good point. I will change in the next commit.
Den 15/01/2016 17.38 skrev "Gabriel Ebner" <notifications@github.com>:

> All of prop, prover9, and insert should be tactics, not tacticals. You
> usually only want to apply them to the current goal (otherwise you can
> always write repeat { prover9 }).
>
> The reason for this is that for example prop can only solve very simple
> goals, and for some goals it might not even terminate (in a reasonable
> time). So you only want to apply these tactics to the current goal, which
> you have already sufficiently simplified.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gapt/gapt/commit/2c1234106476c001dc075a279caaeee62e1268b5#commitcomment-15478671>
> .
>


Pretty please, don't do this. I feel like reading BASH :)


```python
for base in enumerate(variant.alternateBases):
     # etc
```
is the Pythonic way.


Nice, awesome to get rid of that internal state!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11673](https://teamcity.mesosphere.io/viewLog.html?buildId=105860&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:10:01


I already found the answer, thanks


dfgfgf


I think you might start seeing the advantages of rx @oscarlorentzon ;)


Function naming: `repeat` is called `replicate` with reversed order of parameters in `Vector`and `Data.List`.

Why isn't `unit` a `Seq` of length 0?

I don't recall the exact problem but I remember going across `value` gave bad code from the code generator. Can `indexed1` be used instead of `toPull $ value1 []`?


Re-add this if u r using gcc4.9 or higher


@datapimp I just opened all this issues: 5338, 5339, 5340, 5342, 5343 and 5344. At this point I feel like we need more people to try it to get a better sense of how far we're from making this fully available. If you want to give it a try and give some feedback that would be great!. Also, of course, we'll all be super happy if you want to contribute ;)


was this done to avoid the analytics prompt message?


Thank the gods, no more invisible stools. :+1:


So, these are basically copies of the existing functions, right? We should try to reuse these as much as possible. There are some options here:

1. Make SimulatedVariantAnnotationSet a subclass of VariantAnnotationSet  and inherit these methods directly.
2. Make a VariantAnnotationMixin which both SimulatedVariantAnnotationSet inherit from
3. Make these as standalone functions within the module.


This should be caught at the driver level rather than the frontend level, so that the error message only gets emitted once instead of N times.


Lovely ❤


When using this version (```compile 'com.github.quentin7b:android-location-tracker:3.1'```) in a project targeting SDK version 23, it says that I need to handle correctly when user doesn't grant the permission.

I used the README's code (implemented a requested --by Android Studio-- onTimeout():
```
LocationTracker tracker = new LocationTracker(context) {
   @Override
    public void onTimeout() {
    }

    @Override
    public void onLocationFound(Location location) {
    }
};

tracker.startListening();
```

When I lower the target SDK version to 22, Android Studio stops the warnings.

I guess this commit is for solving that issue, but I don't know if the code that's on the README needs to be updated. Thank you, @quentin7b :+1: !


FWIW since these are hosts this can probably be limited to 255, but in practice _probably_ doesn't matter too much.


Better to describe the action under test: `describe 'GET show_response' do`


TeamCity Reaver Project :: ReaverLib :: Test Build with Clang [Build 93](http://ci.reaver-project.org/viewLog.html?buildId=1400&buildTypeId=reaverlib_TestBuildWithClang&guest=1) is now running


I really don't see the point of these comments I'm afraid!
```
 # impact enum
 impacts = []
```
I can see that it's the impacts enum by reading the code! Inline comments like this are meant to be used sparingly to explain things that might not be obvious from reading the code. Python code is supposed to be so obvious that comments are necessary.


TeamCity Reaver Project :: ReaverLib :: Test Build with Clang [Build 93](http://ci.reaver-project.org/viewLog.html?buildId=1400&buildTypeId=reaverlib_TestBuildWithClang&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 84 Build time: 00:00:26


We shouldn't have hardcoded strings here. Use ``protocol.Imact.HIGH``, etc.


LGTM


This should be something like
```
effect.hgvsAnnotation.genomic = None
#etc.
```


aw....


```bool``` because of the chained syntax you hate ;)


I don't think we need this line


I would probably do these the other way around:

Start the synapse, start probing it over HTTP for it to actually come up, then when it's come up, start exposing our own HTTP interface.

Partially because it's poor form to accept connections before you can fulfil them, and partially because the synapse failing to come up is an error we can notice eagerly and give debugging output for, whereas right now if an invalid cert file or key is passed, or a port can't be bound to, or something, we silently ignore it.


Hi,

if you change your code instead of commenting it out, it would be much better to understand what you have changed...


Drop your else to reduce indentation, just:

if u, err := url.Parse(*synapseURLStr); err != nil {
  panic(err)
}
synapseURL = *u


I think these tests could be a little simpler, no need to get involved in actual loading and rendering. Maybe just do
```
new Cesium3DTileset({
    url : './Data/Cesium3DTiles/Tilesets/TilesetOfTilesets'
})
```

And then check that `_url` and `_tilesJson` are expected values.

Also change the names of the tests to reflect this.


We shout acronyms in go:

synapseURLStr


true! closed!


Y u no scrubbing ckey in `add_*_whitelist()` or `setDonator()`?!? Shit is dangerous


I don't think we need this line either


Lines 34-36 throw the following the error `Uncaught TypeError: t.map is not a function` at `app.js:1855`
I can't figure out why yet, but you can comment those lines out and it'll compile.


should be working also with the new one, but didn't checked why currently not working ... too lazy to look for a reason ... just downgrade drivers and it works ! Maybe it should edit/update also init.qcom.rc or/end BoardConfig & device.mk :)


Already included in the used filter class


Oh thanks, I didn't know that.

The problem with squashing is that we have a refactoring commit in-between. And since this commit actually does what it's intended for (like, functionality for the user), I would say it's fine to have it as separate commit. But I could just rewrite it using `const`, if you since it's necessary.


@Rlin415 request-handler.js has some at least one function using Mongoose. I think removing Mongo at this point would break the apps current functionality...


Apparently the sequence does exist. I assume it is used elsewhere. Please don't delete it.


Good catch. I'm also writing a functional test for it.


Don't you want to return here?


Wie wäre es, wenn wir einfach alles in femininer Form schreiben? Fände ich viel lustiger und cooler.


Great, this fixed the compile errors for me.


Was this really necessary?


:) I know. There were a few beats with 2 sentence descriptions, so I added periods to all because it looked a bit cleaner. With the other commits I've made, it should be consistent now.


Why the intermediate? Why not just:

if synapseReq, err := http.NewRequest(...); err != nil {
  report error
  return
}


s/old/orig/

s/creates the correct diff which cancels out the age contributions in the time the old key was live./ages those original stats by the time which the previous version was live./


Should probably return JSON?


There are a sign that would work with older drivers ? Thanks !


Good point for the case sensitivity, fixing it.


I wouldn't stub a return value here as we're not using a double. This just makes the spec more brittle to changes. I'd just create a record with the correct attributes.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/25628/testReport/) for this commit**


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11675](https://teamcity.mesosphere.io/viewLog.html?buildId=105862&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:25


Aha. Hmm... Do you want to move it to the separate file as well, or just create a component here? I think don't feel very comfortable with moving it out to other file.


Thanks.
A couple comments:
1. The license header is wrong on all Java Files, please use the one described in https://docs.google.com/document/d/1RZz2nd2ivCK_rg1vKX9ansgNF6NpK_PZl81GxZ2MSnM/edit#heading=h.iayg4mgzyzs8
2. As best practice please try to add more comments in the code to describe what a particular big piece of code is doing.
3. There is a number of logger.error and logger.info but no logger.debug. How do you plan to track an issue and debug it from logs when it happens ?
4. this pull request is missing test
5. this pull request is missing documentation


@Lyadis you should use this syntax to properly refer to issue on other repositories: HEADS-project/heads_ide#86


Something that @dmurphy mentioned was: Do we need to have the toggling functionality at the beginning of the function, or could it be at the end? Do we need to be recreating the comment form every time we toggle the comment button; is that wasteful?


It's more usual to assign outside of ifs, if you're actually using the result:

resp, err := synapseClient.Do(synapseReq)
defer resp.Body.Close
if err != nil {
  error
  return
}

w.Header()...
...

to avoid unnecessary nesting


Why not just copy all headers? (and on the request, too)


For the future, globals are icky :) But we'll ignore them for now...


That would be good, perhaps early one morning next week? Meanwhile, feel free to try it out: I'm merging frequently to avoid delta clash nightmares.


Skript > Java


The original specs here were passing an `:incoming_message_id` parameter. Don't know if dropping that was intentional?


This is a great workaround. I had a problem exporting a N field, and debugging I reach the same problem. I was having a "7,25" DecimalFormat number, and then the file shows a "0.00" in that field.

I found the same error and I was going to rewrite the library but fortunately you have mantained it. Thanks a lot for your work! I had downloaded the 0.6.0.

By the way, why don't you upload to the mvnrepository.com?

Pd: Sorry about my english. I am from Argentina.


Actually, it looks like we can get rid of `project_before_remove_contributor` along with this test and the test in the GitHub addon.

https://github.com/CenterForOpenScience/osf.io/pull/4799#issuecomment-172011497


But I am, unless there is some secret update that isn't available here: https://github.com/smealum/ctrulib


Better to describe the action under test: `describe 'POST show_response' do`


The alert search defines the criteria for creating an instance of an alert.  By nature 1:N with an alert.  An alert search has a 1:N relationship with producers.  That's the picture we had on the board the other day (and still makes sense IMO).

Strategic:
I want to generate alerts when a new vulnerability is detected (query), and notify a@b.c via email, and the slack channel xyz (producer instances that refer to this alert search).

AlertSearch:Producer 1:N where N is probably fairly small.

Tactical:
task detected a match on the query.  we should create a alert and send via all known producers for our related alert search. select producer where alertsearch == alert.search_id, then x.send(self).

AlertSearch:Alert 1:N where N could be very large.

Where do you get the value for channels when you create an alert?  If you are getting it from the AlertSearch, then you can just look it up via the FK to your AlertSearch rather than store it with every alert.  Besides, why would you store a string representation of a list of channels rather than use the data model to reference the actual channels.  It's brittle and inefficient.


:+1: thanks


This group of specs has been deleted without replacement.


Use the named route rather than passing controller/action params


not sure, but doesn't this result in a negative value as the default for from_default ?


il codice funziona bene...


PocketMine.yml is working, we added a cache config file, now it is imagicalmine.yml


Locking


Thanks! No idea how I missed it.


Yes indeed.


great


Ah :D


This looks fine thanks. Are most links on the site complete urls or just relative references? If we were to build a testing server the complete urls (with the full domain name) wouldn't work out well.


Yes, this should be ```atomic_inc/dec```.  Those functions require some rework, however.


So... the Header will appear beneath the header? Renaming is the best strategy


wow, a really cool logo. Well done, guys!


@yurrriq A fresh clone of your repository and trying to compile gives me:

```
 LFE    upload-app.lfe upload-handler.lfe upload-sup.lfe upload.lfe
src/upload-sup.lfe:23: unbound function: #(map 6)
```


@fabricioflores borra, no comentes


For info having an LFE file in cowlib and building/running a release works fine for me.


Beat me to it :) , thanks will merg.


in case of WoT 0.9.12+


So do angle brackets work now on your machine? Can we rename `TAMP(.*)` back to `$1`?


I get two spec failures on this commit

```
Failures:

  1) ResponseController when viewing the followup form calls the message a followup if there is no incoming message
     Failure/Error: expect(get_last_post_redirect.reason_params[:web]).to eq(expected_reason)

       expected: "To send a follow up message to Example Public Body 1"
            got: "To reply to Example Public Body 1."

       (compared using ==)
     # ./spec/controllers/response_controller_spec.rb:44:in `block (3 levels) in <top (required)>'

  2) ResponseController when viewing the followup form calls the message a reply if there is an incoming message
     Failure/Error: expect(get_last_post_redirect.reason_params[:web]).to eq(expected_reason)

       expected: "To reply to Example Public Body 5"
            got: "To send a follow up message to Example Public Body 5"

       (compared using ==)
     # ./spec/controllers/response_controller_spec.rb:38:in `block (3 levels) in <top (required)>'

Finished in 8.88 seconds (files took 26.14 seconds to load)
13 examples, 2 failures

Failed examples:

rspec ./spec/controllers/response_controller_spec.rb:41 # ResponseController when viewing the followup form calls the message a followup if there is no incoming message
rspec ./spec/controllers/response_controller_spec.rb:35 # ResponseController when viewing the followup form calls the message a reply if there is an incoming message

Randomized with seed 12585
```


I downloaded v0.0.14 and this fix fundamentally breaks everything for me. When I revert it back, it works fine.

Maybe it's something I'm doing wrong, as it always goes into that "else", but then I get an error saying getBoundingClientRect is not a function. I'm trying to run the most basic example code.


Releasing zalgo?


In the copy constructor (line 98) you just overwrite the current value of `ref`. Is that intended?


Surely, I'll do so. But I think I *might* have found one other bug. Let me look at it first.


call this product


I think you also need a move constructor.


:coffee:


So the idea here is that the more configuration you have, the more weight is assigned to it and the more likely it is to be evicted?


Enabled and Healthy don't mean the precision landing sensor has a target/beacon in view, does it? I think it would be beneficial to have a mavlink message to reflect if a target is being tracked.


I don't really think there are any security implications to expanding the number of URLs that this filter skips, is there?  One prerequisite of this plugin is that people are using the Active directory security plugin.

So the way I look at things is the Active directory plugin still handles security.  The only purpose of this plugin is to automatically log me on so I don't have to manually enter my credentials.

If this filter is skipped, there is the potential that the active directory plugin determines I'm not logged on and will redirect me to the login page.  But there isn't any way I could access data that I otherwise couldn't access, right?


Either there is a typo or this can be merged into "return true if architecture.blank?".


Added the sample.csv file. Use the following to get same thing : https://www.youtube.com/user/csev/playlists


This check has been removed?


Unrelated to this PR, but I wonder if this delete is necessary here. `clear` about also does this delete.


that's true. Thank you for the hint. I will apply it in future.


If this is run by npm, then `./node_modules/.bin` will be added to `PATH` right? I was thinking maybe the `ask()` function could be `askElectron()` and just do `exec('electron',..)` and if we have electron installed as a dependency, that would be hit automatically?


Ein "generisches Femininum" sozusagen. Fände ich witzig!


I like :coffee: :banana: and :100:;


This looks ok, but I wanted to log the research I did on django-storages.

2.25.0 warns about a siginificant change to `S3Connection.get_bucket`

http://docs.pythonboto.org/en/latest/releasenotes/v2.25.0.html

    IMPORTANT - This release also include a SIGNIFICANT underlying change to the Amazon S3 get_bucket method, to addresses the blog post by AppNeta. We’ve altered the default behavior to now perform a HEAD on the bucket, in place of the old GET behavior (which would fetch a zero-length list of keys).

    This should reduce all users costs & should also be mostly backward-compatible.
    HOWEVER, if you were previously parsing the exception message from
    S3Connection.get_bucket, you will have to change your code (see the S3 tutorial
    for details). HEAD does not return as detailed of error messages & while we’ve
    attempted to patch over as much of the differences as we can, there may still be
    edge-cases over the prior behavior.

We are running django-storages 1.1.8
https://github.com/jschneier/django-storages/releases/tag/1.1.8
Which is 87ca0ef

When django-storages calls `get_bucket` it does not parse the exception message, so I think we are in the clear.
https://github.com/jschneier/django-storages/blob/87ca0ef/storages/backends/s3boto.py#L312


ckey() actually already does that, I just accidentally left a sql_sanitize_text() on one


If i'm reading this right, only tests that use 'dirtiesContext' will have CCM Bridges that they can change right?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/25631/testReport/) for this commit**


Your way would make it work regardless, whether this is run by npm or not. So this is fine I guess :) Just wanted to comment about it.


one JS and one **CSS**


I'd make these distinct actions:

```ruby
def set_incoming_message
def set_info_request
def set_last_request
```


Oh yeah, you mean `"Encoder.h"` to `<Encoder.h>` right? I forgot to do that but I'll do that now.


Use `that.config_.capture.maxProperties` instead of 100 here?


Sorry for asking this silly question, Should the license be updated to a range like 2015-2016 or should it remain as 2015 because there hasn't any version release in 2016?


ditto


### Week 9 Assignment Feedback

@MariaVintimilla Nice job with your changes!  One thing to note:
* Make sure to watch out for the naming conventions of `function`'s in Javascript (https://github.com/emeraldaly/WrightFaceGame/commit/1e925f3bd5317daf713a2781645ccf6b7378d472#diff-4725c0ce919c309d16e2ebd517e25956R4).
* A best practice for naming conventions of `function`'s is the `camelCase`:
```javascript
function yourFunction() {
  //---JS Code
};
```


Shouldn't this still be here?


Honestly don't know, but AFAIK it doesn't matter.

http://www.contentious.com/2007/01/07/copyright-notice-is-the-year-really-necessary/


Ah, that again. So it's "return true if architecture.blank? || repo.blank?", right? :-)


Good catch, it most certainly should.


This `script` file could be hard coded right? I.e. we don't really need to write it to disk if it's provided by `prebuild`?


The original ordering of these was (marginally, tbf) easier to follow:

```ruby
@is_owning_user = @info_request.is_owning_user?(authenticated_user)
@gone_postal = params[:gone_postal]
@gone_postal = false if !@is_owning_user
```


how


This is a hard failure.  We can't know, in ```Function```, if we're in IRQ context or not.  Minar has the same problem, currently: You can't know whether a postCallback fails due to memory allocation.


Err, I didn't mean hard coded, I meant we could write it once and provide it with the prebuild module.


Agreed, but it maybe it deserves a call to https://github.com/ARMmbed/core-util/blob/master/core-util/assert.h#L44


Turns out the other thing I suspected is not really a bug at all. So forget about it. Updating this PR.


Cool, done! https://github.com/openseadragon/openseadragon/pull/820


explain this. Are you just returning a list of neighborhoods?


Can't do asynchronous work inside of a virtual.


Finde ich auch gut! (Wobei wir jetzt nicht unbedingt alle vergangenen
Posts durchgehen müssen [auch weil Immutability ja etwas Gutes ist], die
Workshop-Ankündigung war mir nur gerade aufgefallen.)


Ist in englischen Texten der Informatik absolut üblich. Mache ich in meinen englischen Texten (also praktisch allen) eigentlich auch immer so. (da äußert es sich natürlich hauptsächlich als "she" anstelle von "he" oder dem "they" im Singular). Warum nicht auch auf Deutsch?

Ich bin finde das Binnen-I und Formulierungen wie "Studentinnen und Studenten" ziemlich furchtbar, aber ein generisches Feminimum ist in Ordnung.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11677](https://teamcity.mesosphere.io/viewLog.html?buildId=105870&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:13


Best to name fields that are references as if it was post-population to avoid something like `favorite.aptId.location`.


In other places in the codebase, we appear to just check for the existence of `invalidateShadowRenderer` per https://github.com/webcomponents/webcomponentsjs/blob/e327439975d265dab71717bcacde993569bd12f1/src/ShadowDOM/wrappers/HTMLElement.js#L193, however the last review did ask to check this is a function so it should be fine.


you will never hit the next(err)


@grosenkj These should probably be done on the SimPEG code base on the mt/dev branch?


try findById


No info available yet. Stay tuned.


@pb00068 , out of curiosity, why did you only change one of the calls to tte->save() in search.cpp?  It seems yours is an important one, but for instance the ones in qsearch() might also care about the margin parameter..


`reviewTitle` should have a better name -- `review.reviewTitle` is awkward.


use google's android tool chain
it seems to be faster for me
https://github.com/Zenfone2-Dev/android-google-toolchain-4.9


Maybe deserves to be an `enum`?


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 210](https://teamcity.labkey.org/viewLog.html?buildId=297078&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:02:14


> I understand but why not implement RTL6b on a new PR?

Well you can, but I am really not sure this PR is demonstrating anything, that is the point.  All it shows is that if you send a RAW message along a WebSocket it returns a `ACK`/`NACK`, so that's not even testing any of the functionality really of the client library.


I'd extract the outgoing message setting to its own filter. I find it really confusing that this calls a private method, which in turn calls another private method which sets some more instance variables.


Agreed (d4f9220ed202044c645b97b608d0d0b5088922b49, I was going to tell you to just use a previous revision of the nixpkgs tree but the only available 14 release never made it into nixpkgs. I also unpinned the product builder so that end users can import it into their `~/.nixpkgs/config.nix` just in case (69c98f75e23393baa419757f903bf690bbebb3dd). Finally I've started working on a patch for intellij.


They aren't required because `version` and `isDSE` are now "derived state" in the sense that whatever their value, there is a corresponding value in `createOptions`. But in a certain way you are right, because it doesn't do any harm to keep them here, so I will amend.


I'm not convinced this is correct.  What if the shape of p2 at runtime is [3, 2]?

I believe the output should be [None, 2] in this case.


@bradenmacdonald I guess we could do that -- it would also fix the problem affecting Studio (which I haven't had time to address yet).


Yes, @rowanc1 this has been fixed on mt/dev as well. I currently running with simpegMT, while developing mt/dev and I wanted these fixes there.


```
router.post('/', function (req, res, next) {
  res.send(req.body);
});
```

The above will pass this test. Why? How to fix?


I believe in this case, you would expect ndims == 2 but the dimensions to be [None, None]


Yes :) I added this safeguard because I am suspecting some tests in 3.0 to be altering clusters without declaring dirtiesContext = true.


;) thanks


finder - `browser.find('li').containing({text: 'blah'})`


Exactly.


Both. If the include changes to <Encoder.h>, then our files don't need the TAMP prefix any more


I think `__PRETTY_FUNCTION__` is a GCC extensions (not sure if it works in armcc)


TeamCity pull requests :: netty [Build 1039](https://garage.netty.io/teamcity/viewLog.html?buildId=4791&buildTypeId=pulls_netty&guest=1) is now running


I'm not convinced the Merge shape inference is correct.

The merge definition is:

`Merge` waits for at least one of the tensors in `inputs` to become available.
It is usually combined with `Switch` to implement branching.

`Merge` forwards the first tensor for become available to `output`, and sets
`value_index` to its index in `inputs`.

It is an error if more than one tensor in `inputs` is available.

Which means, as far as I can tell, the tensors do not need to have compatible shape.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11679](https://teamcity.mesosphere.io/viewLog.html?buildId=105890&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:08


Then please stop doing me "favours" like such!
Its not about the name change I am not happy with, its about storing it away as an option. This makes it unusable for direct decisions, since you now always have to go the way over the "sort" layer box, as far as I can see. This is not the way I wanted it to behave.
(We could talk about a tiny + / - button though, beside the select field instead of my radio fields, but that would mean to really talk before...)


Relates to b34397b


Ok, fixed.

```
KellerFuchs@to1$ sudo apt install pass imagemagick golang-go clojure1.6
KellerFuchs@to1$ sudo etckeeper vcs format-patch --stdout -C -M origin/master.. | git am
KellerFuchs@to1$ git push
KellerFuchs@to1$ cd ~/admin-tools && ansible-playbook -i hosts -K sync.yml
```

I would ask whether apt indicated it was going to deinstall things before you confirmed, but it has been a while.
We can check the logs on `ny1`, though.


@SeymourApps, just to let you know that I have reworked your proposal and integrated in Rufus.

See pbatard/rufus@96f421f7d29b56df3ac606997f1b46e7f7b1a839 for the kind of patch I wanted you to submit. One of the issues with adding this was also that `ChangeWindowMessageFilterEx()` is only available on Windows 7 or later, so it would break compilation with MinGW, which is what I use to produce releases. And even switching to `ChangeWindowMessageFilter()` wasn't enough, since this was introduced with Vista and we need to be compatible with XP. This is why you'll see that I had to go with `PF_TYPE_DECL()` and `PF_INIT()`, which are the calls I use to fetch API calls directly in the DLL (doesn't require the compiler headers to know about them) and also added a couple related `#ifdefs`.

Still, you really did the hard work there, with figuring out which API calls were needed, and I'm sure having drag-n-drop in Rufus will make a lot of people very happy, so thanks a lot for your patch! :smile:


This is weird and maybe outdated based on what is in the route.


:+1: my bad


trying to think why this was important... Something to do with testing pages that had already imported `jQuery` without require...? Honestly can't remember.


This one should work; however, the code is likely incompatible with GCC >= 5.0, I'm investigating that.


I thought the magic number was supposed to be 42, not 40 :tongue:


Be careful about putting that password there.

*Take care.*


don`t completed -> not completed


yes indeed


ping @Artpej  :smile:


Of course! Sorry I couldn't make your requested changes because I've been
swamped with school, and git was being annoying.
On Jan 15, 2016 12:30 PM, "Pete Batard" <notifications@github.com> wrote:

> @SeymourApps <https://github.com/SeymourApps>, just to let you know that
> I have reworked your proposal and integrated in Rufus.
>
> See pbatard/rufus@96f421f
> <https://github.com/pbatard/rufus/commit/96f421f7d29b56df3ac606997f1b46e7f7b1a839>
> for the kind of patch I wanted you to submit. One of the issues with adding
> this was also that ChangeWindowMessageFilterEx() is only available on
> Windows 7 or later, so it would break compilation with MinGW, which is what
> I use to produce releases. And even switching to
> ChangeWindowMessageFilter() wasn't enough, since this was introduced with
> Vista and we need to be compatible with XP. This is why you'll see that I
> had to go with PF_TYPE_DECL() and PF_INIT(), which are the calls I use to
> fetch API calls directly in the DLL (doesn't require the compiler headers
> to know about them) and also added a couple related #ifdefs.
>
> Still, you really did the hard work there, with figuring out which API
> calls were needed, and I'm sure having drag-n-drop in Rufus will make a lot
> of people very happy, so thanks a lot for your patch! [image: :smile:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Int80x/rufus/commit/54a13332743feb953cb32d14dd58a6cd6f32df78#commitcomment-15479889>
> .
>


Awesome, I love it already!


You can make BlockEntity and BlockEntityRendererId class? I need in it :(


V nice


Ich fand lange Zeit das Binnen-I und Formulierungen wie "Studentinnen und Studenten" auch optisch schlecht. Mittlerweile habe ich mich daran gewöhnt -- bei unserer Arbeit im Mathezirkel für Kinder und Jugendliche ist es wichtiger, explizit die feminine Form zu verwenden (um zu helfen, gewisse archaische Vorstellungen zu überwinden), als das generische Maskulinum der besseren Optik halber zu verwenden.

Nicht besonders schön finde ich übrigens auch Formulierungen wie "Teilnehmenden". Zumindest ist es kürzer als "Teilnehmerinnen und Teilnehmer".

Wenn wir hier einen Konsens für das generische Femininum haben, vereinfacht sich natürlich alles!


because you assign the same key to multiple values :)


this line doesn't do anything


Do these 2 headers exist in armcc? What implications does <tuple> have in terms of dynamic memory allocation?


Chain is new to me.


ups war kein request @jplitza and @mortzu so okay?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11678](https://teamcity.mesosphere.io/viewLog.html?buildId=105876&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:08:37


the `bind` here is not needed


not sure why a List is better than a String here


bad godoc


actually changing it uncovered another problem. build_schema() should always be called with new declarative_node() and declarative_relationship(), because it does change the underlying registries.

But its too late to change the interface


fair comment, anything that make this easier to read has got to be a plus


On that topic, should we try to log things that we do like this? Something
like `sudo apt install pass imagemagick golang-go closure1.6 | tee <log>`.

On Fri, Jan 15, 2016 at 11:30 AM The Fox in the Shell <
notifications@github.com> wrote:

> Ok, fixed.
>
> KellerFuchs@to1$ sudo apt install pass imagemagick golang-go clojure1.6
> KellerFuchs@to1$ sudo etckeeper vcs format-patch --stdout -C -M origin/master.. | git am
> KellerFuchs@to1$ git push
> KellerFuchs@to1$ cd ~/admin-tools && ansible-playbook -i hosts -K sync.yml
>
> I would ask whether apt indicated it was going to deinstall things before
> you confirmed, but it has been a while.
> We can check the logs on ny1, though.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hashbang/shell-etc/commit/0745cd503ee4d77443312bbc4e6d2723640fbff3#commitcomment-15479885>
> .
>
--

Charles Heywood <vandor2012@gmail.com>
Programmer :: Scripter :: Designer :: Administrator
https://github.com/ChickenNuggers


This is not correct, the .mirthless directory should be created at runtime, not install-time or it will break with multi-user systems.


On that topic, should we try to log things that we do like this? Something like `sudo apt install pass imagemagick golang-go closure1.6 | tee <log>`.


Will they work on MSVC? I know I had to do the opposite some time ago


Lets think of a away to specify protocol specific clients.
I plan to add more in the future.
Ssllabs only cares about https so only has typical https clients.
Java is also a non https capable client.


```word.toList().sort().join('')``` should suffice, or you could work with lists directly, instead of Strings


- Maybe add the benefits of using pods (vs downloading code, copy pasting, downloading libraries,etc...)

- It's short, but since it's just an installation guide (and not usage), its OK. :)


c'est mieux, il reste encore des zone noir mais c'est bien mieux :)


what's the difference between this and `text`?


Wow, that's great. Thanks.


Nice, I'll merge this over the weekend.


This causes the sort in the tooltip to flutter in stacked line graphs where multiple datasets have a 0 y-value for the same x-value.  It also triggers an unwanted sort in the legend when adding/removing datasets by clicking on them in the legend.  Please revert.


you could use an open range, instead of extracting one, e.g. `1..<10`


I'd suggest a name like `SwaggerConfigLocator` or something other than map, since this isn't a true map...  Nitpick, i know


"ensure" not "insure".


this can probably be a for loop instead


@dbleyenda aqui estaba mal el value, pero existia una default.


Yeah, the CSV was mainly for ease of use when I was manually entering data. I didn't back-update it after converting to GeoJSON


you should process it instantly, don't store it first


- Add that the first time you use cocoapods you have to run "pod setup" in terminal.

- Add that you can also call "pod update" when you want to update the pod versions.

- Add an example of a complete Podfile and explain the parts. (ios version, targets, etc...)

- Otherwise, good :+1:


`it`?


I think you agreed with my comment saying "It seems to me that if everyone is able to see real JIDs (non-anonymous) that unaffiliated users should be able to see them" but that the text doesn't match.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1166](http://teamcity.monogame.net/viewLog.html?buildId=13609&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


This should be called through the `before_filter` as we're only setting defaults based on a param. Its pretty confusing to have a method call in the middle of another method that sets ivars


I was teetering with the two, and ending up picking on at random :P


nice, but again, you can use `Lists` also, not just `Strings`.
But even for `Strings`, you don't need the `.toString()`


Good point-


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11680](https://teamcity.mesosphere.io/viewLog.html?buildId=105891&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:10:35


dependencyList and dependencyStats are nice additions. Thanks!


La url para obtener el branch correcto es:
pip install -e git+https://github.com/jfunez/packtools.git@html-generator-new#egg=packtools


Good job on optimizing it :) :+1:


Hi @mbeckerle, in this branch I have added client static files, koclient.js has been generated with _Browserify_.

The first commit (578d10334733bf2d3ef4c1a159a778ce4a0dd192) corresponds to the source code from 34f176404400c3d262fec03a23135761dee7e5b1, when the library rfc6902.js were being referenced as external script file in koclient.html.

The second commit (a8b76b511d16fea9cd8b7638f8ec1b32837c357a), this one, is after [replace rfc6902 reference by a reference to a Node package](https://github.com/andresmoschini/board-poc/commit/098237c125dfc3ba19108d35e6cc8c7f69d7998e#diff-15567d757b2e1b77b6990f39dafe4460R3) and corresponds to source code 098237c125dfc3ba19108d35e6cc8c7f69d7998e

As you can see, at the end, koclient.js includes rfc6902.js sources, in the same way than with my own modules like common/utils, common/model and view-model.

I hope that this brach be useful to you, if you are interested we can talk on Monday about it, I think that Browserify is great and will be useful for us in different scenarios, not only with _isomorphic_ applications.


Ok, great! How can we change the following as well?
* hashtag(s)
* time from .. to
* tweets from specific user(s)


Part of Issue #222


Nit: this (and two others below) can also be written `if !matches!(c, BidiClass::L | BidiClass::EN | …) {`


That value is put into the  the "buildModuleForMessageTest" class. https://github.com/ThisuraThejith/openmrs-core/blob/Fix-For-TRUNK-3920/web/src/test/java/org/openmrs/module/web/WebModuleUtilTest.java#L232
So it should be there as it is created in the "buildModuleForMessageTest" method. Therefore it should still exist. Please correct if I am wrong.


Sorry, I think I'm misreading this PR, aren't I? I'll see if I can work out what's going on.


Looks good.


I think this is very good.  The samples under swagger-samples should work as-is without any change with a locally-built snapshot.


+Drawing 1 ampere wouldn't be suitable for a usb1.1 port for example


There are some folks who run without a servlet context.  Is there any safeguard for these changes if the ServletConfig is not available?


bumping version to fix format issue in README on npmjs.org


Not sure how this got added


@Samana04 Added this - need you to review and proof and/or suggest a better structure


profesor,me dijeron que su oficina esta en docencia 3, me podria decir en
que parte exactamente :D

2016-01-14 18:03 GMT-06:00 Julio Cuellar <tsukiitou@gmail.com>:

> de Julio Cesar Perez Cuellar de 5B hahaaha :D
>
> 2016-01-14 17:43 GMT-06:00 ffranjavierutez <notifications@github.com>:
>
>> Mmm el commit me marca de esta cuenta o de quien es esta cuenta?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/ffranjavierutez/gitdesdeapps3/commit/6dc4550729347cc83c514c0644f7c76b024b3c83#commitcomment-15463966>
>> .
>>
>
>


Sorry for asking this silly question, Should the license be updated to 2011-2016 or should it remain as is ?


TeamCity pull requests :: netty [Build 1040](https://garage.netty.io/teamcity/viewLog.html?buildId=4792&buildTypeId=pulls_netty&guest=1) is now running


Can you update the comment on the method at least?

On Fri, Jan 15, 2016 at 12:35 PM, lodrion <notifications@github.com> wrote:

> actually changing it uncovered another problem. build_schema() should
> always be called with new declarative_node() and
> declarative_relationship(), because it does change the underlying
> registries.
>
> But its too late to change the interface
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kensho/pyorient/commit/78bceddc9e6216b1af11500b678fb11f8f877b38#commitcomment-15480004>
> .
>


fixed


If you could leave comments on the source code it would be useful in case obfuscation changes in a future version.


you're absolutely right, that simplifies a lot! i'll adapt


I have started with `FLAMBDA=false` because that's configure's default and I don't know what it does! Should the default for native Windows be `true`


@flowersw You can delete these two variables since they're unused


Submitted https://github.com/unicode-rs/unicode-normalization/pull/9, and filed https://github.com/servo/rust-url/issues/158 to use it.


@flowersw You could also use `this` instead of repeating the ID


func (p SynapseProxy) will copy p by value each time you call something on it. It also cannot ever implement any interfaces.
func (p *SynapseProxy) will copy p by reference, which is almost always the thing you want to do.


Doesn't seem to play ball with automation tools... thinking of an alternative/fresh start

as the last update to the readme, put's me right off.


pushed


You probably want a return in here


test comment


Is there a notion that each Data Center will be tracking things independently? Or is the CMS at each data center a replicated clone?


I think so, just wasn't sure if it's worth polluting the module for a one liner


Fine for now as is, thanks.


You can drop the Str suffix from the variable name, now that it doesn't conflict with a global


> We could talk about a tiny + / - button though, beside the select field instead of my radio fields,

Mock something up and we can talk about it. It is possible I missed a better solution. It is just the two contextless radio buttons that were unacceptable.

> This makes it unusable for direct decisions, since you now always have to go the way over the "sort" layer box, as far as I can see

It means "one click more". I don't see the problem. It is not a central navigation feature that has to be directly accessible.


This is false by default


Yes I now consider this bad design, fancy urls should have to be enabled to use permalink structure.
If you enter a permalink structure you cannot toggle its use on and off, you have to erase it, and if you have a fancy url structure entered, and toggle off fancy urls you might be confused whty its still using "fancy urls"


err.Error() can be replaced with just err


This flag doesn't exist in our gralloc but we probably need this feature


need to change config.yaml.example in doc repo also


normal comment


A colleague of mine and I worked on classifying a movie's genre based on the Wikipedia description, we seemed to get pretty decent results given we only trained the model out for perhaps a day at most on an old iMac. He had worked on a way to save / load trained models, believe he might still have the code - although I noticed that skflow now supports saving models.


line comment


The latest commit has been merged and will be included in 4.9 RC 5.


Hey @wingrunr21, based on the current project activity I decided to add this and point out to @nickcharlton's project. If you still want to continue hacking over here feel free to remove the section (I'd also recommend "joining forces" with @nickcharlton ;-)


Is this used anywhere? What's the the TODO?


I think you should change the method signature to not take a pointer argument, similar to your changes elsewhere.


Use the following link to have same results : https://www.youtube.com/user/csev/playlists