Please let the current log usage for easy debugging.


in-lineは、「その場」でという意味ですね。out of lineはその反対ですが、うまい訳語が見つかりませんん。


Gonna update to retrofit 2 at some point… will wait for that.


Rather just use one space before the comment instead of two tabs.


> Yes, sure. Well, I think you mean tokenParams == nil. I will change.

Yes, good spot :)  Keeping you on your toes


Note this was important, and overrides my prior 3 commits as the more intelligent version 10/10 Peyton you may not be executed for incompetence yet.


Vai mexer na lógica dos menus nem dá para perceber que é relativamente a dados móveis...


could always pad it out to 32bytes :P


la vie est trop belle pour que **DIEU** nous laisse mourir dans la souffrance et la pauvreté nous feront tout pour être **juste devant**sa face** Cas **DIEU EST DIEU** allons seulement**


Jovem,
É específico do Cancro, neste caso Android 6.
Não sei porque estás a alterar no resto.
Vou reverter este commit


Why?


@stsje we'll do some performance tuning on this in a future release to minimize array allocations and closures. Take a look at `ClassObserver` for more info.


1- naming rule : prefix is missing
2- we prefer static because:
- we only need 1 instance
- performance (only one creation)
- consistancy


这个？


人


** yannick** est nom


コンストラクタ内で例外を投げる可能性があるメソッドを呼ぶ場合は、
例外発生時にインスタンスが生成されず、デストラクタが呼ばれない可能性があるので注意してください。


unused variable


Damit ist gemeint dem Delay einen sprechenden Namen zu geben und ihn dann zu referenzieren, oder eben zu kommentieren.


`serialize.h` is also included by "logmsg-serialize.h"


semicolon


This does not seem to have propogated to the customised version via http://getbootstrap.com/customize/ as it still says 2015


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12800](https://teamcity.mesosphere.io/viewLog.html?buildId=113052&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:04:26


Don’t use string builder if optimization can be done by the compiler.
Android Studio raises a warning when StringBuilder can be replaced by ‘+’ concatenation.
Let do the compiler optimizes the code and finally it is more readable.


includes and defines copy-pasted somehow...


A typo here.


legacy


Using ngRoute
In AngularJS 1.2.0 and later, ngRoute has been moved to its own module. If you are getting this error after upgrading to 1.2.x or later, be sure that you've installed ngRoute.


please don't clobber return values on failure. See CODING_STYLE.


Coudl we use own Atomics?


I think so yes. I think a leading `/` forces the match to be rooted at the repo's root


reuse meaning: rely on what the previous run test let us hang on?


是不是放到layout的样式里面更好？


Pushed 0d9b726140b dealing with new extensions.


Such a big methods need a `AutoTrace` at least, May be a few debugs also)


there's extra `,` in here


hmmm... 26? could you create a static const int, or a define?


dito - depending on what the test listed before this one in main.pm does, we might run as root or user


menu seguinte:

<string name="data_usage_menu_roaming">Dados em roaming

menu anterior:

 <string name="data_enabled">Dados Móveis

Não difere do Android 6 mas sim da tradução...


"private final" since only set in constructor.


Here installer.upload() is doing nothing. You maybe wanted to call it with upper params which can be achieved for several ways:
```
.use((req, res, next) => {
 installer.upload(req, res, next)
}
```

or simply: `.use(installer.upload)`


Yes you're right. Seems to be a copy and paste error when moving the fixes from our production systems to my dev laptop.


目录和图表清单是不是应该加入目录中呢？
我看了一些似乎很少有这样做的。
不过加入PDF书签还是不错的


Why we need to sleep in thread?
Looks liek we need `CondWait` or could just do the stop logics right agter the stop/


Or, equivalent to the upper use (and following REST conventions) `.post(installer.upload, installer.process, installer.git)`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12801](https://teamcity.mesosphere.io/viewLog.html?buildId=113057&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:08:40


王胜飞


Note that log_error_errno() is happy both with negative and positive error codes, and will use abs() on them anyway. Hence the first argument really can be "r" here, no need to write "-r".


Shouldn't this whole command be replaced by `kubectl convert`?  A followup issue is ok.


In alloy-ui code variables should always be declared at the top of a function, so these two should be together with draggablesList.


yeah, I happened to notice this yesterday too and left this validation in favour of the latter - i tend to think it's good to bail out sooner rather than later, with less to go wrong. I've now also added a comment to clarify that read_properties_unlocked only does validation of properties in isolation, not validating that the combinations of properties necessarily make sense or validating that all required properties have been set. later _init_stream code is then responsible to inter-property validation.


This is just that you can place it @keithkfng


In the next rebase, we should do away with this package to be consistent with kube.

@pweil-, not sure who the victim is.


Also, please don't log from "library"-style code, except on LOG_DEBUG level... See CODING_STYLE.


OK, its time to shoot the engineer to get product out the door.
I'm not going to make any more changes other than editorial.


膜！


(yeah, we do this in the file at a couple of places, but we really shouldn't... )


Why we are asserting here?


This is a great start.  I assume you'll be breaking down the headings into sections for measurements, raw data, rollups and calculations etc. You may want to show pulling down measurements and working out the min, max and median in a list of values (that was noted in the previous feedback).


SF. I can test everything tonight. Feel free to merge if I don't. :)


The commit was done by me BTW


Looks liek we could construct `QVector` by the input value and then use `std::for_each` or Qt `foreach` with replacing the negative values (by the std unary operator of cause)


yeah, it doesn't matter in these cases


Move it to the constant at first.
May be move to ini file?


aaaa


sss


Yes, see EspHttpBinding::doAuth()


Unwanted tokens due to conflict resolution


I'm reasonably sure that this should be registered in reverse.  I don't think you have to updates that allow adding to the scheme in any order.


Please don't declare variables and call functions in one expression. See CODING_STYLE.


logs?


Yeah - I figured here it might be better to be verbose to make it more understandable. I could add these shortcuts to the `duckpan` reference though. Are those the only two or is there a code file where I can find them all?


Hey wondering how to send stagefright from an iphone, I would greatly appreciate you helping me with this if possible please?❤


Hi,

can I please ask you where the original version of this driver can be found?
Was searching codeaurora git but was not able to find it anywhere.

Thanks for help
Andi


I created separate classes, code looks cleaner now


great.  removed now.  is there anything else still pending?


On Tue, 2016-01-26 at 05:06 -0800, Stephan Kulow wrote:
> yeah, it doesn't matter in these case
>
>
>
>   >
>   >

>
>

>

right - some other tests explicitly stated this in the comment instead
of a 'reuse console' - but that's minor... LGTM


Is the order of elements in `Hash` _always_ guaranteed in Ruby? Hint: it's complicated.


Ок, i agree
 i am not good at c ))


Maybe use exists `Pimpl<Impl>` class here?


Could it just be handled by subtraction (vide line 28)?


I thought we generally just did things like:

```
call(:get, "#{path(id)}state_summary/")
````

Since the state_summary path isn't reused


The reason people are being snappy is this has been discussed countless times before (all the way back to BIP101). I'll do my best to answer the questions, but don't expect to change our minds:

> but what happens if 25% do not want the HF? How would a sudden security lost be avoidable?

Let's split people into three main groups:

1. Active supporters (will set the flag, willing to follow the fork).
2. Reluctant followers (will not set the flag, willing to follow the fork).
3. Opposition (will not set the flag, will not follow the fork).

The grace period is only meant to give people in group 2 the time necessary to upgrade their software. People in group 3, by definition, won't follow the fork.

So we have 3 options:

1. Allow a group that's outnumbered more than 3:1 to veto a network rules change.
2. Deliberately orphan that group's blocks as a way to reach the higher threshold.
3. Allow that group to continue on their branch, and coordinate the rest of us moving to new rules we prefer.

It seems to me that 3 is the best of a bunch of bad options.

To put the "security loss" in perspective, we're talking at most about a 25% hashrate drop. This is roughly equivalent to the hashpower increase we get in a month. More importantly that hardware isn't sitting idle (probably): it's either mining a minority branch that's >3 times easier to attack, or it's been sold back to people mining on the >2MB branch.

Your concerns would be justified if we were triggering a fork closer to the minimum 50%+1 threshold, but we're not.

If there's a specific reason for thinking the risk is very high at 75% (and significantly lowered even by a slightly increased ratio), let us know. Looking at the math for [attackers outrunning the main chain](https://bitcoin.org/bitcoin.pdf), doesn't seem to suggest than an inflection point exists there.
If there's a specific reason for wanting a 95% threshold (and not 94.2% or 96.3%), please let us know.


redundant include


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12802](https://teamcity.mesosphere.io/viewLog.html?buildId=113065&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:03:49


Would you consider a class with static (class) methods only good Object-Oriented design? How could you change the design to take advantage of Ruby object model? Hint: think of `RomanNumeral` being a subclass of something.


wrong commit message :(


setting field to null is redundant


`result.baseExpression?.let { findCallName(it) }` would be much shorter


Mostra me sff onde é que isso está


Are you familiar with rspec's `shared_context` and `shared_examples_for` calls? Would any of these be useful here?


So is the whole API compatible to php 5.4 or even 5.3?
"Officially", the lib requires 5.6? Does your change fixxes all interpreter-errors from lower versions?


I'll just leave this here: http://hastebin.com/ahewegigit.vhdl  :)


Подобную функциональность (общение с бд и сервером) начинай выносить в отдельные модули


What can be the downside of putting multiple expectations in a single test (`it`)?


I am not a lawyer but according to http://www.copyright.gov/circs/circ01.pdf (See screenshot of relevant section below), listing the first year of publication in the copyright is a good thing

![selection_008](https://cloud.githubusercontent.com/assets/829526/12409934/7021c3a6-be95-11e5-8d1a-18f6948571e0.png)

In case, you don't want to update the license year every new year, you can follow a notation like `2015-present` (used by libraries like React - https://github.com/facebook/react/blob/master/LICENSE )


`kapi.Kind("Node")`


Tu vérifies l'identité de l'item à supprimer ? Ou tu veux vérifier l'égalité ?
J'enlève une hache, ou j'enlève cette hache précise ?


Would `between?` here work?


Use constant


Teste De Capacidade


@talsraviv Agreed! There are a couple more options - `-l` (aka `--list-templates`) and `-N` (aka `--no-optionals`). Here's the complete list of options related to templates: https://github.com/duckduckgo/p5-app-duckpan/blob/5ab6674705e7abd0e9c8e745280223b9bb144951/lib/App/DuckPAN/Cmd/New.pm#L19-L44


You'll still have to use pointers in the vector.
During this 'for' loop a different thread can resize lostables which can move the table itself and invalidate your iteration.

your suggestion can remove 2-3 lines of code.


Is the assignment useful here?


use constant.  probably `ourapi.SchemeGroupVersion`


Thank you.


Dammit, this is the last commit for issue #1 and I forgot to mention it. Let's hope this is also referenced.


It seems to me that proper condition is USE(CF), but it would be better to check WinCairo build


Maybe uint?


`kapi` so it leaps out at me please.


Why not rename this method : selectComponentsFromProjectId ?


This change.  Why was it needed?  Were we failing to properly round-trip the kube subtypes before?


`api.SchemeGroupVersion`


Look at it tonight. Don't have access.


Waste of space :(


Please add word `lock` to variable name


`api.SchemeGroupVersion.WithKind(kind)`.

This all sounds picky for test code, but we want to be able to locate all our references. **Especially** since the next rebase will be wanting to default these groups.


could we name it LZF


Thanks, I removed the extra comma.


How are you sure received `argc` would be exactly 5?


Jovem,
não preciso mostrar nada basta veres a string em inglês e a lógica dos menus...


I think this code block breaks the guest view. If a guest want to download a PDF file that was not generated before he is sent back to the web view? Could you please take a look? :confused:


done


> api.SchemeGroupVersion.WithKind(kind).
>
> This all sounds picky for test code, but we want to be able to locate all our references. Especially since the next rebase will be wanting to default these groups.

@liggitt @soltysh @kargakis Since you're all likely victims.  @smarterclayton's scheme/codec changes in the next rebase will allow us to default a `Group` and split us from kube inside the code.


@Bogdan Line 58 SortedSet reproduces issue https://github.com/TCPR/KCauldron/issues/19 need to revert to Tree Set


In fact it would have been better to add the new query in ComponentDao, ResourceDao should not been used anymore (it should even be deprecated)


This was removed because it does not work reliably.  It throws lots of exceptions from deep within the web language services.


Já percebi.
Reverter tudo para onde estava.
Abraço


No this must NOT be in camel-core. Create a new external component camel-lzf and put the code in there. In camel-core we have the model of the dataformat. But the actual impl is outside. Only a few are in core because they use from JDK only.


Is is really useful ?
As project_uuid is only populated on projects components, this filter could be removed in my opinion


No, you don't: lostables being resized would not matter if you retrieve the element at index `li->radius` each iteration.


Done, pull request was updated


这个实现是合适的吗？


sphinx complaining here


And there's no index on PROJECTS.SCOPE


and here


Removed unused object and constants as suggested.


@ntustison Awesome.

I won't be able to test this again today. but it looks like you fixed most of the easy errors.


You misspelled you moron


I wanted to avoid Count in case an Id gets deleted during updates. If using count you will end up with duplicates. It is not guaranteed to not happen wth max, but less likely. But as I posted to the other repo. We probably should use a GUID if numeric else create a numeric hash.


Better use `Chef::Log`.


Use `shell_out!` to fail fast if the command fails?


In fact you could also have create one query to get all components from a project_uuid, an to get the project uuid you use a select by id => It's adding an additional query but these 2 queries can be elsewhere in the code.


Don't we need lock here?


Ah ok @kucharovic, so you're covering an edge case.. Good!


You think the overhead of GetAllRepositories is negligible?


@Robotia verification process


are you sure it doesn't construct an iterator and advances it?

doing a for loop on indices may work though.


Same question as with GetAllRepositories.


`buildapi.Resource("builds")`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12803](https://teamcity.mesosphere.io/viewLog.html?buildId=113075&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:03:44


For whatever reason I don't see ``SkipActivation`` being reported in d-feet.


Just "service"


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12804](https://teamcity.mesosphere.io/viewLog.html?buildId=113080&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:02


Thanks :)


Following the behavior of the legacy code, it ignores it


```project.properties``` can be named ```gradle.properties``` and be accessed by ```build.gradle``` without needing config loader code. Makes things cleaner.
```CoFH_at.cfg``` not needed at this time and needs to be fixed before it can be used anyway.


The abiquo-re-ease-ee package is not supposed to configure a nightly repo. Is this needed for anything else?


certainly so


why?


We should probably keep the `ToLowerInvariant`. That way I don't need to remember my username capitalization.


This was removed in a later commit, I'll see if I can patch the commit


constants


Change to `return if node['abiquo']['profile'].eql? "monitoring"`, to avoid having all the recipe nested inside this?


so the issues we have are with:

eebranch delay
some fpu (cba listing :P )
iop hilo delay
iop lsudelay
iop div
iop interrupt register (seems to reboot)
iop messagebox receive
iop messagebox send
iop thread stat

think IOP needs some work :P


Beautiful


Is this used anywhere outside of this scope? I hoped to insapsulate severity value to the filter


done


We should remove this class completely and use `TimerThread` for this purposes


Hmm, I don't like this syntax for body-less loops. Would prefer this:

```c
while (next_ehader(&b1))
        ;
```

Which I think makes it clearer that this is a loop without a body.


This will perform the update N times, one for each package. It's better to notify only for the server package or subscribe the liquibase update to it (or something similar that triggers it only once).


It appears that one function that I used doesn't exist on that platform. I know how to fix it so that call is not used but I don't have the time this morning to do it. I will post a fix later tonight for it.

- James

From: "Nikolay" <notifications@github.com>
To: "m oneymanagerex/moneymanagerex" <moneymanagerex@noreply.github.com>
Cc: "Webmail Siena123" <siena123@mstar.net>
Sent: Tuesday, January 26, 2016 4:43:07 AM
Subject: Re: [moneymanagerex] feat(622-Account.View): multiline select copy to clipboard (1266df2)

FYI #667
/home/dawid/Development/moneymanagerex/compile/bk-deps g++ -c -o mmex_mmcheckingpanel.o -I../lib/wxsqlite3/sqlite3/secure/src -I../lib/wxsqlite3/include -I../lib/lua/src -I../lib -I../3rd -I../3rd/LuaGlue/include -I../3rd/cgitemplate -I../3rd/csv-parser/include -I../src -DNOPCH -I/usr/lib/x86_64-linux-gnu/wx/include/gtk2-unicode-3.0 -I/usr/include/wx-3.0 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXGTK__ -pthread -fPIC -DPIC  -g -O2 -std=c++11 -g0 -O2 ../src/mmcheckingpanel.cpp
../src/mmcheckingpanel.cpp: In member function ‘void TransactionListCtrl::OnCopy(wxCommandEvent&)’:
../src/mmcheckingpanel.cpp:1352:52: error: ‘GetColumnsOrder’ was not declared in this scope
         const wxArrayInt columns = GetColumnsOrder();
                                                    ^
make: *** [mmex_mmcheckingpanel.o] Error 1

—
Reply to this email directly or view it on GitHub .


the point is to remove useless queries and you're suggesting to have two... what's wrong with you? think of the network roundtrip

in addition, it's been benchmarked that the request based on the projectUuid (ie. without the auto join) is slower because the join enforces the use of a more selective index


Pointer to a copy if you please.  Don't want to someone to make an "unrelated" change and destroy the original.


The average PC this year has around 4gb of memory, I don't think anybody is going to miss 32bytes.


You need to annotate the lifetime here.


Это полуночные копипасты с вашего кода. Я даже не вникал


oops


to make it more clear, do you claim the following will work?
for (const CLosTables::LosLine& line: instance.lostables[li->radius]) {
       instance.lostables.resize()
}


It looks good. Thanks Bridget! Please, take a look to the sphinx issues before merging :)
Thanks!
(feel free to pass it through someone else if it needs to be re-reviewed by a more senior person, or by Dave because it is docs?)


the fact there is no index matters only when the clause is used to select rows, here, it will be used to only filter rows out. A more selective index is used first.


If you change `re.match` to `re.search` it'll look anywhere in the line, and if you change the regex to `(?:^|\s)(\${1}.*\${1})(?:$|[\s!?.,])` I think it'd be less likely to flub LaTeX containing dollar symbols.

(I can't remember how to fork PRs. ._. )


Does that mean pcsx2 is already close to bit-correctness? I always thought it is miles away and everyone is actually more or less wondering/impressed how/that it still works.


Given that we have the same code here twice, maybe add a short function

```c
static const char *skip_header(const char *s) {
        while (next_header(&s))
                ;
        return s;
}
```


Для большинства случаев это не требуется по большому счёту. А передавать nestingLevel внутрь шаблонов конечно же можно


Could this make more sense into the `repository` recipe? Take into account that a run list that wants to upgrade Abiquo  will not include the default recipe but just the upgrade one.


@Jean85 I think, a good developer tool should warn about cases like this one. So, that's why yellow color.


This structure is wrong.  You need to make a decision based on the entire `GroupVersionKind`, otherwise duplicates in other groups will break this.


if this method should be renamed, it should be to `getWholeProjectScopeTreeForRootId`


Use mempcpy() please.


This could be a shell variable.


(Also I think you don't actually need the `{1}`s?)


Да уж ;-) У меня это полуночные портирования из https://github.com/bem/bh/blob/master/lib/bh.js#L817-L835


(int) cast looks wrong. Should be ptrdiff_t or so...


I implicitly assumed that the ranged-for translates to index lookup, but it probably doesn't because `std::vector` defines `begin`. You would need to write `for (unsigned int n = 0; n < instance.lostables[li->radius].size(); n++)` here.


This is borked because the interface for `Get` is broken.  `Kind` is insufficient.  Make a TODO, but we can't fix it yet.


> Is the issue that we don't want to modify global objects?

Yes, I think that's an issue. If I'm a developer including the Ably library then the last thing I want is Ably messing with the prototypes. It's just nasty IMO.


Combine these two lines into one?


This is borked because the interface for `Update` is broken. `Kind` is insufficient. Make a TODO, but we can't fix it yet.


exactly


Why a pointer?


Well this only checks a few ops to make sure the opcodes and such are giving correct results, we failed about 20-30% of those tests, although some you can't really account for, where they are purposefully using a number which is a NaN on x86 architecture, we clamp it to MIN/MAX so it isn't


Why do we still have this?  @kargakis weren't you replacing this upstream's implementation?


![Scrat fixes bugs](http://i.imgur.com/QdVD216.gif)


Note, we could easily overwrite the fpu parameter to check the test behavior.


Hold on, there should be another `NBTTagList`


Shouldn't this be a pointer to preserve the "no opinion" case?


I thought you're using the new property system (decorator) on master now.


I speculate – based on absolutely no evidence – that this caused #1775.


No opinion as compared to "any version of the legacy group".


very nice functional commit


Nice :)


I don't think that adding only one query to get the component from an id is costly. My point was a trade off between perf and code maintenance. But that was only a proposition.

I found getWholeProjectScopeTreeForRootId not very understandable. From my point of view, the goal of this query is to return all components from a project id => No need to speak about tree, root, etc.


Oh, I see, we have ability to load this from config. I'd better then made this like

```php
$minimumSeverity = Config::get()->minimum_severity;

\\... parsing CLI...

new MinimumSeverityFilter($minimumSeverity),
```

as it would be more obvious and minize side-effect which is used no more


Yes, we could. But this function is **windows-specific**  though placed in `Qt` branch and wasn't designed as crossplatform


I agree with the index, but I found this filter completely useless.


Closes #2.


Hello Swift from 🇨🇳


Makes usable #1.


Je sais plus trop à force... j'essaie déjà de rendre tout le reste fonctionnel. Mais je pense que ce sera cette hache précisément


We can drop it if we want, the fixes we needed are in upstream

https://github.com/openshift/origin/issues/5323


I would change this config. Ideally it would be similar to how the key config works with subdirectory inheritance and all of that nice stuff.


Is there any reason why we use
```
(cl-assert (featurep 'popup) nil "Popup package is not installed")
```
and not
```
 (or (require 'popup nil t) (error ...))
```
?


# Assignment 2 Grading Rubric (15 points total)

## Screenshots

- [ ] There are screenshots showing 3 valid ways to run the program (0.5 pt)

## Imports

- [ ] To the best of your knowledge, each of these explanations is correct (1.5 pts)
- [ ] This method of import is correctly selected as the best (0.5 pts)
- [ ] This explanation is correct and the example is good (0.5 pts)

## Paths

- [ ] This is a reasonable path to the Desktop (1 pts)
- [ ] This is a reasonable path to the `root` directory (1 pts)
- [ ] This is a correct explanation of the meaning of $PATH (1 pts)
- [ ] This is a correct explanation of the meaning of $PYTHONPATH (1 pts)

## Modules

- [ ] This paragraph explains the module well (3 pts)
- [ ] There are examples (3 pts)
- [ ] The examples aren't simply taken from the documentation (2 pts)


Always compare constant to variable and not reverse.


if you do not use err, just use _
rc, out, _


pass uses the `if ...; then` convention.


`%s` not `%v`?


What a great method signature.


It's not really a good idea to rename it. It's better to keep it as it and in the thelia's composer.json file add a `repositories` section which redefine where to look for the `propel/propel` package (in https://github.com/thelia/Propel2.git). As it it will be easier to maintain this fork.


> What a great method signature.

And there already *is* a value object??  Open an issue.


It filters out files, directories and technical projects. It's far from useless.


@malirod , Current commit is not commited by me. It's changes from PASA. It was needed to fix defect.


no @app since it is a local variable, its hould be app.


where? xd


No @app, it should be app


Missing static import of Arrays


It would be nice to have this method work for symmetric to change passwords or encryption algorithms. However that might be hard to do because symmetric encryption can have different passwords and can be changed to different passwords. Maybe there is a way to cache all entered passwords and only ask again if all previous passwords don't work. Also a way to cache the `to` password would be essentially required.

That can all be handled in a different change though. For now I would at least print a warning.


I can further improve the examples using `case classes` in the Scala example. Doing it while retaining the usage of inheritance would involve making a `trait` for both the `Point` and `Centroid` to inherit from.


This should be configurable. Probably configuring it though the `.gpg-id` system that I am recommending would be best.


@soltysh - this is what happens when you volunteer to do 2


Just a style issue: we can use [] instead of .at() for consistency with our other code


Hmm, this get is actually unnecessary.. we can just use it->value() (we are already iterating over these keys)


This needs to support both methods.

I don't know if it supports the old way now but not at least printing a warning sounds dangerous.


Remove?


I squashed in a couple of extra deps that were missing from CMakeLists.txt


Oh, that's much neater.


This package is no more available on Debian:8.1, this breaks the docker build.
The apt-get --force-yes option doesn't work


I'm missing ``4.`` here.


For the block device we do not allow short reads--if you ask for N bytes you always get N bytes (or an error).  This simplifies all of the calling code...


... so for all of these we should assert r == 0, not the length


`halfRow == -1` is more clear


I'm not opposed to the idea but I don't really have any say. The changes might be rejected due to maintenance burden even if they are well made. I would try to get confirmation of interest before sinking too much time into it.

Also this change will need a lot of tests if it is going to get accepted. It is changing a quite fundamental part of pass.


I saw that upstream too but it wasn't clear if KF5Solid was really used or not. It's no issue though.


ok thank you


# Assignment 2 Grading Rubric (15 points total)

## Screenshots

- [ ] There are screenshots showing 3 valid ways to run the program (0.5 pt)

## Imports

- [ ] To the best of your knowledge, each of these explanations is correct (1.5 pts)
- [ ] This method of import is correctly selected as the best (0.5 pts)
- [ ] This explanation is correct and the example is good (0.5 pts)

## Paths

- [ ] This is a reasonable path to the Desktop (1 pts)
- [ ] This is a reasonable path to the `root` directory (1 pts)
- [ ] This is a correct explanation of the meaning of $PATH (1 pts)
- [ ] This is a correct explanation of the meaning of $PYTHONPATH (1 pts)

## Modules

- [ ] This paragraph explains the module well (3 pts)
- [ ] There are examples (3 pts)
- [ ] The examples aren't simply taken from the documentation (2 pts)


So you're only returning PROJECT components ? Why are you filtering out files, directories and others ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12805](https://teamcity.mesosphere.io/viewLog.html?buildId=113083&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:06


LGTM :+1:  (LGTM: means Looks Good To Me)


We can probably re-formulate this a bit: "Can detect if STS plugin is installed in Eclipse"


LGTM :+1:


Another update: I've been able to strip all custom props from the dump file, BUT sanitizing paths in `svn:mergeinfo` appears to be quite a challenge. Maybe I could splice some code to do that in `svndumptool` but this will take uncertain amount of time.


For whatever reason the changes here aren't highlighted.
The changed are:
- periaattessa -> periaatteessa
- sisällöltän -> sisällöltään


Excuse me but why are you copying each one of our commits into single files?


"If the user does not check the option, then the dialog will continue to be rendered upon startup".


Ok, now I understand -> The goal is to only return modules...


Does this mean that the user can directly click on the link in the dialog and a browser will be opened?


The change was (since it wasn't highlighted for whatever reason):

- kontorollerimme -> kontrollerimme


@JustAkan kernel.org 에서도 새로운 커밋이 안올라고..
https://git.kernel.org/cgit/linux/kernel/git/geoff/kexec-tools.git/

Tasssadar 님의 활동을 봐도 arm64 관련 커밋이 없는 걸 보니 아직 힘들어 보입니다.
https://github.com/Tasssadar?tab=activity


using System.IO;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
namespace program
{
class name
{
    static void Main(string[] args)
    {
    string x;
    Console.WriteLine("enter your name:");
    x=Console.ReadLine();
    Console.WriteLine("My name is {0}",x);
    Console.ReadLine();
}
}
}


@bradymiller let me know what we have to do with gacl


Why dont you EVER give proper authorship credit???


that change is useless


So indeed the name I've proposed you is not good. It could be selectModulesFromProjectId().
I hope we will be able to remove this module thing in the purge, and do the purge by project and no more by module, because it's misleading (I remember we've talked about that, but I've already forgotten).


this change is not wanted


some vi leftover ? :)


Why not use the actual types?
    short zoom = [components[0] shortValue];
    uint32_t x = [components[1] unsignedIntValue];
    uint32_t y = [components[2] unsignedIntValue];


use correct constant.


@AGritsevich you shouldn't change components stopping sequence within your task. Please restore it to avoid regression.


this resolves an issue where in VR stereo view on iOS, min-height css results in the canvas becoming larger than the display area.


В соответствии с названием .psd макета, или исходя из логики того, что страница отображает, если эту логику удаётся проследить.


Reviewed. Please merge


cuz those are methods on `NSNumber` while the components are strings


Strings are fine here for now, but please use constants.


Понятно) Но тем не менее. Вёрстка - гибкая штука ))


s/NSUserDefault/NSFileManager/


I get the not give ..be still nope


> "all components from a project id"

This query works (and it should) for views, developers and projects (as per the UI definition of this word). This description is incorrect and misleading.

Here, we get all rows in table project which root has the specified id and which scope is project, hence the notion of tree and root, which represent describe the data structure and not the data.
This query doesn't care about the data. It looks only at information about the data structure stored in the DB and retrieves data from there. The only contract about data this query enforces is the scope.


The super() in this case is not necessary


# Assignment 2 Grading Rubric (15 points total)

## Screenshots

- [ ] There are screenshots showing 3 valid ways to run the program (0.5 pt)

## Imports

- [ ] To the best of your knowledge, each of these explanations is correct (1.5 pts)
- [ ] This method of import is correctly selected as the best (0.5 pts)
- [ ] This explanation is correct and the example is good (0.5 pts)

## Paths

- [ ] This is a reasonable path to the Desktop (1 pts)
- [ ] This is a reasonable path to the `root` directory (1 pts)
- [ ] This is a correct explanation of the meaning of $PATH (1 pts)
- [ ] This is a correct explanation of the meaning of $PYTHONPATH (1 pts)

## Modules

- [ ] This paragraph explains the module well (3 pts)
- [ ] There are examples (3 pts)
- [ ] The examples aren't simply taken from the documentation (2 pts)


我也想学 js 了


`<<<<<<<<` or `>>>>>>>` mean, there is a conflict @marceladel


feature


How about using `NSFileWrapper` instead of rolling your own?


I get the not give..be still nope


You can delete Exercise2.1 folder as you have your updated code in Exercise2 folder, after you do this I will merge your code


> The PHP programmers'

Only if you consider "programmers" to be plural in this case. I read it as singular, as in "You're a programmer, util.php is your new best friend." I guess that's really up to @brandonwamboldt. :shrug


*feature


looks good.


Замечание по разметке: лишний обёрточный див. Дополнительного семантического смысла, в отличие от <nav>  не несёт, и больше никаких функций не выполняет. Вместо этого просто ul.main-navigation.


Can you also add a random spawner just as the ones for winter and summer trees by MaxEd?


Nice, big improvement :thumb:


I'm with @yan12125 we should reproduce the behaviour of the webpage player. If that part of the code is only reached for geoblocked videos, I would prefer to error and suggest to run `youtube-dl {id}` or at least show some warning (`Video is geoblocked, trying with the YouTube video <...>`).


feature && Editor::Instance()...


Замечание по единообразию: исправь пожалуйста и этот список тоже, чтобы выглядело единообразно, <li><a> на одной строке.


Leaving a comment on a commit!


Makes sense, but still, isn't intValue better because integerValue is designed for NSInteger (which is 32/66 bytes, whereas int is 32)


Could you please add a note on how is `id` related to `operationName`?


what about `getWholeTreeForRootId` and move the scope value to a parameter.

There won't be any use of this query with a scope other than "PRJ" but the name of the method on the mapper is simpler and we understand there is a restriction on the scope (mandatory) thanks to the parameter.


For consistency, the best name for the algorithm would be "FFTWC"


:clap: keep that shit clean


Просто ```return frm()->DeleteBmCategory(index);```


こまかいことですが。。


> Ok, now I understand -> The goal is to only return modules...

still wrong, it also returns projects, views and developers (ie. the root itself) as well as subviews and technical projects for developers


`auto it`?

Rest LGTM


Change class name to "FFTWComplex"


Здесь не хватает каких-то обёрток.
И названия first-img и second-img мягко говоря - не очень говорящие.

Я бы сделал или так:
figure>img.gallery-photo-big
ul.gallery-previews > img.gallery-photo-small*3

Или, например, вот так:
img.gallery-photo-big
ul.gallery-previews-list > img.gallery-photo-small*3


> I would prefer to error and suggest to run youtube-dl {id} or at least show some warning (Video is geoblocked, trying with the YouTube video <...>).

ok i will report a warning if the extract from youtube only if it's geo restricted.


Не хватает отступа, и этот блок находится в html дальше, после блока который у тебя .stockroom называется


oops


Sounds good. :+1:  I :heart: it. Merge it.


There is quite a bit of conflict of the helper classes in each block with the core helper classes at the end. Maybe just have the helper classes all at the end under core classes and nowhere else


JNI_TRUE/JNI_FALSE обычно можно опустить.


The problem is that the change was incomplete :S  The other test in here should have been updated to not specify level either.  I'll take care of that now.


I am assuming we are verifying these things manually or do we have some sort of functional testing infrastructure in place? Should spell it out how we test it.


"indicated"なので「指定」は変ですね。
「（表などに）示された組み込みのデフォルト値」と解釈するのが自然だと思うのですが、このページにも、直前に参照している環境変数のリンクのページにも、組み込みのデフォルト値など何も書いてないですねぇ…
サラッと"indicated"を無視する（訳出しない）のが自然な日本語のような気がしてきました。


.bay -> .buy  лучше если английские слова будут правильными. Используй гугл транслэйт, если не уверен.


Chris' comment is fine with me.   I was on skeptical on the custom blink rate too.  You still need to fix the method names to be what they are named in old led controller


Наверное, есть смысл закэшировать этот список.


This would only work if Google has already loaded - it has the potential to create a race condition making your code sometimes work & sometimes fail.


You can use here ``super()._set_target_size(newsize)`` but it's not required of course.


@ophian I disagree with moving { to a newline after function declarations, I believe our PEAR coding guidelines should actually have that on the same line, and most of our code should do so. Please don't change it.


Yeah, this is designed incorrectly.  Like the other issue, this is only a partial fix.  Clearly my cherry-picking skills were poor last night.


Add more logs please


legacy?


Debug?


Thank you for the quick response.


@Psithief Are you on ubuntu and did you use that dependency to compile? If not, this wouldn't cause it.


debug


I think it should be an external web page as long as we have control over it and can change it at any time. Maybe GitHub pages on the Buildship repo would be good enough for the beginning.


@arcturial @evansolomon : this breaks ability to stream files. for example, this example does not work any more:

```javascript
api.sendPhoto({ chat_id: 1, photo: fs.createReadStream(__dirname + '/test.jpg') }, function (err, message) {
    if (err) throw err;
    console.log(message);
});
```


This structure is wrong. You need to make a decision based on the entire GroupVersionKind, otherwise duplicates in other groups will break this.


all are debugs or info


First thing, we do not use anymore 'get', but 'select' to understand that it's a query.
The notion of tree was never used before so it will be a different name from elsewhere.
I just remember that for all components of scope PRJ (modules, sub view), we've in the past decided to take about 'sub project'.
See ComponentDao for some exemple (but all names there are not good).


I see. So something like https://github.com/z-brooks/binding/blob/master/src/element-observation.js#L50 is preferred?


`return`?


I'm reasonably sure that this should be registered in reverse. I don't think you have to updates that allow adding to the scheme in any order.


I'd prefer ```Items``` instead of ```@Items``` ... e.g. for mocking in tests which are btw missing.


Doh!  Nice catch.


直接叫lk_log就行，另外其实这个函数用不着实现，我会在loki.h核心里实现的，然后核心就可以打日志了= =


In that case we can probably just remove it from the spec.


I've never needed to use `NSFileWrapper`, didn't know it existed. So far, I've not needed to deal with writing, it's worth looking at when we need that.


What is this logic for?


You should do a 'right click' on 'java' folder under 'androidTest' and **select the option 'Create 'All Tests' first**

Then you can see next to the green play button 'All Tests' and launch all tests under androidTest... Well this is on Android Studio, I'm not pretty sure how appears on intelliJ

Let me know if you could run it in that way.


Why was this change needed? Were we failing to properly round-trip the kube subtypes before?


Cannot flush


Pointer to a copy if you please. Don't want to someone to make an "unrelated" change and destroy the original.


`AtomicInt`?


Probably a good idea.


Could you please add a note here or somewhere else that `name` is set in `standalone.xml` ? Does this hold for all `Name`s? Note that the class `org.hawkular.agent.monitor.inventory.Name` is missing any meaningful JavaDoc.


I think it would be great to have direct links in the documentation that point to the relevant STS plugin documentation so people can cross-reference.


Why a pointer?


redundant set to `null`


Missing Chromagram, and tests.

In fact, the algorithms will only work when FFTW is present in the system. If Essentia is compiled without FFTW, the should be ignored in build scripts.

Append ConstantQ, Chromagram, and FFTWComplex to ALGOIGNORE similarly how it is done for FFTW:
https://github.com/dimastro/essentia/blob/master/src/wscript#L156


The session does not exist any more. Why not executing "onDataFlushed(ContactId contact)" then ?


move constants to the own file (possible to `ini`)


Shouldn't this be a pointer to preserve the "no opinion" case?  No opinion as compared to "any version of the legacy group".


Yeah we could put clamping to "none" to resolve that, the other bugs still exist though.


somehow I knew I would get bit by this one :)


Forgot about that one ;-) Thanks!


no pushear archivos de config


what about using ```IsCurrentConfigured```?


also set the other fields


No stringbuilder for log: already optimaized by compiler and better for readability.


@ThomasBurleson, according to http://caniuse.com/#search=calc IE11 is reported not to support calc inside of a flex.


Strings are fine here for now, but please use constants.


No problem ;-) These days I'm focused on this, I see Asciidoc everywhere :-D


Thanks!


constant


Already fixed.


Полученное достижение будет выше, чем фрейм ошибок. Актуально, если включен автоскриншот достижений.
Надо ещё вычислить название фрейма прогресса квестов, чтобы тоже понизить, ибо http://i.imgur.com/jbYBQaR.jpg смотрится некрасиво.


Yes you're right, it's a better solution.
Thanks.


TeamCity Civic Assembly :: Build all [Build 28](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=457&buildTypeId=CivicAssembly_BuildAll&guest=1) is now running


Should this be localizable? (Also, I think it's better to put "Cannot" than "Could not" in error messages)


This is wrong.  There's no reason to believe that the versions will match.  What we actually want is the correct version of the `unversioned` group.  Add some comments around this and hard code it to the latest unversioned version.  We can't untangle it until after the next rebase.


ok


constant please


As a general note ```comited``` is never used key


I don't see the purpose of this method. Flush requests are serialized at the API server level. No risk of concurrency...


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26489/testReport/) for this commit**


I miss at least basic unit tests for ```Rollback``` method ...


I prefer this check:

```
if (typeof module !== "undefined" && typeof exports !== "undefined" && module.exports === exports) {
```


Is this tested properly. I'm thinking if removing the exception before and doing this wouldn't cause error when other partitions types will be resized.


Now you also removed the error message.


This appears as a separate commit in the PR? I would have thought that this would get merged into the original commit.


I like this. Great refactor.


It might be worth setting this up to build on CI, or maybe fix to a certain container version?


done


You're right for "get" but "subproject" I don't understand.

We lack a terminology to describe the data functionally correctly and we keep going in this direction when there is no solution there. At the end of the day, table PROJECTS stores trees of components. And we have a correct (for once) way to describe the components this query should return : the scope.

Let's get someone else into the discussion: @simonbrandhof, WDYT?
(I can also summon @eric-duquesnoy)


We should not log too much events. It is already logged at the API server level.


Maybe we should add another algorithm FFTKComplex to support KissFFT too:
src/3rdparty/kiss_fft130/tools/kiss_fftnd.c


Watch these tabs please!


Please do remember to `makersinit` your new stuff :D


You can use backticks to make a code block :wink:


Watch these tabs please


Avoid type checking. This is not necessary as you can constrain input instead of constraining logic.


Ohne der 2 Leerzeichen bricht meines Wissens nach die Zeile am Ende nach dem Rendern nicht um :)


For `'stormy'`, prefer symbols over strings.


给craft大大跪了。。。我这么多年中文白学了。。。


What about if airport starts with a number of planes greater than capacity?


I have hardened the getTotalAmount() code against NPEs.
Awaiting review and closing.


@liewegas  And I found another fix just now while I am looking for an example of decoding meta. LOL:-)


Yes absolutely - avoid adjusting your code just to pass tests. That's a big red flag.


This edge case is probably not required. Although it's a possible error, you can constrain your user input instead.


:( :( :( but you can refactor as you go along! R-G-*refactor*


:clap: aeeeeeeeee


Leerzeichen ebenfalls on purpose.


Why the '..' at the end?  Is from a file instead of a directory?


lgtm


I like `--format documentation` in here as well ;)


新版 savaAs 接口允许传 null / 空字符 format 了吗？


Is this a compiler bug? I think expression in trailing return type is evaluated as if within the function body. No?


I would put this in a code block (use three backticks)


Agreed, will pull from the project releases instead of master


Ah, I thought we stored the title and the id here.


Bist du dir da sicher?
Bei einer Rigid-Body Simulation, müsste man die Ausfallswinkel alle selbst berechnen, daher wäre das doch nur unnötig viel Aufwand oder?


Now the hashes update on scroll in addition to clicking the menu items.

Tested on Chrome 47.0.2526.111 & Firefox 43.0.4 with OS X 10.11.1

Note: Chrome CORS policy requires the file to be viewed through a web server before allowing URL modification in this way. I tested chrome by running python -m SimpleHTTPServer in the ./examples directory.


Nice idea to have these in a separate file. In a real project you would put these on a tracker of some sort (like Trello or Waffle: feel free to look them up)


Can you update the version and push this module to npm?


because the method renders a service only if the corresponding session is not terminated


有道理


StringBuilder can be replaced with string


it is different from java-8/integration_tests.sh ? if not, maybe we could make a symbolic link instead ?


Please eliminá del review los archivos de configuracion de eclipse .classpath .settings/* .project, etc. Fijate de agregar un .gitignore para que te los ignore al momento de hacer el add en git. Hay tantas lineas en el pull request que no me deja hacer comments en las clases.


Well, I am not sure if it is make sense, I am not very familiar with the buffer/list working logic.


Ah, in `src/smm/Makefile.am` you have `-version-info @OPENSC_LT_CURRENT@:@OPENSC_LT_REVISION@:@OPENSC_LT_AGE@`, which for itself is a misnomer. This should get its own LT version. And then you may change the value for `DEFAULT_SM_MODULE` accordingly


Ah, I see. Thanks for the fix :)


je suis probablement trop tard mais le enable-background aussi est inutile :D


@deads2k I am sorry for my prior formatting transgressions


Думаю что ```MainActivity``` не должен заниматься чтением файлов.


Use String concatenation here.


TeamCity Civic Assembly :: Build all [Build 28](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=457&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new); exit code 1 Build time: 00:14:03


I'd suggest to keep it as HashMap while you are populating it.
```
private Map<String, String> prefixMap = new HashMap<>();
```
On large XML this could be a huge performance issue as it's resorting on each _put()_. Once map is fully populated in the loop around line 312, then you can do a one time sort:
```
prefixMap = new TreeMap<>(prefixMap);
```


Anzahl der Möglichkeiten sollte dann auch noch angepasst werden :)


OK here to concat because String.concat is more performant than String '+' operation


@kevincox thanks for reviewing and for the comments.

I am not finished with implementing it yet. Let me also try the method of using the presence of `.gpg-id` file to figure out automatically which encryption method to use.

If people (including the maintainers) are not conviced on the usefulness of this change, there is also the option of forking and making a simple-password-store which does not have the advanced feature. So, I am not that much worried about spending time with it.


We should add this line to the `CuppaRunner` in `cuppa-junit`.


A small thing, but when I implemented react-router for manage-users I got a URL like: "manage-users/#/users." This creates one like: "dynamicoverview#/presentation-types."


I don't now if it's a good idea, it may be broken by a modification in the Java-8 version.
For example, if we add some integration tests on JMAP, we will have to give a JAMES_JMAP_PORT.
Then the integration tests on Java-6, as JMAP server will not be available.


Uhm... for the random spawner I am not sure because we have 3 normal trees + 2 special ones (wall), but I can add it with no problems anyway.


这是在做什么？


Nice. I'd like to use this.


Hi,

Your fix will for the majority of people, but in my case this is not enough.

I'm using token plugin and the content may change.

Here's my solution.

I also added external plugins support. Feel free to use it if you find it useful.

The syntax is:
ckeditor options
    'extraPlugins' => 'autocorrect,imagebrowser,token',
'ckeditor_external_plugins' => array(
							array('name'=>'token', 'folder' => '/js/plugins/token/', 'filename' => 'plugin.js'))

Also,

I add an issue when using it with twb-bundle. Both are extending FormElement and yours is bypassing the other.

My solution is disabling yours in module_config and add these lines in my form

$viewRender = $this->getServiceLocator()->getServiceLocator()->get('ViewRenderer');
$viewRender->plugin('form_element')->addType('ckeditor', 'formckeditor');

I'm sure there are a better solution, but I'm not an expert of ZF2.

Thanks very much.

[FormCKEditor.zip](https://github.com/Satsume/CKEditorModule/files/105012/FormCKEditor.zip)


Уберу, я только названи метода менял


wtf is this?


Done!


ok


done


Missed some --- for the subject text.


Se agregó ToString()


Since the size is unsigned, then you should compare with `0u`. But since data is empty, I propose to check `empty` instead. Check all occurrences,


Please correct all the text format for all the subjects.


@rubys We have to install `libgmp3-dev` package on server to resolve errors present here -  http://intertwingly.net/projects/AWDwR4/checkdepot/makedepot.log


this is practice


Well, what would be the meaning of such a version attribute? Wouldn't
```
name = "hello-1.10";
version = "1.10";
```
denote a package named `hello-1.10` with version `1.10` (i.e. `hello-1.10-1.10`)? Since that's the case, we *can't* just have `nix-env` start giving meaning to the `version` attribute.

It's more likely that we'll end up with some new function for defining packages, e.g. `package` instead of `derivation`, where we can clean these things up all we want. E.g.
```
package {
  name = "hello"; # Note: *not* "hello-${version}"
  version = "1.10";
}
```
However, that would still require updating expressions so it's premature to do it now.


also added table variable to ParsePromotion


Вообще сделаю список вместо массива.


.breadcrumbs а не .map-navigation
в specification.md написано что активный элемент меню и хлебных корок - должен быть без ссылок
И сделай чуть более единообразно, если ты в .main-navigation Делал li и a на одной строке, без переносов, то и тут тоже.


Hi @golgauth ,

I just noticed this line produces "File not found" error message, when running the startMZmine script on Windows 7 64-bit. Can you please check it?


open


For future reference, to get auto-highlighting to work without `code-block`, you can use `...` syntax:
```
class ParentPlugin(CMSPlugin):
    # comment
    ...
```


这样的话启动脚本也要改，会变麻烦的


Done. removed the trace in the class MultimediaMessagingSessionImpl


Done


По какой логике ты решил назвать этот блок - .catalog ? вроде бы на этой странице - один элемент каталога, так что это мог бы быть .catalog-item, или .catalog-element или .product.  А каталог - это скорее название для чего-то на странице, которая у нас называется shop.html
Ну и когда переименуешь - подумай оставить ли тебе имена дочерних классов, или что-то нужно будет переименовать вслед за родителем?


:sob:


Nice :)


官方文档没有规定，理论上怎样都行。我个人倾向于图目录。


Latest version is [alpha11](https://github.com/composer/composer/releases).


@tenphi this is only fork so i would sugest you to use main repo https://github.com/hiebj/ng-focus-if
This change has already been merged https://github.com/hiebj/ng-focus-if/blob/master/focusIf.js#L7


wrong style


It doesn't look like you added the validation for a single root division, something like `validates :parent, presence: true, if: -> { Division.root.present? }` should ensure exactly one root division is present.


1.26 update


Yes, its another compiler bug :P


只加到书签里就好，没有必要加到目录里。


wow that was quick :)  PR please!


.consist это какой-то глагол, а тут бы лучше было существительное какое-то, например .details вполне подошло бы, или там .родительскийкласс-details
Вообще глаголы лучше использовать для именования классов, связанных с какими-то действиями.
Но это уже куда-то в сторону javascript и всяких активных элементов.
А для объектов страницы - обычно существительные.


Fixed this by fixing the interface.  Please check latest code.


в тайтле должно быть написано о чём эта страница а это у нас каталог товаров, или типо того.


Won't Sonata\MediaBundle\Provider\MediaProviderInterface also need to be updated?


Yes. all this "concat" have but added in the past by someone. But I can redo as it it initially.


In this case you need to pass p to decode instead of bl...


Активный элемент меню - без ссылки, так указано в тех-задании specification.md


Отступы поломались


Thanks! :)


Скинул в скайп ссылку на обновлённый макет, посмотри его плиз, и добавь сюда несколько радиокнопок


no clue. running the generate step doesn't seem to get rid of it ...


This code doesn't run. Can you please check?


explicit is totally redundant. The style of the args is wrong.


Отступы починились))) Видно ты целиком предыдущий кусок скопировал откуда-то...


[`TemporaryFile`](https://docs.python.org/2/library/tempfile.html#tempfile.TemporaryFile) gets deleted when is closed, so it just needs to be closed. On Unix doesn't look like it even creates the actual file.


This needs to be clarified more.
It is backwards incompatible change that will break apps using request headers that contain underscores.
Warn about it and link to the workaround blog post https://blog.phusion.nl/2015/12/07/cve-2015-7519/


Resolved #3


remove it


You might want to note that this is a description of Tor's not-yet-deployed (and only partially implemented) [Next-Generation Hidden Services](https://gitweb.torproject.org/torspec.git/tree/proposals/224-rend-spec-ng.txt).


Too much parenthesis


done


ok


Читабельность нарушена: лучше делать после открывающего <p> и перед закрывающим </p> переносы, если текст многострочный. (вспомни пример с поиском времени работы барбершопа в пятницу, из вебинара)


test


You could standardize the uses of `os.system` to `process.run` in this file on a future patch :)


Thanks! Much appreciated!


It's from another module name:

_relativeModuleName('foo/baz', from: 'foo/bar') == './baz'

(using dirname instead of concatenating /.. might have read better :-S)


В specification.md много интересной информации об этом блоке. Посмотри и сделай в соответствии.


We don't need Pimpl here since the class is not copyable due to macro in the private section.


Please add 'capacity' as parameter, i.e. LRU(capacity), because each cache has it own limited capacity


I believe all the Redhat/Cent/Fed distros support upstart it would be nice if we just needed one service script.


> @deads2k I am sorry for my prior formatting transgressions

Damn right!


shouldn't this be actually wrapped by the `if` above?

When no 'mavendir' property is defined in project, I recieve the error: 'Could not find property 'mavendir' on root project.'


paint is qdel'd in ChangeTurf


From the looks of it, the following seems to be the issue:

`data.value && data.options`

I will work on a PR to get this sorted as soon as possible.


Тут будет ещё что-то, для обработки варианта, когда кнопка Купить уже была нажата, и товар уже в корзине.


Nice. I'd like to use this component.


change the function name 'insert' as 'set' (for simplicity & consistency)


@marcinwyszynski You're right, I could have made RomanNumeral a subclass of Fixnum and make roman_representation an instance method, this would automatically handle part of validation for me - I guess opening a Ruby core class is not the first thing that comes to mind :)


typo =)


Кавычки не такие как в макете. Должны быть такие же. Их можно прямо оттуда скопировать. Или погуглить словосочетание alt-codes


Isn't it since Ruby 1.9?


Ссылки на активном элементе нет. Class =  лучше использовать стандартное слово .active или .selected. Но для страницы это скорее .active


As we've split this script into multiple ones for threading purposes I'm unfortunately unable to provide a PR to this.

You might have a look into the results here: https://github.com/uni-halle/ownCloud/tree/master/local-decryption


LGTM :+1:


done


thanks Chris!


Can we get rid of |message| parameter as well? We never pass any message to usage. We always call it as usage(0).


唔，官方wiki里推荐使用这种方法配置JSON文件，升级的时候比较方便qwq
2016年1月26日 23:37，"Mike Lei" <notifications@github.com>写道：

> 这样的话启动脚本也要改，会变麻烦的
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mikelei8291/shadowsocks-rss-onekey/commit/d57e6b4f63f61e9a65f4c7ef15856acc9f789923#commitcomment-15678355>
> .
>


@garvinhicking ;-) I knew you were coming up with that...
Its not doing so with function declarations! Its now doing this with all class methods **only**!
And this, while it was all over differently used.
At this time I had to decide which one to take. And I found two reasons to do so:
 1. It was done by the extended plugin_api methods already in a lot of plugins, which I felt to be the majority,
 2.  and in some cases this was much better readable with the follow-up line.

This has been bothering me a long time, consistent wise. **Please** think about it a while....

Beside that PSR Standards tell us to
 * Opening braces for classes MUST go on the next line, and closing braces MUST go on the next line after the body.
 * Opening braces for methods MUST go on the next line, and closing braces MUST go on the next line after the body.

In my experience PEAR is sort of dying and not really used in current projects any more. They themselves say: `The PEAR Coding Standards apply to code that is part of the official PEAR distribution.`
And if you go through this http://www.sourceformat.com/coding-standard-php-pear.htm, I cannot see it requires this approch for classes and methods; it use the linebreak for them too (in the example).


LGTM.


I failed to catch these paths as well.  They are hard coded to Debian only.
A pull request will follow.


:+1: done.


Should we add a checkstyle rule to not allow `junit.framework` imports?


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 229](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=717&buildTypeId=XbimEssentials_XbimEssentials) is now running


remove the main method. LRU should be a class used by another class. You should another class for testing this class.


Double quotes are only needed to run sed command locally on your Mac


Why do you need it?


Ты зачем в мастер ветку пушишь?


Wut
Please learn cherry-picking instead of manually updating files
There are a lot of guides on how to use git


via GIPHY


Why this change? Do you want to support IE8?


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 229](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=717&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:54


.info.housing .info.food .info.souvenirs   - это хорошо, теперь можно по классу .info задать все однотипные параметры для этих блоков, а по второму классу - задать картиночки.


I'm not sure I know what solution you have in mind - I needed the ratio to get the partial_numeral


tu voudrait que je t'aide ? j'ai le temps ^^ je sais juste pas comment marche nsight, je m'en sert mais je vois pas ou esque ca devrait m'afficher les probleme a debuger ^^


Ok, Im liking the start. One thing I would like to change is i would rather reference stocks for backtracking using its sid instead of its handle.


Note: This is only a **quickfix**!


TeamCity Civic Assembly :: Build backend + frontend [Build 28](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=469&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


Hi,
This file haven’t in the commit and templatetags. Where does it come from?  I am interested in this feature, it’s a good idea.
Thanks


Yhm, with a min value set to 1 it would


C++11 setting looks good


В общем-то в медиа блоке классы лефт и райт особо не нужны будут, т.к. ты всё равно задашь обоим некую ширину, в результате чего они встанут друг за другом в том порядке, в котором они в html коде идут


TeamCity Civic Assembly :: Build backend + frontend [Build 28](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=469&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **UNKNOWN**
Summary: Canceled (Exit code 137 (new); exit code 123 (new)) Build time: 00:00:35


Nope, that was a leftover - that's why it got removed in the next commit :)


Do you consider implementing a generalized class or interface like 'Cache'? Or a Cache class which takes LRU as one of its replacement algorithms or constructor? Try to use OOD (including Design Pattern)!!!


Don't be a dick


@richardkchapman this is ready to pull


Actually, this starts capturing at a double-quote and stops at the next double-quote unless it was proceeded by a backslash in which case it includes it in the next.


Place link ?


TeamCity Civic Assembly :: Build backend + frontend [Build 29](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=471&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


It seems that the DMA stop is called after the tasklet is scheduled.
I didn't manage to reproduce the bug, so if you have insight about it and procedure on how to reproduce it, we can have a look. A crash log or kernel Oops output can also hel.

Best regards,


That's a good idea!


constant


Done


Feel free to cherry-pick what you like, to much of a hassle creating a PR for each commit...


@anosach-luxoft see c26ce39f1e92deebbda06e1bf576b8295a8a4cca


And compile to .js please!


No changes to the defaults please.


The previous two are really the same expression. It captures all special single characters and the two-character "~@" .


OK, I can see this, package useful


Yay :tada:


I tried the manual way, but the builds fail, and offcourse no ouput to the builds/local folder.

Everybody else seems to have no problems? I can't imagine that...

And now even the whole platform has been renamed, which is good to clarify everything.

Please, reply. I'm out of options. :)


Hi!
I was trying to get a custom mapping working where `null` is accepted as `None` to match what we have been doing so far with Play's `formatNullable` construct, and ran into this piece of code which casts `null` to whatever the target type is. Unfortunately the method is final and this is the first thing it does so there doesn't seem to be a way to influence this behaviour.

I'm sure there's a reason for not throwing an exception instead, but would it not make sense to at least allow `read0` to look at the value first, and maybe do this cast as a last resort?

Thanks


This captures sequences of non-special characters (e.g. symbols, "true", "false", and "nil").


Won't we collide on cache keys for `nil` and `legacy kube groupversion`?


transport helis are an exception, this should stay 0.


Standardization required


Love the use of `change`!


I like to include `--format documentation` as well ;)


Это всё можно записать _одним_ выражением have_attributes.
Кроме того, надо проверить что будет, если дата состоит только из года, например.


пожалуй тут можно уточнить - date-field-container, или можно .date-field-wrapper потому что есть возможность, что у тебя будет поле другого типа, тоже с обёрткой, какой-нибудь чекбоксик, и нужно будет какие-нибудь css правила этой обёртке задавать, и может получиться что для обертки чекбокса правила будут отличаться от обёртки для даты.
Но в принципе пока оставить можешь.


Nice, I like the conversion to a module here


Yes, however the SOURCE_DATE_EPOCH stuff is in the staging branch, not in master.


Thank you and sorry again


Этот геттер, наверное, вообще не нужен. Можно напрямую вытащить ICONS.


not sufficient, test the entire `gvk`, not just the `kind`.


Not sure if it makes sense to `include` the weather in the plane, though. Should a plane be responsible for the `weather`? It'd be great if real life worked this way! But this violates SRP (and is a bit weird)


This change is not correct. Should the reallocation at original line 436 fail, then the heap data structure tracking the virtual allocations will be invalid anyway. The code here is trying to grow an array it uses to track the block allocations. It expects to be able to insert a pointer to the new allocation into the array which it is attempting to increase the size of at line 444. If the realloc failed and the block could not actually be grown, then the write at 444 is going to be off the end of the array, and will either corrupt the heap, or write into an unallocated memory and cause an AV.
It is very unlikely this realloc will actually fail and return null. If it does then that will be because there are no blocks in the heap of sufficient size to accommodate the array of pointers. This could happen when memory is exhausted, or the heap has become to fragmented. This is a very unlikely eventuality, but if it does occur then all bets are off and the program is not going to be able to continue anyway. Therefore it is not worth making even a correct implementation of this change.


Why not use make build.ncsim?


I like this way of testing it!


In python you can actually write verbose multiline regexs that have comments embedded (http://www.diveintopython.net/regular_expressions/verbose.html). However, most languages don't support that sort of regex form. BTW, I would be fine with a more complete description of the regex in the guide if you wanted to take a stab at adding that :-) (basically what you have now with my comments incorporated).


I'm gonna accept this PR; however, I think it'll be worth changing the nokogiri & xpath stuff to use CSS-style selectors in the future. For example, instead of doing an xpath query `"//table[@id='subject_tags_table']` we could do a CSS query `#subject_tags_table`. We'll get to that before you start adding more things here...


Great to see you using symbols instead of strings :+1:


Repeat from line 53-54, no?


`admission.Attributes` has a `GetKind` method.


global START_PAGE_NUMBER


Doesn't this mean all of these events will spill into the main namespace without a container?
```
import __dataSource = coreServices...;
__dataSource.redrawing
// preferred... ?
__dataSource.events.redrawing
```


Love these variable names ;)


not sufficient, compare the entire `GroupResource`


This is an interesting way of doing it! I'm not too sure I'm a big fan - you want to communicate the randomness in this test, but I don't think you need to test it (after all, `Kernel.rand()` is already well-tested).


entire `GroupResource`


"and then click Choose" <-- is this right? Just seems like 'Fix Issue' should do it


Certainly then -> that
I don't understand why you would want to deploy (= install?) a new/recent version on user's computers, then ut an older version in the download repository. Obviously I am missing something in the workflow of this.


1- serviceId is always true. Test is useless.
2- Allways compare constant to variable.


Nice. Although you have a double in line 8 you could use just as well.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 230](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=718&buildTypeId=XbimEssentials_XbimEssentials) is now running


It is not right to free the memory at line 2928, as this will discard the block that has just been allocated/resized by realloc at line 2925, leaving the elems variable as a dangling pointer into the heap. This is very likely to result in either heap corruption or an immediate AV when the compiler subsequently writes data into the memory block.


entire groupresoruce


You might want to check out https://github.com/sindresorhus/ansi-escapes


I love your commit message clarity :+1:


Brilliant. This reads like a book, which is perfect.


And https://www.npmjs.com/package/ansi-styles


Why is `Limit` written like a class?


You shouldn't restrict your decoder to a particular version.  If its not easy to fix, we can get it in the next rebase I think.


ga naar huis


Great use of `change`


:+1:
btw: placing `calculator()` inside of a while loop would make it loop


I prefer string '+' operation here since action may be null.


Watch these tabs please


`has-color` is deprecated, but seems I forgot to `npm deprecate` it. Use https://github.com/chalk/supports-color instead.


Great


:+1: Nice work seeing your mistake


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 230](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=718&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:51


It's so human readable!


actually it checks that it is not only the tie breaker but also the only order element?


The semantics of MIME type are already defined by eval & co. If your language registers multiple MIME types you can also eval in each of them and your code will always run in the same language. The same shall apply for configuration. Each of the MIME types will be equal.


:)  Just taking https://www.udacity.com/course/viewer#!/c-ud775/l-3105028581/e-3328228620/m-3360158581


Careful here, script:name isn't exactly accurate, as we have a dScript object


Redundant to check that something `== true`. In Ruby, everything is `true` except `nil` or `false`. So this could just as well be

```ruby
raise "your balance cannot exceed #{ @limit }, please top up a different value" if limit_hit?
```


Логотип как правило — ссылка на главную страницу


Avoid interpolating in tests. This is trying to be too clever: keep it simple.


LGTM.


can't we define `_mul128` instead?


rustc_const_math. Perhaps just name the crate `librustc_const_eval` if we happen to want move more thing into the crate later?


И почему решил назвать именно `index-logo`? У нас этот логотип будет только на индексной странице?


Canola  :)


Too clever though. Better `it "cannot exceed a maximum limit" do`


Hm, I'd move the implementation of `clear` back to the dtor. Calling `clear()` on its own might not make sense (you'd also have to `m_widgets.clear()` if you *do* want to call `clear()` on its own)


saw approval from macintux
at https://github.com/hairyhum/lager/commit/4373c6e567bc21d9dd6c286bb8cb046f5abd79cf


merging hairyhum/lager/error_logger_format_raw = 4373c6e5 into borshop-integration-305-error_logger_format_raw


hairyhum/lager/error_logger_format_raw = 4373c6e5 merged ok, testing candidate = 23c5cc5d


You should bring the conversation to gitter otherwise it'll get lost and nobody will be able to find it


Watch these tabs please


Nice fix, but these should be in a pull request, not commits directly to gh-pages.  Pay attention when you're committing- the details are important!


Is this okay without a delay? Some things need it, especially in events related to changing items


Better! :+1:


This change does not correctly address the issue. Should the reallocation fail then the elems block will be of insufficient size. If you really want to make this robust to memory allocation failures, then the code will have to avoid proceeding when the allocation fails, and report an appropriate error. I think this is very unlikely in practice however. I don't think it is worth making this change as it is very unlikely in practice, and should the eventuality occur then when the compiler subsequently derefs the "elems" pointer in the code, it will cause an AV that will be trapped and reported by Dolphin, without any further damage being done. This is preferable to allowing the code to continue and writing off the end of the original allocation.


How about `Pressed`? Updated in https://github.com/cfpb/cfgov-refresh/pull/1367


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12808](https://teamcity.mesosphere.io/viewLog.html?buildId=113104&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:08:46


no use..


@jwarrich looks like you caught your commit to gh-pages but I don't see an open pull request for you.  See #235 for more info


Inconsistent indentation. Watch it!


Also:
(04:12:48 PM) volker: cbegin/cend will likely be rejected by the CI, auto is fine
(04:13:19 PM) kevin.funk: oh, cbegin/cend is Qt5 stuff, didn't know
(04:13:32 PM) volker: possibly not even early Qt5 stuff, yep


I LOVE THIS


Nice catch.


ok


@kouk & @diegobz For some reason client is not working as intended with those two modes. API returns two different files, but not the client. (Well they are different, client downloads with mode `reviewed` reviewed translations and unreviewed are being substituted by the source strings. With `onlyreviewed` mode there isn't any difference)
![screen shot 2016-01-26 at 17 13 52](https://cloud.githubusercontent.com/assets/13113025/12584432/332a704a-c450-11e5-88d7-2ff0bc432ac8.png)


Top string escaping :+1:


comment is opaque?  you mean check on next rebase?


should this be 2015-1016?


:boom: done.


These are really neat tests.


godoc mismatch, can fix it after.


Why not allow "players:" or something as well? "set 100 money to Bob" doesn't sound right


Removed the whitespace that I accidentally added.


This is nice. However, I try to avoid `allow_any_instance_of` where possible. It's better to seed rand using `srand`.


Is the old one still used?  For origin?


Super-clear. :+1:


The following doc(s) have been deployed to the [test-commen](http://test-commen-static-docs.pantheon.io/docs) Multidev environment:
- [source/_partials/footer_content.html](https://github.com/pantheon-systems/documentation/commit/222bc615ff7193b0a4b9de5500bb9d0960c396f8/source/_partials/footer_content.html)
- [docs/articles/drupal/8/create-services-yml-file](http://test-commen-static-docs.pantheon.io/docs/articles/drupal/8/create-services-yml-file)
- [docs/articles/drupal/configuring-jetbrains-phpstorm-ide-with-pantheon](http://test-commen-static-docs.pantheon.io/docs/articles/drupal/configuring-jetbrains-phpstorm-ide-with-pantheon)
- [docs/articles/local/cli/machine-tokens](http://test-commen-static-docs.pantheon.io/docs/articles/local/cli/machine-tokens)
- [docs/articles/local/continuous-integration-solutions](http://test-commen-static-docs.pantheon.io/docs/articles/local/continuous-integration-solutions)
- [docs/articles/wordpress/cloudFront-setup-for-wordpress](http://test-commen-static-docs.pantheon.io/docs/articles/wordpress/cloudFront-setup-for-wordpress)
- [docs/guides/rerouting-outbound-email](http://test-commen-static-docs.pantheon.io/docs/guides/rerouting-outbound-email)


Not necessary. Just try
```ruby
def stormy?
  rand(0..6) == 0
end
```


Add "zip" to wily/vivid/utopic dependencies files


The cache still remains though so in a long running process, this will chew up more and more memory, right? (I don't think that's a problem, because that's not how I expect people will use memoise, but it should be mentioned somewhere)


Great to see a named subject :+1:


Why would we exit early?


Watch the indentation here


Shouldn't this be `detail::` instead of `details::`?


It's required for `librustc` to compile, not the other way around. All other `librustc_*` crates require `librustc`.


@sbeaver-netgate Yes, this and the previous commit together look good. The <span id=secs> tag is a good way to have a place where text can be put and replaced by JS at run time.


Well is it an 16 bytes by entries. But the issue isn't the RAM but the cache. If we need to double all structures in x64, perf impact won't be nice.


Also I feel like airports shouldn't be responsible for the `Weather`


+1 Thanks, Kang Ye for your work.

Just for next commit messages - wrap it to about 72 characters or so on the line.


NIT: an empty line between previous and next method.


better: `if !@planes.include?(plane)`

best: Private method e.g.

```ruby
def at_airport?(plane)
  @planes.include?(plane)
end
```


I like this :+1:


This is moved to the higher level?


nit: repo URL is Kinto/kinto.js


@shortie8 were right. This commit breaks arm support.
https://github.com/NicoHood/Arduino/commit/6398cde1c820e04294e1aa379293d440abb2863a#commitcomment-15669960


Since you chose a number type for your input here, you must handle the negative number issue. You can do this with input properties.


Great tidying here. Thanks, Hound! Thound


зачем нам эта обёртка?


Avoid committing commented code at all costs :8ball:


By the IOP tests are maybe not perfect.
1/ EE is in crazy mode. It would be better to make it jump to the IDLE thread.
2/ IOP is loaded after the initial ROM image. However it could be a better idea to load after the flash of the new kernel image. Actually it would be even better to use same version as the reference.


...I'm curious, what even caused an error here ø.O


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12809](https://teamcity.mesosphere.io/viewLog.html?buildId=113111&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:07:25


Nit: perhaps name this `try_cmp` or something, so the name doesn’t collide with `PartialOrd`?


Looked fine to me


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12810](https://teamcity.mesosphere.io/viewLog.html?buildId=113116&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:06:50


Anyone remembers why we need "socket.io"?


I now also tried it with the dev branch with the build.cmd. It will run for a while and does a lot, and eventually fails with the following message:
`Unable to locate Dependency Microsoft.Net.Http.Server >= 1.0.0-rc2-16188`


Nice job on your quiz, William! Make those changes to your number input and then you are good to go. :+1:


No need for the instance var here though. `[:sunny, :raining, :snow, :hail, :stormy].sample` would do


nit: `TransactionProxy` → `get()`


Тут больше похоже на `input[type=search"]`, который при `:hover` и `:focus` раздвигается влево. Что скажешь?


TeamCity Civic Assembly :: Build backend + frontend [Build 29](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=471&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 1736, ignored: 7 Build time: 00:20:29
### Failed tests
```
Document tests: Should take a alert when try to upload new version for locked document: <no details avaliable>

User Management: Should submit a form for user creation: <no details avaliable>

Venue tests: Venue type: Should Not Edit a Venue: <no details avaliable>

```


new file


@xtreamwayz yeah, I moved to alpha8 as minimum supported, thanks for notifying tho :-)


Watch your tabs! Use spaces for indentation, and set your text editor to do this automatically.


Very nice test


Tack!


why the homepage fields are left "-" in those rockspecs?


`Dis`…`play`? Why not `Debug`?


Yes primitive types are passed by value. In this case the primitive type is the array, so a list of addresses to SortSpecificer. So copying the array does copy a list of references.


Hey, why have you removed this part? The function main() would not be called then, and the program won't run.


Committing with merge conflicts! :scream:


Tabs please


Just checking, the null-or-undefined check is intentional?


I removed the `map` that was in this file because I think that's best delegated to an existing library (either built in like `Array.prototype.map` or a library like lodash).

I used lodash because I wanted to keep good browser support if it's not much effort.

Lodash didn't drop support for IE8, did it?


Wrong issue number?


Avoid type checking. This is a big antipattern because of duck typing.


This is a better way to check a thing is what it says it is: by testing its behaviour.


@syl20bnr I'm not sure what you mean by the message here


@timsutton Oh!!! Thanks good infomation!!
I'll check later and fix README.


good catch, I copy-pasted exception code. still need to clean this up


Should we mention that we don't rollback imported changes if push to server fails ?


Might want to open issue for these xplat-todos?


This misses the point of the undocumented 'tyFieldAccessor' though. Not sure what the state of our test suite is for this feature but I'm afraid there is no bug here, but just a bad error message.


Very nice method


Very neat code :+1:


Зачем и тут обёртки? Мы же можем написать типа такого: `a.btn.enter` (понятна запись?)


Shell


Yes, I wasn't sure which way we wanted to go. If we only check `isLegalPort`, then `null` will be coerced to 0, but undefined will be invalid.


You probably also want to forbid move assignment and move constructors.

Also, this is nice new syntax for C++11:

```C++
    PoolAllocator(PoolAllocator&&) = delete;
```


I really like this private method. It's beautiful, and I never thought to do it. Great job :+1:


I'm not really sure, but I think argv is sent generally; the argparse object uses them by default


Improve Javadoc


By the way, I'm working on a pet-project allmychanges.com and keep [a list of the tools to make changelogs](https://allmychanges.com/help/changelog-generators/). May be some of them will suite your needs.

Also, the good reference is a http://keepachangelog.com site.


@jimmidyson Please build and push a new release containing this PR to the maven repo so that the origin-aggregated-logging elasticsearch container can pick up this plugin via the elasticsearch plugin install command.  Thanks!


Love that you are returning a plane at the end too. Your Ruby reads like a book: perfect.


Run Busybox shell


Hmm it's restricted by a global structure size? sucks...

Okay I guess just remove the padding then, should just about fit in the 16 bytes.


That is true, there isn't a function in memoise currently to invalidate a particular call, which is I guess what you would want to implement that. All you can do is call `forget()`, which dumps the whole cache.


опечатка: "basket" правильно


Great that you are injecting `Weather` as a dependency. This is a beautiful pattern. :100:


Great to see you preferring symbols to strings.


Is currently an error, and probably should stay that way for the time being.


I like this. It might be over-optimisation, but that's preferable to anything else. Great job.


I can't seem to get gerrithub to see my repository, probably because it's an organization's repo.


I thouoght about that, but if I'm reading https://stackoverflow.com/questions/8283589/are-move-constructors-produced-automatically right, the compiler won't even attempt to automatically generate move-related operators in this case.

I wanted to use `= delete`, but I'm not sure if that's supported in armcc, so I opted for the safer alternative.


I'm not sure you need an instance variable here. I feel like this is over-optimisation.


all tests pass:
success: http://buildbot.bos1/builders/test-lager/builds/338


The downside here is that if one expectation fails, the whole spec fails - but here I'm testing the same behavior so I didn't really see the point of isolating those expectations.


any documentation of this change? couldn't find anything with a quick google. thanks!


:0 wow, I haven't seen that used in a while. Brilliant brilliant way of testing this.


comment: time in ms


Thank you for including your build status!


First thought - would it be possible to move init() into the base class?  Loop over _var_names, and for each name assert(has_variable) then set _vars.


Давай это голосом лучше обсудим, ок?


A really wonderful and clear README @yyl29 . Seriously great job.


Thanks for the contribution. I have a clarification question: are you trying to use ncsim as your simulator? If so, maybe we should consider support ncsim as a separate target, rather than modifying the code path for build.bluesim.


hum, indeed, should probably check if `read` is not zero. I'm still not totally sure this is the right thing to do (the read loop) for immutable files, as this slow down reads (for big files) quite a lot. Any opinion on that? @avsm I remember you said that mmap was not a good idea in general


а на других слайдах — этот же заголовок?


for sake of clarity I would not negate the condition when I use the else...


Even the add_variable cases could be pushed into base classes if you made _order and _fe_family indexed vectors.


newline missing


Looks dead


Looks ok - would like someone to do another pass in case I missed something


what is this？


I will have to kill a kitten for this...


banners


missing newline


Oh, wait, that's what you did.  So are e.g. _TU_order and _TU_FE_family redundant with these?


This conversion method smells. (i.e. makes converting i64->i32, losing info along the way, easy)


Is this still used? If not then this can be deleted


Ditto.


@thetutlage Note that some code documented here are not released yet.

Like the RESTful routing section.


контентное или декоративное изображение?


@martint

> I'm investigating whether this is going to be a big problem for all the client libraries we run at FB. At first glance, it appears that the only one affected is the Presto client and jdbc driver.

> I was thinking we might want to apply just this change as a separate PR that we can roll out in the next release in preparation for merging the rest of the varchar changes once the clients have been updated to use the new version of the driver.

Seems reasonable. I will prepare such PR.


cc @pan-
I'm not clear on the behaviour when you declare one as private, but don't instantiate it.


lgtm


If we use this construct everywhere a helper might have been better.  I'm not sure it's worth changing now


что за пустой элемент?


Perhaps nothing will ever attempt to exec something other than coreutils on the `$PATH` (in which case the following distinction isn't important), but should this bet *setting* `$PATH` or *prefixing* it? It would seem that the `source "$NIX_LD_WRAPPER_EXEC_HOOK"` line could result in arbitrary code running; might be best to prefix to avoid surprises?


Psst. https://github.com/reindexio/youmightnotneedunderscore.


Awesome! Thanks for the infromation, I will fix that now!

—

@StuYam

Software Engineer at Dockwa.com

On Tue, Jan 26, 2016 at 8:16 AM, Prayag Verma <notifications@github.com>
wrote:

> I am not a lawyer but according to http://www.copyright.gov/circs/circ01.pdf (See screenshot of relevant section below), listing the first year of publication in the copyright is a good thing
> ![selection_008](https://cloud.githubusercontent.com/assets/829526/12409934/7021c3a6-be95-11e5-8d1a-18f6948571e0.png)
> In case, you don't want to update the license year every new year, you can follow a notation like `2015-present` (used by libraries like React - https://github.com/facebook/react/blob/master/LICENSE )
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/yamartino/pressure/commit/e034dbbc98bc14a51432009e6bb9096b7ab756f5#commitcomment-15676376


It is in master already since 1a4ab04e29.


`class="rub"` — логичнее смотрелось бы...


Era mejor Dropp Showdown, pero ok :+1:


why we decided to remove this?


Looks good to me.


I think there's a dead field (or if not dead, its in the wrong spot).  LGTM otherwise.


We could pass `--no-column` and `--no-color` to avoid depending on the user's config


Thanks for teaching me!


Since this PR is an automatic Jenkins process I see now that this change is needles.
Feel free to ignore this.


Should it read *following configuration*?


# Assignment 2 Grading Rubric (15 points total)

## Screenshots

- [ ] There are screenshots showing 3 valid ways to run the program (0.5 pt)

## Imports

- [ ] To the best of your knowledge, each of these explanations is correct (1.5 pts)
- [ ] This method of import is correctly selected as the best (0.5 pts)
- [ ] This explanation is correct and the example is good (0.5 pts)

## Paths

- [ ] This is a reasonable path to the Desktop (1 pts)
- [ ] This is a reasonable path to the `root` directory (1 pts)
- [ ] This is a correct explanation of the meaning of $PATH (1 pts)
- [ ] This is a correct explanation of the meaning of $PYTHONPATH (1 pts)

## Modules

- [ ] This paragraph explains the module well (3 pts)
- [ ] There are examples (3 pts)
- [ ] The examples aren't simply taken from the documentation (2 pts)


после `—` — зачем неразрывный пробел?


感觉这样不是很必要，我找个时间写个升级脚本吧


Token of git conflicts should be removed.


very thankful that you did this in a single commit ;)


FIXME:


Тут у каждого `p` своя иконка, может, сразу добавим классы?


This repository has changed again to incorporate a `public/media` folder for images etc. Also, the `source_html` folder has been deleted and all html files have moved to the `public` folder.


Yes, it's because the `+n` mode is set on #pyinstaller. The `skip_join` option requires that the mode not be set, because the bot will try to send messages to the channel without joining it.

Either set `-n` on the channel, or remove the `skip_join` option.


good catch, I've got a 3.4.1 branch pr open and ready to go.


Well this makes me sad.  We should fix it upstream.


Testing `lz4` on the staging branch actually revealed a bug with SOURCE_DATE_EPOCH, which I fixed (f4553d721972e6a437c9f367af2bb0967b773998). So I guess we can revert this commit.


It will when I get round to it.  Didn't want to lose comments.


Lab 1 has changed to incorporate changes that were made to `mp1_starter`


@dugokontov jos koristis sublime :)


*at least*


Isn't that the reason the C90 `atexit` function exists? So you can do cleanup stuff without worrying about where you'll be exiting?


I derived `Debug`. The `Display` impl is what you could use directly in rust code to obtain the same value again


похоже на заголовок, оставим просто ссылку?


null- [docs/guides/using-sendgrid-to-deliver-email-with-wordpress-and-drupal](http://test-commen-static-docs.pantheon.io/docs/guides/using-sendgrid-to-deliver-email-with-wordpress-and-drupal)


@b4n Great! Will have a look at it too.


it is. `check_division` does the same checks for division and remainder


missing %d for printing cycles


either *selects specific devices* or *selects a specific device*


Should we add a note that bus/dev is dynamically allocated and does not correspond to USB ports?


то, что другой шрифт — не смутило? Как будем стилизовать?)


We need to be careful here. Javascript is a very forgiving language, so this may work in this example, but this code is technically flawed. Here's why:
- `slength` = length of the string. so if the string is `hello`, slength is `5`
- your for loop condition is `i <=`, meaning that, in the last iteration of your loop, `i` would = `5` in the case above
- so in that final iteration, you are trying to assign letter1 to the character located between positions 5 and 6, which does not exist.

To see what I mean about this not working in other languages, check out [this example](https://play.golang.org/p/4x_CgUXGvM) and click "Run" at the top. The language is in Go, but you will recognize the similarities with your code. Scroll down the bottom of the output after you run it.


@underlog This task do not exist in the gulpfile:

```console
$ gulp tests
[09:32:41] Using gulpfile d:\kendo-ui-core\gulpfile.js
[09:32:41] Task 'tests' is not in your gulpfile
[09:32:41] Please check the documentation for proper gulpfile formatting
```


done


fast-forwarding master to borshop-integration-305-error_logger_format_raw = 23c5cc5d


This looks ok to me, but would prefer you rename `graph` to `baseGraph` to match the method signature in `DrawLine` and `DrawWay` where it is used.

I normally don't nitpick about variable names, but this is one is kind of confusing.


The `tests` task do not exist in the gulpfile.


Sure, I guess we want one API compatible with the one already used? It could basically be what I submitted with low being the result cast to int64 and low the result shifted 64bits. Would that be OK?


We have here list of selected entities, i add remove button and i will try now to insert my own library for selected entities, but maybe is enough this one for entity_reference? I will continue this later from home.


The TID value should be query from the kernel state system from $currentCPU/$currentThread


Dear Pieter, I have followed your tuto to setup evohome on my own website. evrything seems to be clear but when I run the TemperatureLogging.py I get error about missing parenthesis on line 20.
Your help woul be very much appreciated, I am definitely really interested in this dvlpmt.
Thanks.pascal (pascal at pixs.be)


Please, don't use c-casts


Valeu pela contribuição, para poder entrar na master vou precisar dos testes unitários.

Obrigado!


I don't think we want to use `country_from_ip` except in the `other_country_message` method of the service controller - it would only work correctly if we disabled caching for the pages we used it on. We currently have this page set to `long_cache` which means the headers are such that varnish will serve up the same page to multiple different IP addresses. I don't think it's worth sacrificing that caching - we can use `ISO_COUNTRY_CODE` from the `general.yml` file instead to get the country for the install rather than the user here.


@K-Guan 邮箱 andytimes@qq.com

有急事，速发邮件给我。


The jquery-mobile is depended on the jquery, so add jquery.js. When I
deleted jquery.mobile.theme-1.4.5.css, there is no effect to the
website, now just delete it.


I'll keep that in german to prevent misunderstandings.

Das sind viele Commits. Solche unnötigen Refactorings in der Commitliste zu haben empfinde ich als sehr störend.

{ nach Funktionen gehören in die gleiche Zeile, völlig egal ob das Funktionen in Klassen sind oder ob sie zu Objekten gehören. Das ändert doch überhaupt nichts am Kontext der Funktion, nichts an der Darstellung.

Wir haben in s9y einen vereinbarten Codestil und den auf dem s9y-Treffen einstimmig bestätigt. Selbst wenn Garvin damit okay wäre, ich wäre es niemals – für ein neues Projekt kann es mir schnuppe sein, aber das hier jetzt zu ändern ohne Anlassist inakzeptabel.

Was ich übrigens okay finde ist das Einfügen von { nach einzeiligen if-Statements. Aber nicht wegen Stil, sondern weil es Bugs vermeidet.

Generell: Entweder wir schieben s9y automatisiert durch einen Codeformatierer wie in Go fü alle neuen Commits. Oder wir halten uns an unseren existierenden Standard wenn bestehende Codeabschnitte sowieso neu formatiert werden müssen. Aber in keinem Fall sind solche Stil-Neuformatierungen akzeptabel. Das ist doch nur Lärm und Einfallmöglickeit für Bugs und wäre höchstens okay bei Refactorings für Codequalität wie mattsches mal angedacht hatte (static analysis).


O resultado? Teria como me explicar ou passar algum link do processo?

Em 26 de janeiro de 2016 13:37, Vitor Leal <notifications@github.com>
escreveu:

> Valeu pela contribuição, para poder entrar na master vou precisar dos
> testes unitários.
>
> Obrigado!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/soares-luan/node-correios/commit/7b0da97a812885cdc465e131a924a69799b47a8d#commitcomment-15680269>
> .
>

--
*Luan Soares*


I failed to see the rationale of changes in this file, can you elaborate?