[R/extdata.R:20:6:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/extdata.R#L20) *style:* **Commented code should be removed.**
```r
#' # "extdata/fortytwo.rds"
     ^~~~~~~~~~~~~~~~~~~~~~
```
[R/extdata.R:39:3:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/extdata.R#L39) *warning:* **no visible global function definition for ‘read_rds’**
```r
  read_rds(dots_expr, assign.env = assign.env)
  ^~~~~~~~
```
[R/extdata.R:65:3:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/extdata.R#L65) *warning:* **no visible global function definition for ‘read_rds’**
```r
  read_rds(files, assign.env = assign.env)
  ^~~~~~~~
```
[R/extdata.R:71:15:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/extdata.R#L71) *warning:* **no visible global function definition for ‘extdata_name’**
```r
  system.file(extdata_name(), package = packageName(package.env))[[1L]]
              ^~~~~~~~~~~~
```
[R/extdata.R:75:23:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/extdata.R#L75) *warning:* **no visible global function definition for ‘extdata_name’**
```r
  file.path(pkg$path, extdata_name()[[2L]])
                      ^~~~~~~~~~~~
```
[R/fortytwo.R:10:2:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/fortytwo.R#L10) *style:* **Commented code should be removed.**
```r
#extdata(fortytwo)
 ^~~~~~~~~~~~~~~~~
```
[R/fortytwo.R:11:2:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/fortytwo.R#L11) *style:* **Commented code should be removed.**
```r
#extdata_("fortytwo")
 ^~~~~~~~~~~~~~~~~~~~
```
[R/fortytwo.R:12:2:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/fortytwo.R#L12) *style:* **Commented code should be removed.**
```r
#read_rds("inst/extdata/fortytwo.rds")
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/infrastructure.R:13:3:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/infrastructure.R#L13) *warning:* **no visible global function definition for ‘require_devtools’**
```r
  require_devtools()
  ^~~~~~~~~~~~~~~~
```
[R/infrastructure.R:17:19:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/infrastructure.R#L17) *warning:* **no visible global function definition for ‘inst_extdata_path’**
```r
  inst_extdata <- inst_extdata_path(pkg)
                  ^~~~~~~~~~~~~~~~~
```
[R/infrastructure.R:23:3:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/infrastructure.R#L23) *warning:* **no visible global function definition for ‘write_auto_extdata’**
```r
  write_auto_extdata(pkg)
  ^~~~~~~~~~~~~~~~~~
```
[R/infrastructure.R:33:1:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/infrastructure.R#L33) *style:* **lines should not be more than 80 characters.**
```r
  message("Now include additional datasets as .rds files in the inst/extdata directory.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/infrastructure.R:45:5:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/infrastructure.R#L45) *warning:* **no visible global function definition for ‘write_fun’**
```r
    write_fun("auto_extdata", con)
    ^~~~~~~~~
```
[R/infrastructure.R:46:5:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/infrastructure.R#L46) *warning:* **no visible global function definition for ‘write_fun’**
```r
    write_fun("read_rds", con)
    ^~~~~~~~~
```
[R/infrastructure.R:47:5:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/infrastructure.R#L47) *warning:* **no visible global function definition for ‘write_fun’**
```r
    write_fun("extdata_path", con)
    ^~~~~~~~~
```
[R/infrastructure.R:48:5:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/infrastructure.R#L48) *warning:* **no visible global function definition for ‘write_fun’**
```r
    write_fun("extdata_name", con)
    ^~~~~~~~~
```
[R/infrastructure.R:49:5:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/infrastructure.R#L49) *warning:* **no visible global function definition for ‘write_fun’**
```r
    write_fun("name_from_rds", con)
    ^~~~~~~~~
```
[R/infrastructure.R:50:5:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/infrastructure.R#L50) *warning:* **no visible global function definition for ‘write_fun’**
```r
    write_fun("delayed_assign_", con)
    ^~~~~~~~~
```
[R/infrastructure.R:51:5:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/infrastructure.R#L51) *warning:* **no visible global function definition for ‘write_fun’**
```r
    write_fun("delayed_assign_one", con)
    ^~~~~~~~~
```
[R/infrastructure.R:86:1:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/infrastructure.R#L86) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
{
^
```
[R/infrastructure.R:91:3:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/infrastructure.R#L91) *warning:* **no visible global function definition for ‘require_devtools’**
```r
  require_devtools()
  ^~~~~~~~~~~~~~~~
```
[R/infrastructure.R:95:19:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/infrastructure.R#L95) *warning:* **no visible global function definition for ‘inst_extdata_path’**
```r
  inst_extdata <- inst_extdata_path(pkg)
                  ^~~~~~~~~~~~~~~~~
```
[R/infrastructure.R:99:1:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/infrastructure.R#L99) *style:* **lines should not be more than 80 characters.**
```r
    stop("At least one of the target files exists. Use overwrite = TRUE to override.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lazyforward.R:18:3:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/lazyforward.R#L18) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  }, as.environment(list(call_nse = call_nse))))
  ^
```
[R/read-rds.R:15:6:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/read-rds.R#L15) *style:* **Commented code should be removed.**
```r
#' # "extdata/fortytwo.rds"
     ^~~~~~~~~~~~~~~~~~~~~~
```
[R/read-rds.R:29:27:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/read-rds.R#L29) *warning:* **no visible global function definition for ‘name_from_rds’**
```r
  names(dots)[unnamed] <- name_from_rds(dots[unnamed])
                          ^~~~~~~~~~~~~
```
[R/read-rds.R:38:3:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/read-rds.R#L38) *warning:* **no visible global function definition for ‘delayed_assign_’**
```r
  delayed_assign_(.dots = dots_expr, assign.env = assign.env)
  ^~~~~~~~~~~~~~~
```
[R/zzz-autoroxy.R:1:1:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/zzz-autoroxy.R#L1) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
{
^
```
[R/zzz-autoroxy.R:8:16:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/zzz-autoroxy.R#L8) *warning:* **Do not use absolute paths.**
```r
    if (grepl("/.*[.]Rcheck/00_pkg_src/.*$", normalizePath(getwd(),
               ^~~~~~~~~~~~
```
[R/zzz-autoroxy.R:14:1:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/R/zzz-autoroxy.R#L14) *style:* **lines should not be more than 80 characters.**
```r
        warning("Cannot load roxygen2. Package documentation will be unavailable.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-delayed-assign.R:6:44:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/tests/testthat/test-delayed-assign.R#L6) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  delayed_assign(fortytwo = 42L, message = { message("Hi!"); NULL },
                                           ^
```
[tests/testthat/test-delayed-assign.R:6:67:](https://github.com/krlmlr/rextdata/blob/8a714fa1f63adf95bb61fd3fd34333381f54d65f/tests/testthat/test-delayed-assign.R#L6) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  delayed_assign(fortytwo = 42L, message = { message("Hi!"); NULL },
                                                                  ^
```


develop (axelstudios) - Win64-Windows-7-VisualStudio-12: OK (2348 of 2384 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.49%25-yellow.svg)


I have reservations having design tests for deprecated elements (s is deprecated and nobody will come up with a good excuse to use it instead of del. Del (with ins) is okay for representing replaced as well as deleted content). Another observation is, we ought to test ordered lists as well (ol).  Do we need to worry about the various bullet styles?


If increasing of cyclomatic unavoidable then make it more "friendly"
For create if scopes with exit body only
like
```javascript
 if( _.keys(primitivesMap).indexOf(type) <0 ){
    return ""
}
```


2015, not 2016?


Seems fine to me.


Test on a real point cloud.
The point cloud has 40k points. I use 200 random sampled point to build the
gp.
In the plot the yellow points are the 40k from the point cloud. Then I
randomly sample other 50 points to evaluate the fx, varx and the normals.
Blue normal are the ones computed from pcl, the magenta ones are estimated
by the gp.
There are errors, however it is also true that this point cloud is a
composition of several views, so the pcl knows when the normal is pointing
inside or outside the object. I don't know if a gp would ever be able to
figure it out by itself. Perhaps the best option is to have a gp with two
kernels, one for the points and one for the normals.

PS. I don't have any nan in the computation.

On 12 January 2016 at 11:12, Memnone <memnone@gmail.com> wrote:

> I would say that, given the same point cloud is OK that the optimisation
> converges always to the same values.
> I did not get if the NAN values come from pcl or from my lib. For the
> sphere I don't recall seeing NAN normals.
> I'm about to test my code on a real point cloud using golem. I will come
> back with the results from my testing.
>
> On 12 January 2016 at 10:42, Federico <notifications@github.com> wrote:
>
>> Ok it works, good yob. Here's some remarks i found to improve it further:
>>
>> Optimization always converges to the almost same parameters (in this case
>> l=1.74 s=0.255), the normals are surely improved and some of them are
>> almost identical to pcl ones (blue discs), but some of them are still
>> incorrect and it looks random which of them are incorrect.
>> [image: screenshot from 2016-01-12 11 29 09]
>> <https://cloud.githubusercontent.com/assets/1950251/12261360/e815681a-b920-11e5-84d6-b271ba237f83.png>
>>
>> Another thing i noticed, i made 10 computes or so and the FIRST normal
>> computed is always NAN no matter what... thus the errors towards pcl:
>>
>> Error from pcl normal new lib: inf
>> Error from pcl normal new lib: 0.092285
>> Error from pcl normal new lib: 0.988456
>> Error from pcl normal new lib: 0.248141
>> Error from pcl normal new lib: 0.262916
>> Error from pcl normal new lib: 0.154093
>> Error from pcl normal new lib: 0.386632
>> Error from pcl normal new lib: 0.127535
>> Error from pcl normal new lib: 0.91962
>> Error from pcl normal new lib: 2.48641e-16
>> Error from pcl normal new lib: 0.696234
>> Error from pcl normal new lib: 0.704938
>> Error from pcl normal new lib: 0.410239
>> Error from pcl normal new lib: 0.730451
>> Error from pcl normal new lib: 1.07823
>> Error from pcl normal new lib: 0.853574
>> Error from pcl normal new lib: 0
>> Error from pcl normal new lib: 0.481036
>> Error from pcl normal new lib: 0.493647
>> Error from pcl normal new lib: 0.819825
>>
>> As you can see some are close to zero [image: :+1:] some other are not [image:
>> :-1:] , plus the first one is nan.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/pacman-project/gaussian-object-modelling/commit/db07b15c925c8b6059d397721847e3a78d00e7fd#commitcomment-15393425>
>> .
>>
>
>
>
> --
> Claudio
>
> Curiously enough, the only thing that went through the mind of the bowl of
> petunias as it fell was "Oh no, not again".
> Many people have speculated that if we knew exactly why the bowl of
> petunias had thought that we would know a lot more about the nature of the
> Universe than we do now.
> D. Adams - Hitchhiker's guide to the galaxy
>

--
Claudio

Curiously enough, the only thing that went through the mind of the bowl of
petunias as it fell was "Oh no, not again".
Many people have speculated that if we knew exactly why the bowl of
petunias had thought that we would know a lot more about the nature of the
Universe than we do now.
D. Adams - Hitchhiker's guide to the galaxy


I'm with Arcanemagus.  I'm not involved in the drama that went down here, but have switched to the other repo simply because it fixed my bugs.  Bugs that I have been unable to report,  unable to submit PR's for and frankly, unable to communicate anything to the developer about.

I hope you get the project back under control echel0n but right now, from my point of view,  you don't have a leg to stand on and a large portion of your community thinks you are an absolute asshole.   Good luck with everything you do.


My idea of testing it was much simpler :)
I thought to simply use this template to generate an application and check if still works. Some kind of a manual smoke test.

Not sure how exactly to do it though.


TODO. Dangerous assumption there.


@wzrdtales, alright, it's just the update of the `parse-database-url` package version? you want me to open the PR?


Are there BC breaks that should be documented before we upgrade to `5.x`? Otherwise we can also update the documentation to the new master alias: https://github.com/lexik/LexikFormFilterBundle/blob/master/Resources/doc/installation.md


Forgot to convert to TypeScript, it is still in JavaScript.


[R/extdata.R:20:6:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/extdata.R#L20) *style:* **Commented code should be removed.**
```r
#' # "extdata/fortytwo.rds"
     ^~~~~~~~~~~~~~~~~~~~~~
```
[R/extdata.R:39:3:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/extdata.R#L39) *warning:* **no visible global function definition for ‘read_rds’**
```r
  read_rds(dots_expr, assign.env = assign.env)
  ^~~~~~~~
```
[R/extdata.R:65:3:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/extdata.R#L65) *warning:* **no visible global function definition for ‘read_rds’**
```r
  read_rds(files, assign.env = assign.env)
  ^~~~~~~~
```
[R/extdata.R:71:15:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/extdata.R#L71) *warning:* **no visible global function definition for ‘extdata_name’**
```r
  system.file(extdata_name(), package = packageName(package.env))[[1L]]
              ^~~~~~~~~~~~
```
[R/extdata.R:75:23:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/extdata.R#L75) *warning:* **no visible global function definition for ‘extdata_name’**
```r
  file.path(pkg$path, extdata_name()[[2L]])
                      ^~~~~~~~~~~~
```
[R/fortytwo.R:10:2:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/fortytwo.R#L10) *style:* **Commented code should be removed.**
```r
#extdata(fortytwo)
 ^~~~~~~~~~~~~~~~~
```
[R/fortytwo.R:11:2:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/fortytwo.R#L11) *style:* **Commented code should be removed.**
```r
#extdata_("fortytwo")
 ^~~~~~~~~~~~~~~~~~~~
```
[R/fortytwo.R:12:2:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/fortytwo.R#L12) *style:* **Commented code should be removed.**
```r
#read_rds("inst/extdata/fortytwo.rds")
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/infrastructure.R:13:3:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/infrastructure.R#L13) *warning:* **no visible global function definition for ‘require_devtools’**
```r
  require_devtools()
  ^~~~~~~~~~~~~~~~
```
[R/infrastructure.R:17:19:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/infrastructure.R#L17) *warning:* **no visible global function definition for ‘inst_extdata_path’**
```r
  inst_extdata <- inst_extdata_path(pkg)
                  ^~~~~~~~~~~~~~~~~
```
[R/infrastructure.R:23:3:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/infrastructure.R#L23) *warning:* **no visible global function definition for ‘write_auto_extdata’**
```r
  write_auto_extdata(pkg)
  ^~~~~~~~~~~~~~~~~~
```
[R/infrastructure.R:33:1:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/infrastructure.R#L33) *style:* **lines should not be more than 80 characters.**
```r
  message("Now include additional datasets as .rds files in the inst/extdata directory.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/infrastructure.R:45:5:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/infrastructure.R#L45) *warning:* **no visible global function definition for ‘write_fun’**
```r
    write_fun("auto_extdata", con)
    ^~~~~~~~~
```
[R/infrastructure.R:46:5:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/infrastructure.R#L46) *warning:* **no visible global function definition for ‘write_fun’**
```r
    write_fun("read_rds", con)
    ^~~~~~~~~
```
[R/infrastructure.R:47:5:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/infrastructure.R#L47) *warning:* **no visible global function definition for ‘write_fun’**
```r
    write_fun("extdata_path", con)
    ^~~~~~~~~
```
[R/infrastructure.R:48:5:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/infrastructure.R#L48) *warning:* **no visible global function definition for ‘write_fun’**
```r
    write_fun("extdata_name", con)
    ^~~~~~~~~
```
[R/infrastructure.R:49:5:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/infrastructure.R#L49) *warning:* **no visible global function definition for ‘write_fun’**
```r
    write_fun("name_from_rds", con)
    ^~~~~~~~~
```
[R/infrastructure.R:50:5:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/infrastructure.R#L50) *warning:* **no visible global function definition for ‘write_fun’**
```r
    write_fun("delayed_assign_", con)
    ^~~~~~~~~
```
[R/infrastructure.R:51:5:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/infrastructure.R#L51) *warning:* **no visible global function definition for ‘write_fun’**
```r
    write_fun("delayed_assign_one", con)
    ^~~~~~~~~
```
[R/infrastructure.R:86:1:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/infrastructure.R#L86) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
{
^
```
[R/infrastructure.R:91:3:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/infrastructure.R#L91) *warning:* **no visible global function definition for ‘require_devtools’**
```r
  require_devtools()
  ^~~~~~~~~~~~~~~~
```
[R/infrastructure.R:95:19:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/infrastructure.R#L95) *warning:* **no visible global function definition for ‘inst_extdata_path’**
```r
  inst_extdata <- inst_extdata_path(pkg)
                  ^~~~~~~~~~~~~~~~~
```
[R/infrastructure.R:99:1:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/infrastructure.R#L99) *style:* **lines should not be more than 80 characters.**
```r
    stop("At least one of the target files exists. Use overwrite = TRUE to override.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lazyforward.R:18:3:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/lazyforward.R#L18) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  }, as.environment(list(call_nse = call_nse))))
  ^
```
[R/read-rds.R:15:6:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/read-rds.R#L15) *style:* **Commented code should be removed.**
```r
#' # "extdata/fortytwo.rds"
     ^~~~~~~~~~~~~~~~~~~~~~
```
[R/read-rds.R:29:27:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/read-rds.R#L29) *warning:* **no visible global function definition for ‘name_from_rds’**
```r
  names(dots)[unnamed] <- name_from_rds(dots[unnamed])
                          ^~~~~~~~~~~~~
```
[R/read-rds.R:38:3:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/read-rds.R#L38) *warning:* **no visible global function definition for ‘delayed_assign_’**
```r
  delayed_assign_(.dots = dots_expr, assign.env = assign.env)
  ^~~~~~~~~~~~~~~
```
[R/zzz-autoroxy.R:1:1:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/zzz-autoroxy.R#L1) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
{
^
```
[R/zzz-autoroxy.R:8:16:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/zzz-autoroxy.R#L8) *warning:* **Do not use absolute paths.**
```r
    if (grepl("/.*[.]Rcheck/00_pkg_src/.*$", normalizePath(getwd(),
               ^~~~~~~~~~~~
```
[R/zzz-autoroxy.R:14:1:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/R/zzz-autoroxy.R#L14) *style:* **lines should not be more than 80 characters.**
```r
        warning("Cannot load roxygen2. Package documentation will be unavailable.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-delayed-assign.R:6:44:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/tests/testthat/test-delayed-assign.R#L6) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  delayed_assign(fortytwo = 42L, message = { message("Hi!"); NULL },
                                           ^
```
[tests/testthat/test-delayed-assign.R:6:67:](https://github.com/krlmlr/rextdata/blob/c9bcbbcf5e1ee7d17a6597d16d85452df6061f5a/tests/testthat/test-delayed-assign.R#L6) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  delayed_assign(fortytwo = 42L, message = { message("Hi!"); NULL },
                                                                  ^
```


What's the occasion?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11288](https://teamcity.mesosphere.io/viewLog.html?buildId=103381&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:14


@Jan-E 1.6.0 was just stabilized on Gentoo a few weeks back, that's what I'm using.


lighten(@brand-secondary, 65%)


@gilligan what!?!? ;-)


damn u're really crazy ! - Even on LK 4.3.3 strict-aliasing is broken xD.
For sure much work? - Can u show an commit ? (just for learning purposes)
btw: did u also fix strict-aliasing on ROM-side ? - There is strict-aliasing enabled by default ... but it breaks strict aliasing rules like hell ^^


thanks for the feedback, do you plan to open a pull request for this @goulvench ?


Code style violation. The contents of these ifs should be in brackets and on new lines.


@Jan-E There is no critical bug fixes since 1.6.0 as far as I know.


could it be useful to add format section per each type to make it scalable?


revert please.


This check is same as for future, right?
I am not Lewis Carroll, but I think, that if we need future check after correct field settings check, so is minimal year check. One note - this check may be not after, but in couple with future check. In another side, these events - date in future and date too long time ago - cannot be in same time. Am I right?


TeamCity testProject :: build [Build 34](https://teamcity.midnighthub.com/viewLog.html?buildId=60&buildTypeId=TestProject_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:50


indent your lines properly


what is the reason of this deletion ?
does package create those files ? or we don't need it?


Happy to add a named contributors section. However, there have been so many individuals doing work on the app that I don't find that to be appropriate to update our LICENSE to reflect one PR.


To squash, I've tried :
git rebase -i  upstream/master
git push --force origin uniformizeLoading

Hope it fine this way.


Seems like ddoxTool is missing.


TeamCity testProject :: build [Build 35](https://teamcity.midnighthub.com/viewLog.html?buildId=61&buildTypeId=TestProject_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:41


Thanks, @cambell-prince.


remove the form tag


That looks like a major simplification, that is very interesting!
But we have to be very cautious with these changes, as there is a risk of regression.
I do not have the required knowledge with respect to autoconf to review that. My main questions are:
- is the new config strictly equivalent to the previous one?
- did you make sure there is no regression? Against which platforms have you tried the compilation with this new config?

Thanks for your contribution and help.


energy instead of energie ^^


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11289](https://teamcity.mesosphere.io/viewLog.html?buildId=103386&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:14


You'll only see it if you put an invalid version number in the schema, I suppose it could be confusing if you put something like 0.9 in, but we wanted to avoid having to update it too much for every version, or ending up with a huge list over time


format property may be useful only for string, in other cases it doesn't influence on result value, also there are quite a big value of different formats spec:
https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#data-types

so there may be quite big map with useless info

Does it make sense?


In short, it's just avoiding some files that doesn't handle strict aliasing to be compiled with this optimization.

c56ee4d bcmdhd: disable strict aliasing
1c8b005 libcrc32c: compile with -fstrict-aliasing
619e6ba init: apply strict aliasing
d32e898 net/wireless, Makefile: fixes after applying strict aliasing
c541950 General: strict aliasing


@tatsuhiro-t Indeed, no critical bug fixes. But @lkraav 's problem is edgy. Things like idle stream detection and client closing might help to solve his problem.


TeamCity testProject :: build [Build 36](https://teamcity.midnighthub.com/viewLog.html?buildId=62&buildTypeId=TestProject_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:44


TeamCity testProject :: build [Build 37](https://teamcity.midnighthub.com/viewLog.html?buildId=63&buildTypeId=TestProject_Build) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:07


TeamCity testProject :: build [Build 38](https://teamcity.midnighthub.com/viewLog.html?buildId=64&buildTypeId=TestProject_Build) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:05


Can this ever happen? Something similar is checked for in line 136.


Does serveCategory() not need this too? It also relies on `$uri`.


好的 @luiges90


I am not sure to understand the unit-test very well (or rather, I find it non-intuitive).

In my mind, the easy-to-understand, 'prototypical' unit-test should be something like (in pseudo-code):

```python

self.assertAlmostEqual(simu.robot.pose, [0.0, 0.0, 0.10, 0.0, 0.0, 0.0])

# case 1: normal time
simu.time.set_time_scale(1.0)
simu.robot.motion.publish({'v' : 1.0, 'w' : 0.0})
simu.sleep(1.0)
self.assertAlmostEqual(simu.robot.pose, [1.0, 0.0, 0.10, 0.0, 0.0, 0.0])

# case 2: accelerate time: 1 sec in reality is 2 seconds in simulation
simu.time.set_time_scale(2.0)
simu.robot.motion.publish({'v' : 1.0, 'w' : 0.0})
simu.sleep(1.0)
self.assertAlmostEqual(simu.robot.pose, [2.0, 0.0, 0.10, 0.0, 0.0, 0.0])

# case 2: slow-down time: 1 sec in reality is 0.5 seconds in simulation
simu.time.set_time_scale(0.5)
simu.robot.motion.publish({'v' : 1.0, 'w' : 0.0})
simu.sleep(1.0)
self.assertAlmostEqual(simu.robot.pose, [0.5, 0.0, 0.10, 0.0, 0.0, 0.0])
```

Does it makes sense, or am I missing something?


Why is srcfile an array?


I had to add handlers to window.go, otherwise a slider which is not in a container, like the vertical slider in the example, does not get the event.

From my point of view, it seems to work now.


TeamCity testProject :: build [Build 39](https://teamcity.midnighthub.com/viewLog.html?buildId=65&buildTypeId=TestProject_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:27


... if the dimensions and values of ...


> Godoc Added in a follow up. Define emptiness?

Uninitialized.  I think it would be caller error.


Codestyle violation: Content of if should be on a new line and in brackets.


Hm... Maybe you are right, but I'm still not sure what exactly may be wrong in this case. The message will be serialised just without subject and body. You'll get error if you try to send it without setting or loading a template after deserialization. And you still have a chance to complete initialisation after deserialization, if needed.

I'd say this is a good candidate for new test case, but I'm in doubt what exactly it should test because can't imagine any problem.


> btw: did u also fix strict-aliasing on ROM-side ? - There is strict-aliasing enabled by default ... but it breaks strict aliasing rules like hell ^^

I didn't touch this at all.. According to Archi, applied by google strict aliasing is handled properly despite of warnings printed by compilers.


Small nitpick FWIW: typo in commit message


TeamCity testProject :: build [Build 40](https://teamcity.midnighthub.com/viewLog.html?buildId=66&buildTypeId=TestProject_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:43


已Fix


Yes, I missed that. Thanks.


Well, since I'm nitpicking, technically this is not a refactoring like the PR claims ;-)


The idle stream detection is what we improved since 1.6.0.  We just makes detection strict, and it should mostly affect client side, and very edge case.
That said, experimenting latest version is always a good idea...


Rate of what could be considered erroneous behavior has reduced significantly with mod_h2 v1.1.0 and probably due to proper timeouts configuration. But it's not 0 for sure. There are still occasional moments during a workday where the browser gets stuck with "Waiting for response from ..." and you have to let some kind of a timeout expire before this tab or any new tabs are able to make a connection again.


TeamCity testProject :: build [Build 41](https://teamcity.midnighthub.com/viewLog.html?buildId=67&buildTypeId=TestProject_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:33


+100 for this kind of refactoring, the extra function name makes the code a lot clearer and promotes reusability.


Nice, this also ensures that dub has the same understanding of the json file.
Seems unlikely that SDL->JSON invents new fields, so the test should suffice.


deleted


newline


I'm not sure. `ambiguous` feels (potentially) too strong, since it overrides the where clauses, but doing nothing seems wrong because it will choose `Foo::Bar` (in the case of 0 candidates) as the normalized form and then, perhaps later, choose a concrete type (once inference variables resolve). I think the problem is that you are inserting this code into the wrong place: rather than changing the candidates, we should just adjust what we do when we are finished *choosing* a candidate.

In other words, if we settle on an impl where the type is marked default, we can then safely return `Ok(NoProgress)`, since that is as good as it's going to get.

Also, I'm not sure if this code here needs to worry about inference variables. That seems like it is trait selection's job. That is, at least as it's currently setup, trait selection will return ambiguity if inference variables mean that two impls may apply and it's not certain whether the more specific one applies yet or not, right? So, iiuc, that means that if we get back an `Ok` result here, we already know that this is the most concrete impl we will ever get, whatever happens with inference.


TeamCity testProject :: build [Build 42](https://teamcity.midnighthub.com/viewLog.html?buildId=68&buildTypeId=TestProject_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:01:40


this line needs to be removed  it is a test output


At least subConfiguration, x:ddoxFilterArgs, and x:ddoxTool are missing.


why did V make these things arrays, it makes it hard to add to them :V
at least they're public and nonfinal


class "Foam::tmp<Foam::gpuField<Foam::scalar>>" has no member "begin"
class "Foam::tmp<Foam::gpuField<Foam::scalar>>" has no member "end"
class "Foam::tmp<Foam::Field<Foam::scalar>>" has no member "begin"
how can we solve this problem?


Yup looks good to me - let's get it into next.


The example is wrong.
I will fix it.


Is the date-stamp the end of the filename - e.g. somefilename.datestamp?
If so you should stick a $ on the end of the regex - should make it more efficient.


Can you take it for granted, that every quote will only have one character? If so, why is `quotes` a `String` array instead of a `char` array?


Why `nozzle_size * 5`? Perhaps you could document this. Why is 5 nozzle sizes too long?


> remember this edge case

What about edge cases, there are actually just four cases when render may happen, and the rules are very simple. Template may be rendered on initialization if requested and possible, on send if requested, also on send if not rendered yet, and on explicit call to render. I think I have to add tests for all these and opposite cases to be sure behaviour will not change in the future. Thanks for the idea.


it's fixed


Ah flûte, la PR s'est faite dans mon dépôt ? Je pensais qu'elle arrivait sur le votre, je me suis fait avoir par l'interface de Github. C'est donc pour ça que ça n'avait pas été intégré :-)
Je modifie ça tout-à-l'heure, dès que je suis sur un écran de taille adaptée.
--
Goulven

> On 12 janv. 2016, at 1:29 PM, Frank Taillandier <notifications@github.com> wrote:
>
> thanks for the feedback, do you plan to open a pull request for this @goulvench ?
>
> —
> Reply to this email directly or view it on GitHub.
>


Might also be worth putting the dateformat in a constant somewhere so it doesn't have to be manually typed all the time.


These 2 cases produce the same error response.


@grimen because it's not installed globally, use `./node_modules/.bin/fonteditor-ttf2svg` instead of `fonteditor-ttf2svg`. All else seems to be good for me.


does it also fix https://bugs.php.net/bug.php?id=71243 ?


Test


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11290](https://teamcity.mesosphere.io/viewLog.html?buildId=103387&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:30


@jiru  That was fixed. Thank you!


By the way, HP EliteBook Folio **1020** G1 also have ForcePad.
This is not supported yet ?


Without introducing a dependency on EntityManager, the PartMaster must be detached from the calling class, which can introduce bug.
Using a clone version in the filter method could work, but clone can be dangerous to use (and we would have to implements cloneable on all the attributes of PartMaster).
A wrapper could do, but it would change the general architecture of all the PSFilter.
Not sure which solution would be the best.

Yes the algorithm causes a NullPointerException when the Product only have one revision and one iteration (not checked-in). What should be the behaviour ? The revision without any iteration ? Hiding the product ?


@justbur @syl20bnr You forgot to move this one :unamused:


why connect to local server on error ?


How about...
Specifies the direction the user has to swipe **in order** to navigate "forwards".


I believe this will break rand and seq bench tests when run without --no-verify since seq/rand bench still looks for "I'm the %16dth object!".


nice.


hum, what about just remove the .template file ?
while the ro share_init is supposed to give initial files. (ie remove the cp ... line.)


the changes on this file don't seem related to this commit


unrelated


The name of this commit should be add underscore to filename


great!


but isnt that the point of semver?
communicating breaking changes?


padding: 2px 10px 2px 5px

and for better alignment: vertical-align: top


this commit should not exists, it's the whole point of editing the history


package-private


static fields first


Please provide a long option `--non-interactive`, using those helps a lot in script maintenance.


wouldn't it be better if you had the tm numbers as the move's actual name instead? (e.g. 4 as tmSteelWing for example)


How come the flip back? You almost had this able to be built consistently cross-platform :)


You forgot an ending quote in
```
[dash.games.packages.form]
	title_label = "Pakket Naam
```


only the before element is needed (arrow on the left side)


Maybe time to remove the deprecated arg?


getBytes usually need an encoding


[Minor] Possibly need to change on ClassLoaderUtil.class


This should be the first step towards fixing #1799.
Whoever is working on the KDoc, can take this production and give it some latex code.


json的语法标准为

    {
        "key1" : value1,
        "key2" : value2,
        "key3" : value3
    }

逗号用于分割不同的key-value对。仅有最后一个逗号可以省略，中间的都不能省略。


token is not nullable


The table can be created in such place
https://github.com/hibernate/hibernate-orm/blob/fd1ff34f03265a681e8ca690eccdb6039c40f3fb/hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/ModelBinder.java#L3208-L3212
 and name will be equal to NULL.

In this case getTable().getNameIdentifier() returns NULL. The NullPointerException will be thrown in this place.


Oops, sorry.  I hadn't intended for those changes to get pulled by you.  I'm still getting used to working with GitHub.


Dave,

Today once I saw the toolbar "disappear" and could not find it anywhere. So I think there is still some buglet in this area. I was using the auto hide feature. After some panning around the chart I looked up and the little shrunken icon was missing and had to close and reopen O to get the toolbar back.


[Minor] It would be good to show at least method and parameters or run entered class.


Don't know tbh, its just what vaz does, though if shes ok with it you might be able to convert em to lists instead so other/custom materials can be added in addons


Do you have any javascript error in your browser log or console ?


It's a `Path` object, where this accesses only the file name without the rest of the path.


This is a very different level of abstraction. Please encapsulate the package search and version handling code somewhere else. This must already exist to for the non-interactive init command anyhow.


Neh, It's already [possible](
https://github.com/L0neKitsune/Botanical-Addons/blob/099a3dc6a2e5ae1f74c197210a15b51c270024f0/src/main/java/ninja/shadowfox/shadowfox_botany/common/blocks/material/MaterialCustomSmeltingWood.kt
).
On Tue, Jan 12, 2016 at 8:02 AM Jonathan Smith <notifications@github.com>
wrote:

> Don't know tbh, its just what vaz does, though if shes ok with it you
> might be able to convert em to lists instead so other/custom materials can
> be added in addons
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Vazkii/Botania/commit/a7000e8a47e15ee62665487003837f3c761dbf99#commitcomment-15396262>
> .
>


Ok, will add one asap.


Hi Erik,
Straight to your questions:
1) Active/Pressed states - These are the same states. The RadToggleButton and RadButton property for the active state is already named PressedUrl. Browsers, however, call it active state. You can see it in the browser console as well - http://screencast.com/t/iuRWj7wSnGJ. That being said it may be better for both names to present. I have added that.
2) Normal state. This is the default state of the button. It is configured in the first section of the article and therefore it is not necessary to present in the second one which is specific only for particular states.
3) Slug. The slug consists of the article's name which is Image. It is a common one and I think self explanatory.


Всё равно постоянно вываливается исключение. Стектрейс:
Traceback (most recent call last):
  File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/tornado/web.py", line 1443, in _execute
    result = method(*self.path_args, **self.path_kwargs)
  File "/home/sly/work/echoba/echsu/views.py", line 73, in get
    if board else self.send_error(status_code=404)
  File "/home/sly/work/echoba/toolz/base_cls.py", line 61, in render_template
    self.write(self.template_env.get_template(self.template).render(context))
  File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/jinja2/environment.py", line 989, in render
    return self.environment.handle_exception(exc_info, True)
  File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/jinja2/environment.py", line 754, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/home/sly/work/echoba/echsu/templates/thread.html", line 11, in top-level template code
    {{ thread.op().poster_name }}
  File "/home/sly/work/echoba/manage/models.py", line 201, in op
    return self.messages[0]
  File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/sqlalchemy/orm/attributes.py", line 237, in __get__
    return self.impl.get(instance_state(instance), dict_)
  File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/sqlalchemy/orm/attributes.py", line 583, in get
    value = self.callable_(state, passive)
  File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/sqlalchemy/orm/strategies.py", line 505, in _load_for_state
    (orm_util.state_str(state), self.key)
DetachedInstanceError: Parent instance <Thread at 0x7fe655fbe950> is not bound to a Session; lazy load operation of attribute 'messages' cannot proceed
ERROR:tornado.access:500 GET /b/1/ (::1) 37.20ms


Doesn't this exception kill the thread which processes new events? Therefore no new events will be processed anymore.


Too bad this was dropped. I was using it. Is there a way to achieve this with a custom router? (I tried and gave up.)


No log?


c'est quoi le bug du coup ?


Just had a feeling I don't like Gulp yet, over old-century Makefile :)


@raveit65: see all comments at https://bugzilla.gnome.org/642766 - it doesn't seem to be the complete fix...

Also no changes needed in GTK+2 build as selection during rename works fine.


This is a dirty hack, because I didn't find a way to determine the path of the OpenSSL configuration file. The OPENSSL_CONF environment variable does does not exist when a script runs from the command line. This is the OpenSSL example configuration file you can find it in xampp\apache\conf or here:
https://raw.githubusercontent.com/openssl/openssl/master/apps/openssl.cnf


was about to say "Java let you do what to an array", then I saw you guys made an extension method to expand the array. :stuck_out_tongue_closed_eyes:


@livec
Of course it would need more games, but before going 120M you must make sure the tuning works.
Or have some evidence that the idea is good.
If you tune a "bad idea" the end result will not be better after 120M games.

There is no problem using the tunable version. It takes less time to submit.

Not sure what happened here, is seems it converged very nicely to a "worst optimum". LOL.

SPSA does not work when too far away from optimum.
This is why people tries manual values before resorting to tuning.
But here we already have good start values, they are close to what master is using.

It is possible that we will need one set for mg and another one for eg. But let's try to keep number of parameters to a lower.

@joergoster @livec
Will try with smaller ck's


Good to know ;)

I wondered why my rails log is always empty :(


Wouldn't be better to escape the '|' character?  I'm mostly worried about human-readability of these messages in logs.


Hello, thanks for response, I go to your link but I couldn't find a way to contract with the dev team, could you please give me a little help? Thank you very much


I would recommend to go through **spring data jpa** [reference doc](http://docs.spring.io/spring-data/jpa/docs/current/reference/html/)  once before adding further @Query, spring data jpa doesn't required a @query to be created most of the time if its a simple query.


no i dont have. I also try in other web browser like Firefox, IE and Chrome.


Never mind it's in https://github.com/D-Programming-Language/dub/commit/14d2847c522a89406caa351d25d14623d4402e52.


@davezuko why remove host option ? Right now, I'm using docker in workflow so I need to expose server to 0.0.0.0 host. I can make a PR to add it back


@extremewaysback Sure, sorry for a non-working code sample.


@Memphiz

this part is fully viable for (perhaps) whole POSIX tree.
(just of course with proper home set as user home, not application home)


Название метода не информативно. Старайтесь называть методы так, чтобы сразу было понятно что они выполняют.


inconstancy of placement of setCenterCoordinate methods, moved method a bit lower


This removes fix from https://github.com/mate-desktop/caja/pull/285 - hope it will be ok :smile:


Small fix to manage deprecated vs new api methods


Also I should not tested the tuning results with a 30M numgames.
I was too optimistic...


Split into three test cases


@pellepelster Something must have gone wrong with this release, [it hasn't been uploaded to the Maven repo](https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/jenkinswalldisplay/). Could you please re-release it?


Do portals work yet?


Thanks :+1:


@vargaz What would be the final call on this ?


Why?


@davezuko please use extract-text-webpack-plugin ^1.0.1 .
v1.0.0 is broken

https://github.com/webpack/extract-text-webpack-plugin/pull/142


> Can you take it for granted, that every quote will only have one character?

The delimiters right now are guaranteed to be only one character. Any of: `` `identifier` ``, `"identifier"`, or `[identifier]`.

> If so, why is quotes a String array instead of a char array?

Because (without thinking about it very thoroughly), I couldn't think about a more suitable data structure than `EnumMap<SQLDialect, String[][]>` for:

```
SQLDialect -> {
     { main         start delimiter, alternative         start delimiter, ... },
     { main         end   delimiter, alternative         end   delimiter, ... },
     { main escaped end   delimiter, alternative escaped end   delimiter, ... },
       ...
 }
```

Now that I'm thinking about it (thanks for insisting), `char[]` with the `SQLDialect.ordinal()` as an index to the array might be more suitable...


Thanks.


Wouldn't that just be a pain when I change TMs again? Plus I just got around to retyping them all to use this tmlearn, really don't want to do that all again. The only issue here is that I did Charizard first, copy/pasted, and forgot to fix this tm afterwards.


This should be the only place that `inspect().active_queues()` is called, and this only once per request per celery app, due to the caching at `self.route_queues`.

It's _not_ the same as `inspect().active()`, as I'm using it to get the _queues_ on each worker, not the tasks. This allows me to look at all of the queues, even ones that the current proc doesn't know about, but still summarize them for easy usage.


I did ( d410066 ).


(sigh)

Because it turns out that we don't have tests for it. At least none that contain the string `@//` except for `test_load_skylark_from_external_repo_with_repo_relative_label_load` (but I don't find that convincing enough)

Trying having a label `@//:foo` in an external repository and verify that that label ends up pointing into the main repository. And if it does, tell me why, because the `isDefault()` call in `AbstractAttributeMapper#visitLabels()` implies that with this change, it should be resolved into the external repository, shouldn't it? This working as it should would be quite surprising.


Commenting on your spelling


Still deriving from `TestSuite` instead of `beast::unit_test::suit`


これは一体何をしてるんでしょう？


Erro de digitação


Well, this code isn't under ```GTK_CHECK_VERSION```. But the description of https://bugzilla.gnome.org/637424 looks like this code was excessive even in 2010, so I guess it's ok to remove it.


@levitte typo, CIPHR -> CIPHER


duplicate() just copy Byte[] ,but readerIndex and writerIndex still the same ? So when brocast ByteBuff, its readerIndex will be error?


Can you elaborate why such previous declaration right before the function definition would be needed?


Whats the plan? ;)

https://github.com/zhaomingliang/seotool/commit/c3ae575c512562146386370bba762c0fdb58028e#diff-18a1ad7e330400bb31aa33bd6e29a090L11


Thanks


I think you should add in the tracking issue instead of `None`


I see what the keyword does, but I have never seen anyone using the static modifier on the main function as there can anyway only be one such function be defined in all translation units linked together. It is thus not needed. Did you really get a warning from a compiler for "int main(int, char **)" ?


Also, we should think about how to add more targeted unit tests for this situation. I am thinking maybe some kind of `#[rustc]` attributes that will trigger special behavior. Have to think about it!


Isn't this just going to make it not compatible with my version of VS?


Thanks, I assume this is the only change of this commit that actually needs to be merged.


You can see how I'm using it in `__init__`:

```python
def __init__(self, app):
    super(CeleryInspector, self).__init__(self.get_status_task_counts)
    self.app = app
    self.route_queues = None
```

I need `KeyDefaultDict` because the values have to be resolved based on the task status that we're looking for.

The anatomy of a `CeleryInspector` is something like this, where it should be used like a dict that is already populated:

```python
{
    'active': {
        'celery': 200,
        'important': 4,
    },
    'reserved': {},
    'scheduled': {},
}
```

Thanks for your suggestion of `collections.Counter`. I had to go back and check, but it's perfect for that inner dictionary. I still need the `KeyDefaultDict` for the top-level though, which is why `CeleryInspector` inherits from it.


> In short, it's just avoiding some files that doesn't handle strict aliasing to be compiled with this optimization.

well, respect! quite a lot of work :-)

> I didn't touch this at all.. According to Archi, applied by google strict aliasing is handled properly despite of warnings printed by compilers.

Yeah i'm facing the same :-)

One more thing: what about -fpic -fpie flags in ROM ?? To be honest i can't find proper Documentation for those Flags if it's safe to use it or not.
But what is sure: adding -fpic to codina kernel will break W-lan and makes code size around 100kb bigger. It looks like Archidroid have removed those flags for TARGET .. but he is still using this for HOST:

https://github.com/ArchiDroid/android_build/blob/cm-12.1/core/combo/HOST_linux-x86.mk#L42


Oops, I got the second bullet wrong, nevermind that.


I can totally add a default `openssl.cnf` there.


Awesome, a nice maintainer :+1:  :+1:  :+1:


yaya, you are the best


Actually AST_Lambda extends AST_Scope and that extends AST_Block (which might have its own scope as well in some cases like the catch statement and use of let in es6) in the current code on master.

So for arrow functions later, we simply skip adding the arguments object as strategy for now (and to be done later), unless there has been changes to the scope stuff internally to UglifyJS.


@ondrej-hosak what do you think?


Looks good.


I don't know if this code is useless in GTK+2 as well... but ```else if``` branch should be left in GTK+2 just in case. Otherwise, you move ```gdk_window_clear_area``` into the first ```if``` branch, which changes the logic :smile:


Obviously, in most cases changing a TM would require editing everyone who knew the old move anyway, but like if I replaced a TM but it didn't involve changing everyone (like editing one of the more generic TMs, or swapping out between moves like Dragon Rage and Dragonbreath for example). I don't know, I just woke up, but it sounds like more trouble than it's worth for what was only a simple mistake.


why is this needed? The repartition module doesn't run blkdiscard.


Hi @chrisyoulden , thanks for using Cognition! I follow your commits, your redis work is really useful, I'll try to merge it with my repo. You may find it more useful to fork from the main development repository: https://github.com/iemre/cognition .


That's a good question, and I'm all for simpler switches. There are two reasons I chose to go this way:

1. It wasn't clear to me what the "right" choices were. You used all three, but I'd chosen to use only `active` and `reserved` in my own work, because I didn't expect any `scheduled` in my queues.
2. Each `inspect()` method that we have to call is expensive, and it gives the user the flexibility to lose some data to gain some speed.

If you have further insight on that, I'm open to it. It may be the right call to make it easy for a user, and just make a choice. I just wasn't sure what the right choice was.


@jkvim Please use `rebase` command to merge chunks of commits.

Read our [guides](https://github.com/weflex/weflex/blob/master/doc%2Fguides%2FCONTRIBUTING.md#step-4-rebase) for more details.

You could also look it up in your terminal:

```bash
man git-rebase
```


Bringing my sml-library_fork up to date with Don's master


остались кусочки )


@syl20bnr #4538

I don't think this binding needs to be tied to helm, since it's not a helm command. I put it in spacemacs-base in that PR


When you're using `-Wmissing-declarations` compiler expects functions to either have a declaration or be static/belong to anonymous context. This way it helps you to prevent global namespace being polluted causing linking conflicts when one accidentally forgets to ensure function is not visible outside of .c/.c++ file.

Now, gflags here are using quite nasty thing from this point of view -- defining function in one .cc file and then declares it in another one.

More proper way to solve this would be to add gflags_declare_flags.h, put `print_message` declaration there and include it from both `gflags_declare_flags.cc` and `gflags_declare_test.cc`.


Yes.


This reports lines starting with ` ` as empty line even though there is some content. Try `re.match(r"\S+", " a")`


It is used to include `blkdiscard` in the initramfs image. Probably the wrong place but we need this somewhere.


well, yes, sometimes it will be a single-prop format object, but it will be general, which is my main concern here


This isn't really a `main` function it's `GFLAGS_NAMESPACE::main` function which is being called from a "regular" main later in the file. I don't have a warning about `int main() {}` but i do have a warning about `namespace Foo { int main() {} }`.


Got it!


Ok, I see that relates to the other explanation. Was not looking at the code to realise it is not *the* main function.


@Bogdan-G I tried it enabled vs disabled, it has helped a bit. If you want to see this and the SyncHashMap in action, I can send you the IP for my server.

The grace period, stops Bukkit plugins like ClearLag from unloading chunks properly if the grace period is too high (> 100ms, I had it on 400 for some time, bad idea). I have it on 1ms right now and the server performs well.


reverted after reading bug filed by brett. however, many driver do not support method or do not use executor at all ! and worse as in bug report, mysql is abusing executor for setting network time itself !


Why is this needed? I generally don't want to bloat Nixpkgs with ad-hoc `enableStatic` package flags.

Note that the `makeStaticLibraries` stdenv adapter can be used to enable static binaries on a per-package basis already.


I'm wondering if you have the string which causes the failure. I'm not aware of any problems with the simple old `strip` method. It should work fine with unicode encoding...


Where did Logger go?


Why not use a private setter?


@Zeng0122 "english" should be uppercased as "English"


Thanks for the explanation :)


We need to check for `null` here. AvailableCultures might not yet be initialized. I recommend that you create it in the ctor instead of InitializeAsync.


These two lines I read out from the spec link to w3.org. Here's the relevant lines:

```10.1.2. multiply blend mode

```The source color is multiplied by the destination color and replaces the destination.

```The resultant color is always at least as dark as either the source or destination color. Multiplying any color with black results in black. Multiplying any color with white preserves the original color.


Put this on the same line as the UserControl and align all the xmlns on the same column.


E.g `libpcap.override { stdenv = makeStaticLibraries stdenv; }`


Странно очень, у меня все хорошо в css, я перезалью, может поможет (http://prntscr.com/9p5lhi)


Remove `this.`


Shouldn't the dot go within the `gettext`? ;)
```php
gettext("The IPsec tunnel configuration has been changed.")
```


Changing a locale something is not a breaking change. We do it all the time.

Iskren
On Jan 12, 2016 2:54 PM, "Manuel Ernst" <notifications@github.com> wrote:

> but isnt that the point of semver?
> communicating breaking changes?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/moment/moment/commit/c74a101d549b8b443b72d9a470839eaffea852c2#commitcomment-15396125>
> .
>


pour illustrer cette ligne, pourrais tu mettre en commentaire une ligne de log juste au dessus ?


Do we need to change anything on https://github.com/SecUpwN/Android-IMSI-Catcher-Detector/pull/714 after this?


修正ありがとうございます。
マージします。


Спасибо.
Поправил без слияния


Not working :name_badge:

```
8192
+ /retrieve_plex_download_url.py
Retrieving the latest Plex release for PlexPass Premium users...
Traceback (most recent call last):
  File "/retrieve_plex_download_url.py", line 70, in <module>
    print(retrieve_latest_download_url(login, password))
  File "/retrieve_plex_download_url.py", line 57, in retrieve_latest_download_url
    assert len(links) == 1
AssertionError

+ DOWNLOAD_URL=
Try retrieving the latest wernight/plex-media-server:

  $ docker pull wernight/plex-media-server:autoupdate

** Waiting for 30 seconds... **
```


Please merge this renaming into a previous commit.


@motezazer if you REALLY want to avoid confusion, please merge my pull request. It copies this readme to the release folder when you build it, and also leaves the .pdf docs out. They are too outdated, but if you'd rather they stay, at least move the readme to the release folder...


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#UpNw48CMRB-QjBHeG1mifg


Eu acho que deveria verificar o cpf , já que tem o parâmetro.
Ou o passo poderia ser : Given o atleta aparece na lista de atletas cadastrados


Should be done in a previous commit


ici aussi un commentaire qui pourrait montrer des exemples de ce que pourrait contenir match[2] serait les bienvenus


Yes, this is OK for gtk3.
I think the logic for gtk2 isn't correct because it fixes not the issue with black themes.
After merge i will test if we can use the same logic for gtk2 too, to fix https://github.com/mate-desktop/caja/issues/81 for gtk2


Add the server and v2v profiles to this test too


We must have a template that is the base file, ones must have an example file, for two reasons :
- Copy it to recalbox.conf if he wants to have the original file
- See the updated version if he is from a past version and modifications has been done to this file.

But as this file is not updated while upgrading, it should be a link to the recalbox.conf in share_init


maybe by clicking "contact" on the Openvibes website ?
http://openvibe.inria.fr/contact/

--
do it yourself
http://antoine.villeret.free.fr

2016-01-12 14:09 GMT+01:00 hoangtran355 <notifications@github.com>:

> Hello, thanks for response, I go to your link but I couldn't find a way to
> contract with the dev team, could you please give me a little help? Thank
> you very much
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/avilleret/openvibe/commit/f6179da7d575fc2caabf2e6fcd3c21fa6ba10f3f#commitcomment-15396393>
> .
>


You should include it in the 99reflash module where it's going to be used


Just checking in


Right. New PR on its way.


@urherenow Is it that difficult to wait @nastys ?!


Aha, I haven't known about the adapter. My use case is compiling User Mode Linux which requires them, but if I can achieve it without additional patches, all the better. I'll test and revert.


Adoption of new DUB versions is kinda slow, so I'd still keep it for the next version. Definitely needs to be removed for 1.0.0, though.


Please use `threadName` instead of `s` as being used in [`StandardExceptionParser`](https://developers.google.com/android/reference/com/google/android/gms/analytics/StandardExceptionParser).


Not sure it is a good name for this boolean


The monolithic recipe will include this one and the v2v one. Can you verify that the node does not end up with duplicated iptables rules? because both recipes will add these rule. Otherwise we should try to figure out a way to make sure rules are applied only once (I don't know if Chef or the iptables_rule already take care of this).


I think a comment here might be relevant.


Il faut corriger MDOS en MODS


It is when you aren't on the "inside" and don't know if he's actually working on it. @moetezazer made a change "to avoid confusion". A change that at this point nobody will ever see unless they come here. Whatever @nastys is doing has no bearing on adding the readme to the release folder, does it?


can be rewritten with .map()


This should be abstract in its top declaration.


Update: Now I am losing the tool bar anytime I change from ENC to CM93 chart source.


TODO: improve these regexs, using the following stolen from PHPCI (sorry Dan!)


looks like indentation was changed overall - sorry for that.

The relevant change is

    "dependencies": {
      "crypto-js": "^3.1.5"
    }

(i.e. `npm install crypto-js --save`)


also a refresh_number func has been added that refresh rows number when user removes a row using remove btn


That's just the core threejs library right? Vreffect isn't included in
that.
On Mon, Jan 11, 2016 at 11:17 PM Chris Van <notifications@github.com> wrote:

> this module/repo is pretty out of date. you may want to check out
> https://github.com/ngokevin/three-dev
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/msfeldstein/three-vreffect/commit/6e5c843b06c9740cc7917abcc69196975edf4f92#commitcomment-15389831>
> .
>


duplicated code from checkAuthorizationHeader?


well simple `set()` should do as booth support iteration.


comment?


Kernel-style spacing.


This ("watchPods(stop)" instead of "watchPods(oc)") gets fixed later but it would be good to fix it here in the original commit


This seems likely to break somehow at some point...


Why removing this test?


I think this is not the correct fix. Use negative value instead for the poseTransform.


Btw python2.6 supports set comprehension, so you can actually just replace the `[` on line 587 to `set(` and that should work.


ありがとうございます


* TODO: rewrite this as it is doing way too much and is very messy now.


// TODO: See if we can figure out a way to set this to 'AES-256-CBC' for new installs only


Do you think it's necessary to have the same tests in functional and unit testing? I think unittest for this corner case is enough.


Docstring. :scroll:


assumes you've got the `dev-nginx` project cloned one level up


I'm not sure what's the difference between these two functions (didn't look deep into it), but ```gdk_pixbuf_new_from_stream_at_scale``` is available in ```gdk-pixbuf``` since 2.14 (see the [doc](https://developer.gnome.org/gdk-pixbuf/2.31/gdk-pixbuf-File-Loading.html#gdk-pixbuf-new-from-stream-at-scale)).


Can't wait for new release with this exporter!


TDan...
Is this problem caused by this commit?  Can you temporarily revert it and verify?
Thanks
Dave


Good catch, will correct.


I suggest adding tests for `CALL` (empty string), `CALL @#$` (odd chars/unicode), `CALL      ` (whitespace), `CALL CALL foo` (weird composition), and give constructive error messages.


comment


Hello
I am working on Cognition on behalf of Simon Pither at SEOSS. I have copied him in on this email.
I pushed my commits recently but I believe the longer term plan is to provide you with a finished solution at a later date.
Simon can you comment please?
ThanksChris

Sent from Yahoo Mail on Android

  On Tue, 12 Jan, 2016 at 13:25, Ismail E. Kartoglu<notifications@github.com> wrote:
Hi @chrisyoulden , thanks for using Cognition! I follow your commits, your redis work is really useful, I'll try to merge it with my repo. You may find it more useful to fork from the main development repository: https://github.com/iemre/cognition .

—
Reply to this email directly or view it on GitHub.


Why not use: $(el).parent().find(..)
see line 93:$(this).parent().find(..)


Bu nedi


this mechanism for version checks needs to be improved, as is version 1.6 would fail this test, but that might be separate jira


good~~


De afgelopen paar jaar heb ik de gemeentelijke indeling al geupdate, en ben dat voorlopig van plan te blijven doen.

Met het script en bijbehorende documentatie (in `bag/db/data/README`) kunnen anderen het ook relatief eenvoudig (zonder met de hand de XML file aan te hoeven passen).

Omdat de Python implementatie een goede training voor mij is, zal ik dat toch ook doen (rekening houdend met beschikbare tijd).


ack


Hi Eugen,

can you open an issue on Jira providing a test? .

Thanks a lot.

Andrea

On 12 January 2016 at 12:58, Eugen Maysyuk <notifications@github.com> wrote:

> The table can be created in such place
>
> https://github.com/hibernate/hibernate-orm/blob/fd1ff34f03265a681e8ca690eccdb6039c40f3fb/hibernate-core/src/main/java/org/hibernate/boot/model/source/internal/hbm/ModelBinder.java#L3208-L3212
> and name will be equal to NULL.
>
> In this case getTable().getNameIdentifier() returns NULL. The
> NullPointerException will be thrown in this place.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hibernate/hibernate-orm/commit/534cd7dae82c860b5e07fcde7ad7738ac0f86a3e#commitcomment-15396216>
> .
>


It seems like the last few latest commit had broke the command 'A' which is mark all feed read, probably this commit or the previous commit.

When I pressed 'A', only the feed that is highlighted (the line I am on) is mark as read, not the rest.


Should be the user part of url fixed also?