Was going to use as an alternative to room class.


@Jiavan <- <-


I appreciate you giving feedback on code, but don't be an asshole about it.


yeah but then i sound serious


so is there a way how i can get rid of that ugly test parameter


ack


both layers are there in geoserver. We are working on moving them to the suggested position in the tree.


I need the proper commenting for the code.


this is a BC change, that is why it will go with 2.5.0 version release. there were a few changes to make extensions more concise. It cannot dictate how you name your columns there is [naming strategy](http://stackoverflow.com/questions/12702657/how-to-configure-naming-strategy-in-doctrine-2) now. Also in next release it will require >= php5.4. You should not point your composer to ***** (master) for this reason. it is not necessary for your project to migrate to 2.5.0. or change naming strategy to underscore for compatibility


Better practice would be to state the export list explicitly: `Main (main)`.


done


I have problem with the variable declaration.


The 204 response in this post shouldn't be "Checkpoint created", since it's restoring, not creating a checkpoint.


I need proper indentation


Will add a comment on the code. Just not sure this is the right place. In any case, better here than "nowhere".


actually not my job to search for you... https://github.com/wout/svg.js/commit/cf783fca1213d26b50bc07af0ca7e2b0f6385401

it was changed afterwards anyway so just take a look at the code...


hmm, nope, this assumption is not true, destroy_zend_class is called via zend_hash_destroy(class_table). which is not in reverse order... so, should we change that order?


Electric-Service-Refactor (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-62.97%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


i don't know the technicalities but from what i recall, that folder is set up as if clientlibs is tdstelecom root so that it'll pull from the dam without needing those extra "../". The old path was throwing an error and incorrectly looking for files in "etc/designs/". With the update, that error seems to have gone away and the banner-overlay is now showing up again.


we will update it with v4 .. thanks for mentioning


I thought you were against implicit constructor imports? ;) (It's OK with me.)


These variables were already being used, they need to be kept as legacy references for now or scss won't compile when they are used.


great, thanks!


unserialize returns FALSE if it fails to unserialize its argument. I've added an is_array check as well.


Not sure if the javac catches it, but IntelliJ gives a warning when it detects duplicate code. In this case, there are tests which are very similar, with only a couple of changes. I prefer to have them verbose, to avoid unintended consequences when changing a test.


Is that what's been screwing up my gh-pages?  Good to know!


Is removal necessary? don't think it is mentioned in the spec


Like, "Hello ${username}" ? It can be made, yes.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12221](https://teamcity.mesosphere.io/viewLog.html?buildId=109732&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:17


i believe this has the potential to create some hickups in skins wrt animations and such. i believe that's why the current unfocus/focus cycle is there - to (re)-trigger animations. not opposing the change or anything, but i'd look out for such.


the hash has to contain a "value" or "bind" key or it wouldn't be possible to bind a value in that case
currently the test does not ever bind NOTHING - so in the realistic scenario for this test with the concrete data that is there, my change is 100% compatible with this in mind
I don't see the need for error-handling in a test like this personally.

However it was not my intention to change your code just for the sake of changing it - I was trying to demonstrate a more elegant way of achieving the same goal - if you don't like it just revert it and I'll commit it with the old code in place.


If you do this (and @burnburn agrees with it), the class has to grow "name" and "message" attributes, since these are no longer inherited from DOMError.
This is the same issue as with ConstraintError in mediacapture-main.


It works with the following cords.

```coffee
transform: (code, {sourceMap} = {}) ->
  babel ?= require 'babel-core'
  options =
    sourceMaps: sourceMap ? false
  result = babel.transform(code, options)

  Promise.resolve({
    code: result.code
    sourceMap: result.map ? null
  })
```


This seems ok to me, it mimics the if made in the actual printNumber (IIRC) function for (not) supporting negative numbers. However, I don't think the & masking is needed, converting from int to unsigned long should, I think, do zero extension? Or perhaps you need to cast to unsigned int first? If we can drop the mask, the code becomes more portable, because it currently hardcodes the size of an int.

Any clue what the extra compilation size impact is for a program using this print function?

I'm also wondering if this commit helps at all for the char case? I would expect you would need a `print(char, int)` version looking like this int version as well? Because that is absent, I would expect printing a char with a base to either use the `print(unsigned char, int)` version, which should already do the right thing, or use `print(int, int)`, but then it will already be sign-extended and it is too late to fix it?


I don't think it worked though...I think that's why we had to overwrite it in Phase 1 with height:auto instead of just commenting it out.


registry is unused, remove


The short names are not great for readability.


indeed!


We'll see that in the future but we might add some other document types to this exception since for instance articles are not linked to areas (I think).


The `isEmpty()` case happens in case of coercion to type with different base.
Most common case is passing `NULL` (which is of type `UNKNOWN`) to function which declares parameter of type `VARCHAR(x)`.

I changed code to be more explicit to:
```java
        // in case of coercion to different base type we ignore arguments
        if (!declaredType.getBase().equals(actualType.getBase())) {
            checkArgument(actualParameters.isEmpty(), "Expected empty argument list for actual type with different base");
            for (TypeSignatureParameter parameter : declaredParameters) {
                if (parameter.isLiteralCalculation()) {
                    inputs.put(parameter.getLiteralCalculation().getCalculation().toUpperCase(Locale.US), OptionalLong.empty());
                }
            }
            return inputs;
        }

        if (declaredParameters.size() != actualParameters.size()) {
            throw new IllegalArgumentException(format(
                    "Number of parameters for typeSignature [%s] and actualType [%s] don't match",
                    declaredType,
                    actualType));
        }
```

Hope intention is more readable now.


@satya164 Here is the change to CameraRoll we were talking about.


ergh i tried to do a search and replace for them but couldn't find anything...sorry...


ack


Ideally we'd also get rid of md5 :)


This lock_release needs to be moved down at least 2 lines as the list traversal also needs to be protected with the lock. Technically it should be moved to the end of the function, as an intermittently released lock (between here and the new_list case below) results in a race condition when two processes try to add the same set_id at the same time, although that's very unlikely to happen.


should parameter_OS_SPECIFIC_SRCS be set to an empty list on non-windows toolchain?


As I've indicated in my commit message, RTCSdpError is not actually used anywhere in the spec; I've removed the inheritance from DOMException since it broke WebIDL validation, but my suggestion in #472 is simply to get rid of it.


@jastice oh true. I just searched Gringotts since someone asked me to fix the HCF support with their plugin and that was the first one I found.


Kalau ada yang keberatan dihapus saja itu line 53 :v:


@hb9cwp I have to fix a handful of problems with ESP implementation in the next days anyways, so no PRs for now please. But thanks for the pointer, I bookmarked this commit so I won't forget it,


Awesome. Looks great.

Verified on my linux machine using kill -9/2 and the samphub connection window, looks pretty solid.

Merge it.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12228](https://teamcity.mesosphere.io/viewLog.html?buildId=109742&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:53


I believe the original reasoning included the care about "null" and the cost of throwing an exception. As this is a user-facing component (REST endpoint), throwing exceptions at will might slow down the server, so, it's faster to check it this way.


Unacceptable! Will fix now


I'll add a comment with the reasoning to the code, but will not adopt the "valueOf" approach.


Electric-Service-Refactor (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-40.01%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


maybe a @PUT, then? http://stackoverflow.com/questions/630453/put-vs-post-in-rest


Maybe remove these members completely so they don't break code like kaguya::TableKeyReference test = state["test"];?


@barbaramartina it's not absolutely necessary to use it, but it's more robust and less error-prone than manually cleaning things up. [This blog post](http://echorand.me/site/notes/articles/c_cleanup/cleanup_attribute_c.html) gives an example, but here's how it could be used here:

``` objc
// Define a macro for ease of use (e.g. in NSObjectUtilities.h)
#define WMFReleaseOnExit __attribute__((__cleanup__(CFRelease)))

// .. use it to annotate variables that should be release when the scope exits
- (BOOL)urlIsReachableOverCellularNetwork:(NSURL*)url {
    SCNetworkReachabilityRef WMFReleaseOnExit reachabilityRef =
        SCNetworkReachabilityCreateWithName(NULL, [[url host] UTF8String]);
    // ... rest of method continues, no calls to CFRelease necessary
}
```


On 21/01/16 16:39, Ivan Novick wrote:
> @danielgustafsson @hlinnaka "prevents WAL logging when COPY is done in the same transaction
> that created it." will we get a performance boost for this?  It would be nice to advertise this in Greenplum 5 if its worthy

Hmm, how does this work with mirroring? In PostgreSQL, that optimization
only applies when WAL archiving is disabled. Do we enable WAL archiving
for mirroring, or do we use some other mechanism to capture changes?

- Heikki


Fixes #1710


@sklum as discussed


Is there a reason for using the Picasso library to load the *imageUri* into the *imageView* instead of using *setImageBitmap(bitmap)* once the stream has been decoded?


Fixes #1701


This looks much better :)


There is a test, but I added an explicit test for the bad request as well, just in case :)


Line too long.


@Chuck5ta - this strange targeting mode for AM is specific to classic only. For the others, your commit is perfect as is, because the order of effects changed. And yes, TBC and WoTLK need it


New-Fan-Object (EnergyArchmage) - x86_64-MacOS-10.9-clang: OK (2050 of 2050 tests passed, 0 test warnings)

 * 546 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


112083967_VentilatedSlab (Nigusse) - i386-Windows-7-VisualStudio-12: OK (2057 of 2057 tests passed, 0 test warnings)

 * 6 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Right, but I want user-friendly error messages, not exceptions being thrown to the user's face :)


PlantCompBaseClassAgain (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (2056 of 2056 tests passed, 329 test warnings)

 * 334 tests had: AUD diffs.
 * 329 tests had: BND diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


how was this number arrived at?


Fixed :)


An uninitialized variable is empty by default. Since nobody else is supposed to set this variable, it is fine. If someone does set it, we're in trouble but in order to be (maybe) bullet-proof, we would need to backup this variable's value and, at the end of this file, reset it to its previous value... I don't think it's worth it.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12223](https://teamcity.mesosphere.io/viewLog.html?buildId=109731&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:08:39


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12224](https://teamcity.mesosphere.io/viewLog.html?buildId=109730&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:08:54


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12220](https://teamcity.mesosphere.io/viewLog.html?buildId=109733&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:08:55


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12222](https://teamcity.mesosphere.io/viewLog.html?buildId=109734&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:08:55


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12225](https://teamcity.mesosphere.io/viewLog.html?buildId=109729&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:08:58


`next unless property.is_a?(NestingExposure)`


I'm not sure what value this comment adds, can you clarify?


New-Fan-Object (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Doing God's work, Jeff :+1:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12227](https://teamcity.mesosphere.io/viewLog.html?buildId=109737&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:09:40


unused - delete


Is `throwIO . ErrorCall` not just a fancy synonym for `error`?


Script to compare 2 set of images with Jaccard index, overlap and create the graphs and statistical results and result tables.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12226](https://teamcity.mesosphere.io/viewLog.html?buildId=109726&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:10:10


These break cases should not error out--they just mean we reached the end of the journal.


Not sure I get it: would this look better?
`... is a member of<br/>`
`<br/>`

The way it is, there a single empty line in the HTML: one of the br's breaks the line from the previous statement, the second breaks the empty line.


This can be `Debug`, rather than `Debugf`


>Ideally we'd also get rid of md5 :)

The current script is cheap and matches the upstream intention as good
as possible cheaply.

I agree it would be nice to convince upstream to switch to a newer hash
like sha256, but I have no idea how to approach that.

I also agree that it would be nice to make more of these into separate
builds, but I remember it sometimes breaks the build.


Is it necessary to check the `isNotModified` ones multiple times. As far as I can see it, this behavior is independent from the other test results, they could be in their own test method.


Unintended consequences :) I implemented this, as it makes sense.


Ok, if it's set up that way I'm down with it. Easier to remember that's for sure


yeah typo... it's being output and is not escaped yet, which means escaping. Or am I missing something?


TeamCity Gitversioner :: Build [Build 2](http://tc.phome.cz/viewLog.html?buildId=3&buildTypeId=Gitversioner_Build) is now running


You sure? It's there in the currently deployed RSS feed


Then instantiate it with Vec64f or Vec128f. But the other refactorings are more important.


TeamCity Gitversioner :: Build [Build -0.0.0-0-](http://tc.phome.cz/viewLog.html?buildId=3&buildTypeId=Gitversioner_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:34


TeamCity Gitversioner :: Build [Build 3](http://tc.phome.cz/viewLog.html?buildId=4&buildTypeId=Gitversioner_Build) is now running


TeamCity Gitversioner :: Build [Build 3](http://tc.phome.cz/viewLog.html?buildId=4&buildTypeId=Gitversioner_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:12


TeamCity Gitversioner :: Build [Build 4](http://tc.phome.cz/viewLog.html?buildId=5&buildTypeId=Gitversioner_Build) is now running


TeamCity Gitversioner :: Build [Build 4](http://tc.phome.cz/viewLog.html?buildId=5&buildTypeId=Gitversioner_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:07


TeamCity Gitversioner :: Build [Build 5](http://tc.phome.cz/viewLog.html?buildId=6&buildTypeId=Gitversioner_Build) is now running


TeamCity Gitversioner :: Build [Build -0.0.0-0-](http://tc.phome.cz/viewLog.html?buildId=6&buildTypeId=Gitversioner_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:07


What value is the polymorphism adding? Do we need this class?


tee hee ;)


See comment by @samccone at https://github.com/PolymerElements/polymer-starter-kit/pull/648#issuecomment-170601914
> I am in agreement with you @abdonrd @JosefJezek @klarkc , however it seems like a large number of the users of PSK have never used a tool like jshint or jscs and are very confused about what is wrong with their code.

> Due to the above fact, this generates a lot of noise and maintenance work for us on this repo. This is not a failure of our users, but rather a poor assumption on my part around how users will interact with our tooling.


@lwhinson I'm not married to "your own," but I wanted to emphasize that there are built-in environment properties and user-created ones. What do you think?

The tab *is* all caps.

I'm okay the proposed changes. Thanks!


Does the religious and specifically Christian connotation of Monasticism need some comment here (considering that Christianity is a patriarchal and hierarchical tradition- that might be at odds with the flatter organisational methods being developed by this group of people)


`std::make_pair(fqan,order)` (without the explicit types) should be correct and preferable. Can you try it?


Denkst du daran Variablen, Methoden und den Code an sich an den Styleguide anzupassen und sprechend Namen zu wählen?


No good for me as I run the compile in another task which posts completion via an event.. e.g Some code below. which returns before I have received the event passing the result back..

```coffee
  # method used by source-preview to see transpiled code
  transform: (code, {filePath, sourceMap}) ->
    config = @getConfig()
    pathTo = @getPaths filePath, config
    # create babel transformer tasks - one per project as needed
    @createTask pathTo.projectPath
    babelOptions =
      filename: filePath
      sourceMaps: sourceMap ? false
      ast: false
    # ok now transpile in the task and wait on the result
    if @babelTranspilerTasks[pathTo.projectPath]
      reqId = @reqId++
      msgObject =
        reqId: reqId
        command: 'transpileCode'
        pathTo: pathTo
        code: code
        babelOptions: babelOptions

    # transpile in task
    try
      @babelTranspilerTasks[pathTo.projectPath].send(msgObject)
    catch err
      console.log "Error #{err} sending to transpile task with PID #{@babelTranspilerTasks[pathTo.projectPath].childProcess.pid}"
      delete @babelTranspilerTasks[pathTo.projectPath]
    # get result from task for this reqId
    @babelTranspilerTasks[pathTo.projectPath].once "transpile:#{reqId}", (msgRet) =>
      @result = msgRet
```


fappa


:ghost:


@caduvieira A mudança de fallback para o editor se encontra em um Pull Request e está apenas aguardando um merge. https://github.com/servicosgovbr/editor-de-servicos/pull/518


ah, right you did. oops... misread the diff.


Forget that comment. I understand now that A, B and C are needed.


I never got a reply back wrt the problem you're trying to solve here. This is basically opening up a session fixation attack vector, and I'm struggling to understand why... presumably it *was* introduced for a good reason...?


Although you put the parenthesis probably in the right place according to how the expression is written, the meaning of the new code is not the same as the old. Have you run some tests on that function?


Oh, this should be interesting. Does it actually work now? Have you implemented a phantom limit, or is the tome a hardness of 1?

On a side note, I think it would be easier while debugging to set the name to be something along the lines of summoner.name + "\'s phantom..)


again, would you not like to allude to other (network inspired) paradigms


huh?


No, it's much better: its type is `IO a`, not `a`, so it works as a traditional exception, not a diverging computation.

Of course the type of the exception is not very interesting, but I think that's find in this context.


Why do you have a semicolon `;` after the call to `where()`? Wouldn't this cause a syntax error?


Thanks


To už vypadá docela k světu. :)


Yup! So either if a user has not had a role granted to them yet, or if you want to remove a user's privileges.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12229](https://teamcity.mesosphere.io/viewLog.html?buildId=109743&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:08:32


final public class ...


Wow, my mistake. That's what I get for working on something late in the day. I'll get this taken care of.


You will have a issue with that?


adding spaces now, eh?


Your second example above looks good but I don't see how your code manages to get a result of a promise?


@fneu if `original_result.affected_code == ()`? Will a `None` be appended to `source_ranges`?


It looks like all you need now is some animations. would you like me to merge and do that, or do you want to handle it on your own?


I templated the method to reduce the amount of code because the method is close to identical for Vec64f and Vec128f. Are you sure you want me to instantiate the method?


=> If you plan to use only ngeo, ...


Hi Pierrick,

thank you for your quick response!

could you point to me some documentation to help me understand the dss application ?

best regards..


Yeah, apparently that's the way the cool kids are writing it these days. :weary:


This should definitely be i18n-zed


It took me a while to understand why these methods exist, since the blurb is mostly *code*.
I would have slightly preferred:
- for the first one: "Compiles a shader provided as a std::string, but otherwise the same as CompileGlslToSpv(const char*, size_t, shaderc_kind, const char*)"
- for the second one:  ""Compiles a shader provided as a std::string and specified options, but otherwise the same as CompileGlslToSpv(const char*, size_t, shaderc_kind, const char*)"


This range is short by one: it you have a d6, it'll test that the result is in range(1,6) which doesn't include 6.


The increment should be done right here, not later with a separate lock acquisition. Otherwise there's a race condition when two processes add a node simultaneously.


Solves #21835 (https://github.com/owncloud/core/issues/21835)


Maybe there's a better name than `p1`? :)


@RuthCatlow I think it was arbitrarily selected as symbolic commitment and responsibility over the organisation -- it was initially £1000, but some felt because that was equal to month of their income it was prohibitively high, so we lowered it.

Should be noted that this comes on commitment by the org never to take on debt.


await Runtime.RunInMainThread?


Shouldn't we add this in the CONST_vars.yaml?


This change breaks my code: the reason is because I give aliases for tables such as

    ... FROM users AS u ...

but now this gets quoted incorrectly like this

    ... FROM `users AS u` ...

instead of

    ... FROM `users` AS `u` ...

The solutions might include 1. supporting aliases, and 2. making quotes optional.


why can't you
a) borrow money
b) charge a property as security for money borrowed or security for a grant


В проекте теперь будет уже 3 класса с почти одинаковым функционалом. Лучше изменить и переиспользовать.
См de.plushnikov.intellij.plugin.extension.LombokNonNullAnnotator.RemoveNonNullIntentionAction
de.plushnikov.intellij.plugin.extension.LombokFinalAnnotator.RemoveFinalIntentionAction
Возможно еще какие-то.


:wink:


Will `_WIN32` try compile src/mongo/util/processinfo_linux.cpp? Do we need the `|| defined(_WIN32)`?

Some BSD variants also has mallinfo:
http://www.freebsd.org/cgi/man.cgi?query=malloc&apropos=0&sektion=3&manpath=SunOS+4.1.3&format=html

Maybe add a configure check for it? Something like:
````diff
diff --git a/SConstruct b/SConstruct
index e7f518b..cc8d297 100644
--- a/SConstruct
+++ b/SConstruct
@@ -1866,6 +1866,9 @@ def doConfigure(myenv):
     if conf.CheckFunc('strnlen'):
         conf.env.SetConfigHeaderDefine("MONGO_CONFIG_HAVE_STRNLEN")

+    if conf.CheckFunc('mallinfo'):
+        conf.env.SetConfigHeaderDefine("MONGO_CONFIG_HAVE_MALLINFO")
+
     conf.Finish()

     # If we are using libstdc++, check to see if we are using a libstdc++ that is older than
````

Or maybe:

````diff
diff --git a/SConstruct b/SConstruct
index e7f518b..44483f7 100644
--- a/SConstruct
+++ b/SConstruct
@@ -1866,6 +1866,9 @@ def doConfigure(myenv):
     if conf.CheckFunc('strnlen'):
         conf.env.SetConfigHeaderDefine("MONGO_CONFIG_HAVE_STRNLEN")

+    if conf.CheckFunc('mallinfo'):
+        env.Append(CPPDEFINES=["HAVE_MALLINFO"])
+
     conf.Finish()

     # If we are using libstdc++, check to see if we are using a libstdc++ that is older than
````


er, yeah. I was thinking the expected output wouldn't need escaping. but you're right: escape all the stuff! :smile:


The perils of copying and pasting. :)


good point, fixed here: https://github.com/hall-lab/svtyper/commit/faecbc5b52715b1dc2bbffc8c13c80b1389838b2


nice spam :fappa:


можно избавиться от вложенности


Should remove this block from `LICENSE.rst` too.


I'm fine with the change, I just pointed out there are some differences, though maybe not really important.


In that case I’d appreciate some enlightenment :-)

(I just used the name from [documentation on MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace).)


Is there a reason to have this int dynamically allocated? From what I see in the code, a static int on the heap would do just fine. Not really a problem, just wondering.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 220](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=700&buildTypeId=XbimEssentials_XbimEssentials) is now running


Your numbers and letters are out of order!


I agree with "hostParam" to make compulsory. But I don't think we should make it compulsory to provided "user" and "password" as well. For example, some databases can be accessed without user/password, such as https://education.cloudant.com/movies/.   So it order to avoid errors, you can write something like:

val user = parameters.getOrElse(CLOUDANT_USERNAME_CONFIG,sparkConf.get(CLOUDANT_USERNAME_CONFIG, null))

Then user will be set to null, and we don't need to authenticate.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12230](https://teamcity.mesosphere.io/viewLog.html?buildId=109744&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:36


что если добавить javaFx как библиотечку и не использовать константы?


But this is article 6 - circular? is this a mistake


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12231](https://teamcity.mesosphere.io/viewLog.html?buildId=109747&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:08


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12232](https://teamcity.mesosphere.io/viewLog.html?buildId=109748&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:04:16


PlantCompBaseClassAgain (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2084 of 2088 tests passed, 325 test warnings)

 * 334 tests had: AUD diffs.
 * 329 tests had: BND diffs.
 * 4 tests had: ESO big diffs.
 * 1 test had: EIO diffs.
 * 1 test had: Table small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.81%25-yellow.svg)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26186/testReport/) for this commit**


Start simple. If we were testing git, that would be correct. But we aren't. We are testing _read_ operations on git repos. Since the repo is not changed, we don't need to clean up and setup every time.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 220](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=700&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:37


Нужно больше переносов)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26187/testReport/) for this commit**


I vote for removing both `<br/>`s.

Checking in Eclipse's built-in JavaDoc viewer, I can say that there is some vertical gap between "is member/owner of." and "Returns:" both with `<br/><br/>` and without `<br/><br/>`.

Although the gap with `<br/><br/>` is bigger, I find the one without `<br/><br/>` sufficiently big.

End of treaty on `<br/><br/>` :)


- [ ] `// (1)` はメソッドにつけた方がよい


Неужели такой строки до сих пор нет?


I agree with @akien-mga, but this still is a good idea. Damn, those bats are amazing !


мож как-то переименовать метод, а то два метода для нахождения getterName


TeamCity ArachNGIN :: Build [Build 1](http://tc.phome.cz/viewLog.html?buildId=7&buildTypeId=ArachNGIN_Build&guest=1) is now running


PlantCompBaseClassAgain (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2046 of 2050 tests passed, 325 test warnings)

 * 331 tests had: AUD diffs.
 * 329 tests had: BND diffs.
 * 4 tests had: ESO big diffs.
 * 1 test had: EIO diffs.
 * 1 test had: Table small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.8%25-yellow.svg)


`error_key`, `key` come to mind...


TeamCity ArachNGIN :: Build [Build -0.0.0-0-](http://tc.phome.cz/viewLog.html?buildId=7&buildTypeId=ArachNGIN_Build&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:23


TeamCity ArachNGIN :: Build [Build 2](http://tc.phome.cz/viewLog.html?buildId=8&buildTypeId=ArachNGIN_Build&guest=1) is now running


А точно средствами системы эти строки получить нельзя? Вопрос к @yunikkk


Вс


Thanks @wql7013! I used this change on a project of mine and it worked perfectly!


ok please add the relnotes as request in the comment to the pull request and I'll merge it


TeamCity ArachNGIN :: Build [Build -0.0.0-0-](http://tc.phome.cz/viewLog.html?buildId=8&buildTypeId=ArachNGIN_Build&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:25


sorma changed


Problem with Runtime.RunInMainThread is that if this method is called from UI thread it will not schedule to be execute later on UI thread but it will just execute...

Problem with this is GenericAlert() is blocking which means `await task.ConfigureAwait (false);` will not be called...


This is why <3 Windows Forms, Invoke and BeginInvoke...


The block can't be removed from LICENCE, because it's still in `operator.py`. But LICENCE should be updated.


:+1: nice catch, this is way better!


The room class will have to be removed as Prof. Watt indicated it was not necessary. I have incorporated what it would have been used for into the TimetableGUI class.


код как неразрывное полотно, может его поделить на пару логических блоков?


Is this not redundant from the previous status?


Ah, right you are!


ahahah ⛄


Странное сообщение. Я не пойму, что мне надо исправить, и зачем возвращаться в простой режим.
И "еЁ" же)


@stevekuznetsov diagnostics does the same validation that was previously done by oadm validate (literally just reports the same errors/warnings from the existing code). I wouldn't call it in-depth but it can be expanded as needed.


Oh cool, I was just looking into this :smile:


- [ ] ""/login"にアクセスされたら、"は不要。＋ `ViewResolver`を絡めた話はこちらに追加してください。


PlantCompBaseClassAgain (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (2056 of 2056 tests passed, 329 test warnings)

 * 334 tests had: AUD diffs.
 * 329 tests had: BND diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I don't think either of those will quite do what I want for this test. I want to wait until the coro is done, but `test` is not expected to return true immediately after the coro finishes. Under the hood, the processing of `tx` spawns another job that also has to finish before `test` will finally succeed, which doesn't take long, but may take longer than the coro itself. If there's a better way to do that here, I am happy to improve the test.


Dammit, and I just deleted the One commit, lol

Thanks H0zen. Je t'aime, baby :-)


Эта строка явно не нужна


The removal i had in mind was in case one wanted to move a module to another time slot or room and not removing it entirely from the timetable. I have implemented it and will upload it in a bit.


It's described in the `get_course_blocks` docstring.


PlantCompBaseClassAgain (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


need help enquiry number: 21255 87547 email : armandociobanu82@gmail.com please email me master key for 3ds thanks


@dmmiller Thanks.


- [ ] `<mvc:view-controller>` に対するコード説明は特に必要ないと思います。


@maxbridges In that case, I think it's OK to use "your own." We could also say something like, "You can create environment properties and add them to a stage from its ENVIRONMENT PROPERTIES tab." However, I don't know if that gets the message across as clearly as "your own" does.


Please see following.

[Promise.resolve() - JavaScript | MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/resolve).


My mistake. Yes I missed a line!! I have modded my code and it now works.


This should test for status == ``UserLimit`` now


Could we do fuzzy searching with `fuzzywuzzy` or something else instead?


@jlipps Thi should probably not say Sauce Labs right? Or is this the thing where it needs to have an actual company behind it or it's not enforceable?


Можно, но там формат различный на различных платформах, поэтому отдали в перевод строчки


Checkmarx scan results 21 Jan 2016 18:30 UTC +02:00

High
Medium
Low
Info

New
4
3
4
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

1a27bf29aaa056626854f6d0da36662863b45f3c	@cxehud


а это зачем вообще?
таки нужны коменты


Sorry for the trouble. Thanks for the very quick turn around.

FYI my code

```coffee
# method used by source-preview to see transpiled code
  transform: (code, {filePath, sourceMap}) ->
    config = @getConfig()
    pathTo = @getPaths filePath, config
    # create babel transformer tasks - one per project as needed
    @createTask pathTo.projectPath
    babelOptions =
      filename: filePath
      sourceMaps: sourceMap ? false
      ast: false
    # ok now transpile in the task and wait on the result
    if @babelTranspilerTasks[pathTo.projectPath]
      reqId = @reqId++
      msgObject =
        reqId: reqId
        command: 'transpileCode'
        pathTo: pathTo
        code: code
        babelOptions: babelOptions

    transpilePromise = new Promise (resolve, reject ) =>
      # transpile in task
      try
        @babelTranspilerTasks[pathTo.projectPath].send(msgObject)
      catch err
        console.log "Error #{err} sending to transpile task with PID #{@babelTranspilerTasks[pathTo.projectPath].childProcess.pid}"
        delete @babelTranspilerTasks[pathTo.projectPath]
        reject(err)
      # get result from task for this reqId
      @babelTranspilerTasks[pathTo.projectPath].once "transpile:#{reqId}", (msgRet) =>
        @result = msgRet
        resolve(msgRet)
```


updated.


@deads2k what is a more robust way of breaking this file?


I sure hope this fade in time is optional!


done.


Thanks a lot :) Is this file already available from the main wiki? I
would like to pass it along to some interested people in another fcc
github issue but not sure how to go about that :)

Florian


bnvnv


можешь словить NPE


I think this should be fixed by the latest commits in master: https://github.com/Fuzion24/JustTrustMe/commit/482d1166d1ebb8ffce2ab6e771469b6ed6ce61ea https://github.com/Fuzion24/JustTrustMe/commit/8bcd193afb84d9f98e1c477e744620b0af6704a2


fixed.


:smiley:


Fair enough, will change to `key`.


Create an api helper for isimport->is


http://stackoverflow.com/a/22917902/2710074 perhaps?


This doesn't just suck, but is highly illegal and is breaking the ebuild for users. `QA_PREBUILT` is an optional portage-only variable. The quickest fix is just to remove that line altogether.

```
cave@1453393528: [WARNING e.ebuild.metadata.unusable] No usable metadata for 'dev-lang/ghc-7.8.4::haskell'
cave@1453393528: [WARNING e.ebuild.postload_eapi.mismatch] In thread ID '30869':
  ... In program cave resolve -c world -km -Km -R daily -C if-satisfied -l */* -r */*:
  ... When resolving and adding dependencies recursively:
  ... When adding dependencies for 'x11-wm/xmonad:0::(install_to_slash)' with 'x11-wm/xmonad-0.12:0::installed':
  ... When handling dependency '>=dev-lang/ghc-7.4.1:0/7.10.3=':
  ... When finding slots for '>=dev-lang/ghc-7.4.1:0/7.10.3=':
  ... When determining resolvents for '>=dev-lang/ghc-7.4.1:0/7.10.3=':
  ... When finding best version of each package from packages matching >=dev-lang/ghc-7.4.1:0/7.10.3= (ignoring additional requirements) with filter all matches filtered through supports action install filtered through not masked filtered through slot is 0:
  ... When generating metadata for ID 'dev-lang/ghc-7.8.4::haskell':
  ... When loading generated metadata for 'dev-lang/ghc-7.8.4::haskell':
  ... Post-source EAPI 'UNKNOWN' does not match pre-source EAPI '5', treating as unknown                                                                                Deciding: 165 steps, 12 metadata (12 haskell) cave@1453393528: [WARNING e.ebuild.cache_failure] In thread ID '30869':
  ... In program cave resolve -c world -km -Km -R daily -C if-satisfied -l */* -r */*:
  ... When resolving and adding dependencies recursively:
  ... When adding dependencies for 'x11-wm/xmonad:0::(install_to_slash)' with 'x11-wm/xmonad-0.12:0::installed':
  ... When handling dependency '>=dev-lang/ghc-7.4.1:0/7.10.3=':
  ... When finding slots for '>=dev-lang/ghc-7.4.1:0/7.10.3=':
  ... When determining resolvents for '>=dev-lang/ghc-7.4.1:0/7.10.3=':
  ... When finding best version of each package from packages matching >=dev-lang/ghc-7.4.1:0/7.10.3= (ignoring additional requirements) with filter all matches filtered through supports action install filtered through not masked filtered through slot is 0:
  ... When generating metadata for ID 'dev-lang/ghc-7.6.3-r1::haskell':
  ... When running an ebuild command on 'dev-lang/ghc-7.6.3-r1::haskell':
  ... Could not generate cache for 'dev-lang/ghc-7.6.3-r1::haskell', stdout says '' and stderr says '
!!! ERROR in dev-lang/ghc-7.6.3-r1::haskell:
!!! In useq at line 30
!!! Flag 'binary' is not included in IUSE_EFFECTIVE=""

!!! Call stack:
!!!    * useq (/usr/libexec/paludis/5/list_functions.bash:30)
!!!    * use (/usr/libexec/paludis/0/list_functions.bash:25)
!!!    * source (/var/paludis/repositories/haskell/dev-lang/ghc/ghc-7.6.3-r1.ebuild:125)
!!!    * ebuild_load_ebuild (/usr/libexec/paludis/ebuild.bash:404)
!!!    * ebuild_main (/usr/libexec/paludis/ebuild.bash:657)
!!!    * main (/usr/libexec/paludis/ebuild.bash:698)

diefunc: making ebuild PID 31602 exit with error
die trap: exiting with error.
```


TeamCity Gitversioner :: Build [Build 6](https://tc.phome.cz/viewLog.html?buildId=10&buildTypeId=Gitversioner_Build) is now running


I'll keep "your own," then. Thanks! @lwhinson


TeamCity Gitversioner :: Build [Build master-1.0.1-4-g8ad3c7d](https://tc.phome.cz/viewLog.html?buildId=10&buildTypeId=Gitversioner_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:14


TeamCity ArachNGIN :: Build [Build 3](https://tc.phome.cz/viewLog.html?buildId=12&buildTypeId=ArachNGIN_Build&guest=1) is now running


TeamCity ArachNGIN :: Build [Build master-1.0.1-48-gd652bd1](https://tc.phome.cz/viewLog.html?buildId=12&buildTypeId=ArachNGIN_Build&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:26


> isimport->is

meant is->isimport


Why it's not allowed to cancel a request that has a numeric timeout?


typo in stateparams was the error


There are currently t**wo** configuration**s** available


We are currently using it when the app starts to refresh the state of all the geofences. In our Android project for example, we call this method after starting the app and also confirming location services are available. But the thought was this could be used for any work a user might want to do after confirming the app has started and location is available and want to perform some additional logic for geofencing - maybe to kill some existing geofences on app start or perhaps delaying geofence logic until the app has confirmed we are in a state that we can do geofence work.


If I'm not mistaken, the main reason we always go through getNetworkResourceProviderClient is to guarantee we have a valid token. Scott can comment more on this though.


Just thought it would be nice if every function would be independant on the other and always has the same effect. Thus i initialized and cleaned up every time. so in case i remove a function from the code, and the test function with it, the rest of the tests still behave the same. what do you think?


Cool, +1 then.


no probs go a head


please fix the typo: Intent -> Indent


Looks good so far, but is incomplete. Note the requirements:
_Once the user enters in a number, and a character, the user can either then just press the enter key **(as long as the cursor is in one of the input fields)**, or click a button that is labeled "Grow your tree" and the tree should be shown in the console._


Ok, pensé que habías dicho que usara http://localhost:8081, las refactorizamos entonces.


Busted rebase?  You remove this line in 0c912a0c, so it's not really a problem, but it would be nice to remove it from this commit too.  On the other hand, this PR has already absorbed lots of polishing, so no worries if this is too minor to fix ;).


No probs go a head


Looks good -- I'm going to move some of this into a Containers folder once this is merged in unless you object.


Build artifacts should be in ./dockerfiles/run/guice/destination


разбить бы на разные блоки


Why hard code this?


Tab formatting in actor.h looks a little off compared to the rest of the file, and also is the shortening of the DECORATE flag name necessary? +INVERSEPLAYERVIS looks clearer and doesn't take that longer to type...


Just made it live...
Not sure it's been linked/referred to anywhere, but it's definitely searchable now.
or you can see it [here](https://github.com/FreeCodeCamp/FreeCodeCamp/wiki/accessibility-101)

it may help if you add `a11y` as a keyword somewhere, just to easy finding it.


Where do I put it then? It's temporary anyways, until we have prerestore/postrestore in nuget.


ну может и норм, но как-то громоздко (только ИМХО, код стайлу вроде как не противоречит)


47 and 48 should be indented inside the function


I did a git pull last week, and tried running this script on one or two other templates, but kept getting errors due to missing links. Do you have a committed template for which the script is working? (I may have missed something obvious)


As noted in the last PR, `mimecontent` is not needed here.


это скорее collect или assemble


Fucking AWESOME, keep it up!


    OK, I have converted the PKCS11_ecdh_derive to
      pkcs11_ecdh_derive_internal so it is not part
      of the libp11 API but can be used by the engine, and does not
      expose any of the PKCS#11

      I rebased the patch onto master 90387131 So
      I think the patch is ready. Please have a look.

    On 1/20/2016 1:59 PM, Michał Trojnara
      wrote:

      Yes, we do need an internal function for raw key derivation. It
        probably does not need to be as complex as PKCS11_ecdh_derive().
      —
        Reply to this email directly or view
          it on GitHub.

    --

 Douglas E. Engert  <DEEngert@gmail.com>


@ahashibon , even though we had fixed the other bug in this spot. there was another that we didn't see.   Like you mentioned the other day, this whole individual variables for all the properties should be reworked to an array.


En la línea 3 cambiaría del por de


Clarified the docstrings in 5082e7a :)


New-Fan-Object (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (956 of 956 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.85%25-green.svg)


As noted previously, these changes represent a change to existing behavior and may cause problems in production flows.


PsiTypesUtil.getPsiClass(psiField.getType()) - can return null

и это действительно может произойти, может стоит убрать возможность того, что плагин будет падать с NPE?


Checkmarx scan results 21 Jan 2016 18:42 UTC +02:00

High
Medium
Low
Info

New
8
9
13
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

1418a1bd24357501b052075f1cdde1ca89c45e27	@dortal


Well, IIRC we don't promise that initialization happens in source order, but we could. It would certainly make things better for lazy properties.


Oh good. That's what I thought we talked about before. I misunderstood Sam then.

Sent from my iPhone

> On Jan 20, 2016, at 10:42 PM, cshenry <notifications@github.com> wrote:
>
> I agree with this, but that’s why we have an index on the compartments.
>
> So really, we allow 26 “types" of compartments, as we use a single letter to represent compartment types. But an actual instance of a compartment has a “type”, and an “index” (e.g. c0 - cytoplasm “0”, p1 - periplasm “1", g100 - golgi “100”).
>
> So we can have an unlimited number of compartments in the system right now, but only 26 distinct types.
>
> It would be a substantial amount of work to allow multi-letter compartment types, and I have yet to see the compelling justification for why more compartments are needed. Maybe someday we should address this, but there are so many other things that should be higher priorities right now.
> On January 20, 2016 at 5:53:07 PM, chian (notifications@github.com) wrote:
>
> Just as a thought, in the near future, community modeling will need more than 26 compartments.
>
> Best,
> Nick
>
> Sent from my iPhone
>
> > On Jan 20, 2016, at 5:12 PM, cshenry <notifications@github.com> wrote:
> >
> > Multi-letter compartments are extremely problematic across the board. Assumptions of single-letter compartments are everywhere in the code and in our web visualizations.
> >
> > Plus, I really just can’t believe we need more than 26 compartments to capture a euk… nor do I think we really have the ability to adequately and accurately assign reactions to 26 compartments.
> >
> > On January 20, 2016 at 4:20:02 PM, samseaver (notifications@github.com) wrote:
> >
> > @ctseto I copied and expanded your compartment list for the human template. You'll see there's a whole bunch of sub-compartments, I will not be using many of these, for now, but they arose out of conversations with others who are focused on very specific parts of cellular metabolism.
> >
> > This list of compartments pretty much covers cellular biology, so I don't see any need to add more with the exception of abstract compartments for the sake of modeling itself.
> >
> > Couple of points, the plastidial stroma and the mitochondrial matrix is where the majority of the reactions take place, and so, at least in my plant models, these "spaces" default to the general plastid and mitochondria spaces.
> >
> > @cshenry Can't remember if you said otherwise, but as far as I understand it, we're using single letters to capture compartment identity. We may want to consider moving away from this to a 2 or 3 character system that covers a wide range, in a future iteration of ModelSEED, but in the meantime, yea, anyone can declare their own list of compartments, so its not a big deal.
> >
> > —
> > Reply to this email directly or view it on GitHub.
> >
> > —
> > Reply to this email directly or view it on GitHub.
> >
> —
> Reply to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub.
>


Sorry for that old comment, but I missed that method `dataForTaggingRuleFailed` which seems unused. Did you forgot to commit something?


Well, I built the gram positive and gram negative templates with it… so those worked at one time or another.

--
Chris Henry
Sent with Airmail

On January 21, 2016 at 10:52:23 AM, samseaver (notifications@github.com) wrote:

I did a git pull last week, and tried running this script on one or two other templates, but kept getting errors due to missing links. Do you have a committed template for which the script is working? (I may have missed something obvious)

—
Reply to this email directly or view it on GitHub.


Credits to @halaszk  for commit orgian :https://github.com/halaszk/Perseus-halaszk-universal5433/commit/c9345bc8d96597aa5726766cd3c3c320821607a3

Details kindly see
UpInTheAir commit

GPU: added 800 Hz OC step and other locked GPU freqs : https://github.com/UpInTheAir/SM-N915/commit/21a2c307ae850e5083cb7772ee6d4c7dfa6efd8e


test


Typo?


This is nicer than before :)


Gram positive, gram negative, and microbial templates worked for me.


ditto


test again


Some classes like PointerIntPair allow you to substitute custom PointerLikeTypeTraits as a template parameter. This is sometimes useful, and would have allowed us to just special-case the instances that use types while they're forward-declared. PointerUnion doesn't have this flexibility, though, so we actually need to make the PointerLikeTypeTraits work. (Or declare a wrapper type, like Michael did, but it sounds like we're not going that way.)


Try loading and then saving a world in the program and let me know if it will still run.
And try filling some blocks too btw :D


Thanks for the explanation @benrudolph .
So just to confirm that I understand the different proposals correctly, in my proposal, a form with two questions, with one included in the export would look like this:
```python
exportable_items = ExportableItems(
    items=[
        ScalarItem(
            path=["form", "q1"],
            label="Question 1",
        ),
        MultipleChoiceQuestion(
            path=["form", "q2"],
            label="Question 2",
            options=["yes", "no"]
        )
    ]
)

export_configuration = ExportConfiguration(
    tables=[
        TableConfiguration(
            table_name="My awesome form",
            columns=[
                ExportColumn(
                    item=exportable_items.items[1],
                    display="Header for Question 2 column"
                    expand_column=False
                )
            ]
        )
    ]
)
```

I think you are suggesting that this should be modeled as follows:
```python
export_configuration = ExportConfiguration(
    tables=[
        TableConfiguration(
            items=[
                ScalarItem(
                    path=["form", "q1"],
                    label="Question 1",
                ),
                MultipleChoiceQuestion(
                    path=["form", "q2"],
                    label="Question 2",
                    options=["yes", "no"]
                )
            ]
            style={
                (['form', 'q2'], 'multiple_choice'): {
                    "display": "Header for Question 2 column",
                    "expand_column": False,
                }
                # maybe includes keys for items not included in the export as well?
            }
        )
    ]
)
```

I think the `style` dict that you are suggesting encodes essentially the same thing as the `ExportConfiguration` structure that I'm proposing. With the main differences being that:
- Your proposal nests the export configuration under the object that knows about all possible exportable items
- Your proposal encodes the export configuration in primitive data types
- My proposal allows for changing the order of export columns (which in hindsight is probably unnecessary)
- My proposal includes some information in the export configuration which is not necessary to build the export (such as question labels).

So yeah, I think our proposals are pretty close to each other. I think you're right that storing the column configurations in a list instead of in a dictionary makes look up slightly more difficult when constructing the configure export page. I personally think it's cleaner to keep the models representing "what is exportable for a given app/xmlns or case type" and "what does this export contain" separate though. So, how about a third proposal :smile: :

```python
exportable_items = ExportableItems(
    tables=[
        ExportableTableConfiguration(
            path=[]  # This would be non empty if this table represented a repeat group
            items=[
                ScalarItem(
                    path=["form", "q1"],
                    label="Question 1",
                ),
                MultipleChoiceQuestion(
                    path=["form", "q2"],
                    label="Question 2",
                    options=["yes", "no"]
                )
            ]
        )
    ]
)

export_configuration = ExportConfiguration(
    tables={
        exportable_items.tables[0].path: TableConfiguration(
            name="My awesome form",
            columns={
                 exportable_items.tables[0].items[1]: ColumnConfiguration(    # We would make `ExportItem` hashable
                    label="Header for Question 2 column"
                    expand_column=False
                 )
            }
        )
    }
)
```
And, if we didn't want the unnecessary bits of `ExportItem`s being stored in the ExportConfiguration, we could give it a method like `ExportItem.get_identifier()` which would return a tuple uniquely identifying it, or some simple composite class that wraps those pieces of information.

(FYI @czue, @snopoke)


test one last time


I see, the Eclipse complaint is indeed a real argument. I also agree with your conclusion.


I think what I was getting at is whether, as we start to diverge, invariably, different templates will start re-appropriating the same letters for different compartments, depending on the species, kingdom, families etc. You'd be surprised, I keep hearing about, for example, sub-organellar organization in green algae that doesn't appear in higher plants and we haven't even touched the diversity of fungi yet. This can lead to some confusion if one were to try and compare models generated by different templates.

One possible consideration is that we keep a master list of compartments outside of the individual template directory, and it has a "Templates" column within which individuals can keep track of who's using what letters for which compartment in which Template.


looks good


Solid commit message 5/7 :+1:


I recommend only specifying the version string in one place (settings), and reusing that variable.

Hard-coding it in text means we would need to change the code in multiple places when a new version was released.


Using a underscore method, a private API by convention, is inherently dangerous. Do the benefits outweigh the risks? Is the alternative unattractively complex?


Yes, but we don't know that there was anything there from the source if the method is removed. (I kind of see us adding optimizations for methods that only contain forwarding calls, if they're not already handled well by LLVM.)


See [PR 19](https://github.com/cdmedia/cms.js/pull/19) :)


Related changes done on coffee in devel only


`request.getStatus()` may never be `null`? Or better `!JoinRequestStatus.PENDING.equals(request.getStatus())` ?


This document does not assume that you need the old interface for a library present to compile the new one.


Compiles successfully.


Notice


Haha, so clever I am...


Keep/Process only unique Snippet-Calls in Matches-Array


Not the same semantic but I'm ok adding console spam for cases like this.


albo zróbmy czat, w którym użytkownicy będą sobie pisali np c7 i pudło ;p a reszte rozrysują sobie na kartkach ;> w weekend do tego usiąde mam pare pomysłów, ale w praktyce może nie być aż tak kolorowo
pozdrawiam cieplutko


I dont think this second assignment is needed, the first you added should always define it and the manipulation done after that point does not need to be saved (it will just be repeated should this one fail and be added back to the queue .... its kind of like doing empty($email['body_fail']) ? $email['body'] : $email['body_fail'] down in the queue re-add.


New-Fan-Object (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2088 of 2088 tests passed, 0 test warnings)

 * 549 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Doesn't that look for a file named `constants` at the root directory instead?

I think it's cleaner to bake the version number in at compile time [using the manifest](https://github.com/jhclark/multeval/issues/9), but I'm not really sure the Java code and manifest I posted are production-ready


@roadev iba a escribir del grupo, pero al parecer esto último se me escapo xD


no idea.  @GodenYao @ashwinstar @asimrp any ideas about this?


Why we should have this here?


unused, remove


indentation is off here?


This class seems to have several unused methods (getLoadBalancersForApplication, getLoadBalancer, getLoadBalancersForApplication). If they are not used, delete them.


idem


The summary is referring to PullToRefreshView, but in actual commit there is no such a component. So I'm confused. Are we talking about new PullToRefreshView, or ScrollView has been just extended of refreshControl component?


It is nickles and dimes.  We could even release the memory after this, right?


Delete this rule?


This test failed
  org.apache.spark.sql.AnalysisException: Cannot resolve column name "(UDF(city,_city) > 0.9)" among (id, first_name, last_name, address, city, state, zip, full_name, _id, _first_name, _last_name, _address, _city, _state, _zip, _full_name, First_Name_Match, (UDF(city,_city) > 0.9));


@mrac, both mechansms (numeric timeout and `cancellable`) use the same `$http` API (the `timeout` property of the `$http` config object). So, there can only be one in effect per request.

We needed to pick one to take precedence over the other, so we picked the numeric timeout.


they should spawn inside the bounding only if noone else is outside the bounding :D


I'm not sure how references are handled, but I'm not personally a fan of few pages of assertions followed by a list of references.  The more obvious the link between an assertion and the supporting reference(s) is, the easier it is for readers to fact-check you.  I'd make the whole “the scientific consensus among linguists, psychologists and neuroscientists is that the bridge phonics builds from letters to sounds makes learning to read easier” a link to [the NRC report][1].  Then folks who don't buy that assertion can click the link and get lots of detail on why we think it's a safe statement.

[1]: https://www.nichd.nih.gov/publications/pages/pubs_details.aspx?pubs_id=88


This is pretty unrelated


Nitpick (though not your doing): these can be using llvm::function_ref instead of std::function.


Shouldn't this be a synchronize and not a copy?


This test failed:
  "[[null,null,null,null,null,null,null,null]]" did not equal "[[1,George,Jetson,100 Skyway Drive,Metropolis,CA,90210,George Jetson]]" because array element [null,null,null,null,null,null,null,null] not equal [1,George,Jetson,100 Skyway Drive,Metropolis,CA,90210,George Jetson] (SparkTestUtil.scala:130)


This was removed at some point, but not certain what commit.


asi, es. solo en este momento no entendi bien que querias hacer


fixed my mistakes


Notice


we can use just angular date filter!


Notice here too


Can the next blog post be about comment length? :stuck_out_tongue:


ditto


I have been thinking about 5,3 and I think the last three paragraphs belong at the beginning with 5. Its design, not implementation. I didn't know how to change yesterday's commit to incorporate this comment.


The flatten is a safety, otherwise this code behaves exactly as before.  It was all double checked in a pry console and none of the existing specs that depend on this are broken, so it's all good.


Title suggests the name of the problem


In most cases trap_print should translate to Log::Notice, unless there is a blatant warning (warnings in commands could still be notices)


Bot* could probably be replaced by a Logger


Hi Carlos-Alex,

You can find a demo at http://dss.nowina.lu. In the menu, you have the available documentation.

If you have more questions/remarks, feel free to use the project's Jira : https://esig-dss.atlassian.net

Kind regards,

Pierrick


Could you make a commit to be merged in for-0.49 that removes it?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12233](https://teamcity.mesosphere.io/viewLog.html?buildId=109753&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:03:54


Also added comments and extra description information


My application seems to lock up when I upgraded to this new version. There appears to be a difference in the API call being made:

v 2.0.1:
uri: 'https://sandbox-quickbooks.api.intuit.com/v3/company/1314009425/preferences/?minorversion=4'

v 2.0.2:
uri: 'https://sandbox-quickbooks.api.intuit.com/v3/company/1314009425/preferences?minorversion=4'

(Notice the trailing slash after preferences in the uri)


Thanks, got it.


translationLogs?


Are there any specs for rake tasks?


Ja ja, irgendwann mal wenn alles funktioniert.

Am 21. Januar 2016 um 17:24 schrieb Ben Schumacher <notifications@github.com
>:

> Denkst du daran Variablen, Methoden und den Code an sich an den Styleguide
> anzupassen und sprechend Namen zu wählen?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hu-semesterprojekt-genombrowser/Alazen-Integration/commit/7d6168086875a7300578ec8c347dff8642c4204a#commitcomment-15590302>
> .
>


What about `copyAssetsIOS`?
Is there any way to check if already copied the assets or not?


Okay, yeah, makes sense.


This file appears to be added unintentionally. Probably we want a pattern for this in gitignore.


@vvidic We're missing the tarball for 0.12.2 in the debian/jessie branch.


Do you mean with the code that after this function, only if ``observation_request_reply()`` runs will the entry be actually removed? Will that arrive after this call for sure, for all cases?


That makes sense.  I guess the assumption is that the first organization type will be the default type.


g_assert(g_spawn_async(NULL...)) instead of if(!...) g_assert(0);


Also, dpkg-buildpackage is complaining about an unmet dependency: `python3-dateutil (>= 1.5)`  Do we need that?


Hmm, I don't know. Also, I don't see why they moved the location at all.


Great!


Ah. Comparison against algae would be tough. This would require some thoughtful discussion as some algae underwent triple endosymbiosis and have a chloroplast in a eukaryotic membrane inside another eukaryotic membrane inside an algae. I'd say that we'd have to put that on our futures list and that we need to hash out what the exact use case is.

I almost think an outside solution like you are proposing would be necessary because I just don't see people sticking to one compartment standard until the algae modeling becomes more well developed as an area.

Sent from my iPhone

> On Jan 21, 2016, at 11:00 AM, samseaver <notifications@github.com> wrote:
>
> I think what I was getting at is whether, as we start to diverge, invariably, different templates will start re-appropriating the same letters for different compartments, depending on the species, kingdom, families etc. You'd be surprised, I keep hearing about, for example, sub-organellar organization in green algae that doesn't appear in higher plants and we haven't even touched the diversity of fungi yet. This can lead to some confusion if one were to try and compare models generated by different templates.
>
> One possible consideration is that we keep a master list of compartments outside of the individual template directory, and it has a "Templates" column within which individuals can keep track of who's using what letters for which compartment in which Template.
>
> —
> Reply to this email directly or view it on GitHub.
>


Ready to merge.


all input tag must be closed.


I'd cite [Streeter][1] here (congrats on finding a copy :), because it's good to see:

* Experimental evidence of enthusiasm being useful.  Even though the sample size isn't great, and the topic/students are much different from ours.
* An experimental definition of enthusiasm (Collins' eight variables).
* Examples of short, inservice workshops for training teachers.  The phases is in the “Experimental Group Treatment” section sound very similar to our instructor training procedure.
* References into the “enthusiasm in teaching” literature.  Unsurprisingly a robust field (at least as Streeter describes it), but something that may be hard to discover for folks a long way from that field.

The only problem I have with Streeter is the paywall, and that's probably a necessary evil.  If/when we hear of a similar paper with open access, we can replace our reference.

[1]:  http://doi.org/10.1080/0270271860070403


Agree, we should make an issue, but low priority for now.

Von: Nathan Franklin [mailto:notifications@github.com]
Gesendet: Donnerstag, 21. Januar 2016 17:53
An: simphony/AViz
Cc: Hashibon, Adham
Betreff: Re: [AViz] Fix finding min value of property 8 (#42) (65be7d0)

@ahashibon<https://github.com/ahashibon> , even though we had fixed the other bug in this spot. there was another that we didn't see. Like you mentioned the other day, this whole individual variables for all the properties should be reworked to an array.

—
Reply to this email directly or view it on GitHub<https://github.com/simphony/AViz/commit/65be7d03d778b2ac00219f872523dc6e4b775150#commitcomment-15591169>.


You could probably remove the whole section and just rely upon the `default-src 'self'`


Fixes #29


hej, mam takie głupie pytanie:
To zadziała jeżeli aplikacja jest z plikiem obb?


@gkalpak Thanks, then I'll look for a way to simulate timeout by using $timeout with $cancelRequest.


@popcornmix, this was missing in your version.


Millor arreglar el problema original... https://github.com/FontFaceKit/open-sans


hardcoded because the 'mesos-slave' group must always be version 26 or terraform will destroy the existing resources prematurely.
I tried to do this by creating an `atlas_artifact.mesos-slave-old` resource but this also triggered a premature resource tree termination.  We can't change the name right now.


вероятно, это нужно перенести в layout


Why do you proxy click like this? You should just be able to disable the warning at program startup.


yes. the copyright currently belongs to sauce labs since it must belong to a legal entity but will move over to the foundation at the right moment.


ugh; all I wanted to do was fix a stupid security bug, but latest pip has a bug; everything is terrible


I was also curious what happens if you specify `output: github_document` in the YAML of a `.md` document. It seems to cause some additional files to be left behind: `rmarkdown::render()` or "Preview" of `gfm-test.md` leads to the creation of `gfm-test.markdown_github` and `gfm-test.markdown_github.html`. Not sure exactly what should happen here?


Is there a libfreetype-dev dependency if you don't need freetype support? I've built cleanly without it on many platforms.


So I'm missing something obviously, if I run the example:

```./Build_Model_Template.py GramNegative ../Templates/GramNegative /mmundy/public/modelsupport/templates/GramNegative.modeltemplate```

I get this:

```Traceback (most recent call last):
  File "./Build_Model_Template.py", line 91, in <module>
    helper.readReactionsFile(reactionsFile, includeLinenum=False)
  File "/homes/seaver/Projects/ModelSEEDDatabase/scripts/TemplateHelper.py", line 499, in readReactionsFile
    raise ComplexNotFoundError('Reaction %s on line %d refers to complex %s which is not found' %(reaction['id'], linenum, complexes[cindex]))
TemplateHelper.ComplexNotFoundError: Reaction rxn05488_c on line 6689 refers to complex universal which is not found```


this definition is incorrect


nice job


merge


@slavapestov Yep, I agree that we could define this and make it work.  However, until and if end up doing that, we should emit better diagnostics. :-)


PlantCompBaseClassAgain (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (956 of 956 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.85%25-green.svg)


I'm really not sure about changing single qoutes to double qoutes.

DDB CMS and Drupal usually uses single qoutes?


@mrac, yes, that's certainly doable. In fact, thinking about it again, we should be able to do the same thing in `$resource`. I.e. when something is `cancellable` **and** has a numeric timeout, use `$timeout` to resolve the promise.

Would you like to try your luck on a PR for that ?


Right, that's because the natural extension of the output file is .md,
however a file with that extension already exists (in the input file) so we
use a more explicit extension to avoid overwriting the input.

On Thu, Jan 21, 2016 at 12:21 PM, Jennifer (Jenny) Bryan <
notifications@github.com> wrote:

> I was also curious what happens if you specify output: github_document in
> the YAML of a .md document. It seems to cause some additional files to be
> left behind: rmarkdown::render() or "Preview" of gfm-test.md leads to the
> creation of gfm-test.markdown_github and gfm-test.markdown_github.html.
> Not sure exactly what should happen here?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rstudio/rmarkdown/commit/62cc240a17ab655b50e823da39e7bcc5f2dbdbb2#commitcomment-15591974>
> .
>


This is also commonly just a filename (despite the element suggesting it is a URI).

For example, the official openSUSE images have icon_uri = "OpenSuse12_100.png" and  small_icon_uri = "OpenSuse12_45.png"


code must be properly indented.


Nice catch. Rebased again. Hopefully I got it right this time.

On Thu, Jan 21, 2016 at 8:49 AM, W. Trevor King <notifications@github.com>
wrote:

> Busted rebase? You remove this line in 0c912a0
> <https://github.com/arokem/instructor-training/commit/0c912a0c8e00f937cac94abd265de1a5d635700e>,
> so it's not really a problem, but it would be nice to remove it from this
> commit too. On the other hand, this PR has already absorbed lots of
> polishing, so no worries if this is too minor to fix ;).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/arokem/instructor-training/commit/1119fce7d8902daa2eba7f43d2fb792b6aa20bdc#commitcomment-15591062>
> .
>


Instead of forcing the user to submit a date/time in the specified format, can we try to coerce the provided imput into the appropriate format, and error out if it's not coercible?


Yeah I know, this whole thing will hopefully go away in a few weeks, if I end having time to gut our default args implementation...


SHAMapDelta use of 'nodeStack' should probably be updated.


Maybe you could have the obj/res IDs #define'd to help on maintenance, but it looks fine. I guess the methods (write/read/create) etc from the management API need more doc -- I'm not 100% sure of their effect/intentions.


use alt attribute inside <img> tag.


HBIRE_vector_take2 (amirroth) - x86_64-MacOS-10.9-clang: OK (2038 of 2051 tests passed, 501 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.37%25-yellow.svg)


should log before returning.


i think here should be `source`


What is your feedback about SIFT_GPU matching...
Does it is really fast?
Does it is faster than CASCADE_HASHING?


I am fine adding references as (Author, Year) inline and a full
bibliography in some place, but I have not see this anywhere here, and I
have no idea how this is handled in the markdown/html system here.

On Thu, Jan 21, 2016 at 9:16 AM, W. Trevor King <notifications@github.com>
wrote:

> I'd cite Streeter <http://doi.org/10.1080/0270271860070403> here
> (congrats on finding a copy :), because it's good to see:
>
>    - Experimental evidence of enthusiasm being useful. Even though the
>    sample size isn't great, and the topic/students are much different from
>    ours.
>    - An experimental definition of enthusiasm (Collins' eight variables).
>    - Examples of short, inservice workshops for training teachers. The
>    phases is in the “Experimental Group Treatment” section sound very similar
>    to our instructor training procedure.
>    - References into the “enthusiasm in teaching” literature.
>    Unsurprisingly a robust field (at least as Streeter describes it), but
>    something that may be hard to discover for folks a long way from that field.
>
> The only problem I have with Streeter is the paywall, and that's probably
> a necessary evil. If/when we hear of a similar paper with open access, we
> can replace our reference.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/arokem/instructor-training/commit/0c912a0c8e00f937cac94abd265de1a5d635700e#commitcomment-15591835>
> .
>


Wow, that was super fast! Thank you!


same as above.


Looks fine, except for the random Gerrit change ID in the commit message.


I think we should reconsider using the Coder module.

It is making some weird changes. I think we should let scrutinizer decide what should be changed tbh.


because lbc is tRaASH


CFStringCreateMutableCopy returns retain +1 and CFArraySetValueAtIndex will retain resulting a +2 retain count string; this leaks

Code like this should be in the form of:

```c
CFMutableStringRef copied = CFStringCreateMutableCopy(kCFAllocatorSystemDefault, 0, str);
CFArraySetValueAtIndex(resultsComponents, i, copied);
CFRelease(copied);
```


Please fix this definition


I know it's bikeshedding but I think `.jsm` ("JavaScript modules") might be better. Exposing JS developers to the fact that there's an ES vs. JS naming split, or an organization-formerly-known-as-the-European-Computer-Manufacturer's-Association, seems bad. Stick with "JavaScript".


Ok, here I get more that writing to a resource is to send data to change its state, I guess. But what is to execute a resource? Make it do its "thing"?


releasing out from underneath the array is potentially very dangerous


all input tag must be closed.


close #1


However, this is a good change and setting CFrame will have this effect.

A further change would be to allow Size to work after setting FormFactor.

```lua
local CFrame = Values.CFrame or Values.Cframe

... -- original code

if CFrame then
    Object.CFrame = CFrame
end
```

Although you can then pull CFrame from the Values table, please don't modify the value sent, as sometimes code can reuse the same properties table.

This is both more efficient (no if-statement every single value), and feels more readable. From a performance standpoint, setting CFrame twice is cheaper than checking if CFrame is set. This is because ROBLOX executes an if-statement for delta on every change of a value. There is no harm in double-setting CFrame, if it's the same, ROBLOX will do nothing else, and we can save an if-statement.

Before I accept this commit:
- Please update the code for efficiency
- I'd prefer if you switched back to `pairs()`, but in this case, it's fine.
- Optionally, handle Size changes before CFrame, in case FormFactor was changed.


what are these two empty strings? perhaps some sort of comment on why this is the case would be good


Well, `preferLocalBuild` isn't handled by `stdenv` but by nix. It is documented in the nix manual but wrongly ATM, as since NixOS/Nix@b64988bb358547 substituting is controlled separately by `allowSubstitutes`.

It's a question whether it's worth keeping the documentation of the attributes split according to where they are implemented. I don't expect many users of `nix` language without our `stdenv`.


@thatoddmailbox Yes


I've now made this change across all sg definitions in this module.
Feel free to comment on the PR
https://github.com/terraform-community-modules/tf_aws_sg/pull/23


I don't understand what you mean by "Why use variables for the checker type strings? I personally find the strings
easier to type."


I've now made this change across all sg definitions in this module.
Feel free to comment on the PR
terraform-community-modules#23


Consider having the overload SHAMap::walkTowardsKey(uint256 const& id) const which would eliminate all the nullptr checks.


the components1808 are leaking here if I understand the contract from _CFURLCopyComponents correctly.


C'est un point de détai. J'avais opté pour post_save au cas ou la saison a besoin du turn sauvé dans la DB.


And must be NULL-terminated, it seems.


LGTM


code must be properly indented and also attach all images used in this assignment.


je pensais que les commentaires seraient UNIQUEMENT ce qu'on met sur le forum. Et que les résultats détaillés (style tableur) seraient consultable sur une page adaptée.


Unrelated to this PR, sorry self.


y u no `master`?


Should be single hash, as it's bigger (and is the master header)


Je ne crois pas que je surchargerais la DB en ajoutant un texte personnalisable.


Is the double // intentional?


Nitpick: perhaps *`*not*` for emphasis? Will render in docs as italics.


@mzikherman I left this line here but I'm not sure if it's needed?

Basically: is it possible for an API image response to have the old form of `image_url`, and `image_versions`, without having the `image_urls` hash?

I suppose *anything* is possible.


It's somewhat annoying to have them split -- as data points, several friends of mine was very surprised to find out separate NixPkgs manual, because Nix manual felt to them as a complete one (after all, there is description of `stdenv` there). I, on the other hand, was surprised just now to find `preferLocalBuild` documentation there ~_^

Maybe cross-linking between those documentations is a solution.


correct me if im wrong... but shouldnt this file be also called in the serverside init where the db is defined?


(d'ailleurs je croyais que les notifications étaient une alternative au post automatique de message sur le forum)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12236](https://teamcity.mesosphere.io/viewLog.html?buildId=109764&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:08:32


not yet


Looking at line 6689, the complexes field is "universal" and there is not complex in the Complexes.tsv file with that ID. Maybe the type field should be switched from "gapfilling" to "universal"?


query_shadowing() ist doch nicht privilegiert?


On Thu, Jan 21, 2016 at 09:29:26AM -0800, Ariel Rokem wrote:
> I am fine adding references as (Author, Year) inline and a full
> bibliography in some place…

That works for me too.

> … but I have not see this anywhere here…

Yeah, probably good to see what @gvwilson wants before making changes.

> … I have no idea how this is handled in the markdown/html system
> here.

I'd recommend reference-style links [1] with entries in the text like:

  Enthusiasm is great ([Streeter, 1986][streeter-1986])!

and then at the bottom of the file a set of link-label definitions:

  [streeter-1986]: http://doi.org/10.1080/0270271860070403

I wouldn't bother with a formal bibliography, because the DOI system
seems fairly reliable and is specific enough.  I would probably put a
full bibliography entry in the commit message landing a link-label
definition, which we can use for recovery if this repository outlives
working DOI resolution ;).

[1]: http://daringfireball.net/projects/markdown/syntax#link


I'll replace my solution with yours - it's cleaner indeed.

I'll leave the unmodifiable in place - although it won't hurt to change the defensive copy, it does not have the intended effect either. It's nice to throw an explicit exception that indicates that.

When we're creating a defensive copy, I don't believe it's likely to  run into concurrency issues (as each thread will have it's own copy).


because I suck. disregard.


Não entendi :3


I've just been using author/title/date as long as there's a link - we'll
fill in the references once the content settles down.


Okay, I agree - let's also capture the colours and ages of cats.


Not quite sure this applies to Python, does it?


nitpick: `numerator` instead of `N`, `denominator` instead of `D`, line slightly longer than 80 characters


Hey Rita,

I think this is very well done. Clean code, good organization and straight to the point. One pointer would be clean up the spacing in your `style.css` file, keep the indentations at 4 spaces.

Good job!

-Stephen


Are you sure that all you have plug-in this modules in a right place ?

non of those variables are used in Animated


body on a separate line to stay consistent please


TL;DR is the compressed version.
> An abstract is a self-contained, short, and powerful statement that describes a larger work. Components vary according to discipline. An abstract of a social science or scientific work may contain the scope, purpose, results, and contents of the work. An abstract of a humanities work may contain the thesis, background, and conclusion of the larger work. An abstract is not a review, nor does it evaluate the work being abstracted. While it contains key words found in the larger work, the abstract is an original document rather than an excerpted passage.

As opposed to the abstract the TL;DR is the summary, containing the compressed information, not information about the craft.
The abstract is the definition of the abstract. as seen before, while the TL;DR is "An abstract is a self-contained, short, and powerful statement that describes a larger work. An abstract is not a review, nor does it evaluate the work being abstracted." (it contains the main points, without talking around the subject. Usually used to sum up the main points of the chapter, instead of talking about the chapter. It's different from the summary, since the summary contains more details about why and how is the chapter helpful, while the TL;DR is the shortest way to explain the chapter to somebody who already learned it, and in the TL;DR the use of complicated -abstract- terms is allowed, if they help reduce the length of the TL;DR section of the chapter).


it doesn't. fixing.


@garvinhicking Shall we really keep this plugin separated?
Why not include to event creativecommons?


It's better to define valley directly in HTML, it increase customizability of application


What's the purpose of this function? I seems to call `handler` and return its result — couldn't we just call the handler function directly?


id isn't a query parameter, its after the last forward slash in the url.

i.e. if your route is `/^\/airplanes\/?/`, and you hit it with `/airplanes/1`, id is 1.


@mauron85 The commit summary is misleading, the component is called `RefreshControl` and is used with the ScrollView `refreshControl` property.


Thanks for this one. I was on my way to resubmit the patch since I've been too confident on the first time.


Should it be 2.0.1? Am I missing something?


Another comment


Please, import only what you need, you may see in your editor or IDE that some variables are not used in ecosystem


that's exactly why I'm here as well


Much better but not done yet


I love that code like this (that's manipulating the shared error state) is _already parallel-izable_ in Clojure.


Почему скрипт работает не стабильно?


@ide Notice this change to iOS promises.  The parameter is no longer wrapped in an array.  It is just whatever object is passed from the native side.  I think you might be the only person relying on this.  I changed it to match Android which doesn't put the extra wrapper around it.  Hopefully I didn't break you or not too badly anyway.


Immanent Tuple developments mean that we can deal with long tuples in-stream more easily. Discuss with you tomorrow. (For the _cognicenti_: Abstract Nonsense for Tuples and multi-parm functions can be super-imposed on the Stream stuff meaning `String someId = tuple.t3;` need never be written again. Fully type-inferred and -checked.)


The names numerator and denominator are already used in the enclosing scope (You're also shadowing the rawValue identifier in a few places). I'd be okay with longer names, but I don't like shadowing identifiers.


uhm, I must be having a "senior moment", but I do not understand how does the code work here. What's the meaning of checking  `(size_t)(pw->Port1) > 3 ` or `long(pw->Port1) & 1`. Isn't `pw->Port1` the address of the `Node` object?


This way it's easier to build logic that is being run before/after the handler is executed by overloading it (without building-in special 'middleware' mechanisms)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12234](https://teamcity.mesosphere.io/viewLog.html?buildId=109762&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:12


Is either `app.fetch` or `app.uris` always empty?


Is there a reason we do not separate classes into their own file?


Fixed with this: 588fe82


Das ist nicht notwendig. Das configure_interactive wird hier von der sefun aufgerufen, damit ist der Aufruf automatisch privilegiert (wie ein Aufruf vom Master selbst).

Ich hab die Ersatz-Sefuns immer so programmiert, daß die Sefun selbst privilege_violation mit den alten Parametern aufruft, wenn die frühere Efun privilegiert war. Dafür findet der privilege_violation für die configure_*-Efuns nicht statt, weil der Aufruf eben aus der Sefun kommt. Damit ist es automatisch voll kompatibel, man muß dem Master nichts beibringen.


- [ ] "サーブレットコンテナを使う場合は"は不要。


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1210](http://teamcity.monogame.net/viewLog.html?buildId=13845&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Hi. Is possible dont shows the total course in Category + Subcategory instead Category - SubCategory? I think is the best.
In my Moodle I will show only the subcategorys counters, because in Category will don't have any courses for now. For the ideal is shows the total counter instead divided.


Done, @brendan-ward.


Must we call this here? This can lead to deadlock if the adapter application is not started when Application.start is called on an application with this in the tree.


Please, remove that one, it's enough to go with field for both predators and paln-eaters


remaining?


Should we call it inside start_link and proxy the start_link?


LGTM
we can push this already. Thanks!


What's going on with all these indent changes? They seem fine in my editor


The theme is supplied as is.  That is the way I have chosen to implement it.  If you're not happy then change your copy.  You have the source code.


I need to make a BIP out of this comment:

/*
 * Forward-compatible version bits
 *
 * A forward compatible version bits int32_t nVersion has 5 distinct sections.
 * The following diagram is an example nVersion with the sections labeled below.
 *
 *     31     24  23     16  15      8  7       0
 *     0011 0000  0000 0000  0000 0000  0000 0000
 *     AAAB CCCC  CCCC CCCC  DDDD DDDD  DDDD EEEE
 *
 *   A) The top three bits, 29..31, should be set to 001 to indicate version
 *      bits support.
 *
 *   B) The next bit is to indicate support for Bitcion Classic's 2015 2 MB hard
 *      fork. A 1 shall indicate that the block is a vote in support of the 2 MB
 *      hardfork. This bit will be reset to 0 after the fork is activated, or
 *      after [TBD], whichever comes first.
 *
 *   C) The next 12 bits, 16..28, have undefined behavior and are reserved for
 *      future use.
 *
 *   D) The next 8 bits, 4..15, are for soft forks with BIP9 activation rules.
 *
 *   E) The last 4 bits, 0..3, are reserved for backwards-and-forwards-compatible
 *      soft forks (BAFCSF). A BAFCSF works by incrementing the nVersion number,
 *      but instead of checking
 *
 *        if (nVersion >= new_minimum)
 *
 *      which incorrectly interprets all uses of version bits as support for the
 *      fork, it uses
 *
 *        if ((nVersion & 0x0F) >= new_minimum)
 *
 *      which causes it to ignore any version bits used by other clients. This
 *      allows a version bits fork and a non-version bits fork to be deployed
 *      simultaneously on the same network, for example by different development
 *      teams, with no incompatibilities. This allows up to 11 BAFCSFs before
 *      a change to version bits forks would be necessary. This mechanism allows
 *      for nodes and miners using version bits to indicate support for these
 *      BAFCSFs by setting the bottom four bits accordingly.  It is suggested
 *      that the value 15 for the bottom nibble be used to indicate support
 *      for a soft fork that reclaims this lost space. The first BAFCSF shall
 *      have a bottom nibble value of 5. Previous soft fork tests are
 *      adequately covered by the setting of bit 30.
 */


Yeah, it probably should be a private method.


Ditto WRT letting timeout=NULL on errors.


Why wasn't it enough to just use the PortName for tracking purposes? Each MessagePipe endpoint has a unique port, right?


superseded by #280


PlantCompBaseClassAgain (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2050 of 2050 tests passed, 329 test warnings)

 * 331 tests had: AUD diffs.
 * 329 tests had: BND diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Also we shouldn't touch the feature export code?


Ieks. Ich hab shadows und snoops durcheinander geworfen...


ok


goto?


Because port names change as endpoints are transferred. This makes it easier to analyze logs above the ports layer, i.e. to know what's happening between a pipe's two endpoints regardless of what ports they're attached to at the moment.


However, if the overflow does occurs, your change would lead to a different result than the old code, possibly causing a (soft) fork.

Since this code is a legacy check I think keeping it exactly the same is simplest.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12235](https://teamcity.mesosphere.io/viewLog.html?buildId=109763&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:10:01


Hey Brittany,

1. Move this part `<link type= "text/css" rel="stylesheet" href= "style.css"/>` into your `<head>` tag. Modern browsers are smart enough to understand what you were trying to achieve so it picked up on your `style.css` file but any resources you might need for your HTML page should be inside of `<head`> tag.

2. in `style.css`, the `body` style block can be combined into one like so.
```css
body {
    color: gray;
    font-size: 20px;
    font-family: "Helvetica", times, serif;
    background-color: white;
}
```

3. Use lowercase for all file naming, class naming, id naming, basically all naming - minus when we get to JavaScript. But I'll explain that later

Other than that, all is good :100: great job!

Stephen


Bekommt er ja mit previous_object(). Ich hab versucht, mich auf Codeverschiebungen und Umbenennungen zu beschränken. Ich wollte jetzt nicht noch die Semantik ändern, da der Migrationsaufwand so schon hoch genug ist...


New-Fan-Object (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1507 of 1507 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


@gsmet I see the point of a clean (sort of), but is there any reason we should trigger the "install" goal (which will build the whole project) *before* the build script?
Unless there's a particular reason, we could cut the build time by 1 or 2 minutes by removing this line.


Ok then TL;DR is actually the *Summary*.


Thank you, Raphael!


Well, that is a good point. We probably should have a separate compartment file in ModelSEEDDatabase.

And if we do try and maintain a single set of compartments for all species, we could ultimately run out of letters, but I think we’re a long way from that. I do concede, we will someday have to deal with multi-letter compartments.

--
Chris Henry
Sent with Airmail

On January 21, 2016 at 11:00:33 AM, samseaver (notifications@github.com) wrote:

I think what I was getting at is whether, as we start to diverge, invariably, different templates will start re-appropriating the same letters for different compartments, depending on the species, kingdom, families etc. You'd be surprised, I keep hearing about, for example, sub-organellar organization in green algae that doesn't appear in higher plants and we haven't even touched the diversity of fungi yet. This can lead to some confusion if one were to try and compare models generated by different templates.

One possible consideration is that we keep a master list of compartments outside of the individual template directory, and it has a "Templates" column within which individuals can keep track of who's using what letters for which compartment in which Template.

—
Reply to this email directly or view it on GitHub.


Looks fine to me although I don't particularly like the refactor in the initiailizer. It's harder to read and understand (mind has to keep track of intermediate variable and syntax of the assignment plus a ternary).


That change (switched gapfilling to universal) took place with the integration of the core template.
This is my argument for that. Analyzing 8000+ organism across the tree of life, I have seen many genomes that have complete pathways for number of fermentation products that derived from central metabolites, YET, does not have the appropriate transporter due to annotation inconsistencies (This is the case most of the time). Reaction rxn05488 (Acetate transporter) that was on the above comment and few other transporters related to fermentation products (I think about 6), I made them universal, which I realize, was crucial in getting ATP generation accurate, specially when its done through fermentation.  So, its a preference, whether to keep it "gapfilling" or "universal", I ended up keeping it universal for these few transporters, which really helped the outcome of the FBA.


I don't think it's obnoxious.


You're right, I misread it.


@janicduplessis thanks for explanation. Now it's clear. I've spent some time looking for PullToRefreshView, before getting here. :-). My journey stated here:

https://github.com/facebook/react-native/releases/tag/v0.18.0

![screenshot 2016-01-21 18 55 21](https://cloud.githubusercontent.com/assets/359450/12489434/9b65a776-c070-11e5-90ac-e1769360d9f9.png)


Don't forget n3DS URLs. ;)

I believe n3DS uses different title id for AGB_FIRM as well!


@UniversalMediaServer/developers Even though I *think* this should be safe, I'm a bit afraid of this commit because it's hard to judge what ancient behaviour relies on this exact implementation. I feel this needs some testing (that the database initialization is still working properly).


Apparament, zip n'est pas encore dans la librairie (https://github.com/elm-lang/core/pull/421)

Il faudrait référencer ce package http://package.elm-lang.org/packages/circuithub/elm-list-extra/3.7.0/List-Extra


- [ ] 見出しを設ける必要はない。本節の冒頭部分にnoteとして記載してください。


Is this hash correct?  I couldn't see it in `docker/goamz` and the S3 object doesn't have a `Client` member
https://github.com/docker/goamz/blob/master/s3/s3.go#L39


I guess these numbers are part of the spec, right? If so, don't they deserve a define/enum?


Just noticed in game that it is calculating the fight power before factoring in the counters. Not sure if this fixed that too.


oh really! thats cool - did not know that


Looks good we should implement the same for population serve