PlantCompBaseClassAgain (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1507 of 1507 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.7%25-green.svg)


I think is:
apt-get install libncurses5-dev


This should test more than one key, shouldn't it?


kostyabak, нє нє) Я вже геолокаційну частину пишу. Не комітив ще, бо воно ще не працює так як треба


What do you want to really express in this way? We have to build anyway, even if pull failed?


Having an if/else dangling off an if without enclosing braces is error-prone, please put the if/else inside {}.


:dancer:


Hi - original author here. Just a fyi - I'm planning a release with the route change handler pulled apart so that this can be done cleanly at the package level. Somewhat motivated to do so as I'm using it myself with both ui.router and Angulars router.


i have to know how that make moneyand my business in the world


In my experience the Django folks only change underscore methods from major release to major release.  It's not ideal to use one, but if there is no other way I wouldn't worry about it until Django 1.10


Please coalesce all var declarations in this file.


sorry to be *really* pedantic, but can you please make this a lower case i.


Is the default value  for `MaxIdleConnsPerHost` (2 as far as I can tell) OK for the transport?


Some vertical whitespace is good, but I think you're overdoing it a bit in this file. I think we can manage to read two consecutive lines without white space in between. :wink:


I found a bit odd we call the gpio ISR from the i2c driver. We probably need a 'shared irq' subsystem to handle this properly.

The 'shared irq' subsystem would have only one API: register_isr(). Device drivers such as GPIO and I2C would use the register_isr() API to register their ISR functions. The 'shared irq' subsystem would register its own ISR into the IDT (e.g. shared_irq_handler). When a shared interrupt is fired, the shared_irq_handler() call all ISRs registered for that interrupt number.

Are we aware of any other devices that share IRQs?


Added a Han to the lisy list


I suppose while I'm being pedantic - can we have a newline after these declarations too please.


Don't be rude. It's only a idea.


awesome


Hi @RobinHerbots!

Suppose that I use a mask like 999.999.999-99.
In the case that I show, when I digit third or fourth number, last charCode verification in $.each will be undefined.

You has a browserstack account? If yes, you can test jquery.inputmask demo page in Galaxy Note Tab 4, using Android keyboard. If you use your computer keyboard this issue was not happen.

Glad if I can help more.


Can this be changed to just `active-set`, since `active-setted` isn't the best of grammar. :smile:


Temporarily removed some parts of the shader to find out what's causing the opaque repeller bug


From my experience the speedup is significant. While it might not show on
small datasets, when comparing 1000+ images you can clearly see the
difference. If you are interested I could do an experiment.

On Thu, Jan 21, 2016 at 6:29 PM, Pierre Moulon <notifications@github.com>
wrote:

> What is your feedback about SIFT_GPU matching...
> Does it is really fast?
> Does it is faster than CASCADE_HASHING?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hcjghr/openMVG/commit/0ab04c93c82792f475432aadfdd2b9ff0c82ff72#commitcomment-15592143>
> .
>


yeah this accidentally commented out - it should be uncommented


I just think if people are going to put up their own copies of it, I'm happy with my name only being in the source. :)


Yes it is why I created this CMD_VERSION_STRING_READ in order to manage new feature depending on the FW version


Oh! I didn't know we can do this with scons (I never used it). That would be indeed useful!


Sorry for this mess... I should have placed this commit to a new branch, I suppose.
But still it is small and requires some intervention from your side, because I'm not quite sure what is better to return for absent keys (and whether to touch this code at all). So, please comment and I'll try to rebase or something, if necessary.


Looks good. I will test and merge.


1. `<img src="images/emily, Modern Farmhouse.jpg"</img>` these `<img>` tags will work as long as you correct the file path (src). Should be `images/Modern Farmhouse.jpg` and same for others :)

2.
```css
<style type="text/css">
        a:link {color: #A9A9A9; text-decoration: none}
        a:hover {color: #A9A9A9; text-decoration: none}
        a:active {color: #A9A9A9; text-decoration: none}
 </style>
```
You technically do not need this block in HTML since you are already linking a `css` file to this HTML page. and this should go to your `style.css` instead.

3.
```html
<title>Emily Pecot Portfolio</title>
<meta name="Emily Pecot Design"/>
<meta author="Emily Pecot"/>
<meta tag="web developer, portfolio"/>
```
Let's move this into `<head>` since head block in an HTML page should include `<meta>, <link>, <title>` and all the necessary resources for the page.

Other than that, very well done Emily! :+1:

Stephen


then u suk


Fuse Mobile Coding Test V1.1/Clients/FuseUniversalClient.swift

better!


If you move this line up to the start of the loop, I think you can remove the same line above the loop?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12237](https://teamcity.mesosphere.io/viewLog.html?buildId=109765&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 174 Build time: 00:04:06


Fuse Mobile Coding Test V1.1/Views/ViewController.swift

dont need to capture self, see http://krakendev.io/blog/weak-and-unowned-references-in-swift more examples


I'm not being rude, I'm sorry if it appears that way, not my intent.

Every single time I implement something, somebody criticises it.  I cannot be all things to all people.

It might be an 'idea' but you are asking me to spend time and 'change' it.  Therefore its not an 'idea' its a 'request'.  If I then change it to your view, then somebody else will want the other way.  Then after that the only solution is a setting for both ways.  Then that takes even more time and effort.  See where I'm going with this?


Remove space after and before <>, e.g., unordered_map<int, char[16]>. The only time you need to put an extra space before > is when the value is a template instantiation, e.g., unordered_map<int, vector<int> >. This will keep some old compilers happy.


:+1:

BTW, this kind of change could go on its own PR since it doesn't depend on the other patches from this PR. This way we could merge it right away :)


@bgerstle are we still using this class - btw - might be one of the ones we no longer need but haven't cleaned out yet.


It is, for example cover image for a show (https://api.artsy.net/api/v1/partner/mathaf-arab-museum-of-modern-art/show/mathaf-arab-museum-of-modern-art-focus-works-from-the-mathaf-collection) doesn't have the hash for some reason.

![screen shot 2016-01-21 at 1 09 30 pm](https://cloud.githubusercontent.com/assets/1457859/12489834/5cbe0ad4-c040-11e5-8a78-e8229b714708.png)


Does this imply that Dropbox integration will never be implemented?


Ah yes - for some reason I was thinking the process could be stale, but they are kind of short-term lived.


Oh, I see. It's not a technical issue then.
Thank you.


I think a more verbose name might be better here, such as "lastReturnedSocket" or something? In any case, I think starting variables with an underscore isn't actually recommended (I am aware that a lot of nearby code does it, though).


Remove the comment.


Remove and extra empty line.


That's kinda my bad, I wanted everyone to use the hash instead of the dumb url w/ version replace...


updating my fork


@jfeaver, just wanted to draw your attention, that's not just a refactor. That stuff should be run not `:before => :load_config_initializers`, but `:after => :load_config_initializers`. Otherwise, it won't just work correct. There was a failing test, and I moved those lines in separate initializer. And this fix helped.

Sure, I could use if/else instead of ternary operator.


It's the commit from my pending PR (docker/goamz#1)


A quick `grep` in the codebase reveals cover images for shows, and cover images for 'collections' (these are user sets from the long-lived AB test) just have the old style and not the hash.

So that's not too bad, we can fix that!


We need to understand why getMachine() is not returning nil for physicalHosts anymore. We possibly broke the API.


Does inlining a virtual function do anything? (it has to look in the vtable anyway)


Uhm, I actually want these log messages - perhaps you could add an option for these (debug logging)?


Not sure, I'd imagine we want some real world data for tuning this


I didn't see that one. Thanks for telling me


>We could even release the memory after this, right?

The objects are created lazily and then cached. We could create them all up front for each geometry instance.


module_param available with cpu-boost does all. any particular reason for touchboost_switch.c ??

If input_boost_freq = 0, it switches off cpu-boost driver.
input_boost_ms and input_boost_freq are already configurable.

All available under /sys/module/cpu_boost/parameters


use DRY approach? why not use use "if success" statement inside dispatch_async


`/tmp/pc-rc.local` example output:

```sh
# VM writeback timeout
echo '1500' > '/proc/sys/vm/dirty_writeback_centisecs'

# Enable SATA link power management for host0
echo 'min_power' > '/sys/class/scsi_host/host0/link_power_management_policy'

# Enable SATA link power management for host1
echo 'min_power' > '/sys/class/scsi_host/host1/link_power_management_policy'

# Enable SATA link power management for host2
echo 'min_power' > '/sys/class/scsi_host/host2/link_power_management_policy'

# Enable SATA link power management for host3
echo 'min_power' > '/sys/class/scsi_host/host3/link_power_management_policy'

# Enable SATA link power management for host4
echo 'min_power' > '/sys/class/scsi_host/host4/link_power_management_policy'

# Enable SATA link power management for host5
echo 'min_power' > '/sys/class/scsi_host/host5/link_power_management_policy'

# Enable Audio codec power management
echo '1' > '/sys/module/snd_hda_intel/parameters/power_save'

# NMI watchdog should be turned off
echo '0' > '/proc/sys/kernel/nmi_watchdog'

# Runtime PM for I2C Adapter i2c-1 (NVIDIA i2c adapter 1 at 1:00.0)
echo 'auto' > '/sys/bus/i2c/devices/i2c-1/device/power/control'

# Runtime PM for I2C Adapter i2c-2 (NVIDIA i2c adapter 6 at 1:00.0)
echo 'auto' > '/sys/bus/i2c/devices/i2c-2/device/power/control'

# Autosuspend for USB device External HDD     [Western Digital ]
echo 'auto' > '/sys/bus/usb/devices/3-5/power/control'

# Autosuspend for USB device USB-PS/2 Optical Mouse [Logitech]
echo 'auto' > '/sys/bus/usb/devices/3-1/power/control'

# Autosuspend for USB device USB Keyboard [ ]
echo 'auto' > '/sys/bus/usb/devices/3-2/power/control'

# Autosuspend for USB device Mass Storage Device [Generic]
echo 'auto' > '/sys/bus/usb/devices/3-7/power/control'

# Autosuspend for USB device STORE N GO [Verbatim]
echo 'auto' > '/sys/bus/usb/devices/4-5/power/control'

# Runtime PM for I2C Adapter i2c-0 (NVIDIA i2c adapter 0 at 1:00.0)
echo 'auto' > '/sys/bus/i2c/devices/i2c-0/device/power/control'

# Runtime PM for PCI Device Intel Corporation 4th Gen Core Processor DRAM Controller
echo 'auto' > '/sys/bus/pci/devices/0000:00:00.0/power/control'

# Runtime PM for PCI Device Intel Corporation Xeon E3-1200 v3/4th Gen Core Processor PCI Express x16 Controller
echo 'auto' > '/sys/bus/pci/devices/0000:00:01.0/power/control'

# Runtime PM for PCI Device Intel Corporation 82801 PCI Bridge
echo 'auto' > '/sys/bus/pci/devices/0000:00:1c.6/power/control'

# Runtime PM for PCI Device NVIDIA Corporation GM107 [GeForce GTX 750]
echo 'auto' > '/sys/bus/pci/devices/0000:01:00.0/power/control'

# Runtime PM for PCI Device Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller
echo 'auto' > '/sys/bus/pci/devices/0000:03:00.0/power/control'

# Runtime PM for PCI Device Intel Corporation 9 Series Chipset Family PCI Express Root Port 1
echo 'auto' > '/sys/bus/pci/devices/0000:00:1c.0/power/control'

# Runtime PM for PCI Device Intel Corporation 9 Series Chipset Family USB EHCI Controller #1
echo 'auto' > '/sys/bus/pci/devices/0000:00:1d.0/power/control'

# Runtime PM for PCI Device ASMedia Technology Inc. ASM1083/1085 PCIe to PCI Bridge
echo 'auto' > '/sys/bus/pci/devices/0000:04:00.0/power/control'

# Runtime PM for PCI Device Intel Corporation 9 Series Chipset Family USB xHCI Controller
echo 'auto' > '/sys/bus/pci/devices/0000:00:14.0/power/control'

# Runtime PM for PCI Device Intel Corporation 9 Series Chipset Family ME Interface #1
echo 'auto' > '/sys/bus/pci/devices/0000:00:16.0/power/control'

# Runtime PM for PCI Device Intel Corporation 9 Series Chipset Family USB EHCI Controller #2
echo 'auto' > '/sys/bus/pci/devices/0000:00:1a.0/power/control'

# Runtime PM for PCI Device Intel Corporation 9 Series Chipset Family HD Audio Controller
echo 'auto' > '/sys/bus/pci/devices/0000:00:1b.0/power/control'

# Runtime PM for PCI Device Intel Corporation 9 Series Chipset Family PCI Express Root Port 6
echo 'auto' > '/sys/bus/pci/devices/0000:00:1c.5/power/control'

# Runtime PM for PCI Device Intel Corporation 9 Series Chipset Family H97 Controller
echo 'auto' > '/sys/bus/pci/devices/0000:00:1f.0/power/control'

# Runtime PM for PCI Device Intel Corporation 9 Series Chipset Family SATA Controller [AHCI Mode]
echo 'auto' > '/sys/bus/pci/devices/0000:00:1f.2/power/control'

# Runtime PM for PCI Device Intel Corporation 9 Series Chipset Family SMBus Controller
echo 'auto' > '/sys/bus/pci/devices/0000:00:1f.3/power/control'

# Runtime PM for PCI Device NVIDIA Corporation Device 0fbc
echo 'auto' > '/sys/bus/pci/devices/0000:01:00.1/power/control'

```


Why did you change this out of curiosity?


We should be a little more defensive here. This would potentially lead to an endless panic-restart loop if we somehow got bad data.


:+1: thanks for the interest though @jarrodek


Hi,

I'd like to know if there are any reason you hard coded the lower and the upper ip ? At the moment is there any possibility for me to add a custom DHCP ? I'd like for example to bind my VM to the IP 10.0.5.10.

Regards


I did not find a publicly exported alternative that would accomplish this. Alternatively, we can consider using `.iterator()` and checking the class but I don't at the moment know if that will force a query to happen. https://github.com/django/django/blob/master/django/db/models/query.py#L325

Note that we previously were using non-underscore methods and classes and it didn't protect us from an API change. I think with our code coverage and build matrix we're pretty safe. Whenever we add a new version, someone not only expands the test matrix but also exercises the app to make sure it's producing sane CSVs.


no iterator required
for (auto buf : m_raw_buffers)
  delete buf;


strange usage :), see above


Use TAG, Nick :'( Not "MessageActivity"

Although admittedly "MessageActivity" is better than "random string"


112158233_PVwithStorageSystem (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


If you have time, it would be valuable for the openMVG community.
In order to see if implementing a GPU matcher would be a nice idea or not.
Despite there is a memory limit that limit the number of descriptor you can match together...
Some images can have a very large count of descriptors...

Having a tiny GPU brute force matching library that would be generic (supporting uchar-float based arrays of any size) would be nice ;-)


very fast :D


tu pourrais remplacer ta récursion par map


TAG!!!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12239](https://teamcity.mesosphere.io/viewLog.html?buildId=109787&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:32


I don't understand how this TLDR fits together with *Abstract* and *Summary*, and because of that I don't understand which problem it solves which is not being covered already.


What I actually meant was since the unpack data isn't used at all they produce the same qwords.


Reordering these is actually causing this test to fail. Can you switch the order back?


This will all be changing with the move to the new Azure SDK for Java that is coming so I wouldn't worry about this for this PR.


TAG TAG TAG

And what's with this +"" crap? getPath() already returns a String.

+"" is a hack to turn ints into Strings, but even then you should be doing Integer.toString(int)


We have decided not to open source dropbox.

sent from my phone.
On 21 Jan 2016 6:10 p.m., "Carlos A Arguelles Delgado" <
notifications@github.com> wrote:

> Does this imply that Dropbox integration will never be implemented?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sharelatex/sharelatex/commit/dea04f2e251dbc569b270cf0a20b0336bb3f8270#commitcomment-15593196>
> .
>


TAG! D:<


also i think this starting or stopping activity should be in a method to keep things clean


TAG


The section about writing nix expression in nix manual does link to the nixpkgs manual. But the whole concept seems a bit problematic. `stdenv` is a rather special thing.


@tomgarcia Isn't this the expected behavior of the feature? It says "Allows other users to contribute content into your gallery.", meaning non-instructors.

Can the reported "bug" just be a misunderstanding of how the new feature works?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1210](http://teamcity.monogame.net/viewLog.html?buildId=13845&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:32:54


Unfortunately, this too will be changing as part of the move to new Azure SDK for Java so I wouldn't spend time changing this as part of this PR.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1211](http://teamcity.monogame.net/viewLog.html?buildId=13849&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12240](https://teamcity.mesosphere.io/viewLog.html?buildId=109808&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:29


setSendable(s.length() > 0)

The if statement isn't needed >.>


All these config keys will actually start with a lowercase. Can you change them? I'd like to keep them consistent with how the data will actually appear.


Lowercase these


@buddhi1980 thanks, glad you like it :)
@mclarekin
yes, this occupies all cpu cores, since all widgets are visible and all render simultaniously.
On my PC this does not cause freezing, but this can definetely be the case.
Also the duration of the rendering is pretty high for such "small" thumbnails.
@buddhi1980 what do you think to reduce oversampling to 2?
I made a test with some configurations and the thumbnails still look pretty antialiased. This way we can at least shorten the render time...


lowercase


Just call mSendButton.setEnabled(sendable), and you won't even be able to click on it anymore (as God intended)


It's better to not right defensive code like this, because it can obscure serious problems.


112083967_VentilatedSlab (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (2057 of 2057 tests passed, 0 test warnings)

 * 6 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The summary is meant to be read at the end of the (let's call it) *lecture*, while the other 2 are meant to be read at the beginning. The TL;DR is meant to be written last and be understood by those who already learned the *lecture*, while the abstract is meant to explain the *lecture* to those who didn't already learned it.


most swift community guides state force unwrap is a bad practice, simple guard statement might be better


Is it on purpose to include only file output in the configuration file?


I should've said that, instead of that long, useless, talk...


Hey Brandon, I don't see that behavior. Can you try with 2.0.4?


Yeah, I know, I just didn't feel like looking for it. There's nothing that uses this right now anyway, I just wanted to restructure the code to make it possible.


For performance it basically doesn't matter, virtual calls can only be inlined when the exact derived object type is known. I just like placing one-line functions in headers.


nice catch :]


Does Spinnaker ever perform any check of the health of their ELBs? If so, we probably will need this method at a later date, however we will need to revisit the code cause I'm not sure "Provisioning State" is what we will want to check.


Yes, backward compatibility to S3, Tab 10.1 S5 etc.
And easier handling of that more simple sysfs (expecially on the OP2)


Why did the azure provider get deleted?


TeamCity pull requests :: netty [Build 1079](https://garage.netty.io/teamcity/viewLog.html?buildId=4960&buildTypeId=pulls_netty&guest=1) is now running


Thank you!

I fixed the image file paths—totally dumb mistake.

I moved the h1 style to the stylesheet, however I can’t get text-decoration: none to work now. It’s underlining the link.

Moved the title and meta tags to head.

Having a hard time figuring out how to properly scale the images—I just keep guessing px and refreshing—surely there’s a better way to do this.

Also, is there some secret to know what order the attributes need to go in on the stylesheet? The only way I am able to figure it out right now is to move them around until Sublime shows the right color for it.

Thanks for your help!
emily

> On Jan 21, 2016, at 1:08 PM, Stephen Bae <notifications@github.com> wrote:
>
> <img src="images/emily, Modern Farmhouse.jpg" these  tags will work as long as you correct the file path (src). Should be images/Modern Farmhouse.jpg and same for others :)
>
>
> You technically do not need this block in HTML since you are already linking a css file to this HTML page. and this should go to your style.css instead.
>
> 3.
>
> <title>Emily Pecot Portfolio</title>
> <meta name="Emily Pecot Design"/>
> <meta author="Emily Pecot"/>
> <meta tag="web developer, portfolio"/>
> Let's move this into  since head block in an HTML page should include <meta>, <link>, <title> and all the necessary resources for the page.
>
> Other than that, very well done Emily!
>
> Stephen
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/empecot/basic_personal_website/commit/a48eff8d8dc87592d5905122290f569edfb176f0#commitcomment-15593144>.
>


lowercase


I think this statement isn't necessary since this functions is declared with `CONSOLE_BRIDGE_DEPRECATED`, but I guess it doesn't hurt anything.


short term promisify done here https://github.com/npm/newww/commit/588fe8250ae1fd192542a8101011c6ff4ac6ca5e


TeamCity pull requests :: netty [Build 1079](https://garage.netty.io/teamcity/viewLog.html?buildId=4960&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:32


tu n'es pas obliger de faire 2 fois in, tu peux écrire
let a = ...
let b = ... in
c


ugly, `shrink_to_fit()` is required, because the new array slice is a view into the old data?  a non-iterator for loop should work.


Maybe we should whitelist `tier`, to avoid memory leaks (lots of keys?)


There was a bug in `removePath` as well, this line was wrong:
`[_referringObjectToPaths removeObjectForKey: referrer];`
It was clearing all the paths linked to that referrer, instead of just `aPath`.

Your new `-removeReferringObject:` looks correct to me, I'll replace the code with that


I suppose it will get added once you have patches ready. Also, any plans on doing anything interesting with TWL_FIRM? Emunand patches? Should be possible. I do know the CXI from emunand is what's used to boot TWL_FIRM because I intentionally broke the one on sysnand and TWL mode still boots from emunand. :P


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12238](https://teamcity.mesosphere.io/viewLog.html?buildId=109786&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:08:58


abstract out the command lines


Just curious: why this change?


@JeffBezanson do you remember why this was commented away ? it's from a 2012 commit https://github.com/JuliaLang/julia/commit/1b1978fbd8014ff18edfe0de05ddfb62a5b447e7 but I'm not sure why this would be part of the fix.


Great fix @audev, thanks.


remove unused config files


Nice! :+1:


cool.


Yes. I understand. But is request and a Idea, because if you see another system, they work like this.(Check a E-commerce for example, when you select to see the itens in category, he shows all itens in the category + subcategory. I think is a default, probably, is default in my country.


I'm really confused. To me, TLDR looks just like Summary in terms of the problem it solves. Where you stick it (start or end) is irrelevant.

So which problem does the TLDR solve which is not solved otherwise? Illustrate this with a concrete example.


Also delete server?


stylistic nitpick: doesn't `${ID} == "null"` conform better to programming norms?


Why was it deadlocking?


@caduvieira além disso, mais informações sobre essas variáveis de ambiente podem ser encontradas na documentação em "Utilizando variáveis de ambiente" na parte de [implantação](http://servicosgovbr.github.io/portal-de-servicos/implantacao/documento-de-implantacao.html).


Nie.

czw., 21.01.2016 o 18:17 użytkownik MaciejSzaflik <notifications@github.com>
napisał:

> hej, mam takie głupie pytanie:
> To zadziała jeżeli aplikacja jest z plikiem obb?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/xavarius/usefulAndroidScripts/commit/2407bc4fbf3425fabac07740e17348874d755999#commitcomment-15591887>
> .
>


Nice Cleanup.


Well, the process9 code is pretty much shared between both AGB and TWL. Patching one for emuNAND would make the other possible too. I've looked into this, and I've noticed the nand_read and _write functions are the exact same as NATIVE_FIRM, but I have been unable to find the sdmmc structure, if it's being created at all.


Create a new gem for adding extra hdd on running VM, avoid using curl


This is for #14


This will break upgrades -- existing secrets won't be able to revoke. This needs to gracefully handle the lack of `is_sts` by assuming IAM (e.g. just forcing `isSTS` to `false`)


We don't really care about anything inside phone number.  It is mostly about phone type and phone number.


C'est a ce moment que c'est le chaos :p


112158233_PVwithStorageSystem (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2050 of 2050 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


`helpers` is not an appropriate name for this package. How about `drivers` or `dynamicdrivers`?


Are you sure about this? Here this changing cause loss data on parse serverTalk


ok cool.


Ok, the issue was raised here: https://moodle.org/mod/forum/discuss.php?d=325929#p1312055 - I've now addressed the issue and only display a figure if there is a sub-category:

![2016-01-20 15_52_23-moo30_ course categories](https://cloud.githubusercontent.com/assets/1058419/12490324/dfb43c20-c06c-11e5-85ad-1eb34ade3882.png)

That is the way I have implemented it.  Now you are saying that because it does not match the way in your country I have to change it?  Yes or no?

Ok, if I get fifty people 'complaining' about it on the themes forum then I'll change the minus to a plus or just the total number of courses or add a setting to set the two.


Si! ahí en el siguiente commit resolví con un solo beforeEach


Nice, I need to start using aliasing too.


By having a standardized sysfs for it, my config app can use the same nodes for all devices, that is the main reason behind. Nothing else :)


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 80](http://teamcity.otenv.com/viewLog.html?buildId=4023428&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) is now running


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 80](http://teamcity.otenv.com/viewLog.html?buildId=4023428&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) outcome was **FAILURE**
Summary: Exit code 1 Build time: 0:0:0


TeamCity libpalaso :: palaso-precise64-libpalaso-2.6 Continuous [Build 2.6.1027.8e818b7126c3efe81b766ba74c286a98444cbf64](http://build.palaso.org/viewLog.html?buildId=68327&buildTypeId=PalasoPrecise64v26Cont) outcome was **SUCCESS**
Summary: Tests passed: 3377, ignored: 124 Build time: 00:08:22


Let's switch this to using log.Fatal as opposed to os.Exit(1)


Just switch this to log.fatal()


test commit


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.652.085a339eeda6b14c5f7f2cc0d29e3768a5b82373](http://build.palaso.org/viewLog.html?buildId=68330&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3324, ignored: 125 Build time: 00:08:24


Install from staging forge.


keep as error, but outside of for loop, add a log.Fatal("Encountered multiple errors loading drivers.")


`Seq(phoneType, phoneNumber).flatten.mkString(": ")`


Remove this line.


Got it. CPU boost might not be available/used on non-CAF kernels.


i was on the read me brunch


missing new line


you should have the inverse flag here, since the default behavior is for purge to be always enabled.


unused


delete dead code


if the disabled flag set to true, this branch becomes really simple with just a log and return statement here.


same as the other comment.


maybe something like:

````go
var err error
var device string

device, err = sh("rbd", "map", "--id", d.user, "--pool", pool, imagename)

if device == "" {
    device, err = getRBDDeviceName(imagename)
}

return device, err
````

I haven't "golanged" in a while so this may not be entirely correct syntax, but that general idea.


Yeah i'd love to do that, but I'd say one thing at a time. I was going to visit that once im done with the settings menu


use `org.jetbrains.kotlin.resolve.DescriptorUtils#isLocal` instead


No. You don't need change it. How I say, it's a idea and in my country is default the category counter is like this.
I report the error for you in moodle forum. You work is very good. You fix the error in 2 days. It's a great professional. No more, I already adjust my moodle.


Heh. Given that patch was the first time I've EVER golanged, I'm not one to
judge :)

On Friday, 22 January 2016, Adam Avilla <notifications@github.com> wrote:

> maybe something like:
>
> var err errorvar device string
>
> device, err = sh("rbd", "map", "--id", d.user, "--pool", pool, imagename)
> if device == "" {
>     device, err = getRBDDeviceName(imagename)
> }
> return device, err
>
> I haven't "golanged" in a while so this may not be entirely correct
> syntax, but that general idea.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/deanpemberton/rbd-docker-plugin/commit/10300b88fa02ad4419b4426e532847520cfa22d1#commitcomment-15593839>
> .
>

--
Regards,

Dean


Have you tried to use the [sh()](https://github.com/yp-engineering/rbd-docker-plugin/blob/d46eff2ecff6f47d5ef06c84d48933c0140c8ac9/driver.go#L908-L916) command at all? Did it not work for some reason?


I hope this explains it:

---

Abstract:
> In this chapter we will learn to create buttons, text fields and forms. We will learn how to use a form to send data to a different page or the same page, how to use text fields and why those things are needed.
TL;DR
> Button: <button /> does not shows a link. The form often requires a link to lead to and need a button to send the data. The text fields can have a *default* value, also they can be hidden.
Summary:
> In this chapter we learned how a button is created and used, and why to have it, how we can create a form and it's proprietes, as well as the use of text fields.


<english> should be a string value in this line


112158233_PVwithStorageSystem (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (956 of 956 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.85%25-green.svg)


It worked. It's just that subsequent commands that need the device name
fail

On Friday, 22 January 2016, Adam Avilla <notifications@github.com> wrote:

> Have you tried to use the sh()
> <https://github.com/yp-engineering/rbd-docker-plugin/blob/d46eff2ecff6f47d5ef06c84d48933c0140c8ac9/driver.go#L908-L916>
> command at all? Did it not work for some reason?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/deanpemberton/rbd-docker-plugin/commit/10300b88fa02ad4419b4426e532847520cfa22d1#commitcomment-15593866>
> .
>

--
Regards,

Dean


I don't think this would work


TeamCity pull requests :: netty [Build 1080](https://garage.netty.io/teamcity/viewLog.html?buildId=4961&buildTypeId=pulls_netty&guest=1) is now running


Successfully created the [saml-availa](http://saml-availa-static-docs.pantheon.io/docs) environment. New commits to this branch will automatically be deployed.


`strtok_r` requires a non-`const` string.


Ok, so with respect, if you don't want me to do anything about it, then why tell me?

Are you Leandro?


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.663.085a339eeda6b14c5f7f2cc0d29e3768a5b82373](http://build.palaso.org/viewLog.html?buildId=68331&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3303, ignored: 106 Build time: 00:06:10


Yes, option will automatically become seq


it's easier to inspect the content of the return when debugging the code


@rufoa I've added getSingleton() method in StaticMarkerBinder and StaticMDCBinder classes shipping with SLF4J. Moreover, MDC and MarkerFactory classes now access getSingleton and if unavailable fallback to the SINGLETON field. See commit https://github.com/qos-ch/slf4j/commit/ea3cca72cd5a93

Please note that the SINGLETON field is public which caters for the case of an slf4j-binding version 1.7.14 or later is used with an older version of slf4j-api.

Obviously, slf4j-timbre will require slf4j-api 1.7.14 or later.

Please let me know if https://github.com/qos-ch/slf4j/commit/ea3cca72cd5a9329a06b788317a17e806ee8acd0 fixes issue SLF4J-347.

@rufoa May I have your name? It's for the news page detailing changes in 1.7.14.


Kuba, why you need to setup extraClassPath for executor and driver. We are already passing FAT_JAR at the end of commandline


What is this gperf patch for? Do we need a modified gperf in order to build freetype-infinality??


Good idea.


@coreyfloyd ya that's old cruft, but it may still be used in the editing workflow iirc.


@scaytrase Whats that `. chr(0)` for?


@coreyfloyd i think settings might be the last place this is used. whenever we re-organize/redo settings we can drop this as well


growl.  I eventually managed to test this: printing `CRYPTO_KEYMASK_READ` showed it was 2166, which converted to binary is 0000100001110110, which means that I should do

    ./tarsnap-keymgmt --outkeyfile foo.txt --keylist 1,2,4,5,6,11 ~/keys.txt
    ./tarsnap-keymgmt --print-key-permissions foo.txt
    This key has permissions for: reading.

I didn't try testing other keylist combinations.


NICE


missing file header


Done, thank you.


Is it necessary to make a copy here?


This seems really awkward, but as noted earlier, `strtok_r` requires a non-`const` string.


never throw `RuntimeException`. Use a framework/domain specific exception instead


I would really like to keep the Config class just with plain constants and no methods if possible.


This logging might be superfluous -- we may want to only log in some branches of this


full spelling of pv, vg, and lv


I've got a "don't allow more than one `--passphrased` argument" patch ready once this PR is accepted.


would it make sense to make this class (and others like it) `final`?


and add test, something like:
```kotlin
fun foo() {
    class A {
        inner class B
    }

    val b = A().B()
}
```


please fix


yea i need the assistance thanks


This is a noop. Why was it needed?


What do you mean?


these two conditions can be merged


112158233_PVwithStorageSystem (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2088 of 2088 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Right, but on line 71 of typeahead-filter.js we set the id of the filter checkbox to "C00431445-checkbox" and then pass that same ID through to the tag, right? Instead of setting the ID of that tag, shouldn't we just set a data attribute?


`onClearEvent: { (): void };`


There were 2 waitpid's at once on the child process and the status change is only reported to one of them.


Let's make an issue to promisify this at the source not here.


En effet, les commentaires sont uniquement sur le forum et les résultats uniquement dans la partie ALDP. Par contre, lorsque je crée une manche et que je définis une date de départ, j'aimerai pouvoir déjà compléter le message qui sera posté sur le forum lorsque la manche débute (c'est à dire lorsque la date de départ est dépassée). Ce message, on peut l'enregistrer soit dans une manche, soit dans un modèle séparé qui sert temporairement à stocker les messages en attente d'être posté sur le forum.


should return:
1) "2"
2) (nil)
3) "42"
4) (nil)


signature as well as verification code send to my personal account thanks!!


involve me yes!!


LEt's make an issue to promisify dropCache


Is this needed? Where does this rejection go?


ok


Nevermind, I see you changed it in a later commit :+1:


lol


make `final`


all the azure resource descriptions have been changed so this is base class is not needed anymore


Redis returns:
1) "string"
2) "boolean"
3) "string"
4) "boolean"
5) "nil"

ledis used to return:
1) "string"
2) "string"
3) "string"
4) "string"
5) "nil"


Check errno?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1211](http://teamcity.monogame.net/viewLog.html?buildId=13849&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:26:46


Ahh, I see that it was already there (in https://github.com/etsy/phan/blob/8df21721dfc352e0e9d2c2dfc246d07c297080e2/src/Phan/Log.php#L170)

I'm going to remove it for now.

@ablyler Do you know what that extra null is being appended for?


@gkalpak sure, why not


nicely done!


are these intentionally missing the `^`?


the whole class will go away when we move the azure load balancer to use redis caching.


import my gmail information to a private in application not public where only me to know knowledge thanks! Usedname Mimi2k16


Removed in https://github.com/etsy/phan/commit/bdbd087908a4427bbd28c1fa96c5e27b2268dd36


please spell message as "must not"


looks good


HBIRE_vector_take2 (amirroth) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


If we enter in the following branch errno will not be set.
Errno is only set in overflow cases.


I see. But I'm still not convinced this benefits anyone. We already have many types of sections. My notion of summary is a bit longer and it includes the information which you'd put in the TL;DR.

Anyway I'd wait for other opinions.

And even if we accept it, TL;DR and summary will not be there in the first draft of the guide (just the annotated TOC), most probably we won't have the abstract either.


Code in SceneSwitcher Update method is testing it. To change scenes, call the changeScene() from somewhere else.


I toyed with the idea of making this `GETOPT_OPTARG("--print-key-id")`, but the rest of the code assumes that the filename is on `argv` already.  Should I change that, either as part of this PR, or a separate PR, or leave it alone?

At the moment, it's missing the nice "`Missing argument to %s`" message.

```
$ ./tarsnap-keymgmt --print-key-permissions
usage: tarsnap-keymgmt --outkeyfile new-key-file [--passphrased] [--passphrase-mem maxmem] [--passphrase-time maxtime] [-r] [-w] [-d] [--nuke] key-file ...
       tarsnap-keymgmt --print-key-id key-file
       tarsnap-keymgmt --print-key-permissions key-file
```


Yea, I think a category makes sense.


Also privacy my Google play store in my mobile  device playstore and my gmail: garnet2324@gmail.com and mimiscarlett2k@gmail.com


I love how you tracked down the commit that did this, thanks so much for the effort!

This is not at all intentional, would you mind submitting a PR with a fix against the `v3.0.0` branch of this repo?


Yes, it is per the CodeClimate spec: https://github.com/codeclimate/spec/blob/master/SPEC.md#output


It should be count, == 0 here, sorry.


There are two signals mapped, one with status 0x90 and one with status 0x80, for [Playlist],SelectPrevTrack and [Playlist],LoadSelectedIntoFirstStopped. Is that intentional?


fixed


Do you know how much memory it saves to not make a copy here?  If it isn't significant, it might be worth keeping the copy in to avoid some potentially tricky bugs.


sure


Yes, they are. I will add a define for them


Hi @tgeczy, This commit and the four previous are from the SpeechControl branch. They were not supposed to be merged to the master-branch yet. But I screwed something up when I was doing a merge... Xcode's git-support is horrific so sometimes it does weird things. I can't figure out how to do a proper "unmerge" so I'll just leave the code on the master branch and clean up later.


@aredridel: Agreed.


fair.


Check namespace since (ns ...) isn't being used


oh weird. So this shouldn't be proper JSON then?

So sorry for the confusion on that @scaytrase; I'll fix this up.


Changed method to methods. I am going to leave the list as is for now since that matches the pre-existing examples.


I think this might cause an error...


See above


Oops.


this is a core class that initializes all the cache agents; for azure we only have three at the moment. in the aws implementation registry is been passed along/used when initializing other caching agents.


Good question. My current memory of this is that it was more of a desire for output consistency than a bug.

The way the handler originally works, the **_paging** property will only be populated on the result object if the API response includes a links header -- in other words, only if there is more than one page. I changed it so that the **_paging** property instead is populated when the "X-WP-TotalPages" header exists. Wordpress sets the "X-WP-TotalPages" header consistently on any paged request, even when there is only one page, while it does not set the Links header unless additional pages exist.

The difference is essentially that any paged request I make (using **page()** and **per_page()**) will now be ensured to have the expected **_paging** details on the response object containing the information on total items and total pages, even if total items is less than that requested and the total pages is 1. For me, that was more logical to implement in my application, although I think it's a good question as to which style of response is better.


I thought the extra parameter was going to propagate through DeskKit API. Looking back on the DK*.h we did add a property (but did not remove anything), so I think the proper version (if we follow semantic versioning) should be 2.1.0.


Potentially a lot. We do this for encoders and decoders, which for the most part remain the same. So in the past we've been making unnecessary copies. Also, initial weight matrices for learning connections, maybe other stuff too I'm not thinking of. I've tried my best to make sure that those bugs are avoided by setting `write=False` on the view. The one place where there could be bugs is if a user takes the built parameters from `sim.data` and changes them. Maybe we should make those read-only too?


The scan failed.
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


@tfoote I have modified take_photo.py for using in the next lesson.


Changed


this comment is for internal usage only and does not go to the netflix pr.


Thank you for response! I got the purpose of this check but it looks like new function `_bigDecM` returns `bd` independent of `rs` was null or not. Maybe I misunderstood something fundamental but if we remove 628 and 629 lines, anything will change?


Each output is a separate json blob separated by a null.


This is a noop


i'm still unclear on how flatten is a safety measure.  flatten changes the structure of a nested list.  so if it's being inserted here and changes a nested list, then things in later steps might not be operating on the structure they expect.  if the list isn't nested, it has no practical effect anyway.  i don't understand the benefit.

i don't think there are any tests for this behavior.  that's not a defense of the current structure, just another point as to why i'm a bit worried about doing this sort of thing.  it seems like extra work for extra worry, and no sure upside.


I think this is indeed a bug. Moreover, since there is no longer a caller, it should probably be removed entirely.


I'm not sure why this is failing @mbland any idea?


I think that here, during `CommandFetchNodes::procresult()`, the node shouldn't be notified neither set as changed. The changed flag is definitely for action packets or the `CommandSetPH` itself.


@mmundy42 Are you getting the same error after a pull?


HBIRE_vector_take2 (amirroth) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2075 of 2089 tests passed, 502 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.33%25-yellow.svg)


This was duplicated. Removed.


Should the addition of this Apache License file be added to LICENSE.txt?


no specs for rake tasks that i'm aware of.

i think the right thing to do is to have the htaccess generation be moved to code in `lib/` or something, write specs for that, and invoke a single lib method from the rake task.  no spec to make sure the rake task does exactly what it should, which is regrettable.  but it'd make the central logic of the rake task reusable and testable, which would be a big gain.

outside the scope of this issue, though, i think.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12241](https://teamcity.mesosphere.io/viewLog.html?buildId=109833&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:07:59


You made IE look better? :O


TeamCity pull requests :: netty [Build 1081](https://garage.netty.io/teamcity/viewLog.html?buildId=4962&buildTypeId=pulls_netty&guest=1) is now running


Nice to see some GUI work.


+2 Will squash and merge


none other than the class names follow the pattern used by all the other providers (see aws/google/cf)


Initial


Consider adding javadoc comments in the future to help other developers understand how they should implement your interface.


Break Dream C Club Portable
http://www.emunewz.net/forum/showthread.php?tid=92836&pid=229295#pid229295


issue for the htaccess refactoring:  https://github.com/sul-dlss/argo/issues/469


Yeah, I guess so... thought I don't like it ;)


@ablyler This should fix the code climate output format.
@scaytrase Sorry again for getting that format wrong and asking you do work to change it.


comment here


Probably don't need to specify ArrayList as the return type. The more general List interface might be more flexible. In fact if order isn't important you could use Collection?


I'm going to agree with @christophebiocca :  bug-for-bug compatibility more important here.

@zander : thanks for the review, I cleaned up the size_t/uint64_t issues with the ValidationCostTracker (went with uint32_t -- don't need 64 bits (BIP101 did, 2MB bump doesn't) and don't like that size_t is different sizes on different machines).


I have tried inserting "./jhoveConfig.xsd" in there, but it didn't work.
I found conflicting info online, on whether relative pathnames are
allowed in schema defs.

I would come up with something, if it were *my* code, that needed to
validate that file. But it's buried inside the jhove .jar library that
we use.

I will modify the installer script to adjust the path in new
installations, to match the user's location of Glassfish.
And for now, I'll just add a paragraph to the 4.2.3 release notes,
telling both new and existing users that this needs to be done by hand.

But yes, I hate having a hard-coded path in there myself. But it really
solves some issues, to provide the schema locally.

On 1/21/16 7:44 AM, bencomp wrote:
>
> Can't it use a relative path to the XSD?
>
> —
> Reply to this email directly or view it on GitHub
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_IQSS_dataverse_commit_a90be2a49146b7e5b2d1c9b7d9c899891a14ab9b-23commitcomment-2D15584398&d=CwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=Wyoaab-62YLl40kAZBx0_PvdnyX0x8nOcegnuRFUlgM&m=kASFgPSEdGA2sj1eg3AOUhmII-3yH23D7hzzxGkrDmM&s=ytWKTlfI8kyfuYGm9ogbdZwkUSnqarDL2lPEZFSrvXU&e=>.
>


This double-logs with reply(err) below -- let's just log the < 500 branch


I have a placeholder for it inside prv_cnf_Task see "gitSHA" column. It is probably too simplistic: I am basically assuming that there will be only one module that needs to have version tracked for each task. That is probably too naive, but it is not hard to change it, we'd basically need to have a separate table with 3 columns: taskCnfId, moduleName, gitSHA. Do you want me to add it now?


brain fart. removing.


ok


Why is KVariable treated differently? I looked briefly, but it's not obvious to me. It would be more readable if we could treat all KLabels the same way or at least document why KVariable is special.


I'm not sure we really want to halt the system because the pinmux initialization failed. I think we should halt the system only in very special cases such as when a double fault occurs (see cpu.c).


:+1:

Tech Review: Looks good.


I think that was a brain fart at the time, I rewrote how this ended up working.


Pushed.


I would make that a boolean: should I check or not?


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1242.f4adac422e8e29637463cd50bb75830103c10eb0](http://build.palaso.org/viewLog.html?buildId=68349&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 842, ignored: 7 Build time: 00:06:55


"Not ready"? Have you looked at [glide](https://github.com/Masterminds/glide) for dependency management? My todo contains looking into it for use with [Logstash Filter Verifier](https://github.com/magnusbaeck/logstash-filter-verifier).


@pombredanne I think it is ok since this has been working for a while now without needing to be escaped.


IMHO, it's safe to define a constant for this, with support for user overwrite with `make -DCACHELINE=2^57885161-1` defines.


@UniversalMediaServer/developers I had to do a rebase, this is the current commit with the changed database implementation that I feel need proper testing.


Hello


Create "index.html" file.


Hi. I am Leandro. I tell you in e-mail because I will want you, but in future.


Neither of the above :). See prv_cnf_Task_KVParams, it is a set of key/value pairs basically. I did not optimize for the case you mentioned though. I'll add it to my notes, and will think about it.


Yeah, universal reactions should have the “type” field set to universal, not the complex field. The complex field should only have complexes.

--
Chris Henry
Sent with Airmail

On January 21, 2016 at 12:57:36 PM, samseaver (notifications@github.com) wrote:

@mmundy42 Are you getting the same error after a pull?

—
Reply to this email directly or view it on GitHub.


Then here, I would do instead:
```
if (global()->settings().checkVersion())
{
    UpdateCheckDialog update(&mainWindow);
}


For anyone reading along: This is the `user: "1000"` that I mentioned in the README.


I think this should just be "suspicious" :).


Another thing I noticed about Janaka’s PR. There’s alot of thrash in the file because complexes seem to randomly switch order in the complex field. We should do some kind of sort when we print the those files to avoid this kind of thrash. This makes it easier to identify which changes are actually meaningful.

--
Chris Henry
Sent with Airmail

On January 21, 2016 at 1:05:10 PM, Chris Henry (chrisshenry@gmail.com) wrote:

Yeah, universal reactions should have the “type” field set to universal, not the complex field. The complex field should only have complexes.

--
Chris Henry
Sent with Airmail

On January 21, 2016 at 12:57:36 PM, samseaver (notifications@github.com) wrote:

@mmundy42 Are you getting the same error after a pull?

—
Reply to this email directly or view it on GitHub.


(removing all the above, between the two comments)


If you've set both --with-cc and --with-cxx, why would you want to check for a host Clang?

(Also, it would be nice™ to infer one from the other, since they are almost always the same.)


I imagined we'd track at least some things inside provenance. prv_cnf_Node is meant to depict that. We should discuss that with NCSA. I'll add the note on my todo.


Few dangling print statements.


Minor: revert changes in A.kt would be simpler


I know, but when I started the script without it, it crashed during calling
H2OContext(sc). I searched the web  for
the problem and it looks like the working solution is to set
spark_classpath and since this is deprecated, we have to set these
configurations.

Can you please try to run it without the lines I added? I believe that you
will experience the same problem.

But let me please know
On 21 Jan 2016 19:41, "Michal Malohlava" <notifications@github.com> wrote:

> Kuba, why you need to setup extraClassPath for executor and driver. We are
> already passing FAT_JAR at the end of commandline
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/h2oai/sparkling-water/commit/fdc92d817c665c7a4640632ff8bd9c2cce8bd4d7#commitcomment-15593957>
> .
>


Do we really want to enforce users to use a certain license? Do we want to overwrite the license in the beat update? @tsg @ruflin what are your thoughts here?


Looks like we should be reading this parameter in dns itself, instead of reading it in main and then passing this setting to dns


I could sort the complexes for each line and commit.


Isn't godep obsolete here?


@pombredanne I will escape it in HTML to be on the safe side.


yep, you're right. Good catch. Thanks!


Successfully created the [machine-tok](http://machine-tok-static-docs.pantheon.io/docs) environment. New commits to this branch will automatically be deployed.


This seems to be a common error message. Could you refactor it so that there is less duplication?


1. can't this be left to [operator ()(T lhs, T rhs)](https://github.com/mapnik/mapnik/blob/0e836d7e204ad0a71008cb4826064d9c7d689621/include/mapnik/value.hpp#L648)?
1. true / false == true?
1. true / true == 1?


I don't like null objects.


When You nest text inside textinput letters show up with delay or misplaced.


will do


ok


Setting `write=False` doesn't prevent the base array from being modified though right?  I'm imagining someone creating an array of the encoders they want, building a model with those encoders, then modifying their original encoder array.  That would, probably unexpectedly, change their encoders in the first model next time it is reset, if I'm parsing things correctly.


"isIoFied" -> "isIoField".


How could you transform all guesses to lowercase automatically?


The `0-0-0-mosaic.png` expected image change now no longer contains overlapping geometries in the center. That needs some explanation @flippmoke so we know what changed.


See further discussion: https://github.com/doorkeeper-gem/doorkeeper/pull/769#issuecomment-173612037


Is there a way of detecting this automatically?


The reason for this is because I have added a "Don't remind me about this version again" option to the update dialog, in case users are not interested in this particular update, but are still interested in future updates. To do this, the version to compare against needs to be stored.


This logging has been removed.

Right now, I'd prefer to not have big old issues with caching blowing our stuff up, so this rejection ends up sending us into `reply(err)` mode.


Overwriting the configuration file might be problematic here when the user is changing the etc/beatname.yml file instead of etc/beat.yml. A warning message or just a backup of the old configuration file might be a solution to this problem. @ruflin @tsg


removed.


Why yes it is. For some reason when I was working on it it seemed necessary to add.


Hm, would this theoretically allow changing the code for the anon inner classes in SV to use this feature instead? E.g. by providing additional SRG lines to MixinGradle which would then reobfuscate the anon inner class targets in the refmap using the additional SRG lines we give to it.
I'd personally prefer that option over changing the way SV deobfuscates the code like we have it right now.


Incidentally, I do see that this change might contradict your READ documentation:

> The existence of the _paging property can be used as a flag to conditionally show or hide your paging UI, if necessary, as it will not be present for single-page or single-item responses.

In the changed handler, one would want instead to check for 'next' and 'prev' properties on **_paging.link**.

I do think a case can be made, however, that it is better in line with this:

> ... paginated collection responses are augmented with a _paging property

To me, being able to rely on having that information on total results and total pages in any paged request makes the most sense. But it's certainly up to interpretation.


Make sure you're using spaces instead of tabs for indentation!


:tada:


Avoid committing commented code


@normann what aspect of the SS 3.2 API has changed that makes this necessary? `File::find()` returns `null` or a `File` object via `File::get(), so I don't understand why removing the type-hint is required?


Could you use the interface List rather than ArrayList as the declared return type to give more flexibility?


:( ale ty i tak chyba rzadko musisz dzielić aplikacje na kawałki


Sure, here is the full request w/ version 2.0.4 (oauth token removed):

{ request:
   { uri: 'https://sandbox-quickbooks.api.intuit.com/v3/company/1314009425/preferences?minorversion=4',
     method: 'GET',
     headers:
      { 'User-Agent': 'node-quickbooks: version 2.0.4',
        'Request-Id': '817c34f0-c06c-11e5-a930-53b3aed1abd3',
        host: 'sandbox-quickbooks.api.intuit.com',
        accept: 'application/json',
        Authorization: 'OAuth oauth_consumer_key=
      }
   }
}

I don't think this should affect the call at all, but my stack is meteor.js, using meteorhacks:npm package to run npm packages with meteor.


TeamCity Chorus :: chorus-precise64-chorus-2.5 Continuous [Build 2.5.1011.bab9ad24dc6ac370cd6b01ef876ee8b815ba2fe8](http://build.palaso.org/viewLog.html?buildId=68346&buildTypeId=ChorusPrecise64v25Cont) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:18:44


TeamCity LabKey :: LabkeyModules15.3 :: Git sqlserver 2014 [Build 93](https://teamcity.labkey.org/viewLog.html?buildId=298503&buildTypeId=LabkeyModules153_GitSqlserver2014) outcome was **SUCCESS**
Summary: Tests passed: 218 Build time: 00:25:06


Should people be able to disable logging if they really want to?


Not sure if you need this as a field?


is 4 * 4k an intuition? or what is the reason for that number (I'd expect the size of a page would be a good candidate as well)?


I just tried this.  I actually think for this case overload is better.  If you have a template like this

```c++
template <typename T>
void foo(T bar);
```

then provide some specializations
```c++
template <>
void foo(int bar) { // impl }
```

Now if you call `foo(3.0)` for double, it will still compile, but there would be a obscure linking error because `foo(double)` is not provided.

If we used function overloading, it becomes a clear compilation error, not link error.

Do you have suggestions of how to do this with templates that avoids this problem?


Sounds good. Easy to find prior art as well
On Jan 21, 2016 11:30 AM, "Domenic Denicola" <notifications@github.com>
wrote:

> I know it's bikeshedding but I think .jsm ("JavaScript modules") might be
> better. Exposing JS developers to the fact that there's an ES vs. JS naming
> split, or an
> organization-formerly-known-as-the-European-Computer-Manufacturer's-Association,
> seems bad. Stick with "JavaScript".
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bmeck/node-eps/commit/8e35cccc92896d06716996b4e324fac27ac4e4e7#commitcomment-15592184>
> .
>


I am hoping that won't be an issue because tasks will be executed for a relatively long time, I'd imagine. One easily solution would be to use time of the middle of task execution instead of start or end time.


I think Phil is right.  There seems to be some problem with using aliases in group by expressions.

There is a ticket for this with more examples.  Some of the example are spurious, showing that my expectations were incorrect.  But some of the examples seem to be bugs.

The ticket number is ENG-9782.


Did you mean to include debugging text here? :smile:

In the future, you may consider using the Rails Logger, which is built in and has a lot of other benefits. http://guides.rubyonrails.org/debugging_rails_applications.html#sending-messages


Yes, that's similar to what I was saying with modifying things through `sim.data`. With encoders, it would actually never be a problem, since the simulation just uses the scaled encoders which the user won't have unless they look in the built objects in `sim.data`. But in general it could be a problem. I'm not sure of the best solution. Maybe make an issue to discuss?


I _do_ understand this one though because "HtmlEditorField_Image" does _not_ subclass `File`.


This is so great. :)


You've convinced me, that's a solid argument for consistency! I can make the change tonight, unless you'd like to submit the PR?


Instead of .build and then .save, you could just use create:

```ruby
# favorite = user.favorites.build(post: self)
# favorite.save
favorite = user.favorites.create(post: self)
```


I'm not sure we need to be that detailed.  How about

If any value in `ref` is to be updated more than once, because there are duplicate entires in `indices`, then the order of update for each individual value is undefined.


No need to specify that these are public and abstract as this is implicit for interfaces.


:+1:  best commit ever :dancer: :dancers: :dango: :accept: :cake: :camel: :last_quarter_moon_with_face:


Would still be nice to make it clear what we are assuming here. If the system breaks down if "tasks" take less than a second then state this up front.


Might be worth using `head` here rather than `only`. The latter will only get an element if the list is of size 1.

Until #32 is implemented I think we should just kill off the Scapegoats 1 by 1 until they're all dead hah.


Note: This is superceded by zhengxq's comment.


Should this return the empty string? Or is it really an error case that should be handled with an exception?


Great, really clean.


So should i add a 3rd bullet? I think the 1st one (which is not about forensics at all) captures to some extend what you mentioned.


Thanks. :) I just notice, I somehow forgot to include the lines for the ethereal update.


You can get to them with

```
$form_state->get(['entity_browser', 'selected_entities']s)
```

as soon some entities are selected. List will be empty initially of course.


A best practice for Mailers is to use `deliver_later` with no parameters rather than `deliver_now`. When you don't have an ActiveJob system set up, `deliver_later` will be automatically sent right away, but if you decide later to set up ActiveJob, `deliver_later` will automatically use that queue.


@AndreKlang It's going to lead to problems somewhere down the line anyway, so making the customer aware of them as soon as possible is a good general practice, no? While I agree with @aait that we should accept the full range of allowed UTF-8 characters, that is not the case in the current API and I highly doubt it will ever change.

If you have ideas on how to ensure that no unacceptable characters reach PayEx API before the SOAP request is submitted, please bring them forward. Automatically replacing disallowed characters has been brought up, and I can't say I'm a fan of it, since it may lead to unexpected results.


@gregkorte Thanks for the comment! I stopped passing the tree object to the growYourTree function and I see that the function still works as it should. I am guessing that the reason it's unnecessary to pass the tree object to growYourTree() as a parameter is because I already declared the tree object globally, so it's redundant to pass it locally as a parameter, too. Do I understand this correctly, or is there more to it than that? In general, I am still not 100% sure on when a function needs to have parameters, versus when they are not necessary.


I'm not sure I care too much.  I want something that works. ;-)

We have the ability to inject a web proxy in the path to cache traffic if that is the problem.

In general, I'd prefer cleaner ansible roles than anything at this point.  Seems like direct download would be fine.  These aren't huge images.


I did a little more testing. I previously had an empty string ("") in place for the id before your update. I hadn't removed that, and things worked before 2.0.2, but not after. I removed the empty string, and it works...now that I re-read your code above, I understand why. It was thinking the empty string was the callback.


Could roll it into the discussion in #933, which is related. If we do the probe thing I suggested, then you'd have to explicitly ask for something, which would make the memory cost more obvious.


I went ahead and made them all bullets


For public dns records, the environmentName in FQDN becomes redundant. We should parameterized fqdn construction, and pass the required option as a command option in image template (similar how we do provider's pick). Default way would be serviceName.stackName.envName.rootDomain


Fixed


no


oops


PlantCompBaseClassAgain (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2050 of 2050 tests passed, 329 test warnings)

 * 331 tests had: AUD diffs.
 * 329 tests had: BND diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Tried this combination, but it's still failing. Try e.g.:
```
chmod 0600 /etc/httpd/conf/*
```
and run the scan. Actually wanting:
```
-rw-r-----.
```
or stronger you would just enumerate those '-' fields and require them to be set to ```false``` (when using AND) operator. The rest fields (user's read perm, user's write permission, group read permission would be irrelevant). If they are all set, the mode would be ```0640```, is some of them isn't set, the mode is stronger.

E.g. something like ```rsyslog_files_permissions``` check is doing right now:
https://github.com/OpenSCAP/scap-security-guide/blob/master/shared/oval/oval_5.11/rsyslog_files_permissions.xml#L92

(try to set e.g. ```0400``` mode on some of the system log files. The check will still pass).


What is the dockerizer repo? Any way we might be able to support this upstream?


Underscore variable names if they are more than one word! `bike_number`


No comma after "day".


oh crap wrong pull


OK, whatever you think.  Sorry, did not want to bikeshed this.


After reading all through #3500 I'm not sure this is actually necessary.  We should make a test to be sure, although it's tricky to even tell what the failing case would be.  Like you said, we never explicitly documented that this was a merge, but if we don't _need_ to change it, might as well just document the way it currently works rather than making a breaking change.


>All commits but dbfa026 are ok with me. For dbfa026 I would like to be sure, that if you load a Groovy instance and use the thread local, that the JVM can still later unload it again and there is no JDK-internal data structure preventing this.

Thanks for reviewing.  Since the change to the ThreadLocal is not needed in order to fix the issue reported and the other 2 commits are not dependent on it, I will open another PR for changes that were done in dbfa026 if I can show that it will not prevent the GSE/LocalData classes from being collected.

I think GROOVY-4177 was a different issue (no cleanup of the ThreadLocal was being done) and has already been fixed by GROOVY-4130.


HBIRE_vector_take2 (amirroth) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (957 of 957 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.86%25-green.svg)


These are magic numbers. You could improve this by declaring them as constants or create variables if you plan on changing them.


I think CodeClimatePrinter could be not a FlushablePrinter but a generic one. There is no need  in flush operation for this output format


Note: we've moved away from the ruby version, so this should no longer be necessary :)


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.165.8515507208c1539220ebee854cf5e7e479e1de6d](http://build.palaso.org/viewLog.html?buildId=68338&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 943, ignored: 50 Build time: 00:37:17


I think it's ok and it is consistent with how it was before.


We have to be careful here, and either make this parameter - token - optional, and don't error out if not present, or set the minimum Rancher version to 0.57 (or whatever version where token support has been added) to the updated external-dns template.


This error doesn't quite make sense when you specify the spl directory using the `--with-spl` configure option.  You'll want to move this in to the AS_IF conditional, `$splsrc` will be set to the provided path.


is this supposed to say `characteristic` in singular?


I'd call this getNewTableLayout


TeamCity pull requests :: netty [Build 1080](https://garage.netty.io/teamcity/viewLog.html?buildId=4961&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6381, ignored: 23 Build time: 00:43:10


TeamCity pull requests :: netty [Build 1082](https://garage.netty.io/teamcity/viewLog.html?buildId=4963&buildTypeId=pulls_netty&guest=1) is now running


You could just set `DOKKU_DOMAIN` in your `~/.bashrc` or similar to this :)


You probably also want to do something other than just print the stack trace here.


All parameters have a reference to their tool, maybe instead of passing ``app`` around you could just add

```
@property
def app(self):
    return self.tool.app
```

to ``ToolParameter``.


@akozlova `CharacterGraph` and `IndexedGraph` could be removed, as far as I see they didn't contribute to the slowdown in IDEA-149952. I would've excluded them from the report if the editor didn't hang.


@springmeyer this is due to a change in the buffer size


Did we ever merge your shellcheck changes?


@rcoup well, that particular one seems sane now. It needs to get a queryset from somewhere, and if you don't override `get_queryset` and don't provide a queryset arg, it's an actual error


Good use of abstract methods


I suppose that (1) could be seen as a special case of what I'm saying: working out what went into a particular product so that you can either regenerate it or generate it in a different way. I had another thought on this as well: In previous life we used provenance to also decide which products had to be remade if it turned out that one of the inputs was bad. At JCMT sometimes we would decide months later that an observation should not be used in the group coadds and we used provenance to decide which products were contaminated and needed to be recreated.


`+    "Not wanting to take any chances,", name, " is promptly tied to a pyre and burned alive."`

This just avoids the use of too many "they"'s.


No need to declare as public. This is implicit in interfaces (otherwise it wouldn't be much use as an interface)


good job~


TeamCity pull requests :: netty [Build 1082](https://garage.netty.io/teamcity/viewLog.html?buildId=4963&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1801, ignored: 4 Build time: 00:01:34


Theano is picky about num types. Let's make sure to use float32 everywhere


Given the VSTS guys are now talking about moving to npm 3 even for Node 4 or 0.12.x, we likely need to also validate the npm version for the Windows case.  (Oddly enough we may end up needing to install npm 2 using npm 3.)

I know npm 3 breaks Cordova Create - however, I'm not certain it actually impacts anything.  We could have a checbox under advanced for the task called "Manage Windows npm version" to make this logic optional given there's overhead associated with doing the install.

OSX / Linux ships with npm pre-installed, so we should be good there.


spaces in function args


See #31.


Good abstraction and nice to see an immutable class.


Hi Lorenzo, M attending your class in Udacity. When I run findARestaurant.py in vagrant it doesn't print the required characters to the japanese or other locales on the console or terminal rather just outputs unicode strings. But if I use python3 it works as required! Can you explain the reason?

below is the output of my program in a vagrant terminal:
vagrant@vagrant-ubuntu-trusty-64:~$ python2.7 findMyRestaurant.py
{'image': u'https://irs1.4sqi.net/img/general/300X300/124505368_4A6d5gGK6mPzXQ7h
oYRCTkPJq18xl2K0hhEqR-xQWLE.jpg', 'name': u'PIZZA barcafe \u98ef\u7530\u6a4b\u89
7f\u53e3', 'address': u'\u5bcc\u58eb\u898b2-9-11,\u5343\u4ee3\u7530\u533a, \u677
1\u4eac\u90fd,102-0071,\u65e5\u672c'}
{'image': 'https://placeholdit.imgix.net/~text?txtsize=33&txt=NOT%20FOUND!&w=300
&h=300', 'name': u'Waffle, tacos and BBQ', 'address': u'Jl. KS tubun,Jakarta,Jak
arta,Indonesia'}
{'image': u'https://irs3.4sqi.net/img/general/300X300/87809650_hUCm0I8wy0-cRJW0S
mHK4iyDQg64aaU08Yhc0MyfsJ0.jpg', 'name': u'My Tapas @ Marisol Baia', 'address':
u'Mo\xe7ambique'}
{'image': u'https://irs0.4sqi.net/img/general/300X300/37230211_6LnbKTYYxF9drU5Rh
evgmrOaj27rruHHlXFKUu2ZBFQ.jpg', 'name': u'Just Falafel', 'address': u'Road 9,\u
0645\u0635\u0631'}
{'image': 'https://placeholdit.imgix.net/~text?txtsize=33&txt=NOT%20FOUND!&w=300
&h=300', 'name': u'Spaghetti Kitchen', 'address': u'Shop No \u2013 4, Ist & IInd
 Floor (Sundar Nagar Market),New Delhi 110003,Delhi,India'}
{'image': u'https://irs0.4sqi.net/img/general/300X300/6480155_eE-1x351SiNg-vZceE
qC1Kc2sUn0E-2YDzUlZMGM3_U.jpg', 'name': u'Tea-Room Cappuccino', 'address': u'Rue
 des Paquis 17,1201 Genf,Schweiz'}
{'image': u'https://irs0.4sqi.net/img/general/300X300/KEi8pONMVi-80G-rxKTWvwSj_s
XoVXkOh9nIyL2Xj3g.jpg', 'name': u'Sushi Gen', 'address': u'422 E 2nd St (btw Cen
tral & Alameda St.),Los Angeles, CA 90012,United States'}
{'image': 'https://placeholdit.imgix.net/~text?txtsize=33&txt=NOT%20FOUND!&w=300
&h=300', 'name': u"Rock'N steak", 'address': u'San Miguel,Bolivia'}
{'image': u'https://irs0.4sqi.net/img/general/300X300/1546047_Jd3-GMtAT3valE_N1-
5HbyAw7Vl8Mc4Qnzj7EvAxAwU.jpg', 'name': u'Gyros Fix', 'address': u'Unit 5, 118-1
30 Queens road,Sydney NSW 2046,Australia'}


Seed is sort of an id for a random number generator. The same seed will produce the same numbers which is good for repeatability. But if you want real randomness, you want a different seed. random.randint uses the clock


You want the matrix sizes to be random variables


Looks like we can store this info in the Metadata client (NewMetadataClient func), similar to the environment name, as this parameter will persist, and won't change.


> errore

@syl20bnr typo


+1 for `jsm`. parallels nicely with `jsx` also :-)


:heart: :+1:


Thanks :)


No need to use braces here, I shouldn't think.


Does it fix well known bug that db is not used for recent records?
When new file is added to db, UMS parse file continuously (every folder refresh) until UMS is restarted. After that file is not parsed anymore. I think there is already opened issue but can't find it from phone:)


Go away.


keyword args (foo=bar) have no spaces


Electric-Service-Refactor (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (2049 of 2056 tests passed, 476 test warnings)

 * 547 tests had: AUD diffs.
 * 477 tests had: RDD diffs.
 * 1 test had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: Table big diffs.
 * 2 tests had: MTD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.66%25-yellow.svg)


Shouldn't need braces here, either.


This one I don't understand either. There is no instance of `get_numeric_identifier()` that _isn't_ called in a `Controller` subclass.


@JINDALG One good way of making contribution is not to push Binary i.e .pyc files.
Instead put them in .gitignore of your repo on local machine :)


Yeah, I think it is a crucial feature for keeping hight quality code. But - on second hand - not all people thinks this way. Anyway, it's not a problem to restore it in a own project.


We use that constant in other places so I've just lazily copied it. I've tried with a bigger constant without much changes.


It's not a recommendation, but a future improvement. `BufferedPrinter`s  could consume more memory on large project analysis


I think TF uses class templates silghtly more than function templates, because you can specialize class templates, but only overload function templates. But this case is simple enough so it may not matter. So either way is fine with me.

You can trigger compilation error in the base implementation. For example, for CudaAtomicAdd, the base implementation, you can use atomicAdd. If anyone wants to call with a type that is not supported, that will be a compilation error.

If you have no valid base implementation, you can do a static assert. That way, if anyone call your base class, the compiler will complain.


Ah, makes sense.


*Runs and hides*


wrong commit message: remapped shortcuts


Add the list of columns to the message


It's ok?


Did this skeleton come from `rails new` or something? Seems like a bunch of stuff you don't need - rake tasks, `ActiveSupport::TestCase`, etc. I'd recommend `bundle gem`.

Although, it *does* seem like you're using Rails in your tests with some dummy app. It occurs to me that the Rails dependency isn't terribly strong here; use case, sure, but nothing about the actual code relies on it (save for the monkey-patching `ActiveRecord::Base.include` and such). Could probably simplify the gem to worry about plain-old-Ruby preloading.


hello,sorry if i post here but,
this -> http://hastebin.com/nuwiyofaxo.dos is a device or recovery issues ?
Moto G 2014 LTE (thea)  https://github.com/TWRP-THEA


I'll readd it to the code. I was waiting to push an update until I had some further feedback from you on the topic of https://github.com/robison/lua-geoip/commit/1d5b0b8d68cbb5a8ec660cfb949e7e905d8c6490#commitcomment-15564486


No it was not, fixed that now.


Yes, perhaps this check isn't good enough.

So the reason you see me avoiding ```rescue Exception``` is because it handles all exceptions, including the ones the module should not be handling, therefore this practice is not recommended. This explains rather nicely:
http://stackoverflow.com/questions/10048173/why-is-it-bad-style-to-rescue-exception-e-in-ruby

Would it be better to move this check to the beginning of the for loop? Or are you thinking about other possible errors?


NICE. Clear!


What if we have the default be `Logger.new(STDOUT)` and then if it's set to `nil` we don't log anywhere.  That way users can potentially disable logging.


i choose my fav


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.573.8515507208c1539220ebee854cf5e7e479e1de6d](http://build.palaso.org/viewLog.html?buildId=68347&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 931, ignored: 56 Build time: 00:18:14


Tabs! Tabs everywhere!

Y'all need some rubocop. ;)


I think you've committed this by accident?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12250](https://teamcity.mesosphere.io/viewLog.html?buildId=109905&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 174 Build time: 00:04:03


I am beginning to wonder if the locking was done on purpose.  I can see the case where 2 threads may be executing dependent scripts with the same GSE and even though it wouldn't be a problem with the CHM scriptCache, they would be racing on the `put`'s and I just can't tell whether or not that would be an issue (for example last modified times being set, etc.).  So I might be more inclined to leave the synch block and just go with commit 863247f.  What do you think?


LGTM!


Does rake release not work?


Works fine for me. What do you see?

![screen shot 2016-01-21 at 11 13 44 am](https://cloud.githubusercontent.com/assets/204723/12491960/af9e2cb0-c032-11e5-8ad1-db773c44d9ba.png)


Sounds good.


Yes it would.


capitalization difference in style?


I'm wondering if the i2c controller should configured in the platform main() instead of the pinmux initialization function.

Since we now initialize the i2c controller in main() and we know what i2c configuration should be applied in order to talk to all i2c devices from our platform, it might make sense to configure it in main() as well.

Does it make sense to you?


Remind me tomorrow what this means.

On Thu, Jan 21, 2016 at 10:42 AM, Spencer Lyon <notifications@github.com>
wrote:

> We should change this so that the subject line is bootcamp project ug
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DaveBackus/Data_Bootcamp/commit/3a4873fac0ecf52c2ffff1c6c6bcb73c6a5bafd3#commitcomment-15588796>
> .
>


112158233_PVwithStorageSystem (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1507 of 1507 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


If invalid referrer? Is this always guaranteed to be present?


Definitely! The specific flags applied to stack frames were just a first pass. The fact that they got us this far is better service than I'd expected. The middleware flagging functions are designed for easy composability, so if a concept comes to mind, it should be simple to add.


Is this always valid?


I think we should also check that `LoggerWrapper#logger` is set to what we expect.  Need to make sure that this logic is initializing the wrapper properly.


On first read, I see "false" and "true" for these values so I'd like better names.  Also, isn't transform for only the failure case equivalent to `recoverWith` ?

e.g. `insertBucket recoverWith { case regret => Future.failed { rollbackGroups(insertGroupTries.values, regret) } }`


What does this context title mean?  Passed as `10`?


Electric-Service-Refactor (EnergyArchmage) - i386-Windows-7-VisualStudio-12: OK (2049 of 2056 tests passed, 476 test warnings)

 * 547 tests had: AUD diffs.
 * 477 tests had: RDD diffs.
 * 1 test had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: Table big diffs.
 * 2 tests had: MTD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.66%25-yellow.svg)


this certainly needs to be addressed all over the place. Pinging @ncawthon - I'm going to switch everything to lowercase, because that seems to be the trend everywhere


Could you expand on what you mean by this? Are you talking about the hashCode of the parent types? Is this stable across invocations of the compiler?


Code is fine. The comment is a bit cryptic. Perhaps "Only store signature if we are unpacking content, don't store if just peeking." Or something like that.


Explain what node vs stream partitioning means in the commit message


Something looks bad here:

make: *** [/var/lib/jenkins/jobs/CM-TWRP/workspace/out/target/product/thea/obj/EXECUTABLES/recovery_intermediates/data.o] Errore 1

but you didn't provide enough of your log for me to see why data.cpp fails to compile.


capitalization difference?


I'll put it here so I don't forget:

This is the UG page and you told them to submit the final project via email with the subject saying `"bootcamp project mba"` when you really should say `"bootcamp project ug"`


Log output doesn't match anymore.


The referrer is set with: `referrer: validReferrer("/settings/billing", request.info.referrer)`, which starts with a default and overrides if the referrer is invalid, missing, or anything else incorrect.


Mind adding a test case to parser_test.py?


@jefflembeck - my rule of thumb has been, if I need punctuation, then I'll apply capitalization... or, if it is an official npm Product Name, then capitalization is also applied. If neither of the two conditions match, then keep it lowercase.


@forresst - Thanks again


If it is nested, it should not be nested, and flatten ensures that it can't be nested.  Chat on slack is preferred.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12255](https://teamcity.mesosphere.io/viewLog.html?buildId=109907&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:08:37


if you get null license, that means customer exists?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12252](https://teamcity.mesosphere.io/viewLog.html?buildId=109908&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:08:53


See: https://github.com/npm/newww/commit/c151d941afc33acfc7d75b2bccb01dfd8be312e2#commitcomment-15595283


TeamCity LabKey :: LabkeyRelease15.3 :: Git postgres 9.4 [Build 126](https://teamcity.labkey.org/viewLog.html?buildId=298496&buildTypeId=LabkeyRelease153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 19 (4 new), passed: 252 Build time: 01:40:54
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCounts: <no details avaliable>

##### there are 9 more failed tests, see build details
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12254](https://teamcity.mesosphere.io/viewLog.html?buildId=109910&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:09:04


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12258](https://teamcity.mesosphere.io/viewLog.html?buildId=109917&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:09:10


Cool, then I think we're good.


Could you ask Alex to review? I might suggest this could be a second activity just to keep the primary activity of Basic as simple as possible, but I defer to him.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12253](https://teamcity.mesosphere.io/viewLog.html?buildId=109911&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:09:51


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12257](https://teamcity.mesosphere.io/viewLog.html?buildId=109916&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:09:52


Nice try, but I'm afraid that doesn't count. :)


Should this be removed?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12256](https://teamcity.mesosphere.io/viewLog.html?buildId=109909&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:10:10


Rendering incorrectly because it's missing the closing single quote


Merge in from master


Thanks for catching that. Fixed in https://github.com/adhearsion/adhearsion/commit/d31f08313a2fac0a89d12e7d8d73e39cbe12eca2.


I might need to comment on this, but, if there is no customer `request.customer.getLicenseForOrg` will reject with a `404`, but if there is no license, it will return a `200` with `[]` as the result. So, if you're in this part of the flow at all, the customer already exists.


Ah, I see what the problem is here. The issue is that the `Write` is issued, but doesn't update the backing offset until flush is called. This behavior is somewhat "by design", in that the offset reflect the offset of accepted data, rather than written data, which is not a useful guarantee. We either need to maintain an offset on the `bufferedWriter`, in addition to the `fileWriter` or document this appropriately.

I'll provide a way forward in a comment below.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1243.5fbbaef835079522f3a7106c7cae2e29d0ea754f](http://build.palaso.org/viewLog.html?buildId=68360&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 844, ignored: 7 Build time: 00:06:31


Is it okay if that is tested in the logger_wrapper_spec?


PlantCompBaseClassAgain (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


to follow convention, all "throws" should be bolded in this list.


@willianribeiro  Dúvidas ?


Probably want to warn them that we couldn't figure out what they meant so we chose '2'.


See above about bolded "throws".


On [the note](https://github.com/bwheeler96/awesome_preloader/commit/e2f314bd9408fe789e15c528eee9bd64d0b16ced#commitcomment-15595096) about this gem really applying to plain ol' Ruby...

Considered using [memoist](https://github.com/matthewrudy/memoist)? It has the advantage of already being written. Then preloading just entails invoking the memoized methods. Which could just as well live without a gem at all, e.g. defining
```ruby
class MyModel < ActiveRecord::Base
  extend Memoist

  def method1
    ...
  end
  memoize :method1

  def method2
    ...
  end
  memoize :method2

  def preload
    method1
    method2
    self
  end
end
```
or else this gem could boil down to something like
```ruby
class Object
  extend Memoist
  def preload(*memoized_methods)
    # maybe there's a way to validate that each method actually *has* been
    # memoized?
    memoized_methods.each { |method| call(method) }
  end
end
```


Yep, I saw that later, I agree with you, it's very nice like this.


Good use of an interface. Perhaps some javadoc could be included to help developers wanting to use this?


Released in https://github.com/brigade/db-query-matchers/releases/tag/v0.4.1


Sure, I'll be a little less lazy and finally submit a PR in this case. And I suppose I'll need to double check and see if any existing test cases would contradicted by that _paging attribute suddenly appearing on certain requests where it wasn't before.


For the context `with no logger passed to client`, should this just be `without logger defined` or something? We're not dealing with the client here.

For `with logger passed in`, what do you think of flattening them out:
```ruby
context 'with logger set to nil' do
  before { Rester.logger = nil }
  it { is_expected.to be_a Rester::Utils::LoggerWrapper }
end

context 'with logger set to STDOUT logger' do
  let(:logger) { Logger.new(STDOUT) }
  before { Rester.logger = logger }
  it { expect(subject.logger).to eq logger }
end
```


Just spent like 40 minutes reading through all of this. I can only laugh.


Actually, this looks more like a problem with your build environment:

/bin/bash: -c: riga 0: EOF non atteso durante la ricerca di """
/bin/bash: -c: riga 1: errore di sintassi: EOF non atteso

Or did you manually edit data.cpp? Or perhaps you're using a custom language file with characters the shell does not recognize?


yep, next commit removes this


@Potla1995 are you sure the **identation** is correct? I think you need to add indents to the lines starting from 11. Please check once and lemme know.


Usually you will want to do something when this happens other than print a stack trace and carry on...


I added that to the "open questions" section, see my latest commit. We will definitely take a closer look at this and will make sure it is properly addressed.


The `kill -9` command [should be avoided](http://stackoverflow.com/questions/31170119/consequences-of-using-kill-9-for-node-processes).


I think the subject should always be what we're describing:
```
describe '#new' do
  subject { LoggerWrapper.new(logger) }
  ...
end
```

Thoughts?


Yeah, this needs clarifying -- right now the relationship between the states and results is unclear.


Yes


:key: info


Tidied


Fixed


fixed


I'm thinking we should at least check that `#error`, `#warn`, `#fatal` and `#debug` are defined.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1244.5bd0c87b27cc91839124a921a021490192cb358b](http://build.palaso.org/viewLog.html?buildId=68361&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 844, ignored: 7 Build time: 00:06:18


no,i use your bootable_recovery without any change

this is the log http://hastebin.com/aqapibiyaz.dos


Not a grammar expert (English is my second language), and I know it's common to sometimes omit it... but isn't there a grammar rule that list of 3 or more items should get a comma before the coordinating conjunction? (i.e. 1, 2**,** and 3)


Ooh, does this work without the context of the user object? (function vs method call here)


we're done**


It would be interesting to see if sorting alphabetically the `from galaxy.` imports still breaks the tool.


I don't think that this is about <i>reading</i> the rules, rather, it's to ensure that they know they got warned so that they can't say "I didn't see the warning popup" when trying to appeal a punishment.


Same as above about comma/conjunction.


I'm a bit confused by this one... why does this affect whether a warning is triggered?


Ah, this really relies on doing `self.each`. So my [previous comment](https://github.com/bwheeler96/awesome_preloader/commit/4e29d3ac7c8ce3850f496d63b99e7f4c978b359f#commitcomment-15595417) doesn't quite apply. The idea is to preload something at the *class* level, but be able to get the results on the *instance* level. E.g., doing a giant SQL `group by model_id` then being able to get each model's data via an instance method.


@Mumfrey Awesome. Is there any easy way to give an additional SRG file or lines to the Mixin AP similar to FG's extra file/lines feature or would I need to copy the whole SRG file first and append the lines?


No need for `.content`.


The curriculum has a bug (that I just submitted a patch for) that incorrectly states this should be `ActionMailer::Base`. It should actually be `ApplicationMailer` instead, FYI!


Need `h2.section_heading`.


I would normally.  But the `TransformerRegistry` does not use django.


Мне тоже :)


The messageModeMap in https://github.com/edubart/otclient/blob/1686d8081b7462caebb11fd8b6d38be721f2c45e/src/client/protocolcodes.cpp might need an adjustment for older protocols, as MessageNpcFromStartBlock should be the main message mode for npc talks.


No, I mean the kind of hashing that the incremental compiler will compute based on the API we extract here. See https://github.com/sbt/sbt/blob/0.13/compile/api/src/main/scala/xsbt/api/HashAPI.scala


comment added here: https://github.com/npm/newww/commit/d3ffbd9


From the advanced/Scripts/setupPiholeStats.sql
```
+DROP TABLE IF EXISTS `pie_chart_stats`;
+DROP TABLE IF EXISTS `top_chart_stats`;
```
If you drop the tables if they exist it is important that on an upgrade the setupPiholeStats.sql is not run again or you would remove all history. In other words (no really good idea on how you check for that) you should not do that automated or at least check if its a new installation or upgrade


`array('%lang' => $global_lang_code), WATCHDOG_ERROR);` refers to `$global_lang_code` and the vars definition was removed in prior PR... so it was missing and no longer defined.


This is pretty Australian specific. The intention with the bie-index re-implementation was to make something more reusable for other countries.


We should document those