Это в шаблонах надо искать
> 16 янв. 2016 г., в 21:25, slykmp <notifications@github.com> написал(а):
>
> Нужны подробност
>
> в админку не могу зайти, так как нет шаблона manage_base.html
>
> В templates <https://github.com/Impish-/echoba/tree/CBV_incoming/templates> нет папки parts, в manage/templates/parts/ <https://github.com/Impish-/echoba/tree/CBV_incoming/manage/templates/parts> нет manage_base.html
>
> При создании треда тоже вылетает исключение о некоем несуществующем листе
>
> Traceback (most recent call last):
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/tornado/web.py", line 1443, in _execute
>     result = method(*self.path_args, **self.path_kwargs)
>   File "/home/sly/work/echoba/echsu/views.py", line 106, in post
>   File "/home/sly/work/echoba/echsu/views.py", line 79, in form_valid
>   File "/home/sly/work/echoba/echsu/views.py", line 68, in get_context_data
>     board = self.db.query(Board).filter(Board.dir == self.path_kwargs.get('board_dir', None)).first()
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/torgen/list.py", line 108, in get_context_data
>     queryset = kwargs.pop('object_list', self.object_list)
> AttributeError: 'BoardView' object has no attribute 'object_list'
> При попытке прикрепить картинку
>
> Traceback (most recent call last):
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/tornado/web.py", line 1443, in _execute
>     result = method(*self.path_args, **self.path_kwargs)
>   File "/home/sly/work/echoba/echsu/views.py", line 35, in post
>     return self.form_valid(form) if form.validate() else self.form_invalid(form)
>   File "/home/sly/work/echoba/echsu/views.py", line 53, in form_valid
>     return self.render(self.get_context_data())
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/torgen/base.py", line 34, in render
>     return super(TemplateResponseMixin, self).render(self.template_name, **context)
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/tornado/web.py", line 699, in render
>     html = self.render_string(template_name, **kwargs)
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/tornado/web.py", line 806, in render_string
>     return t.generate(**namespace)
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/tornado_jinja2/integration.py", line 12, in generate
>     return self.render(**kwargs)
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/jinja2/environment.py", line 989, in render
>     return self.environment.handle_exception(exc_info, True)
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/jinja2/environment.py", line 754, in handle_exception
>     reraise(exc_type, exc_value, tb)
>   File "/home/sly/work/echoba/templates/thread.html", line 2, in top-level template code
>     {% from 'macro.html' import post_message %}
>   File "/home/sly/work/echoba/templates/base.html", line 19, in top-level template code
>     {% block content %}
>   File "/home/sly/work/echoba/templates/thread.html", line 24, in block "content"
>     {{ post_message(
>   File "/home/sly/work/echoba/templates/macro.html", line 31, in template
>     [G]
> AttributeError: 'unicode' object has no attribute '__call__'
> При этом изображение загружается, создаётся запись в базе, с виду всё нормально. Если прикреплять к треду, всё нормально.
>
> При попытке открыть любой тред открывается первый
>
> Открываю, например, /b/7/, а вижу тред /b/1/
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/Impish-/echoba/commit/d8defa6d08068a6c5b2169cfff43fd60f8355b70#commitcomment-15490970>.
>


@bcho  嗯，忘记了


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11768](https://teamcity.mesosphere.io/viewLog.html?buildId=106358&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:25


of course


It appears that this line and the following are indented using spaces, but Git's source code uses tabs instead.


Alfredo Sanchez Ruiz


All that code should be reworked to not use global functions, but that will only become possible after we refactor platform code to inherit from GraphicsWindow etc. For now this is pointless churn which makes the commit harder to review. At least it has to be split, but I think leaving them to use `SS.TW` is fine too.


combine in one if (!isWin() && flag)


set a more meaningful name


develop (lefticus) - i386-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


develop (lefticus) - Win64-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Git's coding style puts spaces after the `if` and around the `==`, but in the case of `strcmp()` it is more common to use the exclamation mark, i.e. `if (argc == 4 && !strcmp("--non-patch", argv[1]))`


You should also check for the node's name, otherwise you can mix multiple kind of trees into one stack of a single tree type. (see [here](https://github.com/MinetestForFun/server-minetestforfun-skyblock/commit/d198644e08e0e0ee9aef1c14875af51a58baca6d#diff-fe24fdf96c7af2afc4edbda97f408e43R421]))


code duplication, extract


Basico


Bascio


for(JButton btn : buttons){ btn.setIcon(null); btn.setEnabled(true); }


`usage()` does not return, so the curly brackets and the `return` are unnecessary.


Nice catch! I'm not sure that we should use -O3 at all for the release build actually, at least on my distro we package everything with -O2.

-msse2 might also be problematic for 32-bit machines which don't support SSE2 instructions btw.


 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:679](../blob/561b47e4630c25552a2be42869dfb54c9f34df61/include/chaiscript/language/chaiscript_parser.hpp#L679) Expression is always false because 'else if' condition matches previous condition at line 677. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:683](../blob/561b47e4630c25552a2be42869dfb54c9f34df61/include/chaiscript/language/chaiscript_parser.hpp#L683) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/561b47e4630c25552a2be42869dfb54c9f34df61/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/561b47e4630c25552a2be42869dfb54c9f34df61/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 683. (multiCondition)
 - __information__: [src/chaiscript_stdlib.cpp:1](../blob/561b47e4630c25552a2be42869dfb54c9f34df61/src/chaiscript_stdlib.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __information__: [src/main.cpp:0](../blob/561b47e4630c25552a2be42869dfb54c9f34df61/src/main.cpp#L0) Too many #ifdef configurations - cppcheck only checks 12 of 13 configurations. Use --force to check all configurations. (toomanyconfigs)
 - __information__: [src/main.cpp:1](../blob/561b47e4630c25552a2be42869dfb54c9f34df61/src/main.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/561b47e4630c25552a2be42869dfb54c9f34df61/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/561b47e4630c25552a2be42869dfb54c9f34df61/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/561b47e4630c25552a2be42869dfb54c9f34df61/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/561b47e4630c25552a2be42869dfb54c9f34df61/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/561b47e4630c25552a2be42869dfb54c9f34df61/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


TeamCity Civic Assembly :: Build backend + frontend [Build 9](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=345&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests failed: 78 (59 new), passed: 1542, ignored: 7 Build time: 00:16:34
### Failed tests
```
Blogs tests: Should add new blog: <no details avaliable>

Blogs tests: Should not change blog if Cancel button clicked: <no details avaliable>

Blogs tests: Should change blog: <no details avaliable>

Blogs tests: Should not delete blog if Cancel button was pressed: <no details avaliable>

Blogs tests: Should delete blog: <no details avaliable>

Organization tests: Should add new organization: <no details avaliable>

Organization tests: Should not change organization: <no details avaliable>

Organization tests: Should change organization: <no details avaliable>

Organization tests: Check that admin can change organization image: <no details avaliable>

Organization tests: Check that admin can cancel change organization image: <no details avaliable>

Organization tests: Should not delete organization if cancel pressed: <no details avaliable>

##### there are 68 more failed tests, see build details
```


I don't think it's enough. The problem is that you can press upload without noticing that the subtitle to be uploaded actually changed.

I don't see any solution to avoid that. That's why my idea was to link the upload dialog with the subtitle that was loaded when opening it. If the user changes his mind about the subtitle to upload or want to upload multiple subtitles, he can either quit and reopen the dialog or just press "Refresh" to cache another subtitle track.

Another solution would be to cache the subtitle when pressing "Upload" and then ask for confirmation based on what was cached.


Since it is `static` anyway, let's define it here instead of declaring it now and defining it later. And surround it by empty lines.


think of a generic way to check, this is pretty ugly


Git's coding style is to use `underscore_separated_lower_case` variable names, not CamelCased ones, and neither do we use Hungarian notation. So maybe just `int result;`?


think of a more generic way to check


nextInt(buttons.size()) makes more sense


> Also we should add the check m_pCAP->GetSubtitleDelay() == 0 before the actual call because we wouldn't want to upload any subtitles that are not properly synced, and/or show a messagebox to the user that operation could not be completed because subs are not properly synced.

I think I agree although the user might have actually fixed the desync doing so.


Done


some remarks


Maybe use `argv_array_pushl()` instead?


Note that the change is not equivalent. The p11-kit proxy module is not just a default module. It is a system wide module that wraps all the available in the system PKCS#11 modules. With the new option the p11-kit module is not used even if available. A user would have to know about it.


And by the way, thanks for your suggestions! :+1:


comentário


develop (lefticus) - i386-Windows-7-VisualStudio-12: OK (382 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


Probably easier on the eyes as `result = run_command(&read_tree) || setenv("GIT_INDEX_FILE", tmp_indexfile, 1) || ...`


Let's put a space after that comma.


hmmm....
in recent wotlk core.... this channeling spell is canceled on aggro.


I did fix it here: https://github.com/TrinityCore/TrinityCore/commit/8dd072722ab523b611fa65e8bd6b84653dd7cacb


Maybe rename the test to `test-vm-proxies.js`?


Are we sure that those command-lines cannot contain quoted arguments?


Git's source code does not use curly brackets around single-line code blocks.


Server variable REQUEST_SCHEME doesn't exist when running NGINX. I fixed the code to be more robust.


Again, let's surround the `#include` block as well as the function declaration with empty lines.


@Re3os File an issue ticket if you have any issues


nice


The main method is better that be in another archive, separated of the class DBSingleton


aktualna jest mapa-wies3 - to ta sama mapa co mapa-wies2, ale dodałem checkpointy i ogniska, po wejściu w które gracz ma ginąć, oraz poszerzyłem dziury, który miały szerokość jednego kafelka, żeby dało się w nie normalnie wpaść.


Me gustaría aprender los fundamentos de este tipo de modelo de distribución de software así como los conocimientos necesarios para trabajar en una empresa que maneje SaaS y mas a futuro poner un negocio propio en el futuro.


Very good. Maybe put the `$(`, `git` call and `) ||` on a single line?

Besides, would you terribly mind measuring before and after this patch? On the Git mailing list, the accepted method is to use best-of-5 measurements (it is actually technically not sound, but Good Enough (ntm)).


This line contains spaces. Can someone clear it in some PR?


Related with #198


I see you are talking about the Resource and Kind in the RESTMapping, and you are saying if we want the default Kind, we should use `api.RESTMapper.KindFor(mapping.Resource)` rather tan `mapping.Kind`, right?

Is there any example where `mapping.Kind` is set to a different value?


develop (lefticus) - x86_64-MacOS-10.9-clang: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


You missed the private constructor, so that the class is a Singleton must have a private constructor, to avoid this is instantiated from outside


develop (lefticus) - Win64-Windows-7-VisualStudio-12: OK (382 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


< 0 doesn't mean end of stream, svc_EOF does, unless I am missing something


Random to prandom probably has to be done to all files


add_performance_tests (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-AddressSanitizer: OK (3041 of 3041 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It would be safer, and easier to write queries, but sadly it would also require a major overwrite of the app, since every query is written with the old direct params method.

Pushed this because I too get goosebumps when I have to write a query with params in it and escape it one by one, so I rather use the PDO driver but quickly realized that I could not pass params.

I can't agree with you anymore @pine3ree but the amount of work behind this proposal is enormus.


Actually it is not necessary to create a real DB connection, just to make here an new DBSingleton and log a message to say that it is enough


Ok


Thank you @autocar  :+1:
I've merged your commit  (@4e4df0f and @be981be) and release to [version 1.0.1](https://packagist.org/packages/unisharp/laravel-settings#1.0.1)


Never know, never will. xD


Это :+1:


It's hardly protected by https://github.com/Shestak/ShestakUI/blob/master/ShestakUI/Core/Launch.lua#L218-L222
Why you want to change the scale? Is it not displayed correctly?


You should use a name for the package instead of leave as default package, for example in this case you can use the name singleton for the package name (to fix this you should create a new package with the name you want and then remove you code there)


Тоже гуд


code for tinkering audio/tinkeringAudio.py

for toneGeneration you've got sec in the function parameters but secs for makeEmptySoundBySeconds, which gave me an error


test


This makes that if an "old" configure exist autoreconf/autogen will not run anymore ?
What if a new "configure.ac" came with git ?  Are we still going to use that old configure script ?


>Это в шаблонах надо искать

Что именно? [Здесь](https://github.com/Impish-/echoba/commit/6352992c293f2c794ab8f73f9f95f7576aab2c82) был удалён base.html, но manage_base.html не создан. Может, он у тебя в игнор попал, как у меня login_form.html в своё время?

С созданием треда проблема в BoardView возникает.

Картинка в треде - ошибку вызывает метод image() модели Message

А номер треда - вообще что-то странное. op_message правильный находится, но отображается не он


for echoes it's not clear what num is


ลบ .html ออกด้วยทำเหมือนตัวล่าง เพราะว่า ul บนสำหรับ หน้าจอกลางถึงใหญ่ ล่างคือสำหรับ mobile มันควรจะเหมือนๆกัน


You should use a name for the package instead of leave as default package, for example in this case you can use the name abastractFactory for the package name (to fix this you should create a new package with the name you want and then remove you code there)


You should create a class with a main method to test your code


Why do you delete it?


Ok to poprawcie ktoś proszę w kodzie tak, żeby wczytywało najswiezszą wersje mapy. Stare pliki mozna usuwać, aby nie robił się bałagan.


^ to


`||` means "or". It still always runs if there are new updates.


@javierarce this is the config file restored


Maybe add an additional check that configure.ac is older/newer then configure ?
Or is this always checked by the configure script ?


Why?


>It still always runs if there are new updates.


You should at least put a message here, using System.out (The same for all the places where the method is empty)


Ok so the only case i see this happeing is if you have a (playlist or continue with next file in folder) and local subtitles files (for downloaded subs it would take far to long), and press Upload at the same time the video is changing.
If you time it just right, 3 things may happen:
 - Upload gets called before __current subtitles__ are distroyed and caches and sends them for the __current video__.
 - Upload gets called after current subtitles are destroyed, but before new subtitles are loaded and __does nothing__.
 - Upload gets called after the __new subtitles__ are loaded and sends the new subtitles for the __new video__.

In such case when the user is doing a marathon :D i don't think they will bother with manually uploading subtitles, let alone just beore changing a video.

Further more if the user is changing videos manually i find it difficult to believe that they will manage to press upload and then manage to load a new file before the subtitles are cached.

So i think you are overthinking the matter :D but i do beleive the call should come from the main thread as i said before.


>  созданием треда проблема в BoardView возникает
>
>

Это сейчас пофикшу(тред создается, но ошибка при "сборе аргументов»)

по поводу тредов, если смержится с ‘board_style’ - наркомания начинается :) если откатиться то все нормально

> 16 янв. 2016 г., в 21:56, slykmp <notifications@github.com> написал(а):
>
> Это в шаблонах надо искать
>
> Что именно? Здесь <https://github.com/Impish-/echoba/commit/6352992c293f2c794ab8f73f9f95f7576aab2c82> был удалён base.html, но manage_base.html не создан. Может, он у тебя в игнор попал, как у меня login_form.html в своё время?
>
> С созданием треда проблема в BoardView возникает.
>
> Картинка в треде - ошибку вызывает метод image() модели Message
>
> А номер треда - вообще что-то странное. op_message правильный находится, но отображается не он
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/Impish-/echoba/commit/d8defa6d08068a6c5b2169cfff43fd60f8355b70#commitcomment-15491153>.
>


You should use a name for the package instead of leave as default package, for example in this case you can use the name proxy for the package name (to fix this you should create a new package with the name you want and then remove you code there)


Dammed, I mist the | |   !!
Sorry )-:


When do you need this?


There's two functions called toneGeneration I couldn't test/use the first one without changing the function name


Here you must return the connection not null, for example calling this bdAdapterSlow.BDConnection(url, user, pass


타임아웃 난거 수정한건가 ?


develop (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@hisorange

I believe it would be just fine to drop the deprecated php_mysql for opencart 2.1 and start using parametrized queries. and I agree, it is indeed safer. In my case (since i needed both mysqli and pdo_mysql support long before opencart had it ready) i developed a small db-sql-builder for that job long time ago.

My only observation was that if we start supporting sql parameters via the $db service (and adding a second argument to DB::query() is a step towards that) we either need to make all the adapters support it or remove those that do not. Using $parameters in DB::query() means that the $sql string contains placeholders, so we must be sure that all the adapters are able to use the $sql string and the $parameters to build and run the complete query.
If not, then the $parameters in DB::query() would not be safe to use.
A public method (I would say a contract/interface method) should be used in the same way without knowing which internal adapter is loaded.

kind regards


The name of the method should have the word get at the beginning, for example get DBConnection


add_performance_tests (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Remember to code in english, it would be DB (Data Base) and not BD (Base de Datos)


![draft wtf](https://cloud.githubusercontent.com/assets/3866018/12373521/228ab57c-bc41-11e5-9d81-def32948bfa3.png)

All the Devoid cards are split from their color couterparts when using a color sort.  Slip through space should be next to Sweep away, Reality Hemorhage next to Brute Strength, etc.


I already was a contributor, now I'm there twice :smile:


@dmethvin well yeah, those are tickets i mentioned in that thread. I fixed those cases. I believe fixed for those tickets were released logic was solid for detached elements case.

But know we changed that behaviour, i assume because of the performance reasons (right @gibson042?) by not using the `contains()` method.

But now, after this commit, we again using the `contains()` method, we now worsen the behaviour of the `show()` method for the case when element is hidden by improving performance of case when element is shown. Which looks as upside down.

@gibson042
yes, that what are discussing now, forget about the thread there is no thread :-). Just try to understand the https://github.com/jquery/jquery/commit/fe05cf37ffd4795988f9b2343df2182e108728ca#commitcomment-15480663 comment.

@timmywil

> I might argue that supporting disconnected elements means not putting a display on it

We even falling that actually, if element is disconnected, but `hide()` is called, then we apply the display.

--

My opinion when i introduced supported for detached elements three years ago, is that, if element is detached and user calls either `hide()` or `show()` on it, they know what they doing, they expect for element to be shown or hidden when they attached elements to some context.

And that assumption worked well, we didn't **ever** had complains about it.

But now we expect, that only those users that apply `hide()` to disconnected elements know what they are doing, not those ppl who apply `show()`... and we worsen the performance... and size btw.

Granted `contains()` shouldn't reflect the performance that much, because `jQuery.css()` display already takes a lot of time, but if it doesn't matter, then again, why?

I hope my explanations is now more clear, i know it is hard to understand, no kidding, but please try to grasp it.


LGTM.


The abstract factory pattern is not well applied, please read again the pattern and update the code properly


In general level the proxy pattern is well applied


Not sure, but in general every recipient of RestMapping should assume
it is correct (that it has a kind and resource that matches the
callers intent) rather than override it.  Since this is limited scope
here it's less of an issue - it's possible that we should have a
resource group version *and* kind group version struct on RestMapping
in the future to further clarify.


Now you are a double contributor :sweat_smile:, I will fix later.


:'D


So much contributions :smile:


Try to use meaningful names for the variables, for example in this case it would be much better call tha variable book and not just a


I had to add the following before every  do_vcs git:... to make it work properly.
Else it  was creating a the directories inside the previous package.
'''
 cd_safe "$LOCALBUILDDIR"


baaapapappa


Right, forgot about that.


The builder pattern is not being fully well implemented, you mixing book with director and with DBConnection


Передается в шаблон ‘threads’ переменная, там "отпагинированные» треды (может изза этого наркомания)
Или лучше собрать агрегатированный board object?
> 16 янв. 2016 г., в 21:25, slykmp <notifications@github.com> написал(а):
>
> Нужны подробност
>
> в админку не могу зайти, так как нет шаблона manage_base.html
>
> В templates <https://github.com/Impish-/echoba/tree/CBV_incoming/templates> нет папки parts, в manage/templates/parts/ <https://github.com/Impish-/echoba/tree/CBV_incoming/manage/templates/parts> нет manage_base.html
>
> При создании треда тоже вылетает исключение о некоем несуществующем листе
>
> Traceback (most recent call last):
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/tornado/web.py", line 1443, in _execute
>     result = method(*self.path_args, **self.path_kwargs)
>   File "/home/sly/work/echoba/echsu/views.py", line 106, in post
>   File "/home/sly/work/echoba/echsu/views.py", line 79, in form_valid
>   File "/home/sly/work/echoba/echsu/views.py", line 68, in get_context_data
>     board = self.db.query(Board).filter(Board.dir == self.path_kwargs.get('board_dir', None)).first()
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/torgen/list.py", line 108, in get_context_data
>     queryset = kwargs.pop('object_list', self.object_list)
> AttributeError: 'BoardView' object has no attribute 'object_list'
> При попытке прикрепить картинку
>
> Traceback (most recent call last):
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/tornado/web.py", line 1443, in _execute
>     result = method(*self.path_args, **self.path_kwargs)
>   File "/home/sly/work/echoba/echsu/views.py", line 35, in post
>     return self.form_valid(form) if form.validate() else self.form_invalid(form)
>   File "/home/sly/work/echoba/echsu/views.py", line 53, in form_valid
>     return self.render(self.get_context_data())
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/torgen/base.py", line 34, in render
>     return super(TemplateResponseMixin, self).render(self.template_name, **context)
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/tornado/web.py", line 699, in render
>     html = self.render_string(template_name, **kwargs)
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/tornado/web.py", line 806, in render_string
>     return t.generate(**namespace)
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/tornado_jinja2/integration.py", line 12, in generate
>     return self.render(**kwargs)
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/jinja2/environment.py", line 989, in render
>     return self.environment.handle_exception(exc_info, True)
>   File "/home/sly/work/echoba/env/local/lib/python2.7/site-packages/jinja2/environment.py", line 754, in handle_exception
>     reraise(exc_type, exc_value, tb)
>   File "/home/sly/work/echoba/templates/thread.html", line 2, in top-level template code
>     {% from 'macro.html' import post_message %}
>   File "/home/sly/work/echoba/templates/base.html", line 19, in top-level template code
>     {% block content %}
>   File "/home/sly/work/echoba/templates/thread.html", line 24, in block "content"
>     {{ post_message(
>   File "/home/sly/work/echoba/templates/macro.html", line 31, in template
>     [G]
> AttributeError: 'unicode' object has no attribute '__call__'
> При этом изображение загружается, создаётся запись в базе, с виду всё нормально. Если прикреплять к треду, всё нормально.
>
> При попытке открыть любой тред открывается первый
>
> Открываю, например, /b/7/, а вижу тред /b/1/
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/Impish-/echoba/commit/d8defa6d08068a6c5b2169cfff43fd60f8355b70#commitcomment-15490970>.
>


Why a director construct a connection?


No, because IPI642 lives and exercises most of the same code. When we remove that there should be more removal possible.


Why director get a book?


Note, it was my old comments, they probably wrong. Probably serial shouldn't be changed... (not sure when this change happened).


:+1: , thanks!

I'll be surprised if there isn't an 0.12.1, so I'm going to create that branch and cherry-pick it onto that.


This change essentially reverts  edad8291ac7635e8b7faab180f203bb6c3623f4a
Doesn't compile for me :)


Das Label "LabelConsumerPriceIndex" habe ich in den Wechselkurs geändert (chart#getTitle)


Wenn das "adjustRange" nicht mehr notwendig ist, ruhig den Code löschen.
Aaskommentierter Code irritiert später nur.
Habe ich jetzt einfach gelöscht.


Honestly, we shouldn't be encouraging use of this idiom. (It shows up in a few other places, namely to define the monoid instance for an installed package info.)


ack


Is this BMX used by MPV or did you add it for the binaries ?
What exactly does this BMX ?  Where can I use it for ?


Makes sense. Maybe I ought not to use maps. The alternative would be to require 17.5 (or whichever OTP release has maps) or newer. Thoughts?

I'm pretty sure LFE compiles with maps if they're available. Am I wrong, @rvirding?


Why are we blacklisting those things? Shouldn't we just ask upstream not to ship an appdata.xml in this case (especially thinking about tracker-preferences)


add_performance_tests (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (389 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


add_performance_tests (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Although the pom is well programmed, you should use an archetype so that you get the structure of project, becasue here I don't see the source folder: 'src/main/resources' nor source folder: 'src/test/resources'


OK done.


Я нашёл причину наркомании с открытием первого треда - [ссылка неправильно формировалась](https://github.com/Impish-/echoba/commit/aae5c11f2335654bb299416c1ba8d3032cbd7329).


Caricato per errore file prova.java


Yeah, I agree. I didn't know I could do direct JSON in JS without JSON.parse(). Also, JS can't read from files without AJAX which will add many seconds to my page load :package:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11769](https://teamcity.mesosphere.io/viewLog.html?buildId=106362&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:03:05


Кстати, у нас будет сквозная нумерация во всех разделах?


The class is empty, at least should have one test


Так ссылки будем же резолвить прямо из шаблона, как боги! давай я либу сегодня ночью прикручу, как только закончу с вьюшками
> 16 янв. 2016 г., в 22:19, slykmp <notifications@github.com> написал(а):
>
> Я нашёл причину наркомании с открытием первого треда - ссылка неправильно формировалась <https://github.com/Impish-/echoba/commit/aae5c11f2335654bb299416c1ba8d3032cbd7329>.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/Impish-/echoba/commit/d8defa6d08068a6c5b2169cfff43fd60f8355b70#commitcomment-15491249>.
>


Ahh, finally I got what you mean, you are talking about the code before my #18627 went in, I've already fixed the issue in that PR. We are actually in agree with each other. The code in master branch is correct, see https://github.com/kubernetes/kubernetes/blame/master/pkg/kubectl/cmd/util/factory.go#L194.

Please revert the "restoration" in Review 19 :)


I thought this couldn't be the cause for a NPE because JSoup's `Elements.text()` returns "" even when nothing is found.


You should use a name for the package instead of leave as default package, for example in this case you can use the name test for the package name (to fix this you should create a new package with the name you want and then remove you code there)


>Кстати, у нас будет сквозная нумерация во всех разделах?
хороший вопрос


It's a standalone lib/binary to handle MXF files? No idea, ask @laurfb.


It shouldn't be for all displayable things; all the sites are from PackageId. I'll do that.


The name of the class should always start with upper case, in this case Test


Я только за. Кстати, не знаешь, как в этом раширении для картинок получить имя картинки и размер (в Кб) оригинала?


master test


I think Unicorn is still evolving too fast to worry too much about versioning. Your choices are 0.9 or always tracking latest master right now.


Yeah xml:id are unique It's clearly a better way to do it ! Thanks :+1:


Message.picture поидее там вся эта инфа


For point 4 you should use an archetype to do that, I don't see neither the pom nor the classes in this project


оригинальное имя не сохраняется


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 207](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=676&buildTypeId=XbimEssentials_XbimEssentials) is now running


I prefer to have my important i.e. non-static functions defined at the top, so that people can read into my code (IMHO) easier. they'll notice the declared helper functions exist, but won't spend much thought on them, until they hit a point, where they have to read them. But that might just be the way I like to work through other peoples code.


What about `account_supported:false` ?


Yeah, it's the only thing GHC supports.


changed the initial value of temp variable


Да мне и не нужно оригинальное. Просто в документации не нашёл нужной инфы, а методом тыка лень было перебирать


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 207](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=676&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:30


LGTM


2 hours of work


Hmm, I thought the error [here](https://github.com/kubernetes/kubernetes/commit/f7e385a88a8dd49a3fd55aeb6693aa705c3751ef#diff-406d4a9e887052033447a7381526fa75R210) would be triggered. I'll take a closer look when I'm back next Tuesday. I have to go now, sorry.


ack


Message.picture - Оригинал (там динамический скуль запрос к БД, хз как в шаблоне отобразится)
у него поля все нужные тебе(в БД триклятую-таблицу к image смотри)
 op.create_table('images',
    sa.Column('width', sa.Integer(), nullable=False),
    sa.Column('height', sa.Integer(), nullable=False),
    sa.Column('mimetype', sa.String(length=255), nullable=False),
    sa.Column('original', sa.Boolean(), nullable=False),
    sa.Column('created_at', sa.DateTime(timezone=True), nullable=False),
    sa.Column('message_id', sa.Integer(), nullable=False),
    sa.ForeignKeyConstraint(['message_id'], ['message.id'], ),
    sa.PrimaryKeyConstraint('width', 'height', 'message_id')
    )


Possibly exposing secret to public. :eyes: Should consider regenerating a new secret on server's side.


Your theme already has code to generate title via add_theme_support. Yet it has a title tag in header.php. So it still generates duplicate title.


SQL и отобразится))


Нет, там нет размера файла


I know it doesn't do anything particularly wrong but I still doesn't like it much because of:
> Upload gets called after the new subtitles are loaded and sends the new subtitles for the new video.

Nothing tells you that those subtitles were ready for uploading. I know that there is little chance that it actually happens but do we really want to base this on chance?

If the general opinion is that it is too unlikely to happen to care then ok, let's say I'm just overthinking it.


add_performance_tests (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


In "show" function of events controller why are you fetching all the users? And you are not using it anywhere also. You don't need this line. I wonder where you are this "@user" object.


Same thing, why are you creating "@user" object and why do you even need it here?


> i do beleive the call should come from the main thread as i said before.

I don't really think it matters because `Upload()` actually does `m_MainFrame.SendMessage(WM_GETSUBTITLES, 0, (LPARAM)&pSubtitlesInfo);`.


That won't work as required. `result =!(run_command(&read_tree) && !setenv("GIT_INDEX_FILE", tmp_indexfile,1) && !...` should work though. Your solution won't shortcut on failed commands.


@codesnake can you debug out the PTS values? that way @fernetmenta can also give some tipps on how to proceed. Which branch are you currently on?


Oops, missed that. Too late :(


Done that! :)


Yes, that is fixed in this commit also, the title tag was later introduced in WordPress and this theme's initial release was 1year ago that is why a function was used for rewriting titles.


For some reason if I don't do this:

https://github.com/emoon/ProDBG/blob/master/src/prodbg/main/mac/prodbg_view.mm#L56

I get flickering at startup.

I'm doing some rewrite of my window setup so maybe the issue will go away hopefully.


Good pickup @mbsvpn , without current_item_ancestor the top level of the menu does not get the "active" class added when navigating to it's the sub menu page.


Ah, you might be right on that. Uhm, but how else could there be a NPE in this line?


I should split this function up


Shouldn't this module name end with `Extension`, not `Extention`?


Any suggestions for the interface name? `GlobData`?


[Сюда](https://github.com/Impish-/echoba/blob/board_style/templates/macro.html#L34) нужно имя вставить. Что-то странно, следующей строкой должен был размер в пикселях идти, не помню, почему удалил


What does this fix. I can see issues with this change.


I copied this from `views/pokemon/buy.py` without actually replacing the one there.  I'm pretty sure there's some other place I had a field like this, too?


What does this fix ?


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 121](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=677&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


Ok


So it caches the results in case you try to update too soon - is this
necessary?
Why not just check the feed less often? Does sickbeard let you control
how often you
  scan the RSS feeds? I can add a cache if it's needed, but I'm not sure
why it might be necessary.

The log then reports all the failed matches, which we do on the "RSS
Author Match" lines.
I have just added a line saying how many results found, like
"Transaction with 3 queries executed"
Theirs is a cached search response, ours doesn't have a cache and just says
"RSS %s returned %i results"

On 16/01/16 17:17, Maxcore wrote:
> |2016-01-16 10:43:55 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] ::
> Transaction with 1887 queries executed 2016-01-16 10:43:49 DEBUG
> SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] :: Last update was too soon,
> using old cache: 2016-01-16 10:41:37. Updated less then 15 minutes ago
> 2016-01-16 10:43:41 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] ::
> Transaction with 1887 queries executed 2016-01-16 10:43:40 DEBUG
> SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] :: Last update was too soon,
> using old cache: 2016-01-16 10:41:37. Updated less then 15 minutes ago
> 2016-01-16 10:43:36 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] ::
> Transaction with 1887 queries executed 2016-01-16 10:41:49 DEBUG
> SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] :: Transaction with 3 queries
> executed 2016-01-16 10:41:49 DEBUG SEARCHQUEUE-DAILY-SEARCH ::
> [ETHORLANDS] :: Unable to parse the filename
> Masters.of.Sex.S03E09.FRENCH.HDTV.x264-FRiES into a valid show
> 2016-01-16 10:41:49 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] ::
> Unable to parse the filename
> Masters.of.Sex.S03E10.FRENCH.HDTV.x264-FRiES into a valid show
> 2016-01-16 10:41:48 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] ::
> Unable to parse the filename
> Les.grands.reportages.2016.01.13.Au.coeur.du.pouvoir.2.de.2.DOC.FRENCH.480p.WEBRip.x264-REJECT
> into a valid show 2016-01-16 10:41:47 DEBUG SEARCHQUEUE-DAILY-SEARCH
> :: [ETHORLANDS] :: Unable to parse the filename
> Columbo.S01.MULTi.1080i.BluRay.REMUX.AVC-GLaDOS into a valid show
> 2016-01-16 10:41:47 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] ::
> Unable to parse the filename
> Ramdam.S04E18.FRENCH.SDTV.x264-QuebecRules into a valid show
> 2016-01-16 10:41:46 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] ::
> Unable to parse the filename
> Ramdam.S04E19.FRENCH.SDTV.x264-QuebecRules into a valid show
> 2016-01-16 10:41:46 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] ::
> Unable to parse the filename
> Dragons.-.Par.delà.les.rives.-.Saison.3.épisodes.14.à.26.(fin.de.saison).-.Netflix.-.Web-DL
> into a valid show 2016-01-16 10:41:45 DEBUG SEARCHQUEUE-DAILY-SEARCH
> :: [ETHORLANDS] :: Unable to parse the filename
> Les.grands.reportages.2016.01.14.Rene.Angelil.l.homme.derriere.Celine.DOC.FRENCH.480p.WEBRip.x264-REJECT
> into a valid show 2016-01-16 10:41:45 DEBUG SEARCHQUEUE-DAILY-SEARCH
> :: [ETHORLANDS] :: Unable to parse the filename
> Challenge.Hockey.RDS.EA.Sports.S01E06.FRENCH.720p.HDTV.x264-QuebecRules into
> a valid show 2016-01-16 10:41:44 DEBUG SEARCHQUEUE-DAILY-SEARCH ::
> [ETHORLANDS] :: Added RSS item:
> [Série.Noire.-.S02E01.20160115.-.720p.HDTV.x264-Handy] to cache:
> [ethorlands] 2016-01-16 10:41:44 DEBUG SEARCHQUEUE-DAILY-SEARCH ::
> [ETHORLANDS] :: Parsed
> Série.Noire.-.S02E01.20160115.-.720p.HDTV.x264-Handy into Série Noire
> - S02E01 [GROUP: Handy] [ABD: False] [ANIME: False] [whichReg:
> ['standard']] 2016-01-16 10:41:44 DEBUG SEARCHQUEUE-DAILY-SEARCH ::
> [ETHORLANDS] :: Unable to parse the filename
> Escortes.S01E01.FRENCH.720p.HDTV.x264-QuebecRules into a valid show
> 2016-01-16 10:41:43 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] ::
> Unable to parse the filename
> Infiltration.S01E01.FRENCH.720p.HDTV.x264-QuebecRules into a valid
> show 2016-01-16 10:41:43 DEBUG SEARCHQUEUE-DAILY-SEARCH ::
> [ETHORLANDS] :: Unable to parse the filename
> Prière.de.ne.pas.Envoyer.de.Fleurs.S05E01.FRENCH.720p.HDTV.x264-QuebecRules
> into a valid show 2016-01-16 10:41:42 DEBUG SEARCHQUEUE-DAILY-SEARCH
> :: [ETHORLANDS] :: Unable to parse the filename
> Escortes.S01E01.FRENCH.404p.HDTV.x264.Hypnotize into a valid show
> 2016-01-16 10:41:42 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] ::
> Unable to parse the filename
> C.est.Juste.de.la.TV.S09E13.FRENCH.720p.HDTV.x264-QuebecRules into a
> valid show 2016-01-16 10:41:41 DEBUG SEARCHQUEUE-DAILY-SEARCH ::
> [ETHORLANDS] :: Unable to parse the filename
> Ti.Me.Show.S02E01.FRENCH.404p.HDTV.x264.Hypnotize into a valid show
> 2016-01-16 10:41:41 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] ::
> Unable to parse the filename
> Gangsters.Les.Diables.de.l.Amerique.S02E05.2013.DOC.FRENCH.720p.HDTV.x264-InFinity
> into a valid show 2016-01-16 10:41:40 DEBUG SEARCHQUEUE-DAILY-SEARCH
> :: [ETHORLANDS] :: Unable to parse the filename
> Gangsters.Les.Diables.de.l.Amerique.S02E06.2013.DOC.FRENCH.720p.HDTV.x264-InFinity
> into a valid show 2016-01-16 10:41:39 DEBUG SEARCHQUEUE-DAILY-SEARCH
> :: [ETHORLANDS] :: Unable to parse the filename
> Gangsters.Les.Diables.de.l.Amerique.S02E07.2013.DOC.FRENCH.720p.HDTV.x264-InFinity
> into a valid show 2016-01-16 10:41:39 DEBUG SEARCHQUEUE-DAILY-SEARCH
> :: [ETHORLANDS] :: Unable to parse the filename
> Strike.Back.S05E03.FRENCH.720p.HDTV.H264-LiBERTY into a valid show
> 2016-01-16 10:41:38 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] ::
> Unable to parse the filename
> Strike.Back.S05E03.FRENCH.1080i.HDTV.H264-LiBERTY into a valid show
> 2016-01-16 10:41:38 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] ::
> Added RSS item: [The.Simpsons.S26E17.French.VFQ.HDTV.x264] to cache:
> [ethorlands] 2016-01-16 10:41:38 DEBUG SEARCHQUEUE-DAILY-SEARCH ::
> [ETHORLANDS] :: Parsed The.Simpsons.S26E17.French.VFQ.HDTV.x264 into
> The Simpsons - S26E17 [ABD: False] [ANIME: False] [whichReg:
> ['standard']] 2016-01-16 10:41:38 DEBUG SEARCHQUEUE-DAILY-SEARCH ::
> [ETHORLANDS] :: Added RSS item:
> [The.Simpsons.S26E17.French.VFQ.HDTV.XVID] to cache: [ethorlands]
> 2016-01-16 10:41:38 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] ::
> Parsed The.Simpsons.S26E17.French.VFQ.HDTV.XVID into The Simpsons -
> S26E17 [ABD: False] [ANIME: False] [whichReg: ['standard']] 2016-01-16
> 10:41:38 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] :: Unable to
> parse the filename Code.F.S02E03.FRENCH.HDTV.x264-MQR into a valid
> show 2016-01-16 10:41:37 DEBUG SEARCHQUEUE-DAILY-SEARCH ::
> [ETHORLANDS] :: Unable to parse the filename
> Code.F.S02E04.FRENCH.HDTV.x264-MQR into a valid show 2016-01-16
> 10:41:36 DEBUG SEARCHQUEUE-DAILY-SEARCH :: [ETHORLANDS] :: Cache
> update URL:
> http://ethor.net/rss.php?feed=sdl&cat=48,45,43,7&rsskey=********************************
> |
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/philborman/LazyLibrarian/commit/8897f4f2125104780f7a10ff338c68878fd91571#commitcomment-15490936>.
>


ok


@fritsch  I'm on master branch.


ok, but can you change this format to the new json syntax ?


This is a bug, you shouldn't be touching track_ids since you never materialized that mapping / don't want to be changing track ids anyway.
I will fix it.


Чтобы channel не был закрыт по выходу из try-with-resources.


I think the original author needs to ok this. Can you send this change here:

https://github.com/vestom/rtl_433/

I will merge if he is fine with the change.


Typo.


.idea folder should not be in git. These are settings files for phpstorm


This is dope @changetip $.50


Sweet!

--
Best wishes,
Matthew Wo


Will fix!


Hi @emesde, @MaxFangX sent you a tip worth $0.50, and I'm here to deliver it ➔ **[collect your tip](https://www.changetip.com/collect/934732)**.

**[Learn more about ChangeTip](https://www.changetip.com/tip-online/github)**


Right, I was just thinking that it might made sense to centralize the "badness" in one place and then marking that place clearly as "deprecated" or some such.


<title>NOW.REPORT</title>


The variables do *not* follow a normal distribution, and that is not our hypothesis, quite the contrary.


This will not solve the problem. We need to change display type.


I am not sure this is an issue, but I will never merge code that introduces unneeded casting. Just change the type of the struct members instead if this is needed to silence some warnings..


Насколько я понял, такое исключение бросается, когда идет попытка послать новое сообщение, когда предыдущее еще не отправлено.


I thought you made it compiling somewhere? Could you log out the PTS values? that way we see what we can do. I think a lot of the other stuff still in there can go after that is working properly.


wrong indentation


I think it's fine to use maps, it's just something we got to fix.

The maps thing is apparently done by the LFE Makefile and LFE then calls rebar to compile. If it was done by rebar it would be fine, Erlang.mk would detect it during autopatch. But right now it's dismissed by Erlang.mk. I don't have a solution right now, will look later on.


Ok @ManuelDeLeon...so I realized that when I asked for the #156 feature I didn't specify something that I thought might already be the case, and I'm now realizing that it might be going against what you are trying to do with viewmodel as a package. I was expecting for the properties within the loaded mixin object to be reactive, but I realized that this would essentially make the mixin object kind of like a viewmodel itself, except instead of being bound to a template the instance of this mixin would be bound to another ("parent"?) viewmodel in the form of a reactive property. So what is it that you want to do? What do you think about this idea of having reactive models within viewmodels? Will this be taking away from the whole simplicity aspect of "model of the view"? The only reason I'm asking about this is because I'm trying to use http://snapsvg.io. I see value in being able to dynamically create and destroy groupings of polygons/paths within an svg elements, but then again I can just choose the option of statically defining (with helpers) the svg structure with templates. What do you think I should do. please feel free to email me.

I feel like I might be taking away from the simplicity of it.


there is method ```groups_include?``` in User model, maybe you can use:
```
user = User.super_admin if user.nil? || !user.groups_include?(miq_group)
```


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Will try.


I can't comment on the last lines for some reason,  but you've imported random twice (line 1 & 99)

The only other thing I can think of is that the function/variable names don't use the PEP8 naming conventions which is lowercase with words separated by under scores (I think)  apart from that it seems to be working well


Ok because i an trying to make you happy :D

Lets make it a little more transparent and ask the user to confirm the filename that is manually going to be uploaded.

```
void SubtitlesProviders::Upload(BOOL bConfirm)
{
    if (CheckInternetConnection()) {
        // We get all the information we need within the main thread, to delay closing the file
        // until we have everything we need.
        SubtitlesInfo pSubtitlesInfo;
        m_MainFrame.SendMessage(WM_GETSUBTITLES, 0, (LPARAM)&pSubtitlesInfo);

        if ((bConfirm && ID_YES == MessageBox("Do you want to upload the file\n" + pSubtitlesInfo.fileName, MB_YESNO)) || bConfirm == FALSE) {
            if (!pSubtitlesInfo.fileContents.empty()) {
                InsertTask(DEBUG_NEW SubtitlesTask(&m_MainFrame, pSubtitlesInfo));
            }
        }
    }
}
```


I like the idea, but without the counter part server it is of little use. So when you release that I will merge this patch.


Ah, gotcha. Chances are someone looking to run the examples or write Cowboy servers in LFE will have it installed, but if we're to make that assumption it bears mentioning it in the READMEs. Maybe we can add a prehook to LFE's rebar.config or find some other workaround.


Thanks for fixing this :+1:


Python


> Another solution would be to cache the subtitle when pressing "Upload" and then ask for confirmation based on what was cached.

As I said I would agree with this.


LFE can be compiled with or without maps. The LFE Makefile checks with the escript "get_maps_opts.escript" and rebar also checks in "rebar.config.script" so there should be no problems. I am wondering when it is time to abandon R16 and older.


Well, I tried, but I can so few English that I coudln't do it. Sorry to bother, but if you can, would you report it? Or give some advision?

(It has been a while, sorry. I did a lot of real world works.)


This duplicates 5534b1bea04bfd09de1ca30e190a26d01c81353b


Isn't this the `FLUENT_SETTER` field ?


## Caching the Inverse of a Matrix:
## Matrix inversion is usually a costly computation and there may be some
## benefit to caching the inverse of a matrix rather than compute it repeatedly.
## Below are a pair of functions that are used to create a special object that
## stores a matrix and caches its inverse.

## This function creates a special "matrix" object that can cache its inverse.


Nice job 👍 keep it up


Создание тренда пофикшено


I get the following peridocally during playback,

17:49:48 T:2715931552   DEBUG: CVideoPlayerVideo::CalcDropRequirement - dropped in decoder, Sleeptime: 0.142932, Bufferlevel: 1, Gain: 0.480000
17:49:48 T:2715931552   DEBUG: CVideoPlayerVideo::CalcDropRequirement - hurry: 1

but SetDropState() never gets called with a value of true.


I updated from repo standards. Perhaps someone added  it to core without updating repo standard?


Could erlang.mk configure `rebar.config.script` on the fly then?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This could be more elegant by mapping on the previous stream :smile:


Maybe putting this as a public static in `TypeMatching` could be useful?


Пиши в таски, чтобы не забыть
> 16 янв. 2016 г., в 22:34, slykmp <notifications@github.com> написал(а):
>
> Сюда <https://github.com/Impish-/echoba/blob/board_style/templates/macro.html#L34> нужно имя вставить. Что-то странно, следующей строкой должен был размер в пикселях идти, не помню, почему удалил
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/Impish-/echoba/commit/d8defa6d08068a6c5b2169cfff43fd60f8355b70#commitcomment-15491321>.
>


Looks like you put a misspelled "canola"!


The filename should end in "Test.php" so it gets included when running all tests.  See phpunit.xml.


I went with something like this which is basically the same than yours:

```
diff --git a/src/mpc-hc/SubtitlesProviders.cpp b/src/mpc-hc/SubtitlesProviders.cpp
index fc49922..58ac417 100644
--- a/src/mpc-hc/SubtitlesProviders.cpp
+++ b/src/mpc-hc/SubtitlesProviders.cpp
@@ -472,7 +472,7 @@ void SubtitlesProviders::Download(SubtitlesInfo& pSubtitlesInfo, bool bActivate)
     }
 }

-void SubtitlesProviders::Upload()
+void SubtitlesProviders::Upload(bool bShowConfirm)
 {
     if (CheckInternetConnection()) {
         // We get all the information we need within the main thread, to delay closing the file
@@ -482,7 +482,11 @@ void SubtitlesProviders::Upload()
         //pSubtitlesInfo.GetCurrentSubtitles();

         if (!pSubtitlesInfo.fileContents.empty()) {
-            InsertTask(DEBUG_NEW SubtitlesTask(&m_MainFrame, pSubtitlesInfo));
+            CString msg;
+            msg.Format(ResStr(IDS_SUBUL_DLG_CONFIRM), pSubtitlesInfo.fileName);
+            if (!bShowConfirm || IDYES == MessageBox(msg, MB_YESNO))) {
+                InsertTask(DEBUG_NEW SubtitlesTask(&m_MainFrame, pSubtitlesInfo));
+            }
         }
     }
 }
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11770](https://teamcity.mesosphere.io/viewLog.html?buildId=106366&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:08:38


I will have a look tomorrow - cause of the snow I won't make it to my AML device today :-)

Btw. the PTS that player is seeng might also be interesting:  http://paste.ubuntu.com/14467624/


And a debuglog, please - player should tell at the start about which PTS it receives.


мержись


sample


Fixes #54


do not stack .arg() this is a QT anti pattern.
use
.arg(String::number(currentRating), String::number(m_starRating.maxStarCount()), String::number(m_starRating.starCount())


This should fix Tricky1975/Star-Story#319


ack


Yup, excellent! (i miss-read your suggestion and got confused. i thought you wanted to cache when showing the dialog box, my mistake)

Did you give the automatic upload any thought of how it should be initiated ?


:+1  @MarianoJT88

It would be great if your new code for fast pyramid could be merged with this class http://reference.mrpt.org/devel/classmrpt_1_1vision_1_1_c_image_pyramid.html , either replacing the implementation there, or adding a new method if there is some theoretical difference...

What do you think??


@gautric I'm afraid that your `XXX=${XXX:yyy}` syntax doesn't work well with Ubuntu Bash:

    /usr/bin/rhiot: 20: /usr/bin/rhiot: Bad substitution

Please try your syntax in non-OSX version of Bash when your perform refactoring like that.


Why did you leave out humidity?

This change will break things for current users that parse the output (at least me) and throws away half the data.


Nice, it is coming along!!


This one should work properly:

```
[ -z "$(find -name 'Makefile.am' \! -execdir sed -i -e '1ipkgdatadir=$(datadir)/herwig' {} \; -print -quit)" ] || die
```


yes


There are no samples in the test repo for the Acurite rain gauge that this code is supposed to handle.

Do you have one of these devices or are you just trying to reduce some of the false positives?


А теперь посмотри, куда ссылки ведут))


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11773](https://teamcity.mesosphere.io/viewLog.html?buildId=106378&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:10


лять


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 121](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=677&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **SUCCESS**
Summary: Running Build time: 00:36:18


There is no St.Table class in St library since Gnome Shell 3.18, so I replaced it with St.BoxLayout.
Now users of Gnome Shell 3.18 are able to select wallpapers with widget manually.


Wasn't it `meteor-base`?


Русский перевод


This doesn't look semantically correct to me.

Looks like the original code's intent was to check the value of the lower 7 bits without making any assumptions about the MSB.


Hehe:

18:06:55 T:2808206240   DEBUG: VideoPlayer::Sync - Audio - pts: 64000.000000, cache: 396757.669707, totalcache: 741333.305836
18:06:55 T:2808206240   DEBUG: VideoPlayer::Sync - Video - pts: 11.111111, cache: 50000.000000, totalcache: 100000.000000

Yeah, this can't work. I think at this beginning, when we don't have any pts yet, we should just return the dts we get ... and after we have succesfully decoded something, we can adjust.

@FernetMenta: better idea?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11772](https://teamcity.mesosphere.io/viewLog.html?buildId=106374&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:08:40


Let me have a look and I'll tell you! (but not today because I have to leave)

Date: Sat, 16 Jan 2016 10:07:41 -0800
From: notifications@github.com
To: mrpt@noreply.github.com
CC: mjaimezt_mjt@hotmail.com
Subject: Re: [mrpt] Difodo refactoring and faster image pyramid computation (1a09587)

:+1  @MarianoJT88

It would be great if your new code for fast pyramid could be merged with this class http://reference.mrpt.org/devel/classmrpt_1_1vision_1_1_c_image_pyramid.html , either replacing the implementation there, or adding a new method if there is some theoretical difference...

What do you think??

—
Reply to this email directly or view it on GitHub.


it is now includes inside `ddp`


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-AddressSanitizer: OK (3041 of 3041 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The way I read it, it's not a fix, just making things slightly cleaner, by reducing the scope of iter to just the loop in which it is used.   So it should be marked as an OK to merge now that other parts of the code are using that feature.


You have a `=` rather than a `+` before the userName variable on line 12. I believe you've already fixed that, but just wanted to make sure you saw it in case.


It does not crash here. Have you fixed it?

I tried this:

```python
import time
import numpy as np
from artiq import *

class CrashPYON(EnvExperiment):
    def build(self):
        pass

    def run(self):
        def stripchart_roll(xs, x0):
            xsnp = np.roll(np.array(xs), -1)
            xsnp[-1] = float(x0)
            return xsnp
        current_bright_mean = self.get_dataset('detect_bright_mean',
                                               default=100)
        x = self.get_dataset("default_bright_mean_strip_x",
                             default=[current_bright_mean]*100)
        x = stripchart_roll(x, int(time.time()))
        self.set_dataset("default_bright_mean_strip_x", x,
                         broadcast=True, persist=True)
```


I think that this is not needed for the main bundle.

What do you think about creating a separate bundle / package like `meteor-webapp-client-side` / `webapp-client-side`.

that will include: `webapp`, `hot-code-push`?


Sorry this isn't happening Ewoud.... It breaks Gregtech.


Also does not crash at 15039e1d74feb899f9c8bd954d6e922388d31268.


@Sanjo was this never actually published?  Only seems to be `velocity:METEOR@1.2.1_2` available from Meteor.


Absolutely no rush!! Enjoy the weekend ;-)

On Sat, Jan 16, 2016 at 7:16 PM, MarianoJT88 <notifications@github.com>
wrote:

> Let me have a look and I'll tell you! (but not today because I have to
> leave)
>
> Date: Sat, 16 Jan 2016 10:07:41 -0800
> From: notifications@github.com
> To: mrpt@noreply.github.com
> CC: mjaimezt_mjt@hotmail.com
> Subject: Re: [mrpt] Difodo refactoring and faster image pyramid
> computation (1a09587)
>
> :+1 @MarianoJT88
>
>
> It would be great if your new code for fast pyramid could be merged with
> this class
> http://reference.mrpt.org/devel/classmrpt_1_1vision_1_1_c_image_pyramid.html
> , either replacing the implementation there, or adding a new method if
> there is some theoretical difference...
>
>
> What do you think??
>
>
> —
> Reply to this email directly or view it on GitHub.
>
>
>
>
>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/MRPT/mrpt/commit/1a09587bdf0a2d150f440dff7fba97182ad79edf#commitcomment-15491494>
> .
>

--
___________________________________________________________

Jose Luis Blanco-Claraco
CITE-IV 1.05
Universidad de Almería, Departamento de Ingeniería
04120 Almería (Spain)
http://www.ual.es/~jlblanco/
___________________________________________________________


Alfredo Sanchez Ruiz A00397967


needs a more detailed commit message :trollface: :tada: and either the left or right  motors need to be reversed. calling @amycontreras to fix this


ack


Hmm. Weird that I didn't see this failure locally. Anyways those flags come from `<fcntl.h>` which every platform has (even MSVC) so maybe we could just add `<fcntl.h>` to those files instead of hiding away an include to a platform specific header?


I'm writing new device code and the transmission features a preamble of several sync bits. Every sync bit will produce a new (empty) row. I guess we don't need bit rows of zero length -- I might be wrong though?


I think the intent of eliminating the addition of empty (zero bit) rows is good but I can see a number of ways that this will confuse decoders and might obscure information about how the demodulators are working.

I'd consider @vestom's input before merging.


i hope i didnt forget anything.


> i miss-read your suggestion and got confused. i thought you wanted to cache when showing the dialog box, my mistake

That's my fault, there were two suggestions and I finally went for the one that was more in sync with your way of seeing things.

> Did you give the automatic upload any thought of how it should be initiated ?

That one is complex. Thing is, it's really hard to ensure that the user actually watched X% of the movie. We cannot just say that if we reach X% of the full length then it's ok because of seeking. Disallowing seeking would be bad too of course. I guess the only way would be to keep track of seeking and try to know what part was actually watched by the user. But there are yet some other issues, like what if the subtitle track changes... I guess we would have to be sure that the user watched at least N% of the video with the same subtitle track. I think I might have some ideas about this after all so I guess I can give it a try. It would be a great feature.


There is a compiler warning on the unused ", found" in the "for" setup, also iter = data is duplicate. The part about pulling in the var definition is just about style and can be reverted.


@zuckschwerdt there are several demodulators that do that though somewhat incorrectly.  (And there are decoders that use that/work around it.)   Personally I think it would be better to have more demodulators that are sync/start pulse aware.   Right now there isn't a good PPM demodulator that can handle a sync pulse definition.


@merbanan please don't merge this at this point.


I don't have this sensor, sorry. I get too many false positives from this code the way I read the code 24 bits are needed and the false positives are due to shorter bitbuffers where all zero test match.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hi


Isn't the topic on the socket?

http://hexdocs.pm/phoenix/Phoenix.Socket.html

it's one of the fields, so I'm not sure you need to store this.


I was confused too. The real problem is "&&" is logical "and" not bitwise -- this gives a compiler warning and will not work anyway. But if you look at the buffer length (25 bits), there is just a single trailing bit (MSB) and thus the whole byte will always be zero :)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11774](https://teamcity.mesosphere.io/viewLog.html?buildId=106387&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:01


Ok, sorry. Do I need to split the device in two parts, one for humidity and one for temperature? Or is there a way to define two different "fields" outputs?


@fishcakez this fixes the build. It seems new Elixir versions are fast enough for this to not be an issue. :D


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (383 of 383 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


a better idea to what?


Also since the topic is on the socket, I wonder if you could not just replace this call with

```elixir
push_msg = fn(payload) ->
  broadcast! socket, "event", payload
end
```

instead of needing to go through the Endpoint and you can remove line 19 all together. I think it will be ok in the fun, should resolve properly.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11775](https://teamcity.mesosphere.io/viewLog.html?buildId=106392&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:03:44


Composer/Util/GitHub.php line 42 references Composer/Util/Factory which was moved to Composer/

composer is no longer working


Apesar da Fiel 2007 trazem sabedoria de __palavras__, eu vejo que eles traduziram σοφια (translit. _sophia_) λογου (translit. logou) para 'sabedoria _de_ palavras', sofia significa sabedoria (ou discernimento). Aqui está logou e não logos, logou é no caso genitivo e logos no caso nominal.

- O caso genitivo é um caso gramatical que indica uma relação, principalmente de posse.
- O caso nominativo é um caso gramatical que indica uma designação, que denomina.

__3056__ logos log'-os from __3004__; something said (including the thought); by implication, a topic (subject of discourse), also reasoning (the mental faculty) or motive; by extension, a computation; specially, (with the article in John) the Divine Expression (i.e. Christ):--account, cause, communication, __X__ concerning, doctrine, fame, __X__ have to do, intent, matter, mouth, preaching, question, reason, __+__ reckon, remove, say(-ing), shew, __X__ speaker, speech, talk, thing, __+__ none of these things move me, tidings, treatise, utterance, word, work. see GREEK for __3004__

Sugestão: 'sabedoria _de_ __palavras__' -> 'eloquente sabedoria'

---------------

Sugestão 2: Não existe a palavra inútil nesse versículo.

Mas sim a palavra é κενωθη (_translit_: kenothe)

__2758__ kenoo ken-o'-o from __2756__; to make empty, i.e. (figuratively) __to abase__, __neutralize__, __falsify__:--make (of none effect, of no reputation, void), be in vain. see GREEK for __2756__

---------------

Ao meu entender Paulo está expondo de uma maneira a qual ele não queria que o pessoal de Corinto tivesse dúvidas (muito menos nós) que:

1. Batismo com água não é essencial para salvação. Mas sim! Cristo Jesus é essencial para a salvação.
2. Batismo não é parte essencial do Evangelho. A história do batismo com água dos fiéis que vinham até João foi como preparatório para que os judeus fiéis __recebecem__ Jesus Cristo (o Filho de Deus) com o Óculo da Fé renovado e revigorado. E o próprio João Batista declarou que ele apenas batizava com água, mas haveria de vir aquele maior do que ele, e que iria batizar com o Espírito Santo.

Hoje em dia muitas sinagogas de congregações neopentecostais, congregações católicas fazem do batismo com água algo deturpado e medíocre. Achando que por ventura eles mandam em Jesus Cristo. Fazendo Data/Hora marcada para batismo, como se Jesus Cristo não tivesse mais nada para fazer a não lhes servir. Isto é, hoje em dia fazem do batismo um negócio (um atrativo), um circo.

O que eu quero dizer é que o batismo na igreja primitiva era na hora da conversão de algum fiel. E não um agendamento posterior. Era na hora do arrependimento. E era uma forma do fiel mostrar que não queria mais parte no pecado. Mas queria passar da morte para a vida seguindo Jesus Cristo (e por aí vai...). ( __The Sovereign Creator Has Spoken__, Objective Authority for Living _The New Testament with Commentary_. Dr. Wilbur Pickering, ThM, PhD. Página 357 - I CORINTHIANS 1 17, nota de rodapé _f_)

A segunda parte é mais complicada e eu não vi nenhum comentarista explicando bem essa parte. Eu entendo que:

Paulo esta mostrando que o entendimento do sacrifício de Jesus Cristo na Cruz só é possível de se receber através da 'humildade' que é um conhecimento que todos os seres humano podem ter, mas muitos não querem ter. Então Paulo é Evangelista mas não com 'eloquente sabedoria' mas com 'grande humildade e __simplicidade__ na pregação' para que a mensagem da salvação em Cristo pelo seu sacrifício Cruz seja __recebida__ com tranquilidade e humildade, pelos arrependidos. E também porquê quem manda é o Senhor Jesus Cristo e não os homens. E quem escolhe aponta e escolhe os fieis é o Senhor Deus Jesus Cristo e não os pregadores, pastores, pessoas. Sempre Jesus Cristo no comando e nunca nenhum homem sequer.


@sbourdeauducq Your code crashes at my machine.


Great, looks like it works too for me - copying as override, and new, adding manualla both DIAL and INFO. The only feature left to update is changing top ContainedIn Quest element of DIAL to move it to another quest record.
By the way why those additional checks before calling SetVisibleWhenDistant? Group 10 and not FO4 mode (not wbVWDAsQuestChildren) should be enough to work in Oblivion. Right now I believe it won't set vwd flag for refs in group 10 in Oblivion since all those checks won't match there.


5/7 commit title


Ok. This is a compiler warning. I'm not sure about the implications here but the original code is wrong and the abs() won't do anything on uint's


What should we set / return before the first packet was correctly decoded.


Nice one


you can split this line into two, to increase readability. E.g. int rssi = wifiManager.getConnectionInfo().getRssi(); and then use it. After that, checkstyle also should be satisfied.


typo: wifi_signal_level_lable, but should be wifi_signal_level_label


btw: I already told koying that this is wrong: https://github.com/xbmc/xbmc/blob/master/xbmc/cores/VideoPlayer/DVDCodecs/Video/AMLCodec.cpp#L1813
but he knew better ....


This seems ok, but feels slightly wrong.

I guess the code will never run on a machine with a 16 bit int, where a valid sum could be 0, so it's really ok.


I'm not sure that the persistence of the interpreter state is "expected" here... but I think it is OK, and potentially useful.


Why 4? Moreover, you can extract it to private static final int value as attribute of the class.


> What should we set / return before the first packet was correctly decoded.

heh? there is not pts before there is a fist pic decoded


Just noticed they are ANDed, not ORed. It should work in Oblivion, but still they are not needed I think.


This change just removes the ambient audio toggle inside the openURL. Not needed, which I'm sure there will be more to follow.


Please, keep the same naming convention as other views - TextView has "tv" prefix.


I do not remember very well. But you can try remove it and compile the standalone.


You can use String.format(...), extract message to a separate variable and then use this variable in Log.d(...) method and setText(...) method.


Nahh, it's because we're showing installed applications in gnome-software without AppData files; the blacklist applies to those too. Perhaps the blacklist needs to move to GNOME Software, or perhaps we just need to show apps in the installed panel *with* appdata files only, although this does affect several important nonfree apps commonly installed by users.


I think we talk about different things. When first decode is called, we get the value as seen above, which is totally off. What should happen then?

We need to estimate / create the pts in AMLogic it's not like it is in FFmpeg where it's already sane.


To clarify on the problem I encounterd: I got 4 sync bits and 10 or so repetitions. The bitbuffer lengths end up to be: 0 0 0 0 40 0 0 0 0 40 0 0 0 0 40 0 0 0 0 40 0 0 0 0 491.
It's ugly to work around that and most of the rows are mashed into the last slot. I'd like to have length of all 40 so I can compare rows easily.


Typo: It should be Wifi signal level - not "sevel"


Pushing Car class up to master


Put the footer inside the container.


@Sharlikran: Revert that change that's what breaks it ;)


@bakkot Please use the `--minify` and `--no-node` flags when building libraries for the website. I'll update this.


again there is no pts after decode, there is one after decode returned VC_PICTURE and this means a frame was decoded.


Uh-oh, I meant 113.3%....


It's better to put here numLevels instead of 4 for documentation purposes. Can you explain, why it's 4?


у вас в итерации запросы к другому сервису
если 100 пользователей одновременно посмотрят топ и у каждого будез запрос за инфой 1000 юзеров - то это приведет к ддосу вашего бекенда
нужно ходить батчем
like this: /name/id1,id2,id3,id4,id4,id5


It's better to put here numLevels instead of 4 for documentation purposes - e.g. observeWifiSignalLevel(context, numLevels)


comment should be changed to "do something with level"


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Put code inside of header. Give top NAV class of top nav. Change class nav names to main-nav and top-nav.


Observes is fine. The same convention is in other JavaDoc comments.


Mmm this might be easily done activating the window of the primary screen and when removing iterate the top level windows and activate the window of the primary screen


A row with all zeros would imply an ID of zero, and all other values at minimum. I guess 0 could be a valid humidity, but I didn't see a valid status of 0 and a temperature of -100 deg C is certainly a fault.
Merely suggesting this to reduce false positives. I'd say rows of all zeros shouldn't trigger any of the decoders.


I suspect it'd be more efficient to filter this after filter.Ids?


I never looked closely at the LOD stuff :) If yous mean to say that "Visible when distant" won't be used outside of TES4 then yes it is unneeded. It's just that at first glance there wasn't any reason to exclude using group 10 for both "visible when distant" and Quest children" at the same time.


Ok lets say we cache the first frame drawn with the current subtitle and do
``(total frames drawn - total frame skips backwards - first frame drawn) / total video frames > 90%``
in addition
``(((total frames drawn - total frame skips backwards - first frame drawn) / average frame rate) / total video length in seconds) > 90%`` should be approximately the length of the video drawn in seconds (skips forwards dont matter here as those frames will not be drawn)
and finally to verify with real time, capture the ``current tickcount - (paused time tickcount) - tickcount when the subtitles were loaded`` should be approximately equal to the length of video drawn in seconds


any of the exact full names ?


This newline removal here might be another `perfectionist` bug.


Yeah, I did notice that, just too lazy to deal with it right now LOL


deleted


Testing Multiple World loads


Be nice to get this running in travis


We can agree about the code style and add the rules from http://jscs.info/rule/maximumLineLength


Yeah @tjenkinson but first we need to fix... or at least agree how much are we going to lint ;> right now it has `76 errors`


Unfortunately this breaks compability with the minimum GTK/GLib requirements. G-P uses the same minimum GTK/GLib versions as Geany and for GLib this is currently 2.28.
However, g_hash_table_contains() is first available in GLib 2.32.

You could either tell autotools to build the plugin only if GLib 2.32 is available (i.e. depend on it) or maybe write some simple compatibily function to implement g_hash_table_contains() when GLib < 2.32 is used. I guess this can be easily done using g_hash_table_foreach() or maybe g_hash_table_lookup().


Ahhhh.  That was the format from previous files I compared.  Let me try that first because I was starting to go over a lot of changes.  :tired_face:


This is what I changed: https://github.com/codesnake/xbmc/commit/49633a102bac72051fe3d8446c42b14be2321903


good job breh.


Yeah, shouldn't really matter :wink:


> Note that the change is not equivalent.

I certainly hope so.  The previous code attempted to create an unnecessary direct dependency on p11-kit, whereas the new code simply requests libp11 to load the p11-kit-proxy module.

> The p11-kit proxy module is not just a default module. It is a system wide module that wraps all the available in the system PKCS#11 modules.

I fail to understand the contradiction in your statement.  p11-kit-proxy is both "just a default module" and "a system wide module that wraps all the available in the system PKCS#11 modules".  For libp11 and engine_pkcs11 p11-kit-proxy is just a PKCS#11 module.  Neither libp11 nor engine_pkcs11 directly invoke any functionality specific to p11-kit.

> With the new option the p11-kit module is not used even if available. A user would have to know about it.

Why do you think it is not used?  Have you tested it?  Could you share the results of your tests?


Use less file


Thanks @gribozavr .


Leave this file as it is. Don't edit any of these @Vincentes


Clear


it looks good to me


Is this really necessary? Leave that as it is


Nice!


This is fine, but leave the rest as it is @Vincentes


For anyone who want to see it live, I made one: http://embed.plnkr.co/gkcpsH/


Use the constants in ``url_sig.h``.


It's good so far, just fix these and add some screenshots too


DocumentPicker


I'm having this same issue.


Clever :)


LGTM


This assumes that all the signature parameters will be at the end of the URL. Is that actually true? If it is required, please document or at least comment this requirement.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11776](https://teamcity.mesosphere.io/viewLog.html?buildId=106393&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:03:40


I will split the changes to `DefaultDirectionalityFeature` here into their own commit.


This looks fine


``buf`` is not guaranteed to be nul-terminated here. How are you handling long URLs?


Create a mockup of dynamic lower header bar. Will we be able to push data to the main header text and the right header text dynamically depending on the ui-view page.


I think this regex is not sufficient. The entry might be "```!*```" and it's still locked. This can happen for example if the entry is "```*```" and you do a ```passwd -l```, then it turns into "```!*```".


Only Oblivion has that group 10 under CELL, and all refs in it must have vwd flag. Later games store vwd refs in temporary group (wbVWDInTemporary = True), and now FO4 recycles it as quest children group, but vwd refs are still in temporary.


who did this horrible thing? LOL


востановлен


My idea was somewhat simpler. I think...

When updating the time counter on the UI, just initialize "start" the first time after changing the subtitle track and update "end" otherwise. To handle seeking, you just need to use a list of ranges [start, end] and update the correct one. It can be optimized being that most of the time you just update the same interval. Finding the right interval after seeking isn't hard either (it's unlikely that we will have a lot of intervals and we can keep then sorted). Do you think that would work?


Da hast du aber schon ein gutes Stück ran gelegt... damit können wir auf alle Fälle arbeiten (Daumen hoch)


I Think ther e is a variable flappy which is the same as current_flappy. Not sure if you would need such a variable at all.


The version of the test suite in this commit raises no exceptions, despite line 24.


Doveva essere xxx_scope_id?


I can sort of see why you decided to mash UDP output into a a different output formatter, but it's a kludge.

So if you've got a UDP printer, why not also a TCP printer?

What happens when someone wants  and CSV or KV and TCP or UDP?    Do you just keep adding more printers?

Personally I think it would be better to just pipe to a utility (netcat, socat, ...) that would handle TCP and or UDP and have more robust error handing, possibly including some bounded amount of buffering when nothing is connected.

If you don't care about the output when nothing is connected, just have inetd/xinetd start rtl_433 when someone connects.

I don't want to dismiss the work you've done.  It's great to see people contributing a lot.


It's not my suggestions, just to clarify


@jonsterling is this way of making decl right?

Also, I don't know how to build a telescope for result (tried to fold, but failed with label).
And how to organize tests and which library to use?