Great, thanks.

> On Jan 26, 2016, at 3:58 AM, Ian <notifications@github.com> wrote:
>
> @peterl94 <https://github.com/peterl94> - How does this look to you?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/ianrrees/FreeCAD_tinkering/commit/a63113473d5a05acf26547884bca5ba7fd7e928c#commitcomment-15671391>.
>


Same here. Lets stick with margin-left:auto; && margin-right:auto;


Ah. Okay:

module HelperMethods
  def titleize(string)
    string.split(" ").map {|word| (word == "in" || word == "the" || word == "of" || word == "or" || word == "from") ? word : word.capitalize}.join(" ")
  end
end

> On Jan 26, 2016, at 4:52 PM, Tammam Kbeili <notifications@github.com> wrote:
>
> This prints the word but doesn't return them. It would be nice to be able to call titleize and get back a string that's titleized instead of just printing the string titlezied.
>
> Also note in the ternary operator you may not be able to do print word you likely need to use full syntax print(word)
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/kaiaolson/quiz_one/commit/0276ba711edaa80ba2d4d5a52079e8ab7994a8fe#commitcomment-15693791>.
>


@nbd168: Any idea [what's wrong with the MT7620 builds](https://downloads.openwrt.org/snapshots/trunk/ramips/mt7620/)? They've been broken for months.


- The javascript client is just as an example.
- The changes mentioned by gary need to be made before the PR can be made.
- Tests are performed using the autobahn test suite.  If you look in the
examples/autobahn folder there are examples on how to run the test to
ensure they pass autobahn.

On Sun, Dec 27, 2015 at 1:16 PM, ThomasAlxDmy <notifications@github.com>
wrote:

> @euforia <https://github.com/euforia> Looks great! I have few questions
> though:
>
>    - Why adding a javascript client and not a go websocket client -- as
>    example?
>    - How close is that from being production ready/merge back upstream?
>    - Are you going to write tests?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/euforia/websocket/commit/8ae9644acb6772415b47bea1f8a2b1a422fdb249#commitcomment-15168604>
> .
>

--
cheers
-abs


Just to be sure, do you still need to turn it into a `str`?


Sure... I can probably run through the repo looking for this category of thing. I typically catch them when I manually review the diffs (as you're doing now).


:tada:


I think it may be a better idea if our component impacts margins/padding and our grid system is just there to support it.


One small issue: this line
```
+mvn $ANT_OPTS $BUNDLE_SNAPPY -Pdist -Pnative -Psrc -Dtar ${HADOOP_OPTS}"$@"
```
is missing a white space after HADOOP_OPTS. Build is failing (at least on deb, because of that).


Path seems funny.  Usually the standard is /songs/new  For some recommended routing names: http://guides.rubyonrails.org/routing.html#nested-resources


I don't think it should change the type ,ever. It'll lead to odd behavior if users first change the type and then the scale, in a different callout.


might want to name this /users/signup since it is a signup action against the user model


You should change your ```msgid``` to ```msgid "Enable Choose Stream by default"``` according to [this](https://github.com/scakemyer/plugin.video.pulsar/blob/318e9e8271546f8bd862df090a1b3643c602bac2/resources/language/English/strings.po#L110)


somehow the merge was bad (not your fault)

Manually merging


`if [[ -z ${CENTOS-}" ]]; then`.

Also, you should add a comment here to explain why we don't specify these toolchain files. I suppose it's because the compiler names are not the same?


We typically do not want to use where directly inside a view ever.  The view should be concerned with display.  Where scopes really belong inside models or actions (though not as preferred).  This way you should pass an @reviews action.


@liewegas, just need =, ctx->can_recover_partial = false; Right?
Or you mean bitwise "AND" may lead to a risk on different architecture?


@nyalldawson thanks!


Yeah compiler names are different. Also, for some reason, -z wasn't working for me before. Will try again.


merged manually


@PikachuEXE haha, good catch I will fix that.


Technically this bit is just a negation refactoring which could live in an unrelated commit, right?


You missed https://github.com/nitrogen-project/android_frameworks_av/commit/2f13f80d8c976c3e2e3fc04cf8a87e466e267007


I remove it. It has many trouble after boot.


@dirkmueller don


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12985](https://teamcity.mesosphere.io/viewLog.html?buildId=114163&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:08:07


here you can even do:
```python
return set(dotted_key[1:].rsplit('.', 1)[0] for dotted_key in dotted_keys)
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12986](https://teamcity.mesosphere.io/viewLog.html?buildId=114168&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:08:39


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12984](https://teamcity.mesosphere.io/viewLog.html?buildId=114162&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:08:39


Всё очень перемешано получилось... для выборок можно гем ransack использовать, там всё шибче используется


In future it would help to explain what the bug was in the commit message. Helps with reviewing and also looking a the git log.


This is a straightforward fix and I brought this commit into the codebase:
https://github.com/openemr/openemr/commit/b81ea313f1359e601850093118ca009ce538d1c0


github.com >> code.google.com (closing soon btw) ;-D


Hum, don't bother for 64 bits. It is far from started and my idea was to put all x86 buffers in the first 2GB. It would avoid to use 64 bits pointer for all recompiled stuff.


s/webdevelopper/web developer/ ;)


Should `Apply_Changes_With_State_Interceptor_Should_Change_1M_And_M1_Entities_State` be refactored into two separate tests -- one for 1M and the other for M1?  Part of the rationale for unit tests is that they serve as a functional specification, basically documenting expected behaviors.  So it's best to view them as a kind of documentation.


You don't use this method anywhere. Maybe you should delete it


А причём тут state и сортировка asc и desc?


What is a BatchPacket?


@lubomir ; thank you~!


В таких случаях лучше искать решение использовать if но с другим условием (то есть минимизировать использование Unless в коде). Например, if is_cabinet.blank?
Также, is_что-то - это Javascript-style, а не ruby


Adding this comment first as an explanation before a quick code review:
- I realise this code is prototype / R&D, but thought it best to raise your awareness of coding standards we have adopted over time. [There are some written on the Alfresco wiki here](https://wiki.alfresco.com/wiki/IOS_Coding_Standards), but be aware they may be slightly out of date. The best reference is the existing code.
- the third part library you've included seems ok. I had bookmarked a few others from previous research (see below). We should be mindful of the issue someone raised in that project regarding app rejection: https://github.com/abury/ABPadLockScreen/issues/55
- https://github.com/yankodimitrov/SwiftPasscodeLock
- https://github.com/liu044100/SmileTouchID
- https://github.com/venmo/VENTouchLock


For you two commits above:
1. gacl/gacl.class.php (changed adodb path and fixed php4 style constructor)
I placed comments in the commit to clean up the centralization of the adodb library)
2. gacl/profiler.inc (changed split method to explode as split is removed in php7)
I brought this commit into the main codebase:  https://github.com/openemr/openemr/commit/b81ea313f1359e601850093118ca009ce538d1c0


Wow!!!


Not sure Info.plist needs to be added?


ush....((


Sorry, will do! The bug was that the venue entity was not retrieved from the database and the venue from the backing form only contained the identifier.


Fy fan


First I had them as two methods. Bu then I realised they do the same, the only difference is this:

```c#
if (relationship == RelationshipType.OneToMany)
	  interceptorPool.ApplyChanges(order);
else if (relationship == RelationshipType.ManyToOne)
	  interceptorPool.ApplyChanges(detail2);
else throw new ArgumentOutOfRangeException("relationship");
```

So shall I split them?


Rather than bringing the project in as a source code snapshot, is there a reason you didn't add it to the list of imported Cocoapods?


Ну вот для юзера есть фабрика, а для task нет.
К тому же, лучше для каждой модели отдельный файл выносить с одноимённым названием.


smooth :smiley:


__apiary.manifest contains references to non-existent files in repository.__ (Autogenerated message from apiary.io)
+ endpoint/appointments/smart-meter-appointment-slots
+ endpoint/products/product-prices


this is good stuff!


Regarding the Smarty, feel free to place this as a separate commit. I do think this a bit risky and would require extensive testing; still would be better to instead try to fix the constructors, if possible and feasible.


also da komme ich mir ein wenig verarscht vor.... die meisten der offenses die jetzt wieder im master gelandet sind, hatte ich schon korrgiert....


Closes #4


why 0 as default values? Also, these can be const.


Code style: we omit a space after the return type, i.e.
```objectivec
+ (void)setup;
```


Preco si zmazal .gitignore?


On a second thought, I think we should either bypass the cache or wait until #578 is merged. What worries me is the "notStarted" stuff – the cache can't guarantee that.


Somebody got a problem with this, speak now


Should we extract width & height from https://github.com/micnews/html-to-article-json - or should it be configurable somehow?


I have tested it and found out that
```
<label translate>culture</label>
```
actually works => I would prefer we stick to this syntax for the attributes names. Of course the mandatory-field sign (*) cannot be embedded in the translation, you might have to use an intermediate span or use some special class to show the mandatory fields (what about directly using a red border or showing the "warning" sign as when the validation fails?).

For ng-message, it seems the brack notation is indeed required so that the string is translated.


Amazing tests :+1:


In a NIX file the name of a block is unique. Therefore the above code can be simplified a bit:

```python
parent_name = parent_block.name
if parent_name in nixfile.blocks:
    nixblock = nixfile.blocks[parent_name]
    ...
```

Btw: the `__getitem__`, `__setitem__`, `__delitem__`, `__contains__` methods of accessors like `file.blocks` take the id, name or index of the child nix object.


I am sorry. I added the wrong path for images...


I've thought about that too but so far I then always decided that the advantage of having all arguments listed explicitly outweighed the slight inconvenience of having to list them. Also, if you look at the functions in this module, they share little state that could be put into a context/collector object (apart from the ccx).
And I expect the mir cache here to move into the ccx in the medium term (this needs a bit more than initially expected), so this parameter would go away.


@scottyaslan @dcleao I'm not particularly fond of requiring the i18n bundle into the tests and using it. I know it produces the desired result, but is there another mechanism for checking thrown errors? Should we exploit the 2-parameter syntax of the .toThrowError and create a bunch of subclasses of Error for this purpose?
This would go along the lines of having error codes.


embeds also includes a caption property that we could add a a `figurecaption` here - if set.


Am I blind or something, can't find the settings for this. Not that I can't just throw a switch in, just was weird lol


telnet有现成的客户端程序，不需要自己写了……


So this is in anticipation of the day when Cassandra will provide this info in system.peers?


Code style: Try to avoid writing if() blocks without accompanying braces. We don't allow it in production code, so it's a good habit to try to break when writing prototype code.


Simpler and more efficient. I'll make the change.


It really depends on the game, it was probably unlikely to hit it often, but it may have hit it in some scenarios, but i generally try the IOP interpreter if a game doesn't work for some reason as the performance impact isn't very huge, so I can't say I've ever seen something run across it, but nevertheless, at least it's another potential bug squashed :)


It would be hard to measure the difference. But I doubt this change can make code run worse. The idea is that CPU/JIT will be able to store the reference in a register instead of having to read it from RAM each time (it will probably be L1 cache anyway, but I guess register is still better). Also this change eliminates the (potential) memory fence (none for x86) and enables JIT to do more reads/writes reordering.


didnt think its from 2013, thats cool


We should discuss number of attempts and the consequences of exceeding that number in the design meeting.


Aaaaand it does not work ;)

```
$ irb
irb(main):001:0> module Blah; end
=> nil
irb(main):002:0> x = 7
=> 7
irb(main):003:0> x.extend(Blah)
TypeError: can't define singleton
        from (irb):3:in `extend_object'
        from (irb):3:in `extend'
        from (irb):3
        from /usr/local/bin/irb:11:in `<main>'
```


Answer call with hardware HOME button (1/2)
https://github.com/temasek/android_packages_apps_Settings/commit/3d2a1042dd5187bbe1a43798670ab8e9bda42cea


**New**Issue sounds a little odd for a class-name -- I expect once there is another *new* issue, the last one isn't so new anymore? What about just `Issue` or `IOUIssue` (since that seems to be the domain of application).


@anosach-luxoft He used strlen()


Code style:
```objectivec
- (void)applicationWillEnterForeground:(NSNotification *)notification
```


Ship it.


Couldn't you simply use `self` here?


Cool, I get the concept of a factory for producing objects.

Should the filtering be a factory though? I think of factories more like factory girl objects.


> Wake lock seemed to have no effect.

Maybe this should be reverted then : https://github.com/mupen64plus-ae/mupen64plus-ae/commit/ae0c33447f754ee7791bd8c2774c410c6e3b32d9

Also don't hesitate to remove branches that have been merged already ;-).


Formatting should be consistent, all other chained calls use 8 spaces to indent multiline statements, too.


Wow, I have no clue how the hell I missed that, thanks man. Seems like you're moving right along as always, the ROM is looking awesome as usual. Glad you got your weather refresh fixed up, I had to come up with new ways to update basically everything on the fly because not using CM base this time or theme engine so I don't have recreatestatusbar. Anyway, keep kicking ass man


I'd would like to test my reverse proxy and are running the beta (Version: 2.4333
Build Hash: 698201c) on Raspberry Pi wich includes these commits. Added -webroot as Daemon argument but I'm not shure where I can add the desired webroot foldername.
@JohnAdders can you advise where I need to add/edit the webroot variable or do I need to compile local?


Well, gcc doesn't support well extra register. It don't even use all standard register. So except special asm code, and I don't see any reason to set the lo register with a constant. (actually I suspect that set hi/lo is only used to restore a saved context). Anyway, one less bug and maybe one game will run better.

We really need to find a way to do the test without constant propagation. So far we found 3/4 bugs on IOP constant path. Non-const path likely contains a couple of bug. Unfortunately it isn't easy to remove constant propagation as EE. I think some jalr/move need a special path.


Adicionando a classe Tanque*


Match removed


it will be possible to cut it off i'd imagine, but we would have to go through the code having a define check to see if it is enabled by define.


@adammurdoch: I've added your comments to the relevant issues.


docstring missing. especially what is rtgs_hash?


You're right I missed the fact that the PR was breaking some syntaxes. We're going to resolve it.
For now you can manually edit the keyword classes indexes for AS3 like in `Languages/Haxe.xml`.


As a sidenote: in the hdf5 back-end lookup of nix entities via name is usually the fastest way to access an entity:

```python
f = nix.File.open(...)
b = f.create_block(...)
f.blocks[b.name]  # fastest
f.blocks[0] # almost as fast as by name
f.bocks[b.id] # slow (actually iterates over all blocks)
```


is not stored,


good!


yeah, but here DSL > formatting, or better the formatting should be consistent for the DSL. Normally i also discourage everyone from static imports, but here it makes sense because it's more similar to the SQL-queries.


On line 302 used `strlen(str)` that need a `string.h` header. Link to `string.h` is lost when logging turned off. So build fail in line 302 was not found when log enabled.


@mega94 я разобрался. Скорее всего это видео имеет цифровую подпись и скачать его не тривиальная задача. Это не реализовано в данном скрипте.

Если нужны подробности - https://github.com/jeckman/YouTube-Downloader/issues/9

@jeckman sorry, I tell to @mega94 about signed videos.


maybe issuedBy ?


Yes I know but I think it should be changed now or in some follow-up commit. So or so @vojtechtrefny will be now the one who will be blamed by git :).


@aait If these changes make merging of #10 difficult, perhaps it should be merged first, then this branch rebased on top of it?


True, though in the end there is a weird case where we don't do it. Let me see if I can relocate it anyway...


OK nice candidate for the follow-up.


TeamCity pull requests :: netty [Build 1119](https://garage.netty.io/teamcity/viewLog.html?buildId=5103&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4911, ignored: 23 Build time: 00:36:35


Was also off by one space before. If you want to align it, move `.select()` to a new line as well.


Yes, you have to check them twice :) I did a dirty test (modifying the inst-sys to return a `nil`) and it worked :) So I think it's secure.


Вообще-то у нас идея была же другая. Что если print_format не задан, то выводится инфа по фильму в каком-то дефолтном формате (потому что это же не задано _как выводить_, инфа по фильму никуда не девается)


I'm not sure this method is necessary. You can call AddConnection in tests without this function


@jpkrohling you do not need to manage the `secret-store-undertow-filter` here once again just to override its version. It is enough to override `${version.org.keycloak.secretstore}` as you did above.


fjhuy


Thanks for that!

Don't suppose you'd be willing to change it to the shorthand syntax (`$logs = []` and `$types = []`) before I merge, would you?  I know it seems incredibly picky (sorry!) but it'll keep it in the same format as the rest of the script.


uyoui


Statusbar weather temp still derp in refreshing after recent cm source mergers. Still troubleshooting

I'm seeing u busy at cm gerrit. Kicking ass! Continue your great job.:)


This plugin has some bugs I didn't spot before it was merged that need to be fixed before it can appear in a release:

* `check_enabled()` container test is inconsistent with that in `policies/redhat.py::RedHatAtomicPolicy`
* Plugins _must not_ attempt to do their own `/host` handling - for one this path is not guaranteed to be at `/host` (it is passed to containers in an environment variable), but also since this is handled automatically in sos via the `--sysroot` and policy-based sysroot auto-detection this will conflict and lead to file collection failures. If plugins need to inspect paths inside the chroot then we need to develop new methods to allow this to use the correct path location.
* The call to collect `/etc/ostree/remotes.d` presumably targets the host? The call as written will attempt to collect this from the chroot (all file collection is chrooted when `--sysroot` is in play). Again we need to add interfaces that would permit a plugin to request collection outside the chroot path.
* You cannot run host commands in the plugin unless you pass `chroot=False` to the `add_cmd_output()` calls.


@aklomp How about putting `config.h` to a location (and may add include switches) which would allow the following?
```c++
#include <config.h>
```


No, it's not fixed. The effects are minimized slightly. If I read and remember correctly, it's about using Emacs search functions in the embedded elisp. They were catching some stupid escape guard.

I didn't close it because in general, we haven't decided on a stable order of evaluation. Perhaps one day in the future we can decide that how and when exactly embedded elisp is evaluated in the expansion buffer. And distinguish between embedded elisp in backquotes and embedded elisp for fields and so on.


one note here:
in python we do not use CamelCase for function names. Contracts that are according to the Standardized API are different, because we follow that. But for functions we define ourselfs and are not in the standard set, we should stick to the python convention and especially not mix two styles (underscores, camelcase).
so `get_issued_amount(address)` might be good enough.


This is the simple application history: https://github.com/pacoguzman/route_translator_application_helper/commits/master

I'll try to fix the problem and propose a PR


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26565/testReport/) for this commit**


@avikivity Could we add a if (_server._memory_available = mem_estimate) { print_ratelimit("Maximum request count reached), 0.1); just before the semaphore ?

This way the test will have a clue that this scheme worked.


The 3 commits adding/removing  should be squashed


@GregroxMun are you happy now?


`Issuance` is the correct event name i think.


So I should essentially think of containers like `blocks` as a dictionary/map indexed by `name`?
Thanks for the heads up - I'll keep it in mind.


You sure? I had the impression that if it gets the managed from parent, the property defined in parent would take precedence. Let me change it and test again :)


Should be #194, sorry. Github numbers are two ahead of googlecode, for some importation reason that I can't remember.


please do not use _underscore prefixes unless there is a good reason.


Go to https://woshizhaolinwu.github.io/ghapplate, that's all:)


thats not how it works ;) And not consistent with the use of the DSL in the other places of the operations-package


So you have to include `<cstring>` and use `std::strlen`. Do not include c-style `<string.h>`


again, please do not use _underscore prefixes. please let us kown if you need clarification on when to use them.


da


@lauraluiz You can change both color and background color as desired.


Uhmm .. I was just thinking about that .. I'm dgging better, but I'm quite sure I saw the short syntax to be deprecated ...

I'm going to fix for now, but please take a moment to rethink and use long array() everywhere :)


TeamCity LabKey :: Trunk :: Community :: CDS postgres 9.5 [Build 80](https://teamcity.labkey.org/viewLog.html?buildId=299591&buildTypeId=LabkeyTrunk_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 15 (2 new), passed: 32 Build time: 01:06:22
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSHelpCenterTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSSecurityTest.verifyUserPermissions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogAndLinearScales: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyCounts: <no details avaliable>

##### there are 5 more failed tests, see build details
```


Acc. to fglaser: das ist sowas wie ein identifier für den issuer bzw das wie eine iban in der realen welt.
rtgs (real time gross settlement system account hash)

Originally from ayoub: https://github.com/brainbot-com/dlg_swaps/blob/iou_token/iou_contract.py#L61


`usd_address` is not used anymore. Is it in there to test for interference? If so, there should be an assert for that. Otherwise I suggest to get rid of it.
Also I am not sure, what `eur_address` wants to imply. Maybe chose a more neutral way?


что лучше использовать, код или символ?


Нет, кейса в спеке быть не может. Спеки должны выполниться все, а не «какая повезёт». То есть должны быть спеки типа «с таким-то годом — будет то-то» (включая спеку на отсутствие года и год, выходящий за пределы описанного диапазона).


`std::endl` already performs a flush on the stream.


It uses PSX_SET_CONST (from top of my head). I hack it to set it to 0 but BOOM. Potentially some code relies on the const optimization. (JARL/move). If you check the EE side, a couple of instruction are different if EE_CONST_PROP is disabled namely (LUI/JAL/JALR). And potentially a couple of others instructions.


Why the double line breaks here? This should fit the line width limit written as:

```python
            for image in set(images['output'].splitlines()):
                self.add_cmd_output("atomic info {0}".format(image))
```

The `if image` also looks unnecessary - the loop should never execute if the set is empty:

```python
>>> s = set()
>>> for m in s:
...     print("member: %s" % m)
...
>>>
```


@lauraluiz Please review my changes and give me a thumb down or up


@c0mrade sublime majka... 'ta ce atom (:


The createTag method has specified arguments. It's no different than any other method. I might split it up by adding the optional attributes of a model in a seperate argument, but I see no need to create one argument which is an array, you would still need to read documentation or code to know what array keys are available ;)


@kkofler https://techbase.kde.org/Projects/Usability/HIG/ViewingAndNavigation Use a menu bar only for applications with a very complex command structure.

In any case, I don't plan to remove the option to show it. But the defaults will stay as it is now. It looks better imho and is also consistent with other browsers, and more importantly, it makes more place available for actual websites.

@cranes-bill If there is no free space on the right, how would you show the menu there?


OK this will work: https://gist.github.com/marcinwyszynski/3bb1c358fab9efb7056a


But it will spam the logs.  Can you look at collectd stats?


I suspect some opcodes don't do the check and just fall in to using const propagation without checking :P The ability to disable them has been widely ignored for a long time.


It doesn't really. Where would you want me to place it?


In any case, the parent PR was merged, so, I'll not manage this here. I'll change the parent dependency to src-deps.


Thanks, understood :)

Seems appropriate, Google is pushing to have MD in previous versions, no problem on our side.


regarding _underscore prefixes: the best practice to circumvent reserved word variable names is to underscore_ suffix them. So, if you have to use `from` as a variable, call it `from_`.


seeing 30-40% perf increases with this


@LeanderK Please use braces everywhere.


@AndreKlang We've planned to merge this for quite some time, but unfortunately it hasn't been communicated in public. With the publication of [PayEx Open Source Development Guidelines](/PayEx/Development.Guidelines/blob/master/open-source-development-guidelines.md), this is going to change.

All development, issues, planned features, etc., should be done in the open, right here on GitHub. Features should be developed in focused `feature/*` branches. Hopefully, we'll get continuous integration (Travis) and tests (PHPUnit) up and running, to ensure that the module is working as intended even as we do large refactorings like this.

I really hope this in time will make it easier to make outside contributions and pull requests. We really appreciate your contributions.


In short, yes.


И if тоже в спеке быть не может.
Идея в том, чтобы протестировать все возможные пути, спеки должны показывать именно это: «в таком случае произойдёт то, а в другом случае произойдёт это».
Учитывая, что ты берёшь только один объект movie для прогона этих тестов (и нам известно какой — первый из файла) — этот if никогда не сбудется, и таким образом ты НЕ тестируешь, что произойдёт если премьера фильма описана только годом.


Then adjust the other places, I don't see any advantage of having different formatting for DSL.


J'attends de voir car j'ai pas trop d'avis pour le moment. Ce qui me guide c'est qu'il ne faut pas trop disperser les données pour ne pas avoir de source d'erreurs sur leur mise à jour.

Sur l'orateur, on avait parlé de "pourquoi un speaker était présent à sudweb". Est-ce un champ à ajouter sur le yml ?


@afollestad From what I know there's no need for complex reflection here, you can just call `mDelegate.onCreateView(...)` (see [here](https://github.com/TR4Android/AppCompat-Extension-Library/blob/master/appcompat-extension/src/main/java/com/tr4android/support/extension/typeface/TypefaceCompatFactory.java), worked for me).


@owencm The problem is that, apparently, the browser can change the subscription while we're not loaded, so we actually don't know if it changed. There will be the `onsubscriptionchanged` event in the SW eventually, but it's not yet implemented.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12987](https://teamcity.mesosphere.io/viewLog.html?buildId=114169&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:07:54


@AndreKlang Would it lead to big problems to add this back into the code? If so, please just do it in your `master` branch, which is what #10 is based on, and it will be added to the pull request and eventually merged if that's how we agree to move forward with this.


whoa, can just format the DSL like its done in the other places, its a DomainSpecificLanguage, it has advantages to format it different then the rest of the java-code, because you can see it as fancy SQL and not java.


that was an error ;) You don't have to be so formal :)


fdv


Going the global variable route adds a lot of convenience. I don't know if having more than one `Ringpop` instances is a valid use case, but the current code supports it (i.e. each `Ringpop` instances gets its own `bark.Logger`). This update is incompatible with that assumption.


strange. We tried again today, and now your commit works perfectly.
Merging your pr. Thanks a lot!


ahh, i didn't file out a text in right field, so it was never scrolled.
As i said i don't use this app.
....then merge it.


borrado el readme


@nyh sent a patch to limit excessive logging of the same thing a while ago
- don't recall the specifics - yet it sounds like we have a solution for
this

On Wed, Jan 27, 2016 at 12:31 PM, Avi Kivity <notifications@github.com>
wrote:

> But it will spam the logs. Can you look at collectd stats?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/scylladb/scylla/commit/c55900891570052f3a41b753ba688bb629f2b4cb#commitcomment-15701662>
> .
>


Fixed it already multiple times. ;-)


I've got the feeling, the tests below have nothing/not much to do with the doc-string.


many things could use an overhaul.. the sab homepage could probably be moved over to github... i know people are partial to sourceforge for the binaries since you can track it.. but its so painfully slow at times :(


换成相对路径的好处是？


Can we add a TODO: here. As enrolments don't expire we should actually be deleting the attribute and updating all functionality dependent on it. However this is to large to tackle in this task so will handle separately.


I think you should be more specific when getting the name and code of the city in jne method, try find `padang` and you will get incorrect data because using `$array[0]->code` & `$array[0]->label`

Should have been fixed with compare `$array[0]->label` with `$this->dari` before `curl` to `http://www.jne.co.id/getdetailfare.php`

Nice repo btw ;)


この状態でテスト流しても
```
  1) Users GET group_users_path returns all users name
     Failure/Error: expect(response).to have_http_status(200)
       expected the response to have status code 200 but it was 404
     # ./spec/requests/users_spec.rb:8:in `block (3 levels) in <top (required)>'
```
になる


@AndreKlang Good idea. If adding configuration for this is simple, let's do it like that. We can even try doing replace by default and see how it goes. I'm just worried that it might cause unforeseen issues that suddenly requires a hotfix and hasty release.

A new pull request based on a `feature/*` branch implementing this would be highly appreciated. But some coordination with @aait and the plans for the merging of the modules is required, so we have the same idea on how to move forward.


I believe that will be fine. I was concerned about a possible regression in node with v8. Thanks for verifying.


It's still bad if you get this message once a second.


Also, I noticed that the word "override" in a comment gets highlighted now, I never noticed this before.
![image](https://cloud.githubusercontent.com/assets/576184/12610945/b41b9ed2-c4ea-11e5-829d-575ccde4bc76.png)


Nice


inpheaux is already working on the move to GitHub, it should be done before the release of 0.8.0.
That's why we also now publish the releases there so we can completly switch to there for 0.8.0 and above.
GitHub also has a download-counter, you can get it with the API:
http://www.safihre.com/sabnzbd/stats.html
inpheaux made a script that periodically combines the counts of both :)


Good point. I think it's worth a discussion.

If you were to instantiate multiple Ringpops, it would still work though. It's just that log settings are global to all instances.

If we *really* wanted to support individual log settings for instances, this patch still supports that. It just means we create our own `Facility` and pass it around instead of using the default one.


TeamCity LabKey :: LabkeyModules15.3 :: Git postgres 9.4 [Build 102](https://teamcity.labkey.org/viewLog.html?buildId=299586&buildTypeId=LabkeyModules153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 18 (5 new), passed: 258, muted: 1 Build time: 01:39:04
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCounts: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.tests.CDSLoginTest.testSessionTimeoutIntercept: <no details avaliable>

##### there are 8 more failed tests, see build details
```


LGTM


Protect concurrent access to `f.loggers`.


see https://github.com/StackStorm/st2workroom/commit/fa17c43df8655d6888ba83aa279358482f827fb8


https://github.com/TasukuNakano/present-shuffle/blob/master/app/controllers/users_controller.rb#L11
ここに `binding.pry` を仕込んでも作動しなかったので、index アクションまで到達していない。
テスト対象のオブジェクトがログインしている状態というのを書くべき…なのかな


@nikolai-b note - all these folders you've changed are generated automatically be pct-load.

So we need to update the load script to build the folders in the right place - next region we build will overwrite these as pct-load writes to pct-shiny. Make sense? Can discuss if not.


Couldn't this be simplified to

    with cache.lock:
        return Configuration(cache)


with or without this branch.
![mate-dict](https://cloud.githubusercontent.com/assets/961604/12611107/685ca13e-c4eb-11e5-99e1-7a7b6f422127.png)


Dito.


Should that say `scripts` instead of `scrips`?


LGTM, I'm ok with it, Michael.

thanks


You are right. This function should have been removed.


gfhgfhgfhgfhgf


You're using my favorite variable name, but others usually complain about it. Please replace it with a proper name which reflects the meaning of the variable...


#include <cassert>
is the "usual" C++ way


Can't this really never happen?


I have this square circle issue on EC2 that small and slow instance have slow network that limit their saturation speed and instance with fast network cards are built with a bunch of ram which make them difficult to saturate. I tried to limit the iops but I can't limit them below 100 iops.

So I was looking for some scylla internal knowledge of the situation to make the test robust and avoid guesswork.


This `Run and check` part has been duplicated a few times by now. I guess it's worth considering introducing a dedicated method such that you can just say something along the lines of

    self.assertOutput([os.path.abspath("main.exe")], "2")
    self.assertOutput(["cmd", "arg1", "arg2"], "15")

etc.


The commit where I tried to alleviate the problem is 2ccd85a7262b71a3567e4910cdd7216dc1ecc6d2

I also changed the title of that issue and marked it as a bug.


Because `this.featureOverlay_` is not a managed layer, `layer` is always `null` (see #4704)


Could you remove that void while you're at it? :D


OK


@molinch Yes, currently it rotates only local files (eg. pictures taken with camera app). Do you think we also need to rotate cached images (Uri source)?


I'd need to get the standard out, but I'm pretty sure you should use reinterpret_cast here


I am looking into this


эмм... даже не знал, что оно есть =)


Augmenting-Types.html:18 Uncaught TypeError: Math[(intermediate value)(intermediate value)(intermediate value)] is not a function


Все равно.


oui, this can happen only if libvlc instance is destroyed.


Maybe. I am not really sure how this with statement works. Should I change it?


Yes it is wrong!


Please continue at #1205 ...


You can reduce the memory and shard count.  But we don't want our tests to be tied to EC2 or a particular hardware network configuration.


It actually should expand to the bottom right after you start the app - even without any text in it.


This fixed the issue?


Yes, I noticed that and I don't like it for a library. This will make the code search for a `config.h' (a pretty generic name) in any of the default search paths - which may be set from some external source if this library is included into a larger project. I think a library like this should stay away from the default search paths and only use absolute paths.

Wouldn't CMake be satisfied if we put `config.h' into the top directory? That's an easy fix in the Makefile.


Do you think maybe this line is a little too long?


This doesn't propagate the change to existing loggers. For example:
```go
log1 := facility.Logger("a")
log2 := log1.WithField("key", value)
facility.SetRootLogger(myLogger) // both log1 and log2 continue to log to the previous logger
```


а я не могу тут использовать: .filter span?
они же все одинаковые, вроде...


Is it working?
Are you testin on POSIX also?


@andalusi I guess this is to fix the aspect ratio, which I just tested that is not working properly and deforms images. If it's that, then :+1:


come on: s/developper/developer/
l2read! :P


Same issue (and same correction) to apply in sg_tServices


the `sudo_cmd` is not param anymore, so it'd be probably better to say just `sudo` or so...


idk yet. haven't tested. Busy with children....lol :D


Ok, branch rebased and merged into master.


Ack


I agree but if we go the multiple instances route, then the code must always use the local facility (as in `ringpop.facility.Logger`) and then this default, or the module level functions, won't get any use.


I though about this.

But thereis nothing is this : https://github.com/scylladb/scylla-ami to do
that. And yes our current tests are tied to EC2.

On Wed, Jan 27, 2016 at 11:55 AM, Avi Kivity <notifications@github.com>
wrote:

> You can reduce the memory and shard count. But we don't want our tests to
> be tied to EC2 or a particular hardware network configuration.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/scylladb/scylla/commit/c55900891570052f3a41b753ba688bb629f2b4cb#commitcomment-15702097>
> .
>


There is an extra parenthesis here:
Parse error: syntax error, unexpected ')' in /usr/local/www/services_igmpproxy.php on line 109


Thanks LINQ <3


Do you mind adding a one or two sentences here summarizing the Message Bus, please?


minor: 2016


ah ok :)


May be [`bool operator==`](http://www.cplusplus.com/reference/string/string/operators/)?


Hmm interesting. Well I can fix it so it's not reliant on recreate anymore if you'd like. I'm also not using any updates to lock clock if that matters, I saw that cm has updated it but it worked great before so I never bothered to pull the latest changes. Thanks, still have some stuff I need to finish up at cm actually, thanks for reminding me lol


would probably be useful to add a test for this path


will it work on any andriod


For me it only breaks request callbacks (#283).


Indeed, this pattern is quite ugly, and the captured copy never gets unregistered from the GC.
That's one part that gave me some trouble to get working. But that's only due to the fact that I'm not so used to C++.
Wrapping the `proc` in a `shared_ptr` is indeed much nicer and simpler, and allows to unregister the proc from the GC.
Updated branch is on its way.


@lauraluiz Did you check out the branch and tested it? Maybe we have to change to background-color to white because sometimes you can see a small line on the image borders.


This is surprising to me. For example, `facility.Logger("x").SetLevel(InfoLevel)` works as expected but `facility.Logger("x").WithField("key", value).SetLevel(InfoLevel)` is a noop.


/etc/sysconfig/scylla-server SCYLLA_ARGS.

And no, we can't run all the tests all the time on EC2.


Немного неточно вилимо я написал. У каждого блока должен быть свой класс, это же уникальные блоки, которые могут использоваться в любом месте. А сейчас у всех один класс about-contacts-login, нехорошо.


lgtm
(I haven't tested it)


Shouldn't branch `analysis-8nOM0X` be deleted @tymondesigns ?


has this been actioned then?


Hi,

Do you plan to launch a STM32F2 based Feather board? :smiley:


may be premature optimisation, but as `find` across a list is quite slow in Ruby, and `legislatures` is a data-structure we're building by hand anyway, perhaps it would be better making it a Hash, keyed on slug?


Also, sometime, we should change it from "accountTransaction" to "accountTransactions" because it's not a single one, it's a list of them. This could be somewhat confusing.

This code is ok, I suppose, but it seems like a bit of a roundabout way to get what we want out. Isn't this way a little more elegant:

    let deposits = case Map.lookup accountToLook accts of
                    Just account -> accountTransaction account
                    Nothing      -> []


main-div нехорошо, а вдруг это станет не div, а section какой-нибудь в будущем?


![screen shot 2016-01-27 at 12 05 29](https://cloud.githubusercontent.com/assets/4887212/12611681/5d80b2a2-c4ee-11e5-88ed-011363254241.png)

Here you can see a blue line on the bottom of the image.

![screen shot 2016-01-27 at 12 05 57](https://cloud.githubusercontent.com/assets/4887212/12611682/5d868948-c4ee-11e5-92c4-67d6a400f224.png)


Этому блоку бы тоже класс задать, он же особенный, не такой как все h2 на странице.


I think this should be called create_contact because in the context of this library I think that "save" means "create or update" but this function only creates, never updates.

Also if you're doing that change it would be good to have 2 lines between function definitions instead of 1 because that's what PEP8 wants


This doesn't have to be `classmethod`, or did I miss something? Also a nitpick, it prepends the sudo... How about this:

```
diff --git a/avocado/utils/process.py b/avocado/utils/process.py
index b784a09..48b535c 100644
--- a/avocado/utils/process.py
+++ b/avocado/utils/process.py
@@ -247,7 +247,10 @@ class SubProcess(object):
                      straight out fail.
         """
         # Now assemble the final command considering the need for sudo
-        self.cmd = self._append_sudo(cmd, sudo, shell)
+        if sudo and os.getuid() != 0:
+            self.cmd = self._prepend_sudo(cmd, shell)
+        else:
+            self.cmd = cmd
         self.verbose = verbose
         self.allow_output_check = allow_output_check
         self.result = CmdResult(self.cmd)
@@ -277,22 +280,20 @@ class SubProcess(object):
             rc = '(finished with exit status=%d)' % self.result.exit_status
         return '%s %s' % (self.cmd, rc)

-    @classmethod
-    def _append_sudo(cls, cmd, sudo, shell):
-        if sudo:
-            if not os.getuid() == 0:
-                try:
-                    sudo_cmd = '%s -n' % path.find_command('sudo')
-                except path.CmdNotFoundError, details:
-                    log.error(details)
-                    log.error('Parameter sudo=True provided, but sudo was '
-                              'not found. Please consider adding sudo to '
-                              'your OS image')
-                    return cmd
-                if shell:
-                    if ' -s' not in sudo_cmd:
-                        sudo_cmd = '%s -s' % sudo_cmd
-                cmd = '%s %s' % (sudo_cmd, cmd)
+    @staticmethod
+    def _prepend_sudo(cmd, shell):
+        try:
+            sudo_cmd = '%s -n' % path.find_command('sudo')
+        except path.CmdNotFoundError, details:
+            log.error(details)
+            log.error('Parameter sudo=True provided, but sudo was '
+                      'not found. Please consider adding sudo to '
+                      'your OS image')
+            return cmd
+        if shell:
+            if ' -s' not in sudo_cmd:
+                sudo_cmd = '%s -s' % sudo_cmd
+        cmd = '%s %s' % (sudo_cmd, cmd)
         return cmd

     def _init_subprocess(self):
```

PS: I moved the logic into `__init__`, but it can stay as you implemented it. Then the method would be probably something like `_init_cmd`. But I think the if then else in __init__ looks better.


이때는 투표 된게 아니라 투표한 값을 얻어오는 거니깐 상태를 안 바꿔도 될거 같아요


Это всё же ссылка на раздел, но с классом button, да.


Looks good.


можешь, но чем меньше у тебя будет каскада, тем лучше


myAsks 가 아니라 myVotedAsksItem 되야 겐네요


I wonder: why the same addition is shown in green (which is ok) and red? in the green version there is an additional "will this finally work" which was the comment on my commit but for the rest the red part isnt supposed to be a deletion?


파라미터가 정의가 안되어 있어요


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12990](https://teamcity.mesosphere.io/viewLog.html?buildId=114227&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:05:08


파라미터로 전달된 date값이 있을 때는 now 값이 아니라 전달된 값으로 설정이 되어야 합니다.


Думаю для этой картинки вообще не понадобится специальный блок, все декорации зададим фоном блоку service или его псевдоэлементу.


again, sudo_cmd is not a parameter, should not be used in docstring


I don't understand the question.
The list_field here is event_type_id - the represent then looks up the name with translate=True...which seems like the default (no need to add again here)
Why would you need anything different?


インデントを入れてください。
チームで開発する場合は、コーディング規約は
他の開発者の為にも必要になってきます。

PSRというコーディング規約が参考になるかと思います。
検索すれば色々とで出てくるかと思います。


new changes


If you like, I can add a prominent note linking to a Wiki page, where we list all required changes. Would you like to add the Wiki page?


and here


This configuration change is required for the [OAuthAdminController](https://github.com/thehyve/naa-transmartApp/blob/master/grails-app/controllers/OauthAdminController.groovy) to function, which is currently only present in the version of transmartApp at https://github.com/thehyve/naa-transmartApp.
It is used to display and manage supported OAuth clients and authorization methods.
In the same repository, there is also a [UserApplicationsController](https://github.com/thehyve/naa-transmartApp/blob/master/grails-app/controllers/UserApplicationsController.groovy) to manage generated access tokens.
See the [OAuth client application registration](https://wiki.transmartfoundation.org/display/transmartwiki/OAuth+client+application+registration) page on the wiki for more information about client registration in tranSMART.


here


__API Description file syntax error on line 14818__: the use of tab(s) '\t' in source data isn't currently supported, please contact makers (Autogenerated message from apiary.io)


Doesn't this conflict with the deleteLater in the reject/accept slots?


Can't we set up each of these once, instead of on each invocation?

eg

````
Utils.arrForEach = Array.prototype.forEach ?
    function(...) {...} :
    function(...) {...};
````


Works with positive integers (ie 10 * 3) , does not work with negative integers (-10 / 3).

When negative this error is called:

Uncaught TypeError: Math[(intermediate value)(intermediate value)(intermediate value)] is not a function


On Wed, Jan 27, 2016 at 12:04 PM, Avi Kivity <notifications@github.com>
wrote:

> /etc/sysconfig/scylla-server SCYLLA_ARGS.
>
> And no, we can't run all the tests all the time on EC2.
>
I agree that I would be happy not to wait 5 minutes for vm to start while
testing my test.

> —
> Reply to this email directly or view it on GitHub
> <https://github.com/scylladb/scylla/commit/c55900891570052f3a41b753ba688bb629f2b4cb#commitcomment-15702327>
> .
>


Ok, so the latest change on Rstudio through creation of a new project-version control and then github.com/poldham/manual_proofs.git worked, I see the commit, yet wonder about the pull request that I made on Rstudio. It does not appear here, although I got a message on Rstudio that it was sent from master to master poldham. Hm...


Do you think there are also other schemes (like plain `http`) in use ?


ソルトとは暗号化を強化する為に用いられているものです。
なくても暗号化自体は可能ですが、暗号化で生成される暗号をより複雑にし、
復号化の難易度をあげてくれます。


I will let look through the file still but as a side note you don't want to create a version 2 yourself that is the whole point of Git. By editing the same file git takes care of the versioning and gives you the audit path. By creating a new file you are losing most of the power of git.


way better, python3 is awesome. In python 2 this doesn't work for all classes but who cares ^^


minor: merge this line and the below


I think the answer is that the green displays the latest additions to the text ( = will this finally work???) and the red is the original text before that addition.


Thanks ! Could you please do me a favor and [sign off the PR](https://github.com/rhuss/docker-maven-plugin/blob/master/doc/contributing.md) ?

will apply the PR asap then so that it will be available in the next release.

thanks again ...


Yeah, better let's put it white the background. Maybe the square can be dark blue then so it doesn't get lost, but I leave the decision to you. Nice animation, btw :)


great :D


Usually it's `https`. But I can add a check for `http`. Should I?


How about adding this in case `sudo` is not available?
```
    @unittest.skipIf(lambda: path.find_command('sudo'),
                     "sudo command unavailable")
```


@timmywil This breaks IE 9 tests, could you have a look? http://swarm.jquery.org/result/1011154


This is my first commit


just watch, not talk.


@YuLingJheng 這本書重覆了。我剛是指已經有人借書了，就應該要紀錄上來才對。


It still hangs on the xchat in my system. It prints the date and time however it doesn't run to completion still.


Got it ;) (oh i have also a “manual proofs” emails address?? cooool

From: Paul Oldham [mailto:notifications@github.com]
Sent: mercredi 27 janvier 2016 12:15
To: ikitsara/manual_proofs
Cc: Kitsara, Irene
Subject: Re: [manual_proofs] ...ok, now I also changed from Options the "Git" executable location. What i realized is I had set the Github - git.exe instead of the Git - git.exe path... (c931ae4)

I think the answer is that the green displays the latest additions to the text ( = will this finally work???) and the red is the original text before that addition.

—
Reply to this email directly or view it on GitHub<https://github.com/ikitsara/manual_proofs/commit/c931ae4d6db7a8b40ec47332cceb676659f010dd#commitcomment-15702542>.

World Intellectual Property Organization Disclaimer: This electronic message may contain privileged, confidential and copyright protected information. If you have received this e-mail by mistake, please immediately notify the sender and delete this e-mail and all its attachments. Please ensure all e-mail attachments are scanned for viruses prior to opening or using.


To be what?


Once again, this is a brand new concept here. Can you please add a sentence or two summarizing the feature, please ?


As this was the way it worked already it's already being tested by other tests - https://github.com/everypolitician/everypolitician-ruby/blob/f94e435574b5f5491ce4def889efddbe0d3538c6/test/everypolitician_test.rb#L10


TeamCity pull requests :: netty [Build 1120](https://garage.netty.io/teamcity/viewLog.html?buildId=5104&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6390, ignored: 23 Build time: 01:21:18


Changed., you are right, This looks better and is more clear what it does


I think this needs either a better name, or at least some documentation. It's not obvious to me at all what the "gender count" of a country means. I _think_ from the code, it's simply the total number of People within the Country for whom we already have a gender set? If so perhaps something around KnownGender?

It also feels a little odd having it be a full blown Class (especially as it doesn't really act as one)


Where does this value come from? From ``@phone`` in the CSS?
I see it is used in the user directive: shouldn't it be defined once in some file?


@mixailenko5 Do you know @MagicDroidX spent 2 days in fixing this !!!


Updated on Arch :smile:


Great Pawel :)


You're sure this should be `interpreter_src_dir`? I thought that would be where the sources live…


afair now, it is that using a full URL with scheme always uses https, if one wants to use an insecure registry one has to use the `host:port` format. (so when you specify `http://registry...` a registry for docker, then it still uses TLS for the communication).

We should be save with `https` only here.


Why not use the constant?

(SecurityProtocolType)0xC00
is equivilent to
(SecurityProtocolType)3072
which is equivilent to
SecurityProtocolType.Tls12

given:

  [System.Flags]
  public enum SecurityProtocolType
  {
    Ssl3 = 48,
    Tls = 192,
    Tls11 = 768,
    Tls12 = 3072,
  }


Here missing the unit of packet size. I suppose the minimum size is 8 flits?
But not clear why 8 flits? Head+tail+none data only needs 2 flits.
Also who can query the size from SCM. Is SCM one per core?
If so, I assume a core can query the size limit. Also it does not make sense for Host to query as the id for SCM is not foreknown.


extra space after ``if``


might be worth adding the comment from the commit message here so that it's more obvious to future readers what this is doing.


__API Description file syntax error on line 17698__: the use of tab(s) '\t' in source data isn't currently supported, please contact makers (Autogenerated message from apiary.io)


Good catch. Merged, thanks!


missing space after ``}`` :P


mooi hoor


That would be great if you could do that. I just wrote an email to the user and dev mailing list.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26578/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26579/testReport/) for this commit**


@lauraluiz
Ok, done!
The white background fixed two issues:
- The thin blue border is gone
- Now you can actually read the image alt description

Thanks :)


It is a pity we can’t comment directly from RStudio or Github desktop.

No, nothing is ever obvious… such as every piece of new open source software reinventing terminology because it sounds cooler or to make it easier… sob…

> On 27 Jan 2016, at 11:17, Irene Kitsara <notifications@github.com> wrote:
>
> Got it ;) (oh i have also a “manual proofs” emails address?? cooool
>
> From: Paul Oldham [mailto:notifications@github.com]
> Sent: mercredi 27 janvier 2016 12:15
> To: ikitsara/manual_proofs
> Cc: Kitsara, Irene
> Subject: Re: [manual_proofs] ...ok, now I also changed from Options the "Git" executable location. What i realized is I had set the Github - git.exe instead of the Git - git.exe path... (c931ae4)
>
>
> I think the answer is that the green displays the latest additions to the text ( = will this finally work???) and the red is the original text before that addition.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ikitsara/manual_proofs/commit/c931ae4d6db7a8b40ec47332cceb676659f010dd#commitcomment-15702542>.
>
>
> World Intellectual Property Organization Disclaimer: This electronic message may contain privileged, confidential and copyright protected information. If you have received this e-mail by mistake, please immediately notify the sender and delete this e-mail and all its attachments. Please ensure all e-mail attachments are scanned for viruses prior to opening or using.
> —
> Reply to this email directly or view it on GitHub <https://github.com/ikitsara/manual_proofs/commit/c931ae4d6db7a8b40ec47332cceb676659f010dd#commitcomment-15702598>.
>


Moving to github may be nice, but I'm not looking forward to converting the wikidot.com dialect to github-flavored Markdown. I did two medium-sized pages and it cost me more than an hour. Everything is different, especially tables are very different.


Do you really need to indent here?


Well, there i son Rstudio a “commit message” which i guess could be some sort of commenting?

From: Paul Oldham [mailto:notifications@github.com]
Sent: mercredi 27 janvier 2016 12:22
To: ikitsara/manual_proofs
Cc: Kitsara, Irene
Subject: Re: [manual_proofs] ...ok, now I also changed from Options the "Git" executable location. What i realized is I had set the Github - git.exe instead of the Git - git.exe path... (c931ae4)

It is a pity we can’t comment directly from RStudio or Github desktop.

No, nothing is ever obvious… such as every piece of new open source software reinventing terminology because it sounds cooler or to make it easier… sob…

> On 27 Jan 2016, at 11:17, Irene Kitsara <notifications@github.com<mailto:notifications@github.com>> wrote:
>
> Got it ;) (oh i have also a “manual proofs” emails address?? cooool
>
> From: Paul Oldham [mailto:notifications@github.com]
> Sent: mercredi 27 janvier 2016 12:15
> To: ikitsara/manual_proofs
> Cc: Kitsara, Irene
> Subject: Re: [manual_proofs] ...ok, now I also changed from Options the "Git" executable location. What i realized is I had set the Github - git.exe instead of the Git - git.exe path... (c931ae4)
>
>
> I think the answer is that the green displays the latest additions to the text ( = will this finally work???) and the red is the original text before that addition.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ikitsara/manual_proofs/commit/c931ae4d6db7a8b40ec47332cceb676659f010dd#commitcomment-15702542>.
>
>
> World Intellectual Property Organization Disclaimer: This electronic message may contain privileged, confidential and copyright protected information. If you have received this e-mail by mistake, please immediately notify the sender and delete this e-mail and all its attachments. Please ensure all e-mail attachments are scanned for viruses prior to opening or using.
> —
> Reply to this email directly or view it on GitHub <https://github.com/ikitsara/manual_proofs/commit/c931ae4d6db7a8b40ec47332cceb676659f010dd#commitcomment-15702598>.
>

—
Reply to this email directly or view it on GitHub<https://github.com/ikitsara/manual_proofs/commit/c931ae4d6db7a8b40ec47332cceb676659f010dd#commitcomment-15702744>.

World Intellectual Property Organization Disclaimer: This electronic message may contain privileged, confidential and copyright protected information. If you have received this e-mail by mistake, please immediately notify the sender and delete this e-mail and all its attachments. Please ensure all e-mail attachments are scanned for viruses prior to opening or using.


@sils1297 @Makman2
I have no idea why we needed to have everything two times, but a function `.from_textrange` makes perfect sense to me - in general. I will not include this now for various reasons, but at some point someone will likely need that anyway and write it ;)


Yes, I can put that back, ... but what i syntax is that anyway?
int main(...) try {

...
} catch () {
}
I am pretty sure that I didn't put it there.


Not, it wasn't tested on POSIX. Why it shouldn't work?


print ('Hello world! Eb tvoyu mat')


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12994](https://teamcity.mesosphere.io/viewLog.html?buildId=114239&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:16


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12993](https://teamcity.mesosphere.io/viewLog.html?buildId=114238&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:21


`result->d_name` is `const char*`


@nowrep
Yeah sure. That why i think that the menu buttons should be placed in left. That's the natural structure of LTR languages. That my note was not addressed to you. I just tried to illustrate why that's sucks and unnatural and should not be called STANDARD.


advantage -> disadvantage?


In the case of legislatures there are only ever going to be two-ish for each country, so probably not worth it :) Also in https://github.com/everypolitician/everypolitician-ruby/commit/347c5eb714c52f4a71f98c912fbb477c7494782d I've made it possible to look up a legislature by any attribute, rather than just by slug, so putting it in a Hash wouldn't work for that.

Countries there are a few more, but even with 232 of them the lookup with `.find` is still pretty snappy!

```ruby
puts Benchmark.measure { 100.times { Everypolitician.country(slug: 'UK') } }
  0.020000   0.000000   0.020000 (  0.022474)
```


:+1: :+1: :+1: :+1:! I'm really proud!


Тут не получается слишком много не обязательных оберточных элементов?


I don't think we should add a dma.h at this point.
We are using it here for something that is actually only IMR related.

Can't we move this into imr-conf.h, perhaps?


Screen should be free from any background operation (like image download), please consider using custom target.


missing space


@jose-manywho I think we should change `TwilioConfiguration` to have separate methods for getting each endpoint - doing a `Map#get` isn't brilliant :dancers:


extra space!


0 is for var to contain number even if there is no property


should support both, ppl doing custom machine writes there own ~/.sailfish_platforms.py might not know these gotcha.


Doesn't that completely prevent to delete the user who authored this content?


This should go in the development branch, but your jt-donations branch is essential the development branch at this point.. This the other commit should be in master eventually.


Thanks! Have committed a patch to revert the original bevavior and some optimizations (4024717).


it only uses those for the aspect ratio


Оставил figure, если не критично. Если может при оценке расцениваться как лишний тэг - напиши, удалю в следующей правке.


You can't change the type/scales of an existing collision volume from lua, only replace it wholesale.


Why don't we use imr.h instead ?


:clap:


@ash2k :+1:


Maybe be more specific and catch the [ProtectedError](https://docs.djangoproject.com/en/1.9/ref/models/fields/#django.db.models.PROTECT)?


Maybe we should ask that on github
If we can avoid it, it's better :)


@jose-manywho the tests fail for this branch, but I think because it's using an SDK `SNAPSHOT` from before we started deploying them publicly - we can use SDK version 1.19.4 :+1:


It's a standard library


This version was abandoned because it was too random.
Also, it desperately needed optimization.


@rhuss I've amended commit with the sign off.


Why is it important that it's a number when we do `if (.. !width || !height)` further down?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12992](https://teamcity.mesosphere.io/viewLog.html?buildId=114235&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:11:55


Same comment about `ProtectedError` vs `IntegrityError`.


ok


I agree. I kept this because I was thinking about future changes to the spec. I don't mind removing it although I would think the spec should be updated to take this into account.


regression


lol, this is great!


I would suggest to keep the path consistency here and add the "/" after ``%s`` as for the other script includes. Ditto for the line above.


I patched now I get the below

Fatal Error
Error: Call to undefined function imagecreate()
File: /var/www/tharaasu/Vendor/croogo/croogo/Croogo/View/Helper/ImageHelper.php
Line: 161

Notice: If you want to customize this error message, create tharaasu/View/Errors/fatal_error.ctp

Thanks


Yeah I removed them :)


What is this for? There is not `<span>` in the footer as far as I can see.


Same comment about the "path consistency" for the 2 lines above.


The function should optional, if missing then the code directly calls syscall SYS_sched_setattr.

It would be nice to have relevant information from config.h and compiler warnings/errors.


Pillow is a Fork of PIL and should be enougth


making few changes


I corrected it :)


extra space in ``class="login-text "``


Do you really need that much indentation here?


не нужно создавать лишнюю обёртку для лого. div здесь не нужен. а вот ссылка не помешала бы, потому что по правилам хорошего тона при нажатии на логотип должен осуществляться переход на главную


Does initializing the webapp to nil work? It looks weird to me to rely on variables that might not exist depending on the execution path (but perhaps it is the idiomatic way to do this kind of things in ruby and I'm too used to java).


because we don't gain anything from it.
and because most of the times starting with a clean state is a good idea
oh, and NewRPCServer also syncs (caches) the data from etcd. this means in this situation, reusing a previously running rpc server wouldn't be nice. (the data would be outdated)


@brettwooldridge only logging delta was required?
I think +/- 128ms is required too as mentioned here http://www.ntp.org/ntpfaq/NTP-s-algo.htm#Q-ACCURATE-CLOCK
am I missing something here?


@cacauinbox Acho que aqui seria: `More than 80 succeeded projects.`


Just add -webroot domoticz as the deamon arguments to make the webroot domoticz


Whoops! Thanks!


Not clear about this strict-ordering. Is it global strict ordering that all packets must be synchronized to a global clock and they are transmitted in order. If so, this is kind of heavy. Any topology other than ring may break it. Arguable even ring can break this ordering.
If it is strict ordering related to each core, still a little bit of vague as there are multiple debug modules from each core.
I think enforce strict ordering among multiple modules is very difficult, so you are proposing some global time stamps. In this way, it should not be the network topology to enforce this order and perhaps topology cannot enforce it anyway.


in the same way, stopping an rpc server when engine loses leadership is also a good idea: it forces the clients to do things.


@anosach-luxoft, so we have no idea it is working or not (hierarchy logging)
And after merging back to SDL we will not remember about this,


Do you really need the ``<a href="#">`` here? What about using a button instead?


I'd simply omit the "neo." prefix for odml property names


Could be renamed -begin/endMutation, it would make the relationship with -isMutable clearer.


private: the inmemory registry is not intended to be used out of this package.


if going this route, why not make it an input and the method static?


PreSendRequestHeaders
Check this info: Do not Use, has a bug reported from microsoft

http://www.asp.net/aspnet/overview/web-development-best-practices/what-not-to-do-in-aspnet-and-what-to-do-instead#presend


думал об этом, но как всегда, пока стили писать не начну - не будет полного понимания разметки.
раз ты спросила, сделаю как было - .promo для главной.


Shouldn't you rather put the ``ng-if`` in the ``<li>``?


номер телефона нужно обернуть в span, потому что ему нужна будет дополнительная стилизация


@inpheaux isn't also in GitHub pages we can just input plain HTML as well? That way we can just copy and paste (with small modifications) from the output of Wikidot.


Maybe he meant `#include <cassert>`


Isn't this "viewport" meta duplicated with the one 2 lines above?


Readme edits, fixes #1


@PeratX i dont like copy-paste the code, and if this happened that I hadn't choice


This condition seem incorrect.
Both of following statements will be correct otherwise:
```
CSSSelector("#a") > CSSSelector(".b")
CSSSelector("#a") < CSSSelector(".b")
```

I think we need to add something like:

```
return lhs.id < rhs.id ||
    ( lhs.id != rhs.id && lhs.`class` < rhs.`class` ) ||
    ( lhs.id != rhs.id && lhs.`class` != rhs.`class` && lhs.element < rhs.element )
```


Wtf why do we want spam


Assalom 3alaykom,
I think "**Si vous ne voulez ne pas faire cela maintenant**" can be changed to "**Si vous ne voulez pas faire cela maintenant**"
or and i prefer "**Si vous ne le faîtes pas maintenant**"


aa


Indeed, markdown ate my `<cassert` :(


Bump to `2.1.8` as that's the current Old stable https://www.ruby-lang.org/en/downloads/


Should include `2.2.4` as that's previous stable according to thttps://www.ruby-lang.org/en/downloads/


The variable name is poor, I think. If you look at the Windows code it also just downloads a precompiled VM, and uses interpreter_src_dir.


additionally won't this  remove the ability for the .net application using your application to fallback to another ssl protocol as ServicePointManager.SecurityProtocol is static.  Shouldn't it be:

 ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls12 | SecurityProtocolType.Tls11 | SecurityProtocolType.Tls | SecurityProtocolType.Ssl3


now I remember why I didn't use a callback before:
I wanted changes to be processed synchronously. picture N `e.engineStateUpdate` running at the same time.


alright what about the others RPCServer ??


Might be better to report them as a mismatched begin/end pairs, rather than silently "eat" extra -endTemporaryModification call as the code does. I'm fine with both approach though.


So JIT will keep them always compiled as numbers. Ideally it could have been `| 0` instead of `|| 0` to basically declare them as int32.


So just to get this right: when we are asked to drop the limit, which part of the code does that, assuming that there was a limit set before?


So we have to stop it then, because I reproduced the following error:
https://github.com/giantswarm/giantswarm/issues/481#issuecomment-175078530


As we discussed in Munich: since this whole rcg in neo 0.4 seems to be a moving target it may be best to postpone the handling of the rcg and implement it as late as possible (in this milestone).


Small type here -> // Making


I don't know . I think it is useless in my case


почему ты используешь тег b? он ведь служит только для стилизации, которую легче осуществлять в css


Same typo than previously


oh those lovely micro-optimizations :)

Another take here could be to make width & height mandatory for an image instead of failing silently.

I think that might be more user friendly - right now you can try and render a stream of nodes & it'll error - but it will be a little bit unclear why.


Agreed. I consider the RCG write and add methods placeholders which simply store the basic attributes. This was mostly done so we can have a complete top-level block with at least placeholder objects for the children.


лучше оформить списком


right, and all youtube videos have the same aspect ratio, right?


@DC07 lol. You  found the odd one out :joy:


replaced to Reflex's icons


__API Description file syntax error on line 10215__: the use of tab(s) '\t' in source data isn't currently supported, please contact makers (Autogenerated message from apiary.io)


OK


Error in Octree.inl


Yes, thats right, I will add the flit info.

The formulation is really confusing, what I am intending to say is: "The maximum packet size must be at least 8", meaning, that the system can define a maximum packet size, but it must at least be able to handle packet sizes of up to 8. Always allowing two or three flit packets of course. This minimum is a guess by me to always allow the maximum sized control packet (write 64 bit to register at the moment I think).

The property is system-wide and the SCM exists once per system. The debug software queries the packet size for packetization of variable-length requests (e.g., memory initialization). It also is a parameter to the modules that generate variable-length packets.

Thanks for pointing it out. I will clarify it soon.


Thanks to me for the "receiving a message clears your input box" :D
http://www.sanwebe.com/2013/05/chat-using-websocket-php-socket/comment-page-3#comment-37253


yes


Hehe, but who does that?
I would expect those cases to be programmer errors rather than intended code patterns...
Do you have an example?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12995](https://teamcity.mesosphere.io/viewLog.html?buildId=114240&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:36


This change seems unrelated to the pouch upgrade.  Am I missing something?


For sure, thanks!


That's better.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12996](https://teamcity.mesosphere.io/viewLog.html?buildId=114241&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:38


@jsynacek, I guess this satisfies your use-cases?


как и в catalog нужно переделать


Correct it.


As far as I am aware, sort() with strings such as
a='1.2.321'; b='1.2.4';
[c,ind]=sort({a,b})
does not produce the expected result. "b" have lower "revision" number than the "a" version and should be put first as numerically 4 is less than 321.

In mms_local_file_db.m we split the string and compare each component numerically..

Ver = get_ver(fileList(iSame).ver); fVer = get_ver(fnd.vXYZ);
        if(fVer.maj>Ver.maj) || ... % Newer major version
            (fVer.maj==Ver.maj && fVer.min>Ver.min) || ... % Same major version, newer calibration
            (fVer.maj==Ver.maj && fVer.min==Ver.min && fVer.rev>Ver.rev) % Same major and calib. but newer revision, replace file
          fileList(iSame) = add_ss(Entry); % replace file
        %else, older file.
        end

        function ver = get_ver(verS)
           vT = strsplit(verS,'.');
           for iTmp=1:length(vT), vT{iTmp} = str2double(vT{iTmp}); end
           ver = struct('maj',vT{1},'min',0,'rev',0);
           if isempty(vT{2}), return, end, ver.min = vT{2};
           if isempty(vT{3}), return, end, ver.rev = vT{3};
        end


тоже выделить span


The base specification will discuss this in more detail. I will also clarify it a bit here.

Here strict-ordering applies to a data stream with identical source and destination, meaning that packets cannot overtake each other. Otherwise we end up with flow control and complex buffers.


But, that's why you have the following piece of code:
```
func (r *RegistryMux) EngineChanged(newEngine machine.MachineState) {
	r.handlingEngineChange.Lock()
	defer r.handlingEngineChange.Unlock()

```


massive +1 to this commit!!


вот представь в один прекрасный момент великолепный дизайнер решит, что начертание теперь будет не жирное у заголовков, которое даёт тебе тег b, и тебе придётся в html лезть и все теги править. а если через css делать тоже самое, то нужно просто одно правило поправить


Wa `alaykum as salâm,
Indeed, your suggestion is better, maybe a typing error from me


IStationDao 인터페이스 파일이 없네요.
pom.xml 도 같이 커밋해야 하는데 이것도 없구요,일요일날 만나서 다시 만들어야 할거 같아요.


Nice workaround to avoid `sudo` magic :smile:


Done the changes as requested


Shouldn't we add the xml file name which was failed to parse? It is about providing more context information to the caller.


Looks good! Thanks :) Could you add similar behavior to the `KafkaGraphStageSink`?


Maybe warnings? Error seem to much to me, partial document without the image can still be rendered.


this was popped up automatically by intelliJ at one point of time when I was checking for empty, but then I later on deleted it.


If you saw the other commit you would know that this was a temp fix.


Just 'Thanks @MagicDroidX' is enough


Type safety , Camel casing and primitive data type changed as requested.


I think that there's a problem with incomplete cliques. Here's an example: three reads all in a line: y=0, x=10,20,30 in that order in the list, with the last one being the "keeper", and distance=15. Only "20" will be marked as optical duplicate though I think we should mark both 10 and 20.


Maybe you could only use `tempfile.NamedTemporaryFile` to avoid the later `open()`, but no strong opinion about that... (as benefit it would be removed on failure)


LGTM


Is the error message accurate, do we know it is the SHA1PRNG algorithm?


That's right but in order to have it styled correctly one still needs to use the AppCompat implementation. I can also change this, if you want me to.


Die muss ich haben. Nicht nur das Löschen ist ein Problem wo Daten verloren gehen können, sondern auch Bugs im Browser, die dann beim Speichern einen leeres Objekt senden. Das hat den gleichen Effekt wie Löschen. (Ist gerade bei ecg passiert).

D.h ich werde in den nächsten Tagen eine History implementieren müssen. Jede Änderung wird gespeichert und kann wiederhergestellt werden.


Acho que aqui está bem narrativo


wanted to avoid calling accessors from outside the modal class, I completely agree on the point where it is not a good practice as any entity can set it externally.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26586/testReport/) for this commit**


made it private


The added query: (for the 'sparta' user e.g)

    SELECT firstname, lastname
    FROM User
    WHERE username NOT LIKE 'sparta'
          AND username
              NOT IN (SELECT user1
                      FROM adds, user
                      WHERE user2 LIKE user.username
                            AND user2 LIKE 'sparta')
          AND username
              NOT IN (SELECT user2
                      FROM adds, user
                      WHERE user1 LIKE user.username
                            AND user1 LIKE 'sparta')
          AND username NOT IN
              (SELECT receiver
               FROM notification
               WHERE sender LIKE 'sparta'
                     AND type LIKE 'sendFriend');


Thanks @MagicDroidX


Nicht nur das Löschen ist ein Problem wo Daten verloren gehen können, sondern auch Bugs im Browser, die dann beim Speichern einen leeres Objekt senden. Das hat den gleichen Effekt wie Löschen. (Ist gerade bei ecg passiert).

D.h ich werde in den nächsten Tagen eine History implementieren müssen. Jede Änderung wird gespeichert und kann wiederhergestellt werden.


Is ``unsigned int`` the right type? It appears as though it should be ``tx.vpour.size_type``. (Have I mentioned I hate C++?)


в настройках выставь время
> 26 янв. 2016 г., в 21:56, slykmp <notifications@github.com> написал(а):
>
> Решил продолжить пилить. Мёржу ветку, теперь у меня улитка постоянно висит вместо треда
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/Impish-/echoba/commit/c57fa152be9c6d926a478f32d8d488439f910cd9#commitcomment-15682818>.
>


za


> you would still need to read documentation or code to know what array keys are available

True, but my point was about *reading* the code. Here I have no clue what these arguments would mean, whereas with an array it would be obvious. For writing code, you almost always need docs. ;)


i try to build this, sadly it does not working with serenity :(


@PeratX  and i have very nice idea with redstone. I'm crazy) You will be surprised with all the)


OK, I've updated the docs.


和一个场景名


That's enough. :) BTW,you are doing a nice work.


It's missing from the commit. I'll get it pushed.


Oh,really? Detail?


Aqui também


Какое? (без времени вообще вываливаемся с исключением)


It is not a problem for now as there is no multiple clock domain.
But if there is, I am thinking whether this division is the best option.
I assume the clock for debugging network is not very high because it is a global interconnect around the chip.
In the case that the core has a higher clock rate than debug, putting filters on the debug side might be slow and the cross-clock buffer would be big?
But if putting filters on the core side, then the status registers should also be on the core side.
I believe it is normally not a problem for a debugging module to add extra delays in reading and writing a status register. So perhaps we should just move the status register and filters all to the core side.
On the debug side, there is only packetization and necessary ring control.


Right, makes sense.


qwer


If I remove the line above I get:
```
(WARNING/2) Bullet list ends without a blank line; unexpected unindent.
```
So both above and below seems to be needed.


ты с dev мержился?

> 27 янв. 2016 г., в 16:58, slykmp <notifications@github.com> написал(а):
>
> Какое? (без времени вообще вываливаемся с исключением)
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/Impish-/echoba/commit/c57fa152be9c6d926a478f32d8d488439f910cd9#commitcomment-15703509>.
>


On further reading of the code, this seems to disable the timeout.  Aren't we upgrading pouch so it has built-in support for timeouts?  In which case presumably this option should not be changed.


@PeratX its very big secret. But it is very big "Easter eggs" of Mojang :-)


well, "dropping the limit"  only makes in the context of quota, but not when it comes to block device sizes. You cannot have a block device that has an infinite size. Hence, if you ask for infinite size we drop the quota, but we simply skip the operation for the loopback size.


Oh, upstream uses ``unsigned int``. Sigh.


I don't know why. But `using Escher` only works if this line is changed to `function __inits__()` (mind the "s")

Otherwise I get this error

```
ERROR: LoadError: InitError: UndefVarError: __inits__ not defined
 in __init__ at /home/csto/.julia/v0.4/Escher/src/Escher.jl:67
 in include at ./boot.jl:261
 in include_from_node1 at ./loading.jl:304
 in require at ./loading.jl:243
during initialization of module Escher
while loading /home/csto/.julia/v0.4/Escher/src/Escher.jl, in expression starting on line 66
```


Да


typo: un changed


@ToDo: Use Shapely here:
http://toblerity.org/shapely/manual.html#set-theoretic-methods


миграции провел?


Hmm, this might be confusing indeed though... another option could be to refuse setting the limit to infinity if the device is backed by loopback... But I think this should be done in a later, independent commit, as its not that trivial a change...


Конечно


chalk will take care of this for you.

```js
return exports.colors[type](str);
```

...will do just fine.


Hi, in the line 30 and 67 that have set_rights.sh www-data www-data i needed to put sh before sh set_rights.sh :

sh lizmap/install/set_rights.sh www-data www-data

make sense put this addition on the file of INSTALL.md

Regards
João


shouldn't devtools loaded by app author? why yo have added it into view package?


+1 to adding this function here :)
I would however just call this 'intersects' which matches both PostGIS & Shapely


It's much easier to review a pull request then a bunch of commits. That's the point of pull requests.
You still have to fix the lambda in the README.md file.
I made a separate suggesting about a better way to do enable().
The synchronous option is now broken. If you don't pass a callback and _enabled isn't set yet then it's return value is undefined.


@mixailenko5 So you will not tell me. Right? :)


Без указания ремени:
```python
File "/home/sly/work/echoba/manage/models.py", line 180, in get_time_arrow
    hour, min = self.available_from.split(':') if name == 'start' else self.available_until.split(':')
ValueError: need more than 1 value to unpack
```


I think that if you iterate through the list starting with "keeper", and always mark one of the two reads as a duplicate (so if the later one is marked already as you need to mark it, you will mark the first one instead) it will solve this problem.


@PeratX if i add this on the core i tell you and all people about this.


I like this commit it really slimed down Glang


LGTM.


No need to use raw SQL queries here!
The DAL supports this function...I gave you the link before:
https://github.com/web2py/pydal/blob/master/pydal/adapters/postgres.py#L289


Дык разве это теперь будет работать как Parcelable?


@mixailenko5 OK,I will wait :)


@piton Да, вроде отношения через промежуточную.
Например, когда есть таблица сообщений и таблица статусов, связь делается через сущность message_status_info какую-нибудь, где будет соответствие message_id -> message_status_id.

В данном случае просто не стал усложнять.


You have a full spatial database & yet you just check BBOXes?
Better to do a proper check of the Polygons...


@piton я впоследствии так и сделал (возможно, не везде, но так делаю точно)


We (are trying but) can't replicate the same problem on an empty or simplest project,
it's a 3 layer application, with separed  FronteEnd (web interface) and this use httpclient to get data from Back End (server) in async. all informationa are crypted and decrypted in aes256 dinamically, and json between FE and BE it's compressed.

here the full debug of BE on a single page change from FE,
https://gist.github.com/dorvan/7c91f7012c8c823772ff

the double "//" are already solved. but problem remain.
strange the method convert and "overloads"


@piton ага, пользовался, там же можно и вложенные модели организовывать


хм, у меня без времени работает…
докинь ValueError в exept

> 27 янв. 2016 г., в 17:02, slykmp <notifications@github.com> написал(а):
>
> Без указания ремени:
>
> File "/home/sly/work/echoba/manage/models.py", line 180, in get_time_arrow
>     hour, min = self.available_from.split(':') if name == 'start' else self.available_until.split(':')
> ValueError: need more than 1 value to unpack
> —
> Reply to this email directly or view it on GitHub <https://github.com/Impish-/echoba/commit/c57fa152be9c6d926a478f32d8d488439f910cd9#commitcomment-15703585>.
>


смотри, радиокнопки лежат в body и рядом с ними лежит общая обёртка для всего сайта для смены фона. Ну а лейблы могут лежат на любой вложенности в этой обёртке, если использовать самый обыкновенный контекстный селектор. а в slider будет разметка: .slider>slide*3>img+h1+a


NB Can mention this will be slower...can also do a BBOX intersection check 1st, which doesn't need any spatial DB - just check that lat_min, lat_max overlap & lon_min/lon_max.
If the BBOXes intersect then need the full spatial query...otherwise the failure condition is known anyway.
http://gamedev.stackexchange.com/questions/586/what-is-the-fastest-way-to-work-out-2d-bounding-box-intersection


@piton с тестами в руби я, к сожалению, не очень хорошо знаком, но там дальше factory_girl прикрутил, правда, только для логина.
Учту, спасибо!


Да, базовый класс создаёт себя и наследника.


Will do, just a habit and a way to keep tabs on what I'm working and evolving.  I'll just create another dir/folder separate from "clone" to keep different versions and do a

cp "newer ones" "original file name" and place that in the "clone".


@piton по тестированию в руби мне ещё многое стоит изучить :)


тут будет заголовок другого уровня. h2 у тебя уже есть


@piton и если будет несуществующий юзер, оно свалится с 500, вроде бы


This is a good start pulling some of the Solr syntax out into methods.  But it's still very long and hard to read.  It seems like we could take this further so the query would be something like:

`"#{main_query(q)} OR #{child_query(q)} OR #{file_query(q)} OR #{child_file_query(q)}"`


Не нравится мне такой подход. Зачем так было сделано?


synfig studio gtk+ 3.18 under fedora 23
![synfig-gtk3 18-fedora23](https://cloud.githubusercontent.com/assets/2943058/12613010/101cc466-c4f7-11e5-999f-ff1a6d66ce9a.png)


Thanks for the fix! Keep 'em coming :-)


What is the purpose of logging same exception in debug as well as error?


Тот код, что я заменяю - не работает вовсе. Если передавать базовый MapObject, CREATOR тоже ищётся именно там.


Есть мысли в будущем вообще избавиться и от класса Bookmark, но влазить в ещё один большой рефакторинг сейчас некогда.


:+1: Cargo supports SPDX expressions here, `/` is an ad-hoc cargoism.


I'm guessing x1 = left, y1 = top, x2 = right, y2 = bottom, but it would be good to add some comments here to make that explicit.


Yeah!


@piton точно не знаю как, но функционал там достаточно большой, наверняка можно каким-либо образом.
конкретно эта строка валидации вероятнее всего не требуется, если задан жёсткий переход между состояниями, потому что там автоматически будет вываливаться исключение


removed in dc208cc (fixup)


Fair enough, but what's most confusing about this is the comment in the code ;)


After discussing what `delegate:call/2` timeout value should we use with @Ayanda-D I think it should be `net_ticktime` + 10 (so, 70 seconds). This gives `DOWN` messages a chance to kick in first. WDYT?


```
/* Redefinitions of variables for safe transfer over wire. */
#define TOX_AF_INET 2
#define TOX_AF_INET6 10
#define TOX_TCP_INET 130
#define TOX_TCP_INET6 138
```


Note that on the realm side, you haven't nulled the `mFillDrawable`...

Also - is there no way in android to apply alpha when drawing a drawable? Because that could be useful... in iOS there's such an option by temporarily setting the alpha on the drawing context.


@piton честно сказать, эту штуку просто для своего удобства быстренько запилил. Вообще можно более общий хэлпер для подобных сортировок написать, ну, или - да - использовать гем.


If `key` or `value` has the value of `0` this is accidentally treated as `false`.

Use:
```javascript
if (key != null & value != null) {
```


Remove


What do you mean? I don't understand


Do you have skype or something else where we can coordinate together?
my skype id is waqasrana.haroon

(also please tell me once read, i'll remove my id)


@piton просто хэлпер для переключения порядка сортировки


```
module-whatis   "conda is a scientific python package manager"
```

Should this mention phyluce?


修改


`override` on destructor? I don't understand this.


Looks good, however is the cast to size_t valid?
I don't think we need it.


@piton да, название неудачное, соглашусь. да и от unless лучше отказаться, да.


The best I can do is Twitter: [@clughCoC](https://twitter.com/clughCoC)


@piton да, я уже к концу быстренько накидывал по тестам, тут на самом деле по тестированию достаточно много упущено.
Про фабрики буквально вот в процессе читал, не для всего успел сделать.


changed to 'kitten' in 56644c1


Можно выделить делегат, обслуживающий оба класса. Просто сейчас, если базовый класс что-то знает про наследника, - это плохо. И грубое нарушение ООП.


These files aren't formatted correctly, please install the formatter for eclipse and use it before submitting code.


Brilliant!


looking to see what we stored instead as of 828eba7


@piton запомню, а то не учёл этот момент здесь


@jpkrohling yes, I am quite sure it is enough to override the prop. I do that often.


rectified @ 7049d08 (fb5e967 additionally removes the school logic)


Раздели пожалуйста main и класс container/ это разные вещи) лучше их использовать отдельно. И если подумать, то у нас идёт контейнер в котором есть хедер, мейн и футер. Из-за изначально ограниченной ширины макета.


That's a different issue. I think it means your php does not have gd module.


ingles


Почему такой странный формат? Переменные называются однотипно, при этом имеют разный тип.


These two lines are the same as:

```c
errx(1, "initialize_cef_base failed, size member not set");
```


подобные надписи положи в заголовки одного уровня)


How about putting the stuff here to some shell script and having it called here?


yeah, sorry - have made work for myself trying to write fixups that make some sort of sense as well :crying_cat_face:


Обычно такие штуки мы кладём в `util`. В именах файлов и папок используем camel case, вложенность папок и имя файла обычно совпадает с именем модуля.


good call. https://github.com/dimagi/commcare-hq/pull/10082


should be usec_t


@JustAkan kexec-tools 가 arm64 에 대해서 커밋상으로만 gzip 지원이라 되어있고 실제로는 currently NOT SUPPORTED 라 되어있습니다. bullhead 에 맞는 hardboot 패치도 필요한 상황이고요..

지난번 작업했을때 멀티롬 리커버리와 부팅시 나오는 멀티롬 화면 까진 성공했는데 kexec 명령이 실행될때 메모리 에러가 나면서 튕기고, 배터리 상태를 보니 뭔가 잘못 됐는지 계속 깎여 내리고 있었습니다.

추가로 현재 멀티롬 리커버리에서 마쉬멜로 롬을 멀티롬으로 설치시 인식을 못하는 현상이 있습니다.
최근에 6.0 관련 커밋이 있긴 한데 이에 대한 패치인지는 확인을 못해봤습니다.


Thank you @aequabit for the attention to detail here and improving a weak point in Snabb Switch i.e. meaningful error detection and reporting.


А реально без этой портянки обойтись?


then i guess we'll communicate here. I'm a bit new to how github and dont know issues etc works (had to google pull request). You have 3 linked projects and i'm not sure where to post issues :P

i'll give it a go, if i post in wrong repo, do correct me.


made it private


Так как картинки будут задавться через css было бы неплохо к features-item приписать ещё классы для этих картинок, например «features-item features-item-food»


(we use usec_t inall our internal code for usec time values. sd_event_now() and friends expose uint64_t instead, since they are public API. But internally we should still use usec_t everywhere...)


@JustAkan 아 그리고 질문드릴게 하나있습니다.
혹시 Wi-Fi 사용하시면서 일정 시간 동안 패킷 흐름이 없다거나 처음에 전송 시작시 속도가 급격히 낮다거나 하는 증상 없으신가요?
릴리즈 하려다가도 계속 이것땜에 말썽이네요.


Is it good form to put images in the style sheet? Why not put it directly in `master.html`?


ああ


Mangler doc comment


あああ


Thanks!


Плохо, но не хочется влезать сейчас в красивости, пригорает остальной функционал. Предлагаю сойтись на тудушке.

> On Jan 27, 2016, at 3:18 PM, Alexander Marchuk <notifications@github.com> wrote:
>
> Можно выделить делегат, обслуживающий оба класса. Просто сейчас, если базовый класс что-то знает про наследника, - это плохо. И грубое нарушение ООП.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/yunikkk/omim/commit/422d4d1a9df2bc186a762d62f92cce5fb3e08437#commitcomment-15703937>.
>


Did you get a chance to look at the reddit responses you got? A couple of them had really good advice to take.


Space after ,


Looks like a mistake. Reinstated.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12997](https://teamcity.mesosphere.io/viewLog.html?buildId=114256&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:28


@ntwb What's in this release?

Have you added new rules or changed options? If so, can you list them in the changelog.

Based on that we can work out whether this is a major, minor or patch release :)


кстати — №1 — делаем  в разметке


> Wouldn't CMake be satisfied if we put `config.h' into the top directory?

I could even write the config file in the src directory, but this is an anti-pattern in cmake. Let me explain why I want to avoid this: In cmake you have a build dir and a project dir, which *can* be the same, but don't have to. The project directory contains the root `CMakeList.txt`, whereas the build directory can be *any* directory and is specified during the project configuration. The expected behaviour is that all temporary files and the whole build output go into the build dir and its subdirectories, so that the project directory won't be modified during configuration and build if you choose a different build dir than the project dir.
How about getting rid of config.h by specifying the `HAVE_*` options on the compiler commandline? These options don't influence the public API and thus don't need to be persisted in a file.


wanted to keep it public as I wanted to prepare test case by setting it externally.


I think these two values should be #defines defined at the top somewhere... so that this becomes:

```c
client->start_delay = CLAMP(client->start_delay, RESTART_AFTER_NAK_MIN_USEC, RESTART_AFTERNAK_MAX_USEC);
```

or something like that...


You can do that too but I just didn't want to mess with the
margins/paddings.

2016-01-27 13:26 GMT+01:00 Jan Pecinovsky <notifications@github.com>:

> Is it good form to put images in the style sheet? Why not put it directly
> in master.html?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opengridcc/website/commit/686b9a3714ef6a5797d2427360efa87182ca704d#commitcomment-15704087>
> .
>


$this->startsWith returnerer en bool så der er ikke grund til at lave en === TRUE