That's weird! Promise is a built-in JavaScript object. app.Promise is just a pointer to the built-in Promise object.

Please open the background page and see if Promise is defined there
![screen shot 2016-01-17 at 11 16 44](https://cloud.githubusercontent.com/assets/351062/12376490/f6582c5c-bd0b-11e5-84cf-46b2613c7b14.png)


That's a really clean way to deal with the data changes. Very nice!

Being in Australia I can't test this. I'll have to merge and let others have a look. Also, is there a Trello card for this one? Couldn't see it at the moment. Happy to add one for you if needed.


> @inbasic Are you sure this is version 0.6.1? Manifest is still 0.6.0

Yes, I just haven't updated the manifest yet. https://github.com/inbasic/ignotifier/blob/beta/src/manifest.json#L6


Shiny!


Do you also have changes to validation code that catch these ?


please use { } as that's a good practice


the original returns undefined. wouldn't it be better to to do the same for consistency
https://github.com/sahat/satellizer/blob/master/satellizer.js#L317


Fine. Let me try now.


now I just add .gitignore file to exclude any intermediate files such as obj, exe...
If you find more file types or directories to be excluded, please add them.


Remove extra dash.


because if `${${ans}}` doesn't work here.


Just for information. The pull request will be evaluated and merged after the end of the Toggl developer challenge (https://toggl.com/toggl-developer-challenge) on February 14th. Thank you for your contribution.


@jacobwgillespie It looks like there is an unencrypted private key in your git log

https://github.com/radiant-player/radiant-player-mac/blob/43766377026544fad7fb87d838f2d35b0458285e/keys/private.pem

I was just browsing through commits and this stood out as something that maybe shouldn't be there.  It looks like you missed a force push at some point.  Not sure you you could fix this without a massive `rebase` through history.


What?


aah, great! Thanks!


Can you change that method such that it no longer prefixes the message with module id?


</html>


コメントありがとうございます！なるほどです、！しかし、このあとthumbnailがないとprototypeを投稿できないようバリデーションをかけるつもりなので、条件分岐はいらないので消してこのように修正しました。


bad pull


I agree. That means refactoring of the `exporting` module


This is merged now.


I added toy version 1 for map digitization.
I think I can solve lots of major problem of this solution within a week.
With this first commit, I tested and confirmed listed below.
1. I compiled the GMap dll files successfully, and referenced them at the toy1 project.
2. I extracted core parts of dll's api, and used at the toy1 project.
3. I can now draw current position's marker, and add other markers with ctrl-key.
4. Each marker object has 2 positions : one is display position, another is geo-position.
You can refer this document. (http://greatmaps.codeplex.com/documentation)

Until this week meeting(21-01-2016), I can complete major toy test, such as multiple site draw, sites information serialization to disk(sqlite), reload from sqlite., etc..
I can explain this solution at that meeting.
After this toy test, I think we can work together.


Oooh, handy!


ayo


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 208](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=678&buildTypeId=XbimEssentials_XbimEssentials) is now running


sd


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 208](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=678&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:35


@mohangk I kinda love default vim shortcut.


Да всё нормально, я же говорил, что дал тебе права на запись, вот и проверили как оно работает.


Maybe we should document here, that this uses a naive slow algorithm, not a suffix tree


i think `translator.translate()` is fine and not really redundant.  it's explicit about what the method is doing.  with `translator.t()`, you're relying on there being context in the surrounding code to make it obvious what `.t()` is actually doing.  im not entirely sure how/where the method will be used, but you're also going to be relying on the fact that the object is named `translator`.  i also feel like it would be harder to locate `t` when searching through code compared to `translate`.

i dont think it's redundant, since `translate` is what a `translator` does.  i think a redundant situation would be if you had a `translation` object with a `translation` property to hold a translation, like `translation.translation`.


There was a problem with relative links inside html documents. For example:
```bash
mkdir test123
cd test123
echo '<html> <a href="./about.html">./about.html</a> <br> <br>
<a href="about.html">about.html</a> </html>'  > index.html
echo '<html> <h2>About</h2> </html>' > about.html
cd ..
hserv
```

If you open in browser `http://127.0.0.1:8888/test123/` you will get `File not found`, when you  try to click on links. Adding a slash to the name of the directory solves this problem.


Even these are for power efficient wq:
https://github.com/neobuddy89/shamu/commit/e51126823a0bbf28d2ef4b1cfb887065a473a34b
https://github.com/neobuddy89/shamu/commit/efa140e483a1b7970b82462501b6c90102ffce23


@mistadikay


Hi Mr Napoleon, I really like your videos.
I wanna ask you if you could help me how to make m3u from xml or plx on windows 10. please?


Thanks @rhc54

i initially wrote a different fix.
We should decide what ```orte_util_snprintf_jobid``` and ```opal_util_snprintf_jobid``` should return in case of success.
i was initially thinking of returning the number of bytes written (e.g. the return code of ```snprintf```), but i am fine with returning ```OPAL_SUCCESS``` / ```ORTE_SUCCESS``` too.
current behaviour is not consistent (e.g. ```ORTE_SUCCESS``` if ```ORTE_JOBID_WILDCARD``` but ```snprintf``` return code in the other case.
any thoughts ?


@neobuddy89 thanks, will add shortly:)


css


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 209](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=679&buildTypeId=XbimEssentials_XbimEssentials) is now running


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 209](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=679&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:34


@minaz912 no need for loop; just use vm.list = data.data


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 210](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=680&buildTypeId=XbimEssentials_XbimEssentials) is now running


@roblav96 Thank you. I fixed the issue by changing the dependency to 4.0.0 which is a stable version. I checked and it was working. but let me know if there was any problem.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 210](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=680&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:31


I hope I understood correctly and you mean dst.x0 + p->x here (and similar for y). I did that. Though I don't see any difference before and now, things appear where they should, and by "things" I mean videos with various aspects (4:3, 16:9, 2.35:1; including anamorphic), the osd, different kinds of subtitles (ssa, vobsub, styled ssa/ass).


From here: http://www.jvcref.com/files/PI/documentation/html/struct_m_m_a_l___d_i_s_p_l_a_y_r_e_g_i_o_n___t.html#ace67a311b29a3ac8684d56fb21030dea

"Indicates that we are using the full device screen area, rather than a window of the display. If zero, then dest_rect is used to specify a region of the display to use."

What happens in practice is, if I don't set the flag then the video will always be fullscreen instead of where we want it to be.


Is this really needed? Anyone who uses a framework should know the basics and has a local server with a dbms.
Or I am wrong?!


Ah, cool, thanks for the hint. I was already wondering how you are going to deal with the lack of OpenCL in the Travis-CI builds ;-)


Done.


Oh no, not „phpMyAdmin“ – it's the worst choice for database development.


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 122](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=681&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


Good explanation! :+1:


Please always set this to false in next commit so there won't be whoops when you push a pre-release.


I agree with Artur that translator.translate('bla') will be painstaking to use for translations (In the cake world, it used to be `__('bla')` for instance. But since folks can use `const t = translator.translate` locally, I agree with Harry that we can allow ourselves the longer version here.


1. xorg-video-nvidia304 ile xorg-video-nvidia340 xorg-video-nvidia-current çakışıyor. Bu nedenle iso oluşturulacak ara depoda silinmesi gerekti.
2. Ksnapshot depodan silinmediği için iso da gelmiş, depodan silinecek.


+1 this crashes node


@valib you have a Panasonic TV right? Could you (and any of the other @UniversalMediaServer/developers ) see if these changes are appropriate for other Panasonic TVs you may own? I suspect they all have the same or very similar file support. You can use the video testing suite I made at http://sourceforge.net/projects/unimediaserver/files/Official%20Releases/Windows/VideoTestingSuite-1.0.7z/download


Ah, I also had that mistype all over my notes. Thanks!


hello I need help installing the proxy in windows. You can help?


Thanks, Rocky. You are right, of course, and certainly the reason for the 0 scaling is that ranks 7 and 8 are compensated somewhere else in the code (possibly even in middlegame code) since this is connected with promotions.
Looking at the course of the tuning these zeros remain stable which confirms the above.


erk.


Is the `ArraySerializableInterface` with `exchangeArray` and `getArrayCopy` a good idea? Yes, it's really simple, but I think the hydrator should take a greater role in this tutorial – from the beginning.
Btw. with `Zend\Hydrator\ClassMethods` you don't need `exchangeArray` and `getArrayCopy`.


I was wondering what the best practices for handling these files might be. They are quite a pain in terms of diffs because of the changing row number references. Separate commits might be a way to go. The same probably applies to code layout changes.

From now on I'll try to keep such commit types separate, commit more often locally and if necessary sqaush by type before pushing.


use typedef for std::vector<std::pair<LogicObject*, LogicObject*> >


Hm… würds dir was ausmachen, für das hier nachher erstmal ne PR zu stellen vorm mergen? :)


@varlesh

https://aur.archlinux.org/cgit/aur.git/commit/?h=papirus-git&id=0ae5a1e5226a0fdb2c7999892c13273b5b394c6d

and fix ;)

https://aur.archlinux.org/cgit/aur.git/commit/?h=papirus-git&id=68b76970b2b61bc322a62e7fa1d0b8418ac08711


%Zeineb: "That is why, after some initial studies of noise in a specific game in" --- or "That is why, after an initial study of noise in a specific game in"


I think, a hint to the "Table Data Gateway" design pattern and a link to http://www.martinfowler.com/eaaCatalog/tableDataGateway.html would be nice.


I assume if we want to disabled the teleport function all that needs to happen is change from true to false and clothing_box to clothing_random?


Machen `build:js` und `cp` nicht irgendwie das gleiche?


Which is quite sensible, @aboe76


Well, since I add the database configuration for database, user and password later on, it will be helpful to use the same values.


TeamCity LabKey :: Trunk :: Community :: CDS postgres 9.4 [Build 69](https://teamcity.labkey.org/viewLog.html?buildId=297401&buildTypeId=LabkeyTrunk_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 14, passed: 34 Build time: 01:04:14
### Failed tests
```
org.labkey.test.tests.CDSSecurityTest.verifyUserPermissions: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyCounts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterPane: <no details avaliable>

org.labkey.test.tests.CDSHelpCenterTest.verifyHelpCenter: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

##### there are 4 more failed tests, see build details
```


Okay, see below… :wink:


Yep, but it is well known to almost anyone. If you have more suggestions, please name than.


:smiley:


Line 131- %Zeineb: "That is why, after some initial studies of noise in a specific game in" --- or "That is why, after an initial study of noise in a specific game in"


Thanks for catching this.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11789](https://teamcity.mesosphere.io/viewLog.html?buildId=106631&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:09:15


Well, I do know `Zend\Hydrator\ClassMethods`. We decided to use that interface and the hydrator mainly for simplicity. It simplifies the form handling in the action middleware as well.


I mean, delete this part and all is fine.
This should be enough:
> First, we need to setup the database. We will use MySQL for this tutorial, so please create a new database called `album-tutorial`.

No user creation and no database tools.


Maybe we should replace this by a default link towards the GitHub Page of the MISP project? This would be useful for the users of the MISP platforms to know where the source code of the application is available (following the GNU Affero free software license).

The copyright has been expanded to various contributors as mentioned in https://github.com/MISP/MISP/blob/2.4/AUTHORS.


Why did the CRSF get removed?


the second "bug_status not in ['NEW', 'ASSIGNED', 'ON_DEV'] means the bug is in a state ready
 for QE and the test will be run and reported on." should be ['ON_QA', 'CLOSED', etc ...]


That is very cool change :+1:


fix #47


actually, how often will this need to be called?  after I looked at cake's `__` function, i realized this may be something that needs to wrap strings all over the place, as opposed to being called once or a handful of times.  in that case, im definitely on board with something short like `t`.

we used `_i18n(string)` on the last project where we implemented localization.


Issue #16 done


Just go ahead and modify the line. You can do it online using the editor,
or download it using git.

2016-01-17 10:05 GMT+01:00 Zeineb <notifications@github.com>:

> Line 131- %Zeineb: "That is why, after some initial studies of noise in a
> specific game in" --- or "That is why, after an initial study of noise in a
> specific game in"
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/geneura-papers/2015-ECTA/commit/750ebe7b278235da0f1c50c5b4b4c5b3dc8def4e#commitcomment-15494294>
> .
>

--
JJ


Ok, I suppose you are right.


> Well, I do know Zend\Hydrator\ClassMethods.

I know you know that! :wink:

> It simplifies the form handling in the action middleware as well.

This is a very good point, but is this a good choice for progressive developments?!


Should we add DocBlocks?


These must be in... did you start your translations with an outdated file? You must make sure to first update your `master` branch to the state of ours before using it as a base for changes.


> only char * and String no Flash string, it may compile and looks ok
> but this could generate crash
>
I'm a complete ESP8266 newbie, so please erase stupidities directly :-)

Nevertheless I'm surprised because the F macro does an "interpret_cast"
to a new type (something like "FlashHelperString__") and thus if there
is no associated method, it should complain. Am I missing something here ?

T.


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 122](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=681&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **SUCCESS**
Summary: Running Build time: 00:36:54


Is a simple `$this->select()` not enough?


> you have compilation error ? I am pretty I do not but will double check

The OTA update function calls WifiUDP.stopAll() but WifiUDP.h was
included indirectly by SSDP.h only.


Le 17/01/2016 04:02, Luc a écrit :
>
> actually the goal was:
> have authentification for user and another aithentification for
> sensitive admin settings,
> but just did the admin part right now
>
> display admin /icon to show need to be authenticate to use this page,
> may not be obvious
>
Ok. Understood. I was so happy to have only string to enter :-)


Thx ))


Please consider using [`XDG_DATA_HOME` environment variable](http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html#variables) first.


The same here with `$this->select(['id' => $id])`.


将核心词、冒号词、变量、常量统一实现，根据代码域指针的不同，对参数域的处理也不同。


Well, the focus of the tutorial is on `Zend\Expressive`. The model layer is already very complex for a beginners tutorial that concentrates on `Zend\Expressive`. Yes, the choice might not be the best and there is much room for improvement. If you haven't done yet, please read the discussion here on the model-layer:

https://github.com/RalfEggert/zend-expressive-tutorial/issues/6

Maybe that clarifies why we made some of the decisions.


Damit ist die Position beim Start des Roboters gemeint.


why do 3.3.5's outdated/removed/changed quests and spells get merged to 6.x ?


…for all classes!


I deleted them from the original code because I thought it might be too much.

https://github.com/RalfEggert/zend-expressive-tutorial/blob/part3/src/Album/Model/Storage/AlbumStorageInterface.php

Not sure if I should add them.


This will reduce the explanation below.


Yes, but the idea was to add Zend\Db\Sql to the mix as well. I really like to use it whenever I can because it is easy to understand and selects, inserts, updates and deletes all work in the same way with the *with() methods, while the other methods all have slightly different params.


Mindre ändringar


merge


yup
want the perf profiles ?


No more comments on this commit!


Add a command line argument to set the hostname/port/offline mode without editing the config file.


fixed. thanks.


Great


Effectivement ca devrait être le cas, sauf que le if ligne 145 est foireux (parenthèse fermée après 'Gouvernement' donc `if (false in groupes)`) et donc le bloc ne s'exécute jamais. A supprimer.


Thank you for the link.

So: `ArraySerializableInterface` is good. :smile:


create


круто! а чо не `@yummies/eslint-config`?


@MrPowerGamerBR Later, got a semi-bricked Samsung Galaxy S4 Mini (LTE) (i9195). I can flash stock firnmware and boot up but it says device memory damaged and a reset button so I click that and it says "Could not do boot".


It would explain:

```php
$collection = array();
foreach ($this->selectWith($select) as $entity) {}
```
https://github.com/RalfEggert/zend-expressive-tutorial/commit/b6c1ee9244740bdcf68916b8109d3e9b1c685c32#diff-8406b6dd56b0e943927c4f78b1800bd0R252


default yarn-site.xml configuration
https://hadoop.apache.org/docs/r2.4.1/hadoop-yarn/hadoop-yarn-common/yarn-default.xml


I will upload something bigger later :)


we wont argue about
``` };```

LOL.. almost a fight with some (idiot) IT manager last week...


Currently can't compile it with **buildpkg**. I always hit followed error:

```
/bin/sh: line 1:  7590 Segmentation fault      (core dumped) ESPEAK_DATA_PATH=/build/espeak/src/espeak-ng LD_LIBRARY_PATH=../src: ../src/espeak-ng --compile=af
Makefile:1793: recipe for target 'espeak-data/af_dict' failed
make[1]: *** [espeak-data/af_dict] Error 139
make[1]: *** Waiting for unfinished jobs....
	506 rules, 48 groups (0)
```


Yes we can push it to the server. It accepts POST requests with the MultiPart form/data. It doesn't return an APK yet, though. I'm nearly done with that, too.


`[{atom, any}]` is the type spec for `options`?
how about `result`?


这个  `woudle then react to this update 2 seconds too soon`是什么意思啊
我觉得应该是 `这个更新对于2s而言是在太快`这个意思，但好像又不太对

@catherine2014  @yuanzhaohao


On second thought, I found that `ToAPIContainerStatus()` is not a self-contained function either, because it can only set container to *Running* or *Terminated* and can not set `LastTerminationState`, it is more like a helper function.

So I believe you are right, these two functions should not belong to `PodStatus` and `ContainerStatus`, I'll put it into kubelet for now, and try to find a better place for it.


prečo sa tieto eventy nezobrazujú ( ak sú to eventy ) a ak to nie sú eventy ta kčo to je ?


Ajouté à la todo list


agree with you it should complain per my understanding, but it do not,


Hmm, unexpected. I reused the work I did for "next" branch and there is no CRSF protocol in se.h.txt and never was. I had an updated "master" and checked that the last one or two patches were applied and assumed se.h.txt was in sync. Never assume though. I will need to go through this in detail again and really sync with en.h.txt.


> …in the same path.

Would help an overview of the directory structure? Maybe after the last file / class is created?!


@wzrdtales, There is anything new with the new version? Do you think I can use this branch in the meantime?


@elia Maybe we could rename --module to --library or use --no-source (to stay consistent with --no-exit and --no-opal and --no-method-missing) ?


Upgrading to Flask-Bcrypt==0.7.1 totally did not work out for my app and I had to go back down to 0.6.2 due to inability to clear a "Invalid salt" error when trying to log in a created user. The exact code in this template does not work at all for me with 0.7.1 but works fine with 0.6.2.


ありがとうございます。そこ、書きかけになってるところですね。まだ書いてる途中だったので間違ったコードになってます、はい。とりあえずいただいた内容に修正しておきました。(この部分は探索部を書くときに変更すると思います。)


no your approch is correct, I just do the short path because I am also wondering if it worth to have admin user for wifi setting and simple  user to access printer and guest for  information only


test


This is never used. Add this to the comment below.


Seems `make -j1` fixed the issue on my AMD CPU.


And just for you, a screenshot of the Sudoku puzzle

![image](https://cloud.githubusercontent.com/assets/11202073/12376836/d226b35c-bd07-11e5-8d81-2a5ead719748.png)


Well, I thought of adding this repository to compare the code at the end of each page. Maybe that would help the understanding?


But it is used in the comment below, isn't it? ;-)


I like the idea.


Sounds like a good idea.


Cool! Do you have any idea what values the Link* characteristics are supposed to be?


I think you don't have to pass `newItem` here.


#228 someone do me a favor and add a proper dialog on this.


```php
$this->select();

$this->select(['id' => $id])->current();

$this->insert($insertData);

$this->update($updateData, ['id' => $album->getId()]);

$this->delete(['id' => $album->getId()]);
````
vs.
```php
$select = $this->getSql()->select();
$this->selectWith($select)

$select = $this->getSql()->select();
$select->where->equalTo('id', $id);
$this->selectWith($select)->current()

$insert = $this->getSql()->insert();
$insert->values($insertData);
$this->insertWith($insert);

$update = $this->getSql()->update();
$update->set($updateData);
$update->where->equalTo('id', $album->getId());
$this->updateWith($update)

$delete = $this->getSql()->delete();
$delete->where->equalTo('id', $album->getId());
$this->deleteWith($delete)
```


Created by Admin on 17.01.16.
Who is Admin??
Here should be nick name.


Please remove this Copyright


please fix indentation


Here are the changes to resolve Refactoring #6 on the Trello. Here, I shortened the createEvent() method which was very long. I did this by taking using extract method techniques to pull some logic of creating and populating new arrays and events into their own methods.


Devtools will be open after reload with chromedriver.


Why you extends from NSObject ?
Can you use Swift classes ?
```Swift
class User {
....
}
```


I think you changed these by mistake. Never use "git add ." unless you are perfectly sure that all changes are *correct* and relevant to the commit.


@ig0774 three questions / comments on this code:

1. why is it necessary to test if cmd is an instance of subprocess.Popen?
2. if there is a project file, the script_commands will be read from that, correct? This will make it extremely useful, I believe---for instance, one could run some non-tex program to generate pictures then input them in a doument.
3. One additional caveat should be that tex & friends should be invoked with `--interaction=nonstopmode`; otherwise, what if an error occurs? Wouldn't the user have to manually kill the compilation process?

Thanks---this is really cool!

BTW, a neat addition would be the ability to switch to the traditional builder after the specified commands have been executed. This would simplify the scenario in 2 above. But that can definitely be for a later release.


May forgot to remove this line


resogun est tout buger maintenant, et ça affiche mème plus les premier logo c'est normal ?
![capture d ecran 2016-01-18 01 05 18](https://cloud.githubusercontent.com/assets/5261759/12380939/8ccb5d4e-bd7f-11e5-9095-4c05bf517ccf.png)


to much spaces here


remove commented code


Issues mentioned in this commit (eeb4a84fa8e8d1d6086df30d22a90f220324ba85):

* [Issue #26](https://bugs.mtasa.com/view.php?id=26)
* [Issue #28](https://bugs.mtasa.com/view.php?id=28)
* [Issue #200](https://bugs.mtasa.com/view.php?id=200)
* [Issue #28](https://bugs.mtasa.com/view.php?id=28)
* [Issue #29](https://bugs.mtasa.com/view.php?id=29)


Opps, this is actually a copy of "arch/arm/boot/dts/am335x-bonegreen-wireless.dts" i couldn't find your actual arch/arm/boot/dts/am335x-bonegreen-wl1835.dtsi on github..

Please send again. ;)

Regards,


I'm honestly not sure what the answer here is. We have a similar issue with `diesel`/`diesel_codegen`/`diesel_cli`, though the biggest difference there is that `diesel` is likely to change more often than `diesel_codegen`, while `dotenv_codegen` is likely to change more often than `dotenv`. Perhaps it's a non-issue since we're not actually relying on anything that's breaking, and the changes are likely just to be changing the upper bound of the `syntex` requirement. I think it's fine to have `dotenv` be `0.8.0` while `dotenv_codegen` is `0.8.12`, since people will be requiring `^0.8.0` in both cases.


sorry to be pedantic, but I hate it when people use 'my' as a prefix for variables ;). Can you just call it 'value' or something like that? :)


CuraEngine already does that, I believe: https://github.com/Ultimaker/CuraEngine/blob/2.1/CMakeLists.txt#L86

It could be made to work for Cura's Python side too, I'm sure. Then we could leave this file out of the repo, even. I'm never keen on having generated data in a repository.


Change user name and password for installing on web server apache of xampp.


This seem not to work. Package.json has "jspm", but `pkg` object does not have it.


With git 2.4.3 on OSX Mavericks, I get this:

    error: unknown option `format=%(committerdate:format:%s) %(*refname:short)'

The patch list also isn't sorted and only shows patches in the 1000+ range.


This was done as part of the work for issue #1


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1186](http://teamcity.monogame.net/viewLog.html?buildId=13719&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


System.currentTimeMillis() ?


Here, I noticed some heavy temporary field obsession. Since the fields were only used once after being instantiated, and they were created by simple queries, I thought it would be useful to use the Replace Field with Query refactoring technique to solve this problem. Beyond this, I also extracted this chunk of logic into its own method using Extract Method.


And if query the main window too early, the whole app will be froozen.


This change is just like the changes for the following commit. Please refer to that commit's comments to see what exactly was done.


I was trying to change here, there is actually no need to pass it.


Good call! Maybe a description as well. Adding that now!


Created  subclasses and a super class for login activity. The subclasses was extracted from MainActivity and other classes. This was done to avoid duplication.


This is a bug that prevents oAuth update working. Make sure 'id' is a string.


Looks like you misspelled "canola"


istreambuf_iterator has a constructor signature that accepts the return type of its post-increment, corresponding to the `cursor` constructor up on [line 134](https://github.com/CaseyCarter/cmcstl2/commit/aea1cd2ff2de37df6ad4dd337a7f035dff09a260#diff-dd97e9f1f57bc069f481d2bf92f36f61R134). istream_iterator also uses `post_increment` to override the default behavior - it needs to return a copy of the "old" iterator value like a `Forward` iterator would.


http://www.ict.griffith.edu.au/teaching/2501ICT/cgi-bin/man.cgi?fesetround+3

I assume it is fe set round


c'est du wip, ça risque de pas mal casser. Je sais pour le logo de sauvegarde.


Having ticks modify observables is a performance nightmare.  If you have x animated objects on screen, then you would redraw the canvas x times every frame.


Yup, good catch!


Thanks


It is still untested on the robot.


I previously planned to incorporate some graphical pyGame element, but I no longer see that as a direction for the game. Yes, Python 3 is fine. My group of about 5 developers ("developers" meaning teens who decided to help me make a game) has gone on to some Unity work, so I'm kind of staying to manage the project. My laptop that I bring to our meeting place is too old to run Unity, and I'm too stubborn to learn Unity instead of a classic programming language. I've never been very good at sticking to standards, I just write code when I'm bored and want to do something. I just write some bugs and then take 20 minutes to turn the bugs into badly formatted code. :|


HBIRE_vector_take2 (amirroth) - i386-Windows-7-VisualStudio-12: OK (2047 of 2057 tests passed, 506 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.51%25-yellow.svg)


Shouldn't you write some tests? Every time you fix 1 thing in Intellij Scala lately you break 5 things.


Shouldn't you write some tests?


This title is wrong.


I think is more clear if it's on a separate row.


The @depends has to be corrected.


`s/set generate/generate`


Some weird indentation


I think this looks better if you emphasize it with back ticks, also one row was missing two `"`


typo


See above


Looks great to me! We can do the same thing when we add the child row expansion columns later.


lol :smile:


If it pleases girscanner, I don't see no problem with it


Looks good -- could you send me a pull request for it and I'll put it into 1.20_04?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1186](http://teamcity.monogame.net/viewLog.html?buildId=13719&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:26:19


ambition towards lisp interface.


Script for processing data and creating a weekly report.


This will break non-Windows :(

`SQUASH_PLUGIN_DIRECTORY` is THE directory where the plugins should be placed when they are installed, but the tests should run after building but before installing.  Basically, it's the thing we are trying to *override* with `SQUASH_TEST_PLUGIN_DIRECTORY` so the tests can be run without installing the plugins.


Issues mentioned in this commit (0a689f0a9c5f6dd6653bd7840bb8662b7d5ff913):

* [Issue #123](https://bugs.mtasa.com/view.php?id=123)


Removed "show command" checks throughout


Good catch.
At least his [version names are consistent](https://github.com/eligrey/classList.js/releases).


I can find many references where this creates a problem:
`<select onChange="setExtWmsLayer('${my.baseurl}/geoserver/wms','ANFOG Glider ','1.1.1','anfog_glider','',this.value,'')">`


Ahaha, whoopsies


Look at the rest of this PR. It handles those.


HBIRE_vector_take2 (amirroth) - Win64-Windows-7-VisualStudio-12: OK (2045 of 2057 tests passed, 504 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.42%25-yellow.svg)


Issues mentioned in this commit (b80fb081af68b4c6031d66c136ec5b58a75a26c0):

* [Issue #9001](https://bugs.mtasa.com/view.php?id=9001)


Does this loop need to be inside the synchronized block ?


I guess I could just include a readme file with tips.


The end?.. =) it's work


else if ?


Make sure to leave merge pull requests after making changes :-) (unless you didn't want to merge)

The reason this logic is in here, is that m3u files can use relative paths from the .m3u file, and the absolute path has to be calculated to match up with Plex. Removing this code makes the relative paths no longer work. I thought I had made this project Linux compatible, but I might have forgotten to match linux style absolute paths. If that is the problem, I would be happy to add it.


I was looking at the contributor list, and this is your 500th commit. Grads on the misspell agin >.> <3


ПЫ СЫ потестил на нагрузку. ты был прав ошибка в логике, была.


Joins, and joins, and joins!


Can you elaborate on why you think this link should change?  My feeling is that http://docs.haskellstack.org/en/stable/GUIDE.html#travis-with-caching is the better starting point (and it links to the full document if people need more), so I'd like to understand your reasoning better.


Call new function to check if the comic exists in the comics table. If it doesn't, a new comic entry will be created and an entry in the users_comics table will be created to associate the user with that comic.

If the comic already exists in the comics table, we just add an entry in users_comics.


this isn't necessary


Use blocks.back()


Use C++ random.


this can be done via python manage.py shell  why do we need to add another one? why not just release the commands to run it mannually?


Ah ok, thanks :)

Well I've tested and was able to replicate the decode error by switching my Kodi language to German. Crashed as soon as it started. To fix it, we need to encode to utf-8 first, then decode to unicode. Turns out, it is indeed ascii to begin with. Weird huh?


10以内的数的平方


내가 영알못이어서 철자실수함ㅋㅋ


the comment is no longer correct


OK.
There are some warnings:
Mapnik LOG> 2016-01-18 02:11:02: Unable to process some data while parsing 'osm.xml':
* attribute 'repeat-distance' with value '800' at line 86
* attribute 'repeat-distance' with value '400' at line 104
* attribute 'repeat-distance' with value '800' at line 120
* attribute 'repeat-distance' with value '600' at line 139
* attribute 'repeat-distance' with value '400' at line 156
* attribute 'repeat-distance' with value '800' at line 171
output image to image.png!

Mapnik2 probably doesn't understand "repeat-distance". It's in default/inc/otm-contours-styles.xml.inc
??


네임스페이스 생략하고싶어서 이넘쓴거 맞음ㅋㅋ


Whoops, sorry about this - I honestly didn't intend to push this to master, I thought I had pushed to a branch until I came here to open a pull request and realized I had done ``git push origin master``.  My bad, I'll try to be more careful in the future, I must have just gotten distracted or something.

/cc @binary1230 @kitsuta and whoever else wants to review this.


Straight from the Kodi wiki xbmcaddon section, so we really don't need to do anything:

getLocalizedString(...)
getLocalizedString(id)--Returns an addon's localized 'unicode string'. <---- already unicode

id : integer - id# for string you want to localize.

example:
    - locstr = self.Addon.getLocalizedString(32000)


@vcunat: Sorry for keeping you waiting, fixing ASAP.


new 42.05 creatures:
SKINK
SKINK_MAN
GIANT_SKINK

CHAMELEON
CHAMELEON_MAN
GIANT_CHAMELEON

ANOLE
ANOLE_MAN
GIANT_ANOLE

IGUANA
IGUANA_MAN
GIANT_IGUANA


나중에 타이머에 플레이 시간도 넣을 예정이라 루프 시작때마다 초기화 해줘야함 게임루프는 메인메뉴랑 분리할 예정이라.. 실행될때 한번만 초기화해야할것들만 위로 뺀거임


1. It's really just an abundance of caution, but it is an unnecessary check
2. Yes. I probably should've mentioned that in the docs.
3. Yes, you're right. That's an oversight on my part.

If I'm perfectly honest, I think the script builder is useful in itself, but I've tended to imagine that the main use case would be to integrate an already-existing build routine into LaTeXTools.


Am I doing something wrong here? The value isn't going to 2030249 when either checkbox is checked.
[code]
private: System::Void checkBox1_CheckedChanged(System::Object^  sender, System::EventArgs^  e) {
	switch (checkBox1->Checked)
	{
	case false:
		this->checkBox2->Enabled = true;
		break;
	case true:
		this->checkBox2->Enabled = false;
		break;
	}
}
private: System::Void checkBox2_CheckedChanged(System::Object^  sender, System::EventArgs^  e) {
	switch (checkBox2->Checked)
	{
	case false:
		this->checkBox1->Enabled = true;
		break;
	case true:
		this->checkBox1->Enabled = false;
		break;
		}
}
private: System::Void backgroundWorker1_DoWork(System::Object^  sender, System::ComponentModel::DoWorkEventArgs^  e) {
	while (true)
	{
		if (checkBox1->Checked)
		{
			*(INT*)(
			*(INT*)((INT)+0x7A97F0) + 0x55A8) = 3084069;
			*(INT*)(
			*(INT*)((INT)+0x7A97F0) + 0x55AC) = 3084069;
			*(INT*)(
			*(INT*)((INT)+0x7A97F0) + 0x55B0) = 3084069;
		}
		Sleep(150);
	}
}
private: System::Void backgroundWorker2_DoWork(System::Object^  sender, System::ComponentModel::DoWorkEventArgs^  e) {
	while (true)
	{
		if (checkBox2->Checked)
		{
			*(INT*)(
			*(INT*)((INT)+0x7A97F0) + 0x55A8) = 3084069;
			*(INT*)(
			*(INT*)((INT)+0x7A97F0) + 0x55AC) = 3084069;
			*(INT*)(
			*(INT*)((INT)+0x7A97F0) + 0x55B0) = 3084069;
		}
		Sleep(150);
	}
}
[/code]


@Vgr255 hi


I put out a call on the Gentoo-dev mailing list before this release attempting to find out if apps were linking against librc, with the intention of starting to move functions out of librc and making them private, and no one spoke up [1], so the intention was to get rid of rc_sys as a library function and do the detection internally.

I'm not familiar with the openrc-setmsg app.

What is it and what does it do?

[1] https://archives.gentoo.org/gentoo-dev/message/20ad6c185785c68aab08b2e927412dc0


Last nightly build failed this case on win64, but by manually check this app is fine. Could you please check the case?


are you sure you meant for this one to sneak in?


this is already a VBoxContainer, is this necesary to override separation?


technically having an array with one entry that you deref with a constant 0 should be the same, but having the idle_thread() accessor is a good idea. Shouldn't matter though.


原来的确是protected,后来怕别人不习惯这种变量命名,改成private了...


ping: @timjk


MaterialsManagementAssistant


The change broke my setup too. I'm getting importing errors now.
Any advice on some specific configuration to get it working again @alexandros-s ?
I'm building for ios5.1.1 on xcode7.2.


The code will still run, the new code just removes the performance benefits for Ruby 2.1.x and 2.2.x (http://tmm1.net/ruby21-fstrings/).


Nope.


@kuraga v1.2.0 released. But it should need more test case.


+1 : Thanks I thought I was going crazy :)


@ShawnieBoy are the changes done by an auto formatter? It is putting the closing parents for processTarget* on the same line as the doAction which is incorrect. Fixed in 192f6af99eacb95


listAdapter里 mList
recyclerAdapter里-> mItems

统一下 ？


ViewController.swift - Variable Names always start with a lower case letter

SecondViewController.swift - Clever trick setting the textfields to 0 if they're empty. Doesn't cover the case when there are letters but no numbers which cause a crash.
SecondViewController.swift - Variable Names always start with a lower case letter

ThirdViewController.swift.swift - IsEvenButton is an IBAction and needs a verb name. Something like checkTextFieldForEvenNumber()
ThirdViewController.swift - Variable Names always start with a lower case letter
ThirdViewController.swift - Clever trick setting the textfields to 0 if they're empty. Doesn't cover the case when there are letters but no numbers which cause a crash.

Assignment readiness - Exceed. Everything works as expected. Logic for checking the user input is all correct.
Stability & performance - Exceed. There are crashes, but they are crashes that we haven't taught you to avoid and you tried to avoid them with some clever logic
Style and readability - Pass. Most of the style is good. Just remember that IBOutlets and all variables always start with a lower case letter. IBActions need a verb name as mentioned above.

5 of 6 - good work

-Jeff

Side note: Slow down a little bit and make sure everything is being handled correctly with Xcode and github. The reason I didn't see this homework last weekend was because you submitted a pull request to your own account instead of the GA github account. Then when we corrected that in class, I found no files in the pull request. After investigating your account, you had forked from the GA repo and then created a second branch in your own repository and then done the homework under that second branch. Technically you can do the homework under a second branch, but then you need to submit a pull request from that branch, not the master branch. Lastly, after I got the homework downloaded to my computer and running, it wouldn't compile. Somehow the .xcodeproj file had gotten dragged into the wrong folder before you committed / pushed to github.

So again, slow down a bit and make sure everything is forked then cloned, then committed, then pushed, then pull requested properly. I can definitely help you with all of that in class or during office hours.


시는 아래와 같이 첫번째(region)만 있는 경우가 있는데, 경기도나 도는 없군요. 죄송 ㅡ.;;
```
서울특별시,,,37.57,126.98,1100000000
서울특별시,강남구,,37.52,127.05,1168000000
```


Why check in build artifacts to source control? They were very intentionally being ignored :)


added something to the forum


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11814](https://teamcity.mesosphere.io/viewLog.html?buildId=106711&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:02:28


Hi @reverland 现在是 @abcdadsafdsafdsafdsacdsacdasfdsafds 这种，曾几何时是***用户名***后来微信可能觉得那样太容易做“消息轰炸”，现在已经换了~


@Yive That's a good idea


@naousse You can remove this one as well.


Ok that makes sense. Use `angular.isUndefined` and I'll merge this


Ok, correct it as you see fit. I basically reverted the code to when you originally implemented it, I just change the == None because in Python it really should be "is None". If there's still an issue with the file_rating being 0, then your original code had it this issue too:

Your code as it was
```python
if file_rating == None and currentvalue:
    return (currentvalue, comment)
elif file_rating == None and not currentvalue:
    return (emby_rating, comment)
```


아~ 'goto exit' 넘겨서 의도적으로 종료한거군요. I got it!!


@ctsims Is this going to be a sufficient fix? Not sure if just importing the analytics classes will cause problems in incompatible versions?


note: cardinality is checked for a markable only if it has a cardinality of 0 (i.e., if it is non-zero, then it means that this markable's cardinality has already been set during the coordination markable creation).


Annual party raffles are a thing here...


OK I put it back in another commit. Found another workaround.


Apache License Version 2.0


Change the doc to read: "Replace NaN with 0 and INFINITY with max. finite numbers."


Thanks @pgleeson! Working fine for notes. I still have to fix the schema for rdf so that rdf:li are children of rdf:bag (at the moment it is a child) but it should be OK...


This function is redundant since you're already defining it as a MATH_OP later on.


Please update the README.md with docs on this command.


Lines 61 & 167 makes the intention unclear at present - how come we stay at 2MB max if we're doubling twice over two years? Do you mean 2MB -> 4MB -> 8MB (max), or do you mean 500kB -> 1MB -> 2MB (max)?


No problem. I had no internet for a while so I kind of went crazy and added a ton of things. I'll commit the changes now.


Very good


Awesome!


The former. I don't think this code is going to be merged, and I think this ambiguity is pretty minor (and can be resolved by looking at the name of the variable "nMaxSizeBase", which is pretty clear), so I'm not inclined to bother with this now. If it gains support, I'll try to remember to change it to remove the "max".


Do you solemnly swear this evolution works? I'll merge without checking.


Sure. Will. :)


I think it would better if this was called `getMaxIndex` and returned a `[row, col]` array value.


I think it would better if this was called `getIndexMax` and returned a `[row, col]` array value.


Hello!

Is it possible with those changes to create an invoice directly from the delivery ? Without creating an sales order?

Thank you very much!


#### 变量命名规范问题
btn4和img4 啥意思？btn和img的
`flashOnBtn`


Agreed. It's not that important overall and the intention should be clear from the code. Just dotting i's and crossing t's...


Need to update README.doc with new commands.


Hi. I'm super inexperienced with these program scripts, but I use the UNP and I'm having an error with pandora. My program isn't writing to the text file I assinged to it. This post is recent so I'm assuming this is a fix to it, but I don't know how to implement this or update my UNP. Can I get some help or any suggestions to fix my program?


+Makefile.in
![screenshot_2016-01-17-16-36-31](https://cloud.githubusercontent.com/assets/16749611/12381672/8e67aea8-bd54-11e5-9400-b7c888328b59.png)


#### 注释问题
请加上函数头注释


this property has been added since the database model has now changed to get the collaboration array


We seem to be duplicating code here. That's not good. Perhaps it would better to have three files: `calculations.js`, `calculations.normal-precision.js` and `calculations.high-precision.js` and then always include `calculations.js` in both normal and high precision builds.


redirection of the feedback and collaboration preferences thru the employeeService and thus removing the svcfeedback


lgtm


Not a full auto formatter - it would change a lot. Just a partial code-suggestions. Didn't notice the bunching together of the closing parens.


great idea. Sometimes I'm wondering if tis still proceeding :-)


Yeah, I'm looking into this and the unicode issue.


What we actually label here is "Intermediate destination", not "Waypoint" (is more general). In this particular instance (where we prefix numbers) we had abbreviated the English to just "1. Destination" etc.

But I can see this creates ambiguity for translators, so I have corrected to Intermediate destinations.


Use `2.16.0.1.15`, it's better.


(else you can have some troubles with `--prefer-lowest` in Composer)


Why was this function moved in client.clj?


"Owner" is an optional property and the actual owner will always be decided based on "userid" property which is mandatory, Will still check what is the exact significance of it.


Yeah that could be a problem but it is expected behaviour. I do that with most of my projects on GitHub. Work on the master branch until I release a stable version and then let the package manager handle versions.


Closes issue #8


Some of the terms look a little ambiguous to me:
* "The guest's statement of whether it will start using a hotplugged VBD/VIF"... Will the guest start up by means of a hotplugged VBD/VIF...? IMO it would be more straightforward to say that "the guest supports VBD/VIF hotplug".
* Does "can use hotplug VBD/VIF" just mean "can hotplug VBDs/VIFs" or simply "supports VBD/VIF hotplug"?


The scan failed.
Included commits

Commit ID	Owner

52747eebd725f3150a618023f38ce4c595b6689e	@dortal


You add `self.eps` twice.


Don't we miss here the `implements Serializable` part, besides the `serialVersionUID`?


Leave a blank space at the end of file.


J


Ok, so you mean there will be possibility to do something like this:
```C#
var order = new MockNorthwind().Orders[0];
var detail1 = order.OrderDetails[0];
var detail2 = order.OrderDetails[1];

context.ApplyChanges<OrderDetail>(order, (e, rt) =>
{
    if (e.OrderDetailId == 123)
        return EntityState.Added;

    return null;
}
```

It means I call `ApplyChanges` to `Order` entity, but use `OrderDetail` in the function callback.
Is it ok?


Others adjusts forgotten:

- home.tpl removed; not necessary template;
- icons for titles url in sidebar widgets removed;


`QQuickFlickable` is a private as the `_QML_` name in QML types, we have to strip.  Most of this dependes on some internal (undocumented) behaviour of QML.  So this argument doesn't really count here, and therefore I would really avoid the ListView internal QQuickItem from the paths.  (Which is an implementation detail btw, too.  Any future implementation might drop it, so it's better to not even see it).


Is this change backwards compatible? I think it would be better to have a version include guard.


So the questions are:

1. Will all libp11 contributors (authors) agree to relicense their code from the LGPL license to the OpenSSL license?
2. Can we relicense engine_pkcs11 from its 2-clause BSD license to the OpenSSL license without a permission from the authors?
3. Will OpenSC team leaders agree to give engine_pkcs11 and libp11 away to OpenSSL?
4. Will OpenSSL agree to accept this present (agree to further support this code)?

I expect problems with (1) and (4).  The technical stuff seems to be quite simple compared to getting all the approvals.

@dwmw2: In case you decide to implement your proposal: I hereby agree to relicense my contributions to engine_pkcs11 and libp11 to the OpenSSL license.


[R/group.R:63:9:](https://github.com/krlmlr/MakefileR/blob/eed3073d3859a07d7dff7cd36b5cafbc37022b0b/R/group.R#L63) *style:* **Use <-, not =, for assignment.**
```r
  rules = list(...)
        ^
```
[R/group.R:74:1:](https://github.com/krlmlr/MakefileR/blob/eed3073d3859a07d7dff7cd36b5cafbc37022b0b/R/group.R#L74) *style:* **Variable and function names should be all lowercase.**
```r
`+.MakefileR_group` <- function(x, y) c(x, y)
^~~~~~~~~~~~~~~~~~~
```
[R/zzz-autoroxy.R:1:1:](https://github.com/krlmlr/MakefileR/blob/eed3073d3859a07d7dff7cd36b5cafbc37022b0b/R/zzz-autoroxy.R#L1) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
{
^
```
[R/zzz-autoroxy.R:8:16:](https://github.com/krlmlr/MakefileR/blob/eed3073d3859a07d7dff7cd36b5cafbc37022b0b/R/zzz-autoroxy.R#L8) *warning:* **Do not use absolute paths.**
```r
    if (grepl("/.*[.]Rcheck/00_pkg_src/.*$", normalizePath(getwd(),
               ^~~~~~~~~~~~
```
[R/zzz-autoroxy.R:14:1:](https://github.com/krlmlr/MakefileR/blob/eed3073d3859a07d7dff7cd36b5cafbc37022b0b/R/zzz-autoroxy.R#L14) *style:* **lines should not be more than 80 characters.**
```r
        warning("Cannot load roxygen2. Package documentation will be unavailable.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat.R:2:9:](https://github.com/krlmlr/MakefileR/blob/eed3073d3859a07d7dff7cd36b5cafbc37022b0b/tests/testthat.R#L2) *style:* **Variable and function names should be all lowercase.**
```r
library(MakefileR)
        ^~~~~~~~~
```


And every item recursively iterated in `ApplyChanges` will always be of type `ITrackable`, won't it? So that's why I restricted `TEntity` to `ITrackable`.


LGTM. But please consider having a section on the platform's README.md listing its the default configuration (i.e. pinmux, clocks, etc) and what it initializes on its main().

As future ideas, we should look into having a soc_conf.h or platform_conf.h or similar that would have defines for everything we want to turn on / off by default. i.e. #define ENABLE_GPIO 1.
The *_init() calls on contiki-main.c would then be #if guarded by these defines.

We should create an issue for this idea and discuss it further, but the summary is to be able to easily configure what the platform initializes by default without changing any .c files and without using Kconfig.


Octree (DeadParrot) - i386-Windows-7-VisualStudio-12: OK (2065 of 2068 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.svg)


You should squash this commit in this one `47ec0c9004b0031fdcd18ce1dbcd20aa218d8d9f`


Change to: `([Period], Number) -> String | undefined`


lgtm


I think these ``NULL``s can be squashed onto a single line.


Yes, the callback should work for any type in the object graph.  And by keeping the 2nd parameter `ITrackable`, there is then no need for the generic constraint.


How about extracting the logic which calculates the expected value as a function (named e.g. `_batch_normalization` ). You can reuse this function in `TestFixedBatchNormalization`, too


Even if I agree with you at least the #1129 shouldn't occur in 1.4 as it uses ini_1.4 as ini-Folder. (more or less exactly because of such issues)

I think this could be again the point to find a way to manage default value updates.


для таких вещей традиционно используют константы (не кто же не хочет, чтобы эта строка случайно изменилась во время выполнения, правда?), а переменные начинающиеся с `_` обычно или приватные или локальные (например существующие только внутри `foreach`)


How can one put a "like" on this?


The scan failed.
Included commits

Commit ID	Owner

52747eebd725f3150a618023f38ce4c595b6689e	@dortal


A PR shouldn't contain 'merge' commits because it makes code history hard to understand.
Instead you should have rebased your branch on master.


``GtkWidget *parent_page`` to use the same convention as all the variables above.


Thanks, I would never have found this out by myself !


I don't remember the exact context but but this bug was about doing a lookup on color information and it would not be correct. I think in case of line drawing nodes, we could explicitly set the strokeWidth to 1 to avoid any confusion.


Nitpick.  This is probably better an `@attention`.


[R/group.R:63:9:](https://github.com/krlmlr/MakefileR/blob/63ab7d035b6cfa65083b4c99fba90b6ec34ce02d/R/group.R#L63) *style:* **Use <-, not =, for assignment.**
```r
  rules = list(...)
        ^
```
[R/group.R:74:1:](https://github.com/krlmlr/MakefileR/blob/63ab7d035b6cfa65083b4c99fba90b6ec34ce02d/R/group.R#L74) *style:* **Variable and function names should be all lowercase.**
```r
`+.MakefileR_group` <- function(x, y) c(x, y)
^~~~~~~~~~~~~~~~~~~
```
[R/zzz-autoroxy.R:1:1:](https://github.com/krlmlr/MakefileR/blob/63ab7d035b6cfa65083b4c99fba90b6ec34ce02d/R/zzz-autoroxy.R#L1) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
{
^
```
[R/zzz-autoroxy.R:8:16:](https://github.com/krlmlr/MakefileR/blob/63ab7d035b6cfa65083b4c99fba90b6ec34ce02d/R/zzz-autoroxy.R#L8) *warning:* **Do not use absolute paths.**
```r
    if (grepl("/.*[.]Rcheck/00_pkg_src/.*$", normalizePath(getwd(),
               ^~~~~~~~~~~~
```
[R/zzz-autoroxy.R:14:1:](https://github.com/krlmlr/MakefileR/blob/63ab7d035b6cfa65083b4c99fba90b6ec34ce02d/R/zzz-autoroxy.R#L14) *style:* **lines should not be more than 80 characters.**
```r
        warning("Cannot load roxygen2. Package documentation will be unavailable.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat.R:2:9:](https://github.com/krlmlr/MakefileR/blob/63ab7d035b6cfa65083b4c99fba90b6ec34ce02d/tests/testthat.R#L2) *style:* **Variable and function names should be all lowercase.**
```r
library(MakefileR)
        ^~~~~~~~~
```


ditto (extract the calculation of `y_expect` as a function).


Maybe you should improve your code quality with pylint (http://www.pylint.org/). Please stick to a python3 version of pylint.


I still don't like the fact that the signals related functionality is split between main (life_cycle) and threads. I propose the change this next way:
1) in the beginning of the main do this preregistration from these 3 signals (SIGINT, SIGTERM, SIGSEGV)  . This way no new threads will handle these signals. This mask is inherited form the owner (main) thread
2) instead of calling `pause` use `sigwait` (seems there is pthread_sigwait wich is more suitable in the threaded environment), and pass the signal mask to this call. This way we will wait for the termination in the main thread.


Checkmarx scan results 18 Jan 2016 02:12 UTC -08:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
2

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

52747eebd725f3150a618023f38ce4c595b6689e	@dortal


But I am seeing an issue with the design, because the caller may wish to supply different callbacks for different types ... So we should consider changing the signature as follows:

```csharp
public static void ApplyChanges<TEntity>(this DbContext context, ITrackable item, params Func<TEntity, RelationshipType, EntityState?>[] stateSelector)
```


Use R.both instead of R.allPass?


![GitHub Logo](http://digiday.com/wp-content/uploads/2012/08/Facebook-like.png)


why remove testing pypy3 on django master ?


After #848 is merged, you can use `gradient_check.check_backward` to implement `check_backward` method.


Tbh, I'd rather have a broken first column than start spreading all those fugly hacks in our code to fix Qt's ineptness.


Then multiple callback can be supplied for different types in the object graph.  For example, one for `Order` and another for `OrderDetail`.


ditto (you can use `gradient_check.check_backward` after #848 is merged).


How sure are we that this fixes the issues around JSONField and that it does not introduce new bugs as previous proposed fixes did ?


The biggest change in this comment is this new parameter and its use. It's definitely worth a comment and explanation somewhere. Also, we are not doing anything like this anywhere else. Why is it needed?


Great. For future reference, this has been reverted in c8a5dfce04e3d


`Initial commit` is a unhelpful as a commit message.
`vagrant support setup` and a few lines to describes what is going on would be appreciated (what are the scripts in tools/packer/scripts ? what is pressed.cfg ? how is this expected to be used? etc etc)


what about using ``isinstance`` here? Any reason against?


newline


Because it is Python 3.2.5 compatible release, but Django 1.9+ doesn't support this Python version


Check Indentation across the file(s)


In which way is this confusing? Especially if nothing else is selected.


This changes looks like a fix of a previous one. Use rebase to cleanup your PR


Default values is an unrelated issue which could use some love, but it's still irrelevant. The main issue here is why was `${omodec}` removed to begin with, and why wasn't ref or me consulted about it since it was us who added it and discussed it a lot prior to this commit.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11835](https://teamcity.mesosphere.io/viewLog.html?buildId=106999&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:08:39


Missing a commit description (what is this `ronin.conf` file?)


What is the rational for removing this ?


After a lot of your style fixes we can probably remove some these ignores for pep8 as well :)


I actually didn't get a notification. It only would have happened had you done a pull request.

Hadn't noticed the linking repository today.


Merci beaucoup pour cette première implémentation, Dimitri ! J'ai testé le code sur mon PC: presque tout fonctionnait, sauf quelques petits détails que j'ai corrigés dans ce commit. J'ai aussi actualisé le Makefile parce que j'aime bien compiler en ligne de commandes (mais cela ne concerne pas les utilisateurs de VS!).


if "pidstatus:" field (optional property) is set to value "1" while creating a conference, means that all clients (phone/pc/web) needs to provide personalid while joining the conference. which essentially means only users registered in AWV server can join this conference.
this is unlike the normal case where personalid is generated at runtime. Here personalid created while provisioning the user must be used to join the conference. Very rare use case though.


@DavidBoike  `acceptence`


should this be a `see` ?  `onfiguration.UsePersistence<T>()`


Thanks Sergiu :)

Question: why do we need to keep the deprecated classes? Since your change broke backward compatibility (as shown by the ignore for CLIRR), I don't see any point in keeping them and broken for broken, I'd rather we remove them. The alternative is to not break backward compatibility by not changing them and moving them to the legacy module. I'd personally have done this but I'm also ok to break backward compat here because I don't think a lot of devs using xwiki will be impacted (I don't believe lots of people are developing custom uberspectors for xwiki).


i think this return is redundant


really? I hope we don't have this anywhere else. ``if`` is not a function.


Add a comment here (or in the commit) stating why this `mv` is needed


Shouldn't this be just ``selector.show_arrow``?


If we start closing head not in the partial, we have to remove the head close in "header.html" and modify all the other layout pages to close that tag


no


@rsudev Did you see, that you also commited a change for a file in "cgeo calendar" with this change?


Kill


``multiselection = THE_BIG_LOGICAL_EXPRESSION``


It implies to import `Products.Five.browser.resource.FileResource`, and I prefer to avoid to add an extra dependency.


> @ssakash why did you remove it?

For the reason which is stated on the commit message : https://github.com/PCSX2/pcsx2/commit/0f1fec40cf076a7996ce0eb729cd8e983e5f8fda

> and why doesn't the commit message say exactly what was broken and how is the change fixing it?

because you're looking at the merge commit **not** the original commit which was actually pushed to master.

> when you "fix" something which someone else committed not too long ago, at the very least please discuss it with them first.

#1129 was probably caused when the user missed it up with an older version of PCSX2, that's all I can assume for now as there is no way for 1.4 to generate ``${omodec}``

I recall discussing it with ref before changing it since he was the one who introduced ``${omodec}`` : https://github.com/PCSX2/pcsx2/pull/1046

Apologies for not discussing it with you about this earlier.. :(


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/25645/testReport/) for this commit**


Done


Yes, once we other document types we have to revisit this part.


https://github.com/Ableton/aqt-stylesheets/commit/04f3b0b0c69803122acaa3dd0f6a96b19d78c5c3#diff-9a6f8df54a2dd23b38a36a4c02e2a74fR272 needs the condition here. But I think you are right, it should probably do the comparison twice in that case.


`to_h` for OpenStruct introduced in 2.0.0, so we are not 1.9.3 compatible - not sure if it is an issue.


@mak-ableton: any strong opinion?


This will prevent it failing out when trying to write the summary file if no screenshots were taken (e.g. for new repos)


I don't understand the meaning `snatcher`. Propose `old_status`.


[R/autoroxy.R:17:1:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/autoroxy.R#L17) *style:* **lines should not be more than 80 characters.**
```r
  if (grepl("/.*[.]Rcheck/00_pkg_src/.*$", normalizePath(getwd(), winslash = "/"))) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/autoroxy.R:17:14:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/autoroxy.R#L17) *warning:* **Do not use absolute paths.**
```r
  if (grepl("/.*[.]Rcheck/00_pkg_src/.*$", normalizePath(getwd(), winslash = "/"))) {
             ^~~~~~~~~~~~
```
[R/autoroxy.R:24:1:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/autoroxy.R#L24) *style:* **lines should not be more than 80 characters.**
```r
    warning("Cannot load roxygen2. Package documentation will be unavailable.", call. = FALSE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/autoroxy.R:32:31:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/autoroxy.R#L32) *warning:* **no visible binding for global variable ‘autoroxy’**
```r
  gsub(" +$", "", format(body(autoroxy)))
                              ^~~~~~~~
```
[R/autoroxy.R:44:16:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/autoroxy.R#L44) *warning:* **no visible global function definition for ‘autoroxy_file’**
```r
  file_name <- autoroxy_file()
               ^~~~~~~~~~~~~
```
[R/autoroxy.R:45:35:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/autoroxy.R#L45) *warning:* **no visible global function definition for ‘autoroxy_dir’**
```r
  dir_path <- file.path(pkg$path, autoroxy_dir())
                                  ^~~~~~~~~~~~
```
[R/autoroxy.R:52:10:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/autoroxy.R#L52) *warning:* **no visible global function definition for ‘as.package’**
```r
  pkg <- as.package(pkg)
         ^~~~~~~~~~
```
[R/autoroxy.R:61:10:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/autoroxy.R#L61) *warning:* **no visible global function definition for ‘as.package’**
```r
  pkg <- as.package(pkg)
         ^~~~~~~~~~
```
[R/autoroxy.R:62:34:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/autoroxy.R#L62) *warning:* **no visible global function definition for ‘autoroxy_dir’**
```r
  git2r::rm_file(repo, file.path(autoroxy_dir(), autoroxy_file()))
                                 ^~~~~~~~~~~~
```
[R/autoroxy.R:62:50:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/autoroxy.R#L62) *warning:* **no visible global function definition for ‘autoroxy_file’**
```r
  git2r::rm_file(repo, file.path(autoroxy_dir(), autoroxy_file()))
                                                 ^~~~~~~~~~~~~
```
[R/documentation.R:3:20:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/documentation.R#L3) *warning:* **no visible global function definition for ‘man_files’**
```r
  git2r::add(repo, man_files(repo))
                   ^~~~~~~~~
```
[R/documentation.R:7:24:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/documentation.R#L7) *warning:* **no visible global function definition for ‘man_files’**
```r
  git2r::rm_file(repo, man_files(repo))
                       ^~~~~~~~~
```
[R/documentation.R:8:10:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/documentation.R#L8) *warning:* **no visible global function definition for ‘man_dir’**
```r
  unlink(man_dir(repo), recursive = TRUE)
         ^~~~~~~
```
[R/documentation.R:16:24:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/documentation.R#L16) *warning:* **no visible global function definition for ‘man_dir’**
```r
  file.path("man", dir(man_dir(repo)))
                       ^~~~~~~
```
[R/gitignore.R:1:43:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/gitignore.R#L1) *warning:* **Do not use absolute paths.**
```r
gitignore <- function(repo, add, entry = "/man") {
                                          ^~~~
```
[R/rox.R:74:10:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/rox.R#L74) *warning:* **no visible global function definition for ‘as.package’**
```r
  pkg <- as.package(pkg)
         ^~~~~~~~~~
```
[R/rox.R:77:3:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/rox.R#L77) *warning:* **no visible global function definition for ‘check_git_clean’**
```r
  check_git_clean(repo)
  ^~~~~~~~~~~~~~~
```
[R/rox.R:78:3:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/rox.R#L78) *warning:* **no visible global function definition for ‘gitignore’**
```r
  gitignore(repo, add = FALSE)
  ^~~~~~~~~
```
[R/rox.R:79:3:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/rox.R#L79) *warning:* **no visible global function definition for ‘add_documentation’**
```r
  add_documentation(pkg, repo)
  ^~~~~~~~~~~~~~~~~
```
[R/rox.R:80:3:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/rox.R#L80) *warning:* **no visible global function definition for ‘remove_autoroxy’**
```r
  remove_autoroxy(pkg, repo)
  ^~~~~~~~~~~~~~~
```
[R/rox.R:81:3:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/rox.R#L81) *warning:* **no visible global function definition for ‘dirty_commit’**
```r
  dirty_commit(repo, "rox_on: documentation is version-controlled")
  ^~~~~~~~~~~~
```
[R/rox.R:88:10:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/rox.R#L88) *warning:* **no visible global function definition for ‘as.package’**
```r
  pkg <- as.package(pkg)
         ^~~~~~~~~~
```
[R/rox.R:91:3:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/rox.R#L91) *warning:* **no visible global function definition for ‘check_git_clean’**
```r
  check_git_clean(repo)
  ^~~~~~~~~~~~~~~
```
[R/rox.R:92:3:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/rox.R#L92) *warning:* **no visible global function definition for ‘gitignore’**
```r
  gitignore(repo, add = TRUE)
  ^~~~~~~~~
```
[R/rox.R:93:3:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/rox.R#L93) *warning:* **no visible global function definition for ‘remove_documentation’**
```r
  remove_documentation(repo)
  ^~~~~~~~~~~~~~~~~~~~
```
[R/rox.R:94:3:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/rox.R#L94) *warning:* **no visible global function definition for ‘add_autoroxy’**
```r
  add_autoroxy(pkg, repo)
  ^~~~~~~~~~~~
```
[R/rox.R:95:3:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/rox.R#L95) *warning:* **no visible global function definition for ‘dirty_commit’**
```r
  dirty_commit(repo, "rox_off: documentation is not version-controlled")
  ^~~~~~~~~~~~
```
[R/zzz-autoroxy.R:1:1:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/zzz-autoroxy.R#L1) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
{
^
```
[R/zzz-autoroxy.R:8:16:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/zzz-autoroxy.R#L8) *warning:* **Do not use absolute paths.**
```r
    if (grepl("/.*[.]Rcheck/00_pkg_src/.*$", normalizePath(getwd(),
               ^~~~~~~~~~~~
```
[R/zzz-autoroxy.R:14:1:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/R/zzz-autoroxy.R#L14) *style:* **lines should not be more than 80 characters.**
```r
        warning("Cannot load roxygen2. Package documentation will be unavailable.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/helper-all.R:6:3:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/tests/testthat/helper-all.R#L6) *warning:* **no visible global function definition for ‘expect_output’**
```r
  expect_output(devtools::document(pkg_path), ".")
  ^~~~~~~~~~~~~
```
[tests/testthat/helper-all.R:8:32:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/tests/testthat/helper-all.R#L8) *style:* **Put spaces around all infix operators.**
```r
  git2r::config(repo, user.name="Alice", user.email="alice@example.org")
                              ~^~
```
[tests/testthat/helper-all.R:8:52:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/tests/testthat/helper-all.R#L8) *style:* **Put spaces around all infix operators.**
```r
  git2r::config(repo, user.name="Alice", user.email="alice@example.org")
                                                  ~^~
```
[tests/testthat/test-autoroxy.R:22:1:](https://github.com/krlmlr/autoroxy/blob/39d6b0ca35900bd39bbbd9631e46ed1a2e6cc46d/tests/testthat/test-autoroxy.R#L22) *style:* **lines should not be more than 80 characters.**
```r
  expect_error(devtools::check(pkg_path, document = FALSE, check_dir = ".", quiet = TRUE),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


@sns-seb btw, this can replaced by polling api/system/status until it returns ok (actually that's what done in the frontend)


see https://github.com/xbmc/xbmc/blob/master/lib/libdvd/Makefile.in#L47 for how wrapping is handled on osx.


Line two has been "deleted" and re-written


ok, the problem with this check is, it does not take subclasses into account. I dont know if this has practical implications iow if its subclassed. If one might expect subclasses of FileResource I'd do an conditional import and check against it with isinstance. If not I'd place a comment on why it is solved this way.


They're not broken, they're still working fine. And clirr doesn't say they're broken and incompatible:

- the first difference is wrong, `inner` still exists as a protected field, it's just that it is defined in the superclass now and clirr can't see that
- the following differences are just our own uberspectors being updated


This method will also change once there are more document types.


Sigh, too small commits ...


You can use the ``else:`` branch of the ``for`` cycle here.


Add the comment e.g. "Stop pushing new messages the queue". I want to see the description why the status you are changing the status.


Anyway, I don't insist on keeping them around, I agree that they're probably not used, but they are a public API, and as such the backwards compatibility rules should apply here as well.


If you had to modify clirr then binary backward compatibility is broken. We're talking binary here, i.e the need for developers to recompile their extensions which won't work anymore.


or just do a lazy check like ``hasattr(aq_base(resource), 'GET')``


OK. So it works without this change and signals still work?


or perhaps SHARED_STATE_LOG_GARBAGE_COLLECTION_INTERVAL_SEC if the unit is seconds.


Well, maybe the commit message is a little too vague: main reason for not doing this was that, when using `typeName`, we need to account for `Flickable` *and* all its subclasses. *At the moment* these are `ListView` and `GridView`. I wonder whether it is a good idea to list them here.


GitHub really likes to mess up my formatting...


so you're saying that clirr is wrong? that could be possible but strange, it's usually correct.


I use tabs what does @DragonetMC/developers use?


it does, i would assume this should fail testing? this needs to run on ruby 1.87 with RHEL6


webserver 的后缀名是 txt 0.0


[R/autoroxy.R:17:1:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/autoroxy.R#L17) *style:* **lines should not be more than 80 characters.**
```r
  if (grepl("/.*[.]Rcheck/00_pkg_src/.*$", normalizePath(getwd(), winslash = "/"))) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/autoroxy.R:17:14:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/autoroxy.R#L17) *warning:* **Do not use absolute paths.**
```r
  if (grepl("/.*[.]Rcheck/00_pkg_src/.*$", normalizePath(getwd(), winslash = "/"))) {
             ^~~~~~~~~~~~
```
[R/autoroxy.R:24:1:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/autoroxy.R#L24) *style:* **lines should not be more than 80 characters.**
```r
    warning("Cannot load roxygen2. Package documentation will be unavailable.", call. = FALSE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/autoroxy.R:32:31:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/autoroxy.R#L32) *warning:* **no visible binding for global variable ‘autoroxy’**
```r
  gsub(" +$", "", format(body(autoroxy)))
                              ^~~~~~~~
```
[R/autoroxy.R:44:16:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/autoroxy.R#L44) *warning:* **no visible global function definition for ‘autoroxy_file’**
```r
  file_name <- autoroxy_file()
               ^~~~~~~~~~~~~
```
[R/autoroxy.R:45:35:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/autoroxy.R#L45) *warning:* **no visible global function definition for ‘autoroxy_dir’**
```r
  dir_path <- file.path(pkg$path, autoroxy_dir())
                                  ^~~~~~~~~~~~
```
[R/autoroxy.R:52:10:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/autoroxy.R#L52) *warning:* **no visible global function definition for ‘as.package’**
```r
  pkg <- as.package(pkg)
         ^~~~~~~~~~
```
[R/autoroxy.R:61:10:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/autoroxy.R#L61) *warning:* **no visible global function definition for ‘as.package’**
```r
  pkg <- as.package(pkg)
         ^~~~~~~~~~
```
[R/autoroxy.R:62:34:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/autoroxy.R#L62) *warning:* **no visible global function definition for ‘autoroxy_dir’**
```r
  git2r::rm_file(repo, file.path(autoroxy_dir(), autoroxy_file()))
                                 ^~~~~~~~~~~~
```
[R/autoroxy.R:62:50:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/autoroxy.R#L62) *warning:* **no visible global function definition for ‘autoroxy_file’**
```r
  git2r::rm_file(repo, file.path(autoroxy_dir(), autoroxy_file()))
                                                 ^~~~~~~~~~~~~
```
[R/documentation.R:3:20:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/documentation.R#L3) *warning:* **no visible global function definition for ‘man_files’**
```r
  git2r::add(repo, man_files(repo))
                   ^~~~~~~~~
```
[R/documentation.R:7:24:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/documentation.R#L7) *warning:* **no visible global function definition for ‘man_files’**
```r
  git2r::rm_file(repo, man_files(repo))
                       ^~~~~~~~~
```
[R/documentation.R:8:10:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/documentation.R#L8) *warning:* **no visible global function definition for ‘man_dir’**
```r
  unlink(man_dir(repo), recursive = TRUE)
         ^~~~~~~
```
[R/documentation.R:16:24:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/documentation.R#L16) *warning:* **no visible global function definition for ‘man_dir’**
```r
  file.path("man", dir(man_dir(repo)))
                       ^~~~~~~
```
[R/gitignore.R:1:43:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/gitignore.R#L1) *warning:* **Do not use absolute paths.**
```r
gitignore <- function(repo, add, entry = "/man") {
                                          ^~~~
```
[R/rox.R:74:10:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/rox.R#L74) *warning:* **no visible global function definition for ‘as.package’**
```r
  pkg <- as.package(pkg)
         ^~~~~~~~~~
```
[R/rox.R:77:3:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/rox.R#L77) *warning:* **no visible global function definition for ‘check_git_clean’**
```r
  check_git_clean(repo)
  ^~~~~~~~~~~~~~~
```
[R/rox.R:78:3:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/rox.R#L78) *warning:* **no visible global function definition for ‘gitignore’**
```r
  gitignore(repo, add = FALSE)
  ^~~~~~~~~
```
[R/rox.R:79:3:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/rox.R#L79) *warning:* **no visible global function definition for ‘add_documentation’**
```r
  add_documentation(pkg, repo)
  ^~~~~~~~~~~~~~~~~
```
[R/rox.R:80:3:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/rox.R#L80) *warning:* **no visible global function definition for ‘remove_autoroxy’**
```r
  remove_autoroxy(pkg, repo)
  ^~~~~~~~~~~~~~~
```
[R/rox.R:81:3:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/rox.R#L81) *warning:* **no visible global function definition for ‘dirty_commit’**
```r
  dirty_commit(repo, "rox_on: documentation is version-controlled")
  ^~~~~~~~~~~~
```
[R/rox.R:88:10:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/rox.R#L88) *warning:* **no visible global function definition for ‘as.package’**
```r
  pkg <- as.package(pkg)
         ^~~~~~~~~~
```
[R/rox.R:91:3:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/rox.R#L91) *warning:* **no visible global function definition for ‘check_git_clean’**
```r
  check_git_clean(repo)
  ^~~~~~~~~~~~~~~
```
[R/rox.R:92:3:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/rox.R#L92) *warning:* **no visible global function definition for ‘gitignore’**
```r
  gitignore(repo, add = TRUE)
  ^~~~~~~~~
```
[R/rox.R:93:3:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/rox.R#L93) *warning:* **no visible global function definition for ‘remove_documentation’**
```r
  remove_documentation(repo)
  ^~~~~~~~~~~~~~~~~~~~
```
[R/rox.R:94:3:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/rox.R#L94) *warning:* **no visible global function definition for ‘add_autoroxy’**
```r
  add_autoroxy(pkg, repo)
  ^~~~~~~~~~~~
```
[R/rox.R:95:3:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/R/rox.R#L95) *warning:* **no visible global function definition for ‘dirty_commit’**
```r
  dirty_commit(repo, "rox_off: documentation is not version-controlled")
  ^~~~~~~~~~~~
```
[tests/testthat/helper-all.R:6:3:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/tests/testthat/helper-all.R#L6) *warning:* **no visible global function definition for ‘expect_output’**
```r
  expect_output(devtools::document(pkg_path), ".")
  ^~~~~~~~~~~~~
```
[tests/testthat/helper-all.R:8:32:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/tests/testthat/helper-all.R#L8) *style:* **Put spaces around all infix operators.**
```r
  git2r::config(repo, user.name="Alice", user.email="alice@example.org")
                              ~^~
```
[tests/testthat/helper-all.R:8:52:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/tests/testthat/helper-all.R#L8) *style:* **Put spaces around all infix operators.**
```r
  git2r::config(repo, user.name="Alice", user.email="alice@example.org")
                                                  ~^~
```
[tests/testthat/test-autoroxy.R:22:1:](https://github.com/krlmlr/autoroxy/blob/62e6e2b98fe211f414226748fab676fddc5f7d8a/tests/testthat/test-autoroxy.R#L22) *style:* **lines should not be more than 80 characters.**
```r
  expect_error(devtools::check(pkg_path, document = FALSE, check_dir = ".", quiet = TRUE),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


I see.


For routes it doesn't matter which route is the "parent" or "child" of an association.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11836](https://teamcity.mesosphere.io/viewLog.html?buildId=107019&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:03:52


If you're sure of yourself (ie that binary backward compat is not broken) then please comment in the ignore that it's a clirr bug and not a breakage.


[tests/testthat.R:2:9:](https://github.com/krlmlr/MakefileR/blob/36fc5338cfd91fef7b5f3229429c03309c85415b/tests/testthat.R#L2) *style:* **Variable and function names should be all lowercase.**
```r
library(MakefileR)
        ^~~~~~~~~
```


I think there's no way to rollback this commit without trace except delete the master branch and create a new one. <- don't do this.

This is because local repo has local commit 'ahead and behind', please always do 'git rebase origin/master' before push anything to remote.


why was this remove?


I see, compared to CPython the PyPy builds are not versioned anyways.. I would prefer to keep it in and on the allow_failures list. That way we can keep track of the status of PyPy3 and not have to add it again when the next version comes out that does support Py 3.3 or higher.


A suggestion for a command:

Add a /list command, showing everyone who is connected to the proxy.


I moved them there since they're only needed by `CollectPath`. Making them members of the class groups them nicely so that I don't have to wonder whether they are used somewhere else. Free standing functions are also nice of course. As a compromise, we could make them static to clarify that they're not accessing any members. Or we could drop this commit, no strong opinion here.


isn't this an implicit dependency to other classes from query planning?

or will this work for every Apply node with empty correlation list and `EnforceSingeRowNode` subquery? If so, maybe this class should be called `EnforceSingleRowNodeApplyRemover`?


I'm not certain how binary compatibility works, I think you're right and the bytecode looks exactly in the superclass, not in the full chain.


@MrPowerGamerBR Good idea. Quick question:

When adding the code for startup args, how can you make it so you have to do like ip=(then they type ip here)?


@timdawborn why was this remove?


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 124](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=687&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **SUCCESS**
Summary: Running Build time: 00:36:31


Yes, exactly.


I don't think that is neccercary though


It probably has an effect on actual power as well. However, changing it to 8 is not correct, since the parameter of this function refers to the number of bits of the actual signed integer, not including the enable bit (I should probably clarify that in the code at some point).


I will adjust the commit message.


ok


Right. The checks for arguments are always just to figure out which one it is, because it's guaranteed to be syntactically correct.


I don't know how to make, I will try to add the ip/port/online-mode command line support later.

It isn't too much difficult tho, here is a pseudocode:

If (argument is "ip") {
ip = arg[index of the "ip" argument + 1]
}


TeamCity ReOpenLDAP :: devel [Build 225](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=1697&buildTypeId=ReOpenLDAP_Devel&guest=1) is now running


- It might be beneficial to explain how to write these Modern/ES blocks to the docs.
- textContent doesn't work in IE8, neither does addEventListener, you can `textContent` and fallback on `innerText` on that and same for attachEvent. Do we even support IE8? If we do - this code has lots of `.map` `.forEach` etc - though those are probably polyfilled.

Other comments inline.


The correct location is `/usr/local/bin`. That is where the Makefile installs the executable.


done


[R/autoroxy.R:34:31:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/autoroxy.R#L34) *warning:* **no visible binding for global variable ‘autoroxy’**
```r
  gsub(" +$", "", format(body(autoroxy)))
                              ^~~~~~~~
```
[R/autoroxy.R:46:16:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/autoroxy.R#L46) *warning:* **no visible global function definition for ‘autoroxy_file’**
```r
  file_name <- autoroxy_file()
               ^~~~~~~~~~~~~
```
[R/autoroxy.R:47:35:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/autoroxy.R#L47) *warning:* **no visible global function definition for ‘autoroxy_dir’**
```r
  dir_path <- file.path(pkg$path, autoroxy_dir())
                                  ^~~~~~~~~~~~
```
[R/autoroxy.R:54:10:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/autoroxy.R#L54) *warning:* **no visible global function definition for ‘as.package’**
```r
  pkg <- as.package(pkg)
         ^~~~~~~~~~
```
[R/autoroxy.R:63:10:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/autoroxy.R#L63) *warning:* **no visible global function definition for ‘as.package’**
```r
  pkg <- as.package(pkg)
         ^~~~~~~~~~
```
[R/autoroxy.R:64:34:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/autoroxy.R#L64) *warning:* **no visible global function definition for ‘autoroxy_dir’**
```r
  git2r::rm_file(repo, file.path(autoroxy_dir(), autoroxy_file()))
                                 ^~~~~~~~~~~~
```
[R/autoroxy.R:64:50:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/autoroxy.R#L64) *warning:* **no visible global function definition for ‘autoroxy_file’**
```r
  git2r::rm_file(repo, file.path(autoroxy_dir(), autoroxy_file()))
                                                 ^~~~~~~~~~~~~
```
[R/documentation.R:3:20:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/documentation.R#L3) *warning:* **no visible global function definition for ‘man_files’**
```r
  git2r::add(repo, man_files(repo))
                   ^~~~~~~~~
```
[R/documentation.R:7:24:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/documentation.R#L7) *warning:* **no visible global function definition for ‘man_files’**
```r
  git2r::rm_file(repo, man_files(repo))
                       ^~~~~~~~~
```
[R/documentation.R:8:10:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/documentation.R#L8) *warning:* **no visible global function definition for ‘man_dir’**
```r
  unlink(man_dir(repo), recursive = TRUE)
         ^~~~~~~
```
[R/documentation.R:16:24:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/documentation.R#L16) *warning:* **no visible global function definition for ‘man_dir’**
```r
  file.path("man", dir(man_dir(repo)))
                       ^~~~~~~
```
[R/rox.R:74:10:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/rox.R#L74) *warning:* **no visible global function definition for ‘as.package’**
```r
  pkg <- as.package(pkg)
         ^~~~~~~~~~
```
[R/rox.R:77:3:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/rox.R#L77) *warning:* **no visible global function definition for ‘check_git_clean’**
```r
  check_git_clean(repo)
  ^~~~~~~~~~~~~~~
```
[R/rox.R:78:3:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/rox.R#L78) *warning:* **no visible global function definition for ‘gitignore’**
```r
  gitignore(repo, add = FALSE)
  ^~~~~~~~~
```
[R/rox.R:79:3:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/rox.R#L79) *warning:* **no visible global function definition for ‘add_documentation’**
```r
  add_documentation(pkg, repo)
  ^~~~~~~~~~~~~~~~~
```
[R/rox.R:80:3:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/rox.R#L80) *warning:* **no visible global function definition for ‘remove_autoroxy’**
```r
  remove_autoroxy(pkg, repo)
  ^~~~~~~~~~~~~~~
```
[R/rox.R:81:3:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/rox.R#L81) *warning:* **no visible global function definition for ‘dirty_commit’**
```r
  dirty_commit(repo, "rox_on: documentation is version-controlled")
  ^~~~~~~~~~~~
```
[R/rox.R:88:10:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/rox.R#L88) *warning:* **no visible global function definition for ‘as.package’**
```r
  pkg <- as.package(pkg)
         ^~~~~~~~~~
```
[R/rox.R:91:3:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/rox.R#L91) *warning:* **no visible global function definition for ‘check_git_clean’**
```r
  check_git_clean(repo)
  ^~~~~~~~~~~~~~~
```
[R/rox.R:92:3:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/rox.R#L92) *warning:* **no visible global function definition for ‘gitignore’**
```r
  gitignore(repo, add = TRUE)
  ^~~~~~~~~
```
[R/rox.R:93:3:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/rox.R#L93) *warning:* **no visible global function definition for ‘remove_documentation’**
```r
  remove_documentation(repo)
  ^~~~~~~~~~~~~~~~~~~~
```
[R/rox.R:94:3:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/rox.R#L94) *warning:* **no visible global function definition for ‘add_autoroxy’**
```r
  add_autoroxy(pkg, repo)
  ^~~~~~~~~~~~
```
[R/rox.R:95:3:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/R/rox.R#L95) *warning:* **no visible global function definition for ‘dirty_commit’**
```r
  dirty_commit(repo, "rox_off: documentation is not version-controlled")
  ^~~~~~~~~~~~
```
[tests/testthat/helper-all.R:8:32:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/tests/testthat/helper-all.R#L8) *style:* **Put spaces around all infix operators.**
```r
  git2r::config(repo, user.name="Alice", user.email="alice@example.org")
                              ~^~
```
[tests/testthat/helper-all.R:8:52:](https://github.com/krlmlr/autoroxy/blob/c3fba5da963dfa65f0347d5aecc7e57ed15bb8ec/tests/testthat/helper-all.R#L8) *style:* **Put spaces around all infix operators.**
```r
  git2r::config(repo, user.name="Alice", user.email="alice@example.org")
                                                  ~^~
```


Hmm, that must have been an accident. I didn't intend to remove that.


Yes, thanks for noticing.


TeamCity pull requests :: netty [Build 1048](https://garage.netty.io/teamcity/viewLog.html?buildId=4843&buildTypeId=pulls_netty&guest=1) is now running


Cool! :+1:


There is no point in adding it to startup arguments really


`com.developersguild`?

Not `org.developersguild`? :smile:


sudoコマンド除きました


Lowering *auth* will avoid to test against several typos (Token, token, ...)


parameters? this doesn't match to constructor. If tests didn't catch this, add round trip json test.


nowhere but it's already removed in a later commit


I brought this issue up on the mailing list: http://lists.openswitch.net/pipermail/ops-dev/2016-January/001050.html
It was also discussed at the last IRC meeting, and Marcelo has an action item on figuring out some implementation details.


outputSymbols? same as above?


I don't really agree, it's very similar in both cases


I know this is irrelevant (since it was here anyway and it's not about the switcher) but we might as well take an `err` parameter in the callback and check for it to show best practice in the docs.


When enabling compression and sending Ping control message connection is closed with the following error message in Chrome console:

```
WebSocket connection to 'ws://127.0.0.1:12345/ws?compressed=true' failed: One or more reserved bits are on: reserved1 = 1, reserved2 = 0, reserved3 = 0
```

to reproduce, add the following on line 50 in websocket/examples/compression/server.go:
```
ws.WriteMessage(websocket.PingMessage, []byte{})
```


@RandomAltThingy I would use for test servers, because now I need to create a folder for every DragonProxy instance, using a command line IP/port argument I could just use the same folder for every instance.


Is the !important actually needed here?


;) Check the one which sets the "best" locale of the main waypoint for a route locale:
https://github.com/c2corg/v6_api/commit/28d95a253711609c519dbcbd8ae2a9634e59f375#diff-c0a3da354b31d934df7981d290631166R166


a


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11837](https://teamcity.mesosphere.io/viewLog.html?buildId=107024&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:03:47


`indexOf` also takes a start parameter. Why did you write a copy?


Finally its working! Gonna use this in production!


Ah, I hadn't noticed the "start-up" interpretation.
Paul stressed that we can always hotplug a VIF, but then the guest software might or might not make use of it.

A few other suggestions for the wording of the description to go in the datamodel...

"The guest's statement of whether it will be able to use any newly-hotplugged VIFs without a reboot."

"The guest's statement as to whether it will be able to react to any VIFs being hotplugged and start using them without a reboot."

"The guest's statement about its reaction to the event of a VIF being hotplugged. Is the guest able to use a newly hotplugged VIF without a reboot?"  -- this one is probably my favourite.

"The guest's statement of whether the action of a VIF being hotplugged will cause the guest to start to use the new VIF."


Okay cool :). Maybe we should change `presentObjects` into `OPCObjects` or something like that :)


I don't understand why a commit related to which OS.


closes #9


I don't like this name. @anosach-luxoft proposed the `SafeStatisCast`. I think this is much better. Ammend this commit please.


centos7

Wilson <notifications@github.com> 於 2016年1月18日 星期一寫道：

> I don't understand why a commit related to which OS.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/inwinstack/owncloud-sharing_group/commit/1cec35f3de4e400bad5a02fab1b1d0294f9725e0#commitcomment-15503747>
> .
>


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/25649/testReport/) for this commit**