[R/feature_ignore_singletons.R:39:15:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/feature_ignore_singletons.R#L39) *style:* **Commas should never have a space before.**
```r
    segsites[ , !is_singleton]
             ~^
```
[R/feature_ignore_singletons.R:50:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/feature_ignore_singletons.R#L50) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_msms_arg.ign_singletons <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_ignore_singletons.R:54:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/feature_ignore_singletons.R#L54) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_scrm_arg.ign_singletons <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_ignore_singletons.R:58:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/feature_ignore_singletons.R#L58) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_seqgen_arg.ign_singletons <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_mutation.R:140:9:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/feature_mutation.R#L140) *style:* **Commented code should be removed.**
```r
#       model <- addFeature(model, "gamma.categories", parameter=categories.number)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_mutation.R:143:7:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/feature_mutation.R#L143) *style:* **Commented code should be removed.**
```r
#     return(model)
      ^~~~~~~~~~~~~
```
[R/feature_mutation.R:152:5:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/feature_mutation.R#L152) *style:* **Commented code should be removed.**
```r
#   model <- addFeature(model, 'mutation', parameter = middle_rate, group = group)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_recombination.R:47:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/feature_recombination.R#L47) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_seqgen_arg.recombination <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_selection.R:178:36:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/feature_selection.R#L178) *style:* **Commas should never have a space before.**
```r
                        n_pop, " " , paste(start_freq, collapse = " "), " ",
                                  ~^
```
[R/feature_selection.R:191:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/feature_selection.R#L191) *style:* **lines should not be more than 80 characters.**
```r
                         ifelse(feature$get_start(), 0, feature$get_time()), ", ",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_selection.R:202:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/feature_selection.R#L202) *style:* **lines should not be more than 80 characters.**
```r
                         ifelse(feature$get_start(), 0, feature$get_time()), ", ",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_sumstats.R:18:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/feature_sumstats.R#L18) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_msms_arg.seg_sites_feat <- conv_to_ms_arg.seg_sites_feat
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_sumstats.R:22:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/feature_sumstats.R#L22) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_scrm_arg.seg_sites_feat <- conv_to_ms_arg.seg_sites_feat
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_sumstats.R:26:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/feature_sumstats.R#L26) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_seqgen_arg.seg_sites_feat <- conv_to_ms_arg.seg_sites_feat
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/import_popgenome.R:17:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/import_popgenome.R#L17) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.segsites.GENOME <- function(data, only_synonymous = FALSE, ...) {
^~~~~~~~~~~~~~~~~~
```
[R/import_popgenome.R:41:43:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/import_popgenome.R#L41) *style:* **Commas should never have a space before.**
```r
      seg_sites <- bam[c(pops, outgroup), , drop = FALSE]
                                         ~^
```
[R/model_getters.R:74:21:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/model_getters.R#L74) *style:* **Commas should never have a space before.**
```r
  if (sum(llm[group , c(1:2, 4:5)]) == 0) return(llm[group , 3])
                   ~^
```
[R/model_getters.R:74:60:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/model_getters.R#L74) *style:* **Commas should never have a space before.**
```r
  if (sum(llm[group , c(1:2, 4:5)]) == 0) return(llm[group , 3])
                                                          ~^
```
[R/model_getters.R:81:25:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/model_getters.R#L81) *style:* **Commas should never have a space before.**
```r
  min(which(cumsum(llm[ , "number"]) >= locus))
                       ~^
```
[R/model_getters.R:124:46:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/model_getters.R#L124) *style:* **Commas should never have a space before.**
```r
  numbers <- get_locus_length_matrix(model)[ , "number"]
                                            ~^
```
[R/model.R:93:39:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/model.R#L93) *style:* **Commas should never have a space before.**
```r
  sum(get_locus_length_matrix(model)[ , c(1:2, 4:5)]) > 0
                                     ~^
```
[R/model_simulate.R:36:3:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/model_simulate.R#L36) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  }, mc.set.seed = TRUE, mc.cores = cores)
  ^
```
[R/parameter.R:132:11:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/parameter.R#L132) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      if ((!is.numeric(value)) || length(value) != 1) {
          ^
```
[R/segsites.R:18:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/segsites.R#L18) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.matrix.segsites <- function(x, ...) get_snps(x)
^~~~~~~~~~~~~~~~~~
```
[R/segsites.R:31:19:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/segsites.R#L31) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  create_segsites((matrix(c(1, 1, 0, 1, 1,
                  ^
```
[R/segsites.R:96:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/segsites.R#L96) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.segsites.default <- function(data, ...) {
^~~~~~~~~~~~~~~~~~~
```
[R/segsites.R:101:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/segsites.R#L101) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.segsites.list <- function(data, ...) {
^~~~~~~~~~~~~~~~
```
[R/simulator_class.R:55:3:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/simulator_class.R#L55) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  }, character(1L))
  ^
```
[R/simulator_class.R:67:44:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/simulator_class.R#L67) *style:* **Commas should never have a space before.**
```r
  grouped_commands <- unique(sim_commands[ , 2])
                                          ~^
```
[R/simulator_class.R:70:36:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/simulator_class.R#L70) *style:* **Commas should never have a space before.**
```r
    sum(sim_commands[sim_commands[ , 2] == cmd, 1])
                                  ~^
```
[R/simulator_msms.R:101:41:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/simulator_msms.R#L101) *style:* **Commas should never have a space before.**
```r
        paste("msms", sample_size, cmd[ , 1], cmd[ , 2])
                                       ~^
```
[R/simulator_msms.R:101:52:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/simulator_msms.R#L101) *style:* **Commas should never have a space before.**
```r
        paste("msms", sample_size, cmd[ , 1], cmd[ , 2])
                                                  ~^
```
[R/simulator_ms.R:71:9:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/simulator_ms.R#L71) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
        }, character(1))
        ^
```
[R/simulator_ms.R:86:39:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/simulator_ms.R#L86) *style:* **Commas should never have a space before.**
```r
        paste("ms", sample_size, cmd[ , 1], cmd[ , 2])
                                     ~^
```
[R/simulator_ms.R:86:50:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/simulator_ms.R#L86) *style:* **Commas should never have a space before.**
```r
        paste("ms", sample_size, cmd[ , 1], cmd[ , 2])
                                                ~^
```
[R/simulator_scrm.R:84:41:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/simulator_scrm.R#L84) *style:* **Commas should never have a space before.**
```r
        paste("scrm", sample_size, cmd[ , 1], cmd[ , 2])
                                       ~^
```
[R/simulator_scrm.R:84:52:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/simulator_scrm.R#L84) *style:* **Commas should never have a space before.**
```r
        paste("scrm", sample_size, cmd[ , 1], cmd[ , 2])
                                                  ~^
```
[R/simulator_seqgen.R:54:4:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/simulator_seqgen.R#L54) *style:* **Commented code should be removed.**
```r
  #print(cmd)
   ^~~~~~~~~~
```
[R/simulator_seqgen.R:129:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/simulator_seqgen.R#L129) *style:* **lines should not be more than 80 characters.**
```r
                                        sample_seed(length(trees[[locus_group]])))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simulator_seqgen.R:154:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/simulator_seqgen.R#L154) *style:* **lines should not be more than 80 characters.**
```r
                                                              ignore_variation = TRUE),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat_ihh.R:19:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/sumstat_ihh.R#L19) *style:* **lines should not be more than 80 characters.**
```r
    initialize = function(name, population, max_snps, calc_ihs, transformation) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat_ihh.R:52:45:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/sumstat_ihh.R#L52) *style:* **Commas should never have a space before.**
```r
                      iHS = data.frame(ihh[ , 1:2], iHS = rep(NA, n_snps))))
                                           ~^
```
[R/sumstat_ihh.R:54:15:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/sumstat_ihh.R#L54) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          if ((n_snps < 50)) freqbin <- 0.90
              ^
```
[R/sumstat_ihh.R:55:20:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/sumstat_ihh.R#L55) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          else if ((n_snps < 100)) freqbin <- 0.45
                   ^
```
[R/sumstat_ihh.R:56:20:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/sumstat_ihh.R#L56) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          else if ((n_snps < 200)) freqbin <- 0.225
                   ^
```
[R/sumstat_ihh.R:57:20:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/sumstat_ihh.R#L57) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          else if ((n_snps < 400)) freqbin <- 0.1
                   ^
```
[R/sumstat_ihh.R:60:55:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/sumstat_ihh.R#L60) *style:* **Commas should never have a space before.**
```r
            data.frame(ihh2ihs(ihh, freqbin)$res.ihs[ , -4])
                                                     ~^
```
[R/sumstat_omega.R:14:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/sumstat_omega.R#L14) *style:* **lines should not be more than 80 characters.**
```r
    initialize = function(name, min_win, max_win, grid, binary, transformation) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat.R:192:6:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/sumstat.R#L192) *style:* **Commented code should be removed.**
```r
    #assert_that(is.list(tree_list))
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat.R:193:6:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/sumstat.R#L193) *style:* **Commented code should be removed.**
```r
    #assert_that(length(tree_list) == get_locus_number(model))
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat_seg_sites.R:41:38:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/R/sumstat_seg_sites.R#L41) *style:* **Commas should never have a space before.**
```r
    trio_segsites <- seg_sites[[i]][ , left | middle | right]
                                    ~^
```
[tests/testthat/test-feature-ign-singletons.R:13:45:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-feature-ign-singletons.R#L13) *style:* **Commas should never have a space before.**
```r
               list(create_test_segsites()[ , -c(1, 3)],
                                           ~^
```
[tests/testthat/test-feature-ign-singletons.R:14:45:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-feature-ign-singletons.R#L14) *style:* **Commas should never have a space before.**
```r
                    create_test_segsites()[ , -c(1, 3)]))
                                           ~^
```
[tests/testthat/test-model-class.R:241:44:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-model-class.R#L241) *style:* **Commas should always have a space after.**
```r
               data.frame(name = c("theta","tau"),
                                           ^
```
[tests/testthat/test-search-executables.R:30:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-search-executables.R#L30) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-segsites-class.R:15:41:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-segsites-class.R#L15) *style:* **Put spaces around all infix operators.**
```r
  expect_error(create_segsites(snps, 1:4/10))
                                       ~^~
```
[tests/testthat/test-segsites-class.R:16:46:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-segsites-class.R#L16) *style:* **Put spaces around all infix operators.**
```r
  expect_error(create_segsites(snps, pos, 1:4/10))
                                            ~^~
```
[tests/testthat/test-segsites-class.R:22:40:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-segsites-class.R#L22) *style:* **Put spaces around all infix operators.**
```r
  segsites <- create_segsites(snps, 1:3/10)
                                      ~^~
```
[tests/testthat/test-segsites-class.R:30:31:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-segsites-class.R#L30) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  segsites <- create_segsites((matrix(c(1, 1, 0, 1, 1,
                              ^
```
[tests/testthat/test-segsites-class.R:36:26:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-segsites-class.R#L36) *style:* **Commas should never have a space before.**
```r
  ss_subset <- segsites[ , 1:2]
                        ~^
```
[tests/testthat/test-segsites-class.R:38:64:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-segsites-class.R#L38) *style:* **Commas should never have a space before.**
```r
  expect_equivalent(as.matrix(ss_subset), as.matrix(segsites)[ , 1:2])
                                                              ~^
```
[tests/testthat/test-segsites-class.R:41:30:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-segsites-class.R#L41) *style:* **Commas should never have a space before.**
```r
  expect_equal(dim(segsites[ , 1]), c(3, 1))
                            ~^
```
[tests/testthat/test-segsites-class.R:42:33:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-segsites-class.R#L42) *style:* **Commas should never have a space before.**
```r
  expect_equal(dim(segsites[1:2 , ]), c(2, 3))
                               ~^
```
[tests/testthat/test-segsites-class.R:43:32:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-segsites-class.R#L43) *style:* **Commas should never have a space before.**
```r
  expect_equal(dim(segsites[-2 , 1:3]), c(2, 2))
                              ~^
```
[tests/testthat/test-simulator-ms.R:7:73:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-simulator-ms.R#L7) *style:* **Put spaces around all infix operators.**
```r
  expect_equal(parse_ms_positions("positions: 0.1 0.2 0.3 0.4 0.5"), 1:5/10)
                                                                       ~^~
```
[tests/testthat/test-simulator-seqgen.R:213:6:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-simulator-seqgen.R#L213) *style:* **Commented code should be removed.**
```r
  #  model.addMutationRateHeterogenity(model.hky, 0.1, 5, categories.number = 5)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-simulator-seqgen.R:236:6:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-simulator-seqgen.R#L236) *style:* **Commented code should be removed.**
```r
    #feat_migration(par_zero_inflation(1, .5), symmetric = TRUE)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-simulator-seqgen.R:274:27:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-simulator-seqgen.R#L274) *style:* **Commas should always have a space after.**
```r
  model <- coal_model(c(5,5,2), 1, 100) +
                          ^
```
[tests/testthat/test-simulator-seqgen.R:274:29:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-simulator-seqgen.R#L274) *style:* **Commas should always have a space after.**
```r
  model <- coal_model(c(5,5,2), 1, 100) +
                            ^
```
[tests/testthat/test-sumstat-jsfs.R:4:3:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L4) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  seg.sites.3.pop <- list(create_segsites(matrix(c(1, 0, 1, 0,
  ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:10:60:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L10) *style:* **Commas should never have a space before.**
```r
                                                   1, 0, 1 ,0 ),
                                                          ~^
```
[tests/testthat/test-sumstat-jsfs.R:10:61:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L10) *style:* **Commas should always have a space after.**
```r
                                                   1, 0, 1 ,0 ),
                                                            ^
```
[tests/testthat/test-sumstat-jsfs.R:11:54:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L11) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                    ~^~
```
[tests/testthat/test-sumstat-jsfs.R:11:62:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L11) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                            ~^~
```
[tests/testthat/test-sumstat-jsfs.R:13:3:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L13) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1:2, 3:4, 5:7))
  ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:13:27:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L13) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1:2, 3:4, 5:7))
                          ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:14:13:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L14) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  expect_is(jsfs.3.pop, "array")
            ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:15:21:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L15) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  expect_equivalent(jsfs.3.pop, array(c(0, 0, 0, 0, 0, 0, 0, 0, 0,
                    ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:18:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **lines should not be more than 80 characters.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:18:73:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                       ~^~
```
[tests/testthat/test-sumstat-jsfs.R:18:78:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Commas should always have a space after.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                             ^
```
[tests/testthat/test-sumstat-jsfs.R:18:80:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Commas should always have a space after.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                               ^
```
[tests/testthat/test-sumstat-jsfs.R:18:82:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                                ~^~
```
[tests/testthat/test-sumstat-jsfs.R:21:3:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L21) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  seg.sites.3.pop <- list(create_segsites(matrix(c(1, 0, 1, 0,
  ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:27:60:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L27) *style:* **Commas should never have a space before.**
```r
                                                   1, 0, 1 ,0 ),
                                                          ~^
```
[tests/testthat/test-sumstat-jsfs.R:27:61:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L27) *style:* **Commas should always have a space after.**
```r
                                                   1, 0, 1 ,0 ),
                                                            ^
```
[tests/testthat/test-sumstat-jsfs.R:28:54:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L28) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                    ~^~
```
[tests/testthat/test-sumstat-jsfs.R:28:62:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L28) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                            ~^~
```
[tests/testthat/test-sumstat-jsfs.R:30:3:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L30) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1, 2:6, 7))
  ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:30:27:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L30) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1, 2:6, 7))
                          ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:31:21:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L31) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  expect_equivalent(jsfs.3.pop, array(c(0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0,
                    ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:32:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **lines should not be more than 80 characters.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:32:82:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Put spaces around all infix operators.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ~^~
```
[tests/testthat/test-sumstat-jsfs.R:32:87:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Commas should always have a space after.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:32:89:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Commas should always have a space after.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:32:91:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Put spaces around all infix operators.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ~^~
```
[tests/testthat/test-sumstat-jsfs.R:33:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L33) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test-sumstat-jsfs.R:53:41:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L53) *style:* **Commas should always have a space after.**
```r
  jsfs <- calc_jsfs(seg.sites, list(c(1,3), c(2,4)))
                                        ^
```
[tests/testthat/test-sumstat-jsfs.R:53:49:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L53) *style:* **Commas should always have a space after.**
```r
  jsfs <- calc_jsfs(seg.sites, list(c(1,3), c(2,4)))
                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:58:41:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L58) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,3), c(2,5)))
                                        ^
```
[tests/testthat/test-sumstat-jsfs.R:58:49:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L58) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,3), c(2,5)))
                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:59:41:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L59) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,7), c(2,3)))
                                        ^
```
[tests/testthat/test-sumstat-jsfs.R:59:49:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L59) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,7), c(2,3)))
                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:141:40:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-jsfs.R#L141) *style:* **Put spaces around all infix operators.**
```r
                                    1:4/4))
                                      ~^~
```
[tests/testthat/test-sumstat-mcmf.R:13:51:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-mcmf.R#L13) *style:* **Put spaces around all infix operators.**
```r
  expect_equal(calc_mcmf(seg_sites, 2:4, FALSE), 2/3)
                                                 ~^~
```
[tests/testthat/test-sumstat-mcmf.R:70:63:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-mcmf.R#L70) *style:* **Put spaces around all infix operators.**
```r
                              coal_model(4) + locus_trio()), 1/3)
                                                             ~^~
```
[tests/testthat/test-sumstat-omega.R:7:5:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-omega.R#L7) *style:* **Use two spaces to indent, never tabs.**
```r
1.11	1.000000
    ^
```
[tests/testthat/test-sumstat-omega.R:8:5:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-omega.R#L8) *style:* **Use two spaces to indent, never tabs.**
```r
2.22	0.200000
    ^
```
[tests/testthat/test-sumstat-omega.R:9:5:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-omega.R#L9) *style:* **Use two spaces to indent, never tabs.**
```r
3.33	0.030000
    ^
```
[tests/testthat/test-sumstat-pi.R:7:67:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-pi.R#L7) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 1, 1, 1), 5, 3), 1:3/5)
                                                                 ~^~
```
[tests/testthat/test-sumstat-pi.R:26:67:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-pi.R#L26) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 1, 1, 1), 5, 3), 1:3/5)
                                                                 ~^~
```
[tests/testthat/test-sumstat-segsites.R:28:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-segsites.R#L28) *style:* **lines should not be more than 80 characters.**
```r
  seg_sites_trio[[1]] <- create_segsites(get_snps(seg_sites_trio[[1]][ , c(1:2, 4:6, 8:9)]),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-segsites.R:28:72:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-segsites.R#L28) *style:* **Commas should never have a space before.**
```r
  seg_sites_trio[[1]] <- create_segsites(get_snps(seg_sites_trio[[1]][ , c(1:2, 4:6, 8:9)]),
                                                                      ~^
```
[tests/testthat/test-sumstat-sfs.R:62:40:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-sfs.R#L62) *style:* **Put spaces around all infix operators.**
```r
                                    1:4/4))
                                      ~^~
```
[tests/testthat/test-sumstat-tajimas-d.R:14:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-tajimas-d.R#L14) *style:* **lines should not be more than 80 characters.**
```r
                                 0, 0, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 0, 0, 0, 0),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-tajimas-d.R:27:1:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-tajimas-d.R#L27) *style:* **lines should not be more than 80 characters.**
```r
  expect_equal(tajd$calculate(list(create_empty_segsites(10)), NULL, NULL, model), NaN)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-trees.R:6:30:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-trees.R#L6) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_true(requires_trees((coal_model(5) + sumstat_trees())))
                             ^
```
[tests/testthat/test-sumstat-trees.R:7:30:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-trees.R#L7) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_true(requires_trees((coal_model(5) + sumstat_sg_trees())))
                             ^
```
[tests/testthat/test-sumstat-trees.R:8:34:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-trees.R#L8) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_false(requires_segsites((coal_model(5) + sumstat_trees())))
                                 ^
```
[tests/testthat/test-sumstat-trees.R:9:34:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-trees.R#L9) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_false(requires_segsites((coal_model(5) + sumstat_sg_trees())))
                                 ^
```
[tests/testthat/test-sumstat-trees.R:73:64:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-trees.R#L73) *style:* **Commas should always have a space after.**
```r
                                 locus_trio(locus_length = c(1,3,5),
                                                               ^
```
[tests/testthat/test-sumstat-trees.R:73:66:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-trees.R#L73) *style:* **Commas should always have a space after.**
```r
                                 locus_trio(locus_length = c(1,3,5),
                                                                 ^
```
[tests/testthat/test-sumstat-trees.R:74:60:](https://github.com/statgenlmu/coala/blob/f82582271b51792ca8be3f22dbd0601bbcc5baec/tests/testthat/test-sumstat-trees.R#L74) *style:* **Commas should always have a space after.**
```r
                                            distance = c(2,4)))
                                                           ^
```


That fixes it, thanks. :+1:


Bela história


:smile: nice underlines!


This line needs removing, left over from testing. Removed in next commit.


![screen shot 2016-01-25 at 4 48 02 pm](https://cloud.githubusercontent.com/assets/5640772/12565766/2018320c-c384-11e5-91ee-d06ae62d445d.png)


did the lab.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12649](https://teamcity.mesosphere.io/viewLog.html?buildId=112249&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:09:13


This kills Ruby 1.8.7 compatibility. :( Is PR welcomed?


@vdaburon , I forwarded your note to dev mailing list, read there my answer


Interesting, I'm curious why what we pass to the `setup.py` doesn't need to be adjusted too:

https://github.com/ros/catkin/commit/f20c4730f3a15e829da987e5564729987306bbf9#diff-227e03260c0f962311819d32ab4341b6R33

Does the `setup.py` respect `DESTDIR` implicitly?


Lets create a 'elixir.son' in the root directory so we can pull this out. In it lets add it:

```
{
  "production" : false,
  "sourcemaps": true,
  "bowerDir": "bower_components"
}
```


I think back then new stuff was under the `tr1::` namespace but yeah, it's safer to do it this way.


@un1versal. The previous merge was a bad one. Left merge headers. This file should not change and remain same as AOSP


Так всё-таки, количество попыток = 3 - это первый if, или второй?


а так да, хорошо


This is a bit funky looking. Perhaps if you move it into a helper function you could assign the two paths on separate lines and then the simple format call would just be one line...


Could extract this from the above with regex (e.g. `/function (\w+)\(/`), but since they don't really change it doesn't seem worth it.


@balsdorf do you see otherwise?


Please add the word 'formats' after the CSV link.


I did but kept getting "directory not empty" error. Let me see if I can dig in a little more here...


Mir ist nicht klar, warum die die Datein hier nochgeladen hast


Legacy code, but is m_authtype used?


I think they're both supposed to be replaced by the new json model system, which I'm just starting to look into. I'm not sure quite how robust it is, but I think it should work OK for (most of) our purposes. We'll see, I guess...

I still have to actually code in all the blockstate stuff as well - at the moment it's all just converting them to old-style metadata whenever it comes across them, and I haven't even actually written the code to change between state and metadata properly yet.

I saw your comment, but I've not had time to properly think about it and form a response. I'll go and respond in that thread shortly. Sounds like you're doing exciting work on all the new generation stuff, I'll see if I can take a look at it back in 1.7 in a bit, where everything still looks like it should rather than just being large black/purple cubes...


It should be  enclosed in
```
if(RestClient.isDebug()){
   Log...
}
```


For me it means I'll have to stay on the 3.2.22 version till I can get away from Ruby 1.8.7. It is in the works, but not within the next month.


@talsraviv sorry for the confusion

- they need the `Fixes #ISSUE` in the **description** -- having it in the title has no effect

- PR **title** should be: `"{IA NAME}: Brief explanation of PR"`
- PR **description** should be:

```
fixes #12345

This PR accomplishes X by doing Y and .....
```


Checked these in, instead of PR'ing cause it was time sensitive cc @cjb @oconnor663

Added "latest" command to release tool here, see commits here: https://github.com/keybase/release/commits/master
(First I tried using links and then changed to use copy)


in MCG


I haven't tested this. In theory, PROGMEM does not prevent the same optimization from being applied - to the compiler a PROGMEM array is also just a const array, only at link time will it end up in a different section. However, these particular tables are only defined by pins_arduino.h when ARDUINO_MAIN is defined (which, I think, is only when compiling the .ino files), meaning that the contents of these tables is only available to the sketch, not to libraries. This would mean that any lookups in the sketch can happen at compiletime, while lookups from libraries must happen at runtime. Also, I just realized that the compiler probably doesn't optimize through e.g. `pgm_read_byte()` calls, preventing this optimization from happening at all. I wonder if there is some way to solve both and have all of this constant data available to the optimizer all the time...

On the short term, I guess verifying that this is indeed a lot slower might be a good idea, and perhaps revert this change? Or use this method only for boards that are not otherwise known?


Lets leverage elixir.json here by modifying the following:

```
// Get Bower Directory Path (elixir.json)
var components = elixir.config.bowerDir;

// Get Bower Package Paths
var paths = {
   'jquery': components + '/jquery/dist/'
}
```


@thejinxters can you take a look at this? The test is failing but it shouldn't be. I think there's an issue with the unittest scope not matching the controller's scope maybe?


LGTM


D3D11_RASTERIZER_DESC.FrontCounterClockwise is passed to pVC4ConfigBits->ClosewisePrimitives. Did I miss something?


yeah - forgot to remove this one


Simplified


@wjwwood We explicitly pass `--root=...` for that: https://github.com/ros/catkin/commit/f20c4730f3a15e829da987e5564729987306bbf9#diff-227e03260c0f962311819d32ab4341b6R12

@mikepurvis I will create the PR with the patch soon. Thanks for reporting!


On second thoughts, looks like that's how the test was designed, so the cmd is still set when the DMA ends then it sends the rest of it, so that's working :P just need to check the results lol


hard to see on github, but how do we handle the case where a binding contains an Authenticate section but no method attribute?


Also confused with the use of `bundleId` since the method seems generic across types, but then looking at latest code, seems like nothing is now implemented here because of #431.


I did not upload the robot.java file. Anthony has the eclipse project with the robot.java file.


commented on #23248


Is updated. Thank you!

https://github.com/chef/chef-web-docs/commit/b6aa9d4ddd168ec9da578432286271d5ab920888


lets swap `assetsDirectory` for ex. `paths.jquery`


@clintonb did you test this? This makes it look for unicorn in `/edx/app/forum/cs_comments_service/bin/unicorn`, whereas it should look in `/edx/app/forum/.gem/bin/unicorn`.


Fixed by f966ef0


Вообще решено правильно, но есть несколько моментов:
1. Условия задачи проверяются верно, но потом всё равно происходит расчет зарплаты. А зачем, если условия не выполняются?
2. Строки 14 и 18 - абсолютно одинаковые. Можно немножко переписать и обойтись только одно.


Did you consider to introduce a singleton class that holds the UserSettingsPointer?
If we add facilities to mock the preferences for test, this should be a neat solution for unit testing and for de-cluttering the call tree from the pConfig Argument.
What are the cons?


```
while self.server_proxy.get_reports():
    time.sleep(2)
```


The defaults do not provide for a venv based install. I'd like to see if we can work that into this file so that the base role will have the venv capabilities we see in the other OpenStack-Ansible roles for OS components. Something similar to https://github.com/openstack/openstack-ansible/blob/master/playbooks/roles/os_nova/defaults/main.yml#L23-L36


@vdaburon , isn't the bug fixed in JAVA 7u2 :
- http://www.oracle.com/technetwork/java/javase/2col/7u2bugfixes-1394661.html


Cool. Looks like this should Just Work once I call into s3_index.sh from the Linux nightly build?


`$price` moet ingevuld zijn en mag nooit `null` zijn, deze is verplicht. Deze controle is dus niet goed. Zelfde geld voor `$name`. De `OrderController` moet daar zorg voor dragen.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12651](https://teamcity.mesosphere.io/viewLog.html?buildId=112261&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:10:24


Does it fold properly if you make the first docstring a normal string (not raw)?

Do you happen to have `foldminlines` set to a value greater than 1?


Can we be more descriptive here regarding what is being done here?


Magic constants :question:


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 129](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=715&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


@calvinatintel looks good please merge


granted this class is already leaking through the `WMFExploreSectionController` abstraction, but IMHO this should be done in `fetchDataIfNeeded`—especially since then it will happen behind the rate-limiting in `fetchSectionIfShowing:` logic


Je hebt `$messages` al op regel 47 gedefineerd. Deze is dus overbodig.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1252.4dfced852e0a09ad7dbdc93c6e2fabb4b378674b](http://build.palaso.org/viewLog.html?buildId=68442&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 847, ignored: 7 Build time: 00:07:04


De `User` ophalen aan de hand van de `Order` kan niet eah.


I think this may have broken compatibility with ruby 1.8.7 if anyone still uses that (only noticed because the rspec-rails  test-suite still runs against 1.8.7)


This is only the artifact. Typically it's a good practice on GitHub not to check-in the artifacts, since it makes the PR messier to review, and these kinds of mistakes easier. Not a big deal, just a small point of etiquette.


Yep, that wasn't intended.


if i understand this correctly, it duplicates `isDisplayingCellsForSectionController:`


Je kan beter het `User` object geheel insturen. Dus `$user`.


массивы в этой задачи не нужны


IDK if this file is needed. In the nearish future we're going to be moving all of the plugins and libs to a separate project. For now the roles that depend on these things have been pulling the plugins from the OS-cloud repo https://github.com/os-cloud/openstack-ansible-plugins and pulling them done in tests like so  https://github.com/openstack/openstack-ansible-galera_server/blob/master/tests/ansible-role-requirements.yml#L1-L5


можно было просто
```int x = (int) (Math.random() * 100) + 1;


Electric-Service-Refactor (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (2060 of 2060 tests passed, 479 test warnings)

 * 549 tests had: AUD diffs.
 * 479 tests had: RDD diffs.
 * 3 tests had: MTD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The `<img>` tag is not actually a block level element. Try wrapping these images in a `<div>`.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.575.8515507208c1539220ebee854cf5e7e479e1de6d](http://build.palaso.org/viewLog.html?buildId=68443&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 931, ignored: 56 Build time: 00:18:09


Nadat deze succesvol is aangemaakt kan je beter doorsturen naar `index.php?section=order&action=view&id=' . $order->id` en dan het gehele `Order` object weergeven. Met de naam van de `User` die hem heeft gekocht.


huchwas?


Je gaat hier een `Order` aanmaken. Dus je moet naar `order/add.tpl`.


Last bit; how about: "or validate metadata in an existing file."?


Nice! This looks really great!


Binstubs negate the need to know the path of the gem directory. See https://github.com/rbenv/rbenv/wiki/Understanding-binstubs. The relevant binstubs have been added to the cs_comments_service repo (https://github.com/edx/cs_comments_service/pull/170).


только ты забыла напечатать поздравления в зависимости от количества попыток


Change BW logo


don't forget to remove this comment


Dammit! Thanks for the catch, @basz !


Thanks, Adam!


I'd like to see the venv based install as a default option for this service. This can be done similar to how it was added in nova https://github.com/openstack/openstack-ansible/blob/master/playbooks/roles/os_nova/tasks/nova_install.yml this will work just fine however itll install within the root path and while I'd like to keep that as an option getting the service into a venv will ensure we're not running into upgrade/deployment conflicts.


I totally love these cleanups. It would be great if you could put them in separate commits from the substantive code changes though so I can pay more attention to those. Thanks!


NO.


Jaki sens ma sprawdzanie czy indeks najwiekszego elementu jest wiekszy od zera?


remember to fix indention


can this be added as a handler?


Здраво, перенесу.


Missing @param.


Oops - sorry about that.


tu moj blad. Powinno byc po całym zakresie przeciez!!! A nizej tylko po polowie (po fft).


From our style guide; I believe we typically break lines at 80 chars, including comments. There are some exceptions, but normal comments should be wrapped?


Indent


Тут ОК


That was meant to read "use $watch to enable autorefresh", but I forgot I was in a shell when writing it...


front-end source code


Je hebt hier het `user_id` nodig. Dus `$_POST['user_id']`.


You go from ## in Usage to #### (2 to 4 pound signs). Why no 3?


Ok, I've made the update. After testing I'm not getting it anymore. I changed the download/extract logic a lot since I got the error so perhaps I was doing something wrong before.


I know at some point we passed in the email account but clearly that was
removed a LONG time ago.

Good code cleanup. Thanks

On Mon, Jan 25, 2016 at 3:56 PM, Elan Ruusamäe <notifications@github.com>
wrote:

> @balsdorf <https://github.com/balsdorf> do you see otherwise?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/eventum/eventum/commit/b6920b00673fae140d48662702eba3deea195922#commitcomment-15662517>
> .
>

--
Bryan Alsdorf
MariaDB Corporation | http://mariadb.com


please see #23248


Do we need the whole default config file? can we prune this down to just the basic requirements to get the service to run?


Cambié animalitos por revolucionarios en la barra D* para cambiarse cada día de la semana. El domingo es hackday. Es el día de los revolucionarios informáticos, que vaiará cada domingo.


update


I will change it in next commit.


Did you intend to grab the more ambiguous logger?


I guess i am still confused about handling multiple types real time (`state.getType()`) versus extracting the `bundleId` (and therefore implying things are for bundle only.

Also why would bundleId not be set -- does `entitlement.getBundleId()` ever [get null](https://github.com/killbill/killbill/blob/fix-for-451/entitlement/src/main/java/org/killbill/billing/entitlement/api/svcs/DefaultEntitlementInternalApi.java#L231)?


I should put it in a try block though...


Nice. I like it :)


Yeah these changes are more meaningful. I will modify them.


Huh, that's really weird. Well, reverted as well and will check to see if everything is working accordingly for me too later...


In future commits, lets do indentation changes in it's own commit. Switching arg modules AND updating the indentation makes it much harder to track the changes :8ball:


Maybe rename `setBlockingStatesForBundle` to make it clear we work at the bundle level?


With the additional definition of the bin path in defaults can we remove this absolute? In that way we prep the role to support a venv based install https://github.com/openstack/openstack-ansible/blob/master/playbooks/roles/os_nova/templates/nova-upstart-init.j2#L13


I moved the caddy tar.gz out of the /tmp directory, because it also serves as a check if there were any updates to caddy (after the releases file changes) and should therefore persist and not get deleted by the system.


а тут можно сделать красивее и короче, используя switch-case


This might be the binding name (which a lot of times includes the service name)


Same remark about naming?


Can we add in the sourcing of a venv should the venv be used. example : https://github.com/openstack/openstack-ansible/blob/master/playbooks/roles/os_nova/templates/nova-upstart-init.j2#L26-L28


Missing @param.


OK results are wrong with the vif dynarec, but completely correct with the interpreter

Interpreter results: http://pastebin.com/zaaHR0Lm
Recompiler results: http://pastebin.com/YscGdbSD
Expected (from PS2?): http://pastebin.com/77eM3kwR


object not objected


112331505_SurfaceHeightRange (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1508 of 1508 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


Yes, pgm_read_byte() prevents that optimization, since it's assembly code.

Long term, the 2 good solutions would be gcc named address spaces or Arduino providing a better pin manipulation API.  On the latter, we've been down this road before, and there just wasn't any willingness to define the pin mapping differently than the PROGMEM table.


Any particular reason for defaulting these new methods to protected?


LGTM.


Ben, great job on your quiz. I only saw the one block level element issue. After you fix that you are :+1: . Keep up the good work.


Review?


ой, а зачем тут какой-то i < 100 ? что такое это 100? почму именно 100, а не 42?


Didn't build :cat: http://jnugh.de:8080/job/RootJS/lastFailedBuild/ :D


specifically this is the critical step that I was missing...


Camel case not applied to variable after copy/paste.


Fixes #3


Thanks for doing this Jeremy. I should reiterate that I certainly DID have to remove the vendor section for rugged to get SP to use the correct location for the compiled rugged.so file. having done that, there was indeed no need to move any .so file to rb-native.


A quicker way to check this would be `if mission_id != form.mission_id`?


This one would need to round off  to some allocation unit.  But.. I don't think we really need it, since rocksdb only writes whole files.  The only time the truncate even comes up is when it has crashed and reuses a file that wasn't in the manifest, which is pretty rare, and the new instances will fill it up.  Or, it has a log file that is slightly shorter than it expected. But I don't think it's worth worrying about, honestly...


Should be deleted?


I know this is petty, but they will prob give us crap on it. Rename `metricis_we_want` to `HDFS_METRICS` or something a little more meaningful.


So in the JS, we need to be able to differentiate between these two errors and also other InvalidModification errors. Do we need different error names?


Why not just `build-common`?


Send a PR upstream ;)


здесь ретурн не нужен
и вообще, обычно принято все входные параметры проверять в начале - тогда и этих ретурнов по всему коду не нужно.
А так все хорошо


We don't need this.  Once rocksdb writes a file, it is never touched.  Write, then read. The only time a written file is every modified is when there was a crash and we are overwriting an unreferenced/incomplete file.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12659](https://teamcity.mesosphere.io/viewLog.html?buildId=112272&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:08:36


yep Just Works™


Right, thanks!


I see what you are doing here but I think we can be a bit more restrictive. Folks should not even be able to see the form if it's not in the current mission.

What I'd like to see is:

1. In the new and create actions on the responses controller, we should be checking that the requested form is in the current mission, and returning 403 otherwise.
2. To prevent folks from even getting to this point, we should redirect the user to the mission dashboard if they were in responses/new when they changed missions. Should add a spec to mission_change_redirect_spec.rb for this.
3. The validation is still a good idea I think.

Thanks!


Why protected on the last four services? If made private, and add protected getters, it would make for a better pattern to inherit later down the road.


I would change this to the slightly less revealing "The specified form does not exist in this mission."


не будем ))


Thanks, Brian! I'm glad that was easy even if it may have taken awhile to track down.


I think i missed making them public...


`libsmm-local.dylib` and `libsmm-local.so` are symbolic links to a potentially incompatible version of the library. It's safer to strictly bind OpenSC to the (library) version of libsmm that's installed.


Successfully created the [aeligature-](http://aeligature--static-docs.pantheon.io/docs) environment. New commits to this branch will automatically be deployed.


on second thought, this is a bit different than `fetchDataIfNeeded`. this was handled w/ list data sources by having a "dynamic data source" sub-protocol which has `(start|stop)Updating` methods invoked in `(will|didEnd)DisplayingCell` which are balanced—unlike the rate-limited/aborted fetching calls.


The binding name might make sense, but the method comment seems to expect the service name:
const char *srvName = bnd_cfg->queryProp("@service");


ок ))


LGTM


@Robotia the very symbol values


it looks like you are using the key as the metric name. DataDog specifies metrics reported by the Agent are in a pseudo-hierarchical dotted format (e.g. http.nginx.response_time).

So this probably means you should specify the metrics you are collecting as some type of constant. It will make it easier for you to add remove metrics in the future.


Nope, just a Typo. will fix


And by the way, which problem did you encounter that this commit fixes?


This change was done for mongo java driver version 3, but then later I realized that version 2 should be used and reverted afterwards.


Another petty comment, gotta have a better name than `everything_dict`


Also, can you please look into the Travis failures for this one. The specs aren't even running. Perhaps a syntax error hidden somewhere?


Um die Lesbarkeit zu erhoehen koennte man die folgenden Zeilen ungefaehr so schreiben:
```python
config_mode = args.config
reboot_all = args.all
server_proxy.reboot_router(args.routers, config_mode, reboot_all)
````


Looks like is Canola!


If the method `onPhaseEvent ` and `onBasePlanEvent `, why do we then send the event at this level?


I don't know why this file showed up in this commit, there was nothing changed in here....


TeamCity Chorus :: chorus-precise64-chorus-2.5 Continuous [Build 2.5.1013.bab9ad24dc6ac370cd6b01ef876ee8b815ba2fe8](http://build.palaso.org/viewLog.html?buildId=68446&buildTypeId=ChorusPrecise64v25Cont) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:16:13


No problem. It made perfect sense after I figured it out.


Right, can you fix typo "Closewise", too ? And just want to double check, does VC4's ClockwisePrimitives and D3D11's FrontCounterClockwise state really match ?


Overall It looks good. I am trying to think of where you might need tags, but can't think of anything yet. My biggest comment is variable names, they need to be meaningful. Also, metric names need to be in reverse hierarchical format.


I think we shall chain commands with `&&`, so if something fail we dont go on.


actually, two things about this being here:

1. I already implemented the "did the entire section go offscreen" logic on line 719 (which might also be similar to `isDisplayingCellsForSectionController:`)
2. Depending on your thoughts about [what I said above](https://github.com/wikimedia/wikipedia-ios/commit/00af0ff12b0281668f10ddb08b67020c1aeef51f#commitcomment-15663247), this could be a call to `stopUpdates` on a dynamic section controller for that section (pushing back the leaks in the abstraction)


This approach will read-out one AM2301 after the other, using the original code as is. This is obviously a very slow approach, but it used only every min or so it should be fine.


I did not know that bio-formats packages are pretty different in ome and loci. I initially used loci one and failed. This commit is to fix those failures.


This now throws the following error
```DistributionNotFound: The 'keyring' distribution was not found and is required by the application```


This breaks builds that using the [_tag_ releases](https://github.com/ariya/phantomjs/tags) as they do not retain the `.git` directory.


to put it another way: `isShowingNearbyCells` should always equal `visibleIndexPathsInSection.count == 0` when the section is the nearby section, so you shouldn't need to do this check. however, the `stopMonitoringLocation` when cells go away is a nice optimization to cut down GPS/compass battery use when cells are offscreen :+1:


TeamCity StatCraft :: Build [Build 11](https://tc.demonwav.com/viewLog.html?buildId=196&buildTypeId=StatCraft_Build&guest=1) outcome was **UNKNOWN**
Summary: Canceled (Exit code 1 (new)) Build time: 00:00:06


TeamCity StatCraft :: Build [Build 10](https://tc.demonwav.com/viewLog.html?buildId=194&buildTypeId=StatCraft_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 46 Build time: 00:00:13


@karasu I don't have a preference either way. Though to be clear, there's nothing preventing the user from simply uninstalling the antergos-kde meta package if they want to uninstall one of its dependencies (the other packages would still be kept)


if you wanted to add prefixes for different archs for rpm vs deb... e.g.

/linux_binaries/deb/amd64/keybase_....

(also maybe rename linux_binaries back to linux?)

it allows us to list, categorize files easier


Yes, I think so.


Fixes #1


TeamCity StatCraft :: Build [Build 12](https://tc.demonwav.com/viewLog.html?buildId=198&buildTypeId=StatCraft_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 46 Build time: 00:00:17


Actually got details, edit and delete working again


:+1:  Awesome looking forward to it i do know the following makes it feel a bit laggy when you hit the ground also love to see your soloution to the crouch jumping spamming that causes animation jitter.


You're using this method (cached), which is a private methode of another class, and that method uses @cache which is then not correctly initialized -> `undefined method cache for nil:NilClass`


Installed inxi
reworked for this script


It seems counter-intuitive to have to send events at the time we rebuild, since this should just a be a read-only operation?


This commit broke the humidity sensor for me... :-(
The preamble will always be 0xFF, so there must be some other way.


This was more a convenience thing than a necessity thing.


TeamCity StatCraft :: Build [Build 13](https://tc.demonwav.com/viewLog.html?buildId=200&buildTypeId=StatCraft_Build&guest=1) outcome was **FAILURE**
Summary: Tests passed: 46; exit code 7 (new) Build time: 00:00:14


I would change this to `return Promise.reject(response)`


IMO it's odd to require the loop button to be held down. This behavior may make sense in slip mode, but most uses of looping should just require a single button press.


Please remember to test your changes with the test corpus...


a co z configlist.php? "Nieznana opcja. ... "


I'll get these to you soon.


Interesting @varund7726

I just checked RR's source and is line for line the same. Not sure why is working for you and not us. Might have to revisit this when I have a bit more time, thanks for the heads up tho!


Ah, I was up too late and thought it was something different. I am however very interested in the possible bootloader applications. I'll update if I find anything interesting


Is there a reason this is removed from the LICENSE? It is still in use by the AbstractHTMLProcessor.


this hunk belongs in the previous commit


i encourage you to remove unsused code?


@cleverpanda texturepack+soundpack, Forge the latest version is recommended, Lex just forgot or was too lazy to update the status.

compilation modes depending on what uses? I was manually gradle project settings for this mod as on github there are none, and there is no description for how to compile Java and what dependencies.


112331505_SurfaceHeightRange (Nigusse) - i386-Windows-7-VisualStudio-12: OK (2057 of 2057 tests passed, 0 test warnings)

 * 6 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The practice "e.printStackTrace();" in a catch block will get spit out to STDERR, which in KFS PRD gets dumped to localhost.log; not sure if this is what you intend.


No, probably another "auto-merge" issue during rebase, will restore, sorry about that!


Yea, I've been thinking a lot about how to share this state in Mixxx.

The object graph tree is indeed pretty polluted by passing this around. But on the other hand you can tell immediately whether a class relies on user configuration state if it takes a UserSettingsPointer. So that's actually a huge win. If we have a singleton, we can't tell whether a class uses global state unless we fully read the class's implementation *and* the implementation of every class that class depends on!

There's a difference between simple and easy. We should be shooting for simple, not easy. It's *easy* to make a singleton and then just grab it whenever you need it but it's more complex because you can't tell what parts of your system rely on global state and which are pure (do not depend on global state -- same input to function == same output).

When writing a unit test, you can't be sure you covered all the cases you need to test until you've tested all the possible inputs. But if there are hidden inputs -- such as singletons -- then it's very easy to end up with code that is highly dependent on particular values of global state and tests that don't have full coverage.

So, from my perspective, we shouldn't be aiming for saving on typing extra characters (i.e. passing the user settings around) since it requires us to think about what parts of Mixxx should depend on state and which should not. Putting thought into the design up front results in better designs.

This isn't to say all uses of singletons are bad -- sometimes they are called for.

These are by no means new idea -- this has been understood in functional programming communities for decades. In my workplace (Google) singletons are strongly discouraged. Here are some references:

* http://www.infoq.com/presentations/Simple-Made-Easy
* https://www.youtube.com/watch?v=-FRm3VPhseI
* https://code.google.com/archive/p/google-singleton-detector/ (Google actually built tools to detect singletons and tell you not to make them!)
* https://code.google.com/archive/p/google-singleton-detector/wikis/WhySingletonsAreControversial.wiki
* http://googletesting.blogspot.com/2008/08/by-miko-hevery-so-you-join-new-project.html
* http://googletesting.blogspot.com/2008/08/root-cause-of-singletons.html


I haven't specifically templated this out. (I presently have the basic requirements in the test playbook.)


See #2


I think that in Markdown, you can use two or more spaces at the end of a line to create a line-break... and it won't look unreadable in a text editor or pager (not sure if it works inside quote blocks or not though).


Frankly wanted this to always run after a playbook run for now. Past experience with handlers has been... inconsistent to say the least.


This closes #4


I think it makes more sense to put these new fields in pg_missing_t::item.  You just need to make sure the pg_missing_t decoder will manually traverse the old-style encoding since item itself doesn't have the encoding version wrappers.


Lol this was the reason? fml


TeamCity StatCraft :: Build [Build 14](https://tc.demonwav.com/viewLog.html?buildId=202&buildTypeId=StatCraft_Build&guest=1) outcome was **FAILURE**
Summary: Tests passed: 46; exit code 7 Build time: 00:00:12


Looking good.


nit: these two are empty


Yes, apparently it does. That's awesome!
I'll commit this to the file, to improve it even further. Thanks.


I think if we're doing a partial recovery like this, we should use the temp object at all--just overwrite the existing one with the right extents and update the version


that's really clever :+1:


This is already stated here: https://github.com/apache/nifi/blob/1f4ef9f5fa38bab9a29102b4a1367063b622ed02/nifi-assembly/NOTICE#L206-L206


I love this :+1: looks so much cleaner


Return fail here?


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 129](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=715&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **SUCCESS**
Summary: Running Build time: 00:36:44


TeamCity StatCraft :: Build [Build 15](https://tc.demonwav.com/viewLog.html?buildId=204&buildTypeId=StatCraft_Build&guest=1) outcome was **FAILURE**
Summary: Tests passed: 46; exit code 7 Build time: 00:00:16


Thanks for fixing that, I was kinda herping the derp when I changed that code


Nits: Refactor the rest of this function into RemoteDeploy().  It's nicer to have this function call LocalDeploy() or RemoteDeploy() depending on the switch.


@allustin ушел в другой бранч https://github.com/silverbulleters/vanessa-behavior/tree/feature/build-from-one-step


This method will be unused until [#4945](https://github.com/CenterForOpenScience/osf.io/pull/4945) is merged.


Uhm, why are you using SurfaceType.MIXED and not SurfaceType.UNDERGROUND? :P


Question: When is this function, GetCurrentDebugTarget(), called?  I don't see a caller in this class.  Any chance of this getting out of sync (ie. isLocalTarget have the won't value) when deploying?


Please follow the existing naming schema and use `Audio.Fields.Role` and `Audio.Details.Role`.


Question: Do we want to have the --debug switch for release configuration as well?


Bad indentation


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.167.8515507208c1539220ebee854cf5e7e479e1de6d](http://build.palaso.org/viewLog.html?buildId=68450&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 943, ignored: 50 Build time: 00:35:25


Should we have the top bar be #555 instead of #000 to match the new snazzy buttons?


I dont know of anything like that, but I think I can describe it pretty well since it's pretty much just recursion. Is there any way on these slides to make some of the text appear later like a regular slide show?


There are a few things that may be tripping you up.

1. You are not using the restful $resource object that angular provides in your session.coffee service
2. You are trying to mock out the httpBackend in your controller, when realistically you may want to simply mock the session service in your backend (keep unit testing to just the unit you are working on). This will also remove the need for "localhost:300/.... blablabla."
3. You can look at the mentor_controller_spec.coffee for examples on Mocking a service

I think that if you were to use some of the following code, it might fix it:
```coffee
LoginController = {}
scope = {}
SessionMock = {}

beforeEach module ($provide)->
    $provide.value('Session', SessionMock)
    return # null return needed for beforeEach module

beforeEach inject ($controller, $rootScope) ->
    scope = $rootScope.$new()

    # Mock successful session service
    SessionMock.login = ->
      return {
        name: "User Name"
        email: "user@example.com"
      }
   LoginController = $controller 'LoginController',
      $scope: scope
```
then you can just call `scope.sendCredentials(creds)` and it will return the login object when it is called


Instead of capping the y level like that which will cause a lot more pots to generate at y = 70 you should just change the range


Can we inject this?


Did you mean to leave the valid move stuff outside the functions? Remember that in Python, indentation controls where the code belongs, and right now, most of your code is not in a function. Also, I'd not write directly to the board (that ought to be a part of the board module, and I've already let Yann know).


A meican\base\grid\Grid já é responsive. Nao é necessário que a box seja responsive. Vou documentar isso como feature da Grid.


The workaround calls overdue from payment (or rather the invoice-payment plugin). This creates a new dependency between this plugin and overdue and breaks the event -based approach we had before.

I am not sure if this is really a problem (we should chat), but i could see a different design:
* We introduce a new event type `InvoicePayment` that is sent from invoice when an invoice just got paid (seems like a good event to have anyway), other plugins or subsystem could benefit from knowing that
* Overdue stop listening to `Payment` event (those are raw payment, that may or not be related to invoices), and instead listens to the new `InvoicePayment` event


I guess I'd also be happier to hear more about the assumptions made here. What branches are expected in the main and submodule repositories? What deploy procedure are you targeting? Does it matter which branches you're on when you run the command? What checks will be performed? I suppose these may be silly questions... maybe I'm not really your intended audience, which I guess is probably people who have done FR cluster deploys ;)

P.S. Maybe there's other existing doc about the expected deploy procedure/repo structures you're targeting?


@SubJunk not sure but i'll try. looks like I'm getting it to build and will have a new version for you to try shortly


TeamCity StatCraft :: Build [Build 16](https://tc.demonwav.com/viewLog.html?buildId=206&buildTypeId=StatCraft_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 46 Build time: 00:01:37


I apologize for the inconvenience. I should have changed the data structure long time ago. I will try using the data structures we talked about on the pull request and probably they would achieve a more reasonable time.


Bad indendation


This happens because the above pull wasn't able to fast-forward?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12665](https://teamcity.mesosphere.io/viewLog.html?buildId=112320&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:21


# Assignment 2 Grading Rubric (15 points total)

## Screenshots

- [ ] There are screenshots showing 3 valid ways to run the program (0.5 pt)

## Imports

- [ ] To the best of your knowledge, each of these explanations is correct (1.5 pts)
- [ ] This method of import is correctly selected as the best (0.5 pts)
- [ ] This explanation is correct and the example is good (0.5 pts)

## Paths

- [ ] This is a reasonable path to the Desktop (1 pts)
- [ ] This is a reasonable path to the `root` directory (1 pts)
- [ ] This is a correct explanation of the meaning of $PATH (1 pts)
- [ ] This is a correct explanation of the meaning of $PYTHONPATH (1 pts)

## Modules

- [ ] This paragraph explains the module well (3 pts)
- [ ] There are examples (3 pts)
- [ ] The examples aren't simply taken from the documentation (2 pts)


@kohsuke Copy/paste mistake.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1253.4dfced852e0a09ad7dbdc93c6e2fabb4b378674b](http://build.palaso.org/viewLog.html?buildId=68464&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 847, ignored: 7 Build time: 00:06:45


Done through passing 0 to NotifyEndDeploy


We can't add parameters in between without breaking backwards compatibility.


That was a typo on my side - should be fixed there:
https://github.com/mnhauke/rtl_433/commit/81029fdfe79c5eebaa1fbf40945938ed568d49ab


Commented code should be deleted.


This looks good, I'll most likely accept tomorrow :)

Thanks


I don't see anything critical wrong, just assignment of read variable, he didn't want to touch all the code I guess


No need to change this until the UI is finalized, I believe we can rely on whether`popoverPresentationController` exists instead of needing to check hardware.


Its been fixed in PR from a while ago.


It gets called by VS when a project gets loaded and when a user selects the target (see below). It should always have a value.
![capture](https://cloud.githubusercontent.com/assets/8389594/12567486/3763d1f6-c374-11e5-926f-3fd696298d85.PNG)


ID should be camel case, I believe.


@erwint We tend to favor using GerritHub more than Github PRs ( https://review.gerrithub.io/#/q/project:repaint-io/maven-tiles ) with additional patchsets rather than multiple commits.  I though Github shows the CONTRIBUTING doc before creating PRs?

That being said, all contributions are welcome :)


 We are compiling against forge 1230 and Java 1.8 with 1.6 compiler compliance. What you said looks fine to me.
Yeah, I know there aren't any instructions here. Sorry about that, but we weren't really expecting anyone to compile releases from here.
Can you run this jar for me and tell me if there's still a problem?
https://www.dropbox.com/s/96n0rcz5afzsk8v/MineFantasyII-TestBuild-2.5.6.jar?dl=0


Check page 196 for the equation you derived, so we can cite them for this.  Nice work on that.

What you call probability in equation 9 of ms.tex should be encounter rate...

mean encounter rate is independent of the nest distribution, but time until the next event is not.  so we have to make an explicit assumption about that.  if we assume spatially random nests, time until next event gets drawn from an exponential distribution with rate parameter λ = encounter rate?


Great job, and looks great!


good


no, if so, then const& but for sure not const, but it's not needed there, it's minor, it's not some big structure


+1 - though i don't understand the impact of the async call


are you sure this doesn't break te switching from other modes?

i.e. the real problem is not the texture values of the texture, it is the fact that metal view uses a different `texture combining mode`


I should take it out for release. It can still be used but it's probably confusing to leave it in by default.


For user it is more intuitive to click at Cancel button, when user want to quit without saving the changes.
It is added to all add and edit forms, after clik there will be redirect to index page.


Dear friends,
I  just upgradet ot GregorioTeX 4.1.0 and got this erorr that I show
with this almost minimal working example;

% !TEX TS-program = LuaLaTeX-SE
% !TEX encoding = UTF-8 Unicode
\documentclass[a5paper]{article}
\usepackage[a5paper]{geometry}

\RequirePackage{fontspec}
\defaultfontfeatures{Ligatures={TeX},Numbers={OldStyle}}
     \setmainfont{Linux Libertine O}

\RequirePackage[autocompile]{gregoriotex}%
\RequirePackage{gregoriosyms}

\begin{document}
This snippet used to work perfectly before GregorioTex 4.1.0-beta1:
{\small
\begin{verbatim}
\gabcsnippet[0]{(c4) (f) (gh) (h) (h) (h) (hr) (hr) (hr) (hg)
                 (ixgi) (h) (hr[ocba:1;7.5mm]) (hg) (gh) (;) (h+z)}
\end{verbatim}
}

Now it produces an error:{\footnotesize
\begin{verbatim}
l.13 }{}{\GreSetNoFirstSyllableText}{}{\GreUnstyled}
{1}{\GreSetNextSyllable{}{...
\gre@gabcsnippet@option ... "initial-style: #1;")}

l.11 ... (h) (hr[ocba:1;7.5mm]) (hg) (gh) (;) (h+z)}
\end{verbatim}
}

The same error is produced even if the deprecated \verb|[0]| is deleted.
If after the error you press the S key, the job terminates, but this is
the result:

\gabcsnippet[0]{(c4) (f) (gh) (h) (h) (h) (hr) (hr) (hr) (hg) (ixgi) (h)
(hr[ocba:1;7.5mm]) (hg) (gh) (;) (h+z)}

Apparently the code that produces the actual \TeX\ code contains
something such as
\verb|...{\GreUnstyled}{1}| instead of \verb|...{\GreUnstyled{1}}| since
\verb|GreUnstyled| command
requires a mandatory argument; just a misplaced closed brace but, sorry,
I can't find out where this happens.
\end{document}

May be the error is in the Lua code, but I have no hint to suggest.

Forgive me for being unable to give a more accurate diagnosis

Claudio
On 21/01/2016 03:29, Br. Samuel Springuel wrote:
>
> I might still point out that |\p@| is a form of 1 used to increase the
> accuracy of the calculation. I know that without some reminder I'll
> eventually come back to this code and scratch my head about why it's
> there.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/henryso/gregorio/commit/966e508f9af52b3cb2e45391c4acf87d00e37ab6#commitcomment-15575402>.
>


@cleverpanda `[Client thread/INFO] [FML/]: FML has found a non-mod file MineFantasyII-TestBuild-2.5.6.jar in your mods directory. It will now be injected into your classpath. This could severe stability issues, it should be removed if possible.`


@russellsayshi Does color correction work *already*?


Avoid whitespace between function identifiers and argument lists. `itsLikeThis() {` and not `likeThis () {`.


(nit) go package names should be lowercase (https://blog.golang.org/package-names)


Same as the above, when calling functions. `size(50, 50)` and not `size (50, 50)`.


Will this continue to work properly for a non-native loader in a page that hasn't been marked as having utf8 encoding?


At minimum, extract important Strings like this into a global constant. eg:

`final String FILENAME = "alice30.txt";`


README is in progress. Please feel free to add to any part of the README.


Real +1 - Jonathan explained :)


Shouldn't GCR have been updated with a new image v0.6 tag?

```
$ curl  https://gcr.io/v2/google_containers/heapster_influxdb/tags/list
{"name":"google_containers/heapster_influxdb","tags":["v0.3","v0.4","v0.5"]}
```


Don't think you want to return here before showing the no matches message?


That sounds familiar. I believe I did the same.
On Jan 25, 2016 5:24 PM, "Robin Newman" <notifications@github.com> wrote:

> Thanks for doing this Jeremy. I should reiterate that I certainly DID have
> to remove the vendor section for rugged to get SP to use the correct
> location for the compiled rugged.so file. having done that, there was
> indeed no need to move any .so file to rb-native.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/samaaron/sonic-pi/commit/012063207069141d7f4f3eb0b9bc96abd46767cb#commitcomment-15663138>
> .
>


Hmm... Im going to have to do some testing as well...  Thanks for the info.

On Mon, Jan 25, 2016 at 5:39 PM, Alex Cruz <notifications@github.com> wrote:

> Interesting @varund7726 <https://github.com/varund7726>
>
> I just checked RR's source and is line for line the same. Not sure why is
> working for you and not us. Might have to revisit this when I have a bit
> more time, thanks for the heads up tho!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DirtyUnicorns/android_frameworks_base/commit/7dac20b8f9399c4ff9775dc77fe713d6e0c9e4ea#commitcomment-15663480>
> .
>


It looks like this field is never populated? Is the intent to fill it in later? In either case, I think it should probably be `omitempty`


112331505_SurfaceHeightRange (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (2057 of 2057 tests passed, 0 test warnings)

 * 6 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


##traffic


4th time I'm seeing webkit /moz radial gradients. Would consider making this into a mixin


feature_initializer_list_conversion (vrennert) - i386-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


feature_initializer_list_conversion (vrennert) - Win64-Windows-7-VisualStudio-14: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


I think we're going to need to do some more testing for Python 3; I haven't actually run it with >= 2.7.9 yet


I think you should just return the error in this case?


nice..I'm a fan of only passing params in when they can't be accessed through other methods


I saw the squared inputs thing, i would just leave it at the default value of true. If it ends up being horrible, we can just change it later.


![screen shot 2016-01-25 at 6 13 00 pm](https://cloud.githubusercontent.com/assets/5640772/12567889/cf20c178-c38f-11e5-8d12-cf7ddf162106.png)


(nit) inline: `return newStorage(machineName)`


I use MOUSE3 too. It's why I had fixed it in the first place.


Does it work on Android?


feature_initializer_list_conversion (vrennert) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


feature_initializer_list_conversion (vrennert) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


feature_initializer_list_conversion (vrennert) - x86_64-Linux-Ubuntu-14.04-clang-3.6-AddressSanitizer: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Is this just a local update or pull from Transifex? Cause I see things that should have been updated but are not.


feature_initializer_list_conversion (vrennert) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


I took it from `make`:

    -n, --just-print, --dry-run, --recon
                              Don't actually run any recipe; just print them.


feature_initializer_list_conversion (vrennert) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


this should fix #7 definitely


feature_initializer_list_conversion (vrennert) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


We still need pip2pi and ansible to do automated pip packaging and deployments for private code repos.


What's the logic for not using the default of 3 retries?


In this case, the return is desired.  The assumption is the delegate (if it implements the method) will make the relevant decision about what to show the user.  If the delegate does not implement the method the default SVProgressHUD prompt is shown.
TBH I want to get rid of all the SVProgressHUD calls and do something like #3750


feature_initializer_list_conversion (vrennert) - i386-Windows-7-VisualStudio-12: OK (384 of 385 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


Typo


As talked offline the IsInt part is a little bit confusing but other than that the change LGTM.


That's a good question. I was going to pass this change by the Google team before merging it in because I wasn't sure why these were entities instead of text (maybe for JS that isn't served as UTF8)?


del


(nit) remove this blank line (to associate the error handling)


@TheHollidayInn _.pull doesn't work with mongoose docs


user.guilds is an array of plain ids not of objects


or pretty amazing


@TheHollidayInn here it wasn't checking for the right property


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12673](https://teamcity.mesosphere.io/viewLog.html?buildId=112368&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:09:32


that indentation


We literally pass it to swiftc as -Xcc though. Seems consistency should win here.


I'm investigating whether this is going to be a big problem for all the client libraries we run at FB. At first glance, it appears that the only one affected is the Presto client and jdbc driver.

I was thinking we might want to apply just this change as a separate PR that we can roll out in the next release in preparation for merging the rest of the varchar changes once the clients have been updated to use the new version of the driver.


Change this to headers.


Your code sucks.


Would consider writing this all as one string. Faster than parsing through jQuery methods.
Would also open it in a new window since you are navigating away from the page:
     return ''+this.name+'';


I really don't like the idea of adding an extra round trip to query the time, when the client didn't request it, and the client's clock is likely to be sufficiently accurate.

So our options I think are:

- query the time if the specific error response from the system indicates a likely clock skew. In general the client should rely on the expiry indication from the server where it can, instead of decding for itself whether or not the token has expired.

- if we think the margin for token generation (currently 2 minutes) is too narrow to cover most realistic scenarios then it can be increased;

- the library can use the `TokenDetails.issued` time to set `serverTimeOffset` if it is successful in getting a token.

- we could very easily have the realtime system include a reference timestamp in any related error message, which could be used to determined `serverTimeOffset`.


The package task at the end doesn't fire properly.


Matt, you should add `add_action( 'network_admin_notices', ... );` so it show a multisite notice.


You are right, I was distracted. This should be ok.


feature_initializer_list_conversion (vrennert) - Win64-Windows-7-VisualStudio-12: OK (384 of 385 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


There's also some registrator/consul cleanup. A lot more tidier now


feature_initializer_list_conversion (vrennert) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Sounds good. Or even link to a (new) place in the documentation that talks about known backend implementations.


> @mattheworiordan the issue is RSC14d (the token has expired *or* the server has responded with a token error) -- ie clients check if the token has expired themselves, so time matters for all clients, not just servers. (If we want to change that and rely just on realtime telling you you've expired, now we have that working reliably, we can, but that's what the spec says at the moment)

I think this thinking is wrong unfortunately. The timing issues of most clocks being out by say even up to 60s (which is huge) is largely unimportant.  For example:

* If a token request is being signed and sent to a client, then it is going to be from a server in 99% of the cases so timing issues are far less likely.  Added to this, we allow for 2 minutes either side anyway, see http://docs.ably.io/general/authentication/#token-request-spec
* If a connection is established with a sever-generated token and the local clock is out (forwards or backwards) by up to say 5 minutes, yet the token expires in 1 hour, the client will use the TokenDetails and connect because it's valid.  When the token expires, the client is not going to pro-actively detect that (according to the spec) and will simply wait for the server to tell it when the token has expired.
* This same applies to REST requests, given the default TTL is 1 hour, an insane few minutes difference in the clock will not really be relevant as the tokens will mostly be valid anyway.

No where in the spec does it state that we should be doing server time requests unless the developer explicitly requests that, and I think we should stick to that.  If however in our test suite we are seeing issues with this because we are testing behaviour with very short abnormal TTLs, then yes perhaps the test suite should sync the clock at the start of the tests so that the clock differences are irrelevant in regards to tests only.


Посмотри вот этот метод:
http://www.w3schools.com/tags/canvas_measuretext.asp
 this._ctx.measureText(sizeXY)


@paddybyers seems our messages crossed, but largely we both feel a server time query is unnecessary I believe?


@hhanke what about just calling:
`
self.view.accessibilityElementsHidden = hide
`
or
`
self.navigationController.view.accessibilityElementsHidden = hide
`

Thinking that we shouldn't invoke the app delegate if we don't need to - and it seems like the only thing you want to affect is the current instance of WMFArticleContainerViewController and the navigation controller it is embedded in. Is that correct?


does there need to be a corresponding call in `viewDidDisappear`?


Do we also need to post a notification when the share sheet is dismissed?


Would think about moving this to it's own file to be imported, so that you don't have ~200 lines of code that are just an object


> largely we both feel a server time query is unnecessary I believe?

yes


Wonder why these PDFs arne't digitally signed? Anyone could change the scores


Patch amended!


nice! blogpost incoming?


very nice


:+1: Thanks @ericguirbal @uggla !


The reason why it isn't working is
https://github.com/rit-sse/api-client/commit/988b43d82fb54465586917a63267f7314d7159ff#diff-6485c5dd65506041ffa27a871441132dR14

Throwing the error means nothing is returned and the promise is unresolved.

But don't worry about it and just apply the fix from the above comment.


TeamCity Waterfall :: Build [Build 22](https://tc.demonwav.com/viewLog.html?buildId=211&buildTypeId=Waterfall_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 43 Build time: 00:01:09


LGTM.


Revisando lo hecho anteriormente.


Hopefully in a few mins :-).


OK the recompiler problem seems to be that it's running the wrong VU program, it is loading the first one it makes, hence the repeated first result (which is wrong on subsequent runs). If i force it to recompile each one it comes out perfectly, but as far as I can tell everything else is fine. So now I need to work out this hash bucket crap..


I think that not needed use es2015 for testing
It generate more eliminated functions, that need tested
What you think - are this change OK?