The "Get it on Google Play" button seems to be outdated - old logo. I guess it is better to use the button below from [Google](https://play.google.com/intl/en_us/badges/). But I am not sure about using external assets here on the other hand.

 ![Get it on Google Play](https://play.google.com/intl/en_us/badges/images/apps/en-play-badge.png)


This should be `widget::layout_changed`.
Rule of thumb: If `:draw` does something different than before when called with the same(!) arguments, then `redraw_needed`. If `:fit()` or `:layout()` would return different things, then `layout_changed`.
If the layout actually changes, the whole(!) widget is redrawn. If the layout stays the same, nothing is redrawn.


> So rather than worry about guaranteeing we won't change the passed in string we just change the convertedString/out string so we can still guarantee we won't change the original text?
Right :) It's good to use `const char *` where you don't want the string to be changed, but it's still fine to use `char *` if you *do* want the function to change it. The constness is more a detail for the programmer so they know what the function will do with it.

The const_cast stuff won't cause any problems, but it's more a code cleanliness thing more than anything else.


新博文


@blueyed will tell you to use `@tparam boolean draw_empty` instead, I bet.


Importing only what's needed.


Imports on separate lines and alphabetized for maintainability.


Ahhh, the default is `nil` and Lua says `nil ~= false`, so the default behaviour is still the same as before and my comment below was wrong. Quite a trick, but fine with me, I think.


Trying to keep everything within an 80-column width.


// Creating a new outgoing call without notifying CALL_STATE_CHANGED.


Commit message: introsuce

Github says the file doesn't have a newline at the end.


ok


I'd propose `Add a rounded rectangle to the current path` to avoid the word `Draw` (same for the other method).


Per [EditorConfig Supported Properties](http://editorconfig.org/#supported-properties):
> **indent_size:** a whole number defining the number of columns used for each indentation level and the width of soft tabs (when supported). When set to “**tab**”, the value of **tab_width** (if specified) will be used.


+1 for _i18n(string). Seems to be the best of both worlds: short and it's clear what it does.


I'm not really sure that I get this, but shouldn't this be `math.min(width, height) / 2` instead of `height / 2`.


I'd personally prefer the curly braces and the return. The first example is quite cryptic.

I agree we should have a consistent way of doing things across the lib.


The Node way of parsing a file name with [`path.basename`](https://nodejs.org/dist/latest-v5.x/docs/api/path.html#path_path_basename_p_ext).


If `radius > width` or `radius > height`, then the result will be really weird. Should that case be checked for? And print a warning? And set a smaller radius?


Fixed the spacing, mostly to spend time reading the code. Sorry if the diffs make it difficult to grade.


Returning early.


ok. !!e.stop() => true

Why you return true?
I don't understand this code


Oh.. The rails. I'll right go on it


Much better indeed.

Wow, really verbose rules. Makes me wanna learn Russian. Or maybe not? :sunglasses:


ff


ddd


Using a hash instead of a switch...case or a series of "if" statements that check the same value.


このコミットに関連するタスク
https://www.wrike.com/open.htm?id=75931281


`.toLowerCase()` ensures `CR` and `CRLF` settings are picked up.


Could you install ldoc so that ldoc complains to you about broken documentation? (Should be `draw` instead of `c_or_w`, although I consider both names weird, but don't have better suggestions)


ok, will try, thank you


No problem.

By the way, do you have any recommendation for bottom refresh library? I use DGElasticPullToRefresh at the top for data refresh and when I scroll to the bottom, I hope to load more data.


Could the same be added for the other shape whose name I forgot?
Also, could you (try to) convert `awful.client.shape` to use this? To test `awful.client.shape`, you can use `xeyes` (it is what makes xeyes look not-stupid).


This should be moved to the commit adding `gears.shape` (whoops, I didn't notice it there)


I am confused by this commit. The library will not compile for a teensy now because SIM_SOPT1_OSC32KSEL(x) is not defined anymore. Am I missing something?


Eureka. Solved - I found a way to automate the IP address. I tried in vain to get an environment variable into the runtime, so took a different approach. (I actually was able to read an env var in a couple ways, but neither would work to distribute.)

The solution is to add a run script that writes the computer's wifi IP address to a file in the app bundle directly during build, and to only do that when running a Debug build:

```rm -f ${BUILT_PRODUCTS_DIR}/${PRODUCT_NAME}.app/ReactNativeServerConfig.txt
if [ "${CONFIGURATION}" == "Debug" ]; then
  touch ${BUILT_PRODUCTS_DIR}/${PRODUCT_NAME}.app/ReactNativeServerConfig.txt
  echo "`ipconfig getifaddr en0`" > ${BUILT_PRODUCTS_DIR}/${PRODUCT_NAME}.app/ReactNativeServerConfig.txt
fi```

Then in AppDelegate I've written code that will read that file and store it to an NSUserDefault, only in the case that you're debugging on the device if useBundle is not active.

I can put a PR together that would allow us to test this out.


Is this the same file that's on snap.b.e?


@param[opt] shape Function used for shaping
(Hm, that's a really bad description...)


@rainautumn можно так, но смысл этим всем страдать для персонального бложика?


I'd propose to get rid of this `f` stuff and to just do a `cr:clip()` here. I *think* that should have the same effect (but I am not totally sure)


也许是维护者不太了解。你可以去评论一下。


almost good just -1 doesn't include files which starts with dot ('.') and os.listdir includes them.

```listdir(path) -> list_of_strings

Return a list containing the names of the entries in the directory.

    path: path of directory to list

The list is in arbitrary order.  It does not include the special
entries '.' and '..' even if they are present in the directory.```


Hast Du auch mal geschaut, ob das lat-delta und das lon-delta immer passend sind, dass wurde ja hier für Barcelona gewählt. Ich könnte mir vorstellen, dass in kleineren Städten das zu Überschneidungen führen kann.

Sprich man könnte das lat-delta und lon-delta auch noch für jede Stadt definieren. Und den Array dann so gestalten:

[45.1, 11.4, 'Entenhausen', 0.55, 0.90]

Und das dann mit initialiseren und in die Url als string einfügen.


100MHz wouldn't compile and 50MHz is all you need for max SPI speed on the F3 since maximum possible SPI speed is only around 20MHz or so.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11830](https://teamcity.mesosphere.io/viewLog.html?buildId=106881&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:03:52


typischerweise schreibt man farben klein, sprich 'lavender'


This part isn't needed anymore, I think. The `if not idx then return nil end` below catches everything. (Sorry, that's what I meant with my other comment).

However, this part doesn't hurt either, so: fine with me: :+1:


this is a 3-days ago commit … and would you revert your temp fix ?


/make: resolve issue: https://github.com/astaxie/beego/issues/1251


¬¬ @DavidPhilip


Change


You need the latest Teensyduino 1.27 its defined in the core now. Sorry I should state that in the readme.


I don't think that method doesn't belong here. I would put it under Filesystem, and call it 'touch'


I should have provided better guidance for where to put `RelationshipType`.  You'll need to move it from *TrackableEntities.Common* to **TrackableEntities.EF.5**.  Things in Common are there because both client and server need to reference them.  But `RelationshipType` is only needed for calling `ApplyChanges`, which is done on the server only.

Then right-click on **TrackableEntities.EF.6**, select *Add Existing Item*, navigate to *TrackableEntities.EF.5*, where you placed *RelationshipType.cs*, select the file and and choose **Add As Link**.


**Line is longer than allowed. (90 > 79)**
*LineLengthBear, severity 1, section `pythoncheck`.* *Related to file `coalib/output/ConsoleInteraction.py`, line 242 column 80 to line 242 column 91*.


Ok, an update. It seems that in Sailfish 2.0 they re-designed the notification model to set the transient flag on the preview and summary notifications that pop up in the bubbles. The ones logged on the events screen are separate ones that contain only serialized notifications of some sort. I'm still trying to find concrete documentation on it, but this would get rid of the '2 new message' ones that folks dislike so much. I'm trying and speak to a dev about how they think this should be done, because if there was a way to get notifications straight from the events screen, then that might be better and more compatible with the timeline API.


Might possibly want to support lookup for all possible suffixes here?


To be more consistent, you need to rename "admin.contact" by "admin.lotto_number". The important thing is to keep config key names as tight as possible.


dddd


A unicode string = UTF-8 formatted string IS NOT the same as a python unicode object
We should convert all strings to python unicode objects


Maybe refactor this to use a label/text box for the user to enter a fully customizable suffix


The comments are not correct. Refine them.


what does it mean "local directory", you are working with Host. anyway I think that mount is not only about NFS ... you can mount physical device, you can mount image, ... I would put it under Filesystem too .

When I see NFSService I would expect something what manages nfs server, like export_dir, list_exports, unexport_dir, ... or something like that


why is MessageIdComputer (I'm not a big fan of the name btw, I'd prefer something like MessageIdGenerator) not used as a class variable in MailStatus instead of created everytime. I don't see it holding a state.


This is touched upon on the date of 18 January 2016


Commit message ("Implemented batch subcommands") doesn't match what you are doing (changing something backup related)


LGTM


Ohhh, I hadn't thought about this version before, but I think it's actually nice. All widgets now inherit this!


Hi @YuriyYevsyukov .

I don't think it's a bug.
Because we are taking an optimistic approach so the bufferSizeHighWatermark start at DefaultBufferSize.

As you can see inside the function in case there is a BufferUnderRunException, we increase the value of bufferSizeHighWatermark so in the next time we will not have this exception again.

Why you are thinking it a bug?


Sehr cool! Bitte lass mich wissen, wenn du dafür bereit bist, dein Fischertechnik API auf der Snap! Homepage zu verlinken...
Vielen Dank
Jens


Related thread: https://github.com/facebook/react-native/issues/1597


``return len(self._selectedPages) > 1``


@japgolly Unfortunately It WAS covered by tests. The biggest problem is that we have broken tests right now, so one more broken test doesn't look like something critical and urgent. Situation has no excuses, so I will not give you any promises, I'm just going to fix it right now.


Thanks. It's been lots of work, I think. I don't use chromium much, but it's an important package IMO.


oops my bad , i understood the code wrong........


Parameter tweaks can be run as SPRT[0,4]


TeamCity pull requests :: netty [Build 1046](https://garage.netty.io/teamcity/viewLog.html?buildId=4825&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6372, ignored: 23 Build time: 00:42:49


A private attribute shouldn't be accessed here. Either make it public or (preferably) add ``addSelectedPage()`` and ``removeSelectedPage()`` methods.


All pc2bytesX variables below should be declared in this scope, right?


I see a lot of replacement of message.getMessageID()  by messageIdComputer.compute(message). Wouldn't it be possible instead to override the getMessageID() (or add a new method such as getUniqueMessageID()), that would look better from a design pov. I'm probably missing a reason but I thought I should ask.


Why this commit committed by a root user?


This will also need to have conditional directives added:

```csharp
#if EF_6
namespace TrackableEntities.EF6
#else
namespace TrackableEntities.EF5
#endif
```


Recommend only use bold font once when it first appears instead of using bold font multiple times


done


Done. -but i added an override (!important). After deleting the inline font-size a font-size:24 was being applied and i couldn't tell where it was coming from...?


by me and @dr-j


https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Array_comprehensions
Says that 46 removed support for the old js 1.7/1.8 comprehensions, but AIUI, the new form is still supported, so replacing with the new form should work. As I read it, the new form is supported since FF30, so it's not a problem to use it.
So I'd rather switch to that instead.


It doesn't include . and .. only a list of names of the entries in a directory


TeamCity pull requests :: netty [Build 1047](https://garage.netty.io/teamcity/viewLog.html?buildId=4828&buildTypeId=pulls_netty&guest=1) is now running


should have a space in **,then**


Good point! I thought I'd catch this by testing with 3.x and 2.7 ...


Ok, so apparently we do need this and it cannot be based on a `wibox.hierarchy`...

Why is `:get_children_count()` necessary? Why would it ever return something else than `#w:get_widgets()`? And why is this actually the case for e.g. background? Can't we just remove this?

Also, I still think `:get_children()` (why is it `:get_children_count()` and `:get_widgets()`? They should have a common name prefix) should not be recursive and the recursive variant would be (wow, widgets now even inherit this...):
```lua
function wibox.widget.base:get_children_recursive()
    local to_return = {}
    local left_to_handle { self }
    while #left_to_handle > 0 do
        local w = table.remove(left_to_handle)
        table.insert(to_return, w)
        left_to_handle = util.join(left_to_handle, w:get_children())
    end
    return to_return
```


Hi Oliver,

This is brilliant! :-)
I'll look through the changes ASAP.

Best regards,

--
Harald K


Please don't touch the version number in this commit.


personalid is always fixed for a single user session(for whatever duration before a timeout/disconnect) although there might be a few edge cases(may be only one or two) where a user rejoin and get a new personalid.
The suggestion is good although I will take it post first phase of REST API development. Reasons are
1- We don't have yet a authentication strategy in place which would be a must before we choose this path
2- Right now our focus is to make the initial implementation stable for first cut of REST APIs and take such enhancements later

I know that same discussion is on going on our One Note document and perhaps same answers applies to it as well.


The limitation only applies to projects which are _directly_ under the workspace root folder.


Fine with me, I guess. But I will (try to) complain if some widget inherits from fixed, but ignores `spacing`...


Done. исправил сори, ты был прав, что-то меня переклинило


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11831](https://teamcity.mesosphere.io/viewLog.html?buildId=106915&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:09:42


Related thread that touches some of the same files (PR that didn't make it through review for configurable port) https://github.com/facebook/react-native/pull/1546


Thanks Xanland!

However: You have to be online for at least 48 hours to use the regular-chat, and you have to be registered.

That should be adjusted to 50 hours.


Lol good attention span Dougley


Why  not return `request.getKeyTypes()`?


For now the only changes to `DbContextExtensions` should be:

a) Removal of `RelationshipType `.

b) Addition of two new overloads of `ApplyChanges`, as specified in this [comment](https://github.com/TrackableEntities/trackable-entities/issues/106#issuecomment-172376855):

```csharp
public static void ApplyChanges<TEntity>(this DbContext context, ITrackable item, Func<TEntity, RelationshipType, EntityState?> stateSelector)
{
}
```
```csharp
public static void ApplyChanges<TEntity>(this DbContext context, IEnumerable<ITrackable> item, Func<TEntity, RelationshipType, EntityState?> stateSelector)
{
}
```

Neither of these should have any implementation at all.  And there should be no other changes to `DbContextExtensions`.  This will ensure that all tests for these two methods will fail.


> Why is :get_children_count() necessary?

I guess it is not anymore. I simply wrote it first. I will remove it from the next version

>  :get_children()
It is how `awful.fixed` and `awful.flex` called it internally, I will rename it


What's `k`? This will end up looking into the global env for `k`.


return `request.getPrincipals()`?


done


You're right. Isn't necessary return.
It was left from the reorganizing code.


The label is somehow long... I'd rather it appear only if the user is subscribed to Pocket, too.

Come to think of it, maybe a global checkbox that makes closing tabs save them to pocket would be useful.
Or, actually, a separate addon that just stores closed tabs to pocket. Or even, why not make this an option in firefox itself?


Эта функция нигде не использовалася


an un-authenticated person. Pls see my response above on of : '/conferences/{accesscode}/participants'. Line no 65.


Good question. This used to be an issue, but not so much any more with the
state of Ruby and JS linting.

I do share my prefs with my team members sometimes, but I've come to the
conclusion that's it for sharing, rather than project inclusion.


throws MailboxSessionCreationException, NoValidAuthHeaderException


Эта функция нигде не использовалась


Add a local boolean `self_changed`, set it to `true` here and move the signal emitting to the end of the function, please.

Also, don't randomly mess with the details of a random widgets. This should be:
```lua
if l ~= self then
    l:remove(rem_widget)
else
    assert() table.remove() signal() -- The same code as now
end
```


Turns out you were right @angelblue05 !

I did this:

string = addon.getLocalizedString(stringid)
    if isinstance(string, unicode): print "EMBY LANGUAGE STRING IS UNICODE !"
    elif isinstance(string, txt): print "EMBY LANGUAGE STRING IS TEXT !"
    else: print "EMBY LANGUAGE STRING IS UNKNOWN !"

and guess what was printed in the log... UNICODE

So, all Kodi api methods return UTF8 strings except for this one, it returns unicode.

Now, let's dig through the code for any other spots where this good be wrong.


#6 : Added 3D Vector class to the Engine


I never saw a table with a negative number of entries. This is just `return ret`.


我那個是在nginx 上的owncloud 環境commit 的 那我有需要換回ubuntu 再commit 一次嗎？

Wilson <notifications@github.com> 於 2016年1月18日 星期一寫道：

> Why this commit committed by a root user?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/inwinstack/owncloud-sharing_group/commit/1cec35f3de4e400bad5a02fab1b1d0294f9725e0#commitcomment-15501168>
> .
>


but I am talking about files '.xyz' ... see difference

```
In [5]: Popen(['ls', '-1']).communicate()
a.patch
AUTHORS
build
dist
LICENSE
MANIFEST.in
python_rrmngmnt.egg-info
README.md
rrmngmnt
rrmngmnt.egg-info
setup.cfg
setup.py
tests
tox.ini
Out[5]: (None, None)
```
versus
```
In [6]: os.listdir('.')
Out[6]:
['setup.py',
 'AUTHORS',
 'rrmngmnt.egg-info',
 '.travis.yml',
 'LICENSE',
 'MANIFEST.in',
 'python_rrmngmnt.egg-info',
 '.gitignore',
 '.git',
 'rrmngmnt',
 'a.patch',
 'build',
 'tox.ini',
 '.tox',
 'tests',
 'dist',
 'README.md',
 'setup.cfg',
 '.cache']
```

you can see that you are missing files like .cache, .tox, .travis ....


Octree (DeadParrot) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


This is not needed and already implemented based on `:get_children()` in a previous commit.


I'm just curious... any particular reason why cherry-pick master commits to staging instead of merging?


`o[from]` or `o[to]` ?
When will `Array#copyWithin` better than a `for` loop?


`widget_or_index` or only brings problems. I'd make this `:set(index, widget)`.


Maybe add `exit(EXIT_FAILURE)` here too?


Example of this case - /conferences/0151296/participants/9999
What if the client provides a wrong personal id here which doesn't exist.
404 seem to be the best matching error code.
Agree with your point that we can use 404 only in a case where client has requested a resource which doesn't exists. Will recheck this response code in complete API.


Was this intentional? I reverted it so it links to the latest party.


I wish there is a design pattern shared by every CDMA enhancement, so I construct a new handler function as other handler function here. However, I think we can merge the two handler functions now, and try to derive a design pattern when we rebase to a new platform such as Emulator-M :)


I'll quote my reply to the last version since apparently none of it was addressed in any way:

Get rid of the recursive non-sense, make :insert do something sane with invalid indices, turn :replace(index_or_widget, widget) into :set(index, widget) and specify the behavior when a widget is contained twice (easiest solution: Make everything work with indices and document that:index` only returns the first index) and then this seems less insane.


situation is simple, we have only 1.2GB ram left after ROM and Kernel take there allocated cut.
So! when we set sysctl_vfs_cache_pressure to 50, kernel prefer to cache file/dir index/content to RAM!
and to ZRAM if exist, and inflate RAM and we get close to OOM...

Now! you turn on your device, and it's needs RAM to resume all apps and the home app and the lockscreen(systemui) that where stripped from there cache during sleep by process reclaim and other cache cleaners, so now they want there stuff back! and your RAM is full of file/dir cache! :)
So OOM kick in, and low mem killer start to slice and chop low rate apps from ram, and now sysctl_vfs_cache_pressure is 100! so it's time to kick all cache from RAM! and here is the party start.
when user see, is DELAY... and they not happy... = we need to think how to prioritize our needs.

I wish we had 4GB ram... then you can set sysctl_vfs_cache_pressure 30! and have super fast read/write performance as RAM used to help with that... but we stuck with little more than 1GB for real usage...


I suggest deleting this commit from the history.


**Line is longer than allowed. (90 > 79)**
*LineLengthBear, severity 1, section `pythoncheck`.* *Related to file `coalib/output/ConsoleInteraction.py`, line 242 column 80 to line 242 column 91*.


This one actually has a few commits prior to this one that changes the minorbehindpawn code


This should have an underscore somewhere.


Ah allright, they aren't the most beautiful commits :) but this all is sort of for educational purposes :)


Try this:

```
cmake --build . --clean-first --config %BUILD_CONFIG%
cmake --build . --clean-first --target INSTALL --config %BUILD_CONFIG%
```


Clever trick. But is it ever possible for the overflow helpers to be inlined? In that case the generated code is slightly worse.


Try not to use double `\\`


Von Antragsgrün? Bei Antragsgrün müsste dieser Work-Around ja gar nicht nötig sein, da dort das XSS anders umgesetzt ist? Das Problem mit dem ->submitForm scheint doch zu sein, dass der Submit-Button bei MT den Anti-XSS-Token im Button-Namen hat, und man den als dritten Parameter bei Codeception mit übergeben muss.


``skip_option_active`` could be a better name here.


This old DB class really sucks!!!!
I want readbeanphp.com

i am on it

Am 18.01.2016 um 07:30 schrieb Krzysztof Winnicki:
> Warning: mysql_num_rows() expects parameter 1 to be resource, object
> given in
> D:\Programming\www\wamp22ap1\www\wbcegit\framework\class.database.php on
> line 196
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/WBCE/WebsiteBaker_CommunityEdition/commit/b38b465f2728c3e67f2abd5776c1d3f6ab140ec0#commitcomment-15499422>.
>

--
Norbert Heimsath
Mergelstraße 25
45478 Mülheim an der Ruhr
Tel: 0208 55792


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11832](https://teamcity.mesosphere.io/viewLog.html?buildId=106965&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:03:45


Wrong Sphinx syntax AFAICT.


Thanks Vlad! I'll have more interesting stuff for you guys when I return from Tokyo :smile: :+1:


@ndrik tu as vu ça, right?


We usually indent these lines under the second colon in the line above.


By the way, I appreciate the contribution, and I don't mind any missteps you might make.  It's a learning process, and the best way to learn is to jump right in and not be afraid to make mistakes. :fearful: Hang in there and we'll keep making progress. :persevere:


RFC 3261

10.2 Constructing the REGISTER Request
....
 Request-URI: The Request-URI names the domain of the location
           service for which the registration is meant (for example,
           "sip:chicago.com").  The "userinfo" and "@" components of the
           SIP URI MUST NOT be present.


@grainier Shall we add a line comment to the thread sleep by explaining why it is added there?


No, this create a `(_123_)` bar like Apple do in their apps (and I do in the screenshot)

No shapes should handle rotation themselves. If they have to be rotated, then they need a wrapper. I used to try to handle rotation in these function, but I stopped doing that and deleted that code. I have a rotation, scaling and translated wrapper generator somewhere (in my `bling` module?), I should make it more flexible and upstream it. Anyhow, I will update the documentation to reflect this.


move this ifdef behind the FLUSH_LOGGER


Remember? :)
![img_20141030_211553](https://cloud.githubusercontent.com/assets/51264/12386789/28707c46-bdc8-11e5-82b9-8315bb3b6f14.jpg)


done -I think? I deleted the duplicates -just not sure about the directories.


Seems this define is redundant. There is the same above.


Traits folder does not exist.


better knowloage


add space after `//`


Commerce has a very solid way to implement deletion of files and instances, that's why I bring this from there. The next commit cleans it up and renames them. Please check the whole PR when reviewing.


This exception should be thrown, or at least logged.


wut?


Not to forget: Great FLOSS Philosophy discussions on our way back from Salzburg.


Correct. POST operation in this resource is actually going to be merged with "/conferences/{accesscode}/participants"
Will remove  this resource : "/conferences/{accesscode}/participant" from API list


Please simplize the ip and hostnames in your example:

* IP can be 10.0.0.1 for docker host and 10.0.0.100 for docker container
* docker container name can be dockernode1


Same problem for this line.
There are several games with missing file, and it is normal, the file does not exist, now this problem and break it displays an error, then it was going very well before.
Ex in Sh2 and 3 same think
>sys_fs_stat('/dev_bdvd/PS3_GAME/USRDIR/sh2/data/eff_tex/white.tex') failed: not found
{PPU Thread[0x3e] (ShReadThread)[0x0039c9ec]} Exception: Unknown Win32 error: 0x3e6.
(in file ..\Utilities\File.cpp:690, in function fs::file::read)
Please report this to the developers.

This file does not exist, it is normal, there should not be any mistake here.


Split this line to multiple lines for easy to read


test commit


Fix all comments same way.


we can enable sshd in xcat docker image by default


I have no idea what I'm doing with GIT :)


Probably not a pyzord request ;)


why using this strange dir for install packages?


done


don't commit commented code


we can remove this line.


i am not sure this is OK...
as you didnt merged changes to include/linux/bitmap.h that really set all bitmap_* to take unsigned int nbits
it's still:
static inline void bitmap_zero(unsigned long *dst, int nbits)

and same for other friends.... of bitmap_*


Let's rephrase that message while we're at it. What about:

> Regular chat is only available for registered players whom have been playing for at least 50 hours.


create function prototype in `InternalClientInterface` and comment there.


typo 'confirm' -> 'conform', 'your' -> 'you'


As far as I can tell, `evalExpression` is dead code. No need to modify it, just ditch it before doing this change.

(And even if it weren’t dead code, this modification leads to returning `-1`/`0`/`+1`, which is not what was intended.)


Looks perfect. Thanks.


Behaviour of sed greatly differs on the operating system used, existing code works on mac, I'm assuming you're using linux?


Sounds good.


Reference: d6e212339a279838090ace72f6a08d7e3ec0c559


@EgorSobko thanks. Also please remove 'Swift 2.0' section from README


Good idea. I should do it every time I add a new function.


I'm wondering, isn't it the same as `lh#encoding#strlen()`?


simply said: ls -A1 does exactly what os.listdir does.


list comprehension :(


Great idea!


这个修改上机跑过吗？


'Please contact its developer'.


There is ArrayUtils.unshift for this purpose, I will fix.


The check can be done outside the function call. i.e.

```vim
if exists('*abs)
  function! lh#math#abs(val)
     return abs(a:val)
  endufunction
else
function! lh#math#abs(val)
     return return a:val >= 0 ? a:val : -a:val
  endufunction
endif
```


Add java doc describing what this class is supposed to do in method verify?


:metal:


Nit: I think the most readable code should generally go from clear cases to more complicated ones, and in case of comparison from primary criteria to secondary, etc. This would translate into structure like this:

```javascript
if (ms1 < ms2) {
    return -1;
} else if (ms1 > ms2) {
    return 1;
} else {
    // ...
}
```

Up to you whether you want to adopt this or not.


noth.


@jcalovski Sorry my bad, I saw the wrong diff.


1) Use underscore suffix for the private members
2) `relief_notifier` is not meaningful, at least for me. I cannot understand the purpose of the var from it's name.
3) Don't create new cond var here. Move this functionality to the MessageQueue itself. There is already cond var. Just move impl of the `WaitEmptyQueue` there.
3) Try to rename `WaitEmptyQueue` to something better. I can suggest something like `WaitUntilEmpty`


any way to get this backported to 2.0.x?


In addition, i'm implementing clang support


It will be awesome to wrap these as ops.


Should non-public headers be added to the install?


In Python 3 the ipaddress module can be used to check if an IP is private. Perhaps we should use that, and require the Python 2 backport on Python 2?


Octree (DeadParrot) - x86_64-MacOS-10.9-clang: OK (2059 of 2062 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.svg)


Definitely not :) Fixed later in 5f4d58439872ec562cac30b5b210f4d4c0953e6d.


OK, found another one that already returns unicode according to the docs, the addon.getSetting()
Anyway, just checked in some changes at places it was still wrong


```
...../ )
.....' /
---' (_____
......... ((__)
..... _ ((___)
....... -'((__)
--.___((_)
```


done. whoa... these percentages were all interacting with a bunch of other stuff.


es ist kein hack wenn es funktioniert :D


Octree (DeadParrot) - Win64-Windows-7-VisualStudio-12: OK (2066 of 2068 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.9%25-yellow.svg)


We may think about pixelated versus continuous ROIs first. So there will probably come another five operators just with different parameter/return types...


done


You have learned how to convert an image to grayscale, and how to select and process several images to convert them to grayscale and display them. You also learned how to copy an image and save it with a different filename. Now put this all together in one program that batch processes several images, and creates and saves new images (with new filenames) that are grayscale versions of each image.

More specifically,

Your program should let the user select multiple image files
For each image, create a new image that is a grayscale version of the original image
For each image, save the grayscale image in a new file with the same filename as the original image, but with the word “gray-” in front of the filename. For example, if the original file was named lion.png, the new image would be a grayscale image and be named gray-lion.png.
Hint: Start with the Batch Grayscale program that processes many images, and add in code to save those files with new names.


Test Results after making changes:
Test to create vpc tier with nic type as Vmxnet3 ... === TestName: test_01_create_tier_Vmxnet3 | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 161.386s

OK


Regarding version number.
I have been trying to follow _semantic versioning_ since a couple a months -- but old habits due hards ^^'. As you introduce new functions that you want to use in lh-brackets, the version number should be 3.7.0 I think.

Then I also update the mkVba/mk*vim file to add the new files (when there are) and the version number. After that, I can push everything, to be sure there is no regression, then git-tag a new version, that I'll use in the dependent plugins that require the new version. Here, we'll have to update lh-brackets/VimFlavor to request lh-vim-lib 3.7.0.


Why did we remove this? Why do we need `HEAD`, doesn't brew use `HEAD` out of the box?


rename to `castExpressionIfShouldCerce`. Somehow `Registered` name doesn't compile for me in this context, because `analysis.getCoercion` return non null, when `StatementAnalyzer` detected that coercion should be `done` or `inserted` - not `registered`.


No need to override this method. You can simply override getScope() method.


Is a header file that is required by a public header file non-public?  See https://github.com/qgis/QGIS/blob/master/src/core/qgsfeatureiterator.h#L20


So many intermediate files in it. You should not commit them at all.


The description of this commit seems wrong. It adds no new classes, but only expands them and fixes issues.

Also, have you seen the [ImageJ coding style](http://imagej.net/Code_style#SCM_history) page? And in particular the [How to Write a Git Commit Message](http://chris.beams.io/posts/git-commit/) article?


Can you add number chat_id in chat_ids = list()? chat_ids = list() are usernames, fullnames, groups

http://domoticz.com/wiki/Telegram_Bot#Test_Your_New_Bot_and_Get_Your_chat_id
I don't know why don't include number chat_id. I guess number chat_id is simple than usernames.


I think I fixed this too.


we need  to instantiate it on tests that belongs to other packages.


小儿赞助


Tohle bude asi ladící, není-liž pravda? Tedy před nasazením bych odebral.


"the server itself" is better than no proxy?


Octree (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (968 of 968 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-27.0%25-green.svg)


The problem has to be older than these two commits, as I see it in Hydra logs before them.

I just merged to master anyway so that the pre-built libxml2 security fix isn't delayed. `gobjectIntrospection` on darwin doesn't seem to be such a vital failure. If there was a simple possibility to only merge non-darwin, I would've done it (like reverting this pair of commits), but I found none.


Thanks.

I completely forget this pull  request ^^'.
I wanted to investigate why this is happening in the first place but did not have time to do it. Any way, your patch is welcomed!


missing information about scramble


Not sure if `NotifyDataSetChanged` method should be public maybe protected is better?


Thanks for the links. I'm in fact newbie to this...


comments next to it was better aswell IMO


Guys, why was this change performed?

The template system was added at 9b988ee1. Then at commit 45606202 @refractionpcsx2 added `${omodec}` to show combined output mode (frame/field/interlaced) in a single field, then this commit completely removes it.

@ssakash why did you remove it? and why doesn't the commit message say exactly what was broken and how is the change fixing it?

@ramapcsx2 you could at least ping @refractionpcsx2 or myself before merging it since we added and refined it.

And now we have issue #1129 which shouldn't be at all, but somehow still happens.

In general, when there's a PR regarding code which was recently modified by someone, it would be at the very least courteous to ping that guy to ask how to handle the PR instead of just accepting it without any useful explanation. What does "PCSX2: Fix up Video mode detection on GS Frame" even mean?


Why do you like to give a space before parenthesis?

Why do we have a `console.log` here?


These seem very Debian-y. Does regular SA actually default to these? It seems like right now it would be better to not have any defaults so everything is explicit in testing and no one accidentally picks up SA stuff.


list comprehension


the doc said ' subclasses do not inherit their superclass initializers by default', I am not sure if this is why barSpace is not inited? That's werid too because it has default value


Why do we have a console.log here?


why?


Nope, brew doesn't use `HEAD` out of the box, it is using the versioned releases.


YES! That was sooooo delicious :yum:


There is no need to remove this blank line.


Why so much initial spacing? Too much


Oh, definitely :blue_heart:


@javadevelopuser  是的，在测试环进行的


这会生成一个issue吗？


If you are new to Git, then I suggest reading the [ImageJ Git](http://imagej.net/Git) page. It has many links to tutorials, and in particular, lots of links to rewriting history guides. These help to make your commit history easier for others to read in the future, which is very important.


Checkmarx scan results 18 Jan 2016 01:10 UTC -08:00

High
Medium
Low
Info

New
0
0
0
2

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

f0409066932c51a55e98107e3e8cd6d755a01985	@dortal


I think this was me, but this should be `ncol = ncol(data1)))`


If it is important to you, feel free to make a pull request that fixes this in all the make_*.py scripts.


C'est quoi ce message de commit ?


Ah, sorry. I got a bit behind in reviewing and missed that when I was looking through.


Good spot thanks, I changed it without merging because I guess you left a test value "PydiominEnvLanguages"


Hahahaha :P fail.


"w" also truncates the file. "w+" truncates and lets you read back what you wrote. I don't need to read back, so "w" is the correct mode to use here. (I think you are confusing "w" with "r+" or "a".)


TeamCity pull requests :: netty [Build 1047](https://garage.netty.io/teamcity/viewLog.html?buildId=4828&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6370, ignored: 23 Build time: 00:42:16


Why not instantly return true or false, instead of initiated first granted?


MemoryCache sample code
https://gist.github.com/pknam/98466ec459179796da05


I'd insert a blank line here to break up the two operations: adding the sescase parameter, and adding the reg parameter.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11833](https://teamcity.mesosphere.io/viewLog.html?buildId=106971&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:03:56


OK


Do you mind if I grab your commit into main line so that GoSSHa uses current SSH package?


Good question (and the code probably needs more work) : we want a CompletableFuture<Void> to be able to wait for the update to be done but we don't care about the result. I'll  try to make this simpler.


Checkmarx scan results 18 Jan 2016 01:14 UTC -08:00

High
Medium
Low
Info

New
0
0
0
2

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

8037b5d137350c731d5955203a7419d3895f5194	@dortal


removed later anyway and should not have been imported here but in java8 profile.


The python constraint will be added in master, not in a stable release such as 9.0, to avoid retro-compatibility issues for databases already having the issue.


The only change I think you will need to make to get your tests to compile is to call `ApplyChanges` by specifying the `TEntity` argument explicitly, like so:

```csharp
context.ApplyChanges<Product>
```


Good point.

In the future we could move that to a private data member instead.


fixes #2634 even


maybe add correlation list to exception's message?


javac is not able to compile without this


There is no need to use PJ_POOL_ZALLOC_T rather than PJ_POOL_ALLOC_T here. The Z is (marginally) less efficient, so I'd remove it.


Good catch; fixed


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11834](https://teamcity.mesosphere.io/viewLog.html?buildId=106987&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:03:46


nice, is this why the mission isn't starting for me :D (stratis)


it needs to be dropped, I really don't like copy/pasting other's people lib in our code


Checkmarx scan results 18 Jan 2016 01:17 UTC -08:00

High
Medium
Low
Info

New
0
0
0
2

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

8037b5d137350c731d5955203a7419d3895f5194	@dortal


Saying "want to" makes it sound like we might not succeed.


Hey Adam,

I'm sorry not recognizing this border case. At the same time, I'm happy that you pointed it out, so you could round it out to a perfect solution.

Best regards,
István


And @ssakash when you "fix" something which someone else committed not too long ago, at the very least please discuss it with them first.


Good commenting. I know this is mostly copied, but it's a good style, and the example helps.


You don't need to fork this repo as you should be authorized to push directly to this repo ;)


TeamCity LabKey :: Trunk :: Community :: CDS postgres 9.4 [Build 70](https://teamcity.labkey.org/viewLog.html?buildId=297523&buildTypeId=LabkeyTrunk_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 15 (1 new), passed: 33 Build time: 01:12:06
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogAndLinearScales: <no details avaliable>

org.labkey.test.tests.CDSHelpCenterTest.verifyHelpCenter: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyCounts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

##### there are 5 more failed tests, see build details
```


Yeah I found this in the docs:

> If your subclass provides an implementation of all of its superclass designated initializers—either by inheriting them as per rule 1, or by providing a custom implementation as part of its definition—then it automatically inherits all of the superclass convenience initializers.


Thank you.   This was a very useful read.

Technically, we could replace the libp11 (not engine_pkcs11, because engine_pkcs11 only invokes PKCS#11 via libp11) code for loading PKCS#11 modules with p11-kit API (http://cgit.freedesktop.org/p11-glue/p11-kit/tree/p11-kit/p11-kit.h).  p11-kit would basically replace the functionality currently implemented in the src/libpkcs11.c file (4% of the libp11 code) with its own, significantly more advanced implementation.

On the other hand, there are important drawbacks of this approach:
* Another build dependency: libp11 currently only requires OpenSSL.
* Limited portability: AFAIK p11-kit only builds/works on Unix-based operating systems, so making it a dependency would also limit the platforms supported by libp11.  Conditional compilation (supporting the current code for loading PKCS#11 modules *and* the p11-kit API) would break the KISS principle.
* Limited flexibility: Some end-users prefer simplicity for their (possibly embedded) hardware, over the advanced features of p11-kit.
* No apparent benefits: We already achieved identical (please correct me if I'm wrong about it) functionality with p11-kit-proxy.


Updating the template is very sensitive, and now we have it on the release as well. The thing with the template is that once a user has an "old" template at the ini file, it will not overwrite it with the new template, so even if we now restore `${omodec}` to the code as the default, new users will not get it. This sucks.


Octree (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed (1731 of 2100 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-82.43%25-red.svg)


No problem @AlexTr :)


oui mais pas sûr d’avoir compris.

Je fini ce truc pour les parents et je m’y remets.

Je dois compiler toutes les dates importantes du projet, et donc creuser mes archives….

H. van Boetzelaer
////////////////////////////////////////////////////////////////////////////////////////////////
||||||	architect EPF & parametric design consultancy
|||||| 	mobile:	+41763652683 <>
|||||| 	www: 	http://www.proceduralstrategies.net <http://www.proceduralstrategies.net/>
|||||| 	mail: 	hvanboetzelaer@gmail.com <mailto:hvanboetzelaer@gmail.com>////////////////////////////////////////////////////////////////////////////////////////////////

> On 18 Jan 2016, at 09:43, Walid <notifications@github.com> wrote:
>
> @ndrik <https://github.com/ndrik> tu as vu ça, right?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/walidvb/festor/commit/c9d04b829527220e287d1ca609ef2a8d5ce0f6ef#commitcomment-15501415>.
>


Checkmarx scan results 18 Jan 2016 01:04 UTC -08:00

High
Medium
Low
Info

New
2
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

fcd7e827fb86bde141a5e80b4ed6d59d0b7ad9fa	@dortal


Good decision!


We also though about using PUT for dialout case. Although it came out that dialout is also used separately (i.e. UCA) and not always in conjunction with a POST request to get a WebURL of the conference. Which means call to dialout is also creating a resource rather than just updating it.

Here we have three cases which creates a participant in system:
1- Get me weburl and also dialout to my phone [weburl:true flag creates a user and dialout use created personalid]
2- Get me only weburl[no dialout]
3- Only Dialout out to me[dialout:true creates a personalid (or user) so should be post]

I would suggest to keep these three cases together with a flag based approach to avoiding having two operations(POST and PUT) and simply calls for existing and new clients of AWV REST APIs.


Indeed.. if I find the time I'll add a bit more explanation to the home page and then put it on hacker news.. great way to find performance issues :-)


ok I saw e15baffd09ea9cfbbd1df2dbec9d4b9e2c918af3, it is better with this refactoring


This commit removed the `actionsRequestRendering` feature!


If or as?


I''ve a feeling the function could take a key/value table instead


Hmm, actually it was a commit this one merged. Our Git is merge commit hell...


1 Mi == 1048576 (not 1 million).


May I ask a Dev option to disable color on the console. I would like to redirect stdout in a PERL script. Unfortunately I can't easily match string such as `"-- TEST BEGIN"` due to escaped color character (in the middle !)


I'm not the maintainer of this plugin really, just fixed a simple bug, but why do you care hoe chat_ids are retrieved? it doesn't change any functionality of the plugin AFAIK.


ki, Mi, Gi, Ti = ISO binary sizes
k, M, G, T = ISO decimal sizes


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/25640/testReport/) for this commit**


> As I read it, the new form is supported since FF30, so it's not a problem to use it.
> So I'd rather switch to that instead.

The new form will be removed eventually (soon-ish, hopefully), too. It used to be part of the ES6 spec, but got removed before finalization in favor of a more general approach. Since we want to get rid of all non-standard features in the engine, it'd not be useful to use this now.


Let's figure out a good suite of tests for the new `ApplyChanges` overloads ...

In terms of process, maybe just add a single test, such as the first one.  Then implement code so that it passes.  Then we can try adding other tests.

I will think about the kinds of scenarios we would want to have for our tests.


[R/group.R:63:9:](https://github.com/krlmlr/MakefileR/blob/338e8d50b8937bfcc422804091324f2aaaf5230e/R/group.R#L63) *style:* **Use <-, not =, for assignment.**
```r
  rules = list(...)
        ^
```
[R/group.R:74:1:](https://github.com/krlmlr/MakefileR/blob/338e8d50b8937bfcc422804091324f2aaaf5230e/R/group.R#L74) *style:* **Variable and function names should be all lowercase.**
```r
`+.MakefileR_group` <- function(x, y) c(x, y)
^~~~~~~~~~~~~~~~~~~
```
[R/zzz-autoroxy.R:1:1:](https://github.com/krlmlr/MakefileR/blob/338e8d50b8937bfcc422804091324f2aaaf5230e/R/zzz-autoroxy.R#L1) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
{
^
```
[R/zzz-autoroxy.R:8:16:](https://github.com/krlmlr/MakefileR/blob/338e8d50b8937bfcc422804091324f2aaaf5230e/R/zzz-autoroxy.R#L8) *warning:* **Do not use absolute paths.**
```r
    if (grepl("/.*[.]Rcheck/00_pkg_src/.*$", normalizePath(getwd(),
               ^~~~~~~~~~~~
```
[R/zzz-autoroxy.R:14:1:](https://github.com/krlmlr/MakefileR/blob/338e8d50b8937bfcc422804091324f2aaaf5230e/R/zzz-autoroxy.R#L14) *style:* **lines should not be more than 80 characters.**
```r
        warning("Cannot load roxygen2. Package documentation will be unavailable.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat.R:2:9:](https://github.com/krlmlr/MakefileR/blob/338e8d50b8937bfcc422804091324f2aaaf5230e/tests/testthat.R#L2) *style:* **Variable and function names should be all lowercase.**
```r
library(MakefileR)
        ^~~~~~~~~
```


We do need that as it's inside the foreach and the $returnArray will just grow foreach loop. Therefor it's unset at the end of each foreach.


arr is useless.


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/output/ConsoleInteraction.py`, line 242.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/output/ConsoleInteraction.py
+++ b/coalib/output/ConsoleInteraction.py
@@ -239,7 +239,8 @@

 def print_affected_lines(console_printer, file_dict, sourcerange):
-    console_printer.print("\n" + os.path.relpath(sourcerange.file), color=FILE_NAME_COLOR)
+    console_printer.print(
+        "\n" + os.path.relpath(sourcerange.file), color=FILE_NAME_COLOR)

     if sourcerange.start.line is not None:
         if len(file_dict[sourcerange.file]) < sourcerange.end.line:
```


**Line is longer than allowed. (90 > 80)**
*LineLengthBear, severity 1, section `python`.* *Related to file `coalib/output/ConsoleInteraction.py`, line 242 column 81 to line 242 column 91*.


I am not aware of ZK using any such pieces, afaict all radius/height data is either set via metafile, or via colvol override gadget. I was aware of their existence (i assumed they were inherited as a paradigm from blender s3o addon era) - but they seemed way too unclean to touch.


The new parse method means that inputs such as "0." will no longer throw the exception "0 is not a number" but instead throw "unexpected '.'; expected end of input".  This was an unexpected side effect of parsing using `strtoull()`/`strtoll()` so the unit test has had to change.  This is actually a good thing as the previous message, while convenient from a coding point of view, was misleading and, in the literal sense, nonsensical.


For use with rawgit.com and jsbin.


i ve added
https://github.com/tzapu/WiFiManager/tree/master/examples/AutoConnectWithFSParametersAndCustomIP
that shows how you would go about enabling ip change from the web config portal as well


it needs the latest github version of the esp8266 core as well


I just added babel-standalone to CDNJS, you can use that if you like :)

https://cdnjs.cloudflare.com/ajax/libs/babel-standalone/6.4.4/babel.js
https://cdnjs.cloudflare.com/ajax/libs/babel-standalone/6.4.4/babel.min.js


Hi,

I just committed your code to the official codebase. So, now the next thing to do is to test php7 on OpenEMR and see what breaks(check the php log). I recommend working and testing from the most recent development codebase branch here:
https://github.com/openemr/openemr/commits/master

-brady


Thanks :-)


[R/group.R:63:9:](https://github.com/krlmlr/MakefileR/blob/a54c57db88c377b0d42465fca5c93156c51d987a/R/group.R#L63) *style:* **Use <-, not =, for assignment.**
```r
  rules = list(...)
        ^
```
[R/group.R:74:1:](https://github.com/krlmlr/MakefileR/blob/a54c57db88c377b0d42465fca5c93156c51d987a/R/group.R#L74) *style:* **Variable and function names should be all lowercase.**
```r
`+.MakefileR_group` <- function(x, y) c(x, y)
^~~~~~~~~~~~~~~~~~~
```
[R/zzz-autoroxy.R:1:1:](https://github.com/krlmlr/MakefileR/blob/a54c57db88c377b0d42465fca5c93156c51d987a/R/zzz-autoroxy.R#L1) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
{
^
```
[R/zzz-autoroxy.R:8:16:](https://github.com/krlmlr/MakefileR/blob/a54c57db88c377b0d42465fca5c93156c51d987a/R/zzz-autoroxy.R#L8) *warning:* **Do not use absolute paths.**
```r
    if (grepl("/.*[.]Rcheck/00_pkg_src/.*$", normalizePath(getwd(),
               ^~~~~~~~~~~~
```
[R/zzz-autoroxy.R:14:1:](https://github.com/krlmlr/MakefileR/blob/a54c57db88c377b0d42465fca5c93156c51d987a/R/zzz-autoroxy.R#L14) *style:* **lines should not be more than 80 characters.**
```r
        warning("Cannot load roxygen2. Package documentation will be unavailable.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat.R:2:9:](https://github.com/krlmlr/MakefileR/blob/a54c57db88c377b0d42465fca5c93156c51d987a/tests/testthat.R#L2) *style:* **Variable and function names should be all lowercase.**
```r
library(MakefileR)
        ^~~~~~~~~
```


`getSubqueriesInPredicates`?


[R/group.R:63:9:](https://github.com/krlmlr/MakefileR/blob/1b8e87b24bcbe72c4df379e28eb97517bef03307/R/group.R#L63) *style:* **Use <-, not =, for assignment.**
```r
  rules = list(...)
        ^
```
[R/group.R:74:1:](https://github.com/krlmlr/MakefileR/blob/1b8e87b24bcbe72c4df379e28eb97517bef03307/R/group.R#L74) *style:* **Variable and function names should be all lowercase.**
```r
`+.MakefileR_group` <- function(x, y) c(x, y)
^~~~~~~~~~~~~~~~~~~
```
[tests/testthat.R:2:9:](https://github.com/krlmlr/MakefileR/blob/1b8e87b24bcbe72c4df379e28eb97517bef03307/tests/testthat.R#L2) *style:* **Variable and function names should be all lowercase.**
```r
library(MakefileR)
        ^~~~~~~~~
```


> The label is somehow long... I'd rather it appear only if the user is subscribed to Pocket, too.

That makes sense and shouldn't be too hard to implement.

> Come to think of it, maybe a global checkbox that makes closing tabs save them to pocket would be useful.

I'm not convinced of this, though: I don't want *all* tabs that I close to be saved to Pocket, just some. Having to toggle a checkbox every time would be quite annoying.

> Or, actually, a separate addon that just stores closed tabs to pocket. Or even, why not make this an option in firefox itself?

The reason this is nice to have integrated into Tabstats is that this way it's integrated with a nice overview of all the tabs currently open. Also, the critical part is the operation on a large number of tabs. Your proposal sounds like one would have to apply it to every tab independently. At least for me, that'd completely defeat the purpose.

I guess your main issue is that the functionality just isn't useful if one doesn't use Pocket, right? If so, would only showing it if the user is logged in to Pocket perhaps make it ok?


I can add a default port to sync_socket if you want, but for moment, it does not have. 4001 seems a bad value too, as 4000 - 4010 is reserved for multiples instance of Morse - socket request stream.


I noticed it was missing when I looked that up the other day. There are some typo's in the text though.
Could you update it to:
```
You can trigger a new modal inside the current modal. The default behaviour closes the first modal when a second one opens. You can prevent this from happening by adding the <code>data-uk-modal="{target:'#ID',modal:false}"</code> attribute.
```


Well, then I see there two options: Make Cura depend on CuraEngine at
buildtime and generate the file like you said.
Or, as I think other projects also need this generation step, build the .py
at CuraEngine and import it at Cura.
Something like '''from curaengine import protocol''' or whatsoever.

I guess if I'll find some free time I'll try to implement the first one
into Cura and add the second idea into CuraEngine bug tracker.

What do you think?


Octree (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1519 of 1519 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.74%25-green.svg)


Well, 4011 then :-) or 4050 if you want to be safe. Or 3999...


Missing modeline :-)


Align this line with the first left parenthesis on the above line so that it's better visible that this is a part of the same sub-expresion.


This doesn't actually do something. It draws something fully transparent -> no-op


unused variable


[R/group.R:63:9:](https://github.com/krlmlr/MakefileR/blob/5c9546f05dc634ad17b5566e14771bed2e388563/R/group.R#L63) *style:* **Use <-, not =, for assignment.**
```r
  rules = list(...)
        ^
```
[R/group.R:74:1:](https://github.com/krlmlr/MakefileR/blob/5c9546f05dc634ad17b5566e14771bed2e388563/R/group.R#L74) *style:* **Variable and function names should be all lowercase.**
```r
`+.MakefileR_group` <- function(x, y) c(x, y)
^~~~~~~~~~~~~~~~~~~
```
[tests/testthat.R:2:9:](https://github.com/krlmlr/MakefileR/blob/5c9546f05dc634ad17b5566e14771bed2e388563/tests/testthat.R#L2) *style:* **Variable and function names should be all lowercase.**
```r
library(MakefileR)
        ^~~~~~~~~
```


Got exception while project has aggregate target, cause Xcodeproj::Project::Object::PBXAggregateTarget doesn't has product_type method


Checkmarx scan results 18 Jan 2016 01:37 UTC -08:00

High
Medium
Low
Info

New
0
0
0
2

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

8037b5d137350c731d5955203a7419d3895f5194	@dortal


[R/group.R:63:9:](https://github.com/krlmlr/MakefileR/blob/02cbf6a54bab7bd3687414f168c5e1565a6227a6/R/group.R#L63) *style:* **Use <-, not =, for assignment.**
```r
  rules = list(...)
        ^
```
[R/group.R:74:1:](https://github.com/krlmlr/MakefileR/blob/02cbf6a54bab7bd3687414f168c5e1565a6227a6/R/group.R#L74) *style:* **Variable and function names should be all lowercase.**
```r
`+.MakefileR_group` <- function(x, y) c(x, y)
^~~~~~~~~~~~~~~~~~~
```
[R/zzz-autoroxy.R:1:1:](https://github.com/krlmlr/MakefileR/blob/02cbf6a54bab7bd3687414f168c5e1565a6227a6/R/zzz-autoroxy.R#L1) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
{
^
```
[R/zzz-autoroxy.R:8:16:](https://github.com/krlmlr/MakefileR/blob/02cbf6a54bab7bd3687414f168c5e1565a6227a6/R/zzz-autoroxy.R#L8) *warning:* **Do not use absolute paths.**
```r
    if (grepl("/.*[.]Rcheck/00_pkg_src/.*$", normalizePath(getwd(),
               ^~~~~~~~~~~~
```
[R/zzz-autoroxy.R:14:1:](https://github.com/krlmlr/MakefileR/blob/02cbf6a54bab7bd3687414f168c5e1565a6227a6/R/zzz-autoroxy.R#L14) *style:* **lines should not be more than 80 characters.**
```r
        warning("Cannot load roxygen2. Package documentation will be unavailable.",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat.R:2:9:](https://github.com/krlmlr/MakefileR/blob/02cbf6a54bab7bd3687414f168c5e1565a6227a6/tests/testthat.R#L2) *style:* **Variable and function names should be all lowercase.**
```r
library(MakefileR)
        ^~~~~~~~~
```


hello hows u


__forceinline itself is supported by LLVM. It works well if inlined functions being called from the same module (.cpp file) they have been defined in. Problems arise if try to call them from another module. CRender2D::BBoxInScreen() referenced in CBitmapFont::Draw2D() (Font.cpp) and CRender2D::DrawTexture() referenced in CTexture::Draw2DSimple() and CTexture::Draw2D() (Texture.cpp).
Possible solution is to move function definitions from Render2D.cpp to Render2D.h.


WHAT IS THIS?


I just did a search in the new fundraising repo and found that there are no else branches in src/ and test/ at all :)

Personally I prefer the multiline form over the more compact one.


It may be `ombinatoricslib3.svg` link for travis.


The quotes should be on the same line.


[R/cred.R:48:19:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/R/cred.R#L48) *style:* **Put spaces around all infix operators.**
```r
             class="db_credentials", show_warn = .show_warn, force_log = .qlog)
                 ~^~
```
[R/cred.R:67:7:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/R/cred.R#L67) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(show_password){
      ^
```
[R/cred.R:70:13:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/R/cred.R#L70) *style:* **Commas should always have a space after.**
```r
    cat(res,"\n")
            ^
```
[R/cred.R:88:50:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/R/cred.R#L88) *style:* **Put spaces around all infix operators.**
```r
    j <- tryCatch(jsonlite::fromJSON(json), error=function(e){
                                                ~^~
```
[R/cred.R:93:33:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/R/cred.R#L93) *style:* **Commas should always have a space after.**
```r
    required_fields <- c("user","password","dbname", "host")
                                ^
```
[R/cred.R:93:44:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/R/cred.R#L93) *style:* **Commas should always have a space after.**
```r
    required_fields <- c("user","password","dbname", "host")
                                           ^
```
[R/cred.R:105:38:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/R/cred.R#L105) *style:* **Put spaces around all infix operators.**
```r
    plyr::l_ply(optional_fields, .fun= function(x) {
                                    ~^
```
[R/cred.R:106:11:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/R/cred.R#L106) *style:* **Place a space before left parenthesis, except in a function call.**
```r
        if(is.null(j[[x]])) j[[x]] <<- NA
          ^
```
[R/cred.R:130:7:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/R/cred.R#L130) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!file.exists(file)){
      ^
```
[tests/testthat/test_cred_file.R:17:41:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred_file.R#L17) *style:* **Commas should always have a space after.**
```r
test_that("cred_file reads from a file",{
                                        ^
```
[tests/testthat/test_cred_file.R:18:45:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred_file.R#L18) *style:* **Put spaces around all infix operators.**
```r
    writeLines(jsonlite::toJSON(clst, pretty=TRUE), path)
                                           ~^~
```
[tests/testthat/test_cred_file.R:26:18:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred_file.R#L26) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred_json.R:19:18:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred_json.R#L19) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred_json.R:31:52:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred_json.R#L31) *style:* **Put spaces around all infix operators.**
```r
        '"engine":"MySQL",".qlog": true}', collapse="")
                                                  ~^~
```
[tests/testthat/test_cred_json.R:39:18:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred_json.R#L39) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = TRUE)
                ~^~
```
[tests/testthat/test_cred_json.R:46:57:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred_json.R#L46) *style:* **Put spaces around all infix operators.**
```r
        '"engine":"MySQL",".show_warn": true}', collapse="")
                                                       ~^~
```
[tests/testthat/test_cred_json.R:54:18:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred_json.R#L54) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = TRUE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred_json.R:61:38:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred_json.R#L61) *style:* **Put spaces around all infix operators.**
```r
        '"engine":"MySQL"}', collapse="")
                                    ~^~
```
[tests/testthat/test_cred_json.R:69:18:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred_json.R#L69) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:11:47:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred.R#L11) *style:* **Commas should always have a space after.**
```r
test_that("cred creates a credentials object",{
                                              ^
```
[tests/testthat/test_cred.R:20:18:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred.R#L20) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:25:69:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred.R#L25) *style:* **Commas should always have a space after.**
```r
test_that("cred creates a credentials object with a character port",{
                                                                    ^
```
[tests/testthat/test_cred.R:36:18:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred.R#L36) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:49:18:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred.R#L49) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:62:18:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred.R#L62) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:75:18:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred.R#L75) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = TRUE, force_log = NA)
                ~^~
```
[tests/testthat/test_cred.R:88:18:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred.R#L88) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = TRUE)
                ~^~
```
[tests/testthat/test_cred.R:101:18:](https://github.com/acjackman/dbezr/blob/5ac7d918389a2aed532d0f0a8e68dbc95a6ef82a/tests/testthat/test_cred.R#L101) *style:* **Put spaces around all infix operators.**
```r
            class="db_credentials", show_warn = FALSE, force_log = FALSE)
                ~^~
```


This is actually a crazy bug because the `drawDataSet` method of the `HorizontalBarChartRenderer` got never called :-D


yes, tried on Ubunto and Debian with same results.


Updated. :+1: that you did not let this imperfection into the docs.


If we're going to have a discussion along those lines, what I would *actually* like to do is kill libp11 and engine_pkcs11 completely. OpenSSL should support PKCS#11 as a first-class citizen. The APIs which currently take filenames for certificates and keys should accept PKCS#11 URIs seamlessly in place of  those filenames.

One potential way that might be achieved is perhaps:
 - Obtain permission to relicence libp11 under the OpenSSL licence
 - Add libp11 under openssl/crypto/pkcs11
 - Extend the other APIs (especially SSL APIs) to use it as appropriate, for full integration

The relicensing might be a pain point; it might end up being better to reimplement, or to re-use code from something with a more appropriate licence like Alon's pkcs11-helper. But I *really* want to see OpenSSL supporting PKCS#11 natively so that it isn't a bolt-on extra that all applications forget to support.


How the log entry resolves the crash? Please, don'e ever use such words in the commit.


On One note you have mentioned Participant object in an example for resource :(/api/v1/conferences/{accesscode}/participants)
If you see the existing SOAP APIs you would find all mentioned Object properties(in YAML) are needed for existing and new callers as per the way AWV system is designed.

For example there is no concept of 'name' and use term 'displayname' across the system due to the nature of this user property. Name may be what you have registered in MAS/MiCollab while creating the user. Displayname is always what name you want to display in AWV clients and you set this value in clients itself then call the APIs to change in in server db.

We can discuss in details if you have questions on any specific Object properties.

Although I do have some queries on your suggestions which I will post inline on One Note itself.


Please test a gain, as i am not at home and can not test from here.

Am 18.01.2016 um 07:37 schrieb Krzysztof Winnicki:
> |public function field_exists($table_name, $field_name) { $sql="SHOW
> COLUMNS FROM `$table_name` LIKE '$field_name'"; $result =
> $this->query($sql); $num = $result->numRows(); $exists = ($num > 0);
> if($exists) return true; else return false; } |
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/WBCE/WebsiteBaker_CommunityEdition/commit/b38b465f2728c3e67f2abd5776c1d3f6ab140ec0#commitcomment-15499486>.
>

--
Norbert Heimsath
Mergelstraße 25
45478 Mülheim an der Ruhr
Tel: 0208 55792


:100: :)


I think enterprise database is created via `EnterpriseFacadeFactory` and HA database via `HighlyAvailableFacadeFactory`. So checking the classpath should not be necessary. Not sure about the advanced database though.


Attention: This change breaks the template rendering on Django <= 1.7


Delete this commit and the prev one.


Here we change the edition string from `Community` to `community`. Is this ok? Could this be reported to JMX or somewhere else and break backwards compatibility?


Shoulnd't this check conceptually be in `setPath`?  Even if it doesn't make a difference in the end?


I am fine with both. Just remembered https://www.mediawiki.org/wiki/Manual:Coding_conventions#Indenting_and_alignment opting for that "compact" style.


This seems to cause problems with basic nodes, like line or freehand, that now no longer show their output. Setting strokeWidth back to 1 seems to fix it.

Could you explain what this line was trying to solve?


The check for `it.second.present` might not even be necessary, as you iterate over `presentObjects` which hopefully only contains present objects :P.


Same comment here `Enterprise` vs `enterprise`.


This is correct, thank you :)


changed


Hi, you should now use server_ischannel(server, channelname) instead. We do this to support dyamic CHANTYPES in the IRC 005 message.


Its already in pan and will change this once authentication strategy is finalized.
We may not do this change in phase 1 of REST APIs is there is no concrete authentication strategy available well in time.


Don't think that is correct. If you remove that code you will get test failures and this is not the right place to cleanup that mess.


Maybe `toString()` instead of `name()`?


same response as above.


We do not need to make `gamma` an attribute.


We do not need to make `beta` an attribute.


Hi @pattacini,
Thanks for these changes, I think they are really useful. The fixed position of the images had bothered me for a while. Should we one day create `BufferedPort` objects and send the images there, so we can use `yarpview` to display them?

Best, Tobi


for the name maybe ```testImport_kojakExport_csv```


Yeah, maybe it is better to fetch the latest stable release?


Yes. I think its by default Audio and Web. Will check and default it to AW as its the most widely used type.


Yes, that would be a more standard approach, indeed.
Mine was just a quick hack in the end :smirk:


same response as above for userid field.


Can we check row[0]?


same response as above for password field.


табы - зло


This is used only for printing the edition in the welcome message from shell. I don't think this is really important.


Well not exactly, `presentObjects` are all the objects that are contained in the OPC (the name is a bit confusing), while the attribute `second.present` indicates if the object is present in the sense of opc presence under the threshold newly implemented (if an agent is pointing, but is not detect for a few millisecond, the pointing continues).
With this you will record in ABM only the true appearance and disappearance. And pasar will work on this presence (not the one given directly by the OPC).


Simple ReadMe


Same reply as the other case.


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/output/ConsoleInteraction.py`, line 242.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/output/ConsoleInteraction.py
+++ b/coalib/output/ConsoleInteraction.py
@@ -239,7 +239,8 @@

 def print_affected_lines(console_printer, file_dict, sourcerange):
-    console_printer.print("\n" + os.path.relpath(sourcerange.file), color=FILE_NAME_COLOR)
+    console_printer.print(
+        "\n" + os.path.relpath(sourcerange.file), color=FILE_NAME_COLOR)

     if sourcerange.start.line is not None:
         if len(file_dict[sourcerange.file]) < sourcerange.end.line:
```


**Line is longer than allowed. (90 > 80)**
*LineLengthBear, severity 1, section `python`.* *Related to file `coalib/output/ConsoleInteraction.py`, line 242 column 81 to line 242 column 91*.


Well I admit that setting the display only in `agentDetector` suits better for me than creating the 4 yarpview and the 4 connections related.
Can we keep as Ugo just changed it, and if you want to use it through the yarpview, you just: `showImages false` ?


Why?  You don't like non-member functions?  At least make them `const`.


чорд. сейчас поправлю.


no


@gregoire-pointeau yes, this is also viable


I think this should be part of your personal global .gitignore (see https://help.github.com/articles/ignoring-files/#create-a-global-gitignore).


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 124](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=687&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


I am currently rewriting the libArcus Python bindings to wrap the libArcus C++ API. These changes will mean there will be no further need to use a generated _pb2.py file from the Python side, instead it will need the .proto file that will be parsed at runtime. This can simply be an installed file that CuraEngine installs, so that makes the process a lot simpler.


You check the `dtype` of `y.data` twice.


Hah.. thanks for the schooling.


Looks like this version is not quite right.  Here is your version:

```csharp
public static void ApplyChanges<TEntity>(this DbContext context, TEntity item, Func<TEntity, RelationshipType, EntityState?> stateSelector) where TEntity : ITrackable
```

And here is what it *should be*:

```csharp
public static void ApplyChanges<TEntity>(this DbContext context, ITrackable item, Func<TEntity, RelationshipType, EntityState?> stateSelector)
```

`TEntity` is only on the `Func`.  Also note there is no need for `where TEntity : ITrackable`.


Welcome to Stradivari


Good catch with range... I guess that a plain range would not have worked in Python 3?


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/tests/MakeTempTest.py`, line 8.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/MakeTempTest.py
+++ b/coalib/tests/MakeTempTest.py
@@ -5,6 +5,7 @@
 sys.path.insert(0, ".")

 from coalib.misc.ContextManagers import make_temp
+

 class MakeTempTest(unittest.TestCase):
 	def test_temp_file_existence(self):
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/tests/MakeTempTest.py`, lines 10 to 17.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/MakeTempTest.py
+++ b/coalib/tests/MakeTempTest.py
@@ -7,14 +7,15 @@
 from coalib.misc.ContextManagers import make_temp

 class MakeTempTest(unittest.TestCase):
-	def test_temp_file_existence(self):
-		"""
-		Test that the temporary file created exists only within the with
-		statement context and not outside it
-		"""
-		with make_temp() as temporary:
-			self.assertTrue(os.path.isfile(temporary))
-		self.assertFalse(os.path.isfile(temporary))
+
+    def test_temp_file_existence(self):
+        """
+        Test that the temporary file created exists only within the with
+        statement context and not outside it
+        """
+        with make_temp() as temporary:
+            self.assertTrue(os.path.isfile(temporary))
+        self.assertFalse(os.path.isfile(temporary))

 if __name__ == '__main__':
 	unittest.main(verbosity=2)```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/tests/MakeTempTest.py`, line 20.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/MakeTempTest.py
+++ b/coalib/tests/MakeTempTest.py
@@ -17,4 +17,4 @@
 		self.assertFalse(os.path.isfile(temporary))

 if __name__ == '__main__':
-	unittest.main(verbosity=2)+    unittest.main(verbosity=2)
```


**Line contains following spacing inconsistencies:
- Tabs used instead of spaces.**
*SpaceConsistencyBear, severity 1, section `python`.* *Related to file `coalib/tests/MakeTempTest.py`, line 10.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/MakeTempTest.py
+++ b/coalib/tests/MakeTempTest.py
@@ -7,7 +7,7 @@
 from coalib.misc.ContextManagers import make_temp

 class MakeTempTest(unittest.TestCase):
-	def test_temp_file_existence(self):
+    def test_temp_file_existence(self):
 		"""
 		Test that the temporary file created exists only within the with
 		statement context and not outside it
```


**Line contains following spacing inconsistencies:
- Tabs used instead of spaces.**
*SpaceConsistencyBear, severity 1, section `python`.* *Related to file `coalib/tests/MakeTempTest.py`, line 11.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/MakeTempTest.py
+++ b/coalib/tests/MakeTempTest.py
@@ -8,7 +8,7 @@

 class MakeTempTest(unittest.TestCase):
 	def test_temp_file_existence(self):
-		"""
+        """
 		Test that the temporary file created exists only within the with
 		statement context and not outside it
 		"""
```


**Line contains following spacing inconsistencies:
- Tabs used instead of spaces.**
*SpaceConsistencyBear, severity 1, section `python`.* *Related to file `coalib/tests/MakeTempTest.py`, line 12.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/MakeTempTest.py
+++ b/coalib/tests/MakeTempTest.py
@@ -9,7 +9,7 @@
 class MakeTempTest(unittest.TestCase):
 	def test_temp_file_existence(self):
 		"""
-		Test that the temporary file created exists only within the with
+        Test that the temporary file created exists only within the with
 		statement context and not outside it
 		"""
 		with make_temp() as temporary:
```


**Line contains following spacing inconsistencies:
- Tabs used instead of spaces.**
*SpaceConsistencyBear, severity 1, section `python`.* *Related to file `coalib/tests/MakeTempTest.py`, line 13.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/MakeTempTest.py
+++ b/coalib/tests/MakeTempTest.py
@@ -10,7 +10,7 @@
 	def test_temp_file_existence(self):
 		"""
 		Test that the temporary file created exists only within the with
-		statement context and not outside it
+        statement context and not outside it
 		"""
 		with make_temp() as temporary:
 			self.assertTrue(os.path.isfile(temporary))
```


**Line contains following spacing inconsistencies:
- Tabs used instead of spaces.**
*SpaceConsistencyBear, severity 1, section `python`.* *Related to file `coalib/tests/MakeTempTest.py`, line 14.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/MakeTempTest.py
+++ b/coalib/tests/MakeTempTest.py
@@ -11,7 +11,7 @@
 		"""
 		Test that the temporary file created exists only within the with
 		statement context and not outside it
-		"""
+        """
 		with make_temp() as temporary:
 			self.assertTrue(os.path.isfile(temporary))
 		self.assertFalse(os.path.isfile(temporary))
```


**Line contains following spacing inconsistencies:
- Tabs used instead of spaces.**
*SpaceConsistencyBear, severity 1, section `python`.* *Related to file `coalib/tests/MakeTempTest.py`, line 15.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/MakeTempTest.py
+++ b/coalib/tests/MakeTempTest.py
@@ -12,7 +12,7 @@
 		Test that the temporary file created exists only within the with
 		statement context and not outside it
 		"""
-		with make_temp() as temporary:
+        with make_temp() as temporary:
 			self.assertTrue(os.path.isfile(temporary))
 		self.assertFalse(os.path.isfile(temporary))

```


**Line contains following spacing inconsistencies:
- Tabs used instead of spaces.**
*SpaceConsistencyBear, severity 1, section `python`.* *Related to file `coalib/tests/MakeTempTest.py`, line 16.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/MakeTempTest.py
+++ b/coalib/tests/MakeTempTest.py
@@ -13,7 +13,7 @@
 		statement context and not outside it
 		"""
 		with make_temp() as temporary:
-			self.assertTrue(os.path.isfile(temporary))
+            self.assertTrue(os.path.isfile(temporary))
 		self.assertFalse(os.path.isfile(temporary))

 if __name__ == '__main__':
```


**Line contains following spacing inconsistencies:
- Tabs used instead of spaces.**
*SpaceConsistencyBear, severity 1, section `python`.* *Related to file `coalib/tests/MakeTempTest.py`, line 17.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/MakeTempTest.py
+++ b/coalib/tests/MakeTempTest.py
@@ -14,7 +14,7 @@
 		"""
 		with make_temp() as temporary:
 			self.assertTrue(os.path.isfile(temporary))
-		self.assertFalse(os.path.isfile(temporary))
+        self.assertFalse(os.path.isfile(temporary))

 if __name__ == '__main__':
 	unittest.main(verbosity=2)```


**Line contains following spacing inconsistencies:
- No newline at EOF.
- Trailing whitespaces.
- Tabs used instead of spaces.**
*SpaceConsistencyBear, severity 1, section `python`.* *Related to file `coalib/tests/MakeTempTest.py`, line 20.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/MakeTempTest.py
+++ b/coalib/tests/MakeTempTest.py
@@ -17,4 +17,4 @@
 		self.assertFalse(os.path.isfile(temporary))

 if __name__ == '__main__':
-	unittest.main(verbosity=2)+    unittest.main(verbosity=2)
```


АуЕнНыЕ КрИсЫ


Needs one extra empty line before this (PEP8)


What are the next steps? I'd like to maintain a steady pace of progress?
@OmgImAlexis @miigotu @neoatomic ?


By default it does that, but if the user is already going to the git repository of client, I assume he wants the latest version, not some old version.


You may have meant `instantiate` ? https://en.wiktionary.org/wiki/instanciate


Oh, noticed it too late, sorry. I'll keep a note of this for the next time...


I didn't even know init was a word already hehe.


Not sure why this is "simpler".  It ties two things together without need.  The `CollectPath` should not know actually that it has to start from an object`s parent.  (The `Q_ASSERT` in `CollectPath`s ctor shows it probably clearly).


lgtm


2245154-NewVRFHRModel (rongpengzhang) - x86_64-MacOS-10.9-clang: Tests Failed (1663 of 1980 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-83.99%25-red.svg)


Yes!


When I made this change, the link was broken, but it seems to be back up. I agree with you that the original link is better


No promises, but I'll do what I can.
Thanks,
Josh
On Jan 18, 2016 6:59 PM, "Eldon Koyle" <notifications@github.com> wrote:

> That would be great.
> On Jan 18, 2016 4:56 PM, "jbnoam" <notifications@github.com> wrote:
>
> > Wow. Ok. Debian it is.
> > Thanks.
> > Mind if I put info in the wiki as I go about building, using, learning
> this
> > tool?
> > Josh
> > On Jan 18, 2016 6:03 PM, "Eldon Koyle" <notifications@github.com> wrote:
> >
> > > I don't think we have tried building for windows in over 5 years. I
> don't
> > > think the code has changed a ton, but I have no idea what the build
> > process
> > > was.
> > > On Jan 18, 2016 1:20 PM, "jbnoam" <notifications@github.com> wrote:
> > >
> > > > I see readmes fro the debian version but nothing for the windows
> > > > version..... what am I missing?
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub
> > > > <
> > >
> >
> https://github.com/USU-Security/oip/commit/045b87b05249d8a93a3ae3e68cd27af4e033a6fd#commitcomment-15516043
> > > >
> > > > .
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/USU-Security/oip/commit/045b87b05249d8a93a3ae3e68cd27af4e033a6fd#commitcomment-15518627
> > >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/USU-Security/oip/commit/045b87b05249d8a93a3ae3e68cd27af4e033a6fd#commitcomment-15519123
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/USU-Security/oip/commit/045b87b05249d8a93a3ae3e68cd27af4e033a6fd#commitcomment-15519153>
> .
>


Fixed in dc97d3f21c22ffae749f9307cb2aa5e87e492e4b.


Have you looked at system.auto_channel_create ? If you set this I don't believe you need the workflow_channel_next


What about to add `# frozen_string_literal: true` in the beginning of files instead?

http://blog.lucascaton.com.br/index.php/2016/01/19/what-is-frozen_string_literal-in-ruby/


You can pass `t` instead of `(4)` -- we use the prefix argument as a boolean currently, the numeric value is irrelevant to us. (Same in your other calls that use `'(4)`.)


@loriab I have incorporated `libgetkw.a` inside of `libpcm.a/libpcm.so` so that now you do not need to know that it exists. Notice that PCMSolver now created **both** the static and shared libraries and CMake seems to prefer linking against the latter.
I do not remember exactly where those libraries come from. My guess is `${CMAKE_IMPLICIT_LINK_LIBRARIES}` I do not have the Intel compilers on my machine, so I can't print that variable out and see for myself. My tests with the whole infrastructure change in this commit showed that there is no need anymore to instruct CMake to link against those.


Weird indent.


FixDElightIOrefShading (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1507 of 1507 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


Thanks for the suggestion.  It works fine.


revisado.


Daria Joanna Mydlarz (daria.mydlarz@gmail.com)


OK, good to know. Is there any other function (e.g. `load_parameters`) in which we should apply the same trick?


Not crazy about this - should harmonize with our other tools and make it white. If there is another style issue let's fix it by changing something other than the background.


I think it would be better if `go--function-name` returned nil for anonymous functions, unless an optional `arg` was non-nil, in which case it would skip anonymous functions. That seems more consistent with the rest of the new API.


@gaborbernat , would you mind splitting the file removal and the config updates into two commits? I hope to one day history re-write to get rid of the binary files, having the removal be in their own commit will make that a bit easier.


IMO do this commit in an independent  PR so that this overall change is not delayed. I've no objection to this commit, but there will be some delay for conversation about it.


Puedes hacer el paso de mensajes más transitivo para que el código quede menos verboso

```
Cliente cliente = vista.getCliente();
cliente.getName();
```


Nice addition :+1:


Is this an issue particularly about the base sysimg? I thought the order of definition doesn't matter until the method is called.


ASIHPdev (shenb) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-56.45%25-red.svg)


**커밋 메세지**는 무엇을 변경했는지 명확하게 써주는게 좋아. 그래야 다른 사람들이 보고 리뷰를 명확하게 해 줄 수 있거든.
위와 같은 경우는 도메인을 변경 후 그와 관련된 산출물들의 내용이 변경된 것 같아 보이네. 그럴 경우에는
`ERD도메인 변경에 따른 ERD, 테이블정의서 수정` 이라고 달면 더 좋을 거야. 잘 하고 있어.


I'm not sure! I already applied it to `add_to_dump`. I'll check if we need it elsewhere!


propertyはenumをしようしmainが0、subが1のように管理していくので型はINTにしましょう( ˘ω˘)


I think `nerd boner` needs a hyphen.


Because this was a quick proof of concept and I didn't bother fixing this.


reduce_redimensions (mbadams5) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


yeah. in particular, it seems the method did get called, just not on the PipeBuffer branch of the function (probably because this method got called to string-ify some random stuff)


Commenting out that line allows device_angler to include files from build
dir/vendor dir.  That same commit is typically used for all devices if you
are using vendor dir. Check it out on some other devs githubs.

On Mon, Jan 18, 2016 at 6:52 PM, dl200010 <notifications@github.com> wrote:

> May I ask what this actually accomplishes?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fwhem/device_huawei_angler/commit/6f97b2e7b7339ee5c6078d0010dd93d7b57f0bd5#commitcomment-15519081>
> .
>


Yes that should work, I will try that. Thanks!


exposed at runtime :(


Actually, I just took a closer look at the API docs and I believe that we have some duplication in our code. The code for handling errors already tries to unmarshal in the "Response" (which is actually errorResponse). If any error is present, it wraps the error in an APIError.

What we may do is having a Response with a single Message, for the case where the operation went fine. What do you think? In terms of behavior, that would be what we get:

1. API Response:

```json
{
    "response": {
        "message": "It didn't work",
        "errors": {
            "error": [
                "Something went wrong, please don't try again"
            ]
        }
    }
}
```

Response from our code: ``nil, &APIError{...}``.

2. API response:

```json
{
    "response": {
        "message": "It worked",
        "errors": {}
    }
}
```

Response from our code: ``&Response{...}, nil``.

I'm also invoking @marzagao here, as he worked with me on the error handling code.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11881](https://teamcity.mesosphere.io/viewLog.html?buildId=107337&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:11


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11880](https://teamcity.mesosphere.io/viewLog.html?buildId=107336&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:17


Do you think it's wise to include `\uspunctuation` in the language file by default?

When I studied in Australia, our punctuation style had to be **‘Title’,** which is in line with what is normally done in Britain and Australia, even though it does not match SBL. This is what I get by default with these settings:

```
\usepackage[australian]{babel}
\usepackage{csquotes}
```

Is using `\uspunctuation` with non-US languages institution dependent?

What do you think @Nhapsie and @baem2?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11879](https://teamcity.mesosphere.io/viewLog.html?buildId=107335&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:08:54


means -> means?


hmm si on, regarde bien il y a comme des lumière bleu qui éclair les bloc, ce que nous on a pas ^^


I haven't gone through those yet, and they look very useful. Looks like two of the notebooks are linked from http://dask.pydata.org/en/latest/array-overview.html and http://dask.pydata.org/en/latest/dataframe.html currently.


I have my editor setup to automatically remove extra end-of-line white space characters. Hence, all the delete changes. Please ignore those.


Interesting - what do you know about this?


You should probably be checking `FAILED(hr)` here so that you can provide some kind of error message instead of letting the renderer go into some kind of unstable state :Pf


`A` or `CNAME`


Hello,

Thanks for the info - I will make a note in the docs that it has been confirmed to work except for R registers.

I looked in the MC protocol manual and it looks like with the Q12H CPU the extension file (R) registers need an additional block # specification that the FX CPU doesn't need, so there is a different protocol command that has to be used for reading and writing these registers.  If I can find time to add the code for it, would you have time to test?

Good to hear you are finding it useful...


Thanks for responding so fast. I am just working on my first AOSP compile. I found this and just did not get what it was doing.


`BINDGEN_HAS` should be `BINDGEN_HASH` here.


What is special about this hash?


:camel:


Merged and committed.


Can avoid 2 calls to getAndAdd() with something like:
```java
int inc = null == bucketedValue.getValue() ? value.length : value.length - bucketedValue.getValue().length;
sizeInBytes.getAndAdd(inc);
```


note: "It works" means that I think it'll work but haven't tested it as I need to sleep. Close enough.


Ligne 24 et 25 ne servent à rien en fait :