The fix is indeed for https://github.com/plumpudding/meshviewer/issues/19 not for issue 19 in the main meshviewer fork


We treat the title clips in a special way. Where does this logic go?


TeamCity ReOpenLDAP :: devel [Build 223](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=1671&buildTypeId=ReOpenLDAP_Devel&guest=1) outcome was **SUCCESS**
Summary: Tests passed Build time: 01:54:03


What about giving `Action` a MonadRandom instance and changing the type of `mkAudioSolution` to `MonadRandom m => m ST`?


Ok, but in that case is the javascript also loaded for the page that's loaded through ajax, without the main templating file? Because that's what this page is for. It's loaded from the gui/slick/views/addShows_imdb_wrapper.mako template.


111639676-UniqueThermostats (DavidGoldwasser) - i386-Windows-7-VisualStudio-12: OK (2350 of 2384 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.57%25-yellow.svg)


Can you have a look at https://repl.it/Bdp2/0 and tell me whether it answers your question?


*Don't forget to click on "Run"*.


Yeah, I was planning to move it to core.js when all was working. Wanted to add it here, to do some testing. But if you think this is the root cause, i'll move it now.


    nagashi_deltas = [-4000] * 4
    nagashi_deltas[player.id] = 12000

のほうがシンプルな気がします。else文も同様。


What's the difference?


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1221.1fa58b27d6053f7fcf1e453b96c350aff0b7c8bb](http://build.palaso.org/viewLog.html?buildId=67962&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 836, ignored: 7 Build time: 00:14:09


She must be proud ...


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11558](https://teamcity.mesosphere.io/viewLog.html?buildId=105248&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:03:54


somehow I must have pushed not the latest version, I was sure I added that :/ .. thanks for pointing it out :)


To be honest, this is not clear which is the correct in case of static functions.
Somewhere the double underscores are used, elsewhere the simple underscore is used.
@bazsi @lbudai @bkil-syslogng What should be the correct usage


renamed NotAnUUIDException to NotAnAccesTokenException


Isn't it more easy to set the density of the drawing_context somehow? Otherwise you have to get rid of self.pixbuf and also make sure "pixbuf" does not appear anymore.


I fixed those in my own repo.

At the first glance, the application compiles, and sort of works:
* Network menu can be hidden,
* but Status and System menus are always visible. Might be related to e.g. the fact that some other luci applications add menu items to System. E.g. "custom commands" get added there by luci-app-commands. That might confuse the logic.

There have also been some changes betwen CC15.05 and trunk, so it is possible that your approach is not quite compatible.

I also ended up in a situation, where trying to select the forbidden but visible "Reboot" item led to immediate reboot of the router, without the normal confirmation... Again, that is probably due to changes between CC and trunk.

But I think that this is suitable for discussion purposes.


test close issues by commit. see https://github.com/tudou527/marketch/commit/b552518b967b719a3fce4717c755bbd583c7113b


here magic happend


squash with previous commit?


Hello Snowch,

I added it as part of TODO List. Please feel free to remove it, if you feel its not relevant.


あ、でも複数人の流し満貫が成立する可能性があるんですね。失礼しました。


в шаблонах мы используем конструкции
```
<? if (): ?>
  <meta>
<? endif; ?>
```


Oh sorry, my bad. In the current context it should be okay. Let me then
rephrase my query that I'd like to see unit tests for strings containing
`NULL`.

On Thu, Jan 14, 2016 at 2:43 PM, juhaszviktor <notifications@github.com>
wrote:

> To be honest I don't understand why strcmp is not good enough in this
> context. The MESSAGE is a predefined constant string, have to ended with
> '\0' char. The strcmp go while it doesn't found NULL character so the
> maximum value is the length of MESSAGE.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/juhaszviktor/syslog-ng/commit/45f01241da7fbc0bd3e49056b4789ca1829beb01#commitcomment-15449903>
> .
>


I compared the code coverage before and after your change, and there are lines/branches that were covered before that aren't now.  We don't want to regress in that way.


How do you decide what version should be?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11559](https://teamcity.mesosphere.io/viewLog.html?buildId=105249&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:08:03


Abcd


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11561](https://teamcity.mesosphere.io/viewLog.html?buildId=105250&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:08:13


issue #38


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11560](https://teamcity.mesosphere.io/viewLog.html?buildId=105251&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 174 Build time: 00:09:19


An assert like this that's testing that ```new``` doesn't give back null isn't necessary.


Fix-allocation-for-feneSolarDelaySeq (JasonGlazer) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-82.93%25-red.svg)


Nit: s_dictionaryData


@skeep We would need the default task to run the file.
I would not need gulp-sequence task


TeamCity Civic Assembly :: Build backend + frontend [Build 164](http://54.229.176.143/tc/viewLog.html?buildId=449&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests passed: 1361, ignored: 8; exit code 1 Build time: 00:15:18


Ola


This is a pep8 concession to avoid the same ident as in the next line :)


I completely agree with you @ligi  - but I think especially this feature should be an option since it alters device behaviour outside of the app.
@stephanlindauer What if for example someone want's to be able to interact with his lockscreen but still be able to unlock his device and be right back in the app. Right now we basically prevent that workflow.


o>


Could you include the parameter name as an argument to Throws (here and anywhere else you use it for args) so that it also validates the parameter name?


what will happen if we call `run_mon` like this `run_mon /xxx 123 --a --b --c`


TeamCity Civic Assembly :: Build backend + frontend [Build 165](http://54.229.176.143/tc/viewLog.html?buildId=450&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


Montalvo's clauses are still marked-up as they were before, so our notion of clause is the same (that is, we keep using the punctuation marks as boundaries).
I modified all the chapters that you had already stitched. In the first chapter I had to segment 9 clauses, in the second, 18. I didn't meant to underestimate its frequency. The stitchery process is arduous enough already, and this adds an extra layer to consider, but I don't see another way around it.


maybe use dpkg instead of deb to be consistent with the warning


Does this need to return a promise for interface purposes? Doesn't look like there's anything async to seal over.


indentation


Have you checked that the paths are correct on dpkg based systems?


besides that lgtm


because if I want to fiddle with the dialog code it's quite annoying that the whole program needs to be recompiled every time I change a number!


Please merge yourself!!


I like early returns.. so please replace this with:

    if (line.empty()) {
        ret << '\n';
        continue;
    }


Pretty sure this wasn't me :)


```php
$oView->getPersParamValue('foo', 'bar'); // returns 'bar'
```
Is that right? If so, why should I use this method, when I know what `$s_paramValue` is? Why do I need to pass `$s_paramKey` to the method, since it's not used?


Recommendation from Stephane's style.  It's simple a mechanism to align (and highlight) the operations that are happening in the stream.  Since `this.spaceId` is an object it doesn't fall into this pattern.  We've seen places where we get [odd alignments that are difficult to read](https://github.com/cloudfoundry/cf-java-client/blob/master/cloudfoundry-client-spring/src/main/lombok/org/cloudfoundry/client/spring/util/AbstractSpringOperations.java#L81-L82) so you'll see elsewhere in the code (`AbstractSpaceOperations` not withstanding) that all of the code has been changed to follow this pattern.  Places where it hasn't been changed, are candidates for polishing.


formatLog is calling these as async so it can process the large array in an async manner 200 entries at a time.


This one removed Side panel and have a top navigation for the 5 Areas as PHP-Fusion 7 have.
Idk if we will future develop it and make it more unique or just have it as a proof of concept for the various voices that miss old style admin look.


This is an error. Assing the value here results in time_since_error always being zero.


I prefer that the c++ type std::size_t is used instead of the c type.


Hallo Ben

Mir sehr wohl bewusst, dass der Code sehr viele Qualitätsmangel aufweist.
Es hängt damit zusammen, dass ich vor hatte erst den LParser zu
programmieren so dass er funktioniert, dann den zu formatieren und zu
kommentieren und erst dann bei Git hochzuladen. Da ich, aber von Gabriel
gestern um Mitternacht Mail bekam, dass ihr bietet den aktuellen Stand auf
Git in die neuen Branches zu pushen, habe ich es auch getan. Der Code wird
spätestens an diesem Wochenende fertig gestellt und dokumentiert.

Außerdem würde ich gerne noch eine Sache besprechen.
Wir haben heute folgende Goya-Nachricht von Professor Leser an unsere
Gruppe bekommen:
Prof. Leser hat an Kacper Siedlecki eine Nachricht der Priorität "Normal
wichtig" zum Thema "[VGB]Treffen Integrationsgruppe (Pflichttermin)"
gesandt:

Sehr geehrtes Integrationsteilprojekt,

es bestehen bei uns Lehrenden erhebliche Zweifel, ob alle Teilnehmer der
Integrationsgruppe bisher Leistungen erbracht haben, die eine
Scheinvergabe rechtfertigen. Das betrifft die Qualität der abgegebenen
Dokumente ebenso wie den bisher vorhandenen Code; manche von Ihnen waren
unserer Erinnerung nach bei keinem Treffen seit Semesterbeginn mehr
anwesend, insb. auch nicht beim Pflichttermin (Code Review) letzten
Dienstag.

Ich fordere Sie daher auf, am kommenden Montag, den 18.1.2016, um 9.00
Uhr in mein Büro zu kommen, damit wir das weitere Vorgehen besprechen
und die potentiellen Konsequenzen aus der aktuellen Situation erläutern
können. Sollten Sie erneut unentschuldigt nicht kommen, werde ich Sie
ggf. aus dem Projekt ausschließen.

Mit freundlichen Grüßen,
Ulf Leser

Ich wollte ob ihr Projektleiter auch kommen könntet um als Vermittler und
in bestimmten Sinne als Zeugen zu funktionieren. Die Meisten Leistungen von
Mitgliedern unseren Gruppe lassen sich mithilfe von E-Mails nachvollziehen
und nachweisen, aber bestimmte Sachen (wie z.B. Gespräch mit Malte an dem
Tag wo er Git und Spezifikation vorgestellt hat oder Gespräch mit dir über
dem Stand unserer Gruppe und Leitung von Gabriel) lassen sich so nicht
nachweisen, deshalb wäre es sehr nett ihr mitkommen könntet.

Mit freundlichen Grüssen Kacper

Am 14. Januar 2016 um 11:44 schrieb Ben Schumacher <notifications@github.com
>:

> Hallo Kascper,
> der Code benötigt eine dringende Überarbeitung. Die Dokumentation ist
> nicht vorhanden und der Code ist sehr schwer verständlich. Die Variablen
> sollen eine sinnvollen Namen bekommen und der Styleguide eingehalten
> werden. Zudem sollte der Commit eine sinnvolle Commitnachricht bekommen.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hu-semesterprojekt-genombrowser/Alazen-Integration/commit/b6a8e78c91fe60ae454e667529a2c4bc8b0aa2be#commitcomment-15446671>
> .
>


Ваша модель описывает только одну шутку, а вам приходит целый список. Поэтому тут нужно использовать List<GettingDataModel>


follow and track are not mutually exclusive. Both should be able to be specified simultaneously


И тут, конечно же List<GettingDataModel>


weird formatting.. is it done by autopep8?


All js needs to be loaded on the page, if you're loading a page via AJAX then the controlling page needs the js in the core section. The controlling page then should load the js after the other page is loaded in.

For example X loads the contents of Y into a div. Y's js should be a function for the AJAX callback on X.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/25525/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/25526/testReport/) for this commit**


Ну и здесь будет List<GettingDataModel>


Even when testing it should all be in core. Core loads everything in the correct order, if you're testing then use Chrome's console.


php database connection


Good enough for me

On Thu, Jan 14, 2016 at 2:57 PM, juhaszviktor <notifications@github.com>
wrote:

> Do you think something similar:
>
> if (handle_a == handle_b)
> {
>   return 0;
> }
> else
> {
>   return (handle_a < handle_b) ? -1 : 1;
> }
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/balabit/syslog-ng/commit/3a4723cb7d5f6e9792a07b3612ea4de38ed5d8e6#commitcomment-15450187>
> .
>


Теперь, чтобы всё вывести в лог, нужен цикл.


Additional checks could be performed for personal documents (eg. outings) to make sure that only moderators and users associated to the document may create new associations (as in v5). But we could do this later if actually needed.


First line of your commit message is too long. It should only be 50 chars.

</trolling_mode>


こちらも

    if (@ag_bakaze == last_bakaze.succ) || (@ag_bakaze == last_bakaze && @ag_oya == @players[3])

にしておかないと、「東南戦、南4局、renchan == false、全員3万点未満」という条件でゲームが終わってしまいません？


We are using concourse in a corporate environment that requires an http_proxy to reach outside to github.com. So we rebuild all the resource containers with http_proxy and no_proxy environment variables to make them work in our network.

In our case this resource disables ssl verification which seems unrelated and is not wanted in our case. We can fork the resource and change it of course, but I always try to change as little as possible.


code style


Plz insert return statement ... (note to self)


There is a warning here. I really have no idea about when to close mongoClient. Maybe the only solution is that take the mongoClient as a parameter.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11562](https://teamcity.mesosphere.io/viewLog.html?buildId=105256&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:09


use hamcrest matchers


Ok I will compile it and see what I can do. Status menu and overview are always visible by design because that is the default path for initial login. System menus should be able to be hidden though so I will look into that and the reboot issue


if not too much trouble it could be good to avoid introducing unrelated whitespace changes in a patch - there are quite a lot of spurious line removals in this patch.

One quite easy way to rectify this would be to do:
```
# reset your HEAD by one commit (it will leave the changes in your working directory)
git reset c3311536950552e184ff14e237a1ce31f885f1af
# interactively discard changes (say 'y' to discard the white space changes)
git checkout -p
# re-commit everything with your original patch message/authorship/date...
git commit -a -c aea01384f5661108d1976844737fe92825e30db0
```


can just be `features.fake_mode = gputop_fake_mode;`


wuut?


I think this method and field should be put into TestSaveFile, as private function.


Fix-allocation-for-feneSolarDelaySeq (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-83.25%25-red.svg)


Why?


Well alteast servers are not using it... But i don't know for how long... 100% someone will find it who has shitty server with 0 or 1 player on it and will use it somehow... And why is that code there anyway? And it works!?! I allways check and test alot of things before i give 'final jar' to my friends/someone... (i only code as a hobby)


This container runs without ...


Please, could anyone provide me the compiled files?
armeabi / libaacdecoder.so
armeabi-v7a / libaacdecoder.so
thx so much


done, thanks!


WIP: this is a try to fix back the promise chaining


Does this only match --security-opt label:disable?

Other versions of --security-opt should not trigger this warning.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1222.f80256ad4bc0e4921410e4d85eebeebf2af55bf8](http://build.palaso.org/viewLog.html?buildId=67963&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 839, ignored: 7 Build time: 00:07:25


You're right, thanks for catching this! Fixed in c5e3cec.


Add buttons into self.stars


Here also we would need to check that only moderators can delete an association (as in v5).

I guess that with the current settings, any authenticated user may delete an association. I suggest to leave as is and see what the client thinks of it (it's a bit a pain in the neck in v5 that contributors must ask moderators to delete associations). Perhaps we should create an issue to sum up who can do what with associations.


We should start these three with the same comment

Processes in the container can ...


when callback setStar(), remove old buttons and create new. But it does not working.


Until sparse shape is generalized none of this matters yet. Namely, dense
shape does not contain range info, hence SparseShape::gemm(DenseShape) is
not possible in principle. I'm trying to pull symm branch changes in here
where I started on a generic shape.
On Jan 14, 2016 8:53 AM, "Justus Calvin" <notifications@github.com> wrote:

> In order to enable this behavior, the distributed evaluators need to be
> updated to handle the logic of mixed sparsity types. The binary evaluator
> should be relatively strait forward, but Summa is going to be much more
> involved.
>
> Also, the tile interface need to be expanded to produce a dense tile of
> zeros, if you want to support casting from a sparse to a dense result.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ValeevGroup/tiledarray/commit/cde1ba74af0e73c987108767241e9f18fb0772fe#commitcomment-15450087>
> .
>


LGTM :+1:  Thank you


You can use getTestMuleMessage for simplicity.


svdf


名前はpao_player_idとかのほうがわかりやすいかもしれません。それでもあまり自明ではないのでコメントも書いてもらえると助かります。

また、単にpao_playerという名前にして、idではなくPlayerインスタンスそのものを入れたほうがややすっきりするかもしれませんが、お任せします。Player同士は単に==で比較できます。


fefaeg


Hi Ronnie,

i would like to understand what exactly the issue was. I wrote this patch as it saved a lot of syscalls and it improves performace (it always reads all availabe data from socket).
Do you have a reproducer? Maybe the bug is somewhere else and was just revealed by this change.

Thanks,
Peter


OK


I've told this to @johnnyxl26 already, the idea of the `vm` is to NOT USE $scope.

Doing this:
```
var vm = $scope;
vm.something = stuff;
```
Is not different from doing this:
```
$scope.something = stuff;
```
Check the right way to to this.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/25527/testReport/) for this commit**


This isn't a fuckup. Novaember best!


I agree with aligning operations on a stream, but is `Validators` is a class not a stream and `validate` is not an operation on a stream (well, ok, it constructs a stream, but I don't think you'd want to split e.g. `Mono.just()` across two lines).


ここ `{}` の最後にスペースはいってない？


Somehow the single quote transformed into an accent. It should be `amandapalmer´s` and neither merge the `´`with the `r` nor the `s`.


@teckjon DWMR of #27. Well done here. Ship code!


I recommend that you use raw strings for regular expressions. Put a r before the string:

    re.compile(r'^\s*#\s*define\s+_TIME_BITS\s+64\s*$')

That way you know that '\x' will be translated to a '\' character and a 'x'. no matter what 'x' is.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11563](https://teamcity.mesosphere.io/viewLog.html?buildId=105257&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:13


This --quiet field should be handled in the self.display function, although you need to add another flag when user specifies display.

Something like

```
def self.display(self, cmd):
       if self.display or ! self.quit:
               subprocess.check_call(
                             "/bin/echo \"" + cmd + "\"", env=self.cmd_env, shell=True)

```


TeamCity Civic Assembly :: Build backend + frontend [Build 165](http://54.229.176.143/tc/viewLog.html?buildId=450&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests failed: 20, passed: 1476, ignored: 12 Build time: 00:17:29
### Failed tests
```
Document type tests: Should not create new document type if cancelled: <no details avaliable>

Document type tests: Should add new document type: <no details avaliable>

Document type tests: Should not change document type: <no details avaliable>

Document type tests: Should change document type: <no details avaliable>

Document type tests: Should not delete document type if cancel pressed: <no details avaliable>

Document type tests: Should delete document type: <no details avaliable>

Media type tests: Should not create new media type if cancelled: <no details avaliable>

Media type tests: Should add new media type: <no details avaliable>

Media type tests: Should not change media type: <no details avaliable>

Media type tests: Should change media type: <no details avaliable>

Media type tests: Should not delete media type if cancel pressed: <no details avaliable>

##### there are 10 more failed tests, see build details
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11564](https://teamcity.mesosphere.io/viewLog.html?buildId=105258&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:04:27


Forcing users to only use either track of follow makes reasoning about the data collection easier, especially in terms of sampling. I've added a note to the docstring.


ACK


whitespace at the end


Missing newline at eof


do you really want to use a different output format that is not cppcheck-compatible?

it would be more cppcheck-compatible to rename "category" to "severity" and use one of the possible cppcheck severity values.


Why check `sizeof()` here and skip it at other places? You could consider creating a macro for that for clarity.


Please use non-min versions of js files for now. Like this - ` <script src="https://code.jquery.com/jquery-2.1.3.js"></script> `

This will make debugging possible.


@leeoniya good work on finding a fix! In Inferno I opted to use comments to break up text nodes, rather than merge text nodes. Upon first run of hydration, the comment nodes are removed. I had to do this because someone could simply do this (pseudo-example):

["test", someVar, someVar2, "test2"]

On first pass someVar and someVar2 are strings – so simple to merge. However, if on the 2nd pass they turn out to be nodes, it's much harder to break out the old part of the text from the merged string and replace it with a DOM node.


will never be null, application at line 20 if this is to occur


It´s a getter function! Sure you know what the value is... - but for example, if i want to print the unit for my value you can do:

class my_oxview extens my_oxview_parent {
    public function getPersParamValue (.....) {
      $s_ret = parent::getPersParamValue (..);

      if ($s_param_key == "my_persparam")
         return $s_paramValue . " Inch";

     return $s_ret;
}}

For that, you don´t have to change every template where persparam occur...


Thanks


Missing line at eof


I would replace the comment with `g_assert()`


This changes all cards when editing, probably just want to select the add item card here


s/issues/requests


@ggreif yes, but at the end I've used your map code. Thanks for the lesson btw.


Nitpick: might make sense to make this bit-booleans, by adding a ":1" as suffix


Fair enough. Sorry to have put these as comments rather than pull requests--I'm on my phone. Thanks for making all the code and documentation available!


remove this conflicts reference


you have no braces on the if, so only the strcpy will be in the if...


protosの中にprototypesを入れ子にしているのはおかしくない？
同じ意味の中に同じ意味のものが含まれてしまうよね。

namespaceではなく、:moduleオプションを使用してpathにはprototypesを含めないようにしよう。


The OS::Nova::ServerGroup should be created in openshift.yaml otherwise one OS::Nova::ServerGroup will be created per master and the VM may end up on the same compute node


return getFormatter(format).parse(date);


remove the conflict reference


Missing newline at eof


This warrants some documentation. I get what you're doing since `_changed_settings` is the settings that are specified by the profile, but to an innocuous onlooker these two lines will seem strange. If a setting is not changed, then we emit that the setting is changed...?

That said, I don't get why you don't want to emit value change signals for values that are in the profile (why the commit was made in general, that is), so you might want to include that in your documentation.


same as the method above


I am!  It's reading the workflow at the end of this file.  Check out the [Special Literals section of perldata](http://perldoc.perl.org/perldata.html#Special-Literals).


    t.same_symbol?(w)

というメソッドもあります。まあどちらでもいいですが。


Something is weird with the git history. I had planned to port it as is (with checks for v2 vs v3) and then refactor it, but it looks like (according to git), I added the logic.

Oh, I know why. I did the original work in the v3 branch, which didn't have this logic. When I ported the changes made in the v3-groups branch, this got added. It will be removed soon.


Why not do this all in one command.

docker rmi -f keys should work.


this is an else after a while...
Does this even compille.

morover, if you break at the end of the if, what's the point of having an else at all ?
you just exit the while scoop at the end of the if...


I am pretty sure this check should be called from add_file() somewhere, but not from add_root_directory(). Also, it shouldn't be called for directories anyway, only for files.


`decodeURLParameter` is not called.

We should say like as follows?

```
Option(...).map { executorId =>
  UIUtils.decodeURLParameter(executorId)
}.getOrElse {
  ...
}
```


One simple workaround for spark jobs is to disable the ATS integration in your spark-defaults.conf. Note, with ATS v1.5, given we use HDFS as one of the underlying stores, if HDFS is down, the ATS and jobs that need to write ATS will experience issues.


```
namespace :api do
      resources :likes, only: [:create, :update]
end
```

はprotosの入れ子にしなくていいね。

おそらく、controllers/api/likes_controller.rbとしてると思うんだけど、同じだね


Will this except catch the ValueError raised above?


Please add an `assert_return(j, false)` check at the beginning of the function.


leftover debug.


Similar here


please change _str to a reference to avoid data-copy.

    const std::string &_str


Fix-allocation-for-feneSolarDelaySeq (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-76.76%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-68.42%25-red.svg)


You said:

> You're right. But we need to specify that in the style guide.

Which leads me to believe that we should have made this an `a` tag, instead of removing the `href` attribute.


http://techracho.bpsinc.jp/hachi8833/2014_03_03/15619
参考までに！


likewise.. please use the c++ type


In exported APIs we currently avoid using C99 concepts, such as the "bool" type. Please expose this as functions returning "int", and do not include stdbool.h, so that we stay compatible with C89...


This is how the other examples are in atomic. If we change this, it would be out of sync with the rest of the code.


a) this is about to break on 0.5
b) don't extend base methods for types that aren't from the package


Also see CODING_STYLE about this


I think I only saw double underscores in systemd journal source, which was already integrated by the time I was reading it. Anyway, I don't currently have a reason why I would use double underscores.

So except someone can tell a compelling reason all of them should be gone.


The line needs to be moved lower after the last use of last_error_date rather than being removed completely. I think that is just after time_since_last_error. Sorry again for commenting rather than a pull request. I was just skimming the code from my mobile.


Nice


変更部分を確認しました。特にコメントはありません。


change to if (date == null) { continue; }


どうもです。
2010サポートもそろそろ‥なんですかね。


Right now I am not convinced it should go into a module, so I would postpone this question until we have that settled


@Andrei-Stepanov so please send an updated version changing everything to https.


Use const reference for _str

    const std::string &_str


Dorobiłem brakujący ".
Czy w innych miejscach dostawi się {trans("ID:")} to czy to zaburzy wizualnie formę?


Why not using the relax syntax as stated in http://www.bootsfaces.net/integration/angularFaces.jsf ?


fix "where where"


lll


Oops, absolutely!


TeamCity pull requests :: netty [Build 1030](https://garage.netty.io/teamcity/viewLog.html?buildId=4750&buildTypeId=pulls_netty&guest=1) is now running


Why don't you just compare by `===` instead of `sameElements`?


Actually testing is always expensive, and not always worth the time. However, in this case, I feel that we would at least need to generate a message with all slots filled, and upon retrieval, we should compare all of them.

Furthermore, of course more granular tests would be cool, I understand that there are too many combinations to worth it. However, it would be nice if you could illustrate a few edge cases and/or error cases too.


@kjoscha kannst du nochmal verraten woher das car-icon.png ist?


I thought you are using the Chrome extension for Google Play Music now :smile:


test


We can remove it, the tests just have to pass still, that's all. :-) PR welcomed.


Speaking of Gemstone2 - are you still intending to keep it as a different plugin?  Now that there is a v9 exclusive repo, you can likely keep it as the same Gemstone plugin, but only those running v9 would be able to use it, so working off the v9 SageTV7.xml is still fully workable.


Every non-variable template text should be wrapped in a [`trans` tag](https://docs.djangoproject.com/en/1.9/topics/i18n/translation/#trans-template-tag).


And why would that be important? I can understand that we might want to do that for network traffic, but why do we want that for a disk buffer? Why would a user change it? Would serializers be semantically different?

I can understand that we want a better handle on serialized formats and be able to code different formats in independent c modules, but as of now I fail to see what we get in exchange for making this pluggable. Maybe we should do that when a 2nd format comes along.

Also, this is really tightly coupled with nvtable code as it pokes into the in-memory representation of nvtable without using accessor functions.

If your concern is not to pollute /lib why don't we create a /lib/logmsg directory and move all code there. Would probably help us remove some of the coupling.


Yes, you are right, this is totally uncessary


J'hésite. Le module est bien, court et simple, mais il ne fait que retourner une regex qui n'a quasiment pas bougé depuis sa création (https://github.com/regexps/doi-regex/blob/master/index.js#L17). Je ne sais pas trop si je devrais l'intégrer ou me contenter de récupérer la regex. Des avis ?


sudo_users = {154184294,132633553},--Sudo users


I made up my mind. I think no further checking here will be needed because no such asserts are present anywhere else. In this case, it would only raise suspicion and make the code a bit more unreadable. (Static analysis with Frama-C will still be possible.)


これだと赤牌を加槓した場合に:paiに赤くない牌が入ってしまいませんか。そうなるとどこかのバリデーションでこけたり、プレーヤの副露牌に赤牌が残らなかったりする予感がします。もし簡単に直せそうであれば直してもらえませんか。面倒そうなら放置してください。こちらでIssueを残しておきます。


This feature can now, help frameworks scrape token even when they are using a # prefix for routes


Done


realm = {89490142},--Realms Id


BrokenPipeError is the only exception, which will ever be raised here?


Any reason for this to be a list instead of a vector?

P.S Apologies for reviewing a PR after it being merged.


What specific exception do you mean? Point the line where the exception was propogated before my change and stopped being propogated after my change. I can't see such case, but may be you see something...


Pipe is a bit misleading. I would phrase it the following:

```
raise (ConnectionError("Connection to server was reset")
```


@jmorton Is this a typo? Seems like it ... can't think of a good reason a method call would need to be backquoted -- I'm fixing in my PR, so no need to do anything ;-)


No reason in particular I can think of right now, no.

PS: Not an issue.


interesting, thats a good way to go as well!

but it would be more difficult in domvm given that dom nodes are sorted by their expected and actual index in parent. this means i'd have to pluck the comment nodes from the vtree instead. realistically though, nodes tend not to change types. if they do then it would be handled by a normal nodeValue update + insertBefore of the new tag by domvm (hopefully!)

i fixed another textnode & isomorphism situation a while ago where leading and trailing text nodes (if empty) were getting squashed by innerHTML, so i have to re-insert those during attach. dbmonster caught that one :)


When I added the -b compat, my Travis status went from Pass to Fail:

https://travis-ci.org/Tux/CSV/jobs/102357841


You may want to start using unique_ptr instead and avoid similar issues for this pointer in future


May be worth changing this to make it clear that this behaviour has changed since 2.4


@joecaintic DWMR. Looks like you have things working well, and, of course, you're shipping code. Good.


嘛，现在这个获取的是稳定版，一会把clone的加上去，乃看看如何w


No; it probably comes from me playing silly bugger with the indentation settings in my editor. Fixed.


web server


POPO


Tu pourrais directement virer les lignes vides (pour les orbites non prises en compte)  :
```
    case Orbit::PHI2:
    case Orbit::PHI1_PHI2:
    ...
    default : assert_not_reached(...);
```
et juste laisser le default ?


I am ... weird this one is left in the Brewfile


@pekohl DWMR here. Good work. :+1:


glaube da her: http://www.flaticon.com/free-icon/smart-car_13153#term=car&page=1&position=52


I'm wondering why promises are implemented with C++ and not JavaScript?


Funny, I was thinking of that yesterday.  There would be a little rework to undo some stuff I did to separate it but that is not huge.

However, my plan for the release was to have it as a STV type plugin where the first one was a stvi that then lets the user add the STV....not sure how that would affect when the user did an update from the previous version.


Done


Okay; removing my nose from others' business, now.  :)


:+1: I will do this


Bah, si tu récupères la regex, ce sera à toi de la maintenir, dans l'éventualité où elle se met à changer.
Mais ça augmente le nombre de dépendances.

(bon sang, faut que j'arrête d'enfoncer des portes ouvertes)


Fixed.


This function seems closely related to WP and routes. What about getting associated documents for other documents types? I don't think all documents may be associated to WP or routes.


Fix-allocation-for-feneSolarDelaySeq (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I cannot replicate your errors, perhaps my build is behind yours ? everything works perfect on  OpenWrt Designated Driver r48014 / LuCI Master (git-16.014.43266-8f75af9)  using multi2 from your repo


Elle fonctionne cette regex ? si c'est le cas, ca peut être bien de reposer sur leur module surtout vu qu'il est bien codé.


Checkmarx scan results 14 Jan 2016 06:57 UTC -08:00

High
Medium
Low
Info

New
0
0
0
2

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

a9770dca08c6e7c5a698c7d4e78012cbd36c0712	@dortal


All these tests are expected to give `Plan_exists_for_all_VMs` as output.

It would be nice to have have at least one test for each of `Plan_exists_excluding_non_agile_VMs` and `No_plan_exists` as well (so that each possible output has at least one test expected to produce it).

I suppose this needn't necessarily block merging this pull-request though.


Done.


#10

- wants touched coordinates x and y value


I don't add the ```lblas``` anymore. So ```lblas``` should be in ```flags``` already. Right?


Testing, so far all good, i have merged only needed for my tree changes. Its seems my tree is more advanced, some checks missing with your tree. Take a look and compare, maybe its can be good.
I have tested usb otg, file transfer no issues. Also mtp... but i have some LG moods there that set other buffer size and again more checks...


MSは面倒見いいのでこっち側の根気がつづくまで、でしょうかね…
2010は開発環境軽いんで好きでしたがC++11まわりとかもう限界きてる感じもしたりしなかったり


Oh, so when you call `reorder` after calling `order`, you are sorting the list that was ordered by `order` first?  If you were to call `order` after `order`, would that make the first `order` call irrelevant?


We also check flags other than blas. Right?
If so, I need to change the ```tmp_prefix``` and also the name of the function.


Not sure it is important here but in v5:
* we do have parent>child relationships between summits (or other WPs), with a main summit having satellite summits around.
* for routes, I don't think this kind of relationship exists, we only have "plain" associations between routes that have common parts.


Sorry @roselin-yohan I don't have enough experience with Java to be of much help.  You may want to do some searching on github for another repo that has a solution in Java.  I did a quick search and found this one:  https://github.com/TheCK/codeChallenges/blob/master/codeEval/src/main/java/org/ck/codeEval/easy/details/Main.java


That's not the bug- the bug is that the `end` should have been checked against the max size... Now you are missing an entry. I think you fixed the real bug in later commits, but the condition should be turned back to `<=`


Sure!  just use the given format and submit a pull request.


Setting two categories for each item imported


Get all the users from the model


That's good!


Yes, that's my understanding of the feature at least. We should give it a try in the console tomorrow.


Thanks for the mention!

I realised that I'd missed adding to the readme a few days after I made the PR, but then promptly forgot about it again. Thanks for adding!


I tried to have translation-canary skipped entirely, with https://github.com/rhinstaller/blivet/blob/master/tests/pylint/runpylint.py#L38, since translation-canary pylints itself with its own configuration and whatnot. You might need a new pocketlint for the ignoreNames support though.


Perso je suis pour limiter les dépendances

Le 14 janvier 2016 à 15:48, Yannick Schurter <notifications@github.com> a
écrit :

> J'hésite. Le module est bien, court et simple, mais il ne fait que
> retourner une regex qui n'a quasiment pas bougé depuis sa création (
> https://github.com/regexps/doi-regex/blob/master/index.js#L17). Je ne
> sais pas trop si je devrais l'intégrer ou me contenter de récupérer la
> regex. Des avis ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ezpaarse-project/ezpaarse/commit/ed1b7341ce1d50ba0f6c2fc790da46f84d6bb97d#commitcomment-15451363>
> .
>


As said above, the content of this function might depend on the current document type.


> Makes sense and looks good to me. I'm not sure why you didn't create a JIRA issue though.

Yeah.... I got distracted.


@ligadata-dan
could you please explain the code behavior now? i mean the older code used the watch service and responded to each event (new file) using take() and pollEvents() and the response was queuing the file name enQBufferedFile(fileName). but now i am not sure how new files are caught and where is the response to such events.
Regards,


I think if we make it pluggable format, we offer a possibility to create a message serializer for other contributors, or in other languages.
I think we should talk IRL, becuase at once I've already mentioned it to you, and you liked the idea of serializers.

I accept that we should this default serializer into the lib, but in this format (I mean plugin) should be a better base point how to create a new serializer.


don't change the tmp_prefix. This is just the prefix of the file we will use to test. As we test blas flags (which ever version) it make sence to use that name even if the flags are different.


TeamCity Civic Assembly :: Build backend + frontend [Build 166](http://54.229.176.143/tc/viewLog.html?buildId=459&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


Yes, that makes sense now by seeing the code. I am assuming `::` means that a class is nested?


And logmsg.c also has double underscore and all of the __tls_deref has double underscore.


en liten test


Thanks , It works well


please change method name to more meaningfull - it is not posting user but saving so 'save' or 'saveOrUpdate' will be better


It's just temporarily for making the compilation work. It's on my list to get it back ;)


Хрень, что оно каждый раз вот тут будет делать ченжи.
Как вариант, либо убрать инжектор, или сделать фейковый индекс лоадить все через него и добавить его в игнор.

Тимур FYI, наподумать.


That was probably because you copied my mistake before I fixed it ;)


Fix-allocation-for-feneSolarDelaySeq (JasonGlazer) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-82.98%25-red.svg)


initially coded on OSX, ... worked xD
strange case insensitive os


No we should fix other code.


Yay, ES6 stuff!


We might want to be a more careful here - before that change we were not passing any maps parameters which means that we were effectively passing `{ inline: true }` - since [this is a default value](https://github.com/postcss/postcss/blob/master/docs/source-maps.md)
IOW - the default way postcss is working is generating inline maps. The default way postcss-cli is working should be the same.


@alexjab :eyes:


This is so obvious a basic understanding of WPF would overcome the need of this example.


I think this is broken, and this code will only get executed with dangling images, you must remove indent.


Wut? So strange


=p


We should avoid increasing the version number during development. The Release tag is increased by the ``make-rpms`` script.


Really, really on top!


don't use full url, '/users' is enough


It was probably automatically added by Eclipse at some point, I'll path this commit.


The purpose of this entity (schema) in general is questionable.


Morning @heckj ,Nope,I am sorry for that. I am just trying to use these code with packer to atlas to build a vagrant box ,Please ignore that.Thanks a lot.


TeamCity pull requests :: netty [Build 1029](https://garage.netty.io/teamcity/viewLog.html?buildId=4749&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6372, ignored: 23 Build time: 01:21:56


Do we need imageID at all anymore?


This can be accomplished with the `default` schema property, but good implementation!


How did Chesley give me the :+1: on this... he was sitting right next to me...


why did you change this?


Good but possibly could live in another schema if addresses needed to be used for things other than user shipping.


What is the difference between a cart and an order that hasn't been placed yet?


> Do we have any documentation about it in the source?

Not really. I will try to write some.


@domenkozar I suppose you didn't notice 1.4.0 was released earlier today? :) I'm on it


use relative path, don't use port 8080 as in most cases it is used by server, spring can choose port randomly


Je comprends pas pourquoi il a utilisé un **lookahead** qui complexifie inutilement la regex, mais elle marche.


`output` should be called `name` here


No need for `done` here but I get you, I get you.


All the tests in this file use equals for a reason -- `contains()` will match even if the returned permissions are incorrect in some cases. For example, if there are two ACLs returned in the line above.


also need to check if we are not writing to stdout - I don't think we want to dump source map there


No need for a describe of `should be able to`


Ahh yes, I'm surprised I missed that.  I agree it does make more sense in Activity


Same here.


这个优化挺好的。可以单独提交一下。
其它部分的可以考虑一起合并到node-weixin-card里面。


Че это за говноиконка из текста???
На сайте логотип совсем другой: http://it-structure.ru/


Why SMS service is not allowed ? Thank you


Replaced 'category' with 'severity' and 'Note' with 'information', and made severities lowercase in calls.


@php-coder fixed now


OK


Need more verbiage: what's the default, where the source map file goes etc.


This test is called `done` right away.


@mhkuu Would you mind close-reading this for a correctness check? Of course I will also write a bunch of test cases.


Don't bump version please. It's done automatically during the release when changelog is generated.


maybe we should thow or log here


Форму получили раньше, а параметры ищем на странице при этом. и нет проверки, что форму нашли всё-таки


Right now the simple approach will work, although this assumes we'll always run from the base source code directory. If this expectation breaks, then the test will break :)

It's fine for now, though.


Can you use some permutation of `uint64_t`? And do you want to make this a CMTK option?


This test should query the database to make sure the route actually persisted the updated information.


Не нужно html_entity_decode!!!
replaceTagsAndSpaces уже всё содержит в себе.


Should this be in another patch ?


consider switching to REST testing framework like rest-assured


Не надо переусложнять регулярное выражение учетом разных кавычек (или они сильно варьируются на этом сайте?)


Do you mean ``waypoint_locale``? (trailing e)


It's better to make `break_scylla.sh` executable, and leave the interpreter to the shebang (no need to add /usr/bin/bash directly).


:star:


@hadley I think this needs to be before L39 to work around the fact that `file.exists("dir/") == FALSE` on windows. It looks like the reason we are getting these Appveyor failures https://ci.appveyor.com/project/hadley/devtools/build/1.0.131#L305


```
^Only in
```
Will catch pattern only on start of line


I don't think this is right.

We're getting this warning:
```
_imaging.c:474:9: warning: ‘r’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     int r, g, b, a;
         ^
```

Assume that we're passing in a tuple, and we've got a RGB image, so it's a IMAGING_TYPE_UINT8.

Tracing that block through, neither of the Py(Int|Long)_Check functions will hit, so at #498, r is undefined and no error has occured, yet we don't have an integer so rIsInt == 1.


Consider using the error handling middleware here.


As you said you must remove the node before choosing a verification node


LOL


Тут message не переименовали) В new есть какой-то смысл?


I've been using Wpf for more than 10 months now, while attempting to follow MVVM and avoiding all uses of code-behind. Consequently, I had no idea how to do this, or I wouldn't have created the issue, and showed multiple code attempts that failed.


Why not `const`?


The local_sr and local_net are held in common (shared) by all the hosts.
Having read the rest of the code I see that this shouldn't cause a problem since we don't use any VBDs or VIFs at present; I'm not immediately certain whether it would if we did.
In any case it seemed rather odd at first reading.
Perhaps a comment to reassure the reader that this is intentional and won't matter, or mention the situations in which it would?


Fix-allocation-for-feneSolarDelaySeq (JasonGlazer) - x86_64-MacOS-10.9-clang: OK (2045 of 2045 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Can't we infer (or use sane defaults) for the serde parameters of `countByKey` instead of passing `null`?


Be careful with not using `exec` -- don't believe the lies that `OrderItem.findById(id)` returns a *real* promise.


I really likes the *change that is coming* 0.0
מישהו יכול להסביר בפשטות מה המטרה בצורה הזאת של קוד רובוט (סתומרת מה הייעוד של תכנות כזה ואיך הוא יותר טוב\יעיל מקומנד בייס)


рег выражение предполагает, что класс последний атрибут в теге. А если там будет пробел или ещё добавится атрибут? Надо не забывать добавлять [^>]* в конце тега


@seffenberg-naspers Sure. That works for me. I'll look into the timeout issues as well. It's not incredibly surprising since phantomjs takes a REALLY long time to compile.


It still think that the pattern `./include/**.h` is wrong. What should it match?


This route updates every order?


waypoint_localE ?


add transaction


Love the use of `Promise.all` despite me not understanding the point of this route.


Also known as `Review.create(req.body)`


should it be a different `morse_start` time?


Although a nice idea, the conceptual class relationship seems a bit odd - a RepairMonkey inherits from CorruptorMonkey, meaning that it's a destructor and a rebuilder at the same time.

The more I think about it, the more I come to the conclusion the disruption and repair methods should belong to the base Nemesis class, then each specialized class can refer to them.


Необходимо также добавить счетчик __tariff (текстовый, в манифесте не объявляется), содержащий название тарифного плана.
И счетчик licschet - номер лицевого счета (который надо обычно указывать для совершения оплаты). Эти счетчики вообще всегда надо по возможности получать.  Во всех провайдерах.


Remove all the temporary files before commit next time. By temporary files I mean the files which have '~' in the end.


My derp brain forgot that I wasn't the one who fixed main menu, it was @wfikkert who did that... sowwy :X


Cool!!!! :+1: @mathiasrw Thank you for right things!


TeamCity Civic Assembly :: Build backend + frontend [Build 166](http://54.229.176.143/tc/viewLog.html?buildId=459&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests failed: 20, passed: 1476, ignored: 12 Build time: 00:19:14
### Failed tests
```
Document type tests: Should not create new document type if cancelled: <no details avaliable>

Document type tests: Should add new document type: <no details avaliable>

Document type tests: Should not change document type: <no details avaliable>

Document type tests: Should change document type: <no details avaliable>

Document type tests: Should not delete document type if cancel pressed: <no details avaliable>

Document type tests: Should delete document type: <no details avaliable>

Media type tests: Should not create new media type if cancelled: <no details avaliable>

Media type tests: Should add new media type: <no details avaliable>

Media type tests: Should not change media type: <no details avaliable>

Media type tests: Should change media type: <no details avaliable>

Media type tests: Should not delete media type if cancel pressed: <no details avaliable>

##### there are 10 more failed tests, see build details
```


wah


TeamCity pull requests :: netty [Build 1030](https://garage.netty.io/teamcity/viewLog.html?buildId=4750&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6230, ignored: 21 Build time: 00:42:29


`EdgeNavigator`, not `EdgeNavigation`


You should explicitly set the expected framerate of the pose sensor in the builder script: it is really important for this test (and 60 fps may not be the default forever).


Maybe we can leave the disruption method in the Nemesis base class and lend
a a list of Repair object to it.
Then we let him choose

On Thu, Jan 14, 2016 at 4:25 PM, Lucas Meneghel Rodrigues <
notifications@github.com> wrote:

> Although a nice idea, the conceptual class relationship seems a bit odd -
> a RepairMonkey inherits from CorruptorMonkey, meaning that it's a
> destructor and a rebuilder at the same time.
>
> The more I think about it, the more I come to the conclusion the
> disruption and repair methods should belong to the base Nemesis class, then
> each specialized class can refer to them.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/benoit-canet/scylla-longevity-tests/commit/f6830330bd2a540b2d71f25428ac995cfbd2531f#commitcomment-15452377>
> .
>


All that's left to do is make a PR and see what the others think. Would like their opinion on changes to AST_Lambda.prototype. init_scope_vars.


Можно название функции до "add" сократить. Да, между "newMessage" и "message" не сильно большая разница.


Hehe, nice piece of query :P


I like the test better like that. What about also checking the actual pose? (ie, the distance should be either halved or doubled)


I already found that this should include the space character (` `). This is fixed in the next commit.


Same here.


Okay, I was trying to do it on F22. I'll drop this commit and get with the times instead.


if the following:

    return (opts.redirect_uri_scheme and opts.redirect_uri_scheme or ngx.var.scheme).."://"..ngx.var.http_host..opts.redirect_uri_path

works for you then please apply that, turn it in to a PR and I'll merge it in the main branch; let me know


Fix-allocation-for-feneSolarDelaySeq (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (951 of 951 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.63%25-green.svg)


Huh? `nozzle_size` is now gone but is used immediately in the line below!


I see https://github.com/pyexcel/pyexcel-webio/commits/master got an update to pass on the file_name arg.  Looks good for me.


Fix-allocation-for-feneSolarDelaySeq (JasonGlazer) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-82.98%25-red.svg)


fixing issues from commit 766c861


thanks


My patch mistakenly single quoted 'arguments'. Probably best to be consistent with rest of UglifyJS2 code base and use double quotes.


This line is indented farther than I would recommend. Try changing your default to 2 spaces.


Nice!! A classic. I don't think my kids have seen this movie yet - maybe this weekend I'll address that.


@shucknjiveturkey Good. :+1:


Yup. Yikes! Thanks!


Updated the Jenkins job running on your betaflight branch to use the makefiles, skiping the "fake_travis"-script used before. Now you will see build failures here too. http://andwho.sytes.net:8080/job/BorisB%20BetaFlight/
Jenkins checks your repo for updates 4 times/hour and runs the builds if there are new commits. No need for me any more to keep my repo in sync manually just to see those results.
I could let Jenkins spam you with mails on build results... All or only failures. But I am not sure you would want that...or? You can check the results at anytime manually.


Allow, not avoid :)


Sorry @coffy  but you're missing this line.. You must delete it


Yeh I have relented


Instead of doing the elapsed increase here, we can always do

    start_time = time.time()

Before the while loop starts

And then

    elapsed time = time.time() - start_time


You probably don't want this... if this is here, the method will ALWAYS return a task, even when one is not found.


#17 おわった


Used .equals. THIS IS GOOD.


That'll be an even more faithful representation of the timeout, as it'll take into account the time run_cmd took to run.


Aha!


@diegomarcon even better :)

Great work, dude :+1:

LGTM


Yep, good catch.


barki@ninja-network:~$ npm install data-lasso --save
data-lasso@1.0.1 node_modules/data-lasso
├── three-orbit-controls@71.2.0
├── three.regular.helvetiker@1.0.0
├── jquery@2.2.0
├── three@0.71.1
├── d3@3.5.12
├── lodash@3.10.1
└── backbone@1.2.3 (underscore@1.8.3)


The version in my local repository uses the criteria from the paper, I'll check which one performs better.


Legacy code! I can't do much!


Fixed.


Fix-allocation-for-feneSolarDelaySeq (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2083 of 2083 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Why was the stats removed in this commit?


Yes, I did the removing part at the end. Maybe it's best to remove before, to avoid other code touching the node being operated on.


@leejordan think this should use `@font-family-sans-serif`?


Right, I'll add a logging saying that the code couldn't parse the line.


lgtm


The problem with this simple fix is that the field len field still reports the length of the name field as being something that is not allocated.  So either we should set the len field to 0, or we should just drop the variable entirely as proposed, as I don't think it is worth keeping this confusion around.


Should there be a default value for invalid action names? e.g.
```
if (action=="compress_ram") {
    sample_action=SAMPLE_ACTION_COMPRESS_RAM;
} else {
    sample_action=SAMPLE_ACTION_NONE;
}
```


attention Said au formatage de la page ^ ^, dans sublimetext: voir jsformat


Would be better to use `compat.as_bytes` here and with `mode='wb'` when opening the file.  Is `compat.as_bytes` available from tensorboard?


Same: `compat.as_bytes`.


Actually it should use the mixin `.graze-font()` but yea, it's wrong so good catch. Will fix.


TeamCity LabKey :: LabkeyModules15.3 :: Git sqlserver 2014 [Build 89](https://teamcity.labkey.org/viewLog.html?buildId=296738&buildTypeId=LabkeyModules153_GitSqlserver2014) outcome was **SUCCESS**
Summary: Tests passed: 218 Build time: 00:15:26


Nevermind, the ```sample_action``` var is already initialized to ```SAMPLE_ACTION_NONE``` anyway, so there would be no bug if the config is broken.


`res.redirect`?


Сейчас неконсистентно с названием параметра в интерфейсе и другом классе.


111639676-UniqueThermostats (DavidGoldwasser) - Win64-Windows-7-VisualStudio-12: OK (2318 of 2384 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.23%25-yellow.svg)


Passing pointer to uint8_t is quite bad idea. Either pass pointer to int (default type size) or pass argument by value.


Will you use fat arrows or not?


If motion capture is enabled here, why don't you start the optitrack node in the corresponding roslaunch ?


Added a javascript method for PING ing the server when the page is refreshed or closed.


LGTM


I think it's better to use DataInputUtil.readBoolean/writeBoolean directly.


Intentionally using function declaration instead of fat arrows tells people that the new scope of the function is important, which in this case, it is not


this code crash, (p, o) -> (m, p, o)


Interesting.
Then it might be something transient or e.g. due to I using a Firefox test build.


This need to be a little tested, you can just swap easgd in the example.


This `.then` function will run before the orders/order items being created in the above function have completed.


:muscle:


I'm puzzled about ValueMethods -- I must have checked in the wrong version.

Anyway, LGTM


Why is this needed?


No `return` statement.


Thanks!


My build is newer r48235, but there should be no siginificant difference in Openwrt, and of course Luci itself is the same.


would be more instructive with an example like:
`To prove that a.b.c.d is rightfully synthesized from *.d, all we have to prove is that c.d does not exist`


develop (DavidGoldwasser) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Alternatively, GOPACKAGES=$(shell glide novendor)
Then, the vendor packages are not tested by default.


What about moving everything related to toggling the `focus` class inside the `if ( 'ontouchstart' in window)` condition? That way the DOM is not queried and variables aren't declared unless the device supports touch. It's a minor optimization I admit, but is there any reason not to?


you need to change it to ?rel=0


x'd out on purpose?


I'm not sure that by default we will use the motion capture. Will we ?


Can't merge this. Naming convention not appropriate.

Use names as
'minimum_team_size'
'maxiumum_team_size'
'spoc_user_id'
'contact_details'


@lamblin computed on paper that it should be `m + (p-o)`


First sample is ignored. But it can be discarded without consequences here ...


`mame` -> `name`


Don't use spoc_of_the_event. Use 'spoc_user_id'
And this will be an integer field not a string field. Admin will have to search for a spoc and then add their ID here. You might have to modify this for that functionality.


I think correct replacement is 'wpml_current_language' filter,
it's appropriate for frontend and backend calls.


LGTM


00-HTML-CSS-basics/01-HTML/01-The basics of html/multimedia.html

yeah, sorry about this one, it wasn't supposed to be commited, i didn't even start it, just pasted a youtube link.


xczxc


You should depend on `Cache` (maybe use `derive()`), not on `IStorage`.


"Once voted the greatest Canadian of all time, Tommy Douglas was a prairie politician who believed in democratic socialism, the crucial role of civil rights, and the great potential of cooperation for the common good. He is best known as the “Father of Medicare.”


(Sorry, not sure where else to place this comment. It was either here or a direct message/e-mail). Do you know if there's something like this for the desktop app version of Slack, @laCour ? Thanks, man!


00-HTML-CSS-basics/01-HTML/01-The basics of html/expenses.html

lol, I know, another one that I just didn't finish but commited anyway


Because I forgot it! :smile:


Odd indeed. I didn't think much about this when I saw it, but it matches the same things as `./include/**/*.h` in bash with globstar enabled.

I think the reason for this is that the wildcards of tar do no treat slash differently from other characters. See the very incomplete doc here: https://www.gnu.org/software/tar/manual/html_section/tar_50.html


cool, thanks


You're right!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11565](https://teamcity.mesosphere.io/viewLog.html?buildId=105284&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:04:23


Different things


Nice!!


I personally prefer aligned param names. It makes the phpDoc easier to read.


00-HTML-CSS-basics/01-HTML/01-The basics of html/signup.html

cool


Is this some debugging code that slipped in?


Foi apenas um teste


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


should by uppercased


Are you a troll or what ?
- Please read above 2 comments this is not a test for fishbench

Even if it was
- If you just changed const, your bench should be the same
- The SPRT bounds would have to be something else.

Please delete this test.


TeamCity Civic Assembly :: Build backend + frontend [Build 167](http://54.229.176.143/tc/viewLog.html?buildId=464&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


We should update the example to call it. Good idea to add this.


This didn't come with a version bump, and NPM still seems to have the react 0.13 dep instead of 0.14


Since their new infrastructure, BT removed SSL ability (SSL is redirected to non ssl domain).


I wondered this, too, but it is removed in the next commit. So you could squash this change altogether.


Holy shit that is far simpler.


I need to get in on this.


@SubJunk Regarding the scaling and video, it doesn't seem to be entirely true. I have several video files where the thumbnail isn't scaled, and that seems to happen if there's a .jpg with the same name in the same folder for example, so that the thumbnail isn't "generated".

What I really don't understand is what you need the ```isSquare``` options for. Both ```ThumbnailHeight``` and ```ThumbnailWidth``` are already in the renderer configuration, so why do we need to know if they are square? That's a given if width and heigt are equal.

Also, I still don't understand what the scaling is there for. On the 3 thumbnail capable renderers I have tested (PS3, MediaMonkey and the web interface) it looks worse when it's "scaled" (padded with black in reality). What is the purpose of the scaling? Do some renderers stretch them if not scaled?


EdgeNavigator, not EdgeNavigatior


To meet the requirements, each section needs to contain three block elements, so this img (which is inline-block), should be contained in a block element, like a div.


Ok, deleted run. I will try Fishbench. If it is a speedup, how do I let @zamar to approve the commit?


I understand that `.htaccess` should not be in the repo.  It is listed in `.gitignore`.  However,
it disappeared from my local repo when I pulled your changes, and it took a little while to figure
out why my euclid site no longer worked.


:thumbsup:


竟然笑得夸张至此 - -||  还一堆问题问你呢 就跑了... 得了 我还是 明天再弄


Oddly enough, the bench was different. This means it is a functional change.. Strange.


Je suppose qu'il faut prévoir une migration des anciennes données aussi.


Promises polyfill https://github.com/jakearchibald/es6-promise


LGTM


remove?


the empty ones do render like they have water in them, pinging @bonii-xx for that, he might know what's up with that


This will make sure that the transition method of the provisioner barclamp is also executed. And that will then trigger a chef-client run on the admin node. We need that to have the pxe_config and autoyast profile written.


Add a description of what this does.


sorry, I mean to indicate there were two occurrences of "issues" that need to be swapped here


```python
delta = (dt - last_dt).total_seconds()
d['delta'] = max(0, min(4, delta)) * 1000
```


This is great code!


It looks like the code behaviour actually changes with this patch, since the `longkey` string no longer has a terminating null byte, like it used to have with the simple `strcpy` function call.


What if I can't even?


I'll add a bunch of more structures for multithreading.


The method name used is copy_global_to_local. Not this one.


Looks good! Let's push!


Maureen Hernandez would like to connect on LinkedIn. How would you like to respond?

Accept: https://www.linkedin.com/e/v2?e=tu2gt5-ijeam031-fv&a=preRegInvite&ek=first_guest_reminder_01&li=14&m=hero&ts=accept_text&sharedKey=qqKAF7gI&invitationID=6092120483619233792

View Maureen Hernandez's profile: https://www.linkedin.com/e/v2?e=tu2gt5-ijeam031-fv&a=preRegInvite&ek=first_guest_reminder_01&li=3&m=hero&ts=profile_text&sharedKey=qqKAF7gI&invitationID=6092120483619233792

Has recibido una invitación a conectar. LinkedIn utilizará tu dirección de correo electrónico para enviar sugerencias a nuestros miembros en funcionalidades como Gente que podrías conocer. Puedes darte de baja aquí: https://www.linkedin.com/e/v2?e=tu2gt5-ijeam031-fv&t=lun&midToken=AQFmrFVhGEd36Q&ek=first_guest_reminder_01&li=16&m=unsub&ts=HTML&eid=tu2gt5-ijeam031-fv&loid=AQFu5p1oiX8bGwAAAVJA38qiKFahLeNgGqmbEWxl_gt2N8OjCju_3pKs6Bde1LHF4kHeVbEh6GXu9VZVqfmFv08qyYmDuVy_YpapM2Xj4u0r3ND1CouHIOmVKh1L18YETXHGUsvx-mMAHzRG9IC_qA-cqRl13Tm9kkf7uOmyVMCnvVahUMgEoGaO705BibHpckAC

Este mensaje se ha enviado a reply@reply.github.com.

If you need assistance or have questions, please contact LinkedIn Customer Service: https://www.linkedin.com/e/v2?e=tu2gt5-ijeam031-fv&a=customerServiceUrl&ek=first_guest_reminder_01

© 2016 LinkedIn Corporation, 2029 Stierlin Court, Mountain View CA 94043. LinkedIn y el logotipo de LinkedIn son marcas registradas de LinkedIn.


Maybe we should actually make `RequestImage` and `ImageFromLocalFileAsync` accept a `CancellationToken`.


self.assertAlmostEqualPositionThenFix do that (and a lot more to avoid to increase errors between several sub-step).


There is no such API anymore. Maybe the readme should be updated.


I don't understand your remark


I followed that approach before the latest changes. The problem that I found with that systemd unit was that systemd wasn't aware if the java process died.

This systemd unit relies on a bash script and it seems that systemd only cared about the bash process instead the java child process. During my tests sometimes the java process died and it left the playbook stucked in the task "waiting for Jenkins to be ready".

Thats why I run the java process directly from the unit with the option "Restart":
https://github.com/amatas/ansible-jenkins/blob/master/templates/jenkins.service.j2#L23


Because of changing the master code, please merge it to your branch again.


### [Codacy](https://www.codacy.com/app/johnsmith0508/cubes/commit?cid=24708140) detected an issue:
#### Message: `Object prototype is read only, properties should not be added.`

#### Occurred on:
+ **Commit**:  12187bc2ccb9815e621f9aeedb697aef48060d89
+ **File**:    [app.js](https://github.com/Johnsmith0508/cubes/blob/12187bc2ccb9815e621f9aeedb697aef48060d89/app.js)
+ **LineNum**: [17](https://github.com/Johnsmith0508/cubes/blob/12187bc2ccb9815e621f9aeedb697aef48060d89/app.js#L17)
+ **Code**:    `Object.prototype.allFalse = function() {`

#### Currently on:
+ **Commit**:  8c7163504dfe89d833d9339bb3113ad0dc49a317
+ **File**:    [app.js](https://github.com/Johnsmith0508/cubes/blob/8c7163504dfe89d833d9339bb3113ad0dc49a317/app.js)
+ **LineNum**: [18](https://github.com/Johnsmith0508/cubes/blob/8c7163504dfe89d833d9339bb3113ad0dc49a317/app.js#L18)


Yes, good call.


tested ??


Thanks for your review!


Exact!


Code behaviour change, as above.


Das ist nur ein Beispielscript, um zu testen, dass der Scriptaufruf funktioniert, hatte ursprünglich nur ne Hello World Ausgabe, die man aber nicht sehen konnte, also hatte ich es umgeschrieben, eine Datei zu erstellen, damit man sieht, das es auch wirklich ausgeführt wird.


persianFazbot


You are living in the past ;-)


Am 14.01.2016 11:27 vorm. schrieb "John Biddiscombe" <
notifications@github.com>:
>
> HPX_APPLICATION_STRING appears over 250 times in HPX, whereas
HPX_APPLICATION_NAME is <10
> Are both really needed?

At the moment, yes. I think cleaning that up should be handled in a
separate PR.

>
> —
> Reply to this email directly or view it on GitHub.


What about the related case where the user clicks on *Validate*, and then notices that the document is not saved, so they're afraid the system may validate the old version of the document, and they quickly click *Save*. This ends up sending twice the same `write` data to the server, which in the case of invoices will cause the same tax line to be created twice again.
Shouldn't we prevent the user to click *Save* while an action is already executing (which implies that the record is already being saved)?


Why are we always writing this? Looks like we can skip this if the cached data is valid.


Cool... I will check later.


File1: Line_of_Credit


oh yes, sorry. Could you then comment quite a bit the unit-test, like:
```python
# we first tell MORSE to move the robot for 2 *real* seconds -> this now corresponds to 1 sec only in the simulator
simu_time_elapsed = self.send_speed(v_w, simu, 1.0, 0.0, 2.0)
# as a consequence, the robot will have moved forward by only 1 meter
self.assertAlmostEqualPositionThenFix(simu, [1.0, 0.0, 0.10, 0.0, 0.0, 0.0], precision)
# we can check as well that only 1 second elapsed in the simulated world
self.assertAlmostEqual(real_time_elapsed, 1.0, delta=time_precision)
# and that even the sensors have slow down: we received only 60 pose updates
self.assertAlmostEqual(self._count, 60, delta = 1)
```


wtf?


Should we maybe clear the userdata if `!isKotlinBinaryClass`, to avoid wasting memory if a Kotlin-compiled .class is replaced with a Java-compiled one?


If you like using jshint, please consider installing it locally, as it will be removed as a dependency.
Also, locally is the best place for it to reside.


Oups, sorry, I misread the code. Forget about my comment.


This change has left me puzzled many times.

I've used p4.el for many years (since 2004/5 I think) and have the last year thought I've mistakenly been pressing `C-c C-c`, when I have in fact done `C-x C-s`! I believe `C-x C-s` should only save the state/draft of the form, not submit it, IMHO. I understand your rationale, of course.


But aren't we already sure it's happening because of the next block (state changes)?


Using `angular.mock.module` is necessary here, as `module` is overridden by webpack's module definition.


@SungMatt It was very very messy, looking back on it I could have done it so much better...
if there isn't a newer version already in Cardinal perhaps I'll revisit this


Also this should probably be `list(header)` instead of `header.keys()`.  On Python 3 this will iterate instead of return a list, and we're modifying the header while iterating over the keys.  This really should be prevented in the first place, and I opened an issue for that but never got around to it spacetelescope/PyFITS#74


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (mjwitte) - x86_64-MacOS-10.9-clang: OK (2036 of 2046 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.51%25-yellow.svg)


r+


On latest master, possibly after this merging, I am getting "500 internal server error" on all actions. Logs show:-
"PHP Fatal error: Class 'PMA_Util' not found in /../phpmyadmin/libraries/check_user_privileges.lib.php on line 180,".
Reproducible on demo as well.


LGTM


Please always use named functions (or classes) when defining components, as they might get handy for debugging if something goes wrong.


@vivihuang this is not  secure.... i have to go in and change passwords.

i was using the settings file on my local machine to push up to the production .. if your going to change how the fab file does.. just post in slack how deployment needs to work.. and/or just comment it in the fab file.


this loop can be simpler:
`for(const auto& c : getMapInstance(type)) result.push_back(c.first);`


### [Codacy](https://www.codacy.com/app/johnsmith0508/cubes/commit?cid=24708140) detected an issue:
#### Message: `Function 'anonymous' has a complexity of 5.`

#### Occurred on:
+ **Commit**:  e5e39eb942e2fd8e3786eb85455a5f8cfb7a654e
+ **File**:    [app.js](https://github.com/Johnsmith0508/cubes/blob/e5e39eb942e2fd8e3786eb85455a5f8cfb7a654e/app.js)
+ **LineNum**: [69](https://github.com/Johnsmith0508/cubes/blob/e5e39eb942e2fd8e3786eb85455a5f8cfb7a654e/app.js#L69)
+ **Code**:    `		socket.on('chat message', function(message) {`

#### Currently on:
+ **Commit**:  8c7163504dfe89d833d9339bb3113ad0dc49a317
+ **File**:    [app.js](https://github.com/Johnsmith0508/cubes/blob/8c7163504dfe89d833d9339bb3113ad0dc49a317/app.js)
+ **LineNum**: [89](https://github.com/Johnsmith0508/cubes/blob/8c7163504dfe89d833d9339bb3113ad0dc49a317/app.js#L89)


Bask in the pleasure of never having to do that again :smile:


TeamCity Civic Assembly :: Build backend + frontend [Build 167](http://54.229.176.143/tc/viewLog.html?buildId=464&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests failed: 20 (1 new), passed: 1476, ignored: 12 Build time: 00:17:46
### Failed tests
```
Venue category tests: Should delete venue category: <no details avaliable>

Document type tests: Should not create new document type if cancelled: <no details avaliable>

Document type tests: Should add new document type: <no details avaliable>

Document type tests: Should not change document type: <no details avaliable>

Document type tests: Should change document type: <no details avaliable>

Document type tests: Should not delete document type if cancel pressed: <no details avaliable>

Document type tests: Should delete document type: <no details avaliable>

Media type tests: Should not create new media type if cancelled: <no details avaliable>

Media type tests: Should add new media type: <no details avaliable>

Media type tests: Should not change media type: <no details avaliable>

Media type tests: Should change media type: <no details avaliable>

##### there are 10 more failed tests, see build details
```


IMO, we really should abbreviate "work-package" where ever it is used as a prefix.


Did you forget to close your body tag?


Please invert the if. The condition be easier to read without the "not".


We should eventually move to https://github.com/petabridge/NBench or the like, lots of features from GC checking to taking stats in these micro benchmarking things.


This script converts spoken numbers to digits using the words2numbers.js module


Added reference to words2number.js module


@Aeusman @j6k4m8 This is amazing. What do you guys think about adding this to the ndio docs somewhere or maybe create a ipython notebook when it is merged into the master branch?


Ok perfect, I added it. I have uploaded the app but Google takes some hours to publish the game.


Neat. Beat me to it.


Thanks for review!
I pushed the fix as the latest commit in this branch, if it helps.


LGTM


This is the shit :+1:


Defer здесь будет тормозить


oh wow, I'll fix it quick! thanks


i think we should add it to [openconnectome/ndio-demos](https://github.com/openconnectome/ndio-demos) among other places


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (952 of 952 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-27.33%25-green.svg)


is this working? I think you should pass `None` if you want to use OCP, not `''`. Maybe a bug?


Ah yes. Sorry, I should have given you a heads up.

In any case, for future ref/installs, its in the README here:
https://github.com/friendly/DDAR#htaccess

On Thu, Jan 14, 2016 at 7:57 AM, Michael Friendly <notifications@github.com>
wrote:

> I understand that .htaccess should not be in the repo. It is listed in
> .gitignore. However,
> it disappeared from my local repo when I pulled your changes, and it took
> a little while to figure
> out why my euclid site no longer worked.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/friendly/DDAR/commit/b273db1e7ddbece295409b8d058cc4c75c88a317#commitcomment-15453303>
> .
>

--
—
Derek Harnanansingh
Arietis Software
http://arietis-software.com
Cell: +1 250 217-1850


Good catch!


Good idea... but now we always have a space at the end....


hyperstyles is a module I wrote to bind hyperscript-like functions to CSS Modules, to simplify their use and readability. https://www.npmjs.com/package/hyperstyles


??,wie, wo was? Tools laeuft ohne probs durch jetzt.

LG Jens

2016-01-14 17:06 GMT+01:00 Christoph Junghans <notifications@github.com>:

> You are living in the past ;-)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/votca/tools/commit/edc99701214895fa1a4625982e989e420a269e95#commitcomment-15453549>
> .
>


Usual systemd style is to keep the logic flat:
```
_cleanup_ ... *timer = NULL;
...
r = sd_event_add_time(...)
if (r < 0)
   return r;
r = sd_event_source_set_enabled(timer, SD_EVENT_OFF);
if (r < 0)
  return r;
f->post_change_timer = timer;
timer = NULL;
return r;
```
This way it's easier to read and extend in the future.


genderについて
0:男
１：女
-1：未選択


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1159](http://teamcity.monogame.net/viewLog.html?buildId=13581&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


All straightened out!  And, thanks for the nav change.


Why? I don't see it as best practise,.


don't you think it's simpler to compare two sets via `==`?
`ASSERT_TRUE(knownIds == registeredIds);`


According to
http://tests.stockfishchess.org/actions
(see 14-01-16 04:42:34 mgrabiak optimize_threads stop run: Wrong bench in base.exe Expected: 8076724 Got: 8603285)

Your "test" bench is ok, but not your "base"
most likely it is your base which is not the right one.

Before you run a speed test, make sure your bench are identical (they should).

If you have a positive result, and statiscally significant,
to submit your result, go on your git page
https://github.com/stockfishdeveloper/Stockfish

select the branch you want to submit,
and click "New Pull Request"

Fill in the details, providing your speed test output.
Here you go.

Some other people will try the change too, and the change may be approved or not.

But really, I doubt you can measure any difference.

Some other people will have to confirm the speed up


I know that. You get zero gyro values. It cant harm anything.


LGTM


@pluma is the version exposed anywhere in JS? So that as a transition, I could do something like

```JavaScript
if (process.VERSION < 2.8) {
  require(/* old style */)
} else {
  require(/* new style */)
}
```


I have not read the schema in totality. @Aeusman will have a look. Also, @Aeusman we are phasing out OCP which is replaced by ND now.


Yeah, that is a good idea especially once we have dealt with the low-hanging fruit.


I feel like in that case ```MvxImageCache```, ```MvxFileDownloadCache``` and ```IMvxLocalFileImageLoader``` platform implementations get more complex without a strong reason. These classes only used inside ```MvxDynamicImageHelper```.

Though maybe it's just my laziness :)


Can you explain why? It is actually just being used to read into other variable. I could of course just pass it.


This should be inside of the `for img in images:` loop, so you need to indent this four more spaces


Other versions do not trigger it, only --security-opt label:disable


CSS looks good. You might want to consider assigning the font family to "body" instead of repeating it 5 times for your different elements. Also, if you're looking for an extra step to improve, resize your browser and see how the images break out of their divs. How could you fix that?


Done.


delete this extra tab


@hpi1 fyi I have not check the semantics, so maybe some types are to "big" now.


I think it would be better to use it on `person-tile__name` it might be less confusing?


Here too, please flatten.

```
if (reliably)
    r = ...;
else
   r = ...;
if (r < 0)
   return r;

r = ...;
if (r < 0)
   ...;
return r;
```


I would move this up since it is always the same


Es ist nicht mehr `2011` ;-) Muessen irgendwann mal die copyright Jahre updaten!


Opened #50. I was actually going to do this fairly soon, at least until I can continue post-processing work on the JSON data.


I answer in English just in case one of our foreign partners wants to join the discussion.

Of course your point could be debated. Should each cell be self-contained or should we expect users to go through a solution from top to bottom? I tend to favour the second approach because otherwise we create a lot of overhead and it does not require too much effort to step through a few cells (in most cases four cells or less). Therefore, so far all code in the cells is (or should be) written in such a way that it may rely on the execution of previous cells. Of course, we might change this policy if there is a good reason to do so but so far I do not see any.


Overall nice work! Come see me (or Joe or Greg) if you have questions about changing your indentation size or anything else.


-1 disable selling. It doesn't show up on sell menu.


Unfortunately, I think the Write method is dead code. As far as I can tell it is not called directly (except for tests) and io.Copy prefers calling ReadFrom over Write.

> On 12 Jan 2016, at 22:18, Stephen Day <notifications@github.com> wrote:
>
> Ah, I see. Let's throw a comment there, since that slicing is fairly important.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/aibaars/distribution/commit/5cac9c6a3973060c2b67e1e1f1e4fa79ea9e43fc#commitcomment-15409883>.
>


achso

2016-01-14 17:24 GMT+01:00 Christoph Junghans <notifications@github.com>:

> Es ist nicht mehr 2011 ;-) Muessen irgendwann mal die copyright Jahre
> updaten!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/votca/tools/commit/edc99701214895fa1a4625982e989e420a269e95#commitcomment-15454089>
> .
>


@hpi1 off_t is a mess with win32, both mingw and msvc. So it's just a try to get it upstream, so I don't have to maintain patches ;)


oops?


rename `full_result` to something like `full_state`, since it is actually the internal state, not the result


Hm yeah. I think it's because the default model is initialized with water. Forge doesn't use the same model for empty, so it never occurred there. Will probably have to be fixed in forge.


@hpi1 fyi


This is not a result, rename it to `second_half_state`. Same with `first_half_result` on line 109


Ack, done.


@djmdjm What exactly use_roaming should do?

I only could found:

    2009/06/27
        Add client option UseRoaming. It doesn't do anything yet but will
        control whether the client tries to use roaming if enabled on the
        server. From Martin Forssen.


Didn't removed, just set the flag later, and add an _oldBev var to set the previous behaviour after player close Clothing Menu.


Delete the `\` at the end of this line


Fix-allocation-for-feneSolarDelaySeq (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1502 of 1502 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.66%25-green.svg)


Thanks!


@khancyr thanks... I added this additional check and unit test continues to work. I already have more changes to send. I'll wait a little bit more to collect more feedback


Už to vidím přiřazené i tady. Jinak bacha je to nastavením `git config email` nebo tak nějak. Lze si to nastavit global i per-repository.


The formatting on this line looks off


I think this should be behind an `if settings.DD_MM_DATE_FORMAT_PREFERRED`, with another string for US sites.


Delete the commented lines


Instead of #ifndef, may be you can detect if m_testHooksInitialized after ChakraRTInterface::LoadChakraDll below?


thought it would be something like that, do i need to open an issue on the forge tracker for this?


Change the `-` to a `:`


@Arcanemagus Adding a promise here is the only way I could get the promises to work in the spec files. Does this look right to you?


Yes, I need to inherit `description` from `ARTBaseMessage` for both: `ARTMessage` and `ARTPresenceMessage`. I will improve it.


Yep, agree!


Why not just `return two_time_state_to_results(result)`?


I tested this manually on a cluster (as it's tricky to write a test). Without the patch I saw the error described in #1324, and then when I used the patch the command worked correctly:

```bash
./gatk-launch FlagStatSpark --input hdfs://bottou01.sjc.cloudera.com/user/tom/bam/CEUTrio.HiSeq.WGS.b37.ch20.1m-1m1k.NA12878.bam -- --sparkRunner LOCAL
```

@lbergelson perhaps you could you take a look?


Yes that is strange, do you have any extra luci packages installed beside
the admin-full and multi-user ?

On Thu, Jan 14, 2016 at 10:47 AM, Hannu Nyman <notifications@github.com>
wrote:

> My build is newer r48235, but there should be no siginificant difference
> in Openwrt, and of course Luci itself is the same.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Hostle/luci/commit/c1ba7d780fbafba1d882e3d05ff96baeaee131f3#commitcomment-15453005>
> .
>


`const`


I told you to update the `largestArea` and you said you were just going to store the `largestRect`. I expected you to finish the implementation. :laughing:


I wonder if we can add the hangup interceptor during some of the init / run of the main class. So when you disable it then you do not have to call the remote shutdown hook. It seems a bit stilly to add / remove the hook when you wanted to disable it.

I am not sure where the best spot for such piece is? So we may use a boolean flag to keep state if the hangup should be enable or not. Then the disable method is just setting that boolean to false. And then when the main init/run it checks the boolean and add the hangup if enabled.


+1 if


space missing


In Python 3 GzipFile has a text mode, which wraps a binary GzipFile into an io.TextIOWrapper instance. Python 2 adds a 'b' to the mode anyways.


@j6k4m8 I pass nothing at the moment because I want to use an internal ndio testing server (what we talked about a couple days ago).

@kunallillaney Definitely, I'll change it in next commit


nebylo by lepší dát něco jako

Můžete změnit maximálně XY objektů v jednom requestu. Nebo něco podobného


> do you have any extra luci packages installed beside
the admin-full and multi-user ?

…
Lots of them:
```
perus@ub1510:/Openwrt/github/luci$ grep luci /Openwrt/trunk/.config.init
CONFIG_PACKAGE_luci-ssl=y
CONFIG_PACKAGE_luci-mod-admin-full=y
CONFIG_PACKAGE_luci-app-commands=y
CONFIG_PACKAGE_luci-app-ddns=y
CONFIG_PACKAGE_luci-app-upnp=y
CONFIG_PACKAGE_luci-app-wol=y
CONFIG_PACKAGE_luci-app-statistics=y
CONFIG_PACKAGE_luci-app-sqm=y
CONFIG_PACKAGE_luci-proto-3g=y
CONFIG_PACKAGE_luci-proto-ppp=y
CONFIG_PACKAGE_luci-app-bcp38=y
CONFIG_PACKAGE_luci-theme-material=y
```


zde bys měl využít název který máš definovaný v is-core


Does minetest.get_node_or_nil work faster?


It looks from the docs as if you could do the same with the [`override` context manager](https://docs.djangoproject.com/en/1.8/ref/utils/#django.utils.translation.override), which makes it easier to  convince yourself that it'll definitely be deactivated, even if there's an exception thrown


I don't see the latest version on RubyGems.


Done


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1159](http://teamcity.monogame.net/viewLog.html?buildId=13581&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:11:57


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2074 of 2084 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.52%25-yellow.svg)


It seems that `MIMEText` has been in `email.mime.text` since Python 2.6, so we don't need to use `six.moves` in this case.


일단, 출력은 됬는데, 내부적으로 케이스 분류가 잘못된듯 합니다.
예를 들면
2+3은 2 3 +로 출력이 되는데,
2+3+4는 2 3 + 4 - 로 출력이 됩니다.
이론상으로는
2+3-4가
_2_+  3  -  4
  2___3  -  4  스택 : +
  2      3_-_4  스택 : +
  2      3___4 + 스택 : -
  2      3      4  +  -가 되야할 텐데 말이죠


Might that be the cause of https://github.com/tananaev/traccar/issues/1659 ?


co to nazvat bulk_put? tu metodu?


ugettext


místo [] použit () je to generátor ale * by ho měla otevřít


Fixed in : https://github.com/phpmyadmin/phpmyadmin/commit/0882bc7f6de903f942849e80b83308dda42767f8


Any reason the minSdkVersion has jumped from 4 to 15?


牛逼!


魅族前端之子


are you sure? The method is horribly named but here is the doc:

>    * Creates a matcher for {@link Iterable}s that matches when a single pass over the
>   * examined {@link Iterable} yields a series of items, each logically equal to the
>   * corresponding item in the specified items.  For a positive match, the examined iterable
>   * must be of the same length as the number of specified items.


그리고, 스택에 문제가 있는 것 같아서 다시짰습니다.
우분투에서 하다보니 클래스 내부가 잘 안보여서 /**/로 다 이어버렸는데, 나중에 다 뗄겁니다
근데 사실 정보은닉성을 고려하면 클래스 내부는 상관없지 않을까욬ㅋㅋㅋ

하지만 나중에 볼수도 있고, 여러가지 이유가 있으니 모두 원상복구 해놓겠습니다


i think you should check if we have any presets:

```
if (!m_vecPresets->Size() == 0)
{
  CGUIMessage msg(GUI_MSG_ITEM_SELECT, GetID(), CONTROL_LIST, m_currentPreset);
  OnMessage(msg);
}
```


This was a big mistake


is this really necessary? should be marked safe and always return dict that contains errors


Change as I told you the getGroups function and go go go!


Eh, workshops are boring.


You are right, i just read that if JavaScript is disabled then the element will be always visible instead of always invisible. Which makes sense :)


Hey @deborahleehamel & @GKhalsa, the way this method is written is perfectly fine. But if you wanted it to be shorter, you could write it like this:
```ruby
def kindergarten_participation_by_year(year = nil)
  year ? kindergarten_participation[year] : kindergarten_participation
end
```
Writing it that way is called a ternary operator. If you were to break down each part of the ternary and translate it into pseudo-code, it would be something like this:
- Check to see if there is a year: ```year ?```
- If there is a year (if true), then return something: ```kindergarten_participation[year]```
- If there is not a year (if false), then return something else: ```: kindergarten_participation```

Ternaries can look confusing at first and sometimes they make conditionals harder to read. But, with practice, they can make simple conditionals clear and concise. It may not make sense for you to use a ternary here; it is really a matter of preference. I just wanted to make sure you knew about it.


for example this fails

```java
  @Test
  public void testMatcher() {
    assertThat(Arrays.asList(1, 2,3), contains(1));
  }
```
with:
> Expected: iterable containing [<1>]
>     but: Not matched: <2>


you should rewrite get_fieldsets too


Блин, что-то синтаксические ошибки полезли... Старею :)


I corrected this in meantime to `.flush`. I think that's what you meant?


Ok, one of those packages must have a link to the system menus somewhere, I
was able to replicate the reboot issue, I am working on it now. As for the
system Menu issue, that s exploits the weakness of this approach as all of
this packages would need the modified index() function and the
/model/cbi/admin_users/users.lua module when need to have all available
package options avaialable and enabled/disabled by some short of switch (
the later is no problem) the first issue requires alot of work

On Thu, Jan 14, 2016 at 11:31 AM, Hannu Nyman <notifications@github.com>
wrote:

> do you have any extra luci packages installed beside
> the admin-full and multi-user ?
>
> …
> Lots of them:
>
> perus@ub1510:/Openwrt/github/luci$ grep luci /Openwrt/trunk/.config.init
> CONFIG_PACKAGE_luci-ssl=y
> CONFIG_PACKAGE_luci-mod-admin-full=y
> CONFIG_PACKAGE_luci-app-commands=y
> CONFIG_PACKAGE_luci-app-ddns=y
> CONFIG_PACKAGE_luci-app-upnp=y
> CONFIG_PACKAGE_luci-app-wol=y
> CONFIG_PACKAGE_luci-app-statistics=y
> CONFIG_PACKAGE_luci-app-sqm=y
> CONFIG_PACKAGE_luci-proto-3g=y
> CONFIG_PACKAGE_luci-proto-ppp=y
> CONFIG_PACKAGE_luci-app-bcp38=y
> CONFIG_PACKAGE_luci-theme-material=y
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Hostle/luci/commit/c1ba7d780fbafba1d882e3d05ff96baeaee131f3#commitcomment-15454289>
> .
>


Indent


and so does this

```java
  @Test
  public void testMatcher() {
    assertThat(Arrays.asList(1, 2, 3), contains(3, 2, 1));
  }
```

> java.lang.AssertionError:
> Expected: iterable containing [<3>, <2>, <1>]
>    but: item 0: was <1>


This key name is already used by create-deployer. It could be that bump in that semver resource would trigger this one..... Call it st. like `trigger-tf-destroy` - both name and the S3 bucket key name.


@bbatsov Correct. I am waiting for tests to pass. https://travis-ci.org/whitequark/parser/builds


and get_readonly...


@ppold should we propose this upstream to https://github.com/gimite/google-drive-ruby ?


I think this should be squashed into the first commit - it'd be nice to still include this commit's helpful message in the squashed commit's message, of course.


throwing MailboxCreationException now


Nice solution :D


I like this hack, but IMO the cleanest solution would be just update the images. But I know it is basically a designer work, and we don't have access to one atm so after testing that in different browser it's ok I guess. I think more than these 2 caricatures need some love, but I know Graeme was up to fixing only those two.


:heart: the shell-fu


I think this is checking the same thing as the above...

(Also, what if label is something like "hasOwnProperty" or other names from the prototype? Wouldn't `fullEvolutionMap[label]` be truthy in that case?)


Thank you :smile_cat:


Also include pm2 as daemon (instead of nodemon / forever), and as a tool for further deployments and app monitoring.


why?


Oops, this is not correct. My bad!


The problem is those caricatures are just abnormally wide, so when they are the same dimensions as the others the heads look smaller. We would need 2 exception caricatures for them on the people page, or chop their bodies off in all the pictures.


Class HeartbeatRecovered is missing a docblock.


// FIXME: Throw a HeartbeatMissing event?