next level's threshold


`the current level's threshold`


Got cha. What can I do with this information now? Hmm, let me think ...


Of course!


Nice! :+1:


I'd be more clear here, because "semantic changes" are a bit fuzzy:

ActionDispatch weakens ETags to allow conditional GET to work when downstream servers change the content encoding, for example by adding compression. This is documented in RFC 7232 §2.1.


Return value must be *nullable*.


Hi!


Thanks for this. Good spot. I'm surprised has gone unnoticed, oops... Can you share some info on your setup - eg. what front-end server are you using?

I was going to ask if you could put braces around the single line `if`s to be consistent with the rest of the code but apparently I didn't use to put braces everywhere. Ah, naive times. :)


Is this really useful; the case where it would be relevant is if multithreading was involved. And in this case, this call would most likely be locked.


Nit: Space after '//'.


Type of `relationshipType` argument changed to `RelationshipType?` (*nullable*) - see https://github.com/luboshl/trackable-entities/commit/99ac84896ca29c029a2c9a6ec8734847e34f125f#commitcomment-15601938


ShareX is a free and open source program that lets you capture or record any area of your screen and share it with a single press of a key. It also allows uploading images, text or other types of files to over 50 supported destinations you can choose from. https://github.com/ShareX/ShareX


@joedean wondering if we shouldn't just set the username/password only in production, so it'll use your local user when you're on development.  Less configuration for the win...


I can alphabet!


Do not require `this.` for any member.


The `interceptors` argument is before `state` argument, becouse is mandatory and it is better then add other `null` when calling this method.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12339](https://teamcity.mesosphere.io/viewLog.html?buildId=110327&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:33


Yes, it should be troy ounces (symbol = ozt)


Sorry, misread your comment. Anyway, this is fixed in https://github.com/18F/fec-style/pull/226.


1st) I'd get rid of the python-h5py package. I assume it's not parallel
enabled and we require it to be. That's why we build our own h5py in the
configure stage.

On 22 January 2016 at 11:08, OKaluza <notifications@github.com> wrote:

> H5py will not configure for me either (Ubuntu 15.10)
> I've installed python-h5py but it doesn't find it so builds its own copy,
> but then that fails too with ImportError (when I add a line to print the
> exception: "cannot import name _errors")
>
> On 19 January 2016 at 15:04, RebeccaFarrington <notifications@github.com>
> wrote:
>
> > no worries :)
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/underworldcode/underworld2/commit/2aa51432318a306b05a8a7d9a409ef69ea49508e#commitcomment-15521265
> >
> > .
> >
>
>
>
> --
> *OWEN KALUZA*
> Senior Visualisation Specialist
>
>
> *Immersive Visualisation Platform (eResearch)*
> Monash University
> Room 337-25, 20 Research Way, Clayton Campus
>
> T: +61 3 9902 9809
> M: +61 410 545 824
> E: owen.kaluza@monash.edu
> monash.edu/mivp
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/underworldcode/underworld2/commit/2aa51432318a306b05a8a7d9a409ef69ea49508e#commitcomment-15601410>
> .
>


C'est parce qu'il implemente pas un truc.

Dis sur la Master est ce que tu as les ombres sur Naruto ultimate ninja storm 2?  Je les ai perdu et je sais pas quand/comment.


@djmitche Thanks :) Issues are disabled here and I couldn't comment just on the file, so switched to `blame` view and found the needed line :)


The JSON object here that's being passed into ``deletePrerequisiteSkill`` should be in its own local variable to keep the function call clean. I don't think it's matching syntax but I'm also not sure how to clean it up, so my suggestion is to move it to its own variable.


Please capitalize ``exploration``.


Agregamos la `gem devise` en el archivo Gemfile
Agregamos la gema al proyecto con el comando: `bundle install`
Instalamos la gema con el comando `rails g devise:install`


LGTM! It looks like that constructor should have always done what you're doing here.


@scottjones I have a plan for a super easy setup that will guide through this.

Effectively, anything you run will fail telling you to run `rake setup` and then `rvm reload`.

Once you do that, it will create a `.ruby-evn` file which specifies all your answers to the needed environment variables.

This way, you will have a local file to store that, it can be different from production... but no usernames/passwords in the repo


Victara does not support multicolor lights or pulsing. Simple on off toggle for a green light is all she gets


Ditto for this function call (move parameter to variable).


This just updated the project.json file and ran `>dnu restore`


The file is named as the brokerage/market, so yes, we could add all security types supported by that brokerage. In this case, for Oanda and FXCM we could only add Forex symbols.


@paulinus I've been working on a viewer based on this code and have gotten hung up on the scene orientation. Changing the `camera.up` vector seems to have no effect. When I comment out this line in your viewer, the scene is sideways. In my scene however, this has no effect one way or anther. Do you have any tips for what I might be missing?


Thanks!


ping me when done


also this means that any thing that extended Link before loses those attributes as now we are only serializing this new internal class HalLink.  Since link wasn't marked final...ug...


Ok, now i'm getting
Checking for package H5py... No module named usr
/home/owen/underworld2/h5py/defs.so: undefined symbol: H5Pset_dxpl_mpio

On 22 January 2016 at 11:52, julesghub <notifications@github.com> wrote:

> 1st) I'd get rid of the python-h5py package. I assume it's not parallel
> enabled and we require it to be. That's why we build our own h5py in the
> configure stage.
>
>
> On 22 January 2016 at 11:08, OKaluza <notifications@github.com> wrote:
>
> > H5py will not configure for me either (Ubuntu 15.10)
> > I've installed python-h5py but it doesn't find it so builds its own copy,
> > but then that fails too with ImportError (when I add a line to print the
> > exception: "cannot import name _errors")
> >
> > On 19 January 2016 at 15:04, RebeccaFarrington <notifications@github.com
> >
> > wrote:
> >
> > > no worries :)
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/underworldcode/underworld2/commit/2aa51432318a306b05a8a7d9a409ef69ea49508e#commitcomment-15521265
> > >
> > > .
> > >
> >
> >
> >
> > --
> > *OWEN KALUZA*
> > Senior Visualisation Specialist
> >
> >
> > *Immersive Visualisation Platform (eResearch)*
> > Monash University
> > Room 337-25, 20 Research Way, Clayton Campus
> >
> > T: +61 3 9902 9809
> > M: +61 410 545 824
> > E: owen.kaluza@monash.edu
> > monash.edu/mivp
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/underworldcode/underworld2/commit/2aa51432318a306b05a8a7d9a409ef69ea49508e#commitcomment-15601410
> >
> > .
>
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/underworldcode/underworld2/commit/2aa51432318a306b05a8a7d9a409ef69ea49508e#commitcomment-15601997>
> .
>

--
*OWEN KALUZA*
Senior Visualisation Specialist

*Immersive Visualisation Platform (eResearch)*
Monash University
Room 337-25, 20 Research Way, Clayton Campus

T: +61 3 9902 9809
M: +61 410 545 824
E: owen.kaluza@monash.edu
monash.edu/mivp


Correct. This is useless per se but it is a convention issue: no pointer is allowed unless it points to something or is null.

In more complex code, this convention helps. Easier to enforce a convention obsessively than selectively.

But, yes, here it serves no practical purpose.


Method `IsRelatedProperty` can now be refactored to:

```C#
private static bool IsRelatedProperty(this DbContext dbContext,
    Type entityType, string propertyName, RelationshipType relationshipType)
{
    return relationshipType == GetRelationshipType(dbContext, entityType, propertyName);
}
```


Oh neat :D I'll check it out after college. It's 1AM, here 0~0


Whoops!


import not required


Should read "StaticMarkerBinder"


Should read "@return IMarkerFactory"


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12342](https://teamcity.mesosphere.io/viewLog.html?buildId=110333&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:08


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12341](https://teamcity.mesosphere.io/viewLog.html?buildId=110331&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:15


Yes, this looks like it should bring the behavior back to how it was. There was an old bug (I feel it was a bug), which continues to stay.

Even though PATH is overridden, it doesn't apply to the currently spawning process. Meaning, if you override PATH to `/abc` and `/abc/def.sh` exists, you will still not be able to use it as `def.sh`, because, if you see, the overridden PATH is not set back on to the `processBuilder.environment()` in `createProcess`. But, that's not something you introduced, so this is fine, according to me.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12340](https://teamcity.mesosphere.io/viewLog.html?buildId=110330&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:05:43


regarde ma video de generation, les 2 jeux on le meme moteur ^^ et les meme bug donc


FastCGI running behind servers like Apache mod_fcgid won't work in the default configuration with this change. At least they didn't used to.

This works on most versions of Boost AFAIK. Again, I'm curious what your setup is where you are seeing this issue.


It look like you want to go a stable way.
I `d like to explore, I can learn more.
But as you said, don`t add things if one part of it is broken.
I am prepared to modify each part carefully, modify the next part until its stable.


Thank you Przemek, this is great!
I've cleared a few more in `hbssl`. Left just two that may be problematic — not sure if this matches what you had in mind though.
https://github.com/vszakats/harbour-core/commit/a344cf928f0ce71f51c99fb9d297d8245321c409


Yup, thanks again. This cleans up some old garbage sloppiness. :)


@marcosdf Can you provide an example that need this hooks ?
A module can already disable and add its own tab. Translation can also be replaced.
And you can also inject js.
Not enough ? Example of the need ?


LGTM.


Great! Thank you for your work on this @ceki, it seems to fix SLF4J-347.

I have made two corrections to the javadoc and highlighted two unnecessary imports:
https://github.com/qos-ch/slf4j/commit/ea3cca72cd5a9329a06b788317a17e806ee8acd0#commitcomment-15602106

> Please note that the SINGLETON field is public which caters for the case of an slf4j-binding version 1.7.14 or later is used with an older version of slf4j-api.
>
> Obviously, slf4j-timbre will require slf4j-api 1.7.14 or later.

Yes, makes sense

> May I have your name? It's for the news page detailing changes in 1.7.14.

Sure - Rufus Alexander


@ddomit, plane+quadcoppter.  wiki is here if you're interested: http://plane.ardupilot.com/wiki/quadplane-support/


Can you make a separate PR for this change and I'll merge the rest?


PlantCompBaseClassAgain (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (2056 of 2056 tests passed, 329 test warnings)

 * 334 tests had: AUD diffs.
 * 329 tests had: BND diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I understand what you are saying marcel. I'll readjust. It is useless because the server can't even properly convert utf-8 to unicode for device names at the moment. I have no choice but to convert to ascii otherwise, it displays giberish in the emby dashboard. So essentially, I'll have to decode for no reason atm. I'll then need to encode to utf-8 to then encode to ascii. Anyway.


Check out the jsdoc format for commenting which will allow you to automatically produce your docs based on your function comments. It's pretty cool!


As an example of functional code, you could put this whole for-loop into a separate function (I think, but maybe I'm wrong). If you copy `path_d` at the start of the function, then return the copy, it could be called like:

    path_d = updated_paths(path_d, chain, n0, nlast)

Then you could write a function for just that part.

Yes, the functions which take `G` and modify it *could* be class methods. I would do that only if no other arguments are modified. But really, by passing G everywhere consistently, you already have an object-oriented style. The consistency is good, so it's fine as it is.

I would consider moving "pure" functions into a separate module to make that clear. It helps the reader tremendously.


LGTM


https://youtu.be/fNNzzv6VDyg?t=4m36s ya des gros probleme de reflet, plus d'autre mais les ombre on les vois, mais pas trop


That's just an example. I'm not sure whether it makes sense for that *particular* for-loop. You'll have to decide that case-by-case.


Первая версия


Make sure you update the comment so that it still matches the code (or remove the first line of the comment and just have it state that there is scaling)


Anytime you have an each or forEach loop thats sole purpose is to push onto an array, think about changing it to a map. It'll make it cleaner and easier to read.


We need this even when show-labels flag*


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1213](http://teamcity.monogame.net/viewLog.html?buildId=13857&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Mac) Build time: 00:00:05


s/const //. (const is not necessary here, especially since |data| isn't a pointer).

Perhaps also it is better to rename |data| to |x| since |data| kind of implies a buffer of bytes whereas |x| implies a single value.


when running programs that use plugins


`if (reqErr) return callback(err);`
If you handle the err here, then you avoid doing exra work later and it makes the code a little easier to read in my opinion. Then at the end of the function you can just call `callback(null, gif_urls);`


This method is a good example of purely functional code. But note that you don't really need `path_d`. The caller could say:

    make_in_same_path(path_d.itervalues())


Testing now.


thank you very much for these changes.  i have tested the issue i encountered in #59 with 3.1a0 above, and confirm that it no longer occurs on the Raspberry Pi.


I was literally just investigating if this was always safe or not.


Se agrega el modelo devise con el comando `rails g devise User`
Donde User es el nombre asignado al modelo en singular que se utilizara para los usuarios


did you rm /home/owen/underworld2/h5py first. Perhaps the previous h5py
build attempt left something bad there.

Do you have a parallel version of hdf5? Mansour's adding a check for that
now in our configure.

Ensure libhdf5.so & mpi4py's MPI.so
(ie, /usr/local/lib/python2.7/dist-packages/mpi4py/MPI.so) all use the same
mpi libraries. Use ldd for this.
All the compile issues I experienced were because one of - hdf5, mpi4py or
h5py - was linked with a different version on mpi to the others.

On 22 January 2016 at 11:57, OKaluza <notifications@github.com> wrote:

> Ok, now i'm getting
> Checking for package H5py... No module named usr
> /home/owen/underworld2/h5py/defs.so: undefined symbol: H5Pset_dxpl_mpio
>
>
> On 22 January 2016 at 11:52, julesghub <notifications@github.com> wrote:
>
> > 1st) I'd get rid of the python-h5py package. I assume it's not parallel
> > enabled and we require it to be. That's why we build our own h5py in the
> > configure stage.
> >
> >
> > On 22 January 2016 at 11:08, OKaluza <notifications@github.com> wrote:
> >
> > > H5py will not configure for me either (Ubuntu 15.10)
> > > I've installed python-h5py but it doesn't find it so builds its own
> copy,
> > > but then that fails too with ImportError (when I add a line to print
> the
> > > exception: "cannot import name _errors")
> > >
> > > On 19 January 2016 at 15:04, RebeccaFarrington <
> notifications@github.com
> > >
> > > wrote:
> > >
> > > > no worries :)
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub
> > > > <
> > >
> >
> https://github.com/underworldcode/underworld2/commit/2aa51432318a306b05a8a7d9a409ef69ea49508e#commitcomment-15521265
> > > >
> > > > .
> > > >
> > >
> > >
> > >
> > > --
> > > *OWEN KALUZA*
> > > Senior Visualisation Specialist
> > >
> > >
> > > *Immersive Visualisation Platform (eResearch)*
> > > Monash University
> > > Room 337-25, 20 Research Way, Clayton Campus
> > >
> > > T: +61 3 9902 9809
> > > M: +61 410 545 824
> > > E: owen.kaluza@monash.edu
> > > monash.edu/mivp
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/underworldcode/underworld2/commit/2aa51432318a306b05a8a7d9a409ef69ea49508e#commitcomment-15601410
> > >
> > > .
> >
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/underworldcode/underworld2/commit/2aa51432318a306b05a8a7d9a409ef69ea49508e#commitcomment-15601997
> >
>
> > .
> >
>
>
>
> --
> *OWEN KALUZA*
> Senior Visualisation Specialist
>
>
> *Immersive Visualisation Platform (eResearch)*
> Monash University
> Room 337-25, 20 Research Way, Clayton Campus
>
> T: +61 3 9902 9809
> M: +61 410 545 824
> E: owen.kaluza@monash.edu
> monash.edu/mivp
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/underworldcode/underworld2/commit/2aa51432318a306b05a8a7d9a409ef69ea49508e#commitcomment-15602057>
> .
>


@ooHmartY
The first scenario has been written for you. Over the next 60 minutes please implement as many of the remaining scenarios as you can within `events.js` (event dispatcher can be used both server-side and client-side). We're looking for simplicity in architecture and the correctness of the code. Make whatever changes you want to the scenario implementations and source code to accomplish that goal. Do not worry if you cannot finish all of them. Find a good stopping point and send us what you have. We are excited to see it! Zip up the entire directory and email it back to us.


This is going to be a fun class.


Ideally you want to let your testing suite know that the test is over only once all async calls are complete. If you need to do a bunch of async calls in a test then you'll need to use something like the async library to control the flow. I think tape allows you to pass in a callback function that you call once your tests are done so that it knows it can move onto the next test.


Makes sense.


I agree that 0 is correct.


#define Nevent 20


Should this be:
```
// +build linux freebsd
```
?


`setUpClass` raises `SkipTest`, which causes all of the tests in this class to be skipped, if `settings.S3_BLOB_DB_SETTINGS` is not present.


add .idea to .gitignore


Curses! My evil plan has been foiled!

Seriously though, this has gone far enough. I don't know if you're the guy from Piazza, but if you are, let's both agree to bury the dagger here, OK?


Completely fixed thank you for all your hard work :3


Se realizan cambios al modelo y se ejecuta el comando `rake db:migrate`


You might write some tests to check other edge cases. Does your function work if you forget to pass in a length, what happens if it can't find any gifs for the string, maybe make sure that the array is actually full of string URLs rather than just checking the length of the array, etc...


@dontcallmedom How come you changed "MUST be rejected" to "will be rejected" here? The spec should speak to the implementer, not the API user, so the former seems more correct.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12346](https://teamcity.mesosphere.io/viewLog.html?buildId=110338&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:03:58


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12344](https://teamcity.mesosphere.io/viewLog.html?buildId=110336&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:04:08


Yeah I was/am wondering about that too. Thanks. Both are excellent comments.


Yup, std::string::size() does not include the terminating character.


I'm a different guy from piazza, but I'm enjoying the drawings.


Lots of work! I hope I will be able to test this soon! (it is still missing modules when I try to start it)


Thanks, got it working! I had both libhdf5-dev and libhdf5-mpi-dev installed, so removed libhdf5-dev and it seems to solve the problem.


OK


a new page


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12345](https://teamcity.mesosphere.io/viewLog.html?buildId=110337&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:06:43


indeed :smile:


no need to pollute the list of registered callbacks in the admin... maybe we should be doing this globally?

is_admin() || add_action('send_headers', function(){
    header('X-UA-Compatible: IE=edge,chrome=1');
}, 1);

is_admin() || add_action( 'send_headers', 'bsg_add_header_xua' , 1);
function bsg_add_header_xua() {
    header( 'X-UA-Compatible: IE=edge,chrome=1' );
}


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12343](https://teamcity.mesosphere.io/viewLog.html?buildId=110334&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:10:20


make 8 a const.


I think you can close over the args with a new func and put that on the channel.


You can close over the args and create a new func, no need for struct.


...and that causes an ERROR :facepunch:, not SKIP with the django test runner. Works fine with :nose:


ReplicaSet and Deployment should just be enabled. No conditional at this point.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1214](http://teamcity.monogame.net/viewLog.html?buildId=13861&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Mac) Build time: 00:00:00


Done


I think it's possible for the call to `worker()` to *not* return an `err`, and return `shouldRetry=true`, but then `shouldContinue` could evaluate to `false`, which would cause the `RetryLoop(..)` to return a `nil` value for the `err` return val, which is a bit misleading.

What about:

```
	if !shouldContinue {
		if err == nil {
			err = fmt.Errorf("RetryLoop for %v giving up after %v attempts", description, numAttempts)
		}
		Warn("RetryLoop for %v giving up after %v attempts", description, numAttempts)
		return err, value
	}
```

to cover the case described above?


develop (macumber) - Win64-Windows-7-VisualStudio-12: OK (2353 of 2389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.49%25-yellow.svg)


Sorry for my slow response and thanks for the contribution. I need to maintain backward compatibility, believe it or not I have one user who's system is on 2.6.something. I'm still new to working with github, so I'm just going to change these patches and credit you I guess. Thanks again!


Thanks for reducing the test case. Should be an easy fix.


Again, close over to capture the args, no need for ancillary structure.


There should be a step introducing the list:
`<p>Run the following steps:</p>`


at some point (not necessarily this PR), I think this should be changed to:

```
if db.user != RootUser {
```

I think this would be clearer ..


Hint


width, height, x and y could optimize: It can be calculated at onCreate() method.


nit: There should be a comma after "reason."
I think we can improve this by adding "for each..." to the end of the sentence. Thus, "...reason, run... on each..."


Yeah, definitely. I'll fix that.


Good call, @miguelportilla.  The OpenSSL documentation (https://www.openssl.org/docs/manmaster/crypto/BN_add.html) says the remainder will have the same sign as the dividend.  So the API of this function is dead wrong.  I'll change the API to return the remainder as a parameter and the `BN_div()` result as the return value (like the other three functions).


Garoto revoltado


@cklosowski cat walked across the keyboard here. :cat2:


YingmiEventHandler

统一名词 message -> event
它自己已经是interface，犯不着再在名字里写一次


OK


用类吧，FundInfoUpdateEvent这种，定义一组我也用


Done


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1215](http://teamcity.monogame.net/viewLog.html?buildId=13865&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


不是ac了


is there a reason why plugins are added here instead of declared in the base config along with the loader in https://github.com/kriasoft/react-starter-kit/blob/master/tools/webpack.config.js#L75? @koistya


Thread请封装到YingmiService里面


fixes #146


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12348](https://teamcity.mesosphere.io/viewLog.html?buildId=110352&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:11:42


I also tried to call `push_new_attribute` directly, but it still called a panic.


明明是一个Object，为啥叫objects


thread 'ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }' panicked at 'DOMRefCell<T> already borrowed', ../src/libcore/option.rs:298
stack backtrace:
   1:     0x7fce16ff5ad0 - sys::backtrace::tracing::imp::write::hd273f86d5325347aweu
   2:     0x7fce16ff89f5 - panicking::default_handler::_<closure>::closure.42335
   3:     0x7fce16ff849f - panicking::default_handler::h907ce0af740f5f06spy
   4:     0x7fce16fe14e6 - sys_common::unwind::begin_unwind_inner::ha417239bcab1f2ff56s
   5:     0x7fce16fe1c48 - sys_common::unwind::begin_unwind_fmt::hac4637ed0b5bb49eb6s
   6:     0x7fce16ff5131 - rust_begin_unwind
   7:     0x7fce1702c0df - panicking::panic_fmt::he5f9c513e9167673LnK
   8:     0x7fce15866fbb - option::Option<T>::expect::h4248389772591209977
                        at ../src/libcore/macros.rs:29
   9:     0x7fce15866dd5 - dom::bindings::cell::DOMRefCell<T>::borrow_mut::h4539319508708057868
                        at /home/divad/Rust/servo/components/script/dom/bindings/cell.rs:150
  10:     0x7fce1575ec4a - dom::element::Element::update_inline_style::hc1220ba376b10bc84qH
                        at /home/divad/Rust/servo/components/script/dom/element.rs:695
  11:     0x7fce152e81e4 - dom::cssstyledeclaration::CSSStyleDeclaration.CSSStyleDeclarationMethods::SetProperty::hff6b602ba6dba965eWz
                        at /home/divad/Rust/servo/components/script/dom/cssstyledeclaration.rs:257
  12:     0x7fce152e8c1f - dom::cssstyledeclaration::CSSStyleDeclaration.CSSStyleDeclarationMethods::SetPropertyValue::h0942244815b52181q0z
                        at /home/divad/Rust/servo/components/script/dom/cssstyledeclaration.rs:303
  13:     0x7fce152eb55f - dom::cssstyledeclaration::CSSStyleDeclaration.CSSStyleDeclarationMethods::SetBackgroundColor::hbdf1ef945c886739GYA
                        at /home/divad/Rust/servo/components/script/dom/cssstyledeclaration.rs:46
  14:     0x7fce152eb261 - dom::bindings::codegen::Bindings::CSSStyleDeclarationBinding::set_backgroundColor::__rust_abi
                        at /home/divad/Rust/servo/target/debug/build/script-e566a6469c040583/out/Bindings/CSSStyleDeclarationBinding.rs:609
  15:     0x7fce152eb0e0 - dom::bindings::codegen::Bindings::CSSStyleDeclarationBinding::set_backgroundColor::h6427aa8d1db0f64c4ej
  16:     0x7fce165f7187 - CallJitSetterOp
  17:     0x7fce152d46e1 - dom::bindings::utils::call_setter::__rust_abi
                        at /home/divad/Rust/servo/components/script/dom/bindings/utils.rs:539
  18:     0x7fce152d4634 - dom::bindings::utils::call_setter::h0ffa15d6851f39353eg
  19:     0x7fce152d3611 - dom::bindings::utils::generic_call::hd1da9a8e4bd015b6nag
                        at /home/divad/Rust/servo/components/script/dom/bindings/utils.rs:505
  20:     0x7fce152d47c7 - dom::bindings::utils::generic_setter::__rust_abi
                        at /home/divad/Rust/servo/components/script/dom/bindings/utils.rs:551
  21:     0x7fce152d4782 - dom::bindings::utils::generic_setter::he0f6cc60c36102ccPfg
  22:     0x7fce16712e4c - _ZN2js6InvokeEP9JSContextN2JS8CallArgsENS_14MaybeConstructE
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/jscntxtinlines.h:235
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:502
  23:     0x7fce1671433e - _ZN2js6InvokeEP9JSContextRKN2JS5ValueES5_jPS4_NS2_13MutableHandleIS3_EE
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:558
  24:     0x7fce16717a59 - _ZN2js20InvokeGetterOrSetterEP9JSContextP8JSObjectN2JS5ValueEjPS5_NS4_13MutableHandleIS5_EE
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:628
  25:     0x7fce1675e1cc - _ZN2js17NativeSetPropertyEP9JSContextN2JS6HandleIPNS_12NativeObjectEEENS3_IP8JSObjectEENS3_I4jsidEENS_13QualifiedBoolENS2_13MutableHandleINS2_5ValueEEERNS2_14ObjectOpResultE
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Shape-inl.h:51
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/NativeObject.cpp:2194
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/NativeObject.cpp:2230
  26:     0x7fce16a9ba9f - _ZN2js30SetPropertyIgnoringNamedGetterEP9JSContextN2JS6HandleIP8JSObjectEENS3_I4jsidEENS2_13MutableHandleINS2_5ValueEEES6_NS9_I20JSPropertyDescriptorEERNS2_14ObjectOpResultE
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/NativeObject.h:1451
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/proxy/BaseProxyHandler.cpp:108
  27:     0x7fce16a9bb8a - _ZNK2js16BaseProxyHandler3setEP9JSContextN2JS6HandleIP8JSObjectEES7_NS4_I4jsidEENS3_13MutableHandleINS3_5ValueEEERNS3_14ObjectOpResultE
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/proxy/BaseProxyHandler.cpp:91
  28:     0x7fce165f8e82 - _ZNK22ForwardingProxyHandler3setEP9JSContextN2JS6HandleIP8JSObjectEES6_NS3_I4jsidEENS2_13MutableHandleINS2_5ValueEEERNS2_14ObjectOpResultE
  29:     0x7fce16ab51a0 - _ZN2js5Proxy3setEP9JSContextN2JS6HandleIP8JSObjectEES7_NS4_I4jsidEENS3_13MutableHandleINS3_5ValueEEERNS3_14ObjectOpResultE
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/proxy/Proxy.cpp:326
  30:     0x7fce166d8442 - _ZL17SetObjectPropertyP9JSContext4JSOpN2JS6HandleINS2_5ValueEEENS3_I4jsidEENS2_13MutableHandleIS4_EE
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:330
  31:     0x7fce167074f2 - _ZL9InterpretP9JSContextRN2js8RunStateE
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:361
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:2492
  32:     0x7fce16712b2c - _ZN2js9RunScriptEP9JSContextRNS_8RunStateE
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:452
  33:     0x7fce16718bff - _ZN2js13ExecuteKernelEP9JSContextN2JS6HandleIP8JSScriptEER8JSObjectRKNS2_5ValueENS_11ExecuteTypeENS_16AbstractFramePtrEPS9_
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:660
  34:     0x7fce1671a90c - _ZN2js7ExecuteEP9JSContextN2JS6HandleIP8JSScriptEER8JSObjectPNS2_5ValueE
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/vm/Interpreter.cpp:703
  35:     0x7fce169dc2d7 - _ZL8EvaluateP9JSContextN2JS6HandleIP8JSObjectEERKNS1_22ReadOnlyCompileOptionsERNS1_18SourceBufferHolderENS1_13MutableHandleINS1_5ValueEEE
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/jsapi.cpp:4184
  36:     0x7fce169dc5bf - _ZN2JS8EvaluateEP9JSContextRKNS_22ReadOnlyCompileOptionsEPKDsmNS_13MutableHandleINS_5ValueEEE
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/jsapi.cpp:4218
                        at /home/divad/Rust/servo/.cargo/git/checkouts/mozjs-06d7f04b6dbb8a8e/master/mozjs/js/src/jsapi.cpp:4272
  37:     0x7fce152b992b - dom::window::_&'a T.ScriptHelpers::evaluate_script_on_global_with_result::h15369056617150762074
                        at /home/divad/Rust/servo/components/script/dom/window.rs:816
  38:     0x7fce157fde2d - dom::htmlscriptelement::HTMLScriptElement::execute::hd820d00a090ebc54u4T
                        at /home/divad/Rust/servo/components/script/dom/htmlscriptelement.rs:417
  39:     0x7fce159422a7 - dom::htmlscriptelement::HTMLScriptElement::prepare::hdf4a27ee8b6ffe51YTT
                        at /home/divad/Rust/servo/components/script/dom/htmlscriptelement.rs:344
  40:     0x7fce159cd1bf - parse::html::servohtmlparser..Sink.TreeSink::complete_script::he40fdf910a4859cc8Ce
                        at /home/divad/Rust/servo/components/script/parse/html.rs:156
  41:     0x7fce159b37cc - tree_builder::rules::super..TreeBuilder<Handle, Sink>.TreeBuilderStep::step::h11281135998388019670
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tree_builder/rules.expanded.rs:1461
  42:     0x7fce1599a039 - tree_builder::TreeBuilder<Handle, Sink>::process_to_completion::h6465385879961674149
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tree_builder/mod.rs:327
  43:     0x7fce1599580e - tree_builder::TreeBuilder<Handle, Sink>.TokenSink::process_token::h14073795346578288465
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tree_builder/mod.rs:425
  44:     0x7fce15994a91 - tokenizer::Tokenizer<Sink>::process_token::h1142806760397791138
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tokenizer/mod.rs:233
  45:     0x7fce159de007 - tokenizer::Tokenizer<Sink>::emit_current_tag::h12032453629681101526
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tokenizer/mod.rs:392
  46:     0x7fce159d621a - tokenizer::Tokenizer<Sink>::step::h17000905979645303138
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tokenizer/mod.rs:795
  47:     0x7fce159d35fb - tokenizer::Tokenizer<Sink>::run::h9347854623409678734
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tokenizer/mod.rs:334
  48:     0x7fce159f3ed2 - tokenizer::Tokenizer<Sink>::feed::h11122150034214555435
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tokenizer/mod.rs:221
  49:     0x7fce1598b858 - dom::servohtmlparser::ServoHTMLParser::parse_sync::h9e1bf7a0c9447631w72
                        at /home/divad/Rust/servo/components/script/dom/servohtmlparser.rs:470
  50:     0x7fce1598af92 - dom::servohtmlparser::_&'a ServoHTMLParser.Parser::parse_chunk::h24a49f06855bcb41Y02
                        at /home/divad/Rust/servo/components/script/dom/servohtmlparser.rs:355
  51:     0x7fce1598ad73 - dom::servohtmlparser::ParserRef<'a>::parse_chunk::hdb1c7549f7a040c8sM2
                        at /home/divad/Rust/servo/components/script/dom/servohtmlparser.rs:141
  52:     0x7fce1598f053 - dom::servohtmlparser::ParserContext.AsyncResponseListener::data_available::h100afa4737423bafNU2
                        at /home/divad/Rust/servo/components/script/dom/servohtmlparser.rs:306
  53:     0x7fce15eb8021 - ResponseAction::process::hc5e234e7d4322f71jMd
                        at /home/divad/Rust/servo/components/net_traits/lib.rs:136
  54:     0x7fce15b9e835 - network_listener::ListenerRunnable<T>.Runnable::handler::h13439789093495147791
                        at /home/divad/Rust/servo/components/script/network_listener.rs:48
  55:     0x7fce15b02685 - script_thread::ScriptThread::handle_msg_from_script::hefd7cdb2573bf9e3bjg
                        at /home/divad/Rust/servo/components/script/script_thread.rs:1149
  56:     0x7fce15b7db62 - script_thread::ScriptThread::handle_msgs::_<closure>::closure.171647
                        at /home/divad/Rust/servo/components/script/script_thread.rs:1001
  57:     0x7fce15b7d782 - script_thread::ScriptThread::profile_event::h15525301070989550331
                        at /home/divad/Rust/servo/components/script/script_thread.rs:1083
  58:     0x7fce15b512cb - script_thread::ScriptThread::handle_msgs::h8d3c2378aac8698e44f
                        at /home/divad/Rust/servo/components/script/script_thread.rs:993
  59:     0x7fce15afed90 - script_thread::ScriptThread::start::he5c522eecb9402a4U4f
                        at /home/divad/Rust/servo/components/script/script_thread.rs:851
  60:     0x7fce15afed44 - script_thread::ScriptThread.ScriptThreadFactory::create::_<closure>::_<closure>::closure.170374
                        at /home/divad/Rust/servo/components/script/script_thread.rs:641
  61:     0x7fce15afea74 - mem::ProfilerChan::run_with_memory_reporting::h14646429605872663705
                        at /home/divad/Rust/servo/components/profile_traits/mem.rs:60
  62:     0x7fce15ae912d - script_thread::ScriptThread.ScriptThreadFactory::create::_<closure>::closure.169754
                        at /home/divad/Rust/servo/components/script/script_thread.rs:640
  63:     0x7fce15ae8587 - util::thread::spawn_named_with_send_on_failure::_<closure>::closure.169741
                        at /home/divad/Rust/servo/components/util/thread.rs:52
  64:     0x7fce15ae7f73 - std::thread::Builder::spawn::_<closure>::_<closure>::closure.169730
                        at ../src/libstd/thread/mod.rs:277
  65:     0x7fce15ae7ee8 - sys_common::unwind::try::try_fn::h15441903801498570928
                        at ../src/libstd/sys/common/unwind/mod.rs:153
  66:     0x7fce16ff4f78 - __rust_try
  67:     0x7fce16ff124b - sys_common::unwind::try::inner_try::h62f00e3d34dbb509D3s
  68:     0x7fce15ae7e25 - sys_common::unwind::try::h2826455607981404404
                        at ../src/libstd/sys/common/unwind/mod.rs:123
  69:     0x7fce15ae7c6b - std::thread::Builder::spawn::_<closure>::closure.169727
                        at ../src/libstd/thread/mod.rs:277
  70:     0x7fce15ae8797 - boxed::F.FnBox<A>::call_box::h11407286024432784320
                        at ../src/liballoc/boxed.rs:541
  71:     0x7fce16ff7263 - sys::thread::Thread::new::thread_start::hb3a0514b9d87669e1mx
  72:     0x7fce1187c181 - start_thread
  73:     0x7fce13a9347c - __clone
  74:                0x0 - <unknown>
thread 'ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }' panicked at 'assertion failed: *self.stack == mem::transmute(&*self)', /home/divad/Rust/servo/.cargo/git/checkouts/rust-mozjs-ebb4917e843c0a11/master/src/rust.rs:334
stack backtrace:
   1:     0x7fce16ff5ad0 - sys::backtrace::tracing::imp::write::hd273f86d5325347aweu
   2:     0x7fce16ff89f5 - panicking::default_handler::_<closure>::closure.42335
   3:     0x7fce16ff849f - panicking::default_handler::h907ce0af740f5f06spy
   4:     0x7fce16fe14e6 - sys_common::unwind::begin_unwind_inner::ha417239bcab1f2ff56s
   5:     0x7fce15206b17 - sys_common::unwind::begin_unwind::h14435761367766209739
                        at ../src/libstd/sys/common/unwind/mod.rs:227
   6:     0x7fce15259600 - rust::Rooted<T>.Drop::drop::h10148855915066515977
                        at /home/divad/Rust/servo/components/servo/<std macros>:3
   7:     0x7fce1525955c - js..jsapi_linux_64..Rooted<js..jsapi_linux_64..Value>::drop.130360::hbea65b6ec5622d8e
   8:     0x7fce157fdcc9 - dom::htmlscriptelement::HTMLScriptElement::execute::hd820d00a090ebc54u4T
                        at /home/divad/Rust/servo/components/script/dom/htmlscriptelement.rs:443
   9:     0x7fce159422a7 - dom::htmlscriptelement::HTMLScriptElement::prepare::hdf4a27ee8b6ffe51YTT
                        at /home/divad/Rust/servo/components/script/dom/htmlscriptelement.rs:344
  10:     0x7fce159cd1bf - parse::html::servohtmlparser..Sink.TreeSink::complete_script::he40fdf910a4859cc8Ce
                        at /home/divad/Rust/servo/components/script/parse/html.rs:156
  11:     0x7fce159b37cc - tree_builder::rules::super..TreeBuilder<Handle, Sink>.TreeBuilderStep::step::h11281135998388019670
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tree_builder/rules.expanded.rs:1461
  12:     0x7fce1599a039 - tree_builder::TreeBuilder<Handle, Sink>::process_to_completion::h6465385879961674149
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tree_builder/mod.rs:327
  13:     0x7fce1599580e - tree_builder::TreeBuilder<Handle, Sink>.TokenSink::process_token::h14073795346578288465
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tree_builder/mod.rs:425
  14:     0x7fce15994a91 - tokenizer::Tokenizer<Sink>::process_token::h1142806760397791138
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tokenizer/mod.rs:233
  15:     0x7fce159de007 - tokenizer::Tokenizer<Sink>::emit_current_tag::h12032453629681101526
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tokenizer/mod.rs:392
  16:     0x7fce159d621a - tokenizer::Tokenizer<Sink>::step::h17000905979645303138
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tokenizer/mod.rs:795
  17:     0x7fce159d35fb - tokenizer::Tokenizer<Sink>::run::h9347854623409678734
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tokenizer/mod.rs:334
  18:     0x7fce159f3ed2 - tokenizer::Tokenizer<Sink>::feed::h11122150034214555435
                        at /home/divad/Rust/servo/.cargo/registry/src/github.com-0a35038f75765ae4/html5ever-0.2.11/src/tokenizer/mod.rs:221
  19:     0x7fce1598b858 - dom::servohtmlparser::ServoHTMLParser::parse_sync::h9e1bf7a0c9447631w72
                        at /home/divad/Rust/servo/components/script/dom/servohtmlparser.rs:470
  20:     0x7fce1598af92 - dom::servohtmlparser::_&'a ServoHTMLParser.Parser::parse_chunk::h24a49f06855bcb41Y02
                        at /home/divad/Rust/servo/components/script/dom/servohtmlparser.rs:355
  21:     0x7fce1598ad73 - dom::servohtmlparser::ParserRef<'a>::parse_chunk::hdb1c7549f7a040c8sM2
                        at /home/divad/Rust/servo/components/script/dom/servohtmlparser.rs:141
  22:     0x7fce1598f053 - dom::servohtmlparser::ParserContext.AsyncResponseListener::data_available::h100afa4737423bafNU2
                        at /home/divad/Rust/servo/components/script/dom/servohtmlparser.rs:306
  23:     0x7fce15eb8021 - ResponseAction::process::hc5e234e7d4322f71jMd
                        at /home/divad/Rust/servo/components/net_traits/lib.rs:136
  24:     0x7fce15b9e835 - network_listener::ListenerRunnable<T>.Runnable::handler::h13439789093495147791
                        at /home/divad/Rust/servo/components/script/network_listener.rs:48
  25:     0x7fce15b02685 - script_thread::ScriptThread::handle_msg_from_script::hefd7cdb2573bf9e3bjg
                        at /home/divad/Rust/servo/components/script/script_thread.rs:1149
  26:     0x7fce15b7db62 - script_thread::ScriptThread::handle_msgs::_<closure>::closure.171647
                        at /home/divad/Rust/servo/components/script/script_thread.rs:1001
  27:     0x7fce15b7d782 - script_thread::ScriptThread::profile_event::h15525301070989550331
                        at /home/divad/Rust/servo/components/script/script_thread.rs:1083
  28:     0x7fce15b512cb - script_thread::ScriptThread::handle_msgs::h8d3c2378aac8698e44f
                        at /home/divad/Rust/servo/components/script/script_thread.rs:993
  29:     0x7fce15afed90 - script_thread::ScriptThread::start::he5c522eecb9402a4U4f
                        at /home/divad/Rust/servo/components/script/script_thread.rs:851
  30:     0x7fce15afed44 - script_thread::ScriptThread.ScriptThreadFactory::create::_<closure>::_<closure>::closure.170374
                        at /home/divad/Rust/servo/components/script/script_thread.rs:641
  31:     0x7fce15afea74 - mem::ProfilerChan::run_with_memory_reporting::h14646429605872663705
                        at /home/divad/Rust/servo/components/profile_traits/mem.rs:60
  32:     0x7fce15ae912d - script_thread::ScriptThread.ScriptThreadFactory::create::_<closure>::closure.169754
                        at /home/divad/Rust/servo/components/script/script_thread.rs:640
  33:     0x7fce15ae8587 - util::thread::spawn_named_with_send_on_failure::_<closure>::closure.169741
                        at /home/divad/Rust/servo/components/util/thread.rs:52
  34:     0x7fce15ae7f73 - std::thread::Builder::spawn::_<closure>::_<closure>::closure.169730
                        at ../src/libstd/thread/mod.rs:277
  35:     0x7fce15ae7ee8 - sys_common::unwind::try::try_fn::h15441903801498570928
                        at ../src/libstd/sys/common/unwind/mod.rs:153
  36:     0x7fce16ff4f78 - __rust_try
  37:     0x7fce16ff124b - sys_common::unwind::try::inner_try::h62f00e3d34dbb509D3s
  38:     0x7fce15ae7e25 - sys_common::unwind::try::h2826455607981404404
                        at ../src/libstd/sys/common/unwind/mod.rs:123
  39:     0x7fce15ae7c6b - std::thread::Builder::spawn::_<closure>::closure.169727
                        at ../src/libstd/thread/mod.rs:277
  40:     0x7fce15ae8797 - boxed::F.FnBox<A>::call_box::h11407286024432784320
                        at ../src/liballoc/boxed.rs:541
  41:     0x7fce16ff7263 - sys::thread::Thread::new::thread_start::hb3a0514b9d87669e1mx
  42:     0x7fce1187c181 - start_thread
  43:     0x7fce13a9347c - __clone
  44:                0x0 - <unknown>


Thanks. Have invalidated this key and sorted this out. Infinite embarrassment, esp. after taking care not to commit my local db creds.


Fix v3.0.0 to properly detect "js.cookie.js" instalation


@jjangu Consider breaking out some more partials that repeat on all pages like:
_header.scss
_footer.scss


Yeah that sounds good to me. My plan was to Ajax the data.  So that should work fine.  And yeah the draggable can definitely work that way.


This is functional too.

One convention is to use class-methods for code with side-effects, but to use top-level functions taking G for pure functions. There's nothing wrong with mixing styles if it has a purpose.

Anyway, G is already an object of a closed class, so this is really an academic question. The code looks good to me.


@obecolette thanks will do


Looks like something got lost in the merge here--we're no longer calling `registerHelper` on this function.


I like that image. :+1:


I don't have a strong opinion either. Will leave it to @martint to decide as he looks through the Teradata code


Yields and returns should be on their own lines so they pop out. Maybe continues and breaks too. Other stuff can be on one line.


I'd probably say "Expected accumulated retry delay" rather than just "delay".  A delay of 24 hours is not what we want, but rather a 24-hour period within which retries occur.


If a supplier invoice has a the arrray  supinvoice->lines define with 3 lines. We want to update a line, so we call the update line.
If you do a this->lines[], you add a forth line. So this change looks wrong to me.

We should update and not add the line and only if it already exists into supinvoice->lines array.


K, now I understand what you're trying to do with NAN.

Some library a dude created to make compilation of native add-ons a bit more break-proof from the madness that goes on with the v8 api, that keeps changing dramatically and breaking everything.

I like that path, but at the same time, I see you're trying to ease your way out of it declaring a lot of things with `auto`.

I don't have much experience with this feature of C++11, but given that you're working really with C code under, not really C++, I'm not sure if this is actually going to bring you even more headaches due to unwanted type conversions.


erijgioergjreig
erpgijergoijeroigejrgioerjgioerjg


Done and dusted.


I think it might be worth asserting that `retrier.ShouldRetry(request)` returns false at this point.


@chai2010 ，这个地方我的考虑是与原文一致：
>because it simplifies logic
原文如此，没有细说到底是简化程序员编程时的逻辑，还是简化编译器的逻辑，我以为译者在无法确认的情况下，最好不要对原文的过度引申。


Gah. Oops. Thanks.


Wait, yeah we are it's just lower.


Small performance improvement:

    izip = itertools.izip

to avoid the symbol look-up in the inner loop.


were the original data types giving you issues when building?

like issues with `String::AsciiValue`? or `uint32_t` not being found?
why risk it with so many `auto` declarations?


Why query here?
And why you only set looktype? What about mounts/addons/colors?


Try to put all imports at the top of the file. That shows the dependencies.


确实有这个问题。目前的出里方式是如果原文使用了等宽字体，那么翻译时用````号包括起来，譬如`main`。这个事儿特别琐碎，很容易漏掉，我觉得校准的时候发现就改掉，漏掉就先这样把，跟注脚类似，可以等放再仔细合并处理一次。


1. 简化签名，不必使用Buffer即可完成签名
2. 创建一个App调用多次发送会失败（因为_.merge会改变第一个参数的值导致this.config被修改生成的签名不正确）
3. 将GET请求改为POST


Looks good!


这路径不对吧？../assets/beauty.jpg 是 source下的assets，我们应该用flex下的assets，即/assets. @happypeter


you can just return &val


this code seems to be naive in terms of nested constructions. it considers that u can only use certain definition once, which is usually true, but could be confusing for those cases when you have multiple properties of the same type on the same level of tree


hi @lennerd , using this agent doesn't seem accurate. I also have those user agents :

    Spiderbot/Nutch-1.7
    tbot-nutch/Nutch-1.10
    Nutch/2.2.1 (page scorer; http://integralads.com/site-indexing-policy/)

So using Nutch as the agent seems more accurate, what do you think ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12397](https://teamcity.mesosphere.io/viewLog.html?buildId=110461&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:17


Now you get the console of the QEMU host directly in your terminal, I was looking for this for ages. Nice!


no, it does not. because when at least core 3 is also powered up, core 4 can follow.


I fixed all the relevant comments in the code edited by us. All remaining comments can be tracked by # 5617


Just did some checks - the line will not work for some cases, as `level_number` is a derived SQL attribute. `create_list` will only return an array without the level number which breaks some tests (eg. `level#next` needs the level number)

Because of that, the `course.levels` within this describe block are instantiated and sorted correctly, but lack the calculated attribute.

For now, would suggest to revert back to `course.reload`. If we want to fix it, I suspect we will need to remove the association cache after building the default level. That might trigger rspec/rails to reload levels again.


why this change?


@luiges90  耒大，能不能把事件新增是否选项的代码写给我看看？


@chelmuth: above commit makes the buildbot happy


If you used a calculated attribute, then the missing level_number attribute would be resolved by an SQL query. Does that not happen?


Nice. Thanks :)


// GetPodReplicaSets


I think this is what that guy the other day was referring to on issue #434.
Indeed, it was a while ago, it's no biggy.
Look at it, it just feels like streaming everything all the time might
benefit from being an option rather than a default.

On Fri, 22 Jan 2016 at 09:42 Rob Evans <notifications@github.com> wrote:

> Not sure. I remember that there was a really good reason to do it though,
> something about values not streaming when they should be.
>
> Once the data gets built up from the multiple stream sections the final
> string is checked against the previous one and only sent if different, so
> there is a larger check at the end of the process.
>
> I know the change came because of something not working in the StarFlight
> project I was working on. Without this change the stream properties never
> updated or only updated in certain conditions. I realise that is really
> non-descript but it was 4 months ago :)
>
> I'm happy to revert this change if it's not fixing a problem for others.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Irrelon/ige/commit/c62581f7ca8ff8025d06db796df94f0faefd611e#commitcomment-15608405>
> .
>


Denis, if you only change line 93 and leave the protocol detection, does it work for you then?

'href'  => '/image/' . utf8_substr($image, utf8_strlen(DIR_IMAGE))


godoc convention: // List lists...


I'd rename `apply_ns` to `should_copy`.


lowercase the error


Why implement a move constructor when it does nothing move-y? I'd either drop it or implement it somewhat like this:
```c++
StyleSetPropsRef::StyleSetPropsRef(StyleSetPropsRef&& other)
   : mpStyleSetProps{other.mpStyleSetProps}
   , mpUsageCount{std::move(other.mpUsageCount)}
 {
   other.mpUsageCount = nullptr; // in order to not depend on any implementation-dependent post-condition of moving from other.mpUsageCount
 }
```
Though that would require adding an `if` to the destructor.


lowercase the start of the error


Think we should mark this file as assume unchanged or something, otherwise we'll keep merging the wrong version strings from one branch to another.


I'm not sure what happened but when I tried accessing all the level numbers, they were all 0. Not sure whether an SQL query was made, might need to see the verbose rspec output.


We can add it for sure, just raise a JBTM and I will make sure .13 has it


It's your code, just in a different wrapping :-)


bjhbjhbjhbjhbhjb


you can start a Rails console with the TEST RAILS_ENV and debug there.


s/controller/replica set/g


The post SDK returns a status and will only fail if the task Q is already full. Quite honestly as this is the first scheduled task, this failures shouldn't occur and we couldn't do anything if it did.


pass app identifier parameter to UFT


should be enqueueReplicaSet


Yep. Thank you.


Good catch.


syncReplicaSet


s/controller/replica set/


drop Controller


Interesting, this is for sure. Did you had a look what the default core access checker does?


edited for branch 2 master edit


Btw I found other issues.

1. In boost/cgi/fcgi/client.hpp there are full-specified members of fcgi-parameterized ``basic_client``. This means that I cannot include headers that dependently include this header in multiple translation units because it violates ODR. There are two ways to fix it: 1) make this header a .cpp source code which is really bad because this CGI library is intentionally supposed to be *headers only* (am I correct?), and 2) specialize full class template with all its other content copied (this is boring but keeps the library header only).

2. ``async_load()`` is not implemented

3. Response is a plain text, but FCGI requires binary tags like ``FCGI_STDOUT`` and ``FCGI_END_REQUEST`` (sse examples from [here](http://www.fastcgi.com/devkit/doc/fcgi-spec.html#S5.3)). This works somehow in nginx but my testing tool based on *perl-FCGI* return errors.


Absolut richtig. Der Austrittsvektor ist R, der Aus- und eintrittswinkel ist derselbe und ist theta.


Any reason for using postinst instead of preinst? I mean it's ok if it works, but maybe it would be safer in preinst.


Should be an utility at pkg/controller/controller_utils.go


使用异步,避免阻塞


Indentation errors on ListRoute.js


nice!


I don't see how the change could play well with more than one language. So "No", in current state.


Good work.
I think mti_GetResolutionLimit() is the equivalent for FLI


@daniel-luberda This improvement could be added on Android and WP: https://github.com/molinch/FFImageLoading/commit/f645c40170adc27d9c0443747e06631e4b4fa91f#diff-9c653fc0bc273453149ef75da1a23a48R263

This MemoryStream, on WP, could probably be removed too: https://github.com/molinch/FFImageLoading/blob/ae1f38a8c30e0b769cd02bc47e9eb5ed82e36873/source/FFImageLoading.Windows/Cache/DiskCache.cs#L318


проинклудь это в layout.html.twig а не сюда


cc: @bprashanth


Commit message nitpick: s/not existing/non-existing/


Are you sure the npm-debug.log should be added?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12398](https://teamcity.mesosphere.io/viewLog.html?buildId=110470&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:08:28


Double parenthesis?


Nee, ik moet nog meer zooi in een .gitignore zetten. slordig, I know.


Hmmm grösser isch immer guet @zperee @zmartl-bbc


Fixed at cf49ad2


I thought we agreed to remove the mymodule prefix.


pour moi un rtype c'est toc , abs ou article
et pdf, html, misc c'est du mime
c'est peut etre pour ca que je n'ai aucun article dans les EC en pdf,


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12399](https://teamcity.mesosphere.io/viewLog.html?buildId=110477&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:09:55


Maybe you meant "canola"?


Currently there are 7 classes in 1 header file here, and likewise for the cpp file. Please don't do that! It's easy to create a folder and just put the 14 files there, even if they are small files.


Is changing the name necessary for this test? If not I'd remove it (or replace it with some other property access if it's just required to initialize the attached property in a certain order) since it can be confusing when trying to understand what's going on here.


If the directory already exists (for some reason) with some files it will change ownership of the directory itself and not the files in it - not sure if this is intended so just making a note of it.


create a `ScaleFromReplicaSet` api helper at apis/extensions/helpers.go similar to [ScaleFromDeployment](https://github.com/kubernetes/kubernetes/blob/7fea0ada4b158635660bed389f0d06e704f6a77e/pkg/apis/extensions/helpers.go#L68) and use it both here and in Update.


which dsym headers?


CONST 25


Bonjour,
je viens de corriger le parseur, c'été une faute de ma part

On Fri, 22 Jan 2016 02:19:54 -0800, fredericinist wrote:
> pour moi un rtype c'est toc , abs ou article
>  et pdf, html, misc c'est du mime
>  c'est peut etre pour ca que je n'ai aucun article dans les EC en
> pdf,
>
>
> --
> Reply to this email directly or view it on GitHub [1].
>
> 	*
>
> Links:
> ------
> [1]
>
> https://github.com/ezpaarse-project/ezpaarse-platforms/commit/db001660595c005960d521bf5fe2d1d225e1ba44#commitcomment-15609069


PHONEIX-2407 issue resolved ? please give ample information on commit message while pushing code to github


good test, dead lock or hang, waiting on previous resolves to complete? which could be complete? race condition??


Ich hans mal mit e Million gmacht xD


OK. I'm leaving uber jar for now, since I depend on 5.2.12.Final. I'll update once the fix is released. Here is the issue for the fix: https://issues.jboss.org/browse/JBTM-2612


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 12400](https://teamcity.mesosphere.io/viewLog.html?buildId=110478&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:07:47


Using Delphi XE8 and Ribbon Designer version 2.1 have build error:

STARTING THE RIBBON COMPILER...

STARTING THE RESOURCE COMPILER...
ERROR: Error executing "Generate.Ribbon.Markup.pas.ps1""

Using designer version 1.2 build OK.


@bambooom 谢谢~去试用看看~


return ttl, nil


Codacy code cleanup for issues in commit 5865a5a


Why not just `defer safeClient.Unlock()`?


Yes, see [1]. Every time when user with name "error" is created, service throws RuntimeException to test rollback.

[1] https://github.com/gytis/spring-boot/commit/e2f5ecd2e8f4f44136fbb13bf5f3c00c5476e598#diff-354b94a8bb4bbec9299d91aae1238b8aR37


i think we have a defined shutdown error somewhere in etcdserver pkg.


The `shared_ptr<size_t>` feels a bit inefficient to me. It's just a gut feeling and thinking about performance without mearuing is evil etc... but wouldn't a simpler alternative be to add a struct like this:
```c++
struct RefCountedStyleSetProps {
  StyleSetProps mStyleSetProps;
  size_t mRefCount = 0;
};
```
and to store `unique_ptr`s to that in `StyleEngine::mStyleSetPropsInstances`? `StyleSetPropsRef` could then just hold a pointer or reference to the struct.


add a todo? we should try all urls not just one.


you're right, needs to implement hashCode/equals as well :(


define error type? at least we need to add a prefix like `etcdserver: no leader`


Shouldn't this have a negation?


It would be great to the ROP sorted by average consumed time but not compulsory at all.


Shouldn't this be `__GENERICS_TYPE(ObjectType)` so it uses `id` if the `objc_generics` feature is unavailable?


Fixes https://github.com/Microsoft/react-native-code-push/commit/3e4ac610fe2a9826756005f0ee0bf44266c56d70#diff-b7db8d4961f23b3a578b72dad2e6d9d0R85


Done.


make the func declaration one line? (we do not usually wrap this line)


I guess that I'm just to use of using defer for `Close`, which then we need to check the error :P Let me change that.


The `enablePlugins(ScalaJSJUnitPlugin)` is useless here, I will remove it.


위에는 new CONNECTION_NOT_CLOSE()
아래는 그냥 멤버변수 error로 사용한 이유는 뭔가요?


Move all jrxml and jasper to resources/reports folder @manikanta-pt please instruct.


Радикально)


Strictly speaking, clearing `mMissingProps` isn't part of extracting `checkProperties()`.


I think the simplest would be keeping the original case classes but make them private and then build a public trait that is implemented by the case class and an object that implements the apply methods.


Создай, пожалуйста, новый коммит, и добавь имя наставника в формате:
[Имя Наставника](профиль наставника на гитхабе).
Вроде бы Саша в лекции так просил сделать


update the comment too


return или всё-таки void?


ok


'Update' is very generic and doesn't mean anything; a short description is a good idea for every update.


My suggestion:
Extended characters are not supported in CIFS paths, usernames, and passwords.


My suggestion:
The WLB server said something that your server wasn't expecting or didn't understand.


That sounds quite good indeed, and `withBlabla` would be easy to implemet too.
I'll try that now


I choose 'geodata', is this good ?


Да, всё же void.


Я бы оставил короткие названия - *_DOWNLOAD, *_UPDATE, зачем многословность если нет отдельных файлов?


yes, it's good too :-)


There has been a discussion about this few months ago and as far as I remember the conclusion was that arguments are language specific. I am not sure if that is true, but certainly correctly parsing command line composed with arguments for unknown amount of modules is problematic (see  http://bits.netbeans.org/8.1/javadoc/org-netbeans-modules-sendopts/).

If the arguments are supposed to be per-language, then the API should look like:
```java
PolyglotEngine vm = ...;
vm.getLanguages().get("text/javascript").getGlobalObject().setArguments(...)
```

but the whole things is so language specific, that there never was enough thought given to abstract it to work across all languages.


Короткие названия были привязаны к логике без роутинга. Переименую их.


The bottom line is: we need a) a scheme of scoped pinning/unpinning, and b) a means of avoiding the described race.


some of the test cases like :
what is the sum of 2 and 5?
add these 2 , 5? etc wont work.. so add more words like 'sum of', 'these', plus add 'comma' too in the list


hi Justin the Engineering Spec are in revision 2 and your config file is not right
I completed this
https://github.com/jeedom/plugin-openzwave/blob/master/ressources/openzwave/config/aeotec/zw112_doorwindow6.xml

best regard


This is looking ok to me! I think we don't have much options here instead of reimplementing async transaction context manager.

I think we need import guards to prevent importing on Python prior to 3.5 version. And we need tests :)


this is only needed for avocado I think


This config is tested and fully functional as well.


Hi, as far as I know, Chrome doesn't allow you to draw video frame to canvas. Is this a bug, or a feature to reduce bandwidth I have no idea. Just use native video, as it works out of the box.


Whoa, so the result of the process is actually returned via a reference parameter that's set in the *constructor*?

Couldn't that just be a const output parameter of a function, or a return value?


I guess this should be "backwards compatible"?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1216](http://teamcity.monogame.net/viewLog.html?buildId=13869&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:47:18


Seem like `await` is missing here.


True. I'll revert that change


:+1: thx!


This should be reverted by last commit : 7b498a4da6e37d6ef17dc67b7ee7b853e02dad1a


重新提交合并


Can you unlock ? There is an error at 137.


?  < 40150


Oops, I'm a retard


thanks this is amazing! :)


^ wrong URL


:ok:


hmmm, I would only add/use strings to action-types when we use them from any action defined inside of the state directory / redux-related code. Keep in mind that the dispatcher user here (Flux's one) and the one we use in redux aren't the same, so it's not like the code which manages this dispatch is the same that the one managing the redux' dispatches.


@alex-mikheev - what will be behavior in case of bad input?


@errorSummary() is in a separate PR?


@nebhale : I tested the behaviour of `after` and you're right: validation errors are ignored. _However_ this behaviour is a bug, so we should take into account the corrected behaviour (propagates the error, so request validation failure would fail the whole stream).


je ferai attention la prochaine fois et j'utiliserai ton outil

2016-01-22 10:26 GMT+01:00 Stéphane Gully <notifications@github.com>:

> La virgule manque sur la ligne suivante :
> "portalparts.acm.org"
>
> (mais depuis Yannick a corrigé.)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ezpaarse-project/ezpaarse-platforms/commit/4fc785b03f9fea8bdd592aa5de027bbe466cf20e#commitcomment-15608124>
> .
>


Indentation


Dropping mote and it's pickup is not bound processes, so i have not expected to see it.=)
pb's will be with dots, when someone use dot on target that is not touched by meter starter, but i don't see the way to workaround this.
btw, received heal/hot statistic tab may also be interesting and should show hots that was applied out of meterstarter field of view (for example priest buff outside of dungeon in crossserver party)


Hello @mcalmer ,
I've finally found some time to review the commit. Sorry, about the delay.

You're completely right. My fault was I named the ks distributions/trees the same like the appropriate channel labels. So, the commit worked for me. If the ks tree is named differently, it obviously cannot work.

Unfortunately, I'm not able to come with a good solution, as:
* you cannot associate a child channel with a ks tree
* kickstart requests are based on the ks trees, not on the ks profiles, with them child channels are associated

Would you prefer me to revert the commit(s) as you write they break kickstart installations with multiple child channels associated or do you have an idea, how to patch it and keep the workaround (with the limitation of naming ks trees the same as child channels for those who want to use it) in Spacewalk?


I would rather delete the link in each comment. Why would someone click the link of a specific comment if he/she can read this one already in the feed? We could then add a link to the text "Spenden an Wikimedia" leading to our landing page.

in case this doesn´t work or implicates something that I can´t hink of, just leave it as it is.


I have some naming considerations:

1. The whole library is explicitly "asynchronous", so we don't need to append `async_` or `_async` part to public functions, i.e. we have `execute()` not `async_execute()`. So I think we should provide `transaction()` context manager instead of `async_transaction()`. We don't mix sync and async here. Everything is just async.


je vais mettre à jour la préprod et tester sur un mois de comparaison stat (janvier 2015)

en traitant sur 1 JOURNEE, je vois les pdf redcube qui apparaissent donc ca devrait bien marcher

Merci Stéphane et Abdel


const std::string &.... () const?


Hey! Any particular reason for this? This looks like it breaks the intension of the function (to only reload the tab that the user clicked on), or did you just comment it out while debugging?


Вот такие точки с запятой, по-моему, лишние. Учитывая отсутствие точки с запятой строкой выше. (Ну и в 43ей строке тоже нет точки с запятой). Это не помешает проходу задания, просто странно выглядит.


I have basic ground for quest [5821 (Bodyguard for Hire)](http://www.wowhead.com/?quest=5821) but I did not have the time to test my script yet.
I'm missing the spawn points for [quest 5943 (Gizelton Caravan)](http://www.wowhead.com/quest=5943/gizelton-caravan). If you have them, it would be helpful. :)


actually it is possible to run coverage on 3.2, it's just necessary to install "coverage<4.0", it works fine then, even with coveralls


This breaks my nice AddPause functionality.


I wanted to do the same but `transaction` is used internally by Peewee and if I would rename `async_transaction` to `transaciton`, it'll blow up because Peewee will expect it to be normal(not async) context manager. The same apply to `async_atomic` and `async_savepoint`.


this is PAGE_SIZE right?


Is this line needed?


OK, but be prepared for me to ask for a .13 and the individual Jars before we PR springboot repo :)


jjbjbjbjb


done


Great. I do still think it would aid readability as it looks like poor exception handling unless you know what to expect!


Makes sense :smile:


jbjbk


`prefill_cache` calls the functions who generate variables.

BTW it is bad named, it does not *only* prefill the cache


This one-liner must be changed to:

if use python;
  cd "${BUILD_DIR}"/bindings/python || die
  distutils-r1_src_install
fi


its not doing it with this change.


missing || die


I think I answered that but by email?


I'll add a comment.


missing || die here too


uh? what is that script meant to be doing?


We should raise pr to Spring only with the latest version anyway.


Perfect - thanks


I see you have already fixed this. Thanks @nebhale.


"AkasataNahama"→"Akasata Nahama"
Space is important!


2. When we **mix** sync and async interfaces like we do with `AsyncPostgresqlMixin` that is not really cool, but I think we can't avoid that for now as we often need a drop-in replacement for sync codebase. And actually many inits are just ok to run synchronously. So, when we have to mix, I've decided to suffix names with `_async()` instead of prefixing `async_`, because of C# common practice - they add suffixes. Python's async / await are semantically very close to C# ones.


went from 20sec to 8sec :+1:


This version causes an error with MySQL 5.7. The `storage_engine` system variable is [removed](http://dev.mysql.com/doc/refman/5.7/en/mysql-nutshell.html#mysql-nutshell-removals) in MySQL 5.7 and replaced by `default_storage_engine`.


Thank you) can now proceed to the conservation in cocos2d v3 format and testing....


should probably be `reference_value_size`


I'll have a look later today, thanks for the report.

On 21 January 2016 at 10:35, simson2010 <notifications@github.com> wrote:

> I got msg :
> Warning: React.renderToString is deprecated. Please use
> ReactDOMServer.renderToString from require('react-dom/server') instead.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/datashaman/react-server-rendering-example/commit/42a35af64bc872453453bbe5d66c91421bd3c16f#commitcomment-15579708>
> .
>


If I remember correctly it is the later one


I've rewritten receive again, because this one didn't work on chunked streams and I'd only tested on a preset size stream. My new one works on both set size and chunked streams, but the problem I'm having now is that sometimes something inside the openssl BIO vanishes and then read/gets function calls either return nil or crash. See https://github.com/fiendish/lua-openssl/commit/019c023ca8d2128b19cda65dff61a1521f7862a2

I'm a total openssl novice, so I don't know what's going on. Any thoughts?

I'm testing with
```
sock = require "ssl.https"

while true do
   a,b,c,d = sock.request("https://github.com/fiendish") -- this crashes after a few successes
   print(b, c, d, a and #a or '')
end
```


what the hell u talking about firs commit ? iv been sinking commits all this while haven't it ?


Hello, je serai ravi de pouvoir vous aider à mettre a niveau ce plugin pour qu'il fonctionne sur la version la plus récente de video.js.
 Votre branche me semble être la plus aboutie (par rapport aux autres forks, et même à Master) savez-vous ce qu'il reste à faire pour le rendre à nouveau fonctionnel ?

Merci d'avance


yep


Actually I've decided to create an application exception rather than use generic one. This should make it even more readable.


@cyberium
where ego? as always it already done in R2. but cmangos why does not want to take a lot of ready, tested, working code. lazy cmangos =)


cc @barbalberto


Perhaps it is better to rename the superclass then, instead of this one. If this is the first child in the hierarchy that actually has zigzags, then the superclass would not have zigzags, so the superclass should not have zigzag in the name. You'd then call it `ConnectorProcessor` (though that too is not a very descriptive name; maybe it should rather be called something with the word "infill" in it, or whatever else if you can think of something better).


> it'll blow up because Peewee will expect it to be normal

Hmm... That's possible, but why it would? I haven't done investigation yet, so I have no idea actually. Why context manager name matters?


@Rushor
and what?

https://github.com/mangosR2/scriptdev2/commit/21a5e6eff32ce865b751fdd27474c23d0e5080f0
signed as: Adapted from TC, author DDuarte


(maybe I shouldn't change the name of the actions that didn't belong to redux actions .. hmm, I think I'm going to change the flux ones back to RECEIVE_WPORG .... )


`Why context manager name matters?` - because it's called from `_atomic` context manager(`with db.atomic()`) as `db.transaction()` - so if our `db` is anything inheriting from `AsyncPostgresqlMixin` then it'll return our `async_transaction` instead of `transaction`. So in this case you would have to be really careful where you use async db and when not


Can you make this:
```
 (flg) | GEOIP_SILENCE);
```
when or if  several bits are used in `flg`.


@xfurry
this my piece of code:
            case POWER_MANA:                            // Food
                if (GetId() == 66041)
                    modValue = int32(float(target->GetMaxPower(POWER_MANA)) * 0.04f);
                break;
other don't know. @rsa?


This change should be reverted. It's one thing to stop testing new features against IE8 come the end of March 2016, but even then we shouldn't be actively reverting existing IE8 support code as it will cause our client's pain with little benefit to ourselves.


Wow. Looks fab!

Just ran this version to release stylelint 4.1.0, and all went well.

Thanks for doing this rewrite, it makes releasing effortless :)


Why not just `model(table)`?


程序ID的類型是 int 嘛
數據庫應該是對應長整型

再不行就逐一測試吧 :sweat_smile:


That's scattered everywhere. I think we can do that in a new change, if at all. I don't think it's important enough because those are tests and it's correct as it is.


Wow! You are genius!


@aquamatthias shouldn't we point that out in our documentation and in our release notes?

The new `fetch` fields is only documented in the app definition JSON schema.


@chelmuth: yet another fixup to re-enable the wandboard, worry for the inconvenience!


I think it would be better to revert it.

I did here some modifications on the SQL statement. Not sure but maybe this would help to select the package from the right channel:

```
     <sql-query name="Channel.packageByFileName">
-      <![CDATA[SELECT {p.*}
-          FROM rhnPackage {p},
-             rhnChannelPackage CP,
-             rhnChannel C
-             WHERE (C.id = :channel_id OR C.parent_channel = :channel_id)
-               AND (CP.channel_id = C.id  OR CP.channel_id = C.parent_channel)
-               AND CP.package_id = P.id
-               AND P.path LIKE :pathlike
-          ORDER BY p.build_time
+	    <![CDATA[
+	        SELECT {p.*},
+	               (CASE WHEN C.id = 698 THEN 1 ELSE 0 end) as chanprio
+                  FROM rhnPackage {p},
+                       rhnChannelPackage CP,
+                       rhnChannel C
+                 WHERE (C.id = :channel_id OR C.parent_channel = :channel_id)
+                   AND CP.channel_id = C.id
+                   AND CP.package_id = P.id
+                   AND P.path LIKE :pathlike
+              ORDER BY chanprio DESC, p.build_time
         ]]>
```
This is more for the other commit, but maybe it would help here also?
(The original query here is a bit different to what is in spacewalk.

I used build_time as order statement, because I hope derived distributions like CentOS would build fixes always "after" the main distribution. This would mean original RedHat packages are prefered over derived dist packages.
With this change I added now the channel prio as first criteria.


weutoih gm


wait, now I'm thinking on it that action is not used anymore!! (we use the one defined in state/plugins/wporg/actions). So I can just remove those tests & that action!


Is it reopen or finished?


Well, texture border and sprite border are still missing in the implementation.


Oh my, maybe we could have started with a clean history (i.e. used rebase here instead of merge)

(sorry, I have a bit of an OCD with clean commit logs)


The statement has a small typo:

```
(CASE WHEN C.id = :channel_id THEN 1 ELSE 0 end) as chanprio
```
in the select part would be better :-)


1968-new-oa-methods (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2354 of 2391 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.45%25-yellow.svg)


did this make into into main?


The reasons I purge it:
1. It seems nobody caring about it.
2. The upstream has 2.3.0 there.
3. 1.4 branch is a beta version, for test case.

If someone needs this, feel free to add it back, with further updating it to 1.4.111


Hi !

The action "stop" fails on mongod and mongos services

Like start-stop-daemon man says "--exec won't work with interpreted languages" ; it seems to be the problem. I think $PIDFILE is enough to guarantee which process needs to be stopped.


> because it's called from _atomic context manager(with db.atomic())

Oh, ok then! :) I meant not methods of class but module functions, e.g.  `peewee_async.transaction()` instead if `peewee_async.async_transaction()`


Yes, I remember, but I really want to have test results in cocos2d :)


This should be done in Canvas, not in DashboardCanvas. Shouldn't it?


Okay- no problem then, will change :)


Dunno.


how to switch back to automatic mode?


Well test case was done several years ago. I hit the bug when I start to port GSdx to openGL. Recent change was due to Delorth's contact. First reply was "not possible, extension is working everywhere". Then you show the 2 lines shader that failed to do a `"1 * 0"` operation on blending unit... However I'm afraid they will only fix it on their non-legacy driver.

The good news is that the free driver also fix a remaining bug. So maybe I would be able to mark the SSO extension as mandatory on the future. And remove legacy openGL code (but I'm afraid that Ubuntu will keep the old Mesa version for a long time)....


```!play 0```, will be documented.


thanks


I don't understand this change


is this ever going to exit?


# dude leave this page as it is, work with view folder

layout should be something like this

>>> top navbar .....  Already done by me ...
>>> {{views}}  --- any one from views/home.html, views/contact.html, views/members.html, views/alumni.html ... etc
>>>  footer


This is shit mate


As you wish, I think
// Ignore exception as it is expected from the test
would suffice but an app exception might be nice too to be certain its the right exception being trapped


Done.


Being negative or positive has no meaning here. It's just that it had to be shifted 12 millimetres, and it happened to just remove the `-`.


remove additional spaces


Nice, but I believe we can simplify this and simply make the existing IdStrategy use varargs. Then if you use it with only 1 arg, it works exactly as it does today.


Wow guys, way to necro a thread.


- 對話在 https://github.com/kpxp/ZhongHuaSanGuoZhi-New-Code/blob/master/GameObjects/GameObjects/Event.cs#L49 觸發
- 然後在這裡 https://github.com/kpxp/ZhongHuaSanGuoZhi-New-Code/blob/73692679b61c4af8755e38606da3145cdf051730/WorldOfTheThreeKingdoms/YouxiPingmu/MainGameScreen.cs#L2201 顯示對話
- 在上面顯示對話那裡，如果事件裏有是否選項，改為調用 ConfirmationDialogPlugin (大概是 https://github.com/kpxp/ZhongHuaSanGuoZhi-New-Code/blob/73692679b61c4af8755e38606da3145cdf051730/WorldOfTheThreeKingdoms/YouxiPingmu/MainGameScreen.cs#L2594 這樣用)
- `this.Plugins.ConfirmationDialogPlugin.AddYesFunction(new GameDelegates.VoidFunction(this.saveBeforeExit));` 這行，改為
```
delegate {
    // 執行事件裏答是的內容
}
```
- `this.Plugins.ConfirmationDialogPlugin.AddNoFunction` 就是事件裏答否的內容


I don't think you have already redelivered the changeset for Write attribute. If not - please include part of this PR or deliver it before this.


F%$K
The pinctrl version is completely different :(


See original idea/suggestion here: https://uwsgi-docs.readthedocs.org/en/latest/tutorials/Django_and_nginx.html#if-that-doesn-t-work


If we would just ignore we wouldn't be able to be sure that the exception has actually been thrown. See this assert: https://github.com/gytis/spring-boot/commit/e2f5ecd2e8f4f44136fbb13bf5f3c00c5476e598#diff-39a2c1c1e3f4667b3e31e80658b8eb3fR40


Lets have filename in small letters


Shouldn't this be the other way round?
We don't need to have selections to have a background.


No \n at the end of the file


Take important part from body of this commit and put them in views/homepage.html and then revert back the changes to this page to its original state.


Where `_this` defined?


With minimal tweaking, this software could also be used to generate fictitious grunt plugins.


I don't see anything other than new line in the end, you can just undo this


Lets not have any story numbers as comment here.


it looks like you copy & pasted this from the accounts.js file, but there are differences. The routes in accounts.js are for admins, while the paths in account.js are for the currently signed in user. Because of that, there is no `request.params.id`. `request.params` comes from placeholders in routes, see http://hapijs.com/tutorials/routing#path for example

So what we need to do is to find out the user account id by sessionId instead. We should also add a check that the current user is not an admin like in the routes above, could you add that?

Does that all make sense so far?


However, the "result_str" was set to the value of the field which originated the calculation ajax event.  So, if I have a set of interims, "Vol" and "Factor", when I enter "3.00" in vol, the result is rounded to two decimal places.  if I then enter 0.9994 in "Factor", the result is rounded to four decimal places.  This is crazy.

This commit has an additional deficit, also; if a calculation returns a formatted_result with some non-numeric string (for instance, the antibiotic resistance calculations), they are now removed.  Having calculations that render some smart interpretation is very useful, and this JS toFloat() function is quite brutal with it's input.

I understood that "result" and "formatted_result" were the values that contained these two values: one, the actual result value, and the other is the value formatted (in calcs.py) according to whatever rules need to be considered.

I haven't worked out a solution for this issue yet, but I had to undo this commit before any calculations worked properly.  when I round up my work into PRs against bika.lims, I'll try take care of this.


Fixes a bug causing segfault when chimera detection is performed on extremely short sequences.


:D


If you haven't started yet, here is the base code for v3 :

```
function exportSpriteSheetV3(dataFilePath, imageFilePath, spriteFrames) {
    var plist = {};
    plist["metadata"] = {
        "format": 3,
        "textureFileName": imageFilePath.replace(/^.*[\\\/]/, '')
    };

    console.log("Collect spriteframes for cocos2d plist data");
    var cocosFrames = {};
    for (var key in spriteFrames) {
        var spriteFrame = spriteFrames[key];

        var cocosFrame = {};

        cocosFrame["spriteSize"] = "{" +
                spriteFrame.frame.width + "," +
                spriteFrame.frame.height + "}";

        cocosFrame["spriteOffset"] = "{" +
                spriteFrame.offset.x + "," +
                spriteFrame.offset.y + "}";

        cocosFrame["spriteSourceSize"] = "{" +
                spriteFrame.sourceSize.width + "," +
                spriteFrame.sourceSize.height + "}";

        cocosFrame["textureRect"] = "{{" +
                spriteFrame.frame.x + "," +
                spriteFrame.frame.y + "},{" +
                spriteFrame.frame.width + "," +
                spriteFrame.frame.height + "}}";

        cocosFrame["textureRotated"] = spriteFrame.rotated;

        cocosFrames[key] = cocosFrame;
    }

    plist["frames"] = cocosFrames;

    return {
        data: plist,
        format: "plist"
    };
}
```


Or maybe even `url_for(:back)` instead of `departments_url`? Then you'll be able to use the `edit_department` link in multiple places, and still get the desired behaviour.


The project files should have .java extension, are you compiling and testing the files before sending them?


this is a bit of a mystery, we should not need it, but it makes things more stable. It’s something I want look into later :tm: because `.catch(reply)` should be enough


should the event.prevetDefault() come before the return? otherwise is never reached.


Ok, so here you're using back-link. :+1:


Например вот: http://tajmarket.ru/files/www/getvideo.php?videoid=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3D0AqnCSdkjQ0&type=Download


This should be mirror?


I like this change. But we need to be sure that all uses of widget now take into account the null option.
For instance, in Canvas.cs we have several `widget.Whatever` without null checks.


`link_to …, :back` ?


You are using this variable without initializing, that will result in NullPointerException (NPE)


Ahahah nice ! Parfait exemple de l'utilisation des classes ! :) J'ai hate de bosser dessus :)


that one was a bit tricky, I tried explain what happens in the comments


This commit has broken the kernel build. Build script looks for hwtest.sh at  chip-hwtest


This can be written as !ENV(mirror_param).to_s.empty?


`source ./etc/deploy.sh` can do without exec permission


This is not formatted properly.


Thank you very much in handy :+1:  ) will only write the information on triangles


OK, I'll fix it....


Could we change the signature of this to `(String surveyId, String recipient, Map<string, string> templateFields)`. It seems XStream can serialise a Map nicely <http://stackoverflow.com/questions/19775238/xstream-with-hashmapstring-string>.


I should've missed something. Where are you using this partial?


i hope this doesn't break anything. but i think we have to change the `0` to `'0'`


That's why I said that it makes sense. As the STL object by bq was already not centered the offset of 6 in negative x direction is after the 180° rotation on the other side. Swapping +/- here should be absolutely correct.
I just didn't know that there is a setting to define the offsets :wink:


In body it requests rendering of `:new`, not `:edit`


@lsj4401 그러게 ㅋㅋㅋㅋㅋ 천잰데? ㅋㅋ 아무짝에 쓸모없는 거였네 ㅋㅋㅋ 속도가 빨라졌다 ㅋㅋ


This solves the issue but isn't performing to reverse an array just to get the last ones.
If you know how many items are in the array, and you can access directly by index using .get() method, there is no need to reverse it


Indeed I read it in the other way round. But agreed 2.3.4 and I need to fix in develop/2.4 branch


With uneven, you probably meant odd.


Maybe it's time to extract those invalid params steps into a shared spec step?
You seem to be repeating them over and over again


:bomb:


I didn't have any colours in mind that would work.


 Некоторые видео не даёт скачивать, вот здесь можно качать: http://video.gegas.ru/movies/97318
а нельзя некоторые ссылки стянуть с savefrom?
http://ru.savefrom.net/savefrom.php

sf_url:https://www.youtube.com/watch?v=0AqnCSdkjQ0
sf_submit:
new:1


This file can be removed given that you have the `*.DS_Store` entry in the root folder https://github.com/rubenvp8510/hawkular-command-gateway/commit/8e1cbb951971f4334cee461d31fcf85eb791278e#diff-a084b794bc0759e7a6b77810e01874f2R32


@PocketKiller
```php
Fatal error: Cannot use pocketmine\nbt\tag\Float as Float because 'Float' is a special class name in /home/travis/build/ImagicalMine/ImagicalMine/src/pocketmine/Server.php on line 117
```


Referenced the wrong issue. Should be #45 instead of #46


Remove this README unless you fix it to be true.


This line will never work.
Please compile and test the exercises before sending them, then I'll continue reviewing them.


Line 44,46: printf() --> sprintf()


Again, this should read const std::string& GetLogoUrl() const;


If you run the latest RStudio Preview (v0.99.865) then the HTML preview for `github_document` should be hooked up. You can download it here:

https://www.rstudio.com/products/rstudio/download/preview/

I've also got some documentation for the format posted here:

http://rmarkdown.rstudio.com/github_document_format.html

@hilaryparker Let us know if there is anything else we should be thinking about here to better support the GitHub .md publishing workflow.


Getting to this bugfix took so long (ok, couple hours tops)... it's amazing how hard I shot myself in the foot when I introduced the bug :-)


Remove this file


@luiges90  读取那里是短整型，数据库是整型，但ID本身是int。我把读取那里short改为int,数据库改为long，程序就跳出了


Fixed with a C++ idiom in #5481

Sorry for breaking you guys, it compiled in our internal pipeline.


MyISAM isn't crash safe, transaction aware, and uses a different set of memory buffers than InnoDB.

Additionally, MariaDB's clustering solution requires InnoDB and not MyISAM.


ah, ok - even more "// comment" required then.


@luiges90  是/否的内容是事件效果怎么破？


Is this license-maven-plugin config really necessary?


ok


Thanks. I think this is correct.


Yeah I agree, I'm happy to just remove the `bool stat = ` part. After all, every programmer knows not to test for errors they can't handle... :wink:


直接改就不再向下兼容了.......


You need one more `artifactItem` for cmdgw war


什麼錯誤？


Nice!


Fixes #2


Uploaded!


Appliquer les paramètres


I do not think we need this management user for the echo test. The whole `maven-antrun-plugin` can probably be removed.


再增加兩個欄位，一個是玩家選是的時候使用的EventEffect，另一個是玩家選否時


事到如今，逐個類型也試一下吧 :sweat:


The function need to set both (title and color) or nothing. If you return in the if (color) { } block then things will be inconsistent. It would be better to add another pointer for the new color and set all at the end of the function when you're sure all is OK.
```
    free(tb->title);
    free(tb->title_color);
    tb->title = p;
    tb->title_color = pc;
    tb->title_pos = position;
    return 0;
}
```


好吧==


OK


Maybe I'm missing something obvious, but why not "Max"?


`hawkular-command-gateway-war` is enough, `hawkular-command-gateway-api` can be removed.


You're right, that is probably better.
Having the true filter order available was the motivation in the first
place.
I think that outweights the inconvenience of manual correction.

On 01/22/2016 10:19 AM, Hagen Wierstorf wrote:
>
> Another possibility would be to add an |iseven()| test directly to
> |wfs_fir_prefilter()| and raise an error if it is not even.
> Or do you prefer not to raise an error and simply correct the wrong
> filter length as it is done at the moment?
> I'm not sure what is the better option. Normally we raise errors in
> SFS if the input is not correct, on the other hand it might be
> convenient to correct such a small error automatically.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sfstoolbox/sfs/commit/5eb9c4fd130e97f47bde4ec3f01c27e0363a1425#commitcomment-15607993>.
>


why we need to fill the rest of the line by " "? (due to background colors?)


Wrong comment button :-) The android app is not always intuitive. Why not just "Max"?


Why not use NPP and change all Compound (needs regex maybe) to CompoundTag? And the others? Takes 5 minutes maybe

> Am 22.01.2016 um 12:31 schrieb DRedDog <notifications@github.com>:
>
> @PocketKiller
>
> Fatal error: Cannot use pocketmine\nbt\tag\Float as Float because 'Float' is a special class name in /home/travis/build/ImagicalMine/ImagicalMine/src/pocketmine/Server.php on line 117
> —
> Reply to this email directly or view it on GitHub.
>


Mmm, i think that it is correct. In Mac Os X, it reports me a path different from the root folder with the project.xml or application.xml, so it doesn't enter here never:

https://github.com/ianharrigan/haxeui/blob/224dd03aeaf87470db516a1242cd425bb2354ad1/haxe/ui/toolkit/core/Macros.hx#L757

Because of that, i made the change.

In Windows, the "c" var doesn't change, because the candidate is valid. With your change, it resolves me with an absolute path in Windows, and Mac Os X will be a wrong candidate.


Upgrade https://github.com/ci-tron/ci-tron/blob/master/back/composer.json#L20 ?


@bertfrees FYI: I've pushed [this branch](https://github.com/snaekobbi/pipeline-mod-braille/tree/more-options) with some boilerplate for the new options. It should be safe to merge already if we want to but it doesn't do anything yet. The options are grouped the same way as in the google doc. Datatypes are not used here yet.


? in the param or do you complain about a involuntary return?


Thanks!


Thanks, that helped me a lot!


ah... I see the title wrap now. Makes sense.


Don't *worry* ;-)


Dodając zdjęcia w tle czy inne obrazki, zawsze dołączaj link z danego folderu w którym znajdują się pliku ze stroną (o ile zdjęcia nie pochodzą z netu) Np. w katalogu ze stroną tworzysz katalog "img" i w nim plik zdjecie1.jpg. Wtedy link do takiego zdjęcia to "img/zdjecie1.jpg". Dzięki temu każdy po odpaleniu strony widzi foty, a teraz widzisz je tylko Ty ze swojego kompa :)


To me Minnowboard Turbot is compatible with Minnowboard Max is I see 'Max' more as a type of boards which includes Turbot & circuit co Ax boards. I don't want to call it just 'minnowboard' because then it's confusing as to whether we support the old minnowboard....

@warthog9 what do you think?


I agree, thanks.


Without that change i couldnt compile my application, i was using "application.xml" rather than "project.xml", but i also dont really understand the logic of the code, ie, if the file *doesnt* exist then resolve the path, so it will probably always throw an error if it cant fine the first candidate (which was the case for me)


Why is this a slot and not just a public setter function?


I prefer a briefer notation, also in other parts of PR #101, also with setting the `verbosity` variable below.

```python
execute_signal = 'execute_command' if p_verbosity else 'execute_command_silent'
```


Please use issue number (#542) in a request header.


как-то `clear` ни о чем не говорит. Может `applyGrep_`?


`out` seems to only be declared for the unsigned functions, not for the signed ones.  You could simply use `array_data` everywhere.


Do not hesitate to force a clean history, warn people on consequences and advise good practices for the future.


или `filter_`?


Note to self: split into PEF, BRF and HTML preview.


Thanks! I'll merge soon.


it's been re-enabled in a subsequent PR


Why not just `except TypeError:`?


This is why having 8 very similar functions eventually turns into maintenance hell...


Nice Job. Contiue pls i need a calculatorrrr.


Here should be called pEventDispatcher instead of EventDispatcherImpl::instance()


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26269/testReport/) for this commit**