At this point you should be able to use the `child_process` module to launch the ISE:

```javascript
process = require('child_process');
var filePath = convertUriToPath(editor.document.uri);
process.exec("powershell_ise.exe " + filePath);
```
Documentation on that module is here: https://nodejs.org/api/all.html#errors_error_propagation_and_interception

The code I just wrote may need a little work since I'm not sure if you can call `exec` without a callback parameter.  You may also need to check the paramaters that you send to the ISE, and potentially even find an absolute path to the powershell_ise.exe if calling it by name isn't enough.

Lastly, you'll need to implement the `convertUriToPath` method I referred to.  VS Code stores file paths in URI format: `file://c/dev/myproject/Script.ps1`. You'll need to convert that to a Windows path format: `c:\dev\myproject\Script.ps1`.  I looked for a built-in API for doing this but couldn't find one.  Doing the conversion should be fairly simple, you'd just need to replace `/` with `\` and translate the first part of the path into the drive prefix.

Happy to answer any further questions about this!


tools:text


@etpinard more robust - and I think easier to understand too.


提交第一个测试hello world


good code!


I was not aware that Go mutexes are non-recursive/reentrant. This recommendation now makes sense.


Второй атрибут на новую строку


Много переносов. Я бы вообще их все поубирал


Now I think that this is probably important for encoding as well, which would make this a great candidate for all read calls.


The `generic` thing was just a placeholder, we could change both DISTRO & FORMAT to `debian` like it's done for arch, or net set thsi variable at all and assumes that the derivative remain close-enough.


사용한 라이브러리들의 라이센스 표시 정리


If that map is also used as a set for servers I would love to make a `serverSet` type. Something like this

```go
type serverSet map[string]struct{}

func (s *serverSet) Add(server string) {
  s[server] = struct{}
}

func (s *serverSet) Del(server string) {
  delete(s, server)
}

func (s *serverSet) Has(server string) bool {
  _, has = s[server]
  return has
}
```

This makes it immediately clear what we are storing and why. It can then be used with `make(serverSet)` I believe.


Wenn es nichts zurück gibt, sollte man lieber eine `if` Abfrage so gestalten das sie vom negativen Teil ausgeht und etwas sinnvolles zurück gibt, wenn nicht das läfut sie durch ohne etwas zu liefern. Finde ich persönlich keine schöne Implementierung.


addressed


Нерелевантные атрибуты


Подозрительный цвет


Hi @andela-jejezie! It may be better to write your comments on the latest version of the file https://github.com/andela-ftchirou/checkpoint-four/blob/master/app/src/main/java/andela/checkpoint/stilld/MainActivity.java.

While an activity is one single thing that the user can do, for the user to be able to do that thing, an activity has do a lot of other things (e.g. make HTTP requests, connect to a database, launch services, ...). In this case, the MainActivity purpose is to track the user's movements. For this purpose, the activity connects to the Google API, launches some services and registers some broadcast receivers. These functionalities are small enough to be implemented as independent methods in the activity. If I were to implement a separate class per functionality, I will end up with multiple classes that have MainActivity as dependency. MainActivity would then become a God class (http://sahandsaba.com/nine-anti-patterns-every-programmer-should-be-aware-of-with-examples.html#god-class).

I do agree that the name MainActivity is not very explicit. I just like naming the main activity of my apps MainActivity :)


>  "cross-compile"

but that goes a bit against the idea of *for local use only* , but some Fedora user may want to generate a .deb for RaspBian for it's Raspberry sitting in the same room, so well OK :-)


```fsharp
let get() = reqCh *<+->- fun replyCh nack -> (nack, replyCh)
```

Equivalent and a little bit faster.


fantastic :tada:


Last Fix I'm working on (everything is operational, I need to fix the program to accept user strings instead of numbers within the list)


you probably used the basic << operator which is kinda crap. If you want real binary writing, then use this:
```cpp
std::ofstream ofs ("test.txt", std::ofstream::out);
double myValue = 0.5;
ofs.write(reinterpret_cast<char*>(&myValue), sizeof(myValue));
ofs.close()
```


wow nice 🤖


Nope. I tried once a while back and had trouble with it building reliably. I just use `mvn package -DskipTests=true`, which is aliased to `mp` in my shell.


@mikedld See discussion on PR #1, which introduced this change. I haven't tested on the old OS X versions in years, so beyond that detail I couldn't tell you.


Awesome work, thanks for documenting this. Saved me a good bit of time I would assume!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10819](https://teamcity.mesosphere.io/viewLog.html?buildId=100832&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:06


Тут можно повыносить стили у многих вьюшек


@gr4yscale, glad to hear!


All fine Ste :)


nice, realizing the selector specificity `textarea[name="blocks"]` should be enough for us to only render the form where necessary since only the Post + PageType models have that field

Guess we'll see


if you put a console log in this method you will see what i'm talking about... go to the management dashbaord, put a log at the top of the "shouldUpdate" method and click the campaign drop down... on my machine at least will see that this code is executed 100 + times.  your machine might behave differently because you probably have more ram thhan i do.


@antialias where are you using this package? Scagnelli is running into some admin v2 install issue when he does a clean install.


seems like you already have a solid image


"working on it"


Would be so great to have this on android. @PhilippKrone are your colleagues already working on it or could you need some contribution support?


处理中文乱码


also wenn das hier eine tabelle sein soll, dann sollte wie im sql üblich die folgenden spalten nicht eingerückt sein....


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10820](https://teamcity.mesosphere.io/viewLog.html?buildId=100833&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:09:53


Nicely done.


> gtk_label_set_xalign() aligns the text inside the widget, while gtk_widget_set_halign() aligns the GtkLabel widget as a whole.
> Someone wrote a program to indicate this difference. So just use old API when we don't have 3.16.

Ok, i didn't know that, but what indicates to use gtk_label_set_xalign() or gtk_widget_set_halign() ?
I ask because i mostly use gtk_widget_set_halign() in other packages to fix the deprecation.

Can you please rebase the PR to correct  line 322/323 in clock-location-tile.c ?


Typo error here

-  <project path="prebuilts/clang/linux-x86/x86/3.3" name="platform/prebuilts/clang/linux-x86/x86/3.3" groups="linux,pdk-cw-fs,x86" rclone-depth="1" emote="aosp" />
+  <project path="prebuilts/clang/linux-x86/x86/3.3" name="platform/prebuilts/clang/linux-x86/x86/3.3" groups="linux,pdk-cw-fs,x86" clone-depth="1" remote="aosp" />


you can just remove me, I'm already following all clients :)


It's updated here : https://forge.puppetlabs.com/dalenys/snoopy.

We're sorry for the delay.

Thanks for your support.


Ira Greenberg Examples from workshops


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10821](https://teamcity.mesosphere.io/viewLog.html?buildId=100834&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:04:04


:beer:


Exactly, I'm working with the [YunoHost](https://yunohost.org) project, and I really like to have a one-click flarum application ;)
Next steps: LDAP and basic_http auth


Submitted to trunk, can't accept the pull request from github. This repository is only a mirror of the svn repository.


Много переносов


Ok, commited, I hope it's ok


We could use `if (_.isEmpty(this.tags))` instead.

Pro tip: skim through the underscore docs if you haven't already: http://underscorejs.org/. I'll often start implementing some verbose or awkward logic, only to find that it's a one-liner with the right underscore helpers.


Напрашивается стиль


any reason for not using `Plots.traceIs` here?


tt?


@aismail : can you please take care of documenting it?
Thanks


The check should be replaced by `and delta_it` in fact to avoid DivisionByZero exception in some edge cases.


без «это»


«Легковесный» с маленькой буквы


> cross-compile

I also knew it would mean an extra burden to manage with smaller gains, I wouldn't had gone that way if you weren't interrested.


@JustAkan 네 감사합니다. 확인해보겠습니다.


@xiang90 Added ```f(s.store.Get(...))``` for success case to avoid additional ```updateAttr``` via ```f(s.store.Set(...))``` at the end of ```default``` case. Please give me feedback, Thanks!


wenn es geht bitte die neue hash syntax nutzen und nur bei string interpolation "" verwenden, ansonsten immer ''


I completely agree with this one. `Lookup` is being called for every incoming request during forwarding.


111101900_MSHeatPump (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1465 of 1465 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.62%25-green.svg)


> What was wrong with all those liveries?

Personally, I did not delete those liveries. The No. 969d6f0 commit is
named "delete some files" because I accidentally forget to do the "git
rm" when I merged from the SVN. It means that SVN "gatekeepers" deleted
them. They may have their own concern, but I don't know why.

It may has licensing concern, or it may caused by the changing of UV
unwrapping since the external model has been modified by someone else.

I have no suggestion to liveries' issues, leave it to all of you to
decide.

Bo


indentation.


works as expected....thanks a lot for the fast changes. :+1:


I've been using `*` to delimit attribute values e.g. [here](https://github.com/plotly/plotly.js/blob/master/src/traces/bar/attributes.js#L29) and ` to delimit attribute names e.g. [here](https://github.com/plotly/plotly.js/blob/master/src/traces/box/index.js#L18).

My bad for not documenting this.


This is where I messed up. The reaction dict now only contains strings as keys, hence, `library` is a string.
As a consequence,
`isinstance(library, KineticsLibrary)` will always return `False` regardless of whether it was really a library.

I am looking for ways to figure out if a string is either a `KineticsFamily` or a `KineticsLibrary`.


sprich wenn der key wie hier ein symbol ist dann:

```
%a{href: 'https://blablub.com'}
```


Great!
Thanks


Closes #83


Love the metrics based approach to see if it moves the needle or not. Would love it even more if we had updated documentation for these metrics :P


This should probably use `tts.getDefaultLanguage()` instead of a fixed locale.  Then it would "Just Work."


@jakubpawlowicz: https://github.com/jakubpawlowicz/clean-css/compare/master...XhmikosR:master

Do you want me to make a PR or can you cherry pick these 2 patches?


@tafia Perhaps `#[inline]` or `#[inline(always)]` improves the benchmarks in imageproc?


Does `FilterPanel` need to know about widgets, the widget container, or the `TagList`? I see that we're storing some things on `this` that aren't used anywhere else, which makes me wonder if these steps could happen outside the `FilterPanel` class entirely--maybe in `candidates.js`, `committees.js`, etc.

#loosecoupling


Finde ich eigentlich so übersichtlicher, weil du nicht zwei Verschachtelungen hast und vielleicht noch eine Fehlermeldung angezeigt werden soll, falls keine Daten angekommen sind. Aber ist Geschmackssache.


any advice？

can I make a pr?

非常感谢！（当前模块已应用于微博平台）


Nicely done :balloon:


I am not sure what am I looking at, is it the tag you were using with the goto and you forgot to remove it?


@renecannao okay. Will create issues from now on to document these without pinging you anymore. Thx!


Разве нужна запятая?


can you use `mockery` instead of making your own dummy here?


There is already a task to fix naming convention, but I need to try to not break compatibility between binaries in minor version.
Would be ok to change the name of global variables between minor releases as rarely you need to change global variables.
Although, a change in table structure in admin tables I think it would requires a major version change.
Changes in statistics tables are ok in minor version releases.


Ported to #842 https://github.com/bkil-syslogng/syslog-ng/commit/7f0bbea3f105e269db2209dcf3a5819496921329


I checked and can confirm. No need for "commit()" instruction.


@xyyx No alarm Wake locks on MM
ive tested this


This is no1dead's commit


do we have a category for the scatter type only? I guess we could make one, and eventually this logic could apply to scatter3d and polar scatter too... but maybe make that change when it would serve such a purpose, rather than trying to predict it now?


It's currently required as templates get wrapper in a master template that
needs the title before it reads the content requested. It's ugly, but it's
been ugly, so I figure we can address it later. As for defaulting to
control, we could do that for now but it requires an extra conditional for
isset() and I figured your whitelisting philosophy matched the current
implementation

On Wed, Jan 6, 2016 at 7:58 AM, Roy R. <notifications@github.com> wrote:

> Page titles in the router?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BitLucid/ninjawars/commit/8cb03ebf28a39b357854acdd5c8edaf0bb631adb#commitcomment-15287268>
> .
>


:muscle:


Yes, it does apply only to English of Bebas Neue Light, this is noted in PR description.


@angeldm it actually looks like it's in both default and production modes?
http://devdocs.magento.com/guides/v2.0/config-guide/cli/config-cli-subcommands-static-view.html

So it looks like I can merge this in as everything is set to `default` as default (hah). Can you fix the typo in "Deploying" message? Then I'll merge it in.


Thank you, Jeff!


Alternate not that better naming : `--google-register-host` or `--google-register-existing` or `--google-register-on`


It'd be good to remove the duplicated `PlaceKind` here


Could the update value be customizable in the Slider node ?
100ms is very slow for the type of things we do (control audio volumes, opacity of video layers etc.) Also it's pretty easy to throttle the data afterwards in node-red using the delay node if needed.

Thanks !


Why is there a bare # in the input code? This is in both the header and implementation strings.


I'm -1 on this.
This did cause issues with 5.0 and 5.1, and unless the author explicitly claims that he has a fix, this risk is not worth it.
Plus, these stuffs are NOT user-friendly at all, picking up wake-up sources one by one. Even I don't need stuffs like this.
(No disrespect to the original author.)


ok. https://github.com/plotly/plotly.js/commit/bc04a15528d56b45929c3cda883a2feca36197fc


This should be replaced by `from pombola.core.models import ParliamentarySession, Person` I think


Why?


> do we have a category for the scatter type only?

No, we don't. My mistake.

> but maybe make that change when it would serve such a purpose

Sounds good. :+1:


can you publish this change to npm?


Similarly, I think you might as well take out the duplicate `PlaceKind` here


fixed ~


`views.index` is from tutorial 1.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1129](http://teamcity.monogame.net/viewLog.html?buildId=13391&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:38:09


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1130](http://teamcity.monogame.net/viewLog.html?buildId=13395&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


thanks!


I not sure about your interpretation of the pep-8
I m not a python coder but what I read about this pep-8 to understand your commit is that all line must ended by \n but the last one, which is , so, empty.


이제 주석 달때 왠만하면 영어로 달아보자. 짧아도 괜찮음.


Maybe split up the repo, either on GH or on jsDelivr?

> On Jan 6, 2016, at 5:34 AM, Jonathan Hornung <notifications@github.com> wrote:
>
> Hello Tom,
>
> I want to host minifed and unminified files
> You are right, I will remove mainfile
> thanks for your advices. What should I do now?
>
> Best,
> Jonathan
>
> —
> Reply to this email directly or view it on GitHub.
>


Interesting, I had in my head to pass the file name in a message to the C# and execute ise in the service. Lots of ways to skin the cat.


The Micasense camera uses ardupilotmega for their API. They assume that the timestamp is absolute time. You're saying that that behavior is in fact incorrect? To reliably get the absolute time they should then be using the `SYSTEM_TIME` message instead?


You're welcome to submit a pull request to make the test cases more diverse.


I think this should be replaced with `from pombola.core.models import Contact, ContactKind`


![screen shot 2016-01-06 at 10 26 56 am](https://cloud.githubusercontent.com/assets/742384/12146141/0dbce1f8-b460-11e5-99ed-510a7c44e350.png)


@matt-riemer, I added 'note' attribute to orders as you had asked in one of PRs on another project.


Very minor style thing, but the following tests have a great deal of redundancy. Would it make sense to pull out a shared function?


if forum_settings.ATTACHMENT_SUPPORT and self.cleaned_data['attachment']:


I think it's because they merged my PR yesterday. I pointed back at their master branch (they haven't published my change to npm yet). The issue should go away for him after running npm run cleaninstall.


Doing it in the language service could work as well but it complicates the effort involved. I suppose there's a  benefit to having a general launch action that all editors could share, but it may not be appropriate in all use cases.

Up to Jan, really. If he wants to dive in to the C# code he should feel free :)


369 additions, 369 deletions not shown ?
Are there some space at the end/line end issues too so it changed whole thing?


Thank you! This fixed all the account creation related errors I mentioned at https://github.com/PrestaShop/PrestaShop/pull/4503


he ran into the issue when he ran the clean install. It seems that it's still pointing to this branch somewhere.


Awesome, thanks, was just about to send a PR for this.


Would you care to share your relevant microbenchmark results and/or disassembly, and the overall impact on system performance?


I *just* updated Bunsen. He should try again.

On Wednesday, January 6, 2016, dale tan <notifications@github.com> wrote:

> he ran into the issue when he ran the clean install. It seems that it's
> still pointing to this branch somewhere.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/antialias/backbone-model/commit/944ac00e0387dbf9f3b0242ccb171fa49d327e52#commitcomment-15292736>
> .
>


@SirUrban maybe older versions of gitlab-ci-runner supported running as a diff user.  However, the current instructions tell you to use sudo and that is the only way I have ever run it.

The latest version of the approved module, just added Debian only support for the runner:
https://forge.puppetlabs.com/vshn/gitlab
I'd consider that if you don't need RedHat.  I will be looking into that soon and possibly add RedHat support.


Hardly dangerous, but it can indeed never evaluate to true for a length one String.


I only did so to show that one without mail perms doesn't have that mod permission (more so visual consistency with how currently if the user is not a mod its not distinguished).


How about stripping whitespace in the sql import script instead? Then we'd only have to apply the logic once, instead of every time we serialize a date--and we wouldn't need to think about `summary` vs. `summary_raw`, etc.


ok. i'll let him know


Hmm!! Counting on it. keep it up.


I guess this fits better in your `$GIT_DIR/info/exclude`, since that file is not generated by some ide specifically on your box.


The reason should be the one configured in the server.properties.
$this->server->getBooleanConfig or so


Agreed, these tests happens a lot!


Maybe remove the double space while you're changing this line anyway


z.dev.iq.gen.data.AppSystem file is missing.
I am even not sure why you added it.


It would be really awesome to have some kind of a short description what was the idea behind this code :)! Just for people like me, who are interested in understanding origin of successful project without having to actually read the code, because - I truly believe - that in the code we can find like only "the 12.5%" of the primary idea, which in the end appears to be successful.


Why not make `Plugins/` a submodule?


Comment commits example


If the time stamp is smaller than 2009 it should be regarded as boot time. Very simple. If they do t do that, then they screwed up and should have used system time.


I don't have an immediate answer to this. Would you please open an issue and we can track our findings there?


This fixes download errors with mangas that has a siteid ending in '1'


Removing this duplicate import at the same time would make sense, I think


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 182](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=625&buildTypeId=XbimEssentials_XbimEssentials) is now running


Yes, next PR sounds good.


Label used for the Dymo API.


There aren't that many aliases in `make-webpack-config.js`. `@scss`, `@operator`, and `@pointerevents` are the ones I'm seeing in .com.

I suppose a possible solution would be to add a config to the plugin rule that is an array of regexes that if any match a given file name the plugin ignores checking said file. That being said, is that adding to much complexity?

We could also eslint disable these aliased requires if there aren't that many instances of them.


Duplicate import that can be removed


What would that give us? Save people having to worry about multiple repos?


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 182](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=625&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:29


Timetable)


with https://github.com/kcwu/tqdm/blob/6130309588b2b7d5d642d6b0ef9694cd6a0b95e3/tqdm/_tqdm.py#L451
```
line 451    n += 1
line 452    delta_it = n - last_print_n
```
`delta_it` will not be zero.


@alexcjohnson potential problem with log axes:

![image](https://cloud.githubusercontent.com/assets/6675409/12146407/77c222c4-b461-11e5-8c77-90196057320a.png)

looks like the range in the event data isn't converted


It's a Harry Potter reference. Neville always forgets things. It's not the
official name, just needed to put something down.
On Jan 6, 2016 6:36 AM, "dothework" <notifications@github.com> wrote:

> @maelee <https://github.com/maelee> DWMR. What, or who, is Neville?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/maelee/Parse-Todo/commit/cdbafeced087798ef7f557c97bb9e0823cfe4b8a#commitcomment-15290381>
> .
>


Привет, это Тимофей. Запятая нужна.


similarly for date axes:

![image](https://cloud.githubusercontent.com/assets/6675409/12146448/af80b482-b461-11e5-8c75-b7e3cc96fe1c.png)


Maybe we should make the API doc using something like http://springfox.github.io/springfox/docs/snapshot/ to maintain it at the Java code level instead ? Any experiences with such tools ?


배포 라이센스는 MIT License하의 배포되며 그외 저희가 사용한 라이브러리는 NOTICE.txt를 참조하시면 됩니다.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 118](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=626&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


This is a good example for when the feature to create "macros" comes online?


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 118](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=626&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:17


I will fix this by tonight.  Thanks.

From: JJ Allaire <notifications@github.com>
Reply: rstudio/rticles <reply@reply.github.com>
Date: January 4, 2016 at 1:20:12 PM
To: rstudio/rticles <rticles@noreply.github.com>
Subject:  Re: [rticles] remove tufte_ebook (not passing tests on windows) (b5a41d0)

@justsomeone1001 We are preparing to submit rticles to CRAN and in advance of that have written a test suite to ensure that the various formats work on all platforms. We got errors testing tufte_ebook on Windows. So that we can submit to CRAN the tufte_ebook format has been removed from the package by this commit. However, we are more than happy to take it back in as a PR once you've remedied the failing test.

Note that you can arrange to test your format by adding it to this source file: https://github.com/rstudio/rticles/blob/master/tests/testthat/test_formats.R

—
Reply to this email directly or view it on GitHub.


wäre doch eh besser, die link_to-Funktion zu nutzen. Müsste dann so in etwa aussehen:

= link_to "Repository", "https://github.com/00Bock/RubyCars"

http://apidock.com/rails/ActionView/Helpers/UrlHelper/link_to


Oops!


@manishearth does this seem on the right track?


Onde está a classe Mensagem? Só encontrei Mensageiro.


I think tuples are good enough?!

    (0, 0) <= (1, 0) <= (1, 1)

Very readable in my opinion and what we're doing right now.


they could be prefixed with proxy. was feeling a bit torn - didn't want to
introduce additional flags that semantically duplicated flags that already
exist in the system. so instead I reused.

agree - we need to address the config issue soon. these flags are a
nightmare.

On Wed, Jan 6, 2016 at 2:09 AM, Dr. Stefan Schimanski <
notifications@github.com> wrote:

> shouldn't these be prefixed with proxy?
>
> This duplication of parameters is really a mess. Would like to have that
> fixed somehow (config objects?) sooner than later.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mesosphere/kubernetes/commit/f93bc3d0b9b8435b1f6b9ab2734faf4c50562abe#commitcomment-15282434>
> .
>


Fixes #1133


does this fix need further testing, than I did with my scenario?


Agreed, then cve_string can handle the internals


Hi, can you give an example of this? Kind Regards, Tord


did not knew this before, thx


Das magische Rails hat auch einen Helper für Email-Links:

http://apidock.com/rails/ActionView/Helpers/UrlHelper/mail_to

also:
```mail_to "dashboard@innoz.de"```


Can this be consistent array construction please


Fixes #1151


It's fine with me to keep those as it is a mess already and this doesn't make a difference. So lgtm.


Yeah, that would probably be a better fit for this.  Maybe it's better to keep the launch behavior client-side in VS Code for now until we better understand the other possible use cases for it


Aye, squireling it away into one place where we can decide the implementation seems the best thing. My main thought on using openssl is that it has far less ABI issues than say, gnutls, or nettle


Makes sense yea


ALARM! bitte single quotes ;-)


Looks great! Thank you for taking time to go through all of this and updating
Kind Regards, Tord


If I am on a branch, can I publish to a different distribution? We may need a way to publish debs that correspond to branches, so that we can build appliances that install debs from branches.


Ja wo es geht natürlich die leckeren Rails helper nutzen und wie unten bitte auch hier single quotes, wenn das dann noch läuft.


Excellent! I missed this from the 1.7.10 release.

Does this add back in right click with a wooden axe to set pos1/2?


Can you imagine a case where `mSenFac` should not equal 1 ? We're talking about the thermal mass of a solid here.


so cool, you are using github


@justinlevi Is this still a commit you want to merge? I know we were discussing that 1000 is too high for global nav..


Why is a clear for lockRenewID needed here? If the are inside the callback, the the timer as already been fired, and therefore clearing it would be redundant, or I am missing something else ? :)


What was the original intention? Seems like we're putting a lot of effort
into this (as you noted Lilly), what are we getting from it?

--
Tim Whidden | VP, Engineering
1stdibs
(e) tim@1stdibs.com
(p) 212.627.3927 (ext. 178)
<http://www.1stdibs.com/?utm_source=sig&utm_medium=email&utm_campaign=sig>
<https://twitter.com/1stdibs>  <https://www.facebook.com/1stdibs>
<http://www.pinterest.com/1stdibs/>  <http://instagram.com/1stdibs>

On Wed, Jan 6, 2016 at 10:36 AM, Liliana <notifications@github.com> wrote:

> There aren't that many aliases in make-webpack-config.js. @scss, @operator,
> and @pointerevents are the ones I'm seeing in .com.
>
> I suppose a possible solution would be to add a config to the plugin rule
> that is an array of regexes that if any match a given file name the plugin
> ignores checking said file. That being said, is that adding to much
> complexity?
>
> We could also eslint disable these aliased requires if there aren't that
> many instances of them.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/1stdibs/eslint-config-1stdibs/commit/cd7923768266510270804199b31e7d9f147d89e7#commitcomment-15292895>
> .
>


You prefer to have a single state for a multi-layer window ?


This file can just be empty (and removed once we upgrade to Django 1.7)


Hmm, in order to support the full range of binding structures in tactic scripts, we'll need to reorganize things a bit in the surface-language. Here's an example of something that doesn't work under the current code:

```
a, b <- tac1;
[ tac2 a , tac3 b ];
tac4 a
```

The symbol `a` is not actually bound in the call to `tac4 a`.

What we need to do, I think, is add a little bit of asymmetry between the surface language and the LCF API, such that we have a *single* sequencing / binding form, `a,... <- t1; t2`, and things like `[t1, t2, t3]` are nodes all on their own (as opposed to being part of a second sequencing form like in `THENL`).

Then, we'll properly handle elaboration to things like `THENL` and `THENF` in the compiler.


I am not tested this branch yet (only tested with previous preload branch), but this line should be like below

LKL_HIJACK_NET_TAP=lkl_ptt0 LKL_HIJACK_NET_IP=192.168.13.2 LKL_HIJACK_NET_NETMASK_LEN=24 ${hijack_script} ./ping **192.168.13.1** -i 0.2 -c 65

current destination address goes to localhost, which host side tap interface (lkl_ptt0) is not involved at all.

if I changed the destination IP address of ping to 192.168.13.1, the packet is able to transmit but cannot receive ARP reply packet (from a glance of tcpdump output at host side).


That would probably help :)

Done!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10822](https://teamcity.mesosphere.io/viewLog.html?buildId=100838&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:08:22


hier fehlt das Inputfeld `<input type="text" className="search-query form-control" placeholder="13;234-343 or 589-767 or FOXP2" ref="inputSearch" />`! Wohl beim Autoeinrücken gelöscht worden ;)


This should be:

```http.cors.enabled: true```


thsi is great change!
how about adding  same approach for luyten version as a x.y value?


Random feedback: I just tried your IRQ-code on the Raspi and it works great - it nicely unburdens that one CPU core that was churning through the while(1)-loop in the non-IRQ example. Cheers!


should be probably get_param instead of get_resource, otherwise LGTM


close() - close focused window
quite() - kill driver instance


Lets say i have 5 mock objects that are required to test a method in different cases. Then should i declare and initialize (as local variables)all the mock for each case (which is lot of redundant code)?
Or is it okay to declare them as instance variables and initialize in @Before(setUp()).


if the decompress flag is not set, we can exit here


As before, I'd just make this file empty.


aaaaaaa


Unhandled Failure


Thank you for my Reyes gift!


Schema should be updated as well: https://github.com/interledger/five-bells-shared/blob/master/schemas/Account.json#L19


@matheusagcosta  vou converter! melhor mesmo :) sobre a indentação já configurei aqui o editor vamos ver se agora dá certo. thankks


whitespace changes make it very difficult to see what has actually changed


OK


Part of #1238.


This needs to use `os.path.isabs()` for portability. Consider Windows.

However this magic is undocumented. That will need to be fixed too.


I think you should fix the spaces here at the same time


No, do not use instance variables.  It is redundant code and part of the
reason to make Facil.  Instance variables/Before are ok but harder to
manage as you don't always want the same mocks for each test (i.e., you may
not mock a variable in one test but in another you do)

On Wed, Jan 6, 2016 at 10:51 AM, Sumanth Varma <notifications@github.com>
wrote:

> Lets say i have 5 mock objects that are required to test a method in
> different cases. Then should i declare and initialize (as local
> variables)all the mock for each case (which is lot of redundant code)?
> Or is it okay to declare them as instance variables and initialize in
> @Before <https://github.com/Before>(setUp()).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/svd260/practice-tests/commit/624ec5cad9771d43c80cfe9d0b924501f3593e53#commitcomment-15293290>
> .
>


> the outline clears at the beginning of a zoom/pan, and the selection point effects clear at the end of a zoom/pan, when the points redraw. Changing dragmode in itself does nothing.

feels like the correct behavior for now.


These should be clearer about being interpreted relative to `$prefix`.


In that case, perhaps I should move the call to galileo_pinmux_initialize back to each example that requires it instead of always calling it in contiki-main.c?  I originally moved it because I thought it was a prerequisite for quarkX1000_gpio_init.


actually ProductDistribution::computeCDF was added by the previous commit


@pelikhan This makes us always takes #master version of nRF51822 and BLE_API. Either @finneyj needs to use specific versions (which would tie version of these modules to a particular version of microbit-dal) or we need to have explicit versions here. Right now, changes to BLE_API and nRF* will quietly slip into our builds.


Admin


closes #86


Unneeded, I think, the file should just be empty.


Heh, just in time for when I was going to find out what these things were about, thanks.


Should push the unstable code/feauture to `dev` branch


Nope - Seems like we're leaning toward a drupal configuration option or documentation so this can be closed and ignored.


Thanks for taking a look. I haven't tested this on any hardware yet, so it's still a bit of wait-and-see on my end (and why I closed the PR shortly after opening it; once its tested on our end, will reopen). The hardware is mostly in another office, but I'll bug someone here to help me get set up with some.

Writing zeros makes sense to me. Calls to `setZeros()` were replaced by `fillBuffer(0)` internally and an optional `writeData()` to send the data immediately. You can also use `stopLoop()` and `startLoop()` to avoid sending new data. Again, untested, so we'll see how well that works in practice.

As far as the data size, the [DMX pro api guide](https://www.enttec.com/docs/dmx_usb_pro_api_spec.pdf) suggests that the packet data size can be between 25 and 513 bytes, which is why I changed to calculating the header values from the data vector (it is ambiguous about whether we are supposed to send the start code, that initial zero). It may be constant in practice, though, and changing that out would be trivial.

For performance concerns, it probably is a bit faster to have a single `writeBytes()` call and store a constant header. I could see storing everything in the vector and buffer the data inline with a memcpy. Even given a potential small change in performance, running on a secondary thread that mostly sleeps should result in this performance change being negligible. That said, you now have me curious to go back to packing everything in a single buffer (but updating using buffering methods rather than a channel at a time).


Minerva Panda


@niklasravnsborg Nice, das schaut super aus, da hast du ja ganz schön aufgeräumt :D Das hat mich auf die Idee gebracht, das man dann auch aus den anderen Funktionen bestimmt den update-Parameter rausbekommt.


This should either be left as `Exception` for PHP 5.x or remove the type hint completely for compatibility with both 5.x and 7. Most examples have been targeting 5.x.


Création du projet Moteur, avec juste le fichier "README.md" au départ


Thanks for the hint @keilw! Mine is a CI job, so I simply skipped RevAPI.


You forgot to remove your debug lines.


so as I understand it, this does nothing in the back end, correct? only has to do with html5 client side validation?


miss take No. #4.
closing #9.


When implemented is better to add this to the end so that it doesn't break older protocol versions.


there are a few ways to enable this, let's talk about it after standup


this is an extra comments.


Why doesn't the `m.first_message` stuff (https://github.com/13steinj/reddit/blob/6820b72f0f41a41aff41042679b64e6a5b9dae96/r2/r2/models/link.py#L2032-L2050) cover this case?


ugh :disappointed:


it seems ProductDistribution::computeProbability is only declared


:+1:

This can be merged to master and tagged as v0.7.1.


which package is this change being used in? this is coming up in his build:

> (node) child_process: options.customFds option is deprecated. Use options.stdio instead.
 CXX(target) Release/obj.target/contextify/src/contextify.o
 SOLINK_MODULE(target) Release/contextify.node
 SOLINK_MODULE(target) Release/contextify.node: Finished
npm ERR! fetch failed https://github.com/green-mesa/backbone-model#master


Somehow I need to get these values changes for the camera's speed based on the scale data from the sphereColliders.  Probably calculated based on the current speed state.  We should be able to do this, and not have to worry about the camera's speed changing back and forth each frame as we're testing for both OnTriggerEnter and OnTriggerExit for each distance collider.


Is this suppose to fix a In-Call StatusBar bug? Cause I have one on this version.


Will do.


As of DAL 1.4.2 it appears that using explicit versions there is the way it is going:
https://github.com/lancaster-university/microbit-dal/blob/v1.4.2/module.json


What's the current version of bunsen?  The version of package.json in v2 is ^12.0.1.


Since you are referring `this` within the scope of an event listener `this` actually is the mongoose connection instead of the exported db object.


111101900_MSHeatPump (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (2001 of 2001 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Apply this modifier without the MS override and a different model:

https://github.com/MNoya/DotaCraft/blob/master/game/dota_addons/dotacraft/scripts/vscripts/libraries/modifiers/modifier_hex.lua#L1-L26

It's better than the hide-wearables method. It might not update the portrait properly though.

The other option is replacing all lycan model paths with invisible textures vmats, similar to this one:

https://github.com/MNoya/DotaCraft/blob/master/content/dota_addons/dotacraft/materials/models/heroes/chaos_knight/empty_body.vmat


> I *just* updated Bunsen. He should try again.

ooh it's in bunsen. whoops


Oh, sorry. I only looked at #master in DAL. Everything is OK then.


I only checked your scenario 1. Can you try out 2.a and 2.b ?


root@ubuntu:~/SilVeR-BoT/tg/tgl# make
make: Nothing to be done for `all'.
????????????????


How did you attach an LSM9DS0 to the board?


The whole phrase is bold (**dir=rtl to the html or body**) because we want to stress on the property and the elements it applies to. Should we leave it as is or remove the bold?


It looks like a mess during the rebase of the branch. I fix it ASAP.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1131](http://teamcity.monogame.net/viewLog.html?buildId=13399&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1130](http://teamcity.monogame.net/viewLog.html?buildId=13395&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:39:16


I think here you want to call pdf_document_format and pass your CSL style file. Something like this:

```r
pdf_document_format(...,
                                    keep_tex = keep_tex,
                                    md_extensions = md_extensions,
                                    format = "acs_article",
                                    template = "template.tex",
                                    csl = "american-chemical-society.csl")
```


The flag is created but never used.


#50  numarali is ile iliskili.


this looks like Korean, isn't it in the wrong directory? shouldn't it be intl/ko/messages.json?


@drod4 DWMR. Good good. Lean into it!


@FGRibreau just out of curiosity why did you decide to switch to when by default? more lightweight or otherwise?


Can this be released? It'll help to resolve the issue https://github.com/PolymerElements/paper-dropdown-menu/issues/31#issuecomment-169078473


I also like the liveries. I suggest to restore the liveries back up. If everyone agrees, I can do that.


this shouldn't have been merged... I'm working on another PR for this change


Good call.


Yeah, it seems weird to me Float are not using their native binary representation, I thought it was portable.
Anyway, MRI also uses dtoa is seems, which goes to some expensive double-to-base10string conversion, which String.format also uses, so that's good to reuse, but while using it we might as well take advantage of its formatting abilities :smile:


Once you pass the CSL file to pdf_document_format as described above you can remove the csl file from your skeleton


yeah, its a copy of intl/ko/messages.json


This assertion is hit on ZK (try to place a shieldbot factory with the com, also sometimes when units fire).


@pekohl DWMR. Happy New Year. Hope it's the best ever! Ship code!


hello

u can help me integrate payu in yii2

i do composer all , but who initial interface!

thanks


> How did you attach an LSM9DS0 to the board?

I used a breadboard and some wires to connect them.


Maybe the tools is leaving intl/MSG.json as a side-effect instead of cleaning it up, and you added by mistake?


If such a simple check is so effective, why don't you recommend an upstream patch for them? Until they merge such a check, shouldn't we carry such a patched function separately, something like slng_g_string_append_unichar()?

Also, I generally don't like to accumulate such micro-optimizations sprinkled over the place. Especially in cases when the overall system impact would be really low (if not negative). Dijkstra said in different words, that premature optimization is the root of all evil. I prefer to optimize clearly and/or with fallback and to start with the real bottlenecks.

In my opinion, gathering all such dirty tweaks to a single header might be acceptable. It highlights that you need to revisit your tweaks regularly, because newer library version might eventually fix the issue that you were working around originally. It's a bit like a TODO file.


These images aren't accurate.  The underline color is actually red, not orange as shown in these screenshots.


sorry


they do work too!


自定义ScrollView


Yes. In this example it is without any function, but in general this prevents the submission being blocked by unsatisfied client-side constraints.


@yihui If the bibliography is included in this fashion do we need a non-default `citation-package` argument to `pdf_document`?


Note:  There's also a [platform config](https://getcomposer.org/doc/06-config.md#platform) that may be useful.


If we want the initialization of I2C and GPIO to always be performed during platform boot, I think it's better to initialize pinmux to its default configuration as well. In the worst case we'll just need to change the pin we're using for this example.


I'd say italicAngle is the only sensible other thing to add here.  xHeight and capHeight are very ill-defined for anything other than Latin/Greek/Cyrillic.  xAvgCharWidth is even more ill-defined.  What's the correct number for it for a CJK font that includes Latin as well?

We can add the other values in a hb_font_metrics_t opaque structure later, or just add functions for them instead of public structs, since this went into a release already...


Aha. Understood. I wasn't aware of the `org.junit.runner.Description.fUniqueId` field.

You're right: it's unfortunate that there is no getter method for that property, but it may make sense to access it via reflection. I'll leave the decision up to you. ;)


As before, I think this file should just be empty until Django 1.7


don't use wildcard imports.


@izuzak :grin: :cake:


Yes, multiple states would result in too small time constants.


>Add validation for uploading files not greater than 500 Kb.

Strictly speaking you've added image size validation.


@mojavelinux nice, love it :+1:


If you'd want to artificially increase the thermal time constant of the windows. :)


yes - thank you!


I'm unsure too, but my pep-8 compliant pycharm was yelling at me to add a
blank line when I made the other fix, so I thought I'd do both at the same
time.

On Wed, Jan 6, 2016 at 4:24 PM, Pascal GOUHIER <notifications@github.com>
wrote:

> I not sure about your interpretation of the pep-8
> I m not a python coder but what I read about this pep-8 to understand your
> commit is that all line must ended by \n but the last one, which is , so,
> empty.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nicolas-petit/clouder/commit/e88f12c807d9985e23ee04f91c7fb9df934541ed#commitcomment-15292641>
> .
>


111101900_MSHeatPump (Nigusse) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


neat :+1:


Thanks guys!


Actually I have many hardcore ideas for optimization in this case if this is indeed a bottleneck, but which comes from another direction.


Maybe those last few could do with a bit more explanation (e.g. the subtitle of each blog)?


An update. @yihui  is breaking the `tufte_handout` format out of the **rmarkdown** package and into a new **tufte** package. This will also include a new `tufte_html` format and some functions to make it easy to have a single Rmd target rendering in both PDF and HTML form. I think that's the package which we should include `tufte_ebook` in so let's target the PR there.

@yihui Once that repo is up and running let us know and then @elbamos can take a look at what you've and ensure that the `tufte_ebook` format works well with your formats and functions.


`settings` can be removed


What makes matters worse: It's not a `String` but `Serializable` so we would have to do some `instanceof` where it's easy to convert it into a `String` (`CharSequence`? `Number`?) and serialize it into a string (base-64 encoded?) as a fallback... :-/


change to downgrade java version


On second thought, your example is indeed fewer calls since it would only do the .test when the result is a zero. I'll update to use that.


But now it will result in a wrong glass surface temperature, which might be crucial for comfort assessment in zones with large window areas (such as offices). What do you think, @GlennReynders ?


This should probably be refactored - hiding and showing content with display:none, and running data through redux is not best practice. Likely can be accomplished with props/internal state/ a ternary and breaking renderables out into a function


don't think this is ever used


Yes, that's a good point. I'll update that.


Yes, we do, because the default is to use `pandoc-citeproc` to parse and process bibliographies, which does not understand `\bibliography{}` here.

@yufree I think this line `\bibliography{acstest}` can be removed since you have already got `bibliography: acstest.bib` in the YAML metadata. If you want to use bibtex to process the citations, you need to specify the citation package in YAML, e.g.

```yaml
output:
  rticles::acs_article:
    citation_package: natbib
```


Meam, inline, optimizeaza fata


@rikkbhat it needs some additional changes you can review here --
https://github.com/PolymerElements/paper-input/pull/303


Should be 'our server has a problem' :)


New gulp task to run e2e tests


Show de bola. Qualquer dúvida estamos aí :rocket:


CHEATER!

Really though, I think this will be super helpful :heart:


It's now up-to-date with tag 'LA.BF.1.1.1-04310-8x74.0'


removed unused injections


>It means that SVN "gatekeepers" deleted
them. They may have their own concern, but I don't know why.

No. It is not a license issue. these liveries are also in the Database, which means they are GPLed. The problem really is when people forget they are expected to work constructively, not destructively.
I guess what was going on in the mind of the commiter, is that having the liveries in the aircraft installed is redundant if the "user" can "just" download them from the database, at need.

Having the livery installed is convenient, and safe (many liveries in the database don't work out of the box, and others even break the code, as it happened to this same aircraft once we installed them from there: particularly non-ascii characters get the nasal code of the livery running amok). so by us installing these we guarantee the full code compatibility to all users as well (not only savy ones)

in terms of space, a few images may weight some bytes, but nothing to crazy as far as I can tell.

My vote is to restore the Models/Liveries directories (regardless of SVN status). That would be a best way for us.

I can do that easily, but I'll await for your opinions @bolan, @jan-hudec


I’m curious why this was done.
I have nothing against it whatsoever, just curious to hear the reason.


I think we should add a bit of logging here.


@adamhadani way better code :)


should be xvjf not b


REASONS and PROVINCES aren't used


in my zeal to clean things up,  I must have zapped that line,  I will commit a fix and make sure the integration test runs.


REASONS and data_path aren't used


refactor userRepos is not a function anymore but an resource object.


总算把这些方法都抽出来放在不同的module了，之前看的头都大了 还不知道哪是哪


removed workaround as it was fixed by the library in the last version


`data_path` and `REASONS` aren't used


You should add: If setting is missing then use a default setting. If a setting is removed, you should ignore the setting if removed (make a console warning).
Now auto builds (phar)  don't work anymore.


I'd use a heredoc for this:

```ruby
instructions = <<-EOF
Welcome to…
EOF
```


so gefährlich sind die auch nicht, dass das CAPLOCKS rechtfertigen würde :P


This if/else may be unecessary. We may just assume that the `wanted_metric_configurations` always is a `MetricConfiguration` Array.


@varund7726, i tested it too. I had alarm loops.


removed unused injections


- switch-theme**.rb** script
- I'd add something like "take a look at the documentation in the script/switch-theme.rb file for more information"


Mmmmm.... it's getting uglier by the second. Might be best to just leave it _as is_ for the time being.


Good start! Removing script nodes, however, is just the beginning. XSS code can also be in node attributes like `onclick`, `onmouseover`, `href="javascript:`, etc. or even in CSS `url()` as we learned with HTML messages.

So traversing the entire DOM is probably necessary to provide protection that goes beyond the one example we received.


New gulp task to run e2e tests


The usage of start & end sort of implies that this line segment is directional (eg; starts at self._start and moves to self._end), whereas this is not the case. Might want to consider renaming this somewhat.


Just commit too many files and the commit comment is not correct.

On this commit:
 - Simplified MatrixMultiply() function
 - Reviewed matrices on rlglDrawModel()
 - Re-implemented GetMouseRay() function... but still does not work.. :(


@robrez Thanks!


@jonsterling Hah, yeah that email got me thinking that I should write about this one. Next I'll have to see if I can work through the proof that you can take fixed points of locally contractive functors in CBUlt :)


I'd use a heredoc for this:

```ruby
modt = <<-EOF
To start your alaveteli instance:
* cd alaveteli
* bundle exec rails server
EOF
```


Done in aa65184c7bc3ec2101c5ebd2c315baa03c9d2281


Added comment.


`adn` typo


@antialias did you push a new version of bunsen with this fix?


PHP is faster with numerically ordered arrays.


Make a config error trapping.
If setting is missing, add to pocketmine.yml with defaults (ofcourse user defineable like update-config: <false/true>).
That makes future errors trapped :)


Typo'd conversion here


Ya

> On Jan 6, 2016, at 11:26, Andrew Scagnelli <notifications@github.com> wrote:
>
> @antialias did you push a new version of bunsen with this fix?
>
> —
> Reply to this email directly or view it on GitHub.
>


Wrong place


Nice! :zap: 141 additions, 2,715 deletions :zap:


Task <bool> is meaningless replace to Task.
(you never return false so it's the same )


Hi @YuriyYevsyukov,

It's nice to see that other people are using the library.
I did a short review it's looking good.
Please add tests for the public methods you've added.

Also, I've noticed that there a bug in my lock code that you've copied, you might want to fix that in your methods:

`SemaphoreSlim.WaitAsync` get a timeout parameter and returns `Task<bool>`, so if you get a timeout it can enter the critical code on multiple threads.

I think this should be the fix:
```C#
   if (!await locker.WaitAsync(timeout).ConfigureAwait(false))
     {
         throw ;
     }
      try
     {
       your code
     }
  finally
    {
        locker.Release();
    }
```


I was able to validate that is correct and will make the corresponding change. Thanks! :+1:


Hm?


@AbigailBuccaneer Gee, thanks.
You're a bit late to the party, though.


added error handling for promise rejection.


This class name is confusing because it is a verb.    This is a test fixture, so name it something like CompileStringTest.
Also, missing a blurb for the class. What is it, generally?


if you don't install v0.12.7 here, you'll get this message: `N/A: version "v0.12.7" is not yet installed` when you try to run the next command


y


Fixed


We prefer a using declaration instead:

using CompileStringWithOptions = CompileString;


Nice catch with the backticks behaviour.

Kudos @danielkza @marcheing


ty


Thanks @chaosphere2112 Fixed now.


Sorry for the long reply.
Now I'm sure that it's better to add close() method, than rely on the BaseChannel::closed() signal, because it would be right to emit the signal after interfaces close.
I'm going to change the commit message, feel free to force push rebased branch after that.
I made AbstractChannelInterface changes a bit differently and it's up to you to verify that this commit ("File transfer: Handle aborts by local side") would be related only to BaseChannelFileTransferType::close() implementation.


better to say "expects compilation success" rather than asserts.  That's because you use the EXPECT_TRUE instead of ASSERT_TRUE.


Let me check


On that matter why stick it in a try/except ? if it fails it will exit with non zero status no?


書きかけの「列挙子の末尾へのカンマ付加を許可」をコミットに含めてしまいました。いまはこれのせいでリンク切れしていますが、今日中くらいに書きます。


"expects compilation failure"


We need a test to catch this.


I'm planning to merge it to master eventually, tagging at least enough to help users be able to reproduce results from a particular paper.


"expects compilation success"


there is a RoutingTable#shardRoutingTable shortcut, and IndexShardRoutingTable is iterable


See if it's OK now.
@manpreet9112 @amrit3701 Pull the changes.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10823](https://teamcity.mesosphere.io/viewLog.html?buildId=100862&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:02:45


@ANierbeck, here's the thing. If I run "mvn clean install" on my local computer, even before my changes are introduced, the integration tests still fail. As far as I can tell, the tests has external dependencies. To be more precise, I believe the tests depend on the presence of certain external databases which are not running on my local computer. For example, locally, I can see the tests are failing to connect to my mysql database because the user it is trying to log in with does not exist.

In summary, running "mvn clean install" is not sufficient for these tests to run successfully, there are dependencies on the presence of external databases and even those require proper configuration. Which is why I'm seeking some information on how to properly setup my environment to replicate the CI environment.

FWIW I have a theory about why the tests are failing. They are loading jdbc-config in containers which don't have jasypt. Here's some evidence for this theory:

```
 Unresolved constraint in bundle org.ops4j.pax.jdbc.config [40]: Unable to resolve 40.0: missing requirement [40.0] osgi.wiring.package; (osgi.wiring.package=org.jasypt.encryption)
```

I also have some ideas on how to fix this I just want to be sure to test them before I merge another set of changes. It would be great if there was a way to run the integration tests on pull requests like in the pax-web project.


This comment seems awkward here.  First, you're talking about client uses of this object, instead of the intrinsic properties of this object.    This extra information would be known if the whole class had a good blurb.


== false or simon would scream :)  also check that if it is local we don't send? in which case we don't have to skip the primary


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1131](http://teamcity.monogame.net/viewLog.html?buildId=13399&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:31:37


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1132](http://teamcity.monogame.net/viewLog.html?buildId=13403&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@elbamos Perhaps I missed the story from the beginning, but I'm wondering where the tufte-ebook class came from. It does not seem to be a package on CTAN. The tufte-latex project only provides two classes `tufte-handout` and `tufte-book`: https://github.com/Tufte-LaTeX/tufte-latex


awesome! if you path that up I can merge. also it would be best to inject and use `$window` for better test mocking


Ok.


@david-martin whoops - think you checked this into all templates on the 4.x branch


You should always endeavour to use symbols as your hash keys since strings tend to consume more memory. Furthermore you can use the ruby 2.0 and above hash syntax.
`{ name: @name, level: @level }`


FYI, the Vehicle interface already extends Entity.


Could have used #error here I think.  But coder's choice.


pulled


I believe it will just stop and crash and would not continue. Also, having it wrapped under try catch allows me to have a custom message rather than a python multiple line error message which I find distracting and hard to read.


(Updating the version of vON shipped in Wiremod has come up in wiremod/wire#923.)


Follow https://github.com/syl20bnr/spacemacs/pull/4458


If it's shell script file, it should start from `#!/bin/sh`


How would it be if I added one more test to examples/galileo that configures and tests I2C callbacks like the LSM9DS0 test, but uses them to do a simple read/write test of communication to the onboard GPIO controller?  Would that be a suitable alternative to running the LSM9DS0 test?

Also, I'd like to elaborate on why these changes are necessitated by my memory management patches.  The memory management patches require protection domains to setup all of their allowable system calls early in the system's boot process, before the application processes have started.

I expect that a large proportion of apps targeting this platform will use GPIO.  The Ethernet device is also always initialized even though it may not be used by as many apps.  However, an alternative option for only selectively initializing GPIO would be to add a new build flag controlling an #ifdef,  The build flag could be set as needed in per-example makefiles.


The timer manager does not clear timers automatically. It only class the
callback. Thus the timer manager array is always full and the queue cannot
idle. This prevents the queue from closing.Try my test case without the
changes to queue. It fails.

An alternate solution is to have the timer manager automatically remove
timedout timers. However we would have to ensure calling clear on an
expired timer doesn't fail.

Another alternative would be to have the timer manager clear and then set a
new timer if the key is duplicated. I think this is what the original
author of processJob intended. However the current implementation sets a
new uuid for each call to set and does not clear the timed out timer.

I can implement any solution but I wanted to discuss the changes before I
made them.
On Jan 6, 2016 3:46 PM, "Manuel Astudillo" <notifications@github.com> wrote:

> Why is a clear for lockRenewID needed here? If the are inside the
> callback, the the timer as already been fired, and therefore clearing it
> would be redundant, or I am missing something else ? :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ryan-sandy/bull/commit/51d34c9cbb08b5ca7ff760448693e5183ea7a0e2#commitcomment-15293181>
> .
>


111101900_MSHeatPump (Nigusse) - x86_64-MacOS-10.9-clang: OK (1995 of 1995 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


We leave temporary file if this error occurs.


Ergh, I thought I changed this. I'll fix the alignment with the next push.


The text is worse, because it doesn't say why a dictionary is expected, or even *that* a dictionary is expected.

If the error with fix-it is better than the error plus note with fix-it, why aren't we using it in the other case? Do we think that fix-it is less likely to be correct? (That would be a good reason. I just want to know what the guidelines are.)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10824](https://teamcity.mesosphere.io/viewLog.html?buildId=100864&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:08:12


There is no point creating the variable choice. you can just return `gets.chomp.downcase`


Actually i do this in all of my plugins.

> Am 06.01.2016 um 17:27 schrieb Danny Terweij <notifications@github.com>:
>
> Make a config error trapping.
> If setting is missing, add to pocketmine.yml with defaults (ofcourse user defineable like update-config: ).
> That makes future errors trapped :)
>
> —
> Reply to this email directly or view it on GitHub.
>


Okay, i will.

> Am 06.01.2016 um 17:27 schrieb Danny Terweij <notifications@github.com>:
>
> Make a config error trapping.
> If setting is missing, add to pocketmine.yml with defaults (ofcourse user defineable like update-config: ).
> That makes future errors trapped :)
>
> —
> Reply to this email directly or view it on GitHub.
>


Merged Branch


@dgeb good job!  Let's sync up in the amserializers slack?


Thanks for cutting a release with my fix so quickly!


@antialias I pushed 12.2.3 to use the package instead of the path to the repo (my devbox was choking on the https for some reason)


As far I understand we can't run this script because it doesn't have executable bit (because for files we set 0666 permissions). So, we should make it executable or run as `sh /tmp/rm-secrets`. I like the 2nd option.


The default for one parameter should be the buffer, not a single character. A single character can be represented by a buffer of length 1.


Seems like it's necessary if you're a contributor who is going to make any changes to the app's models. After initially cloning the repo and running `python example/manage.py migrate`, I was still lacking a calaccess_raw/migrations dir with a 0001_initial.py file that creates all calaccess_raw's models. Also none of the calaccess_raw data tables were getting created (maybe this is happening somewhere in downloadcalaccessrawdata?). So when I ran `python example/manage.py makemigrations calaccess_raw` after making this model change, it added commands for creating all of the models' tables. But since they were already there, I was getting an error.

Do we expect that running migrate after initially cloning the repo should recognize calaccess_raw in INSTALLED_APPS and create it's models? Maybe this is related to some of those changes in more recent versions of Django we were dealing with yesterday.


I see your point. No problem.


Това име може да направи конфликт с `import json`, ако се появи.


111101900_MSHeatPump (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (927 of 927 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.13%25-green.svg)


Do we want to do our own thing or use the framework provided stuff? (http://developer.android.com/guide/topics/ui/settings.html)


The author of this commit was John Pimentel


What is the 10000 good for?


Dump useless code.


The default should be the non-ambiguous constructor. Although the name is the easiest constructor it can fail, and the constructor using the `DeviceInformation` cannot.


The method may be renamed to reflect its true result now: namespaced class name

Again we missed tests that check this feature.


Soon the rest of the SDL and Qt hotkeys will be configurable too. This is just the basic framework for that. Now, however, Turbo works in Qt (although Qt is slow because of the way it draws, it needs OpenGL).


I like this change.


aaaa i see.. ty


Why this change? creating BigInteger and then computing 2^32-1 is likely slower than the previous solution.


Just built multi thread version in OS X EI Captian version 10.11.2 and it worked with clang-omp. I guess it is working.


@AbigailBuccaneer I mean about versioning.
I had no awareness of any (or just proper) versioning standards prior to 2015.


old .war(!), update in next version


@Darvame hi,next time you want to back port a patch please just use git cherry-pick ;)


@yihui I was trying to get tufte-book to work with rmarkdown.  (Well actually I was trying to do things with tufte-handout that the class didn't support, and it turned out to be easier to modify tufte-book than tufte-handout.)

Tufte-book out of the box didn't look very good as a pdf - there were things like extra blank pages, symmetric margins, etc., that would look great printed as a paper book but didn't look right as a pdf.  I generalized the class a bit to make those things optional.  I also put things in, like additional levels of TOC, numbered TOC, etc., that other rmarkdown templates support and the rmarkdown help files describe as standard, but weren't supported by the tufte-book class.

I think (its been quite a while) there were also a few font-related and other things that didn't want to work properly in rmarkdown.  I think I ended-up finding fixes for all of them.

Basically, I adapted tufte-book to rmarkdown in particular for use in producing files for digital distribution.  I didn't want to just call it 'tufte-book' because it wasn't the same class anymore.  And I didn't want to make a PR to whoever maintains tufte-book, since it looks like they haven't updated the class in years and I don't have any involvement in TeX beyond work on this.


I have submitted patches to different projects. In many cases, developers preferred to use int. I would use the default boolean type used in the project. What's the default bool type? Are you already including stdbool.h?


Does the "this->transpose()" operation make a copy of the data?  It seems that this may be a significant speed penalty and also a memory penalty.

I think that a temporary matrix is being created (using essentially the same double nested for loop in the transpose operation) simply to have the correct memory layout, and then copied.  It is probably better to use the double nested for loop directly here.


`if status[0] && !status[1]` or if you prefer to be explicit here `status[0] == true && status[1] == false`


Same comment as above: I think that a temporary matrix is being created (using essentially the same double nested for loop in the transpose operation) simply to have the correct memory layout, and then copied.  It is probably better to use the double nested for loop directly here.


@ncannasse
I added `run_raw`, which is the no argument-escape version of `run`. Is that ok? Or should I change `run` to be `string -> string array option -> process`?


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 119](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=627&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


Cool. Yea just thought it made more sense. Not everything will be a string and map[string]interface{} felt clunky whereas context means alternative implementations can actually leverage that, whether they want cancellation or just storing things in that idiomatic method.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 119](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=627&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:20


Please refactor the Player class to use instance method as against class methods. This is because class methods should only be used if the method returns the result as against the result be returned in a different method.


Change to userName


![photo_2015-10-28_22-00-28 -](https://cloud.githubusercontent.com/assets/15527459/12148379/2065ea76-b4af-11e5-96e6-fb20e3f4fb73.jpg)


@rawanhamdi this line cause a bug, this global variable `limit` will be overridden by latest client who call an Api


10000 is somewhat of an arbitrary value (which in a later commit gets replaced by a configurable value). To detect that a rollover has occurred, we need to distinguish between stanza's that have a higher-than-h value which are simply not yet acknowledged, or that have been acknowledged by the rolled-over h.


@rawanhamdi why should i wait to log to be written before returned to user?


Added


line 17 of Startup.cs should be  .SetBasePath(appEnv.ApplicationBasePath)


Done


Can you remember why we don't just do this in DEV *and* PROD? I know we copy it to `common/conf/assets`, but if we can read it from `static/hash`, won't that suffice?


> How would it be if I added one more test to examples/galileo that configures and tests I2C callbacks like the LSM9DS0 test, but uses them to do a simple read/write test of communication to the onboard GPIO controller? Would that be a suitable alternative to running the LSM9DS0 test?

Sounds good to me :+1:

>Also, I'd like to elaborate on why these changes are necessitated by my memory management patches. The memory management patches require protection domains to setup all of their allowable system calls early in the system's boot process, before the application processes have started.

> I expect that a large proportion of apps targeting this platform will use GPIO. The Ethernet device is also always initialized even though it may not be used by as many apps. However, an alternative option for only selectively initializing GPIO would be to add a new build flag controlling an #ifdef, The build flag could be set as needed in per-example makefiles.

Thanks for clarifying this, the way the patch does looks good to me (:


this assignment took us quite a while. we worked on it all of lab. we finally got the filters functioning properly and called all of the functions we had working. the next steps are adding the css components and finishing the nav bar functionality. that was where we left things.


Yeah I second this ++. Typo in Readme


To be honest: I don't know. I simply could no get it to work with 0xFFFFFFFF - any operation evaluated to a negative value (overflow, even though it is a long?)

The BigInt solution worked fine (and is somewhat easier on the eyes). As for performance: it's a static, evaluated just once.


having fun?


oops, backward function composition :scream:
https://github.com/plotly/plotly.js/commit/710791d3ad38edc0888da527fd1551f57d79924f
thanks for checking!


When requiring files, you should try as much as possible to order the require statements in alphabetical order. This helps with code readability and easy location of required files.


I saw the fillBuffer function, but I also would keep setZeros() or even better blackout(). regarding the writeData I would never call it manually, the usb dmx pro can't run faster than 35-40fps so my gut feeling says there is a chance the function will fail or get ignored, same when you shutdown the thread.

about the protocol I can't remember it on top of my head, but for the sake of simplicity I would always keep the same header and packet size, it should not affect the performances.


The correct syntax is ``) {`` :)


Alles klar. Kannst du das einmal noch testen und dann mergen?


делаю тнтран на кб. регион /rg info tntrun


Changed to match EOL setting used across all code


_when_ the container goes out of scope.


This doesn't look like it defers the read connection (connects every time) - is that intended?


this looks like it now needs a `go fmt`?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10825](https://teamcity.mesosphere.io/viewLog.html?buildId=100871&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:30


Can you send me an email?  I'd like to take this discussion off github, so
I can introduce you to the person who actually suggested pyNastran use
pandas.  He also showed me some examples of pandas and sent me an example
file that I can also attach.  I implemented the objects based off my (poor)
understanding of that.

On Wed, Jan 6, 2016 at 3:29 AM, Buran1988 <notifications@github.com> wrote:

> It seems that you've already implemented pandas dataframes for nearly all
> op2 objects.
> However, I'd rather to print out data in 'normalized' formatting as below:
> [image: pic1]
> <https://cloud.githubusercontent.com/assets/9808176/12141352/b4e95064-b47f-11e5-970a-bd3f4253c78b.PNG>
>
> This formatting has some advantages:
>
>    - Ease of further data analysis: filtering/sorting by specific
>    component (i.e. max von Misses stress)
>    - Ease of introducing auxiliary calculation columns (i.e force
>    magnitude based on specific components, average stress, reserve factor etc.)
>    - Accordance with .f06 representation
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SteveDoyle2/pyNastran/commit/c7e023cabb7a9f2555bc5b112af83aaa97040de0#commitcomment-15285662>
> .
>


This is a non-functional patch, right?
I'm pretty sure you can just measure the slowdown with a few runs of bench and submit the pull request.


Thanks for catching that...


@legoboyvdlp @D-LASER
This branch was created by cherry-picking legos commits, without the one that added the P3000 unnecessary files.
I suggest we force push this as the master branch, and clone again. That way, effectively the files get cleaned out of the repository

Let me know.

(@lego. if we do this, you will need to also fork again. or your fork will keep pushing us those files back)


hi @davidjimdo I am seeing the same error in https://stephenlb.github.io/webrtc-sdk/. Are you also seeing it there?


I would mention here what would be necessary to remove this (and use unique_ptr): (a) we stop using NuttX or (b) we make std <memory> works with NuttX. (or whatever)


You do not need to define different modules for different classes in this application. You could use `MastermindSname` as the module name for all the classes in the application.


Wenn das erst heut Abend, hab jetzt grad keine Zeit.


Due to a warning I fixed [this assignment in %t-struct.c](https://github.com/metaeducation/ren-c/commit/d13bc8ee658d18bc797bce1054b9b9c283c51123).

I've brought up the question of for what purpose or goal we are prohibiting it recently:

> How essential is the declarations-before-initializations thing. I think it makes the code worse enough and is not relevant enough to keep doing?

earl said:

> I have no relevant compiler survey handy, so I cannot provide an answer to "how essential" this is.  While I'm personally very fond of being able to use relaxed declaration placement rules when helpful, it's not something I'd quickly give up C89 compatibility for.  I still value the C89 backwards compatibility, in general. As mentioned above, I'd need some more data on how this would be impacted.

It is a tough thing to consider.  If the codebase hadn't been like that to begin with, I wouldn't have suggested trying to do it...but now that it's done, having the warning switched on and maintaining it is *not that difficult*... just annoying.

The one thing I *have* thought is that having a mixture is likely bad...that it should be completely separate declarations and initializations or none at all.  The problem being things like:

    FOO foo = Something();
    BAR bar = SomethingElse(foo);

It gets disruptive if you wind up needing to do a thing that--for instance checks foo before using it:

    FOO foo = Something();
    BAR bar;
    if (SomeCheck(foo)) return;
    bar = SomethingElse(foo);

The modification would have been easier and touched fewer lines if the declarations had been separate as a standard.

     FOO foo;
     BAR bar;
     foo = Something();
     // check can go here which is a simple insertion of one line
     bar = SomethingElse(foo);

It makes me feel that living in a world that's not entirely one or the other is the worst of all possible worlds as far as maintenance and change goes.

In a sense--I am exaggerating a bit.  It's not like it's that big a deal, considering everything else that makes programming in C a pain.  It takes only moments, can be checked with a compiler warning (`-Wdeclaration-after-statement`), and it makes the code work across compilers that existed before the precise semantics of the feature had been formalized by the committee.

Just something to think about.  If any of us have the warning on, all of us should... and if we don't, we should just decide it's okay and let the code embrace it.


try to avoid using the `T` alias for `TRUE` or `F` for `FALSE`


as already mentioned on IRC, tested it on the PI now and working as expected, with and without GPU accelerated JPG decoding (hoping that test file was actually decoded in HW)


Or just `delete leak();`? Hehe.


@hughsando Is this something I should try to get before Pakka release? I'm not sure if this affects me.


that works but could be a performance problem, it would be better to add `[^)]*` instead of `.*`


Haha hacker!! :smile:


I change the indentation.
You can now add this correction in npm?


dont know if fixed, found this in history. notice: if `SuperClass` implements an interface you are not interate it


Yes
Just want to run a sanity check at STC...the queue is empty.
Should be a speed up...removing a redundant function call.


111101900_MSHeatPump (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2033 of 2033 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Okay, I see. Thanks for the explanation! Perhaps this should be included in the documentation as well.


Pow for expensive classes can be made easier by not having to clone all the time


the plan was to use the framework provided stuff

On 06.01.2016 17:46, Christian Balster wrote:
>
> Do we want to do our own thing or use the framework provided stuff?
> (http://developer.android.com/guide/topics/ui/settings.html)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/criticalmaps/criticalmaps-android/commit/ab23537b73e45b1b9aac1965b98cd54878efec81#commitcomment-15294840>.
>


Thanks!


Q: with these set of operator==, comparison between pointer to base class and ownptr to derived class works?


@Cybermaxs  This class should be public


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1132](http://teamcity.monogame.net/viewLog.html?buildId=13403&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:33:07


PRd to xbmc/master


I think is much better to improve the timers logic instead of working around it. The timers should be removed when the fired, and mimic the internal functionality of setTimeout.


Nope
On Jan 6, 2016 11:57 AM, "martin coulon" <notifications@github.com> wrote:
>
> having fun?
>
> —
> Reply to this email directly or view it on GitHub.


Actually, see_sign should be a huge speed boost as it saves a lot of work when the first capture is bad.


Supi, ja bin gerade im Zug wenn ich Zuhause bin kann ich das auch sonst machen.


so great if you want and will do it :) :+1:


:+1:
I just saw that you didn't subclass PreferenceFragment and was wondering if this was intentional or just WIP. :)


Are you sure? Works for us on chrome/ff


One too many ')' on istype


Just delete this line.


They should.. I can't check right now


yep. thanks for the heads up though. ;)

On 06.01.2016 18:11, Christian Balster wrote:
>
> :+1:
> I just saw that you didn't subclass PreferenceFragment and was
> wondering if this was intentional or just WIP. :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/criticalmaps/criticalmaps-android/commit/ab23537b73e45b1b9aac1965b98cd54878efec81#commitcomment-15295368>.
>


I believe @dhh is referring to [JSON API Resources](https://github.com/cerebris/jsonapi-resources). correct me if I am wrong.


@jasonmadigan thanks. an oversight here.

@grahamhillis if you're updating templates (and getting failing builds) this may be why. I'll set aside some time tomorrow to fix any templates with this bad merge, unless you are in a position to easily fix this before then


grrr, wrong commit name :(


It may be worthwhile mentioning that this is not necessarily the main thread, or the thread used for registering the handle.

Since you mention thread here, it's worth mentioning when it's safe to use the other functions. ("do I need the semaphore locked to call transfer?")


@MetropoliaUAS/raspberry-pi here you can comment


This looks more like a little hack than a solution ;) I still believe it's the button element which behaves wrong (why soever, I don't know). We should simply try to substitute it with a styled link, setting the background pause/play images for this link ..

So we could leave the turnaround-container as it was without the onclick="playAudio()" action.


Missing the explanation of what this is.


sa fie mai frumix


Maybe this line could be `var target = e.target.parentNode || e.relatedNode;` or something similar and you could revert the change 5 lines down.


It may be good to leave this try/except/else here, as it lets users configure logging parameters. As you noted on IRC, there are some oddities with it and I don't know how `c.truncate_log` is communicated through to here, but configurable logging is nice.


And it would definitely be worth ;logging to see what and/or where it fails


We should preserve the semantic that we return error when the instance is not found (`if len(instances) == 0 {`)


:+1: for  PreferenceFragmentCompat http://developer.android.com/reference/android/support/v7/preference/PreferenceFragmentCompat.html

What should be in the Settings? Should we merge this before it has real use or should we wait until there are some settings in there?


This needs to be a `u"""` string in order for the help to be displayed when running `cr_import_parties_from_csv` since it contains non-US-ASCII characters. Also the way long help strings are displayed is a bit unfortunate - they're word-wrapped so appear as:

```
 ./manage.py cr_import_parties_from_csv --help
usage: manage.py [-h] [--settings SETTINGS]

optional arguments:
  -h, --help           show this help message and exit
  --settings SETTINGS
usage: manage.py cr_import_parties_from_csv [-h] [--version] [-v {0,1,2,3}]
                                            [--settings SETTINGS]
                                            [--pythonpath PYTHONPATH]
                                            [--traceback] [--no-color]
                                            [--party-set PARTY_SET]
                                            CSV-FILENAME

Create or update parties from a CSV file Takes an argument of a CSV file which
should have 3 columns: 1: Name of party 2: ID of party (optional) 3: Comma
separated list of Cantons the party is standing in The ID is the "Cédula
Jurídica" and is added as an Identifier. It expects the CSV file to have NO
header row. It will create, or update, a party for each row in the CSV and a
party set for each Canton, adding the party to the party sets for the Cantons
in which the party is standing. This generates slugs by slugifying the party
name as we don't have the above IDs for all parties.

positional arguments:
  CSV-FILENAME
```

... so it might be worth reformatting it with that in mind. (I can't see an obvious way of changing the `[formatter_class](https://docs.python.org/2/library/argparse.html#formatter-class)` used by the management command.)


Good catch! I also forgot to use /24 when adding the IP address to the tap interface, with that it works for me.


Sorry, thank you.

On Wed, 06 Jan 2016 07:25:10 -0800, Tim Graham <notifications@github.com> wrote:

> `views.index` is from tutorial 1.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/django/django/commit/3653466bdf211ca603ec976c28d4a8da566dc671#commitcomment-15292631


deleted ignore


Right now I recognize that the original version should not be considered a "bug", since it follows the contract that any input should be similar to the template input (in dimensions, type, etc.). However, it seems kind of uncomfortable to ignore the input. Probably we should make this a NullaryOp instead.


Is the assignation of `t` supposed to be just before the print?


`fix_whitespace` is used on the names of parties, I think, but this strips out any run of spaces completely instead of replacing them with a single space - I guess that's not what you intend? Maybe this should be `remove_whitespace` and have a new `fix_whitespace` that reduces whitespace to a single space?


Oh right! Yeah, I've mostly just been searching through if I have a specific need, but good idea to skim through.


There are several style guide violations here.
1) The argument list is too long and should be broken down as our code review guideline proposes.
https://github.com/andela/code-review-guidelines/blob/master/style/ruby/sample.rb#L2
2) There should be a space after `,` in the argument list.


:dancers:


`INFO` is really noisy, it's probably better to leave it on `WARNING` so users can easily see exceptions and warnings without wading through all the noise info generates.


I think this `--party-set` argument should be removed.


This is a rebase onto 0.5.1. It was based on the RC1 before


As far as I can remember ```ole32``` is required. The perl bindings are known to work well on Windows+libssh2(+openssl): https://github.com/jacquesg/p5-Git-Raw/blob/master/inc/MakeMaker.pm#L255-L270


Good call. Yeah, I suppose we could just init the `filterTags.TagList` from each page that it's used on, rather than in the filter panel, which would save us from needing to pass in the title property to the `FilterPanel`.


thanks :beers:


Does this work when the task_priority macro is mapped to a numerical field in Jira?


this is inconsistent with the default config


@cam156 I'm super into that Legacy::Cleaners pattern you wrote. That was literally exactly how I was going to do it! :+1:


Can you separate commit for each group of files?


Good enough for v1 !

We can revisit this later.


missing a godep entry for `github.com/coreos/go-oidc/jose`


@Geequlim , can you be more specific about the issue you are seeing?


I dont think ms013g has significant motion sensor


Babel says this is a duplicate declaration "items" :warning:


Still a bit confused why this need to be exposed at all (why not making a map/func from Device::Speed to 100/400 and let I2C objects use it), but I guess concrete implementations will make clearer...


This relies on a fwb commit. Otherwise, flag isn't read anywhere


Yes, tagging is a great idea. It will be nice to somehow show the configuration that they can use per paper and change the input arguments accordingly.


This line is not doing anything. Can you remove it?


P.S. On my xamblak.de page I use the turnaround as well and the links are working properly on chrome.


@yihui That's a good idea.  But also, if you're working on more general tufte classes for a new R package, I'd like to try to help out.


If size is 5, and alignment is 4, then the formula will give 5 + 1 (remainder of 5 modulo 4) -> 6 not 8...
Is it really what's intended???


Hi there

This breaks the feature introduced in e4d103 (PR #113), where `buildMenuItemWithParams:(NSDictionary *)params` might return nil if the plugin should not be shown in the dropdown.
Additionally, not displaying a menu item if there's only one line of content prevent actions (such as `refresh` or `bash`) from being attached to this line.


Starting the paragraph with 'i.e.' is horrible. Suggest replacing the . and the new paragraph with "-" here. Or better yet, "—".


fixed. thanks


This method has no definition / purpose and should be removed.


add-default-build-type (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1995 of 1995 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


There is really no point creating a method to return time. You can just store the current time as the start time.


This does not work if a cortex arm is selected :-(
I will fix it later


The new package will be here: https://github.com/rstudio/tufte I will upload what I have got at hand by the end of today or early tomorrow. Then I'll take a look at your book class, and let you know what you may help me with. Thanks!


I think this should be a `unicode`, i.e. `u"Cédula Jurídica"` (it might work without, but I bet it'd create obscure bugs in the future :))


Go uses (name type); so this should be `getInstanceByIds(instanceIDs []*string)`

Also, some style guidelines:

* Go always upper cases acronyms, so this should be getInstanceByID.  You will find lots of places where I break this rule, because I find it odd.
* In general []*string is not very go-like; the string type is a pointer to immutable character data.  The AWS SDK auto-generates a lot of code, which is why they use it.  I think it's find to leave this, but I just wanted you to be aware!


Comment not needed but nitpicking :)


I get what you are saying, but I (respectfully) disagree ;-)

While service's and factories have use-cases each is somewhat better at, I think these differences are out-weighed by the simplicity of only using one or the other in a given project.


Minor: use `struct` instead of `class`?


Yes, sure that's it: fly-tu144@ya.ru or volk@buran.fr.  06.01.2016, 20:03, "SteveDoyle2" <notifications@github.com>:Can you send me an email? I'd like to take this discussion off github, so I can introduce you to the person who actually suggested pyNastran use pandas. He also showed me some examples of pandas and sent me an example file that I can also attach. I implemented the objects based off my (poor) understanding of that.  On Wed, Jan 6, 2016 at 3:29 AM, Buran1988 <notifications@github.com> wrote:  > It seems that you've already implemented pandas dataframes for nearly all > op2 objects. > However, I'd rather to print out data in 'normalized' formatting as below: > [image: pic1] > <https://cloud.githubusercontent.com/assets/9808176/12141352/b4e95064-b47f-11e5-970a-bd3f4253c78b.PNG> > > This formatting has some advantages: > > - Ease of further data analysis: filtering/sorting by specific > component (i.e. max von Misses stress) > - Ease of introducing auxiliary calculation columns (i.e force > magnitude based on specific components, average stress, reserve factor etc.) > - Accordance with .f06 representation > > — > Reply to this email directly or view it on GitHub > <https://github.com/SteveDoyle2/pyNastran/commit/c7e023cabb7a9f2555bc5b112af83aaa97040de0#commitcomment-15285662> > . >—Reply to this email directly or view it on GitHub.


Since this is a predicate function, you can just call it quit?. Since all predicate functions returns true/false.


Is there any reason to remove this method?


Can we nest all of these inside of `.tile{`?


s/i.e./For example,/


Thanks, that'll work just fine.


> We could also eslint disable these aliased requires if there aren't that many instances of them.

There are many uses uses of these aliases,m hundreds between the big three repos. Changing them all to eslint disable line doesn't seem practical.


Double checked for validity


You aren't creating a new variable name here; so you use `:=`, you use `=`.


i published operator - https://www.npmjs.com/package/jquery-operator - so we can get rid of that alias


`cpanm` (at least) considers '0.023_01' < '0.023' and so it doesn't install the development version even when explicitly asked for it as in `requires => { 'Alien::Base' => '0.023_01' }`

IMO, it is better to use different numbers for the development and stable versions. For instance, after 0.023, use 0.024_01, 0.024_02, etc. for the devel versions, and then make the next stable one 0.025.


Ok super


> I suppose a possible solution would be to add a config to the plugin rule that is an array of regexes that if any match a given file name the plugin ignores checking said file. That being said, is that adding to much complexity?

If you can configure how the plugin validates paths, the only practical solution would be to incorporate the aliases from the current webpack config into the validity check.


An annoying thing is that calling the parameter `id` shadows the built-in [`id` function](https://docs.python.org/2/library/functions.html#id), which obviously doesn't matter in this case, but it's probably *very slightly* better style to call this `party_id` instead ;)


Oh never mind, I don't think we claim to support that in the documentation...


This is the mapping function. Users of the Device interface are supposed to call the function below.

```
dev->set_speed(Device::SPEED_LOW);
```

For I2CDevice this will choose one of the speeds above. For SPIDevice it will select the speed from the SPIDeviceDriver (to be renamed) table.


@gsmet , could you take a look at this commit, please?

This was added following [this discussion](https://github.com/openwide-java/owsi-core-parent/pull/14#discussion-diff-48875293) on the subject of adding an error handler to executors.

It was... much more complicated than expected, especially because the ThreadedProcessor simply swallowed exceptions, up until now.
So:
 * I added a hack to `TransactionWrapperCallable` in order to propagate checked exceptions
 * I made sure that the `ThreadedProcessor` collects any `ExecutionException` that arise during execution, and throws them all in a single `ExecutionException` upon termination
 * I added an option in the ThreadedProcessor (and, consequently, to the `MultithreadedBatchExecutor`) in order to abort the remaining tasks whenever an exception occurs. This is enabled by default on the `MultithreadedBatchExecutor`.

I took the occasion to enable the use of simple runnables on the `ThreadedProcessor`, because that's all we need for now. We'll have to get back to work when we'll really use it with callables (and use the result), because right now, if several tasks succeed and only one fails, no result at all will be available. But maybe that's not very important... There's no impact on the `BatchExecutors`, anyway.


Looks good. r=crafuse


Ok, I see now that you pulled the early exit into see itself.
I'm still seeing a slow down.

i5-4590 CPU @ 3.30GHz with profile build bmi2.

for i in {1..5}; do ./v1 bench 2>&1 | grep To; done
Total time (ms) : 3467
Total time (ms) : 3449
Total time (ms) : 3511
Total time (ms) : 3501
Total time (ms) : 3484

for i in {1..5}; do ./base bench 2>&1 | grep To; done
Total time (ms) : 3320
Total time (ms) : 3313
Total time (ms) : 3301
Total time (ms) : 3330
Total time (ms) : 3333


I believe this is only allowed if the variables are of the same type https://golang.org/ref/spec#Variable_declarations  So I think you need to split this onto two lines