TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13075](https://teamcity.mesosphere.io/viewLog.html?buildId=114678&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:08:45


currently I think this is not necessary, etape variable is known when we are in the controller so I guess we can remove the watch


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13072](https://teamcity.mesosphere.io/viewLog.html?buildId=114717&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:09:21


Same as the header comment. This needs to be inside each card. Should contain some made up text about the expiration date of the specs.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13079](https://teamcity.mesosphere.io/viewLog.html?buildId=114761&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 217 Build time: 00:09:21


Removed definition of zvcb_arg_t.


@josegonzalez Sorry, I should probably have mentioned that I'm not keen on joining the "Awesome" branding scheme at the moment. Ideally I'd like to sort out a brand specifically for this list at some point.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13071](https://teamcity.mesosphere.io/viewLog.html?buildId=114728&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:09:45


Was ich eigentlich gemacht hab war die UI und den Output aufzuräumen :D


Great work! Nice job in going that extra mile


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13070](https://teamcity.mesosphere.io/viewLog.html?buildId=114730&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:10:00


Много лишних инклюдов. Здесь нужны только cstdint (у тебя его кстати нет, нужен для `(u)int*_t`), string и vector. Остальные инклюды не нужны и только замедлят компиляцию программ, которые подключают этот заголовочный файл.


@dkayiwa  yeah the test case passed. will do necessary changes in the next commit.


Need to add a <header> that contains the pricing <h3>


I know similar tests have been tried before. I just don't like that mobility array. :)


// so not quite sure where this leaves the comment


Thank you! @Evisceration


В инклюде (интерфейсной части библиотеки) такое писать категорически не стоит, так как оно глобально повлияет на все прогриммы, подключающие этот заголовок. Вот в реализации или в своём внутреннем инклюде (который не будут подключать другие программы – пожалуйста.


The existing API isn't consistent about whether the first letter in a description is captialized or not (I've been going with lower-case recently, but am fine with both approaches).  I think `Membership` should be lowercase though.


I am working on it. This was a temp fix, their JSON format is a littler different than what I used. Don't want to hardcode the object names in.


@afelisatti please take a look to this.


No, that's ok. I forgot to include path for release configuaration


You're absolutely right, thanks for find.


Thank you Alexandr!


Код этого файла достаточно тяжело читать и понимать.

Может помогут развёрнутые комментарии с картинками ;-).


Can i remove this testcase , or is there any alternative for this to work.


А точно тут `huffman_tree_result` не пуст и можно делать `begin()->first`?


OK, then leaving `virtual` off makes sense. `override` should still be included, because it's not just cosmetics - it performs a safety check by the compiler against the function signatures falling out of sync.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13077](https://teamcity.mesosphere.io/viewLog.html?buildId=114736&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:12:15


класс для h2


Nice work. Instead of of 10 you could have use `*fortunesList.length`


The other endpoints just use `{id}`, with the membership-ness being clear by context.  You already have `id` in your parameters below, so you probably just need to change this line.


Аналогичный вопрос про `symbol_frequency_map` который могут передать пустым снаружи.


Could you add whitespace after FROM? Or replace second find with string.find(" FROM "), isn't it equivalent?


ссылка , а не  button


магическое число


Great work! Nice looking code.


Be mindful about the order of the attributes of the instance. Follow the order that you used while modeling the class. For example, your `Bicycle` class follows this order: `name, weight, cost_of_produce, selling_price`
The instance should be created following the same order


Good point :+1: , but maybe this could be done in a second commit in the future?


Same as above


этого дива не надо, мы картинку карты кинем на бэкграунд


FYI: As the plugin is coming with its own autoloader, we only need to include this bootstrap file. It will handle the rest.


i know that, but i also know this shit is correct ;) anyways, i pushed the override addition fixup commit 2h ago.


The assumption is if there is an 'AuthorizationCode' there must be a 'c_hash' claim. The theory being the id_token and code arrived together as the result of a 'id_token + code" request.


can capital Q match lower()?


Nice work sir! Plasma Workspaces 5 is shaping up to be very nice. :+1:


Looks nice, thanks :+1: Could you please check the " FROM " remark before merging?


Looks like most of these dependencies are already covered in build.gradle one level up. Check this out - you might make your build file smaller.


Probably best to write `[.gh_response` method


I presume you use "krbtgt" as a lambda example among others ;)


why are there 2 functions being defined here? The function heading was given to you in the starter file, your code should be indented below the function heading (the line that starts with `def`)


i felt like it


Perhaps you don't need conf/ resource as you don't have it anyway


магическое число – так назови его `sentinel`, и комментарий не понадобится


I think “or is a coordinator of the drop” falls under our generic “if the user has access to the…” phrasing.  Auth decisions can get complicated, and I'd rather not bake those definitions into the spec.  Clients probably don't care all that much either, because you usually won't learn about IDs unless you have access to some portion of the backing object.


тут явное приведение не нужно


Logger properties is now included automatically into all smoke-tests. Check build.gradle one level up


ИМХО, `headers_bits <<= 1;`


Amazing job. Great work


The `elif` statement should be outdented so it matches line 49. The body is what's indented.


This is a great first attempt, Michael. Just review the requirements
https://github.com/nashville-software-school/front-end-milestones/blob/master/the-static-web/quiz/HTML_CSS.md
and make sure you get the headers and footers placed inside each card.

The CSS is spot-on. Just clean up your formatting a little by making sure you have consistent spacing between the blocks of CSS. Right now there are some with multiple lines between them, and some with none. Make them have one line of space between them, like you have between `.specs` and `.prices`.

Make those fixes and you are good to go. Just push them up as before and the PR will update automagically.


I typically do string comparisons in lower case, just to avoid case issues: e.g.

`if 'FWHMeff'.lower() in [fname.lower() for fame in summary_columns]:`


Please make sure that gradle rat is still passing with this patch in place. Thanks


ИМХО, `usymbol_tmp -= usymbol_bit << symbol_bit_length;`


TeamCity pull requests :: netty [Build 1124](https://garage.netty.io/teamcity/viewLog.html?buildId=5131&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests passed: 6390, ignored: 23; resource leak detected (new) Build time: 00:44:46


Aqui ele não vai mais fazer o build. Ele vai precisar da imagem já com o build feito


ИМХО, тут и далее тоже `<<=`


Style: отступ


Esse script facilita o build


In see the refactor, but I don't understand the idea behind this abstraction. What exactly is the purpose of `mCount`?


missing semicolon


httpS, please


Awesome. This is all very exciting. Seems like with JInterface (and clojang interface) lfedn wouldn't be of much use. It'd really only be good for sending messages with EDN as a string and then decoding into Clojure/LFE data structures on the receiving end... Which seems not so useful as the more direct approach. I would assume EDN strings are smaller than full blown data structures though, so I guess it could be good for reducing network latency.. /end-thought-dump


I agree that `getIncludes` was a poor name - but my gut feeling is that `parseIncludes` is not quite optimal either. To me, it reads like `parse includes`, i.e. `parse include files`. It doesn't do that though, it parses a list of included files from the compiler output.

How about `parseListOfIncludes`? Maybe a bit long, but it seems closer to what it actually does.


Why is this a variadic parameter?


pour ne pas avoir a faire un commit pour le supprimer tu devrais mettre un .gitignore


Great fix here, it is better to grab the whole length than to use numbers.

Good work overall.


Hmm then is it doing a partial transfer? The xVc counter  or whatever it is might not be setting  to the correct value, that could explain it


I seem to recall that -- since strings in Python are immutable -- repeated string concatenation is very inefficient. Wouldn't it be potentially more efficient (and certainly a smaller patch) if you kept `newOutput` as a list but just used `splitlines(True)` on the compiler output and eventually use

    ''.join(newOutput)

here?


wrong error message


vCL sorry


Removing the `makeActive()` call appears to have broken the map: it is no longer scrollable (and produces js errors on click). Not sure if that was intentional.


How would a person go about connecting to LTE using this APN?

Do you have to set it in build.prop or similar?


после div class=contacts вставь див-контейнер.  потому что мы карту на бэкграунд зафигачим, а текстовый блок все таки будет красиво как контент у нас находиться в контейнере, абсолютно позиционировать этот блок не будем.
то есть структура будет такая:
< div class=contacts >
< div class=container >
< div class=contacts_block>
< h2 >
< p>
..............


Great work!


So are you supposed to do `[[` and `$` as well? All the list-y things?


RIP .data()


Does this comment really help? It was a bit of a 'mental speed bump' to me, but doesn't seem to help much. In fact, it seems to duplicate (a part of) the information in `compiler_output.txt`, i.e. it's prone to getting outdated. I'd vote to remove the comment.


112259371_UnitHeaterHWCoilUASizing (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1507 of 1507 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


OMG 2 spaces after a period? We're not on typewriters anymore. http://www.slate.com/articles/technology/technology/2011/01/space_invaders.html


Since we're already in a `.then` here you can just return `stats.size - (totalBytesRead + (bytesRead - index))` and -1 on line 51.


Error in commit comment - should read "Add hero and CSS styles"


Should this be a json file & array


@juno thanks, man


Instead of these comments (`Don't strip` and `Strip`), which duplicate the meaning of the last boolean argument to `parseIncludes`, better make the code self-documenting...


h


...by writing `strip=False` here.


Kopec noviniek


# Assignment 3 Grading Rubric (15 points total)

## Task Set 1

- [ ] Regex matches entire dinucleotide repeat (AT)5 and only the repeat (1 pt)
- [ ] Regex matches entire dinucleotide repeat (AT)5, only the repeat, and is different from above (1 pt)
- [ ] Regex matches entire dinucleotide repeat (AT)5, only the repeat, and is different both above (1 pt)
- [ ] Regex correctly matches all instances of `R` or `S` (1 pt)
- [ ] Regex (find and replace) matches all instances of `R` or `S` and replaces them with `N` (1 pt)

## Task Set 2

- [ ] Regex (find and replace) correctly reverses the order of the columns from 1,2,3,4 (as you see them) to 4,3,2,1 (1 pt)
- [ ] Regex (find and replace) correctly reverses the order of the columns from 1,2,3,4 (as you see them) to 1,2,4,3 (1 pt)
- [ ] Regex (find and replace) correctly replaces commas with tabs (1 pt)
- [ ] Regex (find and replace) correctly gives us the horrible format requested (1 pt)

## Task Set 3

- [ ] Regex (find and replace) correctly parses out only the lane number from the header (1 pt)
- [ ] Regex (find and replace) correctly parses out only the flowcell ID from the header (1 pt)
- [ ] Regex (find and replace) correctly parses any flowcell ID from the header (1 pt)

## Task Set 4

- [ ] Regex (find and replace) correctly extracts only the serial number from the fastq sequence (1 pt)
- [ ] Regex (find and replace) correctly turns the fastq into a fasta having the requested format (2 pt)

## Task Set 5

- [ ] Regex (find and replace) correctly extracts the (AT)5 repeat (Regex bliss)


...and `strip=True` here.


The intent was to make clear where the 83 comes from. It is a magic number not trivial to conclude when you just look at the input file.


More annoying to write. Have to escape quotes and stuff.


hotobo


Когда их так много, может иметь смысл сделать вектор:
```
enum direction
{
  left_up = 0, // или даже lu, ld, ru, rd
  left_down,
  right_up,
  right_down,
  link_count
};

using links_t = vector<shared_ptr<element>>;
links_t links = links_t(link_count, nullptr);
...
shared_ptr<element>& link(direction d)
{
    return links[d];
}

const shared_ptr<element> link(direction d) const
{
    return links[d];
}
```


The option for me still appears in `/r/random`, perhaps because of #903? also could do with adding `/r/randnsfw`


Like how you are recording the number of clicks


seems this `variant-moreinfo-editdonebutton-row` element is not generated any more, breaks variants UI


Great work.


ИМХО, хочется комментарий с описанием формата заголовка в виде таблицы. Желательно в формате, который одновременно человеко- и машино-читаемый. markdown?


indeed, @njoyard I guess you initially put the $timeout wait for etape to handle the simple check etape was not null ?We still do the same simple check in the debates here https://github.com/regardscitoyens/the-law-factory/blob/refactor-v2/public/modules/debats/debats.js#L20


That's more like a "wait till angular did at least dispatch loop" kind of thing here. Most likely not the best way to do it, though, I'll see what I can do. The idea is that, if we call resize() too soon, other components of the page are not ready yet and computed sizes are wrong.


`sizeof(header_word)`, может ты потом тип `header_word` поменяешь, и особенно с учётом что `unit16_t` может занимать не 2 `char`а


does this work? Don't I need a kwarg function signature for that?


ThermCalcRelHumUseSameHumidRatioDryBulb (JasonGlazer) - x86_64-MacOS-10.9-clang: OK (2048 of 2050 tests passed, 2 test warnings)

 * 3 tests had: AUD diffs.
 * 2 tests had: ESO big diffs.
 * 1 test had: EIO diffs.
 * 1 test had: ESO small diffs.
 * 1 test had: Table small diffs.
 * 2 tests had: ERR diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.9%25-yellow.svg)


`16` всётаки стоит сделать именованной константой


Yes, that's what I'm working on.


:shit:


The following doc(s) have been deployed to the [1030config](http://1030config-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/sites/plan-configurations](http://1030config-static-docs.pantheon.io/docs/articles/sites/plan-configurations)


@ttuegel Thank You very very much! https://github.com/NixOS/nixpkgs/issues/12415 It is unlikely I will be able to pull and test this until the weekend. I am however; pretty optimistic that this will fix the linked issue. :+1:


It will save to the hd anyways


и опять магическая константа `9`


I agree with the chance in general, but in addition to what I mentioned in the inline comments, there were a few things which made me twitch while reading:

1. There seem to be two entirely separate things in this commit; renaming `getIncludes` to `parseInclude`, and adding tests for the function. Splitting these two things into two commits seems sensible to me.

2. There are two typos in the commit log, `plitting` should be `splitting` and `it's` should be `its`.

3. The paragraph `Add tests.` in the commit log doesn't seem to provide any extra value. :-}


http://52.0.79.220/redmine/issues/921 (1 & 2)


Similar problem in here. Each of  the the three assignments is ending with an `update` eventually and `update` is already quite slow. Please use one `update` instead.


You got the mention wrong, it's Lanchon :)


название класса лучше привязать к форме, а не к левой колонке, например form_title


As discussed with you, the fix can be apply in the Database.class file by making the fetchAll function optional.


Great work, going above and beyond using conditional statements.


maybe watch rather for steps then ?


Good use of the setAttribute


2 space indents.


We can move this check prior to the `statAsync`, right? Since we already know we're not going to do anything if `element.length === 0`.


We need to be able to write a SQL query using this column name in the WHERE clause, so we have to know what OpSim's capitalization convention is, anyway.


What about making two tests out of this? Then we can even get better feedback from the testing framework if only one fails. Leads to some code duplication, which should not be too bad.


Явное приведение не нужно, тут типы вообще совпадают.
Кстати, лучше писать приведение в C++ стиле: `..._cast<...>(...)`.


I'm guessing that this is the appropriate place for `events_shutdown()`?


@Alexendoo, yeah that's why it shows up there. That's the problem when you have similar code in two classes. Will fix this tomorrow


ИМХО, я бы не стал ради чтения заголовка лишний раз открывать/закрывать файл. Да ещё хранить позицию. Прочитал бы файл, или его часть, и распаковывал бы заголовок из памяти.


Exactly.. just a random username I chose ;)


Je peux faire ce machin là... non?


The term `e` isn't present in the above code sample.


Based on instructions here: https://lord.io/blog/2014/travis-multiple-subdirs/


lgtm


Can we flatten this promise chain?


where did you ear that? we prefer to use [plone.directives.form](https://pypi.python.org/pypi/plone.directives.form) whenever we need to create a `z3c.form` as it give us some goodies,


Good enough.


Are all these white space changes only? Did you commit it by mistake?

Could you please make separate pulls for such cleanups?


it doesn't matter; just trying to be consistent.


У тебя многие имена длинноваты. И код немного тяжело читать и понимать.

С другой стороны, у меня имена слишком короткие.
Например, непонятно что делает каждая из функций `encode()`/`pack()`/`pack_code()`/`compress()`.
Ещё у меня нет распределения исходников по файлам, нет работы с файлами, разбивки файла на блоки и тестирования на случайном входе.


I'm not sure this is needed if we are defaulting the login-mode to machine-token. I think this allows the

`auth login --machine-token`

usage, but that usage is now the same as:

`auth login`

So it's redundant.


Also, the [[ ]] is not required here (not even sure it works).


Ah ouais, thanks pour le tips


тут теги < p > вообще не нужны.
просто делаешь input'ы и с ними связанные label, которых у тебя пока нет.
label добавь обязательно!!! на них будет строиться вся стилизация


i don't mind ;-)


As mysql_* database calls are deprecated and are no longer supported by PHP, they have been changed to the corresponding mysqli_* calls. Thanks to Laurens Vercaigne for his work!


`and not os.getenv('CENTOS') == '1':`


Ok. I see what's going on. You worked on an  outdated tree. Could you please re-base your change?


although it's bit too bad to have to wait for the stepsbar to be loaded before calling the amendments api, maybe only put the resize call in the already existign watch on steps in the update function here https://github.com/regardscitoyens/the-law-factory/commit/3f568a7d584beeaf6d6b10310efbed7588ed244b#diff-6a3c7e53fa4633742fab427e36d2aea8R96


Uh oh, is performance 50x worse?


I haven't looked at the rest of the patch, but yes this looks like the right place: After every events-using piece of code has returned.


This smells like copypasta.


Why is that the case? I'm happy to revert, but I'd like to understand why this would be a bad idea?


Fine :)

1. I'd consider it a wast of time because these renaming happen on the go when stuff does not makes sense while working at another point. But if that really matters, I can split it
2. thanks, I'll fix those
3. The commit adds tests, which is the core of this commit. But it is redundant to the commit title, yes.


I'm trying to think through my last 'elsif' block of code. My previous conditional was not specific enough, so i thought of a better statement. I'm expecting my code to:

-Take the value of the latest words last letter and add one to it
  			last_letter = word_index.max{|k ,v| v} +1

-Delete the key/value pair with highest value
 			word_index.delete(word_index.max_by{|k,v| v})

-Take the value of the previous word's last letter and add 1
 			first_letter = word_index.max{|k,v| v} +1

But this elsif block isn't being used despite updating the conditional. I need help troubleshooting the issue.


Nice, I didn't know about `-s`.


Is there a reason why we do all of this reading c-style as opposed to opening an iostream and using getline(), etc? Especially now that we're doing more complex parsing, that seems like it may be less error-prone.


What is `hector_ocean_data.csv`?  It is huge.  Also, it seems to contain some paths that are specific to your workspace (e.g., `C:/Users/hart428/Documents/GitHub/hector/output/outputstream_rcp26.csv`).


lgtm


i think your branch is out of sync with master


Yes, you get all the good language support this way. :+1:


I thin we need to reimplement this so that only controller.js shows any messages or does any AJAX requests to create  new patients - and here we just notify the controller that a new patient should be created.

The only reason a patient was created here is to have patientID in the message to the controller (and even then this was just the quickest way to do it for a demo a while ago). nodeMenu should only do UI stuff and not issue any requests


Why did you add the travis status image here  ?
https://docs.travis-ci.com/user/status-images/


Where does this factor of 0.7 come from?  It should probably be a defined constant, and it needs some comment on why it has the value it does.


Ah, ok - however, when reading this comment, I didn't even see the number '83' being used anywhere (I see it's used further down, when asserting).

How about adding

    numUniqueIncludes = 83

right below `compilerOutput=infile.read()` then? That kind of suggests that the two are related.


Right. Too long is hardly the issue, too short is. Especially with Python's type system.

`parseListOfIncludes` is alright. What about `parseIncludesList`?


Not sure really. Might be because reading different integer formats
(decimal vs hex, etc) is a bit of a pain with iostreams.

On Wed, Jan 27, 2016 at 1:37 PM, Francis Ricci <notifications@github.com>
wrote:

> Is there a reason why we do all of this reading c-style as opposed to
> opening an iostream and using getline(), etc? Especially now that we're
> doing more complex parsing, that seems like it may be less error-prone.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sas/ds2/commit/d8647181b8760232569583697aa08cca9a77bd2f#commitcomment-15718497>
> .
>

--
Stephane Sezer


Version makes no sense with a default since you must give SOMETHING for us to check for.


Good catch.


My eyes just bled a little. But at least it's a concise hack? Looks good.


What happens when `Type` is a generic type argument that is instantiated with Nullable?


Ah a side note, I analyzed the DMA test issues.

Most of the issue are due to a wrapping after 16K (size of the spad).
So in `pcsx2/SPR.cpp`
* `spr0ch.sadr` must be masked with `0x3FFF`
* all transfers must be wrapped after 16K
 * It seems `hwMFIFOWrite` already do something with `MemCopy_WrappedDest`
 * I guess raw memcpy must be updated too. So far I put some assertions


112259371_UnitHeaterHWCoilUASizing (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (2056 of 2056 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


все аналогично тому, что и с радиобаттонами. value тут в принципе не надо.


Hey @johanneslumpe are you going to publish a new npm version (1.1.1) with the latest pull requests applied?

thanks!


Thanks @jeremyevans. Wonder if we can get this as 4.30.1 sooner if master is in flux?


Whoops, done.


I really like the testing class, I will add some more links that are possible as well in the future! Thank you!


well for so long as `version()` in the Plugin annotation is defaulted we can't really require this.


How can `T` have a base type here?  The `T` is constrained to be a struct.  Are we specifically referring to `object` here?


 *** ANNOUNCEMENT: m_ctcpxline: Invalid pattern value in config:
*** ANNOUNCEMENT: m_ctcpxline: Invalid action value in config:
*** ANNOUNCEMENT: m_ctcpxline: Invalid duration value in config:
 *** ANNOUNCEMENT: m_ctcpxline: Invalid reason value in config:
*** ANNOUNCEMENT: NEW MODULE: ZeRo loaded m_ctcpxline.so

Hello I added so file and config lines but I give an error version 2.0.20


Well, I am not sure that an s3 method is the best, actually. gh is very ignorant about the response, and I think this is better than being half-smart. And having indexing methods would mean being half-smart.

Actually, maybe the current code above is broken for responses that are not lists. Or all github responses are lists?

Anyway, I think it would be better to leave gh dumb and build another package on top of it, a really smart one.


This is a fine workaround. I do feel like, all else being equal, it would be good to know why these failures are occurring, i.e. where the actual bug is. Memory allocation failure? Corruption of the IPL header?


@column you better take this one.


You can remove that OnAbilityPhaseStart kv block and CheckPosition its not longer valid. If the clay planting needs a free 2x2 with ghosting it would need to pass through the builder script


does this only skip spectators when they haven't voted? that's how it should be


112259371_UnitHeaterHWCoilUASizing (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (956 of 956 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.85%25-green.svg)


I agree and have made the changes here


@Deamon5550

If we default it to something other than "", we'll be fine.


Yes, spectators without any votes are not counted.


Update util.check_model_param_types to allow for `None` even if not in listed expected types


trying to make this the ms.cpp file in the master branch


див класс btn_submit
< p > не надо
лучше использовать: < button type="submit" class="filter_btn" >Показать</ button >.  стилизировать будет лучше


:+1: looks like @manucorporat!


Two problems with this:

1) It seems to depend on the encryption service being available in the system before this bundle is loaded. It simply loads the decryptor and if the service isn't immediately available it just passes it through as-is. If the value is encrypted, it should wait for the decryptor service to be available before continuing. I'll submit a pull request to fix this.

2) It adds the decrypted value to the config properties where they are easily visible via config:list. It should only decrypt the config value and use it to create the DataSource, but leave the OSGI configadmin property as-is. I can submit a pull request to fix this too.


TeamCity DNN JavaScript Libraries :: CI [Build 137](http://teamcity.engagesoftware.com/viewLog.html?buildId=415&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


див а не < p>


TeamCity DNN JavaScript Libraries :: CI [Build 137](http://teamcity.engagesoftware.com/viewLog.html?buildId=415&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:21


Hmm okay. It looks like it works, so I'm good with it.


Looks like we can have custom `operator is` definitions.  How does this impact the `is` usage today?  Does it call into operators when appropriate?


@ccrama nice to hear that. I figured that somebody had to start with test classes :p are you on IRC tomorrow?


Shouldn't there be some before or after values in this dependency?


В одиночных тегах не нужен закрывающий слэш на конце.


Indeed, was about to mention that.


Are these unescaped ampersands going to cause any issues?


oops


Vous trouverez un mode d'emploi de la classe DataMnist dans la rubrique Wiki


Incorrectly named texture.
 src/config/Quadrum/block/textures/Bones.png


c'est bon ca passe les tests


Maybe. As it is, for just two tests, I don't feel strongly either way. As long as the need for comments can be avoided by just making the code more expressive, I'm happy.


Done


I think "Alumnias" may have been intended to be read as "Alumni as defined in...". Currently it says "Alumni defined in..." which may or may not be correct.


This example actually is for custom analytics and not Google Analytics. Maybe use a scope like "cookieScope"?

Google analytics already has the client id configured correctly in extensions/amp-analytics/0/1/vendors.js.


первая активная страница span, не ссылка


Тут нет смысла оборачивать ul ещё в один див. Достаточно просто сделать ul.breadcrumbs
Если бы это было главное меню, и ты использовала бы тэг Nav - тогда это прибавило бы семантического смысла, а так - блок в блоке, для стилизации нам это не понадобится, и семантики не прибавит. Див стоит убрать.


And make sure that you handle all kinds of whitespaces correctly (`SELECT X\nFROM TABLE`).


because of grok?
i beleave you find that stuff now in plone.autoform


Wait I'm dumb. I swear I know how grep works.


nav лучше дать класс, что это главное меню. Хотя с точки зрения что он один на странице и не обязательно. Но на вебинаре Саша его добавил, думаю и нам лучше тоже)


This cause `erlang-syslog-1.0.1` to be matched as well which makes `relx` depends on `erlang`!


You probably don't want to delete the wait_for_tests unit test


You don't need this method.


Looks good overall. Just a few nits and this can go in.


+1 for 4.30.1


This is a smell, prefer `$stdout` over `$>`


в html5 есть тэг address который примерно для того, чтобы оборачивать автора сайта... Ну, можешь почитать про него, как минимум.


No, `kwargs` is needed if you want to access an _arbitrary number_ of parameters, by keys.


It may be that IDE integrations need updating after this - but I'd actually be a bit surprised if that is the case.  If there is a problem with this change that IDE integrations don't think they should need to work around, I'd be interested in details of that.


Keby si to chcel skraslit monospace fontom, v github flavored markdown sa da command odlisit:
```
`nano /var/www/openbiblio/database_constants.php`
```


Назвать файл можно просто shop.html  т.к. понятно к какому сайту этот файлик относится и без префикса)


Я знаю, это задание не надо было решать, но уж очень интересно было.


I can't seem to get this build to load? I run the start.sh and it immediately closes.


Hate to nit-pick but this should be `areSigsChecked()`. But, I'd prefer to have:

```virtual bool checkSigs() const = 0;
virtual bool checkSigs(bool) = 0;```


Test


@mjpost , I don't think this modification was tested. Where does word.txt come from?

My current runs crash because of :
ERROR: FstHeader::Read: Bad FST header: sos.ft


I'm reading more into this, but for starters please fix the conditional itself. You have `last_letter = str.length` but that's _setting_ `last_letter` to be equal to `str.length`. You need `last_letter == str.length`

Again, no idea if that's the issue. But I'd rather you check it for me while I read more of your code.


Одна из ссылок в меню - активная, в спецификации написано что в этом пункте тег a надо убрать.


NICE!

I wonder if we can get power in there too - I think its available in smoothArray ?


I don't _insist_ on splitting the commit (if everything else is fine, I'd merge it anyway) - I just prefer it. The main reason being that `git bisect` gets me closer to the cause of an issue if each commit is smaller.


Check if the GPS fix is good enough to set an EKF origin and start aiding


Since you're using these consts in two places already, and it makes sense to have them in other places, could you move these to constants defined in a header somewhere?


I think you're missing a trailing dollar sign. Should be
```
if (kind == "$Isolate$"):
```
But like was mentioned, you might only need
```
if (kind.startswith("$")):
```


Последний пункт хлебных корок - активный, ссылка на нём не нужна.


@Jalle19 why is m_dmx_active access here and everywhere(?) else not mutex protected?


Ok I cannot reproduce the issue as my laptop is super fast but I can feel the issue. For me, the way the resize is done is weird and I guess that we will drop this watch after a better way of managing height in this app


You can now fork this repo. @CharlesVaneenoo


yeah, if fixed it. i don't think that was the main issue


NIce


checked лучше ставить последним атрибутом. id не может содержать пробелы, или ты хотела чтобы у тебя три айдишника было на один инпут?)


лэйбл, соответственно, не может ссылаться на такой айдишник


Run start.bat if you use Windows


Review complete. there will be some conflicts when PR https://github.com/PX4/ecl/pull/14 is merged


AUTO-MESSAGE - JSHint detected errors in the following files: webtask.js


Fed dftd3frf TD Waterhouse


Works for me.


I am using linux mint


Ce fichier comporte une esquisse de la base de données il y a je pense de bonne idée mais aussi des choses à jeter je pense


previous build worked fine D:


This is ~100 lines after a compiler process call. So optimizing this should not be the motivation.

But I can write it as you suggested, there is no reason against it.


Wow, I messed up on the commit message...!


IMO we don't even have to resize containers dynamically. We should use absolute positioning relative to screen edges for each of them, that would solve everything.


How strange.  Both versions of this file compile in my workspace.  What version of Boost are you using?


I couldn't say it better :))))))


@rjmccall , I'd appreciate a review of this. The changes all *seem* correct to me, and match the way Clang emits ObjC selector references.


this is a start


@franticpsyx That makes sense. Is there currently a limit on how many options that can be added or will it be left unlocked?


where's this file coming from?


fast-forwarding 1.7 to borshop-integration-227-bugfix/jdm/leak-hintfile-fd-on-startup = a1526725


# This is a comment.


I'm assuming on Mac is the same as on Linux?


Added recommended changes, but forgot to delete the old method for defining note_content. will do that on the next revision.


Please proceed !!! If we can make this thing easier to tune, that would be great.
My point was just to give you some ideas: trying pieces independently.


This is somewhat disgusting, but I need a policy judgement.  As far as I understand the magic getopt, if you want to **enforce** that the first argument to `scrypt` is `enc` or `dec` (or now `--version`), these checks must happen before `GETOPT`.

I would be tempted to relax the "`enc` must be first!" policy, and add `GETOPT("enc"):` .  But that would be a behaviour change from the current `scrypt`, so I thought I should check.


Nice!  Do you plan on just launching more instances by hand?  Or where will `INJECTOR_COUNT` be specified?

:fish:


LGTM.


get rekt


gg wp


cyka


Yes, they compile under Mac/Linux. It's only VS on Windows that throws an error with this line.


Do we need the first three files? Aren't they just Eclipse artefacts? I'm aware this is a tests but tests are useful! Worth adding these to the .gitignore file?


Should this line be also changed or not? I'm not sure here.


Fixed a bug whereby changing the HBP temp was then disabling management of the HBP heater.  Logic was inverted in call to setUsingPlatform(altTemp == 0).  Indeed, now that I think of it, that call needs to never pass false. The routine is really only supposed to be called on power-up to tell the firmware that there is indeed an HBP present so manage it.  Since someone can, from the Utilities menu, set the HBP being present post-boot, there's a call in Command.cc to ensure that it is enabled if any command is received to use the HBP, even one to turn it off.  That's a safety measure: if it isn't being managed, then a command to turn it off by setting the temp to 0 will go unseen....

Also, I'll add in the necessary code (hopefully it fits) for dealing with gcodeTempOverride.  When the HBP temp is altered via the LCD display, the code for executing temp overrides of gcode needs to know.  If it doesn't know and it is enabled, it will then toss the operator updated temp and use the pre-heat temp.


Depending on the openssl lib on the host, the `post(...)` will throw if the server does not have a properly signed SSL cert. One can add `post(..., verify=False)`. However, that seems like a bad default and kattis should have a valid certificate.
We *could* add a command line option to ignore strict certificate checking but I'm not sure it is worth the clutter.


This should not have been done this way; you should have been adding `amber.popupHelios();` just after `amber.initialize(...);` call.


@nathaniel-mahieu Could you rebase this branch please?


Integration tests caught this: now that `startEditorWindow()` is called asynchronously, we need to emit this event later, otherwise, we may miss an `open-locations` ipc message that is sent too *early*.


(`amber/devel` reexports `amber/deploy` which reexports `amber/helpers`, look at support/devel.js and support/deploy.js)


..\..\..\..\..\..\Windows\Microsoft.NET\assembly - this reference is machine specific. please use it form packages folder instead (if it is a nuget package) or let the system figure out where it is located.


See #10


Already in https://github.com/notspiff/xbmc/commit/62d1b50695373989d044db53c97726faeb1a51c0#diff-4b90bd3a25e54c31f8e21789f7a66da9R396


Added methods to the 'WithdrawalDeposit' class with some general settings. Later user input will be added.


This parameter sets offset of stack trace when exception throwed.
Useful example: wrapping user scripts in closure so stack trace will shift.

```javascript
(function(){
       `userScript`
}())
```

So, you need to call Load with offset = -1.
This is variadic parameter because it is 0 by default.


I looked again into Fixnum documentation and found a way to make it look nicer and save me a line of code -
```ratio, number = number.divmod(value)```
will do the trick and I can get rid of line 26


Darn, thought this was resolved. Well, I don't see why it shouldn't be changed for consistency.


AUTO-MESSAGE - JSHint detected errors in the following files: webtask.js


Thank you :-)


puppet


Thanks for the shoutout @alexG53090


Much more elegant approach.  Thanks.


It might clearer to type the argument as "const int pos[]".


I made a derp from https://github.com/Huawei-Kiwi/android_device_huawei_kiwi/commit/fa1340782f9b58bacfaec14f917d8f4e09a291c5 by failing to removing the kernel and dtb from its original location after relocating. Problem solved here lol.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1257.4080e47ff75a393e1d37561bf7c69acb24bae9c5](http://build.palaso.org/viewLog.html?buildId=68540&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 857, ignored: 7 Build time: 00:06:36


You forgot to change the CoFHCore file; only changed the changelog.


```ruby
Model.fetch_multi(object_ids).select { |record| record == true }
```

for fetch_multi. You could add `.first` to use that like fetch_by_id


So `IOUtils.toString` doesn't take encoding as a parameter.  How did you determine this to fix encoding assumptions?


got it


will do


`customer` is a critical field here, so I recommend listing these in the following order: `id`, `customer`, `drop`, `cutoff-*`.


This works. I wonder if you can just create booleans in JavaScript and return them.


Wonder if your IDE is doing this?


I'm going to look into this, the truth is that when using the sync method instead of the async I was getting outrageously better numbers here but this is also appending 1 JSON object at a time. Which when doing several thousand objects at a time the performance hit was not much (although this suite is still in the works). I'll file an issue (#1) to investigate this as I can't see any reason the async implementation would be slower than the sync one.


compatibility


Should I be using the  part  # bikes = {"black_bike":"4", "gold_bike":"3",
"red_bike":"2", "silver_bike":"5", "purple_bike":"1"}
# bikeshop = Bike_Shop("Bikeshop",bikes,20/100)

# customerone = Customers("Customerone",200) # added info to included
customers budgets.py
# customertwo = Customers("Customertwo",500)
# customerthree = Customers("Customerthree",1000)

# allcustomers = []
# afforablebikes = {}  for the if __name__ == '__main__':

or should I just be creating new code is what I am trying to understand
because it seems that some of the project I need to add more info or is
that incorrect is the other info in the classes enough

Loren

On Wed, Jan 27, 2016 at 4:16 PM, Emily Karungi <notifications@github.com>
wrote:

> Be mindful about the order of the attributes of the instance. Follow the
> order that you used while modeling the class. For example, your Bicycle
> class follows this order: name, weight, cost_of_produce, selling_price
> The instance should be created following the same order
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lrsouthflorida/drummerclasses/commit/563807713dedd1d0440a1ea7350f1c317e7b1f19#commitcomment-15717869>
> .
>


@davidvgalbraith I'll fix up those things you mentioned above and tag you in a follow up PR instead of directly pushing things to master.


sending over white spaces clean up as a separate pull request (I will then make the meaningful changes as part of improved version of date)


This didn't seem to work for me. I'm getting strings instead of dates.
```
cljs.user=> (:created (planck.io/fstat "/tmp"))
"Wed Jan 27 2016 17:13:45 GMT-0500 (EST)"
```


I'm probably overthinking this, but: would it make sense to put this def (and all the upgrade/downgrade/wrapper code) inside an ifdef HALIDE_SUPPORT_OLD_BUFFER_T? This would make it easier to identify and remove later.


You should open an issue instead of commenting on a commit


I think you can create JavaScript integers in the Objective-C side. May not be a need to create strings to be parsed.


AUTO-MESSAGE - JSHint detected errors in the following files: webtask.js


Awesome! Thanks!! :100:


Does setting attributes outside `hook.params` work?  Previously you had to stick any custom data as an attribute of one of the existing attributes if you wanted it to persist, but maybe that's only if you want it to persist from before-hooks to after-hooks.


Perhaps this fn should be private


Looks like a typo at end of sentence.


Я правда думаю, что объединить compress и uncompress в одном файле возможно хорошая мысль.


@ajmath do you remember what the rational was behind adding this? Seems like it's not part of the spirit of this PR. I'm cleaning things up now to get this merged but wanted to check with you first before moving forward.


It does not make sense to change the version to a release version if there has not been made a release yet which will be done automatically by using the maven-release-plugin during the release procedure..


`six` is a Python library that helps with this sort of thing. It provides safe imports for both Python 2 and 3 for these renamed modules. Django bundles six, so you do not even need to install it. You can replace these four lines with:

```python
from django.utils.six.moves.http_client import client
```

The documentation for all the moved modules can be found at: https://pythonhosted.org/six/#module-six.moves


@iherman is this correct?


На сколько удобено такое определение:
using letter_t = size_t;
using text_t = vector<letter_t>;
Приходится в голове держать тип данных? Или это действительно удобно?


@donnapep "PermanentMarker" is a google font, can you clarify why that's the font-family expected here?


w00t!
[![Build Status](https://travis-ci.org/HE-Arc/demo-rails-application.svg?branch=master)](https://travis-ci.org/HE-Arc/demo-rails-application)


PlantCompBaseClassAgain (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2050 of 2050 tests passed, 329 test warnings)

 * 331 tests had: AUD diffs.
 * 329 tests had: BND diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


for clarity, or confusion, we're using the cancancan fork of cancan, so the documentation you want is [here](https://github.com/CanCanCommunity/cancancan/wiki/Defining-Abilities)


добавь все таки li'шкам класс, например  class=main-nav-item.  чтобы в дальнейшем при стилизации не было слишком боьшой вложенности селекторов


oooh! Okey! Thanks for your comments, I'll make those changes. I just started to see the code and tried to make some changes.


Wow, this one really looks cool


Indeed; I have this in my `config`. Probably missed it in some sync.


![image](https://cloud.githubusercontent.com/assets/16653086/12630430/ef9dcdd2-c511-11e5-9f9d-e6c1d46582ed.png)

It didn't find and replace correctly.


oops, thought I removed this...


Would that be instead of attribute((deprecated))? I'm not sure how they should interact.


Probably want to figure out what should be done if the file is not found. Maybe have it return `nil`? Or, if an error might have a useful localized string (and your other `exists?` API is available, you could perhaps have the API throw.


Actually merge fail, this commit is over an half year old


Perhaps a suiting header? A blue background with the European stars?


Hi Romain! Thanks for your comment. Parallel streaming is efective when opperation inside takes some time. In this case it is realy simple operation. So, yes, I could use old good foreach loop. I just like stream approach.


Need to remove the .DS_Store files.


It should follow DE translations, as requested in head comments.


Like I said: probably overthinking it.


We should probably check that `len(stats) > 0` first.


Is the --with-toolchain actually necessary?
I've just checked and I'm using ``--with-toolchain=/usr/local/bcm-gcc/arm-bcm2708hardfp-linux-gnueabi/sysroot`` but I don't have a ``/usr/local/bcm-gcc/`` so I suspect this line isn't doing anything useful.


Słuszna uwaga, ale z drugiej strony nie nasłuchujemy tego zdarzenia na stronie edycji, więc co za różnica?


The intent here is slightly unclear, are you disabling it for line below and then re-enabling it after? Would have thought the right way to do that would be to put the disable on the same line.


It may be beneficial to define a trivial default constructor (possibly giving regions a valid initial state along side it), and a constructor that assigns to its members for SpecialRegion which allows for forwarding. This line can then be changed to:

```cpp
current_page_table->special_regions.emplace_back(base, size, mmio_handler);
```


NO idea I just noticed the inconsistency and thought I'd raise it to someone's attention who might know more.


AUTO-MESSAGE - JSHint detected errors in the following files: webtask.js


You got it partner. Doesn't get persisted to the db. Just in the req, res cycle.


Correct me if I'm wrong, but the `./` is optional, since it defaults to the current working directory.


I am now getting a "NameError Exception: uninitialized constant Capybara::Queries::CurrentPathQuery::Addressable" when I use "page.has_current_path?" and I think it is because of this change.


@thejameskyle +1


While you are making these changes can you include enough things to have travis just call this Makefile instead of moving around and calling other makefiles?


Your commit title doesn't match what changed... O.o


I notice in your code cleanup that you spend a bit of time with whitespace and aligning = signs.
What tab settings do you use? Or do you just use spaces?
I have tried 2 and 4 space tabs and they often don't align with your columns.
Do you want me to re-align groups of assignment statements if a variable name pokes out past the column? Or just leave that stuff up to you?
Reason I ask is that if I did that, any pull requests may have more trivial whitespace changes than the actual code that does the job.
Cheers, Graham


Se crea el archivo de migración con el comando  `rails g migration change_column_permission_level_from_string_to_integer`, realizamos los cambios y luego se migra con el comando `rake db:migrate`.


It's not necessarily a bad idea, but I've never been keen on the idea of branding "Awesome Lists" under one big group. I'd prefer to define a unique brand instead eventually, which would fit in with my longer term goal of maybe having a website version of the list. I'm hoping to flesh out a simple roadmap at some point so the direction is clearer.


What's this about?  I don't see any backing implementation in azurestandard/beehive#1498.


Sorry, persist was a bad term, there.  I meant to say that I thought that if you set `hook.awesome` in a before-hook, it will not be present in an after-hook.  You would have to stick it on `hook.params.awesome`.  I don't know if it still works the same way since I've been sticking stuff in `hook.params` since then.


оберни все таки этот img в div, чтобы свойства позиционирования мы применяли к диву , а не к  img


I think I was up to date but the documentation wasn't and when I made the documentation for date these files also got updated. How should I deal with such a situation?


It's already there -- if you just call "make -C regression" from the top-level of rocket-chip it'll work fine.


dependecy => dependency

Funny, I always misspell it as depedency


These debug message changes seem out of place. Should this be in another patch?


The following doc(s) have been deployed to the [refactorci](http://refactorci-static-docs.pantheon.io/docs) Multidev environment:
- [circle.yml](https://github.com/pantheon-systems/documentation/commit/fc35327823d9acbb92cd607dbee52c0829e9e20b/circle.yml)


Disabling all certificate validation subsumes host name verification.  However, in many use cases one wants to ensure having a valid certificate (say signed by a trusted CA) but does not want the additional check of CN and/or the SAN in the cert.  Hostname verification enable/disable should not be gratuitously removed.


This code doesn't work.  You can't read the image mask from an arbitrary position - it only occurs at the start of the file.


That's exactly the way it works right now in Forge though? The version of the dependency is completely optional and not sure if you should really make it required unless we enforce a proper comparable comparable version format because otherwise things would just break, wouldn't they?


Why does subsetting something via `[` change its class anyway? 🤔

@gaborcsardi are you saying to fix it right there and if people subset a `gh_response` themselves, they can deal with regular list printing?


nice!


BRB, killing myself


what is truenorth?


Yay!


That's awesome


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1258.c1cb4c75078973ea35dd23d4072e55dc31991851](http://build.palaso.org/viewLog.html?buildId=68552&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 857, ignored: 7 Build time: 00:10:28


Добро решение на задачата


класс для < p >забыл


Do you have any reason for not using session.get() for the above?


112259371_UnitHeaterHWCoilUASizing (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1507 of 1507 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


should it be passed the event?


My apologies for not seeing this sooner. I have made these updates and committed. Next time, I'll be sure to check the PRs on the project before doing the work.

Thanks for taking the time for this contribution.


Ok, we'll have to test this out and see, thanks.


Back to our discussion - In general we don't want to create packages that only work in particular scenarios. Did you consider using props for this instead of content items?


@jennybc

Yes.

I think in general if you subset a gh_response, that is not a gh_response any more. Right? And since we don't want to have any more classes (gh_repo, gh_user, etc.) in this package, subsetting is up to the user.

As for the code above, that is special, we are constructing a gh_response here, internally.


тут нужна картинка, верни ее )


класс для <p >


This isn't protecting against the cases where this is not 8 bit per pixel, any block masking, and band representation other than R -> G -> B.

It also doesn't appear to have your generics approach for the ImageBlock data.

Those probably need to get JIRA tickets, or be fixed for 0.2.


Since mail bodies are encapsulated in CDATA sections, would it not make sense to show that in the sample response?


As a reader of the tests I usually don't care that I have a fake object. I'd say `ui` is fine here.


@JeffBezanson the rest of this commit is random unrelated WIP, but this file diff is fixes for `--compile=all` for jb/functions


I think it broke dice test on my amd gpu.


# +1 :smiling_imp:


Страхотно решение на задачата, използвали сте и правилна формула, което е супер.


Should this be in BUILDFLAGS  Or should we add a $DEBUGFLAGS  and then set it separately?

That way we might be able to get it upstream


класс для ссылки


This used to be a separate option in the plugin annotation but I removed it when I updated the commit because the naming was weird and I'm actually wondering if there is a real use case for it, except really bad mistakes like starting to specify plugins using the API from the plugin or stuff like that when it really should be an dependency in the actual plugin using APIs of other plugins.


The block with an empty string as the return value is not needed here, is it?


The following doc(s) have been deployed to the [refactorci](http://refactorci-static-docs.pantheon.io/docs) Multidev environment:
- [circle.yml](https://github.com/pantheon-systems/documentation/commit/fc35327823d9acbb92cd607dbee52c0829e9e20b/circle.yml)


PlantCompBaseClassAgain (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


# Assignment 3 Grading Rubric (15 points total)

## Task Set 1

- [ ] Regex matches entire dinucleotide repeat (AT)5 and only the repeat (1 pt)
- [ ] Regex matches entire dinucleotide repeat (AT)5, only the repeat, and is different from above (1 pt)
- [ ] Regex matches entire dinucleotide repeat (AT)5, only the repeat, and is different both above (1 pt)
- [ ] Regex correctly matches all instances of `R` or `S` (1 pt)
- [ ] Regex (find and replace) matches all instances of `R` or `S` and replaces them with `N` (1 pt)

## Task Set 2

- [ ] Regex (find and replace) correctly reverses the order of the columns from 1,2,3,4 (as you see them) to 4,3,2,1 (1 pt)
- [ ] Regex (find and replace) correctly reverses the order of the columns from 1,2,3,4 (as you see them) to 1,2,4,3 (1 pt)
- [ ] Regex (find and replace) correctly replaces commas with tabs (1 pt)
- [ ] Regex (find and replace) correctly gives us the horrible format requested (1 pt)

## Task Set 3

- [ ] Regex (find and replace) correctly parses out only the lane number from the header (1 pt)
- [ ] Regex (find and replace) correctly parses out only the flowcell ID from the header (1 pt)
- [ ] Regex (find and replace) correctly parses any flowcell ID from the header (1 pt)

## Task Set 4

- [ ] Regex (find and replace) correctly extracts only the serial number from the fastq sequence (1 pt)
- [ ] Regex (find and replace) correctly turns the fastq into a fasta having the requested format (2 pt)

## Task Set 5

- [ ] Regex (find and replace) correctly extracts the (AT)5 repeat (Regex bliss)


See above. Allowing `display` to be received but never verifying it. This line can be deleted here.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13092](https://teamcity.mesosphere.io/viewLog.html?buildId=114842&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:03


The problem is RE definition.  _WIN32/64 'should' have been defined, I would think.  But I may be wrong, and it may be that they are defined in jumbo.h or something.


commit branch1


Yes, if power is present I have to add it.


The commit says that the user callback should be called if an error happens. Ok.

However you're also fixing some other problems. Like in  _parse_platform_info_payload() and _parse_server_info_payload().

Are you supposed to call the user cb there as well? Because if you do, you still not calling it.

I suggest that you split this one


Unknow should be Unknown.


Great and eagerly awaited job! I had figured out a few of those, but might have spent weeks on the rest of them.
Perhaps some more inline documentation of functions in the package source would be more productive than having an external document?
One example I believe may be missing, or at least have missed myself, is converting 2d signals (mouse position) to 3d signals. And vice versa, 3d signal positions to 2d for hit point detection outside of OpenGL. Indexing on signals is not possible.
Another possibly missing example is updating an existing, asynchronously rendered geometry with more vertices or text. Or deleting geometry.


Same here.


Woah... I must have accidentally committed this somehow down the road... Whoops


див form-item тут уже лишний


@jpgarcia Will see that I get this done within 24 hours!


I'm still a littile bit unclear on this. Do you mean that we can't access certain parts of our application from every test, so ngMock stubs it out for us?


Thanks @smileart I have to put your name in the changelog. but I was in hurry and forgot. I should add.  Just recovering :-)


Editor issue - changed spaces to tab when I wasn't looking.


Teste


Currently travis build the verilog for vsim,fsim, and emulator and then runs the tests on emulator. If I read your Makefile correctly it seems like it only support building and running vsim.


Thanks Deepinder,

They are just trying to keep you on your toes :). I guess we'll find out when they add 3.4.7 or replace 3.4.6 when the install fails again.

Cheers Rob Rennison


ACK


Documented via https://github.com/qzind/qz-print/wiki/2.0-Override-RSVP#node-sha265.  Feedback welcome.


AUTO-MESSAGE - JSHint detected errors in the following files: webtask.js


Probably not related to this PR, but why do we need this dependency?


> Я правда думаю, что объединить compress и uncompress в одном файле возможно хорошая мысль.

Да. Но разнести по типам думаю у меня стоит.

> На сколько удобено такое определение:
using letter_t = size_t;
using text_t = vector;
Приходится в голове держать тип данных? Или это действительно удобно?

Это чтобы:

1. Сразу было понятно что за переменная. Если у неё безликий тип, вроде `int`, то он ничего не говорит. `size_t` использовать не для размеров даже хуже – получается тип врёт. А если у неё тип `letter_t`, сразу понятно что там внутри.
2. Менять в одном месте. А попробуй поменять тип букв, если они везде `size_t`, и `size_t` используется не только для букв. Придётся в каждом месте думать что же там внутри.
3. Для длинных типов вроде `vector_t<letter_t>` обозначение `text_t` короче и не требует спецсимволов – быстрее и проще набирать и читать.
4. Более того, иногда бывает полезно делать искусственно несовместимые типы для разных целей. (Это можно сделать, например, оборачивая совместимые типы в структуры с разными именами, содержащие по одному полю каждая.) Тогда, если ты ошибочно используешь неправильный тип, программа не скомпилируется. Полезно в первую очередь в интерфейсах. Например, в функции `memset()` часто путают размер области памяти и символ-заполнитель. Что проводит к неприятностям вплоть до уязвимостей. Если бы эти типы были не совместимыми, ошибки бы отсекались на этапе компиляции и проблем бы не было.

Пункты 1 и 2 перекликаются с аналогичными для именованных констант вместо магических чисел.


AFAIK, "bool" is not a C keyword.
It appeared with C++.


другой класс, это ведь уже внутренняя страница


We should probably still include common if we have a direct dependency on it?


если здесь уже h2, то где же h1? лучше поменять на h1


This is where I added material to Highlight the PAT project and it's successors.
PAT will close down and transfer over to Vacant Land project.


// FIXME: Regenerate if it expires?


добавь сюда класс, чтобы потом его использовать как селектор для стилизации


- 'Google Satellite' as the default layer
- accidentally caused a variable to be mis-spelled which is resolved on the next commit


Thanks for making it easier for us to write your task lists, GitHub :flushed:

- [x] Ship a feature that helps almost no one
- [ ] Respond to the dear-github letter


I agree that there should be before/after here.


TeamCity pull requests :: netty [Build 1125](https://garage.netty.io/teamcity/viewLog.html?buildId=5132&buildTypeId=pulls_netty&guest=1) is now running


Final changes added.


## deskelvinrepo


There may be a couple of `EAPI=6` -> `EAPI=5` additional changes. I'm unable to upgrade to `sage-7.0` in prefix because
```
!!! All ebuilds that could satisfy "~sci-libs/fplll-20151201" have been masked.
!!! One of the following masked packages is required to complete your request:
- sci-libs/fplll-20151201::sage-on-gentoo (masked by: EAPI 6)

The current version of portage supports EAPI '5'. You must upgrade to a
newer version of portage before EAPI masked packages can be installed.
(dependency required by "sci-mathematics/sage-7.0::sage-on-gentoo" [ebuild])
For more information, see the MASKED PACKAGES section in the emerge
man page or refer to the Gentoo Handbook.
```


I'm primarily asking before this will break anyone instantiating or casting to this for whatever reason.


Changing to unsigned integer allows negative values to be passed so the error checking can be handled by the pyserial module.


это не критично, но лучше использовать здесь более подходящий тип - date


this causes `npm run watch` to throw Error: Cannot resolve module 'electron'


то же - time


This is a a workaround for a regression in JRuby, not in Sequel, and Sequel's policy is to only release patch versions for regressions in the latest release of Sequel.  For example, if this was working in Sequel 4.29.0 and broke in 4.30.0, I would release 4.30.1, but that is not the case.

The 4.31.0 release should be next Monday, so you won't have to wait that long.


I need help trouble shooting the line where i try to delete the word from my array


added back


- added a generic exception handling module developed around 'revealing module' design pattern (https://addyosmani.com/resources/essentialjsdesignpatterns/book/#revealingmodulepatternjavascript)
- logs exception on functions at this stage and can be further extended


OK I will do the really narrow fix.


это заголовок


- un-did the accidental typo


You might even want to go further than this and do `rm -- "$host_data"`.


здесь семантичнее было бы использовать теги списка - каждая ссылка в своем li и все три  вместе - в ul


тут все таки лучше будет див , а не спан


112259371_UnitHeaterHWCoilUASizing (Nigusse) - i386-Windows-7-VisualStudio-12: OK (2055 of 2056 tests passed, 0 test warnings)

 * 6 tests had: AUD diffs.
 * 1 test had: EIO diffs.
 * 1 test had: ESO small diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: Table big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


я бы перенес `</p>` после ссылки. Иначе какой-то странный, незаконченный абзац получается


@DougGregor, mind reviewing this? It's a 2.2 regression, so I'm hoping to get it into that branch if it looks good.


the file isn't located in the repository, so why reference it? in fact, there's no evidence it has ever been located in either location... is it supposed to be created during compilation?


classic


Is this certain to fail? Otherwise `|| exit 1` might work.


- re-factored 'Main-UI.js' to get views and stores into separate modules
- the new module dependencies injected into 'Main-UI.js'
- application name and application folders specified so ExtJS can now load them without a reference on 'jsimports.html'
- the header view only has the basic structure for now, it still is included as a JSP include


It _would_ break people casting to this.
Almost all of its methods can be accessed through the interface, so they'd probably be using that.


- added comments in JSDOC format


On purpose?


- updated the views with correct top margins for the layers and map


- the store sorting, to-do


It seems to work yeah, I run a Stability Test and it takes longer to offline the big cluster and instead of offlining one by one like stock does, it takes the whole cluster down, and then it gets it all back again at once. Stock thermals offline them one by one in different intervals and take less time to do it. Also I set temp_threshold to 60 and it takes a ridiculous long time to offline the cluster, to a point where the little cluster is already throttled to 960MHz and the big one is juggling between 768-864-960MHz. Battery temperature is roughly ~34ºC at this point and everything is online and kicking. With the default 46 temp threshold the bug cluster normally offlines at ~31.5/32ºC. The phone is pretty cool though, throttling these cores help reduce heat more than I thought.


I am not pretty sure if this is necessary at all. Omni completion seems to use it but no effect is being done when returning the  current col. I have kept it because @yazgoo did something similar with the backspace matching.


- re-factored 'Main-UI.js'


PlantCompBaseClassAgain (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2088 of 2088 tests passed, 329 test warnings)

 * 334 tests had: AUD diffs.
 * 329 tests had: BND diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Crazy question, what is  `redirects` referencing? It's not a defined variable at this point yet, and it doesn't look like it's a method, so what is it?


Unfortunately, this is a backward-incompatible change. I hit it when running the verifier against our internal deployments. It's problematic because a given version of the verifier cannot talk to a version of presto that doesn't have this change and one that does.


Please, if you are involved in this project feel free to add your name to this list.


- updated the mark-up and associated events


Lazydexopt made fast boot after update, but all app open very slow, because odex starts after run it.


- sorting and grouping on 'featured layers' store now in play


PlantCompBaseClassAgain (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (956 of 956 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.85%25-green.svg)


But in `githug` I'm writing the other methods ;)


I should also point out that master is not in flux.  Sequel's policy is that the master branch on GitHub should always be in a releasable state.  So just use the master branch until 4.31.0 is available if you need this fix.  I don't think 4.31.0 will differ from the master branch unless someone reports a bug before the release.


Pretty sure this feature list is heavily influenced by 1990s BBS software. **Next up:** User profile signatures that are dumped into each comment.


по спекам вроде бы px в атрибуте `width` указываться не должны


`client` and `server` will be used to indicate client-side or server-side.
More importantly, it will be used in the middle of an artifactId e.g., `tachyon-client-keyvalue` or `tachyon-core-server`, so plural form sounds less ideal.


@theoriginaljuice This looks great, as long as it has been tested im happy.  As an aside, why are these longs and not ints or something? its just a baudrate like 112500 or something right?


There are a lot of EAPI 6 in the overlay now. I pushed the reversion for `fplll`.


`|ref kv|` should also be `|&kv|` here as well.


Looking at your failed Drone build, all you had to do was clean up your documentation. Bad form to dodge that just by turning this off.


Haha ok :) Thanks


fixed for me by
```
--- a/js/commonMenu.js
+++ b/js/commonMenu.js
@@ -7,7 +7,14 @@
 const AppConfig = require('./constants/appConfig')
 const AppActions = require('../js/actions/appActions')
 const messages = require('../js/constants/messages')
-const electron = require('electron')
+
+let electron
+try {
+  electron = require('electron')
+} catch (e) {
+  electron = global.require('electron')
+}
+
 let app
 if (process.type === 'browser') {
   app = electron.app
```


removed.


This should probably be configurable - if we want the robot to drive a long distance, it shouldn't just stop after 15 seconds.

```java
public DrivePid(double heading, double speed, double distance) {
  this(heading, speed, distance, 15);
}

public DrivePid(double heading, double speed, double distance, double timeout) {
  // ...
  setTimeout(timeout);
  // ...
}
```


все-таки section должен:

- иметь заголовок;
- иметь внутри **несколько** **равнозначных** элементов.

Считай section вариантом списка, который имеет заголовок. Здесь скорее просто `div`.


this fix things?


i really like hair metal :+1:


its much clearer in SourceTree.

you can always keep multiple remotes and choose which one to push to. the one called 'origin' is just like the default.

look at your `.git/config` file. that is all those apps are doing is changing that (using git commands).

sometimes I just open that up and edit some line rather than try to understand the correct git command.

```
[core]
	repositoryformatversion = 0
	filemode = true
	bare = false
	logallrefupdates = true
	ignorecase = true
	precomposeunicode = false
[remote "origin"]
	url = https://github.com/supercollider/supercollider.git
	fetch = +refs/heads/*:refs/remotes/origin/*
	fetch = +refs/pull/*/head:refs/remotes/origin/pr/*
[branch "master"]
	remote = origin
	merge = refs/heads/master
[submodule "external_libraries/nova-simd"]
	url = git://github.com/timblechmann/nova-simd.git
[submodule "external_libraries/nova-tt"]
	url = git://github.com/timblechmann/nova-tt.git
[submodule "external_libraries/hidapi"]
	url = git://github.com/sensestage/hidapi.git
[remote "crucialfelix"]
	url = https://github.com/crucialfelix/supercollider
	fetch = +refs/heads/*:refs/remotes/crucialfelix/*
[remote "supercollider"]
	url = git://github.com/supercollider/supercollider.git
	fetch = +refs/heads/*:refs/remotes/origin/*
	fetch = +refs/pull/*/head:refs/remotes/origin/pr/*
[remote "scztt"]
	url = git://github.com/scztt/supercollider.git
	fetch = +refs/heads/topic/coremidi-crash-fix:refs/remotes/scztt/topic/coremidi-crash-fix
[branch "3.7"]
	remote = origin
	merge = refs/heads/3.7
```


i feel like this kind of inconsistency in names has the potential to give us enormous headaches later (cf. `short` vs `short_name`)


I disagree with this one. One of the hallmarks of almost all the breakout venture successes (Google, Facebook, etc.) is that they had plenty of competition from well-funded startups. Peter Thiel's own book contradicts his argument.


That is *one* example of a differentiated value proposition, but only one. Another is "get to work with Dave Morin" etc. So I'd change to an e.g.,


yeh MFIFO does that already, it was very finicky on some games, im not sure just masking it will be enough, we might need to add checks on the qwc as well to make sure it doesn't go over the end of the scratchpad memory so we can wrap it properly.


Thanks for mentioning `IBAniamtable`.


I hadn't pulled in a while


I don't see `erlang` in the generated `rel/relx.config`


Should use the `PIDCommand(String name, double p, double i, double d)` constructor, so that the commands on SmartDashboard show up as `name` (i.e. "DrivePID to x degrees at y speed for z distance") instead of `org.usfirst.frc.team1294.robot.commands.DrivePid`.


Why are two booleans used for this option?


Add space between link and the word 'to' in last line of first paragraph.

"Instructions located in Configuring Basic Securityto further protect your data."


and another note for @opengapps/packagers, if you upload any new Hangouts, because of the DPI change you have to remove the old api+dpi entry manually, and make sure to include it in the commit (so that git will make it a "rename" operation, which saves a lot of git repo space)


There is no support for portable versions yet, see #88


Ok. I just used the mvn -B release:prepare release:perform command in the README. It was unclear if that was supposed to be done for a pull request or if this was for a real release.

Should I revert the pom.xml back to 2.1.5-SNAPSHOT and do another merge request?


Yup still not working with this revert.

@eyosen

Will try yours. Thanks.


In Task 4 part 1, it seems that your expression doesn't find the header because of ')' after {6}. In task 4 part 2, the header and + are extracted not the header and the sequence


AUTO-MESSAGE - JSHint detected errors in the following files: webtask.js


посмотри, без стилей эти хлебные крошки не считываются как таковые. думаю, что наиболее семантичным выходом будет добавление после каждой ссылки span'a с ">", потом мы его скроем с глаз людей, но для поисковиков это будет явный намек на то, что перед ними хлебные крошки, а не просто набор случайных ссылок. См. больше по теме: https://css-tricks.com/markup-for-breadcrumbs/


Ya not sure why it was originally written as long.... Everything tested okay.


I got this from aptoide, but isotopes was just *too* fast on apkmirror :-(


Let's sit down in the morning and get you rolling on this again. I'd like to see you finish it ASAP


/cc @yuchi This is for you.


But I see in mine:

```erlang
1> ToName = fun (Apps) -> [list_to_atom(hd(string:tokens(App,"-"))) || App <- Apps] end.
#Fun<erl_eval.6.54118792>
2> Deps = ToName([App ||         "deps/"++App <- filelib:wildcard(        "deps/*"), App /= "Makefile"]).
[base16,bear,couchbeam,cowboy,cowlib,detergent,ecsv,edown,
 eiconv,ejson,erlang,erlang_localtime,erlsom,erlydtl,escalus,
 exml,exmpp,folsom,fusco,gen_leader,gen_smtp,goldrush,gproc,
 hamcrest,hep,ibrowse,jesse,lager,lager_syslog|...]
3>
```


Hell yeah!


# Assignment 3 Grading Rubric (15 points total)

## Task Set 1

- [ ] Regex matches entire dinucleotide repeat (AT)5 and only the repeat (1 pt)
- [ ] Regex matches entire dinucleotide repeat (AT)5, only the repeat, and is different from above (1 pt)
- [ ] Regex matches entire dinucleotide repeat (AT)5, only the repeat, and is different both above (1 pt)
- [ ] Regex correctly matches all instances of `R` or `S` (1 pt)
- [ ] Regex (find and replace) matches all instances of `R` or `S` and replaces them with `N` (1 pt)

## Task Set 2

- [ ] Regex (find and replace) correctly reverses the order of the columns from 1,2,3,4 (as you see them) to 4,3,2,1 (1 pt)
- [ ] Regex (find and replace) correctly reverses the order of the columns from 1,2,3,4 (as you see them) to 1,2,4,3 (1 pt)
- [ ] Regex (find and replace) correctly replaces commas with tabs (1 pt)
- [ ] Regex (find and replace) correctly gives us the horrible format requested (1 pt)

## Task Set 3

- [ ] Regex (find and replace) correctly parses out only the lane number from the header (1 pt)
- [ ] Regex (find and replace) correctly parses out only the flowcell ID from the header (1 pt)
- [ ] Regex (find and replace) correctly parses any flowcell ID from the header (1 pt)

## Task Set 4

- [ ] Regex (find and replace) correctly extracts only the serial number from the fastq sequence (1 pt)
- [ ] Regex (find and replace) correctly turns the fastq into a fasta having the requested format (2 pt)

## Task Set 5

- [ ] Regex (find and replace) correctly extracts the (AT)5 repeat (Regex bliss)


Hmmm.  Just checking that we expect `setDebugJournalSink()` to only ever be called very early in the boot up process and never again.  Otherwise we have thread synchronization considerations and the `debugJournal` would get more complicated.  Is it worth putting a note to that effect in `Log.h`?  Maybe it's blindingly obvious.


пока все хорошо, но в будущем эти кнопки надо будет перенести в JS - ведь если он выключен, они не будут работать и потеряют смысл


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13106](https://teamcity.mesosphere.io/viewLog.html?buildId=114967&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:24


> Java doesn't have native constants for charsets, and this avoids having to add an UnsupportedEncodingException catch block everywhere we specify an encoding.

I'm not sure that's a good reason to avoid it though.  We could instantiate one in constants and use it everywhere.


112259371_UnitHeaterHWCoilUASizing (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (2055 of 2056 tests passed, 0 test warnings)

 * 6 tests had: AUD diffs.
 * 1 test had: EIO diffs.
 * 1 test had: ESO small diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: Table big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13099](https://teamcity.mesosphere.io/viewLog.html?buildId=114973&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:51


I don't think the response needs to be sarcastic about them shipping something. What I heard privately from various current and former GitHub employees made it sound like its really hard to ship anything.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13107](https://teamcity.mesosphere.io/viewLog.html?buildId=114968&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:01


> s_secret[0] = 0;

That treats s_secret as a string; the other 23 bytes aren't zeroed. But the use of memmove() and memset() on it elsewhere gives the impression that it should be used as a binary blob.

Should this assignment instead be s_secret ={0}; ?

Thanks


Anyway, if I filter out `erlang-syslog-1.0.1` and add it manually, `erlang` is not `rel/relx.conf` anymore but when I run `make build-release` I still get `Dependency erlang is specified as a dependency but is not reachable by the system.`


тебе не нужно указывать цвет по умолчанию. он будет черным даже на самых старых и невероятных браузерах.


Seems adding this is necessary to get the truth evaluation on both HCal towers/jets working again.


@laperry1

it gets generated via protobuf

just do a clean build and all is fine

"sudo updatedb && locate sap-api.pb.h" will show you, that the file exists.

https://github.com/CyanogenMod/android_hardware_ril/commit/09b05fe9489fe6699e4d196832d637d1dd933a56

together with

https://github.com/CyanogenMod/android_build/commit/947c4cdf1c7653b7aacafca38955234a5a33f364

move it to the new location.


this is unreachable


Typo:  "RecycerView.Adpter"?

Should be [RecyclerView.Adapter](https://developer.android.com/reference/android/support/v7/widget/RecyclerView.Adapter.html)  (both Recycler and Adapter need help :) )


as is this


But then we'd have that variable imported everywhere..?
Maybe it wasn't clear, but this apache library was not brought in to the project just for this. It was one we already had.


and this


…and this


обрати внимание - в барбершопе используется вполне конкретный шрифт. нужно указать его и похожие на него стандартные шрифты


Goo catch.


You're right. I don't have a problem with the toolbar improving discoverability of markdown during editing. It's more to Addy's point that this is nowhere near the top of our list and doesn't really address anyone's pain points. Bug reporters can get their points across without larger text.

It is easier to empathize with someone's problems when you know what those problems are. There are definitely good reasons for a company like Github to move slowly and avoid breaking things, perhaps that is driving their inability to work in the issues we care about. It would just be good to have some response acknowledging our letter.


great start. for now, i think the menu should also include the Bravery settings (i can add with #330) and a Help submenu with "submit an issue" and "about brave". in my linux windows manager, the application menu doesn't appear by default so i basically only use the hamburger menu.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13104](https://teamcity.mesosphere.io/viewLog.html?buildId=114965&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 214 Build time: 00:08:12


The following doc(s) have been deployed to the [resptable](http://resptable-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/sites/plan-configurations](http://resptable-static-docs.pantheon.io/docs/articles/sites/plan-configurations)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13105](https://teamcity.mesosphere.io/viewLog.html?buildId=114966&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:08:23


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13098](https://teamcity.mesosphere.io/viewLog.html?buildId=114975&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:08:25


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13101](https://teamcity.mesosphere.io/viewLog.html?buildId=114972&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:08:32


By default, single line blocks will be ignored. Is this line necessary? :)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13103](https://teamcity.mesosphere.io/viewLog.html?buildId=114964&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:08:38


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13102](https://teamcity.mesosphere.io/viewLog.html?buildId=114963&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:08:40


AUTO-MESSAGE - JSHint detected errors in the following files: webtask.js


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13108](https://teamcity.mesosphere.io/viewLog.html?buildId=114969&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:08:53


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13100](https://teamcity.mesosphere.io/viewLog.html?buildId=114971&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:09:07


Regardless of how hard it is to ship, the mere fact that they didn't publicly acknowledge and address the note in 2 weeks (HN thread don't count) is enough to know they don't care.


We might want to add some other checks here to make sure that the baselineColumns and baselineValues have not been called. As well as check this flag in those methods to make sure that no invalid combinations of settings are allowed to be called (even if they might "work' by just ignoring some of the options).

It is possible that this could be accomplished without an extra flag, as there are already methods for providing baselineTypes and signaling that the result set should be empty. I'm not too picky about it, but as there are already a good number of options here I would rather try to prevent unneeded APIs from being added if possible.

What do you think?


то же, что с color:#000000. все заголовки по умолчанию полужирные, и, если ты не используешь CSS reset, указывать их полужирность излишне.


See #1540


why the `float` indeed.


no pos esta bien feo


present: true is default as well :)


"discardable"?


> `Rooms.rooms[room.id]`
> `Rooms.rooms[room.id]`
> `Rooms.rooms[room.id]`
> not `room`


Thank you for such quick fix Valeriy, appreciated!


Thanks :P


style: short is default


style: lowercase is default


It appears this commit is necessary to get HCal tower and jet truth evaluation working again.


The following doc(s) have been deployed to the [1030config](http://1030config-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/sites/plan-configurations](http://1030config-static-docs.pantheon.io/docs/articles/sites/plan-configurations)


For task 5 the find expressions didn't seem to match the header/sequence data, I don't know if this is just a problem I'm having with atom because initially I wasn't able to get Alicia's to match either


This should really be `bail-out` (vp) not `bailout` (n)


I like it!


leading_underscore: false
filename_extension: false
both are deafult


V1 packages don't get modified


TeamCity pull requests :: netty [Build 1125](https://garage.netty.io/teamcity/viewLog.html?buildId=5132&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6398, ignored: 23 Build time: 00:42:51


ignore me :p


character: space
width: 2
Both are default


мне кажется, здесь aside нехорош. aside обычно - это второстепенный контент, не связанный с основным. здесь же фильтры явно связаны по смыслу с товарами справа, непосредственно влияют на их состав. лучше просто div


Awesome! thanks for clarifying and your work on sequel.

> On Jan 27, 2016, at 6:01 PM, Jeremy Evans <notifications@github.com> wrote:
>
> I should also point out that master is not in flux. Sequel's policy is that the master branch on GitHub should always be in a releasable state. So just use the master branch until 4.31.0 is available if you need this fix. I don't think 4.31.0 will differ from the master branch unless someone reports a bug before the release.
>
> —
> Reply to this email directly or view it on GitHub.
>


this is disabled, but "style: exclude_zero" is added. should enabled be true?
style: exclude_zero is default.


> But then we'd have that variable imported everywhere..?

Yes, but most classes already import Constants, no.

> Maybe it wasn't clear, but this apache library was not brought in to the project just for this. It was one we already had.

I'm not sure how this is relevant to the discussion.


you can keep these sorts of lists if you want, but honestly they really get out of date so we just prefer to refer people to the github graph, e.g. https://github.com/jvican/ensime-vim/graphs/


LGTM


It is a valid integer, leading zeroes are unuasl but valid for integers in normal life. They just get confusing in computing when they sometimes get treated as octal instead of decimal ;-)

My testing so far has shown that the ELSE (although needed) does not completely fix the problem. I'm still trying to determine what else (no pun intended) is needed.


enabled is set to false, but force_nesting is true. should enabled be true?
force_nesting: true is default.


ACK 920704b


I think you copied a little bit too much. All of the pep8 stuff and the mode keybindings is pep8 / python related :)


I think in current situation, it is best to roll back to original patch, until "proper" fix is found.


It's relevant because I do not understand your concern over an import.


allow_leading_underscore: true
convention: hyphenated_lowercase
Both are default


Do we need to output this one? If it’s just for now call it `volcano_subset.png`


не проблема совсем, но если хочешь делать свое оформление для чекбоксов и радиокнопок - input должен стоять до label'a (не внутри) и у последнего должен быть атрибут for, совпадающий по значению с id input'a


Will you need to add a Distinct() to any
```
public IList<string> Scope { get; } = new List<string>();
```
access just in case someone adds your default scopes again?


Isn't that favicon missing quite a bit of the top/bottom of the rings?

Also @samozzy pointed out in [#28-comment](https://github.com/nottinghamtec/Main-Website/issues/28#issuecomment-175891142) that you should have a .ico and a .png for this, ideally with a transparent background.


And simply call this `volcano.png`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13111](https://teamcity.mesosphere.io/viewLog.html?buildId=115014&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:03:58


Since this is a real API call, should we increase value of DSAPIDefaultTimeout?


радиокнопки - как чекбоксы, просто с `type="radio"`


Missing a closing parenthesis ;)


Why we don't increase value of DSAPIDefaultTimeout?


The names of these enum values sound a bit too generic to be made public. Should I rename them to `POS_BEFORE`/`POS_AFTER`?


атрибут name у всех input'ов одной группы (Производители) должен быть одинаков


Oops, yes


border-top-left-radius
border-top-right-radius
border-top-**left**-radius
border-top-**right**-radius


I assume you mean the way the context is changed before drawing some points? If so, I did it that way for optimisation purposes.. the less calls made to the canvas context, the better. Here's a couple of quick JSPerfs to prove it! https://jsperf.com/canvascontextcalling https://jsperf.com/canvas-context-switching

In Chrome it runs about 10% faster for me in both cases when I avoid changing the context when I don't have to (interestingly, no significant between the difference in Firefox!! clearly some optimisation going on in Chrome and not FF..).

That being said, I'm happy to pass the context styles as parameters of the ``_drawPoints`` function?


Thanks for the feedback! Always good to know whats missing. The examples are going to follow soon :) First fixing bugs, then reading and documenting the code and then examples and documentation!

>And vice versa, 3d signal positions to 2d for hit point detection outside of OpenGL.

What exactly do you mean by this? So do you know how I'm doing hitpoint detection with opengl (which I do via the formerly called `mouse_hover_id` signal and now `mouse2id`, where id is the renderobject your mouse is hovering over) and you want an alternative which doesn't rely on OpenGL? Or do you just want to know how I do hitpoint detection?

>Another possibly missing example is updating an existing, asynchronously rendered geometry with more vertices or text. Or deleting geometry.

What exactly do you mean by asynchronously?

It's mostly all via signals! But I better create a few examples over the next days!


ignore_unspecified: false is default


Is this a bug?


I gave this a try, but it didn't work due to a small typo. This line should be StringIO and not StringIo - when I tested it out on my mac it failed without that change in both py2 and py3. When I corrected that issue it worked with py2 but still not py3 for some reason...


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13112](https://teamcity.mesosphere.io/viewLog.html?buildId=115015&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 174 Build time: 00:07:22


Oh god, something's gone dodgy there. Standby.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13110](https://teamcity.mesosphere.io/viewLog.html?buildId=114995&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:08:25


@rschmukler --
There should be some padding added so both label and error message can be displayed

Error Message active:
![image](https://cloud.githubusercontent.com/assets/2799090/12632455/e9681b3e-c50c-11e5-8dc2-984451794b98.png)

Error Message inactive:
![image](https://cloud.githubusercontent.com/assets/2799090/12632463/02e1321c-c50d-11e5-956a-6340f40d00b3.png)

Also, the provided demo only shows the error message if something is selected then cleared. But clicking on it, and not selecting anything doesnt change anything. Removing the ng-if $dirty clears this up.


Agreed, there's no good reason for the difference. I'll make these blocks more consistent.


Should I move this to `con.c`?


no extra_properties are listed


If you do it this way you have to do a Distinct on the scope List when in FormatScope to account for anyone who added the scopes again.


@ligadata-dan , @ligadata-pokuri , @ligadata-william

Note that that this method is defined the other way in the trait:

  /** Retrieve a specific MessageDef from Metadata Store
    *
    * @param objectName Name of the MessageDef
    * @param version  Version of the MessageDef
    * @param formatType format of the return value, either JSON or XML
    * @param userid the identity to be used by the security adapter to ascertain if this user has access permissions for this
    *               method. If Security and/or Audit are configured, this value must be a value other than None
    * @return the result as a JSON String of object ApiResult where ApiResult.resultData contains
    * the MessageDef either as a JSON or XML string depending on the parameter formatType
    */
  def GetMessageDef( objectName:String,version:String, formatType: String, userid: Option[String]) : String

We should probably correct the trait as well.


Addressed comments here


This enables the feature for everybody. I'm not sure if that's a good idea. What's your process on iterating on an experimental feature? feature branch? config setting?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13109](https://teamcity.mesosphere.io/viewLog.html?buildId=114994&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:09:44


This would need to be `flowType`, right? But I can fix that if you finally move on with it ;)


enabled is false. are the other properties necessary?
allow_element_with attribute/class/id: false are default.


Import library is different than importing a constant.  Byte to String conversion is supported in Java and I've seen no valid argument for avoiding it.  There may be valid reasons, I just haven't seen one.  We've been using Java's internal charset conversion for a long time.  I've never used Apache's.  I don't think the original question is unreasonable.


This could just be `padding: 16px 16px 0;`


Not sure why you changed this away from forwarding references back(?) to const references. It could save a copy on the `args`.
Here's how I'd write it:
```
template<class... Args>
Json::Value
Env::rpc(std::string cmd, Args&&... args)
{
    std::vector<std::string> vs{std::move(cmd),
        std::forward<Args>(args)...};
    return do_rpc(vs);
}
```
But I don't think a few extra string copies in tests is worth much stress over.


In theory this also conflicts with the normal propType handler, right? How are you handling this?


Blank


convention: hyphenated_lowercase is default


@vinniefalco: I don't think so.  I read it as an optimization so we don't keep re-building the `uint256` each time around the loop.


``` protected virtual string FormatScope()
        {
            // OAuth2 3.3 space separated
            return string.Join(" ", Options.Scope.Distinct());
        }
```

Note Facebook overrides this method so need to do there too

```protected override string FormatScope()
        {
            // Facebook deviates from the OAuth spec here. They require comma separated instead of space separated.
            // https://developers.facebook.com/docs/reference/dialogs/oauth
            // http://tools.ietf.org/html/rfc6749#section-3.3
            return string.Join(",", Options.Scope.Distinct());
        }


It's not about use cases, it's more of plugin dependency loading. If I have an RPG plugin providing a hefty skills api, other plugins should be loading after mine if they depend on it being semi-available. Likewise, the same plugin can be dictating that it knows that it should load after PEX or before some other plugin requesting some services.


Android Studio, __powered by Intellij IDEA__


allow_single_line_rule_sets: true is default


It was just for testing purposes. Will do


header не имеет смысла использовать, если внутри только один элемент. Это группирующий тег, дающий поисковикам понять, что все содержимое внутри принадлежит к какой-то смысловой группе


Your code sucks.


Hehe


Another note, Input doesnt color the placeholder text red:
![image](https://cloud.githubusercontent.com/assets/2799090/12632578/e47b2bb0-c50d-11e5-8199-e7e488a711ff.png)


:tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada: :tada:


style: space is default