@gforcada Jenkins CI reporting about code analysis
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/catalog.py Imports are incorrectly sorted.
plone/app/discussion/catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/catalog.py:0:1: I001 found unsorted imports
plone/app/discussion/catalog.py:81:17: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/comment.py Imports are incorrectly sorted.
plone/app/discussion/comment.py:0:1: I001 found unsorted imports
plone/app/discussion/comment.py:65:28: Q000 Remove bad quotes.
plone/app/discussion/comment.py:160:40: Q000 Remove bad quotes.
plone/app/discussion/comment.py:162:30: S001 found %s formatter
plone/app/discussion/comment.py:166:48: S001 found %s formatter
plone/app/discussion/comment.py:201:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
plone/app/discussion/comment.py:295:21: Q000 Remove bad quotes.
plone/app/discussion/contentrules.py:0:1: C101 Coding magic comment not found
plone/app/discussion/contentrules.py:18:5: E731 do not assign a lambda expression, use a def
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/conversation.py Imports are incorrectly sorted.
plone/app/discussion/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/conversation.py:0:1: I001 found unsorted imports
plone/app/discussion/conversation.py:57:27: Q000 Remove bad quotes.
plone/app/discussion/conversation.py:431:29: Q000 Remove bad quotes.
plone/app/discussion/events.py:0:1: C101 Coding magic comment not found
plone/app/discussion/interfaces.py:133:17: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:159:65: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:213:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:239:21: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:257:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:261:23: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:268:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:271:23: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:279:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:296:25: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/patches.py Imports are incorrectly sorted.
plone/app/discussion/patches.py:0:1: C101 Coding magic comment not found
plone/app/discussion/patches.py:0:1: I001 found unsorted imports
plone/app/discussion/patches.py:25:46: Q000 Remove bad quotes.
plone/app/discussion/subscribers.py:0:1: C101 Coding magic comment not found
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/testing.py Imports are incorrectly sorted.
plone/app/discussion/testing.py:0:1: C101 Coding magic comment not found
plone/app/discussion/testing.py:0:1: I001 found unsorted imports
plone/app/discussion/testing.py:17:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:18:1: B901 blind except: statement
plone/app/discussion/testing.py:19:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:80:14: Q000 Remove bad quotes.
plone/app/discussion/testing.py:110:10: Q000 Remove bad quotes.
plone/app/discussion/testing.py:113:10: Q000 Remove bad quotes.
plone/app/discussion/testing.py:119:10: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tool.py Imports are incorrectly sorted.
plone/app/discussion/tool.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tool.py:0:1: I001 found unsorted imports
plone/app/discussion/upgrades.py:0:1: C101 Coding magic comment not found
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_catalog.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_catalog.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_catalog.py:77:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:95:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:102:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:123:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:130:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:146:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:161:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:179:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:187:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:200:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:212:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:223:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:231:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:238:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:265:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:284:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:292:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:332:40: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:365:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:371:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:414:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:421:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:435:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:435:49: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:538:25: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_comment.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_comment.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_comment.py:44:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:45:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:46:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:95:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:97:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:103:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:125:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:131:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:132:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:136:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:137:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:159:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:167:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:180:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:183:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:188:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:232:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:263:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:268:23: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:305:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:330:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:367:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:403:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:438:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:446:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:455:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:464:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_comments_viewlet.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_comments_viewlet.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_comments_viewlet.py:52:45: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:97:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:111:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:119:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:120:64: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:169:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:183:59: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:185:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_comments_viewlet.py:193:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:195:64: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:237:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:251:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:295:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:310:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:357:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:406:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:441:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:522:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:523:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:528:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:533:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:534:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:535:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:546:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:547:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:548:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:604:63: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_contentrules.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_contentrules.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_contentrules.py:40:24: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:41:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:42:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:43:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:98:38: S001 found %s formatter
plone/app/discussion/tests/test_contentrules.py:102:38: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:103:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:104:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:32:18: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:39:56: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_conversation.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_conversation.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_conversation.py:27:1: B901 blind except: statement
plone/app/discussion/tests/test_conversation.py:85:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:87:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:90:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:437:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:442:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:447:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:452:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:842:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:846:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:851:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_events.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_events.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_events.py:89:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:142:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:155:38: S001 found %s formatter
plone/app/discussion/tests/test_events.py:175:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_indexers.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_indexers.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_indexers.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_indexers.py:42:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:43:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:50:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:51:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:58:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:59:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:121:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:122:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:152:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:152:41: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_moderation_view.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_moderation_view.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_moderation_view.py:78:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:86:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:94:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_notifications.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_notifications.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_notifications.py:35:44: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:59:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:81:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:82:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:97:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:127:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:142:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:147:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:174:44: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:222:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:223:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:229:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:233:13: S001 found % formatter
plone/app/discussion/tests/test_robot.py:0:1: C101 Coding magic comment not found
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_workflow.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_workflow.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_workflow.py:90:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_workflow.py:129:38: S001 found %s formatter
plone/app/discussion/tests/test_workflow.py:195:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/captcha.py Imports are incorrectly sorted.
plone/app/discussion/browser/captcha.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/captcha.py:54:39: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/comment.py Imports are incorrectly sorted.
plone/app/discussion/browser/comment.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/comment.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/comment.py:49:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:49:20: S001 found %s formatter
plone/app/discussion/browser/comment.py:51:41: S001 found %s formatter
plone/app/discussion/browser/comment.py:57:10: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:96:52: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:99:40: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:99:58: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/comments.py Imports are incorrectly sorted.
plone/app/discussion/browser/comments.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/comments.py:84:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:90:35: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:124:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:125:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:126:42: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:128:1: C901 'CommentForm.handleComment' is too complex (17)
plone/app/discussion/browser/comments.py:137:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:138:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:210:53: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:258:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:259:22: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:282:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:283:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:359:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:362:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:370:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:378:37: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:448:20: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:448:21: S001 found %s formatter
plone/app/discussion/browser/comments.py:494:17: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/controlpanel.py Imports are incorrectly sorted.
plone/app/discussion/browser/controlpanel.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/controlpanel.py:26:10: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:84:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:85:48: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:90:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:91:40: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:91:41: S001 found %s formatter
plone/app/discussion/browser/controlpanel.py:107:46: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:113:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:120:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:122:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:125:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:128:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:132:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:138:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:164:46: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/conversation.py Imports are incorrectly sorted.
plone/app/discussion/browser/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/conversation.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/conversation.py:15:1: B901 blind except: statement
plone/app/discussion/browser/conversation.py:27:1: C901 'ConversationView._enabled_for_archetypes' is too complex (14)
plone/app/discussion/browser/conversation.py:133:12: P002 found "hasattr", consider replacing it
plone/app/discussion/browser/conversation.py:133:29: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/migration.py Imports are incorrectly sorted.
plone/app/discussion/browser/migration.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/migration.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/migration.py:31:1: C901 'View.__call__' is too complex (32)
plone/app/discussion/browser/migration.py:38:19: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:42:16: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:74:26: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:76:31: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:77:22: S001 found %s formatter
plone/app/discussion/browser/migration.py:175:25: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:175:26: S001 found %s formatter
plone/app/discussion/browser/migration.py:185:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:185:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:199:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:199:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:200:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:200:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:201:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:201:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:203:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:204:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:222:21: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:223:31: S001 found %s formatter
plone/app/discussion/browser/migration.py:231:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:232:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:233:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:233:28: S001 found %s formatter
plone/app/discussion/browser/migration.py:240:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:242:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:243:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:244:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:246:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:247:13: S001 found % formatter
plone/app/discussion/browser/migration.py:251:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:251:18: S001 found %s formatter
plone/app/discussion/browser/migration.py:255:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:256:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:260:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:261:17: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/moderation.py Imports are incorrectly sorted.
plone/app/discussion/browser/moderation.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/moderation.py:104:19: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:105:22: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:138:17: W503 line break before binary operator
plone/app/discussion/browser/moderation.py:143:17: W503 line break before binary operator
plone/app/discussion/browser/moderation.py:182:15: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:183:18: Q000 Remove bad quotes.
plone/app/discussion/browser/traversal.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/traversal.py:32:20: Q000 Remove bad quotes.

```
You can always test the configuration using: qa.cfg


Adds some random dust... btw putting 101 there was a mistake


This ReconstituteInterface is not really needed imho. @danizord may confirm.


LGTM as long as it stays consistent with the change in Bazel.


Perhaps we should just remove these commented out headers?


Here we change stats to be 97% of origional value


Potential addition:

> Should be used in conjunction with the `purge` parameter to replace the default `sources.list`.  Failure to do so could cause "duplicate source" warnings when running Apt.


Remove?


Charon requested a 20% chance for a 5 second lasting Shadowflame debuff.. here ya go


А зачем каждый раз при добавлении одного нового элемента перерисововать весь список, навешивать все хендлеры и удалять всю таблицу? Думаю будет оптимальней добавить новый элемент в сторедж и в табличку.


Done.


dunno what happened here


@danizord could you please remind me when exactly we'd suppose to use constructor directly or a specialized method? Value Object => constructor, otherwise specialized method?


Здесь нет fieldset. Браузеры рисуют вокруг формы рамку,  которую к тому же крайне сложно стилизовать. Вот [твоя страница  ](https://htmlacademy-htmlcss.github.io/115748-sedona/3/hotels.html)


Adding file includes for the VS project


This looks good to me. Will merge and test.


Ok, these two tests definitely cover every case. But wouldn't it be better to create tests for the several cases separately? Also, not testing which errors are thrown also leaves room for confusion :-)


Sorry, it did this automatically.


Why does `make_move` raise an exception and `ai_move` does not? Perhaps the behaviour should be made consistent in this regard (either both shall raise or neither one should).


It will be part of the 1.10 release, which I think we agreed to will also be merged into master.


Remove Android items.


This buff was called twice


I'd say that you don't need to trim again. You are already doing that in the createNewClient so I think we can consider the data has been cleaned already. Here you're getting data from DB so it should already be trimed.


Looks like sometimes the shell glob expands out and includes a directory, which you're not filtering.


To summarize an off-line discussion, the `Mono<Void>` returned from `execute` is quite similar in effect to `onSent` except it completes after the server starts sending the response status/headers which might close in timing the time after the headers/body are written but not necessarily so.

In any case we don't have any use cases for `onSent` so it's not clear it is needed. Moreover `ServerHttpResponse` now has a [beforeCommit](https://github.com/spring-projects/spring-reactive/blob/937b173904767cd647261ffac5b25e3809d0da40/src/main/java/org/springframework/http/server/reactive/ServerHttpResponse.java#L44) hook which is much more likely to be useful on the client side as well for an interceptor implementation. In that case `beforeCommit` can be moved up to `ReactiveHttpOutputMessage`.

For now I think it would be important for consistency for `ClientHttpRequest` to extend `ReactiveHttpOutputMessage`. As for the `Mono<Void` from `setBody` it could be implemented correctly but we could also just choose to intentionally return `Mono.empty()` and indicating clearly that the call to `setBody` is a simple sync operation and nothing happens until `execute`.


The new data import stuff will soon be enabled in the daily builds (and thus have quite a bit of visibility). Let's hide any importers that are not yet implemented (i.e. just call .remove() on things not yet implemented).


Thank you for creating the issue.  Specifically, if I try to use a global environment variable or global password in a Scriptler parameter, it does not get expanded.


The type of redirect URIs is array, I suppose this means that it needs to be saved as array in persistence, so when you reconstitute it it should already be an array. I'm not sure what is the most correct though...


Not a needed interface imho.


Какие отступы? Мне требуется чуть больше информации)


Remove commented out code.


Remove midi items.


Make the interface have default methods, then you can remove this implementation


@gforcada Jenkins CI reporting about code analysis
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/catalog.py Imports are incorrectly sorted.
plone/app/discussion/catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/catalog.py:0:1: I001 found unsorted imports
plone/app/discussion/catalog.py:81:17: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/comment.py Imports are incorrectly sorted.
plone/app/discussion/comment.py:0:1: I001 found unsorted imports
plone/app/discussion/comment.py:65:28: Q000 Remove bad quotes.
plone/app/discussion/comment.py:160:40: Q000 Remove bad quotes.
plone/app/discussion/comment.py:162:30: S001 found %s formatter
plone/app/discussion/comment.py:166:48: S001 found %s formatter
plone/app/discussion/comment.py:201:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
plone/app/discussion/comment.py:295:21: Q000 Remove bad quotes.
plone/app/discussion/contentrules.py:0:1: C101 Coding magic comment not found
plone/app/discussion/contentrules.py:18:5: E731 do not assign a lambda expression, use a def
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/conversation.py Imports are incorrectly sorted.
plone/app/discussion/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/conversation.py:0:1: I001 found unsorted imports
plone/app/discussion/conversation.py:57:27: Q000 Remove bad quotes.
plone/app/discussion/conversation.py:431:29: Q000 Remove bad quotes.
plone/app/discussion/events.py:0:1: C101 Coding magic comment not found
plone/app/discussion/interfaces.py:133:17: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:159:65: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:213:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:239:21: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:257:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:261:23: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:268:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:271:23: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:279:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:296:25: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/patches.py Imports are incorrectly sorted.
plone/app/discussion/patches.py:0:1: C101 Coding magic comment not found
plone/app/discussion/patches.py:0:1: I001 found unsorted imports
plone/app/discussion/patches.py:25:46: Q000 Remove bad quotes.
plone/app/discussion/subscribers.py:0:1: C101 Coding magic comment not found
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/testing.py Imports are incorrectly sorted.
plone/app/discussion/testing.py:0:1: C101 Coding magic comment not found
plone/app/discussion/testing.py:0:1: I001 found unsorted imports
plone/app/discussion/testing.py:17:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:18:1: B901 blind except: statement
plone/app/discussion/testing.py:19:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:80:14: Q000 Remove bad quotes.
plone/app/discussion/testing.py:110:10: Q000 Remove bad quotes.
plone/app/discussion/testing.py:113:10: Q000 Remove bad quotes.
plone/app/discussion/testing.py:119:10: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tool.py Imports are incorrectly sorted.
plone/app/discussion/tool.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tool.py:0:1: I001 found unsorted imports
plone/app/discussion/upgrades.py:0:1: C101 Coding magic comment not found
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_catalog.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_catalog.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_catalog.py:77:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:95:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:102:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:123:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:130:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:146:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:161:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:179:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:187:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:200:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:212:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:223:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:231:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:238:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:265:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:284:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:292:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:332:40: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:365:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:371:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:414:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:421:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:435:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:435:49: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:538:25: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_comment.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_comment.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_comment.py:44:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:45:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:46:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:95:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:97:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:103:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:125:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:131:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:132:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:136:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:137:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:159:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:167:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:180:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:183:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:188:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:232:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:263:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:268:23: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:305:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:330:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:367:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:403:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:438:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:446:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:455:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:464:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_comments_viewlet.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_comments_viewlet.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_comments_viewlet.py:52:45: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:97:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:111:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:119:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:120:64: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:169:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:183:59: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:185:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_comments_viewlet.py:193:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:195:64: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:237:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:251:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:295:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:310:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:357:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:406:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:441:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:522:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:523:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:528:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:533:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:534:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:535:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:546:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:547:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:548:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:604:63: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_contentrules.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_contentrules.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_contentrules.py:40:24: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:41:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:42:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:43:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:98:38: S001 found %s formatter
plone/app/discussion/tests/test_contentrules.py:102:38: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:103:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:104:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:32:18: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:39:56: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_conversation.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_conversation.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_conversation.py:27:1: B901 blind except: statement
plone/app/discussion/tests/test_conversation.py:85:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:87:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:90:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:437:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:442:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:447:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:452:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:842:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:846:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:851:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_events.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_events.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_events.py:89:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:142:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:155:38: S001 found %s formatter
plone/app/discussion/tests/test_events.py:175:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_indexers.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_indexers.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_indexers.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_indexers.py:42:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:43:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:50:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:51:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:58:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:59:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:121:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:122:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:152:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:152:41: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_moderation_view.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_moderation_view.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_moderation_view.py:78:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:86:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:94:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_notifications.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_notifications.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_notifications.py:35:44: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:59:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:81:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:82:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:97:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:127:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:142:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:147:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:174:44: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:222:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:223:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:229:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:233:13: S001 found % formatter
plone/app/discussion/tests/test_robot.py:0:1: C101 Coding magic comment not found
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_workflow.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_workflow.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_workflow.py:90:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_workflow.py:129:38: S001 found %s formatter
plone/app/discussion/tests/test_workflow.py:195:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/captcha.py Imports are incorrectly sorted.
plone/app/discussion/browser/captcha.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/captcha.py:54:39: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/comment.py Imports are incorrectly sorted.
plone/app/discussion/browser/comment.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/comment.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/comment.py:49:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:49:20: S001 found %s formatter
plone/app/discussion/browser/comment.py:51:41: S001 found %s formatter
plone/app/discussion/browser/comment.py:57:10: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:96:52: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:99:40: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:99:58: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/comments.py Imports are incorrectly sorted.
plone/app/discussion/browser/comments.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/comments.py:84:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:90:35: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:124:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:125:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:126:42: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:128:1: C901 'CommentForm.handleComment' is too complex (17)
plone/app/discussion/browser/comments.py:137:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:138:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:210:53: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:258:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:259:22: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:282:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:283:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:359:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:362:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:370:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:378:37: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:448:20: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:448:21: S001 found %s formatter
plone/app/discussion/browser/comments.py:494:17: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/controlpanel.py Imports are incorrectly sorted.
plone/app/discussion/browser/controlpanel.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/controlpanel.py:26:10: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:84:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:85:48: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:90:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:91:40: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:91:41: S001 found %s formatter
plone/app/discussion/browser/controlpanel.py:107:46: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:113:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:120:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:122:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:125:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:128:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:132:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:138:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:164:46: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/conversation.py Imports are incorrectly sorted.
plone/app/discussion/browser/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/conversation.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/conversation.py:15:1: B901 blind except: statement
plone/app/discussion/browser/conversation.py:27:1: C901 'ConversationView._enabled_for_archetypes' is too complex (14)
plone/app/discussion/browser/conversation.py:133:12: P002 found "hasattr", consider replacing it
plone/app/discussion/browser/conversation.py:133:29: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/migration.py Imports are incorrectly sorted.
plone/app/discussion/browser/migration.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/migration.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/migration.py:31:1: C901 'View.__call__' is too complex (32)
plone/app/discussion/browser/migration.py:38:19: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:42:16: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:74:26: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:76:31: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:77:22: S001 found %s formatter
plone/app/discussion/browser/migration.py:175:25: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:175:26: S001 found %s formatter
plone/app/discussion/browser/migration.py:185:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:185:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:199:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:199:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:200:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:200:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:201:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:201:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:203:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:204:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:222:21: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:223:31: S001 found %s formatter
plone/app/discussion/browser/migration.py:231:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:232:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:233:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:233:28: S001 found %s formatter
plone/app/discussion/browser/migration.py:240:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:242:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:243:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:244:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:246:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:247:13: S001 found % formatter
plone/app/discussion/browser/migration.py:251:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:251:18: S001 found %s formatter
plone/app/discussion/browser/migration.py:255:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:256:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:260:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:261:17: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/moderation.py Imports are incorrectly sorted.
plone/app/discussion/browser/moderation.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/moderation.py:104:19: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:105:22: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:138:17: W503 line break before binary operator
plone/app/discussion/browser/moderation.py:143:17: W503 line break before binary operator
plone/app/discussion/browser/moderation.py:182:15: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:183:18: Q000 Remove bad quotes.
plone/app/discussion/browser/traversal.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/traversal.py:32:20: Q000 Remove bad quotes.

```
You can run that yourself using buildout.coredev ``experimental/qa.cfg`` config file.


TeamCity Waterfall :: Build [Build 48](https://tc.demonwav.com/viewLog.html?buildId=238&buildTypeId=Waterfall_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 46 Build time: 00:01:01


Shouldn't this file be removed?


I won't say it for all the other cases, but I feel that the coalesce operator is useless here. it does not make sense to save a scope without an id, name and isDefault. We should not assume that the persistence have saved a client without id, description or isDefault. Therefore here you should assume the data is present. The same for all other "reconstitute" method.


Not exactly. strin is a list of arguments, so this is checking if '\x00' is included in those arguments (if it is, subprocess call will crash).


You made this change just in the branch `indent-style`. :-) I'd also suggest adding a test for this, so we won't run into the problem again.


Константы пишут в Upper case, например Constants.SUCCESS, Constants.API_KEY и т.д.


I'm thinking this could be named `TablePropertyHandle`. Will ask @dain


@Qeole there nothing ever wrong with modifying code, don't worry :-)


THose didn't work


baller


This works, but we're going to talk about the memory implications here for very long, tight loops.


Желательно всю эту логику вынести в отдельный класс.


The more I see this flesh out the more I dislike it

The old config had the advantage of being mostly automated, which is now lost with this change.
Also the bare minimum previously needed to be changed to create a unique board to ones liking is now spread out across the file.


Lol. I just saw that.


we can omit the ( ) here :)


I'd like it better if:
1. you'd rename `ic` to something upper case, like `L` or `C`
2. instead of `i !== ic ` the less confusing `i < ic` were used
3. you'd read the elems array into a local variable
4. you'd use errors.push.apply(errors, ...) instead

Apart from these mostly idiomatic and performance related issues, I wonder if it is a good idea to collect all the errors, of all the elements. We're not complementing errors with the property path/index in the model at which they occurred, so it might not be very useful to accumulate errors like this: wouldn't be perceptible where the errors would came from.

So I'd go for returning the error(s) of the first failed item.


Whoops - that should've been num_quer**ies**.


Yeah. True.


There is a reason we do it. We'll talk about it on Friday.


You probably need to change the derived classes (to add using directive) or change Reset(node) to something like ResetWithNode(node), but it would work.

I would prefer to skip this intermediate step just modify those few extensions.


TeamCity Waterfall :: Build [Build 49](https://tc.demonwav.com/viewLog.html?buildId=239&buildTypeId=Waterfall_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 46 Build time: 00:01:01


Retrieved from issues tab:
Describe how a new user can install a new application #103


@jtormey lmk if there's a more angular way to do this/im thinking about the wrong way. ty


I removed the `osx_template` that had the `selector` key instead of the `role` key in the menu item objects and changed those keys here for OSx.


We'll talk about why this might be bad while we're talking about `NSArray` and `NSMutableArray`.


Can you correct the test def JSON file:
Advanced/tpcds/tpcds_sf1/original/not_supported/tpcds_parquet_sf1.json

Change the source to Datasources/tpcds/sf1/parquet


can we pull the loop inside of the requestAnimationFrame?


TeamCity Waterfall :: Build [Build 50](https://tc.demonwav.com/viewLog.html?buildId=240&buildTypeId=Waterfall_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 46 Build time: 00:01:07


Remove MIDI items.


@matcracker ti dispiacerebbe provare ora? xD


Just leave shutdown.target?


Not testing the case where element validation fails and its errors returned (or accumulated, depending on how you end up implementing it).


- Тут все ок. Ты сетаешь рутовый элемент. Кстати rootElSelector - это не селектор а jQuery элемент. Так как ты присылаешь не строку, а $(...). Думаю будет логичнее переименовать, либо передавать строку. Но далее, ты этот селектор теряешь. В частности, в функции setElements() ты еще снова ищешь в глобальном скоупе. А ведь он уже был найден ранее. В общем, здесь нужно его реюзнуть.


Remove commented out function declarations.


Fixed.


Remove commented out files.


Should we filter the return value earlier so the rest of code can stay untouched?:
```
ret = self.class.filter_objects(object_send(method, *params))


First modification


Oh, okay. Thanks.


`each` accepts a second argument, `x`, that is the context in which the callback is called. You can use it to avoid defining the variable `self`.


idiom


Yeah that looks great.


Remove commented out code.


Do we need to filter obj when it is kind of ar_klass?


TeamCity Waterfall :: Build [Build 51](https://tc.demonwav.com/viewLog.html?buildId=241&buildTypeId=Waterfall_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 46 Build time: 00:01:00


Thank you for this, it's actually a really good idea to add the label @carpodaster. May I suggest an improvement: indicating the orga status also when the current_user is orga & commenter?
I suppose it wouldn't make a huuuuge difference, but right now I think I'm the only one who has commented, and I notice that I would love to still see a small orga label, especially if it's a short discussion between me and maintainer.


@dpgeorge : Was this just debug code, not intended to be committed? Should this be removed now?


Same concern here on being able to distinguish errors from different properties... Should we be appending something to the error text? Or adding to a path property on the error object?


Shouldn't there be options to provide `Mono<?>` or `Flux` as the content?


TeamCity Waterfall :: Build [Build 52](https://tc.demonwav.com/viewLog.html?buildId=242&buildTypeId=Waterfall_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 46 Build time: 00:01:07


What required the inclusion of these headers here?  Since this really came from another library, I'm just wondering the reasoning here.


:tada: this is such a nice improvement! :tada:


Can you do the indentation right here? Also you need to put brackets around the string AFAIK


Did you mean to include this file?


I think the problem is that you have to be lucky to push both to the "release" tag and with the proper tag, so that @appveyor entry for the job looks like this:

release v3.5.0-beta.1 60af985d

(so we need to have both release and a tag)

I am using `git push --atomic -f` to try to achieve this, I also make sure that the tag is deleted on the github before that and the `release` points to some other commit than intended. I think we also make sure that GitHub "release" matches the "new" tag - I just did "Edit" on the release and it "jumped back" to point to the `v3.5.0-beta.1` tag.


We can't check for a command because YCM sets up them on the VimEnter event. Also since it's a pretty heavy plugin a lot of people (me included) load it only on demand. I think it would be best to check for a variable here, disabled by default, that the user can use to load the extension or not.


Этот глобальный on() мне не нравится. Получается, что наш компонент лезет в DOM, о котором не знает. Он знает только свой DOM. А это рутовый элемент и все глубже. Выше он не видит. А тут по сути навешивается хендлер на весь документ. Нужно юзать рутовый элемент:
```javascript
rootEl.find('.close').on(...)
```


Just put the help string here directly maybe?


Yes, totally... I'll fix this!


It seems like a few of these files shouldn't have been checked in.  That's the main concern with these changes.


A few minor notes.


Same thing here as above should be >= min  since `('a'..'a').to_a == ['a']`


Can you put this new test in an own function? We didn't separate tests good back when this was created...


Good catch!


Ack


All minor commented code things.


I have moved the relevant ipython notebooks and the "additional thoughts" page into this repo and updated the links in the DMTN.


Just one minor comment.


А зачем здесь cb?


maybe this can go in ctor now so we have somewhat of a standard place to look for defaults.


oh, it seems we end up with GitHub `401 Unauthorized` now. API key issue?


The following doc(s) have been deployed to the [1124envco](http://1124envco-static-docs.pantheon.io/docs) Multidev environment:


this is a test comment - i think i know what's going on...


Раз создаешь константы, то давай для всего ;) Класс 'visible' как раз хороший кандидат... Как и остальные ;)


haha - another test comment


It would make sense - this should be a TODO.  I'm not familiar (yet) with QgsAuthManager


Thanks for the PR! I'm unfamiliar with rst. can you show me an example of this working in action so I can confirm the syntax?


Finally, thanks ;)


@afollestad Yep, that's what I meant :smile:


yes


I agree that having to put it in all the workbench POMs is not ideal. +1 to making this change in the uberfire-api.


nit: be idiomatic `housekeepingInterval` (don't use underscores in go)


With the fix the problem goes away.


Please leave that one alone :) (I am an emacs user too, but it tends to leave backup files suffixed with tilde)


I'm not sure if I understood it correctly. This is what a comment made by an orga person looks like now:

![bildschirmfoto 2016-01-28 um 23 39 02](https://cloud.githubusercontent.com/assets/164400/12661180/6ca64b86-c618-11e5-932d-c3ddff3d1e5b.png)

Where else should the blue label appear?


agree - I end up seeing the password all over


Is this intentional?


@gakimball why was this not a problem for everyone before?


This is the one that seemed to break a lot of things. I'm re-merging this pull request with the correct conflict resolutions and will attempt to apply the subsequent commits as well.


Sure, why?


# Assignment 1 Grading Rubric (15 points total)

## Screenshots

- [ ] Assignment 1 contains directory of files for user (0.5 pt)
- [ ] Repository contains screenshot of [github][] account (0.5 pt)
- [ ] Repository contains screenshot of [Slack][] session (0.5 pt)
- [ ] Repository contains screenshot of [Atom][] installed on users computer (0.5 pt)
- [ ] Repository contains screenshot of screenshot showing that user installed [linter-flake8][] (0.5 pt)
- [ ] Repository contains screenshot of the Anaconda [REPL][] on user's computer (0.5 pt)
- [ ] Repository contains screenshot, in the repository, displayed by Github Desktop (0.5 pt)

## jupyter notebook

- [ ] Repository contains ipython/jupyter mini-tutorial as ipynb file (0.5 pt)
- [ ] ipynb Task 1 is presented with a description explaining what is occurring (0.5 pt)
- [ ] ipynb Task 2 is presented with a description explaining what is occurring (0.5 pt)
- [ ] ipynb Task 3 is presented with a description explaining what is occurring (0.5 pt)
- [ ] ipynb Task 4 is presented with a description explaining what is occurring (0.5 pt)
- [ ] ipynb Task 5 is presented with a description explaining what is occurring (0.5 pt)
- [ ] ipynb Task 6 is presented with a description explaining what is occurring (0.5 pt)
- [ ] ipynb Task 7 is presented with a description explaining what is occurring (0.5 pt)
- [ ] ipynb Task 8 is presented with a description explaining what is occurring (0.5 pt)
- [ ] ipynb Task 1 appears to be answered correctly (0.5 pt)
- [ ] ipynb Task 2 appears to be answered correctly (0.5 pt)
- [ ] ipynb Task 3 appears to be answered correctly (0.5 pt)
- [ ] ipynb Task 4 appears to be answered correctly (0.5 pt)
- [ ] ipynb Task 5 appears to be answered correctly (0.5 pt)
- [ ] ipynb Task 6 appears to be answered correctly (0.5 pt)
- [ ] ipynb Task 7 appears to be answered correctly (0.5 pt)
- [ ] ipynb Task 8 appears to be answered correctly (0.5 pt)
- [ ] You can successfully re-run every step of the ipynb notebook (3.0 pt)

[screenshot]: https://en.wikipedia.org/wiki/Screenshot
[git]: https://git-scm.com/
[github]: https://github.com
[Slack]: https://biolprogramming.slack.com
[Atom]: https://atom.io/
[linter-flake8]: https://atom.io/packages/linter-flake8
[syllabus]: https://github.com/biolprogramming/syllabus
[ipython]: http://ipython.org/notebook.html
[jupyter]: http://jupyter.org/
[REPL]: https://en.wikipedia.org/wiki/Read%E2%80%93eval%E2%80%93print_loop


Так, я правильно понимаю, что я могу, в итоге, оставить 2 заголовка одного уровня в section, да?)


Wouldn't this cause issues for mods that add in new stone textures, but the server thinks they're from 1.8?


lgtm


> Sorry for this shifting out under you

Why sorry? :wink: Thanks for the hints! :smiley:

> Maybe you need to pull the latest?

Yes,  I was using a bit [older code base](https://github.com/mlocati/concrete5/blob/44675b0e2f747d42c58f5d8bb767839a08feb331/web/concrete/src/Page/Stack/Stack.php#L180).


I'd rather keep this one as com.github.perlundq, if possible


jsync -> yajsync


`DynamoDBStore.prototype = Object.create(Store.prototype)`

__proto__ not recommended yet.


@carpodaster yes, but it only works if it's made by an orga who is "not you". Does that make sense? Meaning, if you post a comment, you will not see the `orga` label next to "you", you will only see it next to the names / comments of other organisers. :)


I like it.


2014 -> 2013, (although I didn't push it to github until 2014)


It seems odd to expose a public `getContent` method on a public API for building the request since its actual purpose is for internal use. The bigger problem I think is that build returns a partially built request with the body left to be sorted out separately.

Rather than exposing `getContent` here why don't we add a protected method to allow `HttpClient` to configure the builder with the encoders it needs for the body. That makes the builder complete and more friendly for sub-classing.


The following doc(s) have been deployed to the [bugdelete](http://bugdelete-static-docs.pantheon.io/docs) Multidev environment:
- [scripts/deploy-live.sh](https://github.com/pantheon-systems/documentation/commit/d2bcd106a7967f296d2b25e04306f4aa7bbeb2b3/scripts/deploy-live.sh)


Is this the same as the `forms.fm` landing page?


LGTM


Yup


Please do not include unnecessary changes


this comment no longer seems valid - what is the default now?


I think this should be `port:dev`, right?

Again _not_ intuitive :smile:


we don't need this blank line right? blank lines are sweet but not too many :stuck_out_tongue:


You hadn't fixed line 23 :warning:


because there is no need to kick off N number of RAF's here :)


Is this better because we assume the client height changes over time?


I guess that means we haven't tried to deploy a complex enough stack..


@pfalcon oops, yes, it's debug code.  Same with the block below.  It surely can be removed :)


this is what I mean :)

<img width="1195" alt="screen shot 2016-01-28 at 23 46 13" src="https://cloud.githubusercontent.com/assets/3143348/12661341/5ad374fa-c619-11e5-84bd-5b4978748d66.png">


-> rsync Java API and rsync client/server application


Does it make sense to sum delayPercentViewport and delayPercent of have them used as one or the other?


Ahhhh, gotcha! You'll see it when you logout :trollface: But in all seriousness: yeah, I suppose we can add that. My only concern is that the conditional in the user_for_comment helper methods gets really ugly with another branch.


Does this mean only sprinter is linked in the bin directory?


these should probably be declared to be of type `time.Duration`


The scope parameter on {include} does change the template variable environment into other state for example that of the parent template. Global variables have own storage area are merged at certain times into the template variable environment. Setting the sub-template to global had some negative side effects.
But let me recheck.


Again with 0.25% comment


see the cadvisor code:
```go
Godeps/_workspace/src/github.com/google/cadvisor/manager/container.go:var HousekeepingInterval = flag.Duration("housekeeping_interval", 1*time.Second, "Interval between container housekeepings")
Godeps/_workspace/src/github.com/google/cadvisor/manager/manager.go:var globalHousekeepingInterval = flag.Duration("global_housekeeping_interval", 1*time.Minute, "Interval between global housekeepings")
```


````PHP
<?php
$config = array();
$config['aye'] = [ 'lmao' => 'xd' ];
$config['webm'] = [
    'allow' => false,
    'maxduration' => 30,
    'audio' => true
];

var_dump($config); //Dumps current config.

class SaguaroConfig {
    private $config = array();
    function init($config) {
        if ($config && empty($this->config)) {
            $this->config = $config; //Store once.
        } else {
            return "Some problem with config init.";
        }
    }
    function get($key = null) {
        return ($key) ? $this->config[$key] : $this->config;
    }
}

$backup = new SaguaroConfig; $backup->init($config);
unset($config); var_dump($config); //null
var_dump($backup->get()); //Dumps copied config contents.
?>
````


@carpodaster ah, no worries then. I guess the solution is to have more people that aren't me comment on the projects :trollface:


I ended up reverting to the old method and offsetting a different way, see https://github.com/phenotips/phenotips/commit/d6260c78f17e3fc8013151f57d2bbc4bb8823cbb


@alicetragedy haha, well played! :+1: :joy:


Thanks mike


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1258](http://teamcity.monogame.net/viewLog.html?buildId=14117&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Not testing the invalid case and aggregation of errors.


Even as is, shutdown scripts do not trigger. I need to look more into it.


Ok, prova questo, dovrebbe andare bene, no? @matcracker


Looking at this from a `phytool` perspective, `dev` simply addresses the PHY with that address on the given `port`.

Should we have a separate usage message for `mv6tool`?

In any case the device map is as follows:

`dev` 0x0 - 0xa: PHY<n>
`dev` 0xf: SERDES page on some switches (e.g. 6352)
`dev` 0x10 - 0x1a: MAC(port)<n>
`dev` 0x1b: Global1
`dev` 0x1c: Global2


we could move this 'put' and the one in the next method also to a method in the presenter.

actually, we could have something like

    def present_average(average, attribute)
      puts "The average #{attribute.to_s} is: #{average} €/night"
    end

and call it like

    @homes_presenter.new.present_average average, :price

and for this to work we would need this on the initialize method of the HomesPresenter

    def initialize(homes = [], presenter: HomesPresenter)
      ...

Beautiful, right?

![](https://media.giphy.com/media/pSurYTaFDcY4E/giphy.gif)


Alphabetization!


I've added this because coming from `orga/projects` and constantly going back to the "normal" view was getting ridiculously annoying, but I'm not sure if this is as helpful as I think it is. feel free to revert if needed!


Would this fit on one line?


Add a newline at the end of the file please


The following doc(s) have been deployed to the [bugdelete](http://bugdelete-static-docs.pantheon.io/docs) Multidev environment:
- [scripts/deploy-live.sh](https://github.com/pantheon-systems/documentation/commit/812435b9a68b3d4d1cfa46bbd22b990d9fe23923/scripts/deploy-live.sh)


Looks super! :+1:

Same comments as in the other commit about the `dev`/`port` mess :smile:


ones is not defined. Besides you need to use AddRowSumMat for this.


AddRowSumMat again.


return $_warning = __('register.closed')';


since we have attr_readers, we don't need to do it like this anymore, should be enough with

    hourly_rate * hours_worked

This happens because the attr_readers define methods like this

    def hourly_rate
      @hourly_rate
    end

so you can actually call it just like a regular method (and yes, send("hourly_rate") would also work but it's super ugly)


typo interfac->interface


same here and all over the place :stuck_out_tongue_winking_eye:


presenter pattern would be awesome here!


Nope @hvelarde you've got it backward.


Haha, alright! I was just wanting to know if there was any fanciness about this. Maybe it could be made a hidden pref? Don't think it's that crucial to be a slider.


Perhaps we should consider something like `RestClient` or `WebClient`, a slightly different nomenclature in the `web.client` package to set it apart from the `http.server.reactive` level. Much like we have `WebHandler`, `WebFilter`, etc under `web.server`.


OK, it looks pretty good (I saw that you have already fixed some stuff I mentioned earlier, never noticed that before). Please make a new pull request against the maven branch with the changes we have talked about earlier (or just merge that commit into your branch, if you prefer that). I will then update the documentation on that one before merging into master. Thank you.


Is this because curator will not allow you to specify --older-than 25 --time-unit hours?  If not, then I think we should allow it, possibly with an INFO level log message "hey, did you really mean 25 hours?"


this was funny lol

![](http://33.media.tumblr.com/e616ef810e0138393a882ff233d4dc23/tumblr_nxw2bkJ4Kk1rxpytqo1_400.gif)


this NEEDS a presenter! if you separate concerns using that, you're gonna have super nice classes actually


It's valid code for the ternary.


Are we ok with adding this dep?


Oh, you're probably right.


Raising `IndexError` in `make_move` is a way of responding to an illegal transition call (index not provided in `current_state` output), not as a way of restricting movement. If it seems inconsistent, just think of it as input sanitation where necessary.


Thanks!


@vinkla *All Climb commands can does have an optional flag*
Could it be that Google search yields no results for "can does have"?


I'll take care of this.


interfuck


Nice, @cheerfulstoic! :sunglasses:


allowed_units = {'hours': 'hours', 'days': 'days', 'weeks': 'weeks', 'months': 'months'}


This might throw an error if `Question` or `Answer` with the given `id` is not found


thanks!


https://github.com/vlajos/misspell_fixer finds no typos :)


Hmm I thought we did away with needing the tag. I was under the impression any push to `release` would just build the binaries.


the scheduler will have to pass these same flags to each executor it launches. take a look at contrib/mesos/pkg/scheduler/service/service.go
* addCoreFlags
* prepareExecutorInfo


I'm not sure who's key is in use.


xDDDD


lol, we were glad to find this... we discovered it just now and reverted to some old commits but we couldn't figure out why it wasn't broken until sometime during the past week or so.


Can you explain this a little more? When are these not passed in? From here:

https://github.com/docker/docker/blob/master/container/container.go#L280

It looks like ctx.Command() and ctx.ContainerLabels will be available. What is a better way to act here?


@lfu
the find_ar_object_by_id method calls Rbac.search so its already filtered.


Removed extra space


Some response status code are not explicitly given, what will they be assigned by default?


Nice! TDD :+1:


Yeah, a separate help/usage for mv6tool would be useful. But right now they act the same, right?


The following doc(s) have been deployed to the [bugdelete](http://bugdelete-static-docs.pantheon.io/docs) Multidev environment:
- [scripts/deploy-live.sh](https://github.com/pantheon-systems/documentation/commit/812435b9a68b3d4d1cfa46bbd22b990d9fe23923/scripts/deploy-live.sh)


TeamCity pull requests :: netty [Build 1137](https://garage.netty.io/teamcity/viewLog.html?buildId=5176&buildTypeId=pulls_netty&guest=1) is now running


Verified it works. Done.


@lfu
2 reasons
(1) The object_send might return an active record relation object, which gives the objects only when you do a to_a on it.
(2) The object_send is being used for virtual_columns and other methods which are not associations and can't be RBAC'ed.
So we filter them only if they are associations.


`sin` and `cos` are expensive functions, you can safely cache `sin(angle)` value once and reuse it as I did here: https://github.com/procedural/quatFirstPersonCamera/blob/333714a/qfpc.h#L91-L97


Just thinking, won't this be take care of by the validation in the *model*?


Thx! :smiley:

Yup, will fix tomorrow :+1:


I don't care about your apples :p


I think you should just remove the line instead of commenting out, that's what RCS for, or there would be many remnants here and there in the future.

The note for `napms` can be put into commit message for why you switched to `sleep`.


I don't care about ...


Nice!


Ahh really need this, the liquid processing of all JS files has otherwise made the upgrade to jekyll 3 really painful for us -- thanks for the fix!  Any chance you could push a new gem version?


If `altPlatName` is not needed outside of the foreach loop, just declare inside the foreach loop (ie. on line 52)


This number determines the which if statement the code uses


... your apples :p


... your potato :p


Instead of iterating a list of strings representing platforms and compare the string with "x86", it would be easier to iterator through a list of enums.  For example: `foreach (Platform plat in Enum.GetValues(typeof(Platform))` and then later, you can call `plat.ToString()` when you need the string.


Why explicit "G"?  I thought it's the default if nothing is passed to ToString().


Tiny thing, indentation appears to be off by one tab here.


Could you shed more light on the use of the `rescue`?


Is this in any way dependent on role order? (i.e. does it matter if I call the hydra-stack role before or after the upenjdk1_8 role?)


This needs to be DateTimeOffset


DateTime offset as well and we need to set this when we submit it to the events date.


Correct me if I'm wrong but the modal doesn't have a `handleHidden` method.


It's fine. It may cause a conflict once (but only if master branch gets any change around these lines), but it will be a no-brainer to resolve.

Also, I like the idea.


How hot is ur phone getting?


Let's make sure this doesn't regress perf, as all the changed lines are on a very hot path. Additional method calls, repeated Math.pow etc. can add up bit by bit.


I think it makes sense if doesn't go there @ all. Moreover, since they will be using input fields in the front end. An empty input field will default to a `""` which could still be seen as an empty string. Nice one on the status codes, I'll state all explicitly.


I don't think it does. I'm simply looking for if I have a current_value If I was checking for nil that would imply I cared which kind of falsey value I had, I don't.

If I want to check for `nil?` this also becomes less readable due to the context it is being used.

I would either have to reverse the order of the condition, which doesn't read in the order I would think about
```
if current_value.nil?
  # I have no current _value
else
  # I have a current value
end
```

Or check that the value is not nil, which I have to interpret much like a double negation
```
if !current_value.nil?
```

I probably wouldn't enforce this on other PRs, all 3 are fine, but I think the version I have is the most readable.


@gimballock @odandia what do you guys think about this change? should I revert it back?


Lol. That's rails generated sir!


Gah. I did it in a hurry because I was about to leave for a road trip. Could you make this change on master? It will be difficult for me to push changes over the next week.


http://sync.zyos.co/zyos/redmine

Aquí les dejo el compilado


`s/encodeJsonForJStopInfo/encodeTidAndReason` seems good, but do you have any suggestion for encodeWithJStopInfo? The only thing I can think about is encodeWithThreadsStopInfo


merge artifacts


question about the package version check. The order of the two file inputs to join seem wrong (at least from what I run) -- comparing my working environment where blinker is a new package to the frozen file...

$ pip freeze -q -r requirements.freeze.txt | join --nocheck-order -v 2 requirements.freeze.txt -
## The following requirements were added by pip freeze:
blinker==1.4

bear@opus ~/circleci/python_testing/tenki (master %)
$ pip freeze -q -r requirements.freeze.txt | join --nocheck-order -v 2 - requirements.freeze.txt


Apparently @rightfold can't do anything herself.


I surely appreciate posting your programs. Your codes are absolutely great and had helped me tremendously over the course of this certificate program


@vvo have to start paying attention to the build :-P


Add release notes for this. Mention that this property is not used by Hive.


Can we get a factory spec that fails without this reload?


same here


Aha looks like your key https://github.com/sass/node-sass/commit/30b2b14095c73d6b31a7a2f799570ae4786d2f08


very creative


Fixes Issue #1


how can we start to rebuild the push delivery?


I just checked and newlines are already handled before qU is assembled via utils.removeExtraWhitespace. Again, this will need to be revisted because it blindly does it to *all* newlines in the query, e.g.

```sql
select * from table where name = '1\n2%'
```


This seems reasonable.


Is it me, or the name `QuaternionFromAxisAngle` implies that Axis goes as a first parameter and Angle as a second one? :)


Scala style: Lower case naming is reserved for singleton objects that are also functions; so these should be upper case.


Remove trailing whitespace


This could be an early return. ;)


I didn't see this resizeTables function really helped to get correct column width. Removing it doesn't break the tables so why to have it there ;)


@matthew-dean I hope you don't mind I commited directly.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1259](http://teamcity.monogame.net/viewLog.html?buildId=14121&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1258](http://teamcity.monogame.net/viewLog.html?buildId=14117&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:35:53


I'd like to re-asses schema mode; Cypher actually might want to know that for running schema procedures from within Cypher queries, not on this PR though :)


I was just going to suggest a similar fix. I can confirm this stops the input boxes from disappearing.


@skevy for reference, this is the alternative to adding a module to the jest config - it's a bit easier for us since there are multiple jest configs (FB, GitHub) that would have to be updated.


Nothing much about it. Just normal. When a rescue block is placed directly in a method body it is triggered whenever an error is thrown anywhere in the method. If the error is not within the scope of  a `begin-rescue` block though.


sure thing


Not sure I like "@Context" that feels to vague to me


Looks good. :+1:


since this exports a function, i renamed the module to lowercase to match our convention. otherwise, this is per the original PR.


The following doc(s) have been deployed to the [bugdelete](http://bugdelete-static-docs.pantheon.io/docs) Multidev environment:
- [scripts/deploy-live.sh](https://github.com/pantheon-systems/documentation/commit/812435b9a68b3d4d1cfa46bbd22b990d9fe23923/scripts/deploy-live.sh)


No, this is wrong. Now setPortletName() really sets the name of the portlet while _portlet.getPortletId() returns the portletInstanceKey.


I like this overall; could we add some tests regarding procedures calling other procedures (hope I didn't miss those)


I propose a format something like this::

    {'project_name_1': {
        "unit": "hours",
        "value": 12
        },
       "project_name_2", { ... etc.

We could even extend this to support other actions e.g.::

    {'project_name_1': [
        {"action": delete,
         "unit": "months",
        "value": 2},
        {"action": "archive"
         "unit": "months",
        "value": 1},
        ],
        "project_name_2", [.....


This is correct. Good catch!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13267](https://teamcity.mesosphere.io/viewLog.html?buildId=116230&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 216 Build time: 00:10:39


I thought it was but after looking at the enum tostring docs it's not.


> would still prefer to skip this intermediate step and just modify those few extensions

Agreed. I will investigate further ...


Is this for the ".operations" and "logging" indices?


Topped out at 34C during dexopt... thermald spends alot more time throttling the GPU than the CPU, even just during dexopt. Why, your temps running hot?


Oh really!


Because this is an 'else' statement, no need for `current_user.try(:subscribed)`


Are we going to ship the procedures used in these examples as built-ins? People might expect those to work, esp. if they just googled this example without having the context from the surrounding manual


Great catch, thanks!


Cool beans. :)


Thanks! Now I know. :)


Why is this calculate order being called again?


>I think you should just remove the line instead of commenting out

Right. In general I really need to go through and remove all of the commented code I've left.
Old habit.

>The note for napms can be put into commit message for why you switched to sleep.

With the really low refresh rate, napms works fine. I might add it back so that time doesn't have to be imported.


Hello!

Why are the modules uninstallable? Is it because of compatibility issues with v9.0? Do these modules work with v9.0 or should I just install v8.0?


@osahyoun every time someone took an action, it updated the `cache_key` for that page...

derp.


@alanch-ms are you saying easier in terms of readability?


@domenic I see that some arguments are enclosed by a `« »` and some not.

It is not clear to me why some are... can you explain?


Make this method return a Schedule object and parametrize it with the teachers ID so that you can validate later that it returns something in the test


Doesn't look I can add `+ 'Stack'` back or this line breaks (and can't find a solution to it) https://github.com/DualSpark/cloudformation-environmentbase/commit/7383c18413b4035c475aa1ad30b2382ee5355b7d#diff-25af13cdbbecb95cd3a8acde2ec8d93cR1221


Wait, what? It's been quite a while since I wrote this piece of code, but how does this filler help? Which pointer must not point to where specifically? `EXCEPTION_REGISTRATION` is just supposed to match how the fields are laid out in the various stack frames – is it the extra offset by `EXCEPTION_REGISTRATION.sizeof` below that does the trick for the fix?


I was confused first you have to make this method return a Schedule object or a list of Schedules


nit: `removeIf` returns a `boolean` saying whether it removed something, so the it can be assigned to `isRecursiveReference`. And then `getRecursiveReferencePredicate` can be converted to a lambda.


I think we should keep this format.  Instead of "retention" I would propose "delete" - that is, just use the same names as the curator command names.  We could also have "close", "bloom", etc. - the other curator commands.


It's easier (and faster) to compare (ie. line 53).  You can just do a `if (plat == Platforms.x86)` instead of a `string.compare(...) = 0`


« » denotes a List. The second argument to Logger is a List.


It is scheduled for a release shortly.


I'm not sure what you mean?


On Thu, 28 Jan 2016, Michael Mifsud wrote:

> Aha looks like your key https://github.com/sass/node-sass/commit/30b2b14095c73d6b31a7a2f799570ae4786d2f08

Replaced the key, it seems to work now.


Great to hear, thanks!
On Jan 28, 2016 3:18 PM, "RBLachica" <notifications@github.com> wrote:

> I surely appreciate posting your programs. Your codes are absolutely great
> and had helped me tremendously over the course of this certificate program
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/edj-boston/coursera-r-programming/commit/82063d7c9fa1f7c4dc42f17016f4201685304f00#commitcomment-15748420>
> .
>


Is "can does have" a typo, or is it "can/does have"?


Hmm ok that would be one less tostring call. I'll change this.


Don't forget those blank lines in the end of script.


For new projects (and when I change projects) I'm making it cover by default, and you have to say COVERAGE=off to turn it off, because I'm thinking of coverage as part of the testing run that really shouldn't be turned off (performance impact is negligible), just a thought.


These 4 lines can be replaced by::

    curator_settings[unit].setdefault(value, []).append(project)

This means - get the value of curator_settings[unit][value] - if it doesn't exist, set it to an empty array and return it, then append project to it


This is obviously quick and dirty thing just to illustrate the problem. Half of `tree` type are "values" and can appear here, i.e. as in:
```less
fooz {
    rgb(1, 2, 3);
    length(1 2 3);
    extract(1 + 3, 1);
    %("quoted");
    %(~"unquoted");
    extract(keyword, 1);
    extract(url(http://foo.bar), 1);
    extract({foo: bar}, 1);
    @l: 1 2, 3 4;
    extract(@l,    1); // space list, tree.Expression
    extract(@l @l, 1); // comma list, tree.Value

    // tree.Anonymous is actually allowed in the root as it's used
    // for `@import (inline)` (with isRulesetLike being a function)
    // This opens this scary back-door though:
    e("whatever"); // OK
}
```
So we doin't really want to test them all in this condition. The negative condition like above is shorter but still pretty bloating (-> performance). Some corresponding types (Ruleset, At-Rule Directives) already have `isRulesetLike` flag, but it's somewhat [broken](https://github.com/less/less.js/blob/v2.5.3/lib/less/tree/ruleset.js#L333-L337).
In other words, apparently this part is something to be improved somehow (I have no good ideas about "how" though).


Flips of the order of the check to see if we are scrubbing (seeking) and if so move icon to scrubbed position. If not, we move the icon according the the currentPlayhead. Also sets the 'scrubbingPlayheadX' (the delta on scrubbing) to 0 at the end of handlePlayheadMouseUp so that it is not constantly trying to apply the value.


for project in curator_settings[unit][value]


>Don't forget those blank lines in the end of script.

I definitely would have.


this looks weird but it handles the case of re-defining handler to something like `dist/index.handleEvent`


Thanks, Bjorn.  This is a good fix.


Ah I see you are doing this in the spec helper, so maybe this isn't needed?


will need a better error message than this - it will be hard enough to debug this . . .


Hey Yan,
Can you add this bash script under the test folder.


 ありがとうござますー！
1行にまとめる...確かに出来ますね！（ぜんぜん気が付かなかった。。）
` /3/ =~ i.to_s `は、最初に書いていて、` #{ i } ` と迷った結果後者になりました＾＾；


`![image](https://cloud.githubusercontent.com/assets/16807981/12662497/1dfff640-c621-11e5-8bb1-02f7f5d74b40.png)
`


I guess you're right, the `IndexError` raised after reaching a terminal state is merely a side-effect of raising it whenever the requested transition cannot be found.

If there _was_ a fitting exception built into Python I'd be forced to insist, but looking through them it would appear that there is not. Not even a `DataError` or anything like it, which I'm sure our frontend dev would appreciate greatly. :)


why not `#!/usr/bin/env python3` instead of `#!/Library/Frameworks/Python.framework/Versions/3.5/bin/python3`?


Also, 10G may be overkill. Try s could of time to get a good size. Try ~5G and a large batch.


## Task 1

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 2

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 3

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 4

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 5

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)
- [ ] Program is different than [Task 4](task-4) (1 pt)

## Task 6

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (3 pts)


thank you, @davisagli! do you mind if we depend on plone.autoform then @agitator


OK, done() is an antiapptern which came here as the hue lib is using Q-promises. My suggestion is to wrap function body with a new bluebord promise and to the innerfunction also handle errors. I think it is OK to reject on error.

```
turnOn: ->
      return new Promise( (resolve, reject) =>
        hueState = hue.lightState.create().on()
        @device[@hueStateCommand](@hueId, hueState).then( =>
          @_updateState power: true
          resolve()
        ).catch( (error) =>
          env.logger.error error.message ? error
          reject("" + error.message ? error)
        )
      )
```


I think this should be `--prefix` - I think `--index` requires the exact index name, which is only used for manually deleting indices.  You will also need to provide the `--timestring` argument, but that can be provided in the `base_cmd`


Params could be a map of k/v pairs to help with self documentation


Every -> period ?


I was going to just add the commit fixing the `git checkout` command and leave that tag where it was, but then I ran into another bug that was causing test failures on OS X (because I had cherry-picked f6f868fe28f but not be24e9daf1 from master). I'm not sure if moving the tag was a good idea or not, but it's done now. This bug doesn't appear to affect the other binaries, so I'm not rebuilding them.

Now it's just a matter of getting the PR for the updated Homebrew formula resolved and then we can make an announcement of the release.


nice commit


Sorry for the extreme delay in grading this...Overall, it looks pretty good for a first assignment. I would suggest describing how your code works or what it is you're coding for in the end.


# Assignment 3 Grading Rubric (15 points total)

## Task Set 1

- [ ] Regex matches entire dinucleotide repeat (AT)5 and only the repeat (1 pt)
- [ ] Regex matches entire dinucleotide repeat (AT)5, only the repeat, and is different from above (1 pt)
- [ ] Regex matches entire dinucleotide repeat (AT)5, only the repeat, and is different both above (1 pt)
- [ ] Regex correctly matches all instances of `R` or `S` (1 pt)
- [ ] Regex (find and replace) matches all instances of `R` or `S` and replaces them with `N` (1 pt)

## Task Set 2

- [ ] Regex (find and replace) correctly reverses the order of the columns from 1,2,3,4 (as you see them) to 4,3,2,1 (1 pt)
- [ ] Regex (find and replace) correctly reverses the order of the columns from 1,2,3,4 (as you see them) to 1,2,4,3 (1 pt)
- [ ] Regex (find and replace) correctly replaces commas with tabs (1 pt)
- [ ] Regex (find and replace) correctly gives us the horrible format requested (1 pt)

## Task Set 3

- [ ] Regex (find and replace) correctly parses out only the lane number from the header (1 pt)
- [ ] Regex (find and replace) correctly parses out only the flowcell ID from the header (1 pt)
- [ ] Regex (find and replace) correctly parses any flowcell ID from the header (1 pt)

## Task Set 4

- [ ] Regex (find and replace) correctly extracts only the serial number from the fastq sequence (1 pt)
- [ ] Regex (find and replace) correctly turns the fastq into a fasta having the requested format (2 pt)

## Task Set 5

- [ ] Regex (find and replace) correctly extracts the (AT)5 repeat (Regex bliss)


I commit the changes using git commit, so it just combine all my commits


That's what I thought.

So, why keep the skipped local var then at all?

And "Why does it even work?"™

From my understanding, this is what happens:

The lambda that's stored as `action` gets called with `store_credit` from the caller, but with your change `_store_credit` is not used in the lambda anymore. So I guess it takes the `store_credit` from the outer scope.

Shouldn't this also work without the local var then? And why pass the `store_credit` around if the local one from the caller gets used anyway?

I am so confused.


We use linux to compile anyway, so it's no need