I enabled debug ans now its filled:
2016-01-06 14:11:35.911 Always, OpenZwave Version 1.3.625 Starting Up
2016-01-06 14:11:35.911 Info, Setting Up Provided Network Key for Secure Communications
2016-01-06 14:11:35.911 Info, mgr,     Added driver for controller /dev/ttyACM0
2016-01-06 14:11:35.911 Info,   Opening controller /dev/ttyACM0
2016-01-06 14:11:35.911 Info, Trying to open serial port /dev/ttyACM0 (attempt 1)
2016-01-06 14:11:35.914 Info, Serial port /dev/ttyACM0 opened (attempt 1)
2016-01-06 14:11:35.914 Detail, contrlr, Queuing (Command) FUNC_ID_ZW_GET_VERSION: 0x01, 0x03, 0x00, 0x15, 0xe9
2016-01-06 14:11:35.914 Detail, contrlr, Queuing (Command) FUNC_ID_ZW_MEMORY_GET_ID: 0x01, 0x03, 0x00, 0x20, 0xdc
2016-01-06 14:11:35.914 Detail, contrlr, Queuing (Command) FUNC_ID_ZW_GET_CONTROLLER_CAPABILITIES: 0x01, 0x03, 0x00, 0x05, 0xf9
2016-01-06 14:11:35.914 Detail, contrlr, Queuing (Command) FUNC_ID_SERIAL_API_GET_CAPABILITIES: 0x01, 0x03, 0x00, 0x07, 0xfb
2016-01-06 14:11:35.914 Detail, contrlr, Queuing (Command) FUNC_ID_ZW_GET_SUC_NODE_ID: 0x01, 0x03, 0x00, 0x56, 0xaa
2016-01-06 14:11:35.914 Detail,
2016-01-06 14:11:35.914 Info, contrlr, Sending (Command) message (Callback ID=0x00, Expected Reply=0x15) - FUNC_ID_ZW_GET_VERSION: 0x01, 0x03, 0x00, 0x15, 0xe9
2016-01-06 14:11:35.916 Detail, contrlr,   Received: 0x01, 0x10, 0x01, 0x15, 0x5a, 0x2d, 0x57, 0x61, 0x76, 0x65, 0x20, 0x33, 0x2e, 0x39, 0x39, 0x00, 0x01, 0x95
2016-01-06 14:11:35.916 Detail,
2016-01-06 14:11:35.916 Info, contrlr, Received reply to FUNC_ID_ZW_GET_VERSION:
2016-01-06 14:11:35.916 Info, contrlr,     Static Controller library, version Z-Wave 3.99
2016-01-06 14:11:35.916 Detail, Node045,   Expected reply was received
2016-01-06 14:11:35.916 Detail, Node045,   Message transaction complete
2016-01-06 14:11:35.916 Detail,
2016-01-06 14:11:35.916 Detail, contrlr, Removing current message
2016-01-06 14:11:35.916 Detail,
2016-01-06 14:11:35.916 Info, contrlr, Sending (Command) message (Callback ID=0x00, Expected Reply=0x20) - FUNC_ID_ZW_MEMORY_GET_ID: 0x01, 0x03, 0x00, 0x20, 0xdc
2016-01-06 14:11:35.919 Detail, contrlr,   Received: 0x01, 0x08, 0x01, 0x20, 0xec, 0xb9, 0xf3, 0x07, 0x01, 0x76
2016-01-06 14:11:35.919 Detail,
2016-01-06 14:11:35.919 Info, contrlr, Received reply to FUNC_ID_ZW_MEMORY_GET_ID. Home ID = 0xecb9f307.  Our node ID = 1
2016-01-06 14:11:35.919 Detail, Node185,   Expected reply was received
2016-01-06 14:11:35.919 Detail, Node185,   Message transaction complete
2016-01-06 14:11:35.919 Detail,
2016-01-06 14:11:35.919 Detail, contrlr, Removing current message
2016-01-06 14:11:35.919 Detail,
2016-01-06 14:11:35.919 Info, contrlr, Sending (Command) message (Callback ID=0x00, Expected Reply=0x05) - FUNC_ID_ZW_GET_CONTROLLER_CAPABILITIES: 0x01, 0x03, 0x00, 0x05, 0xf9
2016-01-06 14:11:35.920 Detail, contrlr,   Received: 0x01, 0x04, 0x01, 0x05, 0x3c, 0xc3
2016-01-06 14:11:35.920 Detail,
2016-01-06 14:11:35.920 Info, contrlr, Received reply to FUNC_ID_ZW_GET_CONTROLLER_CAPABILITIES:
2016-01-06 14:11:35.920 Info, contrlr,     There is a SUC ID Server (SIS) in this network.
2016-01-06 14:11:35.920 Info, contrlr,     The PC controller is an inclusion static update controller (SUC) and was the original primary before the SIS was added.
2016-01-06 14:11:35.920 Detail, Node195,   Expected reply was received
2016-01-06 14:11:35.920 Detail, Node195,   Message transaction complete
2016-01-06 14:11:35.920 Detail,
2016-01-06 14:11:35.920 Detail, contrlr, Removing current message
2016-01-06 14:11:35.920 Detail,
2016-01-06 14:11:35.920 Info, contrlr, Sending (Command) message (Callback ID=0x00, Expected Reply=0x07) - FUNC_ID_SERIAL_API_GET_CAPABILITIES: 0x01, 0x03, 0x00, 0x07, 0xfb
2016-01-06 14:11:35.924 Detail, contrlr,   Received: 0x01, 0x2b, 0x01, 0x07, 0x05, 0x02, 0x01, 0x15, 0x04, 0x00, 0x00, 0x01, 0xfe, 0x83, 0xff, 0x88, 0xcf, 0x1f, 0x00, 0x00, 0xfb, 0x9f, 0x7d, 0xa0, 0x67, 0x00, 0x80, 0x80, 0x00, 0x80, 0x86, 0x00, 0x00, 0x00, 0xe8, 0x73, 0x00, 0x00, 0x0e, 0x00, 0x00, 0x40, 0x1a, 0x00, 0x09
2016-01-06 14:11:35.924 Detail,
2016-01-06 14:11:35.924 Info, contrlr,  Received reply to FUNC_ID_SERIAL_API_GET_CAPABILITIES
2016-01-06 14:11:35.924 Info, contrlr,     Serial API Version:   5.2
2016-01-06 14:11:35.924 Info, contrlr,     Manufacturer ID:      0x0115
2016-01-06 14:11:35.924 Info, contrlr,     Product Type:         0x0400
2016-01-06 14:11:35.924 Info, contrlr,     Product ID:           0x0001
2016-01-06 14:11:35.924 Detail, contrlr, Queuing (Command) FUNC_ID_ZW_GET_RANDOM: 0x01, 0x04, 0x00, 0x1c, 0x20, 0xc7
2016-01-06 14:11:35.924 Detail, contrlr, Queuing (Command) FUNC_ID_SERIAL_API_GET_INIT_DATA: 0x01, 0x03, 0x00, 0x02, 0xfe
2016-01-06 14:11:35.924 Detail, contrlr, Queuing (Command) FUNC_ID_SERIAL_API_SET_TIMEOUTS: 0x01, 0x05, 0x00, 0x06, 0x64, 0x0f, 0x97
2016-01-06 14:11:35.924 Detail, contrlr, Queuing (Command) FUNC_ID_SERIAL_API_APPL_NODE_INFORMATION: 0x01, 0x07, 0x00, 0x03, 0x01, 0x02, 0x01, 0x00, 0xf9
2016-01-06 14:11:35.924 Detail, Node002,   Expected reply was received
2016-01-06 14:11:35.924 Detail, Node002,   Message transaction complete
2016-01-06 14:11:35.924 Detail,
2016-01-06 14:11:35.924 Detail, contrlr, Removing current message
2016-01-06 14:11:35.924 Detail,
2016-01-06 14:11:35.924 Info, contrlr, Sending (Command) message (Callback ID=0x00, Expected Reply=0x56) - FUNC_ID_ZW_GET_SUC_NODE_ID: 0x01, 0x03, 0x00, 0x56, 0xaa
2016-01-06 14:11:35.926 Detail, contrlr,   Received: 0x01, 0x04, 0x01, 0x56, 0x01, 0xad
2016-01-06 14:11:35.926 Detail,
2016-01-06 14:11:35.926 Info, contrlr, Received reply to GET_SUC_NODE_ID.  Node ID = 1
2016-01-06 14:11:35.926 Detail, Node173,   Expected reply was received
2016-01-06 14:11:35.926 Detail, Node173,   Message transaction complete
2016-01-06 14:11:35.926 Detail,
2016-01-06 14:11:35.926 Detail, contrlr, Removing current message
2016-01-06 14:11:35.926 Detail,
2016-01-06 14:11:35.926 Info, contrlr, Sending (Command) message (Callback ID=0x00, Expected Reply=0x1c) - FUNC_ID_ZW_GET_RANDOM: 0x01, 0x04, 0x00, 0x1c, 0x20, 0xc7
2016-01-06 14:11:35.981 Detail, contrlr,   Received: 0x01, 0x25, 0x01, 0x1c, 0x01, 0x20, 0x3c, 0x71, 0x45, 0x63, 0x67, 0x9c, 0xf9, 0x67, 0xc8, 0x50, 0x48, 0x83, 0x1f, 0xa3, 0xbb, 0x89, 0x56, 0xb7, 0xea, 0xd0, 0x14, 0x4e, 0x3a, 0xf6, 0xe4, 0x37, 0x72, 0xc3, 0xcc, 0xb1, 0x91, 0x6b, 0x9d
2016-01-06 14:11:35.981 Detail,
2016-01-06 14:11:35.981 Info, contrlr, Received reply to FUNC_ID_ZW_GET_RANDOM: true
2016-01-06 14:11:35.981 Detail, Node032,   Expected reply was received
2016-01-06 14:11:35.981 Detail, Node032,   Message transaction complete
2016-01-06 14:11:35.982 Detail,
2016-01-06 14:11:35.982 Detail, contrlr, Removing current message
2016-01-06 14:11:35.982 Detail,
2016-01-06 14:11:35.982 Info, contrlr, Sending (Command) message (Callback ID=0x00, Expected Reply=0x02) - FUNC_ID_SERIAL_API_GET_INIT_DATA: 0x01, 0x03, 0x00, 0x02, 0xfe
2016-01-06 14:11:36.081 Detail, contrlr,   Received: 0x01, 0x25, 0x01, 0x02, 0x05, 0x08, 0x1d, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x05, 0x00, 0xcd
2016-01-06 14:11:36.081 Detail,
2016-01-06 14:11:36.104 Info, mgr,     Driver with Home ID of 0xecb9f307 is now ready.
2016-01-06 14:11:36.104 Info,
2016-01-06 14:11:36.105 Info, contrlr, Received reply to FUNC_ID_SERIAL_API_GET_INIT_DATA:
2016-01-06 14:11:36.105 Info, contrlr,     Node 001 - Known
2016-01-06 14:11:36.105 Detail, Node001, AdvanceQueries queryPending=0 queryRetries=0 queryStage=Probe1 live=1
2016-01-06 14:11:36.105 Detail, Node001, QueryStage_Probe1
2016-01-06 14:11:36.105 Detail, Node001, QueryStage_Associations
2016-01-06 14:11:36.105 Detail, Node001, QueryStage_Neighbors
2016-01-06 14:11:36.105 Detail, contrlr, Requesting routing info (neighbor list) for Node 1
2016-01-06 14:11:36.105 Detail, Node001, Queuing (Command) Get Routing Info (Node=1): 0x01, 0x07, 0x00, 0x80, 0x01, 0x00, 0x00, 0x03, 0x7a
2016-01-06 14:11:36.105 Detail, Node001, Queuing (Query) Query Stage Complete (Neighbors)
2016-01-06 14:11:36.105 Detail, Node008,   Expected reply was received
2016-01-06 14:11:36.105 Detail, Node008,   Message transaction complete
2016-01-06 14:11:36.105 Detail,
2016-01-06 14:11:36.105 Detail, contrlr, Removing current message
2016-01-06 14:11:36.105 Detail, Node001, Notification: DriverReady
2016-01-06 14:11:36.105 Detail, Node001, Notification: NodeAdded
2016-01-06 14:11:36.107 Detail, Node001, Notification: NodeProtocolInfo
2016-01-06 14:11:36.107 Detail, Node001, Notification: EssentialNodeQueriesComplete
2016-01-06 14:11:36.107 Detail, Node001, Notification: ValueAdded
2016-01-06 14:11:36.107 Detail, Node001, Notification: NodeNaming
2016-01-06 14:11:36.107 Detail,
2016-01-06 14:11:36.107 Info, contrlr, Sending (Command) message (Callback ID=0x00, Expected Reply=0x06) - FUNC_ID_SERIAL_API_SET_TIMEOUTS: 0x01, 0x05, 0x00, 0x06, 0x64, 0x0f, 0x97
2016-01-06 14:11:36.108 Detail, contrlr,   Received: 0x01, 0x05, 0x01, 0x06, 0x64, 0x0f, 0x96
2016-01-06 14:11:36.108 Detail,
2016-01-06 14:11:36.108 Info, contrlr, Received reply to FUNC_ID_SERIAL_API_SET_TIMEOUTS
2016-01-06 14:11:36.108 Detail, Node015,   Expected reply was received
2016-01-06 14:11:36.108 Detail, Node015,   Message transaction complete
2016-01-06 14:11:36.108 Detail,
2016-01-06 14:11:36.109 Detail, contrlr, Removing current message
2016-01-06 14:11:36.109 Detail,
2016-01-06 14:11:36.109 Info, contrlr, Sending (Command) message (Callback ID=0x00, Expected Reply=0x00) - FUNC_ID_SERIAL_API_APPL_NODE_INFORMATION: 0x01, 0x07, 0x00, 0x03, 0x01, 0x02, 0x01, 0x00, 0xf9
2016-01-06 14:11:36.109 Detail, contrlr, Removing current message
2016-01-06 14:11:36.109 Detail,
2016-01-06 14:11:36.110 Info, Node001, Sending (Command) message (Callback ID=0x00, Expected Reply=0x80) - Get Routing Info (Node=1): 0x01, 0x07, 0x00, 0x80, 0x01, 0x00, 0x00, 0x03, 0x7a
2016-01-06 14:11:36.115 Detail, Node001,   Received: 0x01, 0x20, 0x01, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x5e
2016-01-06 14:11:36.115 Detail,
2016-01-06 14:11:36.115 Info, Node001, Received reply to FUNC_ID_ZW_GET_ROUTING_INFO
2016-01-06 14:11:36.115 Info, Node001,     Neighbors of this node are:
2016-01-06 14:11:36.115 Info, Node001,  (none reported)
2016-01-06 14:11:36.115 Detail,   Expected reply was received
2016-01-06 14:11:36.115 Detail,   Message transaction complete
2016-01-06 14:11:36.115 Detail,
2016-01-06 14:11:36.115 Detail, Node001, Removing current message
2016-01-06 14:11:36.115 Detail, Node001, Query Stage Complete (Neighbors)
2016-01-06 14:11:36.115 Detail, Node001, AdvanceQueries queryPending=0 queryRetries=0 queryStage=Session live=1
2016-01-06 14:11:36.115 Detail, Node001, QueryStage_Session
2016-01-06 14:11:36.115 Detail, Node001, QueryStage_Dynamic
2016-01-06 14:11:36.115 Detail, Node001, QueryStage_Configuration
2016-01-06 14:11:36.115 Detail, Node001, QueryStage_Complete
2016-01-06 14:11:36.115 Warning, CheckCompletedNodeQueries m_allNodesQueried=0 m_awakeNodesQueried=0
2016-01-06 14:11:36.115 Warning, CheckCompletedNodeQueries all=1, deadFound=0 sleepingOnly=1
2016-01-06 14:11:36.115 Info,          Node query processing complete.
2016-01-06 14:11:36.115 Detail, Node001, Notification: NodeQueriesComplete
2016-01-06 14:11:36.116 Detail, contrlr, Notification: AllNodesQueried


minor: include in alphabetical order


Maybe it should be better to consider throw an exception when editable option is false instead of return a value always.  So exception says to user something like this: you must set true ediatable option first


> If you need to inject a content script into the page in order to detect the PDF viewer,
> doesn't that mean you need the <all_urls> permission to be able to inject content scripts into any page?

Not if you have the Chrome implicit "activeTab" permission

> Will this (PDF viewer detection) technique work when we want to share code between
> extensions for different browsers? We'd have to add code to detect each different browser's PDF viewer, right?

In Firefox we can definitely detect PDF.js, although we might not need to replace the viewer if it is already HTML based. I'm unsure about Safari and Edge. My inclination is that we can cross that bridge when we come to it - and possibly take a different approach in other browsers if necessary.


minor: you could give an error message here


dose public creds


Are you able to connect to your database?


minor: you could give an error message here.


Does it support symbolic link, BTW?


which format ? what is this public key used for ?


It isn't receiving a connection. Check the console in your `chrome` browser there might be a hint there.


add some words


Awesome, this is great! Super excited, thanks for taking this on.

Could you please change the filename to "Guest Room Guidelines.md"? (With space to match House Rules, and a "md" extension to make it markdown?) And then for formatting,

Agree that we have to figure out keys. This will get easier with electronic locks but that's not happening tomorrow.

I also suspect that there will be some linen/cleaning workflow issues to work out, and that we'll need to set some expectations about when (what time of day) the room needs to be cleaned up for the next guest when we have back-to-back guests. And that we'll ultimately need a "guest room manager" that checks up and keeps everything running smoothly (some hosts are going to do a great job with their responsibilities, others are going to fuck it up.) But all this can come later..


If it isn't logging that means it never runs. Try logging your code backwards to see the top level of whatever isn't running. Then you'll have a better sense of where your problem is


Not that it has much to do with this PR specifically, but shouldn't there be some encoding/escaping going on here?


For the formatting, you just need to rename the file to end in ".md" and add Markdown formatting. It's pretty easy. See House Rules.md for an example.


Somehow, my build suddenly stopped detecting sass binary, not sure whats going wrong. Do you have a clue?

remote: -----> Installing Sass/Compass
remote:        Restoring ruby gems directory from cache
remote: Updating installed gems
remote: Nothing to update
remote: Successfully installed chunky_png-1.3.5
remote: Successfully installed sass-3.4.20
remote: Successfully installed compass-core-1.0.3
remote: Successfully installed compass-import-once-1.0.5
remote: Successfully installed rb-fsevent-0.9.7
remote: Building native extensions.  This could take a while...
remote: Successfully installed ffi-1.9.10
remote: Successfully installed rb-inotify-0.9.5
remote:     Compass is charityware. If you love it, please donate on our behalf at http://umdf.org/compass Thanks!
remote: Successfully installed compass-1.0.3
remote: 8 gems installed
remote:        Caching ruby gems directory for future builds
remote:
remote: -----> Building dependencies
...
...
...
remote:        Running default compile
remote:        You need to have Sass on your system
remote:        Execute `gem install sass`
remote:


@svd260 generics do not by you any type-safety or ease of programming here.  Better to leave as `Object` and not use `T` or `U`


Should we put defer before checking for a dir? Because we leak file descriptor in this case.


Default should be LIKE


This is not right, @paddybyers this repo should be in `ably-forks`. Can you add to `ably-forks` and we can update the docs?  Also, do we need this fork?


It completly broke it.
`[13:16:58] [EMERGENCY]: [RakLib Thread #140122517694208] RakLib crashed!`
`[14:16:58] [INFO]: Loading DevTools v1.10.0`
`[14:16:59] [INFO]: Enabling DevTools v1.10.0`
`[14:16:59] [INFO]: [DevTools] Registered folder plugin loader`
`[14:16:59] [INFO]: Preparing level "world"`
`[14:16:59] [ERROR]: Could not load level "world": Invalid argument supplied for foreach()`
`[14:16:59] [WARNING]: RuntimeException: "Invalid argument supplied for foreach()" (E_WARNING) in "/src/pocketmine/level/Level" at line 408`
`[14:16:59] [EMERGENCY]: No default level has been loaded`
`[14:17:00] [INFO]: Disabling DevTools v1.10.0`
`[14:17:00] [INFO]: Stopping other threads`


Outdated comment.


Hello NocusNibbes ;-), I created a module and edit it 5 min later and you can see the removed line in red and added lines in green


@svd260 do not use exceptions as flow control.  Instead have a private method which "walks" the class-hierarchy to find the polymorphic class associated with the field name.  Then return that or throw an exception.


Fixes issue #65


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10815](https://teamcity.mesosphere.io/viewLog.html?buildId=100796&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:03:45


makes separate bounding arrays for each axis on the subplot, which means they're all labeled by the axis id, not the axis letter. Here's what this looks like for box (first object) and lasso (second object):
![selection event data](https://cloud.githubusercontent.com/assets/2678795/12143440/dc9ecbd8-b480-11e5-8efd-d2dec172f487.png)


...and directories will have 0777 permissions. Probably, you would like to mention that too.


@nfour Just pushed 2.7.2 that fixes the typo and missing # marks on includes. Hope this works now!


@svd260 in general unit tests should not have state and thus not have instance variables.  These should be created/mocked within the test methods.


@svd260 conventionally do not put logic in a JUnit class's constructor.


Opmerking bij de regel?


Oh, also, could you include a note about suggesting changes to the policy? Like "if you have suggested changes or improvements, send a PR/post to the mailing list/(whatever you think is appropriate to put here)"? Want to show that input/collaboration is welcome, and provide some basic coaching on how to do it


Since the `fstruct` abstraction is only used in one place (as far as I can tell), can we relocate it under the `lib.virtio.*` hierarchy? That way as soon as another component wants to use it we can easily move it into `core.lib`, but as of now I am not convinced it deserves to extend `core.lib`.

I don't want to be the judge here though and am happy to be convinced otherwise if people find this abstraction useful.


@svd260 do not create actual files.  This is the job of Mockito, to mock these objects so that you can precisely control their usage (i.e., when `exists` is called on my mock `File` return true, etc).


nice, it's true
thanks @alrra lol


How does this relate to the rest of the commit?


I would like to have the List of ProjectLikes provided to this constructor instead of the computed long count. But that's more like a question of taste.


Just want to remind that probably we could add check for a symlinks and other filetypes? I personally prefer handle all cases that I want to handle and raise the error for unknown cases.


s/enable/use/?


Sorry, I'm still not clear on what you mean - do what exactly?


parameter should be named "likeStatus"


Yes. Look at the closed issues.


Now, `mountedSecrets` is an array of strings, right? Could we just join them by space?


yeah , its a mistake. I am directly using the global variables. Will fix it.


This is some next level coding. Hope one day I will become as knowledgeable as you are.


This is good, from indentation to logic implementation. We shall discuss it a little though, for as you probably noticed, the way this file has been organized is by following some *opinionated* guideline. Plus, it's using an [IIFE](https://en.wikipedia.org/wiki/Immediately-invoked_function_expression) which serves a specific purpose.


oh yeah, I forgot about that


jwtPublicKey?


I've now fixed this, and also the utf8utils.c comments.

Actually I could find 269 occurrences of double slash comments, but you are right. We have agreed to using the legacy version and I was generally using it, but I forgot this time.

I'm using `TODO` to mark these places because at the moment I can see and remember the location where the NULness can start to manifast itself. I will open a meta-issue to encompass these issues.
`TODO  is usually parsed in IDEs and are pretty visible, that's why I used that keyword, but you could suggest something else. Perhaps I should paste in the GitHub issue number in every such comment? That sounds even more kludgey.

`TODO` here doesn't strictly mean that this is an absolutely must-do short term (but at most mid-term (a month?) in my opinion). I meant to express that the implementation is not complete and not binary safe without that. I only highlight this because you place so much emphasis on the arbitrary and binary nature of our input in most of our conversations. I just think that we should put our money where our mouth is.


Maybe we could extract this to the method because original `Execute()` now gets longer..


Because i think that it will be provided by MELON guys. So it is just hardcoded here for testing purposes. The method is there which takes "url" and "title" as arguments. Those parameters can be passed by any method later on.


:+1:  It would be more consistent with existing implementation. Logic could then be implemented in ProjectEntity as for the pledges.


In the configuration, the key seems to be encoded into base64. I'm not sure it is the more usable format.


Shouldn't at least createdDate be set by constructor, or at field level when creating a new LikeEntity?


Oh, I overlooked `%q` here... So, we can't just join them in this case.


So cute! :heart:


`defer` has performance implications and its convenience here does not outweigh the potential loss of performance. We should follow the previous pattern (or use Go's named returns if you prefer):

```
r.RLock()
checksum = r.checksum;
r.RUnlock();
return checksum;
```


yeah we need that to make the filenames "safe"


please add phpdoc for the method, and actually enable it (you have return input early in the method)
also, add some phpunit test perhaps?


Oh, sorry, I forgot about it.


Great !


Just a proposition. Could be reverted if we decide it's the job of HTML5ChainingRenderer to do that.


@maelee DWMR. What, or who, is Neville?


LGTM


I pushed this to D.O, but this, along with the initial WBM config, should have been in a feature branch.


I actually think this comment is less clear than the former.


建议一: 文件名要用英文的采用这种格式：2016-1-6-create_spice_for_console.cn.md
建议二：这个md 文件要 git checkout source; 然后放到 _post/ 目录下。 图片放在 images/blogs/spice/ 下面， 然后pull request 要发给 source branch，而不是发给master branch。
建议三：这个文件的头上要加上这个格式：
---
layout: post.cn
title:  "给ZStack VM Console 添加Spice协议支持"
date:   2016-1-6
categories: blog
author: Nan Su
category: cn_blog
---
具体可以参考： https://raw.githubusercontent.com/newbiet/zstackorg.github.io/source/_posts/2015-12-22-add-qemu-mode-to-zstack.cn.md
建议四：最好写一下改好后如何使用，以及配上插图，进行说明。同时比较一下和vnc的区别。
建议五：最好写一下还有什么缺陷，未来还需要添加什么。这样文章就完整了


I was seeing reports of people having issues with this feature causing them to be locked out of their devices across a few of the other roms out there and it may need to be rewritten for marshmallow capability.  I personally haven't had the issue or had any reports of the issue...  Quite a few people used this feature..  I am going to do some additional digging and am debating adding it back in.


When an end user checks "Auto" radio button:

1-a XMLHttpRequest is created and sent (via wifi) to the RPi (server) running appache web server
2- server run the request which is running of AutoIntTime.php. running this file update int time and return new int time to client via wifi agian

this explanation is very general and have many details that we can discuss it offline.


slave.sh now has a initroots check which saves the slaveroots to prevent the slave to be started if a slaveroot is missing.
if you change your slaveroot you need to update the lockfile with slave.sh initroots


Undo this. Prefer the hold style. It's less convenient, but the performance implications outweigh the convenience.


Should be reverted IMO, rel is not wiki syntax and there is no reason  HTML5ChainingRenderer deal with it. If we start doing automatic pseudo conversion between what looks like XHTML 1.0 and HTML 5 HTML5ChainingRenderer will be full of hack (and we don't even know that the goal was not to really put rel="_blank" in the HTML and we ends up with a WTF effect).


This copy requires a lock.


The fix for issue "Last row margin #54"
The last grid was ignored. Don't know why.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 181](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=624&buildTypeId=XbimEssentials_XbimEssentials) is now running


图片要放在 images/blogs/spice/ 目录下，这样就使用相对路径，所有的图片的格式都写成下面的样子，
<img src="/images/blogs/spice/1.jpg" class="center-img img-responsive">


1) Dereferencing inet_ntop result is wrong, it just converts first character of the string to address.
2) You just return `dst` in the case of success and NULL (`vm::null` is useful there) in the case of failure.


建议一: 文件名要用英文的采用这种格式：2016-1-6-create_spice_for_console.cn.md
建议二：这个md 文件要 git checkout source; 然后放到 _post/ 目录下。 图片放在 images/blogs/spice/ 下面， 然后pull request 要发给 source branch，而不是发给master branch。
建议三：这个文件的头上要加上这个格式：
```
---
layout: post.cn
title:  "给ZStack VM Console 添加Spice协议支持"
date:   2016-1-6
categories: blog
author: Nan Su
category: cn_blog
---
```
具体可以参考： https://raw.githubusercontent.com/newbiet/zstackorg.github.io/source/_posts/2015-12-22-add-qemu-mode-to-zstack.cn.md
建议四：最好写一下改好后如何使用，以及配上插图，进行说明。同时比较一下和vnc的区别。
建议五：最好写一下还有什么缺陷，未来还需要添加什么。这样文章就完整了


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 181](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=624&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:40


I consider AddServer and RemoveServer methods to be an allowable set of exported methods. Why did you unexport them?


Can we use 'ServerCount()` instead?


toler**a**nce


It looks like `impl<T> From<[T; 0]> for () { .. }` is missing from here.


Yeah, Anastasia did a brilliant artwork. Maybe it's ok to make a logo even bigger. ^__^


I don't think we need it now.


tring should be string


%{_infodir} refers to /usr/share/info that's correct.

hello.info is under doc dir.

Do you know how it comes to %{_info}?


Copy paste mistake, should be machine variant ;)


Heh, I agree.. however, there's no "prepend" method.. and I tried to stay consistent with the previous groups of func falls.. which do the same for the "data" dir.

I'll rework and propose something different.


Minor nit: Since you changed 114 to a guard, you could use `otherwise` here.


Did you benchmark and find that this was in fact more performant?


why remove the lock?


лучше «который позволяет программам и скриптам динамически получать доступ к документу и обновлять его содержимое, структуру и стили».


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1127](http://teamcity.monogame.net/viewLog.html?buildId=13383&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@Ocramius yes have a look at the example in the referenced issue https://github.com/doctrine/dbal/issues/2248. The fulltext non-unique index is dropped in favour of the unique constraint defined (as the constraints are fullfilled according to DBAL: `Index::isFullfilledBy()`). However IMO this method should not be used in such scenarios anymore, as it's purpose is solely to tell whether two indexes COULD be "the same" and one of them COULD be dropped silently. The example in the issue shows it perfectly. If you evaluate the physical constraints, the regular fulltext index can easily be discarded in favour of the unique index. If you evaluate other semantics like fulltext searchability in this case, the regular fulltext index clearly has the right to live on its own. The point really is, the Doctrine cannot and should not do those kinds of evaluations for the user has Doctrine cannot know the reasoning behind multiple similar index definitions... Just 2 my 0.02$


Of course, `not` and `or` are part of the C++ language.


Sorry, it seems that I can not create a pull request from a single commit.
Please feel free to create a pull request, for those 2 lines, from your own fork.


Oja, dit was een foutje van mij. Vanmorgen vergeten weg te halen.


It'll do for now.

In anticipation of what's next though, let's think about this feature some more. Besides changing the look of the icon upon clicking, a side-effect action will have to be triggered: actually *playing* or *pausing* the song. It's quite likely that we will use the very song's state (*playing* or *paused*) to infer what the icon should look like, instead of relying on the click event.

Let's say we have a `playerBar` "module" at our disposal, exposing a `songPlayer` object acting as the central hub for interacting with the songs. In terms of code, playing a song could be expressed like this (wishful coding):

``` html
<span class='ion-play'
                      ng-show="!playerBar.songPlayer.currentSong.playing"
                      ng-click="playerBar.songPlayer.play()">
</span>
```

You'll make your own mind up when you get started implementing this feature in a couple of checkpoints.


why an empty struct?


That seams overly complicated, why not simply ? :

```diff
-        for port in ('debian', 'rpm'):
-            if port in d and (FORMAT == port or
-                    (FORMAT == 'deb' and port == 'debian')):
+        if FORMAT == 'rpm':
                for k in ('engine', 'install_to', 'description', 'depends', 'provides'):
                    if k in d[port]:
                        setattr(package, k, d[port][k])

-        for port in ('arch', 'fedora', 'suse'):
+        for port in ('debian', 'arch', 'fedora', 'suse'):
            if DISTRO == port and port in d:
                for k in ('engine', 'install_to', 'description', 'depends', 'provides'):
                    if k in d[port]:
                        setattr(package, k, d[port][k])
```


This, through :14 is redundant. Could be removed?


The short story is that JSON Resource has emerged as a reasonable alternative as well, and that is a more likely path for the future of serializing in Rails (besides jbuilder). But it's fine for AMS to co-exist alongside that, as a gem.


Can you revert this code because default camera not replace by snapdragon camera


It's now up-to-date with tag 'LA.BF.1.1.1-00110-8x74.0'


`.then(res.json)` should do the same thing and be more readable :+1:


good


No not yet - we have a card to add the checks that would go in here


Huh, dit is al weg gehaald?


I believe @dansimau preferred the this way. That's why I changed it


No problem mate.


@jwolski, @thanodnl @danielheller
We had a discussion about the defer locks being less performant and I chose this route because it's safer and more readable. I believe we came to the conclusion that if we see performance problems we change it then and only there were it is necessary. I believe Nils said that it's a 3x performance loss. I am not sure how impactful that is on locking. Do you agree/disagree? I'd like to hear your thoughts on this.


1. 소개

M.O.I.M 은 한국어로 모임을 뜻하는 협업관리 프로그램(Collaboration tool) 입니다.

일을 할 때, 혼자 하기보다는 여러사람과 함께 협업을 하는일이 늘어가고 있습니다.

협업을 시작할 때 프로젝트를 진행할 간트차트를 제작하고 시작합니다.

하지만 제작을 해도 일정에 맞게 실천하기가 어렵습니다. 왜냐하면 직접 들어가서 프로젝트를 확인해야 하고,

일이 많을때는 뭘 먼저 해야하는지 이 팀에서 내가 해야하는 일이 무엇인지 알기가 힘들기 때문입니다.

이런 것들을 쉽게 관리해주는 프로그램이 있으면 좋을 것이라고 생각했기 때문에 이 프로젝트를 시작하게 되었습니다.

2. 기능

안드로이드, 아이폰, 웹 세가지가 연동되어 사용자에게 더욱 편리한 기능을 제공합니다.

android studio , x-code(objective-c) , java script 를 사용하였으며,

서버는 parse를 사용하였습니다. parse에는 공개된 API가 있기 때문에 처음 사용하는 사람도 쉽게 이용이 가능합니다.

- 테스크 태그
- 위젯
- 알림
- 전체 일정관리
- 개인화페이지

주요 기능으로는 간트차트, 팀 일정, 개인 인정 등을 관리해주며, 작업에 담당자를 추가해서 본인이 할당된 일을 볼 수 있도록 합니다.

시각적으로 할 일과 한 일을 구별할 수 있도록 체크박스와 그래프를 도입할 것입니다.

해야 할 일이 얼마나 남았는지, 누가 수행해야 하는지에 따라 적절한 알림기능과 시각적 피드백 제공하며,

더 개인적이고 세분화된 일정관리를 할 수 있도록 개인화 페이지를 추가합니다.

3. 기대효과

SW 이외의 모든 분야의 협업에 도움이 됩니다.

프로젝트 기간 관리가 용이합니다.

프로젝트 진행 일정 관리 및 프로젝트 결과물 품질 향상에 도움을 줍니다.

오픈소스로 개발하기 때문에 다양한 기능이 추가될 수 있고, 추가적으로 새로운 플랫폼에 적용할 수 있습니다.

youtube 링크 : https://youtu.be/BFfHUAYMys8

사용한 오픈소스 이름 및 홈페이지
https://github.com/google/iosched


 > The fulltext non-unique index is dropped

Ah yes, that one I was aware of.


Судя по макетам WhatsNew, тут всё же должны быть длинные названия. Или всё переиграли?


 > cannot

Exceptions then. We should think about how to do that, but can't do it in the 2.x series.


buildings не нужно с большой буквы, это же не заголовок


Yeah, I prefer the latter comment (sans typo). But I don't think it really matters. It's just personal preference.

Bear in mind that the audience for this sentence are humans, via the godoc documentation. The type system already documents the specifics of what is returned (i.e. a boolean).


Probably want to remove secret from this example or replace it with something which looks less real - this way, even if the key has already been deactivated, people won't contact us that we have secrets in the code...


Out of interest, how is this different to `List[Option[A]].flatten`?

``` diff
 +      val pairs = maybeLocations collect {
 +        case Some(v) => v
 +      }
```


111101900_MSHeatPump (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


С большой буквы все строки.


[ECMAScript](http://www.ecmascript.org/) (сокращенно *ES*) — это стандартизованная спецификация скриптового языка программирования, используемая в качестве основы языками JavaScript, JScript и ActionScript.


We decided on moving the locks to the exported functions only. I think renaming this to computeChecksumNoLock is appropriate and I'll do so


With frozen string literals, it cannot be mutable.


Желательно укоротить до длины русской строчки, так как не будет помещаться ни в настройках, ни в WhatsNew.


@nerdstep, I've deleted the ozp-integration branch that had the modifications to ism-u.config.js and bootstrap-classify.js. I have a new branch called ozp-integ that has only one (significant) difference from master, the addition of a bower.json file. So, if/when you decide to start your own repository we will point to that instead, provided the bower.json file is there. Let us know. And thanks for writing this thing.


I prefer to set the `subject` to match each `describe` block, so I know I'm testing the right method in each test. This would be:

```ruby
describe "#total_friends" do
  subject { introvert.total_friends }
  it "return 0 when no friends" do
    subject.must_equal 0
  end

  it "returns total no of friends" do
    stub_friends(friends) do
      subject.must_equal 2
    end
  end
end
```

And the same for the other tests you added. This is ultimately up to you though; feel free to leave it as-is if you prefer.


@smcv

(see diff in previous message)

I can't think of any Debian derivative that would need special porting in the .yaml files; the run-time checks for available engines seems to be good enough. (e.g., Raspbian only get the `all` packages from contrib & non-free)


I did not, but I cannot image the standard library has a function that does has a non optimal string joiner...


Ah, you're right.


Not sure why this is done. I'd deem it unnecessary unless we have established/communicated that this a codebase-wide best practice.


Its not working, error event is not working ?


暂时不支持火狐，之后用统一SVG来实现算了，记录为TODO为好


I found a decent refactor to make this a non issue, I will push the code after looking over your other comments.


I thought of the same thing. Your changes are correct.


Remove it


remove


=1 :-)


and this comment is already obsolote :sweat:


Соглашение по управлению версиями ECMAScript было предметом горячих споров. Мы часто ссылаемся на ES5 (воспринимается большинством браузеров), ES6 (будущее JavaScript) и даже ES7 (далекое будущее JavaScript), но официальным названием ES6 на самом деле является ES2015. Разработчики спецификации намереваются выпускать новую версию каждый год, что позволит языку развиваться быстрее чем когда-либо. Тем не менее, большинство разработчиков используют термины ES5 и ES6.


Before i tried a map[string]bool. @thanodnl did not like that the value of the bool could differ from the check go does to see if the key exists in the map:
```
exits, ok := r.serverExists[server]
// exists could possible be non equal to ok
```

Also I believe this is the way you implement a set in go. I'm ok with both ways but this one has caused some confusion it seems.


Just testing commit comments.


remove code is already in the namespace -- see line 62


:ok:


Also struct{} takes 0 bytes


remove. This has to go as template parameter of the class!


track me here what i did one by one here: https://github.com/hamnan1945?tab=activity


// FIXME: This is a messy way to do it


redundant star for folders (*.idea/ -> .idea/ and *.targer/ -> .target/)


change to getOrientation


change to getDirection


我多加了这一行，为了测试多次commit


This function aught to be called by functions that lock. I will put a comment that says something along those lines


thank you for the prompt fix


edit try catch


Well, I agree with you in this use case. I will rebase my patches to address issues pointed.
This case isn't problem to address at all. Accepted.


Righto. I forgot about the 0-byte thing. I'm good with the empty struct. Nothing to see here.


missing cubical complex. Change to template <typename CC, typename KSpace>


Это тебе лучше Игоря спросить.


I have a hard time reading this flow graph. Can we spread it out a bit so the different sub stages doesn't overlap?


Removed the duplicate import statement.


Can we call this `copyServers` instead?


remove defer.


remove defer


[JSON (JavaScript Object Notation)](http://www.json.org/) — это легковесный формат обмена данными. Широко используется в [RESTful](https://en.wikipedia.org/wiki/Representational_state_transfer)-сервисах. Данные в этом формате просты для восприятия как людьми (данные легко читать и писать), так и компьютерами (данные легко анализировать и генерировать).


I have not released yet. It is on `1.0.0`, so I'll see if I can push it to router5@1.3.0


remove defer. This is a particular hotspot in the code base.


For these two private vars only, but not the 3 othe upcased ones ?


Agree with your point of view about glib dependency. Not a big deal. In upcoming rebase I have replaced these (and many more) g_strdup_printf() with cve_string_dup_printf().


What I meant was, declare message as mutable with `String.new`:

```rb
message = String.new("Unused #{variable_type(variable)} - `#{variable.name}`.")
```

Then, it should be possible to concatenate using `<<` and not creating a new object.


No, we would also like administrative users to be able to see personalisation panes, even though they would not use them and many of them would be empty for non-provider users.


Надо убедиться, что на итальянском текст помещается полностью.


do not blow up signature! Previous was better.


尝试对指定代码行做评论


change pyside to wx here


FTR: let's revert this until we can figure out how we want to rework exceptions in the new model.


Sounds good. Thanks.


И на остальных длинных строках тоже.


change pyside_display to pyqt5_display here


On second thought I agree. I usually prefer if the methods exported by an api are orthogonal. These seem quite essential though.


change pyside to pyqt5 here


尝试对指定代码行做评论2


chrome 不支持 svg, 只能 blur(...).

On Wed, Jan 6, 2016, 9:52 PM Chen.Yanshen <notifications@github.com> wrote:

> 暂时不支持火狐，之后用统一SVG来实现算了，记录为TODO为好
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BangumiMoe/rin-webui/commit/51f68567343045de676eb0585f1f76418f5b348b#commitcomment-15290652>
> .
>


I don't think it is, in this case, you can think of `collect` as a general pattern which can achieve `flatten`'s behaviour


尝试对commit做评论


This is already done, see aa8c200808824c61f2c46ed1eb948c759c9483c2.


Addressed with cve_string_dup_printf(). I think we need to avoid asprintf() in the wild, except in cve_string implementation for now to reduce number of changes when we consider to replace GNU specific asprintf().


what is the difference between close and quit?


Reverting the changes in the already migrated code is not useful as we want to keep the commit for migration and renaming separated. Should be done before and then adapt the migration.


io;op


Now we have a section called "Writing more views" without writing the first one, and the views.index is mentioned in the urlpatterns.


Gotcha. Thanks for the info :)


Variable `--text-primary-color` is Text Color on Primary Color. This variable is important. Also Importnat is `--text-accent-color`. Check out the Color Palette https://www.google.com/design/spec/style/color.html#color-color-palette

`Light Blue` have black font...


store reference to KSpace as a member of the class. Use constructor to do so. You can also use init(ConstAlias KSpace & kspace); to initialize. But better check if one could get KSpace from CubicalComplex class. maybe there is an interface to do so.


agreed


Good point - this was my fault


// FIXME: This is a messy way to do it


I'll edit this


http://semver.org/

> Given a version number MAJOR.MINOR.PATCH, **increment the:**

> 1. **MAJOR version when you make incompatible API changes,**
2. MINOR version when you add functionality in a backwards-compatible manner, and
3. PATCH version when you make backwards-compatible bug fixes.


renamed


111101900_MSHeatPump (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1995 of 1995 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


You can do

```js
simple.mock(Log.console, 'log', function () {})
```

for stubbing and then

```js
simple.restore()
```

for restoring


What version of the API doc did you create here? I am missing my nifty image.


DeploymentController::abort is missing a docblock.


line 23: "When I click the first tab link" should say ...second...


huhu


Backported to `v1.4.x` as bf35d53 by @Narretz :+1:


Use typedef with enum locktype.
Added LT_MAX and assert() checks for enum locktype where appropriate to catch possible out of bound access. I think _MIN isn't necessary because enum item should be >= 0. When item less than 0 added to the enum we probably should add LT_MIN.