[R/feature_ignore_singletons.R:37:15:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/feature_ignore_singletons.R#L37) *style:* **Commas should never have a space before.**
```r
    segsites[ , !is_singleton]
             ~^
```
[R/feature_ignore_singletons.R:48:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/feature_ignore_singletons.R#L48) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_msms_arg.ign_singletons <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_ignore_singletons.R:52:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/feature_ignore_singletons.R#L52) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_scrm_arg.ign_singletons <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_ignore_singletons.R:56:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/feature_ignore_singletons.R#L56) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_seqgen_arg.ign_singletons <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_mutation.R:140:9:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/feature_mutation.R#L140) *style:* **Commented code should be removed.**
```r
#       model <- addFeature(model, "gamma.categories", parameter=categories.number)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_mutation.R:143:7:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/feature_mutation.R#L143) *style:* **Commented code should be removed.**
```r
#     return(model)
      ^~~~~~~~~~~~~
```
[R/feature_mutation.R:152:5:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/feature_mutation.R#L152) *style:* **Commented code should be removed.**
```r
#   model <- addFeature(model, 'mutation', parameter = middle_rate, group = group)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_recombination.R:47:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/feature_recombination.R#L47) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_seqgen_arg.recombination <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_selection.R:178:36:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/feature_selection.R#L178) *style:* **Commas should never have a space before.**
```r
                        n_pop, " " , paste(start_freq, collapse = " "), " ",
                                  ~^
```
[R/feature_selection.R:191:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/feature_selection.R#L191) *style:* **lines should not be more than 80 characters.**
```r
                         ifelse(feature$get_start(), 0, feature$get_time()), ", ",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_selection.R:202:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/feature_selection.R#L202) *style:* **lines should not be more than 80 characters.**
```r
                         ifelse(feature$get_start(), 0, feature$get_time()), ", ",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_sumstats.R:18:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/feature_sumstats.R#L18) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_msms_arg.seg_sites_feat <- conv_to_ms_arg.seg_sites_feat
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_sumstats.R:22:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/feature_sumstats.R#L22) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_scrm_arg.seg_sites_feat <- conv_to_ms_arg.seg_sites_feat
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_sumstats.R:26:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/feature_sumstats.R#L26) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_seqgen_arg.seg_sites_feat <- conv_to_ms_arg.seg_sites_feat
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/import_popgenome.R:17:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/import_popgenome.R#L17) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.segsites.GENOME <- function(data, only_synonymous = FALSE, ...) {
^~~~~~~~~~~~~~~~~~
```
[R/import_popgenome.R:41:43:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/import_popgenome.R#L41) *style:* **Commas should never have a space before.**
```r
      seg_sites <- bam[c(pops, outgroup), , drop = FALSE]
                                         ~^
```
[R/model_getters.R:74:21:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/model_getters.R#L74) *style:* **Commas should never have a space before.**
```r
  if (sum(llm[group , c(1:2, 4:5)]) == 0) return(llm[group , 3])
                   ~^
```
[R/model_getters.R:74:60:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/model_getters.R#L74) *style:* **Commas should never have a space before.**
```r
  if (sum(llm[group , c(1:2, 4:5)]) == 0) return(llm[group , 3])
                                                          ~^
```
[R/model_getters.R:81:25:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/model_getters.R#L81) *style:* **Commas should never have a space before.**
```r
  min(which(cumsum(llm[ , "number"]) >= locus))
                       ~^
```
[R/model_getters.R:124:46:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/model_getters.R#L124) *style:* **Commas should never have a space before.**
```r
  numbers <- get_locus_length_matrix(model)[ , "number"]
                                            ~^
```
[R/model.R:93:39:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/model.R#L93) *style:* **Commas should never have a space before.**
```r
  sum(get_locus_length_matrix(model)[ , c(1:2, 4:5)]) > 0
                                     ~^
```
[R/model_simulate.R:36:3:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/model_simulate.R#L36) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  }, mc.set.seed = TRUE, mc.cores = cores)
  ^
```
[R/parameter.R:132:11:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/parameter.R#L132) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      if ((!is.numeric(value)) || length(value) != 1) {
          ^
```
[R/segsites.R:18:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/segsites.R#L18) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.matrix.segsites <- function(x, ...) get_snps(x)
^~~~~~~~~~~~~~~~~~
```
[R/segsites.R:31:19:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/segsites.R#L31) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  create_segsites((matrix(c(1, 1, 0, 1, 1,
                  ^
```
[R/segsites.R:96:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/segsites.R#L96) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.segsites.default <- function(data, ...) {
^~~~~~~~~~~~~~~~~~~
```
[R/segsites.R:101:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/segsites.R#L101) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.segsites.list <- function(data, ...) {
^~~~~~~~~~~~~~~~
```
[R/simulator_class.R:55:3:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/simulator_class.R#L55) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  }, character(1L))
  ^
```
[R/simulator_class.R:67:44:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/simulator_class.R#L67) *style:* **Commas should never have a space before.**
```r
  grouped_commands <- unique(sim_commands[ , 2])
                                          ~^
```
[R/simulator_class.R:70:36:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/simulator_class.R#L70) *style:* **Commas should never have a space before.**
```r
    sum(sim_commands[sim_commands[ , 2] == cmd, 1])
                                  ~^
```
[R/simulator_msms.R:101:41:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/simulator_msms.R#L101) *style:* **Commas should never have a space before.**
```r
        paste("msms", sample_size, cmd[ , 1], cmd[ , 2])
                                       ~^
```
[R/simulator_msms.R:101:52:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/simulator_msms.R#L101) *style:* **Commas should never have a space before.**
```r
        paste("msms", sample_size, cmd[ , 1], cmd[ , 2])
                                                  ~^
```
[R/simulator_ms.R:71:9:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/simulator_ms.R#L71) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
        }, character(1))
        ^
```
[R/simulator_ms.R:86:39:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/simulator_ms.R#L86) *style:* **Commas should never have a space before.**
```r
        paste("ms", sample_size, cmd[ , 1], cmd[ , 2])
                                     ~^
```
[R/simulator_ms.R:86:50:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/simulator_ms.R#L86) *style:* **Commas should never have a space before.**
```r
        paste("ms", sample_size, cmd[ , 1], cmd[ , 2])
                                                ~^
```
[R/simulator_scrm.R:84:41:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/simulator_scrm.R#L84) *style:* **Commas should never have a space before.**
```r
        paste("scrm", sample_size, cmd[ , 1], cmd[ , 2])
                                       ~^
```
[R/simulator_scrm.R:84:52:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/simulator_scrm.R#L84) *style:* **Commas should never have a space before.**
```r
        paste("scrm", sample_size, cmd[ , 1], cmd[ , 2])
                                                  ~^
```
[R/simulator_seqgen.R:54:4:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/simulator_seqgen.R#L54) *style:* **Commented code should be removed.**
```r
  #print(cmd)
   ^~~~~~~~~~
```
[R/simulator_seqgen.R:129:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/simulator_seqgen.R#L129) *style:* **lines should not be more than 80 characters.**
```r
                                        sample_seed(length(trees[[locus_group]])))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simulator_seqgen.R:154:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/simulator_seqgen.R#L154) *style:* **lines should not be more than 80 characters.**
```r
                                                              ignore_variation = TRUE),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat_ihh.R:19:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/sumstat_ihh.R#L19) *style:* **lines should not be more than 80 characters.**
```r
    initialize = function(name, population, max_snps, calc_ihs, transformation) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat_ihh.R:52:45:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/sumstat_ihh.R#L52) *style:* **Commas should never have a space before.**
```r
                      iHS = data.frame(ihh[ , 1:2], iHS = rep(NA, n_snps))))
                                           ~^
```
[R/sumstat_ihh.R:54:15:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/sumstat_ihh.R#L54) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          if ((n_snps < 50)) freqbin <- 0.90
              ^
```
[R/sumstat_ihh.R:55:20:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/sumstat_ihh.R#L55) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          else if ((n_snps < 100)) freqbin <- 0.45
                   ^
```
[R/sumstat_ihh.R:56:20:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/sumstat_ihh.R#L56) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          else if ((n_snps < 200)) freqbin <- 0.225
                   ^
```
[R/sumstat_ihh.R:57:20:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/sumstat_ihh.R#L57) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          else if ((n_snps < 400)) freqbin <- 0.1
                   ^
```
[R/sumstat_ihh.R:60:55:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/sumstat_ihh.R#L60) *style:* **Commas should never have a space before.**
```r
            data.frame(ihh2ihs(ihh, freqbin)$res.ihs[ , -4])
                                                     ~^
```
[R/sumstat_omega.R:14:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/sumstat_omega.R#L14) *style:* **lines should not be more than 80 characters.**
```r
    initialize = function(name, min_win, max_win, grid, binary, transformation) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat.R:192:6:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/sumstat.R#L192) *style:* **Commented code should be removed.**
```r
    #assert_that(is.list(tree_list))
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat.R:193:6:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/sumstat.R#L193) *style:* **Commented code should be removed.**
```r
    #assert_that(length(tree_list) == get_locus_number(model))
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat_seg_sites.R:41:38:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/R/sumstat_seg_sites.R#L41) *style:* **Commas should never have a space before.**
```r
    trio_segsites <- seg_sites[[i]][ , left | middle | right]
                                    ~^
```
[tests/testthat/test-feature-ign-singletons.R:13:45:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-feature-ign-singletons.R#L13) *style:* **Commas should never have a space before.**
```r
               list(create_test_segsites()[ , -c(1, 3)],
                                           ~^
```
[tests/testthat/test-feature-ign-singletons.R:14:45:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-feature-ign-singletons.R#L14) *style:* **Commas should never have a space before.**
```r
                    create_test_segsites()[ , -c(1, 3)]))
                                           ~^
```
[tests/testthat/test-model-class.R:241:44:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-model-class.R#L241) *style:* **Commas should always have a space after.**
```r
               data.frame(name = c("theta","tau"),
                                           ^
```
[tests/testthat/test-search-executables.R:30:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-search-executables.R#L30) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-segsites-class.R:15:41:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-segsites-class.R#L15) *style:* **Put spaces around all infix operators.**
```r
  expect_error(create_segsites(snps, 1:4/10))
                                       ~^~
```
[tests/testthat/test-segsites-class.R:16:46:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-segsites-class.R#L16) *style:* **Put spaces around all infix operators.**
```r
  expect_error(create_segsites(snps, pos, 1:4/10))
                                            ~^~
```
[tests/testthat/test-segsites-class.R:22:40:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-segsites-class.R#L22) *style:* **Put spaces around all infix operators.**
```r
  segsites <- create_segsites(snps, 1:3/10)
                                      ~^~
```
[tests/testthat/test-segsites-class.R:30:31:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-segsites-class.R#L30) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  segsites <- create_segsites((matrix(c(1, 1, 0, 1, 1,
                              ^
```
[tests/testthat/test-segsites-class.R:36:26:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-segsites-class.R#L36) *style:* **Commas should never have a space before.**
```r
  ss_subset <- segsites[ , 1:2]
                        ~^
```
[tests/testthat/test-segsites-class.R:38:64:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-segsites-class.R#L38) *style:* **Commas should never have a space before.**
```r
  expect_equivalent(as.matrix(ss_subset), as.matrix(segsites)[ , 1:2])
                                                              ~^
```
[tests/testthat/test-segsites-class.R:41:30:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-segsites-class.R#L41) *style:* **Commas should never have a space before.**
```r
  expect_equal(dim(segsites[ , 1]), c(3, 1))
                            ~^
```
[tests/testthat/test-segsites-class.R:42:33:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-segsites-class.R#L42) *style:* **Commas should never have a space before.**
```r
  expect_equal(dim(segsites[1:2 , ]), c(2, 3))
                               ~^
```
[tests/testthat/test-segsites-class.R:43:32:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-segsites-class.R#L43) *style:* **Commas should never have a space before.**
```r
  expect_equal(dim(segsites[-2 , 1:3]), c(2, 2))
                              ~^
```
[tests/testthat/test-simulator-ms.R:7:73:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-simulator-ms.R#L7) *style:* **Put spaces around all infix operators.**
```r
  expect_equal(parse_ms_positions("positions: 0.1 0.2 0.3 0.4 0.5"), 1:5/10)
                                                                       ~^~
```
[tests/testthat/test-simulator-seqgen.R:213:6:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-simulator-seqgen.R#L213) *style:* **Commented code should be removed.**
```r
  #  model.addMutationRateHeterogenity(model.hky, 0.1, 5, categories.number = 5)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-simulator-seqgen.R:236:6:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-simulator-seqgen.R#L236) *style:* **Commented code should be removed.**
```r
    #feat_migration(par_zero_inflation(1, .5), symmetric = TRUE)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-simulator-seqgen.R:274:27:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-simulator-seqgen.R#L274) *style:* **Commas should always have a space after.**
```r
  model <- coal_model(c(5,5,2), 1, 100) +
                          ^
```
[tests/testthat/test-simulator-seqgen.R:274:29:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-simulator-seqgen.R#L274) *style:* **Commas should always have a space after.**
```r
  model <- coal_model(c(5,5,2), 1, 100) +
                            ^
```
[tests/testthat/test-sumstat-jsfs.R:4:3:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L4) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  seg.sites.3.pop <- list(create_segsites(matrix(c(1, 0, 1, 0,
  ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:10:60:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L10) *style:* **Commas should never have a space before.**
```r
                                                   1, 0, 1 ,0 ),
                                                          ~^
```
[tests/testthat/test-sumstat-jsfs.R:10:61:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L10) *style:* **Commas should always have a space after.**
```r
                                                   1, 0, 1 ,0 ),
                                                            ^
```
[tests/testthat/test-sumstat-jsfs.R:11:54:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L11) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                    ~^~
```
[tests/testthat/test-sumstat-jsfs.R:11:62:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L11) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                            ~^~
```
[tests/testthat/test-sumstat-jsfs.R:13:3:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L13) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1:2, 3:4, 5:7))
  ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:13:27:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L13) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1:2, 3:4, 5:7))
                          ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:14:13:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L14) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  expect_is(jsfs.3.pop, "array")
            ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:15:21:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L15) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  expect_equivalent(jsfs.3.pop, array(c(0, 0, 0, 0, 0, 0, 0, 0, 0,
                    ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:18:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **lines should not be more than 80 characters.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:18:73:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                       ~^~
```
[tests/testthat/test-sumstat-jsfs.R:18:78:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Commas should always have a space after.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                             ^
```
[tests/testthat/test-sumstat-jsfs.R:18:80:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Commas should always have a space after.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                               ^
```
[tests/testthat/test-sumstat-jsfs.R:18:82:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                                ~^~
```
[tests/testthat/test-sumstat-jsfs.R:21:3:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L21) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  seg.sites.3.pop <- list(create_segsites(matrix(c(1, 0, 1, 0,
  ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:27:60:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L27) *style:* **Commas should never have a space before.**
```r
                                                   1, 0, 1 ,0 ),
                                                          ~^
```
[tests/testthat/test-sumstat-jsfs.R:27:61:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L27) *style:* **Commas should always have a space after.**
```r
                                                   1, 0, 1 ,0 ),
                                                            ^
```
[tests/testthat/test-sumstat-jsfs.R:28:54:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L28) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                    ~^~
```
[tests/testthat/test-sumstat-jsfs.R:28:62:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L28) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                            ~^~
```
[tests/testthat/test-sumstat-jsfs.R:30:3:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L30) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1, 2:6, 7))
  ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:30:27:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L30) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1, 2:6, 7))
                          ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:31:21:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L31) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  expect_equivalent(jsfs.3.pop, array(c(0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0,
                    ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:32:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **lines should not be more than 80 characters.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:32:82:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Put spaces around all infix operators.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ~^~
```
[tests/testthat/test-sumstat-jsfs.R:32:87:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Commas should always have a space after.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:32:89:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Commas should always have a space after.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:32:91:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Put spaces around all infix operators.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ~^~
```
[tests/testthat/test-sumstat-jsfs.R:33:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L33) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test-sumstat-jsfs.R:53:41:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L53) *style:* **Commas should always have a space after.**
```r
  jsfs <- calc_jsfs(seg.sites, list(c(1,3), c(2,4)))
                                        ^
```
[tests/testthat/test-sumstat-jsfs.R:53:49:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L53) *style:* **Commas should always have a space after.**
```r
  jsfs <- calc_jsfs(seg.sites, list(c(1,3), c(2,4)))
                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:58:41:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L58) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,3), c(2,5)))
                                        ^
```
[tests/testthat/test-sumstat-jsfs.R:58:49:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L58) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,3), c(2,5)))
                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:59:41:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L59) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,7), c(2,3)))
                                        ^
```
[tests/testthat/test-sumstat-jsfs.R:59:49:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L59) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,7), c(2,3)))
                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:141:40:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-jsfs.R#L141) *style:* **Put spaces around all infix operators.**
```r
                                    1:4/4))
                                      ~^~
```
[tests/testthat/test-sumstat-mcmf.R:13:51:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-mcmf.R#L13) *style:* **Put spaces around all infix operators.**
```r
  expect_equal(calc_mcmf(seg_sites, 2:4, FALSE), 2/3)
                                                 ~^~
```
[tests/testthat/test-sumstat-mcmf.R:70:63:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-mcmf.R#L70) *style:* **Put spaces around all infix operators.**
```r
                              coal_model(4) + locus_trio()), 1/3)
                                                             ~^~
```
[tests/testthat/test-sumstat-omega.R:7:5:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-omega.R#L7) *style:* **Use two spaces to indent, never tabs.**
```r
1.11	1.000000
    ^
```
[tests/testthat/test-sumstat-omega.R:8:5:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-omega.R#L8) *style:* **Use two spaces to indent, never tabs.**
```r
2.22	0.200000
    ^
```
[tests/testthat/test-sumstat-omega.R:9:5:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-omega.R#L9) *style:* **Use two spaces to indent, never tabs.**
```r
3.33	0.030000
    ^
```
[tests/testthat/test-sumstat-pi.R:7:67:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-pi.R#L7) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 1, 1, 1), 5, 3), 1:3/5)
                                                                 ~^~
```
[tests/testthat/test-sumstat-pi.R:26:67:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-pi.R#L26) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 1, 1, 1), 5, 3), 1:3/5)
                                                                 ~^~
```
[tests/testthat/test-sumstat-segsites.R:28:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-segsites.R#L28) *style:* **lines should not be more than 80 characters.**
```r
  seg_sites_trio[[1]] <- create_segsites(get_snps(seg_sites_trio[[1]][ , c(1:2, 4:6, 8:9)]),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-segsites.R:28:72:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-segsites.R#L28) *style:* **Commas should never have a space before.**
```r
  seg_sites_trio[[1]] <- create_segsites(get_snps(seg_sites_trio[[1]][ , c(1:2, 4:6, 8:9)]),
                                                                      ~^
```
[tests/testthat/test-sumstat-sfs.R:62:40:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-sfs.R#L62) *style:* **Put spaces around all infix operators.**
```r
                                    1:4/4))
                                      ~^~
```
[tests/testthat/test-sumstat-tajimas-d.R:14:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-tajimas-d.R#L14) *style:* **lines should not be more than 80 characters.**
```r
                                 0, 0, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 0, 0, 0, 0),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-tajimas-d.R:27:1:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-tajimas-d.R#L27) *style:* **lines should not be more than 80 characters.**
```r
  expect_equal(tajd$calculate(list(create_empty_segsites(10)), NULL, NULL, model), NaN)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-trees.R:6:30:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-trees.R#L6) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_true(requires_trees((coal_model(5) + sumstat_trees())))
                             ^
```
[tests/testthat/test-sumstat-trees.R:7:30:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-trees.R#L7) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_true(requires_trees((coal_model(5) + sumstat_sg_trees())))
                             ^
```
[tests/testthat/test-sumstat-trees.R:8:34:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-trees.R#L8) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_false(requires_segsites((coal_model(5) + sumstat_trees())))
                                 ^
```
[tests/testthat/test-sumstat-trees.R:9:34:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-trees.R#L9) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_false(requires_segsites((coal_model(5) + sumstat_sg_trees())))
                                 ^
```
[tests/testthat/test-sumstat-trees.R:73:64:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-trees.R#L73) *style:* **Commas should always have a space after.**
```r
                                 locus_trio(locus_length = c(1,3,5),
                                                               ^
```
[tests/testthat/test-sumstat-trees.R:73:66:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-trees.R#L73) *style:* **Commas should always have a space after.**
```r
                                 locus_trio(locus_length = c(1,3,5),
                                                                 ^
```
[tests/testthat/test-sumstat-trees.R:74:60:](https://github.com/statgenlmu/coala/blob/d19910f584f4566171d96116c506fbf4872870f2/tests/testthat/test-sumstat-trees.R#L74) *style:* **Commas should always have a space after.**
```r
                                            distance = c(2,4)))
                                                           ^
```


Yeah yeah, I had just copied the basic tests that it seemed most other linters used and they all used promises.


This looks like it won't trigger if the pure dim corresponding to the innermost storage dimension has already been split/tiled. Does this logic happen before tiling?


super


OK, so "Just []" means "No extensions" and "Nothing" means "Unkown"? Might be worth a comment in the commit message


I did not know that, cool.


why why why is because 50 different ways of doing it crashed for seemingly no reason - I was getting desperate. Look at what it was changed *from*. And sorry I didn't keep the last 49 to show you.


theres a library to do this called Chance, will generate random strings, numbers for you
http://chancejs.com/


Ok, I get that error now. Still a macro thing ... :/

![asdwerwrwer](https://cloud.githubusercontent.com/assets/1466920/12334497/93386726-bafa-11e5-9f57-2809cbe4e098.PNG)


Removed two repeat sentences


@mrunalk: the change to `xwalk_content.cc` is incomplete. Later in that method we create another `scoped_ptr` from `manifest_dictionary` and pass that to the `Manifest` class. We then end up with a double deletion since both `Manifest`'s and `manifest_value`'s destructors are trying to delete the same pointer. I've fixed this and simplified the loading code a bit, please take a look at the final rebasing commit later if you're curious.


:boom: :metal:


OK.  But what I mean is that both conditions (the initial "if") and this one ("else") are the same..


Yes.  I'll update the commit message.


`if (leader ~= nil) then`
how is it nil after that? is what I was trying to say.


cool


wwwwwttttttttttfffffffffffff


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2082 of 2083 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


That's a good point. I'll think about it.

Also there was a bug if a script and action were selected for testing, but nothing was selected above.
`script = kwargs.get('script', '')` gets the script, but if it would be overwritten in the code below with `script = plexpy.CONFIG.***`.


@sbourdeauducq, it depends on widget size, it's just that wrapping is performed in 30-character increments, and yes.


That doesn't explain the *why* of choosing to apply a python source file lint tool to a .txt file. If it was some other tool than pep8 that you applied, please share the steps to run that tool.

I'm not saying that linting the .txt files is wrong, and I don't have a particular problem with these whitespace changes, but the process seems bizarre to me. I wouldn't apply python source file criteria to .txt files is all.


Stick with current "_" function naming convention


@JavascriptFTW; You forgot the "Spark" link, though.


@natthu Running React Native apps on device using an IP address has been a bit brittle for my team, so I'm looking into some improvements. I had a question about your code here, which has been moved into a setUp method but this appears to be where it was added.

When I try to use Chrome debugging on a device after setting your IP address in the AppDelegate, I always receive an error indicating that this class is using localhost instead of the IP address. If I go into this class and manually patch it with my computer's IP address, debugging in Chrome works on the device.

I like that you introduced the idea of using NSUserDefaults here to look up the port, but when I search the codebase I don't find any other instances of that default - it doesn't appear to ever be set. It's a good idea though, so in my project I've modified this code to use a 2nd user default for 'address' and then I'm setting both defaults in the AppDelegate. That allows this class to get the correct IP and port. Wanted to get your thoughts around this NSUserDefault, perhaps it referred to something that got removed elsewhere or was just an open door for an update like mine.

Another enhancement I'd love to add would be to use an XCode run script to fetch the computer's wifi IP address on launch. This way running on device wouldn't require any manual tinkering. Would love your thoughts on that as well.

If you know of another RN contributor with more experience in WebSocketExecutor-land, please tag them here or in a PM thread so we can get a productive conversation going. Since this is pretty close to core of RN Xcode functionality I'm hesitant to drop a PR without adequate discussion and testing! But if it turns out it's fairly easy to automate I think it would be great if the community could just install RN and run on device out of the box. Thanks!


Note that in Ubuntu 14.04 LTS, there is no support for 'property'


To avoid confusion with our `manifest.json`.


@adarsh-ramakrishna-sfdc I updated my fork with this code change. When I clean and compile, I get the following compilation errors:

```
[INFO] Compiling 22 source files to C:\Users\tom\Development\Java\git\ApexUnit\target\classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] \Users\tom\Development\Java\git\ApexUnit\src\main\java\com\sforce\cd\apexUnit\client\connection\ConnectionHandler.java:[118,92] error: incompatible types: String cannot be converted to int
[ERROR] \Users\tom\Development\Java\git\ApexUnit\src\main\java\com\sforce\cd\apexUnit\client\connection\ConnectionHandler.java:[185,91] error: incompatible types: String cannot be converted to int
```

I believe the type of proxyPort property in CommandLineArguments.java should be changed from a String to an Integer, because the value for the proxy port argument passed to the ConnectionConfig.setProxy method is expected to be an int, and String cannot be implicitly converted to int.


These are functions from ggplot2 and should be reverted to original names


In your .then, you can invoke the login method on the request object. Consider giving feedback to the user that a user with that email address already exists, or they might think it just doesn't work.


Its not nil because you pushed the light user data manually, which makes a
CLuaBaseEntity that itself is bound to a null pointer (pushlightuserdata
doesn't check that, because it can't). If you just push PLeader it should
be fine (or is at least more correct)


The only other way to do what you want is to implement custom painting using [QItemDelegate](https://doc.qt.io/qt-5/qitemdelegate.html), and since the log is going to look approximately equally terrible whether this is done or not, I'm not sure what the point is.


Dev/Prod environment setting or switch, maybe?


but if you DO want to make it even better, I'd do:
```
        [Fact, TestCategory("Functional"), TestCategory("Generics")]
        public async Task Generic_1Argument_NonGenericCallFirst()
        {
            var id = Guid.NewGuid();
            var nonGenericFacet = GrainFactory.GetGrain<INonGenericBase>(id, "UnitTests.Grains.Generic1ArgumentGrain");
            var exception = await Xunit.Assert.ThrowsAsync<AggregateException>(async () => await nonGenericFacet.Ping());
            Assert.IsInstanceOfType(exception.GetBaseException(), typeof(OrleansException));
        }
```


Need consistency in "if" statement spacing


Did not merge this. Prefer to reduce nesting than having two returns.


I know, but that this the syntax. It is not pretty, but we didn't make it.

https://cmake.org/cmake/help/v3.0/command/if.html


Yes, this might help quite a bit with https://github.com/broadinstitute/gatk/issues/958


Why do we need this?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1521 of 1521 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I.e. what I mean is that displaying half of the things you are putting in the log in the way you are displaying them is wrong in the first place. Compilation errors should not go in the log, for instance, they should be displayed and formatted like compilation errors.


you probably don't need this any more


for clarity sake consider renaming the route /:categoryName/items/:itemId, when you have two ids in a row in a url it can get confusing what resource the id is referring to, by putting items in the route its crystal clear


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


just put this code in the constructor and it will be called for each test. No need to add `TestInitialize` to every test.


Keep original name


Why not fix the problem at the source in the Qt layout code, instead of implementing workarounds such as QItemDelegate or this?


Really?  Sigh.  I use autocomplete a lot.  Do you know if there's an open issue for it?  Is it the autocomplete extension for js-tern?


Is there another way to push the entity? I still want to just push PlLeader, the garbage you saw was from me grasping at straws and not cleaning up before contacting you. At one point I even scrapped the entire function and looped the party in lua check each member till I found a leader, but decided *no, this is too stupid, I should be able to return the #$%^ing entity* and went back to this again.


I could set it back to `Pending`, although I've been confused about the phase transitioning back to `Pending` due to this reason :-\

Even if we set the pending state, it should not be used to calculate `PodStartLatency` because it might just be a temporary error.


this has some side effects of ucommenting all options in ssh_config

I didn't set any so it should stay commented...


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@mrunalp PTAL


typo: s/elimiation/elimination/


Thanks for this tool.  Unfortunately, it looks like it has stopped working as I get Cannot download lecture eveytime I try to download anything.


New branch `ld-direct-aeabi-memclr` is in. It is branched from `ld-direct` and brought up to date with master. With this, building with Clang fully works on my machine. I'll wait for you to test it on yours before pushing.


Because it is not a bug, it's just a decision you disagree with. Qt only does word wrap on word boundaries, this is clearly stated in the QTableView documetation.


I'm not entirely sure what would happen if this throws an exception, but we can deal with it later. Maybe add a comment to verify correct behavior


Its been the sort of morning where I give the dog coffee and try to put dogfood into the coffee maker. :warning:


whats blocker this being on stable?


Can you add a test? Seems like the kind of sensitive thing that deserves a test.


Seems like it has too big indentation, removing one tab should fix it.


yeah, that should be fixed now


How do you propose to display the compilation errors?


I think actually if you use Lunar::push and set the third optional argument
to true, it should both check for null and push nil and be properly
scoped/garbage collected, but I've never tried this
On Jan 14, 2016 12:20 PM, "TeoTwawki" <notifications@github.com> wrote:

> Its been the sort of morning where I give the dog coffee and try to put
> dogfood into the coffee maker. [image: :warning:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/TeoTwawki/darkstar/commit/e54f953b699780e5765456ea408fc9c900f6bdd8#commitcomment-15458506>
> .
>


I like it pretty. lol

Probably a bit easier to debug by seeing the string too.


Have you seen how any IDE displays compilation errors? VisualStudio, Eclipse, Qt Creator, whatever. Basically that.


moved unnecessarily


call this HostedCluster, that way you don't need to fix every test that used the variable. Also, if we later decide to use a base class, we wouldn't need to change it once again


FInally it was so annoying :dancer:


Hi Mike,
In the days after Christmas I was working on a parser for the tlm files from my DX9. After a few days I discovered your Project :-). I decided to fork your repo and add my features to the lib.
I hoped to find, how to interpret the 'rpm' value. But as I look at the code, I saw, that the implementation for rpm value was a untested assumption (which was wrong), because you do not need it with your sailplane. Im flying with a helicopter the rpm value is important. I've continued my research and after a few hours after I found the calculation function for it :-).

Some of my changes also affect the mobile app. So currently I try to build the app.
When I have tested my code, I'll submit the changes to your main branch.

I am glad that you are interested and hope that I will soon find time go on with it.

Bye
David


They're fairly particular about not spelling it as SystemD :smile:


Bad job.


Missing: <pre>#include <stdint.h></pre>


I think it's a matter of the "select this result" binding. You're typing away quickly and it brings "the rest" in helpfully. I haven't dug into issues yet.


Does this mean we're getting a proper source-built openjdk on Darwin, using a conventional binary bootstrap?


You're forgetting to close the section element


Link? :D


Does this work in the sandbox? I'd expect to find some invocations of `install_name_tool` unless I'm misunderstanding stuff :smile:

cc @pikajude


Yeah I see that. I added that before I added the action to the test. Anyway it's no biggy if you want manual selection of the script I'll fix that bug. If not the user can just choose something that happens rarly to avoid issues regarding test scripts.


Please keep indentation as in the Symfony code: http://symfony.com/doc/2.8/components/config/definition.html#variable-nodes


Isn't this usually spelled with an extra 's': 'ErmessenSspielraum'? Not entirely sure though.


Inherit from OrleansTestingBase. That way you inherit the members such as `GrainFactory` which would not just make diff nicer, but also we'd be able to change the mode to use a different cluster startup if we so require, without much changes


has been? Did we actually do the registration or should we say something like "The link relation type below is pending registration by IANA per Section" and make sure one of us send the proper regristration?


I don't see why this shouldn't be lowercase.


I didn't mean that python linter applied to .txt. It was 'arc lint' which applied different techniques to different sources.


Whoops.  Messed up cleaning this up before.  Meant to fixup here but actually applied it to the last commit.  Yeah I meant to just call `new`.


So you would get path, message, etc sorted out and shortened in appropriate ways; full path would be hidden but shown via tooltip. Of course, you could poke the widget and when you do, it should launch your configured editor.

Same with exception backtraces. We should also hide ARTIQ guts by default and rather prominently place focus on the user's code, where the problem is most likely to originate.


And you have to use new CLuaBaseEntity. I think if you check the pushArg
functions in luautils.h that might be what I did


item.itemName is a bit redundant, i was under the impression you were doing filtering as a directive?


Keep function calls connected to (
e.g. function(filename = file.choose())


Why not a simple to remove extra spaces?

```
return string.strip()
```


This revision was the subject of a walk-through today: https://github.com/racket/racket/wiki/Inside-Racket-Seminar-1.-Asumu-on-Typing-Classes


Keep function calls connected to (


Perfect, thanks...would have been good to put that in the commit message :)


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (mjwitte) - i386-Windows-7-VisualStudio-12: OK (2042 of 2052 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.51%25-yellow.svg)


similar as other comments. Always call this HostedCluster for consistency. Also inherit from OrleansTestingBase


I enabled this per the "TODO".


It doesn't completely, which is why I didn't want to use a (mis-)leading strap. http://www.smbc-comics.com/?id=2075


Please keep compatibility with PHP 5.3, `[]` arrays only exist on PHP 5.4. See #149 for example.


super ;)


TeamCity pull requests :: netty [Build 1032](https://garage.netty.io/teamcity/viewLog.html?buildId=4752&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6372, ignored: 23 Build time: 01:22:59


TeamCity pull requests :: netty [Build 1034](https://garage.netty.io/teamcity/viewLog.html?buildId=4754&buildTypeId=pulls_netty&guest=1) is now running


Please don't remove Backward compatibility code.


similar: just store the HostedCluster in a HostedCluster field


Comment no longer true.


I would define a variable for this uuid instead of duplicating it in separate places


We have something like that all over luautils, but those functions have those things as their lua function compliment's arguments so didn't think it'd work out. If I don't get this to behave in my next attempt I guess I'll try that,


and here too (I'll stop pointing at these, as it's probably easier for you to do a find & replace


Abe hata to dia tha cross origin request maine.
Abhi to thik chal raha hai


I don't know much about the maven-hpi-plugin, can you explain quickly what did not work with the previous pom.xml and what the changes fix for you?


I'll think about it.

Gotta go to work.


The authors focus on the intra-patterns. I thought the last line of this par made it clear? Should I remove this point?


@stephentoub Please add a TODO and issue and comment out the code instead. This needs to be moved right after the call to GetLastError.
In most cases the beginning of an IOCP operation should never fail. If it does, it's most likely caused by incorrect arguments passed to the Win32 API.


It's all relative! :D We might be moving towards them. And I didn't want to repeatedly say "relative motion towards" etc.


inherit from OrleansTestingBase to get the logger (and also ease migration from one startup mode to other if we require)


Right you are!


move this to the constructor so there is no need to call it from every test


Hey @SupaHam may I ask why you don't do something like this?
https://github.com/HunterGPlays/Essentials/commit/daec100725c79888e6524bbe990123a7ce371cca

Also you choose to use NumberFormat instead of DecimalFormat and do some next level thing with it? Why not just make a new DecimalFormat and use "#,##0.00"?


When resizing a containing canvas, internal items were moving wrongly. Fixed.


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1505 of 1505 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Did you forgot the `html5validation` node?


Yes, I posted this commit before you responded on the PR thread.  I've already undone this locally.


Check the spelling section of http://www.freedesktop.org/wiki/Software/systemd/ :sweat_smile:


I have checked this PR and all is okay except this one.
I can't find any source that states this mob drops 4591 (Bakonawa_Card)


OK, great. I thought I had cleaned all of those functions up, but apparently I was wrong :)


Looks good to me. I just think we should state the reason in the commit message. Just like it's done in https://github.com/jberaud/ardupilot/commit/919f01789eb5e15835cd44e2293ca10bc281e637 .


TeamCity pull requests :: netty [Build 1033](https://garage.netty.io/teamcity/viewLog.html?buildId=4753&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 5873, ignored: 22 Build time: 00:31:43
### Failed tests
```
io.netty.testsuite.transport.socket.SocketConnectionAttemptTest.testConnectCancellation: <no details avaliable>

```


TeamCity pull requests :: netty [Build 1035](https://garage.netty.io/teamcity/viewLog.html?buildId=4755&buildTypeId=pulls_netty&guest=1) is now running


I didn't notice while committing this.
reverted in the next commit.


I don't think the base class should define `IClassFixture<StreamFilteringTestsFixture>`. Instead, each of the concrete classes should define which fixture to use. Now I believe the concrete classes are actually not testing the correct thing, as the main difference was which silo configuration to use.
Also, please inherit from OrleansTestingBase.


django-filters ou django-filter ?


You're right, and then it's recognized already.


I don't think you need to include "soc_common.h"


You don't like "climes"? It's such a nice word.

Ok, I'll split the sentence. But I'm not sure I want to continue with that analogy -- there doesn't seem to be a real need for it.

Changing to "seasonal".


This task shouldn't need these scopes.


this should be getTypeface, not getTypeFace


I don't think you need to include <stdio.h>


I forgot to edit the effect crap. I could have been done an hour ago.
![FAIL](http://spiritualhealingsource.com/wp-content/uploads/2012/06/Dunce-cap-in-corner.jpg)


kjkjkj


@PitchBright Nah this is the old branch with the old logo, if you look a little later in the messy commits you'll see the new logo... hopefully


Yes, you are right! Mea culpa :)


this should be setTypeface, not setTypeFace


@loverajoel  Very nice logo :+1:
How'd you do that?


lol nice spelling


Makes sense, thanks for posting the reference 👍


Yep. @khancyr has a branch with the fix https://github.com/khancyr/ardupilot/commit/3ac682e2fb65c6348ef9f64cab4c3880312cdb41


I found the image via WC, where there is an explanation for why the image is Public Domain. The original source doesn't provide the licence. So, I felt it best to point to the original source and link through to WC for the licence reference.


No reason. Changed to normal text.


Any reason why the adverb should be moved? No strong feelings from my side…

Second edit looks good.


Ok, excuse me... I think there is some sort of change in the code I have not seen. I wrote the methods in a "live" app with a version of the bundle, and pasted the methods directly in the checked out `master` branch.

I'll refact the method by hand, without copy&paste... The same thing I'll do for the configuration file...


Library and dataflash example builds. Dataflash example confirmed to be working.


good to instantiate the RuntimeException's cause here so we don't lose the actual error that drove the crash


Yeah...But in the old implementation...When a temporary error occurs, the pod will be set to [`Pending`](https://github.com/yujuhong/kubernetes/commit/07cf5cff482b0fd50cc7d9ff90584a975a7359a2#diff-bf28da68f62a8df6e99e447c4351122dL3125)...And in next `syncPod()` it will be used to calculate [`PodStartLatency`](https://github.com/yujuhong/kubernetes/commit/07cf5cff482b0fd50cc7d9ff90584a975a7359a2#diff-bf28da68f62a8df6e99e447c4351122dL1591), which is of course wired...Hahaha


In the future, it's better to use a new folder parallel to 'src', say 'build', as the target directory.


You are correct. See http://stackoverflow.com/a/1769163

Let's change it


this probably should be volatile


You mean title case? Sorry, confused.


[Blocks] Let's have a named constant for the maximum possible sensible height. Even 1024 is vastly larger than we'd ever need (*) while still being a small amount or memory.  Then in this deserialization routine, let's fail early if length is greater than this height.

So right after this, we'd have something like:

```
if (deserialized.treeHeight > MAX_MERKLE_TREE_HEIGHT) {
  do_whatever_we_do_to_signal_invalid_input();
}
```

Also, if this height is capped at 1024, we could save some serialization bytes in height representation.


Thanks!


Not entirely. That's what I tried to say…

Also, you missed this: "doesn't" should be "don't". :)


Lots of fields required for user signup, might be helpful to relax the requirements. Also most address input is handled as address1, address2, city, state, zip. Good idea to follow convention. Consider enumerating states, so that you can't input a state that doesn't exist.


It had no real use, removed it


83811630_ReheatCoilSizingImprove (rongpengzhang) - x86_64-MacOS-10.9-clang: OK (2034 of 2042 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.61%25-yellow.svg)


Here I see that if the ``deserialized.treeHeight`` is a malicious/incompetent extremely large value, then ``vectorSlice`` will throw an exception, due to use of ``std::vector::at``, so we're safe *in this case*.  However, having an explicit cap on allowed tree heights would make safety clearer.


metre* ;)


Ça dépend. :sheep:
Ces thèmes marchent super mal de toute façon, l'export en PDF marche mal/pas...


don't need to call set(dv_idx) here.  intersection_update will take any iterable as an arg.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1223.6b6d7eab5e23011cb70089c79fe88ebc2ed54e6a](http://build.palaso.org/viewLog.html?buildId=67967&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 836, ignored: 7 Build time: 00:05:51


Ok, I'll expand on the whole blubber-pitch connection.


You'll  need to declare rc first, or you'll get an "undefined variable" error if the command ever unexpectedly succeeds. So e.g.:

```bash
rc=0
${ATOMIC} help centos:latest 1>/dev/null || rc=$?

if [ $rc != 1 ]; then
...
```


we can remove reference to ".net server"


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1504 of 1504 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Your current change is right, it was my mistake when i lost context on why path style was used in the first place.  Virtual style fails for non-US standard regions.


should these be `constexpr`?


From what i read okhttp does connection pool by default.


//cc @udalov


Chunyang Xu <notifications@github.com> writes:

>     What is the recommended way to get this back?
>
> I think you can remove these two new entries from that list, for
> example, (assq-delete-all 'find-file
> helm-completing-read-handlers-list).

Even better is to use the customize interface e.g M-x customize-variable
=> helm-completing-read-handlers-list => RET

Thanks.

--
Thierry


Hmm. Shift is the literal shift in frequency, whereas effect refers to the phenomenon. I could've worded it better throughout.

Correlated in that the variations match movement, but were greater than what could be accounted by Doppler alone?


Overall, the changes look very good. One recurring comment that I didn't highlight in all cases, is to use the OrleansTestingBase class even for the classes that don't completely require it. Even if it's just to inherit  its helper methods.
Also, for the classes that use a custom fixture, or no fixture at all but new up the cluster in every test, I would keep using a field called `HostedCluster` (instead of `_silo` or `_fixture`). The reason is that I later intend to make more and more tests reuse cluster instances instead of restarting every time. My previous PR was a first pass on that, but I think we could get to even fewer cluster restarts in the future. Having a standard way to name the HostedCluster member and inheriting from OrleansTestingBase, will make it very easy to just update the base class or which fixture to use, and run the tests to see if they can share the cluster with others.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11581](https://teamcity.mesosphere.io/viewLog.html?buildId=105391&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:03:49


You can position the window in the center of the screen by using the Java Toolkit to get the default display settings for the user.


Of course this one still requires minqlx development branch for now!

See https://github.com/MinoMino/minqlx/commit/e1a0c90db661bec44855a3cdb8a5e79d153b6eef


Oh okay cool… I misunderstood. Thanks!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11580](https://teamcity.mesosphere.io/viewLog.html?buildId=105378&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:08:44


Thank you!

The validation code was in there (in quiz.js):

  // VALIDATE INPUT
  // If either of the input fields does not have a value in it when
  // the user presses the enter key, or presses the button, then display
  // an alert stating that both fields must have a value.
  if (!/^\d+$/.test(tree_height)) {
    alert("Tree height must contain only digits 0-9");
    return false;
  }


You should only import what you need


Здесь как-то очень сложно всё сделано, можно было проще. В этой задаче не стояло условие экономить на переменных ))


NodeMCU v1.4 1.5 changed the server mod to only allow one :send per http request.  Removing all :send command except one.  This also makes the status the default landing page.


What kind of olive oil?


Oh, wait, I see what you meant.  You're right, as it is the .js accepts a blank as the tree_character, and that's my bad.  But the regex in my validation section will trigger the alert if tree_height is blank.


Use /* */ for multi-line comments


why jpg?


unused


the beginning of the ultimate buck owens application


Yup, indeed some stuff in pedigree node menu is in px, some is in em. All should be in em as I guess.


hi, this seems awesome exactly what i need. why dont you pr it?


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1503 of 1503 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.68%25-green.svg)


develop (rongpengzhang) - x86_64-MacOS-10.9-clang: OK (1502 of 1502 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@bberenz if raw data is provided without the `raw` keyword (i.e. EPL) will this try to resolve it?  At a glance, the js logic seems like it will.


What grammar should be according to?


- when passing pointer, you get no type conversion. Passing int makes it s little bit easier to get right.
 - on little endian, when you pass adress of larger type, you get the correct part (lsb). But should the function set the valu, only part will be modified, possibly with incorrect results
 - on big endian, you pass incorrect value when passing address of larger, you pass incorrect value.

When using pointer, you have to have value in memory. no lvalues -  no inline calculation, constant etc ..

In this case you gain nothing from using pointer, things just get more complicated.

BTW: I would use int for parameter - 500 hz is reasonable value (and using int usually generated better code on gcc ARM)


Isn't the user expected to provide the old password or answer to their secret question when resetting the password?


Merged to master and cleaned up branches.
All that is left to do is trying to compile compiler-rt for arm-none-eabi to remove the libgcc dependency. After that, binutils + Clang will be fully supported and we can document how to build with Clang and how to build the compiler-rt (if one wants, they can always decide to use libgcc) in the readme.


I think it is set to `Pending` from long long ago, at least before this one [https://github.com/andronat/kubernetes/commit/4910be6dcb201d7aa5c93f364fffaf2ac3896a95]. It may be better to keep the `Pending` state and add a TODO here, then double check with Dawn later to figure out what this means and whether we can remove it.


The input `t` is not needed yet, is it for future use?


I think this would be slightly more readable if you put these lines after the next target (ie the standalone JSX build target.  Similar comment for the other added stanzas.


The logger is already available and set-up for all plugins and in all states of the parser via the [global context](https://github.com/SpamExperts/SpamPAD/blob/60942f89f2d3d61bd97bcafcdcff4750e8278392/pad/plugins/base.py#L74). So there is no need to initialize it here, you can simply do this whenever you want to log something:

```python
self.ctxt.log.debug("Test")
```


Тут правильно, но конкретно в этом случае можно было сделать проще - в условии говорится, что тебе дано 3-х значное число, оно всегда будет таким. Можно было цикл не делать


Здесь можно было не экономить на переменных


I'd suggest using $(RSYNC) here and in other targets to be consistent with the rest of the Makefile as well as leaving usable datestamps on the built files.


Did you integrate "-j4" to dex2oat source too?


Yes ... just .. the initialization and filtering are quite independent parts of code. First sample is the same as all others, it should be handled consistently (should not be special-cased).


If you want to keep one line non-breakable, the solution is to:

- set `white-space: nowrap` on the line element (in this case `.cancer_field`)
- set `min-width`, but not `width` on the container element (in this case `.tabholder`)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11582](https://teamcity.mesosphere.io/viewLog.html?buildId=105392&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:10:21


Didn't know about them yet when I wrote this.  That being said, doesn't make much difference here, does it?  It's not like there's a lot of runtime initialization overhead for an integer.  If I happen to think about it later when at home, I'll change it.


@lgu1234 Sorry, I wasn't concerned about the `int` type, it was more about the use of optional.  In general, I think I'd like to move away from using optionals like that.  Instead just be intentional and have the argument always either true or false.  That's my opinion though, and the code is littered with optionals, so it's not like I'm going to hold your branch up for it.

I'll delete this branch and we'll converse more on #5375.


Je propose de ne pas mettre de valeur par défaut, et de simplement mettre dans settings_common la valeur  ``SITENAME = 'Roxpage'`` (ou ce que tu veux, idem pour ``DEMONYM``) pour expliciter le settings et limiter la "magie".


the block files are still compatible right?  that's the whole point of being able to fix it with a reindex?

also what happens if you just start a new node with 0.12, it will also be obfuscated?  it's not just on a reindex?


`if (rc.abi === ..`?


This field is supposed to be used by Docker Swarm for now, but can be used by any other tool that builds on top of Engine.


closes #15 - disable video preload


Merge bubble?


+1 Good catch on this. Obviously we can't use the installed version of `node` to verify the binary.


Please never use the old style except with a comma, and instead use `as` here.


The lastSampleTimer measures the time since the last sample was received. The purpose is to timeout 250ms after the *last* sample arrived (not after the last-20th sample arrived). That's why the timer is retriggered as each new sample (individual GstBuffer) comes.
If you don't retrigger the timer here, you're using it to manage the timeout of several samples at once, defeating the original purpose of lastSampleTimer. Doing this you could generate last sample false positives and break the appends more easily.


If you follow the call hierarchy, it's clear that emitCurrentSample() and flushCurrentSample() are only called from the main thread. However, adding an ASSERT(WTF::isMainThread()) would help people to understand the code better and to know from where the actions are being performed.


See the annotation I wrote somewhere else about the state machine being responsible of managing the timers, instead of scattering that logic around the code.

If you really really know what you're doing and want to use a single lastSample timeout to fit the processing of several GstBuffers, then the right thing to do is to change the meaning of the Sampling state so it now means "processing a group of 20 buffers" and trigger a Sampling --> Sampling state change only when you finish the group of 20 or on last sample timeout.


This is strange, because the DataStarve condition is meant to detect that no GstBuffers have been generated by an append. In that case, why would we have a pending MediaSample with buffers waiting to be processed (flushed)? That MediaSample (those buffers) should have been delivered to the upper layer long time ago, in the previous NotStarted --> Ongoing --> Sampling --> LastSample --> NotStarted cycle.

Is there a meaning for flushCurrentSample() that I'm missing?


There's code to cancel lastSampleTimer and also dataStarveTimer in the setAppendStage() method. That's partly the purpose of having a state machine to manage everything: to strictly enforce the preconditions of each state. If we're moving that enforcement here, we're stealing responsibility from the state machine and weakening the design, IMHO.


It's great for performance to have buffer lists instead of independent buffers now. However, I wonder what happens in these two cases:

- A caps change arrives in the middle of a buffer list filling, so we have some buffers with the old caps and some others with the new ones. Will it work? Maybe this situation never happens because a new init segment is needed for caps change. New segments need their own dedicated append to appear, so we won't ever have a caps change in the middle of a single append.

- We have the [10-15s] segment, we're currently playing at 3s and the player wants to perform a seek to 12s. The seek will involve a PlaybackPipeline::flushAndEnqueueNonDisplayingSamples() for [10-12s] to make the decoder happy and then some PlaybackPipeline::enqueueSample() for [12-15s]. The upper WebCore::SourceBuffer layer needs to query the buffered ranges to get the GstBuffers (encapsulated as MediaSamples) of [10-12s] on the one hand and of [12-15s] on the other hand. Does the GStreamerMediaSample subclass provide such granularity to "break" its GstBufferList into [10-12s] and [12-15s] pieces? If not, we have a problem.


C'est pas très "Django-spirit", mais ça semble être ze-way-to-go de DRF.


to stay consistent can you make sure that function names are underscored instead of camel case?


You don't have to specify the uuid twice


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11515](https://teamcity.mesosphere.io/viewLog.html?buildId=104763&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:03:38


Hmm, this makes it more difficult to test. Should we leave it to the consumer to test `response.notModified`?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1156](http://teamcity.monogame.net/viewLog.html?buildId=13549&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:34:54


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11514](https://teamcity.mesosphere.io/viewLog.html?buildId=104757&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:04:43


Hi,
At least on linux with gcc leading white spaces are included in the strings and the text is not aligned


the KeyError being caught here could be avoided altogether in one of two ways... 1. use the .get() built-in for dictionaries to return `None` if the key isn't present, or
2.  ...just don't call/run the function in the first place if you don't have any search domains being handed out?


thank you :)


This disables, not enables double buffering, sorry for any confusion about that. Without this revert eom is almost unusable for .svg images


It's not clear if there is a user-configured value for `IdeaProject.languageLevel` in this case.


nit: do we need `-version:6` now? I think the default is version 6.


Great response Christian! I noticed you have applied some good practices to improve code quality and standards.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1157](http://teamcity.monogame.net/viewLog.html?buildId=13563&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


I believe that this should also walk into `sym.annotations.map(_.original)`.


Thanks!


How do you feel about also using `#if` to interleave code from modules and test code?


型パラメーターを指定してるのに使ってない問題


this looks good


should 'y' and 'u' under RegExpSticky flag?


If you run pyfact without specifying any functions on a machine without search domains, it errors out.

Processing: searchdomains
Traceback (most recent call last):
  File "/Users/pgalla2/Downloads/pyfacts-master-2/pyfacts", line 810, in <module>
    main()
  File "/Users/pgalla2/Downloads/pyfacts-master-2/pyfacts", line 805, in main
    d[i] = getattr(facts, 'get_' + i)()
  File "/Users/pgalla2/Downloads/pyfacts-master-2/pyfacts", line 297, in get_searchdomains
    for i in dns_info['SearchDomains']:
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/PyObjC/objc/_convenience.py", line 162, in __getitem__objectForKey_
    return container_unwrap(res, KeyError, key)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/Extras/lib/python/PyObjC/objc/_convenience.py", line 659, in container_unwrap
    raise exc_type(*exc_args)
KeyError: 'SearchDomains'


lint fail :P


@1ambda 모나드 ㅋㅋㅋ


So it begins, on my own SlackBuild no less...


Remind me, but IsSticky() already takes care of checking flag config flag RegExpSticky?


Whoa how did you get a GPL? Don't you have to register for that or something?


@justin808 our own method, it's below


Include #18


Please rename your PS-01 folder to lowercase `odonnel-p/ps-01`


Missing a semicolon. Won't break anything, but it's good practice to have the semicolon :)


I love the refactor! :+1:


it is a GNU and no you do not have to register for it
ParkerMc

On 1/13/2016 8:11 PM, pianoman373 wrote:
>
> Whoa how did you get a GPL? Don't you have to register for that or
> something?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/TEAMModding/KalStuff/commit/56257d479f46fbed4ce613ea89b3b43349dccdcb#commitcomment-15439884>.
>


Okay, let's take a look at this `if`statement. Do you notice any patterns? If so, what is it? How can we refactor our code here?


RIP :)


Nevermind, I see that Shutdown() now calls Release() which calls delete.


@justin808 it's not stubbing, we're just using DI as `VersionChecker` doesn't care what the logger is as long as it has a `warn` method.


1. You can't use the API client until you have received the  ConnectionCallback, in the onConnected method at the bottom of MainActivity. Please Add the geofences in there.

2. All Database access should be handled in the datasource class, in fact, looking back at it, the DataSource shouldn't even expose the Database Helper class

3. Instead of adding a static method on the GeofenceTransitionsIntentService class, create a new class that houses static methods that take Context's as arguments and handle saving/retrieving preferences data. Then, When the add button is clicked in the main activity, call the method to save the preference, and in the oncreate method, call the retrieval method and reset the state of the plus button.

4. Also, it looks like in the sendNotification method attempts to grab sharedpreferences via file name, while when saving you aren't providing one


Was this always present or introduced during a refactor?


Really? I think it's covered by the preceding comment... only iframes need the unload handler, and since they appear under `preferredDocument`, anything that _is_ `preferredDocument` can be skipped.


Note that this commit reverts

https://github.com/mate-desktop/eom/commit/9c5a19aa360dd32b07e0c6e830c6495ce96da296

and modifies the comment in the code to reflect why this line had to be brought back


Shouldn't we than add SPL to module dependency to make sure it loaded first? On php 7 from master I faced with an issue that I had no SPL loaded (was trying to close to the same you do here).


Udacity front end HTML / CSS courses helped me compile this


Yea - let's think twice about what we make a setting and where a good default is better - too much settings can lead to bad UX and complicated code/testing


AFAIU this means that https://bugzilla.xamarin.com/show_bug.cgi?id=8344 is FIXED?


Thanks for this @jmchilton


This solves #136


still have a misspelling here (get_organizaions)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 11516](https://teamcity.mesosphere.io/viewLog.html?buildId=104798&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0, ignored: 213 Build time: 00:12:40
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


このコミットに関連するタスク
https://www.wrike.com/open.htm?id=73747707


Probably the PR never got merged. Happens to all of rourkes pulls ...


done in https://github.com/ipfs/npm-go-ipfs/commit/fd990a6848fad2863b34b635455323f289751feb


* I think we need to better convey at the beginning that by following the guidelines your PR can be merged _very quickly_, but if you don't then it can sit for a long time.

* The acceptance test running/writing section seems sparse for something that won't be obvious to newcomers. I'd include `go test` and command line examples, along with a real example of how to run a single AWS acceptance test (including the env vars to set).


Try connecting Trello to a Github repository


Why not?


选择器分钟设置为5，假如此时时间为10:57时就是出现奔溃


I don't think it hurts anything for this to be here but it shouldn't actually ever trigger an exception, right? because it's already checked in resolveNonConfigBubbles.


I'll fix it as soon as I get near my desktop again. (I left for the night)


this is unrelated to this diff so I don't think we should worry about this now, but why is this duplicated both here and below?


Of course not! It's open source. It just means anyone can edit the source code however they want, and even release it themselves, as long as they give us (TEAM) credit.


This isn't going to work. The answer is you shouldn't be using s3Dist. And should be using aws-cli to upload. Have a project where this is still being used? I will try to point you at a solution.


ivory I believe


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1157](http://teamcity.monogame.net/viewLog.html?buildId=13563&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:29:40


Yea um there is no issue section on fork repos..


각종 프로젝트


I can track it down but most likely it had been duplicated before.


Yeah, I just didn't think copying and pasting the document would make your software subject to those rules, without having to register a copyright or something.


Her'es the thing, the origional codebase operates via case statement off of segment+offset. ImpactStart would be the segment of the full list of attached sounds that begins where the impacts begin. so <ImpactStart+MaxSoundOffsets will end at ImpactSnow which corresponds to the earlier packed FootSnow, hence using MaxSoundOffsets as our limiter since the engine (again at time of writing) expects the same number of FootX as ImapctX. For a more practical example (minus a bugfix and this latest, see:

https://gist.github.com/Azaezel/9a21b74466dbad0b4cc1#file-gistfile1-txt-L205-L217
+
https://gist.github.com/Azaezel/9a21b74466dbad0b4cc1#file-gistfile2-txt-L1028
+https://gist.github.com/Azaezel/9a21b74466dbad0b4cc1#file-gistfile2-txt-L1062

Does that clarify matters? (as well as illustrate why come 4.0 I'd really, *really* recommend refactoring that to work off scripted numbers)


likely, but I would let it in until I refactor the error part a bit more -- I want to have the methods return their errors.


I think you may want to join the worker thread after resuming it. Imagine threads operate like this:
Caller thread:
   Unregister()
   DeleteSomeDebuggerStuff()

WorkerThread
   1) startup notification arrives signaling m_startupEvent
   2) callback is invoked
   3) user's callback uses 'DebuggerStuff'

If you run all the caller thread code in between 1 and 2 on the worker thread then step 3 on the worker thread will fail. Unregister needs to guarantee that no callback will happen after Unregister has returned. That requires that the worker thread enters a state where it can't call the callback any more, and that Unregister can prove the worker has entered that state. Joining the thread is probably a simple way to achieve that.


nice!


Minor point but it's actually not necessary to initialise the Vector3f because it does that in the constructor.


add deep-equal


See https://github.com/nodeca/argparse/commit/00ab75fdf0882ab450265701fa4afcb91f737ff5#commitcomment-9835846


typo: invoked


I wonder how many people have actually read that whole thing.


Again, minor point but we actually have "M_2PI_F" and "M_PI_2" definitions.


it's not that long. I've read probably half of it.


deep-equal


It's nothing compared to the thousands of pages of Microsoft's terms.


I’ve benchmarked this and it’s okay; no significant slowdown compared to manual approach.


It's the SCSI SBC-4 defined value(since they don't support negative number).
-1 make more sense. Will change it to that.


Yeah, that was suggested. I like the idea.


There are 3 patches that I need to merge into our Spigot, but this is not
one of them. Dan has it right.

On Wed, Jan 13, 2016 at 6:28 PM, Daniel Boston <notifications@github.com>
wrote:

> Probably the PR never got merged. Happens to all of rourkes pulls ...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Civcraft/JukeAlert/commit/31f12b36958d1cbe74273f3151a0234d7e6f7995#commitcomment-15440085>
> .
>


Microsoft does not want you to read it all so that they can spy on you.
ParkerMc

On 1/13/2016 8:43 PM, pianoman373 wrote:
>
> It's nothing compared to the thousands of pages of Microsoft's terms.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/TEAMModding/KalStuff/commit/56257d479f46fbed4ce613ea89b3b43349dccdcb#commitcomment-15440249>.
>