@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.autoform/6/violations
```
plone/autoform/base.py:0:1: I001 isort found changes, run it on the file
plone/autoform/base.py:23:1: C901 'AutoFields.updateFieldsFromSchemata' is too complex (11)
plone/autoform/directives.py:123:30: Q000 Remove bad quotes.
plone/autoform/directives.py:123:31: S001 found %s formatter
plone/autoform/form.py:0:1: I001 isort found changes, run it on the file
plone/autoform/form.py:22:13: Q000 Remove bad quotes.
plone/autoform/interfaces.py:0:1: I001 isort found changes, run it on the file
plone/autoform/supermodel.py:0:1: I001 isort found changes, run it on the file
plone/autoform/supermodel.py:51:25: Q000 Remove bad quotes.
plone/autoform/supermodel.py:51:26: S001 found %s formatter
plone/autoform/supermodel.py:61:17: Q000 Remove bad quotes.
plone/autoform/supermodel.py:62:17: S001 found % formatter
plone/autoform/supermodel.py:69:1: C901 'FormSchema.read' is too complex (11)
plone/autoform/supermodel.py:104:34: Q000 Remove bad quotes.
plone/autoform/supermodel.py:104:67: S001 found %s formatter
plone/autoform/supermodel.py:109:1: C901 'FormSchema.write' is too complex (14)
plone/autoform/supermodel.py:143:25: Q000 Remove bad quotes.
plone/autoform/supermodel.py:143:26: S001 found %s formatter
plone/autoform/supermodel.py:146:55: Q000 Remove bad quotes.
plone/autoform/supermodel.py:151:25: Q000 Remove bad quotes.
plone/autoform/supermodel.py:151:26: S001 found %s formatter
plone/autoform/supermodel.py:156:17: Q000 Remove bad quotes.
plone/autoform/testing.py:0:1: I001 isort found changes, run it on the file
plone/autoform/testing.py:2:1: F401 'Layer' imported but unused
plone/autoform/testing.py:12:10: Q000 Remove bad quotes.
plone/autoform/testing.py:16:10: Q000 Remove bad quotes.
plone/autoform/utils.py:0:1: I001 isort found changes, run it on the file
plone/autoform/utils.py:118:1: C901 'processFields' is too complex (19)
plone/autoform/view.py:0:1: I001 isort found changes, run it on the file
plone/autoform/widgets.py:0:1: I001 isort found changes, run it on the file
plone/autoform/widgets.py:69:17: S001 found %s formatter
plone/autoform/widgets.py:81:22: Q000 Remove bad quotes.
plone/autoform/widgets.py:81:23: S001 found %s formatter
plone/autoform/widgets.py:95:30: Q000 Remove bad quotes.
plone/autoform/widgets.py:95:31: S001 found %s formatter
plone/autoform/tests/test_directives.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_doctests.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_supermodel_handler.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_supermodel_handler.py:39:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:40:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:42:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:42:52: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:43:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:43:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:44:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:44:54: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:46:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:47:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:82:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:83:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:85:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:85:53: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:86:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:86:56: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:87:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:87:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:90:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:90:53: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:91:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:91:56: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:136:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:137:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:140:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:141:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:146:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:147:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:148:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:151:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:152:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:153:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:244:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:245:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:245:52: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:246:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:246:54: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:248:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:249:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:270:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:271:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:272:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:272:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:273:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:284:51: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:285:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:286:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:287:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:315:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:316:32: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:319:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:320:32: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:324:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:325:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:326:32: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:329:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:330:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:331:32: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:416:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:416:63: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:417:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:417:64: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:459:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:460:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:463:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:464:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:480:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:484:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:498:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:502:31: Q000 Remove bad quotes.
plone/autoform/tests/test_utils.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_utils.py:21:23: Q000 Remove bad quotes.
plone/autoform/tests/test_widgets.py:0:1: I001 isort found changes, run it on the file
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-borg.localrole/6/violations
```
borg/__init__.py:0:1: C101 Coding magic comment not found
borg/localrole/__init__.py:0:1: C101 Coding magic comment not found
borg/localrole/__init__.py:0:1: I001 isort found changes, run it on the file
borg/localrole/__init__.py:14:80: E501 line too long (90 > 79 characters)
borg/localrole/__init__.py:15:43: E127 continuation line over-indented for visual indent
borg/localrole/__init__.py:15:80: E501 line too long (89 > 79 characters)
borg/localrole/config.py:0:1: C101 Coding magic comment not found
borg/localrole/default_adapter.py:0:1: C101 Coding magic comment not found
borg/localrole/default_adapter.py:0:1: I001 isort found changes, run it on the file
borg/localrole/factory_adapter.py:0:1: C101 Coding magic comment not found
borg/localrole/factory_adapter.py:0:1: I001 isort found changes, run it on the file
borg/localrole/factory_adapter.py:16:63: D001 found directlyProvides replace it with zope.interface.provider
borg/localrole/factory_adapter.py:66:13: D001 found directlyProvides replace it with zope.interface.provider
borg/localrole/factory_adapter.py:67:80: E501 line too long (80 > 79 characters)
borg/localrole/factory_adapter.py:79:13: D001 found directlyProvides replace it with zope.interface.provider
borg/localrole/factory_adapter.py:93:0: P102 docstring does contain unindexed parameters
borg/localrole/interfaces.py:0:1: C101 Coding magic comment not found
borg/localrole/interfaces.py:0:1: I001 isort found changes, run it on the file
borg/localrole/interfaces.py:5:3: Q000 Remove bad quotes.
borg/localrole/interfaces.py:9:3: Q000 Remove bad quotes.
borg/localrole/setuphandlers.py:0:1: C101 Coding magic comment not found
borg/localrole/tests.py:0:1: C101 Coding magic comment not found
borg/localrole/tests.py:0:1: I001 isort found changes, run it on the file
borg/localrole/tests.py:55:5: E122 continuation line missing indentation or outdented
borg/localrole/tests.py:57:13: E128 continuation line under-indented for visual indent
borg/localrole/tests.py:58:13: E128 continuation line under-indented for visual indent
borg/localrole/tests.py:59:13: E128 continuation line under-indented for visual indent
borg/localrole/utils.py:0:1: C101 Coding magic comment not found
borg/localrole/utils.py:0:1: I001 isort found changes, run it on the file
borg/localrole/utils.py:25:9: T001 print statement found.
borg/localrole/utils.py:25:23: Q000 Remove bad quotes.
borg/localrole/utils.py:25:24: S001 found %s formatter
borg/localrole/utils.py:35:27: P002 found "hasattr", consider replacing it
borg/localrole/workspace.py:0:1: C101 Coding magic comment not found
borg/localrole/workspace.py:0:1: I001 isort found changes, run it on the file
borg/localrole/workspace.py:9:49: D001 found classImplements replace it with zope.interface.implementer
borg/localrole/workspace.py:20:9: Q000 Remove bad quotes.
borg/localrole/workspace.py:21:18: Q000 Remove bad quotes.
borg/localrole/workspace.py:24:80: E501 line too long (82 > 79 characters)
borg/localrole/workspace.py:25:80: E501 line too long (81 > 79 characters)
borg/localrole/workspace.py:31:80: E501 line too long (90 > 79 characters)
borg/localrole/workspace.py:32:17: S001 found % formatter
borg/localrole/workspace.py:75:42: D001 found classImplements replace it with zope.interface.implementer
borg/localrole/workspace.py:77:15: D001 found classImplements replace it with zope.interface.implementer
borg/localrole/workspace.py:111:80: E501 line too long (99 > 79 characters)
borg/localrole/workspace.py:119:0: P102 docstring does contain unindexed parameters
borg/localrole/workspace.py:247:40: D001 found directlyProvides replace it with zope.interface.provider
borg/localrole/workspace.py:248:13: D001 found directlyProvides replace it with zope.interface.provider
borg/localrole/workspace.py:249:13: D001 found directlyProvides replace it with zope.interface.provider
borg/localrole/workspace.py:355:17: Q000 Remove bad quotes.
borg/localrole/workspace.py:358:34: Q000 Remove bad quotes.
borg/localrole/workspace.py:367:16: P002 found "hasattr", consider replacing it
borg/localrole/workspace.py:403:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
borg/localrole/workspace.py:403:29: Q000 Remove bad quotes.
borg/localrole/workspace.py:424:80: E501 line too long (80 > 79 characters)
borg/localrole/workspace.py:428:80: E501 line too long (84 > 79 characters)
borg/localrole/workspace.py:431:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
borg/localrole/workspace.py:431:29: Q000 Remove bad quotes.
borg/localrole/workspace.py:433:1: C901 'WorkspaceLocalRoleManager.checkLocalRolesAllowed' is too complex (14)
borg/localrole/workspace.py:476:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
borg/localrole/workspace.py:476:29: Q000 Remove bad quotes.
borg/localrole/workspace.py:493:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
borg/localrole/workspace.py:493:29: Q000 Remove bad quotes.
borg/localrole/workspace.py:506:1: D001 found classImplements replace it with zope.interface.implementer
borg/localrole/bbb/interfaces.py:0:1: C101 Coding magic comment not found
borg/localrole/bbb/interfaces.py:0:1: I001 isort found changes, run it on the file
borg/localrole/bbb/interfaces.py:6:1: E302 expected 2 blank lines, found 1
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.contentlisting/8/violations
```
plone/app/contentlisting/catalog.py:42:12: P002 found "hasattr", consider replacing it
plone/app/contentlisting/catalog.py:44:14: P002 found "hasattr", consider replacing it
plone/app/contentlisting/catalog.py:84:12: P002 found "hasattr", consider replacing it
plone/app/contentlisting/catalog.py:185:12: P002 found "hasattr", consider replacing it
plone/app/contentlisting/contentlisting.py:130:12: P002 found "hasattr", consider replacing it
plone/app/contentlisting/realobject.py:36:12: P002 found "hasattr", consider replacing it
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Good


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.discussion/34/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/discussion/__init__.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/catalog.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/catalog.py:89:17: Q000 Remove bad quotes.
plone/app/discussion/comment.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/comment.py:77:28: Q000 Remove bad quotes.
plone/app/discussion/comment.py:172:40: Q000 Remove bad quotes.
plone/app/discussion/comment.py:174:30: S001 found %s formatter
plone/app/discussion/comment.py:178:48: S001 found %s formatter
plone/app/discussion/comment.py:213:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
plone/app/discussion/comment.py:250:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:259:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:268:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:277:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:303:21: Q000 Remove bad quotes.
plone/app/discussion/contentrules.py:0:1: C101 Coding magic comment not found
plone/app/discussion/contentrules.py:18:5: E731 do not assign a lambda expression, use a def
plone/app/discussion/contentrules.py:26:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:48:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:59:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:70:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:81:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:92:1: E302 expected 2 blank lines, found 1
plone/app/discussion/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/conversation.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/conversation.py:67:27: Q000 Remove bad quotes.
plone/app/discussion/conversation.py:205:16: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:214:12: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:220:12: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:324:8: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:453:29: Q000 Remove bad quotes.
plone/app/discussion/events.py:0:1: C101 Coding magic comment not found
plone/app/discussion/events.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/events.py:11:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:33:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:38:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:43:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:48:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/interfaces.py:135:17: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:161:65: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:247:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:262:21: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:280:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:284:23: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:291:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:308:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:390:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:394:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:398:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:402:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:406:1: E302 expected 2 blank lines, found 1
plone/app/discussion/patches.py:0:1: C101 Coding magic comment not found
plone/app/discussion/patches.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/testing.py:0:1: C101 Coding magic comment not found
plone/app/discussion/testing.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/testing.py:13:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:14:1: B901 blind except: statement
plone/app/discussion/testing.py:15:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:66:14: Q000 Remove bad quotes.
plone/app/discussion/testing.py:78:10: Q000 Remove bad quotes.
plone/app/discussion/testing.py:81:10: Q000 Remove bad quotes.
plone/app/discussion/tool.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tool.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/upgrades.py:0:1: C101 Coding magic comment not found
plone/app/discussion/upgrades.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/vocabularies.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_catalog.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_catalog.py:89:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:107:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:114:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:135:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:142:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:158:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:173:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:191:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:199:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:212:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:224:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:235:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:243:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:250:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:280:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:299:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:307:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:347:40: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:380:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:386:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:429:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:436:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:450:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:450:49: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:533:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:578:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_comment.py:55:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:56:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:57:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:106:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:108:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:114:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:130:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:131:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:135:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:136:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:158:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:166:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:179:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:182:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:187:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:231:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:262:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:267:23: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:304:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:329:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:371:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:407:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:442:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:450:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:459:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:468:38: S001 found %s formatter
plone/app/discussion/tests/test_comments_viewlet.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_comments_viewlet.py:43:1: F811 redefinition of unused 'IConversation' from line 38
plone/app/discussion/tests/test_comments_viewlet.py:112:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:126:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:134:43: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:135:60: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:137:66: W291 trailing whitespace
plone/app/discussion/tests/test_comments_viewlet.py:180:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:194:59: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:196:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_comments_viewlet.py:236:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:281:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:316:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:405:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:406:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:411:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:416:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:417:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:418:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:429:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:430:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:431:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:487:63: S001 found %s formatter
plone/app/discussion/tests/test_contentrules.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_contentrules.py:6:1: F401 'notify' imported but unused
plone/app/discussion/tests/test_contentrules.py:22:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_contentrules.py:51:24: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:52:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:53:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:54:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:59:5: E303 too many blank lines (2)
plone/app/discussion/tests/test_contentrules.py:117:38: S001 found %s formatter
plone/app/discussion/tests/test_contentrules.py:121:38: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:122:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:123:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:126:9: F841 local variable 'new_re_id' is assigned to but never used
plone/app/discussion/tests/test_contentrules.py:135:35: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_contentrules.py:145:44: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_controlpanel.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_controlpanel.py:36:18: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:43:56: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:92:5: F811 redefinition of unused 'test_edit_comment_enabled' from line 84
plone/app/discussion/tests/test_controlpanel.py:145:5: E265 block comment should start with '# '
plone/app/discussion/tests/test_conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_conversation.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_conversation.py:31:1: B901 blind except: statement
plone/app/discussion/tests/test_conversation.py:91:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:93:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:94:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:95:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:96:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:96:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:97:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:518:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_conversation.py:560:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:565:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:570:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:575:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:969:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:973:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:978:38: S001 found %s formatter
plone/app/discussion/tests/test_events.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_events.py:15:1: E302 expected 2 blank lines, found 0
plone/app/discussion/tests/test_events.py:26:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:29:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:32:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:35:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:40:1: E302 expected 2 blank lines, found 0
plone/app/discussion/tests/test_events.py:81:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:99:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:138:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:151:38: S001 found %s formatter
plone/app/discussion/tests/test_events.py:157:9: F841 local variable 'new_re_id' is assigned to but never used
plone/app/discussion/tests/test_events.py:171:38: S001 found %s formatter
plone/app/discussion/tests/test_functional.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_indexers.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_indexers.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_indexers.py:54:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:55:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:62:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:63:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:70:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:71:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:110:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_indexers.py:112:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_indexers.py:139:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:140:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:170:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:170:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_migration.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_migration.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_migration.py:55:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_migration.py:68:14: Q000 Remove bad quotes.
plone/app/discussion/tests/test_migration.py:214:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_moderation_view.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_moderation_view.py:111:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:119:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:127:38: S001 found %s formatter
plone/app/discussion/tests/test_notifications.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_notifications.py:37:42: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:64:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:86:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:87:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:102:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:130:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:146:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:151:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:176:42: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:227:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:228:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:234:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:238:13: S001 found % formatter
plone/app/discussion/tests/test_tool.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_tool.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_tool.py:32:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_tool.py:42:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_tool.py:43:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_tool.py:43:15: S001 found %s formatter
plone/app/discussion/tests/test_workflow.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_workflow.py:58:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_workflow.py:94:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_workflow.py:133:38: S001 found %s formatter
plone/app/discussion/tests/test_workflow.py:153:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_workflow.py:154:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_workflow.py:203:38: S001 found %s formatter
plone/app/discussion/browser/captcha.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/captcha.py:64:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/comment.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/comment.py:45:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:45:20: S001 found %s formatter
plone/app/discussion/browser/comment.py:47:41: S001 found %s formatter
plone/app/discussion/browser/comment.py:53:10: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:92:52: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:95:40: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:95:58: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:108:1: E265 block comment should start with '# '
plone/app/discussion/browser/comments.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/comments.py:94:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:100:35: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:128:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:129:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:130:42: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:132:1: C901 'CommentForm.handleComment' is too complex (15)
plone/app/discussion/browser/comments.py:141:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:142:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:157:16: E713 test for membership should be 'not in'
plone/app/discussion/browser/comments.py:210:53: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:251:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:252:22: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:275:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:276:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:325:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:328:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:336:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:344:37: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:415:20: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:415:21: S001 found %s formatter
plone/app/discussion/browser/comments.py:462:17: S001 found %s formatter
plone/app/discussion/browser/controlpanel.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/controlpanel.py:34:10: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:90:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:91:48: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:96:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:97:40: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:97:41: S001 found %s formatter
plone/app/discussion/browser/controlpanel.py:113:46: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:119:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:126:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:128:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:131:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:135:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:141:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:168:46: Q000 Remove bad quotes.
plone/app/discussion/browser/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/conversation.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/conversation.py:20:1: B901 blind except: statement
plone/app/discussion/browser/conversation.py:32:1: C901 'ConversationView._enabled_for_archetypes' is too complex (14)
plone/app/discussion/browser/conversation.py:138:12: P002 found "hasattr", consider replacing it
plone/app/discussion/browser/conversation.py:138:29: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/migration.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/migration.py:37:1: C901 'View.__call__' is too complex (32)
plone/app/discussion/browser/migration.py:44:19: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:48:16: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:80:26: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:82:31: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:83:22: S001 found %s formatter
plone/app/discussion/browser/migration.py:181:25: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:181:26: S001 found %s formatter
plone/app/discussion/browser/migration.py:191:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:191:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:205:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:205:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:206:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:206:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:207:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:207:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:209:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:210:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:228:21: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:229:31: S001 found %s formatter
plone/app/discussion/browser/migration.py:237:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:238:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:239:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:239:28: S001 found %s formatter
plone/app/discussion/browser/migration.py:246:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:248:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:249:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:250:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:252:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:253:13: S001 found % formatter
plone/app/discussion/browser/migration.py:257:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:257:18: S001 found %s formatter
plone/app/discussion/browser/migration.py:261:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:262:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:266:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:267:17: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/moderation.py:100:15: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:101:18: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:139:15: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:140:18: Q000 Remove bad quotes.
plone/app/discussion/browser/traversal.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/traversal.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/traversal.py:32:20: Q000 Remove bad quotes.
plone/app/discussion/browser/validator.py:0:1: I001 isort found changes, run it on the file
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


```python
line = context['position'][1]
col = context['complete_position']
```


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.browserlayer/2/violations
```
plone/browserlayer/__init__.py:0:1: C101 Coding magic comment not found
plone/browserlayer/exportimport.py:96:21: Q000 Remove bad quotes.
plone/browserlayer/exportimport.py:102:21: S001 found %s formatter
plone/browserlayer/exportimport.py:115:21: Q000 Remove bad quotes.
plone/browserlayer/exportimport.py:121:21: S001 found %s formatter
plone/browserlayer/layer.py:5:28: D001 found directlyProvides replace it with zope.interface.provider
plone/browserlayer/layer.py:12:31: Q000 Remove bad quotes.
plone/browserlayer/layer.py:29:5: D001 found directlyProvides replace it with zope.interface.provider
plone/browserlayer/testing.py:20:10: Q000 Remove bad quotes.
plone/browserlayer/utils.py:37:24: Q000 Remove bad quotes.
plone/browserlayer/utils.py:37:52: S001 found %s formatter
plone/browserlayer/tests/test_doctest.py:0:1: I001 isort found changes, run it on the file
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.indexer/7/violations
```
plone/indexer/interfaces.py:0:1: I001 isort found changes, run it on the file
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17783](https://teamcity.mesosphere.io/viewLog.html?buildId=149235&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 244 Build time: 00:03:58


I wonder if we can export PropTypes in cases like this.  This way we will not have duplicate declarations of a proptype.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.intelligenttext/3/violations
```
plone/intelligenttext/tests.py:0:1: I001 isort found changes, run it on the file
plone/intelligenttext/tests.py:11:5: T001 print function found.
plone/intelligenttext/transforms.py:0:1: I001 isort found changes, run it on the file
plone/intelligenttext/transforms.py:22:9: P103 other string does contain unindexed parameters
plone/intelligenttext/transforms.py:22:80: E501 line too long (278 > 79 characters)
plone/intelligenttext/transforms.py:63:45: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:68:20: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:69:32: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:73:26: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:79:37: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:79:54: Q000 Remove bad quotes.
plone/intelligenttext/transforms.py:97:26: S001 found %s formatter
plone/intelligenttext/transforms.py:107:45: S001 found %s formatter
plone/intelligenttext/transforms.py:150:33: S001 found % formatter
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


```python
pos = {"line": line - 1, "ch": col+1}
```


@thet Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.namedfile/7/violations
```
plone/namedfile/copy.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/file.py:283:1: C901 'getImageInfo' is too complex (15)
plone/namedfile/marshaler.py:8:1: C901 'If 8' is too complex (13)
plone/namedfile/scaling.py:248:1: C901 'ImageScaling.create' is too complex (13)
plone/namedfile/scaling.py:294:41: S001 found %r formatter
plone/namedfile/tests/base.py:54:16: P301 format call provides unused index (1)
plone/namedfile/tests/test_scaling.py:91:32: S001 found %s formatter
plone/namedfile/tests/test_scaling.py:92:70: S001 found % formatter
plone/namedfile/tests/test_scaling.py:109:14: D001 found failIf( replace it with assertFalse
plone/namedfile/tests/test_scaling.py:158:32: S001 found %s formatter
plone/namedfile/tests/test_scaling.py:159:70: S001 found % formatter
plone/namedfile/tests/test_scaling.py:166:32: S001 found %s formatter
plone/namedfile/tests/test_scaling.py:167:72: S001 found % formatter
plone/namedfile/tests/test_scaling.py:174:32: S001 found %s formatter
plone/namedfile/tests/test_scaling.py:175:72: S001 found % formatter
plone/namedfile/tests/test_scaling.py:215:32: S001 found %s formatter
plone/namedfile/tests/test_scaling.py:216:70: S001 found % formatter
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@jensens Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.recipe.codeanalysis/16/violations
```
plone/recipe/codeanalysis/__init__.py:176:13: T001 print function found.
plone/recipe/codeanalysis/__init__.py:191:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:200:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:248:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:59:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:66:13: T001 print function found.
plone/recipe/codeanalysis/tests/test_csslint.py:24:0: P103 other string does contain unindexed parameters
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.subrequest/4/violations
```
plone/subrequest/__init__.py:0:1: I001 isort found changes, run it on the file
plone/subrequest/__init__.py:31:5: E301 expected 1 blank line, found 0
plone/subrequest/__init__.py:66:20: Q000 Remove bad quotes.
plone/subrequest/__init__.py:69:1: C901 'subrequest' is too complex (21)
plone/subrequest/__init__.py:70:29: Q000 Remove bad quotes.
plone/subrequest/__init__.py:76:9: Q000 Remove bad quotes.
plone/subrequest/__init__.py:92:25: S001 found %s formatter
plone/subrequest/__init__.py:94:22: S001 found %s formatter
plone/subrequest/__init__.py:150:9: B901 blind except: statement
plone/subrequest/__init__.py:151:30: Q000 Remove bad quotes.
plone/subrequest/__init__.py:151:60: S001 found %s formatter
plone/subrequest/interfaces.py:0:1: C101 Coding magic comment not found
plone/subrequest/interfaces.py:0:1: I001 isort found changes, run it on the file
plone/subrequest/interfaces.py:3:1: E302 expected 2 blank lines, found 1
plone/subrequest/subresponse.py:0:1: I001 isort found changes, run it on the file
plone/subrequest/subresponse.py:20:12: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:21:16: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:22:12: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:48:16: P002 found "hasattr", consider replacing it
plone/subrequest/testing.py:0:1: I001 isort found changes, run it on the file
plone/subrequest/testing.py:51:23: S001 found %s formatter
plone/subrequest/testing.py:87:25: Q000 Remove bad quotes.
plone/subrequest/testing.py:88:17: Q000 Remove bad quotes.
plone/subrequest/testing.py:163:10: Q000 Remove bad quotes.
plone/subrequest/testing.py:167:10: Q000 Remove bad quotes.
plone/subrequest/testing.py:169:1: W391 blank line at end of file
plone/subrequest/tests.py:0:1: I001 isort found changes, run it on the file
plone/subrequest/tests.py:22:5: Q000 Remove bad quotes.
plone/subrequest/tests.py:23:5: Q000 Remove bad quotes.
plone/subrequest/tests.py:42:61: S001 found %s formatter
plone/subrequest/tests.py:50:61: S001 found %s formatter
plone/subrequest/tests.py:58:61: S001 found %s formatter
plone/subrequest/tests.py:147:13: Q000 Remove bad quotes.
plone/subrequest/tests.py:147:51: S001 found %s formatter
plone/subrequest/tests.py:160:13: Q000 Remove bad quotes.
plone/subrequest/tests.py:161:13: Q000 Remove bad quotes.
plone/subrequest/tests.py:172:13: Q000 Remove bad quotes.
plone/subrequest/tests.py:173:13: Q000 Remove bad quotes.
plone/subrequest/tests.py:184:13: Q000 Remove bad quotes.
plone/subrequest/tests.py:185:13: Q000 Remove bad quotes.
plone/subrequest/tests.py:231:46: Q000 Remove bad quotes.
plone/subrequest/tests.py:241:46: Q000 Remove bad quotes.
plone/subrequest/tests.py:251:46: Q000 Remove bad quotes.
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.resourceeditor/4/violations
```
plone/resourceeditor/browser.py:84:16: P002 found "hasattr", consider replacing it
plone/resourceeditor/browser.py:372:1: C901 'FileManagerActions.__call__' is too complex (13)
plone/resourceeditor/browser.py:462:1: C901 'FileManager.__call__' is too complex (13)
plone/resourceeditor/tests.py:43:52: P103 other string does contain unindexed parameters
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Add a short comment explaining that this implementation rounds the decimal to the nearest integer.


Changed sudo disclaimer on cassandra doc as another sudo command with be introduced for rethinkDB


Where did you get this from?


@jensens Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.tiles/10/violations
```
plone/tiles/__init__.py:0:1: I001 isort found changes, run it on the file
plone/tiles/data.py:148:1: C901 'map_to_pairs' is too complex (12)
plone/tiles/data.py:196:1: C901 'encode' is too complex (15)
plone/tiles/data.py:277:1: C901 'decode' is too complex (14)
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


causes #3212


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.namedfile/8/violations
```
plone/namedfile/copy.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/file.py:291:1: C901 'getImageInfo' is too complex (15)
plone/namedfile/marshaler.py:8:1: C901 'If 8' is too complex (13)
plone/namedfile/scaling.py:248:1: C901 'ImageScaling.create' is too complex (13)
plone/namedfile/scaling.py:294:41: S001 found %r formatter
plone/namedfile/tests/base.py:54:16: P301 format call provides unused index (1)
plone/namedfile/tests/test_scaling.py:91:32: S001 found %s formatter
plone/namedfile/tests/test_scaling.py:92:70: S001 found % formatter
plone/namedfile/tests/test_scaling.py:109:14: D001 found failIf( replace it with assertFalse
plone/namedfile/tests/test_scaling.py:158:32: S001 found %s formatter
plone/namedfile/tests/test_scaling.py:159:70: S001 found % formatter
plone/namedfile/tests/test_scaling.py:166:32: S001 found %s formatter
plone/namedfile/tests/test_scaling.py:167:72: S001 found % formatter
plone/namedfile/tests/test_scaling.py:174:32: S001 found %s formatter
plone/namedfile/tests/test_scaling.py:175:72: S001 found % formatter
plone/namedfile/tests/test_scaling.py:215:32: S001 found %s formatter
plone/namedfile/tests/test_scaling.py:216:70: S001 found % formatter
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


OK, thanks for the explanation. It definitely makes sense for debugging.

I am just being so strict because I don't like to change the UI in the release version for no reason.


Needs an @Ignore.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17778](https://teamcity.mesosphere.io/viewLog.html?buildId=149220&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 243 Build time: 00:04:53


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17782](https://teamcity.mesosphere.io/viewLog.html?buildId=149232&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 243 Build time: 00:04:58


Remove print statements


Unfortunately there isn't a lot of data about early life injuries causing CTE later


Fix a few items like the hostgroup was original calling name and changed it to title, once I did that the program started to work.   Lastly, added two items and deleted one item from the configure puppet section to allow puppet to run with the correct environment the first time and turn off the annoying allow_virtual error.


Reduces kernel size by freeing un-needed initrd


Perhaps emphasize "few batches as possible"?


They are not the same. The JWK mechanism encodes the key in a JSON Web Key.


Was finally able to verify this, and you're right.

Others mentioned there is quite a bit of confusion when using the Bootstrap library (that's not a problem here though!), as it is easy to get confused between the `.footer` class and the `footer` element.

If you wanted to try 'er out, it'd be something like:

HTML:
```html
<footer>
   <p>© <a href="./license.md">Copyright</a> by Mike Dolbow, <a href="http://twitter.com/mmdolbow">twitter.com/mmdolbow</a>.</p>
</footer>
```

and CSS:
```css
footer {
   right: 0;
   bottom: 0;
   left: 0;
   padding-top: 1rem;
   text-align: center;
}
```


This is a test comment


Add this unit by adding a Prefixes to LitersPerMinute instead. Then you can add milli and other prefixes too if you like. See Length.json and how Millimeters and Centimeters are implemented, as an example.

I also noticed there is a typo here, singular should be LiterPerMinute, but I guess it's too late to fix that now without breaking backwards compatibility.


Unfortunately, everything about this particular commit pretty much has undone all of the merging and other work that has been done.. Was that intentional?


Leave a comment when it is fixed, I am not notified of new commits.


I see. How about `$applyAsync()` then ? :smiley:


This local variable is unnecessary. Inline it.


should have trailing slash like original


I know but it'll be addons from before NetworkVar was added - DTVar wasn't an internal function then and was what people used. I've seen several reports on the DarkRP issue tracker/forums about it so unfortunately these addons using older techniques are still being used (or have lazy devs).


I have added your change but that didn't fix it same issue doesn't support rtl


Why don't you need to append here?  Are you confident this only ever gets called once per timestamp?


I want this thing to be kind of basic and simple just to start so people get the idea I want you to be able to turn the locations on and off I want you to be able to let people see your location for a certain amount of time and turn it off I want people to make pin drop . It's gotta be course I have to be map


*For backwards compatibility it can also be a `boolean`. In this case, the inverted value is set to `options.restructure` (e.g. `true` becomes `{restructure: false}`).


i'm not sure this is supposed to be abstract. we can't instantiate it if it is @czue @snopoke might be missing something though


Can't we keep the 1.7 entitymaps?


nuked; added a precise `Find` function to the interval tree


Super picky, but this reads like two sentences.  Should there be periods at the end and a capital "K" in "keep"?


Ah, I think I see below.  This really is called sequentially.


I guess so :smile:


It hurts that we can't upload everything atomically; or have an atomic "reset HEAD" upstream :(


No, I made a mistake, but I already re-upload the correct files. Hope it's ok now


222ddb3a361b0510b084de3f8e1e4073fdfe8bcd
reverted and edited again
Thank you!


Extra vertical line.  Intentional?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17787](https://teamcity.mesosphere.io/viewLog.html?buildId=149245&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 244 Build time: 00:12:39


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17779](https://teamcity.mesosphere.io/viewLog.html?buildId=149229&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 243 Build time: 00:13:02


Great comment!  Thanks.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17784](https://teamcity.mesosphere.io/viewLog.html?buildId=149236&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:13:29


Sounds good to me.


caramba essa pagina virou uma salada! não tá dando pra entender quase nada


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17789](https://teamcity.mesosphere.io/viewLog.html?buildId=149254&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 243 Build time: 00:06:20


Different cases in the filenames?


Tested and improved performance for all copy page operations which are quite common


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17786](https://teamcity.mesosphere.io/viewLog.html?buildId=149244&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 243 Build time: 00:15:23


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.autoform/7/violations
```
plone/autoform/base.py:0:1: I001 isort found changes, run it on the file
plone/autoform/base.py:23:1: C901 'AutoFields.updateFieldsFromSchemata' is too complex (11)
plone/autoform/directives.py:123:30: Q000 Remove bad quotes.
plone/autoform/directives.py:123:31: S001 found %s formatter
plone/autoform/form.py:0:1: I001 isort found changes, run it on the file
plone/autoform/form.py:22:13: Q000 Remove bad quotes.
plone/autoform/interfaces.py:0:1: I001 isort found changes, run it on the file
plone/autoform/supermodel.py:0:1: I001 isort found changes, run it on the file
plone/autoform/supermodel.py:51:25: Q000 Remove bad quotes.
plone/autoform/supermodel.py:51:26: S001 found %s formatter
plone/autoform/supermodel.py:61:17: Q000 Remove bad quotes.
plone/autoform/supermodel.py:62:17: S001 found % formatter
plone/autoform/supermodel.py:69:1: C901 'FormSchema.read' is too complex (11)
plone/autoform/supermodel.py:104:34: Q000 Remove bad quotes.
plone/autoform/supermodel.py:104:67: S001 found %s formatter
plone/autoform/supermodel.py:109:1: C901 'FormSchema.write' is too complex (14)
plone/autoform/supermodel.py:143:25: Q000 Remove bad quotes.
plone/autoform/supermodel.py:143:26: S001 found %s formatter
plone/autoform/supermodel.py:146:55: Q000 Remove bad quotes.
plone/autoform/supermodel.py:151:25: Q000 Remove bad quotes.
plone/autoform/supermodel.py:151:26: S001 found %s formatter
plone/autoform/supermodel.py:156:17: Q000 Remove bad quotes.
plone/autoform/testing.py:0:1: I001 isort found changes, run it on the file
plone/autoform/testing.py:2:1: F401 'Layer' imported but unused
plone/autoform/testing.py:12:10: Q000 Remove bad quotes.
plone/autoform/testing.py:16:10: Q000 Remove bad quotes.
plone/autoform/utils.py:0:1: I001 isort found changes, run it on the file
plone/autoform/utils.py:118:1: C901 'processFields' is too complex (19)
plone/autoform/view.py:0:1: I001 isort found changes, run it on the file
plone/autoform/widgets.py:0:1: I001 isort found changes, run it on the file
plone/autoform/widgets.py:69:17: S001 found %s formatter
plone/autoform/widgets.py:81:22: Q000 Remove bad quotes.
plone/autoform/widgets.py:81:23: S001 found %s formatter
plone/autoform/widgets.py:95:30: Q000 Remove bad quotes.
plone/autoform/widgets.py:95:31: S001 found %s formatter
plone/autoform/tests/test_directives.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_doctests.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_supermodel_handler.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_supermodel_handler.py:39:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:40:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:42:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:42:52: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:43:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:43:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:44:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:44:54: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:46:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:47:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:82:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:83:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:85:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:85:53: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:86:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:86:56: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:87:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:87:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:90:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:90:53: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:91:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:91:56: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:136:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:137:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:140:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:141:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:146:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:147:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:148:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:151:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:152:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:153:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:244:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:245:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:245:52: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:246:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:246:54: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:248:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:249:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:270:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:271:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:272:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:272:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:273:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:284:51: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:285:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:286:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:287:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:315:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:316:32: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:319:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:320:32: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:324:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:325:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:326:32: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:329:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:330:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:331:32: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:416:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:416:63: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:417:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:417:64: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:459:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:460:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:463:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:464:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:480:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:484:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:498:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:502:31: Q000 Remove bad quotes.
plone/autoform/tests/test_utils.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_utils.py:21:23: Q000 Remove bad quotes.
plone/autoform/tests/test_widgets.py:0:1: I001 isort found changes, run it on the file
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Thanks, @colin-marshall. Good to know. I'm gonna leave it there for now tho, hoping I'll be able to stop adding them all individually. It would be nice to do it the right way, loading 'em via Foundation.


The following doc(s) have been deployed to the [1407nginx](http://1407nginx-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/sites/logs/debugging-sites-with-log-files](http://1407nginx-static-docs.pantheon.io/docs/articles/sites/logs/debugging-sites-with-log-files)


Oh, one more thing: the constructor should come after the fields.


Since tasks are short lived services we may need to consider having the default for isDeleteFilesOnExit to false.  Tasks like timestamp that have a short runtime  will leave a foot print for developers to review.


We shouldn't log to the console here, it should be up to the gulp plugin's consumer to handle errors.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17790](https://teamcity.mesosphere.io/viewLog.html?buildId=149255&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:55


I'm getting a segmentation violation signal error when I test with these Univariate Polynomials, specifically when they contain symbols on the second or later terms. The polynomial's first term is always printed correctly if it's a symbol or number.


You misspelled canols. It should be canola.


@mikepetersonccv Curious, why would we need to track the Nuget binaries in this repo?  e.g. `Rock.CodeGeneration/packages/Newtonsoft.Json.8.0.2/lib/net20/Newtonsoft.Json.dll`

Both VS and AppVeyor detect NuGet dependencies and should download packages as needed.


It sorta looks like you really expect the `afView` to be present.  If that's the case, should the `PaymentSandbox` not be an `optional`?


Yeah, that's what Bug 1250189 is for — soon!

/cc @rfk :+1:


This is a test comment


I don't think I understand the logic here.  Does something _require_ these signals?  It sounds like the if-statements were doing what they were supposed to.  Or is this only a problem for AMReadOnlyPVControl?


why?


I'm not sure we need to add keys for `:uri` and `:name` here, since `Krikri::Harvester::expected_opts` is intended for specific implementations, and thus for the hash associated with the key `:nypl`. cc @no-reply


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.resourceeditor/5/violations
```
plone/resourceeditor/browser.py:84:16: P002 found "hasattr", consider replacing it
plone/resourceeditor/browser.py:372:1: C901 'FileManagerActions.__call__' is too complex (13)
plone/resourceeditor/browser.py:462:1: C901 'FileManager.__call__' is too complex (13)
plone/resourceeditor/tests.py:43:52: P103 other string does contain unindexed parameters
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


new commit for that


Tested with:
> x = rbind (c(1,-1/4),c(-1/4,1))
> m = makeCacheMatrix(x)
> m$get()
      [,1]  [,2]
[1,]  1.00 -0.25
[2,] -0.25  1.00
> m$getinverse()
NULL
> cacheSolve(m)
          [,1]      [,2]
[1,] 1.0666667 0.2666667
[2,] 0.2666667 1.0666667
> m$getinverse()
          [,1]      [,2]
[1,] 1.0666667 0.2666667
[2,] 0.2666667 1.0666667
> cacheSolve(m)
getting cached values
          [,1]      [,2]
[1,] 1.0666667 0.2666667
[2,] 0.2666667 1.0666667
>


The problem is that if a control connects and it's min/max value is identical to the default value, the min/max changed signals won't be emitted.


Can be in shorthand `padding: 18px 10px` instead.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17791](https://teamcity.mesosphere.io/viewLog.html?buildId=149260&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:03:30


:disappointed:


jajaj un pequeño despiste


We stop observing in the next function call `_launchUI()` here https://github.com/phenotips/phenotips/blob/c364af395cde19737bceb347e0aeddd78e4ad819/components/patient-data-sharing/push-ui/src/main/resources/PhenoTips/PushPatient.xml#L393


sure or `defined?(ActiveModelSerializers::Support::UrlHelpers::Rails) == 'constant'` or `ActiveModel::Serializers::Support::UrlHelpers.included_modules.include?(Rails.application.routes.url_helpers)` or ` ActiveModelSerializers::Support::UrlHelper.const_get(:Rails) # doesn't blow up`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17792](https://teamcity.mesosphere.io/viewLog.html?buildId=149261&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 243 Build time: 00:05:13


Add space in between 180deg: `rotate( 180deg );`


GC support ?
As in overriding oxy?


oh.. that's because we should be using `prepend`, not `include`. oops


Ups. I restored that in https://github.com/s9y/Serendipity/commit/6fafd4964a830384f565fe81137d60ccb023022f


@Patater please keep box_name - just drop this patch. It's anyway the local box variable name and not the prefix.


Yep, it's left from debug.


Indent `top/right/bottom/left` after positioning property declaration for readability.


Why does it need server support? you can get the current team easily in cgame


Nit: Would be good to add a comment above this line, explaining this: e.g. "# If there is no tip for the user's choice, show any available question-level feedback"


Joshua - stop adding this subrepository please! It should be removed.


I think this is where I keep getting confused.  If the values are identical, why would it matter?  Calls to min/max should still be relevant for the editor to set its limits.  And for most controls, where the limitsMonitoring isn't enabled it wouldn't matter anyway.

Am I off base here?  My apologies that I seemingly can't see a clear image of this one.


Can we revert grab's retardness too pls


Background color should be `$gray-light`.


@sneakret Not sure if you are going to update your branch to support 1.9, but currently NBTEditor doesn't work with spigot 1.9. :)

```
[15:22:26] [Server thread/INFO]: [NBTEditor] Enabling NBTEditor v2.0-SNAPSHOT
[15:22:26] [Server thread/ERROR]: [NBTEditor] Error preparing reflection objects
java.lang.RuntimeException: Error while preparing item name methods.
	at com.goncalomb.bukkit.mylib.reflect.BukkitReflect.prepareReflection(BukkitReflect.java:88) ~[nbteditor-2.0-SNAPSHOT.jar:?]
	at com.goncalomb.bukkit.nbteditor.NBTEditor.onEnable(NBTEditor.java:71) [nbteditor-2.0-SNAPSHOT.jar:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:291) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:340) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at org.bukkit.craftbukkit.v1_9_R1.CraftServer.loadPlugin(CraftServer.java:361) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at org.bukkit.craftbukkit.v1_9_R1.CraftServer.enablePlugins(CraftServer.java:321) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at net.minecraft.server.v1_9_R1.MinecraftServer.t(MinecraftServer.java:411) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at net.minecraft.server.v1_9_R1.MinecraftServer.l(MinecraftServer.java:376) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at net.minecraft.server.v1_9_R1.MinecraftServer.a(MinecraftServer.java:331) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at net.minecraft.server.v1_9_R1.DedicatedServer.init(DedicatedServer.java:269) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at net.minecraft.server.v1_9_R1.MinecraftServer.run(MinecraftServer.java:522) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_74]
Caused by: java.lang.NoSuchMethodException: net.minecraft.server.v1_9_R1.RegistryMaterials.c(java.lang.Object)
	at java.lang.Class.getMethod(Unknown Source) ~[?:1.8.0_74]
	at com.goncalomb.bukkit.mylib.reflect.BukkitReflect.prepareReflection(BukkitReflect.java:86) ~[nbteditor-2.0-SNAPSHOT.jar:?]
	... 12 more
[15:22:26] [Server thread/ERROR]: [NBTEditor] This version NBTEditor is not compatible with this version of Bukkit
```


Fixed


@goncalomb Not sure if you are going to update your branch to support 1.9, but currently NBTEditor doesn't work with spigot 1.9. :)

```
[15:22:26] [Server thread/INFO]: [NBTEditor] Enabling NBTEditor v2.0-SNAPSHOT
[15:22:26] [Server thread/ERROR]: [NBTEditor] Error preparing reflection objects
java.lang.RuntimeException: Error while preparing item name methods.
	at com.goncalomb.bukkit.mylib.reflect.BukkitReflect.prepareReflection(BukkitReflect.java:88) ~[nbteditor-2.0-SNAPSHOT.jar:?]
	at com.goncalomb.bukkit.nbteditor.NBTEditor.onEnable(NBTEditor.java:71) [nbteditor-2.0-SNAPSHOT.jar:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:291) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:340) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at org.bukkit.craftbukkit.v1_9_R1.CraftServer.loadPlugin(CraftServer.java:361) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at org.bukkit.craftbukkit.v1_9_R1.CraftServer.enablePlugins(CraftServer.java:321) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at net.minecraft.server.v1_9_R1.MinecraftServer.t(MinecraftServer.java:411) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at net.minecraft.server.v1_9_R1.MinecraftServer.l(MinecraftServer.java:376) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at net.minecraft.server.v1_9_R1.MinecraftServer.a(MinecraftServer.java:331) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at net.minecraft.server.v1_9_R1.DedicatedServer.init(DedicatedServer.java:269) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at net.minecraft.server.v1_9_R1.MinecraftServer.run(MinecraftServer.java:522) [spigot-1.9.jar:git-Spigot-7d15d07-c194444]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_74]
Caused by: java.lang.NoSuchMethodException: net.minecraft.server.v1_9_R1.RegistryMaterials.c(java.lang.Object)
	at java.lang.Class.getMethod(Unknown Source) ~[?:1.8.0_74]
	at com.goncalomb.bukkit.mylib.reflect.BukkitReflect.prepareReflection(BukkitReflect.java:86) ~[nbteditor-2.0-SNAPSHOT.jar:?]
	... 12 more
[15:22:26] [Server thread/ERROR]: [NBTEditor] This version NBTEditor is not compatible with this version of Bukkit
```


Need a better error message


+# hrtelseedmi


Add me


I know that the software does it for you but as someone who has used Gentoo/Funtoo for a long time I go by the CPU amount +1
so I have an 8 core so I'd put a 9.


NOICE


use lowercase in r_asm. there's `asm.ucase` eval var that will uppercase if you prefer this way.


Why this is now limited to 5000? For brushed motors this is set to up to 32000.


2097-EP-8-5 (kbenne) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


you could do `Rails.application.routes.append do get '/omg' => lambda { [200, {}, ['omg']] }, as: 'omg' end` and then you can verify with `Rails.application.routes.reload_routes!;  Rails.application.routes.recognize_path('/omg')` I think.  I usually look at how rails tests this stuff.  Maybe just add a route to the test app for this purpose.  Might be simpler


I don't want to run a $rootScope.$digest - ideally I would like to just run $scope.$digest and have all the nice stuff that evalAsync has in terms of phase/digest resolution


@AlbertoSONIC Can the button be used with emuNAND9 too?


missing spaces before parenthesis


use strcpy


Oh, right, I'll fix. should be the same as the PPTs (lowercase).


Does this already have slough?  I see the BSO limit in http://docs.services.mozilla.com/storage/apis-1.5.html#api-instructions, but not the 1Mb limit.


use snprintf


2097-EP-8-5 (kbenne) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


For context I am working on a MASSIVE angular app, like .. MASSIVE, so we have a lot of watchers, a lot of directives, etc - so a $rootScope.$digest can be really expensive hence why trying to localize things to $scope.$digest();


Do we need a new release of Krikri to test?


this var can be overflow as long as its written with `sprint` instead of `snprintf` and many of the format strings will result in > 32 chars written


Thanks :+1:


Payloads can be 256k, 100 * 256k is significantly larger than 1Mb :)


if (1)?


> must behave just like any other :edit command and that does not change to any mode

I understand,thanks a lot,
I can do this by an `autocmd bufEnter`,but now vim-airline has bug about this event,after that bug fixed,I will add to my vimrc.
bug link https://github.com/vim-airline/vim-airline/issues/1029


Should consider tracking blockDepth by test context to support nested modules.


Is your primary concern about the if-checks? Or is it about the solution generally?


should be an autoload, no?


Good work with the CSS! Keep practising!


Citation needed :)


do it


```diff
- ActiveModelSerializers::Support::UrlHelpers.include ActiveModelSerializers::Support::UrlHelpers::Rails
+ ActiveModelSerializers::Support::UrlHelpers.prepend ActiveModelSerializers::Support::UrlHelpers::Rails
```


Elsewhere you talked about ordering bookmark folders first.  I raised my eyebrows at that -- it's not something we do on Android, for instance -- but this destroys any hope of doing that.


Strictly, no (you could pin to `develop` in testing; and I think @markbreedlove is already doing that.

Still, a new release wouldn't hurt, since https://github.com/dpla/KriKri/pull/221 won't likely make it in for a few days.


use hex value instead of `0b`. it's more portable for some old C compilers. Also, use defines instead of inlining those magic numbers. I understand that binary read better, but there are macros for this in r2 to solve that compat issue.

See `r_types_base.h`. Anyway.. as long as r2 codebase is being updated to use `bool` and other modern features of `C`. Maybe it's ok to just use that `0b` syntax. i'm not sure which compilers are incompatible right now.


The solution generally.  It is quite likely that there is a piece of this that I don't understand and therefore the fixes that are being presented don't make sense to me.


This is a hard line.  Better to drop the record?


missing space


Why not destructure `line`?


missing newline


FWIW, I just looked at the final pull request (all the stacked commits).  There's both a "src/ripple/app/paths/Flow.h" and a "src/ripple/app/paths/impl/Flow.h".  Having two files named "Flow.h" seems less than desirable to me.  It certainly could lead to confusion.  Just for your consideration.


Yeah, that's a c++14 feature unfortunately.


take the copyright holder style from any other file and put your name in it


wrong indent


missing space before ( and after every ;


You're right about imagemagick. We were only using it for test-suite diffing. That's now handled by pixelmatch.


klkflhjdhgd


@mayork: we use a syntax/style checker called pylint. Please install pylint (you can install a plugin for your text editor, or just run the pylint program from the command line). Our config file is at https://github.com/hoburg/gpkit/blob/master/.pylintrc.


Oh geez, this looks ugly.  Only the plus side maybe we can make other libs private?


o yeah i always forget brushed motors.

I am not sure if brushed is going to work in this concept. It will burst
the cpu usage.

I will have to find a fix for that.
Op 1 mrt. 2016 00:30 schreef "MJ666" <notifications@github.com>:

> Why this is now limited to 5000? For brushed motors this is set to up to
> 32000.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/borisbstyle/betaflight/commit/856ceee528cd471c1ecd5408a35226270dc872ed#commitcomment-16405039>
> .
>


I will fix this, but there's a missing `user_model.find_by_id(user_or_user_id)` that helps some tests not fail :)


Same here sorry :(


Is it a system level decision to assign a random port when it attempts to bind to port "0"? If so is that the same across all systems (mac, windows, linux)?


This outputChatBox is not required


Any reason you didn't add docs for this?


Fixed.


Just fixing the gravity that got broken when they added new armors.


Since this change the build/build.py script does not run anymore for RPM and DEB - setup.py seems to use this argparse instance too and fails. Do you have any experience in resolving this?


missing copy rights


We will have one repo per third part module or theme and only one repo for all our modules and themes. So it is easier to have all of them within the same folder


i think you can remove this


I apologize, it won't happen again!


@mayork, check this out -- it's equivalent, and much simpler.


Shouldn't you await this? If not, add comment to make it clear why


Is a `combined` option something that we want to support in general? (I haven't included it in ably-js, and it isn't in the spec)


Yup here too... then will merge. Lets be **Bold!**


I'm fine with TI.


This was an old commit which was fixed.  Any reason why you comment?  Did I miss your point?  Thanks


lmao


Okay, cool. The original problem is that in master right now, all control editors for AMPVControls don't seem to accept input (only -1 is shown in the dialog), at least for Side, Main, and IDEAS. I added connect statements to the editors to listen for when the new min/max signals are emitted. Looking at AMPVControl classes though, it looked like the min/max values weren't always being updated and the signals not always emitted. But I could have messed this up, being unfamiliar with the code. With the changes in this pull request, I think the cached min/max values are now always representative of the PV's min/max and the signals are emitted every time those values are changed. That's what I meant to do, anyways. Does that make more sense?


Do we want to add an instance for `Maybe`?


did you fix this manually? because there shouldn't be a .props file any more in the new nuget package


Yeah, I'd like to be in a place where we don't need to order anything at all…


FYI `obj.abc = xyz` is preferred over `obj['abc'] = xyz` except when you're using a variable instead of a string for `"abc"`

https://github.com/airbnb/javascript#properties


same here


Yep! But that'll be in `maybe`, `control` is higher in the hierarchy.


i think there's just Contract. Fail.


what the fuck is what?

On Thu, Feb 25, 2016 at 2:00 PM, Damanjit Gill <notifications@github.com>
wrote:

> what the fuck is this
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/LordoftheWild/the-wild/commit/b7b158bbd1b668efdabd4e989879e5c28474acfc#commitcomment-16334858>
> .
>


wat does ToString on a tree produce?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17793](https://teamcity.mesosphere.io/viewLog.html?buildId=149317&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 243 Build time: 00:03:42


@sgibb - FYI: two commits that should probably be ported to the 2.0 branch

- Update call to nQuants to accomodate changes in MSnbase (see commit #ce637b87e491a2f4c9f93490b2f4c7027cbfce16) <2016-02-29 Mon>
- Defunct synapterGUI <2016-02-29 Mon>


If we drop the record, we can't sync at all. We're in a `forEach`, so we can't early return. If we fail, there's nothing we can do — it's simply not possible to sync. Error handling here is difficult.


isn't this just root.FullSpan.Intersects(position)?


English pls


s/stand/standby/


English commit


for the **time** being


s/mode,/mode/


So good, well done.


The 1MB limit was imposed in Bug 692372, alongside the 100-record limit. We stop at whichever comes first — count reaching 100, or bytes reaching 1M.


Oh, I think I see.  You're using a `boost::optional` as a work-around for `PaymentSandbox` having a deleted copy constructor?  If that's correct, maybe it would be better to just give in and give `PaymentSandbox` a copy constructor.  That feels like the honest answer, but I may be missing something...


1.7 is finally totally outdated. Either don't update bungee or update your server some time. You will loose players slowly but constantly.


+1 If you have Linus's blessing, then you have mine.


I like this!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17794](https://teamcity.mesosphere.io/viewLog.html?buildId=149345&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 243 Build time: 00:03:52


:+1: Looks good, then!


@mattahorton, should this have a preceding '.' ?


Seems ok to me.  @pilchie @jasonmal any objections?


curious: i never use www -- why did you?


The server isn't supposed to return the same timestamp on two successive responses. We could handle that on line 38.


My opinion is that all 'hand-trigger' should use SetRange() to declare this property, since 'hand-trigger' is actually a totally different category.


Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.


@nmittler @normanmaurer any thoughts on how we might approach this for openssl and the fedora library..? yet another try catch? bit of a special case since the artifact only exists for openssl, not boringssl..


@dmose Added line.


Ah no worries :)


The service bridge will time it out at a minute.
The worst running time of this loop is just over 3 minutes, but that is an extremely unlikely case (it has to make 58 or 119 requests and then the service bridge goes bad hitting the one minute timeout).
If the service bridge recovers during a one minute attempt, it should just work (even though we are ostensibly only making two requests in the worst case)


orch**e**strate


The directory would be /home/jenkins/...  not /jenkins/...


Rock.CodeGeneration is it's own solution therefore it has it's own packages.  You'll notice that Rock.sln keeps it's packages in https://github.com/SparkDevNetwork/Rock/tree/develop/packages


s/its/their/


A throttling lock means that this operation can only be done once every 15 minutes. Also, you are not adding anything from the work item (like org) to make the lock specific to that work item. Which means that you will be able to do 1 of these operations every 15 minutes across the entire app.


Git**H**ub


Yes, that does make a lot of sense.  My only comment/question is that the code that @iainworkman wrote doesn't always update the AMPVControl's min/max values by default.  It only does that for controls that have called `enableLimitMonitoring()`.  Does that matter or is the behaviour you're fixing only pay attention to the controls where the limits are enabled?  Or is this just a bug in @iainworkman original implementation where it causes controls to get into a bad state for controls that don't have min/max values defined?

Thank you for the detailed response @helfrij.


Good call, missed that

On Mon, Feb 29, 2016 at 3:54 PM -0800, "Eric J. Smith" <notifications@github.com> wrote:

A throttling lock means that this operation can only be done once every 15 minutes. Also, you are not adding anything from the work item (like org) to make the lock specific to that work item. Which means that you will be able to do 1 of these operations every 15 minutes across the entire app.

—
Reply to this email directly or view it on GitHub.


This will be a proxy instead ;)
It will listen on the IP, and will trasfer players.


So it turns out you fixed one problem here and exposed another problem - the syntax for latexmath ranges actually has to be

    latexmath:[$[min,max\]$]

(note escaped inner right bracket) due to unfortunate asciidoc macro/LaTeX interactions. Should be fixed in a PR I'm about to create.


Trailing comma ಠ_ಠ


Please use some of the block quoting / code formatting type stuff.

https://guides.github.com/features/mastering-markdown/

For example

    $ vagrant package
    $ vagrant box add --name devstack-gate package.box


Ahhh. Ok


@HenriWahl the problem is that the debian build is passing two command line arguments --install-lib=/usr/share/nagstamon and --install-scripts=/usr/share/nagstamon that are not handled.
Before that mod, unhanded arguments were silently ignored, that is bad. Now it complains about unhandled arguments.

Fixing that could be as easy as removing these arguments from debian/rules but... are they supposed to be used?


The name of the image was misspelled, it should be ` <img src="images/TrumpPicture.jpg" alt="Selfie" id="trumpface"> ` :hammer:


1，增加.gitignore忽略文件
2，为项目配置sass
3，把index.css重构为index.scss


Good work on the assignment.


These need to use tuple args otherwise the decorator is iterating through chars in the string.


Add some error cases.


I am curious, why do we need logcat here?


## Task 1

Write a program that includes 5 different functions each of which demonstrates one of 5 **different** string methods. As always, your program should contain a `main` loop and an `ifmain` statement.

- [ ] Program is correctly formatted (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program uses 5 functions to show 5 string methods and functions correctly (2 pts total; 0.4 points each function)

## Task 2

Write a program that processess these data to split them by line ending, replaces the tab separations with commas, and prints out the result - line-by-line. As always, your program should contain a `main` loop and an `ifmain` statement.

- [ ] Program is correctly formatted (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly processes data - it prints the data line-by-line, reformatted from tab-delimited to comma-delimited (3 pts.)

## Task 3

Write a program that takes the given list (using argparse) as input, and passes the list to a function.  Within the function, use iteration to remove every even-numbered item from the list, and return only the list containing odd numbers to the `main` loop.  Print the list of odd numbers from the main loop.  As always, your program should contain a `main` loop and an `ifmain` statement.

- [ ] Program is correctly formatted (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly removes even-numbered elements from the list using iteration, returns this list, and prints this list from the main loop (3 pts.)

## Task 4

Why do you see these different behaviors between `function1` and `function2`?  Answer the question for each function by copying the code below to `task5.py` within your github username directory and adding your explanation to each function as a **function description**.

- [ ] Correct answer for function 1, as a function description (2 pts)
- [ ] Correct answer for function 2, as a function description (2 pts)


在提交git的过程,其实是需要添加忽略的,在还没有任何提交的时候,要添加忽略直接在git的配置清单文件中添加即可


Toss this.  It's redundant.


程序流程
==============================
待添加


need the error log to fix it


Move this assignment to before the submit() -- otherwise, the new thread may start, check 'transfer' before this assignment has happened, and terminate immediately. Actually, it seems like transfer should be volatile if we want to modify it in one thread and have the change be visible in another without synchronization.


the time for timeout is better to be configurable with a default value


Soon we won't even need this code, lol


Please move apivalidation.ValidateLabels() and apivalidation.ValidateLabelName() into (unversioned) validation.

I mean currently it's not appropriate that ValidateLabels() and ValidateLabelName()  stay in apivalidation, to move the two functions into (unversioned) validation, you need also delete those in apivalidation.


$ cat input
this   		is input  file
you need	to  read this
$ ./a.out < input
line --> 2, word --> 9, character --> 47


Reference: 1.5.4 Word Counting
The C PROGRAMMING LANGUAGE, Second Edition, Brian W. Kernighan & Dennis M. Ritchie


Result of running:
```
find . -type f -exec sed -i "" "s/1\.2\.0/1\.2\.1/g" '{}' \;
```


test


## This is a markdown file


Begin using v0.4 of Vagrant box which includes matplotlib installation


Fixed in 4352c8b0c099ff5c. Thanks for checking.


Fixed bad refactoring on Date analysis (JSON cannot serialize Timestamp object error)