I've not tested this but, the below code should let you access the elevated context:
<snip>
diff --git a/cinder/volume/driver.py b/cinder/volume/driver.py
index 647b5e9..861e5db 100644
--- a/cinder/volume/driver.py
+++ b/cinder/volume/driver.py
@@ -418,7 +418,7 @@ class BaseVD(object):
         return

     @abc.abstractmethod
-    def delete_volume(self, volume):
+    def delete_volume(self, context, volume):
         """Deletes a volume.

         If volume_type extra specs includes 'replication: <is> True'
diff --git a/cinder/volume/drivers/lvm.py b/cinder/volume/drivers/lvm.py
index 84e6f56..b8ea575 100644
--- a/cinder/volume/drivers/lvm.py
+++ b/cinder/volume/drivers/lvm.py
@@ -324,7 +324,7 @@ class LVMVolumeDriver(driver.VolumeDriver):
                              self.configuration.volume_dd_blocksize,
                              execute=self._execute)

-    def delete_volume(self, volume):
+    def delete_volume(self, context, volume):
         """Deletes a logical volume."""

         # NOTE(jdg):  We don't need to explicitly call
diff --git a/cinder/volume/drivers/rbd.py b/cinder/volume/drivers/rbd.py
index ecaa929..75d55cd 100644
--- a/cinder/volume/drivers/rbd.py
+++ b/cinder/volume/drivers/rbd.py
@@ -559,7 +559,7 @@ class RBDDriver(driver.VolumeDriver):
         if int(volume['size']):
             self._resize(volume)

-    def _delete_backup_snaps(self, rbd_image):
+    def _delete_backup_snaps(self, context, rbd_image):
         backup_snaps = self._get_backup_snaps(rbd_image)
         if backup_snaps:
             for snap in backup_snaps:
@@ -622,7 +622,7 @@ class RBDDriver(driver.VolumeDriver):
             if g_parent:
                 self._delete_clone_parent_refs(client, g_parent, g_parent_snap)

-    def delete_volume(self, volume):
+    def delete_volume(self, context, volume):
         """Deletes a logical volume."""
         # NOTE(dosaboy): this was broken by commit cbe1d5f. Ensure names are
         #                utf-8 otherwise librbd will barf.
@@ -639,7 +639,7 @@ class RBDDriver(driver.VolumeDriver):
             parent = None

             # Ensure any backup snapshots are deleted
-            self._delete_backup_snaps(rbd_image)
+            self._delete_backup_snaps(context, rbd_image)

             # If the volume has non-clone snapshots this delete is expected to
             # raise VolumeIsBusy so do so straight away.
diff --git a/cinder/volume/manager.py b/cinder/volume/manager.py
index 6d76a77..55f96ef 100644
--- a/cinder/volume/manager.py
+++ b/cinder/volume/manager.py
@@ -545,7 +545,7 @@ class VolumeManager(manager.SchedulerDependentManager):
             if unmanage_only:
                 self.driver.unmanage(volume_ref)
             else:
-                self.driver.delete_volume(volume_ref)
+                self.driver.delete_volume(context, volume_ref)
         except exception.VolumeIsBusy:
             LOG.error(_LE("Cannot delete volume %s: volume is busy"),
                       volume_ref['id'])
</snip>


Hi,
During this change, you have removed the changes which were done to fix LPS-30298. Now its back again. So now layout.prototype.link.enabled.default is not being considered at all.
https://github.com/liferay/liferay-portal/commit/3c2bdbcc78005c69601accb5c954b8cf116772cb#diff-82ecd2b87996de47188592cd7e9b14d2


OK, but it's only at the very beginning/end of the paragraph, not for each line.


ack


Упс, не заметила ●‿●'


Is it really needed this line to be here twice :)


Je ne conaissait pas sponge, mais utiliser "tac" qui vient de "coreutils" me semble plus sympa, ça me gêne de forcer tout le monde à installer un paquet juste pour ça. Mais ça mérite peut être un commentaire ?


This no longer seems to load any files in valid directory paths that are specified containing dots:

__Works:__
`/home/squigg/project1/tests/factories`
__Doesn't work:__
`/home/squigg/project1/database/seeds/../../tests/factories`

As I'm using Laravel I fixed it by switching out my path to use `base_path()` and building up from there, but maybe something to document or fix, as it's not uncommon for people to build paths using `__DIR__` and traversing back up the hierarchy.


Хм. А почему это не сделать селектором для цвета?


Just to clearify, making the getCurrentNumber(String secret, int timeInMillis) public is not enough?


is it useful to log something? IMO yes, maybe at `DEBUG` level only


#include<stdio.h>


I'd love a doc comment, you need to do a rebase anyway right?


This is cool. Can you update the README as well?


Why?
Globals are EVIL


unack


Can we make the additional method abstract just like the other ones?


Cool, that makes tests much shorter and clearer.


`accADCRaw` can be auto variable


but why do u need to elevate context for just a backup_get operation ?
user context should suffice I believe...


it is not clear to me what is the intention of the `yield` + `throw`


same as before


Дублирует 1 в 1 downloader_done, точно нужен отдельный?


seriously?


I don't think those two commits are related. Max retries fix comes with bosh_aws_cpi release 44. We can discuss whether it is necessary to bump version of bosh release in this PR but it doesn't fix max_retries.


seack login and password between existing in db


А тут ночной цвет в обоих downloader_update[_night]


Can we squash this commit down or reword the commit message pls?


:+1: Thanks!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15833](https://teamcity.mesosphere.io/viewLog.html?buildId=135704&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:19


these can probably stay as int16_t


you might want to log the intention, not the outcome (which is obvious)


why do you compare against a boolean value?


Good Job Ani!


Better "Tests run in the...". And you can test *private* subs that are not exported, right?


ack


This was actually a proof of concept to test if it works and it works and
tested.

Bur gyroADC and other sensor values were already global!
Op 15 feb. 2016 11:56 schreef "Petr Ledvina" <notifications@github.com>:

> accADCRaw can be auto variable
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/borisbstyle/betaflight/commit/2340200fa017ae119c4cf6b238b1f345ce53992d#commitcomment-16092317>
> .
>


It's of minor importance. No trailing spaces is a simple rule (which can be usually enforced by an editor) that should prevent pollution of commits with a white-space changes assuming everybody has the same setting enabled. I do not remember that we ever discussed it though, I am just used to do it this way. Therefore I've kept the white-space removal there. I should have done an extra commit though.


That said, how likely are we to truly see single-page documents?
This would mean having the whole thing as an XHTML document right now (as we still require a Navigation Document and the requirements for it are still tied to XHTML serialization, neither requirements making much sense IMO). Also, do we mean single document as in single content document or single resource? You can of course embed CSS and images in-line too, but that's not very likely to happen.

When you mention serving different media at the same resource, I assume that you're talking about content negotiation in HTTP? Based on the "Accept" header you could of course serve both JSON and HTML, but we can't make that a requirement for BFF.
We want to support use cases where the manifest creator won't be able to set that up on the host, or even use cases where the manifest creator is just remixing content resources found across the Web (all of them with nice CC licenses of course!).

I'm not a fan of well known location/names either outside of the context of a zip container, we're much better off using links on the Web.

Overall, I think we're still stuck thinking that an EPUB on the Web absolutely needs a homepage, which IMO is incorrect. From a Web perspective, there's no content document that is more important than the others, I should simply browse and search as usual, and eventually encounter a publication if my browser can detect it (should be a pretty easy Chrome extension to create).

For an OPDS record, being able to link directly to the JSON manifest would make a pretty massive difference in terms of semantics.

Let's take the HTML example again, how do I know that this actually point to a publication instead of an HTML resource?
```xml
<link type="text/html" rel="http://opds-spec.org/acquisition/open-access" href="...">
````
I would have to add additional information to know that I'm actually going to reach an EPUB BFF.
On the other hand, if I can link directly to the JSON, we can simply use a new media type that can be easily detected by OPDS clients:
```xml
<link type="application/epub+json" rel="http://opds-spec.org/acquisition/open-access" href="...">
````


you might want to add the complexity the to rest of the exercises also


I think we have agreement to do not use built-in types


Thanks @mikemcquaid, our daily Homebrew-based CI installation job confirms the PSQL cluster is now initialized post-installation.


Thanks for the comment! That's exactly what I thought, but I wasn't quite sure about it.
I'll take a look at ActionPlanPatchType, make the changes, set-up my foundation member account and will submit the patch, following the instructions.


I think you're supposed to do it in-place


Yeah I agree, the exception was added based on someones suggestion so I'll defer to @eregon / @nirvdrum.


can we somehow to disable creating weighted main domain? in case i just want to have a VersionDomain, some check here like ```if main_domain == "": turn_on_flag_for_no_main_domain``` would be good and easy way to do this


Does this fail on comments?
```perl
# Old package name
#package Test::Confuser;
package Test::RenamedConfuser;
```


you should probably have a few leftover spaces at the end, in order to be able to do it without additional structs


"should"


still not readable


Just because? Do you expect this to have noticeable effect? But sure, go ahead.


no, a builder is not supposed to "talk" to another component, it should build something


Угу, скорее всего некоторые (или даже все) иконки загрузчика будут одинаковыми. Позже разрулю это и поудалаю дублирование.


WOOHOO, we have lift off. Got a good sync on the WWVB clock first try tonight with the new update.
Got to go test it again with the right time zone setting :)

Serial Monitor text FYI as well.
Waiting on first GPS sync (sync only occurs at 0s)
error : NMEA string $GPTXT is not supported
error : NMEA string $GPTXT is not supported
7......40.........50.........
##### GPS SYNCED #####
IsValid    : 1
Quality    : 1
Satellites : 7
Time/Date  : 21:27 on 15/02/2016
WWVB transmit started
Time/Date  : 21:28 on 15/02/2016
Time/Date  : 21:29 on 15/02/2016
WWVB transmit stopped
Resyncing time with GPS
.........10.........20.........30.........40.........50.........
##### GPS SYNCED #####
IsValid    : 1
Quality    : 1
Satellites : 7
Time/Date  : 21:29 on 15/02/2016
WWVB transmit started
Time/Date  : 21:30 on 15/02/2016
Time/Date  : 21:31 on 15/02/2016
Time/Date  : 21:32 on 15/02/2016
Time/Date  : 21:33 on 15/02/2016
Time/Date  : 21:34 on 15/02/2016
Time/Date  : 21:35 on 15/02/2016


As per my previous comment on this PR you need to create a v2 event_aliases store along with the appropriate C* schema


Ага, позже разберусь


I think the 'renderCard' method should be renamed to 'renderContent'. Then probably it would be better to not incorporate the render output in a div tag (In my opinion this could generate undesired rendering issues, we could put this as requirement for the template configuration in case of multiple components).


Actually this was not JS-specific at all, it was wrong for both backends.


axis is used everywhere...but can be kept private.

I just keep seeing it in many functions.


Селекторы в цветах не работают до 5.х


keine ahnung was ich da geschrieben habe
Beim abmelden werden alle Premissions und Header zurückgesetzt, und das funktioniert auch.


Thanks for the answer,

I use the LibRingClient from the AUR on Arch which should come straight from git.
The package is this one : https://aur.archlinux.org/packages/libringclient-git/

Retried to compile today did not worked and the lib doesn't have any updates


PS. When checking against NTP (internet time) on my laptop the seconds count difference is not possible to see. i.e. better than 100mS I think.


It looks like tabs are used for indentation in iglu central: https://github.com/snowplow/iglu-central/blob/master/schemas/com.snowplowanalytics.snowplow/contexts/jsonschema/1-0-1


Is the existing event store publishing messages to a Kafka topic? If so is anyone listening to that topic?


@mreinsch What is the use case for this? I thought that we want to remove blank characters.


the commit message doesn't really fit does it?


Don't put "organisation" as a magic string. Make it a constant


I think the following part in RFC 6550 mentions about when the timer is reset implicitly.

> 8.3.  DIO Transmission
>
>    RPL nodes transmit DIOs using a Trickle timer [RFC6206].  A DIO from
>    a sender with a lesser DAGRank that causes no changes to the
>    recipient's parent set, preferred parent, or Rank SHOULD be
>    considered consistent with respect to the Trickle timer.

In other words, if a DIO changes the recipient's parent set, preferred parent, or Rank, it is considered as inconsistent and the DIO triggers the DIO timer reset.

I have no idea why they emphasized it by "from a sender with a *lesser* DOGRank" in the second sentence, though... Perhaps, this is because a DIO from a sender with a *higher* DOGRank has obviously no effect on the three things of the recipient.


there's no such thing as private subs in perl, you can always call them by full package name
tests now run in the same package namespace, so yeah naturally you can directly access everything that is defined in that package


second arg should be `coala` not `coala-ci` right?


Проект Fast Search завершен


This removed the feature "activePath" . Need to restore to previous version


Would it be possible to return `None` instead of `'error'` ? What if I'd define an alias called `error`?


coala-ci -> coala-format


Please add full stop at the end of the debug message.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15834](https://teamcity.mesosphere.io/viewLog.html?buildId=135707&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:51


need npm publish


emblem strips all spaces, and we don't want to have leading / trailing spaces in the translations. But we need to sometimes add spaces in front of / after texts.


Resolved by https://github.com/summernote/django-summernote/commit/cff61485befe1bcd2b1953574252aebcc53c91c2


DYAC s/score/scope/ in commit description.


R


This commit threw away everything in the style landing page feature


Isn't it a XOR ? if so : the name is not ok and you can use `^` i guess


I'd rename this `getExistingId`. That you are using the uri from the passed organisation is an implementation detail that should be transparent to the the user of this method


Let's: remove anything related to the environment ({{hbase.rootdir}}, {{fs.defaultFS}}, {{hbase.zookeeper.quorum}})
We are already passing these in env variables
That way, we are prepared to override hbase-site.xml completely with "useful" information


Hey, welcome @JohJakob ! :wink:


Yes but doesn't `replace(/^\s+|\s+$/g, '') ` remove everything, even at the end of paragraphs?
Not sure I got this correctly ^_^'


We should have the rootdir here as well


yeah, should fail


@mischah @clementgalidie Hey!


ah, this was an oversight that you fixed along the way.  thanks!


Wow, that's hard to understand


This is pretty slopply code @benedekfazekas .  If the user sets the user-customizable `lein-jack-in-lein-plugins` variable he'll override our dependencies.


Add to constructor initialization of potOffset


te pregatesti pentru semestrul 2 deja, boss?


please, no single line conditions


Can you add some comment on that?


No pull for Romanian translation for 26 days?


Ah ok then parent switch should result in a reset indeed :)


@IgorMaksymov  We have perfect DateTimeUtils class. Why do you use magic numbers instead DateTimeUtils?


This should really be "When `t` inject ...."


alignment.


Why removed?


So, I've found about `avcodec` package, Move to it

![image](https://cloud.githubusercontent.com/assets/572096/13047230/a5cec594-d3ee-11e5-9a79-d145c74bd33f.png)


You should change 'integer' to 'int'


No nice to you man! Thanks for all the work you've done! Loved that kernel on my s4!


@atd,
first: I did not add those traces, just changed the inner code accordingly to the new variables.
second: we are not in a merged branch to master, those logs are part of work in progress code.

if you still want all code commits free of traces, we should agree on that in a team discussion.

BTW, Thanks for keeping the code clean ;)


correct.


Indentation problem around <-. You can try this to fix indentation: https://github.com/scala-ide/scalariform


Didn't we have this before? I thought the Organisation store was already in Deer


penis


В смысле атрибуты


But looking at the bullet list below that I do think this sentence is mainly about not resetting (e.g. when things are consistent). Rank change should not be considered a "always" reset. Not included in the list is parent switch. Consider the case when there is no child at all. Then there is no need to reset - since if the rank is similar there is nothing new to say to anyone "below". So it is more complex than just resetting as often as we do now in Contiki RPL.


Bad habits are a diamond dozen.


Unnecessary ```println```


Put expectations into a Set then call `containsAll()`


@kappu72 @mbarto In my opinion it would be better to add an unique 'require' instead of adding all components here (i.e. an external index file with needed requires properly configured).


What about something like "parse_arp_cache"?


can we initialize to "None", this should simplify the following check at line #653


リロード時にはjqueryが読み込まれるが、
単なるページ遷移時には読み込まれないという問題を解決するために
このgemを導入しました。


type is useless for `List.newArrayList`


javascript ファイルをとりあえず作成しました。


Maybe `organisationSeperatingEventReadWriter` to be more explicit about what this does?


https://github.com/sindresorhus/user-home ;)


Я бы не называл Pref, будет ассоциация с префсами андроидными, а не сеттингами нашими. kAutodownloadKey?


オンライン上の画像プレビューのためのレファレンスをコピーしてきました。


И вроде static string const


The code in the previous lines up to this one is a re factoring. I would suggest to keep it on a patch by itself.
Thus, could you please split that patch two: the first refactoring the resolv_host function by adding the nre read_arp_cache, the second using that last function to make the reboot more robust.


We should drop the `jack-in` suffix to avoid coupling ourselves to a name which might change.


How about configuredHeaders?


OK, I see what you mean, sorry. Fixed everywhere.


Hi. Have you actually tried building Examine with this? Lots of warnings :crying_cat_face: .


@dev-gh, as I know It's a @dtrunov CRQ/defect


All variables should have as tight scope as possible. Dont even reuse one local variable for multiple purposes in function. Compiler is clever enough to handle variable correctly (and local variable is usually allocated only to register, without allocating memory to it).

BTW: with axis global, it will be very easy to call function that uses it too, with possibly catastrophic results


we can avoid "hsot=" for such simple single parameter functions...


```json
{
  "a":0,
  "b":1,
}
```


Thanks, ingbrzy


I think host is mandatory, isn't it?


ここgithub上だとわかりにくいのですが、
thumbnail_previewという関数を定義してその中に先ほどの処理を入れただけです。


Yes it is a XOR
I prefer having it with != I find it easier to read. But if you want I can change it to ^
The name "hasOnlyOneReasonOrMime" IMO explains what I want : having exclusively the reason or mime defined. I'll update it.


先ほど定義した関数に引数を使って、
main画像　sub画像１　sub画像２のプレビューに使いまわせるようにしました。


yes but up was not sure enough, imho, because if you go to the second menu entry for any bugs, you will go to first menu-entry. esc is more safer, since it do nothing but stop the timeout.


Может и так. Поменяю на char const kAutodownloadKey[] = ..., как в других местах проекта. static вообще не нужен, так как это анонимный неймспейс.


Ok. Smart.


Interesting idea. But your second condition seems wrong because its evaluate only from perspective of white.

Did you mean abs (pos.count<PAWN>(WHITE) - pos.count<PAWN>(BLACK)) < 3?


here also we can avoid to assign the single only parameter


Ok


Yes, but the file is loaded in the ConfigurationPerformer which is not overriden, and may be will not be overriden; as it is a setBinder.


Getting error, while trying to update ffmpeg, git submodule update --init --recursive
fatal: Needed a single revision
Unable to find current revision in submodule path 'submodules/externals/ffmpeg'


AvcodecIsOpen -> CodecIsOpen
via this function is a method of CodecContext and return bool instead of int


Thanks for the patch. We use gerrit for this repo though. Could you resubmit using `git review`?


We need to checkout the files: landing.html, landing.css, navbar.html to version https://github.com/refugeetech/platform/commit/94eea89f6104aa8997fd61f44c85960bac8a7f4c


Ok, you tell me that we configure things we don't use ? Looks like a bad idea, even if I understand why.


added_classという引数に入れているクラスを
◉$('.' + added_class + ' img').css({
このように ドット付きで使いたい場面と
◉('

');
このようにドットなしで使いたい場面があったので

引数の中身をドットなしクラス名にして
文字列連結でドットをつけました。


Regarding Issue #1


If you target 2016.1 and higher: `math_ext.nas` is generic and part of FGDATA nowadays (via c172p), so there's no use in copying the whole file. Just refer to `Aircraft/c172p/Nasal/generic/math_ext.nas`.


Then maybe the name "...Builder" is not appropriate... I would propose VacationReplyPoster
I wanted to make this post here, as it allows me to better factorize the code (recipients and sender that needed to be specified in the post)
If you want, I can keep it a builder, build a "triplet" (sender, recipients, mime) and send it in the mailet.
As you prefer.


画像表示を綺麗にするためにcssを調整しました。


@Nicowcow what do you think of that wrapper ? It's the shortest I managed to do but it should be working with all languages and projects.


From the beginning, I don't find this easy to read. The method name could be better for "Either...Or"


このコミットは間違いだったので、次でgit revert します。


No. This was a mistake.  Good catch.


ここはずれていたインデント揃えただけです。


必要ないコメントアウトを消しました。


Sorry :cry:


Nice


On empty arguments, and single arguments, I got compilation errors with intelliJ. Hence the parameter.


Sorry, I just used the blame tool. I did not searched it further.

I don't have any problem on discussing it with the rest of the team.


[Single page app.zip](https://github.com/dilipMindstix/gitHub/files/130576/Single.page.app.zip)


if you do not add `NeoBundle 'user/repo'` into you vimrc, the plugin will not be add to rtp,so there is no need to clean


:+1:  I like it, thanks !


I think add-to-list should suffice here (and would be more appropriate).


Same here.


This is take from other 3rd repo , OficialPM dont have this , I will have a look on this


That may be more accurate I shall schedule one last test, thanks!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15835](https://teamcity.mesosphere.io/viewLog.html?buildId=135708&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:43


For good measure, would suggest we also clear the session before starting it at the beginning of the flow incase the user does not make it to the end of the flow. This ensures all the pre-existing session variables would have been cleared.


None of the injection variables should be customizable.


dsaddsf


"// Amount of cycles" is just wrong... you loop through the amount of cycles!
Better would be:
{ // creates a png for each cycle


@neitsab hello, can you try to change line 273 from
`let data = exec('./.translator  ...` to `let data = exec('trans ...`
Please let me know it it works and thanks for sharing the issue


I'm not sure why gcc allows this syntax. But MSVC doesn't. It should be:
```
typedef LONG (WINAPI *exm_WinVerifyTrust_t)(HWND   hWnd,
                                            GUID  *pgActionID,
                                            LPVOID pWVTData);
```
(the ptr isn't `WINAPI`, but what it point to is).

And shouldn't all your func-`typedefs` be `WINAPI`?


I 'll rework it tommorow.
I am compelled to stay java6, iterative , and keep track of a state ( as an Argument can be a value for a tag argument )
I'll do my best...


Besides the wrong indent... in waf all boards should get -Wundef, but the gtest part needs to gain a -Wno-undef


As you wish https://github.com/epogrebnyak/txt/commit/c62bcd4a84f1a160c463433109e4bda9fa8dc4dc
Теперь и строки с только пробельными символами отфильтровываются.
Но в общем мне больше нравится с filter, он, кстати, тоже ленивый в Python 3.


Either change the name of this key, or remove it if there's no excluding required.


Thanks. Added a suitable `@return`.


We should split this file.


Extra semicolon.;


Note that XHTML is *not* required for the navdoc in the current 3.1 draft. That said, in classic EPUB at least it will need to be used (for epub:type=toc) while waiting for RS to be upgraded to recognize @role.

Re pointing to JSON vs pointing to HTML: if we had unambiguous mime information for both these cases (acknowledging the problem you describe in your text/html example Hadrien), what would be the concrete problems arising from allowing both approaches?

> On 15 Feb 2016, at 12:02, Hadrien Gardeur <notifications@github.com> wrote:
>
> That said, how likely are we to truly see single-page documents?
> This would mean having the whole thing as an XHTML document right now (as we still require a Navigation Document and the requirements for it are still tied to XHTML serialization, neither requirements making much sense IMO). Also, do we mean single document as in single content document or single resource? You can of course embed CSS and images in-line too, but that's not very likely to happen.
>
> When you mention serving different media at the same resource, I assume that you're talking about content negotiation in HTTP? Based on the "Accept" header you could of course serve both JSON and HTML, but we can't make that a requirement for BFF.
> We want to support use cases where the manifest creator won't be able to set that up on the host, or even use cases where the manifest creator is just remixing content resources found across the Web (all of them with nice CC licenses of course!).
>
> I'm not a fan of well known location/names either outside of the context of a zip container, we're much better off using links on the Web.
>
> Overall, I think we're still stuck thinking that an EPUB on the Web absolutely needs a homepage, which IMO is incorrect. From a Web perspective, there's no content document that is more important than the others, I should simply browse and search as usual, and eventually encounter a publication if my browser can detect it (should be a pretty easy Chrome extension to create).
>
> For an OPDS record, being able to link directly to the JSON manifest would make a pretty massive difference in terms of semantics.
>
> Let's take the HTML example again, how do I know that this actually point to a publication instead of an HTML resource?
>
> <link type="text/html" rel="http://opds-spec.org/acquisition/open-access" href="...">
> I would have to add additional information to know that I'm actually going to reach an EPUB BFF.
> On the other hand, if I can link directly to the JSON, we can simply use a new media type that can be easily detected by OPDS clients:
>
> <link type="application/epub+json" rel="http://opds-spec.org/acquisition/open-access" href="...">
> —
> Reply to this email directly or view it on GitHub <https://github.com/dauwhe/epub31-bff/commit/cafee9bdf4d58e7eba12872354ea813464709ff4#commitcomment-16092454>.
>


[ABSTRACT.docx](https://github.com/vithiya04/vithiya04/files/130518/ABSTRACT.docx)

[toget.txt](https://github.com/vithiya04/vithiya04/files/130519/toget.txt)


Does anyone know who is behind the @sheffieldgeeks Twitter account? It seems like it could be a useful resource and the last Tweet was made a month ago.


Назовите только filled_lines() для простоты


Ah, there's a fields field and a fields (a list of field values) in the register register. No worries, it'll become clearer when we write some text explaining.


Missing newline.


Add Javadoc to this class.


Security/Commander/tree/master/keepercommander/yubikey).  You will end up using a challenge phrase to authenticate instead of the ,!


Is a **downdown** ability less or more than a simple *down* ability, mathematically speaking? ;)


to /tmp/png ...


alive states of all cells.


I might be out of my depth, but shouldn't it be: for example, you **can** annotate a `case` but not an `if`


You may want to extend ManagerBase or AdapterBase to hook into the CloudStack component lifecycle.


See pull request #157


Perhaps use CloudStack life cycle instead of `@PostConstruct`.


This is not needed any more!!!!!!


Second go synced fine too, but I got UTC not local time with an offset of -6,0. Date is OK but looking closer the minutes are 1 ahead of local NTP time. Will fiddle the gps.setTimezone again and retest.


What for you need cycle anymore?


not needed, waste of space


actually in sprediction's waypoint analysis castposition and unitposition nearly same position so castposition and unitposition value is same for now also castposition means the best position of skillshot can hit to enemy (like minimum time etc) and unitposition is the enemy's position when skillshot hit.


Every homie loves a little bit of `super`.


$x = $_gameField->getWidth();


$y = $_gameField-> ...


See https://msdn.microsoft.com/en-us/library/windows/desktop/dn469266%28v=vs.85%29.aspx

It's not a web page `url`, it's an `xml namespace`


Remove the <K>.


instead of make you should write "draw", so we really know what is meant here


You are correct, thank you!


Fixed in afe0c35 and 90fa163


a for is followed by a single space. for (...)


Use CS lifecycle instead of `@PostConstruct`?


Fixed in 5d8c502


Fixed in  c5361cc


{ // draw a black rectangle it the cell is alive


Remove `<K>`.


could we add `renamed="align"` on the available attribute? i.e (`@available(*, deprecated=1.0, renamed="align")`) same below


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15836](https://teamcity.mesosphere.io/viewLog.html?buildId=135709&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:46


Please write for what cycle is used: it's used for naming the png files.


np, that was fast!

> On Feb 15, 2016, at 12:41 PM, José Valim <notifications@github.com> wrote:
>
> You are correct, thank you!
>
> —
> Reply to this email directly or view it on GitHub.
>


Lol - that must have been there for ages without me noticing it. Should be 'drop-down' - I will correct.


Remove space between `!` and `checkUuidSimple`. Also, please use a logger WARN level message here to indicate we are changing an invalid UUID to a correct one.


add extra "column" to ownedgames


Je n'arrive plus à compiler :(
error line 244 >>>>
! Missing $ inserted.<inserted text>$ ... $\dot{M}_{accr}=\SI{e7}{M_\odot.yr^{-1}}


Awesome!


Please fix the method name to use standard Java conventions (`isUuidFormat`).


![ios simulator screen shot 15-feb-2016 5 07 52 pm](https://cloud.githubusercontent.com/assets/1255516/13047807/b85366b6-d407-11e5-897a-aa81f315fd28.png)
![ios simulator screen shot 15-feb-2016 5 09 42 pm](https://cloud.githubusercontent.com/assets/1255516/13047808/b853d72c-d407-11e5-9201-c60c53642eb2.png)


Please fix the method name to use standard Java conventions (`isUuidUnique`).


LGTM


@aofall （管他呢，不饿着就行）


Hey Sneezy. If the time is 1minute ahead, then i know what the issue is.
I assume that when you start transmitting a time it is for the minute it will be at the end of the frame, so whatever i sync to i add +1 minute.
Ill remove that an re-upload now


Please use a logger WARN level message here to indicate we are changing an invalid UUID to a correct one.


UI-Screenshot


Remove `<K>`.


I'd say consistency and simplicity mostly.

I'm not against the idea of embedding the JSON for single-resource publications (although I doubt we'll see such publications very often), but IMO it's the only case where it makes sense.


looks good


This argument should initialize `Time` property. And `Time` property should be used as in spine-libgdx in `EventTimeline.SetFrame`.


Is this change related to this bug ?


[ABSTRACT.docx](https://github.com/keerthisundaram/prepaidenergy-meter-using-smart-card/files/130613/ABSTRACT.docx)
[PREPAID ENERGY METER USING SMART CARD2.pptx](https://github.com/keerthisundaram/prepaidenergy-meter-using-smart-card/files/130615/PREPAID.ENERGY.METER.USING.SMART.CARD2.pptx)
[vini.txt](https://github.com/keerthisundaram/prepaidenergy-meter-using-smart-card/files/130616/vini.txt)


Taken out


Actually, I think you already solved this in another commit, so I think you're good.


Why not add the `_vmNamingPolicy` to the constructor?

Also, according to @nnesic (author of this here code), this line should not even be here!


$_POST['user_name'] && $_POST['user_password']

опасно класть необработанные GET'ы и POST'ы в запросы, нужно эскейпить через mysql_real_escape_string, ибо SQL инъекции
http://php.net/manual/ru/function.mysql-real-escape-string.php


Typo? hehe


Deux styles sont créés "modalBiblio--zonedrop--ok" et "modalBiblio--zonedrop--ko".
Il faut appliquer soit l'un soit l'autre sur la div ".modalBiblio--zonedrop".


got it !


i will change that one back and add a PR
Op 15 feb. 2016 12:21 schreef "Petr Ledvina" <notifications@github.com>:

> All variables should have as tight scope as possible. Dont even reuse one
> local variable for multiple purposes in function. Compiler is clever enough
> to handle variable correctly (and local variable is usually allocated only
> to register, without allocating memory to it).
>
> BTW: with axis global, it will be very easy to call function that uses it
> too, with possibly catastrophic results
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/borisbstyle/betaflight/commit/2340200fa017ae119c4cf6b238b1f345ce53992d#commitcomment-16092913>
> .
>


You may consider extracting repeatable code, like   `readyToCheck.methodsBuffer.append(".isEqualTo(").append(String.valueOf(value))
					.append(")");`  or `	if (delegate.isAssertingAValueInArray()) {
			readyToCheck.methodsBuffer.append(".value()");
		}` into separate elements. It's probably not extremely important, but it seems to me it would be more readable. wdyt?


fixed.


Trailing whitespace.


LGTM


Clive,

Although I haven't worked out the failure mechanism, I think there is an issue with the released sdhost driver and its use of the sg_miter API for PIO. I've pushed a source patch that restores the use of the SG_MITER_ATOMIC flag, and that should make its way into builds fairly soon.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15837](https://teamcity.mesosphere.io/viewLog.html?buildId=135713&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:55


Je regarde !

On February 15, 2016 12:44:44 PM CET, "Claire Guépin" <notifications@github.com> wrote:
>Je n'arrive plus à compiler :(
>error line 244 >>>>
>! Missing $ inserted.<inserted text>$ ...
>$\dot{M}_{accr}=\SI{e7}{M_\odot.yr^{-1}}
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/M2-AAIS/Poly_ET8/commit/505363b77067d5f4ef493c9485635d68ac3754e7#commitcomment-16093398

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


Can syncing of avatars be an option under ldap configuration?


The O in `VAO` already stands for object. Can we find a different name for them?


Why not here?


Now I see why this renders for you. It's not an Akka HTTP thing though, it's how Heiko's library provides marshallers, this one triggers:

```
implicit def json4sMarshaller[A <: AnyRef](implicit serialization: Serialization, formats: Formats, shouldWritePretty: ShouldWritePretty = ShouldWritePretty.False): ToEntityMarshaller[A] =
```

from `de.heikoseeberger.akkahttpjson4s.Json4sSupport`. So it's a 3rd party lib that makes the `()` render as you noticed, not any Akka HTTP defaults. If possible it would be great if you could amend the blog post to explain that :-) Our defaults certainly don't provide default marshallers for this case yet it sounds so from the context of your blog post :)


I did not renew my iOS program membership, the app will be removed from the app store automatically in the next couple of days.

Most probably it does not matter now, but I still think I did not violate the peer talk [bsd license](https://raw.githubusercontent.com/rsms/peertalk/master/LICENSE.txt), since the app [included the license](https://github.com/yep/DeviceSync-for-iOS/blob/master/DeviceSync/en.lproj/Credits.txt) as required by [line 10 of the bsd license](https://github.com/rsms/peertalk/blob/master/LICENSE.txt#L10). The license was reachable from the `about` section in the sidebar. My impression was that the bsd license covered the whole project, including artwork. If this was stated otherwise somewhere I did not realise it.


:sob:


Yeah good idea but i think this should be done by sven


Instead of using `unique_ptr`s here, can we write `ShaderObject` in such a way that we can use it inline? (i.e. move-only constructor/assignment operator) This reduces the need for dereferencing the pointers.


Sollte das nicht besser ein Gebiet sein?


switch


I'll look for out for that update.

Just hit the correct GPS time zone to make my made for USA CST clock read right for Adelaide.
gps.setTimezone(-8,30); //


-thought the same but i tried both with return but the first gave back all products


-cause later 2 lines later comes the if(!$location) -> show flash msg


It was because txs can come in from peers, appending new txs.


@trown Please take a look at https://review.gerrithub.io/263173, because I never used GerritHub, before.


This is what I was talking about :+1: Thank you! :smiley:

With instances a hook can store data specific to a single Parsedown instance without the need of accessing Parsedown's internal data structure. The only thing missing is that one can access the hook's instance. There are two ways to achieve this: Either return the hook's instance (`$this->hooks[]`) in `Parsedown::registerHook()` instead of `$this` or declare a appropriate `ParsedownHook` interface with `__construct(Parsedown $parsedown)` and accept instances of `ParsedownHook` as parameter of `Parsedown::registerHook()`. Whether @erusev wants to keep this project be a single-class library or not, the first solution may be easier, whereas the latter is cleaner.

Regarding @erusev's addition: Am I right that you just have to
* add public methods to add/remove items to/from `Parsedown::$BlockTypes`, `Parsedown::$unmarkedBlockTypes` and `Parsedown::$InlineTypes` (`Parsedown::$inlineMarkerList` could be updated automatically),
* add a public getter method for `Parsedown::$DefinitionData`, and
* hook into `Parsedown::isBlockContinuable()` and `Parsedown::isBlockCompletable()` the same way as for any other method,

or am I missing something?


Optimalerweise ja. Siehe Beschreibung: "Ort, an dem das Body beheimatet ist. Wenn möglich die Stadtgrenzen, ansonsten die Stadtmitte.". Wenn wir da jedoch die Stadtgrenzen reinschreiben, wird das Beispiel sehr, sehr länglich.


better do count($args) <= 2


I think we agreed that you could use null cirectly instead of a new NullFilterValue object.


Apart from the one cross-compile comment it looks good.

Cheers,


still getting TypeError: Argument 1 of Window.getDefaultComputedStyle is not an object....


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15838](https://teamcity.mesosphere.io/viewLog.html?buildId=135714&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:58


I would format the values as expected in QueryFilterToSql:

-  regular string values surrounded with "

- null values without quotes


Unit tests missing


OK, seems fine!


good!


Bad variable name. Please fix that and also fix the indention


Nice!


Please fix the indention


@amakropoulos Can you give the command for which you needed this change? Generally, these basic operations are meant to behave similar to the operators in C/C++. Hence, a division by zero is NaN, not zero. You could possibly use some additional data operation to substitute NaNs by zero in your case again.


> None of the injection variables should be customizable.

If these shouldn't be changed, why aren't they prefixed with `cider--`?


Damn, u impressed me :D


Would it have been a bit safer to separate changes for different issues here?


Add descriptions for error code but not all.


cc @AlbertoFuente @makotot @Rokt33r @Layzie @charbelrami @sohje for new translations. Thanks


TeamCity Civic Assembly :: Build all [Build 48](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1104&buildTypeId=CivicAssembly_BuildAll&guest=1) is now running


This grammar could be shrunk a bit, going to take a look :telescope:


If you try to export a save to VBA/MGBA, make sure you go to the cartridge data selection, then click export as raw binary. Rename the resulting sav file (It has the game ID code within the filename, albeit cryptic, but unique) to match the filename of the ROM used by VBA/MGBA and drop it into the same directory as the ROM.


Approach 1


I think you mean `Imports or returns` ?


In here we take advantage of the `explicit operator bool()` from `GLObject`, which does an equally safe check.


Could you keep these lines on top and use a `.split()` like the other bears ? This is a little difficult to read


No problem :smile:


This code will never be executed with the Mac backend, because it overrides `GetSystemDefaultMonospaceFont`.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.discussion/33//violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/__init__.py Imports are incorrectly sorted.
plone/app/discussion/__init__.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/catalog.py Imports are incorrectly sorted.
plone/app/discussion/catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/catalog.py:0:1: I001 found unsorted imports
plone/app/discussion/catalog.py:89:17: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/comment.py Imports are incorrectly sorted.
plone/app/discussion/comment.py:0:1: I001 found unsorted imports
plone/app/discussion/comment.py:77:28: Q000 Remove bad quotes.
plone/app/discussion/comment.py:172:40: Q000 Remove bad quotes.
plone/app/discussion/comment.py:174:30: S001 found %s formatter
plone/app/discussion/comment.py:178:48: S001 found %s formatter
plone/app/discussion/comment.py:213:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
plone/app/discussion/comment.py:250:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:259:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:268:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:277:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:303:21: Q000 Remove bad quotes.
plone/app/discussion/contentrules.py:0:1: C101 Coding magic comment not found
plone/app/discussion/contentrules.py:18:5: E731 do not assign a lambda expression, use a def
plone/app/discussion/contentrules.py:26:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:48:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:59:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:70:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:81:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:92:1: E302 expected 2 blank lines, found 1
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/conversation.py Imports are incorrectly sorted.
plone/app/discussion/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/conversation.py:0:1: I001 found unsorted imports
plone/app/discussion/conversation.py:67:27: Q000 Remove bad quotes.
plone/app/discussion/conversation.py:205:16: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:214:12: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:220:12: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:324:8: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:453:29: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/events.py Imports are incorrectly sorted.
plone/app/discussion/events.py:0:1: C101 Coding magic comment not found
plone/app/discussion/events.py:0:1: I001 found unsorted imports
plone/app/discussion/events.py:11:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:33:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:38:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:43:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:48:1: E302 expected 2 blank lines, found 1
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/interfaces.py Imports are incorrectly sorted.
plone/app/discussion/interfaces.py:0:1: I001 found unsorted imports
plone/app/discussion/interfaces.py:135:17: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:161:65: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:247:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:262:21: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:280:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:284:23: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:291:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:308:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:390:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:394:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:398:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:402:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:406:1: E302 expected 2 blank lines, found 1
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/patches.py Imports are incorrectly sorted.
plone/app/discussion/patches.py:0:1: C101 Coding magic comment not found
plone/app/discussion/patches.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/testing.py Imports are incorrectly sorted.
plone/app/discussion/testing.py:0:1: C101 Coding magic comment not found
plone/app/discussion/testing.py:0:1: I001 found unsorted imports
plone/app/discussion/testing.py:13:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:14:1: B901 blind except: statement
plone/app/discussion/testing.py:15:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:66:14: Q000 Remove bad quotes.
plone/app/discussion/testing.py:78:10: Q000 Remove bad quotes.
plone/app/discussion/testing.py:81:10: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tool.py Imports are incorrectly sorted.
plone/app/discussion/tool.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tool.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/upgrades.py Imports are incorrectly sorted.
plone/app/discussion/upgrades.py:0:1: C101 Coding magic comment not found
plone/app/discussion/upgrades.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/vocabularies.py Imports are incorrectly sorted.
plone/app/discussion/vocabularies.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_catalog.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_catalog.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_catalog.py:89:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:107:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:114:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:135:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:142:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:158:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:173:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:191:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:199:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:212:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:224:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:235:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:243:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:250:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:280:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:299:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:307:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:347:40: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:380:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:386:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:429:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:436:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:450:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:450:49: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:533:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:578:25: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_comment.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_comment.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_comment.py:55:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:56:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:57:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:106:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:108:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:114:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:130:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:131:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:135:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:136:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:158:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:166:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:179:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:182:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:187:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:231:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:262:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:267:23: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:304:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:329:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:371:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:407:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:442:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:450:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:459:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:468:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_comments_viewlet.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_comments_viewlet.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_comments_viewlet.py:43:1: F811 redefinition of unused 'IConversation' from line 38
plone/app/discussion/tests/test_comments_viewlet.py:112:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:126:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:134:43: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:135:60: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:137:66: W291 trailing whitespace
plone/app/discussion/tests/test_comments_viewlet.py:180:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:194:59: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:196:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_comments_viewlet.py:236:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:281:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:316:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:405:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:406:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:411:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:416:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:417:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:418:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:429:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:430:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:431:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:487:63: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_contentrules.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_contentrules.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_contentrules.py:6:1: F401 'notify' imported but unused
plone/app/discussion/tests/test_contentrules.py:22:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_contentrules.py:51:24: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:52:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:53:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:54:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:59:5: E303 too many blank lines (2)
plone/app/discussion/tests/test_contentrules.py:117:38: S001 found %s formatter
plone/app/discussion/tests/test_contentrules.py:121:38: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:122:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:123:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:126:9: F841 local variable 'new_re_id' is assigned to but never used
plone/app/discussion/tests/test_contentrules.py:135:35: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_contentrules.py:145:44: E127 continuation line over-indented for visual indent
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_controlpanel.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_controlpanel.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_controlpanel.py:36:18: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:43:56: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:92:5: F811 redefinition of unused 'test_edit_comment_enabled' from line 84
plone/app/discussion/tests/test_controlpanel.py:145:5: E265 block comment should start with '# '
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_conversation.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_conversation.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_conversation.py:31:1: B901 blind except: statement
plone/app/discussion/tests/test_conversation.py:91:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:93:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:94:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:95:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:96:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:96:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:97:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:518:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_conversation.py:560:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:565:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:570:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:575:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:969:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:973:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:978:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_events.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_events.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_events.py:15:1: E302 expected 2 blank lines, found 0
plone/app/discussion/tests/test_events.py:26:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:29:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:32:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:35:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:40:1: E302 expected 2 blank lines, found 0
plone/app/discussion/tests/test_events.py:81:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:99:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:138:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:151:38: S001 found %s formatter
plone/app/discussion/tests/test_events.py:157:9: F841 local variable 'new_re_id' is assigned to but never used
plone/app/discussion/tests/test_events.py:171:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_functional.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_functional.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_indexers.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_indexers.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_indexers.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_indexers.py:54:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:55:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:62:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:63:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:70:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:71:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:110:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_indexers.py:112:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_indexers.py:139:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:140:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:170:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:170:41: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_migration.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_migration.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_migration.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_migration.py:55:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_migration.py:68:14: Q000 Remove bad quotes.
plone/app/discussion/tests/test_migration.py:214:9: E265 block comment should start with '# '
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_moderation_view.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_moderation_view.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_moderation_view.py:111:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:119:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:127:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_notifications.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_notifications.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_notifications.py:37:42: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:64:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:86:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:87:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:102:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:130:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:146:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:151:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:176:42: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:227:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:228:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:234:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:238:13: S001 found % formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_tool.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_tool.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_tool.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_tool.py:32:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_tool.py:42:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_tool.py:43:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_tool.py:43:15: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_workflow.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_workflow.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_workflow.py:58:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_workflow.py:94:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_workflow.py:133:38: S001 found %s formatter
plone/app/discussion/tests/test_workflow.py:153:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_workflow.py:154:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_workflow.py:203:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/captcha.py Imports are incorrectly sorted.
plone/app/discussion/browser/captcha.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/captcha.py:64:39: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/comment.py Imports are incorrectly sorted.
plone/app/discussion/browser/comment.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/comment.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/comment.py:45:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:45:20: S001 found %s formatter
plone/app/discussion/browser/comment.py:47:41: S001 found %s formatter
plone/app/discussion/browser/comment.py:53:10: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:92:52: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:95:40: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:95:58: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:108:1: E265 block comment should start with '# '
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/comments.py Imports are incorrectly sorted.
plone/app/discussion/browser/comments.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/comments.py:94:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:100:35: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:128:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:129:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:130:42: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:132:1: C901 'CommentForm.handleComment' is too complex (15)
plone/app/discussion/browser/comments.py:141:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:142:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:157:16: E713 test for membership should be 'not in'
plone/app/discussion/browser/comments.py:210:53: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:251:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:252:22: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:275:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:276:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:325:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:328:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:336:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:344:37: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:415:20: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:415:21: S001 found %s formatter
plone/app/discussion/browser/comments.py:462:17: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/controlpanel.py Imports are incorrectly sorted.
plone/app/discussion/browser/controlpanel.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/controlpanel.py:34:10: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:90:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:91:48: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:96:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:97:40: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:97:41: S001 found %s formatter
plone/app/discussion/browser/controlpanel.py:113:46: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:119:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:126:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:128:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:131:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:135:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:141:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:168:46: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/conversation.py Imports are incorrectly sorted.
plone/app/discussion/browser/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/conversation.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/conversation.py:20:1: B901 blind except: statement
plone/app/discussion/browser/conversation.py:32:1: C901 'ConversationView._enabled_for_archetypes' is too complex (14)
plone/app/discussion/browser/conversation.py:138:12: P002 found "hasattr", consider replacing it
plone/app/discussion/browser/conversation.py:138:29: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/migration.py Imports are incorrectly sorted.
plone/app/discussion/browser/migration.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/migration.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/migration.py:37:1: C901 'View.__call__' is too complex (32)
plone/app/discussion/browser/migration.py:44:19: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:48:16: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:80:26: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:82:31: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:83:22: S001 found %s formatter
plone/app/discussion/browser/migration.py:181:25: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:181:26: S001 found %s formatter
plone/app/discussion/browser/migration.py:191:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:191:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:205:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:205:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:206:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:206:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:207:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:207:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:209:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:210:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:228:21: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:229:31: S001 found %s formatter
plone/app/discussion/browser/migration.py:237:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:238:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:239:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:239:28: S001 found %s formatter
plone/app/discussion/browser/migration.py:246:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:248:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:249:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:250:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:252:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:253:13: S001 found % formatter
plone/app/discussion/browser/migration.py:257:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:257:18: S001 found %s formatter
plone/app/discussion/browser/migration.py:261:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:262:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:266:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:267:17: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/moderation.py Imports are incorrectly sorted.
plone/app/discussion/browser/moderation.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/moderation.py:100:15: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:101:18: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:139:15: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:140:18: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/traversal.py Imports are incorrectly sorted.
plone/app/discussion/browser/traversal.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/traversal.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/traversal.py:32:20: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/validator.py Imports are incorrectly sorted.
plone/app/discussion/browser/validator.py:0:1: I001 found unsorted imports
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Per chat, we elected `*Holder` as a more favorable naming scheme e.g. `VAOHolder`.


So if we went with `Ord` I think we shouldn't test for it. I'm not a fan of checking what sort of type it is. That's one of the fantasy-land distinctions (unlike other libraries), so we either go full in, or make other types for ord checking (example `/ord/min.js`).

Thoughts?


Since that commit, I can't start prometheus anymore:

fatal error: stack overflow

runtime stack:
runtime.throw(0xe17270, 0xe)
	/usr/lib/go/src/runtime/panic.go:527 +0x90
runtime.newstack()
	/usr/lib/go/src/runtime/stack1.go:794 +0xb17
runtime.morestack()
	/usr/lib/go/src/runtime/asm_amd64.s:330 +0x7f

goroutine 1 [stack growth]:
github.com/prometheus/prometheus/vendor/gopkg.in/yaml%2ev2.(*decoder).prepare(0xc820050a40, 0xc820014e40, 0xca1dc0, 0xc8200539d0, 0x16, 0xc840600310, 0xc840600320, 0x458aa0, 0xc840600310)
	/srv/prometheus/go/src/github.com/prometheus/prometheus/vendor/gopkg.in/yaml.v2/decode.go:253 fp=0xc8406002a0 sp=0xc840600298
github.com/prometheus/prometheus/vendor/gopkg.in/yaml%2ev2.(*decoder).unmarshal(0xc820050a40, 0xc820014e40, 0xca1dc0, 0xc8200539d0, 0x16, 0x0)
	/srv/prometheus/go/src/github.com/prometheus/prometheus/vendor/gopkg.in/yaml.v2/decode.go:284 +0xc1 fp=0xc840600310 sp=0xc8406002a0
github.com/prometheus/prometheus/vendor/gopkg.in/yaml%2ev2.(*decoder).callUnmarshaler.func1(0xca1dc0, 0xc8200539d0, 0x0, 0x0)
	/srv/prometheus/go/src/github.com/prometheus/prometheus/vendor/gopkg.in/yaml.v2/decode.go:228 +0xf5 fp=0xc8406003a8 sp=0xc840600310
github.com/prometheus/prometheus/config.(*GlobalConfig).UnmarshalYAML(0xc8200539d0, 0xc82453be80, 0x0, 0x0)


It doesn't display anything, but it includes Blaze helpers for the user name, groups, and user id. Might not be such a great idea for React projects, actually. We'll adjust that tomorrow morning, I guess.


Handled in followup.


git fetch origin
git checkout -b revert-19-readme-edits origin/revert-19-readme-edits
git merge master


TeamCity Civic Assembly :: Build all [Build 48](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1104&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **FAILURE**
Summary: Tests failed: 165 (1 new), passed: 7, ignored: 4 Build time: 00:06:38
### Failed tests
```
Blog categories tests: Should delete blog category new blog category 1455538745390: <no details avaliable>

Blog categories tests: Should not create new blog category if cancelled: <no details avaliable>

Blog categories tests: Should add new blog category: <no details avaliable>

Blog categories tests: Should not change blog category: <no details avaliable>

Blog categories tests: Should change blog category: <no details avaliable>

Blog categories tests: Should not delete blog category if cancel pressed: <no details avaliable>

Blogs tests: Should not create new blog if Cancel button pressed: <no details avaliable>

Blogs tests: Should add new blog: <no details avaliable>

Blogs tests: Should not change blog if Cancel button clicked: <no details avaliable>

Blogs tests: Should change blog: <no details avaliable>

Blogs tests: Should not delete blog if Cancel button was pressed: <no details avaliable>

##### there are 155 more failed tests, see build details
```


I was trying to do mirtk calculate img.nii.gz -div img2.nii.gz -out out.nii.gz .
img2.nii.gz will generally have zeros, so this fills out.nii.gz with nans.
With this modification I have similar behaviour to fslmaths  img.nii.gz -div img2.nii.gz out.nii.gz


This brake main tiles switch in Settings. Without resolver it's not work.


hmmm...? So q4wine will use pootle to localize?


You are right, I don't know what was on my mind when I wrote <sparkle:installerArguments>, I was clearly referring to the sparkle:installerArguments attribute, as you pointed out.


InMemoryAuthenticationAccountRepositoryImpl.loadUserByUsername - never return null #68


This ci_keyword isnt required. because the #todo cs_keyword would match it


Why?

Looking at `updateAttributes`, `touch`ing an attribute on a new record shouldn't give any issues at all. However, not allowing this makes it more difficult to use methods using `touch` in normal scenarios, and it makes it more difficult to test methods using `touch`.

I don't fancy having to save() methods twice just to be able to call a method using `touch` so I guess I'll have to extend this class and overwrite `touch` to provide its old behavior.


Yes, we can implement move semantics on the base class i.e. `GLObject` (now `GLHandler`).


Each arg on a separate line


needs to be `$packageType`, not `$packageKey`.


Didn't we decide it better to run on a small file with `prepare_file` ?


`updateAttributes` fires a query to the database which includes the primary key. This does not work on new records.


Two things:
1) typo in the commit message (should be *task*)
2) this needs to bump the required libblockdev version to 1.4 (which will be released this week)


Удалим? CountryTree и ActiveMapsLayout больше нет.


Удалим?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15839](https://teamcity.mesosphere.io/viewLog.html?buildId=135718&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:11:00


Would adding `self.assertEqual(requires_migrations_checks, False)` after the first line be sufficient?


No need to use quotes in combination with indent, quotes are for inline code blocks, indent (or triple quotes) are for code blocks.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15840](https://teamcity.mesosphere.io/viewLog.html?buildId=135725&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:08:48


Well alright, I guess more people would expect it this way then and in most cases that's what you might want. But with the following, the user could choose what the default value shall be if the division is not defined. So keeping NaN's allows more flexibility actually and has the user deal with undefined mathematical operations. In case the ```-mask NaN``` isn't actually working yet, I'd rather fix that or add a ```-pad-nan``` option.

```
mirtk calculate img.nii.gz -div img2.nii.gz -mask NaN -pad 0
```


zczxvcxc


@AbdealiJK  Did something very similar in previous commits and @sils1297 didn't approve it. Anyway is it really essential to change that and send a PR again, given that the current style already complies with PEP8? :smile:


Sorry, I'm too busy with other work to help right now.

David Crocker, Escher Technologies Ltd.
http://www.eschertech.com
Tel. +44 (0)20 8144 3265 or +44 (0)7977 211486

On 14/02/2016 14:53, EinPunkt222 wrote:
>
> i dont know why, but now it enter the while at line 122 now it cant
> pass line 154 "if (ctr == 7)" ctr stay on 0 same to lastctr. is this
> the sleep mode?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dc42/arduino/commit/e4337de50dd9faa17381b2d06c95c48f5fdbe74e#commitcomment-16083612>.
>


I don't see `new_user_params` method defined anywhere. Are you sure this code works?


line 6


@liggitt Does the new client do what we want?  It seems unlikely, but its probably worth a check.


Not sure - when I began coding @sils1297 was strict about it.
You anyway have to modify `cs_keyword` right ?


Cider's usage of the the double-dash prefix is inconsistent at best. =P
Besides, it is still an exposed variable for usage by other packages (thus I think the single-dash is currect here).

When I say it's not “customizable”, I just mean that it is not a custom-option. And users who change it without respecting its previous value are just digging their own grave. :P


Oui ça serait plus clair :)


@AbdealiJK  It was intentional. It shows the purpose of both `cs_keywords` and `ci_keywords`. Should I remove it anyway?!


Why? The former is much more readable in plaintext. The output markdown is exactly the same.


Either name of the author or drop the line


I think it should be removed - Doesnt seem necessary to the test


lgtm


Does this make any difference?

If not, it should be dropped. If it does, it should live in attributes.h


Переводов нет ещё? Или дальше в реквесте будут вставки?


sdffsd


This looks like it has holes in it. Use pahole.


Certainly more legible that way.


Would you please push a v2.5.1 tag?


```did_hardlink``` should be set to FALSE.  It is initialized only when the condition at line 456 is met.


Переводов пока нет. Это вроде бы твой код, я его ещё не трогал.


dasdasd


This doesn't make me very happy.  @smarterclayton do you know why we bumped again?  Any concerns about doing this now?  I think I'm more afraid of not doing it and trying to keep the patchset with kube 1.2.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15841](https://teamcity.mesosphere.io/viewLog.html?buildId=135726&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:10


@AbdealiJK I was thinking not to because it has purpose. Anyway whatever you suggest. I should finally remove it then?


looks to be mostly test code


Yes, that makes sense, better to leave this file as it is.
Do you think it would be better to define this as the default behaviour for mirtk calculate -div ?


on 1.6 I get this:

```
BenchmarkESbulk-4    	    3000	    513901 ns/op	  184539 B/op	    1240 allocs/op
BenchmarkESbulkThem-4	    2000	   1040081 ns/op	  200882 B/op	    2283 allocs/op
```


@dev-gh `uint32_t` you like more?


Comment on a commit


Please stick with the existing style of having the starting brace at the end of the same line as the `if`


This looks wrong. First of all the commit description mentions G2D, which the patch however doesn't touch. Then it mentions some relation between glmark and IPP. But there is no relation here.


Straightforward, but do you know why we have an allocator factory?  I hate indirection.


'count' is rather vague. Perhaps 'count_read'.


@dirtycoder, I already did a .env file (line 33). :dancers:
The others parts was the steps that I made to run the project. I think this will help someone in the future.


Ок
> On Feb 15, 2016, at 3:33 PM, Alexander Marchuk <notifications@github.com> wrote:
>
> Переводов пока нет. Это вроде бы твой код, я его ещё не трогал.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/trashkalmar/omim/commit/ffd07e63adeec39e1ead5dee8496e21e8b9b5b86#commitcomment-16094365>.
>


Ок
> On Feb 15, 2016, at 2:06 PM, Alexander Marchuk <notifications@github.com> wrote:
>
> Угу, скорее всего некоторые (или даже все) иконки загрузчика будут одинаковыми. Позже разрулю это и поудалаю дублирование.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/trashkalmar/omim/commit/ffd07e63adeec39e1ead5dee8496e21e8b9b5b86#commitcomment-16092554>.
>


I always used to get hopelessly confused because I was mainly working with two and sometimes three remotes: nodemcu-firmware, TerryE and DiUS and I had "remote", "upstream", etc. but which was which? Until the light dawned and I twigged that the names could be anything; it's just that the Git help and documentation uses this functional naming convention.  So I switched to `nodemcu` for the nodemcu-firmware repo, `terrye`, `dius`.  No more confusion.  So I strongly recommend `git remote add nodemcu https://github.com/nodemcu/nodemcu-firmware.git`.


lgtm


I made it simple.
https://github.com/nitrogen-project/android_frameworks_base/commit/720201e628c65138d039c2a0121288b6a2c7ea89

Without resolver you can not enable/disable main tiles.


Не анонимный, android же.


Some JsonVerifiable implementations have hashCode() method that is based on the delegate .hashCode() inherited from the Object class (for example, JsonAsserter while creating hashCode can call Object-based hashCode() on any DocumentContext. Will this not be a problem?


I think I found the issue. In the Git class:

```
	sha {
		// find what hash is currently checked out
		var out;
		^sha ?? {
			out = this.git(["rev-parse HEAD"]);
			sha = out.copyRange(0, out.size - 2)
		}
	}
	remoteLatest {
		// find what the latest commit on the remote is
		var out;
		^remoteLatest ?? {
			out = this.git(["rev-parse origin/master"]);
			remoteLatest = out.copyRange(0, out.size - 2)
		}
	}
```

It is copying with out.size - 2, that means it is discarding the last char, which means that sha will have 39chars instead of 40. Then when it gets to Quarks#validateRefspec it fails the regex and says that it doesn't find the tag. Don't know why this doesn't manifest in other cases, but I can confirm that changing from -2 to -1 then it checks out the lastest from ModalityTests correctly. @crucialfelix , why does it have out.size - 2 instead of out.size - 1, were you expecting a newline at the end ?

```
x = Git("/home/miguel/.local/share/SuperCollider/downloaded-quarks/ModalityTests")
x.git(["rev-parse HEAD"]).last
```

returns a b, not a newline.


since you're already using `local` in your `combineReducers`, you could remove this `<Root>`. or does it not work then (which would be odd)?


Ой, ну да) Значит, нужен


Where does $ENV{MKL_ROOT} come from? MKL scripts are exporting MKLROOT not MKL_ROOT (at least in recent releases that I have seen). Could you please tell  me which MKL version did you use so that you had MKL_ROOT rather than MKLROOT ?


Hey, i was going to report that! :D


Out of curiosity more than anything, why did you go with `opacity:0` for the `select::-ms-expand` thingie?


> Do you think it would be better to define this as the default behaviour for mirtk calculate -div ?

Would make sense, but that wouldn't be easy to realise the way the calculate program works. Each option just performs some specific basic operation and the concatenation of these operations gives the final result. There could be another option ```-div-with-zero``` which does exactly what you have intended with your change. So basically instead of changing the ```Div``` class, you could add a ```DivWithZero``` class with your change and this new option.

I just made the ```-mask NaN``` change (wasn't possible yet) and could add also this ```-div-with-zero``` option.


Looks wrong.
`row` is not used?


convinced


Can you show us your config?


https://review.gerrithub.io/#/c/263173 looks great. I will close this one out. I have an open issue on a lack of contributor documentation. Patches welcome :).


we don't have this requirement anymore since we switched to PEP8 at some point


This and in fact every other G2D related patch doesn't do anything. The XU3 dts doesn't contain any of these compatible strings.


@wangchun Ah, thanks! Cool that the idiom does translate over.


Great! could you do this? Otherwise I can give it a go.


I see, alright


Actually, already got the problem. Fix to come – sorry about the disruption.


Please first do `cd submodules/externals/ffmpeg && git fetch --tags && cd - && git submodule update`.


This was a change from the IntelliJ formatter.  The formatted can align let and map forms, but doesn't do anything for a sequence of definitions.  (And I don't see how a general rule could be applied in this case.)


Doesn't this basically compute sum of first row and multiply it by number of rows?
Instead of actually computing the sum of all 'bytes'?


I feel like this should be exported, so you could use it e.g. in a struct in another package


It makes quite a difference, and yes it should be av_likely/av_unlikely in the end.


`_available`/`_consumed` is what we could use to make it more rational.


lgtm


Hang on, will be ready in just a moment.


I just used it in case there were any accessibility edge cases by removing the UI altogether. I can use `display: none` instead if you think that is better path?


-

- 435й3ц

[1.

> # #

> ](6ну6435463435)


I don't see how it simplifies things : if you put the three information into a VacationReply object, you can do the call to context.post easily


Resurrected code ^^
This should not be there.


I think you've pushed this by mistake ?


nice change bro


This is insane.  Open an issue to refactor upstream.


I would rely upon dependency-resolver to discover ```node-gyp```, it will provide ```HAVE_*``` and the appropriate path variable... Unless we have a very good reason not to...


Please put this in the same line while you are removing `a` and `b`


@makayi i have seen the changes. does it mean this student file will just be echoing messages


Hum ... It's `Build.scala`, not `ScalaJSPluginInternal.scala`, is it?


Actually, file a newcomer bug for it :P


Same - newcomer bug


perfect, thank you!


Since you're touching this code, please consider replacing ```@``` to ```$(Q)``` to make it consistent across the build system also compatible with the ```V=1``` build flag.


fastlane would be a lot happier if the version was `3.0` than `3`.


ditto with the version number


JRuby program to read data from HBase CLI and delete rowkey based on match parameter found.


確認しました。問題ないのでマージします。


поменял дату и время местами, файл выложил


@vuntz: Thanks... +1


that printer is ugly, but lgtm


Does this make it so that you need to reload a mod if you change map rules (while OpenRA is running), instead of just the map?


Most get requests tend to have data wrappers around the responses, right ?


comment about version being `3.0` rather than `3` should apply to all these Info.plists.


Perhaps the second condition can be removed altogether.


Out of interest does ansible complain if the path names are not in quotes?


Definitely not... what are you doing looking into this, btw? :joy:


looking at the ```nodejs_bindings``` rule I see it's safe guarded by ```ifneq ($(USE_NODEJS),)``` if you move the ```node-gyp``` to dependency-resolver you could add it as a ```depends``` for ```config USE_NODEJS``` and guard it all at once.


isn't this a use case for `@pytest.mark.parametrize`?


Indeed, a formal definition for the alignment seems difficult. And I'm not able to see anything in the [Clojure Style Guide](https://github.com/bbatsov/clojure-style-guide) about this particular case.
Not a strong opinion about it, but I'd tend to write it vertically aligned myself for clarity of reading. Surely not worth modifying it though.


Nah it handles it fine. The quotes are optional, I only got rid of them cause they were messing up my syntax highlighting. :smile:


trytry


Well, depends on the kind of perspective. 'PUT' is not the same as 'put' or 'pUt' but that implementation treats it as it is. Explain this please?


Please fix this version number to an existing SNAPSHOT.


I would add here `this.props.dataType`


@amakropoulos The ```-all``` option is really useful. But instead of a boolean variable, I would make ```-all``` an alias for ```-n 0``` or ```-n -1```. Basically, whenever the variable n is non-positive, all components should be extracted, i.e.,

```
// [...]
else if (OPTION("-all")) n = 0;
// [...]
if (n <= 0) n = nregions;
if (m + n > nregions) n = nregions - m;
```

could you make this change and submit a separate PR for only this modification? In general, you should create a branch for related changes. For example, "fix-smooth-image" for the other fix. And "end-extract-all-components-option" for this one. Makes it easier to accept those that are fine and reject/discuss others that still need some small changes.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15842](https://teamcity.mesosphere.io/viewLog.html?buildId=135731&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:05:10


Since we're reviewing all this, why are we keeping this rule inside root's Makefile ? can't we move it to tools/build/Makefile.rules(where all the other rules are kept)?


hi


haha this was by mistake :smile:  I was wondering why the test wasn't passing so decided to cross check the results after `split()`
Sure filing a new comer bug for it


Пробелы после каста


will file it in the same bug


Лишняя строка


Sure, can you create a new issue for that?


ДиКаприо одобряэ:)


how tied is this to the slack API?
I understand botkit has some logic to decide what slack API to call, based on the content of the messages.
for my use case I want to adapt to other platforms (wechat) so wondering where this would fit in - should I write a middleware for botkit, or do i need to modify core?


removed code will be in migration


I really hope that they split the API groups apart soon.  This is going to encourage bad behavior.

Looks like a straight rename, boring?


Totally agreed. I don't like this checks neither.
I think I like the idea of having `ord/min` and so on. I will play a little bit more with both solutions before deciding for one or the other.


Totally, agree. I was also thinking about the need to make this split over
the weekend.

On Sun, Feb 14, 2016 at 5:31 AM, Vincent Velociter <notifications@github.com
> wrote:

> Here I suggest you to split the code in tournamentCtrl in two controllers
> (tournamentList, and tournamentHome). It will be much simpler to manage
> the different parts of tournaments then.
>
> You'd have two routes:
>
> {
>    '/tournament': tournamentList,
>    '/tournament/:id': tournamentHome,
> }
>
> tournamentHomeCtrl will take the id with m.route.param('id'). this is
> idiomatic mithril code, as mithril was not designed to handle several
> screen per controller.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/freefal/lichobile/commit/c381ce2eb9cad3b1a806110d9e009400dfaee62f#commitcomment-16082750>
> .
>


Looks good. merging it in order to test in staging server


does it have to be atomic?


Actually - since it's a target - it should live inside tools/build/Makefile.targets, and I would suggest renaming it to nodejs-bindings(or even bindings-nodejs if we eventually have bindings to other things we have already an established "namespace") but my point here is the underscore, as far as I remember, we're not using underscore anywhere in target names...


in that line, the verb is not sent to server. It's just used internally, to be compared a list of HTTP verbs ( _METHODS_EXPECTING_BODY) that are stored upper-cased, that's why the verb is uppercased, to be compared however the case it has been received.
Anyway, cpython doesn't take github pull request, so you will have to fill a bug and use bugs.python.org bugtracker.


Не нравится мне когда соседствуют и if(smth) и showIf(smth). Мб подправить проверки чтоб более явно логика  видна была?


Nogen grund til at have en `docker-compose.yml` her _og_ i roden?


Unused


keep separate.

@liggitt, do we have a test for the different proxy mode configurations?


Use ${PV} instead of 1-3-3 and ${PN} instead of rdiff-backup.


Ditto here.