I should probably go into more details regarding consistency.

As I've said in an earlier comment, metadata before EPUB 3.1 was a bit all over the place. In an OPF, I could actually have a mix of metadata about the publication, about a specific resources and about a group of resources (since 3.0.1 thanks to the collection element).

With EPUB 3.1, we bring consistency and clarity regarding metadata:
- publication metadata in the OPF metadata element or linked from that element
- metadata about a group of resources in the collection element
- metadata about a specific resource in the resource itself

On top of that, EPUB BFF adds some extra clarity:
- since each rendition is now a collection, no more problem identifying metadata about a publication vs metadata about a rendition
- selecting a rendition can be entirely based on metadata describing the rendition instead of a different mechanism outside of the OPF

If we keep the JSON document separate from any given HTML document, IMO we keep that consistency and clarity.
Metadata about the publication and a group of resources are in the JSON manifest (clearly separated from one another), while metadata about each specific resource are in the resources themselves (ideally in JSON-LD for HTML?).
By embedding the publication/collection level metadata in a content document, I feel that we muddle things up.
I'd also like (and I know that this is far from being accepted by this group) EPUB BFF to be a good alternative for CBR/CBZ which means having strictly bitmaps as the content of the publication. I can't easily embed JSON in a JPG/PNG, but I can still include a link in HTTP headers.

For a single-resource publication, that's not a problem though, since the resource and the publication are pretty much the same thing.

From a client perspective, it's also far more consistent if we tell the client to always look for a link element, instead of supporting both link and embedded JSON.
When we point the client directly to the resource, we can also easily provide a hint (the media type) that it'll get a publication and not just HTML (see the example above).

Aside from OPDS clients, this extends to most mobile apps too. If my native app supports EPUB BFF, there's no way for me to force iOS/Android to look for links or an embedded JSON in an HTML page in their default browsers (Safari or Chrome). If we have a media type and/or an extension, and we point directly to that, it's a very different story: both OS/browsers allow native apps to declare that they support specific media types or extensions.
By following a link directly to an EPUB BFF, I'll either be redirected to a native app that supports it or a dialog will be displayed to ask me which app I'd like to use.

Even though we're talking about designing something that's friendly for browsers, the use case is bigger than that. We're really defining a format for publications that live on the Web and can be constantly updated. Such a format is not only useful for browsers or web apps, but also for distribution (OPDS or another protocol) and native reading apps.

While typing this comment, I just realized a new requirement for EPUB BFF: we absolutely need a "self" link.
If the JSON document is passed along by the browser to a native app, the reading app needs to know where the JSON document came from and how to get an always up-to-date copy of the manifest.


Yeah. I figured that one out by now :)


@jensens Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.transformchain/5//violations
```
ERROR: /home/jenkins/workspace/package-plone.transformchain/plone/transformchain/interfaces.py Imports are incorrectly sorted.
plone/transformchain/interfaces.py:0:1: I001 found unsorted imports
plone/transformchain/tests.py:104:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:137:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:143:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:174:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:205:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:236:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:238:1: C901 'TestTransformChain.test_transform_mixed' is too complex (13)
plone/transformchain/tests.py:307:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:338:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:340:1: C901 'TestTransformChain.test_abort_chain' is too complex (13)
plone/transformchain/tests.py:409:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:411:1: C901 'TestTransformChain.test_ordering' is too complex (13)
plone/transformchain/tests.py:480:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:482:1: C901 'TestTransformChain.test_request_marker' is too complex (13)
plone/transformchain/tests.py:551:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:560:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:562:1: C901 'TestTransformChain.test_published_marker' is too complex (13)
plone/transformchain/tests.py:631:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:640:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:721:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:739:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:757:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:773:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:790:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:806:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:813:13: T001 print statement found.
plone/transformchain/tests.py:829:18: D001 found failUnless( replace it with assertTrue
plone/transformchain/tests.py:857:14: D001 found assertEquals replace it with assertEqual
plone/transformchain/tests.py:878:14: D001 found assertEquals replace it with assertEqual
ERROR: /home/jenkins/workspace/package-plone.transformchain/plone/transformchain/transformer.py Imports are incorrectly sorted.
plone/transformchain/transformer.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.transformchain/plone/transformchain/zpublisher.py Imports are incorrectly sorted.
plone/transformchain/zpublisher.py:0:1: I001 found unsorted imports
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Я так предпочитаю передавать undefined — подсознательно мне так спокойней)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15853](https://teamcity.mesosphere.io/viewLog.html?buildId=135764&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:56


Waiting the implementation of this class...


good to merge


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15854](https://teamcity.mesosphere.io/viewLog.html?buildId=135765&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:41


it's fixed height. pull this PR to see problem


Nice! It's a bit of a tricky one and you nailed it.


@jensens Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.transformchain/6//violations
```
ERROR: /home/jenkins/workspace/package-plone.transformchain/plone/transformchain/interfaces.py Imports are incorrectly sorted.
plone/transformchain/interfaces.py:0:1: I001 found unsorted imports
plone/transformchain/tests.py:238:1: C901 'TestTransformChain.test_transform_mixed' is too complex (13)
plone/transformchain/tests.py:340:1: C901 'TestTransformChain.test_abort_chain' is too complex (13)
plone/transformchain/tests.py:411:1: C901 'TestTransformChain.test_ordering' is too complex (13)
plone/transformchain/tests.py:482:1: C901 'TestTransformChain.test_request_marker' is too complex (13)
plone/transformchain/tests.py:562:1: C901 'TestTransformChain.test_published_marker' is too complex (13)
plone/transformchain/tests.py:813:13: T001 print statement found.
plone/transformchain/tests.py:829:18: D001 found failUnless( replace it with assertTrue
ERROR: /home/jenkins/workspace/package-plone.transformchain/plone/transformchain/transformer.py Imports are incorrectly sorted.
plone/transformchain/transformer.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.transformchain/plone/transformchain/zpublisher.py Imports are incorrectly sorted.
plone/transformchain/zpublisher.py:0:1: I001 found unsorted imports
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@fsundermeyer that bit about REPOS_SKIP_CHECKS is actually not needed anymore in Cloud 6 -- there's no check during the install process. I'd just drop it.


@joshmoore What do you think about using a ExecutorService? Can be shut down on the Gateway disconnect, that should prevent forgotten threads lingering around somewhere.


カラムの情報も`init`の中でとってきた`response.data[1]`の中に全部入っていますよ。


Think we should continue the investigation in private: erouvier29@gmail.com


@jensens Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.transformchain/7//violations
```
plone/transformchain/tests.py:238:1: C901 'TestTransformChain.test_transform_mixed' is too complex (13)
plone/transformchain/tests.py:340:1: C901 'TestTransformChain.test_abort_chain' is too complex (13)
plone/transformchain/tests.py:411:1: C901 'TestTransformChain.test_ordering' is too complex (13)
plone/transformchain/tests.py:482:1: C901 'TestTransformChain.test_request_marker' is too complex (13)
plone/transformchain/tests.py:562:1: C901 'TestTransformChain.test_published_marker' is too complex (13)
plone/transformchain/tests.py:813:13: T001 print statement found.
plone/transformchain/tests.py:829:18: D001 found failUnless( replace it with assertTrue
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


You can have a single-document epub publication right now. There's no requirement that the nav doc be a separate document, only that you have nav/epub:type=toc inside the file somewhere. The only impact is that it imposes rules on any nav elements that have an epub:type attribute attached to them, but if you have a toc at the top of your content that would satisfy epub's requirements.

I think it would be very useful for broader adoption to not require zipping of multiple resources but just be able to distribute a single-file html document that could load in a reading system or in a browser as plain old html. It's maybe not critical right now, but as a future ideal for epub 4 it would be interesting. But starting off with a requirement for the json to live alone right now doesn't prevent future integration inside an html file if that use case does get pursued. It introduces other complexities, sure, but those are problems for another day.

I don't see that we're limiting future embedding by not starting with it, in less words.

And, no, I wasn't thinking content negotiation. That seems like a bad way to go, since a browser is going to prefer html, so it forces you to be inside the reading system to get the content you want (or we simplify little as you'll still find the json through an html page, which I don't think is all that bad a thing, either).

All I'm wondering is whether we want to go anywhere near the canonical locator stuff that pwp has been going round and round with, where some specific representation has to be returned if that url is accessed. If we dodge that bullet and instead rely on linking (i.e., point directly at the json file if you want the bff opened, or discover the link from the html), then it leaves the publisher to present whatever user experience they want through a default document for the directory (e.g., via .htaccess file) if someone enters the publication space that way.


Perhaps it is more useful for oscap developer, than the content author?


added .vim again


Also some exception handling on `segmentation.py`


The commit message (NeworkBase stuff) was not updated, but maybe you want to squash the patches before pushing them.


The `contentDescription` is what a screen reader will read out loud; you have made it be literally "previous_button", complete with an underscore in it, which isn't likely to sound great when read. Also, since this description is among the things that would be internationalized or otherwise subject to user-interface tailoring, I'd suggest using a string resource for it. That is, just as with the `text` label on a `Button`, I'd use `@string/previous_button` and then define in the strings.xml what the description is. (You could even just reuse the string resources you already had.)


I guess this check should be performed only if (!pdata->cyclic) then. I will fix it ASAP.


Is this relevant for standalone spoke at all? I don't see it used further. A leftover of previous approach?


What changes did you make to this file?


Correct me if I'm wrong, but isn't Math.Round method also produces double / floating point?

I mean, won't be the rounded PercentDPS also suffers from the kinky floating point behavior then?


TeamCity Civic Assembly :: Build all [Build 51](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1129&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **FAILURE**
Summary: Tests failed: 165 (1 new), passed: 7, ignored: 4 Build time: 00:06:37
### Failed tests
```
Blog categories tests: Should delete blog category new blog category 1455548367408: <no details avaliable>

Blog categories tests: Should not create new blog category if cancelled: <no details avaliable>

Blog categories tests: Should add new blog category: <no details avaliable>

Blog categories tests: Should not change blog category: <no details avaliable>

Blog categories tests: Should change blog category: <no details avaliable>

Blog categories tests: Should not delete blog category if cancel pressed: <no details avaliable>

Blogs tests: Should not create new blog if Cancel button pressed: <no details avaliable>

Blogs tests: Should add new blog: <no details avaliable>

Blogs tests: Should not change blog if Cancel button clicked: <no details avaliable>

Blogs tests: Should change blog: <no details avaliable>

Blogs tests: Should not delete blog if Cancel button was pressed: <no details avaliable>

##### there are 155 more failed tests, see build details
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15855](https://teamcity.mesosphere.io/viewLog.html?buildId=135766&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:48


First of all we should ask ourselves why there is:

```java
    public CallTarget accessMessage(Message unknown) {
      if (Message.valueOf("WRITE").getClass().isInstance(unknown)) {
        return Truffle.getRuntime().createCallTarget(com.oracle.truffle.sl.nodes.interop.SLForeignWriteNode.createRoot(com.oracle.truffle.sl.SLLanguage.class));
      }
      if (Message.valueOf("INVOKE").getClass().isInstance(unknown)) {
        return Truffle.getRuntime().createCallTarget(com.oracle.truffle.sl.nodes.interop.SLForeignInvokeNode.createRoot(com.oracle.truffle.sl.SLLanguage.class));
      }
      if (Message.valueOf("READ").getClass().isInstance(unknown)) {
        return Truffle.getRuntime().createCallTarget(com.oracle.truffle.sl.nodes.interop.SLForeignReadNode.createRoot(com.oracle.truffle.sl.SLLanguage.class));
      }
      throw UnsupportedMessageException.raise(unknown);
    }
```

when there already is
```java
    public CallTarget accessRead() {
      return com.oracle.truffle.api.Truffle.getRuntime().createCallTarget(com.oracle.truffle.sl.nodes.interop.SLForeignReadNode.createRoot(com.oracle.truffle.sl.SLLanguage.class));
    }
    public CallTarget accessWrite() {
      return com.oracle.truffle.api.Truffle.getRuntime().createCallTarget(com.oracle.truffle.sl.nodes.interop.SLForeignWriteNode.createRoot(com.oracle.truffle.sl.SLLanguage.class));
    }
    public CallTarget accessInvoke(int argumentsLength) {
      return com.oracle.truffle.api.Truffle.getRuntime().createCallTarget(com.oracle.truffle.sl.nodes.interop.SLForeignInvokeNode.createRoot(com.oracle.truffle.sl.SLLanguage.class));
    }
```
I guess the processor is just buggy and there should be no code in acceptMessage(...) in this case.


Anyway, like I said, solution is to bootstrap and build. Something like
> - cd $TRAVIS_BUILD_DIR/project/cmake/addons
- mkdir -p build
- cd build/
- cmake ../bootstrap -DCMAKE_BUILD_TYPE=Debug
- make -j3
- cd $TRAVIS_BUILD_DIR/
- mkdir build
- cmake -DADDONS_TO_BUILD=pvr.hdhomerun -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=../addons $TRAVIS_BUILD_DIR/project/cmake/addons
- make -j3


I'd mark the settings as changed (move this block) at the end of the function, so we don't do it for cases which return from the function without any changes applied.


That would probably be the more consistent approach. Then again if you look at manopt, not every manifold actually implements a pairmean method. My guess is that the concept simply doesn't make sense for certain geometries. In that case, manifolds should raise meaningful exceptions in the respective method.


Did you think about using `documentStore.entries().forEach((key,entry)->{ ...` to save the lookup?


Because I thought we don't want to modify the attributes of the resource, to avoid any side-effect of running through this code path.


Thanks Man, It's my honor.🙌


As I remember, the code with "data","error","code","message" was never published (you removed it the next day or so). So, this is not needed imho. Until we experience this problem.


:+1: Looks good. Thanks!


I got most of the tests to green. Except those:

```
org.jumpmind.symmetric.service.impl.JdbcDataLoaderServiceTest > test05SkippingResentBatch
org.junit.ComparisonFailure: decimal_value. sqlite expected:<10.1[0]> but was:<10.1[]>
```
and
```
org.jumpmind.symmetric.service.impl.JdbcRouterServiceTest > testRoutingScenarios
java.lang.AssertionError: expected:<17> but was:<11>
```
and
```
org.jumpmind.symmetric.test.SimpleIntegrationTest > test02RegisterClientWithRoot
java.lang.AssertionError: expected:<0> but was:<1>
at org.jumpmind.symmetric.test.AbstractIntegrationTest.checkForFailedTriggers(AbstractIntegrationTest.java:179)
```

where the first one I can't believe that this is an error and the other ones are randomly failing

And I can't find a correlation between the failing tests and this change.
what do you think?


a


This closes issue #9


> so what are you proposing @expez ?

Proposed changes are offered inline.  Just ignore the part about the variables I misunderstood.


Looks great.

I wasn't familiar with vector::swap.  Passing other by copy was a sneaky elegant way of doing the assignment:

```
MidiEventList& MidiEventList::operator=(MidiEventList other) {
    list.swap(other.list);
    return *this;
 }
```


This comment probably needs to change. (I haven't gotten through all of the commits, so you may have already fixed it.)


There are


Unneeded returns


Cache the get_turf result


visible_message for observers


Don't split the lines here, it's misleading!


@jensens Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.transformchain/8//violations
```
plone/transformchain/tests.py:238:1: C901 'TestTransformChain.test_transform_mixed' is too complex (13)
plone/transformchain/tests.py:340:1: C901 'TestTransformChain.test_abort_chain' is too complex (13)
plone/transformchain/tests.py:411:1: C901 'TestTransformChain.test_ordering' is too complex (13)
plone/transformchain/tests.py:482:1: C901 'TestTransformChain.test_request_marker' is too complex (13)
plone/transformchain/tests.py:562:1: C901 'TestTransformChain.test_published_marker' is too complex (13)
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Same here, misleading.


Again


Тест


you probably need to put `show=False` in these calls that precede the end of the scripts in order to get the old behavior (all windows up at once)


No space before/after brackets (ROS coding style).


Dan, why did you remove the IF(NOT MSVC) block? IIRC those were there to support mingw.


I think std::complex<{double,float}> is more useful than int and long.


we want **to** save


ah missed those, no worries. so you are not worried about the user setting these anymore then, or? ;P


Oh yeah, of course.


Ok, thanks, this is a quick fix, but the cleaner thing is to equiv A.QuestionMark with a (Maybe InteractionID) and then use `fromMaybe __IMPOSSIBLE__` to retrieve it.


Boolean vector and trajectory vector must be the same size


@chriswmackey this might be cleaner: ```basePlaneNormal = rc.Geometry.Vector3d(thermPolygons[0].normalVector)```


Seems reasonable.  We should add the policy.


There were extensive discussions on talk, REST infrastructure did not support DELETE /patient/{patient_uuid}/allergy to delete all allergies for a patient. The changes in this file allows this route. The line endings of the file is corrupt hence when you edit the file it shows the whole file as changed. My changes start at the end of the old file, line 168.


Not sure if you saw my last comment Matt, but overall I agree with what you've just said, especially:

> If we dodge that bullet and instead rely on linking (i.e., point directly at the json file if you want the bff opened, or discover the link from the html), then it leaves the publisher to present whatever user experience they want

Also as I've said before, I'm not against embedding for single-resource (different from single-content) EPUB publications, and adopting link as the preferred mechanism for now won't limit us in the future to support embedding if we need to.
Just keep in mind that some of the problems that I've stated earlier will still apply to single-resource publications (How do I know that I'm going to get a publication instead of just an HTML resource? How do I declare that a native app can support that resource better than the default browser?).

Do you have any specific URI where I could read into more details about the canonical locator stuff? I'm not sure if I understand correctly why any of that (or a well-know location for that matter) is needed.


I am wondering if we could be more clever here and set the flag only if settings have actually changed, something similar we do with settings_changed callback in on_edit_connection. But doing check like this, it would be probably simpler (given we restart the thread in apply) to dump the settings when entering the spoke and check if they changed in apply.


Can you fix the line endings?


vtkPolyData represents the mesh to be cut


Since that change, all my jobs are failing due to EOF error (I have node_exporter jobs, blackbox_exporter jobs, snmp_exporter jobs). Metrics are properly collected though. This is just messing the 'up' status.

Do I need to change some config or anything else ?


hello dc42 i think i found out what the problem is i check it right now :)  is about i using a mega board the timer settings are a bit different thats on the uno


passe > pass (check everywhere)


ttttt


It's fixed in selinux-policy-3.13.1-158.6.fc23.


What was the purpose of this commit? Just tidying up?

I'm getting a strange error now from jetty:

> 2016-02-15 15:53:38.239:WARN:/:qtp646153587-17: Exception while dispatching incoming RPC call
> com.google.gwt.user.client.rpc.SerializationException: Type 'ch.systemsx.sybit.crkwebui.shared.model.ApplicationSettings' was not assignable to 'com.google.gwt.user.client.rpc.IsSerializable' and did not have a custom field serializer.For security purposes, this type will not be serialized.: instance = `ch.systemsx.sybit.crkwebui.shared.model.ApplicationSettings@39462da7`

This seems to be due to the model classes no longer compiling in a GWT context, so they don't inherit from the IsSerializable class. It seems likely the bug happened here.

The error is a bit tricky to reproduce, probably due to maven caching issues getting the model & wui projects out of sync. Be sure to do mvn clean after changes.


updated node


str[0]=='<' && str[len-1]=='>'


not tested, but the code seems good


Done.


adding RFC 7500 quote to address #26


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15856](https://teamcity.mesosphere.io/viewLog.html?buildId=135769&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:32


Agreed. I did not include complex because their is an error in Tensor for complex values that prevents it from compiling. At the time I was shooting for working rather than a complete implementation.


Je ne suis pas spécialement doué d'un point de vue esthétique alors si vous avez de meilleures idées concernant les couleurs / les hovers , dites le moi sachant que ce que j'ai mis là je l'améliorerai forcément plus tard


Remove this (+ Ubuntu + PCL) and point to the official [README.md](https://github.com/ros-industrial-consortium/bezier/blob/indigo-devel/README.md).
Let's only have 1 source of information, it's easier to maintain.


h2_priority.vtc result
https://gist.github.com/flano-yuki/cf1612e1cea9e104b611


Missing `\n`s in your `format/2`s


I have tried, but according to web research it seems that windows line endings have found its way into GitHub. It affects several files, so in fact when you clone the module and create a branch it immediately shows some files as modified. The best way to fix this is to move the file into git with the correct file endings.


The space after `luajit` doesn't belong there. Also, please indent the other arguments below.


Same here, indent and remove spaces.


Seems fine, but the `ResourceNamingPolicies` class really needs to be renamed to something different, since it is very confusing with regards to `ResourceNamingPolicy`. Also make sure both classes are javadoc commented properly.


h2_priority2.vtc result log
https://gist.github.com/flano-yuki/335081fd189f4c00c192


I'm planning a fix to edit these `"200"`s that are now actually `200`s (str -> int)


> ah missed those, no worries. so you are not worried about the user setting these anymore then, or? ;P

No, I didn't check the CIDER source so I just assumed they were `defcustom`s instead of `defvar`s.


Don't know. We're abusing `A.QuestionMark` here so it feels better not to legitimise the abuse by adding a `Maybe`.


This change is for a related project where we study merge scenarios. There, we have `base-left-right` triplets and, based on these, we want to analyze the release ranges `base-left` and `base-right` using Codeface with minimal effort. I.e., we want to use a single configuration file and, consequently, one project inside the database. Currently, Codeface does not support this in any way. That's why we wrote this patch.

This patch is **not** intended to be merged into the master branch.


tetetete


You got me, I thought for sure it would be an int. Should be fixed now.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15857](https://teamcity.mesosphere.io/viewLog.html?buildId=135770&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:08:38


辅导费


bloog


Answered through email, as it is easier


That's the MySQL version, not the PHP version.


I believe one of the guidelines of RPM packaging is that packages from group core are exempt from being listed on package dependencies:

```
$ dnf groupinfo core | grep procps-ng
```

But I'd have to find the guideline to confirm it.


You can also use this syntax: `characterDictionary[@"favorite drink"]`


actually, i think this change was merged in.


Commit text includes "stderr and stdout are not FILE pointers as per standards" but I can see no changes that reflect anything along those lines.


I'm aware, Travis is simply using too-old distros  :V


That fix itself caused some more serious issue! Luckily, after spending couple of hours googling, I finally came to a good solution. coldnew/pangu-spacing#10


testing


Probably


This isn't good. In fact, it is a problem with the test. It will pass or fail depending of the environment (if blas is available or not)... That isn't good. I'm not sure what to do. Is it possible to accept both?


TeamCity libpalaso :: palaso-precise64-lfmerge Continuous [Build 2.6.1.f26105e9c5574e2a63f5c30a16fe6b34b452c703](http://build.palaso.org/viewLog.html?buildId=69171&buildTypeId=Libpalaso_PalasoPrecise64lfmergeContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3377, ignored: 124 Build time: 00:05:14


very long line


`$reqliblist` can be empty (`undef`) and `dpkg-query -S` doesn't like that.


@mikepurvis This doesn't work with a debian, because `env_run` is installed in `/opt/ros/indigo/lib/jackal_description` and `$(find jackal_desciption)` returns `/opt/ros/indigo/share/jackal_description`, which doesn't have any `scripts` folder at all.


The "first backup" of save (or mod) is added this f - backups are half documented and implemented here and there but a useful feature to revamp for 308


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15858](https://teamcity.mesosphere.io/viewLog.html?buildId=135771&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:08:08


bloog


Does language allows to assign default values in struct declarations?


any reason for this commit? I'd rather make sure all is clean before reusing the header struct.


No, they are inline functions.
https://github.com/raspberrypi/userland/commit/e0ecdb98a59a70048b64f8a5196d423680fbdc7e back in December fixed up all the errors of inline functions not matching prototypes.
If you're still aware of any warnings being thrown up, please report them.


@vocrsz


Salve ma come faccio a far partire questa patch?
ho copiato ed incollato il testo in un file nominandolo webiopi_raspberry_pi_2_cpu_support.patch e ho lanciato il comando come descritto nella guida, ma mi dice che non è un file o directory.
Mi potete consigliare?
Grazie
saluti


> I've tried this on 2 comps with 60fps on one and 70fps (interpolated) on the other, MP works well.

This sounds good. Thank you very much for testing!

Say, did the rendering feel smoother compared to the 35fps mode? Which mode felt better on your screen? And did the rendering begin to stutter or lag at any time?

> A suggestion: please include Permanent Mouselook option in the in-game Tactical options, currentl one is forced to use Setup to enable that.

You don't have to use the setup tool, this setting is "hidden" under Mouse Sensitivity options.

> Choco 2.2.1 has bugged endianness calculation that's already been fixed in latest Choco and Crispy builds

But this only affected network games across two systems with different endianess, or not?


Ну кто же с файловой системой из контроллеров работает-то? Захочешь ты поменять хранение файлов с локального на облачное - будешь переписывать контроллеры?


I am finally getting around to looking at old pull requests.  Thanks for this fix which someone else just reported, and I eventually tracked it down.  It was causing erratic behavior, mostly when calling class destructors.


Water pump?


Awesome, so this is done :P


Seems good to me.  Should also be ready for merging.


Missing ']'


hi


Have a look here: https://www.w3.org/TR/2015/WD-pwp-20151126/#identification

In a nutshell, the pwp has a canonical url that all instances reference as it move from online to offline state (and back and forth). There has been a fair bit of discussion on the dpub mailing list[1] and during the locator group's telecons[2] about what that means (the full publication, a manifest document, ??).

[1] https://lists.w3.org/Archives/Public/public-digipub-ig/2016Jan/0106.html
[2] https://www.w3.org/dpub/IG/wiki/Task_Forces/locators#Task_force_meeting_minutes


Yes, this is what's done with e.g. Stiefel.dist(). No-one has yet derived
the geodesic distance on the Stiefel (according to P. Absil who I asked
about this a few months ago), so this is not implemented in manopt. The
pymanopt method raises a NotImplementedError. This should be done for other
methods which don't yet exist.

On 15 February 2016 at 15:03, Niklas Koep <notifications@github.com> wrote:

> That would probably be the more consistent approach. Then again if you
> look at manopt, not every manifold actually implements a pairmean method.
> My guess is that the concept simply doesn't make sense for certain
> geometries. In that case, manifolds should raise meaningful exceptions in
> the respective method.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/j-towns/pymanopt/commit/b0856730c8fd1364e9c129b6782cb36ce5d9c342#commitcomment-16097279>
> .
>


Кстати, наверное бы лучше подошло название MapItem вместо CountryItem. Правка на своё усмотрение.


"Copyright (c) 2012, Broadcom Europe Ltd
All rights reserved."
on several files. I'm sure they'd be delighted to have written them, but is that really true?


TeamCity libpalaso :: palaso-precise64-lfmerge Continuous [Build 2.6.2.f26105e9c5574e2a63f5c30a16fe6b34b452c703](http://build.palaso.org/viewLog.html?buildId=69173&buildTypeId=Libpalaso_PalasoPrecise64lfmergeContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3377, ignored: 124 Build time: 00:04:43


This will never match since `name` has been lowercased on [line 44](https://github.com/hchiorean/modeshape/commit/96639d63ea99ed9c10ad6957284f87e32314ca1b#diff-32d52f6d3678bbeb75c402c0bdfa6646R44). Fix by using "cassandra" literal (all lower case).


The first loop is only checking the pseudo header.
This loop not use hdr struct.


Может и так. В ядре используются названия Country*. Оставил в том же стиле.


no idea ;-)


*self recursive type* perhaps?


Может лучше в MapManager сделать метод вроде GetFilledMap?


aye. That was going to be my original way of doing it. I'm still working
out the edge cases for it (there are many edge cases). I might be able to
not worry about the edge cases initially and add a `use_parts` option (for
folks like you who can debug in the cases where it may not work). Is that a
possible, viable solution?

On Mon, Feb 15, 2016 at 9:36 AM, Robin Cura <notifications@github.com>
wrote:

> I have (yet another :D) question : when straightening a request, the
> resulting object contains a url (obj[[1]]$url) but also a decomposed url (
> obj1[[1]]$url_parts).
> This later is very practical, for example for a quick url edit without
> having to string-edit/regexp the whole url.
>
> But when editing the url_parts, it's not taken into account when doing a
> make_req(), the base $url is used. Would it be possible to rebuild the
> url from url_parts instead ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hrbrmstr/curlconverter/commit/f9475d9ba849e0e3eb0687cc0a4e8dfe51a8771b#commitcomment-16096676>
> .
>


Maybe best is to do 3 different function here:
- mysql : just test 1049: all other can be returned
- pgsql : test 7 and 7 with empty DB : all other can be returned (with dbname)
- mssql : don't know : leave like it


Actually the whole thing better use the same style as in https://github.com/neovim/neovim/pull/3871/files#diff-8b6a4062f8e1671e23354c7e5570c0d0.


Okay, aquesta es la versio 1.0


Missing ']'


Rename to `ImageResourceQuota` specifically, looking at others.


Licence and copyright on a couple of files.


Не очень понял. Переименовать?


When I added organisation store I didn't add anything here


Is it possible to do some LookAHead here before triggering ExportNameId?
As far as i can see, the problem occured when using the UnitName in front of the function?
Imagine:
Foo.Bar.MyFunction
Not just will the above handle it incorrectly but using it is kind of cumbersome. I need to check subsequent calls to ExportsNameID to analyze if its part of a unitname or the actual Exportname. Isn't it possible to first go through all Identifiers(seperated by the dots) and treat each identifier except for the last as part of a Unitname?


В одно выражение через тернарный оператор не хочешь переделать?


`savoir!` -> `savoir !`


~~a~~


`passion !` -> `passion !` (c'est mieu les ` ` car c'est un espace insécable qui évitera d'avoir un saut de ligne avant la ponctuation.


déjà corrigé voir nouveau commit!


+SHM_A is like SHM_ALL which is like STL_ALL.


Можно. Это тоже старый код, не рефакторил тут ещё


Why https://github.com/snoyberg/http-client/commit/0e1a52115c168e65dcbe393ebe097bf6365e79c7 commit wasn't reverted?


theano/sandbox/cuda/blas.py need change for prepare_node


reack


long line


LGTM, :+1:


this issue will be solved in my new plan on table structure, thanks :)


I'm not sure why it should be. Can you clarify what you're asking here?


I think that we should add caption as first element of _current_ widget, not child.


OK pour  ! je l'ai mis devant les mots avant ! du paragraphe, par contre pas dans les titres ou le title. Tu  me conseille de le mettre quand même?


No, those enums are not consistent. Use mmalil_error_to_mmal() to convert between them.
Repeat with the other identical fixes below.


ack


small writing mistake: verison->version


Is that a good removal? Being able to assert the correct image resource id was a very valuable feature.


Не, я имею в виду не здесь статический метод сделать, а в MapManager. Ну и с другим названием.


wow I didn't know that's possible that can simplify the dbus skipping too!


@targos Reading [the migration guide](http://eslint.org/docs/user-guide/migrating-to-2.0.0#language-options) and other ESLint 2 documentation, I don't get the impression that they plan to re-add pick-and-choose `ecmaFeatures` to the linter again.


Noooo don't commit directly to master :cry:


Ок
> On Feb 15, 2016, at 6:32 PM, Alexander Marchuk <notifications@github.com> wrote:
>
> Можно. Это тоже старый код, не рефакторил тут ещё
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/trashkalmar/omim/commit/14affa8cdaafcabf0753b234eb335276aea05647#commitcomment-16098030>.
>


move the import at the top. Also do the import like this:

import six.moves.cPickle as pickle


Not nice, but these two enums are the same so it is valid.


can you file a bug?


@HaxeFlixel/owners anything to add / change?


don't we have some ready to use function generator for this?


@Kai,
as you documented [here](https://www.eclipse.org/smarthome/documentation/development/bindings/xml-reference.html#xml-structure-for-configuration-descriptions), I used <br> tags inner 'CDATA', but it has no effect.
Should I cancel the tags or will they work later?
![jdbc_config](https://cloud.githubusercontent.com/assets/5707426/13052857/76d4f5d4-d401-11e5-95bd-14d351f7c7e0.JPG)


>> Do you have any specific URI where I could read into more details about the canonical locator stuff? I'm not sure if I understand correctly why any of that (or a well-know location for that matter) is needed.
>
> Have a look here: https://www.w3.org/TR/2015/WD-pwp-20151126/#identification

See also the [Locators page on dpub-pwp-loc](https://github.com/w3c/dpub-pwp-loc/blob/gh-pages/locators.md), which is the most up-to-date info of what is currently being discussed.


ack, ouch


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15859](https://teamcity.mesosphere.io/viewLog.html?buildId=135775&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:08


Мне кажется, так дешевле и сильно меньше кода.


it's maxHeight, it's a typo mistake ;(
I'll fix it


ack


@Teteros
I merged it accidentally so it isnt arnabs fault.


yeah but in the same guide there is this part:


No, VCOS_STATUS != MMAL_STATUS_T.

```VCOS_STATUS_T status;```


TODO: find a better way
  - Dynamically resolve all middlewares and promisify them
  - Make the request being processed by express beforehand, and handle the response object


Not that I know of. I took this from GitCommitBear.
Couldnt find anything easier


Il faut le mettre dans tout ce qui est dans le body HTML. Mais éviter de le
faire dans les meta, parce que les parsers genre aperçu G+ ou Facebook ne
transforment pas souvent ces encodages.

On Mon, Feb 15, 2016 at 4:34 PM Agnès CREPET <notifications@github.com>
wrote:

> OK pour  ! je l'ai mis devant les mots avant ! du paragraphe, par contre
> pas dans les titres ou le title. Tu me conseille de le mettre quand même?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Ninja-Squad/ninja-squad.github.com/commit/79f42718f1f02150809497834c0444ef0c635e94#commitcomment-16098082>
> .
>


You need to find the full path to the pickle file. You don't know what is the current directory. Here is code for this:
```
        testfile_dir = os.path.dirname(os.path.realpath(__file__))
        fname = 'CudaNdarray.pkl'

        with open(os.path.join(testfile_dir, fname), 'rb') as fp:

```


I was willing to go either way, but I think it would be best to follow the names of the extensions, given that there are other extensions with similar issues (Mssql vs. SQLSRV, clearly you want to connect to an MS SQL Server database, but the Mssql extension was removed in PHP 7; ibase for Firebird would be similar to Maria or Percona). Also, there are still occasional questions about whether Maria is supported.

One of the things I like about the way this is all structured, though, is that you could create a base class for a Maria connection configuration which extends CodeIgniter\Config\Database\Connection\MySQLi and be done with it (since the $adapter property would be inherited from the MySQLi class, it would still use the MySQLi adapter, connection, etc.). If you actually wanted to add special configuration options it would become a little more complicated, but you could still inherit most of the functionality from the MySQLi classes.


Если аннотации не прописывать явно в конструкторе тут - предупредит идея о несоответствиях разве?


Sure, having a default (safe) mode and a `use_parts` option would imho be the best :)


Closes https://github.com/TrinityCore/TrinityCore/issues/14446.


I have to check if the image links break as soon as I merge the examples branch into master.
As soon as I find some free time I will update the master branch.


(Grr can't add comments outside the scope of the patch)

Line 127:
```return status==VCOS_SUCCESS ? MMAL_SUCCESS : MMAL_ERROR;```
(or something similar)


Settled to `OriginResourceQuota` on IRC.


Вроде бы приходится дублировать аннотации везде


The default ecmaVersion is supposed to be 5 according to the doc. I am surprised that it works without that option set.


```if ( status != VCOS_SUCCESS)```


Ship it!


Why was this added?


```rb
require "benchmark/ips"

def fast(path)
  path.split('/').include?(":mondo")
end

def slow(path)
  !path.split('/').detect { |segment| segment == ":mondo" }.nil?
end

Benchmark.ips do |x|
  x.report("fast code description") { fast('ciao/:mondo/infame') }
  x.report("slow code description") { slow('ciao/:mondo/infame') }
  x.compare!
end
```

```
Calculating -------------------------------------
fast code description
                        72.629k i/100ms
slow code description
                        53.367k i/100ms
-------------------------------------------------
fast code description
                          1.450M (± 8.4%) i/s -      7.263M
slow code description
                        836.794k (±10.7%) i/s -      4.163M

Comparison:
fast code description:  1449555.9 i/s
slow code description:   836793.7 i/s - 1.73x slower

```


but we're holding the lock, so checktx will block, no?


IIUC, this won't work for people that are running Docker on Linux, since that address is only used by the Docker Machine on OS X and Windows. You might need to pass the IP address of the database machine on the build command via `-D` (though you could default it to the above address).

(You can have the Maven build to use the Jolokia Maven plugin to start a Docker container (and optionally create a new custom image), run the tests, and then stop the Docker container. If you do this, the Jolokia Maven plugin defines properties with the IP address of the running container, and that would mean you don't have to pass the command line parameter. See the [Debezium code](https://github.com/debezium/debezium/blob/master/debezium-connector-mysql/pom.xml#L75) for an example of using this plugin. However, this doesn't really mirror how the rest of the databases are assumed to exist elsewhere.


Да, наверное нужно


I see. Well there's no good solution for that, as you've said it's better to let the publisher decide when it's best to link to HTML or to the JSON manifest directly.

Add a third URI and handle content negotiation, since that URI would identify something different than a resource or the manifest anyway.


Nie ma sensu wywoływać tę metodę bez słów kluczowych – więc nie powinno być pustej wartości domyślnej.


ok, cool


shouldn't this be something like

'meson8b_odroidc1': ['meson8b-odroidc1', 'amlogic']

rather than

'meson8b_odroidc1': ['meson8b-odroidc1', 'exynos'] ?


I'd need to check on this one. VCSM != VMCS.
That looks like a typo that just happens to match up with a defined value. There should be no need for a cast when it is a defined value being passed in.


Testy automatyczne?


113567901_Inconsistent-code-and-document-in-luminance-calculations-#4776 (lgu1234) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Дак столько же получится, просто здесь какой-то метод "заполнить", который по строке возвращает готовый CountryItem на мой взгляд смотрится инородно. А вот
CountryItem item = MapManager.GetFilledItem(id)
вполне понятно. НО не блокер, решай сам.


IMHO takie zmienne nic nie wnoszą: nazwa metody mówi mi, że zwrócony zostanie `page content`, więc wystarczy `return page.read().decode(encoding)`

podobnie w reszcie miejsc


Ah, sorry, didn't see the extra loop. I would be better to put everything in one loop, instead of duplicating.


I've read https://hackage.haskell.org/package/http-conduit-2.1.7.2/docs/Network-HTTP-Conduit.html#g:12 and saw comment added in this commit. And then I've read the source https://github.com/snoyberg/http-client/blame/master/http-client/Network/HTTP/Client/Core.hs#L100 and saw that commit mentioned in this comment was reverted.
So, comment added in this commit is outdated.


Looks dubious.
Moving the place and condition on which VCOS_INLINE_... gets defined is probably OK, but why are we losing the VCOS_INLINE_DECL totally on several functions?


How do you plan to use alignak backend? Is it already implemented?


What was changed in PHP 7? https://3v4l.org/lKJcM


still not there

TASK: [2-common | install yum from Fedora 23 for arm!!!] **********************
failed: [127.0.0.1] => {"changed": true, "cmd": "rpm -ivh https://kojipkgs.fedoraproject.org//packages/yum/3.4.3/506.fc23/noarch/yum-3.4.3-506.fc23.noarch.rpm", "delta": "0:00:04.901058", "end": "2016-02-15 15:40:26.596930", "rc": 1, "start": "2016-02-15 15:40:21.695872", "warnings": ["Consider using yum module rather than running rpm"]}
stderr:         package yum-3.4.3-506.fc23.noarch is already installed
stdout: Retrieving https://kojipkgs.fedoraproject.org//packages/yum/3.4.3/506.fc23/noarch/yum-3.4.3-506.fc23.noarch.rpm
Preparing...                          ########################################


Closes #70.


heeeej


Please look in line 360. the identifiers are already there.


When I try bake a MSSQL 2008 View return this error.

Fatal error: Class Cake\Database\Schema\SqlserverSchema contains 2 abstract meth
ods and must therefore be declared abstract or implement the remaining methods (
Cake\Database\Schema\BaseSchema::addConstraintSql, Cake\Database\Schema\BaseSche
ma::dropConstraintSql) in D:\WWW\htdocs\mygex\vendor\cakephp\cakephp\src\Databas
e\Schema\SqlserverSchema.php on line 40


Hmm variable? Is it runtime only type or can be stored in plugins too?


This patch solves a bug caused by the code `events.resize(0)` on line 2082, at the end of MidiFile::clear_no_deallocate().  However, I needed to resolve the bug in a different way: the MidiFile class always contains at least one track into which data can be added.  The `events.resize(0)` line was causing problems because it set the track count to zero.  You noticed that the function was creating a new track, then resizing to 0, so you wisely remove the track creating code.  But in this case the resizing to 0 code was incorrect.

I wanted MidiFile::clear_no_deallocate() to match the behavior of MidiFile::clear().  The clear function deallocates all MIDI events currently being stored in all tracks, and then creates a single track with no contents:

```
void MidiFile::clear(void) {
   int length = getNumTracks();
   for (int i=0; i<length; i++) {
      delete events[i];
      events[i] = NULL;
   }
   events.resize(1);
   events[0] = new MidiEventList;
   timemapvalid=0;
   timemap.clear();
}
```

Here is the preferred MidiFile::clear_no_deallocate() to match MidiFile::clear():

```
void MidiFile::clear_no_deallocate(void) {
   for (int i=0; i<getTrackCount(); i++) {
      events[i]->detach();
      delete events[i];
      events[i] = NULL;
   }
   events.resize(1);
   events[0] = new MidiEventList;
   timemapvalid=0;
   timemap.clear();
}
```


Setting `es6: true` in `env` handles setting `ecmaVersion` in `parserOptions` for you. See https://github.com/eslint/eslint/blob/5aa474833b161b2d5eb684b911d1f7745fa2a696/conf/environments.js#L99-L103 (which @silverwind posted when he and I had a similar conversation earlier).


Ну как же, создание объектов в JNI удовольствие ещё то. Хотя вцелом согласен с кейсом. Посмотрю.


I think we need an exception case for team and blog post updates.  TBD with how we integrate with prose.


what about the data ownership?
if we don't have a pointer how do we point to data that the dataowner has e.g. in AllocateImage?


@MagicMan2016 What's the benefit of marking two of the parameters as "final"


zahardkodowane 3500


Could you make both the `UVISOR_BOX_CONFIG_CTX` and `UVISOR_BOX_CONFIG_ACL` a 1-line definition? You probably did it in 2 for consistency with the ones above but there's no need to imho (and I prefer shorter files :smile:).


For the future: I'd write this as a compact if:


Apparently I published this already.. so moving to 0.0.26 (0.0.25 is the same as 0.0.24)


@popcornmix one for you.
Just removing the assert seems wrong as it will have been added for a reason. Is this that we've had an update that wasn't for us, so calling dispmanx_client.update_callback sounds wrong.
Change for
```
if ( dispmanx_client.pending_update_handle == handle)
   dispmanx_client.update_callback(handle, dispmanx_client.update_callback_param);
```
?


how do we know that this information is at the first index?


Just return, I don't see any advantage in creating this variable.


Shouldn't this be `this.ReplaceAnimation` instead of `UITableViewRowAnimation.Fade`?


@GlacierW : I meant the use of TCG target along with manipulating interpreter.


The data will always be owned by the HashImage as an internal container. My point was that this external raw data ownership is only useful for continuous memory images to allow interfacing with other libraries. For this special purpose image class, I would at least at the moment not support such external data ownership.


The reset handler should  ensure that the C execution environment is in place before executing C code emitted by a compiler.

A  compiler is free to perform idiom recognition and replace arbitrary code with library calls.  Hence the BSS zero loop above may be replaced with a library call (either to a compiler support library like libgcc, or to a standard C library implementation).


Implement DBSCAN without R* tree.


Could you move this before the local file inclusions? We usually include global header files first and then local ones (but it's just a preference).


Do you even need AllocateImage?


lgtm.  This looks pretty boring, am I just missing why its interesting?


не, я не про нативный метод. Враппер в java, с кодом 1 в 1 как здесь в методе.


I just wonder, why the systemd prefix?


Not really, it is not a given that checking a boolean would be appreciably faster than that, and even if so it would likely be by a far far smaller amount than you think. I don't think you fully appreciate just how much a decent compiler can optimize out when it is allowed to inline code, which is the case for template classes such as these.

These are the sorts of changes one should not make blindly, assuming it will improve performance, without benchmarking the code to know if it actually does.


What is this forwarded port good for except for local testing? Why was it not there before?

Could this have a conflict when running in a CI-Environment?


Stupid question: `update-bash` has three occurrences of `chdir`.  But there is no `chdir` on my machine, either as a bash builtin or as an executable.  Should those be `cd` instead?


Yes, I need to get rid of that API.


lgtm.  keep this separate.


Oh, silly me! Sorry :)


see comment about forwarded ports below.


Jakbyś pisał testy to wiedziałbyś, że biblioteka robiąca żądanie http powinna być zależnością.

W teście mógłbyś oczywiście robić „prawidzwe” żądania do YT, ale po pierwsze byłoby to bardzo wolne, a po drugie testy wybuchałyby Ci w czasie, gdy padł sam YT, dając false-positive.


It looks good, but I don't know how to do that. So I should read related code for a while.


Аа. Тогда лучше здесь оставить. MapManager задумывался исключительно как прослойка с JNI. А по владению метод больше тяготит к CountryItem, ИМХО.


ack


if we don't support this ownership probably not


Add to `MissingCommands` and open a followup issue.


no, just calling out that the NewKeepAliveListener no longer will create a listener for you.  Squashing


This line probably needs a comment on its own, right? It does not return the box ID for the current, but rather of the caller box.


Not a stupid question! It's defined in `bin/brew`: https://github.com/Homebrew/homebrew/blob/c9aee547bc70a3bef7f81f67b56c1cf6b820b99f/bin/brew#L19-L21


think this would be better

dnf install https://kojipkgs.fedoraproject.org//packages/yum/3.4.3/506.fc23/noarch/yum-3.4.3-506.fc23.noarch.rpm

which probably ansible can do


lgtm, boring.


as this block was replaced with something else, can we delete it instead of commenting it out?


draft-origin? So when we publish topics are we pushing to draft and live at the same time? To me it makes more sense to send them to the live one as we don't talk about drafts elsewhere.. _shurg_


O co chodzi? Co to za znaczek?


Anyway, because this API is not using frequency, in most of cases this API is unused, so, I don't wanna do junk work even it's imaginary.


What's the justification for this?


> Add to MissingCommands and open a followup issue.

After moving this and linking the issue, lgtm


Fixed up in #1117


Is `contentStream` ever closed?


peut être pourrait on mettre une autre couleur que ce bleu ?


Could you move this brace on the previous line? See [here](https://developer.mbed.org/teams/SDK-Development/wiki/mbed-sdk-coding-style#rules) for reference.


`newstr = oldstr.replace("M", "")`


why was this changed to "upgrade"?


Would it be `alternate=true`?


stomp needs something similar as well... it has some sort of thread per connection.

if we used this there it would be great.

We can merge this now, and reuse on stomp


Thank you, base-left and base-right ranges are still expected to have disjoint sets of commits, but overlapping time stamps? I'm asking because I want to know whether it's one of the cases I have planed to support.


Should replace this hard-coded string with `ChatbotActionRegister.GetChatBotActionUsage<OptOut>()`. Same with the opt-out class.


> yes, it's one day. changed to be multiplied out.

I've clearly done this job too long :)


dead code - can it be deleted, or does it need to be re-enabled?


@vera-l  х.з. http://stackoverflow.com/questions/18419428/what-is-the-minimum-valid-json
делать не будем


Looks good.


@matryer Yeah


Because it was there before, but I agree to remove it.


@copenhas probably doesn't hurt to keep, but we don't use the html side of phoenix so it may not matter either unless it's breaking something.

I don't think it effects the JSON serializers.


Здесь же чистый метод по созданию экземпляра объекта, почему считаешь что здесь лучше?
Это не принципиально в любом случае, ок.


The mean value of 86 variables from the original experiment in which each variable was the mean or standard deviation of one of 561 features measured.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15860](https://teamcity.mesosphere.io/viewLog.html?buildId=135778&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:53


this looks broken, does this even pass the ruby parser?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15861](https://teamcity.mesosphere.io/viewLog.html?buildId=135780&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:11


This whole statement is a bit vague.  I'm not sure why I'm telling JaResource which repo to use in controllers, or, particularly, what that means.  Maybe we can reword this to something like

> JaResource can be configured to execute queries on a given repo.  While not required, we encourage doing so to preserve clarity.


added, opened, squashed


なるほど、使い回したほうがいいですね。ありがとうございます。


Co jeśli słowem kluczowym będzie `"?dupa+++hehe=lol"`?

Jak składasz URLa to powinieneś poprawnie escape'ować wartości.


I reckon this is more of a view layer layer. Maybe a helper called #topic_view_path or #topic_view_url? Or.. #topic_frontend_url to make it clearer it's not the GET /topics/34 path in this backend app?


If the call stack is empty it means that no secure gateway happened yet, which means that box 0 called me. I think this function should return 0 in this case.

Note: The API does not tell you whether you are in a secure gateway or not. Code running in box 0 that calls other code in box 0, will result in having a "caller ID" of "0", even if no gateway occurred. A secure box should not use this API to assess whether it's running as a result of a gateway. (Of course box 0 might be the caller ID even when the gateway **did** occur). @meriac Do you agree?


You can just join the array, e.g.

```ruby
sh((XCODEBUILD_DEBUG_COMMAND + ['test']).join(' '))
```


Problem confirmed. However, this change _removes_ the report of an EOF error, so it's weird that it now shows up. Will talk to @fabxc


@anroark I think the current date picker is not intuitive. it doesnt separate the year into months like one would expect. It instead list each week up the 52nd week. I found this hard to use. Mabye we could pick a different one?


Wygląda jak spacja, w parsowanym htmlu siedzi w takiej postaci - escaped unicode.


Nigdzie używasz parametru `encoding` to go wywal. Jak będziesz potrzebował, to go dorzucisz.


I believe such an approach is a mistake, because it causes issues like the one I found. What happens is that when you include the global header and then some other headers under it, the global header also adds definitions before the other header. So, if `vmpu.h` requires `stdint.h`, you often don't get a compile error and can easily forget to add the include for `stdint.h` as some other file had added it for you. Later, when the header (e.g. `vmpu.h`) is used in a different context, a compile error might show up (as in this case) due to missing dependencies (e.g. `stdint.h` missing). Requiring the global includes to be at the end helps to ensure that all global includes a file needs are defined in the file itself; it helps headers in particular to be more portable between compilation units.


EPUB and PWP are different ends of the spectrum, too. A pwp is about taking a specific web site offline, whereas bff is how to put a publication up anywhere on the web.

I don't think we need to get hung up on their issues, only make sure that there aren't significant conflicts. Right now I don't see any, as the json/linking approach skirts defining what has to be presented at a given canonical url.


You should use 8 bit instructions: `strbt`.


Nie jestem pewien, ale chyba `self` też tu można pominąć?


Good points. Connection name works, then. Excited to see this how this progresses. I'll agree with one of your commit messages that it all feels a little too complex, but you're making valid points here. And I was going to wait until things were further along to actually dive too deep in and say anything. :)


staket staket staket


You should use 8 bit instructions: `ldrbt`.


mvp functionality. light and dark themes added.


> Now kramdown's GitHub-flavored Markdown seems to support it and there would be no barrier to go back to the kramdown.

Apparently, "strikethrough" syntax is not supported (yet) on kramdown.


Then let's say that in the docs: `* `alternate=true` to mark a line as an alternate to the previous one for when the Option key is pressed in the dropdown`


Bro project much!


@tfausak and @hadronzoo The default timeout is now 300s.  Arion probably won't be able to do the connection drain in that timeframe, but larger containers like the old feedback one should.


Nice, btw. I keep thinking there must be a better way to document this but I haven't found a good way yet.


OK. the problem was not introduced by this commit, but later.


The 16 bit functions should change as well: `strht`, `ldrht`. Could you create a separate PR request that fixes those 2 functions and introduces the 2 new ones for 8 bits?


Nice! I've been working on a series using ``hyp0f1`` and Buchholz polynomials; here it is as a gist:

https://gist.github.com/person142/ba5432e6c828aa39b8db

I'm sending it that way since using it will require rebasing on something that includes gh-5777 (ok, also because it's still kind of janky...). It works very well in some places and surprisingly poorly in others. I suspect that part of the problem is ``hyp01f`` itself, and I'm hoping that gh-5828 will do something to improve it.

It seems that Bessel functions always come to bite us--saw they were causing a loss of precision in your spherical Bessel functions too.


I like this too.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15863](https://teamcity.mesosphere.io/viewLog.html?buildId=135782&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:46


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15862](https://teamcity.mesosphere.io/viewLog.html?buildId=135781&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:02


Thank you very much! It does make sense now.

I'll update my blog post asap :)

You're the best! :dancer:


I can confirm that this has now been resolved (i.e. build is green again)


@gleber We should probably update the documentation on how to override things as well.


@yuyichao can you check whether this piece code looks correct to you? If possible, can you also point me to the right direction on how to test !COPY_STACK?


Glad this helped explain the mystery :-)
Thanks for updating the blog, you rock!


Did you mean to comment line 27?


Depending on how the stack is set up, one might run into permission problems here.  Might consider adding "--output $OUTPUT_DIR" or something, so not to write into $OBS_TEST_DIR?

Same for line 120


Coś mi wcześniej ta metoda usunięcia nie chciała działać, potem jeszcze raz to przebadam.


Let's keep this for now. Macro selection needs its own PR but it is low priority now.


enums are "int", which means we don't necessarily know the size (yes, it usually defaults to 32-bit, but surprisingly there are systems where it doesn't). If we are going to play bit-packing games, then we have to ensure we know exactly how many bits are involved in the type vs the flag fields.


Maybe just do `dead_time = config['HeartBeatTimeOut']` directly here so that it can be dynamically updated easily? It also avoids a global variable.


Capital 'c' plus dot at the end.


What is this attack?


`div style:color`


Two spaces are intentional? My `db_dump` prepends one space only.


Could you move this brace on the previous line? See [here](https://developer.mbed.org/teams/SDK-Development/wiki/mbed-sdk-coding-style#rules) for reference.


Move brace to previous line.


typo `pol`→`pool`


I love micro-optimization.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15866](https://teamcity.mesosphere.io/viewLog.html?buildId=135785&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:42


We should probably add the systemd/ceph-osd@.service.in to the EXTRA_DIST.


I originally did this, but it appears that the compiler is smart enough to see the type of the data and transform the instruction to the correct one.


The image is wrong: http://i.imgur.com/lF8Qdpk.png


This is not needed.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15865](https://teamcity.mesosphere.io/viewLog.html?buildId=135784&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:54


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15864](https://teamcity.mesosphere.io/viewLog.html?buildId=135783&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:13


A forward declaration will do.


TeamCity Chorus :: chorus-precise64-lfmerge Continuous [Build 2.5.1.07308e7fd4f1bf73bb35001e0f43370669790dfd](http://build.palaso.org/viewLog.html?buildId=69175&buildTypeId=ChorusPrecise64lfmergeCont) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:16:01


I originally made a commit to fix this, too, but after looking at the disassembly, left it as is because it appeared to work fine as is.


or even poll :wink:


Ah, ok, I guess we can do that in some other commit.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15867](https://teamcity.mesosphere.io/viewLog.html?buildId=135789&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:02:34


Can do


how can you poll without a workspace and get list of committers for all commit between local HEAD and remote branch tip ? `git ls-remote` does not provide this level of detail


I added comments to this function implementation in a previous review. Are they still available somewhere? (They should be in your emails anyway).


Obsługa błędów? Co jeśli YT walnie np error 500?


I don't mind the use of `UnsupportedOperationException`, but I'd like there to be a message for the exception. It makes debugging a lot easier.


Thanks.  That's the one place I forgot to include in my grepping!


these moved into `c.ProxyConfig.KubeProxyConfiguration.BindAddress`


subscriber of mission event/status publisher


pleas leave it in


Good question.


Please add this also to the actual generated file (no need to regenerate it, just add this line) and commit that too.


they're doing the same thing we are now, with a runtime config containing a serializable config struct... most of the missing bits are nested under `KubeProxyConfiguration` now


Would need a description of what was being done to provoke the assert.
It is there because the author (seems to be @pelwell) of the code believes that this shouldn't happen and subsequent code is unlikely to behave correctly, so it shouldn't be removed without understanding.


Adding a custom message at each place where the exception is thrown should lead to better messages than a default message in a subclass. For example 'This branch of code should be never reached, because we already know that this value should be in this range'.


Superb!


publish as you can :) i'm waiting to update :)


The problem in this case is that we are looking for a specific byte inside the integer, and so you do care about the endianness. Of course, we could define a value to be equal to 256 and then just bitmask using it, but that still wouldn't fully solve the problem.

Frankly, I'm wondering if we aren't pursuing a bad path here as this bit-packing notion is complex and fragile (all someone has to do is set the type equal to a value instead of using the macro and it will break).

The fact is that the 1.1 series, while released, isn't being used anywhere. So we have the opportunity to change the pmix_info_t object without worrying about backward compatibility at this time. Perhaps we should take advantage of that situation and simply add an int flags field to the struct?


Zdecyduj się czy chcesz przekazywać parser jako argument czy mieć go jako pole – nie ma sensu udostępniać dwoma kanałami, jeśli i tak korzystasz tylko z jednego. Niepotrzebne ifowanie.


I did not like writing objects.* for everything. It was causing lots of line wrapping issues. I can change back if needed.


resolves #3


we do not


Oops, I may have misinterpreted the original code; help me understand it better. Currently while running CosyDVR, a notification beep occurs on a fragment split and all other sound will be muted (e.g. music playing in the background from another app will be muted and interrupted by CosyDVR's beep).

I may be modifying the wrong section of code in this patch. What I want to do is allow sounds from other apps to continue playing, and in addition play the CosyDVR beep during fragment splits.


113567901_Inconsistent-code-and-document-in-luminance-calculations-#4776 (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (983 of 983 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-28.54%25-green.svg)


I should have implemented at least a subset of your feedback. I didn't implement the string length reading stuff, since I'm not sure it'd be worth implementing. We can require callers to always provide a big enough buffer (potential memory waste) or do a strlen on the box name (potential cpu time and energy waste). We could calculate and store the length up front (box enumeration time) to save from spending the energy on strlen for each name getting call, but that also has a memory overhead. It's the classic space-time tradeoff, and I'm not familiar enough with our design space to make a choice.


Also set it to false on ``cluster.stop()``


113567901_Inconsistent-code-and-document-in-luminance-calculations-#4776 (lgu1234) - x86_64-MacOS-10.9-clang: OK (2079 of 2079 tests passed, 4 test warnings)

 * 3 tests had: AUD diffs.
 * 1 test had: ERR diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Эм, нету такого хелпера. Везде конструктор извлекается руками.


Mine too. Well I'll update the test to 1 space...


ah, nm... you're still using the config bits but they changed to untyped


Thanks


Cała ta metoda sprowadza się do `self._html_parser.find(id = element_id)` – w tej sytuacji IMHO w ogóle zbędna.


Agreed. I'm just noting that they're currently all blank.


I think I am misunderstanding this automatic feature. I have 10 FullHD images attached to 10 inputs. I click on the automatic option and press play. All what happens is the node stays on the first input. Is it suppose to do that or is suppose to cycle through each input for the duration of the timeline?


you should not really use `System.currentTimeMillis()`  for much other than logging, as this timer can jump due to fixing the time with `ntpdate` or the like.   Should really use `System.nanoTime`.

That said - worst that will happen is a failed login which should be fixed by the next login...


well, quite :smiley:


Do you mean this:

http://c2lang.org/site/language/variables/#initialization

On Mon, Feb 15, 2016 at 4:25 PM, procedural <notifications@github.com>
wrote:

> Does language allows to assign default values in struct declarations?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/c2lang/c2compiler/commit/12c368f9a88af0e09507324d73d79a344532eafa#commitcomment-16097823>
> .
>


Since you want this comment to be godoc, use `//` instead of the current solution.


We can add it. In the future if we support adding that attribute then the server will add it manually to the _names list and then it will get persisted. I'll go ahead and make that change. Good catch.


Raz masz `{'key' : 'val'}` innym razem `{'key':'val'}` – zdecyduj się na spójną składnię.


In markdown, you're not supposed to use <br>, but empty lines


Yes, this looks weird. Imagine I did comment out line 27 in the commit that temporarily disables this SVC call and replaces it with uvisor_box_name.


Your code is much better than mine here :-).  I will think about this more, as there are a few complications to fix in your submission:

(1) you iterate through key.tick++ and key.tick-- values until finding the next higher and lower tick value by using bsearch.  This will cause problems in the general case, since the distance to the next/previous tick value could be large.  Suppose the input tick value is 100, and the next tick value in the timemap is 2000000, then you would be running bsearch 1999900 times.  So it is probably better to iterate once over all tick values, storing the next lowest and highest values with which to interpolate.

(2) your returned time value is always half-way between the two adjacent timestamps.  For example if tick 100 was at time 2 seconds and tick 200 was at 3 seconds, if you try to get the time for tick 199, it would return 2.5 seconds instead of 2.99 seconds.


Zbędne spacje wokól `repr`


Same here, short if.


s/uvisor_box_name_self/uvisor_box_name

But this temporary disabling should all go away before this API is ready to merge.


Should there be more explanation here about whether you're on the EU or US stack? Simply check the url you log in at?


Nice contribution! :)
You could move the creation of ToastContent into the Helper, and ToastContent could be internal. Just a thought.


Point taken! Yes, I'll start using this approach for future files.


А всё, нашёл. Не в той ветке был


Wyciągnąłeś do tego metodę `_find_element_by_class()` – albo z niej korzystaj (bo powiedzmy, że nie chcesz wszędzie „pamiętać” jak się szuka po klasie) albo wywal – bo w sumie jak się czyta kod to jasne jest co się dzieje.


About me


I forgot to add to the commit comment that this also completes the addition of the desired content to the job details view.


Why do you need to refresh the state of this variable? You're invoking this operation before above if, already.


Which changes in particular? There are a couple of things that are automatic. No matter what when you add an item to the names list then _names will be updated. Also whenever in a session then changes made to the object will be reflected in the session. Are there any other changes you had in mind?


It may be worth adding to our style or contributor's guides, come to think of it.


Love 'em!


@whadar how? it doesn't work for me.


What happens when a name is locked while there is only one node in the cluster, but before it can be unlocked at least one node joins the cluster? Is that possible? IIUC, the `ClusteringService` does not get re-instantiated, so this instance will have to deal with it. Does it already handle this case?


Merge pull request #104 from lnug/its-not-feb
only show jan talks


My client needs the .project file in my local repo to work, so I'm adding it to .gitignore


That sounds very likely.

David Crocker, Escher Technologies Ltd.
http://www.eschertech.com
Tel. +44 (0)20 8144 3265 or +44 (0)7977 211486

On 15/02/2016 15:13, EinPunkt222 wrote:
>
> hello dc42 i think i found out what the problem is i check it right
> now :) is about i using a mega board the timer settings are a bit
> different thats on the uno
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dc42/arduino/commit/e4337de50dd9faa17381b2d06c95c48f5fdbe74e#commitcomment-16097491>.
>


I would still spell it out explicitly, as it reduces the error surface. If the code is mistakenly changed or copy-pasted (or, say, we `ldr`/`str` to `addr` instead of `data`) the compiler would issue a different instruction. It is really important for us to get the instruction right both for security and safety (i.e. alignment; some peripherals do not allow {8, 16, 32} access).


That is odd. I'll do some more research to see if there is a way to change that. If not, it may be best to revert to Date and Time text fields.


Found it... fix incoming.


Pierwszy i ostatni element są zawsze jednoznakowymi stringami trzymającymi znak końca linii.


ultimo


I take "there is no default action for deeplinks in the Unity SDK" to mean that urls are not handled automatically like in the iOS and Android SDKs – maybe an explicit note on this? Also, should we give some examples as to what deeplinks can be used for, or is that outside of the scope here? e.g. send custom events as deeplinks in IAM, or to gift items.


> defining ioctl() isn't needed for 90% of usecases

Well, all my uses need it (flash needs sync, sd card needs init, ramfs needs sec_count).  So that's 100% needing ioctl in my book.

> does it work like that?

No.  Not defining ioctl means that you want to use the old protocol with sync() and count() methods.


no to taki komentarz daj, bo nie jest jasne o co biega


Why is it a problem if `InfoRequestEvents` get created at the same time?


I think we should rephrase the subject's sentence to the next one: `Please, set ^WebTerminal(""HomeNamespace"") global equal to the namespace WebTerminal was installed to before uninstalling.`
But this also should never be printed :)


Yep, just switch it. I use localhost by default, accidentally went with that.


Czemu w ogóle długość musi być większa niż te 3500? Co tu chcesz de facto zwalidować?


This is awesome, thank you Jenny!

I want to make one tangential observation that is immaterial here, but my have future consequences... In general, I don't think

`expect_equal(url, build_url(parse_url(url)))`

will always work, or should be guaranteed to work.  The problem could arise when you use an url like:

`url <- "http://www.example.com?a=1&b=2"`

You could `build(parse(url))` on that and get:

`http://www.example.com?b=2&a=1`

which is a legitimate reconstruction, but won't test equal as a string.

Again, that won't be the case here because there is only 1 parameter to reconstruct, and you may already know this anyway, but I thought I'd state it here in case it triggers something in the future.

My thought is, for completeness, that it should compare `parse(url)` to `parse(build(parse(url)))`, which would require a module in R that knows how to correctly compare arbitrary objects deeply and smartly for equivalence.  It's not a question I saw a clean answer to (at least for Python, where I was trying to find an analog) after a brief initial web searcy.

Thanks again for your work,
Matt


Did you happen to see my comment about this on the (already-closed) original issue I raised?

https://github.com/MindscapeHQ/raygun4py/issues/38#issuecomment-181692836

In short, I don't think this try block does what you think it does.


113567901_Inconsistent-code-and-document-in-luminance-calculations-#4776 (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2117 of 2117 tests passed, 7 test warnings)

 * 6 tests had: AUD diffs.
 * 1 test had: ERR diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I would first want to make sure we enforce it ourselves. I think also https://github.com/ARMmbed/uvisor-lib/issues/24 is (loosely) related to this.


Don't forget to remove your debug code


It's not really clear to me what's being demonstrated by this test.


Но там же и не нужны атрибуты, просто селектор для текста не будет работать с явно заданными цветами?


I think this was correct the first time.


Here too.


Why not PR this?


Неа, не работал на 4.х. Поэтому пришлось делать кодом.


Hmm, it didn't recognize you, most likely because you don't have that address registered with github...


То есть альтернатива - добавить все селекторы в темы. Но можно и так, ок.


By returning here, you're skipping the tail of this function, and create a leak.


same here


The cache gets updated. But I see now that the `img` definition can be moved here entirely.


Yup, works for me. I'd allow someone to also inject their own to make it more integration-friendly though.


number, is not an explicit variable name.


it actually says "Tests are being run" in later commit


`feedback_config = makeConfig('Feedback', 'Settings for the Feedback plugin. Cannot be changed ruding the interactive Ganga session.')
`
ruding -> during


Shouldn't `mta_ids` be a flat list anyway?


Not sure what's going on here.


Should it better to be
```
set role = ..GetDBRole(dbdir)
set cspProperties("MatchRoles")=":%DB_CACHESYS" _ $case($get(role)'="", 1: ":"_role, :"")
```
instead of
```
set cspProperties("MatchRoles")=":%DB_CACHESYS:" _ ..GetDBRole(dbdir)
```
in case role returns an empty string?


I just cross-compiled from my amd64 system in a schroot. The /usr/include/python is okay:
 dpkg -S /usr/include/python3.4m/Python.h
 libpython3.4-dev:arm64: /usr/include/python3.4m/Python.h

However, I did have a typo and had to change -I${top_srcdir}/include/lib to -I${top_srcdir}/lib/include. The result builds and runs for me.


utACK


Humm, not sure this is a good name.
maybe multicast_internal


No need to use `err_` regular `err` should work without any problems here.


Good call. I think this will work. @kprovance. Can you verify? We should add to all our extensions.  :)


I guess IGMP_PROTOCOL_NUMBER is equal to 0x02, so this line should not be in the if


a `NamingException` can be thrown for reasons other than a timeout here...

Whilst I don't like parsing exceptions for Strings (as it is brittle) - in this case the String is not subject to localization or the ilk - `LDAP response read timed out`


At any given time, it will take the first valid input.
It is very useful if you split a video file into shots using several FrameRange nodes, process each shot with different effects, and then want to join them without taking the risk of shifting time (AppendClip may shift time if you make a mistake in one of the frame ranges).
We use this to fix the alignment of stereoscopic movies, with a transform that differs on each shot.


We use camel case for the config options in our enrichments...


cambio uno


I tried but `go vet` complains about shadowing an `err` variable.


I'll fix in develop


Would you be able to add tests for this?


Trying to understand the world of HaxeFlixel testing by looking at the official repos...

How come the flixel tests are run here--aren't they already [run by the flixel repo's own travis file](https://github.com/HaxeFlixel/flixel/blob/dev/.travis.yml#L43)?

Also, what happened to "run filxel-tools testdemos"?  That sounds like it would have been actually testing the demos rather than flixel itself...


А я оказывается вернул управление настройкой обратно в Java


Whatever this was doesn't exist any more..


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15868](https://teamcity.mesosphere.io/viewLog.html?buildId=135790&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:10:09


I did it! Thanks for your comment.


This line is the same, as the one bellow,
so this should not be in this condition


This is an old info string anyway so it's not caused by this PR. Fixing in `develop` is fine.


What is the current way of switching on `!COPY_STACK`? It seems the `USE_COPY_STACK` option has been removed by commit b238ac2815a46cc021aa8e2a109f1ba292df69c3. Thanks!


Maybe it would be cleaner to add `preprocess_urls` hook to the test_runner somewhere around `job._handle_urls`, but I just briefly looked at that part.


Zamiast robić dodatkową zmienną i pętlę, masz w Pythonie kilka opcji:

* generator:
```
def _filter_only_valid_results(self, elements):
    for element in elements:
        if (len(repr(element)) > 3500):
            yeld element
```

* list comprehension

```
def _filter_only_valid_results(self, elements):
    return [element for element in elements if len(repr(element)) > 3500]
```

* filtr

```
def _filter_only_valid_results(self, elements):
    return filter(lambda element: len(repr(element)) > 3500)
```

---

Powyższe może nie działać, bo dawno nie pisałem w Pythonie, więc nie pamiętam dokładnej składni, ale ideę powinieneś czaić ;)


This bug was mine, but this if is actually useless.


Test how blame works. @snoowball


`json_last_error()` reported 0 in PHP <7, in 7.0 it returns 4 (`JSON_ERROR_SYNTAX`).


They are, but each repository needs to run the full test suite. Travis builds on commits, and a commit to any repo can break something (well, technically not the flixel core unit tests, but whether the demos compile or not is dependant on flixel, flixel-addons, flixel-demos and flixel-ui).

`testdemos` is now `buildprojects` and called from within the [`RunTravis` neko script](https://github.com/HaxeFlixel/flixel/blob/dev/tests/RunTravis.hx).


![qq 20160216003137](https://cloud.githubusercontent.com/assets/1846356/13054398/a5c8c1ac-d444-11e5-9650-ab4b0b337e73.png)
ZZ 菊苣，这里的 tag 需要弄成和上面的 tag 统一的样式，这里如果用白底的就用 `.rin-tag` 吧
宽度不要弄成变长的，对于每个宽度需要在浏览器上计算最优化的布局方式使得总体宽度最小~


Renamed.


this is an abuse of TimeUnit2 which should be handling the conversion rather than you doing it yourself `TimeUnit2.MILLISECONDS.toSeconds(System.currentTimeMillis() - start)` - or just use the JDK5 classes `TimeUnit.MILLISECONDS.toSeconds(System.currentTimeMillis() - start)`


Yes, it is very important to get it right. I was concerned enough about this that I went to look at the disassembly. When everything appeared correct, I decided to match the existing coding style.

Your proposal sounds reasonable. I prefer being explicit, especially for important code. I'll make an update.


`handle` not declared.


Compacted.


Fixed.


I missed the functional change here. It would have been nice to have had a test.


@yuyuyu101 seems the test does not compile.


Good catch :)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15869](https://teamcity.mesosphere.io/viewLog.html?buildId=135794&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:09:16


Using `//` now.


No właśnie długość nie ma żadnego znaczenia, taki tylko zbieg okoliczności, że blok htmla reprezentujący kanał jest (w większości przypadków) krótszy od kodu reprezentującego film. Przykład w kodzie tej strony: https://www.youtube.com/results?search_query=lana+del+rey

Muszę zmienić to w taki sposób, że walidowane będzie czy dany tag zawiera klasę "yt-lockup-channel" czy "yt-lockup-video".


Why put them in req?


Shortened.


Thanks, much better now. Additionally I would make clear in the Github pages section that:

This grunt task is designed to be running on [Travis CI](https://travis-ci.org/) by default.
Users who want to deploy the generated files manually will have to set the environment variables `GH_TOKEN` as well as `TRAVIS_REPO_SLUG` on their own system.


hello 我只是想试一下


btw, do we want to push an RC3 or jump straight to release?


![qq 20160216003433](https://cloud.githubusercontent.com/assets/1846356/13054479/0b5ea6da-d445-11e5-97d9-80cb1c38aaa7.png)
另外这里下面的 tag 不应该是文本，需要把 `input` 换成 `div(editable)` 然后里面使用统一的 tag 样式~
最后向列表发送一个搜索的 query，这个 query 请参考 wiki 里的 Torrent API 中的搜索部分~


@Vincent-Michael could you check the copyright header of this file ?


Wouldn't this mean that if you didn't provide a secret in the URL, it would authorise you?


It may be more tightly related than you think.

I'm not afraid of adding it to the guide. It at least documents the standards we want to live up to for new code.


Dlaczego tak miałoby być?


better than leaving it in for all of us :)


I'd prefer calendar_tree, but don't care much. :)


Regarding Vector vs []: I'm using [] because Polynomial is a newtype for []. If we used Vector, we'd still have to convert each chunk to a list to make the Polynomial, so we gain no efficiency. Furthermore, we'd *lose* efficiency in one of CT or RT because one of them would have to convert to a different Vector type, and *then* convert to a list.


jscs now has https://github.com/jscs-dev/node-jscs/blob/2.x/CHANGELOG.md#disallowspacesinsidetemplatestringplaceholders which they've also added to the airbnb preset, we should link that here also


Yeah, I didn't care about them in the PRs, but now both are in clean state :)


How come you decided not to also create a parse_calendar method?


You can skip adding the target `gen` by replacing `gen: src/kz_mime.erl.src` with `src/kz_mime.erl: src/kz_mime.erl.src`. ie: skip `$(MAKE) gen`


Tutaj użyłbym generatora: dwie linijki mniej ;)


Zbędne spacje


Почему-то постоянно слетает эта настройка


I think this code may be incorrect. The client version when using MySQLi with mysqlnd, which is supposed to be the default configuration in PHP 5.4+, is 5.0.12 in PHP7 and [5.0.7 in PHP 5.3.2+](http://php.net/manual/en/mysqlnd.plugin.obtaining.php). The behavior described is based on the server version, not the client version, so this should probably be checking `$this->mysqli->server_info`. If that is the case, this should also be updated in CI3's mysqli_driver.


> On 15 Feb 2016, at 16:36, Romain Deltour <notifications@github.com> wrote:
>
> Do you have any specific URI where I could read into more details about the canonical locator stuff? I'm not sure if I understand correctly why any of that (or a well-know location for that matter) is needed.
>
> Have a look here: https://www.w3.org/TR/2015/WD-pwp-20151126/#identification <https://www.w3.org/TR/2015/WD-pwp-20151126/#identification>
> See also the Locators page on dpub-pwp-loc <https://github.com/w3c/dpub-pwp-loc/blob/gh-pages/locators.md>, which is the most up-to-date info of what is currently being discussed.
>
>

More specifically:

https://github.com/w3c/dpub-pwp-loc/blob/gh-pages/locators.md <https://github.com/w3c/dpub-pwp-loc/blob/gh-pages/locators.md>
https://github.com/w3c/dpub-pwp-loc/blob/gh-pages/drafts/ivans-musings.md <https://github.com/w3c/dpub-pwp-loc/blob/gh-pages/drafts/ivans-musings.md>

Ivan

> —
> Reply to this email directly or view it on GitHub <https://github.com/dauwhe/epub31-bff/commit/cafee9bdf4d58e7eba12872354ea813464709ff4#commitcomment-16098129>.
>

----
Ivan Herman
Bankrashof 108
1183NW Amstelveen, The Netherlands
http://www.ivan-herman.net


yes good change!


@macjones743 is this actually your commit? It's showing up as me who pushed it, but this could be just because you were working on the lab machine.


Thank you


This rule is no needed, due to it's allowed using "auth_use_nsswitch(lttng_sessiond_t)".


Love this diff!


This is no longer needed


good items name


redundant parameter "role"


>But this only affected network games across two systems with different
endianess, or not?

Both of my systems have the same endianness, so in my case it should
probably work with Choco 2.2.1.

>Say, did the rendering feel smoother compared to the 35fps mode? Which
mode felt better on your screen? And did the rendering begin to stutter or
lag at any time?

Yes, 60fps feels very smooth :) and on 70fps interpolation generally works
well, the only visible artifact of the interpolation is that the projected
crosshair can be seen "dragged".


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15870](https://teamcity.mesosphere.io/viewLog.html?buildId=135795&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 226 Build time: 00:04:04


added PR 597 to use dnf instead of shell and rpm


Yes, it was a bug. It's already fixed in a local branch but I haven't pushed yet.


develop (mjwitte) - x86_64-MacOS-10.9-clang: OK (1533 of 1533 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


We should really promisify imagemin.


Use https://github.com/sindresorhus/pify so we can use promises everywhere ;)


By that argument we should use variable1, variable2, ... as the variable names in our code! :laughing: What's wrong with calling a spade a spade, or a nodemcu repo `nodemcu`?


Yes. This is my commit. It was a slight change from the lab machine. It's weird that it showed up as you when it asked for my username and password.. Hmmm

-------- Original message --------

From: Alexander Brown <notifications@github.com>

Date: 2/15/2016  11:40  (GMT-05:00)

To: Alexanderallenbrown/MotionBase <MotionBase@noreply.github.com>

Cc: macjones743 <jonesdm@lafayette.edu>

Subject: Re: [MotionBase] Fixed position of short leg 4 in hii.m (3252127)

@macjones743 is this actually your commit? It's showing up as me who pushed it, but this could be just because you were working on the lab machine.

---
Reply to this email directly or view it on GitHub:
https://github.com/Alexanderallenbrown/MotionBase/commit/325212732b6089a4191c67d34ee4ae738237dcb0#commitcomment-16099787


Change text Ssoon to Soon


Same here. Just return the promise.


Makes sense! PR welcome!


Relative imports should be last.


Maybe you missed this commit: https://github.com/concrete5/concrete5/commit/41ec8ac518255223c2db5aec61179f47c6181a4a


use lowercase `content-type`


No, it looks wrong. As a start, you need to fix up all the reference in the gcstack linked list to point to the new stack instead of the old stack. More fundamentally, you need to fix up all the reference to the old stack on the old stack to point to the new stack and I don't think that's doable.

For example you can have, (in c pseudo-code)

```
void f(int*);
void g(int a)
{
    f(&a);
}
```

Now there's a pointer in the register or on the stack that point to the stack copy of `a` and you just can't find where it is.


Très bien !


What is DG?


Should your dotted border be on this element or it's parent?


To test it, you can just disable the `COPY_STACK` in `src/options.h` and observe breakage.


This actually fixes #9. Wow


Your portfolio profile? :D


    Correction en cours de compilation ...
Avec en bonus une remarque sur la matrice de l'application transposée et
une partie du groupe conforme.

bonne soirée
Laurent

Le 14/02/2016 18:13, Lilian Besson a écrit :
> Typo, le "par" aurait aussi du être supprimé.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/LaurentClaessens/mazhe/commit/4c22a0c5886b184c9b7ab5beb134984df0bf175f#commitcomment-16084268
>


Although that line was most recently changed by me, its current content:
```
    handle = (DISPMANX_UPDATE_HANDLE_T)dispmanx_client.notify_buffer[1];
    if (handle) {
        // This is the response to an update submit
        // Decrement the use count - the corresponding "use" is in vc_dispmanx_update_submit.
        vchi_service_release(dispmanx_client.notify_handle[0]);
        if (dispmanx_client.update_callback ) {
           vcos_assert( dispmanx_client.pending_update_handle == handle);

```
is semantically equivalent to the initial commit:
```
    if(dispmanx_client.update_callback ) {
        vcos_assert( dispmanx_client.pending_update_handle == (DISPMANX_UPDATE_HANDLE_T) dispmanx_client.notify_buffer[1]);
```
at least as far as the assertion is concerned (except for the extra test for a non-zero handle).

Perhaps the weston guys weren't cancelling the callback, or were changing the callback while there was still an update outstanding?


This is allowed for all domains on Fedora. This can be removed.


Revamped exceptions in 80b3c4. Improvement?


Ah, I did not know that flixel-tools changes could break flixel, but I believe you there.  This makes sense, I'm glad things are set up this way.  Many thanks for the explanation and the link, I will go explore more :)


shouldn't it fail for any non-zero exit code?


Only when functionCall.args.size() > 0
MajorType majorType =  functionCall.args.get(0).getMajorType();
can be initialized.


I wish we could find a way to handle cleaning the output that does not reproduce https://issues.scala-lang.org/browse/SI-9335


AFAIK it's still needed in this repository.

https://docs.travis-ci.com/user/workers/container-based-infrastructure/#Routing-your-build-to-container-based-infrastructure:

> For repos we recognize before 2015-01-01, linux builds are sent to our standard infrastructure.


No, I mean:

```c
type Point struct {
  int x = 5;
  const char* y = "Default String";
}
```

Right in the declaration. Is it allowed?


113567901_Inconsistent-code-and-document-in-luminance-calculations-#4776 (lgu1234) - i386-Windows-7-VisualStudio-12: OK (2085 of 2085 tests passed, 7 test warnings)

 * 6 tests had: AUD diffs.
 * 1 test had: ERR diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Are you sure it will work without quotation marks if there are spaces in the path?


# Good flaxues i mean matthew sorry


@squigg You were supported to call `realpath` on the path before you passed it through.


I can apply a fix for that case though.