Is there a timeframe for this? I guess this is for issues not labeled as accepted, and the previous item is for accepted ones, right?


Hi @paulray ,
I realize in my computer I ran into this error, which is very weird.

```
>>>parf = 'datafile/B1855+09_NANOGrav_dfg+12_modified.par'
>>>timf = 'datafile/B1855+09_NANOGrav_dfg+12.tim'
>>>model = mb.get_model(parf)
>>>t = toa.get_TOAs(timf)
>>>model.ECC.value
2.1745266×10−5
>>>binaryOBJ = model.get_dd_object(t.table)
>>>any(binaryOBJ.ecc()) >= 1
True
>>>max(binaryOBJ.ecc())
2.1745266×10−5
```

The any part seems wrong here, it should return False. Can you run your test and see if you have this problem?


The default should be set to 1 here. Think you might have forgotten that. Or am I missing something?


YearDescription_Results (macumber) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


I don't think this is needed, look at line 260 or so:
```
     # Also fingerprint this source file, so that if the logic for installations
     # changes, we will redo the installation.
     this_file = __file__
     if this_file.endswith(".pyc"):
         this_file = this_file[:-1]      # use the .py file instead of the .pyc
     files_to_fingerprint.append(this_file)
```

Did you have a problem with adding to the list and it not kicking in?


On 26/02/16 13:59 -0800, Ken Gaillot wrote:
> Agreed on all counts, but we're stuck with the _GNU_SOURCE
> dependency (which itself makes everything less readable). Let's
> avoid moving headers unless we have to.

Ok, let's do it a two step operation
1. just add <limits.h> to a sane position (part of this PR)
2. make sure there is a unified convention for listing includes
   (deferred, possibly done together with #858 resolution)

Can we proceed like this?

--
Jan (Poki)


lgtm


Koukám, že je tady a na spoustě dalších řádků posunutý apostrof. Shodou okolností to není parser error, ale fungovat to rozhodně nebude =)


Done


develop (macumber) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Can you add some details to the commit message explaining the motivation for this change? I'm not sure I understand how it fits in the big picture.


ThermCalcRelHumUseSameHumidRatioDryBulb (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (1962 of 2127 tests passed, 185 test warnings)

 * 165 tests had: Table big diffs.
 * 185 tests had: Table small diffs.
 * 2 tests had: ESO big diffs.
 * 1 test had: EIO diffs.
 * 1 test had: ESO small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-92.24%25-yellow.svg)


Default value is 1.0: https://developers.google.com/cast/docs/reference/chrome/chrome.cast.media.TextTrackStyle


[tests/testthat.R:4:2:](https://github.com/biggis-project/temp-modeling/blob/3a93ec9bb74bb10a0307367bbe428dddfb11bbcf/tests/testthat.R#L4) *style:* **Commented code should be removed.**
```r
#test_check("biggis.tempmodel")
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


Shouldn't this be FEATURE_UNIX_AMD64_STRUCT_PASSING_ONLY?


TeamCity LabKey :: LabkeyRelease15.3 :: CDS postgres 9.4 [Build 162](https://teamcity.labkey.org/viewLog.html?buildId=305858&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 16 (5 new), passed: 13 Build time: 00:47:58
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAxisSelectors: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisFilter: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.verifyAntigenVariableSelector: <no details avaliable>

##### there are 6 more failed tests, see build details
```


this whole green section is a cleanup due to a small change in line 29 where I now pass in sessionId. due to this line, I cleaned up the whole code surrounding it.


develop (macumber) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Good idea, fixed in 60cf310e7be04f9c85ea7729812fe804aea2e38a


This is fine if Class#superclass does sth like
```java
value = getSuperclass(rubyClass);
if (value == null) {
  transferAndInvalidate();
  throw error
}
return value;
```
But I agree it's a bit hacky. One proper fix would be to disallow `Class#allocate` and only allow `Class#new` so superclass is truly final and non-null (I see no possible real usage of Class#allocate, is it?).
So well, the current code looks fine IMO.


@MrSecure I just ran across this. Any interest in submitting this as a PR so I can merge it in?


#ifdef FEATURE_UNIX_AMD64_STRUCT_PASSING
Instead using #if


5499-Electric-Service-Follow-Up (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


This blog post was very helpful in creating this solution: http://www.milevis.com/Tips/Details/56


dfg_fix-test-models-for-standard-report (DavidGoldwasser) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


I have root-caused the test failures. Interestingly, they are not caused by this patch but by a bug in the Python launcher where it does not check whether the file is a directory when looking for the `python` binary.

The fix is simple. I have opened bazelbuild/bazel#981 for the bug.


Bova zamenjala presledke s podčrtaji.


// FEATURE_UNIX_AMD64_STRUCT_PASSING


this can be disputed if its a good separation of concerns. I need to think a little bit more on this. Comments appreciated. Maybe I should move the addition of PERMISSIONS page to the method calling addRequiredPages so that PERMISSIONS is no longer a required page per se. This might also reduce the amount of changes required to fix the initial problem in #7


dfg_fix-test-models-for-standard-report (DavidGoldwasser) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Changed.


as mentioned in the comment within addRequiredPages, maybe we should move addition of PERMISSIONS page to this method.


`LKL_HIJACK_NET_*` depends on `LKL_HIJACK_NET_TAP` completing successfully, I think. I know at least `LKL_HIJACK_NET_GATEWAY` does. It would be nice to stick in an example that includes setting up a TAP device too, IMO, and maybe including the expected output of those `ip` commands.


helloWorld (evanweaver) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


This update will save people hassle - can we get this deployed to:
https://grails-plugins.github.io/grails-spring-security-ldap/v3/index.html#custom-userdetailscontextmapper

soon?  I got stumped up on this.... .


I think that `init_lte` should still be in there.


I think that the `init_lte` parameter is missing here.


:+1: sweet! :rocket:


helloWorld (evanweaver) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


these two `q'` bindings are a good candidate for `cond->`


boring code-style thing, lets keep the let bindings aligned


Fixed.


:shipit:


It's a bit hard to reverse engineer what this is testing, so add a comment like:

"given a function with signature `(decimal(p,s), decimal(p,s))->boolean`, and invocation with `(decimal(2,1), decimal(1,0))`, verify that `p == 2` and `s == 1`"


version_modified (macumber) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


I assume this is still work in the progress. Do not forget to rename class `OmegaRatemeterServer` and remove `rate monitor` from multiple doc strings.


Unrelated change?


version_modified (macumber) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


This whole thing sounds very Linux-specific to me. I don't hear any of the other dozen or so operating systems asking for this.

And I like the idea of reference counting tables and being forced to go to a get/put model. It sounds way too complex, especially for a model that already works.


I know why i couldn't find this.

When you select help it send you to

https://github.com/glinscott/fishtest/wiki

instead of

https://github.com/official-stockfish/Stockfish

i don't know if this is an omision

I need to report it?

Regards

2016-02-26 16:06 GMT-06:00 fe lix <felix.bolanos@gmail.com>:

> Thank you
>
> I was sure someone tried this but i didn't search very well and i couldn't
> find anything.
>
> Next time i will ask in the forum
>
> Regards
>
>
>
> 2016-02-26 15:39 GMT-06:00 Rocky640 <notifications@github.com>:
>
>> The following line includes squares which are not checks !
>> b = undefended & ei.attackedBy[Them][ROOK] & ~pos.pieces(Them);
>>
>> For example, if Black Kg8, a White rook may attack and safely move to h7,
>> but this will not be a check
>> (for Queen, this is not a problem)
>>
>> so you would have to add something like this to only look at orthogonal
>> squares
>> b = undefended & ei.attackedBy[Them][ROOK] & ~pos.pieces(Them) &
>> PseudoAttacks[ROOK][ksq];
>>
>> There was some RookContactChecks not so long ago,
>> but it was found they could be simplified away.
>>
>> official-stockfish#442
>> <https://github.com/official-stockfish/Stockfish/pull/442>
>>
>> Also, it was often tried to include Rook Contact Checks supported by the
>> other Rook,
>> but it seems that search does not need that to find the correct moves.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/fbv-sf/Stockfish/commit/e9d4673caf0ff61da28c47e166ef9a69d2b53c79#commitcomment-16363705>
>> .
>>
>
>


This seems promising.  Could you please update with the last angular-chosen and compile to chosen.js as well? Thanks


Thanks for tracking that!

On Fri, Feb 26, 2016 at 11:17 PM David Z. Chen <notifications@github.com>
wrote:

> I have root-caused the test failures. Interestingly, they are not caused
> by this patch but by a bug in the Python launcher where it does not check
> whether the file is a directory when looking for the python binary.
>
> The fix is simple. I have opened bazelbuild/bazel#981
> <https://github.com/bazelbuild/bazel/issues/981> for the bug.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/google/protobuf/commit/985c968443e5124327fb600a91856192df4476ac#commitcomment-16365245>
> .
>


Good point! Coroutine may throw exceptions, and in that case the loop won't be restored.


Yeah, ok, no problem. :)


IMO you should use `lkl_sem_t` to get the various benefits of typechecking, revealing intention, easier refactoring, etc, but I know that's kind of my own pet peeve --- I will eventually go through the arch code and swap out the `void*` sems in the future and send a PR if you don't want to bother for now.


Looks like your parens are in the wrong place.  Here is what I did:
```
In [22]: np.any(binaryOBJ.ecc() >= 1)
Out[22]: False
In [23]: np.max(binaryOBJ.ecc())
Out[23]: <Quantity 2.1745265668236920582e-05>
```


This needs to be `malloc`'d, I think? Because it's possible that `lkl_create_syscall_thread` returns before `bootstrap_syscall_thread` has run `data->fn`, which would cause a segfault.


Perfect, thanks. That was the part I had missed.


Delete!


Does it say "Move" ANYWHERE in the title?

> Am 26.02.2016 um 19:10 schrieb RenanGamerz <notifications@github.com>:
>
> now minecarts move?
>
> —
> Reply to this email directly or view it on GitHub.
>


Thanks! BitHub has sent payment of  $29.06USD for this commit.


So, we should change the code to say
` if any(e<0) or any(e>=1):`


Tuším, že důvod, proč jsem se tomuhle bránil, jsou IDE. :)

Budou takhle našeptávat a umět nalézt usage property `$myName`?


Sounds true. Though line 282 should copy *arg instead


What about string/object?  Not important?


Hi, thank you so much for reviewing it. I have made changes accordingly. Please review.


Ok, didn't @balajikris just add this?  Or wasn't he able to use some other fnuction?  Can you turn around and ask him if this is necessary?


We should use Semver: http://semver.org/


Sure.

If the only reason we need limits.h is for INT_MAX in that one trace, I'd rather get rid of that usage (e.g. by using 0). That trace call is of dubious value to begin with.


I really dislike printing from within the automaton. Given that this should only ever occur due to a lttng-modules bug, which only affects  certain 32-bit architectures, and will be fixed in the next release, I feel like using the `get()` method, which would set `ret` to `None` if `'ret'` is not in the event's keys, would be a tolerable alternative.

Thoughts?


I am tracking down what appears to be a thread safety issue with the use of loading to check for circular dependancies.  Two threads loading the same file both use "loading" before clearing it.

Does that seem right to you?

More details here as the final answer.

http://stackoverflow.com/questions/29439323/rails-4-2-autoloading-not-thread-safe/35662892#35662892


It is the same in essence, but it is probably more readable this way - so I changed it. Reading https://msdn.microsoft.com/en-us/library/hhzbb5c8.aspx states:
"By default, the value associated with a symbol is 1. For example, /Dname is equivalent to /Dname=1. In the example at the end of this article, the definition of TEST is shown to print 1."


I was testing a build from the latest commit (bc23418 - Adjust Delta Scaling on MW23) and was wondering why the accelerometer is being disabled on F3 targets when set to 250us cycle time?  Maybe I'm missing something but my board seems to handle it (F303).  The below is from using the guy to set the cycle time to 250 and then re-enabled the accelerometer.  The to present a worse case I set pid_controller = lux and used feature SERIAL_RX and set the provider to SBUS.  The stats below seem to indicate this works ok, but maybe I'm missing something.  It the decision to disable the accelerometer based on PID loop and accel data processing or an I2C limit?

```
# status
System Uptime: 11 seconds, Voltage: 49 * 0.1V (2S battery - CRITICAL), CPU:22%
CPU Clock=72MHz, GYRO=MPU6050, ACC=MPU6050.n
Cycle Time: 251, I2C Errors: 0, config size: 1388

# tasks
Task list:
0 - (SYSTEM) max: 9us, avg: 0us, rate: 9hz, total: 1ms
1 - (PID) max: 226us, avg: 172us, rate: 2008hz, total: 9sec
- - (GYRO)  rate: 4016hz
2 - (ACCEL) max: 155us, avg: 85us, rate: 33hz, total: 50ms
3 - (SERIAL) max: 635us, avg: 2us, rate: 98hz, total: 21ms
4 - (BEEPER) max: 8us, avg: 0us, rate: 98hz, total: 2ms
5 - (BATTERY) max: 10us, avg: 1us, rate: 49hz, total: 43ms
6 - (RX) max: 84us, avg: 53us, rate: 49hz, total: 51ms

# tasks
Task list:
0 - (SYSTEM) max: 10us, avg: 0us, rate: 9hz, total: 1ms
1 - (PID) max: 226us, avg: 174us, rate: 1999hz, total: 13sec
- - (GYRO)  rate: 3999hz
2 - (ACCEL) max: 155us, avg: 85us, rate: 33hz, total: 71ms
3 - (SERIAL) max: 17668us, avg: 2us, rate: 99hz, total: 40ms
4 - (BEEPER) max: 8us, avg: 0us, rate: 99hz, total: 3ms
5 - (BATTERY) max: 10us, avg: 1us, rate: 49hz, total: 44ms
6 - (RX) max: 84us, avg: 53us, rate: 49hz, total: 73ms

# tasks
Task list:
0 - (SYSTEM) max: 10us, avg: 0us, rate: 9hz, total: 1ms
1 - (PID) max: 227us, avg: 171us, rate: 2008hz, total: 17sec
- - (GYRO)  rate: 4016hz
2 - (ACCEL) max: 155us, avg: 85us, rate: 33hz, total: 96ms
3 - (SERIAL) max: 18014us, avg: 2us, rate: 99hz, total: 60ms
4 - (BEEPER) max: 8us, avg: 0us, rate: 99hz, total: 5ms
5 - (BATTERY) max: 10us, avg: 1us, rate: 49hz, total: 46ms
6 - (RX) max: 84us, avg: 53us, rate: 49hz, total: 98ms
```


nice, but still no need for all those braces (or use them consistently)


you should create a separate test for this


Not a single test for this thing? What's the storage/retrieval order of UUIDs?


you don't know if it's random, it could already be sorted


супер, очень аккуратно


I'm not too fond of duplicating this code. I'd rather put it in once `common/format_utils` or somewhere. I'll submit a patch with this change.


you don't need to retest anything `< i` here, that's already sorted


I like this, I think it's a much more intuitive way for things to work. Conceivably in the future we could hijack `pthread_create` with `boostrap_syscall_thread`.


@duke12468 Finis is in the works, and will be available as soon as possible. I do work 40 hours a week, and I'm a full time student -- so I can't fully dedicate myself to the platform, but I am making considerable progress.

On another note, if anyone would like to live chat, I opened a discord server for Finis @ https://discordapp.com/channels/152905170009718785/152905170009718785. I'll report updates as I develop.


about tweet


I think it's fine to take away the use of `pthread_attr` (at least for now); I don't think it's possible to support things like that in a platform-independent way.

> On top of that, we can add that on every syscall, it checks whether it's on the default queue, or thread-specific queue. If it's the default queue, then start a new thread.

I agree it would be nice to lazily initialize a new syscall queue in each new thread. I think there is a nice solution for this that involves using `__thread` rather than the pthread tls stuff to figure out if a new queue needs to be initialized for the current thread without doing any bookkeeping.

> I prefer your current implementation, even if it has some limitation.

IMO this solution is much more intuitive than having to remember to call a function in each new thread, I like it a lot. Either way, I think the current implementation needs to change because the race condition is undefined behavior.


this is basically an unoptimized https://en.wikipedia.org/wiki/Selection_sort


Can you clarify: (1) What devices this will allow and (2) Why you've made this modification only to the usb_large_nand target, and not all the ar71xx targets (besides the default, which is the only one that does not have usb support)?


5499-Electric-Service-Follow-Up (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1012 of 1012 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-29.4%25-green.svg)


`cpath` -> `key-path`


you shouldn't need this part. if you want to iterate backwards, there are other ways for that


5499-Electric-Service-Follow-Up (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


`def`


join()


@hartleys, I realized that my solution to formatting the HTML table assumes that the gene.name.separator and gene.multimap.separator are always respectively going to be "+" and ",". Because those are defined internally with mapGeneNames, I don't expect this to be an issue unless someone is breaking the rules and overrides the defaults. However, the edge case of someone using non-standard separators is a possibility to keep in mind for future reference.


Glad this has been fixed, just ran into it today, was about to submit a PR with exact same fix and found this ;)


the amount of `!important` I see get used just scares me as a developer.. screams bad css..


which config should I use ?


And in this case, weird is bad


Looks good.


第一次修改


@CrackerTeg really fucking weird....and really fucking bad...


Symlinks are not supported on Windows, this is one of those so-called barriers.


This looks good, although I'll probably look through the other scripts to see if I can't find anymore that would benefit from some more room.

:dromedary_camel:


On 26/02/16 14:31 -0800, Ken Gaillot wrote:
> If the only reason we need limits.h is for INT_MAX in that one
> trace, I'd rather get rid of that usage (e.g. by using 0). That
> trace call is of dubious value to begin with.

I stuck with the rule "more is more" when tracing, but either offset
may be omitted or a complete trace...

Or at least -1 as 0 wouldn't be distinguishing enough, perhaps.

--
Jan (Poki)


PhpStorm ne, ale tohle řešení je lepší jak tichá chyba. Navíc vazby jako `m:hasOne()` mezeru nemají, takže umožním kompatibilitu, ale budu preferovat mezeru


FixCrashWithZoneAndSystemERV (JasonGlazer) - Win64-Windows-7-VisualStudio-12: OK (2128 of 2128 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


He says his is staged against future. We have agreed to resolve any merge conflict that occurs. :)


should be:
reply = sd_bus_message_unref(reply);


This is policing, the kind you wanted to remove.  We don't normally see people update the version, we're lucky if we can get them to update the tests.  We just created a voter-id law to prevent fraud when there is no voter-fraud :wink:


5499-Electric-Service-Follow-Up (EnergyArchmage) - x86_64-MacOS-10.9-clang: OK (2118 of 2120 tests passed, 7 test warnings)

 * 9 tests had: AUD diffs.
 * 9 tests had: MDD diffs.
 * 9 tests had: MTD diffs.
 * 1 test had: ERR diffs.
 * 2 tests had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


Why did you implement #equals()? I'm asking because I couldn't find where it's being used and, consequently, I couldn't ensure that there's no potential for a problem caused by the lack of #hashCode(). Generally, static code analysis will warn that #equals() is implemented and #hashCode() isn't.


Not sure whether all compilers would treat /Dname the same way.  Note that this code is also getting compiled on Unix and OSX.


Szerintem a .class fájlokat gitignore-ba kéne tenni...


maybe this is not right ... then again maybe its not !


I think we probably want `vary-meta` + `assoc` here, no?


This commit date is wrong. It was done 26/february.


Error log:

```
((("" + moment.tz(...).format(...)) + " ") + event.name).join is not a function
  at /app/scripts/event_manager.coffee:78:22, <js>:97:92
  at Array.map (native)
  at EventManager.make_list_message (/app/scripts/event_manager.coffee:78:13, <js>:96:18)
  at TextListener.callback (/app/scripts/event_manager.coffee:33:7, <js>:27:22)
  at EventManager.respond_on_add (/app/scripts/event_manager.coffee:126:14, <js>:143:21)
  at executeListener (/app/node_modules/hubot/src/listener.coffee:65:11, <js>:53:19)
  at allDone (/app/node_modules/hubot/src/middleware.coffee:44:37, <js>:34:16)
  at /app/node_modules/async/lib/async.js:274:13
  at Object.async.reduce (/app/node_modules/async/lib/async.js:268:15)
  at Object.async.eachSeries (/app/node_modules/async/lib/async.js:142:20)
  at /app/node_modules/hubot/src/middleware.coffee:49:7, <js>:37:22
  at nextTickCallbackWith0Args (node.js:433:9)
  at process._tickCallback (node.js:362:13)
```


Nope, it's my fault. For some reason I was under impression that Reviewers should accept issues as well. Which is incorrect. I'll refrain from doing this in the future.


basically monkey see / monkey do.

i had a look at how it was done in the other settings dialogs and stuck to that.
for instance:
https://github.com/xbmc/xbmc/blob/master/xbmc/profiles/dialogs/GUIDialogProfileSettings.h#L41-L46
https://github.com/xbmc/xbmc/blob/master/xbmc/profiles/dialogs/GUIDialogLockSettings.h#L39-L44


i like it


zueiro!


OK. :)

Určitě bude super propagovat variantu s mezerou jako *best practice*.

Jinak nelze úplně srovnávat absenci mezery v případě `m:hasOne()` a mezi názvem property sloupcem, protože název property je název property (kterému rozumí i IDE), zatímco `m:hasOne()` je jakýsi modifikátor s parametrem… Čímž chci říct, že určitá logika v původní striktní verzi je :), ale přiznávám, že není úplně intuitivní a hlavně ty závorky pro název sloupce jsou matoucí.

Teď by to bylo zbytečný BC break, ale dneska bych asi ty anotace navrhl aka `@property $myName ~name~ m: passThru(…)` nebo tak nějak. :) Prostě aby aby ten název sloupce nebyl v závorce, nýbrž byl použit jiný delimiter.


Simplified script by replacing grep+2 seds with one grep action.


Hmm I probably should fix my eclipse settings...if I auto import things it'll screw it up again.


Ah, yes, probably better.


Quick question do other platforms build with -D_THREAD_SAFE or equivalent ?


The Grunt file is missing!


I'm not a fan of silently fixing invalid parameters. I'd rather get an assert exception if I'm passing an invalid value.


You'll have to replace `iCloud.com.pemdas.Provenance` with your custom CloudKit container.


Any of those is fine. I think the following CRM_CHECK() and crm_time_log() are sufficient, but no harm in keeping it.


It's a public function declared here: https://github.com/seelabs/rippled/commit/ae22bb9f4f3b599ca7aee7786f1f989cf8796269#diff-01c2e265861a39bbfedeeda869f79011R219.


Clash Of Clans game note


Also I don't know yet how I triggered it but somehow between enabling/disabling the accelerometer in the CLI and twice I've had the CPU utilization go to 100%.  Testing at 250us cycle time with luxfloat and enabling/disabling the accel (F303 FC).  Both times power cycling the board returned things to normal.  The last time was after I disabled the accel (set acc_hardware = none) and did a save in the CLI.  Can't seem to find a pattern that replicates this but I'll keep trying.


Will do.
On Feb 26, 2016 5:53 PM, "Benoit Pierre" <notifications@github.com> wrote:

> I'm not a fan of silently fixing invalid parameters. I'd rather get an
> assert exception if I'm passing an invalid value.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/morinted/plover/commit/b0f32e16937be5d27c55ba4eb78f6f79b536bf2a#commitcomment-16365870>
> .
>


typo: supper -> super


Maybe add a comment to differentiate the 2 ForwardingRules?


I believe that greping for "+" is not the safest way, considering possibility that some randomly added by ERES admin expression on site footnote may consist such character.
Surely new regexp will be safer, cause it's using longer schema that is less likely to appear somewhere else than we expect it to.


allow /demo/ works as well by using:
`(r"/demo/?", DemoHandler),`


I think "via a `context` method one of your controllers" is missing a word.


Do we really need this? I feel like this could scare people away from writing issues at all. I think we can readd this if/when we start having to many badly written issues.


Let's make this "./tests" so it matches up with the existing default in https://github.com/cloudant/basho_bench/blob/6fdf8ced8b70b18c0ca9b7351b76a2883b2512d4/src/basho_bench.erl#L193


I split server configs into proxies and servers serving apis/content/etc


Would be nice to avoid redefining the default test_dir location in several parts of the app. Perhaps move this get_env call into a top level function in basho_bench.erl? something like `get_test_dir() -> application:get_env(basho_bench, test_dir, "./tests")`.


5499-Electric-Service-Follow-Up (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2156 of 2158 tests passed, 7 test warnings)

 * 9 tests had: AUD diffs.
 * 9 tests had: MDD diffs.
 * 9 tests had: MTD diffs.
 * 1 test had: ERR diffs.
 * 2 tests had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


```
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running com.adobe.people.justinedelson.uberjardemo.impl.ClassExtendingDefaultAuthenticationFeedbackHandlerTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.079 sec <<< FAILURE! - in com.adobe.people.justinedelson.uberjardemo.impl.ClassExtendingDefaultAuthenticationFeedbackHandlerTest
shouldInitialiseObfuscatedClass(com.adobe.people.justinedelson.uberjardemo.impl.ClassExtendingDefaultAuthenticationFeedbackHandlerTest)  Time elapsed: 0.025 sec  <<< ERROR!
java.lang.VerifyError: (class: org/apache/sling/auth/core/spi/DefaultAuthenticationFeedbackHandler, method: <init> signature: ()V) Constructor must call super() or this()
	at com.adobe.people.justinedelson.uberjardemo.impl.ClassExtendingDefaultAuthenticationFeedbackHandlerTest.shouldInitialiseObfuscatedClass(ClassExtendingDefaultAuthenticationFeedbackHandlerTest.java:15)

Running com.adobe.people.justinedelson.uberjardemo.impl.ClassWhichHasAEMInterfacePassedInTest
objc[61332]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_60.jdk/Contents/Home/jre/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.732 sec - in com.adobe.people.justinedelson.uberjardemo.impl.ClassWhichHasAEMInterfacePassedInTest
Running com.adobe.people.justinedelson.uberjardemo.impl.ComponentWhichHasAEMInterfaceInjectedTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.019 sec <<< FAILURE! - in com.adobe.people.justinedelson.uberjardemo.impl.ComponentWhichHasAEMInterfaceInjectedTest
test_that_long_string_is_trimmed(com.adobe.people.justinedelson.uberjardemo.impl.ComponentWhichHasAEMInterfaceInjectedTest)  Time elapsed: 0.009 sec  <<< ERROR!
java.lang.InternalError

Results :

Tests in error:
  ClassExtendingDefaultAuthenticationFeedbackHandlerTest.shouldInitialiseObfuscatedClass:15 Verify
  ComponentWhichHasAEMInterfaceInjectedTest.test_that_long_string_is_trimmed » Internal

Tests run: 3, Failures: 0, Errors: 2, Skipped: 0
```


[inst/benchmarks/profviz-wtc_sig.R:16:21:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L16) *style:* **Commas should always have a space after.**
```r
d1.ar1 <- arima(d1[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[inst/benchmarks/profviz-wtc_sig.R:17:21:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L17) *style:* **Commas should always have a space after.**
```r
d2.ar1 <- arima(d2[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[inst/benchmarks/profviz-wtc_sig.R:34:1:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L34) *style:* **Variable and function names should be all lowercase.**
```r
registerDoParallel(cl)
^~~~~~~~~~~~~~~~~~
```
[inst/benchmarks/profviz-wtc_sig.R:48:33:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L48) *style:* **Commas should always have a space after.**
```r
        .init = array(dim = c(3,3,nrands)),
                                ^
```
[inst/benchmarks/profviz-wtc_sig.R:48:35:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L48) *style:* **Commas should always have a space after.**
```r
        .init = array(dim = c(3,3,nrands)),
                                  ^
```
[inst/benchmarks/profviz-wtc_sig.R:50:14:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L50) *style:* **Commas should always have a space after.**
```r
          y[,,x$r] <- x$a
             ^
```
[inst/benchmarks/profviz-wtc_sig.R:52:9:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L52) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
        }) %dopar% {
        ^
```
[inst/benchmarks/profviz-wtc_sig.R:53:43:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L53) *style:* **Commas should always have a space after.**
```r
          list(r = r, a = array(dim = c(3,3), (1:9) * r))
                                          ^
```
[inst/benchmarks/profviz-wtc_sig.R:70:3:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L70) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  {seq_len(1000000)},
  ^
```
[inst/benchmarks/profviz-wtc_sig.R:70:20:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L70) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  {seq_len(1000000)},
                   ^
```
[inst/benchmarks/profviz-wtc_sig.R:71:3:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L71) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  {1:1000000},
  ^
```
[inst/benchmarks/profviz-wtc_sig.R:71:13:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L71) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  {1:1000000},
            ^
```
[inst/benchmarks/profviz-wtc_sig.R:82:36:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L82) *style:* **Commas should always have a space after.**
```r
    out1 <- apply(ts, MARGIN = c(1,2), quantile, 0.95, na.rm = TRUE)
                                   ^
```
[inst/benchmarks/profviz-wtc_sig.R:86:14:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L86) *style:* **Commas should always have a space after.**
```r
      out2[i,] <- row_quantile(ts[i,,], 0.95)
             ^
```
[inst/benchmarks/profviz-wtc_sig.R:86:37:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L86) *style:* **Commas should always have a space after.**
```r
      out2[i,] <- row_quantile(ts[i,,], 0.95)
                                    ^
```
[inst/benchmarks/profviz-wtc_sig.R:92:13:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L92) *style:* **Commas should always have a space after.**
```r
      out3[,i] <- row_quantile(ts[,i,], 0.95)
            ^
```
[inst/benchmarks/profviz-wtc_sig.R:92:36:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L92) *style:* **Commas should always have a space after.**
```r
      out3[,i] <- row_quantile(ts[,i,], 0.95)
                                   ^
```
[inst/benchmarks/profviz-wtc_sig.R:92:38:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/inst/benchmarks/profviz-wtc_sig.R#L92) *style:* **Commas should always have a space after.**
```r
      out3[,i] <- row_quantile(ts[,i,], 0.95)
                                     ^
```
[R/check.data.R:31:8:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/check.data.R#L31) *warning:* **no visible global function definition for ‘check.datum’**
```r
  y <- check.datum(y)
       ^~~~~~~~~~~
```
[R/check.data.R:34:11:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/check.data.R#L34) *warning:* **no visible global function definition for ‘check.datum’**
```r
    x1 <- check.datum(x1)
          ^~~~~~~~~~~
```
[R/check.data.R:44:11:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/check.data.R#L44) *warning:* **no visible global function definition for ‘check.datum’**
```r
    x2 <- check.datum(x2)
          ^~~~~~~~~~~
```
[R/check.data.R:61:47:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/check.data.R#L61) *style:* **Commas should always have a space after.**
```r
    if (class(x[, 1])[1] == "Date" | class(x[,1])[1] == "POSIXct") {
                                              ^
```
[R/phase.plot.R:38:17:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L38) *style:* **Commas should always have a space after.**
```r
  phases[-a.row,] <- NA
                ^
```
[R/phase.plot.R:39:11:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L39) *style:* **Commas should always have a space after.**
```r
  phases[,-a.col] <- NA
          ^
```
[R/phase.plot.R:43:27:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L43) *style:* **Commas should always have a space after.**
```r
      if (!is.na(phases[i,j])) {
                          ^
```
[R/phase.plot.R:45:32:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L45) *style:* **Commas should always have a space after.**
```r
              alpha = phases[i,j], col = arrow.col)
                               ^
```
[R/phase.plot.R:76:60:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                           ^
```
[R/phase.plot.R:76:63:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                              ^
```
[R/phase.plot.R:76:66:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                                 ^
```
[R/phase.plot.R:76:69:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                                    ^
```
[R/phase.plot.R:76:72:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                                       ^
```
[R/phase.plot.R:76:75:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                                          ^
```
[R/phase.plot.R:77:60:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                           ^
```
[R/phase.plot.R:77:63:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                              ^
```
[R/phase.plot.R:77:66:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                                 ^
```
[R/phase.plot.R:77:69:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                                    ^
```
[R/phase.plot.R:77:72:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                                       ^
```
[R/phase.plot.R:77:75:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                                          ^
```
[R/plot.biwavelet.R:114:29:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/plot.biwavelet.R#L114) *style:* **Commas should always have a space after.**
```r
                     "cyan","#7FFF7F", "yellow",
                            ^
```
[R/pwtc.R:89:40:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/pwtc.R#L89) *warning:* **no visible binding for global variable ‘MOTHERS’**
```r
  mother <- match.arg(tolower(mother), MOTHERS)
                                       ^~~~~~~
```
[R/pwtc.R:91:14:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/pwtc.R#L91) *warning:* **no visible global function definition for ‘check.data’**
```r
  checked <- check.data(y = y, x1 = x1, x2 = x2)
             ^~~~~~~~~~
```
[R/pwtc.R:105:21:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/pwtc.R#L105) *style:* **Commas should always have a space after.**
```r
  y.ar1 <- arima(y[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[R/pwtc.R:106:23:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/pwtc.R#L106) *style:* **Commas should always have a space after.**
```r
  x1.ar1 <- arima(x1[,2], order = c(1, 0, 0))$coef[1]
                      ^
```
[R/pwtc.R:122:20:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/pwtc.R#L122) *style:* **Commas should always have a space after.**
```r
  y.sigma <- sd(y[,2], na.rm = TRUE)
                   ^
```
[R/pwtc.R:123:22:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/pwtc.R#L123) *style:* **Commas should always have a space after.**
```r
  x1.sigma <- sd(x1[,2], na.rm = TRUE)
                     ^
```
[R/pwtc.R:145:20:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/pwtc.R#L145) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.cw_yx1 <- smooth.wavelet(s.inv * (cw.yx1), dt, dj, wt.y$scale)
                   ^~~~~~~~~~~~~~
```
[R/pwtc.R:146:20:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/pwtc.R#L146) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.cw_yx2 <- smooth.wavelet(s.inv * (cw.yx2), dt, dj, wt.y$scale)
                   ^~~~~~~~~~~~~~
```
[R/pwtc.R:147:21:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/pwtc.R#L147) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.cw_x1x2 <- smooth.wavelet(s.inv * (cw.x1x2), dt, dj, wt.y$scale)
                    ^~~~~~~~~~~~~~
```
[R/smooth.wavelet.R:51:37:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/smooth.wavelet.R#L51) *style:* **Commas should always have a space after.**
```r
    wave.pad[seq_len(m)] <- wave[ii,]
                                    ^
```
[R/smooth.wavelet.R:68:12:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/smooth.wavelet.R#L68) *warning:* **no visible global function definition for ‘convolve2D_typeopen’**
```r
  swave <- convolve2D_typeopen(twave, rev(ker))
           ^~~~~~~~~~~~~~~~~~~
```
[R/smooth.wavelet.R:71:41:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/smooth.wavelet.R#L71) *style:* **Commas should always have a space after.**
```r
  swave[keep.start:(keep.start + n - 1),]
                                        ^
```
[R/wclust.R:40:21:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wclust.R#L40) *style:* **Commas should always have a space after.**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                    ^
```
[R/wclust.R:40:27:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wclust.R#L40) *warning:* **no visible global function definition for ‘wdist’, Did you mean 'dist'?**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                          ^~~~~
```
[R/wclust.R:40:42:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wclust.R#L40) *style:* **Commas should never have a space before.**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                                        ~^
```
[R/wclust.R:40:43:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wclust.R#L40) *style:* **Commas should always have a space after.**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                                          ^
```
[R/wclust.R:40:55:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wclust.R#L40) *style:* **Commas should never have a space before.**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                                                     ~^
```
[R/wclust.R:40:56:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wclust.R#L40) *style:* **Commas should always have a space after.**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                                                       ^
```
[R/wdist.R:35:31:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wdist.R#L35) *style:* **Commas should always have a space after.**
```r
  u <- wsvd$u[seq_len(nfreqs),]
                              ^
```
[R/wdist.R:36:31:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wdist.R#L36) *style:* **Commas should always have a space after.**
```r
  v <- wsvd$v[seq_len(nfreqs),]
                              ^
```
[R/wdist.R:38:61:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wdist.R#L38) *style:* **Commas should always have a space after.**
```r
  Lnk <- t(u[, seq_len(nfreqs)]) %*% Re(wt1[seq_len(nfreqs),])
                                                            ^
```
[R/wdist.R:39:61:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wdist.R#L39) *style:* **Commas should always have a space after.**
```r
  Ljk <- t(v[, seq_len(nfreqs)]) %*% Re(wt2[seq_len(nfreqs),])
                                                            ^
```
[R/wdist.R:49:11:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wdist.R#L49) *style:* **Commas should always have a space after.**
```r
      (u[,2:NROW(u)] - v[,2:NROW(v)]))))
          ^
```
[R/wdist.R:49:27:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wdist.R#L49) *style:* **Commas should always have a space after.**
```r
      (u[,2:NROW(u)] - v[,2:NROW(v)]))))
                          ^
```
[R/wt.bases.R:32:12:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wt.bases.R#L32) *style:* **Put spaces around all infix operators.**
```r
    morlet =rcpp_wt_bases_morlet(...), # original wt.bases.morlet(...),
           ^~
```
[R/wt.R:75:14:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wt.R#L75) *warning:* **no visible global function definition for ‘check.datum’**
```r
  checked <- check.datum(d)
             ^~~~~~~~~~~
```
[R/wt.R:81:20:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wt.R#L81) *style:* **Commas should always have a space after.**
```r
  sigma2 <- var(d[,2])
                   ^
```
[R/wt.R:107:11:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wt.R#L107) *warning:* **no visible global function definition for ‘wt.bases’**
```r
    wb <- wt.bases(mother, k, scale[a1], param)
          ^~~~~~~~
```
[R/wt.sig.R:42:40:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wt.sig.R#L42) *warning:* **no visible binding for global variable ‘MOTHERS’**
```r
  mother <- match.arg(tolower(mother), MOTHERS)
                                       ^~~~~~~
```
[R/wtc_sig_parallel.R:24:10:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc_sig_parallel.R#L24) *warning:* **no visible global function definition for ‘get_minroots’**
```r
  mr1 <- get_minroots(lag1[1])
         ^~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:25:10:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc_sig_parallel.R#L25) *warning:* **no visible global function definition for ‘get_minroots’**
```r
  mr2 <- get_minroots(lag1[2])
         ^~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:28:22:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc_sig_parallel.R#L28) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
  d1 <- cbind(ntseq, ar1_ma0_sim(mr1, lag1[1], ntimesteps))
                     ^~~~~~~~~~~
```
[R/wtc_sig_parallel.R:36:11:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc_sig_parallel.R#L36) *style:* **Variable and function names should be all lowercase.**
```r
  NUMC <- getDoParWorkers()
          ^~~~~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:36:11:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc_sig_parallel.R#L36) *warning:* **no visible global function definition for ‘getDoParWorkers’**
```r
  NUMC <- getDoParWorkers()
          ^~~~~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:48:23:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc_sig_parallel.R#L48) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
                      }) %dopar% {
                      ^
```
[R/wtc_sig_parallel.R:58:26:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc_sig_parallel.R#L58) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
      d1 <- cbind(ntseq, ar1_ma0_sim(mr1, lag1[1], ntimesteps))
                         ^~~~~~~~~~~
```
[R/wtc_sig_parallel.R:59:26:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc_sig_parallel.R#L59) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
      d2 <- cbind(ntseq, ar1_ma0_sim(mr2, lag1[2], ntimesteps))
                         ^~~~~~~~~~~
```
[R/wtc_sig_parallel.R:71:14:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc_sig_parallel.R#L71) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
      sw1 <- smooth.wavelet(s.inv * (abs(wt1$wave) ^ 2), dt, dj, wt1$scale)
             ^~~~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:72:14:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc_sig_parallel.R#L72) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
      sw2 <- smooth.wavelet(s.inv * (abs(wt2$wave) ^ 2), dt, dj, wt2$scale)
             ^~~~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:96:5:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc_sig_parallel.R#L96) *warning:* **no visible global function definition for ‘row_quantile’**
```r
    row_quantile(rand.rsq[,j,], sig.level)
    ^~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:96:28:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc_sig_parallel.R#L96) *style:* **Commas should always have a space after.**
```r
    row_quantile(rand.rsq[,j,], sig.level)
                           ^
```
[R/wtc_sig_parallel.R:96:30:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc_sig_parallel.R#L96) *style:* **Commas should always have a space after.**
```r
    row_quantile(rand.rsq[,j,], sig.level)
                             ^
```
[R/wtc.R:97:40:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.R#L97) *warning:* **no visible binding for global variable ‘MOTHERS’**
```r
  mother <- match.arg(tolower(mother), MOTHERS)
                                       ^~~~~~~
```
[R/wtc.R:100:14:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.R#L100) *warning:* **no visible global function definition for ‘check.data’**
```r
  checked <- check.data(y = d1, x1 = d2)
             ^~~~~~~~~~
```
[R/wtc.R:115:23:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.R#L115) *style:* **Commas should always have a space after.**
```r
  d1.ar1 <- arima(d1[,2], order = c(1, 0, 0))$coef[1]
                      ^
```
[R/wtc.R:116:23:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.R#L116) *style:* **Commas should always have a space after.**
```r
  d2.ar1 <- arima(d2[,2], order = c(1, 0, 0))$coef[1]
                      ^
```
[R/wtc.R:128:22:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.R#L128) *style:* **Commas should always have a space after.**
```r
  d1.sigma <- sd(d1[,2], na.rm = T)
                     ^
```
[R/wtc.R:129:22:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.R#L129) *style:* **Commas should always have a space after.**
```r
  d2.sigma <- sd(d2[,2], na.rm = T)
                     ^
```
[R/wtc.R:134:17:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.R#L134) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.wt1 <- smooth.wavelet(s.inv * (abs(wt1$wave) ^ 2), dt, dj, wt1$scale)
                ^~~~~~~~~~~~~~
```
[R/wtc.R:135:17:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.R#L135) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.wt2 <- smooth.wavelet(s.inv * (abs(wt2$wave) ^ 2), dt, dj, wt2$scale)
                ^~~~~~~~~~~~~~
```
[R/wtc.R:153:16:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.R#L153) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.CW <- smooth.wavelet(s.inv * (CW), dt, dj, wt1$scale)
               ^~~~~~~~~~~~~~
```
[R/wtc.sig.R:59:10:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.sig.R#L59) *warning:* **no visible global function definition for ‘get_minroots’**
```r
  mr1 <- get_minroots(lag1[1])
         ^~~~~~~~~~~~
```
[R/wtc.sig.R:60:10:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.sig.R#L60) *warning:* **no visible global function definition for ‘get_minroots’**
```r
  mr2 <- get_minroots(lag1[2])
         ^~~~~~~~~~~~
```
[R/wtc.sig.R:63:22:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.sig.R#L63) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
  d1 <- cbind(ntseq, ar1_ma0_sim(mr1, lag1[1], ntimesteps))
                     ^~~~~~~~~~~
```
[R/wtc.sig.R:79:24:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.sig.R#L79) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
    d1 <- cbind(ntseq, ar1_ma0_sim(mr1, lag1[1], ntimesteps))
                       ^~~~~~~~~~~
```
[R/wtc.sig.R:80:24:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.sig.R#L80) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
    d2 <- cbind(ntseq, ar1_ma0_sim(mr2, lag1[2], ntimesteps))
                       ^~~~~~~~~~~
```
[R/wtc.sig.R:92:12:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.sig.R#L92) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
    sw1 <- smooth.wavelet(s.inv * (abs(wt1$wave) ^ 2), dt, dj, wt1$scale)
           ^~~~~~~~~~~~~~
```
[R/wtc.sig.R:93:12:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.sig.R#L93) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
    sw2 <- smooth.wavelet(s.inv * (abs(wt2$wave) ^ 2), dt, dj, wt2$scale)
           ^~~~~~~~~~~~~~
```
[R/wtc.sig.R:95:16:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.sig.R#L95) *style:* **Commas should never have a space before.**
```r
    rand.rsq[, , r] <- abs(smooth.CW) ^ 2 / (sw1 * sw2)
              ~^
```
[R/wtc.sig.R:111:13:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.sig.R#L111) *style:* **Commas should always have a space after.**
```r
    result[,i] <- row_quantile(rand.rsq[,i,], sig.level)
            ^
```
[R/wtc.sig.R:111:19:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.sig.R#L111) *warning:* **no visible global function definition for ‘row_quantile’**
```r
    result[,i] <- row_quantile(rand.rsq[,i,], sig.level)
                  ^~~~~~~~~~~~
```
[R/wtc.sig.R:111:42:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.sig.R#L111) *style:* **Commas should always have a space after.**
```r
    result[,i] <- row_quantile(rand.rsq[,i,], sig.level)
                                         ^
```
[R/wtc.sig.R:111:44:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/wtc.sig.R#L111) *style:* **Commas should always have a space after.**
```r
    result[,i] <- row_quantile(rand.rsq[,i,], sig.level)
                                           ^
```
[R/xwt.R:75:40:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/xwt.R#L75) *warning:* **no visible binding for global variable ‘MOTHERS’**
```r
  mother <- match.arg(tolower(mother), MOTHERS)
                                       ^~~~~~~
```
[R/xwt.R:78:14:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/xwt.R#L78) *warning:* **no visible global function definition for ‘check.data’**
```r
  checked <- check.data(y = d1, x1 = d2)
             ^~~~~~~~~~
```
[R/xwt.R:93:23:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/xwt.R#L93) *style:* **Commas should always have a space after.**
```r
  d1.ar1 <- arima(d1[,2], order = c(1, 0, 0))$coef[1]
                      ^
```
[R/xwt.R:94:23:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/xwt.R#L94) *style:* **Commas should always have a space after.**
```r
  d2.ar1 <- arima(d2[,2], order = c(1, 0, 0))$coef[1]
                      ^
```
[R/xwt.R:105:22:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/xwt.R#L105) *style:* **Commas should always have a space after.**
```r
  d1.sigma <- sd(d1[,2], na.rm = T)
                     ^
```
[R/xwt.R:106:22:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/xwt.R#L106) *style:* **Commas should always have a space after.**
```r
  d2.sigma <- sd(d2[,2], na.rm = T)
                     ^
```
[R/xwt.R:127:9:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/xwt.R#L127) *warning:* **no visible global function definition for ‘ar1.spectrum’**
```r
  P1 <- ar1.spectrum(d1.ar1, wt1$period / dt)
        ^~~~~~~~~~~~
```
[R/xwt.R:128:9:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/R/xwt.R#L128) *warning:* **no visible global function definition for ‘ar1.spectrum’**
```r
  P2 <- ar1.spectrum(d2.ar1, wt2$period / dt)
        ^~~~~~~~~~~~
```
[tests/testthat/test-convolve2D.R:7:12:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-convolve2D.R#L7) *style:* **Commas should always have a space after.**
```r
  y <- c(1,1,2)
           ^
```
[tests/testthat/test-convolve2D.R:7:14:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-convolve2D.R#L7) *style:* **Commas should always have a space after.**
```r
  y <- c(1,1,2)
             ^
```
[tests/testthat/test-convolve2D.R:9:27:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-convolve2D.R#L9) *style:* **Commas should always have a space after.**
```r
    convolve2D_typeopen(x,y),
                          ^
```
[tests/testthat/test-convolve2D.R:10:18:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-convolve2D.R#L10) *style:* **Commas should always have a space after.**
```r
    convolve2D(x,y, type = "open"))
                 ^
```
[tests/testthat/test-convolve2D.R:15:12:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-convolve2D.R#L15) *style:* **Commas should always have a space after.**
```r
  y <- c(1,1,2)
           ^
```
[tests/testthat/test-convolve2D.R:15:14:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-convolve2D.R#L15) *style:* **Commas should always have a space after.**
```r
  y <- c(1,1,2)
             ^
```
[tests/testthat/test-convolve2D.R:17:18:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-convolve2D.R#L17) *style:* **Commas should always have a space after.**
```r
    convolve2D(x,y, type = "circular"),
                 ^
```
[tests/testthat/test-convolve2D.R:20:1:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-convolve2D.R#L20) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-convolve2D.R:21:1:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-convolve2D.R#L21) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-plot.biwavelet.R:27:1:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-plot.biwavelet.R#L27) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test-rowQuantileC.R:41:22:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                     ^
```
[tests/testthat/test-rowQuantileC.R:41:24:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                       ^
```
[tests/testthat/test-rowQuantileC.R:41:27:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                          ^
```
[tests/testthat/test-rowQuantileC.R:41:29:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                            ^
```
[tests/testthat/test-rowQuantileC.R:41:31:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                              ^
```
[tests/testthat/test-rowQuantileC.R:41:33:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                                ^
```
[tests/testthat/test-rowQuantileC.R:41:35:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                                  ^
```
[tests/testthat/test-rowQuantileC.R:41:37:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                                    ^
```
[tests/testthat/test-rowQuantileC.R:41:40:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                                       ^
```
[tests/testthat/test-wclust.R:17:10:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-wclust.R#L17) *style:* **Commas should never have a space before.**
```r
w.arr[1, , ] <- wt.t1$wave
        ~^
```
[tests/testthat/test-wclust.R:18:10:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-wclust.R#L18) *style:* **Commas should never have a space before.**
```r
w.arr[2, , ] <- wt.t2$wave
        ~^
```
[tests/testthat/test-wclust.R:19:10:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-wclust.R#L19) *style:* **Commas should never have a space before.**
```r
w.arr[3, , ] <- wt.t3$wave
        ~^
```
[tests/testthat/test-wclust.R:28:37:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-wclust.R#L28) *style:* **Commas should always have a space after.**
```r
  expect_equal(dim(c$diss.mat), c(3,3))
                                    ^
```
[tests/testthat/test-wtc_sig_parallel.R:9:21:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-wtc_sig_parallel.R#L9) *style:* **Commas should always have a space after.**
```r
d1.ar1 <- arima(d1[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[tests/testthat/test-wtc_sig_parallel.R:10:21:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-wtc_sig_parallel.R#L10) *style:* **Commas should always have a space after.**
```r
d2.ar1 <- arima(d2[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[tests/testthat/test-wtc_sig_parallel.R:39:34:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-wtc_sig_parallel.R#L39) *style:* **Commas should always have a space after.**
```r
    expect_equal( dim(out), c(42,64) )
                                 ^
```
[tests/testthat/test-wtc.sig.R:9:21:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-wtc.sig.R#L9) *style:* **Commas should always have a space after.**
```r
d1.ar1 <- arima(d1[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[tests/testthat/test-wtc.sig.R:10:21:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-wtc.sig.R#L10) *style:* **Commas should always have a space after.**
```r
d2.ar1 <- arima(d2[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[tests/testthat/test-wtc.sig.R:39:34:](https://github.com/vsimko/biwavelet/blob/1dce991bf8cc191486da07872dcd065b43bd7402/tests/testthat/test-wtc.sig.R#L39) *style:* **Commas should always have a space after.**
```r
    expect_equal( dim(out), c(42,64) )
                                 ^
```


Hi Philip, Thanks for your work.  I tried your code and it works nicely.  I want to let you know that you are publishing the ApplicationId in the Java code.  Please ignore my message if you are already aware.  Kwan


```
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running com.adobe.people.justinedelson.uberjardemo.impl.ClassExtendingDefaultAuthenticationFeedbackHandlerTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.061 sec <<< FAILURE! - in com.adobe.people.justinedelson.uberjardemo.impl.ClassExtendingDefaultAuthenticationFeedbackHandlerTest
shouldInitialiseObfuscatedClass(com.adobe.people.justinedelson.uberjardemo.impl.ClassExtendingDefaultAuthenticationFeedbackHandlerTest)  Time elapsed: 0.028 sec  <<< ERROR!
java.lang.VerifyError: (class: org/apache/sling/auth/core/spi/DefaultAuthenticationFeedbackHandler, method: <init> signature: ()V) Constructor must call super() or this()
	at com.adobe.people.justinedelson.uberjardemo.impl.ClassExtendingDefaultAuthenticationFeedbackHandlerTest.shouldInitialiseObfuscatedClass(ClassExtendingDefaultAuthenticationFeedbackHandlerTest.java:15)

Running com.adobe.people.justinedelson.uberjardemo.impl.ClassWhichHasAEMInterfacePassedInTest
objc[61944]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_60.jdk/Contents/Home/jre/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.648 sec - in com.adobe.people.justinedelson.uberjardemo.impl.ClassWhichHasAEMInterfacePassedInTest
Running com.adobe.people.justinedelson.uberjardemo.impl.ComponentWhichHasAEMInterfaceInjectedTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.018 sec <<< FAILURE! - in com.adobe.people.justinedelson.uberjardemo.impl.ComponentWhichHasAEMInterfaceInjectedTest
test_that_long_string_is_trimmed(com.adobe.people.justinedelson.uberjardemo.impl.ComponentWhichHasAEMInterfaceInjectedTest)  Time elapsed: 0.016 sec  <<< ERROR!
java.lang.InternalError

Results :

Tests in error:
  ClassExtendingDefaultAuthenticationFeedbackHandlerTest.shouldInitialiseObfuscatedClass:15 Verify
  ComponentWhichHasAEMInterfaceInjectedTest.test_that_long_string_is_trimmed » Internal

Tests run: 3, Failures: 0, Errors: 2, Skipped: 0
```


&& not ||

((level >= 200) && (owned > appliedOwned))


On it. Sorry for the delay!