So I'd argue that the nesting here is bad CSS practice. There's about 1 id and 4 classes nested in here, meaning if you had to override any of these rules elsewhere, they'd need important or the same amount of nesting. This would require some refactoring to fix, just wanted to point it out.

The 18f CSS styleguide specifies not more then 2 levels of selector nesting to limit this from happening.


Great spec coverage.


@xc-racer99 You can comment on my commits as much as you want, you're more knowledgeable than i am, so feel free to correct any mistake.

I guess i will add back ext4 on /data. About /system, it should be possible to force it to mount with f2fs right ?

Apparently @sooti have already updated the updater.sh : 4e736a2daafdb8a65367ba5fe4379ded86795957. I will try to take a look on the kernel side, it could be great to have system partition formated as f2fs.


Then @0xbadb002 would have to add a new mode. Which he should.


this can be a comma separated string.

> If I understood you right every InputStream Addon MUST

every instance of an addon. hence this should go to the config dialog of the addon. you can easily configure this in settings.xml


OS has been changed to an enum with no instances and the SIGNATURE has been made static.  Not sure adding equals() helps readability in this case.


I'm not sure I understand why we've lost the case normalization for WDigest


@rouson Quick question: Do you remember the rational for adding this symbolic link? It is  deleted in your latest commit. While I rebase, I'm wondering if I should just never add it, or if  it is needed in this revision.


112331505_SurfaceHeightRange (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (978 of 978 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-28.32%25-green.svg)


This seems unrelated to the merge


because it looks more complicated than before and is more code.


Is this extraneous?

Also, should we make module be `test_history.py` now?


this bear is so simple that by using an abstraction you're making it more complicated


reverting to previous state


Looks good to me.


I'd prefer uniformity


I am sure you know, but you can just write: `scenario "an Admin assigns a Nurse to a Nurse Supervisor"` and it will let you know it is pending so you don't forget to write the test.


Though if `a` is zero here then these cases need some additional checks as well.


Please use a MEMORY_MODE enum in memory.h for readability.


Так а мы ж вроде договорились в отдельном файле _извлекалку данных с imdb_, а тут ты начинаешь сразу менять весь MovieList на использование только imdb?..


It's not the nicest code to look at, but I felt the optimizations were worth it.

I am unaware of any interest by zilmar to convert all memory to big endian. If he actually intended on enforcing big endian and I was aware of this, I would not have submitted this commit.


revert


Hi,
i think you introduced a bug with this commit in src/utility.js line 209
when run in a browser without browserify this line throws a error. I think what you wanted to do was check if process is defined. So it should be:
return utils.isBrowser && typeof(process) !== "undefined" && typeof(process.browser) !== "undefined";


I can't see the images here. Make sure you link them correctly, though.


@PixnBits I guess you actually want to make use of the ed25519 support, then? Since as it is, you can just not include tweetnacl and everything else should still work (which is why it's in `optionalDependencies`, though `npm` seems ill-equipped to actually do anything useful with that field). The ed25519 in Javascript implementations are all pretty slow -- we're talking low hundreds of signatures per second, and high tens of verifications here. I've been pretty iffy about enabling it in production for anything here (at Joyent) just because of how slow it is.

tweetnacl does have a fallback "license" (CC0) if you're in a jurisdiction where public domain doesn't exist: https://github.com/dchest/tweetnacl-js/issues/85 -- does that help at all? My long-term plan, to be honest, is to get rid of the dep on tweetnacl completely once OpenSSL has EdDSA support...


Not sure I am a fan of `calculate` as the endpoint name.


их вынеси в самое начало, после боди (все три инпута)


In general, the harder it is to explain the equivalence of the old code to your new code, the more questionable overall it will be to have that revision committed.  By all means, if it provides a noticeable speed-up that you can actually _see_ or _hear_, without benchmarking, then it's substantial enough to sacrifice code readability for major optimizations, but with some comments explaining the performance outweigh (and probably put the old, slower but more readable code inside `#if 0` for legacy tests and debugging, though zilmar IIRC would not like the #if 0).

If (wired &= 31) is all you have to change, then maybe your rewrite does not detract from the ability to correct the algorithm, because even with your change that is still easy to install.  It does still, however, detract from the ability to see the intentions behind the code to question them against hardware accuracy descriptions, when written in the form you've provided here.


take what you want :D I want the new parameters

2016-02-10 21:12 GMT+01:00 AbdealiJK <notifications@github.com>:

> I'd prefer uniformity
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/8cb4d1b03ff87ea23342e24f139bc9d33dd3c499#commitcomment-16016005>
> .
>


This only installs git-pair for the currently active Ruby.

Would be better to do a system-wide install. See https://github.com/pivotal/git_scripts#system-wide-installation


:+1: I had forgotten about that!


Oh okay. I was going to say, I compiled for my angler and haven't ran into any problems.  My b!


Please use a bracket style consistent with the rest of the codebase as described in CONTRIBUTING.md


sizeof(bool) is more correct there.


It is not needed or used anywhere.  The reason for adding it was that I think it's most convenient to have all the tests in one place (src/tests), but any initial tests for the OFP source transformations will likely need to evolve over time so just seemed convenient to have the tests "close" to the OFP transformation rules.  I decided that maintaining the symbolic link is not worth the longer-term hassle, given how git handles symbolic links.


Typo: missing final `S` on `tesSUCCESS`


@DaleMcGrew This looks a bit interesting... The logic you pulled from BallotStore is creating a hash of voters and that's not what you want. I told you yesterday and you said you don't want to refactor but it's not a refactor as much as it is doing it the right way...

I think it's literally a one line change...
 *136*
`_voter_store = response // or something... i'm not sure what the response object looks like`

and then here the entire function gets wiped and is one line...
`return _voter_store;`


Or you call it in a loop until it returns nullptr?


I don't think this is right. Or the comment is now wrong.


Ok, I must be missing something here... the _raw() takes a path to a tty device, so I can't use that here w/o duplicating most of the functionality of mraa_uart_init().

In addition, there is a mraa_uart_ow_init_raw() that does take the path, and calls the appropriate mraa_uart_init_raw(), again, without duplicating the existing functionality of mraa_uart_init_raw().  What am I missing?


Oops, this snuck in the same pull request. Basically to trim image size, I might have deleted locale files which sounds like they might be used in some scenarios, when reading
http://netatalk.sourceforge.net/3.1/htmldocs/configuration.html#charsets

>afpd handles three different character set options:

>unix charset
>This is the codepage used internally by your operating system. If not specified, it defaults to UTF8. >If LOCALE is specified and your system support Unix locales, afpd tries to detect the codepage. >afpd uses this codepage to read its configuration files, so you can use extended characters for >volume names, login messages, etc. see afp.conf(5).


@shaleman thanks for catching that.. I have updated the code and cleaned up some old code in the process, PTAL

```
vagrant@netplugin-node1:~$ netctl tenant create pepsi
INFO[0000] Creating tenant: pepsi
vagrant@netplugin-node1:~$ netctl net create net1 --subnet=20.1.1.0/24 --gateway=20.1.1.254 --pkt-tag=1002 --tenant pepsi
vagrant@netplugin-node1:~$
vagrant@netplugin-node1:~$ etcdctl get /contiv.io/state/nets/net1.pepsi | python -m jsontool
{"epCount": 1, "pktTagType": "vxlan", "subnetIP": "20.1.1.0", "subnetLen": 24, "ipAllocMap": "AAAAAAAAAQEAAAAAAAAAAwAAAAAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAB", "gateway": "20.1.1.254", "pktTag": 1, "extPktTag": 1002, "networkName": "net1", "id": "net1.pepsi", "tenant": "pepsi", "dnsServer": "20.1.1.1"}
vagrant@netplugin-node1:~$ netctl net delete --tenant pepsi net1
INFO[0000] Deleting network pepsi:net1
vagrant@netplugin-node1:~$

vagrant@netplugin-node1:~$ netctl net create net1 --subnet=20.1.1.0/24 --gateway=20.1.1.254 --pkt-tag=1002 --tenant pepsi
vagrant@netplugin-node1:~$ etcdctl get /contiv.io/state/nets/net1.pepsi | python -m jsontool
{"epCount": 1, "pktTagType": "vxlan", "subnetIP": "20.1.1.0", "subnetLen": 24, "ipAllocMap": "AAAAAAAAAQEAAAAAAAAAAwAAAAAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAB", "gateway": "20.1.1.254", "pktTag": 1, "extPktTag": 1002, "networkName": "net1", "id": "net1.pepsi", "tenant": "pepsi", "dnsServer": "20.1.1.1"}
vagrant@netplugin-node1:~$ docker run -itd --name=web1 --net=net1/pepsi ubuntu /bin/bash
Unable to find image 'ubuntu:latest' locally
latest: Pulling from library/ubuntu
92ec6d044cb3: Pull complete
2ef91804894a: Pull complete
f80999a1f330: Pull complete
6cc0fc2a5ee3: Pull complete
Digest: sha256:457b05828bdb5dcc044d93d042863fba3f2158ae249a6db5ae3934307c757c54
Status: Downloaded newer image for ubuntu:latest
f4d8a9bfb1e02914122644c6506a8c4d2b4efc3f9e083061ec9e30e34a18334b
vagrant@netplugin-node1:~$ etcdctl get /contiv.io/state/nets/net1.pepsi | python -m jsontool
{"epCount": 2, "pktTagType": "vxlan", "subnetIP": "20.1.1.0", "subnetLen": 24, "ipAllocMap": "AAAAAAAAAQEAAAAAAAAABwAAAAAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAB", "gateway": "20.1.1.254", "pktTag": 1, "extPktTag": 1002, "networkName": "net1", "id": "net1.pepsi", "tenant": "pepsi", "dnsServer": "20.1.1.1"}
vagrant@netplugin-node1:~$ docker run -itd --name=web2 --net=net1/pepsi ubuntu /bin/bash
78de323f7260aa6fad4a788cd19e8a129fdeb25f5e8c492968b51c59cb827006
vagrant@netplugin-node1:~$ etcdctl get /contiv.io/state/nets/net1.pepsi | python -m jsontool
{"epCount": 3, "pktTagType": "vxlan", "subnetIP": "20.1.1.0", "subnetLen": 24, "ipAllocMap": "AAAAAAAAAQEAAAAAAAAADwAAAAAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAB", "gateway": "20.1.1.254", "pktTag": 1, "extPktTag": 1002, "networkName": "net1", "id": "net1.pepsi", "tenant": "pepsi", "dnsServer": "20.1.1.1"}
vagrant@netplugin-node1:~$ netctl net delete --tenant pepsi net1
INFO[0000] Deleting network pepsi:net1
ERRO[0000] Error: Network has active endpoints [github.com/contiv/netplugin/netmaster/master.DeleteNetworkID network.go 343]

vagrant@netplugin-node1:~$ docker stop web1
web1
vagrant@netplugin-node1:~$ docker rm web1
web1
vagrant@netplugin-node1:~$ etcdctl get /contiv.io/state/nets/net1.pepsi | python -m jsontool
{"epCount": 2, "pktTagType": "vxlan", "subnetIP": "20.1.1.0", "subnetLen": 24, "ipAllocMap": "AAAAAAAAAQEAAAAAAAAACwAAAAAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAB", "gateway": "20.1.1.254", "pktTag": 1, "extPktTag": 1002, "networkName": "net1", "id": "net1.pepsi", "tenant": "pepsi", "dnsServer": "20.1.1.1"}
vagrant@netplugin-node1:~$ docker stop web2
web2
vagrant@netplugin-node1:~$ docker rm web2
web2
vagrant@netplugin-node1:~$ etcdctl get /contiv.io/state/nets/net1.pepsi | python -m jsontool
{"epCount": 1, "pktTagType": "vxlan", "subnetIP": "20.1.1.0", "subnetLen": 24, "ipAllocMap": "AAAAAAAAAQEAAAAAAAAAAwAAAAAAAAAAAAAAAAAAAABAAAAAAAAAAAAAAAAAAAAB", "gateway": "20.1.1.254", "pktTag": 1, "extPktTag": 1002, "networkName": "net1", "id": "net1.pepsi", "tenant": "pepsi", "dnsServer": "20.1.1.1"}
vagrant@netplugin-node1:~$ netctl net delete --tenant pepsi net1
INFO[0000] Deleting network pepsi:net1
vagrant@netplugin-node1:~$

```


Misael: Haciendo modificaciones para probar un "commit" y "puhs" para que Román y Danaé puedan hacer pull


exactly here. I am not sure if the initialisation of session to 0 does work here. debugger showed me session was 0x0 but crashed on first line in destructor.


Awesome! Thank you Nick, I will give that a try this afternoon.


key — не оч.хорошее название, лучше бы что-нибудь типа формат; а ещё лучше — MovieList.from_csv и MovieList.from_json


Please post an issue for that, we should because benchmarks alone do repeated reloading of the same site.  Also useful in general.


For some reason your fork does not reflect these changes, so I am not able to test them. Would it be easier just to create a separate branch with these changes?


`<link>` tag is not supporting


функция работает правильно, но очень сложно =)
смотри: times+times2 всегда будет равно чему? правильно, длине строки ))
потому что times - это количество букв g или c, times2 - это количество букв, которые НЕ g и НЕ c. А в сумме это число равно общему количеству букв.


I'm somewhat worried about the `math.tan` here in combination with the problem addressed before. When the `x` values are the same, then the `atan2` call will set the angle to a very large value. This is because it should actually be infinite, but it cannot reach this value. I'm not sure what effect this has in this specific piece of code, but it might be a cause for the following warning:
``
../reconstruction/Weight_Matrix.py:83: RuntimeWarning: divide by zero encountered in double_scalars
  weight_matrix[index] = (1.0 / np.sqrt(length)) * weight
``


On the subject though you did come up with a different algorithm than what I thought of.

You seem to have chosen accumulation, for better or worse.  (I did not finish.)  I chose a fixed math relationship of the form:  `random = wired + k*(32 - wired)`, where _k_ need only be solved for.  A yet-to-be-optimized solution to this uses the standard floating-point ceiling operation:  `k = (int32_t)ceil((double)(32 + wired) / random);`, or something like that.


ah, you found my dirty dev trick! Just there to be able to use the things in the Chrome REPL.


а зачем ты два раза считаешь одну и ту же строку? один раз в строке 16, а потом зачем-то в строке 17...


I corrected the issues. Deadbeef supports gtk3, I have tried it and works, but it still has some issues, so I  added the option --disable-gtk3, like you had done in other commits.


I believe this is backwards and was correct the first time. The point of the tolerance is to specifically *exclude* lines that are on the tile boundary, *or* just inside. The tolerance exists because small variances in the data caused lines that were nearly on the tile boundary, but just inside or outside, to not be caught, and incorrectly drawn. With the sign flipped this way, it seems like boundary lines would always expect to be drawn. Have you tested it? (BTW you often need to test several areas and zooms, because sometimes it works in some cases but not others, which are easy to miss.)


This same code is in SpatialReference.  Perhaps a function is in order?


Then I would need some error handling in kodi for the case an addon never returns nullptr. You don't have to do anything. just pass the user entered sting from settings


Ты должен описать поведение функции, а не сослаться на поведение другой.


@sgdc3 The reason for the test's long duration is the high number of iterations in BCrypt. This is by design to slow down attackers, but of course this slows down any "legitimate purposes" like our unit tests, too. 20 seconds is indeed quite steep, so I'll open an issue to discuss what we could do.


Нет необходимости создавать эту переменную, можно проверять результат вычисления функции напрямую.


@geekwise
looks great - please change the color back


тут два раза считается одна и та же строка - это не очень хорошо, потому что если строка длинная - то одно и то же будет считаться дважды (см. комментарии к следующему коммиту)


strafeAir have a different brakingdistance since they also have drag:
https://github.com/spring/spring/blob/develop/rts/Sim/MoveTypes/StrafeAirMoveType.cpp#L1245


Не путай с `map`


I was thinking along the lines of the following.

```
class ssl_context_t {
public:
    ssl_context_t() {
        context = SSL_new();
        if (m_contest == nullptr) {
            // Handle error
        }
    }

    ~ssl_context_t() {
        SSL_free(m_context); // Note this handles nullptr fine
    }

    SSL *get_context() {
        return m_context;
    }

private:
    SSL *m_context;
};
```

Note that I just wrote this out here and may not compile. It has the advantage that it will always clean up when the stack gets unwound, regardless of the exception being thrown. The current solution works, but if an exception is added in the future we're back to square one unfortunately.


I missed to update the comment, it should read `pg_conversion`. Fixing.


Ok, not sure about this either.  I do see an owner flag for gpio and pwm contexts (only).  There is no such animal for uart that I can see.  Keeping in mind, as much as possible, this functionality makes use of the underlying mraa_uart functionality.


Здрасть


ok, but Lieschen Müller has to be able to define multiple strings, Best without the knowledge of separators.
Does the GUI dialogs support something like this? Insert a list of strings and settings.xml stores a singles sting with separators?


great
yes, it supports gtk3, but you can see in their development, gtk2 is still clearly preferred.
That is why, don't blindly copy others :)


эээ


How is this traceback printing different from [`traceback.print_exception`](https://docs.python.org/2/library/traceback.html#traceback.print_exception)?


We talk as refugees seeking asylum. While talking about asylum seekers is technically correct, the previous formulation might have been more approachable for people who don't know what "asylum" means.


@annevk not 100% on this, can you sanity check?


Fixed.


Yeah well, it was a bit sloppy. Thanks for noticing!


@annevk ditto.


Correct, not sure how I managed to cross-eye that one. Fixing.


Can you add a quick comment here explaining what `state.n` means? (I think it refers to which variable in a `var a,b,c` scenario)


How can I test it? Is it possible with your latest inputstream code tree?


Not writen on the commit, but yes, it needs maps to be extracted again.


Смотри, это ОЧЕНЬ ДЛИННЫЙ метод — который тяжело проконтролировать и тяжело тестировать.
Я бы его разбил, в первую очередь, на
1. запрос top, из которого 250 раз вызывается ...
2. запрос отдельного movie

Тогда запрос конкретного movie очень легко было бы оттестировать для одной страницы.


Yeah these are only basic modes for testing, there's loads of other weird things you can do so I'll need to do a flag type thing


Not exactly what we want to do but it beats fixing #413 first... for now ;)


ack


Oups...


картинки бекграундом, разметку как делать слайдер в скринкастах или демках можешь глянуть


so what's the problem of simply putting the `# Ignore PyImportSortBear` comments in the files? Ignoring the whole file is bad


There is no 'IsTrue' you have to use 'c.Assert(status, Equals, True)'


:clap:


Does 'this.log' exist in this context? Else just make it required.


Oh. I thought you meant make a comment on top saying why the files are ignored by PyImportSortBear

Will do


is this cast needed?


Why did you do this change? What does it do?


As far as I know, the roborio only has an accelerometer. Do you mean something like encoders?


Good point. I originally wrote this for some parallel code where I could then send the traceback to the master node which actually printed it - but even for that there might be simpler alternatives...


yuuyyu


fwiw from https://github.com/timothycrosley/isort/wiki/isort-Settings known first and third party imports are important we should either have a bug for them or just do it here


Done


#5 finished


script lib should be including right before closing the body tag.


@alphapapa: For now, guard them with a universal variable like

```fish
if not set -q fish_initialized
    # All your abbrs
    set -U fish_initialized
end
```

I'm looking into more optimizations. I think I've got it down quite a bit, but I'll need to test it extensively.


Can you think of a good way to summarize this in a comment? Or should we expand the docstring to say that `a_slice` and `b_slice` can also be indices? This is an assumption we make other places in the code, specifically in `ObjView`, where we also call this type of thing "slice" when it can really be either an actual `slice` object or a list of indices. Is there any way to make this clearer in general? Also, it's good to know this for writing backends, too. I was just wondering to myself whether `a_slice` and `b_slice` could also be individual indices (i.e. integers), but we turn these into `slice` objects in the `ObjView` code.


It's not actually there on my local, but this was when I was trial/erroring some weird compiler error.


@xfurry
quest still req.
```sql
-- npc_kerlonian
-- Horn of Awakening
-- http://www.wowhead.com/spell=17536/awaken-kerlonian#used-by-item
DELETE FROM `creature_ai_scripts` WHERE `creature_id` = 11218;
INSERT INTO `creature_ai_scripts` VALUES
('1121801','11218','8','0','100','1','17536','-1','0','0','4','6700','0','0','0','0','0','0','0','0','0','0','Kerlonian Evershade - play sound on SpellHIT');
UPDATE creature_template SET AIName = 'EventAI' WHERE `entry` = '11218';
```

As u said .. .this need to be done in SD2 script...
So when u'll get free time ;)
thanks


Great indentation 😌


`@VisibleForTesting`


Bo was talking about the turret that will be rotating on top of the robot
I'm not 100% sure exactly what sensors we will be putting on the robot.


Why not just make it a hash lookup


Pas grave fais dans un autre commit mais manque deux espaces autours des {. et le mieux serait de mettre des parenthèses vu qu'il n'y a qu'une seule instruction
Normalement il n'y en a pas non plus en suivant les google convetions après timeout: (timeout(() =>)


вот хорошо, на самом деле хорошо.
Одно замечание по алгоритму - у тебя каждый раз в цикле идёт перерасчет минимального значения. А его совсем не надо делать каждый раз, потому что зачем? Тебе надо найти минимальное значение всего один раз - когда ты точно нашла максимальное.
В общем - одно мааааленькое измение в программе - и будет ваще идеально )


:( que c'est moche ces trucs !


what is it meant to be "valid" node?


Oh, didn't see this. #165 is blocked by a merge conflict related to the travis file. I can't see the problem from looking at the files but git also failed to merge locally.

So I merged `master` into this fork of `develop` and resolved the merge issue. In other words, from a develop point of view, there are no changes but from a master point of view there apparently are.


IMO any are cleaner than hash lookups as they are much more natural to read


It resolves https://github.com/AntennaPod/AntennaPod/issues/837#issuecomment-173871217


I know this is a pain (and not always done elsewhere), but I feel that if the input is not in the expected format we should return that as an error to the client.


Hmm. I think the code is actually wrong, even before this patch. It's supposed to list a syscache on pg_constraint, to make sure ORCA's metadata cache is invalidated if a constraint is dropped. And that's what the comment implies too. I think I was confused when I wrote that, and thought that CONOID is a syscache on pg_constraint, while in reality it's a syscache on pg_conversion.


indentation


I'm hoping merging this back into `develop` will resolve the merge conflict from `develop` to `master`.

But to be honest, I'm not sure if this is the correct approach.


It should be possible to use f2fs on /system.  I haven't looked at it as I have /system on an MTD volume on my variant.

The kernel has ext4 hardcoded at https://github.com/Coldwindofnowhere/android_kernel_samsung_aries/blob/android-6.0/usr/galaxysmtd_initramfs_files/init and you'll also want to look at the charger section in init.aries.rc.

Ideally, there would be some way to dynamically test which filesystem it is but I don't want to figure out how to do this.

On unrelated notes, I wish we had a newer kernel...  I found some guy that had the Fascinate up to 3.3 (I'm unsure of how functional, see https://github.com/syndtr/android-kernel/tree/qss-next), another guy who had the Nexus S up to 3.4 (but most things still weren't working but it did boot, see http://dmitry.gr/index.php?r=06.%20Thoughts&proj=05.%20Android%20M%20on%20Nexus%20S).  Also, with ION, there was a bunch of changes that were submitted to Google's gerrit that included basic ION support for the Nexus S.  Unfortunately, they were Abandoned and I can't find the newer GPU blobs anywhere.


test


AddWarningWhenDElightAndShading (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1530 of 1530 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.7%25-green.svg)


manque un espace avt le {


space


so, I think the right thing to do is s/CONOID/CONSTROID/, and leave the comment as it is.


not 80-chars-on-a-line compliant


а зачем эта странная переменная нужна?


agreed!


ici ça rentre sur une ligne ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15301](https://teamcity.mesosphere.io/viewLog.html?buildId=131585&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:04:58


Will you open a pull request? I'd love to use it with rails 4+


+1 looks great


Seems to be an easy mistake to make (per the comment in gpdbwrappers.cpp, I mixed up the too there earlier ;-) )


probably not but for for this iteration it should do. I think there are more important things that need our attention in this round :) what do you think?


space avt =


Does this warning context actually get applied the the `multiprocessing.Process`?


indent + go to the line avt et après else


а чего ты считаешь gc-content в целых процентах? там по условию и примеру было в дробных ))


Done


.main-nav-dropdown Тоже скрыт должен быть


To be clear, I do not want to support a `RegisterCustomRegistry` ; which appears to have been added into the carry PR and is not in the upstream.


Whether he's interested in it or not doesn't interest me, and it shouldn't interest you.  He did express a open willingness to it for the future.  Pull requests should be about doing what the right thing is and/or what you want, not necessarily what zilmar wants or gift pull requests to exchange for trust, mutual service friendships, respect or appreciation...that makes the pull requests sound more like paid services or jobs, rather than just doing what should be done.  Unless it really was zilmar paying us to make PRs of what he's interested in.

Besides, even with the loop approach, you would only really have needed to just loop `i` partially up to a 16-bit aligned address, then loop _mm_storeu_si128 (or better still, `memcpy()`), then finish off any trailing bytes if the final address isn't 128-bit aligned.  Even in the totally unaligned cases you could have done this, but alas, the memcpy is simplest because the compiler optimizes this for you before you or I even thought of it.


Вопрос в том, а нужен ли нам тут _класс_?.. Ведь класс — это что-то, объект чего ты создаёшь, у него есть какое-то внутреннее состояние, а потом долго используешь (в результате его состояние, например, меняется). В данном случае ничего этого нету.

В принципе, и такое использование класса возможно/разумно (он предназначен для выполнения какого-то _процесса_, используется как `Класс.создать(аргументы).выполнить_процесс` и забыть) — но тогда всё равно должно быть понятно зачем тут класс (он опять же хранит _внутреннее состояние_ происходящего процесса). Здесь у тебя, по сути, один метод, завёрнутый в как-бы-класс.

Как было бы лучше?
1. Если уж класс — то пусть он будет ImdbParser (он же всё равно ничо другого не умеет, правильно)
2. ...И использование его будет явное: `ImdbParser.parse_top` — возвращающий список распарсенных фильмов
3. ...А уж он внутри себя создаёт объект, который несколько своих методов вызывает по очереди, чтобы аккуратно всё распарсить, имеет какое-то своё состояние и т.д.


I'm cool with this. I note that this does affect rendering for all courses, not just generic ones.


Мне кажется, что там где-то был аттрибут, в котором прям кол-во минут было въявную написано :)


à la ligne le id + je mets ici le reste, y'a des endroits où y'a plus d'une ligne de sauté, pas nécessaire imo


indent (après aussi)


This is good!


This is the versioning scheme I'm using in my projects, it just slipped in here out of habit. The general idea is that the first two numbers define the CRAN version, and anything behind the dash is on GitHub only. (Point releases such as this are an exception.)


hey, I don't think this function is useful - `get_json(string)` vs. `json.loads(string)`


What if it's actually a rapper?


Это ж только с двумя жанрами будет работать?..


True is lower case :-)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15302](https://teamcity.mesosphere.io/viewLog.html?buildId=131609&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:48


removed old files and folders


I think these all need some more spaces if they’re meant to be code blocks…


Кстати, `css(...).first` легко заменяется на `at(...)`


That doesnt work. isort still moves around the imports in an unwanted manner

On Thu, Feb 11, 2016 at 1:59 AM, Lasse Schuirmann <notifications@github.com>
wrote:

> so what's the problem of simply putting the # Ignore PyImportSortBear
> comments in the files? Ignoring the whole file is bad
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/9696322524682912ec6c4c9df5ad25eb4dab3e98#commitcomment-16016329>
> .
>


задай высоту


clientOptions.rejectUnauthorized will not do anything. In this version it's not being used whatsoever. Thus, breaking change.


ce serait bien pour tous les tests d'avoir toujours : les conditions initiales (déclarations de val, etc) séparé par une ligne, puis le process (ici readArtist), puis une ligne blanche, puis les expectations (d'ailleurs le top serait qu'il n'y en ait qu'une le plus souvent [c'est bien le cas ici mais pas dans plein de tests que j'ai fait et c'est pas top])


I like how you give the user the option to select a different file. Good call.


J'ai supprimé une partie sur Adblock Plus car le fonctionnement de l'extension a changé.
De même pour la partie configuration d'HTTPS Everywhere.


I couldn't go higher than jQuery 1.8 because after that they removed the $.browser object which is used in one of our libraries and I didn't want to upgrade multiple libraries right now.


You can select an item which has id using this.$.addContactform within polymer


Done.


слайд шириной в ширину контейнера, все скрыты кроме активного поэтому можешь и не флоатить


Dunno, seems you can't really put a code block as part of the list item


Renamed to just replicaset/frontend.yaml


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1363](http://teamcity.monogame.net/viewLog.html?buildId=14747&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Just reading this commit.
Just delete dead code.
In a pinch, use #if 0 ... #endif


what is the cast `(<Map<any>>node)`?


зачем этот ретурн, если он нигде не используется?


Hm, looks like you’re right.


delete dead arguments.


First Line.

Second Line.

Third Line.


зачем нужен второй массив? rez[]?


No that's good, let's keep it that way.


Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus egestas gravida quam non ultricies. Aenean sed vehicula enim. Vivamus consectetur est vitae quam cursus, non semper dolor cursus. Praesent sodales ligula vel neque ultricies cursus. Duis suscipit blandit posuere. Nulla sagittis aliquam lacus sit amet volutpat. Maecenas id justo velit. Praesent sed tellus et enim viverra finibus. Curabitur a ipsum at magna cursus maximus quis suscipit mi. Phasellus vulputate erat lorem, ut dignissim nibh sagittis ac. Morbi mauris ligula, vestibulum ac ex in, auctor vulputate magna. Mauris gravida, nisi at viverra mattis, eros mauris luctus ligula, ut dignissim turpis sem id lectus. Nam mollis sagittis tempus. Nam erat justo, volutpat id rutrum sit amet, mattis ut massa. Sed et ipsum nisl.

Proin mauris arcu, pellentesque in gravida at, tempor vitae magna. Etiam convallis leo purus, eu tincidunt purus commodo at. Nullam id sem at odio luctus pretium quis at ipsum. Suspendisse non libero dolor. Aliquam ut neque bibendum, bibendum augue eu, pharetra leo. Vivamus rhoncus magna in nibh viverra ultrices. Pellentesque id mattis lectus, gravida maximus nibh. Curabitur sit amet blandit felis. Interdum et malesuada fames ac ante ipsum primis in faucibus. Maecenas id faucibus libero. Nullam dignissim turpis at eleifend luctus. Donec sodales lobortis velit in rhoncus. Donec accumsan eros et leo luctus, a luctus arcu auctor.

Nullam ut volutpat ligula. Duis iaculis eros in mauris varius, non blandit justo auctor. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Proin viverra lacinia orci et finibus. Maecenas malesuada orci ac ex interdum aliquet. Fusce vulputate maximus tempor. Pellentesque purus justo, lobortis a nisi id, scelerisque pharetra mauris. Donec imperdiet fringilla lorem, id euismod elit tincidunt id. Sed convallis arcu dolor, sit amet lobortis tortor pretium sed. Mauris et vestibulum ipsum. Morbi lacus justo, lobortis nec justo in, volutpat mollis nunc. Cras vitae ipsum nunc. Morbi nisl felis, scelerisque id consequat vel, malesuada quis nisi. Aenean pulvinar maximus nulla, at euismod enim iaculis sed. Curabitur scelerisque ligula eu posuere sagittis. Vestibulum non laoreet felis.

Nulla magna nibh, ultrices a accumsan et, egestas eget elit. Aenean luctus nisi ac lacus elementum, non bibendum felis porttitor. Cras enim libero, ullamcorper sed maximus vel, tempor vitae odio. Sed orci mi, eleifend in vulputate et, posuere eget turpis. Cras consequat orci a nibh imperdiet ultrices. Fusce non turpis facilisis, porta nibh blandit, dapibus tellus. Fusce commodo lacus vel eros condimentum tincidunt tincidunt sed elit. In eget felis posuere, tincidunt ex at, tincidunt elit. Quisque auctor mollis ex, quis feugiat lacus imperdiet eu. Pellentesque rhoncus, tellus nec ultrices ultricies, ante odio vulputate diam, at venenatis enim augue nec felis.

Donec sem diam, tincidunt ac consectetur nec, lacinia vitae metus. Morbi lobortis ut libero ut scelerisque. Fusce pharetra hendrerit tincidunt. Interdum et malesuada fames ac ante ipsum primis in faucibus. Nulla facilisi. Donec iaculis eros at egestas ornare. Nulla tristique semper sapien in scelerisque. Nam volutpat augue et sollicitudin malesuada. Nullam eu tincidunt lectus. Nam lacinia felis velit, sed vulputate augue consectetur nec. Quisque sodales dui blandit, cursus turpis ut, tempor lorem.


.. "as follows:"


:candy:


Currently stuck on what to do for "views." Not sure how far you'd like us to go with this at this point. Also, I don't believe I've seen an example of what to do to display the entire contents of a table. We'll use the "events" table for an example. So far, everything I've seen up to this point, if I remember correctly, was only to show one column of that table. I'm not sure of an appropriate way to display all columns and how to use some form of HTML to accommodate an easy to read view.


Ich habe die tabs in d13aba80bc9ece092949b0c01353f0d6e75de2b2 wieder entfernt.


I suppose this function could be virtual and overriden by SAMT, but

1) conservative estimates are better IMO
2) 5079 affected HAMT aircraft
3) SAMT assigns its own value to `landRadiusSq`: https://github.com/spring/spring/blob/develop/rts/Sim/MoveTypes/StrafeAirMoveType.cpp#L948


Yep, the original signs were correct here. This function should return `true` for line segments that are coincident with a tile boundary within the tolerance.

To see whether the behavior is correct, you can just add a "lines" draw rule to landuse features in the default scene file.


AWESOME AWESOME AWESOME


You should not merge master to develop.  That is a git-flow no-no.  I will check into it and see what I can figure out.  Please don't merge anything else just yet until I work it out.


Get it. Fine with me! :)


113008903Provide-a-better-warning-message-for-a-triangular-window (lgu1234) - x86_64-MacOS-10.9-clang: OK (2074 of 2074 tests passed, 0 test warnings)

 * 3 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This causes symfony cache to use the same user hash across users as it no longer varies on 'Cookie'.

The fetch for the user hash is not marked as an internal forward request so vary cookie is not added as described.


Про лишнюю переменную я понял. А про "не путай с map" нет. Там ведь все различие в проверке на истину, которую я делаю, так в чем ошибка?


I made a change on the computer, but can't find it yet.


тут почти всё хорошо, кроме того, что сложность твоего алгоритма поиска - квадратичная. А это не совсем хорошо. Можно решить эту задачу, не используя цикл-в-цикле.


Okay, as I said, I do not really care much about it. Thanks!


I find it a bit clearer to mention the renaming. But I find your name selection still confusing in this use case.
How are the chances to find a really unique entity that is affected here?


oh, forgot that!
cool then


It is true that it is nicer to look at but a hash lookup is faster and not that much more difficult to read.

Since it is in a code path that is not used that much speed does not matter that much.

It is more of an issue of best practices.
IMO we should always go with the faster way if the cost is small.
This seems to be one of those cases.


WOW such interpretation


I think may miss something here. Why you have to liftNode here? I don't understand why if the lifting fails, we return undefined


I’d remove the `translate` on the `div` and add the translate directive on the `span` and `footer` separately since they can be pretty much translated independently


Что эта функция в итоге возвращает и что должна возвращать?


I think lazy parsing days are numbered. We lose it with other module systems, right?


Done.


agree - just trying to avoid double work


I think that you forgot to include cover.tex


это решение я уже комментировал ))) спроси у Ани, что я ей написал, мне второй раз лень )))


Cordova is indeed new to me. :)


контейнер должен быть на всю ширину окна, он будет окрашиваться слайдером потом, а вот внутренние блоки (header, main, footer) и другие должны быть выравнены по центру и они то и должны тянуться


Yeah, we don’t have very consistent rules with respect to self-closing tags and stuff like that… so, for now, write them whichever way you want :)

(I’m totally in favor of more xml-y style, though :D)


Sorry I missed this change: You have set the ignore_discard property to False for this save. Nice work :)


Thanks -- that sounds like a good approach!


try catch and log have been handled in MonotonicTreeMap
    var ex = new ArgumentException("Attempt to re-add: [" + key
                                                   + "]\n old value: " + val + " new value " + value);


I am not entirely sure I understand. Do you mean we should just replace all the rc examples with rs and not have the rc examples at all?


This is actually no longer necessary since `getAvailableMeasurementNames()` now uses the configured ordering. See https://github.com/phenotips/phenotips/commit/e2df2e1fb7b2a040676446193051ee7ab8cae357#diff-9ae230be19931ef6ecf69450de5dec77R98


Now its OK.


:)

On Wed, Feb 10, 2016 at 3:48 PM, Frank Cornelis <notifications@github.com>
wrote:

> Cordova is indeed new to me. :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/MobileChromeApps/cordova-plugin-chrome-apps-usb/commit/ab5a8c217f8fd3b23be56d35556032f497a9af9c#commitcomment-16016806>
> .
>


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1545 of 1545 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


тут хорошо, толь 1+ лишняя, зачем она?


Ok, I have addressed (or commented) on all of your comments.  I have clang-format-ified the code and rebased from current master.

Thanks!


Really the 10m just limits the in-memory keys, which at about 80,000 is plenty.


A node that is legal in this position. For example, it is invalid to have an `IfStatement` on the left-hand-side of a `BinaryExpression`.


а двухмерный-то зачем? )


Why? It's working, isn't it?


> This only holds if the users don't set --selector, right?

This is true even if the --selector flag values are not supplied. For example using the selector from the existing replica set or deployment.


Boo, this whitespace is unintentional.


Thanks, i will try to do it tomorrow.

If only we had a 3.4 kernel, that would be amazing !
We would need a great debug setup to make 3.3 or 3.4 work ... I've also found a 3.0.101 nexus kernel with a lot a fixes from linux 3.4 : [https://github.com/zzpianoman/android_kernel_samsung_tuna](url)

I will try to cherry-pick some of his commits to see if you can get something of it.
Right now i'm trying to port JIT compiler for packet filters on ARM (07ac34e61ffe526609387f074016f65f8bd3c1f9) but i'm still getting build errors.

I guess the easiest way to have a better kernel is to port some specific features.


кстати с box-sizing: border-box проще считать внутренние падинги, так как они включены в ширину. Здесь в резине это стоит использовать


Returning an error to the client has been problematic in the past as well because different clients send different garbage. For example see joyent/sdc-docker#52. But sure. We can blow up here instead.


I felt `Map<any>` was more type-safe than `any`, but regardless I need to cast `node` so that I can index into it by property name.


On my side I do prefer code readability when the cost is next to nothing especially when it is in a code path that is not taken often (which is our current case)


Sure. Thanks.


Good Good :+1:


No se que me pides pero ya estabas en el repo mio en el README. Lo que procede es que actualices tu repositorio con el repo mio si quieres tener lo ultimo. Estare haciendo cambios introduciendo alumnos y eso te obligara a actualizarte periodicamente


you can define a range with `# Start ignoring PyImportBear` or you need to have this comment above *one* of the affected lines of the diff. Question is how that move looks in our diff so a range might be better?


I've added an example about how to scrap a page - it is called "page-scrap.php". Thank you!


нехорошо так - один экстендер генерирует данные, а второй - считает контент. Как-то оно не очень логично.


@sgdc3 I hope the changes are OK (and desirable), otherwise please revert/adjust. I just got sick of a) seeing the "build failed" badge because it was referring to the Xephi/AuthMeReloaded repository and b) I got tired of always scrolling down for the links because of the large Gource image :P


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Used the STAR module of Extract, resulting in 12, 050 classes
For info on ROBOT Extract:  https://github.com/ontodev/robot/blob/master/examples/README.md


This could use `g_autoptr()` too now.


Also btw:
```
$ git rebase -i master
pick 6b2980ac4f8e added wikifolio signature
fixup fba68dd62da7 fixed wikifolio <a>
fixup 372a7c9a6417 fixed 'by wikifolio' link (again)
$ git status
Your branch and 'origin/wikifolio' have diverged,
and have 1 and 3 different commits each, respectively.
$ git push -f
```
squashes the commits together for a more overseeable history, if you want


> Can you update the usage message of selector flag too?

Done.


Ты имеешь в виду то, что у меня не соблюдается порядок, т.е. в выводе нет результатов со значением False/None?


Renamed.


Most people are using ReplicationController today. The right move for many/most of those users will be to Deployment, not ReplicaSet. We'll need to talk about how to roll out this change before we do it pervasively.


do not work... also with qm files in the directories.
should we include the qm file in the dependencies?


I don't understand this; it seems like a bug in the python bindings that it's unref'ing them?


that's excellent.  v1.0.1 was released *12 hours ago*.  when i tried using 1.0.0, it was borked pretty badly -- upgrading to a fixed version is *great*


_Rewrite of this block starting from line 528._
```javascript
var attempt = function(count) {
	var nextAttempt = function() {
		if (count < options.retries) {
			attempt(count + 1);
		} else {
			reject.apply(null, arguments);
		}
	};

	var delayed = function() {
		var config = _qz.tools.extend({}, _qz.websocket.connectConfig, options);
		_qz.websocket.setup.findConnection(config, resolve, nextAttempt)
	};
	if (count == 0) {
		delayed(); // only retries will be called with a delay
	} else {
		setTimeout(delayed, options.delay * 1000);
	}
};

attempt(0);
```
I didn't like that you have a 'standard connection' call separate from the retry calls, since it could be considered one of the tries.
This block also removes the delay on the first connection attempt (since qz could already be running), but will keep it on each retry. And since retries are after the initial try, a retry of 5 will effectively make up to 6 calls to connect.


Ok, got it - So if the exclude_tile_edge option is intended to only drop segments from clipped geometries one could be more strict and require that the lines are parallel to the edge.
@tallytalwar could you test if this works as well?

```
_a.x < tile_min.x + tolerance && _a.x == _b.x || ...
```


Right, is https://github.com/MichaelMraka/libhif/commit/044a3459642c8a873a097c976403431b24cfa128 still needed then?


An improvement of the filtering: now it is possible to provide a filter consisting of multiple QNs referencing columns from the .states file.


Нет. Если ты опишешь своими словами поведение твоей функции и сравнишь его с тем, что она должна делать, ты поймешь, в чем дело.


done


contenu while be moore global than texte, beacose some time size string can be numbers


If it is fast enough then we can avoid it. Less things to maintain :)


fan instead of gan


It is strange that it does not work, given my interpretation of Qt documentation, putting the qt_LL.qm in the same directory as the exe should work. We should try tomorrow also on OS X. If it does not work, yes we can include them in the resources.


@bgrant0607 Ack. Makes sense.


Since you are in BibCheck and you already have the record at hand it's much better `iterfield`, which is simply performing a loop in the given record representation. `get_fieldvalues` would instead query the database and hence slow down and impact on the system.


Int to float is a widening conversion, float to int is a narrowing conversion and currently unhandled by the compiler, though built-in functions can be used, the compiler can probably use bitwise ops


Cinternship:

The bridge for students across the world to intern in China


I don't know if Mono.Cecil offers a definition for ArrayTypes.

The generated fallback reference (fbgenMethod at the end of this method) should handle such cases and only depends on the references, not definitions. There's a risk of broken references, but IMO it's worth to take that risk when handling "unfindable" methods. The decision was made for MonoMod; suggesting and taking an alternate approach is welcome.

What does the FindFNA call return? It should return the ArrayType. It's possible that the Module.ImportIfNeeded(foundType) call in FindFNA(TypeRef) may "kill" the array type.


TeamCity Open-source Libraries :: ConfigInjector :: CI [Build 2.0.504.0](http://build01:8888/viewLog.html?buildId=14188&buildTypeId=ConfigInjector_CI) is now running


I'm sort of curious why this needed to be done in the macports version.  There's quite a few more of these that they either change or comment out entirely.  If they are building with wxMac 3.0, then __WXMAC__ should still be defined...sure, it is considered "old" and we should probably change them all to __WXOSX__ or, more precisely, __WXOSX_COCOA__.


TeamCity Open-source Libraries :: ConfigInjector :: CI [Build 2.0.504.0](http://build01:8888/viewLog.html?buildId=14188&buildTypeId=ConfigInjector_CI) outcome was **SUCCESS**
Summary: Tests passed: 38 Build time: 00:00:35


Correct. The code overwrites the name with the alias so you have no way of telling whether the name is the original base column name or the alias.


The idea here is to not have any integer instructions, treat int as int24. If integer instructions ever happen, int32


```python
from invenio.bibrank_citation_indexer import record_duplicates_in_asana
record_duplicates_in_asana(match, recids)
```
Where "match" is a string that should hint to the cataloguer why you think 2
records are duplicates (e.g. could be a DOI or the title of a journal or ...)


future


There are some instances where we need to transform a single node into multiple nodes, such as with a `ClassDeclaration` with decorators or static initializers. When visiting a `NodeArray`, this is not an issue as we can merely spread the new statements into the array. However, some nodes like `IfStatement`, `IterationStatement`, etc. take a single embedded `Statement`. In those cases we need to convert the multiple statements into a `Block`.

The `liftNode` function (https://github.com/Microsoft/TypeScript/commit/c3faf0f34efd6a54d12f2f9f64c330523365327e#diff-25d8529c0c0061fafa4aa188cab43277R746 below) returns `undefined` if the input is `undefined` or attempts to convert the node using the supplied `lift` callback if it is a `NodeArrayNode`; otherwise, it simply returns the input node. There's no failure case in `liftNode`, so if it returns `undefined` that is an expected return value. Instead, we fail on line 500 if we did not indicate that the node is optional.

The `NodeArrayNode` is a transient node meant to allow a visitor to return multiple nodes in place of a single node.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1363](http://teamcity.monogame.net/viewLog.html?buildId=14747&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:19:21


Tests fail, I think you have a duplicate ${files[$i]}


Was testing something


Well, that would be an API change. Which we can do, just need to think about it.


У меня для каждого элемента выполняется функция fn и если она принимает значение "истина", то записывается в список, который в итоге возвращает функция... Написал я, и тут до меня дошло )))


Although BibCheck was designed precisely to create tickets in RT (e.g. one ticket per rule, or one ticket per record). But I understand this is much nicer to have all these duplicates nicely handled in one place in Asana.


Hi

Thanks for the Pull Request.

Could you explain to me the advantage of this change?


Ok.


we all


Also please add me here.


- pongo `None` en vez de `{}` para evitar [mutable default argument](http://docs.python-guide.org/en/latest/writing/gotchas/)


cambio la [forma de pasar los parámetros](http://docs.python-guide.org/en/latest/writing/style/#function-arguments) en la llamada de posicional a clave


an*l


test leaving a comment


FindFNA does find Texture2D[], so the issue appears to be in Module.Resolve(), which is what findTypeRef.Resolve() ends up calling by the end.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15303](https://teamcity.mesosphere.io/viewLog.html?buildId=131668&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:03


you can only add the if in the tag, instead of have to tag declaration


размеры не совпадают с теми что на макете. проценты считаются от ширины родителя. Пересчитай все остальные блоки тоже (ни один не совпал практически).


LGTM.


jgalar a une autre syncope


OK, I'll make it so that it is never introduced on the rebased branch in that case. (We won't second guess ourselves about it when going back through the project history if it's never added to begin with vs added and then removed. i.e., we'll wonder why at a later date, just like I am doing now)


I see that lua jit can't inline the "..." arguments, nor anything with select().  I think that's what you're trying to avoid.  I see the point there, so let's go with your technique for now.

One small suggestion is to use a reusable metatable for these objects.  We can avoid having to construct it each time.

E.g.

```lua
local _hx_obj_mt = {__newindex=_hx_anon_newindex};
//...
local x = setmetatable({__fields__={y=true},y=nil},_hx_obj_mt);
```


I think we're good to re-integrate now. Please pull if you agree. Thanks.


112331505_SurfaceHeightRange (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1530 of 1530 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.7%25-green.svg)


Remove: trace is already valid DUH


HBIRE_vector_take2 (amirroth) - x86_64-MacOS-10.9-clang: Tests Failed (1554 of 2074 tests passed, 3 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-74.93%25-red.svg)


may be here should be equal zero?


я не знаю что я курил когда писал это)))


I don't think it's an issue, but if a non-payment transaction ever had a DeliveredAmount field, this would add a delivered_amount field to the JSON for that transaction.


Я понимаю ты устал переделывать. Но атрибуты href у ссылок надо будет поправить.


Watch out this should be for the 1.2 docs, not 1.0 which should be left alone.


Ugly place, is needed for requiring module from preset's node_modules directory.


As Stef says, the doc directory remains 1.2.

I think where we go adding new APIs we should explicitly say "since 1.2.1".
On 10 Feb 2016 6:53 pm, "Tako Schotanus" <notifications@github.com> wrote:

> Ok, I didn't know, but aren't we making some pretty big changes that could
> affect documentation? The whole system of up/downgrading versions was
> introduced in 1.2.1 and is not part of 1.2.0, if someone wants to look at
> the docs for 1.2.0 they'll be getting all kinds of stuff that won't exist
> in their version.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ceylon/ceylon/commit/496a2499f34a30e18bdacf99e5a50dce4c713245#commitcomment-16013895>
> .
>


> I think the new OpenTK central should be distinctly recognized as a successor of the project.
Something akin to OpenTKReborn.com for the domain name. The project could still have the same name as before, starting with version 1.1.5. or 1.2.0.

That "reborn" term in specific sounds a bit cheesy to me, but I get the idea and we could probably find something more fine-tuned along those lines.

Still, maybe we should pick a distinct name and then add something like "A community-driven OpenTK derivative" and link back to the original to draw a clear line: OpenTK may be gone, but now we're on stage 2 with project Foo. Maybe we could also fork from `opentk/opentk` and rename the project later, so we'd have a `foo-team/foo` repo with a GitHub-generated "forked from `opentk/opentk`" link beneath it.

I definitely like the old name, but I'm a bit conflicted about sticking to it as well - even if it's just because it can lead to people asking "which one?" when telling someone you use OpenTK. It could also lead to irritations among new users when they google how to do X or Y and they find stuff from a framework with the same name that's very similar, but seems (?) to be something else, because there's this old domain and some different GitHub project.. you get it. A new name would also open up a new conceptual space, which might be a good thing.

But then again, I'm conflicted on this.

> I would really like if the new name was an anagram.

Incidentally, another anagram of OpenTK is "kept on". The project that just kept on going. We could rename our efforts to "Kepton" and then choose some kind of elemental particle as a logo to make it less cheesy. :smile:

Anyway! Joking aside:

> How about Token framework?

Token. I kind of like this.


for python, they are converted into dictionaries right?


sure 👌


Дивы подвинь на 2 отступа левее, как будут силы


Nice!


Does [this renaming action](https://en.wikipedia.org/wiki/Rename_method "Renaming of function names") try also describe that you would like to change [the application binary interface](https://en.wikipedia.org/wiki/Application_binary_interface "Description for application binary interface usage") for one of your evolving libraries with the next software release?


loc


Ah nice...I did not know that function existed - I only tried to use `np.seterr()` as a context manager which naturally failed...


fixup


:thought_balloon: This is a really nice pattern


AAHHHHhh :angry:


this function should be moved out as `execute_coala(args, function)` while the parameter `function` could the be given as e.g. `coala_json.main`, then this function can be used by both tests


> I didn't like that you have a 'standard connection' call separate from the retry calls, since it could be considered one of the tries.

I didn't like it either, personally.

> This block also removes the delay on the first connection attempt (since qz could already be running), but will keep it on each retry. And since retries are after the initial try, a retry of 5 will effectively make up to 6 calls to connect.

That's fine, but now the documentation should change to specify that such that if someone supplies delay without retries, it never uses the delays.

I guess it depends how you look at it... even in our example, we don't offer the reconnect option unless the software definitely is **not** running, so the original logic makes an assumption that the delay actually is needed on startup, but I don't mind this new logic either.


How about adding an operator * for this?


The ugliest line in the world, but is needed for requiring module from preset's node_modules directory.


This looks great, Cynthia! Did you have a chance to work on the CommentingOnCodeExercise as well?


irrelevant testcase for coala-json


112331505_SurfaceHeightRange (Nigusse) - i386-Windows-7-VisualStudio-12: OK (2080 of 2080 tests passed, 0 test warnings)

 * 6 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


irrelevant testcase for coala json


irrelevant testcase


yeah.. its map.. ill update..


This commit is in the releases, but not in `master`...?


I think there should be a copy constructor here as well which does an inc ref.


It's used in TauP somewhere... :wink:


Remove, see assertions above


This looks great, Tami! I knew exactly what was going on in the code through your comments.


Won't this wipe out all validations prior to the new version of rippled that adds the new columns?

I thought we were going to have 2 queries--the 2nd one after the first, which checks InitialSeq for NULL.


#4 finished


dangnabbit


что-то с отступами


Yes, I did.  I'll post it there as well.  Thanks a lot!

On Wed, Feb 10, 2016 at 1:14 PM, Samantha Powell <notifications@github.com>
wrote:

> This looks great, Cynthia! Did you have a chance to work on the
> CommentingOnCodeExercise as well?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/samnpowell/RADDevDivas/commit/c71bd74dc78cb30f246ad9c9e8d228fce5f38f74#commitcomment-16017416>
> .
>

--
*Cynthia Saalfeld*

(415)690-5589

[image:
http://vnfa8y5n3zndutm1.zippykid.netdna-cdn.com/wp-content/uploads/2011/12/url7.jpg]
cynthiamm@gmail.com

www.linkedin.com/in/csaalfeld

@CynthiaSaalfeld <https://twitter.com/CynthiaSaalfeld>
salesforceambassador.com


отступы


once a method hits `return`, that's it. it exits.  there's no use putting anything after the return statement.


This introduce non-free crashlytics software. Could you provide a build withoit proprietary stuff?


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1526 of 1526 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I'm wanted to try to run debian chroot with your Recipe, however it fails early on in the recipe with:

ls: cannot access /tmp/10398/union/mnt: No such file or directory
Could not find free mountpoint

so it seems the mount is not working.  Here is text of all terminal output when running from Trisquel 7 (Ubuntu 14.04 LTS) x86-64, but I also had that same mount error when runing from archlinux x86-64:

[testappimage-debian-x86-64_from-trisquel.txt](https://github.com/ericfont/MuseScore/files/125507/testappimage-debian-x86-64_from-trisquel.txt)

So then I tried using the CentOS 6.7 x86-64 LiveCD, but it seems to fail when install automake & autoconf:
[chroot-CentOS-x86-64_from-trisquel.txt](https://github.com/ericfont/MuseScore/files/125508/chroot-CentOS-x86-64_from-trisquel.txt)

Once I get past those errors, I'll get to making a jessie recipe.


You're re-defining the $validator variable on the next line.  This line doesn't do anything.


здесь урл начинается от `/`, а ниже — от `../../`. должно быть консистентно


I think we need to treat temps like anything else.


You should aim to make your `js-` classes specific. Consider changing these to `js-picture-name` and `js-picture-link`.


so the basic testcases aren't really relevant for coala json, we want new tests for json. We want tests that test that the json output works correctly, not that coala does the right thing. We know that because of the other tests!


oh, i thought we should the empty view on _top_ of the table view (i.e. not as a subview). i guess this isn't possible in a `UITableViewController` 😔


уже писал, что скрипты стоит подключать в секции scripts (как это и делается чуть ниже), чтобы они не блокировали загрузку страницы


Should  "USE_NATIVE_LIBRARIES" section be added?  In chance users compile HPCC on other Linux Distributions or OS which CMake supports.


Nested `<section>`? Is this intended?


dictionary -> dictionaries


должен быть массив:
```js
scripts: [
    { elem: 'js', url: '...' },
    { elem: 'js', url: '...' },
    { elem: 'js', url: '...' }
]
```


The class name should match the name of the file. In this case, you're missing an `s` after `Image`. Though, given that your model is named `Picture` instead of `Image`, you may want to rename both the file and the class to use `picture` instead of `image`.


i thought if object_class was nil we'd need to auto-inflate and throw deprecation warnings, and so the `#from_json` call should still be preserved in order so that external consumers that didn't pass an object_class wouldn't break?  i don't see any way we can throw a deprecation warning now which seems incorrect?


on my system it would crash if I removed the comment. with branch inputstream


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15304](https://teamcity.mesosphere.io/viewLog.html?buildId=131705&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:04:57


you don't have $page here, so you can't use $page->id.  You only create $page on line 131 if the validator passes, and if the validator passes we don't end up in this else statement.


this is a dictionary right? as it refers to the input record.


emit zero or more transformed dictionaries, or emit an error dictionary using the provided emitter object


importAssetsFor what?


This takes you to the page you just created


Apparently `translate_tabs_to_spaces` does not work on sublime-settings files :panda_face:


Should we prefix this with `DOKKU`?


But the sentence starts with the plural 'Input records', so dictionaries has to be plural.

Perhaps a better edit would be "Each input record is converted into a dictionary ..."


`sleep`s in tests are a code smell. You can avoid this if you use one of the capybara methods that has some waiting built into it, such as `page.has_current_path?`


Nice job, Tami! I noticed two things:

1. In the conditionalsExercise method on lines 103 and 107 you were exactly correct in your conditional statements. It would have been wonderful to see you practice declaring and initializing variables to do the comparisons instead of hard coding values.
2. On line 171, your system debug statement is 'myStringListPos2' - I love how you're thinking like a developer and numbering everything from 0!!


если библиотеку можно установить через `bower`, нет смысла коммитить ее код в проект (аналогично не коммитится код библиотек `bem-core` и `bem-components`).

если пока ее нигде отдельно нет, то достаточно создать для нее отдельный репозиторий, `bower` поддерживает `github` как источник


Ideally the default should be sorting by value, in _descending_ order... I'm drawing a blank on what the proper syntax is for this... But ascending by value isn't much of an improvement over alpha, is it?


йоу! попробуй теперь слить свои правки в эти файлы
хочу понять как изменения будут объединяться


Consider explicitly returning either null or undefined here.


OK, I understand.  The main reason I'm making the recipe to run on x86 Jessie is because I can get work done much faster on my x86 machine.


`page.driver.browser.switch_to.alert` is duplicated on the previous two lines. Consider saving a reference to the alert instead.


MT cache is accidentally rejected, for now. I must fix class constructors, you see "self = hx_empty, getmetatable(self)._index = fun()" this brokes one globally cached shared metatable.
Will fix today.


113008903Provide-a-better-warning-message-for-a-triangular-window (lgu1234) - i386-Windows-7-VisualStudio-12: OK (2080 of 2080 tests passed, 0 test warnings)

 * 6 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


отдельно можно подумать над вариантом включения кода `coverflow-container` в общий собираемый бандл с помощью `borshik include` (см. https://ru.bem.info/articles/borschik/#js)


Sorry, I didn't wanted to created a merge commit.


okay.


BTW LuaJIT will inline tail call so we can use _hx_obj({}) short syntax


## Task 1

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly demonstrates the use of **chained conditionals** to accomplish a task (2 pt)

## Task 2

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly uses recursion to sum 0 to 1000 [inclusive] (2 pt)

## Task 3

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly uses recursion to compute `e` (2 pt)

## Task 4

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly accepts (and uses) the user input value for the maximum of the range over which to compute `e` using the `input()` function (2 pts)

## Task 5

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly accepts (and uses) the user input value for the maximum of the range over which to compute `e` using the "argparse" module (2 pts)


Use bt_ctf_stream_class_get_trace()


I think it would be easier to browse if the titles were alphabetical


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15305](https://teamcity.mesosphere.io/viewLog.html?buildId=131707&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:05:01


This selector is duplicated on the previous two lines. You could save it in a variable instead...but you could also just remove the assertion because this line would fail if that selector does not exist.


static const char* ?? No Idea what the compiler is doing with this one.....
Does this maybe solves the segfault?


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (977 of 977 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-28.31%25-green.svg)


Again, we should avoid `sleep` in our tests so that we don't waste time unnecessarily.


What I mean is that we don't need to have the structure we currently have, which is basically:

```java
try {
    if (condition) {
        value = talon1.get();
    } else {
        throw exception
    }
} catch (Exception e) {
    e.printStackTrace();
    value = talon1.get();
}
```

You could basically do:

```java
value = talon1.get();
if (condition) {
    System.out.println("Something has gone horribly wrong!");
}
```


Consider first submitting an invalid tag list and then a correct one, so that you verify that the edit can succeed after first failing.


Thank you, Andriy for the very quick fix!


I think, that [@(intNumber) stringValue] would be better, when both current variants.

Do you agree?


Looks good. Can we also remove the 0 initialization below the memset, they are now useless.


I pushed a fix to master that fixes this issue.


I'm curious...why did you move this test?


Simba doesn't care about the original column name. I sent them an e-mail asking this specifically and they said they just want the column alias.

The purpose of having `qualifiedOriginTable` is to attach the origin information to a field and have that information follow that field until the output (unless the field is an input to an expression, in which case all bets are off). The `relationAlias` field in the `Field` class gets overwritten when a column comes from a subquery. You still need the `qualifiedOriginTable` field even if the relation is not aliased because, prior to this commit, the `Field` class did not carry any information about schemas or connectors. I don't know how to better explain this so if you don't understand I'd be happy to explain in person.


"Zoom to extent" only works on layers loaded on-demand. You should be able to reproduce this issue by clicking "zoom to extent" on "Hurricane Sandy/Hurricane Sandy..."

At this point, `layer` only contains fields that were defined in layers.json (the service data has not been applied yet) so `layer.getServiceId()` will always return `undefined` here. The only solution I can think of is to modify `getLayerDetails` to accept `serviceLayer` as an argument and pull the id from there.


Right, there is a similar problem here as above. In addition to your comment, `angle` could also be zero, causing a division by zero here. I'll prepare a patch to handle that here too.


"show pictures with one tag" is a bit ambiguous: it could also be interpreted as "show me the images that only have one tag", but i think you're intending to test filtering the images index by a tag.


Thanks, I'll add that.


I was thinking the feature flag would be the opt in, not the opt out.


Hey @levity obv this is a temporary hack. It's so that Ed can use this tool before we build the admin login for redux.


I tried to arrange the methods by alphabetical order.


I asked Simba what the value for these should be in the case of an expression and they said they wanted the empty string.


Precisely. In the commit that Sarah and I paired, we rename the methods...


And really, this should never affect control of the robot anyway. This is just getting a value from the Talons, so if we've actually screwed up enough to be setting the Talons in a `TalonGroup` to different speeds, then we don't need this method to tell us. We'll know :smile:


I don't see how this could happen.


My bad. I thought those two layers weren't implemented because they are "combined" layers so I didn't test them. I'll take a look.


Let me guess... hacking to make a server binary?

Look to this environment variable and redesign accordingly:

https://github.com/FNA-XNA/FNA/wiki/7:-FNA-Environment-Variables#fna_audio_disable_sound


#165 Did I break stuff?  I just acted on my coffeescript linter saying this was an unnecessary double arrow. Where is the shell symbol defined?


The differences between `Engine` and `Railtie` are exactly the extra functionality :smile:.

We can't use a `Railtie` for Action Cable because it includes JavaScript code. The main difference between an Engine and a Railtie is that Engines can have models, views, controller, helpers, initializers, migrations and assets. We need assets support for Action Cable.

I explained it here https://github.com/rails/rails/commit/ff370ee61754b00f864f3ddd0af62be4dfa0de67


Hmm, here's a rough outline of what I would test about the index page:

1. Go to the index page
2. Assert that all the image URLs in my database are shown
3. Click on a tag to filter the index by that tag
4. Assert that only the image URLs for images with that tag are shown

which is a bit broader than what you've tested here.


wraios manmu


You are right. I didn't realised that this could be a concern for some people. At the same time, this kind of tools is absolutely necessary to produce quality software and Acralizer was incompatible with this update for some reason.

Do you have any clue that could help me find a similar powerful open-source, free and respectful library? (and maybe let more freedom to the final user and let him choose which information we wants to send)

Thank you for your report and for pointing out this topic.


Yup, I understand what you've done/why.  I'm trying to understand the reasoning behind the requirements.  It's not really related to your code.  Reading the implementation just made me think about it more.


`finalUri = path.relative(eyeglass.options.eyeglass.assets.relativeTo, assetUriInfo.path);`
do it here instead


I can confirm that this error handler executes if there's an exception in the previous callback in the promise chain.


You could add an assertion about the contents of the tag list shown on this page.


Make sure when the user sets values for hours, minutes or seconds, that you check if it's a valid number for each of those variables.


Looks good to me.  It's probably important to note that if the image has snapshots, this will be a potential underestimate the usage if the same backing object was re-written across snapshots.

How often is volStorageBackendRBDRefreshVolInfo invoked?  If it is invoked on every image in a pool and each image has a lot of snapshots, this could take a long time to compute.


voyons donc


Admin login goes directly to the Node backend though, so you can go to next.hylo.com/noo/admin/login to get the admin flag on the session. It redirects you to www.hylo.com, but that's not a problem. You can confirm that it works by hitting next.hylo.com/noo/user/me and searching for is_admin.


If you have to use javascript crypto, it would be better to use https://www.npmjs.com/package/chloride
that gives you a consistent interface to libsodium, either the sodium bindings in node (if you can compile it) or the ecmascript compiled version when you in a pure js enviroment. It's the pure JS version is pretty fast in firefox, because it has the optimizations for asm.js.

This would mean using ed25519 instead of RSA, but this is a kind of decision change you can easily make early in development. And ed25519 is considered by many to be the best option currently.


The commit description says "Clicking on the ellipse icon..." which isn't true anymore.


For sure  we're pushing right now


LOL that is a misuse of pexit(). Use error() instead.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15306](https://teamcity.mesosphere.io/viewLog.html?buildId=131720&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:04:57


@adamhundley iteration 8 is required


UPDATE: Running "make clean" before doing "make portable" produced a valid stripped mscore-portable, and ./AppRun works.

I think my problem with the stipped binary arose because I was alternating between running commands make portable and make release and maybe a regular debug make (and I was also deleting the mscore binary sometimes in between, to prevent the make file from remaking everything).  So probably what I think happened is some of the .o from different builds got mixed up together and linked in a manner that they shouldn't have...although I don't know the exact steps I did to get in this situation.


@mgold YUP YUP YUP (also, your Invitation To Another Dimension is featured on it, now!)


Test.


113360729_HumidifierOASys (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2114 of 2114 tests passed, 0 test warnings)

 * 6 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


You're right, this will never be `null`. I'll update accordingly.


To answer the comment...no, I don't think so. See my previous comment for how I would've avoided the sleep: https://github.com/AppFolioOnboarding/Haomin_ImageUploader/commit/f965fc50a51c7ab215eed83d8f786dc572a939ca#commitcomment-16017595


clang disagrees about math.h vs math:
cpp_code/src/State.cpp:21:10: fatal error: 'math' file not found

#include <math>

re assert, 648ec22
<https://github.com/probcomp/crosscat/commit/648ec2220d82e1ed9f9741333ef71449f15219f5>

--
Gregory Marton
--
gremio@mit.edu
617-858-0775
http://csail.mit.edu/~gremio/cal


Te entiendo, lo cambio y subo cambios en cuanto pueda ;-)

A ver si se puede quedar "perfecto" de una vez por todas 20up... Muchas gracias por tu colaboración :D


Oh, the horizontal line case is fine. Indeed `angle` will become 0, but we will always snap to the left or right boundary for horizontal lines, so we never reach this division. Now only the issue you mentioned remains.


For `build` I wrote a little script to generate this file, so you don't have to keep it up to date. https://github.com/dart-lang/build/blob/master/tool/create_test_all.dart


It gets set after the analyzer, which is too late for me. Probably in the cli. I'm grepping through the codebase right now to figure it out. The fields coming out of the analyzer are nameless.

The naming scheme for selecting nameless columns is _col{idx} so I'll update my code to be the same.


Is it necessary? Because, again, for each sensor, it will create a request to the db, parse all the samplings into models. And then count the collection...


Yeah, just saw that.


Another thing that happens when not debugging the VS instance: https://github.com/icsharpcode/RefactoringEssentials/issues/174


watch your indentation here, `<body>` and all of its children, should be indented one in


in HTML any time you provide an attribute value (like href="..."), the value should be in DOUBLE quotes, not single quotes.


Question, is it significant/intentional that this is an Int32 in AppFetchRequest, but Uint32 in PutBytesAppInit?


this is working now, had to add order

later:
            filter: { $zoom: { min: 14 } }
            draw:
                waves2:
                    color: [1.0, 0.970, 0.970]
                    order: 6


It would be better to just remove the alert (or change it to a `console.log` for now). That alert is not intended to be a real part of our application; it was just a way to demonstrate that ES6 was working.


Will talk about this more in Lesson 4, but when you assign classes, the class name must be in double quotes, so `<div class="container">`.


It gets added in the `LogicalPlanner`.


I see. It would be better to move it in the commit that introduced it, so that the commit diffs aren't unnecessarily complicated.


images/Julio Almanza _ Portfolio_files/styles.css

When you provide the URL for an image, it's a good practice to provide the URL within quotes, so `background: #1695CE url("../images/Metal-background-5.jpg");`


According to our internal documentation, it is correct; app IDs are signed in appfetch but unsigned in putbytes.

I couldn't comment on why this is the case, though.


You should make it clear that while canvas, resize, clear, and context2d are functions you can call, redrawCanvas and onAnimation are callbacks you can set that will be called on certain conditions. Listing them all together like this is confusing.

Also, you might consider instead of having the dev set the callback properties themselves, having them pass those properties into the `canvasOverlay` call in the first place. That way your API doesn't involve directly manipulating properties (which can paint you into a corner later).


113360729_HumidifierOASys (Nigusse) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15308](https://teamcity.mesosphere.io/viewLog.html?buildId=131726&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 223 Build time: 00:03:57


I mean I would escape additional conversion to NSNumber (`NSUInteger -> NSNumber -> NSString`) and go right `NSUInteger -> NSString`


Oh, ok. I understand you. I will make it a bit later.

> 11 февр. 2016 г., в 0:43, Dmitry Korotchenkov <notifications@github.com> написал(а):
>
> I mean I would escape additional conversion to NSNumber (NSUInteger -> NSNumber -> NSString) and go right NSUInteger -> NSString
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/Werbary/metrika_ios/commit/253c5c4f287950039ffe1fcb2d4ef795964878f1#commitcomment-16018157>.
>


Shouldn't it be string?


I agree that the purpose of the requirement is unclear. I decided to trust Simba. Maybe I should send them mail asking whether it is really necessary?


Why the string cast?


For that matter I'm a little unclear on why the API needs 2 callbacks...how about just a single `onRedraw` that gets called whenever the canvas needs to be redrawn?


Good catch @dmmiller!


Cool, thank you.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15307](https://teamcity.mesosphere.io/viewLog.html?buildId=131725&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:11:19


Fair enough. I'd like to consider this for a future PR though if @adelevie and all are okay with that.

Here is the [relative reference on nesting](https://pages.18f.gov/frontend/css-coding-styleguide/specificity/) that @msecret was referring to


A couple of extra comments -- it's a good practice to keep everything lowercase when you are naming folders (noticed your CSS folder is capitalized here).  And I see there are extra files in your images folder -- that's totally fine, but try to keep things organized and delete any files if you aren't using them anymore.

Overall, really great job with this!  I would have loved to see you apply the same dedication in styling to the portfolio page, but I totally get feeling a little overwhelmed/psyched out at the beginning.  Next time, recognize how much progress you're doing and feel free to check in whenever you need a second pair of eyes!!


well, never mind then

On Wed, Feb 10, 2016 at 1:35 PM, Lawrence Wang <notifications@github.com>
wrote:

> Admin login goes directly to the Node backend though, so you can go to
> next.hylo.com/noo/admin/login to get the admin flag on the session. It
> redirects you to www.hylo.com, but that's not a problem. You can confirm
> that it works by hitting next.hylo.com/noo/user/me and searching for
> is_admin.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Hylozoic/hylo-node/commit/cd4eed5a1129d60f91e803c153be98b869f06387#commitcomment-16017913>
> .
>

--
Robbie Carlton

719.358.3482
<robbie@authenticmanprogram.com>


Corrected.


I think you could add:
`FlxRainbowEffect` (replaces `FlxRainbowSprite`)
`FlxOutlineEffect` (replaces `FlxOutline`)


This function should call your onRedraw callback if it detects that the size has changed (otherwise the app might not know). I suppose it should also call resizeCanvas in that case as well.


I'm getting an error "cannot find module passport." Do we need to install a package?


I know this is just a private function, but the name resizeCanvas is confusing. Maybe updateCanvas? Also, since it's private, I recommend prefixing the name with an underscore, like _updateCanvas.


Also, mainly in the sake of consistency:
* There should be a "replace first" function as well
* They should be methods of Str class, with helpers simply calling them


Cool !

You think you can put this plugin on composer as beta ?
I would start to use it easier, else I will clone it manually.


In HTML use `&` for & char


What is 'Deploy the virus' commit?


`FORM_DIRECTIVES` are not needed anymore. They are automagically there. :)


That being said, nice addition :)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15309](https://teamcity.mesosphere.io/viewLog.html?buildId=131727&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:10:40


can you use https://developer.mozilla.org/en-US/docs/Web/API/Node/contains instead?


Of course if resize automatically calls resizeCanvas if needed, you need some mechanism here that will call resizeCanvas if resize doesn't but not if it does...i.e. you don't want it to be called twice but you also don't want it to be called 0 times.


Ok, that makes sense.
On Wed, Feb 10, 2016 at 3:31 PM Ben Visness <notifications@github.com>
wrote:

> And really, this should never affect control of the robot anyway. This is
> just getting a value from the Talons, so if we've actually screwed up
> enough to be setting the Talons in a TalonGroup to different speeds, then
> we don't need this method to tell us. We'll know [image: :smile:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/frc-2175/2016RobotCode/commit/aa95fa3e9c03af52a896d8d13d6ad8f167c6e2a4#commitcomment-16017829>
> .
>


Je ne comprends toujours pas ce que tu veux: les tests passent tous. Est-ce que tu peux ajouter un nouveau test qui ne passe pas pour décrire le problème?


If you just pulled you need to rerun npm install to load the new module
On Feb 10, 2016 4:49 PM, "Kevin Utz" <notifications@github.com> wrote:

> I'm getting an error "cannot find module passport." Do we need to install
> a package?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kpu23/weat/commit/c013cf38b3db90d7f36726b65a7f3011ecae7a86#commitcomment-16018258>
> .
>


@khmarbaise Yes, agree, I just borrowed this style from a test somewhere around considering it's the convention. Here is the fixed commit: https://github.com/lyubomyr-shaydariv/maven-enforcer/commit/2723f8c2add0e832f9304720bae82d7cce0c4b76 . No test seem to be missed: 160 tests before and after the commit.


@iangilman I've wanted to separate them, so we can keep clear and drawing and further possible canvas modifications separate. Not sure if that was best approach though


I'm from the south, what can I say?


Looks OK unless build platform on Apple/Windows need NUMA.


You need to change this to your site domain. Maybe set this as a `ENV['default_email_sender']` and set the ENV variable in application.yml


It turns out that this problem is not caused by the snap to boundary component, but rather by the weight matrix component. I have pushed a commit that adds more unit tests for horizontal and vertical lines to ensure that this works as expected. The vertical line case is also fine as I confirmed this by manual calculations: even though the value here will be large, the division makes the adjacent side very small and Python will interpret this as 0 in the next line, so there should be no problem here.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15310](https://teamcity.mesosphere.io/viewLog.html?buildId=131736&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:00


ah, so that's how you refresh packages. I ran npm install passport, npm install passport-local which did the same thing I guess


(I will still look into the weight matrix problem though.)


:+1: i've done exactly same in my pr but for different purposes :D


I'd prefer to raise something more specific than Exception, but besides that this patch looks fine to me.


In this case I think the test should not fall back to sleep but use `count_subscribers`. Then the macros is only used once and get be put inline again.


If you use javaslang, you may use ```@Data(flavour = Flavour.Javaslang)``` to benefit from better integration from derive4j (eg, generated code will use javaslang ```Option``` instead of the jdk ```Optional```). (would have been the same with functional-java and ```@Data(flavour = Flavour.FJ)```)


did this happen after the tag?


mathieu aime po ça


ыпвап


I just removed the patch spigot(entity-update-cap) ))


Are they supposed to be? The FEMA layer has never worked for me.


Sounds good to me.  I hear only good things about ed25519.


Can't you fall back on the most general `collect` method? Since `next` already takes care of checking `cond`, this sounds like it would be more efficient (no need to allocate `result` and then filter it).


Why not the native is bind?


where is this property __moduleDirectory__  used?


This message is printed at configure time of CMake. Nothing is being built yet. So it is a bit misleading.


`trans::mir::analyze` promotes every temporary with an associated drop to an alloca, so it is safe to say that `TempRef::Operand` won’t ever get dropped, only consumed, and thus having it zeroed doesn’t really matter.


The following doc(s) have been deployed to the [workflowau](http://workflowau-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/sites/code/using-the-pantheon-workflow](http://workflowau-static-docs.pantheon.io/docs/articles/sites/code/using-the-pantheon-workflow)
- [source/docs/assets/images/deploy-live.png](https://github.com/pantheon-systems/documentation/commit/3501fa652136c076dfb44382d06e713198e0830e/source/docs/assets/images/deploy-live.png)
- [source/docs/assets/images/test-env.png](https://github.com/pantheon-systems/documentation/commit/3501fa652136c076dfb44382d06e713198e0830e/source/docs/assets/images/test-env.png)


I put this in for debug purposes and forgot to take it out.


Do you think it might be useful to do ti this way: https://github.com/pyr/cyanite/commit/2577dc05c4a7ecd76a9fa84a4ff668b690a5467c

It will allow for the inner-range queries, too, as a hidden benefit.


I think just FEMA is combined actually.


mhm, hmm... amusingly


@ZiperRom1 Done. You'll have to have `"minimum-stability": "dev"` in your `composer.json` until I tag a stable (should be soon :smile:).


> You're absolutely right! This will be really great to have because the reactivity can work with any data source by manually invalidating, but you can still get extra magic for particular databases like Mongo or RethinkDB.

This is crucial if we want to provide an upgrade path from many existing Meteor applications. And this raises a question: Could the invalidation server be horizontally scalable if it becomes a bottleneck?


Fixed


It's for searching in `node_modules` and `web_modules`


test comment


great approve!


Thanks I will rename both the class and the file


On that reference, it's not all nesting in sass, it's nested selectors.

So
```
.class {
  &.other {};
}

//compiles to
.class.other {}
```
which is fine.

```
.class {
  .other {};
}

//compiles to
.class .other {}
```

which is what to be careful of because `.other` becomes much more specific.


## Task 1

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly demonstrates the use of **chained conditionals** to accomplish a task (2 pt)

## Task 2

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly uses recursion to sum 0 to 1000 [inclusive] (2 pt)

## Task 3

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly uses recursion to compute `e` (2 pt)

## Task 4

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly accepts (and uses) the user input value for the maximum of the range over which to compute `e` using the `input()` function (2 pts)

## Task 5

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly accepts (and uses) the user input value for the maximum of the range over which to compute `e` using the "argparse" module (2 pts)


In that case, you could explicitly specify in the backend that these fields are special and should be fetched separately. So it wouldn't be fine-grained by default, but you could easily make it more specific as you identify some of these patterns.


Best. Docstring. Evah.


Yes, I know. But I was searching where the property is consumed, found it here: https://github.com/substack/node-resolve#resolveid-opts-cb :)


@trowski could you also make the alias versions, similar to other libs? https://github.com/assertchris/sunshine/blob/master/composer.json#L3-L4


I think this commit addresses all of the issues you raised with my earlier pull request. There's a corresponding update to vzome-desktop that uses this new version of vzome-core, but is mainly focused on improved logging.


Rename this to `checkAccountUidExists`. The function only checks the UID right now.


Are the values passed to this func guaranteed to be correct? You're ignoring err from both Parse methods, which I think would end up returning 0 and using all memory.  Shouldn't we scan for a %, then call either ParsePercentage() or ParseEngineeringNotation(), and if we get an error return it?


Yes, and?


The only way that division by zero could happen in the weight matrix component is when you place the source and the destination at the exact same point. Then the length between the two will be zero. Otherwise this should not happen because the length calculation squares the values, making them always positive, and thus addition could only yield zero if both components are zero, thus when the two points are equal.

Did you check if that cannot happen in your algorithm? If so, I'm interested in seeing the positions of the sensors that trigger the division by zero warning you mention, because I cannot seem to reproduce that with something else than having the sender and receiver at the same location.


Why unset the `uid` here?


Node actually saves dependencies in a packages file, like nuget. So if you
just run npm install without parameters, it checks that file and installs
all dependencies.
On Feb 10, 2016 4:52 PM, "Kevin Utz" <notifications@github.com> wrote:

> ah, so that's how you refresh packages. I ran npm install passport, npm
> install passport-local which did the same thing I guess
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kpu23/weat/commit/c013cf38b3db90d7f36726b65a7f3011ecae7a86#commitcomment-16018386>
> .
>


> This is crucial if we want to provide an upgrade path from many existing Meteor applications.

In my experience the overwhelming majority of Meteor applications don't rely on external updates to the database being reactive, but we should certainly make it possible to maintain that property.

> Could the invalidation server be horizontally scalable if it becomes a bottleneck?

Yes, the whole project hinges on making this invalidation server component be scalable to an arbitrary number of users. Which we think is a _much_ easier problem than scaling live queries on MongoDB.


This is very tightly coupled with the OFP  makefile include, and quite opaque, at least for the time being. It's hard to understand this makefile and all of it's targets without also having the include in front of you. In the current setup this looks like a decent candidate for git submodule or git sub-tree merge. I'll keep my eye on this as it progresses and think about what the best approach is.... maybe contributing a more "normal"/canonical build system upstream to ofp-sdf could help alleviate this. I'll think about it some more.


Nit: You can use the string.indexOf function here instead of a regex


you need to `deref` the atom here

otherwise you're comparing an `<Atom#jfkladj>` to 4. It's always gonna be false

It should be `(= @waiting-room 4)`


I do not understand, why this is?


ano binago dito?