Yes, I believe I followed the correct procedure. So here are my steps:
1. fork
2. git clone xxx.git to get a local copy
3. do some work, commit locally
4. git push [mybranch]

Are these the correct steps?

So right now this webpage here: https://github.com/whatwg/html/compare/master...xidachen:ImageBitmapSpecEditing shows the comparison between [mybranch] and whatwg/html:master, and I can create a new pull request from there.


Removed


TeamCity Open-source Libraries :: ConfigInjector :: CI [Build 2.0.533.0](http://build01:8888/viewLog.html?buildId=14391&buildTypeId=ConfigInjector_CI) outcome was **SUCCESS**
Summary: Tests passed: 38 Build time: 00:00:57


Fair enough, done


I think it's best to just copy the doc here.


Ive noticed we have multiple sources for providing values into our models, this shouldn't be the case and we should have a single source of truth for these sorts of things. I'll do some work to tidy these things up in another branch.


the cast to double for pixels is not needed, Math.Ceiling will give the closest integer, so after that you work with ints for pixels.


Yep, without it there's a lot of build breakage. Done.


I have tried this on HK 3700 and it seems to work fine. However, after issuing "off" the 3700 disconnects from the ethernet port and is no longer reachable, so after that it's impossible to make it wake up again via the ethernet port (as far as I can tell).


@steida So [you're](https://github.com/este/este/commit/6ab860dd1a113a31237f234a72427d7f736b851d) [reading]
(https://github.com/este/este/commit/b8705e49048dc94e8e0633b85f7729ebc96fbc35).

I'm a happy bunny :)


I changed the updating timing progress bar.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17208](https://teamcity.mesosphere.io/viewLog.html?buildId=145851&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:04:11


What is the reason for this return statement?
Returning at this location after handling the first * will leave all the other columns undefined. I have a view that is defined with SELECT a.*, [b].[col] FROM a INNER JOIN b ON [a].[col] = [b].[col]
With UCanAccess-3.0.3.1 I get all columns of table a in capital case except for column "col"
With the return statement here, I get all columns of table a in the correct case, but the column "COL" in capital case...
Without this return statement, I get all columns in the correct case.

Regards


Just a note on this commit. I tried hard to get an integration test to work with deleted donations and deferrals, but the `@Where` annotation wouldn't work with HSQL. It works perfectly with mysql.

See more details:
 - http://stackoverflow.com/questions/26800618/hibernate-where-clause-inconsistent-between-hsql-and-mysql
 - http://stackoverflow.com/questions/10730640/is-there-a-way-to-stop-hibernate-from-corrupting-boolean-literals-in-where-anno


And update both docs each time we add something?
Also, harder to read as people will spend a few seconds to figure out differences…


Trying to run this:

```
./scripts/avocado --show='?' config
Avocado crashed unexpectedly: global name 'missing' is not defined
```

Traceback:

```
Avocado crashed:
Traceback (most recent call last):
  File "./scripts/avocado", line 82, in <module>
    app = AvocadoApp()
  File "/home/cleber/src/avocado/avocado/avocado/core/app.py", line 48, in __init__
    self.parser.start()
  File "/home/cleber/src/avocado/avocado/avocado/core/parser.py", line 103, in start
    self.args, _ = self.application.parse_known_args()
  File "/usr/lib64/python2.7/argparse.py", line 1733, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "/usr/lib64/python2.7/argparse.py", line 1939, in _parse_known_args
    start_index = consume_optional(start_index)
  File "/usr/lib64/python2.7/argparse.py", line 1879, in consume_optional
    take_action(action, args, option_string)
  File "/usr/lib64/python2.7/argparse.py", line 1791, in take_action
    argument_values = self._get_values(action, argument_strings)
  File "/usr/lib64/python2.7/argparse.py", line 2231, in _get_values
    value = self._get_value(action, arg_string)
  File "/usr/lib64/python2.7/argparse.py", line 2260, in _get_value
    result = type_func(arg_string)
  File "/home/cleber/src/avocado/avocado/avocado/core/parser.py", line 45, in log_type
    "eg. 'my.stream'.\n" % ", ".join(missing))
NameError: global name 'missing' is not defined
```


Cheers. Hopefully it'll be fixed in the game at some point.


TeamCity Civic Assembly :: Build all [Build 80](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1378&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 208 Build time: 00:09:37


Ah, yes, true. And I agree with you that although it shouldn't happen, the function should handle it. Perhaps just make that line and the forming of the OR conditional depending on $aCurators? Then also make sure the arguments are built up conditionally as well.


Well this certainly is the first time this has come up. I clearly remember you struggling on more than one occasion to get the "proper" result from the tool chain: showing stacktraces when it shouldn't , *not* showing them when it should, forgetting to tell us to create a bug report etc.
In this case I just want to be able to say: something went wrong and please don't show a stack trace ;)


Hello

How do I build your rom, but without your Snapdragon Cam and with the normal Snap cam?
Just remove the poject from the manifest? Or should I do something else?

Asking this because you said you will use the Snap cam from CM in the future :)

Greetings


no reason. copied from application switcher, i didn't notice


Seems to be similar to mine, which disconnects after a few minutes. Luckily, I'm able to send heartbeats every few minutes to keep it alive. Does that work for you as well, or is it disconnecting immediately after issuing the "off"-signal?


@akselsm In main-hw.h: please merge the TARGET_LIKE_EFM32PG_STK config into the above (with a sub-conditional for RTCC+EMU/RTC)


Oh, my grammar sucks... :sweat_smile: Thanks for the extensive research! Fully agree with your proposal!


If my understanding of `...` is correct these values will be passed onto to `mean(data, ...)`. This lays the foundation for a potential defect where an incorrect result could be returned from the cache. This is how it would unfold, supposing that the `...` args to `mean` can alter the result.

### Call 1
```
 x <- makeVector(ξ)
 m.1 <- cachemean(x, trim =0.1)
```
### Call 2
```
 m.2 <- cachemean(x, trim = 0.4)
```
At this point is there is a possibility that `m.1` ≠ `m.2` depending on structure of `ξ`. This could arise as the value of `trim` in the second call is different to the first resulting in different means.

### Without Caching

This shows the above scenario can arise with a suitably crafted vector.

```
> ks <- c(1:5, 1000, 2000)
> mean(ks, trim = 0.0)
[1] 430.7143
> mean(ks, trim = 0.1)
[1] 430.7143
> mean(ks, trim = 0.2)
[1] 202.8
```

### With Caching

Here we can see `trim` varying across the calls but the result does not change.

```
> x <- makeVector(ks)
> cachemean(x, trim = 0.0)
[1] 430.7143
> cachemean(x, trim = 0.1)
getting cached data
[1] 430.7143
> cachemean(x, trim = 0.2)
getting cached data
[1] 430.7143
```

For the purposes of this example removing the `...` argument from `cachemean` will fix this.


No specific reason, it was an arbitrary choice I guess.
It's true however that ``--project-manager`` and ``--path`` would be more classical (btw the help is already ``--help``).


Not confident about the name I've chosen: TIMER_FIRST_CAP_PULSE (pulse width modulation capability). Not sure how to make the symbol less verbose.


fixed it, it was on ChunkUpdatePacket class.. no idea why backtrace didn't tell us


Default theme PROMPT changed:
```
➜  .oh-my-zsh git:(master) ✗  grep PROMPT= themes/robbyrussell.zsh-theme
PROMPT='${ret_status} %{$fg[cyan]%}%c%{$reset_color%} $(git_prompt_info)'
```
Could you please fix example? Also it's actually breaking ability to autoupdate oh-my-zsh, so it will be nice to have some tips for that (`git pull` on `~/.oh-my-zsh/` advice for example).


It looks as if you've now included the removal of the "naturalisation certificate" link in this commit. Was that intentional? Ideally I think it would still be a separate commit. However, if you'd prefer not to split the commit, then I think the commit note should mention this change.


Excellent idea, I didn't think about that. Would you like to take that upon you? Otherwise we can make a ticket for it.


You don't seem to have followed up with commits, so I'll reject this and do the proposed changes myself.


зачем у попапа в state хранить completed, если и так хранится модель в props?
я так понимаю, нужно хранить в state всю модель как раз


It disconnects immediately. That was a "wow" moment, it kind of defeats the whole purpose of having an app to control the device, if you can't turn it on with the app.


hao


Yeah, that's all correct. Feel free to go ahead and make the pull request so it shows up in https://github.com/whatwg/html/pulls. After you have made the pull request you can still make changes to your branch, it basically allows everyone to easily find your work and review it.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17211](https://teamcity.mesosphere.io/viewLog.html?buildId=145858&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:03:38


What is this? Was this changed with the introduction of the celebration dialog?


I see that you're now using whitespace-removing ERB tags. Since this is not the norm, it would be useful to explain why they are needed here.


мне всё-таки не нравится штука с хранением пустой модели, лучше просто не отрисовывать попап в page


Is this whitespace change intentional? If not, it would be good to avoid it if it's not too hard.


I assume that 0 in 'code 0' is the value of CODE_GPS_L1CA. If so, then you can use stringification of macro expansion instead:
#define xstr(a) str(a)
#define str(a) #a
So
"code 0," \
would be replaced by
"code " xstr(CODE_GPS_L1CA) \


You can use the new extension method I just pushed to master 4337579ff5f0a6d841988af5e8ddd9765e078dbf :

X = p.X.Clamp(0, MaxPointX)


Too much request and generated attachment => slow performance and completely useless


@floehopper yes it was intentional.. becuase it was a late update from google docs edit..


testingg


I'll pass debug instead of minify


I am afraid I did not get entire your point.
If you set R as max distance between point on the object surface, you will
end up having high correlation between point on the surface and point on
the sphere. That is something we would like to avoid, right? So, how is
possible that you get better results reducing R to the max distance between
point on the surface?

On 24 February 2016 at 22:47, Federico <notifications@github.com> wrote:

> I think i managed the Hat-Trick here:
>
> Summary:
>
>    - Kernel saturation removed
>    - Kernel R = 2.0
>    - Mug is still reconstructed quite fine
>
> I think i get it now, how R should be dimensioned i mean, "the maximum
> possible distance" is between object points, not counting the external
> sphere. Here's why:
> If you look at the thin plate plot (with R=2)
> [image: thinplate]
> <https://cloud.githubusercontent.com/assets/1950251/13302818/3bf17b34-db4c-11e5-9594-9b038573b2d9.png>
> where on x-axis there's the distance between points you can see that
> normalized object points willl have x in [0,2], thus having a nice
> descending flavor. while sphere points (at radius 2) will have x in [0,4],
> thus sphere points "close" to each other will influence a lot, but also
> points on oppiste hemispheres will influence each other a lot, since the
> thin plate diverges after x=2 and their distances is 4. Meaning that we are
> reinforcing a lot the bounding region where f(x) must be 1.
>
> Now the tricky part, distances between sphere and object will likely be in
> [1,3], meaning that a sphere point will influence a lot object points on
> the opposite side, where distance might be close to 3. We dont want this
> cause we will have deformations unless we have a lot object points with
> label 0 to reinforce an unknown region, and that is difficult to achieve.
> To mitigate this i will try to lower the sphere points to bare minimum, or
> eventually completely remove it, to see what happens.
>
> Another consequence of this is that we cant add external points (even with
> scaled target, i.e 0.3 instead of 1) too close to the object or it will get
> deformed. That's why I added a control to skip adding external points if
> they are too close (0.3 distance), however you still want to put some of
> them inside the concavity or you wont model it.
>
> Once i tweaked decent parameters I can start producing medias in mass
> quantity.
> First thing i want to do however is the sliding, since it will add a bulk
> of object points to reinforce an unknown region and I think it will reach a
> better result than this:
> [image: rviz_screenshot_2016_02_24-23_45_32]
> <https://cloud.githubusercontent.com/assets/1950251/13303637/c1b181fc-db50-11e5-81e8-11f697262365.png>
> Where the concavity is decenty modeled, however too few points where added
> on "the back", where we know nothing, and the surface gets eaten by
> external points.
>
> I think i'll go bed now !
> Cheers
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pacman-project/gaussian-object-modelling/commit/5a71cdb3983cdfff00c89a7e80da0f4fd977521f#commitcomment-16312017>
> .
>

--
Claudio

Curiously enough, the only thing that went through the mind of the bowl of
petunias as it fell was "Oh no, not again".
Many people have speculated that if we knew exactly why the bowl of
petunias had thought that we would know a lot more about the nature of the
Universe than we do now.
D. Adams - Hitchhiker's guide to the galaxy


@cbrenner04 Ah, I see what you mean. Will do.


вот тут просто не добавлять в разметку PopupTask, если state.popupModel == null и всё


Should be '#replace_members'


track by


давай использовать checkbox из material UI и все другие новые компоненты оттуда, а не дефолтные


Yeah, I recall that I didn't really want to require tools to have to subclass an exception type from the tool API, and there was an annotation which they could use instead, but that didn't work out for mysterious classloading-like reasons. Maybe the dichotomy of tool errors v.s. framework errors is false (once you have tools operating on tools, and loading tools from modules etc), but at the time it made sense that tools would ned that extra control, but it wasn't obvious that the framework itself would. Or that's my excuse anyway.

There's not good excuse for the crappy naming though, other than `ToolException` was already taken and `ToolError` was about an error in a tool.


Yeah Cedric commented about this too. I had a look at some other code around the tree and it used this approach. Just trying to follow what was already in the codebase - not that it's a good justification. I'll see how many other complaints I get on the list :)


it isn't intentional.. auto-generated.


A test to ensure that existing users won't be removed might make sense here


Argh, right :(


good point


Hi


zephiK/android_external_noto-fonts hasn't been added to the manifest.


...ho no... if we use id_or_xml_id instead of id, the new api don't allow to use https://github.com/odoo-dev/odoo/commit/72b64973596490cc77f7ebbe7b92a073ed3c6b2b#diff-3ad2ad1e9b88257a01a42d04ca1c0605R1592
Which is a shame all for a typo


I just tried hypothesis 1.9.0 on RHEL-6 (Python 2.6.6) and it works just fine. However 3.0.4 works fine with 2.6.6 as well. Lets see what travis-ci thinks about this when it is pulled.

r+


fixed!


I changed it, or at leat I think I did.


I know the file is generated, but it reflects a genuine change in the output. Is this change not a consequence of using the whitespace-removing ERB tag(s) in an earlier commit? Sorry if I've misunderstood.


@floehopper
my addition of the whitespace-removing ERB tags was to make it look similar to the earlier changes


@Patater You need to check also the start address


this produces the following error at least in matlab2013a:
Error using exist
The optional second input to exist must be 'var', 'builtin', 'class', 'dir' or 'file'.

the correct way should be:
hasbaseline = exist('baseline');

this change has consequences in http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=3078


No, because it's called replace members which means that it actually will remove existing members!


Probably better to use IS_LENGTH with minsize and maxsize


(but maybe a test case for the other way around makes sense ...)


ee32bc3 should fix that


Probably better to use IS_INT_IN_RANGE


Because func definition is plain wrong. (there should not be named variables and number of cpu should be returned as value from runtime.NumCPU - btw. imo this should be uint but still - returned from runtime.NumCPU).


bezveze


> and ToolError was about an error in a tool.

Yeah, I didn't know that, I guess that I, like @lucaswerkmeister , saw the similarity with Java Exceptions and Errors and immediately assumed that `ToolError`` would be "worse" than `ToolException`.


i've test it.. and it works completely different ... the Bootanimation works smooth now .. but 2D V/H Games laggs now .. but i think it needs now re-calibration of video.modes + lcd_freq .. then i think it'll work far better ... Maybe after a few Years it'll finally work properly :-)
Thanks for this Commit :-)


I think reference fields already have IS_NOT_EMPTY implicit due to the default IS_IN_DB validator


OK. Well as long as you're happy with the changes as they stand, I think it would be good to explain the use of the ERB tags and the removal of the "naturalisation certificate" link in the commit note.


```
s/or  podAffinity/or podAffinity/
```


I think this is a very dangerous idea. #validated is an internal form API key and setting it results in all kinds of processing being skipped. Here's what the address widget does: https://github.com/bojanz/address/blob/8.x-1.x/src/Plugin/Field/FieldWidget/AddressDefaultWidget.php#L510
We probably want the same thing once our own widget here starts working.


Anyway my "solution" is obviously a Dirty Hack(tm) and we should at some point refactor that error reporting bit of the tool chain into something a bit more coherent.


dame


Probably better to use the IS_IMAGE validator


bbbbbbbbbbbbbbbbbbbbbbbbbbbの方がいい


r+


In the case err != nil, the user can't get useful info since the log didn't print err.


I am nitpicking here. Is this line needed? It confused me a bit since it give the impression that it's testing something different than line 13/14. But that doesn't seem to be the case.


Switched to g_assert, dropped the message. But, it seems like a convenient shorthand if the assert expression is dumped to a log/stdout right?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17212](https://teamcity.mesosphere.io/viewLog.html?buildId=145859&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:07:01


@jelicanin - where are we checking for this permission in the code?  The only permission we are checking for elsewhere at present is 'ADMIN'.  Am I missing something?


Bytecode - > byte-compiler


@Patater check for >=0 ?


Ok I was 8 mins late: http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=3078


It's silly to separate files.
And I create the file for translation in separate ?


Would it be possible to backport this on the 4.0 branch, please?


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/28034/testReport/) for this commit**


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17215](https://teamcity.mesosphere.io/viewLog.html?buildId=145864&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:04:58


Shit happens!


I would prefer to swap line 11 and 12. So that visiting the path and testing the page is grouped together


Good call. Done.


Ээээм. Это что, зачем и когда надо вызывать? Как минимум не хватает комментариев.


I have trouble following this code, which means it's missing important comments.
Why don't we filter based on the last attribute? And why do we maintain a list of invalid matches instead of skipping the variation once it's proven not to match?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17218](https://teamcity.mesosphere.io/viewLog.html?buildId=145876&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 237 Build time: 00:03:43


same here


It'd have to be completely separate MAIN_ACLs, since you can't do #if inside of #define, though?


Ok Cool


Yeah, that what docs say for shallow copies, r+


Missing in the commit message:
- Replace require_admin by pundit authorization


What does this have to do with python 2?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17217](https://teamcity.mesosphere.io/viewLog.html?buildId=145865&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 226 Build time: 00:07:44


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17216](https://teamcity.mesosphere.io/viewLog.html?buildId=145863&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:08:11


'2' here can be replaced by the size of 'loop_params_parse.loop_params_stage' array.


These are eventually used in hw/arm/ast2400.c (a couple of commits away). They should be left for that?


Bad code formatting here


It's used just below to define the array of timers (line 49), so I think the only way to avoid adding it would be to use a magic number below?


Oh that's cool. Well thanks again for your help. Can I ask you one more
question though please? How does the playing videos on the Ee box over http
work exactly?
On 25 Feb 2016 09:05, "kevjs1982" <notifications@github.com> wrote:

> The WebUI allows you to search for programmes (only a channel at a time
> though) and set timers (including series links) for them.
>
> Not had any need for the EPG on XBMC as I rarely watch live TV, only really
> did it so I could watch recordings in the bedroom/kitchen.
>
>
> On Thu, 25 Feb 2016 at 01:25 fraser1978 <notifications@github.com> wrote:
>
> > Hello again Kev,
> >
> > That's fantastic, thanks for that! Excellent work mate, exactly what I
> > needed. Is there any plans to build on the catchup section (if its
> actually
> > theoretically possible) and maybe a record setting option? Also, is there
> > any way to add EPG and choose programmes as required?
> >
> > I'm definitely going to consider looking at the webui stuff in the future
> > as I have some experience helping a friend build his website with some
> php
> > code. Its certainly an interesting subject for me.
> >
> > I honestly highly commend you for your work on this, as after many
> searches
> > on google you seem to be the only person who is expanding on an already
> > lacking service. So hats off to ya pal!
> >
> > Thanks again.
> >
> > Regards,
> >
> > Fraser
> >
> > Hi fraser1978.
> >
> > I've updated the readme for the XBMC plugin at - should allow you to get
> > started
> > https://github.com/kevjs1982/xbmcplugins/blob/master/README.md (Alas my
> > Kodi/XBMC installs are a couple of years old so these haven't been tested
> > with the latest ones).
> >
> > The web-ui requires knowledge of setting up webservers and PHP which is a
> > bit on the complex side.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> >
> https://github.com/kevjs1982/eetv-webui/commit/8cd482dbbab10c7b93363c0af4355c6ef582628c#commitcomment-16298393
> > >
> > .
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/kevjs1982/eetv-webui/commit/8cd482dbbab10c7b93363c0af4355c6ef582628c#commitcomment-16314954
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kevjs1982/eetv-webui/commit/8cd482dbbab10c7b93363c0af4355c6ef582628c#commitcomment-16320191>
> .
>


Good point. I'll re-write them.


r+


if you respect the api, as you should, def js and def css do not receive the debug argument. actually they are not called in debug mode. instead it's the asset to_html function that is called.


观光团


@Patater please check with @AlessandroA regarding unified uVisor error codes. Something like https://github.com/ARMmbed/uvisor/blob/master/core/system/inc/iot-error.h , but namespaced for uVisor.

Candidate: https://github.com/ARMmbed/uvisor-lib/blob/master/uvisor-lib/error.h


repos are not handled by the module therefore in the case that the repository used does not contain python-pulp-streamer (e.g.  https://repos.fedorapeople.org/repos/pulp/pulp/stable/2/), then the option to install it can be set to false

also, apache::mod::proxy should be installed (otherwise the following httpd error is seen 'Invalid command '<Proxy', perhaps misspelled or defined by a module not included in the server configuration)


Dunno, it only failed on Python 2.  I assume Python 3 either is happy to create the folder if it doesn't exist, or ignores this setting.


see my fix 7b520746f60a1338c7692d86ff94828689a00455


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17213](https://teamcity.mesosphere.io/viewLog.html?buildId=145860&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 226 Build time: 00:07:04


Do we want to add a `related_query_name` here too? I guess we don't need it yet.


please comment out RequiredDuringExecution related logic and add comments with "todo: ****", you may refer to the node affinity for a detailed todo description


What amazon service are you using https://aws.amazon.com/ses/ ?


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/28037/testReport/) for this commit**


真神作


We are not going to switch to a longer integration time for L2C. So, I think, we need to add an extra condition to the enclosing 'if' to exclude entering here for L2C.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17214](https://teamcity.mesosphere.io/viewLog.html?buildId=145861&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:08:19


@akselsm Ah, dammit missed, that - you're right - we need to change our concept first.


Agree on the principle. In fact, use Bootstrap input-group here add unexpected behaviors and hardest maintenance, because of the $ù%! graphic properties that bootstrap add, with a random (in most case superior) [specificity](https://www.smashingmagazine.com/2007/07/css-specificity-things-you-should-know/).
Or, all we want here it's the structure. So I prefer repeat this simple structure in my class, instead of overwrite (with !important) the graphic properties...


При вводе не-числа (любого символа) упадет с NumberFormatException


Осторожнее в английским.
"Автор не кладет", если перевести дословно


Indentation


r+


Shouldn't this be setError rather than setMessage?


when in el7 x86_64 and using the following repository https://repos.fedorapeople.org/repos/pulp/pulp/stable/2/7/x86_64/
pulp-server does not install in /usr/share/pulp/wsgi but rather in /srv/pulp


I think, that the explicit size can be omitted here and compiler will decide it automatically.


Same here.


Hmm, it looks like removing it is the right thing to do anyway. `user_management.ui` doesn't have a `models.py`, so we don't need test migrations for it.


ack


внутри класса можно обращаться к полям, не нужно делать лишние вызовы


what's this for?Missing newline before EOF.


все поля должны иметь модификатор доступа private


Did you log this with elasticsearch?


Ok


Probably some github buffer or table record then that needs to be updated. Will probably get fixed in a day or two.


`final`


I finished the review. Please check out my comments.


>DuplicateSoundMem

46行目に既にありません？

>LoadSoundMemBase

ただの別名の関数をあまり置きたくないです。


Also one of the reasons for separating these was to allow the imports to be declared early but having the names separate and later defeats this use case. Thus suggest inlining the strings. See elsewhere that strings are to be encoded by a leb128 length. Two options are to either inline the strings in the import entry or place them one after the other at the end of the imports sections, with just the sig_index for each import entry.

Might also consider a sub-table per module name to avoid repetition of the module name.


There's a typo here: *enviornment*.


in that case your previous commit doesn't make much sense :P


in the event that python-pulp-streamer is not set to be available, then do not include it in the list of services


What is the testing status of this commit? Has this been compared thoroughly for regression?


Jednak będzie app_dev, bo się psuje kontrolka od dotpay


Отличный подход, но если используешь один и тот же объект, его можно вынести в статические константы:)
Как минимум "d MMM yyyy HH:mm:ss" подходит под определение "магическая строка" и должна быть объявлена константой


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/28040/testReport/) for this commit**


I had a similar behaviour on my bds. I found out that on my device, the off command was disconnecting the device. To be able to send heartbeat, I had to send a pause command (or something like that. I'm not sure since I have no access to my notes for a few days). This pause command is a toggle command. I'll confirm the exact command name as soon as I have access to my notes. My guess is it will work for @mikaabra as well


r+


あまりにも名前が長いのでSoundMemだけ削りました。

で、提案なんですが、クラス内関数はいっそ命名規則もスネークケースにしてしまい、DxLibと同名の関数はフリー関数として実装しませんか？
textureクラスのようにラップすることを当初考えていたのですが、どうもそれをすると使い勝手がよくなさそうで。
つまり、メンバー関数にしては名前が直感的では無いというか


态度如此不友好，下次不给合并了


Вместо реализации стоит использовать интерфейс, это позволяет сделать код более гибким к изменениям. Объект создается ArrayList, а ссылка на него должна быть List.
```java
private List<Message> = new ArrayList<>();
```


-E is not working on SLES / RHEL


ONE advantage of using standard `.input-group` Bootstrap component : it allow to remove this (`& &__...`). Which is used to overwrite an unwanted `width: auto` that apply when a `.form-control` is put inside a `.navbar`, expect when it is inside a `.input-group`.
*When I say boostrap is dirty....*

On the other hand, we whould use this overwrite trick to remove all the `.input-group` graphic properties. What would be even worse.


By doing it like this, a user cannot override default provided moddle extensions.

Instead, it should read something like that:

```javascript
return new BpmnModdle(assign({}, this._moddleExtensions, this.options.moddleExtensions));
```


I would pass `declarationFrame` as an argument to `readFrameSlot`, otherwise the helper is doing more than just calling the helper node.


Isso. Eu estou pensando em desacoplar duas coisas na verdade:
* o **layout** de form, que pode se aplicar a qualquer FormView
* o **crud**, que agora usa o esquema de layout, mas poderia ter uma versão básica com forms simples (sem layout) e uma versão com layout. Idealmente os dois aspectos poderiam ser independentes e combináveis, mas não sei se será possível.
Podemos reorganizar quando fizermos a issue #214.


عزیز لطفا یک ایمیل به من بزنید کار واجبی باهاتون دارم
shm379@live.com


Вот тут программа говорит программисту "Файл не найден", а программист пользователю - "Ошибка с файлом!".
Может, стоит сказать пользователю что файл не найден?:)


So we're ditching the relational link for the actual path. More flexible! It makes me wonder why it was using the relational link in the first place?

Paths can't be changed for guides or topics.

At some point we're going to start turning guides/topics off and we'll need to retire or redirect. I wonder if by losing the relation we might one day start sending people through multiple redirects as pages get moved and moved again etc?


Better: Showcase the sub-classing use case here, i.e. provide a custom viewer for which the `prototype._moddleExtensions` is being patched.


So I understand that after implementing #193, two data stores will be created from contents with `mime-typ` equal `xml`: a one with `interpretation="JATS"` and another one with `interpretation="OAI"` (or something like this) and both data stores would be processed by the same code introduced in this pull request. What I'm saying that such code might be trying to do too much.


As this is part of generating a select tag this feels like a helper to me.


I would not do a blocking operation. It may work in the first request, but how are you going to handle a user receiving the first page, and now he jumps to the last page - which may not yet be computed either.

I would do it differently:
(1) After each page is generated, update the cache. For that, change produceCacheablePages, add your listener, and begin listening for status updates. You are guaranteed to get one update whenever a page changes.

      private IReportContent produceCacheablePages( final MasterReport report, final int yieldRate, final String key )
        throws ReportProcessingException {

        final PageableReportProcessor proc = createReportProcessor( report, yieldRate );

        final PageableHtmlOutputProcessor outputProcessor = (PageableHtmlOutputProcessor) proc.getOutputProcessor();
        outputProcessor.setFlowSelector( new DisplayAllFlowSelector() );

        try {
          final ZipRepository targetRepository = reinitOutputTargetForCaching();
          proc.addReportProgressListener(new ReportProgressListener() {
            @Override
            public void reportProcessingStarted(ReportProgressEvent reportProgressEvent) {
              // ignore
            }

            @Override
            public void reportProcessingUpdate(ReportProgressEvent reportProgressEvent) {
              if (reportProgressEvent.getActivity() == ReportProgressEvent.GENERATING_CONTENT) {
                // we finished pagination, and thus have the page numbers ready.
                // we also have the first set of pages ready ..
                try {
                  persistContent(key, produceReportContent(proc, targetRepository));
                } catch (Exception e) {
                  // better error handling here ...
                }

                // now update the state that you report via the JobManager ...
                // anything up to (currentPage-1) should be safe to fetch now.
                int currentPage = reportProgressEvent.getPage()
              }

            }
            @Override
            public void reportProcessingFinished(ReportProgressEvent reportProgressEvent) {
              // ignore
            }
          });
          proc.processReport();
          return produceReportContent(proc, targetRepository);
        } catch ( final ContentIOException e ) {
          return null;
        } catch ( final IOException e ) {
          return null;
        }
      }

      private IReportContent produceReportContent(PageableReportProcessor proc, ZipRepository targetRepository) throws ContentIOException, IOException {
        final int pageCount = proc.getPhysicalPageCount();
        final ContentLocation root = targetRepository.getRoot();
        final Map<Integer, byte[]> pages = new HashMap<>();

        for ( final ContentEntity contentEntities : root.listContents() ) {
          if ( contentEntities instanceof ContentItem) {
            final ContentItem ci = (ContentItem) contentEntities;
            final String name = ci.getName();
            final int pageNumber = extractPageFromName( name );
            if ( pageNumber >= 0 ) {
              pages.put( pageNumber, read( ci.getInputStream() ) );
            }
          }
        }
        return new ReportContentImpl( pageCount, pages );
      }

(2) Change the UI on the client to listen to the state updates and to request the page as soon as it becomes available.

This code relies on the Jobmanager to be able to listen to proper status updates from the ReportProcessor, which is also needed to properly implement the progress bar (at the moment, it is just a dummy, it does not report any true row/page data from the server).

See my code-review email for how to implement it. Yahor also needs that ability for his current case as he needs to know about the total-pages generated by the pagination.


Não entendi...


i still don'T get that one


Тоже неплохо бы красивый текст ошибки. Все исключения содержат сообщение, его можно получить через метод Exception::getMessage()


Additional test needed. Make sure user can override pre-populated moddle extensions defined in prototype via options (see above).


r+


silly, stupid, ... why don't you begin by understanding this model mechanism and respect it? it concerns something like 30 file **in debug mode** in the backend, which helps you debug the bundle. About the file for the translation, your implementation could maybe be improved by returning the xml templates directly translated, which makes more sense. At the moment the client templates are already treated server side in the concat_xml function, so why not translating them directly there? this way you could only fill the "translation bundle" with the terms used in "_". What do yo think? (i didn't try to implement it)


@jelicanin I've just seen it... merging :)


Trouble with radare2
see ->  https://github.com/radare/radare2/issues/4158


Filen verkar OK för Grupp4 :)


Здесь тоже можно использовать Java8:
```java
messages.forEach(System.out::println);
```


Seria bom mover estas chamadas a métodos do banco (e.g., materia.tramitacao_set.last) para variáveis acima desta linha.


depends a bit on what compatible means. if you add new functions the api does not break but if someone relies on new function a simple call to is_compatible does not cover this check.
The question here is, what is the purpose of this function?


I corrected it in my version Just have not pushed it to you


Kigrepelve az ub készletet 248 perl* szerepel az összes ub build-depends és a depends fájljaiban.
Magával a prl -el egyetemben.
Nem szerepel viszont már perl-pod* bennük, tehát az eddigi két törlésem jogos.
Ráhasalok a még hátralévőkre, már látom az alagút végén a fényt.


Может предложишь какое-то более понятное решение? Суть в следующем:
Когда пользователь жмет кнопку редактировать объект, надо проинициализировать поля EditableFeature, которые потом в UI редактора вычитываются и редактируются. Делать это просто так, без редактирования, бессмысленно и не нужно.

Точно так же надо будет проинициализировать эту же структуру специальным методом фреймворка при создании новой фичи.


we call it from here:

  def self.complete
    step = new
    step.invite_user
    step.user_clicks_invitation_link
    step.set_password('Berty2016')
  end


Em termos de formatação? O comum é não haver linha em branco entre o decorator e a definição da função. Rodei a verificação de PEP8, mas rodarei novamente.


You can have a look here http://24days.in/umbraco/2014/your-first-pull-request/ Good luck!


not sure but    Next would work or? it that case it'll be better


Отступ нужен


What could be considered here would be to check if the version is at least as big as the one given but major is not bigger. That would be more useful and match semver.


Где-то остались отступы, где-то нет. Предлагаю не менять кодстайл и делать с отступами везде.


все поиски можно реализовать фильтрацией из Java8
```java
messages.stream().filter(msg -> msg.getAuthor().equals(newAuthor)).collect(toList());
```


Added Some code  of Line


Blz. Eu, na verdade, percebi que não havia subido a última versão desse ramo. Algumas das suas sugestões talvez já estivessem resolvidas na minha máquina. :P


Я думал сгруппировать методы, близкие по смыслу. Отступы в таком случае удобно разделяют группы методов. Или нужно добавлять отступ по какой-то еще причине?


aka why not just
"aurelia-dependency-injection":...
"aurelia-binding":..


Методы сгруппированы и отделены отступами сознательно.


I suggest using a different name. "aliveness test" leads many people to believe that it covers nearly every possible problem, which is certainly not the case.

We should make this clear that this is a node-local test. So how about `node_health_check`?

@dcorbacho @binarin


What is the reason that you added the if statement here? If "query" does not return a valid node, wouldn't the earlier lines fail already? After all, you have the same "style.set(query(..))" with the same parameters there and no checks.

Remove the checks, I'd say, trust that the "dijitDialogPaneContent" is there (its provided by Dojo, we implicitly trust it).


Do we need the `@selected_slug` variable? It's used in the view but the `@slug_migration.redirect_to` should have the correct value in the edit and update actions.


You surely dont want to be styled like "splash-content" for the progress bar. What if a theme starts changing their splash screens - they wont necessarily want that change in their progress bars too.


Небольшие замечания:
 - подтяни английский (или используй гугл-переводчик для проверки)
 - поля должны быть <code> private </code>
 - вместо ссылки на реализацию лучше использовать ссылку на интерфейс.
 - старайся не парсить зря числа (там может упасть RuntimeException)
 - не используй сеттеры в конструкторе - доступ к полям внутри класса есть всегда
 - аккуратнее лови исключения - пользователю должно быть ясно что произошло.

Код довольно красивый, молодец, задание 2.2 принято.


Seems reasonable to me


Дополнения по 2.1 тоже приняты.


That's complicated but clever, r+.


General: That dialog is only used in the report viewer, so keep it there. The report viewer already has a "dojo/pentaho" directory with content, so there is a precedence case you can follow.


Yeah.  I added that more as a formality, there's no cost to removing it.


I think there is a superclass of our GdsApi::* errors so we can catch the lot at once.


It does not work and I print it for debugging purposes (I monitor travis builds). When I finish the patch, I will leave the corresponding message.


15 minutes to 10 seconds? I knew indexes had an impact, but didn't expect it to be that much.


Is the consensus here that this change should be backed out again?


The Django Coding Standard would have you put the Meta here, immediately after all the fields are declared (https://docs.djangoproject.com/en/1.9/internals/contributing/writing-code/coding-style/#model-style)


Human error. I changed the my repo not cppits.


I guess this function is not done? You don't even do matching for `topologyKey`.


@VocrsZ


"Redirect to" is probably the default label text so we might not need to override.


May as well remove this note, as that's what you're doing!


@nfeske: above are my two cents for the upcoming release-notes. The second part you marked with my name (intel_fb) actually refer to a commit by cnuke. I'll asked him whether he can write something about it, and he agreed.


Ну раньше в файле все методы были разделены одним отступом. И почти везде тоже так сделано. Когда добавляются ещё и аннотации, и нет разделения отступом - смотрится и читается очень непривычно.
> On Feb 25, 2016, at 3:35 PM, Alex Zolotarev <notifications@github.com> wrote:
>
> Я думал сгруппировать методы, близкие по смыслу. Отступы в таком случае удобно разделяют группы методов. Или нужно добавлять отступ по какой-то еще причине?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/deathbaba/omim/commit/b5c63b04519a811e39abfb40919402ddac14d5f5#commitcomment-16324776>.
>


For some reason this update causes freezes or AccessViolationExceptions on Steam.RunCallbacks() on StandAlone Steamworks.NET (haven't tried Unity).
It only happens sometimes when Set() is used from the m_Func delegate on the same CallResult instance. I found for some reason it happens more often when I go offline.
This isn't fixed with the later revision where a `if (hAPICall == m_hAPICall)` check is added before the `m_hAPICall = SteamAPICall_t.Invalid; // Caller unregisters for us`

I tried to figure out why it happens, but my knowledge of managed/native interactions is not extensive enough to reason my way out of this. The best option I can think of is that some var somewhere is not being pinned long enough and is sometimes GC'ed. That would explain why it only sometimes goes wrong.


just we are  use this stuff ,but ,emmm,thks


Yes it's good to get this. Nice finding!


I wonder if it would not be more flexible and faster to use TraceEvent for capturing the GC data instead of going through logman and an ETL file. If there is interest I can probably put together a PR.


@klimov-paul I think it is not environment specific. I am using the setting `PDO::ATTR_EMULATE_PREPARES => false` in my DB config. Apparently this uses native preparation which means that you cannot use the same parameter twice.

Example DB component config:
```php
    'db' => [
      'class' => 'yii\db\Connection',
      'charset' => 'utf8',
      'dsn' => $params['components.db.dsn'],
      'enableSchemaCache' => $params['components.db.enableSchemaCache'],
      'schemaCacheDuration' => 3600,
      'username' => $params['components.db.username'],
      'password' => $params['components.db.password'],
      'attributes' => [
        PDO::ATTR_STRINGIFY_FETCHES => false,
        PDO::ATTR_EMULATE_PREPARES => false,
      ]
    ],
```


I just removed the left parenthesis. I sent the commit for this


네 Cache 로 변경해서 테스트 해 봤는데 잘 되네요. 불필요하게 loadingCache를 쓸 필요가 없어졌네요.
알려주셔서 고맙습니다. : )


У меня возник вопрос просто - что это за метод, когда его нужно вызвать, почему он называется initialize. На старте активити? Приложения?


You can't see such docs in IDEs etc., you always have to dig into the source or reference then.


CRC checks should be done on both client and chunkserver to avoid situation when chunkserver sent data but it decayed during transfer to client. This was one of the best features of LizardFS. Please preserver CRC checking on client.


@PDDStudio for you this still causes a crash?


Может назвать метод StartEditing?


The limit is configurable to the condense function, so that should not be a problem.


I think it would be good if we can aim to extend the existing ops[] array otherwise things might get out of sync as we add new ops if we mistakenly only update one array or the other. E.g. it looks like this isn't handling UMIN which is listed in the ops[] array.

I think the way we handle expression splicing in oa-gen.py (which is a very similar problem to this) could be a good model to follow here, where each operation has a splice_OP() function that takes an operands[]/args[] array which is responsible for concatenating the strings of sub-expression-operands with the operator itself.

So imagining the ops[] array something like:
```
ops["FADD"] = (2, emit_fadd, mathml_splice_fadd)
ops["FDIV"] = (2, emit_fdiv, mathml_splice_fdiv)
ops["FMAX"] = (2, emit_fmax, mathml_splice_fmax)
ops["FMUL"] = (2, emit_fmul, mathml_splice_fmul)
ops["FSUB"] = (2, emit_fsub, mathml_splice_fsub)
ops["READ"] = (2, emit_read, mathml_splice_read)
ops["UADD"] = (2, emit_uadd, mathml_splice_uadd)
ops["UDIV"] = (2, emit_udiv, mathml_splice_udiv)
ops["UMUL"] = (2, emit_umul, mathml_splice_umul)
ops["USUB"] = (2, emit_usub, mathml_splice_usub)
ops["UMIN"] = (2, emit_umin, mathml_splice_umin)
```

And then e.g. for fdiv we'd have a splice function something like:
```
def mathml_splice_fdiv(args):
    return "\n<mfrac>\n<mrow>" + args[1] + "\n</mrow>\n<mrow>\n" + args[0] + "</mrow>\n</mfrac>\n"
```
(which looks like it can be shared for both ops, in the same way you share code for integer/float division)

If we have a single function to concatenate the operands + operator xml like above we can avoid assuming all future operations will have 2 operands that follow the pattern of <pre><operand0><op><operand1><post> - although that's ok for now.


If you follow through the splice_rpn_expression() code in oa-gen.py you'll see how after popping an operator + its operands off the stack to call the splice callback it then pushes the returned sub-expression string back on to the stack as a possible operand for later operators. If you were to do the same thing, but pushing snippets of xml returned by mathml_splice_OP() functions, then you can avoid needing to build an intermediate tree representation of the expressions.


``prefetch`` is not defined here


Always read code before accepting patches ;)


Or at least make it optional; it helped us greatly in many infrastructures where networking problems caused substantial data disruption on the wire.


I guess when we use a proper (maybe full qualified) identifier IDEs might get more helpfull with it

`@see` supports various parameters types
http://manual.phpdoc.org/HTMLSmartyConverter/HandS/phpDocumentor/tutorial_tags.see.pkg.html


Modificación README


I tested WebView 40.0.2214.114 prebuilt APK and it works fine but ignore_egl_sync_failures isn't applied so the Browser crashes


Ahh, good, thanks! This function was a leftover.


> DxLibと同名の関数はフリー関数として実装

わかりました。textureクラスの方もそうしたほうが良いですかね？


that's a bit short and not really a sentence


I think it should be possible to avoid special casing READ operations in this loop, and handle the expansion of READs like any other operator.


Aknowledge !


**[unitTests_js_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_js_branches/25357/testReport/) for this commit**


Shouldn't `element` be stringified?


aa啊啊


Merged here.


А нас как-то напряжет сразу же проиницализировать всё в Editor.init ? Не вижу смысла в оптимизациях этих и нескольких методах инициализации.
> On Feb 25, 2016, at 3:32 PM, Alex Zolotarev <notifications@github.com> wrote:
>
> Может предложишь какое-то более понятное решение? Суть в следующем:
> Когда пользователь жмет кнопку редактировать объект, надо проинициализировать поля EditableFeature, которые потом в UI редактора вычитываются и редактируются. Делать это просто так, без редактирования, бессмысленно и не нужно.
>
> Точно так же надо будет проинициализировать эту же структуру специальным методом фреймворка при создании новой фичи.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/deathbaba/omim/commit/b5c63b04519a811e39abfb40919402ddac14d5f5#commitcomment-16324729>.
>


Ok looks like even VS2015 supports that.


Yeah that was pointed out by @AbdealiJK, sorry I will update that.


Here: https://android.googlesource.com/platform/external/chromium-webview/+/179c69ae7cbe7616ca7feff7f0a1bc7292dce640


data_type の選択肢が増えた場合、
（まず、増えることは無いかな、と思いますが）
if - and が増えてしまうので、
<pre>
if data_type not in ['ascii', 'base64']:
</pre>
とかは、いかがでしょうか？


А Editor.init будет гарантированно вызываться каждый раз для разных фич в Place Page? Если так, то это хорошее решение.


Hi @bwalsh. There's no reason why the info shouldn't be optional. It is there for potentially project specific information which is not captured by the named attribs.


@bbottema Hi!

I just came to update my version from 1.1.1 to 1.3.1 and noticed that this module is no longer getting picked up by wiredep (used to automatically 'wire' bower dependencies into the index.html etc). This seems to be due to the bower.json configuration being removed and there no longer being a 'main' property available for wiredep to find the JS to load.

What's the reason for this change? Should I just manually override this 'main' property in my .bowerrc?

Just checking to make sure it's not a mistake


-.-" oh guys. Should i show you the disassembed Minecraft game files? It is UPDATED. Just the internal handling in PM was incorrect


It doesn't break itself. You just need replace ``exports`` with ``module``.
You are right, that this refactoring is not required for 8.0, but I suggest to update it anyway to have similar code for both version


This should be a another custom mapping defined in OrikaMapper class. We'll look at that later on, it is fine like this for now.


Java/Ch 05. Bit Manipulation/Q5_04_Next_Number/QuestionA.java

unused


simplifiable


`console.log`


Java/Ch 05. Bit Manipulation/Q5_04_Next_Number/QuestionB.java

unused


Java/Ch 05. Bit Manipulation/Q5_04_Next_Number/QuestionC.java

renamed for consistency with `getPrev`


`0 & 1` cannot be 1


Thank you! Was just looking into this.


Vill få med in
_"Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live."_

Men ändra till _"Always commit as if the....."_ :stuck_out_tongue:


We could add an error to this list https://github.com/ARMmbed/uvisor/blob/master/core/system/inc/halt_exports.h

(it's publicly available through uvisor-lib)


Сейчас он вызывается один раз на старте. Я потому и начал спрашивать про initialize, что непонятно, как часто этот метод нужно вызывать и зачем он вообще.

> On Feb 25, 2016, at 3:55 PM, Alex Zolotarev <notifications@github.com> wrote:
>
> А Editor.init будет гарантированно вызываться каждый раз для разных фич в Place Page? Если так, то это хорошее решение.
> —
> Reply to this email directly or view it on GitHub <https://github.com/deathbaba/omim/commit/b5c63b04519a811e39abfb40919402ddac14d5f5#commitcomment-16325146>.
>


Java/Ch 05. Bit Manipulation/Q5_04_Next_Number/QuestionD.java

if Java helper methods should be avoided for some reason, this method can be rewritten to the `while` loop used in `QuectionC`


Isn't there a spelling mistake here? "adpator"?


Full variable names: `user`


Why did you delete the comment?


## Task 1

Previously, you wrote a program that used a recursive function to compute the sum of the integers from 0 to 1000 (inclusive).  This time, I want you to accomplish the same thing, but using a `while` loop. Compute the sum of 0 to 1000 (inclusive) in a function using `while`. Return the sum of these numbers to the main loop and print the result. Write the program to include a `main()` function and the `ifmain` statement.

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program computes sum using a `while` loop in it's own function (1 pt)
- [ ] Program correctly computes and displays sum of 0 to 1000, inclusive (1 pt)

## Task 2

Above, you wrote a program that used a `while` loop to compute the sum of the integers from 0 to 1000 (inclusive).  This time, I want you to accomplish the same thing, but using a `for` loop. Compute the sum of 0 to 1000 (inclusive) in a function using `for`. Return the sum of these numbers to the main loop and print the result. Write the program to include a `main()` function and the `ifmain` statement.

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program computes sum using a `for` loop in it's own function (1 pt)
- [ ] Program correctly computes and displays sum of 0 to 1000, inclusive (1 pt)

## Task 3

In Python, we tend to use `for` loops over different types of iterators much more than `while` loops - they're more flexible and iterators are **everywhere** in Python.  Write a program that includes 5 different functions, each of which should demonstrate the use of `for` over **different types** of iterators. Your program should include these five functions, a `main()` function that calls all the other functions, and the `ifmain` statement.

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program includes `main()` function and "ifmain" statement (1 pt)
- [ ] Program contains 5, correct subfunctions that use `for` over **different types** of iterators (5 pt)
- [ ] Program's `main()` function calls all subfunctions (1 pt)
- [ ] Program runs and correctly demonstrates use of `for` (1 pt)


@drewzh Actually, it's because angular-logger migrated to npm for managing dependencies. However, I can still provide an entry point for bower, for those who still use it.

When I get the time, I will re-add a bower config file.


Why remove this?


I have a feeling you're testing locally using GPUTOP_WEB_ROOT to serve out of the source directory because I think with this the installed layout with everything under a MathJax directory means the ui won't be able to find MathJax.js which gputop-server.c will try and find in the same place as e.g. jquery.min.js.

I guess we will need to symlink the MathJax.js file directly under gputop/remote/MathJax.js and also gputop/remote/extensions, gputop/remote/jax, gputop/remote/fonts/ gputop/remote/config

It will clutter gputop/remote a bit which is a shame, but I don't think automake has a nice way to drop the top-level MathJax/ directory as the files get installed.


@pynicolas Are you ok with `visit..`?


Yes, as its own tag, but @bwoebi used it inline here.


I think it needs the pokrytie as well:
`\u043d\u2df4\u0487 \u041d\u2df4\u0487`


Does this need new foreign key to user?


can this be removed?


Does this need a foreign key to whatever item you've commented?


Looks good!


Ну вот, а в данном случае один раз при старте не пойдет. Надо для каждого нажатия на кнопку Edit Place.


http://graphics.stanford.edu/~seander/bithacks.html#NextBitPermutation could also be used here, though I consider it way to complicated (especially for an interview)


I put it in there in my first commit, right before I was pointed to our global gitignore information.


Hi @hamsterksu,

Thank you for the PR, a nice option for RestComm.
One thing I see ```juju-log "Update init password``` , I think that is need to be removed.

BR


Every of this IDs could be a foreign key allowing nulls.


 - $npm_package_version is available as an env var during the version lifecycle hook. So we shouldn't need to parse the package.json
 - since this script is intended to be used only by maintainers via npm, which means node is available, should we just do the string-replace via node (maybe with a dep that can make this a one-liner? https://www.npmjs.com/package/replace)


@nfeske my fair share.


y a-t-il des cas d'erreur de prévu?


Already addressed in the next change.


Non


niepotrzebny ponowny import


I'm not sure what you mean, I'm afraid?


No - I'll remove it it a fixup to the "remove South" commit


Hi @hamsterksu,

To configure restcomm-docker we are using some configuration files, please see [here](https://github.com/hamsterksu/Restcomm-Docker/blob/master/scripts/restcomm_env_basicAmazon.sh#L31)

Thank you.


Should be "The template of TaskMentionPlugin"


I'm not sure about that function's name. Anyone has a better suggestion? Simply `export` seems to vague to me.


А почему тогда в MwmActivity в сценарии
if (mIsFragmentContainer)

не вызываем его? Собственно, основная причина моих вопросов - ровно в этом. Совершенно непонятно, когда метод нужно вызывать и что же он инициализирует. Нужен комментарий и другое название, думаю.

> On Feb 25, 2016, at 4:05 PM, Alex Zolotarev <notifications@github.com> wrote:
>
> Ну вот, а в данном случае один раз при старте не пойдет. Надо для каждого нажатия на кнопку Edit Place.
> —
> Reply to this email directly or view it on GitHub <https://github.com/deathbaba/omim/commit/b5c63b04519a811e39abfb40919402ddac14d5f5#commitcomment-16325333>.
>


We had this discussion in the past and agreed to use the single-L way.
This mostly revolves around https://godoc.org/golang.org/x/net/context which uses the same spelling.


Good point. No reason to mention things we don't touch.


iam here


Java/Ch 01. Arrays and Strings/Q1_04_Palindrome_Permutation/QuestionC.java

since the precedence order is not simply left-to-right (i.e. you have to shift, before xor), consider using parens to make it more obvious:
```Java
bitVector ^ (1 << index)
```


to chyba nie tak miało być


Is this print supposed to remain here?


oh, yes. sorry


I'd rather call it data - it's just a dict atm, not really json


It is confusing to use COWORKER key for the list of commenters. Could we use a new key instead (COMMENTERS) ?


@vilchik-elena yes


Just a general thing.. It'd be nice to use the same language as FactoryGirl or similar and Rails. `.build` returning an unpersisted model and `.create` returning a persisted one. I think this is the first one we're persisting? Maybe we could call it `.create_topic`?


nice work


missing i18n, and "settings" doesn't really fit


Or just not persist it? _shurg_


TeamCity Civic Assembly :: Build all [Build 81](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1384&buildTypeId=CivicAssembly_BuildAll&guest=1) is now running


i can't find usage of this file. seems it's not included to docker.


:+1:
I was afraid that this might have been a dangerous change, but there's no deep change, just a change of order and a precision in the query that can be deduced naturally.


Code for different OS's does not work somehow.


Ha :) It looks like you responded to my comment of moments ago 21 hours ago.. impressive :)


Is that forbidden?


Your are absolutely right! That won't work.
We've used a slightly different approach (added the "client/html/template" path to the list for "controller/jobs/template"), so it's not necessary any more to use array_merge().

Can you please change the "aimeos-laravel" package to "dev-master" in your composer.json and test if it works for you too?


Ah. I was pulling from a live device.
On Feb 25, 2016 2:48 AM, "zhuowei" <notifications@github.com> wrote:

> It was originally supposed to pull from a running TWRP, hence the /sbin
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/multirom-nexus6p/TWRP-android_device_huawei_angler/commit/d30632274e1d7854da1b728c5f5da83deabfd22f#commitcomment-16319068>
> .
>


Yes, I will make sure to remove it before I do a PR - am going to keep this branch going until I get everything working with bitballs session stuff. PR will come after that. :)


Дима, именно поэтому я и рассказал тебе подробно о том, что метод делает, и попросил помочь с названием и правильным местом вызова )

> On 25.2.2016, at 16.10, Dmitry Yunitsky <notifications@github.com> wrote:
>
> А почему тогда в MwmActivity в сценарии
> if (mIsFragmentContainer)
>
> не вызываем его? Собственно, основная причина моих вопросов - ровно в этом. Совершенно непонятно, когда метод нужно вызывать и что же он инициализирует. Нужен комментарий и другое название, думаю.
>
> > On Feb 25, 2016, at 4:05 PM, Alex Zolotarev <notifications@github.com> wrote:
> >
> > Ну вот, а в данном случае один раз при старте не пойдет. Надо для каждого нажатия на кнопку Edit Place.
> > —
> > Reply to this email directly or view it on GitHub <https://github.com/deathbaba/omim/commit/b5c63b04519a811e39abfb40919402ddac14d5f5#commitcomment-16325333>.
> >
>
> —
> Reply to this email directly or view it on GitHub.
>


in task 1 you need s+=i rather than s+=1.


I think so, at least they're usually only used on an own line.


Yes!


Feel free to cherry-pick this commit locally. There's an explicit override of the version for nodejs in all-packages.nix.


zaznaczam


I suggest to keep this as `token` because this belongs to the `GitHubClient` and it does not reference the backend.


LGTM


I don't get why `TOOLPREF` shouldn't be set when using a Mac. I personally use the gcc conventions to use cross-compilers (like `x86_64-w64-mingw32-gcc`).
How are we specifying cross-compilers if not using these prefixes? Modifying the `PATH` to point to the right `gcc` compiler?
Thanks for your work!


Yeah, just for clarification, I'm pretty sure my addition of `end: false` is handled later on after `futimes()` finishes. /https://github.com/gulpjs/vinyl-fs/commit/24119a862ad062f39ed15db767feff459843c2d8#diff-22158b56af64af8f8b937f00240fbba7R44


good catch, this change was done in the very last refactor. :)


Suggested by https://github.com/Fody/Anotar/pull/66#discussion_r48254832 @ravensorb


You dont need this line.  File.open(icon_path, "rb") will raise the exception if the file is not there.


some obsolete stuff. clear map +jspm install


Le fait de séparer les fichiers est une idée. Cependant les traductions sont appliquées ainsi que des traitements de fichier, le fait de les séparer n'apporte rien. "api" ou non car il y a du sens de séparer les js/css qui sont alors les fichiers sources, ici les contenus xml sont traduits puis convertis en js dans différents modules en debug.
Le "debug" mode est aussi le "technical" mode...
D'après ton commentaire tu ne comprend pas ce qui est fait/demandé avec les traductions. C'est déjà traduit pour les xml, et les traductions du js y sont attachés, cela économise deux requètes qui au final font environ 400ms. (Il faudra peut être faire une invalidation avec une serveur action pour les traductions, je vais voir ça.). Bref, je rajoute donc un fichier avec les traductions après les fichiers xml.


Cool :sunglasses:


Why is left 1 again?


That would be fine, BUT are we sure the other memalign is 'fine' ?   Also, sparc has not been tested without the align >= sizeof(void*) in there.


Just because somewhere else uses the wrong spelling doesn't mean we should too.


Moved the package database file down a subfolder.
Need to move this into a globally accessible single variable.


Anyways, Hardness and tool type are incorrect.


あっちはあれでも十分使いやすいかなと思っているんですが、命名規則統一の観点から行くとその方がいいんですかね・・・。


Seriously?


`Jan Feb`?


oh my god so cool #letroll


Doesn't feel as though this is the correct place to have this test - I'm not too sure it fits in nicely with any of the features - might be worth just having a separate one for this.


Just want to get your attention to this:
From the hutchinson port this was not included and there won't be any looping, based on Futex semantics.
I need a 2nd pair of eyes on this one.


What are the edge cases ? AFAIK both methods are identical.

https://msdn.microsoft.com/en-us/library/adwtk1fy(v=vs.110).aspx
https://msdn.microsoft.com/en-us/library/system.net.webutility.urldecode(v=vs.110).aspx


See comment above.


See comment above


Not typo, use IDA, decompile Minecraft, check yourself.


@aodzip


@kwstannard ah interesting. We haven't run into a problem with this on exchanges. Looking back at our internal ticket I actually put this clause in place to help with an issue related to expedited exchanges. The specific issue this solved is:

1) Unreturned expedited exchange shipment breaks off onto a new order
2) Something related to the completion of the new order causes the exchange shipment to be destroyed and the tie back to the original inventory units / return items to be nullified (this part is a bit fuzzier to me on the exact interaction that causes it)

Long story short, sorry for causing a problem! I support your effort to consider reverting it, just maybe do some testing around unreturned expedited exchanges and data loss.


TeamCity Civic Assembly :: Build all [Build 81](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1384&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **FAILURE**
Summary: Tests failed: 6 (6 new), passed: 202 Build time: 00:12:21
### Failed tests
```
Basic Document Types CRUD Actions: Should Delete an Document Types: <no details avaliable>

Basic Feedback Message CRUD Actions: Should Delete feedback message: <no details avaliable>

Basic Message Recipients CRUD Actions: Should Delete Message Recipient: <no details avaliable>

Basic Message Templates CRUD Actions: Should Delete Message Templates: <no details avaliable>

Basic Subscription List CRUD Actions: Should Delete Subscription List: <no details avaliable>

Venue tests: Conference place type: Should Delete an Conference place: <no details avaliable>

```


I hesitate at the idea of hard-coding the algorithm here. It's probably fine for the password-obfuscation since it's meant to be reversible (and therefore not secure), but if this function starts getting used elsewhere in Origin, I feel like we might want to make the algorithm configurable.

Maybe it's okay if we hard-code the encryption algorithm, but we should perhaps tag the output (similar to how crypt() adds {SHA256} as a header) so that the decryption will know what algorithm to use. That way, if we discover that we need to change the algorithm in the future, users won't have to instantly migrate their existing ciphertexts instantly.

Also, I don't know what our export-compliance requirements are, but IIRC there are still places in the world where AES-256-CBC cannot be exported, so we might need to be able to support selecting a different algorithm for those nations.


Oh, it's mistake. Nowadays, we are on github, not bitbucket.


Should be indented by a tab, not spaces.


task3 ran fine for me. Yay! Your dmv function is not using a for loop or any iteration for that matter. The other four functions look good.


I can't decompile, I mean you named the class ChunkRadiusUpdatedPacket


Надо перенести метод в EditorHostFragment думаю. В onCreate, например. Тогда на каждое открытие редактора будет вызван этот метод. Ну и название nativeStartEdit
вполне подойдёт, полагаю.

> On Feb 25, 2016, at 4:14 PM, Alex Zolotarev <notifications@github.com> wrote:
>
> Дима, именно поэтому я и рассказал тебе подробно о том, что метод делает, и попросил помочь с названием и правильным местом вызова )
>
> > On 25.2.2016, at 16.10, Dmitry Yunitsky <notifications@github.com> wrote:
> >
> > А почему тогда в MwmActivity в сценарии
> > if (mIsFragmentContainer)
> >
> > не вызываем его? Собственно, основная причина моих вопросов - ровно в этом. Совершенно непонятно, когда метод нужно вызывать и что же он инициализирует. Нужен комментарий и другое название, думаю.
> >
> > > On Feb 25, 2016, at 4:05 PM, Alex Zolotarev <notifications@github.com> wrote:
> > >
> > > Ну вот, а в данном случае один раз при старте не пойдет. Надо для каждого нажатия на кнопку Edit Place.
> > > —
> > > Reply to this email directly or view it on GitHub <https://github.com/deathbaba/omim/commit/b5c63b04519a811e39abfb40919402ddac14d5f5#commitcomment-16325333>.
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub.
> >
> —
> Reply to this email directly or view it on GitHub <https://github.com/deathbaba/omim/commit/b5c63b04519a811e39abfb40919402ddac14d5f5#commitcomment-16325536>.
>


maybe this should just be 'img' and not 'xml'. im not sure what the code would do if later on  you wanted a region in which you only had one or the other cached. if the code is robust to that then this is ok but if not we may want to change it


@hamsterksu

We give the possibility to load custom configuration files, from remote or local location.

Please have a look at the [wiki](http://docs.telestax.com/restcomm-docker-environment-variables/)


Thanks, I will look into it. I ran the "Pause" command (mostly because it's included in example.php) but I couldn't see any noticeable action when that was run.

Also, very annoying with toggles, like "radio" chooses radio, but when radio is chosen again, it switches between AM and FM. HK really didn't think this interface through when it comes to automation.


too little examples!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17220](https://teamcity.mesosphere.io/viewLog.html?buildId=145905&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:08:27


test add


Hi, just a heads up that you've got your database and parse credentials visible to anyone. You should probably change them asap. (I've come across this via my Github newsfeed)


Hello GitHub


Esta errado dessa forma
public void Somar(int a, int b){
 		System.out.println(a+b);
 	}


Ок, спасибо!

> On 25.2.2016, at 16.25, Dmitry Yunitsky <notifications@github.com> wrote:
>
> Надо перенести метод в EditorHostFragment думаю. В onCreate, например. Тогда на каждое открытие редактора будет вызван этот метод. Ну и название nativeStartEdit
> вполне подойдёт, полагаю.
>
> > On Feb 25, 2016, at 4:14 PM, Alex Zolotarev <notifications@github.com> wrote:
> >
> > Дима, именно поэтому я и рассказал тебе подробно о том, что метод делает, и попросил помочь с названием и правильным местом вызова )
> >
> > > On 25.2.2016, at 16.10, Dmitry Yunitsky <notifications@github.com> wrote:
> > >
> > > А почему тогда в MwmActivity в сценарии
> > > if (mIsFragmentContainer)
> > >
> > > не вызываем его? Собственно, основная причина моих вопросов - ровно в этом. Совершенно непонятно, когда метод нужно вызывать и что же он инициализирует. Нужен комментарий и другое название, думаю.
> > >
> > > > On Feb 25, 2016, at 4:05 PM, Alex Zolotarev <notifications@github.com> wrote:
> > > >
> > > > Ну вот, а в данном случае один раз при старте не пойдет. Надо для каждого нажатия на кнопку Edit Place.
> > > > —
> > > > Reply to this email directly or view it on GitHub <https://github.com/deathbaba/omim/commit/b5c63b04519a811e39abfb40919402ddac14d5f5#commitcomment-16325333>.
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub.
> > >
> > —
> > Reply to this email directly or view it on GitHub <https://github.com/deathbaba/omim/commit/b5c63b04519a811e39abfb40919402ddac14d5f5#commitcomment-16325536>.
> >
>
> —
> Reply to this email directly or view it on GitHub.
>


is this needed?


On line 192, the logger called 'south'.


It tags the PEM block with the algorithm


Linux üzerinde çalışan ve bize bilgi sızdıran program


Thanks. I've just added the tag.


This will only work with older builds if you also add /sys/devices/kim as a fallback (which is wrong from my pov, since it's not upstream, which is why we have the -f option). But fine if you want to add that, just make sure this is not pushed to the overlay until that is properly added.


I really should use `Option.map` here.


It doesn't have a value so it's fine.


Up to declaration with comment please /** COMMENT **/


In my assembler I use the following function.
```python
def linear_constraints(om, block):
        lc.add_two_inputs_io_relation(om, block)
        var.set_bounds(om, block, side="output")
        var.set_bounds(om, block, side="input")
        lc.add_postheat_relation(om, block)
```
I do not need if-clauses within this function because the bounds for `in_max` will be set if `in_max` is defined and will be set to infinity if `in_max` is not set.

If they are set to infinity and I use the investment mode the error above is raised. This makes no sense because I do not need a constraint `in_max + in_add < inf`. Therefore the error is wrong and should be skipped. This is what my changes do, skipping the error if in_max is set to "inf" or is not set.


OK, read the docs. Fine.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17221](https://teamcity.mesosphere.io/viewLog.html?buildId=145906&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:07:58


Yeah, I'd prefer to just remove the `.img` files - they're the ones which are taking up most of the space, and they're the ones which are tested to see if they're already there to avoid re-downloading. Cleaning up the extra `.xml` files would be nice, but I think by the time we care about the space taken up by those files we'll have bigger problems :wink:


@danielpaul Compare this to http://logicify.github.io/jquery-locationpicker-plugin/#events

The drop down result of location is not working.


Do not use it on production. I will analysis new protocol tomorrow.


@hferentschik It should not `!` in front of `rep -qE 172.30.0.0.*` should take take care of it. However I am going to test it out.


I recall you being quite strict about not reopening discussions that were already had and were decided on.

I find no 100% agreement when googling but single-L is said to be common in the US. We were very strict in the past on using US spelling.

This is a package that is soon going to be in the standard library and that we are using heavily. I won't introduce friction now be varying spelling between our docs (and potentially our own identifier naming related to "cancel") and a stdlib package.


is this an unmodified dump? Do we have relative paths yet?


ack


survivalTimeInSeconds


doesn't do anything yet, huh?


ok, thank you


Can you compose a unit test for this then?


need to return after this else it will still play the shaving message.


@stulees Do we need to include this script? We're not using it yet and there's a small chance we may never need it.


It isn't wrong. From my PoV, your patch was incomplete and didn't handled that case. Reality check: not everybody is using mainline driver for TI chipset. The other way around: TI recommend to use his out of tree driver.

As uim is a daemon that I'd like to see in Debian, we want to handle it the proper way. i.e. support mainline kernel as out of tree driver.


@irungentoo which nonce is used here?


Right, so you added `pipe(..., {end:false})` and then later explicitly called `stream.end()`.

My point was I think this got kind of mixed up when rebasing the original PR for this issue, which did `createWriteStream(..., {autoClose: false,...})` and then later explicitly closed the file descriptor.

The latter bit was removed for the case of writing streams, but the `autoClose` was still in there, so it was leaking descriptors as phated found out.


XD


why do people keep using improper? didn't this bug out jump to?


Хм. Может лучше тогда абстрактным сделать чтобы гарантировать это?


this isn't really helpful info for the user, don't you think? If you really want to attribute except in the file headers where the generator probably left it's mark rather do it at the bottom like we do at the website.


I think this can be squashed with the last one ;)


Fin del programa


interesting.


seems high. but then again getting all this shit together is kind of rare.


Looks good! If you called forsum() within def forsum(), that would be a recursive function (this could get the job done of summing the numbers, but then you wouldn't need "while" or "for").


Given that we'll also have multiple processes running, perhaps this could be `3 * multiprocessing.cpu_count()` or something like that?


Атата, это что за читы? :-)


Тогда всем подклассам придётся реализовывать этот метод. Сейчас, если не используется голосовой ввод, прячется кнопка, и метод не вызывается.


@stulees `_$el.container` isn't being used. I think it can come out.


We can


No space before :


I already made a pull request.
https://github.com/markiewb/show-path-in-title-netbeans-module/pull/21
Hope that you can integrate it.


Did you fixup the right commit here?


Ok for both


I'll upload a screenshot of MC decompiled.


this commit needs to be before the other one! git rebase interactive will do it for you, you know tht one?


Closes #1 and #2.


@TDiva Спасибо большое за замечания! Постараюсь всё учесть и поправить! :)
Английский, как раз, решила доверить Гуглу.. И тупо сделала ctrl+c, ctrl+v..Это тоже исправлю!


Won't this `return` bypass the `_superfluous.release()` below?

I've been making RAII-like things with Python's context manager like this:

```python
@contextmanager
def lock_array(a, **opts):
  a.acquire(**opts)
  try:
    yield a
  finally:
    a.release()
```

Then doing `with lock_array(_superfluous) as s:` means we don't have to worry about deadlock.


More mental notes, what do other projects return in similar(ish) encode cases?

| Function | comments | Python 3 |
| --- | --- | --- |
| `hashlib.<hash>.digest()` | | bytes |
| `hashlib.<hash>.hexdigest()` | | str |
| `django.BinaryField.value_to_string()` | intended for consumption by database layer | str |
| `django.utils.http.urlsafe_base64_encode()` | intended for transmission over http see also [ticket 23333](https://code.djangoproject.com/ticket/23333) | bytes |
| `dango.hashers.<hasher>.encode()` | intended for consumption by database layer | str |
| `django.core.signing.dumps()` | Serialize & sign objects in url-safe encoding | bytes |


int[] tagArraya = new int[10];
int[] tagArrayb = new int[10];
int[] tagArrayc = new int[10];
int[] tagArrayd = new int[10];
でいいんじゃないかな？


Can you log this message to error?


yes!

      De: R.S <notifications@github.com>
 Para: degaray/magento2-gmailsmtpapp <magento2-gmailsmtpapp@noreply.github.com>
CC: degaray <degaray@yahoo.com>
 Enviado: Jueves, 25 de febrero, 2016 6:18:01
 Asunto: Re: [magento2-gmailsmtpapp] add configuration from_email so it works with providers usernames other than email (217d1de)

What amazon service are you using https://aws.amazon.com/ses/ ?—
Reply to this email directly or view it on GitHub.


![image](https://cloud.githubusercontent.com/assets/8733998/13321180/c8badbd8-dbcd-11e5-9d80-804d295d6c51.png)
![image](https://cloud.githubusercontent.com/assets/8733998/13321188/d39caeb4-dbcd-11e5-817f-6f08f9498906.png)

**** YOU SEE? ****


help="This taxes will be copied to the product customer taxes everytime you change product's category"


Python, like C++, treats the empty string as "falsey", so you can just write `if s:`.


@stulees Do we need to log these to the console? It makes it more difficult to debug issues when there's so much stuff being put in there.


I can't find that previous discussion.

Cancellation is by far the more common spelling, and the spelling here stuck out like a sore thumb to me. There appears to be no agreed spelling in the US (e.g. https://www.airbnb.com/home/cancellation_policies), and hints that cancelation has always been a misspelling even in the US. US dictionaries point to two ls.

This is a word that appears only in the comments in that library, it's not in any identifiers so let's stick with the correct spelling in US and non-US English which is cancellation.


Indeed, thanks


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1334.a0f445e64f06b9ea5997d37f779cfbb5eb3e1e24](http://build.palaso.org/viewLog.html?buildId=69663&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 1019, ignored: 12 Build time: 00:07:20


I'm slightly surprised this works... does it set the string in the shared array to blank? If so, probably needs a comment, as I thought this line was a no-op, since `s` is the loop variable and would get overwritten with the next value anyway.


perhaps writeFileSync


per phpdoc.org its required to be on a new line

> These provide a way to succinctly and uniformly provide meta-information about the associated element. This could, for example, describe the type of information that is returned by a method or function. Each tag is preceded by an at-sign (@) and starts on a new line.

see http://phpdoc.org/docs/latest/getting-started/your-first-set-of-documentation.html


You don't need to create an array list every time when user asks for books list. Please create a field in the class with array list and return its value, when asked


Hey guys before I open yet another issue...  Could you please have a look at my console output below?

Till today I was assuming that the behaviour I see is a bug. But now I am not sure anymore.

Here is what I do:
- I have a list view with `posts`.
- I initially fetch the first batch of posts (page=1).
- But if I have very few (?) posts to display `onEndReached` gets called over and over again.

**Is this actually a feature and not a bug?** :confused:

![isthatnormal](https://cloud.githubusercontent.com/assets/1672198/13320286/2463fed4-dbc8-11e5-822a-b996dc4aeb4a.png)


Great! =)


Also add  the methods for adding and removing books to the class BookShop


Yes, Maybe I haven't understand, where you created a class called ChunkRadiusUpdate**d**Packet, but here you are trying to call ChunkRadiusUpdatePacket...


These `lambda` functions do not actually take from the lexical environment, and so will fail with `lexical-binding: t`. More thought required.


be more specific which fadvise it is about? e.g. `use_fadvise_dontneed`
(same remark for all the other config files)


Good point. I used to have box_id as unsigned, but it isn't anymore.


Do not use `backend_` prefix on client parameters.


Some changeswas made


You left out all the sources indicating the opposite. I won't discuss this
further.

On Thu, Feb 25, 2016, 2:43 PM Brian Brazil <notifications@github.com> wrote:

> I can't find that previous discussion.
>
> Cancellation is by far the more common spelling, and the spelling here
> stuck out like a sore thumb to me. There appears to be no agreed spelling
> in the US (e.g. https://www.airbnb.com/home/cancellation_policies), and
> hints that cancelation has always been a misspelling even in the US. US
> dictionaries point to two ls.
>
> This is a word that appears only in the comments in that library, it's not
> in any identifiers so let's stick with the correct spelling in US and
> non-US English which is cancellation.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/prometheus/prometheus/commit/572ab2989efc111cfca6a5866dc171129c329236#commitcomment-16326238>
> .
>


Brady,

I am able to fix the calendar issue

I just updated Smarty from 2.3 to 2.6 and now it is working

I had to do some tpl changes like in many calendar views I changed "$this->_tpl_vars['PRINT_VIEW']" to $PRINT_VIEW

Next I will try to centralize the smarty library as 2.6 is php7 compatible and we can change it easily

Smarty 3.x is almost rewrite and we need many things to change to work with smarty 3 as I tried and could not get success


It didn't seem worth it, since we're using an old version of the `elasticsearch` Python module for 0.90 compatibility; go ahead if you think it'd be worthwhile to do.


dragon


ach, missing brackets! tsshh


I miss documentation about `user` and `password` parameters.


There is a problem with buckets and collection. A db can contain both collections and schema stores. So you need to get the two arrays and merge them (for instance, using lodash) eventually.

Also the embedded resources of schema stores (URI /db/_schames) are rh:schema


Not supposed to work that way.


Very user-unfriendly message. Consider rewriting it.


Я про это и писал на хабре - мы меряем скорость фреймворка, а не тормознутость JSON.stringify

Если смотреть с точки зрения рабочего приложения - оно работает корректно.
Но я бы вообще вырезал сохранение для всех тестов, оно просто добавляет +100-200 мс и этим можно спекулировать.

можете просто в тесте замокать JSON.stringify = function(){} и тогда все будут равны.


Is there a reason to return null?


OHMAGERD MY FAULT
Sorry, i am sick and my brain doesn't work well.
> Yes, Maybe I haven't understand, where you created a class called ChunkRadiusUpdatedPacket, but here you are trying to call ChunkRadiusUpdatePacket...

this cleaned my brain again.. soz


Move this import  up


Right, I see that now. So that alleviates one concern.

We discussed on IRC about the export compliance: the issue is that if we hard-code this value, the function may fail unexpectedly if the underlying crypto library does not have that algorithm (such as in cases of export compliance).

Since this isn't a core piece of functionality, I'm okay with not blocking the review on it.


Yep, I think so - the duplicate meta class was shadowing the one that should have introduced this constraing.


only first two rows are needed, remove everything from here


Oh, that's new to me :) I'll change that.


Then what's the point of commenting that it's self-explanatory if it's self-explanatory?


Please add the new line :)


dont know yet, each iteration takes a while to test


> мы меряем скорость фреймворка, а не тормознутость JSON.stringify

или другими словами - AL отвечает только за отображение (V+VM), он не имеет никакого отношения к сохранению в json на сервер или ещё куда, поэтому нечего вешать на него чужые "касяки".

Самое главное что идет прорисовка всего (DOM) как у всех.


USBMINER DUAL S5


https://github.com/barryg613

USB MINER DUAL GRIDSEED S5 LTC & BTC with new firmware :)


Das wird nun allerdings erstmal 404 Fehler generieren, falls irgendwer doch auf OGV laden will. Oder kommentieren wir das im MediaWiki lieber auch ganz aus vorerst? Würde eben alle Videos betreffen.


Sure, I'll make that change


I'd forgotten we were on an ancient one. I wouldn't bother then!


Oh yes, I missed that - thanks


In reply to https://github.com/aduprat/james-project/commit/e69b6cea3124180dda6743d499452fe40a75e540#commitcomment-16296090

* the first test `containerShouldBeReachable` may fail in case of the 80 port already used on the docker host
* the second test `containerShouldBeReachableOnExposedPort` may fail as the docker host may not be localhost

Other comment:
The `GenericContainer.getContainerIpAddress()` method return null in case of docker host equals to `unix:///var/run/docker.sock`
I've made a patch, but not send the PR as i don't know if it's the good solution:
https://github.com/aduprat/testcontainers-java/commit/dc862f23813f68b7f7211a4ffbc4d336e17cb749


Made tokentype more precise


We also have the edit().done() thing that could be used for editing objects.
Also for deep copying visitors rock:

replicationControllers().inNamespace(namespace).withName(oldRC).edit()
.accept(new Visitor<ObjectMetaBuilder> {
   public void visit(ObjectMetaBuilder b) { b.withName(newRCName).withResourceVersion(null) }
}).accept(new Visitor<ReplicationControllerSpecBuilder>{
   public void visit(ObjectMetaBuilder b) { b.withReplicas(0); /* blah blah blah*/ }
}.done();


@Patater you can make box_prefix an optional parameter for UVISOR_SET_MODE_ACL (variadic macro)


comment no longer accurate


21600 is 6 hours


This value should be configurable


Мне кажется странный дизайн. Забыл спрятать кнопку - получил креш.

> On Feb 25, 2016, at 4:36 PM, Alexander Marchuk <notifications@github.com> wrote:
>
> Тогда всем подклассам придётся реализовывать этот метод. Сейчас, если не используется голосовой ввод, прячется кнопка, и метод не вызывается.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/trashkalmar/omim/commit/45546572def668913846f9571fd846911360d356#commitcomment-16326072>.
>


These changes won't really solve the issue unless `whis = 'range'` in line `1971 `is changed to `whis = input_whis`


Why is this expression using the operand `<=`? If you got the total of issues, why do you need to ask for more?


Hi Michael,
du hast auf https://elearning.physik.uni-frankfurt.de/projekt/ticket/1291 ein Ticket dazu erstellt. Dort haben wir jetzt schon fröhlich diskutiert und eine Idee, wie wir es beheben wollen. Es wäre gut, wenn du deine Schritte dann auch in diesem (deinem) Ticket dokumentierst, denn was du gerade committed hast, würde Lars sonst am Wochenende wieder machen wollen.


Добавь библиотеку которую используешь в репозиторий. С теми что мы давали в примерах я не придиралась, а вот искать для каждого свою - это уже черезчур.
А то код естественно не компилируется.


why the linebreak?


Can you elaborate?  That looks like an intentional special case for when the first and third quartiles are identical


Is it possible for this section to ever be genuinely ommited via a compiler we ship?


can't you use
```
InvalidXMLTest = verify.....(
    XMLBear,
    ...,
    ...
```


@firebait I have not used atmospherejs, but I can't see any harm in making it available there.


if that's needed to avoid those ugly linebreaks later I'd prefer it by far!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17224](https://teamcity.mesosphere.io/viewLog.html?buildId=145933&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:04:00


`url` parameter should be positional argument, not an optional one because without this URL the backend won't work.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17222](https://teamcity.mesosphere.io/viewLog.html?buildId=145928&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:10:38


couldn't that be simplified with some kind of reduce?

```
forDefaultMaybe :: Foldable t => t [Maybe a] ->  a ->  [a]
forDefaultMaybe xs deflt = map (\
  case (Just val) => val
  case Nothing => deflt
) xs
```

not sure. there's probably something somewhere that eases this...


* `A.row(0)` was processed by `auto row row(in size_t) inout`, which does not copy the elements.

Currently:
* `A[0, 0]` is processed by `auto ref inout(T) opIndex(size_t, size_t) inout`.
* `A[0, 1..2]`, `A[1..2, 0]` and `A[1..2, 1..2]` is processed by `const` method which deeply copies the elements.

Design:
* `A[0, 1..2] *= 2` may make sense.
* The manipulation of `a` after `a = A[0, 1..2]` shouldn't affect original `A`.


Too many options ;)


Yes ... yes, it should be removed.


Если ты не спрячешь кнопку, она будет нерабочая, так как для разных классов нужно реализовать разную логику (вызывать startActivityForResult() у фрагмента или активити).
Крэш - это более предпочтительный вариант, ИМХО.


`getContainerInfo().getNetworkSettings().getIpAddress()` should be the container IP whereas `DockerClientFactory.instance().dockerHostIpAddress()` should be docker host IP


Is this going to be public at some point?


Oops. Didn't realize that I'd had my wolfram ideas in the last commit. Please use your own instead of mine.


Can you rename this to: "`ember-cli-actions/mixins/action` is currently only applicable to routes"


Maybe it's not the best method to validate an ip address. What about this http://stackoverflow.com/questions/319279/how-to-validate-ip-address-in-python/319298#319298?


ww


yeah sure


Also, can you change all double strings from double quotes to single quotes?


rogue href :D


This commit will probably cause lots of existing code to generate DAE that crashes importers https://github.com/IfcOpenShell/IfcOpenShell/issues/36 However, this breaking change is easy enough to overcome by adding openAsset() and closeAsset() calls in the client code.


yes :)


One thought, why change the receiver to Celsius when one can just convert Fahrenheit to Celsius?  I do though, understand what you previously stated concerning the less than Celsius values, and that would make sense.

This receiver device, as far as I know, does not provide any logging from the receiver unless the logging is manually entered into a computer.  Looking over the code now, seems magic only works for a selected few that intimately understand it. ;-)


@leftyb, clear. please close this pull request


Is this safe to go into branch-1-8? Is it worth a NEWS entry?


в Java принята специальная последовательность объявления полей и методов в классе. Например, если ты запустишь форматирование кода (https://www.jetbrains.com/idea/help/reformatting-source-code.html) в идее то она переставит эту строку первой, так как константы принято писать в самом начале.


hm... do you have some IM? btw... pull requests are very welcome, I'm not sure if I fully understood idea


Hier bitte keinen Force-Cast machen, sondern die if let Variante nutzen. (Alternativ sogar guard let, weil der Code keinen Sinn macht, wenn der View eine andere Klasse wäre.


one more rogue href attribute!


Dafür am besten // TODO verwenden, dann wird es in Xcode in der Datei-Struktur hervorgehoben.


True, thanks


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17223](https://teamcity.mesosphere.io/viewLog.html?buildId=145929&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 238 Build time: 00:09:33


why remove the why run?


@matt-manywho could you change this to `columnName` as it seems like that's the convention that's used elsewhere in `ListFilter`?


Wollen wir die App eigentlich lokalisieren? Wenn ja, dann sollten wir das besser von Anfang an schon bedenken und entsprechend die Struktur aufbauen.


I don't get why TOOLPREF shouldn't be set when using a Mac. I personally use the gcc conventions to use cross-compilers (like x86_64-w64-mingw32-gcc).
How are we specifying cross-compilers if not using these prefixes? Modifying the PATH to point to the right gcc compiler?
Thanks for your work!


Cool @jonathantneal ! I assume you will add a tag and update [precss](https://github.com/jonathantneal/precss/blob/master/package.json) to this version. Then I can get postCssImport out of my project ;)


Keeping it like this

```
InvalidXMLTest = verify_local_bear(XMLBear,
                                   valid_files=(valid_xml_file,),
                                   invalid_files=(invalid_xml_file,),)
```


240/255 müsste 0 sein. Sollte als 244.0 und 255.0 geschrieben werden, damit es als Gleitkommazahl erkannt wird. Noch besser: eine extension, die diese Funktion beinhaltet. Das ist was für den Core :)


@matt-manywho I think this should be `orderDirection` or something, as the `orderBy` is a bit redundant and less easily human-readable


Du hast deinen Indent in Xcode noch komisch eingestellt, das müssen wir das nächste mal fixen ;)


neat

Sincerely,

Lasse Schuirmann

contact@viperdev.io
http://viperdev.io/

2016-02-25 15:03 GMT+01:00 Sanket Dasgupta <notifications@github.com>:

> Keeping it like this
>
> InvalidXMLTest = verify_local_bear(XMLBear,
>                                    valid_files=(valid_xml_file,),
>                                    invalid_files=(invalid_xml_file,),)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SanketDG/coala-bears/commit/dad3572eea5e600591ad9877d04a852e4352fa02#commitcomment-16326764>
> .
>


```java System.currentTimeMillis() ``` - возвращает текущее время в миллисекундах.


This was on Ubuntu 14.04 on gcc 4.8.4 -- I needed it to get the cpu set
things it seems. But I wouldn't worry :)

On Thu, Feb 25, 2016 at 12:53 AM Ryan Hitchman <notifications@github.com>
wrote:

> what compiler did you need this on? I thought --std=gnu99 implied
> -D_GNU_SOURCE
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mattgodbolt/whomp/commit/361abd55cf796856d4cefcce3f50eb915e21543a#commitcomment-16318421>
> .
>


добавляй в гитигноре, на не хочу я читать это)


ya it's still there, it's just included in the icons directory now with the apple touch icons and ms icons


uhm, sure, i use skype and gmail chat.


The problem was that you had a space instead of a tab between `Palatis` and `KEYWORD1`