> testing import at least (and only) assures that the module exists and doesn't have syntax errors.

Importing the code in the module is the single (and smallest) unittest that doesn't need to be written as a test.

> I always start with a really simple test that imports, and usually one that instantiate the class if there is a class int eh module -- basic tst driven development -- I do that before even writing any code.

That we can, and should, test with a `assert isinstance(Instantiated, Class)`.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/9308/testReport/) for this commit**


这个测试方法忘了注明只是为了测试在有 `.CallbackDispatchQueue(customQueue)` 这一 option 的情况下回调都会被 dispatch 到 customQueue 上去，这一行为并不是在实际使用中预期的行为，好像是有点多余，应该考虑去掉这个测试用例。至于为了测试在正常使用 `kf_setImageWithURL` 时回调应该在主线程，我在测试方法 `testImageDownloadForImageView` 中的回调里加了断言 `XCTAssertTrue(NSThread.isMainThread())`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15965](https://teamcity.mesosphere.io/viewLog.html?buildId=136216&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:25


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15967](https://teamcity.mesosphere.io/viewLog.html?buildId=136224&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:00:41


This fails when self._fill_value is a numpy scalar of kind `S` or `U`.  See issue #7259.


last line is missing semicolon and timout value. will create new PR asap


Yeah, i should have double-checked the git log. It seems there's another error too which was already affecting the commit earlier today.


I missed the `->` at the end of this line, causing the first case to drop through to the second, thereby making the authentication fail.  D'Oh!


Segur q no esta be. Pero es l'únic q tinc fet de la semana passada. Si et serveix algo, dons be.


поддерживаю!


The XML is valid if the libName is not populated if secmgrPlugin is not selected.  The esp.xsl will validate for empty fields.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15966](https://teamcity.mesosphere.io/viewLog.html?buildId=136217&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:05:18


According to the documentation, g_subprocess_launcher_new always succeeds.


Ahh, it should have been rm -f $LOGS/*, but your solution works fine too.


@rewritten sure thing


Manque un return


et la un de trop ::))


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15968](https://teamcity.mesosphere.io/viewLog.html?buildId=136229&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:38


On a Windows 7 with German locale I get the following error with the latest version of SIM which seems to be a cause of this commit:

   1 15:47:31,478 INFO  **********************************************************************
   1 15:47:31,478 INFO  **********************************************************************
   1 15:47:31,478 INFO  Error during checking IIS state
System.InvalidOperationException: Der Dienst World Wide Web Publishing Service wurde nicht auf dem Computer . gefunden.
---> System.ComponentModel.Win32Exception: Der angegebene Dienst ist kein installierter Dienst
   --- Ende der internen Ausnahmestapel³berwachung ---
   bei System.ServiceProcess.ServiceController.GenerateNames()
   bei System.ServiceProcess.ServiceController.get_DisplayName()
   bei SIM.Tool.App.CheckIIS()

Using the SC [0] utility I found out that the service _W3SVC_ has the displayname _WWW-Publishingdienst_.

[0] https://technet.microsoft.com/en-us/library/bb490995.aspx


There is a custom equality for types. And `t-number` and `t-string` are not builtin types, thus the use of equality rather than the `is-` predicate.

I've also changed `pick2` and `pick3` to take `(A.Loc -> Type)` now, and there's no need for an extra argument as it's in scope from the closure. I'll be pushing that now.


Check out some of the other tests that are in this class.  They are hooked up using `NSubstitute` and `IControlCandidate<T>`  for improved maintainability.  It'll prevent the need for storing the local `beforeRunRan` too.


Redstone not restone


@Divjyot please remove LOL


The libraries are being brought in with bower now, you'll need to run `bower install` to get those files.


Rapaz, o "playerInvulnerableState" dentro da classe deveria ter o 'p' maiúsculo, não está batendo com o cara que voce instancia no AliveState:
`invulnerable = PlayerInvulnerableState.new()`
```
function playerInvulnerableState.new()
    ...
end
```


Note: Although dimensions are available immediately, they may change (e.g due to device rotation) so any rendering logic or styles that depend on these constants should try to call this function on every render, rather than caching the value (for example, using inline styles rather than setting a value in a StyleSheet).

https://facebook.github.io/react-native/docs/dimensions.html#content


Yes, it should. However, we don't have the test infrastructure for this yet. Let's add it later.


Je vois que tu traduis dust par broyé: pourquoi ne pas utiliser "poudre de" à la place?


reack


api-version should not be hardcoded


@tituswinters I've updated my PR with the original text and left the logo underneath.


je m'y ferais jamais a l'espace lol


The URL manipulation should be its own method


done


So now, when any player does any of these things. The sender reference is set?


right!


commit


Like for libpng and icu, the package should be named ffmpeg3 (or ffmpeg30?) so the transition can be made smoothly. Until we can convince libsolv that it's ok to install different versions of a package side by side, that is.


Brackets on their own line.


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/tests/bearlib/abstractions/LintTest.py`, line 104.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/bearlib/abstractions/LintTest.py
+++ b/coalib/tests/bearlib/abstractions/LintTest.py
@@ -101,4 +101,3 @@
         self.assertEqual(
             self.uut._create_command("filename", config_file="configfile"),
             "echo -c configfile " + escape_path_argument("filename"))
-
```


Use the primitive rather than the wrapper.


Ok. I could change it for this code:

```javascript
var url = this._baseLayer.getURL();
var params = L.extend({}, this.options.getCapabilitiesParams, {
  'request': 'GetCapabilities',
  'service': 'WMS',
  'version': this._wmsVersion
});
url = url + L.Util.getParamString(params, url, params.uppercase);
```


其实我起初的想法是希望将 queue dispatch 的逻辑全部封到 ImageDownloader 中去，这样无论是在 manager 还是在 UIKit extension 中回调里面都不需要再进行 queue dispatch（这些回调最终被调用是在 ImageCache or ImageDownloader 里），处理 queue 只需要通过为 KingfisherOptionsInfo 赋值来控制


Add a comment that this copies the content from variables to the handler's environment.


Issue for this is #1203.


@kbrock thanks a lot for clarification!

One other thing:
There is `MiqGroup.with_current_user_groups`, so there are just listed groups of that user. What should be displayed as selected option in select box of group in ownership screen, when there is selected different group/tenant then user's groups(it could be selected for example by admin ) or we shouldn't display this select box at all in that case ? Now there is displayed in that case "No Group" but I don't know what it should be displayed when it will be removed.


Yes, I will start on this - thanks Nathan for setting up the figure order, I'll be trying to paste in knitr code chunks, renaming the files, and creating a build script (bat file) so this will follow the same build method as the doc itself.


J'aurais fais
```js
 if (!validate(json)) {
...
}

return true;
```


This method looks a lot like something we do with NMS integration, perhaps that solution can be generalized.


reack


Did you mean to get rid of the feature where we automatically detect if people are just missing the selection file and download that?


thanks for your submission. It fixed same problem in my fork.


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=2)


The declaration of httpResponse can be combined with the line that does the first assignment below.


Je pense qu'on va souvent vouloir aller chercher les Journal pour lesquels l'utilisateur a la permission X. Crois-tu que ça pourrait valoir la peine de mettre ce check dans un manager custom ?

https://docs.djangoproject.com/en/1.8/topics/db/managers/#using-managers-for-related-object-access


Yeah, I needed it on Ubuntu at least. Ifdeffing this for OS X and Windows is probably a good workaround. (On Linux, we don't statically link against SDL2 for now).


We just checked that outline is not NULL. Drop this assert.


O problema que acontece de encontrar nil na music na hora de carregar é devido a isso:
main.lua
```
function love.load()
  RPG_Logo.load(1.5,1.5,1.5,love.startGame)
  game.load()
  state = RPG_Logo
  audioManager.load()
end
```
O load do game puxa o load do gameManager que puxa o load da arena que é onde você tenta dar play no audio, o que ocorre ANTES do load do audio, ou seja, você tenta tocar um audio que ainda não foi carregado, logo é nil. Consertamos botando o load do audio antes de todo o resto (afinal, o load do audio não depende de mais nada, enquanto no caso contrário, sim)


Since there is ongoing discussion about that, let's remove this scenario from this PR... :(


OK..
Let me check meanwhile can I have those files so that i can place in the desktop folder and upload in chrome extension directly.


Maybe a Map<Text,Index> could  solve that issue and would also increase the performance.

Please include serializability and basic multi language support (named/indexed params). See my PR for other features.


Have you tried this with the Electron?  I'm pretty certain this will break it since connect_cancel() for electron pauses all AT commands.  This would keep network_disconnect() and network_off() from sending the correct at commands to disconnect and power down the modem.


On passe de l'anglais au francais dans Usage !


Bien vu, j'ai ajouté le editorconfig car il manquait


New file please


thanks Joe, will do!


@rewritten @naoisegolden maybe we can opt out the EN translation and open another PR to add EN

meanwhile I'll manage to merge the first one


This is listed as `degbugInfo()` in the PHP docs, with the camelCase.


Py_TYPE was introduced in Python 2.6, but the README says pcapy works on Python 2.1.3 or later. So, to re-define Py_TYPE macro or to update README?


The `sort` method can also take a `null` value as its parameter, in which case the `ArrayList`'s elements will be sorted according to their natural order (by use of the `compareTo()` method which must be implemented for the type of `Comparable` elements contained in the `ArrayList`).


We still need this hook to see the event_info plugin. Will you add it to [https://github.com/MidCamp/midcamp-website/pull/21](url)?


c'est mon côté bilingue , je corrige


ok


I guess we'll need this translation more than once. I would have a function `categoryName` and make use an `Enum` instance to get `categoryValues = [ (c, categoryName c) | c <- allCategories ]` where `allCategories = [toEnum 0 ..]`


one sec.


This is the AWK edit of Josh's original suggestion aimed to clarify and satisfy comments from Jason White and Sailesh Panchang.


ici aussi (0_0)


@Sunilkumarr there is extra space before 1?


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=3)


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1299.31b9776eb10c229ff5ecf029aa4b9aa18b7edebf](http://build.palaso.org/viewLog.html?buildId=69197&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 973, ignored: 12 Build time: 00:07:46


Well now the work will just go down to 0 by 1 every time a block is mined.


@khanson679 How does using anchors duplicate information? But if that's the case, then yes, I agree that finding an alternative would be better.


I've addressed all of these issues and pushed in the changes.


we're fixing things dw


Complementando, mandar a música tocar não deveria estar em algo tão específico como no arena.lua, mas sim na função de start do gameManager


Done 9771ff2


OK. So I gonna remain this comment removed in the next commit.


No, the RAILS_ENV was right. The default env is "development". But `Rails.configuration.database_configuration[Rails.env]` will return the db config from database.yml, ignoring the RAILS_DB setting and ignoring multisite.yml.


在 ImageDownloader 中的实现没有用到 ThreadHelper 里的方法，是因为调用传进来的 completionHandler 时只有两种可能，一是在 processQueue 中调用，二是在新加入的 sessionDelegationQueue 中调用，不会出现在 main queue 中调用 completionHandler


Умница что перехватил исключение,  а еще timestamp должен быть > 0 :)


Yes that is better. Will change it.


Check the length with g_strv_length.


Il manquait l'editorconfig d'où les incohérences https://github.com/Interencheres/cpm-validator/commit/889cc377bc5985fa4ba8210db77a94c2ebda190a


Yo! I checked, and exporting text is, like, sub-a hundredth of a second for each Text object of a normal length, and using numpy.concatenate doesn't help here. So, I don't think we can get Text export faster than this, haha. Maybe the cost of running concatenate (and doing whatever numpy does) offsets the gains of running the function on what's probably a small amount of vertices per text object?

The normal function takes around 0.2 seconds for 35,968 face text object, which is, like, 19 lines and around 29 characters, average, per line.

The numpy function takes around 0.4 seconds per Text object.


@khanson679 Okay, that makes sense. To be honest, though, I don't think any of the people in the database currently have ORCID IDs, so you could probably go ahead and delete them if you'd like.

If you have an idea and want to go ahead and implement in a different branch, that sounds like a good plan to me!


This one is not split over multiple lines because that appears to be the style in carla.cpp (as well as using spaces for indentation instead of tabs).


`@diff_image ||= @mode.diff(@image, @diff)`


Just made a separate PR to `HEAD^` (#2) so once merged we will have this (#3) with just the english translation.


Ups, da hast du natürlich recht. Die Variablen sind tatsächlich lokal, hab total übersehen, dass das alles innerhalb der `ready()` liegt.


Use g_strdup on the strings and g_strvfree on the split array.


`@mode = mode.new`


Make sure to free allocated resources.


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=4)


Hi all.

The Library use the Serial Bridge BLE  and make it ready to use the BLE on the SmartEverything as a Serial connection, allowing the send of streams of bytes.

It could be that the FW present on your SmartEverything is not the one is needed for this library

In order to known if this is the case, please send an email to
**development@axelelettronica.it ** with the:
S/N,
ID and PAC.

Together with your shipping address and we will proceed with the substitution of the BLE chip is in your hand if it comes from the wrong stock.

In order to speed up our  internal steps, please replay this email using the same subject :
"**replace of TDK BLE of SmartEverything FOX**"


Just one empty line.


 Эта строка в целом не то чтобы бесполезная - просто в настройках не используй кириллицу.
Там же пишется документация на класс, с указанием автора и его email.


Do not forget to add 'form' suffix, it make code more transparent.


```ruby
def initialize(result)
  @result = result
end
```


There are a couple of warnings in AzureInfrastructureProviderConfig that need to be cleaned up.


`def compare(a, b)`


@gabrielamatias should be synch not sync - a typo from me sorry!


Use this as the commit description:
"We add pre- and post- handler into the installer, this way we can react to conditions
before and after any installation. This handlers are called independent of
the custom_handler in the manifest."


ImageCache 里的情况似乎更复杂一些，暂时没有考虑完善


I agree `selectHandler` is more explicit than `appSelect`, however it differs from the directive attribute itself which may be confusing/cumbersome as you need to check the matching from the `bindToController` property.

We already use the `app-` prefix for directives/attributes of our application. What would be the rational for prefixing with the directive itself?


`@delta_score += d`


@jaeilepp it seems here is a bug when sfreq is not passed and tmin/max are None, you essentiall subtract inf ... this will yield a mask of false values.


@gabrielamatias the hyphen should be written as `&ndash` instead of -


I changed this to True to match the Solr docs & avoid needing to handle a third state


Typo above was fixed in a follow-on commit:  `connect` should be `sql-connect` in the poor-man's sql-sync-pipe.


@gabrielamatias same here `&ndash`


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=5)


@IlyaEremin Согласен, вырывая из контекста - не описательные. В данном же конкретном примере первое активити для реализации функциональности с помощью сторонней библиотеки, а второе для нативной реализации.

Может у тебя есть предложения как переименовать?


`list of json objects, and write them to a file`?


Can we at least use something like %{_exec_prefix}/lib, here?


@rewritten perfect, many thanks! I hope I'll have time tonight to merge it!


@gabrielamatias couple of tiny changes (one my fault!) but all good apart from that. Thanks!


whaaaat?? :fearful:


but `config_base` is automatically generated during startup. Before run `_start_beamtime()` we would have a `tarball` and a `config_base`


z-index seems odd..


works for me :)


Why is there now a factor of 10 here?


The new function should go into src/context.c, as that will be the only user. Also add a unit test.


We might want to create a filter for this. What do you think?


It's fixed. Thanks. The number ~3500 is perharps related to char[4000].


Отлично пользуешься Java, молодец.
Подсказка - такие штуки с mode и так далее можно реализовывать с помощью функциональных интерфейсов. Просто вместо switch и списка операций хранишь мапку: id операции -> функция которую надо вызвать. Это так, на попробовать :)


OK, here are my thoughts.  I'm posting them here first just so we can come to some agreement, then we can figure out how to make the changes.

1.  I would make partial results the default behavior.  This would mean that the request would instead have a bool field like StopOnFirstError instead of PartialResutlsOK

2.  All search results would then report some sort of additional "status".  For the normal search case its just something like "success": 1, "failed": 0

3.  We use the existing SearchResult merge function to figure out how to sum these things up.

4.  The code we have today that bails out as soon as an error occurs would now also check the setting for StopOnFirstError.

5.  It would also be nice if people could know "which" aliases failed, and possibly the error message.  I don't know if this is feasible, but could also be left for future enhancement.


Shouldn't this be a value from AzureResourceManagerClient.DeploymentState instead of a string?


"survey" contains already the unpickled data. Just do:

    survey.sheets = []

and I have decided that "reset" should reset completely, so add

    survey.questionnaire_ids = []

In the end run "survey.save()" in the cmdline handler.


use the `$>` luke :)

`processor result $> redirectOf page`


Maybe some checks are missing from the ESLint linter. Do we want to keep this rule?


модно, оценила


As a best practice, this should be using `$db->insert( ... );`.


But its interesting that setting the previously larger value had no effect.


Likewise, this should be using `$db->upsert( ... );`.


This line is inside the RobotBuilder auto-generate zone, as indicated by the comment on L15. If we used RobotBuilder after this point, these variable declarations would be erased. Move them above the comment.


В консоль пишешь  error а в лог - warning. Надо решить насколько критично это исключение и унифицировать.


:+1: This is the confirmation that the abstract factory and the IoC was necessary


Yes, I checked this and we can put `gettext()`on the `alertsService`.


LGTM, I'm looking forward to use `redirectFormHandler` to create topics.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15969](https://teamcity.mesosphere.io/viewLog.html?buildId=136238&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:46


__SSE3__'s not good enough here.  Gotta be __SSSE3__.


The same method is already being used when the user manually enters listening mode, so this is just extending that to programmatic control. The intent is to cancel just the connect command, not all commands.  Sounds like the Electron implementation is overreaching a little?


>  What would be the rational for prefixing with the directive itself?

That's what we (at least me :P) do in the project, see https://github.com/c2corg/v6_ui/blob/master/c2corg_ui/static/js/documentediting.js#L94-L101

It seems to be the same in ngeo, for instance: https://github.com/camptocamp/ngeo/blob/master/src/directives/desktopgeolocation.js#L32-L33


I'll try to give some more context on this:

[base,left] and [base,right] might have disjoint sets of commits, but I'm pretty sure there are cases where the sets are not disjoint but contain some shared commits (i.e., they merged the same topic branch). As for the timestamps, I would indeed expect overlapping.

The change in this commit was rather a quick work-around and is of course incompatible to the commit analysis that codeface usually does. We don't really plan to integrate those changes into upstream, as we just came up with this as a quick hack for a colleague of us, who is working on an analysis of merge scenarios and would like to use some results of a codeface run. I think his project is this one: https://github.com/alcemirsantos/repos_crawler

So he has a bunch of scenarios where he created tags like base1, left1, right1, base2, left2, right2 , ... and he only wants the results of (baseN, leftN) and (baseN, rightN), but never sth like (rightN-1,baseN). This is why we splitted the list of tags into triples.


Make key and value gchars. Handle the casting at the g_hash_table_iter_next call.


This all looks right to me.


Oops, the commit message should read "such as issue #49"


Hi ,
Nice ! But for me it's missing some tests.
For all wrap , we should test 0 and same negative value as positive one. Make at least a test with int and a test with double which must failed !


:+1 merge after rebase


I'm afraid this commit may create many conflicts in [ODBCSybase branch](https://github.com/pocoproject/poco/tree/ODBCSybase). @kostya-lnk-ms could you check what does this do to the branch?


Does this need to have an exception thrown here or should we be able to correctly communicate the status be setting a failed state on the deployment task? This method also doesn't account for multiple deployment operations failing, it throws on the first one.  We should collect all failures and report full status.


Problem here is that `AutoAim::GetTargetValue` is not a static member function. If you want to reference this method without instantiating the `AutoAim` class, put a `static` keyword for that function in `AutoAim.h`. Note that you do not want to put the `static` keyword for that method in the class body. You only need it in the header.


 Обычно классы называют в единственном числе, так как они предствляют собой сущность.
Контейнер для сообщений можно было бы назвать MessageContainer, ChatStorage, ну или как-то подобным образом.


@lpichler I would like ownership to be in the model, but privileges / sharing to remain outside the model. But that is subtile and for another day.

Will ask in tenancy meeting today about what to display when a user does not have access to the group name. which seems weird if they can see the vm but not the group


We could also test for __AVX__ and __AVX2__ if you like, which would let MSVC pick up the SSSE3 and SSE4.1 paths.  (There's no macro to test for SSSE3 or SSE4.1 there, but they do define __AVX__ and __AVX2__, which both imply support for SSSE3 and SSE4.1.)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15970](https://teamcity.mesosphere.io/viewLog.html?buildId=136242&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:53


No clue about the filter but it seems to me that building the URL by hand is not really optimal. Please note for instance that we're supposed to add a slug as well.


Please send an email to linux-media mailing list describing this particular use-case.
You may also want to add me and linux-snps-arc@lists.infradead.org to Cc when sending your question to mentioned mailing list.


estas usando tabs en este archivo, no hay un estandar oficial todavia pero siempre hemos usado spaces en el proyecto


mismo comentario de tabs vs spaces


Nice, thanks.


it is needed, could be a different number, but then again... What number? :)


Если прочитать несколько раз один и тот же файл, в истории появятся копии сообщений.


I don't see a delay at all in this loop. I would expect the loop to execute quite fast which could result in an excessive number of network calls.  Thoughts?


Don't forget, just #include <immintrin.h> and forget about it.


I directly commented these lines out, because I had to write `Py_TYPE(&Pcaptype)->ob_type = &PyType_Type` in Python 3. But `PyObject_HEAD_INIT` should initialize a `PyType_Object`.ob_type to &PyType_Type.
Note, the compiler may won't compile it on Windows. I don't have an Windows machine to test this.
For more information, see
https://docs.python.org/3/c-api/typeobj.html#c.PyObject.ob_type


tabs vs spaces


It looks like the errors you get come from the h264 codec, not from ffmpeg. try with a png or tiff output, there is no error:

ffmpeg -loop 1 -i testchart.tif -t 3 -vf "scale=in_range=full:in_color_matrix=bt709:out_range=full:out_color_matrix=bt709" out709-full%03d.tif
compare -verbose -metric MAE testchart.tif out709-full001.tif compare.tif
testchart.tif TIFF 1920x1080 1920x1080+0+0 8-bit TrueColor sRGB 359KB 0.000u 0:00.000
out709-full001.tif TIFF 1920x1080 1920x1080+0+0 8-bit TrueColor sRGB 3.453MB 0.000u 0:00.000
Image: testchart.tif
  Channel distortion: MAE
    red: 0 (0)
    green: 0 (0)
    blue: 0 (0)
    all: 0 (0)
testchart.tif=>compare.tif TIFF 1920x1080 1920x1080+0+0 8-bit sRGB 363KB 0.000u 0:00.000

--
Frédéric Devernay, Research Scientist, INRIA
frederic.devernay@inria.fr

> Le 12 févr. 2016 à 21:05, Troy James Sobotka <notifications@github.com> a écrit :
>
> Sorry for the delay... little busy here.
>
> I'd think that a basic input / output test should reveal whether or not things are going along properly. I outlined the series of commands I issued to the CLI version of FFMPEG for test chart usage here <https://trac.ffmpeg.org/ticket/3785>. Transfer curve will be more obvious in the 50%-75% display referred range if you are sampling values.
>
> I'll try to get 709 added into the configuration based on your test.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/MrKepzie/OpenColorIO-Configs/commit/13202214b4390fb696500287abea9a9e013d5526#commitcomment-16069800>.
>


What do you think of for the two write methods, replacing this and the `validateUser` call with instead so you're using the available method for validating the post and token already?
```php
if ( !$user->isLoggedIn() ) {
	throw new UnauthorizedException();
}
$this->checkWriteRequest();
```


Good job catching that `labels#<<` doesn't work right with dirty tracking! I assume that the `<<` method is still present on the collection, and that could lead to unexpected behavior. I wonder if there is a way to override collection methods in Representable. If there were, we could probably make `<<` work correctly.


I've been improving the documentation of `dfold` in the `newsnat` brach: https://github.com/clash-lang/clash-prelude/blob/newsnat/src/CLaSH/Sized/Vector.hs#L1634


Looks good to me


indentation


Each of these inner classes above has warnings regarding unused properties. Should the be cleaned up?


I don't understand the reason behind those lines. I have a problem with the debugger, I think the problem is the owning thread (?).. If I remove those lines everything works fine


@walterjunjun, these signs are incorrect.


Furthermore, you need to make your three variables in `AutoAim` static as well, you can't reference non-static fields from a static function. Either that, or just create new local variables for `AutoAim::GetTargetValue`. I would honestly recommend that.


This is a really good idea. Did you submit it as a PR to Virtus? It would be great if they incorporated it and we didn't have to monkeypatch this module any more.


This won't work, because you're overriding the `this._listen()` function in `Wu.Chrome` (which you are extending).

Solution: add `closeFullscreen` listener to `Wu.Chrome`(https://github.com/systemapic/systemapic.js/blob/master/js/src/chrome/chrome.js#L15) instead. NB: You must add a default function also in Wu.Chrome (here -> https://github.com/systemapic/systemapic.js/blob/master/js/src/chrome/chrome.js#L101)

Then you can simply add the function `_onCloseFullscreen` in this file. (Please use `_onCloseFullscreen`, not `_closeFullscreen`, similar to the other event functions.)


@pangeacake something something too lazy


aparte del comentario de @EfrainReyes , por mi +1


Ah ok, I wondered why the linter passed whereas I clearly remembered encountering such errors in the past (but it was with the linter we previously used). In my opinion that's not that a big deal not to have the requires in the alphabetical order (might help figuring duplicates out though?), unless it's easy to configure the linter to check this as well.


Hello,

The change has been published on the website.

ymh


thanks spudgy


qué pasa si mi mensaje tiene caracteres especiales?


@pcsram95 Thank you Omar, we will continue to review your progress.


laser_info gets a hitobj_list array (for fusion, I believe) which initializes at the size of MAX_OBJECTS.  Since every object carries laser_info, there's a squaring of MAX_OBJECTS bytes in memory.

This is the only issue remaining preventing a increase of MAX_OBJECTS, which was discovered when Drakona tried to change it to 32767 a while back (it's since been scaled down to 1000).  Drakona and I have talked about somehow resolving this in Retro, but have punted on dealing with it for now since the main focus is observer mode.


I'm curious as to why you copied this code in instead of using the gem. I might guess that it's because the gem is really old and seems unmaintained.


Ese Android XML!


@IgorZiegler Please see comment above. Need a little refactor.


misplaced {


Dong `2 space` `no tabs` ang convention nato. I think mao ni gamit sa tanan JS dev sa whole wide world nyahaha


Nice. Only a small comment here, could we pass the instance by reference instead? It's usually preferable as it guarantees you that the instance cannot by a ```nullptr```.


What's the use of ``gettext()`` then? The messages to be translated won't be explicitely available in the ``alertService``anyway and won't be extracted?!


done


remove this, add to `Wu.Chrome` instead (https://github.com/systemapic/systemapic.js/blob/master/js/src/chrome/chrome.js#L15)


Keep this, but rename to `_onCloseFullscreen`


LGTM


@nlalonde Cool thanks! I'll take note of the when adding multisite support to postgresql_fallback :+1:


remove `me`.


unused


I like this solution ! :)


**Code Quality - Critical**

The path to the file contains a redundant path string.
 - `./` refers to the current directiory
 - `../` refers to the parent directory
Having both interprets, literally - _the current directory to the parent directory_, as opposed to having _the parent directory_.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15971](https://teamcity.mesosphere.io/viewLog.html?buildId=136243&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:23


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15972](https://teamcity.mesosphere.io/viewLog.html?buildId=136244&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 226 Build time: 00:04:07


The name can be confusing as in the base class "data size" refers to the number of bytes per voxel of the image data (i.e., 4 for float or int images). I would try to make this similar to the ```GenericSparseMatrix``` and other image interfaces. Similar to ```NumberOfVoxels```, I would name this one ```NumberOfNonDefaultVoxels``` (for sparse matrices, it's usually ```NumberOfNonZeroVoxels```, but you have the ```DefaultValue``` setting).


ресурсы надо закрывать


Done.


they told us to use invokeLater for starting the window in the lecture, that's why I changed it
you can remove it again if it works better for you :smile:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15973](https://teamcity.mesosphere.io/viewLog.html?buildId=136245&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:51


Yes they will be extracted.


Yeah, I am looking at your `newsnat`branch: https://github.com/clash-lang/clash-prelude/blob/newsnat/src/CLaSH/Sized/Vector.hs#L1678

You seem to define `append'` in terms of `dfold` (and not `(++)`). Of course I might see an outdated version.


You can move L35-L37 to `Initialize`. Since `Execute` is run almost immediately after `IsFinished`, the amount of accuracy gained from refreshing again would be unnoticeable.
Currently, the loop is refresh->move->refresh->check->_refresh_->move->refresh...


Did you mean getInputFilesFromDirectory?


check style violation, @plagoa fix ASAP


Why did you comment this line? Seems reasonable to do this check as should be done by the assignment operator of any class actually.


:clap:


perhaps still offer 'everything' (which is 0)


TODO: export the bash scripts in the /home/instructor/bin directory to the PATH


K, the problem is if those lines are invoked the debugger does not break at breakpoints anymore so I removed the lines and evrything works fine. I did not investigated this any further.


Okay, I fixed the ones in `NativeBinariesTestPlugin`.

The rest are declaring tasks, and take the `ModelMap`s as inputs, so we can't use `@Each` in these cases, at least not yet. However, we might be able to fix them as well once we decide on how to declare tasks for any `ComponentSpec`. Maybe something like this:

```groovy
        @Tasks
        void createInstallTasks(TaskFactory<Task> taskFactory, @Each NativeBinarySpecInternal binary) {}
```

Another option would be to introduce `@Each` for inputs as well.


make it `Expected 0, 1 or 2 parameters for DECIMAL type constructor`


two unused imports


This will temporarily allocate another image, copy it, and then delete the temporary image. Instead, just call:
```
image.Initialize(_attr)
```


@tholman Why did you delete "Passweird"?


Should we validate that input parameters are files and no directories?


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=6)


Lo probé y funciona, adjunto una foto de ejemplo
![screen shot 2016-02-16 at 11 51 45 am](https://cloud.githubusercontent.com/assets/1693000/13081585/be8e4c7a-d4a3-11e5-8df3-9550f3e0b956.png)


better extracted in a getter `getCapabilitiesUrl()`. This way it can easily be overridden.


For inline docs on filters/actions, I don't think we should include the filter/hook name, only the description, when it was added and parameters.


Its still there... my diff was showing 2 files (one with .md, and one without)


It will completely freeze the browser and it's super hard to change it back when you have for example 2000 history items. Especially on Firefox..


release-5.x (lefticus) - i386-Windows-10-VisualStudio-14: OK (389 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Should we validate that inputFiles are files and not directories?
What if accidentally type a symlink or block device as parameters?


Gotcha, I wasn't sure if that would be helpful for parsing with documentation generators.  I might have misapplied the core spec.


Why not the snprintf method we used in the  cmdlft55xx ?


Ah, that was the file @krikmo changed. :smile:


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 262](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=786&buildTypeId=XbimEssentials_XbimEssentials) is now running


I would save the if condition check. In your Put method you already remove values that are equal the default value. Further, even if it contains some default values, these will be just few and not it's cheaper to just overwrite memory than checking the if condition every time.


Could but it is overkill as we don't have any variables.


release-5.x (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (397 of 397 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


work with im


Also, you can always use the ```voxel_cast```. It shouldn't slow down the execution as the compiler can optimize the templates code and when VoxelType and VoxelType2 are the same, the ```voxel_cast``` results in no additional binary code.


you probably don't need these ;-)


 - __information__: [src/chaiscript_stdlib.cpp:0](../blob/e024b99b36496e309ce70abff0f1473e959c5de8/src/chaiscript_stdlib.cpp#L0) Too many #ifdef configurations - cppcheck only checks 12 of 16 configurations. Use --force to check all configurations. (toomanyconfigs)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:679](../blob/e024b99b36496e309ce70abff0f1473e959c5de8/include/chaiscript/language/chaiscript_parser.hpp#L679) Expression is always false because 'else if' condition matches previous condition at line 677. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:683](../blob/e024b99b36496e309ce70abff0f1473e959c5de8/include/chaiscript/language/chaiscript_parser.hpp#L683) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/e024b99b36496e309ce70abff0f1473e959c5de8/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/e024b99b36496e309ce70abff0f1473e959c5de8/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 683. (multiCondition)
 - __information__: [src/chaiscript_stdlib.cpp:1](../blob/e024b99b36496e309ce70abff0f1473e959c5de8/src/chaiscript_stdlib.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __information__: [src/main.cpp:0](../blob/e024b99b36496e309ce70abff0f1473e959c5de8/src/main.cpp#L0) Too many #ifdef configurations - cppcheck only checks 12 of 17 configurations. Use --force to check all configurations. (toomanyconfigs)
 - __information__: [src/main.cpp:1](../blob/e024b99b36496e309ce70abff0f1473e959c5de8/src/main.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/e024b99b36496e309ce70abff0f1473e959c5de8/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/e024b99b36496e309ce70abff0f1473e959c5de8/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/e024b99b36496e309ce70abff0f1473e959c5de8/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/e024b99b36496e309ce70abff0f1473e959c5de8/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/e024b99b36496e309ce70abff0f1473e959c5de8/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


4 lagi ni dong? hahaha I setup imohang sublime-vim dong na if .feature mo set to 2 spaces. Or try install cucumber plugin para subtlime.


ah.. sorry, i wrote wrong example. this patch cannot handle mistake like this
```
sync.fiber(function() {
  asyncMethod1(sync.defer());
  // not yielded
  asyncMethod2(sync.defer());
  sync.await();
});
```
original code given reason of risk to developer.
this snippet looks like very common mistake, but make to very hard to find bugs in the my company.

so in my opinion, raise error after upgrade module;

1. original code was not matched defer/await pair like a snippet.
2. or sync module have bug;
  for example, i don't tested `sync.parallel` code, so i don't know that case.
  (if we need multiple parallel async action in the company, we just use `async.parallel`)

and basically, my question based just worry about published to new version :)


Actually now that I looked at the code again, I see that I did add automatic temporary resuming of AT commands for disconnect, detach, powerOn, powerOff in the modem library ;-)

That said, If this is for programmatic network_listen calls, what is the use case for network_cancel_connect(network); in the other two functions?  I'm guessing this was a Wi-Fi driven requirement?


@ViolaineCartONG there is extra whitespace in the line you added. Can you make sure all there are no spaces


changed to "reloadTable"


Similar to welcome message but this is for group. GroupChat Cell addition to MessageList i.e. giving group created access to group from MessageList View by showing group message cell in MessageView.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 262](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=786&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:02:37


FixGSHPweirdOutputOfAsterisksEtc (JasonGlazer) - x86_64-MacOS-10.9-clang: OK (2080 of 2080 tests passed, 3 test warnings)

 * 3 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This repository is public and states that we use Slack, Slack channels etc. All of those are not visible to the general audience.
Should we keep this information inside the public domain?


da hora!


guiado no lleva acento btw, si lo puedes corregir de un pronto pues jevi


Do you mean physical tracking or deanonymization here?
Can you provide an example perhaps?

Btw, do we also standardize out-of-band non-web use patterns? :)


LoadComponentRefactor (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


So basically I would replace all of these lines by just:
```
image = voxel_cast<VoxelType2>(_DefaultValue);
for (auto it = Begin(); it != End(); ++it) {
  image(it->first) = voxel_cast<VoxelType2>(it->second);
}
```
Much easier to read and maintain. Runtime performance should be better (not generally noticeably though).


@lptr, keep in mind these refactorings are happening in a branch.


I'm so happy they did this...


Thanks for catching that!


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27611/testReport/) for this commit**


см. комментарий по предыдущему коммиту - у нижележащего ol'a не обнулены margin и padding, поэтому он уезжает вправо


Here also, I don't think it's necessary/advisable to have two implementations with and without use of the ```voxel_cast```. It's similar to the use of the C++ ```static_cast``` keyword. You wouldn't write separate code for it as it doesn't add any overhead when it doesn't have to do anything.


ay kani di ay.. man nako ug 4 gyud ni... LOL


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27612/testReport/) for this commit**


Right you are.  Fixed.  Thanks.


shouldn't this be xaml?


zdxgf


4 man gali ni oh...


Good point. However, your test is for finite (non-nan) flux, so I'll say that. I don't think negative flux is rejected, though perhaps it ought to be.


That's fine, but would be even nicer when you use the ```Begin``` and ```End``` functions everywhere. Make ```Begin``` and ```End``` inline functions if they not are already (I think they are).


I think this test is wrong. The single quote `'` is not a special character in rust so this string `"'"` and this other `"\'"` are the same. Nevertheless, this other string: `"Xyz\\' OR \\'1\\'=\\1".to_string()` should bypass your protection.


@darrarski Why did you add @synchronized(self) here? it adds useless performance overhead, because UIKit is single threaded and you will never get a race condition here.


Should we just change
`SELECT MIN(id) as id,`
into
`SELECT row_number() over (order by move_id ASC)::int AS id,`
Then we will not have duplicate id anymore. And then viewing groupby shows us multiple lines for each quants in different prices. Should?


will this also grab deleted?


Pas d'accord avec ce commentaire


release-5.x (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (389 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27613/testReport/) for this commit**


Hahaha oo diay, my bad dong. Sa akoa pud naka 4 but it's supposed to be `2 space` ako na gi set akoang text editor nga basta `filetype => cucumber` then `2 space`


just drop lines 15-17 here


Cc @XanderDwyl


Итого:
 - с гитом разобрался, молодец.
 - код у тебя почти что чистый, проверь по лекции внимательно и поисправляй мелочи для задания 1.3
 - небольшие ошибки (дублирование сообщений в истории и незакрытые ресурсы) надо бы поправить, но даже в таком виде я бы сказала "отлично"
 - коммиты можно быть чуууть чуть слишком дробные, но это лучше чем гигантские :)

Задание 1.1 и 1.2 принято.


I have pushed a tweak to just use localtime() and gmtime() on Windows.  Please check whether it obviates the need for you cctz_libc modifications.  Thanks.


i think in the end we're going to keep this flag, so may be worth reverting this. sorry should've pinged you. this is the conversation: https://github.com/dimagi/commcare-hq/pull/10243#discussion_r52274257


isn't it possible to break the line here neatly avoid the line length violattion?


ako na e apil ug commit..


I mean physical tracking - identifying a physical person and following them through physical space.

(The example I think is obvious - provide an identifiable vibration pattern, and listen for it…)

We are not **standardising this concern**, we are noting that it should be considered as part of the inherent risk of this part of the Web. This is pretty much the same concern as geolocation raises (although that is far more powerful a tool for these purposes).


забыла `;`?


I think you forgot https://github.com/intellij-rust/intellij-rust/blob/master/src/main/resources/META-INF/plugin.xml#L30 ;)


точка, а не зпт


I know something better: the linelengthbear has a setting `ignore_length_regex`, just set that to `http://` and lines containing links will be ignored automatically :)


Compared with other nodes, its missing 'SOL_FLOW_NODE_OPTIONS_SUB_API_CHECK', but isn't a consensus that this is needed before we have 2 versions at least.


Not sure why I've added this. It should work without `@synchronized(self)` like you noticed. Perhaps I was experiencing some strange issues during development. You can try removing this.


@tfarago: just wanted to let you know about this. Moreover, Sai is able to run libuca successfully on Windows.


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=7)


@ST-DDT Will do. I can definitely see how serializability would be a big asset.


I think you don't actually need this template overload. The one with ```VoxelType2``` argument should suffice.


Isn't better to send a brake signal in the beginning?


If I activate -M the Tvh workaround is not needed anymore ?


Just discovered that `vox rm` doesn't work exactly because $VIRTUAL_ENV always exists :-(


лучше переэкспортировать картинку уже 75x74 и убрать bg-size. он нужен для более сложных случаев


on an import cleaning spree


this turned out to be rounding error!
```
ipdb> bestfit_t
0.079918085263355143
ipdb> pred_evoked.times[-1]
0.079918085263355101
```
FYI the culprit is on line 1171:
```
    time_idx = [np.where(evoked.times >= t)[0][0] for t in times]
```
where the comparison `>=` returns an empty array for which

```
*** IndexError: index 0 is out of bounds for axis 0 with size 0
```
I'll propose a test against any `times` being `> evoked.times[-1]` raising exception. I'll fix my example by `np.around`


I highly recommend not putting these in your repo, but on an image hosting site like imgur or even your personal site. Git repositories are meant for things that can be tracked/versioned/etc so that you can view changes over time. Images are static content and you aren't going to get much value out of 'committing' an updated image, since all git will do is see its a binary file and stop caring (or diff the actual binary data..which is still extremely unhelpful).


Did this import get here by accident? Shouldn't it be a generic, non-vendor processor?


Good catch, thanks!!!


Full stop at the end


Great detective work and nice catch!


Fixed


I think you meant "I'll try". Didn't you?


Updated to stop polling for ready pods. The progress timeout down the way is covering us. @smarterclayton this was the reason for the deployment getting blocked. It couldn't scale up because maxSurgePods=2 and both old pods were unready so we would poll here forever.


This allows us to continue using fetchWhere to get the next page of data after a refresh happens, so we aren't returning cached results after the first page.
If we have loaded 6 pages of data, for instance, and we want to refresh, we should fetch the first page again and clear the existing query cache so when the user clicks "load more," we don't return the cached pages 2-6 again.


contain


remove the ignore ranges completely please, this code is not checked yet and if it will be, we'll add the http ignore regex thing so they should be autoignored


ну так `content` то у тебя висит на теге p, а не на теге с классом `.icon`


Also need to update the project.json files in src\Rules\StarterWeb\**, src\Rules\EmptyWeb\**, and src\Rules\WebAPI\**


I pressed enter too quickly so all the changes are in this push.


Yes.


I pressed enter too quickly so all the changes are in the previous push.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27614/testReport/) for this commit**


This would be a bit less verbose as just `def get()` or something (since everything consuming it is then just `client.get()`), but up to you.

Alternatively:

```
from .client import get_docker_client
...
self.d = get_docker_client()
```

?


using global vars in a class context is bad practice


Yeah, my bad. Thanks for nailing that down Tobias!


TeamCity DnnPackager :: Continuos [Build 141](http://dazinator.ddns.net:81/viewLog.html?buildId=1590&buildTypeId=DnnPackager_Continuos&guest=1) is now running


Very petty/minor but using some constant name that would make sense for -1 could make it easier to read.


TeamCity DnnPackager :: Continuos [Build 2.0.2+1](http://dazinator.ddns.net:81/viewLog.html?buildId=1590&buildTypeId=DnnPackager_Continuos&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:14


<Help>


If we make this final, we need an `onInit()` empty method to override - we must allow subclasses to initialize themselves.


TO choose one of THESE variantS;
do THE following;
like THEY both are usual functionS


с помощью конструктора по умолчанию можно наплодить сообщений с одним и тем же id. может лучше его убрать?


release-5.x (lefticus) - Win64-Windows-10-VisualStudio-14: OK (389 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This verification looks like redundant.


What does it mean, "at least once"?


What about validating the second level (inner nested values) of the matrix?


2月16日：障碍物运动。


resolveD


Это не C++ конструктор копирования тут в целом не нужен :)
тем более что идея подсвечивает что он нигде не используется


I had added this one too, I'll remove the duplicate ok?


I found the reason. Trying to fix it


I compare function foo with property foo and function invoke.


Can you explain why this test had to be changed? It concerns me.


Looks great :D


There is two answers.


PEP8 please.


This file is empty now!


последовательности пробелов можно заменить на табуляцию ('\t')


PEP8 please


Hi Nichole, looks like you have made some very useful changes. Do you think you could upload an ipython notebook, at some point, that shows how to use this code? Or some sample scripts?

Also, have you fixed that problem where it takes ~1 second to analyze each well, as opposed to 1 second for like 400 wells?

Regardless, looks great, very excited to see what you changed and how the plate layout file works.


@danielnorberg thanks... my thinking was to just higher the number of `maxNumComponents` when allocate the `CompositeByteBuf`.


`server_function` is not yet available...


@dtarb I don't think we need this py file?


With https://github.com/clash-lang/clash-prelude/commit/1967fa87d4648b59848c95e5ed04a2212e0d0ccd I think the documentation of `dfold` should now be correct.


@nbigaouette would you mind taking care of it whenever you have time? that'd be definitely smoother than me putting the head into it


You write that “podcasting is harder than it sounds.” :laughing: Hear, hear. Nice pun. :smirk:


Если вызвать equals не с объектом класса Message (например, с Integer) то он упадет с ClassCastException
Посмотри какие equals генерирует IDEA или просто добавь  instanceof проверку.


Please write something like "we don't stop on first property, but instead do " and what you do.


`topomap.py` should probably use `_time_mask`, which is more tolerant of these things


lgtm. :shipit:


Fixed.


Fixed


Если сделать проверку msg.equals(null) то тут упадет NullPointerException


FixGSHPweirdOutputOfAsterisksEtc (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2118 of 2118 tests passed, 6 test warnings)

 * 6 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


wrote get_station_locations to find the lat long of usgs station locations. made fixes in test_lin_reg.py


Etapas pra consertar tudo
* Trocar as ocorrências de p por P, nas classes de vulnerabilidade
* As classes de vulnerabilidade NÃO são subclasses de PlayerAliveState, são classes base UTILIZADAS por PlayerAliveState, logo: trocar class_extends por class_new
* Remover os requires das classes de vulnerabilidade e adicionar requires para elas na PlayerAliveState
* Adicionar às classes de vulnerabilidade o parâmetro aliveState para a função de instanciação (.new), e passar o passar o PlayerAliveState (ele próprio) ao instanciar objetos dessas classes.
* Em tookHit em AliveState temos:
`if self.curr_state == self.vulnerability.vulnerable then`
AliveState NÃO possui campo curr_state. Lembre-se que ele tem 2 tipos de estados (vulnerabilidade e comportamento), tendo respectivamente self.vulnerability.curr_state e self.behavior.curr_state. O que nós queremos usar aqui é o primeiro. Além do mais lembre-se que o correto a fazer na hora de verificar a precedência da classe é usar a função is_a passando como parâmetro a classe a ser verificada, o que resultaria nessa linha de código:
`if self.behavior.curr_state:is_a(PlayerVulnerableState) then`.
Todavia, não podemos esquecer que essa função está dentro de AliveState, utilizando do operador IF para verificar o estado e executar o que for apropriado, quando, na verdade, um dos intuitos de criarmos as classes de vulnerabilidade é possibilitar inserir essas funções DENTRO das mesmas. Ou seja, carregar o tookHit para vulnerable e invulnerable, e delegar para elas a partir da AliveState de acordo com o curr_state de vulnerabilidade.
* Em PlayerInvulnerableState temos:
```
function PlayerInvulnerableState.update(dt)
  self.timer = self.timer - dt
  if self.timer < 0 then
  PlayerAliveState:setVulnerability(vulnerable)
  end
end
```
**vulnerable** é um campo que NÃO existe E adicionalmente, **PlayerAliveState** é uma CLASSE, e não o objeto de estado que o player possue. O correto é, *tendo passado o aliveState como parâmetro*:
`self.aliveState:setVulnerability(self.aliveState.vulnerability.vulnerable)`
* Ainda no invulnerableState, no new o timer da instância é setado para 2. Mas não se esqueça que o estado de invulnerabilidade vai ser acessado várias vezes. Ou seja, é necessário setar o timer para 2 NÃO na instanciação, mas sim na função de START, caso contrário quando ele entrar em invulnerabilidade pela segunda vez o timer já vai estar menor do que zero e ele vai instantaneamente voltar para vulnerableState.
* Para terminar, basta implementar as funções :update(dt), :tookHit() e :start() dentro das classes de vulnerabilidade, e chamar elas a partir do aliveState quando necessário for


*directory


release-5.x (lefticus) - i386-Windows-10-VisualStudio-12: OK (388 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


general:
  build_dir: api


@nbigaouette if contextually you could also fix the double slash issue that'd be great


taking a look now...


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=8)


Кстати, `film = ` в блоке лишнее.
И, напоминаю, передачу опций в CSV.read можно чуть компактнее записать.


@tkx Please address the feedback.
Please add a requirements file.

Bonus:
- Is the code `Python3` compatible? if not, what changes are required to make it `Python3` compatible?
- What is the time and memory complexity of this code?
- In the `validate` function, is there a way to improve efficiency by rearranging the order of the calls to the so called 'private' validation functions (`validate_rows`, `validate_cols`, 'validate_inner').
Please explain your answer.

Thank you for submitting a solution quickly.


When we resolve property `foo` for some call `foo()` we don't stop on first property, but instead we collect all variables with name `foo` and for each of them try to find some invoke function.


Is this debug message left in here in purpose?


println usage


Ill nreak dat bitch 😍
On Feb 16, 2016 3:07 AM, "martin coulon" <notifications@github.com> wrote:

> purty plz
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Tesla-M-Devices/device_lge_hammerhead/commit/281ba9863de6668b3ed65208048605a85e67972b#commitcomment-16111352>
> .
>


That is the same comment I made to Scot when he added the code for handling of the deployment state. I can add a "sleep()" for a sec before we go through the next iteration of the loop.


Break 😂😂😂 fail
On Feb 16, 2016 11:21 AM, "Anthony Pyrtle" <xxpyrtlexx93@gmail.com> wrote:

> Ill nreak dat bitch 😍
> On Feb 16, 2016 3:07 AM, "martin coulon" <notifications@github.com> wrote:
>
>> purty plz
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/Tesla-M-Devices/device_lge_hammerhead/commit/281ba9863de6668b3ed65208048605a85e67972b#commitcomment-16111352>
>> .
>>
>


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15974](https://teamcity.mesosphere.io/viewLog.html?buildId=136248&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:05:08


LoadComponentRefactor (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


We expected you to work on an html file, usually "index.html".  I don't see how you can see the results of your efforts unless this is in an html file.  Eventually, the css should move out of that file to "styles.css".


Hey Sanne!

Already done in the PR! See: https://github.com/gsmet/hibernate-search/commit/23afe3d1d28bba6656684cecf40140298c971a32


Sounds good!

- At each step the game will inform the user, what and why, they are doing this.
- At the completion of each step the user is rewarded by a designated point system.
- If the user get's stuck or makes a wrong choice, Nurse Narwhal will come in to help assist the doctor.
- As the user completes cases and helps patients, he get more exotic animals.
- To help keep the game intriguing, after X amount of cases in the Veterinarian Clinic, Dr. Dog will travel to new places to help animals and meet other Doctors and Nurses along with way.

This was the user is constantly learning about new animals and new locations in the world.


Do you support CUDA 2.x? In that case this is either 2048 or 4096, depending on architecture:

http://blog.cuvilib.com/2014/11/12/cuda-differences-bw-architectures-and-compute-capability/

You should use [cudaDeviceProp.maxTexture3D](https://www.cs.cmu.edu/afs/cs/academic/class/15668-s11/www/cuda-doc/html/structcudaDeviceProp.html)


FixGSHPweirdOutputOfAsterisksEtc (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


release-5.x (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-AddressSanitizer: OK (3047 of 3047 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Done as part of addressing #74


checkout:
  post:
    - git submodule sync
    - git submodule update --init


Yeah, that'll do.


checkout:
  post:
    - cp ./ci-server/config.yml ./app-server/config.yml


`local.properties` should never be committed in an android project, it should be listed in the `.gitignore` file.


Смотри, у тебя тут явно в десятке методов повторяется `first(numbers).map(&:name)`.
Я бы это из методов поприбирал (кроме longest, который по постановке задачи таков), зато сделал отдельный независимый метод `print_films`, и в проверочном коде писал бы скажем так:
```ruby
print_films list.select_genre('Comedy')
```
а внутри print_films уже печатал бы фильмы красиво (причём хорошо бы скажем аккуратной строчкой название, жанр, страна, длительность — чтобы можно было посмотреть, правда ли мы только комедии напечатали)


и тут хорошо бы ответственность за вывод результата из класса убрать, чтобы внешний код это делал


Unfortunately:

```
$ nix-build -A glibc
...
Hunk #12 succeeded at 1386 (offset 73 lines).
2 out of 12 hunks FAILED -- saving rejects to file resolv/res_send.c.rej
builder for ‘/nix/store/zpnplnzyjchcrsllz1nfkmqnjzsyj1v7-glibc-2.21.drv’ failed with exit code 1
error: build of ‘/nix/store/zpnplnzyjchcrsllz1nfkmqnjzsyj1v7-glibc-2.21.drv’ failed
```


Yep, will remove


@dtarb I think in this validation routine, we have to first check if the input is a file that exists if not then we check if the input is a directory that exists for validating a grid.


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=9)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27615/testReport/) for this commit**


Refrain from using iojs versions as an example


And another thing: in the text you sometimes write "we" and sometimes (or maybe just this once) "I". I think it should be one way or another.


Instead of using an else, you could have used a return statement inside the `if` and stop execution there.


Point directly to usage


value.val may have the signal inverted here, right?


nit: you already have `listener` bound as a local so could be:
```clj
(when listener <etc>)
```


все инпуты все равно имеют id. поэтому обращайся лучше по нему, `nth-child` здесь менее удобен


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15975](https://teamcity.mesosphere.io/viewLog.html?buildId=136250&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:01


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15977](https://teamcity.mesosphere.io/viewLog.html?buildId=136252&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:58


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15976](https://teamcity.mesosphere.io/viewLog.html?buildId=136251&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:02


release-5.x (lefticus) - Win64-Windows-10-VisualStudio-12: OK (388 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


Yes, it's equivalent. Note that it's set to safe value by default.


вот тут message может оказаться null, а дальше где-нибудь вывалится NullPointerException


There is a typo in the commit msg -> 'DUTY_CYCLE_PERENT'


In the [CMake file](https://github.com/thp/psmoveapi/blob/master/examples/CMakeLists.txt#L82-L96), Win & OS X are using `find_package` but Linux is using [pkg_search_module](http://stackoverflow.com/questions/25959972/what-is-the-difference-between-find-package-and-pkg-search-module). The former uses FindSDL2.cmake (if found) or SDL2Config.cmake and the latter uses the output of pkg-config.

We have a FindSDL2.cmake in the psmoveapi/cmake folder and this is made available to `find_package` because [we add it to](https://github.com/thp/psmoveapi/blob/66edf8a647cce4a21b98a43b4180039760c8800a/cmake/common.cmake#L140) `CMAKE_MODULE_PATH` in `psmoveapi/cmake/common.cmake`

@thp , can you give us the result of `pkg-config --cflags sdl2` on your ubuntu system?

Using homebrew's SDL2 and pkg-config on OS X I get the following,

```
$ pkg-config --cflags sdl2
-D_THREAD_SAFE -I/usr/local/include/SDL2
$ ls /usr/local/include/SDL2/SDL.h
/usr/local/include/SDL2/SDL.h
```

In other words, in the homebrew version of SDL2, pkg-config wants us to `#include "SDL.h"`. I'm surprised that this is the default behaviour in OS X/homebrew but not the default behaviour in Linux.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27616/testReport/) for this commit**


here rather than using "u_blank", you can use this

if(ft5x06->in_suspend) {
// your resume ()
}

that way you can remove unnecessary u_blank variable

you might want to use this driver https://github.com/armani-dev/kernel_test/commit/bc7b49c46e62e76044f88941b95f8b847f9865b0

works just fine, plus keeps stuff inline with CAF and Focaltech
all i did there is added firmware detection and vkeys support


I'm not sure if this change makes sense to me. Will we never store css files in this directory?


testing!


Consertando erros dos commits:
https://github.com/LexLoki/RPG-Codinome-Brocolis/commit/ef22e3312e7b5508d52c952fdcfa0ab6dbe8a8a6
https://github.com/LexLoki/RPG-Codinome-Brocolis/commit/6ee2cb52956c831bd635aea4e5b7c66544b26485


There are multiple reasons why we want a try/catch here. For instance the communication can drop (no network) so we can't make a call into Azure.

Only the first one captures the best the reason for the failure; Plus, the deployment error message gets returned back to the deck which can barely handles displaying one error message.


Plus it's a test directory..?


LGTM


Tried that, nothing seems to work. However, I tried visiting dhmc.us:8081 and that seems inaccessible, so I'm guessing that's the actual issue.

Sent from my Windows Phone
________________________________
From: games647<mailto:notifications@github.com>
Sent: 2/16/2016 6:41
To: MLG-Fortress/ExtraHardMode<mailto:ExtraHardMode@noreply.github.com>
Cc: RoboMWM<mailto:robomwm@outlook.com>
Subject: Re: [ExtraHardMode] pom: force updates (072ef17)

You could try to run it with -U

---
Reply to this email directly or view it on GitHub:
https://github.com/MLG-Fortress/ExtraHardMode/commit/072ef175b6dacf4cdfa3fb787f6b022730c899b0#commitcomment-16119439


So in order to identify the person, one needs to deanonymize him/her, right?
Vibration in this case might just point at the person.

I'm just unsure whether to really use "tracking".

2016-02-16 17:04 GMT+01:00 chaals <notifications@github.com>:

> I mean physical tracking - identifying a physical person and following
> them through physical space.
>
> (The example I think is obvious - provide an identifiable vibration
> pattern, and listen for it…)
>
> We are not *standardising this concern*, we are noting that it should be
> considered as part of the inherent risk of this part of the Web. This is
> pretty much the same concern as geolocation raises (although that is far
> more powerful a tool for these purposes).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/anssiko/vibration/commit/48489c54e0b7ed80900e0906fa79803c8fa77069#commitcomment-16121911>
> .
>


GPIO config is indeed still in the machine part, still I don't think that having 650+ lines duplicated, which are not HW specific, is a good idea.


thanks for adding these tests. I think the 1-5 list here is something that will get stale over time and think you should leave that info for the tests' docstrings.


JsonResponse in throttle is giving error because of this change.

> ErrorException in ThrottleRequests.php line 94:
Argument 1 passed to Illuminate\Routing\Middleware\ThrottleRequests::addHeaders() must be an instance of Illuminate\Http\Response, instance of Illuminate\Http\JsonResponse given


ah, great thanks!
I was looking at it one commit at a time.


The inner classes map to the JSON structure that is returned and it's needed when we call ObjectMapper.readValue().


unused


Tried visiting dhmc.us:8081, seems inaccessible @Di3mex

Cc @games647


## Task 1

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program includes `main()` function and "ifmain" statement (1 pt)
- [ ] Program includes additional function(s) to compute "palindrome-ness" (2 pt)
- [ ] Program correctly determines whether **any** phrase or word is a palindrome (6 pt)

## Task 2

- [ ] Program is fixed - it is still recursive and works correctly with no errors (5 pt)


I not completely convinced HDFSReader.run is correct. As I see it you check each file, read the first 4096 bytes (1 page), and write that entire chunk into an IBuffer, correct?

What happens if the file is longer than 1 page?

Also, I'm pretty sure IBuffer.pushData is actually supposed to take the bytes for a single ITuple, not just a generic bunch of bytes. You could figure out how to parse this yourself and just pass the appropriate chunks into pushData, but it might be easier to figure out how to use a ReadableByteChannel and use readFrom. (If the code properly reads multiple records per file as is you can ignore this comment. I'm not entirely convinced I'm right about the pushData function)


Oops, I should have taken that out. I was experimenting with higher spring
constants along with a nicer way of doing fit_rigid: calculating the spring
forces on the atoms in their procrustes rotated state, but not storing that
state. This lets you keep the procrustes entirely in the NEB part, keeping
the optimizer more generic. I need a bigger test suite, but it seems to
improve on LBFGS. I also increased the memory of LBFGS from 5 steps to 20 -
it seems to help, as aria says it should.

James
On Feb 16, 2016 10:30 AM, "Henry Herbol" <notifications@github.com> wrote:

> Why is there now a factor of 10 here?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jminuse/clancelot/commit/886ee02fd54627b6b3122324d6331e3ca0e96b15#commitcomment-16120885>
> .
>


потенциальный NullPointerException


Oh man. Such bad typos. :disappointed:


nit: most people will understand what setUpClass does in general. You should describe what specifically this particular setUpClass does (e.g., compile sass, etc)


I assume these are for Mt. Moon? If so, THANK YOU!


@mkristian from my understanding the `precise` distribution that was being used has a crappy version of JDK8 in its apt repositories and bumping to `trusty` gets access to a more recent JDK8 release


This was reverted by ashwinr64


почему getTime меняет значение даты?


@travijuu That's because you're using an old laravel version. This fix commit is not in a tagged release yet.


I think you meant
`s_dim = ((args.output_dim) * (args.output_dim+1))/2)`
instead of
`s_dim = ((args.output_dim) + (args.output_dim+1))/2)`


Well, that was `final` before this my change. See the `master` state.
But I see that there is a minor redundatnd `getRemoteDirectoryExpression()` to revert, too.


@davidlt , do you understand what we are missing in 76X IBs for slc7?
```
@@@@ Running edmWriteConfigs for MuonGeometrySanityCheck
/bin/sh: /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc7_amd64_gcc493/cms/cmssw/CMSSW_7_6_X_2016-02-16-1100/bin/slc7_amd64_gcc493/edmWriteConfigs: /build/cmsbuild/jenkins-workarea/workspace/build-any-ib/w/slc7_amd64_gcc493/external/glibc/2.17-78.el7_2.12-1.166.el6_7.3/lib64/ld.so: bad ELF interpreter: No such file or directory
gmake: *** [lib/slc7_amd64_gcc493/MuonGeometrySanityCheck.edmplugin] Error 1
```


Does the order of operations in this test accurately represent how they will work in real-life? I guess what I mean is, you should probably override environment settings before processing *any* assets, since that's how it would work in the actual code execution.


Ok just pushed an update.


nit:better to use addCleanup in the setup method.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15978](https://teamcity.mesosphere.io/viewLog.html?buildId=136253&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 226 Build time: 00:08:41


shouldn't this be
```
COMMAND ${CMAKE_COMMAND} -E copy ${DLL} ${DEST_DIR}
```

?
Otherwise it does not work if the CMake bin directory was not added to the system PATH


region variable is not used


Sorry.  I was experimenting with ways to avoid the constraint that the no data value has to be 0, but could not get it to work.  Please delete this.


Credit to @jpsim for the initial PR a while back: https://github.com/fastlane/fastlane_core/pull/35


why do it this way? You don't get the nice per-line output in the logging anymore :(


Oh got it, it's the message that is wrong then, can you update it? "**Should show exactly 20 events**" would make more sense.


Maybe it's a good idea.


funky whitespace/indenting here?


笔记


This class doesn't appear to be used


@benhutton Brilliant idea!


The only difference between the `if` and the `else` seems to be the inclusion of a single `key: value` pair in the second case. So maybe using a default object and just add that k-v pair in a single if would be better.

For example this long code:
```js
if (element.y < 1000) {
    newObject = {
        type: "line",
        name: sensorHash[element.type].title,
        showInLegend: true,
        dataPoints: window[sensorHash[element.type].arrayName]
    };
} else {
    newObject = {
        type: "line",
        name: sensorHash[element.type].title,
        showInLegend: true,
        axisYType: "secondary",
        dataPoints: window[sensorHash[element.type].arrayName]
    };
}
```
can be re-written as
```js
newObject = {
    type: "line",
    name: sensorHash[element.type].title,
    showInLegend: true,
    dataPoints: window[sensorHash[element.type].arrayName]
};

if (element.y >= 1000) {
    newObject.axisYType: "secondary";
}
```
which I take you'd agree is slightly simpler :grinning:


ressources: typo?


To be able to spot ops that use non-initialized memory easier.  I don't want to use NaN or Inf since that can cause other problems.

Also I use the same value in all the AllocEmpty ops so that DebugMode won't complain that some optimization is invalid when one is replaced by the other.


I don't understand the point of setting this as a separate method & giving it the decorator. Could you explain?


first commit


Зачем тебе это тут?:)


release-5.x (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: OK (389 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


interview feelings :P


This is whether or not there's a github repo, right?


That's exactly how `hh_client` works, but `hh_server` (as far as I know) only re-checks files that have changed, or whose direct dependencies have changed.


Since the previous conditional if true `return`s there's absolutely no reason for this `else` here.


I might have forgotten to make changes on CMSSW side. It is missing: https://github.com/cms-sw/cmssw/commit/df8b39d94ab39c5ed83e47a22be2e1d03ae76262


Это более-менее работает, если REWRITABLE_FLAG == true.
Если нам захочется сделать, чтобы новая страница добавлялась, имеем "хвост", который бесконечно добавляется в конец.


Same comment as before. I don't understand why you would patch after processing xmodule assets.


cc @vcunat @romildo , it looks like they updated source code without bumping a version. *sigh*


missing closing } bracket


I'm getting an error from this. I think the `esc_html` should be outside the `sprintf`.


RL rant: Encoders are devices that can be very very vey tiny with freaking 6 ridiculous small terminal that need soldering + 2 terminal that connect to almost no existent terminals in the motor itself making soldering even more challenging specially if you buy micro-motors from pololu.


We shouldn't alter the aws defaults


See the commit comments.
The `mGetWithoutRecursion()`  has been changed to the LS, not LsNames, because just with names there is no hooks to check that the remote path isn't a directory like it is right now:
```
if (lsEntry.isDirectory()) {
    continue;
}
```
I faced the issue with `lsNames` when I used `null` for the MGET.
So, it returns all entries including directories, but our `get()` downstream treats dir as an error, when we really just ignore such kind for the MGET.


I thought Netflix wanted us to leave this as "default"


ah right, can you please do it. Thanks


TeamCity Civic Assembly :: Build all [Build 54](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1173&buildTypeId=CivicAssembly_BuildAll&guest=1) is now running


Why are we adding a TODO? Sorry if I missed this. I'd rather address tech debt here, if possible, rather than introducing it.


This commit will cause unexpected behavior. Take a closer look at the functions being called and the variables being checked.


Поясню, почему НЕ работает `evt.target.id`.
В частности, таргетом может являться label. У него id не указан.
Соответственно, имеем никакой фильтрование.
Как вариант, могу предложить `reviewsFilter.elements["reviews"].value`
У меня заработало.


This PR looks like it have VMImages as well as the bug fix in it. Next time can we try and keep PRs to a single story or at least closely related stories?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15979](https://teamcity.mesosphere.io/viewLog.html?buildId=136254&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:00


TeamCity Civic Assembly :: Build all [Build 55](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1174&buildTypeId=CivicAssembly_BuildAll&guest=1) is now running


Got it thanks


thanks for the fix.
I was seeing `no-popups: * true` rule being not imposed. instead static filter rule was being logged in version < v1.6.1


@GrahamCampbell I updated Laravel to 5.2.16 from 5.2.14.


Отступа не хватает, у класса точка не нужна в данном случае.


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1536 of 1536 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Right, I was planning to add that, and then promptly forgot again. Thanks for the reminder.


This is dependant on ES6. Will update to be friendly to Node <= 0.12


I believe it would be better to use the block function of the `Dir.chdir` (http://ruby-doc.org/core-2.0.0/Dir.html#method-c-chdir), otherwise you could run into strange problems of code paths behaving differently depending on whether this method was called or not.


@mccalluc what is the value of `tokens` here? I don't see it defined.


POST /repos/:owner/:repo/statuses/:sha


The following doc(s) have been deployed to the [workflowau](http://workflowau-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/going-live](http://workflowau-static-docs.pantheon.io/docs/articles/going-live)
- [docs/articles/sites/code/using-the-pantheon-workflow](http://workflowau-static-docs.pantheon.io/docs/articles/sites/code/using-the-pantheon-workflow)
- [source/docs/assets/images/desk_images/376212.png](https://github.com/pantheon-systems/documentation/commit/d085e264c126bb4d287b5f084e1f201b3dd30284/source/docs/assets/images/desk_images/376212.png)
- [source/docs/assets/images/desk_images/376217.png](https://github.com/pantheon-systems/documentation/commit/d085e264c126bb4d287b5f084e1f201b3dd30284/source/docs/assets/images/desk_images/376217.png)


sizeof(int) * sz - это размер типа Int в байтах на данной платформе, умноженный на число sz, т.е. сколько памяти (в байтах_ нужно выделить для хранения sz целых чисел.

sizeof(array) - это размер в байтах объекта, который скрывается под именем array. Какой тип имеет array в данном месте? Это int*. Так что sizeof(array) == sizeof(int*) =, т.е. размер типа int* (указатель на int) в байтах на данной платформе. Обычно, размер указателя (или ссылки) всегда такой же, как и у числа int, например 4 байта, т.к. значением указателя является число (адрес). Т.е. указатель - это просто целочисленная переменная.

Понятно, почему не работает?


Il y a deux typos :

> à celle qu'il optient en dechiffrant la signature > à celle qu'il obtient en déchiffrant la signature


картинку надо спозиционировать так, чтобы она центровалась, и она не должна вылезать за пределы контейнера.
Аналогичные свойства потом надо для Js карты применить.
У Figure будет позишн релэйтив и оверфлоу хидден


I happen to like the latter and implemented that.  Thanks for the suggestion.


What is your reason for never allowing editing? I'm just curious.


Assume this should be 'Admitted' as per line 86?


Commited at 2ce1882
I was not sure where to apply the proxy. I finally decided to leave it outside the getter.


With this line active the validation fails for an ESRI grid that is a folder.  In commenting this out I was recognizing that the C++ function that is called will give an error if it is unable to open the input as a grid so validation here is a bit redundant.  You are welcome to add an additional check for a folder inside where it fails this file check. For the ArcGIS interface it seems to me better to check that it is valid in the interface validation code (that is part of the toolbox) because that helps the user.  When this code is executed it is too late as the computation is already started.


see here in action: ![SVG Logo](https://rawgithub.com/mro/Shaarli/feature/logo-svg/doc/images/doc-logo.svg)
(Safari renders bogus :-( )


what is escape-by-default for ?


This TODO appears to have already been done.


ack


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/tests/collecting/CollectorsTest.py`, line 159.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/collecting/CollectorsTest.py
+++ b/coalib/tests/collecting/CollectorsTest.py
@@ -157,6 +157,7 @@

     def test_collect_registered_bears_dirs(self):
         old_iter = pkg_resources.iter_entry_points
+
         def my_iter(name):
             assert name == "hello"
             class EntryPoint1:
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/tests/collecting/CollectorsTest.py`, lines 161 to 162.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/collecting/CollectorsTest.py
+++ b/coalib/tests/collecting/CollectorsTest.py
@@ -159,7 +159,9 @@
         old_iter = pkg_resources.iter_entry_points
         def my_iter(name):
             assert name == "hello"
+
             class EntryPoint1:
+
                 def load(self):
                     class PseudoPlugin:
                         __file__ = "/path1/file1"
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/tests/collecting/CollectorsTest.py`, lines 166 to 167.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/collecting/CollectorsTest.py
+++ b/coalib/tests/collecting/CollectorsTest.py
@@ -164,7 +164,9 @@
                     class PseudoPlugin:
                         __file__ = "/path1/file1"
                     return PseudoPlugin()
+
             class EntryPoint2:
+
                 def load(self):
                     class PseudoPlugin:
                         __file__ = "/path2/file2"
```


How about using this regex

[(Source)](http://someweblog.com/url-regular-expression-javascript-link-shortener/) [(Regex-Test)](http://regexr.com/355hb)

```
\(?(?:(http|https|ftp):\/\/)?(?:((?:[^\W\s]|\.|-|[:]{1})+)@{1})?((?:www.)?(?:[^\W\s]|\.|-)+[\.][^\W\s]{2,4}|localhost(?=\/)|\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})(?::(\d*))?([\/]?[^\s\?]*[\/]{1})*(?:\/?([^\s\n\?\[\]\{\}\#]*(?:(?=\.)){1}|[^\s\n\?\[\]\{\}\.\#]*)?([\.]{1}[^\s\?\#]*)?)?(?:\?{1}([^\s\n\#\[\]]*))?([\#][^\s\n]*)?\)?
```
this would fix **travis-ci**

and

https://github.com/pajlada/pajbot/blob/master/tests/tests.py#L55
```python
# TODO: The protocol of a URL is entirely thrown away, this behaviour should probably be changed.
self.assertEqual(find_unique_urls(regex, 'https://pajlada.se/ https://pajlada.se'), {'http://pajlada.se/', 'http://pajlada.se'})
```
it will check **https** when the link is **https**

you just need to delete **ftp** from the regex because you can't click ftp links in twitch chat.

```
\(?(?:(http|https):\/\/)?(?:((?:[^\W\s]|\.|-|[:]{1})+)@{1})?((?:www.)?(?:[^\W\s]|\.|-)+[\.][^\W\s]{2,4}|localhost(?=\/)|\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})(?::(\d*))?([\/]?[^\s\?]*[\/]{1})*(?:\/?([^\s\n\?\[\]\{\}\#]*(?:(?=\.)){1}|[^\s\n\?\[\]\{\}\.\#]*)?([\.]{1}[^\s\?\#]*)?)?(?:\?{1}([^\s\n\#\[\]]*))?([\#][^\s\n]*)?\)?
```


Hm, we don't actually depend on `ap` for `tests/test_own_ptr`. However, there may be other future tests that will depend on it, so we have no choice for now :-(

We could think about that in the future.


Cherry-picked.


Awesome! Many thanks! :heart:


Здесь поля объекта Node  выводятся отдельно через запятую с пробелом.

А нужно выводить сам объект, т.е. чтобы работало так:

std::cout << *it << " ";


This seems copy-pasted


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27617/testReport/) for this commit**


why `if(true)`?


Всё о чём мы говорили на консультации:
- фон в баннере поправить
- картинки в медиа блоках сделать резиновыми
- тексту внутри блоков причин и фич добавить отступы, чтобы было максимально возможно похоже на макет, и на мелких разрешениях не обрезалось
- в форме инпутам задать фиксированную ширину, чтобы избежать неизвестного бага
- спозиционировать карту, чтобы она вырывалась из контейнера вправо


I take your point about the translations. The reason for the Choices here was that there is a constrained set of values for this field which have to match the names in the popolo person model so changing these is going to involve changing the database schema anyway.

I'll see what I can do with the translations though.


TeamCity Civic Assembly :: Build all [Build 55](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1174&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **UNKNOWN**
Summary: Canceled (Tests failed: 18 (1 new), passed: 4) Build time: 00:06:02
### Failed tests
```
Blog categories tests: Should delete blog category new blog category 1455641056074: <no details avaliable>

Blog categories tests: Should not create new blog category if cancelled: <no details avaliable>

Blog categories tests: Should add new blog category: <no details avaliable>

Blog categories tests: Should not change blog category: <no details avaliable>

Blog categories tests: Should change blog category: <no details avaliable>

Blog categories tests: Should not delete blog category if cancel pressed: <no details avaliable>

Blogs tests: Should not create new blog if Cancel button pressed: <no details avaliable>

Blogs tests: Should add new blog: <no details avaliable>

Blogs tests: Should not change blog if Cancel button clicked: <no details avaliable>

Blogs tests: Should change blog: <no details avaliable>

Blogs tests: Should not delete blog if Cancel button was pressed: <no details avaliable>

##### there are 8 more failed tests, see build details
```


Why are there are 3 copies of types.go (types.go, v1/types.go and v1beta3/types.go)?   I'm assuming this this has something to do with api stability, similar to how kube uses 'unversioned', but I'm not sure of the specifics.  Pointers to relevant documentation welcome.


Ugh. Thanks. Will get it fixed shortly.


TeamCity Civic Assembly :: Build all [Build 54](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1173&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **FAILURE**
Summary: Tests failed: 166 (1 new), passed: 6, ignored: 4 Build time: 00:07:56
### Failed tests
```
Blog categories tests: Should delete blog category new blog category 1455640995348: <no details avaliable>

Blog categories tests: Should not create new blog category if cancelled: <no details avaliable>

Blog categories tests: Should add new blog category: <no details avaliable>

Blog categories tests: Should not change blog category: <no details avaliable>

Blog categories tests: Should change blog category: <no details avaliable>

Blog categories tests: Should not delete blog category if cancel pressed: <no details avaliable>

Blogs tests: Should not create new blog if Cancel button pressed: <no details avaliable>

Blogs tests: Should add new blog: <no details avaliable>

Blogs tests: Should not change blog if Cancel button clicked: <no details avaliable>

Blogs tests: Should change blog: <no details avaliable>

Blogs tests: Should not delete blog if Cancel button was pressed: <no details avaliable>

##### there are 156 more failed tests, see build details
```


Ok


This is powerful


辛苦 CD 菊苣~
有几个小问题需要修改一下~

种子页面一开始这里的空白较大，在滚动页面之后空白突然消失：
![s x 2xsow6vedc 072 a2o](https://cloud.githubusercontent.com/assets/1846356/13083395/c89f196c-d50f-11e5-94e6-d2eb0f37bc02.png)

新开的种子页面后退无法使用，加上退回首页的功能吧~
![h6h5mkz _ klzdr2 1c](https://cloud.githubusercontent.com/assets/1846356/13083413/e00abaca-d50f-11e5-9efe-af22b1fc8eca.png)


Should we call appropriate logging level in logger.log() statements ?


release-5.x (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-NoThreads: OK (393 of 396 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.24%25-yellow.svg)


5420-OSCM-Docs (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2080 of 2080 tests passed, 3 test warnings)

 * 3 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The following doc(s) have been deployed to the [workflowau](http://workflowau-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/sites/code/using-the-pantheon-workflow](http://workflowau-static-docs.pantheon.io/docs/articles/sites/code/using-the-pantheon-workflow)
- [source/docs/assets/images/desk_images/376212.png](https://github.com/pantheon-systems/documentation/commit/d085e264c126bb4d287b5f084e1f201b3dd30284/source/docs/assets/images/desk_images/376212.png)
- [source/docs/assets/images/desk_images/376217.png](https://github.com/pantheon-systems/documentation/commit/d085e264c126bb4d287b5f084e1f201b3dd30284/source/docs/assets/images/desk_images/376217.png)


formatting nitpick, as discussed


![image](https://cloud.githubusercontent.com/assets/10177669/13083431/88951d60-d507-11e5-8c8d-133feb182352.png)

mới chỉ cộng sản phẩm và giá tiền khi add to cart, chưa thanh toán, xem chi tiết giỏ hàng

tiến độ hoàn thành: 30%


另外种子页面标题栏能固定一个最小高度吗，不然加载完成后高度会突变（


I noticed this last Thursday and was going to do a whole other PR for it.

With my cluster rework in https://github.com/projectatomic/commissaire/pull/22, the host record no longer stores a cluster name.  So this is still technically wrong.  Instead you have to search for the host's address in the `hostset` list at `/commissaire/clusters/CLUSTER_NAME`.

I still plan to follow up on that, unless you disagree with the design.


here we should put a Write-Warning instead of Write-Host, for a better user experience. Same for the next two changes.


Hey. This filter and some other didn't work for me. I managed to track the error to this commit. you assign an negative value to an uint8_t variable i. The inside of the loop never executed.
Thanks for building this library
- Jens


what do you mean? the - does a weighted diff


:+1:

On Tue, Feb 16, 2016 at 5:03 PM, Oduah Tobi <notifications@github.com>
wrote:

> [image: :+1:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/andela/getmyshop/commit/002a88393efb50a0b9d9877808e039c8187d40df#commitcomment-16121873>
> .
>

--
*Best Regards,*

*Yusuf Daniju /** Andela.com
<http://andela.com/?utm_source=andela&utm_medium=email&utm_campaign=signature> *
*Software Developer / **+234.807.266.7248 <+234.807.266.7248>** / @Andela
<http://bit.ly/andelatwitter>*

*"The startup that's harder to get into than Harvard" - *CNN
<http://snip.ly/HfId>
See what The Wall Street Journal <http://snip.ly/u9AI> has to say.


Where is the busybox image coming from? Has it been imported to the image store already?


Debounce is the better choice in this case.  I was testing the two, and must have committed throttle version on the initial commit.  I since then changed it back to debounce.


space between if and expression needs to be added


canola is good, but what about olive oil instead?


页面 `/torrent/56b3d26c50ad6a683360db93` 在拉到极端小之后，图片消失再拉大之后图片没有重新出现（


space between method call and script needs to be added.


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `bears/tests/go/GoReturnsBearTest.py`, line 32.*

The issue can be fixed by applying the following patch:

```diff
--- a/bears/tests/go/GoReturnsBearTest.py
+++ b/bears/tests/go/GoReturnsBearTest.py
@@ -29,7 +29,6 @@
 """.split('\n')

-
 GoReturnsBearTest = verify_local_bear(
     GoReturnsBear,
     (good_file1,good_file2,),
```


maybe we should restrict it to modules starting with coala or somethinhg? Not sure...


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `bears/tests/go/GoReturnsBearTest.py`, line 35.*

The issue can be fixed by applying the following patch:

```diff
--- a/bears/tests/go/GoReturnsBearTest.py
+++ b/bears/tests/go/GoReturnsBearTest.py
@@ -32,5 +32,5 @@

 GoReturnsBearTest = verify_local_bear(
     GoReturnsBear,
-    (good_file1,good_file2,),
+    (good_file1, good_file2,),
     (bad_file1, bad_file2,))
```


**Line contains following spacing inconsistencies:
- No newline at EOF.**
*SpaceConsistencyBear, severity 1, section `python`.* *Related to file `bears/tests/go/GoReturnsBearTest.py`, line 36.*

The issue can be fixed by applying the following patch:

```diff
--- a/bears/tests/go/GoReturnsBearTest.py
+++ b/bears/tests/go/GoReturnsBearTest.py
@@ -33,4 +33,4 @@
 GoReturnsBearTest = verify_local_bear(
     GoReturnsBear,
     (good_file1,good_file2,),
-    (bad_file1, bad_file2,))+    (bad_file1, bad_file2,))
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `bears/tests/go/GoReturnsBearTest.py`, lines 35 to 36.*

The issue can be fixed by applying the following patch:

```diff
--- a/bears/tests/go/GoReturnsBearTest.py
+++ b/bears/tests/go/GoReturnsBearTest.py
@@ -32,5 +32,5 @@

 GoReturnsBearTest = verify_local_bear(
     GoReturnsBear,
-    (good_file1,good_file2,),
-    (bad_file1, bad_file2,))+    (good_file1, good_file2,),
+    (bad_file1, bad_file2,))
```


hi! first off: thanks for this. secondly-- i thought of this semantically as not a 2nd level heading. if you have the time, could you explain this to me?