I think the calling code can directly handle a None return value, but please confirm that it does the right thing.

In general, if tenants or segments can't be returned from the Tenant service, we might consider just failing the entire operation.


FixCrashWithZoneAndSystemERV (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1556 of 1556 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.68%25-green.svg)


Fixing this for hardware wallets and BIP44 recovered wallets is probably best done by taking the matter pubkey one level higher than the account level. Unfortunately that's not currently stored in the wallet. Can't remember if that requires a password but I think it does. We should get and save it at wallet creation time, when creating the main account and will need a one-off prompt for password for existing wallets.


Code that calls this expects an iterable. None is not one of those, so the calling code will crash.


This unnecessary input tag selector has been removed in the commit
https://github.com/AppFolioOnboarding/Li_Image_Share/commit/dbff15a2758d339f7d6f404be55732b456b0fbbc


Actually, the calling code eventually expects the returned value here to be an iterable. None is not, so it will crash.


![](http://i.imgur.com/RBOeCuF.png)
xanex

plz fix this isnt drug name simulator 2016


it's already defined in line 35.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16743](https://teamcity.mesosphere.io/viewLog.html?buildId=141653&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:05:13


I think there is something I don't get here. How can you set up a session with user and password before you had signed up?


:star: :star:


Reporting path privacy errors in `resolve` exposed privacy errors in tests unrelated to privacy that were not previously reported because of other errors before the privacy pass.


Nevermind, I see now that `Session` doesn't try to authenticate until you call `Session.authenticate`.


Good catch! That just hit me as well -- I'll push my current WIP, which already has said test case and an improved condition.


maybe make a static CritetiaBuilder in service


:fire:


cc @vancluever ^^ that's a context test that fails w/ a cycle when the CBD transformer ends up in the mix :+1:


:tada:


LGTM


nice catch, thanks! :+1: - fixed on 74b677514360eecf34a9c01f1ca3c62ef67d1e33


我修改了你的


> Anyone can re-open the issue.

That's not true though. You can't reopen someone else's issue unless you are an owner or collaborator.


Thanks for helping out here. I never really got into the depths of value classes.


Non-UFCS method privacy errors in this test are no longer reported because of the other errors before the privacy pass. These errors are still checked in at least two other tests.


Mango


Thanks for the information @ljharb

I made a few local changes ( and learned that `regeneratorRuntime` is a required global variable !!! )

I'm now able to run the following code as a hook service locally without any issue. Huzzah!

```js
import sleep from 'then-sleep';
export default async function (hook) {
  await sleep(500);
  hook.res.end('Hello!');
}
```


mongo


Thank you for the tutorial, Anders. Fixed in 9e60287. :-)


This or next commit can be a cause of regression: https://github.com/minetest/minetest/issues/3767


I just found that, too ;-)


look for input type text


FixDatasetFiles (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1005 of 1005 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-29.0%25-green.svg)


What tests I could figure out have been added, feel free to suggest more. I've also added the benchmarking for both BM4 and Vinet.


Actually, I used those error messages to distinguish `op`-related code and `util` codes.
  1. "Cannot create an Operation with a NodeDef larger than 2GB." in `ops.py` and `constant_op.py`
  2. "Cannot create a tensor proto whose content is larger than 2GB." in `framework/tensor_util.py`.
The error message #1 is the one used before, and #2 is made by me.

But, I think your idea sounds good to me. I'll update again, @keveman .


This program needs to run under python 2.7 and using the package numpy and matplotlib. It initially includes ten memories for number 0-9 graph in 16*8 and it's not necessary to include all memories to run the program. Since I am using a personal computer, also for this program easier to read, I tried my best to use some matrix calculation-like code which will cause problems in the high-dimensional case.
I test this program by choosing memory 1/4/8 and under the parameter set in the program, the accuracy is 100%.


possibly a bug. We want to replace punctuation and numbers only on title but not category and id.


FixDatasetFiles (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Ok


Reporting path privacy errors in `resolve` exposed privacy errors in tests unrelated to privacy that were not previously reported because of other errors before the privacy pass.


通常class不同，變數名稱ㄧ樣是沒關係的。因為呼叫時會寫instance.method。


Got it. Thanks!


`SIGNUP`???

`_do_authenticate` also log the AUTH, I guess with one place is enough.


https://github.com/russross/blackfriday/blob/master/markdown.go#L294

See Line 294 -> 329


這樣不算多。每個commit的內容有掌握到的話就不會弄混。


I do agree that it is a very dangerous operation to be performing on any system. That was part of the reason for being so specific about only performing the operation on the 'current' folder of a candidate. I can write up an issue and/or pr later for a system specific resolution if that is the direction that you would like to go in. Sound good?


Needs null checks?


Related to #55


該分類的不是留言，是commit。


There's no point in putting `== true` on the end of a boolean; that's like putting `+ 0` or `* 1`  after an integer.


debug


init


Please do not submit the temporary file.


Note that you get the value out of the `savedInstanceState` twice.


Thanks I'll update that now  :smile:


You think "Cannot create an Operation with a NodeDef larger than 2GB." is proper error message is still valid in `tensor_util.py` in this case, right?


gonna need to quote these, e.g. `'Series 1': 2`


@eht16 do you know why this one doesn't need the two sets of double quotes, but the ones above it does? Maybe GLib doesn't use it as a C string but instead as some macro stringification thing? Either way, it works, just curious.


Rather than testing `mIsCheater` in both the `if` and the `else if`, you might consider factoring that test out by wrapping the whole thing in `if (mIsCheater) { ... }`. If you did that, what's left inside it would look a lot like what's in the `onClick` method, providing an opportunity for refactoring. In fact, the whole process of setting `mIsCheater`, setting the result, and displaying an appropriate answer text is essentially the same in both places and could be factored out.


오... YML 이네요. 설정 파일을 YML로 관리하는 이유가 어떤 것인지 궁금하네요. Spring Boot 권고 사항인가요?


This is too strict: we want to be able to extend generic Objective-C classes, but we can't utter the type parameter names anywhere within the extension. Otherwise, we have a fairly serious regression from introducing this functionality.


Also a regression. Is there a problem with allowing this?


Can't in this document @krystophv because it's actually published w/GitBook at [http://developer.tidepool.io/docs/GitHub/index.html](http://developer.tidepool.io/docs/GitHub/index.html) from a static site, which does not understand the GitHub short codes (GitBook does not go through Jekyll either). But hmm, I could add the short codes to the doc for reference I suppose.


The "index" argument is wrong: you should use the same index that the Clang generic type parameter has.


Not a good idea. That name is already taken on Bower. Also, I've already published it as openhpi-video-player.


@nyeholt will get round to the tests tonight :)


Thanks for catching this!  In the future, can you please do pull requests to the dev branch instead of master?  I've pushed this to dev so I am closing this request :)


my apology. I committed only the file I changed but git complained about my
version be outdated, although I could not see it complaining when I was
checking the status.
Anyway after it complained, it merged. I didn't force it or I'm not aware
of having done such a thing.

Sorry again.

C.

On 22 February 2016 at 19:26, Carlos J. Rosales <notifications@github.com>
wrote:

> Do not mind to fix it, I'll do it later.
>
> *my mistake to put the report along with the code, apologies*
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CentroEPiaggio/pacman-DR54/commit/988542469fb344833738fc774c67606a95fd08a2#commitcomment-16249514>
> .
>

--
Claudio

Curiously enough, the only thing that went through the mind of the bowl of
petunias as it fell was "Oh no, not again".
Many people have speculated that if we knew exactly why the bowl of
petunias had thought that we would know a lot more about the nature of the
Universe than we do now.
D. Adams - Hitchhiker's guide to the galaxy


You don't need to check for an explicit bound, do you? Just dig out the underlying type regardless of whether it was spelled in the source code or not.


write_index_array_data_to_buffer() in BufferUtils.cpp does the expansion.
You can get the indices vector size by calling get_index_count() from BufferUtils.cpp too.


Can we make one, single scripted effect called `emf_cb_expelled_holy_order_trigger` and make that about a thousand times easier to read?


Over my dead body.


I feel that I still have a lot to learn to make an informed decision, and I really would like to avoid cleverly shooting ourselves in the feet. I would opt for approach 3 to avoid complexity from tedious work, but maybe try to help the user REALLY look at the first error.

An other approach might be to try to also lex the file backwards from the end, to maybe more accurately determine the start/end of the error, and helping with recovery, but that also sounds tedious, as I guess a whole new lexer would need to be written, looking at what to expect BEFORE some construct.

As stated, I think approach 3 is _good enough_, but better with some guidance to the user.


Fair enough. The sanctity of overwhelming piles of redundancy, I can understand that, because I mod CK2.


The `mIsCheater` field is no longer playing a useful role, now that you've introduced `mCheatBank`.


@keveman . Since `tensor_util.py` is used in many places, I think we had better replace the existing one"Cannot create an Operation with a NodeDef larger than 2GB." into a new one "Cannot create a tensor proto whose content is larger than 2GB.". It's more general message.

With that message, I will change the existing two statements (including test cases) as you said. Thanks.


alas, this didn't type check at some point.. unfortunately I didn't write down why, and with the minimization from the original problem, it's true it;s not clear what the value of this test is


( it gets more redundant once we try to apply this to the other de jure claim CBs )


Don't use `int` if `boolean` is more appropriate. Don't hard-code the length of an array when you can set it to automatically match the appropriate length.


releated to https://github.com/teerapap/grunt-protractor-runner/pull/62


related to https://github.com/teerapap/grunt-protractor-runner/pull/62


Why not use importObjCGenericParams here? The type parameter names in the category *could* be different, for example.


goes back


FixDatasetFiles (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2151 of 2151 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


s/arguments/parameters


Is it necessary to alter the other de jure claim CBs also? I don't remember that part.


Not that it matters, but the `rust!` macro is intended to be used line by line (in which case, it will handle the indentation. So you could generate the table as a value and then iterate out and invoke `rust!` for each row.


- [ ] Darn, I'll investigate and codify as a test


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16747](https://teamcity.mesosphere.io/viewLog.html?buildId=141678&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:09:09


Thank you, but I cannot take credit for that animation.


This entry is generating error in the compilation, please comment or adjust.


This entry is generating error in the compilation, please comment or adjust


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16746](https://teamcity.mesosphere.io/viewLog.html?buildId=141670&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:09:53


You should be able to define VisitObjCTypeParam(const VisitObjCTypeParamDecl *) and put this logic in there; it only chains up to VisitTypedefType when VisitObjCTypeParam doesn't exist.


Do we really want the archetype here rather than the interface type?


@eeeschwartz This looks really cool! What do you think about opening the accordion before you do the animated scrolling? It just feels a little jarring when the form opens right after I scroll down to it.

Anyways, just a thought.

Thanks!


I think this should be `-u _printf_float -u _scanf_float`, since the option name implies it affects both..


awesome!


So this is a bug in Joda < 2.8.1[1] on Java 8u60 (haven't confirmed if it's on versions greater than u60 yet)[2]. The tests are testing for the format that clj-time will output on Java < 1.8.0_60.

We're using clj-time 0.10.0 right now which pulls in Joda 2.7. clj-time 0.11.0 is the latest release and it pulls in 2.8.2.

So... _assuming this is an issue on JVMs above u60_ it's currently affecting PE 2015.2+ and when we upgrade our version of clj-time and pull in a different version of Joda this timestamp will change again. And, considering that this works on most Devs' laptops and in travis, it means we aren't testing with the JVM versions we ship with in [travis](https://travis-ci.org/puppetlabs/puppet-server/jobs/111096189#L154) or [jenkins](https://github.com/puppetlabs/puppetlabs-modules/blob/production/site/profile/manifests/jenkins/usage/java.pp)....

My guess here is that if it's not a big deal to bump a dependency[3] we would want to bump the dependency on clj-time to 0.11.0, update the formatter to keep the current behavior in PE, and then update the test to actually test for that format (since it's currently testing for the format that clj-time produces on Java < 1.8.0_60, which isn't what we ship).

/cc @cprice404 @KevinCorcoran

PS Another fun fact: Joda Time is deprecated for Java 8 and above, I didn't find anything about clj-time's stance on that (I assume that there'll be long tail of support that we don't need to worry about that now).

[1] I don't know if there's a lower bounds on the version in Joda, see https://github.com/JodaOrg/joda-time/pull/291 https://github.com/JodaOrg/joda-time/issues/288 and the [release notes](http://www.joda.org/joda-time/upgradeto281.html)
[2] u60 was released on Aug. 18th of 2015, we ship u65 in [PE 2015.2.x](https://github.com/puppetlabs/enterprise-dist/blob/2015.2.x/packages.json#L141) and u71 in [PE 2016.1.0](https://github.com/puppetlabs/enterprise-dist/blob/2016.1.x/packages.json#L156)
[3] is clj-time a dependency that other projects share?


The "mapTypeOutOfContext" wouldn't be needed if we were using interface types, FWIW.


I think it's better to use vkCmdBlitImage :
https://www.khronos.org/registry/vulkan/specs/1.0/man/html/vkCmdBlitImage.html

DX12 doesn't have a blit operation so I had to use a passthrough shader.
The blit operation can rescale texture when copying them ; since the window surface can be bigger than internal surface (for instance when a game is internally rendered at 1280x720 and displayed on a 1080p display) this is quite useful.


Looks extrange a method that returns a deferred throws exceptions. I checked and logout uses inlineCallbacks decorator, I think if you use that any exception thrown will become a failure in the deferred.


FixDatasetFiles (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@parkera I see. BTW, I got the impression that presets used by the build Swift CI bots are eventually using the Debug version of Foundation. I don't know if this intended or not. I can totally see why you 'd like to use the debug version during development. But why would Swift CI bots checking Swift PRs need to use the debug version?


개인적인 취향이긴 한데요. 예외 이름이 좀 더 명확하면 좋겠네요. 왜냐하면 예외 발생시 예외 이름이 명확하면 메시지를 볼 필요가 없기 때문입니다.
'해당 디렉토리를 찾을 수 없습니다'를 예외 클래스로 만들어 throw 하는 것은 어떨까요?
이미 Java에서는 Checked Exception으로 DirectoryNotFoundException 을 제공 하고 있거든요.
코드 상으로는 Unchecked Exception을 사용해야 하니 위에 건 못 쓰겠지만요. ^^


It looks correct, but is this related to ObjC generics?


Thanks @bluk! That's very helpful information, and the links are much appreciated. :+1:


It's intended to stand for the fully defined version of S.


Don't add dependency on jetbrains annotation


As noted earlier, this is a big regression. We should be marking the type parameters as unavailable within the extension.


Very cool. A bunch of comments above, but this is looking great!


FixDatasetFiles (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2113 of 2113 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Mind using FastMath?


I would put a comment with a XXX saying that this is missing to be implemented. I think usually in python if you see a method with pass as only content it means that this needs to be implemented by a child class.


Same thing: Fast Math?


I just tried to address the reviewer's suggestion:

"The description of the games (and the neural network) is quite incomplete with respect to optimization variables and the used optimization technique (i.e. the applied evolutionary algorithms)."

Thus, I have described the variables being optimized and also the operators and parameters considered in the EA applied in Genebot.


개인적인 취향을 하나 더 붙히자면
public void create(String path, String body) {
        throw new DocFileServiceException("작업 중!!");
    }
위의 코드에서라면 저라면 이미 Java에 존재하는 UnsupportedOperationException 을 사용하는 편입니다.
그러면 좀 더 의도가 잘 드러나지 않을까요?


It looks good. +1


Hello, I noticed that the updated apple certificate thumbprint has invisible characters at the beginning which causes it to not be found when the PassGenerator.GetSpecifiedCertificateFromCertStore(...) executes.


What does it mean to have markers that support CORS? I thought you can instantiate a `L.Marker()` straight out of Javascript, which doesn't have anything to do with the cross origin stuff.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16748](https://teamcity.mesosphere.io/viewLog.html?buildId=141684&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:10:00


@misha1 I want be support english but my english skill is so poor :(


Is this really a good idea? Like that people will have to verify both the signature and then the checksum! With the ISO signed, verifying the signature will be enough... ;)


I think you actually want to put it back to the way it was so that for categories or tags you can pass in an empty value to remove any category applied to a post.


배열때문이예요. yaml문법에서는 배열을 지원하거든요. https://en.wikipedia.org/wiki/YAML#Lists
properties에서는 배열이 불가능해서 도입했었습니다만, 스프링에서는 별도 컨버터가 필요하네요.
가독성이 좋아서(부모키값을 생략가능) 계속 사용하고 있습니다.

스프링에서는 properties나 yml둘다 상관없다가 지금의 가이드상태입니다.


I force un-pushed the travis changes (they're now sitting on branch "travis")


@justinstoller would you mind copy/pasting those (excellent) comments into the Jira ticket?  Would like to preserve the conversation there rather than on the PR.


:tada: Great job Team Godot! :beers:


len(msgBlock.Header.MerkleRoot) should just be chainhash.HashSize, as len calls are expensive.


You shouldn't need to check the sizes of these. The merkle root is a chainhash.Hash and is therefore safely assumed to be 32 bytes long. As long as the header deserialized correctly, you should be OK.


I see... It's not just `containerId`? In that case, can you add a comment or extract this to a function?


utACK, need someone to try it out on testnet or mainnet to see if it solves the "wrong number of voters" issue.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16749](https://teamcity.mesosphere.io/viewLog.html?buildId=141679&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:07:03


@rsanchez-wsu For some reason Jenkins build fails for this commit. I've checked this with 'ant clean test' many times in my computer which doesn't outputs fail build. I don't know if I'm doing something wrong or if it is Jenkins.


Excellent!


> 예외 이름이 좀 더 명확하면 좋겠네요.

넵! 이 부분은 미처 챙기지 못한 부분입니다. 예외명을 좀 더 명확하게 수정하는게 좋을 것 같네요.

> 저라면 이미 Java에 존재하는 UnsupportedOperationException 을 사용하는 편입니다.

자바에 UnsupportedOperationException를 지원하는지 몰랐네요. 이부분도 함께 수정하겠습니다.


Okay let's change~


Says "not valid" here, tho: https://docs.npmjs.com/files/package.json#license


- [ ] 違和感を感じた。ブランクプロジェクトが元々そういった設定になっている、という説明にしてほしい。

---

c39644501580c605ed612bf72dea0b73b9facd21 で対応しました。
by btsatoutkzy

---

リンク先がterasoluna-gfw-web-multi-blankを向いているが、チュートリアルのブランクPJはterasoluna-gfw-web-blank
将来変わるかもしれないので、リンクは不要。 by @ikeyat

---

57c91416db3a394f725aee4c1f3c0567ba4e1335 で対応しました。
by btsatoutkzy

---

差分としては出ていませんが、リンクを削除しました。
by btsatoutkzy


FixDatasetFiles (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1562 of 1563 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.71%25-green.svg)


- [ ] あと「Spring Securityの設定を、セッションを使用しない設定に変更しているため、「RESPONSE」の「HEADERS」に"Set-Cookie: JSESSIONID=xxxx"がないという点にも着目してほしい。」のいう一文も削除しておいた方が、ドキュメントとしての整合性が保たれる気がします。

---

削除しました。 by btsatoutkzy


I don't get it. Why would you define this to be an error?


Looks awesome! 😃


It's using 'this' and arebbeing called outside of TablePanel.  Without bind, this returns null.


Unfortunately, AndroidStudio is normally built with JDK6 and stuff, so this breaks a clean OSX with AndroidStudio installed and no Java updates.


Make it private


Think about removing this, it looks unused here


Hello, I noticed that the PassGenerator.ValidateCertificates() method fails when it tries to create the nameParts dictionary if the passCert.SubjectName.Name contains an organization name with a comma. e.g. O="Acme, Inc.". It throws off the split on the comma.


good point regarding label's default value.  after that change, it's much readable.


Reporting path privacy errors in `resolve` exposed privacy errors in tests unrelated to privacy that were not previously reported because of other errors before the privacy pass.


Non-UFCS method privacy errors in this test are no longer reported because of the other errors before the privacy pass. These errors are still checked in at least two other tests.


I think it's better to drop this comment. The url_bucket is literally the string that was taken out of the URL, no more, no less. BTW, it can contain the explicit tenant when it is different from the explicit tenant with which the client is authenticating. But that's not a problem for TempUrl, I think.


@btshimizukza コメント

- [ ] この２行（CSRF対策及びセッションの利用に関する説明）も不要なのでは？

---

削除しました。 by btsatoutkzy


FixDatasetFiles (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1005 of 1005 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-29.0%25-green.svg)


FixDatasetFiles (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Because the test for being null already exists and is called `isnull`. Use that.


Suggest naming these variables self.os_domain_name, self.os_password, ...  for consistency.


@DivyaVavili this change itself looks good.

but should we also be returning error at the following (which is in the same function above this)
```
    // Create OVS db driver
    sw.ovsdbDriver, err = NewOvsdbDriver(bridgeName, "secure")
    if err != nil {
        log.Fatalf("Error creating ovsdb driver. Err: %v", err)
    }
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16751](https://teamcity.mesosphere.io/viewLog.html?buildId=141707&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:06:48


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16750](https://teamcity.mesosphere.io/viewLog.html?buildId=141703&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:06:55


Weird, I fixed it. I pulled the commit in my old computer and it showed me error - 'Cannot refer to the non-final local variable gui defined in an enclosing scope.' I don't what it was but in my other computer there were no error even without the word 'final' and ant kept giving be successful build!


FixDatasetFiles (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (2119 of 2119 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Wait, this can't be right. The bucket_name and bucket_tenant are always set together, so if you can't use one, you can't use another. What this tells us, the whole function must be called after postauth_init() with no changes, so some such solution.


wow, nice example @DWiechert  :)
if you don't mind, can you add example how to do unit test and integration test for usercontroller?
thank you


It's quite similar to the fall damage in TTT, so if you're high enough it will kill you instantaneously, but mostly close-to death damage. Feel free to try it.


same question as @xiaods

and is the issue present in 3.4.8 ? if not can you update ?

Thanks


Closes #23


This is actually capturing the exist status of the "sudo" process.


All these big ideas result in change and one must keep learning. I am interested in learning more about data analysis. So I must

- [ ] Spend time each day on these courses

- [ ]


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16752](https://teamcity.mesosphere.io/viewLog.html?buildId=141708&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:03:53


Nice, how did you come to choose only the last 3rd of threads?


Honestly, that's fine.  The sudo process will die if the daemon dies.  I think I only used this to make sure the daemon was running.


- Fixed the firefox issue.
- Tooltip is updated to match what's in GWT.
- Enum is not implemented, yet.. as described in the ticket.  Still debating whether it's needed at all.
- As for the strange behavior, not sure what to do about that.
    The input field is designed to not update state unless 'Enter' is pressed or field falls 'out of focus'.  This is an added feature so that we're not trying to perform a filter operation which can be time consuming.
    TablePanel is designed to only render visible rows.  So, after scrolling down, it has to re-render the new rows.  When it re-renders, the old state is re-populated into the input field.
If you can think of a solution, I am all ears.


Gugh. I didn't mean to push this :-(


Oh wait, it's not capturing the exit status, that's `$?`.  I assumed you meant the PID of the `sudo` process.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16753](https://teamcity.mesosphere.io/viewLog.html?buildId=141709&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:07:50


@blickly Will these 7 changes be reapplied? The commit message is incomplete.


Big ideas = learning opportunities


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16754](https://teamcity.mesosphere.io/viewLog.html?buildId=141710&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:08:20


its a fixture test (i.e. the code is never run, only compiled), it doesn't really matter


Looks good to me!


Suggest making the sleep time a variable and using the variable in the exception message and next line.


Also: change href to data-target for smsLink


Yes. Thank you.


RIght. When forking like that, there is no exit status, because the process
should be running indefinitely.

What you need to do in this case is write a pidfile and see if it responds
to signals after a short delay.

https://github.com/chef-cookbooks/etcd/blob/80ce85d413915a186af0fa71f9c648a3fc18c881/templates/default/sysvinit/etcd.erb#L140

All this is moot if we use the stock upstart config from the packages =)

-s

On Mon, Feb 22, 2016 at 8:50 PM, Todd Lunter <notifications@github.com>
wrote:

> Oh wait, it's not capturing the exit status, that's $?. I assumed you
> meant the PID of the sudo process.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/swipely/docker-api/commit/b43f9835ba6ea418d75babb3de5c3220f94e3b99#commitcomment-16257316>
> .
>


@cesar-tonnoir you merged conflicts :'(


Remove extra "this"


I think the module-related one is the one that broke things. We can probably roll the other 6 forward tomorrow.


@DCalliet  Well done sir.  Thank you for doing this.  I won't get a hernia from this.


Hello Andrew.

With your new noiseremovalmultichannel.pas + noiseremoval2.pas -->

uos_noiseremoval works like charms for mp3, ogg, wav, flac.
Out of the box, smooth, mono or multi-channels.

Even combined with lot of other effects.

Congratulation.

Sorry to borrow you with that but...
How may I use your code?
I see that each unit is part of PascalAudioSuite package.
For your NoiseRemoval effect, some PascalAudioSuite units are needed.
How may I integrate it, if you agree, in uos?
In a /pas/ directory or may I rename-merge some units?
Or something else?

Thanks.

Fre;D


As you start working with other programmers, you'll find complying with little conventions like capitalization can make the collaboration go more smoothly. The Java convention is that all names except classes, interfaces, and constants start with lowercase letters.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16756](https://teamcity.mesosphere.io/viewLog.html?buildId=141715&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:03


Same comment as above on the sleep time.


阿飞


thanks


Nice! Keep rockin' Godot devs :)


@vvb: If it errors out in the case mentioned, the process itself exits as it's considered fatal error.


You shouldn't hardcode in that there are five questions. You should use features like arrays and loops to deal with however many there may be.


@SubJunk there are always a few bumps in the road :). This underlap thing isn't that significant imo, I just mentioned it 'cause I happened to notice. Bump js/css needs a little work, btw, since it isn't properly insulated from the host page and once in a while we get slightly bizarre artifacts due to the outer css bleeding through on other websites.

PS new _jumpy-0.3.9_ update for the plugins tab: [jumpy-info](http://skeptical.github.io/jumpy/jumpy-info), [jumpy-inst](http://skeptical.github.io/jumpy/jumpy-inst).


SZVAV-Fan-Control (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Don't worry, it is encouraging to us mortals to see the mighty be sloppy sometimes ;)


That depends on the the parameter of the member function `detect_sharp_feature`. The functionality that detects the borders should be merged into it `detect_sharp_feature`, maybe with an additional Boolean parameter. Or we should document that `detect_borders()` must not be called if `detect_sharp_features` is used.
CC: @janetournois


It'd be good to remove this line now that we're sure this works, to reduce output when migrating, but keep the "No GSS code found" warning output.


Product is always same for all lot of move , Josse can u check this again. So i think its right ..


Again, I tried to follow established naming conventions in state/ and other packages - compare with AllMachines(), AllInstances(), etc. There are exceptions to that convention - sure, but to me "Interface()" and "Interfaces()" just look too similar to be worth the odd few seconds each time anyone looks at the invocation "x.Interfaces()" and have to peek in closer to spot the "s" suffix.


The modes are XOR, so I'd append this using an `else if` or turn the whole thing into a `switch` block.


>only modules set the privacy boundaries, everything else is transparent

I can't find the definitive source right now, but I think this is the intended privacy model and not just bugs.


Fixed in bcdcf4ff2d4c05a8679521389bfaaa1604168366


It's not magic, it's the namespace name configured before.
If you use "AddDefault" method, the namespace name is "default"


I thought of that, but found no use for aborting early so far. Can add when needed though, as it's trivial.


I'll fix that


Here is some data displaying this commits effect:

Build#61: https://gyazo.com/5e503723d11117727d05e9eb5abc0a7a

Build#62(This commit): https://gyazo.com/f836084528c7ba6ce23213d93c639203


nice work!


It's looking good! Please don't forget to test `mapParser` with a bad mapping function which throws exceptions!


You need to `require` highlight mode mode at the top.


Yeah, in fact, this change reversed the original logic in this line, causing #1739.


yes you are right good catch.....I was about to test it this evening. You saved me some time.

btw oneshot42 works like a charm!


Alright, I think functions should get their own privacy boundry, but I'll change it to match how it is now.


ansible-role-slurm has until now been independent of other roles.

Shall we change this? Like:
 - Add another conditional inside the template(s) in the ansible-role-pam
 - Remove the pam changes in this slurm role
 - Point to the ansible-role-pam as a dependency in meta/


We need to add a test in LocationRepositoryTest. Also I'm not sure if we're going with throwing the NoResultExceptions or catching them and returning null. We appear to be doing both in the code base. Can you investigate and make the change if necessary?


Fixes #1

Test example used:
```
[1, 2, NaN, NaN, 4, 5]
```

Output:
```
NaN
NaN
5.0
```


Very cool! Sorry for the late merge. Been rather busy.


It is necessary because the redirect uri is used when:
1. make-auth-request, as a parameter to tell Connect ID where to redirect back to (requires the full URI)
2. authenticated-callback?, to check if the request is matching the auth callback route (only compares the path)


Fixed in dbc8c2672c5b38e1910f24302bdf5a08165fd272


Vtiger_Cache::set('Vtiger_Record_Model', $oginalString, $string);
shouldn't that be
Vtiger_Cache::set('to_html', $oginalString, $string);


Please add the test where locationRepository either throws the NoResultException or returns null.


I have shared a custom dashboard "JDL Studio" on the GA account -> can you see it? Those dashboard can't be realtime, however, for that you need to go to the realtime view and add a filter on the "/jdl-studio" URL


Great. Thanks!


why we make the templates a cache ? it maybe not be valid when the jar is updated .


Good idea, I've just created #34 so that we can discuss the best option and track progress.


I rebased it now....should be fine


Currently it's a .tmp.sock; but that doesn't matter.... Feel free to improve if you care


merge latest push


@debonair done in commit: 30fc077ae1742e7ed2e8c6bf2483fa62bfff20cf


This doesn't seem to work in the app. On yosemite 10.10.5


`is_ancestor_of` in resolve needs to be adjusted as well.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16802](https://teamcity.mesosphere.io/viewLog.html?buildId=141931&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:40


@debonair done in commit: 06fd81703315204cfba88baa8dc39420adc23a01


Bad style, use node namespaces, see https://github.com/DroneEmployee/drone_employee_ros/blob/master/small_atc/launch/demo.launch


Thank you @davidchin :)


Ah, yes, thanks - got it sorted with https://github.com/guardian/play-googleauth/pull/36


So fast, why?


%{?dist} is not used, Delorean replaces the whole Version: and Release: lines - TODO remove in gerrit after import


I've written a SQLConnection module in src/sql/ that may be useful here. It pulls the connection parameters from a text file and takes care of eliminating SQL injection (when used properly) so you can use it like:
SQLConnection sqlConnection = new SQLConnection();
ResultSet rs = sqlConnection.executeQuery("select * from pilot where id = ?", id);


Why would this just be a warning? I am not sure we want to have our bindings get out of hand as the application gets larger and larger. If there is good reason for this then I understand.


a


How to implemet this in spectrum2?


> maybe it's unnecessary

I was just thinking about this -- I believe it is unnecessary since paths can never resolve to items in functions/blocks.


@jjohnson42 What's the meaning of 'txc'? Is not it 'txz'?


Checking differences for passing_data commit


To avoid `innerHTML` this can be replaced by the following code:

    var domParser = new DOMParser();
    var doc = domParser.parseFromString(this.responseText, "text/html");
    rootElement = doc.body;

Hopefully AMO won't nag then!


Nice. Looks much cleaner.


The first thing that comes to mind is that it should be

`if not (current and cap) then return end`

Can you try that change out?


Vassil, thanks for letting us know, we'd be interested to hear more sometime.


You are right. Going to fix that.


Incorrect issue in title, this actually refers to issue #2178.


was missing


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16803](https://teamcity.mesosphere.io/viewLog.html?buildId=141932&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:03:54


are you asking for what code is this? or what is in this page?


Круто, теперь все по макету! Как вариант - можно ставить картинку макета на background у body (с background:
url() no-repeat center 0), чтобы она отображалась прямо в процессе верстки, а потом убрать ее в конце. Это
я к твоему вопросу про оптимизацию верстки, чтобы не надо было пользоваться плагином Perfect Pixel потом,
я поискал и нашел такой вариант, жаль, что раньше не додумался до него.
1. Логотип "Техномарт" должен быть по идее ссылкой везде, не только на странице каталога.
2. Думаю, кнопкам в шапке можно было просто задавать width: 150px с box-sizing: border-box и верхними отступами.
3. https://gyazo.com/40f770b5bbc9c14f89d0121643aa61f8 Тут при желании можно заморочиться с тем,
чтобы сделать отображение табличное (через display: table контейнеру
и display: table-cell самим блокам)и вертикальное выравнивание по середине, чтобы изменение контента
не влияло на отображение лэйаута.
4. .user-pages li - почему это инлайн, а не инлайн-блок?
5. list-style-type: none; можно просто list-style
6. https://gyazo.com/17753ccca3c777541858d4f797f92248 Думаю, полоска у всего меню должна
быть, а не только у пунктов меню.
7. .filter-section-title {
после font-family: "PT Sans" должно быть написано sans-serif
+ нужно использовать безопасный шрифт, например, Arial. такая ошибка встречается и далее, все варианты
я перечислять не буду.
8. <input class="min-price-range" type="text" name="min-price" id="id-min-price" placeholder="0">
вас учили делать это через плейсхолдеры? я бы скорее использовал value.
9. В принципе, всю сортировку по цене, по типу и т.п. можно было бы зафлоатить вправо.
10. В карточках товаров если ты делаешь отступы слева, то нужно убрать их у каждого первого, четвертого
и т.п. Но это оригинальное решение, обычно пишут
.item { margin-right: 20px; }
.item:nth-child(3n) { margin-right: 0; }
А то у тебя какие-то странные левые отступы получились у всего списка.
11. Карточкам стоило бы задать min-height для большей гибкости в контенте.
И странным выглядит разбиение на catalog-item-category и catalog-item-model, очень странным.
Тут скорее можно было бы просто вставить
 после этой категории.
12. https://gyazo.com/f2c20986b882414c6ad0ac46c67b2633 выглядит не очень, я не уверен, что текст
надо прижимать вправо.
13. У bottom-contacts-section call-back и bottom-contacts-section design-by не должно быть ограничения
в ширине, они должны подгоняться под свою ширину, вдруг контент изменится в будущем, верстка при этом
не должна ехать.
14. https://gyazo.com/853df68eb91c8929d98c68b4b2ff0443 Едет всё, должно быть так, если
предполагается, что строка только одна
https://gyazo.com/e4ef26419d8c7c5b5631aa876756f8fd
Обрати внимание на последние 4 правила. Кстати, это подойдет и для других аналогичных ситуаций, например,
с юзернеймом.
15. Слайдер не работает.
16.
<a class="brand" href="#"
Тут явно нужно ссылке задать дисплей: блок.
17. То, что у доставки, гарантии и кредита прыгают блоки, потому что они разные по высоте, это зло :)
Нужно задать минимальную высоту, которая будет в принципе фиксирована, но туда должно влезать
максимальное из этих описаний.
18. В карте иконка крестика прямо на моей аватарке, вряд ли это так должно быть.
19. В формах нужно использовать outline: 0 на инпутах, чтобы отключить эту синюю подсветку в хроме.


This doesn't look like a checksum update.


PSR-2 ? :)


This doesn't test that the non-CSG item isn't returned, I can see it's implied but not really asserted.
Perhaps you could extract/expose the `content_id` of non-CSG item:

```ruby
let(:non_csg_content_id) { SecureRandom.uuid }
```

then use this later in your test assertion...

```ruby
expect(described_class.all.map(&:content_id)).not_to include(non_csg_content_id)
```

This way you're explicit about the return values of the `.all` method.


```js
class Scheduler {}
const scheduler = new Scheduler()

const add = (x, y) => x + y
const removeTask = scheduler.add('*,3,*', () => add(3, 4))
removeTask()

const schedule = xo.getSchedule(3)
const removeTask = scheduler.add(schedule.cron, () => xo.runJobSequence(schedule.job))
```


I ended up not using this option after all. I'll remove it so that there's no confusion.


@lv-zheng shadowsocks-go uses net.Dial() to connect to remote server, which uses the default dns resolver in golang. Maybe you can try cgo dns resolver and modify __/etc/gai.conf__ ?


trial


Actually, since paths never include anonymous modules or their items, using `ModuleS::def_id()` would work -- I'll do that instead.


Yeah, maybe that is the cleanest way. I'll cook something up.


fix issue #1


It might be better to assign the handler function via `addEventListener()`. That's more constant to the other places in the code where event handlers are assigned and allows to use an event parameter instead of (ab)using the `this` scope.


My environment is
- Magento ver 1.7.0.0
- PHP ver 5.2.8


:smile:


Honestly, I'm not sure as it was so long ago.  If I had to guess I would say that I accidentally added the `node_modules` folder to the repository and this commit was fixing that mistake.  But that's a guess.

Sorry I can't be of more help.


Nit: We're counting errors here, not badges. :-) So `errorCount` is more appropriate.


@tj I had to restore previous behaviour as `mvn clean` requires `pom.xml`


That seems to be working fine :)


*This should not hold up merging this PR*

It would be good to add an imminence api test helper to gds-api-adaptors for this api call.  We've got `imminence_has_places` that takes lat/lng and an array of place details to return, and `imminence_has_areas_for_postcode` that takes a postcode and an array of area types to return, but no `imminence_has_places_for_postcode` that takes a postcode and an array of place details to return.  Note that a place here is something from a data set (register offices, dvla testing centres, uk online, etc...) and an area is a mapit area type (councils, parishes, constituencies, etc...).  It might be worth deprecating `imminence_has_places` and replacing with `imminence_has_places_for_location` to make it clear how the new one and old one differ.


With custom profiles we would like to have

```Rust
pub fn name_to_id(profiles: &TomlProfiles, name: &str) -> Option<ProfileId>
```

I haven't implemented it because it is a bit messy, and because we don't need it yet.

Another option would be to move this function to `TomlProfile`, but then I would have to make `name` field of `ProfileId` `pub`, and I'd rather avoid this. Privacy in the current design guarantees that if you managed to obtain a `PackageId` then the profile it refers to actually exists.


That's weird, you shouldn't have to do that, a channel value is comprised of 2 pulses, which can already be 510+1910 = 2420 us max (counterPPM + pulse).
... except if your transmitter generates really small sync pulses (<90 us) which is unlikely.
Which transmitter do you have ?

Regarding the fact git sees diff in every lines may be fixed like that on your side:
git config core.whitespace cr-at-eol
(do it in the project's folder)


Fixed during update with develop (5b29443)


OK merge It


select * from emp
where emp no=4


I removed `RustcDecodable` here because (with the potential arrival of custom profiles) it's impossible to make `Profile` decodable an guarantee that `deps_profile` is valid.


you have forget add the patch


Are you sure that works? I tried the same thing and it just ended up in a 400 error. Though certainly something else could be wrong too.


@alex-anakin test name says that it finds event in future and it is true. There is no verify of calling method, there is checking of found event only


ertert


Thanks for this.
I have tried to run it but get some errors.
Lines 2463 & 2467 error, not required ?.
The 'def Keys' section lines 705-724 puts the numbers of the keys in the wrong positions on the keys.


Isn't crashCallBackWrapper always null on first start? As far as i can see crashCallBackWrapper is null until the first call to getCrashCallBackWrapper() which is after starting the scan


@kares looking through the test. it runs using lib/jruby.jar and with this you need to set jruby.home.
not sure whether the test did actually run - maybe not due to: https://github.com/jruby/jruby/blob/3806de1acc80010c9b65d81372df63073d2a12a4/test/jruby/test_load_compiled_ruby_class_from_classpath.rb#L24

but the change is legit :)


Thank you. I will do that.


Make this first?


Concern about thread safety of this singleton. It should be fine as it is not actually storing state (the property is in a ThreadLocal)? Maybe the rawJavaClass should be in the threadLocal as well?


Here it is :
F4 70
F5 235


Are you intentionally removing the newline at the end of the files? I don't have a strong preference here whether to keep it or remove it, though it should be consistent throughout all files.

Sebastian


first commit


good catch!


really ? AFAIK, an axe is something to cut tree (or goblins ) :)


![valid](https://cloud.githubusercontent.com/assets/16836807/13248889/10d65466-da47-11e5-8cca-4ba3c0b9d7af.png)
![huge](https://cloud.githubusercontent.com/assets/16836807/13248890/10d79f4c-da47-11e5-9b71-f679fd1982ad.jpeg)
![Uploading header.png…]()
![Uploading bg.png…]()


@elandesign you're right, my mistake #2.
Sorry about that.


Ooh-Wee!


good job!
otherwise it calls onSelectionChange one more excessive time.
noticed this bug recently in my project.
want to PR this?

best regards,
Ascarbek


I checked the overall commits of this PR and found that it's already using what you mentioned above:

https://github.com/swagger-api/swagger-codegen/pull/2199/files#diff-7319b8a5d8240e3b2314ca463db1ebffR58


Yes, it's on purpose so the AST of a module body is not included in the surrounding scope (module or top-level). One way to make this clearer would be to pass the definitionMethod as a `Calltarget` as we do for normal methods.


YUP, thank you.


@docnick
Most of those are already addressed in the version I've been working on with the input generalized code, will push changes soon. Thanks for the review!


@ahstro Do you think something like `rootClassName` make more sense than `className` here?


Mach ruhig.
Mir ging es nur darum mal eine Basis zu haben.
Dann erstelle ich keinen Patch und Du nimmst das mit zu Deinen geplanten
Änderungen dazu.
Am 23.02.2016 09:47 schrieb "Lothar Serra Mari" <notifications@github.com>:

> Ich hätte auch noch ein paar kleinere Änderungsvorschläge die ich heute
> Mittag einreichen möchte, weshalb ihr prinzipiell noch warten könntet - ich
> würde euren Vorschlag natürlich übernehmen. Ich teile die Vorschläge in
> mehrere Commits auf, ihr könnt euch also aussuchen was ihr übernehmen wollt
> :)
>
> Viele Grüße
> rootfather
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mamedev/mame/commit/c8b426efe1b8f68b63f9b5744b264ec6c3db0ead#commitcomment-16261997>
> .
>


The only difference to the code in line 83 is the `mode`, so maybe that should be moved into a function.

Sebastian


sisi


I'm not quite sure it has to be a no-op. Calling m.AddInterfaces() might be obvious, but how about m.AddInterfaces(someSliceComingOverFromTheAPI...) ?


Default methods might trip it, yeah. I did move this before the other logic in a different set of patches, but I can do it here too.


Will fix, thanks.


**HEAD commit has no message.**
*GitCommitBear, severity 1, section `commit`.* *Project wide.*


Note: Code for extracting keywords from Twitter is not yet implemented. Added function only loads it to a List<String> keywords.


-w is ignore whites pace, do you want --word-diff=none?


This one's courtesy to `-Ywarn-dead-code` in 2.12.


I propose we create a new interface for the 1.1 and we deprecate the previous one. (No API break)

About clustering, I feel that we are not be able to implement this without API break so we could keep that for the 2.x version.
Currently I think that persisting the session state will be probably enough.

When you said :

> In particular I think that the DTLS spec is not very precise regarding how session resumption is supposed to work and I suspect that we are currently not doing it right because we do not consider the current connection state's epoch and record sequence numbers...

Did you mean our current implementation of session resumption does not respect the spec ?
I'm not really confident about my specification comprehension. But the fact that I succeed to resume session using GNUTLS reassure myself.


@osroca : I don't think you need my confirmation, but I checked the bigmlcom/io repo and we just left the campfire link there, so I guess the google groups are no longer used.


This is so it appears as a link when I copy/paste this changelog on reddit. :)


Almost, see: https://github.com/mholt/caddy/wiki/Writing-Middleware#return-values-and-writing-responses

If there's no error and you write to the response body, return a status code < 400 and a nil error. If there was an error, though, don't write anything to the response body (including the status code) and return the status code instead.


I missed that one, nice! We should add it to the build :-)


First 2 consul jobs were deployed in parallel before. I believe you can remove serial: true from consul_z1, which will make z1 and z2 consuls deploy in parallel...


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16804](https://teamcity.mesosphere.io/viewLog.html?buildId=141963&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:05:17


It seems to have some strange false-positives, though, I think related to eta-expansion.


I'll setup and update a Github page for the demo later.


Wow, you fixed it so fast, thank you, @antonmi !


Whole project in .rar


Minor: The commit message isn't specific enough - it should say something about adding a new response for the regression tests. And I might be inclined to combine this commit with the [one which updates the responses and expected results][1].

[1]: 163dc00ba43adbac26ca3b55bea1d80f5356fc2c


This logic is flawed. You are basically saying that if we have 5 notes that has that search text, we will have `Showing results for search` 5 times. Also the else block loops through all the items we are currently looping through, this code can be better organized to do the right thing.


Thanks, sorry I'm still learning the ropes with Github :/


Is this a bug? `$data['_id']` is a database ID value already, no?

When implementing a custom type, I don't expect `convertToDatabaseValue()` to be called with a database value, but with a PHP value.


It's not atomic, as with all decisions based on cached state data. We're doing best-effort validation of the input arguments, but then we use asserts to validate our assumptions and give us a chance to re-evaluate the cached data and deal with concurrently changing state underneath us. So, once we get all names, there's always a chance a new interface added in the mean time won't be known and will cause an error. However, we *can* detect obvious issues with the input - like having 2 InterfaceArgs using the same name.


Will check.


Minor: I think it's good practice to always have a newline at the end of a file - you can see GitHub is flagging the missing newline with a red warning above. Most editors have a way to enforce this - I'd recommend that you set it up in your editor to avoid this problem in the future.


Don't do this, yet. The bleat library doesn't support it and the DFU will stop working on node. I'll make these sorts of updates as bleat is brought up to date


One data repo per data and lod will put some mess on the project repo no?

It's easier to provide a sample data associated to a specific version of iTowns ( 1, 2, beta2) for new user no? They are still free to clone the data type (and lod) they want from it.


As per my earlier comment, I'd be tempted to combine this commit with the [one which adds the new response][1].

[1]: c7d9a00ff78c89d09d993f0e7f671cc1e5917301


The current code seems fine, since the definition node does not include the body in its `@Child` but as a CallTarget.


http://www.merriam-webster.com/dictionary/axis :-)


Brilliant ;)


@Matubayasi , is this line necessary?
```
stress(:, :, :) = stress(:, :, :) / 2.0    ! removing the double counting
```
What I see is that at line 109 you already excluded the double counting by
```
do j = i + 1, numpt
```


**Body of HEAD commit contains too long lines.**
*GitCommitBear, severity 1, section `commit`.* *Project wide.*


Note: post-shader's input image size (old image_size) can be calculated like this:
`tex_size / (pixel_size * tex_size)`


This is bad. Usleep_range was correct, msleep sleeps inconsistent.


I've fixed a missing library name. The original error only shows up when compiling the DCMTK library (VXL_BUILD_DCMTK:BOOL=ON), which is not on by default.


Change commit name to:
kvm: limit volume tag name in lkvm invocation to 31 characters

This looks nasty, if someone will use tag name in utf-8 using longer-than-byte-characters - it can fail again...


Yeah but this stuff runs only on the server, using a minimal PHP for bootstrapping. On Heroku, that's a PHP 7 build.


No, "child-id" here means the provider id of the interface named "child", and similarly for "parent-id". In might have been "42" instead, but since we don't (and can't) impose restrictions on the format of provider IDs, I thought using non-numeric IDs here will make the test and the error easier to follow.


jak to budeš používat bez hesla když ho tu nutíš aby fielda existovala v initu? neměl bys na to udělat nějakou metodu, kterou budeme moci přepsat _init_auth_fields např


spíš self.fields[self.username_field_name].label is None :)


Hard to read :(


NL


Yes, good catch.


Minor: I might've been inclined to add this response and regenerate the responses & expected results, regenerate the test artefacts, and regenerate the checksums **before** making the actual change to the content. Then you could regenerate the regression test artefacts & checksums again in a later commit and it would show the *change* more clearly.


commented these effects as per your suggestion


So, there should be a limit up to 31 byte data, containing string of 31 or less unicode "runes".


Habe ich inzwischen eingesehen Ist besser so.


I intend to use it for spaces and subnets soon, but even with only one caller, it still makes a code like this:
```go
return &ErrParentInterfaceHasChildren{parentName: "foo", childrenNames: []string{"bar", "baz"}}
```
easier to read like this IMO:
```go
return newParentInterfaceHasChildrenError("foo", []string{"bar","baz"})
```


Looks good.  I might reformat some of the text to shorter line lengths later though ;)


I'm surprised gofmt didn't fix this. Will do.


Fixed header brand padding too.


Well ok :). Still, urdf and blender documentation seems to use axis over axes :)


I might be wrong but I assume `tabWorker` should never be defined here. (Maybe we should switch to `let` statements to avoid any conflicts.)

Sebastian


good job everyone, you're amazing ^^


I have now a fresh DB with all updates installed and a fresh core
result is the same :( It is always 1 hp
![spider](https://cloud.githubusercontent.com/assets/10637389/13249246/79a685fc-da23-11e5-8d9d-4d3a7181cc1b.jpg)


Yes. That documentation is referring to a single process.


Fixed sausage menu padding too.


zde by měla být verze, myslím, že to ale přepisuje ondra ne? z té tvé verze


- remove the `Scheduler`
- move code related to schedules management to `xo-mixins/scheduling.js`
- create the `scheduleFn()` in `utils.js`

```js
export const scheduleFn = (cronPattern, fn) => {
  let running = false

  const job = new CronJob(cron, async () => {
    if (running) {
      return
    }
    running = true

    try {
      await fn()
    } catch (error) {
      console.error('[WARN] scheduled function:', error && error.stack || error)
    } finally {
      running = false
    }
  })

  return () => {
    job.stop()
  }
}
```


The changes look fine, but the commit message isn't according to guidelines.

You can do a `--amend` on this commit to change that.
The issues are:
 - The lines are not truncated at 73 chars (we have a limit on no. of chars on a single line - this is why gitmate fails)
 - Don't use `This change is made for` just mention `Fixes`
 - Title of the git message should have a `:` on the left should be filename being edited. On the right, the action happening

Check other commit messages to get examples of what types of messages we use


I'd say keep a "sample" and "sample-small" for v1, and only one sample dataset for v2 for now


Why not rely on TSQL GETUTCDATE() ? Saves a param.


The MgoSuite panics during SetUpTest, not the test itself or any of the code it exercises.
I'll clarify the comment.
Unfortunately, the race detector was disabled for all state/ tests (have a look in state/package_test.go).


The name of this method can simply be `packageLoggerExists` and also -- when you specify parameters, please use variables which are more meaningful. `s` doesn't really ring a bell; could you please rename this to `loggerPackage`?


s/Add DECIMAL to JSON casts/Add  JSON to DECIMAL casts/


víš že tu nastavuješ statickou proměnnou takže když to změníš v jednom requestu tak ti to zůstane do druhého, takže se tato hodnota nesmí nikdy dynamicky menit v opačném případě jí musíš definovat v __init__, proto se toto také dává do meta


Agreed & done.


why? now god knows what it means


Nit: Too much indentation. Should be only 4 spaces.

Sebastian


in bigmlcom/io the link to the Google list is still there https://github.com/bigmlcom/io#forum-and-mail-contact


Ugh. Yes. It had a Unicode char that is unloved....

----
Sent from my phone.

> On Feb 23, 2016, at 12:08 AM, Jordan Bramble <notifications@github.com> wrote:
>
> @simsong FYI this line throws an error on an EMR cluster, I beleive it doesnt like the - in the comment.
> deleting the line, runs fine. Here is the error.
>
>  File "ANLY502/L03/wordcount_top10.py", line 46
> SyntaxError: Non-ASCII character '\xe2' in file ANLY502/L03/wordcount_top10.py on line 46, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details
> I can submit a PR if need be.
>
> —
> Reply to this email directly or view it on GitHub.
>


怎么样


Shouldn't we catch a parse exception?


This is just wrong.
"key" in CREDENTIAL_POOL should be an actual API key


Aw, thanks! BTW keep an eye on my Github page, I will make a [trick](https://github.com/IonicaBizau/github-contributions)!


Add negative test case here, like `cast(JSON 'dummy_string' as DECIMAL(10,5))` and check that exception is thrown


Okay.


@ramonsmits I thought about that but if there's a time drift between the endpoint and the database we might see some odd effects. And when we send, we use `DateTime.UtcNow` to calculate the `Expires` column. I wanted to have the same "reference" time source to make an expiration decision.


Only frontend part


This is not entirely true, the delete can have locking issues when running via a non-clustered index. By letting it run on the clustered index it will not conflict with locks caused by the SELECT TOP 1 that fetched messages from the queue.

Yes, it will result in more IO but SQL will also need to update the index at INSERT.


memory leak when key was already set?

and other similar places.

user may call setNodeAt multiple times with same key, maybe update value, will cause memory link


Can you update the PR with a proposal for the *new interface*?

The DTLS spec does not clearly specify whether it is allowed to resume a session with a ClientHello from epoch 0 (in particular, not encrypting the message). Given that a (full) re-handshake that is triggered from the server (by means of a HelloRequest) seems to be expected to be done under the *current state* of the connection (i.e. current epoch, current record sequence nos, current cipher etc), it seems quite strange to me that a client that obviously is in possession of the session's master key, epoch etc. should be allowed to resume the session using plaintext handshake messages. However, this is probably something that should be discussed with the authors of the spec. The fact that you are able to resume a session using GNUTLS seems to indicate that we are not the only people who have drawn the same conclusions from the spec. Whether they are what the authors had intended is another question ;-)

Coming back to the general feasibility of providing support for DTLS session failover. In order to do that we would need to share at least the session's master key and crypto params (cipher, epoch etc) via some external component, e.g. Redis, DB, which leaves me with somewhat mixed feelings regarding security. In particular sharing the master key seems quite risky, don't you think?


Aqui o type tbm não devia ser o backgroundFill que criaste?


!self::$active**)** &&  self::init();
这么写是不是多个半个括号?


I think it will take a while for Github to update those stats...


Mucho! xD


wouaw c'est beau


Minor: I'd be inclined to combine this commit with [the later one which updates the checksums again][1].

[1]: 4cd133f7dc2ab8bbcb93bdfdb636365742361c1a


Typo: @vent


I would remove `serial: true` from consul_z2. We want to keep `serial: true` for consul_z1 to create it first, then z2 and z3 can run in parallel.


Minor: I think that referencing the old PR in the commit note might be slightly confusing. However, if you combine with the later commit that won't be a problem.


Was this approach discussed?  I thought we were planning to not actually delete SD, but rather empty most of the contents and leave the reduced data in the chunkstore as a flag that the chunk had been deleted.  That way the data can't be "Put" again, since the deleted marker still exists.

Also, should the user's account be refunded?


Check out 9989654.


ryh


It will be automatically visible.
Please take a look on the lib readme for more details.

Regards.

Seve


and so the release party commence! :confetti_ball:


By design, the only way to free memory in the JsonBuffer is to discard the whole buffer.
The memory will ultimately be freed so it's not a memory leak.


just noticed that it breaks some code.  i'm using glossary instance in one of my tests (probably, i would release them here someday), so when i'm creating manually of course no `ui` passed.

```python
Traceback (most recent call last):
  File "/Volumes/DataHD/users/ivan/projects/py/pyglossary/test/dsl/tags.py", line 77, in <module>
    g = glossary.Glossary()
  File "/Volumes/DataHD/users/ivan/projects/py/pyglossary/pyglossary/glossary.py", line 216, in __init__
    if self.ui.pref['utf8_check']:
AttributeError: 'NoneType' object has no attribute 'pref'
```


Typo in error message, "g" missing before uzzlehttp.


Minor: I'd be inclined to combine this commit with [the later one which updates the regression test artefacts again][1].

[1]: e527c9691f745a9a04294557960594789b082187


Note: this only happens if you use a `String` as a key.


If you want these things to be very dynamic as to always be square, then you'd probably have to do some maths maybe?


This is an improvement to `bezier_library`, not `bezier_application`!
Keept it like this, not a big deal :)


Best would be to test it out :) FWIW ODM's types are idempotent: https://github.com/doctrine/mongodb-odm/issues/765


@debonair Done in commit: 570198e95849812064ce7b21cac598a0aa3f6712


Minor: The commit note isn't specific enough - it should mention regression test artefacts (not just "text changes"). However, this wouldn't be a problem if you combined this commit with the later one.


Same here, you are modifying `bezier_library`. Keep it here like that.


The 5 minute interval is too high I think. Take a look at heartbeats for example which have a TTBR set of 1 minute.

I like the approach of running the purge in a seperate thread.

Maybe signal the task when we normally detect an expired message? That would also purge on-demand.

Very handy for example when using the outbox and message could not be dropped to the queue for a long time. When this happens it could be that a massive amount of expired messages is written.


@debonair fix in commit 570198e95849812064ce7b21cac598a0aa3f6712


@debonair Fix in commit: 570198e95849812064ce7b21cac598a0aa3f6712


Thank you, I fixed it.


thank you very much for all your awesome work


Very minor: I'm guessing this isn't just a "cosmetic" change. I'm guessing it was a style change suggested by the Content Team. In which case, it would be good to say so, otherwise it looks as if you, the developer, has just decided to make the change arbitrarily!


Alright. :)


Thanks Jeremy, I'm going to change my PR to follow contribution guidelines.

On 22 February 2016 at 03:42, Jeremy Danyow <notifications@github.com>
wrote:

> @DrUNE <https://github.com/DrUNE> good catch, thanks for this PR! Few
> things we need before we can merge:
>
>    1. sign the CLA (instructions in contributing.md)
>    2. amend commit message to follow guidelines (instructions in
>    contributing.md). Our release notes are automatically created based on
>    the commit messages.
>    3. Add tests for the observer locator that verify it returns the same
>    Array/Map/Set instance when called multiple times.
>
> Thanks!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DrUNE/binding/commit/8f5977598f210492eef4f4fa078e7e0796d6a821#commitcomment-16230336>
> .
>


Why not always run the task immediately at startup? It makes the most sense to run it at start.


This should be clearly stated in the documentation.


Please all share the news on every gamedev and/or free software related platforms that you use :)


@floehopper will do


Very minor: I think the commit note should be more specific and mention "regression test artefacts" and not just "artefacts", even if this is in the commit note body and not the subject.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16807](https://teamcity.mesosphere.io/viewLog.html?buildId=141978&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 235 Build time: 00:07:59


It is actually true in tests. Discussed to init the Mutex for the test (done).

get_delta_monotonic doesn't strictly need to be in the core rb, but decided to do it anyway for improved findability.


Add debug log that the task is executed.


@ramonsmits I indeed experienced deadlocks without the index at first but after adding the table hints to process the rows exactly the same as the receive query I didn't run into any deadlocks.

Is there still a potential for a deadlock? Maybe adding `RowVersion` as an included column to the index would help?


Small addendum: apparently 22931 refereed to S7, which was not bugged. My mistake.


Why INFO log when no rows affected?


Now fixed and new commit pushed - I did this as a new commit rather than amend an existing one to retain the reason why the change was made.


Could we have a comment with an example for $thisdir to explain why we need this exact number of ../'s?


@ezvirtual Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.namedfile/3/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/namedfile/__init__.py:0:1: C101 Coding magic comment not found
plone/namedfile/__init__.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/__init__.py:3:5: F401 'zope' imported but unused
plone/namedfile/__init__.py:8:1: F401 'zafFileChunk' imported but unused
plone/namedfile/__init__.py:10:1: F401 'NamedFile' imported but unused
plone/namedfile/__init__.py:10:1: F401 'NamedImage' imported but unused
plone/namedfile/__init__.py:11:1: F401 'NamedBlobFile' imported but unused
plone/namedfile/__init__.py:11:1: F401 'NamedBlobImage' imported but unused
plone/namedfile/__init__.py:12:1: W391 blank line at end of file
plone/namedfile/browser.py:0:1: C101 Coding magic comment not found
plone/namedfile/browser.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/browser.py:10:1: E302 expected 2 blank lines, found 1
plone/namedfile/browser.py:12:1: W293 blank line contains whitespace
plone/namedfile/browser.py:16:1: W293 blank line contains whitespace
plone/namedfile/browser.py:19:1: W293 blank line contains whitespace
plone/namedfile/browser.py:23:1: W293 blank line contains whitespace
plone/namedfile/browser.py:25:1: W293 blank line contains whitespace
plone/namedfile/browser.py:30:1: W293 blank line contains whitespace
plone/namedfile/browser.py:32:1: W293 blank line contains whitespace
plone/namedfile/browser.py:35:36: E261 at least two spaces before inline comment
plone/namedfile/browser.py:39:1: W293 blank line contains whitespace
plone/namedfile/browser.py:41:1: W293 blank line contains whitespace
plone/namedfile/browser.py:63:1: W293 blank line contains whitespace
plone/namedfile/browser.py:66:1: W293 blank line contains whitespace
plone/namedfile/browser.py:68:1: W293 blank line contains whitespace
plone/namedfile/browser.py:69:1: E302 expected 2 blank lines, found 1
plone/namedfile/browser.py:71:1: W293 blank line contains whitespace
plone/namedfile/copy.py:0:1: C101 Coding magic comment not found
plone/namedfile/copy.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/editor.py:0:1: C101 Coding magic comment not found
plone/namedfile/editor.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/editor.py:22:1: E302 expected 2 blank lines, found 1
plone/namedfile/editor.py:39:1: E302 expected 2 blank lines, found 1
plone/namedfile/editor.py:54:1: E302 expected 2 blank lines, found 1
plone/namedfile/field.py:0:1: C101 Coding magic comment not found
plone/namedfile/field.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/field.py:11:80: E501 line too long (80 > 79 characters)
plone/namedfile/field.py:21:1: E302 expected 2 blank lines, found 1
plone/namedfile/field.py:95:1: W391 blank line at end of file
plone/namedfile/file.py:0:1: C101 Coding magic comment not found
plone/namedfile/file.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/file.py:158:80: E501 line too long (84 > 79 characters)
plone/namedfile/file.py:170:29: E203 whitespace before ':'
plone/namedfile/file.py:225:24: E261 at least two spaces before inline comment
plone/namedfile/file.py:288:1: C901 'getImageInfo' is too complex (15)
plone/namedfile/file.py:299:30: Q000 Remove bad quotes.
plone/namedfile/file.py:307:11: W503 line break before binary operator
plone/namedfile/file.py:309:30: Q000 Remove bad quotes.
plone/namedfile/file.py:317:30: Q000 Remove bad quotes.
plone/namedfile/file.py:331:39: E701 multiple statements on one line (colon)
plone/namedfile/file.py:332:39: E701 multiple statements on one line (colon)
plone/namedfile/file.py:335:42: Q000 Remove bad quotes.
plone/namedfile/file.py:338:49: Q000 Remove bad quotes.
plone/namedfile/file.py:351:30: Q000 Remove bad quotes.
plone/namedfile/file.py:352:23: E261 at least two spaces before inline comment
plone/namedfile/file.py:354:43: Q000 Remove bad quotes.
plone/namedfile/file.py:366:80: E501 line too long (84 > 79 characters)
plone/namedfile/file.py:388:22: Q000 Remove bad quotes.
plone/namedfile/file.py:407:22: E231 missing whitespace after ','
plone/namedfile/handler.py:0:1: C101 Coding magic comment not found
plone/namedfile/handler.py:6:1: W293 blank line contains whitespace
plone/namedfile/handler.py:8:1: W293 blank line contains whitespace
plone/namedfile/handler.py:10:1: W293 blank line contains whitespace
plone/namedfile/handler.py:12:1: W293 blank line contains whitespace
plone/namedfile/handler.py:14:80: E501 line too long (91 > 79 characters)
plone/namedfile/handler.py:15:1: W293 blank line contains whitespace
plone/namedfile/handler.py:18:1: W293 blank line contains whitespace
plone/namedfile/image_exif_rotation.py:0:1: C101 Coding magic comment not found
plone/namedfile/image_exif_rotation.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/interfaces.py:0:1: C101 Coding magic comment not found
plone/namedfile/interfaces.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/interfaces.py:12:14: E251 unexpected spaces around keyword / parameter equals
plone/namedfile/interfaces.py:12:16: E251 unexpected spaces around keyword / parameter equals
plone/namedfile/interfaces.py:46:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:66:1: W293 blank line contains whitespace
plone/namedfile/interfaces.py:69:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:73:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:79:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:83:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:87:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:91:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:101:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:112:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:116:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:119:1: W293 blank line contains whitespace
plone/namedfile/interfaces.py:122:1: E302 expected 2 blank lines, found 1
plone/namedfile/interfaces.py:126:1: E302 expected 2 blank lines, found 1
plone/namedfile/marshaler.py:0:1: C101 Coding magic comment not found
plone/namedfile/marshaler.py:7:1: C901 'If 7' is too complex (13)
plone/namedfile/marshaler.py:16:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:18:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:23:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:26:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:31:34: Q000 Remove bad quotes.
plone/namedfile/marshaler.py:31:80: E501 line too long (87 > 79 characters)
plone/namedfile/marshaler.py:35:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:36:80: E501 line too long (96 > 79 characters)
plone/namedfile/marshaler.py:47:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:50:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:60:25: E128 continuation line under-indented for visual indent
plone/namedfile/marshaler.py:61:25: E128 continuation line under-indented for visual indent
plone/namedfile/marshaler.py:62:25: E128 continuation line under-indented for visual indent
plone/namedfile/marshaler.py:63:25: E124 closing bracket does not match visual indentation
plone/namedfile/marshaler.py:64:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:66:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:70:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:77:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:83:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:85:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:89:1: W293 blank line contains whitespace
plone/namedfile/marshaler.py:96:1: W293 blank line contains whitespace
plone/namedfile/scaling.py:0:1: C101 Coding magic comment not found
plone/namedfile/scaling.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/scaling.py:46:26: S001 found %s formatter
plone/namedfile/scaling.py:47:21: S001 found %s formatter
plone/namedfile/scaling.py:84:26: Q000 Remove bad quotes.
plone/namedfile/scaling.py:84:27: S001 found %s formatter
plone/namedfile/scaling.py:123:34: Q000 Remove bad quotes.
plone/namedfile/scaling.py:219:1: C901 'ImageScaling.create' is too complex (12)
plone/namedfile/scaling.py:233:12: P002 found "hasattr", consider replacing it
plone/namedfile/scaling.py:263:41: S001 found %r formatter
plone/namedfile/scaling.py:268:31: S001 found %s formatter
plone/namedfile/scaling.py:280:16: P002 found "hasattr", consider replacing it
plone/namedfile/scaling.py:299:16: E713 test for membership should be 'not in'
plone/namedfile/storages.py:0:1: C101 Coding magic comment not found
plone/namedfile/storages.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/storages.py:29:1: W293 blank line contains whitespace
plone/namedfile/storages.py:41:1: W293 blank line contains whitespace
plone/namedfile/storages.py:45:31: Q000 Remove bad quotes.
plone/namedfile/storages.py:53:1: W293 blank line contains whitespace
plone/namedfile/storages.py:57:31: Q000 Remove bad quotes.
plone/namedfile/storages.py:69:1: W293 blank line contains whitespace
plone/namedfile/storages.py:74:34: Q000 Remove bad quotes.
plone/namedfile/storages.py:82:1: W293 blank line contains whitespace
plone/namedfile/utils.py:0:1: C101 Coding magic comment not found
plone/namedfile/utils.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/utils.py:13:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils.py:22:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils.py:22:80: E501 line too long (82 > 79 characters)
plone/namedfile/utils.py:37:1: E302 expected 2 blank lines, found 1
plone/namedfile/utils.py:44:24: Q000 Remove bad quotes.
plone/namedfile/utils.py:45:24: Q000 Remove bad quotes.
plone/namedfile/utils.py:49:58: Q000 Remove bad quotes.
plone/namedfile/utils.py:50:49: Q000 Remove bad quotes.
plone/namedfile/utils.py:51:28: Q000 Remove bad quotes.
plone/namedfile/utils.py:51:80: E501 line too long (95 > 79 characters)
plone/namedfile/utils.py:51:81: S001 found %s formatter
plone/namedfile/utils.py:53:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/base.py:0:1: C101 Coding magic comment not found
plone/namedfile/tests/base.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/tests/base.py:9:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/base.py:14:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/base.py:18:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/base.py:29:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/base.py:35:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/base.py:38:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/base.py:38:80: E501 line too long (84 > 79 characters)
plone/namedfile/tests/base.py:42:17: S001 found %s formatter
plone/namedfile/tests/base.py:48:27: S001 found %s formatter
plone/namedfile/tests/test_blobfile.py:0:1: C101 Coding magic comment not found
plone/namedfile/tests/test_blobfile.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/tests/test_blobfile.py:34:6: E111 indentation is not a multiple of four
plone/namedfile/tests/test_blobfile.py:34:63: Q000 Remove bad quotes.
plone/namedfile/tests/test_blobfile.py:34:80: E501 line too long (80 > 79 characters)
plone/namedfile/tests/test_blobfile.py:35:6: E111 indentation is not a multiple of four
plone/namedfile/tests/test_blobfile.py:35:64: Q000 Remove bad quotes.
plone/namedfile/tests/test_blobfile.py:35:80: E501 line too long (85 > 79 characters)
plone/namedfile/tests/test_blobfile.py:36:6: E111 indentation is not a multiple of four
plone/namedfile/tests/test_blobfile.py:36:66: Q000 Remove bad quotes.
plone/namedfile/tests/test_blobfile.py:36:80: E501 line too long (98 > 79 characters)
plone/namedfile/tests/test_blobfile.py:37:6: E111 indentation is not a multiple of four
plone/namedfile/tests/test_blobfile.py:37:71: Q000 Remove bad quotes.
plone/namedfile/tests/test_blobfile.py:37:80: E501 line too long (89 > 79 characters)
plone/namedfile/tests/test_blobfile.py:72:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_blobfile.py:73:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_blobfile.py:74:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_blobfile.py:75:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_blobfile.py:76:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_blobfile.py:77:1: W293 blank line contains whitespace
plone/namedfile/tests/test_blobfile.py:101:1: W293 blank line contains whitespace
plone/namedfile/tests/test_blobfile.py:101:1: W391 blank line at end of file
plone/namedfile/tests/test_doctests.py:0:1: C101 Coding magic comment not found
plone/namedfile/tests/test_doctests.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/tests/test_doctests.py:6:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/test_doctests.py:12:1: W293 blank line contains whitespace
plone/namedfile/tests/test_doctests.py:16:1: W293 blank line contains whitespace
plone/namedfile/tests/test_doctests.py:20:1: W293 blank line contains whitespace
plone/namedfile/tests/test_doctests.py:24:1: W293 blank line contains whitespace
plone/namedfile/tests/test_image.py:0:1: C101 Coding magic comment not found
plone/namedfile/tests/test_image.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/tests/test_image.py:31:1: E302 expected 2 blank lines, found 1
plone/namedfile/tests/test_image.py:58:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_image.py:59:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_image.py:62:80: E501 line too long (80 > 79 characters)
plone/namedfile/tests/test_image.py:65:80: E501 line too long (80 > 79 characters)
plone/namedfile/tests/test_image.py:85:80: E501 line too long (85 > 79 characters)
plone/namedfile/tests/test_image.py:93:80: E501 line too long (88 > 79 characters)
plone/namedfile/tests/test_scaling.py:0:1: C101 Coding magic comment not found
plone/namedfile/tests/test_scaling.py:0:1: I001 isort found changes, run it on the file
plone/namedfile/tests/test_scaling.py:54:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_scaling.py:69:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_scaling.py:76:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_scaling.py:81:32: S001 found %s formatter
plone/namedfile/tests/test_scaling.py:82:70: S001 found % formatter
plone/namedfile/tests/test_scaling.py:84:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_scaling.py:98:14: D001 found failIf( replace it with assertFalse
plone/namedfile/tests/test_scaling.py:147:32: S001 found %s formatter
plone/namedfile/tests/test_scaling.py:148:70: S001 found % formatter
plone/namedfile/tests/test_scaling.py:155:32: S001 found %s formatter
plone/namedfile/tests/test_scaling.py:156:72: S001 found % formatter
plone/namedfile/tests/test_scaling.py:163:32: S001 found %s formatter
plone/namedfile/tests/test_scaling.py:164:72: S001 found % formatter
plone/namedfile/tests/test_scaling.py:203:32: S001 found %s formatter
plone/namedfile/tests/test_scaling.py:204:70: S001 found % formatter
plone/namedfile/tests/test_scaling.py:206:14: D001 found failUnless( replace it with assertTrue
plone/namedfile/tests/test_scaling.py:294:80: E501 line too long (83 > 79 characters)
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.