> Basic implementation of the RTC for the Transferpak.
Unable to properly test this due to Project64 not being able to emulate the co-processor - http://www.emutalk.net/threads/54598-Pok%C3%A9mon-Stadium-%28Pocket-Monster-Stadium%29-requires-RSP-emulation @project64 @LuigiBlood @LegendOfDragoon

I'm really not familiar at all with Pokemon stuff.
Do you have a save state or something so I can analyze what the RSP is doing?

That EmuTalk post seems rather poorly worded on the specifics.  "Requires RSP emulation" doesn't really say much since we've had working RSP emulation for decades, since before my time.


what happened here? seems this `assertTrue` was important for the test.


Yes, I guess STDOUT.flush should be removed in all places...


I've switched from "manual" (curl) method of dealing with controller to calmh/unifi-api
Unfortunately there is no function to turn on/off SSID. If someone add these functions to API I can also fix these code.


1. opposite condition shouldn't happen since you call `filterOutTypeVariableConstraints` on the `typeParameterRequirements` constructor argument, right?
2. this looks awful. On every access you have to what kind of constraint it is. Can't you abstract this out in `TypeParameterRequirement` class? `ConstratinKind.TYPE ` could mean empty calculation and maybe `ConstrainType.LONG` would return empty type contraint? If it can not be abstracted out, that probably means that those two entities are indeed two separate things that have nothing in common, so maybe store them on two separate lists in `Signature`? I believe it also would be easier, instead of as it is now - you first artificially merge two entities into one and later on every access you add ifology to differentiate between two of them.


indents are not really consistent...


Marc, you undid a lot of my changes with this commit. Take care when merging not to overwrite what others have done before you. The best way to do so is to regularly pull the repo and only work from inside the repo.


Конечно можно так, но я бы делал более точечно.
Хотя в бутстрапе например также сделано. В целом нормально, меньше геммороя и к этому никто придраться не сможет.
Надо понимать что этот селектор самый прожорливый, браузеру приходится раз за разом все теги просматривать. Хотя конечно для современных браузеров это не так критично стало.


Необходимо сделать так `

`


Would be great to `reword` this commit and give more details on why this is needed (I don't know and I'm curious).


> Den 02/02/2016 kl. 06.38 skrev Rune Funch Søltoft <notifications@github.com>:
>
> Almost all my classes have no default constructors by design. Would that be possible in Trygve?

I think it’s artificially inconvenient. I see your point, but if I look at my own Java or C++ code, I am creating default objects all the time.

I think people fail to separate initialization from instantiation. We have a history going back to C++, which all the other C-languages (Java, C#, Objective-C) have adopted, to tie the two together. We learned early on that that is a bad idea. To enforce no default constructors aggravates the problem. I would rather require an init method that can be applied to an instantiated instance.

I got another idea this morning, and that is that each Context (and maybe class) can just have a script body at the end that appears at the type level, and which is executed before first use.


Mistake left after dealing with code, fixed.


in stock - получается у блока 2 класса in и stock? Или ты хотела .in-stock? необходимо блоки .in-stock и .article обернуть в общий блок, когда будут сетки поймешь зачем!


Неверный тег, необходим "p"


I don't feel this commit adds more value as there is no extra verification involved.


Кнопки как на примере сверху  смотри!


TeamCity libpalaso :: palaso-precise64-libpalaso-2.6 Continuous [Build 2.6.1036.e61716bd546b8c2bdf05d988976f9ca9bccef50f](http://build.palaso.org/viewLog.html?buildId=68781&buildTypeId=PalasoPrecise64v26Cont) outcome was **SUCCESS**
Summary: Tests passed: 3377, ignored: 124 Build time: 00:08:07


Наверное этот закрывающий div лишний посмотри внимательнее


I've checked "MAC Addresses White List" and "Poor Signals Reconnect" but "AP Periodic Reboot" should work also (I hope).


## Task 1

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 2

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 3

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 4

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 5

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)
- [ ] Program is different than [Task 4](task-4) (1 pt)

## Task 6

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (3 pts)


Unsubscribe


Проверил


It's strange that we hadn't seen this on Jenkins, which had been using the latest Python client.


Sorry, but this is ridiculous. Did you at least try to understand what's happening?

1. The Client uploads a result file. It's complete so it is marked read only (444). If it is not complete it is still writable.
1. Then the clients sends a get_file_size message on this completed upload for whatever reason. The handle_get_file_size() function then tries to open the file in append mode. This of course has to fail because the file was already completed so the Client is not allowed to add data to it.

Now we are back to where we where before. The Client can reupload (faulty) result files whenever he wants because they get overwritten. Imagine if this happens between validation and assimilation of a canonical result?

I also stumbled upon handle_get_file_size() when I tested this but this RPC was barely used and if used at all only from older Clients.


I didn't spot this as I should have done, but you've changed unsigned int to uin32_t - and the examples no longer compile.

I'll be reverting that bit of the change.


@ekachandrasetiawan : write nya ada dimana ya ??


+1 :+1:


Hi suresh not all the quote will be from the book. Users can put their own sources in.


write untuk tulis picking_id di dn...


dn.write(cr,uid,val.id,{'note_return_ids':[(4,new_picking)]})
+			if val.prepare_id.picking_id.id:
+				dn.write(cr,uid,val.id,{'note_return_ids':[(4,new_picking)]})
+			else:
+				dn.write(cr,uid,val.id,{'note_return_ids':[(4,new_picking)],'picking_id':val.prepare_id.picking_id.id})


`dn.write(cr,uid,val.id,{'note_return_ids':[(4,new_picking)]})
+			if val.prepare_id.picking_id.id:
+				dn.write(cr,uid,val.id,{'note_return_ids':[(4,new_picking)]})
+			else:
+				dn.write(cr,uid,val.id,{'note_return_ids':[(4,new_picking)],'picking_id':val.prepare_id.picking_id.id})`


That assert might have worked once, but it wasn't working at all now.  I tried to investigate what it was trying to test, but couldn't see what was supposed to fail and why, so I took it out.


oh iya di line 649 ya


Enig.


Does that mean that `self.noShow = bool(int(data[index]))` should be just `self.noShow = bool(data[index])`?


iya jay


Good point. Will add it.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.677.2fa2f382978b9c5f9664a73f738bc014b9aeb353](http://build.palaso.org/viewLog.html?buildId=68783&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3406, ignored: 106 Build time: 00:06:59


@friendsonearth hmm, a breaking change slipped through that I failed to spot. I have reverted the change and released 2.6. It should be available in the Arduino package manager at some point today.

Apologies for the distruption


Yes good point. I am aware of it. I am going to move the ThreadLocalMetricsFactory out of the existing package structure. In short, It will be taken care.


Ditto


global methods bad in C headers!


Fix this!!!


Commit comment


Yes. I had troubles verifying the SLASH_TOKEN until I removed whitespace from the edges, so I did that to all other tokens as well.


Unmatch --> Mismatch


If you look at the rest of the code, whenever the Request file is declared, its actually decorated. It certainly gives more readability.


Fix above...


`registered_data` is `float *`. `&registered_data[512*r+c]` is still `float *`.

What is the purpose of reinterpret_cast from `float*` to `float*` here?


Hi. I'm for now only running on the development version and have not tried to package it yet. Other things became more important but my plan is still to get around to create a build for my use internally so I could share that then.


@AGritsevich you're waiting for signals from system but not from child threads. Please correct comment


:yellow_heart: :heavy_check_mark:


New version uploaded


こちら、対応しました。
次に出す内部レビューパッチにて確認願います。


$ git clone.


I am surprised no one has reported a bug on this, the top position is distorted because of this fix.

top is undefined before this statement, so its always going to be **NaN**
top = top - containerOffset.top + 169; -- line 533

please correct this, this has broken my datepicker in all the places i have used.


@comedinha that should fix the error you described before. What is the other error?


fun fun fun


# **wifi列表的截图：**
![A](http://d.picphotos.baidu.com/album/s%3D900%3Bq%3D90/sign=bdbd1721d7160924d825ae1be43c44c7/359b033b5bb5c9ea1e8e7394d239b6003af3b343.jpg)


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.667.2fa2f382978b9c5f9664a73f738bc014b9aeb353](http://build.palaso.org/viewLog.html?buildId=68785&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3426, ignored: 125 Build time: 00:11:48


TeamCity ReOpenLDAP :: devel [Build 230](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=1753&buildTypeId=ReOpenLDAP_Devel&guest=1) outcome was **SUCCESS**
Summary: Tests passed Build time: 01:46:30


memached와 동일한 방식인 지 잘 모르겠음.
본인이 한번 더 점검하고... 대표님께 리뷰 부탁하는 게 좋을 듯.


itu ditulis di def create_returns() ya ??

berarti ketika DN nya di return,,, bukan pas klik return ??

Kalau di taro di def return_product() bisa ???

Jadi biar pada saat klik return aja udah langsung write data nya


Should commit this PR only after jaggery version is updated to 0.12.2 , as it uses updated code available in jaggery 0.12.2 release.


fibonacci


only tcp 1723 port? udp?


Nope, but we will build that wall!


Plutôt qu'utiliser le toString (utilisé pour l'affichage dans les logs) pour ne pas avoir utilisé le getName() ?


Ah, I understand our discussion now.  There was actually a reason for making `Action` a `newtype` rather than a type synonym: It allows to (1) abstrract away from and (2) hide some implementation details.  Not sure now if I like this type.  How important is it to you?  Is there something specific it achieves that the `newtype` doesn't?


:)  ну смотри, на макете они по пикселям одинаковые, в сумме занимают 100% а написано что 33% каждая. Это никак не лечится, просто там немножко нарушена логика.
Я бы поставил ширину 33.3333% чтобы максимально попасть в пиксели


if propertiesIds what?


this doesn't work if user rename its $(PRODUCT_NAME) to a different name of the appPath , maybe it should be inferredSchemeName ?


> slyšeli podcasty nebo je těšily

Je tam pravopisná hrubka (možná :smile:) nemělo by být správně "těšili"


umh, I guess nothing, I was mislead by PCL standard way to pack rbg color into a float. But yea they are both floats so that cast should do nothing. I'll make a few tests with my fork to make sure nothing changes, then we can remove the cast


This wont solve the purpose if you want to put it in init method.
1) MetricUtil object is created, and it either creates a metrics object and put it in request context or fetches from the request context. The object is light weight and i created at multiple instances in code. The object is not passed across through out the context and hence created multiple times.
2) The method initialize_request_scoped_metrics() should be called only once at the start of a request life cycle before putting it to request context. So putting this logic in init you are executing this multiple times in a request context.


why begin -> end when no instructions between these calls?


why not `$this->context->model->className()` ?


I agree that it's not perfect, but it's good enough for the moment;
I don't want to do big changes unti next release.


if (FOR != 0) ???


Agreed, at the same time I am exploring to store the metrics object in thread local. So i ll just keep it this way and come back to it.


iya betul jay, saat return baru terbentuk

jadi mendingan saat klik langsung write ya?

ok


registerJs has special attribute to run script on doc ready, no need in `$(function(){});`


Joli ^^


When get unique id of widget


can't you make it work with syntax: `p2 = min(38, p + 1)`?


Too wide


iya,,mending gitu


Unfortunately this was not that straight forward and previously only worked due to the messed up include directories. `gtext-extra.h` has an include of `cppformat/format.h` which would require to link `test-main` against `cppformat`. However, if we already link against `cppformat` here than it does not make any sense to provide an `add_fmt_test_name` with `CUSTOM_LINK` given that the library is already linked into the binary.

Do you still need the `CUSTOM_LINK` option? It currently is not used anymore.


CSRF here


Yes, we call obs_vec.end() twice and const iterator may be better.


We 're going to: https://github.com/teracyhq/pixelate clone into the local respository.
--> Go to https://github.com/teracyhq/pixelate and clone it to the local repository.


Typo.

ad = and?


wtf? why not to call $.ajax here and add needed stuff from the response?


Hi,

Fixes to your findings https://github.com/practiceprovider/openemr/commit/11c97e11b92405a3f009b3c4aeaaa6a64d77ee2d


Fixes to above findings https://github.com/practiceprovider/openemr/commit/11c97e11b92405a3f009b3c4aeaaa6a64d77ee2d


Můžeme to udělat, že budu uveden taky. Možná bych to nazval lépe.

Výběr zajímavých odkazů minulý měsíc pro vás nachystal [Martin Pešout](http://www.twitter.com/martinpesout):


ok


Also some more deprecated constructors fixes in above commit


I'm ok with this change, but I don't see it as an improvement.  (`if` is nice because it makes it syntactically clear there are only two options.)


RTFM http://api.jquery.com/data/#data-html5


use `$` instead of jQuery everywhere please


@cramja Marc, this looks good. I will make appropriate changes to the index properties in the SQL parser ypp files to use this class then. Thanks.


LGTM


phpdoc please


Yii::t please


Can abis itu cek semua fungsi DN dan Stock Picking nya,, pastiin DN Jalan mulai Draft, Approve, Postpone, Set Draft, Validate, Retur

- [ ]

Terus setelah itu pastiin fungsi Stock Picking Jalan kalau di jalanin dari modul aslinya ( modul Delivery Order, Incoming Shipment dan Stock Move)
Pastiin semua nya jalan buttonnya , jangan lupa test partial juga

Intinya kita develop tanpa mengurangi fungsi aslinya,, dan memastikan fungsi aslinya ga terganggu

- [ ]


It is concerning that the privilege state is a property of the tab, not a property of URL origin; we need to make sure this is called for every possible code path that causes the origin of the tab to change, or else a website has full unsandboxed node access.  Security-wise, I think it would be better if webviews never had the nodeintegration flag set and anything that required node integration opened in a new BrowserWindow.


ref : https://github.com/guitarrapc/DSCResources/issues/51


There is no other asList method? No `Ints.asList`?


`014-2015` --> `2014-2015`

:)


you can registerJs inside widget then


Hned za tuhle větu by bylo dobré uvést kdo je Ethan Marcotte, co dělá a co udělal. Stačí v několika větách


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1263.c1cb4c75078973ea35dd23d4072e55dc31991851](http://build.palaso.org/viewLog.html?buildId=68790&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 857, ignored: 7 Build time: 00:09:22


I think something is inverted. Why year-sensitive version uses double?


Create the custom.js file


OK


Pour idée :
https://maven.apache.org/guides/mini/guide-site.html

Ce qui se cache dessous : tu pourrais utiliser mvn pour générer un site github : https://github.github.com/maven-plugins/site-plugin/


This is where builder pattern comes into the picture where you dont want a lot of parameters in the constructors.
This is a popular style of programming in java.
I am willing to relook this as python supports named parameter.
Will revisit this later and changing this would be localized.


Why is this should be int?


It might be a "bad translation" from the old Java code, I suppose we could use Ceylon Strings instead, but maybe David can think of another reason?


You forgot a comma separator here.

Also this should be added:

```
	files_search_etc($1)
	admin_pattern($1, redis_conf_t)
```


--> Create `custom.js` and turn an image url into a canvas, then pixelate it.


I do not have a strong opinion of this. This gives the option to the user of not making to methods when he creates the metric objects.


吓尿


↓な感じで実装してみましたが、

https://gist.github.com/takahashiminoru/d326e6e69904bd50362d/revisions

* Protectなメンバーに触っているため、Pylintチェック時にワーニング出たため。（うっかりしてました）
* 結局INT変換処理のために行数は稼いでしまうため。
本箇所は既存通りにしようかと思っています。


Je suis mitigé sur le fait de supprimer la factory Directe... ça permettait, justement, que les classes n'utilisent pas directement l'implémentation mais une Factory... à voir sur le long terme


@malirod , 26fd5aa, Done


Set up bower, gruntjs


не сработает.


Didn't you have to modify also `ClientTypeSignature`?


Thanks for the reply. It's good to hear from you. I discovered [your map](http://tm.teresco.org/hbtest/mapview.php?rg=NS&u=ua747sp&colors=tier1:rgb%28128,210,255%29:rgb%280,160,255%29;tier2:rgb%28128,210,255%29:rgb%280,160,255%29;tier3:rgb%28128,210,255%29:rgb%280,160,255%29;tier4:rgb%28128,128,128%29:rgb%2864,64,64%29;tier5:rgb%28224,144,86%29:rgb%28224,0,0%29) after running a labelsinuse/pointsinuse check on NS327. That coastal outline of NS is a beautiful thing, and it helped me pinpoint a few places where the Lighthouse Route diverges from the NS3 corridor. I'm in the early-to-mid stages of adding the Nova Scotia Scenic Travelways as an in-development system -- one that it appears you've traveled on extensively. I might like to ask you some questions later on if that's OK.


Let's use PJL in your website. You need to create APIs which interact with the file logic `pixleate.js`. It will give interaction to users who use your application.
--> Create APIs which interact with the `pixleate.js` logic file. It will give interaction to users who use your application.


Actually, I think `strtoull()` should always set `endptr`.


Что ты пытался последними тремя стилями сделать?)
Не нужно пытаться как-то влиять на сам body, всю вёрстку мы сделаем вложенными в него блоками.


Select


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1282](http://teamcity.monogame.net/viewLog.html?buildId=14253&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Aah apologies for this. I meant user id.


Better code readability


It looks good to me.


Das war nicht "tröpfchenweise", sondern erstmal für **alle** core Plugins. Aber bislang hat sich auch keiner daran gestört, dass das überall anders war. Es geht mir dabei auch um die Beispielhaftigkeit für künftige Plugins. Für additional_plugins habe ich auch einiges in der Pipe. Aber wirklich machbar ist das nur nach und nach.
> dass wir einfach megaviel Code haben der die braces anders setzt,

Meine Erfahrung ist da anders. Es geht bei diesen rund **31** core Plugins zB bei der `"function introspect(&$propbag) {"` um gerade einmal `(4 hits in 4 files)` gegenüber einer 2.0.3, die daraufhin von mir geändert wurden. Das ist ein Beipiel für meine geschilderte mehrheitliche Erfahrung damit. Ich war daraufhin einfach nur konsequent. Abgesehen davon habe ich wirklich **mehr** als nur das getan. Und in 2 tranchen (für sidebar und event) commited. Packt man solche multi-file, multi-code changes in nur einen commit, sieht man hier auf Github gar nichts, da HTML ausgepackt und gehighlighted limitiert ist. Und dann kann man auch keine Fehler mehr erkennen.


Est-ce qu'une quête peut être perdue ?
Exemples :
 * Rapporter 5 pommes avant qu'elles ne soient pourries à Gérard en (-20,42). Vous avez 3 minutes. => Le délai est écoulé.
 * On fait un pari : si vous tuez les 5 prochains blobs que vous rencontrerez, je vous donnerai la carte au trésor. Sinon, si vous fuyez ou que vous perdez vos combats, vous ne saurez jamais où il est caché.


> Proto doslovné upozornění – pro nejnovějším technické vychytávky nebo hloubku informací hledejte jiné zdroje.

_Proto doslovné upozornění_ - toto spojení mně tam moc nesedí. Možná bych si představoval košatější větu


No. the metric logs are intended to be completely separate.


Sure good point.


Some Peer Review-y stuff I noted while checking on the above:

I-44BLPac:	HilvwDr	-> HillViewDr if two words as tile maps suggest; HilDr if one word as GMSV suggests.
MO US36:	MO151/36Bus nonstandard label
MO110Han:	MO151/36Bus nonstandard label
MO15:	MO156 -> MO156_W


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27037/testReport/) for this commit**


Sure. This is the name of the service. This was explained in the monitoring library.


Зачем тебе .main-header и .main-footer центрировать, если они шириной 100% родителя?

Когда пишешь это правило - понимаешь что в разметке можно было бы сделать всё чуть единообразнее ))
Т.е. можно было либо класс контейнер повесить вторым классом на хэдер и на футер. И убрать вложенный div из html.
Или обернуть все их в общий контейнер, но на это ругается валидатор :)


Good point if this is true. I probably dint read the code here well enough.


Насколько я понимаю, эту штуку можно заюзать для формирования названия файла https://github.com/bem/bem-naming/blob/master/lib/bem-naming.js  - так и сделаю)


Нужно этот момент тоже проработать тогда


1. Le participe passé de "find" est "found"
2. Est-ce voulu que ce soit aléatoire à chaque fois que l'on teste ? Une fois que l'on a trouvé une ville, on peut la reperdre ?


usb_io.c is redundant to usb_detection.c. Likely some cleanup is needed. The later one is likely the older version.


Спасибо за правки! Всё учту и исправлю


**的撒后方i**


Ce constructeur prend en paramètre Tile seulement pour savoir s'il y a du danger...


Didn't realize at first that this was a commit message. I'm +1 on these
changes. Thanks for making them!


TeamCity Chorus :: chorus-precise64-chorus-2.5 Continuous [Build 2.5.1019.bab9ad24dc6ac370cd6b01ef876ee8b815ba2fe8](http://build.palaso.org/viewLog.html?buildId=68793&buildTypeId=ChorusPrecise64v25Cont) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:23:45


是的噶


Eh, I'm on the fence. =)


:smile:


こちら、対応しました。関数化はしませんでした。

関数への変数代入方法を、本処理部のみ変数名指定
(configure=p['configure'],)
にしていたため、見づらくなっていたので
(p['configure'])
な形にして整えました。
このあとの内部レビューにて確認願います。
次に出す内部レビューパッチにて確認願います


I don't think you ever merged #26 which added the support for SliceZones.


Euh... à chaque fois tu vas retourner `this`, non ?

Je ne comprends pas à quoi sert cette méthode.


@toshikazu0314 Thank to be clear. I missed to see it. There is no problem.


I cannot understand the love to the const results. Can you explain what is the purpose of the const result when you return **by value**?


the ticket said that we didn't had to hardcode the actual fields. The ruby, python and go libs (that are already merged and approved by  you @samwierema) don't do it. So maybe the csharp lib shouldn't do it either.


@evilaliv3 I've updated the travis shell script to only check the code coverage under node v0.12. This should  allow us to run the builds for other versions of node at native speeds:

https://travis-ci.org/openpgpjs/openpgpjs/builds/106414695

I'll merge this to master locally once the travis build on the `faster_builds` branch pass. So no need to open a PR.


1行が長くならないのであれば引数で改行する必要はないかなと思います


ありがとうございます。こちら問題なく動作しました。
fopen関数は、対象のファイルがない場合は新たにファイルを作成する、と理解しました。
もし間違っておりましたらご指摘くださいませ。


My fault. Sorry :)


了解しました。


Je ne comprends pas la logique ici...

Soit je connais déjà le type d'aventure que je veux, et j'appelle directement la factory correspondante.
Soit je ne connais pas le type d'aventure que je veux et j'appelle quelque chose au hasard...


ファイルに書きださなくても変数として出力結果を保持すればシンプルにcsv出力できるかと。
ただファイル出力してデバッグなどに使いたいなどの意図があればこの方法でもOKです。


to_json化を実施しました。
ただ、勢い余って
 s = stats.to_jsondict()[stats.__class__.__name__]
のままで実装してしまいました。
ただ、簡略化後もライン数変わりませんし、
部外者でもつくりを理解しやすいということで、このままでもいいかなと思っています。


@pestOO , it doesn't matter, github traslate this to one single line.


The semicolon at the end is not ok, I assume. Will remove it.


Tato sekce je dobrá a třeba já bych osobně uvítal, kdyby jsi ji více rozvedl.


I took the Rstudio Template...


CSV、JSONで使っているsetheaderと共通の値はまとめた方がいいですね


Sorry to bring this up in an old commit, but is this necessary? A while ago I changed the ``ecommerce_env`` in the devstack playbook to use ``ecommerce.settings.devstack``: https://github.com/edx/configuration/pull/2562


Tento odstavec mně tam přijde poměrně zbytečný. Případně bych tu myšlenku rozpustil do nějaké textu uvedeného výše.


This file seems to failing the unit test


Toto je dobré. Jen mě třeba napadlo, že by se hodilo tam nakousnout konkrétněji, co to přineslo tobě. Ale to už je tak trochu navíc.


Should not do that.


I think, we need to be registered to tizen gerrit site before to download the tarball, it can be an issue for several people.


引数としてオブジェクトを受け取る際は、タイプヒンディングやコメントでオブジェクトを指定してあげたほうがいいですね。


You can update and delete APIs. If you needn't use it in your website, you can delete it.


@DelazJ This figure makes the build failed as this ref doesn't exist!


`Event trigger` is very important. We need to specify the event which we want to use.
--> `Event trigger` is very important. You need to specify the event which you want to use.


Do you know if something similar can be done with firmware? The package has ~140 MB.


Don't worry about performance, databases are built to do that kind of stuff.
And since we're using Postgres, I'll have to migrate the JsonFields to native Postgres fields which will make things even faster (but which means no more sqlite in dev unfortunately)


--> In this post, I've guided you step by step to use PJL as different JavaScript libaries. I think you can now own this library. It's very easy and convenient for any developer.


ここから67行目までの処理はコントローラーに記載するにはふさわしくないかと思います。
データ構造を作成したり、if分岐で処理が変わる場合にはmodelに記載しましょう。


Actually, I think `strtoull()` is required to set `endptr`. Doesn't hurt to initialize it though.


--> The details about Pixelate JavaScript Library at https://github.com/teracyhq/pixelate


It's probably saner to just count from the end instead of the beginning.  The context parameter will be the last except for the (optional) error result and the (optional) witness-method self metadata.  Among other things, that should allow you to emit the polymorphic arguments in their natural position.


Ok for software GPU but make warning that do not enter on conflict with mesa or your gpu.


that seems unrelated - are you sure we need to retain the extras (and now the ID separately)? I think we do it for the whole message already, right?


このif文の内容に違和感があります。
引数の有無で処理が切り替わるのであれactionごと分けたほうが良い気がします。

また仕様面の話ですが、キーワード検索時にソートを適用しないことに違和感があります。


I think you need something much simpler (and generic) : `Stream<T> toStream(Optional<T>)` so you can just flatmap


This still breaks the build (at least for me). I had to add the proper dir to the header search path [1] and also had to remove the sys directory [2].

[1] http://dpaste.com/35GH0JM
[2] http://dpaste.com/1WVH6T4


remove config.xml, not used anymore


Have you tried?

git clone git://review.tizen.org/platform/adaptation/renesas_rcar/wayland-kms.git

I don't think you need to register to read the repositories.


Good point... let me fix this.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.581.8515507208c1539220ebee854cf5e7e479e1de6d](http://build.palaso.org/viewLog.html?buildId=68794&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 931, ignored: 56 Build time: 00:19:07


Changed that. Thanks.


Um.. :)


Ok, now I understand what this test is supposed to do, thank you for clarifying!

I definitely see why this is valuable for quick checks during development. However, from the testing point of view I am still not convinced that it is a good way to approach this given that it only slightly increases coverage with a syntax check. If you really want to know if the library is working (i.e., formatting correctly) with `-std=c++98` than you have to run all the other tests as well.

I see two possibilities to achieve the full test coverage:
* Define via an option if c++11 should be used at all (e.g. `FMT_USE_CPP11` defaulting to `On`) and test everything in both modes on the CI servers.
* Extend the old approach. I would define a second `cppformat` library (e.g., `cppformat98`) which is explicitly built with `-std=c++98` (and probably guard it by an `FMT_TEST_CPP98` option). This new library would than be used to run all possible tests in addition to the original `cppformat` library.

Of course there is also the third option which simply brings back the old behavior. If we go this route than I would at least make the intend explicit by adding `-std=c++98` to the test (if it exists).

What do you think is the best approach?


verbose_name - со строчной буквы, Джанго сам капиталайзит когда это нужно.


Can you rephrase it according to blahBlah_mustBlah pattern?


Me too. Seems reasonable though.


hey @rafaprax!

what is the reason for this change? You are bypassing the abstraction the user installs to get their resources. This way you are basically saying that you know how every incoming bundle is going to be constructed, which I believe is a very strong assumption.

Please, let's discuss this and find a better way.

Thx.


hi humans


@mixas27 what if it's a Hibernate Proxy?


всегда from django.conf import settings, и четние настроек так: settings.DEFAULT_FROM_EMAIL


if文の中身がないなら否定条件にしてしまえばいいんじゃない？


Maybe define as a constant?


nothing change


What was the issue here?


I don't think Ansible is needed on the target server.


Reword to :"These helpers are also used in bignum printing", or somesuch.


这不是 bug，markdown 语法也支持这种写法，最终生成 ordered list。不过，按您这种写法，读源码的时候更清楚些。


if文多すぎ


Well somethin seems to be going wrong. Any idea why saucelabs isn't working atm?

https://travis-ci.org/openpgpjs/openpgpjs/jobs/106417506#L321


Names like Jenkins and Linux should be capitalized.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1282](http://teamcity.monogame.net/viewLog.html?buildId=14253&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:30:48


課題10
2で割ってからまた掛けて戻すのは効率的ではありません。単純に2で割った余りが0か？などで直接判定してください


Оформляй хотя бы TODO, чтобы поиском можно было найти.


叫initCable更好吧？Cabe是笔误？


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.173.8515507208c1539220ebee854cf5e7e479e1de6d](http://build.palaso.org/viewLog.html?buildId=68801&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 943, ignored: 50 Build time: 00:37:29


笔误 ~


ここの空判定が冗長な気がします。
もう少しすっきりとしたロジックで同じことが実現できそう。


@pestOO , In genivi there is no such version, only pasa.


Looks like we should take in account this case


You might want to read this definition again, this has kind `Context` not `*`. The use would be: `MonadAction e s m => a -> b -> m c` instead of `a -> b -> Action e s c`.


Only subscribers of the target branch (where we move *to*) should receive notifications.


Oh, I see. That make sense. Definitely better than something like ``old_old_fmt`` :)


I am a nice comment


replace widget test with other suites since it is not exist on master


I think it would be best to use a smaller scope, e.g. `webcoin:bridge` instead of just `webcoin`.


ここの変数を複数形にした意図ってなんでしょう？


We tend to place the default values in this configuration sample. This would be an empty string.


Can you add some more information about how the additional modifiers should be used?
For example: how do you add multiple modifiers etc.


I don't understand why do you make a special case of the *org.talend.libraries* artifact, can you explain please ?


Deletes the value equal to the default_value, while saving.


@gyllen Prefetcher seems to have become obsolete here. Remove file?


この変更でロジックが長くなってしまっているので、メソッド化してモデル側に切り出すべきかと思います。


Yes. When we call ```sendNotificationAboutTopicMoved`` target branch already set to topic instance


oops.  you're right.  sorry.  i shouldn't pay to much attention to what i'm thinking before waking up.  (-:

in that case i'm all for this.


not clear this paragrah meaning. maybe you need a application name defination before this sentense


細かいことなんですが、クラス内の上の方にpublicメソッドをまとめて、priveteメソッドはしたの方にまとめて貰えると後からクラスを利用する人が読みやすくなります。
（クラスを利用する人にとってはprivateメソッドの実装は二の次なので。）


リニアサーチ
合致するまで永遠に繰り返す処理になっているので修正
合致した際に「何番目に合致する値があったのか」を表示させるように
全て合致しなかったときの処理を書くように


I agree that this change was borderline useless, the reasoning is that guards is closer to the equational style which is more definitional and less operational. Anyway I will refrain myself from making such changes.


Is there any other approach to avoid
```
java
 field.setAccessible(true);
```
I am thinking, do we really need to use reflection to build a list of predefined properties?


A minor style quibble: I think generally in reST the section header over- and underlines are as long as the heading (although longer ones work as well). I have no good justification for this, I'm just generally a bit bothered by inconsistency :)


$sort_setting引数がオプションではなく、必須になっているのが違和感あります。


Have you checked if multiple threads call this method?


Perhaps this should be GB (bytes, not bits)?


比較対象の配列の要素数が１万個あった時などを考えてください。フローチャートが対象のパラメータにより伸縮するようなことはあってはいけません


why not just make this the default?


@pestOO , explain, please.  I think this is same case.


Since this is undocumented API, would it make sense to also check outLen, just in case? Also, zeroing out basicInfo and perfInfo before the call would add a nice defensive touch :)


@d2bit is it common practice to have this separation between a persistent data container and a disposable execution container?


_on_messages 是什么地方调用的，继承post()方法么


Oh, congrats :-D


Though you can use macro defines
http://www.freepascal.org/docs-html/prog/progse5.html


OK my colleages have just made the test and it's working, I have the doubt because I was registered on the tizen review site.


これってラップ処理ですか？
いまいちこのメソッドの意味が分からないです。


$contentという変数名はふさわしくないと思います。


21212`212`  `4454`


Ahh, no this is just a small hiccup in the current implementation. Soon to be changed.


We had a "pip install" that was failing reproducibly, but the build was green. As a result, the Lambda zip file was deployed with missing a dependency.


Can we move this to the end of the method? Just in case something goes wrong? :stuck_out_tongue:


Whitespace error


@malirod , e5cc0aa, Done


@pestOO , e5cc0aa, Done


@malirod , Changed to Pull request checklist


Would it be possible to upgrade to Jetty 9?


@AByzhynar , @pestOO , e5cc0aa , Done


@Nazanin1369 I mean this.


@AByzhynar , e5cc0aa, Done


I was actually thinking about it and saw problems with both places. Putting it here might mean not all Nancy referencing assemblies would be loaded. Putting it at the end could mean it keeps running this code over and over again and still not being able to load stuff. To be honest, either does sound like a critical app failure instead?


@pestOO , e5cc0aa , Done


Doesn't this technically change the JSON-RPC API? May require a revision version number bump in that case. @Montellese?


@pestOO , @AByzhynar , e5cc0aa, Done


Good to me as well.


@AByzhynar , e5cc0aa , Done


@OHerasym  pleas add information that you should enter name of the person whom you address in review comment. Such in this comment


# 我的第一个GitHub项目

这是项目 [helloworld](https://github.com/gotgithub/helloworld) ，
欢迎访问。

这个项目的版本库是 **Git格式** ，在 Windows、Linux、Mac OS X
平台都有客户端工具可以访问。虽然版本库只提供Git一种格式，
但是你还是可以用其他用其他工具访问，如 ``svn`` 和 ``hg`` 。

## 版本库地址

支持三种访问协议：

* HTTP协议: `https://github.com/gotgithub/helloworld.git` 。
* Git协议: `git://github.com/gotgithub/helloworld.git` 。
* SSH协议: `ssh://git@github.com/gotgithub/helloworld.git` 。

## 克隆版本库

操作示例：

    $ git clone git://github.com/gotgithub/helloworld.git


better git reset to merge the commits


add a notes here, if no manifest special request, such as permissios, you could do not maintain the manifest.json for test suites.


@bjansen is right. Obviously we should be able to use Ceylon strings and the `in` operator.


I like it! :)


Almost looks like improvements, nice!


Are you sure we need all this mutability?


Ah, good catch, what was it in the end?


In this commit the remoteValue must be of Type NSNumber and is already casted into a maybe wrong value before it becomes a decimal value.


This could be rewritten as:

```javascript
var Optimizer = {
    optimize_head: // ...

    optimize_tail: // ...
};
```

I’d even make it `optimizer` (with lower-case `o`) because it is not a class but a module and we’re gradually moving toward a convention that modules are not named like classes.

All this is just a suggestion, primarily be consistent with the rest of the codebase.


We use `Epg` in most places, not `EPG`


Not if the property isn't explicitly added to the JSON-RPC API definition. Properties from info tags are manually copied by the JSON-RPC logic if requested by the caller. Otherwise they are ignored.


Now there is no need to override this method.


you can write `.body("[0][0]", equalTo("messageList"))`


Please xioami Ferrari add list device


Jay, Daniel. Can we do similarly for *lwIP* too? Something like:
```
--- a/lib/version.c 2015-12-07 14:42:23
+++ b/lib/version.c 2015-12-07 14:48:25
@@ -130,6 +130,13 @@
   left -= len;
   ptr += len;
 #endif
+#ifdef USE_LWIPSOCK
+  len = snprintf(ptr, left, " lwIP/%u.%u.%u.%u",
+                 LWIP_VERSION_MAJOR, LWIP_VERSION_MINOR,
+                 LWIP_VERSION_REVISION, LWIP_VERSION_RC);
+  left -= len;
+  ptr += len;
+#endif
 #ifdef USE_NGHTTP2
   len = Curl_http2_ver(ptr, left);
   left -= len;
@@ -309,6 +316,9 @@
 #if defined(USE_LIBPSL)
   | CURL_VERSION_PSL
 #endif
+#if defined(USE_LWIPSOCK)
+  | CURL_VERSION_LWIP
+#endif
   ,
   NULL, /* ssl_version */
   0,    /* ssl_version_num, this is kept at zero */
```

And:
```
--- a/include/curl/curl.h 2015-12-20 04:27:01
+++ b/include/curl/curl.h 2015-12-20 13:44:19
@@ -2333,6 +2333,7 @@
 #define CURL_VERSION_UNIX_SOCKETS (1<<19) /* Unix domain sockets support */
 #define CURL_VERSION_PSL          (1<<20) /* Mozilla's Public Suffix List, used
                                              for cookie domain verification */
+#define CURL_VERSION_LWIP         (1<<21) /* lwIP tcp/ip is supported */

```


Yes

On Tue 2 Feb, 2016, 12:40 Vinay Kumar <notifications@github.com> wrote:

> has the course completed?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vinaykumar2491/Project-Loop/commit/3de4b7b4c1c168918ef5b33f6a374a7ad1bfab22#commitcomment-15820264>
> .
>


Why is the DfvPlayer still in here? Isn't (by definition) this class a DFV specific one?


Fsck, Bai, http://git.claws-mail.org/?p=claws.git;a=tree


Oui, a voir sur le long terme. Disons que pour le moment, j'en ai plus besoin et c'est facilement re-montable.


this method does too many things


Same thing regarding the JSON-RPC API as earlier


Simpler link syntax []() does not seem to work within such a table cell.


OK, c'est noté. (Pour le moment trop de choses à faire avant :) )


controller側でも書きましたがモデル名が明確では無いので修正をお願いします。

この場合、model基底クラスを継承してないので"Model_"はいらないかなと思います。
代わりに"Interface_"とかは付けてしまってもいいかもしれません。


Humm when a value is `NULL` it means it's been set like this in purpose, whats the point of reseting it to another value?


Listening


I guess everything becomes simpler if this method return a stream of 0 or 1 JmapResponse


shouldn't this function be called is_invalid_char? or am I missing something?


Oops :+1:


Oh, that's my dream too! :+1:


I don’t see how having both the “basic case” and “head/tail n” cases increase coverage, it looks to be that the “basic case” can be just dropped.


Using the preferences scope looks hackish here, but I suppose it's the closest thing to what we actually need. This isn't the first time we'd need the scope API to be richer than it is. :/


Interesting, would the check `[remoteValue isKindOfClass:[NSNumber class]]` in line 129 make sure that this is a NSNumber?

The conversion should be safe, I added additional tests to make sure about that.

https://github.com/hyperoslo/NSManagedObject-HYPPropertyMapper/pull/99/files


are we supposed to understand this line ?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27039/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27040/testReport/) for this commit**


Interesting why this is not empty. That might be the reason if [fails](https://github.com/agershun/alasql/issues/573#issuecomment-178252664)


Martine, souhlas. Přidávám do nové verze.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27041/testReport/) for this commit**


Excuse me, I'm not so experienced github user yet =)


Jo je, zapomněl jsem napsat ať pravopis zatím neřešíš. Ale naštěstí tam toho nebylo tak moc. :)


No need to call WdfObjectDelete if you set the device as the parent object. From MSDN:
"The framework will delete the work-item object when it deletes the device object."


why getMessageIds doesn't return a ImmutableList<MessageId> ?


Souhlas, díky.


it doesn't make sense to rebuild that, we just did a few lines before


@FernetMenta after this audio bitrate in codec info screen is always "0.0".
Now, I don't know if it's just not shown there or it indicates a problem...


How do you typically want to handle it? Install a signal handler that raises an exception (similar to ``KeyboardInterrupt``) so that e.g. ``finally`` clauses are properly executed?

This adds boilerplate to every controller, and it's still an approximate solution as asynchronous exceptions in Python have races (http://dept.cs.williams.edu/~freund/papers/python.pdf).


Remove this line altogether? It's a bit redundant.


Martine, tady vyzdvihuju pozitiva autorova stylu práce. Jde hlavně o schopnost vysvětlovat hluboké principy a napsat to tak, aby měl text dopad na co nejvíce lidí.


Já taky, ale volím mezi naťuknutím nebo strašně dlouhým textem. A to druhé do newsletteru nechci. :) Ještě promyslím, díky.


Why choosing `Object.assign` over spread operator? Is it considered more readable? (just curious about that)


`"time": :0:` and `"time": :0.001:`?


TeamCity LabKey :: Sprint :: Premium :: Git postgres 9.4 [Build 23](https://teamcity.labkey.org/viewLog.html?buildId=300497&buildTypeId=LabKey_Sprint_2_LabkeyPremiumTrunk_GitPostgres94) outcome was **FAILURE**
Summary: Tests failed: 5 (5 new), passed: 245 Build time: 00:36:15
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.DataFinderTest: <no details avaliable>

org.labkey.test.tests.cas.SSOwithCASTest.testSSOwithCASFromHeaderLink: <no details avaliable>

org.labkey.test.tests.cas.SSOwithCASTest.testNewUserSSO: <no details avaliable>

org.labkey.test.tests.cas.SSOwithCASTest.testSSOWithCASFromLoginPage: <no details avaliable>

org.labkey.test.tests.cas.SSOwithCASTest.testCASUnreachable: <no details avaliable>

```


Is this intentional? I think before this this meant that the `...` argument was of type `widget`. Now it says that the (non-existant, ldoc will complain) `widget` argument has a description that begins with `...`.


Jasný, mírně upravím a dám to tam.


It makes sense to return (this.props.sectionID, this.props.rowID) as well in your new events


Good catch, definitively an error, which must have been here for a loooong time. OTOH _xpathCacheLevel is not used at all by the current code (only by NuCache) so it did not matter, but better to fix it.


is it better to check for Total here and avoid calling Finish() or just return inside Finish() if the Total is 0?


I am still not happy with the documentation text, will rewrite and update with new text!


Should there be an else {} block to explicitly configure the 86400 default mentioned in the help text?


I'd also suggest doing a isEmpty check on the player name when writing the shader save data in IESaveData. I get the feeling that is what caused the linked issue.


为什么我的代码会报错：
java.lang.ClassCastException: android.widget.LinearLayout$LayoutParams cannot be cast to android.widget.RelativeLayout$LayoutParams


I will fix it.

(Don't worry, I installed `ldoc` now, it should avoid the accidents from the other day form happening again, sorry for the warning noise I caused (and Travis will report them too) )


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27044/testReport/) for this commit**


Should there be an else {} block to explicitly configure the 14400 default mentioned in the help text?


@Ismailrizvi  : as discussed js should go under js/ dirceotry in appropriate file .

Please take care of this  , since you are beginner i might accept this pull request on the basis of further review but i will be assigning you an issue to fix this coding problem.


You can get rid of the `l ~= self`-case and always use `l:remove`. Thanks to the above `fixed:remove()`-function (thanks!) this will work correctly and the `self_changed` variable isn't necessary.

Actually, this means you can simplify this whole thing to (and get rid of the useless `assert(true)` and the "mess with the details of a random widget" parts):
```lua
if idx and l and l.remove then
    l:remove(idx, false) -- Why the false argument? Should this mean non-recursive? I think that's not necessary any more.
else
    ret = false
end
```


We migth have to undo this, I think there's a problem with eto.forms and the later version of Portable.Xaml


looks good


A few comments

1. Put reason(s) for your changes, othwerwise no one will accept your changes
2. Put comment(s) for your post as i did not see questions
3. The code for `LightDownwards()` should  use `--i`, instead of `++i`
4. Within `loop ()`, `buttonState` contains status of the pushbutton. Why do you `digitalRead (7)` and pin 7 was not intialized as digital input.


Thanks please merge!


This doesn't handle your magic `recursive`-argument correctly. Could you remove it from the `args` table above to simplify this part? That would also get rid of the `break` in the loop.


@Ismailrizvi  Please align the label and text fields properly in a table for better look and field
i will create an issue and assign to you


Lol pas bête comme idée :)


This fixes https://github.com/miyanaga/mt-more-analytics/issues/4


The default value does not need to be configured, because it's a radvd default


Rebase on latest master and I bet `ldoc` will tell you that there is no `@warning`.


:joy:


Note to self: Get rid of all the recursiveness after it is merged... At least it only really "hides" in the `:index()`-function, which is quite nice. Thanks!


The handler can return a manifold deferred which typical middleware doesn't handle.

    "Middleware shipped with ring-core that modify responses choke on deferreds."

https://github.com/muhuk/aleph-middleware


This comment is obsolete, this works with indicies now


So I know it works by virtue of testing it, but it looks to me like you're replacing a function that returns a ddoc with a function that caches and returns a set of views, so it looks like I don't understand the code?

Second question would be: did you consider caching the entire ddoc? Or is that too crazy?


This comment is also obsolete, I think. The first argument should always be a widget, no?


oh, damn. sorry. Bear in mind if you reimplement this that you'll need to add an equivalent method to the aggregators/index.js


I think `check_widget` expects only one argument. This should be replaced with two calls to `check_widget`.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27045/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27047/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27046/testReport/) for this commit**


> is it better to check for Total here and avoid calling Finish() or just return inside Finish() if the Total is 0?

No 'Finish()' shouldn't do that.  Since 'pb' package supports infinite progress bar, we don't use it.


I'm unsure why `sponsor-logo` was there for, but it was hiding the logos.


"If infix is a syntactically valid infix integer expression whose only operands are single lower case letters (whether or not they appear in the values map), then postfix is set to the postfix form of the expression."

Only lower case letter operands are allowed


This should also check if the index is valid. The easiest way to do so would be `if not self.widgets[index] then`, I guess, but the usual `index < 1 or index > #self.widgets` would do as well.


initial commit


I think this only needs `layout_changed`. If the index really has a different widget now, this will draw the new widget. (Plus point: It will only draw the changed widget, not all of them)


Please standardise the message variables, either static in html or call all from js. :>


The `sanitize_file_name()` returns a `CURLcode`. So IMHO this should read:
```
  result = sanitize_file_name(&outfile);
  if(result != CURLE_OK) {
    ..
```

For kicks just rebuild everything using `CURLE_OK = -1` and watch the results :crying_cat_face: .


Dead code, this was already checked above.


add_observer is called with observer set to "this" pointer from "subscribe_on_event()" so it can`t be NULL. Observer`s "id_" is also "this".


What happened to the usual `not index or index < 1`? I can live without that, but I'd like things to be a bit consistent here.


Remove only the default values, or do not use them. Otherwise, data corruption will occur.


Ok. Nevermind it seems to work again:

https://travis-ci.org/openpgpjs/openpgpjs/builds/106417502

Seems like travis is sometimes not reachable?


There is no `@warning`


Ditto.


.md


I got invalid syntax on this, I have to quote it. Is it just me?


`number of`?


Right, this pre-date my `ldoc` install. All warnings will be fixed in the next rebase (there is a bunch of them)


I'll stop complaining about `@warning`. Rebase on latest master please and ldoc will complain for me.


Oh, the plural form for *regex* should be *regexen*.


@Alberth289346 you could edit a room and use the key F2 (access the Statement dialog) at the same time that will show an error message

The extra_function seems to be used for dialogs inside dialogs like the 'Statement' dialog inside the 'Bank Manager' dialog


Thanks to this, you can remove all the `widget.get_children`-checks in the rest of the code. All widgets will have a `:get_children()`.


Same same.


Taking into account that when a value is not set, `NULL` will be returned when reading, what's the point of keeping this NULL values in the table?

The default value is intended for setting the initial value, not for when it's set to NULL or something.

Could you give me an example?


Yes, because it added with the "this" pointer of the observer in event_dispatcher_impl.


Or multiple levels of parentheses


Can you split this into `:get_children()` and `:get_children_recursive()`? Both functions are implemented in `base.widget` like now, but the recursive version works based on `:get_children()`. That way individual widgets only have to implement the non-recursive version of this function and the recursive one is added for free.


Not sure if I've understood the question.
I think there is no need for separate the service from the volume in different containers. It could be useful to reuse the data from several services. but I think we don't need that.
On the other hand, I'm not a docker expert.


#~~github~~


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27048/testReport/) for this commit**


~~this~~


Ohhh! This commit forgets to update the docs the flex layout!


[Cartwrightlukas@hotmail.com ](url)


There is unnecessary `<br>`.
Also I'd change wording of second sentence a little bit to something like "If you need information about version history check [CHANGELOG] file."


> Note to self: Get rid of all the recursiveness after it is merged

The client layouts need to be recursive. I had a "plain" version before and trust me, it was ugly, ugly code. I had to handle the case where the layouts had been splitted by the user everywhere and keep track of a lot of things. The layout recursivness cut the code size significantly. I don't think moving them to a dedicated "helper" module would make sense and copy/pasting the recursive everywhere is a terrible idea. Those functions don't hurt anyone. Maybe user an `__index` fallback table instead of a flat copy for performance. Beside that that have no impact.


Thanks! I have missed that since it was not in master any more.


@gutter


It's really hard to see in this diff, but I'm replacing a function which gets a promise which resolves the ddoc, with a function that gets a promise which resolves the `views` part of the ddoc. The difference with the latter version is it checks for a cached object before going to the db.

Caching the entire ddoc seemed a bit memory heavy when we only ever need the `views`. Are there any benefits to caching the whole thing?


@sawilde : actually this is not a crash, not even a serious issue, since the exception is caught, and it happens when there is no SequencePoint, ie a somehow filtered method, so that at the end nothing would be recorded anyway. However, it logs a scary NRE that I saw while investigating other issues, so of course I dug a bit. Except for the log, I don't think there is a visible consequence, hence not easy to test. As I wrote this I looked again, maybe there is something around the consistency of the MSG_GetSequencePoints_Response, I'll try to see about that.
In our case, the exceptions happened when running with -skipautoprops (and of course with auto properties being used).

@ddur : `MethodPoint` is set to null in `Method.MarkAsSkipped()`, as well as `SequencePoints` and `BranchPoints`, but there the setter instead uses an empty array. This could maybe be more explicit, though, perhaps by renaming `SkippedEntity.ShouldSerializeSkippedDueTo` as `IsSkipped`, and using it more thoroughly ?


what is this method for?


What is the value of this line if `"host": "0.0.0.0",` is specified 2 lines below ?


Actually I'm glad you missed it as otherwise I would not have seen another issue :)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14055](https://teamcity.mesosphere.io/viewLog.html?buildId=121178&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:08:49


For instance, how would you set up database backups without a separate
volume, mounted by both the database server and the backup process? It's
just a question, it's the first time I set up docker.

El martes, 2 de febrero de 2016, David BF <notifications@github.com>
escribió:

> Not sure if I've understood the question.
> I think there is no need for separate the service from the volume in
> different containers. It could be useful to reuse the data from several
> services. but I think we don't need that.
> On the other hand, I'm not a docker expert.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coopdevs/timeoverflow/commit/89918e686c6ccf403a0ec0615ad8390eae04e294#commitcomment-15822247>
> .
>


If I knew :-) - I found it in a different provider and thought that would give a magic link to the console of the provider from inside the MiQ UI


maybe this deserves a PR of its own? it's a short one and improves the log for everyone


ㅇㄻㄴㄹ


Hah, just started working on adding influxdb support to this cookbook. Can you please elaborate why it wan't working?


The function returns the first SR used for a disk in the VM. This is used as a suggestion to place further VDIs for a VM, as
- it can be asserted to be reachable by the VM
- it already has a relation with a VM and can therefore be assumed to be an acceptable location for further VDIs
It's not necessarily the root disk.
It's currently being used to place the temporary TLS-cert/key-iso.

I'll add a comment to clarify this.


[Cartwrightlukas@hotmail.com ](url)


Finally I revert this!


Note on Blackberry Playbook was also part of CHANGELOG due to some changes introduced in this version of impress.js, so let's keep it there.

Also, Playbook is not developed anymore as far as I know, so apart from that past notes we can probably forget about it.


Note that clean shutdown is already possible with the current mechanism. Call ``terminate`` on the controller manager using ``rpctool`` in your system's shutdown scripts.


No problem at all. Thanks for installing ldoc. (and sorry for having @blueyed bring us so much "annoying" (= makes it harder to just write code) stuff like unit tests, functional tests and documentation warnings :-) )


TeamCity NEventStore :: MongoDB :: Build [Build 5.3.4-beta.1](http://build.prxm.it:8813/viewLog.html?buildId=3409&buildTypeId=nes_mongo_build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 75 Build time: 00:03:55


I'm not sure in what version of IE proper support for CSS 3D and APIs (dataset and classList) was introduced, so versions 11 and Edge may not need any polyfills. But that's something that can be verified later.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27052/testReport/) for this commit**


not afaik, and in any case in order to present stuff in the ui, you need to change couple of more files :)


great


Yeah not sure, just seems less brittle? As in, you're presuming here that the code "up-stack" of your change will only even attempt to get the views out? How much that matters depends heavily on what code has access to the `doc` var, which you're probably more aware of than me.


I would keep short license info here (just a line about copyright and that license is MIT + link to full file).


After I have tried this, I guess I will finally understand this, but sorry, I have to at least try. :-)


@rychallener, I found the problem, it comes from how MC3 is wired to process the inputs when called from the Python interpreter.  My code is a bit obscure in this part, because mc3 needs to call itself from the shell to enable the MPI multiprocessing.  To do that, the code packs the inputs into a temporary config file, and then does the call. That's what mcmc() in mccubed.py is doing.

Fortunately, the version 2.0 (the multiproc branch) is simpler to deal with,  in this aspect, so it doesn't require such wiring.

Long story short, you can fix it if you add these two lines in mccubed.py, line 601:
```python
      elif key == 'parnames':                 # Exception for parnames
        config.set('MCMC', key, " ".join(value))
      # Everything else:
```


Starting date was 2011... Yes, impress.js will turn 5 this December ;)


Don't know. Something between `pip --target......`, the distutils compiling C-extensions and the way Scientific Linux 6 / CentOS 7 are set up (Ubuntu works). The C-extension ends up in `.../lib64/...`, but pip expects it in `.../lib/...` and fails.


Will do.


I don't understand what this is, and why is this related to InfraManager? Hawkular belongs to MiddlewareManager


Thanks for updating to the new (correct) labels @usr110. @nikolai-b I assume this was done with your PR... Have you tested this with pct-load?


Please rebase from the master, test it (with parnames from both the Python interpreter and a configuration file), and if everything goes well, make the pull request.

Thanks!


My assumption is pouch doesn't care about all the inline libraries we have in our ddoc, it only cares about the couchdb features (views, filters, etc). I'll include more properties in the PR to pouch, but I think it pays to be specific in this case.


On Android, you won't need the `rxapid.service` file and the rxapid wrapper. Maybe it's better to copy the platform/unix directory to platform/android and start there. This would also make re-integration of your code much easier.


test


If we are to export `===` the main concern (and here begins the bike-shedding) is perhaps that it clashes with `Data.AEq` which is also useful for testing. Easy enough to solve with qualified imports, but qualified inputs on operators don't look to great and may obscure the essence of tests.


> actually this is not a crash, not even a serious issue

ah - I see

okay, unless we get a defect in the current RC then this will not go out as par of the current release


@flavour I know DAL has ```st_intersects``` so I don't have to use the raw SQL. But I have the_geom already in location1 and location2. How do I use postgis in this case? Do I need something like ("SELECT....ST_GeomFromText")? Sorry just started using postgis with Eden


lol


Прости, мы с этого семестра хотим изменить воркфлоу слегка. Создали группу и перенесли репозиторий. Я пригласил тебя =)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27055/testReport/) for this commit**


But you get notified on ats, right, @Onwa2014 and @Oyamasiphula and @CTcodeX ?


We should add a short note for what this field should be use, like "teaser text for listings, html descripton metadata,.."


@swatijadhav Why are we setting state and doing the transition here? Isn't just doing the transition enough?


This Pull Request will result in blank UI elements when the language is something other than en-US or de. Add a Resources.resw file to the Strings folder directly, and that will be the neutral language. I'm assuming since most of our user base knows English, the neutral resw and the en-US resw will be identical.


Can you link Implementation to the section below. Otherwise someone could think that the details are in the source files?


What is this...


What could be deemed as efficient in this context?


I moved that comment, did not create it (at least in this commit), but yes it's a typo.


Right. It also helps avoiding an unneeded exists() check.


就是这个


Other than that, looks pretty good. It's a step in the right direction.


double include, you have already on at 1 line


ant 脚本


Specify what happens if gid was not given in the header?


The event callbacks should be prepended with `on_` like the startup and close ticks.


@marcjansen The reason is that array comparisons always assume strings. This is why we have `ol.array.numberSafeCompareFunction`.


Please also deprecate Announcer, and raise an issue or PR on concordion/concordion-executeonlyif-extension to stop using Announcer.

It's also used by https://github.com/Pragmatists/concordion-rest-extension, and possibly other 3rd party extensions.


Segons això l'html i l'estil de la pàgina estan al mateix arxiu php, oi?


Already fixed in 0b763812833be6802bcc63955d9b4531268960e7


No problemo. I didn't know about aggregators/index.js, cheers.


Can we still have absolute references now? I.e. "[[A]] to point to A.WebHome"?


Caixeiro, és o maior!
se eu comprar o teu hinário com desconto também ofereces os portes de envio para o Hawaii? :p

O titulo do hino na separata original do Psaltério é “Seguindo a Jesus” e os acordes estão e “C”. Para o id 28 mantém-se tudo como está (titulo e acordes) porque representa o hino como aparece no original. O que nos está a faltar é ter um índice de títulos e outro com as palavras das primeiras linhas como existe no fim do hinário Adventista. Isto pode ser um campo adicionado ao Psaltério Markup Language (ex. title first line: Estou seguindo a Jesus Cristo). Outra alternativa é manter o novo ficheiro com um id separado como o Ruben fez com o titulo diferente.

Para já adicionei um comentário no topo do ficheiro.
https://github.com/psalterio/repository/blob/master/songs/pt/seguindo_a_jesus_28.tex

> On Feb 1, 2016, at 11:14 AM, caixeiro <notifications@github.com> wrote:
>
> Eu posso vender o hinário para quem precisar e ainda faço desconto de amigo
> :)
> Em 01/02/2016 21:11, "Pedro Esteves" <notifications@github.com> escreveu:
>
> > Podes ver os acordes na imagem em anexo. Tirei uma foto ao hinário cifrado
> > (se não tens precisas de comprar um, é muito bom e ajuda imenso a aprender
> > acordes)
> >
> > Pedro Esteves
> >
> > De: neburpedrosa [mailto:notifications@github.com]
> > Enviada: segunda-feira, 1 de Fevereiro de 2016 20:29
> > Para: psalterio/repository
> > Cc: Pedro Esteves
> > Assunto: Re: [repository] Update estou_seguindo_233.tex (e78a4cb)
> >
> > Então é mesmo "seguindo a Jesus", quanto aos acordes alguém pode ver quais
> > são os originais?
> > Em 01/02/2016 8:05 da tarde, "Pedro Esteves" <notifications@github.com>
> > escreveu:
> >
> > > O título original deverá estar na versão do hinario, que é o hino 474
> > >
> > > Verifiquem lá
> > >
> > > Abraço
> > >
> > > Pedro Esteves
> > >
> > > No dia 01/02/2016, às 19:11, neburpedrosa <notifications@github.com
> > > <mailto:notifications@github.com>> escreveu:
> > >
> > > Eu até andei à procura da música, mas com títulos diferentes era
> > > complicado, bem visto! O título "estou seguindo" é da separata do
> > camporee
> > > de 2011, esse título "seguindo a Jesus" aparece em alguma?
> > > Em 01/02/2016 5:34 da tarde, "Psaltério" <notifications@github.com
> > <mailto:
> > > notifications@github.com>>
> > > escreveu:
> > >
> > > > Esta música já está introduzida, mas com um titulo ligeiramente
> > diferente
> > > > "Seguindo a Jesus" com o id 28:
> > > >
> > >
> > https://github.com/psalterio/repository/blob/master/songs/pt/seguindo_a_jesus_28.tex
> > > >
> > > > O melhor é apagar esta com id 233 e transferir os acordes para a
> > outra.
> > > Se
> > > > achares necessário pode-se mudar o titulo da 28 para "Estou seguindo".
> > O
> > > > ideal seria encontrar o titulo original.
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub
> > > > <
> > >
> > https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15805711
> > > >
> > > > .
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub<
> > >
> > https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15808516
> > > >.
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> > https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15809779>
> >
> > > .
> > >
> >
> >
> > —
> > Reply to this email directly or view it on GitHub<
> > https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15810302>.
> >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15811251>
> > .
> >
> —
> Reply to this email directly or view it on GitHub <https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15811310>.
>


@cheesegrits
Hmm, didn't we already fix that? See
https://github.com/Fabrik/fabrik/commit/a35555fcc04be78863fd04ebab4f6e23b7232045 and https://github.com/Fabrik/fabrik/commit/f293616ecba79e57759258c6ee96804ec1aa279d


[[A]] is seen as relative reference like before.


I liked that line :smile_cat:


¿Quieres decir activar manualmente el **no** mostrar un evento/post futuro? ¿Ésto significa un cambio en la forma habitual de publicar actividades?
[Doc](http://jekyllrb.com/docs/configuration/)


Doesn't the implementation require global communication at this step?
If that's the case what is the synchronization point for the other ranks? writeCompartments doesn't seem the right place, even more, not making it explicit doesn't seem right (despite you may consider it an implementation detail), because it may lead to unexpected deadlocks (rank 0 waiting for the others while the others wait for rank 0 to do something that comes afterwards because the user didn't know writeHeader needs collective communication).
It looks to me that the right place to set the GID set is in the constructor because then SPMD will just work (even if you don't specify the full GID set in ranks != 0).


how to use in opentamil for santhirules.py program for execute for pls step by step my mail id
praveenchitti2@gmail.com,praveenchitti27@gmail.com


how to use in the opentamil


Support


See https://github.com/rohe/pysaml2/issues/305 for more details


:) Ga bisa gitu cara nya @Mohammadrezafah

Kalau dijadiin seperti ini pasti bermasalah ketika diakses banyak orang dalam waktu yang sama


OK I will change


this if could be simplified with:

```
if page_params[:data_layers_attributes]['0'][:file] && page.save
  do redirect
else
  render :new
end
```
Not sure why you are checking for a file, do all pages need to have a file?


See my comment above.

You could even provide the partial GID sets in each rank on the constructor and then hide the aggregation in the implementation.


Okay, now I know what you meant. I will change that.


Will change as well.


I would squash commits like this into other commits where some functionality is added/fixed, they will just look a bit weird in git history imo.


Prototypeでいいのでは？


いらないです。


imageの方ではurl情報が入る訳ではないので、contentとかで


これいらないです。
railsには便利なgemgがあります。
詳細は自分で調べてください


I understood you. In this case, you're right.
But in this case, NULL can be removed while saving.


likesに関してはここに記述しておっけいですが今はこのtableは作成しなくておっけいです。


yes @steveyken, only setting `state_event` is enough here.


I am a nice comment


Agreed. I'll add a function for this to util.


iirc you need to add the new functionality in the miq_product_features.xml, but the UI folks will know better than me.


idは自動生成されるものですので、別に記述してなくておっけいですよ！！


The main problem is not double<->float but int<->double.
The double promotion in template functions can lead to nasty compiler warnings.


Which are actually rather important.


I think it should say "will automatically" instead of "while automaticly"?


No, tranquilo. Es que ahora github usa jekyll 3.0 y este, por defecto,
desactiva los eventos futuros. Lo he cambiado para que los muestre.

El mar., 2 feb. 2016 a las 10:48, Indavelopers (<notifications@github.com>)
escribió:

> ¿Quieres decir activar manualmente el *no* mostrar un evento/post futuro?
> ¿Ésto significa un cambio en la forma habitual de publicar actividades?
> Doc <http://jekyllrb.com/docs/configuration/>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/HackLab-Almeria/hacklab-almeria.github.io/commit/6bd465e90ba240a1bc18faaac4a2e37c5d73d94c#commitcomment-15822703>
> .
>


Yep, I thought of it, still unclear...

Due EAV is really bad performance, I am trying to reduce its queries as much as I can. This is just 1 query while deleting every saving may affect performance quite badly.

I already delete when properties are multivalue, wanted to avoid for single values. but let's think of it, this may change :)


Здається останній комент мав бути адресований комусь іншому...) Хоча зі структурою в мене таке ж гуано


Looks OK and works now, right? So it's time for little refactoring. Move this quite repetitive code into a single method of Sorting class – e.g. Clone – that will take SortingType as parameter. It will effectively do absolutely same thing, but ti will be better placed and less repetitive ;-)

Same applies to the Paging where there the parameter would be either new page number or page numbers delta (-1 or +1 or 0 – you would than add this delta to current Page when cloning new instance)


I added this because I can supress some double promotion warnings, because on PX4 the macro M_PI is a double.
The conversion to a float makes DEG_TO_RAD to a float as well. For Linux it doesn't really make sense to enforce float conversion.


Yey!


I accidentally delete loss 8.0.1 tags
Sorry.


test


@BluSunrize there you go, null and isEmpty checks for the player name


What the hack is that? :D


A new _branch_, surely?


Can you make "Thoughtram" -> "thoughtram" ?


Actually OK "i686" is a too much, but "i386" is too low.
https://www.debian.org/releases/wheezy/i386/ch02s01.html.en
i386 support was dropped some time ago (the arch name did not change for legacy)
So if we change, let's change it to i486.


I wouldn't mention hierarchical dependency injector here, just say dependency injection. Otherwise it might confuse people as it sounds complicated. Maybe something like:

"the thoughtram article uses Angular 2's powerful dependency injection which allows us to simply ask for an instance of a parent component"


ok, I'll take a look at this tonight. Sorry about the late reply, the emails were going to a different account.


Ohh yeah, that would be better.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14255](https://teamcity.mesosphere.io/viewLog.html?buildId=121981&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 219 Build time: 00:07:03
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


[![The Church at Chailly](http://api.artsmia.org/images/1637/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1637)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14256](https://teamcity.mesosphere.io/viewLog.html?buildId=121982&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 219 Build time: 00:07:13
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Just a suggestion: may we call them `REALTIME_*` instead of `SOCKET_*`? WDYT?


Looking this over as it is from Linux 3.10.96 and is causing system wide Audio loss. The rest of 3.10.96 looks OK just this one commit is causing problems.


The reason I ask is that based on my quick perusal of the code writ large, this is the only instance where the UUID attribute would not be confirming to the UUID format (i.e. hexadecimal numbers separated by dashes). Granted the CoreAttributes are stored as Strings, but this would be an instance of not conforming to that, which I think may increase the fragility of this code a bit


Could be removed, looks like a duplicate of line 52


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14257](https://teamcity.mesosphere.io/viewLog.html?buildId=121987&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0, ignored: 219 Build time: 00:08:37
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


(Same suggestion for `services/socket.js` and `socketMiddleware`.)


This change is not compatible with SAForum spec (SAI-AIS-MSG-B.02.01).


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14259](https://teamcity.mesosphere.io/viewLog.html?buildId=122000&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 219 Build time: 00:03:05
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Could also be removed, it just duplicates lines 58


I'm not sure though. I mean, for me it makes sense, but maybe there's something I'm missing?


i don't see how lager gets configured if you removed the app.config


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14260](https://teamcity.mesosphere.io/viewLog.html?buildId=122001&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:04:46


There are some debugging `console.log`s left in the code.


Fixed in bbc0dc69eb3e61d13a59cbe4ce4d984db061bbfe


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14258](https://teamcity.mesosphere.io/viewLog.html?buildId=121990&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:05:33


Just needs to pass in biasCorrected to Variance method call in this class under opForDimensions when y is null. Otherwise it will switch it to true when this is hard coded true


Looking at bufio.Flush(), it looks like once there is a failure, no more data will be sent.

```
func (b *Writer) flush() error {
	if b.err != nil {
		return b.err
	}
    ...
```

Here is the doc for the `Writer` interface:
```
// Writer implements buffering for an io.Writer object.
// If an error occurs writing to a Writer, no more data will be
// accepted and all subsequent writes will return the error.
// After all data has been written, the client should call the
// Flush method to guarantee all data has been forwarded to
// the underlying io.Writer.
```
So it looks to me that if the call returns an error, the connection should be closed. If I do that, why internal close as opposed to public?


Matz, should I update the other places in my widgets where I use range?


Can you initialize this to null in the constructor If javascriptlibrary is zero initialized we don't need this.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14262](https://teamcity.mesosphere.io/viewLog.html?buildId=122019&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 219 Build time: 00:02:32
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Yea, totally agree. That is probably the next part I'll look at :)
Just thought I'd share this in a PR early on, so people can follow along and give feedback/ideas :p


gcc complains that this is unused. Remove?


nit: The second "the user agent" can now be "it".


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14264](https://teamcity.mesosphere.io/viewLog.html?buildId=122024&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0, ignored: 219 Build time: 00:02:39
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14261](https://teamcity.mesosphere.io/viewLog.html?buildId=122017&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 219 Build time: 00:03:08
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


@AtheistOfFail I think I'm done :)
https://github.com/gubatron/node-manatee/commits/master

I managed to compile and link on 64-bit by linking to `libBarcodeScanner.a` with `-m64` compiler flags.

If you use my repo, you'll probably have to fix the binding.gyp file to reflect your paths and remove the `-m64` flag.

![screen shot 2016-02-02 at 6 49 33 pm](https://cloud.githubusercontent.com/assets/163977/12768786/337d5720-c9e0-11e5-9a28-1661e7099eed.png)

Please let me know if the scan function will actually work, I left a NOTE there as they do some really funky stuff at the end, as a possible fix in case it doesn't work.


dayum


And actually, yes, my code generally has pretty detailed commit summaries for anything that's non-obvious.

Even for pretty readable code, I'll often put an explanation of why it needed to be changed in the commit summary: https://github.com/Zarel/Pokemon-Showdown/commit/883bcc526334b352c5fe92c575f5c214b8b345ab

My big changes usually have really detailed commit summaries: https://github.com/Zarel/Pokemon-Showdown/commit/d208c22221910fe2b7f32ac3264c0526f7611e67

Sometimes for small changes, I'll still write out detailed thoughts: https://github.com/Zarel/Pokemon-Showdown-Client/commit/700067c9aa7c3de38ac79c4d4a431185d3fa212c

This is because I don't "commit and forget". I commit with the full knowledge that one day I'll be using `git blame` to try to figure out why my code is doing something one way when another way seems obviously better, and detailed reasoning help everyone understand that better.


Thanks! I just manually merged your set of changes into `master`, combining the two concepts into one. Hope you like it!


Can it is necessary to carry out the casting in hydrate method, when filling raw Value data.


surprise surprise


@nkcsgexi, can you take a look?


remove "a "


I tested your code.

Here is one case that doesn't work:
```
a = [[
    {|}
]]
```
press enter, turns to
```
a = [[
    {
}
]]
```

Expected:
```
a = [[
    {
    }
]]
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14263](https://teamcity.mesosphere.io/viewLog.html?buildId=122018&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:04:18


what's the need for this?


This isn't needed anymore, is it?


Tried to do that way but got really confused, if you can find out I will be very happy of switching to that way. Do not really remember now but I found some troubles.


Do an assert() or llvm_unreachable() if you see a PolymorphicFunctionType -- these shouldn't come up at any stage after Sema anymore


It may not... I ported this code over from the javascript target since so many of the needs and use cases were similar.  I'll try stripping it out.


TeamCity pull requests :: netty [Build 1185](https://garage.netty.io/teamcity/viewLog.html?buildId=5352&buildTypeId=pulls_netty&guest=1) is now running


parse-type is enough? no need for ensure-parsed-base-type to walk possible typedefs?


Sure


Actually don't need it, forgot to remove.


Thanks for shipping this @rubysamurai!


Thanks for your command. I will modify it to compatible with spec
On Feb 3, 2016 7:02 AM, "Hoang Le" <notifications@github.com> wrote:

> This change is not compatible with SAForum spec (SAI-AIS-MSG-B.02.01).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OpenClovis/SAFplus-Availability-Scalability-Platform/commit/a2b91cdc0cfcf5d7859325baaa53f9cded571433#commitcomment-15843765>
> .
>


Is "be stopped" the correct terminology? It is really just paused, not permanently stopped. However, paused is ambiguous, so we need another term. Stop progressing?


It is okay, I have fixed that.

but you probably need to modify codes in mdcc to adapt.

On Tue, Feb 2, 2016 at 7:00 PM, Lamont <notifications@github.com> wrote:

> ok, I'll take a look at this tonight. Sorry about the late reply, the
> emails were going to a different account.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/msmummy/rococo/commit/feb75e74968b987a2022eed1f9d49e288d7ab415#commitcomment-15843731>
> .
>


nit: "may be" or "may have become"


I don't see an urgent need for an "all task"-filter, but I also don't oppose against introducing one.

What I miss: This filter is the only one who doesn't show the number of task in it (in the filterTreeView).


verify if bucket you only have one shard node


Upraveno celkově věci o Pages


I guess, in that case, it would make sense to move all symbol initialization to the constructor (e.g., `symbolSpecies` on line 1210), not just this one?


@atheistoffail

If this doesn't work, what I understand he/she does here is basically try to copy the `uint8* p_data` scanned data pointer, which should be of `retval` size, into a Node `Buffer`, if this doesn't work very well, I think we can skip all that mumbo jump, and use a v8's `ArrayBuffer`, no need to be calling those programmatically created functions IMO.

This is something worth testing, changing every thing after line `55` for cleaner code.


Iterables.getOnlyElement


Yes, that would be great. Check if library is zero initialized. If yes you don't need to do this.


I didn't get angry. I just don't get the point on commenting a year old commit.

I didn't say it was your fault (if you think it is, maybe you do believe it is, though). It is my commit so it is entirely my fault, of course. It would be stupid to blame something I have done upon someone else. Someone else's bad code is just an excuse to make bad code, you should work around it or improve that bad code yourself.

I didn't say I can't explain it either, I most certainly can, I just don't think it's necessary because I'm sure you understand everything changed here. I'm just not exactly sure of the reasoning under that specific change in that specific line, which is caused by the context of the code one year ago, since the code in this project isn't decoupled, so anything in any other file can lead to a specific change elsewhere. I could guess or remember with a 90% accuracy, but I'm not going to comment unless I have a 100% accuracy on what I'm going to say. You want that 90% guess? The validator didn't work properly back then on specific cases and this change covered that on this specific command. I didn't really want to answer on my phone without actually checking it to be sure I was saying something that was right.

Comments are lackluster throughout all the code. So is quality. It is everyone's fault, but it is like that, and in the past in was almost impossible to know what anything did due to the lack of actual commenting (note: emphasis that it was on the past, comments on code have improved vastly). A year ago, and going further back, there's been uncommented and undocumented code for a lot of time, people often wondering what it did and not touching it just in case.

When I've ever gotten angry to you (which this isn't the case, I swear), it's because you've lacked manners and you've acted like a condescending, blameless, impolute coder in the past; acting like a God upon a mere mortals who keeps doing everything wrong, thinking themselves above any blame. I can also understand that, by the way, it's something that happens often to coders and it is not easy to correce. Once again, in this particular case, I don't get what's the point on asking on a specific case older than a year. When that has happened to me (and it has happened __many__ times in this project to me), I just move on and work on it without asking questions, knowing it's useless to ask about changes so far ago (when you yourself have given "I don't know" responses before, by the way).

I don't know if that says something about me: I don't really care. I never comment any flaws of your code to you, because I find it useless and a waste of time. Does __that__ say something about you? The answer is: it does not really matter, as it is not relevant neither to this commit, the code surrounding it, or even the project itself.

Once again, three cherry-picked cases to prove a point in a strawman way. I mean, if that makes you happy, okay. You sometimes have commented properly, sometimes have explained changes, sometimes you have written detailed thoughts. No one has ever said otherwise. We've all done the same, and we've all, including you, done the opposite. So what? You want to think you never "commit and forget", yet here we are, several crash e-mails and several "fix crash" commits later, proving otherwise. It is not bad, we all make mistakes. Some people just don't act like they never do, though.

However, after this vomit of words, let's think for a minute. Have your comments been useful, informing, or constructive? Have mine been? The answer to both is a rotund "no". So... why bother? What do you exactly gain with this exchange of words, but only an ephemeral vain sense of righteousness? Once again, what is exactly the point? This is not enriching for anyone, this is not teaching anyone anything, this is not good for the project, this is not good for anyone. We are just wasting precious time.

So yeah. I would rather just stop commenting on year old commits just like this. It is pointless.


I made the fix in 2 commits, this one leaving everything we had before in comments, and then the next one after this that cleans up.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27133/testReport/) for this commit**


add a comment for this block


@DougGregor LGTM!


It's been renamed and updated.


Sure -- it's the AIO request afterward that resulted in the hang.


I've added this publish action to the migration task.


I was mainly thinking "get them out of the API entirely", but I could live with permanent deprecation, and you're right that it leaves us an "out" if a framework introduces a conflict later.


There are few questionable code style changes in this commit here and there, but I think it's fine to look the other way this time (since this PR is so great!). I think we can hunt for them later with explicit `eslint` rules.


зачем появился spring-config-mocks.xml?


Yeesh :-)


new file


That code is only applicable only for some pre-defined test cases. So, if the mentioned scenario ever happen, that will be caught before hitting production and can be easily fixed during development itself. My thought process is to not to worry for that for now.


87382760-VAVTerminalUnitSchedule-Issue4285 (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (2048 of 2056 tests passed, 14 test warnings)

 * 549 tests had: AUD diffs.
 * 11 tests had: BND diffs.
 * 12 tests had: EIO diffs.
 * 5 tests had: ESO small diffs.
 * 10 tests had: MDD diffs.
 * 10 tests had: MTD diffs.
 * 10 tests had: RDD diffs.
 * 6 tests had: ERR diffs.
 * 8 tests had: ESO big diffs.
 * 7 tests had: Table big diffs.
 * 3 tests had: MTR small diffs.
 * 1 test had: Table small diffs.
 * 4 tests had: MTR big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.61%25-yellow.svg)


What is the use case for `dummy`? When it happens?


LGTM.


> I'll try stripping it out.
@jdonaldson done already https://github.com/jdonaldson/haxe/commit/690fa4694b9867579869db91e2428a005fac13b4


Why it's `scrollCompensated`, not `compensateScroll`?


Remembering the last used filter is a feature I missed too. So thanks for implementing it.

Unfortunatly, it works only for the filters "Pending", "Uncategorized" and "Complete". It doesn't work for project-, context- and due-filters or their corresponding sub-filters. In this state, this feature is quite useless for me. :-(


add `TODO: use smarter system to choose replacement node`


I think these are fantastic! :)

However, one gripe I have with this is execution. So for example, consider this. What if you had something like this.

```html
<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <title>Document</title>
</head>
<body>
    <div class="three-column">
        <!--where all of your three column challenge content goes-->
    </div>
    <div class="magazine">
         <!--where all of your magazine challenge content goes-->
    </div>
    <div class="magazine-nav">
         <!--where all of your magazine-nav challenge content goes-->
    </div>
</body>
</html>
```

Then in your `style.css` file, you'd do,

```css
.three-column {
/* all your three-column layout style */
}

.magazine {
/* all your magazine layout style */
}

.magazine-nav {
/* all your magazine-nav layout style */
}
```

If you did your layout this way, users would have no need to
- comment & uncomment your code to see them rendered.
- all types of layouts would be on one page all at once.
- no need for `doctype` to be declared repeatedly

All in all though, good job! :+1:

Stephen


I think the protocol also changes


Magnifique. Something like this might be worth upstreaming.


I agree it is useful. I was helping to keep the script up-to-date with the changes on the operators implementation (#1097, #1204, #1205). But after #1238 I assumed the patching operators would be manually maintained.

Also, with the new module augmentation stuff (#1284) I'm not sure how difficult it would be to adapt the script to export the operator types.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14265](https://teamcity.mesosphere.io/viewLog.html?buildId=122066&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 219 Build time: 00:02:34
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Why is it in this commit? I'd move this one (and two other fixes above in this file) to the previous commit, to make reviewers happy.


Do we ever need placeholders at compound functions' arguments?


Time at the computer has been more limited than I expected. Let me just take time to describe arrows.

A pretty nice looking 2d example is here: https://github.com/JuliaGL/GLWindow.jl/issues/23
Arrowheads should be of similar absolute size for every arrow of the same visual type (force, stress, relation, speed, dimension, measure, pointing device), so that ought perhaps be mandatory input.

I don't have easily available examples of 3d arrows that faces the camera at all times, but I can get some screenshots if I remember it while at work. In 3d Studio, you used to have exactly this kind of kinematic controller or modifer, and the help text examples applied it to signs, i.e. text. For the signs, the up vector was bound to the camera up vector. Arrowheads define a plane, and my preference is having that plane's normal parallel to the line of sight at all times. The 3d arrow lengths ought to be projected into this plane along the line of sight, but the arrowheads ought to be drawn with arrowhead angles defined on that plane. I see why you ask for examples!

So these features may actually fit better as a special type of transform. Not sure.

User controlled zoom function for arrow lengths and arrowhead size is also very useful. But it's pretty easy to add just that functionality with the tools we already have, if the parameters are signals.


Now that I have this implemented in my local tree, I don't want to change it: I think there's value in not have both versions, and all one would have to "#if" on the deployment target would be your own typealias to the underlying thing.


The [*] in this paragraph refers to the * preceding "This applies to the following tools", which becomes a list item in the markdown conversion to HTML. I'm not sure how to make this better (maybe replacing it with [*] there?).


`console.log`


@tbroyer
My bad, I haven't read carefully [samples/mobilewebapp/README-MAVEN.txt](https://github.com/gwtproject/gwt/commit/a0de97b999468b12d6c19d6a470ca03b2a2b4557#diff-7cd9e1caf2c11ce5be37872ec6d13efbR61)
Everything works fine.
Thanks


@chhapil. This along with other cleanups to the cortexbrain-tune script is needed to enable/disable alucard in stweaks.


What does `scrollBy` return?


And should we check for existence of `findDOMNode(ref)`? Is it never undefined?


Please wrap this line.


Random indentation and whitespace changes snuck in here (none of which are correct??).


「複数行を割り当てる」ではなく、「複数列に代入する」だと思います。
UPDATE ..... SET (a, b, c ) = (SELECT d, e, f....)
の構文の話をしているところなので。


Looking at the rest of the file, we set pointers to `nullptr` close to where they are actually initialized. I'll keep this here to be consistent with the rest.


This commit looks good


Good job!


Done.


Also I'm curious, is that the safest way to handle asynchronous array iteration in Python?


Edit: Now alucard won't switch on, will fix up soon :)


Are you sure it might not be transient error and we can retry? Internal close because we could have an array of servers and we want to move to the next in the list, public Close() should only come from users.


Nice @lehanism !


May want backticks on remote.$remote.cinnabar-data.


It's not a good idea to use `assert` in tests, because when assertions aren't enabled you won't catch any failure.


tbh I still am curious what `tools.getAbility(set.ability).gen <= eventData.generation` was intended to accomplish. Do you remember?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14266](https://teamcity.mesosphere.io/viewLog.html?buildId=122085&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 219 Build time: 00:02:38
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


But...what if you NEED to say "you're" inside there?? How would you do that?? (there's a hint in the homework)


Nodes are our big use case, but anything in the cluster that needs TLS assets could use the same endpoint. It seems widely-applicable enough to make it a generic offering.


No, because there aren't any arguments. It just one big name like "performSelector(_:withObject:)"


Thanks! BitHub has sent payment of  $24.75USD for this commit.


it's called an ESCAPE CHARACTER


:droplet: :raised_hands: :raised_hands: :raised_hands: :droplet: