@luzfcb it prevents attributes that are inherited from a parent model to be saved in the historical record. For me, specifically, models that inherited from `MPTTModel` in the `mptt` package were causing issues.


Done


I haven't used java in 10 years, but I will try. :smiley:

It looks like I just need to install IntelliJ and clone this repository. Is there anything else I need to know about building plugins for pycharm?


What's this and why am I getting this? ;)

On Tue, Feb 23, 2016 at 12:33 AM, Kirill Bobyrev <notifications@github.com>
wrote:

> resolved all issues related to the code @alexfh pointed me to
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/omtcyf0/clang-tools-extra/commit/995d9bf799860738405e4f7557ed7f66d906ce5d
>


@kangax: add your kangax@fb.com email to your GitHub profile too :)


Ah, I think I was confused by the use of "-path" in the option, which (in my head) refers to a file that might not exist yet. Of course, today there are no inputs that aren't just plain old command-line arguments, so there's no precedent. Thanks for explaining it to me.


@lasley Do I do this? `render :nothing => true, :status => 204 and return`


Done. See commit 93.


## Another comment


sorry, i accidentally deleted this stuff, i'm an idiot. don't hate me!


Initializing a file Warangal, TS, added a couple of things to see


Instead of tracking m_isPendingFinalize to avoid accessing a deleted script context in the shutdown scenario, may be should use ThreadContext::GetContextForCurrentThread to get the thread context instead?


Do you think those functions will be used in other templates than ``route/view.html``?
If not you could:
* simply define them at the end of ``route/view.html``
* move them in some route-dedicated helper file (``route/helpers/view.html``??), in order to prevent ``helpers/view.html`` from growing too big with very specialized functions.


LOL, the correct doesn't is `LICENSE` ?


Added quotations to relevant queries.


I still see the possibility of race - https://github.com/meebey/smuxi/commit/961d2961ff6ebb6656bd6c296ec65a649eac75bf#diff-c4b79d637df5669018f657a76286eaf4R649

Shouldn't access to the chats collection be in some kind of critical section? I.e. lines 649 & 650 should be together inside some lock...


Delete this and bufSize


fw is a bit confusing of a variable. Don't know what it stands for


@nf071590 No it's not, good point. I don't know why I deleted that, and directly called set Cookie (without updating the store). Actually it introduces a bug where when you update the address, navigate away from the My Location page, and then go back to it, it does not get updated. Do you want to create a pull request to put back in? Sorry it looks like this already merged before code review.


I noticed your announcement so i may close this...


Por um erro que acontece no Issue #82 Segundo item, essa linha foi será restaurada.


Ici idem, .module devrait passer à la ligne pour des raisons d'homogénéité


**Shortlog of HEAD commit is too long.**
*GitCommitBear, severity 1, section `commit`.* *Project wide.*


Schon committet? Ich hätte hier noch ein paar Korrekturen.


@aragavan can we add some unit tests around the new functionality? Also, you need to handle null coming back as the instance id.  I don't think we want "SeleniumGridScalerPlugin_null" as a tag.


It is to pop the scope that was pushed on the context stack. In theory this should "just work", but in practice the better way would be to "set" the inner context instead of pushing another one.


peer deps not being installed are merely warnings, so that shouldn't fail anything.

But yes, see #751. There's no way for us to make it a dep for the react rules, but not for the base, without splitting this package into two (which would be far more complex to deal with)


Pass e in as the argument instead of calling toString() on it.


This reads funny.  Can we just convert this into a while loop?


optimized code?


Need to revert; I goofed.


C'est moi ou on est passés de Trans*Ctl à Tr*Ctl ?


DoES Liverpool Circular Knitic - Casting on Video: https://www.youtube.com/watch?v=TVHIUf6ZlCI


.module à la ligne


Indent de 8 espaces au lieu de 4


113768035_Provide-addition-explanation-to-input-contaminant-generation-rate-in-IO-Ref-#5480 (lgu1234) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ici, `transaction-short` pourrait être une balise short, non ?


Hey Altaf Mahdi,

Thanks for the quick reply.# CONFIG_BUILD_ARM64_APPENDED_DTB_IMAGE is not set

I am using your device tree so i am pointed to cm_oneplus2_defconfig

with following hange i could able to boot with caf merge, since i am not kernel expert ! I may be wrong doing following change.
# CONFIG_BUILD_ARM64_APPENDED_DTB_IMAGE is not set

Please suggest if i were missing something

your device tree, kernel and vendors has been used !


 * Package:    sys-libs/glibc-2.22-r2
 * Repository: gentoo
 * Maintainer: toolchain@gentoo.org
 * USE:        abi_x86_64 amd64 elibc_glibc kernel_linux multilib userland_GNU
 * FEATURES:   preserve-libs sandbox userpriv usersandbox
>>> Unpacking source...
>>> Unpacking gcc-4.7.3-r1-multilib-bootstrap.tar.bz2 to /var/tmp/portage/sys-libs/glibc-2.22-r2/work
 * Checking gcc for __thread support ...                                                                                [ ok ]
 * Checking kernel version (4.4.1 >= 2.6.32) ...                                                                                [ ok ]
 * Checking linux-headers version (4.4.0 >= 2.6.32) ...                                                                                [ ok ]
>>> Unpacking glibc-2.22.tar.xz to /var/tmp/portage/sys-libs/glibc-2.22-r2/work
>>> Unpacking glibc-2.22-patches-10.tar.bz2 to /var/tmp/portage/sys-libs/glibc-2.22-r2/work
>>> Source unpacked in /var/tmp/portage/sys-libs/glibc-2.22-r2/work
>>> Preparing source in /var/tmp/portage/sys-libs/glibc-2.22-r2/work/glibc-2.22 ...
 * Applying Gentoo Glibc Patchset 2.22-10 ...
 *   00_all_0001-disable-ldconfig-during-install.patch ...                                                                                [ ok ]
 *   Skipping 00_all_0002-workaround-crash-when-handling-signals-in-static-PIE.patch due to EPATCH_EXCLUDE ...
 *   00_all_0003-Fix-localedef-segfault-when-run-under-exec-shield-Pa.patch ...                                                                                [ ok ]
 *   00_all_0004-reload-etc-resolv.conf-when-it-has-changed.patch ...                                                                                [ ok ]
 *   00_all_0005-nptl-support-thread-stacks-that-grow-up.patch ...                                                                                [ ok ]
 *   00_all_0006-rtld-do-not-ignore-arch-specific-CFLAGS.patch ...                                                                                [ ok ]
 *   00_all_0007-gentoo-support-running-tests-under-sandbox.patch ...                                                                                [ ok ]
 *   00_all_0008-gentoo-disable-building-in-timezone-subdir.patch ...                                                                                [ ok ]
 *   00_all_0009-arm-fix-PIC-vs-SHARED-typos.patch ...                                                                                [ ok ]
 *   00_all_0010-hppa-fix-build-problems-with-atomic-code.patch ...                                                                                [ ok ]
 *   00_all_0011-hppa-fix-pthread-spinlock.patch ...                                                                                [ ok ]
 *   Skipping 00_all_0012-disable-PIE-when-checking-for-PIC-default.patch due to EPATCH_EXCLUDE ...
 *   00_all_0013-nptl-fix-set-but-unused-warning-w-_STACK_GROWS_UP.patch ...                                                                                [ ok ]
 *   00_all_0014-hppa-_dl_symbol_address-add-missing-hidden-def.patch ...                                                                                [ ok ]
 *   00_all_0015-microblaze-include-unix-sysdep.h.patch ...                                                                                [ ok ]
 *   00_all_0016-hppa-Fix-miscompilation-of-sched_setaffinity-BZ-1848.patch ...                                                                                [ ok ]
 *   00_all_0017-Readd-O_LARGEFILE-flag-for-openat64-bug-18781.patch ...                                                                                [ ok ]
 *   00_all_0018-Clear-DF_1_NODELETE-flag-only-for-failed-to-load-lib.patch ...                                                                                [ ok ]
 *   00_all_0019-hppa-start.S-rework-references-to-fix-PIE-TEXTRELs-B.patch ...                                                                                [ ok ]
 *   00_all_0020-manual-skip-build-when-perl-is-unavailable.patch ...                                                                                [ ok ]
 *   00_all_0021-getmntent-fix-memory-corruption-w-blank-lines-BZ-188.patch ...                                                                                [ ok ]
 *   00_all_0022-BZ-17250-Fix-static-dlopen-default-library-search-pa.patch ...                                                                                [ ok ]
 *   00_all_0023-Fix-non-v9-32-bit-sparc-build.patch ...                                                                                [ ok ]
 *   00_all_0024-BZ-18921-Fix-opendir-inverted-o_directory_works-test.patch ...                                                                                [ ok ]
 *   00_all_0025-Use-HOST_NAME_MAX-for-MAXHOSTNAMELEN-in-sys-param.h.patch ...                                                                                [ ok ]
 *   00_all_0026-Always-enable-pointer-guard-BZ-18928.patch ...                                                                                [ ok ]
 *   00_all_0027-BZ-18796.patch ...                                                                                [ ok ]
 *   00_all_0028-strcoll-Remove-incorrect-STRDIFF-based-optimization-.patch ...                                                                                [ ok ]
 *   00_all_0029-Harden-tls_dtor_list-with-pointer-mangling-BZ-19018.patch ...                                                                                [ ok ]
 *   00_all_0030-PowerPC-Fix-a-race-condition-when-eliding-a-lock.patch ...                                                                                [ ok ]
 *   00_all_0031-Keep-only-ELF_RTYPE_CLASS_-PLT-COPY-bits-for-prelink.patch ...                                                                                [ ok ]
 *   00_all_0032-Better-workaround-for-aliases-of-_finite-symbols-in-.patch ...                                                                                [ ok ]
 *   00_all_0033-Corrected-path-to-installed-libmvec_nonshared.a.patch ...                                                                                [ ok ]
 *   00_all_0034-powerpc-Fix-usage-of-elision-transient-failure-adapt.patch ...                                                                                [ ok ]
 *   00_all_0035-alpha-hppa-fix-libc.abilist-sorting-wrt-fmemopen.patch ...                                                                                [ ok ]
 *   00_all_0036-Fix-BZ-17905.patch ...                                                                                [ ok ]
 *   00_all_0037-Fix-BZ-18985-out-of-range-data-to-strftime-causes-a-.patch ...                                                                                [ ok ]
 *   00_all_0038-Gracefully-handle-incompatible-locale-data.patch ...                                                                                [ ok ]
 *   00_all_0039-Handle-overflow-in-__hcreate_r.patch ...                                                                                [ ok ]
 *   00_all_0040-Improve-check-against-integer-wraparound-in-hcreate_.patch ...                                                                                [ ok ]
 *   10_all_glibc-CVE-2015-7547.patch ...                                                                                [ ok ]
 * Done with patching
 * Using GNU config files from /usr/share/gnuconfig
 *   Updating scripts/config.sub                                                                                [ ok ]
 *   Updating scripts/config.guess                                                                                [ ok ]
 * Applying glibc-2.19-ia64-gcc-4.8-reloc-hack.patch ...                                                                                [ ok ]
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/sys-libs/glibc-2.22-r2/work/glibc-2.22 ...
 * Running toolchain-glibc_src_configure for ABI x86

 * Configuring glibc for nptl
 *             ABI:   x86
 *          CBUILD:   x86_64-pc-linux-gnu
 *           CHOST:   x86_64-pc-linux-gnu
 *         CTARGET:   x86_64-pc-linux-gnu
 *      CBUILD_OPT:   i686-pc-linux-gnu
 *     CTARGET_OPT:   i686-pc-linux-gnu
 *              CC:   clang -m32
 *              LD:
 *         ASFLAGS:
 *          CFLAGS:   -pipe -O2 -fno-strict-aliasing
 *        CPPFLAGS:
 *        CXXFLAGS:   -pipe -O2 -fno-strict-aliasing
 *         LDFLAGS:   -Wl,-O1 -Wl,--as-needed
 *       Manual CC:   clang -m32 -Wl,-O1 -Wl,--as-needed

/var/tmp/portage/sys-libs/glibc-2.22-r2/work/glibc-2.22/configure --disable-stackguard-randomization --enable-kernel=2.6.32 --enable-add-ons=c_stubs,libidn --without-selinux --without-cvs --disable-werror --enable-bind-now --build=i686-pc-linux-gnu --host=i686-pc-linux-gnu --disable-profile --without-gd --with-headers=/usr/include --prefix=/usr --libdir=/usr/lib32 --mandir=/usr/share/man --infodir=/usr/share/info --libexecdir=/usr/lib32/misc/glibc --with-bugurl=http://bugs.gentoo.org/ --with-pkgversion=Gentoo 2.22-r2 p10 --enable-obsolete-rpc --disable-systemtap --disable-nscd
checking build system type... i686-pc-linux-gnu
checking host system type... i686-pc-linux-gnu
checking for i686-pc-linux-gnu-gcc... clang -m32 -Wl,-O1 -Wl,--as-needed
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether clang -m32 -Wl,-O1 -Wl,--as-needed accepts -g... yes
checking for i686-pc-linux-gnu-readelf... no
checking for readelf... readelf
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking whether g++ can link programs... yes
checking for sysdeps preconfigure fragments... aarch64 alpha arm hppa i386 m68k microblaze mips nacl nios2 powerpc s390 sh sparc tile x86_64
configure: running configure fragment for add-on c_stubs
configure: running configure fragment for add-on libidn
checking for assembler and linker STT_GNU_IFUNC support... no
checking whether .text pseudo-op must be used... yes
checking sysdep dirs... sysdeps/unix/sysv/linux/i386/i686 sysdeps/i386/i686/nptl sysdeps/unix/sysv/linux/i386 sysdeps/unix/sysv/linux/x86 sysdeps/i386/nptl sysdeps/unix/sysv/linux sysdeps/nptl sysdeps/pthread sysdeps/gnu sysdeps/unix/inet sysdeps/unix/sysv sysdeps/unix/i386 sysdeps/unix sysdeps/posix sysdeps/i386/i686/fpu sysdeps/i386/i686 sysdeps/i386/i486 sysdeps/i386/fpu sysdeps/x86/fpu sysdeps/i386 sysdeps/x86 sysdeps/wordsize-32 sysdeps/ieee754/ldbl-96 sysdeps/ieee754/dbl-64 sysdeps/ieee754/flt-32 sysdeps/ieee754 sysdeps/generic
checking for a BSD-compatible install... /usr/lib/portage/python3.4/ebuild-helpers/xattr/install -c
checking whether ln -s works... yes
checking whether /usr/bin/x86_64-pc-linux-gnu-as is GNU as... yes
checking whether /usr/bin/x86_64-pc-linux-gnu-ld is GNU ld... yes
checking for /usr/bin/x86_64-pc-linux-gnu-as... /usr/bin/x86_64-pc-linux-gnu-as
checking version of /usr/bin/x86_64-pc-linux-gnu-as... 2.25.1, ok
checking for /usr/bin/x86_64-pc-linux-gnu-ld... /usr/bin/x86_64-pc-linux-gnu-ld
checking version of /usr/bin/x86_64-pc-linux-gnu-ld... 2.25.1, ok
checking for gnumake... no
checking for gmake... gmake
checking version of gmake... 4.1, ok
checking for gnumsgfmt... no
checking for gmsgfmt... gmsgfmt
checking version of gmsgfmt... 0.19.7, ok
checking for makeinfo... makeinfo
checking version of makeinfo... 6.1, ok
checking for sed... sed
checking version of sed... 4.2.2, ok
checking for gawk... gawk
checking version of gawk... 4.1.3, ok
checking if clang -m32 -Wl,-O1 -Wl,--as-needed is sufficient to build libc... no
checking for i686-pc-linux-gnu-nm... no
checking for nm... nm
configure: error:
*** These critical programs are missing or too old: compiler
*** Check the INSTALL file for required versions.
 * ERROR: sys-libs/glibc-2.22-r2::gentoo failed (configure phase):
 *   failed to configure glibc
 *
 * Call stack:
 *             ebuild.sh, line  133:  Called src_configure
 *           environment, line 3268:  Called eblit-run 'src_configure'
 *           environment, line  973:  Called eblit-glibc-src_configure
 *   src_configure.eblit, line  263:  Called foreach_abi 'toolchain-glibc_src_configure'
 *          common.eblit, line  363:  Called toolchain-glibc_src_configure
 *   src_configure.eblit, line  258:  Called glibc_do_configure 'nptl'
 *   src_configure.eblit, line  148:  Called die
 * The specific snippet of code:
 *      "$@" || die "failed to configure glibc"
 *
 * If you need support, post the output of `emerge --info '=sys-libs/glibc-2.22-r2::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=sys-libs/glibc-2.22-r2::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/sys-libs/glibc-2.22-r2/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/sys-libs/glibc-2.22-r2/temp/environment'.
 * Working directory: '/var/tmp/portage/sys-libs/glibc-2.22-r2/work/build-x86-x86_64-pc-linux-gnu-nptl'
 * S: '/var/tmp/portage/sys-libs/glibc-2.22-r2/work/glibc-2.22'


I'm not going to bother with a pull request for this, but I think this is still inelegant. You could improve this by renaming some of the variables involved. Maybe `bytesPerSize` -> `pixelCount`. Then you'd have bytesPerPixel * pixelCount, which reads a lot better.


I thought it was Smallville?


Using `set` instead of `push` would cause it to break out of the class and object literal contexts it is included in. And since it is included in two different parents scopes, there isn't a deterministic context to `set` back to.


`event-short` devrait être en balise courte, non ?


`transaction-short` en balise courte


DoES Liverpool Circular Knitic - Casting On Video: https://www.youtube.com/watch?v=TVHIUf6ZlCI


TeamCity LabKey :: LabkeyRelease15.3 :: CDS postgres 9.4 [Build 157](https://teamcity.labkey.org/viewLog.html?buildId=305138&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 7, passed: 43 Build time: 01:23:25
### Failed tests
```
org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisFilter: <no details avaliable>

```


you could run following commands to tidy up your minetest_game repo:
git checkout -b add_pies
git checkout master
git fetch https://github.com/minetest/minetest_game master
git reset FETCH_HEAD

and to get rid of that "Add Backgrounds for Formspecs" commit and its reverting, just rebase the add_pies branch
$ git checkout add_pies && git rebase -i master
add #s before picking those two commits, hit ctrl+o and then ctrl+x


Can you move these to a new section and explain how table support works and that it's limited?


Hi Daniele.

Based on your code I wrote a port for esp-open-rtos:
https://github.com/hetii/esp-open-rtos/commit/ffd6cb4799f7094b4a2bbfcac40a81315e7bbac5

Unfortunate GPL license is a blocker for us to merge it into master branch.

Is it possible that you will change license or allow us to use my port into esp-open-rtos project ?


Hmm, probably from when we tested source built. Should be ok to remove it though.


Fantastic. Works great now. Thanks!


event-short en balise courte


Ja, ich habe die Änderungen bereits committed. Hast du noch weitere Änderung außer dieser? Wenn ja, schreib' sie bitte einfach als Kommentar dazu, ich nehme sie dann in den Pull request mit auf.


balise courte


Sure, I'll be preoccupied atm but I'll jump to it later today


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/27894/testReport/) for this commit**


@eliofreitas no console outputs in tests


**[unitTests_php_contractual_responsibilities run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_contractual_responsibilities/490/testReport/) for this commit**


Ja, ich habe die Änderungen schon commited.

Hast du noch weitere Korrekturen? Dann hänge ich die einfach noch an den Pull Request an. Bei mir ist Zeile 1020 allerdings schon korrigiert.


`Tr*Ctl` ou `Trans*Ctl` ? ('suffit de fixer, au pire ça se change pas trop mal mais si on évite de faire des sed en mode yolo ça peut être plus cool :))


@eliofreitas expecting this many fields?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16865](https://teamcity.mesosphere.io/viewLog.html?buildId=142372&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:07


Note that if you retrieved a value of `true` for `mCurrentStatus`, that implies that the user had shown the answer prior to rotating the device. Are they happy that the answer has disappeared from the screen just because they rotated the device? Probably not. So, I would suggest redisplaying it.


It's ok how you implemented it.


Sorry, can not accept this patch, we are not going to edit rfxtrx.h as this is provided by RFXCom, any change will be overwritten when the API updates
Plus, this is not a fix for a dimmer slider


DoES Liverpool Circular Knitic - Casting On Video: https://www.youtube.com/watch?v=TVHIUf6ZlCI


This does not work on Python 2.6, which we still (at least claim to) support. Please leave it as is, that's the way we check for python versions elsewhere in the code.


это вечный цикл


If libfreenect2 is not installed into some default paths like `/usr/local`, cmake in depending projects will fail to find libfreenect2. Can we change this, or mention that one has to use `cmake .. -DCMAKE_INSTALL_PREFIX=/usr/local` if other packages should be able to find it.


I don't get the requirement for distributing pre-compiled binaries: looks like a hack.
How about you create a unified diff for the unpatched vs. the patched sources. You can then use a standard ConfigureMake or MakeCp easyconfig where you include the *.patch file...


Well if we dont do it, it will break all other sliders


Если кого-то приймут на работу или уволят, достаточно будет поменять один параметр


А, черт, извини. Это я коммичу в свой бранч форка clang-tools-extra и
пытаюсь писать информативные комментарии для себя :)

Этот коммит приурочен к очередной порции фиксов после твоих комментариев на
reviews.llvm.org; внезапно гитхаб сообщает о mention'ах в коммитах, это не
intentional :)
On Feb 23, 2016 8:53 PM, "alexfh" <notifications@github.com> wrote:

> What's this and why am I getting this? ;)
>
> On Tue, Feb 23, 2016 at 12:33 AM, Kirill Bobyrev <notifications@github.com
> >
> wrote:
>
> > resolved all issues related to the code @alexfh pointed me to
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> >
> https://github.com/omtcyf0/clang-tools-extra/commit/995d9bf799860738405e4f7557ed7f66d906ce5d
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/omtcyf0/clang-tools-extra/commit/995d9bf799860738405e4f7557ed7f66d906ce5d#commitcomment-16274864>
> .
>


This is the same value that is copied from `x64` propertygroup - https://github.com/Sridhar-MS/roslyn/commit/536c263d8fcad5e7acffd58c83700ca5e5f5c96b#diff-e67bc0de066f6063b0ecf05bd5a3acc4R42 against which csccore is currently built.


We should just combine these into one interface to match iOS library. Also callback doesn't make much sense since there is no failure action. Something like:

```
public interface TweetViewClickListener {
    void onPhotoClick(Tweet tweet, MediaEntity mediaEntity);

    void onVideoClick(Tweet tweet, MediaEntity mediaEntity);

    void onUrlClick(Tweet tweet, UrlEntity url);
}
```

In the future we can add callbacks for profile clicks too. Something iOS already supports.

Then we would have just one setter: `setTweetViewClickListener()`


これはlayout を外に出してあげたってこと？


The default initial value for a `boolean` is `false`, so you don't need to explicitly specify it. More importantly, you shouldn't be hardcoding this to only work in the case of five questions; you should make the array whatever length matches the length of the question bank.


ありがとうございます。


This is also copied from the `x64` propertygroup - https://github.com/Sridhar-MS/roslyn/commit/536c263d8fcad5e7acffd58c83700ca5e5f5c96b#diff-e67bc0de066f6063b0ecf05bd5a3acc4R43


@resendefreitas aqui estão as quatro telas:
- Pinpad desligado
- Tentando conectar com Pinpad
- Inserir cartão no Pinpad
- Erro ao inserir o cartão

Basta chamar uma de cada vez no *content* para ser exibida.


my comment


saw approval from javajolt
at https://github.com/basho/riak-python-client/commit/827787fe57ec5f667f29086eec4bd7f3044f2154


merging basho/riak-python-client/fixes/lrb/fix-pypi-documentation = 827787fe into borshop-integration-438-fixes/lrb/fix-pypi-documentation


basho/riak-python-client/fixes/lrb/fix-pypi-documentation = 827787fe merged ok, testing candidate = 351a5c21


@zebastian, Thanks for finishing this.
@mclarekin, As you see all transforms were rendered as hybrid fractals. I would keep also Benesi transforms as hybrids, even they produce objects as single formulas. I want to have all icons made in the same way.


my second comment


Ah, ok, never mind ;)

2016-02-23 19:11 GMT+01:00 Kirill Bobyrev <notifications@github.com>:

> А, черт, извини. Это я коммичу в свой бранч форка clang-tools-extra и
> пытаюсь писать информативные комментарии для себя :)
>
> Этот коммит приурочен к очередной порции фиксов после твоих комментариев
> на
> reviews.llvm.org; внезапно гитхаб сообщает о mention'ах в коммитах, это
> не
> intentional :)
> On Feb 23, 2016 8:53 PM, "alexfh" <notifications@github.com> wrote:
>
> > What's this and why am I getting this? ;)
> >
> > On Tue, Feb 23, 2016 at 12:33 AM, Kirill Bobyrev <
> notifications@github.com
> > >
> > wrote:
> >
> > > resolved all issues related to the code @alexfh pointed me to
> > >
> > > ---
> > > Reply to this email directly or view it on GitHub:
> > >
> > >
> >
> https://github.com/omtcyf0/clang-tools-extra/commit/995d9bf799860738405e4f7557ed7f66d906ce5d
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/omtcyf0/clang-tools-extra/commit/995d9bf799860738405e4f7557ed7f66d906ce5d#commitcomment-16274864>
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/omtcyf0/clang-tools-extra/commit/995d9bf799860738405e4f7557ed7f66d906ce5d#commitcomment-16275266>
> .
>


@flavour Please review


Haha yeah, this is on the list of reasons I prefer Python 3. Thanks for catching this though. :+1:


https://github.com/AutoQuad/qgroundcontrol_aq/commits/master

http://forum.autoquad.org/viewtopic.php?f=32&t=4786


`default: oops()`


Updated Product Specifications Document

[Prelim_Specifications_DITZY_02192016.docx](https://github.com/taylorrowan/SoftwareEngineeringProject/files/143143/Prelim_Specifications_DITZY_02192016.docx)


why did you comment instead of `skip()`?


The firmwares need to be in /system/etc/firmware/ path. Am I missing something here ?


How come you're calling whereRecipient(this) twice?
Was this intentional or required? Looks like a typo to me.


This call to `checkIfHasCheatedOnQuestion` is the first place where we see the cluttering of your program that results from your still using the `mIsCheater` variable. That variable no longer was useful once you created the more general `mHasCheatedOnQuestion`; you could just use `mHasCheatedOnQuestion[mCurrentIndex]` everywhere you used to use `mIsCheater`. If you did that, then you could get rid of the code that painstakingly tries to keep `mIsCheater` up to date.


Would it make sense to use `fs.stat` instead? I'm just concerned about adding even slightly more contention by using synchronous I/O to an agent that sometimes needs to deal with a lot of concurrent I/O.


There are quite a few intricacies related to JS performance, see http://mp.binaervarianz.de/JS_perf_study_TR_Oct2015.pdf for a recent paper about it.


.module à la ligne


It would be cleaner to have the class name match the file name.


> Our installer will actually check for an existing libglvnd installation when it runs, and it'll try to avoid overwriting one if it's already there.

I hope there is an explicit mention about this somewhere. Providing a varying set of files depending on what's already available isn't great from a distribution (aka Ubuntu, Arch) POV.

> Besides all that, there are also some ABI changes that I'm working on that have a more functional benefit of being better able to work around broken applications. I don't know yet what other problems we might find in the meantime as libglvnd gets more real-world exposure

Sure thing. Considering there's no official release we can break things as much as we want. Once we have 1.0.0 we can start bumping the ABI/SONAME version on each change ?

On the naming suggestion - checkfoo implies an int style return value (0 on success), while the latter a boolean one.


balise courte


-> "Test case for Issue 602:"


Na parte "novas linguages" deveria ser linguag**ens**.


LGTM


done


done (here and elsewhere)


There is a slight inconsistency in usage of `hasOwnProperty` for some of these tests, is there a specific reason for that?


Fixes #4


Type annotations should be on the same line as the type they annotate. (Declaration annotations are usually written on a separate line before.)


This line of code can change `mHasCheatedOnQuestion[mCurrentIndex]` from `false` to `true` if the user has newly cheated on the question. That's good. But it also can change `mHasCheatedOnQuestion[mCurrentIndex]` from `true` to `false` if the user didn't look at the answer on this particular trip into `CheatActivity`, but had done so previously. That doesn't seem so good. I'd think that once we have a record of the user cheating on a particular question, we ought to retain that record forever after.


right right, ignore me haha


At one point. Not any more.


Is this meant to return null?


On Tue, Feb 23, 2016 at 10:03:11AM -0800, ndtimofeev wrote:
>  * Package:    sys-libs/glibc-2.22-r2
>  * Repository: gentoo
>  * Maintainer: toolchain@gentoo.org
>  * USE:        abi_x86_64 amd64 elibc_glibc kernel_linux multilib userland_GNU
>  * FEATURES:   preserve-libs sandbox userpriv usersandbox
> >>> Unpacking source...
> >>> Unpacking gcc-4.7.3-r1-multilib-bootstrap.tar.bz2 to /var/tmp/portage/sys-libs/glibc-2.22-r2/work
>  * Checking gcc for __thread support ...                                                                                [ ok ]
>  * Checking kernel version (4.4.1 >= 2.6.32) ...                                                                                [ ok ]
>  * Checking linux-headers version (4.4.0 >= 2.6.32) ...                                                                                [ ok ]
> >>> Unpacking glibc-2.22.tar.xz to /var/tmp/portage/sys-libs/glibc-2.22-r2/work
> >>> Unpacking glibc-2.22-patches-10.tar.bz2 to /var/tmp/portage/sys-libs/glibc-2.22-r2/work
> >>> Source unpacked in /var/tmp/portage/sys-libs/glibc-2.22-r2/work
> >>> Preparing source in /var/tmp/portage/sys-libs/glibc-2.22-r2/work/glibc-2.22 ...
>  * Applying Gentoo Glibc Patchset 2.22-10 ...
>  *   00_all_0001-disable-ldconfig-during-install.patch ...                                                                                [ ok ]
>  *   Skipping 00_all_0002-workaround-crash-when-handling-signals-in-static-PIE.patch due to EPATCH_EXCLUDE ...
>  *   00_all_0003-Fix-localedef-segfault-when-run-under-exec-shield-Pa.patch ...                                                                                [ ok ]
>  *   00_all_0004-reload-etc-resolv.conf-when-it-has-changed.patch ...                                                                                [ ok ]
>  *   00_all_0005-nptl-support-thread-stacks-that-grow-up.patch ...                                                                                [ ok ]
>  *   00_all_0006-rtld-do-not-ignore-arch-specific-CFLAGS.patch ...                                                                                [ ok ]
>  *   00_all_0007-gentoo-support-running-tests-under-sandbox.patch ...                                                                                [ ok ]
>  *   00_all_0008-gentoo-disable-building-in-timezone-subdir.patch ...                                                                                [ ok ]
>  *   00_all_0009-arm-fix-PIC-vs-SHARED-typos.patch ...                                                                                [ ok ]
>  *   00_all_0010-hppa-fix-build-problems-with-atomic-code.patch ...                                                                                [ ok ]
>  *   00_all_0011-hppa-fix-pthread-spinlock.patch ...                                                                                [ ok ]
>  *   Skipping 00_all_0012-disable-PIE-when-checking-for-PIC-default.patch due to EPATCH_EXCLUDE ...
>  *   00_all_0013-nptl-fix-set-but-unused-warning-w-_STACK_GROWS_UP.patch ...                                                                                [ ok ]
>  *   00_all_0014-hppa-_dl_symbol_address-add-missing-hidden-def.patch ...                                                                                [ ok ]
>  *   00_all_0015-microblaze-include-unix-sysdep.h.patch ...                                                                                [ ok ]
>  *   00_all_0016-hppa-Fix-miscompilation-of-sched_setaffinity-BZ-1848.patch ...                                                                                [ ok ]
>  *   00_all_0017-Readd-O_LARGEFILE-flag-for-openat64-bug-18781.patch ...                                                                                [ ok ]
>  *   00_all_0018-Clear-DF_1_NODELETE-flag-only-for-failed-to-load-lib.patch ...                                                                                [ ok ]
>  *   00_all_0019-hppa-start.S-rework-references-to-fix-PIE-TEXTRELs-B.patch ...                                                                                [ ok ]
>  *   00_all_0020-manual-skip-build-when-perl-is-unavailable.patch ...                                                                                [ ok ]
>  *   00_all_0021-getmntent-fix-memory-corruption-w-blank-lines-BZ-188.patch ...                                                                                [ ok ]
>  *   00_all_0022-BZ-17250-Fix-static-dlopen-default-library-search-pa.patch ...                                                                                [ ok ]
>  *   00_all_0023-Fix-non-v9-32-bit-sparc-build.patch ...                                                                                [ ok ]
>  *   00_all_0024-BZ-18921-Fix-opendir-inverted-o_directory_works-test.patch ...                                                                                [ ok ]
>  *   00_all_0025-Use-HOST_NAME_MAX-for-MAXHOSTNAMELEN-in-sys-param.h.patch ...                                                                                [ ok ]
>  *   00_all_0026-Always-enable-pointer-guard-BZ-18928.patch ...                                                                                [ ok ]
>  *   00_all_0027-BZ-18796.patch ...                                                                                [ ok ]
>  *   00_all_0028-strcoll-Remove-incorrect-STRDIFF-based-optimization-.patch ...                                                                                [ ok ]
>  *   00_all_0029-Harden-tls_dtor_list-with-pointer-mangling-BZ-19018.patch ...                                                                                [ ok ]
>  *   00_all_0030-PowerPC-Fix-a-race-condition-when-eliding-a-lock.patch ...                                                                                [ ok ]
>  *   00_all_0031-Keep-only-ELF_RTYPE_CLASS_-PLT-COPY-bits-for-prelink.patch ...                                                                                [ ok ]
>  *   00_all_0032-Better-workaround-for-aliases-of-_finite-symbols-in-.patch ...                                                                                [ ok ]
>  *   00_all_0033-Corrected-path-to-installed-libmvec_nonshared.a.patch ...                                                                                [ ok ]
>  *   00_all_0034-powerpc-Fix-usage-of-elision-transient-failure-adapt.patch ...                                                                                [ ok ]
>  *   00_all_0035-alpha-hppa-fix-libc.abilist-sorting-wrt-fmemopen.patch ...                                                                                [ ok ]
>  *   00_all_0036-Fix-BZ-17905.patch ...                                                                                [ ok ]
>  *   00_all_0037-Fix-BZ-18985-out-of-range-data-to-strftime-causes-a-.patch ...                                                                                [ ok ]
>  *   00_all_0038-Gracefully-handle-incompatible-locale-data.patch ...                                                                                [ ok ]
>  *   00_all_0039-Handle-overflow-in-__hcreate_r.patch ...                                                                                [ ok ]
>  *   00_all_0040-Improve-check-against-integer-wraparound-in-hcreate_.patch ...                                                                                [ ok ]
>  *   10_all_glibc-CVE-2015-7547.patch ...                                                                                [ ok ]
>  * Done with patching
>  * Using GNU config files from /usr/share/gnuconfig
>  *   Updating scripts/config.sub                                                                                [ ok ]
>  *   Updating scripts/config.guess                                                                                [ ok ]
>  * Applying glibc-2.19-ia64-gcc-4.8-reloc-hack.patch ...                                                                                [ ok ]
> >>> Source prepared.
> >>> Configuring source in /var/tmp/portage/sys-libs/glibc-2.22-r2/work/glibc-2.22 ...
>  * Running toolchain-glibc_src_configure for ABI x86
>
>  * Configuring glibc for nptl
>  *             ABI:   x86
>  *          CBUILD:   x86_64-pc-linux-gnu
>  *           CHOST:   x86_64-pc-linux-gnu
>  *         CTARGET:   x86_64-pc-linux-gnu
>  *      CBUILD_OPT:   i686-pc-linux-gnu
>  *     CTARGET_OPT:   i686-pc-linux-gnu
>  *              CC:   clang -m32
>  *              LD:
>  *         ASFLAGS:
>  *          CFLAGS:   -pipe -O2 -fno-strict-aliasing
>  *        CPPFLAGS:
>  *        CXXFLAGS:   -pipe -O2 -fno-strict-aliasing
>  *         LDFLAGS:   -Wl,-O1 -Wl,--as-needed
>  *       Manual CC:   clang -m32 -Wl,-O1 -Wl,--as-needed
>
> /var/tmp/portage/sys-libs/glibc-2.22-r2/work/glibc-2.22/configure --disable-stackguard-randomization --enable-kernel=2.6.32 --enable-add-ons=c_stubs,libidn --without-selinux --without-cvs --disable-werror --enable-bind-now --build=i686-pc-linux-gnu --host=i686-pc-linux-gnu --disable-profile --without-gd --with-headers=/usr/include --prefix=/usr --libdir=/usr/lib32 --mandir=/usr/share/man --infodir=/usr/share/info --libexecdir=/usr/lib32/misc/glibc --with-bugurl=http://bugs.gentoo.org/ --with-pkgversion=Gentoo 2.22-r2 p10 --enable-obsolete-rpc --disable-systemtap --disable-nscd
> checking build system type... i686-pc-linux-gnu
> checking host system type... i686-pc-linux-gnu
> checking for i686-pc-linux-gnu-gcc... clang -m32 -Wl,-O1 -Wl,--as-needed
> checking for suffix of object files... o
> checking whether we are using the GNU C compiler... yes
> checking whether clang -m32 -Wl,-O1 -Wl,--as-needed accepts -g... yes
> checking for i686-pc-linux-gnu-readelf... no
> checking for readelf... readelf
> checking whether we are using the GNU C++ compiler... yes
> checking whether g++ accepts -g... yes
> checking whether g++ can link programs... yes
> checking for sysdeps preconfigure fragments... aarch64 alpha arm hppa i386 m68k microblaze mips nacl nios2 powerpc s390 sh sparc tile x86_64
> configure: running configure fragment for add-on c_stubs
> configure: running configure fragment for add-on libidn
> checking for assembler and linker STT_GNU_IFUNC support... no
> checking whether .text pseudo-op must be used... yes
> checking sysdep dirs... sysdeps/unix/sysv/linux/i386/i686 sysdeps/i386/i686/nptl sysdeps/unix/sysv/linux/i386 sysdeps/unix/sysv/linux/x86 sysdeps/i386/nptl sysdeps/unix/sysv/linux sysdeps/nptl sysdeps/pthread sysdeps/gnu sysdeps/unix/inet sysdeps/unix/sysv sysdeps/unix/i386 sysdeps/unix sysdeps/posix sysdeps/i386/i686/fpu sysdeps/i386/i686 sysdeps/i386/i486 sysdeps/i386/fpu sysdeps/x86/fpu sysdeps/i386 sysdeps/x86 sysdeps/wordsize-32 sysdeps/ieee754/ldbl-96 sysdeps/ieee754/dbl-64 sysdeps/ieee754/flt-32 sysdeps/ieee754 sysdeps/generic
> checking for a BSD-compatible install... /usr/lib/portage/python3.4/ebuild-helpers/xattr/install -c
> checking whether ln -s works... yes
> checking whether /usr/bin/x86_64-pc-linux-gnu-as is GNU as... yes
> checking whether /usr/bin/x86_64-pc-linux-gnu-ld is GNU ld... yes
> checking for /usr/bin/x86_64-pc-linux-gnu-as... /usr/bin/x86_64-pc-linux-gnu-as
> checking version of /usr/bin/x86_64-pc-linux-gnu-as... 2.25.1, ok
> checking for /usr/bin/x86_64-pc-linux-gnu-ld... /usr/bin/x86_64-pc-linux-gnu-ld
> checking version of /usr/bin/x86_64-pc-linux-gnu-ld... 2.25.1, ok
> checking for gnumake... no
> checking for gmake... gmake
> checking version of gmake... 4.1, ok
> checking for gnumsgfmt... no
> checking for gmsgfmt... gmsgfmt
> checking version of gmsgfmt... 0.19.7, ok
> checking for makeinfo... makeinfo
> checking version of makeinfo... 6.1, ok
> checking for sed... sed
> checking version of sed... 4.2.2, ok
> checking for gawk... gawk
> checking version of gawk... 4.1.3, ok
> checking if clang -m32 -Wl,-O1 -Wl,--as-needed is sufficient to build libc... no
> checking for i686-pc-linux-gnu-nm... no
> checking for nm... nm
> configure: error:
> *** These critical programs are missing or too old: compiler
> *** Check the INSTALL file for required versions.
>  * ERROR: sys-libs/glibc-2.22-r2::gentoo failed (configure phase):
>  *   failed to configure glibc
>  *
>  * Call stack:
>  *             ebuild.sh, line  133:  Called src_configure
>  *           environment, line 3268:  Called eblit-run 'src_configure'
>  *           environment, line  973:  Called eblit-glibc-src_configure
>  *   src_configure.eblit, line  263:  Called foreach_abi 'toolchain-glibc_src_configure'
>  *          common.eblit, line  363:  Called toolchain-glibc_src_configure
>  *   src_configure.eblit, line  258:  Called glibc_do_configure 'nptl'
>  *   src_configure.eblit, line  148:  Called die
>  * The specific snippet of code:
>  *      "$@" || die "failed to configure glibc"
>  *
>  * If you need support, post the output of `emerge --info '=sys-libs/glibc-2.22-r2::gentoo'`,
>  * the complete build log and the output of `emerge -pqv '=sys-libs/glibc-2.22-r2::gentoo'`.
>  * The complete build log is located at '/var/tmp/portage/sys-libs/glibc-2.22-r2/temp/build.log'.
>  * The ebuild environment file is located at '/var/tmp/portage/sys-libs/glibc-2.22-r2/temp/environment'.
>  * Working directory: '/var/tmp/portage/sys-libs/glibc-2.22-r2/work/build-x86-x86_64-pc-linux-gnu-nptl'
>  * S: '/var/tmp/portage/sys-libs/glibc-2.22-r2/work/glibc-2.22'
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ndtimofeev/gentoo-clang-db/commit/0f0838feca30d5577cb1353c32c6a70968b67e88#commitcomment-16275076

Post the config.log.

--
()  ascii ribbon campaign - against html mail
/\  http://arc.pasp.de/   - against proprietary attachments


OK. I'll make the change.


QuickFixIDD-Memos (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Could we remove this if we created a default listener that implements `TweetViewClickListener` interface?


typo, thanks.


+1.  Looks good to me.  My comments have been addressed.


Still need: reaper, redirection, built-in command support


Initially unchanged as of First Presentation


Please indent by 4 spaces.


Bitte
nutze
jQuery
Es ist kürzer, schneller zu coden, besser zu debuggen, weniger fehleranfällig, einfach zu verstehen, mühelos zu lernen, und löst die Probleme für dich. Du handelst dir nichts als Ärger ein wenn du auf reinem JavaScript baust. Nur weil man es machen kann, heißt es noch lange nicht dass man es sollte.


UrlUtils#appendToUrlQuery does this (see usage in ChangesRestClient#get).


QuickFixIDD-Memos (mjwitte) - x86_64-MacOS-10.9-clang: OK (2113 of 2113 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This shouldn't even really be in the translations.  It was my understanding the whole "copyright warning" screen for first time ROM usage was done away with?  The code should best be taken out of source to avoid confusion.


Minor: comment should be moved as well.  rbd test run passed, so ready to merge once updated.


On est pas tellement supposés laisser le choix de l'état de la transaction je pense, si ? Surtout avec le modèle simplifié où c'est juste un khube autoritaire qui décide tout, ça passe directement en 'C', et les autres états n'ont que peu de sens, non ?


Notice that on lines 46 and 47, you retrieve the same boolean twice.


That code runs in the UI thread, this no locking needed inside that method.


Users may (need to) have a user's machine-specific catalog.xml but our checked in catalogs should either be generic or be clearly parameterized so that each user can check out a useful file for themselves, yes?


@jvelasques please review


Please indent by 4 spaces (please also check the following lines).


OK. I'll remove all the kube system units. I'll assume managing non-kube unit files such as etcd, flannel, etc.. are still OK unless I hear otherwise.

Thanks for taking the time to review, I really appreciate it.


wrong version for openstack, shall be cloudbreak-2016-02-23


Qu'est censé signifier le `disabled` ? J'ai du mal à comprendre dans le contexte :/


Updated Prelim Requirements

[PreliminaryRequirementsUpdated.docx](https://github.com/taylorrowan/SoftwareEngineeringProject/files/143157/PreliminaryRequirementsUpdated.docx)


It is not intentional, I guess I was very tired or something..


"and used to implement" reads as "implemented in the past"


For wod encrypt it's :

strtoupper(hash("sha256", strtoupper($email)).":".strtoupper($password)));

(not verified)


WTF?


You seem to be saving more into the `Bundle` than is necessary. The value of `mAnswerIsTrue` will be available from the `Intent` and the textual answer can be recreated from it.


Can you please add one more tests which uses a combination of the diff-options (e.g. whitespaces and context)?


Souci d'indent ici


Which is the best one?


Feel free to commit the change. We probably should have tests for RoundTrip.
On Feb 23, 2016 12:01 PM, "Jacques Carette" <notifications@github.com>
wrote:

> That won't quite work: the ctx is a keyword parameter for improve and
> fromLO. A better change will be
>
> RoundTripLO := proc(m, {ctx :: list := []})
> lprint(eval(ToInert(fromLO(improve(toLO(m), _ctx = ctx), _ctx = ctx)),
> _Inert_ATTRIBUTE=NULL))
>
> [but the above is untested...]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hakaru-dev/hakaru/commit/11bd79e6759cba090921f2d0db238de5a37cda6d#commitcomment-16273489>
> .
>


Add ExpectedConditions.visibilityOfElementLocated


Hey! Thanks. I did notice that. I keep changing it manually in the files. I
think I just have to adjust my settings in Sublime.

On Tue, Feb 23, 2016 at 7:33 AM, Eliot Sykes <notifications@github.com>
wrote:

> @dcox <https://github.com/dcox> minor, but indents appear to be set at 4
> spaces or tabs for some of these files. Lets review the indent/soft space
> settings in the editor soon to stop these creeping in.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dcox/bloccit/commit/463b30e047db8ae4e664796b1c40c8e209b26c2b#commitcomment-16270948>
> .
>

--
Desiree Cox
Product Data Analyst
Zendesk


Letter 'eye' in `CanI` is easily confused with letter 'el'. Suggest renaming this.


Ah, ok, this helps. I wasn't sure if I was supposed to create a new
Post.new given that there's all the let(:post) stuff at the top of the file.

On Tue, Feb 23, 2016 at 7:44 AM, Eliot Sykes <notifications@github.com>
wrote:

> @dcox <https://github.com/dcox> if this is the failing test, note that
> post is already created (i.e. persisted in the database) before line 86
> post.save runs. As it is already created, the after_create callback won't
> run when post.save is called.
>
> Consider using post = Post.new(...) on the first line of the it block to
> get a not-yet-created Post instance.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dcox/bloccit/commit/048825854ba1c4432721491a9a121a82098c1a48#commitcomment-16271305>
> .
>

--
Desiree Cox
Product Data Analyst
Zendesk


`error_message` would be more appropriate than `invalid_message`. Also, I don't think `_text` is necessary (`message` implies that it's text).


Man this website is created for 3.3.5 the encription is right


"Xcode permite que você construa compilar para um dispositivo de destino executando o iOS." essa parte não fez muito sentido, precisa ser revisada.


we've seen that concatenating too many strings in this way has a massive compiler hit wrt timing due to a compiler bug (I believe there is a radar out for it somewhere). Do we want to take that into consideration here as this is a _lot_ of concatenation?


You can add this in the account_functions file with value... i will work on for resolve a registration and auth in the website and in the game :)


Specifically, renaming it `Check`. This will match docs such as APIary.


You got it.
function() to shorthand =>.
What I wrote was not very clear.  sorry.


:heart:


Pokud bude v analysis mozne nastavit project/workspace i jinak, nez ctenim ze souboru (napr. odnekud z kodu), tak je tady potreba pridat gettery a settery (`@property`, `@x.setter`) pro obe promenne, stejne jako to je v meconfigu.


auditors: @bbondy


develop (mjwitte) - x86_64-MacOS-10.9-clang: OK (1560 of 1560 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


"muitos desenvolvedores iônicos não usá-lo como" não seria correto traduzir Ionic ao pé da letra, pois se trata do nome da tecnologia. O correto seria "muitos desenvolvedores **Ionic** não usá-lo como".


removed temp files


Gotcha, that makes sense.

Apologies I didn't realize how it worked..I'm new to github and trying to help :)


You are right. I double pasted..

2016-02-23 20:14 GMT+02:00 Eric Pfeiffer <notifications@github.com>:

> How come you're calling whereRecipient(this) twice?
> Was this intentional or required? Looks like a typo to me.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hootlex/laravel-friendships/commit/ccf5021a7fd4d9e025d5d451320342f13d0b38cf#commitcomment-16275368>
> .
>


"Preocupado com seus projetos V1 iónico? Não se preocupe" novamente usando a tradução do nome da tecnologia. O correto seria "Ionic V1".


Were you able to solve the `DrmManagerV8.initialize:105 Can't load native drm library` that breaks Play Movies? I tried a bunch of MM Widevine blobs (including these), and they do fix YouTube purchased content, but not the other DRM issues. By the way, all these updated blobs seem to try L1 first, then fallback onto L3, when YouTube works.


I'm pretty sure [this](https://github.com/moto8916/android_device_motorola_msm8916-common/commit/158a9b82e6b4eafe0a26bf61bde0387170c39918) was the problem. Our GPS hal is really strange; looks like every change break it. We always had these kind of problems with it since osprey cm-12.1 bring up. I'm afraid in the future we'll have to ship it prebuilt from stock.


Exactly @pokonski ! And this syntax is much more clear than this invisible whitespace.


check my repo, this is fixed


This change breaks my setup when I spawn a docker image using Liberty, I am deploying another OpenStack cluster and pulled novadocker yesterday, any hints on a fix before I embark on debugging futher? My current traceback shows

<pre>
2016-02-23 18:10:11.975 4382 ERROR nova.compute.manager [req-6add2291-39b2-4637-a6a5-825486a1003a 502254a16d404ffd9b3d9f3d9dd41a6a ef0beabfb28d4b1984096796945a2cc9 - - -] [instance: 95d544ae-93d6-4892-b6f8-7ec0d5a9a14c] Instance failed to spawn
2016-02-23 18:10:11.975 4382 ERROR nova.compute.manager [instance: 95d544ae-93d6-4892-b6f8-7ec0d5a9a14c] Traceback (most recent call last):
2016-02-23 18:10:11.975 4382 ERROR nova.compute.manager [instance: 95d544ae-93d6-4892-b6f8-7ec0d5a9a14c]   File "/usr/lib/python2.7/site-packages/nova/compute/manager.py", line 2155, in _build_resources
2016-02-23 18:10:11.975 4382 ERROR nova.compute.manager [instance: 95d544ae-93d6-4892-b6f8-7ec0d5a9a14c]     yield resources
2016-02-23 18:10:11.975 4382 ERROR nova.compute.manager [instance: 95d544ae-93d6-4892-b6f8-7ec0d5a9a14c]   File "/usr/lib/python2.7/site-packages/nova/compute/manager.py", line 2009, in _build_and_run_instance
2016-02-23 18:10:11.975 4382 ERROR nova.compute.manager [instance: 95d544ae-93d6-4892-b6f8-7ec0d5a9a14c]     block_device_info=block_device_info)
2016-02-23 18:10:11.975 4382 ERROR nova.compute.manager [instance: 95d544ae-93d6-4892-b6f8-7ec0d5a9a14c]   File "/usr/lib/python2.7/site-packages/novadocker/virt/docker/driver.py", line 527, in spawn
2016-02-23 18:10:11.975 4382 ERROR nova.compute.manager [instance: 95d544ae-93d6-4892-b6f8-7ec0d5a9a14c]     image = self._pull_missing_image(context, image_meta, instance)
2016-02-23 18:10:11.975 4382 ERROR nova.compute.manager [instance: 95d544ae-93d6-4892-b6f8-7ec0d5a9a14c]   File "/usr/lib/python2.7/site-packages/novadocker/virt/docker/driver.py", line 383, in _pull_missing_image
2016-02-23 18:10:11.975 4382 ERROR nova.compute.manager [instance: 95d544ae-93d6-4892-b6f8-7ec0d5a9a14c]     LOG.debug(msg, image_meta.name)
2016-02-23 18:10:11.975 4382 ERROR nova.compute.manager [instance: 95d544ae-93d6-4892-b6f8-7ec0d5a9a14c] AttributeError: 'dict' object has no attribute 'name'
2016-02-23 18:10:11.975 4382 ERROR nova.compute.manager [instance: 95d544ae-93d6-4892-b6f8-7ec0d5a9a14c]
</pre>

Running on CentOS 7, and did not have this issue a month ago.

Thanks


Summary of changes:
- use usProperties class instead of usServicePropertiesImpl class.
- added a constructor to create a "Properties" object with a std::map


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16866](https://teamcity.mesosphere.io/viewLog.html?buildId=142412&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:03:45


What purpose does this file serve?


For others reading it: FEATURE_OIC was put because the current state of upstream RIOT is so that we have identical cbor.h headers both in the OS and tinycbor (and the former gets read first, thus breaking the build). We'll eventually fix that, but as of now OIC is broken on it.

:+1:  for the patch


@fdefalco is there a reason to use protocol relative URLs here rather than always https?


should this class have a private constructor?
It's not an important detail but I'm surprised that checkstyle didn't raise it.


& otherwise?
We could imagine doing Sync via S3XML/S3JSON or even XLS


I didn't understand your question


I might change this so it doesn't take the context, but would require the caller to assign iterator before the call.


Consider squashing this commit into the one that these files were added before merging.


Approved. (if you want - add poky fido versinn in commit log)


Approved


Nice to see the redesign makes this simpler :)


Don't bump versions in PRs, please.

Up to the maintainer to bring in changes and bump the version appropriately at time of release.


Правильно ли добавлять код в продакшн ради тестов?


Hi,
the program works very well on a 64Bit windows.
Is it possible to get an 32bit installer?
thanks


Got it.


@oberon2007 and @udeved , @philmmanjaro . I try now the use of user.js .. it overwrite the chrome folder so the menda theme is saved ;) . I think if a theme ( exemple arc-theme-firefox ) contain the ff settings it (user.js)  override the chrome folder shared . The bookmark folder is ok it remain in shared .
So how to provide this file ?


Is it not possible to do the check as a single JOIN query?


Sure I will fix this.


Am not sure about the fallback here?
Can name be None ever?
I assume not, and hence a missing name would mean "don't bother doing a dedupe', no?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16868](https://teamcity.mesosphere.io/viewLog.html?buildId=142417&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:08:50


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16867](https://teamcity.mesosphere.io/viewLog.html?buildId=142416&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:08:55


@selwyntcy, I've merged @NateWr's fix, so the master branch should now be working.


@akainic  indentation here seems funky.


@JohnyDays reverting https://github.com/facebook/react-native/commit/f5144094955a0099d57bf3ad1439a376f46bce48 should just work on Android


Also, I need to understand how modules are called because if the are called via scan_blocks then they will invalidate the iterator which would be broken.


or could be `int retval = ....`


Should we restrict access to this controller from only XHR clients that accept json as the response type?


QuickFixIDD-Memos (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1005 of 1005 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-29.0%25-green.svg)


I misread the code, but the problem remains: counter isn't being reset. I think that would fix it; I recommend making a list (or even better, issues in github which you can label to make organization easier) of things to test when you get to competition because you probably won't have time to test stuff like this tonight.


Remove unused file attributions, add attributions for new images (mousejack.png)


QuickFixIDD-Memos (mjwitte) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Why is there a need to check the WKT? This is slow/expensive & so last resort.
Here we /should/ be able to dedupe just on location_id....if not then we are creating duplicate gis_location records anyway which will be cluttering the database...so better to solve that in the gis_location deduplication rather than sweeping it under the carpet here


packages/apps/SetupWizard/src/com/cyanogenmod/setupwizard/setup/CyanogenSettingsPage.java:206: error: cannot find symbol
        policy.addToPreconfirmWhiteList(cn.getPackageName());
              ^
  symbol:   method addToPreconfirmWhiteList(String)
  location: variable policy of type WindowManagerPolicyControl


This is a wealth of information to return.  How confident are we that we can return all of it in most case for most storage back-ends?


according to comment

>  Set exit status if one of vcpus returns error code > 0

so there is no need to check it after first fail - `break ` or `return `could be handy


Ew yeah, didn't look like that for me in my text editor, I will fix it!


> No need to wait **for** me ...


None of the .idea files should be checked into your repo.
Add a gitignore to your project and github will no longer add these files automatically.
https://help.github.com/articles/ignoring-files/

See an example of one here - > https://github.com/mainstreethub/task-api/blob/master/.gitignore


should change spacecoin -> spacemint


@grayjay Looks like the version of `cabal-install` that comes with HP 2014.2.0.0 doesn't support `--allow-newer`. Can we do something about that? There's a newer Windows binary at https://www.haskell.org/cabal/release/cabal-install-1.22.0.0/cabal-1.22.0.0-i386-unknown-mingw32.tar.gz.


Yes, I've added some unit tests and fixed this as well as a few other minor things.


Consider "Take a look at this picture I am sharing with you:"


Also take a look at:

https://github.com/slim-template/slim#trailing-and-leading-whitespace--


QuickFixIDD-Memos (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2151 of 2151 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Type: sudden power loss.

We do need to be careful as some devices are starting to come out with non-volatile caches.


113107773-Improve-waste-heat-function-handling-of-AirloopHVACUnitarySystem-#5222 (lgu1234) - Win64-Windows-7-VisualStudio-12: OK (2120 of 2120 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Does this whitespace render the way you hope it does?


Are you aware why the test broke?


@stonean even better :+1:


QuickFixIDD-Memos (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (2119 of 2119 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Any reason why you keep the brackets?


辛苦 ys 菊苣，

这里有部分需要修改一下：
![image](https://cloud.githubusercontent.com/assets/1846356/13262519/35b4ffa4-daa0-11e5-83a7-ed84316fc2f6.png)

这个边上一般不是用固定宽度 + text-overflow
在右侧工具条上加同色横向渐变背景，这样能保证文字能有足够长度和渐变隐藏
另外，单个种子行的宽度保持和首页的一致，以及评论的样式参考一下 cd 菊苣新提交的首页上的样式~
注意以后在用户为当前用户的时候才显示（不过前期先不管吧，测试用）


Shouldn't this be "check with the vendor of your SSD." ?


Awesome, its working for me!
Why not merge it into the main repo?


What does `image_tag` do in a text email?


Same question as above


This is a new (or newly documented) feature and was not present when i filed that PR


how come this is `CommCareCaseSQL`?


#include <bits/stdc++.h>
using namespace std;

int main() {
	long long int t,i,j,k,l,m,n;
	cin>>t;
	while(t--)
	{
		cin>>n;
		set<long long int> x;
		set<long long int> y;

		x.clear();
		y.clear();

		for(i=0;i<n;i++)
		{
			cin>>j>>k;

			if(j>k)
			continue;

			l=x.size();
			x.insert(j);

			m=x.size();

			if(l==m)
			continue;

			else
			{
				l=y.size();
				y.insert(k);
				m=y.size();

				if(l==m)
				x.erase(j);

			}

		}

		k=x.size();

		cout<<k<<"\n";

	}
}


Cool, thanks


Why delete content?


Why deleted this lines?


Why the distinction with `volume_ram_cache_info` and not generically with `volume_cache_info`?  It is your intention to handle SSD cache reporting differently?


maybe `of the statement`


Are these now dimensions rather than glue?  If so, `grerubberpermit` needs to be adjusted and all usages change from `gre@space@skip@...` to `gre@space@dimen@...`


This shouldn't be checked in either


@FeeJai yeah, pretty sure this feature came after your PR. (now looking at the date)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16870](https://teamcity.mesosphere.io/viewLog.html?buildId=142500&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:12


I think this sentence needs to be reworked.


Nevermind, I see that you remove it later.


I think we should word this "Macintosh" not "mac".


Well, I still want to give a preview of the image I am sharing. Is it proper to do it in the text email?


Or this


This patch is very nice, however tauto depending on `Coq.Init.Logic.not` will again harm to HoTT folks and other people wanting to use Coq with alternative stdlibs. Ummm.

For ML code I have some proposal at the `coqlib-cleanup` branch ejgallego/coq@3d165a45, but dunno how to do for LTAC.


We put our dependencies in alphabetical order


Actually error handling is exactly the same as WindowsError extends IOError - the only difference is that we now will see the `deprint(_(u'Failed to calculate crc for %s - please report this, and the following traceback:') % asFile, traceback=True) ` message instead of `deprint(u'Unable to get crc of %s - probably a unicode error' % self._s)`. Btw the try comes from ea3cad209903bec4228b1fc3e2f5c2aaa5e2c26e and seems related to "unicode mode" - I guess this is the default now


I know I suggested you add this, but given your comments about what's valid in a header, is this still valid?


What about volumes of SAN devices?  Isn't is possible that they have cache settings too?  Just wondering if we need to limit ourselves to state that this is for RAID controllers.


Because I forgot to change the errno code in the test. I fixed it locally.


I was going to make a similar comment, but realized that because the inside syllable ones are still skips, the way the reference to these distances is built up using `\csname` requires them all to be skips.


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


O have turned hot reload on IOS developer menu, but it doesnt work. What am I missing?


In order to help ensure that our managed code assumptions like this stay in sync with what's actually defined in native, we have a scheme whereby we add a corresponding value to our pal_* files and then static_assert that it matches the real one.  Could you do the same here?


Yes, but based on your comment on that commit, I squashed the removal to this commit


@srisurya95 why
this will force XT1033 to single sim
line 143


What about the distinction of write back vs. write through cache policy?


Is there a feature/integration test that can be written to verify this code?


it looks like this line is causing
Uncaught exception TypeError: Cannot read property 'streams' of undefined(…) at some assets.


should be ="dsds"


Зайвий тесткейс.


Can you add documentation for the two different `Cost:` lines.  For example,  I'm not sure what the `%` is... is it CPU of the stage or the whole query.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16869](https://teamcity.mesosphere.io/viewLog.html?buildId=142467&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:03:26


> This would likely break other systems that have rt5645, right?

Yes, but this was meant to be a temporary fix

> Can you point out exactly what should be changed in the EF20 BIOS to fix this properly?

Looking into it


You don't use any setters here (Which is good practice, we try as hard as possible not to use setters because it gets really messy with concurrent processes.) but that also means all these should be final. Try to use as much constraint and strict visibility as possible. Eg. private instead of protected etc.


If someone were to put in a rubber length, does it destroy the output?  If it does, then perhaps we need a special check for things that are defined as glue but still don't allow a rubber length?


Great!
r+


To make sure the rest of the application is safe, you should do some checks here. A common one is checkNotNull(). You want to fail fast, and creating the object is one of the first things that happen.

See here for more examples ->
https://github.com/mainstreethub/task-api/blob/master/api/src/main/java/com/mainstreethub/task/Assignee.java#L22-L24


I'm not sure we need to explain what write caching is in our documentation, unless we are defining terminology.  However, in this case you are describing `write back` not `write through` caching.


Perhaps a missing language string in /lang/en ?


best change!


Do you mean the first one before `AppFolio`? I guess it is a typo. I will fix this..


I have my android project, but the react-native libraries as imported as binaries (as far as I can see). There is no reference to those files in the file-tree (the react-native library java files)


I don't know where this code is used, but I can tell it's browser code.  This information will be scrapable by clients.  If we can get by without any serious security risks, I'm ok with this, but there are good design patterns to prevent this from being exposed to the client.


Dhru, this looks great. Everything works as expected. There is one more requirement to be met: The form should also be submitted when you hit enter/return, so the user has the option to click or hit the enter key to build a tree. Let me know if you need a point in the right direction to make that work.


I think that too. checking the checksum file is an overkill


connection.close(); closes our main database connection :rabbit:


All commits now completed, this should take the Navbar fully modular; https://github.com/gburton/Responsive-osCommerce/commits/ModNav


That's only a first pass. Making HoTTists happy is not my main goal, though, even if this will potentially makes their life a little bit easier. I'm more trying to disentangle the relation between Ltac and the remaining of Coq.


Again, why should this be limited to RAID controllers?


BTW: Ios is working like a charm :+1: been using it this afternoon, only getting some minor warnings.
Although, if I have HMR enabled in my iOS app, the android "Live Reload" option seems to stop working (for the same packager instance)


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1579 of 1579 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Always sign the ISO file. The user can then decide if he wants to check the signature or the checksum.


This error failed spell-check validation :wink:


LGTM


Resolves #12


good commit


setTimeout takes a function as a parameter.  This could be written as `setTimeout(getScores, 3000);`

I'm guessing you tried this, but put the parenthesis after the function name, which causes the function to be called (Important thing to keep in mind because it's a useful thing to use in other places).


Please explain "AL" in the constant.


Age 53 a newbe,please feel free to make your advice heard.


I believe it is possible to put relative paths into the catalog file, which would make it usable by everyone. I'm pretty sure that Protege won't do this automatically, so it needs to be manually corrected.


develop (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1563 of 1563 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


What about `write back` vs. `write through`?


Rename this `finishing` or `flushing`


Oh as the commit message says, it crashed if you deleted a language then deleted the language beneath that first one. Yes it's happening on master.


Style: Switch statements are generally considered Swiftier than else chains I believe.


@vaa25 какие есть альтернативы? Можно создать отдельный класс `MockDataTimeUtil`, который будет замораживать время, он будет только в тестах.


Don't use the hardcoded value here, use the 'privateBucket' constant.


Reverted with a300acd2999a9afbe41a4713a8a1e57741e5d94e


Also, the timeout is fairly arbitrary.  It would be better to use promises to force this process to be synchronous if you're not going to use the ajax callback for updating (both solutions would have been a bit more graceful I think)


GitHub diff is not displaying the renames effectively.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16876](https://teamcity.mesosphere.io/viewLog.html?buildId=142519&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:00:10


Capitalize the first letter for 'serve' to 'Serve' .


Why would the output in this example be `0`?  This query should produce output.


Customized Command Processor for IRTriage.
Found that using MS versions would not work from one Windows edition to the next.


git spackt rum


lgtm


Do you need to count the output size for reporting on the last stage?


Just a pointer, javascript will create this variable in the loadLogs function scope (not this while loop block).  This is called variable hoisting and can create confusion if you don't know it's happening.  I find it makes code cleaner to declare variables at the beginning of their scope.


That's not true. Older versions are available. We list all versions here http://groovy-lang.org/changelogs.html and link to Bintray or Maven Central, as well as providing docs for older versions. I think we should keep the warning.


@dthree There's a module for this you know https://github.com/sindresorhus/user-home ;)


I can see your pictures just fine.


This class is in api/ which means it's also accessible to the client. Everything accessible to the client (over-generalization, but for now) should be json de/serializable.

See all the @JsonProperty and @JsonCreator annotations? You should have these in here as well.
http://wiki.fasterxml.com/JacksonAnnotations
Here's some rundown on the annotations and what they mean. You'll need to import the jackson dependency into your pom to use it.
https://github.com/mainstreethub/task-api/blob/master/pom.xml#L117-L121

That jsr310 module you see is to add some of the java 8 things like Instant. You probably don't need that yet, but you'll see it everywhere else.


@bgerstle

Good points! I'll poke around a bit...


Yes.  We are working on another project that will allow us to get the final stats.


Debug code?  Might remove it if it is.


that would be good... but I prefer to focus on the final bugs and improvements before rc2, maybe it could be done afterwards or in 4.1.1


age 53, please feel to instruct me.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16873](https://teamcity.mesosphere.io/viewLog.html?buildId=142517&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:03:46


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16871](https://teamcity.mesosphere.io/viewLog.html?buildId=142513&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:04:01


I guess "check" can be a little ambiguous. What about `isPatchSupported` then?


remove


@dthree And for `cwd = cwd.replace(home, '~');`, see https://github.com/sindresorhus/untildify


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16874](https://teamcity.mesosphere.io/viewLog.html?buildId=142518&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 174 Build time: 00:04:41


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16872](https://teamcity.mesosphere.io/viewLog.html?buildId=142514&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:43


mhh, yes, this is using the latest scripts. Something to check.


The original formatting makes the tests easier to validate against the origin spec.


Does the output 3V3 from LM317 is intended to be connected only to led LPWR ? (just to show if the Power on Car is present)


Credits go to @sreichel, see #11
and
https://github.com/kalenjordan/custom-reports/commit/ed66296a1298b3c76e21f0dc3de0d23a3a642ba1
https://github.com/kalenjordan/custom-reports/commit/7e1e35eaf2fc23483ee733f6a80477610555aef9


Just a note for when you get around to making this app Python 3 compliant:

Python 2 uses the notification 0077. Python 3 uses then notification 0o077 (sic!). However, both know how to make make an `int` from a string with octal notation: `int('0077', 8)`.

And I suggest that to reset the umask to its original value once you're done:
```py
    old_umask = os.umask(int('0077', 8))
    with open(confighome, 'w') as f:
        config.write(f)
    _ = os.umask(old_umask)
```
Cheers.


indented to far


remove these numbers


fix spacing


I couldn't see the rest of the expression, but for deep-object access with checking, I usually use lodash.get.  it would look like this...
get(plotGroup, 'plotGroupId.lockRelated', _optDefVal);
It takes care  of all the null checking and return an optional default value if supplied with one.


Oh indeed, let me rephrase my comment: "It would be nice if `Coq.Init.Logic.not` was not hardcoded in Tauto.v"


On the www.ev3dev.org page I see the project name as 'ev3dev' and not 'EV3Dev'.


Thanks!


https://github.com/sindresorhus/globby ?


these should be inside a describe bloc...


these should be inside a describe bloc..


there's a typo in the classname


Then the method should be annotated `@Nullable`.


Optimistically*


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16875](https://teamcity.mesosphere.io/viewLog.html?buildId=142520&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:07:54


@romach you can ask our teamlead about it


https://github.com/sindresorhus/array-shuffle ?


TODO Fix Increment


LGTM


Remove :-1:


Why not return a default implementation which takes the first field of a message?


All the objects in api/ are public so they should have hashcode, toString and equals.

See here
https://github.com/mainstreethub/task-api/blob/master/api/src/main/java/com/mainstreethub/task/Assignee.java#L40-L65


https://github.com/chalk/strip-ansi ?


fixed 6f5044ab1a10a2f8be6cd271f4b9c31f629b61ae

thanks


Return of `null` isn't seem to be tested.


I'm not sure if I like that the user of `SRPAuthMechanism` needs to know about the `srp` library by returning `srp_user`. I see it's used by `Session` to see if the user is already authenticated.

I think I would change this class to handle only one authentication per instance. Convert this `initialize` into a `__init__` and keep `srp_user` as a private attribute to the class. Then we can implement `authenticated` as a method of this class.


Remember to not pass literals. Wasted hours : 3


Needs corresponding commit in msm8226-common fixing permissions on /dev/radio0


Hmm, looks like I;ve fixed one problem only to cause another. With this commit, line 674:
```
     sum += spec [(int) this] ;
```

was causing an out-of-bounds memory access because `this` was equal to `speclen`.


Why did you adapt this test? Is it because for now we give up on dealing with "." as separator?


remove number


I don't have strong opinions towards this. I can concatenate each case into one line if you feel like that way. I'm just afraid that will be too long.


@akshaysngupta Why didn't you rebase this commit on top of latest?


Do thorough testing of this function. Stack in common bits together


wayyy too much in there.


`@Nullable`?


Ez nekem törlésnek tűnik, nem frissítésnek :)


... huh. okay. Thanks.


Why are you overriding these?


This transpiles to:

```javascript
_emberMetalDebug.assert('calling set on destroyed object: ' + (obj.toString ? obj.toString() : '') + '.' + keyName + ' = ' + value, !obj.isDestroyed);
```

and throws a ```TypeError``` if ```value``` isn't convertable to a primitive type (e.g. it's an ```Ember.Object```).


So the structure we use for testing objects can be seen here
https://github.com/mainstreethub/task-api/blob/master/api/src/test/java/com/mainstreethub/task/AssigneeTest.java

The main areas are constructors, getters (Which you have some of here), hashcode, equals, and serialization/deserialization. We find a decent number of production bugs in these areas so it's really important to test them all, especially the serialization ones. Those are the most commonly overlooked.


If you get a minute or two, see if there's a auto-format tool with your IDE so the indentation stays uniform.  Not critical, but it does help others look at your code.  Also, if you can specify that tabs are replaced by spaces, that would be awesome too.


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1005 of 1005 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-29.0%25-green.svg)


Shouldn't have any of these /target files checked in either.


I prefer GlobalConnect here.


No .iml files checked in.


Hi Travis,
Thanks for catching this. Can you change the links to be relative and include .md?  This helps with branching and navigation on GitHub.
Please change to:
[example language server](/docs/extensions/example-language-server.md)
[Extending Visual Studio Code](/docs/extensions/overview.md)


I'm seeing this in Chrome, BTW


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Yep -- on a non-admin blog we get "You do not have the capability to manage sharing buttons for this site" error here.


I think this should be annotated `gs_unref_keyfile` so it doesn't leak.


Only pom.xml, no dependency-reduced-pom.xml should be checked in.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16879](https://teamcity.mesosphere.io/viewLog.html?buildId=142546&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:03:57


I think this should be annotated `gs_unref_hashtable` so it doesn't leak.


Again, alphabetize. Also (nitpick since i know this is still a work in progress), but whenever submitting a pull request there should be no commented out code.


ah... sorry


LGTM


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16878](https://teamcity.mesosphere.io/viewLog.html?buildId=142545&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 238 Build time: 00:04:43


I'm having some doubts on how much the user of this class needs to know the details of the srp protocol. But seeing the only user is `Session` and basically this is all that it does, I think it's fine.


Dagger this (I know you're working on it.)


Of course the documentation/changelog is available, but I can not find any direct download links. Did I miss then?


Should be package tictactoe


It would make more sense to arrange the popup like this:

```
Actions
 s Stage        d Diff         b Blame
 u Unstage      l Log          p Find blob
 c Commit
```

using

```lisp
  :actions '((?s "Stage"     magit-stage-file)
             (?d "Diff"      magit-diff-buffer-file)
             (?b "Blame"     magit-blame-popup)
             (?u "Unstage"   magit-unstage-file)
             (?l "Log"       magit-log-buffer-file)
             (?p "Find blob" magit-blob-previous)
             (?c "Commit"    magit-commit-popup))
```


The multi threaded test is useful, to get an impression of how a container performs in a multi threaded environment compared to a single threaded environment.
Why 2 threads? I can't remember, but if you like you can increase the number and execute the tests.
When I update the benchmark the next time, I will add machine details to the report (I always used the following machine: Intel i7 M 620 @ 2.67 GHz, 8 GB RAM).


Ok. The new version is more readable.

However, I still suspect that the code might be too liberal with respect to the input it accepts. Maybe it should be specified by the user of the module whether the input is a JATS record embedded in OAI element or a standard JATS document? In such case, an exception would be thrown if the document doesn't match given specification. Would such an approach make sense here (it certainly wouldn't make sense if both types of documents were mixed together)?


Nice use of annotations here!
You can see a clean example of this here
https://github.com/mainstreethub/task-api/blob/master/application/src/main/java/com/mainstreethub/task/TaskApplicationConfiguration.java


oh GC means garbage collection here?

i prefer "isStaleNetwork"


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16877](https://teamcity.mesosphere.io/viewLog.html?buildId=142521&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:07:29


what's CSN?


nice


There is typo in canola oil spelling.


@windwiny There shouldn't be any new minor version of Racc; once all the planned improvements are made and it is thoroughly tested, the next release will be 2.0. Since that will be a new major release, I'm not very concerned if there are some small changes in the CLI options.

I personally never found the text output of parser states very useful. Do you use it?


ok


Thx bro


This method has been renamed in the commit
https://github.com/AppFolioOnboarding/Li_Image_Share/commit/7fab22fda627b5e4967583237dfd6e0711e3caee

>


That's not what I mean. Even if we don't provide direct links (we don't), we still make it pretty clear the world existed before 2.4.5 (the first release before Apache). Without such a warning, there's no way to know what versions were officially supported by the foundation. I think we should keep an explicit warning.


@mattleff review please!


May be better '== value.to_s' ?
Because, for example, maxLength on record is an integer in Twilio's docs, so it was raising an error on my specs and I had to convert the attribute in the test, but this is just a workaround.


tic-tac-toe not helloworld.

There's a lot of tricky rest URL conventions that go into creating URL's. It's not super important for you to learn them now, but be aware they exist. Once you start creating a real project, you will be asked to adhere to a standard for the ease of cross team integrations.
Here's a rundown of some of the basic concepts.
http://www.vinaysahni.com/best-practices-for-a-pragmatic-restful-api
Again, don't worry about it much now, but know it exists.


Style question: Any reason to use setObject() rather than dict[key] = value ?


Это хуйня


develop (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1563 of 1563 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ah, glad you are there Stéphane !

I'm really not good (or patient enough) to tweak parameters.
Also, I just realised yesterday that most of the time, this initiative bonus is...negative.
I'm a bit confused about this.

So if you want to take over, I will be glad to give you the driver seat.


**Shortlog of HEAD commit is too long.**
*GitCommitBear, severity 1, section `commit`.* *Project wide.*


out of curiosity, what was the reasoning behind switching to using `--prefix` from `--index` ?  Can we use multiple `--prefix` options?  The documentation only makes mention of `--index` being able to be used in that way...


@MikereDD
I'm guessing that you're building for shamu by yourself.
No offence, but there's something called "Bringing up a device for a specific ROM" part wile building a ROM which I definitely can say you haven't done.

Wait until we have done settling the whole ROM and done testing builds for core devices (Yes, the Nexus lineup).


Iirc RPG_RT only adds the inventory of the active actor... But will check again.


I usually use `cmake -Dfreenect2_DIR=$HOME/freenect2/lib/cmake/freenect2`. I feel installing to `/usr/local` is bad for maintenance. Several choices:
* Remove this PREFIX=$HOME/freenect2 here
* In iai_kinect2 README, mention cmake libfreenect2 with PREFIX=/usr/local
* In iai_kinect2 README, mention cmake iai_kinect2 -Dfreenect2_DIR=$HOME/freenect2


**HEAD commit has no message.**
*GitCommitBear, severity 1, section `commit`.* *Project wide.*


Why are you using AtomicLong? Not saying it's incorrect, just curious as to your reasoning


Private


@sgress454 I'll dig around to see what we're doing in the other related modules and push up something real quick


Couldn't that just use `a::get($this->modules, $type, array())`? I think this would be easier to understand.


Haha x)


Approved.


this.board = Lists.newArrayList();
Guava, also you should initialize this here to avoid complexity later one. Eg, do I have to call a method first before calling another method because this ArrayList isn't initialized?! Easy, initialize it in the constructor and you don't have those issues.


It is called only once either in the ```if-block``` or the ```else-block```. But your suggestion is still correct, I moved code duplication into a variable. Thanks!


I think it's okay as a temporary hack.  "new" doesn't create a database object, it's medium-lightweight.  I'll wrap in the model, though!


Yes, thank you, I've been working my way through that as well.


We have encountered the same issue today.  We're using [UglifyJS2](https://github.com/mishoo/UglifyJS2), which isn't minifying two consecutive IIFEs correctly.

```
$ echo "(function (window) { console.log(window) })(window)
dquote> (function (window) { console.log(window) })(window)" | ./uglifyjs
(function(window){console.log(window)})(window)(function(window){console.log(window)})(window);
```
Note that uglifyjs does not insert a semicolon.

I think this is a bug in UglifyJS.  I'm going to scour [the issues tracker](https://github.com/mishoo/UglifyJS2/issues) for anything related.


Style: If this is only assigned in initializer it can be "let" not "var"


Thanks for your input. If you wanted all the functionality of what it does, it would be that ~1000 lines of code. If you try to do the same manually, there’s no guarantee that it works. Depends on whether you have a pre-2015 Mac or not, a multi-slot enclosure or not.

Of course there is code that is not very important. For example a secondary screen scrape method for downloading the driver from Nvidia if the primary one fails. And I’ve “encrypted” some nvram values - that’s like a fingerprint, mainly for displaying my copyright notice.

Regarding AddBoardId function, take a look at this thread:

https://www.techinferno.com/index.php?/forums/topic/6772-which-tb2-macbooks-allow-monitors-to-be-used-on-nvidia-egpus-in-osx/&do=findComment&comment=120034

The script executes this part only if it’s necessary.


super.onResume or super.onStart


Ejnye.
Bocs.


Good prose although it could use a tab's worth of indent (lines 29-37)


thanks sir!


is `explicit` needed here?


@thewtex Do you know a way to set all of the scalars for a VTK volume at once? Right now I use Numpy for the pixel intensity addition (<<1 second) but Setting the tuple values for the output image is still slow (~30 seconds)

I am using the SetTuple1 command on a (vtkUnsignedCharArray) called outputImageScalars to define pixels in the output volume.


I don't like this forloop being in your constructor. I'm not going to go much into it, but this makes me wonder. Are you using the best List type for this problem? Are you constructing it in the correct way? In general this is a red flag to me that the design should be looked at more. Again, since this is a test project I'm not going to dig into it, but something to think about.


Something feels eerily wrong here.
1) compare `diffie_hellman_sha1` and `diffie_hellman_sha256`; is not there exactly same problem in sha1 variant?
2) if I was not mistaken, this is generation of "private exponent"; but "private exponent" need not be as large as group order! Normal size is "twice as generated key material", that something from 256 bits to 512 bits for usual symmetric key sizes, see rfc4419 section 6.2 (Private exponent).
That is, it was, indeed, about 2 times too small before (and still wrong for `diffie_hellman_sha1`?), but it is more than 4 times too large now. (Well, at least later is only performance issue).
Disclaimer: I'm not real cryptographer, but only playing one.


pyBAR_fei4_interpreter version 0.1? The latest is 1.1.1?


The `/** @} */` pair is no longer necessary since there's only one function attached to the javadoc comment.


Thanks for the pointer! This really helped out my speed quite a bit.

Changes: ef99210085e0fb550933f5ce2324e7ec91e1c266

Speed Improvement: 625ec4a5f298e9d8f2d479458c40e8cec4d4746e


I would actually send a plain text email to yourself and see what occurs and see if that's what you expect.


Don't need the grouping meta comment


o.k.: https://github.com/groovy/groovy-website/commit/08b3c53ba6123b9eb6d8cb98fa58e8892a5aa67d


bruh...


Do you know what this timed annotation is doing?

Also maybe this is just the design, but it seems to me like this should have some sort of url param.
  @Path("/move") or something along those lines


The comment is now no longer applicable since we removed the parameter


Conf call conclusion: generalize this solution resetting the value in a common layer.


I don't know that its "unfortunate". Also spelling (`WrappedSing`)


@resendefreitas o comportamento esperado:
- até 1s: não exibe loader
- entre 1 e 10s: exibe loader simples
- 10s+: exibe loader com mensagem


Why do you have two resources? It seems like they should all be under one tic-tac-toe resource.
Generally we split up resources by high level URL. So for example ....
twitter/location/1234
facebook/location/1234

There would be a twitter resource and a facebook resource. But if there was just
tictactoe/move
tictactoe/create
That would go into one resource.


should be `make sensei`.  will fix myself


You could just do `$input["is_ascending"] ? Criteria::DESC : Criteria::ASC` for [this](https://trello.com/c/qudHRoDL/783-igivesda-offering-appeals-module-app#comment-56ccadb2afddec33d47a2ccc).


`id` is planned for deprecation: https://github.com/node-machine/machine/blob/master/lib/Machine.build.js#L315

so I'll add a telltale in there (like we use for switchback)


Removing the `-v` seems good.

@ellismg `dpkg-query` seems to interpret it's input as a glob automatically, so I don't think that would be necessary.
from the docs:
```
 If the first character in the filename-search-pattern is none
              of ‘*[?/’ then it will be considered a substring match and
              will be implicitly surrounded by ‘*’
```

In looking at this I stumbled upon another limitation though.
```
> dpkg-query -S libunwind.so.8
dpkg-query: no path found matching pattern *libunwind.so.8*
```

It seems dpkg-query also only searches installed packages.

It appears `apt-file` may be the correct tool to use here.
```
> apt-file -l search --regex .*?libunwind.so.8
libunwind8
```


README.md needs to be adjusted.


Approved.


What was wrong? Seems ok here.


This looks good to me. Thanks!


Is this different from the default copy constructor?


This should just be the name, i.e., `offering-appeals` (see [here](https://github.com/SimpleUpdates/SUFramework/blob/master/class/SF/system/controller/twig/template.php#L60)).


Hi @gajus this gives me problems when using React-css-modules in IE9. I'm not sure if it is just me not getting the right transform plugins up and running (in that case, sorry for the spam), but otherwise you might consider using some IE compatible code here.


Is there an advantage to this type of closure vs. [Set::Scalar](http://search.cpan.org/~davido/Set-Scalar-1.29/lib/Set/Scalar.pm) each function? Then the items are never lost as they are shifted off here.


I don't know that its unfortunate. Why can't this use the class from beast?


Perfect


This way of constructing the promise chain was selected, because some of the unit tests presume immediate execution of $http(httpConfig). Since this patch would add a preflight promise that would have to resolve before the $http request is sent, I wrapped it into an if statement to maintain backwards compatibility.


@carlbrugger :+1:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16880](https://teamcity.mesosphere.io/viewLog.html?buildId=142577&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:44


So this is not really a health check, a healthcheck is just making sure the service is up.
Here's an example. See how it's just checking to make sure that the DB's are all connected and everything is up?
https://github.com/mainstreethub/hubmail/blob/master/web/src/main/java/com/msh/hubmail/struts/action/health/HealthCheck.java

Something for yours might be just to call something in your application and make sure it's set, or a resource can be called regardless of what it returns.


I thought it might be intentional so that the signature was indented. That's fine, however, whitespace is ignored in HTML rendering so you'd have to use something like ` ` if you actually wanted to have a space there.


no extension