@ebrehault Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/24//violations
```
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/content.py Imports are incorrectly sorted.
src/plone/api/content.py:0:1: I001 found unsorted imports
src/plone/api/content.py:98:13: Q000 Remove bad quotes.
src/plone/api/content.py:99:13: Q000 Remove bad quotes.
src/plone/api/content.py:100:13: Q000 Remove bad quotes.
src/plone/api/content.py:268:1: C901 'delete' is too complex (15)
src/plone/api/content.py:300:25: Q000 Remove bad quotes.
src/plone/api/content.py:322:25: Q000 Remove bad quotes.
src/plone/api/content.py:360:1: C901 '_wf_transitions_for' is too complex (12)
src/plone/api/content.py:454:17: Q000 Remove bad quotes.
src/plone/api/content.py:455:17: Q000 Remove bad quotes.
src/plone/api/content.py:482:17: Q000 Remove bad quotes.
src/plone/api/content.py:521:13: Q000 Remove bad quotes.
src/plone/api/content.py:522:13: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/env.py Imports are incorrectly sorted.
src/plone/api/env.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/portal.py Imports are incorrectly sorted.
src/plone/api/portal.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/user.py Imports are incorrectly sorted.
src/plone/api/user.py:0:1: I001 found unsorted imports
src/plone/api/user.py:70:13: Q000 Remove bad quotes.
src/plone/api/user.py:71:13: Q000 Remove bad quotes.
src/plone/api/user.py:357:37: Q000 Remove bad quotes.
src/plone/api/user.py:400:37: Q000 Remove bad quotes.
src/plone/api/validation.py:20:13: Q000 Remove bad quotes.
src/plone/api/validation.py:21:13: Q000 Remove bad quotes.
src/plone/api/validation.py:22:32: Q000 Remove bad quotes.
src/plone/api/validation.py:66:21: Q000 Remove bad quotes.
src/plone/api/validation.py:67:25: Q000 Remove bad quotes.
src/plone/api/validation.py:96:21: Q000 Remove bad quotes.
src/plone/api/validation.py:97:25: Q000 Remove bad quotes.
src/plone/api/validation.py:127:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:45: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/base.py Imports are incorrectly sorted.
src/plone/api/tests/base.py:0:1: I001 found unsorted imports
src/plone/api/tests/base.py:32:47: Q000 Remove bad quotes.
src/plone/api/tests/base.py:60:28: Q000 Remove bad quotes.
src/plone/api/tests/base.py:62:28: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_content.py Imports are incorrectly sorted.
src/plone/api/tests/test_content.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_content.py:137:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:271:37: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:879:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:880:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:881:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1015:17: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1024:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1025:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1026:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1027:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1028:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1029:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1030:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1031:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1032:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1033:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1034:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1035:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1036:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1037:13: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_doctests.py Imports are incorrectly sorted.
src/plone/api/tests/test_doctests.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_doctests.py:120:13: T001 print statement found.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_env.py Imports are incorrectly sorted.
src/plone/api/tests/test_env.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_env.py:30:14: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:31:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_group.py Imports are incorrectly sorted.
src/plone/api/tests/test_group.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_portal.py Imports are incorrectly sorted.
src/plone/api/tests/test_portal.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_portal.py:61:16: P002 found "hasattr", consider replacing it
src/plone/api/tests/test_portal.py:125:41: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:125:57: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:163:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:164:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:194:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:204:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:213:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:214:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:215:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:229:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:230:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:251:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:252:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:253:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:272:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:273:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:279:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:289:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:290:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:299:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:311:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:312:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:336:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:337:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:338:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:345:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:346:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:347:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:524:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:535:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:544:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:582:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:614:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:615:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:616:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:617:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:713:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:747:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:748:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:749:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:750:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:785:32: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:787:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:788:38: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_user.py Imports are incorrectly sorted.
src/plone/api/tests/test_user.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_user.py:641:20: Q000 Remove bad quotes.
src/plone/api/tests/test_validation.py:37:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:40:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:65:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:70:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:74:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:79:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:84:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:91:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:98:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:123:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:124:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:131:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:132:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:133:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:159:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:160:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:165:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:166:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:167:14: D001 found assertEquals replace it with assertEqual
```
You can run that yourself using buildout.coredev ``experimental/qa.cfg`` config file.


伍仁组第三次作业


伍仁组第二次作业


!fix describe parameters of `jboss::resourceadapter` as you are testing it


確認しました。ありがとうございます。


Isn't this the wrong way around? According to the deprecation notice, we should keep `extraClass()` and remove `extraClasses()`


!fix Test also with artifacts


@MNoya I have added the announcer, the team and player colour should line up with the colour announced.


I see, makes sense.


伍仁组第四次作业


I think Ruby should be also listed here.


Is this correct? I have not tested this piece of code for this specific file but afaik an IPv6 address begins with a '[' so returning $parts[0] would return an empty string.

Maybe something like this would do a better job...
```
		$parts = explode("[", $addr);
		if (count($parts) == 2) {
			$parts = explode("]", trim($parts[1]));
			if (count($parts) == 2) {
				return trim($parts[0]);
			}
		}
```


That sounds really good, but also very ambitious. I think that we should not let any i18n ambitions stop us from starting with just the small step. Also I don't know what a good general mechanism would be, but I think we can best find one bottom-up, just trying to put messages into dedicated spaces in iteratively better solutions.

And yes, it could very well be done separately. Just don't let it slip too far, or it'll become one of the things that people want to do, but the task is so vast that it never gets done.


!fix describe parameters of `jboss::module` as you are testing


其实不太好 conn 调用自己的方法修改自己的对象. 最好还是一个参数传入就好了.


Should read "publish this record" rather than "publish this page", since versioning can be added to all DataObject types


Je fixe aussi celui là... Il fait planter le webhook


Hi, thanks for the suggestion... please create a ticket in the tracker (or submit a pull request) as this one is now already released.


Maybe just invoke this on every loop and supply the resulting value?


Same here, "record" rather than "page"


Your commit mentions logging a warning, but you log a info message. Which of those is correct?


Also, maybe `dn` is a more descriptive alias?


这个文档有点过时了，参考https://github.com/flike/kingshard/blob/master/doc/KingDoc/how_to_use_kingshard.md
更好一些。


Doesn't this conflict with `SiteTree->doPublish()`? I don't see that removed in https://github.com/silverstripe/silverstripe-cms/pull/1381


@ratoaq2 ltv down until 17:00 of today -local time. Try now and see what happens without the try:except.


@ebrehault Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/25//violations
```
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/content.py Imports are incorrectly sorted.
src/plone/api/content.py:0:1: I001 found unsorted imports
src/plone/api/content.py:98:13: Q000 Remove bad quotes.
src/plone/api/content.py:99:13: Q000 Remove bad quotes.
src/plone/api/content.py:100:13: Q000 Remove bad quotes.
src/plone/api/content.py:268:1: C901 'delete' is too complex (15)
src/plone/api/content.py:300:25: Q000 Remove bad quotes.
src/plone/api/content.py:322:25: Q000 Remove bad quotes.
src/plone/api/content.py:360:1: C901 '_wf_transitions_for' is too complex (12)
src/plone/api/content.py:454:17: Q000 Remove bad quotes.
src/plone/api/content.py:455:17: Q000 Remove bad quotes.
src/plone/api/content.py:482:17: Q000 Remove bad quotes.
src/plone/api/content.py:521:13: Q000 Remove bad quotes.
src/plone/api/content.py:522:13: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/env.py Imports are incorrectly sorted.
src/plone/api/env.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/portal.py Imports are incorrectly sorted.
src/plone/api/portal.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/user.py Imports are incorrectly sorted.
src/plone/api/user.py:0:1: I001 found unsorted imports
src/plone/api/user.py:70:13: Q000 Remove bad quotes.
src/plone/api/user.py:71:13: Q000 Remove bad quotes.
src/plone/api/user.py:357:37: Q000 Remove bad quotes.
src/plone/api/user.py:400:37: Q000 Remove bad quotes.
src/plone/api/validation.py:20:13: Q000 Remove bad quotes.
src/plone/api/validation.py:21:13: Q000 Remove bad quotes.
src/plone/api/validation.py:22:32: Q000 Remove bad quotes.
src/plone/api/validation.py:66:21: Q000 Remove bad quotes.
src/plone/api/validation.py:67:25: Q000 Remove bad quotes.
src/plone/api/validation.py:96:21: Q000 Remove bad quotes.
src/plone/api/validation.py:97:25: Q000 Remove bad quotes.
src/plone/api/validation.py:127:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:45: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/base.py Imports are incorrectly sorted.
src/plone/api/tests/base.py:0:1: I001 found unsorted imports
src/plone/api/tests/base.py:32:47: Q000 Remove bad quotes.
src/plone/api/tests/base.py:60:28: Q000 Remove bad quotes.
src/plone/api/tests/base.py:62:28: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_content.py Imports are incorrectly sorted.
src/plone/api/tests/test_content.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_content.py:137:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:271:37: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:879:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:880:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:881:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1015:17: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1024:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1025:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1026:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1027:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1028:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1029:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1030:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1031:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1032:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1033:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1034:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1035:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1036:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1037:13: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_doctests.py Imports are incorrectly sorted.
src/plone/api/tests/test_doctests.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_doctests.py:120:13: T001 print statement found.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_env.py Imports are incorrectly sorted.
src/plone/api/tests/test_env.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_env.py:30:14: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:31:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_group.py Imports are incorrectly sorted.
src/plone/api/tests/test_group.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_portal.py Imports are incorrectly sorted.
src/plone/api/tests/test_portal.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_portal.py:61:16: P002 found "hasattr", consider replacing it
src/plone/api/tests/test_portal.py:125:41: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:125:57: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:163:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:164:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:194:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:204:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:213:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:214:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:215:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:229:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:230:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:251:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:252:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:253:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:272:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:273:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:279:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:289:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:290:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:299:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:311:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:312:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:336:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:337:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:338:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:345:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:346:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:347:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:524:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:535:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:544:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:582:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:614:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:615:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:616:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:617:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:713:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:747:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:748:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:749:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:750:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:785:32: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:787:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:788:38: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_user.py Imports are incorrectly sorted.
src/plone/api/tests/test_user.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_user.py:641:20: Q000 Remove bad quotes.
src/plone/api/tests/test_validation.py:37:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:40:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:65:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:70:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:74:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:79:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:84:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:91:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:98:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:123:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:124:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:131:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:132:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:133:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:159:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:160:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:165:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:166:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:167:14: D001 found assertEquals replace it with assertEqual
```
You can run that yourself using buildout.coredev ``experimental/qa.cfg`` config file.


Same here, `SiteTree-> doUnpublish()` still exists.


Could we stick to ES5 semantics in this change? I'll do the ES5->ES6 pass for the whole project in a separate PR.
An equivalent would be:
```javascript
var Read = AdapterRead.extends({
    initialize: function(...) {
       AdapterRead.call(this);
    }
```

The change of the name to `ReadInflux` is also not necessary (or should be in a separate commit).


TemplateHaskell拡張が無効の場合は問題無いが、有効にしている場合、コンパイルできない


TeamCity pull requests :: netty [Build 1162](https://garage.netty.io/teamcity/viewLog.html?buildId=5277&buildTypeId=pulls_netty&guest=1) is now running


Wouldn't make a difference. Only `template.species` is actually sent to `checkLearnsetSync`. The magic is in the `Tools.includeMods();`


Hi,

I rebased your two deprecrated constructor fix commits into 1 commit for testing here:
https://github.com/bradymiller/openemr/commit/096b0faa86524c9fee732de8f64ec73a7b0652f7

On the patient summary screen the medications/allergies/prescriptions does not show up and I see following php error:
[01-Feb-2016 01:16:26 America/Los_Angeles] PHP Fatal error:  Call to undefined method Controller::Controller() in /var/www/openemr/controllers/C_Prescription.class.php on line 40

-brady


ERROR: Using the '.*' form of import should be avoided - org.fossasia.openevent.api.protocol.*.


ERROR: 'isConnected' hides a field.


ERROR: Using the '.*' form of import should be avoided - android.view.*.


ERROR: Using the '.*' form of import should be avoided - java.util.concurrent.*.


[Mediator pattern](https://en.wikipedia.org/wiki/Mediator_pattern)

Define an object that encapsulates how a set of objects interact. Promotes loose coupling by keeping objects from referring to each other explicitly and it lets you vary their interactions independently.
![2016-02-01 12-23-02 www mcdonaldland info files designpatterns designpatternscard pdf](https://cloud.githubusercontent.com/assets/3999858/12713270/a5aedc4a-c8de-11e5-9780-96be43c6b577.png)


This is unrelated to Read API change, would be better in a separate commit.


??

this doesn't compile / why in GetTabIcon()?


Good catch - throwing on invalid config should really be here. Could you maybe split this change into a commit on its own, please? It is unrelated to Read API change.


Then it should :) What is needed here?


I think that it's not because *we can* let it that we should do it. Enabling a *dev utility* in a *production environment* doesn't seems like a good idea to me. And are we really sure that adding a middleware to all our actions doesn't slow the dispatching even by a nanosecond (I work on critical systems at the NASA and performance is our main issue while launching rockets)?


evictConnection() already correctly have "(connection evicted by user)"


On the patient summary screen the medications/allergies/prescriptions does not show up and I see following php error:
[01-Feb-2016 01:16:26 America/Los_Angeles] PHP Fatal error: Call to undefined method Controller::Controller() in /var/www/openemr/controllers/C_Prescription.class.php on line 40

-brady


@tlitovsk does this mean that the policy installation fails, because enforcing mode is selected for installation?


reverted:
https://github.com/springlobby/springlobby/commit/6314b5992de33e2c9785db14fa807a4b08f04673


change 'host:port' to `host:port`


Is there a special reason for this commit to revert #28 ?


This debug line should be removed.


So end users can understand why this Power Management > Run-Time PM core functionality was disabled:

https://webcache.googleusercontent.com/search?q=cache:vf4rkjMBTzcJ:https://kill-9.me/582/odroid-c1-usb-network-adapter-problems


If one has root and can update ca-certificates, they can also add their own CAs to the system, without needing ZNC's internal CA storage.


I have tested this fix with the attached
[testtopic.aiml.zip](https://github.com/LorenzCK/Program-O/files/111951/testtopic.aiml.zip)
and i can cofirm the fix is correct
thanks @LorenzCK :D


You wrapping it into a sandbox because of security issues?
Which cases there are that you need this "security level"


What do you think about making `:0:` or some equivalent 'beginning' a default, to save keystrokes and simplify the default query?


Thanks, I noticed that this works though with the latest version:

```java
class InSituInitTest {
    public InSituInitTest(String s) {
        string = s.clone;
    }

    private String string = "Hello world!";

    public void test() {
        System.out.println(string);
    }
}

(new InSituInitTest()).test()
```

Since there is an explicit constructor, shouldn't this fail compilation?


gvs不能用于hosts中


Could do with a mention of why this is being removed in the commit message.


I'm not entirely clear on the "Remove bad quotes" error. Is that picking up the fact that double quotes have been used? I agree that the use of `hasattr` should be replaced.


Hi. How's Snap camera on Crackling so far? I tried it on my build once but it crashes when shifting to video mode. Haven't had time to analyze logcat though.


Thanks for adding EasyPkg!


Could you please break out this chunk into a separate commit?


Does this actually work? I'm pretty sure this doesn't actually do anything.


Can you please help me . how to edit and rebuild . libiconv.so . im using targetsdk 23 .its not working .if you have updated file which supported for sdk 23 . can you share . please


This seems potential error prone to me. A controller might not have other permissions you require (opted out of some, or not using the default policy) so I'd recommend to include all the required permissions in here and assume you don't have any privileges.


Sorry, I am probably missing something, but how does this test that timestamp is not used a second time and force is not stored?  Surely you would:

* authorise once with arbitrary defaults
* call authorise again with force and timestamp set
* call authorise again with no params
* call authorise again with force

Then check that the first authorise did in fact authorise, the second authorise issued a new token and used that timestamp in the token request, and the third authorise did nothing, and then forth authorise did create a new token request but did not use the timestamp provided in step 2


Did you intend to upload this value to GitHub? If not, you can put the secret in its own file and add a .gitignore for it as well as instructions for creating your own in the readme.


Made the language check.


Finally build numbers <3


.find instead of where(id:..)


What is really grind my gears is not so the disabling of the dev tools, but the logic addition to createStore, which I think should only be pure composition of functional elements. What I propose is this:

```
> ls -1 src/dev
api.js
tools.js
```

So `src/dev-api.js` would be renamed to `src/dev/api.js`, and we have a new file called `src/dev/tools.js` which export (or not) the devtools.

Like, _separation of concern_, you know.

Opinion?


ini yang ditambahkan? sudah diperiksa kembali?


Siap gan, order sudah sampai


@stalniy The method renderTemplate appears twice here.


Wir programmiern hier kein Java...
Bitte installier linux, dass du deinen code au kompilieren kannt!


@stalniy in `bindings.coffee` the function `renderTemplate`appears twice


tes


读取信道组分支


Und um nen Konstruktor aufrufen zu koennen musst du au einen impementiern.


I'm glad you like them. Thanks.

fy_iceworld

From: Viktor
Date: 2016-02-01 14:57
To: vdakalov/de_dust2a
CC: fy-iceworld
Subject: Re: [de_dust2a] Write version (7fab84b)
hi, your map is not bad. but i think that it is very large and different
areas very similar to each other. this will complicate the orientation.
i wish good luck in the development of maps

Hello, come and have a look at my symmetrical de_dust_2.
It's here: https://github.com/fy-iceworld/de_dust2_dch/releases

—
Reply to this email directly or view it on GitHub
<https://github.com/vdakalov/de_dust2a/commit/7fab84bfab13835ebc526c1bd7a806a3b2a2c5c0#commitcomment-15789464>
.

—
Reply to this email directly or view it on GitHub.


Creo que  no te pone nombre a la imagen de docker del hito 4, porque el nombre se lo tienes que poner cuando la creas en el repositorio de imágenes de docker, y así lo hicimos en clase cuando os disteis de alta y creastéis vuestra primera imagen


sip..lanjutkan kerjamu nak..


This doesn't actually listen for input, it seems to dismiss regardless


Perhaps it should be `val override name: String`? Or isn't it necessary?


Hi. Camera works perfectly


`TODO` tag?


BTW. I prefer not to use mocks unless necessary because it can often hide true behaviour in the library. For example, when testing if params are stored and used as defaults, why don't you simply check the token that is returned without mocking? Mocks should be use sparingly when normal introspection of the library's behaviour is not possible.


For example we're aiming to gradually remove inline CSS from controllers. Since your application might (?) require it you might need to opt-in on that one to be safe that it runs :smile:


@dinkoivanov  - I haven't seen "meta." elements like *meta.schema* and the *meta.element* down on line 18.  Could you give me a URL to somewhere that describes them?


Yeah it would be cool indeed!


> how to make content server to listen just on '127.0.0.1:3030' ??

Just comment out this line, or lines 152 and 153.


Hmm, I don't recognise this expression format *(1-*.  Could you direct me to somewhere that describes it?


No reason for dealing with this in the engine


There was an error, please fork master branch, do a PR and i'll merge it. sorry.


I think we are usually putting a verb in front of the attribute. See for instance "isrecording", LISTITEM_ISRECORDING. thus, imo,  "istimerdisabled",    LISTITEM_ISTIMERDISABLED etc would be better naming.


I'll probably revoke it as 't' looks good enough so far. Will update in a day or so.


Imo, HasConflict() would be better naming.


Needs new strings added to YAML language master file.


Not sure this commit follows through.


see my github.

cm 13 working


oke om


Can you tell me updated zbar library for android with fixed Android 6.0 Issues


Your spelling is incorrect!


摘自<< http://www.netkiller.cn/journal/thread.php.html >> 留作记录


Why do we no longer check the "active" state of the timer here?


Херня!


X n'est pas le X de AX=0, je l'avais appelé V car c'est son nom, qui a du sens :
https://en.wikipedia.org/wiki/Singular_value_decomposition
http://fr.mathworks.com/help/matlab/ref/svd.html


Fixed in https://github.com/cmaglie/Arduino/commit/b02ce54387dae3d1f1a9f10161f72322eaf3d899, thanks!


Удали 2


Hi,
Your test is too restrictive.
If you create a single inventory with 2 lines of the same product your control don't pass.
Yet the odoo algo create 2 adjustments with additionnal values so that it works when duplicate lines in the same inventory.
Is it possible to open a little this part of code


Look at `!learn Nidoking, Counter` for an example of something this code gets correct that your code doesn't.


No extra line here.


This looks OK, but it would be worth dev testing that hard_reboot still cancels clean_shutdown and clean_reboot.


I have done this in a different way in 20383c1554d16ab48bc476be9e3a25e4433f1de6.


wrong


As long as the engine controls what can be transported (transportMass & minTransportMass) it makes sense it should deal with invalidating such orders. I'm not really familiar with this part of engine&game logic.

The alternative is to make a callin for mass changes but that seems too detailed -> Maybe later we can consider a property listening/notification system, although I'd let some of the more senior devs design that (kloot seemed to have something in mind with the hash-update interface in sunlighting)


@aofall 这是 gws 啊


Is <code>!Active()</code> really the same as "disabled"? Not sure. There is an explicite timer state for "disabled". => https://github.com/xbmc/xbmc/blob/master/xbmc/addons/include/xbmc_pvr_types.h#L191


I'm not sure whether this actually works. @mpolakovic help?


Why?


Process framework is only checking for attribute error. So, a 'raise' here will go unhandled


s/Through/Though/


OK


`The behaviour`: do you mean `This behaviour` or another behaviour?


We can probably change this to something more less developery
"Access to path {0} denied. The Event Store database will be created in {1}", dbPath, Locations.FallbackDefaultDataDirectory)


Logging lib is changed but logging object creation remains same


Cool. Thanks. Will try it soon.


The good practice is to remove lists added by apt-get, something like:

     RUN apt-get -y install libgfortran3  && rm -rf /var/lib/apt/lists/*


See inline comments.


[[TargetPage]] is resolved to TargetPage.WebHome, so it is absolute instead of relative. It is a space reference and is absolute since otherwise we can not have absolute references.

This change makes the test fail in the current implementation.


@gforcada sorry this is to old for me to dive into, the reason made was there is a bug and this proves it is there


왜 unknown 으로 나오지? 이건 누가 올린건가요?


210.187.22.132默认证书是*.googlevideo.com
你确定是gws？


I would add an example, like:
`For instance, `env.simulator_frequency(20) means that the main loop will run at 20Hz (or less, if your hardware is not able to cope with the simulation)`


@songjinghe  This is a misunderstanding of the comment by @mbastian . He was not suggesting removing this line. This line should stay.

Rather, the version of the tools-api dependency should be removed (line 21) as that is inherited from the parent


broken on windows, will submit a fix

![image](https://cloud.githubusercontent.com/assets/7974663/12714015/1f435726-c8ca-11e5-8820-c5be27e47206.png)


Add the comment: `# main loop`


> [[TargetPage]] is resolved to TargetPage.WebHome

Yes and this is the bug... See my comment in your commit that "fixed" that test.


Add the comment: `# logic/physics loop`


Why do we no longer check the "active" state of the timer here?


Code eigenlijk alles Engels houden als dat kan


ok, seems like it will already cancel the order:
https://github.com/spring/spring/blob/647991d05feb191c3e2e5282656be0af00379131/rts/Sim/Units/CommandAI/MobileCAI.cpp#L1215


fuck im good 😂😂😂😂😂


To be exact,

```
        <dependency>
            <groupId>org.gephi</groupId>
            <artifactId>tools-api</artifactId>
            <version>0.9.0</version>
        </dependency>
```
should be changed to
```
        <dependency>
            <groupId>org.gephi</groupId>
            <artifactId>tools-api</artifactId>
        </dependency>
```

The changes in this commit should be undone to keep the plugin version in the POM
```
<groupId>edu.buaa.act</groupId>
<artifactId>gephi-plugin-node-color-manager</artifactId>
<version>1.0.0</version>
<packaging>nbm</packaging>
```


OK


Zorg voor het mergen van je branch dat je de Javascript en html gescheiden hebt


```
.gradient1{
    overflow: hidden;
    background: linear-gradient(180deg, rgb(64, 0, 128), rgb(0, 0, 0));

    -webkit-mask-image: linear-gradient(-90deg, white, transparent);
    -webkit-mask-mode: alpha;

    mix-blend-mode: normal;

    position: relative;
    z-index: 1;
}

.gradient2{
    overflow: hidden;
    background: linear-gradient(180deg, rgb(255, 255, 255), rgb(0, 0, 0));

    position: relative;
    z-index: 1;
}
```
Gradient square.

```
.gradientFull{
    overflow: hidden;
    background: linear-gradient(red, rgb(255, 0, 255), blue, rgb(0, 255, 255), green, rgb(255, 255, 0), red);

    position: relative;
    z-index: 1;
}
```
Gradient palette.


`s/(simulated)//`: it is confusing to introduce that soon the concept of `simulated seconds`. IMHO it is better to keep it for following sections.


Well, now that I think about it, it looks like we'll still get assertions when we have one of the *other* OverloadChoiceKinds that does something unusual, won't we?


Where's this undef'd? If it's not undef'd, why not make it a variable?


I'm not sure we should have this in the normal sketch, because most people without modified hardware won't get this and will just see random numbers as read from the floating pin.

Can we #ifdef it or something?

#if MARC_MERLIN ? ;)


# code lou project
Repo for testing the Git

# This is an <h1> tag
## This is an <h2> tag


@ryosukemaehira たかしが見る前に改行入れとこ！笑


Thanks


Additionally updated copyright in all source files to 2016


Cluster yelled at me for using time of day instead of just world.time once, might want to take that into account. Also err, this firing only every thirty seconds is intentional, right?


(I do agree we should monitor solar separately, as per #13 . I'm just cautious about the integrity of the default output.)


OK. I just stumbled across it when I used the sample and my linter yelled at me :)


develop (lefticus) - x86_64-MacOS-10.9-clang: OK (389 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Qdel, I think.


It's a fine linting rule, but in general tutorials omit `propTypes` to keep things simpler. Compare http://facebook.github.io/react/docs/tutorial.html#using-props.


TeamCity pull requests :: netty [Build 1169](https://garage.netty.io/teamcity/viewLog.html?buildId=5308&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6390, ignored: 23 Build time: 00:43:14


I would definitely undef these for this file, that's one really common name and it may fuck up shite elsewhere


@jvperrin this line looks wrong to me, I think you want ]] at the end


H


B


Kg


Gyu


Jhu


typo


* TODO: rewrite this as it is doing way too much and is very messy now.


Is construction being instantaneous intentional?


So there has been a further development. A friend of mine has pointed out that I should be able to do all stages for a y layer before moving on and that should fix the remaining decoration/gravity/fluid issues, including the Lilypad case without adding complicated block dependencies.


THis is the site for my git hub https://github.com/hlbarn02/codelouprojectHB.git


It was pushed as part of the chain leading up to 9244272dd4cdaea7b61b2321f827b2a70c4cfa9f (the `master` node at original time of writing) - running that command to reset `master` to 0ed33e1ef1d0a3384d1beb92e735d3b2b025790c (`master-fixed-blank`) should make this an inaccessible node (outside of reflog).


G


Actually wait, I literally just though of the case where levers can be placed on ceilings now... I will have to keep thinking.


duplicate (see line 105/106)


Gih


Vvg


Vgdvo


What's the point of having a no if it's just going to do nothing? Also eh, switch statements for a binary is kinda silly.


Hhbgdfghi


Should this be `length2<length1`?


minor issue - the rest of the file is indented with 4 spaces, not tabs.


Chen


typo


Convert SDK to Node Package


If I remember my C#,  it's a compilation error to try calling a parameterless constructor if another one exists. But I see your point, interesting...


One idea would be to have an icon that better communicates "muting", perhaps a feed with a slash through it

Definitely agree about having Cancel/Done options.


It is possible, are you saying that this patch is bad or that there is more that we should consider fixing?  I'll do a more conservative follow-up patch that disables the other kinds.


Have we considered not ack'ing here and waiting until after we have written the message to a FlowFile and committed the session to ensure we have it (if that is even possible)?


@ashqal what do you think of this? Best Tom


references #1


I think having both `Security` and `SecurityHolding` is redundant. Let's remove the `SecurityHolding` argument and replace it's usages with the `security.Holdings` property value


Contributor Code of Conduct
As contributors and maintainers of this project, and in the interest of fostering an open and welcoming community, we pledge to respect all people who contribute through reporting issues, posting feature requests, updating documentation, submitting pull requests or patches, and other activities.

We are committed to making participation in this project a harassment-free experience for everyone, regardless of level of experience, gender, gender identity and expression, sexual orientation, disability, personal appearance, body size, race, ethnicity, age, religion, or nationality.

Examples of unacceptable behavior by participants include:

The use of sexualized language or imagery
Personal attacks
Trolling or insulting/derogatory comments
Public or private harassment
Publishing other's private information, such as physical or electronic addresses, without explicit permission
Other unethical or unprofessional conduct
Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.

By adopting this Code of Conduct, project maintainers commit themselves to fairly and consistently applying these principles to every aspect of managing this project. Project maintainers who do not follow or enforce the Code of Conduct may be permanently removed from the project team.

This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community.

Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting a project maintainer at micah@misc.name. All complaints will be reviewed and investigated and will result in a response that is deemed necessary and appropriate to the circumstances. Maintainers are obligated to maintain confidentiality with regard to the reporter of an incident.

This Code of Conduct is adapted from the Contributor Covenant, version 1.3.0, available at http://contributor-covenant.org/version/1/3/0/


Not having the no fucked things up, and every other alert() I've seen is a switch.


please rebase to https://github.com/jedie/django-reversion-compare/commit/3a1eaf8f013993821a3b732b21dc03e1c64cd59b


Not sure if there is actually any over head on individual calls to putAttribute, but there is a putAllAttributes where you could build up the map first and add them all at once.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


> if it's not set, then the default value is $HOME/.config

So just ```~/.config/``` ?


Yeah, I believe I fixed it in the [next commit](https://github.com/ocf/ocfweb/commit/0609a169f490abf323ec4391725f01d721e14a56#diff-9d935aac6875f4d3f9e555ef93068229R104) thanks for noticing though.


Should we have an @InputRequirement of forbidden here?


Good point. Overhead is actually there. Will take care of it.


do we need a new line character or is it automatically added ?


well.. tried... i will go sleep... pointless.. too many have to change...
To make comparison etc. because i have now another line numbering due to
the changes (many changes)
So i need to search it by strings and then replace or add, depending..
The gitHub also gives me additional hard time by not displaying my commits
- not transparent and not intuitive at all.
For today i have no mood , nor power to handle such changes.. probably have
to spend half day or so just for this...
Then need to test all, confirm all is correct, again compare etc.
For today i am off.

On Tue, Feb 2, 2016 at 1:15 AM, Kyle Gabriel <notifications@github.com>
wrote:

> The major changes are additions. You can just manually add the new lines.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kizniche/Mycodo/commit/8b1cd50d0c190144d3ebe7b8c3b2ddb838d3cd89#commitcomment-15814315>
> .
>


Oh, good. Thanks!


How big can the body of a message generally get? I assume not too large since it will be in memory, but if it was large we might benefit from wrapping with a BufferedOutputstream.


xz


This change is made directly from the browser from github site


This should probably strip all of these characters https://html.spec.whatwg.org/multipage/infrastructure.html#space-character

> U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR).

Otherwise a leading tab or line break still has the bug AFAICT.


complicated block dependencies meaning the block attachments system?
while i understand it might be complicated...is there really any alternative for complicated structures that have a bunch of those kinds of blocks hanging to each other?


We don't need a newline.  For comparison, we don't put it at the end of hostname,


That is possible, but wasn't sure if needed here since if there are issues with creating FlowFiles from byte[] and map it would most likely be unrelated NiFi issue that would need to be addressed. In any event nice to keep in mind.


Would it make more sense to have a NO-OP default implementation rather than null checking in ```notifyTimeout``` ?


I wasn't sure we have something like that. Definitely!


In a lot of source processors we also generate a provenance RECEIVE event with a uri representing where it came from, like amqp://host:port/queueName


These multiple calls to `Config` would be better as:

```php
$config = $this->app->make('config');

if (...) {
    $length = $config->get('concrete.whatever.length');
}
```

If you're interested, I'd love another pull request fixing these too!


`RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/container6.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/container6.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/container6.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/container6.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/container6.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/chariot3curve.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/CargoDolly.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/CargoDollyWithContainer.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/CargoDollyWithContainer.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/container6.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/container6.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/container6.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/container6.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/cargobox_pkng.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/cargo_pod_lot.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/cargo_pod_lot.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/caisses_group.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/belt_loader_lp.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/belt_loader_lp.ac'
RJBB-fg-CustomScenery/Objects/e130n30/e135n34/5168920.stg: Failed to load OBJECT_SHARED 'Models/lib/belt_loader_lp.ac'`


Nah, I'm working on rewriting the VoIP system to fix some problems that it has. The current one was just copied-and-pasted code from a tutorial, and it's not very good...


develop (lefticus) - x86_64-MacOS-10.9-clang-Debug: Tests Failed (32 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-8.23%25-red.svg)


That's a good point. This patch looks like a strict improvement, so there should be no harm in taking it. (And it looks correct for what it *is* doing.)


Converting voodoo_device to C++ callbacks was something I had my own reasons for wanting to do. Thanks for putting in the effort to clean up some of the legacy stuff there.


i.e. "LGTM!"


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/31//violations
```
src/plone/api/content.py:268:1: C901 'delete' is too complex (15)
src/plone/api/content.py:360:1: C901 '_wf_transitions_for' is too complex (12)
src/plone/api/tests/test_doctests.py:121:13: T001 print statement found.
src/plone/api/tests/test_env.py:31:14: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:35:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
```
You can run that yourself using buildout.coredev ``experimental/qa.cfg`` config file.


You may remove these commented-out code pieces if they are no longer needed.


@rmacklin Thanks for telling me this. I have changed and amended it to the commit https://github.com/AppFolioOnboarding/Boying_ImageUploader/commit/ff39d6dc8c183ab7dc9013d026e68fdc78d9c8a3.


The main idea behind this test is to make sure that the library works without flags that enable C++11 such as `-std=c++11`, the remaining flags are not important. `FMT_PEDANTIC


Ebből egy új metódust kell csinálni


when i last contributed, we had all the attachments mapped in a handy blockid+datavalue => attachment direction function (apart from sloped tracks, which have two, but there was a special case for those in the dependency algorithm)
Why can't you make use of that, @DarkArc?


Of course GitHub still tracks metadata for any commit that receives comments, so this page will never actually go away (which is good for forensics when reading stuff like the commit message for #24).


Yeah, otherwise the chat would be spammed with HEY THE R-UST IS HOT


https://source.android.com/devices/storage/config.html look here @Rox-


It could be written:

```scala
  def zipWithIndex[A](first: List[A], index: Int = 0): List[(A, Int)] = first match {
    case _ if index < 0 => zipWithIndex(first, 0)
    case head :: tail => (head, index) :: zipWithIndex(tail, index + 1)
    case Nil => Nil
  }
```

or

```scala
  def zipWithIndex[A](first: List[A], index: Int = 0): List[(A, Int)] = first match {
    case _ if index < 0 => Nil
    case head :: tail => (head, index) :: zipWithIndex(tail, index + 1)
    case Nil => Nil
  }
```

But you're right : index should be a _private_ internal count that shouldn't be set outside of this function.


Up to you; one of the goals will be letting you specify the VM name when starting. So you could create a VM per app if you liked (with proper `system_config` settings to only start the app you want), a VM for all apps (including ecallmgr), etc.


## Task 1

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 2

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 3

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 4

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 5

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)
- [ ] Program is different than [Task 4](task-4) (1 pt)

## Task 6

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (3 pts)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1278](http://teamcity.monogame.net/viewLog.html?buildId=14237&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


owned_core.Shutdown() already qdel's it, so it gets deleted if the core manually shuts down from the core control comp.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27033/testReport/) for this commit**


@ebrehault Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/32//violations
```
src/plone/api/content.py:268:1: C901 'delete' is too complex (15)
src/plone/api/content.py:360:1: C901 '_wf_transitions_for' is too complex (12)
src/plone/api/tests/test_doctests.py:121:13: T001 print statement found.
src/plone/api/tests/test_env.py:31:14: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:35:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
```
You can run that yourself using buildout.coredev ``experimental/qa.cfg`` config file.


These lines should be moved to their respective folders, e.g. `18-compile-arm-ports` for `cc2538`. Otherwise, a wrong toolchain will be used by Travis.


I don't know about docking it in the middle, if we did, we'd have to make it far bigger.
Also, something like that would be an extreme nuisance for Windows users. As well as Linux users. Basically everyone except Mac users. Also, the hotkeys are not labeled in the menu.


Yeah, it is my intention to make it required (no error checking for it yet). The reason is I definitely don't want an in-place install because that puts it in a "weird" place in the PETSc directory and I don't want it to default to /usr/local or any "standard" place because I think it is a mistake to install things like the xSDK there. I want the user to conciously need to choose where to install it.


a, yes, good point. will do next time :)


True but otherwise I need an else clause which made the code look less tidy :-)


wtf is this


I am a nice comment


this indentation is cringy as fk


what happened here?


Instead change the exception handling in _upload_chunk and move response = requ.. out of try again.


go ahead make the change


Can it be a <-chan?


Either add OpenSSL.SSL.SysCallError or make broad catch in _upload_chunk


My assumption turned out to be wrong; it turns out there's a Shed Skin Ekans event.

	if (tools.gen <= 5 && eventData.abilities && eventData.abilities.length === 1 && !eventData.isHidden) {
		if (template.species === eventTemplate.species) {
			// has not evolved, abilities must match
			if (ability.id !== eventData.abilities[0]) {
				problems.push(name + " must have " + tools.getAbility(eventData.abilities[0]).name + " because it has a move only available from a specific event.");
			}
		} else {
			// has evolved
			let ability1 = tools.getAbility(eventTemplate.abilities['1']);
			if (ability1.gen && eventData.generation >= ability1.gen) {
				// pokemon had 2 available abilities in the gen the event happened
				// ability is restricted to a single ability slot
				let requiredAbilitySlot = (toId(eventData.abilities[0]) === ability1.id ? 1 : 0);
				let requiredAbility = toId(template.abilities[requiredAbilitySlot] || template.abilities['0']);
				if (ability.id !== requiredAbility) {
					problems.push(name + " must have " + tools.getAbility(requiredAbility).name + " because it has a move only available from a specific " + tools.getAbility(eventData.abilities[0]).name + " " + eventTemplate.species + " event.");
				}
			}
		}
	}

Here's my new code.


this spacing tho


`posix.h` is not only for testing, but it's experimental undocumented API. It is loosely related to the core library allowing formatted file output and at some point I'll probably make it official. But I think it's worth installing anyway.


。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。。卧槽


what is this formatting


I suggest adding directionality markers to the different channels to make errors less likely.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (395 of 395 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@wizjany attachments, things that fall, and things that flow. I initially thought there might be a simpler way, but I think honestly the best way is just to effectively have a block dependency graph generated, and then walk that.

@TomyLobo I'll look into ways to leverage the old queue system and its data more thoroughly.


Same comment.


Very nice! I get the sense you have some idea of what you're doing! Will refer to your code in the future....


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13918](https://teamcity.mesosphere.io/viewLog.html?buildId=120412&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:07:36


With this change the last sentence is not true. Website bugs are part of the rust-www repo. Can you make the last sentence come before the website mention? Then maybe change the website sentence to "Rust website Git repository, which has its [own issue tracker][]".


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13919](https://teamcity.mesosphere.io/viewLog.html?buildId=120252&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:07:54


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13916](https://teamcity.mesosphere.io/viewLog.html?buildId=120415&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:08:00


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13911](https://teamcity.mesosphere.io/viewLog.html?buildId=120420&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:07:59


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13915](https://teamcity.mesosphere.io/viewLog.html?buildId=120414&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:08:04


Pity you broke all your fingers in that climbing accident so can't improve the code yourself.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13913](https://teamcity.mesosphere.io/viewLog.html?buildId=120417&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:08:15


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13910](https://teamcity.mesosphere.io/viewLog.html?buildId=120422&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:08:27


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13914](https://teamcity.mesosphere.io/viewLog.html?buildId=120416&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:08:40


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13917](https://teamcity.mesosphere.io/viewLog.html?buildId=120413&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:08:50


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13909](https://teamcity.mesosphere.io/viewLog.html?buildId=120425&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:09:09


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13912](https://teamcity.mesosphere.io/viewLog.html?buildId=120419&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:09:13


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1278](http://teamcity.monogame.net/viewLog.html?buildId=14237&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:11:41


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1279](http://teamcity.monogame.net/viewLog.html?buildId=14241&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


> Should the whole block maybe be guarded with a check if `CMAKE_SOURCE_DIR == PROJECT_SOURCE_DIR`?

I think it's a good idea.


Since part 2 is to set the background image on the map, so you'll probably need to switch to making XHRs at some point, in which case you'll be able to catch error messages (likely connection timed out).


## Task 1

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 2

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 3

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 4

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 5

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)
- [ ] Program is different than [Task 4](task-4) (1 pt)

## Task 6

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (3 pts)


```java
return true;
```


I can help with this.


Uploaded from laptop


Nothing here, though it will be used to generate the background tileset (snapshot).


u suck at de and ur code is whack


Thank you!! :+1:


You might want to look into, well, just removing those variables


what the fk are thoseeeeeeeeeeee


what the shit hapepned here?


I accidentally revealed a future update


Thanks, @mgoffin !


赞美一下~


Second what Andre said. It did a strange thing to my command line that I couldn't figure out at first.
![screen shot 2016-02-01 at 6 42 17 pm](https://cloud.githubusercontent.com/assets/16668795/12736169/8ae2b30c-c913-11e5-818e-2c966ff957e8.png)


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (389 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


this is good it should be the final


Is there a reason why you're always returning the same album (albumPicasso)?


I think I just have in https://github.com/un1versal/KVIrc/commit/6dbdc8d8a84ef2bd524b14b6feb0dbbda7374618 just checking if it compiles


Tasks 2 and 3 print out on different lines


Esse boolean estava me dando sérios probemas...


? I presume you want to change this and throw it in .gitignore?


You finally will get `postStop` called. Right now we are calling `afterPostStop`, but it is internal API method and `postStop` should be called instead.


Como incrementar isso???


@aofall Done.


@NuclearCookie, thank you very much for code comments!


all this is no longer valid, but we can remove this


The main() is the function you are using for your programs, instead of creating different unique functions then calling them with main(). They work, but the structure isn't right.


Ah! You are right. But the real issue is more deeper IMO. After several hours of digging in code I am really confused about new graph stage API and how it implemented now. The idea of graphs and graph stages are to be completely reusable. You construct you graph with shapes and nothing happens. Then you run your graph and you have an access to "runtime" stuff via materialization process.

GraphStage API in reactive kafka right now is mix of graph and runtime stuff. For example - `sourceWithOffsetSink`. Creation of `ReactiveKafkaConsumer` makes graph not reusable and breaks the contract of graphs. All runtime stuff should be created at materialization step.

The second example is how offset commit implemented in graph stages. Sharing one reference between all threads? I understand why it implemented like this - it is the easiest way to achieve functionality, but it is not thread safe at all. The idiomatic way is to have an input source for such commits.

I have ideas how to implement this in a more graph compatible manner, but first of all I want to ensure, that we are agreed on current implementation problems.

Thanks!


Will check tomorrow when I'm by my macbook.


Thanks, I only tested it on Clang so far so I missed that!


It's been a while, so I don't remember if those names have significance and I may be wrong; I would either rename to make the comments redundant, such as *ChromaHighDetailHorizontal* or add a comment explaining why the constant is called FourFourFour, yet the contents are **1, 1, 1**.


You are right. I will try to fix it quick for this PR and test fixing.

Also I have thoughts about API design. I posted it in this PR discussion.


After several hours of digging in code I am really confused about new graph stage API and how it implemented now. The idea of graphs and graph stages are to be completely reusable. You construct you graph with shapes and nothing happens. Then you run your graph and you have an access to "runtime" stuff via materialization process.

GraphStage API in reactive kafka right now is mix of graph and runtime stuff. For example - sourceWithOffsetSink. Creation of ReactiveKafkaConsumer makes graph not reusable and breaks the contract of graphs. All runtime stuff should be created at materialization step.

The second example is how offset commit implemented in graph stages. Sharing one reference between all threads? I understand why it implemented like this - it is the easiest way to achieve functionality, but it is not thread safe at all. The idiomatic way is to have an input source for such commits.

I have ideas how to implement this in a more graph compatible manner, but first of all I want to ensure, that we are agreed on current implementation problems.

Thanks!


It's more reasonable than it seems at first glance, `handle_action` also uses it, and the other actions don't know about their store_credit to begin with. I've rebased that away with the previous exact behaviour, just changed variable names. I don't want to get too deep into improving these classes in this PR, with the size review is quite unwieldy.


I've opted to remove this section, since changsets will make this upgrade task redundant, rather than adding a section that'll need to be changed.


thanks a lot


I am fine with moving them somewhere else, I think your proposal is good, if you want, please go ahead!


Can you commit the other textures too? (The one with no vine and the one
with the leaf, and any other ones you might have too)

On Sun, Jan 31, 2016 at 9:19 PM DohyunK <notifications@github.com> wrote:

> sure.
>
> On Sun, Jan 31, 2016 at 5:06 PM, BenCuan <notifications@github.com> wrote:
>
> > Can you commit your latest changes so I can use the textures?
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/BenCuan/unity-game/commit/aeff61fa77ab13e89704448ab4fb76b7557f5054#commitcomment-15789068
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BenCuan/unity-game/commit/aeff61fa77ab13e89704448ab4fb76b7557f5054#commitcomment-15790610>
> .
>


It will be deleted.


Spaces will be fixed as well.


stray line


I'm going to update the name and documentation on this feature to make it more clear.


Det var jo ikke meningen å laste denne greien opp. Men håper den ikke tuller ting til :-1:


will remove


Similar to my comment on the companion Cargo PR, why are we excluding part of the grammar here?


NOTE! This build was tested on the robot and seemed to be stable. With the  possible exception of a try-catch block around the camera stuff, this build was stable.


I've adjusted the comment to clarify this.


move defer to top and `l.Close()` inside since it precedes every return?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-AddressSanitizer: OK (3047 of 3047 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yes please.


May want a comment about why this is necessary. On Linux and Android pid 0 is the scheduler which cannot be debugged in user mode AFAIK. However, it is interesting to note that 0 is actually a valid pid on some platforms. .


Awesome job!


Added this change; I'll push up soon. :)

Note that we still need the get*Assets() methods, since even if assets are successfully added to one set, they can still be later moved to different sets.


The following doc(s) have been deployed to the [ttrowellwp](http://ttrowellwp-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/wordpress/configuring-wp-config-php](http://ttrowellwp-static-docs.pantheon.io/docs/articles/wordpress/configuring-wp-config-php)


So far, only the server works ok. The client is a little buggy, I need to debug further.


What's the goal here? It doesn't look like you're using these, but I guess it's just so it won't throw arity exceptions?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1279](http://teamcity.monogame.net/viewLog.html?buildId=14241&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:29:20


f.pack():


I feel like the spelling fascist today with all these PRs, but: s/permisison/permission/


Doesn't `check-app-permissions` already throw an error? Maybe I'm missing where you're catching it if it does.


Thinking more on this, other tools like `pip` for Python, `cabal-install` for Haskell, etc., manage their own build directories rather than using the current directory. I think that's preferable.


I've adjusted the name / documentation around `archive_assets` to clarify that archiving of the dataobject is unaffected by this setting.


Suggest using `-e` (so that uncaught errors cause the script to abort)?


Почему нельзя через first-child чтобы не добавлять новый класс?


Phase 2: separate fulfillment and transfer logic and disallow client from fulfilling a transfer by posting to the `/transfers/:id` endpoint. Phase 3 will remove schema support for condition fulfillments in transfer objects. This will require updating `five-bells-shared`. Phase 3 will also add a new table to the db, so that the ledger will be able to persist the fulfillment, even though it is no longer part of the transfer.


thanks，i have fixed that.


Gah! That was a partial change. Thanks for catching that. The intent was to add additional information to the exception map as in `(throw+ (assoc ex-info :type ::cx/forbidden :error reason))`


ah!! sorry, didn't catch this before. unless tables are holding data, it is considered bad practice to use them. http://webdesign.about.com/od/layout/a/aa111102a.htm

would prefer if you could find another way to implement this.


I guess these guards are so it doesn't need to hit grouper, since presumably the verify-app-permission would let through the owner. (noting to self mostly, but tell me if I'm wrong!)


@keis do you have a test build for the 'gauge' branch?  I am having trouble building it locally.  If you could upload it somewhere, I can provide test feedback.  Thanks for helping get this into the grafana tree!


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: OK (389 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Heh, I should never submit pull requests in this much of a hurry. Thanks for catching this.


Yeah, sorry. Was just browsing the code while fighting a slow web-app with a deadline. Figured commenting was better than forgetting. Also, I'm skeptical of this design versus making a bonafide package manager (I don't consider this a step in that direction).


I'm a bit leery of having a version-less github repository as a core requirement. It was one thing for testing purposes, but quite another to say that whatever anyone commits to the rdflib-sqlalchemy github repo is good enough and won't ever break this module. This also means that this package now explicitly depends on SQLAlchemy as well, which might be overkill for some people (although it doesn't bother me any).


По определению
Тег <label> устанавливает связь между определенной меткой, в качестве которой обычно выступает текст, и элементом формы (<input>, <select>, <textarea>).
В этом случае мы не устанавливаем никакую связь, а значит использование label как-то не оправдано.
Почему нельзя задать input:block.Для чего нужно input оборачивать в еще один тэг?


Haven't implemented default value yet. This just flushes any null values from `property_values` table to make it lighter. Any thoughts are welcome.


The guards are actually to allow the owner to edit app labels after an app has been published. This is the current way of allowing this to happen without doing anything that might cause Grouper's performance to deteriorate.


Yes, I understand, but in several languages it says Movie information.


ㅏㅏㅏㅏ


ㅏ


this function has nothing to do with reachability. it just waits for Condition to turn True before the timeout.


heh, thanks for catching that


lgtm


@txuki2005 Thanks. I'll add it.


Not a big issue, just translator duty ;)


who is this guy


## Task 1

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 2

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 3

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 4

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 5

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)
- [ ] Program is different than [Task 4](task-4) (1 pt)

## Task 6

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (3 pts)


2333 懂的都是中国人，哈哈


I think that's fine. @Marty-D can check as well.


I think renaming them might be prudent with a comment describing in more detail the relationship between J:a:b notation and the actual chrominance subsampling factors.

I've actually given the last one the wrong name if you see page 10 here.

http://dougkerr.net/Pumpkin/articles/Subsampling.pdf


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-NoThreads: OK (390 of 394 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.98%25-yellow.svg)


![image](https://cloud.githubusercontent.com/assets/15005763/12736856/b31e91de-c908-11e5-8406-428f56f0e27a.png)

This is what it looks like.


Looks like someone else beat me to the fix!


@zcorpan good idea, although I am not sure those other control character would make it into `AttVal *attval->value`...

In general, the collection of an attribute value, after the `=` would not include them, but need to check... maybe you could check this... Please Tell More (PTM)... thanks...

OTOH if they are, then maybe [attrs.c](https://github.com/htacg/tidy-html5/blob/master/src/attrs.c#L1511) could be changed to -
```
    if (isspace(c))
```

In general, that would be equivalent to the earlier counter loop, which triggers this replacment, potentially escaped a string, with -

```
if ((c > 0x7e) || (c <= 0x20) || (strchr("<>", c)))
```

Comment, ideas, patches, PR very welcome... thanks...


I had the same exact question!  I assumed at some point they'd vary the
content, but we're just serving up an array of the same object.
On Feb 1, 2016 4:43 PM, "Jason LaChapelle" <notifications@github.com> wrote:

> Is there a reason why you're always returning the same album
> (albumPicasso)?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dpg5000/angular-jams/commit/485fb75726dc989a2843021dea30713b088444a5#commitcomment-15815919>
> .
>


Yes.


Add to this repository.


> emojis in commit messages


Like the use of all the new lines. Need to add these to my code. Looks good though.


Yeah that works wonders; even fixes certain issues with XD event moves where the event Pokemon's evolution has a different slot 1 Ability entirely (such as Heal Bell Mightyena) and would get rejected previously. :+1:


what is the value of having the array syntax vs the `npm test` as a regular syntax?


Hi xanview,
    I am currently using your github live555 repo for my code developments. However I noticed that the latest version is still not supported. ( 2016/01/29). Can I ask a question: do you have plan to support this version? if yes, when will you moved to this latest version? I want to use this version for my developments.
    I did not know how to find your email from github, so I add this comment here.
Thank
Xiaoyi


can you add a comment about the env variable requirement that is linked to container name(?) or how it comes to be `redis` vs any other name


develop (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (389 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Sorry for the giant pull request, I forgot to create one at the beginning.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (395 of 395 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


clarify this console log?


It's used to force pixel drawing to use a specific color, rather than the
color of any non-transparent pixels in the source image being blitted. It's
used in the Sherlock engine for font rendering in any arbitrary designated
color.

On Mon, Feb 1, 2016 at 11:43 AM, RichieSams <notifications@github.com>
wrote:

> What is the purpose of overrideColor? It is never used
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dreammaster/scummvm/commit/d4a849e6a3f7253e9f094ffdaf15dd4478a2d1ac#commitcomment-15804240>
> .
>


Do we need 3 versions? Can we have one?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1280](http://teamcity.monogame.net/viewLog.html?buildId=14245&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


nit: better to check if  1<=prefixlen && prefixlen <=32


make sure the res stuff is documented in the actual api routes as it is not super clear at this point what the res.body would give back to know what it is pulling from


あー `-` いらんわー


Nice. I'd be mulling how to do a nice clean implementation of the method
that could handle other bit depths, and hadn't even thought of using a
template.

Paul.

On Mon, Feb 1, 2016 at 1:17 PM, RichieSams <notifications@github.com> wrote:

> It would be nice to add 16 and 32 bit per pixel support. Perhaps something
> like this: https://gist.github.com/RichieSams/091c3c06b7c679ec208d
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dreammaster/scummvm/commit/d4a849e6a3f7253e9f094ffdaf15dd4478a2d1ac#commitcomment-15806938>
> .
>


I think it's better to keep this library instead of compiling test-main.cc in every test because `test-main.cc` includes a very heavy header (`gtest.h`) and takes non-trivial amount of time to compile (about 0.5s on my machine). Otherwise this time will be multiplied by the number of tests.


jnhvj


,jhvkj,


Spelling mistake


question: why we are only check first ipam only?


Hi Jean-Pierre Charras and Marco Ciampa,

I am still working on xlation to Indonesian.
Recently just 14%. Hope could be faster to finish it.

Thanks n regards.


nit: personally i prefer ipamRefs for readability


你的专题不是这样处理的吧？应该要单独一个文件夹存放的，不然到时候不要这个专题的话，不好维护


1) 조치버튼을 눌렀을 때, 요청구분/담당자/접수일/긴급여부 + 요청상태코드도 update.
2) 이제 처리완료일자/접수일자 넣기.


question: can we create multiple subnet object with same uuid? if so, we should better check uuid.


dttw fix


Может вообще убрать ссылку?Зачем она тут?Сделать Пусто 2 товара
.number-of-items:{dispaly:none}
.user-cart:hover .number-of-items {dispaly:block}


요기는 return없어도 되나요?


Issue related: #177


it is better to have negative test such as
adding 0.0.0.0/-1 bad_string as network


Good idea. I'd welcome a pull request for this addition. :)


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (395 of 395 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Let's keep track of `// fn.name is not supported by IE`


sure I'll make some more

On Mon, Feb 1, 2016 at 4:57 PM, BenCuan <notifications@github.com> wrote:

> Can you commit the other textures too? (The one with no vine and the one
> with the leaf, and any other ones you might have too)
>
> On Sun, Jan 31, 2016 at 9:19 PM DohyunK <notifications@github.com> wrote:
>
> > sure.
> >
> > On Sun, Jan 31, 2016 at 5:06 PM, BenCuan <notifications@github.com>
> wrote:
> >
> > > Can you commit your latest changes so I can use the textures?
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/BenCuan/unity-game/commit/aeff61fa77ab13e89704448ab4fb76b7557f5054#commitcomment-15789068
> > >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/BenCuan/unity-game/commit/aeff61fa77ab13e89704448ab4fb76b7557f5054#commitcomment-15790610
> >
> > .
>
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BenCuan/unity-game/commit/aeff61fa77ab13e89704448ab4fb76b7557f5054#commitcomment-15816132>
> .
>


TeamCity pull requests :: netty [Build 1170](https://garage.netty.io/teamcity/viewLog.html?buildId=5309&buildTypeId=pulls_netty&guest=1) is now running


OOOOOOOooooooohhhhhh

On Mon, Feb 1, 2016 at 5:25 PM, BenCuan <notifications@github.com> wrote:

> [image: image]
> <https://cloud.githubusercontent.com/assets/15005763/12736856/b31e91de-c908-11e5-8406-428f56f0e27a.png>
>
> This is what it looks like.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BenCuan/unity-game/commit/8254ec840b731843c3779a7e08d7e1e54f5aa3a1#commitcomment-15816548>
> .
>


😃

On Mon, Feb 1, 2016 at 5:50 PM, Dohyun Kim <dohyunk314@gmail.com> wrote:

> OOOOOOOooooooohhhhhh
>
> On Mon, Feb 1, 2016 at 5:25 PM, BenCuan <notifications@github.com> wrote:
>
>> [image: image]
>> <https://cloud.githubusercontent.com/assets/15005763/12736856/b31e91de-c908-11e5-8406-428f56f0e27a.png>
>>
>> This is what it looks like.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/BenCuan/unity-game/commit/8254ec840b731843c3779a7e08d7e1e54f5aa3a1#commitcomment-15816548>
>> .
>>
>
>


After upgrading the angular-bootstrap to latest version (1.1.2v), the problem was fixed and now the carousel works with uib-


The problem with that approach is that `(x...y).include?(x...y)` should evaluate to true, but won't.


fixed #7


good or bad?

On Mon, Feb 1, 2016 at 5:50 PM DohyunK <notifications@github.com> wrote:

> 😃
>
> On Mon, Feb 1, 2016 at 5:50 PM, Dohyun Kim <dohyunk314@gmail.com> wrote:
>
> > OOOOOOOooooooohhhhhh
> >
> > On Mon, Feb 1, 2016 at 5:25 PM, BenCuan <notifications@github.com>
> wrote:
> >
> >> [image: image]
> >> <
> https://cloud.githubusercontent.com/assets/15005763/12736856/b31e91de-c908-11e5-8406-428f56f0e27a.png
> >
> >>
> >> This is what it looks like.
> >>
> >> —
> >> Reply to this email directly or view it on GitHub
> >> <
> https://github.com/BenCuan/unity-game/commit/8254ec840b731843c3779a7e08d7e1e54f5aa3a1#commitcomment-15816548
> >
> >> .
> >>
> >
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BenCuan/unity-game/commit/8254ec840b731843c3779a7e08d7e1e54f5aa3a1#commitcomment-15816904>
> .
>


Ouch.


I think the s/mt/meters/ is useful, but IMO, this should be cleaned up to something like:

dist = MaybeStupidAmericanUnits(GPS_distanceToHome, METERS_TO_FEET);


Why not just pull all the #ifdef stuff and define home_position_valid in all cases?  For !DRONIN, it can just be `== GPS_Fix`.


Why not leave the style sheets in the stylesheets block?


"take *a* totally different..."


@m4dz the comment doesn't match the code. It was for line 59, no?


`AfterContentInit` hasn't been introduced yet. For consistency I'd remove it in this snippet


конкретно, что не понял?)

Вроде такой формат ты используешь у себя в доке :)


aaaaaa


This line and its matching brace are actually important.
If they aren't there, gcc tell you it hates you.

The reason is described in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55772.

Given how the code was changed, the matching brace will now probably be right above clearfog label.


The pattern ".-" should be "[^=].-"? This will fix the problem I mentioned in your pull request.


doesn't it make `v` a global in that case, meaning that line 33 would potentially overwrite the value of `v`?


Any reason to not use HTTPS?  If the page is served over HTTPS but any assets are not then browser warnings will be triggered.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27063/testReport/) for this commit**


То есть фактически тут написано:

```ruby
expect(Record.sum(:sum)).to eq(Record.sum(:sum))
```

Клёвые спеки :)


fml


Very nice article! I like it.

Once you've published it, would you mind sending a PR to ours that adds yours to the "related articles" section?

Ideally it would also add a paragraph somewhere that says "here's another article that explains content children in action" or sth. along those lines.


こちら確認したのですが、問題なく全データ含まれておりました。
元csvは新しくアップしたsales.csvになりますが、改行が入っていないなどございますでしょうか?

また、while(!feof)でも作成をしてみました。


beautiful!


А так разве не понятно? :)


Does this `arrayPushClosure` even makes sense in Lua? I added it to genjs because native JS `push` pushes all arguments to the array which makes stuff like `a.map(a.push)` produce wrong results as described in HaxeFoundation/haxe#1997. But in Lua Array has a proper implementation as per haxe spec so there's no such problem.


probably want to remove print statement?


Looks awesome, when can I test it on easymode?? :)


А сейчас запускаются, за счет того,  что мы тесты запускаем не для каждой из платформ по отдельности, а все разом.


@PascalPrecht Awesome, this is huge :heart_eyes:

Thanks a lot for your time, really appreciate it. I'll fix the article and submit you a PR soon. Thx again :smile:


Agreed.


Agreed - this doesn't make sense.
I'll remove this commit.


Could be profiled though?


We need to keep only the changed attributes. Usually changes are rare.


@jrbudnack: it never really worked reliably so as part of an on-going effort to clean up the release we decided to ditch it and re-implement it from scratch when the need arises.


Please use `this.id == null` or `this.id === undefined` just to avoid possible future bugs.


This is for #12


You are handling the case of the requirement argument not found, but this only happens if someone specifies -- without the argument, which may not happen, because -- will be interpreted in a special way. What you probably want to handle is the case of an invalid option, i.e. if someone gives you a short option:

"If an invalid option is seen, getopts places ? into name and, if not silent,  prints  an  error  message  and  unsets
 OPTARG.  If getopts is silent, the option character found is placed in OPTARG and no diagnostic message is printed.
"


Wow, it's a very old PR!
I can't remember why it's wasn't working exactly. :/
Anyway, you should take a look at this cookbook https://supermarket.chef.io/cookbooks/graphite-api which is the new official one. :)


How to get the dependency included then?


correct the externaml path name in
roles/db/templates/dbbackup/automysqlbackup_rep.conf.j2
**CONFIG_externalpathIncremental='{{ tape_path_fullbackup_rep }}'**


Oh :smile:, so this would be a PR to your post as it's a copy&paste quote from there :wink:


ok


test


> Finally I revert this!

Uhh ... is there any special reason? Not because of me I hope!


@tycooon я еще не придумал толком, что именно тут проверять.
В будущем, думаю, будет что-то более дельное


This is knowledge about types embedded into the reducer, I’d omit the comment (and a similar one in `expire`). I think the only thing reducers should assume is that `ops.*` on Juttle value(s) will return a Juttle value or throw.


the code is not meaning that BitCode is enable.
@nonelse
ENABLE_BITCODE
Description	Activating this setting indicates that the target or project should generate bitcode during compilation for platforms and architectures which support it.  For Archive builds, bitcode will be generated in the linked binary for submission to the app store.  For other builds, the compiler and linker will check whether the code complies with the requirements for bitcode generation, but will not generate actual bitcode. [ENABLE_BITCODE]


I doubt we should allow mixed case, but I guess it does'nt hurt :-)


@fluffle
missed a semicolon, don't you think?


@timler Please review, I made the changes that you suggested.


Oops, wrong line move, thanks :sweat_smile:


Can you please include this patch in the next release? It seems that it accidentally missed the 2016.01 release.


@kizniche : finally ! wonderfull ! thank you ! :D

@Seraphim : totally understand man ! ;)

Cordialement,
*A.R.E.M.974*
*Président*
*Mickaël "Myke974" PIERRE*
[image: https://www.linkedin.com/in/myke974]
<https://www.gmass.co/gmass/c?l=e440df2b-7f5b-4816-81bd-9709536442a9&r=c9e52949-6502-4cc3-8dc7-d4823459b639>

<https://www.gmass.co/gmass/c?l=025745b5-9c64-427e-adad-da8acdf90e7a&r=c9e52949-6502-4cc3-8dc7-d4823459b639>

<https://www.gmass.co/gmass/c?l=4ddd71d0-c758-4656-ae48-8c422afdf2c4&r=c9e52949-6502-4cc3-8dc7-d4823459b639>

<https://www.gmass.co/gmass/c?l=88ebcb1b-dea3-4c58-b64c-25dca0ac23e0&r=c9e52949-6502-4cc3-8dc7-d4823459b639>

2016-02-02 10:41 GMT+04:00 Seraphim <notifications@github.com>:

> Merged revisions and will test now.
> If tests are all ok here, then i will request to merge to main repository
> and you can decide if you want to have all changes made for SHT support and
> some other things related to it.
>
> I will start to work on UI (and then will offer it too)
> I have forked to my account the MyCoDo repository
>
>
> On Tue, Feb 2, 2016 at 2:13 AM, Seraphim Marouda <
> seraphim.of.marouda@gmail.com> wrote:
>
> > well.. tried... i will go sleep... pointless.. too many have to change...
> > To make comparison etc. because i have now another line numbering due to
> > the changes (many changes)
> > So i need to search it by strings and then replace or add, depending..
> > The gitHub also gives me additional hard time by not displaying my
> commits
> > - not transparent and not intuitive at all.
> > For today i have no mood , nor power to handle such changes.. probably
> > have to spend half day or so just for this...
> > Then need to test all, confirm all is correct, again compare etc.
> > For today i am off.
> >
> >
> > On Tue, Feb 2, 2016 at 1:15 AM, Kyle Gabriel <notifications@github.com>
> > wrote:
> >
> >> The major changes are additions. You can just manually add the new
> lines.
> >>
> >> —
> >> Reply to this email directly or view it on GitHub
> >> <
> https://github.com/kizniche/Mycodo/commit/8b1cd50d0c190144d3ebe7b8c3b2ddb838d3cd89#commitcomment-15814315
> >
> >> .
> >>
> >
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kizniche/Mycodo/commit/8b1cd50d0c190144d3ebe7b8c3b2ddb838d3cd89#commitcomment-15819662>
> .
>


There's a [apt_repository module](http://docs.ansible.com/ansible/apt_repository_module.html) that can be used to manage APT repositories.

Right now, the apt_repository module generates souces.list files with a [crappy filename](https://github.com/ansible/ansible-modules-core/issues/14) ; ansible 2.x has this fixed, but we're still using an older version so let's stick to using the copy/file modules.

Also, I don't like having the release hardcoded, we should use `{{ ansible_distribution_release }}` instead.


I prefer wait to Ghost Apps for do this kind of change to avoid people update their themes all the time... so minimize the impact in the future when will be necessary the change :-)

But yes is for you too! :P


@InfinityRaider I was wondering if we would be seeing the update for this in 1.7.10 soon, or is AgriCraft moving straight to 1.8.9 from now on?

Thank You


Такие штуки делаются так: создаем записи с конкретными значениями, в голове / на бумажке считаем, проверяем, что код возвращает правильный результат.
А эти спеки ничего и не тестируют, на самом деле.


I think it's just typos. Actually, the caller of `all_keys` uses the value from `coroutine.yield(k,v)`.


"behat" ?


Is it possible to embed a `swift.Authenticator` interface here so you can get rid of the boiler plate `Request`, `Response` etch methods?  It might be getting a valid one at the right time is tricky!