Ok, I will see if I can contribute a bit this late evening on this part,
but already tomorrow I am stuck with exams etc.

Best
Marco

Il 14/02/2016 18:44, Carlos J. Rosales ha scritto:
>
> Many thanks Marco, this is the hardest part to write, at least for me.
> We'll keep you posted.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CentroEPiaggio/pacman-DR54/commit/0dcad894b6d9a0ca1af972a6821961138855a283#commitcomment-16084411>.
>


docstring нужно поменять или стереть


@Robotia Think the ^M is incompatibility with Windows 10, not sure if the issues exists on a linux environment.


Right after john fixed parser


That's exactly it!


I approve this.
On Feb 14, 2016 12:28 PM, "Jed Northridge" <notifications@github.com> wrote:

> [/] Elminate contraction
>
> This one's for @abaruffa.
>
> Scratch that.
>
> This one is for @abaruffa.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/jedcn/jedcn.com/commit/e355c924114ee80f5501c387caa20af844fe4602
>


Hey i have it also
Here's a link to the .phar 14.0 imagical mine latest version


Thanks, fixed in 9acbb9021b1477a0a7f25d54d79811dc33b16e15


Since this is only an `extern` declaration, it should have no memory impact.  Storage would only be allocated when the compiler found a definition.


Of course we can add `v1.2` but usually we run this version locally, wdyt?


We could default to en-US here, I think


Ты забыл закоммитить rpccrypt.cpp.


Very good change. :+1:


s/settngs/settings


PHP has a readable shorthand for this:

    $array[] = $var_to_push;


This will fail if `service_server_dependency` is not set (cf. https://github.com/saltstack-formulas/nfs-formula/issues/13 )


Use short array syntax: `[]`


In Elixir itself it's called `Deriving`.


Add spaces after commas for consistency


This is now out of what with what I put in the docBlock for the article class (i suggested a unix timestamp). Will update.


This bat file won't work on anyone else's machine.


Use proper braces here to be on the safe side


Перемести пожалуйста все `@keyframes` на определённую страницу и добавь для них комментарий, например:
/*==========  Animation  ==========*/

P.S.
1) Комментарии желательно писать на английском языке.
2) И лучше их _нагляднее_ выделять, например:

/*Animation*/
/*==========  Animation  ==========*/

Мне кажется второй вариант я замечу в коде быстрее, чем первый.


@rop2000 Did you check this? This is broken. You need to have a space between the number signs and the words for it to work.


It looks like you pushed a lot of files that shouldn't've been pushed.


I’ve attached two native clips from different cameras/sources.  These and any other HEVC encoded videos I’ve tried do the same “color bar crash” of AviDemux (v2.6.11 official release version) on my W10 (x64) PCs.

If you have a clip that works for you, I’d like to try it.
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
[HEVC (H.265)  1080-24fps.zip](https://github.com/mean00/avidemux2/files/129813/HEVC.H.265.1080-24fps.zip)
[Mobius 2_sample (Native H.265).mp4.zip](https://github.com/mean00/avidemux2/files/129821/Mobius.2_sample.Native.H.265.mp4.zip)


Would it be a bit too magic to roll all these similar calls up into one `foreach`, and concatenate `x_page_href` each time?


@rop2000 This actually worked before but you removed the space! Now it's broken! Please, please, **please** check to see if things work before committing them!


ok


The limit for smart mines is [15 before ammo rack](/dxx-rebirth/dxx-rebirth/blob/08de1bbff0be775c06324bea32c7dce3352afb8b/similar/main/weapon.cpp#L97) and 30 after.


@satriani-vai latest version, 0.14.40 should do the trick.


Должно быть единообразие написание шрифтов. Тип шрифта (`sans-serif`) – в самом конце


This 2 strings have duplicates in this file. They should be deleted probably.


might be better if we are able to specify where java home folder is, in the oracle-java role, so that we are sure, right now, this is a bit loosely defined.


I keep losing my settings for my android lg leon lolipop, i think has to do with com .qualcomn.telephony/com.quicinc.cne.cneservice but I/am_ no_expert. Any ideas?


sounds like a plan!


usunięcie tego wywołuje lag


Yeah it should override.


`matches` is always truthy. since `undefined` & `null` are falsy simply write
```
	return deviceList.filter(function(d){
		return d.id == deviceIn.id;
 	})[0];
```
or even using `deviceList.find()` depending on which version of node Homey is running.


You broke the compilation on master!


zalewa konsolę logami


Oh, right, reverting then :+1:


What did you want to do? Remove completely the AUDIO=YES option?


That's true and I didn't think about it. Nonetheless, I would add `1.2` for completeness :) but we can do it when 1.3 is out, no problem!


hehe


could we instead just cut down the appraisal timer and cycle through the types of appraisal only doing once each so we aren't waiting 30 seconds at one time without taking combat actions?


@rop2000 I've found a great deal of issues with what you did here. I reverted and fixed them commit 7963914.
## Remember: Check your code before committing!


Sorry about that. I'm very new to github and collaborative development in general. Thanks for fixing it!

On 2/14/2016 3:13 AM, Jack Porter wrote:

This breaks the multi-color support - the new GetPGPage function doesn't support color 0 or do any of the special handling.

—
Reply to this email directly or view it on GitHub<https://github.com/BuildingOutLoud/Brickficiency/commit/44a4ff004c24b4c4378392f37dfe12b768f2a0f6#commitcomment-16082710>.


I think the logic of the statement can be a little bit strange, readability wise. As in how is `!isAdminScope(session.scope)` related to `isCsrfValidated`... We can remove the `else` clause to make it less nested and use `isCredentialsValid` in place of `isAccountValidated` to make things clearer.


[Uploading Adventure_Kathrin_Schröder.zip…]()


ChaCha20-Poly1305 cipher suites support added.This means mobile browsers get a better experience when visiting sites.


Careful is 10, normal is 5, quick is 3.


I pushed the would VS project folder. I figured if one of u wanted to get
it working you could manually change the bat file or sift through the
files. This made it easier on my end for now and I will clean it up later
On Feb 14, 2016 1:04 PM, "dkeller93" <notifications@github.com> wrote:

> It looks like you pushed a lot of files that shouldn't've been pushed.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Alzheimers480/FaceDetection/commit/2b1f8034978fe71bb35d2cbef7bfd55db10a5b3b#commitcomment-16084501>
> .
>


Done


`request` seems to be a more reasonable choice in this case. By convention the `session` is meant to be the decrypted result of a cookie (a a set of cookies) from an user instead of a place to add more attributes in to it.


What exactly does ghost site do? When is it tinted green normally?

I'll change the others after we shift to engine 101, I want the necessary bits done first.


Hi,

This would break support for OpenVz. If you'd like me to merge, some compatibility code for openvz would have to be added.

Cheers


I derp here. I wrongly merged this two branches. Need some help


Which information is meant to be in the Python 2.7 documentation's `optparse` chapter? I can't find any.

Is the URL correct? (Maybe it should be https://docs.djangoproject.com/en/1.9/topics/testing/advanced/#django.db.connection.creation.destroy_test_db ?)


Az ftp-ről is kérém a törléseket.


@Yive I hope it isn't, going to check on my server.


Yeah, I was referring to the splitter.  To me it appeared that a recent update caused the splitter to remember position, but perhaps it was an issue on my end.  Either way, thank you!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15795](https://teamcity.mesosphere.io/viewLog.html?buildId=135390&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 226 Build time: 00:08:39


Thanks ;D


Если есть `h3`, значит где-то есть и `h1` и `h2`


Поясни пожалуйста, почему 98%?


So that'd be "youtubeplayer" and "ecasa", they stopped working then?


здесь потом надо будет перенести это во фреймворковый главный модуль


pls read this documentation for correct "CASE" codestyle.


I assume you did't want ot commit this, right?


`[Thank you. You are in the group and the team :) you helped me alot # ##

_**


`session.get('is_kiosk', False)`?


anytime


The search feature is great!  Thanks!!


finance tracker inicio


This is a markdown file


Thanks for the pull request. The solution looks good with just a couple of points:

1. You should match the formatting of the original file (2 spaces) to avoid excessive changes hiding your work.
2. Would this NIST converter be better placed in IdentityUtils as a static method for general purpose use?

I'd suggest using some of the BouncyCastle methods in ByteUtils which provide concatenation. Also, you may want to confirm the use of "ascii" over "utf8" when writing the string.


My privite server plugins are now available to you anytime,just ask what plugin you want heres the list of plugins.


>plugins
[Server] [13:25:28] [INFO]: Plugins (108): AddNoteBlock v1.2, Allmobs v0.3, NoExplode v1, BlockSniffer v1.0.0, PocketDockConsole v0.0.14, CustomAlerts v1.6, Diamond v1.0.0, DisableTntExplosion v1.0.0, Drugs v1.2, EconomyAPI v2.0.9, EconomyAuction v2.0.2, EconomyCasino v2.0.2, EconomyJob v2.0.4, EconomyLand v2.0.9, EconomyProperty v2.0.6, EconomyPShop v2.0.2, EconomySell v2.0.7, EconomyShop v2.0.7, EconomyTax v2.0.3, EconomyUsury v1.0.1, F3 v0.1-Alpha, Fireworks v1.1.0, fireworks v1, FloatChat v0.1.0, gunPlugin v1.0-alpha, HPPlayer v1.0, ItemCasePE v1.0.8, ItemCMD v1, MCG76_MazeRunner v2.0.1, Mishkapvp v0.1, MobXtrem v0.1.2 BETA, MP v1.0.0, NewYear v1, OneShop v1.2, BlockHead v1, Boat v1.0, ColoredTags v1.0.0, FBlockHunt v1.0.0, Givecookie v1.0.0-release, GoldenApple v1, HoneyChest v0.0.0, HungerPE v0.0.0.1, MHelpModifer v2, MSpleef v1.0.0 Beta, MyHelper v1.0.0, NetherWorld v1.0-Alpha, QuelandiaPE v1.0.0, ReportHacker v1.0.0, SurvivalGamesPE v0.0.1.beta, SurvivalGames v1, SurvivalHiveJumpAndRun v1, PlayNoteBlockSong v1.1, Gills v2.0.0, PeacefulSpawn v2.4, xyz v1.0.1, WorldMonitor v2.0.0.000.0, AdvertisingKick v1.0.0, essentialsTP v1.1.0, AdvancedKits v4.0.1, iControlU v1.3, BanItem v2.1, ItemCloud v1.3, WorldEditArt v1.0.0_beta_dev_#048, SignStatus v3.0.0, xRulesx v1.0.0, KeepInventory v1.2.0, EnderPearl v1.2.3, BouncyBlocks v1.1, ManyWorlds v2.0.3, WorldProtect v2.2.0, GlobalShield v1.0.0, SexyMOTD v0.2, MagicTelePortal v1.3.2, SimpleLandGenerator v1.0.0, DamageIndicator v1.5, ColorMatch v1.1.2, TheDropper v1.0.0, ScoreBoardStats v1, Lightning_Strike v2, CalculatorPE v1.0.0, TierLoot v1.0.0, NoAdvertisingPE v1.0.0, PmChair v1.1, Potion v0.1B, PozitiveItem v1, PVPMoney v0.1-Alpha, ResetChest v1.0, SClan vBeta_2.6, ServerAuth v2.10, SnowHalation v1.8-alpha, SoundEffectJoin v1.0_beta, SpawnPort v1, Super_Block_By_Dakadegenerat1 v2.2.8, BetaTester v0.14.0 alpha build 6, TapReactor v2.5, TapToDo-LEET.CC v1.0.0, TimezoneFix v1.0-alpha, mcg76_TNTRun v1.2.2, TransformMob v0.1, UUIDBanning v1.0, VoteReward v2, Wolf v1.0.0, mwvent_Spleef v1.7.0, EssentialsPE v1.1.3, EconomyAirport v2.0.4, SignWarp v1.5.1, GrabBag v2.3.0, SkyBlock v1.0.2


rrrr


Looks like a a typo: `other && id == other.id` would match the previous logic.


а еще можно будет в редакторе добавлять несколько json-деревьев одновременно
как думаешь?


unused


@jsoutherland - Can you make sure this makes sense? It looks like the bit logic in set_servo_enabled() has been flipped (compared to libkovan) so I think this should be flipped too.


тут стремные названия классов


returning "[null]" isn't consistent with any other spring function, any specific reason why not just keep it unset?


Class RemoveGitMirror is missing a docblock.


@hyi @mauriel133 What happens to the 'Manage Access' button in case of published resource?


Like Vezzra stated above, it's not a problem for me, as it just requires to translate the keys of the actual messages. If I remember well, there is already this kind of stuff in the stringtables.

I'm not sure if it's related, but I noticed that a functional list must not be commented out (or a value that contains only a key), otherwise it doesn't fetch the actual translation in the current selected stringtables.

Ex:

`FLD_NEBULA_2
[[FLD_NEBULA_1]]

FLD_NEBULA_2_DESC
[[FLD_NEBULA_1_DESC]]`

These lines were commented out in the FR file (as they're the same than in en.txt), and instead of fetching the french translation of FLD_NEBULA_1 and FLD_NEBULA_1_DESC, it displayed the english strings in-game.

Whatever, it's again not a problem for me (I will not have commented out the functional list anyway).


You are welcome! :smile_cat:


@stze
Also: Do not call "connection_send_request" . If `params == NULL`  this will cause a segfault!
```c
if (params == NULL) {
   // send error response
} else {
  connection_send_request(pluginlongtermpk, cstring_copy_string("run"), params, api_error);
}

```


Lovely pet. I clearly see how it fits with the rest.


The condition statements can be omitted.


OK.
Should we remove all `UserString*` usage and remove `fo.userString* ` from python interface interface?


in development, but thx for the note


Зачем тут else?


Зачем сохранять таймер в переменную, если мы ее нигде не используем?


@lexmag "`Msgpax.Packer` protocol deriving" sounded awful; what do you think of this phrasing?


Since the wal directory is outside the shard directory, we should actually say "assocaited with" instead of "within". Fixed by ab702eb which will be squashed later.


Hmm... Shall we then leave the other url columns still be 255, e.g. url in the table representatives in OMP, and e.g. remote_urls in OJS? -- till someone complains... :-) -- Apparently, the URLs could fit till now, because I haven't heard anybody complain... :-)


Sorry already exist.
addStaticMember is receive freefunction, lambda, std::function type


Почему бы не написать вот так '/24321-kekstagram/'?


All your PHP includes should be at the top of your file. There is no point spreading them out and adding them 'where needed' since your HTML file is processed as a whole. In this case I'm referring to "include_once new_nav.php" on line 28.


One line space after includes please.


Nice. :+1:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15796](https://teamcity.mesosphere.io/viewLog.html?buildId=135394&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 226 Build time: 00:07:29


No need for the `if` above if you don't do anything if the error is non-nil


ooops ... no i just wanted to commit the report


Eventually we should make these weird stubs testify `mock.Mock`s


yea, I was copy-pastaing the touch method


same goes for this one ....  sorry


> There is no way afaics (before or after this patch) to use any value except Debug or Release.

Oh, I understand the confusion now.  It's possible to declare a `'configurations': { ... }` section in your binding.gyp (or more likely, a config.gypi or common.gypi) with e.g. an `OptDebug` target.

It's not a very common pattern but it does happen (I've used it myself once or twice) and I suspect this commit might subtly break that.


It seems useful to me – I don't expect that most applications would care about key order. We could also extend the interface to allow for marshalling dicts in order with manual calls, which might be good to do in Chihaya anyway to reduce garbage.


Will this accept licenses? I think it’s missing the `echo yes |` part.


I suggest to add a check that the mcsValue is consistent with the NSS value.


Why adding a MCS indication there and not in other NS_FAT_ERROR?


If you're not going to add the comments like in my wiki example, then empty line can be deleted.


@dpgeorge : FYI. My original SEC_SIZE patch included similar defaulting.


I hope you tested this, cause I wrote down the wiki code just as a guiding example for the class structure.


You can always find out by checking "sizeof(color_argb_t)". In this case, the attribute is superfluous, as both the struct and the uin32_t will be aligned the same.


@mibby I'm not taking feature requests, but if you [create a new issue](https://github.com/Erbros/Lottery/issues/new), someone else just might complete it for you.


extra line


Tabs


Extra space before comma


I thought careful was 15, we'll see how it goes.


nu cred


Extra line


ok, nevermind, I'll systemize it later


needs space before brace


[checkbox.txt](https://github.com/partha20/Formvalidation/files/129855/checkbox.txt)
checkbox


@elezar: please use one command for `apt-get update` and `apt-get install`, following the Docker best practices:
https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#apt-get
Also, I don't think you actually need all those packages.


Merge with line above as is the convention being used:   } else {


Space before brace


Nice! Definitely cleans it up from what we had before.


Tabs and spaces mixed around here


And redstone lamps?


This is what I was missing. Thank you for your patience and explanation.

I'll kill the last two commits and force-push, so they'll vanish and history will wonder what this thread was about.


Change to "database_table.php"


There's an extra space :3


Tabs and spaces mixed
Space before brace


Tabs


nice! i will take a look at it next weekend or during the week. i already thought about this and didn't know if it is hard to do, but this link provides a jump start. TY


Did you experience corpses not having the correct texture? This shouldn't be necessary given it's already called on respawn at https://github.com/Diffusion9/Sandbox.Stratis/blob/3dbbc116cf476163a972e4d5a99f1dbc243f2f2a/functions/loadouts/fn_equipPlayer.sqf#L83. I was having timing issues but they seemed resolved for me locally with the code linked.


Extra line


Oops!


Olympia!


Why does this base_class.php file exist when you have data_base_table.php?


Signal _that_ the skb can be eaten..


:clap:


If the model contains one other empty-name piece (which is not really handled) then "" would be ambiguous, and `nil` would break BC.


Cool, I can look into setting that up. Any reason for commenting on this line in particular?


I am not sure GetNumberOfReceiveAntennas won't be used in the future, it would give an indication on what is supported at Rx side.

E.g. a station can support 2 Tx antennas, but if receiver only supports 1 Rx antenna, only 1 stream should be used. I expected to use GetNumberOfReceiveAntennas to do that check.

I have not yet checked all other changes, so maybe you do that check in an other way?


Times have changed.


categorize_items or categorize_item?


lol i was looking at the kansas thing and wondering what sam did.


extra line


Maybe you could use -DCMAKE_INSTALL_PREFIX=/usr/local to install Caffe at a slightly more standard location.
At least `/usr/local/bin` should be in your `PATH` by default.

It would also be good practice to setup ldconfig afterwards:
`RUN echo "/usr/local/lib" >> /etc/ld.so.conf && ldconfig`


Space before brace


Tabs


Changed in 8348125  . :+1:


Extra line


tabs


Typo, and in general, I'm not sure most of the commands are very useful here. They just describe in plain English the command just below.


This line do not make a deep copy of the buffer, just equals the references, so when you do this, the returnBuffer will have the same reference of the inner buffer and the initial value will be collected by the garbage collector. Then, if you return returnBuffer you will actually return inner buffer.


ніяких філологів ще не треба, я коли виправлю усе, тоді уже філологи.

щодо великих літер - я не знав як правильніше, адже так було в оригіналі.


blank line after includes


space before brace


I don't understand the reason for this.  Why add extra code to handle None return, when it's just as easy to return 0 or 512 in the Python function??  What prompted this change?


@HashBang173 after latest update ABGR888 worked for me now i think that i cant reserve that 1mb properly it will be good if you describe a little about these values thanking in advance :)


BTW,  I said glControl was not working for WinForms & WPF - I found out the instructions at http://www.opentk.com/doc/chapter/2/glcontrol are wrong.  That should be easy to fix once I get access to the site HTML code.

Maybe I'll make a youtube video too - a good way to stir up new positive buzz about OpenTK.

@ilexp - you're 100% right making sure OpenTK survives is the most important thing, although eventually we do need to think about what new features will be added.  Like @thefiddler said, .Net Core / Vulkan is the most important thing.  I'm not sure if SharpGL has much to offer; I was mostly thinking about that b/cI was having problems w/ WinForms & WPF, but now I figured out they really are working w/ the current code from github.com/opentk/opentk.

A friend at work thought we should add our own physics engine.


Since you're contributing to BVLC/caffe, don't you want to transfer ownership of maintenance to the caffe maintainers?


look out for a PHP warning which is sometimes displayed on site if session_start() is the not the absolute first call in your file


This file should be named "utilities.php"


heh, now I see why it exists https://github.com/codegangsta/negroni/blob/master/negroni.go#L23. We don't need it since we're not following the net/http API or anything.


This test is failing I was wondering if you could look at this mike? Something is causing this to return true and need some extra eyes to maybe spot it.


f


There are spam mails exceeding 100k. @soujak Just create a pull request to increase the limit. I'm currently working with a limit of 500k (in combination with spamd).


Why do you remove
`this.$element.focus();`
?
Without the line, the popup is hiden after move the mouse over an option

```
mouseleave: function (e) {
  this.mousedover = false;
  if (!this.focused && this.shown) this.hide();
}
```


@Arik100 Čia būtų gerai panaudoti

`$scope.$on('DataAvailable', function (event, features) {
});`

čia kintamasis feature, tai būtų ką tu gauni po convertDataFrom, bet bus panaudoti jau turimi duomenys - nereiks antros užklausos daryt.

Taip pat, būtų neblogai, kad pagal dieną būtų nustatomas pseudo- randomiškai tas startupas - t.y. kad tą dieną jau esamas nesikeistų.


Removed 60 from alpha function


@rozhali jQuery is included in https://github.com/DevTips/Artists-Theme/blob/gh-pages/index.html#L38. You shouldn't have to do anything.


I'll probably make this 0.2.10 as the interface didn't change


I'll remove this print statement.


>That's besides the fact that code is supposed to be kept maintainable, so compiling to little-endian is still easy.

Fair enough. As long as people have the option to choose, then that's fine. I was thinking there would be no option to compile to little-endian, so I guess I have nothing to worry about now.

>Then, after, you just said, it's fine to have temporary optimizations? Despite the fact temporary optimizations like this make transitioning into big-endian harder and take even longer.

I was thinking it would be nice to keep this optimization even if temporary for anyone who really wants better performance, because I thought there wouldn't an option to compile to little endian. If it were up to me, I would just use #if #else, while still having the more optimized code, in order to be able to compile either endian.

One big reason why I prioritize the project leader's best interests is because if my priorities are very different than the project, then I do not wish to interfere with other people's work.


Since i made the changes on respawn pops up an error.
core/medical/fn_onPlayerKilled.sqf on line 110 undefined variable life_sidechat

[player,life_sidechat,playerSide] remoteExecCall ["TON_fnc_managesc",RSERV];


Why ask people to bloat their code with useless if's for features they aren't even interested in? How do they know they should return something in the first place? (We don't even define symbolic constants for ioctl types so far (because we don't know where to put them)).


For the secret, why the encode to ascii, then immediately decode it to utf-8? Why not encode it to ascii like the other field? Or, encode all the fields to utf-8?


has this intentionally been changed from 1000 (Required) to 750 (LayoutPriorityDefaultHigh)? (same below)


Good catch!


Hhah


I would use one command, but was trying to limit the `--no-install-recommends` to the boost install. Some of the other packages could be removed now that the development images have been removed from this PR.


> What prompted this change?

Me converting from old blockdev i/f to new, and sample stopping to work, and me needing to go to C source to see why it stopped working.


I don't care too much about the potential 500. I would rather crash when the API is used incorrectly instead of using `kind_of?` or something and program defensively around it.

For "ids", why don't we switch to the "filter" parameter that JSON API uses: http://jsonapi.org/recommendations/#filtering


Yeah it should have been 750 before (my bad) -- that way it matches what AutoLayout would generate from IB :)


Any code you had previously implemented using this lib shouldn't be affected since all constraints previously had the same priority. So should be fine


Wow! Can't believe I made such a mistake. :-)


@pmarsceill this could use some styling love. Just needed a contact email somewhere on the page to meet Apple's "Support URL" guidelines.


@scopatz Hi! I've been thinking about the decision to define the default value for $VIRTUAL_ENV. I think, it's not right.

When no virtual environment is active, this variable should not exist because it only makes sense in the context on virtual environments] management. When checking if an environment is active, in other tools like venv and virtualenv I'd check the existence of this variable, not its value. These tools define this variable when they activate an environment and delete it afterwards, so checking for its existence is common. To make Vox consistent with other tools, I think it's best to follow the common path.


In general looks good. However few action items:
1. Please configure your code formatter to make spaces, like try_SPACE_{, e)_SPACE_{
2. Rename methods deleteByRequestCollectionId to deleteMappedRequestsByCollectionId
3. Rename methods saveByRequestCollection to saveMappedRequestsByCollection


Note that SEC_COUNT is needed only for .mkfs() and not needed for normal mounting => defining ioctl() isn't needed for 90% of usecases (does it work like that?)


The default value is the value that you get *when* this variable is not set in the environment. That is why I think that this behavior is correct.


ここは何？


All that it does is prevent folks from having to pass in the default value every time they call `env.get()`


hi dumb asses this is 2nd


Единообразие: отступ


Which is what you were doing before.


Единообразие: пробел после двоеточия


change to boolean


Единообразие: пробел после запятой


Единообразие: пробел после двоеточия здесь, и в 23 строке


Единообразие: лишний пробел перед фигуркой


@Driesboy I have contact with the owner of EvolSoft, I will ask him to add some Genisys support features.

Also, how about doing what Spigot do and put unknown command, shutdown, whitelist etc messages in the Genisys.yml


Shouldn't we use an integer division here ?  (i'm not sure if it is an issue on python 2.7, but it will be on python 3)
It should be as simple as using // instead of /


Единообразие: лишний пробел после двоеточия - два вместо одного


Единообразие: лишний пробел перед фигурной скобкой


Единообразие: забыт пробел после двоеточия


You can use:
SendRaw("PART %s :%s", pChan->m_Channel, pReason);


All these Strings are constants, please follow name convention for constants in the Java.
For instance: GET_ALL


Actually, those properties have been the most important for making optimally performing conversion code in my experience.  Validated ASCII can simply be treated as UTF-8,
or, like Latin1, widened directly from 8-bit to 16-bit UCS-2 or UTF-16 or 32-bit UTF-32,
with operations that can operate on whole chunks of data at once using SIMD instructions (I'd hand coded those in the past for different instruction sets).

While it might seem by counting number of encodings, that these are just 3 out of many,
if you look at people's data, I'd say most of the data can be represented by those 3.
If you want to leave it out of the table, I think we should still have methods that return that state, set up for those 3 (more really, because with UCS-2 you really have all the different encodings of that subset of Unicode, i.e. little/big endian, with or without BOM, etc.), and then just having a fallback to false for all other encodings.


You see no? :P


Лучше кнопку с быстрым просмотров вложить в блок с bg-hover.
Надпись подложка я бы убрал и `font-size: 0`, тоже


What happened? The diff only showed one file!!!


По поводу форматирования CSS - на консультации могу удобную штуку показать, если не охота самому следить за написанием кода.


Yes. Gladly. @shelhamer What would be the email address to use in this case?


перед твоим style.css можно подключить файл стилей с google-fonts, я тебе про это в скайп написал.


@nirvdrum I don't know if you were using this for something, but it never gets executed for any test we run.


Sry for this stupid var... can use only 'm_NumUnreadMsg' xD


@nnarhinen - let me know if you see/tested something wrong with this. thx


Thanks, that worked. Will take a look at it :)


Just wondering: how does this commit handle name like SNCF or TER ?


39-41 строки, надо поправить отступы у изображений.


Что это за файл? Почему темп? Ты ещё не доделал?


I would've used https://www.npmjs.com/package/git-rev, would maybe simplify the code a few lines.


Зачем вы переизобрели цикл `for`?


First stab at #7


Does this make sense?


That makes two of us. I've hacked that definition dozens of times before.


ывмыв


above lines are not needed


I thought it was 1000 by default. i.e.
`New constraints are created with a default priority of 1000, which makes them required. Generally, you won’t need to change the default priority` [Editing Auto Layout Constraints](https://developer.apple.com/library/ios/recipes/xcode_help-IB_auto_layout/chapters/EditingConstraintAttributesintheAttributesInspector.html)


Эта операция обнуляет состояние генератора случайных чисел. Её, если и делают, то только один раз в самом начале скрипта, передавая какой-то определенный seed, чтобы обеспечить воспроизводимость результатов при тестировании, когда это требуется.


Nice


Everything seems to work.
It now remains to finish ZFS on LUKS ;)

btw: I have tinkered a script for quick test installation.
Maybe useful for someone ;)

```
#!/usr/bin/sh
DIR="pwd"
chmod +x $0
(( EUID != 0 )) && exec sudo -- "./$0" "./$@"
if [[ $EUID -ne 0 ]]; then
  echo "You must have a root permissions" 2>&1
  exit 1
fi

doWork() {
latest_build="$(wget -O- -q https://raw.githubusercontent.com/Antergos/antergos-iso/master/configs/antergos/root-image/etc/lsb-release | grep "DISTRIB_RELEASE=" | cut -d= -f2)"
hdd_dev=$(fdisk -l | grep 'Disk /dev/s' | awk '{print $2}' | sed -e 's/://g')
pool="$(zpool list -H | awk '{print $1}')"
reboot=0

# check build for update
if [ "$latest_build" != "$(cat /etc/lsb-release | grep "DISTRIB_RELEASE=" | cut -d= -f2)" ]; then
  read -r -p "This is not a latest build!
Please download the latest build and try again, otherwise issues may occur during installation.
Continue anyway? [y/n]: " response
  case $response in
    [yYjJsS])
	  echo "Note: Issues may occur during installation!"
	  ;;
	*)
	  echo "Please download the latest build here: http://build.antergos.com/browse/testing and try again."
	  exit 0
	  ;;
  esac
fi

# Destroy pool if existing
if [ ! "(zpool list | grep 'no pools available')" ]; then
  echo "Destroy existing pools..."
  zpool destroy -f $pool
  reboot=1
fi

if [ ! "$(wipesf $hdd_dev)" ]; then
  echo "Wipe a flie system on \"$hdd_dev\""
  wipefs -a $hdd_dev
  reboot=1
fi

if [ "$reboot" -eq 1 ]; then
  read -r -p "You must reboot, otherwise issues may occur. Performing a restart? [y/n]: " response
  case $response in
    [yYjJ])
	  reboot
	  ;;
	*)
	  echon "Will not restart!"
	  ;;
  esac
fi

# Clone and run Cnchi

if [ -d Cnchi ]; then
  cd Cnchi
  if git checkout master &&
     git fetch origin master &&
     [ `git rev-list HEAD...origin/master --count` != 0 ] &&
     git merge origin/master
  then
    echo 'Updated!'
	./run
  else
    echo 'Not updated.'
	./run
  fi
else
  echo "Clone and run Cnchi"
  cd $DIR
  rm -r Cnchi
  git clone https://github.com/Antergos/Cnchi.git
  cd Cnchi
  ./run
fi
}

DATE=`date +%Y-%m-%d:%H:%M:%S`

doWork | tee logfile_$DATE.txt

exit 0
```


implement these methods by using appache library


I see, and if you named a piece "[null]" you deserve what's coming :D


after taking a double look at it, I finally figured out what I had, or rather had not, done.  fixing.


Above lines are not needed


Resolved here: https://github.com/harthur-org/brain/commit/25f0e96a39cf37f4af7ecc755d0d88dabfabe522


1. Про сравнение строк и разницу между операторами `is` и `==` я много говорил на прошлом занятии. Постарайтесь вспомнить, почему это плохо.
2. Зачем так много лишних скобок? `(random.choice([1,2,3]))`
3. `random.choice([1,2,3])` - здесь список создается заново на каждой итерации цикла. Когда этих итераций много, это ощутимо сказывается на производительности.


You need to just subtract and add 100000:
https://github.com/HashBang173/kernel_motorola_msm8992/commit/a6959bcd070d4b9ffc7c85493d6af888702abe0a

for clark, I did 0xaf000000 - 0x100000 and got 0xaef00000
and I did 0x80000 + 0x100000 and got 0x180000


put (Request) obj directly in the method reflectionEquals


above lines (271 - 281) are not needed


Why is the `channel_set_admin` command incomplete?
Is there a reason?


You need to fix that.


Ahh, I was thinking about hugging priorities -- my bad -- can update


good, then please skip my comment for the previous your commit :)


Ещё вы могли делать `random.choice` напрямую от списка с вашими словами, тогда не потребовался бы этот велосипед с индексами и ненужный словарь.
`random.choice(prize)`


What is AM in the class name?


Oh, now I see. Sure, it makes perfect sense, I just misunderstood how default values work.

Thanks for the clarification!


Actually `Array` has its own `first` method. (That's true for a lot of the `Enumerable` methods, where `Array` can implement them more efficiently.)
I measured the difference with `Benchmark` and `[0]` is 1.3X faster that `first`.  So not a compelling speed-up.  And look at it in absolute terms:
```
$ irb
irb> require 'benchmark'
irb> a = (0...10_000).map { |i| "*"*80 };
irb> puts Benchmark.measure { 1_000_000.times { a.first } }
  0.070000   0.000000   0.070000 (  0.065628)
=> nil
irb> puts Benchmark.measure { 1_000_000.times { a[0] } }
  0.050000   0.000000   0.050000 (  0.054143)
=> nil
```
So 20 milliseconds faster across 1 million operations!


lines 69-73 are not needed, that library shoud cover these cases, isn't it?


the same as for previous class


@HashBang173 thanks :)  can u please give you hangout id or might be telegram so that i could discuss with u there, it isnt much suitable to talk here :D


No worries!


Screen capture:
http://s15.postimg.org/g1xvnj0gb/Siege_time_on_hud.png


Совершенно нечитаемый код. Во-первых, вы забываете, что в питоне, за редким исключением, итерируются напрямую, а не по генераторам чисел-индексов. Во-вторых, имена переменных. В-третьих, `zip`. Посмотрите на примеры решений у меня.


I guess this one actually messes with your fix,  in my latest source its back to the above.


are lines 158 - 164 are needed? Doesn't below method cover these cases?


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.discussion/32//violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/__init__.py Imports are incorrectly sorted.
plone/app/discussion/__init__.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/catalog.py Imports are incorrectly sorted.
plone/app/discussion/catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/catalog.py:0:1: I001 found unsorted imports
plone/app/discussion/catalog.py:89:17: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/comment.py Imports are incorrectly sorted.
plone/app/discussion/comment.py:0:1: I001 found unsorted imports
plone/app/discussion/comment.py:77:28: Q000 Remove bad quotes.
plone/app/discussion/comment.py:172:40: Q000 Remove bad quotes.
plone/app/discussion/comment.py:174:30: S001 found %s formatter
plone/app/discussion/comment.py:178:48: S001 found %s formatter
plone/app/discussion/comment.py:213:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
plone/app/discussion/comment.py:250:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:259:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:268:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:277:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:303:21: Q000 Remove bad quotes.
plone/app/discussion/contentrules.py:0:1: C101 Coding magic comment not found
plone/app/discussion/contentrules.py:18:5: E731 do not assign a lambda expression, use a def
plone/app/discussion/contentrules.py:26:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:48:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:59:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:70:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:81:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:92:1: E302 expected 2 blank lines, found 1
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/conversation.py Imports are incorrectly sorted.
plone/app/discussion/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/conversation.py:0:1: I001 found unsorted imports
plone/app/discussion/conversation.py:67:27: Q000 Remove bad quotes.
plone/app/discussion/conversation.py:205:16: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:214:12: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:220:12: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:324:8: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:453:29: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/events.py Imports are incorrectly sorted.
plone/app/discussion/events.py:0:1: C101 Coding magic comment not found
plone/app/discussion/events.py:0:1: I001 found unsorted imports
plone/app/discussion/events.py:11:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:33:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:38:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:43:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:48:1: E302 expected 2 blank lines, found 1
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/interfaces.py Imports are incorrectly sorted.
plone/app/discussion/interfaces.py:0:1: I001 found unsorted imports
plone/app/discussion/interfaces.py:135:17: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:161:65: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:247:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:262:21: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:280:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:284:23: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:291:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:308:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:390:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:394:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:398:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:402:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:406:1: E302 expected 2 blank lines, found 1
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/patches.py Imports are incorrectly sorted.
plone/app/discussion/patches.py:0:1: C101 Coding magic comment not found
plone/app/discussion/patches.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/testing.py Imports are incorrectly sorted.
plone/app/discussion/testing.py:0:1: C101 Coding magic comment not found
plone/app/discussion/testing.py:0:1: I001 found unsorted imports
plone/app/discussion/testing.py:13:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:14:1: B901 blind except: statement
plone/app/discussion/testing.py:15:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:66:14: Q000 Remove bad quotes.
plone/app/discussion/testing.py:78:10: Q000 Remove bad quotes.
plone/app/discussion/testing.py:81:10: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tool.py Imports are incorrectly sorted.
plone/app/discussion/tool.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tool.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/upgrades.py Imports are incorrectly sorted.
plone/app/discussion/upgrades.py:0:1: C101 Coding magic comment not found
plone/app/discussion/upgrades.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/vocabularies.py Imports are incorrectly sorted.
plone/app/discussion/vocabularies.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_catalog.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_catalog.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_catalog.py:89:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:107:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:114:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:135:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:142:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:158:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:173:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:191:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:199:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:212:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:224:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:235:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:243:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:250:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:280:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:299:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:307:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:347:40: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:380:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:386:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:429:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:436:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:450:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:450:49: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:533:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:578:25: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_comment.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_comment.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_comment.py:55:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:56:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:57:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:106:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:108:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:114:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:130:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:131:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:135:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:136:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:158:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:166:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:179:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:182:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:187:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:231:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:262:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:267:23: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:304:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:329:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:371:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:407:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:442:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:450:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:459:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:468:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_comments_viewlet.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_comments_viewlet.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_comments_viewlet.py:43:1: F811 redefinition of unused 'IConversation' from line 38
plone/app/discussion/tests/test_comments_viewlet.py:112:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:126:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:134:43: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:135:60: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:137:66: W291 trailing whitespace
plone/app/discussion/tests/test_comments_viewlet.py:180:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:194:59: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:196:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_comments_viewlet.py:236:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:281:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:316:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:405:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:406:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:411:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:416:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:417:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:418:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:429:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:430:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:431:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:487:63: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_contentrules.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_contentrules.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_contentrules.py:6:1: F401 'notify' imported but unused
plone/app/discussion/tests/test_contentrules.py:22:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_contentrules.py:51:24: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:52:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:53:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:54:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:59:5: E303 too many blank lines (2)
plone/app/discussion/tests/test_contentrules.py:117:38: S001 found %s formatter
plone/app/discussion/tests/test_contentrules.py:121:38: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:122:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:123:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:126:9: F841 local variable 'new_re_id' is assigned to but never used
plone/app/discussion/tests/test_contentrules.py:135:35: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_contentrules.py:145:44: E127 continuation line over-indented for visual indent
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_controlpanel.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_controlpanel.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_controlpanel.py:36:18: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:43:56: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:92:5: F811 redefinition of unused 'test_edit_comment_enabled' from line 84
plone/app/discussion/tests/test_controlpanel.py:145:5: E265 block comment should start with '# '
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_conversation.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_conversation.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_conversation.py:31:1: B901 blind except: statement
plone/app/discussion/tests/test_conversation.py:91:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:93:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:94:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:95:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:96:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:96:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:97:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:518:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_conversation.py:560:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:565:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:570:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:575:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:969:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:973:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:978:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_events.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_events.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_events.py:15:1: E302 expected 2 blank lines, found 0
plone/app/discussion/tests/test_events.py:26:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:29:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:32:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:35:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:40:1: E302 expected 2 blank lines, found 0
plone/app/discussion/tests/test_events.py:81:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:99:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:138:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:151:38: S001 found %s formatter
plone/app/discussion/tests/test_events.py:157:9: F841 local variable 'new_re_id' is assigned to but never used
plone/app/discussion/tests/test_events.py:171:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_functional.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_functional.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_indexers.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_indexers.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_indexers.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_indexers.py:54:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:55:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:62:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:63:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:70:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:71:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:110:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_indexers.py:112:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_indexers.py:139:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:140:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:170:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:170:41: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_migration.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_migration.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_migration.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_migration.py:55:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_migration.py:68:14: Q000 Remove bad quotes.
plone/app/discussion/tests/test_migration.py:214:9: E265 block comment should start with '# '
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_moderation_view.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_moderation_view.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_moderation_view.py:111:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:119:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:127:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_notifications.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_notifications.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_notifications.py:37:42: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:64:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:86:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:87:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:102:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:130:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:146:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:151:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:176:42: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:227:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:228:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:234:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:238:13: S001 found % formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_tool.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_tool.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_tool.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_tool.py:32:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_tool.py:42:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_tool.py:43:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_tool.py:43:15: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/tests/test_workflow.py Imports are incorrectly sorted.
plone/app/discussion/tests/test_workflow.py:0:1: I001 found unsorted imports
plone/app/discussion/tests/test_workflow.py:58:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_workflow.py:94:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_workflow.py:133:38: S001 found %s formatter
plone/app/discussion/tests/test_workflow.py:153:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_workflow.py:154:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_workflow.py:203:38: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/captcha.py Imports are incorrectly sorted.
plone/app/discussion/browser/captcha.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/captcha.py:64:39: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/comment.py Imports are incorrectly sorted.
plone/app/discussion/browser/comment.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/comment.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/comment.py:45:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:45:20: S001 found %s formatter
plone/app/discussion/browser/comment.py:47:41: S001 found %s formatter
plone/app/discussion/browser/comment.py:53:10: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:92:52: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:95:40: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:95:58: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:108:1: E265 block comment should start with '# '
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/comments.py Imports are incorrectly sorted.
plone/app/discussion/browser/comments.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/comments.py:94:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:100:35: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:128:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:129:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:130:42: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:132:1: C901 'CommentForm.handleComment' is too complex (15)
plone/app/discussion/browser/comments.py:141:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:142:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:157:16: E713 test for membership should be 'not in'
plone/app/discussion/browser/comments.py:210:53: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:251:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:252:22: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:275:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:276:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:325:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:328:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:336:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:344:37: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:415:20: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:415:21: S001 found %s formatter
plone/app/discussion/browser/comments.py:462:17: S001 found %s formatter
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/controlpanel.py Imports are incorrectly sorted.
plone/app/discussion/browser/controlpanel.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/controlpanel.py:34:10: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:90:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:91:48: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:96:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:97:40: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:97:41: S001 found %s formatter
plone/app/discussion/browser/controlpanel.py:113:46: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:119:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:126:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:128:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:131:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:135:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:141:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:168:46: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/conversation.py Imports are incorrectly sorted.
plone/app/discussion/browser/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/conversation.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/conversation.py:20:1: B901 blind except: statement
plone/app/discussion/browser/conversation.py:32:1: C901 'ConversationView._enabled_for_archetypes' is too complex (14)
plone/app/discussion/browser/conversation.py:138:12: P002 found "hasattr", consider replacing it
plone/app/discussion/browser/conversation.py:138:29: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/migration.py Imports are incorrectly sorted.
plone/app/discussion/browser/migration.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/migration.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/migration.py:37:1: C901 'View.__call__' is too complex (32)
plone/app/discussion/browser/migration.py:44:19: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:48:16: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:80:26: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:82:31: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:83:22: S001 found %s formatter
plone/app/discussion/browser/migration.py:181:25: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:181:26: S001 found %s formatter
plone/app/discussion/browser/migration.py:191:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:191:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:205:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:205:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:206:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:206:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:207:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:207:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:209:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:210:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:228:21: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:229:31: S001 found %s formatter
plone/app/discussion/browser/migration.py:237:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:238:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:239:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:239:28: S001 found %s formatter
plone/app/discussion/browser/migration.py:246:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:248:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:249:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:250:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:252:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:253:13: S001 found % formatter
plone/app/discussion/browser/migration.py:257:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:257:18: S001 found %s formatter
plone/app/discussion/browser/migration.py:261:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:262:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:266:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:267:17: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/moderation.py Imports are incorrectly sorted.
plone/app/discussion/browser/moderation.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/moderation.py:100:15: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:101:18: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:139:15: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:140:18: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/traversal.py Imports are incorrectly sorted.
plone/app/discussion/browser/traversal.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/traversal.py:0:1: I001 found unsorted imports
plone/app/discussion/browser/traversal.py:32:20: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.app.discussion/plone/app/discussion/browser/validator.py Imports are incorrectly sorted.
plone/app/discussion/browser/validator.py:0:1: I001 found unsorted imports
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


This changes the behavior of the bundle's cookie. The default expiration is zero, which [deletes the cookie when the browser session closes](http://php.net/manual/en/function.setcookie.php). Now the default value sets the cookie to expire at the current time.


But it wasn't DRY to have those `\n` characters at the end of every string. We think that DRY, intention-revealing code is best. Again I suspect the time savings to optimize away `+` would be milliseconds for millions of files.
Hey, with the `\n` characters out of those comment literals, we could go back to single quotes there!  :stuck_out_tongue_winking_eye:


This line needs to be fed with real data.


Yes, we need an integer result. And I didn't not know / is not in python 3.


please add applicationId to the log message
Looks like message is copy pasted from the Request service ;)


add id to the log message


Lista estática.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15797](https://teamcity.mesosphere.io/viewLog.html?buildId=135400&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:09:16


use method LOGGER.error(msg, e)


argument is not needed


It did not, but starts report at least 5 upper case letters, avoiding lot of problems.


add application id to the log message


Why ref here?


@RONNCC we don't want to remove the Gemfile.lock (see the links below) and I am planning to write some comprehensive documentation for Binder, especially as it relates to deployment on our production server.  Can you remove this commit and force push to this branch? Thanks.

http://thelazylog.com/you-should-always-commit-gemfile-lock-and-schema-rb/
http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/


This should be replaced by a state != open check.


I think the added file here is a mistake


should fix: https://github.com/ArmaLife/Altis/commit/77069bdb43d38f161763f7e58e502851673e57c6


:+1:  here is another link that I found later, which is much more descriptive:
https://www.debian-administration.org/article/316/An_introduction_to_bash_completion_part_1


Add to all error mesages information about object, like obj id (application id or service id)
Use for all error loging method - LOGGER.error(msg, e)
Fix log message. Not request, but service or Application


The condition statement can also be omitted


Good that use short class name


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15798](https://teamcity.mesosphere.io/viewLog.html?buildId=135404&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 226 Build time: 00:09:24


not actual anymore


I improved documentation of the Base Pack, take a look to see if it is clearer


Skyblock


HEY I WILL SOON


Nice. I think it is working (haven't the keyboard attached at the moment..)
I simply symlinked the Extensions dir, and recompiled the library (so, no need to restart the sc ide).
```
$ ln -s ~/Src/kaos/github/overtone/plewto/PigOSC/sc/Extensions ~/Library/Application\ Support/SuperCollider/Extensions/PigOSC
```
```
Poly1     isDead false:
      MIDI input channel 1 (1..16)
      OSC ID SS1    Synth ID SS1
      OSC Addresses a NetAddr(127.0.0.1, 57120)
      OSC callback  a NetAddr(127.0.0.1, 58000)
      outbus nil
      keyrange [ 0, 127 ]  transpose 0
      Bender: 200 cents
      MapperSuite source Keynumber domain [ 0, 127 ]
      MapperSuite source Velocity domain [ 0, 127 ]
      MapperSuite source Pressure domain [ 0, 127 ]
      MapperSuite source PitchBend domain [ 0, 16382 ]
      CCMapper
a Poly1
```

Will look at the python stuff next, and play some with sc to get to know that beast better..


Should this not be `i2cRead(address, bytesToRead, handler)`?


I will push updates soon


I think it is already `false` by default. Also, you haven't allocated an ID for the user -- this won't work for `mutableUsers = false` and also generally avoided.


Well, the most important part is to make sure that:
1. Through any of the content document that I can reach, I can get discover that its part of a publication (through a link in the headers of either HTML or HTTP).
2. I can access the JSON manifest for that publication easily.

You're correct Matt that whether the JSON is embedded in an HTML document or not is actually less important than these two points.

What we're discussing here is if it actually makes sense to embed it in HTML, which I don't think is the case:
1. It makes things a little more complex for reading systems since they'll need to parse the HTML first.
2. I don't think that any content document is actually more important than the others, and should therefore be indexed as the "homepage" of the publication (one author might prefer the cover to be the document with the highest visibility in a search engine, while another might prefer the table of contents).
3. By using a link to the manifest instead of embedding it, we're more closely aligned with what the W3C does for the Web App Manifest. Ideally I'd like our manifest to either be linked from or embedded in a Web App Manifest.
4. I personally want to make sure that we'll be able to use the same JSON construct and metadata for a future 2.0 revision of OPDS, which would make it very easy for an OPDS client to also handle an EPUB BFF. There's no way we'll ever embed OPDS in HTML, it makes absolutely no sense.


no need


@lazybotter Something I will fix soon. It can't write to the file since I forgot to create the directory for the file when it doesn't exist yet. I think the easiest workaround is to create at least one tile stamp (see the Stamps view), since this will create the same directory (and is the reason why I didn't run into this problem).


It might happen to return true without eating any SKB when all the SKBs from the queue had already been received (see line 889 in the while loop above).


Hehe, sorry about this one @Guria , was not aware of the options object. But we have some inconsistency there. We already grab stuff from options.

But after latest talk on context I think we should remove options. Because now we are starting to put other stuff on there which is not serializable and just adds load to the signal.

So I suggest we remove options and extract the options that is actually related to signal execution. Does that make sense?


> 테스트 케이스 없는 코드는 작성하지 않는다
 무시무시하고만.. :+1:


`enable` wants service name as a parameter -- otherwise you'll get something like "Whether to enable Whether to enable ...."


mpv/qthelper.hpp is referenced but not added


PEP8이 뭐야?


Not sure if this was tested, but it does not work. Used in helper-functions and also tested in the theme's custom-functions, the generated AMP page still has @type:BlogPosting.

Using either the helper-functions or theme's custom-functions for other things, work no problem.


thx for the pointer


Вы можете мне сами своими словами описать пошагово весь ваш алгоритм? И зардно сравнить его с тем, что требуется.


fix pushedb


testing


Yea that looks good.   I did the same thing regarding a symlink.

At this point you should have OSC reception working on the supercollider side.
Take a look at the Transmitter object in transmitter.py for a list of possible messages.


readme edits


this test won't work because `typeof` returns string. change second argument to `'undefined'` please ;)


based on https://github.com/sebsauvage/Shaarli/commit/029f75f180f79cd581786baf1b37e810da1adfc3


No leaks were fixed, actually. Only style corrections.


@PhrozenByte So, I was thinking about this, in response to #326, and realized... wouldn't it be cleaner to do something like this:
```twig,html
{% if section is iterable %}
  <li>
    <a href="#{{ sectionKey }}">{{ section|first }}</a>
    {{ macros.rnav(section) }}
  </li>
{% else %}
  <li>
    <a href="#{{ sectionKey }}">{{ section }}</a>
  </li>
{% endif %}
```

This would make it more generic, not requiring a specific "_title" item, but instead just using the first child entry in that section of the toc.  What do you think?  I may try this in NotePaper sometime and see how it works.  If you like it (and, for that matter, it even works the way I'm thinking), I can update it here and finally write some instructions to go with it. :smile:


Is this necessary?


HahaI'm, why it return string? 😉


@mxalbert1996 Does it's permit to do screen shot of,for example,game,browser,or other?


There is still an outstanding jsPlumb issue when removing a task. See: https://github.com/angular-gantt/angular-gantt/issues/585


Don't figured what you mean. Better move to separate issue.


There was an error in the code, audio was declared twice :
CPPSRC += audio_avr.cpp debug.cpp
and :
ifeq ($(AUDIO), YES)
    CPPDEFS += -DAUDIO
    CPPSRC += audio_avr.cpp
    BUZZER = NO
  else
    BUZZER = YES
  endif

Now, with this correction, audio works well, that was not the case before. But I did not see that is was not working with audio=no, sorry :(

I found the solution, it will fix it now.


Updates -> Update


:ok:


Good idea :-) I can explain better with examples too


Oh fuck


Props passing is more tedious than explicit connecting, and developers can make a mistake resulting in worse performance passing {...this.props} everywhere. Connect is fine.


No there isn't it is just not being displayed right


I'm not sure we want this behavior because we want use a symlink to direct uploads to the appropriate folder on the production server (see the repo as is).  While this does mean that developers will have to overwrite that link, I think we want the project to most closely reflect the production config when forced to make a choice.


ok, I see you did the fix in 3f3ccc26686286cfbb5fc3bcac79d56c14fdc2be


I meant to say I made it hardware accelerated. This is better for views with alpha (which seen submissions are)!


that include x264 codec.


Ahh right, if formats itself. Thanks for pointing it out :)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15758](https://teamcity.mesosphere.io/viewLog.html?buildId=135170&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 226 Build time: 00:08:49


Is there a planned eventual use for `addr` in a `store`?


Found the problem (on clang). The format is not handling SIMD_PARA_SHA1 > 1  (not sure this is the problem on mingw build on circle-ci) ,but I will have to take them 1 at a time.

I just have to get it working now with proper multi para.


oooo


Exactly, i have a tactic so it is difficult in reproducing my code. (So that people wont plagerise)


But your issue was a minor one not from my tactics


invalid-email-address attacks again! (dammit)


This is an oddly name type, since typically you would expect a pool to be composed of homogenous values. Something like `ServerList` might be clearer.


It is because you are missing a }


please do not change the formatting, use the similar way that is used everywhere else


if placer and not placer:get_player_control().sneak then ?


This could be all put inside Creature::CanStartAttack, including the UNIT_STATE_SIGHTLESS check. Creature::CanStartAttack is only supposed to be used for the MoveInLoS attack checks.


There should be a `//PaperSpigot end` here


I strongly feel that this query can be simplified.
@narahari-archana please look at this and see if you can simplify it. Discuss in the group.


^ :package:


good update but in the proccess left us with (We're not in kansas any more toto) lol this made me laugh but realized that I had to clear cookies to get in. *Fills you with determination*


Will these clash with magit?


I just thought of it..


With comments, I prefer the current interface. We could change the method name to `FindClientForPeer` to be clearer perhaps.


Lists can contain any data type. Only text, numbers and Boolean can be preloaded.


this is very unnecessary change. the if statements above were already handling this. please revert.


I know. I read that discussion.

To me, I thought @voussoir meant "sticky=False" as a keyword argument  by

> Maybe we can add a more general data parameter / kwarg to Moderatable.distinguish

Not to update from the kwargs. Opening up the kwargs to any possible key value pair can be theoretically dangerous if a API change takes place or theres a bug with a secret data param, or just for the sake of protecting the user.


this documentation should have been moved to the type declaration instead of being deleted


Why does this interface need the Create/Delete methods? It doesn't make sense for the tracker itself to call them (the store would be file-backed, db backed, or whatever, but from the tracker's perspective is read-only)


For consistency, no spaces just inside the curly brackets. Here and in all recipies below.


Why was it broken into another repository? It isn't a generic enough implementation of bencode (the non-determinism only makes it suitable for our tracker usage).


Yeah, what is currently under the `api` package in the master branch would be actually exposed by the store server.


where?


it may be appropriate to serve a small html file directing users to https://letsencrypt.org ?


For basic public trackers, yeah. I wanted a good baseline storage, but if people want to implement their own for other logic, they can.


True, but I don't really see this changing in the future.


YUP


It is not to copy values. It's actually a clever trick that lets the package define its own custom config structure that the top level config package doesn't know about.


I dont know because i dont have your code but i just know that sonehwre, you are missing a closing item


srsly i added 1 new set and both times i got that


This change causes the code to expect/assume that the first argument to assertions such as `assert-true` to be function expressions. So code like `(assert-true (and (x) (y))` no longer works (because `and` is a macro). Is this change in behavior intentional?

(cc @wobh)


any ideas?


Please move "Edit 1 from fork/featurebranch" before "Edit 2 from upstream/master"


missing semi-colon at the function ending


That `m_info` (also in other attacks) should be `m_warning` instead.
Info is mostly for harmless, out of combat stuff, like "you need x to craft y".


No wildcard imports please


Seriously, awesome, thank you.


missing semi-colon


Can we just have a normal for loop here


i think it finally worked?


Here you've got "lunges at [body part], battering you", while below, in longswipe, it's "slashes at [body part] damaging it".
I think the latter version is better - it implies that the specific body part got damaged.


missing semi-colon.
also, change the word department, as it is going off context. Use `notification_category`


```java
public static Direction[] NESW = { NORTH, EAST, SOUTH, WEST };
```

Also note the spacing around entries pls


Same comment as `NESW`.


Think about the difference between a private tracker announce, my custom jwt one, and a normal public tracker announce. The private one has a passkey, the jwt has a token, and this would all have to be put on top of the basic public tracker announce struct. I initially had this code using interfaces. You can try and do type assertions in the middleware to see if the type actually implements the interface, but the code ends up verbose and just as clumsy as if you just checked a map for a key. This way the (http|udp) parser can handle all the cases and those not using the features won't care.

I don't think there is a real good solution to this problem.


I believe this commit is responsible for the slow charging since it sets the voltage too low. Try reverting it.


Blank line after after this brace please.


Oops, how silly of me.


- RGB Led (Luxeon styled) support
- Button triggers ported to OneButton library. It  adds more trigger => we can add even more functions... Arduino Nano space will become a problem tho.
- Added ledstring/RGB blaster effect ( randomly shut down one segment for a
short amount of time / change color on RGB)
- Added some more sounds to config Mode
- Added boot sounds of soundfont when selecting them in config mode. (still buggy)
- changed powerOff trigger => via long press on Main button (less risk of shut it down by accident)
- Code cleaning


This is already in `Direction`, so just call it `opposite`?


add external in the name


They are homogenous values; they're Servers.


Great. This is something I wanted you to check and propose :-)


This information is already there in `$rootScope.user_info` and it is loaded initially. You don't need to do this.


Done


lol i cut of some *} else {* things


Naval cfabs shouldn't be building teleporters.


These are going to be used by the API


`directionComponents.length` instead of 2 so this loop immediately makes sense pls


yeah, i didn't know what to call it -- I only want one, ever.


Space before {


Same comment about spacing as above


The reason it looks like one big table is because back in the day Devs were not nearly as smart as they are now... ok they were just as smart, but conventions and technologies that make coding easier hadn't been developed yet.  An easy way to format your page and force certain things to be in certain places was to make the entire page a table and put your content in the <td> tags... this is considered bad practice and is pretty much laughable these days. Infact I took an intro to web development class and one of the assignments was to organize the page as a table like that.  I wrote the professor and said I respectfully decline to do your assignment as I cannot produce bad code.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15759](https://teamcity.mesosphere.io/viewLog.html?buildId=135175&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 226 Build time: 00:07:30


No blank line here please (also trailing comma on `PROJECTILE_SOUTH_EAST` would be nice)


Yes, but arguably, if the creature is sightless, then `MoveInLineOfSight` shouldn't be called, ever.

While `CanStartAttack` is used that way _now_, it's hard to tell what might happen in the future, so I'd prefer to keep it as is.


metering-agent应该是漏掉了，启动顺序如果没有关系就没必要指定


Not This is enough ok dnn't make changes in my code


_please_ for the love of all that is good in this world do not align doc comments


Wow, que legal!

Jekyll é bem bacana, eu acho legal por ele ser bastante fácil de usar, eu as vezes escrevo posts inteiros dentro do github xD

Se tiver alguma dúvida de como usar algo, só me falar, eu fiz várias mudanças específicas, que as vezes pode ser até desnecessário para você.


Random indentation here


this kind of CSS might be already there, check the director theme


:+1: for not having redundant nouns in method names and for making it an instance method.


`logger` not `LOGGER` please, most `Logger`s are stateful.

also

```java
/**
 * The {@link Logger} for all WalkingQueues.
 */
```


no empty line here pls


doc alignment :-1:


damn damn double damn


```java
/**
 * The {@link World} of the Mob the PathfindingAlgorithm is being applied to.
 */
```


Hello Professor,

cmed08 was my user name from the course last semester. I dropped it but my development environment used my that name when I modified the first three files.  I was able to modify it for the remaining files. I hope that this would not affect my grade.


that was why


```java
@param The {@link World} of the Mob the SimplePathfindingAlgorithm is being applied to. Must not be {@code null}.
```


Have jbboyton add you as a contributor, and clone the project (git clone ) then do a git checkout -b toddsNewIdea. Then make your edits. Do a git commit -m"What Todd did" (best practice is git commits should be in present tense "fix the bug in code" not "fixed the bug in code"). Then do a git push and your code will be submitted for review and jbboyton can do a git merge on the master branch. See easy stuff! I know it might be confusing, but you honestly will only use 10 commands with git at most getting used to them is a little difficult, and if ever you are facing a merge conflict or some kind of issue you can just delete your local repo and do a git clone and have the working project clean


```java
@param The {@link World} of the Mob the PathfindingAlgorithm is being applied to. Must not be {@code null}.
```


Not exactly, if a document changes it will be flagged as modified: https://github.com/jeffrymorris/Linq2Couchbase/commit/a35b854ca5e780fd8dbf73be7247dbe66132d909#diff-366afa3a09312cc54d2eee7acf09f6beR84

Although, I took the arse-backwards approach and do it in the interceptor...that logic can change without impacting the API from a user perspective. I'll refactor this a bit later so its more consistent.

The Save method is only called when change tracking is not enabled.  I guess that code isn't really needed, since the document will have already been added to the modified list when the property was changed. Perhaps I did that for new docs (I don't recall)? Of course, as you mentioned they need to be proxied as well.

Still some missing pieces as you have pointed out.

-Jeff


Doc comment here is wrong. IDEA can check this for you

```java
@param The {@link World} of the Mob the AStarPathfindingAlgorithm is being applied to. Must not be {@code null}.
```


hmm, handling multi buffer with para > 2 is not as easy as using GETPOS() macro. That macro only works for 1 crypt limb.  Each limb, you have to move the pointer ahead, so you only work on all SIMD mixed values from that next buffer.   (New information for me).

This is likely what was wrong with Mingw also.  I have it now working up to cmp_all(3) failing, so I'm getting closer.


Main.UpdateRepo() eventually calls Tabcontroller.cs:131 m_TabControl.SelectTab()

Since it runs asynchronously (Main.cs:301), it's be called after ModList.Select(). ModList isn't reselected, just the tab, so of it doesn't end up with focus until you click a checkbox.

I have no idea why clicking a row doesn't focus ModList, but I saw that the main form doesn't, apparently, have focus when that's the case.


Doc comment here is wrong. IDEA can check this for you

```java
@param The {@link World} the NpcMovementTask is running on. Must not be {@code null}.
```


merge


sounds good... do a git checkout-b addingPictures so you create a branch that wont effect the master. I have been pushing to master, but that is only to get a jump start on the project from now on we should make branches. Lets definitely make a develop branch soon just to be on the safe side.


Old version was crap but so is this random use of `Predicate`s. Don't have any alternative ideas though.


I noticed that  when I used the same commit message it counted as one commit. Are you seeing that all 15 files were changed?


This code is awful... can we split the behaviour for `RECTANGULAR_CORNER`/`WALL_CORNER` into different methods?


Garry: drive safe, earn cash, get where you're going!


Can you add a newline EOF as you're editing this file anyway


This is an unnecessary assignment


I am having difficulty understanding how to read and respond to the error messages. I wanted to modify my files but was not sure how to. I need help with decoding error messsages


@mat0thew ? I don't follow.


inCents mights make more sense as a val.  No need to recompute it every time.


The point of flushchanges was to provide a means of discarding the changes and allowing the documents to revert back to their original state...that was my intention. The code doesn't yet reflect this quite yet, however. If did indeed revert the documents, do you think it would be useful then? If not, i'll remove it.

Agree with your other comments.

-Jeff


Ah, good point.


Eu costumo privilegiar o gênero feminino, questionando o padrão estabelecido, como em "convocá-las(os)".


Que especificação de markdown usa espaços no fim da linha?


1.In "MyTimerTask", is it more suitable to write down

* timer.schedule(new ScheduleRunTask(), delaytime * 1000, delaytime * 1000);

instead of
* timer.schedule(new ScheduleRunTask(), 0, delaytime * 1000);?

2.In "MyTimerTask2", is it more suitable to put "private int num=0;" in class "ScheduleRunTask"?
Think about another constructor:

    public MyTimerTask2(int delaytime)
    {
        timer = new Timer();
        timer.schedule(new ScheduleRunTask(), delaytime * 1000, delaytime * 1000);
        timer.schedule(new ScheduleRunTask(), delaytime * 1000, delaytime * 1000);
    }
You will see that each timer runs twice, is it the case you want?


Good points.


Hmm.  How about "Euro.fromCents(inCents + otherEuro.inCents)"?


Untrack works for me as well :)


Similar to above.  No need to calculate euro and cents separately when you have a inCents method defined already


Error invoking Method 'removeAllCoords': Method not found [404].
I wish I could make it works.


`snazzy` is no longer a dependency; this should be `standard-reporter --stylish`


I like how legible this is.  But does it ensure that cents is always displayed as two digits?


Brant -

Thanks for the feedback :) I'll update the code early next week and push another commit.

-Jeff


Minor thing, but you can get rid of these curly braces since there's nothing in them.


Do you have to include jquery in the page?


This works, but note that the "return" isn't necessary.


is is possible to extend the custom skin amount by just adding
this.skin[letterID]shortcut = ' ';
         this.skin[letterID]= ' ';


Note that there's also a 'sum' method.


Will union keep duplicates?  Do we want to keep duplicates (I think so, but not sure)?


This should be translated as below.
```md
testDefinitionは`foo`と`bar`の両方ではなく、いずれかが期待値であるべきです。
```


event listener here


Great use of filter


LGTM, but could you help to split it to a separate commit? Not mix with the h264 B frame bug fix commit.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15760](https://teamcity.mesosphere.io/viewLog.html?buildId=135192&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 226 Build time: 00:03:52


This is pretty cool.  I used pattern matching and it wasn't as concise.


#5 #4 #3


Ahh.. In my solution I had an extra pattern match for (Nil, Nil) => Nil.  But simply returning ys in your first case covers this, I think.


Oops, it's just supposed to skip the spell check if enchant isn't available. Should be fixed in d0e3ef2.


If you're still unsure, it's basically asking you to extend sumOfTwo to work for any number of lists.


This is an outrage!


then I believe you're missing a toastLibrary directive in your build.gradle


Mark Strauss - an article on potential improvements to the ESV, several of which were useful and applicable for the OEB.

http://zondervan.typepad.com/files/improvingesv2.pdf
https://en.wikipedia.org/wiki/Mark_L._Strauss


could tell me the reason why change this way?


This is great. Nice work Rodrigo!


It is worth noting, that we are using Polar 1.1.1 as of this commit


Your CollectionExercise and RecursionPatternMatching are still in their original form.  Did you forget to commit some files?


What happened to good old democratic social coding on github :crying_cat_face:.


Latest imagicalmine build says "server outdated"? Is there a fix anyone
knows of? Thanks much!
On Feb 12, 2016 11:18 PM, "Driesboy" <notifications@github.com> wrote:

> fixed
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ImagicalMine/ImagicalMine/commit/c62466e564115e05deb13795321f3f96fec28169#commitcomment-16077047>
> .
>


'allowed to glean' is good


对UITableView使用及数据管理的综合使用。


Yeah there are some cool pattern matching problems later on.  Definitely give them a shot if you have the time later :)


TeamCity Open-source Libraries :: Sourcerer :: CI [Build 0.0.29.0](http://build01:8888/viewLog.html?buildId=14240&buildTypeId=OpenSourceLibraries_Sourcerer_CI) is now running


TeamCity Open-source Libraries :: ThirdDrawer :: CI [Build 1.1.36.0](http://build01:8888/viewLog.html?buildId=14242&buildTypeId=OpenSourceLibraries_ThirdDrawer_CI) is now running


TeamCity Open-source Libraries :: YACLP :: CI [Build 1.0.29.0](http://build01:8888/viewLog.html?buildId=14241&buildTypeId=OpenSourceLibraries_Yaclp_CI) is now running


Looks great! :smiley:

_Btw.: the D-ELFP is a C182 **N** - the shorter and older version....._

But I don't think it is a real issue - MSFS A2A Payware even mixed a Cessna T 182 T with an older Cessna 182 and the available liveries made by the users are from many many different variants....

Anyway - I like those older liveries more than those today all-white liveries

Happy to see some more liveries from you! :smiley:


This is bad. It will break the legacy map import and map editor.


Are Event and Process mandatory? Why not just make them automatic as part of instantiating the engine, with an optional network param if you want multiplayer


TeamCity Open-source Libraries :: ThirdDrawer :: CI [Build 1.1.36.0](http://build01:8888/viewLog.html?buildId=14242&buildTypeId=OpenSourceLibraries_ThirdDrawer_CI) outcome was **SUCCESS**
Summary: Tests passed: 8 Build time: 00:00:55


TeamCity Open-source Libraries :: YACLP :: CI [Build 1.0.29.0](http://build01:8888/viewLog.html?buildId=14241&buildTypeId=OpenSourceLibraries_Yaclp_CI) outcome was **SUCCESS**
Summary: Tests passed: 20 Build time: 00:00:55


TeamCity Open-source Libraries :: BlogMonster :: CI [Build 2.0.51.0](http://build01:8888/viewLog.html?buildId=14243&buildTypeId=BlogMonster_CI) is now running


а еще надо что-то решить с именованием переменных, все-таки, camelCase или python-style?


TeamCity Open-source Libraries :: MvcNavigationHelpers :: CI [Build 0.0.34.0](http://build01:8888/viewLog.html?buildId=14244&buildTypeId=OpenSourceLibraries_MvcNavigationHelpers_CI) is now running


TeamCity Open-source Libraries :: BlogMonster :: CI [Build 2.0.51.0](http://build01:8888/viewLog.html?buildId=14243&buildTypeId=BlogMonster_CI) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 12 Build time: 00:00:17
### Failed tests
```
BlogMonster.Tests.dll: BlogMonster.Tests.WhenImportingPostsFromAnInstagramFeed.ThereShouldBeAtLeastOnePost: <no details avaliable>

```


TeamCity Open-source Libraries :: ConfigInjector :: CI [Build 2.0.511.0](http://build01:8888/viewLog.html?buildId=14245&buildTypeId=ConfigInjector_CI) is now running


TeamCity Open-source Libraries :: MvcNavigationHelpers :: CI [Build 0.0.34.0](http://build01:8888/viewLog.html?buildId=14244&buildTypeId=OpenSourceLibraries_MvcNavigationHelpers_CI) outcome was **SUCCESS**
Summary: Tests passed: 21 Build time: 00:00:22


TeamCity Open-source Libraries :: NotDeadYet :: CI [Build 0.0.55.0](http://build01:8888/viewLog.html?buildId=14246&buildTypeId=OpenSourceLibraries_NotDeadYet_CI) is now running