**Line is longer than allowed. (81 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 90 column 81 to line 90 column 82*.


**Line is longer than allowed. (82 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 111 column 81 to line 111 column 83*.


lgtm


This doesn't make very much sense. The container will still be called spacedock. Your project-name line below will just namespace it so it doesn't conflict with other spacedocks.


thanks so much!


Why is h_c a pdf??


No need for further benchmarks, the problem is detected. A=5000 is too low, and I'll use A=20000.


thanks


It would make more sense to remove the host bind/port entirely and let Docker pick one. Then use docker inspect to get the port docker chose, which seems safer than writing your own script to pick a random port.


how about `get_default_max()` instead?


And how does that behave if multiple spacedocks are there?


oooh, good catch!


I generally prefer logging and raising the original exception to avoid losing information. If we want to provide a simplified message, however, this should probably raise a `SearchBackendError` instead. Perhaps something like this:

```python
except ValueError as exc:
    logging.error('Unable to decode response from Solr: %s', exc exc_info=True)
    raise SearchBackendError('Unable to decode response from Solr')
```


If superclass will raise exception for null values than I think we can guarantee that compiled code will not depend on the value being null therefore making it unsafe should be now possible.


I think you should be able to use `&[&[u8]]` instead of `Vec<&[u8]>` here


These should be logging calls rather than writing to stdout/stderr which will cause server failures in some WSGI environments and may not be logged


TIL: `samtools` does not validate tags.


and Windows


The container takes care of creating this file if its missing. No need to copy it yourself. See https://github.com/KSP-SpaceDock/SpaceDock/blob/dev/docker/start.sh#L3


Du mangler parameterne på denne funktion.
Og du har sat et semikolon, ikke et almindeligt kolon.


fixes #ENTESB-5041


Hint til den oppe over: Hvor kommer `person` og `possible_match` fra?


            嗯。我有时间修改下。谢谢提出建议。发自网易邮箱大师
            在2016年02月26日 17:54，chenqingxiao 写道:我觉得不用导航控制器应该也可以用这个,再考虑下没有导航控制器的时候

—Reply to this email directly or view it on GitHub.


FYI Travis doesn't support PG 9.5 :(


Was the arm target breaking @oxtoacart?


On Fri, Feb 26, 2016 at 12:38 PM, cyoung <notifications@github.com> wrote:

> @jpoirier <https://github.com/jpoirier> - know of any nice log package to
> separate different log levels?
>
> I like this one: https://github.com/op/go-logging
>
@cyoung

the only third party log package I've used is Rob's
https://github.com/golang/glog which worked well for my use case


L.G.T.M.


It was originally a .png, but I believe Spencer swapped it fairly early on
and we've been working with that.

Dan

On Fri, Feb 26, 2016 at 1:45 PM Jacques Carette <notifications@github.com>
wrote:

> Why is h_c a pdf??
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/JacquesCarette/literate-scientific-software/commit/e82cafb64eec4209ba1a4fdff2a4ccd05ec665be#commitcomment-16359761>
> .
>


This name is internal to the 'docker-compose environment'. It's derived from the link directive in the docker-compose yml file used. See https://docs.docker.com/compose/compose-file/#links


I'll get that done in a sec ;)


@m-kuhn really nice, thank you!


Oooh, that is neat then


I think Jacques comment is motivated by the fact that we could put the tex directly in the paper.  We don't need an intermediate step.  Is there any reason Dan why you couldn't put the tex directly into the paper?


Exactly.

On 2016-02-26 13:50 , Spencer Smith wrote:
>
> I think Jacques comment is motivated by the fact that we could put the
> tex directly in the paper. We don't need an intermediate step. Is
> there any reason Dan why you couldn't put the tex directly into the paper?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/JacquesCarette/literate-scientific-software/commit/e82cafb64eec4209ba1a4fdff2a4ccd05ec665be#commitcomment-16359910>.
>


This need to go into the AP_parachute folder


Import


This needs to go into the AP_parachute folder


I feel compelled to protest extremely strongly against YAML. The fact that Ruby has a C-ext (more than one) to parse YAML has caused extreme pain and suffering for people who want to use something like Rubinius, where no viable pure Ruby alternative for parsing YAML exists.

The dependency file should be possible to parse, and hence to use, with the least amount of ceremony and the fewest possible dependencies. For example, it should be possible to write a reasonable parser for it in Bash or simply POSIX shell.

Either this will be a powerful tool to compose systems, or it will become something like Gemfile or even RubyGems that requires everything from YAML to SSL/TLS to use. That would be a terrible outcome.

This sort of component (the dependency file) in a system needs to be layered. It must be possible to consume (parse) this format at multiple layers in the system. From very simple ones (eg Bash) up to complex SatSolvers (eg the one Bundler uses to resolve dependencies). Those layers should be separable, so that getting a list of dependencies doesn't require all the mechanisms to generate the list, etc.

It may seem like it will save time to "simply use an existing text format". I implore you to not make that assumption. Whatever time it saves now, visibly, will be offset by many times that by the cost of needing to have a complex system in place before you can use the dependencies file to assemble that system.

The dependency file should be extremely simple and purpose built. It should also have a representation (eg the Gemfile.lock) that is also extremely simple, purpose built, and decoupled from the generation mechanism, so that it can be consumed by different parts of the system without needing everything to generate it. The fact that Bundler almost gets this right is great. Unfortunately, Gemfile.lock is not necessarily easily parsed and the tools (command line options) for working with the two representations are somewhat _ad hoc_. We can learn a ton from that effort to make this very useful and effective.

So, in summary, please please please not YAML.


Test


Substrate.h


I agree, but it's a management command. Since the time I wrote this, though, it's recomended to use
`self.stdout.write("Unterminated line", ending='')` (source https://docs.djangoproject.com/en/1.8/howto/custom-management-commands/)


`connection_router` doesn't appear to be used, so we can remove this:

https://landscape.io/diff/288002?page=2#errors


Pretty sure originally it messed up the formatting or was unreadable, but
I'll double check now.

On Fri, Feb 26, 2016 at 1:51 PM Jacques Carette <notifications@github.com>
wrote:

> Exactly.
>
> On 2016-02-26 13:50 , Spencer Smith wrote:
> >
> > I think Jacques comment is motivated by the fact that we could put the
> > tex directly in the paper. We don't need an intermediate step. Is
> > there any reason Dan why you couldn't put the tex directly into the
> paper?
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/JacquesCarette/literate-scientific-software/commit/e82cafb64eec4209ba1a4fdff2a4ccd05ec665be#commitcomment-16359910
> >.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/JacquesCarette/literate-scientific-software/commit/e82cafb64eec4209ba1a4fdff2a4ccd05ec665be#commitcomment-16359920>
> .
>


Getting an error with this latest version that didn't happen in 0.8.5.

Cannot read property 'cssClass' of undefined
    at FlotTooltip.getDomElement (jquery.flot.tooltip.js:329)
    at Plot.FlotTooltip.init.plot.removeTooltip (jquery.flot.tooltip.js:320)
    at jquery.flot.tooltip.js:116
    at executeHooks (jquery.flot.js:717)
    at Plot.shutdown (jquery.flot.js:1363)
    at setupCanvases (jquery.flot.js:1327)
    at new Plot (jquery.flot.js:707)


Install


The dangers of copy-pasting code, people.


this belongs in AP_Parachute


This import isn't used


We still need `padding-top: 50px` because otherwise when you click a TOC link, the section title you just clicked on is hidden behind the top nav bar. We then want to recover as much of that blank space as we can by setting `margin-top` negative, but I figured out that `margin-top: -14px` is as far as we can go before the bounding box starts to overlap and we get those phantom click issues I mentioned in the comment that used to be above this CSS block.


Lisa's commit message on point 👌🏻👌🏻👌🏻


Both dest and src must be local to this thread: dest is being initialized, and src is being destroyed.  You ought to be able to do this without bumping any reference counts.


`data` and `headers` should probably default to `None` and have `if data is None: data = {}` checks since Python's default arguments are shared for the life of the program, not just a single function call


4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2153 of 2159 tests passed, 3 test warnings)

 * 4 tests had: EIO diffs.
 * 6 tests had: ESO big diffs.
 * 1 test had: MTR small diffs.
 * 5 tests had: Table big diffs.
 * 2 tests had: ERR diffs.
 * 3 tests had: ESO small diffs.
 * 4 tests had: MTR big diffs.
 * 2 tests had: Table small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


the commit message consists of `tag: Stuff`, where the tag-colon is the colon after `tag`: `tag-->:<--`


you can't declare var here in ES6 classes.

Need to move them outside the SNSPushAdapter.

and use const is better


I also thought about it, and I really this it's nice. I'm just philosophizing about how to make it in a fashion way.

Yes, I know, it's so easy and fast to do. But I have no hurry at all :)


Ahhh, ja, selvfølgelig, er gået hen og blevet syg, så tog lige en lur, ser
lige om jeg kan fikse det nu
Den 26/02/2016 19.48 skrev "Zlepper" <notifications@github.com>:

> Hint til den oppe over: Hvor kommer person og possible_match fra?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zlepper/sccPython/commit/5726aed63312b220af2cf9f11b72febfe37c66eb#commitcomment-16359848>
> .
>


Hi @nickidlugash, it looks like this commit removed circle-15.svg and circle-11.svg from streets-v8. It looks like the circle icon is still on other map styles' sprite sheets, so maybe it was a mistake? Just wanted to check, as I liked the minimal style of that blank white circle. Thanks


The only "races" that we actually need to support here are read-read races.  If you're initializing, destroying, or assigning to a reference, you can assume that the thread has exclusive access to it.

Also, you will need to ensure that the unknownWeak operations interoperate with your new scheme.


**Shortlog of HEAD commit is too long.**
*GitCommitBear, severity 1, section `commit`.* *Project wide.*


**This file contains unused source code.**
*PyUnusedCodeBear, severity 1, section `python`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 7.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -4,7 +4,8 @@
 import tempfile

 from coalib.bears.Bear import Bear
-from coalib.misc.Shell import escape_path_argument, run_shell_command
+from coalib.misc.Shell import escape_path_argument
+from coalib.misc.Shell import run_shell_command
 from coalib.results.Diff import Diff
 from coalib.results.Result import Result
 from coalib.results.RESULT_SEVERITY import RESULT_SEVERITY
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 40.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -38,6 +38,8 @@
     # TODO Look for existing classes inside python...

 # TODO Dynamic kwargs usage. Context depending signature.
+
+
 def Linter(executable, **kwargs):
            #shell=False, #TODO ??????
            #output_regex=r'(?P<line>\d+)\.(?P<column>\d+)\|'
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, lines 42 to 43.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -39,8 +39,8 @@

 # TODO Dynamic kwargs usage. Context depending signature.
 def Linter(executable, **kwargs):
-           #shell=False, #TODO ??????
-           #output_regex=r'(?P<line>\d+)\.(?P<column>\d+)\|'
+           # shell=False, #TODO ??????
+           # output_regex=r'(?P<line>\d+)\.(?P<column>\d+)\|'
            #             r'(?P<severity>\d+): (?P<message>.*)',
            #use_stderr=False,
            #use_stdin=False,
```


si


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, lines 45 to 51.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -42,13 +42,14 @@
            #shell=False, #TODO ??????
            #output_regex=r'(?P<line>\d+)\.(?P<column>\d+)\|'
            #             r'(?P<severity>\d+): (?P<message>.*)',
-           #use_stderr=False,
-           #use_stdin=False,
-           #provides_correction=False,
-           #diff_severity=RESULT_SEVERITY.NORMAL,
-           #diff_message='',
-           #severity_map=None):
+           # use_stderr=False,
+           # use_stdin=False,
+           # provides_correction=False,
+           # diff_severity=RESULT_SEVERITY.NORMAL,
+           # diff_message='',
+           # severity_map=None):
     kwargs["executable"] = executable
+
     def create_linter(cls):
         class Linter(LocalBear):
             handler = cls
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, lines 102 to 103.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -99,8 +99,10 @@
                     stdin=stdin_input,
                     shell=self.shell)

-                self.stdout_output = tuple(stdout_output.splitlines(keepends=True))
-                self.stderr_output = tuple(stderr_output.splitlines(keepends=True))
+                self.stdout_output = tuple(
+                    stdout_output.splitlines(keepends=True))
+                self.stderr_output = tuple(
+                    stderr_output.splitlines(keepends=True))
                 results_output = (self.stderr_output if self.use_stderr
                                   else self.stdout_output)
                 results = self.process_output(results_output, filename, file)
```


**Line is longer than allowed. (84 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 91 column 81 to line 91 column 85*.


**Line is longer than allowed. (83 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 102 column 81 to line 102 column 84*.


**Line is longer than allowed. (83 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 103 column 81 to line 103 column 84*.


**This file contains unused source code.**
*PyUnusedCodeBear, severity 1, section `python`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 7.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -4,7 +4,8 @@
 import tempfile

 from coalib.bears.LocalBear import LocalBear
-from coalib.misc.Shell import escape_path_argument, run_shell_command
+from coalib.misc.Shell import escape_path_argument
+from coalib.misc.Shell import run_shell_command
 from coalib.results.Diff import Diff
 from coalib.results.Result import Result
 from coalib.results.RESULT_SEVERITY import RESULT_SEVERITY
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 37.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -34,7 +34,8 @@

 class LinterHandler:
-    def create_arguments(self, filename, file, config_file): # TODO Also file???
+
+    def create_arguments(self, filename, file, config_file):  # TODO Also file???
         raise NotImplementedError

     def generate_config(self):
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 49.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -46,7 +46,8 @@
 # TODO ------> Or "hybrid" approach, needed arguments are optional, if one activates
 # TODO ------> further options these get passed by kwargs
 def Linter(executable, **kwargs):
-    kwargs["executable"] = executable # TODO Sucks...
+    kwargs["executable"] = executable  # TODO Sucks...
+
     def create_linter(cls):
         class Linter(LocalBear):

```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 58.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -55,7 +55,9 @@

             @property
             def handler(self):
-                return cls # TODO Directly import functions? Rethink design maybe then...
+                # TODO Directly import functions? Rethink design maybe then...
+                return cls
+
             @property
             def executable(self):
                 return kwargs["executable"] # TODO This needs to be solved more elegant...
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 61.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -58,7 +58,8 @@
                 return cls # TODO Directly import functions? Rethink design maybe then...
             @property
             def executable(self):
-                return kwargs["executable"] # TODO This needs to be solved more elegant...
+                # TODO This needs to be solved more elegant...
+                return kwargs["executable"]

             def _execute_command(self, args, stdin=None):
                 # TODO Also more elegance...
```


**Line is longer than allowed. (84 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 46 column 81 to line 46 column 85*.


**Line is longer than allowed. (89 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 58 column 81 to line 58 column 90*.


**Line is longer than allowed. (90 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 61 column 81 to line 61 column 91*.


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 90.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -87,7 +87,8 @@
                     origin=groups.get("origin", self),
                     message=groups.get("message", ""),
                     file=filename,
-                    severity=int(groups.get("severity", RESULT_SEVERITY.NORMAL)),
+                    severity=int(groups.get(
+                        "severity", RESULT_SEVERITY.NORMAL)),
                     line=groups.get("line", None),
                     column=groups.get("column", None),
                     end_line=groups.get("end_line", None),
```


**Line is longer than allowed. (83 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 73 column 81 to line 73 column 84*.


**Line is longer than allowed. (85 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 83 column 81 to line 83 column 86*.


**Line is longer than allowed. (81 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 90 column 81 to line 90 column 82*.


**Line is longer than allowed. (82 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 111 column 81 to line 111 column 83*.


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 38.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -36,6 +36,7 @@
 class LinterHandler:
     # TODO Damn fuck what about required section settings....
     # TODO Doing the handler stuff below static? see line above^^
+
     def create_arguments(self, filename, file, config_file):
         raise NotImplementedError

```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 51.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -48,7 +48,8 @@
 # TODO ------> Or "hybrid" approach, needed arguments are optional, if one activates
 # TODO ------> further options these get passed by kwargs
 def Linter(executable, **kwargs):
-    kwargs["executable"] = executable # TODO Sucks...
+    kwargs["executable"] = executable  # TODO Sucks...
+
     def create_linter(cls):
         class Linter(LocalBear):

```


We should probably change the output to use the new Django convention of writing to `self.stderr` and `self.stdout` in management commands. That could make the `--stdout` option easier to implement since we should just pass one of the two or a file object to a single output function which would write the schema.

https://docs.djangoproject.com/en/1.9/howto/custom-management-commands/#management-commands-output


Of cource I'd love to accept some pull requests :tongue:


This is another case, like my ~> complaint, where this leaks Ruby-isms elsewhere. I was getting around to opening this issue as well.

> On Feb 26, 2016, at 12:52 PM, Brian Shirai <notifications@github.com> wrote:
>
> I feel compelled to protest extremely strongly against YAML. The fact that Ruby has a C-ext (more than one) to parse YAML has caused extreme pain and suffering for people who want to use something like Rubinius, where no viable pure Ruby alternative for parsing YAML exists.
>
> The dependency file should be possible to parse, and hence to use, with the least amount of ceremony and the fewest possible dependencies. For example, it should be possible to write a reasonable parser for it in Bash or simply POSIX shell.
>
> Either this will be a powerful tool to compose systems, or it will become something like Gemfile or even RubyGems that requires everything from YAML to SSL/TLS to use. That would be a terrible outcome.
>
> This sort of component (the dependency file) in a system needs to be layered. It must be possible to consume (parse) this format at multiple layers in the system. From very simple ones (eg Bash) up to complex SatSolvers (eg the one Bundler uses to resolve dependencies). Those layers should be separable, so that getting a list of dependencies doesn't require all the mechanisms to generate the list, etc.
>
> It may seem like it will save time to "simply use an existing text format". I implore you to not make that assumption. Whatever time it saves now, visibly, will be offset by many times that by the cost of needing to have a complex system in place before you can use the dependencies file to assemble that system.
>
> The dependency file should be extremely simple and purpose built. It should also have a representation (eg the Gemfile.lock) that is also extremely simple, purpose built, and decoupled from the generation mechanism, so that it can be consumed by different parts of the system without needing everything to generate it. The fact that Bundler almost gets this right is great. Unfortunately, Gemfile.lock is not necessarily easily parsed and the tools (command line options) for working with the two representations are somewhat ad hoc. We can learn a ton from that effort to make this very useful and effective.
>
> So, in summary, please please please not YAML.
>
> —
> Reply to this email directly or view it on GitHub.
>


… or `self.stderr`/`self.stdout` since this is a management command.


Snake? Dafuc


Please use proper capitalization and punctuation in comments.


parse command should throw a operation not supported exception if it is not a leaf node. The function will only ever get called if it is a leaf


This sounds straightforwardly like a unnecessary dependency. `Krikri::Activity` shouldn't need to instantiate a `SoftwareAgent` instance to do this work.

Can you provide the backtrace?


edit text


I propose the following instead:

```diff
diff --git a/core/library/DB.php b/core/library/DB.php
index 26ba103..06a37f6 100755
--- a/core/library/DB.php
+++ b/core/library/DB.php
@@ -236,7 +236,18 @@ class sDB extends SingletonFramework {
 	 * @return string An SQL datetime formatted string
 	 **/
 	public static function mkdatetime ( $timestamp ) {
-		return date('Y-m-d H:i:s', $timestamp);
+		$datetime = '0000-00-00 00:00:00';
+
+		if ( is_string($timestamp) && preg_match('/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $timestamp) )
+			return $timestamp; // Ignore already properly formatted strings
+
+		if ( empty($timestamp) ) // Empty check to prevent '0' from becoming epoch datetime
+			return $datetime;
+
+		if ( is_int($timestamp) ) // Seems legit to convert... do it!
+			return date('Y-m-d H:i:s', $timestamp);
+
+		return $datetime;
 	}

 	/**
@@ -561,10 +572,8 @@ class sDB extends SingletonFramework {
 					if ( is_null($value) ) {
 						$value = current_time('mysql');
 					// If the date is an integer, convert it to an
-					// sql YYYY-MM-DD HH:MM:SS format
-					} elseif ( ! empty($value) && ( is_int($value) || intval($value) > 86400) ) {
-						$value = sDB::mkdatetime( intval($value) );
-					}
+					// SQL YYYY-MM-DD HH:MM:SS format
+					$value = sDB::mkdatetime( intval($value) );

 					$data[$property] = "'$value'";
 					break;
```


I just pushed a new version, I got the h_c TeX to fit (I believe that was
the original problem).

On Fri, Feb 26, 2016 at 1:51 PM Dan Szymczak <dan.szymczak@gmail.com> wrote:

> Pretty sure originally it messed up the formatting or was unreadable, but
> I'll double check now.
>
> On Fri, Feb 26, 2016 at 1:51 PM Jacques Carette <notifications@github.com>
> wrote:
>
>> Exactly.
>>
>> On 2016-02-26 13:50 , Spencer Smith wrote:
>> >
>> > I think Jacques comment is motivated by the fact that we could put the
>> > tex directly in the paper. We don't need an intermediate step. Is
>> > there any reason Dan why you couldn't put the tex directly into the
>> paper?
>> >
>> > —
>> > Reply to this email directly or view it on GitHub
>> > <
>> https://github.com/JacquesCarette/literate-scientific-software/commit/e82cafb64eec4209ba1a4fdff2a4ccd05ec665be#commitcomment-16359910
>> >.
>> >
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/JacquesCarette/literate-scientific-software/commit/e82cafb64eec4209ba1a4fdff2a4ccd05ec665be#commitcomment-16359920>
>> .
>>
>


Note on the above that I chose to use a `preg_match` on purpose. I ran tests to verify that it is much faster than doing a strait up `date()` conversion check:

```php
$start = microtime(true);
for ($i = 0; $i < 5000; $i++) {
	$dt = '0000-00-00 00:00:00-';
	$dt == @date('Y-m-d H:i:s',strtotime($dt));
}
var_dump(microtime(true) - $start);

$start = microtime(true);
for ($i = 0; $i < 5000; $i++) {
	$dt = '0000-00-00 00:00:00-';
	 preg_match('/\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}/', $dt);
}
var_dump(microtime(true) - $start);
```

The preg ends up being an order of magnitude faster:

```
float(0.056871175765991)
float(0.0021789073944092)
```


4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1571 of 1571 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.81%25-green.svg)


@obiot Good point, updated!


fixes #5


Не надо создавать промежуточную переменную под результат.


drop /app/ from path here and anywhere else in this file.


guys, i think this is a massive breaking change... those mixins and variables are available externally.
They're definately being used in the react-toolkit and possibly elsewhere


@ekryski you are rocket-man! I have updated my project. Now `authentication` service is worked correctly.


Is this long enough? Should probably programatically create a date after the test is ran.


lets instead of checking if it has a next token, assert that the next token is the token required by the syntax.
ie -> Assert.isTrue(tokens.next().equals("FOO"), "Token doesn't match FOO" );


Do we used the Z for something?


This is funnier! http://php.net/manual/en/control-structures.goto.php
I have to think something to improve the code.
There are two entrypoint  if channel are not setted start from -1, instead if the channels are already setted it start from 0.


hola


Are you talking about negative number?


lets instead of checking if it has a next token, assert that the next token is the token required by the syntax.
ie -> `Assert.isTrue(tokens.next().equals("FOO"), "Token doesn't match FOO" );`


Thanks C++ :D

On Fri, Feb 26, 2016 at 8:58 AM, Stephane Sezer <notifications@github.com>
wrote:

> Yeah but this function returns an std::string which mean when I return
> addressStr it automatically constructs an std::string and copies the
> data. So this is safe.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/facebook/ds2/commit/9f3f60b0889fc0c6c0a4fd66b81051d601db9897#commitcomment-16357403>
> .
>

--
Kemerit plijadur! - Corentin DERBOIS


Rogue import?


This seems like a class that can be used for more than one type of button. Maybe it would be best to make the name more general?


No, I'm talking about always setting an integer instead of a string:
`$session['state'] = 0;`


Lets use PrimitiveParser for the parsing of all primitives. It is already implemented, and allows us to centralize the the parsing logic.


I like it.  #129


yeah it should


The end user doesn't have to configure the route manually I think.. We should be able to do this for them in the bundle.


This pass clang-format :D I will realigne


Would it make more sense to use https://docs.docker.com/compose/extends/ to simplify this configuration a bit?

We could have docker-compose.yml for local development, docker-compose-deploy.yml for staging/production deployments, and docker-compose-pr.yml for building docker-compose-deploy.yml off a specific commit. It would cut down on the duplication between docker-compose.yml and docker-compose-deploy.yml as well as get rid of the need to sed in this script.

If yay, I'll play around with it tonight...


This file, didn't change at all from the fork


Good start, but we also need to show stats per language; not just per translation key.


I couldn't remember why that padding/margin offset was in there to begin
with ... and there was a comment there explaining it, too. I added it back
in as you suggested, changing the margin to -16px, which looks good on my
staging server:
http://adiamondstein.cam.corp.google.com:4000/overview/concepts.html

Thanks,
Andy

On Fri, Feb 26, 2016 at 1:53 PM, Anthony Yeh <notifications@github.com>
wrote:

> We still need padding-top: 50px because otherwise when you click a TOC
> link, the section title you just clicked on is hidden behind the top nav
> bar. We then want to recover as much of that blank space as we can by
> setting margin-top negative, but I figured out that margin-top: -14px is
> as far as we can go before the bounding box starts to overlap and we get
> those phantom click issues I mentioned in the comment that used to be above
> this CSS block.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AndyDiamondstein/vitess/commit/97f57007002bcb19f46e12ca9f4d247479f1ed2d#commitcomment-16359978>
> .
>

--
Andy Diamondstein
Staff Technical Writer
YouTube


this looks like it is missing a condition


Yeah, that comic is on the stackoverflow page too :smile:

Instead of squashing everything into one huuuuge method, split it up and make it easier to read / understand / test.
That way, it's also a lot easier to choose different paths depending on the state.
Also, before the channels are set, there doesn't have to be a conversation. So before the channels are set and a conversation is started, the command can just stay out of the states :+1:

You know what I mean?


updated for arm


Next steps for this file:

- [ ] Expand input to crunch on all facilities' files
- [ ] Filter "small" flows out of per-Facility output
- [ ] Sum all "small" flows across facilities into a single pseudo-facility "Other"


I hope so. We don't touch anything ebean now.


Return.


The biggest issue with open-ended recursive retries on connection failure is this (and especially problematic with sharding):

If the DB simply goes away, any code that hits this will fail dramatically by blowing its stack, instead of gracefully.

Better approach is:

```
if (!isConnected()) {
  connect();
}
try { sql } catch (exception) { // print and don't try again}
```


@jcberquist No worries.

Sublime Text's custom regex engine is a non-backtracking engine. Instead, it matches patterns in parallel and gives up on a pattern once a match is impossible. This allows it to be very fast, at the cost of some memory, but it can not support certain constructs that require backtracking. There are also a few other small features that have just not been implemented yet. The biggest features that are not supported are lookbehinds and backreferences.

When a regular expression is found that is not supported, Sublime Text falls back to the oniguruma engine. Depending on the regular expression, it can be quite a bit slower, especially once you get into OR conditions and variable length patterns followed by other items.

If you are interested in learning about the performance of non-backtracking engines, check out http://lh3lh3.users.sourceforge.net/reb.shtml and https://swtch.com/~rsc/regexp/.


StyleCI should catch that.


See #5. =)


@liiight yea, I noticed it in the movie queue api, but right now the data calls I made limit the list to 10 movies. With client side pagination I meant different calls to the server to load different pages, could have been better worded ;)


Yea anyway in the next version of this review, this function version is not here anymore :) I've clean it from the history, and also clean the new version (no more ThreadBase usage)


Abusing the string concatenation for...? :P


@thezoggy last commit was still a work in progress, here is my second attempt to make it look better! They were the only buttons left that didn't match the rest so something needed to be done :)


Nah, the sed is fine, and if you do more docker, I will get crazy :P


Hi there @ericchiang, at now we are working on it. Our provisional solution is redirect user to main page (in example app is http://127.0.0.1:5555) where user can log in using the OIDC flow. Maybe we could investigate how other IDPs handle this problem.


Never mind, I was on the commit page.


bien


This would break if `email.categories` is a `string`. You could test with `Array.isArray(email.categories)` for being sure that forEach would work (even if the array is empty). If categories is a `string` it could be passed directly to `sendgridEmail.addCategory`.


this doesn't work. I get corrupt docx and cannot open.


ThermCalcRelHumUseSameHumidRatioDryBulb (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I see. You're right, this is a small file. I thought it was another version of this https://github.com/dmacmillan/mykleat/blob/master/KLEAT.py, which could better have been factored into several small files. FYI, There is a tool called pylint that can help provide general guide for writing Python code. https://www.pylint.org/.


aah! ok good catch!


4959-plant-HX-CoolDifferential-stuck-Off (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (2120 of 2127 tests passed, 3 test warnings)

 * 4 tests had: EIO diffs.
 * 3 tests had: ESO small diffs.
 * 1 test had: MTR small diffs.
 * 2 tests had: ERR diffs.
 * 6 tests had: ESO big diffs.
 * 4 tests had: Table big diffs.
 * 4 tests had: MTR big diffs.
 * 2 tests had: Table small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.67%25-yellow.svg)


This plugin is for movie queue? Dunno if it's worth the effort, we're gonna deprecate it when movie list is ready


No problem. But could you give me some other important lmr parameters, because I do not like to run less than 200K games.


Looks like you misspelled "canola".


Bugfix for the not consistent_snapshot case, right?


Hi,
da bekomme ich eine Ausgabe, das Probleme ist erst, wenn ich mit BeautifulSoup versuche zu parsen.

Die Ausgabe habe ich hier angehangen. Könnte es evtl. daran liegen, dass es beim Webseiten-Code keinen Zeilenumbruch gibt??
[wworld.txt](https://github.com/Arno-Nymous/pyload/files/148767/wworld.txt)


And to think, I didn't want to do Docker in the first place. : )

k


That's correct.


You didn't test this against a Bikeshedded spec. >_< Bikeshed puts .toc on *every* list inside of the TOC.


I think I would prefer `.Ok(JSONObject())` for clarity. Not sure though.


Prepared statements are usually connection-scope (unless "client-side" managed, depends on driver options and capabilities) so a safer approach is to recreate them when the connection is recreated.

References: MySQL 3.1.0/J connector and above uses PreparedStatements server-side if supported : https://dev.mysql.com/doc/connector-j/en/connector-j-reference-implementation-notes.html

and MariaDB 10.1 does support them : https://mariadb.com/kb/en/mariadb/prepare-statement/


I tried to improve the comment a bit. Not exactly sure how else to improve it. Please let me know if it still bothers you and/or if you have any suggestions for improvements.


lets instead of checking if it has a next token, assert that the next token is the token required by the syntax.
ie -> `Assert.isTrue(tokens.next().equals("FOO"), "Token doesn't match FOO" );`


Here the results should be grouped, e.g. `mips`, `arm`, `x86_64` are all architectures, but `darwin`, `linux` etc. are operating systems.


test


nice


Did this.


Test Image is including


Comment test.


"added plan to get antique weapon from collector"


Primitive parsing logic is inside of `w15cs350.controller.cli.parser.PrimitiveDeseralizer`


should -> throw unsupported operation exception


I don't think we can safely flatten the tuple set in the way you're doing above.  In the case of a disjoint tuple, for example,

{ ([Product].[Product Family].[Drink], Time.[1997].[Q1]), ([Product].[Product Family].[Food], Time.[1997].[Q2]) }

we'd want to make sure the tuple constraint included an in list list:

in ((1997, 'Q1', 'Drink'), (1997, 'Q2', 'Food'))

I believe we handle that correctly if the raw tuple set is in the slicer, but we should also handle it if the set is inside an aggregate member on the slicer.  I think SqlConstraintUtils.addContextConstraintTuples() is probably a good place to look to start to figure out how we're going to do this.


This was just copied over from BetterShards, idk. The import is being used


Look at my implementation I'm a week hold in FP and Scala

def getHead[A](l: List[A]) : A = l match {
        case Nil => sys.error("List is empty")
        case Cons(x,_) => x
    }

    def dropWhile[A](l: List[A], f: A => Boolean): List[A] = {
        if ( f( getHead(l)) ) l
        else l match {
            case Nil => Nil
            case Cons(_,t) => dropWhile(t, f)
        }
    }


There are other classes where we have functional tests of native set expressions in lots of varieties-- your tests can be added to one of them without needing to create a new one.


kljlkjkl


Also apparently isConnected() already does my suggestion. So if isConnected() returns false, fail.


Why the closure instead of just `errorToast = toast`?


ThermCalcRelHumUseSameHumidRatioDryBulb (JasonGlazer) - x86_64-MacOS-10.9-clang: OK (1958 of 2121 tests passed, 185 test warnings)

 * 163 tests had: Table big diffs.
 * 185 tests had: Table small diffs.
 * 2 tests had: ESO big diffs.
 * 1 test had: EIO diffs.
 * 1 test had: ESO small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-92.31%25-yellow.svg)


Which skills exist and their names are completly config dependant and I thought it's best to have separated tables for each skill, so I set it up like this.


We are generally bad with catastrophic failures. If a DB reconnection continues to fail after X retries we should probably schedule a clean server shutdown instead of just making a log entry and letting everything go downhill.

In this case, we'd display the error and then get a stack dump as the subsequent query fails. Then this would continue to happen until an admin noticed, potentially for hours while players abused the situation. (I don't know how abuseable it would be in skill-up, but within other plugins this would be bad.)


Valeu @AlissonSteffens :)


Yea, but I think (haven't looked at movie list yet, I will this weekend) this plugin can easily be updated to use the movie list, I will look at it as soon as possible.


This will produce invalid results if custom `table` does not start with `0`.


Great summary Lindsay - I would just add what SAAS stands for.


This should also include testutil.c. PR #752 adds it.


wait this is a bug right?


This version of mkLTSA allows for duty cycled data.  Blank LTSA images are inserted for sections that lack data because of the duty cycle


So I should just call that method again when reconnecting to the db or should I recreate them every time I call one of the load/save methods?


Oh bummer. It's just hate using lower case r :/


Sounds like a plan!


You introduced guava, but didn't add it to ivy.xml.

@lucboudreau, the idea of bringing guava into Mondrian comes up about once every 3 months.  It's used in a great many other pentaho projects.  I'm still in favor, but want to make sure we're okay adding it as a dependency.


SSLverifyFull missing here ?


Initial commit.


No, the target builds fine.  But @xiam pointed out that it's still somewhat experimental, which is why we didn't used to run it as part of packaging.  This change just reverts things to where they stood originally.


this should rather be

```python
_dict['diffs'] = {relpath(file): diff
                  for file, diff in _dict['diffs'].items()}
```


It's only being used to raise an exception. There's likely a better exception to raise, possibly java.sql.SQLException.


make a test for it please to make sure all files are preserved


nono, look at the two lines below this. You have pure strings concatenated that don't need to be split. Just ribbing on you.


Yeah makes sense. I didn't spend much time looking at this, it's identical with BetterShards db class.


Just on reconnect.


Also, yes, this is an issue across all plugins.


Fixed. Luckily it only has the functional effect of doubling the null terminator after the first character is added.


Thanks for the idea. Changed in 5eb6bdced4765cdeb70411c6aa93ecb4163a9ffe.


Oh yeah I see, that probably just got messed up by autoformatting, I'll fix it.


Betrayal


Oh, you meant that the following should work?

```c++
struct empty { };

empty e; // not constexpr
constexpr empty copy = e;
```

I'm not sure I knew this should work, but it definitely is a grey area. I wouldn't expect it to work on many compilers, at the very least.


We/I didn't know subtree, thank you for the tip @HybridDog


Fantastic information Ryan - I learned a lot reading this.  Would love if you you could include a link that would show me the W3C's XML 1.0 Specification and JavaScript Programming Language, Standard ECMA-262 3rd Edition at the points where they are mentioned.


Interestingly, looks like this commit caused RocksDB to start failing jsCore_small_oplog and jsCore_small_oplog_rs with OOM issues:

![screen shot 2016-02-26 at 11 27 04 am](https://cloud.githubusercontent.com/assets/1091023/13362955/ff5c8ade-dc7b-11e5-89e8-f886310aa46a.png)


I think the more architectural way of approaching this would be to change checkDoCatch in ErrorHandlingWalker to allow check{Non,}ExhaustiveDoBody to return something that then gets passed to the checkCatch call, i.e.:

  ShouldRecurse_t checkDoCatch(DoCatchStmt *S) {
    auto bodyResult = (S->isSyntacticallyExhaustive()
                         ? asImpl().checkExhaustiveDoBody(S)
                         : asImpl().checkNonExhaustiveDoBody(S));
    for (auto clause : S->getCatches()) {
      asImpl().checkCatch(clause, bodyResult);
    }
    return ShouldNotRecurse;
  }

CheckErrorCoverage will then just return the throwing kind of the body.  In checkCatch, if the body's throwing kind was RethrowingOnly and the current context kind is RethrowingFunction, push a Handled context.


You mentioned the files on the server had permissions 600, was this the same to keep things consistent? Or did the server perms change as well to 644?


With `additional context` I meant that you can get an idea of the reception and popularity of the resource. I'll add it and save the space somewhere else.

Don't worry too much about the character limit for now; please clarify wherever you think that something is hard to understand.


Perfect.


Thank's


@sils1297 Yeah. It throws exception when diff is null.  I've already added a test for null diff [here](https://github.com/tushar-rishav/coala/commit/46d8ea2c7304510c1de350f430745ea40441193a#diff-c29a34019b18eee0e18454ac2dedf20cR133)


This introduces resource leak


Mostly didn't want to keep using errorToast? or errorToast! throughout the method.


This should be $stats['all']

\wp-admin\includes\class-wp-list-table.php is looking for 'all' not 'total_comments'. This makes the if statement `if ( !isset( $num_comments->$status ) )` line 253 of class-wp-list-table.php true and therefore `$num_comments->$status = 10;`

What this means is that when viewing the dashboard's activity widget, the number of All comments will always be 10.


Window class names must not be changed


Done.

The only problem after this change is that the error details will have deployment's name and gvk when the user asked for scale's update.


Lots of this code is old enough that this was correct when written, but I now require Java 8 anyway so sure why not


ThermCalcRelHumUseSameHumidRatioDryBulb (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1994 of 2159 tests passed, 185 test warnings)

 * 165 tests had: Table big diffs.
 * 185 tests had: Table small diffs.
 * 2 tests had: ESO big diffs.
 * 1 test had: EIO diffs.
 * 1 test had: ESO small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-92.36%25-yellow.svg)


ignore this version bump.


**Shortlog of HEAD commit is too long.**
*GitCommitBear, severity 1, section `commit`.* *Project wide.*


Here's the test output: https://logkeeper.mongodb.org/build/56cf5f1abe07c44a012dc316/test/56cf5fbbbe07c44a012ddba0?raw=1


Done.


**This file contains unused source code.**
*PyUnusedCodeBear, severity 1, section `python`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 7.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -4,7 +4,8 @@
 import tempfile

 from coalib.bears.Bear import Bear
-from coalib.misc.Shell import escape_path_argument, run_shell_command
+from coalib.misc.Shell import escape_path_argument
+from coalib.misc.Shell import run_shell_command
 from coalib.results.Diff import Diff
 from coalib.results.Result import Result
 from coalib.results.RESULT_SEVERITY import RESULT_SEVERITY
```


как-то это выбивается из программы качества по javascript. все переменные объявляются в начале функции, а инициализируются уже когда надо.


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 40.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -38,6 +38,8 @@
     # TODO Look for existing classes inside python...

 # TODO Dynamic kwargs usage. Context depending signature.
+
+
 def Linter(executable, **kwargs):
            #shell=False, #TODO ??????
            #output_regex=r'(?P<line>\d+)\.(?P<column>\d+)\|'
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, lines 42 to 43.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -39,8 +39,8 @@

 # TODO Dynamic kwargs usage. Context depending signature.
 def Linter(executable, **kwargs):
-           #shell=False, #TODO ??????
-           #output_regex=r'(?P<line>\d+)\.(?P<column>\d+)\|'
+           # shell=False, #TODO ??????
+           # output_regex=r'(?P<line>\d+)\.(?P<column>\d+)\|'
            #             r'(?P<severity>\d+): (?P<message>.*)',
            #use_stderr=False,
            #use_stdin=False,
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, lines 45 to 51.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -42,13 +42,14 @@
            #shell=False, #TODO ??????
            #output_regex=r'(?P<line>\d+)\.(?P<column>\d+)\|'
            #             r'(?P<severity>\d+): (?P<message>.*)',
-           #use_stderr=False,
-           #use_stdin=False,
-           #provides_correction=False,
-           #diff_severity=RESULT_SEVERITY.NORMAL,
-           #diff_message='',
-           #severity_map=None):
+           # use_stderr=False,
+           # use_stdin=False,
+           # provides_correction=False,
+           # diff_severity=RESULT_SEVERITY.NORMAL,
+           # diff_message='',
+           # severity_map=None):
     kwargs["executable"] = executable
+
     def create_linter(cls):
         class Linter(LocalBear):
             handler = cls
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, lines 102 to 103.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -99,8 +99,10 @@
                     stdin=stdin_input,
                     shell=self.shell)

-                self.stdout_output = tuple(stdout_output.splitlines(keepends=True))
-                self.stderr_output = tuple(stderr_output.splitlines(keepends=True))
+                self.stdout_output = tuple(
+                    stdout_output.splitlines(keepends=True))
+                self.stderr_output = tuple(
+                    stderr_output.splitlines(keepends=True))
                 results_output = (self.stderr_output if self.use_stderr
                                   else self.stdout_output)
                 results = self.process_output(results_output, filename, file)
```


**Line is longer than allowed. (84 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 91 column 81 to line 91 column 85*.


**Line is longer than allowed. (83 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 102 column 81 to line 102 column 84*.


**Line is longer than allowed. (83 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 103 column 81 to line 103 column 84*.


**This file contains unused source code.**
*PyUnusedCodeBear, severity 1, section `python`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 7.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -4,7 +4,8 @@
 import tempfile

 from coalib.bears.LocalBear import LocalBear
-from coalib.misc.Shell import escape_path_argument, run_shell_command
+from coalib.misc.Shell import escape_path_argument
+from coalib.misc.Shell import run_shell_command
 from coalib.results.Diff import Diff
 from coalib.results.Result import Result
 from coalib.results.RESULT_SEVERITY import RESULT_SEVERITY
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 37.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -34,7 +34,8 @@

 class LinterHandler:
-    def create_arguments(self, filename, file, config_file): # TODO Also file???
+
+    def create_arguments(self, filename, file, config_file):  # TODO Also file???
         raise NotImplementedError

     def generate_config(self):
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 49.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -46,7 +46,8 @@
 # TODO ------> Or "hybrid" approach, needed arguments are optional, if one activates
 # TODO ------> further options these get passed by kwargs
 def Linter(executable, **kwargs):
-    kwargs["executable"] = executable # TODO Sucks...
+    kwargs["executable"] = executable  # TODO Sucks...
+
     def create_linter(cls):
         class Linter(LocalBear):

```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 58.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -55,7 +55,9 @@

             @property
             def handler(self):
-                return cls # TODO Directly import functions? Rethink design maybe then...
+                # TODO Directly import functions? Rethink design maybe then...
+                return cls
+
             @property
             def executable(self):
                 return kwargs["executable"] # TODO This needs to be solved more elegant...
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 61.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -58,7 +58,8 @@
                 return cls # TODO Directly import functions? Rethink design maybe then...
             @property
             def executable(self):
-                return kwargs["executable"] # TODO This needs to be solved more elegant...
+                # TODO This needs to be solved more elegant...
+                return kwargs["executable"]

             def _execute_command(self, args, stdin=None):
                 # TODO Also more elegance...
```


**Line is longer than allowed. (84 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 46 column 81 to line 46 column 85*.


**Line is longer than allowed. (89 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 58 column 81 to line 58 column 90*.


**Line is longer than allowed. (90 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 61 column 81 to line 61 column 91*.


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 90.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -87,7 +87,8 @@
                     origin=groups.get("origin", self),
                     message=groups.get("message", ""),
                     file=filename,
-                    severity=int(groups.get("severity", RESULT_SEVERITY.NORMAL)),
+                    severity=int(groups.get(
+                        "severity", RESULT_SEVERITY.NORMAL)),
                     line=groups.get("line", None),
                     column=groups.get("column", None),
                     end_line=groups.get("end_line", None),
```


**Line is longer than allowed. (83 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 73 column 81 to line 73 column 84*.


**Line is longer than allowed. (85 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 83 column 81 to line 83 column 86*.


**Line is longer than allowed. (81 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 90 column 81 to line 90 column 82*.


**Line is longer than allowed. (82 > 80)**
*LineLengthBear, severity 1, section `linelength`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 111 column 81 to line 111 column 83*.


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 38.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -36,6 +36,7 @@
 class LinterHandler:
     # TODO Damn fuck what about required section settings....
     # TODO Doing the handler stuff below static? see line above^^
+
     def create_arguments(self, filename, file, config_file):
         raise NotImplementedError

```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/bearlib/abstractions/Lint.py`, line 51.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/bearlib/abstractions/Lint.py
+++ b/coalib/bearlib/abstractions/Lint.py
@@ -48,7 +48,8 @@
 # TODO ------> Or "hybrid" approach, needed arguments are optional, if one activates
 # TODO ------> further options these get passed by kwargs
 def Linter(executable, **kwargs):
-    kwargs["executable"] = executable # TODO Sucks...
+    kwargs["executable"] = executable  # TODO Sucks...
+
     def create_linter(cls):
         class Linter(LocalBear):

```


The former embedded bsdiff from swupd-client created files with 600, and the version from swupd-server created them with 644. Because this project derived mostly from the swupd-client version, that's why we're seeing the files with 600 perms.


The 2.00 and 0.80 parameters

Run 60k at 20 + 0.2


pRCon is already checked above


gpConEmu is a "life-time" pointer


There is a bug (Kyle can describe more) where the Pi's clock is reset to default and need to be restored to current time before it can continue sending messages through IoT Hub. He's catching the exception, but has no way of internally fixing it. This is the first half of that solution.


Thanks! I appreciate the information. The speed increase is very impressive (as I have already said :smile:), and I want to make sure I understand what conditions are necessary for the custom engine to be used.


The 0.80 value should be no higher than 1.50.


should fix some commented out debug code around these


Exactly, and the monomorphic caching will even be automatic since it's a final property if the the class is constant (but keeping the explicit cache allows for a polymorphic cache).


I would second Ryan's request for an explanation of technical debt, but perhaps you could just provide a link to another resource that explains it rather than adding more content to an already fantastic summary.

You could similarly link to some of the tools you mention (Shopify, Squarespace)

Finally, let's make sure that we don't have a lot of overlap between your contribution and what @etabas made.


Heiner,
It is no more in Python3. Please compare
https://docs.python.org/3.5/reference/lexical_analysis.html#integer-literals
vs
https://docs.python.org/2.6/reference/lexical_analysis.html#integer-and-long-integer-literals
Yet that was the only issue I noticed when trying pylibconfig2 on python 3.
Was it luck? ;)
Thanks anyway!
BR,
Jerome.

On Fri, Feb 26, 2016 at 5:32 PM, HeinerTholen <notifications@github.com>
wrote:

> If you could add a test for long integers, that would be really great. =)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jerome-jh/pylibconfig2/commit/a9b4b61722ba74cc645062e94132ba286b438e7e#commitcomment-16356724>
> .
>


Is it a property of the Take calls that `src` is local?


Done (in both the places).


the same quirk as previously, to preserve backward compatibly.


Not sure I would use a switch for this, just
```
if con[0]=="no-new-privileged" {
...
```


As a test dependency, I have no issues. As a runtime dependency, I have some worries. The versions of guava vary greatly in APIs and they have not stabilised as of yet, nor have they committed to. (that was when I reviewed it a year ago, correct me if I'm wrong)

I'd hate to create problems for Mondrian embedders out there unless there is a good reason to. So far there is nothing in Guava that we badly need which would justify the new dependency. (again, opened to debate)


This demonstrates, among other things, screenshot capture code.

The base directory to which screenshots are saved can be changed via system property.  By default, it's the current working directory (generally root of module), then "surefire-reports/[Test Class name]/[Test Method Name]".

Even though I originally had this directory name to allow Jenkins to know about the screenshots, I find its a good convention in general.


This differs compare to my last PR.


replace with your own driver construction


:+1: :100: Awesome.


N.B. deleting the last trace on a scene, deletes the scene.


Hi Leo, Can you submit a pull request or diff with the changes you feel are appropriate? Thanks, Alex


Hey! Do you happen to have your code from lesson 32 in S1? I've been using your repository as a reference when working on it myself.


@VoyagerOne : OK, if you say so. I was thinking on tuning with some other parameters. If we tune more parameters, we can than selectively run sprts with only some of them base on your experience. I know that you have done many tests with lmr and I guess that you have some experience here. Also, with this change in reduction formula, maybe some other parameters are not optimal any more.


captured here for use in the screenshot code.


Man pages for docker-run and create.  Although it looks like seccomp is not covered in these either.

contrib/completion/*


Sure.


I would prefer using `vars(self)` instead^^


My hope it to get some debugging information into ST at some point to help syntax authors easily identify slow regular expressions.


@duke12468 If it is truly instantaneous gain, than it's using my method -- reworking the incrementation operation. That being said, these method(s) being broadcast on Atlava, are indeed just making use of multiple BM rooms and client sided stats. Multiple BM rooms for medals, stats for boosted carat/exp gain. The reason why I'm leaning against the later option, is due to all the chatter on Atlava, as well as the given evidence of the code posted here.

In Tomoko's case, which is most likely the one who developed the "trainer" everyone's talking about -- as can be seen from his code samples -- he isn't an experienced programmer. I'm not criticizing him, given the fact that he is still learning and has made the effort to due so, Though this would imply, that a complete GameGuard bypass would be out of the question, needless to say my method as well as "speed" hack probably isn't in use with their services.

As such, the entire service at play is quite trivial.

Again, I am not criticizing anyone -- I'm only 20 years old and my programming experience is also limited -- I'm not some sort of cyber jesus. My Finis project will just be a more solid version of both TyE and PyE. I'm also not oppose to telling and or teaching anyone how to accomplish any of which I've stated, as can be seen by my previous posts in this commit. But seeing others pay for something I've literally released and explained for free leaves a bad taste in my mouth.


Can you remove the unnecessary `this` here?


@nishant-cyro this one is going to fail is someone will supply admin path like "/admin/secret" - let's just check the first character if it's / and remove it


solveTemplatePath --> resolveTemplatePath


In addition to providing the webdriver instance, there's some other handy methods (perhaps that ought not to be here).


This `return` is unnecessary


You might need to set `content_type = "text/cloud-config"` here


Sure.  I'll include it with the deb changes.


This allows tests to just grab arbitrary screenshots when they need them.


You could use a more generic name than 'build-to-fix'.  People not famliar with what build-to-fix is may wonder why you chose this name and what it means.  Maybe just `myStack.template` could work.


This is probably too vague - there are separate example programs for NVMe and I/OAT, and we should give the full path here if it is going to be mentioned (e.g. `examples/nvme/perf/perf.c`).


I was thinking on tuning without nodestime option. Is that OK?


@rudkx I'm not sure that your change is correct.

In the original code, `FR` was assigned  `BI->getOperand(1).getOperand()`.

In your new code it becomes: `BI->getOperand(1)`


An oddly named system property which refers to the current working directory.


I am not opposed to this change, but what is the motivation?  The traditional way to write tar options is the plain letters without the dash.  I think all modern tar implementations can autodetect compression based on the filename, but it doesn't hurt to include the `z` explicitly here.


@tjchambers I should have written a slightly different/more verbose error message. The end result is that it removed stale cassettes; but what I actually did was simply regenerate the cassettes from scratch, which removed a ton of yaml config that was no longer being used.


Whatever you think is best...


misc* :(


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17433](https://teamcity.mesosphere.io/viewLog.html?buildId=147078&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 238 Build time: 00:05:13


I think this is a typo ("are" is duplicated).


Yeah, that's why I left it. Unlikely that there's a `phone` missing one of those, but /shrug


Dann versuch's bitte nochmal hiermit:

```python
import requests
try:
    from bs4 import BeautifulSoup as Soup
except ImportError:
    print('Kein BS4 da :/')
    exit

r = requests.get('http://warez-world.org/kategorie/filme')
try:
    soup = Soup(r.text, 'html5lib')
except:
    soup = Soup(r.text)
print(soup.prettify() + '\n\n\n')
print(soup.findAll('li', {'class': 'main-single'}))
```

Bitte dann nochmal die Aussgabe hier beifügen.


I believe "scalable" is the correct spelling.


Ah sorry `dict(vars(self))`


Oh i see, then a pull request would be greatly appreciated.
Thanks in advance.


:+1: cool


Зачем была удалена строка 33?


Wouldn't start-stop-daemon be a better place to do such uid change?


pig oil is too disgusting


You probably want dup instead of clone in this case because dup is shallow, clone is not, dup is faster and unless you are wanting very specific features of clone it's always better to just duplicate.


@dkubb I expected something far more magical than that from you. I elected NOT to do that on purpose to be clear about what I was removing. In the end it could get to the same point, but there was one that had to be manually edited - did you edit that one?


Это сопровождающий рефакторинг


Not sure I follow - could you elaborate?


`root@gitlab02 ~ # /opt/gitlab/embedded/sbin/nginx -V
nginx version: nginx/1.9.10
built by gcc 4.9.2 (Debian 4.9.2-10)
built with OpenSSL 1.0.2f  28 Jan 2016
TLS SNI support enabled
configure arguments: --prefix=/opt/gitlab/embedded --with-http_ssl_module --with-http_stub_status_module --with-http_gzip_static_module --with-http_v2_module --with-ipv6 --with-debug --with-ld-opt=-L/opt/gitlab/embedded/lib --with-cc-opt='-L/opt/gitlab/embedded/lib -I/opt/gitlab/embedded/include'`


OK, I think that more than 60K games is needed, but I'll do as you say, and I'll try my best with this 60K games.


Sebastian Estupiñan Vargas


@obalogu2 You won't want to call `getHead` in your `dropWhile`, as `dropWhile` should be well defined on the empty list.

`dropWhile(Nil)` should be Nil
`dropWhile(Cons(1,Cons(2, Cons(3, Nil))), _ < 3)` should be `Cons(3, Nil)`.


funky line wrapping


@Creeperface01

Fatal error: Declaration of pocketmine\item\LeatherCap::getProtection() must be compatible with pocketmine\item\Item::getProtection(): int in /home/danny/ImagicalMine/src/pocketmine/item/LeatherCap.php on line 30


The `template_cloudinit_config` resource was removed, because AWS's version of cloud-init wasn't handling the multipart upload properly. If you look at the `template_file` resource above, that has the latest changes. Also, cloud-init can derive the mime-type `text/x-shellscript` from the `#!/bin/bash` at the top of the file, BUT adding it in manually is also good. How would I do that?


Ok thank you very much.


ThermCalcRelHumUseSameHumidRatioDryBulb (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1013 of 1013 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-29.46%25-green.svg)


There is a typo here - the h shouldn't be there. / Mattias


edwedr


comment doesn't match the code


Habilitado (true) para que o CI substitua o underline _ por um traço - na url


ThermCalcRelHumUseSameHumidRatioDryBulb (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


one commit


I really like the readability that this creates. Pylint makes a fuss about the indentation structure though. And actually, after looking at the Pylint recommendation, I feel it has a nice aesthetic to it. Your eyes go top to bottom to capture the parameters instead of top right to bottom left.
Love the trailing comma suggestion - that's really clever.


Off by one indent ^


> I expected something far more magical than that from you.

Lol. No, I wanted to have something bare-bones to start with so that any additions to the cassettes could be scrutinized to evaluate it's necessity. I felt we were in a state where if a new recording was made I couldn't tell whether it was done on purpose, or as a result of some legacy decision that changed.

Going forward I want to look at cassette additions with suspicion, and make sure that they are actually required.

> In the end it could get to the same point, but there was one that had to be manually edited - did you edit that one?

No, curiously I didn't need to edit any of them. I didn't even know about that.


this must be replaced with "receive", otherwise the logic is broken.

(A side note. Presence of this test in mock library is a little weird. You're trying to test that jndn library do the job of properly dispatching interests.  Useful, but not the ideal place to put this test.)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17434](https://teamcity.mesosphere.io/viewLog.html?buildId=147082&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 238 Build time: 00:08:36


I'd say you're right to hold off if that's your plan.


我的世界


Hi Laurentiu,

Thanks for submitting the pull request. There are two things need your further updates:

1. `Put` and `Remove` method should not silently return when exception encountered. Instead wrap them into an `UnexpectedIOException` and throw em out.

1. Implement the `createSubFolder` method.

BTW do you think it needs to make `BlobObject` public? Is there any case that this class is accessed from outside? My experience is XxxObject could be package scoped as only XxxService needs to access them. Outside program can always use either `ISObject` or `SObject` to reference those detail implementation.

Thanks again for your contribution!


This assumes TCHAR == WCHAR unconditionally. The MultiByteToWideChar transformation should be used only if UNICODE is defined. In this particular case there is a cleaner solution: define wstr as WCHAR and use SetDlgItemTextW.
However, I think we should just deprecate compilation without unicode.


I'm frankly perplexed that the entire argument against using a format that is expressive, human-oriented, reasonably well defined, and widely implemented is "Ruby hasn't done a good job with handling that for some minority of its users."

If not YAML, then JSON maybe? Though I'd like something that's more amenable to comments.

Or, if we really want something so minimal that it requires no parser, maybe we should consider tab-delimited fields with line-delimited records? Or maybe a directory structure like DJB used in Qmail?

Bottom line: Proposing an entirely unimplemented parser to an unspecified grammar as being somehow more accessible to niche deployments than something widely in use elsewhere is bizarre.


I think, we should not remove `or any other environment file` phrase.

@prathamesh-sonpatki: any thoughts?


The current spec does not mention regarding pointerover/enter firing when processing pending pointer capture. Similar to pointerout/leave that are mentioned in that section we need to fire pointerover/enter events as well in some situation.
I doubled checked with Edge and it does fire pointerover/enter the same as it is explained in the proposed patch as far as I found.


Should probably have a `where isLocked()` condition here since there's no point in recording an expired timestamp.


Another option here would be convert this `kmutex_t` (48 bytes) to a standard Linux spinlock_t (4 bytes).  There is a memory allocation under the lock but it's tiny and could easily be made atomic or even moved outside the lock with minimal restructuring.  This would eliminate any possible increased contention and reclaim the the vast memory of the memory used by this kmutex_t.


And might want to `nil` out `lockOutTimestamp` here, for completeness.


I strongly support that approach, although mere rearrangement or insertion of spec examples seems to though everything off balance and trigger additions.

Re: editing the candidate_spec needed editing and I edited it twice to remove the failed hits.


Looks fine, do you think you can fix the documentation that says 1.10 instead of 1.10.x?


Uday, do you think we need another library for this? Does the Bootstrap modal which we are already using not work?


Commenting on the change: looks good


Works fine for me too, thank you.


Oh sorry I didn't realize this was a continuation of the existing issue. I'm *not* in favor of a new format, but *am* in favor of something more established. JSON makes sense to me.


I just deleted this


This is some amazing work! I gotta get back into C++. Have you seen @Gh0stblade's work on [cdcEngineTools](https://github.com/Gh0stblade/cdcEngineTools)? My C++ is way rusty, but it looks like he might have some insights on the CDRM format.

I got setup again to build your code, so now hopefully I can start picking things up again.


> although mere rearrangement or insertion of spec examples seems to though everything off balance and trigger additions.

Right, hmm. I wonder if we can figure out a scheme that makes this less likely to happen. Or something that makes it so additions are easier to notice.


This change greatly reduced the file size while maintaining the image quality.


You are welcome, it will be started later today.


:wave:


:metal:


@Divgo123 Great post! I agree @MBenkert16 there might be some overlap with mine but overall great takeaways. Might I suggest removing numbers 3 and 8?


Displaying the words of a category in a listview is a good idea!
Icons in the top right is ok. A 'pie' icon for the graphical representation., and a 'T' icon will be more common.


Here and in NettyClientTransport.ping.


:eyes:


For real this time.


-16px looks good to me


I was wondering if AWS cloud-init needed the content-type to recognize it as multipart. The documentation for AWS and cloud-init says that multipart cloud-init is supported: http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/AmazonLinuxAMIBasics.html


you are so mean


Actually you could do even better if you packed the spinlock in the 4 bytes wasted next to the to the existing 32-bit `b_datacnt`.  Then you'd reclaim all 48 byte and avoid any contention.


Taking back my words, that doesn't look correct


I don't think that particular case works though maybe it should. idk. I meant an unused parameter. That one definitely works on clang 3.8, but not others. Don't you remember? :laughing:


Lovely! :heart:


Nice work, @jae9970 . If you put the word you want linked in brackets followed by the http://www.site.com in parentheses, it should hyperlink correctly and make your formatting super cool.


@nemchik good catch, whoops. That was in there for testing to make sure the loop triggered as intended.


Ugh... meant to reference #68 in the commit message!


I'd have to check to be sure but I think PreparedStatement implements AutoCloseable, so you can use the resources-declaration form of try-catch:

```
try (PrepareStatement ps = entry.getValue() {
  code to do stuff
} catch (SQLException e) {
  handle
}
// nothing else b/c with resources auto-closes after, with or without exception.
```


'%' is special character I think


# This is an <h1> tag
## This is an <h2> tag
###### This is an <h6> tag

* Item 1
* Item 2
  * Item 2a
  * Item 2b

![GitHub Logo](/images/logo.png)
Format: ![Alt Text](url)

http://github.com - automatic!
[GitHub](http://github.com)

As Kanye West said:

> We're living the future so
> the present is our past.


why don't you use certmng.php on Linux as well?


I mentioned this in another comment, but from a high level is seems like this process could be more straight-forward.

My concern is that we are making this somewhat fragile by needing a bunch of order-specific / call-once mechanics. Also, definitely don't want to add "already encoded" flags, thats just more state complexity.

Do we need to store the encoded template states at all? Can we not just read all static values into say "config" and "template", then when we wish to export that data, we apply config to template and export in whatever format we want (disk / stack template / whatever)? This doesn't mean immutable, it just means a repeatable export process.

My gut reaction is that we're overloading "config" and it should be broken up into "config" (just holds config values) and "templates" which are just that. Our "stack" then just becomes those two pieces. Exporting (depending on the target) then operates on those raw values (but has no reason to overwrite its own underlying data).


```javascript
if (isAwesome){
  return true
}
```


if (isAwesome){
  return true
}


The function is called IPv4ToInt(). Therefore, shouldn't the distinction between IPv4 and IPv6 been made by the caller (and implying that we have an IPv6ToInt() function)?

If we think the distinction should be made here then we have to rename the function to just "IpToInt()".


how do you mess that up so badly


[Epic Box Story.docx](https://github.com/sparc-request/sparc-request/files/147466/Epic.Box.Story.docx)
Attached is some literature that you might find useful about how the epic box came to be!

Hi Chris!
Great questions!
I quickly pushed this up because I had to move on to something else and it was not finished.  But now I've pushed up more recent code, check it out (still not finished)!

'What if the set of base attrs is valid but the question group attrs is not?'

I’m still trying to figure out why this is happening, but if I don’t update the attrs like I’m doing before I call update_attributes, then the study_type_question_group_id is updated to be ‘0’, which is bad since that doesn’t correspond with anything in the database.  I need a second pair of eyes on this, if you have any suggestions, let me know!  So for now, that’s how I’ve gotten around that issue.

'I'm wondering if in the old code @protocol would have gotten updated with the first update_attributes call but then if the update_attribute(:study_type_question_group_id call failed the change would have still been made on @protocol'

As long as the attributes with validations on them in the protocol model pass, it will be saved to the database.  There are no validations on the study_type_question_group so if I’m not careful, bad data can be added to the study_type_question_group_id and saved to the database, I will have to consider that moving forward.

'Maybe it's better to have the whole thing update or not, but could this potentially change the way something was working for a user?'

I'm not sure I understand what you are asking, but from what I can remember it's updating the same way that it was except that I'm merging in the study_type_question_group_id.  Since this is a update method, it needs to update all the attributes given to it.  Does that make sense or did I completely misunderstand?

'Also, could you help me understand what this code is doing and why?
It looks like if the @protocol_question_group_id is the active one then we are updating_attribute to the same value?
Why would we change this to be the first inactive group otherwise?'

This all has to do with an edge case in which the product owner wanted to only display epic questions/answers in portal/admin (last paragraph of attached file).  Across the app aside from admin/portal, you want to be able to edit the epic box answers.  In admin portal, the only case in which they wanted to  edit a study was when a user changed from a virgin project to a study.  When you change from a project to a study, it hits the Protocols Controller#update_protocol_type, here I added a method called conditionally_activate_protocol that checks to see if you are changing to a protocol type of Study and that selected_for_epic is null (attributes of a virgin project).  If both this conditions are met, that protocol gets updated to an active study type question group (able to edit in admin).  Then after it hits the Protocol Controller, it hits the SubServiceRequest Controller#update_from_project_study_information.  Here is where your question comes in, and I’m embarrassed you saw that code haha it was very messy and I had remnants in there from another idea I had, but is cleaned up now!  I covered this when answering your first question- it’s a work around for now.  I’m going to have someone look at it with me asap.

I hope this answers your questions, let me know if you have more or any suggestions you would like to make.  Thanks!


This was, as I recall, a placeholder to move to v6 but never went too far.


You are reading the current_version from the os-release file in a loop here.  Should be outside the loop. Or better still can get the version using MoM->version since you have already read the version file in download_manifests(). Avoids unnecessary file read.


I will be tweaking the filtering a little more tonight. Creative documents the sound card as having a 100Hz-10KHz response, but listening carefully to playback on an actual Sound Blaster Pro suggests the lowpass filter is not quite right when the filter bit in the mixer is set (output filter bypass), but the lowpass emulation is correct when the output filter bit is zero (output filtered by 3.8KHz lowpass analog circuit). I also need to verify the lowpass/slew filter against a Sound Blaster 2.0 card in another test PC, and a Sound Blaster 16 in yet another test PC.

I actually use a pair of earbuds for listening tests, rather than speakers.


My biggest concern about MongoDb was actually that its not actually ACID compliant. But after trying out Braintree I realized the all the donation/transaction data is all going to be stored on Braintree's server as well. Our donation table is pretty much just the data we get back from them. MongoDB can kind of do relations, it wont strictly enforce them but I think it should be fine. We could always swap it out for mysql or postgresql later if need.

I'm not sure what to add next, I'm thinking about making the social feed show actual donations, but were kind of at the point were we need to meet and talk about what else the site should do. I'm also thinking that we should add some actually testing to this thing before we go to far ahead in development.


@zecoxao I'm quite sorry to bother you, but the `analyse_sprx.idc` script seems broken for some .sprx such as `libspurs.sprx` from 1.5x CEX/DEX PUP. It seems could not find TOC/OPD correctly.
*Since the issue tab is disabled in this repo, I could only come here to ask for support in comments.*


go make your silly sprout-wrap module now.


Shouldn't line 137 be outside the loop?


Well, whatever the reason: If we handle both IPv4 and IPv6 here then the function name needs to be changed.


In javacutil/src/org/checkerframework/javacutil/AnnotationUtils.java we have methods createAnnotationSet and createAnnotationMap to abstract away what concrete class we use.
Should we add methods that use `Class<? extends Annotation>` to that class and unify all these instantiations?


Change this simply to:
`                    throw new AppenderNotFoundException("Appender not found!");`


Change this to:
`throw new LoggerNotFoundException("Logger not found!");`


Change this to:
`throw new LoggerNotFoundException("Logger not found exception");`


How do you go to a planet now then?


Not only is that the most trivial micro optimization ever given that these functions are only run once when PAC is open and closed, it's also wrong.
```
local runs = 100000
local str = "asdfasdfaasdfasdfasdfasdfasdfasdfasdsdf"

local time = SysTime()
for i = 1, runs do
	type( str )
end
print( "type: " .. SysTime() - time )

local time = SysTime()
for i = 1, runs do
	isstring( str )
end
print( "isstring: " .. SysTime() - time )
```

```
] lua_openscript typevssistring.lua
Running script typevssistring.lua...
type: 0.0062238077903203
isstring: 0.0039761194029779
```


@typiconman
could you please review the tests of slavonic numerals: do generated numbers look correct?

https://github.com/pgmmpk/cslavonic/blob/master/cslavonic/test_numerals.py

are there any other corner cases that are worth testing?


Воспользовался советом Игоря :)


I don't think so. I think the issue here is basically a really confusing lib key. "Glyphs" doesn't refer to all the glyphs in the font, but rather the Glyphs app (which uses these inconsistent key prefixes for whatever reason: `com.schriftgestaltung.` for font-wide lib entries and `com.schriftgestaltung.Glyphs.` for glyph lib entries). The flag is present in a single glyph's lib, so I think it only applies to that one glyph.


I think this would leak memory. You should delete the existing `link`. `Master` owns the links.


Fixed bug in plot Figure(51)


I don't want the Linux backend to depend on the extension's codebase.
At least somebody could install it before a new version of the extension is released.
And there are some customers who use it in CLI without the extension.


upload the picture


I wonder if we should just call it `decompose` (distinguishing from the other one by the extra `master` argument).


Also added Beluga species


Oh, sorry, misread this.  I guess the concatenation of lib_prefix and 'Glyphs.Export' could be moved outside the loop, though?


＋1


一开始我也试着用螺旋的性质来解 画个图没想明白

发现O（1）space可解 就可以一个个试 看每条新边和它之前最多 N 条边是否相交 试出来 N=5
简直蠢哭

2016年2月26日星期五，CHANG LI <notifications@github.com> 写道：

> 之前的有bug
> 中间那行应该是：
> if ((++i < xSize) && ((i > 4 && x[i-1]+x[i-5]>=x[i-3]) || (i==4 &&
> x[i-1]==x[i-3])) && x[i]+x[i-4] >= x[i-2]) return true;
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CHANGLI0914/LeetCode_G-C/commit/bbcf715540a8bab0d52b4d4acfd15a1e5856ae37#commitcomment-16341287>
> .
>


The implementation feels like a lot of code duplication, especially because `master` is barely used. I wonder if we can write a functor to plug into the existing `decompose` implementation that would do the job.


Isn't this true for all other errors in this subdirectory? They are all for the Subtyping Checker instantiated for the Encrypted system.
Instead, should we rename the directory?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17353](https://teamcity.mesosphere.io/viewLog.html?buildId=146649&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 238 Build time: 00:04:43


ok


Yea, I think that'll be more clear.


Mm, I may have done this badly; I missed a loop in the entropy calculation, so I added it in and did a commit --amend, and a push --force; I figured nobody had cloned the repo in the meantime.  But it may have been enough to mess github up, as it seems to be pointing to the earlier commit.


The sin and cos functions for ring might need to be flipped based on where the angle is coming from. https://en.wikipedia.org/wiki/Spherical_coordinate_system.


Actually, the query is broken otherwise. The current code will return an SQL error when $aCurators is empty, so we'll have to create a condition somewhere. This part:
```
WHERE u.id IN (' . $sIDParams . ')
```
Would read:
```
WHERE u.id IN ()
```
Which isn't valid SQL. So if we would extend $sIDParams (and rename it, I guess) to include more of the SQL, and also build the function's arguments in a condition, it would work. Or perhaps just let the function return false when $aCurators is empty?


Static vs shared should probably be a build option. Insisting on static libraries would break some of my other projects.


If it's not too destructive, it would help to limit the scope of this initial PR to just be feature parity. Then adding things like upgrades as separate PRs. If it is destructive, don't worry about it.


wtf


lol systime and not frametime or realtime


Replace __threashold__ with __threshold__.


Looks like I now get values both in seconds and percents when I subscribe to `audioprocess`.
Shouldn't here be `wavesurferSegment.getCurrentTime()` instead of `percent`?
cc @katspaugh


@slapin: And then 4.0, and then 5.0? xD


discussed offline. pointer is for Unmarshalling into the stackHolder. However, because this var is used elsewhere, suggest initializing as map, and passing pointer specifically to Unmarshall


Yeah, I see what you mean, this is getting unsatisfyingly complicated.

I wonder if now that this type-comment-matching logic is more complex, it'd be helpful to pull it out as a separate, subsequent loop from the `tok_nextc` loop. So first have the simple loop that just gets characters up to the end of the line, like upstream; then a loop that goes back through from `tok->start` while advancing in parallel through `type_comment_prefix`.

Then that separate loop should be simpler because in particular it can manage its logic with normal control-flow constructs like `break` rather than with its own extra local variables like `is_type_comment` and `tc_start`, because it's not sharing the loop with other logic that has different control-flow needs.


Yes, mostly to use the filePath lib for any explicit path operations (os compatibility)


You still need the `+ 6`, right? That's what ensures that comparing to "ignore" doesn't overrun the end of the token.


Also has the Logout Button feature.


note to self: reviewed `print_tree.rs`, `time.rs`


|Sumit Shrestha| [sumitshrestha08] (HTTPS://github.com/sumitshrestha08) ||


note to self: reviewed `webrender_helpers.rs`


note to self: reviewed `table_foo.rs`


Can you leave a comment saying in which phase this gets filled in?


Unfortunately it's been a couple years. So it's no longer fresh in my head. Perhaps you're using R v3 and we were using v2?


Now has status messages.


finish his


http://www.swiftless.com/tutorials/opengl/sphere.html
Strong Tutorial that walks through this step by step.


doesn't removing the existing check result in duplicate directives when the playbook is executed multiple times?


Why not just leave the implementation out, so the Rust compiler will emit an error if this isn't implemented in a subclass?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17354](https://teamcity.mesosphere.io/viewLog.html?buildId=146659&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:04:02


Modifying the copy assignment operator causes `CrystalTest_ConnectedComponentLabelingTest` to fail.
```
Framework/Crystal/test/ConnectedComponentLabelingTest.h:608: Error: Expected (2 == uniqueEntries.size()), found (2 != 3)
```


LGTM
Acked-by: scui@redhat.com


note to self: reviewed `inline.rs`


I reread the gitignore manpage. It's fine as-is (both in this case are functionally identical). fwiw it is relative to the .gitignore file either way.


Awesome first push bro!


| <Jason T> | [<GitHub Username>](https://github.com/<Github Username>) | <Supsup> |


It's true there shouldn't be themed cards at the very beginning (unless it's some sort of grand opening theme or something), but if there are any themes or packs right now, they are just example themes and packs. Also, you don't have to make them available to clients immediately, but it's nice to have them stored in case you want to release or re-release them in the future.

Also, I need to update this file a little bit XD theres some things that I thought were a good idea, but I later changed them and forgot to change this file.


Now has Logout Button and Admin Main Menu button.


Hi Kevin,

All this change does is not fail the job entirely when the Datastore splitter can't split the query. I do not know how the Datastore library itself works.

However, there are restrictions about what types of queries that library is able to split. If you're seeing this error in a program you're writing, you might try contacting the Datastore support team to help with splitting your query.

Thanks!


I need one less ring that I have subdivisions.


LGTM


true :(


Buttons coded by Paolo Baculi.


Logout button coded by Paolo Baculi.


redirectTab.php edited by Josiah Villanueva.


It doesn't handle IPv6 values really, just the two different forms of IPv4 values.
Direct 4-byte values and 16-byte ones that have v4InV6Prefix and the last 4 bytes are the IPv4 value


Added sha function and url bypass filter. -Jan David Umali


fixes #1


Ok.

Have we actually run into those values? Where and how?

But whatever the situation, we should probably update the comment then to explain this.


Set your editor to indent using 4 spaces to match the existing style(which is inherited from the example code).