If this is sending `dashboard.html` for any HTTP request to the server (not just for `/`), I think this change is incomplete and needs a little routing layer.  Browsers automatically make requests to `/favicon.ico` and robots make requests to `/robots.txt` and other pages.  Sending `dashboard.html` no matter the request seems kind of sloppy.  (And I plan to have a `favicon.ico` in the future.)

If I am wrong and `dashboard.html` is sent only for `/`, please ignore.


I have not done any testing on Fedora. Have you? In theory it should be similar to EL.


The `.get()` function on the hardware map just returns a `DcMotor` object. That's already being done above. The only reason I didn't do it in `TeleOp2016.java` is because theose had to have reverse operations applied first.
Is this OpMode even in use anymore?


@valib fixed in https://github.com/UniversalMediaServer/UniversalMediaServer/commit/516bdc71dea8333a46165ab653290166f08e8436


space after if


same


Alteração


I was going off of the actual config instructions

```
#
# Plugins
#
# Leave blank to ignore.
# See https://support.serverdensity.com/hc/en-us/articles/213074438-Information-about-Custom-Plugins
#
plugin_directory: {{ plugin_directory }}
```

Which is why I was leaving it blank. I don't feel strongly either way, so I'm ok with this change.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16558](https://teamcity.mesosphere.io/viewLog.html?buildId=140743&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:09:14


Hi, sorry for the delay: this one works beautifully, thank you very much! :-)


I should really just delete it, it's not used. I use the hardware map stuff to pass a dcmotor object to the extendeddcmotor


I have just converted the Altis mission to Eden, but I don't know the repercussions yet, so they will stay in the old format on GitHub for now. I will look into it in a couple weeks, as I have midterms coming up in the coming week.

I suggest you stay with the 2D editor for now, which is still available as a button on the terrain selection menu.


This should be a proper error message, since the cause is a mistake in the input.


While in CSharp

using System;

namespace IntroductionToCsharp
{
    class Program
    {
        static void Main(string[] args)
        {
            Console.WriteLine("Please enter your target?");
            int UserTarget  = int.Parse(Console.ReadLine());

            int Start = 0;

            while(Start <= UserTarget)
            {

                Console.WriteLine(Start);
                Start = Start + 2;
            }
        }
     }
}


@liranjiao nice :+1:


I have been converting all my Ansible syntax to be pure yaml compliant.  If you look at the Ansible documentation
http://docs.ansible.com/ansible/playbooks_intro.html#playbook-language-example

They show both types of syntax (either out of inconsistency, or they want you to see both options ;)).
I would prefer to keep this in yaml.


Return false if the loss rate can't be found and let wspace_ap decide.


@Runico, yes, and it 4.9+ problem, 4.8 fine :(


"WspaceAP::UpdateLossRates::Running out of data in packet loss trace."


reverted in 410107cf7606ac61436f46fe52c3ccdcf0de784e


All of lazy collections could go into a 'Lazy collections' group.  I don't think we can make it shorter and keep it descriptive.


@psyvisions thanks for the note, I made a fix: https://github.com/iignatov/LightOpenID/commit/637d7121937c7b7b06b098a3790df8a1df5352ea.


See my comments before - If GetLossRate() return false, return false (don't drop). Remove the comment above it.


Good catch!


Bring the definition of this function into .cc. It's too big now.


How only this hardcoded namespace appeared here...


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16559](https://teamcity.mesosphere.io/viewLog.html?buildId=140744&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:07:07


same


I meant through the swift's diagnostic engine.


change "new ArrayList<String>" to "new ArrayList<>"


same as above


See #197.


That's great to hear!  I'll finish off that mysqli work, it was pretty much ready to go.  I'll try to add some kind of testing while I'm at it...


I have mixed feelings about this.

One of the reasons I put these in the `/vars/main.yml` was because I wanted users to have the option to use `ansible-vault` you don't typically vault a `defaults/main.yml` file. I think as long as we mention something in the README.md about using `ansible-vault` I'd be ok with this.


Should we use async task in here instead of running a new thread?


I agree, the engrish had to go


@SubJunk nice one


I think it will be less of a jump of we return an array for now. Arrays have other nice properties, like they can be used in for loops like `for (var f in ls())`, which our shell string still couldn't.

I'm not opposed to making each shell string have a `forEach` method though. Also, in bash, it by default iterates over each word, which I don't actually like. I always modify `$IFS` so that loops iterate over each line instead. Does that sound like good behavior? It might be too difficult to support both behaviors efficiently


hola como estas


:clap:


At this point, `results` is the response body from the service. So I think you have the reference wrong here.

Shouldn't it be `results.quotes[0].quote`?

I'm also curious what you could do with the other data elements in the return object to make the Slack post richer and more interesting.


TeamCity LabKey :: LabkeyModules15.3 :: Git sqlserver 2014 [Build 113](https://teamcity.labkey.org/viewLog.html?buildId=304643&buildTypeId=LabkeyModules153_GitSqlserver2014) outcome was **SUCCESS**
Summary: Tests passed: 218 Build time: 00:14:40


Is the FB really using this encoding ?


IIRC Ansible still requires python 2, If python3 is not installed on a system, will this still work?


Ho right ! Sorry to forget this.


Good find! This must have been some confusion on my end as to which field to use here. Probably this mistake did not have a large effect, since such close values do not happen very often, but it could have caused some issues in the simulated distance sensor. I did not see them during testing with our current scene files, but it might happen in some corner case.


Please remove the class if no longer neccessary.


Please format to yaml


why are we hardcoding?


Git was causing some weird behavior. I decide to add this change because the previous version wasn't printing the name of the folders. This is right before I start on the newly designed file monitor. I just wanted to have a descent working monitor to branch off of.


By the way, this is crashing on my Swift 3 branch, so I'd really appreciate a better diagnostic here.


Nice.


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/50//violations
```
src/plone/api/content.py:268:1: C901 'delete' is too complex (15)
src/plone/api/content.py:360:1: C901 '_wf_transitions_for' is too complex (13)
src/plone/api/content.py:425:1: C901 'transition' is too complex (13)
src/plone/api/tests/test_doctests.py:118:13: T001 print statement found.
src/plone/api/tests/test_env.py:31:14: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:35:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


yes we are, till we get our server running.


SGTM!


Awesome option.
:100:


These menu buttons represent the single responsibility principle because they are only apart of the user interface and have nothing to do with the actual data calculations or underlying structure. Changing or modifying these menus only effects the interface, nothing more.   (Laura Garcia- 02/20/16)


Ahh re: my previous comment about the python3 script working on systems without python3. I assume this is the required dependency (which will install python3)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16560](https://teamcity.mesosphere.io/viewLog.html?buildId=140748&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:01


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16561](https://teamcity.mesosphere.io/viewLog.html?buildId=140749&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:03


@smcmahon Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.autoform/3//violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/autoform/base.py:0:1: C101 Coding magic comment not found
plone/autoform/base.py:0:1: I001 isort found changes, run it on the file
plone/autoform/base.py:24:1: C901 'AutoFields.updateFieldsFromSchemata' is too complex (11)
plone/autoform/base.py:94:80: E501 line too long (113 > 79 characters)
plone/autoform/directives.py:0:1: C101 Coding magic comment not found
plone/autoform/directives.py:0:1: I001 isort found changes, run it on the file
plone/autoform/directives.py:13:80: E501 line too long (81 > 79 characters)
plone/autoform/directives.py:25:80: E501 line too long (83 > 79 characters)
plone/autoform/directives.py:57:80: E501 line too long (87 > 79 characters)
plone/autoform/directives.py:71:80: E501 line too long (82 > 79 characters)
plone/autoform/directives.py:75:80: E501 line too long (85 > 79 characters)
plone/autoform/directives.py:78:80: E501 line too long (95 > 79 characters)
plone/autoform/directives.py:84:80: E501 line too long (96 > 79 characters)
plone/autoform/directives.py:87:80: E501 line too long (97 > 79 characters)
plone/autoform/directives.py:89:80: E501 line too long (93 > 79 characters)
plone/autoform/directives.py:94:80: E501 line too long (95 > 79 characters)
plone/autoform/directives.py:97:80: E501 line too long (88 > 79 characters)
plone/autoform/directives.py:98:80: E501 line too long (93 > 79 characters)
plone/autoform/directives.py:110:30: Q000 Remove bad quotes.
plone/autoform/directives.py:110:31: S001 found %s formatter
plone/autoform/directives.py:114:13: E122 continuation line missing indentation or outdented
plone/autoform/directives.py:115:13: E122 continuation line missing indentation or outdented
plone/autoform/directives.py:116:80: E501 line too long (86 > 79 characters)
plone/autoform/directives.py:132:80: E501 line too long (94 > 79 characters)
plone/autoform/directives.py:141:80: E501 line too long (93 > 79 characters)
plone/autoform/form.py:0:1: C101 Coding magic comment not found
plone/autoform/form.py:0:1: I001 isort found changes, run it on the file
plone/autoform/form.py:21:80: E501 line too long (109 > 79 characters)
plone/autoform/form.py:35:80: E501 line too long (83 > 79 characters)
plone/autoform/form.py:47:1: W391 blank line at end of file
plone/autoform/interfaces.py:0:1: C101 Coding magic comment not found
plone/autoform/interfaces.py:0:1: I001 isort found changes, run it on the file
plone/autoform/interfaces.py:12:12: E221 multiple spaces before operator
plone/autoform/interfaces.py:13:12: E221 multiple spaces before operator
plone/autoform/interfaces.py:15:10: E221 multiple spaces before operator
plone/autoform/interfaces.py:16:10: E221 multiple spaces before operator
plone/autoform/interfaces.py:18:21: E221 multiple spaces before operator
plone/autoform/interfaces.py:43:80: E501 line too long (89 > 79 characters)
plone/autoform/interfaces.py:49:80: E501 line too long (108 > 79 characters)
plone/autoform/interfaces.py:50:80: E501 line too long (99 > 79 characters)
plone/autoform/interfaces.py:51:75: E127 continuation line over-indented for visual indent
plone/autoform/interfaces.py:51:80: E501 line too long (93 > 79 characters)
plone/autoform/interfaces.py:71:39: E127 continuation line over-indented for visual indent
plone/autoform/interfaces.py:71:39: Q000 Remove bad quotes.
plone/autoform/interfaces.py:72:80: E501 line too long (91 > 79 characters)
plone/autoform/interfaces.py:73:80: E501 line too long (88 > 79 characters)
plone/autoform/interfaces.py:76:31: E128 continuation line under-indented for visual indent
plone/autoform/interfaces.py:76:80: E501 line too long (85 > 79 characters)
plone/autoform/interfaces.py:77:31: E128 continuation line under-indented for visual indent
plone/autoform/interfaces.py:77:80: E501 line too long (97 > 79 characters)
plone/autoform/supermodel.py:0:1: C101 Coding magic comment not found
plone/autoform/supermodel.py:0:1: I001 isort found changes, run it on the file
plone/autoform/supermodel.py:12:80: E501 line too long (84 > 79 characters)
plone/autoform/supermodel.py:13:80: E501 line too long (81 > 79 characters)
plone/autoform/supermodel.py:50:25: Q000 Remove bad quotes.
plone/autoform/supermodel.py:50:26: S001 found %s formatter
plone/autoform/supermodel.py:60:17: Q000 Remove bad quotes.
plone/autoform/supermodel.py:61:17: S001 found % formatter
plone/autoform/supermodel.py:63:13: E128 continuation line under-indented for visual indent
plone/autoform/supermodel.py:67:1: C901 'FormSchema.read' is too complex (15)
plone/autoform/supermodel.py:102:34: Q000 Remove bad quotes.
plone/autoform/supermodel.py:102:67: S001 found %s formatter
plone/autoform/supermodel.py:119:80: E501 line too long (83 > 79 characters)
plone/autoform/supermodel.py:130:80: E501 line too long (81 > 79 characters)
plone/autoform/supermodel.py:132:29: E128 continuation line under-indented for visual indent
plone/autoform/supermodel.py:137:29: Q000 Remove bad quotes.
plone/autoform/supermodel.py:137:30: S001 found %s formatter
plone/autoform/supermodel.py:137:80: E501 line too long (89 > 79 characters)
plone/autoform/supermodel.py:139:1: C901 'FormSchema.write' is too complex (14)
plone/autoform/supermodel.py:143:80: E501 line too long (90 > 79 characters)
plone/autoform/supermodel.py:144:80: E501 line too long (95 > 79 characters)
plone/autoform/supermodel.py:145:80: E501 line too long (91 > 79 characters)
plone/autoform/supermodel.py:164:25: Q000 Remove bad quotes.
plone/autoform/supermodel.py:164:26: S001 found %s formatter
plone/autoform/supermodel.py:167:55: Q000 Remove bad quotes.
plone/autoform/supermodel.py:172:25: Q000 Remove bad quotes.
plone/autoform/supermodel.py:172:26: S001 found %s formatter
plone/autoform/supermodel.py:175:58: Q000 Remove bad quotes.
plone/autoform/supermodel.py:175:80: E501 line too long (82 > 79 characters)
plone/autoform/supermodel.py:196:80: E501 line too long (80 > 79 characters)
plone/autoform/supermodel.py:212:80: E501 line too long (91 > 79 characters)
plone/autoform/supermodel.py:213:80: E501 line too long (93 > 79 characters)
plone/autoform/supermodel.py:216:80: E501 line too long (81 > 79 characters)
plone/autoform/supermodel.py:218:80: E501 line too long (83 > 79 characters)
plone/autoform/testing.py:0:1: C101 Coding magic comment not found
plone/autoform/testing.py:0:1: I001 isort found changes, run it on the file
plone/autoform/testing.py:1:1: F401 'Layer' imported but unused
plone/autoform/testing.py:11:10: Q000 Remove bad quotes.
plone/autoform/testing.py:15:10: Q000 Remove bad quotes.
plone/autoform/utils.py:0:1: C101 Coding magic comment not found
plone/autoform/utils.py:0:1: I001 isort found changes, run it on the file
plone/autoform/utils.py:21:80: E501 line too long (84 > 79 characters)
plone/autoform/utils.py:22:80: E501 line too long (81 > 79 characters)
plone/autoform/utils.py:100:80: E501 line too long (87 > 79 characters)
plone/autoform/utils.py:118:1: C901 'processFields' is too complex (19)
plone/autoform/utils.py:118:80: E501 line too long (85 > 79 characters)
plone/autoform/utils.py:130:80: E501 line too long (88 > 79 characters)
plone/autoform/utils.py:132:80: E501 line too long (87 > 79 characters)
plone/autoform/utils.py:133:80: E501 line too long (96 > 79 characters)
plone/autoform/utils.py:134:80: E501 line too long (101 > 79 characters)
plone/autoform/utils.py:136:80: E501 line too long (98 > 79 characters)
plone/autoform/utils.py:138:80: E501 line too long (81 > 79 characters)
plone/autoform/utils.py:145:80: E501 line too long (104 > 79 characters)
plone/autoform/utils.py:146:80: E501 line too long (106 > 79 characters)
plone/autoform/utils.py:166:80: E501 line too long (98 > 79 characters)
plone/autoform/utils.py:188:80: E501 line too long (127 > 79 characters)
plone/autoform/utils.py:217:45: E127 continuation line over-indented for visual indent
plone/autoform/utils.py:218:49: E127 continuation line over-indented for visual indent
plone/autoform/utils.py:218:80: E501 line too long (88 > 79 characters)
plone/autoform/utils.py:226:80: E501 line too long (81 > 79 characters)
plone/autoform/utils.py:238:80: E501 line too long (96 > 79 characters)
plone/autoform/validators.py:0:1: C101 Coding magic comment not found
plone/autoform/validators.py:0:1: I001 isort found changes, run it on the file
plone/autoform/view.py:0:1: C101 Coding magic comment not found
plone/autoform/view.py:0:1: I001 isort found changes, run it on the file
plone/autoform/widgets.py:0:1: C101 Coding magic comment not found
plone/autoform/widgets.py:0:1: I001 isort found changes, run it on the file
plone/autoform/widgets.py:68:17: S001 found %s formatter
plone/autoform/widgets.py:80:22: Q000 Remove bad quotes.
plone/autoform/widgets.py:80:23: S001 found %s formatter
plone/autoform/widgets.py:94:30: Q000 Remove bad quotes.
plone/autoform/widgets.py:94:31: S001 found %s formatter
plone/autoform/widgets.py:116:80: E501 line too long (80 > 79 characters)
plone/autoform/widgets.py:126:80: E501 line too long (110 > 79 characters)
plone/autoform/tests/test_directives.py:0:1: C101 Coding magic comment not found
plone/autoform/tests/test_directives.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_directives.py:10:80: E501 line too long (84 > 79 characters)
plone/autoform/tests/test_directives.py:11:80: E501 line too long (81 > 79 characters)
plone/autoform/tests/test_directives.py:58:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:61:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:66:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:69:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:72:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:74:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:86:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:86:80: E501 line too long (86 > 79 characters)
plone/autoform/tests/test_directives.py:87:19: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_directives.py:106:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:125:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:160:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:163:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:166:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:169:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:174:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:174:80: E501 line too long (97 > 79 characters)
plone/autoform/tests/test_directives.py:176:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:176:80: E501 line too long (90 > 79 characters)
plone/autoform/tests/test_directives.py:208:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_directives.py:208:80: E501 line too long (88 > 79 characters)
plone/autoform/tests/test_doctests.py:0:1: C101 Coding magic comment not found
plone/autoform/tests/test_doctests.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_doctests.py:10:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_doctests.py:11:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_doctests.py:12:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_doctests.py:14:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_doctests.py:15:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_doctests.py:16:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_doctests.py:18:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_doctests.py:19:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_doctests.py:20:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_doctests.py:22:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_doctests.py:23:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_doctests.py:24:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:0:1: C101 Coding magic comment not found
plone/autoform/tests/test_supermodel_handler.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_supermodel_handler.py:14:80: E501 line too long (84 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:15:80: E501 line too long (81 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:34:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:34:54: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:34:80: E501 line too long (101 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:35:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:35:52: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:36:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:36:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:37:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:37:54: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:38:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:38:57: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:38:80: E501 line too long (104 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:46:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:46:80: E501 line too long (85 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:47:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:48:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:48:80: E501 line too long (93 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:49:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:49:80: E501 line too long (93 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:50:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:50:80: E501 line too long (96 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:51:80: E501 line too long (90 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:57:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:57:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:57:80: E501 line too long (102 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:58:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:58:53: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:59:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:59:56: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:60:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:60:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:63:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:63:53: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:64:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:64:56: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:74:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:74:80: E501 line too long (86 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:75:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:76:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:76:80: E501 line too long (88 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:78:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:78:80: E501 line too long (94 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:80:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:80:80: E501 line too long (97 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:91:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:92:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:93:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:94:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:98:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:98:53: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:98:80: E501 line too long (87 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:99:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:99:56: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:99:80: E501 line too long (88 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:102:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:102:53: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:102:80: E501 line too long (125 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:103:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:103:56: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:103:80: E501 line too long (124 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:113:80: E501 line too long (120 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:114:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:115:80: E501 line too long (116 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:116:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:116:80: E501 line too long (81 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:125:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:177:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:177:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:178:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:178:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:178:53: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:178:80: E501 line too long (80 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:179:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:179:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:179:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:180:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:180:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:180:58: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:180:80: E501 line too long (84 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:190:80: E501 line too long (108 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:197:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:197:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:198:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:198:51: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:199:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:199:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:199:56: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:199:80: E501 line too long (80 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:200:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:200:51: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:211:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:211:52: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:212:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:212:51: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:213:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:213:51: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:214:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:214:51: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:224:80: E501 line too long (118 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:226:80: E501 line too long (114 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:233:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:233:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:233:80: E501 line too long (106 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:233:82: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:234:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:234:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:234:80: E501 line too long (107 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:234:80: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:236:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:236:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:236:80: E501 line too long (99 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:237:46: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:238:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:238:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:238:80: E501 line too long (95 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:239:46: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:253:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:254:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:254:80: E501 line too long (88 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:255:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:269:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:270:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:284:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:285:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:285:80: E501 line too long (88 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:286:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:287:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:288:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:302:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:303:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:303:80: E501 line too long (89 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:304:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:313:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:313:63: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:314:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:314:64: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:322:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:322:80: E501 line too long (96 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:323:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:323:80: E501 line too long (98 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:334:14: D001 found failIf( replace it with assertFalse
plone/autoform/tests/test_supermodel_handler.py:335:14: D001 found failIf( replace it with assertFalse
plone/autoform/tests/test_supermodel_handler.py:349:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:349:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:349:59: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:349:80: E501 line too long (94 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:350:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:350:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:350:60: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:350:80: E501 line too long (96 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:363:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:363:51: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:363:80: E501 line too long (86 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:364:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:364:51: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:364:80: E501 line too long (87 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:375:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:375:51: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:375:80: E501 line too long (86 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:376:14: D001 found assertEquals replace it with assertEqual
plone/autoform/tests/test_supermodel_handler.py:376:51: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:376:80: E501 line too long (87 > 79 characters)
plone/autoform/tests/test_utils.py:0:1: C101 Coding magic comment not found
plone/autoform/tests/test_utils.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_utils.py:5:1: F401 'implementer' imported but unused
plone/autoform/tests/test_utils.py:18:23: Q000 Remove bad quotes.
plone/autoform/tests/test_widgets.py:0:1: C101 Coding magic comment not found
plone/autoform/tests/test_widgets.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_widgets.py:4:1: F401 'zope' imported but unused
plone/autoform/tests/test_widgets.py:73:1: W391 blank line at end of file
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@gaudenz Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.autoform/4//violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/autoform/base.py:0:1: C101 Coding magic comment not found
plone/autoform/base.py:0:1: I001 isort found changes, run it on the file
plone/autoform/base.py:25:1: C901 'AutoFields.updateFieldsFromSchemata' is too complex (12)
plone/autoform/base.py:42:80: E501 line too long (87 > 79 characters)
plone/autoform/base.py:43:80: E501 line too long (82 > 79 characters)
plone/autoform/base.py:103:80: E501 line too long (113 > 79 characters)
plone/autoform/directives.py:0:1: C101 Coding magic comment not found
plone/autoform/directives.py:0:1: I001 isort found changes, run it on the file
plone/autoform/directives.py:13:80: E501 line too long (81 > 79 characters)
plone/autoform/directives.py:25:80: E501 line too long (83 > 79 characters)
plone/autoform/directives.py:57:80: E501 line too long (87 > 79 characters)
plone/autoform/directives.py:71:80: E501 line too long (82 > 79 characters)
plone/autoform/directives.py:75:80: E501 line too long (85 > 79 characters)
plone/autoform/directives.py:78:80: E501 line too long (95 > 79 characters)
plone/autoform/directives.py:84:80: E501 line too long (96 > 79 characters)
plone/autoform/directives.py:87:80: E501 line too long (97 > 79 characters)
plone/autoform/directives.py:89:80: E501 line too long (93 > 79 characters)
plone/autoform/directives.py:94:80: E501 line too long (95 > 79 characters)
plone/autoform/directives.py:97:80: E501 line too long (88 > 79 characters)
plone/autoform/directives.py:98:80: E501 line too long (93 > 79 characters)
plone/autoform/directives.py:110:30: Q000 Remove bad quotes.
plone/autoform/directives.py:110:31: S001 found %s formatter
plone/autoform/directives.py:114:13: E122 continuation line missing indentation or outdented
plone/autoform/directives.py:115:13: E122 continuation line missing indentation or outdented
plone/autoform/directives.py:116:80: E501 line too long (86 > 79 characters)
plone/autoform/directives.py:132:80: E501 line too long (94 > 79 characters)
plone/autoform/directives.py:141:80: E501 line too long (93 > 79 characters)
plone/autoform/form.py:0:1: C101 Coding magic comment not found
plone/autoform/form.py:0:1: I001 isort found changes, run it on the file
plone/autoform/form.py:22:80: E501 line too long (109 > 79 characters)
plone/autoform/form.py:36:80: E501 line too long (83 > 79 characters)
plone/autoform/form.py:48:1: W391 blank line at end of file
plone/autoform/interfaces.py:0:1: C101 Coding magic comment not found
plone/autoform/interfaces.py:0:1: I001 isort found changes, run it on the file
plone/autoform/interfaces.py:12:12: E221 multiple spaces before operator
plone/autoform/interfaces.py:13:12: E221 multiple spaces before operator
plone/autoform/interfaces.py:14:10: E221 multiple spaces before operator
plone/autoform/interfaces.py:15:10: E221 multiple spaces before operator
plone/autoform/interfaces.py:17:21: E221 multiple spaces before operator
plone/autoform/interfaces.py:42:80: E501 line too long (89 > 79 characters)
plone/autoform/interfaces.py:48:80: E501 line too long (108 > 79 characters)
plone/autoform/interfaces.py:49:80: E501 line too long (99 > 79 characters)
plone/autoform/interfaces.py:50:75: E127 continuation line over-indented for visual indent
plone/autoform/interfaces.py:50:80: E501 line too long (93 > 79 characters)
plone/autoform/interfaces.py:70:39: E127 continuation line over-indented for visual indent
plone/autoform/interfaces.py:70:39: Q000 Remove bad quotes.
plone/autoform/interfaces.py:71:80: E501 line too long (91 > 79 characters)
plone/autoform/interfaces.py:72:80: E501 line too long (88 > 79 characters)
plone/autoform/interfaces.py:75:31: E128 continuation line under-indented for visual indent
plone/autoform/interfaces.py:75:80: E501 line too long (85 > 79 characters)
plone/autoform/interfaces.py:76:31: E128 continuation line under-indented for visual indent
plone/autoform/interfaces.py:76:80: E501 line too long (97 > 79 characters)
plone/autoform/supermodel.py:0:1: C101 Coding magic comment not found
plone/autoform/supermodel.py:0:1: I001 isort found changes, run it on the file
plone/autoform/supermodel.py:12:80: E501 line too long (84 > 79 characters)
plone/autoform/supermodel.py:13:80: E501 line too long (81 > 79 characters)
plone/autoform/supermodel.py:48:25: Q000 Remove bad quotes.
plone/autoform/supermodel.py:48:26: S001 found %s formatter
plone/autoform/supermodel.py:58:17: Q000 Remove bad quotes.
plone/autoform/supermodel.py:59:17: S001 found % formatter
plone/autoform/supermodel.py:61:13: E128 continuation line under-indented for visual indent
plone/autoform/supermodel.py:65:1: C901 'FormSchema.read' is too complex (11)
plone/autoform/supermodel.py:100:34: Q000 Remove bad quotes.
plone/autoform/supermodel.py:100:67: S001 found %s formatter
plone/autoform/supermodel.py:105:1: C901 'FormSchema.write' is too complex (14)
plone/autoform/supermodel.py:109:80: E501 line too long (90 > 79 characters)
plone/autoform/supermodel.py:110:80: E501 line too long (95 > 79 characters)
plone/autoform/supermodel.py:111:80: E501 line too long (91 > 79 characters)
plone/autoform/supermodel.py:130:25: Q000 Remove bad quotes.
plone/autoform/supermodel.py:130:26: S001 found %s formatter
plone/autoform/supermodel.py:133:55: Q000 Remove bad quotes.
plone/autoform/supermodel.py:138:25: Q000 Remove bad quotes.
plone/autoform/supermodel.py:138:26: S001 found %s formatter
plone/autoform/supermodel.py:141:58: Q000 Remove bad quotes.
plone/autoform/supermodel.py:141:80: E501 line too long (82 > 79 characters)
plone/autoform/supermodel.py:162:80: E501 line too long (80 > 79 characters)
plone/autoform/supermodel.py:178:80: E501 line too long (91 > 79 characters)
plone/autoform/supermodel.py:179:80: E501 line too long (93 > 79 characters)
plone/autoform/supermodel.py:182:80: E501 line too long (81 > 79 characters)
plone/autoform/supermodel.py:184:80: E501 line too long (83 > 79 characters)
plone/autoform/testing.py:0:1: C101 Coding magic comment not found
plone/autoform/testing.py:0:1: I001 isort found changes, run it on the file
plone/autoform/testing.py:1:1: F401 'Layer' imported but unused
plone/autoform/testing.py:11:10: Q000 Remove bad quotes.
plone/autoform/testing.py:15:10: Q000 Remove bad quotes.
plone/autoform/utils.py:0:1: C101 Coding magic comment not found
plone/autoform/utils.py:0:1: I001 isort found changes, run it on the file
plone/autoform/utils.py:21:80: E501 line too long (84 > 79 characters)
plone/autoform/utils.py:22:80: E501 line too long (81 > 79 characters)
plone/autoform/utils.py:100:80: E501 line too long (87 > 79 characters)
plone/autoform/utils.py:118:1: C901 'processFields' is too complex (19)
plone/autoform/utils.py:118:80: E501 line too long (85 > 79 characters)
plone/autoform/utils.py:130:80: E501 line too long (88 > 79 characters)
plone/autoform/utils.py:132:80: E501 line too long (87 > 79 characters)
plone/autoform/utils.py:133:80: E501 line too long (96 > 79 characters)
plone/autoform/utils.py:134:80: E501 line too long (101 > 79 characters)
plone/autoform/utils.py:136:80: E501 line too long (98 > 79 characters)
plone/autoform/utils.py:138:80: E501 line too long (81 > 79 characters)
plone/autoform/utils.py:145:80: E501 line too long (104 > 79 characters)
plone/autoform/utils.py:146:80: E501 line too long (106 > 79 characters)
plone/autoform/utils.py:166:80: E501 line too long (98 > 79 characters)
plone/autoform/utils.py:188:80: E501 line too long (127 > 79 characters)
plone/autoform/utils.py:217:45: E127 continuation line over-indented for visual indent
plone/autoform/utils.py:218:49: E127 continuation line over-indented for visual indent
plone/autoform/utils.py:218:80: E501 line too long (88 > 79 characters)
plone/autoform/utils.py:226:80: E501 line too long (81 > 79 characters)
plone/autoform/utils.py:238:80: E501 line too long (96 > 79 characters)
plone/autoform/view.py:0:1: C101 Coding magic comment not found
plone/autoform/view.py:0:1: I001 isort found changes, run it on the file
plone/autoform/widgets.py:0:1: C101 Coding magic comment not found
plone/autoform/widgets.py:0:1: I001 isort found changes, run it on the file
plone/autoform/widgets.py:68:17: S001 found %s formatter
plone/autoform/widgets.py:80:22: Q000 Remove bad quotes.
plone/autoform/widgets.py:80:23: S001 found %s formatter
plone/autoform/widgets.py:94:30: Q000 Remove bad quotes.
plone/autoform/widgets.py:94:31: S001 found %s formatter
plone/autoform/widgets.py:116:80: E501 line too long (80 > 79 characters)
plone/autoform/widgets.py:127:80: E501 line too long (110 > 79 characters)
plone/autoform/tests/test_directives.py:0:1: C101 Coding magic comment not found
plone/autoform/tests/test_directives.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_directives.py:9:80: E501 line too long (84 > 79 characters)
plone/autoform/tests/test_directives.py:10:80: E501 line too long (81 > 79 characters)
plone/autoform/tests/test_directives.py:45:28: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:46:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:48:28: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:51:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:53:28: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:54:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:56:28: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:57:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:59:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:61:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:72:80: E501 line too long (85 > 79 characters)
plone/autoform/tests/test_directives.py:73:19: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_directives.py:147:28: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:148:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:150:28: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:151:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:153:28: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:154:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:156:28: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:159:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:160:80: E501 line too long (96 > 79 characters)
plone/autoform/tests/test_directives.py:161:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:162:80: E501 line too long (89 > 79 characters)
plone/autoform/tests/test_directives.py:163:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_directives.py:194:80: E501 line too long (87 > 79 characters)
plone/autoform/tests/test_doctests.py:0:1: C101 Coding magic comment not found
plone/autoform/tests/test_doctests.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_doctests.py:12:17: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_doctests.py:16:17: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_doctests.py:20:17: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_doctests.py:24:17: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:0:1: C101 Coding magic comment not found
plone/autoform/tests/test_supermodel_handler.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_supermodel_handler.py:14:80: E501 line too long (84 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:15:80: E501 line too long (81 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:34:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:34:54: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:34:80: E501 line too long (101 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:35:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:35:52: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:36:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:36:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:37:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:37:54: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:38:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:38:57: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:38:80: E501 line too long (104 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:46:80: E501 line too long (84 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:47:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:48:80: E501 line too long (92 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:49:80: E501 line too long (92 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:50:80: E501 line too long (95 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:51:80: E501 line too long (90 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:57:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:57:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:57:80: E501 line too long (102 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:58:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:58:53: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:59:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:59:56: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:60:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:60:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:63:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:63:53: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:64:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:64:56: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:74:80: E501 line too long (85 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:75:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:76:80: E501 line too long (87 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:77:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:78:80: E501 line too long (93 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:79:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:80:80: E501 line too long (96 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:98:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:98:53: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:98:80: E501 line too long (87 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:99:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:99:56: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:99:80: E501 line too long (88 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:102:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:102:53: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:102:80: E501 line too long (125 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:103:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:103:56: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:103:80: E501 line too long (124 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:113:80: E501 line too long (120 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:115:80: E501 line too long (116 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:116:80: E501 line too long (80 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:125:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:177:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:178:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:178:52: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:179:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:179:54: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:180:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:180:57: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:180:80: E501 line too long (83 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:190:80: E501 line too long (108 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:197:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:198:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:199:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:199:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:200:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:211:51: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:212:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:213:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:214:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:224:80: E501 line too long (118 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:226:80: E501 line too long (114 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:233:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:233:80: E501 line too long (105 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:233:81: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:234:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:234:79: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:234:80: E501 line too long (106 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:236:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:236:80: E501 line too long (98 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:237:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:237:46: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:238:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:238:80: E501 line too long (94 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:239:27: E127 continuation line over-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:239:46: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:254:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:254:80: E501 line too long (88 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:255:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:270:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:285:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:285:80: E501 line too long (88 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:286:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:287:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:288:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:303:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:303:80: E501 line too long (89 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:304:13: E128 continuation line under-indented for visual indent
plone/autoform/tests/test_supermodel_handler.py:313:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:313:63: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:314:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:314:64: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:322:80: E501 line too long (95 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:323:80: E501 line too long (97 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:349:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:349:58: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:349:80: E501 line too long (93 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:350:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:350:59: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:350:80: E501 line too long (95 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:363:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:363:80: E501 line too long (85 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:364:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:364:80: E501 line too long (86 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:375:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:375:80: E501 line too long (85 > 79 characters)
plone/autoform/tests/test_supermodel_handler.py:376:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:376:80: E501 line too long (86 > 79 characters)
plone/autoform/tests/test_utils.py:0:1: C101 Coding magic comment not found
plone/autoform/tests/test_utils.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_utils.py:18:23: Q000 Remove bad quotes.
plone/autoform/tests/test_widgets.py:0:1: C101 Coding magic comment not found
plone/autoform/tests/test_widgets.py:0:1: I001 isort found changes, run it on the file
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Add:

, and there are multiple version of libcrypto and libssl available on the system. Typically, it will happen if Mumble or Murmur are linked against an older version, and a newer version is available on the system.


We never pass NULL as the first parameter and setting lang to -1 would cause the function does nothing so it doesn't make much sense to keep this.


Does the C++11 clock in all cases map to what the previous code did? Do we know the C++11 clock is efficient and low overhead?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16562](https://teamcity.mesosphere.io/viewLog.html?buildId=140750&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:06:31


I noticed this declaration which doesn't have any implementation so I removed it on the way.


The only issue i have found from conversion is the player spawns. It has grouped them all in sets of 4, but all the groups are labelled alpha 1, instead of Bravo 1, Bravo 2, Charlie, 4 etc etc. There is thousands of RPT spam entries that for example Bravo 3-2 has no leader.and anyone that tries to use a slot in the lobby that isnt a group leader slot just hangs at the loading screen. I will attach screenshots of the difference between the old and new spawn slots both visually and the code if it interests you.  Would just need to work out how to place down new spawn points in a way that will work with the wasteland engine and its all good.

[http://www.nobullshitrevolution.com/downloads/oldedit.png](url)
[http://www.nobullshitrevolution.com/downloads/newedit.png](url)
[http://www.nobullshitrevolution.com/downloads/oldspawn.jpg](url)
[http://www.nobullshitrevolution.com/downloads/newspawn.jpg](url)
[http://www.nobullshitrevolution.com/downloads/newspawn2.jpg](url)
[http://www.nobullshitrevolution.com/downloads/newspawn3.jpg](url)
[http://www.nobullshitrevolution.com/downloads/newspawn4.jpg](url)
[http://www.nobullshitrevolution.com/downloads/newspawn5.jpg](url)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16565](https://teamcity.mesosphere.io/viewLog.html?buildId=140754&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:03:47


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16564](https://teamcity.mesosphere.io/viewLog.html?buildId=140753&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:01


Sure, will look into this. I reverted this assertion at 3921517d36c51fc9165577ce2fa5bb34fe4540ef


Thank you!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16563](https://teamcity.mesosphere.io/viewLog.html?buildId=140751&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:09:32


Hi Ted,

This was not meant to be merged. I only created the PR for testing. No big deal either way (the patch was already in the tree so it was just an empty merge).

In general if you see a PR from me, don't merge it :)


I have already fixed the placement of all spawnpoints, took me a whole 5 minutes.


This is one of those commits to check before doing to not do.


Are you pull with merge instead of pull with rebase?
Please check your git client settings.


restore a prior deletion of this commit


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16566](https://teamcity.mesosphere.io/viewLog.html?buildId=140755&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:07:54


This is not a "rebase", not sure why you are using that as commit comment.


please call the block `additional_css`


daha rahat okunup dikkat çekmesi için


please add newline at end of file


Oh! I too implemented it [here](https://github.com/nishnik/symengine/commit/cb511ddc66e5f4bf1bee860204164f5020aaf610).
But now, since this one's better, I should wait for this one to get merged.
This one looks fine to me.
@isuruf till then could you please review this [PR](https://github.com/symengine/symengine/pull/818).


daha kolay çalışması için kullanıcı kodları kopyalayıp kendi programına yapıştırıp tasarımını yaptıktan sonra çalıştırabilir. Ama böyle dediğim şekilde daha kolay ve kısa bi yoldan çalıştırabilirler kodları


This is a bad patch - it touches things all over the place, and will make it harder to cherry pick patches from mainline.

The L2 stuff should be one patch.
The crypto bits should be one patch.
The entry.S change changes the spacing improperly.
The uart stuff should be its own patch.


It's clear to me that there isn't a solution that's going to please everyone. I've been using `request.db` myself for years but recognize that it doesn't seem to resonate with most people - including mike bayer - which is why it was named `request.dbsession` which he was alright with. Similarly the old tutorial/scaffold used the global `DBSession`. Finally it has the word session in the name, indicating more clearly what it is than `request.sa` or `request.sql`. I'm going to just leave it as-is.


the indentation seems not to be correct here


awesome fix!


Ok,  I'll work them all up separate


Great work with this :+1:


My idea here was to allow the user the option to install (and configure by editing the template as desired). How would this change work?

I assume the config would look something like
```
plugins:
    - nginx

sd_checks:
  - nginx:
      init_config:
      instances:
        - nginx_status_url: http://localhost/nginx_status/
```


Im on


As of https://github.com/rbarman/SoundShare/commit/5506b475af3910463d3074be127ebcc4cc69dac4 on 1/20, the functionality of this commit is obsolete. Unique song checking will have to rewritten in the new redux environment


I still nee to rephrase this. I guess "If you are not using the default exchange fr any other purpose" would be much better


A duplicate of line 55.
In emonbase, the font size is quite large, causing log entries to wrap into 2 lines, and looks out of style with the rest of the Administration page.
Could you consider 14px? it's still readable, and IMO more aesthetic.
The auto-refresh 'on-off' is a welcome addition :+1:


why is the span invalid here? what about the panels in all the other templates?


@cra0zy thanks :)

> Lets just say 2 maintainers have to agree that the PR should get merged.

Sounds like a good idea.  Hopefully there won't be a sitch where 2 of us are out of touch for a long time, but all three of us seem really involved right now, so I don't think that will be a problem


Project tek cift sayi > Tek cift > Form1.cs nin içinde 26. satırda


Bence bu pek önemli değil oraya asdqwe ' de yazsam o şekilde tanımlayacak


Please use single quotes in all strings in JS code


Typo, varnishstat


erreur a del


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.recipe.codeanalysis/9//violations
```
plone/recipe/codeanalysis/__init__.py:172:13: T001 print function found.
plone/recipe/codeanalysis/__init__.py:187:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:196:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:244:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:59:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:66:13: T001 print function found.
plone/recipe/codeanalysis/tests/test_csslint.py:24:0: P103 other string does contain unindexed parameters
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


there is no need to check '=== true' here, just write (if $('#register-form').valid()) {


remove space before semicolon


I'm guessing this lightning fast problem solve is in some way related to you being the guy that wrote the mod he he :) Could you link me in on the solution so i may revel in your awesomeness please?


You should run gofmt over all this code so that the style is consistent


@ezyang I agree.  I suggested reverting it here: https://github.com/haskell/cabal/pull/3153#issuecomment-184541185


What I didn't understand when reviewing the Makefile was why you had introduced `make bin` as a duplicate of the pre-existing equivalent function `make binary` in the first place in https://github.com/cleanflight/cleanflight/commit/2354d004d68cb94ba8c1db4b4fe570dc67a8e94d back in December 2015?

When you added the `make all` command, there wasn't a need to create a new 'bin' target and plumb it through, as 'binary' already existed.  Your commit message didn't make it clear why. I'm just trying to clean this all up.

A more aggressive commit would have been to remove the duplicate you added, but I'm now not sure if other external scripts have started using this extraneous feature. Hence why I hid one for now, ahead of deprecation.

Unless I'm missing something?


blah blah blah


if you are logging an error, use console.error() instead of log()


Just done that.


please remove the comment out lines if we should include


I thought about it more, we should keep them

On February 20, 2016 4:06:00 PM CST, Jonathan Chen <notifications@github.com> wrote:
>Any opinions on if we should keep the comments?
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/nyc-copperheads-2016/menu/commit/0bc02b5bf3fc9e7b7eac23fc80a00e22ee8aa7ea#commitcomment-16223633


To be honest.. In all my years of using Ansible, I have NOT used galaxy.  This looks correct after reading the documentation.

We add the travis integration after.


```
platform: steam_online
  accounts:
    - 76561198096271642
    - 76561198073748544
```


forget about two equals in JS, always use three


do whileloop in cSharp

using System;

namespace IntroductionToCsharp
{
    class Program
    {
        static void Main(string[] args)
        {
            string UserChoice = string.Empty;
            do
            {
                Console.WriteLine("Please enter your target?");
                int userTarget = int.Parse(Console.ReadLine());

                int Start = 0;

                while (Start <= userTarget)
                {
                    Console.Write(Start + " ");
                    Start = Start + 2;
                }

                do
                {
                    Console.WriteLine("Do you want to continue - Yes or No");

                    UserChoice = Console.ReadLine().ToUpper();
                    if (UserChoice != "YES" && UserChoice != "NO")
                    {
                        Console.WriteLine("Invalid Choice, Please say Yes or No");
                    }
                } while (UserChoice != "YES" && UserChoice != "NO");
                } while (UserChoice == "YES");

         }

     }
}


how about using the `ul` only when entries exist?


Please log something in case of exception (it's unexpected to happen, right?). Logging usually includes some information that would help to debug issues: variable values, stack traces,...


There is a button in the toolbar, "Toggle Translation Grid", it looks like a Rubik's Cube.
<br/>

![Eden unit placement](http://i.imgur.com/FqQt4PK.jpg)


Please fix


Link for the latest version please!


Something for #43 now eye of the storm can be achieved by crafting strom shots with creeper glands and then shooting creepers to get them charge and have a chance for the eye.


$('#success').html('Agency has been edited successfully').show();


Don't start a variable name with a CaptialCase:

http://www.oracle.com/technetwork/java/codeconventions-135099.html


Confirmed it is stable once again. Maybe intelliactive was the actual culprit? All good now, thanks :)


Seeing as this going to be a galaxy role, I understand why you made the changes.

:+1:


Comentario de prueba ?
es un chiste ?


Please fix the yaml syntax


In a multi-language SOA architecture the common standard format for the key names could make the life much easier in those enviornments. You would know that your standard implementation in Go/Python/Java/whatever will talk with any other seamlessly if you agree on serialization/deserialization format. Otherwise you'd have one more thing to agree on - the key naming scheme.
Makes any sense?


Dorina Gjoni


Another thing for #43 Tome of alkahest is now on hard recipe by default (provided people don't already have the setting in config file), also nether stars are now more expensive


@SubJunk thanks!


Even though some logging is better than nothing, I guess the application is unusable if this happens. Should this exception trigger showing some info to the user and then cause an app to exit?


And the last one for #43


i was assuming the url was in other format.. now it's fixed in 2.0.2 and `jsreport-electron-pdf`@1.2.2


Should remove "--" to allow for tab completions

alias cpv="rsync -poghb --backup-dir=/tmp/rsync -e /dev/null --progress"


No problem, all the assets there are just some CC0 stuff downloaded from the Internet


Ah you seem to have committed the patch file itself.... github wants you to push the tree with the patch applied and it will work out what commits you added.


veji nais


Never mind I can extract it from this.


That's better.


@sraue: this patch has to be reverted, the second part doesn't replace a patch, instead it tries to change a not existing patch, sorry. will send a new version after this is removed.


Need to ask you guys whether I'm supposed to save the IdeaCollaborator, and also add the user and idea (lines 81 and 82) at this point.


So this means, that if we had a package named `true`, we can't express `--allow-newer=true` in the config file? Since when is `allow-newer: True` supported/allowed in `cabal.config` files? (fwiw, I'd rather use `allow-newer: *` rather than stealing the `True` package name...)


Forgot to remove this comment from the file, but anyway is this supposed to be unique?


`:with`?


"out" → our?


A variable with such a name is even worse than an inlined constant "- 17": it clarifies nothing.

Imagine someone reading this line. How would that help a reader to answer the following questions:
- end of what string?
- what is this string used for?
- why is it useless?

Now imagine someone reading the "String address = str.substring(str.length() + LENGTH_OF_UNUSEFULL_END_OF_STRING);" line. Here you lost the actual value "- 17" (so that now they have to scroll up to see what the constant is equal for) without providing anything back. It was already clear enough that if you remove last 17 characters, they were not quite useful for the current application. But why? What did they contain and what are you trying to achieve?


> So this means, that if we had a package named true, we can't express --allow-newer=true in the config file?

Yep. But `foo, True, False` should work. BTW, `--allow-newer=True` in 1.22 works this way even on command line, and no one complained yet :-)


It's an interface. It probably should be a duplicate of the interface in kv, but I changed this quickly because we have a different project internally that uses the same interface and it made sense, at the time, to put it in the same place. I will likely change this back to an internal sessionmw interface in the future. Since its an interface, it doesn't matter where its declared.


@alanwillms agradeço novamente pela contribuição. Essa lista está sendo usada para geolocation em [nossos sites de vestibular](https://vestibular.mauriciodenassau.edu.br/).


Nice idea rat ;8]


I'd like to release it within month.


Sorry @threads. That was a very unfortunate side effect of uploading a repo with your tag in the comments. I have cleaned it out of this instance of the repo.

Thank you for your feedback and patience!


If I'm not mistaken, this fixes compatibility with Polymake 3.0, but breaks compatibility with Polymake 2.14. I think it would be helpful to people, if the minimum required Version of Polymake 3.0 would be stated in the README.md or http://solros.de/polymake/poly_db.


if movie.user_id == current_user.id　に適応されない場合は？


> But `allow-newer: foo, True, False` should work.

And note that `foo` doesn't have to be an actually existing package.


いいね！ こういう細かいとこ結構大事になってくるから、気付いたら付け足してあげよう


For and foreach Loop in Csharp

using System;

namespace IntroductionToCsharp
{
    class Program
    {
        static void Main(string[] args)
        {
            int[] Numbers = new int[3];

            Numbers[0] = 101;
            Numbers[1] = 102;
            Numbers[2] =  103;

            foreach (int k in Numbers)
            {
                Console.WriteLine(k);

            }

            for (int j = 0; j < Numbers.Length; j++)
            {
               Console.WriteLine(Numbers[j]);
            }

            int i = 0;
            while(i < Numbers.Length)
            {
                Console.WriteLine(Numbers[i]);
                i++;
            }
        }

     }
}


``````
echo attr($row['id'])


attr() xla()
``````
<i class="pull-right fa fa-close" onclick="delete_me('<?php echo attr($row['id']); ?>');" title="<?php echo xla('Remove this Prescription from the list of RXs dispensed'); ?>"></i>


сделал задание 1.5


このコミットは別であるべきやね。
コミット名: movie削除機能の実装
  中身: ・コントローラーにdestoryメソッド実装
　　　・thumbnailのモデルに親要素(=movie)の削除に伴う処理を実装

までは分かるけど、
　　　・ユーザー名にユーザーページのリンクを貼る
って言うのはまた別の処理だと思うから、
あくまでコミットは一つのまとまりにしてあげて。


Note the above attr(addslashes()) is a relatively infrequent issue when nesting php variable within a javascript literal that is nested within html code:
See Step 4 (last exception there):
http://www.open-emr.org/wiki/index.php/Codebase_Security#Plan


Awesome dude thanks very much! Does it matter that every set of 4 units has the same callsign Alpha 1-1, do they need to be assigned Alpha 1-2 Alpha 1-3 Bravo 1-2 etc?


さっきの部分テンプレートの変更とかこっちのコミットに入れるべきかな


OD{{right eye}}


OS{{left eye}}


ONGOING REVIEW PLACEHOLDER


Great rework!


before_actionで定義してるよね？
やってんのmovieだっけか？
もし2回以上必要な処理なら、これもbefore_actionにしてあげて


How do you know these are more reasonable values?
What testing was done with these?  JUnits or on the robot?
Some Sequentials were added and removed, how do we know they are accurate?


using System;

namespace IntroductionToCsharp
{
    class Program
    {
        static void Main(string[] args)
        {
            for (int i = 0; i <= 20; i = i++)
            {

                if (i % 2 == 1)
                    continue;

                Console.WriteLine(i);

            }
        }

     }
}


Closes #5


Direct change


wow that's real easy


For reference, here are the flags to use for `Bits2`:

```
typedef enum
{
    // Apply additive translucency
    MF2_TRANSLUCENT               = 0x00000001,
    // Apply additive translucency on red only
    MF2_TRANSLUCENT_REDONLY       = 0x00000002,
    // Apply additive translucency on green only
    MF2_TRANSLUCENT_GREENONLY     = 0x00000004,
    // Apply additive translucency on blue only
    MF2_TRANSLUCENT_BLUEONLY      = 0x00000008,
    // Apply 33% alpha translucency
    MF2_TRANSLUCENT_33            = 0x00000010,
    // Apply 50% alpha translucency
    MF2_TRANSLUCENT_50            = 0x00000020,
    // Apply additive translucency on all red to white
    MF2_TRANSLUCENT_REDWHITEONLY  = 0x00000040,
    // Convert all red to green, then apply 33% alpha translucency
    MF2_TRANSLUCENT_REDTOGREEN_33 = 0x00000080,
    // Convert all red to blue, then apply 33% alpha translucency
    MF2_TRANSLUCENT_REDTOBLUE_33  = 0x00000100,
    // Apply 33% alpha translucency on all blue
    MF2_TRANSLUCENT_BLUE_33       = 0x00000200,

    // Convert all red to green
    MF2_REDTOGREEN                = 0x00000400,
    // Convert all green to red
    MF2_GREENTORED                = 0x00000800,
    // Convert all red to blue
    MF2_REDTOBLUE                 = 0x00001000,

    // Object bobs up and down
    MF2_FLOATBOB                  = 0x00002000,

    // Mirrored horizontally
    MF2_MIRRORED                  = 0x00004000,

    MF2_FALLING                   = 0x00008000,

    // Object is resting on top of another object
    MF2_ONMOBJ                    = 0x00010000,

    // Object is allowed to pass over/under other objects
    MF2_PASSMOBJ                  = 0x00020000,

    // Object is a corpse and being resurrected
    MF2_RESURRECTING              = 0x00040000,

    // Object's feet won't be clipped in liquid
    MF2_NOFOOTCLIP                = 0x00080000,

    // Object won't bob in liquid
    MF2_NOLIQUIDBOB               = 0x00100000,

    // Object's feet are now being clipped
    // (when applied to object's shadow, shadow isn't drawn)
    MF2_FEETARECLIPPED            = 0x00200000,

    // Object has a shadow
    MF2_SHADOW                    = 0x00400000,

    // Object is blood
    MF2_BLOOD                     = 0x00800000,

    // Object's thing triangle is not displayed in automap
    MF2_DONOTMAP                  = 0x01000000,

    // Object has smoke trail
    MF2_SMOKETRAIL                = 0x02000000,

    // Object can be crushed into blood splats by moving sectors
    MF2_CRUSHABLE                 = 0x04000000
} mobjflag2_t;
```


why not
onView(withText("Richmond Hill,Canada")).check(matches(isDisplayed()));


No need, i know how :D


@K-Guan 你把这个换行符改回去?之后传成release的附件就好https://github.com/racaljk/hosts/releases


@absoutherland Hey. Did you see this? https://github.com/KSP-SpaceDock/SpaceDock/pull/74

I'm not too familiar with Docker, but I assume the point of Vagrantfile is that you have mac or windows and want port forwarding to work properly. Maybe you could explain the separate redis and postgres images though. Seems like it'd be easier to use docker-compose and just pull in the images, right?

I'm excited to get this working. Let me know your thoughts on what I've got going on with the PR above.


113360729_HumidifierOASys (Nigusse) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Do you want `simple-form-path` instead? In addition to avoiding the filesystem (except at well-defined times), there's the problem of too-early expansion of symlinks. DrRacket when thru a phase experimenting with `normalize-path` and now it tries to avoid that function as much as possible so that names look sane to the user for as long as possible.


113360729_HumidifierOASys (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16520](https://teamcity.mesosphere.io/viewLog.html?buildId=140563&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:16


EconomizerIntegrationNew (mjwitte) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hi,

I am looking for code/ideas for calculating the volume of the intersection of two tetrahedron.

Is there a way to do this, any papers, books, details? Where can I find code for tetrahedrons intersection?

Could you give me some help? Any help will be appreciated.

Send replies to xihuaxu@126.com

Thanks,
Xihua


EconomizerIntegrationNew (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Apparently I can annotate just the outermost Cofree and it works. But, if I remove that one annotation … 20 compilation errors.


Excellent!


Unable to change network mode


SZVAV-Fan-Control (rraustad) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


why


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16521](https://teamcity.mesosphere.io/viewLog.html?buildId=140576&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 226 Build time: 00:08:09


SZVAV-Fan-Control (rraustad) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


You should describe this in help :smiley:


s/systemctl/networkctl/ in the commit msg


Should be `device_type ("auto")`.


@asterite what do you think about this? this make mapping load faster by 40% in load_file bench. But looks little hacky and maybe not safe.


NEWS?


Your dogged insistence on constructing a new string because of "side effects" you mentioned in your pre-change commentary (now hidden here) made me try this:
```ruby
→ irb
2.1.7 :001 > my_filename = "mydir/myfile"
 => "mydir/myfile"
2.1.7 :002 > my_prefix = "myprefix-"
 => "myprefix-"
2.1.7 :003 > def append_prefix_to_filename(file_name, prefix='')
2.1.7 :004?>   insert_index =  file_name.rindex(File::SEPARATOR)
2.1.7 :005?>   file_name.insert((insert_index.nil? ? 0 : insert_index+1) , prefix)
2.1.7 :006?>   end
 => :append_prefix_to_filename
2.1.7 :007 > append_prefix_to_filename(my_filename, my_prefix)
 => "mydir/myprefix-myfile"
2.1.7 :008 > my_filename
 => "mydir/myprefix-myfile"
2.1.7 :009 >
```
I am genuinely horrified that the conventional expectation of "pass by value" has been broken here: it's obvious, as you were correctly pointing out, that ruby is interning the parameter string and passing it "by value," yes, but *by value of the reference* because the string is boxed, not primitive. This is absurd, and having to accommodate this type of absurdity is a reminder of what drove me into the arms of functional programming some years back. Great Caesar's Ghost, Matz, what _have_ you done?


empd (nmerket) - i386-Windows-7-VisualStudio-12: OK (2096 of 2100 tests passed, 546 test warnings)

 * 550 tests had: AUD diffs.
 * 4 tests had: EIO diffs.
 * 4 tests had: ESO big diffs.
 * 3 tests had: RDD diffs.
 * 4 tests had: Table big diffs.
 * 3 tests had: MTR big diffs.
 * 1 test had: SSZ big diffs.
 * 1 test had: ZSZ big diffs.
 * 2 tests had: Table small diffs.
 * 2 tests had: ZSZ small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.81%25-yellow.svg)


Yep. If you play around with it, you can get the contrast and colours that you want.


Oh I accidentally didn't make it caps


We do not need any setters in this class since it is only changable when server stopped.


You can do the same in the display menu of stock ROM, but since it was removed in lollipop and above, this is really handy.


Hi Ferran,
Thaks for indicating solution. I am very new in this field and new to dolibarr. I just installed dolibarr 3.8.3, verything fine so far except product image. I have to possiblity to add product image. I changes the code lines you shown in htdocs/core/lib/functions.lib.php, but nothing changed after it. What reason could it be? Need your advice. Thanks!
Michael
#


<grammar-nazi-hat>"Fewer than"?</grammar-nazi-hat>


Electric-Service-Refactor (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (988 of 988 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-28.7%25-green.svg)


@benlangmuir , please review


ok


test-lldp still includes lldp-tlv.h.


FML, these change every week, don't they?


@windy1 Is this meant to replace the existing translation stuff?
x https://github.com/SpongePowered/SpongeCommon/issues/421


Because of this route implementation method, my part will be as easy as an html link. Thanks.


does this mean we can't run on Android 4.4 or less? because that's like half the devices out there. http://developer.android.com/about/dashboards/index.html


Recursive expression?


Fixed issue #12


This is not a consensus failure, but should be an assert.


コメントaa


`networkctl status` on a system without systemd-networkd running simply exits without any message (but with error code). I think it should always print something.


Perhaps next time you could put more information on why you are removing so much code. It took me a while to figure out just based on what I see here.


Credits to BrinkiePie for showing this improvement.


Doesn't seem like the most efficient way to do this, but it works. I'm not complaining.


There's no reason to delete this, I can show you things about "mark up" (a type of code(ish) that helps with documentation) which this can use.


Also (on the same system):
```
./networkctl lldp
LINK             CHASSIS ID        SYSTEM NAME      CAPS        PORT ID           PORT DESCRIPTION

Capability Flags:
o - Other; p - Repeater;  b - Bridge; w - WLAN Access Point; r - Router;
t - Telephone; d - DOCSIS cable device; a - Station; c - Customer VLAN;
s - Service VLAN, m - Two-port MAC Relay (TPMR)

10 neighbors listed.
```
^^^^^^^^^^^^^^^^^^ this part looks wrong


Similar to Forge's `@SideOnly`/`Side`?
It does, somewhat, make sense to do that rather than `@Client`


Flip tree and chart


amazing


Fixed bugs? How about commented out the entire code and added 2 characters to fix typos


What are your plans with mod support?


still need another method of spanish deck


Hi, Greg, thanks for the comment. Not sure if I suppose to do this, but I have a new branch and pull request.  Let me know what you think. Thanks.


No, you made it a string literal :rage:


LGTM!


what is At?


Hi Sylvia, You don't actually have to close the pull request and open a new one. Next time, just make changes to your branch and push them up, The pull request will automatically update.

> On Feb 19, 2016, at 9:36 PM, Sylvia Ma <notifications@github.com> wrote:
>
> Hi, Greg, thanks for the comment. Not sure if I suppose to do this, but I have a new branch and pull request. Let me know what you think. Thanks.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/nss-evening-cohort-3/static-web-javascript-quiz-sylviama0827/commit/f08818cc7fa32210cdb08cff15e1c8e9363d1644#commitcomment-16218653>.
>


わからないけど `@parse_object['app']` か `@parse_object['appliUser']` のどっちかが nil になってるとかかな？


Why is this needed?


You're right.


Thank you.


ggg


This commit did not include the java files, only an updated .gitignore as the instructions mentioned


This commit actually included the java files.


up goes a site.


Remove


hello, now im getting this:

Expected: 1649c2768d66c0e0c45345a05f43e095852bc26a2c54bc0df7ef6b08d023bdc1
Actual: 25ee6ca3c5f83ab2e38dc69e42c77fb2d47c0fca99c8537d17c03cdc2defbe4d


Can you really call a function like this? These are decks not games. If we do this, I think we need a game object to work with.


@kashike Yes, once this is complete I intend to integrate it with templates.


哦直接revert这个commit然后再重新写链接更方便<del>（更没有黑历史） </del>


Try to test it without changes in define MAX_SAMPLING_DOWN_FACTOR and define MICRO_FREQUENCY_MIN_SAMPLE_RATE. Ps: This change is still stable for me , uptime=10 day, no SODs.


It requires that the variables have been set up first, which is why I put it here after the variable block.


I don't see a reason why not, but it will be a future update.


Just leaving them as-is, heh


Atualizando de volta para o repositório local.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16522](https://teamcity.mesosphere.io/viewLog.html?buildId=140602&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:10:00


right now I am trying to move this function into cortexbrain. I'll let you know how it goes.


I have ported it to neovim.
It is nice feature!
https://github.com/neovim/neovim/pull/4302


Why not use `file-name-as-directory` here?


aa


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16523](https://teamcity.mesosphere.io/viewLog.html?buildId=140613&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:50


Tablet needs link volume.
Reasons: 1. Ring volume is always linked to system volume(which is the volume of touch sound, lockscreen unlock sound etc).
2. On stock android, notification volume is linked to ring volume, hence controlling the system volume.
3. On cm, without the option of link volume, there is no way to control system volume, and the system volume is always in maximum, which could cause some inconvenience.
Therefore, please enable the link volume again, thank you.


I'm not sure, the code seems to explicitly say `ipcMain` would replace this.

https://github.com/atom/electron/blob/3875b30fcf2065cebc4e914ee5274084875e425b/atom/browser/api/lib/ipc.js#L5

```javascript
const deprecate = require('electron').deprecate;
const ipcMain = require('electron').ipcMain;

// This module is deprecated, we mirror everything from ipcMain.
deprecate.warn('ipc module', 'require("electron").ipcMain');

module.exports = ipcMain;
```

I took a look for `ipcRenderer.on` to see if it would be used in this context:
https://github.com/atom/electron/blob/95d8716ffa7713f7e5a05b3e9fd2cc1d9af759e2/docs/api/ipc-renderer.md


測試2


+1 :)


Commented on #3. Definitely open to discussion, but personally I think it'd be easier to maintain this if it were merged into Swift master. Once that happens we can make small pull requests to bring this down to NDK 16.


@rambo

Hi Eero,

I have pushed significant changes into a branch called "interrupt_driven" that I would like you to review. The onRequest() callback function is interrupt driven as of the merge before last, but this change makes the onReceive() callback function also interrupt driven. I've tested it for days using Uno R3, Mega 2560, Micro Pro (Leonardo) as the master device and a Tiny85 as the slave device. The new TinyWiresS_Stress_Master/_Slave example programs run reliably with zero communication errors. Please read the description of the last commit in the branch because I put more info in there -- especially the part about deprecating the TinyWireS_stop_check() and tws_delay() functions.

I think that the other existing examples should just work, but I have don't have the master program that is meant to accompany them. I can alter the TinyWiresS_Stress_Master for that purpose, but I thought that you might have the original master program used to test these examples.

Please consider whether you even want to merge these changes into the master branch. My opinion is that legacy code built on the current TinyWireS library version [the non-interrupt driven onReceive() callback function] will work with this library interrupt-driven version because an empty version of TinyWireS_stop_check() is still in the library, but I can't say for sure without know how other people have used the library.

Your review and feedback will be appreciated.

--Scott (rshartog)


Use better commit names please.


actually, why not as well use [`_state`](https://github.com/goldfire/howler.js/commit/37197a7adf5960eed788bad0b5806d8ab3edbd95) to track the "loading" status in HTML5 "mode" ? this way you do not need to check for `readyState` everytime, and can just rely on that boolean flag ?


This looks good. I would have have changed the {deckType} to sometime different so that it's not the same as the method call.


In line 10 of the AcesUp file, you shouldn't put all of your css in the html file itself.


Added the the correct values to colors.


In the application controller, you have to change it from 'Game g = new Game()' to 'Game g = new EngGame()' or 'SpanGame()' for this to even compile.  Then you also have to alter the spanish deck construction from 'buildDeckSpanish()' to 'buildDeck()' for it to show the proper cards.

Nonetheless you got the inheritance working mostly correctly, so good work implementing that.


This should indeed default to `Locale.US`, as done throughout the API - this is the default Minecraft language.


Nopes, it wont work. It says `if Twitterbot, Disallow: everything`


Glad to hear this is reproducible.

I did remove reset from the clock wizard, but the external reset for the Processor System Reset IP (PSR) is not defeatable.  When I connect the low reset to the PSR, it locks the microblaze (ERROR: MicroBlaze is under RESET. Check if the Reset input to MicroBlaze and its Bus Interfaces are connected properly
        UNABLE to STOP MicroBlaze)

My only work-around was to connect PSR external reset to a IP constant = 1.

Is there a better way?


Duplicated code should be placed in a method.
Lines: 137,153,169, 185
Lines: 140,156, 172, 188


file no longer needed.