Maybe, but this is a prety long function, and I'm not sure this function need optimization.


`/^qx\.ui/` I guess ?


will look into it


Fine, then :) Sorry for the noise.


Dependence on `shiny` package should go into `Imports` of the `DESCRIPTION` file.


Szerintem az ftp-ről is dobható az inputattach csomag, akkor a replaces sem kell.


Since people_thomas.php is no longer linked from anywhere, I've removed it from the repo and the server. The file is still available in the GitHub history if you need it:

https://github.com/GriffinLab/website/blob/f5ea8eb3969348d3980d5c54b1308466bfc23ed1/people_thomas.php

Let me know if you want it back up.


Why are you eliminating this check?  If there is text but no barline, shouldn't the text be exactly centered?  Without this check the algorithm will try to shift the text to keep it within the offset limits of the hypothetical bar line.


I found that changing the `user_agent` to Mac Safari removed the captcha. They likely have a simple throttling heuristic based on the user agent that could be worked around just by choosing a random one for each client.  However, it wouldn't be hard to improve this commit to extract the captcha image and await user input to put the value in the text field. Both things should likely be done. Thoughts?


Hmm, I wouldn't understand this message, but let's wait for @clebergnu as I'm terrible at English. How about `Impossible to override test urls together with --replay-test-status`, or similar?


could use `lderr(cct)` in this case. and would be better to add a space before `dendl`.


I was thinking, we could show a warning in that case. Most incorrect UFOs I've seen just have inverted sign and in this case silently putting zero is not good. Are there actual fonts who use 0 as ascent or descent anyway?


в будущем эту функцию можно будет переписать, не оптимально немного работает


Ok. I'll tidy up ping handler and I'll leave build-info for you. Coz they were only stubs for future work and outside the scope of the task I worked on.


And wont it significly increase the startup time? since it will need to refresh every show..


I think you're right, but I'm not entirely sure xytext is/was ever supported?  Sorry, my notes here are incomplete/missing.  In any case, why not check both?


Or just use `providing` or `supplying`, instead of `informing`. But as I said, maybe it's just my Czenglish...


Maybe I just don't understand the algorithm completely, but if the goal is to make the spaces larger, why are we increasing the shifts?  Shouldn't it be `\gre@dimen@text@allocation` which is increased?


ah, yes :) 2secs


I will merge this pull into the main repo. Thanks for the additions!


@miigotu problem is that if you run update not at night when user it's not using SR, it will be too slow use

My SHOWQUEUE-FORCE-UPDATE took 25-30 minutes to run.
and SHOWQUEUE-REFRESH took 15min.

So SR will be too slow while running those, that's why SHOWUPDATER runs at 03am. when nobody is using it


This is in the wrong place—try running reformat. :-)


The terminator issue was fixed in da385e6003.


ack


Actually, orionCurl has an option for this:  --noPayloadCheck


`cerr` would be better. but i am not sure cout/cerr is available at that moment if the process is daemonzied. BTW, `std::endl` comes with a newline, why would you put a space and `\n` here?


Edit:
这个添加确实使用了Genisys的解释器，但是我们没有copyright这是CS的作品，也没有说我们拥有copyright，不违背GPL许可证要求。


Why is ``call_soon`` needed? The initialization coroutines have already completed their work when ``run_until_complete`` returns.


It is really necessary?

I had to revert this chunk in order to compile wpcap.dll myself (on VS2015).


Não sei se é a parada do clearOrderFormCookie, mas quanto ele entra ele cai na pagina de login rapidinho, ve q ta logado e sai (coisa de milisegundos) mas ta estranho.


再次路过...


lol ya


Everything seems to work fine! The annotations issue was just a stupid mistake on my part!
Thanks for the effort!

M


import java.util.Scanner;
import java.util.Random;
public class mıllıpıyango
{

      public static void main (String [] args )
      {
    	  Scanner input=new Scanner(System.in);
    	  Random r = new Random();

    	  int bilet[],a,number_length,numbers[];

    	  System.out.println("Biletinizde kaç rakam var?");
    	  a = input.nextInt();

    	  bilet = new int[a];

    	  for(int i=0; i<a ; i++)
    	  {
    		 System.out.println(i+1 + ".sayıyı giriniz");
    		 bilet[i]= input.nextInt();
    		 System.out.println();
    	  }
    	  System.out.println("Biltinizdeki rakamlar:");
    	  for(int i=0 ; i<a ; i++)
    	  {
    		  System.out.print( bilet[i] +"-");
    	  }

          System.out.println();
    	  System.out.print("kaç sayı hesaplanacak?");
    	  number_length=input.nextInt();

    	  numbers=new int[number_length];

    	  for(int i=0 ;i <number_length; i++)
    			  {
    				  numbers[i] = r.nextInt(10);

    			  }
    	  System.out.println();
    	  System.out.println("Kazanan numaralar:");
    	  for(int i=0 ;i <number_length; i++)
		  {

		  System.out.print(  numbers[i] + "-") ;

		  }

      }
      }


The patch looks good. Not sure on how many platforms all these flags will be available, but nice!


TestCustomCommand (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (977 of 977 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-28.31%25-green.svg)


Please don't use meaningless abbreviations (you can replace `req_ctrl` with `request_control` or `req_control`)


I added xyann after receiving a pull request from you sometime ago, but only did so after a very long wait (6-8 months or so). Before that the code did use xytext. And I remember noticing that newer version of mpl  (1.4?) was throwing a deprecation warning.


Here you will need either --noPayloadCheck or use curl directly


Didn't remember... I'll try it.


Don't Edit Phar File...
Download Your Source here (Github) take the extracted zip and put it in plugins folder


非常感谢你教给我如何有效的反击例如the*******XD的行为。


Ah, thanks.  I just forgot and I guess never updated my local branch.  Anyway, it looks like we're merged now, so all is good.


needed


前からなのですが、「文字数」は原語にありません。ここは単に、
「...バイトより長い識別子を使いません。」
で良いと思います。


Same, please give a better name for `pctrls`


You are welcome @EtherTyper !


啊哈。。。thexxxxxxxxXD只是太激动了。。。别理他那么多就好，写点好玩的最好不过了


Refs travis-ci/travis-ci#5227


そっちの方が簡単ですね！やってみます


Ok, let me improve that then. Indeed my portuglish confuses people from time to time :)


correct, thanks


on pourrait:
- remonter dans AttributeHandler une fonction set_all_values() pour éviter de taper direct dans le chunkarray ?
- utiliser plutôt une constante standard au lieu de 0xffffffff


А ошибки почему тут не проверяешь?


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1308.f34d12cc69d7b07a478d73210e07a17805a695f9](http://build.palaso.org/viewLog.html?buildId=69353&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 1003, ignored: 12 Build time: 00:08:49


I analyzed the dependencies of the build and deploy scripts and here are some of my general reflections.

The deployment-related scripts should be separate from R package's code (and probably placed in a separate source code project) because they don't need much knowledge about the package itself, details follow below.

1. **Scripts to upload the built package to the artifacts repository**. These scripts should be only interested in taking a certain file and putting it in artifacts repository (from the scripts' POV, it doesn't matter what the file contains). Note that taking into consideration the way we currently use Artifactory and limitations that it forces upon us (e.g., we're not able to list files in given directory), it would be easier to simply treat a certain shared NFS directory as the repository. Functionalities of the scripts follow.
    1. **Uploading the package**. In the current approach, this would mean taking a `.tar.gz` package, generating `latest.txt` file for it and uploading it to Artifact. Note that the functionality uploading the package to Artifactory is not needed by Jenkins machine because it has it implemented already.
    2. **Downloading the package**. This is something that `deployment/artifactory.sh` script does if you skip one of the last lines that calls `deployment/local.sh` script.
    3. **Listing available packages**. This is not implemented. It's a nice-to-have feature but not really essential as for now. Apparently this functionality is not easy to implement when you're using Artifactory as the artifacts repository. It would be easy to do if you used a shared NFS directory.
2. **Scripts for deploying package**. These scripts are only interested in taking a local R package file with shiny app inside and deploying it in a Shiny server. The package itself can be any R package as long as it follows a convention that things to be copied to Shiny server's directory are inside of `shiny` directory of the package. Functionalities of the scripts follow.
    1. **Deploy package accessible locally in local Shiny server**. This is something that `deployment/local.sh` script does currently if you skip the part where `latest.txt` file is handled (because this functionality shouldn't know anything about that file because it's related to accessing artefacts repository and not deploying the application).
    2. **Deploy package accessible locally in remote Shiny server**. I'm not sure if this functionality is currently needed.
3. **Utility scripts that link scripts listed above** to make developer's life easier. Functionalities of the scripts follow.
    1. **Deploy package from artifacts repository in local Shiny server**. This downloads the package first and then deploys it in local Shiny server.
    2. **Deploy package from artifacts repository in remote Shiny server**. This is not implemented now. I'm not sure if it's really needed. With this functionality in place it would be probably easier for the developer to deploy the application since he wouldn't have to log into the machine with the Shiny server to deploy the application.

Apart from the deployment-related scripts mentioned above, we have a functionality which is a part of **package's build process** of generating a file with a git hash. The file should be accessible from within the code of the application.


Not really, as I'm expecting a JSON array. The pretty printer only changes the order of JSON objects (key-maps).

NTC


awesome! :cherries:


You can connect those 2 if's in one:
` if pctrls and pctrls[0].cookie`


@vsjulu could you prefix your commit message with "xio: " , and your email in the "Signed-off-by" line should be quoted using "<>". so it looks like

```
Signed-off-by: Subramanyam Varanasi <s.varanasi@ssi.samsung.com>
```

also ideally it would be better to split this commit into two. as they are logically separated changes.


Necessary change


How does creating a different form change things? We already have 2 forms..why not create a third?


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 141](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=796&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


Hmmm, not sure about this one. I understand where you are coming from. However, it is technically correct to have this as an anonymous func inline, because it is not a piece of a re-usable code. It happens only once and it is effectively the "main()" for this application. In fact this is a very common pattern for this kind of situation.


Well better wait for Cleber/English_speaker, maybe you're right...


it took me at least two hours to find the correct values, I had to go through almost all the calculations... changing `text@allocation` has 0 effect here (it's never used later iirc). You can try if you want, but I admit I'd be a little frustrated if you spent hours on fixing something that works...


ack


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/tests/processes/ProcessingTest.py`, line 299.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/processes/ProcessingTest.py
+++ b/coalib/tests/processes/ProcessingTest.py
@@ -296,7 +296,6 @@
                          tuple,
                          msg="files in file_dict should not be editable")

-
         # Non existent file
         file_dict = get_file_dict(["non_existent_file"], self.log_printer)
         self.assertEqual(file_dict, {})
```


This is nice and clean—I like it.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16262](https://teamcity.mesosphere.io/viewLog.html?buildId=138288&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:03:04


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 141](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=796&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **SUCCESS**
Summary: Running Build time: 00:01:08


Yeah I would use TheDiamondYT that's my name everywhere else but I forgot the email and pass -_-


and could you squash this change into the previous one, where this line is added?


asdasdasd


thxs i giveva try


Hi Brady,

On sourceforce https://sourceforge.net/projects/html2fpdf/ the Html2pdf version is 3.02 I don't see version 4


No, the text should not be exactly centered in this case (Solesmes never wants stars to go underneath previous notes, they have a special meaning for them)


「サロゲートペアは直接格納されませんが」→「サロゲートペアは直接格納されるわけではなく」の方が自然な感じがしますが、いかがでしょう。


Test


`u` comes after `s`. :dancer:
https://www.youtube.com/watch?v=783EsrHchXA


> fsdfa dfdsfsdf


and squash this one also to avoid the "fix the fix" commits in the same pull request.


Stray \n


Doh; yes of course (no commit); but in that case, I would expect the group to always start from the beginning, not the end. Will play some more but I think my first task today is to create a new project - for now I'll keep it in the same repo; we can decide to move it to its own repo later.


Sentences end with dots.


Looking at it in more details, it seems like it's possible to trigger it by issuing an authorization with no control plugin, then triggering a capture with control plugin(s). I'll add tests for it.


test


i make it say inted of j=hi i make it say rekkuzaragegjens joned and it say who are you and what are dong are you useing hacks if i code it more and add a bit in code in a thing i make i coud make it use comds if i try and it will blok him by say your are banned you ueseing  a hacks eith is not permited on gkaz


那个不是因为这
是因为在safemode下不允许AddBlock了，之前是允许的，会导致集群所有些压力都集中到先注册的3台chunkserver上


Merci. Réparé ici : https://github.com/medialab/hyphe-browser/commit/bf6f12efe6cfb352c56a4abf2cd820ed0ae42efe


但是很抱歉
Genisys 违反了GPL许可证
在使用参考代码的时候使用了Copyright字样


If that's what they want, then okay, but the images you originally posted in #767 showed centered stars when there was no bar line present.

Perhaps rc2 should create an option for that?


我本来不想跟你们争这些，但你们既然过来了就跟你们好好讲讲


`filename (str): `

In the new situation it may be easy to also accept full-path.


あ、そうですね。変な日本語に気を取られて、気付いていませんでした。


perfetto


その方が良いですね。他の同じ部分も含めて、修正します。


Is now not written consistently throughout this file.

The same goes for event log/eventlog.


sorry, my mistake. this one is in the right order.


围观啦！围观啦！
@Angelic47 @shanwer


add Roi


yes, that's probably a good idea. I think a new `maximumbarofffsettextleft@nobar` would be best (most configurable, easily pluggable)


Thanks for your help. Is german your mother language ?
What do you think if we could add the german flag. If you like this idea, I would propose to start the Translation of the english pages in german. It's just a wish.


That fixes it; thanks - explains why it always started at the end - because the second test **never** committed anything.


Indentation


(just to make things clear: they don't find the images I posted particularly good, it's possible that many things will change in the future)


Why?

Should not we init the bbox with ]+inf, -inf[ like the default-constructed bbox?


```python
assert place.holder.validator ==  "'!placeholder' has been overwritten"
```
```


Yeah. If this works, though, I think it's a great way to get students used to using git/GitHub. The only way to do it is to use it consistently, and this is an excuse to do that.


Huh...  You are correct that `text@allocation` isn't used after this.  I'll trust you then on the fact that this "just works" but may revisit things after rc1 to see if I can at least understand why my expectations are being violated here.


Very nitpicking, such change, wow


Right - there an option that governs the auto offset reset - to start or end - the default is to start at the end.


Since Python 2.7, you can use dictionary generator (also, instead of `dummy`, use `_` as a name of variable that you won't use), so something like that:
`records_data = [ {key: [value[0].decode(decode_encoding)] for k, v in x.iteritems() } for _, x in records]`


`dummy` -> `_`


`filename (str):`

And see above comment.


They are not used anyway so @afabri though it was better to initialize them at 0 rather than a value that could raise a question


https://github.com/FernetMenta/xbmc/commit/084cfc933b93c145c7b60181601b03eb7caee370#diff-36709d82d6066b98cdf0f5b73cc68dc7L65

there must be '|' instead ','


Just a heads-up: This method of referring to linked containers is being deprecated. The new way to do it is to simply use containername:port (links are automatically added to `/etc/hosts` inside the container).


ambiguityを「不明確さ」と訳していますが、「不明瞭さ」とした方が原語の意味を組んでいるような気がしますが、いかがでしょう？


shouldn't it be ``scheme`` rather than ``schema`` ?


@bontibon Thanks, I've fixed it.


Yes I speak German, but I think it would be better to wait a little bit:

* I just started to look into NuTyX and at the moment I'm not sure if I will stick with it: just checking it out - that's also the reason why I did not accept your invitation to join the NuTyX organization

* I also think it would be wise to change first the repository name from *houaphan* to *NuTyX* which will help you in the future with the documentation process.


Oh, good catch. I copied this whole section from the `--remove-old-sources` code from upstream, but clearly it doesn't do the right thing as `warn` will return a positive result. I don't know why the variable is needed at all since it's reset on every iteration.
```
if ($dry_run || unlink $path) {
  print " deleted\n" if $debug;
  $deleted++;
} else {
  warn "Could not unlink $path: $!";
}
```
Oh, actually, it looks like if you just change the `||` to `or` the `warn` result won't be included in the `$dr` evaluation. However, I think I'll change it to the above block and drop the variable.


This is a comment


Apart from those small fixes, it looks good.

When you will be amending you commit, you can add the following line to the commit message:
Reviewed-by: Sebastian Witowski <sebastian.witowski@cern.ch>


変更部分について確認しました。


#8  add image preview


The solution you describe sounds clean, I would be for this.


I'd go with "supplying" instead of "informing".


url returns https://127.0.0.1:8443/votes.12 ?  Why the '.' and not a slash?  Do we need APPEND_SLASH in settings.py for DRF created urls?


`Expected` should be `Unexpected` here.


la texture stonemonster est bien ajoutée -> https://github.com/MinetestForFun/server-minetestforfun/commit/f8e7c9557dc3bdce943c08bc524a6d4de3ff90a3#diff-eb4ee35428feeb76ee86af4081fa3b73R23

les icônes d'inventaire étaient ce qu'on avait rajouté, mais avec l'option "colorize" ont peut mettre une couleur directement, j'ai mis la blanche avec colorize, ça fait 15 textures en moins à charger.
![sheep_inv](https://cloud.githubusercontent.com/assets/7189389/13145289/f0537340-d64f-11e5-9b64-f0f7a48192e9.jpg)

pour le pathfinding j'ai mis ce qu'il a mis, pour les autres c'est à voir, apparement il a mis que pour les monstres.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16263](https://teamcity.mesosphere.io/viewLog.html?buildId=138293&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:10:12


Ditto.


`Expected` should be `Reference` here.


leave for future reorgs


A more complete suggestion: "... is incompatible with test URLs given on the command line"


(Note: anyway, to be consistent with ]-inf;+inf[, the min values should be initialized to `-(std::numeric_limits<double>::max)()`.

 `(std::numeric_limits<double>::min)()` represents the smallest non-zero _positive_ double value, not the smallest double value.)


Diff compares two files, from file and to file. Diff-- compares a copy of the file and the input inself.
Should diff-A-B. A and B be directories, it compares both alphabetically.
Syntax diff-a-b and diff-ab


this is still not in a proper regress testcase form yet. would you mind adding some asserts (such as https://github.com/unicorn-engine/unicorn/blob/master/tests/regress/callback-pc.py#L84) to verify the RDX value?

thanks


new Project(fullPath, args, null) should do the job


when in doubt, rip it out


The CPU fallback DPP also has sin/cos lookup tables; would it make sense to reuse them somehow?


client crashes when joining


test


Ah I see, thanks for letting me know; I've fixed it now:
https://github.com/Andrettin/Wyrmgus/commit/2e883b13a9d4977b29fe2652449c5fccc5e4d249


Alright, done.


@rbran100 @mpetrovic As per my analysis, the issue was occurring for cache issue. Same cache entry was being used for different content type listing pages. As a result same content was being displayed for all content type listing pages. This change will create different cache entries per content type for "Determine for me" settings. Can we just bypass this caching thing if "Determine for me" settings is selected?


Word-wrap seems off?
And line ending in dot


This should be re-tested as a simplification with [-3,1] bounds.


@flaviocopes
Error:
Line 17 is closing the form tag, so move `>` and add lat on line 18 ^^


Test cases is two words.


tail looks for lines in a file; it outputs the last lines of said file, should you add more to the syntaxis it will output more lines and keep track of changes that were done.


ack


Checks for the last lines of the file and keeps track on changes done to it.


Erreur !


Will there any more software evolution happen since [the short discussion on a topic like "script code on metavariables"](https://systeme.lip6.fr/pipermail/cocci/2016-January/002761.html "Clarification for script code on metavariables")?


you know I prefer meaningful names with more than one char?


As I'm reviewing this: Why don't we add mailings to the stack?


```js
var verbose = function (x) { console.log(x); };
verbose = function () {}; // comment out to enable verbose logging
```


You still have a "trace" in ConceptStructure.hs on line 92. This could be the cause of the slowdown. You may want to remove it even if it isn't.


unack, apart from the name it's good


Well, that depends. This is not fixing a bug.


Yes


You are missing
```
Returns:
   list: ...
```


Yes, already fixed in https://github.com/getgrav/grav-plugin-form/commit/2e6ba62bf9758a0485f50dcf18a8faa88113eb2d


alright what's wrong here? Either the code was totally broken before or it is now, what happened here?


unack, please keep the assert, it's important


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16264](https://teamcity.mesosphere.io/viewLog.html?buildId=138294&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:13


Drop the `claim.id` argument. Send it as a hidden input field instead.


lieing comment


Actually the issues we are receiving are pretty good, only very few people don't read the readme.


It was broken before.
It was used in only one place - which was while reporting a warning

-----Original Message-----
From: "Lasse Schuirmann" <notifications@github.com>
Sent: 18-02-2016 19:44
To: "coala-analyzer/coala" <coala@noreply.github.com>
Cc: "AbdealiJK" <abdealikothari@gmail.com>
Subject: Re: [coala] Processing: Import LOG_LEVEL correctly (567dab9)

alright what's wrong here? Either the code was totally broken before or it is now, what happened here?
—
Reply to this email directly or view it on GitHub.


why move down the functions? That destroys the diff, do that in an own commit please - unack


It only updates the shows that were updated that day on tvdb.

Regardless if you like it or not, people (including me) end up having shows that dont have their next episode set and it says they are unaired when they were. This was only recently disabled whe thraxis changed the show updater in december.


I can't, don't have the stdout anymore as that function dies in between


was that never executed? Can we add a test?

2016-02-18 15:15 GMT+01:00 AbdealiJK <notifications@github.com>:

> It was broken before.
> It was used in only one place - which was while reporting a warning
>
> -----Original Message-----
> From: "Lasse Schuirmann" <notifications@github.com>
> Sent: 18-02-2016 19:44
> To: "coala-analyzer/coala" <coala@noreply.github.com>
> Cc: "AbdealiJK" <abdealikothari@gmail.com>
> Subject: Re: [coala] Processing: Import LOG_LEVEL correctly (567dab9)
>
> alright what's wrong here? Either the code was totally broken before or it
> is now, what happened here?
> —
> Reply to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/567dab9959660051df70852c4f85ee805691e545#commitcomment-16176306>
> .
>


Chicos, reemplazaron el Readme con una versión vieja!


LGTM!


This occasionally fails and blows up with an error, now is a good time to fix it.


也没有用啥 UIKit specific 的东西呀，直接 iOS 和 OS X 都 `#import <Foundation/Foundation.h>` 嘛 → → @crazytonyli


argh. ...ack


Is this ``require`` really required?


I think `ProjectCollection` helps finding the tools (registry/config), sure it works with null ?


有哇，下面有用到 `UIEdgeInsets` & `UIOffset`。


Pourquoi ce changement ? Je ne vois aucune inclusion d'un fichier `config.php` dans ce pull request.


Cant handle this signal from parent class


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16265](https://teamcity.mesosphere.io/viewLog.html?buildId=138299&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:08:18


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16266](https://teamcity.mesosphere.io/viewLog.html?buildId=138300&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:14


喔，眼花了 ಠ_ರೃ


It's using reflection


@lembacon :eyes:


Screenshot of changes:

![2016-02-18_09-18-46](https://cloud.githubusercontent.com/assets/53005/13145837/e1353c24-d620-11e5-8c7b-bed140170218.png)


Oh new Project will use the global collection. Except I don't want to use that one, it fails the UTs if they run on same resource, and singletons are bad :)


Will this work if we get the image from a SVG font?


Did you fix anything I have mentioned for the lines in the code ? :P


Oh OK, makes sense.


rm


No

On Thu, Feb 18, 2016, 4:46 AM fanyongqiang <notifications@github.com> wrote:

> Could you please reserve Callback's method which in beta3?Interface
> Callback could have override method,onResponse(Response response) and
> onResponse(Call call, Response response).OnFailure method,too.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/square/retrofit/commit/9d0cca1b31e58990b0fcc693e013f0328ea3f376#commitcomment-16170884>
> .
>


added comments and grouped "created" assertions


Did you mean 'this is expected in 74X'?


extracted outboxId as a field and moved method statements into \@Before


What happens if someone WebChannel.create()'s twice ?


Oh didn't think of that it was using the global collection


Yes, I fixed this in the following commit. :)


格式


Link creates a hard link that creates an index node (information containing details of a file) between one file and another. Should one file be modified, it will affect greatly the other one.


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `bears/r/RLintBear.py`, line 26.*

The issue can be fixed by applying the following patch:

```diff
--- a/bears/r/RLintBear.py
+++ b/bears/r/RLintBear.py
@@ -23,7 +23,7 @@
         if shutil.which("Rscript") is None:
             return "R is not installed."
         else:
-            exitcode = subprocess.call(["Rscript" , "-e" , "library(lintr)"])
+            exitcode = subprocess.call(["Rscript", "-e", "library(lintr)"])
             if exitcode != 0:
                 return ('Package lintr is not installed')
             else:
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `bears/r/RLintBear.py`, line 37.*

The issue can be fixed by applying the following patch:

```diff
--- a/bears/r/RLintBear.py
+++ b/bears/r/RLintBear.py
@@ -34,4 +34,3 @@
         Checks the code with `lintr`.
         '''
         return self.lint(filename)
-        ```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `bears/tests/r/RLintBearTest.py`, lines 24 to 25.*

The issue can be fixed by applying the following patch:

```diff
--- a/bears/tests/r/RLintBearTest.py
+++ b/bears/tests/r/RLintBearTest.py
@@ -21,5 +21,5 @@

 RLintBearTest = verify_local_bear(RLintBear,
-                                   valid_files=(good_file,),
-                                   invalid_files=(bad_file,))
+                                  valid_files=(good_file,),
+                                  invalid_files=(bad_file,))
```


**Line contains following spacing inconsistencies:
- No newline at EOF.
- Trailing whitespaces.**
*SpaceConsistencyBear, severity 1, section `python`.* *Related to file `bears/r/RLintBear.py`, line 37.*

The issue can be fixed by applying the following patch:

```diff
--- a/bears/r/RLintBear.py
+++ b/bears/r/RLintBear.py
@@ -34,4 +34,4 @@
         Checks the code with `lintr`.
         '''
         return self.lint(filename)
-        +
```


The wording of this comment could just be something like: `# check for values for all keys up to the max index`

It's a shame there's no way to do anything at this point for missing responses beyond the max index, but I guess we just need to rely on the API complaining that the list is too short.


changed scope to public


Does "it empty array should be retrieved" sound like English to you?

"should return an empty array when no project exists"

Also please add a test key.


。。。else和右大括号放一行好么。。。


Hey Dragos,

Yes, this is an issue and thanks for looking into it. Can I also propose a bigger patch I worked on recently that you can test? If so I will send you the diff., you can test and if all goes well I will commit.

Thanks for all your efforts!


Yeah, I've fixed this and you're absolutely right.  The key difference between this and `getRoutes` is that they're passed to `getRoutes` for lazy-evaluation.  For example, you can `target` just an organization with no space.  At that time, it would be legal to list the routes just for the org you were in (`--orgLevel`) but wouldn't be for the space.  If the values were resolved with a `when()` early, this wouldn't be possible.


D:


Should this be a `None` rather than an empty string?  Or are we leaving non-truthy strings as whatever string got submitted?


I've discovered that if you run a reformat, but change windows to another application before it runs, it doesn't run.  Probably not an issue on your iMacs, but my little MBP takes some time to format these files. :frowning:


renamed to be consistent with class name (as the only publicly exposed method)


TeamCity Civic Assembly :: Build all [Build 62](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1223&buildTypeId=CivicAssembly_BuildAll&guest=1) is now running


See de1cd8f5976eff5d804344675b37ed9695fe52ad.


Авторство Алексея Александровича под этим коммитом выглядит подозрительно.


We may have to ask ourselves if this method really does anything that load_events_from_disk wouldn't do :confused: .


We could consider `import json` at the top and use `json.load` here. That may make it easier to read what is happening.


Именование хромает, тут ведь происходит update, а не add.
Задание 1.1 принято.


It means SH-BANG (# = Sh (sharp) ! = Bang), it tells Unix which program use to run said script.


Проект не компилируется.
Задание 1.2 не принято.


interesting


I don't think it is strictly needed. I expected a bunch of coroutines or timers to be waiting in the loop at that point but it seems pretty empty. Will remove.


Approved


Please check that your code builds before filing a pull request!!!


Yes. That updates the underlying model and does not break the binding - since the binding is the one that will actually update the checked property.


try-catch is hiding the NotSerializableException.


thanks, I missed that one


This request added the assert statement: https://github.com/unicorn-engine/unicorn/pull/435

Thanks.


Neo check this commit.
https://github.com/dorimanx/DORIMANX_LG_STOCK_LP_KERNEL/commit/6f9ff4f3465d7b7080ea25de905f12595f67d649


Already done.


will it work on http links ?


yes scheme is the correct word according to URI spec


I'm not sure this is tolerated in a bundle server on community.


As @tacaswell and I discussed but may not have mentioned to you yet, there are no integer NaNs in numpy. To avoid conversion to float, you may be want to take a different approach (a parallel data structure of binary arrays to be used as masks, or some integer sentinel value of your own choosing -- not NaN).


Same for this.


it needs to be moved as a class field ?


And this


@samoht Already done ;)


And this.


Seems like 4.3.3-r4 was stable on amd64 and x86 so it now forces downgrade to 4.1 on those archs. Intentional?


@particlebanana thoughts?


OK.


Per this description, it seems the Nova services are started when it's set as qemu. Just a question is there any errors reported before it's changed to xen?


I had a look. Jenkins at http://jenkins.plone.org/job/plone-5.0-python-2.7-robot/4082/console says what the basic problem is:

```
http://localhost:51625/plone/ca/a-catalan-document/@@getVocabulary
Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module plone.app.content.browser.vocabulary, line 77, in __call__
  Module plone.app.content.browser.vocabulary, line 211, in get_vocabulary
  Module plone.app.dexterity.permissions, line 82, in validate
AttributeError: No such field: content
```

You can see the same locally in coredev branch 5.0 with this command:

```
bin/test --all -s plone.app.multilingual -t test_add_translation.robot
```

Note that on my Mac, selenium does not like my Firefox so I cannot execute any robot tests, it simply cannot find a browser or profile. You can locally update the selenium pin to the latest 2.52.0. With that pin the robot tests work again. But indeed with the same failure.

From what I see, plone.app.multilingual does not like two of the changes.

First, it has an IAddTranslation interface with the `content` field that the traceback above complains about:
https://github.com/plone/plone.app.multilingual/blob/master/src/plone/app/multilingual/browser/interfaces.py#L57
I think this goes wrong because of this change:
https://github.com/plone/plone.app.widgets/commit/59f74d53482f5092ee7dd0c6d9c29d2637ea168c#diff-764a76f5f8ba1cc0b735b95598b5282fR126

Second, that same `content` field uses the `plone.app.vocabularies.Catalog` vocabulary and it expects to find all content from all languages. That is no longer happening due to this change:
https://github.com/plone/plone.app.vocabularies/commit/6f50418808bd78b6f133e15bae955d3aaa1fd8c6


This commit makes me really uncomfortable. I feel like this field is used on a pretty wide basis and can't just be changed to something else.

What was the motive for this change?


Can you please provide a test case?


@gaganawhad no, these changes all have to do with better debug output (and then they _prompted_ the next commit)


@pgleeson thanks! :+1:


OH MY GOD OF COURSE ITS NOT NAME BECAUSE ITS GIVEN_NAME AND SURNAME.

Really wish I had a second chance I feel silly.


You can also call `-copy` on the mutable array. It does the same thing here. Not a big deal, just something to keep in mind.


this command yields some output for me, that you need to catch and suppress as we want only our message to be shown to the user


Nagyon szép ez az x..org-server frissítés, de minek? Nem lehetne visszacsinálni 1.18 alá?
Nagyon szépen kérlek, hogy tedd meg! A cél 1.17.99!
Nem sok értelme van 1.18 fölé menni, nem jár semmi előnnyel még jó pár évig!
Az 1.18 -tól kezdve az nvidia-173, nvidia-304, nvidia-340 -es csomagok használhatatlanok, kidobandók, mert csak az x.org-1.17.99 -ig támogatottak.
Így az én nvidia GF 210 -es kiváló kártyám is csak a sokkal vacakabb nouveau -val lesz használható.
Lemondva ezzel a HD videók közvetlen dekódolásáról és gyors 3D OpenGL-es képességeiről.
Vagy a leendő UHU-Linux használatáról.


I'd add a period at the end of the sentence :)


The next commit does add a test - that's why I realized it was broken

-----Original Message-----
From: "Lasse Schuirmann" <notifications@github.com>
Sent: 18-02-2016 19:46
To: "coala-analyzer/coala" <coala@noreply.github.com>
Cc: "AbdealiJK" <abdealikothari@gmail.com>
Subject: Re: [coala] Processing: Import LOG_LEVEL correctly (567dab9)

was that never executed? Can we add a test?

2016-02-18 15:15 GMT+01:00 AbdealiJK <notifications@github.com>:

> It was broken before.
> It was used in only one place - which was while reporting a warning
>
> -----Original Message-----
> From: "Lasse Schuirmann" <notifications@github.com>
> Sent: 18-02-2016 19:44
> To: "coala-analyzer/coala" <coala@noreply.github.com>
> Cc: "AbdealiJK" <abdealikothari@gmail.com>
> Subject: Re: [coala] Processing: Import LOG_LEVEL correctly (567dab9)
>
> alright what's wrong here? Either the code was totally broken before or it
> is now, what happened here?
> —
> Reply to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/567dab9959660051df70852c4f85ee805691e545#commitcomment-16176306>
> .
>

—
Reply to this email directly or view it on GitHub.


A libxp törlése szándékos?


We can avoid the array by just recording the top index that DangerousAddRef worked.
Another things, shouldn't we cleanup in reverse order?


fixed by now


Same as with arrays, invoking `-copy` will do the same is creating the dictionary like this.


из-за JSON.simple, нет?


у меня тот же код компилируется


No I am not. I was only able to make it pass by changing custom-context.feature to use Chrome instead of PhantomJS. I have never used PhantomJS and was not able to make it work with it. Let me know if you can make it work by replacing PhantomJS by Chrome or Firefox.


ack


Would you be able to explain more what this is fixing? Could you provide a screenshot of the before and after? Thanks


Muutsin teksti


It's moved down because I need to use an existing function which was below it before (gave function not found errors)
I don't have any reason to move it down in another commit - seems non intuitive to me

-----Original Message-----
From: "Lasse Schuirmann" <notifications@github.com>
Sent: 18-02-2016 19:45
To: "coala-analyzer/coala" <coala@noreply.github.com>
Cc: "AbdealiJK" <abdealikothari@gmail.com>
Subject: Re: [coala] Shell: Use get_shell_type() to find shell (3fca3b4)

why move down the functions? That destroys the diff, do that in an own commit please - unack
—
Reply to this email directly or view it on GitHub.


I wonder why we had `TM_PARSER_NONE` make the check pass… comes from 7419f18f, but I'm not certain, looks like it was to perform some kind of query whether something has to be done, but I'm not sure.

Anyway, looks good.


Хорошее именование, задание 1.1 принято (с задержкой в 1 неделю).


TeamCity Civic Assembly :: Build all [Build 62](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1223&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **FAILURE**
Summary: Tests failed: 166 (1 new), passed: 6, ignored: 4 Build time: 00:15:00
### Failed tests
```
Blog categories tests: Should delete blog category new blog category 1455806451125: <no details avaliable>

Blog categories tests: Should not create new blog category if cancelled: <no details avaliable>

Blog categories tests: Should add new blog category: <no details avaliable>

Blog categories tests: Should not change blog category: <no details avaliable>

Blog categories tests: Should change blog category: <no details avaliable>

Blog categories tests: Should not delete blog category if cancel pressed: <no details avaliable>

Blogs tests: Should not create new blog if Cancel button pressed: <no details avaliable>

Blogs tests: Should add new blog: <no details avaliable>

Blogs tests: Should not change blog if Cancel button clicked: <no details avaliable>

Blogs tests: Should change blog: <no details avaliable>

Blogs tests: Should not delete blog if Cancel button was pressed: <no details avaliable>

##### there are 156 more failed tests, see build details
```


That approach works perfectly! Thanks for good and simple solution :)


TestCustomCommand (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1529 of 1529 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.7%25-green.svg)


:+1: @traversaro


may list the items special for XenSever or give some examples.


Ok


TestCustomCommand (jasondegraw) - x86_64-Linux-Ubuntu-14.04-custom_check: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg)


```
["english":englishTextField.text!, "japanese":japaneseTextField.text!]
```
としてみましょう！
OptionalとかUnwrappingとかについて調べてみると今回のエラーの原因がわかると思います。


we are missing the check for adding a duplicate. You can loop and +=1 to get the count. Though I am not sure we need a limit.  Do we?


@romanblanco shouldn't this be `~1.5`??


Thanks for reporting this bug, I have confirmed it on VS2015.
The original purpose of this patch is that the wpcap.dll built by VS2013 without this change will crash Wireshark on Win8 and Win10. See this: https://www.wireshark.org/lists/wireshark-dev/201602/msg00016.html

However, I didn't notice that VS2015 starts to have native support for these functions, which causes your compiling errors. Although I don't know whether the VS2015 version wpcap.dll will cause Wireshark to crash under Win8/Win10, you could try this.

I have fixed this bug at: https://github.com/nmap/npcap/commit/5de174dad7b1c3753432a257a410cfc8deb5c0c7, by using the method here: http://stackoverflow.com/questions/27754492/vs-2015-compiling-cocos2d-x-3-3-error-fatal-error-c1189-error-macro-definiti

The macros are only active with VS2013 and earlier, so VS2015 can use the native functions.


What a great commit :smile:


> Any objection to adding an ESLint rule to prevent this from happening?

Sgtm.


About this commit...
i think its really bad... i have scouted main line, and this was never merged. it's actually create stack allocated size that can be HUGE!

_STK_LIM = (8*1024*1024) = 8388608 then calc against  PAGE_MASK
in my case it's grabbing large amount of ram and kernel goes to oom...
maybe you should revert it. and see if you get more free RAM after some time of use.


@gaganawhad

I am hesitant to just call it `#graph` because that doesn't connote stringiness at all.

I don't want to use `puts` here because that limits my flexibility. Console is actually my primary use case for this. A script I'm writing is just the occasioning incident for committing it to the codebase. I could also see calling it in error messages or logger. THUS, returning a string seems ideal.

the encoded characters are colors.... I don't think I can write my comments in color ;).


Looks to hard to solve quickly and in one go. I have reverted the changes like this:

Removed three checkouts:
https://github.com/plone/buildout.coredev/commit/7567a3d70a23e182d37cdf2947aaeb49417a9556

And reverted the plone.app.z3cform changes:
https://github.com/plone/plone.app.z3cform/commit/9aecf144230775012e7a4622a56d36eb9b3af182
https://github.com/plone/plone.app.z3cform/commit/db5d1aa4a12842e085c4b07d21f7c7e642d96814


Can you add 3rd parameter as the same message? See pattern above.


Yes I am on a 2015 MBP 13".  If there is anything I can do to help test please let me know.


also where is that constant defined?


This doesn't work on python 2.6.


Disregard this commit, will work on restarting dbus based on system environment setting on raspberry pi


Yeah so this will conform to the current behavior, which is to always use `XLS_2007` for bulk exports. I'm guessing it was implemented this way to avoid confusion when the selected exports have different types, since it's not obvious which format should be used in that scenario. I think ideally there would be a way for the user to choose the type for a bulk export, but that of course would require adding something to the UI.

Another option might be to use the export's format in a bulk export if all instances have the same format, but otherwise to use `XLS_2007`. I'm a little hesitant to do that though because people might not understand why some bulk exports are in one format and some are in another.


BTW, I have fixed the issue at https://github.com/nmap/nmap/issues/298, feel free to feedback to me:)


missing end of the sentence?


Also adjust the Makefile rule for bam_quickcheck.o.


I thought it was reading the value in the `h2` ^^. Thank you for your vigilance! :shipit:


Probably not but we can adapt the delete directive when do the switch.


``#noqa`` avoids that flake8 complains about too long lines?
If yes could you do the same for the URL quoted at the top of the file?


I propose to rewrite history for the test fixture (squash next changes on the same file into first commit) after review is almost completed, in order not to lose current comments/feedbacks.


Best path forward from here is probably:
- Create branches for all these packages, plus probably plone.app.multilingual.
- Revert the changes on the master branches, so others can work from master again.
- Create a coredev branch that uses the new branches.
- Fix the stuff. :-)
- Create a pull request on coredev for that new branch and login to Jenkins and start a build for this pull request.


fixed


`Content-Type: application/json` header is missing.


Before these iptable lines, it's better to add a short description br-storage, br-mgmt just similar as eth3.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16267](https://teamcity.mesosphere.io/viewLog.html?buildId=138305&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:14


we should force upgrade to 1.0 rkt version and forget about old ones


good idea


saw approval from JeetKunDoug
at https://github.com/basho/riak_kv/commit/afd530c992914006b8459833d25327c066e4895c


merging basho/riak_kv/rebar-zl-riak-dt-update = afd530c9 into borshop-integration-1352-rebar-zl-riak-dt-update


basho/riak_kv/rebar-zl-riak-dt-update = afd530c9 merged ok, testing candidate = 76d7d2ed


there's an error on your code, which is "IndentationError".
```
def main():
      '''
      Area of the triangle
      '''
    pedestal = input("Insert the pedestal ")
    height = input("Insert the height ")

    area = pedestal * height / 2
    print "Area of the triangle is : ", area
```

it should be:

```
def main():
    '''
    Area of the triangle
    '''
    pedestal = input("Insert the pedestal ")
    height = input("Insert the height ")

    area = pedestal * height / 2
    print "Area of the triangle is : ", area


wait, 60s to compute the mean on 1.2k 2kx2k images?


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1309.18c2d7e904997c8952323adcab838d79f00e14c0](http://build.palaso.org/viewLog.html?buildId=69354&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 1003, ignored: 12 Build time: 00:07:32


Thanks @ilatypov nice work


It _is_ fundamentally broken if you claim to implement an specific algorithm in a "non-standard" way that produces different of output. If you want to implement a different algorithm, call it by another name. This is why the PHP development team isn't taken seriously; they disregard proper knowledge of their profession in a cavalier way, lacking basic reading comprehension, due diligence and sanity.


otherwise lgtm


extracted buildMimeHeaders


\cc @alecpm Still one failure. Is it related to your changes?


Thank you.


ANOVA Simulation
Bootstrap for sampling simulation
Normal Distribution and Test Hypotheses


This looks fine, but maybe "ls /sys/class/net/" is a simpler way to get this info?


remove FIXME here


godoc this returns the value to be used for the Proxy-Authorization header


IMO we should generalize it a little and allow to specify any options to rkt with something like `--rkt-options=' --stage-path=somehting --insecure-options=2`


Put the position placement words in <>. e.g. mgmt_ip => <mgmt_ip>.


we support "any" for -c too.. In fact -c IN and -c ANY are the only valid parameters.


dont create OutletFeatureHelperImpl with new, inject the interface instead


derp


No problem


Why tabs here?


remove FIXME


Note that plone.app.multilingual may need to create its own Catalog vocabulary that ignores the navigation root. I briefly tried this (or a variant) but the other problem with the context of an Add form was still there.


probably want to record whether there was a Proxy-Authorization header at all to make sure we aren't sending an empty one in non-proxy-auth cases


ping....


lgtm


The current docs list `bitbucket.username` as one of "the minimum required to import issues from Bitbucket," so I wouldn't call this a bug.


return null is not correct, delegate to the outlet helpers


Jenkins is busy running the tests for my reverts now.


i don't have python 2.6(i tested it with the version that i have python 2.7 and python 3.5).
can you explain why this won't work.


move this outside the `testCase.proxyServerFunc` check... we want to make sure we're not sending a proxy auth header even when the testcase doesn't set up a proxy server


remove FIXME, remove uncommented code


Generally speaking, this blog is great and helpful for understanding the XenServer Fuel Plugin. Thanks for writing this.


Ok, then leave it as it is right now. Was just a small nicety...


> This is strictly speaking an API change but no plugin uses langType at the moment so its renaming doesn't cause any problems.

It's referenced my `geany.vapi` bundled in multiterm plugin.  Probably doesn't matter much as it's indeed not actually used even then.
Though, if we care we could add a deprecated typedef quite easily.


need to check not just the string match, but also the presence/absence of the header (we don't want it present-and-empty in non-auth cases)


Gson умеет читать из файла целиком. Проверка валидности это конечно хорошо, но он сделает это за тебя и в случае ошибки выбросит exception, который ведь можно просто обработать.


Remove generated java doc


Formatting


Okay. Now i accept this.


remove FIXME


Remove uncommented code


missing a "do" or "include" before something? :-)


TeamCity Civic Assembly :: Build all [Build 63](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1231&buildTypeId=CivicAssembly_BuildAll&guest=1) is now running


Too late :) @simonharrer wanted the same, so it is implemted by now. Along with another bunch of changes coming soon.


why not use DEFINE_PRIVATE_STRING_TABLE_LOOKUP here?


Reformat this class,


safe_atou16() already does the range check.


Nice catch.


Remove link to wikipedia


What about port_num == 0?


Thanks. 1c8428c3ea0760c78cdbeee03a76413cedf2bfe8


I like where we are going with this functionality -- in order to make it easily available to all XBlocks I'm wondering about moving it into either https://github.com/edx/XBlock, or into https://github.com/edx/xblock-utils -- thoughts?


This change to provision-dind.sh probably doesn't belong in the non-dind-dev-cluster patch?


Is SIMDFloat64x2 still in spec?


Formatting


As with my above comment, what do you think about moving this entire operation into XBlock, or an xblock-utils mixin


remove javadoc comments


I really don't like clobbering input parameters like this (also see CODING_STYLE about this). Let's write this like this instead:

```c
address = strndup(address, port - address)
```

which has the same effect but doesn't clobber input parameters.


Gson умеет работать с  коллекциями и файлами, лишний код - лишние баги:)
Посмотри туториалы и документацию.


Indeed, very minimal coverage in next commit


well, there is a corner case we need to consider, imagine a port with data, but no readers connected is added to the port group, do we signal whoever is waiting so data can be read?


Done


I like the idea of doing a better job of handling errors in our controller. Could we move these changes into a separate pull request? Or could you point to me where this is needed to handle the issue at hand?


I've merged that commit to my code.


Can we just override ToObject instead of all these switch statements?


where have you modified? I don't see any changes in this PR!


looks good otherwise.


renamed


Since we are using the same call in multiple controller methods, could we add this to a separate `before_action`?


What is the effect of this? Just the line on the `yarplogger` will be red instead of yellow ?


java.sql.Timestamp не совсем то, что нужно использовать в повседневности.
лучше java.util.Date


Isn't this same as default case? Why do you need a special case for this?


谢谢组长夸奖。


No reason. I had not seen the PaymentType class somehow when I added this one. So by all means go ahead and unify them


this is so the FilterGroup options can have a numeric value assotiacted with the options. that is different than the Label text.


why not use `get_status_code_or_error`?


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1310.17f4973cc8dd762b880eda44f05f1dd1abbc8c47](http://build.palaso.org/viewLog.html?buildId=69355&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 1003, ignored: 12 Build time: 00:06:43


There's a little semantic trick. For every char buffer we have in the application we have a XXX_LENGTH macro which defines number of meaningful characters in the buffer.  Every XXX_LENGTH macro has a corresponding
XXX_SIZE which is basically XXX_LENGTH + 1;
We use XXX_SIZE in declarations\allocations and XXX_LENGTH everywhere else.

For example:
read_from_socket(fd, rbuf, (size_t)MAX_READ_BUFFER_LENGTH);


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/3240


System.currentTimeMillis() возвращает текущее время как long


It was necessary for the documentation ;)


Remove FIXME


removed FIXME


TeamCity Civic Assembly :: Build all [Build 63](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1231&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **FAILURE**
Summary: Tests failed: 166 (1 new), passed: 6, ignored: 4 Build time: 00:07:14
### Failed tests
```
Blog categories tests: Should delete blog category new blog category 1455807641686: <no details avaliable>

Blog categories tests: Should not create new blog category if cancelled: <no details avaliable>

Blog categories tests: Should add new blog category: <no details avaliable>

Blog categories tests: Should not change blog category: <no details avaliable>

Blog categories tests: Should change blog category: <no details avaliable>

Blog categories tests: Should not delete blog category if cancel pressed: <no details avaliable>

Blogs tests: Should not create new blog if Cancel button pressed: <no details avaliable>

Blogs tests: Should add new blog: <no details avaliable>

Blogs tests: Should not change blog if Cancel button clicked: <no details avaliable>

Blogs tests: Should change blog: <no details avaliable>

Blogs tests: Should not delete blog if Cancel button was pressed: <no details avaliable>

##### there are 156 more failed tests, see build details
```


The following doc(s) have been deployed to the [629multide](http://629multide-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/sites/multidev](http://629multide-static-docs.pantheon.io/docs/articles/sites/multidev)


indent please


@galtgendo:

When the issue came up the first time, it was decided that the SANEST way to treat positioned stereo sounds was to play them with the current properties. Which, if you actually think about it from the point of the user, is actually the only thing that really makes sense!

What OpenAL does appears to be an implementation error for anyone not well-versed in the technicalities of the matter and it is completely irrelevant what you THINK!

You better come off your high horse. Nothing you posted here comes across as less than being pedantic for the sake of being pedantic.


Great. I bring in more complexity. And I am actually fetching the whole of google homepage.


@vinamelody if possible, try to keep all lines shorter than 80 characters. Atom should show a thin line at the right that resembles the 80 character border.


xpath attr does not properly work on python 2.6, `find_xpath_attr` should be used instead:
```
[CBSNews] john-brennan-fifa-danny-clinch: Downloading webpage
[CBSNews] john-brennan-fifa-danny-clinch: Downloading enUCJTHvRFhm SMIL data
[CBSNews] john-brennan-fifa-danny-clinch: Checking video URL
[CBSNews] john-brennan-fifa-danny-clinch: Checking video URL
Traceback (most recent call last):
  File "youtube_dl/__main__.py", line 19, in <module>
    youtube_dl.main()
  File "C:\Dev\git\youtube-dl\master\youtube_dl\__init__.py", line 411, in main
    _real_main(argv)
  File "C:\Dev\git\youtube-dl\master\youtube_dl\__init__.py", line 401, in _real_main
    retcode = ydl.download(all_urls)
  File "C:\Dev\git\youtube-dl\master\youtube_dl\YoutubeDL.py", line 1692, in download
    url, force_generic_extractor=self.params.get('force_generic_extractor', False))
  File "C:\Dev\git\youtube-dl\master\youtube_dl\YoutubeDL.py", line 666, in extract_info
    ie_result = ie.extract(url)
  File "C:\Dev\git\youtube-dl\master\youtube_dl\extractor\common.py", line 315, in extract
    return self._real_extract(url)
  File "C:\Dev\git\youtube-dl\master\youtube_dl\extractor\cbsnews.py", line 79, in _real_extract
    tp_formats, tp_subtitles = self._extract_theplatform_smil(release_url, video_id, 'Downloading %s SMIL data' % pid)
  File "C:\Dev\git\youtube-dl\master\youtube_dl\extractor\theplatform.py", line 57, in _extract_theplatform_smil
    subtitles = self._parse_smil_subtitles(meta, default_ns)
  File "C:\Dev\git\youtube-dl\master\youtube_dl\extractor\cbsnews.py", line 50, in _parse_smil_subtitles
    closed_caption_e = smil.find(self._xpath_ns('.//param[@name=\'ClosedCaptionURL\']', namespace))
  File "C:\python\python266\lib\xml\etree\ElementTree.py", line 330, in find
    return ElementPath.find(self, path)
  File "C:\python\python266\lib\xml\etree\ElementPath.py", line 186, in find
    return _compile(path).find(element)
  File "C:\python\python266\lib\xml\etree\ElementPath.py", line 176, in _compile
    p = Path(path)
  File "C:\python\python266\lib\xml\etree\ElementPath.py", line 93, in __init__
    "expected path separator (%s)" % (op or tag)
SyntaxError: expected path separator ([)
```


Если пользователь вводит не int то падает NumberFormatException


At this point the GUI should be useable. (Issue #4 ) There has not been extensive testing on different systems however, so ease of installation is unclear.


This function now looks like returning simdString where as this is supposed to return typeof string. Please keep the old style. If you want to assert, add assert inside GetSIMDInt16x8DisplayString etc.


I would always add an empty line after a headline or sub-headlint.


Does this docstring look okay? Should I add anything more?


Are these names okay?


A small correction... (missing the word "to")

+$_['text_success']    = 'An email with a confirmation link has been sent to your email address.';


Грустно, что нельзя ввести имя файла с логами самому. Более того, из приложения не ясно, что же ты сделал не так и почему падает FileNotFoundException


do not create the outlet feature helper with new, use inject instead


**FAILURE** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 306](http://ci.infinispan.org/viewLog.html?buildId=36076&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for dadc79d2b3440345930fe4a117a80911aea08c3e
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:01:43

Process exited with code 1


Can we delete this?


if (inputStream != null)


Suggestion: our diary should also have a "Glossary" page where we collect all the fancy vocabulary that we will learn during the programme.


inputStream.close();


textView.setText("Couldn't close file");


Очепятка в UI


Is NETFRAMEWORK45 variable is right? Maybe NETFRAMEWORK461 missed.


Is  there any reason not to include processDestroy in your messagesProcessors too?


NumberFormatException
вроде вводишь в формате который просят, ан нет, ждали число.


Sorry this commit is miss leading as well. value was not part of the original object I added it and commited. but there where some convicts. so I updated it to numericValue. value did not exist before this PR


bedankt


We should add a hint: If you start the editor on OSX for the first time, you should click at "Atom > Install Shell Commands"


Can we just check the raw 128 byte values instead of individual checks?


Can we used the named route here?


NumberFormatException
Вроде вводишь как просили - dd.mm.yyyy hh.mm, ан нет, оказывается надо было число. Посмотри java.util.Date у них есть парсеры.


Cruft?


ACK.


better `python --version`, otherwise it will start the Python interpreter and a newbie wouldn't know how to get out of it :)


Why is SIMDFloat32x4 is special?


please sort import groups in the order [stdlib, thirdparty, this project]


Why the line changes?


I would try to be consistend and always put an empty space after the `#` (you did that on most other headlines) it makes the actual headline easier to read.


In fact, dnsmasq can send the TCP request in multiple segments, resulting in a single read of length 1 and then another read of the rest of the data.  One cheesy way to work around this (which still allows the proof of concept to work against glibc) is to time.sleep( 5 ) before calling conn.recv(), to allow the data to coalesce in the socket buffer before you try to read it.


此外，发现了两次运行回归函数结果不同的问题。唯一存在随机性的地方就是字典的储存。近日将修复这个问题。


This commit fixed what was entirely incorrect syntax. It's up to the user to decide on what semantics they use as its pretty much just preference.

There are probably Babel output repercussions in changing it however, but nothing that is needed as of yet.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16268](https://teamcity.mesosphere.io/viewLog.html?buildId=138310&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:13


Итого:
 - поправь мелкие ошибки вроде строк в UI, даты и чтения из файла.
 - опасайся Integer.parseInt которые могут бросать runtime ошибки в приложении (а оно после этого прекращает работу)

Задание 1.2 принято.


I'd split this into separate sections, to make it easier to pick out that there are three distinct groups of var.


Aaaarg! Maybe we should re-hack string_prefix to a class variable or static method?


2045-draw-dual-ducts (kbenne) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Because you didn't call `res_init()`?


+1 lol


@vinamelody i love it! a few typos here and there that we can fix as a team. you can push one more commit based on my comments and then merge this back into master (`git checkout master` and then `git merge --no-ff prerequisites`)


Seems a bit overkill to just compare 2 strings


@vitorbaptista
This breakes passing path to pytest and also forces change working dir (not good for contributors).


Seems like a formatting only change, no? Does your PR have an impact on this code?


ok got it. i think what you have is the right choice for now


// System.out.println("in");


Не похоже чтобы этот коммит добавлял javax.json к проекту


Could this change be added in with the original commit that adds the comment?


2045-draw-dual-ducts (kbenne) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


constant instead?


oops


Pedantic: Should this be (£3 inc VAT)? On the frontend it is displayed with no pound sign or the inc VAT.
If it needs to be used as a bare number(for calculations), should we not have two variables?


Could these changes be added in with the original commit that made these changes?


Yep, would be better to have test in the same commit than implementation


I am not sure this is right by spec. Assume left is normal object and right is SIMD, do we have to JavascriptConversion::ToPrimitive on the left object? What does spec say here? Ideal place for this check is RecyclableObject::Equals


Since you aren't taking more than a single arg, why use the flag library here instead of just os.Args?
If you did use "-h" as a flag to dump out help, that'd make sense to me.


Another formatting only commit, no? What impact does this have on the current PR?


sprawdź też coś z treści, a nie tylko czy dostajesz status 200


Ah yes we should add which Atom extensions to install too


I think so. We discussed about it together (I and @traversaro )


Maybe you can extract a method instead of writing a comment


Awesome =)


The following works

```javascript
exports.svg2png = function(svg, result, scale, width, height, callback, check) {
  var svgRenderer = new rsvg(svg);
    var buffer = svgRenderer.render({
      format: 'png',
      width: width * scale,
      height: height * scale
    }).data;
    result.png = "data:image/png;base64," + (buffer || "").toString('base64');
    callback();
};
```

But then we don't have the error check anymore. But iiuc the code didn't check for errros in librsvg (th rsvg part) before, "just" on the stream.


So this is the case where `data_one` is `head`, but bellow you advance `curr` to find `data_two` and then assign `first_node` to `curr`.


tytuł commita brzmi „Added landscape.io”, a tutaj dodatkowe jakieś poprawki cichaczem

rozbijaj commity tak, żeby faktycznie opisywały to co zrobiłeś (i najlepiej też „dlaczego”)

przydatne `git add` (żeby dodać dany plik do commita) i `git add -p` (żeby dodać tylko część pliku do commita)

https://github.com/Glenpl/LYTM/commit/730c9fe0196e280a07fa25bf643dc111d61a4e99#commitcomment-16130883


Loop to find `data_two`, just like we want.


@davidhadrianus89 sebaiknya di requirements.txt selalu ditambahkan versi spesifik yang diinstall karena kalau tidak diset versinya, pip akan menginstall versi terbaru yang mungkin bisa bentrok dengan package lain.


You're allowing for a single db to be sized (vs. all dbs), so why not allow someone to list more than one specific db to be sized?  And why not record the argument(s) into a distinct var so it is obvious what it is being used for?


自由


We found `data_two`, so `curr` is current the node before `data_two`, not `first_node`


You can use `descriptor?.visibility` instead of an explicit null check.


Ok, I think I have this figured out... will push one small fix for the focus issue


Нет. Вообще, потому что папка в репозитории названа по-русски, а в файлах прописан пакет up1. Попробуй выкачать его и все поймешь:)


why have `*args`?


This statement confuses me, since when I was testing #603 the preferences were clearly loaded at the title screen.


We use sentence case for diagnostic messages, not title case.


Can't UNKNOWN actually be used as a default filling value by the vendor? Maybe something with a "namespace" like EOSUNKNOWN?


imho samo `id` było ok – nie musisz wskazywać na typ – w 99% przypadkach id to jest liczba, a jak ma liczbą nie być, to wtedy warto się zastanowić


add documentation


add overview documentation


I think you are missing an `end` here


`date` i `time` muszą iść oddzielnie? nie ma jakiegoś typu danych, co łączy te dwie rzeczy w jedno?


This is not a good change. This will break lots of timing and FPS related code, if the delta time is fixed at a single value.


for weather app


Не нужно отвечать тут на все комментарии, просто прими к сведению и поправь. А то меня письмами заваливает:)


Here is better to use the new syntax `article: @article`. Rubocop don't anaylze htmls so you will have to make an extra effort here haha


MessageInCreation? MessageToCreate?


Can you please explain what does this fix. In particular, I'm not sure about LDADD vs LDFLAGS.


I dont think these are needed:
#include <vector>
#include <string>
#include <iostream>

As they are also included above for both windows and linux


same nazwy `date` i `time` są mało precyzyjne – o co chodzi? o datę utworzenia obiektu? o datę jakiejś zaplanowanej czynności?

o datę urodzenia? xD

generalnie np konwencją jest używać nazw typu `created_at`, `updated_at`, `created_by`, `updated_by`


Would be nice to provide a quickfix to create a doc comment stub (just the basic `/** / **/` structure, no need to generate any tags). Make sure you place the caret inside the doc comment.


Ok, dzięki za sugestie. W tym przypadku od razu pozmieniałem rzeczy które zaniżały 'health'.


@andrewngu, is there a reason why are you using `require` rather than `import`, I believe it will be aligned with the standard you have there.


This needs to be inside a windows #ifdef, else this will break linux development.


Can you add some tests for sf_date() and the other functions you added?  I can see value in some of them, but they'd need tests.


osobiście jestem raczej antyfanem skrótowców: preferuję normalnie `description` zamiast `desc`


This only allows for UNIX machines, is that OK?


Quick tip - rather than repeating a whole bunch of bootstrap columns classes, `col-xs-12 col-sm-6 col-md-4 col-lg-3`, why not use mixins to add this behavior to the `profile` class?

See the example here:

http://getbootstrap.com/css/#grid-less

In this way you can get rid of all the `col-*` classes from your HTML


Is it possible to create a base class say JavascriptSimd from which all the SIMD classes inherit common code. Seems like we could get away with repeated implementation of valueof, symboltoprimitive etc. What do you think?


Miałem wspólne datetime ale póki co nie potrafię dobrze wrzucić pickera który by pobierał date oraz czas jednocześnie. Na tę chwile jest tylko data, a żeby tego nie zmieniać jest wprowadzane wpisywanie godziny 'z łapy'. Też mi się nie podoba to, ale jak zostanie czasu to mam zamiar poprawić.


Use the standard "path/filepath" library to construct filesystem paths.


in line 145, multigrid.cpp, should param.Nvec be replaced with nVec_coarse?


@withintheruins14 why we assigning this?


landscape zaniżało tym 'health' więc zmieniłem na coś innego niż `id`


After this, boothd_LDFLAGS gets defined twice.


@Kami https://github.com/StackStorm/st2/pull/2396#issuecomment-173313019

> if there is no specific reason for this change
lol. Why would anyone write code without specific reason?

> I would prefer to move initialization of those two classes back to the constructor
Please don't do that for it will lead to duplication.

> Introduce "explicit" initialization interface
I am fine with this athough this is more java and less python. Regardless of how you break up the constructor this will now always be a fractured interface and a kludge one way or another.


co ma picker do modelu? picker to GUI. w pickerze możesz mieć oddzielnie, w modelu razem ;)


@raphaelpaiva, mais elegante seria, sim. O CorreioThread iria para um arquivo à parte, dentro do siga-base, não mais dentro do siga-ex, de modo que o sigasr também pudesse usá-lo. Mas, como a ideia foi dar uma solução provisória, sendo que a #618 deve exigir revisão dessa estrutura, preferi não agregar mudanças fora do âmbito do sigasr neste commit. Notificando @rafaela00castro sobre a ideia, pois ela deve trabalhar na solução definitiva.


ee, jakiś link? wyjaśnienie czemu?


I'd recommend you consider using the filepath.Walk function instead of calling out to "du" which is UNIX specific and which might be difficult to get consistent results from (unless du(1) with -s and -k are defined in POSIX?)


@Myoldmopar Yes, that is better. Check out the latest commit for the "final" results.


Might want to rescue somewhere so it doesn't blow up. The exception I saw was trying to parse the response as JSON when it wasn't, but maybe it was in fact a 404.


Yeah I debated that too.  Underscores work for me.  Will apply throughout.


We're trying really hard to get rid of boost.  Yes, we're currently packaging this particular code with our system, but only for now.  If we can find a solution that doesn't use boost, it would be preferable.


Thanks @asgrim !


Why isn't this needed anymore? Have you tried uploads with nginx_upload using this change?


Jestem w trakcie pisania dodatkowych testów


May I ask in what way are we suppose to use the Color Wheel node for?


reack (as the variable name has been changed)


reack


#englishfail


There's quite a lot of repeated code between these media queries - can you use a mixin instead? for example, one that takes a logo size and the margin required to push it to the correct location?


fast-forwarding develop-2.2 to borshop-integration-1352-rebar-zl-riak-dt-update = 76d7d2ed


it's ok, just confused myself.


Well I chose sitrep because it was short, concise, and meant the same as status without using the word status.  I can use `status_key` if you like, but I feel sitrep is better because it is easy to misunderstand that `status` and `status_key` have different meanings.  Hence my choice here.


@phlax, sorry. can't get still. why is it unnecessary?


why is this still not merged?


Thx a lot Amina.

BTW, do we need to keep this `selected-samples` file in the future? Isn't the `sample-track` file enough?


Thanks!

This helped me. MoodleRooms, please integrate this.


Сергей, если мы не инициализируем свойство в конструкторе, то при работе с данным свойством в программе (например добавление новых данных) мы рискуем нарваться на NullReferanceException.


Will this break existing tool wrappers?


You haven't removed `ChecksumException` class import :)


this part is terrible


huh?


Redefining built-in 'id' Pylint [W0622](https://docs.pylint.org/features.html#id5)


My interpretation of https://www.gnu.org/software/libtool/manual/html_node/Using-Automake.html is that LDADD should be preferrably used for *.la and LDFLAGS for old plain linking directives.

I've just noticed that redefinition, too. Looks I screwed up when returning to use $(GLIB_LIBS) as appropriate.

Will fix the latter deficiency if it is sufficient (should be `+=` instead).


@AlexanderLitus, please document exception it throws.


wow


It *is* broken, since the values don't match what is in mt19937ar.c. That's *not* in question.
Changing the (mis)behaviour without discussion: that is what's questionable here.


Sounds like you could create a new issue for that, it doesn't have to be dealt with now.


Since you're applying the boyscout rule, you could move computation of this variable closer to here (now it's computed way more above in the code).


That would be a good solution indeed ;)


why so much space between bracket


Any luck with BT anyone?

On Mon, Feb 1, 2016 at 11:25 PM, William Bellavance <
notifications@github.com> wrote:

> No had to step away, was working on the source it self. Now that themes
> are working 100% i started on it. I really need a few good hours to sit
> down and see whats going on i have somewhat of an idea
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Evervolv/android_system_bt/commit/8964e24d9507c4afd89a39f5bc9ae2b29d60041a#commitcomment-15814541>
> .
>


Add welcome message


Why is this 7? I see only 6 properties on prototype object.


It is better to say about "valid timestamp" or something. We don't really need to refer to internals in the error message.

It can be mentioned in the exception documentation.


@dwradcliffe Thanks!


Sure, what is it?


Shouldn't the cl_log check stay, we use cl_log? The change plumb -> gpl got introduced in 7fce5945ad32c518538849ec6f4135c34c676a62. @phmarek, do you remember the reason?


@manasdk Thanks for the clarification.

I'm slightly confused about duplication part, what duplication are you referring to?


ack


I'll follow the path outlined by @mauritsvanrees here, and see if I can get a fix for the multilingual issue on its own branch.  Sorry again.


you're absolutely right, not sure what i was thinking there, good catch :+1:


Electric-Service-Refactor (EnergyArchmage) - x86_64-MacOS-10.9-clang: OK (2077 of 2084 tests passed, 543 test warnings)

 * 547 tests had: AUD diffs.
 * 477 tests had: RDD diffs.
 * 3 tests had: ESO small diffs.
 * 7 tests had: MDD diffs.
 * 7 tests had: MTD diffs.
 * 3 tests had: EIO diffs.
 * 1 test had: SHD diffs.
 * 2 tests had: ERR diffs.
 * 4 tests had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 4 tests had: Table big diffs.
 * 1 test had: SSZ big diffs.
 * 1 test had: ZSZ big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.66%25-yellow.svg)


isn't builtins only available in Python 3?


Well, currently in samples-track there's no info that can justify why we didn't include certain "yes" samples in Bgee (for examples, those of "bad quality").
So either we create a merged file or we keep info separated.


Please move checks to the top of the method.


:shit:


`report_bulk_path` . You can access all of the named routes by visiting the Rails Routes info page at http://127.0.0.1:3000/rails/info/routes . Or by running `bundle exec rake routes`


it did all this previously because extra fields would lose the annotations, breaking the sort


No i to warto zawrzeć w opisie commita, np:

```
Task: changed id field name to id_num

It should not override the built–in field.
"Redefining built-in 'id' Pylint W0622"
https://docs.pylint.org/features.html#id5
```

Wtedy jak szukasz czegoś w historii od razu widzisz co zostało zmienione.
I od razu widzisz też **dlaczego** to zostało zmienione. Mniej WTFów przy współpracy z innymi czy jak sam zaglądasz do kodu po roku. :)


I discovered the `getRoutes()` anomaly and you're right, too. My solution was to pull the `this.spaceId` up into the `list()` public method body, so that all the references to `Mono`s are visible there.  This meant putting some conditional logic at the top level, but i got rid of getRoutes and replaced it with explicit calls to `requestOrganizationRoutes()` (sic) and/or `requestSpaceRoutes()`.  I'm looking at your solution now.

I also put in an extra test because I discovered that `getRoutes()` does an `otherwiseIfEmpty()` which is triggered if there are no organization routes! Not a problem semantically (fortunately), but you get an error if there is no `spaceId` (as demonstrated by my test): which is not expected.


@pkra thank you for looking into this. Let's see what @d00rman as native computer scientist says.


No, it's actually important to know that the item should not be mocked.  Otherwise, it looks like an omission.


This is not general enough. To be reversed. Refer to a related quantstrat 'issue' [ https://github.com/cloudcello/quantstrat/issues/2 ]


Is this assert needed?  Duktape is single-threaded so there's no possibility of a race condition resetting it.


Bugs should be corrected now.


Yup takes about 40 to 60 second depending on load.

@tacaswell @danielballan Just to be clear, the c routine converts from `int` to `float32` **then** applies the nan to the float, so I don't see a problem there. For example the converted intensity is like

```c

float *out
unit16_t *in, *bg
for(all pixels){
    if(bad_pixel){
        *out = NAN;
    } else {
        *out = (float)(*in) - (float)(*bgnd);
    }
    out++;
    in++;
    bgnd++;
}
```


Uniform adoption of the admin user.


(9563eb0) The title of the commit doesn't respect guideline ("type(scope): title (refs #<number>[, ...])")


swoją drogą beka z pytonga, że nie można takiego pola sobie ustawić xD


Maybe.  Perhaps @tingulfsen could advise?  My guess is that's how I found it or that's how it came in from a develop rebase.  It doesn't need to be addressed in this PR.


Prepared to open Internet Explorer to get converted Selenium Web Driver tests to run.


Oops, it got left over. I first had the assert there and then added the assignment when I noticed duk_debugger_attach() will set dbg_processing = 0. I'll remove it.


s/contains/contain/


Do you intend on skipping the actual LICENSE file or fixing it?  And it's great that it already found the year difference in two files.  Do you anticipate cleaning those up in this branch as well so this can go into develop all green?


This is a letter-perfect copy of my delta independently written. We *must* be doing something right!


if (inputStream != null)


I'm not entirely sure what this is going to do or if we even care about IE8 anymore. The regular cdrui_styles.css stylesheet is definitely older CSS.


inputStream.close();


> In general, I'm not a fan of this late initialization since it basically makes it really hard to understand the code

Same I would've preferred to have constructor overloading to handle this better. Adding more args to the constructors will lead to breakages in all existing actions so cannot take those approaches.

init() style methods are generally rare in python so not sure what is the right pythonic way. I suppose explicit is better than implicit. Anyway, the problem is with overload really and the minute we want to add more parameters we cannot really keep adding more params.

```
class Action(Action):
    def __init__(self, config):
        ....

    def initialize(self, logger, datastore_service):
       ....
```

```
class MyAction(Action):
   def __init__(self, config):
       ...

    def initialize(self, logger, datastore_service):
       super.initialize(MyAction, logger, datastore_service)
```

Now the next time we need to rev the args on initialize we end up at the same place since there will be lots of impls like `MyAction` in the wild. We could use `*args` to mitigate and we know some that hates awful `kwargs` and `args` abuse :P


textView.setText("Couldn't close file");


描述


public class WakeLockTest extends FullScreenTest {


public void onCreate(Bundle savedInstanceState) {


`dd` nie powinno być wcięte – jest na równie w drzewie dom z `dt`


> I'm slightly confused about duplication part, what duplication are you referring to?

https://github.com/StackStorm/st2/pull/2396#issuecomment-173313019

dupication of the _setup_logger method.


I just checked the code again and I think I see what you mean with "duplication".

This could be easily solved by making setup_logger a utility function and this way we can re-use it in both places (inside the constructor and inside the wrapper).


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16269](https://teamcity.mesosphere.io/viewLog.html?buildId=138320&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:18


The commit message is wrong. I wrote these commits yesterday, but didn't have permissions to push, and when I pushed today, you've already fixed it. I did fix the merge conflicts, but not the commit message, sorry.

About the change, your idea of using a default value for `posargs` was very cool. I changed it because it means I have to always remember of pointing the tests to `tests/` directory, even if I'd just want to add some configuration flag.

For example, with my patch, if you want to increase the verbosity of the tests (say for reading a full diff), you'd run `tox -- -v`. With your version, that extra argument would overwrite the `tests` option and you'd have to run `tox -- tests -v`. You can pass paths by using `tox -- tests/test_foo.py`. The `--` separates arguments for `tox` from arguments for `pytest`.

I've removed `[pytest]` because the configuration for the pytest should be inside the `[testenv]`. Or did I get it wrong?


Possibly, but part of this coincides with https://github.com/sul-dlss/argo/commit/9ff4296ac768980153bf7415746519ba718d6b84#commitcomment-16177502 . The larger question to me here is "Are the APO permissions changes you are introducing reliant on this?"

If not, let's not get hung up on this review, pop it into another PR for review and move on. If so I couldn't figure it out.

The idea here is this feels like an improvement, but also feels like a different thing than the current question at hand. Are these two things intractably linked? Could we revert one without the other?


What is button 3 and 4?


I would prefer `handcrafted` than `created` as she didn't created it ;-)


raz używasz 2 a innym 4 spacje do wcięć – taka konwencja widoków? czy z przypadku?


We should only need to either `throw result;` or `return result` (shouldn't need the extra promise wrapping).


> This could be easily solved by making setup_logger a utility function

Yeah fine. We still do not solve the original problem.


Nominally, yes... but for whatever reason this still works in Python 2.


Why are you leaving notes on this commit?
This commit adds it, not removes it.

Perhaps you are referring to commit 34a8da2ba26a806413f06ab18fdfad535de45cfa ?


The translation is: Открывать быстрые настройки когда присутствует %1$ уведомлений


sure! I'll do it this  weekend


这里思考再思考一下呢，万一再有一个人想要改字体颜色和大小呢 :smile:


Aussi j'ai ajouté un bouton pour activer le mode.


Yep, because of the ? after the "s" which means 0 or 1. Old memories ? :)
Look at the screenshot in the jira issue, I tried with http and https.


w bazie faktycznie trzymasz to rozdzielone? lepiej chyba jedna kolumna zamiast dwóch?


Created here: 99da08393259dd2a055f5d1df05ebee0b6ee4817


## Task 1

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program includes `main()` function and "ifmain" statement (1 pt)
- [ ] Program includes additional function(s) to compute "palindrome-ness" (2 pt)
- [ ] Program correctly determines whether **any** phrase or word is a palindrome (6 pt)

## Task 2

- [ ] Program is fixed - it is still recursive and works correctly with no errors (5 pt)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16270](https://teamcity.mesosphere.io/viewLog.html?buildId=138321&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:07:35


This works, but I wonder if changing the actual carrier legal name in the back-end would make more sense. Anyone knows the implication of changing the legal name?


v is a bit of a cryptic var name, but not a huge deal.


On Thu, Feb 18, 2016 at 07:27:58AM -0800, Jan Pokorný wrote:
> My interpretation of https://www.gnu.org/software/libtool/manual/html_node/Using-Automake.html is that LDADD should be preferrably used for *.la and LDFLAGS for old plain linking directives.

According to autoconf/automake, LIBS or LDADD should be used to
add libraries which were not found by autoconf, and LDFLAGS for
linker options (but not libraries):

http://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Preset-Output-Variables.html#index-LDFLAGS-112

http://www.gnu.org/software/automake/manual/html_node/Linking.html


@AMikhniev , see 13f939d


@AMikhniev see 13f939d


Why exactly is the numeric value needed for sorting?


@AMikhniev  , see 13f939d


ok


This has been published in v0.14.3

On Thu, Feb 18, 2016 at 3:17 AM Performatric <notifications@github.com>
wrote:

> +1
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/angular-ui/ui-select/commit/b1c4fdc5919dd0f5c66926498c28114a48334af9#commitcomment-16172682>
> .
>
--

Aaron Roberson

JavaScript Software Engineer

Mobile: (559) 492-7467

E-mail: aaronaroberson@gmail.com

Skype: aaronroberson

LinkedIn: http://linkedin.com/in/aaronrobes

GitHub: http://github.com/aaronroberson

------------------------------

Interested in scheduling a meeting? View my calendar and book a time to
talk using https://aaronroberson.youcanbook.me.

I ♥ JavaScript


I don't know the exact implication but I'm going to go with... we should probably not change their legal name.


I agree with your proposal from https://github.com/BgeeDB/expression-annotations/issues/110#issuecomment-185438416 to keep non-redundant info in these two files.


not in my 2.7.11... I can't import that module


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16271](https://teamcity.mesosphere.io/viewLog.html?buildId=138322&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:06


This also work, but we could parametrize this across the board?


utwórz ten słownik „za jednym razem” zamiast najpierw tworzyć pusty, a potem dokładać do niego wartości

chyba na tej zasadzie się to robiło:

```
my_dict = {
    id: str(item.id),
    title: item.title,
    // itd, może składnia nie ta, ale na tej zasadzie ;)
}
```


Warning:Junit测试代码中的数据重复比较多（测试数据太少临场加入数据应付老师233333）


Includes improved alt text. #81


You need the `future` package:
```
conda install future
```


What solution do you have in mind? Is it enough to check if `u0.v0 != 0` and then normalize their cross-product so that it becomes a projector?


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 81](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=797&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) is now running


Namaskara


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 81](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=797&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:21


Slight bug. On initial page load the drop down defaults to the first user while the text field contains the current user. Drop down should default to current user.


Tak, póki co rozdzielone. Właśnie będę chciał ten fragment z datą i godziną w całym programie zmienić jeszcze.


test


So, this assumes all existing users are always female? :)


wydziel metodę, która będzie zamieniać obiekt `item` na jego reprezentację dla `api`

zazwyczaj taki proces nazywany jest normalizacją, czyli np `dict_list.append(self._normalize_item(item))`


Reverted in #164.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16272](https://teamcity.mesosphere.io/viewLog.html?buildId=138323&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:00


Much better :+1:


hello Mike, hope you received the update of my homework.

- added DataProvider
- tried to check validity of Class, test passes by throwing exception but not at expected place.

please review. thanks.


perfect! keeping you updated!


This commit is reverted later. How about squashing this commit into the later commit?


Tabs removed and replaced with space characters.


Use `static const size_t IMAGE_SIZE`? Cosmetic though.


TeamCity Civic Assembly :: Build all [Build 64](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1241&buildTypeId=CivicAssembly_BuildAll&guest=1) is now running


The specs for the user permissions now depend on this refactor.  So this change belongs in this PR for it to pass all the travis tests.  The separation into a separate commit just helps to separate some major themes in this PR, but they are dependent commits.


TeamCity Civic Assembly :: Build all [Build 64](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1241&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **UNKNOWN**
Summary: Canceled (Exit code 137 (new); exit code 123 (new)) Build time: 00:00:27


na tym polega separacja warstw: nie musisz „wszędzie” tego zmieniać

1. zaczynasz od modelu – ustawiasz to tak jak sensownie to widzisz – tak jak `Task` wydaje się mieć to oczywiste – np wymagasz obiektu „datogodzina”, który ma wygodne metody pomocnicze, i tak samo go zwracasz w getterze
2. w bazie to może być zupełnie inaczej, np możesz tę „datogodzinę” trzymać jako napis
3. a w GUI możesz to prezentować jako zestaw trzech 5-u inputów (napisów) na każdą składową daty i godziny

generalnie to są trzy oddzielne rzeczy – to jak projektujesz bazkę czy to jak projektujesz GUI nie powinno mieć wpływo na to, jak wygląda Twój model – to on jest centrum


Hi, found similar bug solution in other project. I can prepare pull request that will fix it.
https://github.com/visionmedia/page.js/pull/239#issuecomment-85652843


Precioso, no dudaré en mergearlo!


I'm more in line with: Make their legal name their real legal name :)


TeamCity Civic Assembly :: Build all [Build 65](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1243&buildTypeId=CivicAssembly_BuildAll&guest=1) is now running


I copied the code from another of our files, but indeed, `/sys/class/net` appears to be the way to go.


i get side tracked to easy.   I haven't look at this in a few weeks was working on some other issues


What error were you seeing? They worked both locally in my MD editor and on the PR I filed for me? :confused:


This is probably not a good idea since it overwrites jQuery object in the middle of the document potentially having unexpected effects.


Thank you!!


grazestrap allert? I'm concerned we're adding too many helpers.


@veikus Pull Requests are always very much welcome :wink:


Built in Types Csharp

using System;

namespace IntroductionToCsharp
{
    class Program
    {
        static void Main()
        {
            int i = 0;

            Console.WriteLine("Min = (0)", int.MinValue);

        }
    }
}


请问有函数的中文解释文档吗？


The "Disp" argument in the original command is not in the new one. Is that ok ? I have no idea how this script works.


Shouldn't  we also take the opacity into account to update gl_FragColor?

gl_FragColor = vec4(accumulatedColor.xyz, accumulatedOpacity);


Tried but failed.
- toMap returns a map, but my accumulator is a single response builder.
- collect is not terser than reduce and also not more readable. Both requires a combiner, for parallel streams I assume.
If you could provide an alternative ...


이렇게 줄마다 쓰면서 코드 추가된 부분 리뷰가능
- 질문, 지적, 제안 등등


TeamCity ClearMeasureBootcamp :: 1 - Integration Build [Build 1.2.17](http://build.clear-measure.com/viewLog.html?buildId=4888&buildTypeId=ClearMeasureBootcamp_1IntegrationBuild&guest=1) is now running


moved to the top of process()


please remove hostname, port, applicationName from here


Se accetto questo suggerimenti, bisognerebbe, per uniformità, cambiare
anche le occorrenze nel file di Firefox. @flodolo, facciamo come dice
Sara o lasciamo come è ora?
Il resto lo correggo quando traduco anche l'altro file su Firefox OS.


+1 nice


please remove  hostname, port, applicationName


TeamCity ClearMeasureBootcamp :: 1 - Integration Build [Build 1.2.17](http://build.clear-measure.com/viewLog.html?buildId=4888&buildTypeId=ClearMeasureBootcamp_1IntegrationBuild&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:41


This seems to broke things :
 /usr/lib/nagios/plugins/customs/Webinject/Webinject $ perl Makefile.PL
include /usr/lib64/nagios/plugins/customs/Webinject/Webinject/inc/Module/Install.pm
String found where operator expected at Makefile.PL line 28, near "readme_from 'lib/Webinject.pm'"
        (Do you need to predeclare readme_from?)
syntax error at Makefile.PL line 28, near "readme_from 'lib/Webinnject.pm'"
Execution of Makefile.PL aborted due to compilation errors.


C'est cool. Je valide.


get_id_rank - хуита, её нужно воткнуть в ранк префикс


IE8 has about 1% marketshare according to http://caniuse.com/usage-table which relative to other IE versions is significant, but its definitely dropping out.  I'd be inclined to keep this for a bit longer


I think these macros are more concise https://github.com/OpenKinect/libfreenect2/blob/master/src/vaapi_rgb_packet_processor.cpp#L39-L41

Maybe use some `CHECK_COND()` `CHECK_CL()` `CALL_CL()`?

```
CHECK_CL(cl::Platform::get(&platforms));
```


take hostname, port, applicationName from configuration here...


probably this could be written as:
```
raise <<-MSG
  vagrant-service-manager plugin is required for projectatomic/adb.
  Kindly install the plugin: `$ vagrant plugin install vagrant-service-manager`
MSG
```


@mfonville, whoops...looks like your previous script had issues with beta too... (adding new beta deleted old beta and same arch non-beta)


In line 40:
```py
    if sys.stdin.isatty() and not tweet.text.isprintable():
```
I am aware that the C stdio function `isatty()` uses the state of `stdin` to determine whether we have a TTY or not, but when it comes to printability and ANSI colors, doesn't it make more sense to test `stdout` for tty'ishness? As in “Yes, give me colors if I can see them on my terminal [output], but give me plain text if I redirect stdout to a file.”


With travis you'll have to make it build on CentOS. See http://stackoverflow.com/questions/32535195/how-to-run-tests-on-centos-7-with-travis-ci


bysj_server use java


Pas faux pour la constante je met UINT_MAX
Le pb de set_all_values() c'est que c'est bourrin, ça remplit tous les chunks.
Une version dans  AttributeHandler laisse croire que l'on parcours uniquement les éléments alloués.  Pour moi c'est du mode expert.
Je préfère laisser comme ça


А по порядку алфавитному не надо отсортировать?