LM: this next model was thrown in without much explanation, I have tried to add some intro to it... is this correct? see line 448

LM: I found the plots a bit confusing to start is it worth putting titles on them to remind the reader that these are from both datasets? I couldn't figure out how to make the text bigger if we want to do this. I have also clarified the text in the para above as it referred to Figure 6 generally at one point that I think is what threw me off a bit and the fact that the other model hadn't been introduced till after it'a plot was introduced. see line 455


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27001/testReport/) for this commit**


I think this is fine, since this function doesn't get called every frame. Don't forget to put the weak ref at the end of the function though.


Such an error message needs to be a resource.


Is this supposed to have a CHECK? Is it supposed to be here at all?


This commit seems to have caused the agent not to start on Ubuntu 14.04.3.  The most interesting bit is at the very bottom of this comment.

`prod-app-1 i-XXXXXX ubuntu ~ $ cat /etc/init.d/codedeploy-agent
#!/bin/bash -ex

# Init file for codedeploy-agent
#
# chkconfig: 2345 98 02
# description: codedeploy-agent processes the deployments created by AWS CodeDeploy and installs \
# the deployment artifacts on to this instance.

### BEGIN INIT INFO
# Provides:          codedeploy-agent
# Required-Start:    $all
# Required-Stop:     $remote_fs
# Default-Start:     2 3 4 5
# Default-Stop:      0 1 6
# Short-Description: AWS CodeDeploy Host Agent
# Description:       codedeploy-agent processes the deployments created by AWS CodeDeploy and installs
#                    the deployment artifacts on to this instance.
### END INIT INFO

RETVAL=0
[ -f /etc/profile ] && [ "`stat --format '%U %G' /etc/profile`" == "root root" ] && source /etc/profile

prog="codedeploy-agent"
AGENT_ROOT="/opt/codedeploy-agent/"
INSTALLER="/opt/codedeploy-agent/bin/install"
BIN="/opt/codedeploy-agent/bin/codedeploy-agent"

start() {
        echo -n $"Starting $prog:"
        cd $AGENT_ROOT
        nohup $BIN start >/dev/null </dev/null 2>&1  # Try to start the server
        exit $?
}

stop() {
        echo -n $"Stopping $prog:"
        cd $AGENT_ROOT
        nohup $BIN stop >/dev/null </dev/null 2>&1  # Try to stop the server
        exit $?
}

restart() {
        echo -n $"Restarting $prog:"
        cd $AGENT_ROOT
        nohup $BIN restart >/dev/null </dev/null 2>&1  # Try to restart the server
        exit $?
}

status() {
        cd $AGENT_ROOT
        $BIN status # Status of the server
        exit $?
}

update() {
        echo -n $"Updating $prog:"
        cd $AGENT_ROOT
        $INSTALLER auto #Update the agent
}

case "$1" in
        start)
                start
                ;;
        start-no-update)
                start
                ;;
        start-with-update)
                update
                start
                ;;
        stop)
                stop
                ;;
        restart)
                restart
                ;;
        force-reload)
                stop
                start
                ;;
        status)
                status
                ;;
        *)
                echo $"Usage: $0 {start|stop|status|restart}"
esac
prod-app-1 i-XXXXXXX ubuntu ~ $ sudo service codedeploy-agent start
+ RETVAL=0
+ '[' -f /etc/profile ']'
++ stat --format '%U %G' /etc/profile
+ '[' 'root root' == 'root root' ']'
+ source /etc/profile
++ '[' '' ']'
++ '[' -d /etc/profile.d ']'
++ for i in '/etc/profile.d/*.sh'
++ '[' -r /etc/profile.d/bash_completion.sh ']'
++ . /etc/profile.d/bash_completion.sh
+++ '[' -n '4.3.11(1)-release' -a -n '' -a -z '' ']'
++ for i in '/etc/profile.d/*.sh'
++ '[' -r /etc/profile.d/nvm.sh ']'
++ . /etc/profile.d/nvm.sh
+++ . /usr/local/src/nvm/nvm.sh
++++ NVM_SCRIPT_SOURCE=']'
++++ '[' -z '' ']'
++++ export NVM_CD_FLAGS=
++++ NVM_CD_FLAGS=
++++ nvm_has unsetopt
++++ type unsetopt
++++ '[' -z '' ']'
++++ '[' -n /usr/local/src/nvm/nvm.sh ']'
++++ NVM_SCRIPT_SOURCE=/usr/local/src/nvm/nvm.sh
++++++ dirname /usr/local/src/nvm/nvm.sh
+++++ cd /usr/local/src/nvm
+++++ pwd
++++ NVM_DIR=/usr/local/src/nvm
++++ export NVM_DIR
++++ unset NVM_SCRIPT_SOURCE
++++ '[' -z '' ']'
++++ export NVM_NODEJS_ORG_MIRROR=https://nodejs.org/dist
++++ NVM_NODEJS_ORG_MIRROR=https://nodejs.org/dist
++++ '[' -z '' ']'
++++ export NVM_IOJS_ORG_MIRROR=https://iojs.org/dist
++++ NVM_IOJS_ORG_MIRROR=https://iojs.org/dist
++++ NVM_AUTO_MODE=use
++++ nvm_supports_source_options
+++++ echo '[ $# -gt 0 ] && echo $1'
+++++ . /dev/stdin yes
++++ '[' _yes = _yes ']'
++++ '[' 1 -ne 0 ']'
++++ case "$1" in
++++ shift
++++ '[' 0 -ne 0 ']'
++++ nvm_auto use
++++ local NVM_MODE
++++ NVM_MODE=use
++++ local VERSION
++++ '[' _use = _install ']'
++++ '[' _use = _use ']'
+++++ nvm_alias default
++++ VERSION=v0.12.7
++++ '[' -n v0.12.7 ']'
++++ nvm use --silent v0.12.7
++++ '[' 3 -lt 1 ']'
++++ local GREP_OPTIONS
++++ GREP_OPTIONS=
++++ local VERSION
++++ local ADDITIONAL_PARAMETERS
++++ local ALIAS
++++ case $1 in
++++ local PROVIDED_VERSION
++++ local NVM_USE_SILENT
++++ NVM_USE_SILENT=0
++++ local NVM_DELETE_PREFIX
++++ NVM_DELETE_PREFIX=0
++++ shift
++++ '[' 2 -ne 0 ']'
++++ case "$1" in
++++ NVM_USE_SILENT=1
++++ shift
++++ '[' 1 -ne 0 ']'
++++ case "$1" in
++++ '[' -n v0.12.7 ']'
++++ PROVIDED_VERSION=v0.12.7
++++ shift
++++ '[' 0 -ne 0 ']'
++++ '[' -z v0.12.7 ']'
+++++ nvm_match_version v0.12.7
+++++ local NVM_IOJS_PREFIX
++++++ nvm_iojs_prefix
++++++ echo iojs
+++++ NVM_IOJS_PREFIX=iojs
+++++ local PROVIDED_VERSION
+++++ PROVIDED_VERSION=v0.12.7
+++++ case "_$PROVIDED_VERSION" in
+++++ nvm_version v0.12.7
+++++ local PATTERN
+++++ PATTERN=v0.12.7
+++++ local VERSION
+++++ '[' -z v0.12.7 ']'
+++++ '[' v0.12.7 = current ']'
+++++ local NVM_NODE_PREFIX
++++++ nvm_node_prefix
++++++ echo node
+++++ NVM_NODE_PREFIX=node
+++++ case "_$PATTERN" in
++++++ nvm_ls v0.12.7
++++++ command tail -n1
++++++ local PATTERN
++++++ PATTERN=v0.12.7
++++++ local VERSIONS
++++++ VERSIONS=
++++++ '[' v0.12.7 = current ']'
++++++ local NVM_IOJS_PREFIX
++++++ tail -n1
+++++++ nvm_iojs_prefix
+++++++ echo iojs
++++++ NVM_IOJS_PREFIX=iojs
++++++ local NVM_NODE_PREFIX
+++++++ nvm_node_prefix
+++++++ echo node
++++++ NVM_NODE_PREFIX=node
++++++ local NVM_VERSION_DIR_IOJS
+++++++ nvm_version_dir iojs
+++++++ local NVM_WHICH_DIR
+++++++ NVM_WHICH_DIR=iojs
+++++++ '[' -z iojs ']'
+++++++ '[' _iojs = _new ']'
+++++++ '[' _iojs = _iojs ']'
+++++++ echo /usr/local/src/nvm/versions/io.js
++++++ NVM_VERSION_DIR_IOJS=/usr/local/src/nvm/versions/io.js
++++++ local NVM_VERSION_DIR_NEW
+++++++ nvm_version_dir new
+++++++ local NVM_WHICH_DIR
+++++++ NVM_WHICH_DIR=new
+++++++ '[' -z new ']'
+++++++ '[' _new = _new ']'
+++++++ echo /usr/local/src/nvm/versions/node
++++++ NVM_VERSION_DIR_NEW=/usr/local/src/nvm/versions/node
++++++ local NVM_VERSION_DIR_OLD
+++++++ nvm_version_dir old
+++++++ local NVM_WHICH_DIR
+++++++ NVM_WHICH_DIR=old
+++++++ '[' -z old ']'
+++++++ '[' _old = _new ']'
+++++++ '[' _old = _iojs ']'
+++++++ '[' _old = _old ']'
+++++++ echo /usr/local/src/nvm
++++++ NVM_VERSION_DIR_OLD=/usr/local/src/nvm
++++++ case "$PATTERN" in
++++++ nvm_resolve_local_alias v0.12.7
++++++ '[' -z v0.12.7 ']'
++++++ local VERSION
++++++ local EXIT_CODE
+++++++ nvm_resolve_alias v0.12.7
+++++++ '[' -z v0.12.7 ']'
+++++++ local PATTERN
+++++++ PATTERN=v0.12.7
+++++++ local ALIAS
+++++++ ALIAS=v0.12.7
+++++++ local ALIAS_TEMP
+++++++ local SEEN_ALIASES
+++++++ SEEN_ALIASES=v0.12.7
+++++++ true
++++++++ nvm_alias v0.12.7
+++++++ ALIAS_TEMP=
+++++++ '[' -z '' ']'
+++++++ break
+++++++ '[' -n v0.12.7 ']'
+++++++ '[' _v0.12.7 '!=' _v0.12.7 ']'
+++++++ nvm_validate_implicit_alias v0.12.7
+++++++ return 2
++++++ VERSION=
++++++ EXIT_CODE=2
++++++ '[' -z '' ']'
++++++ return 2
+++++++ nvm_ensure_version_prefix v0.12.7
+++++++ local NVM_VERSION
++++++++ nvm_strip_iojs_prefix v0.12.7
++++++++ local NVM_IOJS_PREFIX
++++++++ command sed -e 's/^\([0-9]\)/v\1/g'
++++++++ sed -e 's/^\([0-9]\)/v\1/g'
+++++++++ nvm_iojs_prefix
+++++++++ echo iojs
++++++++ NVM_IOJS_PREFIX=iojs
++++++++ '[' _v0.12.7 = _iojs ']'
++++++++ echo v0.12.7
+++++++ NVM_VERSION=v0.12.7
+++++++ nvm_is_iojs_version v0.12.7
+++++++ case "$1" in
+++++++ return 1
+++++++ echo v0.12.7
++++++ PATTERN=v0.12.7
++++++ '[' _v0.12.7 = _N/A ']'
++++++ local NVM_PATTERN_STARTS_WITH_V
++++++ case $PATTERN in
++++++ NVM_PATTERN_STARTS_WITH_V=true
++++++ '[' true = true ']'
+++++++ nvm_num_version_groups v0.12.7
+++++++ local VERSION
+++++++ VERSION=v0.12.7
+++++++ VERSION=0.12.7
+++++++ VERSION=0.12.7
+++++++ '[' -z 0.12.7 ']'
+++++++ local NVM_NUM_DOTS
++++++++ echo 0.12.7
++++++++ command sed -e 's/[^\.]//g'
++++++++ sed -e 's/[^\.]//g'
+++++++ NVM_NUM_DOTS=..
+++++++ local NVM_NUM_GROUPS
+++++++ NVM_NUM_GROUPS=...
+++++++ echo 3
++++++ '[' _3 = _3 ']'
+++++++ nvm_version_path v0.12.7
+++++++ local VERSION
+++++++ VERSION=v0.12.7
+++++++ '[' -z v0.12.7 ']'
+++++++ nvm_is_iojs_version v0.12.7
+++++++ case "$1" in
+++++++ return 1
+++++++ nvm_version_greater 0.12.0 v0.12.7
+++++++ local LHS
++++++++ nvm_normalize_version 0.12.0
++++++++ echo 0.12.0
++++++++ command awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
++++++++ awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
+++++++ LHS=0000012000000
+++++++ local RHS
++++++++ nvm_normalize_version v0.12.7
++++++++ echo 0.12.7
++++++++ command awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
++++++++ awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
+++++++ RHS=0000012000007
+++++++ '[' 0000012000000 -gt 0000012000007 ']'
++++++++ nvm_version_dir new
++++++++ local NVM_WHICH_DIR
++++++++ NVM_WHICH_DIR=new
++++++++ '[' -z new ']'
++++++++ '[' _new = _new ']'
++++++++ echo /usr/local/src/nvm/versions/node
+++++++ echo /usr/local/src/nvm/versions/node/v0.12.7
++++++ '[' -d /usr/local/src/nvm/versions/node/v0.12.7 ']'
++++++ VERSIONS=v0.12.7
++++++ '[' '' = true ']'
++++++ '[' -z v0.12.7 ']'
++++++ echo v0.12.7
+++++ VERSION=v0.12.7
+++++ '[' -z v0.12.7 ']'
+++++ '[' _v0.12.7 = _N/A ']'
+++++ echo v0.12.7
++++ VERSION=v0.12.7
++++ '[' -z v0.12.7 ']'
++++ '[' _v0.12.7 = _system ']'
++++ '[' _v0.12.7 = _∞ ']'
++++ nvm_ensure_version_installed v0.12.7
++++ local PROVIDED_VERSION
++++ PROVIDED_VERSION=v0.12.7
++++ local LOCAL_VERSION
++++ local EXIT_CODE
+++++ nvm_version v0.12.7
+++++ local PATTERN
+++++ PATTERN=v0.12.7
+++++ local VERSION
+++++ '[' -z v0.12.7 ']'
+++++ '[' v0.12.7 = current ']'
+++++ local NVM_NODE_PREFIX
++++++ nvm_node_prefix
++++++ echo node
+++++ NVM_NODE_PREFIX=node
+++++ case "_$PATTERN" in
++++++ nvm_ls v0.12.7
++++++ command tail -n1
++++++ local PATTERN
++++++ tail -n1
++++++ PATTERN=v0.12.7
++++++ local VERSIONS
++++++ VERSIONS=
++++++ '[' v0.12.7 = current ']'
++++++ local NVM_IOJS_PREFIX
+++++++ nvm_iojs_prefix
+++++++ echo iojs
++++++ NVM_IOJS_PREFIX=iojs
++++++ local NVM_NODE_PREFIX
+++++++ nvm_node_prefix
+++++++ echo node
++++++ NVM_NODE_PREFIX=node
++++++ local NVM_VERSION_DIR_IOJS
+++++++ nvm_version_dir iojs
+++++++ local NVM_WHICH_DIR
+++++++ NVM_WHICH_DIR=iojs
+++++++ '[' -z iojs ']'
+++++++ '[' _iojs = _new ']'
+++++++ '[' _iojs = _iojs ']'
+++++++ echo /usr/local/src/nvm/versions/io.js
++++++ NVM_VERSION_DIR_IOJS=/usr/local/src/nvm/versions/io.js
++++++ local NVM_VERSION_DIR_NEW
+++++++ nvm_version_dir new
+++++++ local NVM_WHICH_DIR
+++++++ NVM_WHICH_DIR=new
+++++++ '[' -z new ']'
+++++++ '[' _new = _new ']'
+++++++ echo /usr/local/src/nvm/versions/node
++++++ NVM_VERSION_DIR_NEW=/usr/local/src/nvm/versions/node
++++++ local NVM_VERSION_DIR_OLD
+++++++ nvm_version_dir old
+++++++ local NVM_WHICH_DIR
+++++++ NVM_WHICH_DIR=old
+++++++ '[' -z old ']'
+++++++ '[' _old = _new ']'
+++++++ '[' _old = _iojs ']'
+++++++ '[' _old = _old ']'
+++++++ echo /usr/local/src/nvm
++++++ NVM_VERSION_DIR_OLD=/usr/local/src/nvm
++++++ case "$PATTERN" in
++++++ nvm_resolve_local_alias v0.12.7
++++++ '[' -z v0.12.7 ']'
++++++ local VERSION
++++++ local EXIT_CODE
+++++++ nvm_resolve_alias v0.12.7
+++++++ '[' -z v0.12.7 ']'
+++++++ local PATTERN
+++++++ PATTERN=v0.12.7
+++++++ local ALIAS
+++++++ ALIAS=v0.12.7
+++++++ local ALIAS_TEMP
+++++++ local SEEN_ALIASES
+++++++ SEEN_ALIASES=v0.12.7
+++++++ true
++++++++ nvm_alias v0.12.7
+++++++ ALIAS_TEMP=
+++++++ '[' -z '' ']'
+++++++ break
+++++++ '[' -n v0.12.7 ']'
+++++++ '[' _v0.12.7 '!=' _v0.12.7 ']'
+++++++ nvm_validate_implicit_alias v0.12.7
+++++++ return 2
++++++ VERSION=
++++++ EXIT_CODE=2
++++++ '[' -z '' ']'
++++++ return 2
+++++++ nvm_ensure_version_prefix v0.12.7
+++++++ local NVM_VERSION
++++++++ nvm_strip_iojs_prefix v0.12.7
++++++++ command sed -e 's/^\([0-9]\)/v\1/g'
++++++++ local NVM_IOJS_PREFIX
++++++++ sed -e 's/^\([0-9]\)/v\1/g'
+++++++++ nvm_iojs_prefix
+++++++++ echo iojs
++++++++ NVM_IOJS_PREFIX=iojs
++++++++ '[' _v0.12.7 = _iojs ']'
++++++++ echo v0.12.7
+++++++ NVM_VERSION=v0.12.7
+++++++ nvm_is_iojs_version v0.12.7
+++++++ case "$1" in
+++++++ return 1
+++++++ echo v0.12.7
++++++ PATTERN=v0.12.7
++++++ '[' _v0.12.7 = _N/A ']'
++++++ local NVM_PATTERN_STARTS_WITH_V
++++++ case $PATTERN in
++++++ NVM_PATTERN_STARTS_WITH_V=true
++++++ '[' true = true ']'
+++++++ nvm_num_version_groups v0.12.7
+++++++ local VERSION
+++++++ VERSION=v0.12.7
+++++++ VERSION=0.12.7
+++++++ VERSION=0.12.7
+++++++ '[' -z 0.12.7 ']'
+++++++ local NVM_NUM_DOTS
++++++++ echo 0.12.7
++++++++ command sed -e 's/[^\.]//g'
++++++++ sed -e 's/[^\.]//g'
+++++++ NVM_NUM_DOTS=..
+++++++ local NVM_NUM_GROUPS
+++++++ NVM_NUM_GROUPS=...
+++++++ echo 3
++++++ '[' _3 = _3 ']'
+++++++ nvm_version_path v0.12.7
+++++++ local VERSION
+++++++ VERSION=v0.12.7
+++++++ '[' -z v0.12.7 ']'
+++++++ nvm_is_iojs_version v0.12.7
+++++++ case "$1" in
+++++++ return 1
+++++++ nvm_version_greater 0.12.0 v0.12.7
+++++++ local LHS
++++++++ nvm_normalize_version 0.12.0
++++++++ echo 0.12.0
++++++++ command awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
++++++++ awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
+++++++ LHS=0000012000000
+++++++ local RHS
++++++++ nvm_normalize_version v0.12.7
++++++++ echo 0.12.7
++++++++ command awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
++++++++ awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
+++++++ RHS=0000012000007
+++++++ '[' 0000012000000 -gt 0000012000007 ']'
++++++++ nvm_version_dir new
++++++++ local NVM_WHICH_DIR
++++++++ NVM_WHICH_DIR=new
++++++++ '[' -z new ']'
++++++++ '[' _new = _new ']'
++++++++ echo /usr/local/src/nvm/versions/node
+++++++ echo /usr/local/src/nvm/versions/node/v0.12.7
++++++ '[' -d /usr/local/src/nvm/versions/node/v0.12.7 ']'
++++++ VERSIONS=v0.12.7
++++++ '[' '' = true ']'
++++++ '[' -z v0.12.7 ']'
++++++ echo v0.12.7
+++++ VERSION=v0.12.7
+++++ '[' -z v0.12.7 ']'
+++++ '[' _v0.12.7 = _N/A ']'
+++++ echo v0.12.7
++++ LOCAL_VERSION=v0.12.7
++++ EXIT_CODE=0
++++ local NVM_VERSION_DIR
++++ '[' _0 = _0 ']'
+++++ nvm_version_path v0.12.7
+++++ local VERSION
+++++ VERSION=v0.12.7
+++++ '[' -z v0.12.7 ']'
+++++ nvm_is_iojs_version v0.12.7
+++++ case "$1" in
+++++ return 1
+++++ nvm_version_greater 0.12.0 v0.12.7
+++++ local LHS
++++++ nvm_normalize_version 0.12.0
++++++ echo 0.12.0
++++++ command awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
++++++ awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
+++++ LHS=0000012000000
+++++ local RHS
++++++ nvm_normalize_version v0.12.7
++++++ echo 0.12.7
++++++ command awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
++++++ awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
+++++ RHS=0000012000007
+++++ '[' 0000012000000 -gt 0000012000007 ']'
++++++ nvm_version_dir new
++++++ local NVM_WHICH_DIR
++++++ NVM_WHICH_DIR=new
++++++ '[' -z new ']'
++++++ '[' _new = _new ']'
++++++ echo /usr/local/src/nvm/versions/node
+++++ echo /usr/local/src/nvm/versions/node/v0.12.7
++++ NVM_VERSION_DIR=/usr/local/src/nvm/versions/node/v0.12.7
++++ '[' _0 '!=' _0 ']'
++++ '[' '!' -d /usr/local/src/nvm/versions/node/v0.12.7 ']'
++++ EXIT_CODE=0
++++ '[' 0 '!=' 0 ']'
++++ local NVM_VERSION_DIR
+++++ nvm_version_path v0.12.7
+++++ local VERSION
+++++ VERSION=v0.12.7
+++++ '[' -z v0.12.7 ']'
+++++ nvm_is_iojs_version v0.12.7
+++++ case "$1" in
+++++ return 1
+++++ nvm_version_greater 0.12.0 v0.12.7
+++++ local LHS
++++++ nvm_normalize_version 0.12.0
++++++ echo 0.12.0
++++++ command awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
++++++ awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
+++++ LHS=0000012000000
+++++ local RHS
++++++ nvm_normalize_version v0.12.7
++++++ echo 0.12.7
++++++ command awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
++++++ awk -F. '{ printf("%d%06d%06d\n", $1,$2,$3); }'
+++++ RHS=0000012000007
+++++ '[' 0000012000000 -gt 0000012000007 ']'
++++++ nvm_version_dir new
++++++ local NVM_WHICH_DIR
++++++ NVM_WHICH_DIR=new
++++++ '[' -z new ']'
++++++ '[' _new = _new ']'
++++++ echo /usr/local/src/nvm/versions/node
+++++ echo /usr/local/src/nvm/versions/node/v0.12.7
++++ NVM_VERSION_DIR=/usr/local/src/nvm/versions/node/v0.12.7
+++++ nvm_strip_path /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin /bin
+++++ echo /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
+++++ command sed -e 's#/usr/local/src/nvm/[^/]*/bin[^:]*:##g' -e 's#:/usr/local/src/nvm/[^/]*/bin[^:]*##g' -e 's#/usr/local/src/nvm/[^/]*/bin[^:]*##g' -e 's#/usr/local/src/nvm/versions/[^/]*/[^/]*/bin[^:]*:##g' -e 's#:/usr/local/src/nvm/versions/[^/]*/[^/]*/bin[^:]*##g' -e 's#/usr/local/src/nvm/versions/[^/]*/[^/]*/bin[^:]*##g'
+++++ sed -e 's#/usr/local/src/nvm/[^/]*/bin[^:]*:##g' -e 's#:/usr/local/src/nvm/[^/]*/bin[^:]*##g' -e 's#/usr/local/src/nvm/[^/]*/bin[^:]*##g' -e 's#/usr/local/src/nvm/versions/[^/]*/[^/]*/bin[^:]*:##g' -e 's#:/usr/local/src/nvm/versions/[^/]*/[^/]*/bin[^:]*##g' -e 's#/usr/local/src/nvm/versions/[^/]*/[^/]*/bin[^:]*##g'
++++ PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
+++++ nvm_prepend_path /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin /usr/local/src/nvm/versions/node/v0.12.7/bin
+++++ '[' -z /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin ']'
+++++ echo /usr/local/src/nvm/versions/node/v0.12.7/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
++++ PATH=/usr/local/src/nvm/versions/node/v0.12.7/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
++++ nvm_has manpath
++++ type manpath
++++ '[' -z '' ']'
+++++ manpath
++++ MANPATH=/usr/local/src/nvm/versions/node/v0.12.7/share/man:/usr/local/man:/usr/local/share/man:/usr/share/man
+++++ nvm_strip_path /usr/local/src/nvm/versions/node/v0.12.7/share/man:/usr/local/man:/usr/local/share/man:/usr/share/man /share/man
+++++ echo /usr/local/src/nvm/versions/node/v0.12.7/share/man:/usr/local/man:/usr/local/share/man:/usr/share/man
+++++ command sed -e 's#/usr/local/src/nvm/[^/]*/share/man[^:]*:##g' -e 's#:/usr/local/src/nvm/[^/]*/share/man[^:]*##g' -e 's#/usr/local/src/nvm/[^/]*/share/man[^:]*##g' -e 's#/usr/local/src/nvm/versions/[^/]*/[^/]*/share/man[^:]*:##g' -e 's#:/usr/local/src/nvm/versions/[^/]*/[^/]*/share/man[^:]*##g' -e 's#/usr/local/src/nvm/versions/[^/]*/[^/]*/share/man[^:]*##g'
+++++ sed -e 's#/usr/local/src/nvm/[^/]*/share/man[^:]*:##g' -e 's#:/usr/local/src/nvm/[^/]*/share/man[^:]*##g' -e 's#/usr/local/src/nvm/[^/]*/share/man[^:]*##g' -e 's#/usr/local/src/nvm/versions/[^/]*/[^/]*/share/man[^:]*:##g' -e 's#:/usr/local/src/nvm/versions/[^/]*/[^/]*/share/man[^:]*##g' -e 's#/usr/local/src/nvm/versions/[^/]*/[^/]*/share/man[^:]*##g'
++++ MANPATH=/usr/local/man:/usr/local/share/man:/usr/share/man
+++++ nvm_prepend_path /usr/local/man:/usr/local/share/man:/usr/share/man /usr/local/src/nvm/versions/node/v0.12.7/share/man
+++++ '[' -z /usr/local/man:/usr/local/share/man:/usr/share/man ']'
+++++ echo /usr/local/src/nvm/versions/node/v0.12.7/share/man:/usr/local/man:/usr/local/share/man:/usr/share/man
++++ MANPATH=/usr/local/src/nvm/versions/node/v0.12.7/share/man:/usr/local/man:/usr/local/share/man:/usr/share/man
++++ export MANPATH
++++ export PATH
++++ hash -r
++++ export NVM_PATH=/usr/local/src/nvm/versions/node/v0.12.7/lib/node
++++ NVM_PATH=/usr/local/src/nvm/versions/node/v0.12.7/lib/node
++++ export NVM_BIN=/usr/local/src/nvm/versions/node/v0.12.7/bin
++++ NVM_BIN=/usr/local/src/nvm/versions/node/v0.12.7/bin
++++ '[' '' = true ']'
++++ local NVM_USE_OUTPUT
++++ '[' 1 -ne 1 ']'
++++ '[' _v0.12.7 '!=' _system ']'
++++ local NVM_USE_CMD
++++ NVM_USE_CMD='nvm use --delete-prefix'
++++ '[' -n v0.12.7 ']'
++++ NVM_USE_CMD='nvm use --delete-prefix v0.12.7'
++++ '[' 1 -eq 1 ']'
++++ NVM_USE_CMD='nvm use --delete-prefix v0.12.7 --silent'
++++ nvm_die_on_prefix 0 'nvm use --delete-prefix v0.12.7 --silent'
++++ local NVM_DELETE_PREFIX
++++ NVM_DELETE_PREFIX=0
++++ case "$NVM_DELETE_PREFIX" in
++++ local NVM_COMMAND
++++ NVM_COMMAND='nvm use --delete-prefix v0.12.7 --silent'
++++ '[' -z 'nvm use --delete-prefix v0.12.7 --silent' ']'
++++ '[' -n '' ']'
++++ '[' -n '' ']'
++++ nvm_has npm
++++ type npm
++++ local NVM_NPM_PREFIX
+++++ NPM_CONFIG_LOGLEVEL=warn
+++++ npm config get prefix
++++ NVM_NPM_PREFIX=/usr/local/src/nvm/versions/node/v0.12.7
++++ nvm_tree_contains_path /usr/local/src/nvm /usr/local/src/nvm/versions/node/v0.12.7
++++ '[' -n '' ']'
++ for i in '/etc/profile.d/*.sh'
++ '[' -r /etc/profile.d/vte.sh ']'
++ . /etc/profile.d/vte.sh
+++ '[' -n '4.3.11(1)-release' -o -n '' ']'
+++ [[ ehxB == *i* ]]
+++ return 0
++ for i in '/etc/profile.d/*.sh'
++ '[' -r /etc/profile.d/Z97-byobu.sh ']'
++ . /etc/profile.d/Z97-byobu.sh
+++ '[' -n '' ']'
+++ '[' '' = byobu ']'
+++ '[' '' = byobu-screen ']'
+++ '[' '' = byobu-tmux ']'
++ for i in '/etc/profile.d/*.sh'
++ '[' -r /etc/profile.d/Z99-cloud-locale-test.sh ']'
++ . /etc/profile.d/Z99-cloud-locale-test.sh
+++ '[' -f /root/.cloud-locale-test.skip -o -f /var/lib/cloud/instance/locale-check.skip ']'
+++ locale
+++ locale_warn
+++ local bad_names= bad_lcs= key= val= var= vars=
+++ local w1 w2 w3 w4 remain
+++ '[' '' = zsh ']'
+++ read -r w1 w2 w3 w4 remain
+++ case "$w1" in
+++ key=LANG
+++ val=en_US.UTF-8
+++ val=en_US.UTF-8
+++ val=en_US.UTF-8
+++ vars=' LANG=en_US.UTF-8'
+++ read -r w1 w2 w3 w4 remain
+++ case "$w1" in
+++ key=LANGUAGE
+++ val=
+++ val=
+++ val=
+++ vars=' LANG=en_US.UTF-8 LANGUAGE='
+++ read -r w1 w2 w3 w4 remain
+++ case "$w1" in
+++ key=LC_CTYPE
+++ val='"en_US.UTF-8"'
+++ val='en_US.UTF-8"'
+++ val=en_US.UTF-8
+++ vars=' LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE=en_US.UTF-8'
+++ read -r w1 w2 w3 w4 remain
+++ case "$w1" in
+++ key=LC_NUMERIC
+++ val='"en_US.UTF-8"'
+++ val='en_US.UTF-8"'
+++ val=en_US.UTF-8
+++ vars=' LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE=en_US.UTF-8 LC_NUMERIC=en_US.UTF-8'
+++ read -r w1 w2 w3 w4 remain
+++ case "$w1" in
+++ key=LC_TIME
+++ val='"en_US.UTF-8"'
+++ val='en_US.UTF-8"'
+++ val=en_US.UTF-8
+++ vars=' LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE=en_US.UTF-8 LC_NUMERIC=en_US.UTF-8 LC_TIME=en_US.UTF-8'
+++ read -r w1 w2 w3 w4 remain
+++ case "$w1" in
+++ key=LC_COLLATE
+++ val='"en_US.UTF-8"'
+++ val='en_US.UTF-8"'
+++ val=en_US.UTF-8
+++ vars=' LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE=en_US.UTF-8 LC_NUMERIC=en_US.UTF-8 LC_TIME=en_US.UTF-8 LC_COLLATE=en_US.UTF-8'
+++ read -r w1 w2 w3 w4 remain
+++ case "$w1" in
+++ key=LC_MONETARY
+++ val='"en_US.UTF-8"'
+++ val='en_US.UTF-8"'
+++ val=en_US.UTF-8
+++ vars=' LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE=en_US.UTF-8 LC_NUMERIC=en_US.UTF-8 LC_TIME=en_US.UTF-8 LC_COLLATE=en_US.UTF-8 LC_MONETARY=en_US.UTF-8'
+++ read -r w1 w2 w3 w4 remain
+++ case "$w1" in
+++ key=LC_MESSAGES
+++ val='"en_US.UTF-8"'
+++ val='en_US.UTF-8"'
+++ val=en_US.UTF-8
+++ vars=' LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE=en_US.UTF-8 LC_NUMERIC=en_US.UTF-8 LC_TIME=en_US.UTF-8 LC_COLLATE=en_US.UTF-8 LC_MONETARY=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8'
+++ read -r w1 w2 w3 w4 remain
+++ case "$w1" in
+++ key=LC_PAPER
+++ val='"en_US.UTF-8"'
+++ val='en_US.UTF-8"'
+++ val=en_US.UTF-8
+++ vars=' LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE=en_US.UTF-8 LC_NUMERIC=en_US.UTF-8 LC_TIME=en_US.UTF-8 LC_COLLATE=en_US.UTF-8 LC_MONETARY=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 LC_PAPER=en_US.UTF-8'
+++ read -r w1 w2 w3 w4 remain
+++ case "$w1" in
+++ key=LC_NAME
+++ val='"en_US.UTF-8"'
+++ val='en_US.UTF-8"'
+++ val=en_US.UTF-8
+++ vars=' LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE=en_US.UTF-8 LC_NUMERIC=en_US.UTF-8 LC_TIME=en_US.UTF-8 LC_COLLATE=en_US.UTF-8 LC_MONETARY=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 LC_PAPER=en_US.UTF-8 LC_NAME=en_US.UTF-8'
+++ read -r w1 w2 w3 w4 remain
+++ case "$w1" in
+++ key=LC_ADDRESS
+++ val='"en_US.UTF-8"'
+++ val='en_US.UTF-8"'
+++ val=en_US.UTF-8
+++ vars=' LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE=en_US.UTF-8 LC_NUMERIC=en_US.UTF-8 LC_TIME=en_US.UTF-8 LC_COLLATE=en_US.UTF-8 LC_MONETARY=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 LC_PAPER=en_US.UTF-8 LC_NAME=en_US.UTF-8 LC_ADDRESS=en_US.UTF-8'
+++ read -r w1 w2 w3 w4 remain
+++ case "$w1" in
+++ key=LC_TELEPHONE
+++ val='"en_US.UTF-8"'
+++ val='en_US.UTF-8"'
+++ val=en_US.UTF-8
+++ vars=' LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE=en_US.UTF-8 LC_NUMERIC=en_US.UTF-8 LC_TIME=en_US.UTF-8 LC_COLLATE=en_US.UTF-8 LC_MONETARY=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 LC_PAPER=en_US.UTF-8 LC_NAME=en_US.UTF-8 LC_ADDRESS=en_US.UTF-8 LC_TELEPHONE=en_US.UTF-8'
+++ read -r w1 w2 w3 w4 remain
+++ case "$w1" in
+++ key=LC_MEASUREMENT
+++ val='"en_US.UTF-8"'
+++ val='en_US.UTF-8"'
+++ val=en_US.UTF-8
+++ vars=' LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE=en_US.UTF-8 LC_NUMERIC=en_US.UTF-8 LC_TIME=en_US.UTF-8 LC_COLLATE=en_US.UTF-8 LC_MONETARY=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 LC_PAPER=en_US.UTF-8 LC_NAME=en_US.UTF-8 LC_ADDRESS=en_US.UTF-8 LC_TELEPHONE=en_US.UTF-8 LC_MEASUREMENT=en_US.UTF-8'
+++ read -r w1 w2 w3 w4 remain
+++ case "$w1" in
+++ key=LC_IDENTIFICATION
+++ val='"en_US.UTF-8"'
+++ val='en_US.UTF-8"'
+++ val=en_US.UTF-8
+++ vars=' LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE=en_US.UTF-8 LC_NUMERIC=en_US.UTF-8 LC_TIME=en_US.UTF-8 LC_COLLATE=en_US.UTF-8 LC_MONETARY=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 LC_PAPER=en_US.UTF-8 LC_NAME=en_US.UTF-8 LC_ADDRESS=en_US.UTF-8 LC_TELEPHONE=en_US.UTF-8 LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=en_US.UTF-8'
+++ read -r w1 w2 w3 w4 remain
+++ case "$w1" in
+++ key=LC_ALL
+++ val=
+++ val=
+++ val=
+++ vars=' LANG=en_US.UTF-8 LANGUAGE= LC_CTYPE=en_US.UTF-8 LC_NUMERIC=en_US.UTF-8 LC_TIME=en_US.UTF-8 LC_COLLATE=en_US.UTF-8 LC_MONETARY=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 LC_PAPER=en_US.UTF-8 LC_NAME=en_US.UTF-8 LC_ADDRESS=en_US.UTF-8 LC_TELEPHONE=en_US.UTF-8 LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=en_US.UTF-8 LC_ALL='
+++ read -r w1 w2 w3 w4 remain
+++ bad_lcs=
+++ '[' -n '' ']'
+++ return 0
+++ unset locale_warn
++ unset i
+ prog=codedeploy-agent
+ AGENT_ROOT=/opt/codedeploy-agent/
+ INSTALLER=/opt/codedeploy-agent/bin/install
+ BIN=/opt/codedeploy-agent/bin/codedeploy-agent
+ case "$1" in
+ echo 'Usage: /etc/init.d/codedeploy-agent {start|stop|status|restart}'
Usage: /etc/init.d/codedeploy-agent {start|stop|status|restart}
prod-app-1 i-XXXXXXX ubuntu ~ $`


`$onlyOneDay will` => `$onlyOneDay (if true) will`


Nit: is the cast required?


`st->level`


Not really, this is to make sure we align with the previous line, for manual inspection.


oops, that's sloppy indeed!


True, but it seems bad to sometimes write `require(...).default` instead of `import` to mean "import now"; and what if the module is already loaded?

Note `coffee-script` is not an ES module, so I think it would just be `require("coffee-script")`.


`checkRegion()` is passed to `FlxRect#equals()` via `FlxImageFrame.findFrame()` where that happens.


Maybe `platformio-ide:target:(build|upload|clean)`?


I saw this same pattern in the SslStream code, and it leads to us not being able to diagnose the cause for failures when they do occur.  Why are we translating any exceptions here to "InternalError"?


@khataev this commit is to change the version in the published gem. Here are the code changes since the last version change: https://github.com/thoughtbot/factory_girl_rails/compare/v4.5.0...v4.6.0


What does it means for a null SafeFreeSslCredentials to be passed as an argument?


@dusek please verify :grinning:


Hey, can I get these data files?


Why do we need the loop?


thanks!


`+@PART[*]:HAS[ModuleHeatShield,~RSSROConfig[*]:AFTER[DeadlyReentry]:NEEDS[RealSolarSystem,!RealismOverhaul]`

You have unbalanced the brackets here :)
The HAS part misses an ending bracket


Should we only be catching and handling specific exceptions?


@bgerstle thanks, looks fine :+1:


Not sure if this is a good idea, if this function gets called every frame this would incur a considerable performance overhead.


These do help, Lauryn! Thank you!


Leon Timmermans <notifications@github.com> wrote:

> Any reason in particular for replacing that one test, instead of
> adding a test case?

None. I usually try to condense tests where it makes sense. I believe
that users will try to avoid tests when they become too long.

so long
Maik


This is suspicious, may be best to use a cached static variables in this func.


In case someone introduces another type into the hierarchy.


See previous comments about not calling ReleaseHandle explicitly like this.


Wouldn't ```typeof(AddImport.AbstractAddImportCodeFixProvider<>))``` be updated in that case?


If you want to test this with curl or whatever just make sure to set on the
**Requests Headers**: `Accept-Encoding:gzip, deflate`
and you should receive back in the
**Response headers**: `Content-Encoding: gzip`


TeamCity Open-source Libraries :: ConfigInjector :: CI [Build 2.0.486.0](http://build01:8888/viewLog.html?buildId=14058&buildTypeId=ConfigInjector_CI) is now running


kjnkjn


Can't say for sure, but server browser works much worse now, I see json data in console, but nothing in server browser. I need to refresh a lot to get a list. Or maybe it is my internet.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27003/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27004/testReport/) for this commit**


112796613_DesicDehum (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2089 of 2089 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


What does the "yet" added here mean... do we plan to add support for it by RTM?


The RGWFileHandle::stat() method fills in the stat members only.  Originally at least, this was the actual effect rgw_stat().  Now that it isn't maybe this method should be renamed.  Maybe "fill_stat()" would be better.  Let's do it later, though, there might be other stat changes needed anyway, to get final rsync behavior?


@Alberth289346 @sadger I will try to change the code if that could be nicer


Never mind.
:+1:


What do we do if none of those conditions are verified?


The previous link seemed to be the correct one. Not sure why though.


https://github.com/mperednya/scheduler-google-calendar/commit/62f83e6bae08a33415a19fb583971d976b31ef62#diff-b76fde92c3c3e70a1e5e87b8abba2a13L165
Seems like the commit changes the default behavior of a component.
The plugin will use a timezone from a mapped google calendar by default instead of using previously hardcoded "Europe/Minsk", due to code [here](https://github.com/DHTMLX/scheduler-google-calendar/blob/master/src/google_proxy.php#L20) and [here](https://github.com/DHTMLX/scheduler-google-calendar/blob/master/src/google_proxy.php#L72 ).
That may require code changes (specifying a timezone) in apps where it had worked correctly before.

Need to either make this change explicit (add a comment somewhere near 'timezone' property definition) and make sure it won't break anything or use "Europe/Minsk" as a default timezone so the behavior of unconfigured plugin won't change.


TeamCity Open-source Libraries :: ConfigInjector :: CI [Build 2.0.486.0](http://build01:8888/viewLog.html?buildId=14058&buildTypeId=ConfigInjector_CI) outcome was **SUCCESS**
Summary: Tests passed: 38 Build time: 00:03:27


Who calls these methods?  I thought this was a Unix-only type, which makes me wonder why we're including methods that then just always throw.


Great :tada:


I feel caught between conventions :(
All of the conf parameters are lowercase but scala demands camelCase . Do you think this is ok as is or should I just choose one?


Ah putain je déteste cette putain de fonction le récursif c'est tellement la merde.
M'enfin niveau vitesse ça représente entre 0,1 et 3% du temps de calcul de l'algorithme, tandis que toutes les instances d'ordonner prennent environ 12% du temps de calcul.

Enfin je trouvais A* légèrement long (presque le dixième de seconde, généralement 2* plus que la recherche en pronfondeur) mais je pense que c'est ok, et c'est finalement le genre d'ordre de grandeur auquel on s'attend (et qu'on va peut être devoir calculer voire implémenter, d'ailleurs?)


Thanks for the feedback.
I updated the README and got rid of the auto-degradation.


TeamCity DNN JavaScript Libraries :: CI [Build 140](http://teamcity.engagesoftware.com/viewLog.html?buildId=418&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 140](http://teamcity.engagesoftware.com/viewLog.html?buildId=418&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:7


Thanks, this is better. Oh, bonus points if you make a method on MD5Stream for `final` that automatically calls `flush`.


I think we need to user sinon fake server before this line. Now it's gives me ajax failed reponses on local environment:

GET http://127.0.0.1:8000/test?order=asc&sort_by=attrA 404 (Not Found)
GET http://127.0.0.1:8000/test?order=desc&sort_by=attrB 404 (Not Found)


Nit: might be clearer if it was ```prefixLength + signature.Length``` instead of ```signature.Length + prefixLength```.   Similarly above when the array is constructed, it'd be clearer if the order of the lengths matched the order in which the respective pieces are in the array.


Sorry, I meant GtkTreePaths.

Filing a bug against pygobject instead of this PR makes sense.  Here's my pygobject3 info to help you file the bug:

```
~ ❯ brew info pygobject3
pygobject3: stable 3.18.2 (bottled)
GLib/GObject/GIO Python bindings for Python 3
https://live.gnome.org/PyGObject
/usr/local/Cellar/pygobject3/3.18.2 (164 files, 3.4M) *
  Built from source with: --with-python3
From: https://github.com/Homebrew/homebrew/blob/master/Library/Formula/pygobject3.rb

```


Please re-add the ```int``` here


SingalSampler -> SignalSampler


@nickjs Looks like "that" is duplicated as it says "that that." Can you fix?


In places like this where we take buffer/offset/count, are there asserts we can add?


@daveaglick: I feel like we need some documentation on this.  I used the `InputFolder` and `OutputFolder` variables in my config, which broke with this update.  How do I use these new variables in the config?


Thanks, Aaron!

Hope you had a good weekend. Look forward to our meeting tonight. I didn't
bring my laptop today, but perhaps you could help me think about some
strategies for tackling my project? In particular, how each part flows into
the other, and what languages/technologies I'd need to use at each point.

My plan is to use the Lending Club API
<https://www.lendingclub.com/developers/lc-api.action> to access my account
info, store this data in a DB and then do some visualizations with D3.js.

Thanks!
Erin

On Mon, Feb 1, 2016 at 10:19 AM, Ɛərɪn VonderHaar <notifications@github.com>
wrote:

> On line 104, you set button to the button for Exercise #1. You never
> updated it to refer to the button in Exercise #2.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/erinallard/HackbrightAssessments_4/commit/dfb162a93546ceae1246c3f980af28302335652e#commitcomment-15807001>
> .
>


Is this the right exception type?  The string needs to be in a resource, too.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27006/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27007/testReport/) for this commit**


You're talking about features we haven't yet developed though... that's outside the scope of this pull request.

ChangeSets may either alter, or supersede these instructions. Until such features exist, the below code is necessary.

Should I simply remove this section and not address triggered publishing at all?


newline


I wish you raised this as an issue as I could have then waited for the pull request before creating the RC last night.

Under what conditions (code sample?) does the crash manifest itself?

As I see no changes to tests then how do we prevent the code from reverting back and reintroducing the defect?


Thank you! Was about to fix it. Dont know what i did wrong there...


Don't put Providers to configuration builder


112796613_DesicDehum (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


* `Дякувати Господу,` без цього. Ніяких Господів, Аллахів чи чогось такого — це може образити чиїсь почуття. Краще перекласти `На щастя`.


ok this is good


LGTM


Done: 2f429e5


The extension provides a default config value for the owner; The owner itself though is the item being configured, so it's read there, expecting it to fall back to this. I've used this pattern several times.

If we read the config just from the extension, then you could only ever have one global value, and not one for each class type.


Hm, after looking through the lang files I found that some of them already contain translation strings.
If we let them in, then they could be reused in the future.


Pas certain que ça soit le meilleur moment pour le faire, mais comme ça c'est fait, et je suis sûr de ne pas créer de nouveaux conflits pour le prochain merge vers master.


please test


Idem 43fb4bd


1) Don't create multiple instances of any provider
2) We don't need to have separate "hex" provider
3) Don't use providers directly


This does not make Qt5 work ...


Podes ver os acordes na imagem em anexo. Tirei uma foto ao hinário cifrado (se não tens precisas de comprar um, é muito bom e ajuda imenso a aprender acordes)

Pedro Esteves

De: neburpedrosa [mailto:notifications@github.com]
Enviada: segunda-feira, 1 de Fevereiro de 2016 20:29
Para: psalterio/repository
Cc: Pedro Esteves
Assunto: Re: [repository] Update estou_seguindo_233.tex (e78a4cb)

Então é mesmo "seguindo a Jesus", quanto aos acordes alguém pode ver quais
são os originais?
Em 01/02/2016 8:05 da tarde, "Pedro Esteves" <notifications@github.com>
escreveu:

> O título original deverá estar na versão do hinario, que é o hino 474
>
> Verifiquem lá
>
> Abraço
>
> Pedro Esteves
>
> No dia 01/02/2016, às 19:11, neburpedrosa <notifications@github.com
> <mailto:notifications@github.com>> escreveu:
>
> Eu até andei à procura da música, mas com títulos diferentes era
> complicado, bem visto! O título "estou seguindo" é da separata do camporee
> de 2011, esse título "seguindo a Jesus" aparece em alguma?
> Em 01/02/2016 5:34 da tarde, "Psaltério" <notifications@github.com<mailto:
> notifications@github.com>>
> escreveu:
>
> > Esta música já está introduzida, mas com um titulo ligeiramente diferente
> > "Seguindo a Jesus" com o id 28:
> >
> https://github.com/psalterio/repository/blob/master/songs/pt/seguindo_a_jesus_28.tex
> >
> > O melhor é apagar esta com id 233 e transferir os acordes para a outra.
> Se
> > achares necessário pode-se mudar o titulo da 28 para "Estou seguindo". O
> > ideal seria encontrar o titulo original.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15805711
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub<
> https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15808516
> >.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15809779>
> .
>

—
Reply to this email directly or view it on GitHub<https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15810302>.


Thanks for the review. It's updated.


F com letra maiúscula? Melhor né?


Huh. You're exactly right.

Although, philosophically, I disagree a bit: if the code is not obviously correct or incorrect to begin with, maybe it is already broken?


Sounds good to me, CFD should be in before I get to the option models


Do we need to pass getState() includeDefaults true here? It seems we want to avoid default params in generated urls, not to include them.


What else would this be? Should this raise an exception instead?


canView() API should not infer from the current member if it is given an explicit object.

The idea of the state is that it is independent of the current member; If an anonymous user cannot view it, then it's state is protected, regardless of whether or not the current user can view it.

In fact, the current user has no relevance at all in this operation, since the current user is simply preparing the visibility of the object for other users to view. :)


Thanks, I know it's small/nit-picky, but allows calling code without the entire database to use this overload.


Eu posso vender o hinário para quem precisar e ainda faço desconto de amigo
:)
Em 01/02/2016 21:11, "Pedro Esteves" <notifications@github.com> escreveu:

> Podes ver os acordes na imagem em anexo. Tirei uma foto ao hinário cifrado
> (se não tens precisas de comprar um, é muito bom e ajuda imenso a aprender
> acordes)
>
> Pedro Esteves
>
> De: neburpedrosa [mailto:notifications@github.com]
> Enviada: segunda-feira, 1 de Fevereiro de 2016 20:29
> Para: psalterio/repository
> Cc: Pedro Esteves
> Assunto: Re: [repository] Update estou_seguindo_233.tex (e78a4cb)
>
> Então é mesmo "seguindo a Jesus", quanto aos acordes alguém pode ver quais
> são os originais?
> Em 01/02/2016 8:05 da tarde, "Pedro Esteves" <notifications@github.com>
> escreveu:
>
> > O título original deverá estar na versão do hinario, que é o hino 474
> >
> > Verifiquem lá
> >
> > Abraço
> >
> > Pedro Esteves
> >
> > No dia 01/02/2016, às 19:11, neburpedrosa <notifications@github.com
> > <mailto:notifications@github.com>> escreveu:
> >
> > Eu até andei à procura da música, mas com títulos diferentes era
> > complicado, bem visto! O título "estou seguindo" é da separata do
> camporee
> > de 2011, esse título "seguindo a Jesus" aparece em alguma?
> > Em 01/02/2016 5:34 da tarde, "Psaltério" <notifications@github.com
> <mailto:
> > notifications@github.com>>
> > escreveu:
> >
> > > Esta música já está introduzida, mas com um titulo ligeiramente
> diferente
> > > "Seguindo a Jesus" com o id 28:
> > >
> >
> https://github.com/psalterio/repository/blob/master/songs/pt/seguindo_a_jesus_28.tex
> > >
> > > O melhor é apagar esta com id 233 e transferir os acordes para a
> outra.
> > Se
> > > achares necessário pode-se mudar o titulo da 28 para "Estou seguindo".
> O
> > > ideal seria encontrar o titulo original.
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15805711
> > >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub<
> >
> https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15808516
> > >.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15809779>
>
> > .
> >
>
>
> —
> Reply to this email directly or view it on GitHub<
> https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15810302>.
>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15811251>
> .
>


fixing this import


This breaks `test_youtube_format_selection` from `test/test_YoutubeDL.py`. I don't have too much time now to check how to fix it, could you take a look?


Tego nigdzie nie używasz ;)


This is misleading, and won't be true for some time.  Only a few fonts have source files.


Yeah @stevie-mayhew told me off for that. :)


~~слідуючі~~ →**наступні**, **такі**


h


Super!

Warto dorobić teraz obsługę błędów, czyli jeśli ustawię w hashu jakieś cyferki, to żeby mi na stronę główną przekierowało.


The visibility check is done in getRecordState at the end of this method.


Melhor mesmo hahahaha não me atentei a isso

Em seg, 1 de fev de 2016 19:11, Diogo Moretti <notifications@github.com>
escreveu:

> F com letra maiúscula? Melhor né?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Mendrone/forum/commit/023f6bdda86133f50d67161e17f81a0442a2f5dc#commitcomment-15811256>
> .
>


sounds good, added trello card to revisit the duplication between `SecurityDatabaseKey` and `MarketHoursDatabase.Key`


Ia agora mesmo sacar do meu e enviar os acordes. D? mesmo muito jeito!

Abra?o a todos,

Tiago Torre

No dia 01/02/2016, ?s 21:14, caixeiro <notifications@github.com<mailto:notifications@github.com>> escreveu:

Eu posso vender o hin?rio para quem precisar e ainda fa?o desconto de amigo
:)
Em 01/02/2016 21:11, "Pedro Esteves" <notifications@github.com<mailto:notifications@github.com>> escreveu:

> Podes ver os acordes na imagem em anexo. Tirei uma foto ao hin?rio cifrado
> (se n?o tens precisas de comprar um, ? muito bom e ajuda imenso a aprender
> acordes)
>
> Pedro Esteves
>
> De: neburpedrosa [mailto:notifications@github.com]
> Enviada: segunda-feira, 1 de Fevereiro de 2016 20:29
> Para: psalterio/repository
> Cc: Pedro Esteves
> Assunto: Re: [repository] Update estou_seguindo_233.tex (e78a4cb)
>
> Ent?o ? mesmo "seguindo a Jesus", quanto aos acordes algu?m pode ver quais
> s?o os originais?
> Em 01/02/2016 8:05 da tarde, "Pedro Esteves" <notifications@github.com<mailto:notifications@github.com>>
> escreveu:
>
> > O t?tulo original dever? estar na vers?o do hinario, que ? o hino 474
> >
> > Verifiquem l?
> >
> > Abra?o
> >
> > Pedro Esteves
> >
> > No dia 01/02/2016, ?s 19:11, neburpedrosa <notifications@github.com<mailto:notifications@github.com>
> > <mailto:notifications@github.com>> escreveu:
> >
> > Eu at? andei ? procura da m?sica, mas com t?tulos diferentes era
> > complicado, bem visto! O t?tulo "estou seguindo" ? da separata do
> camporee
> > de 2011, esse t?tulo "seguindo a Jesus" aparece em alguma?
> > Em 01/02/2016 5:34 da tarde, "Psalt?rio" <notifications@github.com<mailto:notifications@github.com>
> <mailto:
> > notifications@github.com<mailto:notifications@github.com>>>
> > escreveu:
> >
> > > Esta m?sica j? est? introduzida, mas com um titulo ligeiramente
> diferente
> > > "Seguindo a Jesus" com o id 28:
> > >
> >
> https://github.com/psalterio/repository/blob/master/songs/pt/seguindo_a_jesus_28.tex
> > >
> > > O melhor ? apagar esta com id 233 e transferir os acordes para a
> outra.
> > Se
> > > achares necess?rio pode-se mudar o titulo da 28 para "Estou seguindo".
> O
> > > ideal seria encontrar o titulo original.
> > >
> > > -
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15805711
> > >
> > > .
> > >
> >
> > -
> > Reply to this email directly or view it on GitHub<
> >
> https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15808516
> > >.
> >
> > -
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15809779>
>
> > .
> >
>
>
> -
> Reply to this email directly or view it on GitHub<
> https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15810302>.
>
>
> -
> Reply to this email directly or view it on GitHub
> <https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15811251>
> .
>

-
Reply to this email directly or view it on GitHub<https://github.com/psalterio/repository/commit/e78a4cb121cbf1fc53bb7ba2792e31461cc705bb#commitcomment-15811310>.


That's a pretty elegant way to handle it :+1:


Why do we need to trim these? Is Heroju doing something silly?


this is all about names and ids... so you could call it `axis_ids.js` or something like that


Also changed:  signature check (we're not using direct Github updating from upsteam), browserstats disabled & check refer toggled off.


Do we need to author code commits? I guess we can just leave it anonymous with more imperative style like:

# Make sure there is convenienceClass to handle loading indicator


Looks really good :) Might be worth putting some screenshots of the dashboard in for clarity and to break up the text a bit.


No, because if a file is getting deleted, the reference to the DBFile values are already getting removed. The use cases will be one of:
- A file is getting replaced, and the before-value is getting deleted
- A record is getting unpublished, and the stage value differs from the live value
- A record is getting deleted / archived

In which case, the current action is already going to delete the reference.


Sure good idea.


It seems weird to me that `postPayments` returns the transfers array but we'll change that later


I'm not familiar with `sessionStorage`, is this line just setting the key of `voa_form` to a value of the form data? Was looking through the docs and only saw the `setItem` and `getItem` functions on `sessionStorage`.


Ładna domena!


I think so; Good idea.


this doesn nothing, check makefiles in camera_v2 folder


I'm going to revert this change; A different fix was applied to the 3.x branch.


This appears to not be threadsafe. I'd add a comment here about that.


Yep that's right. :)


I'd also mention the specific mutex needed to use this safely.


**Р**егулярні


this is for motorola cameras afaik


I think you'll also want to remove the tests you added in base/special/trig.jl


Was added in aa30e381839e61398834cc362d3f8b0406f06abc, but the original code didn't need or have that.  I don't *think* it's required.


@FlashHappy78 , where do you get caving in?...You mean by us being able to make a rule, and xda help enforce it?..You mean our pissing in peoples cheerios for the ones who dont ask permission for unofficial build releases, in turn getting their threads closed and/or moved to our community for utter control?..You mean being able to verify every single word that gets spoken about the rom, information given out about the rom, and being able to make sure that all info given is legit and true?...If so, yeah, i guess we caved in for "the man"..The man being us, cause we win here....


this shouldnt be like this


@megawac do you test with lodash too (in the test harness?)


Hi Mini, :)

isn't the bundle pattern also part of the application.ini?

https://github.com/pingworks/dash/blob/master/backend/application/configs/application.ini#L14

Jenkins: ok to test!


This extension isn't specific to File versioning though; It only deals with versioned DataObjects. In which case, even if the underlying filesystem item is removed, the dataobject itself is still archived.


[`eachLimit`](https://github.com/caolan/async#each) is handy for this kind of thing.


Cow does that during release. If this PR is accepted, I can run a translation synchronisation though, which will make those strings available on transifex. Prior to merge it might be a bit pre-emptive, do you agree?


@benrudolph this should be `page_breadcrumbs` the page looks very different from the rest as a result


Sounds good.


Thanks for letting me know about that. Issue was if the user had no emails or phone numbers on file. Checked for null and now it's ok again. That insert into sync failure, can you let me know if that error shows up again? Not sure where that is coming from.


Why a class check? What else could this be? Maybe this should be:

```ruby
thread = @pipelines[pipeline_id].thread
thread ? thread.alive? : false
```


Good idea.


> The only way I could find to open a file was port-specific.

Indeed, implementation of open() is port-specific. Actually, it's object class specific: there can be many objects which implement file-like (== stream) interface, each requiring construction in a special way, but implementing standard stream interface. And while implementation of open() is port specific, each port provides standard Python's open() implementation. If you really need to access that from C, that can be done (by making function public).

> seek or read from C code.

See mp_stream_p_t and stream.c . Seek is implemented via ioctl.

 > streams also don't seem to support "file-like" objects.

Streams *are* file-like objects. Currently, only native types are supported, not instance types. Nobody needed that, that's why. Well, I could have needed them - that would allow to fully port CPython's http.client and similar classes and all other modules which depend on them. But that would be mostly academic exercise, as those CPython classes are unbeautiful bloat, and wouldn't be useful for MicroPython targets anyway. While adding stream->instance adapters would add bunch of code, again, which haven't been needed by anyone. And as you implement this code in C, need for them is orthogonal for this code. o if you think we should need them, please open separate ticket.

> (albeit through one layer of indirection) call the stream API.

The whole idea of stream API is to be efficient, and have indirection only where there would be slow path anyway (currently, not have, per above).


SiteTree::doUnpublish has been left intact as a SiteTree-specific override.


I know what delta and stuff is. I just missed the scaler, which makes perfect technical sense but is not intuitive when it comes to buttons, which only have two states (on/off). It might make sense for speedup/down but for firing a weapon? Hmmm… 0.5 means pulling the gun trigger only half way :-D


Be mindful of the commit messages. Try to explain better what you've done.


ah oops, thanks i was going off of the `page-title` that was there previously


The convention for a C++ class is to name the header file with exactly the same name as the .cpp file, only changing the extension from .cpp to .h. Note that file names *are case sensitive* in Linux. Therefore, could you please rename your header file accordingly?


Ah, thanks-- this looks like just a straight bug. I'll remove this TODO.


makes sense though i wondered why it looked funny haha


@hyoklee - can you copy the data files to our ftp server?


@tremainebuchanan why not have an object that has attributes that indicate the group and size?  that way we don't treat it desperately - just one array of items... based on those items you place them in the appropriate positions and size?  I think this way is a little too kludgy.


Excelente, desconocía eso de:** sh TR10TOOL.sh**, al ejecutar el script de esta manera he logrado solucionar algunas alertas. Gracias!!


Без разницы. Сейчас нормально


@tremainebuchanan What happens when there is no news items?  This code wouldn't fail elegantly.


NM, this is an old commit, moving to the PR.


Se volaron la referencia y rompieron los link revisar cambiar  por
Comunidad

Comunidad


* початі → почат**и**
* або початку лінії в багатолінійному коді → початку рядка в багаторядковому режимі.


amami abderahim


Moving this comment to the proper spot.


this is the Hello to Hello-World...


There is a balance. One word commit messages are not precise. I real projects, you could face requirements to document your commits with quite long messages. I others, Project owners want you to squash your commits. At this stage of your learning experience time is not an issue so please be more verbose in your messages.


@tremainebuchanan while the problem with the reference is solved here, it would be reintroduced in the javascript app.


yeah I believe so.. underscore just gets overridden in `node_modules` before the tests are run.


fais un jsonHelper du coup et change le case a


@jreadey It won't fit. We have only 44G left on FTP.  @jgallagher59701 Do you have an Internet storage space (e.g., anonymous FTP) for 150G that I can upload?


It should be fine to look for "nobody" and then fall back to "nfsnobody". That should cover pretty much any OS.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27016/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27015/testReport/) for this commit**


No, this is simply the default implementation of Versioned::doUnpublish, intended to ensure that all versioned objects can have doPublish() invoked on them.

SiteTree has a specific implementation of this method, and that's fine. It has a lot of extra work it has to do regarding linked assets, virtual pages, etc.


Right! Gracias


why shrinkwraps?


112796613_DesicDehum (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (957 of 957 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.87%25-green.svg)


its from lg msm8226 they take it from google


крестики средствами html не задашь, к сожалению. это придется через css делать (если считаешь, что нужно)


[R/feature_ignore_singletons.R:37:15:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/feature_ignore_singletons.R#L37) *style:* **Commas should never have a space before.**
```r
    segsites[ , !is_singleton]
             ~^
```
[R/feature_ignore_singletons.R:48:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/feature_ignore_singletons.R#L48) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_msms_arg.ign_singletons <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_ignore_singletons.R:52:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/feature_ignore_singletons.R#L52) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_scrm_arg.ign_singletons <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_ignore_singletons.R:56:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/feature_ignore_singletons.R#L56) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_seqgen_arg.ign_singletons <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_mutation.R:140:9:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/feature_mutation.R#L140) *style:* **Commented code should be removed.**
```r
#       model <- addFeature(model, "gamma.categories", parameter=categories.number)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_mutation.R:143:7:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/feature_mutation.R#L143) *style:* **Commented code should be removed.**
```r
#     return(model)
      ^~~~~~~~~~~~~
```
[R/feature_mutation.R:152:5:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/feature_mutation.R#L152) *style:* **Commented code should be removed.**
```r
#   model <- addFeature(model, 'mutation', parameter = middle_rate, group = group)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_recombination.R:47:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/feature_recombination.R#L47) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_seqgen_arg.recombination <- ignore_par
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_selection.R:178:36:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/feature_selection.R#L178) *style:* **Commas should never have a space before.**
```r
                        n_pop, " " , paste(start_freq, collapse = " "), " ",
                                  ~^
```
[R/feature_selection.R:191:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/feature_selection.R#L191) *style:* **lines should not be more than 80 characters.**
```r
                         ifelse(feature$get_start(), 0, feature$get_time()), ", ",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_selection.R:202:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/feature_selection.R#L202) *style:* **lines should not be more than 80 characters.**
```r
                         ifelse(feature$get_start(), 0, feature$get_time()), ", ",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_sumstats.R:18:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/feature_sumstats.R#L18) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_msms_arg.seg_sites_feat <- conv_to_ms_arg.seg_sites_feat
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_sumstats.R:22:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/feature_sumstats.R#L22) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_scrm_arg.seg_sites_feat <- conv_to_ms_arg.seg_sites_feat
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/feature_sumstats.R:26:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/feature_sumstats.R#L26) *style:* **Variable and function names should not be longer than 30 characters.**
```r
conv_to_seqgen_arg.seg_sites_feat <- conv_to_ms_arg.seg_sites_feat
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/import_popgenome.R:17:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/import_popgenome.R#L17) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.segsites.GENOME <- function(data, only_synonymous = FALSE, ...) {
^~~~~~~~~~~~~~~~~~
```
[R/import_popgenome.R:41:43:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/import_popgenome.R#L41) *style:* **Commas should never have a space before.**
```r
      seg_sites <- bam[c(pops, outgroup), , drop = FALSE]
                                         ~^
```
[R/interface_abc.R:86:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/interface_abc.R#L86) *style:* **lines should not be more than 80 characters.**
```r
        warning("Value of the ", stat$get_name(), " statistic is not a vector. ",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/model_getters.R:74:21:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/model_getters.R#L74) *style:* **Commas should never have a space before.**
```r
  if (sum(llm[group , c(1:2, 4:5)]) == 0) return(llm[group , 3])
                   ~^
```
[R/model_getters.R:74:60:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/model_getters.R#L74) *style:* **Commas should never have a space before.**
```r
  if (sum(llm[group , c(1:2, 4:5)]) == 0) return(llm[group , 3])
                                                          ~^
```
[R/model_getters.R:81:25:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/model_getters.R#L81) *style:* **Commas should never have a space before.**
```r
  min(which(cumsum(llm[ , "number"]) >= locus))
                       ~^
```
[R/model_getters.R:124:46:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/model_getters.R#L124) *style:* **Commas should never have a space before.**
```r
  numbers <- get_locus_length_matrix(model)[ , "number"]
                                            ~^
```
[R/model.R:93:39:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/model.R#L93) *style:* **Commas should never have a space before.**
```r
  sum(get_locus_length_matrix(model)[ , c(1:2, 4:5)]) > 0
                                     ~^
```
[R/model_simulate.R:36:3:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/model_simulate.R#L36) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  }, mc.set.seed = TRUE, mc.cores = cores)
  ^
```
[R/parameter.R:132:11:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/parameter.R#L132) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      if ((!is.numeric(value)) || length(value) != 1) {
          ^
```
[R/segsites.R:18:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/segsites.R#L18) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.matrix.segsites <- function(x, ...) get_snps(x)
^~~~~~~~~~~~~~~~~~
```
[R/segsites.R:31:19:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/segsites.R#L31) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  create_segsites((matrix(c(1, 1, 0, 1, 1,
                  ^
```
[R/segsites.R:96:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/segsites.R#L96) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.segsites.default <- function(data, ...) {
^~~~~~~~~~~~~~~~~~~
```
[R/segsites.R:101:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/segsites.R#L101) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
as.segsites.list <- function(data, ...) {
^~~~~~~~~~~~~~~~
```
[R/simulator_class.R:55:3:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/simulator_class.R#L55) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  }, character(1L))
  ^
```
[R/simulator_class.R:67:44:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/simulator_class.R#L67) *style:* **Commas should never have a space before.**
```r
  grouped_commands <- unique(sim_commands[ , 2])
                                          ~^
```
[R/simulator_class.R:70:36:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/simulator_class.R#L70) *style:* **Commas should never have a space before.**
```r
    sum(sim_commands[sim_commands[ , 2] == cmd, 1])
                                  ~^
```
[R/simulator_msms.R:101:41:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/simulator_msms.R#L101) *style:* **Commas should never have a space before.**
```r
        paste("msms", sample_size, cmd[ , 1], cmd[ , 2])
                                       ~^
```
[R/simulator_msms.R:101:52:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/simulator_msms.R#L101) *style:* **Commas should never have a space before.**
```r
        paste("msms", sample_size, cmd[ , 1], cmd[ , 2])
                                                  ~^
```
[R/simulator_ms.R:71:9:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/simulator_ms.R#L71) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
        }, character(1))
        ^
```
[R/simulator_ms.R:86:39:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/simulator_ms.R#L86) *style:* **Commas should never have a space before.**
```r
        paste("ms", sample_size, cmd[ , 1], cmd[ , 2])
                                     ~^
```
[R/simulator_ms.R:86:50:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/simulator_ms.R#L86) *style:* **Commas should never have a space before.**
```r
        paste("ms", sample_size, cmd[ , 1], cmd[ , 2])
                                                ~^
```
[R/simulator_scrm.R:84:41:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/simulator_scrm.R#L84) *style:* **Commas should never have a space before.**
```r
        paste("scrm", sample_size, cmd[ , 1], cmd[ , 2])
                                       ~^
```
[R/simulator_scrm.R:84:52:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/simulator_scrm.R#L84) *style:* **Commas should never have a space before.**
```r
        paste("scrm", sample_size, cmd[ , 1], cmd[ , 2])
                                                  ~^
```
[R/simulator_seqgen.R:54:4:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/simulator_seqgen.R#L54) *style:* **Commented code should be removed.**
```r
  #print(cmd)
   ^~~~~~~~~~
```
[R/simulator_seqgen.R:129:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/simulator_seqgen.R#L129) *style:* **lines should not be more than 80 characters.**
```r
                                        sample_seed(length(trees[[locus_group]])))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/simulator_seqgen.R:154:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/simulator_seqgen.R#L154) *style:* **lines should not be more than 80 characters.**
```r
                                                              ignore_variation = TRUE),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat_ihh.R:19:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/sumstat_ihh.R#L19) *style:* **lines should not be more than 80 characters.**
```r
    initialize = function(name, population, max_snps, calc_ihs, transformation) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat_ihh.R:52:45:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/sumstat_ihh.R#L52) *style:* **Commas should never have a space before.**
```r
                      iHS = data.frame(ihh[ , 1:2], iHS = rep(NA, n_snps))))
                                           ~^
```
[R/sumstat_ihh.R:54:15:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/sumstat_ihh.R#L54) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          if ((n_snps < 50)) freqbin <- 0.90
              ^
```
[R/sumstat_ihh.R:55:20:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/sumstat_ihh.R#L55) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          else if ((n_snps < 100)) freqbin <- 0.45
                   ^
```
[R/sumstat_ihh.R:56:20:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/sumstat_ihh.R#L56) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          else if ((n_snps < 200)) freqbin <- 0.225
                   ^
```
[R/sumstat_ihh.R:57:20:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/sumstat_ihh.R#L57) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          else if ((n_snps < 400)) freqbin <- 0.1
                   ^
```
[R/sumstat_ihh.R:60:55:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/sumstat_ihh.R#L60) *style:* **Commas should never have a space before.**
```r
            data.frame(ihh2ihs(ihh, freqbin)$res.ihs[ , -4])
                                                     ~^
```
[R/sumstat_omega.R:14:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/sumstat_omega.R#L14) *style:* **lines should not be more than 80 characters.**
```r
    initialize = function(name, min_win, max_win, grid, binary, transformation) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat.R:192:6:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/sumstat.R#L192) *style:* **Commented code should be removed.**
```r
    #assert_that(is.list(tree_list))
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat.R:193:6:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/sumstat.R#L193) *style:* **Commented code should be removed.**
```r
    #assert_that(length(tree_list) == get_locus_number(model))
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sumstat_seg_sites.R:41:38:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/R/sumstat_seg_sites.R#L41) *style:* **Commas should never have a space before.**
```r
    trio_segsites <- seg_sites[[i]][ , left | middle | right]
                                    ~^
```
[tests/testthat/test-feature-ign-singletons.R:13:45:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-feature-ign-singletons.R#L13) *style:* **Commas should never have a space before.**
```r
               list(create_test_segsites()[ , -c(1, 3)],
                                           ~^
```
[tests/testthat/test-feature-ign-singletons.R:14:45:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-feature-ign-singletons.R#L14) *style:* **Commas should never have a space before.**
```r
                    create_test_segsites()[ , -c(1, 3)]))
                                           ~^
```
[tests/testthat/test-model-class.R:241:44:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-model-class.R#L241) *style:* **Commas should always have a space after.**
```r
               data.frame(name = c("theta","tau"),
                                           ^
```
[tests/testthat/test-search-executables.R:30:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-search-executables.R#L30) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-segsites-class.R:15:41:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-segsites-class.R#L15) *style:* **Put spaces around all infix operators.**
```r
  expect_error(create_segsites(snps, 1:4/10))
                                       ~^~
```
[tests/testthat/test-segsites-class.R:16:46:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-segsites-class.R#L16) *style:* **Put spaces around all infix operators.**
```r
  expect_error(create_segsites(snps, pos, 1:4/10))
                                            ~^~
```
[tests/testthat/test-segsites-class.R:22:40:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-segsites-class.R#L22) *style:* **Put spaces around all infix operators.**
```r
  segsites <- create_segsites(snps, 1:3/10)
                                      ~^~
```
[tests/testthat/test-segsites-class.R:30:31:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-segsites-class.R#L30) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  segsites <- create_segsites((matrix(c(1, 1, 0, 1, 1,
                              ^
```
[tests/testthat/test-segsites-class.R:36:26:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-segsites-class.R#L36) *style:* **Commas should never have a space before.**
```r
  ss_subset <- segsites[ , 1:2]
                        ~^
```
[tests/testthat/test-segsites-class.R:38:64:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-segsites-class.R#L38) *style:* **Commas should never have a space before.**
```r
  expect_equivalent(as.matrix(ss_subset), as.matrix(segsites)[ , 1:2])
                                                              ~^
```
[tests/testthat/test-segsites-class.R:41:30:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-segsites-class.R#L41) *style:* **Commas should never have a space before.**
```r
  expect_equal(dim(segsites[ , 1]), c(3, 1))
                            ~^
```
[tests/testthat/test-segsites-class.R:42:33:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-segsites-class.R#L42) *style:* **Commas should never have a space before.**
```r
  expect_equal(dim(segsites[1:2 , ]), c(2, 3))
                               ~^
```
[tests/testthat/test-segsites-class.R:43:32:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-segsites-class.R#L43) *style:* **Commas should never have a space before.**
```r
  expect_equal(dim(segsites[-2 , 1:3]), c(2, 2))
                              ~^
```
[tests/testthat/test-simulator-ms.R:7:73:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-simulator-ms.R#L7) *style:* **Put spaces around all infix operators.**
```r
  expect_equal(parse_ms_positions("positions: 0.1 0.2 0.3 0.4 0.5"), 1:5/10)
                                                                       ~^~
```
[tests/testthat/test-simulator-seqgen.R:213:6:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-simulator-seqgen.R#L213) *style:* **Commented code should be removed.**
```r
  #  model.addMutationRateHeterogenity(model.hky, 0.1, 5, categories.number = 5)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-simulator-seqgen.R:236:6:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-simulator-seqgen.R#L236) *style:* **Commented code should be removed.**
```r
    #feat_migration(par_zero_inflation(1, .5), symmetric = TRUE)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-simulator-seqgen.R:274:27:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-simulator-seqgen.R#L274) *style:* **Commas should always have a space after.**
```r
  model <- coal_model(c(5,5,2), 1, 100) +
                          ^
```
[tests/testthat/test-simulator-seqgen.R:274:29:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-simulator-seqgen.R#L274) *style:* **Commas should always have a space after.**
```r
  model <- coal_model(c(5,5,2), 1, 100) +
                            ^
```
[tests/testthat/test-sumstat-jsfs.R:4:3:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L4) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  seg.sites.3.pop <- list(create_segsites(matrix(c(1, 0, 1, 0,
  ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:10:60:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L10) *style:* **Commas should never have a space before.**
```r
                                                   1, 0, 1 ,0 ),
                                                          ~^
```
[tests/testthat/test-sumstat-jsfs.R:10:61:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L10) *style:* **Commas should always have a space after.**
```r
                                                   1, 0, 1 ,0 ),
                                                            ^
```
[tests/testthat/test-sumstat-jsfs.R:11:54:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L11) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                    ~^~
```
[tests/testthat/test-sumstat-jsfs.R:11:62:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L11) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                            ~^~
```
[tests/testthat/test-sumstat-jsfs.R:13:3:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L13) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1:2, 3:4, 5:7))
  ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:13:27:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L13) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1:2, 3:4, 5:7))
                          ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:14:13:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L14) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  expect_is(jsfs.3.pop, "array")
            ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:15:21:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L15) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  expect_equivalent(jsfs.3.pop, array(c(0, 0, 0, 0, 0, 0, 0, 0, 0,
                    ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:18:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **lines should not be more than 80 characters.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:18:73:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                       ~^~
```
[tests/testthat/test-sumstat-jsfs.R:18:78:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Commas should always have a space after.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                             ^
```
[tests/testthat/test-sumstat-jsfs.R:18:80:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Commas should always have a space after.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                               ^
```
[tests/testthat/test-sumstat-jsfs.R:18:82:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L18) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 0, 0, 0, 1, 0, 0, 0 ), dim=c(2,2,3)+1))
                                                                                ~^~
```
[tests/testthat/test-sumstat-jsfs.R:21:3:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L21) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  seg.sites.3.pop <- list(create_segsites(matrix(c(1, 0, 1, 0,
  ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:27:60:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L27) *style:* **Commas should never have a space before.**
```r
                                                   1, 0, 1 ,0 ),
                                                          ~^
```
[tests/testthat/test-sumstat-jsfs.R:27:61:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L27) *style:* **Commas should always have a space after.**
```r
                                                   1, 0, 1 ,0 ),
                                                            ^
```
[tests/testthat/test-sumstat-jsfs.R:28:54:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L28) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                    ~^~
```
[tests/testthat/test-sumstat-jsfs.R:28:62:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L28) *style:* **Put spaces around all infix operators.**
```r
                                                 nrow=7, ncol=4, byrow = TRUE),
                                                            ~^~
```
[tests/testthat/test-sumstat-jsfs.R:30:3:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L30) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1, 2:6, 7))
  ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:30:27:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L30) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  jsfs.3.pop <- calc_jsfs(seg.sites.3.pop, list(1, 2:6, 7))
                          ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:31:21:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L31) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
  expect_equivalent(jsfs.3.pop, array(c(0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0,
                    ^~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:32:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **lines should not be more than 80 characters.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-jsfs.R:32:82:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Put spaces around all infix operators.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ~^~
```
[tests/testthat/test-sumstat-jsfs.R:32:87:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Commas should always have a space after.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:32:89:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Commas should always have a space after.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:32:91:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L32) *style:* **Put spaces around all infix operators.**
```r
                                        0, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0, 0 ), dim=c(1,5,1)+1))
                                                                                ~^~
```
[tests/testthat/test-sumstat-jsfs.R:33:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L33) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test-sumstat-jsfs.R:53:41:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L53) *style:* **Commas should always have a space after.**
```r
  jsfs <- calc_jsfs(seg.sites, list(c(1,3), c(2,4)))
                                        ^
```
[tests/testthat/test-sumstat-jsfs.R:53:49:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L53) *style:* **Commas should always have a space after.**
```r
  jsfs <- calc_jsfs(seg.sites, list(c(1,3), c(2,4)))
                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:58:41:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L58) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,3), c(2,5)))
                                        ^
```
[tests/testthat/test-sumstat-jsfs.R:58:49:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L58) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,3), c(2,5)))
                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:59:41:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L59) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,7), c(2,3)))
                                        ^
```
[tests/testthat/test-sumstat-jsfs.R:59:49:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L59) *style:* **Commas should always have a space after.**
```r
  expect_error(calc_jsfs(seg.sites, c(1,7), c(2,3)))
                                                ^
```
[tests/testthat/test-sumstat-jsfs.R:141:40:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-jsfs.R#L141) *style:* **Put spaces around all infix operators.**
```r
                                    1:4/4))
                                      ~^~
```
[tests/testthat/test-sumstat-mcmf.R:13:51:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-mcmf.R#L13) *style:* **Put spaces around all infix operators.**
```r
  expect_equal(calc_mcmf(seg_sites, 2:4, FALSE), 2/3)
                                                 ~^~
```
[tests/testthat/test-sumstat-mcmf.R:70:63:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-mcmf.R#L70) *style:* **Put spaces around all infix operators.**
```r
                              coal_model(4) + locus_trio()), 1/3)
                                                             ~^~
```
[tests/testthat/test-sumstat-omega.R:7:5:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-omega.R#L7) *style:* **Use two spaces to indent, never tabs.**
```r
1.11	1.000000
    ^
```
[tests/testthat/test-sumstat-omega.R:8:5:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-omega.R#L8) *style:* **Use two spaces to indent, never tabs.**
```r
2.22	0.200000
    ^
```
[tests/testthat/test-sumstat-omega.R:9:5:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-omega.R#L9) *style:* **Use two spaces to indent, never tabs.**
```r
3.33	0.030000
    ^
```
[tests/testthat/test-sumstat-pi.R:7:67:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-pi.R#L7) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 1, 1, 1), 5, 3), 1:3/5)
                                                                 ~^~
```
[tests/testthat/test-sumstat-pi.R:26:67:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-pi.R#L26) *style:* **Put spaces around all infix operators.**
```r
                                        0, 1, 1, 1, 1), 5, 3), 1:3/5)
                                                                 ~^~
```
[tests/testthat/test-sumstat-segsites.R:28:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-segsites.R#L28) *style:* **lines should not be more than 80 characters.**
```r
  seg_sites_trio[[1]] <- create_segsites(get_snps(seg_sites_trio[[1]][ , c(1:2, 4:6, 8:9)]),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-segsites.R:28:72:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-segsites.R#L28) *style:* **Commas should never have a space before.**
```r
  seg_sites_trio[[1]] <- create_segsites(get_snps(seg_sites_trio[[1]][ , c(1:2, 4:6, 8:9)]),
                                                                      ~^
```
[tests/testthat/test-sumstat-sfs.R:62:40:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-sfs.R#L62) *style:* **Put spaces around all infix operators.**
```r
                                    1:4/4))
                                      ~^~
```
[tests/testthat/test-sumstat-tajimas-d.R:14:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-tajimas-d.R#L14) *style:* **lines should not be more than 80 characters.**
```r
                                 0, 0, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 0, 0, 0, 0),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-tajimas-d.R:27:1:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-tajimas-d.R#L27) *style:* **lines should not be more than 80 characters.**
```r
  expect_equal(tajd$calculate(list(create_empty_segsites(10)), NULL, NULL, model), NaN)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sumstat-trees.R:6:30:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-trees.R#L6) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_true(requires_trees((coal_model(5) + sumstat_trees())))
                             ^
```
[tests/testthat/test-sumstat-trees.R:7:30:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-trees.R#L7) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_true(requires_trees((coal_model(5) + sumstat_sg_trees())))
                             ^
```
[tests/testthat/test-sumstat-trees.R:8:34:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-trees.R#L8) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_false(requires_segsites((coal_model(5) + sumstat_trees())))
                                 ^
```
[tests/testthat/test-sumstat-trees.R:9:34:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-trees.R#L9) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_false(requires_segsites((coal_model(5) + sumstat_sg_trees())))
                                 ^
```
[tests/testthat/test-sumstat-trees.R:73:64:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-trees.R#L73) *style:* **Commas should always have a space after.**
```r
                                 locus_trio(locus_length = c(1,3,5),
                                                               ^
```
[tests/testthat/test-sumstat-trees.R:73:66:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-trees.R#L73) *style:* **Commas should always have a space after.**
```r
                                 locus_trio(locus_length = c(1,3,5),
                                                                 ^
```
[tests/testthat/test-sumstat-trees.R:74:60:](https://github.com/statgenlmu/coala/blob/d0cbf80de2465b27537578365b17ab904b2bdaf7/tests/testthat/test-sumstat-trees.R#L74) *style:* **Commas should always have a space after.**
```r
                                            distance = c(2,4)))
                                                           ^
```


Undo


it will ensure anyone running these locally will have the same results


I'm not sure I'm a big fan of doing all this work in the constructor...


I agree that it is weird and unexpected. It does so right now because it modifies the `transfers` array.


I've been getting a file "gambit.log" after every execution.

What's this about?


необязательно. зависит скорее от логики расположения элементов. поскольку после его нажатия будут учитываться данные из обоих fieldset'ов, скорее он должен быть снаружи