Hello, it has been always possible to invoke corfu_server with -m and
without -s.

It's quite clear from the help that this is possible and it does work fine.

corfu_server (-l <path>|-m) [-s] [-a <address>] [-t <token>] [-c <size>]
[-k seconds] [-d <level>] <port>

On Fri, Feb 5, 2016 at 5:04 PM, dahliamalkhi <notifications@github.com>
wrote:

> right now, it is not possible to invoke CorfuServer -m without also -s
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CorfuDB/CorfuDB/commit/94ffc51732d98ba447266cb42555f3354bb306c9#commitcomment-15929113>
> .
>

--
*Michael Wei*
Graduate Researcher
PhD Student
Non-Volatile Systems Laboratory @ UCSD
http://cseweb.ucsd.edu/users/m3wei/


release-5.x (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Fixes #34 #31


release-5.x (lefticus) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


test


should just create a new target in the pom for these.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14659](https://teamcity.mesosphere.io/viewLog.html?buildId=126958&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:03:38


Unrelated to this PR, but could you sort these?


Works great!
Added the line TERMINAL_CMD    =   "C:\Program Files\SyncTERM\syncterm.exe" to WWIV.INI and it launched perfectly.
Thank you!


@chumer @nirvdrum new tool - pass it either a JRuby or GraalVM tarball and it does basic tests as several levels. Our other tests have a little problem in that they are very integrated into the source tree. This runs tests completely outside the source tree to check everything is in place in the tarball.


This line needs to be removed for this to actually work properly with gorouter. See https://github.com/Stackato-Apps/node-env/pull/6


Is there a unit test for this?

Looks good


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14660](https://teamcity.mesosphere.io/viewLog.html?buildId=126965&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:05:02


don't use abbreviations for variables


@thyageshm Rectify and do a direct commit to master. Next time, I'll create a PR instead of committing directly. :-)


these are breaking changes... should they be backwards compatible?


I will use in my branch =)


Instead of jumping, should we jump and start the prompt? I've observed users mapping the controller, and they think that just because the button is highlighted it's expecting input, giving them a surprise when they press something.


@cwillmor , can you review?


TeamCity pull requests :: netty [Build 1225](https://garage.netty.io/teamcity/viewLog.html?buildId=5490&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6421, ignored: 23 Build time: 00:43:37


TeamCity pull requests :: netty [Build 1226](https://garage.netty.io/teamcity/viewLog.html?buildId=5491&buildTypeId=pulls_netty&guest=1) is now running


Why does this need to be a function? You can move this up to where you declare rollbackInterlude.


This block of code has changed, so as a new user it doesn't look like I can just un-comment that line to use the list. It'd be nice to point to some instructions on how to add it back properly.


LGTM, thanks!


s/backen/backend/


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14661](https://teamcity.mesosphere.io/viewLog.html?buildId=126973&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 223 Build time: 00:04:53


Why did you choose to speculatively parse the literal syntax rather than looking for the explicit names of #-expressions? I guess we could have overlap at some point, but it's not likely, and that doesn't require any lookahead and can be done entirely in the lexer.


Per Java Naming Conventions name of methods and variables should be written in camelCase format.
http://www.oracle.com/technetwork/java/codeconventions-135099.html


Per Java Naming Conventions name of methods and variables should be written in camelCase format.
http://www.oracle.com/technetwork/java/codeconventions-135099.html
Check all names in this clase.


We'll miss you JavaScreepts!


113107773-Improve-waste-heat-function-handling-of-AirloopHVACUnitarySystem-#5222 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (957 of 957 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.87%25-green.svg)


I would leave a comment here about why we are only omitting the rewrite for the root node


The newest version of the Pi-hole has the ad lists broken out to a new file at https://github.com/pi-hole/pi-hole/blob/master/adlists.default so any new installs would not even see the mahakala list. (It's been removed fromt the default adlist.


forgot to delete message #2


Please add a FIXME that this doesn't handle multi-file compilation of the stdlib.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14662](https://teamcity.mesosphere.io/viewLog.html?buildId=126976&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:03:49


I am not complete sure right now but check if you need final keyword here. As I remember, final variable should be used for anonymous class to avoid this variable can change its reference but in Java 8 I think this changed. Check it please.


And the corollary, when the user finishes the wizard, it'd be nice if it jumped back.


/insert "it's happening" gif here


The change of "Taint can spread, no taint at worldgen" is ... well, frankly, I'd like to see the opposite. Taint does spawn, but does not spread -- so you get a few chunks here and there, but that's all. (At least, that's how it behaved in 164).

Yes, taint eradication is a game to me. One I know how to win.


The mahakala list is still in gravity.sh at https://github.com/pi-hole/pi-hole/blob/master/gravity.sh#L189, which implies if I add the URL to adlists.default, it would just magically work?


whoops, this should be `unsigned int curr_ind`, my mistake. @rohgarg since you're the main developer at this point, can you quickly fix this?


[inst/doc/caretEnsemble-intro.R:14:28:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/inst/doc/caretEnsemble-intro.R#L14) *style:* **Commas should always have a space after.**
```r
training <- Sonar[ inTrain,]
                           ^
```
[inst/doc/caretEnsemble-intro.R:15:27:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/inst/doc/caretEnsemble-intro.R#L15) *style:* **Commas should always have a space after.**
```r
testing <- Sonar[-inTrain,]
                          ^
```
[inst/doc/caretEnsemble-intro.R:70:14:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/inst/doc/caretEnsemble-intro.R#L70) *style:* **Trailing whitespace is superfluous.**
```r
  model_list,
             ^
```
[inst/doc/caretEnsemble-intro.R:82:51:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/inst/doc/caretEnsemble-intro.R#L82) *style:* **Commas should always have a space after.**
```r
model_preds <- lapply(model_preds, function(x) x[,"M"])
                                                  ^
```
[inst/doc/caretEnsemble-intro.R:136:1:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/inst/doc/caretEnsemble-intro.R#L136) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/caretEnsemble.R:145:76:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/R/caretEnsemble.R#L145) *style:* **Commas should always have a space after.**
```r
    tmp.t <- out[attributes(out)$dimnames[[nams[[i]]]] == as.character(bt[,nams[i]])]
                                                                           ^
```
[R/caretEnsemble.R:192:38:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/R/caretEnsemble.R#L192) *style:* **Commas should always have a space after.**
```r
  dat <- dat[order(dat[["overall"]]),]
                                     ^
```
[R/caretEnsemble.R:200:33:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/R/caretEnsemble.R#L200) *style:* **Commas should always have a space after.**
```r
  x$importance <- x$importance[,"Overall", drop=FALSE]
                                ^
```
[R/caretEnsemble.R:213:36:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/R/caretEnsemble.R#L213) *style:* **Commas should always have a space after.**
```r
  dat$model <- sub("\\.[^\n]*", "",dat$id)
                                   ^
```
[R/caretEnsemble.R:223:26:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/R/caretEnsemble.R#L223) *style:* **Commas should always have a space after.**
```r
  row.names(dat) <- dat[,1]
                         ^
```
[R/caretEnsemble.R:224:15:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/R/caretEnsemble.R#L224) *style:* **Commas should always have a space after.**
```r
  return(dat[,-1])
              ^
```
[R/caretList.R:268:69:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/R/caretList.R#L268) *style:* **Commas should always have a space after.**
```r
        caret::predict.train(x, type="prob", newdata=newdata, ...)[,2]
                                                                    ^
```
[R/helper_functions.R:15:30:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/R/helper_functions.R#L15) *style:* **Commas should always have a space after.**
```r
    xWbar <- weighted.mean(x,w,na.rm=na.rm)
                             ^
```
[R/helper_functions.R:15:32:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/R/helper_functions.R#L15) *style:* **Commas should always have a space after.**
```r
    xWbar <- weighted.mean(x,w,na.rm=na.rm)
                               ^
```
[R/helper_functions.R:63:78:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/R/helper_functions.R#L63) *style:* **Commas should always have a space after.**
```r
    probModels <- sapply(list_of_models, function(x) modelLookup(x$method)[1,"probModel"])
                                                                             ^
```
[R/helper_functions.R:177:12:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/R/helper_functions.R#L177) *style:* **Commas should always have a space after.**
```r
  b <- b[a,]
           ^
```
[R/helper_functions.R:245:87:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/R/helper_functions.R#L245) *style:* **Commas should always have a space after.**
```r
    set(modelLibrary, i=good_pos_values, j="pred", value=modelLibrary[good_pos_values,positive,with=FALSE])
                                                                                ^
```
[R/helper_functions.R:245:96:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/R/helper_functions.R#L245) *style:* **Commas should always have a space after.**
```r
    set(modelLibrary, i=good_pos_values, j="pred", value=modelLibrary[good_pos_values,positive,with=FALSE])
                                                                                ^
```
[R/helper_functions.R:256:67:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/R/helper_functions.R#L256) *style:* **Commas should always have a space after.**
```r
  return(list(obs=modelLibrary$obs, preds=as.matrix(modelLibrary[,model_names,with=FALSE]), type=type))
                                                                  ^
```
[R/helper_functions.R:256:79:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/R/helper_functions.R#L256) *style:* **Commas should always have a space after.**
```r
  return(list(obs=modelLibrary$obs, preds=as.matrix(modelLibrary[,model_names,with=FALSE]), type=type))
                                                                              ^
```
[tests/testthat/test-caretList.R:62:41:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L62) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,1:4], iris[,5]), iris[,5])
                                        ^
```
[tests/testthat/test-caretList.R:62:53:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L62) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,1:4], iris[,5]), iris[,5])
                                                    ^
```
[tests/testthat/test-caretList.R:62:64:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L62) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,1:4], iris[,5]), iris[,5])
                                                               ^
```
[tests/testthat/test-caretList.R:63:41:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L63) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,2:5], iris[,1]), iris[,1])
                                        ^
```
[tests/testthat/test-caretList.R:63:53:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L63) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,2:5], iris[,1]), iris[,1])
                                                    ^
```
[tests/testthat/test-caretList.R:63:64:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L63) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,2:5], iris[,1]), iris[,1])
                                                               ^
```
[tests/testthat/test-caretList.R:64:61:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L64) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(Species ~ ., iris), iris[,"Species"])
                                                            ^
```
[tests/testthat/test-caretList.R:65:65:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L65) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(Sepal.Width ~ ., iris), iris[,"Sepal.Width"])
                                                                ^
```
[tests/testthat/test-caretList.R:86:36:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L86) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control))
                                   ^
```
[tests/testthat/test-caretList.R:86:48:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L86) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control))
                                               ^
```
[tests/testthat/test-caretList.R:87:36:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L87) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control))
                                   ^
```
[tests/testthat/test-caretList.R:87:48:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L87) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control))
                                               ^
```
[tests/testthat/test-caretList.R:88:36:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L88) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control, continue_on_fail=TRUE))
                                   ^
```
[tests/testthat/test-caretList.R:88:48:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L88) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control, continue_on_fail=TRUE))
                                               ^
```
[tests/testthat/test-caretList.R:89:33:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L89) *style:* **Commas should always have a space after.**
```r
      expect_is(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control, continue_on_fail=TRUE), "caretList")
                                ^
```
[tests/testthat/test-caretList.R:89:45:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L89) *style:* **Commas should always have a space after.**
```r
      expect_is(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control, continue_on_fail=TRUE), "caretList")
                                            ^
```
[tests/testthat/test-caretList.R:100:13:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L100) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
            ^
```
[tests/testthat/test-caretList.R:100:25:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L100) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
                        ^
```
[tests/testthat/test-caretList.R:113:17:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L113) *style:* **Commas should always have a space after.**
```r
  expect_is(p1[,1], "character")
                ^
```
[tests/testthat/test-caretList.R:114:17:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L114) *style:* **Commas should always have a space after.**
```r
  expect_is(p1[,2], "character")
                ^
```
[tests/testthat/test-caretList.R:117:17:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L117) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,1], "character")
                ^
```
[tests/testthat/test-caretList.R:118:17:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L118) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,2], "character")
                ^
```
[tests/testthat/test-caretList.R:121:17:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L121) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,1], "character")
                ^
```
[tests/testthat/test-caretList.R:122:17:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L122) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,2], "character")
                ^
```
[tests/testthat/test-caretList.R:127:13:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L127) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
            ^
```
[tests/testthat/test-caretList.R:127:25:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L127) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
                        ^
```
[tests/testthat/test-caretList.R:136:17:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L136) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,1], "numeric")
                ^
```
[tests/testthat/test-caretList.R:137:17:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L137) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,2], "numeric")
                ^
```
[tests/testthat/test-caretList.R:139:17:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L139) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,1], "numeric")
                ^
```
[tests/testthat/test-caretList.R:140:17:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L140) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,2], "numeric")
                ^
```
[tests/testthat/test-caretList.R:160:17:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L160) *style:* **Commas should always have a space after.**
```r
      x = iris[,1:3],
                ^
```
[tests/testthat/test-caretList.R:161:17:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L161) *style:* **Commas should always have a space after.**
```r
      y = iris[,4],
                ^
```
[tests/testthat/test-caretList.R:205:23:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L205) *style:* **Commas should always have a space after.**
```r
            x = iris[,1:3],
                      ^
```
[tests/testthat/test-caretList.R:206:23:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L206) *style:* **Commas should always have a space after.**
```r
            y = iris[,4],
                      ^
```
[tests/testthat/test-caretList.R:332:18:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L332) *style:* **Commas should never have a space before.**
```r
      y = train[ , "Class"],
                ~^
```
[tests/testthat/test-caretList.R:448:37:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L448) *style:* **Commas should always have a space after.**
```r
      tuneGrid=data.frame(.cp=c(.01,.001,.1,1))
                                    ^
```
[tests/testthat/test-caretList.R:448:42:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L448) *style:* **Commas should always have a space after.**
```r
      tuneGrid=data.frame(.cp=c(.01,.001,.1,1))
                                         ^
```
[tests/testthat/test-caretList.R:448:45:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L448) *style:* **Commas should always have a space after.**
```r
      tuneGrid=data.frame(.cp=c(.01,.001,.1,1))
                                            ^
```
[tests/testthat/test-caretList.R:519:14:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L519) *style:* **Commas should always have a space after.**
```r
  x <- iris[,1:3]
             ^
```
[tests/testthat/test-caretList.R:520:14:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-caretList.R#L520) *style:* **Commas should always have a space after.**
```r
  y <- iris[,4]
             ^
```
[tests/testthat/test-ensembleMethods.R:200:40:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensembleMethods.R#L200) *style:* **Commas should always have a space after.**
```r
  mr1 <- mr1[order(mr1$method, mr1$id),]
                                       ^
```
[tests/testthat/test-ensembleMethods.R:201:40:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensembleMethods.R#L201) *style:* **Commas should always have a space after.**
```r
  mr2 <- mr2[order(mr2$method, mr2$id),]
                                       ^
```
[tests/testthat/test-ensembleMethods.R:220:70:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensembleMethods.R#L220) *style:* **Commas should always have a space after.**
```r
  expect_equal(mr_reg_long[order(mr_reg_long$method, mr_reg_long$id),"resid"], mr2[order(mr2$method, mr2$id),"resid"])
                                                                     ^
```
[tests/testthat/test-ensembleMethods.R:220:110:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensembleMethods.R#L220) *style:* **Commas should always have a space after.**
```r
  expect_equal(mr_reg_long[order(mr_reg_long$method, mr_reg_long$id),"resid"], mr2[order(mr2$method, mr2$id),"resid"])
                                                                                ^
```
[tests/testthat/test-ensembleMethods.R:281:20:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensembleMethods.R#L281) *style:* **Commas should always have a space after.**
```r
        se=tests[i,"se"],
                   ^
```
[tests/testthat/test-ensembleMethods.R:282:32:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensembleMethods.R#L282) *style:* **Commas should always have a space after.**
```r
        return_weights=tests[i,"return_weights"]
                               ^
```
[tests/testthat/test-ensembleMethods.R:286:16:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensembleMethods.R#L286) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"se"]){
               ^
```
[tests/testthat/test-ensembleMethods.R:294:16:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensembleMethods.R#L294) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"return_weights"]){
               ^
```
[tests/testthat/test-ensembleMethods.R:309:20:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensembleMethods.R#L309) *style:* **Commas should always have a space after.**
```r
        se=tests[i,"se"],
                   ^
```
[tests/testthat/test-ensembleMethods.R:310:32:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensembleMethods.R#L310) *style:* **Commas should always have a space after.**
```r
        return_weights=tests[i,"return_weights"],
                               ^
```
[tests/testthat/test-ensembleMethods.R:315:16:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensembleMethods.R#L315) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"se"]){
               ^
```
[tests/testthat/test-ensembleMethods.R:323:16:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensembleMethods.R#L323) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"return_weights"]){
               ^
```
[tests/testthat/test-ensemble.R:28:11:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensemble.R#L28) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
          ^
```
[tests/testthat/test-ensemble.R:28:23:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensemble.R#L28) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
                      ^
```
[tests/testthat/test-ensemble.R:56:11:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensemble.R#L56) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
          ^
```
[tests/testthat/test-ensemble.R:56:23:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-ensemble.R#L56) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
                      ^
```
[tests/testthat/test-helper_functions.R:28:13:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-helper_functions.R#L28) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
            ^
```
[tests/testthat/test-helper_functions.R:28:25:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-helper_functions.R#L28) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
                        ^
```
[tests/testthat/test-helper_functions.R:37:13:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-helper_functions.R#L37) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
            ^
```
[tests/testthat/test-helper_functions.R:37:39:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-helper_functions.R#L37) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
                                      ^
```
[tests/testthat/test-helper_functions.R:43:11:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-helper_functions.R#L43) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
          ^
```
[tests/testthat/test-helper_functions.R:43:37:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-helper_functions.R#L43) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
                                    ^
```
[tests/testthat/test-helper_functions.R:151:93:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-helper_functions.R#L151) *style:* **Commas should always have a space after.**
```r
  modelLibrary$nn <- modelLibrary$lm[sample(1:nrow(modelLibrary$lm), nrow(modelLibrary$lm)),]
                                                                                ^
```
[tests/testthat/test-helper_functions.R:185:18:](https://github.com/zachmayer/caretEnsemble/blob/86d20b0bfc4c3ad97f1d5d62946ee10e9adc0a5a/tests/testthat/test-helper_functions.R#L185) *style:* **Commas should always have a space after.**
```r
      iris[1:100,-5],
                 ^
```


Is this supposed to be `if (!GroupNamesMap`?


Good catch! Do we have a plan to multi-file compile stdlib in the future? I asked @gribozavr early and made sure this is not happening now.


Forgot to add the story number to the commit comment.

[#99927978]


Rather than using count and then subscript, it's marginally faster to use find and then dereference the resulting iterator.


Yes, fixed in the later patch.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14664](https://teamcity.mesosphere.io/viewLog.html?buildId=127013&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:10


I suppose we can get ride of these debugging prints now. They were just there from the plugin I copied when starting this.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14663](https://teamcity.mesosphere.io/viewLog.html?buildId=127000&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:04:41


and i guess this section can be deleted if no longer used


Note: to avoid hardcodes values, you can save them in a applications.properties in the resource package and use the environment class to invoke the values you need. Consider it for next time.


I'm okay with not supporting it, but we should call out that we're not supporting it. So maybe not a FIXME, but something else. Assert that the parent module isn't the stdlib in the file case?


Yes, the `gravity_spinup()` function still checks for some parameters to be passed with the `curl` command to grab the mahakala list. It should work, but it's not one of the suggested out of the box lists, as last week they attempted to block the entire `.com` TLD... I don't know how much longer that `curl` parameter check will stay around, it's there mostly for backwards compatibility with current installs.


A MapVector would avoid the need for all this, but I don't know if you can use MapVector with StringMap. :-/


i think we should change this to `message.channel.id`

it breaks private chats, but makes usage more reliable for storing room to a database.

at least for the interim of adding a wrapper for the channel.


also why is leafPredicates.isEmpty() a condition here?


Can you move onConnectedInitialCapabilitiesReceived() (in WearManager) to outside of the if-clause? Even if the capabilities is null, this callback needs to be called.


@denvned Thanks for this!

Just FYI, here are the main changes I made relative to the original PR:
- Moved the call to inject the change emitter's scheduler to `RelayContext` (from `RelayRenderer`).
- Changed one or two tests to use `new RelayStoreData` instead of `new RelayContext().getStoreData()`, just to be more explicit.
- Updated internal modules to reference `RelayStore.getStoreData()` instead of `RelayStoreData.getDefaultInstance()`.
- Changed `RelayTestUtils.createRenderer` to make the `relay` argument optional in order to simplify some internal tests that use this helper.


вообще то правильно "не спится"


The variable 'a' is a parameter, remember define it as a representative name. I think is the username but to know that I have to find the Account class and look into constructor signature.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14665](https://teamcity.mesosphere.io/viewLog.html?buildId=127022&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:04:12


Um. I *think* that this isn't a problem; the problem was that your mechanism for detecting whether something is part of the stdlib didn't work for multi-file builds. I can't think of any problems with what you've done here.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14668](https://teamcity.mesosphere.io/viewLog.html?buildId=127030&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:04:11


I think you made a mistake on line 170:   `if (!h.get_as_mass()) ` ->  ` if (!Atom::get_is_setup(h)) {`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14666](https://teamcity.mesosphere.io/viewLog.html?buildId=127028&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:04:53


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14669](https://teamcity.mesosphere.io/viewLog.html?buildId=127033&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:03:50


Yes, I just spotted that myself - wondered why rigid body creation was failing all of a sudden!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14670](https://teamcity.mesosphere.io/viewLog.html?buildId=127034&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:04:06


Umm ok lol thought we would be running latest version but thanks for letting me know.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14667](https://teamcity.mesosphere.io/viewLog.html?buildId=127029&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:08:41


Possibly. Time to poke around with the API a bit. I just like that if the engine is private to this `State`, we don't have to do as much munging if we can prove nobody else was mussing with it.


Didn't you just reformat this?  :)


aaa


ignoring `*.php` and `*.pl` is very cool. :laughing:


@Jermolene, perhaps you are referring to #1404, not entirely sure.


requires an update in the doc


This commit is my own config, but I push on the Pull Request. If you don't want accept this commit no problem ;)


Caldrà fer aleshores un camp relacionat a l'estil del que tenim de subpagines a programes, no?


Aww shucks, thats a pretty sweet commit.


Millor amb modals que amb alerts


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14671](https://teamcity.mesosphere.io/viewLog.html?buildId=127042&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:04:06


beginning


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14672](https://teamcity.mesosphere.io/viewLog.html?buildId=127047&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:00:48


You can put your info down if you'd like


LGTM


sweet additions


any title?


Looks good to me.


I can understand not wanting a rate of 6 in the rainbow forests. But given the nature/goal/design, isn't "1" (which I'm assuming is normal) too low? Would "2" be acceptable?


this pleases me.


@deekayen We [have a page on our wiki](https://github.com/pi-hole/pi-hole/wiki/Customising-sources-for-ad-lists) describing what you're after :)


TeamCity pull requests :: netty [Build 1226](https://garage.netty.io/teamcity/viewLog.html?buildId=5491&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6421, ignored: 23 Build time: 00:42:23


TeamCity pull requests :: netty [Build 1227](https://garage.netty.io/teamcity/viewLog.html?buildId=5492&buildTypeId=pulls_netty&guest=1) is now running


PlantCompBaseClassAgain (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (957 of 957 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.88%25-green.svg)


Hi, thanks for the reply.
I realized that when i search using one or two words it works fine but when i put an address that contains four of more parameters especially a non American or European address, it crashes.

I plane on doing the project allover again so i can practice it better, i will try to use a form with a specific number of field so a to constrain the search parameters to a small number of words and also catch exceptions so the program doesn’t crash.

Thanks for introducing me to Heroku and GIthub, I used to do JAVA for about two years now but the web-app part was always difficult to implement. Your Python Project has shown me a better way.

Thanks


@RohanM what was the need to define this as a separate playbook?


This var reset on every monitoring cycle


PATH is only used to search for executables. For directories, CDPATH is used, starting with cwd first in most shells. Given that the script stops on first error, I am fairly certain the correct directory will be found.

Yes "download_prerequisites" only downloads the prerequisites, but they are built together with GCC if they are found in subdirectory of GCC.
( https://gcc.gnu.org/install/prerequisites.html )


So this never happens, I test it.


Please review this, @casey-collab


In the near future we might also need 16x, eg. for AVX-512 with drivers that don't do auto-vectorization.


thanks, I overlooked that


Hi,

Your above commits on the php7-deprecated-methods branch tested well, so I rebased them all into 1 commit and brought it into the OpenEMR codebase:
https://github.com/openemr/openemr/commit/8289682d96b66ae8e5ac7d9a12cf15701ea2dcbe

I also placed a commit after it in the OpenEMR codebase with several encoding fixes:
https://github.com/openemr/openemr/commit/10f3d754219b594487e4d36b58057ef71cabf0da

-brady


I've commented it out for now.


Please remove stable keywords and put them back in ~arch when version bumping a package.


${P}-1.2.src.rpm -> ${P}.rpm


CFileItemList approach has been dumped in the later commits, we just left it in for the sake of history

https://github.com/MrMC/mrmc/commit/83bda101d949b49208c879fb1245167fb365d3b4


I'm not sure why 'DISPLAY' is set only when using feh, as this environment variable is also used by gsettings, and probably the other programs for other DEs as well


OK, thats not good. I will be debugging it then.


Hi,
I wouldn't change non-static methods to static. I'd recommend initiating it and then calling it with ->
-brady


One nit here - can we combine the conditionals both in JS and Objective-C, so as not to have duplicated code across the play and playWithUrl methods?


Если можно по русски. Тот случай, когда на клиенте angular и ответ от сервера не json.

--
when angular on the client and reply from server is not json.


@superkhau I am horrified by this, there are 54 new files and 954 lines full of boilerplate, with only about 10-20 lines that actually matter. How are we going to maintain and update this? How are the people inspecting failing tests supposed to determine which of these 954 lines are important for the test and what is just boilerplate that can be ignored?

Also LoopBack core should not depend on loopback-boot, as loopback-boot is just an optional component.  All loopback features must work without loopback-boot too, and thus the unit-tests should test the features using only loopback API.

Here is the right approach for creating many apps that differ by a small subset of settings:

```js
it('should fall back to config.json settings if setting is not found in' +
  'model-config.json', function(done) {

    var app = givenAppWithTodoModelAndCustomSharedMethods(
      // server-wide in server/config.json
      { '*': false, destroyAll: true } },
      // model-specific in server/model-config.json
      { destroyAll: false }
    );

    request(app)
      .get('/todos')
      .expect(404, done);
   });
 });

function givenAppWithTodoModelAndCustomSharedMethods(serverWide, modelSpecific) {
  var app = loopback({ localRegistry: true });
  app.set('remoting', { sharedMethods: serverWide });
  // set flags like "legacyExplorer" etc. as needed

  var Todo = app.registry.createModel('Todo', { /* no properties needed in these tests*/ });
  app.createDataSource('db', { connector: 'memory', });
  app.model(Todo, {
    dataSource: 'db'
    options: { remoting: { sharedMethods: modelSpecific }
  });

  app.use(loopback.rest());
  return app;
}


左侧头像后面背景能改成图片吗  谢谢


Note my above commit was for the commits in your php7-deprecated-constructors branch. I haven't yet looked at the php7-deprecated-methods branch (I will be doing that very soon, though).


Since this is now the *third* outcome in which these three `precalculate` blocks appear, it would be good to think of a way to refactor to remove the duplication. At the very least, I think `current_path` could become a method on `SmartAnswer::State`. However, it might need a different name to distinguish is from `State#path`, e.g. `url_path`. Or maybe `State#path` should be renamed to be `State#nodes`. Anyway, now that I've thought about it a bit, it might be simpler to make this change outside this PR given that it might require some relatively pervasive changes.


Expect the unexpected. This is a development branch and may be weeks before actual deployment. We'll try new things, avoid confusion by stating both MTUs, one for the parent, one for PPPoE. If it's not working out we'll change it again. And if it works out fine that's ok too. :)


This filename of this partial seems to be inconsistent with its content i.e. "...or_cheque.govspeak.erb" versus "but **not** by personal cheque".

As per my earlier comment, it feels as if these payment method partials are in danger of combinatorial explosion. I think it might be better to have a single parameterised partial.


It's necessary for the first run. After that it doesn't have to be, but that's how it is right now :P


This seems odd. Why add the $_SESSION (I am just asking here, since not clear what this is doing)


erlang doesn't support sha256


haha this is great


I am guessing this will be what you reverted in next commit.


I think that you should have used 0x200 instead of 0x1000.


hebrew'


Yaaaaaaaaaaaaaaaaaaaaaaaaaay! =D


I think feh especially requires it, but apparently this is not the case for other options (they seem to work well), so it's only set when using feh.


@jdtournier @Lestropie  I'm 99% sure this does the same thing, but you may want to check. (Change meant to get rid of "potentially evaluated expression" warning in Xcode clang.)


Ideally it would be nice to explain why this is necessary at least in code terms. Is it because there is a need for Kuwait to deviate from the standard (?) outcome in some way? If so, in what way? Has the change been made in this commit or is this commit simply splitting out the outcome with the behaviour unchanged i.e. would the regression test artefacts be unchanged at this point?

It would also be good to mention why `marriage-abroad-responses-and-expected-results.yml` has changed. I think this is because `kuwait` was already included in `marriage-abroad-questions-and-responses.yml` as a response to the `country_of_ceremony?` question. And therefore the new node name now needs to appear in `marriage-abroad-responses-and-expected-results.yml`.


That commit *does* sorta  crash the game though. 'com.pau101' doesn't exist.


Yo


Unless declaring with `volatile` or something, it really makes no difference whether you declare new variables like this.  The optimizations are unchanged, and the code becomes less readable.  Nothing is being served by underestimating the compiler for rewrites like this, which are trivial for compiler theory to conduct on its own.

Essentially the only difference being done is the `if (wired == 0) random %= 32`, to evade the `while` loop.


I think it would be clearer to have actually duplicated the content in the new `kuwait` outcome in the earlier commit and then have this commit extract the partial to remove the duplication. At the least, it would be helpful to explain in the commit note where else the partial is being used.


умничка!


My [previous comment](https://github.com/alphagov/smart-answers/commit/8e79f795d11fae3212ed48a2363243cd89b57bbc#commitcomment-15931904) applies here too.


все корректно и по делу, за комментарии отдельное спасибо - читать такой код - сплошное удовольствие)


Why not turn the left shift into a multiplication by (1 << shift) ?


:+1: за использование флагов


crashes with bad access here when there is no library in place yet (f.e. fresh install) - storeUrl is nil ...


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14715](https://teamcity.mesosphere.io/viewLog.html?buildId=127391&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 223 Build time: 00:06:51


все верно! претензий нет ни к стилю, ни к логике


Aw, no grass actors on the player island? :(


This seems to be fixed in master here:
https://github.com/raspberrypi/noobs/blob/bc6dc9efe21562deca0de173896aa1abd3194525/recovery/bootselectiondialog.cpp#L84

https://github.com/raspberrypi/noobs/blob/bc6dc9efe21562deca0de173896aa1abd3194525/recovery/util.cpp#L123-L141


очень оригинальное решение) производительность такого решения конечно будет оставлять желать лучшего, но - за креативный подход :+1: .


just in case someone cares - this can't be backported to kodi - becasue each user has to have its own id here ... @DanTheMan827 fyi


Why did you change this? In the current master it seems to be ordered similar:
https://github.com/raspberrypi/noobs/blob/bc6dc9efe21562deca0de173896aa1abd3194525/recovery/mainwindow.cpp#L75


Drop the tbl_membership before you import @uxreactor/batchonecoders


@jeffjirsa I'm running 2.2.4 - so i assume it should be good (tm) ?


I dont have `posix_kill` on windows and i dont need it for detached mode?


I only handle ENCODING_DTSHD_MA myself.
Not sure it's worth taking the other one into account


I thinks we should switch to the stable branch as the unstable version is not available in 32 bits


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14716](https://teamcity.mesosphere.io/viewLog.html?buildId=127392&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 224 Build time: 00:07:38


I am also a fan!


I don't know - it costs us nothing, but if nobody is using it in the wild, probably not worth it.


Yes, exactly. (and below the Login As menu item ... look for @"samuel" somewhere)


never mind - that was due to the hardcoded bundle identifiers here in the code ...


Das ist so nicht richtig, da das Skript auch vom Chromosome_Reader
benötigt wird, deshalb fand ich es sinnvoll das Skript auszulagern

On 05.02.2016 20:51, Ben Schumacher wrote:
>
> Nimm diesen Abschnitt bitte beim GeneTranslator mit rein. Der ist der
> einzige, der diese Skript benötigt. Dann kannst du da auch den Link
> noch mit einfügen
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hu-semesterprojekt-genombrowser/Alazen/commit/05d276a8e2ad97087bde6b08a32d40fd887bbd0f#commitcomment-15923400>.
>


I thought you commented out ifdef?


Hi,
Es war der momentane Index der auch auf dem System gerade aufliegt. Das
ist gerade das gesamte Chromosom 1 der Db, die zur Verfügung steht.

On 05.02.2016 20:53, Ben Schumacher wrote:
>
> 50 Werte anzugeben bringt nicht ganz so viel. Am Besten bildest du den
> Mittelwert und beschreibst Ausreißer. Gab es Unterschiede bei den drei
> Anfragearten? Wie groß war der Index, auf dem gesucht wurde?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hu-semesterprojekt-genombrowser/Alazen/commit/19652fe0649be62e494bc3a3dc4fae852c536b63#commitcomment-15923494>.
>


Hi Christian, I see you are working on Multicam Support, which is great!
Before you continue, let me suggest that you rather could implement a kind of meta-camera driver as a single subclass of CameraEngine (just like all the other platform drivers), rather than hacking multi-cam options into other places as well. Like that the new-multi camera could just be treated like any other camera (without any changes to upper levels) and eventually just come with a separate XML config file for the arrangement. Furthermore I'd would be great to implement some kind of stitching code and the according calibration in order to provide just a single frame to portvideo/reactivision. thanks for your consideration, Martin.K


Look at device tree :)


Why not setting dtype?


hebrew'


WTF?)))


wow!

I would have left a comment in the code pointing to bug! Because it is so tricky and it would be nice to remember it


all is cool!


Лучше temp определять прямо здесь, а не выше; т.к. она используется только в цикле и переопределяется на каждой итерации.


For reference: fix for [#158](https://github.com/ArmaLife/Altis/issues/158#issuecomment-180726930)


hebrew',


ENABLE_KDBUS is about picking a default setting, not about compiling out kdbus support. We do not support kdbus-less builds at the moment. Even with ENABLE_KDBUS disabled passing kdbus=1 on the kernel cmdline should still turn it on if it's available in the kernel.


Can you explain this part? The clocks do need to be started after reset. I tested this on the F0 and F4 using the RTC example and in both cases the RTC failed to start ticking again after a flash/reset sequence when the backup register magic number was present and this test caused the clock initialisation to be skipped.


Обычно ставят пробелы вокруг `:`, но здесь можно вообще без условия.
Это тот случай, когда можно переопределить аргумент (потому что по сути смысл у него тот же остаётся):

```
   k %= a.length;
   int[] temp = new int[k];
   ....
```


Ok well I fixed that, but there seems to be issues involving the sky renderer. I think you ought to have another quick look at this, Lex.


PlantCompBaseClassAgain (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1508 of 1508 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.7%25-green.svg)


' latvian'      : *latviski',


Is the first condition intended to be `resident_of == 'ceremony_country'` and not `resident_of != 'uk'`? I don't know anything about it, but the other `elsif` statements nearby seem to use the latter. If it is intentionally different, I think it would be worth explaining why in the commit note.


nljkhjlhhjkhjkhj


mbkkjbkjbjbj


@atfornes why launching an exception and stopping all the app here? This is making mobile new installs useless! https://github.com/P2Pvalue/teem/issues/163


+var supportedlanguages = [ 'english', 'french', 'hebrew', 'dutch', 'portuguese', 'romanian', 'spanish', 'turkish', 'brazilian',


"hebrew": "he",


+                &.flag-hebrew { background-image: url(../images/hebrew.png); }


Fixed in 6ad51b2.


bl_updated = true

...it's bool


kjbkkbjjbjk


I'd expand on the "here", not remove it, e.g. "if you were asked to enter a username and password during installation, we'd recommend not using the same details for a user as it may cause ..." sort of thing


sp: "separated" (should actually be "comma-separated" with a hyphen as well)


Very minor: It looks like there's an extra space between the first two phone numbers.


language can result in garbled EPG text; if this happens, don't panic, as you can easily change it later.


jjjnñ


"preferred"

Suggest something like "If you don't enter a preferred language, US English will be used as a default."


sp: "preferred" (even in US English)


Looks good 👍


"to allow"? "that you allow"?


I've copied your structure from npm then I edited it. I've my project at work so I can't check it now to make sure why this part is missing.
Maybe I deleted the validation unintentionally. Sorry!


"Internet, make"


Fixed with help of another user. Hopefully it works as designed ;)


Can we delete this line here?


replication is for stochatic model => duplicate


"the admin or a regular"?

"for any account (administrative or regular user)"?


Credits to Mohsen Lotfi (fox_one_fox_one)


No, this method is @api private


- определение `i` лучше в `for` запихать;
- я бы написал `i >= 0`, т.к. это условие на `i`, и вроде как это легче читается; но здесь можно поспорить...

```
for (int i = numberOfDigits - 1; i >= 0; i--) {
```


Which one?


l obviously did it in the wrong mod…


Nella versione inglese cercava di essere spiritoso, per questo l'ho tradotto così.


actually it seem to be ok for file also...


Referencing arduino/Arduino#4530


Is this definitely the right format for international phone numbers?

I'd have expected them to be more like `+359 (0)2 807 64 23`

* I wouldn't expect the international code to be parenthesised (the plus-sign is enough to distinguish it).
* I would expect an extra `(0)`, because you need to dial that if you're inside Bulgaria.

Looking through the code, it looks like we're being inconsistent about this elsewhere, so perhaps not a job for this PR, but something that would be worth clarifying with the content team.


`wet`?


Good idea to make them `public`.


This change has stabilized smelting to behave in a far more predictable fashion instead of randomly smelting individual cells in a furnace it will smelt two items per tick in all cells in a furnace.


But google suggest duplicate:
https://www.google.fr/?gfe_rd=cr&ei=0tO1Vui3K-Pt8wfRw7KoBw#q=%22replicate+a+file%22


Does this mean any extension not in this list will be unsupported? Is there a default catchall mecanism? For instance I would love to have support for `.frag` (fragment shader) or any `.txt` file (just as row text).


missing comma in "MySQL syntax" at the end of line


` let borderPath = starPath(sides, borderWidth: layer.borderWidth).bezierPathByReversingPath()` as Lex said, we need to add a new sublayer to draw the original border.


Known bug: Load Animation callback manager has to be corrected.


"Replicate" is used in several application as synonym of "clone", exactly what we do here. By chance, replicate is also a specific term for the stochastic models.


Produces warning on Xcode:
```
In file included from cmd/fixelcfestats.cpp:24:
./lib/sparse/image.h:124:23: warning: expression with side effects will be evaluated despite being used as an operand to 'typeid' [-Wpotentially-evaluated-expression]
          if (typeid (*buffer->get_io()) != typeid (ImageIO::Sparse))
                      ^
1 warning generated.
```


related to #9


I thought this was what the ST example did however my lse isn't working at all yet so I can't say, RTC_WaitForSynchro errors.
On Feb 6, 2016 05:53, Andy Brown <notifications@github.com> wrote:Can you explain this part? The clocks do need to be started after reset. I tested this on the F0 and F4 using the RTC example and in both cases the RTC failed to start ticking again after a flash/reset sequence when the backup register magic number was present and this test caused the clock initialisation to be skipped.

—Reply to this email directly or view it on GitHub.


Wouldn't it also make sense if the fat partition is marked bootable in the json? Maybe for some reason one want to have a fat data partition or whatsoever.


Yeah I read that, I just let the code since it was already here. Should I also removed all the `drawBorderPath` method?


@uce yes, I've already added _2.10 to my dependencies that are scala dependent... but I still get the build problem.


Aha. Já přemýšlel nad tím, k čemu to je vlastně dobré, když se to pak dále nepoužívá. Ted už vim :-D


@htollefsen Any reason this has been changed to `~5.5` ? I see that `ezsystems/ezpublish-kernel` also has PHP constraint set to `~5.5`.  Any ideas why?
See #45


Just committed the deletion.


I believe copies of the files must exists on the server.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14717](https://teamcity.mesosphere.io/viewLog.html?buildId=127394&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:03:38


aslında adresin doğrusu [şurası](http://zaferdemirkol.com/cik/) değil mi?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14718](https://teamcity.mesosphere.io/viewLog.html?buildId=127395&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:05:08


As mentioned already, please no separate list per event.


I would say that a replication is meant to stay an exact copy of the file (like in file replication system for safety), a duplication is more of a copy, but never-mind.


I should have mentioned that I tested with the LSI. Please let me know what happens for you when your LSE starts working. I would have thought that the principle was the same but you never know.


it's 2016 :-)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14719](https://teamcity.mesosphere.io/viewLog.html?buildId=127396&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 224 Build time: 00:04:06


Wunderbar. :+1:
Den pseudo Komponenten-Baum hätte ich gerne im Buch:
![bild](https://raw.githubusercontent.com/Angular2Buch/code/master/text/angular-routing/images/loesung.png)

https://github.com/Angular2Buch/code/blob/master/text/angular-routing/README.md
@GregOnNet @d-koppenhagen


@XhmikosR yes, thanks! SublimeText went too active; fixed my config ;)


My logic is indeed wrong. As soon as either of the two is true, it enables alldirection.

Your logic is flawed, too. Because 1&2 equals 0 - hence alldirections can never be true.
I'll fix it after the merge.


Super. Ještě trochu poladit - místo "zobrazit" třeba jen šipku a umožnit zase sbalit.


Danke. Blöder Denkfehler. Genauer müsste es >= sein aber macht kaum einen Unterschied


events have generic fields (`name`, `event_time`, ...) and event specific fields that should be in the `parameters` object.

Also `series` is a field for all events. A patch belongs to a series (except for patches before the introduction of the feature, of course).


This looks a bit familiar - does it exist in one of the other recent PRs?


The commit title needs to be shorter...

I'm really really not convinced this is needed. You've also split your patches too much, so I can't tell how you are using it from this patch alone.


:+1: best javadoc ever


Lol, my fault sorry. I was at school when i sent the pr and i used the online editor. I'll try to never use it in the future. xD


I did it because eZ did. And I bet eZ did it already because [Symfony 3.0.2 has done it](https://github.com/symfony/symfony-standard/blob/v3.0.2/composer.json#L14). I know doctrine (eq: [https://github.com/doctrine/cache/commit/24e3969cc60dcfab7804570116d3ac1aa22209cc]) has mixed up they're PHP requirements lately aswell.


put patch just after series


previous and new state should be serialized in the parameters JSON field.


why?


It feels a bit odd that this line is separate from the line within the partial, because the two feel very closely related.


In this commit you're modifying the model but there's no migration? migrations are needed when the SQL tables change so we can migrate DBs easily (https://docs.djangoproject.com/en/1.8/topics/migrations/)


I think it's wrong to make an Unresolved equal (and hence assignable) to anything but itself. It's only use today is where it is impossible to determine whether it's a resource type or a type alias. The only reason it exists is so that we can pass something to the catalog info service that prints itself in a sane way.

Making it assignable to something resolved with the same name cannot be correct. What if `Bar` is a specialization of `Foo`? Is a `Bar` then assignable to an `Unknown[Foo]`? Also, is `Foo[3,4]` assignable to `Unresolved[Foo[2,5]]`? If not, how do you know? After all, an `Integer[3,4]` is assignable to an `Integer[2,5]`.

Another interesting but related question would be, is `Resource[Foo]` assignable to a `Unknown[Foo]`? The intention when the latter was created might well have been to create the former.


Not grokking this. Read-only /var shouldn't be result in the log message being dumped with rubbish unnecessarily. I am fine with adding an info log message, but LOG_ERR, sounds too much?

Also, if don't think it's necessary to print an extra error msg if we failed to open the device for reading for the fact that we then also didn't manage to open it for writing...


cuz the right shift gotta get turned into a division by "1 << shift" (the sign bit gotta stay as the first bit, it cannot be shifted elsewhere along with other bits by the >> operation)
and then, with both << and >> in the expression, you gonna end up with something that's not any less complicated than the expression above...


PlantCompRefactorHackathon (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2089 of 2089 tests passed, 329 test warnings)

 * 334 tests had: AUD diffs.
 * 329 tests had: BND diffs.
 * 12 tests had: ERR diffs.
 * 10 tests had: ESO small diffs.
 * 7 tests had: MTR small diffs.
 * 6 tests had: EIO diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Removed


Thanks. Removed.


or


why the else? it's not needed here


Working on this now with code from fbartels fork. So far my investigation centers around ntfs-3g and timestamp failures when rsync copying files from sdcard to an ntfs formatted drive. I've not had problems with empty files but I am wondering if rsync pushes the device too hard and something keels over causing rsync to throw a "rsync error: received SIGINT, SIGTERM, or SIGHUP".


Do not change lines that you don't need to change for that commit. Cleanup patches should be separate.


PlantCompRefactorHackathon (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@boblail there is no readme around not installing brewcask anymore in a "puppet-brewcask" module. Any info the potential readers might be missing ?
Thanks


I like it. 👍


I fixed it.


ERROR: Missing a Javadoc comment.


FATAL: [MissingTranslation] "`invalid_url`" is not translated in "hi" (Hindi), "ro" (Romanian), "zh" (Chinese), "zh-CN" (Chinese: China)
 If an application has more than one locale, then all the strings declared in one language should also be translated in all other languages.

If the string should *not* be translated, you can add the attribute `translatable="false"` on the `<string>` element, or you can define all your non-translatable strings in a resource file called `donottranslate.xml`. Or, you can ignore the issue with a `tools:ignore="MissingTranslation"` attribute.

By default this detector allows regions of a language to just provide a subset of the strings and fall back to the standard language strings. You can require all regions to provide a full translation by setting the environment variable `ANDROID_LINT_COMPLETE_REGIONS`.

You can tell lint (and other tools) which language is the default language in your `res/values/` folder by specifying `tools:locale="languageCode"` for the root `<resources>` element in your resource file. (The `tools` prefix refers to the namespace declaration `http://schemas.android.com/tools`.)


@mhl: Will a bare `decode` actually work here in Python 2? I think it's passing the test only because the body contains no Unicode characters.


Hahahaha B)


Same here.


@bkomboz two issues identified:

1. Merge rate is 1.00 and not 0.50 in the second case.
2. Message refers to base table, which makes it not commutative from the message point of view but that would be ok for me.

What do you suggest? We can leave it like this and document that it is used to check a foreign key constraint but in a weak way (that does not fail if merge rate is not 100%). I think this is what @zchen would want (if he was actually responsive).


Hey @sheerun we use to build opinionated images with packer providing them with the software that ansible would have the chance and responsibility to run (usually as services) so the expectation here is just the tool to be there.
Then the runtime server specs check that the expected services are actually running https://github.com/Capgemini/Apollo/blob/master/tests/spec/docker/docker_spec.rb

We have moved to coreos removing the packer dependency on devel branch which we aim to merge on master soon https://github.com/Capgemini/Apollo/tree/devel


@maxnet can you please review my port of this fix here?
https://github.com/raspberrypi/noobs/compare/master...NicoHood:datapartitionfix?expand=1

I carefully tried to compare the newer version and applied the required changes.
I did not indent the lines of the new if statement. I'd do this in a later commit to keep things cleaner.

cc @procount

Thx.


Umm, you're adding comments to a commit that was made over 2 years ago! (which would seem to me to be pretty fruitless)

If you have comments about the current codebase, then feel free to open an issue.


Chybička se vloudila :))


you are using git for the sake of history ;)


Jj, vlastně by tam pak nemusel být ten nadpis.. Jak je podtržený, tak moc trhá celý ten dialog


I think there are problems with the get_current_user middleware. In particular with django running on different threads of the same process, this will be wrong.


@Defman21  wow you're fast, great work :+1:
I see you're adding the IE10 support, the only thing I'm missing in you're commit is the `display: -ms-flexbox`


changed


The natural thing to do here would be to use type inference, and say:
```
def instance?(o, guard)
  assignable?(TypeCalculator.instance.infer(o), guard)
end
```
which of course would break miserably if `o` contains self references since the type inference doesn't use guards.

In other words, if we want to guard against self referencing data, then we must sift through the Puppet code-base and find all potential dangers. There will be several. Do we want "securing self referencing data in Puppet" part of the task of adding type aliases?


I'm not sure I can override 'display' property via `constants_css_microsoft_extensions.py` to add a specific -ms-* value. I'll try of course.


The test described in the comment below. The code tests if the type is recursive or not.


Pretty sure that png isn't in diaglogs but in info, so this won't work i think


It looks like it might in this particular instance: https://github.com/Pylons/webob/blob/1.4-branch/webob/response.py#L396.


Were you able to get this to work?  I am getting stuck try to get this to compile cleanly using tsc 1.8.
Maybe I am missing something.  I get an error due to default:
`TypeError: expect_1.default is not a function`

I use the following import and compile using commonjs as the module type.
`import expect from 'expect';`

When used.
typescript:
```javascript
expect("test").toEqual('test');
```
Generates the following code:
```javascript
expect_1.default("test").toEqual('test');
```
But, the expect library doesn't export a default for commonjs.  The following code tends to clobber the .default field in the export.
```javascript
exports['default'] = expect;
module.exports = exports['default'];
```
If you have suggestion on where I am going wrong, they would be most helpful.


stay under 80 chars


It's hard to perform & and | operations on symbols. This is an internal and performance critical part of the code. The class documentation should make it clear enough what the numbers are about.


Какой шрифт указывать альтернативным? В спецификации про это ничего нет. Семейство добавил.


you can be more succinct with your variable names: event, patch, user.


Not really. It used to compile 'undef' and then compile+evaluate the rest of the code. That was wrong and didn't work for some test cases since the latter evaluation didn't evaluate "Model::Definition" objects. All test cases that uses this code still works as expected.


This is an unsigned comparison (JNB) in sq6.

But I think it's '< 0xFFFFFFFFE' rather than '<='


@Walkman100 lol soz. Meant to be `wget`.


PlantCompRefactorHackathon (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (957 of 957 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.89%25-green.svg)


Note: this doesn't actually solve anything. It was just pure luck while I was testing it, but reappeared later.


Because I cluttered the model with logic. Will remove that (and this).


I commented this commit, because I based my fixes on this to the **new codebase**.
If you could have a look, that'd be pretty awesome.

The bugs are still in the code (even though it could have been fixed 2 years ago), so i wanted to do that now and help with it a bit =)

I currently have not tested it, because i have very weird sd card problems. If it works, I will create a PR for it.


Does this really do anything good or is it paranoia?


magnetomotive force (mmf)


flux?


angular velocity?


torque?


I simply forgot to remove that modification before I committed. Done now


Right, I looked a bit into that. I'd rather not use this at all, but well, because of how the patch edition is currently working I think we'll have to.

For the record, my preferred solution would be to override save() on patches and pass the `request` to save() when we can, store the request in the patch instance and use it from the notification handler.

For now though, can we at least have https://github.com/jedie/django-tools/blob/master/django_tools/middlewares/ThreadLocal.py?

(this actually comes from the Web Development with Django Cookbook and not original code from this project).

Probably rename the middleware class to ThreadLocalRequest or something.

You also need to add the middleware to the settings


Are you changing the API?


so, i need to write in this note.


Need the series here as well


Delete this file from the patch


Remove this unused import


JO, So ein Bäumchen ist gut. Dann aber einen kompletten für unseren finalen BookMonkey


The commit message needs some work. You don't need to add everything you've done.

When making the new event like the previous one, you won't need to have more classes here, just add the patch field


Remove unused method


squash that commit with the one introducing the feature.


This commit is not needed when using `events` as the only API entry points for events.


Das :evergreen_tree:chen wächst mit dem Code.


Was an unchecked exception before, is now extending `Exception`. Intended?


I don't think we need this with using `/events/` as the only event API entry point


Fixes like that should be squashed in the original commit.


Is leaving in this `print` intentional? It looks somewhat confusing to see a bunch of such refresh messages in the core buffer when modifying parent options while having iset buffer open.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14720](https://teamcity.mesosphere.io/viewLog.html?buildId=127400&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 223 Build time: 00:05:08


I think we can make this different... No menu button extra is required...
We can check for conflict and add the function ignore yes/no in the list (at the bottom) in case there is really a conflict... at least this is what I think you try to archeive.


Rails add a [`#sum` method][1] to `Enumerable`, so I think you could do `@benefits.values.sum` here.

[1]:http://api.rubyonrails.org/classes/Enumerable.html#method-i-sum


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14721](https://teamcity.mesosphere.io/viewLog.html?buildId=127401&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 223 Build time: 00:03:50


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14722](https://teamcity.mesosphere.io/viewLog.html?buildId=127402&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:16


csv files should be inside the data folder


The only issue I can see is that calling `Trakt['users'].likes('lists')` won't automatically refresh expired OAuth tokens, you should be see other authenticated requests fail if your token was expired though..

Have you tried another Trakt.tv account? or re-authenticating your Trakt.tv account?


fixed.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14723](https://teamcity.mesosphere.io/viewLog.html?buildId=127403&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:44


ok, i hope so, would be nice :smile: , but if it's imposible, it just is what it is.


Neither of them returns a result.


super


can rename this "instant crash script"


This won't work just as intended, you'll need a few extra lines as the GT machine recipes don't mix right with oredicting like this and there are two compatibility which don't seem be oredicted properly accorrding to NEI. The following should hopefully work, I've also included removing the recipe of the OC PCB. Not sure what to do about the RAM recipe with OC PCB still being visible, shouldn't matter too much though.

`
recipes.remove(<computronics:computronics.ocParts:4>);
recipes.addShaped(<computronics:computronics.ocParts:4>, [[<ore:oc:ram2>, <ore:oc:circuitChip2>, <minecraft:brick>], [<ore:oc:materialCircuitBoardPrinted>, <ore:oc:lanCard>, null]]);
recipes.remove(<SGCraft:ocInterface>);
recipes.addShaped(<SGCraft:ocInterface>, [[<ore:ingotIron>, <ore:ingotNaquadahAlloy>, <ore:ingotIron>], [<ore:oc:cable>, <ore:oc:circuitChip1>, <ore:oc:cable>], [<ore:ingotIron>, <ore:oc:materialCircuitBoardPrinted>, <ore:ingotIron>]]);
recipes.remove(<OpenComputers:item:32>);
recipes.remove(<OpenComputers:item:30>);
furnace.remove(<OpenComputers:item:31>);
Assembler.addRecipe(<OpenComputers:item:1>, <OpenComputers:item:24> * 3, PCB * 3, null, 250, 32);`


Do you think we need this line?


Use ```tpl.$``` or ```tpl.find``` instead of pure DOM API


This line was cool!


So why did you AT me?


This is a good change, but I think (at least at this point) the flow is setting attributes as float values on the calculator. I suspect the `format_money` method is working ok, but I think it was really intended to be used with instances of `Money`.

If it's not too hard a change to make, I think it would be good if the flow set attributes as instances of `Money` on the calculator and the `#total_benefits` and `#benefits_cap` methods on the calculator also returned instances of `Money`.


cool, even with tests :)


Don't forget about semicolons!


History content is now present in the [CREDITS.md](../blob/master/CREDITS.md) file.


I'm reverting these changes because afaics you're doing exactly the same as the code except it's more complex, and has nothing to do with the commit title.


It feels slightly odd to introduce the `parent` value here without actually making use of it in the `benefit_cap` method.


BTW, you can compile this into a phar and let users run it by double clicking the phar.


Did you intend to post this remark to this line? I'm up for a discussion on this topic, but it'll have to happen elsewhere.


I think yes...


Ich würde eher einen Baum im Routing-Kapitel einführen, damit man die Hierarchie sieht.
Für den kompletten bookmonkey bietet sich natürlich auch nochmal einer an.
So ein Baum kann auch schon in den Routing-Grundlagen kommen und die Hierarchie des Beispiels zeigen.


Thanks!


Well spotted! It would be nice to do the change from `assert` to `assert_equal` as a separate commit earlier in the PR.


Semicolons!


Added name property for Autblind State items.
Added manuell state item.
Added eval_trigger property for manuell state item.
Added as_repeat_actions to rules.
Added $order property to state items.


The name of this method (`group_name_for_postcode`) doesn't suggest to me that it will be changing the state of anything, so I'm surprised to see the assignment to `group_names[postcode]` on the last line.


This naming is not consisted with `_parse_smil` (returns info dict) and `_parse_xspf` (returns list f info dicts), So better to rename to `_parse_mpd_formats`.


Thanks a lot!


Do we *definitely* know that further devolution of rates is going to happen? If not, I'd be tempted to simplify the code a bit and worry about it if/when it happens.


@babobski fixed on https://github.com/Defman21/KomodoEdit/commit/b3c9e50f9b8ebe1058e87f065219ea1155359455


*sigh* I should stop pushing code when drinking...

Thanks again!

https://github.com/Room-11/Jeeves/commit/54b74c63e20a8abf4532a0bf2e3bf0f6ff335cfc


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14724](https://teamcity.mesosphere.io/viewLog.html?buildId=127407&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 223 Build time: 00:11:25


can't you do this in the sink? at the start of this method the factory is asked if it has dts support (and i guess this "question" is passed down into the sink - so the sink could decide to not support dts with samplerate other then 48000...


upstream check was

#if !defined(__arm__) && !defined(TARGET_ANDROID)

you do this by intention here for arm aswell?


Looks like you were here in python world, too ;-)


I can't quite put my finger on it, but the combination of this method and the ones it depends on feel a bit more complicated than they need to be. Sorry that's not very helpful, but I found this method quite hard to follow.


@Defman21 nice, that's awsome, full IE10 support:+1:.


This will fail if non mpd XML passed in.


I wonder whether it might be clearer to name this method `non_default_benefit_cap_rate_groups` to be clear that it doesn't include the `default` group...?


It would be nice to introduce some kind of adapter class to remove the duplication that this method introduces (see `LandlordImmigrationCheckCalculator#areas_for_postcode`.


@PEMapModder Agreed


This 404 error doesn't seem right.


nope, now you always go for January ... this year or next year; you want next month (which could be January next year)


these changes don't really belong into this commit do they?


There's so much going on in this commit, I can't say for certain that it's all ok. It would be nice if we could find a way to split it up into multiple smaller commits.


This code still has a bug though.


no newline before EOF?


here too


please put that into `.misc/deps.sh`


cc @redox in the end I inlined the zepto latest build in our package. That was the safest and most up to date thing.


@lsm5 this `notify` is preventing the plugin from running in rawhide, removing it will make this work again.
Also, is there any way to start the docker daemon and before starting it this plugin is started? cause right now, if you start the plugin systemd gets docker daemon up but not the other way around


PlantCompRefactorHackathon (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1508 of 1508 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


there's no sd_nofity listener in the plugin :/


@larsiusprime Everything still working the same on my end here (I didn't change any of the actual IDs, mapping etc), but you have a lot more hardware to test with.

Two pieces of dead code (I think anyway) that I've removed:
- `OUYAID` had two `LEFT_TRIGGER_FAKE` / `RIGHT_TRIGGER_FAKE` values that were unused
- the `FLX_GAMEPAD_API` section of  `MayflashWiiRemoteID` defined `axisIndexToRawID()` and `checkForFakeAxis()`, but those are only used on `FLX_JOYSTICK_API` as far as I can tell


Added Blind SQL Injection


Being _pedantic_, shouldn't this be a .txt file rather than a .css one


Apparently Sublime shows `Form Feed`s, but what about `Vertical Tab` (ASCII 11)?


Why did you revert this?


ну, чего ж сразу конструктор-то.. можно было и  reviews = [];


P_UseSpecialLine checks that shootthing is the player, so no need to check (incorrectly) in PTR_ShootTraverse.


追加ありがとう


this is like the _parse_smil_namespace the root of every mpd manfiest is an MPD element.


@rhatdan PTAL


These tests are fairly quick, and if anything breaks I do like to know immediately what broke exactly. I'd prefer it split up.


А давай мы его потрем. Как-то он тут не к месту, да и скоро мы от этого инлайнового безобразия избавимся


No, in smil it has `default=None`.


Да и ты опять не написал что там внутри Array - не взирая на условия задачи, в которых даже написано, что там


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1307](http://teamcity.monogame.net/viewLog.html?buildId=14403&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Removed unnecessary files


а там ниже есть прикольные классы типа review-rating-two, review-rating-five...


в общем, верни как было


Arkady.  Remove the document wrapper.  Begin with: \newglossaryentry
Okay?


А давай мы вынесем эту проверку за пределы функции отрисовки отзывов.


i will add default=None.


Thanks. Please add the update for the sleeper druid as well.


Не знаю, может Игорь в этот раз решил утаить эту инфу, но вообще, он обычно сообщает, что блок с template в ie надо еще и прятать


Use `InnerFormatter.WriteHyperlink` instead, so this becomes clickable in the GUI.


Looks good


You should add "_book" to uour .gitignore; it should mot be stored in the git repository.


This changes the division behavior for the whole file and may be unwanted. Why not just use float conversion and standard `/` and `//` whereever you need?


Known bug: Load Animation callback manager has to be corrected.


Actually this is bogus! I should instead check that we're looking in /usr/share/icons - I was picking up a /usr/share/themes/Adwaita/index.theme here.

Can't fix that right now (desktop is turned off), but will later.


@salimane I agree that the current readme should be updated as it still says

> A module which installs homebrew-cask, and `brewcask` provider for Puppet's `package` type.

Maybe it could be shortened to something like

> A module which provides `brewcask` provider for Puppet's `package` type to allow installation of casks.

Do you agree / would you mind sending a PR?


Too bad this isn't identified as a string. May want to raise an issue about ut.


Yes, not sure we need it but anyway having spaces at the beginning and/or end of your text is probably not a good practice.


Oh no something is wrong with it
Please send help


It's just a bit of an optimisation, clearly not going to solve all cases - but should help in some. :)


I'm not sure if *all* projects need to use Travis -- not everything needs a build step (static sites, curriculum projects)

Otherwise, this is a great list! You might be interested in seeing our list of requirements to get on [Mozilla Science Collaborate](https://www.mozillascience.org/collaborate):
https://github.com/mozillascience/plan/issues/47#issuecomment-179852524


concordo tambem.

deem uma olhada nesse código de conduta, talvez possamos nos basear em algo mais simples e genérico que possa ser utilizado por qualquer projeto que membros do GTI estiverem desenvolvendo.

> Criadores da iniciativa, desenvolvedores principais, e a equipe núcleo, constituem os membros da gestão do projeto e tem prioridade sobre as decisões do projeto.

> Suas contribuições são um resultado esperado da sua participação no projeto. Não espere que os outros trabalhem por você ou lhe ajudem com o seu trabalho para sempre.

> Tenha em mente o contexto voluntario desta iniciativa, ninguém deve justificativas sobre quantidade de tempo dedicado ao projeto. Não exija dos indivíduos o que eles não estejam dispostos a contribuir.

> Todos os membros têm as mesmas oportunidades para buscar quaisquer desafio que lhes interesse dentro do projeto.

> Sua posição e influencia nesta iniciativa será proporcional ao acumulo de suas contribuições que resultaram direta ou indiretamente no sucesso do projeto.

> O desenvolvimento de software é um processo evolutivo: as soluções mais adaptadas aos desafios devem substituir implementações menos eficientes. A vantagem técnica e adequação aos requerimentos, incluindo financeiros e de pessoal disponível, são as métricas de avaliação primárias.

> Este é um espaço para a perícia técnica e nutrição destas habilidades; tópicos fora de escopo do projeto ou conflitos de natureza não-técnicas serão direcionados para serem discutidos em outros espaços.

> A perturbação continuada das atividades será considerada hostil ao andamento do projeto e poderá ocasionar na moderação de conteúdo.

> Características individuais, incluindo mas não limitadas a, corpo, sexo, preferência sexual, etinia, língua, religião, nacionalidade ou afinidade ideológica são irrelevantes no âmbito deste projeto e não serão consideradas para o julgamento do seu valor ou a da sua contribuição para o projeto.

> Priorizem discutir ou debater a ideia, não a pessoa.

> Tenha precisão e seja concisa(o) na sua comunicação: Ambiguidade será atendida com questionamento; mais ambiguidades serão respondidas com silêncio. É da responsabilidade da entidade que origina a comunicação que forneça contexto quando solicitado.

> Se algo é ilegal fora do escopo do projeto, é ilegal no âmbito do projeto. Este código não têm precedência sobre a lei vigente nas regiões onde os colaboradores residem e trabalham.

> Este código rege os procedimentos dentro das atividades do projeto não as atividades, comunicações e comportamentos fora dela.

> A participação no projeto equivale a um acordo deste código de conduta.


please merge it in 0.13.2


Hi Krzysiek,
is this val used?

README.md mention that ZooKeeper (at localhost:2181) is needed for tests but I found "localhost:2181" only here. Then I see that val zkHost is probably not used anywhere (if that is true then maybe it is worth to update README.md too).


Ah right, `pkg` contains this, was looking in `Theme`. Can use that then.


I recently did a `make clean` then confirmed with a fresh checkout.   This error keeps popping up in this branch (500-crypto-api):

../../libraries/chain/libgraphene_chain.a(types.cpp.o): In function `graphene::chain::extended_public_key_type::operator fc::ecc::extended_public_key() const':
/home/jcalfee/graphene/libraries/chain/protocol/types.cpp:139: undefined reference to `fc::ecc::extended_public_key::deserialize(fc::array<char, 78ul> const&)'
../../libraries/chain/libgraphene_chain.a(types.cpp.o): In function `graphene::chain::extended_private_key_type::operator fc::ecc::extended_private_key() const':
/home/jcalfee/graphene/libraries/chain/protocol/types.cpp:193: undefined reference to `fc::ecc::extended_private_key::deserialize(fc::array<char, 78ul> const&)'
collect2: error: ld returned 1 exit status


ver 1.0.62:
  add check for invalid frame rate

ver 1.0.61:
  enable resolution change report for vp8 and H.263

ver 1.0.60:
  fix the inaccurate crop info for vp8

ver 1.0.59:
  handle the special gop size in order to pass some CTS tests in which large gopsize will be set


Thank you for this. :P


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14725](https://teamcity.mesosphere.io/viewLog.html?buildId=127421&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:47


It meant to be #491


И не дурно было бы сделать это функцией, а не через if. То есть один раз проверить, а потом просто использовать результат. А сейчас у нас на каждый вызов getReviewTemplate отрабатывает проверка, что итого около 17 раз. А зачем?


because the default behavior is confusing.
the calculation of the number of segments was wrong and was expecting it to calculate the right number.
by adding this the use of `/` and `//` will consistent between python2 and python3.


next step: try to use `@` to call by name. it usually works as a better _notification_, and only notifying option if the person isn't in the conversation / issue / comment thread.


I've made some refinements to this, see https://github.com/zeromq/libzmq/pull/1776


Нет,  элемент реализется символами.


I don't know. Is your log change into link or just doesn't go to code? Is your log format is similar to that from my screen?


This change broke the descriptor code


I'm aware of the rationale for `__future__ division` but we are not yet agreed to use it in the codebase that's why there are lots of places where `//` is used. So we should be consistent in this.


Arg yes I forgot to publish a new version of that. We'll also mark this new version as a major update in the algolia.com dashboard.


А тут вообще подстава=) Тебе весь код отрисовки рейтингов просто не нужен. Там суть в том, чтобы не плодить спаны, а в том, что бы поставить класс правильный, в зависимости от пришедшего рейтинга. То есть если в json у тебя рейтинг два, то на спан вешается класс review-rating + review-rating-two. То есть ты крут, что сам делаешь звезды, но вообще это не так надо реализовать. Нужен массив с рейтингами arr =  ['one', two ..] и в зависимости от пришедшего рейтинга, ты дописываешь класс, забирая значение из массива. Пришел рейтинг 4, ты извлекаешь из массива строку с индексом соответствующим и дописываешь к классу


Refactor-Rich-CoolingTower1Spd (energy-plus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1900 of 2089 tests passed, 144 test warnings)

 * 334 tests had: AUD diffs.
 * 329 tests had: BND diffs.
 * 67 tests had: ESO big diffs.
 * 195 tests had: MDD diffs.
 * 212 tests had: MTD diffs.
 * 232 tests had: RDD diffs.
 * 169 tests had: Table big diffs.
 * 173 tests had: MTR big diffs.
 * 3 tests had: EIO diffs.
 * 2 tests had: ERR diffs.
 * 1 test had: ESO small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-90.95%25-yellow.svg)


我会format一下


We have marked the Travis CI status as a "nice to have", not an absolute requirement. We are using a severity level for each check to indicate this.


ok i will remove it and surround all the numbers in the _parse_mpd_formats with float.


как не хорошо оставлять console.log


Thanks.


It's not intentional, thanks for reporting it!
I'll commit a new version in a few seconds.


На консультации спрошу.


Удалил.


я просто не ищу лёгких путей


Refactor-Rich-CoolingTower1Spd (energy-plus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Sure!


This commit does not fix the issue. Can you please provide a live example?


hi @xfurry
Yes i did some work for that quest.
- part with sound on quest start is fixed - will add it soon*
- also i have working part with sound for using item*
here i need to ask you...
i fixed it using eventAI for event play sound on spellhit ... and question to you.
- can wee update sd2 script... that we can use sd2 and EAI together?
- or you prefer to do that directly by sd2??

Last part with abush - not done yet, but as i said before... i have a good concept for it :)
and will work on it... soon*

And now:
Smth shit happened yesterday... i tried to compile fresh comangos with your updated script for this q. and
i recived an error and have no idea how to fix it :/ so at the moment my work is on hold :(
If you can help ...more info u'll find here:
https://github.com/cmangos/issues/issues/853
Thank you.


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


Check commits before push ;)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1307](http://teamcity.monogame.net/viewLog.html?buildId=14403&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:36:21


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1308](http://teamcity.monogame.net/viewLog.html?buildId=14407&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


I have added two lines outlining what MusicMates is and what we are going to do today


I believe that would raise NameError


Please remove commented code


Remove this


SEMICOLON!!!


Two empty lines between blocks according to PEP8


Add empty line


> Arg yes I forgot to publish a new version of that.

Actually, I was in the middle of understanding why Travis is complaining /o\


The ` == true` doesn't look right. Did you mean  `item->data(Qt::UserRole).toMap().value("bootable", true).toBool()` ?


Remove two empty lines


Space


please make wii u emulator


Commented code


Shouldn't it be:

    RECALBOX_LOGFILE_PATH = "/recalbox/share/system/logs/recalbox.log"

?


@manunes tomei a liberdade de formatar o índice como uma tabela :)


This gets printed without this patch:
```
WARNING: Token 'COLON' defined, but not used
WARNING: Token 'COMMENT' defined, but not used
WARNING: There are 2 unused tokens
Generating LALR tables
```


It is really necessary to get the #{HOMEBREW_PATH}/bin.


Apple Docs say to do it, their example code does it, and most apps that I've checked also do it. I did it in the original iOS sink code and someone removed it later :) I suspect that 'most' of the time, the buffers are zero but your mileage might vary.