import scala.math._

import scala.concurrent._
import ExecutionContext.Implicits.global
import scala.concurrent.duration._
import scala.util.control.Exception.By
import scala.collection.mutable.PriorityQueue
import scala.collection._

object ProjectEuler extends App {

  def permutations(items: List[Int]): List[Int] = items match {
    case Nil => List[Int]()
    case h :: t => {
      var res = List[Int]()
      for ((item, index) <- items.zipWithIndex) {
        val (pre, pos) = items.splitAt(index)
        for (permList <- permutations(pre ::: pos.tail))
          res = res ++ List(item + permList)
      }
      res
    }
  }

  def binary(num: Int): String = {
    def base2(num: Int): List[Int] = {
      if (num / 2 == 0) List(num)
      else {
        val rem = num % 2
        val newnum = num / 2
        rem :: base2(newnum)
      }
    }
    base2(num).mkString
  }

  def isPalyndrome(num: Int) = {
    val decStr = num.toString
    if (num.toString == num.toString.reverse) {
      val binNum = binary(num)
      binNum == binNum.reverse
    } else {
      false
    }
  }

  def problem36(): Int = {
    val res = for (n <- (1 until 1000000) if isPalyndrome(n)) yield n
    return res.reduce { (acc, item) => acc + item }
  }

  def isPandigit(num: Int): Boolean = {
    val digitSeq = num.toString.map(_.asDigit).distinct
    digitSeq.size == 9
  }

  def products(maxRange: Int): Seq[(Int, Int, Int)] = {

    val res = for (
      multiplicand <- 1 to 5;
      multiplier <- 1 to 5
    ) yield { (multiplicand, multiplier, multiplicand * multiplier) }
    res
  }

  def problem32(): Int = {
    //We shall say that an n-digit number is pandigital if it makes use of all the digits 1 to n exactly once; for example, the 5-digit number, 15234, is 1 through 5 pandigital.
    //The product 7254 is unusual, as the identity, 39 × 186 = 7254, containing multiplicand, multiplier, and product is 1 through 9 pandigital.
    //Find the sum of all products whose multiplicand/multiplier/product identity can be written as a 1 through 9 pandigital
    // multiplicand multiplier plus product shud be concatenated, taken as a set and verify length is 9
    // it means that the lenght of multiplicand+multiplier+product must be 9, otherwise we skip
    1

    //val res = for( multiplicand <- 1 to 1000,
    //     multiplier  <- 1 to 1000,
    //     if  multiplicand * multiplier < 987654321) yield {multiplicand, multiplier}

  }

  def parenthesisBalanced(strList: List[Char]): Boolean = {

    def _innerBalanced(count: Int, resList: List[Char]): Boolean = (count, resList) match {

      case (0, Nil) =>
        println("zero case"); true
      case (-1, _) =>
        println("minus one"); false
      case (x: Int, h :: tl) => {
        println("standard case for:" + x);
        if (h == ')') _innerBalanced(x - 1, tl)
        else if (h == '(') {
          println("adding 1 to open parenthesis")
          _innerBalanced(x + 1, tl)
        } else
          _innerBalanced(x, tl)
      }
    }

    _innerBalanced(0, strList)

  }

  def isPrime(n: Int) = {
    (2 to sqrt(n).toInt).forall(n % _ != 0)
  }

  def primesUpTo(n: Int) = {
    for (candidate <- 2 to n if isPrime(candidate)) yield candidate

  }

  def pFactors(n: Int) = {

    def _primeFactorsFor(candidate: Int, primeList: List[Int]): List[Int] = (candidate, primeList) match {

      case (1, h :: tl) => List[Int]()
      case (num, h :: tl) => if (num % h == 0) {
        h :: _primeFactorsFor(num / h, primeList)
      } else {
        _primeFactorsFor(num, tl)
      }

    }
    val primes = primesUpTo(n)
    _primeFactorsFor(n, primes.toList).distinct

  }

  def goldblachOtherConjecture(): Int = {
    1

  }

  def isConsecutive(first: Int, second: Int): Boolean = {
    second - first == 1
  }

  def consecutivePrimeFactors(numOfDistinctPrimes: Int, start: Int, resultSize: Int): List[Int] = {

    def _primeFactors(n: Int, currentResult: List[Int]): List[Int] = {
      val factors = pFactors(n)
      if (currentResult.size == resultSize) {
        currentResult
      } else {
        if (factors.size == numOfDistinctPrimes) {
          if (currentResult.isEmpty) {
            _primeFactors(n + 1, currentResult ::: List(n))
          } else {
            if (isConsecutive(currentResult.last, n)) {
              _primeFactors(n + 1, currentResult ::: List(n))
            } else {
              println("Skipping. " + currentResult.last + " and " + n + " are not consecutive")
              _primeFactors(n + 1, List[Int]())
            }
          }
        } else {
          _primeFactors(n + 1, List[Int]())
        }

      }
    }

    _primeFactors(start, List[Int]())

  }

  def createCustomFutureFor[A](f: => A): Future[A] = {
    Future {
      f
    }
  }

  def testFun(numOfPrimes: Int, resultSize: Int, start: Int): List[Int] = {

    def createFutureFor(f: => List[Int]): Future[List[Int]] = {
      Future {
        f
      }
    }

    val solutionFunction = consecutivePrimeFactors(numOfPrimes, _: Int, resultSize)
    val firstFut = createCustomFutureFor { solutionFunction(10) }
    val secondFut = createCustomFutureFor { solutionFunction(10000) }

    val firstComplete = Future.firstCompletedOf(List(firstFut, secondFut))

    val res = Await.result(firstComplete, 1.day)
    //#satisfiesAll(startingTriangle)
    println("Out")
    res

    //consecutivePrimeFactors(numOfPrimes, start, resultSize)
  }

  def problem47(numOfPrimes: Int, resultSize: Int, start: Int): List[Int] = {
    List(1, 2, 3)
  }

  def createFutureFor(startPoint: Double, f: Double => (Double, Double)): Future[(Double, Double)] = Future {
    //satisfiesAll(startPoint)
    f(startPoint)
  }

  def problem45(startingTriangle: Double): (Double, Double) = {

    val firstFut = createFutureFor(startingTriangle, satisfiesAll)
    val secondFut = createFutureFor(500000000, satisfiesAll)

    val firstComplete = Future.firstCompletedOf(List(firstFut, secondFut))

    val res = Await.result(firstComplete, 1.day)
    //#satisfiesAll(startingTriangle)
    res
  }

  def satisfiesAll(n: Double): (Double, Double) = {
    //println(s"Checking if Triangle($n) satisfies all conditions")
    //val trian = Triangle(n)
    val hex = Hex(n)
    if (Pentagonal(hex)) (hex, n) //&& Hexagonal(trian))
    else
      satisfiesAll(n + 1)

  }

  def Triangle(n: Double): Double = {
    n * (n + 1) / 2
  }

  def Hex(n: Double): Double = {
    n * (2 * n - 1)
  }

  def Pentagonal(n: Double): Boolean = {
    val pent = (sqrt((24 * n.toDouble) + 1) + 1) / 6
    pent - floor(pent) == 0
  }

  def Hexagonal(n: Double): Boolean = {
    val hex = (sqrt(8 * n.toDouble + 1) + 1) / 4
    hex - floor(hex) == 0

  }

  def problem50(limit: Int): Int = {

    /**
     * The prime 41, can be written as the sum of six consecutive primes:
     * 41 = 2 + 3 + 5 + 7 + 11 + 13
     *
     * This is the longest sum of consecutive primes that adds to a prime below one-hundred.
     *
     * The longest sum of consecutive primes below one-thousand that adds to a prime, contains 21 terms, and is equal to 953.
     *
     * Which prime, below one-million, can be written as the sum of the most consecutive primes?
     */

    val allPrimes = primesUpTo(limit).toList

    //val myfut = createCustomFutureFor {sumOfMostConsecutivePrimes(allPrimes, limit)}

    val res = sumOfMostConsecutivePrimes(allPrimes, limit) // Await.result(myfut, 1.day)

    res

  }

  def sumOfMostConsecutivePrimes(primes: List[Int], limit: Int): Int = {

    def findConsecutiveSums(primeList: List[Int], currentResult: List[Int]): List[Int] = {
      if (primeList.isEmpty || primeList.head > limit) {
        currentResult
      } else {
        val currentSum = primeList.reduceLeft((acc, item) => if (acc + item < limit) acc + item else acc)
        if (primes.contains(currentSum)) {
          findConsecutiveSums(primeList.tail, currentSum :: currentResult)
        } else {
          findConsecutiveSums(primeList.tail, currentSum :: currentResult)
        }

      }
    }

    val res = findConsecutiveSums(primes, List[Int](0)).filter(item => primes.contains(item))
    res.last
  }

  def problem46(): Int = {

    /**
     *
     * It was proposed by Christian Goldbach that every odd composite number can be written as the sum of a prime and twice a square.
     *
     * 9 = 7 + 2×12
     * 15 = 7 + 2×22
     * 21 = 3 + 2×32
     * 25 = 7 + 2×32
     * 27 = 19 + 2×22
     * 33 = 31 + 2×12
     *
     * It turns out that the conjecture was false.
     *
     * What is the smallest odd composite that cannot be written as the sum of a prime and twice a square?
     *
     */

    def goldblachOther(oddNumber: Int): Int = {
      if (isPrime(oddNumber)) {
        goldblachOther(oddNumber + 2)
      } else {
        // get all the primes up to the number
        // for each prime subtract the prime from the odd, split in two and check if remainder is a perfect root
        val primesDivisors = primesUpTo(oddNumber)
        val res = primesDivisors.exists(item => {
          val sq = sqrt((oddNumber - item) / 2)
          sq - floor(sq) == 0
        })
        if (!res) {
          println(s"$oddNumber does not satisfy goldblach")
          oddNumber
        } else {
          goldblachOther(oddNumber + 2)

        }
      }
    }

    val res = goldblachOther(3)
    println(res)
    res

  }

  def problem52(): Int = {
    /**
     * It can be seen that the number, 125874, and its double, 251748, contain exactly the same digits, but in a different order.
     *
     * Find the smallest positive integer, x, such that 2x, 3x, 4x, 5x, and 6x, contain the same digits.
     *
     */

    val solutionFunction = permutedMultiples(_: Int)
    val firstFut = createCustomFutureFor { solutionFunction(1) }
    val secondFut = createCustomFutureFor { solutionFunction(10000) }
    val thirdFut = createCustomFutureFor { solutionFunction(100000) }

    val firstComplete = Future.firstCompletedOf(List(firstFut, secondFut, thirdFut))

    val res = Await.result(firstComplete, 1.day)
    println("OUt");
    res

  }

  def permutedMultiples(n: Int): Int = {
    if (checkMultiples(n)) n
    else permutedMultiples(n + 1)
  }

  def checkMultiples(starter: Int): Boolean = {
    hasSameDigits(starter, starter * 2) &&
      hasSameDigits(starter, starter * 3) &&
      hasSameDigits(starter, starter * 4) &&
      hasSameDigits(starter, starter * 5) &&
      hasSameDigits(starter, starter * 6)
  }

  def hasSameDigits(original: Int, candidate: Int): Boolean = {
    val first = original.toString.toList
    val second = candidate.toString.toList
    if (first.size == second.size) first.forall(second.contains(_))
    else false
  }

  class Node(val id: String, val value: Int, val left: Node = null, val right: Node = null) {

    def isLeaf(): Boolean = {
      (left == null) && (right == null)
    }

    override def toString() = s"id:$id|val=$value|left=$left|right=$right"
  }

  def huffmanCodes(): PriorityQueue[Node] = {
    /**
     * First of all, consult a good book on discrete mathematics or algorithms
     * for a detailed description of Huffman codes!
     * We suppose a set of symbols with their frequencies, given as a list of (S, F) Tuples.
     * E.g. (("a", 45), ("b", 13), ("c", 12), ("d", 16), ("e", 9), ("f", 5)).
     * Our objective is to construct a list of (S, C) Tuples, where C is the Huffman code word for the symbol S.
     *
     * scala> huffman(List(("a", 45), ("b", 13), ("c", 12), ("d", 16), ("e", 9), ("f", 5)))
     * res0: List[String, String] = List((a,0), (b,101), (c,100), (d,111), (e,1101), (f,1100))
     *
     */

    /**
     * alphabet = a, b,c,d,e
     * frequencies = .45, .13, .12, .16, .09, .05
     *
     * here's the algorithm:
     *
     * Create a leaf node for each symbol and add it to the priority queue.
     * While there is more than one node in the queue:
     * Remove the two nodes of highest priority (lowest probability) from the queue
     * Create a new internal node with these two nodes as children and with probability equal to the sum of the two nodes' probabilities.
     * Add the new node to the queue.
     * The remaining node is the root node and the tree is complete.
     *
     * So, shortly, the paper algorithm is
     * while there is more than 1 node in the queue:
     * - find the two lowest priority and create a new node which is the sum of the two
     * - remove the two lowest and add the new node to the queue
     * - repeat the process
     * It seems we need two data structures:
     *     - a priority queue to keep track of current priorities. we will remove the two lowesd and add the new node
     *     - another priority queue to which we can add the removed nodes and the new node
     *
     *
     *
     *
     *
     */

    val pq = PriorityQueue.empty[Node](
      Ordering.by((_: (Node)).value).reverse)

    val tupleList = List(("a", 45), ("b", 13), ("c", 12), ("d", 16), ("e", 9), ("f", 5))

    val nodeList = tupleList.map(item => new Node(item._1, item._2, null, null))
    nodeList.foreach(pq.enqueue(_))
    pq
  }

  def problem51(): (Int, List[Int]) = {
    // TODO THIS NEED TO BE COMPLETED!!
    /**
     * By replacing the 1st digit of the 2-digit number *3,
     * it turns out that six of the nine possible values: 13, 23, 43, 53, 73, and 83, are all prime.
     * By replacing the 3rd and 4th digits of 56**3 with the same digit,
     * this 5-digit number is the first example having seven primes
     * among the ten generated numbers, yielding the family:
     * 56003, 56113, 56333, 56443, 56663, 56773, and 56993.
     * Consequently 56003, being the first member of this family, is the smallest prime with this property.
     * Find the smallest prime which, by replacing part of the number (not necessarily adjacent digits) with the same digit, is part of an eight prime value family.
     */

    // First off write a rountine that proves  the example
    // reuse the function primesUpTo , and do it up to 70k

    // to revisit
    // 1019 should not become 1033.

    // Then work your way to satisfy the problem
    // Find all primes up to 1k
    // for each of the primes . for now we assume we need to replace it only twice

    val range = List('0', '1', '2', '3', '4', '5', '6', '7', '8', '9')

    def generate(num: String, replacement: Char): Seq[String] = {
      println("NUm is:" + num)
      // Broken
      //  we need to replace all the digit, not only two at  time
      // smarter. a digit that is already contained in the start of the number might not count
      val start = num(0)
      for (
        idx <- 1 until num.size - 1;
        idx2 <- idx + 1 until num.size - 1
      ) yield {
        val tmp = num.toArray;
        tmp(idx) = replacement;
        tmp(idx2) = replacement;
        tmp.foldLeft("")((acc, item) => acc + item)

      }
    }

    println("Finding max prime with combinations...");
    val primesUpTo50k = primesUpTo(60000).filter(_ > 100)
    println("Starting the check....")
    def findMax(candidateList: Seq[Int]): (Int, List[Int]) = {
      for (candidate <- primesUpTo50k) {
        val candidates = for (digit <- range) yield generate(candidate.toString, digit);
        val primeCandidates = for (cand <- candidates.flatten if isPrime(cand.toInt)) yield cand.toInt
        println(primeCandidates.distinct)
        println(s"$candidate: we have ${primeCandidates.size}")
        if (primeCandidates.distinct.size == 8) {
          println("Break. we got it!" + candidate)
          println("Break. we got it!" + primeCandidates)
          return (candidate, primeCandidates.toList)
        }
      }
      return (-1, List(-1))

    }

    findMax(primesUpTo50k)

  }

  def palyndrome(num: BigDecimal) = BigDecimal(num.toString.reverse)

  def isPalynd(num: BigDecimal): Boolean = {
    val numStr = num.toString
    return numStr == numStr.reverse
  }

  def isLychrel(candidate: Int): Boolean = {
    println(s"Checking if $candidate  is Lychrel")
    def producePalyndr(num1: BigDecimal, count: Int): Boolean = {
      //println("Count:" + count)
      if (count > 49) true
      else {
        //println("Candiate:" + num1)
        val palynd = palyndrome(num1)
        //println("palnyd:" + palynd)
        val sum = num1 + (palynd)

        //println("Sum:" + sum)

        if (isPalynd(sum)) false
        else
          producePalyndr(sum, count + 1)
      }
    }

    producePalyndr(BigDecimal(candidate.toString), 1)

  }

  def problem53(): Int = {
    val lychrel = for (num <- 1 until 10000 if isLychrel(num)) yield num
    lychrel.size
  }

  def gcd(num1: Int, num2: Int): Int = {
    if (num2 == 0) num1
    else gcd(num2, num1 % num2)
  }

  def isRelativelyPrimeWith(num: Int, candidate: Int): Boolean = {
    gcd(num, candidate) == 1
  }

  def totient(num: Int): Int = {
    val primesWith = for (cand <- 2 until num if isRelativelyPrimeWith(num, cand)) yield cand
    (1 :: primesWith.toList).size
  }

  def phi(num: Int): Double = {
    println("finding phi of:" + num)
    val tot = totient(num).toDouble
    num / tot
  }

  def problem69(): (Int, Double) = {

    /**
     * It can be seen that the number, 125874, and its double, 251748, contain exactly the same digits, but in a different order.
     *
     * Find the smallest positive integer, x, such that 2x, 3x, 4x, 5x, and 6x, contain the same digits.
     *
     */

    val solutionFunction = maximumPhi(1: Int, 1000001: Int)
    val firstFut = createCustomFutureFor { solutionFunction }
    //val secondFut = createCustomFutureFor { solutionFunction(10000) }
    //val thirdFut = createCustomFutureFor { solutionFunction(100000) }

    //val firstComplete = Future.firstCompletedOf(List(firstFut, secondFut, thirdFut))

    val res = Await.result(firstFut, 1.day)
    println("OUt");

    res

  }

  def maximumPhi(start: Int, end: Int): (Int, Double) = {
    val res = for (candidate <- start until end) yield (candidate, phi(candidate))

    res.sortBy(item => item._2).reverse.head
  }

  def generateCube(candidate: scala.math.BigDecimal): List[(Char, Int)] = {
    val cube = candidate * candidate * candidate * 1l
    val cubeStr = cube.toString
    val mp = cubeStr.foldLeft(Map[Char, Int]())((acc, item) => {
      val newcounter = acc.getOrElse(item, 0) + 1
      acc + (item -> newcounter)
    })
    mp.toList.sortBy(_._1)
  }

  def findMaxCube(cand: Int, dict: Map[List[(Char, Int)], List[Int]]): List[Int] = {
    val cbList = generateCube(BigDecimal(cand))
    val itemInDict: List[Int] = dict.getOrElse(cbList, List[Int]())
    val newItemInDict: List[Int] = cand :: itemInDict
    if (newItemInDict.size == 5) return newItemInDict
    else findMaxCube(cand + 1, dict + (cbList -> newItemInDict))

  }

  def problem62(): List[Int] = {

    val mapper = Map[List[(Char, Int)], List[Int]]()

    val res = findMaxCube(1, mapper)

    println(res)

    res
    // The cube, 41063625 (3453), can be permuted to produce two other cubes: 56623104 (3843) and 66430125 (4053).
    // In fact, 41063625 is the smallest cube which has exactly three permutations of
    // its digits which are also cube.

    //Find the smallest cube for which exactly five permutations of its digits are cube.

    // 1. find a rule to find all the cubes
    // 2. create dictionary according to the number of digits (we use them  to find permutations)
    // 3. we loop thru dict to find the key with 5 values
  }

  def generate4DigitPolynomial(start: Int, formula: Int => Int, acc: List[Int]): List[String] = {
    val res = generatPolynomial(start, formula)
    if (res > 9999) {
      acc.filter(_ > 999).map(_.toString)
    } else {
      generate4DigitPolynomial(start + 1, formula, acc ::: List(res))
    }
  }

  def generatPolynomial(num: Int, formula: Int => Int): Int =
    formula(num)

  def problem61(): List[Int] = {
    List(1, 2, 3)
  }

  def findDigitSum(numStr: String): Int = {
    val listWithNoNines = numStr.filter(_ != '9')
    val sum = listWithNoNines.foldLeft(0)((acc, item) => acc + item.toString.toInt)
    if (sum > 10) {
      val res = sum.toString.foldLeft(0)((acc, item) => acc + item.toString.toInt)
      res
    } else sum

  }

  def isPerfectSquare(candidate: BigDecimal): Boolean = {
    println(s"Checking if $candidate is perfect square")
    val candidateStr = candidate.toString
    val zeros = candidateStr.count(_ == '0')
    val knownSquareSuffixes = List('1', '4', '5', '6', '9')
    val knownSquareDigitalRoots = List(1, 4, 7, 9)
    if (knownSquareSuffixes.contains(candidateStr.last) ||
      zeros % 2 == 0) {
      val root = sqrt(candidate.toDouble)
      if (root - root.toInt > 0.0)  false
      else
        true

    } else false

  }

  def findDiophantineSolution(dTermStart:Int, dTermLimit:Int):Seq[(Int, BigDecimal)] = {
    for (d <- dTermStart  to dTermLimit) yield (d, findSol(d))
  }

  def findSol(dTerm: Int, startPoint: BigDecimal = BigDecimal(1)): BigDecimal = {
    println(s"Finidng solution for d=$dTerm and startPoint=$startPoint")
    if (isPerfectSquare(dTerm.toDouble)) findSol(dTerm+1)
    else if (startPoint > BigDecimal("1819380158564165")) -1.0
    else {
      val sol = (startPoint * startPoint * dTerm + 1)
      println(s"Find sq root of:$sol")
      if (isPerfectSquare(sol)) {
        println(s"returning square root of $sol")
       sqrt(sol.toDouble)
      } else findSol(dTerm, startPoint + 1)
    }
  }

  def problem66(): Int = {

    1

  }

}


will do, thanks.


You best commit that then?


ano potřebuji rozlišit () a None jelikož () je také hodnota


Is this change ISO-functional?


if `date` is missing from the json, `DateTimeUtils.iso8601ToJavaDate()` will end up returning `null`. We either need to check for null and not replace `mDate` or the calls to `getDateCreated()`will need to be guarded.


The following doc(s) have been deployed to the [1290wraith](http://1290wraith-static-docs.pantheon.io/docs) Multidev environment:
- [Gemfile](https://github.com/pantheon-systems/documentation/commit/ddb079fba490163b57320d4ed2503a7d011298ff/Gemfile)
- [circle.yml](https://github.com/pantheon-systems/documentation/commit/ddb079fba490163b57320d4ed2503a7d011298ff/circle.yml)
- [configs/wraith.yaml](https://github.com/pantheon-systems/documentation/commit/ddb079fba490163b57320d4ed2503a7d011298ff/configs/wraith.yaml)
- [scripts/deploy-multidev.sh](https://github.com/pantheon-systems/documentation/commit/ddb079fba490163b57320d4ed2503a7d011298ff/scripts/deploy-multidev.sh)
- [scripts/deploy-wraith-diff.sh](https://github.com/pantheon-systems/documentation/commit/ddb079fba490163b57320d4ed2503a7d011298ff/scripts/deploy-wraith-diff.sh)


Most recent commit was also bringing master in line with the Supervisor demo code


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14961](https://teamcity.mesosphere.io/viewLog.html?buildId=128885&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:04:43


[![Reminiscences of 1865](http://api.artsmia.org/images/689/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=689)


This should be calling _controller.Selection.Set so that it only fires Modified once.


develop (macumber) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


I am testing the images url now. My current tests are different from what I
did in #21 <https://github.com/AppFolioOnboarding/Li_Image_Share/pull/21>.
In #21 <https://github.com/AppFolioOnboarding/Li_Image_Share/pull/21>, I
was testing index path with query parameter. Now, I am testing the image
show path.

Li Zhang

Software Engineering | AppFolio Inc.
P: (614) 648-2368
li.zhang@appfolio.comwww.appfolioinc.com

On Mon, Feb 8, 2016 at 3:18 PM, rmacklin <notifications@github.com> wrote:

> See this comment: #21 (diff)
> <https://github.com/AppFolioOnboarding/Li_Image_Share/pull/21#discussion-diff-51846915>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AppFolioOnboarding/Li_Image_Share/commit/0efa284420f9aa1074c64a21bd88093b2d917e68#commitcomment-15964764>
> .
>


( ͡° ͜ʖ ͡°)=ε✄


I wouldn't technically have to create any Ruby objects to write unit tests for these currently.  Although, if we have the `sort-nested-java-maps` call end up referencing `RubySymbol`s directly, then I would have to create Ruby objects to fully exercise the code paths in the same way that calling into the Ruby code directly would.

Are you thinking I should have unit tests for every one of the private functions in this namespace, then?  I had preferred to just write some unit tests for the outermost functions and get transitive coverage of these functions through those.

How about if I replace the 'map sorting' tests in `process-environment-class-info!` tests with a few tests which call into `class-info-from-jruby->class-info-for-json`?  That should allow for tests to be written that don't involve the extra mocking of services and the like but still get coverage of this function and the subordinate `sort-nested-java-maps` function.


@kabouzeid I don't know any scenario where this would actually matter. In case of a background mixing up the actually visible color because of a low alpha value, this check would be wrong either way and just checking the parents background would be unreliable. Or maybe my brain is affected by how late it is.


iteration (evanweaver) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


大量ですが、コンフリクトマージしただけなのでスルーしてください！


iteration (evanweaver) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


I don't care too much.  If the RubyHash is serializable by cheshire and isn't going to force us to do anything weird like stick a clojure object into it, then maybe that'd be worth considering, but otherwise I'm fine w/it how you have it.


Do these really need to be gated with a #if?


Awesome - please fix the alphabetical order and I'll merge ;)


Valeu, acho que é só passar o básico e algumas boas práticas (não fazer upload de binários, verificar com git diff --staged ou --cached antes de dar commit para ter certeza que não adicionou coisas erradas).


probably _cache rather than _cacher.  Thx for method caching!


ready_aim_fire (kbenne) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Either that or we import both and ASPINRemoteImageDownloader gates itself with an #if


Pretty sure it is safe to remove the ternary operator from all of these, as the return type is an actual BOOL


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14964](https://teamcity.mesosphere.io/viewLog.html?buildId=128888&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0, ignored: 226 Build time: 00:07:03
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


The following doc(s) have been deployed to the [1290wraith](http://1290wraith-static-docs.pantheon.io/docs) Multidev environment:
- [scripts/deploy-wraith-diff.sh](https://github.com/pantheon-systems/documentation/commit/a997ac18de2965a8b0dd73f1409bd81e5e326740/scripts/deploy-wraith-diff.sh)


<3 <3 <3


> Are you thinking I should have unit tests for every one of the private functions in this namespace, then?

No, just in general I've been advocating for more unit tests of functions that are moderately complex but easily unit testable and this one seems to qualify.  I'm definitely more interested in it if it allows you to remove some of the tests from the higher-level thing w/o feeling like you are sacrificing coverage.

I'm just throwing this out for consideration though, don't get too bogged down by it, if you think the tests are better as-is then I'm good w/them.


ready_aim_fire (kbenne) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Indentation?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14965](https://teamcity.mesosphere.io/viewLog.html?buildId=128895&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:03:53


Basically, I think to ensure for consistent serialization of our structure for the hash we want to produce, we want to ensure that all of the keys on all of the nested maps in the structure are sorted.  Wherever this code creates new maps - like this outermost one with the `:name` and `:files`, I thought it would be better / more efficient to create the map as a `sorted-map` upfront rather than just as an "unsorted" `hash-map` and run the `sort-nested-java-maps` function against it later.

To make that more obvious, I could add either a comment or docstring in this function stating why I did this, if that would make sense.


Which is why the pull requests are gone.

Notepad++ isn't cooperating on laptop, will re-do later


Why did you change CADIS to PhysicalObject here?


2 reasons to have that name:
1) It's gonna be within the scope of PipelineController once I modify Gtk Pipeline stuff, which is a PR after this one.
2) All the actions are grouped.


sketchup_nomodel_1999 (macumber) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Yeah, good call.  I'll do that.


No worries :)


Although I agree the names could be clearer, this is not a problem - these are two different filters (JPG->JPG and PDF->JPG). I want to generalize this and allow for custom pipelines as I mentioned in the description of https://jira.duraspace.org/browse/DS-3042 , but at this time changing the API is out of scope for DSpace 6.


Hello Tangshen


A little bit sexy.


Any pics of it ingame?


sketchup_nomodel_1999 (macumber) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Is anybody looking into this NULL pointer issue? If not, I will try to post a PR. But there were a lot of changes in this commit and I am not able to check if there are any other issues with it.


comment or docstring explaining why it's important for it to be sorted wouldn't hurt.


Sounds good to me.  I wasn't too fond of the naming convention I used here - just did it to make it look a little more like the others already in this namespace.  I'll go with the approach you suggested, though, instead.


you dont need the explode+inarray. just use strpos()


version_modified (macumber) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


If you see other prototypical middleware fns in here that aren't named w/`wrap-` feel free to change them too.


*best commit message* :)


In addition to partest, I find it helpful to have that global base directory as the working directory for `compiler/runMain` used by the `scala{,c,doc,p}` commands.


version_modified (macumber) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14967](https://teamcity.mesosphere.io/viewLog.html?buildId=128918&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:38


lol. :+1:


:sob:


Actually we should probably delete either the bullet point or the following paragraph as it's a bit repetitive now.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14963](https://teamcity.mesosphere.io/viewLog.html?buildId=128887&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:03


Yeah, that sounds good.  I'd gone with the more generic name thinking ahead to a time in the future where we might want to add other stuff into it - like the actual class-info object structure.  But for the current state of things, I agree that adding `-tags` would be more accurate, so I'll go with that.


Correction: https://github.com/cra0zy/MonoGame/blob/e60ad4f33435ecfdcbf47077e3bfbe53f91cf809/Tools/Pipeline/Windows/MainView.cs#L174 it is used.

Tho it is used in a dumb way so I will still modify this.


Should the library option be named 'source_under_test' similar to the python option?

https://buckbuild.com/rule/python_test.html


2057-ControllerWaterCoil-IP-Units (MatthewSteen) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


lets not make tonumber really alow


to note that i forgot to remove this before the launch.... since the **actual** problem is already gone that regarding this insertion.


Great engineering. Wonder who wrote this... :laughing:


Haha @robby. Finally, it was not only add support for ARC :innocent:


needs tests for assignability at the type level as well.
type MyAlias = T
Type[MyAlias] == Type[T]
Type[Type[MyAlias]] == Type[Type[T]]


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14968](https://teamcity.mesosphere.io/viewLog.html?buildId=128919&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:54


It is, yeah, sorry.  I'd intended to add and format the code this way in one commit but obviously screwed up.


Makes sense - will do.


k, sounds good.


2057-ControllerWaterCoil-IP-Units (MatthewSteen) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


This is very cool, and tremendously exciting to me! However, this method will frequently be called for content that is entering the display range, which could be a full screen height or more away from user. Although this is a good point at which to increase priority to a higher level than it should be at when the request is normally started from a fetch data call, we should use the visibilityDidChange: YES / NO calls to escalate and de-escalate the highest priority level.

The reason we call fetch data at the beginning of this method is essentially as a fallback, for Notes that may be added directly to a window and are not managed by a range controller that calls fetch data. In almost all normal situations, fetch data will be called somewhat before this method, when the node is even farther away from the visible area.


Needs test that 4.x function API in Ruby can use type aliases (preferably the HQ variant which includes scope).


@davidmann4 What does this break? I just installed it and it works fine with all HTTP and SOCK5 proxies :D


Found an npm issue that sounds like this bug: https://github.com/npm/npm/issues/11264 (dependent packages using ^ versions not being de-duped correctly) - related to this one: https://github.com/npm/npm/issues/11043 (Nested modules are missing)


TDan...

I'll get to it soon.  Pleas stand by
Dave


The following doc(s) have been deployed to the [1290wraith](http://1290wraith-static-docs.pantheon.io/docs) Multidev environment:
- [scripts/deploy-wraith-diff.sh](https://github.com/pantheon-systems/documentation/commit/a997ac18de2965a8b0dd73f1409bd81e5e326740/scripts/deploy-wraith-diff.sh)


it is an optimization we can add in a separate ticket.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14966](https://teamcity.mesosphere.io/viewLog.html?buildId=128915&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:08:39


This code looks really good.  However, it should also move to visibilityDidChange:, and we should clear the block on visibility = NO too.


What does this do exactly? What's smart device?


Yeah, I actually had it that way originally.  I reworked it to what I have do what I have now b/c that one `(testing)` block seemed to be getting a little too long to me and I also thought it might be better for visibility to have independent tests for the single environment vs. all environments.  That said, I'll try putting this back closer to what I had before and see if you like that better or not.


111411352_ATDeprecateFields (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2096 of 2097 tests passed, 0 test warnings)

 * 550 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14969](https://teamcity.mesosphere.io/viewLog.html?buildId=128926&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:49


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14970](https://teamcity.mesosphere.io/viewLog.html?buildId=128927&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 223 Build time: 00:03:46


The following doc(s) have been deployed to the [1290wraith](http://1290wraith-static-docs.pantheon.io/docs) Multidev environment:
- [scripts/deploy-wraith-diff.sh](https://github.com/pantheon-systems/documentation/commit/a997ac18de2965a8b0dd73f1409bd81e5e326740/scripts/deploy-wraith-diff.sh)
- [source/docs/assets/js/src/application.js](https://github.com/pantheon-systems/documentation/commit/72488a8852d770f60a5e34ab1cad9e6298e31401/source/docs/assets/js/src/application.js)


this makes me so happy


As mentioned in another comment, I'll plan on removing these new tests and replacing with some that are a little lower-level / closer to just covering the sorting without needing to drag in the extra service breaking that these indirectly require.


best commit ever


Have we settled on the version number for the next release? If we are indeed calling it 0.10.0.0, then we should update JIRA and the KIPs table (some KIPs mention 0.9.1.0).


Yes, given the 100ms base tick, this change does indeed reduce the wait from 10 seconds to 1 second.


111411352_ATDeprecateFields (Nigusse) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@sendhil method naming should use uppercase URL, so `appReviewURL` instead `appReviewUrl`.


Should we mark this as a _"let's keep an eye on this"_ issue in our repo, so our future selves won't be surprised if/when said library changes?


I'll do it, thanks!


Is there a reason why we are not using the `Time` interface here and in other places?


@sendhil do we want to use the shorter version of this default URL, without the extra parameters? For example: `http://itunes.apple.com/WebObjects/MZStore.woa/wa/viewContentsUserReviews?id=335703880&type=Purple+Software`. Probably not a big deal since it is a backup.


I would still wrap @cc_address.save in an if statement; the save method will return true/false if the save succeeds or fails.  Right now if it fails you aren't handling that condition.


Was wondering what this was earlier (vs. using `React.ReactChild`) then see that in `react.d.ts` it is defined as:

`declare namespace __React {`

However TS does not care about this line:

https://github.com/willowtreeapps/tsx-boilerplate/blob/34c981d876511bdb5d9b4ea4fc310f4d94f2532b/src%2Fts%2Fcontainers%2Fapp.tsx#L8

Is TypeScript is doing some magic? I'm curious why it allows it both.


@sendhil property/method naming should use uppercase URL, so `appReviewURL` instead `appReviewUrl`.


It's getting set on `TreeViewAfterSelect`... https://github.com/cra0zy/MonoGame/blob/e60ad4f33435ecfdcbf47077e3bfbe53f91cf809/Tools/Pipeline/Windows/MainView.cs#L660, expand git code.


This is a nice add.  I'm not sure the uniqueness validator existed when I wrote it originally :)


:+1: much cleaner solution here vs. `getRoot`


@sendhil can we make `@"app-review-url"` a `const` instead?


@sendhil should use a retain policy of `copy` instead of `strong` since this is coming from an `NSDictionary` or other source.


http://i.imgur.com/dGeemQ6.jpg
(My arma is on portuguese)

Also, it is a little bigger than I want. Tomorrow I'll tweak it.


The following doc(s) have been deployed to the [1328migrat](http://1328migrat-static-docs.pantheon.io/docs) Multidev environment:


:+1:  on the general principle that we could do with some general guidelines on how to write a private module.  _However_, :-1: on this proposed version.  It's too simplistic and doesn't provide essential information that a potential library writer needs to know.


@rzarzynski attach `else` to previous line


This is also a nice add... :+1:


>Heads up @gaearon, the npm package is using the non-bundled form of Redux.

This is the way it has been. `main` is pointing to a CommonJS build split over several files.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14973](https://teamcity.mesosphere.io/viewLog.html?buildId=128959&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:59


> Why is this necessary -- isn't draining eviction sufficient?

You're right, there's no reason there needs to be a separate split-drain process.

I pushed 3511f76 and 86b3d2f to revert most of the change, just leaving the test against `WT_CKPT_OFF`. Would you please take a look and make sure it's correct?


:(  Please check of you can now, I had hoped the permission was now automatically set for all.
I had to manually add teams again.


The following doc(s) have been deployed to the [1290wraith](http://1290wraith-static-docs.pantheon.io/docs) Multidev environment:
- [scripts/deploy-wraith-diff.sh](https://github.com/pantheon-systems/documentation/commit/8252d7dde2c5f7ffc5a689d199fde9ef45d39831/scripts/deploy-wraith-diff.sh)


imo upload.wikimedia.org and en.wikimedia.org should be first-party since they share the same base domain (origin to the left of the public suffix). see https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/mozIThirdPartyUtil#isThirdPartyURI()


@sendhil we should use the SafeExpectations helper method `stringForKey:` for grabbing the URL str.


So, you're copying his patches and not giving credit?


You might wanna reset this; nobody should be using seed data; but crazy stuff happens.


EnableVolumes probs?


Yeah, there's a bunch of state that has to be explicitly defined and carried around which should be invisible to the user, but isn't.  Would a trait with an implicit helper work?  Then you could apply the trait to a WrappedRequest subclass, and have CSRF without having to tie it explictly to a request.


Yes, it is wrong. Thanks for spotting this.


this is not exported so i don't think this would compile


>Redux should be bundled into a single file with no need for the modules its composed of.

This is only the case for a special UMD build in `redux/dist/redux.js` and `redux/dist/redux.min.js`. We maintain those for consumers who prefer global builds. In general we prefer people to use the unbundled CommonJS sources and bundle them themselves.


@kurzee nice catch. Will update in a moment.


Do I understand correctly: now adblock blocks advertising on our site?


I'm still confused. Isn't that already happening [here](https://github.com/BBN-Q/libaps2/blob/0b0ddb1be62b6a9e541d5f3ad02daa0edc4a123c/src/util/program.cpp#L184)? You're right we could push the `sleep_for` into the `wait_for` timeout though.


@rzarzynski shouldn't it be `if (keystone_version == 2)`?


@sendhil I think I'd rather return the default URL string in the Class helper method `+ (NSString *)appReviewUrl`, instead of setting it on `init`. Keeps it a bit cleaner, rather than setting this property twice and the helper method just returning the value.


or `!= 3`


>  In general we prefer people to use the unbundled CommonJS sources and bundle them themselves.

Sounds like trouble.


![admin_use case](https://cloud.githubusercontent.com/assets/16759930/12904141/20e80078-ce9b-11e5-9f3a-c4d72fb1a940.png)


@permcody IIRC although `PointLocator::operator()` is marked const, it is not thread-safe, since it may modify a mutable `_element` parameter.  `PeriodicBoundaries::neighbor()` calls `PointLocator::operator()` on this line in a threaded region.  I tried to lock this access with a mutex, but that deadlocked the entire program.  Anyway, this might have something to do with our threaded Periodic BCs issues...


Yeah definitely. I tried to do that originally but it was throwing some error. Maybe was related to something else though. Will revisit.


Looks good to me!


style nit: drop the return and put the Ok(()) in the Ok branch here


On Mon, Feb 08, 2016 at 03:27:08PM -0800, Marek Marczykowski-Górecki wrote:
> WIP storage: fix handling netvm and adminvm
>
> @woju what was consensus on 'servicevms' dir? Since "being network
> provider" is no longer separate type and can be changed during VM
> lifetime, maybe we should abandon that idea? Or maybe just set it as VM
> property (some storage pool config argument) - that way mgmt stack could
> put all the sys-* VMs into separate directory, regardless of the type.

AFAIR `servicevms` is to be retired. `vm-templates` and `appvms` were to
remain (the distinction had something to do with liveusb, but I can't
recall what exactly). I don't remember if either was to be renamed.

--
regards
WZJP


@rzarzynski oh, I see you already changed this line.. cool


But what if they click Q?


The idea with using atomic here was as a hint to the developer that the property is thread safe. Whether or not that implication was actually true, it is another question, but as long as the methods are implemented manually and we use locking then I think the atomic flag it is a no-op.  I don't feel strongly about this one way or the other, as there're definitely other places in the API that don't use it consistently, although there are a lot of places that do use it. It might be worth just leaving it as is for now until we can choose a definitive method for annotating thread safety.

cc @Adlai-Holler, this is something we discussed at length this weekend (specifically, the need for annotating both the thread safety and whether or not methods are called off the main thread, and our disappointment that there does not appear to be a platform standard for this yet despite all of the new clang flags)


FWIW the lodash package points to a single monolithic umd build as its index.js and has worked pretty well like that. This allows the common case to work without hassle and still allows folks to cherry-pick or dig into its parts as needed.


There are a lot of Rails guys out there who will try to :hocho: you over this one.  Breaking the MVC convention horribly.  You should be spawning the "new" instance up in the controller and handing it down to the view as a variable.  or some babble like that.  I still wear wireframes and where loose fit jeans, I was never hipster enough to fully know or obey the MVC conventions :)


@rzarzynski as we discussed, we should be able to parse either tokens at the bottom layer


せっかく直してもらったところすみませんが、「できます」の方がよさそうです。
usr*.jax の中では、「出来ます」になっているところは1箇所(usr_06内)だけで、他はすべてひらがなになっていますので。
(usr_06も直したほうがよさそう。)


Thanks Steve for sending in the PR. I have merged into Master.


after the _yes_ there was a pipe, removed it


@kurzee the reason for the `Url` instead of `URL` is because if I remember correctly that policy is for `NSURL` objects whereas `NSString` generally have been just `Url`.


5452-controllerWaterCoil-IP-units (MatthewSteen) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1511 of 1511 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.71%25-green.svg)


The following doc(s) have been deployed to the [1290wraith](http://1290wraith-static-docs.pantheon.io/docs) Multidev environment:
- [composer.json](https://github.com/pantheon-systems/documentation/commit/a2b4fe306927ac7b53b7378f0b417609d42a1f45/composer.json)
- [composer.lock](https://github.com/pantheon-systems/documentation/commit/a2b4fe306927ac7b53b7378f0b417609d42a1f45/composer.lock)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14971](https://teamcity.mesosphere.io/viewLog.html?buildId=128952&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:44


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14976](https://teamcity.mesosphere.io/viewLog.html?buildId=128970&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:48


Hey Ryan!


What the shit is this...
Why.
What are you trying to do?


Now the application is capable of handing more addresses than merely the entrance point of "/" (root). The requests now can be made to URIs in the format of First Name/Surname/ID(number). The number types are assigned according to gender: if it is an even number, it  means that the user is a woman, odd numbers are assigned to men. One thing to be noticed is that in case a non-numeric ID is entered, the application will by default return the version for men, as non-numeric parameters are, obviously, not divisible by two or any other number, and the application implicitly handles the parameter as being of the second type.


Why 5?  Not that I'd practically expect more than 5 requests to be outstanding, but does this mean that if we had more than 5 writes outstanding for some reason that the additional write attempts would block until there's space free in the buffer to service them?  Does having a limit here just make processing more efficient?


GLOBAL: drop the `package:pipe_examples/` from import statements within lib. Just use relative filenames. E.g.:

```
import 'fetch_json_pipe.dart';
```


The code to use ``comtypes`` is quite similar, such that it might be worth trying to use either ``win32com`` or ``comtypes`` depending on which is available. In particular, PyPI, Enthought Canopy and Anaconda all provide ``comtypes``. The following works on Python 3.5, Windows 10 Threshold.

```python
from comtypes.client import CoGetObject
winmgmts_root = CoGetObject("winmgmts:root\cimv2")
cpus = winmgmts_root.ExecQuery("Select * from Win32_Processor")
ncpus = 0
for cpu in cpus:
    ncpus += int(cpu.Properties_['NumberOfCores'].Value)
```


@sendhil 👍that looks to be consistent with most of the project with `Url`. Makes sense.


Another global change: please drop the `library` line from all the files. We don't need it any more. (woohoo!)


This code duplication is not terrible, but it is worth thinking about how we could eliminate it. At a minimum, please add a comment referencing the location of the duplicate copy, so that any edits are propagated there even if they're being made by an engineer who is not familiar with the rest of the stack. This version also needs to be updated to use the visibility method.


Looks like this namespace and the `config` one below aren't used.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14974](https://teamcity.mesosphere.io/viewLog.html?buildId=128962&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:32


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14979](https://teamcity.mesosphere.io/viewLog.html?buildId=128989&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:39


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14972](https://teamcity.mesosphere.io/viewLog.html?buildId=128953&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:49


nbnbnbnbnbnnbnb


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14975](https://teamcity.mesosphere.io/viewLog.html?buildId=128963&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:53


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14981](https://teamcity.mesosphere.io/viewLog.html?buildId=128991&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:45


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14980](https://teamcity.mesosphere.io/viewLog.html?buildId=128990&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:58


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14978](https://teamcity.mesosphere.io/viewLog.html?buildId=128983&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:32


111411352_ATDeprecateFields (Nigusse) - i386-Windows-7-VisualStudio-12: OK (2063 of 2065 tests passed, 0 test warnings)

 * 550 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.9%25-yellow.svg)


The following doc(s) have been deployed to the [1290wraith](http://1290wraith-static-docs.pantheon.io/docs) Multidev environment:
- [composer.json](https://github.com/pantheon-systems/documentation/commit/fe364162da1bc447b2e416238eaad2206d420420/composer.json)
- [composer.lock](https://github.com/pantheon-systems/documentation/commit/fe364162da1bc447b2e416238eaad2206d420420/composer.lock)
- [configs/wraith.yaml](https://github.com/pantheon-systems/documentation/commit/fe364162da1bc447b2e416238eaad2206d420420/configs/wraith.yaml)


Rude.


+ / Keypad + added here. Comment above was not updated and it doesn't explicitly say in commit message. I see you were covering zoom from #745


I believe we can guarantee thread safety if we are call back on a non-main queue in this case, so I would suggest that we do that. Sometimes the main queue can get backed up, So in addition to avoiding any overhead such as UIImage dealloc that may occur if we are setting a new image, it may help the block actually run sooner at least on multi core devices


The following doc(s) have been deployed to the [1290wraith](http://1290wraith-static-docs.pantheon.io/docs) Multidev environment:
- [composer.json](https://github.com/pantheon-systems/documentation/commit/fe364162da1bc447b2e416238eaad2206d420420/composer.json)
- [composer.lock](https://github.com/pantheon-systems/documentation/commit/fe364162da1bc447b2e416238eaad2206d420420/composer.lock)
- [configs/wraith.yaml](https://github.com/pantheon-systems/documentation/commit/fe364162da1bc447b2e416238eaad2206d420420/configs/wraith.yaml)
- [source/docs/assets/js/src/application.js](https://github.com/pantheon-systems/documentation/commit/247c8bec8d29faa7660b8e44fc8ae33d6a15d34b/source/docs/assets/js/src/application.js)


The following doc(s) have been deployed to the [aeligature](http://aeligature-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/sites/code/unsupported-modules-plugins](http://aeligature-static-docs.pantheon.io/docs/articles/sites/code/unsupported-modules-plugins)


@bsedyang should use `ldout(s->cct, 1)` here


I may have missed it, but if we are still using the old protocol, do we set the download identifier somewhere our self? Disregard if you know this is handled


I'm trying to keep Thermos in line with KCauldron so people who transition see little difference.
If Protik has any problem with these commits, I will gladly go through each one and write that it is from KCauldron on GitLab.


What I mean is: you're only testing that _links_ to those images are shown (by testing the `href`s), not that the actual images are shown (by testing the `img` `src`s), which is what the test name "display all images..." suggests.


@bsedyang see my comment, otherwise looks good.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14977](https://teamcity.mesosphere.io/viewLog.html?buildId=128971&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:07:05


Might as well put this block in-line, as some other calls above are doing this even with more complex blocks


@sun1x Can this rewrite to "dark theme"?


Wow. I don't even.


Thoughts behind the impetus for this rename? It is a little bit unusual to have the selector reference a different name and then the local variable / argument, and although I think the name is an improvement, because we can't as easily shorten the variable name without it becoming a bit confusing to call… I'm not sure if this rename is worth it.


We should move this to the very bottom, in the least prominent place possible. Presumably it should no longer be required if it is deprecated?


It's so we can differentiate between the selectors :(


eh. I worked on the document. https://docs.google.com/document/d/1bGAIVi5vVtEoCCM8oV8DLjdOOSpM3rxV0opBgPWKgM8/edit?usp=sharing


Maybe we shouldn't implement this method. Since `downloadImageWithURL` will check the cache before actually downloading, if we implement this method we will check the cache twice on a miss.


In fact, let me go do that now, just for you. :smile:


Credit: Protik (Sergei) at KCauldron GitLab


Please don't use a timeout like this.  If you need an explicit notification, do that.  It can be easily made to do nothing outside the tests.


If you have solved this somewhere else in the app, I'd love to reuse it.


It would still be in free roam


Let's use `ASObjectIsEqual` instead of `isEqual:` in all cases, since it's a little faster and handles `nil` correctly.


@repenaxa someone from your team should probably look into this.

calling classList.toggle("some-class", undefined) acts as calling if classList.toggle("some-class")

I don't know why filter buttons work reliably in official published Chrome DevTools, but it does not work for me when using official externally hosted DevTools from sources. I assume Closure compiler transforms the code in a way which makes it work.


wtf lol


@sebastienros

None of the jQuery UI downloads contain any version of jQuery. Besides, we do not use the built download packages anyway, we build them ourselfs using the individual files using Gulp, like so:

    {
        "inputs": [
            "Assets/Js/jQueryUI/widgets/mouse.js",
            "Assets/Js/jQueryUI/widgets/position.js",
            "Assets/Js/jQueryUI/widgets/draggable.js",
            "Assets/Js/jQueryUI/widgets/droppable.js",
            "Assets/Js/jQueryUI/widgets/resizable.js",
            "Assets/Js/jQueryUI/widgets/selectable.js",
            "Assets/Js/jQueryUI/widgets/sortable.js"
        ],
        "output": "Scripts/jquery-ui-interaction.js"
    },


Yeah it means that any attempts to put more requests on the channel would block.  The default is 1 and that made it impossible for me to write a test because the calls would just block, so I arbitrarily chose 5.  Open to suggestions.


The following doc(s) have been deployed to the [1290wraith](http://1290wraith-static-docs.pantheon.io/docs) Multidev environment:
- [source/docs/assets/js/src/application.js](https://github.com/pantheon-systems/documentation/commit/247c8bec8d29faa7660b8e44fc8ae33d6a15d34b/source/docs/assets/js/src/application.js)


Can you make a "0.1x.x" compilation build, thanks! That way anyone from 0.10 and over can join! (Adds support for older devices)


@BenSchumacher-HU hatte mit meinen letzten push nebenbei noch das alles geupdatet. sollte jetzt wirklich aktuell und so sein


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14982](https://teamcity.mesosphere.io/viewLog.html?buildId=129022&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:58


I have access to settings only some packages (my packages and some owned by other users). You tell me if you need more test.


That's actually a good question, I'm not sure the right direction. I'm only checking the memory cache here which in theory should be fast. My thought was that, eventually, ASDK nodes could take advantage of a hit in the memory cache by drawing synchronously if it was desired like the PINRemoteImage categories do.


111411352_ATDeprecateFields (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (962 of 963 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.9%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-28.8%25-green.svg)


Hi Robert,

thank you for providing a fix so amazingly fast! Works perfect now!

Best regards

Andreas


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14984](https://teamcity.mesosphere.io/viewLog.html?buildId=129038&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:50


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14983](https://teamcity.mesosphere.io/viewLog.html?buildId=129035&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:39


This PR and #1205 are semi-related.


Maybe we should make these the same as ASInterfaceState, or mapped to them - FetchData, Display, and Visible.  Totally fine using different names, could just be Low / Medium / High, or Preload, Imminent, Interactive etc.


If I did this change, the `RubyHash` would still end up being converted into a Clojure-friendly "map" structure prior to Cheshire serialization anyway - by virtue of the `sort-nested-java-maps` call being run against it.  We need to do that in order for the keys to be sorted properly prior to serialization.  I have confirmed that Clojure's `sorted-map` will properly "sort" a RubyHash, so I think we'd be okay there.


Can you set this to 1.0.0-rc2-23805 to match our other references?


Ah, ok.  Seems fine to me, then.  I didn't realize that "1" was the default.


Move to bottom.  I actually don't remember if you can extend a protocol in a different definition, but if so we may want to do that for both the downloader and cache after the main / non-deprecated methods are declared.


I don't know what other settings to change to give you access to editing the description of this package...


@nkcsgexi could you review this?


The reason for the change is completely valid -- however, getSpec is still broken in master because `\specs` is a typo. See #1.


Being fake is one thing but publicly announcing it is rough, I couldn't lie to myself that badly.


is why i pushed it in to space key and not Q key so people can still cycle trough other players with the Q key :smile:

Mode.prototype.pressSpace = function (gameServer, player) {
    // Called when the Space bar is pressed
    if (player.spectate) {
        player.freeRoam =! player.freeRoam;
    } else
        gameServer.splitCells(player);
};
```


I think you need rhel.7-x64 here as well?


The following doc(s) have been deployed to the [1290wraith](http://1290wraith-static-docs.pantheon.io/docs) Multidev environment:
- [source/docs/assets/js/src/application.js](https://github.com/pantheon-systems/documentation/commit/da0a9ae60d7332ba4b19ec13beb453422987f39b/source/docs/assets/js/src/application.js)


Was just about to do this! :+1:


Introducing an associated type can also be problematic for existential types that are expected to conform to protocols, if contravariant requirements are introduced simultaneously. Any existing uses of existential types would also have to be evolved to bind the new associated types to their defaults.


It won't work because updates add NEW blocks and other new prefrences so it might mess it up...xD


This should be two lines gap.


Add 'added' to the end of sentence.


Is there any advantage over my method? I am not a win man, so you might already know way more than me.


Is it possible to share this code with the actual import deserialization code, so that this doesn't happen again?


True, but since this method sends the image asynchronously the image node has no chance of drawing the image synchronously.


Yup, you're probably right that for now, it should just return nil.


good call, at the end was not required to add new a constant for `Name` since we are not doing equality checking because we should add all the fields to the `Point` be returned for later usage - related commit: 5a5b73ee12d1741111fe9ab1c9906b3535ddd764


We're in the process of setting up a community conda channel, stay tuned.


это ширина psd файла минус горизонтальные отступы, до этого просто ширина была, и ты сделал отступы у разных элементов внутри контейнера, я решил, что так лучше


you removed the version number, but this sentence still says that the version number is present


Two things. I scrapped Facebook, because it seemed a bit off for a graduation site (why would people want links to more personal things?) And the other thing is that we'll need to pre-emptively strip the `@` symbol from usernames. That doesn't happen server-side, so we can do it just before render.


The following doc(s) have been deployed to the [1290wraith](http://1290wraith-static-docs.pantheon.io/docs) Multidev environment:
- [Gemfile.lock](https://github.com/pantheon-systems/documentation/commit/a435059e72502786ebd5639278c2f36a88081d03/Gemfile.lock)
- [source/_partials/footer_scripts.html](https://github.com/pantheon-systems/documentation/commit/a435059e72502786ebd5639278c2f36a88081d03/source/_partials/footer_scripts.html)
- [source/docs/assets/js/src/application.js](https://github.com/pantheon-systems/documentation/commit/a435059e72502786ebd5639278c2f36a88081d03/source/docs/assets/js/src/application.js)


minor comment, otherwise lgtm


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14985](https://teamcity.mesosphere.io/viewLog.html?buildId=129077&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:23


ユーザ → ユーザー


sounds good. update at will or I'll try to do so in the morning.


Is that not covered by what's there?

(I still think that the only sensible way to do this is to either reduce those members to the bound of the associated type, or make it uncallable.)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14986](https://teamcity.mesosphere.io/viewLog.html?buildId=129082&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:37


caseには変数を書くから
ここにtrueが来るのは変かな？

case文は例えば

fruits = ['Apple','Orange']   ##変数fruitsにはAppleかOrangeが入ってる

case fruits    ##変数 fruitsの中身が
when 'Apple'  ## Appleだったら
  p '赤'              ##  赤と表示する
when 'Orange'  ## Orangeだったら
  p '橙'                 ## 橙と表示する
end

みたいな変数の中身によって処理を変える時に使う
今回のでcase文を使うなら変数は i だから

  case i                                     ## 変数 i の中身が
  when 15, 30, 45, 60, 75, 90     ## 15か30か45か60か75か90だったら
    puts "FizzBuzz"                        ##  FizzBuzzと表示する
  when 3, 6, 9, 12, 18, 21, 略     ## 3か6か9か12か18か21か...だったら
    puts "Fizz"                               ## Fizzと表示する
  when 5, 10, 20, 25, 35, 40, 略 ## 5か10か20か25か35か40...だったら
    puts "Buzz"                              ## Buzzと表示する

みたいな。
好みって言ったけどここではif文の方が簡単に書けるかも！


TODO what?


gdgdgf


This compiles and downloads the binary, whereas the `GET /v1/binaries/:binary_id` endpoint just downloads. The method name should probably clarify that.


[readme document.txt](https://github.com/blnovak/Novak_Brandy_Portfolio/files/122451/readme.document.txt)


Uh oh. When I enter text in either field, I get an exception:

```
EXCEPTION: Error during evaluation of "ngModelChange"
VM196:1 ORIGINAL EXCEPTION: type 'String' is not a subtype of type 'int' of 'value'.
```


So portable just doesn't support dynamic locals yet?


Thanks so much, I'll do this first thing tomorrow.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14988](https://teamcity.mesosphere.io/viewLog.html?buildId=129084&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:48


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14987](https://teamcity.mesosphere.io/viewLog.html?buildId=129083&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:03


Last comment: As we discussed, the UI of the plunkr version (https://angular.io/resources/live-examples/pipes/ts/plnkr.html) is different from this.

In a future PR, could you please update the Dart version to be like the new plunkr version (UI, docregions, etc.). Thanks!


こういうのCIで検出できたらいいですね…


Implemented in later commit :)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14990](https://teamcity.mesosphere.io/viewLog.html?buildId=129102&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:58


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14989](https://teamcity.mesosphere.io/viewLog.html?buildId=129085&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 212 Build time: 00:05:39


Pass in EnC version. Currently not supported by Portable PDBs... will add and link a workitem


Ah...I'll look for that. :smile:


Outputs for each command


Нет, основной файл никогда не может называться main. Потому что если его твою библиотеку установить подключить вместе с кучей других, то эээ эт чо будет? `require 'main'` просто?..


111411352_ATDeprecateFields (Nigusse) - i386-Windows-7-VisualStudio-12: OK (2065 of 2065 tests passed, 0 test warnings)

 * 550 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


You can do that, or change the meaning of existing existentials when you introduce associated type requirements. If version 1 of `P` has no associated types, and version 2 adds a defaulted associated type `T = Int`, then version 1 uses of `any<P>` can be interpreted as meaning `any<P where T == Int>`.


хорошо бы также все свои классы и модули сложить в один общий модуль. чтобы был какой-нибудь `Movies::MyMovieList` и т.д. — иначе, представим проект где несколько похожих библиотек подключено (допустим чтобы фильмы из разных источников добывать) — сколько раз там встретится класс Movie


So to confirm my understanding, this tests `delete_all` because if we failed to delete all the previously existing records, then there would be more than 34 records here after re-importing.


♥

Some day I hope to make this the default for everything, and we can make things opt into `box-sizing: content-box` if you really need to have confusing sizes.


eek. Thanks for fixing that.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1340](http://teamcity.monogame.net/viewLog.html?buildId=14615&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14991](https://teamcity.mesosphere.io/viewLog.html?buildId=129128&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:52


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14992](https://teamcity.mesosphere.io/viewLog.html?buildId=129131&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 218 Build time: 00:03:31


Is there an easy way to find these bundleIDs (`com.googlecode.iterm2`)? I've been opening the Hammerspoon Console and doing something like `hs.application.find('hint'):bundleID()`, but it seems like there must be a better way.


Так. `files` => `data` для таких случаев обычно называют так.
Хорошо бы старые скрипты, которые всячески демонстрировали функциональность movie_list, положить в examples (и оформить их «красиво и понятно» — чтобы они прям демонстрировали, какой у тебя прекрасный библиотека и как много он может).
Хорошо бы минимальный README.md + минимальную YARD-документацию.
Хорошо бы подключить на этом этапе Rubocop и посмотреть, что он скажет про твой код.


Where is RAPPOR_DEST defined?

Put this git subtree command into a runnable shell function.  Perhaps

./doc.sh build
./doc.sh publish-gh-pages


(Ну и rb~ файлы заигнорь, к слову)


Это, конечно, смешной подход :) Но попробуй его минимально документировать (в README хотя бы) — и увидишь, что он не очень эффективный.


From my understanding, comtypes is a bit better maintained and easier to
install being a pure-Python library. That said, win32com is easier to use
one installed, so it's somewhat of a tradeoff.

On Tue, Feb 9, 2016, 12:08 Paul Nation <notifications@github.com> wrote:

> Is there any advantage over my method? I am not a win man, so you might
> already know way more than me.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/qutip/qutip/commit/79b633c3e3a2573080c24f2bdffc2aded87c1067#commitcomment-15966789>
> .
>


See, this is an important smell you got here. You use the hasFailed_, which is clearly a return value as a member. If you move the if outside and return true or false, the whole thing will look a lot nicer!


test merge


PTAL


Using `label: false` means we won't generate an associated `label` tag for this `input`. That's a bit of an antipattern for form [accessibility](https://developer.mozilla.org/en-US/docs/Web/Accessibility). I think it would be better to have a `label` tag (`simple_form` allows you to customize the label text), and delete [this `<p>` which is sort of acting as a label, but without the correct semantics](https://github.com/AppFolioOnboarding/Haomin_ImageUploader/commit/bd7a0efdb311bc3c7062ce100af3f9d0b47fadaa#diff-bb5906750833aab453c96baf0e575bc1R11).


:tada:


Is there anything else we could assert about the response content?


Good catch! That probably explains some weird behavior people has reported.


Instead of asserting this about the underlying model, it'd be better to test the output of the controller (a level above the model).


Please keep your emails updated and check your emails updates thanks


Looking at this again, I realized that this schema doesn't get evaluated until after the code that does the sorting of map keys for pre-serialization ordering is run through.  Part of that code involves coercing all keys in maps into Clojure keywords, since that's what `sorted-map` requires.  The keywords end up being turned back into strings when serialized to JSON, so that part shouldn't be a problem.  Given that this all is happening anyway, though, I could go ahead and fill this schema out to make it look like the "mostly Clojure-friendly" structure that it would be by this point.  I'll go ahead and do that and we can decide if we're good with that depending upon how it turns out.


Yeah i think it would look better if it was a bit skinnier.


Update Readme


111411352_ATDeprecateFields (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2097 of 2097 tests passed, 0 test warnings)

 * 550 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Except that the two really shouldn't be distinct types:

````swift
// Library, now at v2
protocol P {
  @available(2.0)
  associatedtype T = Int
}
func use(p: any<P>) { … }
func getDefaultImpl() -> any<P> { … }
````
````swift
// Client, compiled against v1
use(getDefaultImpl())
````


nice, like the name


Thanks! BitHub has sent payment of  $24.54USD for this commit.


This code doesn't work, for the second time... please test your code before pushing.


cool


Yeah I found the issue when I create capybara test for it. And I alreadty modified it in the capybara branch that is on my local repo. Is that okay to address this problem in that branch?


I think with these changes the text at the top is slightly not centered.  Please take a look and fix if not.


seems like there could be a race condition vulnerability where:
1. user goes to example.com
2. user navigates the tab to about:preferences
3. the contentScripts are updated to include `aboutPreload.js` but the webview `src` has not yet updated so example.com can mess with the preferences


Fixed.


AAA


let me know if you think that's still an issue with the last commit.


How do you mean? `any<P>` would admit a `P` with `T` bound to any associated type if it isn't constrained. If existing users were allowed to assume that `any<P>: P` before the associated type was introduced, and the associated type is contravariant, they would break.


examples working -- promising!


nit a auth -> an auth


These don't actually get updated like that. The content scripts are loaded into the new script context and there is no overlap. The new page will have it's own script context that only has the webviewPreload


> Sorry if it seems I'm nitpicking too much!

Not at all! Great suggestion. Moved out of this class :+1:


Also please make a trivial change to the doc and test that the whole process works, and that the generated docs are up to date with sources.


CorElementType is internal so when the source is copied to Roslyn it doesn't build.


Oh, sorry. I got confused by the diff view which wasn't showing that line.


Can we include the stack trace?


I don't think we *ever* get to assume `any<P>: P` any more unless it's specifically declared somehow. Adding initializer requirements would already break that. I guess that should be called out explicitly as a model change (and get its own proposal, sigh).


It does in a later commit :)


whats a `.lprof` file? (`simpleflight.py.lprof`)


See https://github.com/brave/browser-laptop/commit/446dfe8c1c39203e5f41f9bb6341a2103df1248c


…not that we can add initializer requirements without existing `Self`-producing requirements, so maybe that's a non-issue. Still, I think self-conformance is something we ought to be opting into, so we can enforce it properly.


I keep getting the error of URI error. What is it supposed to be changed to?


111411352_ATDeprecateFields (Nigusse) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


If we want to reduce allocations, we probably know the size that Conns array should be. The way it is will do this allocation plus a few more depending on list size.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1340](http://teamcity.monogame.net/viewLog.html?buildId=14615&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:19:04


I think you should just leave it as-is. The change makes it more complicated for no benefit. It's just a misunderstanding of how these attributes work. Each page has it's own script context and there is nothing associated with the webview itself that will ever overlap between two pages


Not exactly, I'll DM you on Slack.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14993](https://teamcity.mesosphere.io/viewLog.html?buildId=129167&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:21


111411352_ATDeprecateFields (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (2065 of 2065 tests passed, 0 test warnings)

 * 550 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I know that michael was trying to figure out the calibration we needed for the encoder and I wanted to leave what I could to reference the data we were looking at


Oops...you accidentally removed some things. Fixing...


Cool!  It worked for me.  No additional errors were discovered.


Observing the precedence of the Spell Compendium, I modified the name of
the Wither Limb spell in the Book of Vile Darkness to avoid collisions.


looks the same as before to me. do you have a test page?

![screen shot 2016-02-08 at 5 50 37 pm](https://cloud.githubusercontent.com/assets/549654/12905573/13750d2c-ce8d-11e5-8e09-142a7ed59f99.png)


Hi @jurgc11 , great plugin!
Could you add to the docs that the final default access is through ws://{{server}}:{{port}}/ws/_changes
That could had saved me some time :)


oh ok I guess this is older.
I just measure the pixel count on the left and the right with Commadn+Shift+4
It is off by about 10 pixels I think because of the lock icon.


Good question.  This code overlaps with both `ModuleFile::associateWithFileContext` and `NameBinding::addImport`.  The parts that are the same are:
* Parse RawPath into ScopePath and ModulePath
* Get ModuleDecl

And in the case of `addImport`:
* Lookup the scoped path for a decl.

It seems like that might be worth hoisting out somewhere, but I'm not all that familiar with this code.  In any case I don't want to touch any of that in swift-2.2, but I would like to get this crash fix in.


I'll post a new issue since it isn't related to your changeset


:beers: thanks @jonschlinkert


no problem!


you need to add the team "users" with **Admin** permissions.


Please git tag and push (or push tags if you used `npm version`)


어머 커밋을 안했었네


The module is already defined in `src/parentApp.js`, so you don't need the `[]`


@nickvergessen both is valid - why change?


tryBind?


rename to `declaredSignature`?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1348](http://teamcity.monogame.net/viewLog.html?buildId=14667&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: ... Develop (Win10) Build time: 00:00:02


Will do.


Non Null ?


LGTM. You could also return the `List[Pattern]` from the `hideImplicitConversions`, but it's not mandatory.


@RaoOfPhysics I had a feeling you would comment whichever way I spelled it.


Why the parantheses?


Similarly here I think.


si que  te lo has currado jajaja esta guapo


Две левые колонки, которые fieldset'ами сделаны - даёшь филдсетам ширину фиксированную такую чтобы они сами выстроились, и не забывай что у тебя на этой странице везде паддинги 6%.


There is an addition to the `assert_type` function tests that uses a `TypeAlias`, both as a `Type` and in string form. The `assert_type` function was also changed to be an `InternalFunction` so that the dispatch variant using a `String` could inject the scope.


why is this commented out? can't we get the authconfigs?


And here.


You are right, there is a mistake in my code, I've fixed it in <https://github.com/nunonunes/BatterySense/commit/2657a314aab890e5decb4c173c20dfc89801d376> and I explain my rationale for the change there.


LGTM, except for the parentheses...


+! from the peanut gallery.It's a tough habit to break, as I'm currently fighting rolling optimisations into Seti Cuda Multibeam, from various places (including some of my own).  Only suggestion is to know that whatever works at the moment trumps the new thing, at least until the new one is the same to twice as good in some metric, with no downgrades.

------------------------------------------------------------------------------------------------------
Jason Richard Groothuis
bSc(compSci)

------------------------------------------------------------------------------------------------------

Date: Tue, 9 Feb 2016 01:40:50 -0800
From: notifications@github.com
To: boinc@noreply.github.com
Subject: Re: [boinc] WCG: New feature 'cookieless installs' (6beafff)

Does this mean this feature is incomplete? Why isn't this developed in a feature branch? This would also have avoided breaking master once more, a trap in which we just fell again...

—
Reply to this email directly or view it on GitHub.


sprintf? :smile:


This commit broke my Ubuntu/Qt 5.5 build, and I suspect the reference to QMessageBox is the fault. I included QMessageBox in WorkoutWindow.h and was able to build again. (I do have limited c++/Qt-knowledege so I might be wrong, however.)


Barbora mailed me back and prefer bara@redhat.com as principal mail.


Is the "date" field optional on the server side? If not, may I suggest adding an `else` here with an AppLog warning trace? Idea is to not bypass this silently. Cheers!


All good points, fixes are out.
Concerning PieChart x-value color: Atm I just coded it to be equal to value text color, but that is not correct.
Maybe we need a separate method...


I understand, but what does it have to do with the suggesion?
We have given the default T value to be 100 right?


That's a good question (I assume you mean the additions of `{}`) - on 242 I must have misread and wanted this structure:

```scala
if (a) {
  ...multiple lines
} else {
  ...multiple lines
}

But I see now that it's a single expression. I wanted to remove the added `//`in `ModelFactoryImplicitSupport.scala` - I'll recommit


@DarkSilencerZA, from Gitter chat:
> **danielstuart14 said:**
> I finished the status bar.
Going to upload the image here.
http://i.imgur.com/Rk8SJUD.jpg


Should this be `XBEE_MAC_STACKSIZE, XBEE_MAC_PRIO,`?


Can we change that to 4096-bit RSA, please? It's well supported and considering terminal insecurity, larger keys are better for long term data protection. :)


Also IPT_UI_TIMECODE handling was added yesterday in input.cpp


Tristan, just to be sure that we are in sync: for "elaboration iterations" you mean a scenario where we are elaborating a VHDL architecture "a", which needs a Verilog module "b" which, in turns, needs another VHDL architecture "c" which does not belong to the original subhierarchy of "a".


> Yeah, I like the Message object approach. Basically, the point of that function and the packets mode, as you saw, was to not do expensive conversions on the way out of OpenPGP.js for file encryption operations, so this solves that problem.

@bartbutler this commit reduces memory consumption even more by using transferable objects for the Web Worker. Basically it transfers ownership of the allocated ArrayBuffer from one thread to another and thereby prevents the need to copy the memory (similar to "call by reference" in C++). Since the main thread can't access the buffer anymore once it's been passed on, there are cases where this could get in the way. So I've hidden the feature behind the `openpgp.config.zeroCopy` flag. See the unit test on how to use it:

https://github.com/openpgpjs/openpgpjs/commit/ab68d4b9974cfb310b66650170dcb289a76e339a#diff-5fe7a44144bcf6a4e412a18fd8c09915R618

Also, here is more info on the performance impact of transferable objects:

https://developers.google.com/web/updates/2011/12/Transferable-Objects-Lightning-Fast


Cleanup ccache
ccache -C


*Either* backport latest `ocamlgraph` support to `dose` 3.3 or get `opam` updated for `dose` 3.4.1 and released...


[GregorianCalendar](https://github.com/wordpress-mobile/WordPress-Android/blob/e1e5d193030fffbab481599f3153306382d4f0f8/WordPress/src/main/java/org/wordpress/android/models/Account.java#L14) and [TimeZone](https://github.com/wordpress-mobile/WordPress-Android/blob/e1e5d193030fffbab481599f3153306382d4f0f8/WordPress/src/main/java/org/wordpress/android/models/Account.java#L16) imports are no longer needed. Let's remove them from the file. Cheers!


Add to changed files first line entry like
```
#if MONO
#undef FEATURE_PAL
#endif
```

instead of messing with every single FEATURE_PAL


It feels a bit off to me having a function in a class returning a set of functions -- perhaps this could be put into its own class (Something like `WindowStore`, for example), and `open` returns a new instance of it?


Я тебе в барбершопе подробно написал про плагин pixel-perfect, почитай там, он удобнее чем все эти дополнительные стили с фонами, и картинки фонов не нужно будет в гитигнор добавлять, и вообще меньше заморок всяких )


Hi @Martin-Wegner
I'll add the NULL check, i didn't because I probably wrong assumed form the use of this method that the token would never be null.
for the name what about isQuotedToken?
Any better proposal?


This seems to not work yet:
http://buildbot.sosy-lab.org/results/integration-policyIteration/2613.integration-policyIteration.diff.html

The used JavaSMT version here is 0.3-89-g8ed7153, which should contain this commit.


How can I be listed as one of the contributors to the project?


@nicraMarcin i tak używam wersji 3.1.27 z łatką, więc na nic to się zda.


なんかここで`res`も`body`も取れてない


It seems like a supervisor thing based on [other people running into the issue](http://serverfault.com/a/742366)


test comment


Ugh... Didn't replace the magic number with RANGE... Attempting to fix this will involve re-selecting the test data. Maybe we'll just leave it here.


Should probably say, "Add tests for your change**s**." (plural)


@d42f @akapaul @nervgh please check out this plunkr: https://plnkr.co/edit/WUVVj0POuZ4ekqfzzJQt?p=preview
open the console and add a file. as you can see in the logged uploader the _directives.select array is empty.
cloning the element obviously destroys the event binding as @akapaul already described.


Reminder to change this in the future (though it'll be good enough for now, I think)


3.2.0 onwards.
Good call on the meta :+1:


good idea


Interpreter yells at me for including () on g.user.is_authenticated (same thing for line 33). Python versioning differences? In any case, if you have an error in this line, that's likely it.


I can see that getting confusing, as each of the methods calls `getWindowStore()` -- so if they were in a class called `WindowStore` that would be odd. I see what you mean though. The class could be opened with the store and then all methods act on that one. That's sort of the point of the `StoreService` though -- would this class just be private inside this same file?


Done here 2abc59b


Ok, rozumiem.
zacząłem nawet trochę kombinować, ale właśnie mam errory extendsall. to zostawiam to w spokoju


Левый паддинг нужно задавать не этому элементу, а его родителю .hotel, и он будет равен 6%.
Ну и по аналогии с правым паддингом - его надо не для .hotel-rating добавлять, да ещё и в пикселах, а для .hotel, и в %.
Проверь все блоки, чтобы у них эти 6% были правильно заданы.


This was meant to be [Bug #5]...


тут не нужен правый паддинг, вместо него паддинг будет у .hotel


I have to try this out, but I'm pretty sure this wasn't handled before, that's why I put the comment :angel: (to remember to support it — and create an issue on that).


maybe :sweat_smile:


I had to change the `-Xbootclasspath` argument to `-Xbootclasspath/p:../../mongo-java-driver-2.11.3.jar` with the mongo-java-driver jar file in the repository root (same on line 20).


Thanks for checking. I was afraid of this. I've fixed it the "proper" way: https://github.com/xdebug/xdebug/pull/261


This page is good. While not necessary for students, it seems like the history should be somewhere that's at least accessible to them...

The halting problem is also one where you really need to ponder it a bit before getting it, and I think this alternate version is also helpful, especually making concrete the idea of "in general".


v1.1.2 doesn't seem to work, is there a newer version?


ERROR:
```
protected function initDir()
{
    $this->dir = dirname($this->file) . DIRECTORY_SEPARATOR;
}
```

in initDir() -> DIRECTORY_SEPARATOR under WINDOWS OS is '\'.
When the content is 'remote' it generates wrong https path..

Example:
https://raw.githubusercontent.com/zendframework/zend-diactoros/master/doc\book/overview.md
instead of
https://raw.githubusercontent.com/zendframework/zend-diactoros/master/doc/book/overview.md


Curious that it doesn't affect me on Linux, Windows or OSX and the CI build works too !

I suspect its coming in with an optional dependency that you don't build with, but rather than try and chase  that down I'll just add it to WorkoutWindow.h :)


What a Pushkin, what a son of a bitch!


Hi. Brindu asked me to take a look over the code.

# This seems quite similar to the one on line #68. Is there a reason why we are not using a function?
# In both cases we are subtracting. Maybe we can use a magic values or simplify the operation?

cmess110


me imagino que es un programa de ping pon mi pregunta es si al chocar el balon con la reaquetas el sentido va cambiando no se si mexplico por que si el Ball no se update se combierte en un bucle te lo digo por esperiencia jajajaj
por ejemplo veo que pones

public void refresh() {
 		xPos += Xdir;
 		yPos += Ydir;
 		ballArea.setLocation((int) xPos, (int) yPos);
 	}
me imagino que sera el update de la ball


yeah, useful to mark off version :smile: :+1:


Hi


Yeah, `WindowStore` probably isn't the best name, but I'd say you can probably keep it in the same file since it's the only place it's instantiated (if we need to do this more, then we'll probably need to bring it out).


Я думаю это можно сделать внутри [hostController presentViewController:vc animated:true completion:nil]; ?


umm


Yeah, I'm agree. But this component already doesn't used and will be removed in the next commit


@mtorromeo thanks for the tip, you are right.


SosOption was a class, not a function.. When you are making large changes like this to the core of a project (deleting a whole class, even if that's because it's no longer required due to extra functionality in library modules, is a big change that warrants explanation) you should explain them either in comments in the code, if appropriate, or in the commit message - that's the whole point of git allowing us to associate text with a commit!

This helps save reviewers time as well as making it easier to understand changes in the future (maybe a year down the line someone notices a regression from this set of changes.. It is much easier to understand the reasoning behind a change if the original author's intent was made clear in the commit).


This is so many positional arguments. Why not use, say, json for serialization?


But it's already int!


Needs to be fixed to include the party's name in the `src` and `alt`
Pay attention that not all the parties logos are in SVG format.


Ich denke nicht, dass hier weitere Sql-Injections möglich waren, da die Parameter nicht direkt aus GET-Parametern kommen, aber prepared Statements sind ja so oder so besser/sicherer.


To be clear: i this case a commit message is most appropriate since the commit is removing lines. It would not make sense to continue to document the historic use of `SoSOption` after removing the code.


Łatkę pewnie by dało się nałożyć przez podpięcie się pod polecenie `post-install-cmd`


Really, use json.


note to self: the grep command incorrectly reports CPUS=2 on RPi 1, becuase the string "processor" appears twice, once giving the number of the processor and once in the processor's description.


このexitってなんでしょうか？？


@bmr-cymru My bad. I totally agree that I could have added better explanation for this change. I definitely think that everyone time is valuable. I will keep this in mind from this time on-wards.


Labels is dynamic, but I moved them into model Environment. This component is rudiment.


You're extending H5P.Question so you probably shouldn't define attach here, H5P.Question has attach so registerDomElements should be used to add your content to the dom


These changes aren't reflected in the changelog, nor have `@since` comments, which would be helpful for making code backwards-compatible.


Hello chrootsu.  Thank you for the link.  Please forgive my caution!

Regards, Max


@thpr you aware you have a conflict in your code here? Looks like a simple comment change.


基本的に( ) はつけないのが一般的ですね。


The oracle sql string doesn't have a semi-colon at the end and table-name in double quotes.


Now it not workd


Initial commit


Hi humans


例外処理を記述するのは良いです！
しかし、このやり方は違いますね。
http://ruby-rails.hatenadiary.com/entry/20141127/1417086075

この記事を参考にしてみてください。
ただ、今回はそこまで求めてないので次の掲示板作成研修ではflashを使ってみてください。


"$(locateQt)" was not returning the proper folder on arm


Why continue to call this `OptionParserExtended` when it now wraps an `ArgumentParser'?


This whole block is usesless. It checks a bunch of ifs and ultimately sets `self.is_afk = self.is_afk`. Wat.


The NULL check was only a hint. I also believe that the tokens string array could not contain NULL values. But it is a static method and so you never know what the future brings :)

"isQuotedToken" sounds good to me but I'm a little bit scared... The surrounding code is:

```
else if ( isQuoteCharacter( token) ) {
  inQuote = !inQuote;
  templateQuery.append( token );
  continue;
}
```

You see there is a inQuote state...


I couldn't seem to find this at all in Raspbian Jessie


What a Pushkin, what a son of a bitch!


O proszę - pewnie więcej 'hooków' jest dostępnych w composerze.


I still think that a local function `get_context()` would be nicer than creating contexts in three different places.
The memory leak should still be there (I guess it'd be nice to have a test under tests/ that checks that these objects can be garbage collected).
The way you check if a tag is selected (`tag.selected(tag.getscreen(t)) == t`) is still broken when multiple tags are selected.

Besides that it's mostly fine with me, I guess. I don't have the time to look too closely right now, sorry.


This is probably only temporary? Don't think this will result in a valid xAPI statement.


complained that didn't understand the "-f" on Raspbian Jessie


This should read `*/libc.a:*.o(.text* .literal*)`. Without the `:*.o`, this fails to match the members of the libc library.  See #1025