I have concerns now on conflicts when importing multiple static methods with the same name, e.g. List.fromIterable and Stream.fromIterable.   Maybe we should include the class name in the method, e.g. `listIterable`.  This basically brings us to where we were with `iterableList`, except that these constructors would be grouped together alphabetically, e.g. `listIterable`, `listIterator` which I think is easier to find.  With static imports `listIterable` is easier to read than `fromIterable` because it includes the return type in the name (hmmm.... should we be encouraging people to rely on the name instead of the type?).


I think this breaks dialing with TLS (or any other `Dial` that returns an implementation of `net.Conn` other than `*net.TCPConn`).


The tests looks good ... the commit message ... not in line "with spec" ... But amend can be run many times ...


see @mikedanese's PR which got merged literally minutes ago for the new home for this :)  Sorry.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14646](https://teamcity.mesosphere.io/viewLog.html?buildId=126806&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:04:06


@Moataz-hesham


release-5.x (lefticus) - i386-Windows-10-VisualStudio-12: OK (388 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


Why is the background processor catches StackOverflowException/OutOfMemoryException and here we catches JavascriptExceptionObject here?  We don't do leave script when we use the ForegroundJobProcessor?


For the record, this commit fixes #139 . The cause might be caused by apng patch mismatch. I will need to look into this.


Working up the courage to try to start converting stuff to 1.8.9 soon


Hi to you @sarahhunt! This was actually my mistake, the variant's .start shouldn't be equal to the query, as was asserted, just greater than what we requested:

assertThat(v.getStart()).isGreaterThanOrEqualTo(start);


I think this should return nil


the regular memcpy() is marked as a regular function by llvm, so it has to call it.
__builtin_memcpy() doing actual memory copy, so llvm knows how to generated optimal code for it
considering alignment requirement. I haven't tried __builtin_memcmp...


Everything is in this zip


yep


If it's legal to add some comments to clarify what each of these things is doing, and/or a link to learn more about what you're specifying, please do.


This may be the only way for now, but I was wondering if __builtin_memcmp() worked. If not, maybe renaming that variable "p" will make it look a bit nicer!

While I'm here... A few other places need whitespace cleanup: compare line 48 with 86. Pick one style (48) and use it everywhere.

I think this is a good example of parsing packet headers, but I am wondering why we need to. I'm not expecting you to change this program, but if I wanted to do this I'd try tracing at the syscall or socket level first. Eg, http://www.dtracebook.com/index.php/Application_Level_Protocols:weblatency.d


release-5.x (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: OK (389 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


release-5.x (lefticus) - Win64-Windows-10-VisualStudio-12: OK (388 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


What's this about?  There's no drop.code in [our main drop type][1].

[1]: https://github.com/azurestandard/api-spec/blob/85776deb26fe175449319436240c28d40c200261/public.json#L3259-L3481


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14647](https://teamcity.mesosphere.io/viewLog.html?buildId=126831&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:04:11


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14645](https://teamcity.mesosphere.io/viewLog.html?buildId=126803&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 174 Build time: 00:06:19


First test for Taft lad shield


[inst/doc/caretEnsemble-intro.R:14:28:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/inst/doc/caretEnsemble-intro.R#L14) *style:* **Commas should always have a space after.**
```r
training <- Sonar[ inTrain,]
                           ^
```
[inst/doc/caretEnsemble-intro.R:15:27:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/inst/doc/caretEnsemble-intro.R#L15) *style:* **Commas should always have a space after.**
```r
testing <- Sonar[-inTrain,]
                          ^
```
[inst/doc/caretEnsemble-intro.R:70:14:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/inst/doc/caretEnsemble-intro.R#L70) *style:* **Trailing whitespace is superfluous.**
```r
  model_list,
             ^
```
[inst/doc/caretEnsemble-intro.R:82:51:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/inst/doc/caretEnsemble-intro.R#L82) *style:* **Commas should always have a space after.**
```r
model_preds <- lapply(model_preds, function(x) x[,"M"])
                                                  ^
```
[inst/doc/caretEnsemble-intro.R:136:1:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/inst/doc/caretEnsemble-intro.R#L136) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/caretEnsemble.R:145:76:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/R/caretEnsemble.R#L145) *style:* **Commas should always have a space after.**
```r
    tmp.t <- out[attributes(out)$dimnames[[nams[[i]]]] == as.character(bt[,nams[i]])]
                                                                           ^
```
[R/caretEnsemble.R:192:38:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/R/caretEnsemble.R#L192) *style:* **Commas should always have a space after.**
```r
  dat <- dat[order(dat[["overall"]]),]
                                     ^
```
[R/caretEnsemble.R:200:33:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/R/caretEnsemble.R#L200) *style:* **Commas should always have a space after.**
```r
  x$importance <- x$importance[,"Overall", drop=FALSE]
                                ^
```
[R/caretEnsemble.R:213:36:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/R/caretEnsemble.R#L213) *style:* **Commas should always have a space after.**
```r
  dat$model <- sub("\\.[^\n]*", "",dat$id)
                                   ^
```
[R/caretEnsemble.R:223:26:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/R/caretEnsemble.R#L223) *style:* **Commas should always have a space after.**
```r
  row.names(dat) <- dat[,1]
                         ^
```
[R/caretEnsemble.R:224:15:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/R/caretEnsemble.R#L224) *style:* **Commas should always have a space after.**
```r
  return(dat[,-1])
              ^
```
[R/caretList.R:268:69:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/R/caretList.R#L268) *style:* **Commas should always have a space after.**
```r
        caret::predict.train(x, type="prob", newdata=newdata, ...)[,2]
                                                                    ^
```
[R/helper_functions.R:15:30:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/R/helper_functions.R#L15) *style:* **Commas should always have a space after.**
```r
    xWbar <- weighted.mean(x,w,na.rm=na.rm)
                             ^
```
[R/helper_functions.R:15:32:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/R/helper_functions.R#L15) *style:* **Commas should always have a space after.**
```r
    xWbar <- weighted.mean(x,w,na.rm=na.rm)
                               ^
```
[R/helper_functions.R:63:78:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/R/helper_functions.R#L63) *style:* **Commas should always have a space after.**
```r
    probModels <- sapply(list_of_models, function(x) modelLookup(x$method)[1,"probModel"])
                                                                             ^
```
[R/helper_functions.R:177:12:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/R/helper_functions.R#L177) *style:* **Commas should always have a space after.**
```r
  b <- b[a,]
           ^
```
[R/helper_functions.R:245:87:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/R/helper_functions.R#L245) *style:* **Commas should always have a space after.**
```r
    set(modelLibrary, i=good_pos_values, j="pred", value=modelLibrary[good_pos_values,positive,with=FALSE])
                                                                                ^
```
[R/helper_functions.R:245:96:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/R/helper_functions.R#L245) *style:* **Commas should always have a space after.**
```r
    set(modelLibrary, i=good_pos_values, j="pred", value=modelLibrary[good_pos_values,positive,with=FALSE])
                                                                                ^
```
[R/helper_functions.R:256:67:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/R/helper_functions.R#L256) *style:* **Commas should always have a space after.**
```r
  return(list(obs=modelLibrary$obs, preds=as.matrix(modelLibrary[,model_names,with=FALSE]), type=type))
                                                                  ^
```
[R/helper_functions.R:256:79:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/R/helper_functions.R#L256) *style:* **Commas should always have a space after.**
```r
  return(list(obs=modelLibrary$obs, preds=as.matrix(modelLibrary[,model_names,with=FALSE]), type=type))
                                                                              ^
```
[tests/testthat/test-caretList.R:62:41:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L62) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,1:4], iris[,5]), iris[,5])
                                        ^
```
[tests/testthat/test-caretList.R:62:53:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L62) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,1:4], iris[,5]), iris[,5])
                                                    ^
```
[tests/testthat/test-caretList.R:62:64:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L62) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,1:4], iris[,5]), iris[,5])
                                                               ^
```
[tests/testthat/test-caretList.R:63:41:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L63) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,2:5], iris[,1]), iris[,1])
                                        ^
```
[tests/testthat/test-caretList.R:63:53:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L63) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,2:5], iris[,1]), iris[,1])
                                                    ^
```
[tests/testthat/test-caretList.R:63:64:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L63) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,2:5], iris[,1]), iris[,1])
                                                               ^
```
[tests/testthat/test-caretList.R:64:61:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L64) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(Species ~ ., iris), iris[,"Species"])
                                                            ^
```
[tests/testthat/test-caretList.R:65:65:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L65) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(Sepal.Width ~ ., iris), iris[,"Sepal.Width"])
                                                                ^
```
[tests/testthat/test-caretList.R:86:36:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L86) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control))
                                   ^
```
[tests/testthat/test-caretList.R:86:48:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L86) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control))
                                               ^
```
[tests/testthat/test-caretList.R:87:36:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L87) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control))
                                   ^
```
[tests/testthat/test-caretList.R:87:48:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L87) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control))
                                               ^
```
[tests/testthat/test-caretList.R:88:36:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L88) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control, continue_on_fail=TRUE))
                                   ^
```
[tests/testthat/test-caretList.R:88:48:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L88) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control, continue_on_fail=TRUE))
                                               ^
```
[tests/testthat/test-caretList.R:89:33:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L89) *style:* **Commas should always have a space after.**
```r
      expect_is(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control, continue_on_fail=TRUE), "caretList")
                                ^
```
[tests/testthat/test-caretList.R:89:45:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L89) *style:* **Commas should always have a space after.**
```r
      expect_is(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control, continue_on_fail=TRUE), "caretList")
                                            ^
```
[tests/testthat/test-caretList.R:100:13:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L100) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
            ^
```
[tests/testthat/test-caretList.R:100:25:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L100) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
                        ^
```
[tests/testthat/test-caretList.R:113:17:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L113) *style:* **Commas should always have a space after.**
```r
  expect_is(p1[,1], "character")
                ^
```
[tests/testthat/test-caretList.R:114:17:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L114) *style:* **Commas should always have a space after.**
```r
  expect_is(p1[,2], "character")
                ^
```
[tests/testthat/test-caretList.R:117:17:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L117) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,1], "character")
                ^
```
[tests/testthat/test-caretList.R:118:17:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L118) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,2], "character")
                ^
```
[tests/testthat/test-caretList.R:121:17:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L121) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,1], "character")
                ^
```
[tests/testthat/test-caretList.R:122:17:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L122) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,2], "character")
                ^
```
[tests/testthat/test-caretList.R:127:13:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L127) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
            ^
```
[tests/testthat/test-caretList.R:127:25:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L127) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
                        ^
```
[tests/testthat/test-caretList.R:136:17:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L136) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,1], "numeric")
                ^
```
[tests/testthat/test-caretList.R:137:17:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L137) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,2], "numeric")
                ^
```
[tests/testthat/test-caretList.R:139:17:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L139) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,1], "numeric")
                ^
```
[tests/testthat/test-caretList.R:140:17:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L140) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,2], "numeric")
                ^
```
[tests/testthat/test-caretList.R:160:17:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L160) *style:* **Commas should always have a space after.**
```r
      x = iris[,1:3],
                ^
```
[tests/testthat/test-caretList.R:161:17:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L161) *style:* **Commas should always have a space after.**
```r
      y = iris[,4],
                ^
```
[tests/testthat/test-caretList.R:205:23:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L205) *style:* **Commas should always have a space after.**
```r
            x = iris[,1:3],
                      ^
```
[tests/testthat/test-caretList.R:206:23:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L206) *style:* **Commas should always have a space after.**
```r
            y = iris[,4],
                      ^
```
[tests/testthat/test-caretList.R:332:18:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L332) *style:* **Commas should never have a space before.**
```r
      y = train[ , "Class"],
                ~^
```
[tests/testthat/test-caretList.R:448:37:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L448) *style:* **Commas should always have a space after.**
```r
      tuneGrid=data.frame(.cp=c(.01,.001,.1,1))
                                    ^
```
[tests/testthat/test-caretList.R:448:42:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L448) *style:* **Commas should always have a space after.**
```r
      tuneGrid=data.frame(.cp=c(.01,.001,.1,1))
                                         ^
```
[tests/testthat/test-caretList.R:448:45:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L448) *style:* **Commas should always have a space after.**
```r
      tuneGrid=data.frame(.cp=c(.01,.001,.1,1))
                                            ^
```
[tests/testthat/test-caretList.R:519:14:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L519) *style:* **Commas should always have a space after.**
```r
  x <- iris[,1:3]
             ^
```
[tests/testthat/test-caretList.R:520:14:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-caretList.R#L520) *style:* **Commas should always have a space after.**
```r
  y <- iris[,4]
             ^
```
[tests/testthat/test-ensembleMethods.R:200:40:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensembleMethods.R#L200) *style:* **Commas should always have a space after.**
```r
  mr1 <- mr1[order(mr1$method, mr1$id),]
                                       ^
```
[tests/testthat/test-ensembleMethods.R:201:40:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensembleMethods.R#L201) *style:* **Commas should always have a space after.**
```r
  mr2 <- mr2[order(mr2$method, mr2$id),]
                                       ^
```
[tests/testthat/test-ensembleMethods.R:220:70:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensembleMethods.R#L220) *style:* **Commas should always have a space after.**
```r
  expect_equal(mr_reg_long[order(mr_reg_long$method, mr_reg_long$id),"resid"], mr2[order(mr2$method, mr2$id),"resid"])
                                                                     ^
```
[tests/testthat/test-ensembleMethods.R:220:110:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensembleMethods.R#L220) *style:* **Commas should always have a space after.**
```r
  expect_equal(mr_reg_long[order(mr_reg_long$method, mr_reg_long$id),"resid"], mr2[order(mr2$method, mr2$id),"resid"])
                                                                                ^
```
[tests/testthat/test-ensembleMethods.R:281:20:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensembleMethods.R#L281) *style:* **Commas should always have a space after.**
```r
        se=tests[i,"se"],
                   ^
```
[tests/testthat/test-ensembleMethods.R:282:32:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensembleMethods.R#L282) *style:* **Commas should always have a space after.**
```r
        return_weights=tests[i,"return_weights"]
                               ^
```
[tests/testthat/test-ensembleMethods.R:286:16:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensembleMethods.R#L286) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"se"]){
               ^
```
[tests/testthat/test-ensembleMethods.R:294:16:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensembleMethods.R#L294) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"return_weights"]){
               ^
```
[tests/testthat/test-ensembleMethods.R:309:20:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensembleMethods.R#L309) *style:* **Commas should always have a space after.**
```r
        se=tests[i,"se"],
                   ^
```
[tests/testthat/test-ensembleMethods.R:310:32:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensembleMethods.R#L310) *style:* **Commas should always have a space after.**
```r
        return_weights=tests[i,"return_weights"],
                               ^
```
[tests/testthat/test-ensembleMethods.R:315:16:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensembleMethods.R#L315) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"se"]){
               ^
```
[tests/testthat/test-ensembleMethods.R:323:16:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensembleMethods.R#L323) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"return_weights"]){
               ^
```
[tests/testthat/test-ensemble.R:28:11:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensemble.R#L28) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
          ^
```
[tests/testthat/test-ensemble.R:28:23:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensemble.R#L28) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
                      ^
```
[tests/testthat/test-ensemble.R:56:11:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensemble.R#L56) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
          ^
```
[tests/testthat/test-ensemble.R:56:23:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-ensemble.R#L56) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
                      ^
```
[tests/testthat/test-helper_functions.R:28:13:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-helper_functions.R#L28) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
            ^
```
[tests/testthat/test-helper_functions.R:28:25:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-helper_functions.R#L28) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
                        ^
```
[tests/testthat/test-helper_functions.R:37:13:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-helper_functions.R#L37) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
            ^
```
[tests/testthat/test-helper_functions.R:37:39:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-helper_functions.R#L37) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
                                      ^
```
[tests/testthat/test-helper_functions.R:43:11:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-helper_functions.R#L43) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
          ^
```
[tests/testthat/test-helper_functions.R:43:37:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-helper_functions.R#L43) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
                                    ^
```
[tests/testthat/test-helper_functions.R:151:93:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-helper_functions.R#L151) *style:* **Commas should always have a space after.**
```r
  modelLibrary$nn <- modelLibrary$lm[sample(1:nrow(modelLibrary$lm), nrow(modelLibrary$lm)),]
                                                                                ^
```
[tests/testthat/test-helper_functions.R:185:18:](https://github.com/zachmayer/caretEnsemble/blob/422e7f76377e4ea19e56987fbe935671962e6cb0/tests/testthat/test-helper_functions.R#L185) *style:* **Commas should always have a space after.**
```r
      iris[1:100,-5],
                 ^
```


This looks like a left-over hanging brace; probably shouldn't be here


Extra whitespace here


@Moataz-hesham


We discovered that the `util` module is not included; you can replace `util.today()` with `new Date()`


Ooh, you could use this to pollyfill new features!


Why?


Yeah I think given the dependency of cromwell on cromwell-backend that's the way to go.


There are hanging commas after the colon on each of these attributes that probably have to be removed


Thanks — slip of the keyboard.


Eh?


should the sanity check use ">=" instead of "="?


I have to defer to those more familiar with the details of call caching ( @scottfrazer @cjllanwarne @Horneth ) if non-copying is an issue


@eclarizio Is the value being converted to ```Date``` here so that the patternfly datepicker can display it correctly?


release-5.x (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-NoThreads: OK (393 of 396 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.24%25-yellow.svg)


For best code formatting, make sure to include spaces beween the closing parentheses in `function` delcarations and the opening brace: `$('pre code').each(function(i, block) {`


comments for param1 ~ 4 look a little odd.  I'd probably put what the official use of those params should be and add "-- not support" to the end.


What's wrong with "datagram" from a legal writing perspective?

On Fri, Feb 5, 2016 at 4:23 PM Kyle Mitchell <notifications@github.com>
wrote:

> Eh?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kemitchell/american-legal-archaisms/commit/72b211d1f9af000927085d77ca81af3f92537fd9#commitcomment-15928736>
> .
>


It'd be nice if we could avoid writing "HACK" into the comments.


You may want to make this a separate quick fix.


I've seen it used in lists with "telegram", "facsimile", etc. I'm assuming the _don't_ mean a modern packet-switch unit.


Can you test the following code (should not return anything):

    Function Foo() As Boolean
        Foo = True
    End Function
    Sub Bar(ByVal fizz As Boolean)
    End Sub
    Sub Baz()
        Bar Foo()
    End Sub


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14649](https://teamcity.mesosphere.io/viewLog.html?buildId=126896&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:10


Hmm, if the user's account has a primary email set, and it matches the identity, maybe we should use that one?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1306](http://teamcity.monogame.net/viewLog.html?buildId=14389&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:31:48


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14648](https://teamcity.mesosphere.io/viewLog.html?buildId=126895&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:05:16


@sascala Would you continue to work on these edits? Task, Package, and Marathon need the most work. I suggest reviewing with Support when ready, then doing a PR. Tamar is the best resource for these docs.


Typo here, currentHeight


TeamCity pull requests :: netty [Build 1225](https://garage.netty.io/teamcity/viewLog.html?buildId=5490&buildTypeId=pulls_netty&guest=1) is now running


don't think you meant to add the var here, it's already defined below


`BasicCourse`?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14650](https://teamcity.mesosphere.io/viewLog.html?buildId=126901&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:04:03


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14652](https://teamcity.mesosphere.io/viewLog.html?buildId=126933&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:00:39


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14651](https://teamcity.mesosphere.io/viewLog.html?buildId=126932&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:00:53


Not sure why some there are changes related to indentation (AS shows it to be exactly like the original)


Cool - I'll make the doseq PR in the AM!

;j-

Sent from my Turing Machine

> On Feb 5, 2016, at 14:33, Duncan McGreggor <notifications@github.com> wrote:
>
> Converted the map lookup to a multimethod.
>
> This was inspired by @jmorton's use of (Level/toLevel ...) in his gist here:
> * https://gist.github.com/jmorton/719baeda698720e5635a
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/oubiwann/twig/commit/3a8e2937308f61192d8eb8544502dfa5b8dd6175


release-5.x (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (397 of 397 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


weather information doesnt load. What can i do?


+1. Looks good


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14653](https://teamcity.mesosphere.io/viewLog.html?buildId=126936&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:00:24


Good point, I guess bool ops really can't be converted back.


That's definitely not what `|` does...


113008903Provide-a-better-warning-message-for-a-triangular-window (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1508 of 1508 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


develop (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1511 of 1511 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Is this change necessary?  Checks with check_*_file are done case-insensitive.


ipvx -> IPvx


I just did that because it is subject to change
but yeah I can do that in the future and when this file is updated


I would just change IPPool to be pool


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14655](https://teamcity.mesosphere.io/viewLog.html?buildId=126948&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:03:51


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14654](https://teamcity.mesosphere.io/viewLog.html?buildId=126947&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:04:01


:tada:


[inst/doc/caretEnsemble-intro.R:14:28:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/inst/doc/caretEnsemble-intro.R#L14) *style:* **Commas should always have a space after.**
```r
training <- Sonar[ inTrain,]
                           ^
```
[inst/doc/caretEnsemble-intro.R:15:27:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/inst/doc/caretEnsemble-intro.R#L15) *style:* **Commas should always have a space after.**
```r
testing <- Sonar[-inTrain,]
                          ^
```
[inst/doc/caretEnsemble-intro.R:70:14:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/inst/doc/caretEnsemble-intro.R#L70) *style:* **Trailing whitespace is superfluous.**
```r
  model_list,
             ^
```
[inst/doc/caretEnsemble-intro.R:82:51:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/inst/doc/caretEnsemble-intro.R#L82) *style:* **Commas should always have a space after.**
```r
model_preds <- lapply(model_preds, function(x) x[,"M"])
                                                  ^
```
[inst/doc/caretEnsemble-intro.R:136:1:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/inst/doc/caretEnsemble-intro.R#L136) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/caretEnsemble.R:145:76:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/R/caretEnsemble.R#L145) *style:* **Commas should always have a space after.**
```r
    tmp.t <- out[attributes(out)$dimnames[[nams[[i]]]] == as.character(bt[,nams[i]])]
                                                                           ^
```
[R/caretEnsemble.R:192:38:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/R/caretEnsemble.R#L192) *style:* **Commas should always have a space after.**
```r
  dat <- dat[order(dat[["overall"]]),]
                                     ^
```
[R/caretEnsemble.R:200:33:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/R/caretEnsemble.R#L200) *style:* **Commas should always have a space after.**
```r
  x$importance <- x$importance[,"Overall", drop=FALSE]
                                ^
```
[R/caretEnsemble.R:213:36:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/R/caretEnsemble.R#L213) *style:* **Commas should always have a space after.**
```r
  dat$model <- sub("\\.[^\n]*", "",dat$id)
                                   ^
```
[R/caretEnsemble.R:223:26:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/R/caretEnsemble.R#L223) *style:* **Commas should always have a space after.**
```r
  row.names(dat) <- dat[,1]
                         ^
```
[R/caretEnsemble.R:224:15:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/R/caretEnsemble.R#L224) *style:* **Commas should always have a space after.**
```r
  return(dat[,-1])
              ^
```
[R/caretList.R:268:69:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/R/caretList.R#L268) *style:* **Commas should always have a space after.**
```r
        caret::predict.train(x, type="prob", newdata=newdata, ...)[,2]
                                                                    ^
```
[R/helper_functions.R:15:30:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/R/helper_functions.R#L15) *style:* **Commas should always have a space after.**
```r
    xWbar <- weighted.mean(x,w,na.rm=na.rm)
                             ^
```
[R/helper_functions.R:15:32:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/R/helper_functions.R#L15) *style:* **Commas should always have a space after.**
```r
    xWbar <- weighted.mean(x,w,na.rm=na.rm)
                               ^
```
[R/helper_functions.R:63:78:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/R/helper_functions.R#L63) *style:* **Commas should always have a space after.**
```r
    probModels <- sapply(list_of_models, function(x) modelLookup(x$method)[1,"probModel"])
                                                                             ^
```
[R/helper_functions.R:177:12:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/R/helper_functions.R#L177) *style:* **Commas should always have a space after.**
```r
  b <- b[a,]
           ^
```
[R/helper_functions.R:245:87:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/R/helper_functions.R#L245) *style:* **Commas should always have a space after.**
```r
    set(modelLibrary, i=good_pos_values, j="pred", value=modelLibrary[good_pos_values,positive,with=FALSE])
                                                                                ^
```
[R/helper_functions.R:245:96:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/R/helper_functions.R#L245) *style:* **Commas should always have a space after.**
```r
    set(modelLibrary, i=good_pos_values, j="pred", value=modelLibrary[good_pos_values,positive,with=FALSE])
                                                                                ^
```
[R/helper_functions.R:256:67:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/R/helper_functions.R#L256) *style:* **Commas should always have a space after.**
```r
  return(list(obs=modelLibrary$obs, preds=as.matrix(modelLibrary[,model_names,with=FALSE]), type=type))
                                                                  ^
```
[R/helper_functions.R:256:79:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/R/helper_functions.R#L256) *style:* **Commas should always have a space after.**
```r
  return(list(obs=modelLibrary$obs, preds=as.matrix(modelLibrary[,model_names,with=FALSE]), type=type))
                                                                              ^
```
[tests/testthat/test-caretList.R:62:41:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L62) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,1:4], iris[,5]), iris[,5])
                                        ^
```
[tests/testthat/test-caretList.R:62:53:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L62) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,1:4], iris[,5]), iris[,5])
                                                    ^
```
[tests/testthat/test-caretList.R:62:64:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L62) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,1:4], iris[,5]), iris[,5])
                                                               ^
```
[tests/testthat/test-caretList.R:63:41:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L63) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,2:5], iris[,1]), iris[,1])
                                        ^
```
[tests/testthat/test-caretList.R:63:53:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L63) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,2:5], iris[,1]), iris[,1])
                                                    ^
```
[tests/testthat/test-caretList.R:63:64:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L63) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,2:5], iris[,1]), iris[,1])
                                                               ^
```
[tests/testthat/test-caretList.R:64:61:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L64) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(Species ~ ., iris), iris[,"Species"])
                                                            ^
```
[tests/testthat/test-caretList.R:65:65:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L65) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(Sepal.Width ~ ., iris), iris[,"Sepal.Width"])
                                                                ^
```
[tests/testthat/test-caretList.R:86:36:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L86) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control))
                                   ^
```
[tests/testthat/test-caretList.R:86:48:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L86) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control))
                                               ^
```
[tests/testthat/test-caretList.R:87:36:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L87) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control))
                                   ^
```
[tests/testthat/test-caretList.R:87:48:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L87) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control))
                                               ^
```
[tests/testthat/test-caretList.R:88:36:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L88) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control, continue_on_fail=TRUE))
                                   ^
```
[tests/testthat/test-caretList.R:88:48:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L88) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control, continue_on_fail=TRUE))
                                               ^
```
[tests/testthat/test-caretList.R:89:33:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L89) *style:* **Commas should always have a space after.**
```r
      expect_is(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control, continue_on_fail=TRUE), "caretList")
                                ^
```
[tests/testthat/test-caretList.R:89:45:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L89) *style:* **Commas should always have a space after.**
```r
      expect_is(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control, continue_on_fail=TRUE), "caretList")
                                            ^
```
[tests/testthat/test-caretList.R:100:13:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L100) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
            ^
```
[tests/testthat/test-caretList.R:100:25:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L100) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
                        ^
```
[tests/testthat/test-caretList.R:113:17:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L113) *style:* **Commas should always have a space after.**
```r
  expect_is(p1[,1], "character")
                ^
```
[tests/testthat/test-caretList.R:114:17:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L114) *style:* **Commas should always have a space after.**
```r
  expect_is(p1[,2], "character")
                ^
```
[tests/testthat/test-caretList.R:117:17:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L117) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,1], "character")
                ^
```
[tests/testthat/test-caretList.R:118:17:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L118) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,2], "character")
                ^
```
[tests/testthat/test-caretList.R:121:17:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L121) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,1], "character")
                ^
```
[tests/testthat/test-caretList.R:122:17:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L122) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,2], "character")
                ^
```
[tests/testthat/test-caretList.R:127:13:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L127) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
            ^
```
[tests/testthat/test-caretList.R:127:25:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L127) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
                        ^
```
[tests/testthat/test-caretList.R:136:17:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L136) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,1], "numeric")
                ^
```
[tests/testthat/test-caretList.R:137:17:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L137) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,2], "numeric")
                ^
```
[tests/testthat/test-caretList.R:139:17:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L139) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,1], "numeric")
                ^
```
[tests/testthat/test-caretList.R:140:17:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L140) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,2], "numeric")
                ^
```
[tests/testthat/test-caretList.R:160:17:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L160) *style:* **Commas should always have a space after.**
```r
      x = iris[,1:3],
                ^
```
[tests/testthat/test-caretList.R:161:17:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L161) *style:* **Commas should always have a space after.**
```r
      y = iris[,4],
                ^
```
[tests/testthat/test-caretList.R:205:23:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L205) *style:* **Commas should always have a space after.**
```r
            x = iris[,1:3],
                      ^
```
[tests/testthat/test-caretList.R:206:23:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L206) *style:* **Commas should always have a space after.**
```r
            y = iris[,4],
                      ^
```
[tests/testthat/test-caretList.R:332:18:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L332) *style:* **Commas should never have a space before.**
```r
      y = train[ , "Class"],
                ~^
```
[tests/testthat/test-caretList.R:448:37:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L448) *style:* **Commas should always have a space after.**
```r
      tuneGrid=data.frame(.cp=c(.01,.001,.1,1))
                                    ^
```
[tests/testthat/test-caretList.R:448:42:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L448) *style:* **Commas should always have a space after.**
```r
      tuneGrid=data.frame(.cp=c(.01,.001,.1,1))
                                         ^
```
[tests/testthat/test-caretList.R:448:45:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L448) *style:* **Commas should always have a space after.**
```r
      tuneGrid=data.frame(.cp=c(.01,.001,.1,1))
                                            ^
```
[tests/testthat/test-caretList.R:519:14:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L519) *style:* **Commas should always have a space after.**
```r
  x <- iris[,1:3]
             ^
```
[tests/testthat/test-caretList.R:520:14:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-caretList.R#L520) *style:* **Commas should always have a space after.**
```r
  y <- iris[,4]
             ^
```
[tests/testthat/test-ensembleMethods.R:200:40:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensembleMethods.R#L200) *style:* **Commas should always have a space after.**
```r
  mr1 <- mr1[order(mr1$method, mr1$id),]
                                       ^
```
[tests/testthat/test-ensembleMethods.R:201:40:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensembleMethods.R#L201) *style:* **Commas should always have a space after.**
```r
  mr2 <- mr2[order(mr2$method, mr2$id),]
                                       ^
```
[tests/testthat/test-ensembleMethods.R:220:70:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensembleMethods.R#L220) *style:* **Commas should always have a space after.**
```r
  expect_equal(mr_reg_long[order(mr_reg_long$method, mr_reg_long$id),"resid"], mr2[order(mr2$method, mr2$id),"resid"])
                                                                     ^
```
[tests/testthat/test-ensembleMethods.R:220:110:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensembleMethods.R#L220) *style:* **Commas should always have a space after.**
```r
  expect_equal(mr_reg_long[order(mr_reg_long$method, mr_reg_long$id),"resid"], mr2[order(mr2$method, mr2$id),"resid"])
                                                                                ^
```
[tests/testthat/test-ensembleMethods.R:281:20:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensembleMethods.R#L281) *style:* **Commas should always have a space after.**
```r
        se=tests[i,"se"],
                   ^
```
[tests/testthat/test-ensembleMethods.R:282:32:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensembleMethods.R#L282) *style:* **Commas should always have a space after.**
```r
        return_weights=tests[i,"return_weights"]
                               ^
```
[tests/testthat/test-ensembleMethods.R:286:16:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensembleMethods.R#L286) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"se"]){
               ^
```
[tests/testthat/test-ensembleMethods.R:294:16:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensembleMethods.R#L294) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"return_weights"]){
               ^
```
[tests/testthat/test-ensembleMethods.R:309:20:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensembleMethods.R#L309) *style:* **Commas should always have a space after.**
```r
        se=tests[i,"se"],
                   ^
```
[tests/testthat/test-ensembleMethods.R:310:32:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensembleMethods.R#L310) *style:* **Commas should always have a space after.**
```r
        return_weights=tests[i,"return_weights"],
                               ^
```
[tests/testthat/test-ensembleMethods.R:315:16:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensembleMethods.R#L315) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"se"]){
               ^
```
[tests/testthat/test-ensembleMethods.R:323:16:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensembleMethods.R#L323) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"return_weights"]){
               ^
```
[tests/testthat/test-ensemble.R:28:11:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensemble.R#L28) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
          ^
```
[tests/testthat/test-ensemble.R:28:23:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensemble.R#L28) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
                      ^
```
[tests/testthat/test-ensemble.R:56:11:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensemble.R#L56) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
          ^
```
[tests/testthat/test-ensemble.R:56:23:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-ensemble.R#L56) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
                      ^
```
[tests/testthat/test-helper_functions.R:28:13:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-helper_functions.R#L28) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
            ^
```
[tests/testthat/test-helper_functions.R:28:25:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-helper_functions.R#L28) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
                        ^
```
[tests/testthat/test-helper_functions.R:37:13:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-helper_functions.R#L37) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
            ^
```
[tests/testthat/test-helper_functions.R:37:39:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-helper_functions.R#L37) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
                                      ^
```
[tests/testthat/test-helper_functions.R:43:11:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-helper_functions.R#L43) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
          ^
```
[tests/testthat/test-helper_functions.R:43:37:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-helper_functions.R#L43) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
                                    ^
```
[tests/testthat/test-helper_functions.R:151:93:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-helper_functions.R#L151) *style:* **Commas should always have a space after.**
```r
  modelLibrary$nn <- modelLibrary$lm[sample(1:nrow(modelLibrary$lm), nrow(modelLibrary$lm)),]
                                                                                ^
```
[tests/testthat/test-helper_functions.R:185:18:](https://github.com/zachmayer/caretEnsemble/blob/c201a3e583e23c9783a3483871e14b5f07f68dc6/tests/testthat/test-helper_functions.R#L185) *style:* **Commas should always have a space after.**
```r
      iris[1:100,-5],
                 ^
```


> ... einen Teil der Überarbeitungen und Änderungen können wir ja auch wieder ins Buch übernehmen!?
Ja! Können wir uns mal merken für nach dem EAP-Release. @JohannesHoppe


TeamCity LabKey :: LabkeyRelease15.3 :: CDS postgres 9.4 [Build 143](https://teamcity.labkey.org/viewLog.html?buildId=301338&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 8 (1 new), passed: 42 Build time: 01:30:44
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisFilter: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

```


```
else{
   count++;
}
```


missing dots for Javadoc


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14657](https://teamcity.mesosphere.io/viewLog.html?buildId=126950&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:03:58


initial commit


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14656](https://teamcity.mesosphere.io/viewLog.html?buildId=126949&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:04:53


Octree (DeadParrot) - Win64-Windows-7-VisualStudio-12: OK (2069 of 2069 tests passed, 3 test warnings)

 * 6 tests had: AUD diffs.
 * 2 tests had: EIO diffs.
 * 2 tests had: ESO small diffs.
 * 1 test had: SHD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14658](https://teamcity.mesosphere.io/viewLog.html?buildId=126951&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 222 Build time: 00:03:48


How are you going to determine cost values for our SoC? They aren't exactly the same as bullhead, I think they may have gotten them from some QCOM stuff


Let's be a little more careful with this string replacement. We should only replace "s3://" with "s3a://", at the beginning of the string. A cleaner approach might be to always parse the URI, check for the "s3" scheme, and then if it matches, reconstruct it with the exhaustive `URI` constructor: `URI("s3a", uri.getUserInfo(), uri.getHost(), uri.getPort(), uri.getPath(), uri.getQuery(), uri.getFragment())`


not required


release-5.x (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (397 of 397 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@alex Imi cer scuze,nu incarcasem o solutie corecta. Am confundat sursele.


Needs a higher performance algorithm


113107773-Improve-waste-heat-function-handling-of-AirloopHVACUnitarySystem-#5222 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1524 of 1524 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I'm starting to head down this path, and started looking at these commits.
I'm curious about this commit, as if CT_SYS_GCC is gcc, one can assume that the c++ is g++. Likewise if it is clang, then the c++ is clang++. This seems to add extra complexity.


Oh yes, of course! Thanks.


I was thinking something like:

`diff --git a/scripts/crosstool-NG.sh.in b/scripts/crosstool-NG.sh.in
index 9297e3b..8a253c9 100644
--- a/scripts/crosstool-NG.sh.in
+++ b/scripts/crosstool-NG.sh.in
@@ -232,6 +232,13 @@ CT_SYS_OS=$(uname -s)
 CT_SYS_MACHINE=$(uname -m)
 CT_SYS_PROCESSOR=$(uname -p)
 CT_SYS_GCC=$(gcc -dumpversion)
+if gcc --version 2>&1 | grep ^gcc; then
+    export CT_SYS_GCC_TYPE='gcc'
+elif gcc --version 2>&1 | grep clang; then
+    export CT_SYS_GCC_TYPE='clang'
+else
+    CT_Abort "Your build system\'s gcc is not gcc or clang, so it is unsupported!"
+fi
 CT_SYS_TARGET=$(CT_DoConfigGuess)
 CT_TOOLCHAIN_ID="crosstool-${CT_VERSION} build ${CT_STAR_DATE_HUMAN} by ${CT_SYS_USER}@${CT_SYS_HOSTNAME}"

`


This didn't actually fix the issue....

http://www.mergely.com/editor?key=%27;alert(1);var%20blah%20=%20%27

htmlspecialchars ONLY encodes single quotes when ENT_QUOTES is set.

> '&' (ampersand) becomes '&'
> '"' (double quote) becomes '"' when ENT_NOQUOTES is not set.
> "'" (single quote) becomes ''' (or ') only when ENT_QUOTES is set.
> '<' (less than) becomes '<'
> '>' (greater than) becomes '>'

http://php.net/manual/en/function.htmlspecialchars.php

This method may be better?
http://php.net/manual/en/function.htmlentities.php


mudança sutil kkkk


Ah I'll add a comment as well, but it's because it's not defined anywhere but linux.


113107773-Improve-waste-heat-function-handling-of-AirloopHVACUnitarySystem-#5222 (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Falei Márcio!


There seems to be a problem with that commit. UnitTests dont compile and run

 public void WhileWritingWhenTextIsBoldItalicUnderlineItShouldReadTheProperFormatting()
public void WhileReadingWhenTextIsBoldItalicUnderlineItShouldReadTheProperFormatting()

Severity	Code	Description	Project	File	Line	Suppression State
Error	CS1503	Argument 1: cannot convert from 'bool?' to 'bool'	UnitTests	C:\Projects-GitHub\DocX\UnitTests\DocXUnitTests.cs	2031	Active

8 errors. seems you have changed bool to bool? in Formatting.cs which breaks it.


Was removed because had to add the same line


That's it, thank you. I have the redirection working, but what's the point of working at something that can't be merged?


[inst/doc/caretEnsemble-intro.R:14:28:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/inst/doc/caretEnsemble-intro.R#L14) *style:* **Commas should always have a space after.**
```r
training <- Sonar[ inTrain,]
                           ^
```
[inst/doc/caretEnsemble-intro.R:15:27:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/inst/doc/caretEnsemble-intro.R#L15) *style:* **Commas should always have a space after.**
```r
testing <- Sonar[-inTrain,]
                          ^
```
[inst/doc/caretEnsemble-intro.R:70:14:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/inst/doc/caretEnsemble-intro.R#L70) *style:* **Trailing whitespace is superfluous.**
```r
  model_list,
             ^
```
[inst/doc/caretEnsemble-intro.R:82:51:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/inst/doc/caretEnsemble-intro.R#L82) *style:* **Commas should always have a space after.**
```r
model_preds <- lapply(model_preds, function(x) x[,"M"])
                                                  ^
```
[inst/doc/caretEnsemble-intro.R:136:1:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/inst/doc/caretEnsemble-intro.R#L136) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/caretEnsemble.R:145:76:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/R/caretEnsemble.R#L145) *style:* **Commas should always have a space after.**
```r
    tmp.t <- out[attributes(out)$dimnames[[nams[[i]]]] == as.character(bt[,nams[i]])]
                                                                           ^
```
[R/caretEnsemble.R:192:38:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/R/caretEnsemble.R#L192) *style:* **Commas should always have a space after.**
```r
  dat <- dat[order(dat[["overall"]]),]
                                     ^
```
[R/caretEnsemble.R:200:33:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/R/caretEnsemble.R#L200) *style:* **Commas should always have a space after.**
```r
  x$importance <- x$importance[,"Overall", drop=FALSE]
                                ^
```
[R/caretEnsemble.R:213:36:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/R/caretEnsemble.R#L213) *style:* **Commas should always have a space after.**
```r
  dat$model <- sub("\\.[^\n]*", "",dat$id)
                                   ^
```
[R/caretEnsemble.R:223:26:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/R/caretEnsemble.R#L223) *style:* **Commas should always have a space after.**
```r
  row.names(dat) <- dat[,1]
                         ^
```
[R/caretEnsemble.R:224:15:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/R/caretEnsemble.R#L224) *style:* **Commas should always have a space after.**
```r
  return(dat[,-1])
              ^
```
[R/caretList.R:268:69:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/R/caretList.R#L268) *style:* **Commas should always have a space after.**
```r
        caret::predict.train(x, type="prob", newdata=newdata, ...)[,2]
                                                                    ^
```
[R/helper_functions.R:15:30:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/R/helper_functions.R#L15) *style:* **Commas should always have a space after.**
```r
    xWbar <- weighted.mean(x,w,na.rm=na.rm)
                             ^
```
[R/helper_functions.R:15:32:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/R/helper_functions.R#L15) *style:* **Commas should always have a space after.**
```r
    xWbar <- weighted.mean(x,w,na.rm=na.rm)
                               ^
```
[R/helper_functions.R:63:78:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/R/helper_functions.R#L63) *style:* **Commas should always have a space after.**
```r
    probModels <- sapply(list_of_models, function(x) modelLookup(x$method)[1,"probModel"])
                                                                             ^
```
[R/helper_functions.R:177:12:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/R/helper_functions.R#L177) *style:* **Commas should always have a space after.**
```r
  b <- b[a,]
           ^
```
[R/helper_functions.R:245:87:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/R/helper_functions.R#L245) *style:* **Commas should always have a space after.**
```r
    set(modelLibrary, i=good_pos_values, j="pred", value=modelLibrary[good_pos_values,positive,with=FALSE])
                                                                                ^
```
[R/helper_functions.R:245:96:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/R/helper_functions.R#L245) *style:* **Commas should always have a space after.**
```r
    set(modelLibrary, i=good_pos_values, j="pred", value=modelLibrary[good_pos_values,positive,with=FALSE])
                                                                                ^
```
[R/helper_functions.R:256:67:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/R/helper_functions.R#L256) *style:* **Commas should always have a space after.**
```r
  return(list(obs=modelLibrary$obs, preds=as.matrix(modelLibrary[,model_names,with=FALSE]), type=type))
                                                                  ^
```
[R/helper_functions.R:256:79:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/R/helper_functions.R#L256) *style:* **Commas should always have a space after.**
```r
  return(list(obs=modelLibrary$obs, preds=as.matrix(modelLibrary[,model_names,with=FALSE]), type=type))
                                                                              ^
```
[tests/testthat/test-caretList.R:62:41:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L62) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,1:4], iris[,5]), iris[,5])
                                        ^
```
[tests/testthat/test-caretList.R:62:53:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L62) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,1:4], iris[,5]), iris[,5])
                                                    ^
```
[tests/testthat/test-caretList.R:62:64:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L62) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,1:4], iris[,5]), iris[,5])
                                                               ^
```
[tests/testthat/test-caretList.R:63:41:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L63) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,2:5], iris[,1]), iris[,1])
                                        ^
```
[tests/testthat/test-caretList.R:63:53:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L63) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,2:5], iris[,1]), iris[,1])
                                                    ^
```
[tests/testthat/test-caretList.R:63:64:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L63) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(iris[,2:5], iris[,1]), iris[,1])
                                                               ^
```
[tests/testthat/test-caretList.R:64:61:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L64) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(Species ~ ., iris), iris[,"Species"])
                                                            ^
```
[tests/testthat/test-caretList.R:65:65:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L65) *style:* **Commas should always have a space after.**
```r
  expect_equal(extractCaretTarget(Sepal.Width ~ ., iris), iris[,"Sepal.Width"])
                                                                ^
```
[tests/testthat/test-caretList.R:86:36:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L86) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control))
                                   ^
```
[tests/testthat/test-caretList.R:86:48:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L86) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control))
                                               ^
```
[tests/testthat/test-caretList.R:87:36:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L87) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control))
                                   ^
```
[tests/testthat/test-caretList.R:87:48:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L87) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control))
                                               ^
```
[tests/testthat/test-caretList.R:88:36:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L88) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control, continue_on_fail=TRUE))
                                   ^
```
[tests/testthat/test-caretList.R:88:48:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L88) *style:* **Commas should always have a space after.**
```r
      expect_error(caretList(iris[,1:4], iris[,5], tuneList=bad_bad, trControl=my_control, continue_on_fail=TRUE))
                                               ^
```
[tests/testthat/test-caretList.R:89:33:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L89) *style:* **Commas should always have a space after.**
```r
      expect_is(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control, continue_on_fail=TRUE), "caretList")
                                ^
```
[tests/testthat/test-caretList.R:89:45:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L89) *style:* **Commas should always have a space after.**
```r
      expect_is(caretList(iris[,1:4], iris[,5], tuneList=good_bad, trControl=my_control, continue_on_fail=TRUE), "caretList")
                                            ^
```
[tests/testthat/test-caretList.R:100:13:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L100) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
            ^
```
[tests/testthat/test-caretList.R:100:25:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L100) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
                        ^
```
[tests/testthat/test-caretList.R:113:17:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L113) *style:* **Commas should always have a space after.**
```r
  expect_is(p1[,1], "character")
                ^
```
[tests/testthat/test-caretList.R:114:17:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L114) *style:* **Commas should always have a space after.**
```r
  expect_is(p1[,2], "character")
                ^
```
[tests/testthat/test-caretList.R:117:17:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L117) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,1], "character")
                ^
```
[tests/testthat/test-caretList.R:118:17:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L118) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,2], "character")
                ^
```
[tests/testthat/test-caretList.R:121:17:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L121) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,1], "character")
                ^
```
[tests/testthat/test-caretList.R:122:17:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L122) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,2], "character")
                ^
```
[tests/testthat/test-caretList.R:127:13:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L127) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
            ^
```
[tests/testthat/test-caretList.R:127:25:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L127) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
                        ^
```
[tests/testthat/test-caretList.R:136:17:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L136) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,1], "numeric")
                ^
```
[tests/testthat/test-caretList.R:137:17:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L137) *style:* **Commas should always have a space after.**
```r
  expect_is(p2[,2], "numeric")
                ^
```
[tests/testthat/test-caretList.R:139:17:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L139) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,1], "numeric")
                ^
```
[tests/testthat/test-caretList.R:140:17:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L140) *style:* **Commas should always have a space after.**
```r
  expect_is(p3[,2], "numeric")
                ^
```
[tests/testthat/test-caretList.R:160:17:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L160) *style:* **Commas should always have a space after.**
```r
      x = iris[,1:3],
                ^
```
[tests/testthat/test-caretList.R:161:17:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L161) *style:* **Commas should always have a space after.**
```r
      y = iris[,4],
                ^
```
[tests/testthat/test-caretList.R:205:23:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L205) *style:* **Commas should always have a space after.**
```r
            x = iris[,1:3],
                      ^
```
[tests/testthat/test-caretList.R:206:23:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L206) *style:* **Commas should always have a space after.**
```r
            y = iris[,4],
                      ^
```
[tests/testthat/test-caretList.R:332:18:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L332) *style:* **Commas should never have a space before.**
```r
      y = train[ , "Class"],
                ~^
```
[tests/testthat/test-caretList.R:448:37:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L448) *style:* **Commas should always have a space after.**
```r
      tuneGrid=data.frame(.cp=c(.01,.001,.1,1))
                                    ^
```
[tests/testthat/test-caretList.R:448:42:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L448) *style:* **Commas should always have a space after.**
```r
      tuneGrid=data.frame(.cp=c(.01,.001,.1,1))
                                         ^
```
[tests/testthat/test-caretList.R:448:45:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L448) *style:* **Commas should always have a space after.**
```r
      tuneGrid=data.frame(.cp=c(.01,.001,.1,1))
                                            ^
```
[tests/testthat/test-caretList.R:519:14:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L519) *style:* **Commas should always have a space after.**
```r
  x <- iris[,1:3]
             ^
```
[tests/testthat/test-caretList.R:520:14:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-caretList.R#L520) *style:* **Commas should always have a space after.**
```r
  y <- iris[,4]
             ^
```
[tests/testthat/test-ensembleMethods.R:200:40:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensembleMethods.R#L200) *style:* **Commas should always have a space after.**
```r
  mr1 <- mr1[order(mr1$method, mr1$id),]
                                       ^
```
[tests/testthat/test-ensembleMethods.R:201:40:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensembleMethods.R#L201) *style:* **Commas should always have a space after.**
```r
  mr2 <- mr2[order(mr2$method, mr2$id),]
                                       ^
```
[tests/testthat/test-ensembleMethods.R:220:70:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensembleMethods.R#L220) *style:* **Commas should always have a space after.**
```r
  expect_equal(mr_reg_long[order(mr_reg_long$method, mr_reg_long$id),"resid"], mr2[order(mr2$method, mr2$id),"resid"])
                                                                     ^
```
[tests/testthat/test-ensembleMethods.R:220:110:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensembleMethods.R#L220) *style:* **Commas should always have a space after.**
```r
  expect_equal(mr_reg_long[order(mr_reg_long$method, mr_reg_long$id),"resid"], mr2[order(mr2$method, mr2$id),"resid"])
                                                                                ^
```
[tests/testthat/test-ensembleMethods.R:281:20:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensembleMethods.R#L281) *style:* **Commas should always have a space after.**
```r
        se=tests[i,"se"],
                   ^
```
[tests/testthat/test-ensembleMethods.R:282:32:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensembleMethods.R#L282) *style:* **Commas should always have a space after.**
```r
        return_weights=tests[i,"return_weights"]
                               ^
```
[tests/testthat/test-ensembleMethods.R:286:16:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensembleMethods.R#L286) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"se"]){
               ^
```
[tests/testthat/test-ensembleMethods.R:294:16:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensembleMethods.R#L294) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"return_weights"]){
               ^
```
[tests/testthat/test-ensembleMethods.R:309:20:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensembleMethods.R#L309) *style:* **Commas should always have a space after.**
```r
        se=tests[i,"se"],
                   ^
```
[tests/testthat/test-ensembleMethods.R:310:32:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensembleMethods.R#L310) *style:* **Commas should always have a space after.**
```r
        return_weights=tests[i,"return_weights"],
                               ^
```
[tests/testthat/test-ensembleMethods.R:315:16:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensembleMethods.R#L315) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"se"]){
               ^
```
[tests/testthat/test-ensembleMethods.R:323:16:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensembleMethods.R#L323) *style:* **Commas should always have a space after.**
```r
    if(tests[i,"return_weights"]){
               ^
```
[tests/testthat/test-ensemble.R:28:11:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensemble.R#L28) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
          ^
```
[tests/testthat/test-ensemble.R:28:23:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensemble.R#L28) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
                      ^
```
[tests/testthat/test-ensemble.R:56:11:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensemble.R#L56) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
          ^
```
[tests/testthat/test-ensemble.R:56:23:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-ensemble.R#L56) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], iris[,3], method="lm",
                      ^
```
[tests/testthat/test-helper_functions.R:28:13:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-helper_functions.R#L28) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
            ^
```
[tests/testthat/test-helper_functions.R:28:25:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-helper_functions.R#L28) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], iris[,5],
                        ^
```
[tests/testthat/test-helper_functions.R:37:13:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-helper_functions.R#L37) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
            ^
```
[tests/testthat/test-helper_functions.R:37:39:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-helper_functions.R#L37) *style:* **Commas should always have a space after.**
```r
      iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
                                      ^
```
[tests/testthat/test-helper_functions.R:43:11:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-helper_functions.R#L43) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
          ^
```
[tests/testthat/test-helper_functions.R:43:37:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-helper_functions.R#L43) *style:* **Commas should always have a space after.**
```r
    iris[,1:2], factor(ifelse(iris[,5]=="setosa", "Yes", "No")),
                                    ^
```
[tests/testthat/test-helper_functions.R:151:93:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-helper_functions.R#L151) *style:* **Commas should always have a space after.**
```r
  modelLibrary$nn <- modelLibrary$lm[sample(1:nrow(modelLibrary$lm), nrow(modelLibrary$lm)),]
                                                                                ^
```
[tests/testthat/test-helper_functions.R:185:18:](https://github.com/zachmayer/caretEnsemble/blob/a868d923d6e05df388ae24741558bb81c8fea961/tests/testthat/test-helper_functions.R#L185) *style:* **Commas should always have a space after.**
```r
      iris[1:100,-5],
                 ^
```


@jedesah Just pushed a commit that addresses this


This looks great! I'm actually happy to see us bailing early in a couple more places, before testing the subtype relationship - that might actually address some other problems.


Confirmed, latest commit fixed it. Thanks!


right now, it is not possible to invoke CorfuServer -m without also -s


niiiceee


Seems to work but I keep getting the following message when I try to re-clone the database:

> Do you really want to continue? (y/n): y
devel defines the following permissions: access devel information, execute php code, switch users

The if statement is always executed. Devel status is returning "not installed" but it is already enabled.

 passthru('drush pm-info devel');
`if (isset($modules->devel) && $modules->devel->status !== 'Enabled') {
 +    // This time let's just passthru() to run the drush command so the command output prints to the workflow log.
 +    passthru('drush pm-enable -y devel');
    }`

Oddly, I ran the same command via Terminus and the module status is set to enabled.

> Extension        :  devel
 Project          :  devel
 Type             :  module
 Title            :  Devel
 Description      :  Various blocks, pages, and functions for developers.
 Version          :  7.x-1.5
 Date             :  2014-05-02
 Package          :  Development
 Core             :  7.x
 PHP              :  5.2.4
 Status           :  enabled

Am I missing something? I'm a bit confused. Any feedback is appreciated.

Thanks,
Ruby


@brothermechanic , я тут между делом пытаюсь **stuff** привести в подобающий вид.
есть еще некоторое количество пакетов, в которых ты мейнтейнером числишься (если верить `grepу`).
будешь их поддерживать?