Should we just remove this test, or is there a reason to leave it commented out?


どこがガイドラインの文脈とずれてますか？


I agree - the fact that we happen to funnel multiple sensors through a Teensy (separately) should not affect how they are treated in the code beyond the minimum low-level separation of their data streams.


添田です。
nullと空文字「""」は別物です。空文字を判定してほしいのではなく、nullを判定してください。


@nabedge テーストー


Hi, and Direct3D 10.0? It is always confusing.
> A reasonably modern graphics card (Direct3D 10.0...)

Sorry, I do not have an account on bug.dolphin.


添田です。
3人分の情報をバラバラで処理するのではなく、一括で処理できるようにしてください。


> Basically this discussion is about the Robustness Principle, which states "Be conservative in what you do, be liberal in what you accept from others". This principle originated in protocol design, where following it helps facilitate extensibility: if you allow any value for a field in a packet, then later versions of the protocol can use that field without breaking backwards compatibility.
>
> If we try to apply this principle to programming language design, we get Javascript (without linters). The reason we use linters is the reason why the robustness principle is ill-advised here: flexibility creates complexity and complexity creates bugs (see here https://www.destroyallsoftware.com/talks/wat).

I actually agree with that, but I would say that a config option is more analogous to a protocol than a programming language. Config options are the external interface between your orchestration infrastructure and the application. Config options will be passed to the ledger Docker container by users who aren't five-bells-ledger developers and may not even be programmers at all. You should think of them more as users and use UX principles. I would be much more favorable towards restrictiveness if we were talking about something that internal to the ledger codebase that only five-bells-ledger developers would ever come in contact with.

I guess that's exactly what the Robustness Principle advocates for. Forgiving on the outside and strict on the inside. Makes a lot of sense to me.

> I think everyone would agree that it takes more code to check for 4 literals than 2. In this simple case it isn't a big deal, but if we were to follow the principle of extending flexibility maximally to all non-ambiguous cases, we would be forced to also accept ...

Come on, that's an [appeal to extremes](http://www.logicallyfallacious.com/index.php/logical-fallacies/30-appeal-to-extremes). Nobody is arguing to add support for ✓.

> Making things as strict as possible minimizes the amount of special cases and alternate code paths, which reduces cyclomatic complexity and code size, ultimately increasing productivity.

Explain how this change adds any special cases or alternate code paths. I understand you're trying to argue about a principle, but principles always stand in conflict with one another. The art is in weighing them in the specific instance. In the case of linting, you may well be right to be more strict. In this case here I'm pretty sure I'm right for the reasons discussed in this thread. :)


#blameAnt


Глобальные переменные - зло :-)


I wanted to customise the signup route as well to be `/signup` instead of `users/sign_up`, but to achieve that, you need to also skip the `registrations` routes and redefine them all yourself which is cumbersome, error prone and probably not safe in the long term as devise gets updates :disappointed:


Hmm, is your /bin/sh bash?


You can always use whatever options you want in advanced output. These are just presets.


#5 resolvd


В JS тоже есть ловкие методы типа map filter, можно примерно так написать этот код this.taglist = tags().map(function(tag) {return tag.name;}) Вот тут дока https://developer.mozilla.org/ru/docs/Web/JavaScript/Reference/Global_Objects/Array/map (MDN на мой взгляд лучшее место чтобы найти доку по фронтовой фиче какой-нибудь js или css)


Все ок


添田です。
判定してほしいのは、空文字「""」ではなくnullです。なので、配列にはnullを入れて、nullを判定する様に変更してください。


Oh, I misunderstood. Thank you.


there was another patch that would take in to account a configured scheme:

    return (opts.redirect_uri_scheme and opts.redirect_uri_scheme or ngx.var.scheme).."://"..ngx.var.http_host..opts.redirect_uri_path

if you could merge that in to your PR so that all options are supported (configuration overrides `X-Forward-Proto` overrides `ngx.var.scheme`) I'll merge; thanks


Лучше экспортить сам класс а не инстанс


ResponseBody зря удалил :)


dsfsdfsfdfs


Not the one here but the one in `EventLogSpecLeveldb` :-)


hello world


Oren,

`_reader.ReadToEnd()` creates a new `StringBuilder` instance each time and appends characters to it, but each `StringBuilder` instance has its own buffer.

That's why I preferred to stay with a single buffer created on our own.


Read


`dash`.
IT or someone set this up.


I have learned how to do this!


Is it necessary have the "-u" argument in init script?
It should be controlled by user in /etc/default/shadowsocks


https://github.com/nixzhu/MonkeyKing/) with the native


I'll fix it as well, meta-angstrom should be shell agnostic.


添田です。
課題と処理があって無いですね。関数を20回呼ぶ処理を書いて下さい。


TestCustomCommand (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (977 of 977 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-28.31%25-green.svg)


thank you.


The separation of data streams would be pre-RoboRIO (or somewhere in the FPGA, pre-WPILib at worst).


Is `glibc` a hard dependency? Why is it there?
(I'm porting to ARM)


DB 수정 후 PUSH CONTROLLER 수정


Ah right, wrong line :smiley:


添田です。
基本、課題5がベースになるので、IDも返却してください。


I recommend we use the changelog to update our progress going forward. Could serve both historical and troubleshooting value in the future.


Получатеся, что мы показываем фотографии, у который дата создания меньше, чем 3.02.2016, то есть старые фотографии. А должно быть наоборот.


Give 2ed9904 a try


If you're meaning the text in the readme, yeah, I suppose it could be confusing.

The requirements are a card that supports the 10_0 feature level, with the D3D11 API. Most D3D10-level cards have D3D11 drivers, even though they don't support the 11_0 feature level.


Похоже, что эта ошибка тут давно. Проглядел ;(


Never mind, saw the whole thread now and that's because of dns `search` didn't work earlier...
Now it does (I think) gliderlabs/docker-alpine#8


Actually I was planning to use this `BlittableJsonTraverser` (name could be more expressive) in `IncludeUtil` (not to use `IncludeUtil` instead), since this code is more general - just returns objects for given path, while `IncludeUtil` also transforms them into collection of string identifiers.


Octree (DeadParrot) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


添田です。
結果は問題ないですが、$numという引数（数字が入っている）ものへ、文字列を上書きするのはあまり良くないですね。
動作としては問題ないですが、考え方として問題があります。


@johnsimons  Is it work add a comment as to why that's an empty array.  If I was looking over the code outside the context of this PR I would have thought it was a mistake


The C makes something like:
sessionid = cluster_get_sessionid();
route = strchr(sessionid, '.')
route++;


fixed issue #5


ReferenceError: base is not defined

...grid = $.jgrid, jqID = jgrid.jqID, getGuiStyles = base.getGuiStyles, getGridRes ...

grid.custom.js (line 29, col 45)


添田です。
ちょっと違いますね。trueの場合に実行してほしいのは、掛け算の結果を2乗する事です。


Ireally like the idea of adding articles, but I think it needs more than just the models before I can make a decision. After all, Rails is all about MVC working together, not just the M portion in isolation. If the views and controller are in working order, then I'll pull this into my project


The `persistOnEvent` Java API is still missing.


添田です。
計算対象は、global変数で関数の呼び出し回数をstaticで指示しています。
global変数を使ってください。


zheshishenmegui


Hope my code will be more succinct,more wonderful.


Right


Are you sure it isn't source.HasBuff("XenZhaoComboTarget"), too?


Reverted in 177c02380d523e88f5fd9cc4f4a8c15092730329 and customised differently in 2e834cb4427ab3b40abf96f034fb399a9a25022e.


> Cool, it should already work with a dummy camera over IB, right?

That case (as visualized by Timo) is already covered under Linux by Kiro and the patched UcaDevice TANGO server.


at least we get this fixed?


Adicione data e o link ro seu github no cabeçalho.


If we already have a string value (`value != null`) when there is no need to create `LazyStringReader`.


Same problem here. My db is already set to varchar(191) on my test site.
Shall we not not make a conditional to the series of ALTER TABLE for future updates (from 3.5.0 to 3.5.1)?


![bridgefrom bottom](https://cloud.githubusercontent.com/assets/1422350/13102209/fc0ee5e8-d500-11e5-949d-b1750542a58f.jpeg)


I miss the old aniket


bridge


Could you explain this change? I'm not sure if this is required in order to support the construct keyword.


urgs. I wonder whether that really 'means' the same. the nonmember listing looks at the table and finds the non-members where there is a '0' (zero), a '' (empty string), or \epsilon (None/nothing) in the membership_accepted column. all that for historic reasons. (merge process with different data sets)

So  "membership_accepted != None" would be matched/satisfied by "membership_accepted == 1", which means "is member", right? but we are looking for nenmembers here...

I'll check the test cases...


fixed in https://github.com/gregorio-project/gregorio/commit/b50aa98af399bf0e4091f43bb675c6ecab788622


The Scala version had to have various Java conversions in it, which really messed the code up.  Now, the only explicit Java types used are for the regex support, and that's internal.

Migration should be possible via search and replace of
`be.objectify.deadbolt.core.models.` => `be.objectify.deadbolt.java.models.`
`be.objectify.deadbolt.core.PatternType` => `be;objectify.deadbolt.java.models.PatternType`
`be.objectify.deadbolt.core.utils.TemplateUtils` => `be;objectify.deadbolt.java.utils.TemplateUtils`

Updated documentation in the readme of the master branch is going in today, to help avoid further issues like https://github.com/schaloner/deadbolt-2/issues/69


Thank you for the PR!  I'll review it.


Right, you already provided the magic :)


just some formating, haha, looks like Geppetto likes it this way oO


See: http://eslint.org/docs/user-guide/configuring#configuration-file-formats


@ecoron would you mind editing the compiling scripts here to php7 7.0.2 - https://github.com/ImagicalMine/php-build-scripts/blob/master/compile.sh
And to ImagicalMine of course :)


@neutrinog Does auto-backup use a different naming convention than manual backup? It seems that auto-backup will always generate/overwrite a single file with '-backup' inserted prior to the extension.

Is this functionality that is ultimately replaced by GOGS?


This script was written for the Devuan system ( https://devuan.org/ ) which uses zsh as their default shell.


Even if you get some oscillations, this need not to be bad. For example, if a parameter oscillates between 15 and 25 you can take an average (20) instead of the final value. Maybe also to allow larger interval:
SideAdjustment[0][0],0,-32,32,2,0.02


Shouldn't we also assert it replied to the right one?


Why is this function [called recursively](https://ocaml.org/learn/tutorials/if_statements_loops_and_recursion.html "OCaml tutorial: If Statements, Loops and Recursion")?
Will [a while loop](https://en.wikipedia.org/wiki/While_loop "Description for the usage of while loops") be clearer and safer in this use case?


FD


please dont introduce new non-POSIX things here, just check with e.g. [ -e "$file" ] || break


Hi, I am using C-driver to interface one application with mongolab but i am getting error that

>  Failed to authenticate Credentials

this is my code.
```
const char* String_uri = "mongodb://<username>:<pwd>@ds011115.mongolab.com:11115/tempdb";

    uri = mongoc_uri_new(String_uri);
    client = mongoc_client_new_from_uri (uri);

   collection = mongoc_client_get_collection (client, "mydb", "mycoll");
   doc = bson_new_from_json ((const uint8_t *)"{\"hello\" : \"world\"}", -1, &error);

   count = mongoc_collection_count (collection, MONGOC_QUERY_NONE, doc, 0, 0, NULL, &error);

   if (count < 0) {
      fprintf (stderr, "%s\n", error.message);
   } else {
      printf ("%" PRId64 "\n", count);
   }
```
I am wondering whether i can connect to the mongolab using C-driver or not? I read on mongolab website that they supports all drivers. Also i am using C-driver version 1.0.0. Any hints or example from where i can start. I already succeesully integrated java driver and also connected mongolab via console but C-drivers are not working. Thanks


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `bears/python/RadonBear.py`, line 12.*

The issue can be fixed by applying the following patch:

```diff
--- a/bears/python/RadonBear.py
+++ b/bears/python/RadonBear.py
@@ -10,6 +10,7 @@

 class RadonBear(LocalBear):
+
     def run(self, filename, file,
             radon_ranks_info: typed_list(str)=(),
             radon_ranks_normal: typed_list(str)=('C', 'D'),
```


mismatches


hello~world


I need to check the order of calculation. However, I think this is not possible in these fast games.


Resolved conflict


I agree the usage of `CreateField` in index definition forces us to clear existing fields. Is a missing field in a document the same case? Shouldn't we store it as NULL_VALUE then to be consistent with index definition?


So thank you very informative and applied
www.e-mobl.com


I'm fine with the source code, but for the commit message: "the VppInputAsync did added", maybe typo? should be "the VppInputAsync DIDN'T added"?


this


param(
[string] $configFile,
[string] $ScriptRootP,
[string] $HomeDirectoryP,
[string] $UserName,
[string] $Domain,
[string] $Password
)
#BlastItAll Version 1.1 - Inclusion of additional paramaters to pass to SQL Scripts
Function Get-PSCredential($User,$Password)
{
 $SecPass = convertto-securestring -asplaintext -string $Password -force
 $Creds = new-object System.Management.Automation.PSCredential -argumentlist $User,$SecPass
 Return $Creds
}

try {
#Copy-Item $ScriptRootP\VsoAgentService.exe.config $HomeDirectoryP\agent -force -Recurse

write-verbose "Starting deployment at $(get-date)"  -Verbose

write-verbose "$ScriptRootP\$configFile $(get-date)"  -Verbose

    #Import Configuration XML

   [xml]$ConfigXML = Get-Content "$ScriptRootP\$configFile"

      # Run MSI Deployment
      $usernameD= $Domain+"\"+$UserName #$Command.domain+"\"+$Command.user
       $password=$Password #$command.password
    foreach ($Command in $ConfigXML.DeployConfiguration.MSI.Deployment.Command)
    {
     write-verbose "MSI Deployment Script Start at $(get-date)" -Verbose
        $VarArray = @()

        foreach ($Param in $Command.Parameter) {
            $ParameterName = $Param.ParameterName.Trim()
            $ParameterValueF = $Param.ParameterValue.Trim()
            $ParameterValue = """$ParameterValueF"""
            $ParameterDec = "$ParameterName=$ParameterValue"
            $VarArray += $ParameterDec
        }

       $CommandName = $Command.CommandName
       $WorkingFolder = $Command.WorkingFolder
       $Server=$Command.Server
       $MSIName=$Command.name
        write-verbose "MSI Deployment on $Server started $(get-date)" -Verbose
        write-verbose "MSI Deployment on $usernameD $(get-date)" -Verbose
        #write-verbose "MSI Deployment on $password $(get-date)" -Verbose
        $fileNameLog=$CommandName -replace ".msi"
        write-verbose "$fileNameLog" -Verbose
        $FullWorkingFolder = "$ScriptRootP\$WorkingFolder"
        $logPath="c:\Users\$UserName\AppData\Local\Temp\$fileNameLog"+"_Log.txt"

         write-verbose "$logPath" -Verbose
        cd $FullWorkingFolder

        $Arguments="/q  $VarArray   /qn /l $logPath"

       # Start-Process -FilePath $FullWorkingFolder\$CommandName -ArgumentList  $Arguments -Wait
        #Copy-Item $ScriptRootP\$WorkingFolder\$CommandName  \\$Server\c$\temp\ -force -Recurse

        $sourceFolder="$ScriptRootP\$WorkingFolder\$CommandName"
        write-verbose "$sourceFolder" -Verbose

        $RootdestinationFolder="\\$Server\C$\Users\$UserName\AppData\Local\Temp"
        write-verbose " $RootdestinationFolder" -Verbose
        $pass=$Password|ConvertTo-SecureString -AsPlainText -Force
        $Cred = New-Object System.Management.Automation.PsCredential($usernameD,$pass)
        New-PSDrive -name RMO -Root $RootdestinationFolder -Credential $cred -PSProvider filesystem
        Copy-Item -Path $sourceFolder  -Destination "RMO:\" -force -Recurse
        Remove-PSDrive RMO

        $credential = Get-PSCredential -User $usernameD -Password $password
        $session = New-PSSession -ComputerName $Server -credential $credential
        Invoke-Command -Session $session -ScriptBlock {
        param(
        $CommandName,$Arguments,$Server,$MSIName,$UserName
    )
        write-verbose "MSI Deployment on $Server start process  $(get-date)" -Verbose

        $r = Get-WmiObject Win32_Product | Where {$_.Name -match $MSIName }
        if ($r -ne $null) {
        write-verbose "$MSIName MSI alreday install on $Server  $(get-date)" -Verbose
        $r.Uninstall()
        write-verbose "$MSIName MSI uninstall on $Server  $(get-date)" -Verbose
        }
        else
        {
        write-verbose "$MSIName MSI is not install on $Server  $(get-date)" -Verbose
        }
        write-verbose "MSI c:\Users\$UserName\AppData\Local\Temp\$CommandName installation started  $(get-date)" -Verbose
        Start-Process -FilePath c:\Users\$UserName\AppData\Local\Temp\$CommandName -ArgumentList  $Arguments -Wait
         write-verbose "MSI Deployment on $Server end process  $(get-date)" -Verbose     } -argumentlist $CommandName, $Arguments,$Server,$MSIName,$UserName
        Remove-PSSession  $session

         write-verbose "MSI Deployment on $Server Completed $(get-date)" -Verbose

    }

}

Catch
{
    write-verbose "Ended with error at $(get-date) with error $_.Exception.Message" -Verbose
    throw "Ended with error at $(get-date) with error $_.Exception.Message"
}

write-verbose "Completed deployment at $(get-date)"  -Verbose


Electric-Service-Refactor (EnergyArchmage) - i386-Windows-7-VisualStudio-12: OK (2081 of 2090 tests passed, 545 test warnings)

 * 550 tests had: AUD diffs.
 * 480 tests had: RDD diffs.
 * 3 tests had: ESO small diffs.
 * 7 tests had: MDD diffs.
 * 7 tests had: MTD diffs.
 * 3 tests had: EIO diffs.
 * 4 tests had: ERR diffs.
 * 5 tests had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 4 tests had: Table big diffs.
 * 1 test had: SHD diffs.
 * 1 test had: SSZ big diffs.
 * 1 test had: ZSZ big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.57%25-yellow.svg)


It looks much better this way :-)


You fixed it already :)

I was just going to push a fix (after testing for a few days), when I realized that it was already fixed, when syncing my fork.


Forgot to mention: added seedable pseudo-random number generator, to always create the same events on the same places.


fdznsry


Aye haye :p


:scream: that's what happens when I push directly to master...


Stupid question - why do we need to separate those two steps?
Would it be possible to get that header here directly from the message (context.Message.Headers)?
Is there anything else (e.g. in Core) that relies on that address to be stored in the context?


Файл добавил с целью пересмотреть зависимости. Возможно, его лучше было в Gist залить.


:+1: . I'll fix it


`key()` and `value()` are less clear than `getLeft()` and `getRight()` because they obscure the symmetry and imply some sort of `Map`.


Hi, yes I can do, will check it out if I find some time.


The operations are exposed per bus (I2CBus interface). The pending handle could be private to the implementation.


dbus-python: Ezt megcsinálom a szépség kedvéért, a többit meg a chroot kiakadás miatt kell megnézni, hisz ugyi phonon már nincs, nekik meg kellne. Eddig.


No, recommended is libvirt, please fix :)


Pls give me a log with the newest version (and run domoticz with -verbose 2)


Этот файл добавил с целью показать, что у меня rbenv не ставит ruby 2.3.0. И спросить можно ли это решить как-нибудь. Опять же, лучше было в Gist залить, наверное.


Same about `key()` and `value()` for `Pair`s.


Obvious my comment is wrong, it should say 1978!!!!


There must be a typo in the method: When_in_transaction_scope_add_should_to_commit_until_scope_is_complete

To is Not?


pls write to : https://github.com/domoticz/domoticz/pull/490#issuecomment-184896903


taner.temelt@gmail.com

:)


这样不好。


I have no more comments or questions ;)


*An array


It is not good to put secret in public! Instead it should be taken from properties file with production settings.


:muscle: :muscle:


Could you avoid code duplication between `leftCigar` and `rightCigar` by passing a simple `LEFT / RIGHT` enum argument to a single `leftOrRightCigar` method?


fail over -> default


:+1: makse sense. I'll run it through ATs and push the new version.


So thank you very informative and applied
www.e-mobl.com


Not good at all to put secret keys into public observation!


Fixed in 6003cd4c168b40887f9962fb0eb9f3d5b48039f3


Why are we not relying on NHibernate to generate an ID?


This is a very odd way of doing this...

why not just:

if isinstance(value, bytes):
    value = value.decode('ascii')


Yes, mariadb stopped working because there was no more memory available. I got this error "msg: error creating database: (1047, 'WSREP has not yet prepared node for application use')."


Do not put secret data into publicly available code!


there is no testcase for nonmember_listing_count in test_models.py :-/


Note on line 90: I didn't touch it, used GitHub to edit and make PR


I think it's really critical to keep this subform model as simple as possible because each additional class / interface doubles or triples the number of cases to test for. I will fork your branch today with  a few suggestions on how to keep the model simpler.


s/atleast/at least/


Just a habit of writing braces. Do you need me to remove them?


s/tolerations ,/tolerations, /


diff --git a/src/main/java/com/l2jserver/gameserver/ai/L2AttackableAI.java b/src/main/java/com/l2jserver/gameserver/ai/L2AttackableAI.java
index 6c69e65..62bb5e2 100644
--- a/src/main/java/com/l2jserver/gameserver/ai/L2AttackableAI.java
+++ b/src/main/java/com/l2jserver/gameserver/ai/L2AttackableAI.java
@@ -1796,7 +1796,8 @@
 		double dist = 0;
 		double dist2 = 0;
 		int range = 0;
-		if (getAttackTarget() == null)
+		final L2Character target = getAttackTarget();
+		if (target == null)
 		{
 			return;
 		}
@@ -1804,12 +1805,12 @@
 		{
 			if (npc.getTarget() == null)
 			{
-				npc.setTarget(getAttackTarget());
+				npc.setTarget(target);
 			}
-			dist = npc.calculateDistance(getAttackTarget(), false, false);
+			dist = npc.calculateDistance(target, false, false);
 			dist2 = dist - npc.getTemplate().getCollisionRadius();
-			range = npc.getPhysicalAttackRange() + npc.getTemplate().getCollisionRadius() + getAttackTarget().getTemplate().getCollisionRadius();
-			if (getAttackTarget().isMoving())
+			range = npc.getPhysicalAttackRange() + npc.getTemplate().getCollisionRadius() + target.getTemplate().getCollisionRadius();
+			if (target.isMoving())
 			{
 				dist = dist - 30;
 				if (npc.isMoving())
@@ -1824,19 +1825,19 @@
 				// -------------------------------------------------------------
 				// Try to stop the target or disable the target as priority
 				int random = Rnd.get(100);
-				if (!getAttackTarget().isImmobilized() && (random < 2))
+				if (!target.isImmobilized() && (random < 2))
 				{
 					for (Skill sk : npc.getTemplate().getAISkills(AISkillScope.IMMOBILIZE))
 					{
-						if (!checkSkillCastConditions(npc, sk) || (((sk.getCastRange() + npc.getTemplate().getCollisionRadius() + getAttackTarget().getTemplate().getCollisionRadius()) <= dist2) && !canAura(sk)))
+						if (!checkSkillCastConditions(npc, sk) || (((sk.getCastRange() + npc.getTemplate().getCollisionRadius() + target.getTemplate().getCollisionRadius()) <= dist2) && !canAura(sk)))
 						{
 							continue;
 						}
-						if (!GeoData.getInstance().canSeeTarget(npc, getAttackTarget()))
+						if (!GeoData.getInstance().canSeeTarget(npc, target))
 						{
 							continue;
 						}
-						if (!getAttackTarget().isAffectedBySkill(sk.getId()))
+						if (!target.isAffectedBySkill(sk.getId()))
 						{
 							clientStopMoving(null);
 							// L2Object target = getAttackTarget();
@@ -1853,15 +1854,15 @@
 				{
 					for (Skill sk : npc.getTemplate().getAISkills(AISkillScope.COT))
 					{
-						if (!checkSkillCastConditions(npc, sk) || (((sk.getCastRange() + npc.getTemplate().getCollisionRadius() + getAttackTarget().getTemplate().getCollisionRadius()) <= dist2) && !canAura(sk)))
+						if (!checkSkillCastConditions(npc, sk) || (((sk.getCastRange() + npc.getTemplate().getCollisionRadius() + target.getTemplate().getCollisionRadius()) <= dist2) && !canAura(sk)))
 						{
 							continue;
 						}
-						if (!GeoData.getInstance().canSeeTarget(npc, getAttackTarget()))
+						if (!GeoData.getInstance().canSeeTarget(npc, target))
 						{
 							continue;
 						}
-						if (!getAttackTarget().isAffectedBySkill(sk.getId()))
+						if (!target.isAffectedBySkill(sk.getId()))
 						{
 							clientStopMoving(null);
 							// L2Object target = getAttackTarget();
@@ -1877,15 +1878,15 @@
 				{
 					for (Skill sk : npc.getTemplate().getAISkills(AISkillScope.DEBUFF))
 					{
-						if (!checkSkillCastConditions(npc, sk) || (((sk.getCastRange() + npc.getTemplate().getCollisionRadius() + getAttackTarget().getTemplate().getCollisionRadius()) <= dist2) && !canAura(sk)))
+						if (!checkSkillCastConditions(npc, sk) || (((sk.getCastRange() + npc.getTemplate().getCollisionRadius() + target.getTemplate().getCollisionRadius()) <= dist2) && !canAura(sk)))
 						{
 							continue;
 						}
-						if (!GeoData.getInstance().canSeeTarget(npc, getAttackTarget()))
+						if (!GeoData.getInstance().canSeeTarget(npc, target))
 						{
 							continue;
 						}
-						if (!getAttackTarget().isAffectedBySkill(sk.getId()))
+						if (!target.isAffectedBySkill(sk.getId()))
 						{
 							clientStopMoving(null);
 							// L2Object target = getAttackTarget();
@@ -1902,15 +1903,15 @@
 				{
 					for (Skill sk : npc.getTemplate().getAISkills(AISkillScope.NEGATIVE))
 					{
-						if (!checkSkillCastConditions(npc, sk) || (((sk.getCastRange() + npc.getTemplate().getCollisionRadius() + getAttackTarget().getTemplate().getCollisionRadius()) <= dist2) && !canAura(sk)))
+						if (!checkSkillCastConditions(npc, sk) || (((sk.getCastRange() + npc.getTemplate().getCollisionRadius() + target.getTemplate().getCollisionRadius()) <= dist2) && !canAura(sk)))
 						{
 							continue;
 						}
-						if (!GeoData.getInstance().canSeeTarget(npc, getAttackTarget()))
+						if (!GeoData.getInstance().canSeeTarget(npc, target))
 						{
 							continue;
 						}
-						if (getAttackTarget().getEffectList().getFirstEffect(L2EffectType.BUFF) != null)
+						if (target.getEffectList().getFirstEffect(L2EffectType.BUFF) != null)
 						{
 							clientStopMoving(null);
 							// L2Object target = getAttackTarget();
@@ -1927,11 +1928,11 @@
 				{
 					for (Skill sk : npc.getTemplate().getAISkills(AISkillScope.ATTACK))
 					{
-						if (!checkSkillCastConditions(npc, sk) || (((sk.getCastRange() + npc.getTemplate().getCollisionRadius() + getAttackTarget().getTemplate().getCollisionRadius()) <= dist2) && !canAura(sk)))
+						if (!checkSkillCastConditions(npc, sk) || (((sk.getCastRange() + npc.getTemplate().getCollisionRadius() + target.getTemplate().getCollisionRadius()) <= dist2) && !canAura(sk)))
 						{
 							continue;
 						}
-						if (!GeoData.getInstance().canSeeTarget(npc, getAttackTarget()))
+						if (!GeoData.getInstance().canSeeTarget(npc, target))
 						{
 							continue;
 						}
@@ -1984,9 +1985,9 @@
 			// return;
 			// }

-			if ((dist > range) || !GeoData.getInstance().canSeeTarget(npc, getAttackTarget()))
+			if ((dist > range) || !GeoData.getInstance().canSeeTarget(npc, target))
 			{
-				if (getAttackTarget().isMoving())
+				if (target.isMoving())
 				{
 					range -= 100;
 				}
@@ -1994,13 +1995,13 @@
 				{
 					range = 5;
 				}
-				moveToPawn(getAttackTarget(), range);
+				moveToPawn(target, range);
 				return;

 			}

 			// Attacks target
-			_actor.doAttack(getAttackTarget());
+			_actor.doAttack(target);
 		}
 		catch (NullPointerException e)
 		{


s


Вот, пишу я! ;-) Что надо?


https://github.com/sindresorhus/log-update ;)


ISC


This is going to throw an `IllegalArgumentException` for chimeric read pairs, but this could legitimately occur in the case of translocations.  Are such pairs filtered somewhere upstream of this code?


добрый день нужно обновить апликашку отрада тв, добавит видеотеку
17 февр. 2016 г. 9:37 пользователь "Jo2003" <notifications@github.com>
написал:

> Вот, пишу я! ;-) Что надо?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Jo2003/jo2003.github.io/commit/68acbe1c79f3fd9f8c45062c26faac566ec01a8d#commitcomment-16139306>
> .
>


how change hexagon per row i want 6-5 hexagon per row


LGTM


should move to compat.py @hbmartin ?


![histogram of steps per day](https://cloud.githubusercontent.com/assets/9391910/13102935/e939e49a-d58c-11e5-8f5d-7473bad0b21f.png)


![average daily activity pattern](https://cloud.githubusercontent.com/assets/9391910/13102942/f42cb6ac-d58c-11e5-8af8-23ac72eb9e1a.png)


redundant whitespace


![histogram of steps per day including missing values](https://cloud.githubusercontent.com/assets/9391910/13102950/fc4a8f8a-d58c-11e5-8275-cd295dcdddb5.png)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16084](https://teamcity.mesosphere.io/viewLog.html?buildId=137229&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:09:12


I don't have much opinion, just thought that you might.  Max seems a little better than min to me.


Thank you! I sent the email.


What can be done also is that the controller just acts as a dispatcher, so instead of using an around callback, you just have something that returns the correct service object type, then update looks like:

```ruby
def update
  service = service_class.new(self, assessment: assessment, submission: submission)
  service.update
  extract_instance_variables(service)
end
```

So the service does not know about the controller.


TestCustomCommand (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1529 of 1529 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.7%25-green.svg)


TestCustomCommand (jasondegraw) - x86_64-Linux-Ubuntu-14.04-custom_check: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg)


@alexmv  Within a stable release , the above should maybe not changed. But for the next release, I think the css class should be the (lower?) object class, which would make the above map obsolete.


fghaas, I am wondering how to use 'str_replace' here because these ip addresses are not the attributes of the heat template here.


阿里大规模图像搜索大赛/bfmatch.py

haitao


![weekday and weekend difference](https://cloud.githubusercontent.com/assets/9391910/13103008/6d807af2-d58d-11e5-8060-cfbf9e54de7b.png)


Why this preg_replace is needed here?  I think that preg_split  + trim is more relevent in this case(or explode +trim).


Honestly, i didn't tried to run tests on python 2.7, I will try to do that and see if it is possible to adjust changes so that they do not brake python 2.7. Sorry for being lazy.

In python 3 if file is opened in `r` mode, file content is interpreted as text. From what I understand textract internally process all data in binary form? So that's why I changed that, to make it consistent. And since Python 3 is more strict about text vs binary, if file is opened in text mode it fails in many places, where text is mixed with binary.


Okay, give it a comment in that case.


In that case, we want it explicit, not hidden in the expression


it does not seem to work


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16085](https://teamcity.mesosphere.io/viewLog.html?buildId=137230&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:01


No, a missing field isn't the same as null value.
And at any rate. Consider the case where you have documents with arrays of different sizes?


:warning: l'indentation c'est 2 espaces. Soit vous utilisez un éditeur de texte valable, soit vous apprenez à vous en servir.


iOS


Yes, that is fine with me. I just don't want to have 2 impl.

*Hibernating Rhinos Ltd  *

Oren Eini* l CEO l *Mobile: + 972-52-548-6969

Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811

On Wed, Feb 17, 2016 at 8:49 AM, Arkadiusz Paliński <
notifications@github.com> wrote:

> Actually I was planning to use this BlittableJsonTraverser (name could be
> more expressive) in IncludeUtil (not to use IncludeUtil instead), since
> this code is more general - just returns objects for given path, while
> IncludeUtil also transforms them into collection of string identifiers.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ppekrol/ravendb/commit/0183def19973514ec211770b3fe9d7b4a0120a88#commitcomment-16138781>
> .
>


啊啊啊


Then do that with a string buffer directly.
Your code was using value.Size there, which is the size of bytes, but was
trying to use them as the size of characters.
This would fail for unicode text.

*Hibernating Rhinos Ltd  *

Oren Eini* l CEO l *Mobile: + 972-52-548-6969

Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811

On Wed, Feb 17, 2016 at 8:41 AM, Arkadiusz Paliński <
notifications@github.com> wrote:

> Oren,
>
> _reader.ReadToEnd() creates a new StringBuilder instance each time and
> appends characters to it, but each StringBuilder instance has its own
> buffer.
>
> That's why I preferred to stay with a single buffer created on our own.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ayende/ravendb/commit/f55814a2c2839993c7f25918c4a573652500a017#commitcomment-16138706>
> .
>


`import base` in Python 3 is a global import, since tests are run from project root, and `tests/` is not in `sys.path`, `base` can't be imported. Changing it to relative import (supported both by Python 2 and 3) fixed the issue.


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `bears/natural_language/MarkdownBear.py`, line 50.*

The issue can be fixed by applying the following patch:

```diff
--- a/bears/natural_language/MarkdownBear.py
+++ b/bears/natural_language/MarkdownBear.py
@@ -47,7 +47,7 @@
             "incrementListMarker": markdown_list_increment,    # Bool
             "rule": markdown_horizontal_rule,                  # - or * or _
             "ruleSpaces": markdown_horizontal_rule_spaces,     # Bool
-            "ruleRepetition": markdown_horizontal_rule_repeat, # int
+            "ruleRepetition": markdown_horizontal_rule_repeat,  # int
         }
         config_json = json.dumps(self.remark_configs)
         # Remove { and } (remark adds it on its own) and escape it
```


粗心了点哦。


I don't believe this is an ideal solution as we can't be certain a UIImageView will only ever ask once initially for the image.
Regardless the code in the if block will never execute as superViewAsk will always be false.


No such thing as UNITY_4 define. See: https://github.com/EsotericSoftware/spine-runtimes/commit/1d030bb88f3f3f92e61afe18289aa6d01d557750#commitcomment-16136145


Okay, so I will clear them each time we do the conversion.


Sure.


@sartak Count should be at least a global config option, maybe better a user config option.


ddjj


The following is super complex and smelly:

```
using (var session = await OpenSession(context).ConfigureAwait(false))
{
    session.Session().
    await session.CompleteAsync().ConfigureAwait(false);
}
```

So session is not an NHibernate object its a different session to then retrieve the NHibernate session.

I also don't know why ` await session.CompleteAsync().ConfigureAwait(false);` is needed.

In my opinion this should be restructured.


So hard to read this line, may be better split it to 2 lines:
- concatenation,
- addslashes.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1565 of 1565 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


just remove the error return if we don't use it anymore, it's not exported function, so we can change the API
line 140-144 need to be clean too


Why do we even *have* nested row version columns? That is a really bad design to have. All version checking should be done on the aggregate root.


Remove the third argument.


ini drf to om??


See #268


Давайте через мейл: olenka.joerg@gmail.com
Детали надо.


Thanks, Quintin.
Sorry this took some time to merge - we had no good way to test stuff. Now that we have proper CI, we can get started merging PRs like these.

In this case, there's two challenges that need to be addressed before we can pull it:
* I18n should cover the entire project (right now the pager and the non-template strings are missing)
* We need to actually test the localization (especially special characters).

If you don't have the time for those, no action from your side is required at this point - I'll address all of those issues. (along with i10n for Dutch and German).


For the record: At this point there don't seem to be any focus issues with or without this attribute being set


Alors faudra venir m'expliquer pourquoi sur mon éditeur c'est deux espaces et pas sur github


Just on question what's the reason for the downgrade?


I'm not sure what you mean. I tried removing the ``>`` and got a syntax error.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


the following seems to work:

printf("%*c%s", _exm_indent, ' ', name);


Just realized that it probably needs to be on one line without the ``>``, but does it help with the output somehow?


Whats different?


Unfortunately Python 3 does not honour `b` flag and in case of `'-'` even if `b` is specified file handler is `sys.stdio` which is opened in text mode, but it should be `sys.stdio.buffer` which is in binary mode.

Again, sorry for being lazy, I will run tests with Python 2.7 and will find a way to make it work on both pythons.

I explained [earlier](https://github.com/sirex/textract/commit/e24ae5f5acfea8f86c887640f65dca2b397b3601#commitcomment-16139442), why I'm changing all places with text processing to binary mode. Let me know, if you think, that files being processed should be opened text mode.


lol surprised this typo lasted for so long...


My optimization game is too strong


Do you mean this `StringBuffer`:
https://github.com/ayende/ravendb/blob/v4.0/Imports/Newtonsoft.Json/Src/Newtonsoft.Json/Utilities/StringBuffer.cs ?


The installation script is on 7.0.2, so it's better for everything to be on that :)


- Missing the configuration test
- We need it to be numeric value, that controls how many documents to load


We should validate the input files, thank you!
I think it's all right that symlink or block device as parameters. It can be merged if it's a valid parquet file. And if ParquetFileReader can't read the input, it will throw exception.


>$next = $block->getLevel()->getBlock($block->add(1));
                if(!in_array($next, $processed)) $queue[] = $next;

                $next = $block->getLevel()->getBlock($block->add(-1));
                if(!in_array($next, $processed)) $queue[] = $next;

                $next = $block->getLevel()->getBlock($block->add(0, 1));
                if(!in_array($next, $processed)) $queue[] = $next;

                $next = $block->getLevel()->getBlock($block->add(0, -1));
                if(!in_array($next, $processed)) $queue[] = $next;

                $next = $block->getLevel()->getBlock($block->add(0, 0, 1));
                if(!in_array($next, $processed)) $queue[] = $next;

                $next = $block->getLevel()->getBlock($block->add(0, 0, -1));
                if(!in_array($next, $processed)) $queue[] = $next;
                $processed[] = $block;

This is a nightmare to convert to Java(Nukkit), can you please help?


Yes, I'm sorry :(


No, literally just use a string builder on your own

*Hibernating Rhinos Ltd  *

Oren Eini* l CEO l *Mobile: + 972-52-548-6969

Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811

On Wed, Feb 17, 2016 at 10:01 AM, Arkadiusz Paliński <
notifications@github.com> wrote:

> Do you mean this StringBuffer:
>
> https://github.com/ayende/ravendb/blob/v4.0/Imports/Newtonsoft.Json/Src/Newtonsoft.Json/Utilities/StringBuffer.cs
> ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ayende/ravendb/commit/f55814a2c2839993c7f25918c4a573652500a017#commitcomment-16139666>
> .
>


            $next = $block->getLevel()->getBlock($block->add(1));
            if(!in_array($next, $processed)) $queue[] = $next;

            $next = $block->getLevel()->getBlock($block->add(-1));
            if(!in_array($next, $processed)) $queue[] = $next;

            $next = $block->getLevel()->getBlock($block->add(0, 1));
            if(!in_array($next, $processed)) $queue[] = $next;

            $next = $block->getLevel()->getBlock($block->add(0, -1));
            if(!in_array($next, $processed)) $queue[] = $next;

            $next = $block->getLevel()->getBlock($block->add(0, 0, 1));
            if(!in_array($next, $processed)) $queue[] = $next;

            $next = $block->getLevel()->getBlock($block->add(0, 0, -1));
            if(!in_array($next, $processed)) $queue[] = $next;
            $processed[] = $block;
This is a nightmare to convert to Java(Nukkit), can you please help?


sorry my english, i've meant some kind of roadmap for features. For example:
support AMF files - spring 2016
getting rid of protobuf - summer 2016
....
taking control of Universe - winter 2020


Here I changed ambiguous absolute import to relative. In Python 3 these ambiguous relative imports are no longer supported. Python 2 and 3 pythons support explicit relative imports. See the [PEP-0328](https://www.python.org/dev/peps/pep-0328/) explanation:

> Imports can be ambiguous in the face of packages; within a package, it's not clear whether import foo refers to a module within the package or some module outside the package. (More precisely, a local module or package can shadow another hanging directly off `sys.path`.)


ok, thanks


This fixes #248


Name : Rakesh Dhananjaya.


What does this do?


@guddo this permission is already setted for administrator https://github.com/easySuite/ding2/blob/0cf7a24e8679d7077e81e4944fbf1198e451e44e/modules/ding_permissions/ding_permissions.module#L465


IIRC, there's no logic to support nil/empty tolerations match all taints.


From https://docs.oracle.com/javase/8/docs/api/java/net/HttpURLConnection.html : "Calling the close() methods on the InputStream or OutputStream of an HttpURLConnection after a request may free network resources associated with this instance but has no effect on any shared persistent connection. Calling the disconnect() method may close the underlying socket if a persistent connection is otherwise idle at that time. "

So I think we probably should close the streams if we decide not to invoke `disconnect`.


If the `patterns` variable is a string, it converts it into a list with 1 element.

This is so that I do not have to do a if condition for the for loop below


ref https://github.com/kubernetes/kubernetes/pull/18263#issuecomment-168844915


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/settings/ConfigurationGathering.py`, line 180.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/settings/ConfigurationGathering.py
+++ b/coalib/settings/ConfigurationGathering.py
@@ -177,7 +177,7 @@
         file_path)))
     old_dir = None
     base_dir = (file_path if os.path.isdir(file_path)
-                          else os.path.dirname(file_path))
+                else os.path.dirname(file_path))
     home_dir = os.path.expanduser("~")

     while base_dir != old_dir and old_dir != home_dir and max_trials != 0:
```


We are opening index here and we do not know anything about it yet (e.g. name). This exception to be honest is more like 'should not happen' (ever).


Note that this commit is over a year old.  At the time. it was meant as a work-in-progress commit, the first in a sreies that would hopefully eventually go in that direction.  As it, it at least allows extensions to potentially insert themselves into the list.

Though, IIRC, that didn't quite work as-is for Assets (which was an extension at the time); I don't recall the details, but I believe it to have been related to JS load order or such.


What does _iter_alternatives(pattern) do?


It doesn't strictly speaking prevents pooling, on android it means the connection is put back to the pool, but of course this library isn't used on android only.


Yes, my fault.


It is. The change makes sure the regex above matches at a word boundary, e.g. it matches `something class`, but would not match `somethingclass`.

Without this change `construct set` is interpreted as a struct definition, producing three separate tokens:

* `con` - no special formatting
* `struct` - the struct keyword
* `get` - this gets now interpreted as the structs name

A fun fact is, that the Github code formatting does just the same mistake, look at this:

```Vala
public string my_property { get; construct set; }
```

Note how construct is broken apart, and the set keyword is formatted differently from the get.


@Redridge Im not sure myself (it was there earlier)
My commit simply allows `fnmatch` to take in a list.
Earlier it could only take in a string - with this commit it can take in a list and tests whether the name matches any of these pattern


This will fail on MSVC with "signed to unsigned comparison"


Prefer single-quoted strings when you don't need string interpolation or special symbols.


Uses `this.throw` from koa context (there are sample in TeamPlay)


same


You need to clean up here.

If you have changed the directory, you need it to go back to the old one - as other codes may be affected


**This file contains unused source code.**
*PyUnusedCodeBear, severity 1, section `python`.* *Related to file `bears/vcs/git/GitCommitBear.py`, line 3.*

The issue can be fixed by applying the following patch:

```diff
--- a/bears/vcs/git/GitCommitBear.py
+++ b/bears/vcs/git/GitCommitBear.py
@@ -1,6 +1,5 @@
 import shutil
 import os
-import re

 from coalib.bears.GlobalBear import GlobalBear
 from coalib.misc.Shell import run_shell_command
```


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `bears/tests/vcs/git/GitCommitBearTest.py`, line 165.*

The issue can be fixed by applying the following patch:

```diff
--- a/bears/tests/vcs/git/GitCommitBearTest.py
+++ b/bears/tests/vcs/git/GitCommitBearTest.py
@@ -162,7 +162,7 @@
         # when section does
         self.section.append(Setting("config", self.gitdir))
         self.run_uut()
-        self.assertEqual(get_config_directory(self.section),self.gitdir)
+        self.assertEqual(get_config_directory(self.section), self.gitdir)
         raise AssertionError("new "+os.getcwd() + " old " + old)
         os.rmdir(no_git_dir)
         os.chdir(self.gitdir)
```


Missing error checking


done


Just wondering if you forgot to remove this debug code...


ack https://github.com/coala-analyzer/coala/commit/2d6576e1c5260e30059d914433bfcb2767057318


Why have different code paths for partition_num==1 and >1?
Change it to always use the new queue interface.


This is awesome! Thanks!


You're right, that's my mistake. Pylint complained about the "= None" and demanded "is None" which then led to errors in SQLAlchemy. When changing back I accidentally made it "!= None" instead of "= None". Thanks for checking! At least we found a coverage issue. ;)

Am 17. Februar 2016 08:01:15 MEZ, schrieb AnneGilles <notifications@github.com>:
>urgs. I wonder whether that really 'means' the same. the nonmember
>listing looks at the table and finds the non-members where there is a
>'0' (zero), a '' (empty string), or \epsilon (None/nothing) in the
>membership_accepted column. all that for historic reasons. (merge
>process with different data sets)
>
>So  "membership_accepted != None" would be matched/satisfied by
>"membership_accepted == 1", which means "is member", right? but we are
>looking for nenmembers here...
>
>I'll check the test cases...
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/C3S/c3sMembership/commit/148fbc2190e8fb8f9a852fa8d83138fb17599c56#commitcomment-16138878


Update usage printout


Fix: hide the <body> scroll bar


wa kaka


Cool!


You forgot to aded spells

Id: 51089
Name: Fetch Burning Ice
Id: 53153
Name: Fetch Ghoul Drool
Id: 53158
Name: Fetch Blight Crystal
Id: 53153
Name: Fetch Ghoul Drool

Total missed 4 spells fot quest...


`CookieDough` works a little weird way.
`new CookieDough(arg)` is for server and
`CookieDough()` is for browser. But this would occur es-lint warning.
To fix it, we have to change cookie management module to another one, or add es-lint disable comment. :joy:


can't confirm this line (results in -4), did you mean `'5' - x + x`?


Thanks :+1:


Out of scope of this PR. I only fixed the name so that the test does not go *boom!*.


You seem to be right, I also get `-4`, but `'5' - x + x` results in `5` for me (which is correct). Maybe this isn't a WAT after all.

cc @0x04


@AByzhynar see b47b912


@AByzhynar see again b47b912


@priyank-gupta - just a nitpicking - but in specs we should avoid "should" :) to be better aligned with the new RSpec syntax, let's revert it to the previous one


No idea why.


Same for the PHP version. Your code doesn't need PHP >=5.5


Why??


Hello @chrisgui. Hard to say exactly, somehow depends on our review process and priorities of other tickets, but probably in one of the next releases.
There is also another related ticket - http://dev.ckeditor.com/ticket/14391 and I suppose it will be the best if this two tickets will be delivered together because they cover similar cases, so its deliveries may be dependent.
I will keep you informed on this.


Hey Zach. Without providing concrete suggestions to improve your code, I'd like you to think about what kind of "objects" a calculator consists of.
Look at this math equation:

`(4 + 10) * 20 = 280`

What kind of objects do you see there?


Perhaps have it still work downwards if the entity is looking at least 45 degrees down? (also re-normalize the vector so it doesn't apparently-randomly send you less than the full distance)


@AByzhynar  see eb541f40016562236af78c6bb611bdc766b00c1d


@AByzhynar  see b47b912


And why is nobody thinking about official PocketMine?


为什么这是红的？


please use $(shell) and active export of parameters in order to work around command line length limitations on windows et al.


Good idea.


We're reusing the storage session abstraction here in order to not repeat the code that is here: https://github.com/Particular/NServiceBus.NHibernate/blob/develop/src/NServiceBus.NHibernate/SynchronizedStorage/NHibernateSynchronizedStorageAdapter.cs#L35.

I think there is more value in having that "connection magic" code in one place compared to the slight overhead of doing `.Session().Session`.


Yeah, if that was the case, it was unintentional. But I thought this had been updated at least once?


We agreed that for all new methods added we use `OVERRIDE` instead of `virtual`


I may have found the solution:

Change
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/sql/updates/mysql/3.5.0-2015-07-01.sql#L86

to
ALTER TABLE `#__menu` MODIFY `alias` varchar(400) CHARACTER SET utf8mb4 COLLATE utf8mb4_bin NOT NULL DEFAULT '' COMMENT 'The SEF alias of the menu item.';


@mokulawa 意思是这一行是被删除了。
原来有->现在没：红色
原来没->现在有：绿色


see I  delete a line here


That looks good. Can I merge?


OK


Got it, I amended this for the pull-request.


@iammerrick it's probably better to be in shape of issue ;)


Ok, understood, thanks for the clarification, and indeed, GitHub does the same too, I have seen that even before you have pointed out.


- [ ] 「共通フレームワーク」という用語はありません。「フレームワークスタック」に置き換えて文書を組み立ててほしいです。（ここだけでなく、このセクションの冒頭の文章なども）


Nothing :) Most user prefer to use just Bond so I removed this.


An operator * has grouping from left to right (like most operators), and so XScale * ply is calculated first, after which a conversion to double is happened. I'll check later with writing an output too.


Note that this assumes that the abundances are given with respect to the first collider in the file.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (997 of 997 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-28.67%25-green.svg)


it iterates over alternatives, i.e. if you have a glob like `*.(c|h)` it'll iterate over `*.c` and `*.h`


This will need an alternative expected output file for the --disable-orca case.

Or could we write the query so that it works with or without ORCA? Something like:

select count_operator('explain select bfv_subquery_t1.i, (select bfv_subquery_t1.i from bfv_subquery_t2) from bfv_subquery_t1;', 'Table Scan') > 0 OR count_operator('explain select bfv_subquery_t1.i, (select bfv_subquery_t1.i from bfv_subquery_t2) from bfv_subquery_t1;', 'Seq Scan') > 0;

Probably best to refactor that to be more readble, allow count_operator to take multiple operators as argument, for example. Or replace count_operator() with a simpler function that returns the EXPLAIN output as text, and then use regexp_match in the query itself to count the operators. But the general idea is to treat "Table Scan" and "Seq Scan" the same.

Or is this also trying to ensure that ORCA doesn't fall back to the Postgres planner for this query? Accepting "Seq Scan" with optimizer=on would not catch that. I don't think we need to test for that here, I presume ORCA has its own tests for that kind of stuff, but what do you think?


Please try to be more precise with your commit messages.

http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
http://chris.beams.io/posts/git-commit/


J'ai beaucoup de taf en ce moment mais je regarde des que j'ai un temps


- [ ] 「共通フレームワーク」ではなく、「フレームワークスタック」という単語を使って文書を組み立ててください。


Hi George,
while I understand that this is formal violation of some rule I cannot see that your change makes any sense. Introducing a constant makes sense if you use the constant as a key in a map for example. In this case there is absolutely no risk that I "put" something with String A and try to "get" with String B. The "begin" for example is an attribute name and is defined by an external specification. Other constants are in debug message. What are you trying to prevent?
Accepting this pull request would make the code less readable and wouldn't add any value.
Beste Grüße,
Sebastian


in this case i would not place this into a new line, we are within a 100 character line length


only this?


@apv1313 this is a start. Need to be able to access these properties from the sub plugin easily, will need to augment `StandardPlayer` (or `PersistedObject`) to allow this


d


I am trying to rewrite this plugin for Nukkit, because it is faster and
better, and uses an identical API.
On Feb 17, 2016 12:19 AM, "legoboy0215" <notifications@github.com> wrote:

> Why??
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Falkirks/SimplePortals/commit/505dd594938add76f16d69278e9cf2b68e032e0c#commitcomment-16139962>
> .
>


This thing is extremely flaky. I had better luck just creating a Map with extensions (was a lot faster too).


[Data Analysis Question.zip](https://github.com/debjanigautam/R-programming/files/133898/Data.Analysis.Question.zip)


weibotan


For now, this is ok but keep in mind that this should trigger a warning sign in your head :) what if a user has 1000 blog posts?


बँधुवा


@Divjyot test?


बन्धुवा spelling mistake


@Divjyot if we replace the following:

 +    if(alMessage.groupId!=nil){
 +        groupID=alMessage.groupId;
 +    }
 +    else{
 +        groupID=nil;
 +    }

with just  groupID=alMessage.groupId;
Will it make any difference?


in general, the usage of `_path` helpers are recommended i think. you don't want to put the domain and port in every link. Relative links are fine (eg.: `posts_path`)


Requires: https://code.activestate.com/ppm/Data-Entropy/
`ppm install Data-Entropy`


also @Agajkowski


edit my blog


please use ruby 1.9 hash syntax for labels (`method: :delete`)


again, should be `%p{class: "warning callout"}`


नियम


sure - это квик дети прототип, если ты обратил внимание тут логин тест с паролем 123.


this code is not good, please optimize it.


Готов обсудить - невопрос ) В базовой ветке заранее заготовленной инфраструктуры про базу небыло. Я расчитывал что она появится и я в нее вклинюсь.


nice code !!!lol


the `form_for` should be a part of this partial. You don't have to provide all the details of the form (url, action, method), rails will infer those based on the model's state (eg.: does it saved or not)


Fixar sen :D


Cool! I was trying to figure this out earlier!


sure из конфига. В конфиг тем не менее хотелось бы уметь пробрасывать порт из переменной окружения, это довольно удобно, и в гугловом облаке например используется.


Icu már van, ami eddig kifelejtődött, még QtDBus.so is a csomagban, de a logban továbbra is ez van:

Checking to see if the dbus support module should be built...
The Python dbus module doesn't seem to be installed.

passz.


Если не против я бы про это потрепался :)


I think you need at least version `1.0.0` off `assert-diff` for this assertion to actually work. See https://www.npmjs.com/package/assert-diff#100-feb-18-2015


It isn't new method.


the `actionDomain` name should match a corresponding `@UriPath` option.


looking at this, there a bug here: you add `\gre@skip@temp@one` and then substract it


you may want to not store state on the endpoint, but create the client when creating a consumer / producer etc so the client is not reused.


should be fixed in git


almost the same here and in all other lines like this one


不知道~


I think the last part of this line is not needed...


yep, log files should be added for `.gitignore` ;)


Maybe offer this as a String type and just separate mutliple uris with a comma. This is easier from tooling and end user perspective as you just set one option.


hash syntax and commit message again


Erm måste fixa env också. Kan ju inte ha min api nyckel liggandes här.


I think we don't want to do that because then everybody could get excited
for a feature which we last minute decide not to do...
Op 17 feb. 2016 09:03 schreef "Renha" <notifications@github.com>:

> sorry my english, i've meant some kind of roadmap for features. For
> example:
> support AMF files - spring 2016
> getting rid of protobuf - summer 2016
> ....
> taking control of Universe - winter 2020
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Ultimaker/CuraEngine/commit/e177303c4bf3fe1cd357aa42a8418f9caab47591#commitcomment-16139718>
> .
>


For backward compat, better to have it at end of the param list (would not break existing positional call)


should you not set this as an exception on the exchange so we know it failed due the time out? Thee is an CamelTimedOutException you can use.


For 1) and 2) : possibly some code in the descriptor is machine-specific. Even if I don't see what, you just don't carry around 650+ LOC in multiple files, not because of binaries, but because code maintainance. If you change something, you need to make changes in multiple locations and this is not acceptable quality. Any SW quality measurement tool will show up those lines as duplicate code, and end up indicating what that is, bad quality coding due to duplications and poor choices.
If you really think that anything in there is machine-specific, your driver should have a lightweight API to set those parameters up per board, but otherwise I am sure > 95% of that is` common to any board that is capable to use USB gadget. PIN configuration is something, subsystem abstraction (on top of a generic interface) is someting else. PIN config should go in the machine specific file (as it is now).

3) The userspace does not need to know about the underlying configuration. Some boards might have 2 or more USBs, so what? Userspace uses abstractions of the devices created in userland, not the single devices. You can have some information in sysfs, showing, say, ttyACM0 is from port0 and eth usb0 is from port1, but definitely creating a fno per device is a waste of resources, since you are associating no device operations to that, and it does not make sense from the point of view of the abstraction. Entries in /dev/ dir are not for free, and reserved for those devices that actually use them, not for enumerations. Use sysfs if you need to count/configure objects.

4-5-6) The init has temporarly been forced back into late initialization, because machine_init happens way too early in the system, and:
- you really don't need USB peripherals to be initialized that early. In peripheral mode, the guest gives the timing
- cdc_ecm depends on the TCP/IP stack being initialized. The proposal is to split initialization in two parts, having the usb subsystem initialized at machine init time, and the pico side of ecm initialized later on. Anything else (calling a picotcp device creation before pico_stack_init) is UB.


aaaa


a


a bit overkill, but hey, it is your project :P


Would be nice to have explicit import (no `_` for coding conventions)


instead of keeping your own state, you can use isRunAllowed() from camel itself


Many of our developers are pushing to get Cura's issue tracker, which is currently behind a log-in, to open up to the public. But it doesn't look like it'll happen soon. They want to keep future features secret.

Taking control of the galaxy is planned for spring 2019 though. The rest of the universe will be a bit longer.


use getIn instead


please watch for the hash syntax, use the ruby 1.9 format: `class: "btn btn-default navbar-btn navbar-right"`


Si vous voulez utiliser l'environment.

```ruby
server 'srvz-webapp.he-arc.ch', user: ENV['USER'], roles: %w{app db web}
```

avec les containers docker, il faudra renommer votre utilisateur ruby avec `usermod`.


Great ! Sorry for the response time.


The BLOB should cater for all forms of npm-debug log.
i.e. `npm-debug.log*`

The `*` keyword above will cater for any suffix after any file with name that starts with `npm-debug.log`.


should you not have some code to removeListener also ?


Done, here and elsewhere, as part of https://github.com/seanlip/blockly/commit/63c40660b3479e181ab7f1fea60170d74338169d


I would suggest to merge this patch as it improves the flow reports with the current implementation adding a comment explaining this will be moved in another place when design will be discussed ? What about adding a Key() method to the flow.go  for the moment ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16086](https://teamcity.mesosphere.io/viewLog.html?buildId=137239&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:09:14


use getIn


**Code Quality - Nitpick**

Always endeavours to leave a new line between and ending closure and a new code block. I gave an example in the just resolved comment on this code block.


sorry, I didn't see `dimen` vs. `skip`. To be honest I liked my way of mapping temp variables to meaningful variables with `\let` that you killed in https://github.com/gregorio-project/gregorio/commit/3810a44d169ee7a9ef1dc08594bb5fb6f3417c4d , I think it makes things much clearer... but we'll discuss that later


Add `@Metadata(required = true)` as this option is required


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16087](https://teamcity.mesosphere.io/viewLog.html?buildId=137240&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:08:44


I guess the `channelClosed` even is fired consequently?


this might be a bit too generic. every stylesheets (even `statuses.scss`) will compile into one `application.css` so the files are just logical separations. This means that you will have these rules on every page hence you might run into trouble when you will accidentally have a `<div class="status"></div>` somewhere ;)


Why this change is included in "New Truffle Instrumentation API" commit and isn't separated in its own commit?


I don't think the caps are needed for this message


what is this needed for ?


用220.255那个ggc也是可以的
很多的谷歌域名直接访问出现403/404错误，很正常，加上参数就好了。但报其他错误则是不可以的。
404如：
    https://fonts.googleapis.com
    https://fonts.googleapis.com/css?family=Rokkitt


OK, than we can forget about it.
But feel free to use the alphabetical order when listing requires :P


- [ ] 細かいですが、表現を周辺の説明とあわせてほしい。


yep, add the log files to the `.gitignore` ;)


Да. Например, зачем классу Loger (который наверное все-таки Logger) вообще поле даты?
Что мешает timestamp полученный с помощью System.currentTimeMillis() сразу выдавать строку времени?
это идейно неверно, так как у логирования с датой нет ничего общего. методы getSmth() вообще не должны ничего менять.

А если не веришь, подумай, что произойдет если 2 потока одновременно его вызовут (а они по умолчанию спецификации должны быть threadSafe) и все другие классы (использующие рефлексию например) в этом уверены.


yeah, I think the Key() method in flow will do the job seamlessly


what do you think about adding this file to `.gitignore`?


Hi there,

I started with https://review.typo3.org/#/c/35470/ over a year ago (didn't pull this over to Github yet), if your approach works (mine never fully did as far as I remember) this would give us much better querying capabilities in the TYPO3CR also towards a fully generic content API with flexible queries.


why? :)


this line should be not indented


Don't get frustrated, your code is still there, except for the useless /dev/usbX and the descriptors that are now global.

I won't consider reverting these two things, because /dev/usbX is useless, low level USB devices have nothing to do with filesystem abstraction, and they, in fact, do nothing.

And once again, the whole content of `stm32f4_usbdef.h` (which we better just call `usbdef.h`) is describing abstractions that have nearly nothing to do with the underlying HW.
I am possibly failing to see exceptions to this, but do you want custom VID/PID, or different strings or ECM Mac address? Expose an interface to get custom ones from device definition headers, but no way our code should be as low in quality as copypasting around those definitions in five different places. That's a novice approach to quality, and again it's not about binary size, it's about code duplication indicators.


A generated token should last a while, 1h is too short.
A month should be ideal for a web app, and in the case where we have the application transcend on mobile devices, it shouldn't expire, however, it can be revoked.


// 载入外挂
var gulp = require('gulp'),
    less = require('gulp-less'),
    autoprefixer = require('gulp-autoprefixer'),
    minifycss = require('gulp-minify-css'),
    uglify = require('gulp-uglify'),
    imagemin = require('gulp-imagemin'),
    rename = require('gulp-rename'),
    clean = require('gulp-clean'),
    concat = require('gulp-concat'),
    notify = require('gulp-notify'),
    cache = require('gulp-cache'),
    livereload = require('gulp-livereload') ,
    plumber = require('gulp-plumber');

// 样式
gulp.task('styles', function() {
    return gulp.src('source/less/template.style.less')
    .pipe(less({ style: 'expanded', }))
    .pipe(autoprefixer('last 2 version', 'safari 5', 'ie 8', 'ie 9', 'opera 12.1', 'ios 6', 'android 4'))
    .pipe(gulp.dest('dist/css'))
    .pipe(rename({ suffix: '.min' }))
    .pipe(minifycss())
    .pipe(gulp.dest('template/css'))
    .pipe(notify({ // Add gulpif here
           title: 'less2css',
           subtitle: 'success',
           message: 'less task',
           sound: "Pop"
       }));
});

// 脚本
gulp.task('scripts', function() {
  return gulp.src('source/js/framework7/*.js')
    .pipe(concat('main.js'))
    .pipe(gulp.dest('dist/js'))
    .pipe(rename({ suffix: '.min' }))
    .pipe(gulp.dest('template/js'))
    .pipe(notify({ message: 'Scripts task complete' }));
});

// 图片
gulp.task('images', function() {
  return gulp.src('source/images/*')
    .pipe(cache(imagemin({ optimizationLevel: 3, progressive: true, interlaced: true })))
    .pipe(gulp.dest('dist/images'))
    .pipe(gulp.dest('template/images'))
    .pipe(notify({ message: 'Images task complete' }));
});

// 清理
gulp.task('clean', function() {
  return gulp.src(['dist/css', 'dist/js', 'dist/images'], {read: false})
    .pipe(clean());
});

// 看手
gulp.task('testwatch', function() {

  // 看守所有.less档
  gulp.watch('source/less/template.style.less', ['styles']);

  // 看守所有.js档
  gulp.watch('source/js/framework7/*.js', ['scripts']);

  // 看守所有图片档
  gulp.watch('source/images/*', ['images']);

  // 建立即时重整伺服器
  var server = livereload();

  // 看守所有位在 dist/  目录下的档案，一旦有更动，便进行重整
  gulp.watch(['dist/**']).on('change', function(file) {
    server.changed(file.path);
  });

});

// 预设任务
gulp.task('default', function() {
    gulp.start('testwatch');
});


Doesn't this require healthd updates??


i totally agree for clipboardjs


Log4J is already avail and configured in tests (in master). I prefer not to chance that along with these netty changes.


https://m.zhihu.com/question/30702208/answer/49104295
看该回答下的评论


update


We are setting twice the permission in this init function. It is also set here
https://github.com/maurizioabba/suricata/commit/0d272bac7f73c18217341cd9628051ee6ff45c94#diff-3bf3a0dac6ccf03f336cc9660c505d13R167

So we should merge both chmod.


Do we really need the executable bit to be set here ?


right


Would be useful to test the exception message, to be sure the error is the one expected


> it`s


1.8 seems better today


this indentation can be confusing, please indent these two lines more or consider leaving it as one line


Thread.current will lose data


@Zealar, I think that's exactly @Zoey76 tell us. :+1:


these build changes should be reverted


Agree, looks more tidy.


zz


Look nice, thanks


I reverted it back to 4 hours in a later commit but from your comment 24h is still too short?


What?


I did something similar to this, just used the OnMpKilled function server side to write to a table for death recording. What is spdlog? If I may ask...


24hrs I mean


Через E-Mail возможно?


On a side note, can you please have a more igienic use of git?
- pull only if you don't have local changes
- ensure that you are on latest HEAD before committing your modifications
- if you can't do the above, don't pull/merge after your commits! use fetch + rebase instead. pull is a shortcut for fetch+merge, which makes a mess of the commit history.

Thanks!


I tried running it again with Grails 3.0.11 and could not reproduce either. Please close this issue


j'essaie de faire ça ce matin


This is very usefull tool and great web work.
I hope someone picking up the torch.
thx for all


если ты это делал для себя то ладно, но лучше так не делай)


Be highly, highly careful here. When values.size == 0 you end up with MAX_UNSIGNED_INT


`
.footerSocial
  display: inline-flex
`


merci :+1:


вынести в отдельный файл


multiple small things:

- ```$copy_error``` could actually be any kind of exception from the `has`, `copy` or `delete` call
- we're losing the exception's stacktrace
- we're return "copying did not succeed" while in fact it may have been successful
- we usually try to avoid ```"some '$result' in string"``` and ```$result``` in this case is always a boolean iirc


Because they don't exists when loading the Event::Base class, it's the base class from all of the classes stated in the array ...


В целом структура конечно ужасна, надо созвонится, дабы обсудить дальнейший план работы


Rather than worrying about people who spill coffee, take a look at how you spell coffee...


Uploaded!


Thanks, will change it!


I think we're trying to get away from this style and just use `Props(new ActorImpl(...))`


hmm, damn it, you're right


Avec ça, vous devriez pouvoir versionner ce fichier-là.
```
server 'srvz-webapp.he-arc.ch', user: ENV['USER'], roles: %w{app db web}
```


- [ ] 単に「Spring Securityの仕様である」ではなく、「ひとつの`SecurityFilterChain`(`<sec:http>`)内に、ひとつ以上のAuthentication FilterのBean定義が必要というSpring Securityの仕様をみたすためである」といった感じにしてほしい。


![Uploading 01.jpg…]()
生存手册


I know :) Unfortunately it doesn't work... I don't know how validate_uniqueness_of_matcher works internally but it caused flaky tests. I debugged it yesterday 1-2 hours and haven't found the reason. Don't want to spent more time in investigating this minor thing ...


@limouri rename versionApi to apiVersion and inject constant ElasticSearchProperties


Здесь нет необходимости ссылаться на внешнюю переменную filteredReviews, потому что ты ее передаешь в качестве параметра reviewsToRender.


Yeha, this does indeed work as far as I tested. It is not really faster though. I am seriously skeptical about a general query API, it must be very limited IMHO to be futureproof.


Makes sense, let me correct that


The rationale was that it's better to receive an error from the compiler saying "@BinaryType has been deprecated. Use @ComponentType instead." than "Annotation BinaryType could not be resolved".


发 Gem 我要用 :smile:


I think this should be a warning, not an error.


this should be post.


Еще у меня были сомнения по поводу корректности работы фильтров – должны они фильтровать данные, которые сейчас выведены, или же, как сейчас сделано, выводить первую страницу из всех отфильтрованных данных.

Поскольку в задании на этот счет нет никаких уточнений, то я решил, что оба варианта возможны


test


why make this local to contribution list? i think we'll need the same thing for sessions


if this is something that triggers an action, a button is probably better.


- [ ] 「フレームワークのスタック」は「フレームワークスタック」で。


confirm the email address


I prefer using `email_address` as the variable.


Theres some console logs here, not sure if they are hangovers :)


+1 !!!


yeah, fixed in b5479e170d16d162162ca2a1c36f83ca3859deb1 - thanks for advice!


la seule chose que je vois c'est que ça va un peu diminuer les performances car il faut déréférencer m_constraint au lieu de juste avoir la date "comme ça" sur la pile mais bon, c'est peut-être du chipotage.


insert(Mester)


ah yeah nvm :3


is there a changelog somewhere?


good points, will adapt my tests!


Hmm.. Doesn't seem to be fixed in the 9.1 cocoapod release. This is what it looks like:

``` objective-c
- (CGFloat)slk_appropriateBottomMargin
{
    // A bottom margin is required only if the view is extended out of it bounds
    if ((self.edgesForExtendedLayout & UIRectEdgeBottom) > 0) {
        if (self.tabBarController) {
            return CGRectGetHeight(self.tabBarController.tabBar.frame);
        }
    }

    return 0.0;
}
```


:heart: awesome


已发！


Might be cleaner to put these date specific files in a separate csv? Should be just a matter of moving these new lines out and regenerate the lang files.


Well at least we internal should use one ;) How far we take it to the public side is another story, but without something like that we won't provide enough functionality for a content API / repository IMHO. Especially with remote operations you need to have queries that can give you the wanted content inside one request instead of sending multiple small operations that depend on each other (like we currently do with FlowQuery in process).


As I see from this review if we have one CPU type, (LG G2 has cortex-a15) then HMP is not really do any good.
http://stackoverflow.com/questions/25498215/how-is-heterogeneous-multi-processing-hmp-scheduling-implemented-in-linux-kern

It’s efficient when there are 2 types of cores present.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16088](https://teamcity.mesosphere.io/viewLog.html?buildId=137243&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:03:52


I'm more referring to the snippet above:
```
for i, line in enumerate(config_lines):
    config_lines[i] = line if line.endswith("\n") else line + "\n"
```
you could delete that then and just use `conf_file.write`


Yes true, and we should do that, I just want to be sure we don't expose too much functionality that make it hard to refactor stuff in the future.
I guess I will bring this to a bit further state and explore the query api as well.


I still prefer list of lines - cuz we use that for files everywhere


Do we have a limit on the areaId length ? Because if I read correctly this code, the deeper an area is, the larger its id is : arealvl1_row_3_col_2_row_8_col_6, and so on


`mkstemp()` docs tell me it has a `text` parameter that opens your file in textmode. Maybe you can use that?


This is a web site tribute to the NBA legends. Live at: http://tkouleris.eu/html5/nba/


Full ack, for the beginning the query API should be private and we should be pretty sure about what and how deeply we expose it.


@mattdrayer , Fortunately both of us are at the same path. I was following the same approach yesterday ( Sorry I think, I could not deliver my thoughts properly on hipchat, Actually translations are rendering in Arabic via using this runtime service ) **BUT** my concern was that may be we cannot use this runtime service everywhere specially in case of help text in xblock fields as I had discussed on hipchat But you told me that it is already in your knowledge and no one has this answer.
So with this runtime service we can achieve the partial results of translation and I think we can use it where it is possible.


So are you trying to say that if a pod has empty tolerations....it indicates that it cannot tolerate any taints and we return  false here ?


Thanks, will add to documentation.


ループさせないのにa=1とかする意味ある？
1回で済むなら直接書いちゃったほうが


I suggest currently just implement `NoSchedule`, and you can have the logic of `NoScheduleNoAdmit` and `NoScheduleNoAdmitNoExecute` in commented lines, once the logic of `NoAdmit` and `NoExecute` implemented, you can uncomment them.


@sahat Thanks for checking - I tried it out and it works fine!


c'est bon, je l'ai merge dans dev sur i-score


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16089](https://teamcity.mesosphere.io/viewLog.html?buildId=137244&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:12


Needs an empty line before according to https://www.drupal.org/node/608152#indenting


Great move!


This commit breaks the upgrade process because `NodeId`, `PropertyTypeId`, `Text` and `nodeId` properties do not match column names in database. You didn't rename all props when changing from `PropertyDataDto` to `dynamic` object.  See: http://stackoverflow.com/questions/35442149/unable-to-upgrade-from-umbraco-6-0-7-to-7-4-0


Empty line before


Nice, I like to see code deleted rather than added :)


huh?


There's still some potential for conflict here given a top level component named _nameChildGrandchild_. I don't have any suggestion right now but I'll think about it.


name?


@Makman2 just tried:
```
            config_fd, config_file = tempfile.mkstemp(text=True)
>           os.write(config_fd, "".join(config_file))
E           TypeError: a bytes-like object is required, not 'str'
```
Seems like `os.write` needs a bytes object still :(
Is there any other way of writing to it that I don't know about ?


I'm wondering why PHPCS doesn't do it automatically.


Great idea. Could avoid some issues later.


Cool, I guess the JSON is working for you now?


Ops, sorry i forgot about this one. I think we should add a log message so the user know why it dont work.


I already pushed it


Candidate for inclusion into v0.1 branch.


looks like this or the other commit broke jenkins?
http://jenkins.plone.org/job/plone-5.0-python-2.7/4042/changes


/cc @alecpm


Json for the author profile it worked from the beginning. The problem with the json is : http://172.22.120.162:5000/search, on the second tab. [ /search/user-info/user  ]


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1549 of 1549 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.77%25-green.svg)


TeamCity LabKey :: Trunk :: Community :: CDS postgres 9.5 [Build 102](https://teamcity.labkey.org/viewLog.html?buildId=303850&buildTypeId=LabkeyTrunk_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 10, passed: 40 Build time: 01:14:23
### Failed tests
```
org.labkey.test.tests.CDSHelpCenterTest.verifyHelpCenter: <no details avaliable>

org.labkey.test.tests.CDSSecurityTest.verifyUserPermissions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisFilter: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

```


確かだけど、fields_forにindexをつける方法があったはず...
fields_for_with_indexみたいな...

うる覚えなんで指導出来ないから、もし余裕あったら見てみて


@quelgar Well it was reverted in 6.2, as with all these things it was done to solve other problems mostly related to the Scala compiler being a bit crap with variance.


Looking at `gen_smtp`'s code this might need to be lowercase.
Also, the ticket is not marked as closed.
Also, recent issue in support might need this backported.
Also, here are more: https://github.com/2600hz/kazoo/commit/74ead5bd6ba62db43022bdc47dbd06beb9854483


Don't remove this


Don't remove this.


1.9.1 hasn't yet been released and pushed to cocoapods.


it would be better to get the default value from where they are defined (in the sheet)


Remove debugging messages.


jQueryのとこはファイル1枚になるから、
「Add JS method to ~~~~~」
みたいな感じで追加機能ごとにコミットすると見やすいかもね


please document.


We are not using `$node` here. Please remove this.


Wouldn't it be better to let the event return an event type and additional data, and let Javascript handle the logic then? This way the Javascript logic is moved to PHP ;-)


Please add a test / example.


This is not allowed. The GWT compiler is failing since GWT event handlers must receive an event as a parameter.

To avoid similar issues, I recommend do a build a test the app before pushing to git.

https://github.com/dashbuilder/dashbuilder#build--run


良い勉強になったと思います！(childrenとかnextとか)
あとはparentとかprevとかもよく使うので、
これら駆使しながら汎用性のあるコードを書いてください。


#测试
[我的博客](https://github.com/jinsen1/xUtils3_sample/tree/master/README_img)<br>
![](https://github.com/jinsen1/xUtils3_sample/blob/master/README_img/gif_add_data.gif)


I dont have the best updated code everywhere :)
So please check via 3.10.y before you sync with me, what you reverted here, is this commit. merged now.
https://github.com/neobuddy89/shamu/commit/5577022f4ed8973762450ebe7fe7ebfd953817db


@madnificent It's indeed the intention to use Docker Compose, so a docker-compose.yml snippet would be more helpful than a Makefile. Maybe we can include one in a similar way as https://github.com/big-data-europe/docker-flink/tree/master/docker-flink-compose?


And then again I doublechecked the flag functionality - it seems working correctly. So if you have any suspicions - let's discuss it.


Please correct indentation settings.


Unnecessary newlines


@zpqrtbnk can you have a look at this - and create a task on the tracker if this can be reproduced (scheduled for 7.4.2) ?


Let's use the modern syntax for arrays s/array()/[]


 Unlock conversation
1 comment on commit 1b1d5fb


Looks good with those minor nits.


Fixed.


`$node_type` is not used here. Please remove this code.


"Was this article usefull" - enclose this in `t()`. And it should be usefu**l**


I have written directive where you can specify filter in attribute, you provide a list of fields to watch and react on value changes,
code sample:
`if ("valueFilter" in attrs) {

                            var filters = scope.$eval(attrs.valueFilter);
                            $.each(filters, function (i, v) {
                                var filterField = v;

                               // watches are set dinamicaly
                                scope.$watch(v.scopeField, function (value, oldValue) {

                                    console.log("filter has changed on parent, update filter on control");

                                    var scopeFieldName = this.exp;
                                    // set filter value
                                   setFilter(scopeFieldName, value);
                                });
                            });
                        }`


Thanks, I will test that tonight. Would make the property optional as was intended in the first place.


You dropped the parts that converted paths to project relative ones, which is quite pity - it was very helpful in debugging process.


LGTM..


So what's the point?


I got something mostly working but I cant seem to push to the astro github. heres the files though.

https://github.com/chaunceychason/Vandy_AstroML.git


@mattdrayer I was seeing the same implementation of `ugettext` in django.py , what is the reason to use the same logic in django.py If we already have this in translation.py ?


override func viewDidLoad()が上にあるので、同じ名前の関数が２つあることが原因です。


@fluffypony I'm just now seeing this (almost all emails are no longer getting through lately, very annoying). Next time, please open a ticket so I can catch things like this. Thanks.


@Ismailrizvi : Change page title to  "idroc" instead of Inventory Management in next commit without failure


* examples with rust


@Ismailrizvi  : Please put more content for explanation of idroc at home page in your next PR without any failure


...あなたはturbolinksマスターです


please don't say "plugin" at the end of the title; it's assumed :)


Doesn't the directory this file is in need renaming to `logs`?


BTW can we write it inside `{ }` to avoid these highlighting issues? :dancer:


I think the point is calling ```listeners[i]``` once instead of twice. But i searched through the file and found three ```push()``` calls which could also be optimized with ```listeners[listeners.length] = ...```.


`$variables['content_id']` will always be numeric


@Ismailrizvi  : FYI we are not using php technology in idroc


juj


Is there some documentation on how to use this node.


@mattdrayer I want to share on thing, I think, We need to specify the `languages= user_current_language` in `gettext.translation` like this `gettext.translation( 'django', "../venvs/edxapp/src/drag-and-drop-v2/drag_and_drop_v2/conf/locale", languages = ['ar'])` otherwise it will look for default 'en' directory under LOCALE.


gameCheck()とretry()の２つの関数がstartAccelerometer()のなかに入ってるので、エラー出てます。


No, it doesn't. Call is ambigulous. Please check the https://github.com/Teradata/presto/commit/ac7dca2e10c6d923b9e4d893519d50fbcd7fb8ae#diff-2328b90ef763437999b1701524a98a9fR191


good job, where is the merge ?


Should be `$header_value` :)


2.turbolinksをoffにしてしまう
3,イベントハンドラでreadyだけではなくpage:loadも指定するなどの方法がある

俺はこのどっちかで対応させることが多い(jquery-turbolinks知らなかったw)
解決策がわかったので、これからもどんどん使っていきましょー！


@tchaikov I doe agree with you. But ATM I need to figure out why things are not working for me in Jenkins.
And I try to do limited invasive surgery. I do have the intention to remove these commits before I have completed the porting and have a "fully" compilable and testable Ceph implementation. However last days it has been a "uphill" battle to differentiate between my errors and just the quirks of Jenkins.


@Ismailrizvi  :+1:   nice work done , Please follow the line comments for more improvement


playerMotionManager.startAccelerometerUpdatesToQueue(NSOperationQueue.mainQueue(), withHandler: handler)
は
self.playerView.center = CGPointMake(posX, posY)
の下に書きましょう。
あとは、中括弧({})の数に気をつけてね


Yes - [available on the CDN](http://cdn.datatables.net/1.10.11/). They were actually missing before, but are up now :-)


master android


Remove the else part completely and move the initialization to begining of the function.


No, that was fixed about a year ago: 4e1c264ce2bc2ffed129c46b5d53ab7e3d2a400a :wink:


They don't have any explicit tests for `AggregationMetadata` and `AccumulatorCompiler`. Implicitly it is tested in a way of invoking `approx_set(NULL)`.


Please keep the English version. I'd be happy to add another language support after as part of a follow up PR.


Looks find except one minor comment.


Remove Admin login from search page since search will be accessible only when user/admin is logged in


Ah, OK.

Github file viewer - you've got me cornered again :)