Nope, I tested Canary 50, it doesn't pass if you don't set the `__proto__`

![qq20160224-0](https://cloud.githubusercontent.com/assets/1415488/13281821/e2df3f3e-db20-11e5-8782-aed81468e17d.jpg)


yup, it was complaining about missing deps. the addon generator assumes the addon might not have templates.


Indent by 8 spaces!

And missing newline at end of file.


testing


this doesn't really make any difference does it? Linebreaks are irrelevant for this...


confirm. since the rest of the wording is still subject to changes anyway, I'm waiting for the final copy.


Other parts of this set of updates migrate Mutex::Locker to the standard library, did we want to do the same here?


# 类对象
### <1>一个类是否是另外一个类的子类
	(BOOL)isSubClassofClass:  [xxx class];
### <2>一个引用指向的对象是否是某种类型或子类型
	(BOOL)isKindOfClass:[xxx class];
### <3>一个引用(实例)指向的对象是否是某种类型
	(BOOL)isMemberOfClass:[xxx class];
# 方法选择器
### <1>某个类是否存在某个方法
	- (BOOL)instancesRespondToSelector:@selector(方法名);
### <2>强制发送消息
	- (id)performSelector:@selector(方法名);
### <3>是否可以使用某个方法
	- (BOOL)respondsToSelector:(SEL)aSelector;
# 协议选择器
### <1>某个类是否遵守了某个协议
	(BOOL) conformsToProtocol:@protocol(协议名);
# NSString不可变字符串
### <1>创建
	NSString *str = @”内容”;
### <2>格式化创建
	(instancetype)stringWithFormat:@“%@,%@”,@“内容a”,@“内容b”
### <3>从开头分割到某个位置
	(NSString *)substringToIndex:下标
### <4>从中间分割到结尾
	(NSString *)substringFromIndex:下标
### <5>从中间分割长度x
	(NSString *)substringWithRange:NSMakeRange(下标, 长度)
### <6>末尾追加
	(NSString *)stringByAppendingString:@”内容”
### <7>按指定格式追加
	(NSString *)stringByAppendingFormat:@”%@ %@”,@”内容a”,@”内容b”`
### <8>指定位置替换
	(NSString *)stringByReplacingCharactersInRange:NSMakeRange(下标, 长度) withString:@”内容”
### <9>转换从文件读取的数据的编码
	NSString *path = @”/Users/apple/Desktop/test.txt”;
	(nullable instancetype)stringWithContentsOfFile:path encoding:NSUTF8StringEncoding  error:nil
### <10>字符串的比较(内容是否相同)
	(BOOL)isEqualToString:@”内容”`
### <11>转换为大写字符串
	(NSString *)uppercaseString`
### <12>字符串的比较(比较大小)
	- (NSComparisonResult)compare:(NSNumber *)decimalNumber; `

如果a比b大，返回1，一样返回0，小返回-1
# NSMutableString可变字符串
### <1>创建
	NSMutableString *str = [[NSMutableString alloc]init];`
### <2>在指定位置添加内容
	(void)insertString:@”内容” atIndex:下标`
### <3>在最后添加内容
	(void)appendString:@”内容”`
### <4>在最后添加指定格式内容
	(void)appendFormat:@“%@,%@”,@“内容a”,@“内容b”`
### <5>删除
	(void)deleteCharactersInRange:NSMakeRange(下标, 长度)`
### <6>替换
	(void)replaceCharactersInRange:NSMakeRange(下标, 长度) withString:@”内容”`
# NSNumber基本数据类型类封装
### <1>int型
	封装+(NSNumber *)numberWithInt:int型数字`

	拆封(int)intValue`
### <2>char型
	封装+(NSNumber *)numberWithChar:’字符’`

	拆封(char)charValue`
### <3>float型
	封装+(NSNumber *)numberWithFloat:float型数字`

	拆封(float)floatValue`
### <4>double型
	封装+(NSNumber *)numberWithDouble:double型数字
	拆封(double)doubleValue
### <5>BOOL型
	封装+(NSNumber *)numberWithBool:YES/NO
	拆封(BOOL)doubleValue

# NSValue结构体类封装
### <1>封装
	TRPoint p = {3,4};
	结构体赋值valueWithBytes:&p结构体首地址objCType:@encode(TRPoint)
### <2>拆封
	(void)getValue:&p2接收的结构体首地址
# NSDate时间
### <1>得到当前时间
	NSDate *date = [[NSDate alloc]init];
### <2>得到一个延迟x秒的时间
	(instancetype)dateWithTimeIntervalSinceNow:30.0f
### <3>得到两个时间差
	(NSTimeInterval)time timeIntervalSinceDate:time1
### <4>得到指定格式的时间，自动转换为系统时区
	NSDateFormatter *df = [[NSDateFormatter alloc]init];
	df.dateFormat = @”yyyy-MM-dd hh:mm:ss”
	(NSString *)df stringFromDate:[[NSDate alloc]init]

	NSTimeZone * zone = [NSTimeZone systemTimeZone];
	NSInteger interval = [zone secondsFromGMTForDate:date];
	NSData * localeTime = [date dateByAddingTimeInterval:interval];

# NSArray不可变数组
### <1>创建
	NSArray *array = @[@“内容a”,(ObjectType)str,@“内容b”];
### <2>获得数组长度
	(NSUInteger)count
### <3>通过数组下标获得元素
	(ObjectType)objectAtIndex:下标
### <4>获得数组最后一个元素
	(ObjectType)lastObject
### <5>获取某个对象在数组的下标，如果数组中不存在该对象，则返回一个垃圾值下标
	(NSUInteger)indexOfObject:@”内容”
### <6>OC中数组遍历的三种方式
**a for循环**

	for (int i = 0; i < [stus count]; i++) {
	    Students *stu = [stus objectAtIndex:i];
	    NSLog(@”%@”, stu);
	}

**b for快速枚举**

	//参数1元素的引用 参数2数组或集合名
	for (Students *stu2 in stus) {
	    NSLog(@”%@”, stu2);
	}

**c  迭代器遍历**

	取出数组中元素
	自动向下移动一位
	//迭代器遍历
	//每个数组或者集合相应的迭代器，遍历完会返回一个nil;
	NSEnumerator *enumerator = [stus objectEnumerator];
	//去数组中取出元素
	//并且回自动向下移动一位
	Students *st3 = nil;
	while (st3 = [enumerator nextObject]) {
	    NSLog(@”%@”, st3);
	}
### <7>输出存储自定义类的数组，需要重写description方法，自定义输出格式

	-(NSString *)description{
	    return [NSString stringWithFormat:@”name:%@ age:%d”, self.name, self.age];
	}
	否则需要使用NSLog(@”name:%@ age:%i”,stu.name, stu.age);来输出
### <8>数组的拷贝
	深拷贝 (NSArray *)[[NSArray alloc]initWithArray:要拷贝数组名copyItems:YES]
	浅拷贝 (NSArray *)[[NSArray alloc]initWithArray:要拷贝数组名copyItems:NO]
# Order数组排序
### <1>排序规则
	SEL sel = @selector(compare:);
### <2>两两比较
	(NSArray<ObjectType> *)sortedArrayUsingSelector:@selector(compare:)
### <3>当数组比较的不是基本数据类型，需要重写compare方法
	-(NSComparisonResult) compare:(Students *) otherStudent{
	//    if((self.age - otherStudent.age) >0)c
	//        return NSOrderedDescending;
	//    else if ((self.age - otherStudent.age) <0)
	//        return NSOrderedAscending;
	//    else
	//        return NSOrderedSame;
	//封装两个int型 调用系统compare方法
	    NSNumber *n1 = [NSNumber numberWithInt:self.age];
	    NSNumber *n2 = [NSNumber numberWithInt:otherStudent.age]; return [n1 compare:n2];
	//追加对姓名进行排序—对字符串进行排序
	//    return [self.name compare:otherStudent.name];
	}

# NSMutableArray可变数组
### <1>普通创建
	NSMutableArray *mArray =[[NSMutableArray alloc]init];
### <2>预定义空间创建
	NSMutableArray *mArray2 = [NSMutableArray arrayWithCapacity:19];
### <3>初始化创建
	NSMutableArray *mArray3 = [NSMutableArray arrayWithObjects:@”内容”, (ObjectType)str, nil];
### <4>将不可变数组转化为可变数组
	(id)mutableCopy
### <5>添加元素到末尾
	(void)addObject:@”内容”
### <6>添加元素到指定位置
	(void)insertObject:@”内容” atIndex:下标
### <7>删除末尾
	(void)removeLastObject
### <8>删除指定对象
	(void)removeObject:@”内容”
### <9>删除指定位置元素
	(void)removeObjectAtIndex:下标
### <10>修改元素
	(void)replaceObjectAtIndex:下标withObject:@”内容”
# NSSet不可变不可重复无序集合(无下标)
(1)每一个对象都有一个hash码，hash码是用来唯一标识对象的。(hash算法)如果hash码相同，就认为两个对象可能向东，hash码不同，一定是两个对象。当对象放入到NSSet集合中，会自动调用对象的hash码进行判断。

(2)当hash码相同时，会自动调用对象的isEqual方法，再次判断对象是否重复，根据方法的返回值决定对象是否重复。

	-(NSUInteger)hash{
	    NSLog(@“绕过hash算法判断”);
	    return 1;
	}

	-(BOOL)isEqual:(id)object{
	    NSLog(@”isEqual执行了”);
	    //a.判断自反值
	    if(self == object){
	        return YES;
	   }
	    //b.判断类型是否相同
	    if([object isKindOfClass:[Student class]]){
	        //c.判断值是否相同_
	        Student *otherStudent = object;
	        if([self.name isEqualToString:otherStudent.name]&&(self.age == otherStudent.age)){
	            return YES;
	        }
	        else{
	            return NO;
	        }
	    }
	    else{
	        return NO;

	    }
	}
# NSMutableSet可变不可重复无序集合(无下标)

### <1>创建
	NSMutableSet *mSet = [NSMutableSet set];
	NSMutableSet *mSet2 = [NSMutableSet setWithObjects:@”1”,@”two”, ,nil];
### <2>添加元素
	(void)addObject:@”内容”
### <3>删除元素
	 (void)removeObject: @”内容”
### <4>两个集合的交集
	(void)intersectSet: (NSSet<ObjectType> *)otherSet
### <5>两个集合的并集(集合是无序的，所以输出顺序不定)
	(void) unionSet: (NSSet<ObjectType> *)otherSet
### <6>根据集合删除另外一个集合中的元素
	(void) minusSet: (NSSet<ObjectType> *)otherSet

# NSDictionary字典

### <1>创建字典
**a创建字典对象(一对出现，value1,key1,value2,key2)**

	NSDictionary *dict=[NSDictionary dictionaryWithObjectsAndKeys: (id)firstObject,@“key1”,(id)secondObject,@“key2”nil];
**b通过数组创建字典**

	(instancetype)dictionaryWithObjects: (NSArray<ObjectType> *)objects forKeys: (NSArray<ObjectType> *)keys
**c通过已有字典创建字典**

	(instancetype)dictionaryWithDictionary: (NSDictionary<KeyType, ObjectType> *)dict
**d快速创建字典**

	NSDictionary *dict=@{
	              @"北京":@[@"东城",@"西城",@"朝阳",@"海淀"],
	              @"上海":@[@"静安",@"徐汇",@"浦东"],
	              @"广州":@[@"白云",@"越秀",@"天河"]
	              };
	mutableDic[@"key"] = @"value";
### <2>获取字典中键值对的个数
	(NSUInteger)count
### <3>得到字典中所有的key
	(NSArray<KeyType> *) allKeys
### <4>得到字典中所有的value
	(NSArray<ObjectType> *)allValues
### <5>通过对象获取关键字值
	(NSArray<KeyType> *)allKeysForObject: (ObjectType)anObject
### <6>根据key值得到相应的value值
	(nullable ObjectType) objectForKey: (KeyType)aKey
### <7>遍历字典中的元素
	NSArray *keys = [dict allKeys];
	for (NSString *key in keys) {
	    NSString *value = [dict objectForKey:key];
	    NSLog(@”key-->%@  value-->%@”,key,value);
	}
### <8>遍历多重嵌套字典
	NSArray *collegekeys = [university allKeys];
	for (NSString *collegekey in collegekeys) {
	    NSDictionary *college = [university objectForKey:collegekey];
	    NSArray *classkeys = [college allKeys];
	    for (NSString *classkey in classkeys) {
	        NSDictionary *class = [college objectForKey:classkey];
	        for (Student *student in class) {
	            NSLog(@"name-->%@  age-->%i",student.name,student.age);
	        }
	    }
	}

# NSMutableDictionary可修改字典
### <1>创建
**a创建空的可修改字典**

	NSMutableDictionary *dict = [NSMutableDictionary dictionary];
**b创建包含预估值的可修改字典**

	NSMutableDictionary *dict= [NSMutableDictionary dictionaryWithCapacity:18];
**c创建初始化可修改字典**

	NSMutableDictionary *dict= [NSMutableDictionary dictionaryWithObjectsAndKeys:stu,@“1”,stu1,@“2”, nil];
### <2> 添加
**a添加一个元素**

	(void)setValue: (nullable ObjectType)value (NSString *)key
**b添加一个字典**

	(void)addEntriesFromDictionary: (NSDictionary<KeyType, ObjectType> *)otherDictionary
### <3> 覆盖一个字典
	(void)setDictionary: (NSDictionary<KeyType, ObjectType> *)otherDictionary
### <4>删除
**a删除一个键值对**

	(void)removeObjectForKey: (KeyType)aKey
**b删除多个键值对**

	NSArray *keys = @[@"1",@"2"] ;
	[dict removeObjectForKey:keys];
### <5>清空字典
	(void)removeAllObjects


hmm okay. I assumed that it would be enough if the app using this addon would have that as a dependency.


> In general: what exceptions can be thrown by these interfaces? I assume there are exceptions possible. The API should mention them if possible.

I don't think we have any meaningful/recoverable exceptions yet; either it succeeds and you get a result or it fails and you get an error. We might try for more detail later, e.g. if we add a way to detect version skew.


「Want itボタンが押された時には」ですね。


How does it let the permanent ones pass through to the report?


> Quite confusing. GenericType is meant to store parameterized type information. Why not TypeInformation? Also 'tree of [Type] instances' does not explain what this is meant to do ^^

David also complained about this one. Now renamed FullType, and with more detail in the comment.


above line is odd


@conory 님 소스제공


we might get away with a peerDependency? gotta check


> generics? or parameters?

Renamed to "parameters".


ack, neat!


ack just to get the PR


It is irrelevant, I agree.
The reason I felt it should be there is because I felt that the writer of these tests didnt know about the line breaks were being added. I.e. he/she wanted to test it without the linebreaks
Also, notice that I've added a new test case with a `\n` just to make sure that the `\n` doesnt break the bear.


32行目も「Wantボタンが押された時には」でお願いします。


入门python后的第一个小程序，用来统计商品多久过期的。只要输入生产日期和保质期变能自动计算出哪天过期和还剩多少天并保存为excel文件。查了很多的文档断断续续的终于大体上完成了，其中一些细节上的小问题也无力去弄了，如果以后有闲心可能会解决并添加些功能。


It doesn't work with JInput ?


TeamCity Civic Assembly :: Build all [Build 74](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1335&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 205 Build time: 00:09:40
### Failed tests
```
Basic Message Campaigns CRUD Actions: Should Add Message Campaign: <no details avaliable>

Basic Message Campaigns CRUD Actions: Should Not Edit Message Campaign: <no details avaliable>

Basic Message Campaigns CRUD Actions: Should Edit Message Campaign: <no details avaliable>

```


This looks fine to me, but it's hard for me to comment much since I'm not very familiar with how this code winds up getting used. I'm assuming that the move to vector<> is to make the memory contiguous?


Good one! :ok_hand:


ad #6


awesome!


1) Где деструтор?
2) Стоит помнить о том что стек может сам расширяться, но не может сужаться. То есть он может забирать память во время работы, но вернет ее только после удаления. (Вернее не вернет, т.к. деструктора нету)


**FAILURE** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 331](http://ci.infinispan.org/viewLog.html?buildId=36291&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for 1b3721d1d1c479d7f2b8ba87fee6da33b771955b
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:00:03

Process exited with code 255


Nice, the more benchmarks the better :-)


asked us to ~~not~~ automatically


How much performance degrade on multiple cpus by this new contention point "connection id" ?


@toandv


hi i am ankesh kumar.i am here to learn programming


I have create [this Californium Wiki page](https://github.com/eclipse/californium/wiki/DTLS-Connection-Renegotiation-vs.-Resumption) trying to explain Scandium's behavior for the different use cases. I want to revise the last section, though, trying to better illustrate the difference between resumption and renegotiation.

What do you think?


This seems to work, It's faster to test in "production" :D  If it's not working, the only problem is that some builds might take longer than they should.


Why try/catch the NPE? Null-safe access instead?


`obj.ObjectMeta.Name` is a string, no need to "string"-ify it more ;)


oh, but actually some people are still using the old filesystem, where this is a big problem... :(


We should have guards on Shapes like `isRubySymbol(Shape)` or as in ShapeCachingGuards.
Then, a Shape check is enough and all other guards can be on the slow path.


**HEAD commit has no message.**
*GitCommitBear, severity 1, section `commit`.* *Project wide.*


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/27936/testReport/) for this commit**


Design looks good to me.
I'll write and upload a document to describe all the design elements from your presentation in one place, then we can all discuss and/or tweak the design more easily and then do the user story thingy on the Trello board. :)


Could you remove this logging?


ОМГ, что это? Откуда это число? А если кто-то положит такое число в стек?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16986](https://teamcity.mesosphere.io/viewLog.html?buildId=144003&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:04:06


The cache seems incorrect here, it should be either on identity or Shape (a Shape with a singleton class, so that means a singleton Shape so identity seems more useful).
If it's on identity, guards can be on cachedObject.


1) Почему все в main-е?
2) Где проверки?
3) см. выше про error1


can we maybe have `return 0` here and reduce indentation of the following lines?


This looks great !
Only issue is the commit message - it should be `Add __version__`


You're a force for good! :-) Happy to see unique_ptr<> replacing something like this. IMO it would be nice if we provided an implementation of make_unique<> somewhere and used that rather than a bare new from word "go". (Scott Meyers and Stephan Lavavej both have some popular implementations floating around.)


alright


Consider using jqXHR.done(), jqXHR.fail(), jqXHR.always() callbacks for ajax calls, as jqXHR.success(), jqXHR.error(), jqXHR.complete() are deprecated and will be removed in future versions of JQuery
More details here: http://api.jquery.com/jquery.ajax/#jQuery-ajax-settings


This fixes `make: *** No targets specified and no makefile found.  Stop.` for me (on latest Raspbian).


As far as I can tell, you downgraded. U2 is the update 2 of the same version, even though gradle and maven tell different.


No sense to check `WINAPI_FAMILY` and then include `winapifamily.h`, because `WINAPI_FAMILY`is defined in `winapifamily.h`.


Sorry @johnspicer  - just realised that I didn't respond to this. Yes, `self.source_queue.get()` either raises an exception or returns a message.


I'm okay with it being a dependency. Was just a little surprised.


DEFINIR USER I PASS PER ENCARREGATS I VETERINARIS


I prefer no empty line here, it's already enough boilerplate IMHO. What do @jruby/truffle think?


Принято.
Одно замечание: ok() можно сделать приватной, так как пользователю вместо нее отдана функция check()


Everything looks awesome here too :)

But the commit head should be "coala-bears repo" I think ? ( left overs from the other PR xD )


Should be `array|null`.


Well, after more check, I think I have figured it out. Thank for your patience.


>Various Adjustments

What kind of adjustments? Where? Remember that every commit you make will eventually appear in the list of commits on master.


Does this work without cast? While you specified that the enum should use a byte behind the scenes, does the Effect method take that as a byte?


rename to something more clear. client_templates?


I imagine several things:
- the primary thing about this mode is that you don't _collide_ with things, it doesn't function like a jetpack, which the 'flying mode' term kinda implies
- we can't afford voluntary changing menu item strings because of the translation strings. the l10n snowball will begin rolling pretty fast
- the game doesn't break if you pick this menu item to see what it does even if you don't understand what it's saying
- I hate the notion that we're supposed to treat our players as an intellectually-handicapped bunch
- https://www.google.ru/search?q=noclip+mode


what are the use cases of rel alternate?
could we add a custom type (odoo template or something)


We could have a global Assumption `only one Thread yet` to make it a bit nicer.
But OTOH this also specializes on a given thread so that's more powerful (would be nice to use `@Cached` here).


I'd also add `stub: true` like CouchDB does.


Yep, already done in the last PR version :)


**Code Quality - Nitpick**

This should be in a partial and just placed in like so:

` @include('layouts.partials.alerts')` - Something like that


Wat is dit?


Indeed


+7 (347)262-90-42

+7 (347)287-11-87


Seems it should be `readOrNullNode` here. Please use an helper method for this or it just becomes unreadable and bug-friendly.


xml => client template?
to avoid if js and xml => if client_template


Given that you always need to get the same work function, I would `assert self.fs_visu.max_work_functions == 1` here.


s/SourtceHandler/SourceHandler


Do we want javadoc comments?


change to _get_remote_blueprint_content or something.


In most cases


change back to client_executor


hmm, but then i would assume there is also a digest hash which i dont want to build in this temporal fix

- yes, all errors are my iPhone's fault

> Am 24.02.2016 um 11:22 schrieb Johannes Jörg Schmidt <notifications@github.com>:
>
> I'd also add stub: true like CouchDB does.
>
> —
> Reply to this email directly or view it on GitHub.
>


@Zeng0122 Should write as "Update **a** pdf"


Do we want a constant for the 1, to give it some context?


We don't need to delete all these attributes from `login_session`. We just need to make a request to Google OAuth to revoke the token. You will need `credential.access_token` for that


# wget ...


--cascade


# curl ...


# sh ...


Are above lines needed? If the page wasn't in original website, probably above metadata are not needed. @thatdocslady ?


add space after #


remove entirely


why?


its (spurious space)


Maybe "Password forgotten?" would be more fluent?


:+1: Always wanted to do this!


You know how this works with popover mode?


website


add *_ to args


Hello World


`crendentials` here is a `str` object instead of type `oauth2client.clienit.OAuth2Credentials`. So you will need to convert it into a `dict` object. You can do it using
```bash
credentials = json.loads(login_session.get('credentials'))
access_token = credentials['access_token']
```


fixed :-)


LGTM


Anyway you should update also this file jquery.fileupload-image.js in your fileupload plugin because people that are using require now have always an error Uncaught Error: Script error for "load-image-ios".

Thanks and best regards


Why tho, better to fix api instead right


Can we use HttpStatus class for a name value rather than the magic string here please.


Make the `values` method you propose protected avoid to allocate a new collection and also resolve the "threadsafe" issue.
As we can add a synchronized on `markAllAsResumptionRequired`.


it doesn't match the existing behavior:
in this case you join all templates in one "fake file"
in the less/css case we split to match the original bundle unrendered content (one link => one fake file)


Oups, sorry...


Do we need to consider any exception handling?


It doesn't really read config, get_module_opt does only an ets lookup. If this is still too costly, I can think of some way of passing it on. Not sure what behaviour you mean.


.then(this._handleResponse.bind(this))
.catch(this._handleError.bind(this))


@ole108 it is, it has to be, as it is declared in the method signature... I choose to use the existing IOException. You could argue that it is an IO related issue.


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/27938/testReport/) for this commit**


Should this be extracted into the core framework? - are we likely to reuse it? (or would that just create a new dependency)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16989](https://teamcity.mesosphere.io/viewLog.html?buildId=144020&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:04:23


This cache should be smaller because the generic case is only 3 reads instead of 1 + compare.
I think monomorphic makes sense here because the conditions are likely more expensive than the 2 reads.


Fix spaces being pre-pended


@hoeggi good call


What if there are several different stereo cameras?  Calling these cameras leads to update them alternately, which reduce the performance.


ack


Taka bzdura ale mozesz tu typ dopisac, jak patrzylem to bylem pewien ze id to bedzie jakis Long czy Int.
PUT     /lectures/:id/mapping       controllers.Lectures.addMapping(id: String)
Poza tym nie masz problemu z tymi routami? Wiem ze jak dasz controllers bez @ to nie znajdowal mi jakos tych sciezek:
PUT     /lectures/:id/mapping       @controllers.Lectures.addMapping(id: String)


viewsBridge :) ?


Yes, I was talking about the ets lookup. I think that's fine for now, and if we see any bottlenecks here then we can optimise.


PID: guess that sliped ty, fixed (PR https://github.com/slugalisk/overrustlelogs/pull/8 )

Now irrelevant, but the (/var)/run move is still in migration (FHS-3 is only ~6 months old), so /var/run is supposed to be symlinked "everywhere" anyways for the next decade...
Also I left it in /var to "keep it in line" with the upstart config^^


Oh, just found https://github.com/gajus/react-css-modules/issues/84. That was causing my problem.


change flow of install_cli to prapare+install_cli and add it to the online test


We should continue this discussion on the mailing list I suppose. I mean this is not a good idea if I comment the wiki page here.


Tokių dalykų nededam :)


One other thing to add (discovered elsewhere when reviewing someone else's ticket):

```
template<int X> 12( c< 1<<X> & aVar) { };
```


I'm trying to use custom templates and don't really understand how to make asciidoctor.js recognize them. Just pointing to a location with ERB templates yields the following. Do I need to compile the templates into JS somehow?

/Users/sicher/Documents/Projects/defold/site/node_modules/opal-npm-wrapper/index.js:4213
      throw exception;
      ^
TemplateConverter: uninitialized constant Asciidoctor::Converter::Factory::TemplateConverter
    at OpalClass.$new (/Users/sicher/Documents/Projects/defold/site/node_modules/opal-npm-wrapper/index.js:4429:15)
    at OpalClass.$const_missing (/Users/sicher/Documents/Projects/defold/site/node_modules/opal-npm-wrapper/index.js:2360:50)
    at OpalClass.$const_get (/Users/sicher/Documents/Projects/defold/site/node_modules/opal-npm-wrapper/index.js:2342:19)
    at Opal.get (/Users/sicher/Documents/Projects/defold/site/node_modules/opal-npm-wrapper/index.js:80:24)
    at e.$create (/Users/sicher/Documents/Projects/defold/site/node_modules/asciidoctor.js/dist/npm/asciidoctor-core.min.js:202:403)
    at f.$create_converter (/Users/sicher/Documents/Projects/defold/site/node_modules/asciidoctor.js/dist/npm/asciidoctor-core.min.js:348:454)
    at f.$update_backend_attributes (/Users/sicher/Documents/Projects/defold/site/node_modules/asciidoctor.js/dist/npm/asciidoctor-core.min.js:344:6)
    at f.a.defn.H [as $initialize] (/Users/sicher/Documents/Projects/defold/site/node_modules/asciidoctor.js/dist/npm/asciidoctor-core.min.js:318:474)
    at OpalClass.Opal.defn.TMP_2 [as $new] (/Users/sicher/Documents/Projects/defold/site/node_modules/opal-npm-wrapper/index.js:2793:23)
    at module_constructor.$load (/Users/sicher/Documents/Projects/defold/site/node_modules/asciidoctor.js/dist/npm/asciidoctor-core.min.js:642:79)


Yay! A really nice example of how C++11 features can help clean a lot of things up.


This commit is not linked to any issue, while it has quite a big impact!!


That makes sense :-) So we're done with this one, right?


@muteldar - so am I right in thinking this only happens when you explicitly specify a path to a credentials file, which includes a tilde?
The default credentials location is already fed through File.expand_path.


The purpose was to avoid N*N nodes for instance in the dispatch chain. But we probably want something more specialized like CheckMetaClassNode or so with a constant metaClass/shape anyway.


yep :)


OOC (and, please forgive me if this isn't the right place to ask) are there barriers preventing a move to C++14?


absolutely, so why not put it in /run from the getgo since /var/run is either symlinked to it or a separate tmpfs on all major distros?


inc is to meant to be used that way. inc => increment => paginated lesscss
maybe add a kwarg lang at this function?


Nice catch, fancy merging this as a pull request?


ack


Great job, thanks for helping out! :)
I just happened to notice two small mistakes:

a) double entry:
 9  regex( "Je vais (devenir|être) (végétalien|végétalienne|vegan|végane)" ),
15 regex( "Je vais (devenir|être) (végétalien|végétalienne|vegan|végane)" )

b)
"," is missing at the end of lines 13 - 15


I agree. I just wanted to put the information there so that it doesn't get lost ... I will start a thread on the mailing list ...


remove all args


resolution Object we can retrieve by project, issue and it's name


You could PR this into the main repository if you want. I'm working to remove the lodash dependency too.


ok no problem :)


Will increase zip size by ~50-100 mb


all custom fields should be mapped by their ids between instances


Did this work in a native device then? Because that's awesome :D


`specNo` can/should be const here. And I think `difc` and `tzero` as well.


Il vaut mieux prendre le module exemple sur modules.npds.org et le modifier si besoin (GNU V3)


W play domyślnie wszystkie parametry są Stringami więc nie trzeba podawać typu. Używam
routesGenerator := InjectedRoutesGenerator wtedy nie trzeba pisać @controllers
https://www.playframework.com/documentation/2.4.x/ScalaRouting#Dependency-Injection


don't sync watchers


rc.lua - it contains all geometry and keybinding options i choose, plus the following widgets:
- mpd widget (vicious)
- cpu usage widget (vicious)
- memory usage widget (vicious)
- battery status widget (created from scratch)
- network status widget (created from scratch)
- down/up widget (vicious)

to work it requires
- xbacklight (used for set the brightnees keys)
- termite (used as terminal)


current timestamp in our system


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/27939/testReport/) for this commit**


No problem, my bad habit to rebase changes :confused:…


This is `const`


Could you use `splitlines()` instead of `split("\n")` - thats the recommended way to split into lines


Anybody know what the real issue is here? This fix shouldn't make a difference, the old c++ code should function the same, or am i missing something?

The answer is important for me as i also experience seg faults when starting jarvis for linux on rockchip arm devices. This doesn't happen in isengard with same minimal patches.

Can somebody clarify a bit? TNX!


ack


I'm assuming that leaving out the centos64 reference literally one line below the diff cutout was an accident?


Commit message needs to be changed


ack, yes totally


link just by name


I'm not that good in English but shouldn't it be 'to see it working' or at least 'to see it works'?


This is a good way!


labels are strings, so, we have to find existing or create on the fly


met le sur ton git hub je le prendrai et adapterai avec les nouvelles choses


haha


这么加百家姓真萌啊......


affectedVersions


Anybody know what the real issue is here? This fix shouldn't make a difference, the old c++ code should function the same, or am i missing something?

The answer is important for me as i also experience seg faults when starting jarvis for linux on rockchip arm devices. This doesn't happen in isengard build with same minimal patches.

Can somebody clarify a bit? TNX!


That should be <kbd>M-x evil-vimish-fold-mode</kbd> - you forgot the -mode, otherwise looks good.


Fair enough, looking into doing this with travis now.


il est en dl sur Module
Prends le toi cela fera moins de manip


I think the commit message isn't quite right here as this commit doesn't actually do the import. It's more about getting the directory layout correct so it can be merged in.


Maybe `df1 == df2 || df1.getFrameDescriptor() == df2.getFrameDescriptor();`?
Or `(df1 == null && df2 == null) || ...`?


Can you use orElse here?


Need to remove this


should be
```
XCTFail("Exception should be API_NOT_STORED")
```


client or SUPPORT


ack


I don't see anything changed.


Peux tu me re-expliquer pour ces CSS ne sont pas dans le fichier pages.php au niveau racine themes ?


Please don't post everywhere one post is enough. Each comment send of like 1 email to each team member. So you spammed ~210 mails already :)


StatusObject could be fount by name, project, issuekey


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16990](https://teamcity.mesosphere.io/viewLog.html?buildId=144021&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:08:30


Ok, I agree. Just hard to guess your "driving intentions" by looking at patches only.


Seems string.strip  is excess in case of base64.b64encode


en principe il me reste juste un exemple de conf.php pour les installé auto (!!)


client or support


See the scope of the lock
```
{

}
```

which as changed. Your ARM issue ist most likely something completely different it is not an FFMpegCodec ...


Good point. I got confused with the utility classes which only have static helpers: in that case it mandates a private constructor.


@PEMapModder there are new packets, for example mob effect, or the really new ones, which are related to Map items.


Rename method to Accepted  not 202, and replace magic number in test.


Hi Danny,
Thanks for implementing this -it looks good in general. I think we'll need a change to the baseline and signal taus though to meet the EWK needs please
    - Baseline taus: pT>20, eta<2.47, nTrack=1 or 3.
    - Signal taus: baseline + medium id
I think the tau truthOrigin from the official tool doesn't distinguish between taus faked by quark/gluon jets which we'll need eventually. I'll see what I can do about that later down the line - but this is fine for now.
Thanks,
Tina


This sounds ok to me if using the stub allows you to simplify the tests.


unack, there should be an empty line between paragraphs, otherwise it's a linebreak


This match is too extensive. If you look at the log entries that we have, "the" is the only word found before a gene symbol, so we don't have to match any of the other words. And for the users link, we don't seem to be using "ID", but stead just "user #", so also that regexp can be simplified ;)


typo: '- -'


`request.formats.map(&:to_s).join(', ')`?


actually this should be the to_html for each xml asset (and should be one for each asset if we respect the current logic)


Just a typo in one line. Other than that, looks good to me.


In the future, commit messages like this aren't very useful. No reference to review comment and even if there was, there would be a risk of the original comment being removed. My proposal is to write 1) what you did and 2) why.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16991](https://teamcity.mesosphere.io/viewLog.html?buildId=144043&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:03:53


@mythodeia So how can I get the original image without taking scale in mind?


See, automation FTW ;)


ok je vais le prendre sur module


minify should not be passed, it should be minified in debug mode and in debug mode we do not call js, css, xml but to_html on each xml asset


Remove unused codes


Hi Check the line 509 of MySQL.cpp. If the upgrade type is neither 3 nor 1, buffer will be the SELECT query. This will cause the skills cannot be saved when Skill1/Skill2 is used.


> do you know how the this.base property works?

Almost. Not clear enough, but have some idea.


`array()`


лицензию поменяю


This was used for the output in OSR compilation name, has this changed?


I think, we aren't adding them to PocketMine until they are actually used.


класс, т.к. может использоваться для нескольких окон


Are you interested in all function or specifically this line?
The function expands the set of categories to a full set (ie, it adds missing parent categories). For example:
1. We have `video/movies` and `soft\os` in categories.
2. The function returns `video`, `video/movies`, `soft` and `soft\os`
This is necessary when you enable subcategories support during application run (or when app starts with manually changed configuration).
This line just adds a category to the set. Because categories are a pair { name => savePath }, then we add it with default savePath (empty string).


Besides, the following is a simplified version of GenerateSkill which is in ServerEnum. But only the Skill2 Card functions, so make a little change to make it able to deal with Skill 1 Card as well.
	int GenerateSkill(int level, int Type, int UpgradeType, int old_skill)
	{
			int sizeofBootSkill1 = sizeof(BootSkill1);
			int a = Type % 10, b = IdentifyItem(Type);
			srand(time(NULL));
			int Skill1 = rand() % ((level + 1) * 4) + 1, Skill2 = 0, Skill3 = 0;
			if (UpgradeType == 6 && old_skill != 0)
			{
				Skill2 = (old_skill % 1000000 - old_skill % 1000) / 1000;
			}
			if (a == 4 && b == ct_arm) //boots
			{
				if (Skill2 == 0)
				{
					Skill2 = BootSkill1[rand() % 20];
				}
				Skill3 = BootSkill2[rand() % 20];
				Skill Sk(Skill1, Skill2, Skill3);
				return Sk.getType();
			}
			if (a == 3 && b == ct_arm) //armor
			{
				if (Skill2 == 0)
				{
				Skill2 = ArmorSkill1[rand() % 30];
				}
				Skill3 = ArmorSkill2[rand() % 61];
				Skill Sk(Skill1, Skill2, Skill3);
				return Sk.getType();
			}
			if (a == 2 && b == ct_arm) //Pendant
			{
				if (Skill2 == 0)
				{
					Skill2 = PenantSkill1[rand() % 12];
				}
				Skill3 = PenantSkill2[rand() % 16];
				Skill Sk(Skill1, Skill2, Skill3);
				return Sk.getType();
			}
			if (a == 1 && b == ct_arm) //Shield
			{
				if (Skill2 == 0)
				{
					Skill2 = ShieldSkill1[rand() % 35];
				}
				Skill3 = ShieldSkill2[rand() % 74];
				Skill Sk(Skill1, Skill2, Skill3);
				return Sk.getType();
			}
			if (b == ct_wpn)
			{
				if (Skill2 == 0)
				{
					Skill2 = WeaponSkill1[rand() % 25];
				}
				if (a == 1 || a == 3)
				{
					Skill3 = MeleeWpnSkill2[rand() % 106];
				}
				else if (a == 2 || a == 4)
				{
					Skill3 = RangedWpnSkill2[rand() % 107];
				}
				Skill Sk(Skill1, Skill2, Skill3);
				return Sk.getType();
			}
			if (b == ct_mag)
			{
				if (Skill2 == 0)
				{
					Skill2 = MagicSkill[rand() % 104];
				}
				Skill3 = MagicSkill[rand() % 104];
				Skill Sk(Skill1, Skill2, Skill3);
				return Sk.getType();
			}
	}


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16992](https://teamcity.mesosphere.io/viewLog.html?buildId=144044&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:03:16


We're not in building stage, will keep this for time being. Once everything get cleared out, revert it back.


Ah, see it now, the else clause.


OK, re-reading my own comment, I said something stupid. I meant to say to use "\n" :/ Now again, carefully minding my wording:
- \r\n Is used by browsers in input fields. It would be stupid to change their input, so we leave it and LOVD counts on it even, when parsing data from text fields.
- PHP_EOL is platform-specific (the server's platform), and *must* be used when writing email headers. Otherwise, you'll run into problems with emails being rejected. But otherwise, we never use it.
- For everything else, we use \n.

So in this case... just use "\n", no need for a constant. Sorry! :(


je ne sais plus lol quand je me rappelle la raison je te le dis


ack


Ok, and VersionEye was wrong about this too. I'll revert.


can't we make two newcomer bugs out of this?


AndInvalidate() ? It would make it clearer that value cannot be compiled as null.


Do we need it separately? I thought it comes from sprockets-rails now?


Please toss this newline, we never end a log message with a new line :)


I wanted to do this in case we ever want to do any binary logic on these fields in which case having a state of value `0` wouldn't be useful.


Je pense qu'il vaux mieux le mettre de pages.php au niveau racine comme cela, ca gere le fall back alors que là il est forcé dans tous les themes


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16993](https://teamcity.mesosphere.io/viewLog.html?buildId=144049&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 237 Build time: 00:03:57


Not connected to your PR, but there is off-by-one error in retry-times definition


@bertez Could you make an example minimal project available? I've just tried it in one of my work Webpack projects and it seems jQuery 2.2.1 works fine there. Do you have problems with only 2.2.1? Does 2.2.0 work fine?


No migration for existing data since there isn't any 'real' data. But this will break any existing data you have locally


Добавлю проверку корневого узла на object/array (имхо, простые типы - это лишнее) + только на один элемент в корне.


don't we need to check that the message comes from jmap outbox ?


These were missing from https://github.com/dimagi/commcare-hq/pull/10356


:+1: way better solution. Bash everywhere !


Can be kicked out, sorry :unamused:


^_^ alright


ack


* `array()`
* Add custom params `array('integration_module' => 'boxbilling', 'test_mode' => ?)`
* Add support User Profile API (see other module)
`https://www.paymentwall.com/en/documentation/User-Profile-API/3125`
* Add support feature `test`


yes, sorry for the lack of information, I will make a minimal example and post it here as soon as I can.


留个QQ85362057，看到的话加一下！


1. Almost all these files are missing final newlines.
2. These examples still have the old `format` key, is that intended?


Thanks Alex.

Any thoughts from your side about the testing infrastructure?


Неявная область видимости - даже одну строчку надо оборачивать в скобки.


Push key to subfolder, /config/ssl


@dimagi/scale-team
Curious what you guys think about this. Currently if a form updates a case and also has some ledger transactions for that case we store 2 `CaseTransactions`, one with type `FORM` and one with type `LEDGER`.

Another option would be to store only one transaction and `or` the types: `FORM | LEDGER`.

I have been thinking about this approach with regards to another use case as well: being able to tell which form opened / closed a case (without loading all the forms and their XML). This gets used in one or 2 places e.g. user case, case display.


Can be lazy and have a better name as a globally accesible thing.


I had to see a few times to follow what's going on. We always this this:
```
$sIDParams = '?' . str_repeat(', ?', count($aCurators) - 1);
```
Is that also more clear for you?


Isn't it supposed to be ```%1``` for each argument?


whoops, wrong folder. oh well. I'll sort that out later.


It is not possibly to directly format in QString construction?


you saved my workday !
many thanks


You can use $pingback->getProductId() to get the Order id (pls check SDK)
no need check !empty($goodsId) and remove true in validate method


Не стоит перехватывать Exception  (это общий интерфейс для сотни разных ошибок) - старайся более подробно описывать что за исключение возникло, чтобы можно было определить источник проблемы.


`array()`


_At line **15** in **file**_
***
body


added some packages to make the application executable


The opening paren looks misplaced here (and leads to a failing compile since the closing one cannot be found).


Please post it in a bug report, it's better to have it in issues than in commit comments. Thanks!


This will cause memory leak, because you erase a *pointer* from the std::map, but WFNFont itself object won't be deleted.


use `$data['get']` instead of $_GET


yes, of course, thank you!


I'm thinking the documentation needs to be updated too. As part of the "throw runtime_error" at the top of the method.


@PEMapModder Okay. I'll create a pull request when map items and ItemFrames are done.


@jj-lucas Remember travis and protected branches.


Идея подсказывает что эти конструкторы нигде не используются.


|At line _15_ in _file_|
|---|
body


please reference bugs with prefix like "bsc#" for bugzilla.suse.com


I think it would be more intuitive to have the `!` before the profile. Also the profile value would match with the condition value.


I prefer the empty line which separates two logical units, special case for null from the return value.


I do, I develop with 2 different emulators (genymotion, ios emulator) at the same time, one with hot reloading (iOS) and the other (android) i was attempting to use live reload (because i haven't been able to setup hot reload yet :cry: ). I also sometimes connect more devices and use those, to test simultaneously on all platforms.
Is it a big change to support multiple outputs? I think it'd be a delightful use experience to work like that, cheers :beer:


То же самое про ошибки. Их может возникнуть много разных, а обработчик один.


use `$data['get']` instead of `$_GET`


I noticed the changed scope, however the function itself is already scoped... so this additional scope change shouldn't be needed or make a difference.

I am only thinking that the inline functions of the CSingelock or maybe the compiler optimization functions (i mostly use -O3) could interfere here...

My issue (a segfault) indeed has nothing to do with FFMpegCodec but with glDeleteTexture call in guilib/TextureManager class that is also "protected" with a lock/mutex. If i comment out this glDeleteTexture call it segfault one sec later somewhere else.
However, probably similar to FFMpegCodec  there is quite frequent thread synchonization done/needed when rendering with OpenGL. So I am thinking it might be a lock issue, wonder if something is changed here...


ресурсы надо освобождать после использования, а не когда захочется.
последовательность должна быть open - write - [flush] - close, а не close-open-write


at least put a "save_screenshot" here


Have you tested if this is correct, independently? The code looks OK, but I am just lazy to test :grin:


Are you sure the period type of product is the month?


Very minor: I don't know whether you do this later in the PR, but it would be nice to put the `locals` hash onto a single line now that it is much shorter.


undef is not good for Trunk worker, it doesn't filter at all and there could be retired or not ready projects in rdoinfo which should not be built on Trunk.


Опять идея говорит что этот конструктор не используется


fitst commit


We should add more description for each field


nit: if there's an `inProgress` then it's rather a `QueuedTaskInfo` than a `QueuedTaskCount` for me –  it's used in a lot of places so I'm ok if you don't want to rename it now.


= =这样大家就都happy了


che pippa...
3 giorni per attivare 5 links html ...manco mi madre...
¿Qué te parece?


:+1: ¡Genial! :gem:


Sample Commit


Счарапми комметн


сравнение сообщения с собакой не должно возвращать, что собака меньше сообщения.
Для того чтобы compateTo принимал не Object, а Message надо писать
'''java
public class Message implements Comparable<Message> { ... }
'''


It's already a JavaDoc comment. This will make it less clear which one should be used. 99% of the cases it's this and not Truffle.getRuntime().getCallerFrame() for instance.


cloase? typo or intended?


Get merchant name from system configs


Not in the scenery push :confused: :disappointed:


Can this line admit a divide-by-zero error?


where is the public key?


The first try in 0.11 was so weird. "could not tick level world undefined bla", but this code is tested.

I cant test with PM now. Jenkins is down and the src is missing spl

But this code (without this little code style change) is tested and works perfectly.


Or we could just place the screenshot directory one level above the builder directory, i.e:
`global.SCREENSHOT_PATH = path.join(__dirname, "../../../appium_screenshots/");`


The change looks good - but the tense of the commit message is wrong - it should be "Change" not "changed"

coala.readthedocs.org/en/latest/Getting_Involved/Writing_Good_Commits.html


added picture url


не является хэшем и не гарантирует уникальности :)
нельзя такой ключ использовать как id сообщения


啊实打实


done


@LyzardKing
One more question - do you already test this improvement?


@manoj-btc - change variable to `@user_case`


@ThomasGranheim What's the main reason for this approach? What failed with the previous approach?

All lists are created before we're applying fields? Did you want to use the lookup fields in views? If so, it makes sense! So much sense!


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/27942/testReport/) for this commit**


@JohannesPfeifer did you bring in a new version of this file (C) Ben Abbot then modify it? If so, would it be possible to break it into two commits on this branch: 1) The file from Ben Abbot, and 2) The changes you made?


Why there wat no discussion for example in a PR?


oui mais on en a besoin dans TOUT le portail quelque soit le thème c'est pour ça que c'est sa meilleure place si tu pour une raison x on ne les a plus cela affecte le fonctionnement du portail (absence de commande ...)


@manoj-btc - Indentation issues through out.


@steida Reading location from `locationBeforeTransitions` is [discouraged](https://github.com/reactjs/react-router-redux/blob/master/src/reducer.js#L13-L15).

Additional work is needed since Este is using Immutable.js. We have to provide our own routing reducer and have to pass a custom `selectLocationState` to the enhanced history, like:

```js
// /src/browser/main.js

const history = syncHistoryWithStore(browserHistory, store, {
  selectLocationState: state => {
    return state.routing.get('location').toJS();
  }
});
```

Components then could get routing state from the second arguments of `mapStateToProps`:

```js
// /src/browser/app/Header.react.js

export default connect((state, ownProps) => ({
  location: ownProps.location,
  …
}))(Header);
```

All this is good in theory but I have some trouble to make it work though 😶


Whoops, table names instead of table constants :smile:
Actually, shouldn't the test have failed on this? I thought the selenium test deliberately used a completely different table prefix, in order to pick this up. I am sure users are appointed as curators in the tests, so we do test this code.
Could you open a new issue for this? I don't mind if it's resolved later so by no means drop all else you're doing, but having an issue will remind us.
About the query, how about this one?
```
SELECT u.id, u.name, u2g.allow_edit, u2g.show_order
FROM lovd_v3_users AS u
  LEFT OUTER JOIN lovd_v3_users2genes AS u2g ON (u.id = u2g.userid AND u2g.geneid = "BRCA1")
WHERE u.id IN (1, 2, 3) OR u2g.geneid IS NOT NULL;
```
Returns the same results, but is much simpler. I see your way of thinking, but if you use a filter in the JOIN clause, you don't have to use it in the WHERE and you don't end up losing the new curators in the query. The check IS NOT NULL in my WHERE selects the current curators.
Obviously in this one the 1, 2, 3 and "BRCA1" needs to be replaced by proper variables, and we need table constants instead of table names, but this can be run directly in the database so you can check it if you want.


I think 0 is received for root, but OK to replace it with the user. User 0 is root user group 0 is root group


TeamCity Civic Assembly :: Build all [Build 75](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1344&buildTypeId=CivicAssembly_BuildAll&guest=1) is now running


Updated the branch with your feedback incorporated. Let me know if anything else needs updating, I'll start updating Juju to use the changes from this branch.


Channel may differ for user and root for example.


@manoj-btc - Change to `find_by(title: Role::advocate)`


Could you also remove the $db from the comments in the function?
Sorry :sweat_smile:


"artefact", "product", "distribution", "build"


ack


@manoj-btc - As per discussed, use hash sign like `page: params[:page]`. Change it through out


What you mean with the last comment for "()"?


@pgathogo please check how the geometry types are being referenced as what the user selects is not what is created. For example, I selected 'Polygon' but a 'Multipolygon' geometry column was created.


undefined behaviour.... yay


Maybe you meant this to be something like...

```java
if (httpConnector==null) {
    httpConnector = new MavenServerConnector();
}
if (defaultPort!=0) {
    httpConnector.setPort(defaultPort);
}
```


hehe


Huh :/ I didn't get that. Defensive checks on launcher do you think?


@manoj-btc - As above.
- Do not use static per_page. It should be define in en.yml. Fix it.


"artefact", "product", "distribution", "project"


//Esto es una prueba a ver si funcio


build => project


project => build


I'm really sad that we didn't discuss it. Please make such things being talked by community. You can just make a PR and people will see it. Please don't push such things unnoticed next time :(


@pgathogo Please ensure that your code conforms to PEP8 including the maximum number of characters per line, which is 79


@shama: should we add travis and Appveyor for this repo too?


@nursix please review duplicate functions


jspm 0.17 is backwards-compatible so just shim would work for both.


It looks great. And in the same time easy to use and understand. Hope we will be able to cover with test most important parts of Processing soon.

Thanks for your hard work!


**FAILURE** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 332](http://ci.infinispan.org/viewLog.html?buildId=36298&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for 8d4ddefd5fe9d9b28e614d37358fbc90598057a8
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:00:07

Process exited with code 1


I suddenly realize proper grammar would be "unhid user" and "hid user", or? It sounds awkward, but I realize that "unhidden user" and "hid user" is probably not correct, especially compared with "added" and "removed". What do you think?


it should be asset.minify to respect the other classes structure.. see def js


@manoj-btc
- Change variable name to `@user_case`
- use `update_attribute` instead of `update`
https://priyankapathak.wordpress.com/2010/08/21/difference-between-active-record-methods-update-update_all-update_attribute-update_attributes/


looks good. but avalon6 is hardcoded? tar are a lot of model selectable via compile-time-switches. can you grep+add them somehow?


@manoj-btc - Same as above comments.


**FAILURE** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 333](http://ci.infinispan.org/viewLog.html?buildId=36300&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for 3eff1c16fe04582b3f8a447249e97b4785b55c7a
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:00:02

Process exited with code 255


@manoj-btc - Use `@user_case`


thanks!


@manoj-btc - Indentation issues through out


```$zUser``` would be more correct than ```$zStatus```, because it's not data from a status but from a user.


Thanks for the swift reply!  I should have looked at complete source file as first three lines in boards.js do the trick. Good to know you have these travis build set.


I think that copying the test files is way too complex. That would only complicate test run process and possibly introduce more failures than we already have (All those pesky ENOENTRY and EBUSY node errors)


**FAILURE** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 334](http://ci.infinispan.org/viewLog.html?buildId=36302&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for 3eff1c16fe04582b3f8a447249e97b4785b55c7a
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:00:01

Process exited with code 255


First, thank you for doing my OS400 job :-))

The leading digit is a type specifier: it should match one of the definitions CURLOPTTYPE_xxx in include/curl/curl.h. I had to define CURLOPT_xxx this way because ILE/RPG lacks macros.

Thus the line is wrong, because a leading 1 means CURLOPTTYPE_OBJECTPOINT or CURLOPTTYPE_STRINGPOINT. For CURLOPTTYPE_LONG, it should be a 0.

BTW: the OS400 work you've done for CURLINFO_TLS_SSL_PTR is perfect. Thank you.


**FAILURE** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 335](http://ci.infinispan.org/viewLog.html?buildId=36304&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for 3eff1c16fe04582b3f8a447249e97b4785b55c7a
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:00:01

Process exited with code 255


I'm not ok with this solution : we can't reduce the scope of what we test based on performance matters only.
We have to balance tests between : full server/partial server/single component.
Anyway, I have opinions about that and we should discuss it further, but not in this task. We should try  to speedup without reducing test coverage.
So it's a :-1:  for me


Thanks @maxgoebel


第一次作业怎样给老师检查？
Python2.7 windows版在其官网上有，为何老师要我们使用Anaconda？两个软件有什么不同？


canola?


@manoj-btc - What is the meaning of `c`. Name should be meaningful. fix this


TeamCity Civic Assembly :: Build all [Build 75](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1344&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 205 Build time: 00:09:36
### Failed tests
```
Basic Message Campaigns CRUD Actions: Should Add Message Campaign: <no details avaliable>

Basic Message Campaigns CRUD Actions: Should Not Edit Message Campaign: <no details avaliable>

Basic Message Campaigns CRUD Actions: Should Edit Message Campaign: <no details avaliable>

```


@manoj-btc - Leave space after `,`


Hm, I was getting SSL errors and wondered how can I fix this lately. Did you have any insight? Why this change was reverted?


@manoj-btc - Change variable name to `@user_cases`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16994](https://teamcity.mesosphere.io/viewLog.html?buildId=144073&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:04:08


Guests with accepted petitions are not u->flags2.bits.visitor.
They are Units::isOwnCiv but not Units::isOwnGroup https://github.com/sv-esk/dfhack/commit/83c70ccb0f985fac5c7683cd3e01b37e65319258


Typos in commit message:
unodifiable
atempt


chacal


This be a log rather than a print


None is the default, so no need for this here.


Опять неиспользуемая функция, так еще и вместо закрытия ресурсов она удаляет ссылку на них


@manoj-btc - For activate/deactivate operations, It should be separate links. Fix this.


@manoj-btc - Same as above
- leave space after each  `,`


The subquery that reduces the search space most should be the first (table.name == name)


It is good practice to keep format, and white space changes such as this hunk, in separate commits from functional changes.


@manoj-btc - Change variable, Id to `@user_case`


@manoj-btc - Change partial name to `_cases`


lgtm :+1:


Yes, good point! Still caching stuff on the prototype that actually belongs into the instance. I haven't forgotten about a nicer stereo camera and will take care of this issue once I make the PR.


my mistake ,sorry!


@manoj-btc  - What is `"some class here"`? remove if not in use


In order to prevent this nested loop, we could loop through the results straight after getting them from the database (so just once), and set the ID as a key in a new array. Something like:
```
$zUsers = array();
foreach ($zResults as $zResult) {
    $zUsers[$zResult['id']] = $zResult;
}
```
If we need this functionality more often (it's almost a fetchAllCombine(), but one returning more data), we might extend our PDO class with it...? I do think I have had this issue a few times before, with users and genes.


Here can be:
"CLI for running app containers"


Excellent :+1:


По Clean Code:
 - часто встречается неявная область видимости (отсутствуют скобки)
 - обрабатывать исключения надо аккуратнее (без Exception и с подробными сообщениями e.getMessage() например
 - удалять не используемый код
 - использовать типизацию где она есть (Comparable\<Message>)

В целом выглядит хорошо, задание 2.2 принято.


第一次作业不是就是自己先折腾下readme吗，老师不管吧。以后要在readme里给出写好作业的超链接，老师看readme，点超链接检查作业吧。还有那个A开头的什么玩意是Python的运行环境吧，也就不是Linux装Python要先有这个。还有你是谁？

2016年2月24日 19:33于 UncleSandwich <notifications@github.com>写道：

第一次作业怎样给老师检查？
Python2.7 windows版在其官网上有，为何老师要我们使用Anaconda？两个软件有什么不同？

—
Reply to this email directly or view it on GitHub<https://github.com/caihao/computational_physics_whu/commit/adba974930306494dbb8ba3f1fada6733a696666#commitcomment-16293992>.


|`line 18`|
|---|
public void onCreate(Bundle savedInstanceState) {


I agree, especially with that amount of whitespace


Hey @jagajaga, it was discussed over here: https://github.com/NixOS/nixpkgs/pull/13383

I agree that the channel report might not be always accurate, do you have any ideas on how to improve it ?


Role type declaration is redundant here.


To have the GPIO fixed using the `_DSD` property we need:
```
                Name (_DSD, Package () {
                        ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
                        Package () {
                                Package () {"hp-detect-gpio", Package() {^RTK2, 0, 0, 1 }},
                        }
                })
```

In the `RTK2` device.


Really good choice of card name right here, it's really sensible and honestly, I would name my child this.


not sure where to find the com.sebastian_daschner.jaxrs_analyzer.backend.swagger.SwaggerScheme import ?


TeamCity geo-publisher :: geo-publisher [Build 6](http://teamcity.idgis.nl/viewLog.html?buildId=11&buildTypeId=GeoPublisher_GeoPublisher) is now running


This can be removed, I'll add rkt domain to permissive domains in selinux-policy distgit


Deleted this because it was never used.


What's expected output? Hex format? Tried out several random numbers and if this is the case, output is not correct, e.g. for keyIndex = 10;

output:
key_0000000A0000000A

expected:
key_000000000000000A

Could you elaborate?


Change to the network script on the 2nd line


doc useflag isn't used anywhere in the ebuild

jack useflag is only used for portaudio[jack]: it shouldnt be an useflag and people should use portaudio's useflags to setup jack since mixxx itself wont change

pulseaudio useflag isn't used anywhere


I just pushed a first draft of the DR32.
Check it out.
I'm gonna be in the lab this afternoon working on my active touch grasping
algorithm. Anyway, if you need any help, I'll be reachable on hangout and
email.

On 24 February 2016 at 07:27, Carlos J. Rosales <notifications@github.com>
wrote:

> Yep.
>
> Let me know if there are gonna be major changes in the algorithm, so I can
> fix the paper.
>
> Don't worry about the paper, I think I can finish shaping it today for
> Marco and Jeremy submission, and then I could give you a hand with DR3.2.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pacman-project/gaussian-object-modelling/commit/d420f0a344027fe37eeb4fb6097d93f26fec996d#commitcomment-16289376>
> .
>

--
Claudio

Curiously enough, the only thing that went through the mind of the bowl of
petunias as it fell was "Oh no, not again".
Many people have speculated that if we knew exactly why the bowl of
petunias had thought that we would know a lot more about the nature of the
Universe than we do now.
D. Adams - Hitchhiker's guide to the galaxy


does it work with libav ?

it doesn't build with ffmpeg-3 and should probably be fixed too


Did not delete this line because it is easier to read the code by reading MaxRetryError instead of urllib3.exceptions.MaxRetryError. The same for LocationValueError


Thanks, I got the same problem too.


I have an issue now, with this latest change.  My account is an administrator (and site admin).  Prior to the change, I could see all media folders.  Now I don't see any.  I have the `Manage Media` role permission but not the `Manage Own Media`.
Is this as expected?


![screen shot 2016-02-24 at 6 44 09 am](https://cloud.githubusercontent.com/assets/52411/13284400/0cef0106-dac2-11e5-8a65-4364e55752d0.png)
![screen shot 2016-02-24 at 6 44 21 am](https://cloud.githubusercontent.com/assets/52411/13284402/0eb3a28a-dac2-11e5-929d-77eacbaa8f5c.png)


XXX


This is redundant


TeamCity geo-publisher :: geo-publisher [Build 6](http://teamcity.idgis.nl/viewLog.html?buildId=11&buildTypeId=GeoPublisher_GeoPublisher) outcome was **SUCCESS**
Summary: Running Build time: 00:03:28


TeamCity geo-publisher :: geo-publisher [Build 7](http://teamcity.idgis.nl/viewLog.html?buildId=12&buildTypeId=GeoPublisher_GeoPublisher) is now running


Yup, it's set in .travis.yml now.


Sorry, but...what? You select the area by ID, and if it is a template then you select the first area with the same name and event type that is also a template, and then you check whether that's the same area? What in the world is the point here?

If you have the area_id, then there is nothing you need to check about is_template here. The other deduplicator will make sure that templates match templates and non-templates match non-templates - and in this function all you need to check is whether the area_id and the location_id match.

And that again can be done with S3Duplicate, so actually: what is the point with this function /at all/?


isEmpty (wouldn't comment on that, but you're using the method couple of lines later)


Non toutjours pas ...

formValidation.min.css ==> besoin sur les pages formulaire je suppose et oui pour tout les themes ==> pages.php
jquery-ui.css ==> Besoin presque de partout ou il y a des JS...
bootstrap-table.css ==> besoin sur les pages table je suppose et oui pour tout les themes  ==> pages.php

question font-awesome.min.css, on peux aussi avoir envie de changer de webfont donc ==> valide dans l'admin car intouchable l'admin mais pas le reste...

Enfin voila ...
Je pense qu'il est mieux de mettre tout dans pages.php pour changer dynamiquement les css necessaires comme pour les JS

that all

Apres fait comme tu pense


Sorry - you are totally off topic, open your separate forum thread and provide logs and backtraces. It has nothing to do with "O3 optimization" ... it just makes sure that the function behind that is run without that lock.


TeamCity geo-publisher :: geo-publisher [Build 7](http://teamcity.idgis.nl/viewLog.html?buildId=12&buildTypeId=GeoPublisher_GeoPublisher) outcome was **SUCCESS**
Summary: Running Build time: 00:01:15


Why are we choosing to use direct-initializers here instead of initializer-list ?


no need to wrap response in `FeatureCollection`.
`FeatureCollection` is a list of `Feature`
the service shouldn't return a list of location for a given place.
His main objective is to choose the most appropriate one.

Maybe we should use `properties` to return information about type of location (country, city..)
According to twitter, we could use "place_type" attribute

```json
    {
      "type": "Feature",
      "geometry":
      {
        "type": "Point",
        "coordinates":
          [
            2.3488,
            48.85341
          ]
      },
      "properties": {
         "place_type" : "city"
      }
    }
```


Note to self: check why `params[k]` resulted in typing errors and if [try haxe #03291](http://try.haxe.org/#03291) builds successfully on the nightly haxe we're using.


It's an option. But I think if we merge this two reducers we will have a bit cluttered one big  reducer. So this is trade off, but i think the simple code is more important, than one extra property in the state.


Well, you've already detected that vinf->key2 is type CHAR.

This doesn't work for `:mark` and `:k` though, but I'm wondering why this would be necessary. I'm expecting from a command setting a mark that it does set a mark. So why tell?


FUUUUUU


It affects only on the other box-messages, will check it


@oxtoacart It's still not clear what hangs the connection, but I added this test to capture it locally. It succeeded most times, but with larger timeout, a small loop count will cause hanging.


could be nice to add `bbox` attribute (http://geojson.org/geojson-spec.html#bounding-boxes).
something is available in geonames about that ?


What confirmed is that server can always get what client sends, so the bug should be in the read logic, probably in merger. Let me have a refresh to dig more into it...


I see what you mean about the name of the `os_no_consular_cni_countries?` method. I have a feeling it might be more about whether you *need* a CNI to get married in the ceremony country, but it's really not obvious.

@tadast: I don't suppose you could help with this, could you?!


Реализовано на ASP.NET MVC с использованием AngularJS, bootstrap


I agree about trying to come up with more explanatory method names, but I'm happy that it can wait until later.


TeamCity Civic Assembly :: Build all [Build 76](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1346&buildTypeId=CivicAssembly_BuildAll&guest=1) is now running


This is also allowed by default in Fedora.


My five cents. It looks like two different simple reducers would be easier to maintain and use in selectors/components.


Портал для работы с базой данных для агентства недвижимости.
Доступна фотогалерея для каждой позиции, фильтрация.
Реализован на ASP.NET MVC с использованием AngularJS, bootstrap


Requiring libraries that are part of barebones isn't needed


Think: you have a location_id and an area_id - so there will never ever be any other possible match here than a record with the same area_id and location_id. Whether the area is a template or not, that doesn't make any difference whatsoever.

You must make sure that the right area_id is chosen, but that is done by the other deduplicator, not by this one.


Line 40 generates the mail message object however it doesn't send the email.

What's the method call to chain to the end of line 40 to send the email?


@haniokasai My mistake, my local code wasn't up to date


lgtm :+1:


I'm on a tiny screen so can't see the context, but I'd interpret this as an
opposite sex marriage in countries that require CNI and have no consular
facilities.
On Wed, 24 Feb 2016 at 18:50, James Mead <notifications@github.com> wrote:

> I see what you mean about the name of the os_no_consular_cni_countries?
> method. I have a feeling it might be more about whether you *need* a CNI
> to get married in the ceremony country, but it's really not obvious.
>
> @tadast <https://github.com/tadast>: I don't suppose you could help with
> this, could you?!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/alphagov/smart-answers/commit/cb7fd753ed18e8ca6b89899fa66cb71f24fd8910#commitcomment-16294331>
> .
>


I think it might be worth dropping the `ss_` prefix in the underlying data query method name in a subsequent commit to avoid future confusion, unless it's used elsewhere...?


I was going to suggest factoring `if _PY2` out of the function definitions as an optimization. But it's not worth it to save nanoseconds.

    int2byte(42)
    byte2int(b'a')

    Before (ns)
    After (ns)
    Before (ns)
    After (ns)

    python2
    2.7.10
    177.0
    106.0
    120.0
    39.9

    python3
    3.4.3
    455.0
    477.0
    101.0
    87.8

    pypy
    2.6.0
    0.5
    0.5
    0.5
    0.5

    pypy3
    2.4.0
    187.0
    179.0
    0.8
    0.7

All values measured with `$python -mtimeit -s'import compat' 'compat.$expression'`


Реализован на ASP.NET MVC с использованием AngularJS, bootstrap


Hey @jobrs,
Could you take a look?


I'd opt for returning UNKNOWN instead.


[...].toString() is useless. At least, `Arrays.toString()` should be used here


你好啊


I'd prefer it to be an integration test, because real JDBC drivers are used


KISS ... why use uuids or guids when you can use plain names ?

2016-02-24 11:23 GMT+00:00 bmihovski <notifications@github.com>:

> I think 0 is received for root, but OK to replace it with the user. User 0
> is root user group 0 is root group
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bmihovski/puppet/commit/8642eaf774cbf8376416d9c4f22cf31de134dd0f#commitcomment-16293796>
> .
>


good thinking


Setting the max slider option to maxlevel + 1 in LightController.js and DashboardController.js fixes the sliders.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16995](https://teamcity.mesosphere.io/viewLog.html?buildId=144074&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:07


should be either static or method local


> Twin support is still to come.

Is there any progress on this?

I've used this before, but this doesn't work with latest gems.
```ruby
include Cell::Twin
twin Twin
```


don't we need it also after_destroy ?


Same objection as for the set mark message. I'm expecting from a command moving to a mark that it does move to a mark. So why tell?

IMHO, there should be just one issue a patch. Don't mix different _topics_ (like including a bug fix for an other patch).


**FAILURE** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 336](http://ci.infinispan.org/viewLog.html?buildId=36306&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for 3eff1c16fe04582b3f8a447249e97b4785b55c7a
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:00:01

Process exited with code 255


yep, you are right. it is a different issue i see. i didn't notice the function behind the scope operator, sorry. now i understand your fix for the segfault ... tnx for your feedback


typo in `occured`


I follow the same recommendation as for closing streams to throw any errors if setting auto commit fails instead of always ignoring them silently, see https://commons.apache.org/proper/commons-io/apidocs/org/apache/commons/io/IOUtils.html#closeQuietly(java.io.Closeable...)


also, the assertion is not clear. I'd prefer to see `assertEquals(0, si.getErrors())`


Shouldn't we always remove the var from slave state here?


TeamCity Civic Assembly :: Build all [Build 76](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=1346&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **FAILURE**
Summary: Tests failed: 8 (5 new), passed: 200 Build time: 00:09:34
### Failed tests
```
Basic Message Templates CRUD Actions: Should Add Message Templates: <no details avaliable>

Basic Message Templates CRUD Actions: Should Not Edit Message Templates: <no details avaliable>

Basic Message Templates CRUD Actions: Should Edit Message Templates: <no details avaliable>

Basic Message Templates CRUD Actions: Should Not Delete Message Templates: <no details avaliable>

Basic Message Templates CRUD Actions: Should Delete Message Templates: <no details avaliable>

Basic Message Campaigns CRUD Actions: Should Add Message Campaign: <no details avaliable>

Basic Message Campaigns CRUD Actions: Should Not Edit Message Campaign: <no details avaliable>

Basic Message Campaigns CRUD Actions: Should Edit Message Campaign: <no details avaliable>

```


no immediate strong feeling. the `or` sounds clever though also possibly too clever?


Every time I say the same comment like ...

"Use absolute paths"
"Don't write long complex combined commands"
"Mind the interpreter"
"etc"

I will say between parenthesis the times I have already said the same
thing. so (IV) would mean something like:

*"Are you kidding ???? This is the fucking forth time I tell you the same
thing !!!"*

We want to help you, and you could listen to our advises and not repeat the
same mistake.

:D

2016-02-24 11:26 GMT+00:00 bmihovski <notifications@github.com>:

> What you mean with the last comment for "()"?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bmihovski/python/commit/2e2b41898c1dd733faa3acb768081ad90fd15042#commitcomment-16293833>
> .
>


I like the idea, but there are some issues resulting from this patch.

Although _a_ is on top now, _d_ is current and being edited. I would expect _a_ to be current now.

The window commands `^W j` and `^W k` behave conversely now. (I haven't checked other window related commands.)

Nit-picking: Elvis uses the Allman coding style.


@march1993 you mean alternating cameras? I don't think it's a big performance hit...


note to future: kanskje vi får select2 til å laste språkfiler med ES6 eller lignende, så trenger vi ikke vedlikeholde dette ved oppgraderinger av select2?


how do I create it in visual studio?
why is the select saying the syntax "by" is wrong?
Is that the whole database or is it missing more tables?


**FAILURE** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 337](http://ci.infinispan.org/viewLog.html?buildId=36309&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for 3eff1c16fe04582b3f8a447249e97b4785b55c7a
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:00:01

Process exited with code 255


there are similar parts:
```
    Trans trans = new Trans( transMeta );
    trans.prepareExecution( null );

    RowProducer rp = trans.addRowProducer( injectorStepname, 0 );
    trans.startThreads();
    generateData( rp );
    rp.finished();

    trans.waitUntilFinished();
```

Please, remove code duplication by introducing a common method


you only want to replace the last occurence of .txt if it exists, what if there is a nick with .txt in it for some godforsaken reason


I think we leave `is_running()` as is.


I didn't get you point here


map


Sure, thanks Caludio.

Hope the active touch grasping is doing good.


is this still the one used for MDX and SQL?


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/27945/testReport/) for this commit**


Added Deepanshu Kaurav to README


FWIW removing SN should be a major version bump


**FAILURE** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 338](http://ci.infinispan.org/viewLog.html?buildId=36311&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for 3eff1c16fe04582b3f8a447249e97b4785b55c7a
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:00:01

Process exited with code 255


How did you know to include `same_sex` in the method name? Aren't there some countries which allow civil partnerships for opposite sex couples? I see that the call to the new calculator method is within a `calculator.partner_is_same_sex?` conditional branch, but I'm not sure we should be relying on that inside this method.

Doesn't the underlying method mean something different? i.e. that in the ceremony country, a civil partnership is legally equivalent to a marriage?


|`file:15`|
|---|
body


не пишет в базу данных.


@elirenato
Already wrote to clack, copying it here:
I had to modify the third party library a bit there
As it included some trash in XML that is not needed there

But I couldn't find a way to force it not to add with its config or interfaces
Hopefully no harm, as we can't update this library (next version is paid), and this change was only for xml - that is not used when exporting other formats


fait un exemple d'un pages.php idéal selon toi ... car je ne vois toujours pas moi non plus comment réalisé à travers page.php ce que l'on veut ...

question font-awesome.min.css, on peux aussi avoir envie de changer de webfont donc ==> valide dans l'admin car intouchable l'admin mais pas le reste... ==> on ne l'a pas que dans l'admin on l'a de partout .. donc si il y a volonté d'utiliser une autre webfont on est obligé de faire des classes générique ... sinon il faut retoucher à tout le portail ...


I just don't want this library to add declarations to xml, as it produces invalid XML with a lot of garbage. And I see no use in this declarations there. So I added false to make it obvious that it doesn't process this block.


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/27946/testReport/) for this commit**


@olemp The main reason for this approach was that we needed a lookup column that was looking up to a column created directly on the list content type.
`"Lists":
    {
      "Title": "Møtekalender",
      "Url": "Lists/Kalender",
      "TemplateType": 106,
      "Security": {
        "BreakRoleInheritance": false,
        "CopyRoleAssignments": false,
        "ClearSubscopes": true,
        "RoleAssignments": [ ]
      },
      "Folders": [ ],
      "ContentTypeBindings": [ ],
      "Views": [ ],
      "Fields": [
            {
                "SchemaXml" : "<Field ID=\"{7604dadc-d8e3-4f35-bc58-890d33d908b9}\" Name=\"Dato_x0020_og_x0020_tittel\" DisplayName=\"Dato og tittel\" Type=\"Calculated\" Hidden=\"False\" Group=\"Hemit Områdekolonner\" Description=\"\" Required=\"FALSE\" ResultType=\"Text\" ReadOnly=\"TRUE\" EnforceUniqueValues=\"FALSE\" Indexed=\"FALSE\" Percentage=\"FALSE\"><Formula>=TEXT(Starttidspunkt,\"yyyy-mm-dd\")&\" \"&Tittel</Formula><FieldRefs><FieldRef Name=\"Tittel\" /><FieldRef Name=\"Starttidspunkt\" /></FieldRefs></Field>"
            }
      ]
    },
    {
      "Title": "Dokumenter",
      "Url": "Dokumenter",
      "TemplateType": 101,
      "Security": {
        "BreakRoleInheritance": false,
        "CopyRoleAssignments": false,
        "ClearSubscopes": true,
        "RoleAssignments": [ ]
      },
      "Folders": [ ],
      "ContentTypeBindings": [ ],
      "Views": [ ],
      "Fields": [
            {
                "SchemaXml" : "<Field Type='LookupMulti' DisplayName='Hendelser' List='{{listId:Møtekalender}}' ShowField='Dato_x0020_og_x0020_tittel' ID='{A9E9B2C5-ADFB-4987-893D-3927F0F65377}' StaticName='HemEventLookup' Name='HemEventLookup' PrependId='TRUE' Mult='TRUE'></Field>"
            }
        ]
    }
]`


ack


@SimonCropp you do make a good point there! Well, a bit too late now...


lurer på om denne roter til skjulte elementer? får flere scrollbarer med klasse "support-panel" over skjemaet


**FAILURE** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 339](http://ci.infinispan.org/viewLog.html?buildId=36313&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for 3eff1c16fe04582b3f8a447249e97b4785b55c7a
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:02:27

Process exited with code 255


我的意思是如何让老师知道我们的账户，然后才能查看我们写的readme。
这是Python的官网: [https://www.python.org/](https://www.python.org/), 里面提供了Python2.7的[windows版](https://www.python.org/downloads/windows/)，我只想问Anaconda的提供了什么额外的功能.
我是谁不重要，网上最好不要透露自己的真实姓名。


@PedroLamas hence the "FWIW" :)


Moreover - this complicated sequence does merely check whether the cap_area identified by the area_id is the first cap_area template with the same event type and name, and whether the first location_id of that area template is the same as in the item.

And if that is not the case - then what?

It's a link table - so a link with exactly the same keys is the same link. Per definition. In all cases. Period.


I want to contribute to this project.
New to github.


@kangfend  tolong di review yh


why are we removing camverify?


Just why?


**HEAD commit has no message.**
*GitCommitBear, severity 1, section `commit`.* *Project wide.*


You are wrong :stuck_out_tongue: We must wait for each process. I mention about that earlier:
> This piece of code waits for death of all cpu threads

We cannot break loop here, even when we have got exit status.


My mistake for including the misleading quote. To my defense, I thought you were referring to the WMF :flushed:


*확인 완료!*


/cc @maxlazio


@bbannier You are right, thanks!


sure, your version is (imo) better than mine


itertools.product() might be useful... will fix that soon


> New termination condition is when no charts can be expanded

That makes a lot more of sense, thanks.


Done


@kangfend  tolong di review yh,

Saya menmbahkan models ProductFeatured untuk produk yang akan datang, apakah relevaan atau ada ide lain ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16996](https://teamcity.mesosphere.io/viewLog.html?buildId=144075&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:04:12


*호우 확인 완료!*


Maybe refer they are stored at **catalogs**, since this returns nothing


I wasn't able to get "sudo -E make check" to work on my machine (lxd fails to be ready after 300s). But that is true on the lxd-2.0.0.beta3 tag as well. All of the "go test" tests pass for me.


Как лучше назвать метод? Это проверка присутствия тэга по имени в XML?


请问请问


missing @return


perfect match with the writing :+1:, literally I wrote "given either by a higher level module or the user."


oh! i see!


*확인 완료!*


> Having a bool get isPrimitive; would be easier to understand (Structured is not as common a term as primitive when it comes to my knowledge of type systems ^^). And is- as prefix would be more consistent, see https://www.dartlang.org/effective-dart/design/#prefer-a-non-imperative-verb-phrase-for-a-boolean-property-or-variable

Split the interface into StructuredSerializer and PrimitiveSerializer, then we don't need the bool.


missing `@return`


Thanks, this looks much nice.

Done


On Wed, Feb 24, 2016 at 6:46 PM, Dominic König <notifications@github.com>
wrote:

> Sorry, but...what? You select the area by ID, and if it is a template then
> you select the first area with the same name and event type that is also a
> template, and then you check whether that's the same area? What in the
> world is the point here?
>
> If you have the area_id, then there is nothing you need to check about
> is_template here.
>
I was checking the template here. I was not convienced the way I did, so I
asked to review you. Thanks!
ᐧ


Looks like this stops threads even if set to false (see executeOnSlave()). The logic is a bit confusing.


Wozu? Im Receiver funktionierts ohne. Mach wenn dann setAttribute package private. Das ist sowieso sinnvoller als es komplett private zu machen. Ich greif ja aus dem UnixSocketReceiver darauf zu.


Add Is Which menu is active:
  public void CheckActiveMenu(RouteData routeData)
        {
            CheckActiveMenu(Contained, routeData);
        }
        private bool CheckActiveMenu(IEnumerable<MenuItem> items, RouteData routeData)
        {
            foreach (var menuItem in items)
            {
                if (menuItem.RouteValues != null &&
                    menuItem.RouteValues.Keys.All(e => routeData.Values.ContainsKey(e)) &&
                    menuItem.RouteValues.Values.All(e => routeData.Values.Values.Contains(e)))
                {
                    menuItem.IsSelected = true;
                    return true;
                }
                if (!CheckActiveMenu(menuItem.Items, routeData)) continue;

                menuItem.IsSelected = true;
                return true;
            }
            return false;
        }


> Could we add a comment to explain that typeName can be obfuscated but wireName cannot be etc? dart2js obfuscation is something we have to be careful about when writing code here and it helps if we make it explicit here I think ^^

Done, also noted that for built values there are two types, the abstract class and the generated implementation.


Hi! Please see https://github.com/SwiftEducation/teaching-app-dev-swift/blob/master/CONTRIBUTING.md


Issues mentioned in this commit (f95329746aa45d98897decd9c6c1f8e43069a217):

* [Issue #9159](https://bugs.mtasa.com/view.php?id=9159)


Issues mentioned in this commit (4d6215046dfa31dd4f52eaad20dec2f0e9cd1d2d):

* [Issue #9159](https://bugs.mtasa.com/view.php?id=9159)


If if gets no it will instal only HL CS1.6 hlds without mods.
I wonder is it better for it to be "n"


> I'd prefer a {} here when an if-block becomes multi-line ^^

Done.


You wanted that working, so I helped a little ;)


is this description accurate?


et pour la recherche now...... une de methode est -elle deneré pour ça aussi ?


@houtanb I took the file from Octave 4.0, but it is not Matlab code. Do you still want me to overwrite the initial strjoin.m in Dynare with the Octave 4.0 one, before then adding all the changes?


nah i think its more accurate that way

On 24/02/2016, Deyan Dobromirov <notifications@github.com> wrote:
> If if gets no it will instal only HL CS1.6 hlds without mods.
> I wonder is it better for it to be "n"
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Gousaid67/steam-cmd-installer/commit/8bec70c29ad2dedf886d46ffdf00dfc5583922df#commitcomment-16294963

--
Erik

--
This email and any attachments to it may be confidential and are intended
solely for the use of the individual to whom it is addressed. Any views or
opinions expressed are solely those of the student author and do not
necessarily represent those of the Stockholm International School. If you
are not the intended recipient of this email, you must neither take any
action based upon its contents, nor copy or show it to anyone.Please
forward this email to the school IT Office it@intsch.se if you believe you
have received this email in error or if it contains inappropriate content.


Nice work :+1:


try it again！


Why? It's much less clear and much more verbose.
It also prevents easy refactoring.


This is pretty much the whole factorization instead of ~20 unneeded if-fi statements....


我QQ


I can't judge this - why check whether the first info_id is None? Shouldn't this be an ANY-check, i.e. check whether there are /any/ entries with info_id != None?

Same below.


yes


first time we create a repository


This is a dependence, so i moved it here ;)


**FAILURE** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 340](http://ci.infinispan.org/viewLog.html?buildId=36318&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for 3eff1c16fe04582b3f8a447249e97b4785b55c7a
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:01:50

Process exited with code 255


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/27948/testReport/) for this commit**


Why doing this? Without it you won't be able to stop already paused deployments. See the issue from the comment.


This is not working as bzr, git, mercurilal and subversion are not part of the base system. Personnaly, I think they should not otherwise we might endup with endless list of packages in base. We could go on with cmake, qmake, etc. Imagines all the dependencies we would need.


It's already `done = true` in the fixture?


This variable is unused. Possibly you used it to debug?


Usually, BOOST_TEST_MAIN and BOOST_TEST_INCLUDE are in different files.


TeamCity libpalaso :: palaso-precise64-lfmerge Continuous [Build 2.6.10.da9f5c5f85083ffe721200a3bcd06cac562f9747](http://build.palaso.org/viewLog.html?buildId=69573&buildTypeId=Libpalaso_PalasoPrecise64lfmergeContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3377, ignored: 124 Build time: 00:05:13


>This contract (serialized is Iterable if serializer.structured) would be easier to understand and more visible if we simple had a StructuredSerializer interface that returns an Iterable and we used that here
>
>(Even better use an immutable collection instead of iterable to avoid .toList() calls below)

Added separate interfaces, PTAL.

Iterable seems like the right thing to return: depending on the serialization context we need to either return the serialization result directly converted to a List, or with one item prefixed to it indicating the type. Doing that one item prefix would involve an extra copy if we used a list instead of an iterable.


Same comment as before.


Was no check for packet size. This mean safestrncpy can copy data outside of packet and probably outside of buffer.


> That is some weird formatting here ^^

Added braces to the if.


I think the function of the page would be more clear if it is called for example "manage-channels" instead of "channel". So it is quite obvious from the URL that channels can be added, deleted etc(= managed) here. View name, controller name, shuold also match the name you choose here.

Please use a similar naming for positions also.


У меня открыт файл в Logger объекте. Потом по неизвестным причинам хотят открыть новый файл, не закрыв старый.(Например часть кода логировали в один файл, часть кода захотели в другой) Поэтому я сохраню открытый, то есть закрою. Не вижу здесь ничего криминального. При чем если даже нечего будет закрывать, то оно не выкинет ошибок.


I've removed it: https://github.com/Ultimaker/Uranium/commit/46949c29a4b3ff9b97ea6c9b32a0b3458d235d40
I'll continue testing now.


Why? sytem() will search PATH with the old version of just passing "tracker-control -t".


This will fail. http_login_user is not initialized at this point, nor is http_login_password.


Haha!  you did the refactor to use includes in ShaderLib, although I would go a bit further and move the vert and frag shaders that are defined as strings in ShaderLib into chunks themselves.  I hate so much editing strings in JavaScript that are in fact shaders. :)

I think recursion works :)  But there is the risk of infinite loops.  I guess we can deal with that by being careful.  The way to programatically detect infinite loops is to have a stack of currently being included chunks and each time you look to include a new chunk you check the stack to see if you are currently in the midst of including it -- but we probably do not need that type of check
Could we merge the encoding stuff though before you change too many conflicting things?  THat PR is really useful and I believe ready to go. :)


This just disable hw rendering, so the cause of freezing is hw rendering thingl


The initial idea here was that if deleting RS fails we'd keep the deployment in-place for retry. With your change you can be left with orphaned RSs.


Actually, this would be better as "Sólo se permiten %s ficheros adjuntos."


Check THIS out

https://youtu.be/PiqFFk4nOyM


不是关注这个内容了吗，这不是作业内容之一吗，老师能知道谁关注了吧。那个个A什么我也不清楚啊。里面好像有课上说的IP什么的，好吧，我就是不知道。老师你看见了解释一下啊。
你竟然没选这个课😑

2016年2月24日 20:09于 UncleSandwich <notifications@github.com>写道：

我的意思是如何让老师知道我们的账户，然后才能查看我们写的readme。
这是Python的官网: https://www.python.org/, 里面提供了Python2.7的windows版<https://www.python.org/downloads/windows/>，我只想问Anaconda的提供了什么额外的功能.
我是谁不重要，网上最好不要透露自己的真实姓名。

—
Reply to this email directly or view it on GitHub<https://github.com/caihao/computational_physics_whu/commit/adba974930306494dbb8ba3f1fada6733a696666#commitcomment-16294699>.


Please use StringUtils.EMPTY_STRING.


еще раз, файл надо закрывать СРАЗУ после того как закончил работу с ним. Тогда такой ситуации и возникнуть не может.
В такой структуре как у тебя последний ресурс (перед тем как выйти из программы или перед тем как она упадет) не закрывается и как следствие логи потеряются.


Nvmd, I just looked into the 2nd commit.


This is missing a documentation entry (although this parameter should be here for consistency anyway).


The strings should be constants.


I love the changes. gDeveloperMode isolates everything to one spot. Maybe drive it from an environment variable?

From my POV, the only feature missing is extracting from `Tools/extractACPITables.zip` and `Tools/iasl.zip` if they exist. Clearly that’s conditional on gDeveloperMode. I’ll do a fresh PR, since you already implemented everything else...


should fix #71609


How about test case?


@lucianomlima @cash Do you have any thoughts on #9410? This commit caused requests for a specific format to silently send back a different one.


Ну так вот и хорошо. Я ловлю все сразу ошибки. Здесь ошибки могут быть лишь в открытии файла. В лог файл выведу инфу, что не открылось и дополнительно прикладываю инфу ошибки. Не вижу никаких проблем. Будет ошибка открытия - выведет ошибка открытия и инфа исключения. Даже если будет неизвестно что - выведет ошибка открытия и инфа исключения. Ведь пользователь пытается открыть файл, что-то при открытии пошло не так, поэтому в лог и напишется, что не открылось + инфа исключения что произошло не так.


LGTM


@pamval https://github.com/pentaho/pentaho-platform/pull/2820


Was this an accidental change? This change has also affected the regression test artefacts.

If it was accidental, it would be good to remove this change and the change to the artefacts from this commit.


That picture scares me :frowning:!


Maybe refer they are stored at **datasource** since this returns nothing


Please generate new equals, hashcode and toString


Please generate equals, hashcode, toString.


Hello,

this commit is for DiskStorageCache.java

sorry,

Eric


Анализатор кода хорош, но много чего он не понимает. На то это и статический анализ кода. Да, конкретно в этом проекте я не использовал все возможности класса Logger. Анализатор кода из нормального гибкого кода  хочет сделать код, который заточен лишь под что-то одно. Внести изменения в него невозможно.

Я написал класс Logger, который встроил в класс Message. Мой класс Logger очень удобно встраивать в разные классы. Я создаю объект класса Logger и передаю этот объект в тот объект, который мне нужно отслеживать. В итоге я могу отслеживать лишь те участки кода, которые мне нужно.

Logger logFile = new Logger();
// Файл, куда будет вывод логов
logFile.open("log.txt", false);
// Дополнительный вывод логов в консоль
logFile.setDebugMode(true, System.out);

**вызовы методов messages**

// а вот здесь я хочу отследить кусочек кода
messages.logBegin(logFile);
**вызовы методов messages**
messages.logEnd();
**вызовы методов messages**

Этот анализатор кода это как использовать, например, в классе String лишь пару методов. Давайте удалять все неиспользуемые методы из String. В итоге String наш заточен на то, что используется в программе. Внести изменения/дополнить невозможно.


Would the spec for this fail because of these changes?


Thanks for pointing me to Spacejam. I'll play around with it.


В случае такой примитивной программы - может быть. Но сам принцип перехватывания Exception - это плохая практика.

> Я ловлю все сразу ошибки. Здесь ошибки могут быть лишь в открытии файла. В

То, что тут может быть только ошибки открытия файла - не правда. Ты просто не представляешь какие еще ошибки (Runtime) тут могут вывалиться.

> Ведь пользователь пытается открыть файл, что-то при открытии пошло не так, поэтому в лог и напишется, что не открылось + инфа исключения что произошло не так.

Логи создаются не для пользователя, а для тех, кто будет искать почему программа не работает. А для этих ребят нужно подробно описывать, что именно произошло.


Thanks! Pull request for the fixes:

https://github.com/google/built_json.dart/pull/20

On Wed, 24 Feb 2016 at 13:29 David Morgan <notifications@github.com> wrote:

> That is some weird formatting here ^^
>
> Added braces to the if.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/google/built_json.dart/commit/e5a43a3edf96637a6c5972b1b2ecaf4a14649b5b#commitcomment-16295143>
> .
>


possible this commit makes building on unix not possible

``c++
[ 60%] Building CXX object src/game/CMakeFiles/game.dir/PoolMgr.cpp.o
/home/oregon/oregoncore/src/game/PoolMgr.cpp:485:52: error: specialization of ‘void PoolGroup<T>::Spawn1Object(PoolObject*) [with T = Quest]’ after instantiation
 void PoolGroup<Quest>::Spawn1Object(PoolObject* obj)
                                                    ^
[ 61%] Building CXX object src/scripts/CMakeFiles/scripts.dir/EasternKingdoms/BlackrockDepths/boss_ambassador_flamelash.cpp.o
make[2]: *** [src/game/CMakeFiles/game.dir/PoolMgr.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
``


denne skulle vel ikke vært med i committen? ser at disse testene feiler jevnlig og


Change the version property name to the existing one in the global property version list => dependency.pentaho-osgi-bundles.revision


Was no check for packet size. This mean safestrncpy can copy data outside of packet and probably outside of buffer.


2 spaces


this commit might break the compile on unix

[ 60%] Building CXX object src/game/CMakeFiles/game.dir/PoolMgr.cpp.o
/home/oregon/oregoncore/src/game/PoolMgr.cpp:485:52: error: specialization of ‘void PoolGroup<T>::Spawn1Object(PoolObject*) [with T = Quest]’ after instantiation
 void PoolGroup<Quest>::Spawn1Object(PoolObject* obj)
                                                    ^
[ 61%] Building CXX object src/scripts/CMakeFiles/scripts.dir/EasternKingdoms/BlackrockDepths/boss_ambassador_flamelash.cpp.o
make[2]: *** [src/game/CMakeFiles/game.dir/PoolMgr.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....


На то и есть метод закрытия файла close(). Если человек написал закрытие, все норм. Если он не закрыл старый файл и открывает новый, то оно закроет старый. Как по мне, это очень даже продумано, чтобы не терялись логи.


Use the same name of the global property list => dependency.common-ui.revision


@ThomasGranheim Merged into master


You may take a look at how the corresponding asm functions are already implemented in FastMM4.pas trunk.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16997](https://teamcity.mesosphere.io/viewLog.html?buildId=144086&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 237 Build time: 00:03:58