I've removed 2181 from ELB because people are misusing it. From time to time ELB marks nodes as unhealthy for some unknown (for me) reason and if you are working with zookeeper via ELB you will loose the session...
If such behaviour is not critical for your application and you are aware what you are doing, it's always possible to add this port manually, either by modifying template or just in AWS management console.


I can extract the logic into a callable method, but how will we go about PR dependencies on different repositories?
Since that method will be in PR for thebuggenie repository and PR with action calling it from this module will depend on it being merged.

This could be solved by requiring specific version of modules through composer, though that brings more questions (as we discussed before on IRC). Other way would be that contributor makes PRs from branches, links them so that maintainer knows to merge both.


All similar tasks (prepare, set session, reset session) need to go to the server for validation, and then the client does things in response to the headers it gets back saying it should add/remove the variables or statements.  It would be strange for deallocate to have to take a different path.

It also might validate assumptions of the client.  The client sends requests to the server, and gets responses back.  It does things as a result of what it gets back (ideally just returning the results to the user, but we have it keep session state too due to server limitations).  But it's probably not expected to do things as a result of its own queries.


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (957 of 957 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.87%25-green.svg)


Could be const


you are right, created issue about doc: https://github.com/os-autoinst/openQA/issues/528

https://github.com/os-autoinst/os-autoinst/pull/410/files#diff-bd61f4009ce05bc0647daf1170d6facaR250 is a bit clearer on this but unfortunately the doc between testapi.pm and the document in openQA is not entirely in sync.


ไม่ต้องใช้ table ก็ได้  แต่อันนี้ใช้ให้มันดูง่ายจ้า


WE seem to have lost the tab character following the COST tag in the Silver entry.


The next() function will requires Python 2.6 or greater.  pyproj's docs say it supports Python 2.4 and up. (I'm uncertain of the value of supporting Python 2.4 and 2.5.) However, you might do something like this as a workaround.

```Python
try:
    try:
        fst_pt = next(it)
    except NameError:
        fst_pt = it.next()
except StopIteration:
    raise ValueError("iterable must contain at least one point")
```


It looks like there's no tab following the COST:0.1 in the Silver entry.


adding the otherwise missing GUID to the calibration ROOT file


Yes, you are right. We'll do that in future!


I see, thanks.


In a second look, I saw that you have sacrificed the ability to accept a MenuItem. But it's good for a first iteration. As I have more time we can try to see the available options.


I don't think you need `groovy-json` if you already have `groovy-all`


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26945/testReport/) for this commit**


Thanks for pointing that out.


If my other comments are addressed, this whole function could be reduced to a macro that wraps a call to gpio_init().


I don't know if this applies in this context. But if so, can the result of that query be stored in memory for other modules that use the exact same queries don't repeat the query. Something like:

```php
{
     // To avoid doing duplicate database queries.
     static $tags = array();

     $tagsKey = md5(serialize(func_get_args()));

     if (isset($tags[$tagsKey]))
     {
          return $tags[$tagsKey];
     }

     // Rest of code

     $tags[$tagsKey] = array();
     foreach ($rows as $row)
     {
          $tags[$tagsKey][$row->content_item_id][] = $row;
     }

     return $tags[$tagsKey];
}
```


Component boxes


Ah of course. That makes a lot of sense. Thanks for the explanation!

> On Feb 1, 2016, at 2:57 AM, José Valim <notifications@github.com> wrote:
>
> If the string is only made of whitespace characters, lstrip is enough to find out so. The benefit is that, when the string is not blank, we won't traverse to its end to remove whitespace that won't be used for anything.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/elixir-lang/ecto/commit/1717871ccff0bf8c05718539ea71c378ee98f8b4#commitcomment-15792302>.
>


@K-Guan Same to you.


I get this warning, not important, but not sure how to make it disappear... should it be ENDIF(GCC_VERSION VERSION_GREATER 4.7 OR GCC_VERSION VERSION_EQUAL 4.7) maybe?

```
CMake Warning (dev) in CMakeLists.txt:
  A logical block opening on the line

    /home/yorik/Sources/FreeCAD/CMakeLists.txt:67 (IF)

  closes on the line

    /home/yorik/Sources/FreeCAD/CMakeLists.txt:71 (ENDIF)

  with mis-matching arguments.
This warning is for project developers.  Use -Wno-dev to suppress it.
```


[No more unicorns](https://www.youtube.com/watch?v=uLxpko00


For the sake of the "audit trail", I fixed the error but for some reason despite using my account details when committing it still attributes the work to Simon.
He's always taking credit for my work (joking)


saw approval from mrallen1
at https://github.com/basho/bitcask/commit/a35d6d67fb320c4860f5e1a9ff4ecb56d517d5de


merging basho/bitcask/im/bugfix/bitcask-file-process-leak = a35d6d67 into borshop-integration-229-im/bugfix/bitcask-file-process-leak


basho/bitcask/im/bugfix/bitcask-file-process-leak = a35d6d67 merged ok, testing candidate = 9fbd9b4b


I think it would be clearer if the interface used a GPIO device offset instead of a pin offset that must be a multiple of GPIOS_PER_PL061.


the series does not end my good friend however did not put extra code. I speak spanish sorry for my english :D

> El 01/02/2016, a las 8:01, Ranie Rodriguez Santos <notifications@github.com> escribió:
>
> Hi there, I just wanted to ask if this is the complete code (no lacking code, no extra code) of the social network series (codecourse)
>
> —
> Reply to this email directly or view it on GitHub.
>


Should we remove the functionality to close the search whenever clicked outside of the searchbox and just keep the close search button?


This is a bit tricky because production GFE doesn't support 4K (even though it may advertise support for it in serverinfo). It fails later in the RTSP handshake.


hahahaha dude that's hillarious lmfao

Date: Mon, 1 Feb 2016 06:08:37 -0800
From: notifications@github.com
To: SergeFault@noreply.github.com
CC: julian_carlson@live.com
Subject: Re: [SergeFault] fuck off dumb 32bit shit (fc00e2d)

hey you're on my instagram

https://www.instagram.com/p/BBPwYnksjZm/?taken-by=lettherebecode

lol

—
Reply to this email directly or view it on GitHub.


Script : cambiar nombre a Zenity.sh


I was thinking about caching the data, too, However, it seems from the original PR, the author said that show tags is not used in the modules, that means cache is not needed in this case.

I haven't worked with tags (just know about it), so I don't know exactly whether this method is used in the modules not


4 space tabs . . .
![haram](https://cloud.githubusercontent.com/assets/12195202/12720861/dd575da2-c8ca-11e5-8f80-dcd00a092288.jpg)


I second @rvagg


i see and if using `JHelperContent::getCurrentLanguage()`?


Instead of checking all 4 at once, should check each individually and clear the transfer state after each:
        runner.assertAllFlowFilesTransferred(FetchElasticsearch.REL_RETRY, 1);
        runner.clearTransferState();
This will allow the user to know which exception fails without needing to debug or write more code.


ok i understand


Comment should be changed to say it routes to failure.


@v-sky So good luck.


plus Übernahme der Quotenr. für Bestellungen implementiert.


I think the `JsonFile.java` could instead be `JsonFile.groovy`, and be put into `src/main/groovy`. It would also be much less code :grin:


Sowohl EK (angepasst) als auch VK (neu) Rabatte


The replaced body is in self.tr.value(), but I'm quite unsure about how to get the StringProducer to output into the ``body = yield readBody(r)`` statement without changing anything in ``http_proxy``
I see what you mean about closing the StringTransport, but how do you do that if it needs to send it as part of the response while it is still connected?


nasıl


Take a quick look at the method and it works good. So Yes, we can use JHelperContent::getCurrentLanguage() (is the class auto-loaded) and make the method become static


Un error que cometi en todo el script es el uso de " ( ) " en la definición de cada función. Trata de ir eliminandolos por que no son necesarios.


whaaaaaaaaaaaaat


Great to see you're making improvements to Sharp!

Beware that you're mixing up two concepts here: IdToColor and ColorReplacement. These APIs were carried over from svg-android, and to clarify, they provide the following functionality:
- `setIdToColor()` provides a way to replace the color of any element that has a specific ID. For instance, you can provide `setIdToColor("cartman_hat", getColor(R.color.hat_color))` to replace the color of the hat element.
- `addColorReplacement()` is related, but instead provides a way to replace colors altogether. If the `searchColor` is found, it is replaced with `replaceColor`.

I've updated the documentation and improved the method names in Sharp's develop branch; you may want to merge with that.


Oh wow. How much did the RAM usage increased due to the conditional access?

Sorry for the inconvenience.


Please help me create a variable to compare at this point


Perhaps it would be better


Good question! We will end up having code based in part off of theirs in the app in places, though I don't know how much will get re-used. I'll have to check with the team and see what we think about that. Thanks.


Este script solo muestra el Menú principal en Zenity no ayuda al rooteo


Why change quotes to angle brackets? Although they are probably interchangeable, I think quotes are more appropriate because this is not a system header. Same below.


> Oh wow. How much did the RAM usage increased due to the conditional access?

After or before this change? Before this change I couldn't measure it as the OS always killed it and afterwards I didn't care as it was very similar to before :)

> Sorry for the inconvenience.

No need to sorry :) Thanks for you work :) !!


Sorry for that :dancers:


перед хедером нужно открыть container который закроется после закрытия футера он нужен для резиновости


также просто див


лейблы с инпутами обернуть в обертку с классом price-controls


дать класс


grey нужно удалить у блоков и дать доп классом всей обертке, т.е перенести в строку 62


карту лучше внести в футер на консультации объясню зачем


Should probably just fix this now?


That sounds fine then.


I see your point - if a PR on this repository is dependant on a PR on the main repository, simply reference it in either direction (from either PR to the other) so it's obvious. Feel free to extract it, or else I'll do it. That wasn't a threat, btw :)


It seems like this could be more efficient.


@jwillemsen this link is probably not right


all tests pass:
success: http://buildbot.bos1/builders/test-bitcask/builds/570


The Lifeforms where using angle range from -180 to 180 before too. fixFuckedUpAngle() was only used in modern control type (move violet relative to arms angle) and <i>this</i> works with the above angle range too.


fast-forwarding 2.0 to borshop-integration-208-bugfix/increase_erl_max_ports_default = 6fd48818


Possibly this line should also be changed — not sure what it is for though so have left it as is.


in reality i think `getCurrentLanguage()` should be a static method of `JLanguageHelper` (https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/language/helper.php) ... but that is another talk :)


Будет, завтра :)

пн, 1 февр. 2016 г., 17:40, Maxim Orlov <notifications@github.com>:

> А как же Icon Cache?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/RussianFedora/deadbeef/commit/053aa9a117d0f8d008490da97391e8e60f572e6d#commitcomment-15800546>
> .
>


Suggestion (perhaps for the future): might be nice to separate these out as generic deployment tests. Would reduce the size of this function and make things a bit more readable-reusable.


Looks good


Not sure if you are answering my question.
Let me rephrase it: in this particular case, the warnings were only coming from the missing `@param` and `@return`?
Because if it's only that, I would write the missing info rather than removing the whole Javadoc.


That actually long for a local variable, especially in a small loop. How about "entry"


I don't think this works in quite the way expected.

After merging this change pressing the fork button does not work on any page!


The parser doesn't have that information.  It happens in the SqlQueryManager.  I wasn't sure how to add unit tests or integration tests for it because Presto currently has no tests for the SqlQueryManager.  All the AbstractQueries tests have test query runners to bypass the query manager.    I was going to add tempto tests when this was done.


On closer observation, the thumbnail's padding causes it to stick a little bit outside of the border to the left. I would add some left padding, but that would likely look awkward after the page has "collapsed" for smaller screens.


I was trying to find the method from the class you mentioned :). Don't know why we have different methods like that in our codebase, if it is possible, maybe you should make a PR for that change


I didn't think it should have been - it until I read it later ^_^


> afterwards I didn't care as it was very similar to before :)

Nice. You'r welcome :)


It's a bit different. MAX_GPIO_DEVICES are used in a few different places, especially used in struct definition. If we want to wrap the MAX_GPIO_DEVICES in struct definition, we have to add a new macro in platform.mk.

It seems that we add a new limitation on reference pl061 gpio driver into platform. Without macro in platform.mk, we can't make pl061 gpio driver to pass the build. So I think it's a bit complex, isn't it?


After the current tests finish, lets see if we can un-pending this


I don't see the License for Mockito anywhere. Was it already included?


wuatttttttttttttt


Yep, exactly right.


> Could we stick to ES5 semantics in this change?

All of the other adapters have followed this model where we use ES6 for the adapter implementation even if other places in the code use `extendable-base` or hand-crafted ES5 objects.

Since, as you said, we want to move this whole codebase to ES6 at some point (soon?) my preference would be to leave this as-is and then you can follow up with the big change for the rest of the internals as opposed to having this adapter follow a different implementation model from the others.

> The change of the name to ReadInflux is also not necessary (or should be in a separate commit).

Again this is consistent with what we've done in other adapters. It's useful to have unique class names since they show up in stack traces -- I don't have a problem splitting into a separate commit but it doesn't seem like it adds much except noise to the history.


Yep. One piece of the puzzle at a time :smile:


Got it, thanks!


сюда бы два отступа


и сюда


@dka-odoo so it's not a migration back to the old API, it's a missed rebase of 5a6e136172c14dd7340f3f073c00fdf8b0ce4a2c, so I can not trust this code...


Hey you didn't  describe what you did this time


Added bold tags to the final smiley face. Took a while to find this one!

not.


The comment should be removed here because the code it refers to has been moved to `testCxx11.cmake`.


Thank you!  It is very rewarding to organize and think about code in this way.  I look forward to seeing how it will be used.


:heart:


sure


First. Ever.


Jangan lupa Follow @zhiephie


Decided to spice it up a bit.

Very little bit. But hey, it's a proof of concept, right?


:metal:


TeamCity DNN JavaScript Libraries :: CI [Build 139](http://teamcity.engagesoftware.com/viewLog.html?buildId=417&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 139](http://teamcity.engagesoftware.com/viewLog.html?buildId=417&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:8


recette-retraite.sgmap.fr est l'environnement de "recette", la prod est là (enfin pour l'instant) : retraite.sgmap.fr


Minor thing, but I find an `if not` with an `else` a bit counter-intuitive


Would it be preferable to try and divorce the transport layer (in this case SSH) from this function? I.e. deal with stdin/stdout and have a pre-function set that up for you?


@ebrehault Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/30//violations
```
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/content.py Imports are incorrectly sorted.
src/plone/api/content.py:0:1: I001 found unsorted imports
src/plone/api/content.py:98:13: Q000 Remove bad quotes.
src/plone/api/content.py:99:13: Q000 Remove bad quotes.
src/plone/api/content.py:100:13: Q000 Remove bad quotes.
src/plone/api/content.py:268:1: C901 'delete' is too complex (15)
src/plone/api/content.py:300:25: Q000 Remove bad quotes.
src/plone/api/content.py:322:25: Q000 Remove bad quotes.
src/plone/api/content.py:360:1: C901 '_wf_transitions_for' is too complex (12)
src/plone/api/content.py:454:17: Q000 Remove bad quotes.
src/plone/api/content.py:455:17: Q000 Remove bad quotes.
src/plone/api/content.py:482:17: Q000 Remove bad quotes.
src/plone/api/content.py:521:13: Q000 Remove bad quotes.
src/plone/api/content.py:522:13: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/env.py Imports are incorrectly sorted.
src/plone/api/env.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/portal.py Imports are incorrectly sorted.
src/plone/api/portal.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/user.py Imports are incorrectly sorted.
src/plone/api/user.py:0:1: I001 found unsorted imports
src/plone/api/user.py:70:13: Q000 Remove bad quotes.
src/plone/api/user.py:71:13: Q000 Remove bad quotes.
src/plone/api/user.py:357:37: Q000 Remove bad quotes.
src/plone/api/user.py:400:37: Q000 Remove bad quotes.
src/plone/api/validation.py:20:13: Q000 Remove bad quotes.
src/plone/api/validation.py:21:13: Q000 Remove bad quotes.
src/plone/api/validation.py:22:32: Q000 Remove bad quotes.
src/plone/api/validation.py:66:21: Q000 Remove bad quotes.
src/plone/api/validation.py:67:25: Q000 Remove bad quotes.
src/plone/api/validation.py:96:21: Q000 Remove bad quotes.
src/plone/api/validation.py:97:25: Q000 Remove bad quotes.
src/plone/api/validation.py:127:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:45: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/base.py Imports are incorrectly sorted.
src/plone/api/tests/base.py:0:1: I001 found unsorted imports
src/plone/api/tests/base.py:32:47: Q000 Remove bad quotes.
src/plone/api/tests/base.py:60:28: Q000 Remove bad quotes.
src/plone/api/tests/base.py:62:28: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_content.py Imports are incorrectly sorted.
src/plone/api/tests/test_content.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_content.py:137:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:271:37: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:879:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:880:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:881:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1015:17: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1024:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1025:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1026:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1027:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1028:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1029:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1030:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1031:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1032:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1033:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1034:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1035:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1036:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1037:13: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_doctests.py Imports are incorrectly sorted.
src/plone/api/tests/test_doctests.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_doctests.py:120:13: T001 print statement found.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_env.py Imports are incorrectly sorted.
src/plone/api/tests/test_env.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_env.py:30:14: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:31:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_group.py Imports are incorrectly sorted.
src/plone/api/tests/test_group.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_portal.py Imports are incorrectly sorted.
src/plone/api/tests/test_portal.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_portal.py:61:16: P002 found "hasattr", consider replacing it
src/plone/api/tests/test_portal.py:125:41: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:125:57: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:163:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:164:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:194:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:204:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:213:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:214:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:215:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:229:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:230:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:251:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:252:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:253:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:272:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:273:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:279:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:289:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:290:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:299:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:311:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:312:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:336:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:337:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:338:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:345:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:346:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:347:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:524:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:535:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:544:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:582:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:614:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:615:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:616:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:617:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:713:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:747:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:748:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:749:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:750:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:785:32: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:787:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:788:38: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_user.py Imports are incorrectly sorted.
src/plone/api/tests/test_user.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_user.py:641:20: Q000 Remove bad quotes.
src/plone/api/tests/test_validation.py:37:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:40:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:65:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:70:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:74:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:79:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:84:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:91:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:98:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:123:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:124:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:131:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:132:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:133:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:159:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:160:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:165:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:166:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:167:14: D001 found assertEquals replace it with assertEqual
```
You can run that yourself using buildout.coredev ``experimental/qa.cfg`` config file.


The simple 'json' representation doesn't do any representation.
This is by design - there are usecases for both but the simple 'json' format doesn't have the capability to include both represented & unrepresented in the output.
The more complex 's3json' does have this capability, but of course is more complex.
I think what you need to do is to specify the name field in the list_fields, so:
cap_info.event_type_id$name
(I've not tested whether this works or not)


This equality should check for a different number.


@webknjaz: actually we  **have to**. But to do that we need to do deep refactoring of both clientside and admin as well as reconsidering the whole project.


Why not use ASSERT_TRUE(std::isnan(output.points[0].x))?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26952/testReport/) for this commit**


Great - much nicer :+1:


TeamCity LabKey :: Trunk :: Community :: CDS postgres 9.5 [Build 85](https://teamcity.labkey.org/viewLog.html?buildId=300295&buildTypeId=LabkeyTrunk_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 15, passed: 33 Build time: 01:09:18
### Failed tests
```
org.labkey.test.tests.CDSLoginTest.testSessionTimeoutIntercept: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogAndLinearScales: <no details avaliable>

org.labkey.test.tests.CDSHelpCenterTest.verifyHelpCenter: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyCounts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

##### there are 5 more failed tests, see build details
```


Prvi commit


We do not use this value anywhere, hence we do not need to pass it to somewhere and validate.
All you need to pass to backend is the `authorization_code`, which you received from google API


so it looks like you have missed 94900dda501656300e183289d1dfa16dfd0ee5b8 as well


Sorry to dredge up old commits, but is there a reason we aren't also be passing the `$category` with this?

`<li <?php wc_product_cat_class( $category ); ?>``


Is there a particular reason why this was removed?


You are not fully in the minecart yet. Positions are wrong. When you go out of the minecart, the minecart vanishes.


Same as Fetch: Instead of checking all 4 at once, should check each individually and clear the transfer state after each:
runner.assertAllFlowFilesTransferred(FetchElasticsearch.REL_RETRY, 1);
runner.clearTransferState();
This will allow the user to know which exception fails without needing to debug or write more code.


Same as Fetch: Comment should be changed to say it routes to failure.


Somehow this sent me to merge-hell.  I do not know why they did not merge into master without conflicts in my case.  Maybe it was just a git problem, that I had a file which was not registered with git in my test directory, and which got registered by some other patch I pulled together with this patch.  Anyway, I am now switching to commenting this out with block comments, to avoid large conflicts (involving many lines).


Thank you!


add .settings/


This selector should be moved to the sidebar specific sass.


![screenshot](https://cloud.githubusercontent.com/assets/1310400/12721412/64d46e9a-c908-11e5-9654-df45a9eb8cb7.png)

In dev mode Chrome shows an error for this key. This isn't visible in normal mode though and doesn't influence the functionality but I'm quite sure we'll have quite a few "bug" reports on that in the future.

I guess it can be solved with a build script: the main manifest won't contain this key, there will be a manifest.firefox.json with just this key, the build script will insert it into the main manifest and put it into a folder named build or firefox or whatever.


@tangyan


Faltan las clases


Entities now is reordering fine, just one thing is left, and that is when remove some entity. I try to make some changes in removeItemSubmit, but seems to $form_state wont save my ordered entities with $form_state->setValue('selected', $ordered). I need little help with that or some suggestion.


If you feel motivated, some temporary variables would make this a lot clearer, but I don't demand more work of people doing cleanup.


Des outils et des méthodes au service de la modernisation de l’action publique dans l’Éducation nationale.


Should be `seegno/docker-bitcoind`?


janvier 2015


I need some help grabbing the live feed addresses. Do you know how to get the magic number from: http://open.live.bbc.co.uk/mediaselector/5/select/version/2.0/mediaset/pc/vpid/bbc_radio_one/atk/MAGIC_NUMBER/asn/1/


Again, not for this change, but we should have a method that generates this HTML.


pierre@pezziardi.net


`bitcoind`.


Debug statement? :joy:


What should this correspond to? the SR of the root disk?


Please rename the block typedef to match.


What does the span class do?


TeamCity Civic Assembly :: Build backend + frontend [Build 50](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=622&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


111411352_ATDeprecateFields (mjwitte) - x86_64-MacOS-10.9-clang: OK (2055 of 2055 tests passed, 0 test warnings)

 * 546 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TeamCity LabKey :: LabkeyModules15.3 :: Git postgres 9.4 [Build 104](https://teamcity.labkey.org/viewLog.html?buildId=300290&buildTypeId=LabkeyModules153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 15, passed: 278, muted: 1 Build time: 01:35:57
### Failed tests
```
org.labkey.test.tests.DataFinderTest.testStickyFinderFilterOnDataset: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyParticipantCounts: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSearch: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.tests.CDSLoginTest.testSessionTimeoutIntercept: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

##### there are 5 more failed tests, see build details
```


Keep in mind that `_.shuffle` returns a new array!


Recherchez une formation efficace pour votre retour à l'emploi et découvrez les financements possibles.


Thanks!


It just seemed to me that it was something logical to tidy up - removing static state where possible. I think if we do some complex multi-tennant stuff in the future then we may want to set some options per-context.

But even if you disagreed, it needs to be the same for all the options, not just one of them.


regis.greau@pole-emploi.fr


1er mai 2015


g라는 변수로 뺏으나 g 변수를 사용하지는 않는거 같은데, 변수로 뺀 이유가?


The <span> tags are for the icons in the navbar buttons


The reason I wrote the comment above is because these methods mutate the collection whereas `shuffleDeck` returns something totally new. Consistency in (im)mutability will save you from some annoying bugs later.


Returns new array.


Instead of doing `mkdir -p`, can you try adding the directory to cloudstack-management.install file? Because commit 225a41251334d193fce3182fc8ffdc754b15dd24 should already handle this. But probably the path is missing from the install file, which means the Debian package build does not actually pick up that it needs to make this directory.


@malirod for what?


Sorry to hijack this thread, but I wonder if it would be reasonable to add some sort of metadata to each listing which includes whether a package falls into various categories:

- Production-ready
- Tested
- Actively maintained
- Abandoned
- Experimental
- A "throw-away toy repo"

It may be reasonable to let the community compile this data (possibly a google docs form or sheet?) by asking on julia-users for assistance in filling in the blanks for repos that they have personal experience with.

I find that this repo is such an enormous help in searching out new functionality, but that it can take a long time to evaluate which packages are worth looking at.  Also I too have a couple repos on here that are in various states of usefulness, and it can feel strange to have them on here without context.


certificate either exists or not


[![Build Status](https://travis-ci.org/maxvodo/bitbucket-pullrequest-builder-plugin.svg?branch=master)](https://travis-ci.org/maxvodo/bitbucket-pullrequest-builder-plugin)


Hi guys;
I want to auto scroll the page down and up when the draggable elements are dragged towards the ends (up and down) of the page something like; **scroll:true** here
```
dragula({
        copy : dragulaCopyFunction,
	accepts : dragulaAcceptsFunction,
	removeOnSpill : true,
	scroll:true
});
```
Is this possible with dragula and if yes, how can i do this?


I thought axiomatizing `sq` seemed artificial, so I made `x^2` notation for `x * x` instead. Then neither `pos_sq` nor `log_sq` were necessary, since `x * x` matches `pos_mul`, and we can get `log_sq` in two steps using `log_mul` and `mul_two_sum`. Note that it generates more instances and is a little slower, in part because now we match `mul_two_sum` in both directions.


Hah, indeed. Good catch. I'll fix that after work.


OK pour moi avec les remarques.


My apologies.


TeamCity Civic Assembly :: Build backend + frontend [Build 50](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=622&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests failed: 88, passed: 42, ignored: 4 Build time: 00:05:14
### Failed tests
```
Document type tests: Should not create new document type if cancelled: <no details avaliable>

Document type tests: Should add new document type: <no details avaliable>

Document type tests: Should not change document type: <no details avaliable>

Document type tests: Should change document type: <no details avaliable>

Document type tests: Should not delete document type if cancel pressed: <no details avaliable>

Document type tests: Should delete document type: <no details avaliable>

Document tests: Should take a alert when try to upload new version for locked document: <no details avaliable>

Media type tests: Should not create new media type if cancelled: <no details avaliable>

Media type tests: Should add new media type: <no details avaliable>

Media type tests: Should not change media type: <no details avaliable>

Media type tests: Should change media type: <no details avaliable>

##### there are 78 more failed tests, see build details
```


Trouvez les entreprises qui vont recruter près de chez vous.


I am testing Pull Request


The "n" in "no" should be capitalized.


The contract (which should really be written down somewhere see https://github.com/juttle/juttle/issues/304) is that the adapter should read no more than `limit` points between `from`, and `to`. If the full amount couldn't be read in one batch, the adapter can return paging state in the `state` return, and not include `readEnd`. This way the base class will call back into the adapter to continue the current batch.

In the case of influx, this would mean querying again for the same time range but specifying an offset, or doing this by advancing the time ranges forward (being careful to handle a lot of points with the same timestamp).


1er mai 2015


eric.barthelemy@pole-emploi.fr


Ok avec les remarques. Merci pour ces PR !


Ampersand needs to be `&` here.  This may be a hold-over from the port but it's something that needs to be done.


> Don't know why we have different methods like that in our codebase

i think that all depends of who made the PR.
Maybe because, a change like this has to be done in joomla framework (https://github.com/joomla-framework/language) too.

There are a lot of language methods in the codebase that IMHO should be moved to static methods in JLanguageHelper.

- JLanguage::getMetadata() --> JLanguageHelper::getMetadata();
- JLanguage::getKnownLanguages() --> JLanguageHelper::getKnownLanguages();
- JLanguage::getLanguagePath() --> JLanguageHelper::getLanguagePath();
- JLanguage::parseLanguageFiles() --> JLanguageHelper::parseLanguageFiles()
- JLanguage::parseXMLLanguageFile() --> JLanguageHelper::parseXMLLanguageFile()
- JLanguage::exists() --> JLanguageHelper::exists();
- JHelperContent::getCurrentLanguage() --> JLanguageHelper::getCurrentLanguage();
- JHelperTags-->getCurrentLanguage() --> JLanguageHelper::getCurrentLanguage();

and maybe more ...

> if it is possible, maybe you should make a PR for that change

Maybe i will make a PR for that when i have time. And let's see if the community accepts it :)


Same deal here - the ampersand needs to be `&`.


## Task 1

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 2

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 3

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 4

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 5

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)
- [ ] Program is different than [Task 4](task-4) (1 pt)

## Task 6

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (3 pts)


It turns tokens off completely because $cfg is empty at compile time.


Since I upgraded to 14.1 all my elements have the red text 'DEPRECATED ELEMENT WILL SOON BE REMOVED'. It is not clear to me what will happen to my drawings after upgrading to Umlet 15. Should I replace all my elements in all drawings, or will they be converted automatically?


Also the flowfile for which this is failing should be added to the error message too.


Тут мы на что проверку делаем? Если `a` будет строкой `"true"` — мы пройдём проверку?


should use the newer [mode agnostic specs](http://www.candlepinproject.org/docs/candlepin/mode_agnostic_spec_testing.html)


:D
On Feb 1, 2016 7:08 AM, "Modmuss50" <notifications@github.com> wrote:

> Update JSON-Destroyer to make @TheDoctorSoda happy
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/modmuss50/Steamcraft2/commit/03edc40182acd635acc67656affa66f6ba059eff
>


How did that go? Concerning first fallbacks quality?


This looks a bit temperamental to me... would it not be better to have a function call that returns the template? to save having to reference the file on disk? (the library call could reference a local data file in the package).


This can be simplified to `_add_ns('.//AdaptationSet')`.


Unfortunately between the time you started to rebase this branch and now I landed a refactor of how the SettingsTableViewController works :( . Instead of all of the settings living in this class I've pulled out the specific setup steps for general settings screen into AppSettingsTableViewController. Inside that subclass we have these methods so we don't need to add them here and remove the existing code. I would revert most of the changes in this file besides removing the private selector and setting the text alignment above and everything should still work.


Why not just `_extract_dash_formats`? It would be more consistent with other extract formats methods. Same question for all the other places in code.


Hii @nim-odoo, I'm totally agree with you, except that :
* from time to time, the en is passed in sudo so that user that are not accountant could invoice. (example of the POS you gave me )
* If you are a user working the the top company, your rules displaying all the taxes so when you create an invoice from the top level company you'll have multiple taxes, that's why I propose to change the filter and let it apply whatever the uid


Bin voyons! git c'est malade!


Oops, I messed up the "View in Browser" link. It should be:

http://htmlpreview.github.io/?https://github.com/johnTheDudeMan/the_odin_project/blob/master/etch_a_sketch/index.html


Hi @simongoffin ,

What do you think about my proposal?


Should provide a Charset property for users to select which charset their document is encoded in.


I removed `valid_countries` and changed the controller to [check that the region exists](https://github.com/quintel/etmodel/blob/master/app/controllers/pages_controller.rb#L20-L22). ETEngine tells us all the regions which exist and are available (in fact [there's an attribute on each dataset which does this](https://github.com/quintel/etsource/blob/d25d4289cae751d6c0741786e3d3480291136357/datasets/nl/nl.ad#L5)) so it's a bit redundant to have to add this information to the config file also.

Changes to the config file also have to be reflected on staging/production (in the Ansible repo).


Thanks for this!


@llaniewski , I commited the Sampler class,that was written so far. I have updated also the stuff in the Lattice.h.Rt and Lattice.cu,will push,once I debug it and ensure it works all together.


I don't know about other methods but JLanguageHelper::getCurrentLanguage(); should be accepted. I don't see any reasons why we have getCurrentLanguage() method on different classes. Place it in JLanguageHelper makes sense to me.


Also, I think it's a limitation of JRuby when used with Nailgun/Drip that you can't change options. We'd like to be able to do that if we use a similar approach.


T'as raison!!


Much appreciated :) And sorry about the late response


:+1: Merci !


:+1: Yes. That's better, thanks for the fix.


'consider' sounds like it won't actually do it... given you do remove the keys if the ref count is < threshold, I suggest you make the function name a bit more obvious :)


new pull


 no i made it for personal use and it's easy to understand how it works if
you look at the code, everything is here, you just need to know how to use
it.

On Mon, Feb 1, 2016 at 9:32 PM, jaan143 <notifications@github.com> wrote:

> can you give me final output of that downloader ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mhamri/PluralSight-Downloader/commit/840aa9eaa39a5f9823b47cc7f319f5a26ea3ff21#commitcomment-15798936>
> .
>


We've generally agreed that the "big data" backends that have time as an important dimension (like influx) should have `from / to` default to `:now:` and require the user to specify the time range for a query by default.


Nice job! I learned a lot from your Task 4 & 5 - you have a much more elegant way of printing those strings than I did.


This loop will only execute once if the race condition is met. Explicitly providing a single repeat might be better. Also need a flush after the `psci_set_aff_info_state_by_idx(AFF_STATE_OFF)` at line 135 to ensure that the spurious wakeup after a failed CPU_ON will be detected.


It now looks very weird
![game](https://cloud.githubusercontent.com/assets/6714322/12722080/0c755596-c8fb-11e5-916e-5da46409908e.PNG)


## Task 1

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 2

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 3

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 4

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)

## Task 5

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (1 pt)
- [ ] Program is different than [Task 4](task-4) (1 pt)

## Task 6

- [ ] Program is correctly formatted with shebang, description, code (1 pt)
- [ ] Program functions as expected (3 pts)


This is expecting two objects and the array is only one.


Not sure I understand this? The template referred to here is the path that can be used by a user to override the template included in the package.


> I had a quick go at replicating this with the previous commit checked out and couldn't. Not quite sure what message it duplicates or how it does that

Might be something which is only theoretically possible - although I have seen it in a test scenario - if the message is submitted twice before the flash message is displayed, you can end up with both the message has been sent" and "has not been sent - it's a duplicate" messages unless `flash.clear` is run first.


+1

Totally agree, particularly with letting parser errors be handled 'in-house'.


This is also probably not the right spec for this test, does it make sense to move this to owners resource?


I don't think both effects where meant to apply to the sprite


It looks nice!


country


downloaded


Whoops. This breaks instance lookup in dependencies…


wow, Eric this is an amazing piece of work - thank *you* !


Добавил 6-ть задачек (6_tasks_01.02.2016.js)
https://github.com/ABettik/js-lesson1/tree/master/Js%20Tasks

2016-01-30 12:48 GMT+02:00 Sergey Strizhak <notifications@github.com>:

> все ок
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ABettik/js-lesson1/commit/1379fad6bb59d22abfc1fa156a87e8475769c9fc#commitcomment-15779395>
> .
>


Dear Greg,
Just two more additions: I uploaded a screenvideo + sound here:
http://christianlosert.com/test/01/error_with_sound_02.mov
I just reproduced this bug with another safari 9 version. It behaves exactly the same.

You answered me via stackoverflow to my issue. But I'm not convinced that this is a soundcloud 2.0 sdk issue. This domain request thingy brings my example (http://christianlosert.com/test/01/) and your example (http://twgljs.org/examples/dynamic-buffers.html) to crash with the exact same behavior. (have a look at the video). I suppose it's a safari problem with the webkit support.


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1508 of 1508 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.69%25-green.svg)


Hello @domthu , me and @veon82 have fixed the issue in the model in e9cc65a403050, after checking that for a gasmember the VIEW_CONFIDENTIAL permission has been used only related to cash.

You have done a good work by commenting the lines you referred to, for the next time it would be better if you open an issue too (so we can _celebrate_ that we have fixed another problem in GF ;))


saw approval from hmmr
at https://github.com/basho/riak_kv/commit/63b4e0cea864daf7011213c9ea3eba2160d0ee19


merging basho/riak_kv/at-remove-escapes-in-errors = 63b4e0ce into borshop-integration-1337-at-remove-escapes-in-errors


basho/riak_kv/at-remove-escapes-in-errors = 63b4e0ce merged ok, testing candidate = 927d2eb3


Hah, not sure how this prevents Babel from inserting `"use strict"`, but I agree the proper fix is going to be something pretty much like this.


mocksFile maybe should not be optional at this time
and the default value should be always Mock.plist.... something url


Okay, let me change that.


@malirod , please see  #130 task for this issue.
Currently this is hotfix. But this method should be reworked


> The Lifeforms where using angle range from -180 to 180 before too.

Well you are right. The old implementation didn't even guarantee a mapping onto 0-360, if `angle` is above 720 or below -720.


this should be Mocks.plist as default value or the url for the file


Is it really necessary to do `"{@room_endpont}"` to a string? It seems like `@room_endpoint` would do exactly the same thing without any wasted concatenation.

```coffeescript
@room_endpoint = "some_string"
console.log("#{@room_endpoint}" is @room_endpoint) // => true
```

```javascript
this.room_endpoint = "some_string";
console.log(("" + this.room_endpoint) === this.room_endpoint);
```

Not really a "performance" issue I just find it pointless and redundant so I was curious why it was decided to do it this way?


no mockFile! bad


Worth noting that I'm *adding* vector data, but didn't think of making this repo *only* vector data. Do you think it would be worth running benches specifically based on `vector`/`raster` folders?


I think so, but RC1 didn't like it :)


gak bisa follow @zhiephie :smile:


Yup, I'd fixed locally but thought I'd re-pushed without any driver


Yes, that is what I meant and what would be good in the future.


I would recommend updating the commit title to something like "Use correct printf specifier for size_t" and note it fixes warnings in the commit body. The change LGTM otherwise.


Nice job! Your Task 3 was totally different than mine, which is awesome! I didn't know you could use negative number inside the `range()` function to get a reversed order.


DASH refers to the protocol and a DASH manifest refers to it's description file. Maybe ```dash_mpd``` for a shorter and more accurate name?


Sorry for the delay - it's not an oversight; they're the same.  The dictionary has not changed; only the decoder for the full-fat AvsAn.js was fixed.

As to the encoding issue: that's not a bug in the file, that's ambiguity between utf-8 and whatever ascii variant your editor is trying to use.

If you look at the file in github (https://github.com/EamonNerbonne/a-vs-an/blob/master/A-vs-An/AvsAn-JsDemo/AvsAn-simple.min.js) you'll not see `â€“` but instead various unicode characters towards the end of the dictionary (they're there in the middle of the dictionary too, but rarely, so that's hard to see).  You're probably opening the file as codepage 1251 instead of utf-8.

Does that help you solve whatever issue you're having?  Encoding problems are nasty, and most javascript never needs to deal with unicode, so it's not altogether surprising you didn't encounter this before.


![multipass?] (https://media.giphy.com/media/kFRz9G9z7Lzri/giphy.gif)
I'd rather call it asynchronous, chunked or deferred or something


Perhaps it's time to define a `url_for()` function for ptero-lsf, like we did in ptero-workflow.  We could copy `url_for()` from ptero-workflow in this PR, then move them to ptero-common later.


I checked your' example  (http://twgljs.org/examples/dynamic-buffers.html)  with a friends mac. And it also stops streaming immediately when he types in the link into the adressbar of safari and returns with pressing enter after coming from a different website.


It's better to mention license type which expired.


Is it possible to color the friend list too with class colors?


It was and i got rid of it at https://github.com/openmrs/openmrs-core/commit/1f9c5310445d95e664c87432918eb06c221fdef2


"sadly"?
sad typo is sad


I think it would be better to make this false by default. Then not setting it would result in no emails being sent.


Oh wait, I read this wrong. Never mind!


These variables should be documented like the other variables.


good stuff thanks


++ maybe also check for m.


Ok, I added those to the bug report above


should be: spring.datasource.schema=classpath:import.sql


This worked on version 2 of mongo, but not on version 3, which does not allow trailing slash for the `connectionURI`.


+1 This looks great to me.


Fichero nuevo correspondiente a la vista de los comentarios.
La ampliaremos más adelante para mostrar un listado de todos los comentarios realizados en nuestra web.


@josharian Sorry, didn't see your comment (need to find a better way to get relevant GitHub notifications). The root cause is still being determined. The issue was reported on many different individual devices running on a range of iOS versions (7, 8, 9; all non-jailbroken)/hardware (old iPhones to the latest), but reproducing it under controlled circumstances has been difficult over a period of time. This is a stopgap measure for now.


:walking: gorok


Thank you for this. Kozzy get on Github!!!


Hm there's some trailing whitespace unhapiness going on in there it seems :)


THANKS


Añadimos una nueva opción en el menú superior para poder acceder a los comentarios realizados en la web.


Jesper, check the instructions from Maria about creating a new view to apply updates, instead of changing the default one.

Will be much better, for later upgrades.

Let us know if the document provided in https://webgate.ec.europa.eu/CITnet/jira/browse/GISCOMETAP-147 requires additional work to be more clear.


__API Description file syntax error on line 330__: the use of tab(s) '\t' in source data isn't currently supported, please contact makers (Autogenerated message from apiary.io)


I have the same message, and I get segfault when I start to draw anything.
Compil of commit just before run ok.


The previous default is false, so this should stay false as well to avoid changing behavior.


thanks. hopefully there will be a solution!
Best,
c.


Always use file_prepare_directory! Will save some people a lot of headaches!


Which errors?


Are there drivers that actually do something useful with SIGTERM on Linux?


There is no access modifier for this variable declaration, that is public, private or protected


:scream: :dancer:


why do we need to add this change?


Genial!! Deberiamos dejarla en /util


Then simply `mpd` to stick with well-known manifest/description files' extensions - f4m, m3u8, smil, mpd.


Slugger is used as utilities for the config file that in this repo are just for test purpose, so we should probably move this in the dev dependencies.


also this one? do we really need this to update grpc?


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/3144


Line comments should have a space following the `//` character sequence.  So, you should have:

```go
// SummaryLength ...
```
instead of
```go
//SummaryLength ...
```


use module_get_path https://www.drupal.org/node/319171


This part is obsolete since 770f253


Grpc update breaks etcd. So I needed to regenerate proto files.


No particular reason. It is just a habit of mine to use angle brackets for includes which do not actually have a relative path to the included file like in this case. This helps to visually distinguish includes of files which are only found due special include paths from files which are relative to each other and therefore definitely part of the same project.

However, I don't feel strongly about this matter. I'll therefore switch to quotes when I incorporate your other remarks.


update da branch DESENV para master


but this line seems to have nothing to do with grpc update.


@dill @erex @lenthomas
I feel like it would be really nice to get mads working with Distance so we can say they interface too, how nice would it be? I reckon 1 - 2 days work... worth it?


Why it's pre-commit now? It's look like a bug.


Shouldn't we test if this.config.loadExternalScript is also a function before execute it?


You will probably get a warning for the empty catch block, I always do them like this:
catch (IOException **ignored**) { **}**


I might have included it referring to master branch. Will take a look if it needs it when I get in.


Yes, good point, going to implement that also in tp lib fix.


@malirod , ProcessVRResponse and ProcessPerformInteractionResponse use same object. In case interaction mode BOTH, we need values in smart object from VR and UI.


Fine with me. I just left it in place to give an indication why the whole if is needed at all.


[R/get_analysis_version.R:29:7:](https://github.com/INBO-Natura2000/n2kanalysis/blob/e4f928f850823893d19ec50acffec0f23a059202/R/get_analysis_version.R#L29) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(is.null(attr(version, "AnalysisVersion"))){
      ^
```
[R/get_anomaly.R:186:58:](https://github.com/INBO-Natura2000/n2kanalysis/blob/e4f928f850823893d19ec50acffec0f23a059202/R/get_anomaly.R#L186) *style:* **Commas should never have a space before.**
```r
      this.re <- this.re[this.re[, 1] > random.treshold, , drop = FALSE]
                                                        ~^
```
[R/get_anomaly.R:190:52:](https://github.com/INBO-Natura2000/n2kanalysis/blob/e4f928f850823893d19ec50acffec0f23a059202/R/get_anomaly.R#L190) *style:* **Commas should never have a space before.**
```r
      this.re <- this.re[order(abs(this.re[, 1])), , drop = FALSE]
                                                  ~^
```
[R/get_anomaly.R:198:57:](https://github.com/INBO-Natura2000/n2kanalysis/blob/e4f928f850823893d19ec50acffec0f23a059202/R/get_anomaly.R#L198) *style:* **Commas should never have a space before.**
```r
          this.re[sign(this.re[, 1]) == combination[j], , drop = FALSE],
                                                       ~^
```
[R/get_model_parameter.R:92:14:](https://github.com/INBO-Natura2000/n2kanalysis/blob/e4f928f850823893d19ec50acffec0f23a059202/R/get_model_parameter.R#L92) *style:* **Commas should never have a space before.**
```r
          "" ,
            ~^
```
[R/get_model_parameter.R:356:14:](https://github.com/INBO-Natura2000/n2kanalysis/blob/e4f928f850823893d19ec50acffec0f23a059202/R/get_model_parameter.R#L356) *style:* **Commas should never have a space before.**
```r
          "" ,
            ~^
```


this is not cool but I couldn't find another way to get the actual matchers


Topkek


Apparently renaming folders causes github to reupload everything! Oh boy!


It is very dangerous to include a header here, because we are here inside the CGAL namespace. It Boost headers define anything, that can break very easily.


IMHO "Codenvy license couldn't be estimated" message is more suitable here.


Unfortunately you can not. Prevents API.


There are two more cases where Tux's sprite changes and you don't change worldmap_sprite:

- https://github.com/SuperTux/supertux/blob/95f7133ad1d9cd6751e91f2779d00b061f9ffd2b/src/worldmap/tux.cpp#L277

-
https://github.com/SuperTux/supertux/blob/95f7133ad1d9cd6751e91f2779d00b061f9ffd2b/src/worldmap/tux.cpp#L319


Strange line splitting.


they really safe the matcher as string in ActiveSupport::Callbacks....


>предназначен для хранения тестов написанных на фреймворке xUnitFor1C

предназначен для хранения тестов**,** написанных на фреймворке xUnitFor1C

Запятые не забываем :)
Ну и для текста про v3 аналогично.


Right! I forgot that, thanks for mentioning it


@austinpapp can we update this url with the appropriate dev environment info? I think it's api-dev.powerli.ne


Perhaps you do mean: "Do you have..."?


This is awesome! I love it! Thank you Bunny67!


IMHO "Your Codenvy license has invalid format or absence" message is more suitable here.


перепроверить: надо ли...


There are...


@flavour Please review


is this 35 the number of pixels or a percentage? I think we want to make sure the images are as responsive to the local device's screen size as possible.


Слушай, но с вычислением и потом вызовом всего по этому блоку красивше же было :(
И текущий вариант вообще-то довольно странно будет себя вести.
Например:
```ruby
list.add_sort_algo(:year_genre)
list.sorted_by(:yer_genre) # просто опечатка. вернёт несортированный массив, и пойди разберись чего
list.sorted_by('year_genre') # забыл как правильно использовать. и пойди разберись, чего не сортирует
list.sorted_by #{|m| m.year} # случайно закомментировал блок пока отлаживал. вернёт несортированный
```


# Hello Octocat
## update README.md 👍


9759d6ee comitted


Why move the variable instantiation from the constructor into the variable declaration - goes against how the rest of the variables are instantiated


I am a nice comment


fixed


I indented these to follow graphical layout of the window.


Fixed


Heh, it doesn't, but it prevents the `"use strict"` on the following line from being considered a directive by the JS engine!


this is a test folder


I don't think it needs to be as it is a test dependency so we are not distributing it. Lots of other places in NiFi use Mockito and they don't have license stuff there either.


Start new sentence from Capital letter


cool assignment operator! <- <- <- :)


Ah okay thanks. I think we're going to have a hard time keeping the number of cuts low, might have to take a day at some point to spring clean once we're on our feet.


pgm


Do I need to add this on  iOS?


This fixes https://github.com/ExCiteS/software-dev/issues/81


First off, thank you!!!

Second, I shall fix it. :+1:


Making warning level stricter will have to be accompanied by corresponding changes to the code that fix the new warnings. Since this out of scope of the current PR, I suggest switching back to the default for MSVC.


Not so much a case of missed, as there not being enough hours in a day, but, thanks for this comment.


Depends on LogosLabs/thebuggenie@9c2887f4390059eae6ea21d8b866903b31c32787.


It's also a best practice to use complete sentences with proper punctuation in GoDoc comments.


The name of `SecurityKey` seems misleading. I would expect a `SecurityKey` to index into a collection of `Security` instances. In a recent push, I made the key public, but left it as `MarketHoursDatabase.Key`. Did you need these key somewhere other than `MarketHoursDatabase`?  (maybe I haven't gotten there yet :))


I don't see where I include a header


reviwed->reviewed


I think no, I am fixing the tp lib today, so you will just use it and it will handle that. I just made it before release.


Review process


May be add a link - for example ``[the master branch](/smartdevicelink/sdl_core/tree/master)``?


Non-zero exit value on test failure


@schleichardt check this commit. Now the SDK is sending to the API as type "CustomSuggestTokenizerImpl" instead of "CustomSuggestTokenizer".


This ViewState introduced by this guys basically relies on retained Fragment as well :smile:


The logging here doesn't agree with the use case in `regionServiceClient/usr/sbin/registercloudguest` , where you are only using proxy settings if `set_proxy` returns `True`


See my comment above; this misses the case you handled in `set_proxy` with exisitng proxy settings.


`to` is redundant with answer verb


Looks great! Merge it.


Good job here.  I like this kind of simplification of control structures.


Perhaps ```pip install --user mpi4py``` or adding ppt repository and then
via apt-get? I don't know other method to do that and pip should work cause
they use ```virtualenv```.

2016-01-31 18:13 GMT+01:00 Christoph Junghans <notifications@github.com>:

> @MrTheodor <https://github.com/MrTheodor>: do you have an idea, how get a
> newer python-mpi4py into the container?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/junghans/espressopp/commit/73de155e011d489e6f210e7ad491bea9029d1eec#commitcomment-15786639>
> .
>


Added use of extracted method in commit d7f1b838e8ceb221b1330468b249ef19eef2bf9c.


Fixes memory leak


ok thanks


I would swear there was a native method/property to help with this. Am I imagining things?


Please review @pestOO, @AGaliuzov


Currently it looks like regular block element with special styling applied and it behaves so in Chromium right now, so I've added `icon` attribute for instance and have icon added to button when I need it with simple attribute.
There is `-webkit-appearance: button;`, but no User Agent Shadow Root (like in `input` or `textarea`) to have problems with.
Are there any other issues I'm not aware about?


сделаю


@austinpapp can you review and provide feedback when you get a chance? Thanks. Also, I think we need to have these commits on separate branches so that we can PR/merge them instead...


`FMT_USE_FILE_DESCRIPTORS` should probably be defined in tests only.


"a SDK" needs to be "an SDK".


May be use the perfect form instead of simple?
* UTs updated
* UTs delivered with a separate commit


The comment says

>  When executed during boot the proxy environment variables are not set and thus connection to the region server will fail if a proxy is configured.

but the code has some conflicting behavior around existing settings, so either the comment needs to change, or the code shouldn't bother with existing settings.


do you have


true :+1: just check the diagrams also for ```onViewCreated```. same approach as yours!


I see, let's merge this as-is then and if we need to refactor the whole thing anyway, please bring it up again.


contributor writes


So I got to where this was reused - `SymbolPropertiesDatabase` - maybe we can name it something that refers to its usage,


Tegelt parandab Issue #2


Also ich war mir 100% sicher dass die { und } Sachen in unserem Code nach PEAR code guideline sind. Aber tatsächlich sagt PSR und auch PEAR, dass die { } braces so wie Ian es gemacht hat, "richtig" wären.

Optisch tut mir das aber wirklich, wirklich weh. Und ich würde halt sagen dass wir einfach megaviel Code haben der die braces anders setzt, und für uns komfortabler zu lesen ist.

Ich würde daher schon sehr gerne daran festhalten, { NICHT auf eine Newline zu setzen. Das spart eine ganze Zeile, in vielen Daten summiert sich das, und bringt IMO auch sonst keine höhere Übersicht.

Wenn wir es wirklich einheitlich ändern um dem PSR zu entsprechen, dann würde ich sagen müssen wir das wirklich konsistent und auf einen Schwung und in einem commit für ALLEN PHP-Code durchführen, nicht "tröpfchenweise".


Not quite sure why the last line 56 will print more a '\n' for the original file's content.
check tomorrow.


# Do you have
# May be "Thread specific comments provided"
# Its not clear for me what is "thread specific comment"


Looking at the libpq code I expect it to work. Will test when I have a second.


contributor `leaves` instead of `left`


I believe I failed to notice that their are different naming conventions for operations and the client API.


Given that this line was added in januari 2013 commit 98220314 ), I am guessing the extra function is never used.

Are there any use cases for this code, ie why didn't it surface for 3 years?


@shama: do we really need 0.12? Also, the AppVeyor config you used is slightly off, there are no global packages to cache.

@shama or @vladikoff: can you add AppVeyor for this repository?


Otherwise lgtm


Hi @flotho

I 've just tested your proposal and it doesn't work as expected. For example, if you have in your stock 10 units of a product P and you create one inventory with:
one line for P with a Real Quantity=15 and another line for P with a Real Quantity=20
When you validate the inventory, you expect to have 20 units of P in your stock but you have 25 because the system creates +5 quant for the first line and +10 quants for the second.

Regards,


May be add "see Run tests section"?


Thx! I'll give it a try


=======read and print again=========
write to file_new.txt
aaa
bbb
cccdddeee
ooooooooo

> quit with code: 0
-- why here will output a addictional '\n'?


1) reviewer `is agree or reviewer `agrees`
2) `left` is the Past tense. Should be `leave`


Both http and https work for this URL. Any reason for the choice of the https?

http:
````
@font-face {
  font-family: 'Roboto';
  font-style: normal;
  font-weight: 400;
  src: local('Roboto'), local('Roboto-Regular'), url(http://fonts.gstatic.com/s/roboto/v15/CWB0XYA8bzo0kSThX0UTuA.woff2) format('woff2');
}
````

https:
````
@font-face {
  font-family: 'Roboto';
  font-style: normal;
  font-weight: 400;
  src: local('Roboto'), local('Roboto-Regular'), url(https://fonts.gstatic.com/s/roboto/v15/CWB0XYA8bzo0kSThX0UTuA.woff2) format('woff2');
}
````


I feel like this process could be done much better with a `.map` or `.reduce`, and may even belong in another function. I think this `createPlayerDeck` function in general is a bit long and could be split into smaller, more manageable tasks.


Maybe better to let these switches(enable/disable) configurable by the committee.


Line 245: `#include <boost/config.hpp>`


These are the X_N and Z_N constants. It would be better to rely on them.


We have own specific version ./tools/coding-style/cpplint.py


```
[ERROR] addons/helpers/lua/autorun/server/gs_crashcatcher.lua:111: bad argument #1 to 'pairs' (table expected, got nil)
  1. pairs - [C]:-1
   2. IdentifyCorpse - addons/helpers/lua/autorun/server/gs_crashcatcher.lua:111
    3. fn - addons/helpers/lua/autorun/server/gs_crashcatcher.lua:186
     4. unknown - addons/ulib/lua/ulib/shared/hook.lua:110
```


Good point.


May be add see "Pull request message"?


`in case of`


reviwed -> reviewed


is it an error when no symbol properties are found? is the calling code expected to handle the null case? I believe the `MarketHoursDatabase` throws in this case


@XhmikosR added https://ci.appveyor.com/project/gruntjs/grunt-contrib-copy


Contact Oleksandr Galiuzov or Artem Nosach to merge pull request. `with` is redundant in this context


fast-forwarding riak_ts-develop-1.2 to borshop-integration-1337-at-remove-escapes-in-errors = 927d2eb3


I prefer to use Reviewed in case I have no critical suggestions.


Thanks for your comments! I pushed more changes, let me know if I missed something.


Will it work when `cppformat` is used in another CMake project via `add_subdirectory`?


@AGaliuzov, what's about "Visual reviewed"?


`shuffleDeck` returns a new array, this does nothing!


@AGaliuzov, May be add group for merging and mention it instead of persons?


It would be preferable if the getMissingStaff() method returns nil instead of an empty table. That would be much more clear in meaning.


Resources->sources.
[http://www.grammarly.com/answers/questions/218-what-is-the-difference-between-source-and-resource/](url)


Please make it more elaborative of the formula and please make it formal.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13836](https://teamcity.mesosphere.io/viewLog.html?buildId=119865&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:03:10


Why is this removed?


Ha, found this one myself as well :)


I get the idea, This form is good for the reporter.


@bluefuton Looks like that commit doesn't exist in the new repo. I'm seeing errors in circleci like this one: https://circleci.com/gh/Automattic/wp-calypso/6304
```bash
fatal: ambiguous argument '29784fd': unknown revision or path not in the working tree.
```


`_.find` would be useful and cleaner here.


Don't see checks from https://adc.luxoft.com/svn/APPLINK/doc/internal/cheklists/FORD.SmartDeviceLink.CodeReviewCheckList.xls


Already added in manifest


I was considering splitting off the definition of `===` into a module (maybe `Numeric.Units.Dimesnional.Testing` or something?) so that the module header could explain what those tests are about and link to the haddocks for it? Or is it sufficiently self-explanatory as to not be worth it?


can leave


Rate is now based on sent requests instead of received ones


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13837](https://teamcity.mesosphere.io/viewLog.html?buildId=119861&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:07:04


Why was I deleted?


Tests needed to be modified to update the rate with _sent_ requests, instead of received responses


You are right! Thanks for pointing this out.

If we make the change in `REQUIRE`, it's probably a good idea to tag a new version, making explicit that we have drop compatibility for v0.3. Other possibilities is to revert precompilation, or put it inside and if that checks the version. I am in favor of tagging a new version. What do you prefer?


Right. I thought that it is needed for the library as well given that it has been previously defined globally.

Regarding a different topic. Is `posix.h` actually part of the official interface, i.e. it should be used externally, or is it just there for testing. If it is part of the interface then it should be installed as well. If it is just a internal implementation detail then moving it to the tests and removing it from library itself would be sensible. A brief clarification would be highly appreciated.


I will rename this to properly reflect what it tries to test.


add `err` to the end of `image', path, err)`


Oops, `misspell` failed us!

in `mock/storage.go`

```diff
 -// - ... limit interference due ...:		 +// -  limit intereference due
```

Fixed in https://github.com/client9/misspell/issues/25

There are a few of these that need to be fixed:  https://github.com/client9/misspell/issues/22

Thanks for using Misspell and goreportcard!

nickg

HT: @shawnps


I'll take this away, if we decide to drop compatibility with Julia v0.3


I think this should be called `:have_before_matchers` — because of `expect(subject).to have_before_matchers` semantics.

Other than this — wonderful job, :fireworks: !


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13838](https://teamcity.mesosphere.io/viewLog.html?buildId=119847&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:07:48


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13835](https://teamcity.mesosphere.io/viewLog.html?buildId=119866&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:09:10


The way it works is that an in situ initialization is slotted into the code of any constructors in the class. Its code can be executed only by a constructor that “adopts” it.

If the class does not have a default constructor (taking no parameter) trygve builds an empty one for you.

If there are in situ initializations and the compiler creates a default constructor on the programmer’s behalf, the initialization code is slotted into the code of that automatically generated constructor.

If you try to invoke a constructor without arguments, trygve guarantees that there will be one there.

If you try to invoke a constructor with arguments, and no declaration exists for those arguments, it is a compilation error.

Therefore, it becomes impossible to create an object without executing a constructor.

Since all in situ initializations are slotted into all constructors, it is impossible to create an object without all of its in situ initializations being executed.

I’m bending over backwards to make it user- (child-) friendly ;-)

> Den 01/02/2016 kl. 10.27 skrev Andreas <notifications@github.com>:
>
> Thanks, I noticed that this works though with the latest version:
>
> class InSituInitTest {
>     public InSituInitTest(String s) {
>         string = s.clone;
>     }
>
>     private String string = "Hello world!";
>
>     public void test() {
>         System.out.println(string);
>     }
> }
>
> (new InSituInitTest()).test()
> Since there is an explicit constructor, shouldn't this fail compilation?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/jcoplien/trygve/commit/8e70df32c622ea9a401e9603df7785740116c4b3#commitcomment-15793734>.
>


Use `to be` verb in plural form with plural nouns


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13839](https://teamcity.mesosphere.io/viewLog.html?buildId=119876&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:07:25


This commit could  be squashed with previous before merge


Noticed this when coding tonight. Took me a while to realise why I was getting errors ;)


ping


Just for clarity, we don't need to include this because it is a test dependency only and isn't bundled into the deployment.


My idea was to split the application of `numbr2str` for the usual numerical types and, for the additions (e.g. `Interval`) have the rest of `Real`. That's the motivation for having the parametric dependency here.  What do you propose otherwise?

The actual issue is that all this works assuming that the underlying field `T` in `Taylor1{T}` or `TaylorN{T}` is ordered which is not the case if `T` corresponds to `Interval`. If `T` is ordered, the comparison with `zero(T)` defines the sign; the trick doesn't apply for intervals, and yields wrong out put, while the coefficients are still correct.


Hi!

Is there a more updated list I should be looking at? I'm not finding error codes: 16540 or 16549, which are referenced in Moped error messages:

```
See https://github.com/mongodb/mongo/blob/master/docs/errors.md for details about this error.
```


I'll take away `Irrational`; it doesn't make sense to have it there anyway.


ping @jtreanor


saw approval from macintux
at https://github.com/basho/riak_kv/commit/8734af5fcbe269ca1c0b94855703cf284dbb07bd


merging basho/riak_kv/at-catch-finalizer-div-by-zero = 8734af5f into borshop-integration-1338-at-catch-finalizer-div-by-zero


basho/riak_kv/at-catch-finalizer-div-by-zero = 8734af5f merged ok, testing candidate = 5e9f0745


Send `to` insead of send `for`


Hym, I don't know why VS2015 sent full files ...


Well, thank you again! Will revert back to the correct spelling :)


Ah true! Didn't think about transitives. But OTOH it wouldn't hurt to have a direct include.


Yes, I would drop 0.3 and tag a new minor version.


Sorry, this is one of the real mysteries to me. The length seems to indicate a SHA1, but I couldn't figure out what text is used for the hash. Might be something proprietary to Flash as well.

So why not directly use http://a.files.bbci.co.uk/media/live/manifesto/audio/simulcast/hds/uk/high/PROVIDER/STATION.f4m just like with live TV?


You are not currently using `babel` to transpile your test files, so be careful with the ES6 features you use in your actual tests.


Thanks!

From: David Birtwell <notifications@github.com<mailto:notifications@github.com>>
Reply-To: daveneiman/fits <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Monday, February 1, 2016 at 11:16 AM
To: daveneiman/fits <fits@noreply.github.com<mailto:fits@noreply.github.com>>
Cc: Neiman David <david_neiman@harvard.edu<mailto:david_neiman@harvard.edu>>
Subject: Re: [fits] Fix normalization of MXF files; add corresponding unit tests. (81e3e76)

Looks great! Merge it.

-
Reply to this email directly or view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_daveneiman_fits_commit_81e3e7613456d8bb875b0db1cdf42b132cb32916-23commitcomment-2D15803362&d=CwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=E4CBlG2Y56LZVErMuCUUebUg_BUQBjrd6shQZC_EPhU&m=NAmVN1SXnxcJ2wqdCSCAz7FtQ1sn6l-VQa-6tE6iq0c&s=APRmTAHWlO_5XCgIa_feP7ODAmZUruJKXs8xfv4RqQw&e=>.


The interval case is dealt within `T<:Real`, which applies for `Interval`, and not the other options.


`expect(drawTop).to.be.equal(poppedCard)`


I had forgotten that `Interval` was a subtype of `Real`.
In any case, you can just leave the other non-`Real` version of the function without the type parameter I think.

Can't you use the `sign` function to check the sign?


FYI: you seem to have missed `pl` in the link here.


当然是 rollback至64.233.162.82/3/4


Thanks. I was just looking at the links from http://www.bbc.co.uk/radio/player/bbc_radio_one


`expect(CardFactory.isEmpty([])).to.be.equal(true)`


Oh and one more thing: Once you are ready for a pull request, I would appreciate if you could squash the commits. Otherwise all your temporary commits will move to the main branch and I would like to avoid that. Having just one commit of the final stage makes it easier to maintain in the future.


Done


This has nothing to do with a channel attach failure, this could be any error.


I like the way html is a little more self explanatory, I had trouble doing Python on my own so I just voted my research


This message does not show up when using Polylang.You may want to check for `POLYLANG_VERSION`


Oops! Thanks, fixed.


Yeah, updating this, thanks @MickeyHub


@afanfa, please add a comment  just above line 1614, e..g, "halt execution if sync images contains duplicate image numbers,"  assuming that's what happens.  Also, is there a better approach than "goto" or a good reason for using goto here?  Please ensure that all new code blocks have explanatory comments -- even just one line at the top is sufficient.

@zbeekman, is there a tool that will check for the ratio of comments to executable lines?  That would be a great step to add to the commit process.

All, I'm trying to police myself on this too.  I recently committed a new function inside the bash script and realized, after the commit, that I didn't include a comment describing the new code so I did a second commit to add a comment.


Fixed


windows VS2013 CUDA 7.0 or 7.5 function cuMemGetInfo has 2 argumets


Posted ** not voted


It should. According to [1] it points to `the most recent project() command` which is the one in our main `CMakeLists.txt` when `add_subdirectory` is used.

However, I highly doubt that anyone wants to have package support from `cppformat` when the library is build as part of a bigger project. It is more likely that this project will define the `CPACK_...` variables and the include themselves. Should the whole block maybe be guarded with a check if `CMAKE_SOURCE_DIR == PROJECT_SOURCE_DIR`?

[1] https://cmake.org/cmake/help/v3.0/variable/PROJECT_SOURCE_DIR.html


TeamCity NEventStore :: Core :: Build [Build 6.0.0-unstable.62](http://build.prxm.it:8813/viewLog.html?buildId=3407&buildTypeId=NEventStore_CI&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 280 Build time: 00:01:51


`strings.HasPrefix(e.target, "removeAbove")`


On Mon, Feb 1, 2016 at 3:35 PM, Tom Breloff <notifications@github.com> wrote:
>
> Sorry to hijack this thread, but I wonder if it would be reasonable to add some sort of metadata to each listing which includes whether a package falls into various categories:
>
> Production-ready
> Tested
> Actively maintained
> Abandoned
> Experimental
> A "throw-away toy repo"
>

This would be a nice to have list but who are we to judge? Unless the
package owner/creator tags their repos, it is just guesswork and
probably premature to assume what status the package is in. I list
some packages that were developed in ver0.01 only because its freely
available and someone else may want to continue with the work if it
aligns with their research or work.

> It may be reasonable to let the community compile this data (possibly a google docs form or sheet?) by asking on julia-users for assistance in filling in the blanks for repos that they have personal experience with.
>

Perhaps we could try an experiment - instead of googledoc ask the
community to add a {tag} near the package name and submit a PR?

Not sure atm, but the more I think, I realize that owners/creators or
core-dev maintainers are the best persons to tag the status of their
package as only they know what works and what does'nt - especially
true for lesser used packages.  That is ofcourse just my personal
opinion. fee free to disagree. IMO, the danger with crowd-sourcing is
: What if a community member decides 'foobar' package is unstable as
it didnt work for them or 'not maintained' if they refused to add
requested features?

Community feedback is a good thing if they file bugs and so on, but
lets not forget that there is a risk of some package owners being
offended with the community tagging the status of their package
negatively. If you know what I mean? :-) I usually keep METADATA as
the final authority for stable or actively maintained packages but
even that changes frequently. I think the easiest way is to have
METADATA find a way to effectively tag packages, else it is hard to
know the original author intends - example, some packages on
metadata.jl fail for the latest Julia version, so how do we label
those?

> I find that this repo is such an enormous help in searching out new functionality, but that it can take a long time to evaluate which packages are worth looking at. Also I too have a couple repos on here that are in various states of usefulness, and it can feel strange to have them on here without context.
>

Thank you for the kind words. I understand what you mean. I guess that
comes with the new language and its growing pains. I would love to
find a solution to the problem too but I dont have the perfect answer.
I am more worried that if we start being aggressive about tagging
packages, then some folks will not want to be listed at all as their
package is still 'unfinished'.  That would be sad, dont you think?. I
want to encourage folks not discourage them from showing off their
unfinished julia code on github.

/zero paise worth.
SVAKSHA ॥  http://about.me/svaksha  ॥


What is the purpose of overrideColor? It is never used


`strings.HasSuffix(e.target, "Percentile")`


This is one paragraph copied from the actual Python webpage.


ERROR: replace instance variable with local variable


TeamCity NEventStore :: Core :: Build [Build 6.0.0-unstable.62](http://build.prxm.it:8813/viewLog.html?buildId=3408&buildTypeId=NEventStore_CI&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 280 Build time: 00:01:24


:+1: I was looking for this. You should probably add this to the propTypes though right?


Done


Actually this means pixel because width of image was 35 actually. I didn't specify with on other areas then it loads resized image from the imgix as it is displayed before imgix is used.


@CoralineAda : also unrelated to this exact commit, but I'll think it's worth mentioning (and don't want to raise an issue for something's that probably in the server configuration, not the repo proper):
Documents returns by links to the markdown versions lack `charset=utf-8` in the `Content-Type` header resulting in gibberish with non-ASCII characters (especially noticeable with [Japanese translation](http://contributor-covenant.org/version/1/3/0/ja/code_of_conduct.md) for example). HTML and plaintext versions have the charset in the header specified appropriately.
You might want to take a look at that.


AWS Lambda documentation suggests that using pip is necessary for correct Lambda packaging. I had to play around with the setup.py a little bit and uploaded the package to pypi under a new atrocious name to make it pip compatible. We can clean this up and reevaluate at some point.

I followed this post: http://peterdowns.com/posts/first-time-with-pypi.html


It works :) you should be able to run it on android already.

I think it would be good to keep track of the scripts that are supported by a font to try those first in textShaper runs. Or peek into a TextRun first, before running harbuzz on it, by checking the script and look up available glyphs via freetype. But that are optimizations to consider later.


TeamCity pull requests :: netty [Build 1165](https://garage.netty.io/teamcity/viewLog.html?buildId=5294&buildTypeId=pulls_netty&guest=1) is now running


`expect(result.baz).to.be.deep.equal(myArray)`


Cool I`ll do that


information for GTEX-PLZ6 retrieved from original file:
phs000424.v6.pht002742.v6.p1.c1.GTEx_Subject_Phenotypes.GRU.txt

value = 1
column MHCOCAINE5 (=means, Cocaine use in the past 5 years)


should we do csv for this or JSON to follow the pattern with market-hours-database ?  no need for a change, just posing the question. It certainly can clean up the read/write of these files


How so?  Do you have some output?


This test is less specific than its name suggests.


I agree. Hopefully we can get a hardfork so that we can re-use PM assets eventually.
Until then, this fee should probably be lower. Do you think $25 is something that can work out for PMs?
Also keep in mind that we can reduce the fee if a business approaches the committee and demands lower fees.


ok


> Let's keep the build scripts as before c2833ba, with these two stringifications replaced by a compact variant?

Sounds good..


project name == symbolic name is OSGi convention.  I feel that is the
correct one to go forward with.  But to that end, we need to make sure that
when people use "package like names" for project names, it works correctly
with the rest of the templates.

e.g.
blade create -t mvcportlet com.liferay.banking.web

Will create a project with defaults that make sense.  Like right now I
think that creates a portlet class calldd
ComLiferayBankingWebPortlet.java.  Which is probably not a good default :)
 Probably should just go with the latest "segment" as the portlet name.  or
the last two sgements.  Like "BankingWebPortlet" or "WebPortlet".

If you imagine that first two segements are generally
"<org|net|com>.<company|foundation>.<projectname>"

Then perhaps the blade CLI when picking a default Classname whould strip
first two segments off of a package name and use last two camel case.

On Sun, Jan 31, 2016 at 7:54 PM, Andy Wu <notifications@github.com> wrote:

> so as a developer without knowing liferay conventions , I would expect my
> project name as bnd symbolic name .
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/david-truong/liferay-blade-tools/commit/72bcfc407e288d38f423d0326b6aa6033f99d0d3#commitcomment-15789365>
> .
>

--
Greg Amerson
Liferay Developer Tools
Liferay, Inc. www.liferay.com


Do we have to assert that in this test, too? It was already asserted in `test_cut_pbf_calls_osmconvert`, although without the `as pbf_file_path` part in the `with` header.


This should probably be `// read recorded by find`


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/3146


It looks like [`define_negated_matcher` has been added only in RSpec-Expectations 3.1.0](https://github.com/rspec/rspec-expectations/blob/master/Changelog.md#310--2014-09-04). It also has failed in Travis - https://travis-ci.org/jnicklas/capybara/jobs/105812950


I know a lot of the tests are written in this style, but I personally dislike all this boiler plate code that does not have anything to do with the test itself.  I would not bother with the `on('connected')` or even the `attach(callback)` functions as the connection is implicitly connected, and the [channel when subscribed to is implicitly attach](http://docs.ably.io/client-lib-development-guide/features/#RTL7c).  Why not having something more readable in regards to what it is testing as follows:

```javascript
exports.publishEchoTrue = function(test) {
  test.expect(1);
  var realtime = helper.AblyRealtime({ echoMessages: true });
  var rtChannel = realtime.channels.get('publishecho');
  rtChannel.subscribe('event0', function(msg) {
    test.ok(true, 'event0 echoed back on connection as expected');
    closeAndFinish(test, realtime);
  });
  rtChannel.publish('event0', 'payload');
};
```

Do you think that is simpler to read and understand what it is it is testing?

Note, manually checking for timeouts is unnecessary due to `https://github.com/ably/ably-js/blob/master/spec/common/modules/shared_helper.js#L102-L126` and https://github.com/alex-georgiou/ably-js/blob/cdc7282abec1acacfc7746bf80a71f39b356007c/spec/realtime/message.test.js#L658 being applied plus https://github.com/ably/ably-js/blob/master/spec/common/modules/shared_helper.js#L27-L35 to cancel a test if the connection fails.

I also personally don't see much benefit in catching generic exceptions within tests as we don't expect that to happen in reality because the runtime errors will most likely happen in a different context within callbacks.


I think this overload should just accept the `SymbolProperties` class to follow the pattern with the other overload.


@borshop merge


> Can't you just check if the string representation starts with a -?

I'm not quite sure what do you mean.

The test case is `Interval(-1.0,1.0)`; it doesn't satisfy being less than zero, nor larger than zero, so I think is ok to simply add the interval as it is, to get something like `[-1.0,1.0] t`.

If you consider the interval `Interval(-2.0,-1.0)`, it could be written as `-[1.0,2.0]`, but that would be too specific for Intervals; that's the reason I opted for the simple `[-2.0,-1.0]` choice.


Actually, I see it does, so not sure why circleci is choking on this.


а тут убрать 2 пробела


и тут убрать 2 пробела


My thoughts here have been to given another motivation to keep machines up and running so that witnesses do not need to switch over to failsafe. But I think you are right. Having this fee at anything about 1$c is probably resulting in witnesses just missing blocks instead of switching over.


ну и тут)


should be separated


hi! would love to accept this if you want to submit a pr!


also you need to build this change right?


блок с подсчётом суммы логичнее поставить сразу в проверку на массив, что скажешь?


Unlikely, I haven't found anything. And `element.previousElementSibling` has good browser support,

https://developer.mozilla.org/en-US/docs/Web/API/NonDocumentTypeChildNode/previousElementSibling