[inst/benchmarks/profviz-wtc_sig.R:16:21:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L16) *style:* **Commas should always have a space after.**
```r
d1.ar1 <- arima(d1[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[inst/benchmarks/profviz-wtc_sig.R:17:21:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L17) *style:* **Commas should always have a space after.**
```r
d2.ar1 <- arima(d2[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[inst/benchmarks/profviz-wtc_sig.R:34:1:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L34) *style:* **Variable and function names should be all lowercase.**
```r
registerDoParallel(cl)
^~~~~~~~~~~~~~~~~~
```
[inst/benchmarks/profviz-wtc_sig.R:48:33:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L48) *style:* **Commas should always have a space after.**
```r
        .init = array(dim = c(3,3,nrands)),
                                ^
```
[inst/benchmarks/profviz-wtc_sig.R:48:35:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L48) *style:* **Commas should always have a space after.**
```r
        .init = array(dim = c(3,3,nrands)),
                                  ^
```
[inst/benchmarks/profviz-wtc_sig.R:50:14:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L50) *style:* **Commas should always have a space after.**
```r
          y[,,x$r] <- x$a
             ^
```
[inst/benchmarks/profviz-wtc_sig.R:52:9:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L52) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
        }) %dopar% {
        ^
```
[inst/benchmarks/profviz-wtc_sig.R:53:43:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L53) *style:* **Commas should always have a space after.**
```r
          list(r = r, a = array(dim = c(3,3), (1:9) * r))
                                          ^
```
[inst/benchmarks/profviz-wtc_sig.R:70:3:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L70) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  {seq_len(1000000)},
  ^
```
[inst/benchmarks/profviz-wtc_sig.R:70:20:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L70) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  {seq_len(1000000)},
                   ^
```
[inst/benchmarks/profviz-wtc_sig.R:71:3:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L71) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  {1:1000000},
  ^
```
[inst/benchmarks/profviz-wtc_sig.R:71:13:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L71) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  {1:1000000},
            ^
```
[inst/benchmarks/profviz-wtc_sig.R:82:36:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L82) *style:* **Commas should always have a space after.**
```r
    out1 <- apply(ts, MARGIN = c(1,2), quantile, 0.95, na.rm = TRUE)
                                   ^
```
[inst/benchmarks/profviz-wtc_sig.R:86:14:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L86) *style:* **Commas should always have a space after.**
```r
      out2[i,] <- row_quantile(ts[i,,], 0.95)
             ^
```
[inst/benchmarks/profviz-wtc_sig.R:86:37:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L86) *style:* **Commas should always have a space after.**
```r
      out2[i,] <- row_quantile(ts[i,,], 0.95)
                                    ^
```
[inst/benchmarks/profviz-wtc_sig.R:92:13:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L92) *style:* **Commas should always have a space after.**
```r
      out3[,i] <- row_quantile(ts[,i,], 0.95)
            ^
```
[inst/benchmarks/profviz-wtc_sig.R:92:36:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L92) *style:* **Commas should always have a space after.**
```r
      out3[,i] <- row_quantile(ts[,i,], 0.95)
                                   ^
```
[inst/benchmarks/profviz-wtc_sig.R:92:38:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/inst/benchmarks/profviz-wtc_sig.R#L92) *style:* **Commas should always have a space after.**
```r
      out3[,i] <- row_quantile(ts[,i,], 0.95)
                                     ^
```
[R/check.data.R:31:8:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/check.data.R#L31) *warning:* **no visible global function definition for ‘check.datum’**
```r
  y <- check.datum(y)
       ^~~~~~~~~~~
```
[R/check.data.R:34:11:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/check.data.R#L34) *warning:* **no visible global function definition for ‘check.datum’**
```r
    x1 <- check.datum(x1)
          ^~~~~~~~~~~
```
[R/check.data.R:44:11:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/check.data.R#L44) *warning:* **no visible global function definition for ‘check.datum’**
```r
    x2 <- check.datum(x2)
          ^~~~~~~~~~~
```
[R/check.data.R:61:47:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/check.data.R#L61) *style:* **Commas should always have a space after.**
```r
    if (class(x[, 1])[1] == "Date" | class(x[,1])[1] == "POSIXct") {
                                              ^
```
[R/phase.plot.R:38:17:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L38) *style:* **Commas should always have a space after.**
```r
  phases[-a.row,] <- NA
                ^
```
[R/phase.plot.R:39:11:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L39) *style:* **Commas should always have a space after.**
```r
  phases[,-a.col] <- NA
          ^
```
[R/phase.plot.R:43:27:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L43) *style:* **Commas should always have a space after.**
```r
      if (!is.na(phases[i,j])) {
                          ^
```
[R/phase.plot.R:45:32:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L45) *style:* **Commas should always have a space after.**
```r
              alpha = phases[i,j], col = arrow.col)
                               ^
```
[R/phase.plot.R:76:60:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                           ^
```
[R/phase.plot.R:76:63:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                              ^
```
[R/phase.plot.R:76:66:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                                 ^
```
[R/phase.plot.R:76:69:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                                    ^
```
[R/phase.plot.R:76:72:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                                       ^
```
[R/phase.plot.R:76:75:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                                          ^
```
[R/phase.plot.R:77:60:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                           ^
```
[R/phase.plot.R:77:63:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                              ^
```
[R/phase.plot.R:77:66:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                                 ^
```
[R/phase.plot.R:77:69:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                                    ^
```
[R/phase.plot.R:77:72:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                                       ^
```
[R/phase.plot.R:77:75:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                                          ^
```
[R/plot.biwavelet.R:114:29:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/plot.biwavelet.R#L114) *style:* **Commas should always have a space after.**
```r
                     "cyan","#7FFF7F", "yellow",
                            ^
```
[R/pwtc.R:89:40:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/pwtc.R#L89) *warning:* **no visible binding for global variable ‘MOTHERS’**
```r
  mother <- match.arg(tolower(mother), MOTHERS)
                                       ^~~~~~~
```
[R/pwtc.R:91:14:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/pwtc.R#L91) *warning:* **no visible global function definition for ‘check.data’**
```r
  checked <- check.data(y = y, x1 = x1, x2 = x2)
             ^~~~~~~~~~
```
[R/pwtc.R:105:21:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/pwtc.R#L105) *style:* **Commas should always have a space after.**
```r
  y.ar1 <- arima(y[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[R/pwtc.R:106:23:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/pwtc.R#L106) *style:* **Commas should always have a space after.**
```r
  x1.ar1 <- arima(x1[,2], order = c(1, 0, 0))$coef[1]
                      ^
```
[R/pwtc.R:122:20:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/pwtc.R#L122) *style:* **Commas should always have a space after.**
```r
  y.sigma <- sd(y[,2], na.rm = TRUE)
                   ^
```
[R/pwtc.R:123:22:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/pwtc.R#L123) *style:* **Commas should always have a space after.**
```r
  x1.sigma <- sd(x1[,2], na.rm = TRUE)
                     ^
```
[R/pwtc.R:145:20:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/pwtc.R#L145) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.cw_yx1 <- smooth.wavelet(s.inv * (cw.yx1), dt, dj, wt.y$scale)
                   ^~~~~~~~~~~~~~
```
[R/pwtc.R:146:20:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/pwtc.R#L146) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.cw_yx2 <- smooth.wavelet(s.inv * (cw.yx2), dt, dj, wt.y$scale)
                   ^~~~~~~~~~~~~~
```
[R/pwtc.R:147:21:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/pwtc.R#L147) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.cw_x1x2 <- smooth.wavelet(s.inv * (cw.x1x2), dt, dj, wt.y$scale)
                    ^~~~~~~~~~~~~~
```
[R/smooth.wavelet.R:51:37:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/smooth.wavelet.R#L51) *style:* **Commas should always have a space after.**
```r
    wave.pad[seq_len(m)] <- wave[ii,]
                                    ^
```
[R/smooth.wavelet.R:68:12:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/smooth.wavelet.R#L68) *warning:* **no visible global function definition for ‘convolve2D_typeopen’**
```r
  swave <- convolve2D_typeopen(twave, rev(ker))
           ^~~~~~~~~~~~~~~~~~~
```
[R/smooth.wavelet.R:71:41:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/smooth.wavelet.R#L71) *style:* **Commas should always have a space after.**
```r
  swave[keep.start:(keep.start + n - 1),]
                                        ^
```
[R/wclust.R:40:21:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wclust.R#L40) *style:* **Commas should always have a space after.**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                    ^
```
[R/wclust.R:40:27:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wclust.R#L40) *warning:* **no visible global function definition for ‘wdist’, Did you mean 'dist'?**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                          ^~~~~
```
[R/wclust.R:40:42:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wclust.R#L40) *style:* **Commas should never have a space before.**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                                        ~^
```
[R/wclust.R:40:43:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wclust.R#L40) *style:* **Commas should always have a space after.**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                                          ^
```
[R/wclust.R:40:55:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wclust.R#L40) *style:* **Commas should never have a space before.**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                                                     ~^
```
[R/wclust.R:40:56:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wclust.R#L40) *style:* **Commas should always have a space after.**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                                                       ^
```
[R/wdist.R:35:31:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wdist.R#L35) *style:* **Commas should always have a space after.**
```r
  u <- wsvd$u[seq_len(nfreqs),]
                              ^
```
[R/wdist.R:36:31:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wdist.R#L36) *style:* **Commas should always have a space after.**
```r
  v <- wsvd$v[seq_len(nfreqs),]
                              ^
```
[R/wdist.R:38:61:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wdist.R#L38) *style:* **Commas should always have a space after.**
```r
  Lnk <- t(u[, seq_len(nfreqs)]) %*% Re(wt1[seq_len(nfreqs),])
                                                            ^
```
[R/wdist.R:39:61:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wdist.R#L39) *style:* **Commas should always have a space after.**
```r
  Ljk <- t(v[, seq_len(nfreqs)]) %*% Re(wt2[seq_len(nfreqs),])
                                                            ^
```
[R/wdist.R:49:11:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wdist.R#L49) *style:* **Commas should always have a space after.**
```r
      (u[,2:NROW(u)] - v[,2:NROW(v)]))))
          ^
```
[R/wdist.R:49:27:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wdist.R#L49) *style:* **Commas should always have a space after.**
```r
      (u[,2:NROW(u)] - v[,2:NROW(v)]))))
                          ^
```
[R/wt.bases.R:32:12:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wt.bases.R#L32) *style:* **Put spaces around all infix operators.**
```r
    morlet =rcpp_wt_bases_morlet(...), # original wt.bases.morlet(...),
           ^~
```
[R/wt.R:75:14:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wt.R#L75) *warning:* **no visible global function definition for ‘check.datum’**
```r
  checked <- check.datum(d)
             ^~~~~~~~~~~
```
[R/wt.R:81:20:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wt.R#L81) *style:* **Commas should always have a space after.**
```r
  sigma2 <- var(d[,2])
                   ^
```
[R/wt.R:107:11:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wt.R#L107) *warning:* **no visible global function definition for ‘wt.bases’**
```r
    wb <- wt.bases(mother, k, scale[a1], param)
          ^~~~~~~~
```
[R/wt.sig.R:42:40:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wt.sig.R#L42) *warning:* **no visible binding for global variable ‘MOTHERS’**
```r
  mother <- match.arg(tolower(mother), MOTHERS)
                                       ^~~~~~~
```
[R/wtc_sig_parallel.R:24:10:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc_sig_parallel.R#L24) *warning:* **no visible global function definition for ‘get_minroots’**
```r
  mr1 <- get_minroots(lag1[1])
         ^~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:25:10:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc_sig_parallel.R#L25) *warning:* **no visible global function definition for ‘get_minroots’**
```r
  mr2 <- get_minroots(lag1[2])
         ^~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:28:22:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc_sig_parallel.R#L28) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
  d1 <- cbind(ntseq, ar1_ma0_sim(mr1, lag1[1], ntimesteps))
                     ^~~~~~~~~~~
```
[R/wtc_sig_parallel.R:36:11:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc_sig_parallel.R#L36) *style:* **Variable and function names should be all lowercase.**
```r
  NUMC <- getDoParWorkers()
          ^~~~~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:36:11:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc_sig_parallel.R#L36) *warning:* **no visible global function definition for ‘getDoParWorkers’**
```r
  NUMC <- getDoParWorkers()
          ^~~~~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:48:23:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc_sig_parallel.R#L48) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
                      }) %dopar% {
                      ^
```
[R/wtc_sig_parallel.R:58:26:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc_sig_parallel.R#L58) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
      d1 <- cbind(ntseq, ar1_ma0_sim(mr1, lag1[1], ntimesteps))
                         ^~~~~~~~~~~
```
[R/wtc_sig_parallel.R:59:26:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc_sig_parallel.R#L59) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
      d2 <- cbind(ntseq, ar1_ma0_sim(mr2, lag1[2], ntimesteps))
                         ^~~~~~~~~~~
```
[R/wtc_sig_parallel.R:71:14:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc_sig_parallel.R#L71) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
      sw1 <- smooth.wavelet(s.inv * (abs(wt1$wave) ^ 2), dt, dj, wt1$scale)
             ^~~~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:72:14:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc_sig_parallel.R#L72) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
      sw2 <- smooth.wavelet(s.inv * (abs(wt2$wave) ^ 2), dt, dj, wt2$scale)
             ^~~~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:96:5:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc_sig_parallel.R#L96) *warning:* **no visible global function definition for ‘row_quantile’**
```r
    row_quantile(rand.rsq[,j,], sig.level)
    ^~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:96:28:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc_sig_parallel.R#L96) *style:* **Commas should always have a space after.**
```r
    row_quantile(rand.rsq[,j,], sig.level)
                           ^
```
[R/wtc_sig_parallel.R:96:30:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc_sig_parallel.R#L96) *style:* **Commas should always have a space after.**
```r
    row_quantile(rand.rsq[,j,], sig.level)
                             ^
```
[R/wtc.R:97:40:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.R#L97) *warning:* **no visible binding for global variable ‘MOTHERS’**
```r
  mother <- match.arg(tolower(mother), MOTHERS)
                                       ^~~~~~~
```
[R/wtc.R:100:14:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.R#L100) *warning:* **no visible global function definition for ‘check.data’**
```r
  checked <- check.data(y = d1, x1 = d2)
             ^~~~~~~~~~
```
[R/wtc.R:115:23:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.R#L115) *style:* **Commas should always have a space after.**
```r
  d1.ar1 <- arima(d1[,2], order = c(1, 0, 0))$coef[1]
                      ^
```
[R/wtc.R:116:23:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.R#L116) *style:* **Commas should always have a space after.**
```r
  d2.ar1 <- arima(d2[,2], order = c(1, 0, 0))$coef[1]
                      ^
```
[R/wtc.R:128:22:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.R#L128) *style:* **Commas should always have a space after.**
```r
  d1.sigma <- sd(d1[,2], na.rm = T)
                     ^
```
[R/wtc.R:129:22:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.R#L129) *style:* **Commas should always have a space after.**
```r
  d2.sigma <- sd(d2[,2], na.rm = T)
                     ^
```
[R/wtc.R:134:17:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.R#L134) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.wt1 <- smooth.wavelet(s.inv * (abs(wt1$wave) ^ 2), dt, dj, wt1$scale)
                ^~~~~~~~~~~~~~
```
[R/wtc.R:135:17:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.R#L135) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.wt2 <- smooth.wavelet(s.inv * (abs(wt2$wave) ^ 2), dt, dj, wt2$scale)
                ^~~~~~~~~~~~~~
```
[R/wtc.R:153:16:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.R#L153) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.CW <- smooth.wavelet(s.inv * (CW), dt, dj, wt1$scale)
               ^~~~~~~~~~~~~~
```
[R/wtc.sig.R:59:10:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.sig.R#L59) *warning:* **no visible global function definition for ‘get_minroots’**
```r
  mr1 <- get_minroots(lag1[1])
         ^~~~~~~~~~~~
```
[R/wtc.sig.R:60:10:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.sig.R#L60) *warning:* **no visible global function definition for ‘get_minroots’**
```r
  mr2 <- get_minroots(lag1[2])
         ^~~~~~~~~~~~
```
[R/wtc.sig.R:63:22:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.sig.R#L63) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
  d1 <- cbind(ntseq, ar1_ma0_sim(mr1, lag1[1], ntimesteps))
                     ^~~~~~~~~~~
```
[R/wtc.sig.R:79:24:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.sig.R#L79) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
    d1 <- cbind(ntseq, ar1_ma0_sim(mr1, lag1[1], ntimesteps))
                       ^~~~~~~~~~~
```
[R/wtc.sig.R:80:24:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.sig.R#L80) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
    d2 <- cbind(ntseq, ar1_ma0_sim(mr2, lag1[2], ntimesteps))
                       ^~~~~~~~~~~
```
[R/wtc.sig.R:92:12:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.sig.R#L92) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
    sw1 <- smooth.wavelet(s.inv * (abs(wt1$wave) ^ 2), dt, dj, wt1$scale)
           ^~~~~~~~~~~~~~
```
[R/wtc.sig.R:93:12:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.sig.R#L93) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
    sw2 <- smooth.wavelet(s.inv * (abs(wt2$wave) ^ 2), dt, dj, wt2$scale)
           ^~~~~~~~~~~~~~
```
[R/wtc.sig.R:95:16:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.sig.R#L95) *style:* **Commas should never have a space before.**
```r
    rand.rsq[, , r] <- abs(smooth.CW) ^ 2 / (sw1 * sw2)
              ~^
```
[R/wtc.sig.R:111:13:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.sig.R#L111) *style:* **Commas should always have a space after.**
```r
    result[,i] <- row_quantile(rand.rsq[,i,], sig.level)
            ^
```
[R/wtc.sig.R:111:19:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.sig.R#L111) *warning:* **no visible global function definition for ‘row_quantile’**
```r
    result[,i] <- row_quantile(rand.rsq[,i,], sig.level)
                  ^~~~~~~~~~~~
```
[R/wtc.sig.R:111:42:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.sig.R#L111) *style:* **Commas should always have a space after.**
```r
    result[,i] <- row_quantile(rand.rsq[,i,], sig.level)
                                         ^
```
[R/wtc.sig.R:111:44:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/wtc.sig.R#L111) *style:* **Commas should always have a space after.**
```r
    result[,i] <- row_quantile(rand.rsq[,i,], sig.level)
                                           ^
```
[R/xwt.R:75:40:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/xwt.R#L75) *warning:* **no visible binding for global variable ‘MOTHERS’**
```r
  mother <- match.arg(tolower(mother), MOTHERS)
                                       ^~~~~~~
```
[R/xwt.R:78:14:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/xwt.R#L78) *warning:* **no visible global function definition for ‘check.data’**
```r
  checked <- check.data(y = d1, x1 = d2)
             ^~~~~~~~~~
```
[R/xwt.R:93:23:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/xwt.R#L93) *style:* **Commas should always have a space after.**
```r
  d1.ar1 <- arima(d1[,2], order = c(1, 0, 0))$coef[1]
                      ^
```
[R/xwt.R:94:23:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/xwt.R#L94) *style:* **Commas should always have a space after.**
```r
  d2.ar1 <- arima(d2[,2], order = c(1, 0, 0))$coef[1]
                      ^
```
[R/xwt.R:105:22:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/xwt.R#L105) *style:* **Commas should always have a space after.**
```r
  d1.sigma <- sd(d1[,2], na.rm = T)
                     ^
```
[R/xwt.R:106:22:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/xwt.R#L106) *style:* **Commas should always have a space after.**
```r
  d2.sigma <- sd(d2[,2], na.rm = T)
                     ^
```
[R/xwt.R:127:9:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/xwt.R#L127) *warning:* **no visible global function definition for ‘ar1.spectrum’**
```r
  P1 <- ar1.spectrum(d1.ar1, wt1$period / dt)
        ^~~~~~~~~~~~
```
[R/xwt.R:128:9:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/R/xwt.R#L128) *warning:* **no visible global function definition for ‘ar1.spectrum’**
```r
  P2 <- ar1.spectrum(d2.ar1, wt2$period / dt)
        ^~~~~~~~~~~~
```
[tests/testthat/test-convolve2D.R:7:12:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-convolve2D.R#L7) *style:* **Commas should always have a space after.**
```r
  y <- c(1,1,2)
           ^
```
[tests/testthat/test-convolve2D.R:7:14:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-convolve2D.R#L7) *style:* **Commas should always have a space after.**
```r
  y <- c(1,1,2)
             ^
```
[tests/testthat/test-convolve2D.R:9:27:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-convolve2D.R#L9) *style:* **Commas should always have a space after.**
```r
    convolve2D_typeopen(x,y),
                          ^
```
[tests/testthat/test-convolve2D.R:10:18:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-convolve2D.R#L10) *style:* **Commas should always have a space after.**
```r
    convolve2D(x,y, type = "open"))
                 ^
```
[tests/testthat/test-convolve2D.R:15:12:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-convolve2D.R#L15) *style:* **Commas should always have a space after.**
```r
  y <- c(1,1,2)
           ^
```
[tests/testthat/test-convolve2D.R:15:14:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-convolve2D.R#L15) *style:* **Commas should always have a space after.**
```r
  y <- c(1,1,2)
             ^
```
[tests/testthat/test-convolve2D.R:17:18:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-convolve2D.R#L17) *style:* **Commas should always have a space after.**
```r
    convolve2D(x,y, type = "circular"),
                 ^
```
[tests/testthat/test-convolve2D.R:20:1:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-convolve2D.R#L20) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-convolve2D.R:21:1:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-convolve2D.R#L21) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-plot.biwavelet.R:27:1:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-plot.biwavelet.R#L27) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test-rowQuantileC.R:41:22:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                     ^
```
[tests/testthat/test-rowQuantileC.R:41:24:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                       ^
```
[tests/testthat/test-rowQuantileC.R:41:27:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                          ^
```
[tests/testthat/test-rowQuantileC.R:41:29:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                            ^
```
[tests/testthat/test-rowQuantileC.R:41:31:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                              ^
```
[tests/testthat/test-rowQuantileC.R:41:33:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                                ^
```
[tests/testthat/test-rowQuantileC.R:41:35:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                                  ^
```
[tests/testthat/test-rowQuantileC.R:41:37:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                                    ^
```
[tests/testthat/test-rowQuantileC.R:41:40:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                                       ^
```
[tests/testthat/test-wclust.R:17:10:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-wclust.R#L17) *style:* **Commas should never have a space before.**
```r
w.arr[1, , ] <- wt.t1$wave
        ~^
```
[tests/testthat/test-wclust.R:18:10:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-wclust.R#L18) *style:* **Commas should never have a space before.**
```r
w.arr[2, , ] <- wt.t2$wave
        ~^
```
[tests/testthat/test-wclust.R:19:10:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-wclust.R#L19) *style:* **Commas should never have a space before.**
```r
w.arr[3, , ] <- wt.t3$wave
        ~^
```
[tests/testthat/test-wclust.R:28:37:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-wclust.R#L28) *style:* **Commas should always have a space after.**
```r
  expect_equal(dim(c$diss.mat), c(3,3))
                                    ^
```
[tests/testthat/test-wtc_sig_parallel.R:9:21:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-wtc_sig_parallel.R#L9) *style:* **Commas should always have a space after.**
```r
d1.ar1 <- arima(d1[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[tests/testthat/test-wtc_sig_parallel.R:10:21:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-wtc_sig_parallel.R#L10) *style:* **Commas should always have a space after.**
```r
d2.ar1 <- arima(d2[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[tests/testthat/test-wtc_sig_parallel.R:39:34:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-wtc_sig_parallel.R#L39) *style:* **Commas should always have a space after.**
```r
    expect_equal( dim(out), c(42,64) )
                                 ^
```
[tests/testthat/test-wtc.sig.R:9:21:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-wtc.sig.R#L9) *style:* **Commas should always have a space after.**
```r
d1.ar1 <- arima(d1[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[tests/testthat/test-wtc.sig.R:10:21:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-wtc.sig.R#L10) *style:* **Commas should always have a space after.**
```r
d2.ar1 <- arima(d2[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[tests/testthat/test-wtc.sig.R:39:34:](https://github.com/vsimko/biwavelet/blob/3e18c676910c61c28b7fe57eaec52b961ef960d0/tests/testthat/test-wtc.sig.R#L39) *style:* **Commas should always have a space after.**
```r
    expect_equal( dim(out), c(42,64) )
                                 ^
```


Thank you for your contribution.


```
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running com.adobe.people.justinedelson.uberjardemo.impl.ClassExtendingDefaultAuthenticationFeedbackHandlerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.044 sec - in com.adobe.people.justinedelson.uberjardemo.impl.ClassExtendingDefaultAuthenticationFeedbackHandlerTest
Running com.adobe.people.justinedelson.uberjardemo.impl.ClassWhichHasAEMInterfacePassedInTest
objc[62094]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.8.0_60.jdk/Contents/Home/jre/bin/java and /Library/Java/JavaVirtualMachines/jdk1.8.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.401 sec - in com.adobe.people.justinedelson.uberjardemo.impl.ClassWhichHasAEMInterfacePassedInTest
Running com.adobe.people.justinedelson.uberjardemo.impl.ComponentWhichHasAEMInterfaceInjectedTest
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.021 sec <<< FAILURE! - in com.adobe.people.justinedelson.uberjardemo.impl.ComponentWhichHasAEMInterfaceInjectedTest
test_that_long_string_is_trimmed(com.adobe.people.justinedelson.uberjardemo.impl.ComponentWhichHasAEMInterfaceInjectedTest)  Time elapsed: 0.018 sec  <<< ERROR!
java.lang.InternalError

Results :

Tests in error:
  ComponentWhichHasAEMInterfaceInjectedTest.test_that_long_string_is_trimmed » Internal

Tests run: 3, Failures: 0, Errors: 1, Skipped: 0
```


does this mean the user is a moderator of these subreddits, or that the user is a subscriber to them?


With this, the database should be complete.


@XhmikosR Feel free to publish the release notes draft :)


nit: maybe make it raw instead of json


lgtm


I believe if you declare `diff` as a double, then you won't need the two c-style casts on the following line.


I am just checking


Why this is required? Can you write a unit test to demonstrate what is happening?


Ah, stable-2.0 commit is 7f2bc082fa75560155b0f50e2de2d7e8a3560bd7.  Sorry.


I wonder why switching to double quote? Is it necessary? It might cause some compatibility issues. As far as I know I'm unaware of other projects that are based on Calcite have this turned on.


This is a testing brnach


See https://github.com/palantir/atlasdb/commit/cb76971ec949d2fb1baf37e46fd45bc5ec483272


Testing on brnaach


I calculated some efficiency factors for the various threshold configurations by sampling the closest 8-bit thresholds based on 200 equally spaced power levels with rms covering 29 to 31 channels. The correlator level assignments are assumed to be -3.3, -1, 1, 3.3.

0.882478 +/- 0   for exact 0.16 0.84 thresholds
0.882354 +/- .000053 for original R2 with DC (rho=0) bias not removed (in correlator)
0.882355 +/- .000053 for original R2 with DC (rho=0) bias removed by adjusting level assignments
0.882354 +/- .000053 using dithering on the 0 bin
0.882457 +/- .000051 if 0 bin edge can be set at V=0


Maybe removing the dependency of guava? Occasionally we extend the test to run on a real Storm cluster. Taking care of the dependency is nontrivial.


I love that this is here already. Thank you @cameronmalek!!


I was just trying this out and I noticed some console logging that I think may have come from this line. Did you leave this here intentionally?


nie sprawdzasz konkretnych cech, bo robi to konstruktor VideoSignature – ale sprawdź że faktycznie VideoSignature przyszło


Webpack is making a horrid mess. All of the sudden all `import` statements
silently return undefined and `npm run serve` recompiles on change, but
keeps serving the old bundle version.

On Sat, Feb 27, 2016 at 7:25 AM, Francesco Orsenigo <
francesco.orsenigo@gmail.com> wrote:

> Interesting. Will do.
> I am strggling with using the old pure Task object I had created with the
> new architecture, yesterday I decided that I will have to port that as well
> because it's a pain in the ass to make redux and the stateful object
> coexist (mostly also because the object needs the actions to be available
> already, but the actions can be created once the store is available, but
> the store is available only once we have the statueful object available....
>
> On Fri, Feb 26, 2016 at 10:24 PM, Cameron Chamberlain <
> notifications@github.com> wrote:
>
>> I'd suggest seamless-immutable over immutable.js
>> See
>> http://tech.noredink.com/post/107617838018/switching-from-immutablejs-to-seamless-immutable
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/xarvh/cortex/commit/d4c3911c11dd136ced3b6ad4c8978f38116f187f#commitcomment-16349949>
>> .
>>
>
>


Let's separate it into another jira? I think it makes a lot of sense to do the refactor first as it can quickly grow very complicated.


Oui bon en meme temps j'ai pas d'IDE sur l'ordi sur lequel je bosse.
DONC, j'ai pas testé.
à vos risques et perils incha' allah


Merging


The effect is very small here for 8bit to 2bit, but just to double check is SWARM DBE dithering the 0 bin to go from ~4bit to 2bit?


Bug I was talking about in the commit log:
https://gyazo.com/36205514ff3f178627c896e8f117c59f


Pillow as well, otherwise image-manipulation functions are missing from the docs: see  https://github.com/scipy/scipy/issues/5870.


zrobiłeś bardzo ogólną, „skomplikowaną” metodę

a wystarczyłoby proste `_validate_not_empty_str(self, $value)`

zrób coś ze 3 razy i wtedy wyciągaj abstrakcję => a dopóki nie potrzebujesz to KISS


5499-Electric-Service-Follow-Up (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1570 of 1570 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.78%25-green.svg)


Sure, just reply on the pr when your first pass is done and I'll upload new commits


Cycletime above is just 33hz! That isnt very often and should not work really well. Also in my tests accelerometer causes much more jitter on motor output.

It always can be enabled manually


długość na pewno powinna być napisem? nie byłoby logiczniej, gdyby była floatem lub intem?


how is this different from the sslCert in L7?


newline missing :)


te views to nie powinna być liczba?


jak dokładasz nowe reguły to od razu test jednostkowy niech to pokazuje


https://github.com/millermedeiros/esformatter in package.json ?


„equal **to** xyz”


Ignore this commit, it doesn't solve the problem the right way.


```

$ ls -la ~/Downloads/uber-jar-6.1.0-SP1-obfuscated-apis/org/apache/sling/auth/core/spi
total 80
drwxrwxr-x  12 cpilsworth  staff   408 26 Feb 22:25 .
drwxrwxr-x   8 cpilsworth  staff   272 26 Feb 22:24 ..
-rw-rw-r--   1 cpilsworth  staff  1311 22 Feb 20:13 AbstractAuthenticationFormServlet.class
-rw-rw-r--   1 cpilsworth  staff  1699 22 Feb 20:13 AbstractAuthenticationHandler.class
-rw-rw-r--   1 cpilsworth  staff   507 22 Feb 20:13 AuthenticationFeedbackHandler.class
-rw-rw-r--   1 cpilsworth  staff  1603 22 Feb 20:13 AuthenticationHandler$FAILURE_REASON_CODES.class
-rw-rw-r--   1 cpilsworth  staff  1122 22 Feb 20:13 AuthenticationHandler.class
-rw-rw-r--   1 cpilsworth  staff  1025 22 Feb 20:13 AuthenticationInfo$ReadOnlyAuthenticationInfo.class
-rw-rw-r--   1 cpilsworth  staff  1640 22 Feb 20:13 AuthenticationInfo.class
-rw-rw-r--   1 cpilsworth  staff   541 22 Feb 20:13 AuthenticationInfoPostProcessor.class
-rw-rw-r--   1 cpilsworth  staff   931 22 Feb 20:13 DefaultAuthenticationFeedbackHandler.class
-rw-rw-r--   1 cpilsworth  staff   232 22 Feb 20:13 package-info.class

$ ls -la ~/Downloads/uber-jar-6.1.0-obfuscated-apis/org/apache/sling/auth/core/spi
total 88
drwxr-xr-x  12 cpilsworth  staff   408 26 Feb 22:38 .
drwxr-xr-x   8 cpilsworth  staff   272 26 Feb 22:38 ..
-rw-r--r--   1 cpilsworth  staff  5187 22 Jul  2015 AbstractAuthenticationFormServlet.class
-rw-r--r--   1 cpilsworth  staff  2888 22 Jul  2015 AbstractAuthenticationHandler.class
-rw-r--r--   1 cpilsworth  staff   507 22 Jul  2015 AuthenticationFeedbackHandler.class
-rw-r--r--   1 cpilsworth  staff  1603 22 Jul  2015 AuthenticationHandler$FAILURE_REASON_CODES.class
-rw-r--r--   1 cpilsworth  staff  1122 22 Jul  2015 AuthenticationHandler.class
-rw-r--r--   1 cpilsworth  staff  1408 22 Jul  2015 AuthenticationInfo$ReadOnlyAuthenticationInfo.class
-rw-r--r--   1 cpilsworth  staff  2950 22 Jul  2015 AuthenticationInfo.class
-rw-r--r--   1 cpilsworth  staff   541 22 Jul  2015 AuthenticationInfoPostProcessor.class
-rw-r--r--   1 cpilsworth  staff  3310 22 Jul  2015 DefaultAuthenticationFeedbackHandler.class
-rw-r--r--   1 cpilsworth  staff   232 22 Jul  2015 package-info.class
```


fix-window-frame-calcs-5095 (nealkruis) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


you could do `r'\[(?P<severity>error|warning)\]' ...` so it actually matches `error` and `warning` without the [] brackets. That simplifies your severity_map below and also removes the redundancy of defining the bracket matching twice^^


No, I forgot to pull down, so it had issues merging from gigs auto import. I think there is a plugin for idea to use an eclipse code style. I will look into it.


This fails with a `TypeError` if `prio_str` is still `None`. I'll fix it when I submit my version.


Can message be empty? If not I would suggest using `.+` instead of `.*`


That's the GCE object (output of gcloud compute list ssl-certs), this is all the info from the Kubernetes object. Essentially: this TLS + defaults = sslCert, and I don't want to leak GCE details into the controller and I don't want to leak Kubernetes api in here (changes are easier to make, unittest mocks are easier to create etc).


ponieważ dorzuciłeś walidację, to nie chciałbyś, żeby ktoś zrobił `videoSignature.author = 12` – pola zrób prywatne i dorób gettery to tych, które potrzebujesz „na zewnątrz”

BTW, w ogóle je potrzebujesz? bo nie widzę, żebyś wykorzystywał ;-)


Mouseover scrollbars is still causing the popup. At least in Chrome.

Replacing 208-215 with the code below seems to work:
```
this.addEvent(document, "mouseout", function(e) {
	if(e.clientY < 0) {
		bioEp.showPopup();
	}
});
```


Ok, I was able to find a strange sequence that causes it.  I think there might be some kind of sensor initialization scenario that's related as I saw this happening when I was enabling/disabling the accel but had trouble replicating.  Just for fun I tried switching on the mag by set mag_hardware = auto and triggered the problem.  The funny thing is that this board doesn't have a magnetometer.  I was able to repeat this a couple of times.  The only thing that makes the CPU% go back to normal is a hard power reset.  The problem is that I can't find a pattern.  It just seems like switching the sensors on/off and then the reboot after the save causes something to use 100% CPU and stay there.  After hard powering the board the CPU utilization returns to normal.  I was able to capture the status and tasks in the CLI while this occurred:

```
# status
System Uptime: 19 seconds, Voltage: 49 * 0.1V (2S battery - CRITICAL), CPU:100%
CPU Clock=72MHz, GYRO=MPU6050, ACC=MPU6050.n
Cycle Time: 368, I2C Errors: 2, config size: 1388

# tasks
Task list:
0 - (SYSTEM) max: 8us, avg: 0us, rate: 8hz, total: 1ms
1 - (PID) max: 259us, avg: 226us, rate: 1838hz, total: 18sec
- - (GYRO)  rate: 3676hz
2 - (ACCEL) max: 152us, avg: 82us, rate: 16hz, total: 42ms
3 - (SERIAL) max: 633us, avg: 2us, rate: 46hz, total: 25ms
4 - (BEEPER) max: 8us, avg: 0us, rate: 46hz, total: 1ms
5 - (BATTERY) max: 40062us, avg: 8us, rate: 24hz, total: 44ms
6 - (RX) max: 83us, avg: 52us, rate: 24hz, total: 39ms

# tasks
Task list:
0 - (SYSTEM) max: 8us, avg: 0us, rate: 6hz, total: 3ms
1 - (PID) max: 259us, avg: 225us, rate: 1358hz, total: 56sec
- - (GYRO)  rate: 2717hz
2 - (ACCEL) max: 152us, avg: 82us, rate: 15hz, total: 117ms
3 - (SERIAL) max: 18014us, avg: 2us, rate: 47hz, total: 48ms
4 - (BEEPER) max: 8us, avg: 0us, rate: 49hz, total: 5ms
5 - (BATTERY) max: 40062us, avg: 8us, rate: 24hz, total: 52ms
6 - (RX) max: 83us, avg: 52us, rate: 24hz, total: 115ms

# status
System Uptime: 66 seconds, Voltage: 50 * 0.1V (2S battery - CRITICAL), CPU:100%
CPU Clock=72MHz, GYRO=MPU6050, ACC=MPU6050.n
Cycle Time: 337, I2C Errors: 2, config size: 1388
```


I would use plain ` ` and not `\s`, since `\s` also matches newlines, tabs and others^^


Why does this return nothing? Silly mistake.


And since line is a number, you could provide a regex that matches a number, you could use e.g. `\d+`


same here with number pattern matching :)


waliduj albo rzutuj na liczbę


and whitespaces :D


I have a lot of print statements everywhere, I just comment them out whenever I no longer need them, which I admit is not so good of a practice. How would you suggest I do debugging? or add logging?


I hope this will be the last cleanup ever needed to stweaks descriptions. Spent a good few hours working on these changes :)


Just FYI I haven't found the implementation for the `StrandContext` constructor in this commit.  I assume it's coming later.


When I do CTRL+SHIFT+O it auto imports and reorganizes the list. It's not very smart and replaces all the .* with each import individually.


This never happened.


Thanks for staying on top of release cadence :heart:


> Cycletime above is just 33hz! That isnt very often and should not work really well. Also in my tests accelerometer causes much more jitter on motor output.

>It always can be enabled manually

Fair enough.  Acclerometer is probably not going to work well at 4K gyro on the F3.  I was just curious why it was disabled.  Just not enough processing time available I guess.  I haven't been able to figure out a sequence with the 100% CPU yet.  The weird thing is that the problem persists across reboots and only clears on a hard power cycle.


goodwork


The note could be detail documentation, so instead of
`Checks the code with dart-linter. Note: [...]`
I would do
```
Checks the code with ``dart-linter``.

This bear expects dart [...]
```


After discussions today, I did more testing and everything seems to be working as it should. No more errors and no need for the `time.sleep(1)` hack anymore. This is great news.

It is easer to just sommunicate the small changes necessary here than making a commit or PR as things need to be cleaned up anyway. There are only three very small changes.

1. remove `time.sleep(1)`
2. in `gpsmixer.py` remove line 56 `self.move_listener(listener)`
3. in `lib/api.py` add one line for `move_listener` (~135), shown here in context:
```
    apache_safe_daemon_subprocess(command)
    wait_for_stream(session.id, audio_format)

move_listener(request)

return {
```
I believe that is all that is required, but any testing you want to do will help verify, of course.


Yeah, I saw those. They don't get run as part of the tests though and they
don't make any assertions regarding the order.

On Fri, Feb 26, 2016 at 3:12 PM Mark Elliot <notifications@github.com>
wrote:

> See
> https://github.com/palantir/atlasdb/commit/cb76971ec949d2fb1baf37e46fd45bc5ec483272
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/palantir/atlasdb/commit/0936df0e500ee5f0a1560cf608f147e0ae6937f7#commitcomment-16366188>
> .
>


Hi, Kwan, thanks for the report. Yeah, I am publishing it because I figured there's no security risk associated with exposing that ID. Do you think I should be concerned?


Also, docs are missing on
https://github.com/palantir/atlasdb/wiki/AtlasDB-Schemas

On Fri, Feb 26, 2016 at 3:27 PM Robert Fink <rf@robertfink.de> wrote:

> Yeah, I saw those. They don't get run as part of the tests though and they
> don't make any assertions regarding the order.
>
> On Fri, Feb 26, 2016 at 3:12 PM Mark Elliot <notifications@github.com>
> wrote:
>
>> See
>> https://github.com/palantir/atlasdb/commit/cb76971ec949d2fb1baf37e46fd45bc5ec483272
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/palantir/atlasdb/commit/0936df0e500ee5f0a1560cf608f147e0ae6937f7#commitcomment-16366188>
>> .
>>
>


good work


:+1: Nice targeted improvement.


I can make idea do that, I will sort out a config for us all to us, I know gig likes the { on a new line. I don't mind using that. Tabs or spaces? And the imports. I'm not sure what the eclipse defaults are as I haven't used it in years.


It can work....2.5 is not yet released. I am still testing the limits of targets


looks like edgeHop is basically the whole creation flow. Rename it to something like ensureL7Loadbalancer?


This doesn't look done. Did you push your changes?


Nice catch!


Installs fail.
four packages were not found.  on Unzip the program hung.
Line 30 Updating command not found.

Reverting VM


`return ', '.join([self.video_id, self.title, etc])` – w końcu nie masz jakiś specjalnych wymagań, tylko chcesz połączyć je przecinkami – w ten sposób jak dokładasz nowe pole to nie musisz zmieniać formatowania


Looks good.


Hi Ivan,

I do nor see how you can reset Reduction array elements for r < rstart / 100.0. Remember?

Regards, Alfred


Smooth enough?


fix-window-frame-calcs-5095 (nealkruis) - x86_64-MacOS-10.9-clang: OK (2119 of 2121 tests passed, 0 test warnings)

 * 1 test had: ESO big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


The following doc(s) have been deployed to the [1404upgrad](http://1404upgrad-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/sites](http://1404upgrad-static-docs.pantheon.io/docs/articles/sites)
- [docs/articles/sites/secure-phpinfo](http://1404upgrad-static-docs.pantheon.io/docs/articles/sites/secure-phpinfo)
- [docs/articles/sites/settings](http://1404upgrad-static-docs.pantheon.io/docs/articles/sites/settings)
- [docs/articles/sites/settings/toggling-between-php-versions](http://1404upgrad-static-docs.pantheon.io/docs/articles/sites/settings/toggling-between-php-versions)
- [docs/articles/sites/settings/upgrade-php-versions](http://1404upgrad-static-docs.pantheon.io/docs/articles/sites/settings/upgrade-php-versions)
- [source/docs/assets/images/desk_images/356186.png](https://github.com/pantheon-systems/documentation/commit/63ab3c67da14243c931e495d1ab8f31ac331b5ad/source/docs/assets/images/desk_images/356186.png)
- [source/docs/assets/images/php-versions.png](https://github.com/pantheon-systems/documentation/commit/63ab3c67da14243c931e495d1ab8f31ac331b5ad/source/docs/assets/images/php-versions.png)
- [docs/changelog/2015-01-01-January](http://1404upgrad-static-docs.pantheon.io/docs/changelog/2015-01-01-January)
- [docs/changelog/2015-08-01-August](http://1404upgrad-static-docs.pantheon.io/docs/changelog/2015-08-01-August)


Yeah - this is more defensive programming than anything. If we ever get into a state where two speedwagon windows are displayed (which you're right shouldn't normally happen), the code will still correctly handle the state transition.


Yes, we can remove this.


I'm also hitting this with no files locally:
https://github.com/mozilla/kuma/blob/master/kuma/attachments/views.py#L59


@gkushang you could instead use `npm version` to bump these versions automatically. Commit also  done by this command for you and the commit message is version number. so just looking at git repo, you would be able to tell the version rather than opening package.json.


Tl;dr this does not create or ensure a working L7.

EdgeHop is essentially verifying that everything a single edge hop away from you in the graph is OK. For backends, that's just instance groups, for instance groups, that's just instances, for l7s that's (url map, tp, ssl, fw rule...). Backends are not a single edge hop away from l7s because they're connected via url map, instances are not a single edge hop away from l7s because they're connected via (instance group: port) to the backend, which is connected through the url map to the l7.

If we had a single function that handled all the setup of an L7 it would make sharing resources cross L7s (like backends and instances) really tricky. Currently backends are created when their services come up, and refcounted because they're very limited quota. So you can have a single Service (foo:80), create a single GCE backend for it, and create N L7s each with their own urlmap,proxy etc.

This hopefully sheds some light: https://github.com/kubernetes/contrib/blob/master/Ingress/controllers/gce/controller/doc.go


porównujesz `repr` – a czemu nie po prostu obiekty?

```
// tak ze 3 przypadki, bo walić wszystkie 17 ;)
self.assertEqual(
    found_videos[0],
    new VideoSingature(
        video_id="jq30l5-vBbo",
        title="Lana Del Rey - Freak",
        // itd
    )
)
```

itd.


TeamCity LabKey :: LabkeyModules15.3 :: Git postgres 9.4 [Build 123](https://teamcity.labkey.org/viewLog.html?buildId=305835&buildTypeId=LabkeyModules153_GitPostgres) outcome was **FAILURE**
Summary: Execution timeout (new); tests failed: 209 (202 new), passed: 0 Build time: 04:01:12
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.DataFinderTest: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testDatasetExport: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testImmuneSpaceStudySubset: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudySummaryWindow: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyCards: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSelection: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testNavigationDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSelectingEmptyMeasure: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testBackDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyCardStudyLinks: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testFinderWebPartAndActionShareFilter: <no details avaliable>

##### there are 199 more failed tests, see build details
```


Thank you, I was thinking on that, but I was a little confused with this new form. I guess I should write
if (r < (rStart / 100.0))
{
                  Reductions[!pv][imp][d][mc] = 0 * ONE_PLY;
                  Reductions[pv][imp][d][mc] = 0 * ONE_PLY;
                  continue;
}

Is this correct?


do we need --framework carbon?


meant to say "Enable Self Selection" in the GitHub commit


Resolves #36


Did you recompile the other bootloaders? No need to commit, but it would be cool to know that they still compile after the apple changes.


para que sirve esto


bardzo ogólna nazwa – będą tu wszystkie możliwe parsowania?

bo jak tak, to trochę przyciężka stanie się ta klasa.


fix-window-frame-calcs-5095 (nealkruis) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2157 of 2159 tests passed, 1 test warnings)

 * 1 test had: ESO big diffs.
 * 1 test had: EIO diffs.
 * 1 test had: ESO small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


Haha, I like the 'that' variable name. Works well


fix-window-frame-calcs-5095 (nealkruis) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


proponuję `YoutubeSearchPageParser`


Nice.


wstrzykuj :)


I think my code was def <+> () = Concat(this, Star(this)). I'm not sure which one I like better. This is clearer what the function does but the other way is more Symmetrical with the other function definitions because you use the long form in all of them.


Hmm. This assert is bugging me a little bit. Suppose we're paused in the debugger message loop and you Eval something that calls into application Duktape/C bindings and something there triggers a condition that wants to pause the debugger (and not knowing we're in the message loop).

As a concrete example, suppose my application is a game and I'm debugging some problem and I've modified a Duktape/C function request a pause when some condition is met. That condition might very well be triggered by an Eval when paused.

Some alternatives:

- Leave the assert; when it triggers in practice it'll cause potentially weird behavior when asserts are disabled. I don't think it should be fatal though, and might actually work fine because the interrupt counter is reset when the message loop exits.
- Check explicitly and throw an error if inside the message loop. Would work badly in the game trigger scenario because it'd interfere with debugging.
- Check explicitly and ignore if we're in the message loop. This would be somewhat wrong if the message loop was running when *not paused* (e.g. Eval triggered by a peek in the periodic peek check).
- Support the case explicitly and document it as being allowed (not from debugger callbacks but by e.g. Eval'd code).

Most likely it will actually work as is but would need to be checked and tested in practice.


@samthor It may be worth doing regular tagged releases as it doesn't appear there's been one since last year. Minor oversight :)


Wouldn't difftime(3) be a portable and concise solution here?


I did a foldl on the list of Literals but I like this recursive definition better.


I was afraid the new implementation with sessions would break the app so I left the old code behind, which is really bad; just look at those credentials LOL. Anyway I removed most of the clutter in commit e3a56985c7ea6451d7eea382e70a176935038552


The following doc(s) have been deployed to the [1404upgrad](http://1404upgrad-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/sites](http://1404upgrad-static-docs.pantheon.io/docs/articles/sites)
- [docs/articles/sites/secure-phpinfo](http://1404upgrad-static-docs.pantheon.io/docs/articles/sites/secure-phpinfo)
- [docs/articles/sites/settings](http://1404upgrad-static-docs.pantheon.io/docs/articles/sites/settings)
- [docs/articles/sites/settings/toggling-between-php-versions](http://1404upgrad-static-docs.pantheon.io/docs/articles/sites/settings/toggling-between-php-versions)
- [docs/articles/sites/settings/upgrade-php-versions](http://1404upgrad-static-docs.pantheon.io/docs/articles/sites/settings/upgrade-php-versions)
- [source/docs/assets/images/desk_images/356186.png](https://github.com/pantheon-systems/documentation/commit/63ab3c67da14243c931e495d1ab8f31ac331b5ad/source/docs/assets/images/desk_images/356186.png)
- [source/docs/assets/images/php-versions.png](https://github.com/pantheon-systems/documentation/commit/63ab3c67da14243c931e495d1ab8f31ac331b5ad/source/docs/assets/images/php-versions.png)
- [docs/changelog/2015-01-01-January](http://1404upgrad-static-docs.pantheon.io/docs/changelog/2015-01-01-January)
- [docs/changelog/2015-08-01-August](http://1404upgrad-static-docs.pantheon.io/docs/changelog/2015-08-01-August)


ekhem, dokładasz implementację, bo test tego wymaga, nie odwrotnie

TDD :P


"at any time" isn't strictly correct because you can't call the function from transport callbacks. But I guess we can allow it to be called from the AppRequest callback, and that might be an actual use case?

Also, if the `dbg_processing` assert is left in place, application must not call the function when the debugger message loop is active. This is actually quite challenging because how would the target code know we're executing code triggered by e.g. an Eval command (from the message loop).


zamiast kopiuj–wklejkować kod i komentarz – wyciągnij metodę, np `_remove_non_breaking_spaces()`


added comment


Somewhat unrelated, I noticed `duk_debugger_notify()` is missing from this section; I'll add a separate pull for that for consistency.


I think I'll leave that up to you to decide; I believe you suggested the assert originally. ;)


Thanks - I was going to remove the minor check also, just disable for anything less than 3


moved dispatch initialization here and made the wasapi_state (ao->priv) the talloc parent


Hm, good point.  Should I leave the wording as is, or do you have any suggestions for better wording?


I noticed that too, but didn't want to add it in this pull.


Sorry I was kind of giving pseudo-code. More like this:

```js
it('should run without throwing', function () {
  (function () {
    cash.clear();
  }).should.not.throw();
});
```


Added reference to longstanding annoying bug, which is resolved by this commit.


This is a new commit that removes an old hack.


I know in the solution code, prof Ben has the line require(num > 0) which I like better than the if else statement. Also I think Scala convention is to not have the braces for if else statements.


I think that this case should appear above `methodName === selector` to ensure that static methods appear together, which was the intention of the rule.


I know - it just started to bug me that the application is actually in no position to reliably know that it's not inside the debugger message loop. At first I thought it'd be clear but Eval can basically trigger any code.


The naming conventions for the config defines is a mess, but adding another `USE_`  convention is just adding to this mess; stick with `_ENABLE`, eg. `WIFI_SDK_EVENT_MONITOR_ENABLE`.

I personally hate this but at least we don't add to the confusion.


This would probably be slightly better with `test` instead of `match`.


fix-window-frame-calcs-5095 (nealkruis) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1012 of 1013 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.9%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-29.43%25-green.svg)


If the restriction of not calling from inside the message loop is lifted, then I think it should be fine as is. If the restriction is in place, I think it'd need some change because it's easy to call the function incorrectly. For example, it'd be fine to call in response to a keypress detected in the event loop, but unsafe to call from any Duktape/C function which might be Eval'd.


My thoughts are that having a separate closure type makes the code more clear. It forces the caller to be explicit about what they want, instead of having magic happen.

In the current code passing a context to a function doesn't do anything. The value isn't stored anywhere, it's discarded.

If the user mismatches the function prototype, then we'll have undefined behavior no matter what. My thought is just to make the user be explicit as possible so hopefully they'll notice it.

Also, If the closure type was implicit, then we also wouldn't be able to have null contexts, which would be confusing.


I was not able to get this code to work. Any suggestions?
Thanks in advance


Unfortunately this causes the Hive object not able to be serialized into JSON with TSimpleJSONProtocol:
https://github.com/apache/hive/blob/master/metastore/if/hive_metastore.thrift#L237
Also TJSONProtocol does support list as the key. Can we revert this change?


@dmick I changed this because I believe HEALTH_WARN was confusing for some reason and now it reaches HEALTH_OK with ovrerrides and the check is for HEALTH_OK as well,  this test was working for long time with HEALTH_WARN somewhere down the line it started failing with HEALTH_ERR not sure why but this should fix that recent failures


Basically the initial commit.


5499-Electric-Service-Follow-Up (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (2124 of 2126 tests passed, 7 test warnings)

 * 9 tests had: AUD diffs.
 * 9 tests had: MDD diffs.
 * 9 tests had: MTD diffs.
 * 1 test had: ERR diffs.
 * 2 tests had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


I think that setting this value here is a premature optimization and shouldn't be done.


Кстати, теперь деплой одной кнопкой!


Thanks!


May you add me on skype and send discord link my skype is @halfthelife I tried to get the carat hack from them and they found out. So they kicked me out of all the groups and now I can't get any hacks from them period. Please try your fastest cause there are clearly terrible people out there. But take your time 40 hours a week must be hell. @neetVeritas


Found another thing ^^ This is obviously close to an `assign` method's functionality. I'd actually expect a `clone` method to deeply clone an object, though, instead of this shallow copy.

Could be replaced by just using a custom assign helper, I guess. I'm not aware of any parts of faux-dom needing a deep copy. Or are there some?


Figure 7 was interesting, the legend didn't draw the green line.  Turns out it was using a polygon with a pattern bitmap brush.  I added some rudimentary support for pattern brush rendering.


The following doc(s) have been deployed to the [1404upgrad](http://1404upgrad-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/sites/settings/upgrade-php-versions](http://1404upgrad-static-docs.pantheon.io/docs/articles/sites/settings/upgrade-php-versions)


</html>


please review my work


So to be clear: if we don't allow the call and guarantee it works 100% from the message loop, the assert should of course stay in place or even be promoted to an error. But I'm not sure that restriction is reasonable for the user.


JUnit test class added.


This resolved issue against 401 Unauthorized error running 4.8.12.


This name refers to a resource name in the cf stack template. We'd have to shove the parameter name into the stack template as a config value, which I feel would muddle the interface. Definitely preferable to have the string value defined in one place, I wonder if defining a const, creating a Config field for it, and templating it in as a config value is worth the clutter just to make sure that two short strings are the same.


That makes perfect sense. Thanks


Thanks for taking care of this.

Just a heads up that smp_call_function_single() does exist for 32-bit on 5.5 and above. Nonetheless, I've merged your change so that it's consistent across all 5.X 32-bit.


Gotcha, that's a good thing to look into. I created the basic domain model in my rails app and used a gem to print a pdf that shows what I have in there.  This is what I pictured our schema to look like, more or less.

[FeedTheNeed Schema](https://github.com/mweimer/FeedTheNeed/files/147599/erd.pdf)

Would it be easy to configure MongoDB to work like this? I just remember hardcoding a lot of the relationships (due to lack of time), and I don't currently know how to accomplish these relationships without hardcoding it into our current stack. I'm guessing we use mongoose to do that?

I also think it would be a good idea to talk about what else we want it to do, and then assign some tasks.


Would be nice if there was a way to configure this. I would much prefer the namespaces not be prefixed. In my situation I know they will not class.


added BASE_URL to config. Did you want me to use href="/" for the base url? I wasn't quite sure since you mentioned it can lead to issues in certain cases, but it is what you used in the Logo link originally.


These comments are created by the annotate gem, and are useful for dev, especially if you are not familiar with the schema.  I would keep them.


Hmm, this is first time the UI design board has seen these screens and the high level menus that BTM is at doesn't seem to make sense to me. Maybe our UxD designer  Liz Clayton can look through this and approve.


I am good with this.  This page probably needs some form of i18n as I think about it.


> Have we actually run into those values? Where and how?

Yes, and it caused a panic inside this function, so this commit was added to handle it.

It could be done like this instead?
```go
func IPv4ToInt(ip net.IP) uint64 {
	ip = ip.To4() // IP may be v4-in-v6 address or plain v4 value.
	if ip == nil {
		return 0
	}
	return uint64(ip[0])<<24 | uint64(ip[1])<<16 | uint64(ip[2])<<8 | uint64(ip[3])
}
```
Or it can be the caller's problem to deal with. (It's only called in two places)


Casein checks for Rails 5 and warns if another version of Rails is being used


Did you mean `user_admin.id`?


Así es compañero :smile:


This is a good idea!  Maybe call it

> Dev Environment Setup Guide

Thoughts?


変更部分ついて確認しました。


「定数には」→「定数は」


哈哈哈啊


Great README, proud of you!


add auto flush functions:
StartAutoFlush(timeout time.Duration)
StopAutoFlush()


Read the above comment, as I'm not sure if the GitHub messaging system notified of the changes within the above previously posted comment.  The temperature values are figured-out, including the subzero Celsius values.  Only writing the device identification bit string is likely needed, as this transmitter device probably uses the already coded Acurite device's algorithms.  Worse case, might have to copy some of the code from the already coded Acurite devices.


This addresses a problem created by patch for #172.

Compare  dc2f1c84147a0905e0091e9b5298522668cb326d...4aecda2509f56ed58e44640248507a6c5ea573ba


That won't work. I'll bring the FMC adapter into the office so that you can properly run those tests (alternatively, use Pipistrello).


Bug fixed


Whoops, this breaks the build as the first and last sepolicy entries violate neverallow rules.  Comment them out for now until I fix this properly.

These are the two affected denials - they're unfortunately something about the multi-level policies which are weird.
[  322.501417,1] type=1400 audit(1456451179.526:3): avc: denied { write } for uid=10058 pid=2841 comm="FmRadioServiceT" name="property_service" dev="tmpfs" ino=7181 scontext=u:r:platform_app:s0:c512,c768 tcontext=u:object_r:property_socket:s0 tclass=sock_file permissive=1
[  322.501895,0] init: avc:  denied  { set } for property=hw.fm.version scontext=u:r:platform_app:s0:c512,c768 tcontext=u:object_r:fm_prop:s0 tclass=property_service


Thank you @lukeis


Please, do update. I am a huge player of card games, and an advocate of game design, especially tabletops. I'd love to contribute to not only the code but the design.


#include <cuda.h>
#include <stdio.h>
#include <time.h>
#include <malloc.h>
#include <stdlib.h>

//programa que sume dos vectores. Utilizar macros para definir tamańo del vector. Malloc para asignacion de memoria.
// dos funciones : llenarVector, sumarVector
// kala8ss
__global__void add(int *a, int *b, int *c)
{
    int i=blockDim.x*blockIdx.x + threadIdx.x;

    c[i] = a[i]+b[i] ;

}

#define N 100

int llenarVector(int *V)
{
    int i;

    V=(int*)malloc(sizeof(int)*N);
    //srand (time(NULL));
    for(i= 0; i < N; i++)
    {

        V[i]=i;

        printf("Vector %d \n",V[i]);
    }

    return 0;

}

int sumarVectores(int *v1, int *v2,int *V3)
{
    int i;
    int *V1,*V2;

    V1=(int*)malloc(sizeof(int));
    V2=(int*)malloc(sizeof(int));
    V3=(int*)malloc(sizeof(int));

    llenarVector(V1);
    llenarVector(V2);

    for(i=0;i<N;i++)
    {
        V3[i]=V1[i]+V2[i];

    }
    printf("La suma de los dos vectores da como resultado el vector c : %d",V3[i]);
    return 0;

}
//max 1024

int main()
{
    int *a;
    int *b;
    int *c;
    //int i = blockDim.x*blockIdx.x + threadIdx.x;

    a=(int*)malloc(sizeof(int));
    b=(int*)malloc(sizeof(int));
    c=(int*)malloc(sizeof(int));

    int *d_a;
    int *d_b;
    int *d_c;

    cudaMalloc((void **) &d_a, (sizeof(int)*N));
    cudaMalloc((void **) &d_b, (sizeof(int)*N));
    cudaMalloc((void **) &d_c, (sizeof(int)*N));

    float blockSize=32.0;
    float threadSize = ceil(n/blockSize);

    clock_t start = clock();

    cudaMemcpy(a, d_a, N*sizeof(int), cudaMemcpyHostToDevice);
    cudaMemcpy(b, d_b, N*sizeof(int), cudaMemcpyHostToDevice);

    llenarVector(a);
    llenarVector(b);

    sumarVectores(a,b,c);

    add<<blockSize,threadSize>>(d_a,d_b,d_c);

    cudaMemcpy(d_c, c, N, cudaMemcpyDeviceToHost);

    printf(" \n Tiempo transcurrido: %f", ((double)clock() - start) / CLOCKS_PER_SEC) ;

    free(a);
    free(b);
    free(c);

    cudaFree(d_a);
    cudaFree(d_b);
    cudaFree(d_c);

    return 0;

}


Erro nessa linha


update the comment.
Write the problem description.


Added these to main page accidentally :(


@rkdnc I am updating constantly on my Future branch, check up on there to see updates that I'm working on.


We shouldn't call this if a proxy is not configured. Will address this directly after the move to Spring Cloud Data Flow.


#我很高兴


Fix Indentation.


The ansible scripts shouldn't delete the config files - if you do that then you cannot run multiple scripts. They should always do a non-destructive update.


Please, consider using [`frolvlad/alpine-glibc:alpine-3.3`](https://github.com/frol/docker-alpine-glibc) image instead of putting these workarounds inline (and it would be even better if you could try `frolvlad/alpine-glibc:alpine-3.3_glibc-2.23`).


buffer should not be data member of class student. buffer should be local variable of any function that uses buffer.


Now im kinda confused, should i add these permissions to the wiki?


look goods


Instead of using buffer like a global variable. Buffer should be passed to unpack.


I think there's a typo here. It should probably be `getLibraryMeta()`


@GuangLightman 4有点蠢，下次尽量别了 (手动笑脸


test


some tests failed:
failure: https://travis-ci.org/stellar/stellar-core/builds/111916249


The main reasons to make temporary files to test rather than generating scores are (1) how long does this test take to run? And (2) we don't require musescore to be installed in order to run tests but we want to test as much as possible. Thanks!


Specifically, the README.md for the hash table.


relative


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17356](https://teamcity.mesosphere.io/viewLog.html?buildId=146700&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:04:28


Too big a function. Break it into modify UI and modify method.


I disassembled this unit and I see what looks like two sensors.  One atop of the vent hole, and looks like a temperature sensor.  There's another sensor on the bottom of the vent, which looks like a humidity sensor.  (Top sensor is a two wire, with a small black bulb at the end. Bottom sensor sort of looks like to foil conductors forming a maze, similar to this: http://electronics.stackexchange.com/questions/76773/what-is-this-component-from-an-old-thermostat)  The antenna is likely the tight spool of shiny looking copper wire.

So I'm guessing one of those values is the humidity, but this receiver model does not report the outdoor humidity.  (Only reports the indoor humidity.)  A person would find this transmitted humidity value, by setting the transmitter next to the receiver so that the reporting humidity is the same as the receiver's value, or close to the receiver's value.  But this would also ditch the logic, the first and second binary values are channel ID and checksum values.  Or the value is transmitted elsewhere, or the humidity circuit is wired by not activated on the transmitter.


yea, but wait.
i forgot to add sbpvp.is.home permission, because without the home, players cant go to their island


This buffer based communication between pack and modify is confusing and bad,


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17358](https://teamcity.mesosphere.io/viewLog.html?buildId=146734&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 238 Build time: 00:04:57


Sure. Yeah, submodules are a pain point.

BTW, for those plugins/themes that don't have the correct GitHub Updater headers, I've written a plugin that will add them for you. https://github.com/afragen/github-updater-additions

Also, a lightweight plugin dependency installer class, https://github.com/afragen/wp-dependency-installer

Let me know what you think of them. Not sure how, or if they might also fit into the article.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17357](https://teamcity.mesosphere.io/viewLog.html?buildId=146704&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 238 Build time: 00:07:53


saw approval from graydon
at https://github.com/jedmccaleb/stellar-core/commit/700e487637dcfd0301b0467b98b2bf33112aa6e6


merging jedmccaleb/stellar-core/meta = 700e4876 into auto


jedmccaleb/stellar-core/meta = 700e4876 merged ok, testing candidate = 6b0329dc


nice @tingtingchan ! i can see what you changed but lets go over the changed tomorrow. :)


@alimaredia @ktdreyer why ceph-base depends on ceph-osd and ceph-mon. and vice-versa? i think we should remove the ceph-base's dependency on ceph-osd and ceph-mon.


Done!, add them please! im going to reinstall ubuntu, then update the website..


asdf


xxxxx


Please ignore and reject the commit; error on my part.


This project crudWithImageCRUD
database name crud
"header folder" image crud
"student folder" text crud


表示不是非常清楚，感觉达不到效果。


Thanks!


e.printStackTrace() 쓰지 말아요. LOGGER로


Yeah we can pretty much use that schema, what's the difference between a restaurant and organization?

Mongoose can also automatically map different collections with reference ids to one another: http://mongoosejs.com/docs/populate.html. It's pretty much the same thing as relations but behind the scenes, that DB isn't going to strictly enforce them and check that every "foreign key" actually exists in the referenced collection.


close #481.


The source of Pro.ico file:

![pro](https://cloud.githubusercontent.com/assets/5831804/13342586/f10e93bc-dc7d-11e5-971e-1d42c7f95db2.png)


if條件裡頭兩個載入方式應該不同才對哦


Same with Rack::Protection:

```
    def xhr?
      @env["HTTP_X_REQUESTED_WITH"] == "XMLHttpRequest"
    end
```


Given n non-negative integers a1, a2, ..., an, where each represents a point at coordinate (i, ai). n vertical lines are drawn such that the two endpoints of line i is at (i, ai) and (i, 0). Find two lines, which together with x-axis forms a container, such that the container contains the most water.

Note: You may not slant the container.


> dh_strip -pceph --dbg-package=ceph-dbg

what do we have in the package of "ceph" modulo its dependencies?


No problem at all. This kind of thing happens. You are helping so much with the code, I should thank you for your help!


Hey!


i am wondering what is provided in this package? as IIUC, "ceph" is but a meta package.


test


@cwheart 规范参考这里 https://www.python.org/dev/peps/pep-0008/


how come javascript nodejs don't check code? Ans: here is creating a dictionary which has no way for javascript to check key's name is wrong!


I thought I fixed that already!  It must be sitting in a branch somewhere on my local machine :(  That is pretty ridiculous!


concurrency number not only lead to TCP maxout but also memory allocation maxout!


$errors['email']をforeachで出力


この処理は●●ファイルでも書いているので不要です！


Coding standard. tratamos de no usar tabs,  4 espacios si.


It looks like it would have helped a lot if Tpetra::Map could have detected the "multiple global ID/local ID pairs were sent to Tpetra which could cause a failure" case.  I will add a Tpetra feature request for this.  Thank you for tracking this down.


why


/**
 * Docs?
 */


don't do that


"" + ...
está de mas el "" inicial.


I'm saying that I don't know what the side effects might be.  I do have to contort myself to come up with an example that sounds plausible.  Say that the chainer is running, and two different matches A and B result in the same atom C being created, but with two different TV values.  If C is not indexed, then two different versions of the same exact C will be placed in the atomspace; the TV's will not be merged according to the TV rules ... That's assuming the patterns are doing TV manipulations.   I just don't know if this could or would ever happen in "real life".

I do know that the above change is a real change in the semantics of how the system works; it breaks a contract.  I just can't tell if or when it might ever show up as a bug.  Again with the  @ngeiswei ping.


you somehow duplicated the file here. SourceTree is worth checking out as a git client. Also learning to work with the "stage" in git. The git book is pretty good if you take the time to read it: https://git-scm.com/book/en/v2


If we want that, then I can change the code for bench to not allocate (but set null) if size is 0.


hace falta este cast ?
 (Statement) state


I don't think we should just always search for a scala version. lots of libraries are java libraries, that do not have a scala version. We should probably search for all scala versions together and somehow smartly combine the results


mala indentacion, no tabs.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/111920066


You might want to check if you clang-format really loads the style file in the repository root. These formatting changes are strange.


Are you waiting for the ROM to build?


It works for me in non-built-in python installed via homebrew


ライセンスは
https://github.com/jquery/jquery/blob/master/LICENSE.txt
のように、テキストで配置すべきですね。
Excel上からは、github上のライセンスへポインタする形でよいと思います。


`hashlib.sha1(raw).hexdigest()` is probably what you want


Perfect!


See https://github.com/trilinos/Trilinos/issues/157


`sign_and_upload` is probably a better name. It also uploads the original too, right?


we want to cache forever for non-html files, but only 24h for html


don't comment it; kill it dead.


same.


don't keep unused code. kill it.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17359](https://teamcity.mesosphere.io/viewLog.html?buildId=146735&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 236 Build time: 00:03:33


fast-forwarding master to auto = 6b0329dc


I'm not really sure why I don't have the option to edit the File2 in Branch2 ... it takes me here.


I believe this issue is fixed now.


you didn't get rid of drop_item.


This is a commit, and not a file.  The file was in the lower left of the code tab.


also need to verify the `hashlib.sha1(original).hexdigest()` matches the hash in the database for the version


and throw an exception if it doesn't match


Any advice on ideal Gcode format for insertion? Not sure if use of ; line ends as well as // comment escape characters is causing issue on import of default config when creating a new print profile.

Also, is it possible to leave bed_shape blank? Apparently it breaks integration of Slic3r as slicing engine option, results in silent failure (Slic3r expects bed definition as corner coordinates, not shape and dimensions).


@britton Thanks for help. I am going to write independent testing cases for application and account controller.


this has been changed on TG--may want to suss out why.


This can probably use the CHUNK_SIZE (which is 256KB). When I split them up into separate branches, I used a literal default here because the CHUNK_SIZE variable was in another branch.


It will take more work to implement a map that's not MARAUDERS.


good test


why was this changed--it's not this way on TG.


What...I...again.


That would make sense to do.
I'm not clear on whether these LinkedHashSets are a good idea or not.  (How costly they are, how beneficial the determinism is.)  Some other LinkedHashSets were important, though.


Maybe a nicer structure is to separate the signing function from the upload function?

This could then be two function calls here.


wrong issue in commit message, should be #516


int?


Yes, I agree we should rename the directory.  That would be clearer.  What do you propose we name it?


please use grequests if possible, so that's non-blocking


Typo. passiong => passing


Nice, that makes more sense. I'm not sure about what that FIXME means. It doesn't seem that the x86 emulator needs the number of ND-Ranges, but starting and stopping the timer seems already a good reason to keep that list.


thank you bro, work


let's keep the use of grequests to another issue, for the interest of time


Initialize index.php file


Nice.


transmitted


una forma interesante de evitar este encadenado de if, o un posible switch case es un map.
```
public class DBConnectionFactory extends AbstractDBConnectionFactory {

    private Map<String, AbstractDBConnectionFactory> ConcreteFactories = new HashMap<>();

    public  DBConnectionFactory () {
        ConcreteFactories.put("MySqlConnection", new MySqlConnection());
        ConcreteFactories.put("SQLServerConnection", new SQLServerConnection());
        ConcreteFactories.put("SQLiteConnection", new SQLiteConnection());
    }
    @Override
    public SqlConnection getConnection(String conType)throws IllegalFormatException {
        return ConcreteFactories.get(conType);
    }
```


fixed.


Thanks.


今はlinuxからしか使えませんが，将来的にはwindowsとかからも使いたいので，pathとかを連結したりするときは
```
os.path.joint(パス1, パス2)
```
として欲しいです


This is a great start. You should also check that the other responses comments were *not* affected


added this into connection string for nested lazy query.
`MultipleActiveResultSets=true`

for code in MeetU/MeetU/API/MeetupsController.cs
```c#
//append user name
foreach (var m in meetups)
  foreach (var j in m.Joins)
    if (j.UserName == null)
      j.UserName = j.ApplicationUser.UserName;
```


typo: coment/comment


My thinking is that we'd have the different organizations (food banks, homeless shelters, etc.) on there as well that the restaurants choose to cater their meals to.

If you think it would be best to use mongoDB for now, then we can go with that.


I still think this is wrong, there's no way for you to cancel just one transfer in the interface. You select one to many checkboxes, and you click one button to cancel all of them. The parameter transfer_ids also indicates it should be used as a plural.

I think both *may* be better. An instance method and a class method. Technically, the URL for the instance method should be DELETE /transfer/{transfer_id}, but that would require changing the API.

But if there's a way to cancel (somehow), then I don't care too much, I'm just a neat freak. *shrug*.


oh wow, good catch! I didn't think of this!


Could use a 'clean' target

clean:
    rm -rf regress_log /regress_log/


awesoomeee it works :)


Nice, better.


文字化け


can we change this to a debug, or put more info in there, so it is actually informative? this will fill up logs without much benefit.


Committed this as fab4f192f45f88c1faaf216316a5b5972baf369f.


Wording nitpick - people will probably be looking for the word 'cascading' here


Ah, ok, perfect. I commented on this in an earlier commit.


Thanks @tamird! This has been a long standing issue on my todo list.

A couple of thoughts:
1) can you please rename your buffer_reader.go to buffer.go to make it easier to review?
2) I believe this can be done with adding "source     io.Reader" to "buffer", adding the rest of your Read function to buffer.Read, and removing Write. Optionally you can use "buffer     *bytes.Buffer".

WDYT?


 +        if (blueR >= redR && redL >= blueL) { //blue Right, red Left

Is it correct to have >= rather than > here? If blueR, redR, blueL, and redR are all 0, it means that no color can be detected, not that the color on the right is blue.


perfecto :)


good catch. i experienced a unicode error at some point, but I never saw it again, so forgot about it.


One line 30, + "PRODID:-//hacksw/handcal//NONSGML v1.0//EN\r\n", what is this code for?


let's do that later, in the interest of time


FYI: This change will soon be reverted. It breaks debug builds of the emulator and forthcoming native windows builds of NETMF. FLAVOR_WIN is set up in the build settings files based on the FLAVOR property. Though setting FLAVOR_WIN manually at the command prompt will override it. Setting it in the init scripts breaks that since the environment var overrides and makes it always build with the default.


There are many more settings that I want to take from sprout-osx-settings, so I think keeping them in a logical cohesive osx-settings script makes sense. In looking at the comments, I'm not sure if breaking to many scripts is the correct answer.

I had to run the main script many times to find the bug in the main script that was moving the current working directory. I suspect that an isolation layer around each script would be helpful. That's probably how we ended up with sprout-wrap in the first place. Here's an example where isolation would be good:
https://github.com/pivotal/workstation-setup/issues/25


small grammar fix: greater than or equal **to** 0


TIL `_.memoize` binds `this` properly. Nice.


I did add the asserts.

BUT I also added if !size return null.  Look at all the other allocators in memory.c. they already do this, so not doing it in this function, although you did not want it, actually makes it stand out, vs other allocators.

35996d5


What about "Negative number not allowed: #{max}"?


MySqlConnection
no es un Concretefactory. El abstractFactory devuelve facories. este se comporta como un factory de conn.


ＧＯＯＤ


good or bad?


The API has Address (for ipv4) and AddressIPv6. I don't think IPAliases is consistent. That said, I'm not sure what would be a better name. AddressAliases runs ok; although that also works with ipv6 so the name would be misleadingly induce that it's only for ipv4.


ＷＨＡＴ？？？


'if' instead of 'is'?


connect


//some kode


do we only want to use the first one in the comparison?


[Uploading BIMAGE.v2.10.14-g1.0.4-gp.WIXFMM-114.GPLogo.tar.gz…]()


the name feels like a NIC alias rather than address alias


Here it looks great :) we have InterfaceIP, InterfaceIPv6 and InterfaceIPAliases


Should this be `/^([^-]+)-.*$/`? The first `^` would not do anything, I think. The second `[^-]` group isn’t necessary: there’s a `username` property on the model.


Declare ClipboardManager as a global var
make it easier to manipulate in the whole class


Adaption for InfoImageLoader


local setting - locale setting?


Nit: looks like CMake uses `Darwin` as the `CMAKE_SYSTEM_NAME`, but you use `MacOSX` as the folder where you put the source. Using the same name in both locations would be better.


Revisa los comments, sobre todo el abstract factory,
Muy bien el Builder.
Abrazo


Is is possible to use one of the constants to get the value from the array instead of using `getDouble(2)` so it is clear what this value represents?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 17360](https://teamcity.mesosphere.io/viewLog.html?buildId=146740&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 238 Build time: 00:03:28


You shouldn't need that. Does your compiler not support `thread_local`? Which versions are you using?


Limit each query to display 10 matches


This probably should go away if we find a way to make `thread_local` work with your stuff, but you have trailing white spaces here.


Please do not commit commented-out code.


Thanks!


Ditto.


Delete this — GitHub keeps the history or write a comment why it is important to keep this section (for example, "Uncomment this code if you have trouble debugging this server. This implements a workaround that slows down the server but enables step-by-step execution with the nice error printout.")


Sort these includes.


Try to build WebView again