We'll leave this pull request as a code example. And we'll use it when start adding this functionality for the new UI


Notification Log > Journal de rapport

Save diagnostic notifications log ? This doesn't allow folio to collect any personal information. >
> Sauvegarder le journal de rapport ? Cela ne permet pas à Folio de recueillir des renseignements personnels.


なんかエラー出ます。。。


Hi @simogasp
thanks for the tip, I revert my changes

C


ﾐﾀﾖｰ


Please rename "highestCZkId" to "highestCzxId". This is more familiar term to the exisiting ZK users/dev.


+1, was about to suggest this as well


彼女できません。。。


TextViewの赤くなっているところで、alt + enterをすればなおると思うよ


フロリダ生意気です。


ここエラー・


Could you add a comment for this method please?  It took me a minute of staring to figure out what it's doing and why.  Partly that's the name; `forCollection` implies to me you'd be passing it a collection, or doing something for a collection, not just unwrapping it.  Perhaps `unwrapJavaCollection`?


@flavour no it doesn't expire because there is a check for point and polygon


I'd introduce a couple of methods (`resolveMemberOverrides`/`resolveStaticOverrides`) to prevent adding unclear boolean arguments


ここのTextViewでalt + enter


FOr the commit database file


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15228](https://teamcity.mesosphere.io/viewLog.html?buildId=131148&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:49


直輝！！！！！！


**FAILURE** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 290](http://ci.infinispan.org/viewLog.html?buildId=35289&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for c6125793f862e6297a7282bea36fbdd187c55a20
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:09:41

Process exited with code 1


reack


Oops! Glad you caught this!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15227](https://teamcity.mesosphere.io/viewLog.html?buildId=131147&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:01


perfection


I would add static field and function in `A` without shadowing in `B`, and then call them with `B`


Typo: calculcations > calculations


My intention is for anti affinity topology key  node.Labels[topologyKey]  can be "" then we simply skip the Weight  or in that case we can directly use the node.Name.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15229](https://teamcity.mesosphere.io/viewLog.html?buildId=131149&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:37


i'd say that anything that needs to lock the internal mutex shouldn't be const, it's a pretty big state change in the object


An example of the pluralized ``HoloMaps`` I discuss in the thread.


FWIW, “fixed” in #39 (`.gitignore` had since been deleted entirely)


Oh, just realized I could have made this a little better:
```scala
def size: Int = (seq orElse set) map (_.size) orElse collection.map(_.size) getOrElse assert(false, "Unreachable")
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15230](https://teamcity.mesosphere.io/viewLog.html?buildId=131154&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:04:56


Also it's worth to squash all tests into 89dd250ed339ce5fb87ca81d3249acfa08aab7ad just to make these changes illustrated


faster would be:
```bash
uint8_t msg[AN_MSG_SIZE_MIN + 16]
```


like mutable is something you use for caches or similar where the external state doesn't have any relation with them but locking a mutex seems the kind of thing that shouldn't be hidden under mutable, if any method wants to lock it it's changing the internal state of the object, that's also why lock/unlock are not const


Thanks Anton, but the regex doesn't seem to work?

`var s = 'OPiOS';

s.match( /opios\/([a-z\.\_\d]+)/ );   // null

s.match( /opios/i );   // ["OPiOS"]`


Can we keep cases on the same line where they are short?
```scala
case Some(v) if isSensitive => String.format("--%s ***********", longName)
```


I'd add some short description of what does this test check


Withdraw button stuffs isn't placed correctly in the Bank Account Management window. Goes behind other buttons.


TeamCity Selenium POM :: CI [Build 56](https://teamcity.sponte.uk/viewLog.html?buildId=1061&buildTypeId=SeleniumPom_Ci) is now running


This was test patch in order to check if it was a good way to fix the mapping issue. I'm still thinking about a way to fix it. Fork will not help us on this but that is another story :)


Done, reverted to previous pattern with delimiter added


TeamCity Selenium POM :: CI [Build 56](https://teamcity.sponte.uk/viewLog.html?buildId=1061&buildTypeId=SeleniumPom_Ci) outcome was **FAILURE**
Summary: Tests passed: 39; exit code 1 Build time: 00:00:39


@belucid now at least I know how what the diff means. sorry :)


Gracias, lo podrás corregir en todos los ficheros que has cambiado?


Сори, натупил на ночь глядя.
Со всем разобрался и нашел ошибки, этот коммент не актуален.


Please replace "RuntimeException" with "KeeperException". One idea is similar to java iterator#next() can add new "KeeperException.NoSuchElementException"


c'est vu avec Loïc
Le 10 févr. 2016 12:09, spyjo <notifications@github.com> a écrit :ce n'est pas justement le correctif qu'a ajouté loic dans le commit:
cbc4a3c

pour corriger ce bug:
https://www.jeedom.com/forum/viewtopic.php?f=34&t=15391&p=279303#p278472

?

—Reply to this email directly or view it on GitHub.


Please rename "highestCZkId" to "highestCzxId". This is more familiar term to the exisiting ZK users/dev.


Privet Uriil,
I do have a question about the usage of uint type to specify the from and to (date/time). How can I convert a datetime to uint, or on what basis is the uint value converted by the api to a meaningful date/time.
Such uint values are used in function such as: "TradesUserHistory" and others.
According to the mt4 support forum. the uint specifies seconds so that when requesting dailyreports for instance, specifying 86400 as (To) parameter value, will mean the final second in the day, but that's as far as I was able to grasp in this regard.


@Hatlen for me yes! Since the @mynewsdesk/skywalkers using Coffeescript right now i think it's better to ask some teams on prime? Maybe @mynewsdesk/frontend. I also think its better that the one who created the PR merge it and is responsible for the deploy and can test it out as it should work?


The contract (as specificed in the comment) is that this may only be called on arguments with values set, otherwise it will throw an exception.  How about this instead:
```scala
  def toCommandLineString: String = this.value match {
      case Some(v) => v
        if (this.isCollection) prettyNameValue(new SomeCollection(value).values.mkString(" "))
        else prettyNameValue(value)
      case None =>
        throw new IllegalStateException("toCommandLineString not allowed on unset argument.")
    }
```


A second reminder to myself to check this...


`requiredArgumentErrorMessage`


Wow awesome


tu sers à rien.


`requiredArgumentWithMutexErrorMessage`


> I would add static field and function in A without shadowing in B and then call them with B

This is what `C` is for, is it not?


Dear @gbastien
I propose you use unrestrictedTraverse to avoid your problem and to not be limited calling special view names.
Regards


@sbootsma @FxDetoX Dit is Cool


C'est vu avec Loic. Car au final la ca bloquait la loupe qui sert justement a remettre d'origine.


Polymer behaviour for camera (cordova)


hello world


This commit causes the Agile Web Development with Rails tests to fail, see https://github.com/rails/rails/issues/23590 for details.


small minor nit: please keep { bracket one line above. I agree existing code has many such occurrences. But I prefer to make the new code comply code format :-)

like,

public List<PathWithStat> getChildren(final String path, Watcher watcher, final int maxReturned, final long minZxid)
              throws KeeperException, InterruptedException {


Thanks. This has been addressed in https://github.com/SnappyDataInc/snappy-store/commit/41456e3476080174483adf65d96a1717dd560297.


Should we get only the path?


prova


When file is opened via `include`, it is not possible to remove or rewrite file.


@jvatic Don't we manually install the SSL cert so that we can securely visit this page?  Seems like this should be `https://`.


Yes baby <3


TeamCity Civic Assembly :: Build backend + frontend [Build 91](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=933&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


Hello there is a change in a file.


abc


@lauraluiz
Now the aspect-ratio of the modal-content is fine. But the images has to be bigger for the modal now.


а что форма делает в контроллере? выноси в отдельный класс.


Крайне странная конструкция :-) Функция get, но method при этом POST:-)


Fixes according to today's comments https://github.com/practiceprovider/openemr/commit/3c01ae3e997568b057c45831395190bad670f88b


The user group is hardcoded here. Which can fail the installation in machines with jss user.


![screen shot 2016-02-10 at 12 24 14](https://cloud.githubusercontent.com/assets/4887212/12946091/21dfd7dc-cff2-11e5-89a5-e2659272c613.png)
![screen shot 2016-02-10 at 12 31 06](https://cloud.githubusercontent.com/assets/4887212/12946098/3260127a-cff2-11e5-938c-8775c227d0b7.png)


It's a nice addition!
Do we have styling options?
And what happens when we do not "start at zero"?


I found one issue with this hook: #2915.


I would not pass `$logger` to the constructor.


Почему бы не использовать append?


не так. id должны быть динамическими. {{ postDeleteForm.delete.vars.id }}


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/34//violations
```
src/plone/api/content.py:268:1: C901 'delete' is too complex (15)
src/plone/api/content.py:360:1: C901 '_wf_transitions_for' is too complex (13)
src/plone/api/tests/test_doctests.py:121:13: T001 print statement found.
src/plone/api/tests/test_env.py:31:14: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:35:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


It's up to you whether to leave this as you have it, but this is a case where we know `.get` will succeed, because the parser will only accept known option names.  I.e. I don't think you can write a reasonable test case that will hit the `None` branch here.  So I would tend to use a `foreach` or even leave it as `get`.  If you prefer the match could you change the exception - I think we should have an `UnreachableException` or similar to clearly document code branches we think are unreachable.


Ok, I haven't noticed it


Same here, I don't see the need of passing `$logger` to the constructor.


ack


Order matters here?


We have two IllegalArgumentException cases. Please mention both the cases in api docs, that would makes exception cases more clear to the users.
     * @throws IllegalArgumentException
     *             if any of the following is true:
     *             <ul>
     *             <li> {@code path} is invalid
     *             <li> {@code maxReturned} is lessthan 1
     *             </ul>


This will need to be '$location.$$host === avAnalyticsConfig.DOMAIN'.


 ja/source/sources ディレクトリごと
 en/source/sources へのリンクファイルにすると
今後のメンテナンス性が向上しませんか？
他の言語について同じことをすれば、
en だけ更新すれば良くなって、
手間がだいぶ減る気がします。


Есть метод serialize,  т.е. здесь можно было написать покороче:
```javascript
data: $('#someform').serialize()
```


Instead of just having the domain in the avAnalyticsConfig, why don't you move the rest of AV_ANALYTICS here as well?


Лучше не изменять свойства, а навешивать классы


"priorities"


finally this should appear on flock @sktguha


broken link, should be `emacs.el`


Зачем тебе явный вызов `bool`? Мы же говорили, что он и так неявно вызывается в таких ситуациях.


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/35//violations
```
src/plone/api/content.py:268:1: C901 'delete' is too complex (15)
src/plone/api/content.py:360:1: C901 '_wf_transitions_for' is too complex (13)
src/plone/api/tests/test_doctests.py:121:13: T001 print statement found.
src/plone/api/tests/test_env.py:31:14: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:35:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


this shouldn't


TeamCity Civic Assembly :: Build backend + frontend [Build 91](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=933&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests failed: 148 (1 new), passed: 24, ignored: 4 Build time: 00:06:56
### Failed tests
```
Blog categories tests: Should delete blog category new blog category 1455104049176: <no details avaliable>

Blog categories tests: Should not create new blog category if cancelled: <no details avaliable>

Blog categories tests: Should add new blog category: <no details avaliable>

Blog categories tests: Should not change blog category: <no details avaliable>

Blog categories tests: Should change blog category: <no details avaliable>

Blog categories tests: Should not delete blog category if cancel pressed: <no details avaliable>

Blogs tests: Should not create new blog if Cancel button pressed: <no details avaliable>

Blogs tests: Should add new blog: <no details avaliable>

Blogs tests: Should not change blog if Cancel button clicked: <no details avaliable>

Blogs tests: Should change blog: <no details avaliable>

Blogs tests: Should not delete blog if Cancel button was pressed: <no details avaliable>

##### there are 138 more failed tests, see build details
```


Здесь можно было короче. Есть метод serialize, который всю форму сразу разбирает. Например:
```javascript
$('#someform').serialize()
```
Только для этого форма должна существовать, обратите внимание - у Вас ее нет, что семантически неправильно


This would need to be '$location.$$host === avAnalyticsConfig.DOMAIN


Thanks for telling me exactly what I said in IRC


Why don't you mvoe the rest of AV_ANALYTICS to the config instead of just 'DOMAIN'?


I kept this ```for``` because I need the element's index to remove it from the ```layers``` array, unless there is a more elegant way to do this that I don't know about :)


this value should be 16


this should again come @sktguha


Здесь можно было короче. Есть метод serialize, который всю форму сразу разбирает. Например:
```javascript
data: $('#someform').serialize()
```


Yea, if a non-sensible combination of bits is set, it should probably report it as 'unknown'.


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/36//violations
```
src/plone/api/content.py:268:1: C901 'delete' is too complex (15)
src/plone/api/content.py:360:1: C901 '_wf_transitions_for' is too complex (12)
src/plone/api/tests/test_doctests.py:121:13: T001 print statement found.
src/plone/api/tests/test_env.py:31:14: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:35:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


LGTM.


You can merge these two `try` blocks.


Hi there, how would i go about getting just the exchange rate for example just gbp to usd?


for 2016 APAC Round E (Jan 31)


unack, please add an escaped backslash and an escaped space to make sure those are written back correctly too.


Смотрите code review к предыдущему ДЗ, про serialize написал


Sometimes I do that as a placeholder to add additional logic later. But
sometimes I do that just to be explicit that I meant to do nothing (it
helps others less familiar with Python constructs that read my code at
work).

Mike
On Feb 9, 2016 3:40 PM, "Summer Rae" <notifications@github.com> wrote:

> This is awesome!
>
> I'm curious if you're using try/except/finally and passing 'pass' to
> finally because you are planning for more error catching downstream?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/MikeSchincariol/IntroPython2016a/commit/b7a21ede3fb7f855b89963cf33291e457da379e0#commitcomment-15988754>
> .
>


Когда идет сравнение с true, желательно использовать ===


should be 14


I told ya.


I think you could change this line to:
`.map { args.forField(_) match {`
and eliminate the next two lines.


Ah, thanks. ill add them to the ConfParser too


2 things:
1) I would recommend a name change since OpenTK name does not have a good history, it makes people a bit wary
2) If you need some help with maintaining the project, I don't mind helping


TeamCity Selenium POM :: CI [Build 57](https://teamcity.sponte.uk/viewLog.html?buildId=1062&buildTypeId=SeleniumPom_Ci) is now running


This is a nice trick to squeeze out the Nones.


Я посмотрела не туда и с чего-то решила, что твой комментарий про "Функция не должна обязательно возвращать True или False..." относится не к документации, а к этой строке.


its time to forget 1.x :D


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15231](https://teamcity.mesosphere.io/viewLog.html?buildId=131156&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:04:57


`unknownPipelineErrorMessage`


Missing two subtypes
ITHO_CVT_RFT(1)
LUCCI_AIR_FAN(2)


`unknownCommandErrorMessage`


TeamCity Selenium POM :: CI [Build 57](https://teamcity.sponte.uk/viewLog.html?buildId=1062&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 40 Build time: 00:00:52


Whoops, I didn't mean to leave that in.  Rebased.


It is only usage of valueArgumentsBeforeSubstitution? May be we can use just valueArguments.entrySet()?


@HitcherUK
Done. Let me know if something isn't working.


only to this test, I think those should work without modifying the writer


Indentation.


does a message bubble up @sktguha


You should use the delimiter in the regex pattern.


program**_dp0_**\consolidator
Copypaste error? dp0 does not seem to be a part of path on my system


can you come and hold my hand on this?  I'm a github newbie ...

On 2016-02-10 09:57, Raphaël Proust wrote:
> Can you put that in a branch/commit of its own and send a pull request
> to @Timothy-G-Griffin [1] ? It might get you brownie points…
>
> --
> Reply to this email directly or view it on GitHub [2].
>
> 	*
>
> Links:
> ------
> [1] https://github.com/Timothy-G-Griffin
> [2]
> https://github.com/henryaspegren/cc2016_cl_cam_ac_uk/commit/e038ef83c0957ec9b635c46633a50367be6014b4#commitcomment-16000705


`typedValueFromString`?  At the callsite `fromString` is a little ambiguous.


to reproduce this issue e.g. please try use the following code (with script.js):
```
series: [{
            name: 'Foo',
            type: 'column',
            data: [5, 10, 15, 20, 25, 30, 35, -40, -45, -50, -55, -60],
            tooltip: {
                valueSuffix: '°C'
            }
        },
        {
            name: 'Bar',
            type: 'column',
            data: [-10, -20, -30, -20, -10, -20, -30, 20, 10, 20, 30, 20],
            tooltip: {
                valueSuffix: ' mm'
            }

        }]
```

(no **yAxis: 1**)


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/37//violations
```
src/plone/api/content.py:268:1: C901 'delete' is too complex (15)
src/plone/api/content.py:360:1: C901 '_wf_transitions_for' is too complex (12)
src/plone/api/tests/test_doctests.py:121:13: T001 print statement found.
src/plone/api/tests/test_env.py:31:14: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:35:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Just a suggestion. Since we know the batchSize, how about keeping the server stop till reaching the batchSize element and starts the server back to allow a remote call to get next batch. Again stop the server till batchSize.

Will this make the test more clear and simple ? Any other scenario I've missed for the random server states change in the tests ?


Wrong indexes should be 1 to 3


We using Build 86 it is from 1.12.15 so not so old i think. But this would be the last Build i guess because they work on a 1.8.9 Version.

https://dvs1.progwml6.com/jenkins/job/HungerOverhaul-1.7.10/


renamed*


Ugh, you shouldn't really do this with a static. We can do some kind of similar latch, but just not with the static.


derp


this can't be merged until there's a test for coala-json I'm afraid


Absolutely. The fix is not a concern at all. The only concern is that not keeping older releases on PyPI makes life of some consuming projects harder. I hope that the thread gives you enough reasons not to clean up older releases from PyPI right away.

BTW OpenStack is still in the middle of adopting Python 3 for its code base, and I don't know of any setup that would run its code using Python 3.


Remind me to add a line at the end of install.sh


Two last imports are unused @jozzi05


Ваш вариант хорош, но на мой взгляд лучше было бы описать подобную функцию следующим образом:
```javascript
function validation(object, validator) {
  return (typeof validator === 'function') ? validator(object) : false;
}
```
И вызывать как-то так:
```javascript
validation($(this).val(), validUsername);
```


`unitFromString` or `buildUnitFromString`?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15232](https://teamcity.mesosphere.io/viewLog.html?buildId=131157&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:10:00


Отлично, Вы пока единственный догадались использовать цикл:-)


If government-frontend starts rendering topics outside of the service manual then maybe this `ServiceManualTopicPresenter` would be better named `TopicPresenter`?

I think the idea was that the all purpose topic was expanded to cater for the service manual requirements. See https://github.com/alphagov/govuk-content-schemas/pull/203


Зачем *?


С true лучше сравнивать через ===


I'm not sure that's necessary. It'll only slow the tests down, and there's an `AfterSuite` hook in the global setup that tears down everything at the end.


Can we re-word this to clarify mollis?


mmh, it seems that const/mutable has changed their meaning in c++11 but it's just not said anywhere except in some talks and not even the comittee knew about it, anyway this seems to be correct now.


This is really nice!


TeamCity Selenium POM :: CI [Build 58](https://teamcity.sponte.uk/viewLog.html?buildId=1063&buildTypeId=SeleniumPom_Ci) is now running


Makes sense, thanks for explaning


I think I would still write `Some(resources)` just for clarity, even though the value isn't used.


That sounds right. I'd use "head -n1" to get the first line as it's more readable in my opinion, but it's up to you.
It doesn't matter whether the first file is the real file or a symlink, cp will follow the link and get the content.


> No reason to revert from my end.

There definitely is! Since Garvin pushed his changing commit to addlang.txt without the newlines, which prior were in. This is messed now after the compile...

> We need addlang.txt to contain linebreaks after the define

Better say: for each new BLOCK of new constants. And you need to check if the last compile ended with an extra newline. (_Only 1 linebreak after last line is eaten by Github._)


This looks like it can be merged with the `lookupFileHashCache` function, both use sites are identical.


TeamCity Selenium POM :: CI [Build 58](https://teamcity.sponte.uk/viewLog.html?buildId=1063&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 41 Build time: 00:00:49


Jatte
Le 10 févr. 2016 11:27, "Basile Simon" <notifications@github.com> a écrit :

> tu sers à rien.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/feston/recettes/commit/6a58e5dc9622b99bcb09d6cec7e4fa289293e440#commitcomment-16002511>
> .
>


Thank you that you open this discussion. I re-assigned the bug  to fwupd folks. I hope so we find some other solution.
https://bugzilla.redhat.com/show_bug.cgi?id=1303531


Все круто. Ваш вариант пока лучший из всех, что мне довелось видеть:-)


A [change that the Core Team has merged just now](https://github.com/alphagov/government-frontend/pull/92) turned this method to use convention-over-configuration, so you will need to rebase, sorry...


why do it like this? see [reddit](https://www.reddit.com/r/haskell/comments/44w15q/psa_if_youre_serializing_floating_point_numbers/czu0hq2)?


Got it!


This wrong, print() works in different way :)


Rather complex fix imo.


@mxmlnkn to test before uploading, compile with `CFLAGS="-Werror" CMake ...`


This scaladoc is really out of date


Есть метод serialize,  т.е. здесь можно было написать покороче:
```javascript
$('#form').serialize()
```


But that is not what I commented on, which is why I said “from my end”.


This is identical to the previous use site.


Можно было использовать цикл, чтобы пробежаться по массиву error, а не проверять каждый руками. Получилось бы намного короче и лаконичнее


LGTM.


@Halkreen , don't worry about the longer strings (already happens with German version hehe). Just try to keep the spirit of the meaning (most of the strings are short and concise for buttons, titles, etc). If we have any spill out, we'll resolve it on the client. Thanks Thomas!


См. предыдущий code review


Why keeping "currentBatch" as member variable, you could move this to method level. Anyway you have a 'currentBatchIterator' and 'noMoreChildren' vars for traversals.

For this, you may need to add an extra check
   if(currentBatch.isEmpty()) { noMoreChildren = true; }
 in the constructor , right?.


'theme' is duplicate ??


DBErrors resulting from this update: [**Startup warning**](16537) #1653


Вариант норм. Кстати в jquery есть свой цикл $.each


Can't this just be `(task, resourceSet) :: (task match {`


small format correction: Please leave an empty space between if( , like

if (currentBatch.isEmpty())


Thank you very much!


Why `<>`?


don't know why this caused so many issues - I had problems seeing a branch created on git hub online again so used compare which then bought it up


If you indent like this I'd suggest also putting a line break after the `cond`.


Can we use `LATITUDE_MAX` here?


Can we use `auto` here?


Um, why are we switching them to floating point values?


Urggg, Obj-C is shit


> No, not really, it's just the way it was before. All paginated result callbacks are like this. The spec leaves this unspecified, so I didn't change it.

Ok, IDE's and compilers will help devs anyway so there's unlikely to be confusion


**SUCCESS** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 291](http://ci.infinispan.org/viewLog.html?buildId=35309&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for c6125793f862e6297a7282bea36fbdd187c55a20
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:07:57


I think https://github.com/ably/docs/pull/86/files#diff-11900b395df266bc2bbfc1d11bdfc7a0R754 is pretty much definitive, can you reflect that please?


I think, hasNext() also needs to call the remote server to see any more elements exists. Both #hasNext and #next should know whether I reached end. Since both are exposed APIs we don't know how the users are going to write their logic. I'd say your previous implementation was correct. Any specific reason to not make a server call?


The last paragraph was just me thinking on what would be the best way. I personally haven't done that for classes like Item.
Anyway, my initial point is that besides testing the notImplemented error, for coverage reasons, we should test the other more relevant case.


`auto`.


Thanks for good work. Overall patch looks good, I've added few more comments. Please take a look at it.


Let's remove the `=` sign so the compiler doesn't have to optimize it away.


As described (https://github.com/mesosphere/marathon-ui/pull/609#discussion_r52434435) adding an `isLoadingComplete ` getter to the PluginStore is problematic as the complete condition in this case means that every state but initial and loading results in complete and in other cases could mean something different e.g. only if every plugin loads successfully the whole loading process is complete.


would it make sense to put this in a setup method in case somebody adds another test?


Fixes most of #2 concerns.


Agreed


<irony>much better</irony> ;) (at least no tool barfs now)


Not sure we need this case, If a device is polled sleep we don't want to send a SLEEPM command during configuration, or at most is should be fixed to SLEEPM0 (disable sleep)
Polled device needs to be told to sleep for a period, and IIRC the only wait to specify the period and for it to act on it there and then is to send a SLEEP command followed by a period

This needs testing against a real polled device


SQL query for HFE updated


How we format it on the usage.


Makes sense


This returns an int, it needs comparing to zero I think.  You could add `.zero?`


@GianlucaGuarini ...I'm not sure, `cleanupData(data)` return falsy as-is and `normalizeData(data)` does not test its parameter.


ditto, `.zero?`


BTW I totally forgot to add this in repository-s3 as well.


`length`


Er, actually, just `!version.empty?`


beefed up → "improved" or "cleaned up"?


Great news :)


the second commit


I'm not sure about the webshot removal.. It could be used in the future to "tweet" a graph


"because." as a line ending doesn't work, I think. "Hence it moved from /usr/lib/systemd to /usr/bin".


I think the meaning of the escapes may change here, as `'\"'` is the value `\"` while `%q{\"}` is `"`.


know"s"


Hi @sockchinglow, please use `git pull --rebase` to avoid these merge commits.

Thanks, Tobi :)


Please generate a pull request for this against my fork of the course repo (ritjoe:hfoss/master)


Due to permissions, I'm not able to do this on the demo server.


Hi. Just upgraded too 3037 and have a lot of trouble with stale indexes not getting unstale. What was the problem here? The fix doesn*t look like too much related to the problem description....


nitpick: "color" (American English) and "honour" (British English) in the same sentence.. (feel free to ignore, though)


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 253](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=773&buildTypeId=XbimEssentials_XbimEssentials) is now running


@Mnw2212  what problem are you facing?? It was working fine here
http://localhost:3000/room/-K8_AiosLSaK0cralwtU


OMG I never would have figured this out :)


How about this as an alternative impl for this method (passes tests btw):
```scala
  def parseSizeToBytes(value: String): BigInt = {
    // is it just a number
    val size: Option[BigInt] = try { Some(BigInt.apply(value)) } catch { case e: NumberFormatException => None }
    size getOrElse {
      val regex = """([\d.]+)([ptgmk])b?""".r
      value.toLowerCase match {
        case regex(number, power) =>
          val pow: Int = power match {
            case "k" => 1
            case "m" => 2
            case "g" => 3
            case "t" => 4
            case "p" => 5
          }
          BigInt(number) * BigInt(1024).pow(pow)
        case _ => -1
      }
    }
  }
```


Why to use this if? :)
You already know what type of HTTP protocol you're going to use.
It is not intended to manually edit official plugins anyway


should not hard code pid file name on line 219, make it two _vars
_pidFilePath and _pidFileName


@andalusi good catch! I didn't check the full screen image.
Well, the image should not be deformed (unlike before), so I think your fix will work well.
The image provided should be the original size, so it will look big enough if done properly.


Just trying to understand better: why can this chunk be removed?


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 253](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=773&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:16


You are removing the warning for forgetting the --extract-option flag here, as additional arguments will be interpreted as additional files, not a path to a property in the configuration. I guess that is fine - it's a deprectation/helpful-migration message. But it should probably result in a major version bump.


Check-style violations in GPLoadDataOutput. @SergeyTravin please fix asap


So this one needs to be dropped from the PR?


Shouldn't this method just be `taskToInfoBiMap`?


I have an alternative proposal for `@Valid`.

If a member, parameter or return value declaration presents an annotated type use, then `@Valid` is implied for that declaration. `@Valid` is permitted but redundant in this case.

```
public class Foo {
    Bar<@NotNull Baz> baz;
    // equivalent to
    @Valid
     Bar<@NotNull Baz> baz2;
}
```

```
public class Foo {
    @Valid //optional
    Buz<String, @Min(5) Integer> num;

    // validates Buz as there is an optional @Valid here
    // inside buz, cascade validation to @Foo
    Buz<@Valid Foo, Integer> num;
}
```

Note that this model, while regular, is not the behavior of `Collection` and `Map`:

* `@Valid Collection<Foo>` is equivalent to `@Valid Collection<@Valid Foo>`
* `@Valid Map<Foo, Bar>` is equivalent to `@Valid Collection<Foo, @Valid Bar>`

Should we consider the former form as legacy and deprecated?

* New code would write it as `Collection<@Valid Foo>` or  `@Valid Collection<@Valid Foo>` for the verbose.
* New code would write it as `Map<Foo, @Valid Bar>` or  `@Valid Collection<@Valid Foo>` for the verbose.
* What should `@Valid Map<@Valid Foo, Bar>` do ?


Yeah. I was a bit concerned when I organized imports for the project... But well. It is what it is.
I did not check what is our policy. I actually defined in IntelliJ a limit of `999` common classes in a package before using `*`... :p


Does resolve work in the order listed? It looks odd to me because dicts in Python are unordered, but if I understand, there's a strong ordering implied here.


Thank you!

I'm writing a Forth mode for Emacs, so I have a similar need to communicate between editor and Forth.


This proposal eliminates the need for `autoApply()`


why do you have a one line commit


This message is giving you battery info ? The documentation does not indicate battery for this message.


That is done later already in https://github.com/mapbox/mapbox-gl-native/commit/85365a3ec4e51218d1d8d87803083f35b9d5bf3c :+1:


then there is this one


Ic, someone forked it. Then I might provide a pr for that issue; I'll check that


We should reach to the FX folks interested in validation to discuss that for sure. We do this feature for them basically.


Surely :+1:


Oops! How about now?


Nice! Please squash into the previous commit. One last thing that I'd add, is the rename from `console_handler` to `handler`. This was suggested/coded in:

https://github.com/clebergnu/avocado/commit/04556b32dc924144ae3489cc46e178c4e6d7af87

Looks like the experiment I proposed has one outcome: it's harder to forget to include something a reviewer suggested if you pick his/hers commit, possibly edit it further, and then squash into the original commit.


Two things:
1. I think you went a little crazy with the `get` -> `for` translation.  I think `for` should be used when you are fetching/looking up/building a value _for_ some parameter (e.g. `taskFor(taskInfo)`).  When it's just retrieving effectively a singleton value, just drop the `get` altogether
2. TaskManagerResources is immutable, so no need to wrap it like this.


typo: newer (?)


should be 8


what do you mean with "complex"?


Have to write in some more code knowledge


`pathFor`?  or `pathTo`?


模型内 protected $dbName 指定无效


It's Unix timestamp https://en.m.wikipedia.org/wiki/Unix_time number of seconds starting from 01.01.1970. I think most programming languages support it out of the box, you might need to do just minor adjustments(ex. JS works with milliseconds, instead of seconds, sometimes it's int, sometimes  long)


Does this typo which [was fixed by Sébastien Hinderer](https://github.com/coccinelle/coccinelle/commit/8b4fc6c1d7610a7cd0aefc9bc8cc5767201a7c3f "type_cocci: fix typo, coccinelle didn't compile any longer.") indicate a need to [integrate any special checks for commits](https://www.git-scm.com/book/en/v2/Customizing-Git-Git-Hooks#committing-workflow-hooks-KpT2hQhaik "Committing-Workflow Hooks") into your software development system?


`scriptPath` or `scriptPathFor`. It should read well in a sentence, e.g.:
I want the `scriptPathFor` this `task` and `taskid`


Same here. The policy of the check is simple: Star imports are not allowed at all. Personally, I question that this is more readable now but (a) Intellij folds imports (so I don't care) and (b) it is team consensus to do it this way.


Ditto.


Highly respected colleague,

I followed your opinion and I use now `unrestrictedTraverse`.

Cordially,

Gauthier


Looks good ... I will test that in the next couple of days myself :) Thx for fixing this so fast :+1:


Wouldn't it be easier to call `setjmp` directly instead of going through `CFBind_run_trapped` and `cfish_Err_trap`?


`taskIdFor`


This addition is causing issues for my dev set up. Webpack will bundle fine on it's own, but I think it might be causing issues with webpack-dev-middleware - any ideas on that?


`taskExecutionInfoFor`


**This file contains unused source code.**
*PyUnusedCodeBear, severity 1, section `python`.* *Related to file `coalib/settings/ConfigurationGathering.py`, line 5.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/settings/ConfigurationGathering.py
+++ b/coalib/settings/ConfigurationGathering.py
@@ -2,7 +2,6 @@
 import sys
 from os.path import dirname
 from os.path import isdir
-from os.path import normpath

 from coalib.settings.Setting import Setting
 from coalib.misc import Constants
```


**Line is longer than allowed. (87 > 80)**
*LineLengthBear, severity 1, section `python`.* *Related to file `coalib/settings/ConfigurationGathering.py`, line 187 column 81 to line 187 column 88*.


change max value of setting hours from "0017" (23) to "0063" (99) hours.


https://plus.google.com/+%D0%95%D0%B2%D0%B3%D0%B5%D0%BD%D0%B8%D0%B9%D0%9E%D1%80%D0%B5%D1%85%D0%BE%D0%B2/posts/dykmroX6oYH

    On 2016-02-09 11:53 PM, Shahid Shaikh
      wrote:

      Why replacement of '' with "" for string ?
      —
        Reply to this email directly or view
          it on GitHub.


Dont declare a new route, just use the API like the android team would do.


Good patch! :)


This addition is causing issues with my dev setup. Webpack bundles fine, but i think its causing issues with webpack-dev-middleware - any ideas on that?


@alexcoman @adelina-t

Solution for reminder/manager


@rwightman, I do not understand this part of the change, in conjunction with the comment in your commit message.
openblas_check is still "include/openblas_config.h", so "/usr/local/openblas_config.h" wouldn't be found. If the latter isn't scenario, should the original code be sufficient?


`completeGraphNode`?


hey Caa i see code for just Stage 1 of the project, im trying to implement the parceable, but i cant really load the json data into my adapter


Good catch!


On top of my inlined comments, I propose that:

* we explicitly express that these dynamic constraints do not propagate to method validation (i.e not on type parameter in the definition). Of course parameters and return values with type use constraints are accepted.
    * if we allow it, I fear we end up with lots of side effects like validating collection `get` methods and even more known methods
* what to do when an extractor for a given type parameter exist:
    * validates both the extracted value and the potential member (getter/field) present ? Or give priority to the extractor and inherently excluding the property (getter / field)
    * my preference goes to give priority to the extractor

In practice most cases (Map, Collection, List, Optional) will be of extractor type rather than the "pure" member based form.

Also, it seems that your proposal and the Proposal 1 are actually not far apart and could be reconciled as one. AFAICS, the treatment of Map, Collection, List, Optional, JavaFX Property will be the same in both proposals (via an extractor). So the only different case is that a default "BeanExtractor" would be used in your proposal. When would it be useful in practice (use case!)?


But the limitation of topologyKey for anti affinity is implemented in admission controller, the algorithm implementation should not assume what kind of logic implemented in admission controller


Hoist onto prior line?


OK.


Hey There,

have the same error on todays snapshot (r48648). Actualy it is the same error when I try to install the proto-extension on the stable 15.05...

All the best

Toxic


Ah - and I didn't see Garvin already reverted...


`scriptPathForTask` or `scriptForTask` or `pathToScriptForTask` or even just `pathToScript`


`ditto | s/script/log/`


Ок


no ".qml" for the name of the component ;)
Also, let's keep alphabetical order :)


Perhaps we should just have `private[core] var taskId : Option[Int] = None` on `Task` to simplify this book-keeping?


ხო ეგრე მქონდა მოფიქრებული ისედაც მარა იმენა ქალი და კაცი რო ჩაიწეროს ბაზაში ?
აი იყოს varchar ტიპის ველი ბაზაში და ასე ვიზამ კოდს.
if($_POST["Gender"] == "Male") $gender = 'male';
else if($_POST["Gender"] == "Female") $gender = 'female';
მოსულა ?


ოკს


This causes #673


Maybe with a macro like

    #define TRY(error, routine)               \
        do {                                  \
            jmp_buf  env;                     \
            jmp_buf *prev_env = current_env;  \
            current_env = &env;               \
            if (!setjmp(env)) {               \
                routine;                      \
            }                                 \
            current_env = prev_env;           \
            error = thrown_error;             \
            thrown_error = NULL;              \
        } while (0)

    cfish_Error *err;
    TRY(err, result = fn(args));


sry

On Wed, Feb 10, 2016 at 5:00 PM, Pushpendra-01-Singh <
notifications@github.com> wrote:

> abc
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vikaschauhan1/my-webpage/commit/c5bd33de9fb7a775bee8a3cf3d5ead3983039652#commitcomment-16002569>
> .
>


But then the rules will always be included. So, how about I change the entire if to a kernel version check, and then if we're on 3.7 or newer the table is always included whether or not it has rules, so if there are no rules after there were rules previously then they'll get cleared?


(Nit: space after commas; also elsewhere)


@eradman
Is this project alive?
Wouldn't be better to merge with other project and get the best of both?


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 254](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=774&buildTypeId=XbimEssentials_XbimEssentials) is now running


`taskFor` or `taskForId`


`taskFor` or `taskForNode`


No worries! I submitted an issue and PR to make reference to the big and the fix, in case anyone else runs into it. :)


`taskExecutionInfoFor` or `executionInfoFor`


well it's quite complicated to squash it as it's introduced in View commit, but related parts are modified in following patches. So I left it as separate commit. I'll change the name to `handler`, I missed that ...


Ditto


cool, didn't know about that, will update


Maybe ```slug_exists``` route name would better describe what this method does?


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 254](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=774&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:36


Ditto.


Ah thanks :) Very timely. We will have to rename `ServiceManualTopicPresenter` to `TopicPresenter`.


`statusFor`


`taskFor`


Neden?


Btw I couldn't use your commit as it touched only portion of the code. You can see the difference yourself...


`taskIds`


başlık belirlendi


`taskToInfoBiMap`


text Değişti


`graphNodeFor`


Hey Manuel (@siebenkopf),

Can I release a new version with the modification?
I just pushed this commit to our nightlies build.

Thanks


Nit: closing brace missing after the URL


Shoudn't this return `false`?


`graphNodeStateFor`


Hvorfor et empty commit ?


Shouldn't this return something?


I have the same problem. An official solution would be better and easier...


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15235](https://teamcity.mesosphere.io/viewLog.html?buildId=131184&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:05:03


@Alex-Yuen 感谢反馈 已经修正


oooo! I like!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15233](https://teamcity.mesosphere.io/viewLog.html?buildId=131173&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:12:44


`predecessorsOf`?


Vi legede, og det var ikke tomt. Du kan ikke commite, hvis du ikke laver ændringer. Men det var et tomt tekst dokument.


Forgot to set my git user etc. on this but it most definitely was me that made the commit/push @Cara-Jo


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15234](https://teamcity.mesosphere.io/viewLog.html?buildId=131183&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:08:35


Error durring scanning function fixed


Are you sure that the User/Group is mongod and not mongodb ? (On wheezy it's mongodb)


@sevoku: you reverted my change here, is it on purpose?


The `#{e}` in the log message is not bind to any exception?


Jo man kan, silly! Tjek mit nyeste commit.


Did you mean: `sessionListSavedState = savedInstanceState.getParcelable("sessionListState");` here? Would be great to use a static string for `"sessionListState"`


This is an example of what I was talking about.  I have no idea of the significance of returning Some(Nil) vs. None.  Even the `@return` doc doesn't explain it in a way I understand.


`graphNodesInState`


nå okay :) commitede du henviste til var bare ikke tomt så


Also, is it std::min({m,n,1}) you want (i.e., 0 or 1)? Or do you need std({m,n}) - 1 ? https://software.intel.com/en-us/node/521150 seems to suggest the latter way ... (occurs a couple of times)


`graphNodesInStates`


That should be solved with the current code. The tests fail because of datetime localization issues only.


`graphNodesWithPredecessors`


is there a way to programmatically set # threads for openblas?


Men der er ingen ændringer i hej.txt.


I need to rollback to initial


Ok, thanks for clarifying


Closes #23


@shicks @concavelenz @blickly
I updated my fork to this change before it was rolled back. I'm not sure if it's coming back soon. However you might like to know that it causes the AST to be built for every source file, where previously the regex magic for goog.provide/require meant non-required units never got parsed. Perhaps this is why your rollback mentions parse errors.


In local, apps don't work with index.html, is it related to this commit ?
Only works apps/mobile/ but not apps/mobile/index.html


Sounds good.


I don't think that does anything like what I suggested.  For example, if you were using seconds instead of milliseconds, that test would not demonstrate that.  Actually communicating with the API in this case is necessary


ბიჯო, ყველაფერი შეიძ₾ება, შეგიძლია რამე შენი ანბანი მოიგონო და ის ჩაწერო მაგრამ აქ არის რამოდენიმე საკითხი რომელსაც ყურადღება უნდა მიაქციო
1) რომელი უფრო ნაკლებ მეხსიერებას შეჭამს 1 ან 2 როცა გაქვს თუ male ან female
2) ამ მონაცემების გაგზავნა უფრო მალე იქნება შესაძლებელი ვიდრე იმ შემთხვევაში როცა male/female გაქვს და რაღაც მხრივ ყოველთვის წააგებ ვიდრე პირველ შემთხვევაში
3) ზოგადად მიდგომაა ასეთი რომ ბაზა რაც შეიძლება ნაკლებად დატვირთო, შეიძლება მარტივ აპლიკაციაში არაფერი მოიგო მაგრამ მოვა დრო და დააფასებ :)

ამიტომ, არ მოსულა და ჯობია აქედანვე მიეჩვიო.


Oh wow, you've got to be kidding me!


By the way, do you want to include the password in the HTML?


Sec, should there be a 1px space between the windows? I changed the allocation calc by 1 px and I was pretty sure that there was no space, but perhaps I misunderstood the intention behind your change ;)


@ljacqu can you check also why the IPB4 test takes 20 seconds to complete?


In python 2.x print statement followed by comma means place a space after the displayed string instead of a newline. But in python 3.x , `end=' '` do the same so, here `print (line, end=' ')` will be do the job. am i right?


Булат, можно меньше чем 9 действий сделать.


Why do we no longer cleanup after the tests?


Could you please replace with the following?

```rb
      translated_segments.reject!(&:blank?)
```


Yes. I used distutils.core, as normal, but I didn't use one bit of py2exe. Use `sys.argv.append("windist_inst")`


I tried it and doesn't work


Způsobilo problém s víceřádkovým odkazem do PDT-Vallexu pro celý lexém (neboli jsou-li modrá slova vpravo nahoře alespoň dvě). Viz třeba .../#/lexeme/brat-1/0 -- na "vzít si" téměř není možné kliknout a při scrollování se překrývá s textem lexikálních jednotek.


An error in the task will force us to recompute it (And always get the same error).


Of course, I really hope that this is just temporary. It's seem to be worked in the linked bug, but currently systemd does not compile on rawhide.


This event it is never fired when I log into mediafire


I'm surprised by this change. Why don't you want to export the methods?


Could this be moved to a `successCb` on `createTearoutWindow`?


Must saud


ok, reviewed


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15236](https://teamcity.mesosphere.io/viewLog.html?buildId=131205&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:08:08


It might be possible to move this logic into an additional event listener non-tearouts


Since there are not supposed to be nil values, maybe we could go for ruby's `empty?` method:
```
 translated_segments.reject!(&:empty?)
```


oops, thanks


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 255](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=775&buildTypeId=XbimEssentials_XbimEssentials) is now running


Thanks @hugovk  for his help given in pylast/pylast#168.


fixed


kanskje tilbake denne?


Well basically the line is drawn into "nirvana" when no zero is in the axis range.
Styling is limited to the styling of grid lines atm, but I think I will make it separate.

Also I have another branch where I already removed the "startAtZero" stuff since it's kind of redundant if you can just set axis min / max value anyway.


Esta vacio, creale un contenido


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 255](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=775&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:30


I'm curious why implementations are different for py2 and py3?


consider using isNotBlank(..)


The reason our server returns HTML, is that the endpoint it http://spark.furore.com/fhir, not http://spark.furore.com ;-)


:D This sentence without any punctuation and hyphens is very hard to read.
Not sure if I understood it.
It still doesn't clarify why this function (however it is named) cannot be part of the store.


No, this commit does not fix the SegFaults.
A first comparison of Z3 (version from yesterday vs from today) within CPAchecker shows:
Most of the SegFaults remain unchanged, only some test programs switch between SegFault and Timeout. Overall there are more SegFaults now than in the previous version.


I am confused about what "reserved" means in this docstring. It is also present in the first 4 tests below.


Nice, thanks!


can be simplified to
url += (colo.isEmpty() ? "?" : "&") + params;


I would offer _range as a better suffix than _through


teste


could someone explain this syntax for me?


the same as above (submitAndScheduleWithParam)


why not just `process foreach { _.destroy() }`


indent


Good point. Created https://github.com/juttle/juttle/issues/377 to track that.


Fake and gay


Why is this function ok-ish in Marathon.jsx but not in the PluginStore? Where is the difference?


Cette ligne semble absurde. Ce qui est sur c'est que le cout pour aller vers 15 noeuds devrait etre entre 15 et 15*sqrt(2). A fix, en prenant en charge les couts dans NodeList.K, ce qui va permettre d'appliquer Astar avec les couts de déplacement non uniformes (question 8) automatiquement sans modifier le code.


Oops.  Guess I missed this. :)


I believe there is some confusion going on here.  This Makefile seems to be what the docker-compose.yml would do within the pipeline.  I would expect a Makefile to build the project (which it doesn't, and which it -indeed- also shouldn't do within this project).

@erikap Could it be that we should include an example docker-compose.yml snippet instead of this Makefile?


Yeah I've added 1px gap yesterday :)


TeamCity LabKey :: LabkeyRelease15.3 :: CDS postgres 9.4 [Build 145](https://teamcity.labkey.org/viewLog.html?buildId=302094&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 9 (2 new), passed: 41 Build time: 01:25:02
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisFilter: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

```


> However bad a release was, eventlet should not remove it from PyPI.

I concur with booxter, please never remove any release from PyPI.

For example, eventlet 0.18.2 introduced a new regression... https://github.com/eventlet/eventlet/issues/296


@mjwitte Thank you for reviewing and merging.


Magnifique ma chérie.


This is temporary workaround, I have no ide why selection and metaSelection changed after openin  modal.


missing `break` statement


If it's illegal for there to be no taskRunner, why not just use `taskRunners(taskId)` and let it throw an exception if they key isn't present?


okay!


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1281.18780e687ebc95acdda42585a52975827cf0280d](http://build.palaso.org/viewLog.html?buildId=69055&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 947, ignored: 12 Build time: 00:08:40


Cajk :-D


:smile: Yeah, it's hard to read. Sorry about that! It's not about the name, it's about the definition of complete. We want to wait with the polling until all plugins had a chance to load and bootstrap but don't want to crash the whole application if one of the plugins fails to load. Therefor the definition of "complete" in this particular case is that any state other than "init" and "loading" is complete. As this definition is probably wrong in many different cases we should not add a method with this definition to the store.
Do you have any strong reason why this check needs to be done within the store?


Sadly I don't think I will find the time to maintain an application this large.
What "other project" do you speak of?


Should either check whether `completion` is nil or mark it as non null in the method signature.


gone


`taskInfos(taskId)`?


It should work fine but just a little suggestions:
- Column order: primary_key first, ForeignKey second, other columns last.
- Maybe just use `uid` which stands for User ID instead of `author_uid`, just some kind of redundant. Maybe `uid` or `author_id` are both OK, in which I prefer the first one.


Opening bracket always on the right


`runningTaskIds`?


Nil check completion


same here


why don't we add parameter to submitAndSchedule(String data, String user) and if param is blank we just submit and schedule the entity as usually. If param is not blank, let's add it to url.
Also we can still have overridden methods like
submitAndSchedule(String data) to not affect existing code


Would be good to subscript -- usually W with no subscript refers to total weight, I.e. mtow


we can just add parameter to schedule(String processData, String user) method and add overridden methods


This is the final version that integrates correctly with TravisCI service


basta puntatori !


camel case : ProcessWith


I think the second one reassigns the prompt command instead of concatenating on to the end of it, and you'll only notice a change if one has already been set somewhere else (eg "$(date +%H:%M) " to display the current time).


:tongue:


we need to tag class as embedded/distributed, or tag each test separately if they are not of the same type


@hargup This merge should be reverted.


Yes, it should! =D

Thanks!


@GrifP be sure to also update copy in HTML version of this email.


I'm checking this as well..


Yes


@vancura: fixed in 8098ac6152273d5636d8a5561b10bd5fe738eca5 :-) Sorry!


one day you will have killed the whole upstream repos with one of these foce pushes ;-)


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


ลบไม่รู้ว่าเป็นไฟล์อะไร


We need to compile WebView 40 because we need to apply one patch


I don't get the magic 10000.


Done (provide a lambda that will provide a lambda ...!)


Implemented arkenthera/ChiikaIssues#8


@contactashish13

1. I think would be better if you can fork and send pull requests, since some things have a purpose and you might need to rework code

Looks like the main issue here is that you have worked on an old version of the plugin without syncing or something so lots of things were reverted to 5-6 versions ago.

Could you please revert this to the previous commit code and add your code again?


"A block block "


@endJunction There is an ``assert(result->size() == _x->size());`` in ``_x->copyValues(*result);``.


Good one


align on `=>` please


Should be ok by me.

BTW, I wondered if it'd be ok avoiding the encode/decode - i.e. just:
````data[0] = self._rollover + data[0]````
instead of:
````data[0] = (self._rollover.encode('utf-8')+data[0].encode('utf-8')).decode('utf-8')````

Didn't trust it enough to try it though, but I will at some point...


typo :)


if (completed && completion)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15239](https://teamcity.mesosphere.io/viewLog.html?buildId=131231&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:05:06


why do we need try/catch?


sure, but that sounds like something to fix in the uapi/glibc headers in rawhide... after all not just systemd broke, but pretty much everything else using this, too.


Sure, the commit wasn't intended to be used AS-IS, but to include everything that I caught during the review. Then, as you did here, you get to include even more stuff that you found related to the same commit, ideally squashed into the original one.


ska kolla om detta funkar


Why are you getting rid of this? It'll be useful in the future.


`key` or `keyForValue`


develop (mjwitte) - x86_64-MacOS-10.9-clang: OK (1526 of 1526 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


`value` or `valueForKey`


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 153](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=776&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


still not working if args.image is not just a file name, but a full path.


@endJunction
``_x->size()`` gives the global size.  ``result`` with this size caused an assertion problem in ``_x->copyValues(*result);``.


bra pullat fredrik


Yo, that is correct!


Since this may fail on environments that load the application from a VBox shared folder or a NFS, and causes race conditions with the [awdwr](https://github.com/rubys/awdwr#readme) test suite, perhaps adding something like

    unless ENV['RAILS_DISABLE_LISTEN']

... would be in order?  This could then be both a documented part of Rails and something added automatically by [rails-dev-box](https://github.com/rails/rails-dev-box#readme).


I think this has been removed by the final version


Eu não entendi quais foram as correções feitas...
"private String user = "user";" ?


Good idea


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15238](https://teamcity.mesosphere.io/viewLog.html?buildId=131230&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:04:59


Ahh, ohh, it is a charm to read this now. :D :dancer:
So, yeah, I completely agree about the definition of complete! ^^
So, example, we have 4 plugins.
2 a added without an error, 2 couldn't be loaded somehow.
Means at the end:
```JavaScript
var isFinished = !(init || loading) && !(init || loading) && !(init || loading) && !(init || loading);
```
Why does a function to determine this, not belong to the store?
Where those states are processed and set.
It does belong there!

Where am I wrong?

```JavaScript
get isProcessFinished() { // Hower this is named, there is certainly a better name
  var pluginLoadingState = this.getPluginLoadingState();
  return pluginLoadingState !== States.STATE_INITIAL &&
    pluginLoadingState !== States.STATE_LOADING;
},


Makes sense


@BoumSam13 #25 looks good. Press ahead!


Boa sugestão @dseeker


レベルの表示 #124


LGTM


Ni har tagit bort Karwan


Nice commit message...


What is this solving?  I find the original single method easier to read and maintain.  Probably we could get rid of the warning by replacing all those `if`s with asserts, e.g.:
```scala
if (Files.notExists(parent))      throw new AssertionError("Cannot write file because parent directory does not exist: " + path)
// becomes
assert(Files.exists(parent), "Cannot write file because parent directory does not exist: " + path)
```


I wish there was some kind of `java8to6` tool that would take care of that.


It's the term used in the regulation. I'll try to expand this doc string a bit, but it means the paragraphs have no content, they are reserved for future use by the agency. Not that there's a limited supply...


Would it not be better to put the entire macro value inside `do { ... } while()`? Right now, something like:

    if (something)
        SET_COMPARE_B(x);

will not produce the expected result, so I'm not sure what the added do while really fixes?


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1545 of 1545 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Interesting. I might be missing this, but you pass the localkey and livekey in through the template variables, but do they ever get used?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15240](https://teamcity.mesosphere.io/viewLog.html?buildId=131233&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 223 Build time: 00:04:09


All this is doing is hiding the `== null` check inside of the `Option` constructor, and making the rest of it more verbose.  Let's replace these with `assert` calls too.


It's a large number; this test exists to say "you aren't using 1, 2, 3, etc. which would likely have a conflict". I'll add a comment.


TeamCity DNN JavaScript Libraries :: CI [Build 144](http://teamcity.engagesoftware.com/viewLog.html?buildId=422&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 144](http://teamcity.engagesoftware.com/viewLog.html?buildId=422&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:15


Some Java APIs return null, I don't think it helps to hide that behind calls to `Option()`.


```!enable``` seems to be more readable and style conformant than ```enable == false```. There are a couple of similar cases below.


Apologies for the strong statement. I've seen this particular one be closed on issues and swept off as a ui-select issue so that `resolution: not-core` happens. I actually don't think there is an open issue to discuss it at the moment.

My goal was to provide an alternative (opt-out). It seems that isn't the direction to go unless other apps have a problem. Totally cool.

One thing I love about angular is the breaking change list, it makes it very easy to follow along and I get a checklist of things to go through when I upgrade. While this isn't a breaking change, I think it highlights the fact that the change ends up breaking things (that weren't directly supported). A potential breaking change for this might look like:

> Lazy compilation of the `tranclude` function forces asynchronous behavior in template rendering that, while suggested prior to 1.5.0, was not enforced. If your directive requires that the child template is rendered before the parent, you now must handle this asynchronously. See [ngMessages](#) for a way of doing this.

Thanks for 1.5.0, it looks like a great release. I don't want to turn a commit comment into a huge thing, so take it with a grain of salt.

~ Steve


That's what I am referring to here


Yes, that would be better form, and pretty much essential if these macro were meant for general public consumption.


From the test cases, I was misled (for a brief moment) whether the ranges would have to be followed by the string Reserved... to be detected.


Comment this line to make compiling work


I had synced to get the latest vesion but I guess I overwrote the files. I
have added my changes line by line now.

On Wed, Feb 10, 2016 at 7:05 PM, Ionut Neagu <notifications@github.com>
wrote:

> @contactashish13 <https://github.com/contactashish13>
>
>    1. I think would be better if you can fork and send pull requests,
>    since some things have a purpose and you might need to rework code
>
> Looks like the main issue here is that you have worked on an old version
> of the plugin without syncing or something so lots of things were reverted
> to 5-6 versions ago.
>
> Could you please revert this to the previous commit code and add your code
> again?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Codeinwp/wp-product-review/commit/4afecbadeea9df5a4f5b1e7e5c7fd6b133553003#commitcomment-16005178>
> .
>


Return early `if len(gvrs) == 1`


There are a couple more renames missing:

https://github.com/clebergnu/avocado/commit/eb80b81e408d37af6719a369ba279ede55d6b2b0


Actually, although these can be created with new, they won't behave as normal arrays in what the length property is concerned. The constructor is used not to create but to initialize cast instances.


Why not just make out a public var?  This method isn't doing anything other than assigning and we can always override the accessor and mutator for it later if we want.


What if you have multiple view types


They should be the same object unless the JS engine does not support changing the `__proto__.`


@minoriinoue ありがとう!!


大丈夫です！


Done.


Thanks, with a new version of numpy i have a problem with colormap and i'had no idea to solve it

Sylm,


yep. It's an async hook. Fixed.


optimized > optimised


I removed the boolean above. The return value is only relevant if it is "true" (= sendResponse may be called asynchronously).


Furthermore we > Furthermore, we


Também foi tirado os comentários do merge e foram coisas de style guide do java


This tells me my previous statement about length not being updated is wrong. It might be a cross-browser issue, but I'm almost sure that generally, the pattern you're using does not work. At least, when I wrote the code, I only intended for array sub-classes to be used with `to`, and never newed up directly.


Automated Test Evalution with ELK in the Pipeline: > Automated test evaluation with ELK in the pipeline:


L44-51: what do you prefer: iterfield or get_fieldvalues?


I was aware that `async void` was intended to be limited to certain implementations, but not exactly to what.  Thanks for the resource.


@derekwaynecarr what is the value for us running two controllers instead of one?


In the past an engineer > In the past, an engineer


Si se puede, ponerlo un poco más chico, mejor!


Base.Array :-)


BlameTheVM™


idem


+1. Size patch looks good


analyze > analyse


O sea, más chico con más espacio blanco dentro del cuadrado


@bwoebi never force push `master`.


Still seems odd to allow DocumentMetadataByKey(null) and thus change the contract instead of just not calling it when the key is null in the context of that particular task and error.


L29,30: if there is a dedicated index (journalname is example) it should be used


docs/ :)


*Conversion


^ this.


Remove the link to the follow up post. I will comment on that in the next PR.


Why? A pass is supposed to implement only one of `MirMapPass`, `MirPass` or `MirBlockPass`. These impls not only make everything have the same interface (i.e. regardless of which pass pass implements, the pass will also implement the `MirMapPass`), but also enforce the constraint of having only one of these implemented by the pass.


wisley > wisely


Avoid unused local variables such as '$crawler'.


Avoid using static access to class '\GuzzleHttp\HandlerStack' in method 'getGuzzle'.


Need to handle volume creation without user given display name


Cheers :+1:


Ping @d6y . This is the horror of dynamic languages. We sent the actual function to fs.existsSync that expected a filePath but just says "no, that file doesn't exist" :)


Understood.


კარგია, გავითვალისწინებ მაგასაც. კიდე რამე ველი შეიძლება დავამატო ვაფშე ? ერთი ავატარის ატვირთვა მოვიფიქრე და ეგ ჩავამატე,  სხვა?


OpenShift on Kubernetes as a pod...

Separation of concerns.

On Wednesday, February 10, 2016, Maciej Szulik <notifications@github.com>
wrote:

> @derekwaynecarr <https://github.com/derekwaynecarr> what is the value for
> us running two controllers instead of one?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/miminar/origin/commit/a1cbf5b3b6652096dee93a02055a33582e99cb00#commitcomment-16005613>
> .
>


I created a quick test console to see if the behavior did what I wanted it to do, and it appeared to work the way we wanted.  Though the point around `async void` is very clear, and should be re-worked.

I think your idea for implementing a thread that takes a collection of items to publish in a batch is great.


This might be unnecessary depending on how you eventually decide to let the user decide to enter a storage type name.


Right, I do not disagree.


I have installed the latest version of ServiceControl and I am still receiving the error:

"The server cannot handle directory requests"

![image](https://cloud.githubusercontent.com/assets/6755138/12949128/58165fcc-cffe-11e5-933a-0e9adea63796.png)


Hi @SamyPesse,

Could you shed some light in advance, what's this improvement?
We're in a planning phase of the migration to GitBook Enterprise and any additional info is helpful (even if not yet available).

Thanks a lot!
Imre


2 in-code questions

The record.warn should generate a (asana?) ticket and alert a cataloger.
Don't know how this is done.


that was on line 12


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (977 of 977 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-28.31%25-green.svg)


I think what you're planning to do is to define a key value for IndexType where you have (IndexType IndexSubBlockType) entered by the user. Might want to consider taking in a \*ParseString instead of a pointer to an enum because it makes the parser simpler (we can reuse ParseKeyStringValue). The the resolver would do string comparison to decide if the user's string is a valid string.


Try: `-o Dpkg::Options::="--force-confmiss"`


ytr


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15241](https://teamcity.mesosphere.io/viewLog.html?buildId=131249&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:04


Oops :)

Both works, but since it is a directory I'll change.


I mean, the message, you wrote doc/


"Ändra", what does that mean?


I fixed the commit message in 28e6e19d0a254ed1187b9e352e6070f0cfc4433d.


I have added condition to the query as you wrote
{code}
select * from dfs.`D:\drill\files\testData` where dir0 = maxdir('dfs','D:\drill\files\testData') and columns[2] = 'Q2'
{code}
and with enable_contant_folding option turned off I got an error:
_(java.lang.UnsupportedOperationException) The partition explorer interface can only be used in functions that can be evaluated at planning time. Make sure that the planner.enable_constant_folding configuration option is set to true._
I have looked at the plans creation and in DefaultSqlHandler in convertToDrel(RelNode relNode) method we receive
{code}
convertedRelNode = (DrillRel) doLogicalPlanning(relNode);
{code}
When we call
((DrillProjectRel) convertedRelNode).getInput() we receive DrillFilterRel which contains private List<RexCall> conjunctions.
When planner.enable_constant_folding = false, one of conjunctions is "=($1, MAXDIR('dfs', 'D:\drill\files\testData'))", when true - "=($1, '1991')"
At first I though I could check conjunctions for having directory explorers functions and if yes, throw as error.
But unfortunately conjunctions is private variable and there is no getter for it. So there is no way I can get it without reflection. I guess going that far will be an overhead.
My opinion, original exception is pretty valid and tells users to turn on planner.enable_constant_folding which is straight forward. So unless you have other idea how to check this case, I suggest to leave it as is.


I think docs is fine in the ignore file.


aha :(


Tag一覧ページです。


The test cases for unit tests I suggest to have are:

1. The pod to schedule prefer to run together with some existing pods in the same region
  1. the nodes that have the label `{"region": "foo"}` (match the topology key) and that have existing pods that match the labelSelector get high score
  2. the nodes that don't have the label `{"region": "whatever the value is"}` (mismatch the topology key) but that have existing pods that match the labelSelector get low score
  3. the nodes that have the label `{"region": "foo"}` (match the topology key) but that have existing pods that mismatch the labelSelector get low score
  4. the are 2 regions, say regionA and regionB, both regions have nodes that match the preference. But there are more nodes(actually more existing pods) in regionA that match the preference than regionB. Then, nodes in regionA get higer score than nodes in regionB, and all the nodes in regionA should get a same score(high score), while all the nodes in regionB should get another same score(low score).

2. Test the symmetry cases for affinity, the difference between 1. and 2. is not the pod wants to run together with some existing pods, but the existing pods have the inter pod affinity preference while the pod to schedule satisfy the preference.

3. The pod to schedule prefer to run together with some existing pods on the same node
  1. the nodes that have the label `{"node": "bar"}` (match the topology key) and that have existing pods that match the labelSelector get high score
  2. the nodes that don't have the label `{"node": "whatever the value is"}` (mismatch the topology key) but that have existing pods that match the labelSelector get low score
  3. the nodes that have the label `{"node": "bar"}` (match the topology key) but that have existing pods that mismatch the labelSelector get low score
  4. the are 2 nodes, say node1 and node2, both nodes have pods that match the preference. But there are more pods on node1 that match the preference than node2. Then, node1 get a higer score than node2.

4. The pod to schedule prefer to stay away from some existing pods at node level
  1. the nodes that have the label `{"node": "bar"}` (match the topology key) and that have existing pods that match the labelSelector get low score
  2. the nodes that don't have the label `{"node": "whatever the value is"}` (mismatch the topology key) but that have existing pods that match the labelSelector get high score
  3. the nodes that have the label `{"node": "bar"}` (match the topology key) but that have existing pods that mismatch the labelSelector get high score
  4. the are 2 nodes, say node1 and node2, both nodes have pods that match the labelSelector and have topology-key in node.Labels. But there are more pods on node1 that match the preference than node2. Then, node1 get a lower score than node2.

5. Test the symmetry cases for anti-affinity, the difference between 4. and 5. is not the pod wants to stay away with some existing pods, but the existing pods have the inter pod anti-affinity preference while the pod to schedule match the labelSelector.

6. Combined cases considering both affinity and anti-affinity, the pod to schedule and existing pods have the same labels (they are in the same RC/service), the pod prefer to run together with its brother pods in the same region, but wants to stay away from them at node level, so that all the pods of a RC/service can stay in a same region but trying to separate with each other:
  the situations are the combination of 1. and 4.

7. Test the different operators and values for pod affinity scheduling preference, including some match failures.


Actually I have a use case to keep untracked files during clone.
And I don't use JGit. but it still get's executed.

I'd appreciate a handy checkbox to bypass this in scm config.


It's a few improvements for managing collaborators on organizations:
- Sync with a GitHub organization
- Specify permissions when inviting collaborators by email
- etc


@bryk Could you check that and maybe the whole solution? It seems to work on IE, FF and Chrome but some code seems a bit hacky. I know there is a way to simplify it somehow...


prototype１つ１つについているタブをクリックすると、
そのタブに属してるprototypeがでてくるようなリンクです


სად ამატებ ავატარს და რას აკეთებ ვერ გავიგე, ცალკე ისიუ გააკეთე და იქ დამიწერე რომ ბაზის მხრივ მოგცე რჩევები.


这位同学，看你有接触过newrelic SDK的经历，方便留个联系方式么？


What actually goes wrong if you keep the edown dependency? Just deleting it is not an option since edown is used to build the documentation.


OK.


I think this change really reduces the readability of this method.  The AST for an annotation basically guarantees that `head` call will work.  And similarly, the `argumentLookup` will always have values for those fields.

If you really must eliminate every `.head` and `.get` let's try:
```scala
val name  = arg.children.headOption.map(_.toString) orElse throw Unreachable("Annotation param without name")
val argdef = helper.argumentLookup.forField(name) getOrElse throw Unreachable("Args must be in lookup)
```


doh -- you're correct, my fault.


editページを編集し忘れていたので。


And test cases that test how different weights effect the score are also needed.

And, please add some e2e tests.


This is good - removing the deprecated notion of Primary/Secondary/Search menu and replace with real domains (search & settings).


...or we could package a JRE 8 with Gradle and forget about supporting Java 6 (and any other Java version for that matter) for the Gradle runtime.


I thought we weren't going to replace if/else chains with matches that are just chains of `case _ if`.  It's exactly the same, only with more words.


Declaring `driver` as `JComboBox<?>` and then instantiating it as a `JComboBox<Object>` defeats the purpose of JComboBox being generic.  Now, you can literally insert anything into the container and the compiler can't tell if it is correct or not.  To start with, the JComboBox should be declared and instantiated as `JComboBox<String>`.  But, in reality, if the list is to be controlled from within the program, then it is better to define an enum that lists the available driver types (e.g., `JdbcDriverType`), then declare the combo box as `JComboBox<JdbcDriverType>`, then later on when dealing with the user's selection, a switch statement could be used which switches on the enum's values.  It would look something like this:

```
public enum JdbcDriverType {
    None, Demo_1, Demo_2, Demo_3
}

public class CreateWindow extends JFrame {
    // class member declarations
    // .........
    // private static JComboBox<JdbcDriverType> driver = new JComboBox<>(JdbcDriverType.values());
    // ..........
}

// Later on, in the event handler
JdbcDriverType driverSelection = driver.getSelectedItem();
switch (driverSelection) {
case None:
    // Do something
    break;
case Demo_1:
    // Do something
    break;
case Demo_2:
    // Do something
    break;
case Demo_3:
    // Do something
    break;
default:
    // do something
}
```

The advantage of this is that it catches many more errors at compile time.  For example, if you have a case in your switch for a value not defined in the enum, the compile fails.  WIth an array of strings, it goes on happily and you may not know that you made a typo.

The main reason to not take an approach like this would be if you need to construct the list of possible selections at run time.

Consider which of the two approaches I suggested is better suited to how this will actually be used.  In either case, the approach taken here is not acceptable.


Thanks, sounds interesting, will check it out definitely!

2016-02-10 15:04 GMT+01:00 Samy Pessé <notifications@github.com>:

> It's a few improvements for managing collaborators on organizations:
>
>    - Sync with a GitHub organization
>    - Specify permissions when inviting collaborators by email
>    - etc
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/GitbookIO/blog/commit/ecbd3e3d4771f0527f43534686c1a17694b848d3#commitcomment-16005879>
> .
>


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15242](https://teamcity.mesosphere.io/viewLog.html?buildId=131253&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:04:59


May be missing:
* Testing the several weird argument combinations of the extend method, including with keyArgs?
* Testing that displayName is also set on constructors?
* Testing that name and displayName and other special static properties aren't statically inherited
* Testing the case where the _class constructor_ is the provided "constructor" property and the case(s) where it cannot be?
* Testing that "constructor" overriding and base calling works even if an in-the-middle class doesn't specify "constructor"?
* Testing that a method that calls base always gets a base method, even if there is no base method...
* Testing that a method that overrides a base method only gets wrapped if it has `.base(` (or something like that) in its code

Anyway, great work ;-)


I like your username idea, but I also want to have multiple files so someone can back them up individually by username.


Avoid unused local variables such as '$crawler'.


Avoid using static access to class '\GuzzleHttp\HandlerStack' in method 'getGuzzle'.


We've talked with @miminar on IRC about changing this to something like `projectrepositorysize`(can be pluralize to `projectrepositoriessize`) or `projectimagesize` (`projectimagessize`). Godoc is one thing, but naming should reflect as much as possible the function of an annotation. We already use similar pattern with `projectnodeselector` so this builds on top of this.


``` js
const x = 'foo';
const obj = {
  [x]: 1,
  'bar': 1,
  baz: 1
};
obj.foo === 1;
obj.bar === 1;
obj.baz === 1;
```


რეგისტრაციის ფორსმაა სმნ რა ვერ მიხვდი.


You have removed if (currentMl > 0) { } which was required.
if (currentMl == 0) there can be a problem with the opt parser.


OK, makes sense. If possible, please add a short(ish) commit message.


Localize! Localize! Localize!


A link on the subject of Array subclassing: http://stackoverflow.com/questions/3261587/subclassing-javascript-arrays-typeerror-array-prototype-tostring-is-not-generi

It looks like we could also get the `new` with a smarter constructor. But haven't read through the referenced kangax's article.


Yes. made the corresponding changes :)


This and the instances below are not donations.


Interessant


Hm... Naming the function "finished" or similar boils down to different concept and definition which actually could make sense in the PluginStore. I just don't wanted to add something that specific to marathon component to the store.


Quite like the abstraction over the view animations provided by ViewAnimationController and other types under Helpers/UIAnimation. Slight concern that while this makes the code nicer, potentially moves us further away from designer-driven UI authoring, but this is maybe a good intermediate step to abstract it from the views. Is also somewhat different from the encapsulation on Windows (CustomAppAnimation).


Nit: `start_type.ins = []`


Unfortunately this code doesn't work as expected.


I haven't tested, but I think that this fucks up theming colors

because you are either setting WHITE or setting custom.. so if a theme is applied that colors this, than it will always be white even if you aren't setting custom color

you need to disable color changing completely IF custom color isn't used


@swankjesse are you sure that this fixes the problem? The stack trace (using 3.1.1) is
`java.lang.NullPointerException: Attempt to get length of null array
                                                                         at okhttp3.internal.tls.RealTrustRootIndex.<init>(RealTrustRootIndex.java:31)
                                                                         at okhttp3.internal.Platform.trustRootIndex(Platform.java:97)
                                                                         at okhttp3.internal.Platform$Android.trustRootIndex(Platform.java:271)
                                                                         at okhttp3.OkHttpClient.<init>(OkHttpClient.java:189)
                                                                         at okhttp3.OkHttpClient.<init>(OkHttpClient.java:60)
                                                                         at okhttp3.OkHttpClient$Builder.build(OkHttpClient.java:718)`
Since the parameter `caCerts` is null.


Tu ta criando aquela ferramenta q cria CRUD automático conforme os campos q tu selecionou?


@kmarker1101 #19 looks good. Press ahead!


For this to work, you need to also patch lib/Server/ReadStream.js:
i = 5 instead of i = 4 in line 90 (case 'WRITE_MULTIPLE_REGISTERS')


I haven't been running OS on k8s as a pod myself, but aren't others controllers which we start in origin a concern as well?


```
return "" if post.nil?
post.split(";").first + ": "
```


Like this.


I'd argue for keeping this anyway, or else we will have to explain quats to every user that hasn't been exposed to them previously.


You are returning null from getAcceptedIssuers() in your TrustManager when
you should be returning an empty array.

On Wed, Feb 10, 2016 at 9:12 AM jbxberg <notifications@github.com> wrote:

> @swankjesse <https://github.com/swankjesse> are you sure that this fixes
> the problem? The stack trace (using 3.1.1) is
> java.lang.NullPointerException: Attempt to get length of null array
> at
> okhttp3.internal.tls.RealTrustRootIndex.<init>(RealTrustRootIndex.java:31)
> at okhttp3.internal.Platform.trustRootIndex(Platform.java:97)
> at okhttp3.internal.Platform$Android.trustRootIndex(Platform.java:271)
> at okhttp3.OkHttpClient.<init>(OkHttpClient.java:189)
> at okhttp3.OkHttpClient.<init>(OkHttpClient.java:60)
> at okhttp3.OkHttpClient$Builder.build(OkHttpClient.java:718)
> Since the parameter caCerts is null.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/square/okhttp/commit/784fabac7d1586a5614bd4bc8854fd62850dbe26#commitcomment-16006087>
> .
>


why?


My mistake actually, sorry for this.


If `getCloudFoundryRoot` is no longer used, it should be removed.


I believe there was 2 places where this test was removed, if my memory
still works.

In one of them, currentMl was necessarily >= MINMATCH > 0, so it would
always match the condition.

The second change was hastily done by imitation. And this is probably where
you see it as a mistake.

I'll correct it.

2016-02-10 15:11 GMT+01:00 Przemyslaw Skibinski <notifications@github.com>:

> You have removed if (currentMl > 0) { } which was required.
> if (currentMl == 0) there can be a problem with the opt parser.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Cyan4973/zstd/commit/2f94d2f166f1224a3e853ef927b2d31bacec59e2#commitcomment-16006049>
> .
>


This method is not necessary


Maybe you meant `relativeReference` instead of `relativeReference.getParent()` since, the way I read it, passing a possibly `null` parent would triger a NPE in [AbstractResourceReferenceEntityReferenceResolver#trySpaceSiblingFallback()](https://github.com/xwiki/xwiki-platform/blob/91972764d30af7a829b669d1ea6e0b6a47d195b7/xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/internal/resolver/AbstractResourceReferenceEntityReferenceResolver.java#L210)


I think need to replace `=` by `||=`


`baseurl` should only contain the path components, not the protocol and host.


Why use `defaultReferenceAttachmentReferenceResolver` instead of `currentAttachmentReferenceResolver`?


@Zteve I'm blowing up the client builder logic right now and I'll clean it up as part of that.


The compiler is unable to deduct the template argument type in these cases - it complains about missing template arguments. Using `<>` triggers the compiler to chose the default template argument, as defined in `<typedef T = double>` for every `vec{2,3,4}` struct declaration.


NANOSEC instead of hardcoding a constant?


Thanks! Good idea. I've cherry-picked your commit.


Since the classnames are already unique per folder, there is no need for additional counters. be able to deactivate.


"nonnull" in obj-c: I learned something new today :)


See discussion in #450. This got changed to a before_initialize block, so it works correctly.


turning this into a static inline will make it slightly more readable (fewer macros) and you don't have to deal with the CONSTCOND annotations.


I think this makes most sense here. generating the "clean" name includes to be a name which is not a reserved php keyword.


the trailing whitespace here is wrong and leads to an error when loading the library.


I guess this field should also be renamed.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1282.e70439ebeae4277edd3ac79dc7661613b37a8791](http://build.palaso.org/viewLog.html?buildId=69056&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 947, ignored: 12 Build time: 00:06:33


bra gjort !


This looks like something that could use a functional test. Running an INSTRUMENTED test that does:

```
log = logging.getLogger("custom")
log.info("strouble doubles")
```

And checking for "strouble doubles" in `$job-results-dir/custom.INFO` seems to be enough.


s/will/would/
s/reutrn/return/


CS


https://github.com/isotope/core/commit/a482bc2de78a78a1b4a886ba1695514f68224c20 ;-)


develop (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1529 of 1529 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I feel like the rationale for the constant 1sec should be by the definition of the constant or by the macro/static inline definition.  The code here shows no evidence of 1 second being used for anything. (Also, if this value ever changes, this comment is likely to be left not updated and wrong/confusing.)


`case None` is clearer.


There are an issue : need to CAST value, i do it in some minutes


Nice. If you add a check if `lsblk` is installed and a fallback to `df -h` I can merge it if you like.


That's awesome, Evan.  But the point is that people should be able to recognize you. Please take a normal picture.


If this decoding method works in this case (ie: You are able to write `null` when the tile is raw) why not use it in all cases? This seems much prefered to union of boolean and value approach.

Also it would be good to have a test case for this working with at least one cell type in `TileCodecSpec` as it is a funny thing we're doing here.


come on, you can do better that Date.now !


#include <stdlib.h>
#include <iostream>
#include <sstream>
#include <Windowsx.h> все не нужны


We might want to do a specific check for strings here, as the following behavior is probably not what people want:
```python
In [1]: tuple("hello")
Out[1]: ('h', 'e', 'l', 'l', 'o')
```


Thanks David.  Good luck with the job!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15243](https://teamcity.mesosphere.io/viewLog.html?buildId=131266&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:05:04


I don't know how but with this commit you've add some code which isn't logged/included in other commit. If I revert juce_SVGParser.cpp it works.
It is related to the clipping.


fixed #2


The problem is with two places, beacuse currentMl==0 is possible.

The idea was that even if currentMl==1 (or longer) you can search for backward match extension.


Please file an issue, this deserves a bit of thought.


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 153](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=776&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **SUCCESS**
Summary: Running Build time: 00:45:40


great !


@lexandro The build now passes in CI :)


this should be wrapped in a try catch and if we fail to import the module just all back to none gpio mode by setting self._gpio = None


I didn't look any deeper into it, but it seems that modifying ``mm`` causes ``test_field_interpolation`` failure.


Looks good


It's not needed, just add ```static``` keyword in the code:
```C
static void
_mate_panel_applet_prepare_css (GtkStyleContext *context)
```


This doesn't work, because it produces false positives when including the same file several times without the file including itself.


And the memory gains were marginal.


This one looks out of place compared to the rest of changes here :smile:
Maybe check isn't needed here?


There is quite a bit of state in this type that looks related and could likely be more appropriately structured/encapsulated.


Comme indiqué sur le forum testé Ok chez moi en MySQL 5.5 et en 5.7(.10).


> The problem is with two places, beacuse currentMl==0 is possible.

Not in the second place, since :
`currentMl = ZSTD_count_2segments(ip+MINMATCH, match+MINMATCH, iHighLimit, dictEnd, prefixStart)+ MINMATCH;`

Note the final `+ MINMATCH` which therefore guarantees that `currentMl  >= MINMATCH`.

This is normal, since it was previously checked that `MEM_read32(match) == MEM_read32(ip)`.

Are we talking about the same place in the code ?


Just a cosmetic comment ,If you put the "using std::ofstream" with the others your code will match a style.


Ok ca sera dans la prochaine stable alors (demain ou vendredi)


beauty is truth and truth is beauty 📠


2016-02-10    项目初建，待上传项目文件