Did you know we have a CSS class just for hiding those fields? :)

Stumbled across this while searching for a backend option, realized that the field was not actually hidden because the code above in `config_template.tpl` doesn't close the class attribute's ". Fixed in 400c66246211c583dfd1848ca3d6001e21528b7e.


rm 50


If you understand storage/cache as an extension of a provider, then this is fine. The same for the rest of ``get/set_storage_SOMESETTINGS``. If you understand provider as a wrapper above storage(s) and receiver(s), than it would make more sense to hide all storage/receiver specific options and set them from a configuration file (or config client) as a part of provider initialization.


Think about what the test is trying to achieve and compare it with the uses of the interface in the sos source code.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15055](https://teamcity.mesosphere.io/viewLog.html?buildId=129742&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:10


Thx


no spaces before `?` or `:`


nl ?


is there a reason why the ++ is before?


Ah, that explains a problem that has been dogging us for a while.  Good find!
Backporting would be good here.


I'm not sure i understand what you mean...


Finish


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15056](https://teamcity.mesosphere.io/viewLog.html?buildId=129743&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:23


@yash14123 Please add a "Fixes" before the link to the issue

`Fixes http://github.com/coala-analyzer/coala/issues/1317`

Nearly there !


no return or initialization ?


@wmvanvliet The dipole directions (orientations) get included in the discrete source space definition here.


@odises Thanks. It'll be fixed soon


This seems to be a duplicated test from `abort` for `destroy`, now that `destroy` is removed, the whole test is not needed anymore.


Finish creed.bot


why the new lines?


It is ok


Maybe `board/st_nucleo_f4.cfg` is better?


ok


For these lines with long options, I would keep the indent consistent, even if it means wrapping before the description.  For example:
```
  -o, --output-file FILE    write output to FILE,
                            default is basename(INPUT_FILE)-VERSION.FORMAT
  -s, --stdin               read input from stdin
  -l, --messages-file FILE  output messages to FILE (default: stderr)
  -F, --output-format FORMAT
                            specify output format (default: gtex)
  -f, --input-format FORMAT
                            specify input format (default: gabc)
  -p, --point-and-click     generate SyncTeX information
  -h, --help                print this help message
```


This is awesome! Just a heads up, the official name for this thing is NUCLEO-F429ZI, so `nucleo-f429zi` would be the example folder name.
See also
![](http://www.st.com/st-web-ui/static/active/en/fragment/product_related/line_information/line_level_diagram/ln1847_stm32_nucleo.jpg)


I don't really get this line. Can you explain a bit more why the `:not()` selector would be needed?


Как минимум, в таких местах нужен комментарий, почему так сделано.


But its not ;)


This actually outputs information needed to generate Lilypond point-and-click links in the PDF, not SyncTeX.


Ah, alright, it's because it tries to use transform feedbacks. It should be safe to comment that function out since I implemented that just to test the feature but they are not used by the engine. I believe the shader is vsTransformSkinned, weird it doesn't report the error to be there too. It seems in-shader offset specifications is a 4.4 feature.

Both issues are fixed in the current version.


Why break up `printf` this way?  Why not just concatenate the whole string together and put the parameters at the end?


Yeah it would be better! ;)


Any reason not to hide everything under Debug in a separate view?


`property('confType', 'sliders.@each.{size,unit,value}', 'constantSize', 'randomFromValue', 'randomFromUnit')` ну короче все проперти


It is actually possible to substitute GREGORIO_VERSION here.  Should we?


@enzy and will you fix that?


All Hail @robotia for the instant fixes!
Completely agree with @Cracks777


Почему не вынести @get('controller.model.configuration) в отдельную переменную?


We should either document or remove empty Javadocs, as doclint in JDK 8 is quite strict (http://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html).


It might be worth linking to [reprex](https://github.com/jennybc/reprex) here as a tool that can help displaying your reproducable example (and ensuring it is actually reproducable).


Not sure it's the right conflit you're trying to solve here : 409 are for "immediate conflicts" (trying to update a doc from a to older version ; but conflictHandler work on eventual conflict ( http://pouchdb.com/guides/conflicts.html )
But right, we have to handle immediate conflict in import code !


They do?! Wow!
Looked in Google, and yeah, very nice.
They also have a restaurant in a vintage aircraft.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15058](https://teamcity.mesosphere.io/viewLog.html?buildId=129745&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:32


Leuk!


Thanks, I thought it was master, maybe this info should be posted on the documentation?


I create a prism-mesh by using addTopLayer n times on a mesh that originally consists of x triangles. The resulting mesh consists of x triangles + n*x prisms. I need to remove the triangles as a postprocessing step such that the returned mesh consists only of prisms.


This depends on the native debug level already.

Sometimes I need to quickly see how many ICMP/UDP/TCP sessions there are, like with debugging the dynamic timeout calculation.

Try downloading with a torrent client and see what happens.
Formerly this resulted in 'too many files open', but now the dynamic timeout calculation closes unused socket faster when there are more sockets open.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15057](https://teamcity.mesosphere.io/viewLog.html?buildId=129744&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:01


зачем что-то умножать на 1?
если это такая конвертация в число то почему бы не завести в модели slider проперти которая всегда будет возвращать численно значение слайдера? здорово бы упростило код, не надо было бы parseInt и тд


just a copy/paste typo, i'll fix it.


Then WebApi supports Bearer tokens that are being sent from frontend. What error are you receiving exactly?


Nit: there is already a `clock.getUTCToday(DateTimeZone)` helper.


Can `Version` in these lines actually be properly substituted for with the appropriate version number?


beause of the string limit of C90


I *think* that I have had a successful rollover before, but I don't know.


Nu este necesar "-x"


It might be a good idea to suggest they search for issues (open or closed!) which are similar to their issue before opening a new one. GitHub defaults to searching only open issues so it is easy to miss closed ones.


and as far as @Robotia goes, Im sure that he dont care that you use any code from here. Why cant everyone get along, the point is to have a stable server that is getting the updates that it needs.


How did you decide on this font stack? Is that what .org or devhub use?


Должно быть в темплейте.


added unit tests to SetMessagesUpdateProcessor.applyState method to remove some confusion ... hopefully!


LGTM


nope... But we can discuss the changes


wouldn't there be a better way than hardcoding a duration?


wat


nl after super


Given @henryso's comment above (line164), it probably isn't necessary to pass `copyright` here either.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15059](https://teamcity.mesosphere.io/viewLog.html?buildId=129748&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:07:20


I added an `always_assert` (because reasons) and as a result things didn't link (because `always_assert` is defined in libjson).


this should be a separate commit...


I just checkout your appveyor job and it install `Installing https://luarocks.org/luacov-coveralls-0.1.1-1.src.rock` not scm version (I have no Idea why) and this version does not works with appveyor. Also seems you do not set token in env. (`token  : <NOT DETECTED>`)
Checkout my job https://ci.appveyor.com/project/moteus/lua-appveyor-example/build/job/ow7b7n3ag0esjeda


Added this at the stage of studying, when I do not fully understand the work of models. Removed.


Hhh


How peculiar. I made that change precisely because my iram was overflowing
and the link failing. From memory I even checked the mapfile afterwards.

I'm a bit snowed under with work at the moment, but do feel free to PR a
change to include the `:*.o` - that should be at least as valid as what's
there right now.

On 9 February 2016 at 21:28, Terry Ellison <notifications@github.com> wrote:

> This should read */libc.a:*.o(.text* .literal*). Without the :*.o, this
> fails to match the members of the libc library. See #1025
> <https://github.com/nodemcu/nodemcu-firmware/issues/1025>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nodemcu/nodemcu-firmware/commit/d5f71eb0c633a039cdd6b70dc93c44641b5b11ca#commitcomment-15974075>
> .
>


the height of the prism is the same as the length of each triangle leg. i.e. 2 prisms = 1 (isotropic) cube.


rm 34


PHPCS: Expected 1 space after closing parenthesis; found 9


PHPCS: Whitespace found at end of line


PHPCS: Line exceeds 120 characters; contains 125 characters


PHPCS: Expected 1 newline at end of file; 0 found


Shouldn't this be a dependency rather than a devDependency?


@enzy I will reset it... this is major breaking change - some projects are still rebaseable, but this will fuck everything up.


ack


xcxzc


Awesome ! :)


which suggestion?


Maybe use We instead of I and I feel like this should be at the end of this section rather than at the beginning.


No worries!


+1 for what @Wollus said...


It is done.


Yeah, I made a mistake. You'll want to fix these. Sorry!


Is `bc` not needed anymore?

I see it is still listed as a dependency elsewhere:
- scripts/install-deps-debian-sid.sh
- scripts/install-deps-fedora-22.sh


зачем поле administratorId если есть поле userId?


Your link in the commit message is wrong and as mentioned earlier - 2 commits


The thing is, if you tell the compiler to assume the condition is true, it may optimize out the check and panic, even in debug mode


@Luka967 Yes I put in you calcMergeTime


Not sure I follow, I meant hide Debug Level and Tech info in a separate `Debug` view.

Where do you see those sessions? Via ADB ?


Using reserve and push_back when creating arrays filled with particular values.


fixed


I'm pretty sure the build is failing because the environmental variables that are needed for the tests are not set in a pull request. I'm making some changes to Anthony's code and will push soon.


зачем это поле?


Nice solution! I did my bit


ok


зачем тут перенос строки? это же один селектор...


I am not going to add a separate activity for debug stuff. It will be gone in the stable release anyway.

The sessions are shown in the network speed graph, right bottom corner (for right to left scripts on the other side).


Why "several times" here and "twice" later?


очень сложный метод, и называется неправильно
по идее достаточно проверять что основание меньше чем число которое ты конвертируешь


To test if inheritance over JSON-defined objects was working. For instance,
I defined PhysicalObject in JSON and allowed the car to inherit from it.

2016-02-08 19:08 GMT-05:00 Arthur Valadares <notifications@github.com>:

> Why did you change CADIS to PhysicalObject here?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/iancarv/mobdat/commit/3b041ccce638fb777052981223ecc77903343565#commitcomment-15965827>
> .
>


maybe replace openerp.SUPERUSER_ID by self.uid if possible


Ce qui, il me semble peut s'écrire tout simplement $$ptp_partner_comm{$task_recv}{"recv"}[0]...


mergia e non rompere!


@Cracks777 maybe because it's my code? One week ago:
https://gitlab.prok.pw/KCauldron/KCauldron/commit/7114a28fc64dcfa8f29056fc8aa01b651cbfce5b


Never mind, I was confusing copyright with license.


Can you please give a better name for this variable? If I understood correctly, it can be `endpoints`


No, it does need to be passed here.  This is in a different file.


Эмбер позволяет в шаблоне задавать имя метода, который будет вызван при нажатии на кнопу. Нет необходимости вешать обработчик, тем более в таком странном месте.


такие вещи должны быть в application serializer, а все остальные от него наследоваться и не дублировать код


fixed


В целом — хорошо!


PHPCS: Expected 1 newline at end of file; 0 found


например этот сериалайзер не нужен, он не отличается от дефолтного, который сгенерирует эмбер


В названиях классво лучше не использовать &, лучше - -- __ _


Didn't realize that.  Good to know.  Thanks.


PHPCS: Line exceeds 120 characters; contains 125 characters


@sevoku: Do you want that larger res image here?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15060](https://teamcity.mesosphere.io/viewLog.html?buildId=129761&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:34


@vilchik-elena This method accepts a parameter implementing `Issue`. What if there is a another implementation of Issue? Maybe the `save` method should be in `Issue` itself.


Please note that all CSS modules will be merged into one giant CSS file (as will JS) , so when you add colors and so on to general tags make sure you want it on all pages in the project.  (This is to not create multiple http requests and therefore speed up page)

E.g the CSS file will have the same effect on all pages of the project so make sure you want that to happen.


почему `{ inverse: null }`?


maybe replace this with:
return self.content if content is None else '\n<!-- %s -->\n%s' % (self.name, content)


А что администратора никогда не нанимают и не увольняют?


sure. I fix it.


Не называй коммиты с @ - гитхаб воспринимает это как ссылку.
его стоило назвать "Add log.txt"
в если напортачила то используй git commit --amend
там исправляешь имя коммита (чтобы вводить надо назать <insert>) и нажимаешь <Esc> + ":wq" чтобы выйти из редактора


нужно задать класс, чтобы сделать отступ справа до следующего элемента


Something like:

```
#set ($isNestedSpacesHandled = "$!services.model.createDocumentReference('xwiki', ['A', 'B'], 'C')" == 'xwiki:A.B.C')

#if ($isNestedSpacesHandled)
  ... your work
#else
  #set($entryDoc = $services.model.createDocumentReference($doc.wiki, 'Forums___entryName__', 'WebHome'))
  ...
#end
```


Nice

On Tuesday, February 9, 2016, Jonathan Redpath <notifications@github.com>
wrote:

> They do?! Wow!
> Looked in Google, and yeah, very nice.
> They also have a restaurant in a vintage aircraft.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/FGMEMBERS-NONGPL/MD-88/commit/1b6e68770808b2c23c083cce8a1f1eb3203b813c#commitcomment-15977638>
> .
>


nit: "No pod can be assumed twice" ?


зачем это нужно?


s/before//


I copied and pasted this code from internet. I think this is an id of a tag wrapped the Carousel block.
Unfortunately, I could not find a sample of Product Slider using ui-bootstrap. I have to rewrite this code.


В остальном молодец со всем справилась :)


大文字にしてください


Let me test 1.5.2, I believe I was actually using that.  The bug I had to fix in the compiler was not the same one I've seen referenced on the Internet.  Sorry the details are fuzzy here, I can't fully remember what I did.


abort() is different for read streams and write streams, so IMO not redundant.

Thanks for the detailed review of the PR :)


Для стрелочек нужно сделать не просто картинку а список с классом для li, ul>li. Где количество li будет изменяться пока из-за макета


Can you write what do you mean by:
"if it missed all events due to network disconnection"
?


What happens if you paste all this into a terminal:

path=/usr/lib/arm-linux-gnueabihf/qt5/plugins/platforms/libqxcb.so
for i in {1..3}; do
  path="$(dirname "$path")"
done
echo "$path"

What about:

path=/usr/lib/arm-linux-gnueabihf/qt5/plugins/platforms/libqxcb.so
for i in $(seq 1 3); do
  path="$(dirname "$path")"
done
echo "$path"


@vilchik-elena This seems to indicate that this method is not yet deprecated.


Why is the `viewports` list passed a second time, although a non-const pointer is already provided to `init()`? Store the pointer, remove the argument.


i don't think this works with the signal/slot concept. i get crashes in mem_copy when i use unique_ptr.


it's TIME ?


@pynicolas Hardly understand what you want to say, but now i works another way: see https://github.com/SonarSource/sonar-javascript/blob/74bbd434060b9a67fdd2afad6494faf3395af066/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/JavaScriptSquidSensor.java#L247


スペースを追加してください。


I think the right header would be qopenglext.h, but we tested this fix on Jane's computer and it worked, so I kept this one.


sync.RWMutex should be removed since you are not using lock anymore


lgtm


nit: s/The/the/


@oblador yeah totally forgot that - not used to using a podspec. I guess now I have to bump it to 1.2.1 to fix the podspec issue so I can publish again. Care to send a PR? ;P


fixed


also do bash --version


@tvsonar is this case actually expected? if so, then you'll probably want to `return overriddenSymbol != null` above instead of hardcoding `return true;` if not, then shouldn't an exception be thrown here instead?

it seems strange to have the try pattern return `true` and yet set the out parameter to `null`


Yes that's good. But `NUM_MATCHES` will never be used, and can be removed. And there is no need to initialize the first value with `0` as we actually don't care about the values.


Тебе здесь понадобится смысловые классы social-btn и social-btn-vk например. Иначе как ты будешь задавать картикни/иконочный шрифт. Два класса потому что один для общих стилей, другой для свойств, которые отличаются


TeamCity Civic Assembly :: Build backend + frontend [Build 84](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=894&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


Hi! I took a look on your branch. I almost got it working.
https://ci.appveyor.com/project/ignacio/lua-appveyor-example/build/0.0.1.194-test

I just have an issue with paths. I have a file: C:/Users/appveyor/AppData/Roaming/luarocks/share/lua/5.2/foo.lua

which I need to map to src/lua/foo.lua


I'd suggest being a bit more explicit as to how to get rid of this warning message. Eg, `export OPENBLAS_NUM_THREADS=1`. I expect that many of the users likely to see this message are not going to be familiar with the wonderful-world-o-threading.


I personally use pip all the time to add on to these images. It's not difficult, just needs some doc.


Great feedback Virre!


is there a reason for the new line?


Running quick test's, looking good.


@h13ronim :point_up:


nl before return


I've used VERSION which is more suitable I think:

- `GREGORIO_VERSION` is `4.1.0-beta2-fix-891-d1bd78b-3222`
- `VERSION` is `4.1.0-beta2`


TeamCity Civic Assembly :: Build backend + frontend [Build 84](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=894&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **UNKNOWN**
Summary: Canceled (Exit code 137 (new); exit code 123 (new)) Build time: 00:01:14


насчёт меню, оно делается обычно ul>li>a. Сколько ссылок, столько и li. И третий должен быть пустым


Sorry - I don't understand it. Did you mean that we may potentially observe "Add" even before bind() finishes?


Hmm, at least remove duplicate names. Oh, and could you put the script into `tools`?


HTTP_CF_CONNECTING_IP tas i bruk for å støtte cloudflare skikkelig


Remove constructor, move default values to struct definition, i.e.,

    struct Options
    {
        descriptor_length = 128;
        ...
    }


"we need to combine the two as a whole" - which 2?


TeamCity Civic Assembly :: Build backend + frontend [Build 85](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=896&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


Better:
```
#set ($isNestedSpacesHandled = $services.model.serialize($services.model.createDocumentReference('wiki', ['A', 'B'], 'page'), 'default') == 'wiki:A.B.page')
```


What is the key that you are passing to as querystring?


final merge


woops :D my bad! thanks for catching this!


Don't forget to swap the periods for underscores.


убираем контейнер, у нас теперь есть wrapper


I'm not sure I understand. I only see that the value is the same as the binding property, is the same as the attribute value. But no bindings with the same name.


Here I can see the code


first one: /usr/lib/arm-linux-gnueabihf/qt5

second one: /usr/lib/arm-linux-gnueabihf/qt5

third one: GNU bash, version 4.3.30(1)-release (arm-unknown-linux-gnueabihf)


s/will confirms/confirms/


leaving comments on a commit


Safe initialisation of random positions for robots (positions take into account robot size wrt. environment borders)


PHPCS: Line exceeds 120 characters; contains 125 characters


comment on a line


test


An iterator of `sections.keys` ?


Please change buttons size to be calculated with getWidth function


@mathiasrw
1. exports - test for Node.js
2. importScripts - test for WebWorker (FileSave doesnot work in WebWorker,... IMHO, may be I was wrong)
3. (typeof document == 'object') - test for DOM (browser)


Может, ASSERT(false)? Проверили же уже


я не уверен что такой метод нужен в рауте


:( keine unnötigen zeilenumbrüche


Yes it should. I probably did an `ember install` instead of my usual `npm install --save`


May be we should keep 'contextMenuApp' as module name here?


why do you need _t?


right, I forgot about that


You forgot about [.luacov](https://github.com/moteus/lua-appveyor-example/blob/coveralls/test/.luacov#L17) file.
So it should do `correct path: c:\lua\x86\5.1.5\LuaRocks\systree/share/lua/5.1/foo.lua=>src/lua/foo.lua`
I make regexp like `...share[/\\]lua...` instead of `...share/lua...` just in case in futer LuaRocks change it bihavior.


@pynicolas Yes, it's not.. yet:) I wanted to force the idea that all issues finally should have precise issue location. See final interface (with docs!) https://github.com/SonarSource/sonar-javascript/blob/74bbd434060b9a67fdd2afad6494faf3395af066/javascript-frontend/src/main/java/org/sonar/plugins/javascript/api/JavaScriptCheck.java


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15061](https://teamcity.mesosphere.io/viewLog.html?buildId=129762&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:59


You are right. We can define:
```js
    var saveAs = undefined;
    if((typeof exports != 'object') && (typeof importScripts != 'function') && (typeof document == 'object')) {
```


which kind of bad detection ?


This seems wrong...


some tests (in openerp/addons/test_assetsbundle) should be added to this commit


What if the resources where updated?


This is not valid rst syntax. The underline-part has to be at least as long as the headline; http://docutils.sourceforge.net/docs/user/rst/quickref.html#section-structure


я бы на твоём месте отделила инпут от лейбла в данном случае. и сгруппировала бы каждую пару в див. Это стандартней, проще, легко управляемо.


rm 38


I'll investigate compiler flags for ARM, maybe tomorrow.  I don't know how [the x86(-64) linux nightlies] (http://prereleases.musescore.org/linux/nightly/) were compiled, maybe someone else can enlighten us.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15062](https://teamcity.mesosphere.io/viewLog.html?buildId=129778&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:56


зачем сооздавать новую конфигурацию в index route?


Use `lib.optionals` here. Because it's all coerced to strings in the end it doesn't throw an error, but:
```
lib.optional :: Bool -> a -> [a]
lib.optionals :: Bool -> [a] -> [a]
```
So you end up with `nativeBuildInputs = [ [ pkgconfig which ] ]`.


fixed


Odd.  I tested by doing the following.  Does it depend on puppet version, or have I got a bug somewhere?
```
alex@alex-VirtualBox:~$ cat test.pp
class test (
  $foo = 'foo',
  $bar = 'bar',
  $foobar = "${foo}${bar}"
)
{
  notice("### ${foobar} ###")
}

include test
alex@alex-VirtualBox:~$ bundle exec puppet apply test.pp
Notice: Scope(Class[Test]): ###  ###
Notice: Compiled catalog for alex-virtualbox in environment production in 0.05 seconds
Notice: Finished catalog run in 0.02 seconds
```


Generated an API Key from google developer Console.


From an "ops" perspective, it's a bit of a bummer that a warning like this won't be captured by the built-in logging mechanism.  I don't object to doing it this way but it's suggestive that the packing-origami needs reconsideration.  `log` has a dep on `base` in its table file but I'm unsure as to why.


When I'm at a computer again I'll confirm.


Я говорила, что футер и карта лежат в одном блоке, но не говорила, что карта лежит в футере. Ведь её нет на внутренней странице, как минимум. оэтому просто див, в котором лежит блок с картой и футер


Yes, it's intended. It may be not an intended use of client ID/secret, but I still want to give an easy way to try the library. I would still recommend to create your own cilent ID/secret for production usage, though.


почему он наследуется от index route?


TeamCity Civic Assembly :: Build backend + frontend [Build 85](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=896&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests failed: 148 (6 new), passed: 24, ignored: 4 Build time: 00:07:09
### Failed tests
```
Blog categories tests: Should delete blog category new blog category 1455026937578: <no details avaliable>

Venue tests: Venue type: Should Not Add an Venue if Cancel button pressed: <no details avaliable>

Venue tests: Venue type: Should Add an Venue: <no details avaliable>

Venue tests: Venue type: Should Not Edit a Venue: <no details avaliable>

Venue tests: Venue type: Should Not Delete a Venue: <no details avaliable>

Venue tests: Venue type: Should Delete an Venue: <no details avaliable>

Blog categories tests: Should not create new blog category if cancelled: <no details avaliable>

Blog categories tests: Should add new blog category: <no details avaliable>

Blog categories tests: Should not change blog category: <no details avaliable>

Blog categories tests: Should change blog category: <no details avaliable>

Blog categories tests: Should not delete blog category if cancel pressed: <no details avaliable>

##### there are 138 more failed tests, see build details
```


I thought I'd said not to do anything with the old tables as they were being re-written as new ui-tables ?


In my test setup, changing the `return null` (that in 3.1.1 leads to NPE here) to `return new X509Certificate[0]` results in `javax.net.ssl.SSLPeerUnverifiedException: Failed to find a cert that signed Certificate`


зачем?


so many duplicates :)


why the modal change ?


Looks good :smiley: The operation can be very expensive, but as long as we cache it, it's fine :+1:


Хардкодить названия тегов и классов в js почти всегда плохая идея.


I thought ed was happy how this was ? or at least didn't want to remove the schema stuff entirely ?


It is done on all html files.


Ehmmmmmmm, this is definitely wrong! java-json.jar is **definitely NOT** the reference implementation, which can be obtained via the given URL! It even isn't compatible to the API defined there!


color_accent
blue_dark
etc


Oh, `log` does use lsstimport...


Those keys should never go into the code. We have another code that we use for production instances. You can access it via `app.config['GOOGLE_CLIENT_ID']`.

I think it is better to write a `get_google_photo_url(google_id)` function in `helpers.py`.


Use something like https://github.com/nodejs/node/blob/master/tools/update-authors.sh and exclude the problematic ones ;)


removed them


against - I thought I said to leave all of the old tables ?


i will resize the gifs when i bring my computer with photoshop and stuff. Also i will remove the bg from the camp to camp logo.

I use two different gifs because the small one is barely visible on the page while loading, i needed a contrasting color.


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/tests/bearlib/__init__.py`, line 1.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/bearlib/__init__.py
+++ b/coalib/tests/bearlib/__init__.py
@@ -1 +0,0 @@
-
```


Because (I believe) `base` is needed to load any LSST python package that includes SWIG/C++.


why have you removed this function ? is it no longer needed


app folder contains three files (exclusive-client.js, exclusive-client.js.map, index.html).


раут должен возвращать модель, зачем тут все остальное?


> i will resize the gifs when i bring my computer with photoshop and stuff. Also i will remove the bg from the camp to camp logo.

OK, please open an issue then so that we don't forget to change the gifs


зачем сеттить ее в раут?


:heart: it!

But why did you name file as `normlize.spec.js` ? :) Let's just `normalize.js`.

And commit message `add basic tests for normalize`


Please guys...no arguing. And thank you very much @Prototik!


Looks like a typo. Don't worry, it's commented out.


Retard!


What about using Gimp? It should be available on your Ubuntu PC.


**Code Quality - Nitpick**

Right now, this is a dump :hankey: . It should be removed before submitting a PR.


@awead it only happens when the arkivo zotero integration gets run.


Yep, man!


Yep good catch !


Yes sir i will store the API Key in app.config and get the google url part from the helpers.py


I don't think `path` is used any more with `svgstring`.  I discovered this as I was modifying `editSVG`.  `editSVG` will still need a saved file in order to work.


Почему не бросаешь DbException
Например throw new DbException("Can't execute SQL = '" + USERS_SELECT_ALL + "'", e);


Здесь мы должно получить оба элемента одновременно, или мы просто заранее не уверены, какой из двух подойдет?
Почему не обойтись только общим классом?
```.find('.bsc-select select'))```


этот метод должен быть в контроллере или компоненте а не в рауте


ack


Well that's what you should get. I think I see the problem. I put the wrong shebang at the top. Should be #!/bin/bash instead of #!/bin/sh.

what if you past all this in the terminal:

locateLib() {
  local path="$(ldconfig -p | grep "$1" | awk '{print $4}')"
  [ "$path" ] || echo "$1 not found." >&2
  echo "$path"
}

locateQt() {
  local file="plugins/platforms/libqxcb.so"
  local core_path="$(dirname "$(locateLib "libQt5Core.so.5")")"
  while [ true ]; do
    path="$(ls "$core_path/../$file" 2>/dev/null)"
    [ "$path" ] && break
    # Some distros package Qt plugins in weird places...
    path="$(ls "$core_path/qt5/$file" 2>/dev/null)"
    [ "$path" ] && break
    path="$(find "$core_path" -name "$(basename "$file")" 2>/dev/null)" && break
    [ "$path" ] && break
    # Still not found... Look everywhere except places that might give false
    # positive. Probably best not enable this as as it might find the wrong Qt.
    # path="$(locate "$file" | grep -vEm1 "MuseScore|QtCreator")"
    # [ "$path" ] && break
    echo "$0: Couldn't find Qt." >&2
    return 1
  done
  for i in {1..3}; do
    path="$(dirname "$path")"
  done
  echo $path
}

locateQt

If that works I'll update the PR.


I'd rather want to avoid that...
We already get warnings if one of those 2 implementations (unix/windows) is missing one of the necessary functions, but we don't have to use virtual function calls for it.

So what would be the advantage of your approach?


See https://github.com/sovereign/sovereign/pull/446#issuecomment-181688795


вызывайте метод который будет выделять пункт меню непосредственно из самого фрагмента  примерно как то так
public void setItemDrawer(int itemLink) {
        NavigationView navigationView = (NavigationView) getActivity().findViewById(R.id.navigation_view);
        navigationView.getMenu().findItem(itemLink).setChecked(true);
    }


I don't understand this name. Maybe isOne?


whatever is specified in the config file will be added to app.config on server start.

see cleansweep/default_settings.py and config/development.cfg files.


that still doesn't exclude the ones that have possibly a different first name, and different email.  for example:

Rob Garrison <wowmotty@gmail.com>
aalvarado <adana@amcoonline.net>
Rob G <wowmotty@gmail.com>

@Mottie would be in there twice.

two solutions i can see that are more viable than trying to fix it:

1. Manually doing *this* part of removing duplicates.
2. Deal with it.


sửa lỗi sai format
#27


I did not intend to steal, I am just trying to keep this in line with KCauldron. I give @Prototik full permission to use anything I do in Thermos in KCauldron.


This is a comment on this line of text


Hmm, I'd say a add some logic to remove duplicate emails (keeping the last entry).


Zhao


Chris,
some more success..
using the python command:`python darc_prototype.py <filename>`,
I get a lot of:
syndrome not found
L2 CRC Fail
syndrome not found
l3      BMCh    DI      SCh     Mtype   RFA     BLK     DUP     FNO     US      LS
                False   0b001   0x0     0x0     False   0b10    8       False   0b1111111
SID     EXT     SID     EXTSID  RFA     CS      OFF     MSG
1:      False   52      0       False   False   0       1
2:      False   58      0       False   False   4       1
3:      False   64      0       False   False   7       1
4:      False   70      0       False   False   11      1
5:      False   0       0       False   False   0       0
6:      False   0       0       False   False   0       0
l4      LMCh    RI      CI      FL      EXT?    ADD     COM     CAF?    UDL
                0b00    0b10    0b11    False   52      False   False   125
and the attached layer5_output, but I guess, there should be much more data ?
Where do I need to tweak in the signal processing to improve the demodulation/decoding ?

How to find and correct the error in the gnuradio DARC_decoder block ?

Klaus


что такое currentModel и где оно сеттится?


first commit


i approve


I can cook up a node script if bash is too nasty for this endeavour :)


Exactly the oposite is true: If the compiler _optimize away_ the bound check, there is no possibility for it to panic.


what is a "node"?


Anyways, we can add this back later, if we need it.


[Node.js](https://github.com/nodejs/node) of course :)


good job!


почему бы всегда не передавать currentModel?


Force should be a 2D vector


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15063](https://teamcity.mesosphere.io/viewLog.html?buildId=129800&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:54


This does not mean for virtual function calls, it is all static calls if you use it as generic type. What I am thinking about is that it would be possible to do semantic restriction on the impl of allocators.


Thanks for adding your name!


I think this was meant to tie to #632, not 623


According to PEP 8, default initialization of method arguments mustn't have spaces between the variable and the value, as follows:

```python
def __init__(self, x=0, y=0):
```


done


:P  kidding, of course


я так понимаю этот метод можно вызывать как угодно и он что-нибудь вернет


Maybe, `value` would be a better name than `other`, since other is basically the opposite of self.


I know you said it will be removed. Tho it was an easy fix that allowed me to see the bookings in the table, and see if other things like updating a booking, adding one, works.


insane how fast it blew up


comment 2


если это Ember.Object то нужен get


Missing spaces between arguments: `Vector(35, 17)`


Can you please file as an issue? svglite has already been submitted to CRAN.


Missing spaces between arguments: `Vector(350, 170)`


+1

@jsdf Please resolve merge conflicts.


Missing spaces between arguments: `Vector(1, 2)`


Great! On second thoughts it's probably best I don't update the PR just yet, but if you change the shebang at the top of the file then locateQt will work for you.


sha


BBAdmin.Services is a dependency for all other related admin apps(services, events, etc). The way it was on models, that run was not triggered for every app that had BBAdmin as dependency, resulting in errors of Models being undefined.


I am currently fixing few other things, I'll send you a PR when finished.


Do you really need a commit for this? :P


Missing spaces between arguments: `Vector(-2, -4)` and `Vector(18, 36)`


Project name parser and generator of various strings from it is partially already implement in old modules [1] (it needs some refactoring and redesign to make it more reusable). I would suggest to move this code under self-standing class as most likely it will be used by others

[1] https://github.com/gofed/gofed/blob/master/modules/ImportPath.py


Missing spaces between arguments: `Vector(21, 38)`


Hi

Commit related to non static method called statically issues https://github.com/practiceprovider/openemr/commit/cc9a59f52a70e626d2e96b16ec5c1663df73f48a

I did not modified Zend modules here /interface/modules/zend_modules


функции с аргументами надо вызывать со скобками


Методах DAO слоя не должно быть логики. Это касается методов в классе UserDaoImpl со словом push в названии.


I switched to IntelliJ, but imported the eclipse settings. Is there a format file for IntelliJ?


Oh, by the way, the proper way to do this would likely be a [.mailmap](https://github.com/nodejs/node/blob/master/.mailmap) :)


It is not removed entirely. That default is not existant. The modifications just get rid of errors when modal is loaded, and correctly populate it initially with today date.


Should this say View All Messages?


According to PEP 8, default initialization of method arguments mustn't have spaces between the variable and the value, as follows:

```python
def __init__(self, mass, position=Vector(), speed=Vector(), acceleration=Vector(), damping=0):
```


is dit al merged met de master branch?


Do you need to provide working directory to the class users? IMHO, this is storage specific. Why would any user need to know?


建议暂时不要学`let`, 大多数浏览器还不支持。从最基本的ES5做起。


Johny, will do, but I'll sweep this into my GPIO PR.


Good Job


а он может быть больше 100?


Unfortunately this was cargo cult from a unicode plugin that I was told was correct, so I also am not sure the purpose.  I'll see if I can track down the original original author and find out.


It is not used at the moment. If will be needed when finishing with all the injection stuff via BBModel, I will re-add it.


Also see: https://www.kernel.org/pub/software/scm/git/docs/git-shortlog.html#_mapping_authors


What about to provide one method ``get_space_info`` and return a dictionary will total, free and used space? Usually when a I want to know free space I would like to know the total space and visa verse.


even that one has duplicates (the mailmap you just linked)


Can't wait for the finall pass :heart_eyes:


Done!


I've uploaded the site to my own host, but as you can see on line #32 reffers it to /hack... And that folder doesn't exist, so the hack isn't working at an site-based script...

Line #32: `<form method="post" action="/hack">`

Do you have te /hack folder? And if there are more, could you give me those files?

Thanks in advance,
MatSn0w


It's what in `AUTHORS` what counts :)


It would be helpful if you directly state where and how the hockey app key has to be added.


I'll wait until the next release. I tried to backport it to 5.3.4, but shellcode and auth_* have changed somewhat since that release.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15064](https://teamcity.mesosphere.io/viewLog.html?buildId=129809&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:54


Isn't it better to place the menu at the end of the file? I'm not really aware of the best practise in HTML code but I thought that the main content should come first so that they are loaded first? Especially for impaired users with special devices (not sure our site/app is really adapted to impaired users though). Or maybe some navigation tools are needed at the top of the page so that such devices may browse pages easily?
What do you think?


по идее available это computed property в модели конфигурации, все слайдеры могут ее обсервить, много лишнего


For "trying to keep in sync" uses merges, not separately commits which are regarded as stealing and license violation.

I don't need any permissions since I am not going to use this code in all its form.


@Luka967  i found a bug, if you are big and you spam space with your mouse in the middle, the cells will sometimes merge


Indentation is incorrect here.


modification du 09/02/16


extra space


missing space


все эти экшны должны быть в контроллере или компоненте


Indentation is incorrect.


sure, done in #56.


Do you really want to return binary data? For some use cases it is usefull. For some, I would rather get a location of a tarball from which I can retrieve it. I would not have ``TarballFilesystemStorage`` to specify output format of the tarball. I would rather rename it to ``TarballStorage`` and use decorator to decide the format? E.g. I would have two classes ``BinaryStorage`` and ``DirectoryStorage``. Anyone using ``TarballStorage`` would then decorate ``TarballStorage`` with the binary or directory storage. This way you can more reusable components.


@olandese, it absolutely should! We're working on better docs so this stuff is less of a black box to the world


建议现在`console`里写测试程序，通过后再写在文档里

```javascript
let arr = [3, 5, 7];
arr.foo = "hello";

for (let i in arr) {
   console.log(i); // logs "0", "1", "2", "foo"
}

for (let i of arr) {
   console.log(i); // logs "3", "5", "7" // 注意这里没有 hello
}
```

```javascript
var arr = [3, 5, 7];
arr.foo = "hello";

for (var i in arr) {
   console.log(i); // logs "0", "1", "2", "foo"
}

for (var i of arr) {
   console.log(i); // logs "3", "5", "7" // 注意这里没有 hello
}
```

![screen shot 2016-02-09 at 9 29 30 am](https://cloud.githubusercontent.com/assets/951921/12918903/af870b48-cf0f-11e5-9610-c622815ecc08.png)


ohhh, i see.. i didn't even consider what that mailmap did


@cgfrost Nouns on first line, verbs divided on each line below.  Please match existing style in other integration tests.


почему не deleteRecord?


Okej


may contain traces of traces ;)


"If this value is defined..."


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1279.9d4b6b1ecbdf498278b30bf29481ad798c47f3ee](http://build.palaso.org/viewLog.html?buildId=69018&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 947, ignored: 12 Build time: 00:06:00


Don't be too precise in the menu content. Your suggestion does not fit the wireframes at all. Which means we'll have to make a lot of changes here.


test time 8:03


I don't think eslint catches this but we generally prefer `var` to `let` in function scope.


Closing, this should be fixed now.  Sorry for not addressing this earlier, I missed it somehow


thanks @Philo  :+1:


I'm on to fixing it.


:confused: ?


You can then provider two objects of ``TarballStorage`` with different "base/low-level" storages with the same API based on the way you store your tarballs.


This lets the compiler choose which temporary register pair to use. I assume this is better than clobbering at random.


this file should not be modified by the developer.
Moreover, here the English is not correct.


The same here.


что такое viewRegistry и зачем он нужен? выглядит как костыль


It's unlikely that you mean that you want to have two `.after()`s in a row here.


Let's extract the threshold number to a constant.


Lägga till funktion klar


Looks like it's not available http://askubuntu.com/a/577334/350292 (Ubuntu, Raspian and Debian all share packages).
Perhaps that means it's not needed.


one last trace


разметка и css в коде это не ember-way


Hoo, di system.php style dan js masih ngarah di situ yak, kiraen sesuai dengan yg diclone. padahal mau ikutan nimbrung :dancer:


Here, you would decorate the ``TarballFilesystemsStorage`` (a.k.a. ``TarballStorage``) with ``BinaryStorage``.


I know this is not performance sensitive, but I found `iter @@ rev` is quite common, can we have `rev_iter` in list module like `rev_append`


Just figured that components/firefox/patches/14-thank-Martin.patch has a typo in Martin's last name.


@morcos, unconf prevheights can be equals to tip->nHeight + 1, however you are storing here tip->nHeight, imagine the following:

* You calculate LockPoint with one of the relative time locked unconf coin: maxInputHeight == tip == B1 with minTime = MTP(B1-1) + SequenceTime

* A Block B2 is found, but the coin was not mined.
* Since B1 is still in the chain, LockPoint is not invalidated.

However, it MUST be invalidated as minTime should be now MTP(B2-1) + SequenceTime, which is higher than the previous one.


Для чего понадобилась bootstrapTable. Какую задачу не получилось решить средствами фреймворка?


I think you can also drop `-e c:\lua`


split on two lines


You can keep Data::Matrix6x


第三十连接


Должно быть в CSS.


They are still used, albeit slightly differently. Note, there isn't likely to be any performance difference over adding a drrndq/dctfixq sequence in getmantandexpd32 and returning an integral type, as the compiler does "the right thing" here.

temp is also the conversion from the integer mantissa to float type used to do the 10^x multiply.


Do you have any reference to the fact that FFmpeg always outputs sRGB?
We're only using libavcodec, which seems to output raw data.

On the other hand libswscale seems to assume sRGB in order to rescale in a linearized space, to avoid artifacts described here: http://wayback.archive.org/web/20160112115812/http://www.4p8.com/eric.brasseur/gamma.html
In this case, having the *exact* curve is not very important, since the image is delinearized afterwards. Only interpolation is affected.

That's the only place I can find sRGB<->linear conversion in ffmpeg. Do you have any other evidence?


There should be probably only one _message_ string.


Wohooo, this is amazing! :+1:


Let's make it a decoration:
``def __init__(self, storage_obj = self)``


`@addNewBin` возвращает `@recheckAvailable()` а он `slides.forEach`, какой смысл в `if size != '' && @addNewBin(`


Если visible везде true, его нельзя опустить?


**The code does not comply to PEP8.**
*PEP8Bear, severity 1, section `autopep8`.* *Related to file `coalib/tests/bearlib/__init__.py`, line 1.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/bearlib/__init__.py
+++ b/coalib/tests/bearlib/__init__.py
@@ -1 +0,0 @@
-
```


Maybe `Dashboard on Jupyter Dashboard Server` just to give a bit more of a hint of where it's going?


sometimes i add spaces for readability when there are extra parenthesis


`-f` should work now you have the proper shebang <code>#!/bin/bash</code> at the top of the file. Don't do what I suggested before because I don't think it will work. Either `-f` will work or nothing will work.


I added .luacov file but it is not correcting the path. See:
https://ci.appveyor.com/project/ignacio/lua-appveyor-example/build/0.0.1.196-test


Also it's a bit unfortunate that the menu item will always appear even if the backend is not configured properly. We might want to improve the bundler API over in jupyter_cms to account for this.


Not addressing this for now - I will do this once all of the different parts of this tool are committed ie the Fixer, Logger, ErrorHandler etc


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15065](https://teamcity.mesosphere.io/viewLog.html?buildId=129813&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:08:49


Those described in the doc string, `NS_SEC_TION_KEY` can be detected as `sec_tion.key` or `sec.tion_key`. If you have a `sec_tion` section in defaults or config files, the good one is `sec_tion` so you should no detect it as `sec.tion_key` but you should detect `NS_SEC_KEY` as `sec.key`.


None of these tests seem to test that something has been completed.  If you look at other tests, most (all ?) of them are followed in the chain by something that lists the results and ensures that the original values exist in the current state of the server.


@carpodaster I did not add a test for the back_to_reality phase, because I could not think of a usefull test, ie a test that wouldn't basically test the :destroy method. Am I right?


Такую структуру будет очень сложно поддерживать. В таблицу может понадобиться добавить новые колонки, кнопку "Клонировать", чекбоксы для массовых операций со строками и  т.д. Здесь всё смешано в кучу: внешний вид, данные, действия.


You will find more context in the related issue:

https://github.com/bartavelle/hruby/issues/7


Ah, my intention with that was to not care about system installed rocks. I don't care about penlight's coverage, for instance. So I install all rocks system wide, but the one being "tested" I install with --local


Could you explain a bit more this ? I dont remember


This is for debugging, causes s-w-n page fault


Yeah I tried to transition width too but failed the same way :smile:


It is no need change ubyte to char, IMHO - ubyte size is equal char type

Here is PQexecParams const( char* )* wants a pointer.
Pointer to const array can be obtained just by array.ptr instruction and this pointer will have type const(ubyte)** without any casts.


Need to test both filter paths for `list()`.


i don remeber very well this issue. I think the setup function works fine now.
On my device, if i unisntall the game before installing it again the localstorage gets reset.


[exercice_activite (depart).zip](https://github.com/margou111/hello-world/files/123188/exercice_activite.depart.zip)


It is not every-day that I am cited along side Homer and Luke :smile_cat:


I don't think you could convince the closure compiler :P


This wasn't working because `copy` and `copyQt` are not built-in functions, they only exist inside the file and are not available to xargs unless you export them first. Now that `-f` works you can uncomment this.


Else: infinite loops.


Not -v2?


Можешь еще упростить и реализовать в классе DaoHelper методы initConn() и getConnection() и вызывать их в каждом методе класса UserDaoImpl.
Когда придет время это легко можно будет оптимизировать средствами фреймворка Spring


@Robotia changing to LinkedHashSet is useless as HashSetWrapper not holds any chunk updates, it only provides compatibility layer with mods. Recommend you changing back to regular HashSet as LinkedHashSet not extends HashSet and it can cause crashes.


In the other integration tests, we don't use `.after()` nearly as much as in this one.  This seems odd to me.  I'm guessing it's because you're not passing things like application ids and route ids through in order to verify them in following steps of the chain.  When you are doing that, I'm guessing that they go away.  That being said, if you do end up with a lot of these kinds of top-level `.after()`s you should definitely compare your code to existing integration tests and understand why...


the empty array is returned above


ack


если так уж хочется бутстрап-тейбл, почему бы не завернуть его в компонент а не работать с ним напрямую везде


why keep raw jar in a project?


Will this be the only configuration? In future, you could have soft/hard limit for storage garbage collector.
Does it make sense to dynamically change the limit? If not, let's move all configuration into ``__init__`` and use ConfigParser.


@ddavison damn you and your aliases, by the way :laughing:


Yep, thanks! I updated the PR.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15066](https://teamcity.mesosphere.io/viewLog.html?buildId=129833&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:13


### 膜膜膜


I answer here :)
1. you run test from root dir so luacov-coveralls can not find config file. You can add `-c test\.luacov` flag.
2. .`luacov` config already has filter to select only `foo.*`. But yes this variant also should work.


Feel free to include this when you submit the PR:
<pre>
CPUS      = $(shell grep -c ^processor /proc/cpuinfo)
</pre>
That will work fine on my system and yours.


@cbuescher good point


все должно быть через action'ы, не надо так делать


i had just fixed it.  :P  rejected from push.  that's ok -  i'll let you take it from here.


why do we need to have `$this->path` and `$this->realPath` both seems to be always the same


`getPathToRealFile` will resolve the original file name for versions. Thus `foo.txt.v.111` will return `foo.txt` which has the wrong version in the DB and thus the decryption will fail.


春节快乐呀～
事实上我发现几处memcpy，memset和strcat不能找到定义，加上cstring才可以。
对了，其实如果就是根据

    "../../lib/libsqleast-frontend.a(parser.cpp.o): In function sqleast::sqleast_parse()': /home/zhenzhong/downloads/SQLeast/src/frontend/parser.y:588: undefined reference tosqleast::ql::interp(node*)'

*
之前的编译错误，我并不能够自己修改出正确的CMakeLists，有什么好办法吗？谢谢


Такие вещи действительно надо передавать в метод? DEFAULTS не будут использованы автоматически?


Thanks, appreciated!


Why is there 2 spaces after `with`?


It is done.


We could go with selector like '.post, .comment', and it will work around both issues. It's fragile — of course, as any method based on internal knowledge — but it's much better than passing the things all around the components and reducers.
I'll change the selector and surroundings, but I think that's 'good enough' solution for now. I'm looking forward to feedback from other users to correct behaviour.


Hehe. Ironcially, there really are github profiles in those names. :astonished:


It is done


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15067](https://teamcity.mesosphere.io/viewLog.html?buildId=129837&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:36


All properly done in the Git Way™


@craveica Thanks for reporting!


I'm using `.after()` a lot because the operations API returns `Mono<Void>` most of the time. I didn't find it a very nice API to work with. `.after(...)` was the solution.


Happy lunar new year :smile:


Indeed, my mistake.


Nice. didn't know we could create tempDirs and do things like that in them !


I’m not sure this one would be seen as balanced by anything, at least by an ordinary reader.  But I like the effect.


Is there a reason these can't be removed entirely?


``exists`` instead? It is shorter :)


Please use Joi.compile() instead of Joi.object()

Reference: https://github.com/hapijs/joi/blob/master/API.md#compileschema


Not sure about the error, I'm unable to reproduce that.

As for the overarching issue, it looks like the legacy SPARQL backend is being run through the 'islandora_basic_collection_wrapper' theme, which is what generates all that fancy metadata, and the newer backends are being run through the 'islandora_objects_subset' theme that gets manually wrapped in metadata - but the metadata wrapper doesn't have any alters for collection objects that mimic how metadata is built for the legacy SPARQL backend.

I'm not sure what the best way to proceed with this would be.


I guess we should just put Joi.any().optional() here in regards to Joi.compile()


Should probably add a test case for:
```
expect(objectUtility.propertyNameToString(() => object.child.name)).to.equal('name');
```


but both variables, `realPath` and `path` are set to `foo.txt`

Maybe `realPath` should be:
````
$this->realPath = $path;
````

???


copy-paste typo


This is mostly because the API just returns `Mono<Void>` for most operations. I will add some additional checking `after` the operation is called.


модалка должна скрываться при переходе на раут а не наоборот


glad you made this more conservative, but 0.5 might be too conservative if one assumes some streamlining


Yeah, good candidate for "best code practises" to document for private methods.


But ... you used the `dir` argument in your last commit. This doesn't make logical sense.
Could you move this commit above 1a824fa ?


ahh didn't notice! i'll fix this!


Sounds good, I'll add that right now.


Fix documentation of ``neoyank#save_registers``

Use ``neoyank#save_registers`` instead of ``neoyank#registers`` as the latter has no effect.


that’s a beaut!


Looking at the previous code, we should probably use this function in a loop to find all links on a device. Then mark if any no link with the same address is found, then update.


`day` and `days` both work as units also (and mean the same thing). So could change this to
time = Variable('t', 5, 'days', 'flight time')


This can be countered by verifying "code <= (isize::MAX as u32)" or by using the [conv](http://docs.piston.rs/imageproc/conv/index.html) crate.


Good point. I am curious, because the World Server stores it as a regular java "Set". Would some mods retrieving this set still try to cast it down to hash set?

If that is the case, we could create a wrapper that casts to hash set but is linked!


The -custom one only because I did a quick fix in there, but it doesn't matter so much in this file to be honest, a console build will pull in the latest bower package which will have the right version.


This deadline is already set before and BTW causes a huge load since the deadline is always reached. So I propose to remove this deadline. I made some changes on this file in order to introduce an allocator. I changed the way of closing the connection, please check here https://github.com/safchain/skydive/commit/ed727873aeb51a33845f6f08b7629cd07243dde4

My patch is not ready to be merged but can be a start to fix this issue. I will rebase mine after we get this fixed.


When changing to `dotnet5.3`, you need to change this to `DOTNET5_3` as well :smile:


ack


This shows the problem with doing this.  See the line just above.


@Mottie you should be able to run it with `npm run authors` when bash and perl are available.


Sending an incorrect username or password is a perfectly valid action. Don't think we should throw an exception for this.

Also, try to not remove comments when refactoring :)


Maybe the difference is that this is the one of the first `-operations` integration tests, and since you're working with "name-based" arguments rather than ids, you don't need to chain the values through.  That being the case, I would still expect testing that what you requested to happen is what actually happened (using `list()` for example).


I think the description `'density of hydrogen at stp'` is inaccurate -- isn't this the density at altitude, not stp?

Same applies to `rho_he` description


Why 2 spaces after with ?


Why this one? We are checking for the config value in our Kconfig stuff.


Muss das wirklich sein? `onepage` ist wirklich nur als übler Hack fürs Korrekturlesen gedacht.


Are you sure it's entity_get_aliases ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15068](https://teamcity.mesosphere.io/viewLog.html?buildId=129858&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:09


Oh no that's a mistake, I thought I changed it! Thanks for spotting.


Can we make this configurable? I suggest a static like `uint32_t HTTPPlatformContext::maxRequests()`

Reason being is the Qt backend already implements such logic of throttling. With this I could remove some code, but I need to restrict it to the arbitrary number of simultaneous requests supported by Qt.


Sorry, how would you merge? I do not know how, I thought if you tried to do that the differences would conflict.


Can this overflow? ` i < (len - 5)`?


unack, I believe coala fails because your first line exceeds 50 chars


Awesome!  I had no idea that was a thing; I was planning on grabbing the image from the powerpoint, photoshopping transparency around the edge of the circle, then putting it on the page as a fixed element.  This should be a lot easier and cleaner.


Using a semicolon is no longer considered good English style; I recommend
changing them without comment.

On Mon, Feb 8, 2016 at 8:51 PM, Kasijjuf <notifications@github.com> wrote:

> The punctuation mark after the word inheritance should either be a
> semicolon or a period. If a period, then the following word "you" should be
> capitalized.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openenglishbible/Open-English-Bible/commit/605bda7b2e352f185c8180278994b6da9de30149#commitcomment-15969164>
> .
>


The grammar in the manpage for `get_pam_user` makes it barely readable (either that or I'm having a stroke). Is it saying that under some circumstances it'll ask the user what username it has? That seems wrong somehow. Is this really the right solution, as opposed to having say this PAM module *not* be the first one in the chain for xrdp/openvpn?


Great, however, this is one of those cases where, to my taste, the `else` is unnecessary keyword weight.


Don't think this separate constraint on `h` is needed -- captured below in station keeping requirement section


Injections are configurable here, user can add their own injections through the config object. And I prefer to inject modules with the injector server to keep things simple and to avoid some race conditions.

As for the InjectorClient logic, I think it's far enough to keep these logic in a single function, it makes our code base unnecessarily complex to have a isolated module for this.


Done


`observes` это почти всегда плохо
работать с разметкой напрямую тоже

этот метод делает слишком много всего


The deadline is to fix the previous patch, this didn't cause a huge load any more with this patch.
The SetDeadline() API need a timestamp in parameter, so  time.Now() + 1 second

But It need to be re set on each timeout, error as the parameter is a timestamp, not a duration.
Now the code working well, like a select with a 1 sec timeout


@Andrews54757 Well the point is to merge, so that clearly isn't a bug :1234:


observes + jquery


the exception will be caught in the calling method authenticate(), which will return a HTTP response of 401 UNAUTHORIZED


It is done


Well, it produces something catchable by the code listed in the README, but I haven't passed it on to an LRS to verif that it's acceptable. How should I be doing it? I've seen other code that generates some sort of template?


Well, the `EPERM` is recently my fault from 98eedfd3. I'm not sure if the problem existed before.


FYI quintel/merit#128 says that the *input* (charging) efficiency is 0.85 and the *output* (discharging) efficiency is 0.89.


You clearly do not understand. "/hack" is not a directory, it is an API endpoint created by [main.go](https://github.com/unixpickle/kahoot-hack/blob/master/site/main.go#L27). You must be able to run the server program (which is written in Go) on your server. If you use shared hosting, that will certainly not be an option.


This fix seems to work for 180 < distances < 360 . not sure about larger ones though...


Isn't group use a PHP 7 feature?


обычно этим занимается автопрефиксер


Hi,I have a problem in understanding the regular expression /(\w)\1{2,}/.I knew (\w){2,}means any char repeat at least twice but how "\1" works?


You don't need `stock` as an argument, it's not used in the function


My mistake there. This started out using the greeting card example from the h5p docs, and I later adapted it to extent Question. I've already removed this, but must have forgotten to push the latest bunch of fixes (and now I have some WIP stuff, so I'll wait until that's settled to push).


Hello,

Why this function has been deprecated ?
And what is the new way to configure the download behind an enterprise proxy please ?

Thanks,
Etienne.


Sure it is. You noted that __halt_compiler(); at the line end? ;-)


There is an err -- I call `this.setState('attached', err);`, line [494](https://github.com/ably/ably-js/commit/96e65dee0f0d01bce8035683b7b429822fdbd17b#diff-ee8e6cae22c16e2972f2b341a26d2ed0R494), with `new ErrorInfo('Channel detach timed out', 90000, 408);`


зачем class_variable


Overall I have to say these results make me really *really* **really** ***really*** want to start breaking before prepositions everywhere, and **it has nothing to do with balance**.  I get that feeling just by looking at the beginning of the declaration.  I wonder if what we really need is a guideline that allows us to pull it out in the `moveTo(x: …, y: …)` case.  I think that’s just as easy to justify in terms of balancing argument labels!


@Robotia learn `git merge`


If the text of these error messages is ever changed, do you volunteer to fix all of these?
While I agree with you that the way in which we are testing errors right now is not perfect, this is to me a worse solution, in the maintenance perspective. It is independent of other modules, but I do think that that is a secondary goal.
Most of all, I think we should all do it using the same method, and all change when a really better solution is found.


Lots of the old wind code has this weird spacing issue.  Edited this on github. Just added this one line.  Adn the commit reformatted the rest...


which sync.RWMutex you taking about ?

sync package is used by the WaitGroup to sync the exit of the cacheUpdater() and the exit of Start()


Very true


xml?


It is done for all files name


Care, values are on % of the axes
0.5 means at the middle of the scale ;)


эмбер умеет в кастомные id key, не нужно так делать


Need to be very careful with this - not all the toolchains we use support this.
I think better to keep this off & use the approach you are taking with openLayers of approximating a circle with a regular polygon. NB Yes we could suefully add a comment here to explain this.


Line 46


...

...

...

wow


So this is all unnecessary


Thank you I will figure this out and use it in the future  :smile:


good job!


Do you do this because pylint bugged you with "too many branches" ?


Code die aan de canvas "Signed by ..., topstarter in ..." toevoegd


:thumbs: ... Thanks for the note


We're going to parse emails returned from Mandrill so that we get the email address portion out properly when it returns
"First Last" <fn@example.org>


What do you mean? This feature is there because someone thought it would be useful, and I am fixing it because people reported that it was broken, so someone is at least trying to use it. Do you know otherwise?

> On Feb 9, 2016, at 6:54, ashercodeorg <notifications@github.com> wrote:
>
> Is there a reason these can't be removed entirely?
>
> —
> Reply to this email directly or view it on GitHub.
>


This is probably the the best way to generalise the copy-libs file:
- undo all your changes to the function getLinuxOnlyDependencies()
- rename it CentOS_6()
- create a new function Raspian_Jessie() and put what you need there
- inside the main() function, replace "getLinuxOnlyDependencies" with:

if [ "$(grep "CentOS release 6" /etc/*release*)" ]; then
  # Building on CentOS 6
  CentOS_6
elif [ "$(grep "Raspian Jessie" /etc/*release*)" ]; then
  # Building on Raspian Jessie
  Raspian_Jessie
else
  echo "${0}: Warning: Not running on a supported build system!" >&2
  # Try to fetch all dependencies, just in case
  CentOS_6
  Raspian_Jessie
fi

Note: I don't know if `grep "Raspian Jessie" /etc/*release*` will work so try running:

cat /etc/*release*

and look for something that you can use in the grep command.


Ah! Looks like I should use something like this? (from `multichoice.js`)

```
var xAPIEvent = self.createXAPIEventTemplate('answered');
      addQuestionToXAPI(xAPIEvent);
      addResponseToXAPI(xAPIEvent);
      self.trigger(xAPIEvent);
```

...and then write my own versions of add*ToXAPI?


Actually only the `else…bam_nameid` arm of this if-else-else is being changed here.  It'd be easier to review and verify changes if we could refrain from making unrelated formatting changes.  (Indeed, some people on the team find the original code more legible…)


ack


Close #79


Indeed it is a timeout, so sounds good. Sure I will rebase my patch on top of this.


It totally is. But this line is also supposed to be outright ignored. The rest of the file should look nice at newcomers ;-)


`configuration.update_attributes(params[:configuration])`
кроме того нужно проверять что возвращается и если сработала валидация нужно рендерить ошибку


removed the unnecessary codes.


Для чего нужен такой подробный селектор? Класс ```button-add``` используется для разнотипных элементов?


There are currently 3 tests:
* ReadStream destroy which was renamed abort: l467:`exports['Destroying a download stream']`
* WriteStream abort: l341:`exports['Aborting an upload']`
* WriteSream destroy which was copied from abort, and now is useless: l403:`exports['Destroy an upload']`


Habs grade revertet. Dachte halt, es wäre gut, die Texte auf einer Seite zu haben, weil teils schwer zu finden.


btw. the main reason is the inheritance of the websocket which would give an E_COMPILE_ERROR because of scalar types … if it weren't for that, I'd just have put proper `use`s here.


I'm not sure yet how signals will be handled by the documentation tool, but thanks for the docstring anyway :)


78 log equation


Condition not supported at ASH


What I'm concerned with is all this logic moved here (triggered by render()) produces an overhead.


removed the unnecessary codes


This is a recast of the previous test that serves only to put coverage at 100% — because the class is abstract, this is not really something we would need to test, otherwise.

Shouldn't we be testing that, when validation fails, the `_render` method isn't called? And the opposite?

"Properly" testing an abstract class might mean deriving a non-abstract subclass for the purposes of the test. A simpler, but possibly incomplete solution, is to spy on abstract methods, thus providing concrete behavior.


Could be replaced with `Site.objects.get_current(request)`.


Yes, that's great, but I agree it should be disabled by default. I remember trying to use this when I wrote the initial fork, but there was a problem with some major browser. I think either IE11 or Safari didn't support it, or maybe it was mobile Safari. In any case, great to have the support in there and we can test compatibility.


@gep13 build status md is copied from AppVeyor :wink:
![image](https://cloud.githubusercontent.com/assets/1647294/12920307/5d864992-cf48-11e5-9ed9-027fe99f6027.png)

Getting started should we fix [here](http://cakebuild.net/docs/tutorials/getting-started) to?


Ah good point I missed that, my PR changed considerably since I last checked.


Will require the appropriate context processor.


Scalar types do not produce any compile errors in older versions, they're just recognized as classes.


I still think we must be able to disable the cache. There are legit use cases like a read-only filesystem with low memory. You could keep the code logic if disabling the cache means creating a NullCache that would just trigger the callback.


增加team admin用户的读写权限。
对team的读写进行了控制。


Apologies for ambiguity, my "these" were referring to the console.log statements that you commented out (but left behind).


move under `spec/portal/portal_stubbing.rb`


:exclamation: @opochtovy если коллбэк вызовется в main потоке приложение задэдлочится. Вообще использовать dispatch_sync нужно только в крайних случаях для обеспечения синхронизации в потоко небезопасных объектах.


Yes but it merges without delay, (if you spam space with the mouse at the corner, this doesnt happen)


Then the question mark is inappropriate.


## Task 1

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly demonstrates the use of **chained conditionals** to accomplish a task (2 pt)

## Task 2

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly uses recursion to sum 0 to 1000 [inclusive] (2 pt)

## Task 3

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly uses recursion to compute `e` (2 pt)

## Task 4

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly accepts (and uses) the user input value for the maximum of the range over which to compute `e` using the `input()` function (2 pts)

## Task 5

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly accepts (and uses) the user input value for the maximum of the range over which to compute `e` using the "argparse" module (2 pts)


@devlead yes, I would say that should be changed as well, to me, that should be Title Case


в руби все методы должны называться в snake_case


113360729_HumidifierOASys (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Can you leave a link to the bug for further reference?


Yes, thanks.


Heads up - Travis is going to throw an error for including unit on a value of 0. Try: `padding: 20xp 0;`


e.g.
>>> from shapely.wkt import loads
>>> loads("CIRCULARSTRING(0 0, 1 1, 1 0)")
ERROR:shapely.geos:ParseException: Unknown type: 'CIRCULARSTRING'


Why are you looping on the reconnect? Wouldn't it be better to leave it telling users it is unsuccessful?
Even when the server has to go through all the ports before running the single timeout is still sufficient, so it might be better to extend that period to a single call instead of looping over reconnects.
And this is just the demo page, so if users click the launch button and the delay expires too quickly they can just click the 'Connect' button.

@cruzzan I don't like the idea of a setting in the api, since the `launchQZ` function is in the sample page. This means we expect developers to rewrite it to their needs, and then the setting becomes pointless. Perhaps putting a decrementing variable inside the reconnect function, if we keep this method.

And related: @tresf you define the reconnect function, but never make the initial call, so the code as is still wouldn't fix the issue of reconnecting after launch.


:exclamation: @opochtovy эти методы нужно вызывать лишь раз для таблицы. heightForRowAtIndexPath смысла имплементить с UITableViewAutomaticDimension нету


в рейлс должны быть валидации на поля а не сеттеры которые кидают ошибку


The paragraph below probably will require some additional caching to mitigate an overhead.


@kelunik correct. But due to namespaces when implementing the interface I get a class name mismatch and hence a fatal?


same here


Alright, then I think we're OK.


Ak mám menej ako 7 položiek, nedáva 2.stranu a sumár a zodpodpovedná osoba dáva na 1.stranu, ale má ísť na 2.stranu na spodok.


Good catch, fixed.


Thanks for your help in getting this enabled on more platforms!


Thank you very much! Bug with my map fixed.


Note that we are mostly using S3LocationSelectorWidget2 now so this is more importantly in s3.locationselector.widget2.js.

This code in here is intriguing...seems rather clever...was it copied from somewhere? If so good to credit that.
However I am concerned about the lack of support for CIRCULARSTRING() in the entirety of the toolchain, so think we should actually store as a polygon.
Good to have this function archived somewhere - perhaps leave it here commented-out with a comment saying that we can make use of it once CIRCULARSTRING() is fully supported


@carljbowman Thanks, looks like I forgot to save the file when I removed the unit. Committed again. :)


@flavour Yes shapely doesn't yet support CIRCULARSTRING, so I put the circularstring wkt in comments and POLYGON wkt in wkt field, is that okey?


когда ты пишешь `field :randomFromUnit, type: String` он создает сеттер который ты перекрываешь


@gep13 :+1:


とりあえず、 `vgs-bgm-decoder` は BASIC mode で使っているができれば ASYNC を使いたい


Installed 0.6.2-1 (debian), but AuthNames have not changed from "Demo zpub-Installation"


Missing a Returns tag here :)


This is confusing, what is "nincluded_content" supposed to mean ? And why does pylint say it's unused even though it is just below ?


это должен быть embeds_many


> Why are you looping on the reconnect? Wouldn't it be better to leave it telling users it is unsuccessful?

It does, unless the error function is overridden, then it can call whatever you want.

> @tresf you define the reconnect function, but never make the initial call

Have you tried it? :smile:


準備ってなにしたの？もっと詳細に書いてください


Actually Sigurd wrote it originally. It's copied from another place. Sorry, I don't know the internal logic well either, but believe the `if` ensures that the found variable has enough array indices to satisfy the given variable reference.


это решается accepts_nested_attributes


ok


I think this option is not correct:
> https://"+window.location.host+"/IDEAS/

You are supposing IDEAS is always deployed at /IDEAS. Nevertheless designer.governify.io is also a valid name for the same endpoint. Please, get context path dynamically.


use enum class.


`DefaultFileSource` should maybe take a cache object instead of a path, so we can still be flexible at different cache implementations. Specially now that the cache is no longer at the `OnlineFileSource` (which was a great move btw) we could have a `DefaultFileSource::setCache()` which is IMO even better.


если эти поля не должны сохраняться в базу они не должны отправляться на сервер


So let me get this right, you'd prefer unbalanced bracing instead? eg:

```
     if (strcmp(q, "=") == 0) c->mtid = c->tid;
    else if (strcmp(q, "*") == 0) c->mtid = -1;
    } else {
        c->mtid = bam_name2id(h, q);
        _parse_warn(c->mtid < 0, "urecognized mate reference name; treated as unmapped");
    }
```

Or maybe you want us to start using the comma operator?

Fact is, code layout is "cack" currently, but we don't have a style guide so I feel free to fix it when I'm editing a particular construct.  There are more important things to concern ourselves with than fighting over bracing rules surely?  Or... get the style guide written. :-)


good job here, just be careful with indentation. I think we're using 4 spaces here and if I remember correctly HTML should only be indented two spaces. It will make it cleaner when indented multiple levels.


Mostly @tomverran, appearing as me thanks to rebasing and squashing.


> @tresf you define the reconnect function, but never make the initial call

More specifically, what we do here is set a timeout to fire the startConnection() function, but in 1 second.   If it fails, we have a callback, which if not active, calls the startConnection() function, but in 1 second.  If it fails, we have a callback.... :)


After a talk with Michal, we decided to put in any info that is available. Tests included for all variants. See https://github.com/hrubi/zuul/commit/a068c8d04c0973373b4cc2460a509d5a4eab869d.


As a warning: This will fail in several cases when events() has more than one event. I can probably fix this, because dropping the EventIterator will drop the buffer of events, but for now it is better to do `for event in self.window.events()` and read it until there are no remaining events:

```
'events: loop {
    for event in self.window.events() {
        match event.to_option() {
            EventOption::Quit(_) => break 'events,
            _ => ()
        }
    }
}
````


This is the legacy case, so I don't think it applies to all array lookups. I could add what you suggest, but there are no acceptance tests that fail currently. Can you give a specific test case that needs to pass?


In SDL2, multiple events can be generated from a single SDL event, and in Redox, getting behind the event stream will cause multiple events to be given.


Re `element.innerText`: can you use element.textContent? It is much safer than innerHTML


ack


this is incorrect, you're supposed to return a 2-tuple


It's because Newry and Mourne don't appear in the local directgov csvs.  I suspect they never have because we don't have a LocalAuthority for them, which we would if they had once appeared.


Nice, now we just need it @ the bottom :dancer:


I would have thought we would stub the `@client.send` call instead.


`examples/sqrt.cco` with `/examples/sqrt_main.cco` finally works! \o/


No worries. I cannot tell you how many times I break Travis.


Alright. I just like this view better because it seems more representative of what is actually happening, and therefore might appear less restrictive.


в многострочных блоках нужно использовать `do ... end` вместо `{ ... }`


write_attribute пишет сразу в базу


Or `None`


I like that you're using media queries. This might work, I'm actually not sure. I've usually seen them used like so:
@media screen and (max-width: 700px) { } where it checks the screen size first, but again this might work fine.


I moved it to a reade file


Yeah... I think it is fine like that.


Nit: `items.map(createOrUpdateItem)` should work


@Nawuko : That's interesting. How much did you need to change in order to backport it successfully?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15069](https://teamcity.mesosphere.io/viewLog.html?buildId=129891&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:13


Can we remove the .idea files from this commit? There is no need for them in the repo.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15070](https://teamcity.mesosphere.io/viewLog.html?buildId=129892&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:16


Ah, okay.


I moved it to a readme file


I would change this title to Git-Branching


Thanks. No, I wasn't aware of that.


solve and solveset have their own test suites; the solveset test should be moved with to test_solveset.py


Yes and no. The problem is that you are not using the version of Flask-Login that I'm using. If you check the requirements.txt file, you will see what version you need to use. Flask-Login introduced breaking changes recently. If you switch to my version this code will run. I haven't managed to find the time to update the tutorial for the new Flask-Login, but I will at some point.


修改的toc和左边栏不是太满意，这个是reset --hard之后force push上来的


Nice!


Grepping the existing cack source code, there is no prohibition on unbalanced bracing.  Me, I would indeed prefer it.

As there is no written style guide, I would hope that we would all feel free to **leave the existing cack alone** where there is nothing gained by altering it.  Less noise in the history, etc, etc…


Nit: I'd tend to use the curly brackets form here


Git


Ah, it is not unused anymore. let me fix.

nincluded_content (n for new) is just a tmp allowing me to check whther the recursion changed the content or not.


Why `every`?
Need use `each` for correct work..


This is one of the key issues of this proposed feature: adding an empty section to a configuration file can change the overall behavior of the software.


Hola


This is of extreme importance. Can we please keep the old SQLiteCache around util we have feature parity?


Technically, there are no descriptions for tasks 2 through 5. Argparse absent from Task 5.


```
'[a-z\d]([a-z\d\-]*[a-z\d])?'
```


So, by default it uses the `root` python 3 environment with `conda`. If you want to switch environments, run `source activate python2` and then you can `pip install` into python 2 as needed.

Also, excited to hear about the community channel.


@Martin-Wegner
I  think I have found a good solution.

I added 2 tests to QuerySplitterTest ( noticed the existence of this test class).
 If you manage to find a failing case please tell me.

And Thanks a lot for the help


I was disturbed reading this :D

How about `area.items.clear().then(() => done())`?


Addressed several commits later - in 539fd79fc8a12145f25b37c7d597e862fc4743f2 (```rgw: ONLY formatting improvements for Keystone-related code. ```).


I moved it to a readme though. You still can refer back to the source as well as see the original documentation


You may need to create another mutex to local the PointLocator that's separate from the Threads class level mutex. You may be onto something though


## Task 1

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly demonstrates the use of **chained conditionals** to accomplish a task (2 pt)

## Task 2

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly uses recursion to sum 0 to 1000 [inclusive] (2 pt)

## Task 3

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly uses recursion to compute `e` (2 pt)

## Task 4

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly accepts (and uses) the user input value for the maximum of the range over which to compute `e` using the `input()` function (2 pts)

## Task 5

- [ ] Program is correctly formatted with shebang, description, code (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program correctly accepts (and uses) the user input value for the maximum of the range over which to compute `e` using the "argparse" module (2 pts)


testing commit


Need to hide something: `hidden`. Need to hide something only from visual browsers but not screenreaders: `visuallyhidden`.


@qadan   Thank You for taking the time to research this.   We really appreciate all that you do!


This looks better (putting common settings at the end). Mostly considering that common settings also has buffering settings included. Could you change it on the other output templates also?


I did. You _define_ a function to do all that. But you never call said function. So that initial delayed connect attempt never runs. Take a look at the browser console, "retrying connection..." is never printed and the connect not re-attempted. Unless you add a `reconnect();` call after the definition.

> It does, unless the error function is overridden, then it can call whatever you want

And you are overriding it, on the reconnect. Which I say we shouldn't.


words: "contributE to devtools as quickly and easily AS POSSIBLE"? or similar


Cool, I like that you're messing with font-awesome. I like how you fixed the indenting. Very important to having readable HTML


@craveica I'm pretty sure I see the issue. What version of Cassandra are you running?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1352](http://teamcity.monogame.net/viewLog.html?buildId=14693&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


This should be left as a string?


I can't merged because this line snuck his way in from your other PR #361 which I already merged :)


tested it and my assumption was correct, so i fixed it... Maybe this will also fix the smashbox test? @nickvergessen can you try to run them again? Thanks!


@bberenz it's called in the catch body, but called `errorHandler`


Sorry, I was mistaken


Put in a pull request


This is a giant stylesheet. There's no way you're using all this on that one site. And if you are it's probably overkill. If you're using someone else's stylesheet (i.e Bootstrap) use the minified version to make it load quicker. If you need to make any adjustments just override them in your own stylesheet.


Do you want to suggest somewhere that they at least think about the version of devtools itself? I.e. consider their bug may have already been fixed and try to replicate it w/ latest version before posting?


What will make use of this comment?
Just seems like bloat to me?


What was the original?


@Rushor Do you know if it applies to melee "spells" such as a warriors Mortal Strike? I was under the impression it was only white attacks.

It's interesting to note both OC and TC had this implementation in RollMeleeOutcomeAgainst, it looks like
```c++
    // always crit against a sitting target (except 0 crit chance)
    if (victim->GetTypeId() == TYPEID_PLAYER && crit_chance > 0 && !victim->IsStandState())
    {
        DEBUG_LOG ("RollMeleeOutcomeAgainst: CRIT (sitting victim)");
        return MELEE_HIT_CRIT;
    }
```
But both were being canceled out like I said in this commit. To add this to ranged attacks would require similar code in method _isSpellCrit_ under _case SPELL_DAMAGE_CLASS_RANGED:_


You said "Molecules are made of protons and newtons"


This should probably not be `invokeSync`. My understanding is it will ultimately access the file system.


test reply


> @bberenz it's called in the catch body, but called errorHandler

Just tested this... not working for me either... :cry:


> we don't have a style guide so I feel free to fix it

The point is, whether a particular style change is **fixing it** or **worsening it** is a matter of opinion.

As we haven't yet wasted time writing a style guide, to my mind the opinion that counts is the opinion expressed by the code in question.  The codebase is variously inconsistent and horrible in various directions…  e.g. I acquiesce to the horrible-to-my-eyes spaces in `if ( foo>bar )` when editing code where that is the nearby convention.


Do you have a policy on tests?


It's possible I changed this before I had updated Kconfig properly. Let me re-check then.


Amend this documentation - the function returns None if string is not convertable to integer


Fixed in 646b73837.


Убрал лишние отступы между пунктами меню


shorten this to merely:

return re.search(...)

usually any if statement that returns true on true and false on false can be shortened in this way


I have a feeling that the `readScan1dTrees` method is not at all designed to handle the `doProbScanOnly` case. It only reads plugin files.

If I want to make it work with the prob file I need to add a few lines to this method. Or am I missing something?


Sorry about that @msuchard - I ran all of the tests locally without issue so I was surprised when it failed on travis-ci.org. I had the environmental variables set locally based on some work that @schuemie shared with me.

I took a look on travis-ci.org just now and I see the environment variables under the settings for that project but I cannot see their values. I haven't worked with travis-ci too much so let me know if there is information I should review before doing any other pull requests.

Thanks!


Cool, I like the semantic elements. Most of the indentation seems right. I like that you're messing around with font-awesome


@luiges90  事件加是否选项讲解可否再发一次？


[R/iri.R:20:1:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L20) *style:* **Variable and function names should be all lowercase.**
```r
CalculateIRI <- function(profile, iri_coef, segment.length = 100) {
^~~~~~~~~~~~
```
[R/iri.R:23:1:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L23) *style:* **lines should not be more than 80 characters.**
```r
  K <- max(2, as.integer(.5 + .25 / DX) + 1)  # number of profile points used to compute mvg avg slope input (window)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/iri.R:31:5:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L31) *style:* **Commented code should be removed.**
```r
  # num_segments <- length(profile) / num_samples_per_segment
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/iri.R:32:1:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L32) *style:* **lines should not be more than 80 characters.**
```r
  profile_segments <- split(profile, ceiling(seq_along(profile) / num_samples_per_segment))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/iri.R:39:1:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L39) *style:* **lines should not be more than 80 characters.**
```r
    # sliding window of profil elevations for calculating mvg avg slope (buffer of length K)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/iri.R:52:5:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L52) *warning:* **local variable ‘iri_df’ assigned but may not be used**
```r
    iri_df <- data.frame()  # df for colleteing return values
    ^~~~~~
```
[R/iri.R:61:1:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L61) *style:* **lines should not be more than 80 characters.**
```r
      if (length(profile_segment) >= ix) { # if slope could be built within semgent
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/iri.R:61:42:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L61) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      if (length(profile_segment) >= ix) { # if slope could be built within semgent
                                         ^
```
[R/iri.R:63:1:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L63) *style:* **lines should not be more than 80 characters.**
```r
      } else if (length(profile_segments) >= next_segm_id && TRUE) { # if slope needs to be built with samples of next segment and there is a following segment
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/iri.R:63:68:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L63) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      } else if (length(profile_segments) >= next_segm_id && TRUE) { # if slope needs to be built with samples of next segment and there is a following segment
                                                                   ^
```
[R/iri.R:64:52:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L64) *style:* **Put spaces around all infix operators.**
```r
        y[K] <- profile_segments[[next_segm_id]][ix-num_samples_per_segment]
                                                  ~^~
```
[R/iri.R:65:1:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L65) *style:* **lines should not be more than 80 characters.**
```r
      } else { # if slope needs to be built with samples of next segment but there is no next segment or no following sample
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/iri.R:65:14:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L65) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
      } else { # if slope needs to be built with samples of next segment but there is no next segment or no following sample
             ^
```
[R/iri.R:80:12:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L80) *style:* **Put spaces around all infix operators.**
```r
        y[j-1] <- y[j]
          ~^~
```
[R/iri.R:88:32:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L88) *style:* **Commas should always have a space after.**
```r
          z[j] <- z[j] + ST[[j,jj]] * z_last[jj]
                               ^
```
[R/iri.R:91:26:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L91) *style:* **Put spaces around all infix operators.**
```r
      rs <- rs + abs(z[1]- z[3])
                        ~^
```
[R/iri.R:97:1:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/iri.R#L97) *style:* **lines should not be more than 80 characters.**
```r
    # determine avg rs by dividing by number of samples per segment and attach to result vector
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/rroad-package.R:30:1:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/rroad-package.R#L30) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/rroad-package.R:31:1:](https://github.com/vsimko/rroad/blob/60220ade5ba29b2e51465657cee06e879db954a7/R/rroad-package.R#L31) *style:* **Trailing blank lines are superfluous.**
```r

^
```


Stray whitespace fixed in 181ed88 (on `uw-master`).


113360729_HumidifierOASys (mjwitte) - x86_64-MacOS-10.9-clang: OK (2055 of 2055 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


"=" is missing?