cul?  culo? :stuck_out_tongue_closed_eyes:


Looks good to me! :shipit:


Spock also supports the `and:` label


As above.


Again, I think the naming could be clearer. Is this ``size()`` or ``capacity()``?


We check for libcrypto and libssl elsewhere in configure.in already


I'm not a fan of "pertaining to"...


We check for libz and libbz2 elsewhere in configure.in already


== 0


Спасибо, Дмитрий. Внес это изменение в ДЗ-6.


While I typically prefer the ordering in your change here, it is the only change in the file so reverting it will make the diff smaller and touch fewer files.


This fixes only one scenario, when we change the rate of an event already loaded and we do a seek using the timescale, but it doesn't fix the original bug: changing the playback rate is not saved in the a loaded.


I'd make the code shorter by merging some very similar functions. For example, getOwner, getVisibility, getPatientLastName could all be implemented as getPropertyValue(document, classReference, propertyName, defaultValue). Just my 2cents.


Should you just return here?


Bien hecho Joel, necesitamos determinar nuestra resolución con antelación.


This doesn't seem right. We have a glob() implementationi in src/port already. Should refactor gpfdist to use that instead


Полностью согласен. Поленился я здесь :( Исправлю.


113008903Provide-a-better-warning-message-for-a-triangular-window (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2112 of 2112 tests passed, 0 test warnings)

 * 6 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Do we want to keep this IPs in the repository?


done ;D


:trollface:


Need to add newline in the end of the file ^_^


Can we make these inline numerical constants into named constants or at least explain why they are relevant in some comments.  "3" and "4" appear to be importantly special but I can't tell why.


Why we can't just use timer as class member with some callback method? It seems like this class just duplicates timer interfaces.


You could simplify this a little with `presenter_class.constantize.new(content_item)`.


I would say both. I don't think we promise compatibility for this code, but not 100% sure.


@derekwaynecarr right, I've commented on on your original PR, this pattern is quite unexpected either here or in your PR as well.


Yeah fair enough. Not sure what works though.

"...emerging themes **on** the benefits of using GitHub..."?

Or just restructuring the sentence again. Just trying to make it less repetitive.


You already have another default constructor. What is the purpose of this one?


@ebrehault Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.testing/18//violations
```
plone/app/testing/cleanup.py:16:5: F401 'Products' imported but unused
plone/app/testing/layers.py:311:22: P002 found "hasattr", consider replacing it
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Я ещё не очень понимаю логику того где нужно множественное число, а где единственное


ок, понял


@thebigsmileXD btw, regarding your question PocketMine/PocketMine-MP#3918: I have recently become an outside collaborator of PocketMine-MP. Also I edited the comments there to make the conversation line look more useful.


Is this method used somewhere?


Done :+1:


я пробовал, и нашел, что тут нужно


а как тогда наращивать ?


Why shared pointer, but not just class member?


Your code don`t work on my PC. It dont see dll file , when I started deploy.


Good point. I will do.


cc @garbas @grwlf -- I get vastly better performance with this, especially for complex PDFs.


Are you sure this is needed? I would've thought that APR can include winsock2.h itself if it needs it..


Эм... ты дальше работаешь с отдельным символом. Так и назови это отдельным символом, а не символами, и уж точно не "вещами".


I may also just remove this debug logging, do we need it?


One thing to be careful about is that we don't introduce duplicates by using List instead of Set (I haven't looked at the usages to know if this is a valid concern).


Disagree? The default behavior of prepare() here isn't a coincidence. Also we want these test cases to be readable in isolation, and consumers of the info will want to know how many nodes we ran on


I will change.


I'm not sure what you have done here @jrgz, it doesn't give me the option to merge. It might be because your commit is on master. Could you make a new branch on your fork and submit that as a pull request?


Yes, when we log in as cassandra/cassandra, that is the default superuser.


> 2) If you need some help with maintaining the project, I don't mind helping

Awesome :) Glad to hear!

> While asking for donations may be one of the easiest ways to do so, I am not convinced that paying people works well in an open source environment. It seems that the problem is time, not money.. and converting one to the other is even in the best case icky and subjective.

Agreed completely. Donations won't cut it, even if we manage to gather a significant amount.

> In either case, it would be great if we can get some of the frequent/long-time contributors to be around to help with reviewing PRs and similar.

My suggestion would be to poke them with a mention and see if they join the discussion and offer their help. We could also look around among the most active _users_ of OpenTK - there are plenty of projects out there. Maybe some of them would be willing to join.

> BTW, there is a project called "MathParserTK" (totally unrelated) - it's also abandonware, but it works good & it's C# so it should be compatible. That could certainly be merged in. Maybe "TotalTK" b/c it will have so many features or "NewTK" or.....???

I don't think we should go and merge other projects into OpenTK. Neither SharpGL, nor MathParserTK, nor any other. Our first goal should be to revive and revitalize OpenTK as is. Even when putting my personal opinion on why not to merge any of these projects aside, we simply do not have a communication platform right now that would allow us to decide something like this.

> What spambots? http://www.opentk.com/forum is as quite as a ghost

Quiet might be. [But also buried in spam](http://www.opentk.com/forum/2).

> In the meantime, should I reserve the url and organisation opentkproject(.net) just in case, to make sure we got it if we need it?

I think we should wait until we've settled the naming issue.

As @cra0zy correctly pointed out, the name of OpenTK has unfortunately gathered some negative associations over the years and finding multiple "Is OpenTK dead?" posts when googling it does not help. I personally like the old name, but given our situation and the fact that we're working on a new maintenance staff with a new repository, we might as well use a new name. If we do that, our domain and organization names shouldn't link back to opentk.

Now, regarding a new name for the project, any ideas?


If policy table update is invalid we have to reject it and continue retry sequence. Seems like there is no logic for such cases.


113008903Provide-a-better-warning-message-for-a-triangular-window (lgu1234) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


what does fcdb stand for?


But as far as I can tell it doesn't address the issue of a variable being fixed vs. free, or does it?


Я говорил на лекции про то, что сначала надо собрать всё, что ты собираешься склеить в список, а потом сделать `join`.


Leave out all this commented-out stuff, it's just confusing.


It'd perhaps be nice if all '0/1' properties also accepted booleans.  It's not a big issue though, and I personally don't think I'd be able to find the time to alter all the types! :)


Class SlackMessage is missing a docblock.


SlackMessage::__construct is missing a docblock.


SlackMessage::getPayload is missing a docblock.


Class HipchatMessage is missing a docblock.


HipchatMessage::__construct is missing a docblock.


HipchatMessage::getPayload is missing a docblock.


Message::setMessage is missing a docblock.


Message::getMessage is missing a docblock.


Message::addField is missing a docblock.


I wonder if it would just be easier and more predictable for users to reduce maxNameLength from 255 to 250, that gives 4 characters and should cover up to 9,999 partitions. Is it feasible to have more than that? If so reducing to 249 give us up to 99,999 partitions which is a lot.


I see what you mean about this seeming a little odd but I think checks like this are a good idea.  Going forward, we should see if we can come up with an elegant way of doing these thread-check asserts (for some reason, I feel like there is some kind of static annotation cleverness, which could work, but that might be insanely ambitious and maybe we just need some set of flags, or something, attached to all our threads for checking who is running what).


Just a note that the `diesel migration generate` command currently requires the `--database-url` argument, which I believe was inadvertently introduced in my Sqlite support branch. It's rectified in the integration tests PR.


Of course, I realize that. This was just to show which exact line is
causing the trouble. I guess I should take it out of the PR if you are
going to merge it.
10 lut 2016 12:48 "Jeremy D. Miller" <notifications@github.com> napisał(a):

> Ugh, you shouldn't really do this with a static. We can do some kind of
> similar latch, but just not with the static.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/structuremap/structuremap/commit/0bb17a7cf82d77bb8968ee62fee95ad5a4e6d169#commitcomment-16002952>
> .
>


у меня почему-то вываливал ошибку


AddWarningWhenDElightAndShading (mjwitte) - x86_64-MacOS-10.9-clang: OK (2074 of 2074 tests passed, 0 test warnings)

 * 3 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


yes, we should ... I'm about to address this


@ijuma I can introduce validation for duplicates in the appropriate entry points.


Done and done! And I mean done.


It is considered good practice to declare callback methods as protected or private.


Nice


Was this line just removed in the previous commit?  It looks like something which shouldn't be changing across this entire PR.


I think you need to convert angle of attack to radians.


getOwner differs abit, but for getVisibility, getPatientLastName I can definitely optimize.


These are all constants and should be declared as private static final String NAME_OF_FIELD = "..."


This seems much neater than https://github.com/biemond/biemond-orawls/commit/bb13cc81c6eda8f56d001e69c6c6cc3cefd4e900

There's certainly less code, but it does mix the erb and python throughout the file (instead of the erb only being at the top)


Oh, right. Will do.


I think it works out for both because the diagonally scaled DST-I [here](https://github.com/MikaelSlevinsky/FastTransforms.jl/blob/master/src/clenshawcurtis.jl#L48) operates on a sliced array with two fewer entries. Could that be?


Мы же итерируемся, а значит перебираем символы, отсюда у меня и вылезло множественное число....=(


С какой стати двум строкам с одинаковыми значениями будут одинаковыми объектами, т.е. одинаковым куском памяти, если они создаются независимо?

Реализация CPython, действительно, пытаясь экономить память, переиспользует небольшие строки и маленькие целые числа, но это низкоуровневая деталь реализации интерпретатора. Стандарт языка такое поведение не гарантирует, поэтому ты не должен на него полагаться. Оператор идентичности используется тогда и только тогда, когда ты ожидаешь получить именно тот же объект, а не другой объект с таким же значением. В последнем случае используется оператор сравнения.


Спасибо за рекомендацию относительно serialize(), Дмитрий! :)


Have you changed description for returned result?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15264](https://teamcity.mesosphere.io/viewLog.html?buildId=131303&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:03


I'm still a couple of commits behind on the 2.1 branch, cause Arjen fixed something for Windows which broke Arcus for Ubuntu. Has that problem also been fixed now??


I'm not sure what you are up to, here, as this merge doesn't change anything.


Improve description. E.g. "Creating family documents for all patients with a pedigree and moving pedigree information to the family document".


In a couple places in the code I noticed it said skip people[0] because that's where the player is stored, and it makes sense for the player to be stored in the same list as all other people.


я вроде в следующем коммите добавил обнуление fragment.. как раз в renderReviews
reviewList.innerHTML = '';


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15265](https://teamcity.mesosphere.io/viewLog.html?buildId=131310&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:05:03


Ah, I parsed this as "create a user 'jackob', in such a way that 'jakob' is the default superuser". If you can disambiguate this easily, do so, otherwise, it's fine.


We can't pass `data:` to `sharedWorkspace`. I don't think it'd work, but if it worked, it'd be unsafe, since `data:` URLs can contain executables.

We should whitelist `mailto:`.

I'm not sure about `feed:`. Is it still supported? Can we trust it to be safe?


FYI:
With your formula of d^3+d-1, you can only update the table if depth < 7.

7^3+7-1 = 349

if abs(value) >= 324
we don't update the tables.
See movepick.h  Ln. 57


Seems, like you'll always miss 0 index.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15266](https://teamcity.mesosphere.io/viewLog.html?buildId=131313&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:46


Probably want an explanation of why this type exists and how it is used. It is simple enough but knowing what problem it solves would be useful and that is a somewhat complicated idea with nowhere more obvious to document it (unless you can think of it).


i don't agree because 'option.data' param can be empty, for example in a common GET request.


Hmm, so I thought both of these variables were default-free (which it does fix), but taper is default-fixed.


Yes, that's correct. Except that lucifer only has 3.6 TB, not 8.


I forget that the array method of accessing maps is available.


You can use the script in Fluorohydride/ygopro-pre-script if you like.
https://github.com/Fluorohydride/ygopro-pre-script/blob/master/scripts/ST16-JP/c100316099.lua


Done :+1:


No, I mean you can check the value of `wasInterrupted` and set the flag before line 157, but after the catch block.


Ditto.


Umm, magic 13 -> magic 80 is not a big win :grimacing:


It was replaced by 1.4


Let's leave it at least until others have the opportunity to test the migration during the code reviews.


@sgdc3 Good idea, thanks! Will do :)


Папку bower_components надо добавлять в .gitignore


We should be passing actual inventory lists instead of the string 'player' and 'trader' to cut down on globals (see count_item for example).


Да, но перебираем !ПО СИМВОЛУ!. "for character in string" буквально переводится как "для каждого символа в строке". "for things in string" переводится как "для вещей в строке" - и тут уже не понятно, для каждой из вещей или для каждого множества вещей. + задумывайся о том, к чему ты дальше уже в теле цикла будешь обращаться. Там ты уже явно будешь работать с чем-то в единственном числе.


Oh, this is fine.  For future consideration it's worth thinking about partials as method calls rather than *only* a way to share chunks of code.  To that end I'd put the conditionals inside the partial too: to keep all the logic in one place - think of them like guard clauses. I'd also pass the `@location_error` into it as part of the `locals:` it's better to be explicit about the required variables for a partial than it is to rely on instance variable as it means we can use them in a context where the exact same instance variable hasn't been constructed, but we do have a similar object that we'd like to use.


ack, still like it


I'm scrapping that. The player is now a separate entity ( outside of the list)  and the skipping of people[0] should be removed. I initially had them in the same list since they were very similar, but as development progresses it's making less and less sense to keep the player with everyone else. We'll just have to run the daily routines on the people and the player separately.


put the debug after fmgr include, because if t has a debug wierd things might happen
using macros is: fragile handle with care


Okay, so for default fixed variables the user would have to run `del m.substitutions[m["taper"].key]`. To make it easier, (pre model refactor) you can return that fixed value in a substitutions dictionary `return objective, constraints, {taper: 0.45}` and the user can do `structure = Structure(); del structure.substitutions[structure["taper"].key]`


Took over GJ's fixes.


Actually, the slicing accounts for almost all the remaining allocations. I thought they were OK because they don't re-allocate the underlying array's data (and can be passed to FFTW), but I don't know how much it affects the speed.


I have added comments on the file


Or use distinct where appropriate


develop (mjwitte) - x86_64-MacOS-10.9-clang: OK (1526 of 1526 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I don't know why but I always get a seg fault if I build this with Qt 5.2.0 MinGW 32bit and try to run it.


Yup, sounds good to me.


Mostly "do not pass a (useless) orientation when `hasOrientation` is not set".


Am experiencing https://stackoverflow.com/questions/35318952/dh-builddeb-pkgbinarymangler-dpkg-deb-build-debian-tmp-returned-exit-code Any idea what's wrong?


reverted


we'll fix this in the OO module


Ill be late, but ill be there!!


Yeah well, earlier I got 15 out of 15 for a test on how posh one's vocabulary was, so there!


The reason why the previous implementation was based on `entrySize` and not `pageSize` is because with `pageSize`, there is a risk of growing the database beyond the size limit if we are at the verge of reaching the eviction threshold and you add an entry > `5 * pageSize`.

This can have adverse consequences depending on the user expectations. Because the database never shrinks, I took a conservative approach there.

One way to fix this would be make sure that the max entry size is never greater than `N * pageSize` (probably 5 will be too low).


Ah, so raid1?


I guess you meant here PYTHON_MODULE_SUFFIX. Moreover this check is not really needed. If a variable is undefined it is simply Null. So ${PYTHON_MODULE_SUFFIX} == "".


**On the Boards**
1. Replace the Georgetown and Marlborough with the Florence and MSB that are in the drop box folder (on the boards)

**Portfolio**
1. Replace the Andrade Residence with Georgetown Bank, North Andover, MA. I added a folder called Georgetown Bank to the drop box with the Interior & exterior photos. I would like to have all of them on the website, except you can pick between Int 4 and Int 5 (im not sure which is better).
2. Dean Bank in Portfolio, could you add the photo attached, and eliminate the 2nd Interior rendering and replace it with the night rendering?
4. On the North Shore Bank, could you add the attached photos?


I believe we should differentient between these errors. Returning 500, `UNKNOWN error` is nut much helpful.

We should probably change following error return statement as well.


This line is commented but
graph.graph[(*vi)].degree
is used in the next line


i tried to rebase it out...must have hit the wrong commit.


Hi,

I think the problem is your codes at the checkWinner function. Your strategy is absolutely right, but you don't need to explicitly compare the values in the board to 'X' or 'O'. Instead, just compare to "player" which represents 'X' or 'O' depending what parameter the calling function (the startGame) puts into the called function (the checkWinner). Moreover, the operator OR  can only be used between two boolean values. In addition, the function should return False if all the winning positions are not matched.


If something has gone seriously wrong, why are we catching it and continuing on our merry way...?


Perhaps data: should still call [listener use].  (See https://en.wikipedia.org/wiki/Data_URI_scheme).
The RSS new reader Vienna uses feed:.

What’s dangerous other than file:?


The only thing I can think of offhand is that the `store` that you are using is in a different context. Could anything change the context between `createImage` and `uploadPlane` since in `uploadPlane`  you potentially get back a `store` based solely on `imageId` and not based on your context. If that's the case, perhaps something like: `rootCtx.lookup(RawPixelsStorePrx.class, imageId)` would work.


C join не работает =((


Hi Ronald,

there is an error while importing logging module with this patch.
TypeError: __init__() got an unexpected keyword argument 'deprecated_reason'.

Thanks
Naresh


Nice!


This is actually meant to use device tree overlays rather than pinmux helpers.


5/7 perfect


Also, `value` is only ever set to `talon1.get()`, so I'm not sure why we need all this setup.


i is the same as retry_sequence_index_, don't understand why do you need both
no array bounds check
why next is being added to something? as I understand you just have to get only certain value from array for each retry attempt


I'll merge and go back and complete these comments.


За то работает..


Thanks! I've pulled this in and it is available in 0.6.3.1 onwards (https://www.nuget.org/packages/Consul). There were also 3 fairly large updates/bugfixes that happened too: https://github.com/PlayFab/consuldotnet/blob/master/CHANGELOG.md


Can we call it `TalonGroup` instead? Or some other name that's less cumbersome?


Точно.. как то я проглядел.. сейчас поправлю.. спасибо


Значит ты его неправильно используешь.


change the names to your new names (with the C)


`@Then (the) user :username should receive an email containing :content` should do what you need where things in parenthesis are optional.


An easier fix (that I already pushed) is to just remove this default fixed business altogether. Both Lmax and taper are now just free variables.


For some reason I thought that `new_permissions` wasn't exactly what we wanted, but I went ahead and proved it. Change has been made.


It actually put the cloud in the center of the body but the `svg` isn't, so the cloud dosen't appear.


Does this mean you didn't start with the 0.5.x branch?


Нет, не работает.


Why aren't we calling `disable()` on each individual Talon here?


Initial commit for bash/collectHomework.sh.
You can use tree by entering sudo apt-get install tree in the terminal. Useful for quickly seeing changes while we are developing the file system.

Minor tweaks to bash/createDirectories.sh


This file seems extraneous.


Thanks misan... ) You are a genius...


How about Token framework?

get it?

o en Tk

I would really like if the new name was an anagram.


Do we need to check `talon3` as well?


Thnx for the fix mate.. had scratched my hair due to this error:P


You can take a look at https://launchpad.net/~thopiekar/+archive/ubuntu/cura-master/+packages
It only uses code from [master] branches. (Don't care about protobuf - the latest commits for it broke their java modules.)
As the packages were built 10mins before I guess it is still broken.


Thanks for explaination misan.. :)


I think commenting on the available versions is unnecessary. On the correct branch, I updated the package versions to the current versions.


@knime-mpicbg Function getLowerBound is used twice - needs to be changed


I think this should be done like fluidsynth is: an option of whether to link or dynamic load the lib.
The related define would go to  src/sound/oalload.h:4 and src/sound/oalsound.cpp at the point where '#elif !defined _WIN32' was.


Strange, this commit display only 1 member when i click on view all member


Then it would be three axis :). Use the makelangelo-firmware.

> On Feb 10, 2016, at 2:00 AM, 45su <notifications@github.com> wrote:
>
> Please include the code for servo motor in gcodecncdemo2axis
>
> —
> Reply to this email directly or view it on GitHub.
>


This won't work if called asynchronously. You need to create a new callback function that handles the results if a callback is provided.


I plan to merge and fix.


ConvBinFormate is deprecated


:+1: If we run into a model that really needs this flip-flop we should talk about a better interface. For default-free I think using the special `substitutions` kwarg works fine.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15267](https://teamcity.mesosphere.io/viewLog.html?buildId=131320&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:05:07


This will discard startIdx parameter, if it is 0 (which is OK if 0 is the default).


Naresh,

Are you working with stable/liberty or with master?


you need a function like this one public I think


@lucasbpolo sugestion is written wrong .. The correct is suggestion


Looks like grade-wrapper.properties has unresolved merge conflicts :)


Okey.

> lol... thanks for finding my mistakes

it's normal, haha


AddNetAreaColumnToEnvelopeSummary (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2090 of 2090 tests passed, 11 test warnings)

 * 549 tests had: AUD diffs.
 * 11 tests had: BND diffs.
 * 2 tests had: EIO diffs.
 * 2 tests had: ESO small diffs.
 * 8 tests had: MDD diffs.
 * 8 tests had: MTD diffs.
 * 8 tests had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


forget, it's an lucene problem, i rebuild and it's ok


Thanx for this! Makes me happy.


Works, thanks!


replace old print_mac function and mac_to_string function
closes #54 leading zero in MAC address
also increase speed and reduce memory size


Can you please clarify why you didn't use the file in homepageTemplate as your layout file?

I want to know which of these two options you needed:
1) A completely different/unique layout for *just* the home page, or
2) The same layout everywhere, but the home page displays the contents of a specific page


SDL has to wait for PTU only for one minute, than if no response new update should be triggered after <next_retry_timeout>, again wait for one minute and so on, but here it looks like you're waiting for response for <next_retry_timeout> instead.


Review by @nicolasstucki for pushing on scala-js/master


good


Is this a typo? Line 73 above includes the 't' in 'Microsoft', but it is omitted here. Is there a reason?


Ты понимаешь, что один символ никогда не будет равен трем?


В новом коммите работает


Here you turned Create(true) into CreatePrincipal.  In the next file you turned Create(false) also into CreatePrincipal.  Wasn't one of them supposed to be CreateUser?


seems like a lot of changes for one line. Do we really need the line numbers added to each string? (eg ``#: views/pages.py:701``)


Я не засчитаю это, пока не увижу `join`


I think the new OpenTK central should be distinctly recognized as a successor of the project.
Something akin to OpenTKReborn.com  for the domain name. The project could still have the same name as before, starting with version 1.1.5. or 1.2.0.
And in the future if Fiddler blesses the project it could be made so that OpenTK.com redirects to the new place.
Flowing the current topics into the new site, probably as an 'archive' section would also be a good thing.
While some of the topics are regarding bugs in the framework that were eventually fixed, there are a lot of newbie questions that keep recurring. It would be nice that people can search there, for problems that are both solved and unsolved. At most, we can remove the duplicate topics and the redundant ones.
Ideally the recurring questions could be moved to a huge FAQ bit by bit.


This should also perhaps be configurable. Some people might *want* the original behavior if their appcast is delivered over SSL.

Don't forget custom protocols which may be of use as well.


Нет, не работает.


You should add ben@maykinmedia.nl in https://github.com/settings/emails#new_user_email


You already initialize `hasNoHeaderPart_` to `false` with the `{}` in the .h file, so you don't need to do it here. You should also move the initialization of `headerPart_` and `sourcePart_` to the .h file.

Generally, if possibly prefer to initialize fields in the .h file, since then those default values can be reused for all constructors.


Maybe a good idea compare using `hash_equals()`.


yeah it's irritating to  be tagged everywhere :v

![shin_anim1](https://cloud.githubusercontent.com/assets/10176463/12955090/720ca53c-d047-11e5-9b97-26853916b19f.gif)


I thinks is a very simple check, but please move it to special cases.


actually browsing src/main/server/plugins/ shows no websocket*.jar :(


Thanks.

Hmmm, I do think it makes sense to have escape hatches to allow passing in query strings like that. Will think about how best to do that.


Hey!

First, great work! I have followed you from behind the scenes for a bit.

I was curious, why you made this change and the benefits for doing so. I am new to the N6 and 3.10 based kernels so I may be missing something.

Thanks for any assistance you can provide.

Kind Regards


Is there any reason you folks still recommend [rqrcode-rails3](https://rubygems.org/gems/rqrcode-rails3)? It appears to have been unmaintained since 2013 while [rqrcode](https://rubygems.org/gems/rqrcode) seems wildly more popular (and maintained as recently as 2016).

There's also nothing inherently Rails-specific about rqrcode-rails3, which is a bit weird. ¯\_(ツ)_/¯

Seems like it'd be better to recommend rqrcode.


They are just capturing the arguments below for the method call.  Part of the mockito API not sure if we need more commenting than that.  Plus its a test.


WTF? STALKER!


It is already fixed in a very next commit.


Info debug


AddNetAreaColumnToEnvelopeSummary (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


113008903Provide-a-better-warning-message-for-a-triangular-window (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (978 of 978 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-28.33%25-green.svg)


I think you should just squash the fix into this commit instead of merging this broken, with another commit to fix it.


AddNetAreaColumnToEnvelopeSummary (JasonGlazer) - Win64-Windows-7-VisualStudio-12: OK (2058 of 2058 tests passed, 11 test warnings)

 * 549 tests had: AUD diffs.
 * 11 tests had: BND diffs.
 * 2 tests had: EIO diffs.
 * 2 tests had: ESO small diffs.
 * 8 tests had: MDD diffs.
 * 8 tests had: MTD diffs.
 * 8 tests had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


FYI @oubiwann, I rebased on master and resolved the conflicts but this branch may very well not type check atm.


Use `mob.stopAnimation()` instead here.


sourceUrl doesn't exist anymore. What should i do now? @GuiltyDolphin @MrChrisW


PROBLEM ?

![tumblr_lth8l6pkvj1qgne3xo1_500](https://cloud.githubusercontent.com/assets/10176463/12955272/46891778-d048-11e5-9ca6-1d638b8dc95d.gif)


This puts the function declarations in namespace 'tb::tb' and results in compile errors (e.g., with g++ 5.3.1, using tb::TBID())


Why this logic ?
It will attract more questions and we again will have educational concerns.

I'd rather suggest this for those who are doing it for scheduler dynos, rather than push it for all.

80% of people dont need this and for those 20% we will recommend this manually. What say?


Again what?


Again, what's with these parenthesis? Is it necessary?


hmm, let's make this even a bit more explicit, call it `isTemplateImplementationSeparateFile'


Why? And why the style break?
And why `int==float` and not `float==int`?


Here too.


Hi Stephen,

Looks like it is fixed in Sugar 7.x.
Unfortunately Sugar 6.x has been in maintenance mode for a while and as such there is no plan for future releases that have general fixes.  Only security fixes will be incorporated in future release as needed.


Nice job @nicksavov !


This line needs to be removed.


maybe random.choice(items) is a better .... choice here


@tarunkapadia93 no idea. I picked it from @shahan-mik3 's kernel. You would be better off asking him.


this should be
```coffeescript
return if $page.find('.future').length
```
so it is only true, and we return, if `.future` is found


unused code should be removed


Something like that should probably depend on the used `-std` because we don't actually want to generate any integer instructions if we don't k now that they're supported.


@belucid I don't get why it adds a line. Will check again tomorrow.


why?


Noch fehler in der eintries.txt wahrscheinlich


something new need to added again


Some people might create rules on their own and the way Papertrail alert is setup if it's alerting for scheduler dynos also, they might do wrong things.

I don't think there is any education barrier here as long as the comments are clear. I am more worried about doing wrong things.


Boolean vars should be boolean named: is_ has_ ...


LGTM


funky spacing here, wont break code in this case, but whitespace matters in python


Aaron, I think something went wrong here. Let me know. This has 164 files changed, which seems unlikely.


Thank you! I'll upload this and "Slyhand Sorcerer" once I return home. Since 9-digit codes are normally used for anime cards, is it a problem if I use the 4-digit code instead of the 9-digit one?


If `SetKeys` was never called, this is a NullReferenceException.  While that will be a certain point of debuggability, an assert is a bit stronger.

Should we be asserting on bounds checks for buffer here? (Unless this is on a hot-path in debug builds, the answer is probably yes)


needs a quick fix before I can merge this


Coding style

```
{
    public:
        [...]
        [...]
```


Same assert comments as Sign


Should we assert the result must be false?


@getglad Our next release will be 6.2, at the end of February.


I think best place to put this is [_includes/head.html]() (swap mine out by all means!)


Keep it alphabethically ordered, not sure if Glyphs are on bottom always.


Weekly: https://scala-webapps.epfl.ch/jenkins/view/Scala.js/job/scalajs-weekly/82/


I've continued testing with this and the main tree, and it looks like we should only be wrapping req.Body in a rewinder if it's not nil, and only rewinding on lines 75 and 76 if we did.


FIxed.


If isSend, we're a client.  But shouldn't we already know that we're a client?  In fact, why do we need 4 fields, it seems like we're only ever the client or server, and thus we should only ever need one sign and one seal.


Fixed.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.685.df7ba248b6c8b8d058e14679ad4393b87874ff38](http://build.palaso.org/viewLog.html?buildId=69063&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3377, ignored: 124 Build time: 00:05:57


No problem. Great work on the project.


That's what this line does.


if isEncrypt we pass true.  If !isEncrypt we pass false.  Does that mean that what we're passing is... isEncrypt?

Combined with my previous "why do we have 4 fields", this seems like it gets a lot simpler.  (And trying to understand what the magic boolean means is no longer a problem)


Our study of the student perspective reveals several key benefits that students experience when they use GitHub as an educational tool.

or

Our study of the student perspective reveals several key themes that students benefit from when they use GitHub as an educational tool.


Awesome!


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.675.df7ba248b6c8b8d058e14679ad4393b87874ff38](http://build.palaso.org/viewLog.html?buildId=69062&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3337, ignored: 130 Build time: 00:07:09


nothing


First one is perfect :) Changing


Ok lets go with it


...use GitHub as a tool for managing the education process.


@qadan Would you like me to create a new issue from your description?


forget about the cursor down part...   it is not quite complete!


It would probably be better to split up these two examples into separate files.


What's the default value?
How does the webserver behave with `undefined` as IP?


How are multiple arguments supplied? (would be great!)


@manoj-btc - Please remove this file.


Woops :P Thanks for pointing that out


I used to think that `f` means function


@manoj-btc - Please remove this file


This should be in the .xinitrc.
This will attempt to run on whenever a new term is open.


en json is Japanese, is it all right?


These BBC lines were placeholders for a G4 module once one is developed to reduce the number of interface changes that will take place in the future. I'm not sure what this removal means---are we going to forgo a full BBC sim or is this just cleanup until one is introduced?


Changed, thanks @cpetrachenko. I think that's everything I have @alexeyza.


TeamCity libpalaso :: palaso-precise64-libpalaso-2.6 Continuous [Build 2.6.1041.df7ba248b6c8b8d058e14679ad4393b87874ff38](http://build.palaso.org/viewLog.html?buildId=69064&buildTypeId=PalasoPrecise64v26Cont) outcome was **SUCCESS**
Summary: Tests passed: 3377, ignored: 124 Build time: 00:05:07


hello epi


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1362](http://teamcity.monogame.net/viewLog.html?buildId=14733&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


I think that'd be appropriate here. It sounds like an improvement task - something that brings the metadata display when using 'islandora_objects_subset' more inline with the metadata display when using 'islandora_basic_collection_wrapper'


ER: playgrounds should display the bucket graph for `Dictionary`s


empd (nmerket) - x86_64-MacOS-10.9-clang: OK (2070 of 2074 tests passed, 0 test warnings)

 * 547 tests had: AUD diffs.
 * 4 tests had: EIO diffs.
 * 4 tests had: ESO big diffs.
 * 2 tests had: RDD diffs.
 * 4 tests had: Table big diffs.
 * 3 tests had: MTR big diffs.
 * 1 test had: SSZ big diffs.
 * 1 test had: ZSZ big diffs.
 * 2 tests had: ZSZ small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.81%25-yellow.svg)


hola estoy siguiendo tu video tengo problema en registrar usuarios me aparece Error: Extensión missing: openssl


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15268](https://teamcity.mesosphere.io/viewLog.html?buildId=131328&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:09:23


the sd2 version is different, this script was written already 5 years ago but on old TC (OC) standards.
the way it works is not far from standard, but there are some changes made in the core it self, on possess and on factions of thos chess items.

i think the mayor problem would be to rewrite the possess code and the way it works, the script AI it self is pretty forward.


Use Ctrl+F to find appropriate line and change it.

rlly? xD


Hmm. That does seem odd.

Sent from my iPhone

> On Feb 10, 2016, at 11:22 AM, SteveKoontz <notifications@github.com> wrote:
>
> Aaron, I think something went wrong here. Let me know. This has 164 files changed, which seems unlikely.
>
> —
> Reply to this email directly or view it on GitHub.
>


It seemed a little too specific / inflexible to me to really fit the API (we have to be very careful about adding anything to core types like `FlxObject`). Why single out the center case? What if you need a `setPositionUsingTopRightCorner()`?

flixel-ui for example has an [anchor API](https://github.com/HaxeFlixel/flixel-ui/blob/dev/flixel/addons/ui/Anchor.hx) that is much more flexible for positioning objects.


This is fixed in #149


Does swagger provide a way to document the Request and Response? Right now the API documentation is sparse.

For example, *terms* is very generic


Yes, now en json is Japanese. This will be translated by @hkurokawa tomorrow (today).


> This would fail quite loudly at the integration level if it were wrong – what risk would the test mitigate?

Thats true, although a unit test would do more to self-document whats going, given it's quite a terse few lines. Refactoring/moving it out to a helper would probably be good enough


@fingolfin would it be better to have a sorted list here or use `Collected` so the output will be independent on the order in which elements of the group will be enumerated?


AddNetAreaColumnToEnvelopeSummary (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (958 of 958 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.87%25-green.svg)


Understood :+1:


works during outdoor testing as well


:smiley:


I think it’s OK for us to use tools to generate code, but I think it’s critical that we minimize dependencies. In particular, if we use the auto generation to put vectors in the tree, that’s fine. If the build process invokes the auto-generator, this is bad.

It seems useful now, but I promise we’ll regret it.

Phil

> On Feb 10, 2016, at 8:12 AM, Amit Levy <notifications@github.com> wrote:
>
> This seems to work with both python2 and python3, but is it worth settling on one and specifying it explicitly in the shebang?
>
> For me, this always seems to be the bane of using python in build systems -- it somehow always assumes a version which happens to not be the default for me.
>
> —
> Reply to this email directly or view it on GitHub.
>


Ah, thanks.

A classic case of code that looks right but isn't.


You use IsNullOrWhiteSpace a lot.  If the domain value were " REDMOND" (leading space), would things break?  If we need to trim, but aren't, is there really a reason we'd use IsNullOrWhiteSpace over IsNullOrEmpty?

If we trim later, should we do it sooner?

If the library effectively auto-trims, this is probably ignorable.


This closes #112


nit:
```
noun := "row"
if len(allRows) > 1 {
  noun := "rows"
}
```


You should be able to contact me at *leadlag@users.noreply.github.com
<leadlag@users.noreply.github.com>*

On Tue, Feb 9, 2016 at 8:52 PM, Scott Rodgers <notifications@github.com>
wrote:

> Or how else can we share the file. I did include the single quotes and
> place id though
>
> On Feb 9, 2016 8:46 PM, "Scott Rodgers" <srodger@g.clemson.edu> wrote:
>
> > Would you mind sending me your email? I don't want to publish mine out to
> > the world
> > On Feb 7, 2016 3:14 AM, "leadlag" <notifications@github.com> wrote:
> >
> >> In the Keys.js file, did you retain the single quotations that surround
> >> the
> >> API keys, address, etc? Did you retain the place_id: prefix for the
> origin
> >> and destination for traffic? If so, it's likely some other formatting
> >> issue
> >> with your keys.js file. If you're still having problems, could you
> either
> >> send me your keys.js file, or a screenshot of it?
> >>
> >> On Sat, Feb 6, 2016 at 10:51 PM, Scott Rodgers <
> notifications@github.com>
> >> wrote:
> >>
> >> > I have tried to run the latest version of this code and am having
> issues
> >> > with 2 ajax calls (one going to weather.php and one going to
> >> traffic.php) I
> >> > was able to recreate successfully the call that should be going out to
> >> the
> >> > google directions api and had good results with the values in my
> Key.js
> >> > file. Any ideas?
> >> >
> >> > —
> >> > Reply to this email directly or view it on GitHub
> >> > <
> >>
> https://github.com/leadlag/MagicMirror/commit/9e4c9505196a27a113a17a6b4c5c5eafab91c14a#commitcomment-15936309
> >> >
> >> > .
> >> >
> >>
> >> —
> >> Reply to this email directly or view it on GitHub
> >> <
> https://github.com/leadlag/MagicMirror/commit/9e4c9505196a27a113a17a6b4c5c5eafab91c14a#commitcomment-15937490
> >
> >> .
> >>
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/leadlag/MagicMirror/commit/9e4c9505196a27a113a17a6b4c5c5eafab91c14a#commitcomment-15994740>
> .
>


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: js/console.js


@Halkreen Like in "first: go here",  it's used in notifications.


oh, whoops, I didn't mean to include those.  I'll remove them.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.676.337dbe7f4bb840e8af3c1b08cc61fd9618aee90f](http://build.palaso.org/viewLog.html?buildId=69065&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3426, ignored: 125 Build time: 00:06:25


:raised_hands:

@Tabjones


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.686.337dbe7f4bb840e8af3c1b08cc61fd9618aee90f](http://build.palaso.org/viewLog.html?buildId=69066&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3406, ignored: 106 Build time: 00:06:32


While Contains reads better, since you're testing for a one-character-long string it would be (marginally) more optimal to use IndexOf(char) and check for a non-negative result.  And you could also const the @ (my initial reaction for seeing it twice in two lines was "can you put that in a variable", then "well, a local const", then "hey, why not a local const char?")


This seems like a typo


Dang, you're starting to get into java


CircleCI isn't save the JAR from this build. I'll look into it further.


Вроде разобрался с join


These two exceptions could use a reason-string.


IsNtlm would be the correct casing for this.


IsNtlm


I moved composer out from my path, and tried to run the tests:

![](https://cldup.com/QoaSopsQQf.png)


113008903Provide-a-better-warning-message-for-a-triangular-window (lgu1234) - i386-Windows-7-VisualStudio-12: OK (2080 of 2080 tests passed, 0 test warnings)

 * 6 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yes, I can add in descriptions for each field.  Terms should also be defined as a string enum, with DAP/DDP as the only accepted values.  I have been trying to get swagger to allow me to set this as an optional field and default it to DAP, but no luck so far.  I think it only works on query params.

The Request and Response should be in there, in the Definitions block.  CalculateRequest and CalculateResponse.  I broke them down into component parts such as Country, which is used as the definition of source and destination objects in both the request and response.


Кроме мелких ошибок есть очень большой недочет, который ты не замечаешь. Он связан с логикой алгоритма.


wow lol


I think that kind of functionality would require extensive changes to the
iCal Parser and the current Calendar.js file. You'd have to make a new
function in the iCal parser that only pulls the first few events from a
calendar, and you'd have to set up the Calendar.js file to identify that
specific calendar and call the new function instead of the old function. It
would probably be easier to look into automating a calendar to only
populate events two weeks ahead.

On Tue, Feb 9, 2016 at 8:14 PM, Dominic Spatz <notifications@github.com>
wrote:

> Thats a good idea.
> As you said, everybody should do the customization on his own.
>
> I am really impressed by the traffic feature. I might implement this to my
> repository.
> (some features of my smartmirror/magicmirror:
> Configpage,Localization,notifications from my smart home)
>
> But i got a question, that you might answer:
> Do you think it could be possible to crop a certain calendar, showing only
> the next 2 events, or only a few days in advance.
> The reason is, that i don't want to see every entry of my waste calendar,
> provided by the city.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/leadlag/MagicMirror/commit/9e4c9505196a27a113a17a6b4c5c5eafab91c14a#commitcomment-15994261>
> .
>


That's not a copyright header!


do you have another reason for using key beside reacts reason.  It is required in react for rendering arrays but this does not appear to be that.


I'm not sure these comments help; and comments in sections like this have a tendency to get wiped out by tooling; and cause later editors to decide if it's worth the effort to undo the tooling change to preserve it.


Cool! my plan was to create a library or file or whatever to store such mac_to_char, mac_to_string functions also for other projects...


Missing license header


@Halkreen "go to date" is an option in agenda menu. On select, it shows a date picker.


This doesn't seem to be standard indentation


I think we have a different way to find 'slots'. Need to evaluate.


Sorry @Xaviju but this text should be in https://github.com/taigaio/taiga-contrib-subscriptions


@Halkreen Like in a todo list indeed


Why is there a single input parameter called "Request" which contains all the various parameters? That extra level of abstraction doesn't seem to provide any value.


I like this better in lodash


`evaluate("1 +2(2 - 1) + 5")` - как тебе такой случай?


It may be better to create a function that does this retrieval instead of having a lot of lines of similar code:
```python
def hpervisor_details(key):
     return results['hypervisor_details'].get(hypervisor_id, {}).get(key, None)
```


TeamCity libpalaso :: palaso-precise64-libpalaso-2.6 Continuous [Build 2.6.1042.337dbe7f4bb840e8af3c1b08cc61fd9618aee90f](http://build.palaso.org/viewLog.html?buildId=69067&buildTypeId=PalasoPrecise64v26Cont) outcome was **SUCCESS**
Summary: Tests passed: 3406, ignored: 106 Build time: 00:05:46


Might be worthwhile to consider how we can do this asynchronously for performance.


If outFlags just equals inFlags; why is the parameter there?


I'm wondering why I didn't have this defined before. Perhaps it was variable before and now it is fixed?


yes, this was to stop the warnings appearing in the console.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15269](https://teamcity.mesosphere.io/viewLog.html?buildId=131335&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 223 Build time: 00:04:03


const


Sorry D:


Hello - I find your script very useful and I was wondering if you know of a way to reset the totalsessionhigh count on the connection broker status via powershell. This would be helpful so I can report on the total daily usage.

Thanks


I'm not sure what that trailing comment means.  And trailing comments have a tendency to get messed up by mechanical refactoring.

Please move it to be a comment before the line(s) it's explaining; and perhaps make it more clear.  Are we not setting some sort particular flag because there's no NTLM support?


Perhaps a top-level `InGracefulShutdownException : Exception` and then `StorageInGracefulShutdownException : InGracefulShutdownException` ?


Essentially, the PMC governor is smartmax but tweaked with lower tuneables. In order for both governors to build (it will error out with duplicate definitions), you need to pull out the main coding for the governor, then call on it within the "tuneable" files. Make sense? This is actually an older governor (as is smartmax) and these changes were pulled from the source - Xmister : [https://github.com/Xmister/endeavoru-jb-crc-3.1.10/commits/master/drivers/cpufreq](url)


This is removeStackFromslot in 1.8. Use !mh in MCPbot whenever you need to find a new name.


Does this format conform with our other date-time inputs? ISO-8601?


If I set AcceptIntegrity and InitIntegrity, but not Confidentiality; should that be considered an error?  If so, is it an assert-error, or an exception-error?


License header


@qadan Created: https://jira.duraspace.org/browse/ISLANDORA-1609

Please edit for correctness.


You're casting a list to an entity
Also I think this is ITickable.update(). Not sure why youre calling entity methods here.


I think you built it up as you when before.
I'm not sure that it will always be iio:device0.  I'm afraid the last digit may change.


Indentation


Odd indentation


Seems like these all should have descriptions indicating what they are used for. For example, what is the date here? The date of transaction? The date I made the calc request?


@shahroozhphp


gfd


I'm just guessing on what to return here.


These can be reduced to pos2.equals(pos.up()), etc.


Not sure if this is going to be needed in the end, was needed to run a larger design through this.


Yeah but if min/max is set in a way that the "0" is in the middle of the chart? will the line draw there or still below the axis?


Used this early as an experiment to fail in runtime whenever a part select condition happened. Worth keeping around?


I *think* we should enumerate all the currency types we support, here, as the list is finite.


In case you're wondering about the name:
http://wiki.ecmascript.org/doku.php?id=harmony:egal

Also:
https://www.youtube.com/watch?v=xvcpy4WjZMs


If this sketch is meant to be an example, I think  the button checking would be better coded like:
```cpp
  switch (arduboy.getInput()) {
    case RIGHT_BUTTON:
      x = x + 1;
      break;

    case LEFT_BUTTON:
      x = x - 1();
      break;

    // etc. ...
```
Calling *pressed()* repeatedly is inefficient.

Also, there should be bounds checking on *x* and *y*
```cpp
  case RIGHT_BUTTON:
    if (x < (WIDTH - 1)) {
      x++;
    }
    break;
```


That URI was invalid, the others are wrong too.


I'm not sure what the comment's suggesting.  It feels like it would more belong at a place which skips over those bytes... not at the definition of the constant itself.

And, there's also the "trailing comments are sometimes not treated well by mechanical refactoring tools" paradigm problem.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1362](http://teamcity.monogame.net/viewLog.html?buildId=14733&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:19:49


Just found it funny :stuck_out_tongue:


I will have to undo this as this breaks the filesystem and inmemory switch in/out


Categories have been deprecated. It is now just called tags.


I'm not sure why we're adding a blank line here... but I'd kinda like to see a message in that PNSE, while we're here.


I know, it's a WIP! :)


$url может быть array и тогда конкатенация строк вызовет ошибку


лучше `public function setReturnUrl($url, $useAbsoluteUrl = false)`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15270](https://teamcity.mesosphere.io/viewLog.html?buildId=131337&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:58


Ideally, without documentation, it would be nice to have more descriptive input names. `terms` really is `incoterms` or something that lets me reason-about what the field should be.


избыточный, лишний.


Compiler is exerting it's will regarding _set_uid/_set_gid being private member variables.

    `if (g_ceph_context->get_set_uid() || g_ceph_context->get_set_gid())` instead?


@sparsuram Got it. I haven't used Sugar as a whole in a while so I wasn't sure what the status was other than it still wasn't in the 6.x.   Thanks for the quick feedback.


`other` being other shipping costs?


Please get these changes published (current reference guide publication date: 04/27/2015).  https://github.com/openSUSE/open-build-service/issues/1496 was due to missing documentation.

```DEBTRANSFORM-RELEASE``` will work (```debtransform``` will be run) only if there is any debian.* file.

(However I just discovered the undocumented tag ```OBS-DCH-RELEASE: 1``` which would do something when ```debtransform``` won't run...)


Corresponding dep/loadlib correction now merged:
https://github.com/mangos/mangosDeps/commit/50b6568ad25fb66f2d0646e0e1b0e2f046c329a2


This has an incorrect commit message.

I was entering GH Feedback not editing U5L1.


I think that it should be +libcurl (so that libcurl gets selected and installed, if it is not yet selected)


Bueno, el tamaño y un par de cosas más, hice copiar pegar desde mi práctica de ph1, es que el tamaño de las imágenes antes no estaba controlado.


pos.offset(EnumFacing)


hmmm


It'd be a bit more accurate to test that we get the right number on each platform, by splitting out `CHECK-native-32` and `CHECK-native-64` labels.


Perhaps squash this comit?


Oops, needa fix the commit authorship.


Would you terribly mind replacing those tabs here and elsewhere by spaces?


@shahbaz17 Find a new source ;)


i added it after i saw your email, since somehow I had forgotten.

On Wed, Feb 10, 2016 at 12:12 PM Maxim Solodovnik <notifications@github.com>
wrote:

> actually browsing src/main/server/plugins/ shows no websocket*.jar :(
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Red5/red5-server/commit/db31dff3380bed789f9f2ec0104bdcb6128972a4#commitcomment-16011355>
> .
>


also, landing goes to flying not through takeoff (must be that way so you can land on moving carriers) so an Activate is needed there.


Дмитрий, а папку .gitignore нужно создать самому? Если да, то куда ее поместить?


@shahroozhphp


maybe set this to debug only if environmentId is rather irrelevant to us


sure once it is a detector in G4 it'll go back. But we shouldn't put non
existing detectors or analysis macros into the G4Setup.

On 02/10/16 12:30, Michael P. McCumber wrote:
>
> These BBC lines were placeholders for a G4 module once one is
> developed to reduce the number of interface changes that will take
> place in the future. I'm not sure what this removal means---are we
> going to forgo a full BBC sim or is this just cleanup until one is
> introduced?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sPHENIX-Collaboration/macros/commit/a80191adfedd8ca1e74d166bb9817f88a058e419#commitcomment-16011872>.
>

--
*************************************************************

Christopher H. Pinkenburg	;    pinkenburg@bnl.gov
				;    http://www.phenix.bnl.gov/~pinkenbu

Brookhaven National Laboratory	;    phone: (631) 344-5692
Physics Department Bldg 510 C	;    fax:   (631) 344-3253
Upton, NY 11973-5000

*************************************************************


This change is not covered by the commit message, is it?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15271](https://teamcity.mesosphere.io/viewLog.html?buildId=131341&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:04:56


OK, sorry for the noise :)


So what is `factor` here for?
I do see that now it is unused


Yes we are going to be running on both platforms. We want to these these tests if not the automation on cross-plat.


These changes are not covered by the commit message, are they?


OK, thx


Thanks V! I got lucky :)


This looks fishy, isn't it missing a `)` ?


This can be simplified to just
Names.bindProperties(binder(), myBatisConfig);


nitpick: the return in a separate line, please? ;-) [ or just ignore me :) ]


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1288.b675be88f7bc97e94b194fc770c52e1c92137d01](http://build.palaso.org/viewLog.html?buildId=69068&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 961, ignored: 12 Build time: 00:06:09


mixing tabs and spaces... yay :/


Please, split this function to at least 3: read_from_socket, parse_input, parse_command


Please, split this function to at least 3: read_from_socket, parse_input, parse_command.


On Linux/Mac, we'd probably want to check that we've got errno 13 in e.osError.errorCode. Not sure what the behaviour is on Windows.


Instead of this toooo large regex use this package:
https://github.com/segmentio/is-email


This is a workaround for the following issue: https://github.com/Bouke/django-two-factor-auth/issues/102


Also you can use same module on backend. (https://github.com/segmentio/is-email)


I mean "sensitive" literally. If the flag is true, the header must be encoded as a never indexed field.


Yeah, I figured there might be a corner case. What's needed is a state transition table, this way lies madness.


Ah, fair enough.  Thanks for clarifying :)


This is unnecessary. If you need to append to buffer, just zero the first char: `*cmd = 0`.


I actually found out that this is not needed as vendor/omni sets it automatically in their sepolicy.


It seems like on lines starting on 586, we overwrite hypervisor_type even if we got a valid answer prior to this.
Shouldn't we check after 583-584 if we got good answers first?


Mark~


use IUserService or just UserService


Add javadoc


What if a command has no argument?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15273](https://teamcity.mesosphere.io/viewLog.html?buildId=131343&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:40


object ...rest is not es6. I thought you had decided not to use it. If we want to the we should probably all talk about it.


Hola de nuevo,
Con este cambio funciona hace que en muchas fotos vaya hacia atrás en lugar de hacia delante y se queda en un bucle.
Lo he solucionado "haciendo click en la flecha", de esta manera no he tenido ningún problema.
Para ello haz `INFOS['next2']='i-nav-next'` y en la función `getNextPicture()` haz primero
```
            next = self.driver.find_element_by_class_name(INFOS['next2'])
            try:
                self.driver.execute_script("document.getElementById('" + INFOS['next2'] + "').focus();")
            except:
                pass
            finally:
                next.click()
```

Espero que me entiendas.
Saludos
Alejandro Suarez


Those subsequent checks should be grouped into one validation function and instead of throwing alerts return message string from it. After you receive message string display it next to appropriate form field, do something like: http://www.quirksmode.org/dom/error.html


AddNetAreaColumnToEnvelopeSummary (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (2058 of 2058 tests passed, 11 test warnings)

 * 549 tests had: AUD diffs.
 * 11 tests had: BND diffs.
 * 2 tests had: EIO diffs.
 * 2 tests had: ESO small diffs.
 * 8 tests had: MDD diffs.
 * 8 tests had: MTD diffs.
 * 8 tests had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15272](https://teamcity.mesosphere.io/viewLog.html?buildId=131342&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 223 Build time: 00:04:46


Looks good, can you add a unit test of where this is currently failing and how the new code fixes it?


Question: Should we always have PropTypes for every small react object?  I don't have the answer, but we should decide.


this is ridiculous


hello hello hellooo


anyway, you probably want to revert this for now.


are you planning to complete this in another push?


It is to do the transform or backtransform. In one case it is -1 and the other 1.


Да, вижу проблему, как её обойти в рамках моего решения, я не представляю.....


Where do you think it is better to add such exception?


I should've noticed that. The list was created with the new Softlist option in clrmamepro Dir2Dat, I'll get the issue reported.


Eugh, missed this last time. We shouldn't hardcode treeherder.mozilla.org, we might run this code against staging (treeherder.allizom.org) or a development instance. Just change this to:

```js
$http.get(thServiceDomain + '/api/project/mozilla-inbound/performance/data/?job_id=' + job.id)
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15274](https://teamcity.mesosphere.io/viewLog.html?buildId=131344&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:05:00


hehe


This is going to need to go into a variable defined within the 'hw' modules to keep the old targets working.


I think you'll want to keep the userdata ext4 partition there.  The only problem with it is that it gives you a harmless warning that /data was already mounted with a different filesystem.
The problem with /system is that we've hardcoded ext4 in the kernel and in the updater.sh so f2fs doesn't work properly.

Hope you don't mind me commenting on some of these, if you do, let me know :)


Blocks/GracefulShutdown/exceptions.h

On Wednesday, February 10, 2016, Maxim Zhurovich <notifications@github.com>
wrote:

> Where do you think it is better to add such exception?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mzhurovich/Current/commit/e348c9a7c59438d8b61c3336287bc8025847b19b#commitcomment-16012859>
> .
>

--
And, as always, have a nice day!
Dima

http://dimakorolev.com/ | http://www.linkedin.com/in/dimakorolev |
dmitry.korolev@gmail.com | +1 (312) 593 2783


This also needs to be made into a variable defined in the 'hw' module.


I believe that the level was disabled on purpose on this edit form. To avoid people changing the type of the actor, is this correct @rschumann?


I'm not sure if this is useful to comment. The 'functions.js' file within this directory defines this module.


Not sûre we do that for minor releases, @tombentley?


Looks like a bit of stale copypasta here. :grinning:


@brevilo Their use of the MD5 happens in their validators, which is a little late in the pipeline for this particular issue.


Since this is a demonstration of how to install OutFLANK, `library(ggplot2)` should not be here


See #116


oh that could be, i didn't know.


please remove the comment `#Not shown on screen`


Я сказал, что твоего решения логика вывернута, и потому требует добавления кучи условий. Ты бы мог выстроить её от обратного. Тогда условий было бы меньше.


I know I had this before like this, but given that we have specific "type" related links let's use the more verbose syntax on the last element:

`actor_path(f.object.actor)`
instead of:
`f.ojbect.actor`

same for the other ones.


Hello Hannu (@hnyman),

you are right.

https://wiki.openwrt.org/doc/devel/packages#dependencytypes
explains the DEPENDS syntax:

```
+<foo> - Package will depend on package <foo> and will select it when selected.
<foo>  - Package will depend on package <foo> and will be invisible until <foo> is selected.
```

I have updated the patch https://github.com/openwrt/packages/pull/2368.

Best regards

Heinrich Schuchardt


No idea how this got committed but it will not let me delete.


After this line `start` can point to the end of the buffer. In this case the `for` loop at 137 line moves `start` out of the buffer.


When we cherry-pick this commit, we'll need to update the last option's key to "year-1516"


He cambiado a HTML5 y de momento lo he llamado tacoviajes hasta que decidamos el nombre, he cambiado la foto y los comentarios acordes a una página de viajes. Puede cambiarse en cualquier momento. La foto se llama igual que la que había antes, la pasaré por dropbox.


This was me, not sure why it's by "Unknown".


Makes sense! Thanks for taking the time to respond.


Added interactive mode screen, and error checked for possible strategies. Missing exit code for interactive mode when invalid input is given.


http://stackoverflow.com/questions/3437404/min-and-max-in-c

Please, write function instead.


Updated README


Why not name it `xdecompose_mesh_mpi` like the file name?


@nlacasse I am curious if it is possible to remove the timeout altogether for some of the tests here?

The external tutorial test is especially problematic since it installs `jiri` and Vanadium from scratch and has a highly variable time to completion depending on the resources available on a given test node.


Code review:
Ovde je izbrisano da se navode imena atributa prilikom pisanja u language_definition.tx, ne razumem zasto?


I think this would be a bit clearer written as:
```js
if (!_.isEmpty(response.data) && !job.job_type_name === "Build") {
  $scope.tabService.tabs.perfDetails.enabled = true;
  successTab = "perfDetails";
}
```


verison -> version


Нет ни малейшего представления о чём ты ....=(


There is no need for “python” in the `name` string. The `buildPythonPackage` will add it for you. Currenty, this package is named `python2.7-python-mpd2-0.5.5` (and similarly for other python versions).

Similarly, in the `sonata` package, you may want to use `namePrefix="";` to remove the `pythonXX-` prefix from the name of the package.


Please write tests for the changes, don't remove ioutils_test.go


Ah, looks good.  Instead of slicing, you can form a subarray with `sub(A, 2:length(A)-1)`.   This doesn't make a copy of the data, and FFTW can still operate on subarrays.

(In Julia 0.5, there is a good chance that slicing will produce subarray "views" by default, but this change hasn't happened yet.)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15275](https://teamcity.mesosphere.io/viewLog.html?buildId=131351&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:00:46


Modified it at 9d3529f


TeamCity ReOpenLDAP :: devel [Build 233](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=1814&buildTypeId=ReOpenLDAP_Devel&guest=1) is now running


There are a few other dependencies missing, I think. From my look through:
* decompose_mesh/module_mesh.f90
	* fault_scotch
* decompose_mesh/module_partition.f90
	* module_qsort
* decompose_mesh/program_decompose_mesh_mpi.f90
	* module_mesh
	* module_database
	* module_partition


Can we set it to an hour?  I don't want to get rid of the timeout entirely, since tests do sometimes completely hang.


Yes, i see the potential problem. I will fix it.
Thanks for the found.

Am Dienstag, 9. Februar 2016, 21:29:14 schrieb Tagir Valeev:
> origin = 1_000_000_000, end = 1_500_000_00 => integer overflow.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Blahord/BetterCollections/commit/b66af4dffd440cabbeed4075
> 785412a278726e51#commitcomment-15996626


I guess there is more matching up, but I don't have a decent XML validator
to go through it and -validate only checks the elements, not the file
itself.

On Wed, Feb 10, 2016 at 1:09 PM, Nigel Barnes <notifications@github.com>
wrote:

> I should've noticed that. The list was created with the new Softlist
> option in clrmamepro Dir2Dat, I'll get the issue reported.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mamedev/mame/commit/cd1d9b7a2b997350ff548741808356206630bca4#commitcomment-16012861>
> .
>


The Vector::at call here can fail (i.e. return false). This failure must be handled.


`l` looks like prefix, don't shorten word this way.


ur boi


boudary -> boundary


I left this out by accident after I moved it down at the lower area..
I'll remove these. Thanks


i did test them, they worked fine.

Thank you,
   Connor Haight, Central Magnet Student

On Wed, Feb 10, 2016 at 2:09 PM, Allan Burleson <notifications@github.com>
wrote:

> I like your username idea, but I also want to have multiple files so
> someone can back them up individually by username.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/V1Soft/textbasedgame/commit/d8556b6bc07a289d186e8f379d24b148f4cb8a3b#commitcomment-16005997>
> .
>


adjancy -> adjacency


This comparison is incorrect as it compares Tervel status bits as well as the actual data. This can create false negatives when the data is the same but the Tervel status bits are set differently.


upt -> up


I think we would need to keep the query parameter here and pass in the converted IP, i.e. `createip=$` in the query and `inet_pton($ip)` on the next line. Otherwise it's going to mess up the query if there are special characters.


Is this correct?
https://github.com/revant/drop_ship/commit/b9ad5178e4f75a73be9f7b36a1b3d691c8937746


so pretty :+1:


Sledece sto me interesuje je sto su promenjeni nazivi tako da gube semantiku u languageInterpreter.py ?
Sto se tice prethodnog komentara, sad vidim https://github.com/MilicaVulic/JSDGenerator/commit/5c2b47e3c6b4de71f5f93473a96be496fadb555b


This retrieval via Vector::at can fail (i.e. return false). This failure case must be handled else data is set to an unknown value.


Это не папка, это файл. В нем перечисляются файлы и папки, которые не должны попасть в репозиторий. Кладется в корень


Indeed - good catch! :grin: Will fix.


Я просил о другом тесте:
- есть ответ (вопрос) с прикрепленным файлом (создаем его с помощью фабрики, например);
- заходим на страницу вопроса, редактируем ответ, удаляем файл из формы;
- сохраняем и проверяем, что файла больше нет.

Сейчас ты проверил, что "Remove file" работает для еще не сохраненного файла, а будет ли работать после того, как вопрос/ответ уже сохранили?


pushed fix for this (and a half dozen other little things).


Write function that adds O_NONBLOCK flag to a file descriptor and use it here and above.


Hello Brady,

You're welcome.

Regards,

epsdky.


This message seems wrong 'Access Key or cannot be empty'


Is there a reason why Value has to be read-only? This makes dynamic charts very inconvenient - you have to create a new PieSlice object for every value change. Please make it r/w if possible.


You can manipulate a shared_ptr<> object the same way you use raw pointers. This call to shared_ptr<>::get is unnecessary.


You are right! Fixed!


@jdamerow  QUAD-80 : Changes made as per the review comments


heh, nah not really, the WorldServer fix was just a complete guess which worked & the if statements are just simple enough for pretty much anyone to write xD


I think you want  sharedPreferences.getString(key, gson.toJson(defaultValue)), objectClass)? There is no assumption that defaultValue.toString will return as JSON.


'Minio server is offline' or 'Minio server is unreachable'


dotnet-test-xunit is already present in the global dependencies of all these project.jsons


>What part is not clear?

* What is a "function file"?
* Is an other wording more appropriate than "… has become files …"?


**Working**, **tested** pull requests will gladly be accepted.

The design around Terminal::Action and Parser::Transition has some issues.  I think refactoring/rework needs to look a little higher/wider as well, and may be able to eliminate this field, which has a bit of a smell.


- Tan solo queda adjuntar las firmas de cada uno de los miembros del grupo.


:racehorse::dash:


I think you want sharedPreferences.getString(key, gson.toJson(defaultValue)), objectClass) in line 138 of ShiftPersistenceManager? There is no assumption that defaultValue.toString will return as JSON.


113008903Provide-a-better-warning-message-for-a-triangular-window (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1530 of 1530 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.7%25-green.svg)


@zarquon42b The link checker has been failing on this for a long time.  Gets a 404 on http://rdfbones.github.io/RDFBones-O/ontology_resources/latest/RDFBones.owl.  Is the URL in the README supposed to resolve to a real resource?  If so, could you fix the resource or README?  Thanks.


Actually, since airbases were removed and need to be reimplemented anyway it doesn't matter.


Yep, I know.
And the behaviour is easily verified by starting with en empty .config file.
The dependency without + is a subtle pitfall that has hidden many packages in menuconfig during the years. ;-(


The problem I have with this is that it makes the dirt surface full of holes after all the trees get axed. I'd prefer a solution where the dirt node is maybe marked in a way that mapgen won't place another tree in the same location instead.


No, we should not. If we just return here, the headers in dynamic table will differ from ones in peer's dynamic table. It will spoil all following requests even if we close A stream with RST_STREAM. We have to finish decoding entire header block unless a compression error happen .The current implementation is wrong. If this check was in HTTP2 module, we can just return because decoding is finished.

> An endpoint receiving HEADERS, PUSH_PROMISE, or CONTINUATION frames
> needs to reassemble header blocks and perform decompression even if
> the frames are to be discarded.

RFC 7540 Section 4.3.


The schema needs to be checked before the insertion occurs. Otherwise we would have to do two writes on the table record vector instead of a single one (or none in the case that the schema check fails). You also don't handle the return value of the schema check.


Controller should not call to Dao directly.. use the service layer.


Can you also push the change to saveschems? I'd like to keep minetest-mods/saveschems in sync.


I'm sorry. I will not accept this PR. The copyright mentioned in line 23 would mean a copyright breach.

Additionally, we are making something that is very simple (a C++ vector) into something that is quite complex (230 extra lines code). I don't see any indication that this is performance critical, hence not worth the double hassle.


it has nothing to do with airbases...


OK, I've adjusted to the spec again. Fixed at 61225bd18181cd17fd63562df7cec9e54cd4c38f. Other fixes:

4512168eb0e1023cf08d9cc1592ea7f430664ce5
b0cc6354551d341a768c6e395ee65fb4c2a067f9
61225bd18181cd17fd63562df7cec9e54cd4c38f
339591e2ea1ad6bc687a3131aeb9d766de611f62
6b558a442134d7287a2d2b9951a368134a8a913b
e684b3ec16458deb3a9dda0588c7c58d27b6de0a


nice work.


Tack ironkurd! :)
Den 10 feb 2016 19:09 skrev "Karwan" <notifications@github.com>:

> hehe
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AntoniosAchladis/Romeo/commit/f7000e9fb1e91a66d7985f9ceb6739d6b44d0fba#commitcomment-16012872>
> .
>


ACK


Let's remove that and point the [README.md](https://github.com/ros-industrial-consortium/bezier#dependencies).
Duplicating information makes maintaining harder and is error prone.


Thanks. Some stuff needs fixing, though:
- It needs to handle the case where the thread watcher is disabled.
- That list in Settings.coffee is for converting settings from loadletter's fork, so unless that setting is present there (it doesn't seem to be), that item shouldn't be there.
- Please don't close issues in commit messages. In Github's implementation, it interferes with closing/opening them manually, at least last I checked. And we don't want issues randomly closed in other forks if they pull commits.


Unfortunately VS gets stuck at one of the `Debug.Assert`s in `ControlFlow` & Co. when opening RefactoringEssentials solution (or some files inside of it).


Awesome work adding AZK - maybe I'm not familiar enough with it, but this line, and the lines in ```src/universal/utils/fetching.js``` seem to be hardcoded to the "dev" server. Will this not work in production yet?

What are the next steps to getting this to be easily deployed?


Sorry! I made a mistake with regard to NULLs. Looks like some of the fields allow NULL and some don't (I was only looking at the `qa_posts` table.). We should keep each field the same as it was, so just change `INT UNSIGNED` to `VARBINARY(16)` and leave the NULL/NOT NULL the same.


jeez man now it looks like I haven't done a damn thing!
Code stealer! XD


this bring a bug with it.
I have a source code that works with the version previous to this change and no work after it.

I have this behavior
[
            'TimestampBehavior' => [
                'class' => TimestampBehavior::className(),
                'updatedAtAttribute' => null,
                // This is a callback
                'value' => [$this, 'currentDate'],
            ]
 ]

that stop working after this change


Missing _CONST_ME_BLOCKHIT_


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1289.2086761102e9e06789af6877be9bf2a3c6feab9d](http://build.palaso.org/viewLog.html?buildId=69069&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 961, ignored: 12 Build time: 00:06:20


Looks like they can have "unstable" APIs as well.


This commit is somewhat unrelated to the PR as a whole, but while testing I came across a problem where the resource request models were not fully loaded before attempting to add a new one, so this change mandates that those models exist before the request resources form is rendered.


What happens if there is an 'err' here? - it is better to verify that and throw here and sort subsequently, are you sure that Readdirnames() will return a 'nil' when there is 'err' set?


Thanks!


You can't construct the ledger in every case for every transaction, that's a performance disaster and will push current ledgers out of the cache. You must check the ledger sequence first.


Yeah, I think that would be fine. Thanks!


@stchang The docs for `url-regexp` should have `@history[#:added "6.4.0.7"]`


Sorry, I could've been more clear. The methods `slice` and `sub` create the same type in v0.4.1, but I realize that slicing is a term to describe `c[2:end-1]`, which I agree does re-allocate the concrete data. The code is using the `slice` method [here](https://github.com/MikaelSlevinsky/FastTransforms.jl/blob/master/src/clenshawcurtis.jl#L50). I guess I'm wondering how big the performance hit is when working with `SubArray`s in FFTW? I could refactor to avoid them completely if it's justified.
```julia
julia> versioninfo()
Julia Version 0.4.1-pre+22
Commit 669222e* (2015-11-01 00:06 UTC)
Platform Info:
  System: Darwin (x86_64-apple-darwin14.5.0)
  CPU: Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
  WORD_SIZE: 64
  BLAS: libopenblas (USE64BITINT DYNAMIC_ARCH NO_AFFINITY Haswell)
  LAPACK: libopenblas64_
  LIBM: libopenlibm
  LLVM: libLLVM-3.3

julia> c = rand(1_000_000);

julia> @time slice(c,2:999_999);
  0.000005 seconds (6 allocations: 256 bytes)

julia> @time sub(c,2:999_999);
  0.000010 seconds (7 allocations: 288 bytes)

julia> slice(c,2:999_999) == sub(c,2:999_999)
true

julia> slice(c,2:999_999) ≡ sub(c,2:999_999)
true

julia> typeof(slice(c,2:999_999))
SubArray{Float64,1,Array{Float64,1},Tuple{UnitRange{Int64}},1}

```


I would suggest to use JUnit @Test(expected = ..Exception) instead of this old style expectations.


No, we don't. As I commented above, we must not stop decoding unless the error is a compression error. So I had to tell caller that X bytes read without compression errors but with HTTP2 violations.


xta-git arm_brawler can still land on a moving carrier with this commit, so please ELI5 what the problem is.


Ah my bad. Will fix it. Thanks.


Well, most of the stuff works now.


Can't use the disintegrate in proctetion zone.


We'll need to check if the eventlog table exists, because it's not on every Q2A installation


I was thinking you could filter the static assets and add a --delete to the rsync command. Thoughts?


AddNetAreaColumnToEnvelopeSummary (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1509 of 1509 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.7%25-green.svg)


why delete here and not in the prod script?


hi


Ack, sorry. Thanks.


as correções foram aqueles "=======" e ">>>>>>>" que eu tirei, heheheh


@jbrackins looks good, I think we don't need the markers for days of the week though.

Well, maybe it's good. It's hard to say. It's nice because it really would make it easier to find shows, but then I mean people can set the show name to the days of the week.

Just an idea, and it's definitely more work for us, but what if we set up the drop down menu (and therefore the class) to only show the shows that are on that day? Then just have a refresh button that would destroy the instance of the class, and reinitialize a new one, to pull in the correct shows for the day.


TeamCity libpalaso :: palaso-precise64-libpalaso-2.6 Continuous [Build 2.6.1043.1fa932e2d511960f97b0d696b832718f070de328](http://build.palaso.org/viewLog.html?buildId=69070&buildTypeId=PalasoPrecise64v26Cont) outcome was **SUCCESS**
Summary: Tests passed: 3377, ignored: 124 Build time: 00:07:52


Main view (Custom Grid View):
![device-2016-02-10-182639](https://cloud.githubusercontent.com/assets/1615724/12957601/c4019c90-d02d-11e5-90a1-df5a54693816.png)
Pop-up custom view:
![device-2016-02-10-182659](https://cloud.githubusercontent.com/assets/1615724/12957622/e83bb190-d02d-11e5-94c3-78def36d1944.png)


@grayside Why isn't there a `grunt.config.set()` here to specify the file list like there is for the validate tasks?


I think in the comment "Using time_major = False is a bit more efficient because it avoids transposes at the beginning and end of the RNN calculation." `time_major` should be set to `True` and not `False`.


minor, but this should be below `@strongify`


These should not be in the beanvalidation.org repo. Only in the beanvalidation.github.io repo as they are generated from a different "source". Does it makes sense?
I imagine in the spec, we will add a task to update latest-draft to the final website automatically.


Nem eu sei como apareceu isso 😃


The spec should not be in the beanvalidation.org repo. Only in the final beanvalidation.github.io.
That's why rsync should have the filter rule for the assets directories.


delete


TeamCity LabKey :: LabkeyModules15.3 :: Git sqlserver 2014 [Build 104](https://teamcity.labkey.org/viewLog.html?buildId=302127&buildTypeId=LabkeyModules153_GitSqlserver2014) outcome was **SUCCESS**
Summary: Tests passed: 218 Build time: 00:17:15


typo


It can be used in protection zones, I thought you would know this as you were the one who opened an issue regarding the disintegrate rune.


Спасибо, Дмитрий, разобрался, добавил. Работает, похоже.


There's not a version published on npm with this change, so you'll have to setup your package.json to pull from the master branch of this repo.


@jondixon that probably wouldn't even be that hard, just handle it in the shows class...
1. make 7 lists, one for each day
2. during init, run function that checks day of the week
3. set list to that group

only problem would be that the logger would have to be re-opened every day....... :/


Looking at your "fix" commits. I think I vastly prefer the site.yml solution. It is much cleaner and does fix the atom feed problem


Removed wrong dependency at e86b030


newest


Today I made many attempts to increase the 324 constant and vary the other constants too in singlethread, but the qubic-bonus which worked best was always the one with the original constants.


Good catch.


This hurts my eyes a little bit, and the formatter will format the alignment spaces away.


The random spawner doesn't give it's pitch and roll to the children actors. Not sure if it is possible to be changed.


If you run the server locally outside of Sandstorm (without the --sandstorm_acls flag), then it defaults to all permissions.  This is helpful for local development/debugging.

If you examine the manifest, then you'll see that the Sandstorm app always executes with the --sandstorm_acls flag.  Sandstorm doesn't allow you to access a grain without a sharing link or an explicit invite, in which case the link dictates the permissions as set in line 81.


@coreyfloyd can you elaborate a bit more on why we need to empty the tableview even though there's an error view being shown? i'll try testing this before/after this commit to see the difference as well, but some comment son `isWaitingForNetworkingToReconnect` would be helpful to provide info in the future


Ok, understood. I was trying to optimize on number of future disruptions
not number of lines. I'll do differently from now on.

Mike

--
Michael P. McCumber, PhD
Los Alamos National Laboratory
505-709-8161

On Wed, Feb 10, 2016 at 10:57 AM, pinkenburg <notifications@github.com>
wrote:

> sure once it is a detector in G4 it'll go back. But we shouldn't put non
> existing detectors or analysis macros into the G4Setup.
>
> On 02/10/16 12:30, Michael P. McCumber wrote:
> >
> > These BBC lines were placeholders for a G4 module once one is
> > developed to reduce the number of interface changes that will take
> > place in the future. I'm not sure what this removal means---are we
> > going to forgo a full BBC sim or is this just cleanup until one is
> > introduced?
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/sPHENIX-Collaboration/macros/commit/a80191adfedd8ca1e74d166bb9817f88a058e419#commitcomment-16011872
> >.
> >
>
>
> --
> *************************************************************
>
> Christopher H. Pinkenburg ; pinkenburg@bnl.gov
> ; http://www.phenix.bnl.gov/~pinkenbu
>
> Brookhaven National Laboratory ; phone: (631) 344-5692
> Physics Department Bldg 510 C ; fax: (631) 344-3253
> Upton, NY 11973-5000
>
> *************************************************************
>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sPHENIX-Collaboration/macros/commit/a80191adfedd8ca1e74d166bb9817f88a058e419#commitcomment-16012592>
> .
>


Similar thing here, if `QA_FINAL_EXTERNAL_USERS` is set then the users table won't exist. See the example in case 62 above.


Intentional colloquialism "who done seen"?


outsource `multiLang` method


If it is not too late, I, a lurker, yes, and somewhat new to Omaha, am willing to "lead" the group... if the group wants to have me step into this role.  It can't be terribly taxing, I hope.  :)

Let me know.  -- perl4ever@hotmail dot com or nw7us@nw7us dot us

-- Tomas


I think GitHub just said "Eh, screw it. Let's not put his name on the commit."

Seriously though, the commit is missing author information.

"Invalid author email. If this commit was made by you, check your local git email setting." says the magical question mark.


I think "Invert the anchor and gravity" is a bit unclear here.


You mean I should use uint8_t with bitfields and left 7bits unused, right?


You should leave the type of `dv` and of the return value as `any`.
You should say that the default value of `dv` is `undefined`.


Thanks for this great work! I recently used your SolverPool layer for my own work but it appears that the vector `vec` in `get_solver_pool` is unused. Furthermore I did not manage to invoke this function I implemented it in my training script and import `IntVec` and `SolverPool` classes in the `__init__.py` file


Во-первых, в питоне бул напрямую вызывать в этом случае не надо
Во-вторых, и сравнивать что-то явно с булевыми значениями тоже никогда не надо
В-третьих, если приспичило сравнить, то это делается по идентичность, а не по равенству.


If I am not mistaken, this is already tracked in #18.


112331505_SurfaceHeightRange (Nigusse) - x86_64-MacOS-10.9-clang: OK (2074 of 2074 tests passed, 0 test warnings)

 * 3 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I don't think these can be loc'd.


@MrBaNkS thanx bro

@shahan-mik3 @vasishath  can you pls tell us the which caf tag are you guys using


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.687.cb2331f9563441135c8aa31e4e257b3e02338107](http://build.palaso.org/viewLog.html?buildId=69074&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3406, ignored: 106 Build time: 00:07:20


Can you change `CentaurWarchief` to `Andrey <andreykvital@gmail.com>`? It's more formal for such file.


Awesome, thanks.. I guess you mean the AdminSocket stuff :) My build here hit that a few moments after I wrote that note.


Неэффективное решение, потому что делает два прохода, вместо одного достаточного, и ест в худшем случае вдвое больше памяти.


@jbrackins Yeah, I think we should do it. :100:

Nah, won't have to open every day, right? Like I said, just have a little "refresh list" button that will destroy and recreate the list, so the initializer will get called, then just update the contents of the drop down with that new list.


Instead of "partially off screen" it should probably say something like "outside positioning boundaries set by the compositor" to account for cases where the compositor doesn't want to place a surface over a questionably-valid on-screen region.


Yes, but as far I know you can not use this rune if you are in proctetion zone, maybe I'm wrong, maybe I'm not.


You should mention that the property is considered specified when its value is not a _nully_ value (`{@link Nully}`).


Nope, a simple editing mistake - fixed in 59ebdf2.


No, it should be CONST_ME_POFF, I tested the rune on real tibia before I submitted this pull request.


Is this ever null?


"should not move on that axis when constrained" = be placed offscreen?


The same notes about the type of `dv` and the return value apply.
You should mention that for the purposes of this function, a property is considered defined if its value is not `undefined`.


if while a unit is landing it is given a goal (possibly even a move order) it will stay deactivated.


「一つ前のウィンドウに戻れヘルプにアクセスできます」は
「一つ前のウィンドウに戻る(コマンドの)ヘルプにアクセスできます」とか
「一つ前のウィンドウへの移動のヘルプにアクセスできます」とかですかね？


This should be after the loop, no? I wanted to redo this a bit when I've got some time.


Seems likely to be an oversight. Without the set, the task will still operate but the files list reuse won't work.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 15276](https://teamcity.mesosphere.io/viewLog.html?buildId=131382&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:32


I don't think I like explicitly stating this full path here because a) what is the user expected to do with it, and b) this isn't in the VS layer


Дополнительные именованные аргументы необходимо распаковывать. Здесь ты, по сути, просто передал словарь kwargs как один позиционный аргумент.


Same notes as above. regarding `any`.
Should mention what is considered "specified".


Would be useful to have a real world example case here, not exactly sure what this would be for based on description?


**Задание 1**
Напишите код по следующему словесному алгоритму:
Попросить пользователя ввести число от 1 до 9. Полученные данные связать с переменной x.

- Option 1
Если пользователь ввел число от 1 до 3 включительно, то попросить пользователя ввести строку. Полученные данные связать с переменной s; попросить пользователя ввести число повторов строки. Полученные данные связать с переменной n, предварительно преобразовав их в целочисленный тип;  выполнить цикл повторения строки n раз;  вывести результат работы цикла.

- Option 2
Если пользователь ввел число от 4 до 6 включительно, то попросить пользователя ввести степень, в которую следует возвести число. Полученные данные связать с переменной m; реализовать возведение числа x в степень m;  вывести полученный результат.

- Option 3
Если пользователь ввел число от 7 до 9, то выполнить увеличения числа x на единицу в цикле 10 раз, при этом на экран вывести все 10 чисел.

Во всех остальных случаях выводить надпись "Ошибка ввода".


Megan:
Is it a typo that all of these are Rpq1 crossed with each unit vector?

Also, I may not be following 100% here, but don't you need to account for the distance between the CG of the platform and the connection point? In other words, why are you crossing Rpqi with ei, rather than ei with the vector going from the Pi to the center of the platform?

I think you're confusing this issue because _eventually_ you will want to find the torque on the motor. But remember, we're currently just trying to find the forces in each connecting rod.


Same loc problem with the button text as with the Runs above


Maybe these should also be null if there's no origin table?


@jondixon okay yeah I can start working on that after TOC!


@mattn
最後に「。」が抜けてます。
あと80文字超えてるので改行挟んだほうが良いかもしれません。


Is there a reason these need to be outside of the main body? I want to use `leven` in one of my projects but this will introduce a memory leak.


Yeah- already corrected in next commit, apologies for multiple commits.


I'm currently working on that and hopefully we'll have some results tomorrow or soon thereafter!


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.677.cb2331f9563441135c8aa31e4e257b3e02338107](http://build.palaso.org/viewLog.html?buildId=69073&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3426, ignored: 125 Build time: 00:08:56


where does this get set for output generally when there is no column name?


I'm still not quite sure of how exactly I want to use this.  I can copy the list for an unedited version, prejoin them back into a string, etc, but I don't quite know what I do and don't need.


should be `` `ROT13`_ `` as there is a reference below


Please do not document these errors.
These are, essentially, programming errors and violate the documented contract.


Yes, you're right :+1: