@jensens Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/29//violations
```
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/content.py Imports are incorrectly sorted.
src/plone/api/content.py:0:1: I001 found unsorted imports
src/plone/api/content.py:98:13: Q000 Remove bad quotes.
src/plone/api/content.py:99:13: Q000 Remove bad quotes.
src/plone/api/content.py:100:13: Q000 Remove bad quotes.
src/plone/api/content.py:268:1: C901 'delete' is too complex (15)
src/plone/api/content.py:300:25: Q000 Remove bad quotes.
src/plone/api/content.py:322:25: Q000 Remove bad quotes.
src/plone/api/content.py:360:1: C901 '_wf_transitions_for' is too complex (12)
src/plone/api/content.py:454:17: Q000 Remove bad quotes.
src/plone/api/content.py:455:17: Q000 Remove bad quotes.
src/plone/api/content.py:482:17: Q000 Remove bad quotes.
src/plone/api/content.py:521:13: Q000 Remove bad quotes.
src/plone/api/content.py:522:13: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/env.py Imports are incorrectly sorted.
src/plone/api/env.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/portal.py Imports are incorrectly sorted.
src/plone/api/portal.py:0:1: I001 found unsorted imports
src/plone/api/portal.py:66:9: Q000 Remove bad quotes.
src/plone/api/portal.py:67:9: Q000 Remove bad quotes.
src/plone/api/portal.py:68:9: Q000 Remove bad quotes.
src/plone/api/portal.py:114:13: Q000 Remove bad quotes.
src/plone/api/portal.py:115:13: Q000 Remove bad quotes.
src/plone/api/portal.py:284:17: Q000 Remove bad quotes.
src/plone/api/portal.py:285:17: Q000 Remove bad quotes.
src/plone/api/portal.py:300:17: Q000 Remove bad quotes.
src/plone/api/portal.py:301:17: Q000 Remove bad quotes.
src/plone/api/portal.py:380:66: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/user.py Imports are incorrectly sorted.
src/plone/api/user.py:0:1: I001 found unsorted imports
src/plone/api/user.py:70:13: Q000 Remove bad quotes.
src/plone/api/user.py:71:13: Q000 Remove bad quotes.
src/plone/api/user.py:357:37: Q000 Remove bad quotes.
src/plone/api/user.py:400:37: Q000 Remove bad quotes.
src/plone/api/validation.py:20:13: Q000 Remove bad quotes.
src/plone/api/validation.py:21:13: Q000 Remove bad quotes.
src/plone/api/validation.py:22:32: Q000 Remove bad quotes.
src/plone/api/validation.py:66:21: Q000 Remove bad quotes.
src/plone/api/validation.py:67:25: Q000 Remove bad quotes.
src/plone/api/validation.py:96:21: Q000 Remove bad quotes.
src/plone/api/validation.py:97:25: Q000 Remove bad quotes.
src/plone/api/validation.py:127:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:21: Q000 Remove bad quotes.
src/plone/api/validation.py:128:45: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/base.py Imports are incorrectly sorted.
src/plone/api/tests/base.py:0:1: I001 found unsorted imports
src/plone/api/tests/base.py:32:47: Q000 Remove bad quotes.
src/plone/api/tests/base.py:60:28: Q000 Remove bad quotes.
src/plone/api/tests/base.py:62:28: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_content.py Imports are incorrectly sorted.
src/plone/api/tests/test_content.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_content.py:137:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:271:37: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:879:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:880:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:881:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1015:17: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1024:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1025:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1026:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1027:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1028:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1029:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1030:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1031:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1032:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1033:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1034:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1035:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1036:13: Q000 Remove bad quotes.
src/plone/api/tests/test_content.py:1037:13: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_doctests.py Imports are incorrectly sorted.
src/plone/api/tests/test_doctests.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_doctests.py:120:13: T001 print statement found.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_env.py Imports are incorrectly sorted.
src/plone/api/tests/test_env.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_env.py:30:14: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public
src/plone/api/tests/test_env.py:31:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:32:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:33:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
src/plone/api/tests/test_env.py:34:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_group.py Imports are incorrectly sorted.
src/plone/api/tests/test_group.py:0:1: I001 found unsorted imports
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_portal.py Imports are incorrectly sorted.
src/plone/api/tests/test_portal.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_portal.py:61:16: P002 found "hasattr", consider replacing it
src/plone/api/tests/test_portal.py:125:41: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:125:57: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:163:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:164:13: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:194:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:204:22: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:213:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:214:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:215:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:229:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:230:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:251:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:252:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:253:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:272:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:273:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:279:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:289:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:290:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:299:9: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:311:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:312:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:336:27: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:337:24: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:338:25: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:345:23: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:346:20: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:347:21: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:524:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:535:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:544:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:582:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:614:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:615:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:616:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:617:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:713:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:747:44: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:748:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:749:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:750:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:785:32: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:787:38: Q000 Remove bad quotes.
src/plone/api/tests/test_portal.py:788:38: Q000 Remove bad quotes.
ERROR: /home/jenkins/workspace/package-plone.api/src/plone/api/tests/test_user.py Imports are incorrectly sorted.
src/plone/api/tests/test_user.py:0:1: I001 found unsorted imports
src/plone/api/tests/test_user.py:641:20: Q000 Remove bad quotes.
src/plone/api/tests/test_validation.py:37:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:40:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:65:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:70:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:74:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:79:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:84:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:91:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:98:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:123:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:124:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:131:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:132:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:133:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:159:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:160:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:165:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:166:14: D001 found assertEquals replace it with assertEqual
src/plone/api/tests/test_validation.py:167:14: D001 found assertEquals replace it with assertEqual
```
You can run that yourself using buildout.coredev ``experimental/qa.cfg`` config file.


For the ':controller/list', I've double checked the routes usage as per tests. And I found only these 2 routes. Also searched in the whole project myself. And they are only GET.

Last one is the fallback. I'm strongly against it. But it seems it has been heavily used in the app and requires a lot of work.


WE DON'T TALK ABOUT THIS


TTTTT-2 #time 2d 5h


dasda


What about `button`? Works fine in Chromium currently.


didn't found any :-(


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1273](http://teamcity.monogame.net/viewLog.html?buildId=14217&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:41:34


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26897/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26896/testReport/) for this commit**


В целом - хорошо, явные успехи!
Смотрел только по коду, не запускал подожду наведения порядка в репозитории.

1. Во многих TODO написано то, что следует сделать немедленно, по ним можно пройтись в первую очередь.
2. В работе с adverts целесообразнее использовать Generic Class Based Views.
3. Нет тестов.
4. В репозитории лежат лишние файлы - скрипты, предположительно из virtualenv, статические файлы сторонних приложений.
5. Коммит назван не говоряще.


Can we have a simple docstring explaining what a marketplace is?


Looks like GitHub failed to connect this commit to your account, @elsassph?


It would be better to just do `b_armature.name` rather than adding passing as a new parametre


Add the require here also?


Why is this InlineOnly?


Yes, it appears that there is a bug in decoding amf0 right now; I did some debugging last night, but haven't found the culprit yet.


Minor optimisation, extract  this to a varibale


ok, fixing this


broken implementation, you should use `setTimeout`


@annevk Thanks. Fixed at https://github.com/w3c/webcomponents/commit/5d558251aa179fb53272de5f7a814d757f57c018


Oh...


rubbish


I must be missing something, what is wrong with exit with here? :P


Not only did you remove the switch but you did some formatting to the document. Aren't these two different things?


The initialization code would conventionally reside in the "__init__" method.


can't this be unified now that you always have an sgt?


@nazar-pc Hmm. Rather, we thought that button should be banned. We are not ready how button should be rendered when a shadow root is attached.


You told me to remove it :c


Trying to minimize code here. You could run into some nasty branch divergence with all the if conditionals


It's C++-idiomatic to use no curly braces when inserting one line after an if condition


s/sell-tested/well-tested/ ?


Ditto


Hm, the (existing) glaring bug here is that the optimizer will run on the first iteration of the benchmark loop...  There should be a `querystring.parse()` call after the call to `eval()` but before the start of the benchmark.


Thank for this comment. In that case, you would need also to write
```python
f.write(data.encode("utf-8"))
```
Below in the code.


I guess long_symbol asset would be used a lot for PM.

We should pay attention to not prevent someone tro try establish a business for PMs.
At this early stage, with the low demand and volume in this type of markets, 50$ could be too much to enable a new business to make even a small profit and not going red.

I would suggest to keep the fee for long_symbol's asset lower, at least in the early days.


indeed .. fixed it


What is need for such a complicated cascading method call initialization of the ThreadLocalMetrics instance? Why can't the ThreadLocalMetrics constructor do the same? That would make the code simple and easy to read.


@schneems This still works. Ref - https://github.com/rails/rails/pull/23375

Should we document it again?


what does this line mean when line 40 already added the project_id to the metrics?


Minimizing branch divergence here, as well as curly braces. The check can happen at the end of the function (unless parseText is reliant on there being certain pieces of data) and it condenses the if conditional into a single check.


You should be using String::empty() here due to the const memory, but if you want to use an empty string by value that works too.


method name不要跟帶進去的參數一樣


not really incorrect but maybe a little misleading.
Assuming the transfer load of BTC, I see no reason to have the same amount of income given that we a) have other operations that pay fee and b) we have less costs due to cheaper witnesses


What is the need for this decoration again?


alt должен заменять картинку. Gllacy будет намного лучше отражать ее суть.


Good Job


Doesn't seem to be a valid default. IIRC, its /var/log/cinder/cinder-api.log


Right, I've set my work email by default. I've now set the correct email for this repo...


#1 :bug:  sizzle already included in jQuery
- [ ] remove "sizzle" from this line


@guilhermesilveira  revisa até aqui pra começar fazer operações com a nota por favor


I'm not a fan of deep linking into modules. It's efficient, but it may access interfaces that the module owner has no intention of keeping stable. In this case we're hard-coding a path that is likely to change (`/utils/` should be `/src/utils/`).

One way I can think of to get the best of both worlds is to have a folder with explicit exports: `require('five-bells-shared/exports/makeCaseAttestation')` which contains a file like `module.exports = require('../src/utils/makeCaseAttestation')`.


I wonder if this makes more sense as `/buyers/create` so that it matches `/admin/create` and `/suppliers/create`


Why do we need to return the metrics from the initialization method when the 'fetch_request_scoped_metrics' explicitly does the same? Neither do i see the returned value used anywhere.


The general description and above all conclusion for both worker_create and witness_create are the same, still those two fee differ by x10.

Is this intentional? (I am still pretty fine with this differentation)


Why is this InlineOnly?


Ok. Could you still mention it? something like:
```
while not_quit:
    for i in 0..n:
        execute_logic
            ...
            synchronize_with_external_clock # optionally
            ...
        execute_physics
    end

    execute_graphics # v-sync occurs here if enabled
```


"prognam" means? again a docstring would be nice here.


It seems returning Map<LicenseFeature, String> is more safe here.


ja maar blabla is toch beter


@romainr this is due to be out with 3.10, right? We'd love to demo using Drill alongside Hue, since official Hue support is (still an idea)[https://drill.apache.org/docs/apache-drill-contribution-ideas/], was wondering how I can use this today? There is no 3.10 branch on the repo, your help is very much appreciated.


It should not, but I will test to make sure.


Why are these InlineOnly?


hoi


yooo


saaie les


Done.


++ This makes sense to grab it from the app object directly


zeker


A comment as to the "why" would be more helpful.
i.e.  "why is the bundle name removed from the list?"


That's implied transitively


Because there is no intuitive way to convert float to quantity.


Because it's already inline, and why not?


I'd suggest always adding braces even for one line conditionals. It helps avoid subtle errors.


It wasn't working since _broken is not nil, its [] or did it work for you?

_broken is defined in line 32/25. So its not nil from my understanding.


I think is meth is the method reference and wouldn't return its name. You might want to use the 'func_name' attribute of the method reference to get its name.
 Also, do we want to log the extensions?


We can document but in a different section.


:open_mouth: :+1:


Lets skip it for now. What to do in error situations should be rather the part of HPA graduation - and there is plenty of things that we can do better in half-error situations.


@danilo-helabs Please don't forget to run the `scss-lint` command before you push the changes. :+1:


    assert(ops);

Also, I guess it only makes sense for direction to be GPIO_DIR_OUT or GPIO_DIR_IN? If so, you could assert that too.


:+1:  Good job


I think that a good rule of thumb for methods which don't take lambdas is to inline methods that don't contain any logic. Most of the methods you've marked as inline follow that rule, but this one does not.


> This says getRandomHost yet the hosts are always retrieved in order of their index, which based on the static List, will never be random?

As you suggested above, randomly picking one of [`a`, `b`, `c`, `d`, `e`] using getRandomFallbackHost() would be better. Rather than randomly ordering them in a list. e.g., [`d`, `b`, `e`, `c`, `e`]


It may be misleading, but actually no.
I'm building in `../lib` using babel https://github.com/typicode/hotel/blob/master/package.json#L18


This is impossible since you `assert (ops_ptr->get_value != 0)` in `gpio_init()`. Therefore this can be an assert


@aodzip Can't stop playing it. xD


Ditto


#1 sizzle already included in jQuery
 [ ] remove sizzle from this line


More C++-idiomatic


Agree, but there is also a number of other prerequisites that should happen before 1.2 but shouldn't block this PR. For example - #19944.
Also annotations should be validated when creating an HPA, will add it in the next PR. Lets keep things moving.


Great item to itemize in separate package.


Remove Katana, thats unused @ChalkPE ;)


This operation is used by active witnesses every time they need to change the producing witness_node.
This mostly happens during witness upgrade or for general maintain.

Is this a pretty "rare" operation, but as stated in the conclusion, a bare minimum fee should be applied.

So I suggest a real bare minimum fee of 0.0001  (same as for asset_publish_fee)


Maybe we could start by breaking down the last wildcard into smaller pieces.

match ':controller/delete/:id', :via => [:delete]
match ':controller/edit(/:id(.:format))', :via => [:get]

etc. And then we can continue breaking those down into a proper list later.


Hey Chris. I can confirm that this seems to be fixing the issue we've been having.


    assert(ops);

Also, I guess it only makes sense for direction to be GPIO_LEVEL_HIGH or GPIO_LEVEL_LOW? If so, you could assert that too.


Might want to look at whether your code can support directly returning Serial.available();


assert this instead of runtime check.


Pretty substantial changes. I will test the update process on both platforms.


good call, ill fix these up


@rafaelfranca Can you please explain why we should document in different section. I didn't get it.


May be make pidfile_verify() a member function too?


The general description and above all conclusion for both committee_member_create and witness_create are the same, still those two fee differ by x10.

Is this intentional? (I am still pretty fine with this differentation)


Hello @duanyp1991

I'll investigate and propose a solution.

Regards


I think it looks more nice if you replace this with this here.
buttonText:SetTextColor(classTextColor.r, classTextColor.g, classTextColor.b);


And what would the Class<?> argument be? FSClassloader doesn't export any packages.


смотрела по коммиту


@rfrancel
The referenced column n_scale in view_gridstand_wkt33_shop of this commit does not exist (anymore?) in the view.
Could you please prepare a pr and fix the sphinx query and/or the view .


It takes a lambda `defaultValue`


Think you need to include the built files in `lib` for your bin script to work. Right now installing from npm fails on trying to include files that don't exist.


Используй object literal https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Object_initializer


A bundle's persistent storage area (which is what getDataFile()) accesses, is supposed to be private. This is a workaround that security restriction.


_G["GuildFrameGuildStatusButton"..i.."Online"]:SetTextColor(classTextColor.r, classTextColor.g, classTextColor.b);
Better too i think


mar**K**up


The tests were wrong from the beginning as we should test the client not the "low-level" function.


@meltzow and the libs where necessary for compilation. Please check compilation before commiting.


On library/module standarisation: if a good Lua implementation appeared it would likely get adopted universally. Like for example chili.


@indirect Thank you for release work. I merged Ruby upstream at https://github.com/ruby/ruby/commit/a21d403f21473b21b5766c2483b4325240e9edda


Looks like you're reporting an error in the code (@InlineOnly used with a non-inline function) as an internal compiler error, not as a diagnostic. Why?


    assert(ops);

Also, I guess it only makes sense for direction to be GPIO_DIR_OUT or GPIO_DIR_IN? If so, you could assert that too.


This is impossible since you `assert (ops_ptr->get_value != 0)` in `gpio_init()`. Therefore this can be an assert


I'm wondering why we add the timestamp here. Can't we set the timestamp at the moment we receive the reading from the bluetooth stack or as close as possible to that (since that's closer to reality) and then distribute the RHTDataPoint instead of separate temp and humi values. We could also push the device into the RHTDataPoint, no?


TeamCity Civic Assembly :: Build all [Build 33](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=607&buildTypeId=CivicAssembly_BuildAll&guest=1) is now running


    assert(ops);

Also, I guess it only makes sense for direction to be GPIO_LEVEL_HIGH or GPIO_LEVEL_LOW? If so, you could assert that too.


TeamCity Civic Assembly :: Build backend + frontend [Build 48](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=608&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


assert this instead of runtime check.


Fix #17


TeamCity Civic Assembly :: Build all [Build 33](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=607&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **UNKNOWN**
Summary: Canceled (Exit code 2; exit code 1; exit code 137 (new); exit code 123) Build time: 00:00:34


I am really not sure I see the advantage of this because it means the logic in `getRandomHost` will need to keep track of which random host it had previously used.  If you simply randomise them when the static list is created, it means `getRandomHost` can simply iterate through hosts using a mod function so complexity is reduced with the same overall effect.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/24297/testReport/) for this commit**


We don't really have packages, we actually install the components from source :-)


I don't think that is neccessary.


Yep!


Please always add javadocs


> We have test cases for failing requests to unreachable hosts.

Fine, but we don't need this in every test because 99% of our tests are only ever against `sandbox-rest.ably.io`

> Within our current spec, we are not supporting any other host than rest.ably.io for HTTP calls

Yes we are, http://docs.ably.io/client-lib-development-guide/features/#TO3k2, http://docs.ably.io/client-lib-development-guide/features/#TO3k3, and http://docs.ably.io/client-lib-development-guide/features/#TO3k1 all change the host that is used.


Ладно, не будем больше мучать эту часть, хотя в реальном промышленном проекте этого недостаточно (например, не проверено что будет, если передать Crime, Drama — true, потому что оба этих жанра у фильма есть, или false, по какой-то другой логике). Но бог с ним :)


+1
Why not to use the powerful of return value? =)


Because that section is about loading code not about setting cache storage. It is in Richard's commit message :smile:


Да в grizzly можно написать что угодно - все равно выпиливать.


Not clear about this write-back issue. At least I am confused.


Missing `gpio_get_direction()`. I guess you'll need another `gpio_ops_t` function.


I was talking about some ideas which need more development.


TeamCity Civic Assembly :: Build backend + frontend [Build 48](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=608&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:28


Got it. I will apply randomisation behavior at initialization level (AOT), instead of whenever I need it (JIT)


Since we are not using the groups anywhere, it would be better for performance to make them non-capturing.
(As an added bonus, you'll have the chance to write a RegExp that includes `?::?` - not somethng you do everyday :grin:)


디버그 코드 발견!


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26907/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26906/testReport/) for this commit**


@GarySiu Just fixing some minor things. Let me know when any of the other pages are fully implemented and ready to be styled and I'll move on to styling them. Cheers.


"or imdb_id"


#2 해결


TeamCity LabKey :: LabkeyRelease15.3 :: CDS postgres 9.4 [Build 138](https://teamcity.labkey.org/viewLog.html?buildId=300262&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 11 (7 new), passed: 19 Build time: 01:13:54
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogAndLinearScales: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCounts: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

##### there are 1 more failed tests, see build details
```


I would like to see:
-More consistency on the price_per_kb fee, and more explanation/thoughts on the different values used for these kind of fee.
-Current BTS value for every fee applied.

It is certainly usefull to address fees on $, but I would also like to have an easy reference for its BTS value.
We do not have to underestimate the psychological impact that the BTS value fee could have on users.


Tested on OSX, plan on doing Windows this morning.


Comment on commit msg: This is a bit too brief. Could you at least spell out what GPIO stands for and make it clear that this defines a simple, generic interface to abstract GPIO device access.


Since a witness will gain income but a committee member will not?


With other handlers on this.thread (l202 -> l214)?


method name isn't very descriptive, you should have used something like selectUserByName()


Нельзя переименовывать счетчики!
id счетчика задается раз и навсегда, по нему хранятся данные в приложении


1 - Tanto na classe Pessoa fisica como jurídica a coluna pessoa está como @OneToOne
então ao invés de @Column a coluna deve ser mapeada como @JoinColumn, já que @Column
é usada na classe pai. Além do mais o hibernate está lançando uma exceção ao iniciar
o projeto referente a esse mapeamento.

2 - O padrão que vamos usar é o camelcase, então renomeie os campos e o nome das classes,
ao invés de usar "_" para separar nomes compostos utilize o camelcase.
Além de ser o padrão mais utilizado, quando futuramente alguém for criar consultas mais
personalizadas no spring data vai dar erro se tiver o "_" nos atributos.


プレイヤーの表示 #36


Why you decided to use delayed insertions?


Avoid fractions: although a $1 fee makes some sense, a same fee of 251.12321 BTS makes no sense when showing on the fee schedule.


Always use curly braces even for single lined blocks


what about the mass mailing channel case?


ElipsChat
 +
 +Voice Calling
 +Group Chat
 +One on One chat
 +Facebook Authentication
 +Emojicons
 +Firebase Database
 +Cloudinary Image Storage
 +Picasso ImageLoader


I might say: The multilib feature is not complete and not well tested.


@AGaliuzov. i missed that it's the private method, Ok


> Would be useful to give the equation between logic_step_max, physics_step_max and n. That would make the use of these parameters much more meaningful, I suppose.

It is an internal behaviour of BGE, and I hope they will change their algorithm at some point, because it looks insane from my point of view :). So I prefer do not document it. But I remove the note about the insanity of BGE logic :D


@flavour About this function create_checklist_from_template


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26909/testReport/) for this commit**


@flavour Please review


I'm having trouble passing a fake body into the Response/StringTransport (neither of these ways works), but the response code works.
It breaks in http_proxy at  ```body = yield readBody(r)```


@almeidafab Se quiser que isso vá para produção tem que mudar no docker e não aqui no portal-de-servicos.


There's another three of these!


final


multiple snackbar?


@namhyung  Sure, there are some typos here and there. Fork crosstool-ng, fix the typos and open a pull request. The more help we get the better we can make crosstool-ng. :)


The notifications branch is merged into dev now. Tom is off this week and I'm off the next so I don't have a firm date on when things are considered fully implemented but I'll keep you posted.


You can use `git add -p` to avoid including these comments in your commit :smiley:


You can assign a string directly String dbName = "high-school", there is no need to instantiate it.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26912/testReport/) for this commit**


this installs `carthage` twice:
```
Error: carthage-0.11 already installed
To install this version, first `brew unlink carthage`
The command "brew update && brew outdated carthage || brew install carthage"
```


open #1 sizzle already included in jQuery
- [ ]  remove "sizzle" from this line


*I think* you don't need the `throws IOException` here, since you have the `(expected=UncheckedIOException.class)` already.


Need more butification


OK, so it starts wrong as I've already said:
the limitby 2 is only useful if you limit the query to the location_id or None


These libs seem to be broken. Stock keyboard crashes with them.


open #1 sizzle already included in jQuery
- [ ]  remove this line


nit: probably worth asserting that gpio_nums > 0


Also
```
% false && false || true
% echo $?
0 # ie successful
```

```
a && b || c = (a && b) || c
```


No, only if limitby == 2 & you have reduced to the one with a location_id


Wow, impressive. I should stop committing one more year and we'll kick the hell out of Wordpress


nice :+1:


Hey Basti,

it seems this fix broke browsersync reloading propperly on file change. I didn't quite understand what went wrong but I was able to fix it by passing a server name to browsersyncs create('name') method. One then has to reference the server in the file handler in task.js like:

`let bs = require('browser-sync').get('name');`
`bs.reload();`


You should at least remove this line...


That was my first assumption too, but pthreads didn't showed up with phpinfo. Threrefore I've testet another deployment. To get it working with the included php binary, I had to copy the dll and ini to C:\projects\pthreads\bin.


Guys please check if any API is broken or not working! Because i have modified server code a lot


=D


Can assert this.


로딩 중 에러가 발생합니다. 코드에 이상이 있는지 확인 부탁합니다.


! comment


@omarsotillo @ivanportillo my pulse is about 63 when I see you <3


> for development environments only

As far as I get, release version shouldn't provide APIs to customize host.

We need to find a solution to provide test config while running test cases, instead of production config. What I am actually looking for is something similar to gradle android plugin's build flavors that let's you use different versions of source sets. If I succeed on that, we just need to have a different `Defaults` file under some other path that will be used with test cases.


"Either maze_id, tvdb_id, tvrage_id or show_name are required" should be "Either maze_id, tvdb_id, tvrage_id, imdb_id or show_name are required" after this change. (Note the addition of the imdb_id ye blind bat :+1: )


ты еще не сделал таблицу с названиями мерчант, да?


> As far as I get, release version shouldn't provide APIs to customize host.

I'm not following you?

> We need to find a solution to provide test config while running test cases, instead of production config. What I am actually looking for is something similar to gradle android plugin's build flavors that let's you use different versions of source sets. If I succeed on that, we just need to have a different Defaults file under some other path that will be used with test cases.

Perhaps, but that introduces the possibility that when in production we have other issues.  No other client library has had to do this, we simply instance all libraries with `environment: 'sandbox'` for our test suite.  I am not following why that is not a viable solution and why we should add more complexity


Hello Sir
I would like to speak to you about iphone jailbreaking and unlocking. Please email me jmc213@ymail.com if you can help me I will pay you for your services. Please advise ASAP.

Regards,
James Casasnovas


Remove extra comma


I'll except once there are tests :)


Oh, you meant in the exception. What's the matter, you pay github by amount of details you give in reviews or something? :wink:


For reference
https://github.com/amperka/ino/issues/180


This is not meant as an restriction. It prevents `run` from being executed twice because `run` is called after every callback anyway (see CommandEndpoint).


why use [`wait`](https://docs.oracle.com/javase/7/docs/api/java/lang/Object.html#wait()) here, i.e. who calls `.notify` on this? I think you mean to use [`Thread.sleep`](https://docs.oracle.com/javase/7/docs/api/java/lang/Thread.html#sleep(long)). Otherwise please explain why wait. See this [discussion](http://stackoverflow.com/a/10561020/890242)


Use `<UserName>` or `<DisplayUsername>` component here.


Somewhat late review comment: C# programming style prefers checking and throwing ArgumentException at the start in its own block of code.

if (arg1 != validValue)
{
throw new...
}

Then there would be no else code block before the rest of the function (assume thereafter that all arguments are valid).


The Walter, is there a list of things like these changes that need doing?


focus on body


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1274](http://teamcity.monogame.net/viewLog.html?buildId=14221&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Second letter shouldn't be uppercase.


It's fixed now. Update code using the logic I mentioned above.


Double is huge, for small decimals you should use float.


мне для самообразования - что это ты сделал и зачем?:) просто короче запись или есть другой смысл?


Why is it questionable? returning false renders nothing.


Very nice! Though I think *Nested() should have been kept as a deprecated pointer to the new methods as to not break every plugin using *Nested() immediately.


L is not uppercase.


Obviously this is an example test, but generally speaking ArgumentExceptions are not tested. This might change if there is a user interaction scenario (i.e. a user might try and enter -1 as a value), but convention is that such tests offer little value.


This commit at least makes interrupt IN work. Not sure how to properly do interrupt OUT, as I don't have such a use-case.


alt="" - другой


What kind of warnings? Missing `@param` and `@return` or a different issue?


префикс в swift не нужон. есть модули и namespace'ы. при конфликтах пишем: LeakKit.App


Я совсем запутался что, где надо исправить, где не правельно!!!

2016-02-01 14:40 GMT+02:00 Nastya Smirnova <notifications@github.com>:

> смотрела по коммиту
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pyadmitrij/GoJavaOnline/commit/312a12c243c3b4088a897f39156d42ab4f50b209#commitcomment-15798013>
> .
>

--
С уважением,
Дмитрий Пясецкий
Тел: 0977801619
Email: pyadmitrij@gmail.com
Скайп: pjdmitrij


Should go to the group's page on successful create, no?


почему так? нас учили, что должны быть параметры у коллекций


I dislike this.
I am open to other suggestions.


image


This should solve issue #6
Some more tests are pending


jetzt committed


:laughing:


Creates unique tokens when given a program as an input


vlc, dragon-player iso ya konmayabilir.


approved


Дай этой li класс, чтобы можно было через класс за стилизовать. Потому что наличие тега b, оно такое шаткое, сегодня есть, а завтра нет. Через стили жирность увеличим


а `movie.watched!(10000, "2016-01-01")` ок?
а `movie.watched!("чё-то не очень понравилось", "2016-01-01")` ок?


at foofoo


at barbar


looks good to me.  one thing I would do differently is replacing:
    string thread_name;
    thread_name.append(string("ms_xio_qs_") + std::to_string(ix));
with:
    string thread_name = "ms_xio_qs_";
    thread_name.append(std::to_string(ix));

(this will save you from allocating string object on the stack with constructor & destructor for the result of the string::operator+)


at new line


Excellent work, Jude!  Great to see you diving into all of this!


double strike for Online GitHub Editor


at removed 24: public void run() {


it's working fine


at 27:27


Ссылка с картинкой не нужны. Значок "лупа" повесим на background


This will bring the info but without the asked format, to obtain that format you should use concat() and use multiple queries grouped into one.


кстати, можно `expect(movie).to be_watched` (для любого метода, который есть у объекта и заканчивается на ?)


please remove code that is no longer required, or add a comment explaining why this is here. nothing is more annoying than commented code, when you look at it in 3 months time nobody remembers why it here and if it serves any potential purpose.


at import AtomicInteger


а что здесь удаляется? Мне Дима Колесник все время говорит, что ничего нельзя удалять из базы, если это не вспомогательная техническая информация.


Yes @Guneetconvent2002 ?


remove or give a rationale


That 10 is hardcoded, what happens if there is a new alum?


This should actually look at the 'type' file, and if it is not present, assume filestore.  That way the 'osd objectstore' setting only affects new osds and can be changed on an existing cluster.


remove or explain


Nice work, there were some small issues but I can tell you grasped the idea on how to work with SQL.
If you have some spare time you could investigate how to improve the queries as suggested.


remove copyright. this is original code and does not belong to aplant.


Ещё кстати — когда ты уже немножко освоил rspec, можно позволять себе тесты простой функциональности записывать копактнее, не размазывать по нескольким примерам, скажем:
```ruby
it "меняется в момент просмотра" do
 expect(movie).to_not be_watched
 movie.watched!(...)
 expect(movie).to be_watched
end
```


@sgomes Also "cutting" a [release](https://github.com/google/material-design-lite/releases)?


Sure about this? I had to change this back to "ret" in order to have a similar behavior as chrome.usb on Chrome.


Ссылке дай класс, а картинка не нужна, она будет либо фоном в ссылке либо иконочным шрифтом


This is the hack in #1


this is the kind of changes that should be in the rename files commit, not in the migration one


@odoo-horizontal-padding


I am indeed :) It's a slow process, as I like to do a lot of checks, but expect it later today!


Форме желательно давать атрибут name, чтобы на сервере было понятно с какой формы пришли данные


@sheffien Perfect, just tested it and it works fine.


Awesome! And btw, congrats on :boat:-ing v1.1, t'was a nice journey!


For interrupt IN transfers, simply doing
`return mConnection.bulkTransfer(ep, buffer, buffer.length, 0);`
works for me, while the initial UsbRequest code makes it fail


почему в бинах не нужен конструктор?


Input оберни в label, br - не нужны, сделаем для label {display: block;}


we now have two loops, one in BackgroundService, one here. IMO this one here is no longer required, as BackgroundService restarts the service every so often.


I'm not sure, but I think the issue is here that we need to connect a producer up to the transport (perhaps that string producer that we used before?). It could also be an issue of the `StringTransport` not closing the connection, in which case there is a string transport where you can close the connection.


If `patternns` is created with `g_ptr_array_new_with_free_func()` you may eliminate this loop.


remove or explain


Sep should be `:` color, but it's a semicolon `;` here... DB will break horribly


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26924/testReport/) for this commit**


can you give me final output of that downloader ?


again, same as BluetoothScanService loop: we now have two loops, one in BackgroundService, one here. IMO this one here is no longer required, as BackgroundService restarts the service every so often.


от ты не можешь пройти мимо))))) мне может так понятней)


go to line before class="..." ?


```swift
private static let stringVendorIdentifierKey = "stringIdentifierForVendor"
```


lgtm


8일전?


TeamCity Civic Assembly :: Build backend + frontend [Build 49](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=611&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


Ah, yes, silly me. Someone else sent over this code. I had wrongly assumed it was part of your pull requests.


почему не public?


TeamCity Civic Assembly :: Build all [Build 34](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=614&buildTypeId=CivicAssembly_BuildAll&guest=1) is now running


this code is a repetition of the code above. ( and you don't use the elements by reference here, you copy ). I would refactor this for loop into a function


Oh, sorry, missed that in our standards. I would argue for us to move to eslint, though. See https://github.com/okfn/coding-standards/issues/5


TeamCity Civic Assembly :: Build all [Build 34](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=614&buildTypeId=CivicAssembly_BuildAll&guest=1) outcome was **FAILURE**
Summary: Exit code 2; exit code 1; exit code 123 Build time: 00:00:35


@matsko, I was looking into an issue with parsing dates in IE/Edge the other day and I am wondering what is the usecase for `ISO_DATE_REGEXP` ? Do you have an example of when it is used (i.e. under what circumstances can the viewValue of a date input field be encoded as JSON) ?

I understand it's been a while, so if you don't remember the usecase, I'll understand :smiley:


Sign in button


```swift
static let bundleName = NSBundle.mainBundle().infoDictionary![CFBundleName] as! String
```


аналогично


и это


I don't really understand. Split up how, and why?


all keys are in lower key (`"ssid, signal, mac"`)


ну и остальные тоже думаю static можно сделать


As we mentioned in the pull request, that isn't really useful.


`//Sign in`


x.dtype is a string, right? So this will always evaluate to false. Either use `in` or `== 'uint64'`


Not compatible with `zsh`.


This is going to be an odd merge with develop.  Contact me if you have trouble.


Reduce using the approach I linked to before...& only if len(rows) == 2
if len(rows) is 1 then this would exclude the default fallback


Эту и нижнюю ссылки внеси в форму, либо переделай button на input и привяжи через атрибут form к форме (http://htmlbook.ru/html/input/form). Тут будет кнопка прижата к левому краю, а ссылки к правому. Ссылки должны идти в одном блоке, который будет float: right; кнопка float: left, и кнопка и ссылки в блоке, должны быть в общем блоке


`//Insert log in method`


Внутри ссылки необходим span с классом, в который будет передаваться количество товаров. По умолчанию он пустой.


TeamCity Civic Assembly :: Build backend + frontend [Build 49](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=611&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests failed: 88, passed: 42, ignored: 4 Build time: 00:05:27
### Failed tests
```
Document type tests: Should not create new document type if cancelled: <no details avaliable>

Document type tests: Should add new document type: <no details avaliable>

Document type tests: Should not change document type: <no details avaliable>

Document type tests: Should change document type: <no details avaliable>

Document type tests: Should not delete document type if cancel pressed: <no details avaliable>

Document type tests: Should delete document type: <no details avaliable>

Document tests: Should take a alert when try to upload new version for locked document: <no details avaliable>

Media type tests: Should not create new media type if cancelled: <no details avaliable>

Media type tests: Should add new media type: <no details avaliable>

Media type tests: Should not change media type: <no details avaliable>

Media type tests: Should change media type: <no details avaliable>

##### there are 78 more failed tests, see build details
```


Why query once to see which is the correct ID & then query again to get the fields?
You should only do 1 query here which does both jobs


можно так?
```swift
public let fileLogger = DDFileLogger()
```

или даже static'ом


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26926/testReport/) for this commit**


Please check if did everything right or not.


What about filtering out deleted == True?
This would include deleted entries currently...


скобки лишние?


typo in argument name ( floated, not floaded )


@rikterbeek what's this for? `∂∂∂`


I get the condition but I think it is expressed in a counter-intuitive way. I think :
if (dtype == 'uint64' or (dtype in self.numpy_unsupported_dtypes and r_var.ndim == 1)):
would be much clearer


Why? If we update Tor that should be included, as well as if we change bbserver. What benefit does .gitignoring them have?


Good to include details in the docstring about what the arguments are: meaning & what type they are expected to be.
group_ids sounds like a list of groups, but is it pe_id, pr_group.id, auth_role.id?


Это не input, это просто значок, при клике на который, товар удаляется из корзины. Можно через span


move to `_overridedSetAttributeCore`


Надо дать класс для таблицы, чтобы ее застилизовать.


move to `_overridedRemoveAttributeCore`


You might be having visual studio or visual C++ libraries installed. That's the other way to make it work. But that's a GB+ download for anyone who doesn't have it already.

On 1 Feb 2016 13:01, Mike James <notifications@github.com> wrote:
>
> >
> > Strange, I've got it working with crypto
> >
> > On Mon, 1 Feb 2016 02:01 Varun Achar <notifications@github.com> wrote:
> >
> > > Crypto's implementation doesn't play well with PHP's. In order to make
> > > them play well, we need a library called libmcrypt which doesn't exist for
> > > windows systems. We need to build that library from source. Mcrypt library
> > > used here does that for us. So in order to maintain consistency across
> > > environments, I used mcrpyt.
> > > Varun
> > > On 1 Feb 2016 03:29, Mike James <notifications@github.com> wrote:FYI you
> > > can do this without the dependency, use crypto
> > >
> > > —Reply to this email directly or view it on GitHub.
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <https://github.com/TDispatch/webhooks-and-services/commit/2e917c1d85d419f636898cf0e3fb50d84d95b8b0#commitcomment-15789415>
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub.


![ios simulator screen shot 01-feb-2016 7 06 32 pm](https://cloud.githubusercontent.com/assets/1255516/12718907/b0afb0fe-c917-11e5-93f0-6b26ca77ea04.png)


What's the purpose?
Do we really have a use-case for different values per PolyglotEngine for caches? Or would we even specify them?


when using iterators, ++i is more efficient than i++ because i++ needs to create a temporary object and return it, while ++i can do the operation on the object itself. ( for default types, the compiler will optimize this, I don't think it's optimized for user types )


see #80


Application UI-Screenshot.


@ProjectInfinity https://github.com/Nukkit/Nukkit/pull/444 :D


(The less nodes using the context the better IMHO, and this is just going against it)


please change all method names to lower case. it is common practice that all method names are lower case, in fact only class names are in upper case.


ttemplate.location_id should be looked-up outside the loop & I think probably more efficient to include anyway rather than check for if.
(This is different of sending a JSON over the wire...then not including NULLs is a useful little time/bandwidth saver)


для span - класс


`g_ptr_array_new_with_free_func` can be used here.


Те же правки как и в первой строке


Oh I was looking at the wrong base.cfg ! :P


<b> не надо, сделаем через стили


You should do this for b1.5 as well


No need for this line normally - normal is to do:
onaccept(ctable, dict(id=cid))


prijs = price


remove commented line


wat voor row?


same here, please try to keep your commits consistant


Right now we do not have an sgt for the non-scattered allocation. We use a temporary sgt to construct the list of pages. Let me see what I can do.


webshopprijzen?


Not used here.


prijs = prices ?


Yay fixed. It's been lingering for a while ;)


bad var name: this should be something like template_entries
- shows it's plural
- much more readable


aa = a ? wutfuck


price...


entries (plural)


Thank you for maintaining this code. Unfortunately, upon compiling to compile the git version today, this change gives the following compilation error cross-compiling from GNU/Linux to MinGW-W64 using gcc-5.3.0:

```
win_utf8_io/win_utf8_io.c:266:13: error: static declaration of 'set_filename_utf8' follows non-static declaration
 static void set_filename_utf8(int b)
             ^
win_utf8_io/win_utf8_io.c:106:6: note: previous declaration of 'set_filename_utf8' was here
 void set_filename_utf8(int b);
      ^
win_utf8_io/win_utf8_io.c:266:13: warning: 'set_filename_utf8' defined but not used [-Wunused-function]
 static void set_filename_utf8(int b)
             ^
Makefile:635: recipe for target 'win_utf8_io/win_utf8_io.lo' failed
make[3]: *** [win_utf8_io/win_utf8_io.lo] Error 1
```


This part is not very clear to me.
First of all, there is no definition of the system interface?
I am not sure about the position of this DPM either.
For example, if a DPM act as a filter and receives unfiltered messages from debug network, would unfiltered messages saturate the debug ring?
I see potentials to let DPM act as a bridge between two hierarchical debug networks. Then this DPM filters messages from the internal network and forwards the filtered ones to the outer network.
Also, this system interface can be used to receive messages from another debug module?
Could a DPM works as a wrapper of a tracer? There are many options. The text here is not very clear to me.
Either exploring all possibility here or just leaving a high level description without too many details is your decision.


aa < bb ? ik niet begrijpen


Не увидел блока с временем и телефоном


Deze wordt later aangepast, webshopprijzen ivm fake data


This should be etable not ctable


& eid not cid


repetition of this condition. refactor if statement above to include all cases.


:+1: :+1: :+1: :+1: :+1: :+1:


Row in de grafiek


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1274](http://teamcity.monogame.net/viewLog.html?buildId=14221&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:27:31


Twee keer dezelfde loop? Gebruik beetje comments.


Thanks, heb het aangepast


what if the call to `postData` fails (i.e. if the post to url fails) - currently it deletes all data just assuming everything went alright. never do that with networking on a mobile device => we don't want to loose any data!


etable not ctable, but I don't believe either are instances of a super-entity so not required anyway


Nice that you make it compilable, however you'd have to replace this with number parsing code :-)


Deze functie moet omgeschreven worden uiteindelijk naar de juiste data, is nu zo ivm fake data


This needs to be wrapped in a `<p>` tag.


this case is expecting defaulting to not occur but will now default the empty dir field


Volgorde voor de datums van ophalen. Als ze niet gesorteerd zijn moet hij op volgorde worden gezet


import java.util.*;

public class TreeSetTest{

  public static void main(String[] args){

   SortedSet<Item> parts = new TreeSet<>();
   parts.add(new Item("Toaster", 1234));
   parts.add(new Item("Widget", 4562));
   parts.add(new Item("Modem", 9912);
   System.out.println(parts);

   SortedSet<Item> sortByDescription = new TreeSet<>(new Comparator<Item>();
    {

      public int compare(Item a, Item b)
      {
        String descrA = a.getDescription();
        String descrB = b.getDescription();

        return descrA.compareTo(descrb);
       }
      });

    sortByDescription.addAll(parts);
    System.out.println(sortByDescription);
   }
 }


we should probably mention the default in the text here since it is not the normal default


same for the v1beta3 json description


Thanks, ga het aanpassen


lol please tell me what is "dildo gold"


Oh, shit! Sorry for this!


Thank you :)


typo: cache, not cahe


As we talked with @bazsi, we shouldn't use ```g_ptr_array_new_with_free_func``` because it brokes the compatibility with older glib versions


There should be a corresponding test in the success cases like https://github.com/dgoodwin/origin/blob/7a5d69c51495628b737bcf1afb7c6f8ee702d3ff/Godeps/_workspace/src/k8s.io/kubernetes/pkg/securitycontextconstraints/provider_test.go#L590


Awesome! Thank you very much for this release


We're missing the update for `HAL_BOARD_SUBTYPE_LINUX_BH`. Probably because that wasn't on master by the time of the commit.


Done.


Fixes #6. Silly me was referencing the wrong column for the csv.


according to [this](http://developer.android.com/about/versions/marshmallow/android-6.0-changes.html#behavior-apache-http-client) the apache library's DefaultHttpClient is no longer support in Android. We are targeting api level 3.x (11 and above) => use [HttpURLConnection](http://developer.android.com/reference/java/net/HttpURLConnection.html).

**note** the server will always redirect to https


sources/tech/20151104 How to Install Pure-FTPd with TLS on FreeBSD 10.2.md

如何安装


That must be a typo.


That's a lot of blank lines.


У этого блока и у блока .special-offer-chocolate, должен быть общий класс через который мы сможем задать свойства для заголовков h2 и тегов p. Допустим класс дать им общий .special-offer + у каждого будет свой для фона


It is ok to check if array is (not) empty with `if(array.length) {}` or `if(!array.length) {}`


br не нужен


is this file needed at all? all location updates seem to be handled in MainActivity.


a .then() cannot follow .catch() right? @n1k0  @Natim @almet @leplatrem


Why?


Этот блок будет прижат к правому краю, у него будет float: right;


Protractor version was upgraded to 3.0.0 without upgrading this library's own version. This breaks many folks that relied on version 1.0.0 supporting Protractor 2.X


Oops, forgot that is just our local port


In which case you're safe to remove `project` and `locale` variable definitions above.


@mastercoms Got it. ;)


В данном случае br скорее всего не нужен, здесь сколько текста влезло в строку, то и есть


This should be @ExplodeLoop


Hey Greg,
Hope you're doing well?
I still haven't been able to get a stable stream realized on Safari/Firefox/Chrome + analyze the streamed data with an audiocontext node.

I wrote a request on Stackoverflow.com. But I doubt I'm afraid I won't receive an answer there:
http://stackoverflow.com/questions/35132066/javascript-simple-soundcloud-api-example-for-streaming-wont-work-properly-with

Maybe you could give me a tip to get either my first or second example that I posted via stackoverflow running?

Thanks in advance.
greets from berlin
Christian


@dill

We say that the hn model should be discarded based on fit but it is then included in the model comparison table... is this confusing? There is also no real guidance here on model selection (we do not explicitly say model x shoud be selected)... although the AIC is smallest for amakihi.hr.obs.mas, some would argue that a difference of less than 2 does not really justify the inclusion of the additional covariate. Are we simply saying minimum AIC wins? Are there any other considerations? Should we point them at further discussion on the topic?


I think the *z3* binaries can be reused across two APIs. There are z3-java binaries, which would have to be added to Ivy.


yeah, it is


Не хватает блоков с ценой!


Hi there, I just wanted to ask if this is the complete code (no lacking code, no extra code) of the social network series (codecourse)


This looks like a difference that isn't accounted for elsewhere in the spec file? Doesn't %{name} expand to `ocaml-yojson`? will this not break whatever `setup` step is currently there?


Update Oneliner


We need too change a lot of things in order to fix this, everywhere. (Smart gadget and liable)

I received the input to not put the device into the RHTDataPoint, it was included in the past.


This commit provides the front end for the feature


I'm confused

Doesn't this work?

http://twgljs.org/examples/dynamic-buffers.html

On Monday, February 1, 2016, chrislos <notifications@github.com> wrote:

> Hey Greg,
> Hope you're doing well?
> I still haven't been able to get a stable stream realized on
> Safari/Firefox/Chrome + analyze the streamed data with an audiocontext node.
>
> I wrote a request on Stackoverflow.com. But I doubt I'm afraid I won't
> receive an answer there:
>
> http://stackoverflow.com/questions/35132066/javascript-simple-soundcloud-api-example-for-streaming-wont-work-properly-with
>
> Maybe you could give me a tip to get either my first or second example
> that I posted via stackoverflow running?
>
> Thanks in advance.
> greets from berlin
> Christian
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/greggman/vertexshaderart/commit/9e577e1d0de722902c5cce8224db2fd3995adb68#commitcomment-15799568>
> .
>


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13820](https://teamcity.mesosphere.io/viewLog.html?buildId=119751&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:07:49


why not
```
from pybind11 import __version__
```
?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13812](https://teamcity.mesosphere.io/viewLog.html?buildId=119762&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:07:52


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13816](https://teamcity.mesosphere.io/viewLog.html?buildId=119718&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 213 Build time: 00:08:05


Current version is
```
(1, 3)
```


요기도있넹..


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13815](https://teamcity.mesosphere.io/viewLog.html?buildId=119756&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:08:28


Heh, impossible to see the change, due to whitespace ;/


Yup just saw...felt this hashcode was suspicious looking and would create unbalanced hash tables


C Flat = B Natural = 12.


Не хватает заголовка в блока seo


I don't think this is a type erasure issue, because there are no type tests involved.
Seems like a type checking limitation, but I haven't investigated it thoroughly.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13817](https://teamcity.mesosphere.io/viewLog.html?buildId=119753&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:09:27


Hi @kmkolasinski ,
I see you use "ABFloatSlider" delegate for every Float property there but you don't register "ABFloatSlider"  delegate like this:
```
    QtnPropertyDelegateFactory::staticInstance()
        .registerDelegate(&QtnPropertyFloatBase::staticMetaObject
                                , &qtnCreateDelegate<QtnPropertyDelegateABFloatSlider, QtnPropertyFloatBase>
                                , "ABFloatSlider");
```
You will see assert as you saw before:
```
Q_ASSERT(jt != createItem.createFunctions.end());
```

Note, if you want to have some delegate (let say "ABFloatSlider") as default delegate for every Float property in your project - just register it as default delegate:
```
    QtnPropertyDelegateFactory::staticInstance()
        .registerDelegateDefault(&QtnPropertyFloatBase::staticMetaObject
                                , &qtnCreateDelegate<QtnPropertyDelegateABFloatSlider, QtnPropertyFloatBase>
                                , "ABFloatSlider");
```

So you don't have to write "delegate ABFloatSlider{}" in each Float property.


I posted about this github account on my instagram lol https://www.instagram.com/p/BBPwYnksjZm/?taken-by=lettherebecode


should be --data-binary @/path/to/cities, without the equals-sign.


(Also, I would prefer if this was called just ``version.py``). The only purpose of the package is to provide version information, so it's weird to have one "private" member.


not if you create a new tab and paste your link into safari...


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13818](https://teamcity.mesosphere.io/viewLog.html?buildId=119750&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:09:46


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13813](https://teamcity.mesosphere.io/viewLog.html?buildId=119761&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:09:54


because pybind11 is not installed at this stage


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13814](https://teamcity.mesosphere.io/viewLog.html?buildId=119758&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:10:35


the `squarize.py` went fine I think, can you just make sure the `gregoriotex-write.c` one is ok too?


Это не картинка, вставим псевдоэлементом на блок. У каждого seo1 - seo4, будет свой личный псевдоэлемент, а у него будет фоном картинка лежать


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13821](https://teamcity.mesosphere.io/viewLog.html?buildId=119752&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:11:31


@tyfkda You are quite right thanks


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13819](https://teamcity.mesosphere.io/viewLog.html?buildId=119749&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:12:03


Calling it `_version` is pretty common as per comment in #88. (Jupyter, IPython, numpy  etc all use _version. The APi is publicly exposed via `__init__`).


doesn't matter, it works nonetheless (try it! ;))


So this actually got better in newer Android versions and now you need to dumb it down?


Minor: I would reword this commit with a "AP_InertialSensor: L3G4200D: fix coding style", since there's the removal of unnecessary `void` in function declarations as well as extra (not only trailing :-)) whitespaces.


That's it. :)


Yes, exactly and it was not easy to find.

BTW, I flashed by device to KitKat and NetGuard is working properly.
There is just one little thing to fix.


hey you're on my instagram
https://www.instagram.com/p/BBPwYnksjZm/?taken-by=lettherebecode
lol


my bad


Looks better. But is that last test passing for you? If not, what can you learn from the error message?


Please consider using `g_ptr_array_foreach`.


I changed elasticity back to hardness since in these AFM experiments the rupture tendency or something like this is measured instead of elasticity and, if I recall correctly, authors call this hardness.


import java.util.*;

public class TreeSetTest{

  public static void main(String[] args){

   SortedSet<Item> parts = new TreeSet<>();
   parts.add(new Item("Toaster", 1234));
   parts.add(new Item("Widget", 4562));
   parts.add(new Item("Modem", 9912);
   System.out.println(parts);

   SortedSet<Item> sortByDescription = new TreeSet<>(new Comparator<Item>();
    {

      public int compare(Item a, Item b)
      {
        String descrA = a.getDescription();
        String descrB = b.getDescription();

        return descrA.compareTo(descrb);
       }
      });

    sortByDescription.addAll(parts);
    System.out.println(sortByDescription);
   }
 }


The "tuple" part was an old idiom from Python2. I forgot this was the new awesomer version.

Looks good to me.


Comment on MMD was not addressed.


Can't we just write this as:
```
SECRET = hmac.new(_secret, digestmod=hashlib.sha1) if config.SECRET else None
```


br не нужны, переносы расставляются из ширины блока


Hi istvan-hevele,

A proofset with this commit has been created for bluecore-classnames. Just for you!

[View Proofset](https://www.bluecore.com/admin/email_proofs/bluecore-classnames/proof_set/5629499534213120)


add a constructor that takes begin and end as arguments, that way you can fully utilize the speed of emplace_back


Ну, я имел ввиду это)
![image](https://cloud.githubusercontent.com/assets/15049122/12719570/ecf57d70-c906-11e5-9722-957363bff784.png)


I changed this little bit backwards since I think that we sort of do not solve contradictions between simulations and experiments since the binding is still too strong in many models and the reason in not known. On the other hand, I think we solve the question if Na effectively binds or not with the studied concentrations.


at 35:35


plus: reset button will now force reload from server and not from cache


last line


Этот блок и блок .mailing должны идти в обще блоке, опять же float-элементы!


Таблицу сделал, она есть,  но там же надо грузить ajax`ом конкретные мерчанты под конкретные валюты, я еще не писал Dao/Service для этого, оставил пока так. Вместе с версткой тогда прикручу ajax и буду грузить динамически это


Something doesn't smell right here.. You probably want something like:
```
oldfont = fontforge.open(inputfile)
if args.font_name:
    font_name = args.font_name
else:
    font_name = oldfont.fontname
if args.subspecies:
    font_name = '%s-%s' % (font_name, args.subspecies)
newfont = fontforge.font()
```


Тут br не нужен!


А вот тут нужен


No, I think I need both... When I called the close() method on BufferedReader I had to add `throws IOException`...


could this be done with the default case?


Ah yes! Next time :)


Oh ok, I'll check that. Thank you for the heads-up :)


The emulator does not cut it? (yeah they said it get better in AS2 though)


```JavaScript
'use strict';

const crypto = require('crypto');

module.exports = function(data, key) {

  const payload = new Buffer(data, 'base64').toString('binary');
  const iv = payload.substr(0, 16);
  const encryptedData = payload.substr(16);

  try {
    const decipher = crypto.createDecipheriv('aes-128-cbc', key, iv);

    decipher.setAutoPadding(false);

    let dec = decipher.update(encryptedData, 'binary', 'utf8');

    dec += decipher.final('utf8');

    dec = JSON.parse(dec.replace(/\*/g, ''));

    return Promise.resolve(dec);

  } catch (e) {
    return Promise.reject('Failed to decrypt payload', e);
  }
};
```


br лишние!


`b` & `t`?


The !boxes.empty() is not necessary


br


This line looks strange!


Weird! Although it does not work with `python setup.py install` if the cwd is not the one of `setup.py`


[R2R Content Experts.pdf](https://github.com/forkal1/pdfbinder/files/112342/R2R.Content.Experts.pdf)
[R2R Content Experts 2.pdf](https://github.com/forkal1/pdfbinder/files/112343/R2R.Content.Experts.2.pdf)


The emulator will be more than horribly slow on my Acer C720 ...


码主辛苦了，但愿明年我也能进蚂蚁金服啊~~


Hi istvan-hevele,

A proofset with this commit has been created for bluecore-classnames. Just for you!

[View Proofset](https://www.bluecore.com/admin/email_proofs/bluecore-classnames/proof_set/5649391675244544)


No idea. I'll make it `_`.


@AGaliuzov, I see no change in the set_certificate. I've proposed to set the `certificate_exists_ ` to false at the beginning of method.


@shkodm Commit files defining Sampler. (if you started to write them)


У коллекции есть параметры, но нет необходимости писать два раза параметры, в этом случае компилятор сам тип выводит (называется Type Inference)
Подробней об этом - https://docs.oracle.com/javase/specs/jls/se8/html/jls-18.html


`gregoriotex-write.c` merge looks OK to me.


When starting the containerized Origin, we never are able to hit `healthz/` and get a 200. Unclear why this happens. Contents of the container start script straight move from `test-end-to-end-docker.sh`


No, I really meant what I wrote... but your version is probably better yes, changing it


угу


I was thinking about the 'no fallback' thing second time around for a bit. It had me wondering in what cases would `tryAssembleMergedConfig` with a valid set of oldPartials fail. One of the things that I can think of is what happens in case someone renames a stage of an upstream pipeline in main config, but one of the pipelines from the partials refers to the old stage name. I know you have discussed some of these scenarios in the original issue, but I couldn't find us concluding on anything(or may be I missed it somehow). And, amongst all of this, the original issue about cache not reflecting the version of config from config.git repo remains if the tryAssembleMergedConfig fails.


@andyjansson inconsistent indentation here.


Added leaflet webview, removed mapbox.


I'm not worrying about the version of these at all for now.  When we get closer to the M1 we'll update them all to match whatever has been released.  My current headache is that we'll have to update each of these manually each time a new release has come out and we've brought the API up to date.  Maybe that's something that will have to fall to the CC API upgrade tasks...


develop (mjwitte) - x86_64-MacOS-10.9-clang: OK (1505 of 1505 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Why do you keep EllisLab copyright in the new version of the framework?


typo ( floated )


I Have no idea if this is right


![screen shot 2016-02-01 at 10 18 18 pm](https://cloud.githubusercontent.com/assets/234804/12719694/c7a20d6a-c931-11e5-9d4d-0c73f92d44ee.png)

Is it not working for you?


@grawity Please read https://mikaela.info/english/2015/02/24/znc160-ssl.html#comment-2478870466 and my response.

TL;DR I am not telling how the user can do that or mentioning it's possible so I don't feel responsible for user being stupid in any case.


For the version number, I see two tags for 1.0 and 1.1. pypi only has 1.0.
That is why I chose `1.2.0dev`.


In `database.scala` are still some timeout handlings left – on purpose?


поменяй type="text" на type="email"


I tried and it works. Thanks for adding new constructor !


As a suggestion, try to move JS code to a *.js* file and include it where you need it (instead using a ``<script>`` tag). The idea is to keep all layers separated, besides it's going to be more maintainable and it won't bloat your HTML file.


Because that is how the protocol documents are split up: https://otr.cypherpunks.ca/Protocol-v2-3.1.0.html


I don't know.


ah, you are right! The versions aren't so fine-grained though :). The trailing zero can go, and the 'dev' makes things complicated as well (will need to remove each time before uploading to pypi)


Блок с картой должен идти вне блока .container, так как container - ограничивает ширину блока, а карта тянется на всю ширину окна. А внутри блока .map должен быть блок .container


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13823](https://teamcity.mesosphere.io/viewLog.html?buildId=119767&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:03:48


please correct this

"seconds"


ops, skal fjerne console.log


Then a much cleaner workaround is to do:

```
import sys
sys.path.append(os.path.dirname(__file__))
```


Its not a part of this PR, but just noticed that `validate` calls `config.validateAfterPreprocess()`. Preprocessing takes care of inlining of parameters and templates before a validation is done. Does that mean the pipelines defined in config-repo wouldn't allow usage of parameters and templates, or was it just missed out?


Без br, сделаем max-width: сколько надо чтобы текста влезло как на макете


Это token для oAuth2 авторизации. Вкратце все это обстоит так - всякий раз, когда пользователь хочет заплатить через яндекс деньги ему не надо авторизироваться , один раз он проходит авторизацию на странице яндекса, яндекс мне дает токен (у каждого юзера свой уникальный) ,  потом когда он хочет в следующий раз заплатить - у меня есть токен, я посылают яндексу запрос с этим токеном и платеж проходит.
Токен может стать не действительным в следующих случаях:
- Через 3 года он автоматически становится невалидным на сервере яндекс
- Пользователь у себя на странице яндекса может удалить наше приложение из доверенных и тогда токен
  тоже станет невалидным
- Возможно еще есть неизвестные мне причины, когда токен становитя не валидным


I would recommend to replace the above with
```
assert_screen([qw/nfs-firewall nfs-config/]);
if match_has_tag('nfs-firewall') {
    send_key 'alt-i';
}
```
This way you don't need any timeout and actually save time. This is the way a human user would also do: "looking at the screen, I assume the nfs-config OR the other window nfs-firewall and then press a key" :-)


br не нужен


hi


Do we need to cd into src before making, make and then cd ..? We should be able to 'make' from the Nunya directory because it is the top level of the repo containing the .git directory.


Readme  has been edit raz dva tri TestRepo


spam


Right, but there is no need to split it up that way if it makes it harder to understand


import java.util.*;

public class PriorityQueueTest {

  public static void main(String[] args){

    PriorityQueue<GregorianCalendar> pq = new PriorityQueue<>();
    pq.add(new GregorianCalendar(Calendar.DECEMBER, 9)); // G, Hopper
    pq.add(new GregorianCalendar(Calendar.DECEMBER, 10)); // A. Lovelace
    pq.add(new GregorianCalendar(Calendar.DECEMBER, 3)); // J, von Neumann
    pq.add(new GregorianCalendar(Calendar.June, 22)); // K. Zuse

    System.out.println("Iterating over elements...");
    for (GregorianCalendar date : pq)
       System.out.println(date.get(Calendar.JUNE));
    System.out.println("Removing elements ...");
    while (!pq.isEmpty())
    System.out.println(pq.remove().get(Calendar.YEAR));
   }
 }


Okay, last update. I just went to the professor's office hours and the diagram in my original comment is the correct one.

![](https://cloud.githubusercontent.com/assets/5253312/12703997/ed9bec16-c81e-11e5-8c9b-b8ab53abecb4.png)

I was initially confused because I thought in order to have bids be deleted when a user or auction gets deleted, we had to store the Bids as a weak entity set; but this is not the case. By using this diagram the bids will still be deleted from the relationship because it will use UserID and AuctionID together as a primary key. This makes it a lot easier.


It could be worth adding a release.md file with instructions such as

- Update `_version.py` (set release version, remove 'dev')
- `git add` and `git commit`
- `python setup.py sdist upload`
- `python setup.py bdist_wheel upload`
- `git tag -a X.X.X -m 'comment'`
- Update `_version.py` (add 'dev' and increment minor)
- `git add` and `git commit`. `git push`. `git push --tags`.


See bugzilla report 409


br не надо


I know it's unrelated but why do you know why we need an `assert` here?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13822](https://teamcity.mesosphere.io/viewLog.html?buildId=119763&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:07:37


Ok, I didn't know that assert_screen can do multiple tags!
I'll test and commit.


Well, I would love to upgrade, but as far as I know there are binaries that
carry glib 2.14 and it proved difficult to upgrade on AIX and HP-UX.

I think the best way forward would be to create/fork a minimal version of
glib that is more portable than stock glib (and phase that out with time).
On Feb 1, 2016 2:51 PM, "juhaszviktor" <notifications@github.com> wrote:

> As we talked with @bazsi <https://github.com/bazsi>, we shouldn't use
> g_ptr_array_new_with_free_func because it brokes the compatibility with
> older glib versions
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/balabit/syslog-ng/commit/549e719b0ed31589fbcc64352a2d63ff9e474b1f#commitcomment-15799342>
> .
>


Тот же принцип как и в верху, без br


LGTM


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1524 of 1524 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


here's a video that shows the bug:
I made a small quicktime screen recording:

http://christianlosert.com/test/01/error.mov


> [...] the 'dev' makes things complicated as well (will need to remove each time before uploading to pypi)

pip knows that the dev suffix makes it lesser than just the version info.


à ajouter à toutes vos pages, c'est pour l'icône du menu hamburger


@steffengy is this related with #1173?


Это не button, а тег a


@niks255 do you have a logcat and installation debuglog for me?


@ggouaillardet looks good, thanks!. :+1:


did you migrate these new api fields back to the old api just to move the files?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13824](https://teamcity.mesosphere.io/viewLog.html?buildId=119768&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 220 Build time: 00:10:03


Sir grade assignment bhi change krni thi
On 01-Feb-2016 6:41 pm, "Hemant" <notifications@github.com> wrote:
>
> Guys please check if any API is broken or not working! Because i have
modified server code a lot
>
> —
> Reply to this email directly or view it on GitHub.


Все input обернуть в label. br- убрать


ok, works for me too.


no the only difference is that this prevents garbage collection of target=origin associations.
Same code in different order


Wow, it was cleaner than I could imagine!


Возможно я здесь что-то менял с полями класса, и заново сгенерил геттеры/сеттеры, поэтому конструктора нет
Компилятор создает сам конструктор (default constructor) с пустым телом и списком аргументов,  но если есть еще один какой-то конструктор,  то в этом случае компилятор уже ничего не генерирует. Это не только в Java так, в С++ и C# компилятор делает тоже самое.


I don't have it right now, but I will provide it later. I also think there's a workaround for that - to replace these libs with ones from google keyboard apk.
I'll test everything.


Ok, sounds good


+1 for the release.md (maybe in 'docs'?)


Great :+1:. I do not really understand why this is faster. Could you explain it to me? I always thought `foreach` would be faster than `for`. Initialising the ArrayList with the correct size seems reasonable. This is probably saving some time.


Thanks!  I fixed it now.


@shucknjiveturkey DWMR of #24 and #25. Good. Press ahead.


Because it will fire if ref/unref calls are not balances, abd can uncover use-after-free cases.


@Please review


@flavour

A sample of json

```
[{
status: "Draft",
identifier: "Biplov--20160131-047-alert",
sender: "Biplov/10",
msg_type: "Alert",
cap_info.certainty: null,
cap_info.event_type_id: 25,
cap_info.category: [
"Met"
],
cap_area.name: null,
cap_info.headline: [
"ျမစ္ေရႀကီးျခင္း သတိေပးခ်က္ (မေကြး)",
"Flood Warning in Effect for Magway City"
],
cap_info.priority: null,
cap_info.urgency: null,
scope: "Restricted",
cap_info.severity: null,
id: 47,
sent: "2016-01-31 06:25:03"
}]
```
Everything seems to work but I still have cap_info.event_type_id: 25, id here instead of name.
The default event_type_id has translate=True

What is the problem here?


Картинку обернуть ссылкой


There is no inherent issue, but on the other hand I also don't see a reason for it to be there at all. But it shouldn't matter like that.


Так же значок можно вставить через псевдоэлемент!


> Does that mean the pipelines defined in config-repo wouldn't allow usage of parameters and templates.

Yes. I excluded parameters and templates support in configuration repositories. First reason is that user may just implement his own way of templating pipelines now with a proper plugin. Second is that I wanted to reduce the amount of work to make #1133 happen.

You should know that this line is an error anyway. It is fixed [here](https://github.com/tomzo/gocd/commit/abfd957fba27eee5d75c07bd3fe586a7d4b60ffe) as part of #1810 PR.
I tried without preprocessing on my production server where we have a lot of parameters and templates. Since this is actually validating at global, merged scope, it was simply failing on all parameters not being expanded.


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Oh thanks Tim! I'll have a look at it when I'm home! :)


Если посмотришь, то на второй странице тоже есть эти же контакты. Они должны идти в теге header


Нет необходимости писать public в интерфейсах. Все методы в интерфейсе public и другими быть не могут, как и поля в интерфейсе -  только public static final. В Java 8 методы еще могут быть default и static.


So now the config API is similar to the Bukkit config functions? Nice! (Well, now I won't confuse get() with getNested())


ok, will update the PR with the other changes, the release.md and only have a MAJOR.MINOR version number.


Yes, it should only be set when it will be linked with PIC code.

Here is a test to see what GCC does:

### main.c
```
int main(int argc, char **argv) {
#ifdef __PIC__
#warning "PIC"
#endif
	return 0;
}
```
### With PIC (enabled by default for MIPS)
```
debian-mips:pic-test james% gcc -c main.c -o main.o
main.c: In function ‘main’:
main.c:3:2: warning: #warning "PIC" [-Wcpp]
 #warning "PIC"
  ^
debian-mips:pic-test james% readelf -h main.o
ELF Header:
  [...]
  Flags:                             0x70001007, noreorder, pic, cpic, o32, mips32r2
```
### Without PIC
```
debian-mips:pic-test james% gcc -c main.c -o main.o -mno-abicalls
debian-mips:pic-test james% readelf -h main.o
ELF Header:
  [...]
  Flags:                             0x70001001, noreorder, o32, mips32r2
```

I also performed the following test:

```
debian-mips:pic-test james% cat prog.c
extern int ret;

int main(int argc, char **argv) {
	return ret;
}
debian-mips:pic-test james% cat data.c
int ret = 0;
debian-mips:pic-test james% gcc -c data.c -o data.o -mno-abicalls
debian-mips:pic-test james% gcc -c prog.c -o prog.o -mno-abicalls
# Hex-edited data.o to set the CPIC flag
debian-mips:pic-test james% readelf -h data.o
ELF Header:
  [...]
  Flags:                             0x70001004, cpic, o32, mips32r2
debian-mips:pic-test james% readelf -h prog.o
ELF Header:
  [...]
  Flags:                             0x70001001, noreorder, o32, mips32r2
# This is now similar to having poly compiled without PIC, but dropping the #ifdef so polyexport.o has the CPIC flag
debian-mips:pic-test james% gcc -o prog prog.o data.o
/usr/bin/ld: prog.o: warning: linking abicalls files with non-abicalls files
```

It seems therefore that CPIC should be set if and only if it will be linked with PIC (abicalls) code. Digging around in binutils reveals that the test for whether a file is abicalls or not is `(flags & (CPIC | PIC)) != 0`, and the warning is given if the boolean value is different for two input object files (https://sourceware.org/git/?p=binutils.git;a=blob;f=bfd/elfxx-mips.c;hb=a0a1bb07cb2c03b7d34f12e734c6f363ddb7c7b2#l14693).


Картинка не нужна, она вставляется через фон. Нужен только текст "ХИТ"


Цена не картинка - это текст


@AByzhynar see https://github.com/LuxoftSDL/sdl_core/commit/b3a34885c3b3354483e65762a5aad73abd3e7058


I am not always fond of the foreach functions as they are generally not typesafe and the for loop itself is readable enough in case we iterate through all items. If c had closures a foreach would be great.

At this site foreach could be used however the best solution would be to use the with free function
Variant of gptrarray.


……下次更新前可不可以验证一下……把我吓得半死以为移动开始劫持HTTPS了……
另外用美东代理也是证书错误……应该不是中间人


Каждому seo-content - добавь уникальный класс, чтобы мы к нему привязали псевдоэлемент с картинкой


.seo-text назначь для тега p, а div убери - он лишний


I don't see a problem with this module re-using existing functionality in the main codebase - but I we should make that main functionality reusable, instead of hidden inside a controller / action. Extracting this functionality into a callable method makes most sense, then both the controller action, and this action right here can call that method which will execute the logic.


Note that this line makes the next `coding` ineffective.
`coding:` must be placed at the exact first line except for shebang.
`frozen-string-literal:` can be anywhere before any tokens except for white-spaces and comments.


This is faster because applies is called extremly often and although the JVM optimizes the string appending into a StringBuilder but it still creates too many temporary objects giving the GC too much work. We can easily reduce that when we append this in the constructor. Furthermore we use the normal style for the loop which avoids creating the iterator object on every call.


Небольшие комментарии тут. В основном на предыдущем коммите


We're still duplicating the code. It's much better than before but maybe we could use http://foundation.zurb.com/sites/docs/v/5.5.3/components/block_grid.html to not duplicate:
```erb
<% emoji_name = "emoji-#{name}" %>
  <div>
    <div class='emoji-container emoji-container--inline'>
      <div class="emoji <%= emoji_name %>"></div>
    </div>
    <span style='margin-left: 25px'> .emoji-<%= name %> </span>
    <span style='margin-left: 25px'> .<%= emoji_name %> </span>
    </div>
 <% end %>
```


Тут основные замечания, немного на следующем коммите


1. Fix typos and formatting in `READ` me. It is important that we start paying attention to details like that. Your future employers might be visiting your GitHub account to form an opinion about the quality of your work.

See this resource about the importance of a good README: https://www.reinteractive.net/posts/137-on-the-importance-of-a-readme

And this discussion on the importance of GitHub in recruiting: https://www.quora.com/Can-GitHub-be-used-for-recruiting

2. In the future, make sure your commit messages are better than `ok` or `changing` or `completed` The commit message should reflect what you have done/what changes you have implemented. I've shared this with you earlier but please read this article again: http://chris.beams.io/posts/git-commit/


I'd bump the deadline to something like 24h


:+1: Good catch and good job, @kurisubrooks !


Would it work with a closed connection too? It could be useful (if a connection dies, a generic function may create a new one similar)


@nobu please don't comment on commits? Either open an issue or a pull request


Please keep this comments, it helps other guys can use if they install browsers the custom location


`valid_for` is less than `deadline`, can you make them the same?


Jetzt aber


There is an error with this change.
The parameter this.A cannot be used now as it should be  a / 255f if we are not going to use the backing vector. Maybe using a local Vector4 variable instead would be best?


А как же Icon Cache?


Please do not change the format


@panladen 哥哥， 完全没技术含量。


Ah ok. That makes sense.I did not considered that we create new Strings at this point and therefore clutter the RAM. Thanks for clarification.


use `console.error()` and log the error too :)


Congrats! You have really get the point.

This is the kind of pattern that we should cut from beginning (as you did here). At our code base we still have examples of it.


Please use the default email I have used in the scripts, your email is secret.


Again, please do not change the format


Please help me create a variable to compare at this point


There's WKPreferencesSetFullScreenEnabled.


Missing `;`


Заменил анонимный класс на lambda-expression который появились в Java 8. Вообще необходимо будет это вынести в модуль JDBC


The name implies a const function. if it's not, maybe change the name to "calculate_element_content_size" ?


Does not make much sense to calculate a fall-back in case of empty reference since it means current resource.


I have doubts regarding this being the right class to inherit from WebFullScreenManagerProxyClient.


I now realise we should use `day` :)


Cool to see this, thanks Una!


I see this pattern a lot in this code: push_back + set_parent. You might want to make a function for this


cut & paste from two lines before, saw it but forgot to fix it. will do.


Noted, but most times describing a changed may take a sentence yet brief words can save time and look short and precise, what do you say about this?


As suggested by @jongiddy, a way of verifying that it works is to check we are getting back a dictionary.
Right now, we don't have any extra validation for the JSON output. It would be a nice thing to add, but it is out of scope for this PR.


`cluster_nodes` is (semantically) a list: do we support multiple values for it at the moment?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 13825](https://teamcity.mesosphere.io/viewLog.html?buildId=119770&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 215 Build time: 00:04:44


@v-sky 唉？好久不见呐。


Since you will not use this vars later...
```php
$user   = JFactory::getUser();
$groups = implode(',', $user->getAuthorisedViewLevels());

$query->where('t.access IN (' . $groups . ')');
```

why not just:
```php
$query->where('t.access IN (' . implode(',', JFactory::getUser()->getAuthorisedViewLevels()) . ')');
```


done.


These calls should be invoked via WebFullScreenManager in WK2.


Can't his be a static method. That way you only need:
```php
JHelperTags::getItemsTags('com_content.article', $articleIds);
```


Same, these calls should be invoked via WebFullScreenManager in WK2.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/26943/testReport/) for this commit**


all these getters don't really "get", the "calculate". If you use that as the function name, you will be more careful that you cache the value of this function instead of calling it twice


In relay's connections, the variable name is `first`.


I also only found out about this problem via yourkit profiler as the world wide import was killed by the OS again and again although there should be more than enough RAM (20gb more than previsously needed!) and the OS killed it due to heavy CPU utilization due to the GC I guess.

Normally one should program defensive. But not too defensive and with lots of premature optimization to develop and iterate fast and then optimize later on with a good profiler ;)


Is the value of gpio_nums known at build time? If so, you could calculate MAX_GPIO_DEVICES staticically instead of using a fixed value (which wastes some memory). This method might require you to define a macro to wrap the call to `pl061_gpio_init()` (a bit like `sp804_timer_init()`).


Thanks for your help !
This patch doesn't included README.md and USAGE.md modification that explain this new option.

Can you take it into account before I include this patch, please ?

Thanks by advance,
Jean-Marie


@aofall 那么你们几个讨论的结果是什么？我们还更新不更新了？不论怎样，我感觉我有必要立即去 废掉/rollback 这次的更新，看起来已经造成极度恐慌了。


Nit: s/first/most recent/


> amongst all of this, the original issue about cache not reflecting the version of config from config.git repo remains if the tryAssembleMergedConfig fails.

I know that this solution is not perfect. And as you mention, there may be a few corner cases where *fallback merge* will fail. I doubt that these are significant. I am currently trying these changes out.

There is a lot of talking in #1133 and not that much conclusions. Intended behavior is mostly discusses [here](https://github.com/gocd/gocd/issues/1133#issuecomment-113286221) and next few reponses.
@jyotisingh If you have a big picture of how merge behavior then please post it.

Current implementation is best what I we could we think of then. I came up recently with this *fallback* action, which obviosly improved user experience when there are errors in merged config.
There was (is) another option for handling merges which is more capable of dealing with failures - you can find it [here](https://github.com/gocd/gocd/issues/1133#issuecomment-113434619) under "Best solution?" I did not implement it mostly because of extra work required.


@aofall 比如 #199 ……


This should be

```
<% if policy(@comment).new?
```

You want the policy to reflect the actual action that is being taken so if you need to change the permissions for a new comment later you just have to change the comment policy file and not the view templates.


Agree. Infact, that was quickly copied code from getItemTags method to show my propose


Verified to fix #339


It could not. The reason is because inside the method there is a command **$this->getCurrentLanguage();**


Uninitialized data is already zero - don't need to init again.


LGTM


The absence of one/both will cause warnings.


@K-Guan 前几天刚刚考试完，最近准备折腾折腾Almura/Spoutcraft。


Por favor hacerlo también todos los archivos html del raiz y en el index de eventos/PyTatuy2016


please remove this (no queue urls, this is a public repo)


и "им**п**лементаций"


Since the value is always a multiple of the array index, there is no need to store this in a variable. It can be easily calculated when needed.


@v-sky 这都快过年了才考试？那么祝顺利，话说我最近因为要过年也是忙的够呛的。