O novo fix para o bug de dupe consiste em alterar o TDATA4 dos itens de type t_container, pra impedir que qualquer item jogado dentro do container caia em posição x=0.
TDATA4=00 impede que os itens caiam na posição x=0 dentro do container.
Essa correção se repete em todos os itens abaixo que são t_container


What are those parameters to be passed ?


Why don't you delegate this into prototype?


+1 for a quick release!


empd (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1550 of 1550 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.78%25-green.svg)


Umm, I would say it won't be bad, if we simulate somehow a real behavior. For example, ```
```
happen.keyup(document.getElementById('editable'), {keyCode: 9});
```
should simulate a `tab` in the editable area, which is what the user will normally do.

What about this approach?


The TransferSpammer() in the README.rst doesn't implement these methods.


!roboplus


Better solution from @FilipNest . closing.


I am thinking about a copy-on-write principle here, so that you don't need to do expensive collections copying in a merge where the registered operations groups are the same (I guess that will be a common case). Also, when serializing the data, it could be sent only once.


Perhaps call it DEFAULT_ELASTICSEARCH_IMAGE to make it clear we expect an image that only has ES in it


In that case why don't we apply it on jethro too?


Would be nice to understand what is going on.


This commit changed the line-endings on a pile of files again.

Could we please get guidance as to what the line-endings and file formats should be on all files in this project so that we're not constantly spamming the commit log with whitespace changes?

Sorry to be pedantic, but it's (a) hiding the actual changes, and (b) stuffing up merges into my own working branches.


Shall we remove the TODO and create a separate issue for this?


为什么这里乱码了？？？？？


I can see your point. You'l see an updated pull request shortly.


Closes #7.


asdfasdfasf


LGTM


Yes, I understand. I just merge some of your changes in dev branch but for
the --since option, and why not, --until too, I prefer to integrate more
deeply both options for a better fit into the ouputs. I'm working on it,
maybe in a some days I will have something done.

Thanks!

2016-02-18 10:29 GMT+01:00 Thomas Hirsch <notifications@github.com>:

> Ok, then I am wrong, actually, I misread it to be the shutdown time.
>
> My idea was to return all entries which take place during or after the
> given timestamp, then subtract an offset if the first entry has started
> before (timestamp - start time of first entry).
>
> Should it be 'where btime + uptime > %i' ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/relet/tuptime/commit/1cbfe49dea5af32a9c2a769326b310d51e27857c#commitcomment-16170523>
> .
>


Faltava um "." em "LOCAL.type"


Ah, haven't noticed this PR is for 2.x


Nice catch. Fixed in e7b0978a76af41bb21476f1937cefd3d9786f089


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16243](https://teamcity.mesosphere.io/viewLog.html?buildId=138201&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:09:36


inline


This should now be correct, all of it should be inside the `if self._per_bin` statement, as we only want to update if we are need to store the `per_bin` information (i.e. using a full `Summary` instance not `ReducedSummary`). However it shouldn't have been inside the other if statement, as we *always* want to update the `min_per_bin` values.


@vinamelody typo: "follow **these** steps"


Hi, sorry. I had replied on the other thread.

The images can be found here:
http://imgur.com/a/7t9dS


miss ``` code is bad formatted here


ack


True

Sent from my iPhone

> On 18 Feb 2016, at 09:31, Nicolas Grekas <notifications@github.com> wrote:
>
> that's mkdir's default already, and it's affected by the current umask()
>
> —
> Reply to this email directly or view it on GitHub.
>


Since we run jasmine in the same process as this script, and it doesn't provide the mechanism of passing modules/variables to the tests, the only way I see is the global variables.


maybe we should change it to   step: '=cheStep'


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.590.8515507208c1539220ebee854cf5e7e479e1de6d](http://build.palaso.org/viewLog.html?buildId=69319&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 931, ignored: 56 Build time: 00:18:06


@vinamelody the initialise step is not necessary for someone who wants to contribute, only for you when you set this up for the first time. you can remove this step.


why not here @AbdealiJK ?


@andyjmaclean Does this really belong in the Collections site code? Shouldn't it be in the styleguide?


isn't it better to leave them all out by default? When you have an error that's a good incentive for developers to ask themselves "why do we need this specific rx operator"?

Now we're just including a whole bunch we really don't need


you cherry picked this commit from somebody else, please keep the author info in that case.


unack


But  `ReportAllTheThings` does implement `on_b_dial()`. I'd like to have on_event on the reporter, so that you don't have to work with the ChannelManager if you'd ever want to do something with (user)events.


LGTM


tohle by mělo být v meta


Mudado a maneira como o "Charge" dos npcs funciona.
Antigamente mexia diretamente na dex do alvo, fazendo ele se mover mais rapido, e causava um dano baseado na stam extra que era consequencia da subita redução apos o aumento de dex.
Atualmente, aparentemente, o sphere corrige a stam do alvo impedindo que aconteça um dano extra com base na stam alem do maxstam, deixando o charge apenas com um boost de velocidade.

No novo modo, troca-se a variação da dex, pra uma variação direta no moverate via tag.override que joga o mob pra categorias de velocidade diferentes por instantes, alem de dar um boost de dano via tag.moddam por um breve momento.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16245](https://teamcity.mesosphere.io/viewLog.html?buildId=138206&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:18


thanks, I'll fix this soon


does this definitely raise OSError untilo down to 3.3? IIRC there was some problems with that but now that we've dropped 3.2 it might be that easy actually..


Why not use standard erpnext function?

You should move `set_balance_in_account_currency()` function outside class and there you need to pass company_currency and conversion_rate as argument.


true


Make it readonly


ack


hmm smart form už dědí z rest formu :)


agressão com ç foi feio demais poutz.... rsrs


With these changes can https://github.com/c2corg/v6_ui/pull/13 be closed?


if these changes truly do cause problems in the tests then i will revert them. You can do it yourserlf if you want when you create the PR for the password issue.


though if that's a systemexit why do we catch the exception then anyway just to rethrow it in get_exitcode?


unack


Apenas arrumando os "dmg" pra "dam". Aquela velha historia de não existir mais dmg.


Could you please reserve Callback's method which in beta3?Interface Callback could have override method,onResponse(Response<T> response) and onResponse(Call<T> call, Response<T> response).OnFailure method,too.


Arrumando "dmg" pra "dam"


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16244](https://teamcity.mesosphere.io/viewLog.html?buildId=138205&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:08:56


arrumando "dmg" pra "dam"


commented on your PR


TeamCity LabKey :: Trunk :: Community :: CDS postgres 9.5 [Build 104](https://teamcity.labkey.org/viewLog.html?buildId=304148&buildTypeId=LabkeyTrunk_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 10, passed: 40 Build time: 01:17:54
### Failed tests
```
org.labkey.test.tests.CDSHelpCenterTest.verifyHelpCenter: <no details avaliable>

org.labkey.test.tests.CDSSecurityTest.verifyUserPermissions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisFilter: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

```


you can remove this variable, it is pointless.


After making this changes in accounts_controller, send a PR


akorát bude horší, že když to bude v meta tak se to bude hůř dynamicky nastavovat. Tak to budu muset dynamicky nastavovat už ve view a pak vytvářet přes smartform factory


LGTM


should also clean up the created `tmpdir` - maybe via `mktempdir() do tmpdir` would be convenient?

and the PR needs a rebase, looking good though


ผมลืมแก้ คำพูดอะ กรุณาใส่จำนวนเงิน, กรุณาเลือกรูปภาพ, กรุณาใส่เลขที่ใบสั่งซื้อ


You have saved the day!


Maybe we can inline it ?


+1 for this patch


Hey guys, I have just found your work here yesterday and I am very glad i did in the first place. However i am having problems getting this daemon to work.

milorads@milorads-Inspiron-5737 ~ $ xinput list
⎡ Virtual core pointer                    	id=2	[master pointer  (3)]
⎜   ↳ Virtual core XTEST pointer              	id=4	[slave  pointer  (2)]
⎜   ↳ Razer Razer Naga 2014                   	id=11	[slave  pointer  (2)]
⎜   ↳ SynPS/2 Synaptics TouchPad              	id=15	[slave  pointer  (2)]
⎜   ↳ Razer Razer Naga 2014                   	id=10	[slave  pointer  (2)]
⎣ Virtual core keyboard                   	id=3	[master keyboard (2)]
    ↳ Virtual core XTEST keyboard             	id=5	[slave  keyboard (3)]
    ↳ Power Button                            	id=6	[slave  keyboard (3)]
    ↳ Video Bus                               	id=7	[slave  keyboard (3)]
    ↳ Power Button                            	id=8	[slave  keyboard (3)]
    ↳ Video Bus                               	id=9	[slave  keyboard (3)]
    ↳ Laptop_Integrated_Webcam_HD             	id=13	[slave  keyboard (3)]
    ↳ AT Translated Set 2 keyboard            	id=14	[slave  keyboard (3)]
    ↳ Dell WMI hotkeys                        	id=16	[slave  keyboard (3)]
    ↳ Razer Razer Naga 2014                   	id=12	[slave  keyboard (3)]
milorads@milorads-Inspiron-5737 ~ $ xinput get-button-map 10
1 2 3 4 5 6 7 11 10 8 9 13 14
milorads@milorads-Inspiron-5737 ~ $ xinput get-button-map 11
1 2 3 4 5 6 7
milorads@milorads-Inspiron-5737 ~ $ xinput get-button-map 12
device has no buttons

Is it normal for the 12 to give me the no buttons? I am programmer but i am pretty new to this kind of stuff . Was also thinking of creating graphic application for creating mapping file (java) since i think that this can be very helpful to people in general.


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.183.f9da1d43342ec8300d8bcaf9f729540eb49b66ca](http://build.palaso.org/viewLog.html?buildId=69335&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 944, ignored: 50 Build time: 00:38:31


```python
# Jika Location ID adalah Head Office
				if val.location_id.id==12:
					qty = product.qty_available
				# Jika Parent Location ID adalah Head Office
				elif check_loc.location_id.id ==12:
					qty = product.qty_available
				# Jika Location Merupakan selain Head Office
				else:
					if not context:
						context = {}
					context['location'] = val.location_id.id

					product_context =self.pool.get('product.product').browse(cr, uid, x.product_id.id, context=context)
					qty = product_context.qty_available

```

if location id ==12 ga perlu,, dan juga itu static,,,


This should be a class method


If the favicon actually shows up for mobile and desktop devices, I would say yes.


Looks good. thanks @gkm4d


Add a docstring please


Yassss lol


Doh! Sorry.


Docstring (or later)


to 靜怡:

補上以人為單位的明燈數, 依不分盤口/國際/運彩盤來分, 請看下表:
舉例說明:
假設我們想把國際運彩盤合併,並以人為單位想要限制明燈的數量,
那把明燈上限設成178個明燈數量, 即可滿足站上99%的使用者需求


:tada:


You know, I had a thought like this shaping up, but it didn't make its way to the main brain :-).


Add simple validation for known flags.


ha, I was looking for this issue!
I think it can be closed.

On Thu, Feb 18, 2016 at 10:46 AM, Tobias Sauerwein <notifications@github.com
> wrote:

> With these changes can #13 <https://github.com/c2corg/v6_ui/pull/13> be
> closed?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/c2corg/v6_ui/commit/d60b4ef26eea55580811851acc3b898af8bf8f82#commitcomment-16170870>
> .
>

--

*Adam Gina*JavaScript Developer
adam.gina@camptocamp.com

*Camptocamp SA*EPFL Innovation Park
Bâtiment A
1015 Lausanne

Tel + 41 21 619 10 10
http://www.camptocamp.com


@sinisterstuf thanks for the script, you may want to allow more than one graphic card (i.e. on Lenovo ThinkPad W541).


Add simple validation for known versions


@acalabro  coule you please keep trace of the error stack.
please change this with something like:

throw new LpMonRestException(e.getMessage(), e.getCause());


XD


Can we make it ImagicalMine not ImagicalCorp :)


Ensure that the version is 1


If we're overriding a base class config value add an appropriate comment for this


this is a comment here


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16246](https://teamcity.mesosphere.io/viewLog.html?buildId=138224&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:08:48


close #440.


update


Why have the `consumed` flag? Why not just call `self.vec.set_len(0)` directly here?


Maybe we want to explore adding list support here so that lists are well-defined and behave the same across various config variables.


Empty newline


@sils1297 this was some weird problem with logilab right ? where we had to re-install astroid or something ?
This command wont be doing anything because astroid is already installed as part of logilab-common (which is a dependency of pylint) in `requirements.txt`


Wiki has the first exercise! sorry it's boring but it got be the hello world? As always!


ack


Validate as an enum


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.591.f9da1d43342ec8300d8bcaf9f729540eb49b66ca](http://build.palaso.org/viewLog.html?buildId=69336&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 932, ignored: 56 Build time: 00:15:50


Sure :)


Not sure about how to run validation on this one but I'd like to see some.


Alright, just wanted to check as this project is zealous to avoid potential redundant commands. Thanks for the rationale.


[![Dear America: To Thee We Sing](http://api.artsmia.org/images/121574/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=121574)


[![Saint Catherine](http://api.artsmia.org/images/136/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=136)


[![Large-Leaf Verdure Tapestry Fragment with Birds](http://api.artsmia.org/images/14154/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=14154)


Decision Tree Classifier


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16352](https://teamcity.mesosphere.io/viewLog.html?buildId=138999&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:03:31


License-Fixes-For-8.5 (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Switch Statement in CSharp

using System;

namespace IntroductionToCsharp
{
    class Program
    {
        static void Main(string[] args)
        {
            Console.WriteLine("Please enter a number");
            int UserNumber = int.Parse(Console.ReadLine());

            switch (UserNumber)
            {

                case 10:
                    Console.WriteLine("Your Number is 10");
                    break;

                case 20:
                    Console.WriteLine("Your Number is 10");
                    break;
                case 30:
                    Console.WriteLine("Your Number is 10");
                    break;
                default:
                    Console.WriteLine("Your number is not 10, 20 & 30");
                    break;
            }
        }
     }
}


In any case, I do like the improved readability of the optimistic switch w/retry on CAS error approach, I'll change it.


looks cool


I suppose this just remove warning.


Checking whether Q.nextTick.runAfter exists should suffice, I think.

Q does provide a unhandledRejecion event in Node.js. We could add a Q.onUnhandledRejection hook. Of course, PR welcome.


The following doc(s) have been deployed to the [1130gitre](http://1130gitre-static-docs.pantheon.io/docs) Multidev environment:
- [app/config/sculpin_site.yml](https://github.com/pantheon-systems/documentation/commit/60a85d95b84bbb876764a2f3532bb1f6e937b845/app/config/sculpin_site.yml)
- [docs/articles/local/git-faq](http://1130gitre-static-docs.pantheon.io/docs/articles/local/git-faq)


This didn't change recently I think. Probably this file is whitelisted. test_flake8.py should run in the daily buildbot.


`Whisper.SettingsView` was not included in this commit.


using System;

namespace IntroductionToCsharp
{
    class Program
    {
        static void Main(string[] args)
        {
            Console.WriteLine("Please enter a number");
            int UserNumber = int.Parse(Console.ReadLine());

            switch (UserNumber)
            {

                case 10:
                case 20:
                case 30:
                    Console.WriteLine("Your number is {0}", UserNumber);
                    break;
                default:
                    Console.WriteLine("Your number is not 10, 20 & 30");
                    break;
            }
        }
     }
}


113837367-Fanger-PMV-Equation-Bug (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (2099 of 2099 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


wtf
@ledosladoledi uploaded this
How did you get my account, shit


LGTM.


Hum, I just had a quick look at the `gtk_menu_popup()` code and it looks like the button isn't really used for anything else than enabling a so-called "keyboard mode", which seem to simply show mnemonics.  So I guess it's not important.


Why would it check in the plugin folder and root directory? Would be better to check the specific plugin's directory instead, where the config is located.


YaYY!! http://www.nycwasteland.com/addMagazineTurret.png


Ahhhh, that makes sense. I misread "component" as "controller" and got worried that there might have been something wrong going on.

Back in the day, I had to make a really risky commit that I was pretty sure would break the code, but a supervisor told me to make it. I made sure to mark the author name as "d_vader" in case some exec lost his mind and wanted to chop heads before we could patch a fix. Turns out the commit never broke a thing, and I'm pretty sure that Darth Vader is still attributed in the source code.

Anyway, looks like you guys are making good progress.


SCC members should be able to view all documents.


No it fixes a crash because DownsampleFactorMaxGrad is not in pool, only in downsample.


**SUCCESS** - TeamCity HotRod C++ Client :: Pull requests monitor - RHEL [Build 424](http://ci.infinispan.org/viewLog.html?buildId=36032&buildTypeId=HotRodCpp_PullRequestsMonitorRhel6&guest=1) for bf441d2d8447b64a331912596c9244418206964c
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:10:52


I tested with scipy 0.11.0 (oldest dependency supported by Theano and it was returning a sparse matrix.


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


It does run daily and this error just showed up in the last run.  It may have something to do with the recent stack update.


<3 IT BECAUSE I LOVE CAPS


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16353](https://teamcity.mesosphere.io/viewLog.html?buildId=139037&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:03:46


I build the project using Assignment1 as well, not sure if we are suppose to use Assignment2 or not but it builds correctly on Assignment1.  Anyone else has thoughts on this?


Except it started failing with scipy 0.17.  If you use an older release the test pass.


that is a good explanation. Can you update the dependency installed in
travis?

On Thu, Feb 18, 2016 at 7:15 PM, abergeron <notifications@github.com> wrote:

> It does run daily and this error just showed up in the last run. It may
> have something to do with the recent stack update.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/abergeron/Theano/commit/41607d78b3614230b9b148c8c42d9b4e80ae9948#commitcomment-16192151>
> .
>


Why is this not `def redirect_back(fallback_location, **args)`?  Why the `fallback_location:` with the `:` after it?


One more `subscriber_config` call here.


I don't see any test failures.

    $ git branch
      commonmark
      images
    * linebreaks
      master
    $ git status
    On branch linebreaks
    Your branch is up-to-date with 'origin/linebreaks'.
    nothing to commit, working directory clean
    $ dart common_mark_stats.dart
                            Tabs   3 of   6 –  50.0%
                      Precedence   0 of   1 –   0.0%
                Horizontal rules  12 of  19 –  63.2%
                     ATX headers  11 of  18 –  61.1%
                  Setext headers   7 of  20 –  35.0%
            Indented code blocks   6 of  12 –  50.0%
              Fenced code blocks  16 of  27 –  59.3%
                     HTML blocks  18 of  42 –  42.9%
      Link reference definitions   2 of  23 –   8.7%
                      Paragraphs   4 of   8 –  50.0%
                     Blank lines   1 of   1 – 100.0%
                    Block quotes   1 of  25 –   4.0%
                      List items   4 of  45 –   8.9%
                           Lists   0 of  24 –   0.0%
                         Inlines   1 of   1 – 100.0%
               Backslash escapes   7 of  13 –  53.8%
                        Entities   4 of  12 –  33.3%
                      Code spans   9 of  15 –  60.0%
    Emphasis and strong emphasis  71 of 129 –  55.0%
                           Links  35 of  79 –  44.3%
                          Images   1 of  22 –   4.5%
                       Autolinks   3 of  16 –  18.8%
                        Raw HTML   4 of  21 –  19.0%
                Hard line breaks   8 of  15 –  53.3%
                Soft line breaks   1 of   2 –  50.0%
                 Textual content   3 of   3 – 100.0%
                           TOTAL 232 of 599 –  38.7%

Are you seeing something different?


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#LBEpvqgbSoe3tyGUCUDH-w


You you got memed dude. Face it, you're bad. :^)


I'm not the one who coded it so I have no clue. I'm pretty sure it's not checking the plugins directory though.


Use struct instead of class if everything is public.


The default game is the English version. Just adding a new Spanish game button allows us to change as few lines of codes as possible. Good idea!


Thank you!


This looks great. It's very clear


i did what u told me to


if you used an OrderedMap keyed on id instead of an OrderedSet, this could become more simply:

```
return state.update(id, win => win.merge({ x: roundX(x), y: roundY(y) }))
```


With ordered Map this would become simply:

if you used an OrderedMap keyed on id instead of an OrderedSet, this could become more simply:

```
return state.delete(action.data)
```


I suppose it will be changed, but not sure when.


Congratulations Ivan!


I think when you do the `ng-view` the element needs to be closed immediately after. My thought here is that when a new view is brought in it will wipe out all of the script tags on the bottom the HTML. I would recommend adding a div with the `ng-view` on line 8 and then closing the div tag.


Signed-Off-By :Vishal Pandey vishpandey2014@gmail.com


Осталось:
- проверка на обязательные поля (форма не должна отправляться с пустыми полями);
- сжать css и js файлы при помощи сервисов


grammar*


why is the order expected order empty?


With OrderedMap:

const id = action.data;
return state.delete(id).set(id, state.get(id));


empty string with id 10525


Yeah, it looks like BlackLib's makefile is only meant for generating the test driver, and they expect you to incorporate the files you use into your own project. I was thinking of just writing makefile rules of our own that reach into the BlackLib checkout directory, but maybe it's worth trying to get stuff integrated upstream.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16354](https://teamcity.mesosphere.io/viewLog.html?buildId=139038&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:02


On the other hand, PR #85 (fixing image syntax) *does* break CommonMark. I think the failure you're seeing is due to that PR, not this one.

PR #84 fixes CommonMark tests by putting try/catch around test execution. That's also the same PR that introduces `compareHtml()`.


Display the name for the card instead of the value. Keeps the value on the backend for canoeing cards.


kjlkljh


Since the lists are disjoint, there's nothing we can predict about the order other than that 'a' should come before 'b'.  This test is just here to make sure that all the processors get run


Replace string* with string to the signal class too


The following doc(s) have been deployed to the [1130gitre](http://1130gitre-static-docs.pantheon.io/docs) Multidev environment:
- [app/config/sculpin_site.yml](https://github.com/pantheon-systems/documentation/commit/60a85d95b84bbb876764a2f3532bb1f6e937b845/app/config/sculpin_site.yml)
- [docs/articles/local/git-faq](http://1130gitre-static-docs.pantheon.io/docs/articles/local/git-faq)
- [docs/guides/collaborative-development-github-pantheon](http://1130gitre-static-docs.pantheon.io/docs/guides/collaborative-development-github-pantheon)


Sorry for the delay, I am traveling until early next week so I will be slow reviewing and responding for the next few days.


Did you mean to remove 4.1, cause that is newer than 0.12


Your right, but this will be dropped in a rebase after the PVR PR is in.


0.10-0.12 are pretty ancient. We should be targeting the 4.x and 5.x series.


Firstly thanks for the code!
I had it working, but the message content was the recipients number... rather than the desired message body

I'm not sure why you've made this change - I reversed it, and my sms now works properly


License-Fixes-For-8.5 (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (997 of 997 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-28.67%25-green.svg)


lgtm


The following doc(s) have been deployed to the [1130gitre](http://1130gitre-static-docs.pantheon.io/docs) Multidev environment:
- [docs/articles/local/git-faq](http://1130gitre-static-docs.pantheon.io/docs/articles/local/git-faq)
- [docs/guides/collaborative-development-github-pantheon](http://1130gitre-static-docs.pantheon.io/docs/guides/collaborative-development-github-pantheon)


This typo ( the "o") didn't get updated when I installed via PyPI with PIP. Had to change it manually.


If you use `-[UITableView dequeueReusableCellWithIdentifier:forIndexPath:]` method instead you'll get a return value that's a non-optional. Then you can avoid force-unwrapping the cell on the subsequent lines. Please avoid force unwrapping optionals whenever you can.


You should extract this XML into a test resource under src/test/resources.
In it replace the important values with variables like `${my.var}`. In the `pom.xml`, define these values in the `<properties/>` section and in your `<testResources/>` enable filtering.

I believe there will also have to be a property for specifying this XML file.


My bad. Failed to read the errors in all the travis build logs thoroughly.


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


This was a typo. :(


Since you're always expecting the `textLabel` to be available, you could place an assertion on the line before so this won't silently fail if, for example, outlets aren't hooked up correctly.

`assert(cell.textLabel != nil)`


Thanks for fixing my copy-and-paste error :smile:


as long as you have them stored somewhere...

but do note that before I build a HIP release, my scripts automatically delete all unnecessary stuff like .PNG files before encrypting & compressing the package, so it's technically no biggie storing them on git.


disregard this update.


This could be marked `final`. If we're going to use Swift instead of Objective-C we should try to use it's more expressive syntax wherever possible to better convey intent.


Some points to improve:
-FPS display is broken, you need to dereference var, see source cpp.
-Bug with point light, apparently because of bounding boxes.
-The way to use imguiParams is not the best i.e you also need to update the GUI draw method.
-4-5 warnings while compiling.
-remove debug condition inside main i.e move it to IMGUI.

I think to cancel your commit on develop and merge it when it will be good.


I understand that it's not hooked, but the action type seems wrong.


Tks @jerone . i understand what you mean. that's my mistake !


The cases should start with an uppercase character.


You right.  I put the crop dispatch because I am starting on it in the next ticket, but I was doing cutting and pasting.


It's weird have an explicit external parameter name here. It's Cocoa convention to leave it as part of the method name:

`func fetchTopStoriesForSection(section: News.Section ...`


113360729_HumidifierOASys (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (2102 of 2102 tests passed, 7 test warnings)

 * 6 tests had: AUD diffs.
 * 1 test had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Cache file to remove


slightly better


No need for parentheses around `FetchResult` and `Void` can be simplified to `()`.


your waifu is still trash


+

+
+

+

+
it seems you add two links to the index html. So we can access these two games in the index html. That is a good idea. And i agree with what Houpoc says, we might focus on add jason function to apply the background functions


* do we still need bower.json?
* do you need to update README.md to not ask to isntall bower?


Hadn't seen "redirect_from" before.

:+1:


DSSC methods were in base.rb, but moved to ultraflex.rb for now - need discussion on where these should live long term. Depends on J750 needs, may move back once mature on uflex.


No need to include ` -> Void` here and the parentheses can be dropped.


IMAGE_PLOT_KEY is exported both directly and as a part of default. It is a bit confusing.


This discussion makes it seem like some people think that this is a random number generator for cryptographic purposes, but it's not. So stay calm.


Where's the bug report for that?


No need for ` () -> Void in`


cannnot find the definition of clearState?


Running golint on gocb ‘master’ branch produces 186 lint errors.  While these don’t affect execution of the gocb package, they represent *undocumented* methods the package purposefully exports, therefore they do not show up in godoc.  The couchbase Go SDK docs event point to godoc as the reference developers should follow, but there is a gap in that these exported methods documented.  It also makes the library appear unfinished, or not adhering to some of the Golang conventions prescribed by golint.

This pull request attempts to document these exported methods on Bucket (for starters) for the benefit of the community.  Cleans up the following:

```
[mholton@mh:~/Go/src/github.com/holtonma/gocb → fix_golint_exported_methods]$ golint
bucket.go:10:1: comment on exported type Bucket should be of the form "Bucket ..." (with optional leading article)
bucket.go:54:1: exported method Bucket.OperationTimeout should have comment or be unexported
bucket.go:57:1: exported method Bucket.SetOperationTimeout should have comment or be unexported
bucket.go:60:1: exported method Bucket.DurabilityTimeout should have comment or be unexported
bucket.go:63:1: exported method Bucket.SetDurabilityTimeout should have comment or be unexported
bucket.go:66:1: exported method Bucket.DurabilityPollTimeout should have comment or be unexported
bucket.go:69:1: exported method Bucket.SetDurabilityPollTimeout should have comment or be unexported
bucket.go:73:1: exported method Bucket.SetTranscoder should have comment or be unexported
bucket.go:77:1: exported method Bucket.InvalidateQueryCache should have comment or be unexported
bucket.go:83:6: exported type Cas should have comment or be unexported
bucket.go:111:1: exported method Bucket.Close should have comment or be unexported
bucket.go:115:1: exported method Bucket.IoRouter should have comment or be unexported
bucket.go:119:1: comment on exported method Bucket.Internal should be of the form "Internal ..."
bucket.go:121:29: exported method Internal returns unexported type *gocb.bucketInternal, which can be annoying to use
bucket.go:125:1: exported method Bucket.Manager should have comment or be unexported
```

If this is accepted, I'll take the time to clean up the rest of the golint messages on bucket_crud, bucket_dura, bucket_http, bucket_multi, bucket_subdoc, etc.


update your nn, cunn and cudnn


You are welcome!


dssc method is modeled after store, for changing pin data on previous vector (optional offset applied)


on an i5 Mac it is running @ 3.05s, while on Linux it is running @ 2.15s


The indentation levels are getting quite large here. You could place the body of this `dispatch_async` in a helper method.


new 'dssc_next_cycle' modeled after 'store_next_cycle'


okay thanks, i got it


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16359](https://teamcity.mesosphere.io/viewLog.html?buildId=139076&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:03:56


You could use trailing closure syntax here.


This could be marked `private` or at least `private(set)`


`(fetchResult) -> Void in` could be simplified to `fetchResult in`


Updated 'apply_digsrc_settings' and 'apply_digcap_settings' to take pin arguments, tying DSSC options to pins.  This allows for multiple dssc instruments in a pattern, each with different settings.
Previous method had a list of pins, and each pin received the same settings.


I would place an `assert(NSThread.isMainThread)` on the line above to help ensure we're not updating UI from a background thread. It's common for API like this to actually invoke the callback on a secondary thread.


I like that this is in an extension.


No need for this method. `UITableView`s get one section by default.


Instruments statement now formatted for only the dssc options that are passed in.
Previous version set all available options to defaults, even those not specified.


k


It seems you add the routes for choose html and aceup1 html. Besides, you also add the routes for the deal, move and remove functions. I think this is reasonable and i will test it and hope it works


.index method not found


You could use `-dequeueReusableCellWithIdentifier:forIndexPath:` instead to avoid the optional. There's also no need for the cast to `UITableViewCell`.


isn't this supposed to be `.github` (not `github`)?


Test Comment


new file created at 2-18


I would place an `assert(cell.textLabel != nil)` on the line above.


No need for this extension.


Altis_Life.Altis\Config_VehicleConfig.hpp

line 338
} },

need to be } }


What is this loop doing? Isn't it just equivalent to `info := containerInfo[len(containerInfo)-1]`?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16360](https://teamcity.mesosphere.io/viewLog.html?buildId=139077&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:54


(nit) declare `1 << 4` as a constant


Not sure it's a bug or a feature. I tried m81 target search, selected first image and used Flip. All images displayed were flipped from 4 Wise bands were flipped. How do know these images are connected? The help says "Flip the selected image". Is it possible to flip just one selected image?


OK, incorporated.


Yeah. Not sure why I originally added that loop. Replacing it.


is this supposed to be `case framework.Aufs, framework.Overlay`?


@TheDiamondYT1 Okay, sry I thought you forgot your password. ;P


This commit has **created** a great confusion ...

Helm was such a great package, if activated it works just out of the box and though the documentation is not very clear about the difference between the helmized functions and helm-functions, this difference should be documented and not some default behaviour removed without any notice.

Please never ever change the default behaviour of an application in a minor version (and without notice)!

Nevertheless: Thank you, for a great package!


You can just do `fg` here to bring the user application to foreground


You're absolutely right, thanks for noticing this.

For some reason I still don't see a link to it when creating a new PR however. But then I didn't see it before renaming it neither. I do think it worked before though, so I wonder what's going on here...


`Pathutil.new("Gemfile").expand_path(new_blog_path).write(data)`, works for Pathname too.


I'm a little confused by the structure of this loop.... shouldn't it break here? Or do you want it to keep testing until all retries?


Replaced by apply_digcap_settings and apply_digsrc_settings, which now assign DSSC settings to pins, and add directly to the instruments hash.


Did you add pathutil yet?


일단 이런식으로 코드 리뷰를 한다는 행위가 중요한 것 같습니다.(안 하는 것보다는..) 세종씨 말 처럼 저희 방싱의 코드 리뷰를 찾아 가는 것이 필요 하겠네요. ^^
두 분 다 권투를 빕니다.


This be written to a drop-in file, similarly to other calls to `bus_*_set_transient_property`, no? `TimeoutIdleSec=...`.


Build with clang on OSX 10.11 / Xcode 7.0.2 also requires to add CFLAGS="-msse4.2".


I think these should be test log messages instead (`t.Logf`). Same above.


bashrc 这里 PS1 的生成。。是不是有点多余？


Updating.


Not very important, but if you're going to amend the commit, you could also drop the paren here.


Not yet, but you can add it to the surface as a dependency (which won't affect the pull coming) and start doing new work with it.


If the storage driver is neither Aufs or Overlay, it will loop immediately - I think the sleep should be outside the switch?


cross fingers


DSSC instruments now merged in the apply_digsrc_settings / apply_digcap_settings methods


Next step for a better dissection of **Netflix** is to understand how and when the **Amazon** servers are used by Netflix (in particular _Amazon-EU-AWS Elastic Compute Cloud_).
Netflix used Amazon servers to stream videos.


Still wrapping my head around the unittest thing but this trapz.py should work.  Each function being called by trapz.py would have it's on exception handling and would need to know how to unpack and use the arguments/coefficients passed to it.


Yeah, I remember seeing it when it was in the root, it definitely worked then. Maybe it's just some caching going on somewhere, and it'll resolve itself.


all the functions consistently use camel case. Can we avoid snake case?


Forgot to say: I edited development.rb according to http://railsapps.github.io/rails-send-email.html .


I don't think that this will ever work... Can't see any authentication here ;)


Teammates on vacation, merging own PR's


All good sdunster?


I think this may be where you are running into a problem. This is the function that does the actual calculating, but it doesn't seem to be called anywhere in this calcListener() function. Same with the getInfo() function. It is defined within but never called so it is never accessed.


@duane701 Can you see anything blatantly wrong that I am missing? I'm really stuck here.


This can just be `return shell.ls("cordova-plugin-*");`. Also, just a suggestion: maybe take the directory that contains the plugins as a parameter (something like `--pluginRoot`, for example).


Yeah, this looks correct. Maybe you could put this explanation in the commit message (at least say that this is a cleanup that should not change function).


I don't really want to approve this PR at this point. If you want to use environment variables on dev / test you can just manually put them in, like you have here. This functionality is available on any app already.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16361](https://teamcity.mesosphere.io/viewLog.html?buildId=139114&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:06:24


@Yiyun-Liang


Maybe? If you had something behind what you were rendering. But with a black background and no other objects I can't see how it matters. Rapidly swapping between my commit and my commit with your addendum are per pixel identical... or at least as far as my eyes can tell, staring at my 1080p monitor.


Sad to Listen this.But why?


I can't see how this is right. G0 should already be turning the laser off by definition (if it isn't, that's a bug with the lasercutter firmware, not libLaserCut) and, worse, the tickle power feature of the smoothieboard firmware is completely defeated when the laser power is forced to 0 like this. Some setups require that for proper operation.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16365](https://teamcity.mesosphere.io/viewLog.html?buildId=139141&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:17


yeah. The reason for using snake case here is to easily distinguish that we are calling built-in `Symbol.keyFor`. Likewise we have others at the top of the file.


It would be more appropriate to make this if AMD64 - since the mcx16 option is AMD64 specific.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16362](https://teamcity.mesosphere.io/viewLog.html?buildId=139134&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:32


Change from localmed or add to hostfile like you were talking about.


why the `#`? Won't that break it?


Do this


Signed-Off-By :Vishal Pandey vishpandey2014@gmail.com


There's no reason to have two which do the same thing.

On Thu, Feb 18, 2016 at 4:46 AM fanyongqiang <notifications@github.com>
wrote:

> Could you please reserve Callback's method which in beta3?Interface
> Callback could have override method,onResponse(Response response) and
> onResponse(Call call, Response response).OnFailure method,too.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/square/retrofit/commit/9d0cca1b31e58990b0fcc693e013f0328ea3f376#commitcomment-16170884>
> .
>


Is `m->parameters_fragment` non-empty for transient units? Please add a bit of an explanation to the commit message what you are trying to fix.


→ commit message


Yes. Fixing.


> Using Ruby 2.0 parser...

Rails master supports [Ruby 2.2.2+](https://github.com/rails/rails/blob/6da571add8e8fee0e6252f93978d63fb57f29417/rails.gemspec#L10) only. You can force Ruby version to 2.2 for rubocop with this config:

```yaml
AllCops:
    TargetRubyVersion: 2.2
```


Actually, I do see the link now...

"Please review the guidelines for contributing to this repository." (linked)

For example:
https://github.com/wxWidgets/wxWidgets/compare/master...tierra:crowdin-web-dl?expand=1


Ack.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16364](https://teamcity.mesosphere.io/viewLog.html?buildId=139136&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:08:08


Refactoring the test a bit.


no need for inner local variable e


Restructuring it a bit to make it easy to understand.


Backward compatibility is also important.I use beta3 in my app,but if I want to use beta4 now,I have to rewrite my code.


Oh okay. Would it be better if we document the style we practice? That will help new contributors and reviewers.


I'll make it clickable via a diff way, good catch.  We already highlight hovered text, so it should be possible.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16363](https://teamcity.mesosphere.io/viewLog.html?buildId=139135&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:09:35


Ubuntu 15.10 64bit, tests built w/  release mode, CPU speed is still varies with debug mode


Great, thanks, apparently it was indeed just temporary because I see it too now.


That is why it's a beta and not a proper 2.0.0 final. We are finalizing the
API.

On Thu, Feb 18, 2016 at 8:14 PM fanyongqiang <notifications@github.com>
wrote:

> Backward compatibility is also important.I use beta3 in my app,but if I
> want to use beta4 now,I have to rewrite my code.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/square/retrofit/commit/9d0cca1b31e58990b0fcc693e013f0328ea3f376#commitcomment-16192875>
> .
>


`cameraTable = NetworkTable::GetTable("GRIP/myContoursReport");`

`NetworkTable::GetTable` return a shared_ptr already. Just grab it and hold it. That keeps it from being deleted.


Sure, we can. Does it go under contribution guidelines? Or a comment here would suffice?


Was there a need to swap this out?  My concern is that this async method call just turned into a sync method call.


With:
`$attributes = array('id'=>2,'name'=>'Peter');`
 Return:
`<a href="http://www.foo.com/route/">link name</a>`

No parameters include in the URL

Possible solution for URL GET mode with parameters, replacing "attributes()" on "link()" function by this:

`public function linkattributes($attributes){`

        `$html = [];`

        foreach ((array) $attributes as $key => $value) {
            $element = $key.'='.$value;

            if (! is_null($element)) {
                $html[] = $element;
            }
        }
        return count($html) > 0 ? '?' . implode('&', $html) : '';
    }`

result: `<a href="http://www.foo.com/route?id=1&name=Peter" > link name </a>`

Thanks.


I haven't filed a bug report yet.  If I use the builtin version, I get
wine: Call from 0x7bc54bb0 to unimplemented function urlmon.dll.446, aborting
wine: Call from 0x7b83d0b2 to unimplemented function urlmon.dll.446, aborting
in the terminal and also get "LEGO MINDSTORMS EV3 has terminated unexpectedly. Please restart the application." in a dialog box.


Thanks for your reply.Let me cry for a while.


Contribution guidelines would be better, as we can explain all the JS style and C++ style which we use. That way we can easily link sections of that document to contributors, to point out things.


The flag image won’t work with an uppercase extension. Please rename it to `bvy.png`.


You'll probably also want to add `blank=True`.


Sounds good. Does it have to go in this PR? I can open an issue for this which can go in next few days.


The issue is probably at the index writer queue level.  We use an async
queue here to prevent slowness at the search engine level from affecting
us.  What we may be able to do is put a special flag on index requests.
Certain sets of index writer requests would go into “direct mode” while
others would go in “async mode”.

We can try a relatively simple test of swapping out the search writer
destination using a synchronous destination to see if the problem goes away.

-m

*From:* Jorge Ferrer [mailto:notifications@github.com]
*Sent:* Thursday, February 18, 2016 4:27 PM
*To:* drewbrokke/liferay-portal <liferay-portal@noreply.github.com>
*Cc:* Michael Han <michael.han@liferay.com>
*Subject:* Re: [liferay-portal] LPS-63217 adds new overloaded method to
UserLocalServiceImpl (bade876)

I see

@mhan810 <https://github.com/mhan810> Can you give your opinion on this? Is
there anyway to void doing this thing with forceDatabase?

—
Reply to this email directly or view it on GitHub
<https://github.com/drewbrokke/liferay-portal/commit/bade8768388b436751a80a5ca1a51e202d8c3274#commitcomment-16190177>
.


We should also do a data migration here:

```python
def empty_strings_to_null(apps, schema_editor):
    model = apps.get_model('users', 'User')
    model.objects.filter(first_name='').update(first_name=None)
    model.objects.filter(last_name='').update(last_name=None)
```


sounds good to me


sig is not None is always true


yeah i forgot I set the email and name as me


Okay. That's definitely a bug, so please file one. Winetricks policy is not to add native dlls / workarounds without a documented reason (usually a bug report). That way the problems are known to wine and can be fixed, so they won't be needed in the future.


fail


Thanks, much appreciated!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16366](https://teamcity.mesosphere.io/viewLog.html?buildId=139164&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 229 Build time: 00:04:05


Looks good overall.  Mostly just some style nits:

- needs some unit tests.  See tests/CXXR/ControlFlowTests.cpp for an example of how to setup tests that test both the interpreter and the JIT.

- drop the assert() statements on the return values from emitConstantPointer.  It's not going to return null, so they don't gain us anything.

- the control flow in emitInlinedAssign should be simplified.  Something like:
   if lhs is StringVector
         lhs = symbol(lhs)

   if lhs is symbol
        ...
   else if lhs is Expression
        ...
    else
       // Probably syntax error ...

Thanks


Um, I think you confused Peyton Manning (Papa John's buddy) with Joe Montana!


can you delete this comment, I messed up when i commented on a commit and not on the PR. Now I'm trying to remove these to have a clean history, but I cant.


Not much of a fan of most of these reformats.  (A complaint directed at rubocop.)  Note: I put in a PR for the `before_filter` => `before_action` changes separately.


It should be in a separate PR. No urgency here ;) Please do when you find time. Thanks @kunalspathak :)


Oops what happened here


viewWillDisappearを閉じないみたい
それでエラー吐いてるよ


Thanks.


Steve,
  This was another minor breakthrough for me.  I started to think about how to add an item to a to do list and then came to the realization that I certainly do not want a separate page rendered to add an item.  Then I said, "Hey wait how am I going to invoke a `#create` action from the _to_do_items_controller_ on the show page of the _to_do_list_?  Then I realized I can invoke `form_for` anywhere I want to and in the `form_for` method I can in essence specify the appropriate controller and controller action.


Now I remember. `containerInfo` is a `map[string]v2.ContainerInfo` and I don't know the key. Hence the stupid loop.


also subscriptions.


113360729_HumidifierOASys (mjwitte) - i386-Windows-7-VisualStudio-12: OK (2102 of 2102 tests passed, 7 test warnings)

 * 6 tests had: AUD diffs.
 * 1 test had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


maybe `bind-address = "<IP>:8088"`


@timstclair: Addressed all your comments this time. PTAL


@jwilder - additional thread safety fix here.


I started a thread on this, it kinda stalled out. Don't make any changes to this sentence unless Fred & Jason both agree.


@KaiNissen did you accidentally add this twice, or is one of them meant to be doing something else?


You can't do this. According to [Reading array values published by NetworkTables ](https://wpilib.screenstepslive.com/s/4485/m/50711/l/479908-reading-array-values-published-by-networktables), you can get the data, but there isn't anything to display the data.

You have a couple of choice.

1. Read the data from the network table and put it on the dash board periodically somewhere.
2. Create a `LiveWindowSendable` subclass that can will update the display.


FixImageProblemInIORef (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (2099 of 2099 tests passed, 6 test warnings)

 * 6 tests had: AUD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16367](https://teamcity.mesosphere.io/viewLog.html?buildId=139175&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:53


A cluster must have an odd number of nodes running the [consensus service](/influxdb/v0.10/concepts/glossary/#consensus-node), [data nodes](/influxdb/v0.10/concepts/glossary/#consensus-service) to form a Raft consensus group and remain in a healthy state.


Did you convert all the normal numbers into their correct musical notation?


Ok. I like that, it makes it much more explicit what happens.


read it.


By Soveasna Paak<?p>


while it is possible to build a cluster on a single server,


Though I have a networking meeting tomorrow I think I can get the edit and delete actions completed before Saturday.  I definitely have some more refactoring to do, along with some more tests to write for the purposes of robustness.


maybe

Point the second and third nodes to the first node.


 yes, all images. when the lock button is implemented then it will be either.
come to think of it I need to make a ticket for the lock button


С версткой и задание 1.5 уже не успел, сделаю позже.


Might be worth giving an example of the `influx -host` syntax so they are aware they can run the CLI from any server to interact with any other server.


now this seems to be good :) atom (silvermont) supports sse 4.2, I wonder if using --fmath=sse-4.2 will more optimize it or not since only 4.2 should be used thn. right now our compiler provides whole SSE.
and yeah "THE ERA FOR X86 AKA INTEL HAS STARTED" ;)


#18 resolved


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


@dossett
Why need special set the version of snakeyaml?
in the parent pom, it has set the snakeyaml‘s version


Turns out what I have on `master` won't work with Facebook - omitting "/" path, because Facebook specifically requires you to have it for your callback URL.

The best solution that seems to work for all cases is to parse redirectUri as before and always compare with pathname.

For example, if you use `http://localhost:3000` (no slash) as your redirectUri and then parse this URL:
```js
// All this ceremony because either IE9 or IE10 does not support window.location.origin`.
var redirectUriPath = redirectUriParser.protocol + '//' + redirectUriParser.hostname +
            (redirectUriParser.port ? ':' + redirectUriParser.port: '') +
            redirectUriParser.pathname;
```
The result is `http://localhost:3000/` with slash at the end.


I think they have to point to a node running the consensus service. I don't know if providing a data-only node's address will allow the new process to join the cluster.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16368](https://teamcity.mesosphere.io/viewLog.html?buildId=139176&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:05:17


License-Fixes-For-8.5 (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1549 of 1549 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.77%25-green.svg)


License-Fixes-For-8.5 (jasondegraw) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Signed-Off-By : Vishal Pandey vishpandey2014@gmail.com


Done. https://bugs.winehq.org/show_bug.cgi?id=40174


@hjmjohnson:
Hans, please take a look to this patch.
I created a new class called ''orderedmap" by inheritance from std::map.
The new class use a customized key compare class for the std::map.
This patch compiles successfully, but returns segfault at run time.
The reason of segfault is related to following line of code:
https://github.com/BRAINSia/BRAINSTools/blob/master/BRAINSABC/brainseg/BRAINSABC.cxx#L638

The transform file names are pushed back to the "intraSubjectTransformFileNames[typeIt->first]"; however, when we try to access them, a segfault happens.
For example add following lines right after above specified line of code as:

std::cout << "Segfault happens the next line!" << std::endl;
std::cout << "print transform file name: " << intraSubjectTransformFileNames[typeIt->first][0] << std::endl;

Then a segfault happens. I still could not find the reason.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16370](https://teamcity.mesosphere.io/viewLog.html?buildId=139178&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:03:52


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16369](https://teamcity.mesosphere.io/viewLog.html?buildId=139177&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:17


@jaswsinc Thanks for the reminder. Updated in https://github.com/websharks/zencache-pro/compare/0dc53d2d01ce...845dfd5f1791.


Add '   ' field what to type.


@KillerAsuna See my comments.


You have to use a different variable.


add @override


Is this an alias for `plugins`?


When did you get the build fail error?  Thought Testify automatically calls all functions with *t.Testing


Remember to change this name.


For option one, I should stop trying to make the cameraTable a part of Camera almost as if it is a CANTalon in Chassis. Everything in RobotMap concerning this should be deleted. I should have my code calling my data inside of the command the same way it was before in RobotPeriodic.

For option two, well, I do not know.


Thanks.


Now that I looked more at this code: do you think it would make sense to make the `--plugins` parameter mandatory? That way we wouldn't have to do any logic to get local plugins.


Make sure you check if they have bInternet


Mohamadoul-Bary Farhanatou, 17 february 2016 at 23:40 PM


Option two is interesting, but too hard right now. :-)

Option one is yes. You need to have a command that is running all the time update the dashboard with the data from the camera.


Might there be characters in the build ID that are not valid path characters?


ここのエラーは治せた？


Yeah, it's completly normal, we're getting commands from the other two, see devices array.

As regards to GUI I'd prefer to have it in c++ as well, since I know nothing about java and I hate it (but if you wanna make it, go ahead :) )


What a Pushkin, what a son of a bitch!


This formatting doesn't look right.


I think this could be avoided by having the reference check run after the recursive types check.


why'd you add the space between function and user?


The whitespace here is weird/misleading. `notice: 'Assessment was successfully destroyed.'` is an argument to `redirect_to`, and should probably be indented.


Thanks! BitHub has sent payment of  $28.59USD for this commit.


Thanks! BitHub has sent payment of  $28.01USD for this commit.


Command running all the time = default command. True?

Option two sounds like something for another year...

Thank you. :smiley_cat:


update by src


@farhanat

Bonjour il y a un probleme. Je ne peux ajouter votre nom. Essayer de voir comment faire pour que je puisse merger votre pull request. Bonne chance!

Regardez ici:

https://github.com/paceuniversity/courses/commit/33909013b1563f965ee6ed0e351b7e77c803f11d#commitcomment-16193262

egalement


I was expecting server.Serve() to return when Unmount() gets called.


Maven luckily supports separating test from main language level.. We should
open a bug in idea as it doesn't support this well.


As I mentioned in the other places this commit appears, the `JComboBox<Object>` and `JComboBox<?>` defeat the purpose.  Please properly parameterize them.  The longer it stays like this and the more places it gets merged the more difficult it will be to fix.


Typo: `strand.lable`


will this fail for algorithms that aren't ported over to certain languages?
Another issue with running these in a loop is you don't know 'which' language failed. I recommend using nUnit's TestCaseSource feature, you can see an example of it in the `LeanDataTests`. Basically, you can define a test that takes arguments detailing what to run and what is expected, and then run each test case as a separate test. This provides better isolation as well as more easily determining exactly what failed.


`label_method: :label` is the default.


Simplified implementation:

```ruby
obs = t.strands.map do |s|
  link_to s.label, s.objective + '<br>'
end
obs.html_safe
```


General comments:
Can you please add the closing ?> tag to each example. I'm not sure it wasn't there in the first place but I'd recommend adding it at the end of each functional example.

The README.md usage needs to be updated.


Fixes #3!


That property is set in the container, using existing weld subsystem rules: https://github.com/jbossws/wildfly/commit/6b61d919f13241a4511cdc79df6f28e3dda525a5#diff-9facc2a409d664cf38213e874f281809R55


Ok, let's make sure that in the end the validation is the same.


@anthrotype You forgot to change the `choices` to [10..24].


If we failed to find an alias, for instance because the function was
stored in an array of function, then we have no alias for the call, so
we don't know if it's pure or not, so we conservatively choose it's not
pure.


Update and save `guser.migrated` value


Why can't we just pass address family into create_socket?


Because We can't easily specialize based on a trait (well, we could but
this would imply more changes than doing it this way)


adding new file


Зачем везде раскиданы фигурные скобки? Без них же код работает идентично, и не сбивает с толку.


Ooops.. PR please? ;)


this fails for me on tmpfs as `fsetxattr` returns EOPNOTSUPP.  Not sure what a better place could be, is it fine for now to keep it as "test-libarchive-import-XXXXXX"?


https://github.com/leancloud/cloud-code/pull/624
可以把新增的 smoothly 选项加上


Its totally not..... I removed the listner.


++ typo is in line 234 now of view-source:http://easyappointments.org/


I like this logic but I won't work right now. As you assume here, the key handler should return what have done with the key (handled, nothandled, propagated, and maybe more future options), but right now there are some hacks here and there in the handlers to return KEY_ESC after doing some actions (for example saving the displayed columns in ui_column_select) to force the default handler to run the ACTION_PREV_SCREEN.

I prefer the behaviour suggested by this code, but It requires to update the handlers to avoid hacking the input key. I think that's another enhancement out of this PR scope, so this should still use the key variable 'c' as loop breaker.


I prefer function expressions over declarations for basically two reasons:
- Expressions are not hoisted
- Functions in javascripts are objects, declarations try to hide that.


AddCoolGithubThings (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (997 of 997 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-28.67%25-green.svg)


Looks good to me now.


Camera doesn't work since it can't allocate memory properly.
On 19 Feb 2016 09:07, "Zeeshan" <notifications@github.com> wrote:

> What kind of impact does this have if it is in the wrong order? Does it
> stop the ROM from booting? My ROM is not booting because of camera (it just
> tries to keep initializing over and over). I am thinking this might be part
> of the problem.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OpenDesireProject/android_device_htc_msm7x30-common/commit/640dedc2c1d0beae92e8d20351fc775d2b2ac75a#commitcomment-16196214>
> .
>


OMG! WRONG TRANSLATION here!!!!

it's been translated as saved instead of deleted!!!


https://pypi.python.org/pypi/plone.testing/4.2.1#id8
https://pypi.python.org/pypi/plone.testing/5.0.0#id8


Looks ok, but please explain in this error message what the acceptable states are.


nitpick: this change seems to not be needed and adds a trailing white space


More fun of a default_handler that always return KEY_HANDLED and the loop exits naturaly that breaking the loop here. `c = default_handle_key(ui, c);` will make use of the default_handler return code (that must be changed right now to KEY_HANDLED) and allows the loop to exit gracefully.


Doesn't build on OSX using clang. Conflicting types for the camera_control_set_parameters() function in camera_control_macosx.c
Changing the declaration and definition to match (int -> enum PSMove_Bool) fixes the issue
![screen shot 2016-02-19 at 10 07 44](https://cloud.githubusercontent.com/assets/1104831/13172566/a3c2e442-d6f0-11e5-91c4-eaeb88f6f872.png)


Love it.
If some thay we add a KEY_NOT_HANDLED -1, we just need to change the propagated defined <3


The commit message is not really clear on the purpose. Please describe the actual intention of the change, and refer to http://gluster.readthedocs.org/en/latest/Contributors-Guide/Bug-report-Life-Cycle/ so that others can check if the checked states are correct.


indentation is off by a bit isn't it? Does this even work without brackets? (/me isn't fully sure on that right now)


with brackets I mean parentheses here


Yep, no problem. Looks like an style in the whole code. Nice :)


hey, the commit message needs some love; we have some guidelines at http://coala.readthedocs.org/en/latest/Getting_Involved/Writing_Good_Commits/#how-to-write-good-commit-messages . If you need help getting your stuff into the right shape, just join us at https://gitter.im/coala-analyzer/coala : )


@Vanessa219 好的，不部署。


Чем неудачное? Как лучше назвать строчку для шаблона?


Sull'accorciarla hai perfettamente ragione, sul Do Not Track avevo scelto di non tradurlo perché usando antitracciamento sembrava quasi la stessa cosa della protezione antitracciamento, usando direttiva, almeno secondo  me, si poteva tenere la dicitura inglese.


Рассматривайте префикс "downloader_" как неймспейс для ограничения использования строки. Понадобится в другом месте - лучше завести новую.


Шаблон для какой задачи? Лучше исходить из формулировки цели, для чего он делается.

> On Feb 19, 2016, at 11:11, Alexander Marchuk <notifications@github.com> wrote:
>
> Чем неудачное? Как лучше назвать строчку для шаблона?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/deathbaba/omim/commit/fd019827919e9b4ad0a2d2af0aaa8dc85346843b#commitcomment-16199236>.
>


`return KEY_PROPAGATED` woult be the ideal


Remove unused codes


`return KEY_PROPAGATED` woult be ideal


Эм, в строке же всё написано. Шаблон для фразы "Карт для обновления: %столько-то"


I've discovered this in the following [Symfony News](http://symfony.com/blog/new-in-symfony-2-8-dx-improvements#recursive-directory-loading-for-configuration-and-routing).
There's a link to the code Pull Request, which doesn't link to any documentation Pull Requests, so maybe it hasn't been documented yet.


Logger use


[maps_to_update] ?

> On Feb 19, 2016, at 11:14, Alexander Marchuk <notifications@github.com> wrote:
>
> Эм, в строке же всё написано. Шаблон для фразы "Карт для обновления: %столько-то"
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/deathbaba/omim/commit/fd019827919e9b4ad0a2d2af0aaa8dc85346843b#commitcomment-16199300>.
>


I understand.
 It remains to deal with "argparse"


no the modification made in nop commit was here to enable diopole, this one is here to enable monopole.


you could also just write `return "You are not connected to the internet." if code is None else True` as a oneliner without the no cover even


The commit log seems outdated.


@bykoianko хорошо бы подробнее написать, что именно нужно сделать


Two ExecStarts?


Вроде выпиливаем всё, что связано с разделением карт на "с маршрутами" и "без маршрутов".


*TYPO


Почему 50?


много где не хватает const, не буду отдельными комментариями помечать.


I just copy past some code... can you explain why adding this would be better please?


delete


huh this changed, why?


it's CORRECT now


И здесь хотелось бы подробнее, какая логика требуется.


Pls check code refactoring before commit the source code.
http://www.phpbuilder.com/articles/application-architecture/optimization/best-practices-for-refactoring-in-php.html


seems to work well though


Where is the listener? I think a different pull request added one


On 19/02/16 09:54, Jasper Li wrote:
> In order to download 2G file with 64M chunked, it will need 32 handles, right?

32 HTTPFetcher structs, yes.

I considered whether building all the HTTPFetcher objects in one go,
before we start any of the downloads, is too wasteful. If you have a
very small chunk size, like 1 kB, then you could end up with a huge
number of HTTPFetchers. But I think that falls into the category of
"don't do that". With a reasonable chunk size, in the range of
megabytes, it should be ok.

Note that creating the HTTPFetcher object doesn't open a connection or
create a CURL handle yet. That's done only when the download is started,
with HTTPFetcher_start(). Until then, they just consume a little bit of
memory.

- Heikki


лучше сделать switch


Should this be `<code>0</code>`?


I'd rather break it at the `+`es


Тогда компилятор подскажет, если нужно, о новых или не обработанных статусах.


ahh, thanks!


Don't want to do a fork for this minor thing - I just tried installing following instructions here and got a github error. Seems like one now has to do `install_github("js229/Vennerable")` instead of `install_github("Vennerable")` - maybe change line 16?


TeamCity LabKey :: Trunk :: Community :: CDS postgres 9.5 [Build 105](https://teamcity.labkey.org/viewLog.html?buildId=304367&buildTypeId=LabkeyTrunk_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 14 (4 new), passed: 36 Build time: 01:25:11
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyCounts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterPane: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

##### there are 4 more failed tests, see build details
```


Думаю, что хранить эти переменные членами класса не нужно, т.к. они используются только в одном методе CreateCountryStatusControls.


Added initial file structure and some PHP includes to get the ball rolling. Linux on the command line is confusing, especially at 10am.


Лямбды тоже можно делать const )


s/from it's earliest/since its first/


s/latests/latest/


s/brings couple of/brings several/


QString const &


s/on/at/


why ?


"As source of argument values can be used any top level value or unary function with compatible type"
->
"You can use any top level value or unary function with a compatible type as the source of argument values"


Edited g+


VERY NICE!!!!!!!


Yeah, this wording wasn't very clear, thanks for pointing the out.  I changed it in https://github.com/stasm/ecma402/commit/e358e354d09582645469e7ee35cb2d4614698fc4.


If you have some time, could you tell me if you still have this issue with the latest 3 commits : de3861b4f4966cd24f07a134dc11da4bf9d61517, 98709cad4d41755285e2a769791f359404817d90 and ab1983341f461ad00cbc48b85c2c553f91e23280 ?

For now it seems to resolve it on my side.


s/for whole/for the whole/

Honestly I'm tempted to not fix the missing "the" lines, as it gives it a certain Russian charm :)


Все комментарии не по стантарту, с маленькой буквы и без точки в конце.


SWEET ASS!


Pas du tout....
Bon il est temps de mettre eslint


"the condition if the test can be reliable executed is known only"
->
"the activation condition for the test can only be known"


Это на какой именно момент времени TODO?


occhio che poi il risultato matchato dentro la `v=(.[^&]+)` viene usato in giro tipo dalla `preg_match()` per pigliare l'id del video


Комментарий не outdated?


s/is useful/it is useful/
s/thouse/those/


awesome!! :+1:


I know there is some concerns about this iteration, but I don't see any other way to create this dependencies because creation order of resources/services doesn't permit to do that in different way. If MDR/Service APIs give a better way to filter this serviceNames could be used.
Another possible approach could be to have a separate registry dedicated to this names, managed from the subsystem just for this purpose, but I don't think we want this kind of special registry


Hey @danielwegener
no, spring-core is needed during compile-time as well. When I change the spring-core to test, the compilation of the source fails because of missing `org.springframework.core.NestedRuntimeException`. - When I put it to test the dependency is removed from the classpath due compile time.


I think that's fine.


s/mechanism/mechanisms/ (because "are")
s/which allows/which allow/ (because "are")


please add markdown links: `[Good Commits page](http://coala.readthedocs.org/en/latest/Getting_Involved/Writing_Good_Commits.html)` they're wrongly recognized


Sorry, this syntax only works for the MSVC compiler (which is untested for the master branch). This is why all the tests are failing on Travis.

I think a better solution would be to remove the static keyword when creating the grammar object.


s/The easiest way, how to register/The easiest way to register/


@batopa Yes, I know. All other groups are non-matching groups `(?:     )` for this reason, thus `$matches[1]` is the video ID. Was this your concern?


"Note that for drop-in files, if one wants to remove entries from a setting that is parsed as a list (and is not a dependency), such as ConditionPathExists= (or e.g. ExecStart= in service units), one needs to first clear the list before re-adding all entries except the one that is to be removed. See below for an example."
(https://www.freedesktop.org/software/systemd/man/systemd.unit.html)


your regex matches the closing bracket


Can <set> be removed?


"Currently there are available following extension points and new can be added if needed."
->
"Currently the following extension points are available, and new ones can be added if needed:"


How do you mean? That is what drop in services are, right, configuration?


if you have multiple place input in your page there will be multiple `<input id="vueGoogleMapsPlaceInput" type="text" v-el:input :placeholder="placeholder" :class="class"/> ` in the dom. And since there should be only one DOM element with a given id (in this case `vueGoogleMapsPlaceInput`). This is not valid.


s/are available for some time already/have already been available for some time/


s/easily slipped/easily have slipped/


trailing period or comma should also be tested and not matched


Let's change this to

```php
/* translators: %s: document.write() */
'badDocumentWrite' => sprintf( __( '%s is forbidden' ), '<code>document.write()</code>' );
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16400](https://teamcity.mesosphere.io/viewLog.html?buildId=139589&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:04:13


This fixed #394


s/build/built/


@alecpm all jenkins jobs are green already, feel free to push as many pull requests as you wish!


@granthenke The default in the old consumer is true, but since this option doesn't exist in the new consumer for 0.9.0.0, the default behaviour for the new consumer in 0.9.0.0 and 0.9.0.1 is false. Vahid is going to change the default to true as you suggested, but I just wanted to check that changing the 0.9.0.0 default behaviour is OK. I imagine most users would want to exclude internal topics, so perhaps the change in behaviour is not an issue.


Excellent post, man. I learned a lot of things I didn't know `ceylon.test` had!!!


@fquffio yep! Then it seems ok, I didn't know about `(?: )` to skip matching. Good to know :)


which compiler version are using?

I think we should remove this one and to open an issue to remove this flag.

Let's put there the output of the compilation + compiler version.

We have 2 options: either downgrade the gcc version (if it helps at all) or to upgrade the qemu version.


@Urigo
`angular:angular` before `angular-templates` because of `angular is not defined`


Sorry I should have said before, it's usually better to pass the inputs as the function's arguments instead. That makes it easier to know what's in the package and also to override one of the dependencies.


`file[issue["startLine"]-1]` -> `line_to_change`


```machine", len(```? (Add a space)


Nice change


Il tuo ragionamento concettualmente non fa una piega. Però io pensavo agli utenti che non seguono le varie iniziative Mozilla: se gli dici "Antitracciamento" possono trovare subito un riscontro nelle preferenze del browser, se gli dici "Do Not Track" non capiscono che si tratta di un'impostazione che possono attivare a loro scelta.
Secondo me per smorzare un po' la ripetizione, che effettivamente dà fastidio, si può sottolineare come una funzione vada a perfezionare l'altra:
Grazie all’Antitracciamento e alla navigazione anonima con protezione antitracciamento *incorporata* …
Grazie alla protezione antitracciamento e alla navigazione anonima, ora disponibili anche insieme, …
Dall'opzione Antitracciamento fino alla nuova navigazione anonima con protezione antitracciamento, Firefox OS continua a innovarsi per darti il pieno controllo sulle tue attività online.


This really tripped me up for a while. It's completely unnecessary for SQL models but there is lots of code that depends on it.


I didn't know this. Nice.


Indeed. I miss read it.


Approved.


same here, you could accept eggDerivation and fetchegg as arguments instead.


What does the TODO: var in dot24 mean? @TiarkRompf


As a further measure to increase reliability, we could use named groups, like `(?P<id> )`, so that the video ID is obtained via `$matches['id']`. It looks like a good practice to me in many scenarios, generally speaking. Of course, this would be a possibly breaking change, so I guess it's best left out.


@Redridge can you file a newcomer bug about this? Then we can merge it :)


Indeed, I initially had the code full of `file[issue["startLine"]-1]` but then I refactored it a bit. I missed this one


is *an* integral


Should be fixed in 60a6075dc42d8eb90dc3e0b51e2753ad68e659f7.


s/when/where/
of *a* test fucntion


I'm not sure I understand why you've used `quacks_like` in these tests, because as far as I can see nothing is calling methods on those stub objects. In any case, I think you should explain why you're using `quacks_like` in the commit note since it's out of the ordinary.

On a related note, it might be worth setting the `: stubbing_non_existent_method` option in [Mocha::Configuration](http://gofreerange.com/mocha/docs/Mocha/Configuration.html) to `prevent` globally and see whether any tests fail.


Can you write Russian in russian, like the other links?


initial


*A* classical


This commit was supposed to end up in my fork.


with *a* function


*the* source


Hi Stefan,
Have you made a release for this fork? If so, could I get a copy of the package from you?


and *a* second


It might be worth considering introducing a "null object" version of FCO organisation which returns `[]` from the `offices_with_service` method to avoid the conditional.


Sorry for the inconvenience. Thanks @nilya for spotting it, and @eustas for fixing it!


on *a* general


Ops, sorry. Done in [0f93efc](https://github.com/sindresorhus/ava-docs/commit/0f93efc2949ddc6032947b39e34d812c9fce3def)


*a* test
s/but from/but for/


I think you could use a single call to `stubs` here and pass in a Hash of method names and return values.


It's not about preference, it's about best practices. It is really hard to maintain code that was written not using the code standards. That's just my opinion from experience.
Btw in javascript, everything is an object.


Is this correct? (Maybe I'm just a little lost but I think we should check if there's enough space to the right and if so, place the popup to the right)


@yargalot: this is an important one because it removes a lot of bloat. Unfortunately, I'm having test failures probably because of the newer node or something. So we need to merge most of my patches and work on fixing the remaining issues.

https://github.com/yargalot/grunt-accessibility/compare/master...XhmikosR:master

Then, we can do some of this patches for access-sniff too.


Thanks for explanation


do we really need to call :spin-once at here?


a Copy+Paste fail probably, fixed.


EOL?


FROM jenkins
MAINTAINER johan.haleby@jayway.com

# Switch user to root so that we can install apps (jenkins image switches to user "jenkins" in the end)
USER root

# Install Docker prerequisites
RUN apt-get update -qq && apt-get install -qqy \
    apt-transport-https \
    ca-certificates \
	lxc \
	supervisor

# Create log folder for supervisor, jenkins and docker
RUN mkdir -p /var/log/supervisor
RUN mkdir -p /var/log/docker
RUN mkdir -p /var/log/jenkins

COPY supervisord.conf /etc/supervisor/conf.d/supervisord.conf

# Install Docker from Docker Inc. repositories.
RUN echo deb https://get.docker.io/ubuntu docker main > /etc/apt/sources.list.d/docker.list \
  && apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 36A1D7869245C8950F966E92D8576A8BA88D21E9 \
  && apt-get update -qq \
  && apt-get install -qqy lxc-docker

# Add jenkins user to the docker groups so that the jenkins user can run docker without sudo
RUN gpasswd -a jenkins docker

# Install the magic wrapper
ADD ./wrapdocker /usr/local/bin/wrapdocker
RUN chmod +x /usr/local/bin/wrapdocker

CMD /usr/bin/supervisord -c /etc/supervisor/conf.d/supervisord.conf


Remove **modules/ding_item_cache/translations** and add the appropriate strings needed to files in the **/translations** folder (in the root).


Some docs ?


s/For enabling/To enable/


Why not do as you did in `count_active`? I.e.
```ocaml
List.fold_left (fun acc x -> acc || x.Worker.queues = queues && (f x)) false)
```


So methods can't be annotated both with @GET and @POST, only one is required.


But you're stripping whole fun of Eastern-European accent, man :(


The binary kernel (vendor-sony-kernel) pointed by sony's manifest
`<project path="vendor/sony/kernel" name="vendor-sony-kernel" groups="device" remote="sony" revision="l-mr1" />`
does not contain this change. Its last commit was done on Jan 27, 2016.
I'm looking for stability and for this reason I thought it would be better to use the binary kernel. What do you advise me? Using the binary kernel master branch, waiting for a binary kernel l-mr1 branch update, or building kernel (l-mr1 branch) by myself?
Thanks.

ps: Please let me know if this kind of questioning is not appropriate for a commit comment. I that case how may I contact you?


I wonder whether we might be able to use the Rails `Inflector` stuff to implement this kind of behaviour...?

Also ultimately I'd like to see this kind of formatting/presentation logic being done in helper methods (or presenter objects).


コメントをつける


Idem, interesting stuff!


Sahhit


试试


Может лучше LinkedObjectType?


Смотри. У тебя в примерах по-прежнему надо require сам MovieCatalog, а потом ещё отдельные файлы с классами и модулями. Так быть не должно! Должно хватать `require "MovieCatalog"`, чтобы все фичи стали доступны.


VERY GOOD MAI FREUND


Или PositionType.


That what my Spanish friends tell me as well, but that way one *never* learns how speak properly ;)


Hi,

I am still not able to view calendar even after making local/master identical to openemr/master and nothing in error log any idea?


waarom verander je alleen een comment?


コメントできる


тут хочет быть использован либо стандартный [OptionParser](http://docs.ruby-lang.org/en/2.1.0/OptionParser.html), либо удобный гем вроде [slop](https://github.com/leejarvis/slop).


Helpers declaration is wrong and will not work on case sensitive file systems. It should be _ Stuntcoders_FbPixel_Helper_ instead of _stuntcoders_fbpixel_Helper_.


These inner brackets are not required.


1.全局添加
DEFAULT_TIMEOUT = 10 * 1000;
2.
timeout = timeout || 10 * 1000;
=>

request.timeout = request.timeout  || DEFAULT_TIMEOUT;


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16401](https://teamcity.mesosphere.io/viewLog.html?buildId=139599&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:08:44


Oh, err, yes, it was an accident.


Difficult to comment on. In principle, the UI needs to know when O changes the camera's perspective correction (or any other parameter). I didn't realise we had three cameras. We could have used V to flick between the 3 cams (thus creating a need for another button and another problem of semantics, but solving a potential issue with indication). Now the 3d-editor keeps a "cameraState" but it doesn't seem to signal if that is ever modified.


Same issue as with helpers.


DANKE SCHÖN!


ditto brackets.


settings.get(app.id,'timeout',function (timeout) {
=>
settings.get(app.id, 'request', function (requestData) {


protected is used by the associated test class to "extract & override" as a way to stub and reduce test prep. complexity.


This is much nicer!


request(url, {timeout: timeout}, function (error, response, body) {
=>
request(url, requestData, function (error, response, body) {


We are _almost_ there! :)


for dev/validation data logging, look a few lines below. Look for "dev_set" variable!


We need to free the new data input stream.


Yes, it's a buggy implementation, but we can't fix this in a patch release, there's a risk of backwards-compatibility breakage. It doesn't really matter if it doesn't match Mersenne Twister to existing apps. They just care if it works predictably. If we suddenly fix it in a patch release, we might break existing apps.


Is that a changelog for `3.19.3`?


This check should be unnecessary with the length check below.


ack


We need to skip this line if it doesn't match. We should also extend the unit test for this case.


@Johann-S: can you update jasmine and CC me on the PR? I'm getting failures.


Concordo


You should also exclude character 127.


:D

Had some changes since a lot of time ago, the merge was a total mess...


As it is focus on big harvesters, I prefer to have index in the middle. This way we can see how is the harvesting behaving during the harvest.


Add handler support for the network install path.


I can't believe this has gone from Phil trolling me to my team convincing me to change something.


This is going to make my life much better, thanks! If you're ever in Manchester I'm sure I'm not the only who'd buy you a beer for this!


LGTM


Thanks for your contribution @martinjhnhadley

Can you change the plot.ly link to https://github.com/ropensci/plotly ?


Hey @XhmikosR, Id imagine the tests are failing since access-sniff 2.0 has a different implementation from the 1.0 since I es6'd it.

Instead of
```
 var accessSniff = require('access-sniff');
accessSniff.start()
```

Its now ```accessSniff.default``` and then ```accessSniff.report``` to convert the output.

The changes look awesome btw, been meaning to clean this up since I released 2.0 a few weeks ago!


Yeeey thanks for adding me to the contributors :smile:


"Materialeliste" -> "Materiale mellemlagring"


AddCoolGithubThings (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1549 of 1549 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.77%25-green.svg)


@yargalot: do you mind me not splitting this and submit a single PR? then you can work on top of it and make things work again :)


probably fixed in a following commit


ack


sure.


testing


Thank you; that explains why I was a '{}' out when I was formatting the DSL for the Note.


Of course, I understand the strategy used, but you could _add_ @VisibleForTesting, as it's used for testing ...


Yeah, as I was saying, it fails to find a module if we just require it from the tests.


Yeh thats no problem, Can have a look now :)


### [Codacy](https://integration.codacy.com/app/jasonparser/JS-Tests/commit?cid=1069470) detected an issue:
#### Message: `Unexpected console statement.`

#### Occurred on:
+ **Commit**:  010a382bb436a089659d351aff061cc66205ead7
+ **File**:    [test/test.js](https://github.com/nmatpt/JS-Tests/blob/010a382bb436a089659d351aff061cc66205ead7/test/test.js)
+ **LineNum**: [1](https://github.com/nmatpt/JS-Tests/blob/010a382bb436a089659d351aff061cc66205ead7/test/test.js#L1)
+ **Code**:    `console.log("test");`

#### Currently on:
+ **Commit**:  75d174d5cbc7eab9419b0de1c474dfed2ee2ce22
+ **File**:    [test/test.js](https://github.com/nmatpt/JS-Tests/blob/75d174d5cbc7eab9419b0de1c474dfed2ee2ce22/test/test.js)
+ **LineNum**: [1](https://github.com/nmatpt/JS-Tests/blob/75d174d5cbc7eab9419b0de1c474dfed2ee2ce22/test/test.js#L1)


You want to cherry pick these or do you want me to make a PR? I'm still compressing the image BTW.


Missing docs for `log`.


I have just reviewed https://github.com/Wikia/app/commit/027bee2a01ff67d92a5980fddd156013947c64f2 which addresses https://wikia-inc.atlassian.net/browse/SUS-171 and it LGTM :+1:


OK, I've switched to JSHint.


```
BceBaseClient.call(this, config, 'doc', false);
```
43,44两行不需要


Yeh make a single PR if thats easier, dont mind having it broken since its a major upgrade


super


LGTM


reply


uhm we don't support pypy 3.2 anymore IIRC


unack


@AGritsevich, please, use typedef for the arg. I assumes that it should be somewhere in the base class.


ack


TeamCity LabKey :: LabkeyModules15.3 :: Git postgres 9.4 [Build 114](https://teamcity.labkey.org/viewLog.html?buildId=304363&buildTypeId=LabkeyModules153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 19 (2 new), passed: 276, muted: 1 Build time: 01:41:21
### Failed tests
```
org.labkey.test.tests.DataFinderTest.testStudyParticipantCounts: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSearch: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.tests.CDSLoginTest.testSessionTimeoutIntercept: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisFilter: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStickyFinderFilterOnDataset: <no details avaliable>

##### there are 9 more failed tests, see build details
```


I'd mention `git add -p` since it's very handy in that situation. Something like this:

> If the changes to a file are related to several commits use `git add -p` to selectively stage only the changes you want to commit.


coala needs to be changed to - could you file a bug ?


I have just reviewed https://github.com/Wikia/app/commit/edac62e1927c2d38c0f66bc8cb54d3ff3aba4232 which addresses https://wikia-inc.atlassian.net/browse/SUS-146 and it LGTM :+1:


unack, let's keep this in sync with the coala version, think it makes sense


no problem
i am testing and updating kernel git today


unack, put it into `.ci` please


unack .misc -> .ci


Could do with some documentation of the priority documentation attributes/elements are checked in (i.e. “org.gtk.GDBus.DocString attributes will be returned, otherwise the final tp:docstring or fdo:doc element before this node”).


unack .ci


I think it's probably best if it's hidden and documented on something like a Steam tutorial


hello


`FileReader` 好像没有定义？


unack, USER_DIR is only needed in the core coala


This is missing the regex: https://github.com/AtomLinter/linter-scalac/blob/9425acc50a5ca980668ee89ceb20d907bb81f39e/lib/linter-scalac.coffee#L59-L60


K


LGTM


What if `self.comment` is already set? For example in the XML:
```
<tp:docstring>blah</tp:docstring>
<fdo:doc>more blah</fdo:doc>
<method>…</method>
```

The `tp:docstring` will get silently overwritten. Might be a good idea to emit a note log message here to say so. I think a warning is too much, since the XML isn’t actually invalid, it’s just a bit weird.


dunno if it impacts the test results but looks like `aciton:'shouldNotHappen'` has a typo. thanks however for taking care of this issue!


yep


ack


Farhanatou Mohamadoul-Bary February


You may add travis build is green


I disagree ... you may want to release coala but not the bear and vice versa


Right, though maybe not a Steam-specific tutorial (the feature is about how to make the editor portable, i.e. putting its config together with the executable), but more then a tutorial on how to make a portable Godot version (to run from a USB stick anywhere for example, or to distribute in Steam, GOG, itch.io, etc.).


@cvrebert: is markdown-it unused in v4? I can't find any references.


What happened to log domains? Do you have a reason for removing them?


reack


do we want to have item with empty source ?


I could, but I don't think it is really necessary since it is displayed right next to merge button anyway..


Could you use `if isinstance(container, list):` here to get rid of the pylint warning?


如果同时多个文档上传，如何保证每个文档上传时的bucket和key是对的呢？


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 16402](https://teamcity.mesosphere.io/viewLog.html?buildId=139608&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 234 Build time: 00:07:43


done


External devs will not be able to merge anyway so its red button You see :)


@AGritsevich, use prefix increment


Please enclose it in {}


ack then


This equation (and the one above it) don't work out for me. What happened to m? How come two definitions (``:='') are linked by continuation of the calculation?


meh, thanks m(


Please fix indentation and too many blank lines in the all files.


This line is still needed.


`p` can be `const`.


Nice :+1:


reack


@doadin do you have a chance to try this rild? [http://www.mediafire.com/download/x8pc7t15olvrqvx/rild](url)

ı dont have build environment atmunfortunatly ı had to format my pc)
ı compiled it from source with few modifications so ı hope it will work with our old proprietary libril
**without bionic hacks**

do not forget to revert the bionic hacks before compiling
-[https://github.com/AriesVE-DevCon-TEAM/android_bionic/commit/70208219deef6bd79893a23d2e57b6d7bba430a5](url)
-[https://github.com/AriesVE-DevCon-TEAM/android_bionic/commit/b84166856d8a00d97e598550a61154b264e81f91](url)

if it works,we have a chance to get official cm(maybe dream will come true :+1:  )


For small-step, it seems also that we don't really need regularity so far, like for Wadlerfest.


这个操作是`put`还是`post`？


> the AI level is not translated (also intended?)

Nope, that's a bug. Fixed: 7b141205c2758d101d5bbe5c3e4e9bd537a59911