You should add in the CT_Chart element, or whatever the parent element is. We'll need it for reference to know the name and sequence position of the p:title element, or whatever it's called :)  You should be able to cut and paste from one of the other analysis pages, I'm sure it's already been pulled in, let me have a quick look ... here it is on this page:
docs/dev/analysis/features/cht-chart.rst

Note how the attributes are aligned into tabular style for easy scanning. This is important because it's way easy to make a mistake when you have to hunt your eyes back and forth to find the detail you want. I remove redundant minOccurs or maxOccurs attributes from the definitions. The default is minOccurs="1" maxOccurs="1" (one and only one), so you can get rid of the maxOccurs="1" attributes below, but keep the minOccurs="0" ones. These elements become ZeroOrOne in the oxml as I expect you've already discovered.

While you're developing the page, you might as well pull in the complexType definitions for the CT_Title children. I'm curious what a CT_Tx and CT_Layout are for example. One layer down should be sufficient unless we're implementing features that use them. The one for CT_TextBody should be in one of the other analysis documents, already nicely formatted, so you could cut and paste. Never mind CT_ExtensionList, that one shows up everywhere and we ignore it.


POINT FOR v0.1.0

Features:

Read from file

Print statement

Expression

Numeric operations

Boolean operations

Symbol and expression operations

Assignments


why not store as a string and then `strstr()` it like the old code?


* THANK YOU*


Whats the magic number 500? Is that like a max number of stack frames it could build.


@NicolasPetton I'm guessing this is still not in `seq.el`, right? (`map-indexed` I mean)


> the LogThread has terrible repeatability - the thread wakes up anywhere from 10 to 100 msec

We could add a `sleep()` call to the active waits in the main thread and see if this improves repeatability:
```py
    then = start + c['time'] * 1e-3
    while time.clock() < then: time.sleep(interval/2)
```


Hmm ...

They have storage around the level of chests, not the level of jabba barrels.

Maybe they can be set in-between the two by default? Say, 40 or 48 stacks per block instead of "64 is too much" / "32 is too little". They have less flexibility than a chest, more than a barrel.


You should add an XML Examples section here with a collection of real-life XML snippets from files that have a chart title (and one that doesn't, as a baseline). You'll need to clip out a bunch of stuff so they aren't huge; you can just show the parent element and the children down to the title, using ellipses liberally for bits that aren't important for understanding the hierarchy. If you look at some of the other analysis pages you'll see some examples.

This is one of the most insightful parts of the analysis because it shows what the API will implement. Once you've implemented a couple features you can get the gist of the whole implementation pretty much just by looking at the XML samples. It probably seems complex when you're just starting, but once you've done one, probably at least 85% is the same for the next one and then upwards from there :)


... Now this is a real good reason to use the smeltery.


"Sea level" = 64? Vanilla puts the water at 62 inthe overworld.


Looks to be the new code does not take the different initialisation needed for SDCards into account yet. This was mainly why I recomended to use my dev repo as an base.


This should be `for ... of` instead of `for ... in` in the example.


Hi Aurora. Was just having a quick glance through for you and this jumped out. You're checking whether target's an alien here, but the proc's defined it as human.

Haven't got time to look through everything right now, I'll have a closer look later, but hopefully this will help :smile:


miss


This is changing a plain string to a structured python object. Does it work OK?  I remember the class details looked kind of jumbled on the class roster page anyway.


In general the includes in the code use only directories if this is different then the one of the source file. Nothing really wrong here but i think we shoul stay consistent with the existing codebase.


X-Ref: https://github.com/twbs/bootstrap/issues/18569#issuecomment-169541075


Not sure if that's meant to be an exhaustive list of the supported inline formatting or not? e.g. big, small, text color, underlining, and other inline formatting is not reflected in PDF output. Worth an issue?


QUOTE!


@zxdgoal, see corrected/additional tests.


[新年9小时倒计时（截止目前）](http://k-guan.github.io/)


`tostring(key)` is a little redundant in the log message


I left my comments and everything by accident but I have Math 150B homework I need to do and get started on so I will be leaving them. I am sorry.


This type of parsing would break if there is no length validation on the input's value.


Milliseconds need to be separated by a period and not a colon.


Why did you remove the focus?


a check like the one bellow may help avoid some strange use-cases
```
if (key == nil or #key == 0) then
  ngx.log(ngx.DEBUG, "Could not evict an empty key")
   return
end
```


Refactor-Rich-CoolingTower1Spd (energy-plus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1921 of 2089 tests passed, 165 test warnings)

 * 334 tests had: AUD diffs.
 * 329 tests had: BND diffs.
 * 195 tests had: MDD diffs.
 * 212 tests had: MTD diffs.
 * 232 tests had: RDD diffs.
 * 168 tests had: Table big diffs.
 * 11 tests had: MTR small diffs.
 * 11 tests had: ESO small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-91.96%25-yellow.svg)


If the decision is to disable RBF and not even give users the choice of enabling it, I think it would be better to remove the code entirely rather than comment it out / put it inside an 'if false' statement.


By having the macro user already tokenize the path string it doesn't have to be done at runtime, so that's a good start for multi-part paths. This bit here is admittedly ugly but the result is that you can grant command FOO:BAR to a user but not the FOO:BAR:remote version, or you can grant FOO:: to cover every command path in FOO. So it's a little ugly, but recursive. A problem though is that I can't do a lexical nearest-match search in the radix tree to find the nearest or parent command, which may simplify things a bit.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14761](https://teamcity.mesosphere.io/viewLog.html?buildId=127676&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 223 Build time: 00:09:47


Refactor-Rich-CoolingTower1Spd (energy-plus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14762](https://teamcity.mesosphere.io/viewLog.html?buildId=127679&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 224 Build time: 00:06:37


0.031s <ikalog.scenes.game.timer_icon.GameTimerIcon object at 0x109904c88>
3.007s <ikalog.scenes.game.start.GameStart object at 0x10de68da0>
0.002s <ikalog.scenes.game.go_sign.GameGoSign object at 0x11693b358>
0.001s <ikalog.scenes.game.kill.GameKill object at 0x11693b438>
0.001s <ikalog.scenes.game.dead.GameDead object at 0x11693b518>
0.001s <ikalog.scenes.game.oob.GameOutOfBound object at 0x11693b630>
0.584s <ikalog.scenes.game.finish.GameFinish object at 0x11693bb70>
0.002s <ikalog.scenes.game.special_gauge.GameSpecialGauge object at 0x11693bc50>
0.001s <ikalog.scenes.game.special_weapon.GameSpecialWeapon object at 0x11693b668>
0.256s <ikalog.scenes.result_judge.ResultJudge object at 0x116942198>
0.002s <ikalog.scenes.game.ranked_battle_events.GameRankedBattleEvents object at 0x11693b6a0>
0.001s <ikalog.scenes.game.paint_score_tracker.PaintScoreTracker object at 0x116942e80>
0.001s <ikalog.scenes.game.objective_tracker.ObjectiveTracker object at 0x116942eb8>
0.001s <ikalog.scenes.game.splatzone_tracker.SplatzoneTracker object at 0x116942ef0>
0.001s <ikalog.scenes.game.inklings_tracker.InklingsTracker object at 0x116942f60>
0.305s <ikalog.scenes.result_detail.ResultDetail object at 0x116942f98>
0.035s <ikalog.scenes.result_udemae.ResultUdemae object at 0x1169462b0>
0.050s <ikalog.scenes.result_gears.ResultGears object at 0x116946390>
0.003s <ikalog.scenes.result_festa.ResultFesta object at 0x1169466d8>
0.071s <ikalog.scenes.lobby.Lobby object at 0x116946860>


@jnmaloof Fixed! So, if you want to have hidden future posts, just use the [drafts](http://jekyllrb.com/docs/drafts/) feature we talked about last week.


*shrug*


"Capacity can be further boosted with storage upgrades. Upgrades do not need to be applied in sequence, so you can pick the size you need from the start. Capacity upgrades can be mixed and stacked, if you have sufficient upgrade slots available on your drawer. The effective capacity becomes the sum of the upgrade multipliers."

http://www.minecraftforum.net/forums/mapping-and-modding/minecraft-mods/2198533


@oblitum I'm more than happy to add that piece as a note (We have a wiki, I can link from the Readme to the wiki if you want). I too was using YCM for a very long long time. But the recent updates made it unreliable and hard to use. I don't want to complain much as it isn't constructive. Everyone is free to use what they want. But I don't want to recommend anymore it as it's just not compatible.


You're welcome. It drives me insane as well.


We should have a protocol section. One important aspect, I couldn't tell if you'd done it or whether perhaps it was already implemented and I forgot, but we need to be able to detect/read the new chart types, not just create them.

Generally I start with the reading aspects, the reason being that you need that capability in order to test that your add capability is working.

Anyway, maybe protocol looks something like this, you'll know the details better, it's been a while since I've been in this part of the code :)

```python
>>> slide = prs.slides[0]
>>> chart = slide.shape[0].chart  # known area chart
>>> chart.type
AREA (6)  # or whatever the enumeration values are

>>> chart = slide.shapes.add_chart(XX_CHART_TYPE.STACKED_AREA)
>>> chart.type
STACKED_AREA (999)
```
If there's anything else your feature enables it should show up here in the protocol as well.

On the introductory description above, can you address these: Do area charts need any capabilities (properties/methods) that are distinct from other chart types? Or is is pretty much just a formatting style? If there are distinctive operations, are we implementing any of them? Are there some things that are not legal operations on area charts?


Duel.DiscardHand is just a simple way to send cards to grave from hand.
Only using REASON_DISCARD.does it mean "discard".


GSHS RnE report class(기초,심화 알앤이)/sample-report.tex

@evenharder


Can you call out the XML differences for the various types? Like grouping changes from "standard" to "stacked" or whatever. These could just be really localized snippets starting with c:areaChart and just using ellipses for the bits that come after. Folks can infer the details from the full example you've provided.

Btw, in line 48, it should close with matching c:areaChart, you have barChart :)


@Memphiz I just want to let you know, I made a pull request for to yab that fixes this issue.


Will there be any impact to Series class(es) or Chart(s).series propert(ies) because there's a distinct AreaSer element type? Can you summarize whatever impact there will be or why it won't matter if that's the case?


Space before bracket not after.


I've read math that suggets 4.5 seconds is the optimal crossover point - can't find a link now, but it depends on the ilvl of both your ring and the capacitor, but most of the values were in the 4.2-4.8 band.


I wrote this last year as well, just making some minor changes to make it more readable


Needs to be an acceptance test for recognizes the chart types you're adding. I think there's already an acceptance test for that and we can just add Examples to cover the new possibilities. This will also entail updating the test .pptx file that test uses.

If there isn't an acceptance test for that we'll need to add one. When I started doing chart features I experimented with not adding tests. That experiment rapidly proved an unwise practice and so I had to add them in retroactively. I might not have gotten them all as far as chart types are concerned :)


Refactor-Rich-CoolingTower1Spd (energy-plus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (957 of 957 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.88%25-green.svg)


You're welcome ;)


I'll come back to the implementation commits once we've got the analysis document and acceptance tests resolved. The reason being the implementation sequence is driven by the order of acceptance test failures. So this commit will probably need breaking up into a couple commits but that will all make itself apparent when the acceptance tests are in place.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14763](https://teamcity.mesosphere.io/viewLog.html?buildId=127687&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 223 Build time: 00:03:19


Yea


FIXME: Display actual discount when specific + quantity combination


# Creating output list


ok i think i got it figured out... been struggling with  params and now finally it clicked in my head on  'params' and how to use it.


Space after comma.


# output list


It will be best to keep the analysis document to a single commit, at least for this feature. So once you've made your updates you can just rebase this into the first commit.

Are you facile with rebasing? I can help you along if you're not fluent with that yet; I remember it was anxiety-producing when I got started with it but just do it all the time now. Keeps the noise in the commit history way down.


Too many spaces after 'mesh,'?


This is equivalent to (move != ss->killers[0] || ss->killers[1] == MOVE_NONE). Was that your intention?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14764](https://teamcity.mesosphere.io/viewLog.html?buildId=127692&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 223 Build time: 00:03:22


Thanks! :)


I forgot to note that '25' is used in correlation to Abandoned Misery using said mentioned DM player start markers.


what's going on here?


better change `node.Labels[topologyKey] != ""` to `len(node.Labels[topologyKey]) > 0`? since you already do `if len(topologyKey) == 0`


Spaces either side of ? and : in ternary operator.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14765](https://teamcity.mesosphere.io/viewLog.html?buildId=127700&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 223 Build time: 00:03:51


i install this fle


I actually might be able to simplify this nonetheless by just putting a vector in the radix tree so THAT doesn't have to be parsed at runtime this way either. I'll have a look at it when I'm sober :)


this looks fragile...

this assumes that  `||` shortcuts at the CPP-level, and that
either `MIN_VERSION_unix` or  `mingw32_HOST_OS` is defined...


Oops.


Uploaded to Chocolatey, pending review


s/combindly/combinedly/


@Makman2  I didn't get this?


@yuuuuuumi
ありがとうーこれから確認しますー！


So I was confused as to how you would implement an actual tree as it's own class, separate from the node? Since Python doesn't have pointers and such.


Sorry, what does this do?


can be optimized to
```go
podSymmetryAntiAffinityTerms = currpod.Spec.Affinity.PodAntiAffinity.RequiredDuringSchedulingRequiredDuringExecution
```


duplicated white-spaces:
```
podAntiAffinityTerm of  podAntiAffinityTerms
```


s/QX11Info and other wrappers/Qt X11 Extras' module wrappers

? :)


unnecessary white line


Thank you.


> this assumes that  `||` shortcuts at the CPP-level

It does: https://gcc.gnu.org/onlinedocs/cpp/If.html
Also, invocations of unknown macros are replaced with 0 (if I'm reading C99 6.10.2 correctly).


Yeah I agree, I didn't notice it removed those.


How are we pre-configuring this without testing how many bytes are to be received? We have seen in the past that it's too late to test for quantity after the I2C_Send7bitAddress() is called for 1 byte, so I2C_AcknowledgeConfig(i2cMap[i2c]->I2C_Peripheral, DISABLE); done later can be too late and an ACK gets sent.


needs a white line before new function


only unknown non-function macros, though!

i.e. if you attempt to call an undefined `MIN_VERSION_foobar(1,2,3)` you'll get a hard CPP error rather than a `0`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14766](https://teamcity.mesosphere.io/viewLog.html?buildId=127716&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 223 Build time: 00:08:44


@bbatsov no, it's not. But it's in my todo list of the week now :)


@cdent: If you feel like reverse engineering, I'd appreciate your perspective; any ideas on how to proceed? It's just general curiosity though, so very low priority.


Yayy 🙌


will this affect 3d editor too?


Why do you commit json/xml files? I believe they should be ignored


Well, I just realized that it won't be that simple. Emacs-25 being in freeze, I won't add anything new to the API of seq.el for Emacs 25.1.  This means that the upcoming release of Emacs won't have this, so you won't be able to use it until Emacs 25.2.


Oops, I'm a bad person for committing directly to master :(


Super...


There's `Array.forEach` and `Array.every()` for this. It's safer to use them, since they won't fails if you mess up with the array object while iterating it.


It's not Python. JS supports decrement operator `--`.


Again. `Array.every()`


Has anybody even tried compiling the fragment?

I just tried throwing the following CPP fragment at `gcc`

```c
#define mingw32_HOST_OS 1

#if defined(mingw32_HOST_OS) || (MIN_VERSION_directory(1,2,1) && MIN_VERSION_unix(2,6,0))

#endif
```

and it failed as I expected with:

```
$ gcc -c foo.c
foo.c:3:55: error: missing binary operator before token "("
 #if defined(mingw32_HOST_OS) || (MIN_VERSION_directory(1,2,1) && MIN_VERSION_unix(2,6,0))
                                                       ^
```


Really cool! :+1:


BTW, you might generate a bunch of `Promise`s here and wait with `Promise.all()` for them to resolve. It's much more async way.


okay


I fell like now it is getting really full in these lines. Can you
- put each element (div, a, img) into a separate line?
- move the style of the attributes to a css file?


:-( Maybe we can bend the rules a bit just time. ;-)


This one is still a JavaScript function. Would it be better if it was a link with some content? What are your thoughts on this?


IIRC, this is based on empirical result (being the sweet spot for performance).

You're best bet is to benchmark it and change the value to see.

(I'm using this benchmark this days: https://github.com/aloiscochard/scato/blob/master/benchmarks/src/main/scala/FreeMonads.scala)


unnecessary white line


In the Keys.js file, did you retain the single quotations that surround the
API keys, address, etc? Did you retain the place_id: prefix for the origin
and destination for traffic? If so, it's likely some other formatting issue
with your keys.js file. If you're still having problems, could you either
send me your keys.js file, or a screenshot of it?

On Sat, Feb 6, 2016 at 10:51 PM, Scott Rodgers <notifications@github.com>
wrote:

> I have tried to run the latest version of this code and am having issues
> with 2 ajax calls (one going to weather.php and one going to traffic.php) I
> was able to recreate successfully the call that should be going out to the
> google directions api and had good results with the values in my Key.js
> file. Any ideas?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/leadlag/MagicMirror/commit/9e4c9505196a27a113a17a6b4c5c5eafab91c14a#commitcomment-15936309>
> .
>


+                    proxy = "http://" + lines[proxy_line];


Looks good. Thank you for this.


Refactor-Rich-CoolingTower1Spd (energy-plus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1508 of 1508 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.68%25-green.svg)


Just tested it and it looks like you're right. `#if 1 || UNDEFINED` works, but `#if 1 || UNDEFINED(1,2,3)` doesn't.


{player distance _house < 12} maybe?


Yes sorry i will fix


Git keeps track of all changes happening. You'd better drop those lines permanently, but committing it as a single change. This way you'll be able to run `git revert <commit_hash>` to get these lines back.
Moreover, such commenting in a commit:
1. Sucks
1. Is useless
1. Makes review damn complicated

P.S. Do not mess with several changes in a commit! Bear in mind one single rule: make one commit for one single atomic change. i.e. don't mix up code refactoring with adding/removing feature etc.


Thanks, this is great.
On 7 Feb 2016 04:24, "brian-peloton" <notifications@github.com> wrote:

> Again, sorry about missing that; you were right that some of my code had
> nothing to do with the commit title... Resubmitted with an actual
> explanation as #1777 <https://github.com/zeromq/libzmq/pull/1777>.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zeromq/libzmq/commit/f4fe375bd1a650209c37ab3c4de09830dbe6d3f7#commitcomment-15936268>
> .
>


The sprite had 5 colours instead of 4, causing it to throw errors at compile. Running shoes ported from Red++, bike made faster so that it isn't rendered pointless by Running Shoes, surfing made faster because it would be just as annoying as walking.


looks good thanks!


existing logger package is your savior
https://www.loggly.com/blog/three-node-js-libraries-which-make-sophisticated-logging-simplers/
https://www.npmjs.com/browse/keyword/logging


You should not automatically convert StdClass to array. It's better to let the choice with a parameter, like in json_decode function with the "assoc" parameter.


@msroot No way! I've moved back to India as well! I guess our paths will cross again soon one way or another! :)


我来评价一下这个建议·


Trappist time


Assignment 2


@yuuuuuumi

あ、おれが欲しい色のパターンを連絡してなかったねー!

以下の種類について、色を教えて下さいー。
背景色とテキスト色で色パターン貰えると助かります。

* alert
* warning
* infomation
* success
* normal

以下のページを観てもらうとイメージつきやすいかもしれない。
http://getbootstrap.com/components/#alerts


全体のイメージ把握したので、これで一階作ってみるよー。
タイトルのフォントはちょっと考えてみるけど、一番最後の細いやつにしようとおもうー。
これも新しいタイトルを考えたらーって感じでー!


This would work. Could you use an array instead, with all the names? It is less code, then.


NPC 17443 EventAI need or not?)


According to the design doc, I now don't think we can simply return true here when the node is empty.
> Note that while RequiredDuringScheduling anti-affinity is symmetric,
RequiredDuringScheduling affinity is *not* symmetric. That is, if the pods of S1 have a RequiredDuringScheduling affinity rule "run me on nodes that are running
pods from S2," it is not required that there be S1 pods on a node in order to schedule a S2 pod onto that node. More
specifically, if S1 has the aforementioned RequiredDuringScheduling affinity rule, then
* if a node is empty, you can schedule S2 onto the node
* if a node is empty, you cannot schedule S1 onto the node
* if a node is running S2, you can schedule S1 onto the node
* if a node is running S1+S2 and S1 terminates, S2 continues running
* if a node is running S1+S2 and S2 terminates, the system terminates S1 (eventually)


mistake, not function calls but declared functions


The second line should become: `For example, for VCF version 4.3, this line is`


:D


None - I just wanted to do that in a separate commit so I'm not testing 30 changes at once.


This guard is here, because my DbgHelp version is unable to demangle the corresponding name. I'll try to find a way to version the DbgHelp and disable it for this condition.


There is a provision in the name sentence for engine or shaft number. I have not seen this message in use other than homemade devices, but it is perhaps cleaner to use the name input from sentence than to hardcode engine1.


The meta-information lines are optional in VCF, so the wording is not quite accurate here. However, the binary version does need them so this wording is fine with me.


Thank you @sparrc!
Looking forward for the updates.
I've added an issue #659 with my thoughts.
Hopefully I find some time to implement that as well.


Yes, that's what I meant. Have you found a correction for that?


The next step is to compile SDL2_mixer with FluidSynth support...


So with 2FA usage enabled we want players to do `/register`, right? Right now they are still forced to use `/register pass pass`.


Yes


Neither CoreFX nor CoreCLR were using the older name (and the images weren't prepped so no one else could have).  Moving this to the correct format based on everyone else.


Hallo Bernd, ich hab's mir jetzt mal angeschaut, dazu ein paar Kommentare:

* Der Code ist extrem langsam, da du sehr oft per jQuery immer wieder die selbe, langsame Abfrage machst. Mach solche Abfragen prinzipiell nur einmal, und speicher das Ergebnis (Objektreferenz) in einer Variable. Das solltest du dir angewöhnen.

* Das heraustrennen des Dateinamens ist bei dir sehr umständlich. Schau dir mal die funktion `split()` an - ich hab nicht ohne Grund als Beispiel-tag alles in Doppelpunkte gekapselt. ;)

* Bitte den Code in eine separate .js Datei ausgliedern, sonst kann man das später nicht mehr sauber integrieren/abändern.

* Für den ToDo Punkt e): Denk dran, dass wir nicht nur die Beispieldaten richtig unterstützten müssen, sondern beliebige Daten. eine Funktion, die automatisch Datensätze mit sehr vielen einzelpunkten Aggregiert ist eine gute Idee, muss dann aber abstrakt genug ausgeführt sein, damit sie mit anderen Datensätzen ebenso klar kommt.


Not really any use. Just makes code easier to read right?


@dougbu so far this issue has only manifested to this extent in the `DataProtection` repo where I had to force all of the test projects to a specific `System.Runtime`. I have on the other hand a few other repos where it manifests in a single test project (not all of them).


Shouldn't we use a stronger wording here: `Meta-information lines are optional but RECOMMENDED, and if present, they MUST be well-formed.`


@dougbu The antiforgery repo looks to have built on the CI 7hrs ago. Do you see your issue via `./build verify` when running against the aspnetvolatile feed?


you would better import OrderedDict from collections


> смены кодировки при декодировании
Имеется в виду выбор кодировки конечного, декодированного, файла.


Same as above, meta-information lines are optional.


Do you really need the extra loop....? Or can we also consider to add the state ended check after the if?


I'd rather name this with some more descriptive name. E.g. `additional-params` or whatever.


Same here.


And here.


Here too.


Hmm This is an interesting effect. Quite difficult to control I find. Can you give further examples of usage. You can certainly produce a wide variety of sounds from it, but so far I wouldn't say I have produced the described effect. I've tried various synths to drive it and various note frequencies. Also samples like :ambichoir. One further point. It seems odd to number the voice from 0 but the vowel from 1. Would it be better to have both from 1 (or zero).


In fact that was already broken as it replaced all the characters by undersoceres... Indeed we need a new solution for you here....
Bur for picons you also cannot use servicd names....


I think you have a bit of a race condition here, because even if you sleep for 50ms, you cannot guarantee that the worker process has started. And, since you don't initialize the progress value before starting, it may already be at 1.0 from a previous call, and then you would skip over printing the correct messages. A suggestion to fix the race condition and clean up this code a bit, is to replace your triple of progress values in `APS2` with:
```c++
std::atomic<APS2_TASK> task;
std::atomic<double> task_progress;
```

where `APS2_TASK` is an enum defined as something like:
```c++
enum APS2_TASK {STARTING, ERASING, WRITING, VALIDATING, DONE};
```
then create a `clear_progress()` instance method to set `task = STARTING;` before creating `thread_future`. Then this set of 4 do-while loops can collapse to a single loop waiting for `task == DONE` (assuming you also update the task value in the process).


`Compression of a BCF file is RECOMMENDED but not required`


TeamCity LabKey :: Trunk :: Community :: CDS postgres 9.5 [Build 91](https://teamcity.labkey.org/viewLog.html?buildId=301457&buildTypeId=LabkeyTrunk_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 14, passed: 34 Build time: 01:08:55
### Failed tests
```
org.labkey.test.tests.CDSHelpCenterTest.verifyHelpCenter: <no details avaliable>

org.labkey.test.tests.CDSSecurityTest.verifyUserPermissions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogAndLinearScales: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyCounts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

##### there are 4 more failed tests, see build details
```


@NTaylorMullen yes. In Antiforgery on the volatile feed, compilation succeeds but .NET Core test execution fails as I showed above. aspnetcidev is fine for Antiforgery but can't be used for many repos higher in the stack.

(Antiforgery succeeds on our CI machines because those builds don't test.)


`It MUST be the length of the REF allele or the declared length of a symbolic allele respecting the END attribute`


This has been reported in issue #218, fixed, and released. Sorry for any trouble.


Says who?
QA "deprecated" its usage for all I was able to find. This deprecation is neither documented in the eclass nor its man-page nor is it anywhere stated how this deprecation affects ebuild-writing as in location of /usr/{bin,lib,share}/ , user:group modification etc.


you create domNode for each test but use it only inside one. Why don't you create inside that test?


forgot to clean up `selectMultipleEl`?


![plot1 png](https://cloud.githubusercontent.com/assets/17105782/12871613/5b431930-cda9-11e5-9ef1-bba8346bacd1.png)

![plot2 png](https://cloud.githubusercontent.com/assets/17105782/12871614/5b516346-cda9-11e5-9e97-d36da4584830.png)

![plot3 png](https://cloud.githubusercontent.com/assets/17105782/12871615/5b5bbfa8-cda9-11e5-9843-735f184a8927.png)

![plot4 png](https://cloud.githubusercontent.com/assets/17105782/12871616/5b838e34-cda9-11e5-96d2-d53db26f4cba.png)


Great! Thanks a ton.


This is great, thank you! Could you make the pull request against the master please?


Не совсем наверное хорошо выразился =)
Чтобы можно было работать с 2-мя кодировками наравне, как в сторону раскодирования, так и  в сторону закодирования.


import java.awt.*;
import java.awt.event.*;
import java.io.*;
import java.util.*;
import java.util.List.*;
import javax.swing.*;
import javax.swing.Timer.*;

public class SystemTrayTest {

  public static void main(String[] args)
  {
     SystemTrayApp = new SystemTrayApp();
     app.init();
  }
}

class SystemTrayApp
{
   public void init()
   {
      final TrayIcon trayIcon;

      if (!SystemTray.isSupported())
       {
          System.err.println("System. tray is not supported.");
       }

       SystemTray tray = SysteTray.getSystemTray();
       Image image = new ImageIcon(getClass().getResource("cookie.png")).getImage();

       PopupMenu popup = new PopMenu();

       MenuItem exitItem = new MenuItem("Exit");
       exitItem.addActionListener(new ActionListener()
       {
          public void actionPerformed(ActionEvent e)
          {
            System.exit(0);
          }
        });
    popup.add(exitItem);

    trayIcon = new TrayIcon(image, "Your Fortune", popup);

    trayIcon.setImageAutoSize(true);
    trayIcon.addActionListener(new ActionListener()
    {
       public void actionPerformed(ActionEvent e)
        {
           trayIcon.displayMessage("How do I turn this off", "Right-click on the fortune cookie and select Exit.", TrayIconMessageType.INFO);
        }
     });

   try
   {
      tray.add(trayIcon);
   }

   catch (AWTException e)
   {
      System.err.println("TrayIcon could not be added.");
      return;
   }

   final List<String> fortunes = readFortunes();
   Timer timer = new Timer(10000, new ActionListener()
     {
        public void actionPerformed(ActionEvent e)
        {
           int index = (int) (fortunes.size() + Math.random());
           trayIcon.displayMessage("Your fortune", fortunes.get(index), TrayIcon.MessageType.INFO);
        }
      });
    timer.start();
 }

 private List<String> readFortunes()
 {
     List<String> fortunes = new ArrayList<>();
     try (InputStream inStream = getClass().getResourcesAsStream("fortunes"))
     {
       Scanner in = new Scanner(inStream);
       StringBuilder fortune = new StringBuilder();
       while(in.hasNextLine(()
       if (line.equals("%"))
       {
          fortunes.add(fortune.toString());
          fortune = new StringBuilder();
       }
       else
       {
          fortune.append(line);
          fortune.append(' ');

       }
     }
  }

  catch (IOException ex)
  {
    ex.printStackTrace();
  }

  return fortunes;
 }
}


This is testing the result of a call to [net.DialTimeout](http://golang.org/pkg/net#DialTimeout) with an argument of "tcp". The code paths for custom dialers are below.

You were likely hit by #218 as well, but not when using a custom dialer.


・OAuth
・show timeline
・reload timeline
・tweet text and image (in another Activity)


Change to this function triggers assert in S3DModelPiece::SetModelMatrix.
This is because float3::equals is broken when comparing against ZeroVector.
float3::equals needs to be fixed, how about
  math::fabs(x - f.x) <= eps.x (eps should always be positive so fabs is not needed imo)
instead of
  math::fabs(x - f.x) <= math::fabs(eps.x * x)
as it is now ?

You can reproduce this by starting zk and you will get assert when objects3d/gauss_91.dae loads, x is -1.16322064e-25.


please use tabs to indent


same here: tabs, please.


Disconnected + sign?


Ответил также в теме, я имел ввиду кодировку этой локализации
http://steamcommunity.com/sharedfiles/filedetails/?id=537911801


I guess you've got a slack team, mind opening it to the public so we could communicate on issues?


remove .configuration files
indentation size = 4 spaces


Nichtsdestotrotz wird der Abschnitt etwas merkwürdig. Wäre vorher stets Java-Klassen mit ihren Methoden beschrieben wurde, wird jetzt ein Script aufgeführt. Deshalb hatte ich die Idee, es in den GeneTranslator mit einzubauen


thanks to you!


No, leave it immafreedom.eu


I have changed it xD


Hi Martin,
schreib das bitte mit rein, damit man weiß worum es geht


That's why I committed


2263行 216.58.217.12	check.googlezip.net 得注释掉
这个不能使用ggc，也不能使用普通的gws
必须以114结尾的官方gws ip，因为证书是*.google.com的原因全被封完了

# Google:others
220.255.2.153 abc.xyz

# Recaptcha
220.255.2.153 www.recaptcha.net
220.255.2.153 api.recaptcha.net
220.255.2.153 api-secure.recaptcha.net
220.255.2.153 mailhide.recaptcha.net

# Amazon AWS
54.231.48.40 github-com.s3.amazonaws.com

@andytimes @K-Guan


"short" day names should be unique. You should stick to 2-letter abbreviations, at least.


select a geojson file as you want and change GeoJson's path;


spellppmRate no, spellcooldown yes - i will remove it


(1) Please note this commit: https://github.com/osmandapp/Osmand/commit/69ccde4bdb28b7e6b93006efb988787079e42419

(2) Also: Could we please have a numerical display (0-255) again somewhere, so we can create reproducible situations?

(3) And: for many users not knowing what they do, I guess a "Default" button would be good  :-)

Thx - Hardy


The assessment.maximum_grade might be nil and the new line will throw an error for that.


Interesting. It seems to me at's an alias for `.valueOf()`. Or maybe JS calls `valueOf` on the object because of the addition operator. Something like that.


{"message":"Cannot read property 'indexOf' of null","name":"TypeError","stack":"TypeError: Cannot read property 'indexOf' of null\n    at $mypath/node_modules/hexo-generator-sitemap/lib/generator.js:25:60\n    at Array.filter (native)\n    at Hexo.module.exports (/$mypath/node_modules/hexo-generator-sitemap/lib/generator.js:24:6)\n    at Hexo.tryCatcher (/$mypath/node_modules/hexo/node_modules/bluebird/js/main/util.js:26:23)\n


@sun11 Thanks. I'll fix it later.


wa doesn't have a capital letter.


Sounds sensible. Although in this case grayscale_*.png is responsible for the shadows on the windows.  I'll take a look at the code and see if I can rearrange so the window also uses black_*.png and then check out whether grayscale looks good as the default reflection.


**that was very bad rewrite** @wicked-sick


не михаресва


ok


the info.plist.in shouldn't be in the deb - the plist.info is a binary plist and you should be able to open it in xcode for example - no clue how this could get corrupted - because xcode makes the binary plist from our text version...


这样使用别人的链接真的好吗
为何不新建一个repo来存放图片然后使用raw呢

    https://raw.githubusercontent.com/[owner]/[repo]/master/[filename]


I often have to "echo "user/*" >> .gitignore" because of this kind of issues.
After few commits, remove "user/*" from .gitignore and try to build.


still good @eRkuL


Предложи промени.


"Close" should actually just be "close" here, not "Close Pale Moon". it's to close the print preview, not the browser.


Back to old version.


Now you just have to add the logo in /img/clients and add an entry in the clients.yml.
All the carousels will be updated.


If you create a pull request on this, we have a place to discuss things.

I think the -1 approach could work, and we could even add a -1 enum value to all unit enums, to represent this, but it does smell a bit like fixing things at the wrong end.

How about we change the dictionary that maps "cup" to a list of thee Volume units instead of a single Volume unit? This way we should be able to throw if the count is more than 1 in the case of Parse().

Regarding works when running single test but not when running the entire suit of tests surely smells like a racing condition. UnitSystem uses static fields and these will be shared across units in the same test assembly, so I think you've stumble across a lack of thread-safety in UnitSystem. Some lock() ing should help on this.

I don't have much time at the moment to look closer at the source, and I will be away on the bi-annual national military training all next week (ugh..), but hopefully this helps you in the right direction.


isStopped


I guess this can be relaxed to:
Dependencies have diverged:
* ecto (Hex package)
  the dependency ecto

  > In deps/timex_ecto/mix.exs:
    {:ecto, "~> 1.1", [optional: false, hex: :ecto, manager: :mix]}

  does not match the requirement specified

  > In deps/phoenix_ecto/mix.exs:
    {:ecto, "~> 1.1.2", [optional: false, hex: :ecto]}

  Ensure they match or specify one of the above in your deps and set "override: true"
** (Mix) Can't continue due to errors on dependencies


Can you add a spec for this?


yeah, wrong message...


See my other comment that these MUST be unique. you can't have two "M" ones in there.


@GatorQue: This looks like a typo. Shouldn't this be project.flow.branch_develo**p**?


They don't seem to do that much on non-HTC ROM (ie. camera works just fine without them) and I'm trying to cut down all the junk to possibly figure out why camera binaries & libs are making the rest of the system to crawl.

http://forum.xda-developers.com/showpost.php?p=65024627&postcount=86


PS: Something is still unfinished with your string assignment in these documents, but we have all 4 strings you need already as follows, no need for new strings:
    <string name="overlay_transparency_descr">Modify overlay transparency</string>
    <string name="overlay_transparency">Overlay transparency</string>
    <string name="map_transparency_descr">Modify base map transparency</string>
    <string name="map_transparency">Base map transparency</string>
also, if needed:
    <string name="modify_transparency">Modify transparency (0 - transparent, 255 - opaque)</string>


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1318](http://teamcity.monogame.net/viewLog.html?buildId=14477&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Just make it "Close" here too.


This will probably break the initial `repo flow init` attempt.


kB = ISO = 1000 B
KB = IEC(JEDEC) = 1024 B


kB/KB ditto


@GatorQue: Are you planning to also check whether the .git/config is consistent before advancing?


@Mariannach Вибачте, але в такому разі окремі речення не матимуть сенсу. В данному випадку ці частини речення є взаємозалежними.


Dude, I'm the owner of http://spritestorm.com/ , and I'm busily coding a sprite engine I've been working on for years called Spritestorm. Not harassing you, but you're not being very original, and there may be some confusion when I release my software shortly ;)


I'm away from the computer until Tuesday if you want to go add it now


some more comments


Wow


Thanks for making the effort to do this. Also add a signed-off-by for this commit


I love list operations


This import shouldn't be needed


Hmm, let's pick one release of Jekyll and stick with it because the :latest tag will also fetch the newest (possibly unstable/unsupported). How about 3.02?


What does this line and the line below it do?


Un experimento en el cual evaluamos la posibilidad de mantener una estabilidad en una isla, comparando varias tasas de natalidad y como esto afecta la sobrepoblación al cabo de x tiempo.
r= la tasa de natalidad
Yn= es el numero de veces evaluadas


Is there a reason we choose to mount /src instead of /srv/jekyll as specified in our other installations of jekyll?


Very nice. I'll let you flush out the details here, then I'll copy it 😉


I think this pattern would be clearer here:
```elixir
(if scheme, do: scheme <> ":", else: "") <>
(if authority, do: "//" <> authority, else: "") <>
(if path, do: path, else: "") <>
(if query, do: "?" <> query, else: "") <>
(if fragment, do: "#" <> fragment, else: "")
```


this is a good choice. Since we are ever only going to serve our jekyll site, let's automate this even more. Have it so that when we run this image, we will automatically serve the site as well.

This page might be [helpful](http://stackoverflow.com/questions/21553353/what-is-the-difference-between-cmd-and-entrypoint-in-a-dockerfile)


This extra whitespace isn't needed


@TheMightyWarPig looks pretty good so far, just a few things:
* Can you remove all of the commented-out code and unused methods (like intake(), bowlLow(), etc)? We will add methods as we need them
* We will need a command for RunShooterManually (or similar) that passes the OI value to the subsystem. It should be set as the default command in the subsystem.


Need a maintainer email address so that we know who to contact about this Dockerfile


Can confirm that this works as is, good job!

However, we want to minimize this command as much as possible.
Specifically, let's get rid of
- serve by using CMD
- and the -v command. Use ADD in Dockerfile to mount the jekyll files instead


This is the auto-open/close quickfix part.

If you do something that populates quickfix (make or grep), this will open it immediately, so you don't need to :copen it. Similarly, when you do something to clear it (fix the error and rerun make), it'll close, no need to :wq it.


Also, can we use a separate joystick for this (throttle axis)? We should use the same joystick that we used for the lift last year.


This looks good Scott, thanks for getting it to work!
I have made some inline comments that maybe you get working on.
Moreover, why don't you make a fork of the pioneers/website repo (you probably have already) and then commit your Dockerfile into the top level of THAT repo so that we will be ready to go :D

Thanks and let me know if you need anything


In case it's not clear, I copied it from some Google result. I have no idea what the actual vim commands are doing.


I'm late to the game here, but this change is not backwards compatible. This will break all other instances of add (I know of one such place in SSHKeyStore). A better interface would be:
```
add: function(model, options)
```


I am flattered Dongchul, Thank you!!!


:+1:
but maybe paren on the other side: `if(path, do: path, else: "")`?


@lexmag yes, good point.


Can you add a comment annotating the meaning of the boolean return value? (e.g. `// returns true on success`). There are alternative conventions in which non-zero return values represent errors instead, so I believe it should be made explicit.

An alternative approach is an enum, but that seems overkill to me.


The Dpad's inputs are not calculated like sticks. They are buttons with booleans (pressed & !pressed), but is different from normal gamepad buttons.


Updating the Markup


хуй


Files Copied over from Secondary Repository found here: https://github.com/Dave89rr/ThinksterTutorial


Guys solver functionality is not 100% working. I am still working on that. Secondly, it is not returning anything except the final state of the board. To get the board at each step, i'll implement a function, which stores the each state of board and will be helpful for you during Andriod implementation.


Can you please stop abusing SPRT:
"After 10000 games played we will eventually reconsider if together with the old result this test is worth to go on..."

- If you want to measure ELO gain, use fixed game testing.
- If you want to get a single yes/no result, use SPRT.

Everything else is just unsound.


@Nazeebo
блядина,
Головка, шлюха, жопа, член, еблан, петух, мудила,
Рукоблуд, ссанина, очко, блядун, вагина,
Сука, ебланище, влагалище, пердун, дрочила

Пидор, пизда, туз, малафья, гомик, мудила, пилотка, манда,
Анус, вагина, путана, педрила, шалава, хуила, мошонка, елда.

Раунд!


d64 specifies requiring 64-bit server Java, nogui helps in headless (command line only) environments.


We have to add the equivalent of SAGE echelon function() to solve the System of Linear Eqns..


i'm stupid


that's right


p


You are absolutely right. Fixing it now.


this is hilarious


The greatest part is that it even has his picture.


Caching the Inverse of a Matrix


FYI, on merge conflicts,
on `git pull`:
```<<<<<<< HEAD
// These are local changes, your copy
=======
// These are remote changes, the commit trying to merge in
```


blah blah


s/Author/mailmap:/


第二次描述


comment


TCMB, not 0


Make this a define or a var


Just an unrelated note but if cryo is gonna be 'serious danger' and not 'ow I bruised my knee' maybe change the sleeping/paralysis values?


Also, running
```
docker run -it <image> serve
```
is helpful if you want to get output from jekyll as it's doing stuff, incase you didn't find out already


Use an array of two by two (matrix (4, 3, 3, 2), 2, 2) and its inverse matrix (-2, 3, 3, -4), to prove that the functions run properly. Detects an error traceback () in cacheSolve () function, manually reviewed, and detects inv was not defined, so change m inv. With this change I noticed that the functions if you give them an invertible matrix gives back the inverse of the matrix.


I think that I'm going to stick with `matplotlib` for now - the nice thing about saving the original config file with the resulting datalog is that it's much easier to generalize the plotting code. Right now Bokeh does not let us create PNG files programatically either.


Duplicate of the line below (Ma Jianpeng)


libpng-dev, ok

I managed to separate wargus and aleonas tales into separate packages. The problem is in wargus: seems that I need an empty directory tree (after I remove graphics of aleonas tales):
graphics/human
graphics/human/units
graphics/human/buildings

The thing is git seems to ignore such empty trees and they are gone from my wargus fork now. So either
a) I put some dummy files in each subdirectory or
b) I get rid of this structure in the repo, but I recreate it on install via some cmake procedures.
c) ?

Which one would be preferable?


I explain the details further down. Basically, any AsciiDoc formatted allowed in a paragraph (that also works in Asciidoctor PDF) is supported in the running content.


Thanks!


いきなり master にコミットすんなし・・・
ブランチ切ろうぜ


It was causing issues on my linux machine too


@winterhell I've forked the code & you can too (anyone/everyone can it's open source w/ no usage restrictions), so even if @thefiddler  is never heard from again, we can use this code to start a new project if we want to.  But I hope we hear from @thefiddler soon.

And good news, I think the WinForm & WPF stuff is probably working; I wasn't using the latest version.


@curiosityflow Good work here Maritza.


your message has formatting -10 for mailing list style


@curiosityflow pry is going to be great friend.


Happy birthday. Best brother ever!  Been getting way deeper into PowerShell recently.  Thanks for this.


what do u mean? whats wrong with this


@JustAkan 시간될때 컴파일 해볼 생각입니다.
명절 잘 보내시고요.


That's one humongous commit!


Nice one!


necromancer is back!


not yet noob! kkkkk


![_h 599a d7savm9 9cwz 3p](https://cloud.githubusercontent.com/assets/8656410/12876802/869ec2d4-ce42-11e5-881b-167cfe35a73e.jpg)


Ooops :+1: :smile:


@The-Slime Can you test this like you did earlier to confirm this fixes it 100% of the time.


These aren't needed anymore -- use the `ColumnDescriptor`


Pass this in the `ColumnDescriptor`


ASD A


I'm guessing the card graphic corruption might be the typical Italian thing, where they weren't allowed to show playing cards, so intentionally corrupted the layout data in the program rom, we have several other games where that has clearly been made as an intentional change


Is this order correct?


+1. Like this commit.


Nice. will have a try later on.

Plans to include custom/type specific (de-)serialisation-functions ?


WIP


Does this change mean I cannot use `hid_listen` unless I re-enable it?


This is a test


Ha, asdf.

Sincerely,
Kyle
On Feb 7, 2016 6:25 PM, "HoraceDing" <notifications@github.com> wrote:

> Actually professor, all of those "asds" have very profound and insightful
> meanings. For example, the second to last "asd" really just meant that I
> had changed the SESSION SECRET value and added some more HTML code.
>
> On Sun, Feb 7, 2016 at 3:56 PM, Kyle L. Jensen <notifications@github.com>
> wrote:
>
> > Terrible, terrible commit messages! :)
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_HoraceDing_thankswooje_commit_45fa98aaea781fe6707ad7d9a2f88c29bde6e6ee-23commitcomment-2D15940776&d=AwMCaQ&c=-dg2m7zWuuDZ0MUcV7Sdqw&r=CBVwOZsB0DJ720SHFQJBRqywpbqkKcpNjSeoyD5l4aE&m=rbdvLodrKkv98dZsT9yXQX28C3TNsm0J2ibKE3YIGYQ&s=caFLIUZicqKKjq7N6QXcN8X7WdcKq-udSF-RJBe11e0&e=
> >
> > .
> >
>
>
>
> --
> Aujer (AJ) Ding
> Yale College '18
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/HoraceDing/thankswooje/commit/45fa98aaea781fe6707ad7d9a2f88c29bde6e6ee#commitcomment-15941491>
> .
>


Good point, I'll change this


Wrong offset?


The version check here isn't necessary if, like you mention below, this table is only available with kernel 3.7 and up.


:confused:


This can be added to a .babelrc file in the root of the project or in the package.json under the `babel` key


Though perhaps the whole block should be excluded if we're on a kernel less than 3.7?


oops, my mistake.


enabled ES6 features


enabled ES7 features


Hi! Can you open pull request for this change?


```ruby
before_save -> { self.email = email.downcase }
```


That would mean that if someone tries to use a `simple_iptables_rule` with the IPv6 `nat` table on an older kernel, the cookbook will silently not generate the rules. I prefer a failure in that case, instead, to let the author know that that they intended isn't working.


Ahh, yeah would be good if you leave a comment.


Args have been passed to open since the beginning (3f0740c8); this commit only makes it so that applications that do not override `open()` don't get errors (similar to the other HTTP verb methods). See #1242


NewProjection should be able to obviate the need for NewProjectionIndex once you move over the index trie.


Maybe put this object as a const at the top of the file like DEFAULT_WEATHER_OBJECT so it's clear how to add and remove fields from the weather object.


Another typo fixed


You should probably still wrap the <h4> in a <Widget>


Tell mocha we are testing an asynchronous function by passing `it`'s function a callback, named done.


Okay, I've pushed a change through - are you okay with a pull now?


Invoke the callback, `done`, when you have finished making assertions.


Sorry for this, this commit carries the .orig file created by the patch command.


This is why my code stopped working! :P

Since `ReadIterator` implements both blocking and asynchronous operations, I don't see why it needs to have a different name.

Unless you want to make a clear distinction between blocking and async. If that's the case, should remove `__iter__`, `next` and `__next__`.

(I would also call it `async_read_loop` for consistency)

Anyway, just nit-picking -- I'm happy with it :)


@danielstuart14 won't this be the same if the cop dies? Since the body gets set null?  Gonna test it.. just wondering why it's different than !alive _cop I guess.


Sorry, I just took another look at how this works. Since you've added `nat` to `node["simple_iptables"]["ipv6"]["tables"]`, the guard at the beginning of this block is essentially a no-op, which means these rules will always be added, and it'll break on older kernels. Alternatively, if we change the guard above to include the nat table section only if there are actually rules or policy defined for the nat table, then if rules in that table are added and then removed, the nat table will not be cleared after the removal of the rules.

So, I think we need to:

1. Change the provider to add an explicit error if someone tries to use the `nat` table with IPv6 on older kernels.
2. Add a guard for this block to only generate it if running on kernel 3.7 and above, like you suggested initially.


When the callSingle thrown a exception in separate thread, The resultMap will be returned, and main thread not known the exception. Several methods changed to fork join a new thread recently(dbSequencedIdPrimary, runSqlUpdate). When use join, the following code mostly depend on the result of the separate thread, So we should check the result. I suggest to define a ThreadPoolExecutor in ecfi, submit the async tasks to executor and hold the Futures, use Future to get the result and process exception, Other multi thread part not use join can also executed use this ThreadPoolExecutor (e.g. runInThreadAndTx). Another benefit is can avoid some overhead of creating threads.


Wow, there are 76 tests for this assignment. They all fail right now. (Most of them time out.)

FAIL tests/filesys/base/syn-write
run: TIMEOUT after 61 seconds of wall-clock time - load average: 0.17, 0.21, 0.17
FAIL tests/userprog/args-none
FAIL tests/userprog/args-single
FAIL tests/userprog/args-multiple
FAIL tests/userprog/args-many
FAIL tests/userprog/args-dbl-space
FAIL tests/userprog/sc-bad-sp
FAIL tests/userprog/sc-bad-arg
FAIL tests/userprog/sc-boundary
FAIL tests/userprog/sc-boundary-2
FAIL tests/userprog/halt
FAIL tests/userprog/exit
FAIL tests/userprog/create-normal
FAIL tests/userprog/create-empty
FAIL tests/userprog/create-null
FAIL tests/userprog/create-bad-ptr
FAIL tests/userprog/create-long
FAIL tests/userprog/create-exists
FAIL tests/userprog/create-bound
FAIL tests/userprog/open-normal
FAIL tests/userprog/open-missing
FAIL tests/userprog/open-boundary
FAIL tests/userprog/open-empty
FAIL tests/userprog/open-null
FAIL tests/userprog/open-bad-ptr
FAIL tests/userprog/open-twice
FAIL tests/userprog/close-normal
FAIL tests/userprog/close-twice
FAIL tests/userprog/close-stdin
FAIL tests/userprog/close-stdout
FAIL tests/userprog/close-bad-fd
FAIL tests/userprog/read-normal
FAIL tests/userprog/read-bad-ptr
FAIL tests/userprog/read-boundary
FAIL tests/userprog/read-zero
FAIL tests/userprog/read-stdout
FAIL tests/userprog/read-bad-fd
FAIL tests/userprog/write-normal
FAIL tests/userprog/write-bad-ptr
FAIL tests/userprog/write-boundary
FAIL tests/userprog/write-zero
FAIL tests/userprog/write-stdin
FAIL tests/userprog/write-bad-fd
FAIL tests/userprog/exec-once
FAIL tests/userprog/exec-arg
FAIL tests/userprog/exec-multiple
FAIL tests/userprog/exec-missing
FAIL tests/userprog/exec-bad-ptr
FAIL tests/userprog/wait-simple
FAIL tests/userprog/wait-twice
FAIL tests/userprog/wait-killed
FAIL tests/userprog/wait-bad-pid
FAIL tests/userprog/multi-recurse
FAIL tests/userprog/multi-child-fd
FAIL tests/userprog/rox-simple
FAIL tests/userprog/rox-child
FAIL tests/userprog/rox-multichild
FAIL tests/userprog/bad-read
FAIL tests/userprog/bad-write
FAIL tests/userprog/bad-read2
FAIL tests/userprog/bad-write2
FAIL tests/userprog/bad-jump
FAIL tests/userprog/bad-jump2
FAIL tests/userprog/no-vm/multi-oom
FAIL tests/filesys/base/lg-create
FAIL tests/filesys/base/lg-full
FAIL tests/filesys/base/lg-random
FAIL tests/filesys/base/lg-seq-block
FAIL tests/filesys/base/lg-seq-random
FAIL tests/filesys/base/sm-create
FAIL tests/filesys/base/sm-full
FAIL tests/filesys/base/sm-random
FAIL tests/filesys/base/sm-seq-block
FAIL tests/filesys/base/sm-seq-random
FAIL tests/filesys/base/syn-read
FAIL tests/filesys/base/syn-remove
FAIL tests/filesys/base/syn-write
76 of 76 tests failed.


TeamCity Common Provider :: CommonProvider => CI [Build 2.0.51](http://localhost:9090/viewLog.html?buildId=524&buildTypeId=CommonProvider_CoreCiRelease&guest=1) is now running


下もそうだけど、問題において
@book
book
とインスタンス変数ではないようにされていた。
直後にviewからbookを閲覧しないupdateとdestroyについては、あえてインスタンス変数としていると思っていました。

インスタンス変数など有効範囲の広い変数に関して、どう考えますか？注意事項ありますか？


TeamCity Common Provider :: CommonProvider => CI [Build 2.0.51](http://localhost:9090/viewLog.html?buildId=524&buildTypeId=CommonProvider_CoreCiRelease&guest=1) outcome was **SUCCESS**
Summary: StyleCop violations: 229, Tests passed: 68 Build time: 00:00:55


Estan perfect estos cambios.


I think you should add newline at end of file.


La verdad no se que hace este User.delete_all que le agregaste....


TeamCity Common Provider :: CommonProvider => CI [Build 2.0.52](http://localhost:9090/viewLog.html?buildId=525&buildTypeId=CommonProvider_CoreCiRelease&guest=1) is now running


TeamCity Common Provider :: CommonProvider => CI [Build 2.0.52](http://localhost:9090/viewLog.html?buildId=525&buildTypeId=CommonProvider_CoreCiRelease&guest=1) outcome was **SUCCESS**
Summary: StyleCop violations: 229, Tests passed: 68 Build time: 00:00:33


TeamCity Common Provider :: CommonProvider => CI [Build 2.0.53](http://localhost:9090/viewLog.html?buildId=526&buildTypeId=CommonProvider_CoreCiRelease&guest=1) is now running


yeah, it makes sense...
Would need to do some arrayIntersect to check if player still on server...


TeamCity Common Provider :: CommonProvider => CI [Build 2.0.54](http://localhost:9090/viewLog.html?buildId=527&buildTypeId=CommonProvider_CoreCiRelease&guest=1) is now running


TeamCity Common Provider :: CommonProvider => CI [Build 2.0.53](http://localhost:9090/viewLog.html?buildId=526&buildTypeId=CommonProvider_CoreCiRelease&guest=1) outcome was **SUCCESS**
Summary: StyleCop violations: 229, Tests passed: 68 Build time: 00:00:34


going to revert


TeamCity Common Provider :: CommonProvider => CI [Build 2.0.54](http://localhost:9090/viewLog.html?buildId=527&buildTypeId=CommonProvider_CoreCiRelease&guest=1) outcome was **SUCCESS**
Summary: StyleCop violations: 229, Tests passed: 68 Build time: 00:00:34


have a wrapper

````
 if (function_exists('curl_version')) {
$fp = curl_init($this->field_value);
 +
 +    			curl_setopt($fp,CURLOPT_TIMEOUT,20);
 +
 +    			curl_setopt($fp,CURLOPT_FAILONERROR,1);
 +    			curl_setopt($fp,CURLOPT_REFERER,$this->field_value);
 +    			curl_setopt($fp,CURLOPT_RETURNTRANSFER,1);
 +				curl_setopt($fp,CURLOPT_USERAGENT, 'Googlebot/2.1 (+http://www.google.com/bot.html)');
 +
 +    			curl_exec($fp);
 +
 +    			if(curl_errno($fp) != 0) {
 +        			return FALSE;
 +    			} else {
 +        			return $this->field_value;
 +    			}
 +
 +    			curl_close($fp);
} else {
return $this->field_value;
}


And that, friends, is why commits use SHA-1. -1 point for not faking the commit IDs staying the same in the demo.


I think you should stick with [H] though since there's no text involved. If it works though we can leave as is ...


That doesn't work for me. I had to change `name="network"` back to `name="name"` to fix your fix.


保存できなかった場合の返り値が違います。
概ね例外を発生させるものに！がついています。

今回の場合は保存に失敗した場合、失敗した旨を通知しつつ、新規作成画面に戻すべきなので、
saveを利用して、返り値の真偽で分岐させたほうがいいと思います。


@iZezoh Please revert the changes to .classpath and .project before this gets merged into master.  There is no reason for the project to have the Eclipse Plugin Development nature enabled.


no ono to ve starém sixu bylo správně... s novým sixem to už dělá problémy


I mustuse what is standard for knj


I'd be inclined to agree with @WPFerg here. It's OK for now, but if we start getting more cases, it will need to be re-factored to something more maintainable.


Post here is redundant


all good apart from one comment above


@Ben-M we never decided against it, we just didn't find how to do it :)
who do you think put Adam to do it now?? :)


Most probably a personal preference: I would suggest removing this convenience method in the spirit of keeping this model class cleaner. Method doesn't do anything special anyway.

The caller can use `getDate()` and transform it if and when needed.


This fixes #16


> I am also trying to merge MergedGoConfig and CachedFileGoConfig as I don't think we need to main two of those caches, and that extra level of indirection.

That's probably true. As long as you can get it done. Although you'll be putting responsibilies of both these classes into single one, it might get harder to test them.

@jyotisingh I think you should work on top of changed in #1810 or better yet on top of this PR. There are a  few changes in what is returned to the higher services and how merges are handled when changes via UI are introduced. IIRC there is a lot of things that don't work as expected without #1810


А что вызывает, для чего? Закеширован-то именно m_lastTapEvent. Со стороны непонятно, зачем и зачем UI коллбек при восстановлении. Я об этом говорю.


@gaelicwinter
You are welcome.


reverted this change. see 28ed97a


Nope, this is only you standard :D


Looks like this version was never published? Mind publishing it again?


this does not qualify for sprt(0,4). code is more complex than master:
http://tests.stockfishchess.org/tests/view/56b866820ebc590247cdfc7c


IfNeeded, ага. На мой взгляд логично, что если NotNeeded - ничего вызвано не будет)


worst commits ever, were you in class when i was talking about github and how it works?


The branch needs a newer fc library: https://github.com/cryptonomex/fc/commit/d74eee811018f5f0b562b12af3a5afaa59cf60cb


library for connect to Database and create and read JSON content


awesome!


also the repo is empty i dont see any java practice going on here


Yeah and for the few that aren't he created a little patch, iirc that's the petsu window scaler and some setting to not scale if fullscreen is less than X% bigger.


Realised that the assertion is completely incorrect. Last() moves the cursor, it does not even verify that it is the last record and assertions should not have an effect! It should be changed to isLast() - fixed on my branch


Thanks man !


> For some reason I mis-understood that you wanted to allow saving of main xml even when the validation if known partials fails, I guess I was wrong.

I did not want to in the begining, but we have to allow it. The reason is this:
When user has few config repos and some of those are causing invalid merged config, then it must be still possible to edit main xml in order to e.g. remove some configuration repository that is causing trouble. Otherwise user would be 'locked out', unable to edit, which then means turning off server, editing xml and starting server back.


If it gets accepted you are missing register via checkout
catalog/view/theme/default/template/checkout/register.tpl


Fine for me


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14819](https://teamcity.mesosphere.io/viewLog.html?buildId=128137&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:10:23


Why is it called twice?


This should fail the test instead of printing the trace.


Borra todos los usuarios en la bd de test.
---
On Feb 7, 2016 22:52, "Juan Pablo Baeza" <notifications@github.com> wrote:

> La verdad no se que hace este User.delete_all que le agregaste....
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nkipreos/pushvendor/commit/60a222b163b2284f5be12203d8ae3e3af78ebf1d#commitcomment-15942085>
> .
>


@sils1297
1. thanks :) i kinda knew, but i don't know why i didn't use it, maybe with practice :D
2. we can't use make_temp since the contexmanager would try to delete the file afterwards and it would raise an error since the `coala-delete-orig` has already deleted it!
also we can't use mkstemp(), because mkstemp requires us to remove the file after it's been used which we do with our script, but if our test fails it means that the file couldn't be deleted, then mkstemp() would not delete it and TemporaryFile would hence i used it, so that there aren't any tempfiles lying around after the tests


are you sure it's not <= ? I have a doubt, if not sure check with marc


gir mening.


thank you!


packages/apps/Settings/res/xml/temasek_lockscreen.xml:75: error: Error parsing XML: mismatched tag


Usually even for default arguments you should put spaces around the `=` sign for better readability. Also I don't really know what's the agreed convention for the single/double quotes in your project, but usually it is single quotes for simple strings (or empty strings) and double quotes whenever there are any interpolations within the string.


Thanks. Fixed by 05f44e5


usually we use coding style with _width instead of width_ .
If the code comes from external sources it's ok but else it's better to use the previous notation like in Cubemap


Don't we need to unlock before returning here?


i guess i should have left a comment about that


@lakshay1994 Good work :smile:

How about `this.removeHeader ? this.dgrid.set('showHeader', false) : this.dgrid.set('showHeader', true);` ?


Is it ready?

If you don't mention anybody it did not exist :p

On Mon, Feb 8, 2016 at 10:38 AM, Mario de Frutos <notifications@github.com>
wrote:

> yes, I've opened another PR in rails with the changes:
> CartoDB/cartodb#6527 <https://github.com/CartoDB/cartodb/pull/6527>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CartoDB/geocoder-api/commit/4b31a150272b87717945bc9aa2ef88488234c3fe#commitcomment-15945905>
> .
>

--
*Rafa de la Torre*
DataServices Engineer www.cartodb.com


Why not `self.ClickInput`? This should crash all the tests. How did you check it? Please test locally at least before any (!) commit.


This landed in master. Is this intentional?


I don't get it where the quote has been removed?


Ok, I'll make the suggested changes. The move to the parent can be done in another JIRA (the one you have in your todo list?)


Thx for pointing this. Indeed something is not right here. How did you catch this ?


gerne @dergel  ;)


Im testing it before call for check out


I am pretty sure that Gez is right though. The switchable actor bites anyway with the check if an actor is in a specific radius, so removing the "switchability" and keeping it all in one actor state with a TNT1 sprite is a better way to go.


import java.io.*;

public class Caesar
{

  public static void main(String[] args) throws IOException
  {
    if (args.length != 3)
    {
        System.out.println("USAGE: java classLoader.Caesar in out key");
        return;
    }

    try(FileInputStream in = new FileInputStream(args[0]);
     FileOutputStream out = new FileOutputStream(args[1]))
     {
           int key = Integer.parseInt(args[2]);
           int ch;
           while ((ch = in.read()) != -1)
           {
              byte c = (byte) (ch + key);
              out.write(c);

           }
         }
       }
    }


forget it, it's fixed in nexts commits


delete test.php


Bad idea to store a private key in vagrant root.


What about source-type-[create|delete]? Can anyone (admin OR member) can create source_type?


Yes, that's a separate task assigned to me in which ever real or virtual tracker :)


Same as above...


is there anything that depends on this output? Couldn't we just drop the line?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14821](https://teamcity.mesosphere.io/viewLog.html?buildId=128157&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:48


Let's go ahead and revisit this once this is done if you don't mind :)

On Mon, Feb 8, 2016 at 10:46 AM, Mario de Frutos <notifications@github.com>
wrote:

> hahahaha again we face this discussion, I don't like to put database
> objects inside the python library, for my i s coupling two different parts.
> Also for me is not a problem to change the server extension, is very easy
> to deploy for the server part.
>
> This said, if you really want this I could do it without a problem
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CartoDB/geocoder-api/commit/2a9d6c14bd75ac76b4f57f82772baa46c4366102#commitcomment-15946068>
> .
>

--
*Rafa de la Torre*
DataServices Engineer www.cartodb.com


Тут можно писать всякую фигню


Сергей, обрати внимание на этот блок – не рекомендуется создавать функции внутри цикла. В данном случае все будет работать нормально, но если ты внутри создаваемой функции используешь итератор `i`, то это может привести к неожиданным результатам. Чтобы этого не случилось, лучше сразу взять за правило выносить создание функции за цикл.


It's funny - I actually picked this up via the _effective scala_ link you shared, which build on top of the scala style guide.  That guide say to [use this style](http://docs.scala-lang.org/style/control-structures.html) for simple if/else.


@p0psicles This should be "Base class for all AniDB Exceptions" or "An exception occurred with AniDBhttp"


"A Generic" adds no information to these errors.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14820](https://teamcity.mesosphere.io/viewLog.html?buildId=128156&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:07:39


comared => compareResult


looks good to go.


> The flow starts here, then goes to this, then this, then this. The config object here does not include any of the config-repo partials here. So, the validation would succeed, and the config would get saved & checked-in through this call.

This indeed looks like a key path, capable of breaking main xml, totally ignoring that there are configurations outside of main config. I did not know about it. Thank you for pointing it out.

So IMHO we should do a merged config validation somewhere near [here](https://github.com/gocd/gocd/blob/ab767d05fdec94fee7ef04875828da5dc2879841/server/src/com/thoughtworks/go/server/service/GoConfigService.java#L1138). Since the `xmlString` there contains only the main config. Would that be OK?


@lauravignoli please merge in the current master and fix the following tests
Tests in error:
  testSaveBloodTestingResults(service.BloodTestsServiceTest)
  testBloodTestingRuleEngineWithDonation1(repository.bloodtesting.BloodTestingRuleEngineTest)
  testBloodTestingRuleEngineWithDonation2(repository.bloodtesting.BloodTestingRuleEngineTest)
  testBloodTestingRuleEngineWithDonation4(repository.bloodtesting.BloodTestingRuleEngineTest)
  testBloodTestingRuleEngineWithDonation5(repository.bloodtesting.BloodTestingRuleEngineTest)
  testBloodTestingRuleEngineWithDonation6(repository.bloodtesting.BloodTestingRuleEngineTest)


実は、この状態でSubmitすると
Type　Error　MovieController#create
no implicit conversion of Symbol into Integer
というエラーが出てしまって、それが解決できないままPRを出しました。
色々とGoogleで調べたのですが、解決法が見つからず詰まっています。
お気づきの点あれば教えてください。


Instead of calling the keys method every time, you could just assign the result to an instance variable just once. eg
```ruby
  @person ||= Person.new
```


Sh ....


Thanks :)


Thanks for pointing that out! 0b146e32565178fa8879b0173d2edeb10f0190c0 should ensure backwards compatibility, right? I cannot test it right now, but should work now.


Стоит ли использовать `yield return`, или можно создать переменную типа `List`? Вопрос в контесте того, в что разворачивается `yield return`, и, кажется, это серьезный оверхед


Actually my editor was showing error with backslash on some places and while googling some answers was to add another backslash and error was gone I am not sure if I did it correct let me know your comments


Naming for the different configuration usecases would be appropriate for readability.


Does `addHooksToPrint` works only for GitHub?


should be camel case right ?


Why `.split(...)[0]`? One more `dirname` looks better because there are no magic numbers like `0`.


camel case ?


Method's name is too UI-ish to my eyes :)

May I suggest renaming it to something more revealing of its function? For example, it could be renamed to `isOld()` or `isPreCalypso()` or anything that will be more relevant to a date related functionality. Hope this makes sense!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14823](https://teamcity.mesosphere.io/viewLog.html?buildId=128162&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:03:28


Don't forget to enclose `$port=$this->hive['PORT']` in parentheses.


actually the header is by default visible always
so it might possible that the else would never be executed in case we never change the attribute dynamically.


By default, only admin can do create or delete. members can not perform any operations with create or delete.


Is this ready for a release to Hackage?


Thanks for continue working on yhis; I've been a bit lagging behind.

-----

stratagus is also now being packaged at PlayDeb; so you may want to have a look there for ideas too ;-)
(just what I did for Corsix-TH)
https://github.com/ckorn/PlayDeb/tree/trusty/stratagus

-----

Empty dirs Git: somme people just touch a zero byte file:
https://github.com/mvo5/unattended-upgrades/blob/debian/sid/test/root.unused-deps/var/run/.silly-git

You may also use `debian/dirs` if this is only needed for debian; or some `mkdir -p` in the makefile will make it work for all distros


no, it should work for github and local repo as well

2016-02-08 11:28 GMT+01:00 Marcin Kosiński <notifications@github.com>:

> Does addHooksToPrint works only for GitHub?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pbiecek/archivist/commit/4dff1443d3a6b97b5024645335ce33184f428a54#commitcomment-15946906>
> .
>

--
pozdrawiam serdecznie,
Przemysław Biecek


Are you sure the condition is `routingMechanism.getMaxDirectHits() >= directHits.size()` and not the opposite `directHits.size() >= routingMechanism.getMaxDirectHits()`?


what means I I1 I2 I3 I4 ?


I have a better solution: I have pulled this into a `opts_addOpts` function which does all this formatting business in a consistent way.


`Device` doesn't have `min_size`. (I already moved the luks min size related part from `PartitionDevice` to `StorageDevice`).


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27335/testReport/) for this commit**


Hi MIkko,

isn't IP_PKTINFO the general one, and IP_RECVDSTADDR the BSD-specific? i.e. more accurate:

#ifdef bsd
  cmsg->cmsg_type = IP_RECVDSTADDR;
...
#else
  cmsg->cmsg_type = IP_PKTINFO;
#endif


I think what you want is:

   if (! ($backend && $email == $row['email'])) {

(please also note the small format change, the whitespace between if and (, and ) and  {


If I understand this correctly - `data` object holds collection names. If this service receives a collection name - you fetch invalid files for given collection, if it doesn't receive a collection name, it gets invalid files from all of the collections. If this is the case then I think that you should move the part that fetches the invalid files directly to the `data` object. In the above solution you have to call `send` twice. This is not good because send breaks the established interface of the object and calls it's private methods. If you moved the invalid_files method straight to `data` object you wouldn't have this problem + you would give the responsibility of fetching invalid files to the object that holds the collections of files. This change would make your `#call` look something like this:
```
def call
  invalid_files = data.invalid_files(collection_name)
  invalid_files.each { |file| missing_values[file.id] = file.missing_attributes }
  missing_values
end
```
What do you think?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14822](https://teamcity.mesosphere.io/viewLog.html?buildId=128161&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:09:43


looks good to me.


Merging, thanks!


oh yes, you are right.


./guts/exception.py:139:80: E501 line too long (89 > 79 characters)


@stevemao as mentioned, i committed this somewhat accidentally? can you review? i can address comments with a followup PR


lgtm :+1:


LGTM.


That sounds great. Please make sure, that this is also working for multiple inputs aka drawOpts, tableOpts etc. Then we can cleanup all that mess in a separate PR


Comma (`,`) is obviously missed. It looks like the tests were not run. It crashes them all.


Also note, that here there is a special case, as the options are encased in curly braces, which for general *Opts is not true.


Impressed. Yeah - I've tried both. Tuples works, dict doesn't. Both are a bit more complex but I don't care implementing them as long as you are ok to review them.


You don't need to explain what they are inherited from.  If you want to do that do it in the module docs for exceptions.py  and do a heirarchy like that found on the standard library exceptions page.


Yes, it is. We are moving to a merge based workflow. But it should have been removed in the merge commit, I'll do it. Thank you @emodric :)


Great, I will add 2016 to copyright line and then merge it.


fixed in 6f2b6dc50f150461b7ce52bbb7f3dafd525dc829


ok but you can still simplify it like this


Why `wheel_dist*120` and then `wheel_dist/120`? It really confuses!


add here another command to run:

```
$ pip install -r requirements-dev.txt
```

:+1:


@GVRV this is GREAT man! Welldone :D Big spirits will be meet soon 👳


May I suggest `s/toggleAdminVisibility/setAdminVisibility`? Cheers!


This should be `git diff` vs `git diff | diff-highlight | diff-so-fancy`?


May I suggest s/toggleAdminVisibility/setAdminVisibility? Cheers!


Same situation as before - this class knows too much about the private methods of the `file` object. You should create a method calld ie. `invalid_values` in `file` object, that can be parametrized with the types.


getAllTableName ?


Way too wordy... These can be comments in the code.


c'est une autre approche. Tu preferes faire bosser le php et moi la bdd. Y'a pas de methode ideal. ton cade est sympa.


When committing a new version, make sure you tag the version with `git tag` (https://git-scm.com/book/en/v2/Git-Basics-Tagging) and include the tags when pushing `git push origin --tags`

This allows the showing of releases in GitHub, and also paths the way for CI. Thanks :)


getUniqueFieldValues ?


this is already removed in PR  #5773


You also need to state that when they are followed they solve a problem.


For your line 54, maybe use :
```Python
if game in ["list", "list_games", "list games"]
```
What do you think ?

or just
```Python
if game.startswith("list")
```

to support everything


yes, doing it! :D


will do


Removed Max Volume setting as it's no longer needed


Comment should be within the if branch


lol


You have two variables called `h` which are two different hashes. It is quite confusing to read for the first time. Also I don't think that you should pass the `h` to the method since it is not needed inside - it doesn't take part in any computations. instead you could just do:
```
def call
  # stuff
  invalid_files.each_with_object({}) { |file, hash| hash["#{file.id}.yml"] = get_invalid_values(file) }
end

def get_invalid_values(file)
  TYPES.each_with_object({}) do |type, hash|
    # stuff
  end
end
```


lgtm :+1:


debug statement left in


remove `console.log`


is this only needed inside the Twitter if?


Remove that line 75


import java.applet.*;
import  java.awt.*;

public class VerifierTest extends Applet {

   public static void main(String[] args){
   {
      System.out.println("1 + 2  == " + fun());
   }

   public static int fun()
   {
     int m;
     int n;
     m = 1;
     n = 2;
     // use hex editor to Change to " m = 2 " in class file
     int r = m + n;
     return r;
  }

  public void paint(Graphics g)
  {
     g.drawString(" 1 + 2 == " + fun(), 20, 20);
  }
}


Ok, thanks, i thought it let you boot little longer :)


I for "Integrate" (Integral Images is generalisation of Summed Area Table, when order > 1 so I2 is order 2 integral of summed area table algo )
I can rename them but it will make for long lines of code
( They're always used 4 times in a code line as we compute over the four corner of the area for the sum )


From a user perspective, the messaging should be generic, since they don't really care whether it's googlemap or cartodb that is loading.


User nsOID


what about msecs instead? :)


got added by mistake , will remove this


Only used once in each branch of if? => No need for interim variable


Instead of rejecting nils you should just use compact:
```
some_array.map do |k,v|
  #stuff
end.compact
```
It auto removes all nil values.


extra `"` here


Use `keyword=value` syntax. It's not clear what is `True,True`.


what about msecs instead?


The is no tag on the commit; you can't reference the version easily with bower.


Why did you use codeception @andela-cvundi ?


`&` is bit operation in Python. Use `and` keyword.


awesome!


These 2 only seem to be needed inside the if branch?


fix the title


Basically you are triggering `next` if the attributes are nil or if the attributes class is equal to the value's class. You can rewrite this in one conditional for clarity:
```
next if attributes[k.to_sym].nil? || attributes[k.to_sym].class.to_s == v.classify
k.to_sym
```


lgtm :+1:


Alright then, I guess we can leave it as is for now in that case


Please rewrite this commit to remove the grammatical blunder `serach` and `seaech`. It's `search`.


I assume this was a deliberate UX request  to have this in the rheader instead of the Action Buttons? Fine.


I was really asking about bitbucket support?


Hooks only depend on an interface, not an implementation. So I'm thinking that addition may not be correct here. You would just hook to `RemindableInterface` rather than `Event` or `Page`. You see this in the core in a few places too, for example, hooks to WirePageEditor, which is only an interface (used by ProcessPageEdit, ProcessPageAdd, ListerPro, and others).

There are plenty of good reasons to define a custom type of Page, like we do for User, Permission, Role, Language, etc. But it's often a completely different conversation from hooks.

Even if hooks didn't support interfaces, it's not necessarily a reason to avoid them, but rather one would just validate that they have what they want before letting their hook proceed. For a really simple example, in FormBuilder we often validate that it's the form we want before proceeding. If we hook to FormBuilderProcessor::saveForm, and only want to operate on the "contact" form, then we check that `$event->object->formName == 'contact';` before allowing the hook to proceed.

Then in PW 2.7+ there's conditional hooks, which goes even further than what you can do with type hinting (at least in PW context). A good example is that most Page types are defined by their template more than anything else, and you can hook only to pages of a certain type (but that's just the beginning). https://processwire.com/blog/posts/new-ajax-driven-inputs-conditional-hooks-template-family-settings-and-more/#new-conditional-hooks

In the end, it's a question of what's going to be more code to maintain. In PW1, I always had to create various new Page classes for different things. But PW1 didn't have a hook system anything like PW2. If I can accomplish something with hooks, I often consider it preferable to creating new types because it's less code for me to maintain and less fuss to setup. Though if I need to add or modify more than a couple aspects, or need to type hint the new type in several places, then I'll create a new type (like a User class extending Page for example).


This change addresses two of the three macros requested in issue #24.


Please explain what's going on here @andela-cvundi


If you have more than one user account, other users can read all messages (incoming/sent/failed) using returned message_id(s). You can add conditional into get_some_sms(kind, message_id) like this:
`
if m.get('From') == get(auth.username()):
    return jsonify(dict(m))
else:
    return make_response(jsonify({'error': 'Forbidden'}), 403)
`


ya pretty much.
that gives me an idea though… https://github.com/stevemao/diff-so-fancy/issues/6


Looks okay. Is there any scenario that you have tested  this feature against?


this needs to be removed


@limzykenneth video_tag looks in public/videos by default, moved the video and works now, not sure if this was what you were trying to do though.


I think I already changed this one (possibly around the same time you did). Anyway, I also updated the Imports in the DESCRIPTION file. Thanks.


yes, I'm using for basic rate limiting


This name is a bit ambigious. You can use Tor to connect to a clearnet address too.


Yes - that is what the docs says and `MustBool` will return the default value if entry is missing.


select right


Этот вызов было бы лучше перенести в init/1. Что бы загрузкой кода занимался не вызывающий процесс, а вызываемый.

А к кому линкуется запускаемый процесс?


Good Luck for LTC :)


FYI. I added your GitHub handle to the list of translators in [AUTHORS.md](https://github.com/y20k/transistor/blob/master/AUTHORS.md)


this indentation is weird, can you please put all of that in one line or so?


**Code Quality - Critical**

```php
The code here is repeated. A better way of doing this is doing something like:

$condition = return env('APP_ENV') == 'testing') ? 'LIKE' : 'ILIKE';

$results = Episode::where('episode_name', $condition, "%{$query}%")->orWhere('episode_description', $condition, "%{$query}%")->get();
```


LGTM, but perhaps this commit can be squashed into the previous one? It seems like it is just a correction of that.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27339/testReport/) for this commit**


unfinished task
==========
1. integrated new css with news.css
2. deploy to rails


hey, your test doesn't make any sense! you have three times "make sure the bear yields no results" in here - does it yield any results ever?


I guess we don't particular want to optimize the failure path. As you say the exception path is hopefully very rare.


Is it a question for me?
;-)

Dnia 08.02.2016 o godz. 11:49 Marcin Kosiński <notifications@github.com> napisał(a):

> I was really asking about bitbucket support?
>
> —
> Reply to this email directly or view it on GitHub.
>


missing newline before EOF


Why? It don't see why this would be better than using the other setting.


You are right. I have commtitted the changes.


at least your tests don't even cover the case wher eyour bear yields any results which is sad because that's what a bear should do


Just curious: where is this testcase taken from?


Looks good.


**Code Quality - Nitpick**

You don't need to assign `Channel::all()` to a variable `$channels` in line 35 since you are going to need it just once.

You can just call it directly on line 39 like so:

```php
...
'channels' => Channel::all();
```


`wheel_dist` param should be specified after `coords` one as it's done in `_perform_click_input`.


GACL smarty reverted commit https://github.com/practiceprovider/openemr/commit/174ca86ed9e40131f8fe19cce501f7e03b68f5f0


is there any specific reason why mustache depends on ruby ~> 2.0?


I am trying to figure out which functions have which support. Maybe we
could provide a table in an article specifing which funcitonality/function
is support in which situations/mode?

2016-02-08 11:56 GMT+01:00 Przemysław Biecek <notifications@github.com>:

> Is it a question for me?
> ;-)
>
> Dnia 08.02.2016 o godz. 11:49 Marcin Kosiński <notifications@github.com>
> napisał(a):
>
> > I was really asking about bitbucket support?
>
> >
> > —
> > Reply to this email directly or view it on GitHub.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pbiecek/archivist/commit/4dff1443d3a6b97b5024645335ce33184f428a54#commitcomment-15947542>
> .
>


@felipesere I tried to make the test setup a bit easier to read. Do you think this is clearer?


`if wheel_dist:` is enough to avoid empty `return` statement. The code will be shorter in 2 lines.


na co tady vůbec odpovídáš. Zkusím to česky

accent = diacritics

pro v0.0 které používalo knj byl použit accent pro 0.1 diacritics já nechci měnit kód knj takže jsem to pro 0.1 změnil na diacritics


Please add month and quarter


Why are you creating a $user here? I don't see it been used anywhere in this test method @andela-jkariuki


What do you think of moving this code to your model?
They are business logic that should exist either in your model or in poro classes.


Those are live transaction on segnet:

https://blockchainprogramming.azurewebsites.net/checktx?txid=99e7484eafb6e01622c395c8cae7cb9f8822aab6ba993696b39df8b60b0f4b11

and

https://blockchainprogramming.azurewebsites.net/checktx?txid=36c6483c901d82f55a6557b5060653036f3ba96cd8c55ddb0f204c9e1fbd5b15

You can cross check on https://segnet.smartbit.com.au/


TeamCity Civic Assembly :: Build backend + frontend [Build 78](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=844&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


Will remove when migration to redux will be finished


My current implementation is just a wrapper that does:
```matlab
function opts = opts_addOpts(m2t, opts, key, subOpts, sep)
    % add a key={Opts} pair to an options array
    if ~exist('sep','var') || ~ischar(sep)
        sep = ',';
    end
    formatted = ['{' opts_print(m2t, subOpts, sep) '}'];
    opts = opts_add(opts, key, formatted);
end
```

The idea is that, eventually, we should make the data structure for Option Arrays more flexible such that we can put Option Arrays inside Option Arrays for those cases (see #588). So this is just an intermediate step in that process.

This change is not to handle `drawOpts`, `tableOpts` and so on (where the formatting is similar, but it is not really related). For `tableOpts` and so on, we actually generate final TikZ code (`\addplot` stuff and so on). In the case for `opts_addOpts`, we are still building the Option Array (in a somewhat clumsy way, but that should improve with #588).


This problem "bug" likely only affects the AlienFlight targets at the moment.

BTW: There is an pending PR for CF with the same changes for the AlienFlight V2 support.


Везде дублируется это if-else. Это лучше вынести в extension метод вроде GetWrongCaptchaMessage, который будт принимать captchaSettings и выводить ошибку взависмости от 1 или 2


I will try it this week, I'm a bit bussy, sorry for the delay.


npm install


You don't need to grab a bucketlist from db before creating an item for that bucketlist. Remember that item table has a bucketlist_id field which can be populated when creating an item. Always endeavour to avoid unnecessary calls to the db. In the above code, you can replace it with `@item = Item.new(item_params)` and remove the before action for the create method.


We have table like that (table 1).
For remote repos we should support github + bitbucket
for local repo we should support local dirs

2016-02-08 11:58 GMT+01:00 Marcin Kosiński <notifications@github.com>:

> I am trying to figure out which functions have which support. Maybe we
> could provide a table in an article specifing which funcitonality/function
> is support in which situations/mode?
>
> 2016-02-08 11:56 GMT+01:00 Przemysław Biecek <notifications@github.com>:
>
> > Is it a question for me?
> > ;-)
> >
> > Dnia 08.02.2016 o godz. 11:49 Marcin Kosiński <notifications@github.com>
> > napisał(a):
> >
> > > I was really asking about bitbucket support?
> >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub.
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/pbiecek/archivist/commit/4dff1443d3a6b97b5024645335ce33184f428a54#commitcomment-15947542
> >
> > .
>
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pbiecek/archivist/commit/4dff1443d3a6b97b5024645335ce33184f428a54#commitcomment-15947585>
> .
>

--
pozdrawiam serdecznie,
Przemysław Biecek


Tohle nemá cenu řešit, obojí je srozumitelné a myslím, že obojí je i správně. Je to poslední věc, co by nás měla trápit.


Looks good; might be worth experimenting with Scanf to see if the parsing in `get_bond_link_status` could be made clearer.


Hmmm, this line probably won't work consistently after we merge in #171. Is there any way we can determine what month they're viewing that references the data directly instead of the displayed value?


Что будет, если rpc:call вернет {badarg, Reason}?


any reason for removing this? :-) I'm looking for a javascript implementation that does a topological sort with cycles.


please add frac_seconds


I felt it was appropriate to have PlayAppSupport extend RequiresDB because our app ... requires a DB to run..


A minor thing: we can just get rid of `ARCH_HAS_SEND_PULL_TIMERS`; it doesn't serve any purpose anymore. With the move to `smp_call_function_single_async()`, the feature is now portable as we don't have to mess with native IPIs anymore.


We could link to the spec here.


You are pulling the maximum group order from ALL groups in the whole system - shouldn't this limited to the current survey?


I'll come with something then.


adding an additional validation for merged-config there works, but I am trying to avoid adding one-more validation in that flow. For config saves - serialization/deserialization, preprocessing and validations already happens a few times, addition more would kill servers with larger configs.
BTW, similar thing happens when someone edits the config file directly from file-system, so we need to take care of that flow too, it starts [here](https://github.com/gocd/gocd/blob/ab767d05fdec94fee7ef04875828da5dc2879841/server/src/com/thoughtworks/go/config/GoFileConfigDataSource.java#L127), this again does not handle validating with the merged partials.


Looks good.


TeamCity Civic Assembly :: Build backend + frontend [Build 78](http://build.civicconnecttlabs.com/tc/viewLog.html?buildId=844&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests failed: 141 (1 new), passed: 31, ignored: 4 Build time: 00:07:04
### Failed tests
```
Blog categories tests: Should delete blog category new blog category 1454929559427: <no details avaliable>

Blog categories tests: Should not create new blog category if cancelled: <no details avaliable>

Blog categories tests: Should add new blog category: <no details avaliable>

Blog categories tests: Should not change blog category: <no details avaliable>

Blog categories tests: Should change blog category: <no details avaliable>

Blog categories tests: Should not delete blog category if cancel pressed: <no details avaliable>

Blogs tests: Should not create new blog if Cancel button pressed: <no details avaliable>

Blogs tests: Should add new blog: <no details avaliable>

Blogs tests: Should not change blog if Cancel button clicked: <no details avaliable>

Blogs tests: Should change blog: <no details avaliable>

Blogs tests: Should not delete blog if Cancel button was pressed: <no details avaliable>

##### there are 131 more failed tests, see build details
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14824](https://teamcity.mesosphere.io/viewLog.html?buildId=128164&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 225 Build time: 00:04:18


Alright, there we go: https://github.com/symfony-cmf/SimpleCmsBundle/releases/tag/1.3.0-RC1


Done in update PR.


Perhaps also add the example from the spec as a testcase?