[inst/benchmarks/profviz-wtc_sig.R:16:21:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L16) *style:* **Commas should always have a space after.**
```r
d1.ar1 <- arima(d1[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[inst/benchmarks/profviz-wtc_sig.R:17:21:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L17) *style:* **Commas should always have a space after.**
```r
d2.ar1 <- arima(d2[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[inst/benchmarks/profviz-wtc_sig.R:34:1:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L34) *style:* **Variable and function names should be all lowercase.**
```r
registerDoParallel(cl)
^~~~~~~~~~~~~~~~~~
```
[inst/benchmarks/profviz-wtc_sig.R:48:33:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L48) *style:* **Commas should always have a space after.**
```r
        .init = array(dim = c(3,3,nrands)),
                                ^
```
[inst/benchmarks/profviz-wtc_sig.R:48:35:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L48) *style:* **Commas should always have a space after.**
```r
        .init = array(dim = c(3,3,nrands)),
                                  ^
```
[inst/benchmarks/profviz-wtc_sig.R:50:14:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L50) *style:* **Commas should always have a space after.**
```r
          y[,,x$r] <- x$a
             ^
```
[inst/benchmarks/profviz-wtc_sig.R:52:9:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L52) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
        }) %dopar% {
        ^
```
[inst/benchmarks/profviz-wtc_sig.R:53:43:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L53) *style:* **Commas should always have a space after.**
```r
          list(r = r, a = array(dim = c(3,3), (1:9) * r))
                                          ^
```
[inst/benchmarks/profviz-wtc_sig.R:70:3:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L70) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  {seq_len(1000000)},
  ^
```
[inst/benchmarks/profviz-wtc_sig.R:70:20:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L70) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  {seq_len(1000000)},
                   ^
```
[inst/benchmarks/profviz-wtc_sig.R:71:3:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L71) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  {1:1000000},
  ^
```
[inst/benchmarks/profviz-wtc_sig.R:71:13:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L71) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  {1:1000000},
            ^
```
[inst/benchmarks/profviz-wtc_sig.R:82:36:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L82) *style:* **Commas should always have a space after.**
```r
    out1 <- apply(ts, MARGIN = c(1,2), quantile, 0.95, na.rm = TRUE)
                                   ^
```
[inst/benchmarks/profviz-wtc_sig.R:86:14:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L86) *style:* **Commas should always have a space after.**
```r
      out2[i,] <- row_quantile(ts[i,,], 0.95)
             ^
```
[inst/benchmarks/profviz-wtc_sig.R:86:37:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L86) *style:* **Commas should always have a space after.**
```r
      out2[i,] <- row_quantile(ts[i,,], 0.95)
                                    ^
```
[inst/benchmarks/profviz-wtc_sig.R:92:13:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L92) *style:* **Commas should always have a space after.**
```r
      out3[,i] <- row_quantile(ts[,i,], 0.95)
            ^
```
[inst/benchmarks/profviz-wtc_sig.R:92:36:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L92) *style:* **Commas should always have a space after.**
```r
      out3[,i] <- row_quantile(ts[,i,], 0.95)
                                   ^
```
[inst/benchmarks/profviz-wtc_sig.R:92:38:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/benchmarks/profviz-wtc_sig.R#L92) *style:* **Commas should always have a space after.**
```r
      out3[,i] <- row_quantile(ts[,i,], 0.95)
                                     ^
```
[inst/examples/example-plot.biwavelet.R:34:17:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/examples/example-plot.biwavelet.R#L34) *style:* **Commas should always have a space after.**
```r
par(mfrow = c(1,2))
                ^
```
[inst/examples/example-plot.biwavelet.R:42:17:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/examples/example-plot.biwavelet.R#L42) *style:* **Commas should always have a space after.**
```r
par(mfrow = c(1,2))
                ^
```
[inst/examples/example-pwtc.R:15:17:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/examples/example-pwtc.R#L15) *style:* **Commas should always have a space after.**
```r
par(mfrow = c(2,1), oma = c(4, 0, 0, 1),
                ^
```
[inst/examples/example-wclust.R:14:10:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/examples/example-wclust.R#L14) *style:* **Commas should never have a space before.**
```r
w.arr[1, , ] <- wt.t1$wave
        ~^
```
[inst/examples/example-wclust.R:15:10:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/examples/example-wclust.R#L15) *style:* **Commas should never have a space before.**
```r
w.arr[2, , ] <- wt.t2$wave
        ~^
```
[inst/examples/example-wclust.R:16:10:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/inst/examples/example-wclust.R#L16) *style:* **Commas should never have a space before.**
```r
w.arr[3, , ] <- wt.t3$wave
        ~^
```
[R/check.data.R:31:8:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/check.data.R#L31) *warning:* **no visible global function definition for ‘check.datum’**
```r
  y <- check.datum(y)
       ^~~~~~~~~~~
```
[R/check.data.R:34:11:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/check.data.R#L34) *warning:* **no visible global function definition for ‘check.datum’**
```r
    x1 <- check.datum(x1)
          ^~~~~~~~~~~
```
[R/check.data.R:44:11:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/check.data.R#L44) *warning:* **no visible global function definition for ‘check.datum’**
```r
    x2 <- check.datum(x2)
          ^~~~~~~~~~~
```
[R/check.data.R:61:47:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/check.data.R#L61) *style:* **Commas should always have a space after.**
```r
    if (class(x[, 1])[1] == "Date" | class(x[,1])[1] == "POSIXct") {
                                              ^
```
[R/phase.plot.R:38:17:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L38) *style:* **Commas should always have a space after.**
```r
  phases[-a.row,] <- NA
                ^
```
[R/phase.plot.R:39:11:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L39) *style:* **Commas should always have a space after.**
```r
  phases[,-a.col] <- NA
          ^
```
[R/phase.plot.R:43:27:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L43) *style:* **Commas should always have a space after.**
```r
      if (!is.na(phases[i,j])) {
                          ^
```
[R/phase.plot.R:45:32:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L45) *style:* **Commas should always have a space after.**
```r
              alpha = phases[i,j], col = arrow.col)
                               ^
```
[R/phase.plot.R:76:60:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                           ^
```
[R/phase.plot.R:76:63:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                              ^
```
[R/phase.plot.R:76:66:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                                 ^
```
[R/phase.plot.R:76:69:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                                    ^
```
[R/phase.plot.R:76:72:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                                       ^
```
[R/phase.plot.R:76:75:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L76) *style:* **Commas should always have a space after.**
```r
  X <- (par()$usr[2] - par()$usr[1]) / par()$pin[1] * c(x1,x2,x3,x4,x5,x6,x7)
                                                                          ^
```
[R/phase.plot.R:77:60:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                           ^
```
[R/phase.plot.R:77:63:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                              ^
```
[R/phase.plot.R:77:66:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                                 ^
```
[R/phase.plot.R:77:69:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                                    ^
```
[R/phase.plot.R:77:72:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                                       ^
```
[R/phase.plot.R:77:75:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/phase.plot.R#L77) *style:* **Commas should always have a space after.**
```r
  Y <- (par()$usr[4] - par()$usr[3]) / par()$pin[2] * c(y1,y2,y3,y4,y5,y6,y7)
                                                                          ^
```
[R/plot.biwavelet.R:114:29:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/plot.biwavelet.R#L114) *style:* **Commas should always have a space after.**
```r
                     "cyan","#7FFF7F", "yellow",
                            ^
```
[R/pwtc.R:89:40:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/pwtc.R#L89) *warning:* **no visible binding for global variable ‘MOTHERS’**
```r
  mother <- match.arg(tolower(mother), MOTHERS)
                                       ^~~~~~~
```
[R/pwtc.R:91:14:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/pwtc.R#L91) *warning:* **no visible global function definition for ‘check.data’**
```r
  checked <- check.data(y = y, x1 = x1, x2 = x2)
             ^~~~~~~~~~
```
[R/pwtc.R:105:21:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/pwtc.R#L105) *style:* **Commas should always have a space after.**
```r
  y.ar1 <- arima(y[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[R/pwtc.R:106:23:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/pwtc.R#L106) *style:* **Commas should always have a space after.**
```r
  x1.ar1 <- arima(x1[,2], order = c(1, 0, 0))$coef[1]
                      ^
```
[R/pwtc.R:122:20:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/pwtc.R#L122) *style:* **Commas should always have a space after.**
```r
  y.sigma <- sd(y[,2], na.rm = TRUE)
                   ^
```
[R/pwtc.R:123:22:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/pwtc.R#L123) *style:* **Commas should always have a space after.**
```r
  x1.sigma <- sd(x1[,2], na.rm = TRUE)
                     ^
```
[R/pwtc.R:145:20:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/pwtc.R#L145) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.cw_yx1 <- smooth.wavelet(s.inv * (cw.yx1), dt, dj, wt.y$scale)
                   ^~~~~~~~~~~~~~
```
[R/pwtc.R:146:20:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/pwtc.R#L146) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.cw_yx2 <- smooth.wavelet(s.inv * (cw.yx2), dt, dj, wt.y$scale)
                   ^~~~~~~~~~~~~~
```
[R/pwtc.R:147:21:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/pwtc.R#L147) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.cw_x1x2 <- smooth.wavelet(s.inv * (cw.x1x2), dt, dj, wt.y$scale)
                    ^~~~~~~~~~~~~~
```
[R/smooth.wavelet.R:51:37:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/smooth.wavelet.R#L51) *style:* **Commas should always have a space after.**
```r
    wave.pad[seq_len(m)] <- wave[ii,]
                                    ^
```
[R/smooth.wavelet.R:68:12:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/smooth.wavelet.R#L68) *warning:* **no visible global function definition for ‘convolve2D_typeopen’**
```r
  swave <- convolve2D_typeopen(twave, rev(ker))
           ^~~~~~~~~~~~~~~~~~~
```
[R/smooth.wavelet.R:71:41:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/smooth.wavelet.R#L71) *style:* **Commas should always have a space after.**
```r
  swave[keep.start:(keep.start + n - 1),]
                                        ^
```
[R/wclust.R:40:21:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wclust.R#L40) *style:* **Commas should always have a space after.**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                    ^
```
[R/wclust.R:40:27:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wclust.R#L40) *warning:* **no visible global function definition for ‘wdist’, Did you mean 'dist'?**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                          ^~~~~
```
[R/wclust.R:40:42:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wclust.R#L40) *style:* **Commas should never have a space before.**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                                        ~^
```
[R/wclust.R:40:43:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wclust.R#L40) *style:* **Commas should always have a space after.**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                                          ^
```
[R/wclust.R:40:55:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wclust.R#L40) *style:* **Commas should never have a space before.**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                                                     ~^
```
[R/wclust.R:40:56:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wclust.R#L40) *style:* **Commas should always have a space after.**
```r
      dist.matrix[n,j] <- wdist(w.arr[n, ,], w.arr[j, ,])
                                                       ^
```
[R/wdist.R:35:31:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wdist.R#L35) *style:* **Commas should always have a space after.**
```r
  u <- wsvd$u[seq_len(nfreqs),]
                              ^
```
[R/wdist.R:36:31:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wdist.R#L36) *style:* **Commas should always have a space after.**
```r
  v <- wsvd$v[seq_len(nfreqs),]
                              ^
```
[R/wdist.R:38:61:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wdist.R#L38) *style:* **Commas should always have a space after.**
```r
  Lnk <- t(u[, seq_len(nfreqs)]) %*% Re(wt1[seq_len(nfreqs),])
                                                            ^
```
[R/wdist.R:39:61:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wdist.R#L39) *style:* **Commas should always have a space after.**
```r
  Ljk <- t(v[, seq_len(nfreqs)]) %*% Re(wt2[seq_len(nfreqs),])
                                                            ^
```
[R/wdist.R:49:11:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wdist.R#L49) *style:* **Commas should always have a space after.**
```r
      (u[,2:NROW(u)] - v[,2:NROW(v)]))))
          ^
```
[R/wdist.R:49:27:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wdist.R#L49) *style:* **Commas should always have a space after.**
```r
      (u[,2:NROW(u)] - v[,2:NROW(v)]))))
                          ^
```
[R/wt.bases.R:32:12:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wt.bases.R#L32) *style:* **Put spaces around all infix operators.**
```r
    morlet =rcpp_wt_bases_morlet(...), # original wt.bases.morlet(...),
           ^~
```
[R/wtc.R:97:40:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.R#L97) *warning:* **no visible binding for global variable ‘MOTHERS’**
```r
  mother <- match.arg(tolower(mother), MOTHERS)
                                       ^~~~~~~
```
[R/wtc.R:100:14:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.R#L100) *warning:* **no visible global function definition for ‘check.data’**
```r
  checked <- check.data(y = d1, x1 = d2)
             ^~~~~~~~~~
```
[R/wtc.R:115:23:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.R#L115) *style:* **Commas should always have a space after.**
```r
  d1.ar1 <- arima(d1[,2], order = c(1, 0, 0))$coef[1]
                      ^
```
[R/wtc.R:116:23:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.R#L116) *style:* **Commas should always have a space after.**
```r
  d2.ar1 <- arima(d2[,2], order = c(1, 0, 0))$coef[1]
                      ^
```
[R/wtc.R:128:22:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.R#L128) *style:* **Commas should always have a space after.**
```r
  d1.sigma <- sd(d1[,2], na.rm = T)
                     ^
```
[R/wtc.R:129:22:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.R#L129) *style:* **Commas should always have a space after.**
```r
  d2.sigma <- sd(d2[,2], na.rm = T)
                     ^
```
[R/wtc.R:134:17:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.R#L134) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.wt1 <- smooth.wavelet(s.inv * (abs(wt1$wave) ^ 2), dt, dj, wt1$scale)
                ^~~~~~~~~~~~~~
```
[R/wtc.R:135:17:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.R#L135) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.wt2 <- smooth.wavelet(s.inv * (abs(wt2$wave) ^ 2), dt, dj, wt2$scale)
                ^~~~~~~~~~~~~~
```
[R/wtc.R:153:16:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.R#L153) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
  smooth.CW <- smooth.wavelet(s.inv * (CW), dt, dj, wt1$scale)
               ^~~~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:24:10:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc_sig_parallel.R#L24) *warning:* **no visible global function definition for ‘get_minroots’**
```r
  mr1 <- get_minroots(lag1[1])
         ^~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:25:10:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc_sig_parallel.R#L25) *warning:* **no visible global function definition for ‘get_minroots’**
```r
  mr2 <- get_minroots(lag1[2])
         ^~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:28:22:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc_sig_parallel.R#L28) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
  d1 <- cbind(ntseq, ar1_ma0_sim(mr1, lag1[1], ntimesteps))
                     ^~~~~~~~~~~
```
[R/wtc_sig_parallel.R:36:11:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc_sig_parallel.R#L36) *style:* **Variable and function names should be all lowercase.**
```r
  NUMC <- getDoParWorkers()
          ^~~~~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:36:11:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc_sig_parallel.R#L36) *warning:* **no visible global function definition for ‘getDoParWorkers’**
```r
  NUMC <- getDoParWorkers()
          ^~~~~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:48:23:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc_sig_parallel.R#L48) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
                      }) %dopar% {
                      ^
```
[R/wtc_sig_parallel.R:58:26:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc_sig_parallel.R#L58) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
      d1 <- cbind(ntseq, ar1_ma0_sim(mr1, lag1[1], ntimesteps))
                         ^~~~~~~~~~~
```
[R/wtc_sig_parallel.R:59:26:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc_sig_parallel.R#L59) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
      d2 <- cbind(ntseq, ar1_ma0_sim(mr2, lag1[2], ntimesteps))
                         ^~~~~~~~~~~
```
[R/wtc_sig_parallel.R:71:14:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc_sig_parallel.R#L71) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
      sw1 <- smooth.wavelet(s.inv * (abs(wt1$wave) ^ 2), dt, dj, wt1$scale)
             ^~~~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:72:14:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc_sig_parallel.R#L72) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
      sw2 <- smooth.wavelet(s.inv * (abs(wt2$wave) ^ 2), dt, dj, wt2$scale)
             ^~~~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:96:5:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc_sig_parallel.R#L96) *warning:* **no visible global function definition for ‘row_quantile’**
```r
    row_quantile(rand.rsq[,j,], sig.level)
    ^~~~~~~~~~~~
```
[R/wtc_sig_parallel.R:96:28:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc_sig_parallel.R#L96) *style:* **Commas should always have a space after.**
```r
    row_quantile(rand.rsq[,j,], sig.level)
                           ^
```
[R/wtc_sig_parallel.R:96:30:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc_sig_parallel.R#L96) *style:* **Commas should always have a space after.**
```r
    row_quantile(rand.rsq[,j,], sig.level)
                             ^
```
[R/wtc.sig.R:59:10:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.sig.R#L59) *warning:* **no visible global function definition for ‘get_minroots’**
```r
  mr1 <- get_minroots(lag1[1])
         ^~~~~~~~~~~~
```
[R/wtc.sig.R:60:10:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.sig.R#L60) *warning:* **no visible global function definition for ‘get_minroots’**
```r
  mr2 <- get_minroots(lag1[2])
         ^~~~~~~~~~~~
```
[R/wtc.sig.R:63:22:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.sig.R#L63) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
  d1 <- cbind(ntseq, ar1_ma0_sim(mr1, lag1[1], ntimesteps))
                     ^~~~~~~~~~~
```
[R/wtc.sig.R:79:24:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.sig.R#L79) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
    d1 <- cbind(ntseq, ar1_ma0_sim(mr1, lag1[1], ntimesteps))
                       ^~~~~~~~~~~
```
[R/wtc.sig.R:80:24:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.sig.R#L80) *warning:* **no visible global function definition for ‘ar1_ma0_sim’**
```r
    d2 <- cbind(ntseq, ar1_ma0_sim(mr2, lag1[2], ntimesteps))
                       ^~~~~~~~~~~
```
[R/wtc.sig.R:92:12:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.sig.R#L92) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
    sw1 <- smooth.wavelet(s.inv * (abs(wt1$wave) ^ 2), dt, dj, wt1$scale)
           ^~~~~~~~~~~~~~
```
[R/wtc.sig.R:93:12:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.sig.R#L93) *warning:* **no visible global function definition for ‘smooth.wavelet’**
```r
    sw2 <- smooth.wavelet(s.inv * (abs(wt2$wave) ^ 2), dt, dj, wt2$scale)
           ^~~~~~~~~~~~~~
```
[R/wtc.sig.R:95:16:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.sig.R#L95) *style:* **Commas should never have a space before.**
```r
    rand.rsq[, , r] <- abs(smooth.CW) ^ 2 / (sw1 * sw2)
              ~^
```
[R/wtc.sig.R:111:13:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.sig.R#L111) *style:* **Commas should always have a space after.**
```r
    result[,i] <- row_quantile(rand.rsq[,i,], sig.level)
            ^
```
[R/wtc.sig.R:111:19:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.sig.R#L111) *warning:* **no visible global function definition for ‘row_quantile’**
```r
    result[,i] <- row_quantile(rand.rsq[,i,], sig.level)
                  ^~~~~~~~~~~~
```
[R/wtc.sig.R:111:42:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.sig.R#L111) *style:* **Commas should always have a space after.**
```r
    result[,i] <- row_quantile(rand.rsq[,i,], sig.level)
                                         ^
```
[R/wtc.sig.R:111:44:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wtc.sig.R#L111) *style:* **Commas should always have a space after.**
```r
    result[,i] <- row_quantile(rand.rsq[,i,], sig.level)
                                           ^
```
[R/wt.R:75:14:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wt.R#L75) *warning:* **no visible global function definition for ‘check.datum’**
```r
  checked <- check.datum(d)
             ^~~~~~~~~~~
```
[R/wt.R:81:20:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wt.R#L81) *style:* **Commas should always have a space after.**
```r
  sigma2 <- var(d[,2])
                   ^
```
[R/wt.R:107:11:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wt.R#L107) *warning:* **no visible global function definition for ‘wt.bases’**
```r
    wb <- wt.bases(mother, k, scale[a1], param)
          ^~~~~~~~
```
[R/wt.sig.R:42:40:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/wt.sig.R#L42) *warning:* **no visible binding for global variable ‘MOTHERS’**
```r
  mother <- match.arg(tolower(mother), MOTHERS)
                                       ^~~~~~~
```
[R/xwt.R:75:40:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/xwt.R#L75) *warning:* **no visible binding for global variable ‘MOTHERS’**
```r
  mother <- match.arg(tolower(mother), MOTHERS)
                                       ^~~~~~~
```
[R/xwt.R:78:14:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/xwt.R#L78) *warning:* **no visible global function definition for ‘check.data’**
```r
  checked <- check.data(y = d1, x1 = d2)
             ^~~~~~~~~~
```
[R/xwt.R:93:23:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/xwt.R#L93) *style:* **Commas should always have a space after.**
```r
  d1.ar1 <- arima(d1[,2], order = c(1, 0, 0))$coef[1]
                      ^
```
[R/xwt.R:94:23:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/xwt.R#L94) *style:* **Commas should always have a space after.**
```r
  d2.ar1 <- arima(d2[,2], order = c(1, 0, 0))$coef[1]
                      ^
```
[R/xwt.R:105:22:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/xwt.R#L105) *style:* **Commas should always have a space after.**
```r
  d1.sigma <- sd(d1[,2], na.rm = T)
                     ^
```
[R/xwt.R:106:22:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/xwt.R#L106) *style:* **Commas should always have a space after.**
```r
  d2.sigma <- sd(d2[,2], na.rm = T)
                     ^
```
[R/xwt.R:127:9:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/xwt.R#L127) *warning:* **no visible global function definition for ‘ar1.spectrum’**
```r
  P1 <- ar1.spectrum(d1.ar1, wt1$period / dt)
        ^~~~~~~~~~~~
```
[R/xwt.R:128:9:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/R/xwt.R#L128) *warning:* **no visible global function definition for ‘ar1.spectrum’**
```r
  P2 <- ar1.spectrum(d2.ar1, wt2$period / dt)
        ^~~~~~~~~~~~
```
[tests/testthat/test-convolve2D.R:7:12:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-convolve2D.R#L7) *style:* **Commas should always have a space after.**
```r
  y <- c(1,1,2)
           ^
```
[tests/testthat/test-convolve2D.R:7:14:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-convolve2D.R#L7) *style:* **Commas should always have a space after.**
```r
  y <- c(1,1,2)
             ^
```
[tests/testthat/test-convolve2D.R:9:27:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-convolve2D.R#L9) *style:* **Commas should always have a space after.**
```r
    convolve2D_typeopen(x,y),
                          ^
```
[tests/testthat/test-convolve2D.R:10:18:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-convolve2D.R#L10) *style:* **Commas should always have a space after.**
```r
    convolve2D(x,y, type = "open"))
                 ^
```
[tests/testthat/test-convolve2D.R:15:12:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-convolve2D.R#L15) *style:* **Commas should always have a space after.**
```r
  y <- c(1,1,2)
           ^
```
[tests/testthat/test-convolve2D.R:15:14:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-convolve2D.R#L15) *style:* **Commas should always have a space after.**
```r
  y <- c(1,1,2)
             ^
```
[tests/testthat/test-convolve2D.R:17:18:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-convolve2D.R#L17) *style:* **Commas should always have a space after.**
```r
    convolve2D(x,y, type = "circular"),
                 ^
```
[tests/testthat/test-convolve2D.R:20:1:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-convolve2D.R#L20) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-convolve2D.R:21:1:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-convolve2D.R#L21) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-plot.biwavelet.R:27:1:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-plot.biwavelet.R#L27) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test-rowQuantileC.R:41:22:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                     ^
```
[tests/testthat/test-rowQuantileC.R:41:24:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                       ^
```
[tests/testthat/test-rowQuantileC.R:41:27:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                          ^
```
[tests/testthat/test-rowQuantileC.R:41:29:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                            ^
```
[tests/testthat/test-rowQuantileC.R:41:31:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                              ^
```
[tests/testthat/test-rowQuantileC.R:41:33:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                                ^
```
[tests/testthat/test-rowQuantileC.R:41:35:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                                  ^
```
[tests/testthat/test-rowQuantileC.R:41:37:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                                    ^
```
[tests/testthat/test-rowQuantileC.R:41:40:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-rowQuantileC.R#L41) *style:* **Commas should always have a space after.**
```r
  data <- matrix(c(1,1,NA,2,3,3,3,5,NA,NA), nrow = 1)
                                       ^
```
[tests/testthat/test-wclust.R:17:10:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-wclust.R#L17) *style:* **Commas should never have a space before.**
```r
w.arr[1, , ] <- wt.t1$wave
        ~^
```
[tests/testthat/test-wclust.R:18:10:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-wclust.R#L18) *style:* **Commas should never have a space before.**
```r
w.arr[2, , ] <- wt.t2$wave
        ~^
```
[tests/testthat/test-wclust.R:19:10:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-wclust.R#L19) *style:* **Commas should never have a space before.**
```r
w.arr[3, , ] <- wt.t3$wave
        ~^
```
[tests/testthat/test-wclust.R:28:37:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-wclust.R#L28) *style:* **Commas should always have a space after.**
```r
  expect_equal(dim(c$diss.mat), c(3,3))
                                    ^
```
[tests/testthat/test-wtc_sig_parallel.R:9:21:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-wtc_sig_parallel.R#L9) *style:* **Commas should always have a space after.**
```r
d1.ar1 <- arima(d1[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[tests/testthat/test-wtc_sig_parallel.R:10:21:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-wtc_sig_parallel.R#L10) *style:* **Commas should always have a space after.**
```r
d2.ar1 <- arima(d2[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[tests/testthat/test-wtc_sig_parallel.R:39:34:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-wtc_sig_parallel.R#L39) *style:* **Commas should always have a space after.**
```r
    expect_equal( dim(out), c(42,64) )
                                 ^
```
[tests/testthat/test-wtc.sig.R:9:21:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-wtc.sig.R#L9) *style:* **Commas should always have a space after.**
```r
d1.ar1 <- arima(d1[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[tests/testthat/test-wtc.sig.R:10:21:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-wtc.sig.R#L10) *style:* **Commas should always have a space after.**
```r
d2.ar1 <- arima(d2[,2], order = c(1, 0, 0))$coef[1]
                    ^
```
[tests/testthat/test-wtc.sig.R:39:34:](https://github.com/vsimko/biwavelet/blob/08ccefb208548141fa540b578f3f350386309cb2/tests/testthat/test-wtc.sig.R#L39) *style:* **Commas should always have a space after.**
```r
    expect_equal( dim(out), c(42,64) )
                                 ^
```


Document/ИнвентаризационнаяОпись/ObjectModule.txt

Тестовое сообщение


II didn't want to introduce a constructor which only purpose would be
testing. There's no other reason why the project path would be null. So I
agree it would reduce the set of changes, but it would also introduce
confusion, so I'm -1.
Le 3 févr. 2016 10:57, "Rodrigo B. de Oliveira" <notifications@github.com>
a écrit :

> Introducing another constructor delegating to this one would minimise the
> scope of changes.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gradle/gradle/commit/75a42dcd7ebc03e4c54416df43e64b4324731738#commitcomment-15851938>
> .
>


"to avoid weird names now that the code has been re-organized" refers to using 'reference_autocompletion.coffee' for the autocomplete function used in the edit reference form, and using 'references_autocomplete.coffee' for the search box available to all users.


「不便」転じて「あまりうまく処理されません」という訳はどうでしょう？


Not really :-) Projects must go through a release review as per https://eclipse.org/projects/dev_process/development_process.php#6_4_Releases
It's important that the PMC as well as Eclipse's IP team get a chance to review the status of a project prior to a release so as to identify possible issues with 3rd party dependencies, review the overall "health" of the project, etc.

I understand it is a significant overhead compared to a "normal" GH project, but this is really meant to encourage broader adoption in commercial and industrial solutions, at the end of the day...


Oh, right, that's a problem... Well, shouldn't be too hard to find someone who hows to make `Makefile-libbz2_so` work on darwin (it's only 60 lines)


@AByzhynar, `AddConnection()` and `RemoveConnection()` are the only methods that check existence of connection in `MultiframeBuilder`.


If code duplication is not an issue, we could move the entire if-else block to NegoState.Linux.cs and the contents of the if block to Negostate.OSX.cs


ja sam pogledao ovo i mislim da nije dobro


#6504 is related. (Guess we found a victim.)


The PR was for a missing import that's why I merged it.


Please replace existing tab with 4 spaces.


You really don't need to make changes like this when it's working fine.


If an exception is thrown, the transaction also remains open.
To solve the problem you may have to override the `save` method


Es wird für die Vorschaltseite der komplette Angularstak geladen, obwohl kein (so gut wie keins, es gibt eine direktive, für ein div-tag, aber das ist unnötig) Angular genutzt wird und dieser geladene Stack wird bei der weiterleitung komplett verworfen. Die Von schluepper angesprochene Vermischung von planjs und angular macht es nicht besser...


![capture](https://cloud.githubusercontent.com/assets/10598729/12779843/b3205f9c-ca6a-11e5-9690-7ddc9cad7d09.png)

Regarde


Mmm, I would need to test again all my templates to check they continue to work well :-( I haven't experienced the need to take an occurence that wasn't the first one, but I can understand you may need such an option for a few invoices. I must say I don't like very much the rule "we take the first for all fields except totals for which we take the last", because it make it more difficult for beginners who want to write template.

I would prefer the simple rule "always take the first occurence" and an option "amount_last_occurence" (false by default), which you could set to true on the templates that require it.


I would like to make it possible to set no initial capacity so I had to remove the default capacity.


Yep I noticed that, will think about this.


「%d 回目, 結果 = %A」とかでもいいかなと思いましたが好みの問題ですね。いいと思います。


lgtm


Use this file to find the stores, shops, restaurants etc on your location.  This is done using Google map api v3.   Just copy the index.html and you should be good.


This is now redone, It can be closed


quem chama esse construtor? eh soh parar de chamar com null (pq nao deveria)


Hurrah!


@muhammadIkramUlHaq you have made this public! which you didn't want?


**FAILURE** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 274](http://ci.infinispan.org/viewLog.html?buildId=34980&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for afc273484411e125b0b7cc288b1d996326032377
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:00:02

Process exited with code 1


Adding -w so that there is a complete hostname match (without -w, dssst1 will also match with dssst10, dssst11 and so on)


click "Edit properties", otherwise it looks weird that the E is upper-case.


I don't mind keeping pg. Added sqlite just so we don't have to debug postgres issues :)


Why is this back?


@muhammadIkramUlHaq anyone from anywhere in the world can access this machine?


Sip is only required for building I think, and not for building libArcus either. `libprotoc-dev` is dangerous to import, since it might get you Protobuf 2, right? Of neither am I certain.


Now the value of the last timestep is the previous state of charge for the first timestep. Optionally an initial capacity can be set.

I fixed the wrongly placed if statement in the next commit.


Install [the] proactive agent. Assign the account proactive to what? Will there be a dialog a setting will it happen automatically? You can be more precise here.


It doesn't matter then. Whoever needs pg vs sqlite can change it. Having both doesn't make sense.


you should use the ` IMG_THUMB` constant


Bra grejer! :+1:


> why would you want this anyways? Every phone can do screenshots if you can play Minecraft.

Cameras are so useless.. okay, they are back.


debug raus


I'm confused...why do we have this here too?

The one at application.js seems to do the same thing. I've commented this out and it seems to work as before.


Please indent.


Missing one underscore character in constructor name ```_construct()``` instead of ```__construct()```


> Note that officially there should not be semicolons on lineendings in QML, except for inline javascript.

Didn't know this either. Thanks!


Awesome! 👍


Resource Manager and the Scheduler. Capital. It says to do so in the README.adoc in the documentation project. If we all do it then it will look concise and nice.


Scheduler Agent


ProActive Server


Why did you remove `While`?


Scheduler Server


Can this be changed to the raw JTA dependency now and add the dep on JDBC?


duplicate inclusion?


Запятая не нужна


This update killed possibility to read JSON from files on host. I'm changing `CommandInstall` to enable it again


Много дыр


But that's my point -- it's already in local scope, so you don't need to declare it as a variable to use it that way.


I have some stupid questions:
what does this do? what is "v" used for?

why not do it directly with:
QString::fromUtf8(PyUnicode_AsUTF8String(value))?
For me it isn't logical to translate a unicode to a string and set it to a PyObject called unicode which is actually a string:-) This string thing is definetly too dificult for me.

PyUnicode_AsUTF8 -> takes a python unicode object and translates this to a string useable in c++. Setting this to a PyObject * creates a python string object. At least this is what the name of the function says. I didn't understand this at first so I thought it could be helpful for you too.


Man, that's just weird.


asserts are present in the method 'Decrypt' called inside.. Do we want to duplicate?


Как по мне, то звучит не очень. Типа, вы нас задрали своими жалобами, вот вам, хавайте(


Тестовое сообщение №2


Fair enough.  Good point about the bindings, probably has some kind of lifecycle/dependency benefit.


В остальных языках не-Title case.


WTF were Minecraft devs thinking... Yeah, why don't we add computer with GitHub pre-installed is their next idea -_-


That's the idea :-)

However the names[0] prefix bothers me, seems like a requirement of the view right? Not sure if a business validator is the place to put such logic.


Totally doesn't need doing. Order of operations, man.


I only reverted this part on the tvOS target which you didn't comment on earlier. But the reasoning is that we just tried to upload a tvOS app to the App Store but it was rejected due to an incorrect bundle identifier. So I reverted it for tvOS only, keeping it clean on the iOS target.


This would be so much easier with AssertJ. :wink:


##### Demo: http://null09264.github.io/Waves-and-Currents/


@Kozoriz , task is open


難しいですね。。。
「しかしながら、たとえば`EvalExpression`から返される`FsiValue`のような型を必要とするような未処理のオブジェクトが無く、なおかつ`FsiEvaluationSession`が既に破棄済みであることが確実なコードだけが収集可能です。」
という感じでどうでしょう？


<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

	 <meta charset="utf-8">
	<title>GAME</title>
	<link rel="stylesheet" href="style.css" type="text/css" media="screen" />

Новая игра


Always har to knwo if it's must be SURVEYNAME or SITENAME ;)


Why? Really, what's the problem with raw pointers?


@datavoyager the repo is fork


I know this and I'll change it. Just for know I kept it, because I haven't implemented configuration yet. And since only narayana-jta includes jbossts properites, sample app doesn't work without it.
I'll move it to the simple modules as soon as the configuration is implemented.


window.onload = (function startGame() {
var sg = this;

//хранение данных
sg.snakeData = [
{
keyboard: {
	left: 37,
	right: 39,
	up: 40,
	down: 38},

}
];
//создание матрицы функция
sg.createMatrix = function(){
	var cm = this;
	var matrix = document.getElementById('matrix')
	var n = 20 * 20;
	for (var i = 0; i < n; i++) {

	var div = document.createElement('div');

	              div.className = 'cell';

	              matrix.appendChild(div);

	          }

}
//получение ячеек
sg.getCell = function(row, col) {

	          var divs = document.querySelectorAll('.cell');

	          return divs[row * 20 + col]

	      }
//установка маркера ячеек
sg.setCell = function (row, col, val) {

	        var div = sg.getCell(row, col)

	        div.classList[val ? 'add' : 'remove']('mark')

	      }

sg.createMatrix(); //создание матрицы обьвление
sg.setCell(0, 0, true);
}
)


"to secure" seems unnecessarily vague.

I suggest changing the 2nd half of that sentence to something like:
"...<xref target="RFC6125"/>), a different approach is needed when more than one of the leftmost labels in a DNS-ID are considered private (e.g. <spanx style="verb">top.secret.example.com</spanx>)."


Верно, здесь не нужен Title Case.


create project


```
atlantis stephane 11:57 ceylon $ ls -lsa ~/.ceylon/repo/com/redhat/ceylon/maven-support/2.0/
total 2280
   4 drwxrwxr-x 2 stephane stephane    4096 Oct 15 17:55 .
   4 drwxrwxr-x 3 stephane stephane    4096 Oct 15 17:55 ..
2264 -rw-rw-r-- 1 stephane stephane 2317516 Dec 16 12:03 com.redhat.ceylon.maven-support-2.0.jar
   4 -rw-rw-r-- 1 stephane stephane      40 Dec 16 12:03 com.redhat.ceylon.maven-support-2.0.jar.sha1
   4 -rw-rw-r-- 1 stephane stephane    2049 Feb  3 11:53 module.xml
```

So the jar got put there a while ago, and the latest build just put the module descriptor there, contrary to your `exclude`. Not exactly what you expected, no? ;)


The name is confusing - it should be equal false if code is successful and true if it is not. What about rename it?


Hello @nervgh, @d42f !

This fix, actually breaks the logic of next uploads. It just raises the $destroy event, which unbinds from 'change' event. It works on example page with version 2.1.3, but not with 2.2.0 which is in bower


@redmunds The problem is the test created with `\n` line ending.
To test the `\r` case I need a document with `\r\n` line ending.
If I understood correctly codemirror always normalize line ending to `\n`.
So I need to create the test snippet with `\r\n` line ending or I don't see a way to test the `\r` case.


Я писал об этом в письме. Надо придумать вариант помягче.


See http://doc.qt.io/qt-5/qml-codingconventions.html
No line-ending semi-colons except in javascript. I do frown upon their inconsistent use of concatenation in the qml part though.


Actually that's a weird one. For some reason, if I don't add this tests in sample application cannot find JMS integration classes. Maybe it's because of the "optional" set to true above.
Since I saw the same thing for Atomikos, I've just put in an extra test dependency. However, I think that this needs a bit more investigation.


Точно Mobil?


@joakim-hove: Why std::map? I would prefer std::vector< std::vector< double > >. The mapping from name to id can then be handled with a map.


ASIHPdev (shenb) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-56.45%25-red.svg)


Didn't even know we used that :8ball:

Like that `Assertions.assertThat(message.getStreams()).containsOnly(stream1, stream2);` ?


@akapaul it for 1.* version


do you even english?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1290](http://teamcity.monogame.net/viewLog.html?buildId=14315&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Yes.


I am unsure what this line has to do with an App Store submit as it is only relevant to the SVProgressHUDs project and not your Apps Xcode project.


No need to include the_geom?


Clearly our killing feature. :+1:


yeah I agree. What would you recommend ?


Generally better to use API rather than querying values directly:
if current.deployment_settings.get_gis_spatialdb():
    xxx
(As you can see this wraps the postgres check already thus allowiong a single point to change if we start supporting spatialite for instance)


Глаз-алмаз! Да, телефон тут не должен быть мобильный, а обычный (или генерик, подходящий и под городской, и под мобильный).


Oh, no recommandation ....

Some user want : always SURVEYNAME, some other SITENAME , easily updatable in own template .

User vote on forum ;)


Just the sequence, to point the end of the string


На всякий случай, лучше перепроверить через Google Translate и строчки на непонятных языках, чтобы там не было мобильного телефона.


@prathamesh-sonpatki can you get rid of either one.


I would just mention Shapely here...since changing DB on a live system would be a much more major endeavour


its fixed now
https://github.com/borisbstyle/betaflight/commit/403812c45f79b037504c13d3c3233b5139ed3e1a


Use wkt instead...this is available in all DBs whereas the_geom only on spatials...


thanks mate


location[1,2].wkt to work on non-spatial DBs


opkaiii


Now that we are splitting ACKs from checklists, perhaps this should be 2 dfifferent settings?


Maybe, [range-for](http://en.cppreference.com/w/cpp/language/range-for)?
The code now looks like this:
`for (auto i : objects_)
{
	(*i)->move();
}`


Acknowledged


For some reason Cryodex 4.1.2 does not import anything from the Cryodex.save file for me and saves an empty file on exit. Does anyone else see this, or is it a local error. I can't scan anything in the changes that should create this behaviour.


geht aber nicht als Array zurück, oder?


`data` is a plural form from singular `datum`.
`datas` doesn't make sense.


Why do we need catalog_layers here? prob does nothing with map off anyway...same for points =False no need to add this as just confusing


'received' instead of 'defined'?


As-above


T("Checklist Template")


Thanks. Now my code looks much better.


I'm not sure that here is an SOP.
The template is an SOP, ok...but here this is an individual/Specific checklist, not an SOP


I am a god in the end. My phone didn't have data for 2 weeks, so when I got my data back I vpn'd the shit out of it and now were cruising smooth


I am thinking about removing transaction management as this looks more like user preference. Also if transactions are added, user could not open any other transaction as just one transaction could be opened at a time.

Will include in docs that the using of transactions is recommended. Transactions will also improve performance a lot and we do not really have to care too much about bulk inserting or whatever. At least at the moment.


> Whoever needs pg vs sqlite can change it.

We should not waste time over it in workshop. We should promote sqlite for workshop.


This is Incident, not Type

I wonder why you are adding these PopupLinks here...is the workflow really going to happen like that?
I very much doubt it...in 99.9% of cases the Event/Alert will be done & then the Checklists created automatically...so I would minimise this visual clutter which cater only for a likely non-existent usecase.


https://github.com/classicdb/database/commit/1d9e84307e704152c0f049de44c746cb9e3e81eb was one of my first dungeons done. But I have yet to calculate a new base damage for mages.


T("Checklist")


Sure, thats what I am saying, get rid of pg then. Keeping it in Gemfile, people are still going to face issue that pg is not installed.


Oh how this commit bit me and an half an hour was lost in the working day. Lessons were learned. None of this your fault of course.
I'm curious, is there anything in the repo that would hint at breaking changes so as to help find the issue quick?


Yeeaaahhhh :relieved:


My original code writes a log entry every time a Client tries to upload a file we already have marked as complete (read-only). I didn't monitor it very closely until now. Here are the overall numbers:
Since Dec 17 there where 18284 reupload tries (381 avg per day) of result files. Eliminating duplicate tries for the same file there are still 10485 (218 avg per day) unique reuploads.

Looking only in the logs from Feb 2 2016 there are 394 tries (206 unique files) from 73 different IP addresses. Mapping those addresses to Client versions and platform (reported in the HTTP request) you end up with this list:
```
arm-android-linux-gnu 7.4.39
arm-android-linux-gnu 7.4.41
arm-unknown-linux-gnueabihf 7.4.23
armv7l-unknown-linux-gnueabihf 7.2.47
i686-apple-darwin 6.10.58
i686-pc-linux-gnu 6.10.17
i686-pc-linux-gnu 6.10.44
i686-pc-linux-gnu 6.10.58
i686-pc-linux-gnu 6.10.59
powerpc-apple-darwin 6.12.35
windows_intelx86 5.8.16
windows_intelx86 7.2.39
windows_intelx86 7.4.36
windows_intelx86 7.6.22
windows_intelx86 7.6.9
windows_x86_64 7.2.39
windows_x86_64 7.2.42
windows_x86_64 7.4.27
windows_x86_64 7.4.36
windows_x86_64 7.4.42
windows_x86_64 7.6.22
windows_x86_64 7.6.9
x86_64-apple-darwin 6.12.33
x86_64-apple-darwin 7.0.26
x86_64-apple-darwin 7.0.65
x86_64-apple-darwin 7.4.26
x86_64-apple-darwin 7.4.42
x86_64-apple-darwin 7.6.12
x86_64-apple-darwin 7.6.22
x86_64-pc-linux-gnu 6.10.44
x86_64-pc-linux-gnu 6.10.58
x86_64-pc-linux-gnu 6.12.22
x86_64-pc-linux-gnu 6.12.43
x86_64-pc-linux-gnu 7.0.27
x86_64-pc-linux-gnu 7.0.36
x86_64-pc-linux-gnu 7.2.33
x86_64-pc-linux-gnu 7.2.42
x86_64-pc-linux-gnu 7.4.42
```
The next thing I'm going to check is if the file sizes differ between the original upload and the retry. My current working hypothesis is that the client does not get the success message after the first upload and retries again later. Another thing could be that the user resets his computer from a backup but I would expect less retries in this case.


done


Out of curiosity, is there a reason you are not using ffmpeg 2.8 series instead?


It seems that many projects (e.g. Newtonsoft.Json) which include NuGet.exe place it in <root>/Tools/NuGet/NuGet.exe and other tools also under Tools/<Tool name>
My future pull-request for the build script would also place it there.
Maybe remove this addition, as not related to topic of the branch and will conflict later?


what about duplicat of comment. can you remove it?


This code can be simplified as follows:
```
options.put("useTicketCache", ticketCache.toString())
```


hope this works with sqlite adapter now.


This is still a DAL query within a loop...can this not be done in bulk outside the loop?


This is a nitpick: we've been using 40 chars (SHA1) based job IDs, so I think it would make sense to use SHA1 here as well. It also goes better with our "inspired by git" saying.

Note: md5sum is fine for those purposes (we're not trying to choose an algorithm that is collision free), it's just a matter of coherency with our other uses of hashes.


Another DAL query inside a loop:
Again, this should be done outside the loop in-bulk


Well it doesn't get put there *now* at least ;)


> This named route doesn't look right.

As of 2ed30a6 it's now

<pre>
new_followup_no_incoming        /request/:request_id/followup/new(.:format)                             followup#new
            new_followup        /request/:request_id/followup/new/:incoming_message_id(.:format)        followup#new
        preview_followup POST   /request/:request_id/followup/preview(.:format)                         followup#preview
         create_followup POST   /request/:request_id/followup(.:format)                                 followup#create
</pre>

> Should be able to define these with `resources` rather than `match`

I did not manage to get the routes exactly how I wanted them with `resources` so it's still `match` I'm afraid


I think the choice of methods for inequality_index is not very intuitive. I think the constructor is good, but the idea behind unite() and calculate_index_size() seemd weird. I suggest replacing unite() with another constructor that takes 2 sets and the constructed set is the union of the two given sets. Also, in such cases the parameters are usually given by reference (or const reference in this case) rather than by pointer. And the calculate_index_size() should just return the size of the set it is called for, so no need for arguments. Now it does two operations in one (unite and compute size) but this is just an unnecessary complication. Also, name size() is more fitting than calculate_index_size(), since it is already a method of inequality_index class and it is clear what size are we talking about.


Is this a joke?


It's important because the Bundle Identifier in the Info.plist file is set to `$(PRODUCT_BUNDLE_IDENTIFIER)` in order to make sure we don't have a bundle name like `SVProgressHUD_tvOS` which would lead to an import statement like so: `import SVProgressHUD_tvOS`. Instead by setting the PRODUCT_BUNDLE_IDENTIFIER and using that as the bundles identifier an import statement can look like this: `import SVProgressHUD`. At least this is what I remember right now.


why `channelName` as opposed to just `name`?


OK, I think you are right then - its likely optional is the issue and if its consistent with the others that is probably fine then


As above, I think we should be consistent if possible and stick with just name as an attribute of channel.


Please consider adding yourself to `maintainers`.


Can I just add one lowercase "manouche"?


OK. Will check. It's time to do a test that compares documents against a known CSV or something.


Blub


This is just a variable name. It doesn't affect the API. (That said, I can change it.)


I don't follow this logic.
What defines whether an Alert needs ACKing?
A) The deployment_setting
B) That someone is subscribed to the Alert by Admin

That's it?

Surely some Admin subscriptions could require ACKs & some just be FYI?


Isn't this the same as.:


Does it make sense to instantiate an asset without a name? It could:

```
>>> a = Asset(locations=['http://foo.bar/foo.tar.gz'])
>>> a.fetch()
>>> a.name
foo.tar.gz
```

But, IMHO, this makes the overall logic of the Asset class more complex.

I for once, would make the name mandatory, and while at it, make the name a possible location if no other is set. Example:

```
>>> a = Asset('http://foo.bar/foo.tar.gz')
>>> a.name
foo.tar.gz
>>> a.fetch()
```

(Results in downloading from the "name" location).


The purpose is to test the build running the external project and not relying on a system `SlicerExecutionModel`.
But `circleci` looks good!


As with other commit, I believe this should be name


Hello Internet, whats going on?  i am testing some github features.


The Channel attribute is called name (https://github.com/ably/ably-ios/blob/master/ably-ios/ARTChannel.h#L22). This is just an argument name for this method.


Those indentations would be best to keep. Not sure what changes them each time when you edit these files, but they're that way for a reason, aligned with the coding style of the rest of library : )


Ah, yes, true, but I still think calling it `channelName` for a `channel` method is unnecessary.


neverending -> infinite


oh ok, I'll try. In this case it was mostly to have a quick reference of
how the old code worked, in case there is a bug because of a mistake I did

On Wed, Feb 3, 2016 at 3:52 AM, Rémi Verschelde <notifications@github.com>
wrote:

> It would be great if you could add a comment too when you add #if 0s, to
> explain why the code is commented out and not removed (i.e. why it could
> still be needed later on).
>
> We tend to have tons of #if 0s in the code base and it's painful to
> always have to browse the git history to see when they were added and try
> to understand why.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/godotengine/godot/commit/f026838cbc60ec7eeed45d6d30c22a3b73a57bc0#commitcomment-15848605>
> .
>


Requirements for TLS clients should go into the "TLS Client" section (currently numbered 9.2).
I suggest that you restore the previous text for this paragraph, and then add an xref to a new subsection of 9.2 that covers what TLS clients MUST do when they need to reconstruct a TBSCertificate.


```
+/obj/structure/falsewall/mime
 +	name = "silencium wall"
 +	desc = "A wall with silencium plating. Honk!"
```

HONK??!


Here Checklists are only ever used if ACKs are...I'm not too keen on that coupling, but OK

I was envisaging 2 separate messages being sent:
* Get all the ACKs out ASAP
* Get the Checklists out

I feel this reduces the potential delays


IMHO we should make `cache_dir` an Avocado feature that this API get's to know about. The reasoning is that, while the test writer may be interested in setting a specific cache directory, most often than not, he's not. The cache directory should be analogous to the job results directory, something the framework gives for free to the test writer.


The memory effect is even more significant when removing the base value:

Base value (imports, no operation): 6.6 MB
Read all: 19.9 MB
Read by line: 9.0 MB

So the operation itself goes from 13,3 MB to 2,4 MB, which is a nice saving but not a game-changer.

The performance difference is too unstable to tell anything. Reading by line is sometimes slower than reading the entire file at one, sometimes faster. The range is +/- 10 %.

If we change that, we should read into a fixed size buffer. Anything between 1024 and 65536 bytes is fine here. Since the performance range is smaller than the per-run variation, I'd opt for the smallest memory consumption.

```
$ nice python preprocessor-streaming.py
Read entire file: 2.26358222961
Stream by line: 2.39651703835
Stream buffer size 16: 3.38299393654
Stream buffer size 64: 2.30872607231
Stream buffer size 256: 2.18445301056
Stream buffer size 1024: 2.13552999496
Stream buffer size 2048: 2.12127494812
Stream buffer size 4096: 2.11086797714
Stream buffer size 8192: 2.11169290543
Stream buffer size 16384: 2.10043811798
Stream buffer size 32768: 2.09142613411
Stream buffer size 65536: 2.09713602066
25212 kilobytes on Linux, bytes on OS X
```

Updated script: https://gist.github.com/webmaster128/50aa098ea4c2d840f3b4

The numbers might be different on Windows.

The big question is, if it is possible to stream STDOUT and STDERR at the same time, since we want the collected STDERR in case of an error. From what I found yesterday, this is not exactly trivial.


Ok, will check whether sip is a dependency of my binary package. There are
functions during building the packages which scan for dependencies of the
binary packages automatically. '''libprotoc-dev''' is correct according to
my own packaging of protobuf3, but generally it should install protobuf2
packages, right. Maybe I'll rename this package into '''libprotoc3-dev'''
if necessary. But at the moment nobody blamed me about this problem with my
PPA, so I'll keep it like this.


Why would the first be the generic one!?
That should be the one with location_id == None


You can use something like this
```PHP
/**
 * Class Transaction
 *
 * @mixed Eloquent
 */
trait Transaction
{
    /**
     * Save the model to the database.
     *
     * @param  array $options
     *
     * @return bool
     * @throws \Throwable
     */
    public function save(array $options = [])
    {
        $connection = $this->getConnection();
        $connection->beginTransaction();
        try {
            $saved = parent::save($options);
            if ($saved) {
                $this->getConnection()->commit();
            } else {
                $this->getConnection()->rollBack();
            }

            return $saved;
        } catch (\Throwable $e) {
            $connection->rollBack();
            throw  $e;
        }
    }
}
```


Yeah, it's a typo. Sorry about that! Should be just `it` instead of `it.only`. What's the best way to change it? Should I submit a PR?


@JohnCheNey, Thank you for your cooperation!


This seems all wrong I'm afraid.
There shouldn't be any need to check Intersects for templates & alerts.

I see the Intersects used for deciding whether a recipient gets an Alert
If they get an Alert then we look for a location-specific checklist by exact match location_id == location_id...not by an intersect


Ok this may look good, will probably go this way, thanks.


Please write your answers under the "// Task N"


Wildcard labels are "considered redacted" (see previous paragraph).  So are they included in the "total number of redacted labels", or not?

I suggest: s/total number of redacted labels/total number of <spanx style="verb">?</spanx> labels/


According to [this](http://www.swi-prolog.org/pldoc/man?predicate=between/3), `between/3` accepts both,but infinite is indeed prefered so I changed it. I'll keep in mind `sup`, where I to implement CLP(FD) in the future.


I'm opposed to treating Sentiment as a form of Categorizer in the simplified response, even if this leads to some redundancy. Customers don't think of them as the same operation. My arm could be twisted.


Then I'll eliminate that.


looks good!


What about this:

var myObject = {};


should be `return log_error_errno(…` rather than just `log_error_errno(…`. Failure should be fatal here I think.


Task 3 is failed


Thanks a lot for the feedback, I appreciate having it.

Docs, guidelines and testing are things we sorely need. The main difficulty here is the amount of churn Ink is going through right now ([e.g.](https://github.com/JunoLab/atom-ink/compare/omm/console)); I don't feel confident setting things in stone before we're really sure that the API and the architecture are really right. For the inline results and console, at least, I think that will happen over the next month or so, and we can start getting docs and so on going then. (Docs are particularly useful when they come from an outside perspective, I think, so if you have any notes you'd like to put up, we'd definitely appreciate them.)

Breaking changes are largely linked with the above. Aside from promising not to totally change the APIs (and we can use Atom's service versioning when we do), I think the best thing will be for us to keep tabs on what dependents exist and help by e.g. warning or sending in PRs for the changes ourselves. Ink is only ever likely to have a few dependents so that shouldn't be a huge challenge for us.

I haven't thought about the npm package thing in detail and could perhaps be persuaded, but the main upsides to Atom packages are (1) making it possible for packages to share a global ui (like the Linter does) and (2) making it easy for people to swap out alternate versions and forks.


@thvitt OK?
Asking because "item" is rendered in a red color.


I'd leave this to Python's "duck typing", I mean, we should document what the user should pass as the parameter, but in the end, anything that Python can iterate on should be fine (a Set is another example).

It's not common, exceptions exist, to do this manual type checking in Python code.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1290](http://teamcity.monogame.net/viewLog.html?buildId=14315&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 584, ignored: 6 Build time: 00:30:15


Well I've compiled a list of suggestions for commit messages some time ago. I don't get why the duplication of effort.

https://docs.google.com/document/d/1cJ0bE8IJglRVBcfBVLMONGjyidLRCtCDlMwm4dfAChY/edit?usp=sharing


As I mentioned in another comment just now, I think the description of how to reconstruct the TBSCertificate belongs in the "TLS Client" section, since it describes things that TLS clients MUST do.


I am assuming that these ACK messages replace any normal Alerts these people receive...is that correct?
(Otherwise the intersects doesn't make sense)

So the logic for ACKs is:
A) The deployment_setting
B) That someone is subscribed to the Alert by Admin
C) The subscription matches on Event Type, Priority & Location

I still think that there are cases for FYI-only Admin-controlled subscriptions (check with Nuwan if-needs be), but either way good to put this logic explicitly in the code comments.


I fail to see how the caching is effective here. What I mean is, calling `fetch()` should first (provided a hash was given) look into the cache directory, then, if not found or corrupt, download it from one of the locations.


& what if ACKs are off?
Do the subscribers get no Alert at all?
Or is that handled elsewhere?


Please fill-out this checklist


Hi

I fixed the above mentioned issues also some more deprecated constructors fixes

But when I view the commit it is showing some UTF8 characters changes and my editor still show UTF8 mode any idea what is happening?

https://github.com/practiceprovider/openemr/commit/58d35d4541219f4fa6ac4d95135301a88bf816ed


Oops, my bad. I missed the earlier block (line 55).


I still don't see any Instances of Super Entities beuing created/updated here?


The path to the Solv file has been changed back to the old one just for purposes of a presentation on DevConf. Later, the path will be adjusted according to the version of Fedora.


@flavour But the alert location is polygon and the template location is most probably Lx as we provide LocationSelector. So isnt there very less chance that these location_ids be same?
So here what I am trying to do is see which template should be used for this particular alert(location), if none found use the generic one?


In accordance with the way that the `date` validator has been implemented, should this not be `data-validate="required,date" data-future-date` instead of `data-validate="required,date,future-date`?


This even would crash due to a typo: entries not entires
But as I have said a couple fo time, I don't see it as needed here?


*CONTAINS operator


test


Looks good. I'm still not sure about the boilerplate inside the naming policy proxy. Perhaps we could instead tie the registry ordering to the proxy so that it's a bit more intelligent about what policy to pick, instead of always picking the first one in the list (use CS global setting?). I guess though that the ordering setting works with this.

Also we need to prepare a technical summary about what exactly is going on in this commit:
* What it is.
* Rationale.
* Any new features.
* Explanation of the proxy class.

This summary will be put into the pull request description.


@flavour The admin based subscription are handled here: https://github.com/flavour/eden/blob/master/modules/templates/SAMBRO/controllers.py#L628


I see no value in the intermediate ack_data variable here?


I think so. Syntax highlighting is probably because of `item()`


I think you miss a lot of stuff in this commit ; like the insertion of fancybox if configuration is set and all of the rest like that, no ? :)


Are you sure those changes are related to the current PR?
They look like i18n changes you did for the search filters. In addition translations such as "This field must be between -180° and 180°." are related to the editing page, not the view page.


tested on one of my test setups.. I can see it connects with ntlm when dc is not reachable .. it takes little more time though.. may be it waits for certain timeout for DC to respond.


Этот `else` все равно был лишним.


Bad commenting. asdasd doesn't explain the function of code. Wouldn't work with again.


but it won't be very coherent with the fact that we ask for string, not a constant, don't you think?


Forum link mentioned in the commit message is a 404.


Yup, we get same schema.rb with sqlite3, also tested our whole flow on master branch, it's working properly. Will do an incremental testing on each branch now to make sure everything is okey.


And in phpstorm it doesn't show the change


This also fixes an issue where the ASK query asks for URIs in the wrong namespace (doh)


And advanced feature (can be implemented later) of the cache directory could be to write an index (if writes are allowed) every time a file is saved there. This would require the cache dir to be "trusted", and could allow users to just grab the file pointed by the index without running the hash again. If all things are given, an Avocado-VT check for the JeOS image could be as simple as:

```
a = Asset('jeos-f21.qcow2', hash)
```

With Avocado looking at `/cache/dir/index`, finding the `hash`, and giving back `/cache/dir/jeos-f21.qcow2` without doing any I/O and computation.


get rid of commented out stuff


Good or bad?


shouldn't it be possible that unprocessed_input was not empty?


explain what this is (add a comment? extract to a function?)


extract to a constant


Why?


Isn't that unnecessary since you derive from IMessage?


Commented


add a comment what the page means here


Let us remove the user id from the journal name, so just test for user-*.journal
You can use re module for the same.


We need to take common properties out of the case statement.


@flavour Yes this is within a loop because I am looking at each 'Relief Team' group (here https://github.com/biplovbhandari/eden/commit/44aee3909ae890dfbe3fda6b086151bf378387f0#diff-4a10b6925357b1b4aa8215107048b7adR251) and each team (usually) has different filter settings, isn't it?


add config parameters to work asynchronously


Well spotted! Thanks.


Behind a Truffle boundary, this directive has no effective. Is this case something that can ever happen anyway?


Can you add some unit tests for this flattening?


> Why the commented last line?

One line is supposed to be 'socket', the other 'hla'. But I can just keep hla and add your comment.


Then you need to return the object for example by using a second queue and insert them in the main process.

For CPU intensive stuff like the file parsing this definitely performs better. Sure the DB uses some CPU too, but it's shared with python. If the script runs your computers CPU is utilized by 100%, but that's the purpose in my opinion - use the ressources we have. Also there is a lot of DB caching going on in the background. I made this a few times so far and never had a problem with it - the single core approach was not usable because it took way too much time. If you run this on a 8Core CPU you can speed up the whole stuff by the factor of 8. If you can also reduce the session commits there is even more performance gain, but it depends your use case.


action :start after the template['/opt/kairosdb/conf/kairosdb.properties'] ? We want to ensure the service running.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/24533/testReport/) for this commit**


Неверно понял явное указание параметра. Функция у тебя генерит ключ из емейла, значит емейл и есть входной параметр для твоей функции, но не request, как его не назови.


jquery는 다른 스크립트처럼 bower에서 설치하는 게 좋을 것 같아.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 14354](https://teamcity.mesosphere.io/viewLog.html?buildId=122525&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 219 Build time: 00:07:07
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


@flavour Does this mean the alert location doesn't affect the acknowledgment? Meaning the admin based subscriber should get the acknowledgement message regardless whether the alert is for that area? But I think this makes sense - alerts sent (admin based) and followup with the ack message?
Then for checklist check the intersection?


@adriengibrat Awesome...thank you!!
https://github.com/wilmoore/curry2.js/blob/master/index.js#L7


В докстринге для такой функции неплохо описать алгоритм ее работы.


Thank you!


Got the translation from Llio.Rhys@bbc.co.uk (see https://jira.dev.bbc.co.uk/browse/IPR-2148)


But no worries, digestion_enzyme gets tested in the [load section of the test] (https://github.com/mwalzer/OpenMS/blob/5303a2a92d91ba5f701ce7a2c3dc4896c0ad95f9/src/tests/class_tests/openms/source/PepXMLFile_test.cpp#L172)


I can change this so it requires only one of the two, untested change below.

```diff
diff --git a/blueman/bluez/Base.py b/blueman/bluez/Base.py
index 057d7a5..197e5de 100644
--- a/blueman/bluez/Base.py
+++ b/blueman/bluez/Base.py
@@ -38,6 +38,9 @@ class Base(GObject):
         if properties: dbus_proxy = self.__dbus_properties_proxy
         else: dbus_proxy = self.__dbus_proxy

+        reply_handler = kwargs.setdefault('reply_handler', None)
+        error_handler = kwargs.setdefault('error_handler', None)
+
         def callback(proxy, result, reply_handler, error_handler):
             try:
                 result = proxy.call_finish(result).unpack()
@@ -45,9 +48,9 @@ class Base(GObject):
             except GLib.Error as e:
                 error_handler(parse_dbus_error(e))

-        if 'reply_handler' in kwargs and 'error_handler' in kwargs:
+        if reply_handler or error_handle:
             dbus_proxy.call(method, param, Gio.DBusCallFlags.NONE, -1, None,
-                callback, kwargs['reply_handler'], kwargs['error_handler'])
+                callback, reply_handle, error_handler)
         else:
             try:
                 result = dbus_proxy.call_sync(method, param, Gio.DBusCallFlags.NONE, -1, None)
```


I know it sounds weird.
With this line to be `"opmcommon"`
```set (opm-material_INCLUDE_DIRS "/home/kaib/OPM/debug/opm-material;/home/kaib/OPM/debug/opm-parser;/home/kaib/OPM/debug/opm-parser-build/generated-source/include;/usr/include;/usr/local/include;/home/kaib/local/dune2.3.1/release_mpi/include;/home/kaib/software/petsc-3.6.2/arch-linux2-c-debug/include")```

With this line to be `""`
```set (opm-material_INCLUDE_DIRS "/home/kaib/OPM/debug/opm-material;/home/kaib/OPM/debug/opm-common;/usr/include;/home/kaib/OPM/debug/opm-parser;/home/kaib/OPM/debug/opm-parser-build/generated-source/include;/usr/local/include;/home/kaib/local/dune2.3.1/release_mpi/include;/home/kaib/software/petsc-3.6.2/arch-linux2-c-debug/include")```


I'm going to propose a challenge here, and you should take it with a grain of salt. Thinking about user visible APIs is hard, but getting them right, is extremely rewarding. If possible, it'd be nice to support this kind of API use:

`path = Asset(name='http://foo.bar/foo.tar.gz', hash=<hash>).path`

Assumes that the asset is mandatory for the test, so an "automatic" fetch is reasonable, and a failure (raising an exception) and ERRORing the test is also reasonable.


Тогда лучше сразу присвоить null


I think it's always better to use constants for this kind of things, avoids typo, refactoring mistakes, etc.
It's not related to the fact that the API user provide the actual value (it would be useless to ask the user to provide the constant name because it would require a textual list of constants, wich is as error prone as the current code... hope I made myself clear...).

Generally this kind of API is coupled with another one that returns the list of possible values.

---
In the meantime the WS server could be enhanced with a list of possible values (the constants VALUES in this case).


thanks for clarification


User name should contains First name and Last Name


Agreed. It just was that way before. Fixed at a7ea666640f0ba18d4ffc09bf308a99ab36887dd.


Use "join" for this


Use "split" for this


Задача только сортировать выборку? Пример из документации:
from django.views.generic import ListView
from books.models import Book

class BookList(ListView):
    queryset = Book.objects.order_by('-publication_date')
    context_object_name = 'book_list'

причем context_object_name тебе менять не нужно.


Awesome! Thank you very much, this helps me to get rid of several workarounds. :+1:


rd


Could you please rewrite your home task according to my comments


Тайтл почему не хочешь прописать непосредственно в шаблоне? Он же не носит характера переменных данных.


I have ended up with something like that, you may agree

https://gist.github.com/IsraelOrtuno/308f3259daaec3515292


Тогда назв. метода должно быть getNamespaces()


template_name может подгружаться по магически сформированному имени.


It was just a small update to see if that helps with some VP9 files
In the past, bumping ffmpeg was tricky.
It seemed to work fine quickly, but then afterward some less used
codec/specifics/corner cases were broken due to some internal changes.
That could be that it should not have worked at all, because it was
incorrectly  used.

So, 2.8 will happen but in a "slow" period, to have the time to test it

On Wed, Feb 3, 2016 at 12:16 PM, İsmail Dönmez <notifications@github.com>
wrote:

> Out of curiosity, is there a reason you are not using ffmpeg 2.8 series
> instead?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mean00/avidemux2/commit/dd4a5e071024bc5d704684ecb77793cb2efd96af#commitcomment-15853553>
> .
>


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


I've put it in both cases because it does not apply to the v2v profile (neither to monitoring or kvm, but these don't have the abiquo.properties file).


@flavour After reading your comments I think I was thinking different usecase...but now makes more sense will update the code
Many thanks for being so patient :)


Did it work now?


It looks to me like only -SNAPSHOT was added to the existing version number? They still say CR1?


Right, but CMake propagates this dependency automatically to all the users which is very handy but undesired in this use case.

Anyway, I am going to remove the CUSTOM_LINK option which allows me to fix the problem.


cc @edolstra


Why?


> Contributions are not recorded by git.

[Exactly](https://github.com/vim/vim/graphs/contributors). That's why they are listed in the [files](https://github.com/vim/vim/search?utf8=%E2%9C%93&q=Contributors).


this ... i dont get
why not config.HealthCheckConfig = helper.healthCheckConf ?


Signed-off-by: Vishal Pandey vishpandey2014@gmail.com


On Windows, linking to something other than `ws2_32.dll` would be a major feature (another network-transport **back-end**?).

But I've not used *libcurl / lwIP* for any sensible things yet. Yang's patches for this (2 years back?) now seems a bit half-done and "hanging in the air". The day this combo really could work, it would be nice to see from the `curl -V` option what **back-end** libcurl is using (instead of running `depends curl.exe` to figure this out) . So this can wait.


Sorry, I missed that.I will remove it in the evening.


I get you (and I've been writing distributed systems in C for a couple of years now, so I can "really fell you"). Have to go to a meeting, will send you a patch for performance testing in one hour or so (just working on the test cases)


AddWarningWhenDElightAndShading (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (2057 of 2057 tests passed, 11 test warnings)

 * 549 tests had: AUD diffs.
 * 11 tests had: BND diffs.
 * 2 tests had: EIO diffs.
 * 2 tests had: ESO small diffs.
 * 8 tests had: MDD diffs.
 * 8 tests had: MTD diffs.
 * 8 tests had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


hay que aclarar que en caso de servicios de tomcat es por ejemplo <context-path>/healthy.html


Why need filtering on that file?


test rpmspec


propongo defaults como ya lo mostraste en el PR de Crane
        health-check-grace-period: 30
        health-check-interval: 20
        health-check-max-consecutive-failures: 3
        health-check-timeout: 10


The static is just important for the scope of the function and becomes important if there are e.g. name conflicts.
The 'inline' directive is for inserting the function body into the code calling the mentioned function. The performance gain is dependent on the architecture usually small (0.1-1%), the size increase can be noticeable dependent on the code.


This line seems problematic with neovim, I have "E78: Unknown mark" here.
Double quotes seem to solve this issue.


:+1: great update!


Thank you for your suggestions.
I will do this and let you know.


Gut gemacht, mach weiter so Leon!


https://git.basistech.net/textanalytics/annotated-data-model/blob/master/doc/Examples.rst#sentiment-results

Sentiment results in the ADM currently reuse CategorizerResult.  Maybe the
name is confusing.  But we had this discussion before adding this to the ADM...


@flavour one question: let's say I subscribe to (3) Lx. The alert is mainly manmade polygon. In that case do I get the alert notification?


it seems that a suffixes should be given, like this: PATH_SUFFIXES "lib"


I think it's better convert it into string

``` Python
s.verify = str(verify)
```
More information http://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#scalar-variable

> Robot scalar values are first converted into a Unicode string and then catenated to whatever is in that cell. Converting the value into a string means that the object's method __unicode__ (in Python, with __str__ as a fallback) or toString (in Java) is called.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27182/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27183/testReport/) for this commit**


Hi,

I was thinking about image slideshows myself. Do you plan to submit a pull request when this branch becomes ready for human consumption? Please note that I'm a very bad coding style Nazi. :)

Also what is `pdf_player.py` and `image_player.py`? Do you plan to package it with `omxd`? Considered using `fbv` for image viewing?

Interesting work :)


Thanks for the contribution.
Please remove options with `value=false`. Also groovy declaration does not seem necessary.
Please remove `spc` as this is error prone and can result in context leaks if not called properly.


As for the question of having both score and confidence, yes, they are
distinct.  But score is currently a raw score, not too useful for customers.
Ideally, we'd just expose confidence in a "simple" api, however, that means
we want confidence to work well.  It may not work great yet.

As for explanations, there is a thread in the R&D mailing list with my views
called "Remove "explanations" from RosAPI?"  I guess I lost that one.


In my project the tableofcontents is missing. What are the steps to get it back? I understand from your commits that you changed the way the toc is generated.


http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html: "An underline/overline is a single repeated punctuation character that begins in column 1 and forms a line extending at least as far as the right edge of the title text."


I would use SOL_INT_CHECK(ret, < 0, ret)


fgdg


@pmclanahan if you're interested to have coverage in basket with the new docker build method. Also https://github.com/mozilla/lumbergh/commit/1aa5ad7432beba2875da29de68af08898874dd2f


@santoshrb mention the link for the bootstrap theme here.


Yes, good catch!


Thanks for adding me to review.
Everything looks great . Except the thing that there must be 2 spaces between the code and the comment.
I mean `}  // namespace name`


I think some basic definiton of the API and a bit of advice on how to use a specific class or whatever should be added as we redesign and things start to look a bit more stable (e.g. [results](https://github.com/JunoLab/atom-ink/commit/66bf648dfe9bcdb0e48d36c57805419fe2f20af1)). This also helps with the design itself, since we have to make up our mind as to how the public API looks and that does help with identifing bad designs with to many exported methods or stuff like that.
Also, it's (hopefully) a bit easier for people looking over the diffs to understand what's going on when there's some docs.


By setting height=50dp, it worked !


Looks ok


Reviewed


we can use this 'CreateExceptionFromError' method which is going to return WIn32Exception only after the fix in PR #5773


On my opinion this is matter of taste. Personally I prefer to write logic as high as possible. The default branch will be deeper (function -> switch -> default->dcheck). Currently it's function -> dcheck.


Even though the RFC always speaks of a "response header" I'd consider it also valid on requests.

The RFC says

> The Content-Disposition response header field is used to convey
> additional information about how to process the response payload, and
> also can be used to attach additional metadata, such as the filename
> to use when saving the response payload locally.

Requests can have payloads just as well, so I'd deem this header also a request header.
For example, multipart/formdata POST requests regularly contain a `Content-Disposition` header in the parts containing the content of an uploaded file.


after re-generating the package with Moveit!_assistant, it did not have these dependencies by default. Do we really need them?


In that case, I would still expect we'd get a specific exception or error code or something, some set of things that we want to fallback for and some set of things we want to ignore.  If, for example, we hit an assert that triggered an exception, or we hit an OOM, or the network was down entirely, or a variety of other things, we don't want to retry with fallback, do we?  And if we're retrying because of transient issues, do we really want to fallback, or simply retry with the same protocol?

I think it's ok to go ahead with this PR without addressing this, but please do follow up on it subsequently.


@VVeremjova , 0585235 , Done


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/27188/testReport/) for this commit**


Lgtm. In general I much prefer argparse, but getopt is fine.


Nuts! 6 errors left. I had not copied over one of the files :(


I haven't tested proto repl with boot yet. I'd rather wait and add that as its own issue. I think there will be other changes that need to get made to make it work. Can you comment out the build.boot part?


Definitely no.
Requests can have entities and almost always contain a `Content-Type` header if they do.


I just added a new line at the end of the file here.


fogefoge :)


It should be ok case. It's normal situation when you try to send e.g. 500 bytes, but socket has only 300 free in the output queue. In this case only first 300 bytes will go out.


ja ensinamos private? se sim, bora lá...


Yes, true. Requests cannot contain HTTP ranges, if I'm not mistaken.


mapa.contemJogador()... mais bonito né? e ai joga o if la pra dentro


Thanks for the explanation.  If you leave it as is, please add a comment to the Linux implementation explaining why the method exists but is unimplemented, similar to your explanation here.  Duplicating a simple if/else block though is also fine, potentially preferable.  Whichever you decide is fine.


@VVeremjova , Done


ui.desenha(mapa);


pq essa variavel eh membro? so declarar onde vai usar


devia estar declarada aqui


mapa.posicaoValida(novaPosicao)


remove(heroi)


We could have multiple templates which intersect with the polygon since polygons typically don't respect Admin boundaries.
Once we know which people can get an Alert (using Intersects) then we match the template.location_id with their subscription.location_id: both of these are Lx


Link headers are general meta-data without any clear semantic boundary.
As such I don't see any reason why we should disallow them in requests.


pq essas duas linhas? precisa mesmo?


se ensinamos private, private


@danfuterman I agree - this code is fine and we can handle the new statuses when those user stories are ready to be worked on.


If Win32Exception is what gets thrown on Windows for similar cases, sounds good.


nao mesmo. troca para construtor que recebe linha e coluna


I don't think `current_path != "/"` will work on windows for identifying the root file system. I did some googling and these two jumped out http://stackoverflow.com/questions/9652043/identifying-the-file-system-root-with-node-js and https://www.npmjs.com/package/filepath as possible solutions.


Heroi duplicado = new Heroi(linha, coluna);


change `<>` to "`"` [here](https://github.com/LuxoftSDL/sdl_core/blob/50aa34d1a88ff2eb6ac2d0abe24f9275388f22cd/src/components/protocol_handler/test/include/protocol_handler/control_message_matcher.h#L35)


Hey! I'm missing this method very much! :)


_dir_  -->  _my-component_ (to be consistent with #13921)


Would it be better to have these info boxes aligned on the right of the chart and with a coloured icon as for the proposed design?


Initial commit


Commented code?


@VVeremjova , variable is used in code.


hellow word

i node js file


extrai um metodo para essa e as proximas 4 linhas: pegaTeclasAceitas()


Yes - I'm planning to use it in future PRs


esse método é pra ser privado? se sim,private nele.