As we're going to got lowercase rename MMAP => mmap_in_task
args => mmap_args
Don't use out params in all of your macros.
Use special gcc extension to return values from your macros. Use gcc anonymous functions. See example of their usage in criu/include/compiler.h  #define min(x, y) ({


Thanks @adityavarshney.  These edits were merged by @prtkgpt in [this commit](https://github.com/pluralsight/guides/commit/57e40056b53c02512fea7321854440832ce481a0).


This is to make sure that a manually started new backup will write into an empty log file. Maybe this is not the preferred behavior


Rename all your macros in this header file like:
MUNMAP => munmap_in_task


The OUTBUFFER variable is meant to keep the log in memory for the mail function.


Avoiding creation of "nil.txt" ....


This line is wrong, but using `FIND_PACKAGE` implies from cmake 3.5.0 (at least) using `add_library` that is not a `CTest` command but a `CMake` one.
We have to write our own Boost version detection.


reduce


Почему не "==="?


Playing chess includng quantum probabilities


good!


@gijzelaerr  I think this commit gives you what youneed? Check the commit message for script usage.


Ошибка выпадет только если не законектится к стору. Я думал, что если компонент является контейнером, то ему defaultProps не нужны, потому что он должен обязательно конектится к стор, а иначе выдавать ошибку, чтобы было понятно, что не законектился.


Пофиксил.


评论测试


This destroys the service success measurement model because it does not allow for custom services messages anymore..
and the rest mapper is not needed for a non-restful service


Я бы не стал объявлять листнеры внутри банка. Это лишняя зависимость. При потребности завести новый листнер тебе придется менять исходник Банка. Что не отвечает принципу сокрытия от изменений.


k


Pinning the xmlbuilder version was apparently very important - since 4.0, xmlbuilder drops support for the `#list` annotation, which this module heavily relies on.


публичные нестатичные свойства не приняты в джаве. их не подменишь при проксировании и тп


просмотрено


Push this file into the test folder inside the python folder


Such assumption is bad in my opinion... It is logically  possible that we can have different number of gyros and accels in the future. This would potentially break things when that happens. Thus, I say that this method shouldn't exist.


If you go ahead with that N64-style state of the player state hashing, you can have a console command to restart the map and the player state using a hash computed and displayed at the console at map start. So you don't have to deal with the save system at all.

For example, I die, load the save and realise it was 30 minutes ago in the previous map? I open the console and see the message when DR loaded the later map, it shows the hash of the player state at that point. I then do a "loadhash a7883e9d" and I am at the map I should be with the stuff I should have.

Also imagine updating DR while doing a megawad playthrough. Those sometimes take me a month :D
Or imagine playing a WIP version of a megawad posted on Doomworld, then the author does some minor fixes, your savegame is useless for the new version.


Странная запись, а просто -148.3f не сработает?


I switched to grid layour because I could not find a way to have a "cell" span over two columns in a grid (see the row on line 62 below)


You could just use guess_number = rand(1000)


Yeah but I was trying not to overuse Linq 😁


отлично


Loading a profile leads to a lot of signals firing. I did not want to cause unnecessary slowdowns.


There are 2 problems with this code:
1. `gets.chomp.to_i` is repeated thrice. Please try to DRY it.
2. You are still counting the same number guess multiple times as multiple attempts. All such attempts should be counted as one.


try again


I went ahead and rebased all the edits from @adityavarshney so these are now officially skipped.  The reason for this was to keep @adityavarshney branch up to date and make their next edits more easily merge-able for guides that are not already published.

However, @Kaizeras you can manually make the changes in your guide by copy/paste and saving your guide using the [hack.guides()](http://www.pluralsight.com/guides) interface.  You can also let me know which specific changes you want, if any, in this thread.  Me or @prtkgpt can manually make those changes for you as well.


Doesn't work here.

Tried pasting with a@de.de,b@de.de, c@de.de


В чем цель? Смахивает на оверинжиниринг. Либо я не понял чего-то


Hi Daniel,

I am trying ur FlowListview but it seems its does not support Horizontal scrolling.I am doing Windows 8.1 homescreen kind a design which will 2*10(Tiles will be dynamic)Tiles with horizontal scrolling using Gridview kinda control.Can it possible to achive that using ur flowlisview ?
![homescreen](https://cloud.githubusercontent.com/assets/15009775/14103519/35ced45e-f5be-11e5-8bbd-ed88dffa6fad.jpg)


Каждый раз когда будешь пулить, заходи в DevTools/Resources и чисти LocalStorage, иначе ошибки могут быть.


2 problems:
1. The code is not obvious to read. i.e. the logic is not easily understood when the code is read for the first time. It is preferred to have readable code, which explains the logic, as the code is read
2. Are you sure this prints exactly 20 leap years for every possible starting year?


наверно больше подходит
```
public class NotEnoughFundsException extends AccountException {
    public static final String NOT_ENOUGH_FUNDS_WITHDRAWAL = "...";
```


просмотрено


I confirm that it crashes time to time due to issue reported by @fretman92


What is this for?


I think this actually breaks on my machine. Just tried this and i get an error about QtQuick.Layouts 1.2


@gharlan könnte man hier besser mit `$this` arbeiten?


просмотрено

можно коммитить

git commit -a - приклеит изменения к прошлому коммиту. (только если еще не пушила)


Liekt wel ardig goed


Not sure, I don't think that this is needed. But I didn't write this application. Sample app is the same for all transaction providers, so I just copied it and adapted to use Narayana.


@fjandrad I think you forgot to push this data to the repo!


Rubyist's solution:
```
sum = 0
(1..10E6).each do |i|
  sum += ((-1)**(i+1))*(1.0/(2*i-1))
end
puts 4*sum
```


I have tried with a `try_run` and that fails with the same message. `Unknown CMake command "try_run".`


5 strings = 3 lost hours)))


Я думал смысл этого метода возвращать int


I'm a bit confused: I thought worf was supposed to be about quick navigation and such, but this seems like...well...I mean, I don't even know what it does, and I wouldn't want to run it by accident if I hit the wrong key.  Should this be in a different package?  :)


As I said in the previous patch, that function shouldn't exist. My suggestion is that we get both counts and loop over the maximum value. Then we only print meaningful information if the gyro/accel is healthy. Checking if the sensor is healthy rather than checking if the instance index is in range is better because we already cover the case when the sensor actually exists but can't give good values.

Another option is doing both checks and printing different characters for x,y,z values depending on the case (say '-' for out of range sensor instance and 'x' for unhealthy ones).


I would remove it then


gvbtruyjy


@chelmuth: please add or squash to staging


checked in online github


Наверно registerListener?


Я бы сделал и пустой конструктор. Может у меня еще нет листнеров. И конструктор
```
Bank(ClientRegistrationListener... listeners)
```

Почитай про vararg


Создай пустой лист сразу в конструкторе. Код чище будет


Its unstable lol


Doesn't seem to be released
https://rubygems.org/gems/http-exceptions/


##Commit


>

> `print("Hello World");`


А если обе ветки не сработали? Ты добавишь null. Место потенциального NPE


Oops

    >>> '8.0' >= 9.0
    True


Убирай вывод из доменных классов. Это делает их нереиспользуемыми. На серверах приложений вывод в консоль не так прост. Логи будут просто теряться


I know, but does it need to be full of this junk comments?


Consider adding the --checksum flag.


Если у клиента в будущем будет потомок и ты сравнишь клиента и потомка - тут будет false классы разные. Есть ли тут логическая проблема?


--delete is not a necessary option, because it only takes existing files into account for the link directory


не к чему этот метод. Неизменяемые объекты лучше. Вряд ли обращения будут менятьс я в течение жизни программы


Should this not also be integrated into the master branch?


Хорошо


Больше тестов


просмотрено


Yeah, cutting a release now.


@yihui


@edbond No, that was a mistake. Fixed in `0.1.40`. Thanks!


Some of the 8994 devices use the module and some use it inline so idk lol


this change just npm package babel-preset-react, but in the example code, preset react is still there.

I think it is confuse to newbee like me. without babel-preset-react, can I directly use this example config?

![image](https://cloud.githubusercontent.com/assets/1147375/14104095/d68510a4-f5d5-11e5-9aa5-949405568ef2.png)


已是最新，只是還沒把巢狀條件拆出來。


closed #25


I am having troubles with this "+1" on my project. My classname is "__CG__MyClassName" and after the str_replace the classname is "_CG__MyClassName" (one _ is missing). If I delete "+1", everything is OK.

Do you have any unit tests that confirm the +1 is needed ?

If not, I suggest to replace :

$className = str_replace('\\', '', substr($className, strlen($proxyNamespace) + 1));

by

$className = str_replace('\\', '', substr($className, strlen($proxyNamespace)));


du har missat på ?


Where did this come from? I have an El Capitan and an Yosemite here and both of them report "Darwin" (and not "darwin" ) from `uname`. This commit breaks the build on my Macs.


Ah directly in the schema, I see. Take a look at http://www.sqlite.org/lang_createtable.html:

> A default value may also be one of the special case-independent keywords CURRENT_TIME, CURRENT_DATE or CURRENT_TIMESTAMP.

and

> If the default value of a column is CURRENT_TIME, CURRENT_DATE or CURRENT_TIMESTAMP, then the value used in the new row is a text representation of the current UTC date and/or time.


[Here is a link](https://upload.wikimedia.org/wikipedia/en/3/39/Wakerlink.jpg).

Real world example:


@ahukkanen Let's suppose this example:

```php
$loc->setActiveContext('system');
include 'another-file.php';
$loc->revertActiveContext();
```

What happens if for some reason `another-file.php` changes the current context?
IMHO it could be safer to replace the `setActiveContext`/`revertActiveContext` with something like this:

```php
public function pushActiveContext($newContext)
{
    if ($this->activeContext !== null) {
        $this->activeContextQueue[] = $this->activeContext;
    }
    $this->setActiveContext($newContext);
}

public function setActiveContext($context)
{
    $this->activeContext = $context;
    if (!isset($this->contextLocales[$context])) {
        $this->setContextLocale($context, static::BASE_LOCALE);
    }
}

public function popActiveContext()
{
    if (!empty($this->activeContextQueue)) {
        $this->activeContext = array_pop($this->activeContextQueue);
    }
}
```


This is sometimes handled by keeping a soft link to the 'current' (last) backup:

```
rm ${BACKUPDIR}/current
ln -s ${BACKUPDIR}/${DATE} ${BACKUPDIR}/current
```
and using this as the link destination:
```
--link-dest=${BACKUPDIR}/current
```


Very cool, good idea!


为什么我修改不了read.md文件


@chelmuth: or - instead use 2207baae9518b6fa4a16378795d6404cbb14b331


You don't have to use it if you don't want to.


тут помогает не юнит-тестирование, а интеграционное. Почитай про Mock-objects. Суть в том что ты создаешь другой класс банка который внутри фиксирует тестовые проверки. Его потом опрашиваешь. Либо наоборот - в реальный банк добовляешь поддельный листенер, кототрый палит вызывали ли его или нет.


просмотрено


INSTALLATION FAILS
update package.json dependency
"grunt-mocha": "~0.4.15"


Or  npm install grunt-mocha --save-dev before npm install


!client.remoteAddress basically says: not client.remoteAddress = defined  if this was the issue then I'd like to know why that was not working.


Полет фантазии пошел) Это хорошо. Можно еще просто использовать regex, Pattern/Matcher


@trangng sorry for not telling you before, but when you find a word surrounded by underscore, such as this `__totalPrice__`, it means that it is going to be replaced by a value. If you remove it then we lose that info (in this case the total price won't be displayed).
Please can you review all your translations and make sure we don't lose these values?
Also, it would be good if you create a pull request for these changes (only if it's not a big overhead for you, Github provides an easy way to do it), so that I can review it before merging it in the master branch.


I made it 512-bit for maximum security.


Could someone move this to the latest version?


The image added for the current poll in home page : https://github.com/StemboltHQ/keg_picker/issues/51
based on the merged  changes


хорошо. Но лучше проверки в начале. Чтоб объект вообще не создавался


kanske lägga till en isWildcardChannel() funktion


Prefix is correct, not prepend.


yeah, that's right


"Postpend" is not a word.


It is unclear why it is done. It will be nice to add/change comment in the code, or at least add explanation to the commit message (less preferable, since messages are harder to find starting from code).


If I can make it a single line, I will.


[R/create_ad.R:65:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_ad.R#L65) *style:* **Variable and function names should be all lowercase.**
```r
createAd <- function(body){
^~~~~~~~
```
[R/create_ad.R:66:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_ad.R#L66) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(class(body) != "list"){
    ^
```
[R/create_ad.R:69:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_ad.R#L69) *style:* **Variable and function names should be all lowercase.**
```r
  result <- createObject(body = body, object = "ad")
            ^~~~~~~~~~~~
```
[R/create_ad.R:69:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_ad.R#L69) *warning:* **no visible global function definition for ‘createObject’**
```r
  result <- createObject(body = body, object = "ad")
            ^~~~~~~~~~~~
```
[R/create_adset.R:119:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_adset.R#L119) *style:* **Variable and function names should be all lowercase.**
```r
createAdset <- function(body){
^~~~~~~~~~~
```
[R/create_adset.R:120:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_adset.R#L120) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(class(body) != "list"){
    ^
```
[R/create_adset.R:123:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_adset.R#L123) *style:* **Variable and function names should be all lowercase.**
```r
  result <- createObject(body = body, object = "adset")
            ^~~~~~~~~~~~
```
[R/create_adset.R:123:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_adset.R#L123) *warning:* **no visible global function definition for ‘createObject’**
```r
  result <- createObject(body = body, object = "adset")
            ^~~~~~~~~~~~
```
[R/create_audience.R:70:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_audience.R#L70) *style:* **Variable and function names should be all lowercase.**
```r
createAudience <- function(body){
^~~~~~~~~~~~~~
```
[R/create_audience.R:71:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_audience.R#L71) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(class(body) != "list"){
    ^
```
[R/create_audience.R:74:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_audience.R#L74) *style:* **Variable and function names should be all lowercase.**
```r
  result <- createObject(body = body, object = "audience")
            ^~~~~~~~~~~~
```
[R/create_audience.R:74:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_audience.R#L74) *warning:* **no visible global function definition for ‘createObject’**
```r
  result <- createObject(body = body, object = "audience")
            ^~~~~~~~~~~~
```
[R/create_campaign.R:54:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_campaign.R#L54) *style:* **Variable and function names should be all lowercase.**
```r
createCampaign <- function(body){
^~~~~~~~~~~~~~
```
[R/create_campaign.R:55:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_campaign.R#L55) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(class(body) != "list"){
    ^
```
[R/create_campaign.R:58:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_campaign.R#L58) *style:* **Variable and function names should be all lowercase.**
```r
  result <- createObject(body = body, object = "campaign")
            ^~~~~~~~~~~~
```
[R/create_campaign.R:58:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_campaign.R#L58) *warning:* **no visible global function definition for ‘createObject’**
```r
  result <- createObject(body = body, object = "campaign")
            ^~~~~~~~~~~~
```
[R/create_image.R:22:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_image.R#L22) *style:* **Variable and function names should be all lowercase.**
```r
createImage <- function(file){
^~~~~~~~~~~
```
[R/create_image.R:26:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_image.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
  result <- createObject(body = body, object = "image")
            ^~~~~~~~~~~~
```
[R/create_image.R:26:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_image.R#L26) *warning:* **no visible global function definition for ‘createObject’**
```r
  result <- createObject(body = body, object = "image")
            ^~~~~~~~~~~~
```
[R/create_object.R:28:6:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_object.R#L28) *style:* **Commented code should be removed.**
```r
#' # new_camp <- createCampaign(body = camp)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_object.R:51:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_object.R#L51) *style:* **Variable and function names should be all lowercase.**
```r
createObject <- function(object, body){
^~~~~~~~~~~~
```
[R/create_object.R:52:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_object.R#L52) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(body)){
    ^
```
[R/create_object.R:55:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_object.R#L55) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(class(body) != "list"){
    ^
```
[R/create_object.R:58:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_object.R#L58) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/create_object.R:58:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_object.R#L58) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/create_object.R:59:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_object.R#L59) *style:* **Variable and function names should be all lowercase.**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/create_object.R:59:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_object.R#L59) *warning:* **no visible global function definition for ‘checkObjects’**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/create_object.R:66:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_object.R#L66) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/create_object.R:66:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/create_object.R#L66) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/delete_ad.R:42:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_ad.R#L42) *style:* **Variable and function names should be all lowercase.**
```r
deleteAd <- function(ad.id) {
^~~~~~~~
```
[R/delete_ad.R:43:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_ad.R#L43) *style:* **Variable and function names should be all lowercase.**
```r
  result <- deleteObject(object = "ad", id = ad.id)
            ^~~~~~~~~~~~
```
[R/delete_ad.R:43:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_ad.R#L43) *warning:* **no visible global function definition for ‘deleteObject’**
```r
  result <- deleteObject(object = "ad", id = ad.id)
            ^~~~~~~~~~~~
```
[R/delete_adset.R:40:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_adset.R#L40) *style:* **Variable and function names should be all lowercase.**
```r
deleteAdset <- function(adset.id) {
^~~~~~~~~~~
```
[R/delete_adset.R:41:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_adset.R#L41) *style:* **Variable and function names should be all lowercase.**
```r
  result <- deleteObject(object = "adset", id = adset.id)
            ^~~~~~~~~~~~
```
[R/delete_adset.R:41:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_adset.R#L41) *warning:* **no visible global function definition for ‘deleteObject’**
```r
  result <- deleteObject(object = "adset", id = adset.id)
            ^~~~~~~~~~~~
```
[R/delete_audience.R:25:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_audience.R#L25) *style:* **Variable and function names should be all lowercase.**
```r
deleteAudience <- function(audience.id) {
^~~~~~~~~~~~~~
```
[R/delete_audience.R:26:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_audience.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
  result <- deleteObject(object = "audience", id = audience.id)
            ^~~~~~~~~~~~
```
[R/delete_audience.R:26:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_audience.R#L26) *warning:* **no visible global function definition for ‘deleteObject’**
```r
  result <- deleteObject(object = "audience", id = audience.id)
            ^~~~~~~~~~~~
```
[R/delete_campaign.R:34:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_campaign.R#L34) *style:* **Variable and function names should be all lowercase.**
```r
deleteCampaign <- function(campaign.id) {
^~~~~~~~~~~~~~
```
[R/delete_campaign.R:35:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_campaign.R#L35) *style:* **Variable and function names should be all lowercase.**
```r
  result <- deleteObject(object = "campaign", id = campaign.id)
            ^~~~~~~~~~~~
```
[R/delete_campaign.R:35:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_campaign.R#L35) *warning:* **no visible global function definition for ‘deleteObject’**
```r
  result <- deleteObject(object = "campaign", id = campaign.id)
            ^~~~~~~~~~~~
```
[R/delete_object.R:37:6:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_object.R#L37) *style:* **Commented code should be removed.**
```r
#' # deleteAd(ad.id = sample(ads$id, 1))
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/delete_object.R:47:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_object.R#L47) *style:* **Variable and function names should be all lowercase.**
```r
deleteObject <- function(object, id) {
^~~~~~~~~~~~
```
[R/delete_object.R:48:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_object.R#L48) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(id)){
    ^
```
[R/delete_object.R:51:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_object.R#L51) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(object)){
    ^
```
[R/delete_object.R:54:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_object.R#L54) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/delete_object.R:54:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_object.R#L54) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/delete_object.R:55:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_object.R#L55) *style:* **Variable and function names should be all lowercase.**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/delete_object.R:55:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_object.R#L55) *warning:* **no visible global function definition for ‘checkObjects’**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/delete_object.R:62:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_object.R#L62) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/delete_object.R:62:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/delete_object.R#L62) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/dict_behaviour.R:26:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_behaviour.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
dictBehaviour <- function(){
^~~~~~~~~~~~~
```
[R/dict_behaviour.R:27:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_behaviour.R#L27) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_behaviour.R:27:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_behaviour.R#L27) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_behaviour.R:29:51:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_behaviour.R#L29) *style:* **Put spaces around all infix operators.**
```r
                file.path("dict", "behavior", fsep="/"))
                                                 ~^~
```
[R/dict_behaviour.R:35:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_behaviour.R#L35) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_behaviour.R:35:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_behaviour.R#L35) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_city.R:24:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_city.R#L24) *style:* **Variable and function names should be all lowercase.**
```r
dictCity <- function(state.code){
^~~~~~~~
```
[R/dict_city.R:25:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_city.R#L25) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(state.code)){
    ^
```
[R/dict_city.R:28:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_city.R#L28) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_city.R:28:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_city.R#L28) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_city.R:37:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_city.R#L37) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/dict_city.R:37:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_city.R#L37) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/dict_city.R:38:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_city.R#L38) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_city.R:38:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_city.R#L38) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_country.R:26:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_country.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
dictCountry <- function(){
^~~~~~~~~~~
```
[R/dict_country.R:27:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_country.R#L27) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_country.R:27:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_country.R#L27) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_country.R:35:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_country.R#L35) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_country.R:35:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_country.R#L35) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_device.R:26:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_device.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
dictDevice <- function(){
^~~~~~~~~~
```
[R/dict_device.R:27:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_device.R#L27) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_device.R:27:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_device.R#L27) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_device.R:35:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_device.R#L35) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_device.R:35:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_device.R#L35) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_interest.R:27:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_interest.R#L27) *style:* **Variable and function names should be all lowercase.**
```r
dictInterest <- function(){
^~~~~~~~~~~~
```
[R/dict_interest.R:28:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_interest.R#L28) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_interest.R:28:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_interest.R#L28) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_interest.R:36:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_interest.R#L36) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_interest.R:36:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_interest.R#L36) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_language.R:29:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_language.R#L29) *style:* **Variable and function names should be all lowercase.**
```r
dictLanguage <- function(){
^~~~~~~~~~~~
```
[R/dict_language.R:30:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_language.R#L30) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_language.R:30:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_language.R#L30) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_language.R:38:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_language.R#L38) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_language.R:38:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_language.R#L38) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_os.R:26:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_os.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
dictOS <- function(){
^~~~~~
```
[R/dict_os.R:27:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_os.R#L27) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_os.R:27:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_os.R#L27) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_os.R:35:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_os.R#L35) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_os.R:35:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_os.R#L35) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_state.R:37:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_state.R#L37) *style:* **Variable and function names should be all lowercase.**
```r
dictState <- function(country.code){
^~~~~~~~~
```
[R/dict_state.R:38:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_state.R#L38) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(country.code)){
    ^
```
[R/dict_state.R:41:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_state.R#L41) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_state.R:41:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_state.R#L41) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_state.R:50:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_state.R#L50) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/dict_state.R:50:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_state.R#L50) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/dict_state.R:51:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_state.R#L51) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_state.R:51:59:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/dict_state.R#L51) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/get_report.R:60:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/get_report.R#L60) *style:* **Variable and function names should be all lowercase.**
```r
getReport <- function(column = c("impression", "click"),
^~~~~~~~~
```
[R/get_report.R:64:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/get_report.R#L64) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/get_report.R:64:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/get_report.R#L64) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/get_report.R:71:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/get_report.R#L71) *style:* **Variable and function names should be all lowercase.**
```r
  reportInput(body)
  ^~~~~~~~~~~
```
[R/get_report.R:71:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/get_report.R#L71) *warning:* **no visible global function definition for ‘reportInput’**
```r
  reportInput(body)
  ^~~~~~~~~~~
```
[R/get_report.R:79:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/get_report.R#L79) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/get_report.R:79:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/get_report.R#L79) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/get_report.R:80:64:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/get_report.R#L80) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data$data, parseJSON))
                                                               ^~~~~~~~~
```
[R/get_report.R:80:64:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/get_report.R#L80) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data$data, parseJSON))
                                                               ^~~~~~~~~
```
[R/get_report.R:82:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/get_report.R#L82) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(grep("^datetime$", names(dat)))){
    ^
```
[R/helpers.R:54:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L54) *style:* **Variable and function names should be all lowercase.**
```r
budgetType <- function(x){
^~~~~~~~~~
```
[R/helpers.R:57:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L57) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!x %in% valid){
    ^
```
[R/helpers.R:69:8:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L69) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:75:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L75) *style:* **Variable and function names should be all lowercase.**
```r
appType <- function(x){
^~~~~~~
```
[R/helpers.R:78:8:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L78) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:84:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L84) *style:* **Variable and function names should be all lowercase.**
```r
webType <- function(x){
^~~~~~~
```
[R/helpers.R:87:8:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L87) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:93:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L93) *style:* **Variable and function names should be all lowercase.**
```r
landingPage <- function(x){
^~~~~~~~~~~
```
[R/helpers.R:96:8:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L96) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:102:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L102) *style:* **Variable and function names should be all lowercase.**
```r
bidType <- function(x){
^~~~~~~
```
[R/helpers.R:105:8:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L105) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:111:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L111) *style:* **Variable and function names should be all lowercase.**
```r
appShowType <- function(x){
^~~~~~~~~~~
```
[R/helpers.R:113:51:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L113) *style:* **Commas should always have a space after.**
```r
  valid <- structure(c("newsfeed", "mininewsfeed","videoad", "applockerad"),
                                                  ^
```
[R/helpers.R:115:8:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L115) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:121:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L121) *style:* **Variable and function names should be all lowercase.**
```r
deliveryType <- function(x){
^~~~~~~~~~~~
```
[R/helpers.R:124:8:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L124) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:133:8:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L133) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:142:8:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L142) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:148:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L148) *style:* **Variable and function names should be all lowercase.**
```r
netType <- function(x){
^~~~~~~
```
[R/helpers.R:152:8:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L152) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:158:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L158) *style:* **Variable and function names should be all lowercase.**
```r
buttonText <- function(x){
^~~~~~~~~~
```
[R/helpers.R:162:8:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L162) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:168:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L168) *style:* **Variable and function names should be all lowercase.**
```r
switchIt <- function(x){
^~~~~~~~
```
[R/helpers.R:171:8:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L171) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:177:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L177) *style:* **Variable and function names should be all lowercase.**
```r
audienceCreation <- function(x){
^~~~~~~~~~~~~~~~
```
[R/helpers.R:181:8:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/helpers.R#L181) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/list_ads.R:21:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_ads.R#L21) *style:* **Variable and function names should be all lowercase.**
```r
listAds <- function(n = 50){
^~~~~~~
```
[R/list_ads.R:22:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_ads.R#L22) *style:* **Variable and function names should be all lowercase.**
```r
  res <- listObjects(object = "ad", n = n)
         ^~~~~~~~~~~
```
[R/list_ads.R:22:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_ads.R#L22) *warning:* **no visible global function definition for ‘listObjects’**
```r
  res <- listObjects(object = "ad", n = n)
         ^~~~~~~~~~~
```
[R/list_adsets.R:21:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_adsets.R#L21) *style:* **Variable and function names should be all lowercase.**
```r
listAdsets <- function(n = 50){
^~~~~~~~~~
```
[R/list_adsets.R:22:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_adsets.R#L22) *style:* **Variable and function names should be all lowercase.**
```r
  res <- listObjects(object = "adset", n = n)
         ^~~~~~~~~~~
```
[R/list_adsets.R:22:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_adsets.R#L22) *warning:* **no visible global function definition for ‘listObjects’**
```r
  res <- listObjects(object = "adset", n = n)
         ^~~~~~~~~~~
```
[R/list_audiences.R:22:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_audiences.R#L22) *style:* **Variable and function names should be all lowercase.**
```r
listAudiences <- function(n = 50){
^~~~~~~~~~~~~
```
[R/list_audiences.R:23:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_audiences.R#L23) *style:* **Variable and function names should be all lowercase.**
```r
  res <- listObjects(object = "audience", n = n)
         ^~~~~~~~~~~
```
[R/list_audiences.R:23:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_audiences.R#L23) *warning:* **no visible global function definition for ‘listObjects’**
```r
  res <- listObjects(object = "audience", n = n)
         ^~~~~~~~~~~
```
[R/list_campaigns.R:21:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_campaigns.R#L21) *style:* **Variable and function names should be all lowercase.**
```r
listCampaigns <- function(n = 50){
^~~~~~~~~~~~~
```
[R/list_campaigns.R:22:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_campaigns.R#L22) *style:* **Variable and function names should be all lowercase.**
```r
  res <- listObjects(object = "campaign", n = n)
         ^~~~~~~~~~~
```
[R/list_campaigns.R:22:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_campaigns.R#L22) *warning:* **no visible global function definition for ‘listObjects’**
```r
  res <- listObjects(object = "campaign", n = n)
         ^~~~~~~~~~~
```
[R/list_images.R:21:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_images.R#L21) *style:* **Variable and function names should be all lowercase.**
```r
listImages <- function(n = 50){
^~~~~~~~~~
```
[R/list_images.R:22:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_images.R#L22) *style:* **Variable and function names should be all lowercase.**
```r
  res <- listObjects(object = "image", n = n)
         ^~~~~~~~~~~
```
[R/list_images.R:22:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_images.R#L22) *warning:* **no visible global function definition for ‘listObjects’**
```r
  res <- listObjects(object = "image", n = n)
         ^~~~~~~~~~~
```
[R/list_object.R:44:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_object.R#L44) *style:* **Variable and function names should be all lowercase.**
```r
listObjects <- function(object, n = 50){
^~~~~~~~~~~
```
[R/list_object.R:46:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_object.R#L46) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(object)) {
    ^
```
[R/list_object.R:48:12:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_object.R#L48) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  } else if(length(object) > 1){
           ^
```
[R/list_object.R:51:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_object.R#L51) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/list_object.R:51:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_object.R#L51) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/list_object.R:52:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_object.R#L52) *style:* **Variable and function names should be all lowercase.**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/list_object.R:52:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_object.R#L52) *warning:* **no visible global function definition for ‘checkObjects’**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/list_object.R:58:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_object.R#L58) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/list_object.R:58:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_object.R#L58) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/list_object.R:59:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_object.R#L59) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(content$data)) {
    ^
```
[R/list_object.R:60:66:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_object.R#L60) *style:* **Variable and function names should be all lowercase.**
```r
    dat <- do.call(plyr::"rbind.fill", lapply(content$data$data, parseJSON))
                                                                 ^~~~~~~~~
```
[R/list_object.R:60:66:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_object.R#L60) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
    dat <- do.call(plyr::"rbind.fill", lapply(content$data$data, parseJSON))
                                                                 ^~~~~~~~~
```
[R/list_object.R:61:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_object.R#L61) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    while(nrow(dat) < n && length(content$data$next_page_url)) {
         ^
```
[R/list_object.R:68:53:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/list_object.R#L68) *style:* **Variable and function names should be all lowercase.**
```r
                          lapply(content$data$data, parseJSON))
                                                    ^~~~~~~~~
```
[R/map.R:66:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/map.R#L66) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(campaigns)){
    ^
```
[R/map.R:69:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/map.R#L69) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(adsets)){
    ^
```
[R/map.R:72:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/map.R#L72) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(ads)){
    ^
```
[R/map.R:75:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/map.R#L75) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(audiences)){
    ^
```
[R/orion_auth.R:47:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/orion_auth.R#L47) *style:* **Variable and function names should be all lowercase.**
```r
orionOAuth <- function (client.id, client.secret,
^~~~~~~~~~
```
[R/orion_auth.R:50:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/orion_auth.R#L50) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(client.id)){
    ^
```
[R/orion_auth.R:65:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/orion_auth.R#L65) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(return)
  ^~~~~~~~~~
```
[R/orion_auth.R:65:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/orion_auth.R#L65) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(return)
  ^~~~~~~~~~
```
[R/orion_auth.R:66:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/orion_auth.R#L66) *style:* **Variable and function names should be all lowercase.**
```r
  constructCred(return, pars = list(client.id = client.id,
  ^~~~~~~~~~~~~
```
[R/orion_auth.R:69:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/orion_auth.R#L69) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(save == TRUE){
    ^
```
[R/orion_auth.R:70:44:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/orion_auth.R#L70) *style:* **Put spaces around all infix operators.**
```r
    credentials <- get("credentials", envir=cred_env)
                                          ~^~
```
[R/orion_auth.R:70:45:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/orion_auth.R#L70) *warning:* **no visible binding for global variable ‘cred_env’**
```r
    credentials <- get("credentials", envir=cred_env)
                                            ^~~~~~~~
```
[R/orion_auth.R:72:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/orion_auth.R#L72) *style:* **lines should not be more than 80 characters.**
```r
    credentials$client.secret <- charToRaw(as.character(credentials$client.secret))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/print.R:2:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/print.R#L2) *style:* **Variable and function names should be all lowercase.**
```r
print.orionToken <- function(x, ...) {
^~~~~~~~~~~~~~~~
```
[R/show_ad.R:25:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_ad.R#L25) *style:* **Variable and function names should be all lowercase.**
```r
showAd <- function(ad.id){
^~~~~~
```
[R/show_ad.R:26:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_ad.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
  res <- showObject(object = "ad", id = ad.id)
         ^~~~~~~~~~
```
[R/show_ad.R:26:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_ad.R#L26) *warning:* **no visible global function definition for ‘showObject’**
```r
  res <- showObject(object = "ad", id = ad.id)
         ^~~~~~~~~~
```
[R/show_adset_audience.R:27:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_adset_audience.R#L27) *style:* **Variable and function names should be all lowercase.**
```r
showAdsetAudience <- function(adset.id){
^~~~~~~~~~~~~~~~~
```
[R/show_adset_audience.R:28:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_adset_audience.R#L28) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(adset.id)){
    ^
```
[R/show_adset_audience.R:31:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_adset_audience.R#L31) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/show_adset_audience.R:31:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_adset_audience.R#L31) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/show_adset_audience.R:40:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_adset_audience.R#L40) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/show_adset_audience.R:40:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_adset_audience.R#L40) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/show_adset.R:25:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_adset.R#L25) *style:* **Variable and function names should be all lowercase.**
```r
showAdset <- function(adset.id){
^~~~~~~~~
```
[R/show_adset.R:26:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_adset.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
  res <- showObject(object = "adset", id = adset.id)
         ^~~~~~~~~~
```
[R/show_adset.R:26:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_adset.R#L26) *warning:* **no visible global function definition for ‘showObject’**
```r
  res <- showObject(object = "adset", id = adset.id)
         ^~~~~~~~~~
```
[R/show_audience.R:25:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_audience.R#L25) *style:* **Variable and function names should be all lowercase.**
```r
showAudience <- function(audience.id){
^~~~~~~~~~~~
```
[R/show_audience.R:26:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_audience.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
  res <- showObject(object = "audience", id = audience.id)
         ^~~~~~~~~~
```
[R/show_audience.R:26:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_audience.R#L26) *warning:* **no visible global function definition for ‘showObject’**
```r
  res <- showObject(object = "audience", id = audience.id)
         ^~~~~~~~~~
```
[R/show_campaign.R:25:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_campaign.R#L25) *style:* **Variable and function names should be all lowercase.**
```r
showCampaign <- function(campaign.id){
^~~~~~~~~~~~
```
[R/show_campaign.R:26:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_campaign.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
  res <- showObject(object = "campaign", id = campaign.id)
         ^~~~~~~~~~
```
[R/show_campaign.R:26:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_campaign.R#L26) *warning:* **no visible global function definition for ‘showObject’**
```r
  res <- showObject(object = "campaign", id = campaign.id)
         ^~~~~~~~~~
```
[R/show_object.R:51:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_object.R#L51) *style:* **Variable and function names should be all lowercase.**
```r
showObject <- function(object, id){
^~~~~~~~~~
```
[R/show_object.R:52:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_object.R#L52) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(id)){
    ^
```
[R/show_object.R:55:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_object.R#L55) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(object)){
    ^
```
[R/show_object.R:58:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_object.R#L58) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/show_object.R:58:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_object.R#L58) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/show_object.R:59:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_object.R#L59) *style:* **Variable and function names should be all lowercase.**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/show_object.R:59:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_object.R#L59) *warning:* **no visible global function definition for ‘checkObjects’**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/show_object.R:67:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_object.R#L67) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/show_object.R:67:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/show_object.R#L67) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/update_ad.R:57:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_ad.R#L57) *style:* **Variable and function names should be all lowercase.**
```r
updateAd <- function(ad.id, body){
^~~~~~~~
```
[R/update_ad.R:58:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_ad.R#L58) *style:* **Variable and function names should be all lowercase.**
```r
  res <- updateObject(object = "ad", body = body, id = ad.id)
         ^~~~~~~~~~~~
```
[R/update_ad.R:58:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_ad.R#L58) *warning:* **no visible global function definition for ‘updateObject’**
```r
  res <- updateObject(object = "ad", body = body, id = ad.id)
         ^~~~~~~~~~~~
```
[R/update_adset.R:102:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_adset.R#L102) *style:* **Variable and function names should be all lowercase.**
```r
updateAdset <- function(adset.id, body){
^~~~~~~~~~~
```
[R/update_adset.R:103:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_adset.R#L103) *style:* **Variable and function names should be all lowercase.**
```r
  res <- updateObject(object = "adset", body = body, id = adset.id)
         ^~~~~~~~~~~~
```
[R/update_adset.R:103:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_adset.R#L103) *warning:* **no visible global function definition for ‘updateObject’**
```r
  res <- updateObject(object = "adset", body = body, id = adset.id)
         ^~~~~~~~~~~~
```
[R/update_audience.R:65:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_audience.R#L65) *style:* **Variable and function names should be all lowercase.**
```r
updateAudience <- function(audience.id, body){
^~~~~~~~~~~~~~
```
[R/update_audience.R:66:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_audience.R#L66) *style:* **Variable and function names should be all lowercase.**
```r
  res <- updateObject(object = "audience", body = body, id = audience.id)
         ^~~~~~~~~~~~
```
[R/update_audience.R:66:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_audience.R#L66) *warning:* **no visible global function definition for ‘updateObject’**
```r
  res <- updateObject(object = "audience", body = body, id = audience.id)
         ^~~~~~~~~~~~
```
[R/update_campaign.R:46:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_campaign.R#L46) *style:* **Variable and function names should be all lowercase.**
```r
updateCampaign <- function(campaign.id, body){
^~~~~~~~~~~~~~
```
[R/update_campaign.R:47:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_campaign.R#L47) *style:* **Variable and function names should be all lowercase.**
```r
  res <- updateObject(object = "campaign", body = body, id = campaign.id)
         ^~~~~~~~~~~~
```
[R/update_campaign.R:47:10:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_campaign.R#L47) *warning:* **no visible global function definition for ‘updateObject’**
```r
  res <- updateObject(object = "campaign", body = body, id = campaign.id)
         ^~~~~~~~~~~~
```
[R/update_object.R:26:6:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_object.R#L26) *style:* **Commented code should be removed.**
```r
#' # update <- updateAdset(adset.id = adsets$id[1], body = settings)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/update_object.R:50:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_object.R#L50) *style:* **Variable and function names should be all lowercase.**
```r
updateObject <- function(object, body, id){
^~~~~~~~~~~~
```
[R/update_object.R:51:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_object.R#L51) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(body)){
    ^
```
[R/update_object.R:54:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_object.R#L54) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(class(body) != "list"){
    ^
```
[R/update_object.R:57:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_object.R#L57) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/update_object.R:57:11:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_object.R#L57) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/update_object.R:58:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_object.R#L58) *style:* **Variable and function names should be all lowercase.**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/update_object.R:58:13:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_object.R#L58) *warning:* **no visible global function definition for ‘checkObjects’**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/update_object.R:67:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_object.R#L67) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/update_object.R:67:3:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/update_object.R#L67) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/utils.R:3:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L3) *style:* **Variable and function names should be all lowercase.**
```r
constructCred <- function(json, pars) {
^~~~~~~~~~~~~
```
[R/utils.R:14:46:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L14) *warning:* **no visible binding for global variable ‘cred_env’**
```r
  assign("credentials", credentials, envir = cred_env)
                                             ^~~~~~~~
```
[R/utils.R:17:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L17) *style:* **Variable and function names should be all lowercase.**
```r
testReturn <- function(content) {
^~~~~~~~~~
```
[R/utils.R:19:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L19) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(content$status != 200 && content$status == 422){
    ^
```
[R/utils.R:28:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L28) *style:* **Variable and function names should be all lowercase.**
```r
orionToken <- function() {
^~~~~~~~~~
```
[R/utils.R:29:51:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L29) *style:* **Put spaces around all infix operators.**
```r
  credentials <- tryCatch(get("credentials", envir=cred_env),
                                                 ~^~
```
[R/utils.R:31:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L31) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(is(credentials, "error") && file.exists(".orionToken")){
    ^
```
[R/utils.R:35:48:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L35) *warning:* **no visible binding for global variable ‘cred_env’**
```r
    assign("credentials", credentials, envir = cred_env)
                                               ^~~~~~~~
```
[R/utils.R:39:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L39) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(credentials$expires_in_date <= Sys.time()) {
    ^
```
[R/utils.R:40:20:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L40) *style:* **Variable and function names should be all lowercase.**
```r
    credentials <- orionOAuth(credentials$client.id,
                   ^~~~~~~~~~
```
[R/utils.R:46:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L46) *style:* **Variable and function names should be all lowercase.**
```r
checkObjects <- function(objects){
^~~~~~~~~~~~
```
[R/utils.R:49:7:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L49) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(x %in% valid == FALSE){
      ^
```
[R/utils.R:57:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L57) *style:* **Variable and function names should be all lowercase.**
```r
parseJSON <- function(data){
^~~~~~~~~
```
[R/utils.R:63:1:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L63) *style:* **Variable and function names should be all lowercase.**
```r
reportInput <- function(body){
^~~~~~~~~~~
```
[R/utils.R:66:55:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L66) *style:* **Commas should always have a space after.**
```r
  groups <- c("datetime", "age", "gender", "location","brand", "ad", "adset",
                                                      ^
```
[R/utils.R:69:7:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L69) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!x %in% col) {
      ^
```
[R/utils.R:75:7:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L75) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!x %in% groups) {
      ^
```
[R/utils.R:80:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L80) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(body$groupby) == 1) {
    ^
```
[R/utils.R:83:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L83) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(body$column) == 1) {
    ^
```
[R/utils.R:89:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L89) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(x) > 1){
    ^
```
[R/utils.R:92:5:](https://github.com/JohnCoene/oRion/blob/921f984416339503caae7d51f16b72a0746c314d/R/utils.R#L92) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!x %in% valid){
    ^
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 20179](https://teamcity.mesosphere.io/viewLog.html?buildId=183569&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:49


Ok, I have to look a little bit more into it.


What's the intuition for this change? Why do we want to unconditionally cache the method ref offset?


But where is _wildcard defined?


It is worth noting that this commit does not include the planned addition of a getClip(ClipShape) method in the Graphics class.  This will be a future change.


I added 20000000 as a test int[] to see how long it'd take. One order of magnitude more and it ran out of heap space. I left the generic commented out, for now, because I need to implement int[] to Integer[] conversion.

I wanted to test speed to see if using Integer objects vs int primitives mattered too much.

It'd also be nice to compare this to something like an ArrayList (in this case our class might be mostly just a wrapper class).

Depending on Team1 code is going to be super simple as I basically wrote everything we need from them already...


Is this really respected? Also nitpick: other options use underscore instead of hypen


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 20180](https://teamcity.mesosphere.io/viewLog.html?buildId=183570&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 267 Build time: 00:09:54


I'm pretty sure the latest auto patch version of NodeBB (released yesterday) ought to have the latest composer version defined in package.json, I can't confirm ATM, I'm on mobile

If it's not, feel free to open an issue on the main issue tracker, it would be an oversight on our end as opposed to incompatibility with the package


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 20181](https://teamcity.mesosphere.io/viewLog.html?buildId=183571&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 267 Build time: 00:10:49


Forgot to mention another change I made (the original reason for the PR to begin with) which was to correct the issue of a goal having been met. Before the code change, that situation would result in no progress bar. Also had to make a change to be sensitive to the moth when the goal was created.


I just pushed them. I got distracted by work - sorry!


AoE Attack Ratio ▲2


Actually, your master is good:
https://github.com/ophthal/openEMR_2/blob/master/sql/4_2_1-to-4_3_1_upgrade.sql

It's just that this branch doesn't have the changes(which is fine). Copying the 4_2_1-to-4_3_1_upgrade.sql file as you have done should work fine when you do the rebase.

Since the upgrade.sql files have been switched around, to avoid a bunch of merge conflicts, recommend the following(rather than rebase from master we are going to use cherry-pick).
1. start a new called branch issue_subtype_6 (based on issue_subtype_5) and rebase your 2 commits into one.
2. do a 'git log' and copy the long sha1 number of the commit
3. then 'git checkout master'
4. 'git fetch upstream'
5. 'git pull upstream master'
6. 'git checkout -b issue_subtype_7'
7. 'git cherry-pick <paste the sha1 number that you copied above here>'
(guessing there may be a couple merge issues, but should be simple to fix)


Lightning Property Attack ▲30


Defense ▲6


Get a little.


added to readme


oupost -> outpost


kingdom's army -> Royal Army


@CptChaos You're absolutely right! We decided it would be better to track the latest Laravel releases.


gracias! :-) -- FAS acct martin.langhoff (o martin@laptop.org) --

Como referencia, puedes ver si quieres que soy maintainer/comaintainer en unos cuantos paquetes. Me acaban de dar comaintainership en pybox2d y puse un update a 2.3.1 para F25 y voy a aplicarlo mas tarde para F24 también.


It just put the first param at the end of the test.


I think this is good idea!


Just for completeness...this is not the full revert of @a69de25fe6a2a178a1318d805dbde1353c3af5ea. The includes were left behind.


Does the list() do anything here?

Is the perf difference between map() and 'for' for two elements really worth the code smell ?


Thanks for the HarvestHand/Scrounge implementation halljared. I also was able to duplicate the issue with the deck editor with it, but the cards themselves are programmed correctly from my testing. I'll create a separate issue for that problem.


Show sample code directly here, and put a brief comment (if necessary) next to the code.


Hi @dwieker ,

Good job finishing up the python exercises! Special brownie points :cake: (I know these are not brownies) go to you for completing the optional Markov chain exercise.

You did a good job explaining lists vs sets. I especially liked that you explicitly pointed out the difference between O(1) vs. O(N) on look up time. Bravo :clap: !  I also like how you explained lambda functions and list comprehensions and the examples you gave are great. One thing you said was "Sets are slow to iterate over", I'm not sure I understand that. slow to iterate over compared to lists? Why do you think that? Could you elaborate on that? Thank you!

One thing you said about list vs. tuples is that _'Lists contain mutable elements; tuples contain immutable elements.'_  This statement is not accurate and could be just wrong. Lists *THEMSELVES* are mutable, and tuples *THEMSELVES* are immutable and that's where the key difference are. Tuples can contain string elements which are immutable elements.  There's a distinction in that.

Re: Q7 in list: Your answer to Q7 list, linear_merge is not a linear time solution. You should notice that list.insert() does not run in constant time, so your solution will not be linear time. Try to fix it so that it runs in linear time.

Re: pythong 5b Q8: The question asks to print out the professors ordered by their last name? But I don't see that in your answer or your code. Did you address that issue?

Overall, great job! Keep up the good work!

-klq


didn't do anything. I recommend reverting.


Ok, disregard this comment since there's more latest commit.


Can this import be at the top level ?


Creo que se tiene que cambiar +DB_PORT dependiendo del que tu uses


Show code sample first, and then the longer explanation.


Use argparse for the args and step-size option.


优秀！


Aren't some of these needed? I'm not sure, but I think they are used down at line 330 or so in the vocab.


wow


done in next commit which has download manager, thx.


NEW FEATURE!!!!

```USE: math
1 2 math:+
```

mwhahahahahaha


@psychobunny I've been pulling from the v1.x.x branch as opposed to master.  It's normal for this branch only to be updated only when a new production version comes out, correct?  I'm (obviously) not an expert on node but now that I know to check package.json, I can see the discrepancy clearly.  I'll probably just manually tweak my package.json locally as a band-aid for now and then fetch the new code once the next v1.x.x release comes out.  I'd prefer this to running my production site off  the master branch.

Thanks for your help!


Hi Team
i am good for Junerealse but not for july.

@venkat, please check


(Implicit "QUALIFIED:" although implemented a little differently by b1be11f39c296591dfa6c151deec858d8d057872 and 7aa0e16df856842bf3e02145da2015b14d3e44d7)


As discussed on Skype I don't think this can be set directly and have an effect.  We should try to reproduce with a rooted phone and then try a fix.


good question. it seems questionable. are the tests run as well?


you used /bin/ksh but /bin/bash should used


This change broke regression tests, my runner shows:
```
error: at /opt/jenkins/workspace/runner/boost_bb/src/kernel/modules.jam:107
error: Unable to find file or target named
error:     'test_forward_list.cpp'
error: referred to from project at
error:     '../libs/serialization/test'
```

It seems that there is no `test/test_forward_list.cpp`.


jhf


@taylorotwell trying to return this Resource Item that is handled in a later middleware: https://github.com/EmberGrep/eg-api/commit/d1aa0df676814ac90e0584570f1f8830fa23754b#diff-01eee8e03c6705cdf775e88b7144654eR29


hghj


GitHub is a fucking cunt why can't it show correct indentation??!!


Yep reverted it for now.


Cool. There is lot's of action right now! :+1:


**[unitTests_php_contractual_responsibilities run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_contractual_responsibilities/1883/testReport/) for this commit**


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/29278/testReport/) for this commit**


From what I recall, the method ref offset could vary across JRE versions which is why we do resolveMethodRefOffset, but it's always the same for all lambdas/ConstantPools in the same JRE, so we cache.


@erg and I are hacking together right now up in Tahoe.  We should have a #factor meetup someday.


forgot to change to my personal dbc tmitka when merging/commit


Opam check says:

 /nas/common1/pir2/coq.inria.fr/opam/released/packages/coq-math-classes/coq-math-classes.1.0.4/url:
          URL is missing
Fatal error: exception OpamFormat.Bad_format(0, 0, "URL is missing")
Did you opam lint it?


Such an improvement. Interestingness pix all have some certain instagram-filter look to them.


.gitignore 파일에 *.class 추가해주면 될 듯~


link update


This seems redundant (conflict) with [elixir.versioning](https://laravel.com/docs/5.2/elixir#versioning-and-cache-busting)?


테스트 메서드들은 관습적으로 대문자로 시작하나요?
기존의 코딩 컨벤션이랑 약간 다른 듯~


Absolutely. Probably best to try for an exact match first and only going into fuzzy logic if needed.

The cutoff logic actually dates back to NIMS at the CNI, where group IDs are usernames of PIs, which aren't typically syntactically close to one another but misspellings are common.


So the latest babel compiler is giving issues?


Definitely! I'm hacking too but it's bedtime since long ago :)


TIP: if people join the project and start helping, you'll want to make those commit messages more descriptive. Obviously you're making updates. Simple and clear descriptions will save you a long time when in doubt of when you may have introduced a bug on your code base.

Keep up the good work.


String.Format


This was probably to fix an Opera quirk: https://github.com/mathquill/mathquill/pull/468#issuecomment-147021100


this looked ugly in team chats, I'll need to see how JA+ did it later


On what platforms did this not build originally?

This change doesn't seem to build on Linux:

```
/root/.cargo/registry/src/github.com-88ac128001ac3a9a/pbr-0.1.0/src/tty/unix.rs:36:30: 36:40 error: mismatched types:
 expected `u64`,
    found `i32` [E0308]
/root/.cargo/registry/src/github.com-88ac128001ac3a9a/pbr-0.1.0/src/tty/unix.rs:36         ioctl(STDOUT_FILENO, TIOCGWINSZ, &mut winsize);
                                                                                ^~~~~~~~~~
```


Night side of DFC needs their colors explicitly set. This should be all of them.


리뷰 완료했습니다


Looks really good!


It's a simple SpringMvc Demo feature Hibernate


Yup sounds good!


I totally agree! ;) But documentation should be updated as well, imo, hahaha! :)


按照最新发布的host文件，更新并刷新DNS后，还是无法使用Google， .85的地址ping不通,全文搜索替换成.84后可以


so this is why I was demoted


[Nist Flow Diagram.pptx](https://github.com/zaharamarim/ISQA3420/files/194539/Nist.Flow.Diagram.pptx)


Flow Diagram update


Escape missing


Isn't this something that should be fixed on master too?


This looks awesome


이슈 해결시
'인 게임 초기에 Workshop 레이아웃 깨짐 문제 보완  #1 '이런식으로 써주세요


This is wrong - you put the "ever" in the wrong place.


Is the update coming soon, Alex?


master (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2391 of 2577 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-92.78%25-yellow.svg)


Ah, that's really useful, thanks for the information! Was trying to figure out why the first steps had different code from when I viewed them a couple weeks ago.
On Mar 29, 2016 7:30 PM, Sashko Stubailo <notifications@github.com> wrote:This is the recommended file structure after Meteor 1.3: http://guide.meteor.com/structure.html#javascript-structure

If you don't want to import stuff, just don't put it inside imports/.

—You are receiving this because you commented.Reply to this email directly or view it on GitHub


You had one job :)


Ditto


neat trick. i presume this is all to reduce GC or memory fragmentation overhead?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 20184](https://teamcity.mesosphere.io/viewLog.html?buildId=183645&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:06:59


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 20183](https://teamcity.mesosphere.io/viewLog.html?buildId=183655&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 267 Build time: 00:09:23


I was reading the code and this catch struck me as being overly-broad. Can it be narrower?


Indentation in view_items.html has gone wrong, @kcmills I think you need to set up your editor to use spaces instead of tabs (and replace the existing tabs with spaces)

Wouldn't it be better to only display the message if it's not in the Trading List already?


Hi @RafaelJMRamos,

Great job! :+1:

You really did a great job with your python exercises. You had a really good explanation of map/filter functions as well as list comprehension. You did a great job with the advanced python section using regular expressions and file read/write, and dictionaries. I don't have a lot to say on those parts because it's very nicely done!!! :star2:

Re: Your explanation of sets vs. lists, it is correct that sets lookup is faster than lists lookup. However the reason is not simply "Sets are better for finding a specific element because there are no duplicates and because they are unordered." Sets are implmented via hashes, which means lookup is O(1) operation whereas with lists you have to traverse the list going through the indices which is O(N) complexity.  You should really make that distinction as that is the key to the difference in speed.

Re: Q7 Python 5a list: You had a good algorithm, however, it is not strictly linear time. In python, list.pop(0) is not strictly constant time (whereas list.pop(-1) is) so your code is actually worse than linear time. Try to fix it so that it could truly achieve linear time.

Overall, great job! Keep up the good work :+1:

-klq


In this format: `NAME_TYPE x,y mass`


Forgot to mention that I have re-disabled the auto-restart with System privilege(paexec) as it was problematic when debugging. Ill enable only when testing for myself the actual cleaning process...


Remove vertical rule styles from `h2`


Add explicit `hr`-tags


@kcmills Same problem with the tabs in this commit.

Could you replace <b> with <strong> as that's part of the accessibility guidelines? :tada:


我是无比开心地去得到这一份工作


Move these styles down for latter application in the cascade


Ah, okay. So I guess that the offset of the _last_ member ref info in the constant pool is always a constant even if there are multiple member ref infos? If the first member ref into that we look at doesn't match (i.e. it's an auto-boxing method, like `valueOf`), then it seems like we need to continue to scan through the pool to find the next matching ref.


Definitely. `GET_CONSTANT_POOL.invoke` is the only thing throwing checked exceptions here. I'll tighten things up here...


А с проверками что-то отвалилось?
Там по коду вроде только modelIndex не всегда инициализируется, ну и clang analyzer пишет, что значение сохраненое в переменной нигде не используется, а тут 3 переменных в одной строке и я сразу не проверил. А так у clang есть предупреждения -Wsometimes-uninitialized на этот счет.


SB，尼玛


j


What's the significance of `22` here?


Unfortunately this won't play well with how pull requests get content added to the bottom of the PR (through commits). I've emailed github about this.


The `lambdaType` parameter in `resolveAutoboxedMethodRefOffset()` is now unused as well and can also be removed now.


:shipit:


I am a big fan of this solution. :shipit:


The Linux.zip file contains the .exe and /bin file. Once downloaded, move the bin file to your /bin folder, either by dragging and dropping, or with the mv command in your bash terminal. To execute the .exe, type "mono" followed by the path to where you have placed the .exe file: for instance, "mono ./Documents/Gematria_Calculator.exe". This should run the file.


Got it - thanks!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 20185](https://teamcity.mesosphere.io/viewLog.html?buildId=183760&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 265 Build time: 00:04:58


rustc-serializeの0.3.16と0.3.18はAPIの互換性は保たれているはずなので、
セマンティックバージョンを使うようにすると良いのではないでしょうか？

```toml
rustc-serialize = "~0.3.18"
```

と書くと、0.3.18 <= x < 0.4の間のバージョンを使うようにできます。
セマンティックバージョンのcargoでの使い方の例はこちらです: https://github.com/steveklabnik/semver


something


Yeah sorry I confused `is_home()` with `is_front_page()` (in my defense the naming of those functions are retarded).

I did notice some issue with page title. Will bring it up in a different branch/pull-request.


420 pack it


test #1


This fixes a small bug: after clicking save plot, if a file name is already selecting by the GUI, clicking cancel or close still saved the plots, as a file name was returned by `dialog.get_filename()`.

I've made a general fix by improving the functions that open/save files with an `else` clause, and only called `dialog.get_filename()` inside the relevant `if` clauses.


Hmmm... it WOULD be perfect if you could if you could search a sentence in `ara` and return results in all of them!

If not, we'll have to treat `ara` as you said, to categorize sentences that don't fit into any of the other Arabic languages that we support. It would definitely be in our best interest to change the language name to "Arabic (Miscellaneous)" or something to that effect. If we end up adding explanations for languages upon selecting languages for profile (as we said we could implement for `cat`, explaining that it includes Valencian as well), then we could explain what exactly we mean by "Arabic (Miscellaneous)".

Another macro-language we have added to Tatoeba is Berber, which has no ISO 639-3 code; instead we use the ISO 639-2 code `ber`
User Amastan speaks `kab` (Kabyle), but if I'm not mistaken, has added sentences in other languages amongst his Berber sentences. I suppose that this too must be corrected... eventually, but I haven't heard from Omar in a while.


Excellent, thanks a lot for doing that.


tanks Geert!

> On Mar 29, 2016, at 2:44 PM, Geert Barentsen <notifications@github.com> wrote:
>
> @kcolon <https://github.com/kcolon> Caution: everything under content/pages/kpub/ * gets automatically re-generated by the kpub tool, so this will be overwritten at the next kpub update.
>
> I'll preserve these changes by merging them into https://github.com/KeplerGO/kpub/blob/master/kpub/templates/template-overview.md <https://github.com/KeplerGO/kpub/blob/master/kpub/templates/template-overview.md>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub <https://github.com/KeplerGO/KeplerScienceWebsite/commit/ef35a572193ec010b2b84930edd782429d1cc243#commitcomment-16885986>


accidently de-selected the file, thus it didn't get commited.


We should also be able to write this as:

`pfnmap = self._nodemaps.(to|from)_pyfr['quad', 4][fnmap]`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 20186](https://teamcity.mesosphere.io/viewLog.html?buildId=183767&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 267 Build time: 00:05:52


I see this as an it can't hurt issue so why not.


Clever. Wouldn't it be faster if the table was stored in the class's scope so that it doesn't have to be re-initialised every time the function is called? Or does Java optimise that?


same footprint on my dev machine.


Won't this create a `Uncaught ReferenceError: data is not defined` in case result.data above is undefined? Are we guaranteed to have result.data? ping @dannon


I want learngit


Hello everyone, here is bonatal. I'm starting a new step into the programming world.


I had issues compiling the tests so I don't know if they run as well, but I would guess they do based on the Makefile generated.