develop (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2361 of 2398 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.46%25-yellow.svg)


@sulthan-ahmed  It's a backlink to take you back to the previous page or somewhere else. In this instance it's being disabled as it's the final step in the form.


newlines


Sorry, I wasn't very clear. I was referring to my first comment:

> I'm surprised that you want to iterate twice over each couple.

And you answered:
> Well it is not a bug, as I was currently using it knowing it will yield (a, b) and (b, a)

So it means that the code that I found curious is this one that use `OthersAccessor` iterator while it might want to use another one that would only yields couple (a, b) once.

You also said:

>  but I think it would be a straightforward optimization when wanting to iterate over all pairs.

However seeing each couple twice or once would lead to different code behavior. On code that relies on that assumption. It is fine as long as you remember it and are the only one writing code for the project. I was thinking that maybe you could file an issue if this is something that you won't fix for now.


website_published is False by default, except if you create product from the Website Admin app (then website_published is set to True). Why is it dangerous ?


fp request


Is it intentionally overriding parent method without any implementation?


I think RFC339 is valid as it is a profile of ISO8601, I think is the recommended format on internet.


What's the benefit of this splitting of the stream here? Isn't that just unnecessarily delaying the output? Also: what if the worker's output deliberately includes a literal `\x1e` :stuck_out_tongue_winking_eye: ?


develop (evanweaver) - Win64-Windows-7-VisualStudio-12: Tests Failed (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Same answer then :trollface:


I can, as much as I can! but yeah moving forward this should probably be with @kdmcclin  or @alulsh


issue #1 created. I agree to change the order of those two lines


Any reason why this was not published as a release and the README.md also changed to reflect this version bump? same goes for the changelog.log file
I'm just mentioning this because I'm new to your project and from the README and changelog, I thought that development for the app stopped years ago and made me wonder if it was worth using it. After checking github and the commits, it seems that development is still going normally.


if one image was added to glance.images wouldn't  that cause all of them to re-download ?
could we create a dict with each image and it's state so the downloading would only happen on per image basis ?


`Cause.source(SpawnCause.builder().type(SpawnTypes.CUSTOM).build()).named(NamedCause.OWNER, this.plugin).build()`


Why not `0.36.10` here?


@meons, ou sont passés html5shiv.js et respond.js ? :laughing:


- pytanie po co przekazujesz name do function Deck(name) ?
- nie ma pobierania info o decku -> http://private-anon-a4b75f333-studybox.apiary-mock.com/decks/deckId


Actually, no. I'll update that.


^this. Looks fishy.


It looks like the `meet`, i.e. least-upper-bound, does not take interfaces into account. E.g. a `meet` of two interface types will be `Object`, and similarly, a `meet` of e.g. `scala.Function0` and any concrete implementation will be `Object`.

But I guess that we are not looking into optimizing that case at the moment.


Is this it?
No more settings FC?


Since we are not setting the attribute in HTML, would it work as well to invent a new property of the DOM element?  E.g.:
echo " aopts[$i][aopts[$i].length-1].codes = ,'" . attr(trim($res['codes'])) . "';\n";
... and correspondingly instead of getAttribute() below.
This is not to suggest you change anything, just curious about any thoughts on best practice.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18702](https://teamcity.mesosphere.io/viewLog.html?buildId=158479&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:00


The build is still broken

build/core/binary.mk:828: ошибка выполнения рецепта для цели «/home/niks/android/cm-13.0/out/target/product/iyokan/obj/STATIC_LIBRARIES/libtoybox_intermediates/lib/dirtree.o»
make: *** [/home/niks/android/cm-13.0/out/target/product/iyokan/obj/STATIC_LIBRARIES/libtoybox_intermediates/lib/dirtree.o] Ошибка 1
make: выход из каталога «/home/niks/android/cm-13.0»

#### make failed to build some targets (07:23 (mm:ss)) ####


@mfonville looks like the /data/app-lib portion is broken


115273495-Suspect-controller-type-in-MixedAirUpdateOAController-when-contaminant-simulation-is-active-#5535 (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1580 of 1580 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.85%25-green.svg)


What kinds of errors were you getting?


This doesn't actually work.  For instance, on a RHEL machine it gets you:
newcutlet:~$ lsb_release -s -i | tr A-Z a-z
redhatenterpriseserver

Moreover, there's really no reason to believe that the system info here correlates with a distro's reserved EFI directory.  I think if there's an issue here, we're probably better off making it /unset/ by default, and erroring unless it's specified. (and maybe having a .gitignore'd local defaults file so we developers can leave something in place normally...)

Something like https://github.com/vathpela/fwupdate/commit/690c778d9f0f0160989af3e79346b4e137e905b3 maybe?


Well, since ``package_list`` is now configurable that might end up being a lie. In any case, the next commit removes this comment anyway.


This is not safe, because setFromMatrixColumn modifies the vector, thus it overrites the x, y that are already set.  The code was previously structured to do these destructive sets first and cache the results is sx, sy, sz and then set the vector again.  To fix this one could go back to the old design or introduce a closure with a temporary Vector3.


@alanfx the actual problem is that the tests derived from SingleHotRodServerTest calls ConfigurationBuilder's native constructor before that the RemoteCacheManager is loaded, so currently they run only because CrossLanguageHotRodTest has run before. Since I only use the test suite via JniTest, my idea was to load the native library once at start up just to be sure that it happens before any native call. It's ok for you if I change the this PR to only add the static code to JniTest?


Interesting, I think the bulk of this driver was from some libopencm3 example, hence the timeout. If it works better without it, we should update it.
I haven't used the USB driver in a while, but if you want to make a new issue out of this I ll test the USB drivers on STM32 (and ChibiOS).


Ah no, fTools still was included and removed after the release.
Seems STAGED_PLUGINS needs to be set to TRUE


Maybe it makes sense to have type list per driver, somehow.

Will try to play around with code to see if it is possible later.

> Am 09.03.2016 um 5:43 PM schrieb Brian J. Cardiff <notifications@github.com>:
>
> Yeah, I wasn't proud of that dup. So
>
> Also given an union type, I think is possible to get an array of all the inner types.
> But at the end of the day, first I need to see if DB::Any will survive...
>
> —
> Reply to this email directly or view it on GitHub.
>


I'm only noticing now that you've used "use base" everywhere. How does it play with the previous line ?
But also, as I was saying on Slack: I think we don't need to add Bio::EnsEMBL::Hive::RunnableDB::SqlHealthcheck to every single runnable, but only to the RunnableDB/GeneTrees/SqlHealthChecks.pm
Since we're calling a methods from SqlHealthChecks, we shouldn't have to add additional libraries, it should all be managed by SqlHealthChecks itself.


The driver is a stateless factory. But I am not sure if just inherit the class should register the driver.
With the current design a user could register for a uri schem the driver he wants. Maybe there might be a clash with this schemes and different drivers. (we already have two crystal-mysql ;-) ).

There is nothing strongly settled regarding this registration pattern.


Oh, ok, and github will render code blocks just fine. Great!


Consider a comment above each assert describing what it represents. I'm not sure what a "nonPeriodTimer" is, nor would I know what to do if the microtaskCount assertion triggered.


Yep. Some exception classes will probably come. I just didn't focused on that still


@psychon

With this commit, the wallpaper on the external monitor only gets the size of the notebook's wallpaper, when restarting due to xrandr changes (from docked to undocked).


You should never use whitespaces in filenames. This will break on a lot of systems :)


`virt-manager`

selecting "Enable boot menu" in the machine's boot options will ...


Только от vanzo?


Sorry I don't follow you here. Driver is a stateless connection factory given a uri.


I think it was more that ``PACKAGES`` contains those items anyway, this was all effectively a no-op.

The comments were added in:
https://github.com/ceph/teuthology/commit/a9d85e6adb194a1e56a564db775d6676286401a5


Yeah you might be right. cmd + option + g works but it feels awkward. What do you think we should do about keybindings? The sublime plugin doesn't define any, but I'm not sure if that is the best either.


Why are we duplicating this logic instead of just using the component that you created?


To be consistent, "Developer Mode"


Obrigado por compartilhar ;)


I moved this block of code to renderer.js (the comments above it are the same) because I needed to be able to check if the layout was pre-paginated. That value is not necessarily already set in this callback. It's because of the EPUB2 duck-typing. It's really messy and I'd like to find a better alternative for determining if an EPUB2 document is fixed-layout.


If this is a whitelisted boolean attribute, just create and add the attribute node without a value since it's presence implies a value of `true`.


Great job Elena! Maybe you can remove the leftover instructions now...


This looks really promising!


XAXQ->XAXQt
const NumericalScalar Q(2 * (3 * residualSize - 4) - 2 * XAXTrace + (XAXQt * XAXQt).getImplementation()->computeTrace());


The textures are all public domain. The models are all original by me, released CC-BY-SA along with the rest of the hero/heroine assets.


Great job Xhesika! I like how you are using Github to store code you have written previously.


Shouldn't the options above be `-target` and `-gcc-toolchain`?


On another laptop this seems to shave off even more time, maybe even up to 1000ms.


I changed my mind, we are amending the file_name to form_map in line 32, so it's better to iterate over form_map keys


Awesome Gisselle! Maybe remove the instructions? Then you could try adding features!


spaces and openToken rules are not very simple with only a single CONSUME.
This is subjective but you might want to just inline their respective CONSUMES and remove two more rules from
your grammar.


Grossso!


Nope, literally duplicate code. The exact same line is in the same function about 10 lines down, and 11 lines down is the first use.


***Code Quality: Awesome***
Nice use of dependency injection here


Should I move my v1 Go client to v2?


Is there a difference between calling `builder.named(NamedCause.OWNER, this.plugin)` and `builder.owner(this.plugin)`?


Hi Michael,

thanks for getting in touch!  You are making a very good and valid
suggestion, and in fact we have been thinking about direct support for URL
paths for a little while now.  We are not yet ready to share any concrete
ideas, though.

In the meantime, the answer on the stackoverflow page is exactly right: you
can handle paths using Android's intent filter mechanism.

--
Patrick

On Mon, Mar 7, 2016 at 5:21 AM, Michael Derazon <notifications@github.com>
wrote:

> Any plan on adding support for handling specific routes ?
>
> For example, if I want https://example.com/products/* to open in app but
> want https://example.com to open in browser regularly.
>
> See
> http://stackoverflow.com/questions/35840262/handling-specific-routes-in-android-m-app-links
> for more details.
>
> Otherwise, every url form the domain will be matched and that's a problem
> for most use cases out there
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/google/digitalassetlinks/commit/5756ac4c037a4d6dee84e5cad79d8d40735ea971#commitcomment-16531529>
> .
>


Nice job Johanny! You have another project on Github now!


Good point. I just coded the functionality knowing how it would work and just wrote the other part of the code knowing it would iterate twice over each pair, but it may not be obvious for somebody reading the code (or wanting to use this iterator).

This whole repo lacks documentation anyway. I hope I will find the time and motivation to write some, but right now lots of part are too unstable for this.


Stuff like
```
myObject[Symbol.iterator] is not a function
```
I guess there's supposed to be an `Object.entries()` function in ES6 that works kind of like `Object.keys()`, but I think there's some kind of configuration issue that we may or may not care about diving into. If not, we could do things in a pseudo-ES6 way (this works):
```
for (let objKey of Object.keys(myObject)) {
    console.log(objKey, myObject[objKey]);
}
```


***Code Quality: Nitpick***
Angular has a nice utility method of $window.localStorage. You should use that ahead of localStorage only because it allows for your code to run in the angular context


For producer name on line 134 make this a label in salesforce as well as NPN on line 135 we want to avoid hardcoding things. Also you needed to do a pull request and assigned it to me I had no clue this was in here @jermainelindsay


typo


sure.  Kind of interested to see the generated railroad diagram and tweak for readability.


:tada:


This statement barley looks correct to me... "blahblah" is a bad default ;) I guess the intent is not to add an authentication header if NULL? If so, the code should reflect that.


Well, I followed the convention used in the other test methods. Didn't want conflicts in style. But if this is a problem, I will move them to top.


What does this property means? Why it's not called currentLanguage if it reflects language of current pane and not language of kernel, etc? Why this additional and unrequired step is introduced?
Why this can be achieved with separate function getLanguageFromGrammar?


dont know


Excellent


That's great change


[HZR] 2.4 Developer creates default display (right side article)


Yup, in this subclass `cancelGroupView` and `cancelControlConstraints` are not used, and `updateCancelContraints` was the only other method using those. Later I'll probably make another base class that will be extended by ActionSheetController and AlertController and will get rid of fishy stuff like this. But introducing such base class would involve a lot of renaming and refactoring, so it's a job for another day. (:


**[unitTests_js_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_js_branches/25852/testReport/) for this commit**


Not sure which is true. /cc @schneems ?


лучше пиши в начале классы, так легче читать код


saw approval from jonmeredith
at https://github.com/basho/riak_kv/commit/a4d7faa45673734d442c6ca2aa75d106a68da874


merging basho/riak_kv/at-flexi-keys2 = a4d7faa4 into borshop-integration-1368-at-flexi-keys2


basho/riak_kv/at-flexi-keys2 = a4d7faa4 merged ok, testing candidate = b64e2c29


I'm not sure if we should give this advice. Or at least not in this way. It's not meant as the main purpose of the mode. We should present it as more of a "oh and btw, you can hack it this way if you'd like to just keep using it without cloud-init".


@rigazilla I guess I would prefer to add the static block to ConfigurationBuilder and leave it in RemoteCacheManager, since I would say that is more "correct". Do you agree?


Because in the new ones the file sync is not working on nixos

On Wed, Mar 9, 2016, 17:41 Arseniy Seroka <notifications@github.com> wrote:

> cc @Mayeu <https://github.com/Mayeu>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/31c22761d8755731c9d16bc3a26a95b5ab5d3035#commitcomment-16594228>
> .
>


no strong feelings either way. as long as this is tested i think it's fine


Imo this approach is still too complicated. What speaks against letting the user manually override `check_prerequisites` if he needs something else than the default one?


...
$logger.


***Code Quality: Nitpick***
This action should have been delegated into a service. To avoid extra fat controllers, and also help in the structuring of your app. So after delegating the service this function should look something like this
```
$scope.addNote = function(){
addNoteService.addnote({title: $scope.note.title, content: $scope.note.content});
}```


Okay, I probably read wrongly your message. I was just very sad after reading your comment.
> I was just saying that if it was possible to clone an iterator yielding mutable references, then calling next() on both after the cloning would yield two &mut references to the same variable.
Yeah that make sense. I need to stop with TypeScript for a while and spend some time again on Rust.


давай все же сделаем ссылкой


Shortlog of HEAD commit is too long.

*GitCommitBear, severity NORMAL, section `commit`.*


?? We got lots of positive feedback on the Psyker profile? if we do Transport as a Profile you don't think it will work?


[Here's](https://github.com/fog/fog-aws/blob/master/lib/fog/aws/credential_fetcher.rb) the Fog credential fetcher that should make this work, per https://github.com/fog/fog/issues/1923.


Are we over-egging the pudding here?  Is this unnecessary JS whizzery?  It's the only JS in the app (it might be using JS from govuk_admin_template though).


@wrathchylde That should really include "partially 2.2". Cassandra 2.2 works, with the exception of 2.2 specific features (new `tinyint`, `smallint`, `date`, `time` data types and UDF/UDA metadata). If those aren't required by your application then you're good to go.


lepiej SearchType::class - jak się zmieni namespace to (dobre IDE) Ci wykryje użycie


@opadron


うえーい


Is it possible that this commit causes a crash on opening e.g. ipk-installer or MediaScanner?

17:46:55.904 { D }   File "/usr/lib/enigma2/python/Screens/ChoiceBox.py", line 63, in __init__
17:46:55.906 { D }   File "/usr/lib/enigma2/python/Screens/ChoiceBox.py", line 195, in updateSummary
17:46:55.906 { D } TypeError: cannot concatenate 'str' and 'instance' objects

Screens/ChoiceBox.py:189 updateSummary [Choicebox] summarylist: [(<__main__.Session instance at 0x723b5738>, 'ST1000LM024 HN-M\t/media/hdd'), (<__main__.Session instance at 0x723b5738>, 'Internal flash\t/'), (<__main__.Session instance at 0x723b5738>, 'Speicher\t/tmp')]

before that commit the summarylist looks like that:
Screens/ChoiceBox.py:190 updateSummary [Choicebox] summarylist: [('1', 'ST1000LM024 HN-M\t/media/hdd'), ('2', 'Internal flash\t/'), ('3', 'Speicher\t/tmp')]


I think its use full i almost did the same for some SW logic.


Either is fine: (from https://www.gnu.org/software/sed/manual/sed.html#The-_0022s_0022-Command)

> The syntax of the s (as in substitute) command is ‘s/regexp/replacement/flags’. The / characters may be uniformly replaced by any other single character within any given s command. The / character (or whatever other character is used in its stead) can appear in the regexp or replacement only if it is preceded by a \ character.


If both c and c++ compilers are clang, then you're duplicating flags in `cfg.env.LINKFLAGS`. Furthermore, the flags passed to `cfg.env.{CFLAGS,CXXFLAGS,LINKFLAGS}` are the same. Consider setting a variable and reusing it.


A minor bug fixed.


***Code Quality: Nitpick***
This function could be delegated to a service too as said in the previous comment


Add a '.' at the end of this sentence.


RealSense:
Requisiitos de HW y SW
Arquitectura de SDK


***Code Quality: Nitpick***
As said above


image не самое лучшее название, напрашивается вопрос где же картинка, не потерялась ли она


(y)


Shouldn't the error be rethrown by default? If there is an issue in the module, nobody will ever know :)


Looks like this broke the build


Well I think I _wrote_ my message wrongly ... I just didn't mean to be aggressive when writing it.

Sorry for that.


:+1: These look great, Clint!


I've added the GitHub link to their documentation about creating issues/pull requests templates for repos at the bottom to replace the removed section.


To be honest, `sarosa` and `dilia` are like that too. For `dilia` I try to add `TODO`s where I can and issues when the problem is more complex.

> right now lots of part are too unstable for this.

I fully agree to you on this, we are not ready yet for proper documentation.


I tend to be narrow-minded about using only boolean values with `or`.  I know that's not the convention in Python, so I'll try to adapt.


Good point. I also need to delete /blob/master


Just curious, was this due to performance reasons? Or did something not work?


The reason the progress was moved forward was since the data was read by httpclient and sent over the network regardless of the underlying error. But with expect 100 continue this patch makes more sense.


I see you prefer multiple returns to nested if's.
Another great way to increase readability create separate cofunctions with meaningful names in function and use it.

But here all stuff with ConfigManager should be definitely moved to a function


It wasn't being used, which is why every board defaulted to red.


I'll add a #TODO and do that in a later.


Good idea.


This is for extracting mean color of Red, Green, and Blue and write it to RGB.txt as reference for thresholding the background.


yeah I think you expect a result, otherwise the promise never ends.


I am not able to use this to start imagej:
final ImageJ imagej = net.imagej.Main.launch(args);

I get this error.

Exception in thread "main" java.lang.IllegalStateException: No UIs available.
	at org.scijava.ui.DefaultUIService.showUI(DefaultUIService.java:163)
	at org.scijava.AbstractGateway.launch(AbstractGateway.java:101)


This will break waf cross-compilation on Travis. Why do we have to remove those lines?


I agree.  That will come in time.


I regret that this doesn't seem quite right to me either - if no backend implements `read_header` then we will return `GIT_ENOTFOUND` here instead of `GIT_PASSTHROUGH`.

What about something like:
```
static int odb_read_header_1(
	size_t *len_p, git_otype *type_p, git_odb *db,
	const git_oid *id, bool only_refreshed)
{
	size_t i;
	bool passthrough = false;
	int error;
	git_otype ht;

	if (!only_refreshed && (ht = odb_hardcoded_type(id)) != GIT_OBJ_BAD) {
		*type_p = ht;
		*len_p = 0;
		return 0;
	}

	for (i = 0; i < db->backends.length && error < 0; ++i) {
		backend_internal *internal = git_vector_get(&db->backends, i);
		git_odb_backend *b = internal->backend;

		if (only_refreshed && !b->refresh)
			continue;

		if (b->read_header == NULL) {
			passthrough = true;
			continue;

		error = b->read_header(len_p, type_p, b, id);

		switch (error) {
		case GIT_PASSTHROUGH:
			passthrough = true;
			break;
		case GIT_ENOTFOUND:
			break;
		default:
			return error;
		}
	}

	return passthrough ? GIT_PASSTHROUGH : GIT_ENOTFOUND;
}
```

If any backend returns a hard error, we stop immediately.  If all backends return `GIT_ENOTFOUND`, we can reliably know that the object was not found.  If any backend returns `GIT_PASSTHROUGH`, we cannot determine the state and should fall back to a full read...


This should be atomic.LoadInt64 do not directly access like this here..


We need to output results one at a time, ensuring integrity, otherwise they'll get mixed up and break the output due to workers streaming results in parallel. We spent quite a lot of time looking for solutions to the problem and this was the fastest one. It's a good compromise to drop support for having `\x1e` in JSON output.


TeamCity jonas-requests :: WindowsBuild [Build 24](https://build.neohq.net/viewLog.html?buildId=571461&buildTypeId=JonasHaRequests_WindowsBuild) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 355, ignored: 7 Build time: 0:41:45
### Failed tests
```
org.neo4j.test.ha.ClusterTest.testClusterWithWildcardIP: <no details avaliable>

```


Oh, I see. Sorry about that!
Will revert.


Thanks your help!

:+1:


Мне не нравится


**[unitTests_js_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_js_branches/25854/testReport/) for this commit**


Maybe a question for @matteobachetti, then?


Probably should add a warning since this is an API change.


https://github.com/chibenwa/james-project/commit/4912af1b9de3cea65592ef160a151c891e4b1c48

I did not squash it as you already read this commit


[HZR] 2.4 Developer creates default display (right side article)


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/3312


Add a comment here..


looks good Alex


***Code Quality: Nitpick***
Most style guide including (google) advices that you should use controller As syntax to maintain the state of this in your controller. and avoid the excessive use of $scope except you have to call some of the inbuilt scope function i.e $scope.eval $scope.watch e.t.c.
So this should have been written like this.
```javascript
$stateProvider
.state('home', {
 url: '/',
controller: 'noteCtrl',
controllerAs: 'note'
 templateUrl: 'views/home.html',
```
So in your controller you could have
```javascript
function noteCtrl(){
vm = this
vm.testNote = " This is a text note";
}
```

And in your template you would have
```Jade
md-content {{note.testNote}}} // -- Test note
```
Source [Google Style Guide](https://github.com/johnpapa/angular-styleguide/blob/master/a1/README.md)


And because they are not back compatible

On Wed, Mar 9, 2016, 18:02 Matej Cotman <cotman.matej@gmail.com> wrote:

> Because in the new ones the file sync is not working on nixos
>
> On Wed, Mar 9, 2016, 17:41 Arseniy Seroka <notifications@github.com>
> wrote:
>
>> cc @Mayeu <https://github.com/Mayeu>
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/NixOS/nixpkgs/commit/31c22761d8755731c9d16bc3a26a95b5ab5d3035#commitcomment-16594228>
>> .
>>
>


I must have missed that or your updates and mine happened in parallel.


Idem, see https://github.com/chibenwa/james-project/commit/4912af1b9de3cea65592ef160a151c891e4b1c48

You already made this comment, and I already reworked it, just didn't squashed it....


что-то не очень мне эта секция


Yep.... indeed this can happen


Same thing


Are those changes related? I mean the PATH exporting and mavproxy installation? They seem unrelated to me. Maybe we should split this. Also, why do we have to install mavproxy as user? (The other commands are already issued with sudo).


Never heard that feedback. People don't really post things like that here. But if that was so, then good.

Just, in every discussion we had here it never really made it to the end.


Everything else LGTM


@alanfx ok for me.


@Chrysostomus are you sure for release ? Is really pkgrel=3  ?


Ok


v2 to v3/ETL Scripts/Lab_Result_CM_ETL.sql

same issue with Nationwide and Nemours testing where measurement_result_date is missing for all records


хмм


Why only primary locale?


where is the free for config when we take this return ?


recipe from http://entulho.fiatjaf.alhur.es/guias/how-to-use-node-along-with-other-language-on-travis-ci/ - thank you @fiatjaf


:+1:  но давай серьезно )


One reason LogBlock went over 65k so fast was a bug (turns out INSERT IF NOT EXISTS still increments the autoincrement on innodb even if it already exists, grr) but even discounting that there have been some people with popular servers (or sharing the database in a network) who have gone over 65k recorded players


Also, I'm always leary when I see magic strings, I'd consider trying to either find a pre-existing constant, or create a private static string in that class.


Thanks for this change, xnox.  Just looks like you need to update the TestNormaliseArch test in arch_test.go to check the s390x case (just a one-line add of '{"s390x", "s390x"},').


free should be free_config ! Then the macro does not leak anymore at least.


Ok for me. We should also change the `MouseComponent struct` comment above `Track bool`.

At the moment this comment says "event if its space is not under the mouse cursor." We could add something along the lines of "AND even if your entity does not have a space component".


VersionInfo.cs still shows 0.11.3.0


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18703](https://teamcity.mesosphere.io/viewLog.html?buildId=158490&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:02


I jumped straight to this commit to understand how the thing is used, before reviewing the classes themselves, so maybe this will become obvious, but why don't we need this shutdownTimer anymore?


Done! 😇


well, the size of the script


Again https://github.com/chibenwa/james-project/commit/4912af1b9de3cea65592ef160a151c891e4b1c48


Should we redirect or should we just render?
How complicated is the view for cookies-required? Maybe we could handle this in the same way we handle SESSION_TIMEOUT above.


Nulla da aggiungere :+1:


I don't know whether it's related to this commit, but I can't seem to build BlockCrs with this repo.

[ 29%] Building CXX object packages/tpetra/core/src/CMakeFiles/tpetra.dir/Tpetra_Experimental_BlockCrsMatrix_DOUBLE_INT_INT_OPENMP.cpp.o
In file included from /projects/install/rhel6-x86_64/sems/compiler/gcc/4.7.2/base/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/functional:56:0,
                 from /projects/install/rhel6-x86_64/sems/compiler/gcc/4.7.2/base/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/bits/stl_algo.h:68,
                 from /projects/install/rhel6-x86_64/sems/compiler/gcc/4.7.2/base/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/algorithm:63,
                 from /home/amklinv/TrilinosDir/christian/Trilinos/packages/kokkos/core/src/impl/Kokkos_ViewSupport.hpp:47,
                 from /home/amklinv/TrilinosDir/christian/Trilinos/packages/kokkos/core/src/Kokkos_View.hpp:66,
                 from /home/amklinv/TrilinosDir/christian/Trilinos/packages/kokkos/core/src/Kokkos_Parallel.hpp:52,
                 from /home/amklinv/TrilinosDir/christian/Trilinos/packages/kokkos/core/src/Kokkos_Serial.hpp:52,
                 from /home/amklinv/TrilinosDir/christian/Trilinos/packages/kokkos/core/src/Kokkos_Core.hpp:53,
                 from /home/amklinv/TrilinosDir/christian/Trilinos/packages/teuchos/kokkoscompat/src/KokkosCompat_View.hpp:58,
                 from /home/amklinv/TrilinosDir/christian/Trilinos/packages/teuchos/kokkoscompat/src/KokkosCompat_ClassicNodeAPI_Wrapper.hpp:5,
                 from /home/amklinv/TrilinosDir/trilinos-build-tpetra/packages/tpetra/core/src/Tpetra_Experimental_BlockCrsMatrix_DOUBLE_INT_INT_OPENMP.cpp:68:
/projects/install/rhel6-x86_64/sems/compiler/gcc/4.7.2/base/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/tuple: In lambda function:
/projects/install/rhel6-x86_64/sems/compiler/gcc/4.7.2/base/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/../../../../include/c++/4.7.2/tuple:501:12: internal compiler error: in get_expr_operands, at tree-ssa-operands.c:1035
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
make[2]: *** [packages/tpetra/core/src/CMakeFiles/tpetra.dir/Tpetra_Experimental_BlockCrsMatrix_DOUBLE_INT_INT_OPENMP.cpp.o] Error 1
make[1]: *** [packages/tpetra/core/src/CMakeFiles/tpetra.dir/all] Error 2
make: *** [all] Error 2


New implementation means for all loop iteration method should be invoke completely instead old variant where used current loop iteration step returning by 'continue' operator. New implementation may decrease each 'handle' method invocation.


will it be helpful if we log the index where we failed ?


...but their references ARE constants. Where does it say that in the style guidelines (just curious).

Personally I find this far easier to read.

As for the trove thing, I was pointed out to look into that and will this evening.


this commit also include some code white space clean up.


The imageset test has been revised for inclusion of rational tuples as well.
example:
x = Interval(1,2)*Interval(2,3)*Interval(0,3)
[1] Tuple(3,1,0) in imageset(Lambda((a,y,z),(y,a,z)),x) should return  True.
[2] Tuple(S(1)/3,1,0) in imageset(Lambda((a,y,z),(1/y,a,z)),x) should return True too.


Yes, it seems that this case was not covered by the tests. There, all algorithms were having the flag ``algorithm.performs_projection`` set to ``True``. Maybe we should add a test case, which actually tests the other case.


Depends what version you use. Master is  3.2 https://github.com/schneems/sextant/blob/f111fec8a3b89c2f19fc0c859e834ea7d47c6164/sextant.gemspec#L22


That is laziness on my part to be honest, and unrelated to the other commits - it'd be handy if we still had a shutdown timer. The problem is that to time shutdown you need to delete the script, but to print the performance statistics you need to keep the script. I could have fiddled it all into some sort of "preprocess the stats and stash them somewhere, shutdown, then print everything" but I wasn't feeling like fiddling, and the shutdown stats didn't seem that important. I can fiddle it back in though if you like...


@dhuppenkothen no particular reason actually. Let's decide a convention and stick with it.
Probably, the best way would be to import at method level all optional dependencies, and at module level all the others


> Je ne suis pas sûr que ce soit exactement la même chose pour le SMIC et les cotisations sociales.

La différence est en effet bien mise en valeur par le test `salarie_ipp_2014-11.yaml`, qui commence avec un premier mois incomplet. Je vais travailler ça.


The reason is perhaps to avoid races like this -

``
c := atomic.LoadInt64(&pb.current)
return c
``


@mi-we since we only need "SCENARIOO_HOME", this method should be called getScenariooHome and access only this environment variable, this would allready improve the design and even the tests.


Nope.


this file was a pseudo-code reference for the memo/cache fixpoint finder... `caching`, `memoify` and `mlfp` are the parts that need to come back to life at some point.


:+1: it is just that you already reviewed the previous one


Here's the change https://github.com/schneems/sextant/commit/e14c0add8ca04fce0ac95e17314052ba91554914 no clue why I made it.


What you should actually change is the "when".


This could be reused for the real /prison reload command.


@mi-we Please allways document shortly the purpose of a class (what is its responsibility?)


I'm fairly confident that you're the only person to have ever used the stats app (or maybe David too), so if you don't find the shutdownTimer stats very useful anymore, I'm sure nobody will have noticed their disappearance...


Actually, after just trying it, seems like you'd have to disable all cloud-init services: `systemctl disable cloud-config cloud-final cloud-init cloud-init-local`. Maybe move this down to the last paragraph before the "You can find more information ..." to say something like:

Though Developer Mode is meant for easily checking what Atomic Host is all about, nothing stops you from setting a root password right there and then and disabling cloud-init completely to have a regular development machine:

```bash
passwd
systemctl disable cloud-init cloud-config cloud-init-local cloud-final
```


Indeed, al exported elements should have a comment. For a future PR?


> /Users/one/Documents/LibreCAD/librecad/src/lib/math/rs_math.cpp:432: warning: absolute value function 'fabs' given an argument of type 'const LDouble' (aka 'const long double') but has parameter of type 'double' which may cause truncation of value [-Wabsolute-value]
        LDouble const fc = fabs(c);
                           ^


@mi-we I see the point of wrapping the static System calls, just for mocking it in the tests, but I do not like the name of this class. What about: SystemEnvironment (i not like "Wrapper" here, too generic)


"Before" preposition:
1.
previous to; earlier or sooner than:
Phone me before noon.
2.
in front of; ahead of; in advance of:
his shadow advancing before him; She stood before the window.


This update needs review. Variable "d" is removed, but it's still used at line 9 at `sum /= len(d)`


Wouldn't [pc.himHerIt] check the PC's gender?


Is it ok to leave off the terminating '+' like this?


Honestly any Timezone will do. If you want to stick to the Greenwich standard that works too. Wouldn't be a son of the West if I didn't try to get in some PST love


just a fence for internal use of the package


The way the Google Java style guide refers to constants not only includes modifiers but also immutability: https://google.github.io/styleguide/javaguide.html#s5.2.4-constant-names


Had to update this file on my local copy.


I think it follows the original logops (TM)


thats cool, i think the next step is discussing the platforms we intend to debut with and then proceeding to construct the user flow.


If these test cases are useful, we should store them locally and hook them up to the unit tests. I think there are parts of the frontend which could be run against them as well.


the size in character or the size in octet ? Here, you have the former


Inspiration: http://stackoverflow.com/questions/13757722/force-eclipse-helios-to-use-a-newer-version-of-swt-at-application-runtime#comment19034572_13763049


If the args are going to be right on the page they should probably be in a `pre`. Otherwise there's not much point to us pretty-printing them.


Changed at 869e1c0f522677082a9c6d4289645aa7f25917e1


Won't this cause move-vs-reborrow issues for MIR borrowck? Maybe we should just allow overwriting reborrowed things and get rid of the problem.


Nice


@mi-we For convenience: Add a default constructor, that implicitly creates the "SystemWrapper" and injects it by calling this other constructor (since only the tests need to inject a different instance of SystemWrapper), and therefore you could even make this constructor package private then.


s/wher/where/


This update needs review. Variable `d` is removed, but it's still used at line 9 at `sum /= len(d)`.


Wouldn't this make more sense in the above check?
`(!this.counter && !Foundation.Box.ImNotTouchingYou(this.$element, false, true))`
I would still like dropdowns to reposition themselves from top to bottom depending on window scroll position.


> If I recall correctly, we already agreed (in an email correspondence) that it is an implementation
detail which should not "pollute" the metadata description ...

This is correct. CUBA.DATA should not be defined yet in the yml file. But this does not mean it cannot be used!.

It will be defined in the specifications document as part of the deliverable D1.6. This is why it was now added as a comment. However, to complete the schema it will have to be specified in the metadata level. Will make an issue regarding future metadata compliant specification of CUBA.DATA.   This will move the implementation forward while the remaining delicate points are cleared.
Do you agree?

As any other CUBA, it serves to indicate that each entity that inherits from CUDS_ITEM will have a data container as already implemented.


@mi-we the constructor is public, but this methods not??


Ok, I could move createPreprocessor() to JavaMode, but it won't be accessible from ASTGenerator or XQPreprocessor, because the only way to call it would through the mode instance in the editor, i.e.: ```PdePreprocessor p = editor.jmode.createPreprocessor(null);```, but jmode is a private member of JavaEditor.

Alternatively, I could make createPreprocessor() as static method in JavaMode, which could be hidden by its declaration in AndroidMode, but do you think this a good solution?


Won't `is_valid` always end up true?


this will mean that ACLs with project+language will apply too.
IMHO that is not what should happen, only "pure-project" ACLs should apply.

if you agree, i can send a PR with doc & test for this


maybe to be fixesd in another PR? There are not so different and it is for developer's use. It should  not have impact in other systems


激动人心 (*˘︶˘*).｡.:*♡


Use the `load_ty` luke


no


Brett, I found all of this redundant since we assign it to `null` above via `ws: typeof WebSocket !== 'undefined' ? WebSocket : null,`


@mi-we: please move the setUp method to the top in unit tests!


done.


ok, so what's the link with `Guice compilation for specific backends should be activated by specific profiles` ?
It looks like a module rename, isn't it ?


Hi @AndreyShelest ,

Do you know how to make this without repeating QTQMLTRICKS_NO_PREFIX_ON_GETTERS define?


@dorimanx I think this is the last hotplug driver that you don't have, just to show you :)


@ZSnake calm down <3


Please change this name for other more strange and specific for the project.


As the profile for activating cassandra-guice is in server/container/guice (IMO the right place) we need to change the parent of this pom to the module that include this pom. What I am doing here.


@mi-we Cool, I like your changes. Good work! Please see my review comments about some small things to improve.


isn't there an issuye related to this


update -> Update (in commit message)


What is this for ?


why the line break?


@alanfx should be ok now


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18704](https://teamcity.mesosphere.io/viewLog.html?buildId=158492&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:04:53


ok, I agree then


Зачем jquery? bootstrap требует?


thats how all are.


Ah ok. This was just a sketch of what the code is supposed to look like. For that, is more than adequate.

The types here are pretty tricky though.


This does not work, PUT returns an error for me
=============

object(stdClass)#63 (5) {
  ["type"]=>
  string(77) "http://developer.mailchimp.com/documentation/mailchimp/guides/error-glossary/"
  ["title"]=>
  string(18) "Method Not Allowed"
  ["status"]=>
  int(405)
  ["detail"]=>
  string(113) "The requested method and resource are not compatible. See the Allow header for this resource's available methods."
  ["instance"]=>
  string(0) ""
}

=============


Don't use jBone to save helpers, you could use $gfwdom.utils or something like that.


Cerrado por integrar todo en index.html, sin separar en ficheros (explicado en el comentario del pull request anterior).


do it only if it's a long list that doesn't fit into one line please


Not really empty :-P


`Add disabled section` is wquite useless, rather describe what the section is for please


should be `is out of scope`


***Code Quality: Nitpick***
I feel this could have been written in a better/ more robust way. This looks hacky ¯\\_(ツ)_/¯


don't use includes in script xml's. this won't work in skins that don't have this include defined.


Thanks for fixing this. Why didn't you not just add the second parameter in the setUserConvStatusTest routine in the BelosSolverManager class? Now we have the one parameter version that each derived class may (or may not) implement and the PseudoBlockGmresSolMgr has an additional second variant which accepts two parameters. When propagating the handling of the user-specified status tests to all other solvers we probably want the same behavior for all solvers. It always would make sense being able to define the relationship of hard-coded solver specific unit tests and optional user-provided additional status tests, wouldn't it?


Maybe this will help think about it: in this compiled version, the ev fixpoint knot is a compile-time fixpoint for traversing expressions. after tying this knot, giving it an expression will compile the whole term. (mrun compiled-thing) then kicks it off and doesn't interpret syntax ever again.


here also the contextId as the second parameter could be used, similar to the next function.


your addon needs to provide these textures.


LGTM


If you're interested, have a look at this .install file I wrote for the other community plymouth-themes:
https://github.com/manjaro/packages-community/blob/master/plymouth-theme-manjaro-cinnamon/plymouth-theme-manjaro-cinnamon.install
It checks if the theme is the one currently already installed and if yes, re-writes initramfs to actually update the theme. Only makes sense as soon as you change something in the theme... But otherwise what ever you change in the package will not have an effect for the user until mkinitcpio is run the next time :wink:


I think, in the future we could improve this.


@arielb1 No, because reborrows don't have *identical* input and output types.


@heliocentrist Thanks,  I thought that nearby other parameter shall be checked


واقعا باگش کوچیک بود :|
is it littel??????????????????? :|


i haven't tested it, but can addons provide a colors definition file?
if not, better use a hex value here.


the contextId should then aslo be used :-)
also, when calling this function, it should be given as parameter whenever possible.


Yes sorry, I grabbed the license header from mem-heap.c since a good bit of that code comes from there. I didn't see guidelines on updating / writing the copyright banner. Should I update it to 2016?


@mi-we why is this method called "loadXX" if it just returns the file path?


Что значит ии

среда, 9 марта 2016 г. пользователь MrTsepa написал:

> О, придумал, я могу написать простой ии врагов а ты напишешь ии игрока
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/TsepaStepan/Tanks/commit/cb426df76a731adb19568185e800e36bacd4dd20#commitcomment-16592073>
> .
>


initializing nginx server via bash-script


thx


This changes behavior - returning `PFR_PJ_INVALID` if the array is empty. Not opposed to doing this, but want to be sure we aren't breaking callers.


oh yea, tots forgot about rpi. Kinda figured that modifying `when` would be cleaner.
2am brain is not making much sense atm.
I'll prolly give a shot to figure the thing out, and maybe use the package module too


добавить класс list


Looks odd, shouldn't it be float?
UnitResourceInfo.metalUse is float.
Must be an old copy-paste bug.


shouldn't this call logically belong to "initializeConfigurationRepository" ?


Same here


добавить класс list :
div class="list list2"


добавить класс list :
div class="list list3"


добавить класс list :
div class="list list4"


заменить на .footer .list ul { ... }


Il metodo `.con_esito_pending` non esiste in `Titolo`, ma in `TitoloPersonale`.


А зачем писать ИИ игрока ведь мы им управляем

среда, 9 марта 2016 г. пользователь Степан Цепа написал:

> Что значит ии
>
> среда, 9 марта 2016 г. пользователь MrTsepa написал:
>
>> О, придумал, я могу написать простой ии врагов а ты напишешь ии игрока
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/TsepaStepan/Tanks/commit/cb426df76a731adb19568185e800e36bacd4dd20#commitcomment-16592073>
>> .
>>
>


TEST COMMENT


Thinking about this more, I don't understand why this is working. `syncActions.initRequest()` doesn't _do_ anything (it just records the beginning of the init flow) and `syncActions.hideUnavailableDevices(opts.os)` should be a no-op on the second time 'round. Re: my comment, I don't remember what "trouble" we were getting into - is it just w/the devices list? Also the comment is inaccurate now (you're no longer preventing app initialization more than once) so please update @krystophv


master branch is now up to date with the calendar input


Heidi just sent me a polite email pointing this out.  I'm in the process of pushing the fix now.


@regalstreak this


This change makes replays list empty right after SpringLobby start. This is what you meant to do?


There were already a few prior comments in favor of moving the explanatory sentence to the table caption, since the terms explained in it are not really used outside of the table. However, if you have a suggestion on how to shorten it, feel free.


The commit message is incorrect. Please replace it from
  ~~P0189R1~~ Wording for [[~~nodiscard~~]] attribute
to
  **P0188R1** Wording for [[**fallthrough**]] attribute
.
(I don't know the correct "R?" number, though.)


na hes talking about binding hw keys i think


yes


Hey @JonnyRock82, nice edit!


I wd talking about swapping the recents and back hw keys


Good Job


Perfecto!


delete


Sweet! Feel free to change any of the monsters if you think of something cool.

On Mar 9, 2016, at 4:53 AM, Chris Wells <notifications@github.com> wrote:

Haha I was going to come in and commit my own monster, but I quite like the details you have made for me

—
Reply to this email directly or view it on GitHub.


de


Included are labs and projects from the Android Development program at Madison College as well as personal projects completed outside of class by Sean Fiscus


d


@Hikari-no-Tenshi Note that I've stopped work on this branch now; the change is so vast and complicated compared to my MX4 port which is only GSM/WCDMA/LTE and single-sim, that it's completely unfeasible to "port" the whole thing (which basically is equivalent to importing all of MTK code only getting it to build under the CM build system and stripping out ALL CM-specific changes). The branch currently can proceed until first successful attach to CDMA 3G data connection, but that's all; major things are broken, like:

* Unable to restore data call after toggling data switch (due to unknown side-effects and interactions of stock MTK code),
* Unable to switch default data subscription (due to completely different implementation approaches that are impossible to merge),
* CDMA calls can be made and accepted, but are silent (due to not having sufficient time to port the suspected `SET_SPEECH_CODEC` request and friends),
* Frequent failures initializing RIL requiring ~3 reboots on average only to properly register on the network,
* etc.

My plan is to suspend all MTK porting until first MTK Marshmallow code drop happens (likely from Zopo). Let's only hope that MTK does standard things this time... :-/


The logic is simple, when user clicks on the column to sort it, it will sort that column and then move vertical scroll bar to the top as the set is now sorted. Do you have any problems with it?


thx, will remove this code. Old leftover.


can we just move these free fns into the `impl`?


Hi Kentaro, I think there are some issues with this. I am trying to build this package on archlinux, and I get unreliable builds, sometimes I get this error:

```
Scanning dependencies of target image_view_exe
[ 70%] Building CXX object CMakeFiles/image_view_exe.dir/src/nodes/image_view.cpp.o
/tmp/yaourt-tmp-username/aur-ros-indigo-image-view/src/image_view/src/nodes/image_view.cpp:34:40: fatal error: image_view/ImageViewConfig.h: No such file or directory
compilation terminated.
```

Which I think could be related to this change here, since you are adding the auto generation here. I am using indigo 1.12.15.


yes, it's a typo, fixed in 4749d46


yup thx. missed that when converting from skin-specific xml to script-default.


Wartosci RGB sa od 0 do 1


Looks good to me


I concur. Can someone make a release?


przedrostki w extensions wedlug schematu sb_NazwaFunkcji.


Yes. I think a static map is better.


Wonderful. Thanks


@mi-we or... why are you loading the configuraton here, if you not need it ... why does the new server startup not log the documentation path here anymore. I would recommend to still log that on startup (and/or to do that explicitly here, not just with a funny get, that nobody understands what it does here)!


Good Job


hmm, rounding error was apparently never significant enough to be noticed.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18705](https://teamcity.mesosphere.io/viewLog.html?buildId=158503&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:05


@varund7762 @akhilnarang


tbh i dont know either :) might also be some testing relict from some years ago. Will remove.


Are you using V2 or V3?


Aaye *@varund7726


is this an integer, then it should be cast with (int)


Consider: `for (auto const& c : accountSourceCurrencies(*raSrcAccount, cache, true))`


`^4.6.0` is equivalent to `>=4.6.0 <5.0.0` :wink:

The only reason this didn't break everything is that there was a v4.6.1 that satisfies that.


115273495-Suspect-controller-type-in-MixedAirUpdateOAController-when-contaminant-simulation-is-active-#5535 (lgu1234) - i386-Windows-7-VisualStudio-12: OK (2136 of 2136 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Good call


I am working on the changes you suggest. It occurred to me that this is a constant, and a concept has to exist in the database for this to work. If we allow the user to change the concept uuid, it will be the user's responsibility to ensure that the new uuid exists in the database.


@mostaphaRoudsari The file not working was entirely my stupidity. I was saving the gh file with "save as" and I think it was saving an html file as gh. I can get the file to open now...shall report back soon !


> The definition rather implies that PE and MRs should be properties of ME ...

I see the logic of this too, but the parent relation does not mean that one CUBA key is necessary a property of the parent. In cases where it is, it is defined explicitly (like the relation between gravity and cfd for example). Here my intention was to classify both MR and PE as a kind of and belonging to - conceptually - the ME. They also inherit therefore the physics variables.

We could though define the ME as containing both the MR and PE as properties, simply by adding those like this:

`
   MODEL_EQUATION:
    definition: SimPhoNy Model Equation = PE + MRs according to the RoMM
    models: []
    parent: CUBA.CUDS_COMPONENT
    physics_variables: []
    CUBA.MATERIAL_RELATION_EQUATION:
   CUBA.PHYSICS_EQUATION:
`

This may however be a step back to the four boxes CUDS model (which wthe SSB already replaced with a flat one without the ME explicitly appearing inside!)


Closed by commit 5623c42934: Move special characters outside of XLT.


So how about we add a comment here stating why it's like that?


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#O5Y6LkStS8utO06O0fQffA


Hmm, this doesn't seem to work. We got following error with repro:

```
xzhang=# explain select * from webtable w1 where 10 > (select 1 from webtable w2 where w2.c2 = w1.c2 limit 1);
ERROR:  unrecognized node type: 526 (walkers.c:520)
```


Thanks for catching that!


Here you can use `logger.WriteLineError`.


**SUCCESS** - TeamCity HotRod C# Client :: Pull requests monitor - WIN_S2012 [Build 98](http://ci.infinispan.org/viewLog.html?buildId=37234&buildTypeId=HotRodCSharp_PullRequestsMonitorWinS2012&guest=1) for 9ddcf6b389ecdc8144348182d4faf966b2c9cee1
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:12:57


What does type `0` and `5` mean? Maybe we can add constants for them at the top of this file and use those instead?


Good Job


Doesn't that depend on the mood of lifetime inference?


Shouldn't the appropriate new functions be implemented in the submissionFile class, similar to all the others -- get and set methods for those two additional attributes (database columns)?


The index variable doesn't seems to be used anywhere.


Can we use `isnt` and `is` instead of `!=` and `==` for consistency?


This commit had passed the test on Travis at https://github.com/ros-perception/image_pipeline/pull/169.
The error may be caused by changes of build tool or dependant packages.
Could you please open a issue?


Gostei dessa solução, não tinha analisado essas duplicidades
acredito que seja necessario os métodos sem Async porem a forma como você sugeriu com .Result, já funciona


You can do `.catchReturn([ partition ])` here.


please, use Start_Request::make_request   method as it includes all curl (or php stream) code.


We can fix this as a follow-up PR, but I think we should by default probably leave reporting enabled. It's good to have the code here, in case people do want to disable it ("If you do not want metrics to be reported, uncomment the following line:") but in general it looks pretty harmless / like it can only improve InfluxDB overall. did you find other motivations for disabling by default?


Not your fault, but this construct borders on unreadable... since you're here, can we try to improve it?


Build failure reported at #36.

<!--
jenkins: report-done
-->


Can we use `.then(_.flatten)` here?


what about CPU*FrequencyList variables?


can you move this to be right after cmds so things are in alphabetical order? The Go core guys prefer that.


Would be nice to wrap the "20 minutes" calculation in a function to make this more readable :)


3n/4, not 2/3 log n


115273495-Suspect-controller-type-in-MixedAirUpdateOAController-when-contaminant-simulation-is-active-#5535 (lgu1234) - Win64-Windows-7-VisualStudio-12: OK (2136 of 2136 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


You can replace lines from 43 to 47 with this code:

    cpp.defines: {
        var defines = project.generalDefines;
        defines.push('QTQMLTRICKS_NO_PREFIX_ON_GETTERS');
        if(project.justRunExperiments)
            defines.push('JUST_RUN_EXPERIMENTS')
        return defines.concat()
    }


Prefer: `boost::algorithm::clamp(std::pow(sourceCurrencies.size(), 2), min_cost, max_cost)` here. You'll need a `#include <boost/algorithm/clamp.hpp>`.


Node already implements EventTarget, so I think you can just go with `?EventTarget`. However, are all EventTargets really valid here or is there a more specific type this should expect? What's the type of the object that caused this PR?


@clin7 I had branched off a feature branch and not trunk. I have created a new branch and made appropriate changes but it's still WIP.


I totally agree. Actually I did exactly that for mark discoverable vertices. The part that makes it hard to implement on multi-GPU is its global visit status array. Also I've done some experiment and found out that the switch-back step is unnecessary too. We can actually switch once, then use the pull-based implementation. For the advance operator, we can reuse the forward one, only part missing is discoverable and undiscoverable vertices. Let's talk about this tomorrow (I have a group quiz tmr morning, can meet afterwards).


Given that the only terminator which affects the gen/kill bits is call -- it'd probably be easier to move this logic into the "propagate" loop. In that case, you could easily handle the fact that the kill should apply to at most one of the successors.

(It'd make the propagate loop a bit less pure of course, in that it is doing a bit of "logic".)


No use, I reverted already.


@wkentaro Or I guess this depend is not working correctly?


Do we need the reference here to avoid that weird gcc 4.4 issue you found?


Yes sorry still need to add it to CPU set

śr., 9.03.2016, 18:03 użytkownik benschhold <notifications@github.com>
napisał:

> what about CPU*FrequencyList variables?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/yarpiin/anykernel/commit/877a61a20c81815dd9da6e613897adef5a9b512e#commitcomment-16596565>
> .
>
--

Slawek Handzlik


`conference`, when you use Webstorm it will tell you that you introduced some typo


There is a function in `partitions.coffee` called `getPartitionOffset()` that does exactly this:

```coffee
exports.getPartitionOffset = (partition) ->
	return partition.firstLBA * SECTOR_SIZE
```


basically you'd just move the code that reasons about the extra kill bit here


Can we replace `path` with `image` to be consistent with the rest of the functions in this module?


Thank you @oberon2007


you're welcome!


iteration (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2359 of 2398 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.37%25-yellow.svg)


Issue still happening.

> Installing Container OS image from D:\WindowsServerCore.wim (this may take a few minutes)...
> Container base image install complete.  Querying container images...
> C:\Install-ContainerHost.ps1 : Image NanoServer not found after 5 minutes
> At line:1 char:1
> + C:\Install-ContainerHost.ps1 -PSDirect -NATSubnetPrefix 172.16.0.0/24 ...
> + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
>     + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Install-ContainerHost.ps1
>
> C:\New-ContainerHost.ps1 : Install-ContainerHost.ps1 failed in the VM
> At line:1 char:1
> + C:\New-ContainerHost.ps1 -VMName testcont -WindowsImage ServerDatacen ...
> + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     + CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
>     + FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,New-ContainerHost.ps1


Nit: I feel like it'd be nice to factor this code out into multiple modules. e.g., at minimum one that handles just the low-level bit manipulation and one for the MIR-specific logic


Is there a reason this is using string concatenation instead of interpolation?


2097-EP-8-5 (kbenne) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


integer cast?


Maybe you can use an `if` guard for this condition to reduce indentation?

```coffee
.map (partition) ->
    if partition.type isnt 5
       return [ partition ]

    getAll().then ->
        ...
```


iteration (evanweaver) - Win64-Windows-7-VisualStudio-12: Tests Failed (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Closed by commit 06a0ced:

> Revert more DOM changes from commit d1442ffe30


bailoutaaah


Still waiting on the offline discussion changes


I agree that your proposed interface is much better (I have a branch with this change). It is however even simpler to assume that all labels are unique when printing record patterns and let `typecore/chech_recordpat_labels` handle multiply defined labels on its own. I should have seen that earlier.


@Glenn-1990 Unfortunately, this does  not work 100%. A recording may life way longer than the channel it was recorded on. Best would be if tvh would store a "radio" flag along with the recording and expose this flag over htsp. Any chance that you implement this for tvh 4.1?


boolean cast?


Don't forget the easy functions!


Good catch - I don't know. I'll look into it, and make sure we have test coverage...


Nice catch.  Mind opening a PR to fix this?


Thanks!


If there will be several messages in a queue, they all should be delivered.
So there should be some loop.
And client side should be ready to receive several messages at once.


Is it possible to have three states? Starting, Running, and Stopped? If not why Started over Running?


> What speaks against letting the user manually override check_prerequisites if he needs something else than the default one?

One can always do that. But I am trying to decrease redundancy here. If you check out `ScalaLintBear` and `CheckStyleBear` you will see they are using something very custom and the code looks pretty unreadable. They have a builder function, that returns the check_prerequisites function.

This pattern of checking for a prerequisite is also getting common, for linters which are activated through an argument, like Ruby and Julia's.


If the lifetimes end up being identical, then *there is no reborrow coercion*.


Purely because it's an adaption of the simple-arm using generation, which predates interpolation.


this would then be getSubmissionSettingsRevisions as in comment above


Works fine!
Thank you!


What does a `DataSourceMetaData` object represent? A single column? And for access patterns, will we query by `datasource_id`, and then group common `tables` together?


Besides, aren't reborrow coercions actually `&mut *foo`? i.e. not a MIR cast, because MIR casts *fully consume* their operand.


Should **current_document** be** currentDocument** ?
https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/#naming-conventions


here too: ->setHideRevisions and ->setSubmissionSettingsRevision...


could we not post here
getting messages in my inbox
thank-you


I am not sure if ':' should be included in the locale file -- could you please see how is it handled else where?


delete it


Sheeri suggest me how can i more improve this validation.


':' here too...


add comments explaining why


method call...


missing 'id' attribute


method call -- just to make it easier find -- but actually grep should do, so I'll stop commenting this ;-)


this is just referring to the `Call` question?


'id' attribute missing


изменения


You can just pick something else I think (`k` perhaps?). Goto isn't the core feature of import-js anyway, so probably won't affect too many to begin with.


This doesn't look good...


The reason this used to return false was the old "internal iterator" protocol. The only user of this that I could find always returned `true`. Let's either convert to a true iterator or else make the callback unconditional (i.e., `FnMut(usize)`)


PR #121


Looks like we may not need the spaces for the colons:
https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/#spacing
... As in:
'dragImage': 'actual'


s. Alec's earlier comment...


thanks sheeri i have added new rules for validation groups. kindly check the updated file from repository.


I'll swap the lines.


Why not put this into its own file?

/me likes more files!


Actually, borrowck treats *moves* better than *borrows*, so turning a borrow to a move will make strictly more code compile, so we are clear in any case.


This passes on Windows also, doesn't it?  Why not just use `[PlatformSpecific(~PlatformID.OSX)]`?


Should be ok now check please

śr., 9.03.2016, 18:06 użytkownik Slawomir Handzlik <yarpiin@googlemail.com>
napisał:

> Yes sorry still need to add it to CPU set
>
> śr., 9.03.2016, 18:03 użytkownik benschhold <notifications@github.com>
> napisał:
>
>> what about CPU*FrequencyList variables?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/yarpiin/anykernel/commit/877a61a20c81815dd9da6e613897adef5a9b512e#commitcomment-16596565>
>> .
>>
> --
>
> Slawek Handzlik
>
--

Slawek Handzlik


комментарии к изменениям


It should be fine now check please


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18707](https://teamcity.mesosphere.io/viewLog.html?buildId=158532&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:06


We really should make a macro for "newtyped indices". I envision it working like this:

```rust
struct NewType(Nonzero<u32>); // stores the index + 1, so that `Option<NewType>` is 1-word
```


Thanks for adding this, Renyi. It is a good start for validating our implementation of Kafka message processing.

You are making few assumptions about the test messages in the Kafka topic. Note them down in the code comments. That will help contributors setup their Kafka before running this manual test. You may also want to add a //TODO to add code for setting up Kafka to make it easier to run the manual test.

Use variable for number of partitions and use that in configuring dstream as well as validation

Consider moving Kafka configuration to config file so that code changes are not necessary to run this manual test


Obviously orthogonal to this PR :)


ohk
I thought you could with this
Don't have a hw key device anymore, so no clue what these do


OK, this looks like a mistake on my part.  This bit is a little confusing because the reducer infrastructure I developed is such that there is a direct correspondence between sections of the state tree and the main reducer that manages that section.  Because of this, it made sense to have the reducers use the same name.

The little `{ currentTarget: cTarget }` bit on line 16 lets us grab the `currentTarget` value from the state under a different name (to avoid shadowing the `currentTarget` **reducer** imported in line 2.  This is all perfectly fine except for the fact that I should have passed `cTarget` when calling the `currentTarget` reducer instead of itself! (line 25)


Right!


Can you expand on this comment a bit? Is this -- the set of things moved out by that particular item?


That's sometimes but not always the case: e.g. on Unix platforms you can just `poll()` the socket and if it has been closed by the remote end you'll get that information without trying a write. A variety of similar mechanisms exist.

As far as the abstraction goes, Duktape shouldn't assume all transports can indicate an error status before a write is attempted as this may be limited by underlying APIs etc.


I don't think these lines are meant to be prefixed by `+`es. (That's fixed in ce0d769bc37f0ef481279e0ea8e2aba84fcc19b3 (PR #155).)


What does this list represent?


Nice find on the use of `URI::join`!


This commit message is probably not as clear as it could be, but it's not that big a deal.


try to create ur own validation


Yeah, good point. I was initially trying to avoid this exact code, but I couldn't find another way to override the configuration easily, since it's hardcoded. Might want to proper CSS for this eventually, but for now I'll use your suggestion.

Closed by 06a0ceddd0:

> Adjust titleBarHeight for just bootstrap-theme.


Looks like we may need a docblock for this "apply_filters":
https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#4-hooks-actions-and-filters


Shit


"strans" -> "strands"?


???ji đây

Kuls
Vào 09-03-2016 22:56, "Hoang Anh Nguyen" <notifications@github.com> đã viết:
>
> great, come on guys
>
> —
> Reply to this email directly or view it on GitHub.


Woo hoo!

At your leisure go ahead and fix the code, removing the comment I added to draw attention to the warning.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18708](https://teamcity.mesosphere.io/viewLog.html?buildId=158533&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:08:27


Thanks Patrick, good to know :-)


While this offends my sensibilities, I'll go along. But if pathogen (and vundle?) are so cool how about updating the README with (optional) instructions on using it with them.


Odpowiedzi/pytania też miały być zmiennej długości oraz niektóre bardzo długie i wieloliniowe.


Main motivation to have it disable is to let know appdash users how to do so since InfluxDB enables it by default.

But yes, totally agree on having it enabled & adding a comment, perhaps something like the following:

```go

// If you do not want metrics to be reported (see: https://docs.influxdata.com/influxdb/v0.10/administration/config/#reporting-disabled-false) uncomment the following line:
// conf.ReportingDisabled = true
```


See #83


display: inline-block не нужен тут.


Lovin' the newtyped' vecs. I've been wanting to make a macro for this pattern, too.


"explictily" Should probably be "explicitly"

I think we need "user" in there, as in:

If the user explictily chooses whether to activate


Это изменение уже закоммичено в master, но не относится к этому коммиту.


It'd be good to have a comment on this struct explaining its purpose.


i.e., "Tables that allow us to quickly map from an lvalue to its move path index."


develop (energy-plus) - Win64-Windows-7-VisualStudio-14: OK (1579 of 1579 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Все изменения в gulpfile не относятся к этому коммиту, их надо откатить.


Object spread is a proposed feature in ES7.  If eslint claims to support it then it's a bug.
Perhaps [this](https://github.com/eslint/espree/issues/129#issuecomment-95732052) might be relevant?

If all else fails, I am fine with just disabling whatever rule is making all the noise.


Initially thought this was from one of our guys, so I just removed the line. But it appears to date back to the initial creation of left_nav.php in 370671a7c3 (9 years ago).

As far as I can tell, fset.rows = rows has no side effects, so I'm not sure why it was duplicated. Should I put it back?


As I mentioned in email, the LLDB build breakage was fixed some time ago, and the bot was happy after that.


Эти изменения не относятся к этом коммиту, их надо отдельно.


Изменения в этом файле не относятся к этом коммиту, их надо отдельно.


Why don't you use the `contactsProvider` variable defined just 7 lines above here?


@anmarjarjees - Nice changes!


Makes sense, good catch. Sounds perfect to me!
On Mar 9, 2016 11:26 AM, "Chris Ramón" <notifications@github.com> wrote:

> Main motivation to have it disable is to let know appdash users how to do
> so since InfluxDB enables it by default.
>
> But yes, totally agree on having it enabled & adding a comment, perhaps
> something like the following:
>
> // If you do not want metrics to be reported (see: https://docs.influxdata.com/influxdb/v0.10/administration/config/#reporting-disabled-false) uncomment the following line:// conf.ReportingDisabled = true
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/chris-ramon/appdash/commit/ef7a19ab740b35d385c3ef2f42675b55572cded1#commitcomment-16597164>
> .
>


mind putting `handler` right at the beginning of the for loop declaration?


That's what I was getting at, sometimes the only way to know is to attempt a write, in which case the enhanced polling doesn't buy you anything unless Duktape is actually writing regularly (like it does now).


Same thing here


Jesus, sorry. Fix comes in few minutes.


Thanks! You spelt my last name wrong though, its Aderinoku**n** not Aderinoku**m** :)


separator надо задать span.


Well, while you can't write it directly, there is nothing wrong with optimizations creating MIR in the style of

```Rust
fn foo(arg0: &'a mut u32, arg1: &'b mut &'a u32) -> &'a mut u32:
    let tmp0: &'a u32;

    return = arg0;
    tmp0 = &'a *return;
    *arg1 = tmp0;
    goto return;
```

Here `return` is borrowed immutably and then returned. If we don't treat `return` as a move there will be trouble.


Зачем margin для картинки сбрасывать? Его же по умолчанию нет.


I am using V3 and I believe the issue is in URL i think I got it to work, you need to MD5 the email address and add it to URL so    list/id/members/md5(email)   I just ran one and I think it works.. I will test it few more time. will keep you posted guys


1) register view
2) user
3) validator


This breaks on Jenkins version 1.545 and the ansicolor plugin won't load.

Maybe mention in the docs that ansicolor 1.4.2+ requires jenkins 1.599 or later


Зачем font-size?


So I'll close the pull request? :)


У тебя одновременно top и margin-top, можно использовать что-то одно. Например, margin-top и убрать position и top.


What's the purpose of this channeltype? To separate radio from tv recordings in the GUI?
And how does kodi handle unknown?


Зачем процентный padding и box-sizing?


We need to update "mt_bg-color-neutral" to "mt_bgcolor--neutral"


How about using a staging repository?


revisions is actually a list of submissionFiles, right? maybe then to call it like this?


Чуть выше у тебя такой же элемент называется image. Надо сделать консистентно, или img, или image. В footer было img.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18709](https://teamcity.mesosphere.io/viewLog.html?buildId=158540&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:06


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18711](https://teamcity.mesosphere.io/viewLog.html?buildId=158549&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:13


Дневник для записей


here you could use submissionFile->getRevision(), right?


C'mon this is not necessary


Unless liquibase doesn't handle it well, i think it is preferable to make your ddl right in the xml file.  My personal preference would be adding another changeset to 20140613-add-computation but that is very debatable.


Зачем inline-block и width: 100%? Это же обычный div.


remove the extra clock rates!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!


Right, just wanted to clarify that with TCP (which you used as an example) specifically there are often cases where you can know the status without writing (because the OS will know it unless the breakage hasn't yet happened as far as things on the wire are concerned); but it depends on the API.


here you could use submissionFile->getOriginalFileName(), right?


No, there's no reason. I'll fix it in the next commit.


To keep up with the existing format of this file, do you think we should require this file within the public function include_admin_files()?


Thanks for pointing this out. I think there's some way to tell Jenkins that this version requires jenkins version X, could you track it and make a PR maybe, either way?


@mpenick what about 3.x ?


I don't understand this section. Why () over {} at line 1928? And why are both () and {} under the "good" examples in light of line 1928, since there is no regex at line 1939?


Seems unrelated to the other changes to me?


Closed by 159f5c420d4

Note: these comments were introduced in 37607af7e1 by bradymiller. In case they were important.


while (


Hmm, I'm not sure.
It is described at the wiki page. http://wiki.ros.org/dynamic_reconfigure/Tutorials/SettingUpDynamicReconfigureForANode


Turns out that commit broke our intent. So I'll have to revert it.

A reseller shouldn't be able to set their own service plans. For example, if you bought service from AT&T you can't upload your own service plan for that!

We intend to write a separate app (Service Plan Manager) that will let Reseller manage their own service plans for their sub-accounts in a better way than the current tool in Accounts Manager.

The Acc manager SP tool is a temporary hack to fulfill one of our need... Sorry about the confusion :)

If you give us your use case for that feature you wanted, we might be able to help you achieve it.


Doubt

  const Score RookOnPawn          = S( 7, 27);
  const Score RookOnPawn2          = S( 14, 54);

RookOnPawn *  2 = RookOnPawn2 = make_score(14,54)?

Regards


Each row represents a column. Again my creative naming.

The query would actually be by both datasource_ID and org. The idea is that model returns all columns but grouping happens based on URL query params. But I imagine that being done in the handler.


In any case, I'll add a note that checking the status may not be possible for all transports.


Why the panic? I guess that this is ill-typed ATM anyway.


@bushong1 Thanks and sorry for making a git mess --I am very green when it comes to merges and branches _etc_.


Whoops, sorry about that. All fixed now: https://github.com/AllThingsSmitty/css-protips/commit/704cd8470a45b9c3632cde665aed7f7a02f31fa6 .👍🏼


Still broken!

`target thumb C: libtoybox <= external/toybox/lib/dirtree.c
In file included from external/toybox/lib/args.c:12:
In file included from external/toybox/toys.h:31:
bionic/libc/include/string.h:120:14: error: conflicting types for 'basename'
extern char* basename(const char*) __RENAME(__gnu_basename) __nonnull((1));
             ^
`


Подумал, что separator можно сделать через `.promo-features__image:first-child:after` и вообще не указывать его в bemjson.


integer casts?


To keep up with the existing format of this file, do you think we should call universal_framework_configs() from Boldgrid_Inspirations_Theme_Install's add_hooks() method?


Didn't this make chrome complain last time around?


oh you're not at fault.  I was the one who screwed up like 100 times :-)

Thanks for the merge, and for the awesome app in the first place.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18710](https://teamcity.mesosphere.io/viewLog.html?buildId=158543&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:10:15


По-голямата част от промените в този файл, са предизвикани от добавянето на `Chart` компонента и са направени автоматично от Visual Studio.

Единственото изключени е `<connectionStrings>` елемента, който е добавен при добавянето на `SqlDataSource`. И при това пак е генериран от Visual Studio. Определно мързелива задача - по-голямата част от решението е написано от Visual Studio :smile:


@lbarulski ping just for info


I may have stripped this from the css but forgot the sass file


why is ramon not authoring his own commits?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18712](https://teamcity.mesosphere.io/viewLog.html?buildId=158558&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:10:04


@weavejester can you cut a release with this change when you get a chance, please?


I added an issue for now -- https://github.com/dblock/jenkins-ansicolor-plugin/issues/68


@johnno1962 Thanks!


I know HeliosSoloDeployment is only used by TemporaryJobs in the real world, but that's a bit of an implementation detail. It makes sense to clean up any leftover jobs when it gets shutdown, but maybe we shouldn't explicitly mention TemporaryJobs in the logs?


integer cast?


… behave like their related, safe variants but only when given … They differ in that they eschew


should also add a comment that we still eat this timestamp, i.e. the update is still performed.


I wonder if we should have a `DataSourceTable` model and a `DataSourceColumn` model. This way you could have table-level tags and descriptions and row-level tags and descriptions. It should also make it easier to grab and group the data when needed.


I believe you need a backslash before tcode here.  Otherwise all looks good - thanks!


When applied to (instead of 'If you supply')


me gusta tu estilo :)


oops delete file


In contrast, when the argument is not a @racket[fixnum?]


make string resource


Being able to receive several messages at once is somehow part of the keep-alive work!
This was designed as a proof of concept, and as it works I'm working on biggest changes (see [socketpool](https://github.com/eliemichel/cgru/tree/socketpool) branch, although it has been forked earlier).


He didn't know how to use git.  I did this just so I could get his initial work on github.  Any other changes he makes from now on, he will commit himself.


Asides from the missing backslash (as mentioned in my inline comment above) - the merge looks good - thank you!


I'd prefer 'humanitarian' instead of 'hot' everywhere. I'm aware of hot being the correct abbreviation, but thinking of recognizing it among a few dozen other directories 'humanitarian' seems less confusing to me.


:S


Awesome! Thank you @weavejester.


this line use the data, but data is missing in the para-list.


IINW, now you won't be able to change the margin property from _GDScript_ (`_set("anchor/left", ANCHOR_BEGIN)`) if `tools=no`. I think adding an #else that calls `set_anchor(p_margin, p_anchor)` would work.


Fair enough. I just want everyone ever to be contributing to our stuff on github :D


Give me a few minutes to upload it to Clojars. I want to make sure Travis is happy first.


`styles` надо передвинуть выше, после build-html, до watch и browser-sync


Okay, done.


Without this change, REST API calls were not possible due to difference in the Bytecode signatures of some methods used by the artifactory-jenkins plugin in conjunction with jackson-mapper-asl 1.5.1.


Thanks! I've made the other change as well (it should be deployed though).


Do you think we can find another way to determine if this is the base pageset, instead of hard coding the ids?


I think I made a mistake, 5.4 is probably better, though not super important


we should probably change this...


Эта строка и на одну выше про одно и то же, надо запускать `styles` до `enb-make`.


These should be shared in another manner.


We may want to even remove this now that we have webpack working :)


Still wont work tho, cause fuseiso is not on Jessie. Can't we just replace it with fuseiso9660 since it's on all Debian releases?


All hooks and filters are configured within this class' add_hooks() method. For consistency, should we move this add_filter there too?


This probably closes #46.


Надо слить коммиты в один и отребейзить по мастеру.


Gonna update this to `5.4.0`


> we've not been clear on what happens if the channel fails i.e. should this fail or succeed

I think `Presence.get()` should fail with an error/exception if the channel is in the `failed` state.


Yeah, it's a strange one. The error only occurs when we update the App.js file itself.
`Warning: setState(...): Cannot update during an existing state transition (such as within `render`). Render methods should be a pure function of props and state.`
The call stack is daunting (66 calls deep) and seems to wind through the redux devtools and the hot loading code.

The crux of the issue seems to be that the hot-reload essentially calls a sort of global re-`render`. Inside that, when we re-load the App.js file, it will call it's constructor and re-init the app. When the `syncActions.initRequest()` is called, it seems that the state of `storeState.working.initializingApp` gets set to true and because of that, the Connect middleware (I think - it was at the end of the `applyMiddleware` chain) in turn tries to call a 'setState' during what is essentially a `render` function and, naturally, React is less than pleased. I can't immediately figure out where the `initializingApp` value gets set or changed.


maybe to give the latest revision as argument to this JS and to have it as 'class' attribute?


I actually have a much more complete solution for your issue that I am waiting for Jack to finish shipping out all the Massdrop orders before showing him.


I could be persuaded with two models. I was thinking just setting setting column to null. But haven't thought too much in detail yet. If we have two models, we might end up querying both in a single API call. But this depends highly on what is the requirement from UI. I'm not clear yet on he flow of the new UI.

 The tags should be CSV and single word, so it is easy to separate and group.

One thing to keep in mind is that I want to keep this generic enough for other data source types too. Although that might be out of the box too.


I confirm that build is broken


Now I get the error:
CMake Error at CMakeLists.txt:41 (include):
  include could not find load file:

    bundle
should there be a bundle folder with a CMakeLists.txt and a Makefile as it is for the HelloWorld programm?


oops this was a typo. I was testing tslint. can you make a PR


A 200 response doesn't feel right here. But I'm not sure what we should respond with.

How about 418?

On a serious note possibly 401 is more correct, or 499. :-/


The wigdets you added to scr-contributors.html are not working :(


Nope.

Closed by 358080021c:

> Remove pills on history_full.


Note: the updated patch has now been merged upstream, and will be part of the upcoming EasyBuild v2.7.0, see https://github.com/hpcugent/easybuild-framework/pull/1659


Yes
This I defined in types.h

The first number (7) is the middle game score.
The second number(27) is the endgame score.
The final value will be something in between depending on game phase, etc.

So you can multiply a Score(x, y) by an integer z and result will be Score(x*z, y*z)


Looking into it a bit, object iteration isn't supported by default in ES6
(as reflected by that error message you're seeing).

I like the "for (let key of Object.keys(myObject)) { ... }" method, though
we should make sure that has the same semantics as the ES5 idiom.

On Wed, Mar 9, 2016 at 12:00 PM Alex Bigelow <notifications@github.com>
wrote:

> Stuff like
>
> myObject[Symbol.iterator] is not a function
>
> I guess there's supposed to be an Object.entries() function in ES6 that
> works kind of like Object.keys(), but I think there's some kind of
> configuration issue that we may or may not care about diving into. If not,
> we could do things in a pseudo-ES6 way (this works):
>
> for (let objKey of Object.keys(myObject)) {
>     console.log(objKey, myObject[objKey]);
> }
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Kitware/candela/commit/9d2e0f3e6e9a61e7c492ecf5120aab15a101d514#commitcomment-16594824>
> .
>


Thanks for all the helpings :)

Are `Cause`s or `SpawnCause`s mutable? I don't see anything in the API suggesting mutability and all the methods returning Causes create a new one. I just figure it's environmentally friendly to create this cause just once if possible.


Ok - will remove these - just will add a message outside the loop w/ number of retries that it did.


@asmecher, could you please take a look at this function?


You say 'port' on commit message, but to me it appears that you added options...?


@DCalliet That's because it was a useless file so I deleted it and it got dropped into our basic_classes.less file.  Please change login.less to not import header.less and then we can delete header.less for good


I couldn't find it, but figured it should be in there :)


Done in commit d5b720455fee038d6384128d3690e7ccbd0fbf12
It works. However, it doesn't look as an elegant solution.


> What's the purpose of this channeltype? To separate radio from tv recordings in the GUI?

 Exactly.

> And how does kodi handle unknown?

 unknown == tv => https://github.com/ksooo/xbmc/commit/8a04da7108d6a8be63c7680d124ac887082c22d8#diff-848cd4de41b99cb49924863a6e6d1c5aR117 (not yet PRed)


Isn't notifying bart of new coords usually an end of semester thing? Or does it not matter too much


@aprokop: Any idea what is special for the two configurations where compilation failed? Is it Epetra only?


This variable is set in almost every single function. It might be worth making it a global variable to reduce repetition.


Also +1 actually naming people (by name) who haven't done an event yet lol


lgtm


This should be ```if cursor```


So, there's no issue loading compiler_c/cxx before setting the flags? That was my doubt.

Adding a class attribute is just writing toolchain = "<toolchain>" in the class definition right?
But how would I get that definition in the toolchain tool?


Confirmed that the tests that have been removed are indeed no longer needed because the corresponding methods have been removed.


Ok


The issue with what you propose is that when we load the compiler_c/cxx tools we need to have made sure it looks for the cross-compilation ones, and that is different in GCC and Clang...
I mean, I could check `env.COMPILER_CC/CXX` but only for adding the flags, we need to set `env.CC/CXX` before loading the tools.


Кстати, может добавить в подпись в куклотреде версию скрипта: es6 или es5? Для определения можно использовать `nav.isES6`.


Not really, for two reasons:
- when the environment variables CC/CXX or `cfg.env.CC/CXX` are defined the tools don't search for the path, they only check if it's executable
- the find_realexec_path also checks if it is a symlink to a program with a different name: this was mainly done because CI setup sets a symlink for Ccache


Thank you!


Have you been looking at documentation? I think that the only thing worse than no documents is bad documents. Those are legacy options, at least since version 3.4 (and you need at least, 3.4.2, I'll make that clear in the PR), but they are still around in many places, including official documents.


Will do.


This doesn't break cross-compilation because the toolchain tool now takes care to remove them from the environment when in cross-compilation (which is the only case where we want to force a specific compiler/target). We remove them because they are set by Travis to test for Clang compilation.


No, they are not related, I just though that the mavproxy change was small enough to not warrant a different commit. I can split if you think it's best.
Regarding the change to mavproxy, it is not needed for Clang support - it was an initial change because it was needed at the time, but not now. The reason I included it is because I think we should try to migrate to Travis container-builds - and that can't have sudo. Obviously this can be included at any later time.


package is 2.0 only afaik. not yet.


Так вроде я добавлял.. Как мне кажется. Щас добавлю, если не.


added `parmetis` here from #517.


Don't know for sure, it shouldn't, but its easy to drop... I will kill it in the next commit


caught this typo in #517.


That one, leave it as it is... don't fix code style


The following doc(s) have been deployed to the [xmlsitemap](http://xmlsitemap-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/articles/sites/code/bots-and-indexing](http://xmlsitemap-static-docs.pantheonsite.io/docs/articles/sites/code/bots-and-indexing)


tau_ForskydningsSpaending refactoring


First, is it possible for you to point to me the place where generate_dynamic_reconfigure_options is implemented? I am not familiar with the ros code base.

I think that this is not finished properly when cmake continues, because when the build fails I don't see "Wrote header file in /foo/src/build/devel/include/image_view/ImageViewConfig.h" after the "Generating reconfiguration files for ImageView in image_view" message.


@cameronwong203 CAMERON.  WHY DID YOU DO THIS.  I told you not to merge shit to master, how the hell did you pull this off.  I'm gonna revoke your write permissions if you do that again haha.


Fixed per our conversation in #517.


With the ongoing work, we are becoming ready to receive data in any size the underlying system/network accepts, this series seems to go against that effort.

My question is: if the tinydtls socket informed that it has a buffer of some size (remember that COAP_UDP_MTU is an arbitrary value, chosen by yours truly), using a value smaller wouldn't mean that  I am corrupting a packet?


Damn... I knew I was going to accidentally commit that.


Why `console.log`? Is this meant to be a `report +=` line?


Fixed in 7b0df31


ah, ok, hier schaun beide gleich aus


This should remedy the discussion in #517.  @alalazo: thoughts?


it doesnt work


@DCalliet FUCK.  THIS NEVER SHOULD HAVE HAPPENED.  Cameron merged his goddamn branch with my new untested code into master 7 days ago without us noticing.  Fuck that.  Imma kill him.


No, this won't help at all. Please read my comments there.


Guys, did you think about a little inline comment for this feature so that the API doc will be populated with ?


ок, ничего криминального не нашел.


That's an interesting idea, @taion - whenever we don't actually have a key we fake it by using a hash of the current URL. I need to think about that some more, but we should probably discuss somewhere the discussion won't get lost.


I moved this lines after the `ERR_FAIL_COND(len%2);` to avoid clearing the segments if trying to resize with an odd number. This is the same behaviour as ConcavePolygonShape~~3D~~.


Good point. Its handled this way in the legacy code but a client sending an empty array here will get different behavior. Not sure if I should revert or not, maybe David can chime in.


Great to see this working. However, by allowing HTTP scripts and active content on an HTTPS page, the security of the page is essentially HTTP, so we should probably show a broken lock icon (and strikethrough the HTTPS in the urlbar location if possible). This might be confusing to users who notice that the page is HTTPS but hopefully this hack will be unnecessary soon when Twitch fixes their mixed content + HTML5 player issue.


If there's no method allowed, all are allowed. But this is not clear on doc. Maybe update doc? Anyway, is this a good behaviour? Not sure about implications, though.


@retslac Can you mind making a pull request with this on the ogar unlimited page? I want everyone else to be able to splitpop too but i dont wanna make the pull request because its not my code that made it possible


I think the move out is of `*lval`, no?


This is intentional. If `location.state` is `undefined` we can safely ignore it and not access session storage when we don't have to. Also, if state is undefined we can skip putting the key in the URL query string.


Issue5276 (wfbuhl) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


This code is OK, but it also seems like something that the MIR visitor would be good for-- but I guess we need to thread through a bit more context then? e.g., the current location


Sure, we could do that. Good catch.


Nit: move the panic! cases to the end, separate with a newline before


@smolukowski : This is my description of the project. Please feel free to change it.  :+1:


mmmmm