Не очень хорошо делать такие функции, которые изменяют свои аргументы.
Здесь лучше сделать так:

`
public String getPhoneNumber() {
  String answer;
  do {
    answer = view.getChoice(GET_PHONE_NUMBER);
  } while (!Order.isAValidPhoneNumber(answer));
  return answer;
}
`

Так метод более гранулярен, делает что-то одно.

Для создания Order лучше использовать шаблон проектирования [Builder](https://ru.wikipedia.org/wiki/Строитель_(шаблон_проектирования)) вместо собирания массива String[] из параметров.


Ah, I see. It's the transition from `AfterFirstFinal` to `AfterMissingConsonant` that drops the consonant. Since this state needs both the actual consonant *and* the `InvalidLetter` error code, the argument-free `AfterMissingConsonant` can't account for this case. (It could be fixed with `AfterMissingConsonant` taking a different initial from `IEUNG`, I guess.)

By the way, is "rora" supposed to output "ror" and "a" (i.e. prefer finals) or "ro" and "ra" (i.e. prefer initials)?


There were many instances of tuning, more or less successful against master (mostly the previous master with lower Eg values). Most common were the following:
  PawnValueMg   = 189,   PawnValueEg   = 256,
  KnightValueMg = 808,   KnightValueEg = 846,
  BishopValueMg = 835,   BishopValueEg = 858,
  RookValueMg   = 1273,  RookValueEg   = 1287,
  QueenValueMg  = 2511,  QueenValueEg  = 2562,

  MidgameLimit  = 15601, EndgameLimit  = 4001


It's a pattern we use in AbstractMutableMultimap for creating new collections of V, but it may not be necessary here.


4096 bit key is an overkill. It doesn't offer double the security, but it is costs computationally more than double. See here: https://www.gnupg.org/faq/gnupg-faq.html#please_use_ecc

>

Almost always when people use 4096-bit RSA they’re doing so because they believe RSA-4096 to be much stronger than it is. The United States’ National Institute of Standards and Technology (NIST) states that RSA-2048 gives roughly 112 bits of security and RSA-3072 gives roughly 128. There is no formal recommendation on where RSA-4096 lies, but the general consensus is that it would come in somewhere around 140 bits — 28 bits of improvement over RSA-2048. This is an improvement so marginal that it’s really not worth mentioning.

> If you need more security than RSA-2048 offers, the way to go would be to switch to elliptical curve cryptography — not to continue using RSA.


Nice job on noticing that


It is a new feature in new protocol?


So this commented code can be removed now.


Have you tested any of these on fishtest? I may consider these in a follow up test at some point


It is a new feature in client-server protocol?


sys.path.append(r'../python') try this and check


> Before the patch LXQt used "~/.config/openbox/", this is the standard path for openbox. Openbox can be used as a desktop by itself (adding some tools). I think to use "~/.config/lxqt/openbox/" it better for us, because we can change default behaviour of openbox.

-

> My fault. I write that for fast test only. I can solve it.

Of course. My point was that such a change should be properly discussed and all alternatives considered. I believe pushing such commits ad-hoc into master is not a good idea and can/will confuse users.


Great!
Thanks,
Erwin


Uploaded!


Чем этот класс отличается от BankApplicationContext? Либо понятнее имя либо явадок


Hi @timdiggins,

This was not suppose to be a refactoring but a change in how the params are mapped to approach the rails way (creating an hash with multiple different keys and turning it into an array of hashes when a key is repeated).

Example:
`one[][foo]=bar&one[][zoo]=car #=> {"one" => [{"foo" => "bar", "zoo" => "car"}]}` instead of `{"one" => [{"foo" => "bar"}, {"zoo" => "car"}]}`
`one[][foo]=bar&one[][foo]=bar&one[][zoo]=car #=> {"one" => [{"foo" => "bar"}, {"foo" => "bar", "zoo" => "car"}]}`


> Of course. My point was that such a change should be properly discussed and all alternatives considered. I believe pushing such commits ad-hoc into master is not a good idea and can/will confuse users

Second that.


решила забить на листреры?


крутая мысль)


I have not tested those on Fishtest. I am testing them locally with the aim to choose best SPSA modification.


аааа. Хорошо


hi friends,
I am new user of github and trying to learn and contribute to github.


I would recommend to load these via javascript and an array to store the countries and use country IDs instead of names. It would make it shorter, easily add more countries and make it more secure.

You could have just removed every blank line using a script :p


README


merg


please update the [META file](https://github.com/vincent-hugot/iTeML/blob/master/src/META#L1) too


такое можно и статичным сделать. Зачем каждому объекту по одинаковой строке?


noyhing 1


adgfsdh


скажите Жене чтоб такое не коммитил


просмотрено


Thanks, merged into staging.


У меня устал палец скролировать эти километры


Решила, что потренироваться работать с листенерами куда логичнее при реализации меню: там они органичны. в формате, в котором они затребованы в рамках упражнения, они наоборот, бессмысленны, чужеродны и несут функцию синтетическую.


Uploaded!


> Of course. My point was that such a change should be properly discussed and all alternatives considered. I believe pushing such commits ad-hoc into master is not a good idea and can/will confuse users

OK. I will remove the changes from the master branch and I will open a new branch.


其實我自己改了不少，等下版吧


you could have done fok@b.ot


Fair enough, a considerate approach! Would fishtest tuning progress things?


Now I am running a test which is almost an exact copy of this one:
http://tests.stockfishchess.org/tests/view/56f9210b0ebc59301a35410e
but with modified SPSA to see how the tuning methods compare.


test


Ah yes interesting, you feel there is more around the EG values?


Your comments are nonsense for this commit.


@wodka : this is why the test breaks I guess : the embedded Admin did not match the class regex previously.


현기에게 닫기를


현기야 받아줘 ..


the cast is most probably needed and the RightThing here, but maybe not the change of type to int, which is signed by default? It shouldn#t harm though


The input data could be either 2 dimensional(continuous dataxch) or 3 dimensional(epoched dataxchxtrials) data. In the beginning of the functions, add a function to check the data dimension, then make it possible to be woking on either 2 or 3 dimensional EEG data.


Piece values combined with the PP parameters are interesting idea. Sometimes tuning gives counterintuitive results. It would be interesting to see if intuitive (idea-based) tuning like that of mbootsector can beat the tuners.


команда гдето в своих полях должна сохранять контекст. Иначе анду не сделать


Looks good! Your file looks at many points more sophisticated than mine does. Should I merge your file (or at least the best points of it) into mine or will we just stick entirely to what you have written?


Doesn't this force the user to have homebrew python as opposed to system python?


インデント幅は、「2」としましょう。
http://shugo.net/ruby-codeconv/codeconv.html


Working on fixing this


I think intuition will beat values that are tuned but yet largely off optimal values. mbootsector has made an example of this I believe


What is going on?


不要です。
actionと同名のViewファイルに常に処理が流れます。


Как я понимаю форсирование связи между key и command у тебя происходит в MenuItem. Тогда этот енум получается избыточныи


ロケット表記は古い書き方のため、シンボルコロン表記に変えましょう。
       render action: 'index'


there is no harm here, and the key is only local to this block.  Anyway, the Key enum uses signed chars (I remeber changing that to signed chars...) so the later Key(key) in this block is consistent with using signed char for key.


OK


Changed back to 2015.


The parameters could be divided into essential and non-essential. Give an error or warning message if the essential parameters are missing. In the case of the non-essential parameters are missing, set those parameters as a default value.


Ditto, why are you forcing the library again?


Ох чето много сущностей. Я малость заблудился


We could do this for fields that don't influence the totals. Otherwise we need a complete page redesign (which might be too hard using just jQuery)


メソッド定義の中にはコメントは記述しないようにしましょう。
http://shugo.net/ruby-codeconv/codeconv.html


If you change 'quit' to 'exit' here there is no need to use 'pre_logout 'n'.


Why you published event block at all? It is more than enough if callback receive name of event and ready-to-use counter's delta.


ロケット表記は古いです。


qwert


просмотрено


не надо такое комитить


Makes all string type of channel variables into lower character. use a function lower(str)

ps. give a detailed comments in the source code


И?


SQL injection !


както не полноцено. Не нужно полработы комитить


Factoriser le code qui recherche un utilisateur ?


Frogs are there, the data is called 'frogs' however.


сделай тут просто return и не нужно всего что ниже тогда


And I can confirm that it works too ;)


Ah ok, I see now. Didn't see the issue at first.


because the auto detection doesn't work properly on OSX when using homebrew.


yes, but that is the default for homebrew right? I think all python related homebrew packages depend on the Python bundled with homebrew.


[R/create_ad.R:65:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_ad.R#L65) *style:* **Variable and function names should be all lowercase.**
```r
createAd <- function(body){
^~~~~~~~
```
[R/create_ad.R:66:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_ad.R#L66) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(class(body) != "list"){
    ^
```
[R/create_ad.R:69:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_ad.R#L69) *style:* **Variable and function names should be all lowercase.**
```r
  result <- createObject(body = body, object = "ad")
            ^~~~~~~~~~~~
```
[R/create_ad.R:69:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_ad.R#L69) *warning:* **no visible global function definition for ‘createObject’**
```r
  result <- createObject(body = body, object = "ad")
            ^~~~~~~~~~~~
```
[R/create_adset.R:119:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_adset.R#L119) *style:* **Variable and function names should be all lowercase.**
```r
createAdset <- function(body){
^~~~~~~~~~~
```
[R/create_adset.R:120:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_adset.R#L120) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(class(body) != "list"){
    ^
```
[R/create_adset.R:123:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_adset.R#L123) *style:* **Variable and function names should be all lowercase.**
```r
  result <- createObject(body = body, object = "adset")
            ^~~~~~~~~~~~
```
[R/create_adset.R:123:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_adset.R#L123) *warning:* **no visible global function definition for ‘createObject’**
```r
  result <- createObject(body = body, object = "adset")
            ^~~~~~~~~~~~
```
[R/create_audience.R:70:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_audience.R#L70) *style:* **Variable and function names should be all lowercase.**
```r
createAudience <- function(body){
^~~~~~~~~~~~~~
```
[R/create_audience.R:71:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_audience.R#L71) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(class(body) != "list"){
    ^
```
[R/create_audience.R:74:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_audience.R#L74) *style:* **Variable and function names should be all lowercase.**
```r
  result <- createObject(body = body, object = "audience")
            ^~~~~~~~~~~~
```
[R/create_audience.R:74:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_audience.R#L74) *warning:* **no visible global function definition for ‘createObject’**
```r
  result <- createObject(body = body, object = "audience")
            ^~~~~~~~~~~~
```
[R/create_campaign.R:54:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_campaign.R#L54) *style:* **Variable and function names should be all lowercase.**
```r
createCampaign <- function(body){
^~~~~~~~~~~~~~
```
[R/create_campaign.R:55:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_campaign.R#L55) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(class(body) != "list"){
    ^
```
[R/create_campaign.R:58:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_campaign.R#L58) *style:* **Variable and function names should be all lowercase.**
```r
  result <- createObject(body = body, object = "campaign")
            ^~~~~~~~~~~~
```
[R/create_campaign.R:58:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_campaign.R#L58) *warning:* **no visible global function definition for ‘createObject’**
```r
  result <- createObject(body = body, object = "campaign")
            ^~~~~~~~~~~~
```
[R/create_image.R:22:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_image.R#L22) *style:* **Variable and function names should be all lowercase.**
```r
createImage <- function(file){
^~~~~~~~~~~
```
[R/create_image.R:26:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_image.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
  result <- createObject(body = body, object = "image")
            ^~~~~~~~~~~~
```
[R/create_image.R:26:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_image.R#L26) *warning:* **no visible global function definition for ‘createObject’**
```r
  result <- createObject(body = body, object = "image")
            ^~~~~~~~~~~~
```
[R/create_object.R:28:6:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_object.R#L28) *style:* **Commented code should be removed.**
```r
#' # new_camp <- createCampaign(body = camp)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/create_object.R:51:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_object.R#L51) *style:* **Variable and function names should be all lowercase.**
```r
createObject <- function(object, body){
^~~~~~~~~~~~
```
[R/create_object.R:52:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_object.R#L52) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(body)){
    ^
```
[R/create_object.R:55:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_object.R#L55) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(class(body) != "list"){
    ^
```
[R/create_object.R:58:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_object.R#L58) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/create_object.R:58:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_object.R#L58) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/create_object.R:59:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_object.R#L59) *style:* **Variable and function names should be all lowercase.**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/create_object.R:59:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_object.R#L59) *warning:* **no visible global function definition for ‘checkObjects’**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/create_object.R:66:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_object.R#L66) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/create_object.R:66:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/create_object.R#L66) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/delete_ad.R:42:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_ad.R#L42) *style:* **Variable and function names should be all lowercase.**
```r
deleteAd <- function(ad.id) {
^~~~~~~~
```
[R/delete_ad.R:43:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_ad.R#L43) *style:* **Variable and function names should be all lowercase.**
```r
  result <- deleteObject(object = "ad", id = ad.id)
            ^~~~~~~~~~~~
```
[R/delete_ad.R:43:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_ad.R#L43) *warning:* **no visible global function definition for ‘deleteObject’**
```r
  result <- deleteObject(object = "ad", id = ad.id)
            ^~~~~~~~~~~~
```
[R/delete_adset.R:40:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_adset.R#L40) *style:* **Variable and function names should be all lowercase.**
```r
deleteAdset <- function(adset.id) {
^~~~~~~~~~~
```
[R/delete_adset.R:41:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_adset.R#L41) *style:* **Variable and function names should be all lowercase.**
```r
  result <- deleteObject(object = "adset", id = adset.id)
            ^~~~~~~~~~~~
```
[R/delete_adset.R:41:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_adset.R#L41) *warning:* **no visible global function definition for ‘deleteObject’**
```r
  result <- deleteObject(object = "adset", id = adset.id)
            ^~~~~~~~~~~~
```
[R/delete_audience.R:25:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_audience.R#L25) *style:* **Variable and function names should be all lowercase.**
```r
deleteAudience <- function(audience.id) {
^~~~~~~~~~~~~~
```
[R/delete_audience.R:26:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_audience.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
  result <- deleteObject(object = "audience", id = audience.id)
            ^~~~~~~~~~~~
```
[R/delete_audience.R:26:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_audience.R#L26) *warning:* **no visible global function definition for ‘deleteObject’**
```r
  result <- deleteObject(object = "audience", id = audience.id)
            ^~~~~~~~~~~~
```
[R/delete_campaign.R:34:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_campaign.R#L34) *style:* **Variable and function names should be all lowercase.**
```r
deleteCampaign <- function(campaign.id) {
^~~~~~~~~~~~~~
```
[R/delete_campaign.R:35:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_campaign.R#L35) *style:* **Variable and function names should be all lowercase.**
```r
  result <- deleteObject(object = "campaign", id = campaign.id)
            ^~~~~~~~~~~~
```
[R/delete_campaign.R:35:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_campaign.R#L35) *warning:* **no visible global function definition for ‘deleteObject’**
```r
  result <- deleteObject(object = "campaign", id = campaign.id)
            ^~~~~~~~~~~~
```
[R/delete_object.R:37:6:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_object.R#L37) *style:* **Commented code should be removed.**
```r
#' # deleteAd(ad.id = sample(ads$id, 1))
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/delete_object.R:47:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_object.R#L47) *style:* **Variable and function names should be all lowercase.**
```r
deleteObject <- function(object, id) {
^~~~~~~~~~~~
```
[R/delete_object.R:48:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_object.R#L48) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(id)){
    ^
```
[R/delete_object.R:51:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_object.R#L51) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(object)){
    ^
```
[R/delete_object.R:54:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_object.R#L54) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/delete_object.R:54:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_object.R#L54) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/delete_object.R:55:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_object.R#L55) *style:* **Variable and function names should be all lowercase.**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/delete_object.R:55:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_object.R#L55) *warning:* **no visible global function definition for ‘checkObjects’**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/delete_object.R:62:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_object.R#L62) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/delete_object.R:62:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/delete_object.R#L62) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/dict_behaviour.R:26:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_behaviour.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
dictBehaviour <- function(){
^~~~~~~~~~~~~
```
[R/dict_behaviour.R:27:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_behaviour.R#L27) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_behaviour.R:27:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_behaviour.R#L27) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_behaviour.R:29:51:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_behaviour.R#L29) *style:* **Put spaces around all infix operators.**
```r
                file.path("dict", "behavior", fsep="/"))
                                                 ~^~
```
[R/dict_behaviour.R:35:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_behaviour.R#L35) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_behaviour.R:35:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_behaviour.R#L35) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_city.R:24:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_city.R#L24) *style:* **Variable and function names should be all lowercase.**
```r
dictCity <- function(state.code){
^~~~~~~~
```
[R/dict_city.R:25:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_city.R#L25) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(state.code)){
    ^
```
[R/dict_city.R:28:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_city.R#L28) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_city.R:28:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_city.R#L28) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_city.R:37:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_city.R#L37) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/dict_city.R:37:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_city.R#L37) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/dict_city.R:38:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_city.R#L38) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_city.R:38:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_city.R#L38) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_country.R:26:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_country.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
dictCountry <- function(){
^~~~~~~~~~~
```
[R/dict_country.R:27:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_country.R#L27) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_country.R:27:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_country.R#L27) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_country.R:35:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_country.R#L35) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_country.R:35:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_country.R#L35) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_device.R:26:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_device.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
dictDevice <- function(){
^~~~~~~~~~
```
[R/dict_device.R:27:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_device.R#L27) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_device.R:27:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_device.R#L27) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_device.R:35:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_device.R#L35) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_device.R:35:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_device.R#L35) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_interest.R:27:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_interest.R#L27) *style:* **Variable and function names should be all lowercase.**
```r
dictInterest <- function(){
^~~~~~~~~~~~
```
[R/dict_interest.R:28:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_interest.R#L28) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_interest.R:28:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_interest.R#L28) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_interest.R:36:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_interest.R#L36) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_interest.R:36:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_interest.R#L36) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_language.R:29:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_language.R#L29) *style:* **Variable and function names should be all lowercase.**
```r
dictLanguage <- function(){
^~~~~~~~~~~~
```
[R/dict_language.R:30:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_language.R#L30) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_language.R:30:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_language.R#L30) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_language.R:38:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_language.R#L38) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_language.R:38:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_language.R#L38) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_os.R:26:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_os.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
dictOS <- function(){
^~~~~~
```
[R/dict_os.R:27:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_os.R#L27) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_os.R:27:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_os.R#L27) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_os.R:35:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_os.R#L35) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_os.R:35:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_os.R#L35) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_state.R:37:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_state.R#L37) *style:* **Variable and function names should be all lowercase.**
```r
dictState <- function(country.code){
^~~~~~~~~
```
[R/dict_state.R:38:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_state.R#L38) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(country.code)){
    ^
```
[R/dict_state.R:41:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_state.R#L41) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_state.R:41:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_state.R#L41) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/dict_state.R:50:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_state.R#L50) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/dict_state.R:50:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_state.R#L50) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/dict_state.R:51:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_state.R#L51) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/dict_state.R:51:59:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/dict_state.R#L51) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data, parseJSON))
                                                          ^~~~~~~~~
```
[R/get_report.R:60:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/get_report.R#L60) *style:* **Variable and function names should be all lowercase.**
```r
getReport <- function(column = c("impression", "click"),
^~~~~~~~~
```
[R/get_report.R:64:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/get_report.R#L64) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/get_report.R:64:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/get_report.R#L64) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/get_report.R:71:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/get_report.R#L71) *style:* **Variable and function names should be all lowercase.**
```r
  reportInput(body)
  ^~~~~~~~~~~
```
[R/get_report.R:71:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/get_report.R#L71) *warning:* **no visible global function definition for ‘reportInput’**
```r
  reportInput(body)
  ^~~~~~~~~~~
```
[R/get_report.R:79:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/get_report.R#L79) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/get_report.R:79:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/get_report.R#L79) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/get_report.R:80:64:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/get_report.R#L80) *style:* **Variable and function names should be all lowercase.**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data$data, parseJSON))
                                                               ^~~~~~~~~
```
[R/get_report.R:80:64:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/get_report.R#L80) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
  dat <- do.call(plyr::"rbind.fill", lapply(content$data$data, parseJSON))
                                                               ^~~~~~~~~
```
[R/get_report.R:82:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/get_report.R#L82) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(grep("^datetime$", names(dat)))){
    ^
```
[R/helpers.R:54:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L54) *style:* **Variable and function names should be all lowercase.**
```r
budgetType <- function(x){
^~~~~~~~~~
```
[R/helpers.R:57:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L57) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!x %in% valid){
    ^
```
[R/helpers.R:69:8:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L69) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:75:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L75) *style:* **Variable and function names should be all lowercase.**
```r
appType <- function(x){
^~~~~~~
```
[R/helpers.R:78:8:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L78) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:84:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L84) *style:* **Variable and function names should be all lowercase.**
```r
webType <- function(x){
^~~~~~~
```
[R/helpers.R:87:8:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L87) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:93:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L93) *style:* **Variable and function names should be all lowercase.**
```r
landingPage <- function(x){
^~~~~~~~~~~
```
[R/helpers.R:96:8:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L96) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:102:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L102) *style:* **Variable and function names should be all lowercase.**
```r
bidType <- function(x){
^~~~~~~
```
[R/helpers.R:105:8:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L105) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:111:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L111) *style:* **Variable and function names should be all lowercase.**
```r
appShowType <- function(x){
^~~~~~~~~~~
```
[R/helpers.R:113:51:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L113) *style:* **Commas should always have a space after.**
```r
  valid <- structure(c("newsfeed", "mininewsfeed","videoad", "applockerad"),
                                                  ^
```
[R/helpers.R:115:8:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L115) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:121:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L121) *style:* **Variable and function names should be all lowercase.**
```r
deliveryType <- function(x){
^~~~~~~~~~~~
```
[R/helpers.R:124:8:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L124) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:133:8:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L133) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:142:8:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L142) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:148:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L148) *style:* **Variable and function names should be all lowercase.**
```r
netType <- function(x){
^~~~~~~
```
[R/helpers.R:152:8:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L152) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:158:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L158) *style:* **Variable and function names should be all lowercase.**
```r
buttonText <- function(x){
^~~~~~~~~~
```
[R/helpers.R:162:8:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L162) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:168:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L168) *style:* **Variable and function names should be all lowercase.**
```r
switchIt <- function(x){
^~~~~~~~
```
[R/helpers.R:171:8:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L171) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/helpers.R:177:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L177) *style:* **Variable and function names should be all lowercase.**
```r
audienceCreation <- function(x){
^~~~~~~~~~~~~~~~
```
[R/helpers.R:181:8:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/helpers.R#L181) *warning:* **no visible global function definition for ‘setthat’**
```r
  x <- setthat(x, valid)
       ^~~~~~~
```
[R/list_ads.R:21:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_ads.R#L21) *style:* **Variable and function names should be all lowercase.**
```r
listAds <- function(n = 50){
^~~~~~~
```
[R/list_ads.R:22:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_ads.R#L22) *style:* **Variable and function names should be all lowercase.**
```r
  res <- listObjects(object = "ad", n = n)
         ^~~~~~~~~~~
```
[R/list_ads.R:22:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_ads.R#L22) *warning:* **no visible global function definition for ‘listObjects’**
```r
  res <- listObjects(object = "ad", n = n)
         ^~~~~~~~~~~
```
[R/list_adsets.R:21:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_adsets.R#L21) *style:* **Variable and function names should be all lowercase.**
```r
listAdsets <- function(n = 50){
^~~~~~~~~~
```
[R/list_adsets.R:22:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_adsets.R#L22) *style:* **Variable and function names should be all lowercase.**
```r
  res <- listObjects(object = "adset", n = n)
         ^~~~~~~~~~~
```
[R/list_adsets.R:22:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_adsets.R#L22) *warning:* **no visible global function definition for ‘listObjects’**
```r
  res <- listObjects(object = "adset", n = n)
         ^~~~~~~~~~~
```
[R/list_audiences.R:22:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_audiences.R#L22) *style:* **Variable and function names should be all lowercase.**
```r
listAudiences <- function(n = 50){
^~~~~~~~~~~~~
```
[R/list_audiences.R:23:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_audiences.R#L23) *style:* **Variable and function names should be all lowercase.**
```r
  res <- listObjects(object = "audience", n = n)
         ^~~~~~~~~~~
```
[R/list_audiences.R:23:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_audiences.R#L23) *warning:* **no visible global function definition for ‘listObjects’**
```r
  res <- listObjects(object = "audience", n = n)
         ^~~~~~~~~~~
```
[R/list_campaigns.R:21:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_campaigns.R#L21) *style:* **Variable and function names should be all lowercase.**
```r
listCampaigns <- function(n = 50){
^~~~~~~~~~~~~
```
[R/list_campaigns.R:22:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_campaigns.R#L22) *style:* **Variable and function names should be all lowercase.**
```r
  res <- listObjects(object = "campaign", n = n)
         ^~~~~~~~~~~
```
[R/list_campaigns.R:22:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_campaigns.R#L22) *warning:* **no visible global function definition for ‘listObjects’**
```r
  res <- listObjects(object = "campaign", n = n)
         ^~~~~~~~~~~
```
[R/list_images.R:21:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_images.R#L21) *style:* **Variable and function names should be all lowercase.**
```r
listImages <- function(n = 50){
^~~~~~~~~~
```
[R/list_images.R:22:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_images.R#L22) *style:* **Variable and function names should be all lowercase.**
```r
  res <- listObjects(object = "image", n = n)
         ^~~~~~~~~~~
```
[R/list_images.R:22:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_images.R#L22) *warning:* **no visible global function definition for ‘listObjects’**
```r
  res <- listObjects(object = "image", n = n)
         ^~~~~~~~~~~
```
[R/list_object.R:44:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_object.R#L44) *style:* **Variable and function names should be all lowercase.**
```r
listObjects <- function(object, n = 50){
^~~~~~~~~~~
```
[R/list_object.R:46:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_object.R#L46) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(object)) {
    ^
```
[R/list_object.R:48:12:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_object.R#L48) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  } else if(length(object) > 1){
           ^
```
[R/list_object.R:51:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_object.R#L51) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/list_object.R:51:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_object.R#L51) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/list_object.R:52:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_object.R#L52) *style:* **Variable and function names should be all lowercase.**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/list_object.R:52:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_object.R#L52) *warning:* **no visible global function definition for ‘checkObjects’**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/list_object.R:58:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_object.R#L58) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/list_object.R:58:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_object.R#L58) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/list_object.R:59:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_object.R#L59) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(content$data)) {
    ^
```
[R/list_object.R:60:66:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_object.R#L60) *style:* **Variable and function names should be all lowercase.**
```r
    dat <- do.call(plyr::"rbind.fill", lapply(content$data$data, parseJSON))
                                                                 ^~~~~~~~~
```
[R/list_object.R:60:66:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_object.R#L60) *warning:* **no visible binding for global variable ‘parseJSON’**
```r
    dat <- do.call(plyr::"rbind.fill", lapply(content$data$data, parseJSON))
                                                                 ^~~~~~~~~
```
[R/list_object.R:61:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_object.R#L61) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    while(nrow(dat) < n && length(content$data$next_page_url)) {
         ^
```
[R/list_object.R:68:53:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/list_object.R#L68) *style:* **Variable and function names should be all lowercase.**
```r
                          lapply(content$data$data, parseJSON))
                                                    ^~~~~~~~~
```
[R/map.R:66:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/map.R#L66) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(campaigns)){
    ^
```
[R/map.R:69:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/map.R#L69) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(adsets)){
    ^
```
[R/map.R:72:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/map.R#L72) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(ads)){
    ^
```
[R/map.R:75:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/map.R#L75) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(audiences)){
    ^
```
[R/orion_auth.R:47:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/orion_auth.R#L47) *style:* **Variable and function names should be all lowercase.**
```r
orionOAuth <- function (client.id, client.secret,
^~~~~~~~~~
```
[R/orion_auth.R:50:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/orion_auth.R#L50) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(client.id)){
    ^
```
[R/orion_auth.R:65:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/orion_auth.R#L65) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(return)
  ^~~~~~~~~~
```
[R/orion_auth.R:65:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/orion_auth.R#L65) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(return)
  ^~~~~~~~~~
```
[R/orion_auth.R:66:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/orion_auth.R#L66) *style:* **Variable and function names should be all lowercase.**
```r
  constructCred(return, pars = list(client.id = client.id,
  ^~~~~~~~~~~~~
```
[R/orion_auth.R:69:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/orion_auth.R#L69) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(save == TRUE){
    ^
```
[R/orion_auth.R:70:44:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/orion_auth.R#L70) *style:* **Put spaces around all infix operators.**
```r
    credentials <- get("credentials", envir=cred_env)
                                          ~^~
```
[R/orion_auth.R:70:45:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/orion_auth.R#L70) *warning:* **no visible binding for global variable ‘cred_env’**
```r
    credentials <- get("credentials", envir=cred_env)
                                            ^~~~~~~~
```
[R/orion_auth.R:72:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/orion_auth.R#L72) *style:* **lines should not be more than 80 characters.**
```r
    credentials$client.secret <- charToRaw(as.character(credentials$client.secret))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/print.R:2:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/print.R#L2) *style:* **Variable and function names should be all lowercase.**
```r
print.orionToken <- function(x, ...) {
^~~~~~~~~~~~~~~~
```
[R/show_ad.R:25:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_ad.R#L25) *style:* **Variable and function names should be all lowercase.**
```r
showAd <- function(ad.id){
^~~~~~
```
[R/show_ad.R:26:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_ad.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
  res <- showObject(object = "ad", id = ad.id)
         ^~~~~~~~~~
```
[R/show_ad.R:26:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_ad.R#L26) *warning:* **no visible global function definition for ‘showObject’**
```r
  res <- showObject(object = "ad", id = ad.id)
         ^~~~~~~~~~
```
[R/show_adset_audience.R:27:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_adset_audience.R#L27) *style:* **Variable and function names should be all lowercase.**
```r
showAdsetAudience <- function(adset.id){
^~~~~~~~~~~~~~~~~
```
[R/show_adset_audience.R:28:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_adset_audience.R#L28) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(adset.id)){
    ^
```
[R/show_adset_audience.R:31:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_adset_audience.R#L31) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/show_adset_audience.R:31:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_adset_audience.R#L31) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/show_adset_audience.R:40:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_adset_audience.R#L40) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/show_adset_audience.R:40:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_adset_audience.R#L40) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/show_adset.R:25:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_adset.R#L25) *style:* **Variable and function names should be all lowercase.**
```r
showAdset <- function(adset.id){
^~~~~~~~~
```
[R/show_adset.R:26:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_adset.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
  res <- showObject(object = "adset", id = adset.id)
         ^~~~~~~~~~
```
[R/show_adset.R:26:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_adset.R#L26) *warning:* **no visible global function definition for ‘showObject’**
```r
  res <- showObject(object = "adset", id = adset.id)
         ^~~~~~~~~~
```
[R/show_audience.R:25:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_audience.R#L25) *style:* **Variable and function names should be all lowercase.**
```r
showAudience <- function(audience.id){
^~~~~~~~~~~~
```
[R/show_audience.R:26:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_audience.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
  res <- showObject(object = "audience", id = audience.id)
         ^~~~~~~~~~
```
[R/show_audience.R:26:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_audience.R#L26) *warning:* **no visible global function definition for ‘showObject’**
```r
  res <- showObject(object = "audience", id = audience.id)
         ^~~~~~~~~~
```
[R/show_campaign.R:25:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_campaign.R#L25) *style:* **Variable and function names should be all lowercase.**
```r
showCampaign <- function(campaign.id){
^~~~~~~~~~~~
```
[R/show_campaign.R:26:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_campaign.R#L26) *style:* **Variable and function names should be all lowercase.**
```r
  res <- showObject(object = "campaign", id = campaign.id)
         ^~~~~~~~~~
```
[R/show_campaign.R:26:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_campaign.R#L26) *warning:* **no visible global function definition for ‘showObject’**
```r
  res <- showObject(object = "campaign", id = campaign.id)
         ^~~~~~~~~~
```
[R/show_object.R:51:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_object.R#L51) *style:* **Variable and function names should be all lowercase.**
```r
showObject <- function(object, id){
^~~~~~~~~~
```
[R/show_object.R:52:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_object.R#L52) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(id)){
    ^
```
[R/show_object.R:55:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_object.R#L55) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(object)){
    ^
```
[R/show_object.R:58:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_object.R#L58) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/show_object.R:58:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_object.R#L58) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/show_object.R:59:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_object.R#L59) *style:* **Variable and function names should be all lowercase.**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/show_object.R:59:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_object.R#L59) *warning:* **no visible global function definition for ‘checkObjects’**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/show_object.R:67:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_object.R#L67) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/show_object.R:67:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/show_object.R#L67) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/update_ad.R:57:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_ad.R#L57) *style:* **Variable and function names should be all lowercase.**
```r
updateAd <- function(ad.id, body){
^~~~~~~~
```
[R/update_ad.R:58:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_ad.R#L58) *style:* **Variable and function names should be all lowercase.**
```r
  res <- updateObject(object = "ad", body = body, id = ad.id)
         ^~~~~~~~~~~~
```
[R/update_ad.R:58:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_ad.R#L58) *warning:* **no visible global function definition for ‘updateObject’**
```r
  res <- updateObject(object = "ad", body = body, id = ad.id)
         ^~~~~~~~~~~~
```
[R/update_adset.R:102:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_adset.R#L102) *style:* **Variable and function names should be all lowercase.**
```r
updateAdset <- function(adset.id, body){
^~~~~~~~~~~
```
[R/update_adset.R:103:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_adset.R#L103) *style:* **Variable and function names should be all lowercase.**
```r
  res <- updateObject(object = "adset", body = body, id = adset.id)
         ^~~~~~~~~~~~
```
[R/update_adset.R:103:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_adset.R#L103) *warning:* **no visible global function definition for ‘updateObject’**
```r
  res <- updateObject(object = "adset", body = body, id = adset.id)
         ^~~~~~~~~~~~
```
[R/update_audience.R:65:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_audience.R#L65) *style:* **Variable and function names should be all lowercase.**
```r
updateAudience <- function(audience.id, body){
^~~~~~~~~~~~~~
```
[R/update_audience.R:66:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_audience.R#L66) *style:* **Variable and function names should be all lowercase.**
```r
  res <- updateObject(object = "audience", body = body, id = audience.id)
         ^~~~~~~~~~~~
```
[R/update_audience.R:66:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_audience.R#L66) *warning:* **no visible global function definition for ‘updateObject’**
```r
  res <- updateObject(object = "audience", body = body, id = audience.id)
         ^~~~~~~~~~~~
```
[R/update_campaign.R:46:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_campaign.R#L46) *style:* **Variable and function names should be all lowercase.**
```r
updateCampaign <- function(campaign.id, body){
^~~~~~~~~~~~~~
```
[R/update_campaign.R:47:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_campaign.R#L47) *style:* **Variable and function names should be all lowercase.**
```r
  res <- updateObject(object = "campaign", body = body, id = campaign.id)
         ^~~~~~~~~~~~
```
[R/update_campaign.R:47:10:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_campaign.R#L47) *warning:* **no visible global function definition for ‘updateObject’**
```r
  res <- updateObject(object = "campaign", body = body, id = campaign.id)
         ^~~~~~~~~~~~
```
[R/update_object.R:26:6:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_object.R#L26) *style:* **Commented code should be removed.**
```r
#' # update <- updateAdset(adset.id = adsets$id[1], body = settings)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/update_object.R:50:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_object.R#L50) *style:* **Variable and function names should be all lowercase.**
```r
updateObject <- function(object, body, id){
^~~~~~~~~~~~
```
[R/update_object.R:51:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_object.R#L51) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(body)){
    ^
```
[R/update_object.R:54:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_object.R#L54) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(class(body) != "list"){
    ^
```
[R/update_object.R:57:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_object.R#L57) *style:* **Variable and function names should be all lowercase.**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/update_object.R:57:11:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_object.R#L57) *warning:* **no visible global function definition for ‘orionToken’**
```r
  cred <- orionToken()
          ^~~~~~~~~~
```
[R/update_object.R:58:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_object.R#L58) *style:* **Variable and function names should be all lowercase.**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/update_object.R:58:13:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_object.R#L58) *warning:* **no visible global function definition for ‘checkObjects’**
```r
  object <- checkObjects(object)
            ^~~~~~~~~~~~
```
[R/update_object.R:67:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_object.R#L67) *style:* **Variable and function names should be all lowercase.**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/update_object.R:67:3:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/update_object.R#L67) *warning:* **no visible global function definition for ‘testReturn’**
```r
  testReturn(content)
  ^~~~~~~~~~
```
[R/utils.R:3:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L3) *style:* **Variable and function names should be all lowercase.**
```r
constructCred <- function(json, pars) {
^~~~~~~~~~~~~
```
[R/utils.R:14:46:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L14) *warning:* **no visible binding for global variable ‘cred_env’**
```r
  assign("credentials", credentials, envir = cred_env)
                                             ^~~~~~~~
```
[R/utils.R:17:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L17) *style:* **Variable and function names should be all lowercase.**
```r
testReturn <- function(content) {
^~~~~~~~~~
```
[R/utils.R:19:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L19) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(content$status != 200 && content$status == 422){
    ^
```
[R/utils.R:28:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L28) *style:* **Variable and function names should be all lowercase.**
```r
orionToken <- function() {
^~~~~~~~~~
```
[R/utils.R:29:51:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L29) *style:* **Put spaces around all infix operators.**
```r
  credentials <- tryCatch(get("credentials", envir=cred_env),
                                                 ~^~
```
[R/utils.R:31:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L31) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(is(credentials, "error") && file.exists(".orionToken")){
    ^
```
[R/utils.R:35:48:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L35) *warning:* **no visible binding for global variable ‘cred_env’**
```r
    assign("credentials", credentials, envir = cred_env)
                                               ^~~~~~~~
```
[R/utils.R:39:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L39) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(credentials$expires_in_date <= Sys.time()) {
    ^
```
[R/utils.R:40:20:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L40) *style:* **Variable and function names should be all lowercase.**
```r
    credentials <- orionOAuth(credentials$client.id,
                   ^~~~~~~~~~
```
[R/utils.R:46:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L46) *style:* **Variable and function names should be all lowercase.**
```r
checkObjects <- function(objects){
^~~~~~~~~~~~
```
[R/utils.R:49:7:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L49) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(x %in% valid == FALSE){
      ^
```
[R/utils.R:57:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L57) *style:* **Variable and function names should be all lowercase.**
```r
parseJSON <- function(data){
^~~~~~~~~
```
[R/utils.R:63:1:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L63) *style:* **Variable and function names should be all lowercase.**
```r
reportInput <- function(body){
^~~~~~~~~~~
```
[R/utils.R:66:55:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L66) *style:* **Commas should always have a space after.**
```r
  groups <- c("datetime", "age", "gender", "location","brand", "ad", "adset",
                                                      ^
```
[R/utils.R:69:7:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L69) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!x %in% col) {
      ^
```
[R/utils.R:75:7:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L75) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!x %in% groups) {
      ^
```
[R/utils.R:80:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L80) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(body$groupby) == 1) {
    ^
```
[R/utils.R:83:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L83) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(body$column) == 1) {
    ^
```
[R/utils.R:89:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L89) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(x) > 1){
    ^
```
[R/utils.R:92:5:](https://github.com/JohnCoene/oRion/blob/4816789c34ea876f0a7fa22ec5f95eb0cf9ea91d/R/utils.R#L92) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!x %in% valid){
    ^
```


из названий не видно что происходит после пользовательского ввода. Сейчас как будто ничего. Однако на этом уровне абстракции хорошо б чтоб было видно


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 20122](https://teamcity.mesosphere.io/viewLog.html?buildId=182563&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 267 Build time: 00:09:38


Possible to revert this one?

It makes the poller.php not process datasources. Realtime stop working aswell. They are enabled but poller.php only gives:

"There are no items in your poller for this polling cycle"


Wow, good news :+1:


See this pending pull request for a followup:

https://github.com/ceph/ceph/pull/7712

I'm using that patch against 0.94.6 and a current aws cli and it works. I do however still see subtle encoding differences, but the way aws cli works will be compatible here. Originally aws cli just unencoded everything no matter what, now it's decoding is predicated on the encodingtype chunk.


Я бы собирал меню прям в командре. чтоб меню не знало из каких элементов оно состоит


Symbolic Links, both to directories and to files, are absolutely not a problem in Windows XP / Server 2003 (and even Windows 2000). FAR Manager (the most powerful of Norton Commander-like shells) is able to create them.

Yes, there is no CreateSymbolicLink() API function, but all types of Reparse Points can be created and deleted via DeviceIoControl()  FSCTL_SET_REPARSE_POINT / FSCTL_GET_REPARSE_POINT / FSCTL_DELETE_REPARSE_POINT

In fact, DeviceIoControl() and struct REPARSE_DATA_BUFFER methods, being somewhat tricky, are more generic and provide more capabilities.

A small driver is required to ACCESS (not to create/change/delete) symbolic links in Windows 2003 / XP / 2000. 32-bit and 64-bit versions exist.
http://web.archive.org/web/20160305095134/http://emk.name/
http://web.archive.org/web/20160305095134/http://emk.name/symlink-1.06-x86.cab

Access to directory junctions (very similar to directory symlinks) does not require this driver.

Support for XP and Server 2003 (which is PAE-enabled and not limited to use only 3 GB physical memory, remaining in practice fully compatible with XP 32-bit - all games work), is important because they are the last lightweight, non-bloatware OSes (Vista and later are bloatware, and modern Linuxes are bloatware). Trying to draw a parallel with Win9x is essentially incorrect.


Midterm soru dosyanız, çalışmanızı yaparken bu dosyayı doldurunuz.


Итераторы стиль явы 1.4 ( тоесть лет 6 назад)


Please fill out an issue at https://github.com/TrinityCore/TrinityCore/issues/new.


Pourquoi ne pas utiliser http://api.jquery.com/jQuery.ajax/ ?
Ou faire une fonction ?


CRC isn't used in code of your test.
Remove macros DATA* with _Z suffix. Leave only DATA* macros without _Z suffix. Hide crc variable from user.
Use gcc anonymous functions for that.


let's play the party crasher here, I would prefer the autodispacher.hpp include to be after the scalar one.


```javascript
var firstbattle;
function firstbattlefunc() {
    firstbattle = prompt('Menu: Would you like to Attack, Special or Flee?').toLowerCase();
}
```


Nice !
Now we know that 26 is too high, and from the struggling test that 11 might not be the best value too.


просмотрено


I stopped the tuning because of incorrect input parameters.


@luiges90 我看到了，我想先把29的事件弄好，出个稳定版


имя банка включено в equals и  hashCode?


typo in comment (I can fix the comments myself, but after lunch ;-)


I'm trying to figure out which test broke - it should only set the group and label if it can find a match based on the entity class name


@luiges90  事件不显示对话不知道哪里出的问题


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 20123](https://teamcity.mesosphere.io/viewLog.html?buildId=182574&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:12


Could it be that you need to update your Qt? The layout works fine when inserted into the current 2.1 builds, which use Qt 5.5.1.


оххх. повысь читабельность этого фрагмента. Сложно


IIRC you can use STF_PASS("A Message"); instead of this


this enforces >=1.3.1 which introduces some Bower conflicts. Wouldn't the same range work as expected (iron-flex-layout#^1.0.0) ?


this shadows a local variable inside stf.hpp. Not sue which one (this or STF's) to rename.


What's the ambiguity here? "which" possibly referring to "it"?


pstree_cont - a script that sends SIGCONT signal to each process in a process tree. PID of process tree root is passed as the first script argument.


<pid> => <root_pid>


Если файл класса больше 100 строк - это знак что пора рефакторить. Разбивай его на части. Тогда просмотрю


*Философски* наш волшебный видеоурок говорит нам использовать итераторы. Есть способ получше? Подскажи :)


@salkinium Yes, I was using the env.Program emitter. Ask me again any time after Thursday, then I should have time to integrate my solution.


То что не относится к Commander можно было вынести в другой коммит. Потому что это логически другой кусок работы


android


так мож проще занаследоваться? Зачем статика?


测试分支


@esteele Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.autoform/8/violations
```
plone/autoform/base.py:0:1: I001 isort found changes, run it on the file
plone/autoform/base.py:23:1: C901 'AutoFields.updateFieldsFromSchemata' is too complex (11)
plone/autoform/directives.py:123:30: Q000 Remove bad quotes.
plone/autoform/directives.py:123:31: S001 found %s formatter
plone/autoform/form.py:0:1: I001 isort found changes, run it on the file
plone/autoform/form.py:22:13: Q000 Remove bad quotes.
plone/autoform/interfaces.py:0:1: I001 isort found changes, run it on the file
plone/autoform/supermodel.py:0:1: I001 isort found changes, run it on the file
plone/autoform/supermodel.py:51:25: Q000 Remove bad quotes.
plone/autoform/supermodel.py:51:26: S001 found %s formatter
plone/autoform/supermodel.py:61:17: Q000 Remove bad quotes.
plone/autoform/supermodel.py:62:17: S001 found % formatter
plone/autoform/supermodel.py:69:1: C901 'FormSchema.read' is too complex (11)
plone/autoform/supermodel.py:104:34: Q000 Remove bad quotes.
plone/autoform/supermodel.py:104:67: S001 found %s formatter
plone/autoform/supermodel.py:109:1: C901 'FormSchema.write' is too complex (14)
plone/autoform/supermodel.py:143:25: Q000 Remove bad quotes.
plone/autoform/supermodel.py:143:26: S001 found %s formatter
plone/autoform/supermodel.py:146:55: Q000 Remove bad quotes.
plone/autoform/supermodel.py:151:25: Q000 Remove bad quotes.
plone/autoform/supermodel.py:151:26: S001 found %s formatter
plone/autoform/supermodel.py:156:17: Q000 Remove bad quotes.
plone/autoform/testing.py:0:1: I001 isort found changes, run it on the file
plone/autoform/testing.py:2:1: F401 'Layer' imported but unused
plone/autoform/testing.py:12:10: Q000 Remove bad quotes.
plone/autoform/testing.py:16:10: Q000 Remove bad quotes.
plone/autoform/utils.py:0:1: I001 isort found changes, run it on the file
plone/autoform/utils.py:118:1: C901 'processFields' is too complex (19)
plone/autoform/view.py:0:1: I001 isort found changes, run it on the file
plone/autoform/widgets.py:0:1: I001 isort found changes, run it on the file
plone/autoform/widgets.py:69:17: S001 found %s formatter
plone/autoform/widgets.py:81:22: Q000 Remove bad quotes.
plone/autoform/widgets.py:81:23: S001 found %s formatter
plone/autoform/widgets.py:95:30: Q000 Remove bad quotes.
plone/autoform/widgets.py:95:31: S001 found %s formatter
plone/autoform/tests/test_directives.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_doctests.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_supermodel_handler.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_supermodel_handler.py:39:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:40:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:42:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:42:52: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:43:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:43:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:44:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:44:54: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:46:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:47:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:82:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:83:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:85:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:85:53: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:86:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:86:56: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:87:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:87:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:90:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:90:53: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:91:28: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:91:56: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:136:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:137:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:140:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:141:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:146:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:147:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:148:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:151:16: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:152:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:153:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:244:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:245:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:245:52: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:246:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:246:54: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:248:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:249:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:270:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:271:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:272:26: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:272:55: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:273:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:284:51: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:285:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:286:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:287:50: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:315:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:316:32: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:319:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:320:32: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:324:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:325:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:326:32: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:329:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:330:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:331:32: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:416:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:416:63: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:417:27: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:417:64: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:459:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:460:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:463:13: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:464:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:480:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:484:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:498:31: Q000 Remove bad quotes.
plone/autoform/tests/test_supermodel_handler.py:502:31: Q000 Remove bad quotes.
plone/autoform/tests/test_utils.py:0:1: I001 isort found changes, run it on the file
plone/autoform/tests/test_utils.py:21:23: Q000 Remove bad quotes.
plone/autoform/tests/test_widgets.py:0:1: I001 isort found changes, run it on the file
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


where is except? error should be printed to user


Thanks Dom.


не надо такое комитить


pid => root_pid


See differently maybe? Our Monitors are different...xD


分支测试


Методы, название которых заканчивается на `?`, должны возвращать true/false — таковы соглашения и ожидания. Если возвращают что-то другое — вопр.знак лучше убрать.


I looked at them :p


Uploaded!


String


This isn't ready to be merged yet.


Haha... Yes @schwaberdoodles  and I saw it, too. I'll add to the note!


Please fix and provide the result as a single commit (as you've done with this one).


c


Also fixed the def plan function


Это довольно сложно, а зачем там flatten? И зачем склеивать всё в строку перед проверкой `include?`?


@tkshimada0912, AWS does the same thing!

```
$ cat ~/.aws/credentials
[default]
aws_access_key_id = AKI***********
aws_secret_access_key = G+N7St*****************************
```


@petester42 do you understand why is Travis failing?
https://travis-ci.org/danielgindi/ios-charts


@eabatalov as you told we could either print error either raise exception (raise here means `don't catch`). So why is this approach (I jast throw exception) is bad now?


Done.


Looks like C isn't used in this class either and could be removed.


Released 1.1.0


Do not use isset! It is so slow


The method `addServers` is accepting an array of servers.
http://php.net/manual/en/memcached.addservers.php


I confirm.
This version is breaking our current run - using a precedent release now


These constructors could take MutableBagIterableMultimap. Once C is removed, this class (and other abstract classes like it) might not be necessary.


кстати, тут с инкапсуляцией всё ок (вынесено в отдельный класс), а с эффективностью не оч: на каждом вызове already_seen заново создаётся SeenMoviesList, и считывается файл. (а также не называй переменные транслитом!!!)


Isn't a use of `system` missing here?


TeamCity jonas-requests :: WindowsBuild [Build 46](https://build.neohq.net/viewLog.html?buildId=613665&buildTypeId=JonasHaRequests_WindowsBuild) is now running


believe it was earlier 'exit', 'exit' if you look at the history of the model. Then it was changed to 'quit'.


@eabatalov ok, but I actually don't see the difference


awesome work, mie


You're right. Agree with you.


@murrant supposedly 'quit' gives us prompt to save config or not? As per ef121cd32 @paszczus noticed this in his edgeswitch.

So should we do
 1. quit + n
 2. exit + exit
 3. something else?


@eabatalov oh wait. It's not the last commit.


Weirdly, tests pass on my local box but fail on Travis-CI.


Yes. Right now it looks like 'exit', 'exit' is better then 'quit':

https://community.ubnt.com/t5/EdgeSwitch/BUG-Entering-enable-is-treated-as-config-change/m-p/1521858#M6458


This was a bug in node_redis and it's fixed in newer versions


oups! thx for catching :)


test commit


@eabatalov here is the final version with all fixes


Archivo borrado sin importancia


About the `aliyuncli`, I guess the version does not relate to available SDKs.

I did a LOT of installation using this command
```
$ sudo pip install aliyun-python-sdk-<Module Name>
```
So with the same `aliyuncli` version of 2.1.2, mine looks like this:
```
$ aliyuncli
usage: aliyuncli <command> <operation> [options and parameters]
<aliyuncli> the valid command as follows:

aas                                      	| acs
batchcompute                             	| bss
cdn                                      	| cms
ecs                                      	| ess
mts                                      	| oms
oss                                      	| r-kvstore
ram                                      	| rds
ros                                      	| slb
sts                                      	| yundun
```


reverted


@muneeb2542 I noticed this just now, what is the reason to check if the camera is discoverable when generating the thumbnail url?


In previous review I've written you that you need to choose a single way of error reporting.
You still use error codes and exceptions. As python uses exceptions let's use them too. Please report your error as exceptions. Remove pr_err() func.
Read https://jeffknupp.com/blog/2013/02/06/write-cleaner-python-use-exceptions/


I think these minor changes that don't affect the program it's used in should be minor versions. I think `npm install --save` adds the dependency to install the latest minor version by default


@eabatalov oh, ok.


I suggest two simple statements instead of complex.


No problem here, using OpenPLi 4 (and OpenPLi 5)


@eabatalov oh, not final as for your last comment about exceptions to the previous commit


Another solution, using the properties of the timestamps:
```
link_target=`ls -1 $BACKUP_DIR | tail -n1`
```


Indeed, I'll add the connection.escape() method of node-mysql, thanks :)


Country IDs? I'm afraid I'm not familiar with that term.


Wtf happened here??!!


Mmmmmmmmmmmmm esto pide a gritos ser un parametro configurable externo


So nice


You should add 'const' here.


>I think  API_VERSION_MIN  needs bumping also with this change, correct?

This commit doesn't break backward compatibility since old clients can simply ignore new fields.
>But I realized I need to bump the API version too.

If you didn't do it already after v3.3.3.


cc @bestander probably this should be cherry-picked?


You should insert a dummy character (e.g. `?`) instead of throwing it away.


Looks good


I will get all of them


This is uncommon; you don't need to map getY here. Just do `r2 <- getY`, and then do the calculation in the yield: `yield r1 * r2` :)


Jahe, follow back urang haha


Yeh it does I think this is classed as a minor version, and major is bumping the first number.

To update I run either 'npm version minor' or 'npm version major'. I think the last number is for patches which should be when no new functionality is added, just a bug fix. (npm version patch)

https://docs.npmjs.com/cli/version

> On 29 Mar 2016, at 12:42, Josh Hodgson <notifications@github.com> wrote:
>
> I think these minor changes that don't affect the program it's used in should be minor versions. I think npm install --save adds the dependency to install the latest minor version by default
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
>


A faire en effet, je factoriserai ce que je pourrai lorsque les principales fonctionnalités seront dispo. Il y a pas mal de boulot sur ce point je pense ;)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 20124](https://teamcity.mesosphere.io/viewLog.html?buildId=182598&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 267 Build time: 00:06:35


Obsolete line


## the inverse of the matrix need to have the same size of x
  i <- NULL
  set <- function(y) {
    x <<- y
    i <<- x<-NULL
  }
  get <- function() x
  setinverse <- function(inverse) i <<- inverse
  getinverse <- function() i
  list(set = set, get = get,
       setinverse = setinverse,
       getinverse = getinverse)


Nice job :)


Denne patchen slenger med fylkesordfører og fylkesvaraordfører


So actually this probably should have been a patch :)

> On 29 Mar 2016, at 12:42, Josh Hodgson <notifications@github.com> wrote:
>
> I think these minor changes that don't affect the program it's used in should be minor versions. I think npm install --save adds the dependency to install the latest minor version by default
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
>


Nice work @farhadmaster!

Recommendation: next time clean up a bit before committing :)


General notes:
We might borrow the read-only approach from [here](http://www.mikerubel.org/computers/rsync_snapshots/). We might use [this] in the documentation (if needed).
Questions/answers:
- Q: How to protect against corruption at the origin?
- Q: How to protect against corruption at the destination?


dsfsdfsdfsdf


OK, thanks. I will have a look at it and see how we can optimize the default values


well done ;o)


This function creates a special "matrix" object that can cache its inverse.


Alright, this is now fixed.


Cache the inverse of a matrix


Done.


##Matrix inversion is usually a costly computation and there may be some benefit to caching the inverse of a matrix rather than compute it repeatedly


Hi,
I agree this needs to be improved in future releases. I hope 3.0.0 will be a new milestone where things get a bit more formalized.

Appreciate the feedback!


stacks up refresh calls


  i <- NULL
  set <- function(y) {
    x <<- y
    i <<- NULL
  }
  get <- function() x
  setinverse <- function(inverse) i <<- inverse
  getinverse <- function() i
  list(set = set, get = get,
       setinverse = setinverse,
       getinverse = getinverse)


##This function computes the inverse of the special "matrix" returned by makeCacheMatrix above. If the inverse has already been calculated (and the matrix has not changed), then the cachesolve should retrieve the inverse from the cache.


W


i <- x$getinverse()
  if(!is.null(i)) {
    message("getting cached data")
    return(i)
  }
  data <- x$get()
  i <- solve(data, ...)
  x$setinverse(i)
  i


On 03/29/2016 02:02 PM, Dimitry Sibiryakov wrote:
> Why you published event block at all? It is more than enough if callback receive name of event and ready-to-use counter's delta.

The problem I see with this is that callback is true AST call - it's
invoked in dedicated thread and not synchronized with worker thread in
any way. I.e. (like any other AST) it can only set some flag and save
data in temporary buffer, real processing (and reactivation of event)
should be done in worker thread. I.e. we anyway need intermediate
buffer. And in that case it makes no big difference in what format that
buffer represents data, may be even better to use internal format to
help avoid desire to do something with received data in callback function.


thanks, @satya164, it is in the list for picking https://github.com/facebook/react-native/issues/6559


hi I think I'm having a problem with this commit, here is the error
 Failed to execute goal org.codehaus.mojo:hibernate3-maven-plugin:2.2:hbm2ddl (default) on project SimpleContentPortlet: Execution default of goal org.codehaus.mojo:hibernate3-maven-plugin:2.2:hbm2ddl failed: An API incompatibility was encountered while executing org.codehaus.mojo:hibernate3-maven-plugin:2.2:hbm2ddl: java.lang.NoSuchMethodError: org.slf4j.helpers.MessageFormatter.arrayFormat(Ljava/lang/String;[Ljava/lang/Object;)Lorg/slf4j/helpers/FormattingTuple;


Pour pinailler car `active_support` essaie de s'inspirer du langage naturel.

```ruby
0.minutes
1.minute
2.minutes
```

Et pourquoi ce `Sale.find` alors que vous l'avez juste au-dessus?


All set.  I had to add this file as my master was old.  The changes are at the end of the file.


Why do you set `surpressTaskName: true` and then instead write the command in the args? I think it would be much simpler like this:
```json
{
  "command": "npm",
  "isShellCommand": true,
  "task": [
    {"taskName": "install"},
    {"taskName": "update"},
    {"taskName": "test"},
    {"taskName": "compile", "args": ["run"]}
  ]
}


done


Won't you need it to be `WHERE visitor = '<username>';` I think you're missing the ' '