 - __information__: [src/chaiscript_stdlib.cpp:0](../blob/cf5913f8906f91021359c9ebf2c3cbec0bc71e10/src/chaiscript_stdlib.cpp#L0) Too many #ifdef configurations - cppcheck only checks 12 of 16 configurations. Use --force to check all configurations. (toomanyconfigs)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:679](../blob/cf5913f8906f91021359c9ebf2c3cbec0bc71e10/include/chaiscript/language/chaiscript_parser.hpp#L679) Expression is always false because 'else if' condition matches previous condition at line 677. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:683](../blob/cf5913f8906f91021359c9ebf2c3cbec0bc71e10/include/chaiscript/language/chaiscript_parser.hpp#L683) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/cf5913f8906f91021359c9ebf2c3cbec0bc71e10/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/cf5913f8906f91021359c9ebf2c3cbec0bc71e10/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 683. (multiCondition)
 - __information__: [src/chaiscript_stdlib.cpp:1](../blob/cf5913f8906f91021359c9ebf2c3cbec0bc71e10/src/chaiscript_stdlib.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __information__: [src/main.cpp:0](../blob/cf5913f8906f91021359c9ebf2c3cbec0bc71e10/src/main.cpp#L0) Too many #ifdef configurations - cppcheck only checks 12 of 17 configurations. Use --force to check all configurations. (toomanyconfigs)
 - __information__: [src/main.cpp:1](../blob/cf5913f8906f91021359c9ebf2c3cbec0bc71e10/src/main.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/cf5913f8906f91021359c9ebf2c3cbec0bc71e10/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/cf5913f8906f91021359c9ebf2c3cbec0bc71e10/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/cf5913f8906f91021359c9ebf2c3cbec0bc71e10/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/cf5913f8906f91021359c9ebf2c3cbec0bc71e10/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/cf5913f8906f91021359c9ebf2c3cbec0bc71e10/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


yep, i checked my code again i think it certainly follows this rule


For large files, the spec did not specify this, i can make modifications latter if need be. Sounds good?


I think it has something to do with physics 2333


Threading disabled by default, doesn't have any proper synchronization (definitions appear in no order whatsoever), lacks thesaurus support, etc


Any reason why this is a hard link instead of a symbolic one? Cygwin will respond with permission denied when creating a hard link.


You mean unneeded?
On 5 Mar 2016 18:49, "Samuel Gaus" <notifications@github.com> wrote:

> i feel so discarded
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gausie/visits/commit/d93d4238802c7386081ef2cca4069da896623a87#commitcomment-16519487>
> .
>


This is a *global* singleton. Two instances of LogTypeManager will share this dict. I suggest that you remove the construction argument altogether.


typo: sparce -> sparse


typo: indicies -> indices


We are migrating away from `export default`. Mostly we want to export the dispatch functions directly. So moving dispatchModifyCustomField into `export default` is the wrong direction. Clearly you can't tell from this code, but about 6 weeks ago we decided we where slowly going to move from doing it like this. We have been steadily changing things.


develop (lefticus) - i386-Windows-10-VisualStudio-14: OK (389 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I already had 3 tests passing between video 3 and 4 so I only did the one commit.


You should us es6 syntax here.
```
var summaryRows = statsSummary.map( (summaryLine, index) =>
```


Убираем комменты


TA said we can't. So receiver will send a request first.


Конструктор копирования должен все-таки копировать объект.
Book b("a", "b", 1);
Book b1(b); // в b1 поля не инициализированы


Этот хардкод не будет работать, как минимум нужен относительный путь


Этот хардкод не будет работать - как минимум относительный путь


What does empty string means here? Is it the same as not having the entry here at all in core2? If so, there is behavior change here - previously it was set to `False`, AKA `0`. And only in case if it was already set to some value (`if 'ntpd' in self.clockvm.services`), currently it is done if either wasn't set at all, or set to `False`.


You should use the ES syntax here
```
var tableRows = statsTbl.map((statsRow, index) =>
        <ImageAreaStatsTableRow key={index} statsRow={statsRow} plotId={plotId}/>
   );
```
you don't need the function keyword or returnl


1. Нет Unit тестов - только один тест для запуска


Yeah that's fine.


Сделал плачущую Славю в форме, решил что может понадобится. Разрешение огромное, надо нарезать.
А ещё, поменяйте директорию кто-нибудь, я нубас и не умею


ненужный импорт


и этот


закоменченные строки в "топку"


const в параметры
const char* name = "sad";
Book b(name, "b", 1); // ошибка компиляции


К чему все эти пустые строки?...


Projet Java sous Netbeans


count++;


pulic - лишнее слово для метода в интерфейсе


@briantrice Curious about the reasons behind this change. It seems to break the notebook `rawdata/socioplt/socioplt.ipynb` with Python 2. What does it fix?

I know Python2 and unicode is hopeless...


I am research assistance


to be commented out?
memory leak


А поле author будет неинициализированным?


Ahhh... That makes sense.


I didn't actually change anything...


+using namespace std;


Ceci est le projet Java du dictionnaire kinande-français. Il contient tous les sources nécessaires pour poursuivre le développement de ce logiciel.


const Book& obj


When configuring joystick input, just hold the button until the timer finishes. This was meant to help with trickier controllers like the 360 (analog triggers specifically) and the DS3 (everything really, all "buttons" are just axes). DS3 still doesn't work very well on Linux thanks to some quirks but I'm working on it.


Why the Cauldron config instead of Thermos?


This avoids the requirement for forge mods to send a dimensionRegisterPacket  @Robotia ?


Нафига этот класс если он вообще ничего не делает?


@DraksterAU it sends a dimension register packet for bukkit dims.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18481](https://teamcity.mesosphere.io/viewLog.html?buildId=155222&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:10:06


@Yive I dunno I just ended up putting it in there. I put stuff in there in the past so I decided to just use it.


.db files probably don't need to be committed


you could use es6 string templates here:
```
statsRow.push(`${formatNumber(item.value)} ${item.units}`);
```


Бывает отрицательное количество страниц?


Where does this a value come from? Can you give some example API invocations to setup some scenarios?


STRINF


`model` here is actually `TreeViewColumn`, its `set_sort_column_id` is very different from the one in `TreeSortable`, it isn't supposed to be called in an event handler.


develop (lefticus) - Win64-Windows-10-VisualStudio-14: OK (389 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


to be commented out


const params


Ah so done at the server level, not mod. AWESOME!
Thanks again @Robotia :D


Зачем у метода аргумент?


me parece f-ormidable...
estaba dudoso de un whitelist muy estático!


@DraksterAU :stuck_out_tongue_winking_eye:


Hey, you got skype?


I think you could just say:
```
if (bands[value])
```


Found a low level error, here we should use "continue" instead of "break"


Comenzamos?


Maybe you could make a drawing of what you want, because I don't understand? You're currently using a cone with a fixed z-scale, my question is how is that different from an ellipse in terms of information provided? I understand that a pie slice would additionally let you display the orientation uncertainty. Are you using the cones to display position uncertainty or orientation uncertainty?


Hi Ning,

Sorry that I just saw this pull request. I do not look at github that often.

Thanks for your fix. In fact, some users reported this error to me as well and I have an independent but similar fix. It is already included in the latest version. What I did is to append ".normalized_data_matrix"  to the output file.

Thanks,
Bo


develop (lefticus) - i386-Windows-10-VisualStudio-12: OK (388 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


Interesting, wolfsgang -- I didn't know about functools.reduce. But I think in this case "Explicit is better than implicit."


Форматирование. И хотелось бы увидеть что-нибудь типа `while(reader.hasNextWord()) {...}`


Thanks for this fixes! I'll merge them!


@milismsft @scotmoor PTAL at this commit for the changes to support adding a security group to server group


Veritas, I believe this hack will work well on Japan RF excluding the pointers and byte sequences. Japan RF seems to be an old RF client that's been updated, but with less patches. Atlava backpack was reborn as Otaku backpack and works well in Japan RF right now.


Hey dude, I've run this method and for the "no_protection" compound it picks out onset values {14, 0, 14} for runs 1,2 and 3 respectively. Can you possibly check that it's meant to do that? Sorry to be a pain.


 - __information__: [src/chaiscript_stdlib.cpp:0](../blob/467392e17dff0a7c3b79791888426c002037b625/src/chaiscript_stdlib.cpp#L0) Too many #ifdef configurations - cppcheck only checks 12 of 16 configurations. Use --force to check all configurations. (toomanyconfigs)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:679](../blob/467392e17dff0a7c3b79791888426c002037b625/include/chaiscript/language/chaiscript_parser.hpp#L679) Expression is always false because 'else if' condition matches previous condition at line 677. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:683](../blob/467392e17dff0a7c3b79791888426c002037b625/include/chaiscript/language/chaiscript_parser.hpp#L683) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/467392e17dff0a7c3b79791888426c002037b625/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/467392e17dff0a7c3b79791888426c002037b625/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 683. (multiCondition)
 - __information__: [src/chaiscript_stdlib.cpp:1](../blob/467392e17dff0a7c3b79791888426c002037b625/src/chaiscript_stdlib.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __information__: [src/main.cpp:0](../blob/467392e17dff0a7c3b79791888426c002037b625/src/main.cpp#L0) Too many #ifdef configurations - cppcheck only checks 12 of 17 configurations. Use --force to check all configurations. (toomanyconfigs)
 - __information__: [src/main.cpp:1](../blob/467392e17dff0a7c3b79791888426c002037b625/src/main.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/467392e17dff0a7c3b79791888426c002037b625/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/467392e17dff0a7c3b79791888426c002037b625/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/467392e17dff0a7c3b79791888426c002037b625/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/467392e17dff0a7c3b79791888426c002037b625/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/467392e17dff0a7c3b79791888426c002037b625/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


Pode ser. Mudo segunda.


fffffffff


Oops


echo "# Releases" >> README.md
git init
git add README.md
git commit -m "first commit"
git remote add origin https://github.com/cheechai/Releases.git
git push -u origin master


@cmriboldi Awesome.


develop (lefticus) - Win64-Windows-10-VisualStudio-12: OK (388 of 389 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


Deveria ser `free(tmp_string)`


might be worth making these allowed failures?


 - __information__: [src/chaiscript_stdlib.cpp:0](../blob/e0143081544996a614686f871b7f4a335728d3db/src/chaiscript_stdlib.cpp#L0) Too many #ifdef configurations - cppcheck only checks 12 of 16 configurations. Use --force to check all configurations. (toomanyconfigs)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:679](../blob/e0143081544996a614686f871b7f4a335728d3db/include/chaiscript/language/chaiscript_parser.hpp#L679) Expression is always false because 'else if' condition matches previous condition at line 677. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:683](../blob/e0143081544996a614686f871b7f4a335728d3db/include/chaiscript/language/chaiscript_parser.hpp#L683) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/e0143081544996a614686f871b7f4a335728d3db/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/e0143081544996a614686f871b7f4a335728d3db/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 683. (multiCondition)
 - __information__: [src/chaiscript_stdlib.cpp:1](../blob/e0143081544996a614686f871b7f4a335728d3db/src/chaiscript_stdlib.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __information__: [src/main.cpp:0](../blob/e0143081544996a614686f871b7f4a335728d3db/src/main.cpp#L0) Too many #ifdef configurations - cppcheck only checks 12 of 17 configurations. Use --force to check all configurations. (toomanyconfigs)
 - __information__: [src/main.cpp:1](../blob/e0143081544996a614686f871b7f4a335728d3db/src/main.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/e0143081544996a614686f871b7f4a335728d3db/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/e0143081544996a614686f871b7f4a335728d3db/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/e0143081544996a614686f871b7f4a335728d3db/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/e0143081544996a614686f871b7f4a335728d3db/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/e0143081544996a614686f871b7f4a335728d3db/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


Alocaste memória para `tmp_string` mas não fizeste nenhuma alteração à mesma... e no entanto é essa que devolves ao programador. Deveria ser `return string`.


Doh! Chamei o Penlight de Lightpen em cada freakin' commit... *Facepalm*


@198xiaozhu Hey chao. I already made TestGameBoard, TestGame, and TestPlayerManager in the model package. I tried to tell you about it on slack earlier today...


Typo: `![Gitter][gitter-image]][gitter-url]`


fixed it :)


Please use a registered commit author! I have a hunch that this was @awhiemstra's commit.


Hi Kevin, I have updated from int to Integer per your request and uploaded the changed. please review. If you have any questions please let me know.

Thanks, Vivek


Closes PR #1


Hi @astrolog

If you have installed all dependencies and follow the instructions on READ.ME you will see a sample example starting with a new selenium browser's session. Please send me an email with errors on your browser's console log or terminal.


Just ignore this. I did the wrong thing when trying to correct another mistake.


Hey, this commit dropped support for Django 1.8 even though 1.8 is an LTS release and supported for another 2 years. Did this commit do anything in particular that makes the package no longer compatible with Django 1.8?


I haven't grokked the interplay between these inverse factories and the processors yet but I'd expect to see inverse relationships added in here.


Be careful with Continous integration! Having dist files under source control should lead to endless rebuil loop


Is there a reason to have this included with the static wall? I though this would be a separate thing.


I looked into it, but the code looks much uglier and more difficult to read. If you are ok with the current solution, then I'd go for the one I implemented now.


Please hold on publishing to bower


Multiline comments are not supported by autostacker and would be passed to cloudformation. I don't think it makes sense to introduce multiline comments as they would require parsing compared to simple comments that could be remove by a single regexp.


How can i find the point.h? Kindly request you to give me. Thank you very much for your help.


Add Bootstrap, Disable NInject


@sneh1234  after your change , if you delete all and then run forward action then it applies on the turtle that is in trash not on the turtle which is there.
here is the screenshots ->
after deleting all.
![screenshot from 2016-03-06 15 38 29](https://cloud.githubusercontent.com/assets/9693445/13553494/bdd4535c-e3b1-11e5-9573-d95115abdf7b.png)

and then move turtle by some amount and then apply forward then what happens is this ->
![screenshot from 2016-03-06 15 38 55](https://cloud.githubusercontent.com/assets/9693445/13553495/c8135110-e3b1-11e5-8126-395733b352bb.png)


Book[] BookStock = new Book[100]; e corect sintactic.

Problema ta e cu clasa Book care nu ti se compileaza. Rezolva prima data acea problema si apoi o sa iti dispara eroare de pe array.

Ati facut la curs Eclipse?
Poate ar fi bine sa nu sari deja la Eclipse ci sa compilezi din comand line.


great


@Infinity95 @JanSurft @Gynjd @Sofoca @Valentin987 Was denkt ihr?


Volviendo a esta versión estable.


We shouldn't fallback on `realtime_viewer_fbid` but on `reader`. The former is your ID.


I wrote it appended first, changed my mind during testing and ended up only testing it on x64 - the final intention was to have them all prepended which I forgot to do :(


@nckx: do you use the 304 branch?


確認しました。、問題ないのでマージします。


just check the php version


In the library/globals.php script, change the css_header setting to your new stylesheet style_bootstrap.css:
https://github.com/openemr/openemr/blob/master/library/globals.inc.php#L159


感覺用 hidden input 不太對，不然只要改 HTML 就可以幫別人 review 很奇怪。應該可以在 submit 時直接帶？如果 URL scheme 換一下，proposal 應該也可以直接從 path 取。

Review 應該是 `unique_together = ['reviewer', 'proposal', 'stage']` 吧？我晚點直接看看，或許直接改就好了。


For now I've added it to link to jsperf.


Why not just restore dwOldProtect here?


reviewer 應該不用帶吧？不是就你本人？
@uranusjr 暗指 @ccwang002 會找來無聊的 reviewer，自己的 review 完還是幫別人 review。


test


Can you change the comment to:

```
The Google Maps client ID (for premium plans).
When you have a Google Maps APIs Premium Plan license, you must authenticate
your application with either an API key or a client ID.
The Google Maps API will fail to load if both a client ID and an API key are included.
```


##This is a markdown file


tesaf


Thanks for catching this. My text editor insisted on doing weird stuff with the quotes for some reason. Got a new one now :+1:


Thomas - ever since this change the not enough funds / colouring stuff hasn't worked properly.


块级元素确实是很霸道的，但是它也怕display：inline-block/inline，或者是位置属性，position：absolute/fixed，这些好像就是它的克星！


不過你要改什麼明天再改吧。


On clean flash it should work, investigating.


今天歡迎 Real-time code review。


### 但是左右的padding和margin都是可以设置的，这个有时候是很有用的。


that is a huge improvement!


You have spotted a bug. Thanks! But it would be better when you send a another PR (where this bugfix is the only change in the commit).

A useful commit message for that new PR could be:
```
fix(LazyMapsAPILoader): use default API version 3
```


this hand too has duplicate card


this is a pair, not a highest card


Should remove 'coalib' and just keep 'tests' ?


this is a full house, not a 3oak


Namely, add support for parser rule lists.


> ### 关于绝对定位，有意思的一点是，当设置元素 position:absolute;   然后进行位置偏移设置时候，如果该元素的宽高固定，可以同时设置所有的位置为零，然后margin为auto来让元素在父元素中居中，比如：
```
positon: absolute;
left: 0;
right: 0;
top: 0;
bottom: 0;
margin: auto;
```


nu am facut eclipse
insa ma gandeam ca e mai simplu prin eclipse


No, you need to keep coalib and remove tests

```
apidoc_command = ('sphinx-apidoc', '-f', '-o', 'docs/API/',
                      'coalib')
```
is correct


Now that we have the TransformBuilder I think we can get rid of `transform([operations])` across the board.


it would be good to make sure that straight flush beats 4oak too, but this test currently doesn't do that.

same as https://github.com/exercism/xgo/issues/252


What do you mean by this?


javs


Need [chromium-pepper-flash](https://aur.archlinux.org/packages/chromium-pepper-flash/) for Deezer and Spotify.

Mixcloud, SoundCloud and 8tracks work fine without flash.


demo


- 新同学没想到这么认真，我当初就写了个“Hello World！”就完事了。
- 希望可以持之以恒。
- 学习无所谓快慢，只要适合自己就好，但贵在坚持。
- 累了就随便逛逛，没想到还有惊喜。
- 网络这么大，我来逛逛。


Yes!


should work, even in SQLite -- but definitely recommend you use postgres on development as well.

`Claim.where("created_at > ?", 7.days.ago)`


@sarumam Thanks. Can you submit a pull request adding it, and I'll accept.

Also, as you are loading it via a submodule, is it the latest version?


How far do we go though? Would you also add OS-specific entries?


Because youve moved out tests, pytest now doesnt know where to find the tests. So, in line 15 of this file you need to tell pytest to also look at the tests folder for unittests


Executable jar added


That was a requirement on my machine. I can try to reproduce it.


For this to work in a keybinding in sxhkd, I have to escape the tilde. Might be worth adding to the documentation.

    # Preselect splitting area
    alt + {h,j,k,l}
        bspc node -p \~{west,south,north,east}


On the patient summary, the Clinical Reminders and the Appointments sections look very awkward. See below screenshot:
![new-ui-issues](https://cloud.githubusercontent.com/assets/278968/13553626/4afcf518-e344-11e5-90e9-b87200331a2f.png)


Review Complete.


Sure ;) And hi @Schmoozerd i'll miss you :)


Thanks! A few comments:

- The directory utests/ collides with my make-based tool-level utests which I also plan to commit to github
- The unit tests should go into each module instead of a separate directory. I think they should even go into the same file so that a test for a function is right next to the function.
- Please don't make everything depend on CUnit. IMHO a unit test for a function should just be a function which returns true or false and uses debug_printf to output additional information.
- We could then have one utest command which calls all unit tests or some subset..
- I am not sure we need CUnit, it is nice and small enough that I do not hate  it, but I am also not sure it offers enough to warrant another dependency. It is almost trivial to do the same thing on your own, and we have more flexibility (for example I want to have bechmark-based tests to catch performance regressions).


There should be a default implementation to fall back on as.Date for non POSIXt classes.


Could you please add a rationale for this method and a link to github issues. Thanks.


This hand has duplicate card

issue #250


Wallet will got clashed if you send dope to it ......Is not it?
what is error you getting?


未设置水量可能导致水泛滥


this hand has duplicate card

issue #250


there is a typo: chaset_is


This is pre-existing, the reason behind it is because containers (LXC) and guests (KVM) are all "machines" for juju.


if you try to edit the code, please make sure that you edit from the source that you pull from GitHub not cut and paste it.I can't check what you edit in the code thanks :)


я бы множество категорий на нашей стороне сделал бы как-то более явным. ну например использовал бы другой разделитель, тогда они бы все попали в один столбец, который можно мапить в массив.


You need `#[deny(warnings)` here!!


This should be `const`.


> i'll miss you :)

he is going to leave? :o


Capitalising these implies that they're classes to my eye, but I get that they're being used as namespaces in this instance, it's just not a convention I've seen in javascript.


Yes, this is intentional - we only need support for bridges to properly link container NICs to their host machine's respective bridges. I don't see a problem to later extend this to support other parent device types, if we need to.


This is wrong. Buffering of stdout happens automatically.


you couldn't add them all in one commit?


Don't use `println!`.


hello world haw are you ???


This shouldn't fail silently. Exit with code, `0`.


Not until the unit tests are updated. Please do this ASAP


So should i add 'tests' to it ? Can you please explain me how this works?(because i don't understand why coalib and docs are present)


hi


Вот это так замапить не получится - для uid нужны partner+name+color[+material]


coalib and docs are present because pytest finds doctests inside those folders which it needs to find and run.

Bu most of our tests are inside the tests folder. So, yeah - you need to add "tests" to it


Yes, it is, now trying to figure it out.


Out of curiosity! What does apidoc_command() do?


Regarding the 'Regex "/e" modifier is not supported in PHP7' stuff. Looks good to me. Were you able to test it? Rec making a commit with the comments removed.


This is because sxhkd runs commands in your shell (this is documented), and I guess your shell is bash, which expands ~ to your home directory.


Regarding appt bug, I'll try to look into this when I have some time (if you are not experiencing the bug, then will be very tough for you to sort it out).


@Dewep Could you refresh the pdf with the new latex file and check if the plots are well formated (full page and one contains a comment below). ty 😘


Thank you John!
I thought that it could be good to include the editor in the remi installation dir. The user should run it by

```
python -m remi.editor
```

What do you think about this?


Лучше писать просто `npm test`, чтобы npm не выдавал собственных сообщений об ошибках.


However the solution proposed have a big disadvantage to create a new string and trigger a copy, Thus implie less optimized code.

Nice catch btw.


Hi Assem,

Thanks for reminding me about this. A version 1.3 should be on PyPi now that should include this fix.


Long commit messages are fine, long commit diffs are not. With huge patches like these, it's a lot more work to figure out what happened, why it happened, and whether it happened well.


в spring boot есть plugin для интеграции с maven: spring-boot-maven-plugin


just about to release a new one today, doing release notes


для отладки, да?


1 line = 1 alias.


I did note a bug that is related to the previous tcpdf/html2pdf changes, which appears to be related to removing the fpdf library(we should fix it by directing the code to use the tcpdf library). The bug is:
1. Open a patient
2. Click popup a bottom of left_nav menu and click 'Chart/Barcode/Address Label', which will produce a popup with white screen of death.
Here is the php error log:
PHP Fatal error:  require_once(): Failed opening required '/var/www/openemr/library/html2pdf/_fpdf/fpdf.php' (include_path='.:/usr/share/php:/usr/share/pear') in /var/www/openemr/library/classes/PDF_Label.php on line 41


Start with capital letter.


I get an NPE here if `"expectedType"` is not set. Are all `JndiObjectFactoryBean` beans now need the `"expectedType"` property to be set?


Fold this to the one above.


You might want to specify the details.


xmlReader надо передать в параметрах метода и Spring его найдет создаст и подсунет.


unmarshaller надо передать в параметрах метода и Spring его найдет создаст и подсунет.


No need for `{`.


delete


и так далее, не надо зависимости руками собирать, надо наоборот дать Spring'у их вывести и заинжектить


M


notes golang postgresql


I just changed BibleVerses.py on my master to reflect your parse routines and some of the API call changes.  I am still struggling with mining data from api calls using multiple dicts.  The latest BibleVerses.py sends one passage at a time for an API call and all works well in a multitude of combinations.  I also obviously need to get a handle on managing files in Github, ie pull requests, forks, etc. I'm not to comfortable with that yet, in terms of protocols and procedures.


This should be written to stderr!


@l3pp4rd I have done a custom implementation of the Json marshalling for Examples: https://github.com/cucumber/gherkin/commit/fe138cfdde0724f78211a0d940b8ebe3b17857b1, (as a user of gherkin-go) WDYT?


總召大大叫我修的，不過這個應該是小問題...


By By


Это для тестовых данных, да?


`stderr` again?


エラー無視したいだけなら

```ruby
Bookmark.find_by(id: params[:id]).try(:destroy)
```

で大丈夫だよ。


This is not unreachable! If a path is invalid unicode, this will panic.


You don't need no heap allocations.


You removed the  && $temp = .. (which allowed to return false etc.)

See issue #9316


I'm surprised that Python doesn't complain about the indentation here. In any case it should probably be fixed.


I think we should be able to remove the renderer argument now that appleseed is the only renderer?


_чисто программерская придирка_: метод огромный, читать сложно


Hi Terry,

Did you fix this issue?

-brady


These should actually be const *references*: `const MString& sn`, etc.


Honestly, I don't know why this was merged. There are still a few things to fix (the overall direction is fine! Very nice code, indeed). I would appreciate if you could send a PR, which fixes my nitpicks above.


I like the idea about this, but why isn't Makefile and configure removed at all?


можно проще: `for (MappingRule rule: rules)`


I'm not even sure you need to construct an `MString` out of `perc`, i.e. this might be enough:

    progressStr.format("^1s% done.", perc);


Yes, but I'm currently writing in `Actors.tex`


Never unwrap.


commented code, remove that please


You need to add manjaro-firefox-settings to the profile.


my email is joshaf.est@gmail.com.......well
i can help you ......dopecoindude told me to fix the syncing issue.....


`stderr` here too.


:+1: LGTM.


`exit(1)` (but remember to flush!).

Potentially, use `extra::fail`.


remove commented code


ok!!!


Ths is inferable.


You're welcome. Thanks for sharing the algorithm in the first place!


I think the backslash isn't needed


I'd put the comment in the same line as the pass to save space


It may be that type constructors for bitstypes were not callable in 0.3. I'd say 0.3 is old enough that it's fine to only support 0.4 for new packages.


Could this be provided conditional on "ifeq ($(ARCH), x86_64)" ?


Sent you a letter.


please use `splitlines(True)` to keep the newlines


Fixed, thanks


What is the difference between set_interval() and set_absolute?


@MagicDroidX perfect job! :+1:


5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Hi,

I thing yes, this should be included in benchmark/Makefile

Best regards

Werner

On 03/06/2016 12:05 PM, Martin Kroeker wrote:
>
> Could this be provided conditional on "ifeq ($(ARCH), x86_64)" ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/xianyi/OpenBLAS/commit/0bbca5e80392625e1af911cc8730c4928b412750#commitcomment-16522827>.
>


Ah, I see. I was searching sxhkd documentation for something relevant, but did not really know what to look for. Still, I think a little note in the bspwm documentation would not hurt anyone.


@MagicDroidX fire and lava should not burn the player in creative


you need `test/**/*.py` with a double star to go through directories recursively


s/_usec2count/us_to_count/ or,
s/_usec2count/us_to_tick


на каждую строчку будет читать из файла? лучше на старте приложения все вычитать в память в Map и заинжектить сюда.


It's pretty heavy-handed; if a definition of a `fail` method appears *anywhere*, the check is disabled for the whole file. I didn't think it was worth it to walk the AST and try to find the exact scope where the custom method could be called.


s/ int vcpuid/vcpuid_t vcpu_id/


word.length() ?


good


pretty


You can take a char at position without new string allocation.


delete


What is the meaning of delay_tick?


You can think the name is better than GUEST_SCHED_TICK.


Remove unused function.


fstream is  still a global variable.
and Total number of records you can handle are 100.
Move main below all member function.
Search function can only for matching usn. You can look at my code how we can generalise this for any
feild.
You are literally loading the entire file into memory to do the search. This is not on.


Done!


want to change hello-world


s/cpu/pcpu/g


we have `packages=find_packages(exclude=["build.*", "*.tests.*", "*.tests"]),` below, I think this can be simplified now to  `packages=find_packages(exclude=["build.*", "tests.*"]),`, can you try and test that? (To test create a binary or source distribution and check that tests are excluded properly


haha


wana know commit


s/cpu/pcpu, in case of cpu is a physical CPU.


Этот адаптер мапит по поиску соответствия в файле-словаре категорий.
Мы еще говорили, что если соответствие не найдено надо попытаться смапить по маске/regexp имени (они в другом файле должны передаваться на вход процессору). Я его не нашел.


Code Smell: Use consistent names.  Either use "d, e" or "value, entries", do not mix and match single-letters and canonical names.


a


s/interval_us/interval/g
 Add a line note


Please, no merging of master in feature/PR branches. This will lead to a PR being rejected (project policy). If you want to update your branch with the changes in master, always use rebase.

As far as I can see, your branch now contains 4 commits with changes that are already in master: f4e8b80ed711157488f1f42f390672b30387ec9f, 83262220941bccbf2d445bfbe81f8e32fd1f9d24, 83e2197ab30623e7c9acfaecba404faa39ef3aa0 and c3c116370ed5d8b47e19109601822b2188d825ed. Please clean up your branch (removing these commits by interactive rebase should do the trick).


Optional Smell: Use begin with `||=` to make code more readable.


Smell.  Please add spacing between a setter and a user.


usec_to_count
do not use a number in function name.


тут нет ошибки в type arguments?


Ditto.


Do not add underscore prefix in function name.
s/_get_syscnt/get_syscnt


Ok


Remove an uncomment.


WARNING - 2004 is making a come back.  :laughing: Smell: Use HTML5.


s/time_us/time/
timer_usec_to_count


Reverse.


Smell: Attribute to the community not a specific person.


Could you please this code into C code?


What files do you think about? E.g. .DS_Store files on Mac OS? Then yes ;)


thank you for solving, today i want to fix some design bucks


closes #2


How about a function calculating pagemax?


Smell: Use `Enumerator#first` not `Array#[0]`


Smell: Use Enumerator#first not Array#[0]


Hash-tables are like dictionaries, compared with Python language.


[Uploading Module2-solution…]()


Smell: Split a Hash by lines if you use `{}` or remove the `{}` wrapper.


@tkelman OK I remove it from Travis CI; but I leave REQUIRE unchanged because it looks like the code by itself is working when used with its default settings. Thanks.


You should use tabs for the indentation in the XML :)
Also, what are JOY_AXIS_{4,5} used for? It would be nice to have it documented too.


EXTREME SMELL: If you have to sort your keys to test, you're doing it wrong and coupling tests too tightly, this will eventually lead to failures, test for what you want or don't want, don't assume something is static, nothing is static.


If you're going to support 0.3, it needs to be tested. You could just skip that one test for `VERSION <= v"0.3"`


I need #'equal because the default :test `(FASTHASH-EQL)` don't permits to index lists, whose makes senses because `eq` don't permits compare lists (`equal` yes).


can you make an own commit for rename and delete respectively?


can you use `enforce_signature` directly?


same here, use `enforce_signature`


Stefan, it can be replaced but the change as it is now doesn't restore old values. So, therefore we have to re-implement the Restore() method and take care of this if this is really needed.

An alternative fix would be to ignore GridSize values if they are <= 0. But this would be a bit strange behaviour to allow negative values even if it's only in the property editor which someone probably rarely uses for this case. That's why I decided to change to the other property type where limits can be set.

> [17:19] Coin error in SoGroup::removeChild(): tried to remove non-existent child 0x47813a0 (Separator)
I don't see how this should be related to the change. In case this is related then there is something else broken too because ignoring to read in a value must not cause such an issue.


:+1:  Hit me up if you have questions to jekyll. [My website](https://github.com/mischah/mischah.github.io) is also based on jekyll :kissing_heart:


Nice.


This is where I put an comments about a new commit


5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1022 of 1022 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-30.52%25-green.svg)


I think you'll want to give the `modified` function a property such that it gives an empty list if the file was deleted


I did commit because I wanted to add about biohacking.


5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


that'd make sense, wouldn't it?


Hi,
Yes, the idea is that the trees are in synch.
However, it also depends on the underlying streaming engine: if it can guarantee the message delivery (in this case, the split message broadcast from the LearningNode to the ModelTrees), then the models will be the same.
We still don't handle the possibility of losing a message, so the algorithm is not entirely fault-tolerant.


also you should adapt usages of this class so deletion and modification actually works


be sure to split up the commit first fwiw ;)


tab키 넣어주세요


I also changed postgis_importsids3.png and postgis_getmanager.png


Назови класс как-то по нормальному `DBUtil` или `DBHelper`


It makes no difference... it's my personal preference to write loops over vectors/arrays like that


my english is terrible... i meant " i miss you "


This call returns NULL and causes a segfault in the next line. I used:
```C
struct cx231xx *dev = fe->dvb->priv;
```
which works. Does it make a difference or is that the wrong approach?


Погугли тему называется `try with resources`  чтобы, `statement` автоматически закрывался.


You are providing a sample application that does not conform to the OAuth 2.0 specification but clearly is insecure (see [RFC6749, Section 10.1](https://tools.ietf.org/html/rfc6749#section-10.1): "Web application clients MUST ensure confidentiality of client passwords and other client credentials. The authorization server MUST NOT issue client passwords or other client credentials to native application or user-agent-based application clients for the purpose of client authentication.").

It is also completely out of the question to implement the authorization grant flow in a user-agent-based application like you do. Either you clearly indicate that your sample implementation is INSECURE and should not be used as a template for your own implementation or you provide an implementation that conforms to the OAuth 2.0 requirements.

IMHO you cannot assume that unsuspecting implementors who see the need to look at a sample application will be able to identify such a vulnerability and fix it in their own implementation. You should better assume that people will simply replace the secret for their own and use the code unchanged.

And another vulnerability: As you do not enforce the same URI for code and token retrieval, you should clearly alert users that any open redirector on their page poses a serious vulnerability (compare [RFC6749, Section 10.15](https://tools.ietf.org/html/rfc6749#section-10.15) "...if the authorization server allows the client to register only part of the redirection URI, an attacker can use an open redirector operated by the client to construct a redirection URI that will pass the authorization server validation but will send the authorization code or access token to an endpoint under the control of the attacker.")

Please be aware that this is not a complete security review review of your sample application - it's only what was immediately obvious by looking at it. Not exactly trust-inspiring for an application like debitoor that deals with highly confidential financial data.


`id` в базе данных должен быть автогенерируемым. Это делаешь на уровне базы данных при создании таблици.

Например:
`c1 INT(11) NOT NULL AUTO_INCREMENT,`

Тогда колонка c1 будет всегда увеличиваться на 1 если её не указать в `insert`.


貌似并没有把bs库移动到src/lib中，，，


one space indentation too much isn't it?


4 and 5 are unused currently on the platforms that I know of. (if the device is mapped; unmapped pads may send events on those axes but then you can't say what they actually mean)

I guess they are placeholders in case some console hardware needs additional controls, like the touchpad or tilt-control on the ps4.


otherwise good, I want it :)


_**perfectly**_

#


Added STLocationRequest repo to the "Permissions"-section


instead `fmt.Sprintf("%s", (ip))` you can just use `ip.String()`


Okay, what do think about this then. If we don't put those files in gitignore, inexperienced developers will have an opportunity to learn that there is such thing as hidden files, or that their editor creates files, that they can make git ignore those files or that `git add -A` is not always a good idea.


5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - x86_64-MacOS-10.9-clang: OK (2124 of 2130 tests passed, 3 test warnings)

 * 9 tests had: AUD diffs.
 * 9 tests had: MDD diffs.
 * 9 tests had: MTD diffs.
 * 1 test had: ERR diffs.
 * 6 tests had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: RDD diffs.
 * 1 test had: Table big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


Pssst, `md5_crypt` has been deprecated due to security flaws: https://pythonhosted.org/passlib/lib/passlib.hash.md5_crypt.html

I switched one of the recommendations, i.e. `sha512_crypt`, and it worked well :smile:

P.S. Thanks for sharing these great Ansible playbooks :heart:


현재 사용중인 언어까지 `lang()` 함수에서 반환하도록 하는 것은 한 함수에 너무 많은 역할을 부여하는 것 같습니다. `Context::getLangType()`을 사용할 수도 있고 `Lang` 클래스의 메소드를 직접 호출해도 되니 이 기능은 빼는 것이 어떨까요? 나중에 꼭 누군가가 `$code`가 `null`인 상태에서 호출을 시도하다가 이상한 결과가 나온다고 이슈 넣을 것 같아요.


luka was here


I just copied the existing `default.html`


Shouldn't the comment be moved one line lower?


I was copying the existing tests


Also if the proposal is indeed fine, we can't pass array like this: in that way calculate missing is just picking up the first two elements of @Installed_Packages.

It should be passed as an hash/struct pointer containing the two arrays or we should pass the length of the arrays  to pick em up later in the calculate_missing sub.
something like that should work:
$my_packages->{Installed}= @Installed_Packages
$my_packages->{Available}= @Available_Packages,
push( @packages_deps, calculate_missing( $p , 2, $my_packages) )

sub calculate_missing{
my $package = shift;
      my $depth = shift;
my $my_packages=shift;
my @Available_Packages=$my_packages->{Available}


Hi... when I try to run it on Android Studio I get an error message "error: package com.bugsense.trace does not exist". That particular package does not exist in the project.


It complains if I don't do it because it expects an MString& reference.


下次再写，完善程序后


I don't see how bad code justifies more bad code but okay.


5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2162 of 2168 tests passed, 3 test warnings)

 * 9 tests had: AUD diffs.
 * 9 tests had: MDD diffs.
 * 9 tests had: MTD diffs.
 * 1 test had: ERR diffs.
 * 6 tests had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: RDD diffs.
 * 1 test had: Table big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


@sils1297 how about now, this is much more readable.


I was just saying that those tests should be fixed. TBH, most if the tests are broken


Do you need one, given that it does nothing ?


Cool


Should be `EzPlatform`


for this indentation please only use four spaces:

```python
foo_bar_foo_bar(
    arg,
    arg1)
```

that's way better readable


TeamCity LabKey :: 16.1 Release :: Community :: CDS postgres 9.5 [Build 18](https://teamcity.labkey.org/viewLog.html?buildId=308260&buildTypeId=LabKey_161Release_Community_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 8 (1 new), passed: 39, muted: 4 Build time: 01:14:21
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSSecurityTest.verifyUserPermissions: <no details avaliable>

org.labkey.test.tests.CDSHelpCenterTest.verifyHelpCenter: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisFilter: <no details avaliable>

```


According to our conventions, we are not fun of such one liners. :) https://wiki.openmrs.org/display/docs/Coding+Conventions


Please reconsider whether you have to turn on Travis on your fork and if so at least disable build notifications, thanks!


Blabla


woo first commit


- random walk에서 알 수 있듯이 fp의 추상화 단위는 oop보다 작다. side-effect를 없애기 위한 함수화로 반복되는 코드가 많아진다면 def 메소드로.. def 메소드로 안된다면 클래스로 해결하는 것이 필요에 의한 디자인. tiles와 at을 좀 더 개선할 필요가 있다.
- array manipulation의 성능개선을 위해 Hash, Set을 애용할 필요가 있다.
- reduce에 의한 recursion은 하나의 idiom으로 취급할 필요가 있다.


Constructor arg  moved to getter / setter


Mmm on utilise Faker ;-)


в таблице Book поле idAuthor это внешний ключ для связи с таблицей Author


5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1580 of 1580 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.82%25-green.svg)


scalar is not needed in this case, using array in scalar context in perl defaults to array length, otherwise LGTM


Constructor arg moved to getter / setter


there are 4 spaces.


なるほど、「厳密」は私の許容範囲外だったので「厳格」にしたのですが、そういうキーワードがあったのですね。であれば、迷わず、訳さずにSTRICTとしたいところです。
func.sgmlの中では他に1箇所、strictを「厳格」としている部分があり、これもNULLの取り扱いに関する話なので、STRICTとすべきところですね。
他のファイルをちょっとgrepしてみたところ「厳密(strict)」とか「strict(厳密)」とか出てきますねぇ…せめて「strict(厳格)」としたいところです。


Autowire using annotation


Yahoo is in the divers sit it is good to knowledge


It looks like this commit will only swallow the error, but it's not doing any checking or using another method to allocate memory, so it didn't really solve the issue.

I think it's better to let the programmer gets the full error stack rather than just "OutOfMemoryError" message, therefore, I didn't merge this commit.

Let me know if you think otherwise, thanks! :+1:


1, develop branch is used for group leader to develop his own codes as well as combine and test other teammates' codes. 改成：develop branch is used for group leader test and merge other teammates' codes.

2, Line 110: Review codes in pull request. 改成: Code review in pull request

3, Line 111: Merge codes to master branch after testing in develop branch. -> Merge codes to master branch after stable in develop branch.

4, If group leader finds problem to modify, he will create an issue and assign it to team members. -> Group leader will create issue and assign to relevant team members for bugs / enhancement in code.


Annotation config context added to enable annotation autowire


ev = empty vehicles


Fix to compile with spigot 1.9 API, so everything works correctly


ここはスルーしていましたが、確かに「右側の値に等しいものがなく」は、何と等しいのか曖昧ですね。修正します。


This actually make the app crash when I test it... In fact I included this change, then only I realized that it will crash, so I reverted this change.


suggest using str_comp


It is TDIP-JP073, why use this id?


We already know that and I am actively fixing that (I'm just not made of time so it's not ready yet -- and soon it will probably just land on a branch for the entire core to work on.) That said, all of these smells were automatic and by a bot and it's not programmed to care about anything but what you changed. :wink:

Honestly though, we know the tests suck and it makes us :cry:


Что нужно дальше сделать https://gist.github.com/flyb1z0n/00f9da319d8758a86279


It works unsure of the results. So we need some better monitoring in place to really see whats going on.  Was able to confirm that multiple connections are being made to the Mysql server by the same user.


Needs a break;


s/golobal/global/ ?


might be better to inherit from dialog_support.error here


Ditto here: s/golobal/global/


Needs #ifdef __IPHONEOS___


why?


Network manager service on latest Kali is called network-manager. If we declare compatibility with Kali, we must leave this to network-manager:
`root@kalif2:~# ls -l /etc/init.d/ | grep -i manager
-rwxr-xr-x 1 root root 1757 Dec 24 01:57 network-manager
root@kalif2:~#
`


What do you think if this would be `--quiet`? NPM tends to be pretty verbal. Quiet mode prints only warnings, errors and the last report. All the essentials, so to say.


暂时找不到解决方法


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18503](https://teamcity.mesosphere.io/viewLog.html?buildId=155280&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:10:44


Awesome :) I would like to actually pull out all of this into a configuration file perhaps?


ah i forget about it, sorry, will add it soon.
thanks


Thumbs up for this!

It's wort mentioning that npm scripts use locally installed versions, which allows version-locking bower, grunt and gulp. `npm start` should be used also at README.md instructions for development.


This is my first repository。


I prefer `zip(arr, arr.save.dropOne)` instead of UFCS. Is `save` necessary?


gidder du endre denne til `input` så slipper vi forklare at inputten har klasse prevent, men at den ikke må ha det


Why do we need it in the repository even if it is empty?


I'm on board with that. I just ported the watched/unwatched menu and it had the same huge list of unnecessary conditions while at the same time being broken for other things:\ Would be great if you could refactor it similar to video info, yes!


Nice example. As this has the tuple indexing, it could be put before the foreach loops and IMO we could remove the `foreach (tup` version. We should also mention *automatic tuple unpacking* in a comment before the `foreach(t1, t2` version.


Looks great! Would you make a PR in order to merge it with master?


Please remove console.log "kenny"


hahahaha


增加完整的bud与方块数据储存队列

在 2016-03-06 20:14:38，dtcxzyw <notifications@github.com> 写道：

暂时找不到解决方法

—
Reply to this email directly or view it on GitHub.


Some of the parameters are used directly in the appleseedrenderer.cpp like:
    https://github.com/appleseedhq/appleseed-maya/blob/master/src/appleseedrenderer.cpp#L230
I suppose it would be consistent if we unify the way enum attributes are used similiar to the way they are used for lightingEngines or bucket orders.


There are some data flows which are a little bit complicate, we need a further discussion.
Currently we can only use `this.props` for the communication between action and beforeUpdate, afterUpdate. But sometimes (when I develop auto-complete) I found it's not enough.


yeah so either you do four spaces or you make all params aligned with the first opening bracket as start position


Not sure if we still need this -- a lot of utils.py has changed. If there is still useful stuff here, could you resubmit?


@bgoldman did you create a Disquss account? Because Disqus fails to load :disappointed:

I will revert the commit until we figure out how to bring back the comments for your fake user :wink:

![comments](ff303e678d6796a673c12cc850462ea6a03bb5c28a017997961fc7f2bd6998bc)


I think we don't need `greaterThan` now ;-)

Thanks for making the suggested edits BTW. I still think the `sort` example should come after the `foreach` example though, YMMV. The foreach example is a better introduction to `zip` IMO.


No this is not for 1.0.0!
I wrote in #499 that this one is **only** for develop because of the API changes that are only in develop.
This change without the API change causes the dashboard to wrongly give this error:
![image](https://cloud.githubusercontent.com/assets/5703454/13554085/01a81cb6-e39f-11e5-87cf-c49e0b321688.png)


This approach isn't going to change in the near future. The IP concerns endemic to standards bodies *require* that most updates will be done inside Khronos in a completely different git repository which does not share history. There's a huge amount of overhead in moving changes between the repositories just using a single application of git diff / git apply after accepting a few dozens MRs internally, and I'm not going to add another couple of hours of work to the release cycle just to break the individual issue fixes down into separate commits. Hopefully over time things will get smoother and more automated, but for right now, it is what it is. Referring to the public issue discussions will get you most of the context around what changed and why.


I don't really have any problems with this solution, but I'm just curious why we should use a WP level API instead of a built in PHP API?

It would have made more sense if the original code had used the more Unix specific `fopen`. Right now I don't see the upside of `wp_remote_retrive_body` as opposed to `file_get_contents`.

But as I said, I don't oppose this change per se.


Correct, links playout like this on the page:
&id= ---> iqdb ---> google
&id= ---> google

The problem is the z-index deal: on the sidebar either "Search", "Tags", and "Statistics" is clickable or "Reverse search" and "Tagging operations"


Not with arrays ;-)
Well `dropOne` is really just a wrapper around `popFront`, so it won't work for most other ranges.
However as the docs examples should strike for simplicity, I removed `save` to make this example even clearer.


jhgfjhgfjhgfjhjh


Yes, it may be confusing. But we need a way to pass data from actions to afterUpdate. I want to find a way to streamline our data flow in actions and before/afterUpdate. We can try to find a more explicit way.


I didn't create a fake user. It was literally a fake username.

If you want comments to appear on the demo site, I recommend making a `personal-jekyll-theme` user a the default rather than using your personal Disqus account.


厳密等価演算子を使用するように修正しました。
再度レビューをお願いします。


Screenshot:
<img width="662" alt="screen shot 2016-03-06" src="https://cloud.githubusercontent.com/assets/844117/13554107/e6c7c82a-e3a7-11e5-82d6-3481f1fead11.png">


This is my fist repository.


> IMO we could remove the foreach (tup version.

That was is the example that is currently used in the docs, so people might be used to it ...


thank you ,tobatha


Bravo les erreurs avec les figures.


> We should also mention automatic tuple unpacking in a comment before the foreach(t1, t2 version.

done.


Hi,
shouldn't the lines above your changes be ifdef'd and changed?

Cheers,
Mateusz


> I think we don't need greaterThan now ;-)

Oh at least you know that I really did test it ;-)

> Thanks for making the suggested edits BTW. I still think the sort example should come after the foreach example though, YMMV. The foreach example is a better introduction to zip IMO.

I absolutely agree that the `sort` example is hard to understand, I restructured all three examples - starting with the shortest and easiest to grasp: (1) the short pairwise sum first, (2) `forEach`, (3) `sort`.


Great, works! I also switched back to `File.exist?`, what also works. No need for the `Dir...any?` anymore :)


Mangler "


@tuvistavie, @HashNuke
`get_element_id`
https://github.com/HashNuke/hound/blob/master/lib/hound/helpers/element.ex#L309
should also use
`Hound.Helpers.Page.find_element!(strategy, selector)` instead of `find_element`
Otherwise all functions that use this function will try to make requests with `nil` instead of element ID if element wasn't found, then we get errors with `Invalid Command Method` (I use phantomjs)


${...} is the property placeholder syntax


there's a python builtin for this, I think it's `__contains__`, this way you can use `"key" in section`


ah kay :)


can you make an issue for adding descriptions here?


Just because it took me half an hour to remember that it's where I should drop my appleseed DLL :)


Right away


you can use tools from linaro project:
[link](http://www.linaro.org/blog/core-dump/energy-aware-scheduling-eas-progress-update
i have merged stuffs from android bullhead branch and @Kali- kernel.


Ah, that's a problem. There should always be a clear decoupling between the label shown in the UI (which could be translated etc.) and the actual value passed to appleseed.


You mean `return self.lang_dict.__contains__("key")`?


OK, I'll try and fix all the code smells I can (including existing occurrences)


tobatha ,readme这样写简介可以吗？HMTL5 Bad Code : 我从Bad Code中学到了什么 :作者tobatha ，前端开发/维护99.99%概率会见到过的一团糟页面，Web 2.0年代的前端开发与现在的移动前端的开发有着很多不同。


Resubmitting will not be required as in this commit, major work was on 2-D grid function but I already created separate grid.py file for all this function  #68.


@vitalis Thanks for spotting this! Are you already on it or would you like me to open another PR?


Volterra is equivalent to (Integral - Evaluation(first(d))*Integral)

But this becomes a LowRankPertOperator, and this erred when using getindex of a LowRankFun for some reason. So I made a Volterra calculus operator for the time being. In the special case of Legendre, Volterra is banded (the LowRankPertOperator is also banded because the first row is a finite functional numerically)

Cheers,

Mikael

> On Mar 6, 2016, at 7:57 AM, Sheehan Olver <notifications@github.com> wrote:
>
> What's the difference between Volterra and Integral?
>
> —
> Reply to this email directly or view it on GitHub.
>


missed a ] here


Thanks for the fix!
1) The (minor) problem with this is if you have disabled advanced map shading, change the specular, and enable it again. It will still use the old specular.
Example (typable in BAR's chonsole):
```
/advmapshading 0
/exec Spring.SetSunLighting({groundSpecularColor = {0, 1, 0, 1}})
/advmapshading 1
```
There is no difference.
If you modify the order:
```
/advmapshading 1
/exec Spring.SetSunLighting({groundSpecularColor = {0, 1, 0, 1}})
```
, map will be obviously green.

2) The bigger problem is that I still think groundSpecularColor is done badly right now. Ignoring it for maps with specularTex is odd (seems arbitrary and actually the opposite from what people except if you look at the wiki documentation/content dev comments), and having it work for non SSMF maps just breaks a lot of stuff and causes people to write these gadgets which just seem to work around what appears to be a hack. I don't have a good solution to this, except maybe deprecate groundSpecularColor and replace it with a different variable (e.g. groundSpecularColor2) or better yet introduce a version number in mapinfo.lua so some resemble of backwards compatibility is maintained (we are pretty much obligated to maintain it for maps anyway).


Das war nur zur Bequemlichkeit für meine lokale Entwicklungsumgebung. So doof ich Apache finde, ist es halt bei OSX vorinstalliert, und dann war das ganz praktisch die Datei zu haben und es nicht in in die globale Konfiguration packen zu müssen.


http://yugioh-wiki.net/index.php?%A1%D4%A5%DE%A5%B8%A5%B7%A5%E3%A5%F3%A5%BA%A1%A6%A5%CA%A5%D3%A5%B2%A1%BC%A5%C8%A1%D5
In yugioh-wiki, Magician's Navigate is TDIL-JP072.
But, In wikia, Magician's Navigate is TDIL-JP071...
Maybe yugioh-wiki mistake...


umm


unrelated to this PR but any idea why ```1``` is missing?


```and``` ?


http://yugioh.wikia.com/wiki/File:MagiciansNavigate-TDIL-JP-OP.png
It should be 071.

So let us change this card to 071 before anyone use it.


There is no such package in KaOS, I can add an opdepend line to chrome


@anarkia1976 was just thinking to try this on msm8939 but saw i upstream my sched which is very behind from angler and bullhead :(


hi
how do i download the filrs?
thank's
marco


JSHint -> JSLint


Trzeba będzie przetestować przed spotkaniem, czy przez to tło, tekst będzie równie czytelny.


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.recipe.codeanalysis/17/violations
```
plone/recipe/codeanalysis/__init__.py:176:13: T001 print function found.
plone/recipe/codeanalysis/__init__.py:191:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:200:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:248:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:59:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:66:13: T001 print function found.
plone/recipe/codeanalysis/tests/test_csslint.py:24:0: P103 other string does contain unindexed parameters
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Hello,

This commit corrupts the close dialog button on WP8.1.
I've tested only on the phone emulator and I don't know how it behaves on a read device with WP8.1.

Regards,
Cristi


Was curious about differences in this case, but maybe it is covered elsewhere.
AFAIK, `std_logic` and `bit` should both implicitly work in this case, without using `??`... e.g.

```
if A then
 ....
end if;
```

instead of
```
if A = '1' then
 ....
end if;
```

or

```
if ?? A then
 ....
end if;
```


Oh, and it should only show a message (and prevent you from committing) if the change fails to lint. Maybe try putting a error there deliberately and commit, just to test.


Any reason to remove the ```INVALID``` here while in the enums above they are kept?


this need to modify


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.recipe.codeanalysis/18/violations
```
plone/recipe/codeanalysis/__init__.py:176:13: T001 print function found.
plone/recipe/codeanalysis/__init__.py:191:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:200:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:248:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:59:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:66:13: T001 print function found.
plone/recipe/codeanalysis/entry_points.py:16:9: T001 print function found.
plone/recipe/codeanalysis/tests/test_csslint.py:24:0: P103 other string does contain unindexed parameters
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


no name the method `__conatins__` instead of `has_key`


Yup. Mam nadzieję, bo jednak slajdy na totalnie białym tle to IMHO najgorsze co może spotkać prezentację ;-)


this method is rather unusual...


Ciekawa opinia, z chęcią bym o niej szerzej porozmawiał :beers:


Hi~
Swift~


@Pub4Game Now fixed.


就因為一定是本人，所以不用放在這個 form 裡面，而是在 submit 時再自動填才對吧。

不過用 hidden field 有個好處是如果都沒人 review @ccwang002 還可以用這個 form 偷改欄位值，好像也不錯！


How so? It will be useful to check if all the necessary keys are available in coalang


@hemantkasat  . Yeah that's why I have closed my Pull request just after few minutes . As I have not taken care for corner cases. By the way this problem is there with your pull request also.
1)Bring two turtle
![screenshot from 2016-03-06 18 24 42](https://cloud.githubusercontent.com/assets/11407306/13554253/224534b6-e3c9-11e5-8096-9e08c663f900.png)
2) Delete the one that was moving
![screenshot from 2016-03-06 18 24 55](https://cloud.githubusercontent.com/assets/11407306/13554258/40f47534-e3c9-11e5-8aa1-0b5808f38661.png)
3) Now click on forward
![screenshot from 2016-03-06 18 25 03](https://cloud.githubusercontent.com/assets/11407306/13554262/54871e6c-e3c9-11e5-80cd-63573b46ffcc.png)


@gaearon Thanks for taking a look at this. I put together [a script](https://gist.github.com/robertknight/3ba6c04a9fa478c8300c) to try and get some idea of what developers are currently doing in constructors since React isn't especially prescriptive about that.

For some projects (eg. [Parse Dashboard components](https://gist.github.com/robertknight/211e9b6fd331a1791527) ) it would work because constructors just assign to `this.state` or set up bound functions. In others (eg. [Nuclide](https://gist.github.com/robertknight/e312c3fe02fdef6299e1)) this would indeed cause memory leaks and other problems.

Calling `componentWillMount` should be OK for most of those components but calling `componentWillUnmount` is going to fail for some of them because they assume that the component has actually been mounted and that they can use the DOM node etc, or they might rely on subscriptions etc. set up in `componentDidMount`.

Thoughts?


Pourquoi ne pas les corriger ?


很少有这样判断 false的 是什么错误会有？


There is something wrong with in_front_bb(Us, RANK_4)
It is fine when Us==WHITE, but for black it should be RANK_5


double backticks as we use rst now


Навигацию нужно поправить: 1) это ведь ссылки 2) можно было бы использовать ul список, хотя не обязательно, расскажу о плюсах 3) "__main" и др. должны быть модификаторами при необходимости, а элементы "top-nav" должны иметь одинаковый класс, иначе как ты их будешь стилизовать


e102b2a87964746c5934f8a923c18613e4169654 changed.
Thank you!


double backticks (everywhere)


1) am aware of that, but don't really care (advmapshading=0 needs to die)
2) groundSpecularColor has no reason to exist at all with SSMF, nobody would object if it disappeared


unnecessary import


Тут немного непонятно было в макете, но гамбургер и крестик это одна кнопка в разных состояниях. Показано где она должна быть и как выглядеть при открытом меню и при закрытом.


Hi @barbatus, tnx for the great work. Could you please elaborate more on why you're using `this.autorun` on this line?


it is the same line. Looks like removed in github


Have you tested coala-bear's tests on appveyor with this ?
Didnt this break it last time ?


The number to select what task to delete, like in TextBuddy


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.recipe.codeanalysis/19/violations
```
plone/recipe/codeanalysis/__init__.py:176:13: T001 print function found.
plone/recipe/codeanalysis/__init__.py:191:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:200:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:248:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:59:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:66:13: T001 print function found.
plone/recipe/codeanalysis/tests/test_csslint.py:24:0: P103 other string does contain unindexed parameters
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@MagicDroidX Great!


Bravo Doc :+1: hai qualcosa anche per flashx? toonitalia usa principalmente quello.


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.recipe.codeanalysis/20/violations
```
plone/recipe/codeanalysis/__init__.py:176:13: T001 print function found.
plone/recipe/codeanalysis/__init__.py:191:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:200:9: T001 print function found.
plone/recipe/codeanalysis/__init__.py:248:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:59:9: T001 print function found.
plone/recipe/codeanalysis/analyser.py:66:13: T001 print function found.
plone/recipe/codeanalysis/tests/test_csslint.py:24:0: P103 other string does contain unindexed parameters
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@jhass sorry, just turn off the Travis, didn't notice there is notification facility in diaspora


Error:(30, 10) Failed to resolve: ru.aviasales:aviasalesSdk:2.0.9-sdk


Bonne idée. Ah, mince, c'est pas mon fichier.


Логотип обычно ведет на Главную ) и это очень важный элемент страницы, нужно чтобы при отключении стилей пользователь видел текст вместо картинки


Это элемент оформления, поясню


все же лучше отдельным блоком


Can I delete this branch? (It's already in master)


Gefällt mir. :+1:


Escriba bien ☺☻


лучше избегать лишней разметки и делать это стилями


haha ...
Closes:
https://github.com/unified-db/Database/issues/155


Commits should have songtitles and songs assigned to it:
Suggestion: I wont let the sun go down on me..


I suggest to [omit the leading underscore](http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier#answer-228797 "What are the rules about using an underscore in a C++ identifier?") from such an identifier.
Other approaches are safer to make include guards reasonably unique.


;)  from


надо будет тебе немного рассказать о диватозе )


Deleting since it exactly matches master at 263ff5bfa684a7e7247caa7a988303298e78a47a.


@sils1297 sorry i don't follow,
are you saying i should use same indentation format for conf_file and CMakeLintBearTest
i.e
conf_file = os.path.join(
                      os.path.dirname(__file__),
                      "test_files",
                      "cmake_config.txt")


((A and B) or !A) != (!A or B)


with 4 spaces on each arguments


It should be "22**nd**", I guess.


the indentation for conf_file is fine. Just do:

```python
CMakeLintBear...Test = verify_local_bear(
    CMakeLintBear,
    ...)
```


It should be "August 2**nd**".


ooh so you mean 4 spaces from starting of line, i thought 4 spaces from verify_local_bear
sorry my bad


> I can add an opdepend line to chrome

Yes but QtWebEngine won't find the plugin in ``/opt/google/chrome-unstable/PepperFlash`` as it looks for the plugin in the following paths:

- /usr/lib/pepperflashplugin-nonfree/libpepflashplayer.so
- /usr/lib/PepperFlash/libpepflashplayer.so
- /usr/lib64/chromium/PepperFlash/libpepflashplayer.so

``google-chrome`` package would need to be adjusted (maybe just add a symlink).
Another option is to patch the MellowPlayer desktop files  and add ``--ppapi-flash-path=/opt/google/chrome-unstable/PepperFlash/libpepflashplayer.so`` to the exec command.

See https://doc-snapshots.qt.io/qt5-5.6/qtwebengine-platform-notes.html#pepper-flash-player-plugin-support

BTW the new qupzilla will need this too.


project closed xD


I don't Know why this commit Can't merge :(


yes :dancers:


5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (2130 of 2136 tests passed, 3 test warnings)

 * 9 tests had: AUD diffs.
 * 9 tests had: MDD diffs.
 * 9 tests had: MTD diffs.
 * 1 test had: ERR diffs.
 * 6 tests had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: RDD diffs.
 * 1 test had: Table big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


Oops, I mean fixes #8625


@kbenne At your leisure, could you install MacTeX on @nrel-bot-3?   Thanks!


ah the previous commit was reverted?


excellent!!


ack


LGTM


Ok


please add a documentation comment for the config


а зачем их в хеш класть, а не в массив? какой физический смысл у этого `movie_111` и чем оно может быть полезно при чтении файла? это раз.

А два — тебе не кажется, что код получился довольно сильно запутанный?
Не стоит ли попробовать здесь использовать класс Movie, добавив ЕМУ возможность сохранять себя и т.д.?..


>Calling componentWillMount should be OK for most of those components but calling componentWillUnmount is going to fail for some of them because they assume that the component has actually been mounted and that they can use the DOM node etc

Actually `componentWillMount` runs before DOM node is available so I don’t think is the case. It also runs during server rendering so people should not try to access DOM there anyway, and it is a safer assumption to make.


I recommend you to post it to the relevant JIRA issue instead.
FWIW, I don't think reverting a merged patch to emit invalid JSON is very likely to happen.
You may want to propose a patch that allows users to disable the check.


I think for configs we should use the `path` conversion! Instead of `str` write `path` and do a `from coalib.settings.Setting import path` on top.

@AbdealiJK I think we should do this in other bears too!


@perexg Why abort here?
This means that entering a retention/removal of 100 days will 'crash' tvheadend on 32-bit machines?


I wouldn't worry about optimization here, because you will rarely see a difference in practice.

 In this commit, almost all cases are like ``` std::string var = sConfig.GetStringDefault( "..." );``` so you have the copy anyway. The only other case I can quickly find in this commit is ```SetAHBotIncludes```, which indeed takes a const reference as argument. Don't worry about multiple copies either; your compiler will use return value optimization whenever possible, so you will see just one copy constructor being called, and that was already the case.

Conclusion: there is no difference for the majority of the code, and there is no problem for the other code.

By the way: :+1: for removing all that const char* C stuff!


background: the path routine automatically takes the position of the coafile into account, if I give a path relative to the coafile it'll still work if I use path, it won't if I use str.


fyk: if u update the builtin supersu zip in your rom source, before a dirty flash remove supersu folders in both /data/app and /data/data, then all will work well. otherwise supersu app won't probably find the su bin. ps: i've used this custom systemmode supersu 2.68 zip: http://forum.xda-developers.com/apps/supersu/v2-64-2-66-supersu-mode-t3286120 but the trick should be good for official versions too


This is to clearly show that SkeletonAnimator is separate from Baking, and to not show the Baking message while the user only wants to use SkeletonAnimator.


1) I'm ok with that. I also can't imagine a great number of people following the scenario I gave.
2) I don't quite understand the whole design there tbh. I'm ok with killing off groundSpecularColor (and unitSpecularColor) - I think doing that is better than the current situation, but I also don't realize why we have both ground AND unit Diffuse/Ambient parameters. I would have much preferred a single sunColor (the diffuse) and some ambient lighting properties (I guess ambientColor would do).

Long story short, let's just nuke the specular for now, but also have an idea how we really wants this to be designed. (this is where I pretty much want your guidance)


Makes sense :)


5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - i386-Windows-7-VisualStudio-12: OK (2130 of 2136 tests passed, 3 test warnings)

 * 9 tests had: AUD diffs.
 * 9 tests had: MDD diffs.
 * 9 tests had: MTD diffs.
 * 1 test had: ERR diffs.
 * 6 tests had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: RDD diffs.
 * 1 test had: Table big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


лучше использовать button submit


If no one is using the dense matrix for anything that requires it,  I can move it to the tests and remove it from the exported api.


:param cmakelint_config: The location of the cmakelintrc config file.
is this fine ?


Should this be gnatsd?


You can probably delete this file


Endret til `input` og fjernet klassen fra html-visningen.


тут в некоторых местах + на - заменить


ссылки, в общем то же, что и в навигации


правила определения категорий пока не делал тк неясно в каком виде оно будет приходить - сейчас просто по equals


I don't think so, see the comments on line 166 of bitboard.h and the implementation in line 161 of bitboard.c


нужно обсудить


@lennart683: the last commit does not seem to work for iOS-9.2.1 and Swift-2.1.1: I keep getting the following error: "'BKTemperatureProfileLoader' is unavailable: cannot find Swift declaration for this class" - do you have any idea what is missing ??


он и используется


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.intid/1/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/intid/setuphandlers.py:0:1: I001 isort found changes, run it on the file
plone/app/intid/setuphandlers.py:13:1: B901 blind except: statement
plone/app/intid/setuphandlers.py:27:12: P002 found "hasattr", consider replacing it
plone/app/intid/setuphandlers.py:59:12: Q000 Remove bad quotes.
plone/app/intid/setuphandlers.py:67:13: Q000 Remove bad quotes.
plone/app/intid/setuphandlers.py:68:13: Q000 Remove bad quotes.
plone/app/intid/setuphandlers.py:68:35: S001 found % formatter
plone/app/intid/testing.py:0:1: I001 isort found changes, run it on the file
plone/app/intid/testing.py:17:40: Q000 Remove bad quotes.
plone/app/intid/tests/__init__.py:0:1: C101 Coding magic comment not found
plone/app/intid/tests/test_setup.py:0:1: I001 isort found changes, run it on the file
plone/app/intid/tests/test_setup.py:20:47: Q000 Remove bad quotes.
plone/app/intid/tests/test_setup.py:21:12: E713 test for membership should be 'not in'
plone/app/intid/tests/test_setup.py:21:16: Q000 Remove bad quotes.
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.behavior/1/violations
```
plone/behavior/__init__.py:0:1: I001 isort found changes, run it on the file
plone/behavior/annotation.py:0:1: I001 isort found changes, run it on the file
plone/behavior/registration.py:0:1: I001 isort found changes, run it on the file
plone/behavior/tests.py:0:1: I001 isort found changes, run it on the file
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@albertcasado Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plonetheme.barceloneta/1/violations
```
Traceback (most recent call last):
  File "/home/jenkins/workspace/package-plonetheme.barceloneta/bin/flake8", line 31, in <module>
    sys.exit(flake8.main.main())
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/main.py", line 33, in main
    report = flake8_style.check_files()
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 181, in check_files
    return self._retry_serial(self._styleguide.check_files, paths=paths)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 172, in _retry_serial
    return func(*args, **kwargs)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1842, in check_files
    runner(path)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 126, in input_file
    return fchecker.check_all(expected=expected, line_offset=line_offset)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1574, in check_all
    self.check_ast()
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1521, in check_ast
    for lineno, offset, text, check in checker.run():
  File "/home/jenkins/.buildout/eggs/flake8_debugger-1.4.0-py2.7.egg/flake8_debugger.py", line 23, in run
    with open(self.filename, 'r') as file_to_check:
IOError: [Errno 2] No such file or directory: 'plone'
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@bloodbare Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plonetheme.barceloneta/2/violations
```
Traceback (most recent call last):
  File "/home/jenkins/workspace/package-plonetheme.barceloneta/bin/flake8", line 31, in <module>
    sys.exit(flake8.main.main())
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/main.py", line 33, in main
    report = flake8_style.check_files()
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 181, in check_files
    return self._retry_serial(self._styleguide.check_files, paths=paths)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 172, in _retry_serial
    return func(*args, **kwargs)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1842, in check_files
    runner(path)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 126, in input_file
    return fchecker.check_all(expected=expected, line_offset=line_offset)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1574, in check_all
    self.check_ast()
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1521, in check_ast
    for lineno, offset, text, check in checker.run():
  File "/home/jenkins/.buildout/eggs/flake8_debugger-1.4.0-py2.7.egg/flake8_debugger.py", line 23, in run
    with open(self.filename, 'r') as file_to_check:
IOError: [Errno 2] No such file or directory: 'plone'
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@pigeonflight Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plonetheme.barceloneta/3/violations
```
Traceback (most recent call last):
  File "/home/jenkins/workspace/package-plonetheme.barceloneta@2/bin/flake8", line 31, in <module>
    sys.exit(flake8.main.main())
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/main.py", line 33, in main
    report = flake8_style.check_files()
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 181, in check_files
    return self._retry_serial(self._styleguide.check_files, paths=paths)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 172, in _retry_serial
    return func(*args, **kwargs)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1842, in check_files
    runner(path)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 126, in input_file
    return fchecker.check_all(expected=expected, line_offset=line_offset)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1574, in check_all
    self.check_ast()
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1521, in check_ast
    for lineno, offset, text, check in checker.run():
  File "/home/jenkins/.buildout/eggs/flake8_debugger-1.4.0-py2.7.egg/flake8_debugger.py", line 23, in run
    with open(self.filename, 'r') as file_to_check:
IOError: [Errno 2] No such file or directory: 'plone'
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.intid/2/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/intid/setuphandlers.py:0:1: I001 isort found changes, run it on the file
plone/app/intid/setuphandlers.py:13:1: B901 blind except: statement
plone/app/intid/setuphandlers.py:27:12: P002 found "hasattr", consider replacing it
plone/app/intid/setuphandlers.py:59:12: Q000 Remove bad quotes.
plone/app/intid/setuphandlers.py:67:13: Q000 Remove bad quotes.
plone/app/intid/setuphandlers.py:68:13: Q000 Remove bad quotes.
plone/app/intid/setuphandlers.py:68:35: S001 found % formatter
plone/app/intid/testing.py:0:1: I001 isort found changes, run it on the file
plone/app/intid/testing.py:17:40: Q000 Remove bad quotes.
plone/app/intid/tests/__init__.py:0:1: C101 Coding magic comment not found
plone/app/intid/tests/test_setup.py:0:1: I001 isort found changes, run it on the file
plone/app/intid/tests/test_setup.py:18:47: Q000 Remove bad quotes.
plone/app/intid/tests/test_setup.py:19:12: Q000 Remove bad quotes.
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@allcaps Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plonetheme.barceloneta/4/violations
```
Traceback (most recent call last):
  File "/home/jenkins/workspace/package-plonetheme.barceloneta/bin/flake8", line 31, in <module>
    sys.exit(flake8.main.main())
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/main.py", line 33, in main
    report = flake8_style.check_files()
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 181, in check_files
    return self._retry_serial(self._styleguide.check_files, paths=paths)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 172, in _retry_serial
    return func(*args, **kwargs)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1842, in check_files
    runner(path)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 126, in input_file
    return fchecker.check_all(expected=expected, line_offset=line_offset)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1574, in check_all
    self.check_ast()
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1521, in check_ast
    for lineno, offset, text, check in checker.run():
  File "/home/jenkins/.buildout/eggs/flake8_debugger-1.4.0-py2.7.egg/flake8_debugger.py", line 23, in run
    with open(self.filename, 'r') as file_to_check:
IOError: [Errno 2] No such file or directory: 'plone'
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


ok


On Sun, 2016-03-06 at 05:24 -0800, Alexandre Cassen wrote:

> ((A and B) or !A) != (!A or B)
>

I've just double checked this, and it appears to me that ((A and B) or !
A) = (!A or B)

A   B        !A or B        A and B    !A        ((A and B) or !A)
0   0              1                 0          1                     1
0   1              1                 0          1                     1
1   0              0                 0          0                     0
1   1              1                 1          0                     1

Have I got this wrong somewhere?

Quentin


обсудить


@vikas-parashar Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plonetheme.barceloneta/6/violations
```
Traceback (most recent call last):
  File "/home/jenkins/workspace/package-plonetheme.barceloneta/bin/flake8", line 31, in <module>
    sys.exit(flake8.main.main())
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/main.py", line 33, in main
    report = flake8_style.check_files()
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 181, in check_files
    return self._retry_serial(self._styleguide.check_files, paths=paths)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 172, in _retry_serial
    return func(*args, **kwargs)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1842, in check_files
    runner(path)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 126, in input_file
    return fchecker.check_all(expected=expected, line_offset=line_offset)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1574, in check_all
    self.check_ast()
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1521, in check_ast
    for lineno, offset, text, check in checker.run():
  File "/home/jenkins/.buildout/eggs/flake8_debugger-1.4.0-py2.7.egg/flake8_debugger.py", line 23, in run
    with open(self.filename, 'r') as file_to_check:
IOError: [Errno 2] No such file or directory: 'plone'
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plonetheme.barceloneta/7/violations
```
Traceback (most recent call last):
  File "/home/jenkins/workspace/package-plonetheme.barceloneta@2/bin/flake8", line 31, in <module>
    sys.exit(flake8.main.main())
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/main.py", line 33, in main
    report = flake8_style.check_files()
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 181, in check_files
    return self._retry_serial(self._styleguide.check_files, paths=paths)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 172, in _retry_serial
    return func(*args, **kwargs)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1842, in check_files
    runner(path)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 126, in input_file
    return fchecker.check_all(expected=expected, line_offset=line_offset)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1574, in check_all
    self.check_ast()
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1521, in check_ast
    for lineno, offset, text, check in checker.run():
  File "/home/jenkins/.buildout/eggs/flake8_debugger-1.4.0-py2.7.egg/flake8_debugger.py", line 23, in run
    with open(self.filename, 'r') as file_to_check:
IOError: [Errno 2] No such file or directory: 'plone'
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@vangheem Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plonetheme.barceloneta/8/violations
```
Traceback (most recent call last):
  File "/home/jenkins/workspace/package-plonetheme.barceloneta@3/bin/flake8", line 31, in <module>
    sys.exit(flake8.main.main())
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/main.py", line 33, in main
    report = flake8_style.check_files()
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 181, in check_files
    return self._retry_serial(self._styleguide.check_files, paths=paths)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 172, in _retry_serial
    return func(*args, **kwargs)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1842, in check_files
    runner(path)
  File "/home/jenkins/.buildout/eggs/flake8-2.5.4-py2.7.egg/flake8/engine.py", line 126, in input_file
    return fchecker.check_all(expected=expected, line_offset=line_offset)
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1574, in check_all
    self.check_ast()
  File "/home/jenkins/.buildout/eggs/pep8-1.7.0-py2.7.egg/pep8.py", line 1521, in check_ast
    for lineno, offset, text, check in checker.run():
  File "/home/jenkins/.buildout/eggs/flake8_debugger-1.4.0-py2.7.egg/flake8_debugger.py", line 23, in run
    with open(self.filename, 'r') as file_to_check:
IOError: [Errno 2] No such file or directory: 'plone'
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


не несет такой смысловой нагрузки, чтобы делать картинкой


dafuq?


да - для конвертации csv в тестовую xml


OK, I've merged your code into mine.

It's here: https://github.com/martinbudden/cleanflight/tree/nrf24

As well as your V202 protocol I've implemented receivers for the SymaX, SymaX5C and Cheerson CX10A protocols (getting the XN297 stuff working was a bit of a nightmare, but eventually I got it working, using lots of DeviationTX magic).

I've included your Crazepony target and it is built using just the V202 protocol, so no ROM wasted using the other protocols. I've also added a `SKIP_RX_PWM` `#define` to the code - I've put this in the Crazepony `target.h` file, but it is commented out. You may want to experiment with it. I had a brief try with it, but it doesn't seem to free up enough ROM to include the Baro. (I have a future plan to put the PIDs on build flags, so that the small ROM boards only need to include one PID, that should free up enough ROM to allow the Baro.)

I've also changed the CJMCU target so that it defaults to using the V202 protocol (also no other protocols are included in that target).

I don't yet have a Crazepony (one on order) so I haven't actually tested the merged code on actual hardware, so I'd appreciate it if you just checked that it is still working.

I'm away from home at the moment, so I couldn't test on a CJMCU either. I have access to a CC3D, so I've build the code for that and run on there, spoofing the RX output and that seems to work OK.

By the way, I've changed the RC channels to use AETR, so be aware of that.

I've also added test code.

Let me know if there is anything you think is wrong, or like to see changed. I've tried to make minimal changes to your code in the merge, but I may have made some changes you don't like. If so let me know and I'll try and fix them.

Once all is OK I'll raise a PR for Cleanflight. Hydra seems to be taking a well deserved break after the v1.12 release, so we have time to iron out any problems.


Well, at least now there's no risk of losing these changes, although this commit will complicate a future PR.