:+1:  yeah, you can return a `Future` from resolve method. In fact you can return quite a few interesting things: http://sangria-graphql.org/learn/#actions


Maybe factor this into separate function?


Ah, purely for the IGNORECASE? I'm sure we can find a better way to do that...

```python
    def do_command_output_sub(self, cmd, regex, subst, ignore_case=False)
```

For e.g.


Yep it could be moved to before the do, will fix this part later on if this is a working solution.


I'm not sure, but is it relevant whether the indentation aligns with the rest of the command?


This adds confusion as you add a lot of stuff then remove a lot of stuff. I would rather just add the necessary and describe in the one commit.


We can do this, but... https://github.com/alphagov/paas-cf/commit/e997f4eb28f7116275fc62d732091900a659a579 is just for smoke-tests. To make it clear we would have to first merge https://github.com/alphagov/paas-cf/commit/e997f4eb28f7116275fc62d732091900a659a579 with https://github.com/alphagov/paas-cf/commit/afd3b3487709b9d70632ba47c0339ca2ce586b57 and then squash https://github.com/alphagov/paas-cf/commit/666ec0503326f0b6f3940bae7f450835a6401f9a with the new one.


lol


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18004](https://teamcity.mesosphere.io/viewLog.html?buildId=151288&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 246 Build time: 00:04:05


Why don't you look in bin for the .bat?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18005](https://teamcity.mesosphere.io/viewLog.html?buildId=151292&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 245 Build time: 00:04:58


This could have a better explanation. Or a less hacky solution?


Does this work or no?  I was gonna add some stuff to testing here but don't want to if this is no good.


Something that would return set up `events` which might be passed then, for example from `create` to `new Api()`


ha! No wonder it was down for a bit!


文档千万


why are we appending empty html content here? -> .html("")...


The return value should be checked.


**FAILURE** - TeamCity HotRod C# Client :: Pull requests monitor - WIN_S2012 [Build 89](http://ci.infinispan.org/viewLog.html?buildId=36902&buildTypeId=HotRodCSharp_PullRequestsMonitorWinS2012&guest=1) for 9ddcf6b389ecdc8144348182d4faf966b2c9cee1
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:06:07

Process exited with code 1


**FAILURE** - TeamCity HotRod C# Client :: Pull requests monitor - WIN_S2012 [Build 89](http://ci.infinispan.org/viewLog.html?buildId=36902&buildTypeId=HotRodCSharp_PullRequestsMonitorWinS2012&guest=1) for 9ddcf6b389ecdc8144348182d4faf966b2c9cee1
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:06:06

Process exited with code 1


cc @AlbertoFuente @makotot @Rokt33r @Layzie @charbelrami @sohje for new translations. Thanks


Fix formatting issues


Im glad its working for you!

You should be able to download the correctly named file from https://github.com/Blu3wolf/Treefarm-Lite/releases just underneath the Downloads heading for the specific release.

Next job is to try get rid of the lag TreeFarm has...


This will fail on 1.11.0, it does have to be `>=` to work as intended.


is this working or still WIP?


:clap: :clap: :clap:


What I normally do in such cases is: I handle some of the exceptions and propagate the error message to the client, as you did above. For all other (unexpected/internal) exceptions i log them on the server with some correlation ID. In this case client gets obfuscated error message like: "Internal Server Error. Correlation ID is 123456-12345-54752468". Correlation ID will help if clients will come back to you and ask for explanation. but in most real-world scenarios I will not expose error message as-is because it can be something like mongo primary reelection exceptions which you don't necessarily want clients to see.


ok this will be ok but need more awesome :sparkle:  title


"This is a temporary fix until the go container receives a new curl version."


This is a bad thing to do - what if people use other python-dateutil version in the same environment? It makes sense to *exclude* versions in install_requires, not to pin them.


in this if check, you can simple use if (temperatureData), so that it will check for "", undefined, null


Removed redundant cast to View


same set of comments apply here as well


If you use `abort` instead of `raise` you won't get a stack trace and simply print out this message. Way better then simulating an error here IMO


this does not test much :-) second argument is custom message so it just asserts that true is true, it should rather test it like this `assert manager.confirm_scenario_change(new_config)`

also on lines below


Dito


I said don't copy TFM make your own, you claimed it was yours so I merged it.


@jbgi It will compile from the build script (build scripts are good at that).

It may or may not compile from your IDE depending on which one it is and how it is configured.

This is friction - it still exists for JSR269.


@fffw Added udpgw port (thanks for catching that!)

@myleshorton Removed UDP hangouts ports


There are different keys for dev and prod env:
https://github.com/Wikia/app/blob/8737102b0a81bad50795fe5329c2e34e1a3d5ed3/extensions/wikia/ExactTargetUpdates/tasks/ExactTargetWikiTaskHelper.php#L267
It's needed to be fixed before finishing this PR.


better putting these device type names into CONSTANTS and use the CONSTANTS here


Merged. Not sure how it happened that it wasn't squashed but description was same.


Ta commit je bil narejen po pomoti.


Why are we always logging these values?


I just want to say I love your code cleanups. They were long overdue. :+1:


Being new to this piece of code, I find the variable names a bit confusing, and wonder if something with more contextual meaning than value might help..

```ruby
def within_eight_weeks_of_current_sickness_period?(current_sickness_start_date)
  earliest_allowed_date = sick_start_date - 8.weeks - 1.day
  current_sickness_start_date >= earliest_allowed_date
end
```


:trollface:


what is the purpose of returning an empty object if no match is found?


I seem to have missed these in 60f69224508ba1d893abdc206b2ea3349b8e2e84


"Older versions of curl have problems with two occurrences  of double
quotes." . We need to keep it until golang container will move to newer version os Debian.


you can simply use result = {}; here


> Why don't you look in bin for the .bat?

The PATH is not added to find t.list (t.list.bat), that is already correctly found also on windows.

t.list.py calls parser()  which starts g.parser (g.parser.exe) and that must be in PATH.


fix formatting issues


@hcoles One other small point to consider: adding or removing Lombok to a project is easier than auto IMO. With Lombok you can add a valid equals/hashcode implementation to existing classes with no other changes. With auto you have to go create the abstract classes and change the usage elsewhere in the code. Perhaps this is why Lombok feels more natural to me. You use classes exactly like you normally would except you don't have to write all the boilerplate. If you decide you don't like Lombok you can run delombok on your classes with Lombok annotations and you are left with the code as you would have written it anyway. Removing auto leaves you with all the abstract classes and references to AutoValue in your code and requires a bit more refactoring to fully clean up.


I would describe what is in this test more clearly.


@ThunderGemios10,
The question is more: Do I have to compile it myself or not?


when using quotes for strings, always use one consistent approach rather than using both single & double quotes here and there.


Are `HAS_DIGIPOTSS` and `DAC_STEPPER_CURRENT` mutually exclusive?


The controller is named `storeController` but you refer to it as `login`, which is the right name of this controller? :)


This string is used 3 or 4 times. Feels like we should refactor it as well.


this is first merging


@AMikhniev , we don need to use SPtr there, because we dont copy this pointer to any places, and we can correctly delete this objects directly in tests(without any crashes). + if we will use SPtr, we will have a lot of useless code in tests.


same set of comments apply here as well


sdfsdf


@ulumulu1510 hmm To compile? or not to compile? That is the question.


I stated "Some code from: [TotalFreedomMod](https://github.com/TotalFreedom/TotalFreedomMod)" from this point on I will not copy any sort of code.


橘色是標示出location.hash，在URL上會顯示此行的#
ex. https://github.com/sony9154/DoubleAircraftDisplay/commit/79e191764b6b4d52b8135134ef4bdafabff5344e#diff-2d7f7cfa14ef769622f304ec5201423fR7


Why 1445? Can you justify this change in the commit message?


Of course, you won't include this file in your PR. :grinning:


You are assuming that this values are empty strings, is it really what you want? You are forcing yoursefl to assign a value to this properties.


instancetype是傳回此class的型別，在這的話相當於傳回`AirplainManager`。


Very nice and clean that you found this. You have good eyes =)


can simply use if (cupData)


This is not super clear to me.


Also, changed `config/environments/development.rb` so assets are merged before being served even in development mode. This makes the website serve much faster.


jkjkjkjk


This interface represents a list of options which can be applied to any test runner right?
If this is the case, should the interface actually contain a `port`? I can imagine that there are test runners which don't need a port to run on.


formatting issues with spacing -> should be like -> } else {


can simply use if (ramData)


formatting issues with spacing -> should be like -> if (cupData) { ...


Do we want to keep factories in the same file?


Could we assert that `tag` if nil instead of repeating the selector? Or does #find raise an exception.. can't remember..


You don't want to add all uses of crackurl, but only those belonging to locky processes (in case there are multiple pieces of malware running during a given run)

-Brad


If this file is _a lot_ like `pins_PRINTRBOARD.h` then you can start out with…
```cpp
#include "pins_PRINTRBOARD.h"
```
…and then just include the differences.


formatting issues with spacing -> should be like -> function updateCPUGraph (CPUData) {


Thank you for your pull request! Looks great!


ok


why is this function used to only wrap another function?


formatting issues with spacing -> should be like -> function renderCPUChart (chartDataRaw) {


這是objectivec在instance初始化時的慣例寫法 。父類別的初始化失敗時會傳回`nil`，在if判定裡`self = nil`時就不會執行此instance的初始化，而直接回傳`nil`。


"as root at" - at what?


@AMikhniev , i`ll remove shared_pointer.h from this test, because including header for one using irrational.


I agree that all the code around here is very confusing. That was my motivation behind #2280 which I'm now hope to bring back to life.

The fact that you've chosen the wrong name for the parameter highlights the fact that this code is confusing. A more appropriate name would've been `previous_sickness_end_date`. I'll add a commit to address this now.


Yeah, that's true. The idea is that the framework just gives out free ports to each test runner. It doesn't know if the test runner actually needs it, but if he wants, he can.

This is not ideal, but i don't know of a better way. I thought of adding a `static` port distributor, but each test runner will run in its own child process, and thus each test runner will have it's own 'instance' of the static port distributor.


Missing library, oops


Okay, done. Also noticed I had two "if you cast if from your hand" statements in there previously.


我習慣簡寫。
https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundation/Classes/NSArray_Class/#//apple_ref/occ/clm/NSArray/array


please remove above commented code in order to make the code clean.


ありがとうございます。
こんなにシンプルになるんだ！、と驚きました。:laughing:


LA LA LA LA LA


Why are we appending an empty string as html here?


PIDFILE in line 23 hasn't been re-factored for $SERVICE. It still resolves $NAME. You end up with pid files w/o prefix.


А он весь остальной конфиг не перетрет таким образом?


I wonder if there adding a `.rubocop.yml` file to the root folder and disabling this rule over the whole project get's a little more visibility that smart answers is using `eval`, and that's it's something we'd like to remove.


ok


Brady after these modifications I am able to fix categories issue
https://github.com/practiceprovider/openemr/commit/d21f9c978b2c4229d84ac89ae6a2692274610fae

Regex "/e" modifier is not supported in PHP7


Fix formatting issues like improper spacing


@AMikhniev , on [line 265](https://github.com/LuxoftSDL/sdl_core/blob/f76e2cfe80997531f8a9fbd9b6e2d4592a5d2b0c/src/components/protocol_handler/include/protocol_handler/protocol_handler_impl.h#L290) you can see first declaration of 'private'.  and second is redundant.


Just EssX, we haven't made significant changes to other parts of the project.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18006](https://teamcity.mesosphere.io/viewLog.html?buildId=151293&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 246 Build time: 00:04:44


I added syncing of the clipRect attributes for good measure: https://github.com/rstudio/rstudio/commit/583384aeccf8e46f41fcf54dfa1431c6560a5363


good point


typo


:gem: sure


I am so sorry that i can not understant every part,If possible ,can you give me some articals about your codes?


why are we using a new function definition here just to wrap a another function here?>


i ko praim sia


Nope. Find proper UUID java class to handle this type. And name will be `id` (Create base java class for all our model class which will have id field).


Нет, textEditor.options имеет тип vscode.TextEditorOptions в котором определены только insertSpaces и tabSize


@neobuddy89 Yeah actually camera don't work good with this.

- Front cam preview is mirror (opposite) of the one it should be (It is solved by using latest camera HAL tho)

- Video recording is just going crazy like whole screen blacks out or goes full white

- No flashlight detected by camera or any other 3rd party app too

So bug 1 is solved by the new HAL but with that pictures do not capture and is highly unstable. Maybe the old blobs do not work with new HAL.
I just got back to this thing today and was busy with my finals :p


Oh well, not even a 50/50 guess, current or previous... not my lucky day


Wrong type and name. (See Deck)


formatting issues with spacing -> should be like -> function renderRAMChart(chartDataRaw) {


I think if we can just verify that locator and manipulate plot clicking work as expected we're good to go!


This commit breaks #send semantics for all Object and Kernel instance methods on OpenStructs. https://bugs.ruby-lang.org/issues/12136

Try `OpenStruct.new(format: :bar).send :format` or `OpenStruct.new(methods: :bar).send :methods` to verify.


s/fields has valid data/fields have valid data/


formatting issues with spacing -> should be like -> for (var i = 0; i < chartDataRaw.length; i++) {


kak o comments be nali komentirah


Alright, thanks for letting me know. :)


Does this change need to be moved to a new update_1.2.sql file?  I'm not very familiar with the Usage module's history, but version 1.1 was release in 2013, so any schema changes since then should be in a separate update script, right?


Ок.


formatting issues with spacing -> should be like ->
chartData.push({x: parseInt(chartDataRaw[i].x), y: parseInt(chartDataRaw[i].y)});


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18007](https://teamcity.mesosphere.io/viewLog.html?buildId=151298&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 245 Build time: 00:03:54


no build script necessary, it will compile with javac (given auto value in classpath). If your java IDE is not good at compiling Java then better ditch it.
Ecj also has problems compiling java 8 even without annotations processing involved (fail at type inference).


Why are we appending an empty string as html here?


@thornomad I think this accomplishes what you mentioned in https://github.com/NEU-Libraries/drs-toolkit-wp-theme/pull/6 but if not, feel free to modify. The only thing I can think of about this method that wouldn't be beneficial is if the person didn't want a custom_footer at all. The div structure would then be left in the footer- though they could just hide it with CSS.


Может этот метод в хелпер перенести?


unnecessary line break


TeamCity LabKey :: LabkeyRelease15.3 :: CDS postgres 9.4 [Build 167](https://teamcity.labkey.org/viewLog.html?buildId=307097&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:48


I'm very curious as well. @melix, did you also benchmark ArrayList?


We can't use __init__ since we need to wait all __init__ for all types to be performed before being able to evaluate any expression


You left the `self` here.


It was for less than 1 minute!


It's better when it's pushed


fix formatting issues -> improper indentation


@originalpete Welcome!


You mean something like:
```
  var scrollTimer;
  var setupSmartScroll = function(mouseWheelZoomInteraction) {
    mouseWheelZoomInteraction.setActive(false);
    if (scrollTimer) {
      clearInterval(scrollTimer);
    }
    scrollTimer = setTimeout(function() {
      mouseWheelZoomInteraction.setActive(true);
    }, 500);
  };

  $(window).on('scroll', function(e) {
    setupSmartScroll(mouseWheelZoomInteraction);
  });
```
?


Yes, that's why I suggested adding `cl_static_init`.


Very cool but f you want to do it npm style you are def going to need to to run it with foreman because of process.env.MONGOLAB_URI


Change to `IdentifiableEntity`


Sure - or more in general:

```python
    def do_cmd_output_sub(self, cmd, regex, subst, re_flags=None)
```

e.g. I see that the cluster plugin seems to do the same in order to set MULTILINE.

Should this PR wait for that change though?


Indented too much, can you fix them?


Make it final


please refer to my comments in your PR named "Add sensor types for CPU Load and RAM Usage" for correcting issues of this PR as well


Does this fix allow for customization of bootstrap-sass within the /src/styles directory? If so, how?


why a console.log is here?


++ 这个不翻译比较好


Hi @thjashin

Thanks for the pull request. I think i would prefer if we don't hardcode the "epsilons" into the functions.

what about reformatting `log_normal(x, mean, sd)` to something like `log_normal(x, mean, sd, eps=0.0)` ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18008](https://teamcity.mesosphere.io/viewLog.html?buildId=151302&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 245 Build time: 00:03:42


formatting issues -> should be like -> function initDate() {


@jordanjennings the class generated by AutoValue is package private and typically only referenced by the annotated abstract class. If you remove auto, only the annotated ```Animal``` class of the example need to be modified. In fact the refacto is quite simple: you take the generated ```AutoValue_Animal``` and copy its content into ```Animal```, then remove ```extends Animal``` and ```override``` occurrences. done.


It successfully build the solution with VS 2015.


No, more like this:

    app.utils.setupSmartScroll = function(mouseWheelZoomInteraction) {
      var scrollTimer;
      $(window).on('scroll', function(e) {
        mouseWheelZoomInteraction.setActive(false);
        if (scrollTimer) {
          clearInterval(scrollTimer);
        }
        scrollTimer = setTimeout(function() {
          mouseWheelZoomInteraction.setActive(true);
        }, 500);
      });
    }

    ..

    app.utils.setupSmartScroll(mouseWheelZoomInteraction);

Then you also can use this function in ` c2corg_ui/static/js/map/map.js `.


Ok, it makes sense. Could you add that info to the commit message maybe?


> Might be better to use uid if a truly unique value matters.

It just needs to be unique-ish for normal human speed interaction.  (note we do the same thing for our primary signer).


be consistent on selecting the type of quotes used. better using only double quotes.


merging


fix formatting issues with spacing -> should be like
} else if (uriMatcher.match("/{context}/api/stats/group")) { ...


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/28279/testReport/) for this commit**


why are we always logging this value?


TeamCity LabKey :: LabkeyRelease15.3 :: CDS postgres 9.4 [Build 168](https://teamcity.labkey.org/viewLog.html?buildId=307099&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:44


Let me know abut problems


@sils1297 Edited documentation, added tests.


some changes by arif


Wah udh tambah komplit user schema nya :) some comments ya:

Location index nya cuma bisa di satu attribute, tapi boleh array. See [geoNear](https://docs.mongodb.org/manual/reference/operator/aggregation/geoNear/#behavior). Jd nanti kalau ada multiple addresses, coordinates nya perlu dipisah keluar. Masih kurang jelas sih gimana buatnya yg bener, nanti aku bikin kalo udh ngerti. Yg pake [long, lat] jg ternyata udh kuno, skrg pakenya [GeoJson](https://docs.mongodb.org/manual/reference/geojson/).

Yg address kynya lebih flexible ada address schema yg ada type nya ('home', 'campus', etc.), terus field nya di user as array of addresses. Mungkin di tiap address bisa dikasih 'isMeetingLocation' buat tandain kalo di sana bisa buat lesson. Buat campus masih pikir2 lebih baik addressnya dicopy ke user atau jangan.

Nah membership justru kynya jangan di membership array, soalnya querynya jd susah kalo hrs cari item yg providernya sama. Buat diquery lebih enak kalo membershipnya langsung `facebook: {MembershipSchema}, google: {MembershipSchema}`. Jd misal cari temen tinggal carinya yg `facebook.userId in facebook.friends or google.userId in google.friends`. Memang kalo ntar ada provider baru jd hrs tambah attribute.

Yg isOkTo... dan isVisible kynya mending dipisah ke privacy attribute, yg dipake juga buat kontrol info apa aja yg boleh dimunculin gt. Nanti kita buat privacy control page jg... ky Facebook. Bisa belakangan sih jd ada defaultnya dulu.

Buat reputation aku cenderung jangan di cash-in. Kalo udh ada exchange rate ke uang itu org jadi cenderung pelit, motivasinya jg udh beda... Lebih baik buat reward gitu ky yg kamu bilang sih.

Lagi kepikir nantinya buat forum ky quora, terus kalau murid mau nanya sesuatu yg susah, bisa pake own points buat "offer". Nanti yg nanya harus accept jawaban ky di SO, atau kalau ga milih, jawaban yg paling banyak dilike yg menang. Nanti org yg jawab dapet poinnya. Memang paling akhirnya dipake buat nanya PR hahaha...

Nah kalo bonus point yg bisa dibuat take lessons, mungkin itu mendingan dipisah dari reputation. Soalnya konsepnya agak aneh ya kalau to join a seminar, one has to sacrifice some reputation. Mungkin lebih cocok pake dari bonus payment/frequent learner points :p buat bayar lessons/seminars gt.

*Just remembered that this will be read by other developers...*

Reputation points need to have both a grand total and break down per subject. Some points may be generic - cannot be associated with a particular subject. E.g. points coming from endorsements from social network. The per subject break-down is because e.g. someone with lots of reputation points from teaching math may not actually be good in teaching piano. But the fact that he has taught math well indicates that as a teacher, he is good & trustworthy.

Items that tend to grow over time and are not used in search queries are better off being separated into other documents. E.g. reputation.history and payment.credits. This is so that the user document won't grow significantly over time.

system.preferredLanguage is the same with system.locale... and the purpose is as you wrote :)


Does it actually work?


fix formatting issues with spacing -> should be like
for (var device in devices.data) {


I think an helper would be better, I'm not sure which problem you're trying to solve here.


fix formatting issues with spacing -> should be like
function getDeviceData(deviceType, deviceId) {


ok


:))
First I wanted to name it `loadReader` then decided to emphasize that it acts like the `read` functions (Glossary.read, plugin.read)


Tested with mine, and i will test it using a second computer.


이것이 메모리 부족익셉션인가보군


I think this import is not really being used?


This seems to throw an uncaught exception if `output + "/nix-support"` doesn't exist.


fix formatting issues with spacing -> should be like
if (!device) {


`pr_debug("- dev->parent=%p\n", dev->parent);` instead of removing the line?


Gnagstagangsta


Yeah


Changes ok


I understand what you're saying, but then we'd lose the rule stopping developers from adding *new* calls to `eval` which I think I'd prefer to keep.

I'm not sure exactly how `govuk-lint-ruby --diff` works, but perhaps we could achieve a similar effect by generating a `.rubocop_todo.yml` file and inheriting from it in `.rubocop.yml` as described [in the documentation][1].

If we did that instead of running `govuk-lint-ruby --diff`, then this change wouldn't have caused a build failure, but any new call to `eval` would.

In any case I think either of these approaches is probably out of scope of this PR. I've added a [Trello card][2] to consider these suggestions.

[1]: https://github.com/bbatsov/rubocop#automatically-generated-configuration
[2]: https://trello.com/c/k4VNXtA2


This is one of the AlarmManager's methods so you can just use the member variable directly using _first_alarm_raised.


ok, looks good.


fix formatting issues with spacing -> should be like
if (stats['cpuTemperatureData'] == null) {


hi how looks like the import array ?


@bmorrise check style was not ran on these code changes. Sonar is reporting unused imports.
Please fix


This `metadataPath.replace("/maven-metadata.xml", "")` does work, however, wouldn't it be easier (to do, read and understand) to simply have `metadataPath.substring(0, metadataPath.lastIndexOf("/"))` ...? (You are doing this in a few places).


I'm trying to solve the problem of complex static inits so we no longer need $this-closures in JS or the awkward return value blocks in C++. We have all the tools to transform the expressions but no place to put it.

Essentially this is the static equivalent of moving non-static variable initializations to the constructor.


뒤에 공백이 하나씩 붙어서 그런가 ?


need a space after `//`
```
// symmetry
```


better using "if (!stats['cpuTemperatureData']) {" rather than "if (stats['cpuTemperatureData'] == null) {"


need a space after `//`
```
// if
```


you can move that into if condition:

if (auto web3direct = ... )


forgot to update the "PLATFORM != PLATFORM_WINDOWS" define


+Makefile


i am lost here, pls clarify once more. can i use entware-ng for wl500gpV2 and if which repository? thanks


Could you perhaps add a small test method in the `strongbox-web-core`'s `ArtifactRestletTest` that uses the `ArtifactDeployer` to deploy against the actual application? I think that should be quite straight-forward now? You can deploy a few versions of an artifact and then run some checks to be sure.

What do you think?


WARN is still too much?


fisierul asta nu trebuie commis. Trebuie ignorat in git ignore file


lgtm


Nice spot!


idem


Clasa asta acum nu isi mai are rost :P


TeamCity Selenium POM :: CI [Build 61](https://teamcity.sponte.uk/viewLog.html?buildId=1073&buildTypeId=SeleniumPom_Ci) is now running


and here


myMessages.size() - (myMessages.size()) nu este egal cu 0?


here too


TeamCity Selenium POM :: CI [Build 61](https://teamcity.sponte.uk/viewLog.html?buildId=1073&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 41 Build time: 00:00:59


```go
	// Parse required affinity scheduling requirements
	// and check if the current node match the inter-pod affinity scheduling rules.
```


Sterge sysout-ul de aici. De obicei in proiect se pune cu logger. Aici putem incurca sout-ul din clasa cu cel din teste.


Repository is set automatically by your router.


I think IllegalStateException is better. Is there a real case when it's null?


Now there is different `ipkg.conf` for different router.
On wl500gv2 you may use Entware only.


@bgashler1  I think it makes sense that you can subscribe everywhere. You are subscribing to anything we will send you. Was the thought that users would be confused and think they were subscribing to the docs / updates? I like the consistent experience if its the same everywhere.


Metoda asta nu mai are rost


Updated


-Currently AudioFilters fail silently if "Process" returns 'false' (e.g. when you use Reclock on an incompatible renderer). That should probably be fixed.

-Maybe the "copysamples" option of MediaSample should be removed.


why not an enum?


La fel si asta, nu vrei sa ii dai access cuiva la toate mesajele (momentan). Doar la ultimul ne primit


duplicated spaces
```
// if err or  podAntiAffinityTerm
```


Good to get into the habit of using the Functions.unpartitioned() utility method, encourages others to use that rather than a new method.


@gregvanl Does this work? I don't think page is available to the swig compiler.


aici trebuie sa faci asa: pricate SMSService smsService = new SMSServiceImpl(); si stergi linia de mai jos.


unnecessary white line


looks good


This has, in itself, nothing to do with this commit. It's just a regression that was introduced on master with https://github.com/mono/mono/commit/d17b89609524441faf6f437eb04526f1e8af4a47


same set of comments apply here as well.


This commits seems to have broken the type system for the `Platform` it looks like there is some condition missing in the check:

![screen shot 2016-03-02 at 14 26 16](https://cloud.githubusercontent.com/assets/407216/13461603/d0569198-e082-11e5-8f19-0c72dcdf7100.png)


lista trebuie sa fie privata (encapsulation)


I am no longer having issues with this.


Will these "waitForCell..." methods scroll the item into view? If so, it may be worth of mention in comment.


aici, momentan ai nevoie doar de junit version, restul poti sa le scoti


What about your set_x methods? Don't these need to update the flag too?

It's usually not a good idea to change member variables on other objects like this directly, as it means that changing the implementation of the other class might break this code. I'd suggest adding a method to the AlarmManager which triggers it to start re-syncing alarms. It's fine if it just changes this flag under the covers. You can then make the flag private.


Why perform this check why not always use jqEl[0]?


Think to remove the CPU Weight field in the VM creation if it's created from a resource set.


I think it looks good, although I would find it nicer if we had compile time declaration of these, because we don't need to change them later (after installation) anyway.

Like:
#define [Something]

public static string IsSomethingEnabled
       {
          get
          {
#if ( [Something] )
                return true;
#endif
                return false;
            }
       }


Yea - this is one of the routes I was proposing.  I think it will be fine this way.  Gives someone more flexibility I think.  If they didn't  want a footer at all they can disable the action and nothing would be output.  Thanks!


You could use the initializer list here.


Merging anyway


Added to change log


Why did you chose to use a literal version here? The download URL isn't versioned and always points to the latest version, which breaks the formula everytime Airmail Beta is updated (sha mismatch).


better to use simply "if (temperatureData) {" as this checks for all possibilities like null, undefined and ""


See https://github.com/Arduboy/Arduboy/issues/118#issuecomment-191237734


For updates - @chrisdias and I talked about the possible confusion with updates. We will send a blog on each update so in a sense people are subscribing to updates.

For docs - I don't think people will get confused by thinking they're subscribing to docs. Open to arguments saying people would.

We could do something like "Subscribe to feed", which would clarify that we are subscribing to our rss feed.


better to use simply "if (lightData) {" as this checks for all possibilities like null, undefined and ""


better to use simply "if (motionData) {" as this checks for all possibilities like null, undefined and ""


Mike,

Thanks for the comments, I'll create different patch series from scratch.

Tomaz

On Wed, Mar 2, 2016 at 6:00 AM, Mike Gelfand <notifications@github.com>
wrote:

>
>    1. The guideline here is "include what you use", not "include bare
>    minimum so that it compiles";
>    2. The <libtransmission/transmission.h> include should always precede
>    other libtransmission includes;
>    3. This commit has nothing to do with Qt 5 or C++11 (for the most
>    part). As I mentioned earlier, it's better to separate unrelated changes,
>    and there're more of such changes in further commits.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tcanabrava/transmission/commit/9d99452cd1cebc79e4c4279789cda2a57dc4e8e1#commitcomment-16439526>
> .
>


这里的display:flex可以去掉吧？


better to use simply "if (fanData) {" as this checks for all possibilities like null, undefined and ""


VS 2010 Express doesn't with this changes.


better to use simply "if (bulbData) {" as this checks for all possibilities like null, undefined and ""


@aszasz, if you're wondering, this is the only meaningful change in this commit.

I was in a hurry and committed a bunch of minor/stylistic changes not really necessary (such as using the new location for spod definitions – `sapo.spod.[...]` – and uniform indentation).


Hi, this is a backward incompatible change, will next release follow semver and be 4.x?


better to use simply "if (cpuData) {" as this checks for all possibilities like null, undefined and ""


better to use simply "if (ramData) {" as this checks for all possibilities like null, undefined and ""


Se http://expressjs.com/en/guide/migrating-5.html


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18009](https://teamcity.mesosphere.io/viewLog.html?buildId=151305&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0, ignored: 246 Build time: 00:06:23
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


looks good


better to use simply "if (cpuTemperatureData) {" as this checks for all possibilities like null, undefined and ""


**FAILURE** - TeamCity HotRod C# Client :: Pull requests monitor - WIN_S2012 [Build 90](http://ci.infinispan.org/viewLog.html?buildId=36905&buildTypeId=HotRodCSharp_PullRequestsMonitorWinS2012&guest=1) for 9ddcf6b389ecdc8144348182d4faf966b2c9cee1
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:11:58

Process exited with code 1


Added to change log


Is this a change in behaviour?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18010](https://teamcity.mesosphere.io/viewLog.html?buildId=151306&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 244 Build time: 00:04:07


enum property is not constexpr so it cannot be used in few context we want it to be used. Also there is no trend to parse string to enum when reading config so I didn't wanted to mess to much with the code.
But yes, it probably can be further improved by switching to enum.


Thanks!

It is the only dependency for whole npcap?


dijkstra 算法计算最短路径


Ok! Fair enough :)


Har sett på GsonFactory().setExclusionStrategies, men ExclusionStrategy sin shouldSkipField-metode ser ikke ut til å kjøre når det er et Map som sendes inn. Gi en lyd om dere vet en metode for å gjøre fjerningen enklere / mer elegant.


I saw that you converted lots of strings like this into the following style:

```
   ('lalala'
    'lalala')
```

Shouldn't this also match it? And be squashed into 4515166d3417d462a571ed47172ed368911e79a3 ?


merge sort


With the docs - we could send an update through the rss feed for docs. People could get an update when we release a new doc page.

My point is that people should start subscribing ... then we choose what we'll send through the feed when it makes sense.

Keeping the same connect widget on every page gives the user a consistent experience.


<iframe src="" id="index_frame" frameborder="0" class="iframe" name="index_frame" scrolling="no" marginheight="0" marginwidth="0" onload="this.height=100" height="860"></iframe>


OK.


OK!


Yes it probably should. How does that affect the go package?

Can you weigh in on https://github.com/cucumber/gherkin/issues/59 please?


Shouldn't this be TEST_ASSERT_EQUAL ?


Nice!


@LuxoftAKutsan , @AByzhynar , see 5aaa49e


@alexisjanvier Feel free to open an issue or a PR for this point.


@LuxoftAKutsan , see 5aaa49e


@AByzhynar , see 5aaa49e


Good!


@AByzhynar  see 5aaa49e


TeamCity Selenium POM :: CI [Build 62](https://teamcity.sponte.uk/viewLog.html?buildId=1076&buildTypeId=SeleniumPom_Ci) is now running


@AByzhynar see 5aaa49e


{{ cookiecutter.repo_url }} and {{ cookiecutter.library_name }} should've been substituted to the corresponding values passed on cookiecutter generation.


TeamCity Selenium POM :: CI [Build 63](https://teamcity.sponte.uk/viewLog.html?buildId=1077&buildTypeId=SeleniumPom_Ci) is now running


Looks like lots of the file changes are from tabs and spaces, nothing else. Please do this commit on top of the `develop` branch https://github.com/Health-Care/BloodDonation/commits/develop and install the http://editorconfig.org/ for you editor, I also added a conf file for it to work properly https://github.com/Health-Care/BloodDonation/blob/develop/.editorconfig and please let's work only on the develop branch not the master. And please take some time to clearly describe what have been done in the commit message, the `wanted apies
` message is not clear. Thanks


;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
begin:  mov ax,3                ;main window
    int 16

    lea dx,[fil1]               ;load level
    call fopen
    lea dx,[lvl]
    mov cx,mx*my/256+12+33
    call fread
    call fclose

    mov ah,2
    mov bh,0
    mov dx,25*256
    int 16
    mov ax,0B800h
    mov es,ax
    lea si,[msg]
    mov di,2*(31+08*80)
    call print
    mov di,2*(31+10*80)
    call print
    mov di,2*(31+12*80)
    call print
    mov di,2*(31+14*80)
    call print
    mov di,2*(15+1*80)
    call print
    mov di,2*(24+2*80)
    call print
    mov di,2*(8+19*80)
    call print
    lea si,[plk1]
    mov cx,3
beginl1:push cx
    add di,4
    mov ax,[ds:si]
    call keys
    mov al,[key+2]
    mov [es:di],al
    inc si
    inc si
    add di,8
    mov ax,[ds:si]
    call keys
    mov al,[key+2]
    mov [es:di],al
    inc si
    inc si
    sub di,4+320
    mov ax,[ds:si]
    call keys
    mov al,[key+2]
    mov [es:di],al
    inc si
    inc si
    add di,640
    mov ax,[ds:si]
    call keys
    mov al,[key+2]
    mov [es:di],al
    inc si
    inc si
    sub di,320
    mov ax,[ds:si]
    call keys
    mov al,[key+2]
    mov [es:di],al
    inc si
    inc si
    add di,20
    inc si
    pop cx
    loop beginl1
beginl0:mov ax,[word ptr key]
    cmp ax,1
    jz ende
    call keys
    mov al,[key+2]
    cmp al,'0'
    jz game
    cmp al,'1'
    jz info
    cmp al,'2'
    jz redef
    cmp al,'3'
    jz ende
    jmp beginl0
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
redef:  call txtcls         ;Redefine window
    mov di,2*(0+01*80)
    lea si,[msg2a]
    call print
    push si
    mov cx,3
    lea bx,[plk1]
    mov di,2*(4+04*80)
redefl1:lea si,[msg2]
    push cx
    push di
    call print
    mov al,'4'
    sub al,cl
    mov [es:di],al
    inc di
    inc di
    mov al,':'
    mov [es:di],al
    add di,4
    mov cx,5
redefl0:push di
    call print
    call ikey
    mov [ds:bx],ax
    call keys
    mov al,[key+2]
    mov [es:di],al
    inc bx
    inc bx
    pop di
    add di,160
    loop redefl0
    pop di
    add di,44
    inc bx
    pop cx
    loop redefl1
    pop si
    mov di,2*(25+16*80)
    call print
    call ikey
redefr0:mov ax,[word ptr key]
    or ax,ax
    jnz redefr0
    cli
    sub al,al           ;delete directions
    mov [cs:plk1+10],al
    mov [cs:plk1+21],al
    mov [cs:plk1+32],al
    sti
    lea dx,[fil1]           ;save redef
    call fopen
    lea dx,[lvl]
    mov cx,mx*my/256+12+33
    call fwrite
    call fclose
    jmp begin
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
info:   call txtcls         ;info window
    mov di,2*(0+01*80)
    lea si,[msg1+1]
    mov cl,[msg1]
    sub ch,ch
infol0: push cx
    call print
    pop cx
    loop infol0
    lea si,[msg2b]
    mov di,2*(25+24*80)
    call print
    call ikey
infor0: mov ax,[word ptr key]
    or ax,ax
    jnz infor0
    jmp begin

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;; Main window: ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
mapi:   pusha
    push es
    mov es,[maps]
    sub di,di
    lea bx,[lvl]
    lea si,[gfx]
    sub al,al
    mov cx,my/16
mapl3:  push cx
    mov cx,mx/16
mapl2:  push cx
    push si
    mov ah,[ds:bx]
    add si,ax
    mov cx,16
mapl1:  push cx
    mov cx,4
    rep movsd
    add di,mx-16
    pop cx
    loop mapl1
    pop si
    sub di,16*mx-16
    inc bx
    pop cx
    loop mapl2
    add di,15*mx
    pop cx
    loop mapl3
    pop es
    popa
    ret
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
car:    pusha                   ;ax=direction es:di=map posiotion ch=car
    push es
    lea si,[gfx+7168]
    add si,ax
    lea bx,[car1-256]
    sub cl,cl
    add bx,cx
    mov cx,16
    mov dl,15
carl1:  push cx
    mov cx,16
carl0:  mov al,[ds:si]
    mov ah,[es:di]
    mov [cs:bx],ah
    cmp al,dl
    jz carx0
    mov [es:di],al
carx0:  inc bx
    inc si
    inc di
    loop carl0
    add di,mx-16
    pop cx
    loop carl1
    pop es
    popa
    ret
cart:   db 255,0,4,255,2,1,3,255,6,7,5,255,255,255,255,255
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
carz:   pusha                   ;es:di=map position ch=car
    push es
    lea si,[car1-256]
    sub cl,cl
    add si,cx
    mov cx,16
carzl1: push cx
    mov cx,16
carzl0: mov al,[cs:si]
    mov [es:di],al
    inc si
    inc di
    loop carzl0
    add di,mx-16
    pop cx
    loop carzl1
    pop es
    popa
    ret
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
carn1:  pusha           ;bx = [plk1 +...] cx =[cary] dh=pl
    push es
    push ds
    push di
    mov al,[cs:bx]
    and al,15
    lea bx,[cart]
    xlatb
    xchg al,ah
    sub al,al
    mov bx,cx
    cmp ah,255
    jz carn1e
    mov di,[cs:bx]
    mov es,[maps]
    mov ch,dh
    call carz
    sub bx,6
    mov di,[cs:bx]      ;player

xxx:    pusha
    mov ah,1
    mov ch,16
crnl1:  mov cl,16
crnl0:  mov al,[es:di]
    or al,al
    jnz crnrx
    sub ah,ah
crnrx:  inc di
    dec cl
    jnz crnl0
    add di,256-16
    dec ch
    jnz crnl1
    or ah,ah
    jnz crnry
    mov ax,[cs:bx+6]
    mov [cs:bx],ax
crnry:  popa
    mov di,[cs:bx]

    call car
    mov ax,[cs:bx]
    add bx,6
    mov [cs:bx],ax
    sub bx,6

carn1e: mov ds,[maps]
    mov ax,[cs:bx]
    sub al,44
    jnc carn1a
    sub al,al
carn1a: cmp al,152
    jc carn1c
    mov al,152
carn1c: sub ah,44
    jnc carn1b
    sub ah,ah
carn1b: cmp ah,152
    jc carn1d
    mov ah,152
carn1d: mov si,ax
    pop di
    call obr
    pop ds
    pop es
    popa
    ret
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
obr:    push ds             ;0A000h:di,ds:si
    push es
    mov ax,0A000h
    mov es,ax
    mov cx,oy
obrl1:  push cx
    mov cx,ox/4
    rep movsd
    pop cx
    add di,320-ox
    add si,mx-ox
    loop obrl1
    pop es
    pop ds
    ret
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
ctrl:   pusha               ;controls al,keyresult di=[carx]
    lea bx,[cart]
    push ax
    xlat
    pop bx
    xchg ax,bx
    cmp bl,255
    mov bx,[cs:di]
    jz c13
    mov ah,2        ;step
    test al,1
    jz c10
    sub bl,ah
    jnc c10
    add bl,ah
c10:    test al,2
    jz c11
    add bl,ah
    cmp bl,240
    jc c11
    sub bl,ah
c11:    test al,4
    jz c12
    sub bh,ah
    jnc c12
    add bh,ah
c12:    test al,8
    jz c13
    add bh,ah
    cmp bh,240
    jc c13
    sub bh,ah
c13:    mov [cs:di],bx
    popa
    ret
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

game:   mov ax,19       ;game
    int 16

    lea bx,[pal]
    mov dx,3C8h     ;set palete
    mov cl,0
pall0:  mov al,cl
    out dx,al
    inc dx
    mov al,[cs:bx]
    inc bx
    out dx,al
    mov al,[cs:bx]
    inc bx
    out dx,al
    mov al,[cs:bx]
    inc bx
    out dx,al
    dec dx
    inc cl
    jnz pall0

getm:   mov ah,48h
    mov bx,12288
    int 21h
    mov [maps],ax
    jc gerr
    call mapi
    mov es,[maps]
    mov di,[cary]
    mov ax,2*256
    mov ch,1        ;player
    call car
    mov di,[cary+2]
    mov ch,2        ;player
    call car
    mov di,[cary+4]
    mov ch,3        ;player
    call car

gl0:    lea bx,[plk1+10]
    lea cx,[cary]
    mov di,0
    mov dh,1
    call carn1
    lea bx,[plk1+21]
    lea cx,[cary+2]
    mov di,ox+4
    mov dh,2
    call carn1
    lea bx,[plk1+32]
    lea cx,[cary+4]
    mov di,ox+ox+8
    mov dh,3
    call carn1

    mov al,[plk1+10]
    lea di,[carx]
    call ctrl
    mov al,[plk1+21]
    lea di,[carx+2]
    call ctrl
    mov al,[plk1+32]
    lea di,[carx+4]
    call ctrl

    mov ax,[word ptr key]
    cmp ax,1
    jnz gl0

freem:  mov ah,49h
    mov es,[maps]
    int 21h
gamee0: mov al,[key]
    or al,al
    jnz gamee0
    jmp begin

gerrm   db 'Memory alocation error.',0
gerr:   mov ax,3
    int 16
    sub di,di
    lea si,[gerrm]
    mov ax,0B800h
    mov es,ax
    call print
    jmp gamee0

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
ende:   push ds         ;uninstall keyboard int
    mov dx,[oint09]
    mov ax,[oint09+2]
    mov ds,ax
    mov al,9h
    mov ah,25h
    int 21h
    pop ds
    mov ax,3
    int 16

    EXITCODE


ok


On Wed, Mar 2, 2016 at 1:28 AM, Barak Korren <notifications@github.com>
wrote:

> Consider installing the Jenkins slave agent on the libvirt host instead of
> doing everything over SSH, there are a few benefits to it:
>
>    - It would at least make logging easier
>
> Can you expand on this?

>
>    - It will give you the kind of isolation that Jenkins workspaces can
>
>
>    - It will let you track changes in Git repos used in the process with
>    Jenkins
>
> Can you expand on this?  Mostly asking cause my Jenkins-foo is not food
enough to see the answer myself.

>
>    - It will allow you to scale by simply adding slaves Also this will
>    crash and burn if the 'sat-deploy' directory is not there, maybe add some
>    command to create it?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ehelms/robottelo-ci/commit/4ab35ae7b642f04a6e6e40871096f1cf1804e601#commitcomment-16437579>
> .
>

--
Eric D. Helms
Red Hat Engineering
Ph.D. Student - North Carolina State University


LGTM


Why have we removed the _stream.open() ?


It's necessary to ensure that all downstream projects, such as -examples, build with the changes.

If there's a way to make it work with releases we're open to suggestions


@AByzhynar , @LuxoftAKutsan , see 5aaa49e


You may try below:
Switch back to old HAL
And sync this up: https://github.com/neobuddy89/yu_msm8916/commits/lollipop/include/media/msm_camsensor_sdk.h

The last commit which exposes uint32_t module_id should fix opposite cam preview.


TeamCity Selenium POM :: CI [Build 62](https://teamcity.sponte.uk/viewLog.html?buildId=1076&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 41 Build time: 00:01:06


@AByzhynar . see 5aaa49e


who knows, maybe someday im gonna writeToReader 😁


TeamCity Selenium POM :: CI [Build 63](https://teamcity.sponte.uk/viewLog.html?buildId=1077&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 41 Build time: 00:01:06


Who is demarlik01?? @incleaf


@purbon I believe the ../lib/basic.rb is a more efficient way to load a jruby extension., than your original that I have moved to test (to be re-purposed as a minitest test)


@AMikhniev see 5aaa49e


I just have realised that i have commited in the main repository It was by mistake, please forgive me.


@AByzhynar , see 5aaa49e


@LuxoftAKutsan see 5aaa49e


;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;;   File library:   ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
hand    dw 0        ;###    handler...
ferr    db 0        ;###    DOS error code
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
fopen:  pusha       ;DS:DX = file name, [hand] <= file handle
    mov ax,3D02h
    int 21h
    mov bl,0
    jnc fopen0
    mov bl,al
    sub ax,ax
fopen0: mov [cs:hand],ax
    mov [cs:ferr],bl
    popa
    ret
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
fnew:   pusha       ;DS:DX = file name, [hand] <= file handle
    mov ah,3ch
    mov cx,0    ;attr
    int 21h
    mov bl,0
    jnc fnew0
    mov bl,al
    sub ax,ax
fnew0:  mov [cs:hand],ax
    mov [cs:ferr],bl
    popa
    ret
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
fclose: pusha       ;[hand] = file handle
    mov bx,[cs:hand]
    mov ah,3eh
    int 21h
    mov bl,0
    jnc fclose0
    mov bl,al
    sub ax,ax
fclose0:mov [cs:ferr],bl
    mov [cs:hand],ax
    popa
    ret
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
fread:  pusha       ;DS:DX = adr, CX = lenght, [hand] = hand, CX => read
    mov bx,[cs:hand]
    mov ah,3Fh
    int 21h
    mov bl,0
    jnc fread0
    mov bl,al
    sub ax,ax
fread0: mov [cs:ferr],bl
    mov cx,ax
    popa
    ret
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
fwrite: pusha       ;DS:DX = adr, CX = lenght, [hand] = hand, CX => write
    mov bx,[cs:hand]
    mov ah,40h
    int 21h
    mov bl,0
    jnc fwrite0
    mov bl,al
    sub ax,ax
fwrite0:mov [cs:ferr],bl
    mov cx,ax
    popa
    ret
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
fdel:   pusha       ;DS:DX = file name
    mov ah,41h
    int 21h
    mov bl,0
    jnc fdel0
    mov bl,al
fdel0:  mov [cs:ferr],bl
    popa
    ret
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
fattr:  pusha       ;DS:DX = file name, CX = attr
    mov ax,4301h    ;4300 for attr read => cx ... change push/pop
    int 21h     ;       7 6 5 4 3 2 1 0
    mov bl,0    ;cx = attr:     0 0 A 0 0 S H R
    jnc fattr0
    mov bl,al
fattr0: mov [cs:ferr],bl
    popa
    ret


If usingTrackBy, equality should be done using it, not full object equality. This implementation brings back the Angular circular reference problem that TrackBy fixes: https://github.com/angular/angular.js/pull/7839


Er det ikke kun status-parameteren, der droppes, ie. `res.json(obj, status)` forsvinder, hvorimod `res.json(obj)` stadigt findes?


I'm open to revisiting, provided it isn't a ton of code. From what I remember on that discussion jQuery's event model is pretty far from the way we do things now in vanilla JS (you mentioned expando) so the simplest solution may be just to keep the `Backbone.$` checks. Do you still agree?


This is a change in behaviour. Is this correct?


@Flamekiller96 I didn't, I was banned and the post was removed. Though I've been great, just a little worn from overworking myself.


Nitpick: what about `metavar="STREAM[:LEVEL]"`, it's only +2 chars, and it makes it clearer and matches the text on the help message.


Det er meget muligt, jeg har ikke nærlæst, tænkte lige det var relevant :)


And while at it: "STREAMs, optionally followed..."


LGTM


I mean, the idea is to help the user's brain to match the syntax with the help message... not sure if it's that much of a big deal, just a nitpick/small suggestion.


consider use LocalDate instead of Date.
Java introduced LocalDate and LocalDateTime if you need time.


这些运行结果不必保存到 github 上。


LGTY


OK!


Ah, right. So while Dan may have experimented with building (maybe why tasks.json even exists), this extension is currently only about language support (syntax highlighting, code completion, etc) and not (yet) for building.


@yangroro 김효석


Yes. At least that's the intention. I've never dug deep into these things.


print??


if file_type != '.py':
    continue

这样写可以使下面的代码少些缩进。


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1352.80681bbcfbacefc4992cbfa79043091828ff8ba5](http://build.palaso.org/viewLog.html?buildId=69805&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 1022, ignored: 12 Build time: 00:07:51


I wonder `sick_start_date` could be improved as well, changing 'sick' to 'sickness' and either adding current or previous to disambiguate which date it refers to, if not in this ticket, maybe in #2280


Oh, this matches the `metavar` suggestion I gave on the previous commit.


ack


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18012](https://teamcity.mesosphere.io/viewLog.html?buildId=151311&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 245 Build time: 00:03:40


yes, I believe you are right.  Thanks!


Alternatively could be `rex::rex(or("#", "//", "!"), any_spaces, "nocov")` to handle C/C++ and fortran comments.

You could probably still construct valid R expressions that would be inadvertently filtered by the above, but there is less chance than simply `nocov$`.


不单止要统计成功和失败的数目，还要记录一下，哪文件成功了，哪些文件失败了。


$(document).ready(function() {

	/* -----侧边栏点击动画效果-----*/
     $(".item").click(function(){
     	$(".item").removeClass("item0");
     	$(this).addClass("item0");
     	$(this).next("ul").toggle().siblings("ul").slideUp();
     	/* 当前元素的下一个ul做显示隐藏效果，同时它的兄弟ul隐藏*/
     });

     /*-------退出登录显示隐藏------*/
     $("#quit").click(function(){
  		$(".quit_content").toggle();
  		})
     $(".btn1").click(function(){
     	$(".quit_content").hide();
     })

});


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18011](https://teamcity.mesosphere.io/viewLog.html?buildId=151310&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 245 Build time: 00:04:35


Again, a nitpick: the metavar mentions `STREAM`, so I'd suggest using `logging streams in $JOB_RESULTS_DIR/$STREAM.$LEVEL`


Hi @alsamhou, please install only the "development" version of the _activityinfo_ package, otherwise you cannot be sure which version will be loaded by R.


This is a possible portability fix we'll have to deal if we aim at Windows compatibility later... but it's fair enough at this point.


Perfect code :+1: I like how you write static.


shouldnt this be compiler != compiler_microsoft in case someone is crazy enough to try non-msvc builds? (not that we support them really but the point is about the pragma syntax being msvc-specific)


Het is nu toch gelukt


Btw, new commits should be reflected in JIRA as well. New commits = new review.


Nice.


lol .. :D
it works properly ... 0x00 = +10dB (digital gain for headphones)
and eardiggain_v = 0x10 = +0dB ... tested and works :-)

btw: anyway it's probably just too much ! xD @ full volume i've now distortions like hell ... it's extremely loud .. even more loud than my real DJ mixer :D
I'll it adapt later .. it sucks a bit :-) - Also it can even damage the headphone ...

btw2: do u use Bass boost on DSP app ??
I've tried it .. and it's just amazing ... sounds like an subwoofer ^^ But my headphone only can handle "clean" with "low" ... which is already good ... but @ "extreme" it's really amazing.. but it can't handle .. maybe i'll buy better an Panasonic headphone .. that sennheiser HD215 sucks :-)


after larning new things in jquery i am making changes to the existing master copy


onChange 也传给 span 了

ie 10/11 下 bug: input onchange react 0.14.x 冒泡：  https://github.com/facebook/react/pull/5004


Good!


run coala over your code please


67980ed

Anyone can install this hook on their local system. Installation is listed within the source file itself.

This hook 'is' versioned, and we can easily add other tests which would reject prior to the commit.


Hastable with no collision detection/handling. Should be fine for now.


do we need require false ? This is currently used for circleci and travis, I dont think it should be there


whats the require for?


making it optional? I'd leave it...


Looks like the packages below are no longer loaded into the R session. This will most likely result in an error if these packages don't happen to be pre-loaded in the session.


This can be made into a class variable i.e. put it outside `run()`


Sorry for the direct commit without branching it :(


Because it has an `appcast`, and we have scripts to check and correct those, now, which means it’s updated more readily. Have a `sha256` is better.


Newline needed or some spacing issue. Run coala on it


You have field date, so you should compare dates , not trying to format the into String
and then compare.
transaction.getDate is equal to actualTransaction.getDate


@jf, choose one: (1) picking a two-letter name in a global name space, or (2) avoiding accidental name clashes/capture. :)


is this newline needed ? If not, remove it please


I just think the naming versus what's happening is a bit strange, when reading `check_phys_to_virt` I'd expect to see the opposite happening in the code, i.e, `phys_to_virt(pa) == va`.


is this newline needed ? If not, remove it please
 Add a line note


No, this is mandatory according to [this](https://github.com/brigade/scss-lint#installation)

> The require: false is necessary because scss-lint monkey patches Sass in order to properly traverse the parse tree created by the Sass parser. This can interfere with other applications that invoke the Sass parser after scss-lint libraries have been loaded at runtime, so you should only require it in the context in which you are linting, nowhere else.


watching


What do you mean by that?
Note that I've tested the hash function and it's 100% bijective. Trust me.


What happens if the whole hash is full? Is this an infinite loop?


Yeah. Definitely #2280 territory. Thanks for the feedback!


@neobuddy89 you talking about this one?
https://github.com/TheStrix/caf_msm8916/commit/333e1d727e5f75400211d4b480e0275fe466cdbd


See you've made a change to accommodate Pi3. How does it perform? Mine's dispatched in the post. Hopefully arrive tomorrow!


Please comment the code.


What is the purpose of this second while loop and the if condition above?


Yes.

All other projects can be built in an independent way.


No. Because the fist element (escp_indexTable[0]) is always 0. ID = 0 is invalid


а если его переопределят в юзер-конфиге?


Thanx for the comments Vincent.  I was not sure booleans didn't get turned into strings anyways.  I think I did tests from the QGIS Python console setting the value to True (boolean) and I'm not sure getting the value back returned a bool.  Will check because strings are definitely a pain.


switched [godog](https://github.com/DATA-DOG/godog) to use gherkin-go from gopkg.in. Not sure whether this service is reliable though. anyway, I do not want to introduce a dependency management tool into the build chain. a simple `go get` currently complies with go standard way, as we do not have a commonly used package manager in go yet.


Salam.
En voila un lien http://www.androidhive.info/2014/01/how-to-create-rest-api-for-android-app-using-php-slim-and-mysql-day-23/ mais je pense que vous pouvez trouver plusieurs tutoriels pour utiliser slim. J'ai pas pu faire la mise en place.


ok,我这边改过来


Why has the named parameter 'client' been removed?


No, it's because my inspect complains about this, so it has to be the first commit, otherwise I incremental selfcheck fails...


curious what kind of problems this causes in the Ruby implementation. Is it the runtime or the module tool that causes problems?


@TimKeighley I corrected.  I remembered I only expected one axis, so that is probably why the bug never bit me.  If you have a use case for multiple axes, I'd like to hear about it.


Может, поправить тогда?)


I will. I did not have time.
The hashing algorithm is a bit difficult to understand but it surely works.

Nexus Razvan

On 03/02/2016 03:52 PM, Alexandru Onea wrote:
>
> Please comment the code.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/thetopor/helix-drone/commit/5796bd4740b249dff0d2b6294454f08f83a4cf58#commitcomment-16445773>.
>

This message contains confidential information and is intended only for the individual named. If you are not the name addressee you should not disseminate, distribute or copy this e-mail. You cannot use or forward any attachments in theemail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. Topor 2016. www.topor.io


Try it :wink:

<spoiler> it raises exception... </spoiler>


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


No noticeable difference with a very simple play. I'll have more to report after I've spent a few hours jamming with it...


Why the linebreaks?


This commit.
https://github.com/neobuddy89/yu_msm8916/commit/a099cf9378c0685a4b879cbbdf51841d755cda6d


Does this work, I thought the code would fail if you did not add a filter?


I see ... can you add a comment so that others don't remove it by mistake ?


The disclaimer appeared here too. Please take actions.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18014](https://teamcity.mesosphere.io/viewLog.html?buildId=151317&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 243 Build time: 00:04:03


Well to be precise I'd have to use `metavar=BUILTIN|STREAM[:LEVEL]` but that won't fit in. As I generalized the STREAM into builtin/streams I left this lowercase. But I'm open to suggestions...


Ну по правильному лучше конечно добавить свой конфиг для bsl.


Unfortunately, it's not. This NMS code was kind of a guess. I created it right after the release of the first Bukkit API 1.9pre1code by md_5 when I didn't even have any CB code to compile against. Don't worry, though, filoghost is currently working on an update himself and said there are just a few bugs left to be fixed.


Do not use `@api.one`; Use `@api.multi` together with `self.ensure_one()` as first file


Why did we even originally require the user? Is `ObsPy client` not a good user name?


Actions are about to be taken. Actions include:

- Defining unit tests for the esc module (I will do this myself later today)
- Doubling the disclaimer size and maybe using some random uppercase characters as well to increase readability


Yep, it was possible here so I used it...


OK, will be in v12


Looks good


because we were asked by GFZ to change that


i have been using this on wl500gpv2
vi /opt/etc/opkg.conf
src/gz openwrt http://entware.wl500g.info/binaries/mipselsf

should i change this then?


@saurabhiiit can you modify the commit message to be a bit better ?

`Change pip -> pip3` is more descriptive than "minor changes".


I just come here to try


fixed. Thx


Set empty string between methods. It's just for code style


didn't see the change


It stands to reason that a terminate call issued by the `onError` mechanism is probably an error. The use of `false` should not qualify as a change in behaviour.


We'll talk about this on Saturday :)


This line is the core of this change.


Could we do something like the following to use your filter to grab stdout and stderr

http://stackoverflow.com/questions/692000/how-do-i-write-stderr-to-a-file-while-using-tee-with-a-pipe

```
ExecStart=/bin/sh -c '/usr/bin/docker daemon \\
         $OPTIONS \\
          $DOCKER_STORAGE_OPTIONS \\
          $DOCKER_NETWORK_OPTIONS \\
          $INSECURE_REGISTRY \\
          2> $(/usr/bin/forward-journald -2) | /usr/bin/forward-journal -1
```


Not really, that's why I used `os.devnull` instead of `/dev/null`. This should work on Windows (and works in wine)


так нельзя же.


I will leave it as it is called in almost all of the commits an renaming is painful. We can rename it as separate commit on the top.


Don't align assignments anywhere pls


It's been moved up due to a dependency between resolve and `_stream.open`


**FAILURE** - TeamCity HotRod C# Client :: Pull requests monitor - WIN_S2012 [Build 91](http://ci.infinispan.org/viewLog.html?buildId=36911&buildTypeId=HotRodCSharp_PullRequestsMonitorWinS2012&guest=1) for 9ddcf6b389ecdc8144348182d4faf966b2c9cee1
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:13:05

Process exited with code 255


done


No, you don't. This is old Entware feed as it should be.


...
Are you kidding me?


Lol this is a cool bug - that last operator should be `||`, not `|`.


Set some message here.


That makes sense... you're absolutely right... I guess that's a fair compromise.


putz!
link-to pede `conversation.id`
e o transitionTo pode ser `conversation`!


`||` not `or` throughout pls


I suggest not to inherit create method but instead make use of `default_get()`. There you can write a short sql which finds ean with highest sequence. It is a general recommendation not to inherit main functions like create, write, unlink etc.


TeamCity Selenium POM :: CI [Build 64](https://teamcity.sponte.uk/viewLog.html?buildId=1078&buildTypeId=SeleniumPom_Ci) is now running


@rapoulson Looks like a merge conflict snuck in.


FluxEnginge is written in Python and requires the following packages: netCDF4, os, sys, re, math, numpy, random.


`RabbitTemplete.doExecute()`:
```
try {
	if (logger.isDebugEnabled()) {
		logger.debug("Executing callback on RabbitMQ Channel: " + channel);
	}
	return action.doInRabbit(channel);
}
catch (Exception ex) {
	if (isChannelLocallyTransacted(channel)) {
		resourceHolder.rollbackAll();
	}
	throw convertRabbitAccessException(ex);
}
finally {
	ConnectionFactoryUtils.releaseResources(resourceHolder);
}
```
See the `finally` block. Independently of the `doInRabbit` result we end up there. Therefore the call there `channel.close()` returns the `ChannelProxy` to the cache.

That is how it works for a while already.

The leak should be somewhere else...


TeamCity Selenium POM :: CI [Build 64](https://teamcity.sponte.uk/viewLog.html?buildId=1078&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 41 Build time: 00:00:51


Ah, you went ahead and added it to the tar. Next time, do it in on a follow-on PR. This was headed for the submit-queue (and almost merged) before you pushed a new copy. :)

This is necessary but not sufficient. We actually need to get it into the server binary tar as well so it lands on the master/nodes. I'm going to LGTM this again and we can iterate.


Small typographical errors are the bane of programming. One day someone will invent a compiler that solves for these.

`{{#ifCond page "blogs"}}`


It should be equivalent behaviour, `_unacked` should have been initialized to 0, and this is called in onConnect, which is only called once.


I wonder what kinds of issues we may have in this area. The meaning of settings is implemented by the puppet runtime, user may set values in their puppet.conf and environment.conf. While it should be possible to parse those and perform interpolations, the native side may not have all of the parameters (for that it would need to read defaults.rb). Hopefully we can define a sane subset of relevant settings that are set to default values in native the same way they are in defaults.rb. (Add a ticket, start a doc for that?)


Add `inverse=` method and drop create, write function inheritance.


Some code I wanted to save along the way, still looking


А можно для соли тоже? Она же просто константа в коде.


个人添加


Great to hear that :)


test


contextは持たない :no_good:
ArrayAdapter#getContext() があります。


Whoops


Daz better :)

But i meant how its coded. Not formatting lol


this should be Baaar!


this is for develop branch


Why no `!`?


ok, thanks for clarification


No, you're fine.


when go packages are importing **github.com/cucumber/gherkin-go** it always pulls it from the master (default) branch. gopkg.in is based on major release version tags, it always pull latest release constrained by major version number. example **gopkg.in/cucumber/gherkin-go.v3** will pull from latest 3.x.x tag.

So the effect is, that all packages, which were using **github.com/cucumber/gherkin-go** explicitly will get a BC break whenever they try to install or update.


Erm... the cluster plugin doesn't do this prior to invoking the plugin functions, sorry - did a quick grep but didn't check. I'll submit another PR for the output_sub functions to accept flags


some change happen


This link seems to be an old one ?
I think now the link should have "Tutorials" in it as it got moved to Users/Tutorials


Свою отдельную настройку? назвать bsl.editor.tabsaize?


"if you set a bool, it will return a bool"; not sure; see https://riverbankcomputing.com/pipermail/pyqt/2010-December/028916.html.  Need more tests.


ok


Fixed with #4.


Upgrade da dev como bkup


I think we should have more info about doing this in the master branch and then doing `rebase` in the actual branch they're working on.

Just doing this on the branch theyre working on would give a "Merge branch" commit I think ?


Do you want to use `self.assertRaises` instead?


appear works ok


Shouldn't we base on "oberthur/redis-base:latest" in this repo?


Not sure about this, it would put an empty wiredep value inside configuration which doesn't use it like in Webpack or SystemJS


I lean towards biasing references to people who are already involved in a project. May require a bit more intelligence from the autocomplete system.... but I dont think it's undoable. But that'll be another task for another day.


develop (mjwitte) - x86_64-MacOS-10.9-clang: OK (1568 of 1568 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


thanks -- cut and paste issue


This makes me think about the "single module" use case where you have to jump through hoops to get a single directory named after the module in a directory where there are no other directories (that become potential modules because the module path points there). e.g. ~/git/myname-mymodule/ is where the module is checked out, the other directories in ~/git are often not all modules, and they are most often named the wrong way even if they do contain modules. Not sure what to do about that, when testing a way around it is to add a symlink (done by the test framework). Maybe have a flag to control this?


FWIW, I think this is a fairly important fix to take because the resource leakage on Android at the moment is indeed pretty high. Even if you construct a map view just once and reuse that instance within your application, a couple of problems still remain today:

* Exiting your app via "back" seems to leave the process owning a lot of resources
* Reloading your app in place dynamically during development leaks a lot too

A couple of notes on the suggested fix:

1. I note that `AirMapView` already has a `com.facebook.react.bridge.LifecycleEventListener` in it. It would probably be good to forward those callbacks to the `AirMapView` too. This may help address resource usage while the app is in background or when it exits.
2. Normally these days Android reliably takes things via `onPause()` before `onDestroy()`. Depending on the internals of MapView, it may be prudent to call `onPause()` then `onDestroy()` in `onDropViewInstance()` just in case some cleanup is done in the former exclusively (but taking care with any interactions with #1 if that's implemented).


would the better pattern be to just have them be undefined?


Needed on 16.03?


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1587 of 1587 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I would prefer splitting watches of index.html and the other. index.html modification should launch inject, all the other html files are just templates where a simple reload should be enough


弹了


// komentarz


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


No - imho that is a leaking abstraction. Users of this API should not have to know anything about `re` nor should they care. They just care whether or not the comparison is case-sensitive (or whatever).


Что за магические числа 2.5?? вынеси в переменные с понятными именами


+1 The C++ test should be updated too.


Yeah on flatgrass I was playing billy mays clips. Will test again tonight


Is this better ?
````javascript
<% if (modules === 'inject') { -%>
  exports.wiredep = {};
<% } -%>
````


Fantastic. I'm really glad you have found the time to improve the scss linting package. I agree it was incredibly slow (almost painful) in large applications. I'll merge this in when I can


You can use a single PR for a branch with several commits - one to introduce the API change and one for the plugin change to use it (it's absolutely fine to use one PR for multiple related commits - it's only when people glom on a bunch of random "and this too!" crap that it's a problem).


Артем, Пиши TODO над методами которые не до конца работает и слабеют доработать. Мы ж потом не докопаемся в чем дело.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18016](https://teamcity.mesosphere.io/viewLog.html?buildId=151324&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 245 Build time: 00:04:02


next line you want to do this:

entry = book.add_entry('Ada Lovelace', '010.012.1815', 'augusta.king@lovelace.com')


the name "config" seems much too vague...


Muy buen aporte!


Suggest resyncing the repo and pushing the results to the PR.


комментарии на английском конечно же


(and I am fine with adding named params for other regex options if or when we have a use case for them)


I think noroot or caps.drop.all would break it - at list it breaks Crome/Chromium.


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1013 of 1013 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-29.44%25-green.svg)


Created a new issue for this


We need similar REDIS_CONFIG to be able to provide redis.config contents via multiline env variable


что за test?


Oh cool! Did not read the docs on it, just assumed it'd not be available on Windows.


финальной это когда? )


ok this is fine with me.


should just say "will auto-login as root,"  (delete the final "at")


Не, я имею ввиду, что нельзя настраивать отступы/размер табов в разрезе каждого из языков, как это можно делать в ST и Atom.
Свой дополнительный конфиг-то можно, да.


I think its fine...in `0.10.2` the `user` must have been provided like this (or all kwarg settings which still work):

`Client("webdc.eu", user="blub")` or `Client("webdc.eu", 18002, "blub")`, otherwise a warning would have been raised. These now both raise errors so it should be easy to fix for users. It can only work in unexpected ways for people who chose to ignore the warning which is not really our problem.


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#C7PVYDk-Rbi2rW1PS_JtkA


You mean change this to:

`git checkout master`
`git pull origin`
`git rebase origin/master`


очень плохая практика комментировать метод. Лучше напиши TODO что с ним не так


используем локализацию


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18015](https://teamcity.mesosphere.io/viewLog.html?buildId=151323&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 245 Build time: 00:07:33


I have no idea, I blindly copied it from https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/common/Logging/Log.h#L172


I think we should try to prepare generic configurable redis node image, that means:
* that we should change name from k8s-cluster to sth. like env-var-conf-redis-node or configurable-redis-node or 12factor-redis-node (not sure which one is the best)
* that in README.MD we should have example with raw docker (not K8S)


все JS скрипты только в теге head


```
git checkout master
git pull origin master
git checkout branchname
git rebase master
```
and explain what each does


ta


Note that the dot notation to access the object properties and the use of DOM syntax instead of raw HTML will be refactored in another PR.


> it works properly ... 0x00 = +10dB (digital gain for headphones)
and eardiggain_v = 0x10 = +0dB ... tested and works :-)

It doesn't seem that 0x0 sets +10 dB, according to this: https://github.com/ace2nutzer/Samsung_STE_Kernel/blob/3f38576134d27a6c0effe53a85d4073c41fc43ae/sound/soc/codecs/ab8500_audio.c#L693
https://github.com/ace2nutzer/Samsung_STE_Kernel/blob/3f38576134d27a6c0effe53a85d4073c41fc43ae/sound/soc/codecs/ab8500_audio.c#L733

in both cases it sets +8dB.

> btw2: do u use Bass boost on DSP app ??
I've tried it .. and it's just amazing ... sounds like an subwoofer ^^ But my headphone only can handle "clean" with "low" ... which is already good ... but @ "extreme" it's really amazing..

No, I don't use DSP app, but I was using a similar(but non-free) app for a long time and now looking for a free analog.


footer.jsp


[Symfony\Component\Debug\Exception\ContextErrorException]
  Notice: Undefined index: scheme in /vendor/doctrine/doctrine-cache-bundle/DependencyInjection/Definition/PredisDefinition.php line 49


I also prefer `IllegalStateException` but given that is a findbugs driven change I didn't want to change the external behavior (if this kind of change is ok I'm happy to apply it).

The case for `null` that I have seen is that "called during initialization, extensions not ready yet", quite corner case.


на будущее - подключение новых JS библиотек лучше делать отдельным комитом.


@rlgomes Unless I’m missing something, this message template still includes response body into the error message (because in `lib/adapters/http/read.js`, the `body` property is set to `message`, which includes `body.join('')`). This is not what I had in mind in my [comment](https://github.com/juttle/juttle/issues/465#issuecomment-190788569).

The fix is to omit ` and response {body}` from the template.


Tested, different IPs work. Maybe Mojang added a time limit.


TeamCity LabKey :: Sprint :: Premium :: Git postgres 9.4 [Build 27](https://teamcity.labkey.org/viewLog.html?buildId=307120&buildTypeId=LabKey_Sprint_2_LabkeyPremiumTrunk_GitPostgres94) outcome was **FAILURE**
Summary: Tests failed: 10, passed: 269 Build time: 00:43:15
### Failed tests
```
org.labkey.test.tests.trialshare.TrialShareDataFinderTest.testPublicationDetail: <no details avaliable>

org.labkey.test.tests.trialshare.TrialShareDataFinderTest.testStudySummaryWindow: <no details avaliable>

org.labkey.test.tests.trialshare.TrialShareDataFinderTest.testStudyCards: <no details avaliable>

org.labkey.test.tests.trialshare.TrialShareDataFinderTest.testSelection: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStickyFinderFilterOnDataset: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testGroupSaveAndLoad: <no details avaliable>

org.labkey.test.tests.cas.SSOwithCASTest.testSSOwithCASFromHeaderLink: <no details avaliable>

org.labkey.test.tests.cas.SSOwithCASTest.testNewUserSSO: <no details avaliable>

org.labkey.test.tests.cas.SSOwithCASTest.testSSOWithCASFromLoginPage: <no details avaliable>

org.labkey.test.tests.cas.SSOwithCASTest.testCASUnreachable: <no details avaliable>

```


The above makes me think about symlinks. Naturally there needs to be protection against user having created recursive structures. Also, since symlinks are often used to link in test fixtures there should perhaps be an option to not follow symlinks (as well as the recursion guard). New tickets? Or are there already mechanisms in place?

This also reminds me that there is some special handling of the "manifest" setting as it can refer to a directory that is recursively parsed in depth first alpha numerical order (based on file/directory name). It is important that the native parser treats a site.pp directory the same way. Think we need a ticket for that.


OK... so before this commit they were all identical, and I was using a theme I actually didn't like.  That explains it.  Thanks for answering; sorry for bothering you.  :smile_cat:


эта страница нужна в мастере?


delete this line (it's out of place in the process steps).  The autologin is mentioned below.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18017](https://teamcity.mesosphere.io/viewLog.html?buildId=151325&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 245 Build time: 00:03:48


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18018](https://teamcity.mesosphere.io/viewLog.html?buildId=151326&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 245 Build time: 00:03:51


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18020](https://teamcity.mesosphere.io/viewLog.html?buildId=151328&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:04:18


This will produce two records for FAIL. When you do an interrupt on the report, the engine will fire a "ReportInterruptedException" which will make the "reportComponent.execute()" return "false". So there is no need to log the fail on cancel in the Audit log.


if possible it would be nice to output the actual default directory


siema


рекомендую делать дао через JdbcDaoSupport , это упрощает код


A single [[BrandName]] is not good enough, since an `HTMLParagraphElement` needs to be branded as `HTMLParagraphElement`, `HTMLElement`, `Element`, `Node`, and `EventtTarget`.  Basically, each IDL object needs to have a list of associated brands with it or something.


Absolutely. Setting that up now should provide plenty of data and opportunities for content down the road.


Perfect code. :+1: :100: :8ball:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18019](https://teamcity.mesosphere.io/viewLog.html?buildId=151327&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 245 Build time: 00:07:14


done


**注意**

1. 由于用户在使用打开最近应用列表一键清空应用时,应用的所有进程都将会关闭,所以开启的后台服务和开机自启动均无效,不打算使用流氓软件的策略,为保证应用能运行,切勿通过以上手段关闭,有必要时给予用户通告


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18021](https://teamcity.mesosphere.io/viewLog.html?buildId=151329&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 243 Build time: 00:04:07


typo: threshold


still trying to understand.
why re-set orte_nowarn_debug_build in   orte/runtime/orte_mca_params.c  line 746, when already set to false (default) in orte_globals.c?

Also why is  orte_cmd_line.nowarn_debug_build set to false, and not to orte_nowarn_debug_build global default value?


add .gitignore


What is that good for?


same here


nice :+1:


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#GpBs2vteQ7207L0WKE7mTg


valid observation, however, originally i had POSIXct format which had some problems similar to this report:https://github.com/rstudio/shiny/issues/904 (i should probably revert my code and re-report the issue)


This now needs to be added to `libostree.sym`.  Also we need to remember to bump `ostree-sections.txt` too, I keep forgetting that...

This is optional, but if we can I'd like to at least have API addition commits come with tests.  I'm going to work on improving that situation.


Isn't it the purpose of 'get_terminal_columns' (just below) to look after the variable `OPAMCOLUMNS` (without underscore).


- assets/app/views/_backingserviceinstance-detail.html这个文件是多余的，删掉
- assets/app/views/browse/_backing-service-instance-detail.html这个文件还没改完，变量名还没更新


Perfect emoji :musical_keyboard: :gem: :gem: :egg: :minidisc:
:fu: :fu: :fu: :fu: :fu: :facepunch: :lollipop: :package:


What do you mean by "not really"?


OK


I've been independently working on adding NRF24 support to Cleanflight, and have only just noticed this.

My code is at: https://github.com/martinbudden/cleanflight/tree/nrf24

My initial aim was to add NRF24 support for the CJMCU FC, then enabling it for other FCs either directly or using soft SPI.

My code differs in at least three ways:

1. It's designed to support multiple protocols, set from the Cleanflight configurator. I've currently got the SymaX and SymaX5C protocols working. (I started with Syma because you can buy the transmitters cheaply.) (I've got partially implemented v202, yd717 and cx10 protocols as well - I'm struggling with the cx10 at the moment.)

2. The decoding of the payload is done in the `rcReadRawData` function which better fits in with the new scheduler. (Although this is less important if the RX becomes IRQ driven.)

3. I've replaced the `NRF24L01_SetTxRxMode` with three separate functions (SetTxMode, SetRxMode and SetStandbyMode) and cleaned these functions up a bit.

I've also written quite a bit of test code for the protocols.

I think it would be certainly beneficial to merge the two codebases together, in particular to get the support for multiple protocols. This would allow a future Cleanflight specific protocol to be written (which could be implemented for DeviationTx). My view is that a NRF24 based receiver would potentially give better performance than many of the commercially available receivers.

Let me know your thoughts.


I'm thinking of keeping it as 'as root at the console' so people don't mistakenly expect that behaviour over SSH. Is that OK with you?


In this case no need of this additional record, just closing this, currently is ok.


No all of the set_x methods call AlarmState::issue.

So am I right in thinking while it's a bad idea for a class's method to change member variables belonging to another class, we can use a class's method to call a method belonging to another class which then changes its own member variable?

So in this case AlarmState::issue() should call AlarmManager::start_resending() which then sets the AlarmManager::_first_alarm_raised to true.


@Avtonom please open an issue (and provide the full stack trace). Commit comments are not a supported way of reporting issues (they are not tracked when looking at the list of issues needing to be fixed)


done


Please remove this line and the associated passing of the `Logger` down.


Please create pull requests for merging


워터마크 색깔이 부담스럽게 밝은 것 같지만
위아래 높이는 괜찮을 것 같다.


yes, put the "at the console" back in.


read


Why is this taken care of here, rather than being taken care of on line 103?


We could probably hide the video in CSS too but if we are going to incorporate changes to Plyr itself we will probably do something there.


This doesn't work, as find_mechanism() requires a CKF_ as second argument and not CKM_.

As a result all pkcs11-tool --keypairgen fails if no -m is given on the command line.

I've created #700 to track the issue.


If you're going to remove the curly braces (good idea), then the first execution needs to follow on the same line.


Aaah ok sorry about that, was confused. thank

On Wed, Mar 2, 2016 at 1:48 AM, Cory Zue <notifications@github.com> wrote:

> My understanding was that everything is supposed to go through
> FormProcessorInterface, and then you use it's helper methods to get the
> other processors.
>
> So for this you would use this function
> <https://github.com/dimagi/commcare-hq/blob/master/corehq/form_processor/interfaces/processor.py#L70>
> and do:
>
> FormProcessorInterface(domain).ledger_processor.whatever()
>
> Happy to change, but I think that's quite similar to how we do the case db
> and underlying form processor
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dimagi/commcare-hq/commit/5226b4faa40ac1ece993adfdfc8ace5eb56a006e#commitcomment-16437763>
> .
>


`debugPrint`?


Up a line


提交功能不完整，提交时应该尽量保证每次提交都是一个完整功能


extracted to separate commit


Why you add empty string in the middle? :smile:


we can add one blank line here :nail_care:


For Unit _testing_ and _structure _purposes.
1) I suggest adding private _access modifiers_ for the field variables.
2) Also, I think this file can benefit from applying **_'finding bugs'_** to capture cases like _exception handling_.


Ek sukkel hierso . Om alles mooi op te line.


Are you sure about this?


I meant: "to look after `COLUMNS`". Sorry for the confusion.


Let's put this in `spec/spec_helper.rb` :kissing:


Closes #1


当前位置所能到达的最远距离


Yes.


**FAILURE** - TeamCity HotRod C# Client :: Pull requests monitor - WIN_S2012 [Build 92](http://ci.infinispan.org/viewLog.html?buildId=36915&buildTypeId=HotRodCSharp_PullRequestsMonitorWinS2012&guest=1) for 9ddcf6b389ecdc8144348182d4faf966b2c9cee1
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:30:06

Execution timeout

Process exited with code 1


on Tue Mar 01 2016, Károly Lőrentey <notifications-AT-github.com> wrote:

> I did replace this use of indexing! Is this really the most recent
> version of this PR? (I've since replaced `_expectEnd` below with
> another function.)

Sorry, clearly I need to be commenting on the completed diff in the PR
rather than the individual steps used to get there.

--
-Dave