[inst/examples/globe/server.R:3:27:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L3) *style:* **Put spaces around all infix operators.**
```r
data(world.cities, package="maps")
                         ~^~
```
[inst/examples/globe/server.R:7:48:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L7) *style:* **Commas should always have a space after.**
```r
earth_dark   <- system.file("images/world.jpg",package="threejs")
                                               ^
```
[inst/examples/globe/server.R:7:55:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L7) *style:* **Put spaces around all infix operators.**
```r
earth_dark   <- system.file("images/world.jpg",package="threejs")
                                                     ~^~
```
[inst/examples/globe/server.R:8:42:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L8) *style:* **Commas should always have a space after.**
```r
moon    <- system.file("images/moon.jpg",package="threejs")
                                         ^
```
[inst/examples/globe/server.R:8:49:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L8) *style:* **Put spaces around all infix operators.**
```r
moon    <- system.file("images/moon.jpg",package="threejs")
                                               ~^~
```
[inst/examples/globe/server.R:9:42:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L9) *style:* **Commas should always have a space after.**
```r
mars    <- system.file("images/mars.jpg",package="threejs")
                                         ^
```
[inst/examples/globe/server.R:9:49:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L9) *style:* **Put spaces around all infix operators.**
```r
mars    <- system.file("images/mars.jpg",package="threejs")
                                               ~^~
```
[inst/examples/globe/server.R:10:45:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L10) *style:* **Commas should always have a space after.**
```r
jupiter <- system.file("images/jupiter.jpg",package="threejs")
                                            ^
```
[inst/examples/globe/server.R:10:52:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L10) *style:* **Put spaces around all infix operators.**
```r
jupiter <- system.file("images/jupiter.jpg",package="threejs")
                                                  ~^~
```
[inst/examples/globe/server.R:12:15:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L12) *style:* **Put spaces around all infix operators.**
```r
    earth_dark=list(img=earth_dark,bodycolor="#0011ff",emissive="#0011ff",lightcolor="#99ddff"),
             ~^~
```
[inst/examples/globe/server.R:12:24:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L12) *style:* **Put spaces around all infix operators.**
```r
    earth_dark=list(img=earth_dark,bodycolor="#0011ff",emissive="#0011ff",lightcolor="#99ddff"),
                      ~^~
```
[inst/examples/globe/server.R:12:36:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L12) *style:* **Commas should always have a space after.**
```r
    earth_dark=list(img=earth_dark,bodycolor="#0011ff",emissive="#0011ff",lightcolor="#99ddff"),
                                   ^
```
[inst/examples/globe/server.R:12:45:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L12) *style:* **Put spaces around all infix operators.**
```r
    earth_dark=list(img=earth_dark,bodycolor="#0011ff",emissive="#0011ff",lightcolor="#99ddff"),
                                           ~^~
```
[inst/examples/globe/server.R:12:56:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L12) *style:* **Commas should always have a space after.**
```r
    earth_dark=list(img=earth_dark,bodycolor="#0011ff",emissive="#0011ff",lightcolor="#99ddff"),
                                                       ^
```
[inst/examples/globe/server.R:12:64:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L12) *style:* **Put spaces around all infix operators.**
```r
    earth_dark=list(img=earth_dark,bodycolor="#0011ff",emissive="#0011ff",lightcolor="#99ddff"),
                                                              ~^~
```
[inst/examples/globe/server.R:12:75:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L12) *style:* **Commas should always have a space after.**
```r
    earth_dark=list(img=earth_dark,bodycolor="#0011ff",emissive="#0011ff",lightcolor="#99ddff"),
                                                                          ^
```
[inst/examples/globe/server.R:12:85:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L12) *style:* **Put spaces around all infix operators.**
```r
    earth_dark=list(img=earth_dark,bodycolor="#0011ff",emissive="#0011ff",lightcolor="#99ddff"),
                                                                                ~^~
```
[inst/examples/globe/server.R:13:9:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L13) *style:* **Put spaces around all infix operators.**
```r
    moon=list(img=moon,bodycolor="#555555", emissive="#444444", lightcolor="#555555"),
       ~^~
```
[inst/examples/globe/server.R:13:18:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L13) *style:* **Put spaces around all infix operators.**
```r
    moon=list(img=moon,bodycolor="#555555", emissive="#444444", lightcolor="#555555"),
                ~^~
```
[inst/examples/globe/server.R:13:24:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L13) *style:* **Commas should always have a space after.**
```r
    moon=list(img=moon,bodycolor="#555555", emissive="#444444", lightcolor="#555555"),
                       ^
```
[inst/examples/globe/server.R:13:33:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L13) *style:* **Put spaces around all infix operators.**
```r
    moon=list(img=moon,bodycolor="#555555", emissive="#444444", lightcolor="#555555"),
                               ~^~
```
[inst/examples/globe/server.R:13:53:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L13) *style:* **Put spaces around all infix operators.**
```r
    moon=list(img=moon,bodycolor="#555555", emissive="#444444", lightcolor="#555555"),
                                                   ~^~
```
[inst/examples/globe/server.R:13:75:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L13) *style:* **Put spaces around all infix operators.**
```r
    moon=list(img=moon,bodycolor="#555555", emissive="#444444", lightcolor="#555555"),
                                                                         ~^~
```
[inst/examples/globe/server.R:14:9:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L14) *style:* **Put spaces around all infix operators.**
```r
    mars=list(img=mars,bodycolor="#aaaaaa", emissive="#000000", lightcolor="#aaaaaa"),
       ~^~
```
[inst/examples/globe/server.R:14:18:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L14) *style:* **Put spaces around all infix operators.**
```r
    mars=list(img=mars,bodycolor="#aaaaaa", emissive="#000000", lightcolor="#aaaaaa"),
                ~^~
```
[inst/examples/globe/server.R:14:24:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L14) *style:* **Commas should always have a space after.**
```r
    mars=list(img=mars,bodycolor="#aaaaaa", emissive="#000000", lightcolor="#aaaaaa"),
                       ^
```
[inst/examples/globe/server.R:14:33:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L14) *style:* **Put spaces around all infix operators.**
```r
    mars=list(img=mars,bodycolor="#aaaaaa", emissive="#000000", lightcolor="#aaaaaa"),
                               ~^~
```
[inst/examples/globe/server.R:14:53:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L14) *style:* **Put spaces around all infix operators.**
```r
    mars=list(img=mars,bodycolor="#aaaaaa", emissive="#000000", lightcolor="#aaaaaa"),
                                                   ~^~
```
[inst/examples/globe/server.R:14:75:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L14) *style:* **Put spaces around all infix operators.**
```r
    mars=list(img=mars,bodycolor="#aaaaaa", emissive="#000000", lightcolor="#aaaaaa"),
                                                                         ~^~
```
[inst/examples/globe/server.R:15:12:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L15) *style:* **Put spaces around all infix operators.**
```r
    jupiter=list(img=jupiter,bodycolor="#222222", emissive="#000000", lightcolor="#aaaaaa")
          ~^~
```
[inst/examples/globe/server.R:15:21:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L15) *style:* **Put spaces around all infix operators.**
```r
    jupiter=list(img=jupiter,bodycolor="#222222", emissive="#000000", lightcolor="#aaaaaa")
                   ~^~
```
[inst/examples/globe/server.R:15:30:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L15) *style:* **Commas should always have a space after.**
```r
    jupiter=list(img=jupiter,bodycolor="#222222", emissive="#000000", lightcolor="#aaaaaa")
                             ^
```
[inst/examples/globe/server.R:15:39:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L15) *style:* **Put spaces around all infix operators.**
```r
    jupiter=list(img=jupiter,bodycolor="#222222", emissive="#000000", lightcolor="#aaaaaa")
                                     ~^~
```
[inst/examples/globe/server.R:15:59:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L15) *style:* **Put spaces around all infix operators.**
```r
    jupiter=list(img=jupiter,bodycolor="#222222", emissive="#000000", lightcolor="#aaaaaa")
                                                         ~^~
```
[inst/examples/globe/server.R:15:81:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L15) *style:* **Put spaces around all infix operators.**
```r
    jupiter=list(img=jupiter,bodycolor="#222222", emissive="#000000", lightcolor="#aaaaaa")
                                                                               ~^~
```
[inst/examples/globe/server.R:23:42:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L23) *style:* **Commas should always have a space after.**
```r
     world.cities[order(world.cities$pop,decreasing=TRUE)[1:input$N],]
                                         ^
```
[inst/examples/globe/server.R:23:52:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L23) *style:* **Put spaces around all infix operators.**
```r
     world.cities[order(world.cities$pop,decreasing=TRUE)[1:input$N],]
                                                  ~^~
```
[inst/examples/globe/server.R:23:70:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L23) *style:* **Commas should always have a space after.**
```r
     world.cities[order(world.cities$pop,decreasing=TRUE)[1:input$N],]
                                                                     ^
```
[inst/examples/globe/server.R:29:29:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L29) *style:* **Put spaces around all infix operators.**
```r
    col <- rainbow(10, start=2.8 / 6,end=3.4 / 6)
                           ~^~
```
[inst/examples/globe/server.R:29:38:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L29) *style:* **Commas should always have a space after.**
```r
    col <- rainbow(10, start=2.8 / 6,end=3.4 / 6)
                                     ^
```
[inst/examples/globe/server.R:29:41:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L29) *style:* **Put spaces around all infix operators.**
```r
    col <- rainbow(10, start=2.8 / 6,end=3.4 / 6)
                                       ~^~
```
[inst/examples/globe/server.R:33:15:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L33) *style:* **Put spaces around all infix operators.**
```r
    list(value=value, color=col, cities=cities)
             ~^~
```
[inst/examples/globe/server.R:33:28:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L33) *style:* **Put spaces around all infix operators.**
```r
    list(value=value, color=col, cities=cities)
                          ~^~
```
[inst/examples/globe/server.R:33:40:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L33) *style:* **Put spaces around all infix operators.**
```r
    list(value=value, color=col, cities=cities)
                                      ~^~
```
[inst/examples/globe/server.R:40:32:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L40) *style:* **Commas should never have a space before.**
```r
    args <- c(col[[input$map]] , list(lat=v$cities$lat, long=v$cities$long, value=v$value, color=v$color, atmosphere=atmo))
                              ~^
```
[inst/examples/globe/server.R:40:42:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L40) *style:* **Put spaces around all infix operators.**
```r
    args <- c(col[[input$map]] , list(lat=v$cities$lat, long=v$cities$long, value=v$value, color=v$color, atmosphere=atmo))
                                        ~^~
```
[inst/examples/globe/server.R:40:61:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L40) *style:* **Put spaces around all infix operators.**
```r
    args <- c(col[[input$map]] , list(lat=v$cities$lat, long=v$cities$long, value=v$value, color=v$color, atmosphere=atmo))
                                                           ~^~
```
[inst/examples/globe/server.R:40:82:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L40) *style:* **Put spaces around all infix operators.**
```r
    args <- c(col[[input$map]] , list(lat=v$cities$lat, long=v$cities$long, value=v$value, color=v$color, atmosphere=atmo))
                                                                                ~^~
```
[inst/examples/globe/server.R:40:97:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L40) *style:* **Put spaces around all infix operators.**
```r
    args <- c(col[[input$map]] , list(lat=v$cities$lat, long=v$cities$long, value=v$value, color=v$color, atmosphere=atmo))
                                                                                ~^~
```
[inst/examples/globe/server.R:40:117:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L40) *style:* **Put spaces around all infix operators.**
```r
    args <- c(col[[input$map]] , list(lat=v$cities$lat, long=v$cities$long, value=v$value, color=v$color, atmosphere=atmo))
                                                                                ~^~
```
[inst/examples/globe/server.R:41:26:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/server.R#L41) *style:* **Put spaces around all infix operators.**
```r
    do.call(globejs, args=args)
                        ~^~
```
[inst/examples/globe/ui.R:8:57:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/ui.R#L8) *style:* **Put spaces around all infix operators.**
```r
      sliderInput("N", "Number of cities to plot", value=5000, min = 100, max = 10000, step = 100),
                                                       ~^~
```
[inst/examples/globe/ui.R:9:31:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/ui.R#L9) *style:* **Put spaces around all infix operators.**
```r
      selectInput("map", label="Surface map",
                             ~^~
```
[inst/examples/globe/ui.R:11:24:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/ui.R#L11) *style:* **Put spaces around all infix operators.**
```r
           list("Earth"="earth_dark",
                      ~^~
```
[inst/examples/globe/ui.R:12:23:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/ui.R#L12) *style:* **Put spaces around all infix operators.**
```r
                "Moon"="moon",
                     ~^~
```
[inst/examples/globe/ui.R:13:23:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/ui.R#L13) *style:* **Put spaces around all infix operators.**
```r
                "Mars"="mars",
                     ~^~
```
[inst/examples/globe/ui.R:14:26:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/globe/ui.R#L14) *style:* **Put spaces around all infix operators.**
```r
                "Jupiter"="jupiter"),
                        ~^~
```
[inst/examples/scatterplot/server.R:5:3:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L5) *style:* **Place a space before left parenthesis, except in a function call.**
```r
if(!exists("example_data")) example_data <- matrix(runif(50 * 3), ncol=3)
  ^
```
[inst/examples/scatterplot/server.R:5:71:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L5) *style:* **Put spaces around all infix operators.**
```r
if(!exists("example_data")) example_data <- matrix(runif(50 * 3), ncol=3)
                                                                     ~^~
```
[inst/examples/scatterplot/server.R:11:7:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L11) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(num.ticks == 0) num.ticks <- NULL
      ^
```
[inst/examples/scatterplot/server.R:12:37:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L12) *style:* **Commas should always have a space after.**
```r
    else num.ticks <- rep(num.ticks,3)
                                    ^
```
[inst/examples/scatterplot/server.R:13:40:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L13) *style:* **Commas should always have a space after.**
```r
    color <- rep(rainbow(input$colors),length.out=nrow(example_data))
                                       ^
```
[inst/examples/scatterplot/server.R:13:50:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L13) *style:* **Put spaces around all infix operators.**
```r
    color <- rep(rainbow(input$colors),length.out=nrow(example_data))
                                                ~^~
```
[inst/examples/scatterplot/server.R:14:57:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L14) *style:* **Put spaces around all infix operators.**
```r
    sizes <- rep(c(0.5, 1, 2)[1:input$sizes], length.out=nrow(example_data))
                                                       ~^~
```
[inst/examples/scatterplot/server.R:15:61:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L15) *style:* **Commas should always have a space after.**
```r
    labs <- sprintf("x=%.2f, y=%.2f, z=%.2f", example_data[,1], example_data[,2], example_data[,3])
                                                            ^
```
[inst/examples/scatterplot/server.R:15:79:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L15) *style:* **Commas should always have a space after.**
```r
    labs <- sprintf("x=%.2f, y=%.2f, z=%.2f", example_data[,1], example_data[,2], example_data[,3])
                                                                              ^
```
[inst/examples/scatterplot/server.R:15:97:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L15) *style:* **Commas should always have a space after.**
```r
    labs <- sprintf("x=%.2f, y=%.2f, z=%.2f", example_data[,1], example_data[,2], example_data[,3])
                                                                                ^
```
[inst/examples/scatterplot/server.R:16:21:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L16) *style:* **Put spaces around all infix operators.**
```r
    scatterplot3js(x=example_data,
                   ~^~
```
[inst/examples/scatterplot/server.R:17:30:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L17) *style:* **Put spaces around all infix operators.**
```r
                    num.ticks=num.ticks,
                            ~^~
```
[inst/examples/scatterplot/server.R:18:26:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L18) *style:* **Put spaces around all infix operators.**
```r
                    color=color,
                        ~^~
```
[inst/examples/scatterplot/server.R:19:25:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L19) *style:* **Put spaces around all infix operators.**
```r
                    size=sizes,
                       ~^~
```
[inst/examples/scatterplot/server.R:20:27:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L20) *style:* **Put spaces around all infix operators.**
```r
                    labels=labs,
                         ~^~
```
[inst/examples/scatterplot/server.R:21:33:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L21) *style:* **Put spaces around all infix operators.**
```r
                    label.margin="80px 10px 10px 10px",
                               ~^~
```
[inst/examples/scatterplot/server.R:22:29:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L22) *style:* **Put spaces around all infix operators.**
```r
                    renderer=input$renderer,
                           ~^~
```
[inst/examples/scatterplot/server.R:23:25:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/server.R#L23) *style:* **Put spaces around all infix operators.**
```r
                    grid=input$grid)
                       ~^~
```
[inst/examples/scatterplot/ui.R:13:36:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/ui.R#L13) *style:* **Put spaces around all infix operators.**
```r
      selectInput("renderer", label="Rendering method",
                                  ~^~
```
[inst/examples/scatterplot/ui.R:14:31:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/ui.R#L14) *style:* **Put spaces around all infix operators.**
```r
         choices = list("Auto"="auto", "Canvas"="canvas", "WebGL"="webgl"),
                             ~^~
```
[inst/examples/scatterplot/ui.R:14:48:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/ui.R#L14) *style:* **Put spaces around all infix operators.**
```r
         choices = list("Auto"="auto", "Canvas"="canvas", "WebGL"="webgl"),
                                              ~^~
```
[inst/examples/scatterplot/ui.R:14:66:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/inst/examples/scatterplot/ui.R#L14) *style:* **Put spaces around all infix operators.**
```r
         choices = list("Auto"="auto", "Canvas"="canvas", "WebGL"="webgl"),
                                                                ~^~
```
[R/globe.R:162:47:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L162) *style:* **Put spaces around all infix operators.**
```r
  img=system.file("images/world.jpg",  package="threejs"),
                                             ~^~
```
[R/globe.R:176:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L176) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(lat) || missing(long))
    ^
```
[R/globe.R:183:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L183) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(i) > 0)
    ^
```
[R/globe.R:186:7:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L186) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(any(j))
      ^
```
[R/globe.R:192:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L192) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(i) > 0)
    ^
```
[R/globe.R:195:7:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L195) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(any(j))
      ^
```
[R/globe.R:201:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L201) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(i) > 0) bg = substr(bg, 1, 7)
    ^
```
[R/globe.R:202:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L202) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(arcs))
    ^
```
[R/globe.R:212:21:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L212) *style:* **Put spaces around all infix operators.**
```r
  options = list(lat=lat, long=long, color=color, arcsOpacity=arcsOpacity,
                   ~^~
```
[R/globe.R:212:31:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L212) *style:* **Put spaces around all infix operators.**
```r
  options = list(lat=lat, long=long, color=color, arcsOpacity=arcsOpacity,
                             ~^~
```
[R/globe.R:212:43:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L212) *style:* **Put spaces around all infix operators.**
```r
  options = list(lat=lat, long=long, color=color, arcsOpacity=arcsOpacity,
                                         ~^~
```
[R/globe.R:212:62:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L212) *style:* **Put spaces around all infix operators.**
```r
  options = list(lat=lat, long=long, color=color, arcsOpacity=arcsOpacity,
                                                            ~^~
```
[R/globe.R:213:23:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L213) *style:* **Put spaces around all infix operators.**
```r
                 value=value, atmosphere=atmosphere, bg=bg, arcs=arcs,
                     ~^~
```
[R/globe.R:213:41:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L213) *style:* **Put spaces around all infix operators.**
```r
                 value=value, atmosphere=atmosphere, bg=bg, arcs=arcs,
                                       ~^~
```
[R/globe.R:213:56:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L213) *style:* **Put spaces around all infix operators.**
```r
                 value=value, atmosphere=atmosphere, bg=bg, arcs=arcs,
                                                      ~^~
```
[R/globe.R:213:65:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L213) *style:* **Put spaces around all infix operators.**
```r
                 value=value, atmosphere=atmosphere, bg=bg, arcs=arcs,
                                                               ~^~
```
[R/globe.R:214:27:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L214) *style:* **Put spaces around all infix operators.**
```r
                 arcsColor=arcsColor, arcsLwd=arcsLwd, arcsHeight=arcsHeight)
                         ~^~
```
[R/globe.R:214:46:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L214) *style:* **Put spaces around all infix operators.**
```r
                 arcsColor=arcsColor, arcsLwd=arcsLwd, arcsHeight=arcsHeight)
                                            ~^~
```
[R/globe.R:214:66:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L214) *style:* **Put spaces around all infix operators.**
```r
                 arcsColor=arcsColor, arcsLwd=arcsLwd, arcsHeight=arcsHeight)
                                                                ~^~
```
[R/globe.R:216:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L216) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(additional_args) > 0) options = c(options, additional_args)
    ^
```
[R/globe.R:218:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L218) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("bodycolor" %in% names(options))
    ^
```
[R/globe.R:220:19:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L220) *style:* **Commas should always have a space after.**
```r
    i = grep("^#",options$bodycolor)
                  ^
```
[R/globe.R:221:7:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L221) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(length(i) > 0) options$bodycolor = substr(options$bodycolor,1,7)
      ^
```
[R/globe.R:221:68:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L221) *style:* **Commas should always have a space after.**
```r
    if(length(i) > 0) options$bodycolor = substr(options$bodycolor,1,7)
                                                                   ^
```
[R/globe.R:221:70:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L221) *style:* **Commas should always have a space after.**
```r
    if(length(i) > 0) options$bodycolor = substr(options$bodycolor,1,7)
                                                                     ^
```
[R/globe.R:223:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L223) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("emissive" %in% names(options))
    ^
```
[R/globe.R:225:19:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L225) *style:* **Commas should always have a space after.**
```r
    i = grep("^#",options$emissive)
                  ^
```
[R/globe.R:226:7:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L226) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(length(i) > 0) options$emissive = substr(options$emissive,1,7)
      ^
```
[R/globe.R:226:66:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L226) *style:* **Commas should always have a space after.**
```r
    if(length(i) > 0) options$emissive = substr(options$emissive,1,7)
                                                                 ^
```
[R/globe.R:226:68:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L226) *style:* **Commas should always have a space after.**
```r
    if(length(i) > 0) options$emissive = substr(options$emissive,1,7)
                                                                   ^
```
[R/globe.R:228:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L228) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("lightcolor" %in% names(options))
    ^
```
[R/globe.R:230:19:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L230) *style:* **Commas should always have a space after.**
```r
    i = grep("^#",options$lightcolor)
                  ^
```
[R/globe.R:231:7:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L231) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(length(i) > 0) options$lightcolor = substr(options$lightcolor,1,7)
      ^
```
[R/globe.R:231:70:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L231) *style:* **Commas should always have a space after.**
```r
    if(length(i) > 0) options$lightcolor = substr(options$lightcolor,1,7)
                                                                     ^
```
[R/globe.R:231:72:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L231) *style:* **Commas should always have a space after.**
```r
    if(length(i) > 0) options$lightcolor = substr(options$lightcolor,1,7)
                                                                       ^
```
[R/globe.R:235:28:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L235) *warning:* **no visible global function definition for ‘texture’**
```r
  if (!is.list(img)) img = texture(img)
                           ^~~~~~~
```
[R/globe.R:259:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L259) *warning:* **no visible global function definition for ‘shinyRenderWidget’**
```r
    shinyRenderWidget(expr, globeOutput, env, quoted = TRUE)
    ^~~~~~~~~~~~~~~~~
```
[R/globe.R:259:29:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/globe.R#L259) *warning:* **no visible binding for global variable ‘globeOutput’**
```r
    shinyRenderWidget(expr, globeOutput, env, quoted = TRUE)
                            ^~~~~~~~~~~
```
[R/graph.R:81:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L81) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("igraph" %in% class(edges))
    ^
```
[R/graph.R:83:10:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L83) *warning:* **no visible global function definition for ‘igraph2graphjs’**
```r
    ig = igraph2graphjs(edges)
         ^~~~~~~~~~~~~~
```
[R/graph.R:87:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L87) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!is.data.frame(edges))
    ^
```
[R/graph.R:89:7:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L89) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(is.list(edges))
      ^
```
[R/graph.R:95:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L95) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(is.null(edges$size)) edges$size = 1
    ^
```
[R/graph.R:96:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L96) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(is.null(edges$color)) edges$color = "lightgray"
    ^
```
[R/graph.R:97:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L97) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!all(c("from", "size", "to", "color") %in% names(edges)))
    ^
```
[R/graph.R:101:26:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L101) *style:* **Put spaces around all infix operators.**
```r
    nodes = data.frame(id=unique(c(edges$from, edges$to)), size=1, color="orange", stringsAsFactors=FALSE)
                        ~^~
```
[R/graph.R:101:64:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L101) *style:* **Put spaces around all infix operators.**
```r
    nodes = data.frame(id=unique(c(edges$from, edges$to)), size=1, color="orange", stringsAsFactors=FALSE)
                                                              ~^~
```
[R/graph.R:101:73:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L101) *style:* **Put spaces around all infix operators.**
```r
    nodes = data.frame(id=unique(c(edges$from, edges$to)), size=1, color="orange", stringsAsFactors=FALSE)
                                                                       ~^~
```
[R/graph.R:101:100:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L101) *style:* **Put spaces around all infix operators.**
```r
    nodes = data.frame(id=unique(c(edges$from, edges$to)), size=1, color="orange", stringsAsFactors=FALSE)
                                                                                ~^~
```
[R/graph.R:104:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L104) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(is.null(nodes$label)) nodes$label = nodes$id
    ^
```
[R/graph.R:105:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L105) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(is.null(nodes$size)) nodes$size = 1
    ^
```
[R/graph.R:106:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L106) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(is.null(nodes$color)) nodes$color = "orange"
    ^
```
[R/graph.R:107:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L107) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!all(c("id", "size", "label", "color") %in% names(nodes)))
    ^
```
[R/graph.R:110:47:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L110) *style:* **Put spaces around all infix operators.**
```r
  stroke = switch(as.character(stroke), "TRUE"="black", "white")
                                             ~^~
```
[R/graph.R:113:17:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L113) *style:* **Put spaces around all infix operators.**
```r
  x = list(nodes=nodes,
               ~^~
```
[R/graph.R:114:17:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L114) *style:* **Put spaces around all infix operators.**
```r
           edges=edges,
               ~^~
```
[R/graph.R:115:16:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L115) *style:* **Put spaces around all infix operators.**
```r
           main=main,
              ~^~
```
[R/graph.R:116:14:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L116) *style:* **Put spaces around all infix operators.**
```r
           bg=bg,
            ~^~
```
[R/graph.R:117:14:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L117) *style:* **Put spaces around all infix operators.**
```r
           fg=fg,
            ~^~
```
[R/graph.R:118:22:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L118) *style:* **Put spaces around all infix operators.**
```r
           showLabels=showLabels,
                    ~^~
```
[R/graph.R:119:22:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L119) *style:* **Put spaces around all infix operators.**
```r
           attraction=attraction,
                    ~^~
```
[R/graph.R:120:21:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L120) *style:* **Put spaces around all infix operators.**
```r
           repulsion=repulsion,
                   ~^~
```
[R/graph.R:121:22:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L121) *style:* **Put spaces around all infix operators.**
```r
           iterations=max_iterations,
                    ~^~
```
[R/graph.R:122:21:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L122) *style:* **Put spaces around all infix operators.**
```r
           curvature=curvature,
                   ~^~
```
[R/graph.R:123:19:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L123) *style:* **Put spaces around all infix operators.**
```r
           opacity=opacity,
                 ~^~
```
[R/graph.R:124:18:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L124) *style:* **Put spaces around all infix operators.**
```r
           stroke=stroke)
                ~^~
```
[R/graph.R:127:35:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L127) *style:* **Put spaces around all infix operators.**
```r
          x = toJSON(x, auto_unbox=TRUE),
                                 ~^~
```
[R/graph.R:148:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L148) *warning:* **no visible global function definition for ‘shinyRenderWidget’**
```r
    shinyRenderWidget(expr, graphOutput, env, quoted = TRUE)
    ^~~~~~~~~~~~~~~~~
```
[R/graph.R:148:29:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L148) *warning:* **no visible binding for global variable ‘graphOutput’**
```r
    shinyRenderWidget(expr, graphOutput, env, quoted = TRUE)
                            ^~~~~~~~~~~
```
[R/graph.R:178:26:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L178) *style:* **Put spaces around all infix operators.**
```r
    nodes = data.frame(id=unique(c(edges$from, edges$to)))
                        ~^~
```
[R/graph.R:183:18:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L183) *style:* **Commas should always have a space after.**
```r
    idx = edges[,"from"] > edges[,"to"]
                 ^
```
[R/graph.R:183:35:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L183) *style:* **Commas should always have a space after.**
```r
    idx = edges[,"from"] > edges[,"to"]
                                  ^
```
[R/graph.R:184:7:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L184) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(any(idx))
      ^
```
[R/graph.R:195:22:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L195) *style:* **Commas should always have a space after.**
```r
  names(id) = nodes[,"id"]
                     ^
```
[R/graph.R:196:7:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L196) *warning:* **no visible global function definition for ‘sparseMatrix’**
```r
  M = sparseMatrix(i=id[as.character(edges$from)], j=id[as.character(edges$to)], x=x, dims=c(N, N), symmetric=symmetric)
      ^~~~~~~~~~~~
```
[R/graph.R:196:21:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L196) *style:* **Put spaces around all infix operators.**
```r
  M = sparseMatrix(i=id[as.character(edges$from)], j=id[as.character(edges$to)], x=x, dims=c(N, N), symmetric=symmetric)
                   ~^~
```
[R/graph.R:196:53:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L196) *style:* **Put spaces around all infix operators.**
```r
  M = sparseMatrix(i=id[as.character(edges$from)], j=id[as.character(edges$to)], x=x, dims=c(N, N), symmetric=symmetric)
                                                   ~^~
```
[R/graph.R:196:83:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L196) *style:* **Put spaces around all infix operators.**
```r
  M = sparseMatrix(i=id[as.character(edges$from)], j=id[as.character(edges$to)], x=x, dims=c(N, N), symmetric=symmetric)
                                                                                ~^~
```
[R/graph.R:196:91:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L196) *style:* **Put spaces around all infix operators.**
```r
  M = sparseMatrix(i=id[as.character(edges$from)], j=id[as.character(edges$to)], x=x, dims=c(N, N), symmetric=symmetric)
                                                                                ~^~
```
[R/graph.R:196:110:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L196) *style:* **Put spaces around all infix operators.**
```r
  M = sparseMatrix(i=id[as.character(edges$from)], j=id[as.character(edges$to)], x=x, dims=c(N, N), symmetric=symmetric)
                                                                                ~^~
```
[R/graph.R:197:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L197) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!is.null(nodes$label)) colnames(M) = rownames(M) = nodes$label
    ^
```
[R/graph.R:215:7:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L215) *warning:* **no visible global function definition for ‘Matrix’, Did you mean 'matrix'?**
```r
  M = Matrix(M)
      ^~~~~~
```
[R/graph.R:216:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L216) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!any(grepl("CMatrix", class(M)))) stop("M must be a matrix or CsparseMatrix object")
    ^
```
[R/graph.R:219:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L219) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("x" %in% slotNames(M)) size = as.numeric(M@x)
    ^
```
[R/graph.R:219:15:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L219) *warning:* **no visible global function definition for ‘slotNames’, Did you mean 'setNames'?**
```r
  if("x" %in% slotNames(M)) size = as.numeric(M@x)
              ^~~~~~~~~
```
[R/graph.R:220:24:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L220) *style:* **Put spaces around all infix operators.**
```r
  nodes = data.frame(id=1:n, label=1:n, size=1, color="orange")
                      ~^~
```
[R/graph.R:220:35:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L220) *style:* **Put spaces around all infix operators.**
```r
  nodes = data.frame(id=1:n, label=1:n, size=1, color="orange")
                                 ~^~
```
[R/graph.R:220:45:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L220) *style:* **Put spaces around all infix operators.**
```r
  nodes = data.frame(id=1:n, label=1:n, size=1, color="orange")
                                           ~^~
```
[R/graph.R:220:54:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L220) *style:* **Put spaces around all infix operators.**
```r
  nodes = data.frame(id=1:n, label=1:n, size=1, color="orange")
                                                    ~^~
```
[R/graph.R:221:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L221) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!is.null(colnames(M))) nodes$label = colnames(M)
    ^
```
[R/graph.R:223:26:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L223) *style:* **Put spaces around all infix operators.**
```r
  edges = data.frame(from=M@i + 1, to=rep(seq_along(dp), dp), size=size, color="lightgray")
                        ~^~
```
[R/graph.R:223:38:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L223) *style:* **Put spaces around all infix operators.**
```r
  edges = data.frame(from=M@i + 1, to=rep(seq_along(dp), dp), size=size, color="lightgray")
                                    ~^~
```
[R/graph.R:223:67:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L223) *style:* **Put spaces around all infix operators.**
```r
  edges = data.frame(from=M@i + 1, to=rep(seq_along(dp), dp), size=size, color="lightgray")
                                                                 ~^~
```
[R/graph.R:223:79:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L223) *style:* **Put spaces around all infix operators.**
```r
  edges = data.frame(from=M@i + 1, to=rep(seq_along(dp), dp), size=size, color="lightgray")
                                                                             ~^~
```
[R/graph.R:224:13:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L224) *style:* **Put spaces around all infix operators.**
```r
  list(nodes=nodes, edges=edges)
           ~^~
```
[R/graph.R:224:26:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L224) *style:* **Put spaces around all infix operators.**
```r
  list(nodes=nodes, edges=edges)
                        ~^~
```
[R/graph.R:247:24:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L247) *style:* **Put spaces around all infix operators.**
```r
  nodes = data.frame(id=1:igraph::vcount(ig))
                      ~^~
```
[R/graph.R:248:63:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L248) *style:* **Put spaces around all infix operators.**
```r
  vattr = data.frame(igraph::vertex_attr(ig), stringsAsFactors=FALSE)
                                                             ~^~
```
[R/graph.R:249:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L249) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(vattr) > 0 && nrow(vattr) == nrow(nodes)) nodes = cbind(nodes, vattr)
    ^
```
[R/graph.R:253:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L253) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!is.numeric(E))
    ^
```
[R/graph.R:255:7:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L255) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(is.null(nodes$label)) stop("can't determine edge list")
      ^
```
[R/graph.R:260:26:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L260) *style:* **Put spaces around all infix operators.**
```r
  edges = data.frame(from=E[,1], to=E[,2], stringAsFactors=FALSE)
                        ~^~
```
[R/graph.R:260:30:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L260) *style:* **Commas should always have a space after.**
```r
  edges = data.frame(from=E[,1], to=E[,2], stringAsFactors=FALSE)
                             ^
```
[R/graph.R:260:36:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L260) *style:* **Put spaces around all infix operators.**
```r
  edges = data.frame(from=E[,1], to=E[,2], stringAsFactors=FALSE)
                                  ~^~
```
[R/graph.R:260:40:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L260) *style:* **Commas should always have a space after.**
```r
  edges = data.frame(from=E[,1], to=E[,2], stringAsFactors=FALSE)
                                       ^
```
[R/graph.R:260:59:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L260) *style:* **Put spaces around all infix operators.**
```r
  edges = data.frame(from=E[,1], to=E[,2], stringAsFactors=FALSE)
                                                         ~^~
```
[R/graph.R:261:61:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L261) *style:* **Put spaces around all infix operators.**
```r
  eattr = data.frame(igraph::edge_attr(ig), stringsAsFactors=FALSE)
                                                           ~^~
```
[R/graph.R:262:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L262) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(eattr) > 0 && nrow(eattr) == nrow(edges)) edges = cbind(edges, eattr)
    ^
```
[R/graph.R:267:13:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L267) *style:* **Put spaces around all infix operators.**
```r
  list(edges=edges, nodes=nodes)
           ~^~
```
[R/graph.R:267:26:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/graph.R#L267) *style:* **Put spaces around all infix operators.**
```r
  list(edges=edges, nodes=nodes)
                        ~^~
```
[R/scatterplot.R:148:19:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L148) *style:* **Commas should always have a space after.**
```r
  num.ticks = c(6,6,6),
                  ^
```
[R/scatterplot.R:148:21:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L148) *style:* **Commas should always have a space after.**
```r
  num.ticks = c(6,6,6),
                    ^
```
[R/scatterplot.R:159:23:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L159) *style:* **Commas should always have a space after.**
```r
  renderer = c("auto","canvas","webgl"),
                      ^
```
[R/scatterplot.R:159:32:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L159) *style:* **Commas should always have a space after.**
```r
  renderer = c("auto","canvas","webgl"),
                               ^
```
[R/scatterplot.R:165:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L165) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!missing(y) && !missing(z))
    ^
```
[R/scatterplot.R:167:7:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L167) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(is.matrix(x))
      ^
```
[R/scatterplot.R:169:16:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L169) *style:* **Put spaces around all infix operators.**
```r
    x = cbind(x=x,y=y,z=z)
              ~^~
```
[R/scatterplot.R:169:19:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L169) *style:* **Commas should always have a space after.**
```r
    x = cbind(x=x,y=y,z=z)
                  ^
```
[R/scatterplot.R:169:20:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L169) *style:* **Put spaces around all infix operators.**
```r
    x = cbind(x=x,y=y,z=z)
                  ~^~
```
[R/scatterplot.R:169:23:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L169) *style:* **Commas should always have a space after.**
```r
    x = cbind(x=x,y=y,z=z)
                      ^
```
[R/scatterplot.R:169:24:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L169) *style:* **Put spaces around all infix operators.**
```r
    x = cbind(x=x,y=y,z=z)
                      ~^~
```
[R/scatterplot.R:171:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L171) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(ncol(x) != 3) stop("x must be a three column matrix")
    ^
```
[R/scatterplot.R:172:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L172) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(is.data.frame(x)) x = as.matrix(x)
    ^
```
[R/scatterplot.R:173:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L173) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!is.matrix(x)) stop("x must be a three column matrix")
    ^
```
[R/scatterplot.R:175:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L175) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(pch)) pch = NULL
    ^
```
[R/scatterplot.R:176:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L176) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(renderer) && nrow(x) > 10000)
    ^
```
[R/scatterplot.R:186:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L186) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(i) > 0)
    ^
```
[R/scatterplot.R:189:7:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L189) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(any(j))
      ^
```
[R/scatterplot.R:191:40:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L191) *style:* **Commas should always have a space after.**
```r
      color[i][j] = substr(color[i][j],1,7)
                                       ^
```
[R/scatterplot.R:191:42:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L191) *style:* **Commas should always have a space after.**
```r
      color[i][j] = substr(color[i][j],1,7)
                                         ^
```
[R/scatterplot.R:194:17:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L194) *style:* **Commas should always have a space after.**
```r
  i = grep("^#",bg)
                ^
```
[R/scatterplot.R:195:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L195) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(i) > 0)
    ^
```
[R/scatterplot.R:197:7:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L197) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(nchar(bg) > 7)
      ^
```
[R/scatterplot.R:199:22:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L199) *style:* **Commas should always have a space after.**
```r
      bg = substr(bg,1,7)
                     ^
```
[R/scatterplot.R:199:24:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L199) *style:* **Commas should always have a space after.**
```r
      bg = substr(bg,1,7)
                       ^
```
[R/scatterplot.R:205:49:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L205) *style:* **Commas should always have a space after.**
```r
  options = options[!(names(options) %in% c("x","y","z","i","j"))]
                                                ^
```
[R/scatterplot.R:205:53:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L205) *style:* **Commas should always have a space after.**
```r
  options = options[!(names(options) %in% c("x","y","z","i","j"))]
                                                    ^
```
[R/scatterplot.R:205:57:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L205) *style:* **Commas should always have a space after.**
```r
  options = options[!(names(options) %in% c("x","y","z","i","j"))]
                                                        ^
```
[R/scatterplot.R:205:61:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L205) *style:* **Commas should always have a space after.**
```r
  options = options[!(names(options) %in% c("x","y","z","i","j"))]
                                                            ^
```
[R/scatterplot.R:207:18:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L207) *style:* **Commas should always have a space after.**
```r
  i = grep("\\.",names(options))
                 ^
```
[R/scatterplot.R:208:5:](https://github.com/bwlewis/rthreejs/blob/652b933790b7a80c4e351aa770ffad3461a38a40/R/scatterplot.R#L208) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(i) > 0) names(options)[i] = gsub("\\.", "", names(options)[i])
    ^
```


Kommentar


Flash


@fivethousand You're correct. I'll file a PR soon to fix this.


Next time everyone - when making a change of indent / format / mass rename split it to a unique commit without code changes. It's impossible to see code changes this way


Salut,

I had to do it if I wanted it do be displayed straight on my figures. I never took the time (because of reasons) to investigate why.


Hi Gabor,

We have investigated your code and found a small issue with it, please take a look at the current implementation. There are some errors in reference RDC algorithm implemented in C - just to let you know.

Thanks,
Igor


**Nitpick - Code Quality**
Instead of this, you can return `routes.empty?` directly. It returns `true` or `false` which will eventually be evaluated by an `if` statement.


You mean with a hash function over a random number generator? It would work too. Note that spdy/http2 and transports like TCP, have the stream Id generation as part of the spec -> https://www.chromium.org/spdy/spdy-protocol/spdy-protocol-draft3-1#TOC-2.3.2-Stream-creation

We can make libp2p-multiplex generate random id and ignore that option on the constructor. However, It will still be required for muxer like SPDY.


i agree so much with this. its not that we need a new name. it should simply be split into getBestTreasureMove()
inside of there we should decide if we go to attack or simply get treasure.

will talk with the team about this


Maybe. The spec suggests we use it to help optimize what type of token were
looking up to revoke not that it must exclusively be that thing.
On Fri, Mar 18, 2016 at 1:31 AM Marco Otte-Witte <notifications@github.com>
wrote:

> I assume we shouldn't require it to be present but we would probably still
> want to respond with an error if it's anything other than 'access_token'
> as that would definitely not be supported by this engine.
>
> —
> You are receiving this because you commented.
> Reply to this email directly or view it on GitHub
> <https://github.com/simplabs/rails_api_auth/commit/394e24c475c9e65d25f1d4bfce8c54754dc552af#commitcomment-16758805>
>


@jdubois does this solve the issue of registry not starting soon enough for gateway and microservices to connect to it?

cc @PierreBesson @pascalgrimaud


建議 expected 直接給結果值即可，因為測試案例不管 how, 只管 what


这是第二次添加文字到cici项目


Попробуй табуляцию "\t", это наверное правильней


iml文件是可以不提交的吧？as自动生成的文件。


this is breaking some travis builds now :-\
https://travis-ci.org/opencontainers/specs/jobs/116826264


I don't think this should be here...


很標準的作法唷，不過不需要開成 protected, 直接開成 private 應該就可以了。


Damn, something just occurred to me.  All this is going to break when we do upgrade testing, since the docker versions involved will span this exit-code change :S  I think maybe just extract the PASS/FAIL words from the obviously negative tests, then the exit code can be examined in context of the docker version.  The only exception is the ``negativeusage`` test, where interpretation/config style probably needs updating.  The alternative is we change the docker-autotest version mid-test and/or avoid running any tests that are sensitive to exit-codes (as much as I dislike the idea).


It does, yes


@webadict Would like to hear your opinion about this commit. Do you see any reason why destroyedWeapon is still needed? I think it was introduced because of wrong orders of death resolves, but now I don't see any reason to keep it.


OK edit... reason for it to be misstaken... It IS real xD. although it is revoked and will nolonger work and thus I changed it to 123. (Alot of misstakes this day)


方法該開 private 就該開 private, 再還用不到的時候，甚至連 protected 都不太需要先開。

這個 commit 很多 protected 跟 public 都不是必要的，因為測試案例都用不到它。


This leads to a compilation error:

`CS0176: Member 'string.Format(string, params object[])' cannot be accessed with an instance reference; qualify it with a type name instead
`


It should probably say many-sorted first-order theory without strong quantifiers, i.e. the class of formulas you can reasonably pass to a first-order prover.  I didn't spend much though on the name though, if you have a better one I'll happily rename it.


Ahh, okay, this way is going to give a much more helpful debug message.  Yeah, maybe this way is better, do we need a ``failif_eq()`` also? It's probably not used much though.


@AlbertoMonteiro is possible to give me access to NuGet and / or even better to AppVeyor :)


not-equals is a common theme; == isn't so much, but it's not important. Ah, I see you got it (the important part of failif_ne).


Can we remove the check from this dstat header also: https://github.com/dagwieers/dstat/blob/master/dstat#L31

I'm thinking we can remove lines 31 - 65 now? Those are pretty ancient python versions.


yea, i thought about doing that.
line 88-90 are new


Is this restriction enforced somehow aside from the fact that you pass the formulas to `Escargot`?


@trotzig I wanted to get this out ASAP, but please feel free to leave any comments


NETWORK_PROTOCOL ?


Some of this morning's effort has been working with DockerVersion, adding `supports_distinct_exit_codes()`, and changing expected exit code `125` to `1` if false. Does that address your concern?


`kobesxl`


The following doc(s) have been deployed to the [dustinlebla](http://dustinlebla-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/unsupported-modules-plugins](http://dustinlebla-static-docs.pantheonsite.io/docs/unsupported-modules-plugins)


Komentarin dong cc: @haryoaw @aulch @kevinega @pflarasati


seems that _mm_popcnt_u64 is only available if the processor is supported SSE4, while __popcnt64 must be implemented for all intrinsic support.
https://msdn.microsoft.com/en-us/library/bb531475(v=vs.120).aspx


Hey @sfackler,

Glad to see this show up so quickly! I stared at the `AtomicReference` implementation for a while, and it looks solid to me. I'm wondering though if the `0` value state is really necessary. `get` could be implemented with a `load` and `transmute`, and `set` could be implemented with a `transmute` and `swap`. Is there something about storing the Arc that requires a spinlock as implemented here?


TeamCity NEventStore :: MongoDB :: Build [Build 6.0.0-experimental-checkpointcache.26](http://build.prxm.it:8813/viewLog.html?buildId=3417&buildTypeId=nes_mongo_build&guest=1) outcome was **FAILURE**
Summary: Error running GitVersion Build time: 00:01:52


Another possibility, since the CI-string-puller likely needs to be involved with swapping docker versions (and dependencies), it could also go through a list of test configs and flip 1 -> 0 or 0 -> 1.  This is probably easier than checking the docker version in so many tests.  The challenge there would be keeping the list updated as new tests are added.  Though we could rely on test failures to show us, I'd prefer a more hands-off approach.  Maybe we add "magic" configuration value/flag/comment to afflicted tests, not for test-use but as a search/replace token for the exit-code-config manipulator?


Well, it is a breaking change to rename Array::empty() to Array::isEmpty().
Also, i suspect that using empty() played a role in the Array class being STL friendly, so perhaps it is a good idea to have both method names


Actually, no.


What I dislike about PASS/FAIL is the complicated logic each time it's used: if/else with a check for PASS/FAIL/anything-else, and code duplication with `OutputGood` and `failf`. It's also binary, whereas using an exit code will let us use 0, 1, 125, 126, 127, etc. I see your point about human readability, but don't have any ideas right now on how to address it. I'll give it more thought, thanks.


고생하셨습니다. TGIF~


In my opinion separation of `SerializationFramework` from `UdashRPCFramework` makes this code easier to understand. We may fix `RawValue` in `UdashRPCFramework` to `String` and then remove `stringToRaw` and `rawToString` methods, but it will forbid custom serialization methods usage.

I think that custom serialization might be useful. I can imagine some possibilities of `UdashRPCFramework` reuse, where we might want to use other types of serialization. For example a WebService wrapper based on Udash RPC for frontend applications.

In case of any changes in the commons library which will broke backwards compatibility we can support two branches of Udash RPC - with and without updated commons library - for some time.


No it's solved because we now use a new configuration in bootstrap-prod.yml :-)
And it works really well!!!


That is unlucky:(
Does it mean that we are not able to do anything relevant unless the vendor decides to expose more details?


I am completely lost. What is this flipping? Where does any 1 need to flip to 0 or vice-versa?


Thanks for the cleanup. You write some of the most understandable code I've seen, and I'm learning a lot from you!


Do you have trouble running the code? If yes, which CPU do you have?


assertNotEquals is from Junit 4.12. Shouldn't we update ivy.xml too?


uh, yepp, this looks like rebase issue :)


* attribute
* attribute
* attribute
* attribute
* attribute
* attribute
* attribute
* attribute
* attribute
* attribute
* attribute
* attribute
* attribute
* attribute
* attribute
* attribute
* attribute
* attribute

*given*


Okay, gave it a quick look through, shared some ideas (all big-picture stuff).  In general seems headed in the right direction.  Code and logic (as per usual) changes are excellent, and will make debugging problems a lot easier.  "66 additions and 61 deletions."  don't forget to be lazy*

*joking of course, please be as lazy as you like, your code is excellent.


고생하셨습니다~


Ho do I run tests only in eap64 submodule?
I used to run mvn install -Peap64 .... Now it's under a subdir it doesn't work anymore...

Tried to use -Ptestsuite/eap/eap64 and it fails:
The requested profile "testsuite/eap/eap64" could not be activated because it does not exist.


The following doc(s) have been deployed to the [ttrowellde](http://ttrowellde-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/content-delivery-network](http://ttrowellde-static-docs.pantheonsite.io/docs/content-delivery-network)


caracola


Really cool stuff. If I understand it correctly, a `BackgroundTheory` is an object that decides, by whatever mechanism, which `TheoryAxioms` are valid and hence admissible in the current context. Is that about right?


This is an improvement, though I wonder if we should void out the provided ID if it doesn't exist in the DB.


Err, this might be a bad idea, but you can test it like this:

Play a Death's Bite. Summon a Tournament Spectator (or whatever it's called. The 2/1 with Taunt.) Then play a King's Defender.

If the King's Defender gets 3/3, then everything works. If it only gets 3/2, then the Battlecry did not go off before the deathrattle of the previous weapon, which is the real issue. Battlecries always happen before processing deaths, including weapons, and this was added in case any issues with Deathrattles and previous weapon searching (I wasn't gonna take any chances.)

I guess also test it with something like Brann Bronzebeard and Blingtron, but that's just to make sure the game doesn't crash.


It's not a good idea to use "vertical-align: middle" because you may need another vertical align. Fontawesome does not specify it and i think there you should use similar styles. This problem should be fixed by rebuilding font files with additional vertical spaces inside of font.


weird it is so complex to get a correct timing function.
I'd say all needed should be to run these lines at each start of an update cycle:
{
    updateTimeNow = Planetarium.GetUniversalTime(); // this serves to fix the current time, as Planetarium.GetUniversalTime will likely return different values if called multiple times within the loop
    deltaTime = updateTimeNow - updateTimeLast; // deltaTime is what we need
    updateTimeLast = updateTimeNow; // and here we keep the value from this cycle, for use in the next one
}
// deltaTime (dT in the KWS simulation) is relative to time elapsed in game; GetUniversalTime() already returns time in game, therefore I can't see a reason to deal with the TimeWarp rate to geto dT


I'm not sure this is necessary. If the blob's path changes, its sha will change. Or it should anyway, but maybe I'm wrong about that?


Okay, this is my last comment on this for today, promise.

Here is my counter proposal: https://github.com/git-for-windows/build-extra/compare/master...dscho:fix-msi


> I've changed the Configurable parent class in such a way that it should complain if you have a kwargs that is not a property of the class, as it makes the dump easier (detecting what has changed), or better, more general since all attributes are treated the same.

Yes, I see this, I was just wondering if there a reason `cmssw_config -> pset` was forced rather than `pset -> cmssw_config`. But I see now that it was just chosen to be in line with the rest of CMS, which is a good reason. I agree with it, it's just a little sad because cmssw_config is a slightly more descriptive.


I did not meet any trouble.
I was just wondering if there is difference between the various implementation.
In mine Hamming distance implementation I have done the following in order to support 32/64 bits compilation


下次記得不需要再新建立 console project 了，用測試專案就可以很完整的搞定


fixed


測試案例是空的，上面的 class 跟 100 是怎麼出現的？

記得要先寫測試案例啊....而且要改 test method 名字


Can you remove relative paths ?


通常 _field 是用來命名 field 的習慣 （在C＃的話啦），區域變數不這樣搞的。


Same here


Ah, I see that the weapon destruction happens first. That's incorrect, it happens after the Battlecry of the new weapon. If you can find a way to feed it to the checkForDeadEntities() check, then you don't have to have the destroyed weapon, but I took the easy way.


yes, commit b4e7e875a7243935389913d0ed3cf380d18d2647


想太多太多太多太多的一步...你現在的需求只有兩本書，期望 190，真要做的應該只是：
書的本數x書的單價x折扣，這麼單純而已。

而且只知道 0.95 的折扣，根本不該出現 3,4,5 的部分唷。


> Where does any 1 need to flip to 0

Err, sorry, I'm the one that's confused.  I meant to type ``1 -> 125 -> 1``.

> adding ``supports_distinct_exit_codes()``

That will be a useful feature to have, but I'm questioning how much we actually need to add it into every test.  My thinking is, we could just the logic above the autotest-execution level that alters affected test's configuration.  That may be easier (more lazy) than trying to add (basically) the same logic to so many tests.  Just a thought - I've been taught the 'lazy' way is often the best.


I think VIRTUAL_PORT is not necessary ?


Everything in this `else` is double code. We should remove the else and outdent the three `if`-`else` clauses.


I missed this line.  See my new PR.


Maybe we have different expectations on what is a useful caption. The captions need to have a meaning only when read in context of the log entry comment. Also, as there is no separate image comment field at OC sites, they are used for - often funny - comments on the image. I think that all this gives a better user experince when reading log entries than images titled "Image".


> but don't have any ideas right now on how to address it.

Don't worry too much about it, it's a very minor concern relative to the importance of proper exit-code checking.  More humans will be reading the test results than the test configuration :smile:


第六個和第七個測試案例，加入時應該要紅燈才對。

如果是綠燈，代表前面的 production  code 已經把後面要的功能偷做完了。


one difference is that now each caller of `Write(LogKind logKind, string text)` has to ensure they use `CultureInfo.InvariantCulture`, rather than it being handled in one place.

This isn't a reason to not do this change, just something to think about?


Hi, Alec.
Why not make pull request? I found your solution very cool.

Also on this week I deeply dive into the code of graffity, and found it very DRY and pretty. Also found your modifications, and very glad to see solution for customQueries. On the next week I'll try to rewrite our codebase on graffity-mongoose.

Also I found some performance lack on `connections` (e.g. make query for `count` if it not requested by schema). And I'll try to fix it in the near future.

BTW, can you share your opinion/experience/problems with me of using graffity with our project? Does it cover all your needs?


nit: I'd prefer the single exception thrown, something like:
```java
wildcardString = StringUtils.clean(wildcardString); // returns populated string or null
if (wildcardString == null) {...}
```

One caveat because the Shiro StringUtils.clean, is not the same as commons StringUtils.clean (but we do not carry commons-lang as a dep)


TeamCity NEventStore :: MongoDB :: Build [Build 6.0.0-experimental-checkpointcache.27](http://build.prxm.it:8813/viewLog.html?buildId=3418&buildTypeId=nes_mongo_build&guest=1) outcome was **FAILURE**
Summary: Error running GitVersion Build time: 00:01:46


TeamCity NEventStore :: MongoDB :: Build [Build 6.0.0-experimental-checkpointcache.27](http://build.prxm.it:8813/viewLog.html?buildId=3418&buildTypeId=nes_mongo_build&guest=1) outcome was **FAILURE**
Summary: Error running GitVersion Build time: 00:01:47


I think it would make sense to do that as well.


Isn't this the same as 'if killActor and tgt not in self._internalAddresses:` ?


mraa_io_obj is freed at line 370


This now forces the caller to either use `String.Format(..)` or preferably `$".."`

Not a massive problem, just something to think about.


Ah! Ok. And re: "same logic to so many tests" -- grin, that's where `dockertest.output.mustfail()` is coming in handy (uncommitted WIP)!


When does this get reset to its original object? (eg. `self.forbidden = tempObject`). I can't see it.
(a context manager or try/finally might be helpful in case an unexpected error skips the resetting)


Thanks!


@m-mcgowan Could you please confirm that it is not an ABI breaking change to rename a function used in dynalib?


Yep, it's all good. The names are not significant. The don't break binary compatibility, only source compatibility. If someone were using these functions their code would no longer compile. Since these are internal functions, and not part of our public API, I'm happy with renaming them.


This badge is missing (request returns a file not found error).


test


If you browse throug the [newest 48 log images](https://www.opencaching.de/newlogpics.php) submitted at OCDE, you will see
* no ramdom strings
* one caption which contains the cache code
* one caption which looks like an image file name
* 45 captions that either describe the image, explain the image, comment the image or say something about the circumstances of taking the photo; many of them are only understandable in context of the log comment, which is fine.


Grz3s Please come see us on IRC today. I need to chat with you please.


@Ulexus Aha! Good catch.


I think this has the same effect but without the spinlock.

```rust
impl<T> AtomicReference<T> {
    pub fn new(t: Arc<T>) -> AtomicReference<T> {
        unsafe { AtomicReference(AtomicUsize::new(mem::transmute(t)), PhantomData) }
    }

    pub fn set(&self, t: Arc<T>) -> Arc<T> {
        unsafe {mem::transmute(self.0.swap(mem::transmute(t), Ordering::SeqCst)) }
    }

    pub fn get(&self) -> Arc<T> {
        let raw = self.0.load(Ordering::Acquire);
        unsafe { (*(&raw as *const _ as *const Arc<T>)).clone() }
    }
}
```


I was seeing cases where the path would change but the sha would stay the same when using the path to manage page hierarchy. I could try to dig up an example of this.


-Peap
On Mar 18, 2016 4:31 PM, "Jonh Wendell" <notifications@github.com> wrote:

> Ho do I run tests only in eap64 submodule?
> I used to run mvn install -Peap64 .... Now it's under a subdir it doesn't
> work anymore...
>
> Tried to use -Ptestsuite/eap/eap64 and it fails:
> The requested profile "testsuite/eap/eap64" could not be activated because
> it does not exist.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
> <https://github.com/jboss-openshift/ce-testsuite/commit/fa8627a2735a9c3aa011148a1f897be35e28fb2a#commitcomment-16764345>
>


Precisely; but a `BackgroundTheory` should do even more: for example given the input `a>0, b>0, c>0, d>0 :- a+d>0` it the expected output is `TheoryAxiom(a>0, d>0 :- a+d>0)`, i.e. a somewhat minimal subsequent that is still valid.

The big keyword is *decide* though.  Everything aside from the prime proof is practically easy to check and AFAICT also theoretically decidable.  However the prime proof contains pretty heavy (in general undecidable) arithmetical reasoning: validating those axioms is a bit of a challenge, see #499.


I would like to rehabilitate `frontpage` attribute lost in this commit. It can be useful when we want to ignore `on frontpage` sections settings, e.g. when searching by categories or author:

`<txp:if_category><txp:article frontpage="" /></txp:if_category>`

Currently it outputs only the articles from `frontpage` sections on the `default` section page. There seem to be no (additional) security concern, since `article_custom` does not filter articles by frontpage anyway. If nobody minds, I will submit a patch.


CQ is missing?


To manage -> to change?


Das Commit würde eher iIntergration von Crossasia Header nennen,  falls es irgendwo gebraucht wird.


bot likes it


kaaalidMy


That would run all tests inside this directory, right?
I'm not sure we want this behavior... I'm going to work on eap70 tests, and I guess they should reside in this same dir, right?

I think we should be able to run individual tests, like eap64, eap70...


myKaleed


Trata de no dejar código comentado en tus commits. Al final de cuentas, tienes el control de versiones para saber que había antes.


Oh dear. That might be a bug that should be fixed.  I don't really know about context managers....


You are absolutely right. I checked that and it turned out, that this formatting was only used for strings and integers, not floats and doubles so it should not affect any existing feature, but could affect the future ones.

I was thinking about setting Thread.CurrentCulture = Culture.Invariant at the top of BenchmarkRunner. What do you think?


`asyncio.ensure_future` appeared in Python 3.4.4 IIRC.
`aiohttp` supports Python 3.4.1+

I recommend to use workaround like https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/helpers.py#L17-L20 :
```

"""Various helper functions"""

import asyncio
import base64
import datetime
import functools
import io
import os
import re
from urllib.parse import quote, urlencode
from collections import namedtuple
from pathlib import Path

from . import hdrs, multidict
from .errors import InvalidURL

try:
    from asyncio import ensure_future
except ImportError:
    ensure_future = asyncio.async
```


I'm not saying captions are a bad thing. I'm trying to avoid having bad and unneeded captions. And forcing users to submit caption often leads to such.

You cannot force the users to submit good captions. Some application developers may even choose to make this field optional for their users and submit their own defaults if the user doesn't provide a caption. Forcing things that are not *really* required doesn't seem a good user experience strategy.


How does this benefit the APQ8084? Isn't this meant for the MSM8994 SoCs only?


The inverse as well, another case would be playing Hogger, Doom of the whatever (New Hogger card), play a Death's Bite, then play a King's Defender, and test to make sure the King's Defender only gets 3/2. Just in case the deathrattle of the weapon goes off and the battlecry still checks the now dead minion in the last case.


Yo pondría todas estas propiedades de CSS en el `main.css`. No es necesario que las pongas con Javascript.


In ci-trap we named it CITracker -- without the underline between CI and Tracker.  Which one do you prefer?


CQ?


Shout out to Richard Bell, who had a huge hand in helping me out with this one.


i know I'm fixing now :P I'm struggling to get my head round this stuff :P


I suppose this would happen if the content remained the same when the path changed, now that I think about it. Ostensibly, the tree (in git) would point to the same blob, but at a different tree path. So that actualyl makes sense.


this function should take 'event' has an argument. You are using event.preventDefault() correctly, but I'm surprised it's not throwing an error.


`response.text()` is also a coroutine, perhaps you need a timeout for both connection/sending request time and retrieving a response body.

I suggest to use `aiohttp.Timeout` class: http://aiohttp.readthedocs.org/en/stable/client.html#timeouts


`loop.time()`


@XhmikosR What do you think about an argument?

```js
grunt.registerTask('contrib-ci', 'Normalizes appveyor and travis ci configs.', function(skipIfExists) {
  skipIfExists = skipIfExists === true
  // ... code to skip if an existing ci config is in place
});
```

Then on those projects we can do `contrib-ci:true`... unless that is too ambiguous, then maybe something like `conrib-ci:skipexisting`?


Para poder agregar el _listener_ a cada elemento y escuchar el evento _click_, guarda el elemento de jQuery en una variable, y después le asignas el _listener_.

```
movies.forEach(function(movies) {
  var movieItem = $('<div><a href="#" id="get-json-'+movies.id+'">'+movies.name+'</a></div>');
  mainWrapper.append(movieItem);

  movieItem.click(function () {
    // Get JSON code here
  });
});
```


svarioni in che senso?


111247952_Remove_QUUID-rebased (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2328 of 2397 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.12%25-yellow.svg)


`loop.create_task()` is available starting from Python 3.4.2
Please use `ensure_future()`/`async()` instead.


It is fine to use SMALLTALK_CI_HOME in a project's `.travis.yml` so this line should be left alone ...

https://travis-ci.org/dalehenrich/obex/builds/116937802#L970 is the line that confirms the cache is being used (-t arg on createStone) and https://github.com/dalehenrich/obex/blob/master/.travis.yml#L19 shows that I was using SMALLTALK_CI_HOME


I'm guessing building the ngrams was the slowest part. Also, out of curiosity, how many unique ngrams did you end up with?


`yield from c.close()` ???


Almost there. You need to extend this functionality so that it works for both blog links. You shouldn't need separate links for "read more" and "read less", rather you should be changing the text of a single link. You can use the jQuery html() method to accomplish this.


@gribozavr This and the one above it don't look like inout violations to me anymore.  Should this have stayed "sort()"?  Otherwise, we're getting an unused value warning that should be squashed.


initial commit


`ensure_future()` is better :)


right, the description is incorrect. but I don't have a "dev" branch. or I'm missing something?


prod profile for mysql and psql seems to be failing in travis

Thanks & Regards,
Deepu

On Fri, Mar 18, 2016 at 11:28 PM, Julien Dubois <notifications@github.com>
wrote:

> No it's solved because we now use a new configuration in
> bootstrap-prod.yml :-)
> And it works really well!!!
>
> —
> You are receiving this because you commented.
> Reply to this email directly or view it on GitHub
> <https://github.com/jhipster/generator-jhipster/commit/2f3e75f1a601b4c0f16858d4e174267d7f67158c#commitcomment-16764300>
>


Won't this break if the build environment has a different architecture than the docker environment?


111247952_Remove_QUUID-rebased (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


It was expecting to resolve response.uri, when response was always
apparently null (in both mobile chrome and other browsers, so I'm not
entirely sure why it only appeared in mobile chrome). It wasn't a major
issue, as it came at the end of the process, but I thought it better to
not have errors laying around.

I'm guessing I could just reinsert the resolve with no arguments to
solve both problems?

On 2016-03-18 5:44 AM, Philip Breau wrote:
>
> This now leaves the promise in an unresolved state. What was the issue
> on mobile chrome?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
> <https://github.com/bridgeit/bridgeit.io.js/commit/434a5ffa2f7fa34938dbce9e6400312d0a744b8b#commitcomment-16761523>
>


but you don't check the malloc succeeds


Fix README.md


First comment


I'm changing the self-test procedure to support caching via `$SMALLTALK_CI_HOME`. That way it's consistent :)


OK by me


Sounds good to me.


Also, this makes it quite difficult to build your own copy of this image - my team had some automation that was building our own copies of all the images we use so we're not depending on trusting foreign binaries - this change makes that automation pretty much impossible now.


> You are absolutely right. I checked that and it turned out, that this formatting was only used for strings and integers, not floats and doubles so it should not affect any existing feature, but could affect the future ones.

That's cool, you've obviously thought about it.

> I was thinking about setting Thread.CurrentCulture = Culture.Invariant at the top of BenchmarkRunner. What do you think?

The tricky thing is that is some places we'd want the current culture to be used because wherever possible people will want to see numbers in their local format i.e. `123,432.04` makes sense to me but other people would want it to be `123 423,04` (I think that's the correct way for some parts of Europe?)

In certain places we need to be explicit, for instance when we emit numbers that become C# code.

So actually, after thinking about it a bit more, it probably makes more sense to NOT explicitly set it to `Invariant`. If it needs to be, the calling code can do so. Does that sound sensible?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 19450](https://teamcity.mesosphere.io/viewLog.html?buildId=171628&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 265 Build time: 00:09:54


Why is `err` being appended here? There is no `err` value in scope at this point.


Your commit does only work for folders. The same should be done for uploads and licenses.


Ghost Dockerfile


The following doc(s) have been deployed to the [drupalizem](http://drupalizem-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/drupalize-me](http://drupalizem-static-docs.pantheonsite.io/docs/drupalize-me)
- [ocs/articles/drupalize-me-series](http://drupalizem-static-docs.pantheonsite.io/ocs/articles/drupalize-me-series)


An related commit is: https://github.com/maximilianhuber/fossology/commit/1a41092a9f51a169d38253428d81c0d45324b57d


Whats they restorecon for ?

Ie. does this change work without disabling selinux ? or does one still need to define a selinux policy or add exceptions ?


Ваш коммит говно, вы ничего не понимаете в коммитах!


ХУЙ


пизда


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 19451](https://teamcity.mesosphere.io/viewLog.html?buildId=171631&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 265 Build time: 00:09:01


How about using the newest rebar3? Then it should be enough to use this `pc` plugin like described here: https://www.rebar3.org/docs/using-available-plugins#port-compiler


Try it on the night!


Added GPLv3 license


ah...forgot this one. Thanks


I don't really agree with the solution implemented here. You are adding separators to the model in order to display a white line in the profile lists, but that is crucially a display issue. The model is intended to contain only data, and adding visibility queues to the data makes maintaining the data much more complex.

A more logical solution (of course, many solutions are possible) would be to let the view or presenter separate the profiles into the current profile, custom profiles and default profiles, and then display them in the drop-down and in the list with a faux entry in between.

I'd like to hear your thoughts about this, @fieldOfView.


This commit makes a few zk (1.4.3.4) units not render (invisible), e.g. Bantha.


i will remove this


Was there any response about this feature in PrBoom+?


Yeah, we were very busy adding both tests and tooling at the same time.  Many/most of the previously written tests were never revised to use the new tooling.  I suppose that kind of thing is typical, maybe we'll get there again some day :grinning:


加入一个常用的webshell password猜解库