@mikekap This seems to work fine for go_library's, but breaks for go_binaries since the packageName is set to "main" and not the path to the binary.  So when it recursively resolves it uses main/vendor which obviously fails.

![Imgur](http://i.imgur.com/aQipM6m.png)

Binaries are the bigger use case for vendored deps than libraries.

I am thinking that packageName should be a string and not a path, and there should be a separate Path variable used for the location of the path.  For go_libraries one will just be string representation of the other.  Fro go_binary packageName will be "main" and the Path variable (packagePath or something) will be the relative path to the actual package.  Thoughts?


Nice :) Eroarea era numele bazei de date?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18717](https://teamcity.mesosphere.io/viewLog.html?buildId=158665&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:05:04


Yes


this isn't _exactly_ right, because `.` is special in regex, so e.g.:

```
% echo "178" | grep -E 'java-8|1.8'
178
```


Let me rephrase... please provide a createTxSummary() method to adhere to the overall style.


gethobstbyname() returns just the hostname given on a lookup error. gethostbynamel() however returns FALSE on error which is not handled at all in your patch.


This is a good demonstration of letting css handle the presentation and letting your markup just be markup. Using display: block thoughtfully can save you some extraneous markup in your html. By using display:block here, you're sparing yourself a p tag or div that would clutter your markup and not add semantic value.


actually `de.randombyte.mobrepeller` is better.


No I'll remove it, its copy paste issue.


Will do


@segiddins it appears this release (beta 5) isn't actually available for download (anymore?)


No worries Gabriel. Thanks for what you've done. You're welcome to submit pull requests for what you've done. Even if they don't get committed directly they can help others patch something together while they're waiting and also inform later work when we end up getting to the feature in question :)


true, I moved the security at the beginning
https://github.com/plomino/rapido.core/commit/3d08d64f474688789a07181593b51c5e556c6b44


Do we need contentType and is_markdown?


Had same issue randomlly since this morning.
The proposed fix seems to work!


Why is getting mounted each time the component instantiates ?
When i click inbox it syncs, when i click sent it syncs.. etc..


Despite having issues centering the buttons in the header and footer, this a satisfactory assignment. Your markup and css are extremely well formatted and you're using classes, id's and nested selectors well. This week's homework should get you more comfortable with getting block level elements centered as well as when to make elements siblings versus when to make them children. Nice work.


Hi Enda,

If you need any help with MatLab...just google it. It's no bother.

Cian.


:dancers:


typo


The ring count should be synchronized by the ring count you hear in the app.


It appears that it not fixes issues of scene loading so I decided to revert back.


Hi Enda,

If you need any help with MatLAB, google is your man.

Cian.


Testing out TortoiseGit


This function fails to return a value if  it reaches the end of the body of the last `if` - i.e. when `iType == sci_tlist` and none of the checks inside that `if` cause us to return.

This is causing warnings for C++ tests and failures for C tests: https://travis-ci.org/swig/swig/jobs/114753648


@romach Replacing some messages by own is good idea, but why do you set own default message instead getting it from exception?


don't hard code the value there. we have a linphone rc  setting for that..


change not advertised in commit message


where did `d`.`letsencrypt` go???


where does this func get called?


I have a solution for this, catch me on Skype


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18719](https://teamcity.mesosphere.io/viewLog.html?buildId=158706&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:07:30


Updated :+1:


I think it's an efficiency thing. It's also highly suspect, because at first glance this code would seem to introduce an infinite loop without this check and in these situations. It doesn't, since ``addSkill()`` only adds the skill if it's unique to the list, but I think the if-check here helps communicate the intentions of the function better.


Good catch, done.


Do you have a pretrained model you can share?


TeamCity LabKey :: 16.1 Release :: Community :: CDS postgres 9.5 [Build 35](https://teamcity.labkey.org/viewLog.html?buildId=309186&buildTypeId=LabKey_161Release_Community_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 11, passed: 41 Build time: 01:25:18
### Failed tests
```
org.labkey.test.tests.cds.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.cds.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.cds.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.cds.CDSVisualizationTest.verifyPlotToolTips: <no details avaliable>

org.labkey.test.tests.cds.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.cds.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.cds.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.cds.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.cds.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.cds.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.cds.CDSVisualizationTest.verifyTimeAxisFilter: <no details avaliable>

##### there are 1 more failed tests, see build details
```


(sorry this should be 6a done)


@littledan That is correct.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18718](https://teamcity.mesosphere.io/viewLog.html?buildId=158693&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:11:05


I might revert base to an `$.OR()` for better diagrams.


Does this rebuild everything?  If test/run_tests.sh already did that, should we just reuse the result?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18720](https://teamcity.mesosphere.io/viewLog.html?buildId=158711&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:04:47


Can't tell what this does / why it seems reversed from what was there before.


Ah, that's a good point. I was caring more about consistently naming the backend JSON objects, but it definitely shouldn't sound like a function. I reverted this change everywhere (it's now ``backendChange...`` instead of ``changeBackend...``).


Thanks, but I feel rather bad that I have not done as much recently as I was hoping. It is uncommented, rather messy and buggy. It was actually originally written just for my use to determine what encounters would be a challenge to a party of munchkins —strangest thing is that I thought that the DM guide was woefully conservative with its CR and stuff, but I think WotC did not spend too much time doing maths and simulations.


It's still listed on rubygems, https://rubygems.org/gems/cocoapods


Book 1 folder


This should fix the test "presents no message explaining that the search has been reduced for the second time".


Reading the code I think that uniqueId as we have it now could do that job, but it needs to be the real physical Id again when playing such content. As 03aa2441 is quite intrusive I don't know exactly at which point the "real pid" gets lost.


Oops, no need to fetch the devices and ports.
Change the ->get() to ->count() and remove the count in the blade.


I'll leave it as-is. ``change`` is also a noun, afterall. I think it reads fine, too.


[SETUP] Developer sets up QA environment and codeship


What was the motivation here?


Based off the v1.0.0-blaze branch of the underlying boilerplate (so react commits are sat on different branch). Development will continue on master using blaze as the primary view engine. (Though might add react back in later if needed).


Why


Done.


Its work, nice)


test version


sorry, its a rudiment from developing.
setupReporter is called during the setUp function which is handled by `testResultHandler`, so the setupReporter event has no place here. I'll remove it right now!


@hannesmuehleisen same prob on windows possibly


Either is valid.
avoiding the redundant rules (single CONSUME)
is the important part.


@hannesmuehleisen pums & censo also having weird problems


Thank you for your detailed feedback @thelastbaldwin


Sgtm, done.


I think this should be a `DUNE_THROW`, with a simple assert we would not get an error in release builds.


I would suggest that this message end with a colon.  Also, I hope that this last message will be shown whether or not the user has any taps at all, and whether or not the taps are git repos, and that there not be a "heading-less" emission of "Already up-to-date" in any of those same circumstances.


@hannesmuehleisen acs has mysteriously crashed on windows between the -setup.R and the -test.R

perhaps this commit will fix..


@gregmacfarlane This section is in a gray area between style and teaching people how to use complex arrays.  I'd like to get your take on whether it stays in this document, or needs to be moved to a separate one.


Good point


Also the spaces are replaced with tabs.


Kommer litt an på :)
<https://hamberg.no/erlend/posts/2015-02-23-git-history.html>

For en endring som denne ville jeg brukt `rebase`.


Hai @Robotia !
Are there any news about items dupe/loss when teleporting? Hope to see dynamic view distance soon ^^


Why don't you handle errors appropriately?
http://mit.spbau.ru/sewiki/index.php/Linux_kernel_2016#.D0.9E.D0.B1.D1.80.D0.B0.D0.B1.D0.BE.D1.82.D0.BA.D0.B0_.D0.BE.D1.88.D0.B8.D0.B1.D0.BE.D0.BA


yeah if run_tests.sh does it, then we can reuse it.


Where have you found this 255 const?


`/home/keybase` now gets a default `keybase` binary packaged into the `Dockerfile`. I want any binaries located in `/opt/scripts` to take precedence over that one.


I think it stays in this doc, but maybe the negative examples aren't helpful? I think knowing that the options arrays exist is powerful enough.


@jpfr: This fix solves #554 for me... is this correct?


Getting an error in console: Uncaught TypeError: hide_mes.forEach is not a function


Hmm, so eslint can't see components inside JSX... interesting.


fixes https://github.com/mspnp/azure-content-pr/issues/163


yes, maybe it's a (temporary) glitch on github? Since I did just see it again (together with beta 4) listed again in the release section - however, the App download link doesn't seem to work for me. What's funny, I was just able to download the beta 3 app (CocoaPods.app-1.0.0.beta.3.tar.bz2), but that link now disappeared from the release list.


LqGTM


excessive goto usage here.
    if (!entry) {
        return NULL;
    }
is enough here.


Oops... this will panic if/when we write to the closed channel.  New version forthcoming.


@savala I sent a pull request to your repo (if you hadn't seen it). I added some more emoji's and fixed the one word commit. Should be working now if you wanted to pull and test, just run `git fetch https://github.com/savala/git-feeling pull/1/head:feature/addednew && git checkout feature/addednew` then test the message after making a small change or something.


@bradking Thank you!


@typiconman This is another round of error analysis (last one?).

This time file to review is significantly larger (I had a bug in error report generation that made it emit errors from training dictionary, not the test one - my apologies).

This error report is from a pattern set generated from the updated words.tex (so the previous review was not in vain!).

Current performance is:
missed hyphens: 9%
false hyphens: 4%


excessive too


Delete this !


Passes the commit.


fix the method that has comments


Explicitly return nil


Compare against nil


Whats bumming you out? Are leading slashes frowned no good?


This commit is not actually buggy. Albert fixed the issues when he refactored it out.


Тут вроде `Path::normalize` не обзятательно


Is this patch a temporary patch for vs2012? It effectively breaks building maya plugin on all non-windows platforms.


Тут наверное лучше через `Asset::getInstance()->addString();`


Logic look inverted here. Isn't this is more straightforward?

    stack_entry_t *entry = NULL;
    if (stack_empty(stack)) {
        return NULL;
    }
    entry = list_entry(stack->next, stack_entry_t, lh);
    list_del(STACK_ENTRY_LIST_HEAD(entry));
    return entry;


Works for me.  I have removed the "bad" example. (9608ef6b77052d8a7524c2b90b2a85549c8666e1)


2129_radiance_server_perf (rpg777) - Win64-Windows-7-VisualStudio-12: OK (2359 of 2397 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.41%25-yellow.svg)


Please don't comment on commits -- it creates noise for everyone.


this could also be
```js
people.map(person => ({
  ...person,
  isModerator: includes(moderatorIds, person.id)
})
```


proč?


Do you need to set both directions of flow control?
````
 flow = SerialPort.FLOWCONTROL_RTSCTS_IN | SerialPort.FLOWCONTROL_RTSCTS_OUT;
````
The "IN" one (from outside to JMRI) can be problematic.  It's needed if (1) the hardware really can overrun JMRI and (2) the hardware supports it, but it's problematic because it relies on a bunch of things being right in between.  As an option, it can be turned off, but then you're also turning off the OUT form, JMRI -> hardware, which is probably needed more.


maybe i'm going to extremes here but even if-clauses have started to seem like code smells :)


Issue5276 (wfbuhl) - i386-Windows-7-VisualStudio-12: OK (2130 of 2138 tests passed, 2 test warnings)

 * 10 tests had: EIO diffs.
 * 7 tests had: ESO big diffs.
 * 4 tests had: Table small diffs.
 * 3 tests had: ESO small diffs.
 * 2 tests had: MTR big diffs.
 * 4 tests had: Table big diffs.
 * 1 test had: MTR small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.63%25-yellow.svg)


I'm also curious - some on the committee tend to push back rather hard at having things be nonconfigurable. It also will prevent transpilers from correcting native behavior (without complete replacement).


Is `hide_mes` definitely an array?


I'm pretty sure that this was needed. I've still got the hardware set-up so will confirm.


this was a poor decision @aaronr


`use`, just like `namespace` (and string class names) always accepts a fully qualified name, there's no point in adding a leading `\`. It's an accident of history that this is allowed at all. For some reason people want to add extra slashes to everything instead of using the canonical names. Don't mind me, just being grumpy about bad design decisions on PHPs behalf...


Sånn *eeegentlig* burde ting som ikke er prosjekt-spesifikke, som `.idea` og `*.iml`, puttes i en global ignore-fil. :wink:

    git config --global core.excludesfile '~/.gitignore'
    echo '*.iml' >> ~/.gitignore


It's a collection


OK, it functions fine with just OUT - I'll push an update to the PR.

@bobjacobsen thanks for spotting that - serves me right for doing this stuff late at night...


I am not seeing real improvements on the benchmarks. I think the retain/release pairs were removed in (most) case as a result of KnownSafety.

I will write a microbenchmark to demostrate the potential of this optimization.


Terminator is back! :laughing:


Very neat solution by the way :-)


@DidierLoiseau Jack wrote me that he's a little busy with shipping out all the Massdrop right now and would like for me to wait until later to share my work.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18721](https://teamcity.mesosphere.io/viewLog.html?buildId=158726&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:05:45


Whats the default m_skew value, if its all `zeros` then final model view matrix will be wrong with `(m_view * m_skew)`.


@vadimyer what was the problem with this?


Issue5276 (wfbuhl) - Win64-Windows-7-VisualStudio-12: OK (2130 of 2138 tests passed, 2 test warnings)

 * 10 tests had: EIO diffs.
 * 7 tests had: ESO big diffs.
 * 4 tests had: Table small diffs.
 * 3 tests had: ESO small diffs.
 * 2 tests had: MTR big diffs.
 * 4 tests had: Table big diffs.
 * 1 test had: MTR small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.63%25-yellow.svg)


Don't we want to insist that geofield is specified and furthermore be of that type?  The fallback below looks kludge'y.


I was curious about that. I've been using a leading slash to make it obvious that its not relative to the namespace.


By the way, if this is ready to go, and you want me to merge it back into the main codebase, just submit a pull request!


Maybe just take the appropriate ShapeWriter to begin with instead of all of them?


use logger


Currently:

```crystal
@@drivers :: Hash(String, Driver.class)
```

Proposal:

```crystal
@@drivers :: Hash(String, DriverFactory)
```

Where DriverFactory has an abstract method to build a driver out of connection.


Hmmmm. You remove proc_entry from stack. But you don't delete it and don't kfree its exe_name.
So you have kernel memory leak here.


The vmos path might cause some confusion. To get the Operating Systems, previous devs definied the path as "oss". If we use "vmos", which is a synonym for "oss", it might get confusing for someone working with these paths. I'd suggest adding a bit more description to the path, such as vmosvalidation, vmoscheck, or something meaningful that gives an intuitive idea of which controller it is calling.

Minor edit, but it might help with clarity.


This method should be declared _after_ it's caller.


i would add a boolean, and replace the while condition which it...a thread ca be interrupted randomly


This loop doesn't free, delete kernel memory because on non-error path stack is empty on this point.


Any ideas? I believe start/end times were pulled from Job prior to the rewrite of Job which broke these values


[R/trace_calls.R:136:39:](https://github.com/jimhester/covr/blob/f6d9d1c52442ea8e22367fd7bb1e325a63b41375/R/trace_calls.R#L136) *style:* **Commas should always have a space after.**
```r
  pd_child <- pd[pd$parent == expr_id,]
                                      ^
```


it's nicer!


Also added a time stamp string inthe data sent TO the kafka server.


Why add "Program" here?


`arrayEach` unless tasks should be an object


Any reason for doing this through a filter instead of inline?


This commit kicked off a test run, which came back :red_circle: RED.

Failures:
* netsim_lobby.feature on 8 browsers (seems legit)
* disableToolboxMaze on IE9Win7 (possible flakiness)
* hourOfCodeFinish on IE9Win7 (possible flakiness)


В Loc::loadMessages() не обязательно, а тут под виндой иначе не будет правильно работать.


Which ones?


This now says getResponse().getResponse()... are you sure that is correct?


Related to the comment below, it might be better to rename OSMapping to something else.

The reason behind this is that there is already some mapping done between VmOs objects with plans, for instance, to determine the plan configurations. This is another mapping that is being done, but with Azure Regions, so it might be wise to make this distinction.


sorry about the mess I made here!


just `params.concat(newTask)`, concat creates a new list


I think the code would be clearer if it's named something like "fieldVal"


FYI, this causes rails db:migrate to fail, with the following stack traceback:

```
rails db:migrate
rails aborted!
LoadError: cannot load such file -- action_view/tasks/dependencies.rake
/home/rubys/git/rails/actionview/lib/action_view/railtie.rb:62:in `load'
/home/rubys/git/rails/actionview/lib/action_view/railtie.rb:62:in `block in <class:Railtie>'
/home/rubys/git/rails/railties/lib/rails/railtie.rb:240:in `instance_exec'
/home/rubys/git/rails/railties/lib/rails/railtie.rb:240:in `block in run_tasks_blocks'
/home/rubys/git/rails/railties/lib/rails/railtie.rb:248:in `each'
/home/rubys/git/rails/railties/lib/rails/railtie.rb:248:in `each_registered_block'
/home/rubys/git/rails/railties/lib/rails/railtie.rb:240:in `run_tasks_blocks'
/home/rubys/git/rails/railties/lib/rails/application.rb:443:in `block in run_tasks_blocks'
/home/rubys/git/rails/railties/lib/rails/engine/railties.rb:13:in `each'
/home/rubys/git/rails/railties/lib/rails/engine/railties.rb:13:in `each'
/home/rubys/git/rails/railties/lib/rails/application.rb:443:in `run_tasks_blocks'
/home/rubys/git/rails/railties/lib/rails/engine.rb:457:in `load_tasks'
/home/rubys/git/awdwr/edition4/work/depot/Rakefile:6:in `<top (required)>'
/home/rubys/git/rails/railties/lib/rails/commands/rake_proxy.rb:12:in `block in run_rake_task'
/home/rubys/git/rails/railties/lib/rails/commands/rake_proxy.rb:10:in `run_rake_task'
/home/rubys/git/rails/railties/lib/rails/commands/commands_tasks.rb:51:in `run_command!'
/home/rubys/git/rails/railties/lib/rails/command.rb:20:in `run'
/home/rubys/git/rails/railties/lib/rails/commands.rb:18:in `<top (required)>'
bin/rails:4:in `require'
bin/rails:4:in `<main>'
(See full trace by running task with --trace)
```


А тут точно работает? Предыдущий не будет перехватывать пути?


Ага, надежнее будет


should't be the ] also get removed then?


The code in question is as follows:

```ruby
    rake_tasks do |app|
      unless app.config.api_only
        load "action_view/tasks/dependencies.rake"
      end
    end
```


`glm::mat4` defaults to identity matrix


Thanks. But I think it was supposed to be https://github.com/rails/rails/pull/24125


driver.manage().timeouts().implicitlyWait(10, TimeUnit.SECONDS);
	Store Flight=new Store(driver);
    Flight.bookFlights();
    Flight.searchFlight();
    Flight.clickRoundTrip();
    Flight.typeFlying_to("New York");
    Flight.typeFlying_from("SFO");
    Select dropdown_Adults= new Select(driver.findElement(By.id("flight-adults")));
    dropdown_Adults.selectByVisibleText("2");
    try{
    	Select dropdown_child=new Select(driver.findElement(By.id("flight-children")));
        dropdown_child.selectByVisibleText("2");
    }catch(Exception e)
    {
    	System.out.println("Could not find dropdown child");
    }

    Select child_1_age=new Select(driver.findElement(By.id("flight-age-select-1")));
    child_1_age.selectByVisibleText("11");

    Select child_2_age=new Select(driver.findElement(By.id("flight-age-select-2")));
    child_2_age.selectByVisibleText("7");

   try{
	   Thread.sleep(5000);
   }catch(Exception e)
   {
	   System.out.println("Error message");
   }
    driver.close();

}
}


problem?


oops, I'll move the comments.


This update looks fantastic, just some minor comments on nomenclature above to facilitate clarity.

I'd also suggest applying the same fix for the VM Size objects, since the config needs to validate them against the region to make sure they are available.

This can be done separately if you wish, but it is definitely needed.


looks good, I am testing now.


Or is it ok if we consider it just a run-time error at the object language's level, just like applying a number?


I don't like the ``` if backend = uia``` condition. To streamline the code I would turn the ```children``` property into a class method with the criteria arguments and just drop the ```children_with_criteria````. Obviously, the same should be done for descendants


Unfortunately, the compiled C++ code is still not building on MAC OS X. It is only the interpreter which builds now.


Why not bind the listener to the correct target instead of the whole document?


Yuck... can't we just do a big assertEquals(expectedString,gotString) ?  It's way simpler to look at and understand.  Granted when there's a failure it's not as obvious exactly what went wrong but I value readability over that.


Yup, saw the pull request. I'll test it out hopefully sometime tonight!


ok - will do.


Ok - will do.


That is so "me-like" that I am almost sure that I did that (although I know that I did not) :-)


Show nothing, and ater press sstop log show this
>{rsx::thread} RSX: Program destructor invoked!
{rsx::thread} Exception: Assertion failed! Result is 1h
(in file Emu\RSX\VK\VKGSRender.cpp:797, in function VKGSRender::init_buffers)


This is a super-long method; maybe you could break it into sub-methods?


I've always assumed the object language is well typed, which is why I
didn't have a case in apply for non-functions.

On Wed, Mar 9, 2016 at 4:35 PM, Phil Nguyen <notifications@github.com>
wrote:

> Or is it ok if we consider it just a run-time error at the object
> language's level, just like applying a number?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dvanhorn/monadic-eval/commit/67a2a77da881752e84b83ff49155de23f5bbd086#commitcomment-16601485>
> .
>


This last sentence is no longer true (it was a bug).


At least, I know that you **are** human, @JeroenVinke


@buglloc Awesome will check it out.. And yes, I'm afraid that could be the case sadly...


lol I need to add my gitignore


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18722](https://teamcity.mesosphere.io/viewLog.html?buildId=158736&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:07


This doesn't build!


Yes, it is, but 2 lines more :)


~ % go get -u golang.org/x/tools/godoc
# golang.org/x/tools/godoc
src/golang.org/x/tools/godoc/godoc.go:495: eg.Unordered undefined (type *doc.Example has no field or method Unordered)


list_del here doesn't follow constructor-destructor symmetric logic principle.
working with lists isn't performed in stack entry constructor or destructor.


Thanks, I am learning Ruby and using this repository for practice.


yuck; I suggest stopping this and simply use the no-arg version.  There's no way it's going to be a hotspot.  1f load factor; why?!


Ups, that is awful.


As a work around I am doing this now which will work.

        getPackageImportMap(params.getBuildTarget().getBasePath(),
            FluentIterable.from(linkables).transformAndConcat(
              new Function<GoLinkable, ImmutableSet<Path>>() {
                @Override
                public ImmutableSet<Path> apply(GoLinkable input) {
                  return input.getGoLinkInput().keySet();
                }
              })),


- [ ] Web of Trust is the wrong term. This is PKI.
- [ ] Clarify that:
  - [ ]  the root CA Is typically *not* included in the bundle
  - [ ] the cert doesn't do anything to authenticate the server

- [ ] Typically a "secure connection" is a connection that is: confidential (i.e. people can't see what you're saying), resistant against tampering (i.e. people can't change what you're saying) and authenticated (i.e. each party knows who it's talking to)

- [ ] relatedly: self-signed certs essentially only provide the firstof these ^  (whether or not they provide tamper-resistance is debatable)

- [ ] Domain validation: I'd cut the WHOIS record bit
- [ ] split "types of certs" in two
- [ ] Any valid cert nowadays, even if it secures a single domain (which is extremely unusual anyway: most CAs will add the `www.` on the cert), will be a SAN cert with DNS names

- [ ] Fix digicert link
- [ ] Suggest not losing `key.pem` and keeping it secret/secure.  Recommend a password manager


Way to go!


ios-sim is not needed here. Right ?


TeamCity Glyssen :: Glyssen-master Continuous [Build 0.2.10.ae14b974e8797620f05e6c1989f22eb60f7112dc](http://build.palaso.org/viewLog.html?buildId=70129&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 1031, ignored: 12 Build time: 00:08:07


pop operation shoul delete entry from top of list.
push, pop implement stack data structure semantic not constructor/destructor.


Oops. I should have done that to begin with


I agree with the well-typed assumption--should we remove those tests, then? It'll make the code look cleaner.


Solved in https://github.com/libre-mesh/lime-packages/commit/3553ca02b3ea438e9aa85faa9610611e9786ea18


Yeah, you're totally right. My code in `debug.h` is busted. I could change `debug*(msg)` to `debug*(...)` for the non-debug case and have it compile, but I don't think you can technically use `...` for variadic macro args in C89 even though the compiler allows it.

I can get this fixed this weekend when I have some time. If I can't find a solution I like with the combined C89 / C99+ header I'll probably just split the header into two versions, one for each language version.


I was thinking people might pass an object of tasks, similar to parallel, e.g:

```js
async.race({
  task1: function (cb) {...}
  task2: function (cb) {...}
  task3: function (cb) {...}
}, cb)
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18723](https://teamcity.mesosphere.io/viewLog.html?buildId=158737&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:05:04


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18724](https://teamcity.mesosphere.io/viewLog.html?buildId=158749&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:15


Ah, right.


exactly! may do not add plus


Are you sure we can drop the `always | never` validation here?


README kind of sucks.


`return $topic->isadoublepost($user) === true ? "1" : "0"`


you can try the latest commit which might fix the crashes during flip without hacks. Commenting out the line was supposed to make the screen not display anything, to check is error is only on flip. Was the fps updating or stuck?


Thank you man you are right. Now i know where the problem was.


Can you please explain how we can use this code. I have .ncs files and I want to convert them to .dat so that I can use them for Kluastaviews.

Thanks


@paulmolluzzo I need to use a delegate so this would work for elements added to the DOM at a later time as well. Also adding multiple event listeners is less performant (especially if I add more on every DOM change) than having a single listener with a target check.

See http://api.jquery.com/on/#direct-and-delegated-events

`jQuery.fn.on` has a built-in support for that using the `selector` argument, but the Sprint framework does not support it.


Yep this seems right. Can you make a PR? I'll merge it to dev and put some tests on top of it for the next release. Thanks!


TeamCity Glyssen :: Glyssen-master Continuous [Build 0.2.11.74be57d97f0f043aa5f3c937df67e3d2c0150a7e](http://build.palaso.org/viewLog.html?buildId=70130&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 1039, ignored: 12 Build time: 00:08:55


Yea lets

On Wed, Mar 9, 2016, 4:41 PM Nicholas Labich <notifications@github.com>
wrote:

> I agree with the well-typed assumption--should we remove those tests,
> then? It'll make the code look cleaner.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dvanhorn/monadic-eval/commit/67a2a77da881752e84b83ff49155de23f5bbd086#commitcomment-16601656>
> .
>


Yes, back then, there was one job per model, now not anymore.  I’d suggest reverting this commit for now until we get to do it in a way that’s consistent.

> On Mar 9, 2016, at 1:25 PM, Nick Karpov <notifications@github.com> wrote:
>
> Any ideas? I believe start/end times were pulled from Job prior to the rewrite of Job which broke these values
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/h2oai/h2o-3/commit/eebfb1fdb4571a67475ff24c0d33e6132cfe491a#commitcomment-16601260>.
>


@paulmolluzzo If you want we can move the discussion to the PR or a diff comment as I've rebased and force-pushed and now these comments are not tied to the PR.


Fatal error, exactly same before ^^


Great commit :)


:shipit:


@raggi, almost nobody on the Go team sees comments here in Github. It's only a mirror of our source code.

Commenting on the Gerrit issue (or filing a bug) will get attention: https://go-review.googlesource.com/20458 (as referenced in the commit)


this is a struct. you can memset it or just set count to zero. i don't think any api change is reqired. note that vnsi does work


TeamCity Glyssen :: Glyssen-master Continuous [Build 0.2.12.c2b7fe47eba6876bfd66e8cdee77bb483fa65280](http://build.palaso.org/viewLog.html?buildId=70131&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 1031, ignored: 12 Build time: 00:06:42


LGTM


Не могу решить одну проблему. На данный момент пользователь может подписаться только на один курс. Если он зайдет на другой курс и попробует также подписаться, выдаст ошибку, что user_id уже существует. Пробовал убрать индексы уникальности, но это не помогло.


Ok, I'll merge on a :+1:


:+1: added the frustration description


I'm trying to understand this if block, and this line in particular.  I've tried isolating as a bash program:

#!/bin/bash

upload_branch="master"

echo "using branch $upload_branch"
echo "input parameters 1: $1, 2: $2"

# Should the AppImage be uploaded?
if [ "$1" == "--upload-branches" ]; then
  echo "# User passed in a list of one or more branches so only upload those listed"
  shift
  for upload_branch in "$@" ; do
    echo "for iteration upload_branch=$upload_branch"
    [ "$branch" == "$upload_branch" ] && upload=true || true # bypass `set -e`
  done
else
  # No list passed in so upload on every branch
  upload=true
fi

echo $upload

but when I execute
branches="master 2.0.3"
./test.bash --upload-branches $branches

then the resulting output:

# User passed in a list of one or more branches so only upload those listed
for iteration upload_branch=master
for iteration upload_branch=2.0.3

indicates that the $upload variable is not set to true...

What is going on???


Its a scoped type, you reference it externally from `LBMContentMapping` via `LBMContentMapping::container_map`. Its only used inside the struct methods.


I suppose, but stuff like that's always a bit sketchy as it relies on object iteration order


We use custom names for some parameters to improve usability for users so this is needed


Hi when was this changed from 2.1 to 2.2 ive a blinkstick pro with 2.1 on now the firmwaris 2.2 and it says hear its not been changed for 3 years,but ime pretty st was 2.1 just the other week,ime confused,


Delete `tagtarget` and re-use `tag` instead


It might be better with switch(outFormat).


hmmm maybe some rethink of that?
31.6 or 31.5
63.2
125.8 or 126
251.2 or 251(as it is)
501.2
1.00 k
1.99 k
3.98 k
7.94 k
15.85 k

to be more technically correct ;)


if you need pid here, you need to parse it out yourself. i seriously doubt that this is required because pid is at mpeg-ts level and no more visible after demuxer


We have 9 valid methods in the enum, no? Will this contemplate any of them?


More descriptive name needed


You've answered it enough I think. I'll give more testing later too.


did you try with vnsi ?


OK, got it.


I think we should test that the presenter returned is the one we expect (rather than another one), maybe this:

```
expect(presenter.attach_controller(controller)).to eq(presenter)
```

What do you think? Sorry to be pedantic about it. Thanks :heart:


не знаю, мне ща очень сложно думать)
но картайтем принадлжит ордеру разве?


Now when you remove "TempDownloadDirectory" what will you add instead? Instead of having leftover files in every folder it was so easy to have a `%[targetdrive]DCUnfinished\` and delete files i found in that folder.


I tried to use it, but it seems not working, what is wrong?
mvn clean test -DrunTestIdMatching=hibernate-01000-test

I would expect it runs only hibernate-01000-test test from https://github.com/windup/windup-rulesets/blob/master/rules-reviewed/hibernate/tests/hibernate.windup.test.xml or is that wrong assumption?


:+1: Once final comment is added.  Thank you.


Suggested SQL updates for this commit (watch out for the condition entry):
```SQL
-- Moved to DB gossip menu/gossip menus options used in quest 4224 (The True Masters) by NPC 9563 (Ragged John)

SET @CONDITION := 9997;

DELETE FROM conditions WHERE condition_entry=@CONDITION;
INSERT INTO conditions VALUES
(@CONDITION, 9, 4224, 0);

DELETE FROM gossip_menu WHERE entry BETWEEN 2050 AND 2060;
INSERT INTO gossip_menu VALUES
(2050, 2725, 205001, 0),
(2051, 2723, 0, 0),
(2052, 2722, 0, 0),
(2053, 2721, 0, 0),
(2054, 2720, 0, 0),
(2055, 2719, 0, 0),
(2056, 2718, 0, 0),
(2057, 2717, 0, 0),
(2058, 2716, 0, 0),
(2059, 2715, 0, 0),
(2060, 2714, 0, 0);

DELETE FROM gossip_menu_option WHERE menu_id BETWEEN 2050 AND 2061;
INSERT INTO gossip_menu_option (menu_id, id, option_icon, option_text, option_id, npc_option_npcflag, action_menu_id, action_poi_id, action_script_id, box_coded, box_money, box_text, condition_id) VALUES
(2061, 0, 0, 'Official business, John. I need some information about Marshal Windsor. Tell me about the last time you saw him', 1, 1, 2060, 0, 0, 0, 0, '', @CONDITION),
(2060, 0, 0, 'So what did you do?', 1, 1, 2059, 0, 0, 0, 0, '', 0),
(2059, 0, 0, 'Start making sense, dwarf. I don\'t want to have anything to do with your cracker, your pappy, or any sort of \'discreditin\'.', 1, 1, 2058, 0, 0, 0, 0, '', 0),
(2058, 0, 0, 'Ironfoe?', 1, 1, 2057, 0, 0, 0, 0, '', 0),
(2057, 0, 0, 'Interesting... continue, John.', 1, 1, 2056, 0, 0, 0, 0, '', 0),
(2056, 0, 0, 'So that\'s how Windsor died...', 1, 1, 2055, 0, 0, 0, 0, '', 0),
(2055, 0, 0, 'So how did he die?', 1, 1, 2054, 0, 0, 0, 0, '', 0),
(2054, 0, 0, 'Ok, so where the hell is he? Wait a minute! Are you drunk?', 1, 1, 2053, 0, 0, 0, 0, '', 0),
(2053, 0, 0, 'WHY is he in Blackrock Depths?', 1, 1, 2052, 0, 0, 0, 0, '', 0),
(2052, 0, 0, '300? So the Dark Irons killed him and dragged him into the Depths?', 1, 1, 2051, 0, 0, 0, 0, '', 0),
(2051, 0, 0, 'Ahh... Ironfoe.', 1, 1, 2050, 0, 0, 0, 0, '', 0),
(2050, 0, 0, 'Thanks, Ragged John. Your story was very uplifting and informative.', 1, 1, -1, 0, 0, 0, 0, '', 0);

DELETE FROM dbscripts_on_gossip WHERE id=205001;
INSERT INTO `dbscripts_on_gossip` VALUES
(205001, 0, 7, 4224, 5, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, '');
```


TeamCity Glyssen :: Glyssen-master Continuous [Build 0.2.13.ae14b974e8797620f05e6c1989f22eb60f7112dc](http://build.palaso.org/viewLog.html?buildId=70132&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 1031, ignored: 12 Build time: 00:07:57


tak własciwie to to powinno być zwracane w jsonie


kill me


It is `race` after all -- you don't necessarily care which finished first. :smile:


Здесь можно по другому
На будущее если ьудешь загиматьсч адаптивной версткой ,то снова прмбовляй 240пх ибо , если растянуть сайт,то он вправо прибьется


no dobra, może nie kill me, ale trzeba to zrobić jakoś inaczej


@barend Yes.
Needs to be replaced with env setting as described here on deployment: https://docs.djangoproject.com/en/1.9/howto/deployment/checklist/#secret-key


Delete line if not needed


Thanks, fixed with v1.0q10.


Does the -n still work as well?


just out of curiositiy: what are you going to use doctrine for?


Awesome


weź porządnie formatuj kod


yup, in that case (if this is giving us the correct lighting) our skew operation was wrong before.


:exclamation:


skad ty to czemu taki commit wat why


So now texture is always RGB (never be BGR) ?


chwila


jak to weszło na maina


I can add it in if you like, but I think it would exercise the same code path as the unicode smiley.


TeamCity Glyssen :: Glyssen-master Continuous [Build 0.2.14.9723423104ab8af2c5f32b92411cb15ef66b05a8](http://build.palaso.org/viewLog.html?buildId=70133&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 1033, ignored: 12 Build time: 00:07:01


Looks like a good change.


> we are not ready yet for proper documentation

That make three of us.


Suggested SQL updates for this commit (watch out for the condition entries):

```SQL
-- Moved to DB gossip menu/gossip menus options used in quests 4001 (What Is Going On) and 4342 (Kharan's Tale) by NPC 9021 (Kharan Mighthammer)

SET @CONDITION := 9998;
SET @CONDITION_HORDE := 10000;
SET @CONDITION_ALLIANCE := 10001;

DELETE FROM conditions WHERE condition_entry IN (@CONDITION, @CONDITION + 1);
INSERT INTO conditions VALUES
(@CONDITION, 9, 4001, 0),   -- Horde quest
(@CONDITION + 1, 9, 4342, 0);   -- Alliance quest

DELETE FROM gossip_menu WHERE entry BETWEEN 1823 AND 1830;
INSERT INTO gossip_menu VALUES
(1823, 2482, 182301, @CONDITION_HORDE),
(1823, 2482, 182302, @CONDITION_ALLIANCE),
(1824, 2481, 0, 0),
(1825, 2480, 0, 0),
(1826, 2479, 0, 0),
(1827, 2478, 0, 0),
(1828, 2477, 0, 0),
(1829, 2476, 0, 0),
(1830, 2475, 0, 0);

DELETE FROM gossip_menu_option WHERE menu_id BETWEEN 1822 AND 1830;
INSERT INTO gossip_menu_option (menu_id, id, option_icon, option_text, option_id, npc_option_npcflag, action_menu_id, action_poi_id, action_script_id, box_coded, box_money, box_text, condition_id) VALUES
(1822, 0, 0, 'I need to know where the princess are, Kharan!', 1, 1, 1830, 0, 0, 0, 0, '', @CONDITION),
(1822, 1, 0, 'All is not lost, Kharan!', 1, 1, 1828, 0, 0, 0, 0, '', @CONDITION + 1),
(1830, 0, 0, 'Gor\'shak is my friend, you can trust me.', 1, 1, 1829, 0, 0, 0, 0, '', 0),
(1829, 0, 0, 'Not enough, you need to tell me more.', 1, 1, 1828, 0, 0, 0, 0, '', 0),
(1828, 0, 0, 'So what happened?', 1, 1, 1827, 0, 0, 0, 0, '', 0),
(1827, 0, 0, 'Continue...', 1, 1, 1826, 0, 0, 0, 0, '', 0),
(1826, 0, 0, 'So you suspect that someone on the inside was involved? That they were tipped off?', 1, 1, 1825, 0, 0, 0, 0, '', 0),
(1825, 0, 0, 'Continue with your story please.', 1, 1, 1824, 0, 0, 0, 0, '', 0),
(1824, 0, 0, 'Indeed.', 1, 1, 1823, 0, 0, 0, 0, '', 0),
(1823, 0, 0, 'The door is open, Kharan. You are a free man.', 1, 1, -1, 0, 0, 0, 0, '', 0);

DELETE FROM dbscripts_on_gossip WHERE id IN (182301, 182302);
INSERT INTO dbscripts_on_gossip VALUES
(182301, 0, 7, 4001, 5, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, ''),
(182302, 0, 7, 4342, 5, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, '');
```


That sounds correct to me. Looking at the code leads me to believe that it should work that way as well. What does the test summary say when it completes?


2081-op-scheme-schedule (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2358 of 2398 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.33%25-yellow.svg)


Sure, LGTM.


No tests for this?


Should probably also include tests, I guess.


This process below could be extracted because it's very similar to what is done in the file upload class. May be extract it to a method which just takes the json paths or use a constant path and don't pass in anything. If that doesn't make sense, let me know.


Better to add some assertion or debugbreak, so it's easy to tell when it hit unsupported path.


fixed in https://github.com/libre-mesh/lime-packages/commit/6324dc36ff7c720ef4fc097fd579f8787b1dde7b


Ok, remind me to look at it next meeting.  The line up plays should work with any number of robots, so if there's a problem with it I can look into fixing it.


What are those leftover files? You should make a bug report instead.


Remove commented code if not needed


Суть как раз в том чтобы написать робота который может играть в танчики


`Cause` and `SpawnCause` are immutable in all senses. You can however create a singular `Cause` and recycle the use of that cause for every  bat spawn to spawn.


still training it


Will do. I'm sorta down in a hole right now :)

Thanks for catching it!


@gasche I assume this is a typo (the second occurrence of ty1 should be ty2).  Can you confirm?


Yes that is fixed now :smile:


LGTM


addressed in #40


#11 should be fixed with this


#12 should be fixed with this.


Recommend using `Clock::now` to get current `Time`


Thanks!


Same suggestion as L217.


React warnings are not under SUT. If we want to test that param is required, then we should do something like this:
expect(IconButton.propTypes.name).to.equal(React.PropTypes.string.isRequred), or even better to write helper for chai.
In this case we’re stricting that prop should match certain React rules, but what should do with these rules should decide React itself.
If we’ll throw an Error from constructor, for example, then this is case for test, but not standard react behavior


according to https://github.com/joewilliams/haproxy/blob/master/include/types/counters.h the values should never overflow. So it's safe to make them of derive type


It also made it really confusing, you're talking about the CocoaPods App, can you make an issue on that repo please


Recommend using `Time` and `Duration` to do time calculations.


Hi @zdenop

For historical reasons, the default psm in libtesseract is PSM_SINGLE_BLOCK.
The default psm when using the 'tesseract' command is PSM_AUTO.

https://github.com/tesseract-ocr/tesseract/blob/b1c13828436ba946d5f708f766bbc03c17fc2b60/api/tesseractmain.cpp#L181

https://github.com/tesseract-ocr/tesseract/blob/b1c13828436ba946d5f708f766bbc03c17fc2b60/api/tesseractmain.cpp#L354

https://github.com/tesseract-ocr/tesseract/blob/b1c13828436ba946d5f708f766bbc03c17fc2b60/ccmain/tesseractclass.cpp#L71


ok to test


To enable partial snapshotting you have to cancel snapshot anyway :)  So, maybe just say something like try again after snapshot finishes or cancel the currently running snapshot.


Actualizado para Ecuador


@davidmfoley yes! That works! I had a copy paste error in my last else statement, so it was harder than it should have been to make it all work right. But now it's filtering games like it should. And showing what i want it to show when there are no games in matchingGames.


you had the indices loop duplicated in comment out code, i cleaned it up.


Doesn't seem to work yet.


Looks good. I'm glad that it didn't involve 234703 lines of code to fix.


test


Great!


herp


Could make this section terse by doing something like `Clock::now() - startTime < stopTimeout`


I believe this is correct, previously we were modifying the model view matrix directly, but correct way to apply the skew matrix is to post multiply it, which is what is happening here.


no clue how i did that, will fix


Why is this change needed?


#Los esqueletos desaparecen antes de que los mate en mi spawn de esqueletos no dropean objetos ni xp


Allowing it to be added to the unit test is the main reason. Via a filter we can run it through the same filter that runs and test it at the same time, without adding another function.


Output starts here..


@jmayer417 :+1:


this fixes #70


... There is a typo in the commit message... :(

Am 9. März 2016 23:09:20 MEZ, schrieb kumy <notifications@github.com>:
>ok to test
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/rahu/c-geo-opensource/commit/114c5944380544c0895633c0f6bd454004a4736c#commitcomment-16602291

--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.


Will generate warning "headers already sent"


Did you mean to leave this commented out?


Fixed in https://github.com/libre-mesh/lime-packages/commit/3773af71e55058dbde8894648c21e9bb2273a778


Vulnerable to SQL injection


tu Brzoza, Zaciągamy sieć! Można zaczynać!


this fixes #69


fixed in https://github.com/libre-mesh/lime-packages/commit/01c6ef9ba9f1b557a11ad184b2385b9f6ac27500


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18725](https://teamcity.mesosphere.io/viewLog.html?buildId=158767&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:04:43


Without doing this, the new person card would keep the first spouse and parents set for all subsequent person cards. I'm open to other methods.


I made it return latency, but add the object size to the metadata for the latency samples. When I add object size distributions, I can just report more latency results with different metadata. How does that sound?


This fixes the previously failing unit test


Looks fine.


this fixes #66


It's no biggie, but sdk.js should probably load current version (which is v2.5 right now).


I like that we made the command the user types the same `ec2 contain` and `nova contain`, but why not just put the body each method inside the `contain` methods?


actually this variable did most of issues


The test should be `x$enable_neo_geo_pocket_plugin`.


Make "Remove banned @NotNull annotation" the title of the commit


rgr


htk


The .And.Contains (BAD-FILE) has been lost on this and following Asserts.  It was retained above, why not in the rest?


this enables the cookies popup #65


Block should be tabbed in to be in line with line 94 above


Done in https://github.com/cmangos/mangos-wotlk/commit/ee8bfd2b178580f38e9d2214b7153fbefe83424e


LGTM.


Lines 31 - 40 can be written as:

```ruby
unless groups_list.any? { |group| group["name"] == SECURITY_GROUP_NAME }
  `neutron security-group-create #{SECURITY_GROUP_NAME}`
end


Issues mentioned in this commit (a64feedd6a1dfd742846e2bce76897ed394c1265):

* [Issue #9179](https://bugs.mtasa.com/view.php?id=9179)


are these environment variables set outside of this script ?


No! Meant to delete altogether, and replace with a different guard. Fix incoming...


recommend `stop.await(stopTimeout)`.


If you write this plugin, you have the copyright I suppose.


Looks good. But in my opinion would be much better to enable colors in dxDrawText function.

Also want to show you easy and beautiful solution about removing color codes without changing code. Just by adding this: http://pastebin.com/8uRNFfjn


Понял, хорошо


Ruby has something called proc to block, which is just a fancy way of saying that we have syntactical sugar for mapping methods with no arguments.

```Ruby
current_secgroups = current_secgroups.split("\n")[3..-2].map(&:strip)
```


I am happy to help but I don't understand what exactly you are trying to accomplish.  Are you trying to see if the Slaad has any other natural attacks except its own?  More info please....


Potential quick solution would be to use apache to proxy this API to, say, `data.gramene.org/v50/reactome/highlightPathwayDiagram` and inject the appropriate CORS header.


Issues mentioned in this commit (70902d813562abda86ce404b189b86d16e6b46c0):

* [Issue #9179](https://bugs.mtasa.com/view.php?id=9179)


Some peer review,
I believe it's only necessary to use _this _ when you need to disambiguate an instruction, overusing it makes code unreadable. You should also be using getters for variables even if they're both in the same class (or why have getters right?).


@gibrahim :+1:


like this
![capture d ecran 2016-03-09 23 24 10](https://cloud.githubusercontent.com/assets/5261759/13652726/1b50fdf2-e64e-11e5-97e9-c9fe7c0d0ab5.png)


I tried with a ts file. no pvr involved.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18726](https://teamcity.mesosphere.io/viewLog.html?buildId=158768&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:05:32


fix for #67


@Duane11003 :+1:


Вот возникла такая проблема http://stackoverflow.com/questions/6949148/css-after-not-adding-content-to-certain-elements

Можно конечно поизвращаться на тему обертки картинок в div, но стоит ли?


A second nested loop after the first one!


@tsheasha this seems to fix Go 1.6.

My rationale is below - legit?

(Assuming Travis is green now, I'm going to tweak README and ship)


test


Here is the script on the Green Slaad
Post levels 10000
      foreach pick in hero from BaseWep where "(wGroup.Natural)"
        eachpick.Field[sbName].text = eachpick.Field[name].text & " (Slaad Form Only)"
eachpick.Field[livename].text = eachpick.Field[sbName].text
        nexteach

Used to add " (Slaad Form Only)" text on natural weapons name, but the Green Slaad has also Hurl Flame that is a for now set as a natural weapon, I dont want this text to display on this one, but don't know how to do it.


Lines 63 - 83 could be written as:

```Ruby
unless EC2Resources.security_groups.any? { |group| group.group_name == SECURITY_GROUP_NAME }
  new_sg_params = {
    group_name: SECURITY_GROUP_NAME,
    description: "Security group for locking down a VM."
  }

  if !vm.vpc_id.nil?
    new_sg_params["vpc_id"] = vm.vpc_id
  end

  containment_sg = EC2Resources.create_security_group(new_sg_params)
end

containment_sg ||= EC2Resources.security_groups.detect { |group| group.group_name = SECURITY_GROUP_NAME }
```


> the special casing for fetching builder plugins
first - it serves no purpose.

Actually there is purpose of fetching builder plugins first: to execute its `get-sources` target before downloading other components. It may for example import some key later used to verify code. See https://github.com/QubesOS/qubes-issues/issues/1420#issuecomment-158617170 (that commend and the whole ticket).

As this mechanism of downloading plugins first doesn't solve all the problems (builder configuration isn't reloaded etc), it may be also removed. But it would be good to think of some solution for QubesOS/qubes-issues#1420

BTW Script to build template in DispVM explicitly calls `make get-sources` twice - first to download builder plugins, then to download the rest of the code: https://github.com/QubesOS/qubes-builder/blob/master/scripts/build_full_template_in_dispvm#L104-L106


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18727](https://teamcity.mesosphere.io/viewLog.html?buildId=158788&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:05:22


Nitpick: Prefer spaces around hash keys and values `({ groups: [] })`


hehe


Ship, makes sense!


You probably know that as it'as a WIP but:

- files you still have to edit:
 - configure.ac
 - plugins/Makefile.am
- missing files:
 - plugins/neo-geo-pocket/src/Makefile.am
 - plugins/neo-geo-pocket/src/neo-geo-pocket-game.vala

Good job so far.


Не могу найти это место ?


Do you have one for the epoch you are up to that you could share?


s#dependencies dependencies#dependencies#


Actually should this not read " > 5 " to match the error message?


wait, shouldn't these two have "should be able"?


Why u reverse this FOO


not needed, we use grunt auto load, that load all `grunt-` prefixe npm modules.


problems in the code


As I said pid is not needed at all in case of Kodi. amcodec uses it only during playback of a full TS stream. Kodi always play ES video stream. I just applied the following patch to a Jarvis build and it continues to play all streams (including Live TV) without problems:
```
diff --git a/xbmc/cores/dvdplayer/DVDCodecs/Video/AMLCodec.cpp b/xbmc/cores/dvdplayer/DVDCodecs/Video/AMLCodec.cpp
index 7236444..4db5395 100644
--- a/xbmc/cores/dvdplayer/DVDCodecs/Video/AMLCodec.cpp
+++ b/xbmc/cores/dvdplayer/DVDCodecs/Video/AMLCodec.cpp
@@ -1438,7 +1438,7 @@ bool CAMLCodec::OpenDecoder(CDVDStreamInfo &hints)
   am_private->video_height     = hints.height;
   am_private->video_codec_id   = hints.codec;
   am_private->video_codec_tag  = hints.codec_tag;
-  am_private->video_pid        = hints.pid;
+  //am_private->video_pid        = hints.pid;

   // handle video ratio
   AVRational video_ratio       = av_d2q(1, SHRT_MAX);


This change is great and fixed a crash or me.  However, the package version did not get updated so the change is not making it out to those of is installing via npm.  Can you please update the package?  Thanks!


This was kind of a surprising change, our server didn't have this running so all the curls failed.
Can you please put on your README that this cipher is required? If people don't have it they'll get empty responses. Thanks.


@datakurre Hi Asko, are you ok if I use what you explained in your article http://datakurre.pandala.org/2015/05/customize-plone-5-default-theme-on-fly.html ? I think it could be useful to have that in the Plone doc.


@Eric-L-T we should continue the discussion on PR #188, Jack has already posted a comment there. It will become confusing otherwise :-)

I wonder why he asked that though, there are lots of people contributing ATM, and even if he does not have the time now I think it's always useful to create PR's as soon as they are ready and have a visible backlog.


:clap: This is fantastic!


You want to keep this closing `p` tag, don't you?


起的好早！
下一个版本终于要到在线音乐播放了。


话说如果可以的话，去官网上把Arch Linux的安装方法之类的写上吧。不然只有PPA和Mint感觉……好像排挤谁似的。
（感觉Linux都可以单独拿出来一页了）


Correct.  If you are using Docker's `link` option, and you name the the linked container as `mongo`, then these variables will be populated by Docker.  You can also set them manually, of course, or set the entire `MONGO_URL` manually.


Having some very puzzling issues where my variables are clearly having their values change as it goes through the alert() statements. I feel like I'm losing my mind. I've checked the math over and over, and can't figure out what I could be doing wrong.


No, it is not. I did the fix with next commit.


sure, latest snapshot: http://cb.cr/wxfc


solution to the assignment


When the alert gets to line 21, it clearly has the values of all three number switched around.


Typo on title: Monday and not Friday


for me, only removes the warning, the image was not send to destination.


Yes, your are right.


Well, no they aren't that bad, it's just that I `went_to(bed)` so I couldn't respond.  And then I had an orchestra contest today, which I think we did really well in.  We also got to hang out at West Town mall, so that was fun.  And yeah, Alex, you can get whoever you want to help us on Github.  And also, my family has two 100x100 ft gardens, beehives, two pear trees, lots of muscadiines (wild grapes), etc so I can definitely relate to the hole digging stuff.  During the summer, my dad says that we need to help him for a certain amount of time.  If I wake up early and work while it's not hot, then it's fine, but if I wait until it's hot, then it's pretty bad.  Anyway, hope you guys have good spring breaks.  I won't be going anywhere, so I'll just do random stuff at home.


well I feel like wasting my time here. you better start testing Krypton you'll find out more than livetv broken on aml...


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18729](https://teamcity.mesosphere.io/viewLog.html?buildId=158800&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:05:18


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18728](https://teamcity.mesosphere.io/viewLog.html?buildId=158799&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:05:32


You are right, I will fix that. Thanks


Yeah, before this fix, if the user didn't have access to one or more of the vocabularies, the system would throw an exception and the Asset Categories Navigation portlet wouldn't display anything. With the fix, the Asset Categories Navigation portlet will always be displayed (unless if the user has access to none of the vocabularies), and no exceptions will be thrown (because we catch it here). It will not display vocabularies that the user does not have access to view because the PrincipalException will be thrown and caught before they get added to _ddmTemplateAssetVocabularies


could you rerun with getting more neighbors, say like 1000. Would be interested in the time diff when requesting more neighbors. Since we request a lot more than 10 neighbors when we use annoy.


Was talking to Alex! Same here for the weekdays, I'll do nothing those days, weekends will be my sister's soccer tournaments!


yep.  Copy/paste error!


Read until the end of the line ;)


hmmm.


Thank you, you are a legend!


"gg"


:tada:


Thanks for accepting! Love the plugin.


Oh duh, I should have known there was a special testing mechanism for this. I've written very little in terms of django tests. I'll get a new PR done momentarily.


Does this actually work for you?  Just curious because I have it that my call_recording is supposed to be enabled to default (vendor overlay) and the default audio source is already 1 and I do not have the record option anywhere...


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18730](https://teamcity.mesosphere.io/viewLog.html?buildId=158801&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:05:19


@vivekramamoorthy Vivek Ramamoorthy please update your commit with corresponding documentation for these tcpdump functions: tcpdump_rate() and tcpdump_capture_interface(). Documentation must be included between """ ... """ like this:

def add_route(enode, route, via, shell=None):
    """
    Add a new static route.

    :param enode: Engine node to communicate with.
    :type enode: topology.platforms.base.BaseNode
    :param str route: Route to add, an IP in the form ``'192.168.20.20/24'``
     or ``'2001::0/24'`` or ``'default'``.
    :param str via: Via for the route as an IP in the form
     ``'192.168.20.20/24'`` or ``'2001::0/24'``.
    :param shell: Shell name to execute commands. If ``None``, use the Engine
     Node default shell.
    :type shell: str or None
    """

Regards,


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18731](https://teamcity.mesosphere.io/viewLog.html?buildId=158802&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:04:58


Yeah, I've found this *really* nice so far.


But are you sure non-working live tv is caused by pid removal? It is the only thing I wanted to say.


http://data.gramene.org/reactome currently proxies http://plantreactome.gramene.org/ReactomeRESTfulAPI/RESTfulWS
but I don't recall doing anything with CORS in the apache conf


What about the `-Ydelambdafy:method` option?


why this?


It doesn't work either. Can it be that telephonyManager.isOffhook() is gets called anyway even if telephonyManager  == null?

I will try the following and see if it solves this issue:

> diff --git a/services/core/java/com/android/server/power/PowerManagerService.java b/services/core/java/com/android/server/power/PowerManagerService.java
index ebb6db0..d46f113 100644
--- a/services/core/java/com/android/server/power/PowerManagerService.java
+++ b/services/core/java/com/android/server/power/PowerManagerService.java
@@ -1701,9 +1701,14 @@ public final class PowerManagerService extends SystemService
      * to suspend.
      */
     private boolean isBeingKeptAwakeLocked() {
+       boolean telephonyManager_isOffhook = false;
+
+       if (!telephonyManager)
+               telephonyManager_isOffhook = telephonyManager.isOffhook();
+
         return mStayOn
                 || mProximityPositive
-                || (telephonyManager != null ? telephonyManager.isOffhook() : false)
+                || telephonyManager_isOffhook
                 || (mWakeLockSummary & WAKE_LOCK_STAY_AWAKE) != 0
                 || (mUserActivitySummary & (USER_ACTIVITY_SCREEN_BRIGHT
                         | USER_ACTIVITY_SCREEN_DIM)) != 0


From lab 9. was provided.


@adamwight This username with an apostrophe is the one that I can't get working when passing in usernames instead of ids. That's what keeps us from doing queries by username.

Alternatively, maybe we can do queries on global_id, and handle that on the tool labs side with more SQL.


Sorry, reformatting changed a bunch of whitespace. The important diff is:

```diff
        private Map<String, Tag> tags;
-
+
+       private Logger log = Logger.getLogger(this.getClass());
+
        public SwaggerSpecificationCreator(String baseUrl) {
                this.swaggerSpecification = new SwaggerSpecification();
                this.baseUrl = baseUrl;
@@ -74,66 +74,73 @@ public class SwaggerSpecificationCreator {
                searchHandlerDocs = fillSearchHandlers(searchHandlers, baseUrl);
                tags = new HashMap<String, Tag>();
        }
-
+
        public String BuildJSON() {
                synchronized (this) {
+                       log.info("Initiating Swagger specification creation");
                        toggleLogs(RestConstants.SWAGGER_LOGS_OFF);
-                       createApiDefinition();
-                       addPaths();
-                       toggleLogs(RestConstants.SWAGGER_LOGS_ON);
-                       addDefinitions();
-                       addSubclassOperations();
+                       try {
+                               createApiDefinition();
+                               addPaths();
+                               addDefinitions();
+                               addSubclassOperations();
+                       } catch (Exception e) {
+                               log.error("Error while creating Swagger specification", e);
+                       } finally {
+                               toggleLogs(RestConstants.SWAGGER_LOGS_ON);
+                               log.info("Swagger specification creation complete");
+                       }
```


Just leaving some comments as I've learned about your change on the IRC.
We're sending TASK_KILL even when the docker task might been SIGTERMED with this, is because TASK_KILL is just sent when the docker process is SIGKILLed, it's when a task is forcefully finished without normal termination. Normally when a task gracefully ends on its own we should reap the process without calling shutdown and it should send a TASK_FINISHED/TASK_FAILED based on exit status.
With this your change, even when a task is killed by killTask from the driver, we still end up sending back a TASK_FINISHED which I don't think is the right semantics.


Yes, but I don't have any ideas for how to ensure that doesn't happen.  I think documentation getting out-of-date with the implementation is essentially always a potential problem.


Зачем нам лишняя обёртка?


Why do we need the static property? Does PHP lose the last errors?


Also... should we support Java8 only, i.e. -target:jvm-1.8?


What are you seeing with stdout/stderr being corrupted?


@tawiesn I don't understand why MatrixMatrix short names in RAPFactory work fine, but Jacobi in SaPFactory does not. I also feel that this is a configuration issue, as my checkin test and local builds did not catch this.

I'm fine with adding forward declarations for classes in xpetra/sup/Utils.


@mrmckeb Random space


Somebody's going to notice you turning automation on.


думаю, вряд ли это ссылки у нас...


I used thuis manifest btw

Op 9 mrt. 2016 20:29 schreef "FayaX-PT" <notifications@github.com>:
>
> Put your errors here, peolple will help you!
>
http://forum.xda-developers.com/chef-central/android/guide-android-rom-development-t2814763
>
> —
> Reply to this email directly or view it on GitHub.


лоо


@kochichi @stefanchiriac Thanks for pointing this bug.


https://github.com/AOSP-CAF
Op 9 mrt. 2016 23:52 schreef "Jimmy G." <quesoo@gmail.com>:

> I used thuis manifest btw
>
> Op 9 mrt. 2016 20:29 schreef "FayaX-PT" <notifications@github.com>:
> >
> > Put your errors here, peolple will help you!
> >
> http://forum.xda-developers.com/chef-central/android/guide-android-rom-development-t2814763
> >
> > —
> > Reply to this email directly or view it on GitHub.
>


`•` в `<i>` можно добавить)


Thanks @nchah - copy and paste error there!


Очень хорошее понимание БЭМа, всё очень круто, ты молодец!


Garrrr :p thx


опечатка. зачем нам тайтлы кнопкам?


查TAGID还是用RPDMID和TAGNAME吧，以防并行时MAX(TAGID)已被修改


what did I do


OK


For what it's worth this was fixed in libsmbios ages ago: http://linux.dell.com/cgi-bin/cgit.cgi/libsmbios.git/commit/?id=23017bdcdbe466df555f63b66d6fcf305ec93260
I asked the person at Dell maintaining libsmbios to issue a new release since it's causing problems.  they did so 2 days ago. (Version 2.3.0) http://linux.dell.com/cgi-bin/cgit.cgi/libsmbios.git/commit/?id=a4d07df6b920584b73c7f6f99279b546fdbd2ec0


See https://github.com/open-sausages/silverstripe-cms/commits/pulls/4.0/tinymce-image-shortcode


Given the logged message, should there be a `return` here?


While we're updating this, these could become `$self->fatal_message` instead of `die $self->error_message`.

Now that there are four, we could also make these into something like:
```perl
sub _parse_seqdict_field {
  my ($expected, $field) = @_;
  my ($actual, $value) = split(':', $field, 2);
  unless ($expected eq $actual) {
    $self->fatal_message('Expected %s but got %s', $expected, $actual);
  }
  return $value;
}
```
We'd lose the position in the error message, but the errors would still be unique.


2097-EP-8-5 (kbenne) - i386-Windows-7-VisualStudio-12: OK (2357 of 2398 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.29%25-yellow.svg)


I always wondered about this. Thank you!


excellent work!

p.s. cmsg packets have different sockets on 6.2.4 too ?


Any particular reason you're starting the thread up lazily?


2. Estamos Construindo.


Looks fine, though it still really calls out for tests :p


Sure.


LGTM


Is this just to avoid sampling too often? If so, LGTM


package names in the go rules are currently a bit screwed up - I think there needs to be a custom GoPackage class (that might use a Path internally) that is RuleKeyAppendable & always uses forward slashes.

`go_binary`ies are currently an issue in general. You can't test them & you can't vendor them. My thought was that `main.go` should be as thin as possible and just call to a library almost immediately. That way you shouldn't need tests/vendoring for the main package.

That said, some people may need more than 64k of ram. I think the easiest fix is to add an arg to `createGoCompileRule` which sets the `packagePath` you mentioned & change `createGoBinaryRule` to pass `goBuckConfig.getDefaultPackageName()` instead of `packageName`. It's a bit unfortunate though - in some sense this means `go_binary` interacts badly with setting `package_name` on `go_library` - only the "default" package name works. You could also try to add a parameter to `go_binary` to make that nicer.


yes, as soon as you call `new`, which we do in `createFromFormat`


nice


This looks like a good place for [`List::MoreUtils::each_array`](http://search.cpan.org/~rehsack/List-MoreUtils-0.413/lib/List/MoreUtils.pm#each_array_ARRAY1_ARRAY2_...).


@ljharb Nothing native will be non-configurable. Just properties on constructors and their prototypes created using this property notation inside a class declaration.

@littledan The motivation is that someone using this notation is describing the shape of their instances. Programmers using this notation do not expect their instances to ever have a different shape from what they declared. If that is what they desire, then they should also be fine imperatively adding the properties in the constructor.


everything

On Wed, Mar 9, 2016 at 2:58 PM, Michael Gonzalez <notifications@github.com>
wrote:

> what did I do
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NVSL/TAZI/commit/dcbe1f8a5727057ff62b20d52e42c2b081578766#commitcomment-16603408>
> .
>


I was actually a bit surprised to find the top part of the comment when I started this port even though I wrote the original code just a few months ago - it certainly is a dangerously undocumented limitation.

Unfortunately, we don't really have a good place to put algorithm documentation like this - I could put it in the class docs, but most algorithm users don't really even have a reason to look at those.

Instead, I'm going to put a check in the Python wrapper code that raises an exception if the reference WCS is not the same as the measurement image's WCS.  That will effectively disable CModel for CCD forced photometry, but that's better than it silently not working.  Obviously, I'll want to fix that eventually.


`update_mtime` shouldn't be responsible (as its name suggests) for constructing the result term for `delete/3`


2.x is unsupported so no on that count, I guess we could release a beta2 with this change for rails 5 tho


I was wondering what was causing this. I had been working around this by deleting the cmhw version locally until it was fixed upstream.


@jameskoster For the sake of all the Ninjas giving repetitive support, and on the slight chance that folks are actually being prodded, nudged, and poked to **not** be **consistently** _spoon fed_ every two seconds...
I'd like to also second the **"larger"** option and recommend that they be the **same height** as the input field or jquery drop down that they are next to.


This wouldn't work correctly if database named as one of the tokens in `["shards", ".shards", "mrview"]`.


Ha, yes :-)


Haha of course I forgot to make it private... like always.


also 2x mal "time" als key


Lost comma


Please comment the `nAarg^1` expression.  This is going to confuse people.


this is client prediction for quaka 3 arena?
please activate again

unlagged = client ?

unlagged + client + server ?


It looks like you misspelled canola!


`couch_file` shouldn't know anything about `compaction`. The notion of compaction is outside of couch_file scope of responsibilities. We need to come up with better name for it.


Jep, hab ich schon verbessert, nur noch nicht gesynct ;)

Am Donnerstag, 10. März 2016 schrieb soeiner :

> also 2x mal "time" als key
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Machplatzwennduunsaufderstrassesiehst/Mental/commit/e6d2eba1a620c5e7f92066727cc56eda481f7d2f#commitcomment-16603609>
> .
>


I think `pos?` is what we want here. `(not (neg? val))` will not catch the case of 0.


2002 yıl itibari ile Emlak, Türkiye’de online alışveriş'in en güçlü isimlerinden biriyiz. Satılık Araba ile kurduğumuz hayaller ve ulaştığımız hedeflerle araba segmentinde bugünlere kadar geldik. Ne İstersen ile internetten güvenilir alışverişi geliştirdik, araba kiralama hizmet anlayışımızla fark yarattık. Emlakçı sektöründe hem çok büyüdük hem çok sevildik! Satılık Araç 1.250 kategoride 90.000 adet ürün çeşitiyle Satılık Oto'da e-ticareti Türk insanına sevdirmekle kalmadık, Emlak Siteleri'ni vazgeçilmeze dönüştürdük.

http://www.neistersen.com.tr/


https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/#spacing

No filler spaces in empty constructs


Looks great


Addressed in a9f77fb69bbec7bdfd608c560fcb798103ff6d9f


If you doxygenate these comments it appears somewhere in the docs.  Then how to extract this information usefully is a question for SQuaRE.


Addressed in 9a1a42ec398fe196b4998e500e40060ea884e5dc


2002 yıl itibari ile **[Emlak](http://www.neistersen.com.tr/)**, Türkiye’de online alışveriş'in en güçlü isimlerinden biriyiz. Satılık Araba ile kurduğumuz hayaller ve ulaştığımız hedeflerle araba segmentinde bugünlere kadar geldik. Ne İstersen ile internetten güvenilir alışverişi geliştirdik, araba kiralama hizmet anlayışımızla fark yarattık. Emlakçı sektöründe hem çok büyüdük hem çok sevildik! Satılık Araç 1.250 kategoride 90.000 adet ürün çeşitiyle Satılık Oto'da e-ticareti Türk insanına sevdirmekle kalmadık, Emlak Siteleri'ni vazgeçilmeze dönüştürdük.

http://www.neistersen.com.tr/


why do you need to call hide + show?  Perhaps just self.view.render() is required?


Why would a flint lock be any slower than any other similar length long arm?


Hi Daryl, I have updated the code to have an optional parameter for each method that will allow the request to be executed synchronously.  Thanks for the suggestion!  This will be part of v0.8.5 when it's released.


This is broken on 16.03: https://github.com/NixOS/nixpkgs/pull/13799


I've squashed this commit completely away.


Hmm, could someone set the `setuid` bit on watchman?

I guess we should also let `root` do whatever.


visit collections_collection_path is resulting in: 'This item is restricted to users with a University of Alberta CCID. Please login in with your CCID to view this item.' Not what I would have expected.


Is ``RTC.prototype.setAudioMute`` actually used? I couldn't reach this code during my tests. It seems like it is not, otherwise we would have noticed this bug?


This looks mostly correct, as far as my understanding of `SO_PEERCRED` and reading of the man pages goes.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18732](https://teamcity.mesosphere.io/viewLog.html?buildId=158808&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:05:23


Done.


I have fixed the spelling mistake and this will be part of v0.8.5 when released. Thanks!


I make sure one of them is defined here: https://github.com/nbrownus/rsyslog/commit/4a51e63f223e9c4abe62edb06e3c72c7a9c3ee16#diff-8554b50b4bc48f0eb45c260d38f03356R1898


Superb! Thank you!


size are knowns


same


the player needs to be starting with 100 dollars not 200


No. Problem was missing [ so the option was not being displayed. [ ] are used to enclose a check so this visibility is saying view type must equal video_right list and container can be either albums or songs. Only one of the container checks has to be true for the [ ] check to be true. | means 'or' and needs sometimes needs to be surround by [ ] having the check without [ ] would not make logical sense with an 'and' & 'or' without [ ].


Addressed in a9f77fb69bbec7bdfd608c560fcb798103ff6d9f


Thanks :rose:


I think it is manoeuvre.


Oh this is just lovely. In my modernistic constructions I rely heavily on diorite. This looks great.


I ported to the DB the text as it is here, but I doubt the grammar is correct.


Fantastic. Love the new look for the andesite; keeps in theme with the entire package.


godbless


Shouldn't we use a branch instead/and or resolve these blockers first?


this wasn't already set?


Crec que a la línia 90 el parèntesi que tanca està mal posat, és a dir perquè sigui una expressió booleana hauria de ser: `return len(tag.find_all(True)) <= 2`


**SUCCESS** - TeamCity HotRod C++ Client :: Pull requests monitor - RHEL [Build 508](http://ci.infinispan.org/viewLog.html?buildId=37247&buildTypeId=HotRodCpp_PullRequestsMonitorRhel6&guest=1) for 6396809633bf909a9a6f7540994af9804d44f89f
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:30:06


Instead of the foreach loop on the section where you bootstrap the wBite and wClaw put the "field" "livename" and "sbName" in with the wording you want.

It would look like this then:
```
    <bootstrap thing="wBite">
      <autotag group="AttackTarg" tag="1Target"/>
      <assignval field="wDieCount" value="2"/>
      <assignval field="wDieSize" value="6"/>
      <assignval field="livename" value="Bite (Slaad Form Only)"/>
      <assignval field="sbName" value="Bite (Slaad Form Only)"/>
      </bootstrap>
```

Remember a foreach loop should be the "last" resort type of code.  Its WAY too CPU expensive to have it run all the time.  Especially on a tablet it will burn through the battery life. =(

Plus then you get to put exactly what you want on the attacks you want without having to do any scripting. =)


having the same here https://github.com/outbrain/ob1k/blob/4deae27fbf44bdee28273401151b8cfc09271805/ob1k-http/src/main/java/com/outbrain/ob1k/http/utils/ComposableFutureAdapter.java
maybe we should centralize?


You can remove the line if you want. It does nothing if its set to false (which it is).


What even.


I will punt on this...  I don't know enough to say what is best, and we should tackle that elsewhere if necessary


A banda del comentari sobre l'expressió booleana, crec que ara s'entén molt millor el propòsit.


Smart!  That is a great thought - it would make it available anywhere else it may be needed.  As for best practices, I need to defer to others...

I am using the Diagnostic codes throughout the eye form and not having it coded right up front adds steps when auto building Imp/Plan and sending codes to the billing module.  If the user enters the correct code up front the first time, it saves a lot of typing and clicking, for every future encounter.


Shouldn't this be _before_ you get the pointer?


Besides that, looks good.


Add todo here to indicate when object sizes distribution is added, we will support multiple sizes here.


You should be clearing the que.


Nice, just led_off is better.


duckduckgo_search_engine should not get the value of duck_duck_search_engine


thanks @dsmiley! i just pushed a new patch with most of your changes.


It works!
It's hacky
But it works perfectly


Also add the number of streams into the metadata.


Don't understand this one.

As I see it, it would be something like:
```js
{
  _: this.meta.toSpec(),
  v: this.value,
  f: this.formatted
}
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18733](https://teamcity.mesosphere.io/viewLog.html?buildId=158842&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:03


Why


You don't need the trailing `**`


private


Sorry, this commit is related to #173


"The `release-cordova` command..."


@jensens please either fix or revert: http://jenkins.plone.org/job/plone-5.1-python-2.7-robot/


seems all OK


I really like that the default behaviour in Swift is the break without having to add the `break` line. This makes using case statements more attractive and easier to read! I really like it!


Just for cleanliness, can you tag this as a shell command via "```shell"


Did you intend to hyperlink the term "update contents" here instead of the `cordova prepare` command?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18734](https://teamcity.mesosphere.io/viewLog.html?buildId=158859&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:05:30


komentarz


TeamCity LabKey :: 16.1 Release :: Community :: CDS postgres 9.5 [Build 36](https://teamcity.labkey.org/viewLog.html?buildId=309277&buildTypeId=LabKey_161Release_Community_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 15, passed: 36 Build time: 01:20:10
### Failed tests
```
org.labkey.test.tests.cds.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.cds.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.cds.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.cds.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.cds.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.cds.CDSVisualizationTest.verifyLogGutterPlot: <no details avaliable>

org.labkey.test.tests.cds.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.cds.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.cds.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.cds.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.cds.CDSVisualizationTest.verifyTimeAxisFilter: <no details avaliable>

##### there are 5 more failed tests, see build details
```


Did you want to wrap the XML snippet in backticks to denote them as code?


Shouldn't this be a hashset?


Line 88 is a breaking change. Causes svg clipPath to break (for any svg using clipPath). See: #7467


ik it was voted in


Done.


Fixed.


You should be able to just do

```js
[readableStreamControllerCancelSymbol]() {
  ...
}
```

inside the class declaration.


How come people favor interpolation over concatenation these days?

I think that interpolation is prone to errors and looks really awkward when you've got just 2 things.


The "view" object themselves are NOT read-only, each worker should generate a view for itself and have exclusive access to it, and each worker thread will use one view sequentially to generate multiple slices.

If you share a view across all workers, your program will likely crash with access violations.


Isn't the flag name `--targetBinaryVersion`?


I've just added periods to all of them.  There isn't a policy, but I certainly agree that consistency at least within one class is a good thing.


Worked with George Skrapits.


It is really interesting to know that iOS will populate the table view with only the visible cells. Maaning on an iPhone 5 you should be able to see 13 rows and as you scroll down the list there is one more cell loaded as you have a cell at the top and bottom half visible. making a total of 14 cells loaded. as you keep going the cell at the top is reused to the next peace of data and is displayed again at the bottom. Cool!


@rhl, good point.  I'll add a note to the Python plugin class.

I've also created DM-5405 to track a fix for the lack of support for CCD forced photometry.


Meaning, spelling and grammar is OK
I will pull, then fix up where fractal name is not the same as list.hpp name


More syntactically lightweight when you have more than two things, similarity to other languages, doesn't require the `any2stringadd` implicit.


love that :D


I thought you couldn't check contains() for a Set


Would you be able to take over making the examples better?


@Grawl fixed 38a7436


## Task 1

Similar to your previous assignment, write a program to count word usage in Chapter 1 of The Origin of Species (you are free to use most/all of that your code to do similar tasks).  Have this program print out, in decreasing order (most common to least common) the 20 most common words and the count of each word used. Your program should contain a `main` loop and an `ifmain` statement, it should be formatted correctly, and you should **use `argparse`** to get the name of the input and output files from the user.  You may use any type of dictionary object in your code.  You should print your Top 20 results to the screen using the `.format()` string method, and your results should be prettily spaced (again, using `.format()`) so that the column of words and word counts are justified left, like so:

- [ ] Program is correctly formatted (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program uses `argparse` to get input and output files (1.0 pt)
- [ ] Program uses any sort of dictionary to correctly count words in the text and returns the correct words and their counts for the 20 most common words (3 pts.)

## Task 2

Write a program that uses `argparse` to get the name of the tab-delimited file you created above from the user.  Read that file into your program, and determine count of all words that start with the letter "t" (or "T").  Using the `os.path` module, write these t-starting words to a new tab-delimited file that has the same name as the input file, but with "T-words" prepended to the input filename.  For example, if the input filename is "all-word-counts.txt", then your output file of t-words should be "T-words-all-word-counts.txt".  You can accomplish these filename manipulations using the `os.path` module. Your program should contain a `main` loop and an `ifmain` statement, and it should be formatted correctly.

- [ ] Program is correctly formatted (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program uses `argparse` to get the input filename (1.0 pt)
- [ ] Program correctly writes the requested file containing words that start with "T" and the count of these words (3 pts.)

## Task 3

Getting the t-words is all good, but your boss wants you to output a separate file for words that start with all letters of the alphabet.  So, modify your program from Task 2 to output 26 files, the names of which should begin with the appropriate letter of the alphabet (e.g. `A-words-all-word-counts.txt`, `B-words-all-word-counts.txt`, `C-words-all-word-counts.txt`) and the contents of which should be those words that start with the corresponding letter and the counts of those words in Darwin's text.  Format each file, as above, in tab-delimited format. Your program should contain a `main` loop and an `ifmain` statement, and it should be formatted correctly.

- [ ] Program is correctly formatted (0.5 pt)
- [ ] Program includes `main()` function and "ifmain" statement (0.5 pt)
- [ ] Program uses `argparse` to get the input filename (1.0 pt)
- [ ] Program correctly writes the requested files, names according to letters of the alphabet, where each file contains words that start with the corresponding alphabet letter, and the count of these words (3 pts.)


My earlier suggestion was that we still need to take payload_bytes and payload_string for this function, to keep it really simple here.

MemoryView is only necessary for those callers that need to take slices out of an array.

The paradigm looks like this: MultiThreaded workers create a memoryview on a big buffer, for each object it needs to send, it "slices" the big buffer using the memoryview into bytes and string arrays, then pass the arrays to this function.


at this point, given the number of branches that IndexType creates in the code, it'd probably be better to create 2 classes and use polymorphism to remove those branches


Heading still says "internal methods". But, let's just move this underneath "Readable Stream BYOB Controller Abstract Operations", since the whole class is kind of an implementation detail of the controller?


Thanks for this patch (I submitted #79 a while ago requesting it), but it makes the text far too large.  It has to fit 80 columns, because that's the assumption of the telnet server.  On my device (Moto G 2014, stock ROM, no special changes), the console is only 48 columns across with this patch.  So nearly everything wraps and has a ragged edge.  Note that I do use Large text size in the Settings menu, that could have something to do with it...

I see that you used hardcoded font sizes (albeit "scale independent"), I'm sure they look great on some devices, but not mine :-) I'd suggest that you divide the actual device's pixel width by 80 to come up with the base font width instead.


Task 1: Program gives the top 20 word list in expected format.
It includes ifmain statement.
Task 2: Program runs fine and gives the output file but output file does not have any content in it (count).
It also includes ifmain statement.
Task 3: Program runs fine and gives output as well for all (a-z) but most of them does not have content inside the folder (count value) and if it has content they are not the all words from that alphabet. I’m not able to figure it out the problem in the code. May b Dr.Brant will help.
It also contains ifmain statement.


A couple of final comments for memory view related logic. (and rest looks good to me now!)


OK. I'll try to today.


Hooray :)


@mernst requested this enhancement.  I will update the format doc and improve the comment.


How can we make it compatible with Docker 1.10? In Docker 1.10, ``docker -d`` changed to ``docker daemon``.


Done and tested on WINDOWS


Very interesting!
I didn't found any place to leave a comment, so I choose the git commit comments now :)

I wonder if something has changed in the meantime related to the article you wrote (exactly 8 month ago :)
Did you switched some layers at OpenStax / CNX?
Or did you changed your mind in some points?

I had and have the same idea of make it really easy, especially for non technical users, to change content or provide feedback with a minimal setup of a server/infrastructure and keeping all the data in GitHub.

I realized that the amazing bookeditor isn't really active anymore: https://github.com/oerpub/github-bookeditor
Is it just done or do you switch to a different tool?

Another awesome tool: https://github.com/philschatz/gh-board
Do you use it in production at your company or so? If yes, from what did you switched: Trello, Jira?

There are also lots of interesting repos in the [https://github.com/openstax](openstax) organization.
Unfortunately I don't understand some of them in the context of the big picture of the openstax infrastructure/architecture. The tutor project looks very interesting and I found this URL: tutor.openstax.org and I signed up, but the dashboard is empty (no courses). So either it's not launched yet or I missed something.


Personally, I would have used a simple macro for adding the base stats, like I did in Red++ with the 3 byte pointers for trainer pics. It's just annoying to dbw Bank(DratiniBaseStats),DratiniBaseStats each time when you could just do like, idk, add_bst DratiniBaseStats and have a cleaner list with less to have to type. Seems like it would be reasonable to save time and effort when you're eventually dealing with over 700 entries lol.


This works perfectly.  Tested over several calls.


In a previous commit I wrapped `update_listings` in try/except which basically fixes this. Should be good to close.


The TAG should be updated to match the class name


Would it make sense to collect these Utils methods into a UrlDeviceBuilder?  It'd be great if we could avoid the setters and make UrlDevice immutable.


Should we also change the URL shortener endpoint with debug view enabled?


Let's name these URL constants PROD_URL/DEV_URL and find a way to share them with UrlShortenerClient


PwoDiscoveryService -> UrlDeviceDiscoveryService?


Created test.txt


I'm curious to the purpose of this


PWO_METADATA_KEY is deprecated now, right?  Let's rename it DEPRECATED_PWO_METADATA_KEY


We should rename this to remove "Pwo".  Maybe UrlDeviceDiscoveryListener?  (IMO "UrlDeviceResponseCallback" sounds like it's the UrlDevice responding, which is incorrect)


Sorry for not resume all the work on one commit.


Entenc que el log hauria de referir-se al fitxer `reply_tancat.py` enlloc del `reply_reobrint.py`, oi?


Bean, Entitycache, file_entity were all missing.  This prevented me from bootstraping the site.  I re-added them and pushed to master.


Its just a unit test, though, and my thoughts about it are probably irrelevant: The apostrophs look like accent graphs on whitespace. I've seen that a few times before, probably since a real apostroph is not available on a german keyboard... and had a lot of "fun" with it...  I would recommend using U+2019 (e2 80 99) RIGHT SINGLE QUOTATION MARK to avoid conflicts of any kind. Seems I cannot really post the character itself here: (’) looks like a simple singe quote, but isn't.


I updated this comment.


It was correct before. This should be identity. Else multiplication with m_view will almost nullify all m_view contribution.


Should this set an error code that can be retrieved via `ERR_get_error` or similar? I'm guessing some folks will get a NULL and suspect an error.

We also often tell people to provide the error code on failure. We also tell them they can print the error code they retrieve with:

    openssl errstr 0xNNNN


Barvoooo :)


2097-EP-8-5 (kbenne) - i386-Windows-7-VisualStudio-12: OK (2358 of 2398 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.33%25-yellow.svg)


This reference should also be adorable-api. :disappointed:


great, thank you!


Només perquè en quedi constància en algun lloc, podries explicar per què no cal aquest fitxer?

Crec entendre que el codi que implementa la lògica de reobrir tiquets és a `reply_reobrint.py` i aquest té pinta de ser un intent anterior de fer el mateix. Però seria interessant que ho confirmis.


Never made a pull request before and have little time to do it now.  If you want to do it, please do.  I don't mind.


I'm satisfied