It's also hard to read the diff and understand what's going on when there are a dozen whitespace changes mixed in with the actual change. If you're going to fix whitespace or formatting, please make a separate commit just for that. `git diff` and `git add -p` can help you with this.


sigh have you read the comments? https://github.com/un1versal/KVIrc/commit/d72002946c287e011b5dff997e3ea66ba58e1b6c


missing a test for rdata_to_str


it doesn't help. can you describe process of storing in this way and what happens during concurrent requests?


Encore un...


Like it.. Looks good!


remove your cookies


Et de trois !


I would argue for matching the repository:
    salesforce-marketingcloud/fuelsdk-php

And fixing the description, as well as homepage URL..


Also, why is the nrmse check allowed to be so large?

Merging either way, as these can be addressed later


add some punctuation here


Given the `FixIncludesBase` change, you can just say:

    self.assertEqual(self.stdout_stub.getvalue(), diff_expect)


ups...
> Le 14 mars 2016 à 21:25, Hassan <notifications@github.com> a écrit :
>
> remove your cookies
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/camilleeyries/AGAR-XPBOT/commit/e872ead0ae4f9d1713d9924d0bf9f405b3ecb0fc#commitcomment-16691198>.
>


thats just an artifact from refactoring the csv reader. I havnt completely gotten the dom writer figured out yet


 "anyone who lost the campaign can not get in anymore"
 -unclear what is meant by "lost" in this context


Hey @geraldb,

Just remind you about the Datafile

:)


fixed in next commit


Please add a `@todo` here to make it easier to identify as a temporary class


what was the outcome? I like overriding `LOGGING` locally, though could be convinced to give that up for a compelling reason


missing a test for rdata_to_str


Please name the virtual file 'unified_diff.cc', there may be logic in fix_includes using the filename to make decisions (I don't think there is, here, but it would make me sleep better :-))


Thanks!  Sorry I totally missed the version bump.
Thanks for the fix.


Ooopppss !


Oh, you're right. I might have mixed up the logic. I'll take another look.


The project is pretty much dead but if this works it would be cool to get
it merged.

On Mon, Mar 14, 2016, 21:21 genaside <notifications@github.com> wrote:

> no, but if u want me to do one, I will. I am pretty much gave up on the
> project since there is so much I can do with php.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/genaside/PHPTracker/commit/6ced388340b81209ea67f2a25e85e84e6dd38f98#commitcomment-16691090>
> .
>


Use new `Folder::get()->byID()` notation, we shouldn't use deprecated functionality in new code


@IgorMaksymov ok


In PHP  single catch block can handle more than one type of exception, it will give us better performance and less duplication.

For example:

```
try  {
	$actionResponse = $this->executeResoruceAction(
		$router->getMatchedController(),
		$router->getMatchedAction(),
		$router->getMatchedRouteParameters()
	);

	if ($actionResponse === false) {
		$response->setCode(404);
	} else {
		$response->setBody($actionResponse);
	}
} catch(\APIJet\CustomException $e) {
	$response->setCode($e->getHttpCode());
	$response->setBody($e->getErrorBody());
} catch(\Exception $e) {
	$response->setCode(500);
}
```


Yes, it was.


looks good.


You can simplify the test a lot by moving `stdout` redirection into the base class's `setUp`. The entire test case basically collapses away when you do that.


another artifact


The future is now


to be able to take advantage of the autoloader it must be “APIJet” instead  of “Api”


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 19066](https://teamcity.mesosphere.io/viewLog.html?buildId=164288&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 262 Build time: 00:04:54


Task specifies generation of the first n Fibonacci numbers but output is determined by only the nth Fibonacci number. F(n) can be calculated using the proposed O(n) complexity iterative method without storing the sequence and therefore without the need to allocate memory for an array.

Binet's formula, Fn = φn - ψn⁄φn - ψn, was also considered but the floating point precision produced inaccurate results for larger values of n.


Ah, yeah, looks like we need a "long" version of `rdata_to_str_string()`.


Add this back, not sure why it was removed, but it's distracting for review.


I get this file is supposed to add some sort of rows to the DOM somewhere, but it's pretty hard to follow. The data (`this.girls` and `this.boys`) seems to be assumed to be there without being set. There's a template variable that holds a function, but it doesn't do anything.

I'd suggest making a practice of commenting your code to explain what it is/will be. You will rarely be the only one looking at your code, and other people looking at your code aren't going to know your thought process behind the way things are structured and named (especially with overly general names). It will also help you remember what was going on in your head if you ever have to step away from your code for a while.


@yihui This is a great feature that I'm really looking forward to use. Does this mean that it's currently on the todo list or that you've already got a working solution (to be realeased in 1.13)? Also, thank you for an already excellent package :)


In the order for easy understandable class name should be CustomException.
For better readability I prefer to call it “CustomException” instead of “ApiException”


yes, we will.
It was first step of the project. (Because of Dima's expectations)
Right now, we will migrate to Spring and include it to our project. =)


New array syntax


BTW, I had locally also changed the capitalisation of the package's folder name, but this is not reflected here! Why is that?

Or, is this change not really required?


missing test for rdata_to_str


We might want to specify both URLs at once so that this won't happen again after an update.


Added two tools to support MapR audit log,
1. id resolver
2. log parsert


The wiki engine doesn't allow `prependHTML` or `addHTML` if the HTML to be prepended or added includes JavaScript, does it?


No it didn't change. Only a `-` was added to the option. I did not manually change the file, it's mostly a copy-paste from a more often updated manifest


Make sense. :+1:
Should we perhaps put the phrase "Constants for "<NULL>", "<ANY>" and "<ANY_UNMATCHED>" are available in the `MappingConstants` class" from further below into an info box? People don't tend to scan for code examples and info boxes first before trying stuff out and only then read the fine print. (At least it's the case for me :grin:)


Is there any possibility to add a refresh button in toolbar?


why delete?


Line: 95:  "This will automatically convert the funding goal into wei"
-unclear (to me) how the suffix ether converts the value to wei in this code example.
Or further why wei is not referenced anywhere but finney is


Is dynTicket redundant?  Doesn't the isDynamic flag determine whether the ticket pointer is to the staticTicket buffer or to dynamic storage?


Sorry, I meant the `LevelOfParallelism` attribute, which I'm now seeing is only available on the assembly. Open to suggestion, as currently a separate assembly is the only way I'm seeing to test properly.


not sure why we should register and unregister each time the window init/de-init. we already handle if the window is active in OnMessage -> GUI_MSG_REFRESH_LIST.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 19067](https://teamcity.mesosphere.io/viewLog.html?buildId=164326&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 262 Build time: 00:05:26


Indeed, but this was intended.
I wanted the malus for each center pawns to be S(8, 12) * 2

In average, there is 3 pawns on same color as bishop, so to make a difference,
one must use larger values.

There are a few funny things about this bonus

When you have 2B, the total of the BishopPawn penalty for both bishop will be the same,
whether your pawn distribution is 0-6 1-5 2-4 3-3. Maybe this could be improved. Or maybe the mobility is doing the job to complete this.

Also, if you have a single bishop, if you have 3 pawn same color as bishop, the penalty is the same
even if your total pawn number is 3, 4, 5, 6, 7 or 8. This is a bit weird.

The other problem is that this BishopPawn penalty is competing with the Material Imbalance table.
The first is counting pawns on same color as bishop(s), and when there is 2 B,
this exactly overlaps with the general pawn count used in the 2B case in the imbalance table.

Despite all this, it works. Because of all this, it might be impossible to improve.


Renamed


These HAVE_SESSION_TICKET variables should be in descending order of size to help the compiler pack and align them.

byte*
word16
byte


same here


Can we reuse `rdata_from_str_string()` to do the escaping on the input?


This comment seems incorrect now, `operator==` is now doing an inexact comparison.


ok i do it later today


What's wrong?
The names of variables declared class constants and of ANSI constants should be all uppercase with words separated by underscores ("_"). (ANSI constants should be avoided, for ease of debugging.)


Hi
I want to create a button in flask that can take a dynamic variable which it receives from the database and pass that dynamic variable to the argument parameter of a routes function.
The routes function will then use the variable to query the database for information.

I have create the query and the flask form but i cant get the button to pass the dynamic variable to the routes arguments.

Any ideas?
Thanks


Issue5276 (wfbuhl) - x86_64-MacOS-10.9-clang: OK (2115 of 2132 tests passed, 21 test warnings)

 * 18 tests had: AUD diffs.
 * 11 tests had: RDD diffs.
 * 20 tests had: EIO diffs.
 * 16 tests had: ESO big diffs.
 * 11 tests had: Table big diffs.
 * 6 tests had: ERR diffs.
 * 2 tests had: MDD diffs.
 * 2 tests had: MTD diffs.
 * 5 tests had: Table small diffs.
 * 6 tests had: ESO small diffs.
 * 6 tests had: MTR big diffs.
 * 4 tests had: MTR small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.2%25-yellow.svg)


clients -> clients,

open discussion -> open and realistic discussion


You've done such a good job that I have trouble finding any suggestions to make. Here's one, though. When a specific class such as `RelativeLayout` isn't needed for any particular reason, I'd stick with the general `View` interface. That way you have the flexibility to change the class in the XML without needing to update the Java code too.


Changing this requires edits to all the bikeshed include files (https://github.com/tabatkins/bikeshed/tree/master/bikeshed/include) for webplatform to match the special html include files. I think those webplatform are common to other specifications. I don't think we want to change other specifications. If we leave this as html for now then we can decide how we want to handle the different include files. If you need to update the html includes go ahead and make them more inline with webplatform.


Verb tense should be singular to match the singular noun "signature"


Да, действительно, постарались исправить


I heard about volley but I just went with Garrett for the whole retrofit
thing
On Mar 14, 2016 4:13 PM, "Kevin Bohinski" <notifications@github.com> wrote:

> http://developer.android.com/training/volley/simple.html
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/atf1999/News-For-NY-Times/commit/0b460002cb4e9f0a91ee0dabcb1bde5af779de44#commitcomment-16690899>
> .
>


I took this out [b1fa38d](https://github.com/blockchain/My-Wallet-V3-Frontend/commit/b1fa38d8ef09d7035b58877f32635ee5c56a05a4) because elem.css('top', 135 || 95) does nothing anyway, it would need to be elem.css('top', '135px' || '95px'). This is handled with css [here](https://github.com/blockchain/My-Wallet-V3-Frontend/blob/master/assets/css/components/_notifications.scss#L35)


use pytest module instead


The purpose seems to have been to hide normal output that makes it hard to see failing or test output. Please restore that functionality?


Do we have an active use case for earlier C++?
This seems like a decision to be brought up at eng meeting, because it is far easier to do than to undo, and commits us to expectations that we may in the future not want to live up to.


Please don't leave ifdef-ed out code for future reference. This is version control's purpose.


This code appears in https://github.com/probcomp/bayeslite/tree/master/external/weakprng too, is that correct? What's the plan for keeping the various weakprng versions up to date? Perhaps there is an argument for a separate library distribution on which these should depend?


Yes, but the configuration for it may not be turned on.

Ah, yes.  See here:  https://infrastructure.fedoraproject.org/cgit/ansible.git/tree/roles/hotness/templates/hotness.py#n5 the new string is missing.


If this has a huge impact on the performance then it's fine by me, but if so we need to rewrite the `OnMessage` stuff too because the active check is not really necessary.


Associated tests would be helpful.


There is no comma-escape supported. Was there any in boost? Tests would be useful.


Consider -ggdb


Why before the next include, instead of in the original place?


De-novo, or does this deserve to be credited?


@jnappy thank you!


When we use update_fields it is more optimal preservation, because we do not have a restore of the entire record, and only one field changed. But it still two transactions.
When we use
from django.db import transaction
with transaction.atomic():
  product.likes.remove(user)
  product.save()
we have one request to db

I could be wrong, because before that I did not do the optimization like this


unexpected. Are there loggers in test classes in real projects? Or it is matter of taste?


browser standard (aka a web standard to be implemented natively in the browser) -> web standard

[My point is we (or I) don't want a web components library that implements all of the current MathML spec either. I want colors and fonts and borders and stuff to be handled by CSS, I want Content MathML moved to a different document (it might be a standard for software products that want it, but not for the "web" i.e. HTML5/CSS/JS ), etc.]


I agree, but where is the problem? There is 1 Usage, where I'm not sure, what the cause is...


this change seems like a good idea if few people override ```LOGGING``` and otherwise would require more work.  For instance you could have a localsettings variable of loggers/handlers to silence if a dev wants less noise.  Polling other devs to figure out the right use cases.


Just for your information, you are editing the wrong file (it's the original file which shouldn't be edited). You would have to copy the untouched res/values/rr-strings.xml file to res/values-es folder to create the Spanish translation of RR settings there. :)


can you compile with https://github.com/un1versal/KVIrc/commit/d72002946c287e011b5dff997e3ea66ba58e1b6c

with ```<table style=\"white-space: pre-line\">" ````

![capture](https://cloud.githubusercontent.com/assets/3521959/13757544/fa79a5d4-ea1c-11e5-869e-8b0616905fde.PNG)

with ```  ```
![capture](https://cloud.githubusercontent.com/assets/3521959/13757662/7eba8386-ea1d-11e5-99e3-9d53be1896c0.PNG)

with ```"<table>"
![capture](https://cloud.githubusercontent.com/assets/3521959/13759030/44d4a744-ea24-11e5-9d2e-a74b661d6ca2.PNG)

tbh pre-wrap works best here, the breaks are less insane, lest see what user says about the test.


Ah ouai, j'ai réussi à faire un truc du genre, mais je n'ai pas pensé à faire deux variables et juste une condition pour afficher la date et l'heure ou seulement l'heure...
Respect !


typo in section closing tag (mising the `/`)


I can't figure out this regex. The previous version specified what kind of ending it was looking for. This appears to specify a certain type of _beginning_. I would have written the new version as a more generic version of the old: `_\S+$`, i.e. ending with an underscore and then one or more non-whitespace characters.


It is working now in the current development version of knitr. If you are using OS X, you probably need the development version of webshot. See Section 2.8 and 2.9 for more detailed documentation: http://rstudio.github.io/bookdown/html-widgets.html (Please do not share the link in the public yet. Thanks!)


That's sooooooo 80s. or Windows95.  :-)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 19068](https://teamcity.mesosphere.io/viewLog.html?buildId=164330&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 262 Build time: 00:04:57


This is a really good change! :+1:


`https` please

https://api.bitcoincharts.com/v1/weighted_prices.json


Je vois que vous avez réussi à utiliser la librairie momentjs finalement, cool !
Je n'ai même pas essayé...


Added here:  https://infrastructure.fedoraproject.org/cgit/ansible.git/commit/roles/hotness/templates/hotness.py?id=a8a2066c38cf0165d638f1e86ea8e3d85e72a046


How this is managing suffix replacement is also confusing me. You're referencing capturing group 2, but there's only one set of parenthesis. Also, the suffix itself isn't described... I suspect there are cases for which this breaks.


@rwinch "Improved Workspace Setup" points to already listed ```MongoOperationsSessionRepository``` PR.


latex-documentation (michael-okeefe) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2158 of 2167 tests passed, 19 test warnings)

 * 18 tests had: AUD diffs.
 * 11 tests had: RDD diffs.
 * 10 tests had: EIO diffs.
 * 6 tests had: ERR diffs.
 * 9 tests had: ESO big diffs.
 * 2 tests had: MDD diffs.
 * 2 tests had: MTD diffs.
 * 7 tests had: Table big diffs.
 * 3 tests had: ESO small diffs.
 * 2 tests had: MTR small diffs.
 * 1 test had: Table small diffs.
 * 4 tests had: MTR big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


Also, consider this a reminder that the purpose of pull requests is code review. The code should be reviewed and the pull requests merged by someone who understands the code being patched. I don't doubt that the intent of this patch was good, but the point of reviewing it is so that someone who really knows it can make sure there aren't unintended consequences. In this case Ben or Reilly should be merging the pull requests; I missed the breakage this caused, but Ben caught it.


@ashleylevs  I see some of your corrections. There is still have a hammer on line 52 in your index.html


CSS went to smaller modular standards a while ago. I bet the w3c, css folks, etc. would easily support MathML doing so also.


Is there any chance to update CURL for Win32 to a newer version? The current version seems to have a bug when reading gzipped, chunked content (retrieved content is disturbed) I have tested 1.47.0 and there has no been any errors anymore. Thanks!


On Wednesday I'll upload a new version. This should fix this too and will allow concurrent boss bars.


Oh nice, this gets rid of the `mut`, which I had totally missed so far (I guess you could used `.last` or something like that). Can you make this function take a reference to `parser`? (It's cleaner since there is no reason I can see for it to own the value.)


@knowuh What was the intent with this version number? Not sure what the next one should be. I would have assumed that after 1.9 we'd have 1.10?


Not inside a snippet.


These will stop working soon; the code has moved to https://github.com/distcc/distcc


With the current way how it works you will see a message that creating the feedback failed. But you dont know what caused it, you even dont see the message you passed there to the exception. So the next try-catch block doesnt even know that the experiment was not found, why not just pass e in the problematic catch block ? This would result in the complete exception beeing logged, with the message passed to the FeedbackException AND the cause (if it exists)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 19069](https://teamcity.mesosphere.io/viewLog.html?buildId=164358&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 262 Build time: 00:05:45


@dlovellrw this was a hot fix, and the patch was pretty big, so I tried to kept as small as possible.
I will update the comment. thanks for the poke.


NewChangelogHeader (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Anthony, you know that English is not my mother language. So, in this context, 'rub' is what Aladdin does to get some genius get out of the lamp. If you are looking for a better name, then can I suggest 'ignite' instead? At least, this would be nicely aligned with the direction given by our leaders for the year. IMHO, 'ignite' would make a better name than 'prepare'. Up to you...


Still need to update CUT and SURF to handle the tiles that have moved around, and need to add an animation for Whirlpool and Waterfall tiles. Possibly other things too.


I'm getting a:
```
=======> ERROR: Footprint mismatch found:
MISSING   -rw-r--r--      root/root       usr/lib/python2.7/site-packages/youtube_dl-2016.03.14-py2.7.egg-info
NEW       drwxr-xr-x      root/root       usr/lib/python2.7/site-packages/youtube_dl-2016.3.14-py2.7.egg-info/
NEW       -rw-r--r--      root/root       usr/lib/python2.7/site-packages/youtube_dl-2016.3.14-py2.7.egg-info/PKG-INFO
NEW       -rw-r--r--      root/root       usr/lib/python2.7/site-packages/youtube_dl-2016.3.14-py2.7.egg-info/SOURCES.txt
NEW       -rw-r--r--      root/root       usr/lib/python2.7/site-packages/youtube_dl-2016.3.14-py2.7.egg-info/dependency_links.txt
NEW       -rw-r--r--      root/root       usr/lib/python2.7/site-packages/youtube_dl-2016.3.14-py2.7.egg-info/entry_points.txt
NEW       -rw-r--r--      root/root       usr/lib/python2.7/site-packages/youtube_dl-2016.3.14-py2.7.egg-info/top_level.txt
```


develop (mjwitte) - x86_64-MacOS-10.9-clang: OK (1579 of 1579 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The "may"s here make it sound like this could be non-deterministic.  Instead our intention was to define this as entirely deterministic.  How about replacing "will not result in ..." with "will have no effect on the behavior of that pointer for as long as it is active".  Or if you prefer, "will not result in the user agent aborting or suppressing any default touch behavior for that touch".


vendors -> vendor


Mind opening a pull request? Take a look at https://github.com/Homebrew/homebrew/blob/master/share/doc/homebrew/How-To-Open-a-Homebrew-Pull-Request-(and-get-it-merged).md and let us know if you have any questions!


look at the problematic try catch block, and you will see. that i can't just pass e...


Your offsets into imagedata only ever point to the first pixel.


@jnappy thank you!


sayHello1 and sayGoodBye1 are not functions. sayHello and sayGoodBye are functions. Check in newer commits.


Comment fixed https://github.com/rails/rails/commit/f85bbed4cdc1bdfd1e0dbd97bce9db81e44cbd11


? There is no e to pass


Actually, I thought more about other iterators that may be index by integer, but not efficiently (e.g. `Dict` with int keys) or not in range `1:length(A)` (e.g. `OffsetArray`s). For this particular example I kept in mind a kind of `IndexedSet` (i.e. a `Set` that supports `getindex` and `eachindex`). This would allow both - efficient iteration (for every tag...) and lookup (is this keyword a tag?). This is a little bit contrived, but hopefully you've got the idea.

Does it make sense (both - in this specific case and in general) or `for i=1:length(A)` should be preferred whenever `i` is provably an integer?


latex-documentation (michael-okeefe) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Second I am commenting on the line i am talking about.


Code works for both async =True and async = False.


what about solaris and cygwin? :)


Sorry brah.


what about solaris and cygwin?


Yeah, too bad.


Thanks for catching that...any chance you'd send a PR?


Could you leave this off? I have another breaking change I want to sneak in.


the latter sounds good to me. will change and force-push (already did for the missing `/`)


Nooooonnnnnn, là tu me déçois vraiment !!!


yeah, we need namespace creation for origin tests to do project requests so we have our service accounts and associated users


I think that moodle link was to a MathJax bug, probably not using native webkit MathML, right? It references problems from the previous Spring. When did webkit/Safari change to stop drawing (some?) lines whose width was less than a pixel? I wouldn't add a link for this because there isn't a good one, because no one filed a bug. If we're challenged on it, we could download some old webkit nightly builds (though we might need a Mac running a prior OS to run them, perhaps?) and we could do some tests. The radical overbars definitely disappeared for at least many months, and no one filed a bug.


aa


This should be a `JVMCIError.shouldNotReachHere`.


"columnDefinitions" isn't going to change between iterations of the do while loop so, while unlikely it will be null, if "columnDefinitions" does happen to be null then it will fetch each of the rows and then never add them. Would be better to handle "columnDefinitions" being null outside of the loop.


for (int i=0; i<100; i++) {


sorry @drewr forgot to merge master


force-pushed new (slightly modified) wording


`Since Cinder can handle a variety of block storage technologies....`


The definition and usage have always been parsed the same, but it is definitely an undocumented feature.


Done in 1e18fd7748de957e6d94cf37fbb1c0c9a7f42ec7.


Duplicate: https://github.com/dotnet/corefx/blob/master/src/System.Globalization/tests/CompareInfo/CompareInfoTests.IndexOf.cs#L20


<s>polyfills</s> - I don't think the reader will understand why you include this but with a strikethrough. I'm not sure, but I'm guessing you are thinking that these converters are not really polyfills in some technical sense. I think you should either explain all that if it's necessary to the main blog post, or else just omit the "<s>polyfills</s>". I vote for the latter. (You're not really arguing that the problem is that converters are not good enough. Later you almost imply the opposite.)


The following 10-line shell script will do this in general -- you can apply it to any program you want, without having to change that program.  Is it really important to build that function into every build script we write?  Or is there something specific about Crosscat that you want to hide -- in which case, what is that specific thing?

    #!/bin/sh
    set -Ceu
    t=
    clean ()
    {
        if [ -n "$t" ]; then rm -f "$t" || :; fi
    }
    trap clean EXIT HUP INT TERM
    t=`mktemp -t output.XXXXXX`
    if "$@" >"$t" 2>&1; then :; else s=$?; cat "$t"; exit $s; done

Generally, I *want* to see all the build output, especially to see if there's something funny about it.


@Residentcl it is done here  #851. Can you test it?


May now fit on one line... unsure of value of the #end of tests comment either. Thanks for the fix!


Not sure where to ask this question, but when I follow these instructions ( raspberry pi) I get almost everything done until the make install.  That seems to progress fine until it gives the following error
Makefile:217 recipe for target 'install-lib' failed
make: *** [install-lib] Error 1

I have started with a clean build and still this happens.  I am not sure what to do to fix it


@Underground78  Maybe we should login at this point when new credentials are set.


GCC 4.5, default compiler on NetBSD 6, doesn't support -std=c++03.

I don't think it's really hard to change this one way or another.  The difference between the two standards for our purposes is negligible.


Currently not working:
a) use a dump path
-so i cant access to the dump file (because there isn’t anyone)
b) should add that it create a dump path
but in the fluxion (master) it property work


It might be worthwhile to have just one definition of this constant?  Maybe here in GeographyPoint since Geography depends on it.


**FAILURE** - TeamCity HotRod C# Client :: Pull requests monitor - WIN_S2012 [Build 102](http://ci.infinispan.org/viewLog.html?buildId=37452&buildTypeId=HotRodCSharp_PullRequestsMonitorWinS2012&guest=1) for 42e03a2d0e298c684a83f46d411fc40f9cb3368b
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:14:22

Process exited with code 1


At first glance I was a bit confused by this comment. Could it be phrased a bit to more clearly explain that it won't map to to Decimal or Date Avro types and instead just treats them as strings (like the underlying getPrimitiveAvroTypeFromCassandraType does)?


I can't defend this. Its indefensible.  My first guess is that the version string isn't being parsed as an int, and this was some hack workaround.  But that doesn't explain why 1.95 instead of some other string. What ever is happening here, I am shamed.


This one can't use the macro?


That would be a very thorough test, for sure, but maybe more than we really need.

I was thinking of something like

```C#
var workerId = TestExecutionContext.CurrentContext.WorkerId;
Assert.That(workerId != null || !runningUnderTestWorker);
```

Admittedly, it doesn't test much but it's a start, especially since we almost always run in parallel. By starting with small bits we can easily do we may come up with more later.

If you prefer to end this, we can add some tests after the merge. :-)


nit: replace "gesture" with "sequence" or something similar, or move the "for example" into a note.  We probably shouldn't introduce the first use of the scary-g-word in normative text without checking first with MS folks ;-)


Is there a expurious + sign ?


> I think that moodle link was to a MathJax bug, probably not using native webkit MathML, right?

I wondered about that, myself, but the About MathJax box shows that the NativeMML output is loaded (and that would only be the case if the NativeMML output hadn't been selected at some point in the session).  Also, the spacing of the fraction is not what MathJax would have generated.  So I think it *is* NativeMML output.  but I can't be sure.


Sure :)


You don't need that you can just use LOG4J and set the right level in the LOG4J file as done in RestComm SIP Servlets: see line 2 and 3 of
https://github.com/RestComm/sip-servlets/blob/master/build/release/mss-sip-stack.properties#L2


One way to do it might be pass the variable to template, and insert that variable inside the href of an <a> element, like this

```
<a href="/home?var={{ your_var_here }}>Click me</a>
```

Looks like your making great progress on Flask beyond the Learning Flask course! If you have more questions about building Flask apps, I recommend you join Stack Overflow and ask there. They have a great community of knowledgeable developers who can help you out.

Good luck!


bizarre... dunno how I overlooked those.

But... thanks!


Issue5276 (wfbuhl) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2153 of 2170 tests passed, 21 test warnings)

 * 18 tests had: AUD diffs.
 * 11 tests had: RDD diffs.
 * 20 tests had: EIO diffs.
 * 6 tests had: ERR diffs.
 * 16 tests had: ESO big diffs.
 * 2 tests had: MDD diffs.
 * 2 tests had: MTD diffs.
 * 11 tests had: Table big diffs.
 * 5 tests had: Table small diffs.
 * 6 tests had: ESO small diffs.
 * 6 tests had: MTR big diffs.
 * 3 tests had: MTR small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.22%25-yellow.svg)


Bug - need space before ].


No, this commit is fine as is. Just for future reference.

On Mon, Mar 14, 2016 at 08:39:48AM -0700, bmw9t wrote:
>Right - sorry! Not as familiar with Jekyll's structure as I should be. I just wrote Jeri and Fred about this. I'll add _site to the .gitignore section in the future. Did you want me to amend this commit in any way?
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/programminghistorian/ph-submissions/commit/d6aed61f3a80bd27385b06039eebed55ff2f1b2f#commitcomment-16683695


This is a function that version control can serve, but OK, if you like.  Done in a79e39b5051b27c5b17e28db3d360b94ba445dda.


We could just keep incrementing the i separately, use the new macro here too and inline GetFirstInputPos.
Minor nit, though.


` provide a mapping between cinder storage components, like volumes and snapshots, and the related zenpack components like LVM volumes and Ceph RBDs.`


Bei Homematic nennen sich die readings drive-up und drive-down


This is not OK. With the last commit, the widget no longer has the auto commit check box.

`gui.auto_commit` returns the box into which the report button has to be moved to be aligned with the apply button. As I suggested above, and in that other PR:

    box = gui.auto_commit(self.controlArea, self, "autocommit", "Apply",
                          checkbox_label="Apply on any change")
    gui.separator(box, 20)
    box.layout().addWidget(self.report_button)

(I haven't run this code (I'm working on something else now), but I guess this is it.)


вот тут баги :-1:


> I think that moodle link was to a MathJax bug, probably not using native webkit MathML, right?

I confirmed the bug on Safari 8 [saucelabs capture, look towards the very end](https://saucelabs.com/beta/tests/95c420195a134fae9fe332a4deded25) using that fraction example and NativeMML (MathJax was fine). It's fixed in Safari 9.1


Yes, or the updater can do so in future. Feel free to improve this.


Hey I added the API plugin and that made that problem go away. So must just be when not using an API plugin.


Which line? The one that is filtering out the removed items? Thea idea of filtering early means we never have to deal with removed items in the heap (like in `pop`).  If we are iterating over _data we can just as well do some work ;)


We have an opposing preference: I prefer to be notified of things only if they might be relevant to me. Ideally, the only response to building would be "okay, I've put the built stuff here" in normal operation. That is enough people's preference that e.g. py.test makes the decision not to show stdout or stderr from tests unless they have failed.

If there is "something funny" that you might detect by looking at this output, then please try to codify that in a way that we can automatically check, so as to be able to share that with those less well versed in this process than you are?


I guess this probably should've gone outside of `GEANY_PRIVATE` since it was (technically) part of the plugin API, though it wasn't accessible on Windows ever or Linux since linkage-cleanup changes. I might make a patch to fix #964 that would also undocument this global variable.


Issue5276 (wfbuhl) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Then please leave as is.


new db config


я хуесос


>  I don't think the reader will understand why you include this but with a strikethrough.

Thanks for catching that (there used to be an explanation in there at some point).


Broken link


Thoughts on offering the ability to select the charset to use?


I suspect they'll want this much higher up in the profile, but let's [see what Adam says](https://github.com/FAC-GM/app/issues/341#issuecomment-196518785)


[Fix for Jekyll 2 → 3](https://github.com/jekyll/jekyll/issues/4145#issuecomment-158140960)


its for xcore blinscan and yes its works


Can you add a functional test case to validate it works end to end?.
How you consider an scenario where a config makes a reference to a global element in the XML and the global element uses @ConfigName? How would that work if the global element is shared? i.e: tls-context? How do you realize if the config owns that element or that element can be shared with other configs?


No.  That is Python code; this is C code.  I put it directly in Crosscat, rather than into an external/ directory like in bayeslite, because

- teaching the Crosscat build to look in multiple directories for source files is a pain, and
- it's sufficiently small and unlikely to change that I don't foresee a significant maintenance burden.


Assuming we'll eventually allow multiple `UploadField` instances which use `DropzoneComponent`, how will this work if we override the default options rather than setting them on the Dropzone instance?


You could also have a `<nobr>` (or whatever the modern replacement is) around each channel name, but I'm not going to give you more evil ideas...


**SUCCESS** - TeamCity HotRod C++ Client :: Pull requests monitor - RHEL [Build 526](http://ci.infinispan.org/viewLog.html?buildId=37446&buildTypeId=HotRodCpp_PullRequestsMonitorRhel6&guest=1) for 42e03a2d0e298c684a83f46d411fc40f9cb3368b
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:04:55


this is neat, would be cool to have a few comments explaining the overall flow though


wtf


OK.


But that's not what your suggested change says:

>(with or without `ignoreParenthesized`)

This option only works if `ignoreParenthesized` is set to `false`.


I like the order of A) MathML needs to be dropped from HTML 5, i.e. move it up from C) below. You're not really arguing that that conclusion follows from the other two "What to do next" points. In those you go into a lot of details and personal opinions about server side tag soup being ok, fractions should be eliminated from mathematics, Ojan can't be right, etc., etc. - these might be true but a reader won't always understand or agree, and together they don't give the reason to drop MathML from HTML5. It's more like if we started by dropping the MathML spec from HTML5 so people didn't think the browsers were going to implement it natively (unless we can get e.g. the google blink group to say it will, sometime before hell freezes over, which almost certainly we can't), and then we split the MathML spec into much smaller and more modular pieces, and then integrate many of those pieces with various CSS modules including Houdini stuff, etc., then we could actually talk about your other "What to do next" points, which we can't get to if we're waiting for Godot (the monolithic MathML spec based on 1998 ideas being implemented natively in browsers soon). This is your main argument.


To update this bullet of What's new section? Sure thing.
Just to be sure we're on the same page, this should refer #393 and #417?


@Underground78 hmm at this point we need to update ``m_nLoggedIn`` because framework still thinks provider is log-in


Thanks; fixed here https://github.com/garyrussell/spring-kafka/commit/cf8ea1aa790ebaca1921d9eda0b302118eb595a6

and added a test.


Why did you do this?


noooo


> My point is we (or I) don't want a web components library that implements all of the current MathML spec either.

I agree. The background for this are some suggestions from a standards person who pointed out the eternal battle about what constitutes a "web" standard. If it's just "what's in browsers" then most specs would go out the window. I couldn't figure out a smooth "gist" of that, I guess.


There was no escape in boost either.

I'd be more inclined to delete LoadData altogether and all its users than write tests for it, if there aren't any tests already.


Thanks! It should refer to #417


Can we set a compass variable for the path rather than hardcoding the folder depth everywhere? Not crucial for this PR, but maybe @scott1702 has a few moments?


Hmmm. Copyright on weakprng.h is you, rather than the group, and is 2016. You wrote it in a non-lab context? Consider reassigning?


I originally copied that file to the repo because I thought we could just pull down updates from http://www.iana.org/assignments/dns-parameters/dns-parameters.txt periodically and run `git diff` to see what's been added since the last time we looked at the registry. But since then the stylesheet that IANA uses to generate the plain text format was changed significantly, which makes the diff output useless:

```
 dns-parameters.txt | 1106 +++++++++++++++++++++++++----------------------------
 1 file changed, 530 insertions(+), 576 deletions(-)
```

Since then they started adding a "registration date" field to newly allocated RRTYPEs and in the HTML version (http://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml) the table can be sorted by date. Which is pretty much all I wanted in the first place, anyway.


-g is sufficient for my needs.  Does -ggdb even change anything on a system with dwarf2 debug data?  (This change was only about deleting -pg, and avoiding generating the gmon.out files needlessly, anyway.)


CreateODS.vi conflicted to userlib version of ZLIB


latex-documentation (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1579 of 1579 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.85%25-green.svg)


Yeah good call - I'll do that.


Crosscat has no standard include order.  To keep it fun, I stochastically rolled a die in my head to decide where each include would go.  But it was largely biased toward system header files first, then Crosscat header files, then the current module's header file last.


latex-documentation (michael-okeefe) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1021 of 1021 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-30.56%25-green.svg)


Oh, I see, you're expecting us to have logical release numbering. Well, we don't. I'm changing this back to what works.


latex-documentation (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I vaguely intended to make a pass through everything and sort includes at some point.  But that was getting in the way of the task I was trying to accomplish, so I didn't bother.


Godoc changed, did the intent of this method change?


Unfortunately this is an example of an aedg lib method that is not in the standards gem. It seems you are going to need at least some of the aedg lib.


Shouldn't this be configurable per instance? Assuming we'll want to reuse this component in an `UploadField` context and eventually an `UploadField` list view, it really depends on the `DropzoneComponent` instance how big the thumbnails are.


I wrote it afresh.


I presume it was tested in Boost. I consider this a risky change. Who uses LoadData? I may be in favor of deleting.


Will think about this.


I'm sorry Axel. :(


QR codes on PCB's are cool!


Add a comment why we need the ` + 1`


This should be like `headers_for_authenticated` or something... Need to revisit.


@mnfurtado  ajusta isso!


I'd be glad if somebody could test the food sickness stuff as I don't really have time atm to do it myself


I don't have access to any Windows or Solaris machines, but if you've got a chance to test, I'd like to hear the results.


start: 2016-03-17 18:30


I put that comment there to make changes to the list friendlier to diff.


Fixes https://github.com/twsh/Convertbibliography/issues/3


Working with mocks, nice!


This is definitely shaping up to be a nice cleanup


<nobr> doesnt work imo and we use it in many many places


http://docs.ansible.com/ansible/file_module.html (state=link)


Good point. We need to merge the user passed options with these default, and set them on the instance.


Then please add tests. This is a core component, and deserves the additional safety and documentation that testing provides.


Also friendlier to M-x sort-lines.


# {{ ansible_managed }}


Дык это... А конструктор-то по-прежнему лишний у наследника, он же ничего не делает кроме вызова родительского конструктора.


consider....
```
require 'openstudio-standards'
BTAP::Resources::HVAC.clear_all_hvac_from_model(model)
```

https://github.com/NREL/openstudio-standards/blob/master/openstudio-standards/lib/openstudio-standards/btap/hvac.rb#L29


Noted. I accidentally had this as part of the previous PR, split it out now into its own


Has adding API.verify_credentials(include_email=True) worked for anyone? Been trying this but haven't able to see email in the response.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 19070](https://teamcity.mesosphere.io/viewLog.html?buildId=164461&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 262 Build time: 00:05:07


...но, впрочем, можно двигаться дальше!


Done.
I just now realized that I've commented on my fork :)


Suppose `this.options.minZoom` is 5 and the user tries to set it to 0. Then the final `&& minZoom` clause will fail (because `0 == false`) and the `minZoom` won't be changed.

Because you ensure `minZoom` is set above :point_up_2:, I think you can omit that clause entirely.


It has huge performance impact (measured that, one can even easily see it), especially with async epg data transfer on kodi startup (currently only supported by pvr.hts) where easily tens of thousands events during short time frame come in, causing every 3 seconds (or so) a refresh of the epg grid control of the guide window, even if the window is not active, which makes NO sense, as on activation of the window (as for ll other pvr windows btw) data are refreshed anyway.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 19071](https://teamcity.mesosphere.io/viewLog.html?buildId=164462&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 262 Build time: 00:05:38


I did all this work on the weekend on my own time.  I prefer to keep the copyright on this.


Sorry, I should have gotten back sooner, so you didn't have to write out an explanation after I had worked it out ;)

Yes, the issue was that we were simply comparing numbers, so 1.9.1 is invalid and 1.10 is < 1.9. I made an initial solution that parsed the string, but then I realized it was ugly and am switching to the SemVer solution, as the comment in the code originally suggested. I'll make a PR when that's done.


I get friendliness to diff, but I'm missing something re sort-lines. In any case, active readability is probably more important than diff readability, and these detract, but it's minor. If you want to leave it, fine by me.


This needs to be checked for `None`


solved (or at least achievable), [add the comma also]


What is the harm you're worried about by making this change?


**manjaro-browser-settings** now installs settings for firefox, palemoon, google-chrome and chromium. Replaced in all profiles that were using **manjaro-firefox-settings**
@udev @holmeslinux @napcok @Ste74 @philmmanjaro @Kirek


Anything stopping us from using SCSS vars for colours?


Yeah that shouldn't be using an AssetAdmin constant. I'll fix that.


I think this wants s3://cxar-ato-team/snowplow-hosted-assets here.  SP will get our custom jsonpaths that we wrote from the config.yml 'jsonpath_assets' field.


Maybe; that's more of a description of MySQL behaviour, not Sequelize, as well as my own experience which may be irrelevant. :)

Btw: MySQL discussion of fractional datetimes is here: https://dev.mysql.com/doc/refman/5.6/en/fractional-seconds.html


That `white-space` thing is the replacement for `<nobr>`. It does not work because of a bug in Qt I guess. There was a Qt bug around which mentioned it.


Nvm I'll keep it


That someone will depend on its being c++98, that we will want to use a newer feature, and that there will then be discussions about continuing to support outdated compilers. I do think this is much harder one way than the other. At any rate, if you want to make the change, please bring it up at eng meeting.


but we already do a active check in OnMessage which IMO does nothing if the window is not active.
see https://github.com/xbmc/xbmc/blob/master/xbmc/pvr/windows/GUIWindowPVRGuide.cpp#L358 and below


Part of the problem with the unit test may have been that for event.flags e.g. every line was of the form

<timestamp> ?

so the grep -v got rid of all of them and left only the header in the csv file. Should this case be
caught and dealt with differently (e.g. no csv  file produced and possibly no html file either)?


You should probably use context managers -- see the qemu task for an example


Calling the observers and sending the message tens of thousands of time is expensive and makes no sense if after all this time is wasted IsActive() decides not to refresh. As I said, for the scenario I described not calling the observers/sending the message makes a huge performance difference.


This should point to /getsenic instead, right?


I was reading http://www.w3schools.com/cssref/pr_text_white-space.asp


Sure, no problem!


Can't we have defaults for `spaceKey` and `returnKey`?


Why is this here?  We should not need to add that.


Tooltip size is controlled by Qt and the Qt theme and we must respect that.


I have deleted the echo statement.


As a reader of this code, the difference between the variables `minZoom` and `zoom` is unclear. My first assumption is that `zoom` is the map's current zoom.

Be careful about replacing invalid input with `defaultMinZoom`. Let's check that `minZoom` is either `null` or `undefined` before using `defaultMinZoom`. Calling `map.setMinZoom({pleaseSetItTo: 5})` should fail loudly. (We don't need to add an explicit check for this)

```js
minZoom = minZoom === null || minZoom === undefined ? defaultMinZoom : minZoom;
```


'Something funny' might be, for example, that -DNDEBUG is getting passed to the C++ compiler.  That the confused Python extension build system automatically chose to do that wasted easily an hour of my time; if the build log had been suppressed while I was trying to debug things it would have been many more.  I also spent half an hour trying to figure out how to inspect or change the flags that are passed to the C++ compiler and gave up in frustration.

I'd rather see stdout and stderr from pytest, because tests generally shouldn't touch them...  But it is not standard practice for `python setup.py build` to suppress output, so I don't think, in a script whose sole purpose is to do a clean `python setup.py build` and then run tests, we should change that either.


if the schema sets the flag on the type it will deserialize as string. the schema it can be walked to set it for type :string,but I don't think it will be better than what you did


I'm not sure where this is used, maybe to build auto documentation


@parkan, @bigs  whenever you're free if you could look over this & let me know if I'm barking up the right tree...


Yes, will update the godoc.  It was suggested that usage of any volume other than secret, config map, and downward api should increase the point value.


will do!


duplicate ConfigMap value


This isn't testing that the payload is camelized.  The `ApiError` will contain the camelized payload down inside it, and we have to check that.


Is this value exposed to the user? i18n?


This null undefined business just seems like a bad idea. We should enforce numbers. If we also want a 'reset' method, it should be a different method.


Fixed in b4392fcb683143e0cd34e3dda1eeb3b4b058fec8 -- not inlining because it's used in other places too, see `main.cpp`.


sure, I understand. But on these long tolltips with non-sensible breaks when you try to read you lose tracking easily because your brain normally doesn't expect to see some things which Qt and the Qt theme do in many cases.


looks like you duplicated this line


This looks like a really good start


this object is no longer Immutable as the name suggests.


This is second resolution by default - multiple files can be queued in the same second. Does this cause issues?


@tmcw We've already settled on this convention. It's commonplace -- D3 for instance.


This error message is confusing and uninformative to the user.  What action should a user take when they encounter this message?


http://web.archive.org/web/20120720203911/http://www.stroustrup.com/bs_faq.html#C++03

There is no substantive difference between C++98 and C++03 for our purposes -- no change in language features.


Actually, no ignore me - it's millisecond resolution, which is fine :)


sure, you are right, this would be more or less a problem if we hammering the observable. But please adjust the case `GUI_MSG_REFRESH_LIST` in all `OnMessage` methods and drop everything which is not really necessary e.g. the active check.


@tmcw This is how other mapbox-gl-js style APIs, including `setPaintProperty`, `setLayoutProperty`, and `setZoomBounds` work. If we want to change the convention, we should discuss in a separate ticket.


@danilaml gsl not works with clang 3.7 :/


Already, I saw commit   :stuck_out_tongue_winking_eye:


I think it would be better if these settings were provided per browser setting pkg.
I know, many packages, but is this wise to bundle them all in one?


It is? d3 has a setter/getter convention, not a 'no argument is reset' convention.


It's standard practice to turn on more output, and more immediate output, while debugging, and that should be easy to do here. In standard use though, there is a benefit to being quiet unless something goes wrong. I'd like to maintain that benefit. Build is done as a step in testing, and again I recall that this change was made because the verbose output was hiding something important. Perhaps condition the behavior on the DEBUG environment variable?


ok.


This is a really good change! :+1:


Could we add a NEWS item for this?


Right. Even if web standards aren't just "what's in browsers", they're about standards for the web, not the whole internet or all of computing. The current MathML standard should be broken into pieces and revised for the web, even if it was for a library like MathJax or whatever. We're not just saying it should be dropped as a browser standard, we're saying it should be dropped (or split and modified) as a web standard.


Oh comment at the same time


Good point. Will do.


I'm going to add the avro option in the schema on write but what I did is
still useful for when you didn't create the schema.
On 14 Mar 2016 21:18, "Stefan Bocutiu" <notifications@github.com> wrote:

> if the schema sets the flag on the type it will deserialize as string. the
> schema it can be walked to set it for type :string,but I don't think it
> will be better than what you did
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/eel-sdk/eel/commit/0e93df197788994e101ab6d8c69dec3adb2c35f9#commitcomment-16692427>
> .
>


I tested the string parsing code itself.  Only manual tests (i.e., tests that are not set up to be run automtaically -- they require data files as inputs that are not in the repository) use them.  Nothing else in Crosscat uses it.


Might be safest to define it if not defined.  Here's an ISC licensed version.
http://users.isc.org/~each/doxygen/bind9/ipv6_8h.html#d58766bc924435725a5d6144c2ed076c


Yes :laughing:


I see you set EOL at EOF to be Unix style but what is the EOL for all other lines? I cannot find it here.


Issue5276 (wfbuhl) - i386-Windows-7-VisualStudio-12: OK (2121 of 2138 tests passed, 21 test warnings)

 * 18 tests had: AUD diffs.
 * 11 tests had: RDD diffs.
 * 20 tests had: EIO diffs.
 * 6 tests had: ERR diffs.
 * 16 tests had: ESO big diffs.
 * 2 tests had: MDD diffs.
 * 2 tests had: MTD diffs.
 * 5 tests had: MTR small diffs.
 * 11 tests had: Table big diffs.
 * 5 tests had: Table small diffs.
 * 6 tests had: ESO small diffs.
 * 6 tests had: MTR big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.2%25-yellow.svg)


do we really need to check it because we call this method only on `OnInitWindow`


> 'no argument is reset'

We aren't advocating for this. The API is intended to be used as `setMinZoom(null)`, as if you were reaching into the style JSON and setting minZoom to `null`.


missing more data then only text.
		player->SEND_GOSSIP_MENU(9507, pCreature->GetGUID());

can i have the data for such things?? @Selphius ?


Please pass `null` as an argument


Shouldn't this be a `framework` dependency? Surely we'll use this in reducer contexts outside of `asset-admin` as well?


genial


`null`


dpvc "hadn't" -> "had", right?

I believe you guys. I don't have a saucelabs account, but the bug was in Safari for a while. My real point is that a typical website (like mathscribe.com for instance) can't rely on Safari or even Firefox native MathML - bugs come and go in releases because testing has been weakened or whatever, which just isn't acceptable. Also that I'm not the only one who has decided this, no one else even files a bug on it.


To avoid making the same comments across the measures let me summarize.

* There are a many useful methods now in the [standards gem](https://github.com/NREL/openstudio-standards/blob/master/openstudio-standards/lib/openstudio-standards/btap/hvac.rb). You can use them by ```require 'openstudio-standards'``` which is included with OpenStudio.

* Consider prefixing the aedg dependencies with cbei or similar to make it clear that they are derived from but independent of the aedg files.

* Please add at least one automated test that applies the measure to a seed model. This is outlined [here](http://nrel.github.io/OpenStudio-user-documentation/reference/measure_writing_guide/#measure-testing) and you can find and example [here](https://github.com/NREL/OpenStudio-measures/blob/develop/NREL%20working%20measures/AddExteriorLights/tests/AddExteriorLights_Test.rb).


FIXME : this commit shouldn't change data transform method (merge issue)


This is a really good change! :+1:


+1 great stuff would it be better to add the info requirements we have in wiki?


Should `deep-freeze` be installed as a dependency in `package.json` if we vendor it in from `framework`?


Consider:

    python -m pytest \
        path/to/foo \
        path/to/bar

If you sort the lines that have pathnames on them, you get

    python -m pytest \
        path/to/bar
        path/to/foo \

which doesn't work.


Also relevant: http://stackoverflow.com/questions/8285777/is-c03-a-new-version-of-the-c-standard-or-just-a-technical-corrigendum-tc

Thanks for the context.

If there is so little difference, and if 03 is intended "to ensure greater consistency and portability", then I'm not sure why you're arguing to go back to the 98 standard. Why are we having this discussion?


FIXME : remove this (merge issue)


mistake delete


I have detected a problem with this code, before this, add a commondevice (processor, memory...) are not logger in history. With this, the behavior is inversed, the creation of the device if logger (glpi_logs).

This behavior was like this because there is no importance to log the creation date for these objects.


ack


FIXME : rollback to previous `require` (merge issue)


Interesting point re. suggestion limit. Didn't occur to me it would change after initialization :-) Memoization is insanely cheap compared to almost everything this module does.

We were dealing with trademark examiners, who not only are likely to have a lot of weird words, but they're likely to be long, not something you want in your dictionary, and appear over and over in multiple documents. Bearing in mind that Typo is a spellchecker and that browsers have a spellchecker built in, the chances are anyone using it has some pretty strange use cases in mind :-)

If I recall correctly, we ended up running Typo inside a web worker.


:+1:  Super.  This caused a code change for us, because we were using the template calling style to render a file outside of the public directory.  Not saying we were right to do that.

Thank you again for your work on Rails.


Please note that you would need to replace the app ID and user name without your own ones after merging.


Note: these games may not be thoroughly tested.


Not sure what this is/does?


remove stray lines please


Because the compiler option `-std=c++98` is more widely supported than `-std=c++03` and has the same semantics, as far as we care (indeed, likely exactly the same semantics).


why the "=" ?


FIXME : merge issue


I do not see this command when I run li . Is this supposed to be hidden from external usage?


you drop nearly all what you've done in this commit in 27afca8, or don't you?


sure. will do. thx.


hi suyash,
i want to create a app for website.  i just see your open source project & i am download your technoxist project but when i am  implement  your project in my Android Studio i see some error. can u please tell me what i do now?


That sounds like a case for speedy deletion. If you know what those manual tests are, then I would ask you to share them with the world by automating them.


thanks. we actually don't need to `generate-keys` here, as build does that already. if you can remove that line i'll merge this PR


if so squash them together.


Should this be bin.prefix()


What info requirements?


This is a really good change! :+1:


Hm. I don't think I've ever been tempted to do that. So putting it on one line also eliminates that possibility...


if I commite about this my spelling will not be the best !


Great ! If you could just const those two variables (`ready`and `excluded`) and put spaces between parens and braces (but not between if and parens), I'll merge that.


A feedback that I earlier received from Nikhil - the script name should always start with a verb. So may be rename to **`create-responsvie-options`**


TODO : add `getter` for missing params (`mailboxID`, `accountID`)


Main version before update.


This functionality should be in the device object.
Then there would be less usage of internals on the topmost  level. For example, when you are adding port you can care less about external_access, device knows how to get external_access and when to get it. Same about port drill. Therefore, it's clear that errors in port drill aren't handled here properly...


fixed


There are two problems with this commit,

1. We should call the class `MetaModelSimulationParamsDialog` instead of `TLMCoSimulationExperimentSettingDialog`. Because the simulation params are part of metamodel so please use better naming conventions.
2. The Simulation Params should be editable from inside of `ModelWidget` instead of `Libraries Browser`. Because the xmlDocument associated to each metaModel is inside `ModelWidget`.

I have fixed the above issues in c6a2ce1f1e5910613fab2b10cfd6d0d25047d6b4. Note that the code is only skeletion the actual code for updating the simulation params is still missing.


If you don't mind, my name is Tim Mundt. Thanks for the credits.


This looks like it breaks embedded entities. since `propertyAccessor.rootBean` will refer to the root bean and not the parent of the object. For 99% of use cases it works, but it breaks for numerics in an embedded object.


The default for `include_merge` is `True`, which includes all the "merge PR 1234" commits.


Issue5276 (wfbuhl) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1024 of 1024 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-30.61%25-green.svg)


I think you should mark this `override` as well.


good catch ill add that in there.


do you call this method somewhere else? it looks like it's an obsolete method.


Issue5276 (wfbuhl) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Yeah for some reason CAF didn't include https://android.googlesource.com/device/lge/hammerhead/+/38dcd1fc134a844e0e2f78b0e4e7e52a90afad79


sogar mit sublime-projects. nicht sicher, ob es so final - aber für den anfang jut.


Issue5276 (wfbuhl) - Win64-Windows-7-VisualStudio-12: OK (2121 of 2138 tests passed, 21 test warnings)

 * 18 tests had: AUD diffs.
 * 11 tests had: RDD diffs.
 * 20 tests had: EIO diffs.
 * 16 tests had: ESO big diffs.
 * 11 tests had: Table big diffs.
 * 6 tests had: ERR diffs.
 * 2 tests had: MDD diffs.
 * 2 tests had: MTD diffs.
 * 5 tests had: Table small diffs.
 * 6 tests had: ESO small diffs.
 * 6 tests had: MTR big diffs.
 * 4 tests had: MTR small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.2%25-yellow.svg)


It looks like under section 4.c:
> You must retain, in the Source form of any Derivative Works
>  that You distribute, all copyright, patent, trademark, and
> attribution notices from the Source form of the Work,
> excluding those notices that do not pertain to any part of
> the Derivative Works; and

[Reactive-Extensions/RxJS/license.txt](https://github.com/Reactive-Extensions/RxJS/blob/master/license.txt#L1)
> Copyright (c) Microsoft.  All rights reserved.

For example Lodash is a fork and a rewrite of Underscore so [you'll see this](https://github.com/lodash/lodash/blob/master/LICENSE#L3-L4) in its license:
>
Copyright jQuery Foundation and other contributors <https://jquery.org/>
>
Based on Underscore.js, copyright Jeremy Ashkenas,
DocumentCloud and Investigative Reporters & Editors <http://underscorejs.org/>


any reason for make them public?


#5507-Polygonal-and-TriangularDoor-have-the-same-value (rraustad) - x86_64-MacOS-10.9-clang: OK (2131 of 2133 tests passed, 0 test warnings)

 * 2 tests had: AUD diffs.
 * 2 tests had: DXF diffs.
 * 2 tests had: EIO diffs.
 * 2 tests had: ESO big diffs.
 * 2 tests had: MTR big diffs.
 * 2 tests had: SHD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


Consider adding an optional `manifestResources` parameter and updating `VerifyEmitDiagnostics` below (line 261) to use this convenient `GetEmitDiagnostics` method.


This is a really good change! :+1:


If it's exactly the same, why hasn't someone added the option for 03 in the intervening 13 years? If it's not exactly the same in implementation, then do we know that 98 in those cases, with those compilers, is still safe for us? Why take this risk? I'm not seeing the case for.


Great job simon, I really appreciate such wonderful comments.


I think it's clever for two reasons:
- the files for different browser are the same
- when the user switches to a different browser later, manjaro settings will still be applied :smiling_imp:


At any rate, let's table this discussion for eng meeting. This is not a good use of our time.


Yep - needs to be translated.


Dear maintainer and committer,

I'm wondering about the reasons behind this commit because it changes the behavior of the bundle.

It breaks BC or at least crashes with the way I defined my routes for the case page <= 1 (line 144). I'm having a mandatory numeric page parameter in my route/url pattern defaulting to page = 1.
@Route("/topics/{page}.html", name="topics", defaults={"page" = 1}, requirements={"page" = "\d+"} )
Not only from SEO reasons I don't wan't to have my URLs changed.

Furthermore I have implemented a kind of ReversePager on top of your PagerfantaInterface that numbers pages like 0, n-1, n-2, ..., 2, 1 (to not have changing URLs) externally and maps to $page 1, 2, 3, ..., n-1,  n internally. This breaks for the same reasons (mandatory page parameter in route/URL).
So also from the point of extendability I do not understand this commit.

If this behavior (no page parameter on first page) is really needed, couldn't it be made optional by configuration? Or is there already a way I'm not aware of?

Thanks for sharing your code and time. Really appreciated.

By the way line 139 is not needed in presence of lines 141 to 146 if you intend to keeping this commit.


How many times do I have to tell you to document your methods?


form(name="add-estimation", ng-submit="submit()")

// In booking.controller.js

```
app
    .controller('ExampleController', ['$scope', '$http', function($scope, $http) {

       function resetForm() {
          $scope.text = '';
          $scope.phone = '';
          $scope.email = '';
          // ...
       }

      $scope.submit = function() {
        if ( $scope.bookingForm.name && $scope.bookingForm.email && ... ) {
            // $http.post('/someUrl', data, config).then(successCallback, errorCallback);
            $http.post('/api/bookingForm', $scope.bookingForm).then( function(data) {
                console.log('SUCCESS');
                resetForm();
                // May want to redirect somewhere after success, or take the received data back, and display it somehow?
              }, function(err) { console.log(err); }
            );
        }
      };
    }]);
```


> On Mar 14, 2016, at 5:12 PM, Geoff Hutchison <notifications@github.com> wrote:
>
> Why are you removing the cumulene? Do you have an example where this causes problems? Otherwise, I'd prefer to keep it.
>
>
I changed the gaff.sdf and gaffresults.txt, so I don’t think there was any cumulene in these two files.
I even did not remove any molecule from gaff.sdf, I corrected the energies in gaffresults.txt.
> —
> Reply to this email directly or view it on GitHub <https://github.com/mmghahremanpour/openbabel/commit/1c896a515e049d5ad18e9c5ad58c6f11c44e3755#commitcomment-16684775>.
>


What I have to do?
No idea how to use the code Github :/


Unfortunately, `s6_addr32` (which that uses) is Linux-only (I'm guessing they have a bunch of platform-specific `#ifdef`s to define it, and we're only seeing the Linux-specific one) . I guess I could just re-implement it in terms of `s6_addr` which is the only thing specified by [POSIX](http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/netinet_in.h.html).

However, if the macro is specified by all of the target platforms, I'd prefer to just stick to the existing macro. *shrug*.


each input should have ng-model like so:

input(type="text, name="name", ng-model="bookingForm.name")

I would also namespace everything in the form with bookingForm.propName

it can avoid potential weird non transparent errors later on :+1:


after this commit the vintage lines disappear, could you let me know how to get it back?


1/0 tests... we've been down this road. If one fails, the rest don't even run.

I'd like a test_results table that looks much like what the SAS computes.

we could have one 1/0 test: select count(*) from tests_results where pass=0

not critical, I guess


Is there any reason why the task cannot create these files directly?  At the minimum, the configs should be stored in a Ceph git repo.


no


Oh, never mind, I can't read. `IN6_IS_ADDR_V4MAPPED` is in Issue 6 and above. I'll just keep using it (and update the comment).


Check the first example here in order to do this the "Angular way"

https://docs.angularjs.org/api/ng/directive/select


But what I removed from check.sh was *extra* logic to *suppress* the normal output.  Why not condition this suppression on the QUIET environment variable if you want to add logic?

I just want to reduce the number of extra special-purpose gizmos that we've introduced in our build system -- as I originally wrote it, check.sh was not supposed to be a new build system in its own right, just an abbreviation for 'do a clean build and run the tests' which I had been typing over and over again, incompletely, at the shell.

As I recall (although the history is fuzzy and there's no rationale in the revision control), the main issues were (a) warnings about the bogus -Wstrict-prototypes option to the C++ compiler, due to a bug in Python C++ extensions; and (b) that the tests did not print 'passed' or 'failed' but reported that only in their exit status, which wasn't obvious (if your shell prompt doesn't show nonzero exit status like mine does).


dá segmentation fault, não sei o motivo com MAX = 10


develop (rraustad) - i386-Windows-7-VisualStudio-12: OK (1582 of 1582 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1598 of 1598 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


If there are truly no data for that metric, then yes, the csv and html file should not exist.  Was event.flags the only metric where you saw this?


Looks reasonable to me. :+1:


I'm not sure it's useful. You check that the authentication is still valid before actually doing anything so it should work as far as I can tell.


I don't think this works. Let's say you set `maxNumDipIters` to 10. You have nothing but up iters until iteration 100, so now you go down this branch. `numDipIters = 100 - (-1) = 101`, which is bigger than `10`, so you bail immediately.


I'm glad you have that context. Have those things changed?

Check.sh should give a default user a clear indication of the status of all of the tests. Exit status indication is not default. I've argued above that quiet should be the default. I don't mind if you use the quiet or debug environment variable as long as, by default, it is easy to tell the status of the full test, and hard to mistake bogus warnings for actual problems.


Good change


I will fix this although I'm not sure sure it matters. It's not really used to check if the authentication is still valid.


This may be a personal preference but I tend to avoid infix notation except in total DSL land/symbolic method names. The [official scala guide](http://docs.scala-lang.org/style/method-invocation.html) discourages using `.map(...)` but the reasons they bring up don't really make sense to me, it's clear that the calls are chained.


When would an item in `_heap` ever be `sentinel`?

If the value in _data is set to sentinel, and _refresh_heap consumes it, this code will
end in an error:

```
>>> from celery.datastructures import LimitedSet, sentinel
>>> x = LimitedSet()
>>> x._data['foo'] = sentinel
>>> x._refresh_heap()
>>> x._heap
[<object object at 0x1002c7d40>]
>>> x.pop()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "celery/datastructures.py", line 752, in pop
    _, item = heappop(self._heap)
TypeError: 'object' object is not iterable
```

But I cannot see any case where values in `self._data`, nor `self._heap` would be set to `sentinel`.


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Nice dude! If you'd like some more useful ones, take a look here: https://github.com/mattkgross/PersonalWebsite/blob/master/index.html#L16-L30


BTW see https://github.com/jenkinsci/cloudbees-folder-plugin/pull/41: I do not recommend calling `save` from your `initViews` override.


@Zangetsu38 what about 3.8?


Ты просто удалил лишнюю строку?


what is the npc id that must be on this script @Selphius ??
also for npc_shattered_helper ??


Should I change out_notify to err_notify?


Hello,

I'm unable to compile using VS2015 after this commit.

Error: identifier "randombytes_close" is undefined

cpx.cpp is not including "randombytes.h" when using LibSodium, so call to "randombytes_close();" on line 115 causes compile error.


@varlesh

https://aur.archlinux.org/cgit/aur.git/commit/?h=arc-dark-suite-git&id=6f0cdc92e618d7e0281e4946a43e3176db774e82


Да, такие имена переменных гораздо лучше)


The default is off now, you need to toggle it once.
In my user key, I mapped
{"keys": [" ", "r"], "command": "toggle_setting", "args": {"setting": "vintage_lines.force_mode"}, "context": [{"key": "setting.command_mode"}]}

so I need to press space , r in command mode once to toggle it.

If you want default show, put this in your user preference {"vintage_lines" : { "force_mode" : true }}
( didn't test my self)


nit: newline!


Maybe some problems with wifi drop during standby


Oh shoot, I forgot the ternary. It should be
```java
int numDipIters = this.dipIter >= 0  this.numIters - this.dipIter : 1;
```


@NicholasBuse instead of making a revert and squashing the original top + the wrong + the revert; you can also just rebase and purge the line with the wrong commit and force-push this new HEAD with the wrong commit omitted.


latest version seems to have a "Relative" still too much.


it would be SO COOL to reference MultiHash "subtypes" using dependent typing... sadly this is not possible


This addition is not necessary, that function is already run right above it.


I think I'm with you on preferring the dot syntax.  I don't like the style guide suggestion either.  I'll toss the dot in there :)


do they really want you to pass the `passphrase` in every time before invoking `signStream`?


GCC 4.5 came out in 2010, so only 7 years, not 13 years.  I don't know why `-std=c++03` wasn't included but the fact is that it wasn't, and `-std=c++98` has exactly the same semantics in GCC and Clang.  Note that `-std=c++03` was only added to Crosscat's Makefile in November, in 24fbe3c32447cf516061493a63927a344c4c3b2f.  Was that change any more objectionable than this one?  That one probably actually did change some pragmatics at least if not semantics that affect the behaviour of Crosscat, on some compilers.

The only substantive difference I'm aware of is that C++03 guarantees STL vector members to be contiguous in memory, whereas C++98 does not.  I would be surprised if we relied on this, and I would also be surprised to learn any implementation of C++ that someone might try running Crosscat on would fail to guarantee it anyway.


Не уверен, но мне кажется, что так нельзя. (См. get-оры и set-оры для бита C)


We need to keep this comment, as it provides information on the reason why we want to run the HGVS checker.


I also added some minimal documentation.


The following doc(s) have been deployed to the [simpleurls](http://simpleurls-static-docs.pantheonsite.io/docs) Multidev environment:
- [_docs/content-delivery-network](http://simpleurls-static-docs.pantheonsite.io/_docs/content-delivery-network)
- [_docs/logs](http://simpleurls-static-docs.pantheonsite.io/_docs/logs)
- [_docs/migrate](http://simpleurls-static-docs.pantheonsite.io/_docs/migrate)
- [_docs/new-relic-analysis](http://simpleurls-static-docs.pantheonsite.io/_docs/new-relic-analysis)
- [_docs/newrelic](http://simpleurls-static-docs.pantheonsite.io/_docs/newrelic)
- [_docs/settings](http://simpleurls-static-docs.pantheonsite.io/_docs/settings)
- [_docs/unsupported-modules-plugins](http://simpleurls-static-docs.pantheonsite.io/_docs/unsupported-modules-plugins)
- [_docs/user-dashboard](http://simpleurls-static-docs.pantheonsite.io/_docs/user-dashboard)
- [_docs/user_dashboard](http://simpleurls-static-docs.pantheonsite.io/_docs/user_dashboard)
- [source/_partials/navbar.html](https://github.com/pantheon-systems/documentation/commit/bca7942f758a1e6f1ab2b2f6d43ff4d36781d91b/source/_partials/navbar.html)
- [source/_partials/search_box.html](https://github.com/pantheon-systems/documentation/commit/bca7942f758a1e6f1ab2b2f6d43ff4d36781d91b/source/_partials/search_box.html)
- [source/_views/doc.html](https://github.com/pantheon-systems/documentation/commit/bca7942f758a1e6f1ab2b2f6d43ff4d36781d91b/source/_views/doc.html)
- [source/docs.html](https://github.com/pantheon-systems/documentation/commit/bca7942f758a1e6f1ab2b2f6d43ff4d36781d91b/source/docs.html)
- [docs/_guides/sendgrid](http://simpleurls-static-docs.pantheonsite.io/docs/_guides/sendgrid)
- [docs/_guides/two-factor-authentication](http://simpleurls-static-docs.pantheonsite.io/docs/_guides/two-factor-authentication)
- [docs/_guides/visual-diff-with-wraith](http://simpleurls-static-docs.pantheonsite.io/docs/_guides/visual-diff-with-wraith)
- [docs/_guides/wordpress-commandline](http://simpleurls-static-docs.pantheonsite.io/docs/_guides/wordpress-commandline)


Idem here; we need to keep this comment, as it provides information on the reason why we want to run the HGVS checker.


That's how the wrapper is set up... I'm not sure if that's because of their specific use case, or just to avoid holding the passphrase in memory longer than necessary?


fast-forwarding 2.0 to borshop-integration-819-jhc-log_no_type = fb9493af


In general no, if it's an external we're getting from `framework`, it's shouldn't be included in `package.json`.

However - external dependencies can't be required in unit tests. This is because we're not loading the Browserify bundles in unit tests, which is the mechanism that allows externals to would. So we have two options when unit testing code that requires external dependencies.

1. Create a mock. Jest looks in the `__mocks__` directory for files matching the requirement name before loading requirements. For example:

__my-test.js__
```js
var myLib = require('my-external-lib');

describe('MyComponent', () => {
    ...
});
```

Jest will first look for `my-external-lib.js` in `__mocks__` before creating an automatic mock for the library. This is useful when your code is expecting specific methods to be available.

2. Sometimes need to use the actual library, rather than a mocked version. In this case, when we're dealing with an external, we need to include the library as a dev-dependency in `package.json` so the module can be loaded in tests.


Кривое говно! Никогда так не делать!


Ngano dili ni siya parehas sa `question` ang `type`?


Why take the risk: so that potential contributors (like me) will be able to use the thing.  The only reason I put work in this weekend was that I wanted to use Crosscat for my own purposes, not because I was getting paid for it, and every build system change was to fix something that got in my way.


Please add a comment about this hack.


Care to explain unsa ni?


Haha


So wala na ta'y `admin` model?


@Selphius can you provide the ID of the npc_honorfallendefender, npc_honorfalleninfantry ??


cool!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 19072](https://teamcity.mesosphere.io/viewLog.html?buildId=164491&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 250 Build time: 00:04:51


Это лучше перенести в класс Test, а Main максимально освободить.


{"vintage_lines" : { "force_mode" : true }} doesn't work for me. Wouldn't it make more sense to make it enabled by default? I think whoever install vintage lines would want to see it working by default. Thanks.


Yupp, I just asked, because I tried to look up some `impl<T:Copy> Deref for T` that said `clone()` but could not find it.


These variables will be available in the next release - https://github.com/beetboxvm/beetbox/releases

However, you can use the latest `dev` box which is rebuilt on each commit to master -- https://atlas.hashicorp.com/beet

Add `vagrant_box: "beet/dev"` to your config.yml


This has been resolved in the newest pull request version by use of the HygieiaException class handling


I'm lucky, I had a public holiday on Monday and now I'm sick at home on Tuesday, no school - lots programming lol


ack


Sorry -- thanks for catching this!


David Howell's link is broken


Ok, fixed in 86686e4, let me know if that does it and I'll do another release commit


develop (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1582 of 1582 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Wondering why you are doing things differently for `filter.value.length == 1`, seems that it would work fine to use `$nin/$in` for all non-zero lengths.

Currently the query can be `db.collection.find({field: ['value']})` which I guess works in mongoose but wouldn't return the expected result as a mongo query whereas `db.collection.find({field: { $in: ['value']}})` does exactly as one would expect.  This seems to be undefined behavior in mongoose.


@flixr tested and working as expected. Thanks.


Clang 3.8 ?


Ok it is for some providers, I got confused by the OpenSubtitles implementation.


yeah, I guess it's consistent with their (interactive, single message) use case, let's leave it be for now


Would `gzip` be required to satisfy build system?


NewChangelogHeader (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 19073](https://teamcity.mesosphere.io/viewLog.html?buildId=164492&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 262 Build time: 00:04:36


Can we not just `sudo -u enforcer /usr/local/bin/enforcer` in tea4cups.conf?


For me my last changes are ready.

Regards


This variable seems to break everything... any thoughts @timurcatakli?


I think I see where you're coming from, I just approached it from a different way, thinking about a couple scenarios:

1. Set up Makefile so that an end user could run ``make env production && python app.py`` (where ``app.py`` is some application that uses python-twitter) and be off to the races.
2. Set up Makefile so that an end user could run ``make env production && pip install python-twitter && python app.py`` and everything'd work.
3. Set up Makefile so that an end user could run ``make env production[/development]`` and begin hacking on the project knowing they were using the same setup everyone else had (assuming installation of pyenv + pyenv-virtualenv).

Option no. 3 is closest to what I went with, and so python-twitter doesn't get installed into the virtualenv (nor would it with option 2). My thinking was that if someone is having trouble, it's a good way to ensure that everyone is on the same page (environment-wise). Deleting the virtualenv through ``make clean`` was so that any issues could be isolated, though in retrospect, it does seem a little extreme to nuke the whole environment. I'm not sure how option 1 would work in practice (since you'd have already ``git clone``'d the repository to be able to see the Makefile (?). My experience with makefile is sorely lacking in this regard.

I'll defer to your judgment on this one - so something instead like:

``` make

clean:
	rm -fr build
	rm -fr dist
	rm -fr doc/_build/*
	find . -name '*.pyc' -exec rm -f {} \;
	find . -name '*.pyo' -exec rm -f {} \;
	find . -name '*~' -exec rm -f {} \;
```

Looking at it again, it also seems a little pushy to specify the version of python. Thoughts?


Errr... Don't mention people in commit message....


To clarify, pushy of me, not anyone else.


platfromID -> platformID


діалектичний


I'm no JS developer, but it seems a little strange to be repeatedly incrementing part of an object called "constants" :)


Looks like the right direction, overall. Maybe give `MultiHash` an implicit conversion to `Array[Byte]`?


@danilaml hmm for llvm38 i have a problem actually


OK, sorry, my bad. Didn't know that rule.


There is  a number of them with just a header line (not sure why: it was a pbench-user-benchmark -- sleep 60 run that produced the data):

timestamp_ms,event.flags
timestamp_ms,event.missed
timestamp_ms,filesys.blocksize["/dev/dm-2"],filesys.blocksize["/dev/sda3"],filesys.blocksize["/dev/dm-3"]
timestamp_ms,hinv.cpu.online["cpu0"],hinv.cpu.online["cpu1"],hinv.cpu.online["cpu2"],hinv.cpu.online["cpu3"],hinv.cpu.online["cpu4"],hinv.cpu.online["cpu5"],hinv.cpu.online["cpu6"],hinv.cpu.online["cpu7"]
timestamp_ms,hinv.node.online["node0"]
timestamp_ms,kernel.uname.distro
timestamp_ms,kernel.uname.nodename
timestamp_ms,kernel.uname.release
timestamp_ms,kernel.uname.sysname
timestamp_ms,kernel.uname.version
timestamp_ms,pmcd.numagents
timestamp_ms,pmcd.numclients
timestamp_ms,pmcd.services
timestamp_ms,pmda.uname
timestamp_ms,swap.in
timestamp_ms,swap.out


Is there any reason to duplicate code here? ```@method_decorator(ajax_required)``` would have done it.


xD s


@danilaml Look this


https://uk.wikipedia.org/wiki/%D0%93%D0%B5%D1%80%D0%B1%D0%B5%D1%80%D1%82_%D0%A1%D0%BF%D0%B5%D0%BD%D1%81%D0%B5%D1%80
Спе*н*сер


We don't really need the full enumeration of machine architectures.


updated before this was submitted - added those additional entries into the file


In my experience, the closer the terminology is to the purpose or function, the faster people learn how to use the system. If the keywords are literal it's easier for people to remember what each one does. I've used the system a few times and I'm still confused about the difference between rub and polish for example. I was thinking to use

* prepare
* configure
* finalize


This removed section is stil true. Simplest case is using an existing env (production) and doing both current/future parser against it. Then, when you start to make changes, you need to use a third env to be able to test your future changes against both current and future. The --baseline_environment is mainly intended for that use case. The documentation may not say it very well, but I think that the above should no be removed.


czemu ROLE_ADMIN? nie powinno być ROLE_USER?


latex-documentation (michael-okeefe) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1579 of 1579 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.85%25-green.svg)


Ты это пробовал это компилить?


Why didn't you provide option `-o` for generating ELF/ARM executable?


@picklepete @coddingtonbear

Do you guys have access to the pypi repo? Would be happy to update pypi after cutting new releases, but I think one of you have to add me for that to work :smiley:


> Should we perhaps put the phrase "Constants for "", "" and "" are available in the MappingConstants class" from further below into an info box?

Good point! Done.

> People don't tend to scan for code examples and info boxes first before trying stuff out and only then read the fine print. (At least it's the case for me )

Yep.. sounds familiar. Still struggling with my VCR :smile:


latex-documentation (michael-okeefe) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


"a summary" (was wrong earlier as well).


//Parse


2015?  Seems a while back...


Try upgrading cython to 0.23 as described in #1544.


Just a slight comment: Please add an empty line between the first line of your commit message (which is the summary) and any further paragraphs for detailed explanation.


Ouch, fixed.


Thanks for talking me through this in person!


@Spikeone Something for you:
![hq](https://cloud.githubusercontent.com/assets/309017/13761463/0c1fa45c-ea39-11e5-8a72-4f3156bebea6.png)


lgtm


No, it is not. Never was in the test releases. You think it should be off?


Почему нельзя написать: int StartAtAdress = 0x200; ?


@dillaman I can use the ceph git repo, these were just static files so i used fpaste instead of creating them. only 2 values change within the vm.xml file.


I'm not catching that. Can you clarify?


Indeed, is it done yet m8s


Ha yes I pointed out to @patriciogonzalezvivo that it is no longer an appropriate variable name :)


Re: unit of analysis: I mean that it's a between subjects design, for which
we writing down the causal model of a single individual, and SUTVA holds.

Re: randomness of userids: Pumping any input through the random op makes it
random, even if there is some systematic correlation between the evenness
of the ID and the users' potential outcomes.

On Mon, Mar 14, 2016 at 12:57 PM, etosch <notifications@github.com> wrote:

> "If we were only dealing with experiments that involved one unit of
> analysis, putting the userid would be completely unnecessary for the DAG,
> as the DAGs represent the structural model for individuals" --> one unit of
> analysis, meaning there is only one unit name used throughout the script
> (i.e., "userid"), or that you are testing on only one person?
>
> To verify: userid is *not* expected to be random -- it could just be the
> next id drawn from a gensym. If it is drawn from a gensym, then we would
> expect something like
>
> specific_goal = userid % 2;
> group_size = 10 ^ (userid % 2);
>
> to *not* be random assignment; if userid *were* randomly assigned, then
> this would be sufficient, no? It's because we pipe the userid through a
> hash function that we don't get a systematic bias in assignment.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/eytan/etosch.github.io/commit/0eb54afe8d1a194037bfb7c800dc6a2d015adb9b#commitcomment-16690475>
> .
>


/cc @jcredding


This is a WIP, not clear if we would actually expose `texcoord_ratio` directly (maybe), but in other cases it would be set automatically by providing a repeating sprite pattern. For shader-based patterns it's useful to control ratio though.


THANKS, now i perhaps gone sleep


Don't worry I can fix it in 3 merges but in the future my recommendation is that you make your own branch and pull from your branch and main before you push to main. I was just a little upset that I lost like 3 weeks of code but git preserves it.


I just prefer the least possible amount of ambiguity.


I double-checked that the develop branch of CGNS (after commit e0faea6) fixes the undefined symbols issue. The CGNS 3.3 release version may suffer from this issue.


You can use the UMSBuilder at http://www.universalmediaserver.com/forum/viewtopic.php?f=25&t=1782 to build that branch and install them for testing.


Note: the canvas_settings_page will be moved out into the selenium_common as a new page object under the canvas sub-directory (so import references above will be modified).  @Joy603 is helping out to parallelize the work to selenium_common while I cleaned up my code here.
The related PR is here: https://github.com/Harvard-University-iCommons/selenium_common/pull/11 (though it looks like it needs to be modified since the the code got moved into the canvas_course_page_object.py instead of being in its own canvas_settings_page object file).   We'll touch base tomorrow.


If check.sh passes, it prints 'Passed!' just before it exits.  If it fails, it will print some indication of the fact unless there's something deeply broken (e.g., if pytest had a mysterious bug causing all failure output to be suppressed, somehow).  Here is how it looks if I break a Python test:

    % ./check.sh
    ...
            assert isinstance(val, float)
    >       assert False
    E       assert False

    src/tests/unit_tests/test_pred_prob.py:232: AssertionError
    ===================== 1 failed, 81 passed in 0.65 seconds ======================
    %

Here is what it looks like if I break a C++ test:

    % ./check.sh
    ...
    End:: test_multinomial_component_model
    test_multinomial_component_model: tests/test_multinomial_component_model.cpp:214: int main(): Assertion `0' failed.
    Aborted (core dumped)
    make: *** [runtests] Error 134
    Failed!
    %


What removed section? The section is rewritten, focusing on '--preview_environment' instead of '--baseline_environment'.


Thanks!


Let's get out what works for v3 and then we could completely remove v2 code. That's immutable :)


To elaborate, the problem is that commits get moved around a lot (rebases, forks), etc and it'll issue an email every time.


Thanks, fixed (the time point was correct, the comment was wrong).


The question is not really whether it's provably an integer, it's rather whether it's used in places which need an integer argument. In that case, using `eachindex` doesn't really make sense. When you encounter such cases, it's best to leave a comment if the code is not very clear (i.e. when it's not obvious that we only expect iterating over a standard `Array` or tuple), and leave the code as-is when the code is clear.

Here `TAGS` is a global `Array`, so there's no problem in practice.


ok


@yfarjoun This doesn't seem ideal, but in order to use CollectWgsMetrics.instanceMain(args), I need the args to be the full command. If I wanted to have argument name (INPUT) as the key and the path as the value, then I'd need to rewrite the function [makePicardCommandLineArgs](https://github.com/broadinstitute/picard/blob/master/src/tests/java/picard/cmdline/CommandLineProgramTest.java#L31) in order to return a String[] rather than call getCommandLineProgramName() which in this case is CollectWgsMetricsFromSampledSites, rather than CollectWgsMetrics. So I either need to have the full command in the value, rather than in both the key and the value (which is what I did here) or I need to override the function in CommandLineProgramTest. I think this is more readable, but let me know if you have a better idea.


the only reason i didnt use them was I had a single cleanup function, I can use context managers but some of the function will not do any cleanups.


Looks like there might be a typo here: "excited on a travel app"


java.util.concurrent.ConcurrentLinkedQueue would have been an alternative. I'm not entirely sure, why we need a queue here at all. Is just remembering last position not enough? Can there be concurrent queries?


Oops, didn't mean to push this but it's fine.


Perhaps I haven't understood your difficulties. Are you unable to use a modern compiler on your system?


Has this patch been accepted by upstream?


Do you think `'subset or equal to'` would be clearer?