As far as I can tell, there's no means whatsoever of configuring pyflakes, hence the mess of regex strings in `util/pyflakes.py`.

If you want configuration, you have to move up to flake8. But flake8 re-uses the config parser from pep8, which means it has *the exact same problem* as pylint did here: because [it uses ConfigParser](https://github.com/PyCQA/pycodestyle/blob/master/pep8.py#L60), its handling of comments is flakey, and Python-version dependent. (The commit comment was wrong about it working locally on Py2.)

Moreover, pyflakes/flake8 (like pep8) only uses short alpha-numeric codes for its errors, meaning that the config file is utterly self-*un*documenting (compared to pylint's nice descriptive text). Comments (out-of-line, of course, given the above), (like I [started adding](https://github.com/gevent/gevent/blob/landscape/setup.cfg#L2)) are utterly mandatory to make sense of the `ignore` line.

Lastly, flake8 only offers the generic `# flake8=noqa` comment line to disable a check inline. That's a step up from pep8 or pyflakes on its own which can't do that at all, but again, a far cry from the descriptive comments that pylint uses that tell you *what* you're trying to ignore ( `# pylint:disable=import-error`) and which prevent additional errors from happening on that line.

So that's why I like pylint (and now prospector) better :)


`attributes_for` は、FactoryGirl の機能で、サーバとブラウザのやりとりをシュミレートするものです。


Что? они теперь блокируют аудио и по местонахождению? Россиянам запретят слушать украинские песни что ли?


latex-documentation (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (2135 of 2135 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


:D


For brevity, UnmodifiableBiMap should extend AbstractUnmodifiableMapIterable. We haven't merged it into master yet, but here it is in my fork:

https://github.com/motlin/eclipse-collections/blob/master2/eclipse-collections/src/main/java/org/eclipse/collections/impl/map/AbstractUnmodifiableMapIterable.java


Could you clarify why do replace addStructType with open/closeStructType methods?
Can't we just use original addStructType method + new updateMembers?


xxxx


This is what happens with client login. I just reproduced in the test what is happening with android and ios. But the same code works with parse official server. I'm not sure if is a client bug or the server should work with that.


Can it be private?


The payload test was: `if (payload.length > 0 && payload[payload.length - 1]._identifier)` and now is `if (**payload && **payload.length > 0 && payload[payload.length - 1]._identifier)`


It gets replaced later on by the ViewHelperInvoker when calling the ViewHelper, so this call is redundant. I can extract this to a separate patch if you prefer, but added it here since it closely relates to the problem at hand.


xxcxzcxz


What about moving this to a method?

```ruby
def close
  # ...
  type = financial_transaction_type
  # ...
end

# same at other places

private

def financial_transaction_type
  @financial_transaction_type ||= if params.permit(:type)
    FinancialTransactionType.find(params[:type])
  else
    FinancialTransactionType.default
  end
end
```

and define `self.default` on `FinancialTransactionType`
I'd prefer to use [strong parameters](http://guides.rubyonrails.org/action_controller_overview.html#strong-parameters) here (and elsewhere?), since we don't want `params[:type]` to be an array.


This test reproduce the client flow.
The user already have a facebook user, then the user logout. After he opens the app (or install a new one), he create a anonymous user (bellow) and try to login with facebook, but the client already have the anonymous user, that is the bug.


I'm really not sure about authData.objectId. I've never seen that anywhere. And that seems plain wrong given the general spec of the authData. If you can back it up with a dump from the request that would help


also `default` if possible


`types` would be shorter and just as expressive here (retaining the db column name)


well, not that important anyway


TeamCity jonas-requests :: WindowsBuild [Build 35](https://build.neohq.net/viewLog.html?buildId=575379&buildTypeId=JonasHaRequests_WindowsBuild) outcome was **SUCCESS**
Summary: Tests passed: 27997, ignored: 97 Build time: 1:39:20


please name it `cms-extension-dir` and make `{$config-dir}/ext/{$extension-key}` the default value for it (and adapt the code accordingly of course). You will need to add `{$extension-key}` and `{$package-name}` as config options as well.


@Kozoriz Why this `if` is needed, if code is commented?


Fixed everything and sent to the list.  Thanks for the comments, Doru.  If you have other concerns, please post them on the public mailing list.


Still getting an error with the error fields.


Hi @sjfkai，這個地方我覺的他的意思是分開的
前面的 `As for `= {}`, it covers the case of a missing _object_` 只的應該是上面那個範例，
後面那句指的是下面的範例，不知道我理解有沒有錯誤？


What, you don't like a good lolparty? ;-)

I actually had it as SGE_PE, but then I figured PEs are only an SGE thing. Perhaps including SGE in the name drives that home for the uninformed, is that what you're thinking?


Fixed in commit https://github.com/jembi/bsis/commit/7388760beba28dbf9118f019835e65063364b214


Thanks for the explanation. Fine with me.


Yeah but here, this is the Facebook user that gets created first as data is the data that have the Facebook ID!
This should be dataAnonymous if that what you want to reproduce


Yes :-)
On Mar 11, 2016 8:10 AM, "Jon Pipitone" <notifications@github.com> wrote:

> What, you don't like a good lolparty? ;-)
>
> I actually had it as SGE_PE, but then I figured PEs are only an SGE thing.
> Perhaps including SGE in the name drives that home for the uninformed, is
> that what you're thinking?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pipitone/qbatch/commit/4ed3475c849a83ec0d32350e4c8e4a3de7826ed2#commitcomment-16643531>
> .
>


Yes; there is no other instance of \stdout in the document. We've been using {\tt ...} instead.


Really more complicated .... adding a css at start is really more easy .
Even for one or 2 lines.  And more we already have this css : https://github.com/LimeSurvey/LimeSurvey/blob/master/styles-public/numeric-slider.css


the above 4 lines could be removed as this case is also easily catched by the next 3 lines.


I propose we change all the \verb back to \java and figure out how to make plastex happy. In V5, hevea was fine with syntax highlighting.


@mhils I've updated the contentview test. Please have a look.


latex-documentation (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2129 of 2129 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Put this typedef in UDPClient as private.


done


test


Great job doing this rep! Keep this work!


this is a rather expensive way to find that 2 files are different.


The only issue with this is that any `script_js()` call is expecting all resources to be in the same directory because we need to specify the full path, e.g.:

```
script_js('js/textpattern.js', TEXTPATTERN_SCRIPT_URL | TEXTPATTERN_SCRIPT_ATTACH_VERSION);
```

If we shift `textpattern.js` then legacy plugins that try to include it (are there any?) will break.

If that's not a significant concern, then by all means move `textpattern.js` too and patch the few `script_js()` calls as above. If it is a concern, then, umm... what? Symlink? Rethink?


Why did you change the play ui version ? This is not the story where we change versions.
I was already working on the ticket that relates to new play ui and assets frontend.


It's possible today - now the ide can handle warning suppression - I hate do do that manually. But it's not an issue in these files IMO


It's not my code in that case I prefer commenting. Feel free to clean things up like you want. I do not want ~100 warnings in every compile.


partner_id = self.env.user.partner_id


you've got a little typo in line 34
local c2=g:GetNest()
Nest->Next


remove


**Comment - Nitpick**
I feel commented out code(a.k.a zombie code) should be totally removed. What do you think. Check out [this blogpost](http://www.bitnative.com/2012/10/22/kill-the-zombies-in-your-code) to find out more about `zombie codes` and why they should be killed.


There's something about this section of code that is causing my build to fail.  I commented this part out (as well as the relevant parts of code that was using this function) and the build succeeds.


yeah okay my back-propagation of the `Option` (which starts initially from the [callback](https://github.com/rust-lang/rust/blob/ef3d0516303f82ebfbcc4c250ebfc783aaadad72/src/librustc_driver/driver.rs#L740) passed into `fn phase_3_run_analysis_passes`) went a little bit too far. Will "fix".


hey esto tenía pinta de molar! pero méte todo en un div si lo haces ;)


The "illegal" characters are using template strings and require nodejs 4 (ES6). The templating will not work with this change.


**Zombie code - Kill them**


Yes, my line of thought was that the user could also specify the hash function, so that he can check specific suspicious files against e.g. SHA1SUMS (or SHA256SUMS, …) supplied by an upstream.


**Zombie code - Kill it**


I ger the feeling that some of this is dependent on meta-ivi and should be moved into layers, no?


I based it off of `RuntimeError` and building happens before running. But I'm cool changing it to BuildError


I'm less convinced that this is a good direction. I assume the reason you've taken it is to avoid accessing the instance variables in the calculator which is understandable. However, I wonder whether keeping the full combinatorial expansion of the outcome template name might be useful, but then removing duplication by having some kind of template fallback mechanism i.e. where a specific template doesn't exist, having rules to fallback to a less-specific template. I'm not sure I've explained that very well, so please say if I haven't


hmm, these 2 nested "for" look like O(N^2) with the archive file count.


Sure :)
I think it makes sense anyway to let the developer/operations decide if pagespeed is necessary or not. Because if you have already a manually highly optimized website, it doesn't make sense to make the server more work than necessary. Actually the reason for changing the default setting were the image thumbnails with many media queries in it.

Short example:
You have an image thumbnail with 1 default setting and 3 media specific configurations. Pimcore generates a <picture> tag for that, but doesn't render all the images directly, but includes only the path to the thumbnail (to save server resources). The thumbnails are  only generated when they are requested by the browser (deferred rendering). But when using pagespeed, all the images are generated directly with the first request to the page, because pagespeed tries to download and optimize them in the background. Having 4 different configurations + @2x versions results in 8 thumbnails per image and that can be too much for the server when having a high traffic website :)


Only values in `cor_id_func_map


An issue is here!


Here in line 4, there's a spelling mistake!


Oh, this'll end up below!!


Oh, this'll too end up below!!


Прошу прощения  я не досмотрел у вас строку
before_action :current_user, only: [:create, :new, :index]


That exactly what I got from Android request with the client flow described above:

{ authData: {
    anonymous: null,
    facebook: { access_token: 'XXXX',
                       expiration_date: '2016-05-08T18:19:20.000Z',
                       id: '10207247385845217' }
},

objectId: '5DeGfe43PC' }

But this '5DeGfe43PC' is the anonymous user trying to login with this facebookId '10207247385845217', but this id is already related to another user.


Huh. It works now for me too. :P Sorry! (Also, gitter pls :()


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18885](https://teamcity.mesosphere.io/viewLog.html?buildId=161087&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 254 Build time: 00:06:06


True, but backend devs are a type of user too, and if we expect advanced users to be making their own neuron types and learning rules these might be useful. Also, we shouldn't consider custom exceptions to add much of a maintenance burden compared to frontend objects; it's just two lines in `exceptions.py`.


This file contains unused source code.

*PyUnusedCodeBear, severity NORMAL, section `python`.*


It would be nice to update or remove this comment line.


resolve #8


I think that was an issue back in the day that arrow components declared like that were without a name. But should not matter that much nowadays


Thanks for the update

I will patch it on my side, see if it resolves the problem and submit a PR.


@thet Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.discussion/35/violations
```
plone/app/discussion/contentrules.py:20:5: E731 do not assign a lambda expression, use a def
plone/app/discussion/browser/comments.py:132:1: C901 'CommentForm.handleComment' is too complex (17)
plone/app/discussion/browser/conversation.py:29:1: C901 'ConversationView._enabled_for_archetypes' is too complex (14)
plone/app/discussion/browser/conversation.py:135:12: P002 found "hasattr", consider replacing it
plone/app/discussion/browser/migration.py:34:1: C901 'View.__call__' is too complex (32)
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


So a lot of what this PR does is ensure that we never raise an exception that isn't a subclass of `NengoException` so that things that import Nengo have an easier time interacting with it. The reason I kept this one separate is because no other `NengoException` seemed to fit at the time, but perhaps `SimulationError` would be okay? It's a `RuntimeError` subclass also.


I think it would be more logical for this commit to *precede* the removal of the requirement of the railtie.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18886](https://teamcity.mesosphere.io/viewLog.html?buildId=161088&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 254 Build time: 00:09:03


yeah, those are anonymous functions


Also, I was curious.  Any reason for adding these functions as extensions to the class instead of just defining them inside the class?


this is wrong, should be data.objectId = r.response.objectId;


So what happens? In your test, you start logging in with Facebook, so that create a user, any attempt to link a user that has the same Facebook id should fail.


this was supposed to be yaml* file, got auto-corrected :rage2:


thats why you the man :p


No creas mejor un archivo .scss para los estilos de la directiva?


YEEEEEEEEEE


A veces pienso q jade fue mucha soga para el puerco, pero cuando veo estos templates tan limpios se me pasa. Buen trabajo


But it's the only thing to fix that warning without changing semantics. However I think I could've just removed this method but I only wasn't sure 99% about that and decided against that because I didn't want to introduce a semantic change with the other warning fixes.


Or simply `date --rfc-3339=s` :shipit:


Close #2 after testing


That is the problem, always fail, because can't link a user with the same facebook id. I know that, the problem that is this is what happens with Android with parse-server. But the same code works with official parse server. So I don't know if this is problem is related with the parse-server or parse-android-sdk


ok


If that is the right flow the server needs to be fixed, if the flow is wrong, so need to fix the sdk.


The format of the `__version__` endpoint is defined [here](https://docs.google.com/document/d/1rGVyiLYvZyKE2oHcSVx-vBmQRKhs1kLLgn7xeCs6qKs/edit). I'm only following it.
I went back and forth with having `/api/v1/<endpoint>`, but ultimately I think we want to coordinate updates so that clients always use the latest API. I wouldn't be so strict for public endpoints, but since we control all clients, it shouldn't be a problem .


I did that, because that is what the android-sdk do.


Vidis da sam ja tu listu sam sastavio, spojivo i okacijo, kako si dosao do
nje ne znam, ali sam sve to napravio pomocu samo jednog kanala kojeg sam
nasao na netu, i samo mijenjao kod u url, tj ID kanala i nasao stotinjak.

petak, 11. ožujka 2016. korisnik vlajic3 <notifications@github.com> napisao
je:

> ja sam koristio ovu listu dva mjeseca radi samo na njoj dva kanala samo
> sportska tv
> ja sam dragan vlajic
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/djiga88/sporttv/commit/b296ce0a8f79e7a0491b1ceea601d9587fdc17f5#commitcomment-16641959>
> .
>


latex-documentation (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Yes


This will run indefinitely if `server.error404page` is specified but not found (i.e. looking for the 404 page for the 404 page which is not found). The conditional should be `if (server.error404page && filename !== server.error404page)`


Hmm, that's an interesting thought, they are similar types of error -- some issue with tracking model/network structure. Maybe `NetworkStructureError`/`ModelStructureError` or just `StructuralError`? Any other ideas?


@LuxoftAKutsan Are we must to check RPCs in ExpectResponse?


Looks good!


Squashing with the `ValidationError` commit makes sense to me!


**Zombie codes - Kill them**


Put both in a `.fold-line` to get them on the same line?
Also, we can hide `delete_attachment` if there is no current attachment. Or am I missing something?


This might be an issue with the node version in the docker build. Let me update that line in the docker file and see if that fixes the error.


https://github.com/LimeSurvey/LimeSurvey/blob/master/application/views/survey/questions/multiplenumeric/item.php#l88
For now, it's some dynamic CSS generated from PHP (a question attribute indeed.)
Of course, we could do it another data- attribute, and then a line of js.


Не следует коммитить содержимое папки bin в репозиторий. Во-первых, эти файлы всегда могут получены на любой машине путём компиляции исходников. Во-вторых, они почти всегда будут изменены, но так как они бинарные, то разницу между двумя версиями просматривать бессмысленно. И получится, что изменений при коммите много, а сути мало.


Which has the more positive connotation, thrifty or frugal?  Jeroen hired a
computer scientist, Matthieu Lefebvre (mpbl), who's really good and helpful
for our group.  Next we need a technical writer/linguist!

On Fri, Mar 11, 2016 at 1:32 AM, gianmatharu <notifications@github.com>
wrote:
>
> With this in mind, I'll be converting this class into a custom equivalent
of the thrifty inversion.
>
> —
> Reply to this email directly or view it on GitHub.


Why not in a core plugin ? cron is a bad name, but can be used for this :)


11253041 - Murat Rahmi KURTUL


Yes, a macro would make sense.   I'll make the changes.

On Thu, Mar 10, 2016 at 9:54 PM, François Saint-Jacques <
notifications@github.com> wrote:

> I think we need a macro for this. Something like:
>
> #define CONTAINER_TUPLE(a, b) (a * 4 + b)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/RoaringBitmap/CRoaring/commit/47864700e396d95ca9cc691ba24b19d816da75e6#commitcomment-16634444>
> .
>


cuando te das cuenta de que no es niara


:frowning: oops, I'm sorry. I think what happened is I changed the version and no hash mismatch error was emitted. I've been working to be more careful about that since I learned this could happen.

Thank you for fixing it.


What is the CoM orientation?


Would code duplication with invoices and documents be an issue, or do you consider it to be dissimilar enough? Things like filename normalization and mime-type detection would apply to both.


Попробуйте разобраться с файлом .gitignore и пунктом контекстного меню (по щелчку правой кнопкой мыши на файле) Add to ignore list при коммите.


**Code Quality - Nitpick**
You can use keyword argument here instead of passing in a hash. Check out [this blogpost](https://robots.thoughtbot.com/ruby-2-keyword-arguments) for more information about `keyword arguments`


2.06 issue too, no ?


You also need a `?` in there: `readonly attribute DataTransfer? clipboardData = null`


@Kozoriz I think this this change isn't right


Так же не следует коммитить в репозиторий файлы, относящиеся к Вашей среде разработки.


> because can't link a user with the same Facebook id
Obviously you can't! That's how it should be. However, you should be able to login with that Facebook authData.
Can you post the android code somewhere so I see what you're doing?


I'd say "// Check each width against average width"


What's wrong with this code?


Yeah, I'm not the Android developer, but I will get the code for you.


Presumably there will be some reaction to having the captions. Dunno what it would be but that will most likely be a facial expression that may need to be communicated in the audio description.


Yeah, typical case where string is shortened :)


Test Comments


why not `is Countvector.Category.reference`?


И что-то у Вас совсем не так с файлами .class - они есть как в папке bin, так и в папке src рядом с исходными файлами .java - видимо, Вы что-то где-то настроили так. Традиционно считается, что лучше держать отдельно друг от друга файлы с исходными кодами и скомпилированые. Это, конечно же, на Ваше усмотрение, но бардака в любом случае быть не должно.


@tomspur No, I had not planned on it.

Scipy now also has an arff file reader, so if you're interested, you may look there as well: http://docs.scipy.org/doc/scipy/reference/generated/scipy.io.arff.loadarff.html


Thanks! :+1:


haha... loved the documentation on this :wink:


ah neat simplification :)


@Kozoriz Why "wrapper" is in header guard?


Хорошо, довольно удобно отличать строчки от не-строчек.


Yeah, I think what we normally do is provide a helper method in `TyCtxt` to do the necessary branching.


font-size: 1.2rem


@atfornes there was a typo. It should be fixed in 0c0aa92 Please confirm! Thanks


@Kozoriz Why "wrapper" isn't in header guard?


Это нужно в туду и переделать через C++, там есть статический класс indexer/cuisines.hpp


Before it it filtered out those which don't start with "#". So, it's repeating the same logic. Everything except literals


What happens if I enter in 0 or 5? :+1:


In my case a zonestar P802M the correct value is 400... not 1600.
Greet Wybren


I'd say no. Separator should be T, not space, as I have understood it.
Possibly also varies according to coreutils version...


this is a different callback, so its not running the same `if(server.error404page){` the _second_ time


Лучше полностью убрать из strings.txt все переводы кухонь, чтобы сильно облегчить этот файл и не дублировать переводы и в ядре, и в нативном коде.


We need to validate that donor is not null (externalDonorId is invalid)


Yeah, it makes sense that there's a choice between counting variable occurrences at runtime or while compiling.


shouldn't this be indented two spaces more?


Good work! I would have not detected this typo ever XD


This was changed so the beta banner matched the pta partial one


Да, это в планах, но не в этом реквесте, ок?


## This is a markdown file.


why do you put the docs dir into `.ci`? Put it on root level, we all need documentation! We should set up readthedocs.org for this even.


this is coala-bears, not coala


@dcramer We just ran into this, since we want to use Sentry in our background jobs as well. What was the reason for this revert?

This commit doesn't remove the actual `raven/integrations/rails/active_job` file, does that mean we can use it?


imo setup.py docs should also run the makefile


latex-documentation (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1021 of 1021 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-30.56%25-green.svg)


I think it should be defined in SPIRVType.h file.


Już tryliardowe gildie do Minecrafta xD


3/11/2016
ergasthrio2


fdsfsdf


Why this variable doesn't change?


latex-documentation (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2167 of 2167 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


latex-documentation (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Не стоит коммитить закомментированный код.


No need for `> /rootfs/etc/hosts || fail` ?


An issue is here!


Here in line 4, there's a spelling mistake!


Oh, this'll end up below!!


Is there a case where `column` or `c->column` could be NULL here? I can't see one reading over the code but I'm not really familiar with this path. Since `equal()` has an additional NULL check before the `strcmp()` it would've passed clean.


Oh, this'll too end up below!!


well but the goal here is to get the number of variables, right? IMO if we use the `is` it's clearer and simpler


hello


Не стоит коммитить закомментированный код. Он вызывает много вопросов и не делает ничего полезного.


no no no no no


and here


why does the original wording need a change?


Right. I actually wrote this function :smile: , but it has been a while and it seemed odd at first glance.


@rqc Sounds good. But what i added is a POC. Ideally, it should work in a similar way to how shipyard forwards requests to swarm. Shipyard is already using a package that makes this easier. Take a look at `github.com/mailgun/oxy/forward`. This way, we can use the same route for different requests (requests with additional query params quickly comes to mind).

Link for forward package's doc (https://github.com/vulcand/oxy)


@dikkedeur
This was written by me before SAI, since nothing in DB worked for this quest, not to mention AreaAnnounce. There was no need to commit "every one" of my fixes :D just those which aren't scripted in SAI and those which you think were good, since most of them were done in my newbie days - half of them like this one, it has more code than necessary no matter how I look at it.


looks like all your entries are still 2015 :)


still think it'd be simpler to use is as we put it into `var_list` not `non_literal_list`


You're right. It doesn't need to be global (anymore).


I noticed a typo here: cirrus -> cirros


@OHerasym I think it's not right conception to use singletons now when all of them are cut out, just waiting for merge. In nearest days we will have to cut out this code.


А зачем выделили переменную?


this line and net one could be replaced by pg = current.get('portgroup_name')


Oh I see, this is covered by the `{ ... }` brackets around the code.


改行


@stepan-a Do you know why this happens? Does it have to do with https://github.com/DynareTeam/dynare/issues/1119#issuecomment-195371200 ?


Fingers crossed for less yellow screens.
I have been decrypting on my Old3DS with decrypt9 launched with a9lh.


Тут произошло смешение табуляций и пробелов. Отдеаёт некоторой небрежностью.


We decided to keep the selected objects in a separate list. I can change it to function (PickedObjects will be used as a function parameter) to avoid the crash. Ok, I can implement .isInRect() method but we should discuss. Maybe, _isPicked() will be enough.


Unused method


フォームのデザインまではまだ適用しないの？


Added button for testing of listed view of recorded data
Added record-buttons
Added 'Export'- and 'Settings'-View and their menues
Changed app bar
Added styles and strings


newとeditのはほとんど同じだから部分テンプレートを使ってまとめよう！


Here I just created the user, because this bug just happens when the facebook user already exists, this part is just to be sure that the user already exists before try to login again with the anonymous user.


latex-documentation-myoldmopar (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2129 of 2129 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ok, that makes sense. Only thing I'm afraid of if this will break when some other categories will be added?


Would be better to put the precondition that the collection should not be null.


This simulates the user with a fresh install. The client create a anonymous user after you open the app and start the parse sdk.


lgtm


This is not what's in the android SDK as you can see in the request that is passed:

```
{ authData: {
    facebook: { access_token: 'XXXX',
                       expiration_date: '2016-05-08T18:19:20.000Z',
                       id: '10207247385845217' }
},

objectId: '5DeGfe43PC' }
```


lg


@aofall 高中数学就是这样啊，知识点不多，考的都是细节。除了刷题别无他法。短期提升自己最有效的方法就是把市面上所有的习题买来全部做一遍。
但到了这个时间，最好的方式就是顺其自然，打破常态会适得其反。
最好多和老师交流交流，你的老师是最可靠的人。

aofall <notifications@github.com>于2016年3月11日周五 下午6:20写道：

> 这周我们这市质检，考完数学之后觉得药丸啊
> 大题看着好熟悉，但就是不会做(╯‵□′)╯︵┻━┻
> 答题卡的大题几乎是空着的啊！！！
> 第一次考成这样(╯‵□′)╯︵┻━┻
> ------------------------------
>
> 高二的话大概再一两个月就开始总复习了吧，到时候节奏就会开始抓紧了
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/racaljk/hosts/commit/7ebc2c0255f031932cd24855ea7269b130228315#commitcomment-16640424>
> .
>


lg -- I was just wondering what purpose this indirection served


in that case this routine has to be adapted anyway to mirror that

Sincerely,

Lasse Schuirmann

contact@viperdev.io
http://viperdev.io/

2016-03-11 15:03 GMT+01:00 Attila <notifications@github.com>:

> Ok, that makes sense. Only thing I'm afraid of if this will break when
> some other categories will be added?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Uran198/coala-bears/commit/192a5730bf27a25e7b8483c28cb84b14135a165e#commitcomment-16644684>
> .
>


Hi, in my case the ZF library path is already included via composer, in the file vendor/composer/include_paths.php, so maybe this is not necessary?


I might move all this out into a handle404 function to tidy it up a bit.


This is wrong. The metamodel should not have save and save as context menu. Because the text for metamodel comes from `MetaModelEditor` which is not created until you double click on the metamodel to open it.

This is crashing the editor.


I should file a bug on it.


Please do not inject he whole container. Inject each need service.


nice cleanup


Can't you catch a more precise exception ?


@sils1297 It is giving the following error
Warning, treated as error:
/home/vivek/gsoc16/coala-bears/bears/natural_language/MarkdownBear.py:docstring of bears.natural_language.MarkdownBear.MarkdownBear.run:29: ERROR: Unexpected indentation.


Not even logging ?


Ja sam dosao do te liste preko fejsbuk grupa jer dosta ih je objavilo na fejs koristilo je sigurno 2000 ljudi a neko je objavio i na onaj pastebin mislim da pise bobo iptv tako nesto

Poslato sa mog Windows Phone uređaja
________________________________
Od: djiga88<mailto:notifications@github.com>
Poslato: 11.03.2016. 14:32
Za: djiga88/sporttv<mailto:sporttv@noreply.github.com>
Cc: vlajic3<mailto:dragan_vlajic@hotmail.com>
Tema: Re: [sporttv] Update sportovi.m3u (b296ce0)

Vidis da sam ja tu listu sam sastavio, spojivo i okacijo, kako si dosao do
nje ne znam, ali sam sve to napravio pomocu samo jednog kanala kojeg sam
nasao na netu, i samo mijenjao kod u url, tj ID kanala i nasao stotinjak.

petak, 11. ožujka 2016. korisnik vlajic3 <notifications@github.com> napisao
je:

> ja sam koristio ovu listu dva mjeseca radi samo na njoj dva kanala samo
> sportska tv
> ja sam dragan vlajic
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/djiga88/sporttv/commit/b296ce0a8f79e7a0491b1ceea601d9587fdc17f5#commitcomment-16641959>
> .
>

---
Reply to this email directly or view it on GitHub:
https://github.com/djiga88/sporttv/commit/b296ce0a8f79e7a0491b1ceea601d9587fdc17f5#commitcomment-16644023


I would inject each service, but I need 3 arguments into the controller, it's large IMO


what is the difference between none and empty ?


Why do you want to catch this at all? You're losing information in your catch, that's all you're doing.


Legacy nonsense - `astencode` was decoupled for a long time from the rest of metadata.
Can't wait to replace it with just MIR :skull:.


thanks!


Yeah, I can see we are looking for NSMain, hence the original question, maybe I misworded the question. :grinning:

Why are we requiring NSMain?   This eliminates someone taking an already existing .so files that exists outside of the nativescript eco system and using it as is.    Is this something that we can change?   Or does the person now have to write a custom .so file to load a unmodified already compiled .so file?


No because it's for the file presence. The config file is not mandatory, so this file not found error doesn't need to be logged


Missing one indentation space in this new block


you ought to factor this into a private `isEmpty` method

could there be a pertinent location to have it public?


**Test**
What are you testing here. There are a lot of mocking happening


Previous version (3.3.21) did not work with Firefox 45 on Ubuntu 14.04.


Are you sure about this? i remember kazz had 1 min enrage?!


could be an enum


True, my mistake, I will fix it. But I was testing with the device to check all the flow.


Why is this a good choice? How can we be sure that the ids will not reappear after one hour?


If the argument list is too long, it is a good sign that your class violates the SRP. But 3 is really not too long. I don't get what this has to do with a controller though.


No karwasz :V


Maybe the semantics are wrong, and by hiding the warning you are hiding a real bug...


You could use `list()`


indention problems


this function could be an enum
I don't know how other `RulesProfile` objects are cloned, but not having a enum can have a  performance impact


When there's a parse error, YAML return a Symfony\Component\Yaml\Exception\ParseException exception and I don't want this event listener throw error


Nice, this should fix #28


`//with old sdk facebook and old ParseFBUtils...
ParseFacebookUtils.logIn(activity, new LogInCallback() {
           @Override
           public void done(ParseUser user, ParseException err) {
               onFacebookParseRegistrationEnded(err);
           }
       });

// the new sdk Parse new ParseFBUtils
       ParseFacebookUtils.logInInBackground(AccessToken.getCurrentAccessToken(),
               new LogInCallback() {
                   @Override
                   public void done(ParseUser parseUser, ParseException e) {
                       onFacebookParseRegistrationEnded(e);
                   }
               });
       return;
`

 @flovilmart the weird thing is when we point to the cloud parse works fine. When we point to our server does not work.


IntelliJ noticed that there was a new folder that it needed to exclude that folder is created during the "documentation" step of the pipeline.  Since the rest of the team never runs that step, you will never have this directory.  I, having run that phase during the initial work for the step, did have that directory.


Please remove or use `qDebug() << Q_FUNC_INFO` consistent with the rest of the code base. We should probably clean this up.


Function could be an enum


I want setting up information directly into the request attributes parameters bag


Hi.
So how is going with this branch?
Did you already wrote (and test) everything?
And what i should do? ))
We can start to merge some things, i see you created userless solving method, where all jobs from all users are solving just by their priority.

ps
Some time ago one people were asking me about method where jobs will solving by some "result" priority, that can be job priority + user priority. If users priority are the same it will be exact your case.


Had a conversation with @AbdealiJK  on gitter He said that we can use .ci/docs since that was the purpose of issue .
Line 27,28 in circle.yml in coala repo are what needs to be recreated
@vivek425ster exactly
We can probably use .ci/docs as the temp dir as its only for CI


An issue is here!


Here in line 4, there's a spelling mistake!


Oh, this'll end up below!!


Oh, this'll too end up below!!


Hey @scotthartbti why did you need to remove PIE?


seems good. I'm surprised to see that code to handle `VtableClosure` and so on was *added* but not removed from elsewhere. But I'm going to assume we'll see some deletions in a later commit.


BTW, logging an exception can be done like this : `$this->logger->err('An error occurred during SEO initialization', ['exception' => $e]);` no need for line 76


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18887](https://teamcity.mesosphere.io/viewLog.html?buildId=161097&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 254 Build time: 00:11:09


This is version 2.1.7, not 1.2.7 as indicated in the commit title.


I am having the same problem - but don't know how to use this fix - as I don't have Game event handler.cs as a file? Please describe the fix for the golden monkey issue pls


This should be https


Is this comment accurate? I think I flattened that out to use `visit_all_items` instead... and I don't see any recursion taking place. :)


Edge gesture service was depreciated and removed by cm as it was outdated
and causing problems... Pie depends on edge gesture service, so with that
being removed, pie needed to be removed as well.
On Mar 11, 2016 9:14 AM, "Matthias" <notifications@github.com> wrote:

> Hey @scotthartbti <https://github.com/scotthartbti> why did you need to
> remove PIE?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/scotthartbti/android_frameworks_base/commit/ce8b46089afc4264231244c0b8e0bd1f3e32aecc#commitcomment-16644950>
> .
>


And what is your solution for this kind of things ?


Does it have to match ? Is there an absolute requirement to match at this stage ? if there is, why ?


Actually bind is both,  static and non static.
Could you add the static back in and keep the non static? Would merge afterwards.


I think you forgot to move these tests after commenting them out


Here are the deletions I expected :)


Sounds good - pulled the commit.


@macool mira: https://github.com/GrowMoi/moi-front-end/blob/7d4f57dd2b50921e7dac7bed9e8bdf28adec0167/Gruntfile.js#L244 antes teníamos un wildcard para todos los archivos dentro del directorio scripts/ , por error en los test en el orden de cargar los scripts, @daosgc los puso manualmente, pero creo q debería haber una mejor forma... he probado con otros wildcard sin suerte :-/


FWIW, I've been told that supporting both the new (rfc 6120,6121) and the old (rfc 3920,3921) is not possible, but I don't know which parts are in conflict so verifying is tricky.


Nice pickup


Please don't push these changes. They are only for your development environment.


Trying to implement a network diagram similar to: http://bl.ocks.org/darrenjaworski/742c0864c409e9202982
but where the nodes are columns (grouped by table with colour) and links are the joins. Cardinality not used.

Currently 404s.


Good catch !


> Factor out a VerifiedDownload; only rename once *every* resource is good

This one I still don't understand:what is "every resource" and why do all of them need to be good?

Or is this about getting both the artifact and its associated SHA1 file?


It's from `trans_impl`, but I can add a fixup commit to remove it if you want me to (I won't rebase before the review is finished).


I mean I tried to use svdt with this title and it kept giving me yellow screens. some other games do this like Shantae Pirate's Curse. I should probably try on Old3DS some time.


From what I remember, You need an empty newline above the list stuff.
```
Can be "1", "tab" or "mixed"

-  "1" - 1 space after bullet.
etc
```

I think right now rst isnt recognizing this as a list because of that ?
Hence its giving an indentation error if you move it.

Have you tried seeing this by compiling the docs and opening the html file in the browser ?


I'm a little surprised we no longer call `register_foreign_item_fn`...does it get called in some other place?


private


more targetType than definition but ok.


Nope. LLVM would eliminate it instantly anyway, it was dead code. We don't want dead code, do we?


Inject each service, why ?


the ``ReactDOM`` package contains a module named ``ReactMount`` which is obviously able to render react components and can adjust a context. It should be evaluated whether this can be done in our tests.


@stefanotorresi I considered doing that. However, since its intention is for use *as an initializer*, changing the signature was necessary in order to provide a usable migration path, since the signature of initializers changes between zend-servicemanager versions.

Yes, `$container` is not used, but in zend-servicemanager v3, the first argument passed to initializers is not the instance, but the container.


Not sure I understood the problem.


Please create and link (in TODO) a re-enable ticket


Why is this an `||=`? I think you mean `=`.


if you save your figures with the appropriate file ending, it helps us see them.  E.g. .pdf, .png.  My computer doesn't know how to display your file without that specification.


When downloading a .jar we have to go back to the server and get the module.(xml|properties). Previously if that second d/l failed we just left the jar on disk and thus corrupted the repo by not having the dependency information.


Rename the probe


shouldn't this be sourced recursively through p3dx_dpl?


for perf issue I would have go for null check rather than string comparison but premature optimization is the root of all evils so let's keep that


`eppn` is too specific, use more generic `persistent_id_attr` instead.


Annotations are a good idea


never even pass a function call into a constructor. In this case APIlevel and Version are methods of IAddonInterface :)


Looks good!


Constructor arguments will have multilines. I don't like that...


it worked! thanks :+1:


A diminuição de arquivos binarios evita os conflitos de merge.


good catch


I should have said *at most* 64 bits (it may use less). The changes in ``sol_oic_repr_field`` might be not needed anymore if the macro goes away, let's see what I can get. Thanks for the input.


Should we perhaps wait a bit between retries? Maybe even increase the time, from 0 to .2, .4. .6 , etc seconds.
(Just as a possible future improvement)


An issue is here!


Using `func_get_arg` could make the job


Here in line 4, there's a spelling mistake!


This feels rather strange. The API look like you're allowing arbitrary excon options to be passed in, which seems like a sensible design, but then the code is restricting to these two. Wouldn't this be better?

    http_opts = http_opts.merge(default_options)

an then just pass that into the Excon initializer?


Of course it was also possible to get half of a `module.properties`. If the connection died at just the wrong time you'd have only some of the dependencies. "At least" with `module.xml` a truncated d/l would be more easily detected.


Oh, this'll end up below!!


Oh, this'll too end up below!!


Why don't you write `public function __construct($arg1, $arg2, $arg3)` ? I don't get it…


@dzafman how about moving the locker into `dump_ops_in_flight()`.

also shall we also hold the lock before https://github.com/ceph/ceph/blob/master/src/mon/Monitor.cc#L335 ?


@bgoodri, I was trying to figure out library linking yesterday and failed
horribly. Want to talk about it?

On Mon, Mar 7, 2016 at 4:24 PM, Bob Carpenter <notifications@github.com>
wrote:

> +1 for sans-#; I don't even like it in Jupyter/knitr.
>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stan-dev/rstan/commit/900c66be59d8029ee242e4d613aac5a8051781bc#commitcomment-16546966>
> .
>


Minor: This might've been clearer if it was done in two steps: (a) extract new partial, but still render from `_making_your_application`; and (b) move `if application_address` condition and rendering of new partial into `ips_application_result ` outcome template.


Please do not rely on exceptions for that. Exceptions should be exceptional, and not happen 90 % of the time.


lg


Do you have stitching in this probe? If there is not, then no need to generate the reconciliation data, which is used to reconcile entities that discovered by two different probes.


Rename to `mail_attr`. So consistent with existing vars using `_` not `-`.


ditto.


@Desteny

When I changed it, I was using wowwiki as source -

"Enrage
 After 54 seconds Doom Lord Kazzak will enrage, increasing his attack damage by 30%. At this time, Doom Lord Kazzak will send out 6 waves of Shadowbolt Volley. Enrage is a temporary buff that ends after the 6th volley."

Also when you check my fixes, bear in mind that I was "scripting them" to be most similar to first patch of TBC not 2.4.3


this one is coming transitively from jdbc-runtime, no need to include it.


"a ... libraries" -> drop the "a"


@pgmmpk Please review.


what is this? static overrides of IAddonInterface?

InputStream crashes because you forgot to add those static methods. this is an obvious indicator that this concept is not good.


since we have a specific configuration just for connection pool checker, we need to have a customised execution options.


An issue is here!


Yeah, I wondered about that too.

Based on my personal crappy connection, retrying without pauses works quite well most of the time. Sometimes it gives up after 3 tries, but I'm not sure a small delay would make it succeed, and waiting for stuff to die *slowly* isn't much fun either. But I certainly wouldn't object if people wanted a delay.

Another thing is maybe these things need config options. If we do that we should refactor the options consumed by CMR into some kind of options class, because there are a load of code changes to propagate each new parameter through the myriad builders, manager builders and builder managers.


Oh, this'll end up below!!


Oh, this'll too end up below!!


> When downloading a .jar we have to go back to the server and get the module.(xml|properties).

But aren't they separate artifacts? So if someone asks for the `module.properties` it should be checked separately if it exists or not and then downloaded separately. (And possibly retried and not copied there, even partly, if the download fails. But you fixed all that already)


Because I want also insert the namespace before each args in order to be sure that no error will be throw if function doesn't exist


I only use svdt on the pokemon games.


Samsung Electronics? Rly?


#ifdef HAVE_CONFIG please


Why not? If the developer writes some crap, they want to know it with a beautiful exception, not a hidden error message.


might need to use `atomic<bool>` instead.


Oh yeah sorry my bad


Good catch. Had tabs instead of spaces. Thanks!


Huzzah. The fact that we pass in `node` here and fetch the substs ourselves, rather than being given the substs, has been bothering me for some time.


This should be revised after having PR#695 https://github.com/payara/Payara/pull/695 merged to origin/master. we need to give a default value for it


__apiary.manifest contains references to non-existent files in repository.__ (Autogenerated message from apiary.io)
+ users.apib
+ domains.apib
+ emails.apib


@onel0p3z @johngills why are we pushing straight to master without doing PR ?


ah I see. that is because of clock in robot package...


Yes. Please do that. Use type hinting.


I don't like that you need to call `configure_pool` before using this object. If the decision is for this object to handle both response processing and connection pooling, then I think both aspects should be initialized at the same time.


3225775b1e:

> Revert Clinical Reminders to standard link.


`public function __construct(SeoPage $sonata, LoggerInterface $logger, FileLocator $filelocator)`


Removing.


Changed to .remove()


Perhaps you've addresses this in a later commit, but the pattern we've adopted in [marriage-abroad][1] and in [part-year-profit-tax-credits][2] is to set the calculator on the state in a `next_node_calculation` block and then assign all responses in `next_node` blocks.

[1]: https://github.com/alphagov/smart-answers/blob/master/lib/smart_answer_flows/marriage-abroad.rb#L22-L24
[2]: https://github.com/alphagov/smart-answers/blob/master/lib/smart_answer_flows/part-year-profit-tax-credits.rb#L14-L16


initial


lg


The scenario was:

1. Download foo.jar, which depends on bar.jar which defines `Bar`
2. Try to download foo.properties, but fail.
3. Process exits.
4. New process tries to resolve foo, finds foo.jar.
5. Oh good, we have it in the cache...
6. WTF is this type `Bar`?

So while they are separate *files* the presence of the jar was enough to prevent checking for the descriptor.

The only reason I found it was it happened to me ;-)


If I use type, arguments will be formatted in multiple lines like that :

```php
public function __construct(
    Type $test,
    Type1 $test1,
    Type2 $test2
)
```
because of long types name


// as well as
printf("hello world";


Oh, I see I left some dead code in.


latex-documentation-myoldmopar (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Note to self: `reuse_if_untouched`!


>  and waiting for stuff to die slowly isn't much fun either.

True ;)

I'd use for short sleeps, just so together they add up to a couple of seconds most.

Btw: does the CMR timeout test in the test suite still work now? I can imagine that this system might work too well now hehehe


Done, thought I had gotten all of them.


If the semantics is wrong it was before. As said it's not a semantic change here. But I doubt it - there is no next target in both cases. Even I would remove that method I don't think that there are commands added or removed.

However as said - when fixing warnings & in doubt (extensible tree view isn't really my area) : do not change semantics.


An issue is here!


Here in line 4, there's a spelling mistake!


Oh, this'll end up below!!


Oh, this'll too end up below!!


Minor: I think it would be clearer to either (a) change the title of the commit message to something more like "Extracted book_appointment_online? method into calculator" which seems the more important aspect of the commit; or (b) split this into two commits where the first one just introduces the calculator.


Removing.


See https://github.com/aspnet/FileSystem/pull/169#discussion_r55793374


Ok ,I understand. Still that's actually a bit crappy. It should be the one asking for the JAR that shouldn't assume the other artifact exists without asking for it.


hang on I forgot to squash a fix here.


This commit also includes typo fix and dfn/a fixes.


define api in another file


rename


大四川某三流城市表示考个好大学真不容易，可恨我高三才明白这一点


why `Option::None`?


@ShoestringTaz this is a reference to the piece of code that fixes the problem. It will be available with the next update to the tracker. (Issue #2185)


That's perfect, and completely ok. It's way, way better than breaking the Law of Demeter like injecting the container does. And if this list becomes to long (like 5, 6 arguments), you know it is time to refactor into several classes. Very handy.


Very interested in the beta2 version - have example repos if you need test subjects.


No idea. Is it still like that after all the other changes?


@sils1297 @AbdealiJK Yes it was not displaying it as a list.
A blank line will do it.
Thanks


Consequent call to `zfs_userspace` will fail for *OBJUSED objects with EOPNOTSUP, making this function return error upstack and the `zfs` CLI complain about unsupported feature or incorrect version.


Ah, it appears to be `s/option:://` that ended up with this.


Minor: It would've been clearer to have split this onto multiple lines in a separate commit. I had to use the console to convince myself that there weren't any accidental changes in this list.


feel free to change and redeploy


I suppose that when the remote server didn't have a `module.properties` we could have created an empty `module.properties` locally, so that a `.jar` would always have a descriptor of some sort, and if it was missing we should fetch it from the server.I suppose that when the remote server didn't have a `module.properties` we could have created an empty `module.properties` locally, so that a `.jar` would always have a descriptor of some sort, and if it was missing we should fetch it from the server.


I've enabled the feature but did not instruct ZFS to upgrade the objspace using a call to `zfs_ioc_userobjspace_upgrade`.


make this `pass`, more pythonic.

And are we sure that it wouldn't return `ValueError` on any other scenario?


I suggest put struct definition just before its methods


You have committed your changes into a new branch and uploaded it correctly. You can always check your uploaded files on Github site in any browser. If you can't find your files, then some problem seems to have occurred.


This is doing index simplification of list tensors, right?  Is this necessary for the trace element stuff, or is it a general "nice to have"?


Minor: I think it would've been clearer to have this in a separate commit.


Could we put it in `base.py` instead of making a new file?


Indentation, should conform to above line.
```
:param tslint_config:   Path to configuration file.
:param rules_dir:       Rules directory
```


Actually after looking at BatchCom again, that blue line was always there and is part of an SSI that includes a special BatchCom email notification link. As such, I just removed our styling from it and left it the way it was originally: which was 2 "title"-classed spans. One for the SSI, one for "Batch Communication Tool".


Tried your code. The placeholder directly gets directly displayed, I don't have the animation like with input or textarea, where the label appear only when I entered some texts.
What should I do?
Also the text in the select gets cut atthe bottom I don't see the bottoms part of p or y. Do see you what I mean?


oh! heres another one. Good Job


еще форматируй
условия ифов с новых строк пробелы после и перед знаков операций
НИКОГДА не используй счетчики i1 i2 i3, если не несет смысловую нагрузку, есть  j.k.l и еще много буков iterator counter и прочее


delete unnecessary comments


why break this up in two lines?


Ah, so these few lines (116-119) are unnecessary then?


its an option bro :)


@weierophinney hmm okay I got it, but couldn't this be simplified in:

```php
public function populateFactory($containerOrInputFilter, $inputFilter = null) {
    $inputFilter = $containerOrInputFilter instanceof ContainerInterface ? $inputFilter : $containerOrInputFilter;
    // ...
}
```

and let `$inputFilter ` be null to avoid the BC break?


tabs everywhere :o


When I saw this form, I was thinking it should be called `empty(hashingStrategy)`. I looked around and we're not always consistent. For example, you can call `SortedSets.immutable.empty(comparator)` but if you want a mutable one, you have to call `SortedSets.mutable.with(comparator)`. I think it would make sense to add an `empty` overload here.


I'm regrouping with the dev team to discuss the SASS. We want to make it so that the developers wouldn't need to run SASS compilation unless making a change that specifically affects the Bootstrap theme.

After any changes required for that process are made, we'll probably need to rebase again and have a start the review cleanly from there.


Minor: As before, it would've made it easier to check the list hadn't changed if this had been split onto multiple lines in a separate commit.


Its an other option bro :)


This is a bad idea, because there is no gem for Puppet 3.8.6.
https://rubygems.org/gems/puppet/versions/3.8.6


how about KubernetesProbe to TargetProbe o GoProbe?


RE:  00-fork_repo.md
Hello @amn34
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:


lg


Yes, it is an index simplification for list tensors. It is becoming necessary, as we currently tabulate trace elements on the cell, or a derivative of trace element, and then throw it away during the simplification. These tabulations become illegal (as they should be) with the new trace element, which makes it necessary to do the simplification earlier.


An issue is here!


сложна
упрощай код


Here in line 4, there's a spelling mistake!


Oh, this'll end up below!!


Oh, this'll too end up below!!


`NSMain` is called when a native module is required. I guess I could named it `Require` or something like this. I came up with `NSMain` for no particular reason. Its sole purpose is to provide a mechanism for a native module to initialize itself. I wanted to provide something similar to the `exports` object which is used for CommonJS modules. Hence `NSMain`.

Also, this should not be confused with a some general purpose library mechanism. For that purpose there are `java.lang.System` class provides `load` and `loadLibrary` methods.


You are not closing the server if this test don't fail.


I think this is redundant. Yes the json-c documentation doesn't mention that, but NULL is a valid JSON value (see json.org) and we can more-or-less assume it is a valid value whenever a `struct json_object *` is expected. See the [json_object_get_type](https://github.com/json-c/json-c/blob/537f8bcbdbdc10ffa7673199a0be82ca4eb56ec8/json_object.c#L231) implementation for example.

There's a possibility of course, that that will be changed, but I would say it is remote. Meanwhile we can save on code lines :)


Not sure why this happened. Ive double and triple checked my Sublime settings :\


Yes, because you will always return before reaching these lines.


What about AppCirclebar, it does not not depend on edge gesture service?


RE:  00-fork_repo.md

Hello @ceciliawong15
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:


Rename to `full_name_attr`. Because used for what OC calls "Full name" and `eduPerson` spec contains another attribute `displayName` which isn't mandatory and not always full name, compared to `cn`.


latex-documentation-myoldmopar (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2167 of 2167 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


been using git pull extensively on a shallow clone while testing the last few days... does not seem to cause problems but I'll keep an eye on it for any shortcomings.


This commit breaks the build for me on Linux with gcc 4.8.4: https://gist.github.com/darealshinji/270600b85f9ee3ad4704


Nope.
On Mar 11, 2016 9:46 AM, "Matthias" <notifications@github.com> wrote:

> What about AppCirclebar, it does not not depend on edge gesture service?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/scotthartbti/android_frameworks_base/commit/ce8b46089afc4264231244c0b8e0bd1f3e32aecc#commitcomment-16645759>
> .
>


I'm assuming here that we'll only get an intrinsic call if the type is TyFnDef -- I guess we don't permit making fn ptrs from intrinsics? (Can't remember precisely.)


RE:  00-fork_repo.md

Hello @chris-graham
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:


I think that this check could also be removed.


instead of spliting and joining why not look for the first occurence of `:` and then substring from there? I think it would be less code and easier to read.


My point is, sometimes warnings are a hint that semantics are wrong. In that case, if the warning is resolved by keeping the semantics, we may be hiding a bug.


latex-documentation (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1579 of 1579 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.85%25-green.svg)


Let's use https://github.com/aviarypl/team/issues/5 to sort it out.


max - min
подсказк


2034-airloop-schedule-crash (kbenne) - i386-Windows-7-VisualStudio-12: OK (2373 of 2397 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.0%25-yellow.svg)


Oh of course, I see it now. I'll remove this in my next commit.


Are there expicit expectation operators in this model?


CopyPasteProgramming


Won't this *always* be evaluated as true since local loaded = false the line above?


I have corrected this.


Minor: Very long line in commit note.


RE:  00-fork_repo.md

Hello @dkanarek12
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:


Несколько комментариев:

- используйте трюк с if __name__ ... Тогда сущности из этого скрипта можно будет переиспользовать.
- def process_qiestion(question): -- опечатка в названии функции, pycharm подсвечивает опечатки по-умолчанию.
- лучше проверять на None вот так:
`if smth is None:`
  Во-первых,это быстрее, во-вторых, PEP 8.
- Как ты добавишь в этот код поиск слов по синонимам (разрешишь вводить IDEA вместо IntellijIdea)?


Pretty sure you didn't mean to tag me in this, just a heads up :)


Good call. :+1:


RE:  00-fork_repo.md

Hello @lizbianco
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:


да, залил первое дз, сделал pull request

2016-03-11 10:34 GMT+02:00 Nikolay Lositskiy <notifications@github.com>:

> А вы просили отсрочку?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Fomenko-Slava/learn_ruby/commit/96afdd5d2e1e93f31a7869dda896f7c2d550aa85#commitcomment-16638357>
> .
>


It's still highly experimental.

I'd say that until 2f8623302ca62238e3f312eb9940e3a62f998557 it should work, although this is not what we use in production, so it's been only locally tested.

Beyond this commit, it is a slightly longer term work, which is taking shape while I'm writing it. And also, I only care about linux for know, as a draft.

The last commit a4e03a7f932ae2a77c963943051a548dc3d9e55d shows a little more toward which I'm trying to go (see also the updated README). The idea is to have exactly 3 threads: `Emitting`, `Receiving`, `Processing`. The first two are based on `AfQueue`, and are kinds of "half-queues" in which you can respectively only write and only read.

As this breaks the concept of request/response, I added a notion of message ID: the emitter tags the message with an ID, and when a message is a reply that needs to refere to its original request, it provides this ID in the answer as a Response ID. I still don't know exactly when there will be an actual use for it, but I'm already using it, and the fact that the ID is ever increasing, to obsolete messages older than a given ID and then ignore what could raise inconsistent states.


RE:  00-fork_repo.md

Hello @ekruskal
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:

But, to render it in markdown, surround it by ":"
Example:  ":thumbsup:"


Didn't you delete too much at line 9365-9372??


No not at all Seek needs to update prevOffset. We need to know if we need to fetch a new reader before reading. It saves currOffset before it changes in Seek.


Ha. Russel Spitzer. ... dar. Thanks for the heads up.


As far as I know that is not the case, but I am puzzled by their using of ```add_auxiliary_variables_to_steadystate``` in their steady state file. Are we sure this is a Dynare bug? Or  is this a user error?


Is it normal that this doesn't work when changing from this controller? All I see is
```
State changed: true (boolean)
State changed: false (boolean)
```

For instance...


Thanks for this, this seems to work well and is really a useful feature. I'm currently using this on a large enquiry form with multiple field-sets.

I noticed that this is restricted to fieldsets within the form or CiviCRM custom fieldsets/default fieldsets is that correct? Do you think this would be more suitable to lock specific fields rather than an entire fieldset, so the user has more control over locking individual fields?

Also, would it be at all possible to lock the Existing contact field for situations where this is auto-filled through the URL?


Why not only "period" instead of "metricPeriod" ?


before this were we just creating multiple ValueRefs for a static?


Honestly I was hesitant adding pie to begin with... Its outdated and seems
like its pieced together to allow it to work.... Cm removing edge gesture
service was the nail in its coffin... Of course I could've kept edge
gesture service, but obviously they removed it for a reason.
On Mar 11, 2016 9:47 AM, "Scott Hart" <scott.hart.bti@gmail.com> wrote:

> Nope.
> On Mar 11, 2016 9:46 AM, "Matthias" <notifications@github.com> wrote:
>
>> What about AppCirclebar, it does not not depend on edge gesture service?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/scotthartbti/android_frameworks_base/commit/ce8b46089afc4264231244c0b8e0bd1f3e32aecc#commitcomment-16645759>
>> .
>>
>


RE:  00-fork_repo.md

Hello @deenhe91
cc:  @reshama @aramnath @Vinoad @JoelWesley

Where's the emoji? :question:


this sets the first not-the-one-we're-stealing NIN to primary I think? shouldn't it operate only on the old_user's *verified* nins?


Looks good.


TODO: Coloca o arquivo ``.env`` dentro ``.gitignore`` do projeto.


Несколько замечаний:
- добавь папку  .idea в gitignore. После этого удали ее из репозитория (в таких случаях всегда советую сделать бэкап). Не нужно делиться своими настройками проекта со всеми участниками.
-


Changes


as this is a user-facing error, it should use `{}` (and we should implement `Display` for `Instance`)


Also comments should have a space after // . Will accept this but we have to make that consistent everywhere.


I think it would be "lowest" (safest) possible level without this set. See http://www.postfix.org/postconf.5.html#compatibility_level


RE:  00-fork_repo.md

Hello @hayattoku
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:


This is where @Procrat proposed changes come in to effect. All User.query should be changed to session.query which is available to import from battlebots. I don't have time for this now.


change: use `Display`, not `Debug`


Yes, that's the main idea. But it doesn't make much sense now that the adapter isn't changing. I would wait until the other pull is merged.


fixed up


Great.  What did you do?


RE:  00-fork_repo.md

Hello @IanLondon
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:


**[unitTests_php_contractual_responsibilities run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_contractual_responsibilities/1237/testReport/) for this commit**


Don't think so, it was probably cached through some other map.


it looks good, but i wonder where it's being used. I did not find any place checking it


It doesn't matter that much, but I find it a bit weird that this is considered part of pre-processing. To me, pre-processing is typically enhancing the markup, generating boilerplate, etc. while what happens here is really just braille transcription.


@roundrobin99 Yes.  So it's consistent with PTA and has the proper official wording from GDS.


This should still be a new-style class, i.e. subclassing object. Its a silly Python internal detail but something QuantifiedCode and other tools rightly complain about.

(The fact that the class name is all lower case is not in line with modern style guidelines, but we don't want to break backwards compatibility here unless we have to)


RE:  00-fork_repo.md

Hello @lpalova
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:


We really need a way to print `(DefId, Substs)` that uses the same format as `TraitRef` if `Self` is present - I was just telling @tsion about this.


It is explained in CDI-441 and also in Jozo's mail on cdi-list -http://lists.jboss.org/pipermail/cdi-dev/2014-June/005082.html

In short, it is about the line starting with ```a bean Z exists, ...```. This one can be interpreted as a redundant extension of the previous line instead of being understood as a transitive relation.


Ah, that is the problem, I thought this was a General purpose library mechanism.  So we can't use "require" as a general purpose load/loadLibrary.   :disappointed:      Thanks, that does answer the question!


RE:  00-fork_repo.md

Hello @maxmelnick
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:


I believe we checked with Steven and he wanted the updated wording


So should I use the Regexes that are available then, or just write a new general one? I limited it to youtube and vimeo because these 2 are the ones that a user would most likely want to embed. I'm not sure what would happen if a regular webpage URL for example is pasted and parsed by the oEmbed service?


RE:  00-fork_repo.md

Hello @applebym
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:


Good point. Thank you.


So I think we still have an open question whether O'Reilly we re-do the figures or whether we should make a pass to clean them up and maybe replace dia with fig.


What happens if someone specifies an invalid value for "rollForward", say, "apple"? Would we rollforward, not rollforward or error out?


Good revision


If I use a connect with an auxiliary function, e.g.:
`(params, stc, [(("slice_order", sum_one),   "slice_order"),]),`

I get this error:
`TypeError('unorderable types: tuple() < str()',)`

Can't sort tuples against strings.


RE:  00-fork_repo.md

Hello @patricknieto
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:

to render the emoji in markdown, it must be enclosed by a colon on both sides :money_with_wings:


Minor: There's a very slight change in behaviour here. If `ALT_EMBASSIES` included a key with a `false`-y value, then previously the block would've returned the `false`-y value; whereas now it will return the `current_location`. However, given that `ALT_EMBASSIES` doesn't contain any `false`-y values and we probably never want to return one from the block in any case, this seems like an improvement, but it might be worth noting in the commit note.


RE:  00-fork_repo.md

Hello @peter-gray-rasmussen
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18888](https://teamcity.mesosphere.io/viewLog.html?buildId=161104&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 254 Build time: 00:05:05


https://github.com/openvswitch/ovs/commit/d273f03533d62eab41479f01804e6b00910cfb5e  Fixes the issue.


RE:  00-fork_repo.md

Hello @rachaelrho
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:

To render the emoji in markdown, enclose it by a colon on both sides :grin:


latex-documentation-myoldmopar (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Most likely this was a direct conflict resolution choice written to the file by git, since there have probably been a lot of authors added since Cypress.


RE:  00-fork_repo.md

Hello @ZakkirGanesh
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:


I can't find any information on what's current actual compatibility level. It seems they don't provide it and instead rely on error messages which specify needed level for each feature. They also advise to set it to 9999 "at your own risk".


Dear @neyensp,

Could you please verify if our solution in PR 39 (https://github.com/Bynder/drupal-media-bynder/pull/39) has solved your issue?

With kind regards,

Thomas Moors


@val99erie Can this go in your global gitignore, rather than in project's .gitignore?


`optarg` can only be NULL, if the option was specified to getopt_long as having optional value and the value was not specified on the command line. I.e. only due to a coding error. However, we still need to protect against *that*, but we need to change the message to say that option value is missing (and not empty) and not print out the command-line help as that's not a user mistake. I would put an `assert(optarg != NULL)` above that as well, so we crash ASAP in debug build and have little opportunity to mask this with some other error following that.


RE:  00-fork_repo.md

Hello @stewartstout
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:


Вы проверите это дз, или я уже не успел и проверяться это дз не будет (

11 марта 2016 г., 16:50 пользователь Слава Фоменко <fomenkoslav@gmail.com>
написал:

> да, залил первое дз, сделал pull request
>
> 2016-03-11 10:34 GMT+02:00 Nikolay Lositskiy <notifications@github.com>:
>
>> А вы просили отсрочку?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/Fomenko-Slava/learn_ruby/commit/96afdd5d2e1e93f31a7869dda896f7c2d550aa85#commitcomment-16638357>
>> .
>>
>
>


Maybe just explain a bit what happens as a side-effect here (i.e. that the hash is regenerated during each put()).


RE:  00-fork_repo.md

Hello @whugue
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:


O'Reilly won't let us put parens in a section heading


RE:  00-fork_repo.md

Hello @zhannar
cc:  @reshama @aramnath @Vinoad @JoelWesley

cool choice of emoji!  :thumbsup:


Yup, you are correct, but this is OTPHelper, and someone trying to inject a slot0x05 type NAND backup is most likely just trying to inject a bricked one.


I never noticed the cool short commit hash ;)


ksadsadksa


@landreev I see you softened my warning about the importance of running the `post-install-api-block.sh` script. I'd go the other way and put **VERY IMPORTANT** in all caps. :)

On a related note, the installer ends with a fairly bland statement that we should probably improve to emphasize the security implications of only considering the running of the script and not actually running it: "Setup done. Consider running post-install-api-block.sh for blocking the sensitive API."

See also:

- [Any Last Minute Security Details Before Going LIVE - Google Groups](https://groups.google.com/forum/#!topic/dataverse-community/BhOFjm7BOAc)
-  Enhancements to API blocker #1886


@romainhild I think you're right but won't it be `/usr/local/bin/zsh` as that is where the post install bin files are ?


refs #18


You mad?


Minor: I'd prefer to use another stub instead of `OpenStruct` here. Also I tend to use hyphenated rather than underscored strings in this kind of scenario, because it makes it easier to search (& replace).

```ruby
@calculator.stubs(:world_location).returns(stub(name: 'world-location-name'))
```


right beneath Q1 on the deenhe91-patch-1 branch


Yes I'm


**[unitTests_php_contractual_responsibilities run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_contractual_responsibilities/1239/testReport/) for this commit**


I did this to prevent having a long list of arguments for the credentials, http settings and pool settings. Doing so would make it look similar to what the initializer before this refactor.

I think it would look something like this:

```ruby
class SendgridApi
  def initialize(api_user:, api_key:, http_opts: {}, pool_opts: {})
  end
end

SendgridApi.new(api_user: api_user, api_key: api_key, { timeout: 2, persistent: true}, {pool_size: 5, pool_timeout: 1})
```
Is this what you have in mind? I find it better to split out the connection pool arguments from that list. Would it make more sense with a different name, maybe something like `establish_connection` ?


Also, the commit message must be updated to reflect the renaming of "dn-" to "obj-".


The assignment arrows aside, I think we should let the format of the code-base remain.
The general format is `( 0 == object.function )` instead of `( object.function == 0 )` as I've noticed with all of the code having patters like above. Example` ( null == something)`, `( 0 == something )`.
It's a better practice and accounts for readability.
Although I can be wrong also.


Maybe self.generate_constant_hash_ctx or something like that? Trying to get across (when this is used below) that the same string is used each time, so that devs don't have to keep referring back to the generator function to see exactly what's going on.


Minor: Given that this assertion has been removed, it might be worth "replacing" it with a "view" unit test like [this one][1].

[1]: https://github.com/alphagov/smart-answers/blob/master/test/unit/smart_answer_flows/part_year_profit_tax_credits_view_test.rb#L62-L65


**[unitTests_php_contractual_responsibilities run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_contractual_responsibilities/1240/testReport/) for this commit**


Merge bug fix.


Is this a bug? It looks like you're checking if `Accelerator.Color` exists, but then dropping `Practice.Color`.


Might want to change this varname.


What is the pythonic way? `return None`?


Tyler Bezuka


Un peu plus d'explications :
On a ici un salaire de base moyen de 1250€ par mois, donc inférieur au SMIC.
Avant le commit en question, l'assiette de cotisations sociales finissait par ce retour :
```python
max_(assiette, smic_proratise * not_(apprenti))
```
Les cotisations étaient donc calculées sur une assiette 12% plus élevée, ce qui donne au final un salaire net plus faible, et donc logiquement (j'imagine) un RSA plus élevé.
Pourquoi est-ce le seul test qui plante ? Peut-être parce que les autres tests RSA prennent en entrée un salaire net pour ne pas dépendre de la partie prélèvements sociaux sur les revenus d'activité.

A mon avis il est donc sûr de mettre à jour ce test avec le nouveau montant (110)


IKEv2 doesnt have a concept of phase 1 and phase 2. The initial exchange in IKEv2 (known as Phase 1 in IKEv1) covers both the establishment of the IKE SA and establishment of the first child SA. Hence in IKEv2 there is no “phase 2” after the initial exchange (at least not until the first child SA needs to be rekeyed).

IKEv2 specification
https://tools.ietf.org/html/rfc7296#section-1.2
“
Communication using IKE always begins with IKE_SA_INIT and IKE_AUTH
   exchanges (known in IKEv1 as Phase 1).  These initial exchanges
   normally consist of four messages, though in some scenarios that
   number can grow.  All communications using IKE consist of request/
   response pairs.  We'll describe the base exchange first, followed by
   variations.  The first pair of messages (IKE_SA_INIT) negotiate
   cryptographic algorithms, exchange nonces, and do a Diffie-Hellman
   exchange [DH].
”

Difference between IKEv1 and IKEv2
https://tools.ietf.org/html/rfc6071#section-2.3.1
” Protection of IKE messages based on ESP, rather than a method
        unique to IKE
”

IKEv2 uses the same protection for IKE messages as for ESP. So if one wants to use GCM for ESP, one will also have to use GCM for IKE messages.


sadsad


reset


Rename to `identity_provider`.


Ravi can you take care of this?

On Fri, Mar 11, 2016 at 9:39 AM, Sarah Griffis <notifications@github.com>
wrote:

> feel free to change and redeploy
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hks-epod/paydash/commit/17781458b3fcadd65830c03a1e1c12d47d63a92e#commitcomment-16645584>
> .
>


Minor: `OpenStruct.new` -> `stub`


We don't need to extend this code to support NULL optarg, as we don't support optional values for this type at this moment, same as above. So we can have a guard assert and condition before this, same as above.


yes indeed !


I'd prefer to keep Excon as an implementation detail, if we allow arbitrary excon options then we are coupling this class with Excon. Also we don't yet need to configure excon with any other parameters so I'd wait until we need it


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18890](https://teamcity.mesosphere.io/viewLog.html?buildId=161123&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 254 Build time: 00:04:53


The path is set for your path how should we manage this not being changed every time we push a commit?


How does `symlinkJoin` differ from `buildEnv`?


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/28649/testReport/) for this commit**


**[unitTests_php_contractual_responsibilities run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_contractual_responsibilities/1242/testReport/) for this commit**


I'd like to revert this.  It's the object that generates the numbers, not the class, but we can't use the word object yet.


Hey, why didn't you use "cleanup" here ? :p


Yep, will update


"catches"


A fix for https://github.com/M66B/NetGuard/issues/211 ? Niice


re: git pull and shallow clone - maybe I was mis-remembering then. Apologies for any red herrings!


Yes, you are right, im not sure about those licences.

Also, yours (it is also mine), Doesn't have a near enity check. That means it'll always spam packets. (Even if there's no one near you.)


Aah!  I have not seen branch use with dsp, but that is ok.
:upside_down_face:

cc:  @aramnath


Well, that's what happens when you comment on work that's not even in a PR at 2:30am :-)
Good luck with that!


could just do `rails db` to connect to db in psql


@ThomastheBicyclist I just noticed this floating `states: [...]` thing.  Can you take a look?


An issue is here!


Here in line 4, there's a spelling mistake!


Oh, this'll end up below!!


Oh, this'll too end up below!!


I'd add lines 27-32 into the try/catch statement so that it doesn't try to null.nextLine()


look


It uses `lndir`, i.e. directories aren't symlinked but re-created instead.


maybe this should be before the this.force_disabled = true


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18889](https://teamcity.mesosphere.io/viewLog.html?buildId=161116&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 254 Build time: 00:10:10


I think .oppia-toast will do?


bind'9.10 以上 才支持，bind9.8没有测试过，请测试成功后再提交。另外，请注释掉这些命令，默认不开启，不是所有的DNS都是公开的。


ugh... such a pain... Im debating on this or just waiting for them to merge everything into the main branch, but who knows when that will be...


latex-documentation-myoldmopar (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1021 of 1021 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-30.56%25-green.svg)


@ar4mirez : @mrferos and I were working together from my machine to resolve the peer dependency issue last night.  You can revert that change.


Tyler


Nice correction


@hzoo Why? :( Any trouble with single quotes in jsx?


PogChamp


My mistake @maya. I'm going to open a PR with the change above :point_up: and the comment I emoji-fied further up :+1:


describe('warnings', ...

(This should read as a sentence clause, basically -- "this test describes warnings".)


ditto


```
hi
```


LGTM


Hola veo que has seguido puliendo a Rosadin y se agradece, tengo 2 canales que no puedo reproducir correctamente, abren pero se quedan congelados y no sé si es falla de los enlaces o del programa, ojalá me puedas ayudar
Saludos :)

#EXTINF:-1,Holvoet HD 720P
http://wow2.cl.digitalproserver.com/holvoet/holvoetvivo/mp4:livestream1/playlist.m3u8
#EXTINF:-1,ITV HD 720P
http://wow2.cl.digitalproserver.com/itv/itvvivo/mp4:livestream1/playlist.m3u8


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 18891](https://teamcity.mesosphere.io/viewLog.html?buildId=161126&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 254 Build time: 00:04:48


```
 class ListViewAdaptor extends BaseAdapter
    {
        String[] name={"양소현","유슬기","김정민","김동희","고민규"};
}
```


If you add messages 'A', 'B', 'A' and then delete 'A', the result should be 'B', right (with no other 'A's)? Maybe test that as well; ditto for warnings.


This needs to be changed? I got a syntax error that this function didn't exist.


https://developer.android.com/preview/api-overview.html#android_for_work

There's:

> Always on VPN
>
> Device owners and profile owners can ensure that work apps always connect through a specified VPN. The system automatically starts that VPN after the device boots.
>
> New DevicePolicyManager methods are setAlwaysOnVpnPackage() and getAlwaysOnVpnPackage().
>
> Because VPN services can be bound directly by the system without app interaction, VPN clients need to handle new entry points for Always on VPN. As before, services are indicated to the system by an intent filter matching action android.net.VpnService.
>
> Users can also manually set Always on VPN clients that implement VPNService methods in the primary user using Settings>More>Vpn.
>

Not sure, but that means it now has a fix for the start up leak issue? Hope it's not limited to Android For Work enrolled devices.


As a matter of readability and maintainability I would probably rather do:
```
if (content_box.search_bar_handle_event (event))
	return true;

return false;
```


could maybe include the erd to refresh memory's about the domain


*readability


I suggest updating the comment to reduce confusion, it doesn't match the variable names.


RE:  02-editors.md
hello @deenhe91
cc:  @reshama @aramnath @Vinoad @JoelWesley

Emacs and Sublime sound great! :+1:


According to [this](https://gcc.gnu.org/projects/cxx1y.html) you need at least 4.9 to use generic lambdas.
By the way Visual Studio 2013 is not supported because of this too.


oops - should I add it straight to the master? It should be changed to a grin now.. good to know that upside down face is doable on slack. I'm not sure how I'd get by without it! Haha


Thanks for sharing insights with me. Agreed, I highly appreciate your decision.. even if taking a feature away does not feel good (from an end-user point of view).


我写了到Level 2的程序，可以是任意的字母，也可以任意长度。大家可以来看一下，提些建议。[https://github.com/UncleSandwich/ComputationalPhysics.git](https://github.com/UncleSandwich/ComputationalPhysics.git)


yes, it's best to have it on master.  Easier for us to check.


Sorry, maybe I was unclear. The comments here are good, but I also meant that this is a good place to describe the format of the things that are stored in this object. I.e., say something like:

```
    Each item in each of the arrays here is an object with two keys:
    - type:  ...
    - content: a string containing the warning or info message.
```


"Our schema defines the structure of our app's db"


I guess this is legacy, but can we get rid of it and use the length of the arrays instead where it's needed?


NP.
On Mar 11, 2016 10:18 AM, "Matthias" <notifications@github.com> wrote:

> Thanks for sharing insights with me. Agreed, I highly appreciate your
> decision.. even if taking a feature away does not feel good (from an
> end-user point of view).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/scotthartbti/android_frameworks_base/commit/ce8b46089afc4264231244c0b8e0bd1f3e32aecc#commitcomment-16646577>
> .
>


Are we splitting Dynamo out into multiple install directories? Would be cool if Dynamo for Revit was update able separately.


I'm not sure these 2 tests are working : whatever the value of the metricPeriodSort is, the result is always green


A more intuitive method name would be preferable, such as "getAll" or "getItemValues"


You, really :)


For instance, expected result is the same as previous test.


(_bit) is missing here


looks good


These constants (`destAbsPath` and `srcAbsPath`) are populated by Modeshape in the underlying event creation?


Tu veux pas nous mettre des petites photos de rendu directement ?


@racaljk 教育资源不均衡的问题，其实国内一线城市的学生努力学习，大概才能得到美国的孩子
无需太多努力就能获得的东西。

上个好大学肯定是每个人都想要的，不容易考就更要加把劲了。
其实，很多事顺应本心，顺其自然总能得到好的结果。然而，我们经常都忘了自己最想要的是什么（本心）


Is this supposed to be while(rs.next())? Or am I just being stupid?


The code does not comply to PEP8.

*PEP8Bear, severity NORMAL, section `autopep8`.*


May be just use the way like
```
if (this.format.quotes === "single" && this.format.jsxQuotes !== "double") {
```


Minor: Why not make `PassportAndEmbassyDataQuery.new` the default argument value?


Image Is broken
![d](https://cloud.githubusercontent.com/assets/12488826/13706426/0fb67564-e773-11e5-9d87-50398e83563c.png)


Yes. I've been sloppy with this, sorry. Pushing a fix in a second.


:+1: Good call, gonna keep it simple.


**[unitTests_php_contractual_responsibilities run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_contractual_responsibilities/1245/testReport/) for this commit**


I'm getting an error on my final 'else if' statement. I've checked multiple times for syntax errors. can't find anything


Yes, they are. As far as I could tell, this is the only way to retrieve the source location of a MOVE event.


@karolyi FWIW I spent the rest of the day fixing taupage, many more things came to light


test yapiyorum


In two lines instead of one like it was before?


You are right. I've just updated pull request.


@ogoffart @danimo review?


Minor: As well as moving it, you've changed the name of the method (very sensibly). It might be worth mentioning that in the commit note.


@JohannesPfeifer please fix the copyright dates on these files to be 2016


Can you post the exact error you're seeing?


commentle


Minor: Again maybe note the change of method name in the commit note.


i do not know what i can do


I guess the most of these changes is because of comparison-is-always-true warning. I see no other options to suppress it in a different way (except compiler flags which is not an option as I understand).


I can imagine :)


TeamCity libpalaso :: palaso-precise64-libpalaso-2.6 Continuous [Build 2.6.1063.62c14d939e53bc6932eb2b4d7c10a7fa61b54838](http://build.palaso.org/viewLog.html?buildId=70257&buildTypeId=PalasoPrecise64v26Cont) outcome was **SUCCESS**
Summary: Tests passed: 3419, ignored: 107 Build time: 00:06:53


Uncaught SyntaxError: Unexpected token if


No I said it, `pass`

```python
try:
    blah
except:
    pass
```


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.704.62c14d939e53bc6932eb2b4d7c10a7fa61b54838](http://build.palaso.org/viewLog.html?buildId=70258&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3439, ignored: 126 Build time: 00:06:08


The JSON error format is in-line with the `oauth/` endpoints.


Though it would be better to use constants for that: https://git.io/vaG3R. I can include a follow-on PR, if you would like.


one is ascending, the other one is descending, so the result are different. You can check the setUp() lines 80-81


But you are better off with @AbdealiJK's solution, of `if`ing for empty json


**[unitTests_php_contractual_responsibilities run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_contractual_responsibilities/1246/testReport/) for this commit**


post-mount文件位置是在这吧，
 /jffs/scripts/post-mount
我按你的来的，ss-redir根本没执行过 。。。


Inner loop removed in later commit


Thanks, I need to pick it up as well.


it's too early in the morning for me to be making commits
fixed and amended


This commit is missing a tag. Talking to @karenzshea about adding one.


I think that should be left to oEmbed. You can successfully embed for example [page from amazon.com](http://embed.ly/code?url=http%3A%2F%2Fwww.amazon.com%2Fgp%2Fproduct%2FB00TU9UFTS%2Fref%3Ds9_nwrsa_gw_g318_i1_r%3Fie%3DUTF8%26fpl%3Dfresh%26pf_rd_m%3DATVPDKIKX0DER%26pf_rd_s%3Ddesktop-2%26pf_rd_r%3D14AHY6MSS2ZWX8TPPGW5%26pf_rd_t%3D36701%26pf_rd_p%3D2091268582%26pf_rd_i%3Ddesktop). So I would prefer if the code just tested, if pasted text is URL and paste it further. If oEmbed returns embeddable content, hooray, we can embed it. If it doesn't return anything, the plain text should be pasted.

And the same would go for embedding without oEmbed. If `Embeds.prototype.parseUrl` recognizes the url, it will embed it. Otherwise it should paste plain text.

What do you think?


nvm


**[unitTests_php_contractual_responsibilities run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_contractual_responsibilities/1247/testReport/) for this commit**


Yes, it is. However, it is also dead code. (It follows the create schema, so the Color object cannot exist.) That's why it stayed undetected for so long.


@dspork  So there is no technical reason then. Just to match the content. We shouldn't have implemented it in my opinion at this stage.
@andrewgee  Yes I know Steven wanted this, but we should have waited until it had been properly checked and implemented.


This breaks the configuration, `class` should be the bare class name. `"stream": None` should be added to the dictionary separately.

https://docs.python.org/3/library/logging.config.html#dictionary-schema-details


Docstring added later:
```
    Wrapper for RawQuerySet objects to make them behave more like
    normal QuerySet objects
```


@chrisnatali hmmmm


Yeah, server-side javascript is handled by npm, client-side javascript is handled by bower.

"xpathValidator" is this file in our repo: https://github.com/dimagi/commcare-hq/blob/master/corehq/apps/app_manager/xpath_validator/nodejs/xpathValidator.js, which is a thin wrapper around a javascript xpath parser we maintain: https://github.com/dimagi/js-xpath (which was already used extensively in formbuilder). Does that answer your question? Exit codes 0 and 1 are the only ones explicitly returned by that process, so anything else means something went wrong in the process itself (as opposed to xpath being invalid).

I agree with @snopoke that it looks like you were guarding against not having run `npm install`, which I think just makes it fail more silently and convolutes the code.


We don't use the backslash in general for strings


Minor: Counter-intuitively, I'm pretty sure `next_node` is evaluated *before* `calculate` (see [docs][1]) and so I think you could use `calculator.application_action` here. However, I imagine this block is going away anyway.

[1]: https://github.com/alphagov/smart-answers/blob/master/doc/storing-data.md


not sure why I renamed this


A question since I'm not sure how these scripts work, is there a reason why latency-msec=1 has been changed to latency_msec=1**k**?


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/28656/testReport/) for this commit**


You should make a tag on github as well


Strange.  Re-committed.

From: Maria Mikhno [mailto:notifications@github.com]
Sent: Friday, March 11, 2016 8:55 AM
To: CISecurity/OVALRepo
Subject: Re: [OVALRepo] Update oval_org.mitre.oval_var_1711.xml (ae59ce3)

Why this variable doesn't change?

—
Reply to this email directly or view it on GitHub<https://github.com/CISecurity/OVALRepo/commit/ae59ce3db64db24d3752545e27b60f667ce105f5#commitcomment-16644490>.

...
This message and attachments may contain confidential information. If it appears that this message was sent to you by mistake, any retention, dissemination, distribution or copying of this message and attachments is strictly prohibited. Please notify the sender immediately and permanently delete the message and any attachments.

. . .


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.713.62c14d939e53bc6932eb2b4d7c10a7fa61b54838](http://build.palaso.org/viewLog.html?buildId=70259&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3419, ignored: 107 Build time: 00:05:46


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/28657/testReport/) for this commit**


**[unitTests_php_contractual_responsibilities run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_contractual_responsibilities/1248/testReport/) for this commit**


Geometry requires a valid mesh in its constructor https://github.com/ORNL-CEES/Cap/blob/master/cpp/source/geometry.templates.h#L170


Verify "@predelete');;" to "@predelete');"


Won't this get the global `layer_height` setting rather than the meshgroup's setting?


Related: #81 and https://github.com/eXistSolutions/hsg-shell/commit/be97b8661e5bac03c5886db2e80030d8256113bb


Seems this has always been broken....


I know, it’s for a school project and I have to make it local for now.

> On Mar 10, 2016, at 9:26 PM, Ricky C. <notifications@github.com> wrote:
>
> You need to make these relative urls. They are linking to your local desktop.
>
> <button onclick="window.location.href='SSHomepage.html'" id="Home">Home</button>
> —
> Reply to this email directly or view it on GitHub <https://github.com/InspectorElement/Party/commit/1b4d2b1beb4b67637baf1618b9f2854928a89bef#commitcomment-16634759>.
>


Cool. Thanks for the clarification. I'll drop this commit from the branch/PR.


Yeah, you're right. So I guess it would be more appropriate to put this logic in block-translate.xsl ?

In any case, we're going to disable this functionality for now (see #25).

Also, it seems this xspec file was included in the commit, I think I meant to delete the file.


Any specific reason? Its more readable, than breaking that bracket awkwardly.


Done. I waited for the doc to be built since I refer to it from the GitHub release notes.


Minor: I find it slightly odd that `application_action` is being set to `nil` in the "false" version of each of these tests. I think it would be clearer & more realistic to choose one of the other possible values in each case.


Scratch that -- the Modeshape constants are defined in a package-protected class. We can't access it from our code.


So great to see you landing tests to go along with this so we're verifying bundling works correctly.