@daniel-beck Why not just `httpRequest.getParameter(crumbFieldName)`, since the code ensures that `crumbFieldName.equals(paramName)` are equal so the `getParameter` result should be the same? That's less code, and has better worst-case performance.

[JavaDocs for getParameter](http://docs.oracle.com/javaee/6/api/javax/servlet/ServletRequest.html#getParameter(java.lang.String)) don't suggest anything else strange going on.

If there's a valid reason I'm missing, I'd suggest to explain it in a comment, lest somebody like me miss that, refactor the code like I'm proposing and introduce a bug.


keep em coming :-)


Comment


Do you have an approximate timeframe to when you might be able to patch menuhax to work with the new software update? last time took...a while, and I really appreciate the work that goes into remaking these, I just want to know so I can be prepared


My comment stands, but this code comes from earlier — the code in https://github.com/jenkinsci/jenkins/commit/ed0ea631cd4af0e678da96d7297910ba1612749d#diff-5d3fd678dc669432db5c7c444cbb25a0L68, introduced earlier in https://github.com/jenkinsci/jenkins/commit/8c4e97d1716d45130fa65a82cb8350055e9f5c98#diff-5d3fd678dc669432db5c7c444cbb25a0R74. The current commit includes however no explanation for this strange algorithm.


Why this is needed? It changes interface of 2 functions and looks like a hack.


I don't see implementation of --show option.


% An error does not become truth by the reason of multiplied propagation, nor does truth become error because nobody will see it.


It is hard to find my original comment from previous review about additional dependencies that we need to initialize. Is this change sufficient to satisfy all the dependencies?


Is it possible that there is a copy and paste error in these two software list entries?

In **kof97oro**, the size of the ROM _orochi-p21.bin_ is set at 0x100000, but the previous ROM had the same hashes, and with size of 0x200000.  Likewise for the ROM _orochi-p29.bin_.  I'm not sure if the offsets need some adjustment too.

	<software name="kof97oro" cloneof="kof97">
		<description>The King of Fighters '97 Oroshi Plus 2003 (bootleg)</description>
		<part name="cart" interface="neo_cart">
			<dataarea name="maincpu" width="16" endianness="big" size="0x500000">
				<rom loadflag="load16_word_swap" name="orochi-p1.bin" offset="0x000000" size="0x100000" crc="6dcb2946" sha1="3ccb3fdf3d32a75c7fcfefff5db1f3c75054731f" />
				<rom loadflag="load16_word_swap" name="orochi-p21.bin" offset="0x0200000" size="0x100000" crc="6e1c4d8c" sha1="f514638a599a8a582c5f4df72f6a957bab776b7e" />
				<rom loadflag="load16_word_swap" name="orochi-p29.bin" offset="0x0400000" size="0x100000" crc="4c7c0221" sha1="fdd05927743cb12210b74768155bb3f59bff01b5" />
			</dataarea>
			<dataarea name="fixed" size="0x040000">
				<rom offset="0x000000" size="0x020000" name="orochi-s1.bin" crc="4ee2149a" sha1="180a1a90021031eac1a643b769d9cdeda56518f5" />
			</dataarea>
			<dataarea name="sprites" size="0x2800000">
				<rom loadflag="load16_byte" name="orochi-c1.bin" offset="0x000000" size="0x1000000" crc="f13e841c" sha1="e24b3fb5f7e1c1f4752cad382c264f5f93e737a0" status="baddump" />
				<rom loadflag="load16_byte" name="orochi-c2.bin" offset="0x000001" size="0x1000000" crc="2db1f6d3" sha1="13d957c04bd69f0db140e4633c39db4a9e44eab8" status="baddump" />
				<rom loadflag="load16_byte" name="orochi-c51.bin" offset="0x2000000" size="0x0200000" crc="a90340cb" sha1="97eaa89f0e860e2c591ca3a995fd910d8116347d" />
				<rom loadflag="load16_byte" name="orochi-c61.bin" offset="0x2000001" size="0x0200000" crc="188e351a" sha1="ab724250bc07ace0873fc825b798ace934260988" />
				<rom loadflag="load16_byte" name="orochi-c52.bin" offset="0x2400000" size="0x0200000" crc="d4eec50a" sha1="0930cce5346fbbd5c1524f9148d0577cbe634420" />
				<rom loadflag="load16_byte" name="orochi-c62.bin" offset="0x2400001" size="0x0200000" crc="031b1ad5" sha1="d47b3452953b553348be0a55473b863ce2872f6e" />
			</dataarea>
		</part>
	</software>

In **sbp**, the size of the ROM _001-003-02a.u2_ is set at 0x020000, but the previous ROM had the same hashes, and with size of 0x080000.  Not sure if the surrounding dataarea needs adjustment.  The following dataarea also appears mismatched (0x20000 instead of 0x80000).

	<software name="sbp" supported="no">
		<description>Super Bubble Pop (MVS)</description>
		<part name="cart" interface="neo_cart">
			<dataarea name="maincpu" width="16" endianness="big" size="0x100000">
				<rom loadflag="load16_word_swap" name="001-003-02a.u2" offset="0x000000" size="0x020000" crc="d054d264" sha1="d1b4bc626d000e0679def0545940fa75035921ab" />
			</dataarea>
			<dataarea name="fixed" size="0x20000">
				<rom offset="0x000000" size="0x080000" name="001-003-02b.u2" crc="2fd04b2a" sha1="1acb446704ab56d0a33df7c48855aa8d00fd5a3c" />
			</dataarea>
			<dataarea name="audiocpu" size="0x080000">
				<rom offset="0x000000" size="0x080000" name="001-003-01b.u1" crc="7b1f86f7" sha1="15b6af7f9fbd0f1f6a1ecd912200ca8d0af2da2a" />
			</dataarea>
			<dataarea name="ymsnd" size="0x800000">
				<rom name="001-003-12a.u12" offset="0x000000" size="0x400000" crc="c96723b9" sha1="52eec88550781d45f84efbf9b905d7e7912e96fa" />
				<rom name="001-003-13a.u13" offset="0x400000" size="0x400000" crc="08c339a5" sha1="badc9510ae243ef2a7877977eb36efa81b1489fe" />
			</dataarea>
			<dataarea name="sprites" size="0x400000">
				<rom loadflag="load16_byte" name="001-003-03b.u3" offset="0x000000" size="0x200000" crc="44791317" sha1="9e773eb9aae5ee767213bd17348ff8a312e9cb16" />
				<rom loadflag="load16_byte" name="001-003-04b.u4" offset="0x000001" size="0x200000" crc="a3a1c0df" sha1="3b1e5be673f7cbb04199a805b0e0de93dad8cb8c" />
			</dataarea>
		</part>
	</software>

I could understand if these three ROMs were overdumped and the sizes made smaller, but it is unexpected that the hashes did not change as well.


Is this the file we are working on?


This look like hack too. Not clear at all. Why if for gc then don't increment.
Function interface change is better to be avoided if there is another way to do needed things.


this syclock object is not used any where please remove it.


Finishes https://github.com/Theseus-Aegis/Olympus/issues/12


Apparently. I've saved a copy of the file in case it changes again. I don't know why it keeps moving.


b


You do know PocketMine is also on PSR-2 right? All I'm trying to do is to clean up the code base and make the code more readable and neater.


> Maybe you should do some regex search in case changes like that happen in the future?


Thanks.


Reminder: this was required to compile with DragonTC/Clang 3.9


from domain import *
  from general import *

 -PROJECT_NAME = 'example'
 -HOMEPAGE = 'http://example.com/'
 +PROJECT_NAME = 'thenewboston'
 +HOMEPAGE = 'https://thenewboston.com/'
  DOMAIN_NAME = get_domain_name(HOMEPAGE)
  QUEUE_FILE = PROJECT_NAME + '/queue.txt'
  CRAWLED_FILE = PROJECT_NAME + '/crawled.txt'


Any reason you went with `REFRESH_ABILITYSHOP` and not `MAKE_ABILITY_SHOP_ICON` [like I did](https://github.com/Excrulon/Tree-of-Savior-Lua-Mods/blob/master/addons/hidemaxedattributes/hidemaxedattributes.lua)? Is it more efficient?


我做的好low啊
我不知道我提交了会发生什么...  试一下


ping?


FYI: gulp-run is blacklisted and deprecated: https://github.com/gulpjs/plugins/blob/master/src/blackList.json


我做的不好
先发出来见见光
![default](https://cloud.githubusercontent.com/assets/18617192/14934833/2c2ae7a8-0ef0-11e6-847d-99300ec4597b.png)


You can also download the finished app from Google Play (free): https://play.google.com/store/apps/details?id=appinventor.ai_notthemarsian.Arduino_car_RC_bluetooth


README wasn't updated.


I tried backporting this to the 1.7.10 version I'm using. Even in my worst-possible-case recording setup, I'm still seeing performance boosts of 60+%. Good stuff.


I think it is better to use:

`if ($fp = @fopen($classname.'.php', 'r', true)) { `

instead of "


Большое вам спасибо! Посмотрите 28.3.


its bootloop with odexed. it shows optimzing app 1 of 1 and shows starting apps then it again shows boot animation and its repeated process


Hi @rayzyar , can you please explain how this may help? We could add an option to toggle this behavior, but I want to make sure that we do not deviate from the original specification of this locking mechanism by much.


@region51 reverted.


Someone, please change my email in the header to `<gvanem@yahoo.no>`. I've not used the `broadpark` address for some years.


Fine by me, but as an idea for further directions: Should the floating layout become more intelligent and handle geometry requests itself?


first file


We probably wont need this many


Heh, looking forward to the commit that removes this code. :-)


The XML you pasted doesn't match the content of hash/neogeo.xml. I'm not sure how you obtained those lines but they are wrong.
It seems you are ignoring the parts with flag="continue" and with flag="ignore" which corresponds to the ROM_CONTINUE and ROM_IGNORE flags in the MAME source and contain vital information when computing the size of ROMs.

For _orochi-p21.bin_, the xml contains the line <rom size="0x100000" offset="0x100000" loadflag="continue" /> which tells the emulator that the second half of the ROMs must be loaded at offset 0x100000. Hence the total size is given by the first half loaded at 0x200000 and the second half loaded at offset 0x100000, for a total of 0x200000 bytes. Analogously for _orochi-p29.bin_

Concerning _001-003-02a.u2_  neogeo.xml contains the lines
`			<dataarea name="maincpu" width="16" endianness="big" size="0x100000">
				<rom loadflag="load16_word_swap" name="001-003-02a.u2" offset="0x000000" size="0x080000" crc="d054d264" sha1="d1b4bc626d000e0679def0545940fa75035921ab" />	<!-- HN27C4096HG -->
			</dataarea>
			<dataarea name="fixed" size="0x20000">
				<rom offset="0x000000" size="0x020000" name="001-003-02b.u2" crc="2fd04b2a" sha1="1acb446704ab56d0a33df7c48855aa8d00fd5a3c" />	<!-- M27C4001 -->
				<rom size="0x020000" loadflag="ignore" />
				<rom size="0x020000" loadflag="ignore" />
				<rom size="0x020000" loadflag="ignore" />
			</dataarea>`

which are not what you pasted, as you can see... the content of hash/neogeo.xml is the softlist and it is correct.


The new layout system does (at least, if it eventually replace this one)


There is tons of "if layout == floating then hack() else sane_stuff() end" everywhere. I don't like that, but adding a `c.is_technically_floating_cuz_I_said_so` property is worst. I am undecided on how to handle this cleanly (yet).


unsigned short calculations often require the compiler to insert extra bit masking operations.
eg.
`unsigned short i, j;`
...
`i + j`

Would be roughly something like: (psuedo assembly)
`
fetch i
fetch j
add
and 0xffff
`

Making these variable changes reduces the x64 output from clang for this function reduces several dozen instructions and allows it to do some nice vectorizing with the sublen update loop


Pls, add check size of accountID befor convert to numericID


unsigned short calculations often require the compiler to insert extra bit masking operations.
eg.
`unsigned short i, j;`
...
`i + j`

Would be roughly something like: (psuedo assembly)

```
fetch i
fetch j
add
and 0xffff
```

Making these variable changes reduces the x64 output from clang for this function by several hundred bytes and also allows it to do some nice vectorizing with the sublen update loop


xcvx


Not lucky FRIEND. When I turn off the screen, the mobile does not come back on. So it is unstable.

:(


`same0` hoisted from inner loops


Этот контейнер нам не нужен будет


Just a small tidy up here -- combine the limit update and the limit check code


Since I've eliminated the `hpos` varibale, update the assert


currentLength can be pushed one level down in scope


be carful to mods/hud/textures/hud_hotbar.png and selected hotbar png, this both file must be replaced by our tweaked hud_hotbar and selected_hotbar


это изображение убирай -  будем делать его через css


`pos + bestlength` can *never* be `>= size`. So remove the check.
This is because of checks at line 444 and line 507 (new code line numbering)


Hilfe von Bluefox


Use hoisted `same0` and promote variables to `unsigned int` instead of `unsigned short`


Least bitrate http format seems to be never available:
```
PS C:\dev\youtube-dl\master> py -2 -m youtube_dl http://www.pbs.org/tpt/constitution-usa-peter-sagal/watch/a-more-perfect-union/ -f http-150
[pbs] a-more-perfect-union: Downloading webpage
[pbs] a-more-perfect-union: Downloading player page
[pbs] a-more-perfect-union: Downloading video info JSON
[pbs] a-more-perfect-union: Downloading widget/partnerplayer page
[pbs] a-more-perfect-union: Downloading portalplayer page
[pbs] a-more-perfect-union: Downloading hls-2500k-16x9 video url info
[pbs] a-more-perfect-union: Downloading m3u8 information
[pbs] a-more-perfect-union: Downloading mp4-baseline-16x9 video url info
[pbs] a-more-perfect-union: Downloading hls-800k-16x9 video url info
[pbs] a-more-perfect-union: Downloading m3u8 information
ERROR: unable to download video data: HTTP Error 403: Forbidden
```
```
PS C:\dev\youtube-dl\master> py -2 -m youtube_dl http://www.pbs.org/wgbh/pages/frontline/losing-iraq/ -f http-229
[pbs] losing-iraq: Downloading webpage
[pbs] losing-iraq: Downloading video info JSON
[pbs] losing-iraq: Downloading widget/partnerplayer page
[pbs] losing-iraq: Downloading portalplayer page
[pbs] losing-iraq: Downloading hls-400-2500k-16x9 video url info
[pbs] losing-iraq: Downloading m3u8 information
[pbs] losing-iraq: Downloading mp4-baseline-16x9 video url info
[pbs] losing-iraq: Downloading hls-800k-16x9 video url info
[pbs] losing-iraq: Downloading m3u8 information
ERROR: unable to download video data: HTTP Error 403: Forbidden
```
```
PS C:\dev\youtube-dl\master> py -2 -m youtube_dl http://www.pbs.org/video/2365641075/ -f http-451
[pbs] 2365641075: Downloading video info JSON
[pbs] 2365641075: Downloading widget/partnerplayer page
[pbs] 2365641075: Downloading portalplayer page
[pbs] 2365641075: Downloading hls-400-2500k-16x9 video url info
[pbs] 2365641075: Downloading m3u8 information
[pbs] 2365641075: Downloading mp4-baseline-16x9 video url info
[pbs] 2365641075: Downloading hls-800k-16x9 video url info
[pbs] 2365641075: Downloading m3u8 information
ERROR: unable to download video data: HTTP Error 403: Forbidden
```


@WestLangley
I don't want this to sound overly opinionated. As said, feel free to revert that commit. However, I want to make sure you know what you are getting yourself into:

It's not at all intuitive to specify the *actual* (rather than the *assumed*, or maybe *intended*) semantics in terms of face culling. In fact, *the effect* is flip-siding the faces. You will still have to explain the very same thing, and throwing face culling concepts at a user who may have never heard about them before, just to say that they are used in a very special way, will probably only make it harder and is a didactically very questionable route.

`.flipSidedFaces` **is exactly equivalent** to `.cullFace === THREE.CullFaceFront`.


в этой части у нас одна большая форма, в которой три дива - стркутура должна быть примерно такой:

```html
<form>
   <div>
      <h2 class="form-title">Инфраструктура</h2>
   </div>
   <div>
       <h2 class="form-title">Тип жилья:</h2>
   </div>
   <div>
       <h2 class="form-title">Стоимость в сутки (Р):</h2>
   </div>
</form>
```


Instead of doing:
```
currentLength = 0;
if(...) {
  currentLength = ...;
}
if(currentLength > bestLength) ...
```

do:

```
if(...) {
  currentLength = ...;
  if(currentLength > bestlength) ...
}
```

This prevents unnecessary checks when currentlength is 0.


Checking `h->val2 == h->hashval2[p]` first seemed to give me better results.


Straight simplification of expression that produces *much* cleaner generated code.


fix Facebook FC. i don't use snapchat and don't know


it is juss for testing how to work on github :)


Getting started..


здесь input type search, а не ссылка


```html
<label for id="infrastucture-1-field">Бассейн</label>
```
тут надо поправить -  у input должен быть уникальный id, а его label привязывается к нему с помощью for.

Правильно будет так :
```
<label for="infrastucture-1-field">Бассейн</label>
```

надо поправить во всей форме у всех label


картинка будет фоном


Все эти блоки одинаковы, но отличаются только цветом и фоновой картинкой. Значит, нам понадобится 2 класса - общий,в котором будут все общие свойства, и дополнительный


Тут пусть будет див)


заголовок для популярных товаров и производителей - одинаковы, значит им нужен один класс


I am updating device tree. You have forked the wrong repo. This repo is for CM11 and CM12.1. For CM13 see here: https://github.com/MSM8930-Samsung/android_device_samsung_loganreltexx/tree/cm-13.0

I had uploaded but they are not available now. It worked fine for me


What is this? Did you really push without pulling first?


Yeah, that's a fair point. I suppose I was not really sure what to do in this case. I think we should leave it as is for now until, as you say, we have some assurance that we will actually notice logged errors. At least, this way if the problem is general, then we'll likely notice when using the site ourselves.

Of course notifying the other user of a won game it's probably not necessary to tell the current user about this, but if the notification was for, say, a new challenge, then it might be more worth-while telling the current user.


А тут пусть будет спан :)


Could you please organize the tree structure a bit more, would be nice if you take a few minutes for that, thanks.


Классы должны быть содержательными - показывать что, где и зачем. Такое наименование совершенно не подходит. Тем более блоки одинаковы. Можно назвать что-то вроде `.product-card`
Также здесь лишний `<br>`, лучше название модели взять в `span`, которому потом задать `text-transform: uppercase`


Это не ссылка, а обычный `div`


То же говорил раньше по общим классам - посмотри, все кнопки у нас по сути одинаковы, хотя и есть отличия. Значит, так же 2 класса


Давай обернем это изображение в свой оберточный див - это нам поможет ее позиционировать в след раз.

Только не забудь на другой странице тоже самое сделать :)


Блок services имеет цвет фона, отличный от других. Значит, его понадобится обернуть в отдельный контейнер, а в конце предыдущего блока закрыть предыдущий.


1. LIS的題目我連O(n^2)的等級都沒想出來，學習了
2. 建議mySqrt裡可以多check一下x<0的情況


Nop, it's not working somehow. michael bestas also did backport this to xperias 2011 http://review.msm7x30.org/#/q/status:open and some guys testing said it was not working there either. Perhaps it does have something to do with this commit (they also did not pick it for xperia2011 cause of the revert). I tried reverting it back again, but as I described the 'screen will freeze' at some point after boot, stuck in some libbacktrace thread function.


Great :)


Также надо обратить внимание на скрытые слои в макете. Там есть три таба в блоке "Сервисы" и есть модальное окно напишите нам, они тоже должны быть размечены.
Модалку делать после футера, перед `body`


why not fadein:200ms ? Then Louis and you are happy ;)


Same issue on my end. I tried to get in touch with @arter97 but he probably didn't have time to reply.


That's great. Thanks @MeFisto94  :+1:


@shilivenus Should use class selector. Remember this is task component, which will be repeated on page. As a consequence, `isComplete` and `isPrioritised` are not unique.


@shilivenus Use `createdAt` because the `Date` object contains time information as well. Also, this is supposed to be a todo app for today, tasks will always be created on the same date.


@shilivenus Try configure your text editor to remove trailing spaces.


```
<div class="advantages-row">
 +          <div class="advantages-item">
 +            <div class="advantages-name">Настоящий городок</div>
 +            <p class="advantages-description">Седона - не аттракцион для туристов, там течет своя жизнь</p>
 +          <img src="img/advantages-1.jpg" width="800" height="256" alt="Sedona View">
 +        </div>
 +        </div>
```
вот в это кусочке один закрывающий тег </div> перенеси перед img


@shilivenus Errr, why?


перепутала тут порядок - сначала идет блок div class="hotels-booking", а после него div class="map"

а также
Поиск гостиницы в Седоне
 - лучше сделать ссылкой)


```
+          <form class="booking-field" action="#" method="post">
 +    <!--    <input ??? >
 +            <input ??? >
 +            <input ??? >
 +            <button class="btn" type="submit">Найти</button>
 +    <-->
 +          </form>
```

можешь убрать форму - ее мы будем делать потом и она будет не тут)


div class="footer-tag" - тоже лучше ссылкой

не забудь поменять и в футере второй страницы)


when I'm only just noticing a response to this a month later _you know_ I've been neglecting to check things in recent times :p

yep, I think I added the red++ font image when I added the exp bar in late last year


> Least bitrate http format seems to be never available

- is it better to add check for format availability or just skip the worst http format.
- there is problem in the extractor here https://github.com/rg3/youtube-dl/blob/cbc032c8b70a038a69259378c92b4ba97b42d491/youtube_dl/extractor/pbs.py#L411 when the url is None.
```
python __main__.py -F http://www.pbs.org/show/pov/episodes/
[pbs] episodes: Downloading webpage
None
Traceback (most recent call last):
  File "__main__.py", line 19, in <module>
    youtube_dl.main()
  File "/home/amine/youtube-dl/youtube_dl/__init__.py", line 419, in main
    _real_main(argv)
  File "/home/amine/youtube-dl/youtube_dl/__init__.py", line 409, in _real_main
    retcode = ydl.download(all_urls)
  File "/home/amine/youtube-dl/youtube_dl/YoutubeDL.py", line 1732, in download
    url, force_generic_extractor=self.params.get('force_generic_extractor', False))
  File "/home/amine/youtube-dl/youtube_dl/YoutubeDL.py", line 673, in extract_info
    ie_result = ie.extract(url)
  File "/home/amine/youtube-dl/youtube_dl/extractor/common.py", line 341, in extract
    return self._real_extract(url)
  File "/home/amine/youtube-dl/youtube_dl/extractor/pbs.py", line 430, in _real_extract
    video_id, display_id, upload_date = self._extract_webpage(url)
  File "/home/amine/youtube-dl/youtube_dl/extractor/pbs.py", line 412, in _extract_webpage
    mobj = re.match(self._VALID_URL, url)
  File "/usr/lib/python3.5/re.py", line 163, in match
    return _compile(pattern, flags).match(string)
TypeError: expected string or bytes-like object
```
- the json api looks like it doesn't work any more.
- also from the i android api i see that it's possible to extract `srt`, `vtt`, `sami` subtitles.
for example:
the dfxp sub: `http://ga.video.cdn.pbs.org/captions/nova/9eb5fb87-7bfa-4c08-a5fc-a3737de2dc34/captions/585295_Encoded.dfxp`
extract dfxp subtitle id in this case `585295`
then add 1 to get srt sub `http://ga.video.cdn.pbs.org/captions/nova/9eb5fb87-7bfa-4c08-a5fc-a3737de2dc34/captions/585296_Encoded.srt`
add 2 to get the vtt sub `http://ga.video.cdn.pbs.org/captions/nova/9eb5fb87-7bfa-4c08-a5fc-a3737de2dc34/captions/585297_Encoded.vtt`
is it better to use this logic to extract the subtiles(without additional requests) or use the android api to extract the subtitles urls(it uses basic auth).


Why extends an interface?


Fixed in commit 728dc8d0580


`$this->minute = $minute;`


Add phpDoc comment for what it means


Add phpDoc comment


`@return string|false`


Why not use the `$redisCache` variable in this class?


The return value differs from what the comment says


@Sskaiknight Nice one! This looks great.


What if we have not got `$value`?


Should `return $this;`


Why public? Add add phpDoc comment


Was a bit confused by the message `git diff` gives for these files until I understood what's happening. It's saying they are binary files not excluded from diffs:
```
Binary files a/src/ocaml-output/FStar_TypeChecker_Tc.ml and b/src/ocaml-output/FStar_TypeChecker_Tc.ml differ
```
Excluding these generated files from diffs seems like a good idea for commit emails. Hope that it doesn't affect git's ability to efficiently store these files in the repo (and hog our repo on the long run).


Should give a parameter to use an external redis instance


1. Beware of capital of class names
2. Should check whether `$key` is a legal value


The second set of `resources` will overwrite the first (so `homepage` will be lost).


Consider that we can create an `Item` instance without `Pool` class. In that case, the `Item` instance may not have any value


My use-case here was to let more than one plugin add icons to my quick-menu (just FYI).


```php
<?php
$items[] = $item;
```


I though about it. Will talk to Louis on Monday.


Oh i didn't see that one. Thanks I'll update it.


Should use `Item::isHit()`


in PSR-2 standard, it should be
```php
<?php
foreach ($keys as $key) {
```


Add comment for these variables.


Does it work? Should test whether the item is null after 1/60 secs (use `sleep`)


This might be a dumb question because I haven't checked the data set, but are there clashes where multiple airlines have the same two-letter code? I think this isn't being used yet, so I'm trying to understand the choice of data structure without seeing code that uses it.


Good Unit Test case


Wouldn't this just break the loop, leaving all the entities in the array unchecked after the first grown tree?


Please don't change error handling style.
Don't remove ret and single return from function statement.
We'll send patches to CRIU people and patch shouldn't contain changes that doesn't bring any new value.
Stylistic changes are done in separate commits (that doesn't change logic at all). And stylistic changes should have motivation. There is no such motivation.


please change max_ prefix to gc_. Don't use temporal names when you already know how to name properly.


Fix code quanlity issues printed in https://travis-ci.org/dyweb/redis-cache/builds/126844769.


yeah, need to revert this if not we wont able to boot the device.. i believe this reclaim still need more backport commits from 3.10 kernel especially in mm.. im waiting for steve to backport this for bacon..


looks accidental


What is this


You've committed to a branch that is


Is there a way to add debian support? And especially openmediavault.
You see i have been building my own LTS kernels:
http://forums.openmediavault.org/index.php/Thread/13169-OMV-V3-Erasmus-X86-64-LTS-kernels/
And it would be wonderful if i could implement wasted cores patches in OMV kernels.


#2 Fixed


> а также div class="booking" - лучше сделать ссылкой)

я не поняла, что это значит =)


May be it would be more efficient with  `intdiv($pos,8)` or $pos>>3?


haha you did it!


great changes!


don't forget to use [this](http://tex.stackexchange.com/questions/6104/how-to-display-numbers-using-comma-as-a-thousands-separator) in order to fix SI numbers and units


Sigh... so let's exclude those packages. But it may worth rising a bugreport for lorax.


Okay I think the answer is "yes", the schema description says this for the `Active` field:

> **Active**	"Y" if the airline is or has until recently been operational, "N" if it is defunct. This field is _not_ reliable: in particular, major airlines that stopped flying long ago, but have not had their IATA code reassigned (eg. Ansett/AN), will incorrectly show as "Y".

So it seems codes can be reused and thus there might be multiple airlines in the data set with the same code. I wonder if this is true of the three-letter codes as well?

At a glance I'm seeing quite a few entries with missing two-letter codes but their three-letter codes are present… it might be better to use the three-letter codes if they are more complete.


The printing of the function prototype is useful for error messages, and could be put in astutil package as previously discussed. `f.FuncType.String()`` in it self are not usable for this as seen in the definition of the FuncDecl String() function. For now the use of function prototype in error messages for function type checking have been removed


Change to old


вся проблема була в цьому рядку?


```
<div class="booking">Поиск гостиницы в Седоне</div>
```

вот этот див надо превратить в
```
 <a  class="booking" href="#">Поиск гостиницы в Седоне</a>
```


Внутри дивов еще добавить чекбоксы в виде списка после заголовка?


Typescript non ha introdotto la keyword **import**, è lo standard ECMAScript 6 che l'ha fatto.


да конечно) я просто сокращенно написала


Don't try this. It lags your computer and you'll have to shutdown your computer to fix it.


> Least bitrate http format seems to be never available

 this should be related


Yes, exactly, got uninitialized constant for `Sidekiq::Job`. You might have `require 'sidekiq/api'` somewhere else in your setup. Thanks!


Nell'editor questa regola potrebbe portarci qualche grattacapo


Wow, I feel really stupid. The project ID appears before the token in the JavaScript file. Of course it be at a different location when the project ID is longer/shorter than what I tested with.