System-Fan-Model (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1088 of 1088 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-33.21%25-green.svg)


⚠ ⚠ ⚠

Cuidado, de acordo com a tabela do IMC sobrepeso está dentro de uma faixa, e não apenas "maior que 25"!


Yeah no worries. Also I think you're not understanding the goal of the library, it's Object Oriented wrappings of OpenGL objects, not necessarily LWJGL utilities in general... My outlook was to port all the functionality of OpenGL to OO also. You'll see what I mean in the next commit.


dá pra unificar mais ainda:

```JavaScript
var porPesoDefinido = function(e){ return (typeof e.pesoLb !== 'undefined')};
var soma = (cavaleiros || goldSaints)
    .filter(porPesoDefinido)
    .reduce(function(anterior, atual){ return anterior + atual.pesoLb}, 0);

var comPeso=(cavaleiros || goldSaints)
    .filter(porPesoDefinido)
    .reduce(function(anterior){ return anterior + 1}, 0);
```


+efedfjj


@billhoffman can you either file an issue or pull request?


I have no idea what happened to these diffs


UnitTestFixes (macumber) - Win64-Windows-7-VisualStudio-12: Tests Failed (2058 of 2406 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-85.54%25-red.svg)


Please use Java generics: ```List<Project> test = new ArrayList<>() ```
Also please use a better name than test


This is where I added the first release information.


UnitTestFixes (macumber) - i386-Windows-7-VisualStudio-12: OK (2363 of 2406 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.21%25-yellow.svg)


My pleasure.


Please get the ProjectService via injection and not instantiation. Add a field with the @Autowired annotation in the class:
```
@Autowired
private ProjectService projectService;
```


yes yes yes


add screen images


Could you please make this a loop? Like for every project in the projectlist show the tasks?


Maaaaaaaaaaaan.

Do not use automatic commits, or do not use github.


This update seems to be causing some strange syntax highlighting behavior (please see attached screenshot).
![ahk_syntax_highlighting_bug](https://cloud.githubusercontent.com/assets/15940251/15203781/d46b37dc-17bb-11e6-8dc4-f6c1de66c896.png)

In particular, it seems like indented lines that start with a non-alphanumeric character are not correctly grayed out when they are commented out (although the exact same line does get grayed out if unindented).

In addition, the syntax highlighting for active hotstrings seems to be slightly wonky as well (here, the first two colons and the hotstring itself are blue, but the latter two colons and the corresponding text expansion are white?).

I'm using the Monokai Dark theme, but have observed the same behavior with every other color theme I have tried.

Is this the intended behavior? Please advise.


Good tests.  Looks like you have a good grasp of the content here. I like that you wrote several tests to test various cases.

Only advice here: you don't need describe('Testing module lib/greet.js...) for each test you do - You can wrap all tests under a single describe block.


rSourceMap is used to strip the sourcemap embeding in composite js files, so the g flag is not needed, and the extra newline should be added to the pattern, so to remove it with the entire line.


I just tried running this against our installation, and the driver doesn't like it:
```
com.datastax.driver.core.exceptions.InvalidQueryException: Partition KEY part service_name cannot be restricted by IN relation (only the last part of the partition key can)
	at com.datastax.driver.core.exceptions.InvalidQueryException.copy(InvalidQueryException.java:50)
	at com.datastax.driver.core.DriverThrowables.propagateCause(DriverThrowables.java:37)
	at com.datastax.driver.core.AbstractSession.prepare(AbstractSession.java:110)
	at org.twitter.zipkin.storage.cassandra.Repository.<init>(Repository.java:170)
```


Sorry, those wrong style make less flexible.
Please let me know if you have other suggestion.
Thanks!


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.219.fd84c7f782e99d8cdc94c4a74b5186a0179c5c5b](http://build.palaso.org/viewLog.html?buildId=72096&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 943, ignored: 50 Build time: 00:42:41


I will contact you about this off site. Looking forward to your feedback and critique. Thanks


用assign不如用weak吧？


UnitTestFixes (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2328 of 2406 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.76%25-yellow.svg)


```
$ cqlsh
Connected to Test Cluster at 127.0.0.1:9042.
[cqlsh 5.0.1 | Cassandra 2.1.7 | CQL spec 3.2.0 | Native protocol v3]
Use HELP for help.
cqlsh> use zipkin ;
cqlsh:zipkin> select trace_id from service_name_index where service_name in ('x', 'y') and bucket in (0,1);
InvalidRequest: code=2200 [Invalid query] message="Partition KEY part service_name cannot be restricted by IN relation (only the last part of the partition key can)"
```


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.627.fd84c7f782e99d8cdc94c4a74b5186a0179c5c5b](http://build.palaso.org/viewLog.html?buildId=72088&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 931, ignored: 56 Build time: 00:22:01


This commit fixes an issue on https://github.com/hercules-390/hyperion/issues/100 where a device would work properly on initial connect, but then would fail to properly operate on any subsequent reconnects to the same device.

The issue was that the dev->console bit is set at initialization of the DEVBLK and indicates that when a device is connected then it is eligible for inclusion in the read fds_set in the main select/pselect loop. This bit was erroneously reset during disconnect meaning that when the client eventually reconnected to the same device, this file descriptor was never made eligible for the pselect read fd_set. Since it wasn't in the fd_set, disconnects were also not seen and a subsequent connect would be driven to the next eligible device.


don't know why


2245154-NewVRFHRModel (rongpengzhang) - Win64-Windows-7-VisualStudio-12: OK (2191 of 2196 tests passed, 551 test warnings)

 * 556 tests had: AUD diffs.
 * 215 tests had: EIO diffs.
 * 5 tests had: Table big diffs.
 * 2 tests had: ESO big diffs.
 * 2 tests had: MTR big diffs.
 * 2 tests had: ESO small diffs.
 * 2 tests had: MTR small diffs.
 * 2 tests had: ERR diffs.
 * 1 test had: MTD diffs.
 * 1 test had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.77%25-yellow.svg)


Good - Easy to understand, simple code.


UnitTestFixes (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Downloads and prepares the dev bundle


addr for pca9542?


@hillsp The commit message is wrong, should be `1.11.33.1 -> 1.11.33.2` instead, but the code is fine.


идэвхитэй юм хий л дээ андаа


in retrospect, seems my linter is retarded and the main tag is a real thing


did you mean for RMSProp to also have 1e-8 as well?  If so, you missed updating that one.


The Firefox extension was rejected because it contains a big blob of compiled code (vim.js), so the URL is invalid.

One can still get it from https://github.com/emnh/vim.js-plugin .


Faster FPS.
Thank you ;)


If there is anything you'd like to add, it would probably be nice adding it to `contributing.md`.


commit by Stella


This does not compile with Puppet 3.8.x. Can you do this with create_resources instead?


g++ -I$JAVA_INCLUDE -I$JAVA_INCLUDE/linux -I../node -I../node/deps/v8 -I../node/deps/v8/include -I../node/src com_eclipsesource_v8_V8Impl.cpp -std=c++11 -fPIC -shared -o libj2v8_linux_x86_64.so -Wl,--whole-archive ../node/out/Release/libnode.a -Wl,--no-whole-archive -Wl,--start-group ../node/out/Release/libv8_libbase.a ../node/out/Release/libv8_libplatform.a ../node/out/Release/libv8_base.a ../node/out/Release/libv8_nosnapshot.a ../node/out/Release/libuv.a ../node/out/Release/libopenssl.a ../node/out/Release/libhttp_parser.a ../node/out/Release/libgtest.a ../node/out/Release/libzlib.a ../node/out/Release/libcares.a -Wl,--end-group -lrt -D NODE_COMPATIBLE=1


Drag and drop node works fine.

** But I the filesystem view still broken** on my taptop(Arch Linux ).
I can't active any resource item in the filesystem view after this commit f909634832a72cfc669fd1b6281c8a960ea3d40f .

@reduz
Could you please take a look at #4556 and #4568 ?


It just broke validation tests.  Hey John, have I ever complained about validation tests checking diagnostics? :-)


This commit causes build bustage on Linux:

https://gist.github.com/trav90/20e15131f3a71b51f58a59bd8bf8a2b8


TeamCity ReOpenLDAP :: devel [Build 259](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=2151&buildTypeId=ReOpenLDAP_Devel&guest=1) outcome was **FAILURE**
Summary: Tests passed Build time: 01:02:31
### Failed tests
```
all LDAP tests for mdb/DQD-KFA: test020-proxycache for mdb/DQD-KFA: <no details avaliable>

all LDAP tests for mdb/KFA: test030-relay for mdb/KFA: <no details avaliable>

all LDAP tests for mdb/DQD: test030-relay for mdb/DQD: <no details avaliable>

all LDAP tests for mdb/free: test050-syncrepl-multimaster for mdb/free: <no details avaliable>

```


ghfh


*wizard


Dave...
Yes. I would still probably replace this with the commit from master I mentioned earlier to be completely consistent with the previous releases. Bigger changes we better leave for O5.

Pavel


Best working firmware I've found for the mega 2560 ramps 1.4 combo.  Works great!


Should be fixed with 150453bff3ceafe7ff4c40742f0348a2a8d272f0


I have created a new pull request https://github.com/linux-sunxi/sunxi-tools/pull/43 with a reworked location for the FEL stacks backup storage.


OOPS


You don't need install elpa-mirror if you use it in a bash. It could be regarded as single script (like python script).


we aren't testing against cassandra 2.1, and haven't been since last year.

The scala project can be ported to temporarily support cassandra 2.1,
although GET /api/v1/traces without parameters won't work.


I dont have broke it, all work for me, for my repository i have already don that and i don't have broken anything


ok


WorkflowCli (macumber) - i386-Windows-7-VisualStudio-12: OK (2065 of 2204 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-93.69%25-yellow.svg)


CBECC-8-5 (macumber) - x86_64-MacOS-10.10-clang: OK (2367 of 2407 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.34%25-yellow.svg)


develop (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2345 of 2406 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.46%25-yellow.svg)


Removed *.meta from Visual Studio Section.


Ok. My intent was to genericize the script in that the script assumes that elpa-mirror.el is in the ~/projs directory and that the ~/myelpa directory already exists.


PS here's the note about cassandra 2.2 in general

https://groups.google.com/forum/#!topic/zipkin-user/s6NZctGdNJM


2245154-NewVRFHRModel (rongpengzhang) - i386-Windows-7-VisualStudio-12: OK (2191 of 2196 tests passed, 551 test warnings)

 * 556 tests had: AUD diffs.
 * 215 tests had: EIO diffs.
 * 5 tests had: Table big diffs.
 * 2 tests had: ESO big diffs.
 * 2 tests had: MTR big diffs.
 * 2 tests had: ESO small diffs.
 * 2 tests had: MTR small diffs.
 * 2 tests had: ERR diffs.
 * 1 test had: MTD diffs.
 * 1 test had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.77%25-yellow.svg)


m thử dịch cả câu ra xem thử =))


I was trying to keep it consistent with my other `require`s, since I usually use '.js'. But it's not really that important.


Right, and we could maybe use the babel build step like we had before to keep <=0.12 support.


added Domain Name


develop (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


embedded_ruby_cli_rubyinstaller (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


s


:up:
все ок)


embedded_ruby_cli_rubyinstaller (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Ping.


Hi @swiftix, Can this use TypeConverter::areTypesABICompatible()?


Configuration class should be separate from actual impl.


That's really great to hear, thanks!

As a side note, I should be getting this up and running within 7 days, waiting for the ability to grab an oscilloscope to double check what the heck I'm reading with a few different methods.

On another note, let me know if you're using the Arduino Uno instead, I may soon switch to it for the better documentation and simpler processor (no flash wait states, yay) as well as Uno console-side GC code already available, but not sure if worth it just yet.


It should rather be a list of users not a single user.


We strive for constructor-based injection. See comment on Adam's version.


The following doc(s) have been deployed to the [albertcausi](https://albertcausi-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/domains](https://albertcausi-static-docs.pantheonsite.io/docs/domains)


Under what circumstances it might be `null`?


You should loop through the arguments and optimize them all


Under what circumstances it might be null?


I'm using a modified version of Android X86's 4.4.8 kernel (patched to 4.4.9 then 4.4.10 with kernel.org patches). I'm not sure where they got their original code from, possibly Google?

To note, nothing I modified has anything to do with wifi, besides updating this driver.


Derp.. this doesn't exist prior to 7.. might be easiest to remove altogether


cool!


See comment on Adam's version on `@PostConstruct`.


$attachment->post_title should be escaped. e.g. attachment title containing quotation marks will ruin HTML of the form.


One dot per line - see comment on Adam's version.


Impl missing basic logging.


TEST


WorkflowCli (macumber) - Win64-Windows-7-VisualStudio-12: OK (2064 of 2204 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-93.65%25-yellow.svg)


Just because UI designer not working with Kotlin yet.


Ожидается комментарии, что делает эта строчка


Where do you get those from (like `AUTH_TOKEN`, `SALES_EMAIL`, `DEVICE_UUID`)?


комментарии за что отвечает каждая переменная или говорящее имя переменной


Well done then :D Last night I've downloaded sources so I hope that there will be some builds till end of week. There is still work to be done to kernel...


the code is not online yet


ok


dsddasdasd


Govenors doesn't make "any" difference in our kernel (at least for power consumption reduction) unless you reduce cpu_max speed so it doesnt make throttle. Gotta find the reasons for it later


@aleph7 do we need FF for alpha? or can we go with this?...
the mask might be redundant now.


Did you try building on Mac A and using the binary on Mac B?

What is your impression, shall we go public with the binary? Or shall we wait until we have fixed the relocation issue?


so here, we rebuild the tables at each restart, if I understand well, since most of the time when you stop lisk mem_round will not be empty.


Shouldn't this be `getOpenFileName` or am I missing something?


This is CPU hotplug not governor. Also hotplugs manage most of CPU activities so yeah you won't notice governor changes until you turn off hotplugs.


I am not agree with this, it's very important to keep a refine mesh in the recirculation zone.
I have no problem to generate the mesh, you must check your gmsh install.
Can you revert please.


I'm trying to port latest CAF kernel with Faheem Kamal. Maybe we can work together? Ping me on Hangouts.


woke


When assembling get an error:

packages/apps/Bluetooth/src/com/android/bluetooth/avrcp/Avrcp.java:659: error: cannot find symbol
            RemoteController.OnClientAvrcpUpdateListener {
                            ^
  symbol:   class OnClientAvrcpUpdateListener
  location: class RemoteController
packages/apps/Bluetooth/src/com/android/bluetooth/avrcp/Avrcp.java:379: error: no suitable constructor found for RemoteController(Context,RemoteControllerWeak,<null>,AvrcpRemoteControllerWeak)
        mRemoteController = new RemoteController(mContext, mRemoteControllerCb,
                            ^
    constructor RemoteController.RemoteController(Context,OnClientUpdateListener,Looper) is not applicable
      (actual and formal argument lists differ in length)
    constructor RemoteController.RemoteController(Context,OnClientUpdateListener) is not applicable
      (actual and formal argument lists differ in length)
packages/apps/Bluetooth/src/com/android/bluetooth/avrcp/Avrcp.java:604: error: RemoteControllerWeak is not abstract and does not override abstract method onClientPlayItemResponse(boolean) in OnClientUpdateListener
    private static class RemoteControllerWeak implements RemoteController.OnClientUpdateListener {
                   ^
packages/apps/Bluetooth/src/com/android/bluetooth/avrcp/Avrcp.java:666: error: method does not override or implement a method from a supertype
        @Override
        ^
packages/apps/Bluetooth/src/com/android/bluetooth/avrcp/Avrcp.java:702: error: method does not override or implement a method from a supertype
        @Override
        ^
packages/apps/Bluetooth/src/com/android/bluetooth/avrcp/Avrcp.java:712: error: method does not override or implement a method from a supertype
        @Override
        ^
packages/apps/Bluetooth/src/com/android/bluetooth/avrcp/Avrcp.java:721: error: method does not override or implement a method from a supertype
        @Override
        ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
7 errors


System-Fan-Model (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1643 of 1646 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.67%25-green.svg)


This title should also be escaped. esc_html perhaps?


System-Fan-Model (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


My edit to this file from branch readme_edits


Commented Out!!
Found no use of this function elasewhere.


👍 Thanks for making the example bash script clearer.


Hi @serjant would you like to add some tests for scala? I really want to pull your code:-)


The resolve function with this signature requires ^1.2


Maybe it is like Buildings. I don't know. I moved the Cameras folder to my core folder and it worked for me.


A lot of work, but should worth it.


Thanks @cowbjt

With two person is now working fine
I understood why annotation was working on origin with one person and not here, that's because this line was code added:
https://github.com/cowbjt/openface/commit/b11b90f2604f3c525cb6707f0a6437bf53ffe688#diff-5c9d6ce4c118410cd01c15cbc9a00d92R101


this rolled back updated list but i can fix this later today


2016.05.12 Lec


I would suggest to mark this as `[BREAKING]` as it changes the default behavior


iteration (DavidGoldwasser) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2346 of 2406 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.51%25-yellow.svg)


Hey I commented on a commit from earlier, I said no more commits before I push my changes. I can't commit now my commit will conflict with yours. I'm going to try to merge the changes with this commit but it'll take some time.


2245154-NewVRFHRModel (rongpengzhang) - x86_64-MacOS-10.9-clang: OK (2185 of 2190 tests passed, 548 test warnings)

 * 553 tests had: AUD diffs.
 * 215 tests had: EIO diffs.
 * 5 tests had: Table big diffs.
 * 2 tests had: ESO big diffs.
 * 2 tests had: MTR big diffs.
 * 2 tests had: ESO small diffs.
 * 1 test had: MTR small diffs.
 * 2 tests had: ERR diffs.
 * 1 test had: MTD diffs.
 * 1 test had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.77%25-yellow.svg)


iteration (DavidGoldwasser) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Git learning


I believe the timestamp should be U32, not U16.


The new byte in 10.92 is "service type" but for now both the standalone and flash clients seem to default to "service type unknown".


这个问题什么时候修复一下,现在一直有呢
我是想修复但是看不太懂你的做法是怎样的


WorkflowJSON_Model (macumber) - i386-Windows-7-VisualStudio-12: OK (2066 of 2204 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-93.74%25-yellow.svg)


os_2_0_develop_big_merge (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Changes in month names in Hindi locale.


Is this happening right at the beginning? Could you send me your ROM infos?

There is probably an assertion failure somewhere please use the following macro in new_dynarec_64.c:
```
#undef assert
#define assert(A)                                                                             \
  do{                                                                                \
    if((A)==0){                                                                               \
      DebugMessage(M64MSG_INFO,"Assertion failure at line %d, in file %s",__LINE__,__FILE__); \
      exit(1);                                                                                \
    }                                                                                \
  }                                                                                \
  while(0)
```

If you still have no luck with this please define the NEW_DYNAREC_DEBUG preprocessor and send me the generated log new_dynarec_debug.txt, maybe you'll have to change the path in fopen.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1658 of 1658 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@adamjimenez Yes. But 0 should not even be passed to the function.
@deitch No, with #159 everything is fine.
I see no need to continue this discussion.


os_2_0_develop_big_merge (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


神速


org.beetl版本的groupTemplate.setClassLoader 方法不是public的，要用最新的com.beetl版本的http://mvnrepository.com/artifact/com.ibeetl/beetl，此版本是public的，这个问题我是跟作者确认的。

插件是基于servlet 3.1开发的，有空试试2.5的


develop (macumber) - x86_64-MacOS-10.10-clang: OK (2374 of 2418 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.18%25-yellow.svg)


static-os-libs-OBJECT-lib (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


So just a recap from this commit:
GLContext - Deleted - LWJGL has GL.class for that.
Window - Deleted - It doesn't wrap the GLFW window how I wanted it too, although it was written well
GLFWContext - Deleted - It seems simpler to keep all the static GLFW calls in one class like GLFWWindows
Texture - Deleted - Doesn't wrap the texture object how I wanted it to, it should just be an interface
Framebuffer - Deleted - Needs a less proprietary system, width/height requirement breaks 3D framebuffers and your class can support more than two attachments, but it's required to have them for some reason? This can be fixed with the interface system I was talking about
Shader - Deleted - Shaders are the sources themselves, ShaderPrograms are the thing their attached to. Having functions for loading shaders that are decoupled from the shader-program is essential! I didn't expect you to know this, it's pretty controversial on LWJGL.org and OpenGL.org. I'll make up a system for shader/program decouplement some day.

What I added:
GLFWVersion - Represents 3 version attributes that come from the GLFW API
GLFWWindow - The window object (functional interface with one long value for the window)
GLFWWindowContainer - GLFW window specific API calls wrapped in a class that ports the calls to the window interface. Also allows easier manipulation of the window and safety using the GLNativeException checks.
GLFWWindows - Factory methods for creating GLFWWindows, also packages all the static methods of GLFW involving context and state.


![tblinfo](https://cloud.githubusercontent.com/assets/9150735/15205742/f19553a8-1854-11e6-92e3-5e6e4bc77e79.png)

Added the Table Summary tab for Altibase. However, Altibase does not support the Column Summary.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


This list should match https://github.com/Microsoft/vscode/blob/master/src/vs/languages/markdown/common/markdown.contribution.ts#L14


Thanks for addressing my remarks. Would you mind to replace the deprecated `Signal_rpc_member` by `Signal_handler` from *base/signal.h*?


static-os-libs-OBJECT-lib (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Its a pity that the history of Makefile is gone.
Still need to resolve what targets (in Makefile) are required for the minimal build.


still not able to fix by changing it.


change color.


dfasfdafadfasdf


static-os-libs-extern-template (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463034495578
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


#amenakoi


@goodmami: Are you interested in merging this change?


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463034562416
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


We usually put exception classes in a seperate `exceptions.py` for each app.  See the `accounts` app for an example.


 +obj-${CONFIG_ROOT_DEVICE} += sunxi-debug.o

Wrong kind of parens.


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463034576844
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463034605314
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


Was x%2==0 when you did it?


ICQ isn't always supported either, SNB et al only support CQP


Fine. Thanks. Discussion (here) done.


I prefer to say `if len(result) != 0` for things like this.  I think it's better to be explicit about exactly what you're testing.


static-os-libs-extern-template (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Why are they public?


ICQ isn't used on SNB.  Note that it says "if (icq)" there, and below it says CQP.


Because everything [isn't fine](https://github.com/deitch/jstree-grid/pull/159#issuecomment-218610298)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463034840636
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


To make sure I understand correctly: this moves the deploy step into the Travis build kicked off by the tag created by `release:prepare`, right? So now the flow is something like `human pushes tag release-1.0.0` -> `Travis does release:prepare` -> `creates tag 1.0.0` -> `Travis does deploy`?


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463034881708
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


static-os-libs-model-refactor (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


@vincentchabannes , @lsala is currently getting acquainted with feel++. We will look into that. thanks for the feedback


Try to avid using hr


The black box is the content of the red box


Try to solve it without using position, except the case of the black box


Same thing as the last commit


Sorry I didn't really explain this properly.

The actual issue is that the [tutorial page](https://googlechrome.github.io/sw-toolbox/docs/master/tutorial-usage) contains some invalid JS:

````
toolbox.router.post(/^https://api.example.com\//, apiHandler);
````

[Speculation re the cause: since it looks like the [original source](https://raw.githubusercontent.com/GoogleChrome/sw-toolbox/master/doc-pages/usage.md) is correct (the forward slashes are quoted with backslashes) something has possibly gone wrong during HTML generation.]


It could be a header


I know that it's not the dame as, I was just trying to understand how feel++ works and in this case it's just not working with the previous mesh, I male a little modification just to make it work, but I don't know the real application and aim of that part


It could be an aside


It could be a main


it could be an aside


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463035164607
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


It could be a footer


This is a little bit funny.  I think you should just be saying `objects = SpatialUnitRelationshipManager()`, instead of having an `objects` which is a normal `models.Manager` and an extra `integrity_check` manager.  The point of doing the integrity checking is to make it impossible to create spatial unit relationships that don't conform to the conditions we're imposing.  Normally when you create Django model instances, you'll do something like `Model.objects.create(blah)`, so you want the `objects` class attribute to refer to the manager that you gives you the default behaviour you want for your model.  You *will* see examples where people have an `objects` that's a normal `models.Manager` and some other managers assigned to class attributes of a different name, but they're most often used for cases where you want to have custom queries.  In the case here, we want custom validation on the creation of all `SpatialUnitRelationship` model instances, so we want to *override* the default `objects` manager.  Hope that makes sense...


Modified:  branches/dominic-branch/src/api/index.php
Modified:  branches/dominic-branch/src/api/services/directoryServices.php
Modified:  branches/dominic-branch/src/api/services/myCompanyProfileServices.php
Modified:  branches/dominic-branch/src/api/services/userIDBasedServices.php
Modified:  branches/dominic-branch/src/app/app.js
Modified:  branches/dominic-branch/src/app/components/directory/directoryController.js
Modified:  branches/dominic-branch/src/app/components/directory/directoryView.html
Modified:  branches/dominic-branch/src/app/components/events/eventsPageController.js
Modified:  branches/dominic-branch/src/app/components/events/eventsPageView.html
Modified:  branches/dominic-branch/src/app/components/home/homeController.js
Modified:  branches/dominic-branch/src/app/components/home/homeView.html
Modified:  branches/dominic-branch/src/app/components/profile/companyProfileController.js
Modified:  branches/dominic-branch/src/app/components/profile/companyProfileView.html
Modified:  branches/dominic-branch/src/app/components/profile/memberProfileController.js
Modified:  branches/dominic-branch/src/app/components/profile/memberProfileView.html
Modified:  branches/dominic-branch/src/assets/sass/partials/_home.scss
Modified:  branches/dominic-branch/src/assets/stylesheets/styles.css


this change is wrong - its float*


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463035263549
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


@terminalmage I did. Thanks for giving me a job. Besides, we already had this discussion before. :wink:


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463035285224
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463035328802
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


indentation


static-os-libs-model-refactor (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


This particular change has nothing to do with your PR. It would be _very helpful_ to do one step per a time: each PR per an issue. Thanks!


Done in 76b7810feeb40b74effbc80466a13dd53861b23e


Same height as turquoise-box you could use combined selector. (same thing with the sidebars)


要不然改成这样吧:
```
view = AddView(self.model, url_for(RoleView.list), default_data=default_data, fields=fields)
```
添加完回到列表


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463035419788
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


Hm, no. Dmitri reported this also yesterday and it appears to fail some of the time but only on the simulator platforms, and only on these machines. I'll get in touch with Mishal tomorrow to see if we can get it to reproduce via repetition on one of the bots. I haven't been able to reproduce this yet.


Try to avoid using hr-s


Unnecessary new line


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463035473644
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


Could be a header


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463035498696
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


Don't use hr for this


Ah, but it is now! :-)

OK, it is now, so I am merging #159 in.

Then, let's open a separate issue about deprecating `value` as a function. We know the use case where it is useful to have *both* `value` function *and* `method` function, but is there a cleaner way, as @adamjimenez suggest? Issue opening soon.


Could be a footer


static-os-libs (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


The label here is the no and ferfi


This can be private too, or?


Same thing as with the radio buttons


Also multiple elements has the same id


It would be nice to use the whole name as property name.


UInt64 would cause crash if the date is earlier than 1/11970, e.g:

`let date = NSDate(timeIntervalSince1970: -10)`
`let x = UInt64(date.timeIntervalSince1970 * 1000)`

Use Int64 would not have this problem.


LGTM


Yep.

Con is that it takes another several minutes (because we unconditionally
download and start servers, run tests etc on all triggers).

Pro is that the side effects on transient error are easier to deal with.
Bintray flakes occasionally and I the deploy-only job should be easier to
retry than a compound job.


Why don't we allow the configuration of this separator somehow?


既存箇所なので申し訳ないのですが、
`NXActionUnknown.parse()` って、エラーしますか？
`subtype` を設定していないので、`NXActionUnknown` をインスタンス化できず、
エラーするように読めます。


TEST


can you tell us your ozw lib version. Last week, I validate a Polycom Danalock with version 1.4167 and got this issue. After I update the lib with the patch, no more error. So be sure you use the latest version of ozw to avoid this issue.

ozwcp is the application open-zwave-control-panel, you have start your gdb session in the open-zwave-control-panel path.


A ni to angleska razlicica? Zakaj je v slovenscini??


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463035797455
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


I actually still prefer the `emptyString`, `emptyArray`, `emptyObject` names, along with `constTrue`, `constFalse` (that we could eventually shorten to `True` and `False`), even though you lose a bit of consistency.

They are more explicit in what they do, and they will not confuse the users by thinking that Lodash has acquired mocking methods like [sinon](http://sinonjs.org/) for testing purposes.

That said, `stubXyz` is probably a better name than `mockXyz`, as it's more about injecting stub content than mocking a function.

> should we create a new mock/stub category? I could see noop and identity as part of it.

Nah, for the same reason as I said above, Lodash is not a mocking library, and we should not confuse the users. Also, these functions have legitimate uses other than mocking/stubbing, especially with FP and methods like `_.cond`.

Also, I think that `stub` and `mock` are less often in the vocabulary of non-native english speakers than `empty` and `constant` (but that's a detail).


static-os-libs (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Yes it should. I guess I didn't do a thorough enough code review.


ok


I face the following issue when vcf2adam is executed on a gz file.
16/05/12 09:51:38 INFO BlockManagerInfo: Added broadcast_1_piece0 in memory on scflexnode09:35192 (size: 30.9 KB, free: 530.2 MB)
16/05/12 09:51:38 WARN TaskSetManager: Lost task 0.0 in stage 0.0 (TID 0, scflexnode09): java.io.IOException: org.apache.spark.SparkException: Failed to register classes with Kryo
	at org.apache.spark.util.Utils$.tryOrIOException(Utils.scala:1177)
	at org.apache.spark.broadcast.TorrentBroadcast.readBroadcastBlock(TorrentBroadcast.scala:165)
	at org.apache.spark.broadcast.TorrentBroadcast._value$lzycompute(TorrentBroadcast.scala:64)
	at org.apache.spark.broadcast.TorrentBroadcast._value(TorrentBroadcast.scala:64)
	at org.apache.spark.broadcast.TorrentBroadcast.getValue(TorrentBroadcast.scala:88)
	at org.apache.spark.broadcast.Broadcast.value(Broadcast.scala:70)
	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:62)
	at org.apache.spark.scheduler.Task.run(Task.scala:88)
	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:214)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.spark.SparkException: Failed to register classes with Kryo
	at org.apache.spark.serializer.KryoSerializer.newKryo(KryoSerializer.scala:124)
	at org.apache.spark.serializer.KryoSerializerInstance.borrowKryo(KryoSerializer.scala:237)
	at org.apache.spark.serializer.KryoSerializerInstance.<init>(KryoSerializer.scala:222)
	at org.apache.spark.serializer.KryoSerializer.newInstance(KryoSerializer.scala:138)
	at org.apache.spark.broadcast.TorrentBroadcast$.unBlockifyObject(TorrentBroadcast.scala:215)
	at org.apache.spark.broadcast.TorrentBroadcast$$anonfun$readBroadcastBlock$1.apply(TorrentBroadcast.scala:178)
	at org.apache.spark.util.Utils$.tryOrIOException(Utils.scala:1174)
	... 11 more
Caused by: java.lang.IllegalArgumentException: Unable to create serializer "com.esotericsoftware.kryo.serializers.FieldSerializer" for class: org.bdgenomics.adam.models.SAMFileHeaderWritable
	at com.esotericsoftware.kryo.Kryo.newSerializer(Kryo.java:335)
	at com.esotericsoftware.kryo.Kryo.newDefaultSerializer(Kryo.java:314)
	at com.twitter.chill.KryoBase.newDefaultSerializer(KryoBase.scala:48)
	at com.esotericsoftware.kryo.Kryo.getDefaultSerializer(Kryo.java:307)
	at com.esotericsoftware.kryo.Kryo.register(Kryo.java:351)
	at org.bdgenomics.adam.serialization.ADAMKryoRegistrator.registerClasses(ADAMKryoRegistrator.scala:156)
	at org.apache.spark.serializer.KryoSerializer$$anonfun$newKryo$4.apply(KryoSerializer.scala:120)
	at org.apache.spark.serializer.KryoSerializer$$anonfun$newKryo$4.apply(KryoSerializer.scala:120)
	at scala.Option.foreach(Option.scala:236)
	at org.apache.spark.serializer.KryoSerializer.newKryo(KryoSerializer.scala:120)
	... 17 more
Caused by: java.lang.reflect.InvocationTargetException
	at sun.reflect.GeneratedConstructorAccessor10.newInstance(Unknown Source)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
	at com.esotericsoftware.kryo.Kryo.newSerializer(Kryo.java:322)
	... 26 more
Caused by: java.lang.UnsupportedClassVersionError: htsjdk/samtools/SAMFileHeader : Unsupported major.minor version 52.0
	at java.lang.ClassLoader.defineClass1(Native Method)
	at java.lang.ClassLoader.defineClass(ClassLoader.java:800)
	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
	at java.net.URLClassLoader.defineClass(URLClassLoader.java:449)
	at java.net.URLClassLoader.access$100(URLClassLoader.java:71)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
	at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
	at java.lang.Class.getDeclaredFields0(Native Method)
	at java.lang.Class.privateGetDeclaredFields(Class.java:2436)
	at java.lang.Class.getDeclaredFields(Class.java:1806)
	at com.esotericsoftware.kryo.serializers.FieldSerializer.rebuildCachedFields(FieldSerializer.java:66)
	at com.esotericsoftware.kryo.serializers.FieldSerializer.<init>(FieldSerializer.java:50)
	... 30 more


nnecessary empy lines


missing doctype


indentation


That's the point, why not add a separate fallback from LA_ICQ to ICQ in case LA_ICQ isn't supported instead of not using LA_ICQ at all?


could be an aside


<pre>
# fixup
return bytearray() if self.data is None else self.data
</pre>
としても、同じ結果だったりしませんか？


Actually Brad, you didn't need to break savegame compatibility as the extra data that gets copied into the mobj for the music id is already copied into the spawnpoint structure and can be read from there when needed (i.e. spawnpoint.type - 14100)
And while I'm here the wiki states that music changer id 0 resets the music to the default for the level. That functionality appears to be missing from the code. I originally copied it from prboom+ (I think!) for my port, but when I realised that it was rather poorly coded I started over.


WorkflowJSON_Model (macumber) - Win64-Windows-7-VisualStudio-12: OK (2052 of 2204 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-93.1%25-yellow.svg)


you forgot one. 7thelementfadeout :^)


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1084 of 1084 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-33.2%25-green.svg)


@gojohnnygo because after having installed it in my application, and when using it, the file that is used is the one in the `lib`folder:
![image](https://cloud.githubusercontent.com/assets/12717418/15206467/aedd92d0-181f-11e6-92b3-a255914dbdb5.png)


Thanks Jeff. I was actually looking at your implementation last night (so I can get the wolves howling in aaliens_rc1.wad as well), but need more time.


Which warning do you get?
You shouldn't need -dev packages unless you are compiling anything, and you should not be compiling inside the container. The .deb package for example depends on librrd4, not librrd-dev.


Oh right, TBH i'm not fully happy with my implementation either!


We can't just allow any separator here. It must be either `,` or `;` (reserved sub-delimiters according to RFC3986).


what will always be greater than zero? (I guess you meant to say "the length of the returned string will always be greater than zero")


lua strings aren't null terminated... the rest of this bit doesn't make sense for the lua interface.


我觉得先实现主要的，让整个东西能跑起来。美术这块能往里添加东西。


`buf` と `offset` は使ってない変数のようです。
どこか特定の `NXAction*` で必要であれば、残しておく必要がありますが、
必要になる可能性は低いように思えますので、
削除でも良いかな、と思います。


@saure now you can update patch ;) there is fix
https://github.com/plbossart/sound/commit/43662320b77004e55eb92c13f133b58e18c3cc33


Good. But the query format should be made (more) compatible, though. :smiley:


pulsesim tutorial


@SkepticalHippo O tai nesukels null pointer exception? Jeigu useris ne authenticated?


The difference between delete and splice method is:
delete will leave the array size unaffected even after deleting the element.
Splice will remove the element and will update its size.


I believe we shouldn't include dependencies in our project, isn't there a way to configure it in the Maven project management tool.


How much it takes time completion of the project ?!


Thank you! Updated to the latest version and the lock works again. So...., I'm now back to the original problem where I can't set user PINs. I have tried ASCII and Dec sequences as Fishwaldo asked here: https://groups.google.com/forum/m/#!topic/openzwave/QhMuuIRgUU4

The lock is fairly useless without this functionality as the PINs must be set via the controller.

Does the Danalock support user configurable PIN's to be set via OZW console?


@axel22 should have asked earlier. For future PRs, do you guys have a custom code style for Scala or just the default Intellij one would do?


Score of  fm_capture_aware vs base: 507 - 484 - 1183  [0.505] 2174   tc=3+0.03
ELO difference: 4


should we add `dest.newPrintWriter()` to forbidden APIs? I think it should even be forbidden upstream?


The null terminator shouldn't make it into lua. This piece from the postgres docs only applies to the C interface.
You can take off the bit about textual copy.


@benmarwick as I mention [here](https://github.com/ropenscilabs/eechidna/issues/3#issuecomment-218013305), there is good justification for using lines over jittered points. If you still disagree, I'll have to convince you during your visit next week 😸


Yra route dar vienas middleware, kuris tikrina tik auth. Stengiausi
atskirti middleware visus, kad atliktu po viena funkcija.
On 12 May 2016 08:08, "Bebras" <notifications@github.com> wrote:

> @SkepticalHippo <https://github.com/SkepticalHippo> O tai nesukels null
> pointer exception? Jeigu useris ne authenticated?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> <https://github.com/SkepticalHippo/maze/commit/8893e13e2ba1cf37cea697bc3db9a3d62012b589#commitcomment-17445546>
>


**Code Quality**

The src folder shouldn't be inside the jasmine folder.


**Nitpick**

`replace` and `split` can be chained to make the code more succint.


> Am 12.05.2016 um 09:14 schrieb daurnimator <notifications@github.com>:
>
> The null terminator shouldn't make it into lua. This piece from the postgres docs only applies to the C interface.
> You can take off the bit about textual copy.
>
>

I wonder if the len includes the NUL byte or not, I need to check that. (so a len of 1 would actually mean an empty string).


Just comment


Why is this marked as shipped? Web Notifications are only available to Insiders.


R code for the Box Plot Application


This is code in buildSrc, which is not checked by forbiddenApis at the moment. I'll have to investigate how much effort it is to enable forbiddenApis there.


update readme


**Test Coverage**

Should more test cases to handle negative test cases such as when searching a term that wasn't in the books.


This is my first repository at github.


@mkorkmaz there ara some other methods which has `$returnType` parameters. What do you think about?

`runRoute`, `notFound`


This is my second comment in my repository


**Test Coverage**

This expectation is always met even when the index is not created because even an empty `Map` object is not falsy.


hmm ok. `notFound` method can use only in class, but `runRoute` method can use from external.


Should I create JIRA or will you handle it ?


поля лучше делать private, т.к. они должны быть видимы только в пределах данного класса


昨天和老师沟通了好一阵子，感觉这帮孩子的问题都已经出显了


use parameters instead of literal values :)


**Code Styling**

Andela's JS code style guide recommends ES6 classes over prototypes.


@cbeck I am sorting through all the code the `rails g scaffold Wiki title:string body:text private:boolean user:references:index` command generated. I am wondering if this notice thing could be moved into some sort of notifications dropdown or something.


@slavapestov I cannot find `TypeConverter::areTypesABICompatible()` anywhere. But I can guess what it does. Most likely, we cannot use it here, because castValueToABICompatibleType not only checks for compatibility, but also generates a code to perform the required casts. This is more involved than just doing a check.


这部历史书分为艺术、地理、历史三个部分。


**Code Styling**

The code style guide recommends the `forEach` function over for loops.


Sadece register'da default value'ya ihtiyacım var, diğerlerinde burada set edilen değeri kullanıyor.


можно сохранить результат выполнения FileSearch(i) в переменной, тогда не надо будет вызывать этот метод 3 раза, что улучшит производительность.


最後の「PHP そのものをセットアップするよりは便利でしょう」は誤訳ですね。
あなたのPHPがそれらを提供しない場合は便利でしょう、という意味だと思います。


Этот метод нигде не используется. Всегда удаляй неиспользуемый код.


**Coding Style**

`let` and `const` are preferred over `var` for declaring variables.


OK


I think you're missing `stmt.Exec(params)`
for queries `stmt.Query(params)`

see: https://github.com/go-cq/cq#minimum-viable-snippet
and https://github.com/go-cq/cq#transactional-api-example

really try to use named parameters in your statements, makes life much easier


**Coding Style**

ES6 string templates are preferred over string concatenation.


thanks it was a big one !


try to use not too generic relationship-types in the real usage,
that makes the queries later more efficient and understandable


Send a message with control(play/pause/full-Screen/stop) and timespan information


Would this fix https://github.com/refactorthis/GraphDiff/issues/160 ?


```
try:
    key = command - 1
    if key > len(menu_items) - 1 or key < 0:
        raise IndexError
except IndexError:
    print u'Invalid input'
    continue
```

Это равносильно

```
key = command - 1
if key > len(menu_items) - 1 or key < 0:
    print u'Invalid input'
    continue
```


I wonder. Is ImageMagick really necessary on OS X if QuartzImageIO is used there? Did you consider something like

```
@osx QuartzImageIO
@windows ImageMagick
@linux ImageMagick
```


Yeah I will write some tests


That looks great, thanks a lot (and for making getoptionkit of course)!


Denne commiten er ikke good. Gad dammit


Err, use `PKG_CONFIG_LIBDIR` instead.  Thanks to @mattiaswal for the heads-up!


Ops, you are right.
That device must be set with 112500 otherwise it won't work, so actually it is not configurable.


Hi, please create a JIRA.
Thanks.


Also if you want to update your graph in the future make sure to add a constraint / index to `:Label(key)`

e.g. `create index on :Node(timestamp)`
`create constraint on (n:Node) assert n.name is unique`

and then use:

```
MATCH (n1:Node {name:{name1}}),(n2:Node {name:{name2}})
CREATE (n1)-[:CONNECTED]->(n2);
```

`MERGE` is also helpful for idempotent operations. It's a "get or create" based on constraints. Both for nodes and relationships.


**Coding Style**

ES6 arrow functions are preferred over the function keyword.


add_openstudio_standards_gem (asparke2) - i386-Windows-7-VisualStudio-12: OK (2389 of 2406 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.29%25-yellow.svg)


Don't send diffs for the luapgsql.md file, it us autogenerated from a LaTeX file...


Ce wp-config n'est pas utilisé en prod' c'est bien ça?


ground_temp_deep (nmerket) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2353 of 2418 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.31%25-yellow.svg)


- Бизнес логика
- Работа с БД
- Работа с модулем

все в одном файле

При росте требований придется все переписывать


sdf


コミットの名前もっと良いのにするんだった。


Many thanks for the advice! Will try to figure that out.


What about squashing this in the previous commit?


The `failed` state is described [later in this document](https://github.com/joyent/rfd/commit/8ab688ca8d5ae50657b8a2a5d84aeaa36da6e0ba#diff-da97b51d9c1ef7b2010e802d5aab60ccR916). I'll add a mention here though to clarify. I like the idea of an `error` field in that case.

Would a workflow job UUID instead of an error property be even more useful, or would that be exposing too much implementation details and couple volume creation too tightly with workflow?


Sure


This commit could be also squashed in the previous one, right?


- NXActionSetTunnel
- NXActionSetTunnel64

の２つも、クラス名、`_subtype`、`_fmt_str` 以外に差分が無いんですね。
BaseClass を作るのはだるいですかね？

<pre>
    class _NXActionSetTunnelBase(NXAction):
        # _subtype, _fmt_str must be attributes of subclass.

        def __init__(self,
                     tun_id,
                     type_=None, len_=None, experimenter=None, subtype=None):
            super(_NXActionSetTunnelBase, self).__init__()
            self.tun_id = tun_id

        @classmethod
        def parse(cls, buf):
            tun_id = struct.unpack_from(
                cls._fmt_str, buf, 0)
            return cls(tun_id)

        def serialize_body(self, buf, offset):
            data = bytearray()
            msg_pack_into(self._fmt_str, data, 0,
                          self.tun_id)
            return data

    class NXActionSetTunnel(_NXActionSetTunnelBase):
        _subtype = nicira_ext.NXAST_SET_TUNNEL

        # tun_id
        _fmt_str = '!2xI'

    class NXActionSetTunnel64(_NXActionSetTunnelBase):
        _subtype = nicira_ext.NXAST_SET_TUNNEL64

        # tun_id
        _fmt_str = '!6xQ'
</pre>


Same for this commit about the squashing.


ground_temp_deep (nmerket) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


imas prav, popravljeno. hvala :)


Whoops, that did not go well, and breaks my site, because I include this with SCSS, where this fails the syntax check.


Fixade även med en knapp och så att p nr 2 även försvinner när man trycker på den.


The set of patches look good to me.


This set of patches looks good to me


これは、１つ前のコミットへの漏れでしょうか？


@lsala If you are not very confident with the commit reverting process, you have [this](https://www.atlassian.com/git/tutorials/undoing-changes/git-revert) documentation that explain how to do so.
In your current situation, that is not a big deal to manually change your commit, but that is the occasion to learn git 😃


Serial.println(CurrentValue);


Just wondering if the method getAllBasicPropertyByPropertyID() itself should throw an exception (NoPropertyFoundException) if there is no property existing with given property id. Would that make the code cleaner?


Yes, I also thought about that, and I didn't had any clear opinion towards one or the other. In the end I let it like this to make easier the review.

If you think that it would be better squashed, I will do it when sending it to the ml.


Displacement can't be cleansed #202


xzczxczxczxczxc


**Nitpick**

Add myself as a copyright owner.


`parse()`、`serialize()` は、`NXAction` に持って行けたりしますか？


This removes the need to uncomment any lines in the build script which can get annoying for all the builds  I make :)


This actually looks like the `Body:n RelPos:(x,y,z)km` is optional, and is left out in NormalFlight (thus the two spaces between `ly  NormalFlight`


`queue_id` の設定ではなく、ただのゼロ埋めのようです。


I bumped PKG_RELEASE with https://github.com/openwrt/packages/commit/2c7e41efebd409f91a702c3e4f41e96af0c94415


You should exclude temporary files .php~, .po~ files from Git (add them to .gitignore).
.mo file I think should be excluded to, because it is compiled from .po file.


mvkl cv


Hi,
I downloded the vanilla kernel from kernel.org and patched it with John Brodie's Asus Transformer patches published here:
https://plus.google.com/communities/117853703024346186936


このフォーマット指定子の説明を追記していただけますか？


このフォーマット指定子についても、説明を追記していただけますか？


look top right to "Asus Files" and open in Google Drive, then you can download a zip.


Mac people should add this to their `.gitconfig_global`


Log.e


Better to ask forgiveness indeed, this "__setup_folder" method shouldn't be in here in the first place though, I'll want to have that in utils at some point, too bad shutil doesn't have such a method btw. Note that the "generated folder" is gone in master, but I'll rebase that in, thanks for the patch!


Дело в том, что мой клиент при запуске не делает ни одного запроса по сети, информация о текущем пользователе хранится локально. Она запрашивается только один раз, при логине. Вот как-то я не рассчитывал на описанный сценарий, когда человек пользуется одновременно двумя клиентами и меняет в другом имена и аватар. Т.е. синхронизации нет, это верно.
Удаленных аккаунтов у меня тоже не было, и поэтому я не знаю, как это выглядит, соответственно не могу сделать нормальное поведение.
> запуск скрипта (и EXE) прерывался с появлением кнопки "SIGN OUT"

Опять же я не знаю, что произошло внутри и почему так вышло, поэтому при любой ошибке я прошу вывод консоли. Случилась ошибка - открой консоль, скопируй текст, и возможно я починю.


Indeed, this can be validated first. It's just a suggestion, I don't use uuid and I find the `-` character prettier :p.


エクスポートしないクラスなので、アンダースコア `_` 始まりにできますか？


no need for `.call`
also here you're probably missing `return` (true).


このコミットの新規追加クラスへの修正では無いので、
１つ前のコミットの方が適切かと思いました。


More to come. This is just the routing information, when messages are sent there will be more interesting relationship types.


ok.


Form和FormControl，FormItem的单元测试先不要写啊，我计划过两天尝试用 context 看看会不会提高性能。


I prefer to use call when a method is dynamically pointed to.

Return shouldn't be needed. Thx for the help anyway!


Adding the stmt.Exec fixed it, thanks!


Probably should rename the second `Pos` capture group to `RelPos`, and as noted above wrap `Body:(?<Body>\\d+) RelPos:\\((?<Pos>.*?)\\)km` in a non-capturing optional group.

```
string rgexpstr = "{(?<Hour>\\d+):(?<Minute>\\d+):(?<Second>\\d+)} System:\"(?<SystemName>[^\"]+)\" StarPos:\\((?<Pos>.*?)\\)ly(?: +Body:(?<Body>\\d+) RelPos:\\((?<RelPos>.*?)\\)km)?(?: +(?<TravelMode>\\w+))?"
```


Yah, on the run I ended up forgetting. But I will add in the next! :dart:


test


2245154-NewVRFHRModel (rongpengzhang) - Win64-Windows-7-VisualStudio-12: OK (2191 of 2196 tests passed, 551 test warnings)

 * 556 tests had: AUD diffs.
 * 215 tests had: EIO diffs.
 * 5 tests had: Table big diffs.
 * 2 tests had: ESO big diffs.
 * 2 tests had: MTR big diffs.
 * 2 tests had: ESO small diffs.
 * 2 tests had: MTR small diffs.
 * 2 tests had: ERR diffs.
 * 1 test had: MTD diffs.
 * 1 test had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.77%25-yellow.svg)


Это зачем ?


__API Description file syntax error on line 1__: expected API name, e.g. '# <API Name>' (Autogenerated message from apiary.io)


using plain 'unsigned' will generate smaller+faster code ..


@mgsloan I've been needing the same thing for present. To write some tests for the TH.


Зачем ты вынес объявление mainPanel в описание класса?


@adrianco let me know when you need more. You also have my email from GotoCon last year :)


Is it possible to make the framework to always ignore `StaleElementReferenceException` I found that to be the most useless exception in my Protractor tests up to a point that I chanced the fx to always ignore that but idk if is easier to do in Java.


Nitpicks:
"reason _why_ we...".
"V" in "Version" doesn't need to be capital.


Getting back on that commit due to the #1259, but why do we try to get a shared lock there? How it is supposed to work if the socket is not in read mode yet?


Agreed, thanks!


Ok, thank you. I've done the git revert


cool :-) im so exited^^


Adding @fanc999 here.


this the new file i made for web designer to used it for helping them to design new creative animation with css3 i hope everyone will useful from that


than idma ksqi ldoldk,a kejqh kd i qikdaq


The cameras folder should be in the same folder as dbc, maps, mmaps and vmaps. They're loaded when the server starts and used to control the invisible npc which is used as a viewport to send the location of creatures during the cinematic.


Same concerns as in the last commit :)


Added.


cool


Wrong version number in second line. Same thing in other xxx-v9.json files.


Indent


Could be a header


Could be a footer


Use lowercase colors
https://google.github.io/styleguide/htmlcssguide.xml?showone=Capitalization#Capitalization


Temporary files such as .mo, .class should not be committed.


ok


I will try to look at it during the weekend.

maybe related, should we create a `username` for pyglmnet and turn it into an organization? It looks like it is still available. Then, the website would live under '`pyglmnet.github.io`' rather than a subdomain. Thoughts @pavanramkumar ?


indent


Nice use of inline and formatted code!


no and ferfi should be a label


I recommend against re-using base functions (`match()`) to store data in.


Very nice option, good OOP.
You can implement only https://docs.python.org/2/reference/datamodel.html#object.__cmp__ and that will get ride of the duplicate code.


Same thing, also multiple elements can't have the same id


The changes to this file you can just commit on master right away


I 've pushed it to the master branch, so I 'll fix it for simplicity


Hmm...

Since it's failing on `cabal update`, I suspect that the config file in the cached `.cabal` directory might be screwed up.

You could try fixing this by temporarily removing the last two lines from the `.travis.yml`, which cache the `.cabal` directory, to force Travis-ci to start afresh...


Yeah I reverted this change, I can't remember exactly what the problem was, I think I had a trailing closing parenthesis.


I like the idea :) The only thing is that by default `ParsOptions` will setup validation and interpolate to false which is a shame (as we want default one to be true).


Netdata (https://github.com/firehol/netdata) is a real-time performance monitoring tool. This submission uses the current Git prerelease, as the latest stable (1.1.0)doesn't build cleanly.

The default configuration makes a few changes for OpenWrt:
 - access log is disabled by default; too verbose for the circular
     syslog buffer, and logging to /tmp is risky memory-wise.
     Some sort of external device would be ideal for this.

 - error and debug logs are sent to OpenWrt's syslog

 - history and frequency times are halved to reduce memory usage,
     as recommended in the netdata wiki

 - external plugins are disabled to eliminate the dependency on bash
     and node.js. Those could be installed from OpenWrt packages if
     you wish to enable that functionality.

     All of those files are still present in the package. The installed
     size could be reduced by eliminating those files first.

Signed-off-by: Claudio Leite <leitec@staticky.com>
Signed-off-by: Sebastian Careba <nitroshift@yahoo.com>


Don't we need to handle `Interpolate` and `Preprocess` for v2 too ?


Thanks! It helps me a lot!


The semantics of \bot should not be the Empty type.  It should contain the neutrals of type \bot.  \star is already the empty type, so you could just rename it to \bot if you fancy.


The title are related so... yeah... https://discuss.atom.io/t/best-way-to-integrate-electron-based-editor-ui-with-c-3d-engine/27393


This commit have a problem, cause the "Buttons" in line 44 and 45 actually are ImageButtons.


Other than inspecting `match` and `match2`, it doesn't seem you use them? Would be nice to show the results that lead to the conclusions above so that it appears in the output.


Files not necessary were deleted


That makes sense for renaming and adding/updating networks. I'm not sure about resizing, so I'll add it to the open questions section. Thank you!


Dat is niet zo goed joh


All of your boxplots and histograms look good.


But the original patch has been created in 2013 before that commit: https://github.com/OpenPLi/enigma2/commit/7b48fd10c089fb9e71eff43e1d3d8ff09237f4f9
in which case aDDP: have moved by one tab, and now bypass = 7; and bypass = 0x22; miss this one tab.


Неееет! Мы не ведём диалог с пользователем внутри классов. Класс — это конкретная функциональность, в данном случае — хранения списка фильмов и выборок по нему. Он должен принимать какие-то аргументы в свои методы и что-то с ними делать, а не останавливать всю работу, чтобы поговорить с пользователем.

Кстати, уровни важности для разных типов фильмов можно задать прямо в коде, в задании это разрешено.

Ещё кстати, узнавать какого типа какой-то объект лучше через `elem.is_a?(ModernMovie)`, а выбрать объекты нужного класса из массива можно с помощью `grep`: `@movies.grep(ModernMovie)`


Yeah, this does not make any sense, does it?  (I am not surprised it does not termination-check.) You need the behavior of \star here.


Should it be reportParams.put("usersignature", (securityUtils.getCurrentUser()!=null ?new ByteArrayInputStream(securityUtils.getCurrentUser().getSignature()):null))


Should it be

reportParams.put("usersignature", (securityUtils.getCurrentUser()!=null ?new ByteArrayInputStream(securityUtils.getCurrentUser().getSignature()):null))


Здесь лучше case с диапазонами значений


As below, you can also use `izip` here.
Rule of thumb: `zip` if you want the list created then and there, `izip` if you don't think you need all the list created and here you don't need the list created. The first (key, value) pairs may be all you need to compare dicts.


As in your way, if c is null, it will still get a NullPointerException. you can try this:

```java
    if (c == null) {
      return initialVal;
    } else if (!c.moveToFirst() || c.getColumnCount() < 2) {
      c.close();
      return initialVal;
    }
```


Mene, mene, tekel, upharsim.  :)


Is there a temporary workaround for the byte-compile issue?


the textures used to be loaded here


Same


The problem seems to be more in the argOrReturnTypeForStruct than here. Var args will encounter the same issue.


Patch looks good.
I would test it thoroughly though, because this patch effectively changes the spirit of the function from: "I just return the base format of any internalformat that is known to OpenGL(ES)", to "I return the base format of an internalformat if it is supported by the *current* GL context, or -1 if not supported". There can be internal logic in mesa/main that relies on _mesa_base_tex_format() not considering API version for each format.


@andrewor14
Can we add this commit also to branch-2.0 ?


Same comment as in previous patch. We need to test is thoroughly.


could have written:
```
.basic-info, .introduction, .finishing {
  width: 100%;
}

.favs, .basic-info, .introduction, .finishing {
  display: flex;
  flex-wrap: wrap;
}
```


需要注意，RFC1945 中规定如下：

> 302 Moved Temporarily
>
> 请求到的资源在一个不同的URL处临时保存。因为重定向有时会被更改，客户端
应继续用请求URI来发出以后的请求。
>
> 新的URL必须由回应中的位置域指定。除非是HEAD请求，否则回应的实体主体
（Entity-Body）必须包括对新URL超链接的简要描述。
>
>如果用POST方法发出请求，而接收到302回应状态码。在这种情况下，除非用户
确认，否则用户代理不必自动重定向请求，因为这将导致改变已发出请求的环境。
>
> 注意：当在接收到302状态码后而自动重定向POST请求时，一些现存的用户代理
> 会错误地将其改为GET请求。

此处 hackhttp 与 RFC1945 有出入，hackhttp 如果指定了 location=True ，则碰到非 GET, HEAD 请求时，会以 GET 请求继续访问 Response 中 Location 指定的 URI。


**SUCCESS** - TeamCity HotRod C# Client :: Release Windows [Build 40](http://ci.infinispan.org/viewLog.html?buildId=39604&buildTypeId=HotRodCSharp_ReleaseWindows2&guest=1) for b706f9ef39631d2ce572417db4aa26d7715f2fe9
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:18:09


Very good separation of concerns. quick_sort algorithm does not know of our "business logic" and it is fully reusable.

Improvement suggestion: change to `quick_sort(start_idx, end_idx, my_list)` and you only need to change how you access the indexes.
The end part would become only:
```
_quick_sort(start_idx, check_idx, my_list)
 _quick_sort(check_idx+1, end_idx, my_list)
```
This way you will not need to create new lists with parts of the big list and then merge those back in the big list.


Very nice.


test comment, will you little tiny comment become an issue?


Add decision making function


Vertaling van het kwalificatiedossier


My bad for skimming.


I would add a comment in the commit log that explains this change better. Maybe quoting a piece of spec or something else, where it is shown that this API of ARB_internalformat_query2 is available for GLES 2.0.


PESAXCO COURSE


@montj2 main reason is that Curassow development isn't active, so it becomes really hard for us to track latest Swift snapshot with such dependencies. We try to replace all such dependencies with alternatives under more active development. Another reason is performance.


SUCCESSFUL_LOGIN needle is expected but echo for it is missing
https://openqa.suse.de/tests/385980/modules/remote_master/steps/16/edit


Well, just realized that next patch has the explanation. I would definitely merge this patch with the next one.


okay, so added my first comment, trying to understand all of this...


@elima, well, the spirit of the function doesn't change so much. Take into account that the method is already checking for the API version for some internalformats, and returning -1 if not supported. Examples:
https://github.com/Igalia/mesa/blob/master/src/mesa/main/glformats.c#L2270
https://github.com/Igalia/mesa/blob/master/src/mesa/main/glformats.c#L2277
https://github.com/Igalia/mesa/blob/master/src/mesa/main/glformats.c#L2292

Those examples were checking for OpenGL core. So for both ES and Compat mode, they would return -1.

And here:
https://github.com/Igalia/mesa/blob/master/src/mesa/main/glformats.c#L2321

Is an example of the opposite. That given format (GL_BGRA) is only supported on opengl es. So in desktop gl, it will return -1.


testing back...


You can use https://docs.python.org/2/library/functions.html#enumerate.
`for idx, line in enumerate(myline.readlines()):`
This will basically get rid of the `+=1` line, but also give you readability and you can use a shorter index name because it is limited to this loop.


I agree, it is totally possible. Nevertheless, the idea is to show the low level details in the workshop as well, and I think that wrapping basic things like this one could leave voids in the audience.

Actually this part was written like that to point out that sometimes it is not the best idea to use the `@FindBy` annotation, because in some situation a `StaleElementReferenceException` can be raised.

To summarise, it was written like that on purpose.


I was referring to AC3+/DDP patch. The whitespaces caused by @technl, most probably due to wrong copy/pase instead of using "git am"


Yes, true. Probably it would be better to do a squash. They are individual commits just because I was adding those stuff incrementaly.


@igorti Now a proper check is done. I have also update the EasyExif library accordingly.
I have also added an unit test in order to check the validity of the change.


nitpick: Maybe change the commit message to:
```
From the ARB_internalformat_query2 spec:
    "Dependencies:
         ..."
````
Basically, indenting the whole spec quote, and also clarifying which spec you are quoting.


Обычно когда добавляется новый ресурс ему высталяется номер. А т.к. у нас номер ресуру уже дали в прогоне симулятора,то мы просто пытаетмся его заново присвоить.  Это временное решение. Нужно что-то получше придумать.


@peterolson Looking forward to seeing this! I'm mostly a backend developer and look forward to learning more about the super fast moving front-end world.


add_openstudio_standards_gem (asparke2) - Win64-Windows-7-VisualStudio-12: Tests Failed (2142 of 2406 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-89.03%25-red.svg)


crash when :
<?php

try{}catch( Exception $e) {}

?>


2245154-NewVRFHRModel (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2223 of 2228 tests passed, 551 test warnings)

 * 556 tests had: AUD diffs.
 * 215 tests had: EIO diffs.
 * 5 tests had: Table big diffs.
 * 2 tests had: ESO big diffs.
 * 2 tests had: MTR big diffs.
 * 2 tests had: ESO small diffs.
 * 2 tests had: MTR small diffs.
 * 2 tests had: ERR diffs.
 * 1 test had: MTD diffs.
 * 1 test had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.svg)


<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<addon id="plugin.video.OMHAR,S MEDIA CENTER" name="[COLOR blue]OMHAR,S MEDIA CENTER[/COLOR]" version="0.0.1" provider-name="OMHAR,S MEDIA CENTER">
    <requires>
    </requires>
    <extension point="xbmc.python.pluginsource"
               library="default.py">
        <provides>video</provides>
    </extension>
    <extension point="xbmc.addon.metadata">
        <platform>all</platform>
        <summary>OMHAR,S MEDIA CENTER</summary>
        <description>OMHAR,S MEDIA CENTER</description>
    </extension>
</addon>


[Assignment 1.zip](https://github.com/MaisarahSanosi/ACJM-/files/260882/Assignment.1.zip)


well ,zookeeper.h is which you missed file in zookeeper folder


../scripts/libscripts.a(spell_shaman.cpp.o): En la función `void Map::VisitAll<Trinity::WorldObjectListSearcher<Trinity::WorldObjectSpellAreaTargetCheck> >(float const&, float const&, float, Trinity::WorldObjectListSearcher<Trinity::WorldObjectSpellAreaTargetCheck>&)':
/root/WorldOfWarcraftWarlordsOfDraenor/src/server/game/Maps/Map.h:830: referencia a `Cell::Cell(CoordPair<512u> const&)' sin definir
/root/WorldOfWarcraftWarlordsOfDraenor/src/server/game/Maps/Map.h:834: referencia a `void Cell::Visit<Trinity::WorldObjectListSearcher<Trinity::WorldObjectSpellAreaTargetCheck>, TypeMapContainer<TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > > > >(CoordPair<512u> const&, TypeContainerVisitor<Trinity::WorldObjectListSearcher<Trinity::WorldObjectSpellAreaTargetCheck>, TypeMapContainer<TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > > > >&, Map&, float, float, float) const' sin definir
/root/WorldOfWarcraftWarlordsOfDraenor/src/server/game/Maps/Map.h:836: referencia a `void Cell::Visit<Trinity::WorldObjectListSearcher<Trinity::WorldObjectSpellAreaTargetCheck>, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeList<AreaTrigger, TypeNull> > > > > > >(CoordPair<512u> const&, TypeContainerVisitor<Trinity::WorldObjectListSearcher<Trinity::WorldObjectSpellAreaTargetCheck>, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeList<AreaTrigger, TypeNull> > > > > > >&, Map&, float, float, float) const' sin definir
collect2: error: ld returned 1 exit status
make[2]: *** [src/server/worldserver/worldserver] Error 1
make[1]: *** [src/server/worldserver/CMakeFiles/worldserver.dir/all] Error 2
make: *** [all] Error 2

Ubuntu 4.8.4-2ubuntu1~14.04.1


In the commit message:

s/the ones that needs the functionality/the ones that _need_ the functionality/


How about following our current URL scheme, so that this should be called something like `/trees/donate` ?


Bonjour,

J'ai installé le plugin sur un synology en suivant la marche à suivre.
Lorsque je me rend sur la page avec la liste des "providers", t411 n'y apparait pas.
Après consultation du fichier log, je vois bien le message "Loaded custom_plugins: t411"..
Une autre action serait-elle nécessaire ?

Merci d'avance pour l'aide que vous pourrez m'apporter.


2245154-NewVRFHRModel (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


hmm, it seems to struggle a bit at STC, slightly positive and gaining about 1 Elo point.

Maybe we could try more discovered checks. Do you see a easy way to check for x-ray attacks on the king by rooks and bishops?


indentation


I guess you mean `lateinit var` not `lateinit val`

Actually you are right. Most of this code was ported from java and need some cleanup.
So some fields indeed can be lateinit but not all of them. I'll cleanup this.


I think `mockXyz` sounds better than `stubXyz`, although I agree with @jfmengels that “stub” and “mock” aren’t really words that come as naturally as “empty” and “constant”.


So this will add **unencrypted** XMPP support to Silence?

From a user point of view I like that Silence does just one thing well (SMS/MMS messaging with encryption support). This simplicity, with its similarity to the standard SMS app, let many persons I known switch to it.

This would also introduce a new way to send insecure messages with this app.
In general, I don't think if it's a good idea...


`getLogger(__name__)` will save you some typing (and the logger name will always reflect module name)


In the commit message:

s/infered/inferred/


Yep. As confirmed by [this job](https://travis-ci.org/tebello-thejane/hs-tls/jobs/129646321), starting from scratch with a clean `.cabal` directory does not cause any issues.


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463042567335
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


2245154-NewVRFHRModel (rongpengzhang) - i386-Windows-7-VisualStudio-12: OK (2191 of 2196 tests passed, 551 test warnings)

 * 556 tests had: AUD diffs.
 * 215 tests had: EIO diffs.
 * 5 tests had: Table big diffs.
 * 2 tests had: ESO big diffs.
 * 2 tests had: MTR big diffs.
 * 2 tests had: ESO small diffs.
 * 2 tests had: MTR small diffs.
 * 2 tests had: ERR diffs.
 * 1 test had: MTD diffs.
 * 1 test had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.77%25-yellow.svg)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463042594405
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463042606794
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463042621179
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


Hi The ’Password‘ field...it seems you‘ve hardcoded your passwd at public.


Oops. I think that was a find/replace mistake by me :-(


I also think they should be squashed.


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1463042640627
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


This is correct, but I have a few suggestions:

- Move the logic outside the file management context. The workflow should be: do potential complex, long running code and after we have the result, open a file to write the result in the format we want. This will make it more maintainable and faster to understand
- The line is great and correct, but it does a lot of things.
`dict_list` is not a list of dicts as the name suggests, is a (dict, dict_index) list. While this is clear when you write the code, you will not remmember this in 2 months when you have an error that only shows you this line and says something line `integer is not iterable`.
```
ordered_dict_data = _quick_sort(dict_data_list)
dict_order = [dict_idx for dict_element, dict_idx in ordered_dict_data]
```
would be an alternative.


I'd be inclined to add an `assert(search != prefixToString.end())` here just because I'm paranoid :)


Right. The initial commit allowed a scatter matrix to be used, but complained to you, now, I realize there is no reason to let bad habits continue and might as well just enforce the right way.


aaa


These variables used to be weak key hash tables to allow the pane objects to be garbage collected. Using lists instead, without a mechanism to remove them when they're destroyed, will keep the objects alive and all other objects they may point to directly or indirectly.


ok. then I am not exactly sure where are you returning `true` for example `if( validResult === true )`?


These two lines limit each dataset to the samples found in the other dataset, but do not ensure that the samples are in the same order...


nitpick: Indent the full spec quotation and specify which spec is being quoted.


Looks good to me!


Re: fission vs nu-fission: You're right, I was broadly lumping Fission, NuFission, Chi, and KappaFission together in that statement.  Clarified.


I think there is a problem with the AML dvb code :

drivers/amlogic/dvb_tv/aml_dvb.c:451:25: error: 'DVB_DEVICE_DSC' undeclared

There is no DVB_DEVICE_DSC in any include file in this kernel (in previous versions it was defined in /drivers/media/dvb-core/dvbdev.h)


@akbertram please review


modified by naveen


This makes more sense. Updating the code with this. Thank you.


A tab crept into sessions.py line 447, causing a pypy test to fail. Do you accept tabs in your code?

http://buildbot.pypy.org/summary/longrepr?testname=test_no_tabs&builder=own-linux-x86-32&build=4386&mod=tool.test.test_tab


This doesn't make sense. If a board only have 1 or 2 LEDs it's misleading to create false LEDs mapping.


Watch out: You committed to your local master, which is probably not what you wanted... Always check which branch you are on (with git status) before committing.

By the way, do you know about https://git-scm.com/docs/git-mv ?


I think you can get more descriptive name like form-field or something similar


I would squash this patch with the next one. This is just a functionality you need to realize something else there.

nitpick: s/made public/make public/
Since you are using present tense in most commit messages, lets be consistent.


https://www.python.org/dev/peps/pep-0008/#imports

It's a good convention to organize imports like this:
```
import native_module
# empty line
import 3rd_party_module_like_mock
# empty line
import PLP.my_module
```


Automatic build report for commit d20218e2e812b237ef2eea2fe660e2d0095cd820:

[![Unit Tests](https://img.shields.io/badge/unittests-97%20/%2097-brightgreen.svg)](#)
[![PyLint](https://img.shields.io/badge/pylint-9.96-brightgreen.svg)](#)
[![Documentation](https://img.shields.io/badge/doc-passed-brightgreen.svg)](#)


**SUCCESS** - TeamCity HotRod C# Client :: Release Windows [Build 41](http://ci.infinispan.org/viewLog.html?buildId=39605&buildTypeId=HotRodCSharp_ReleaseWindows2&guest=1) for b706f9ef39631d2ce572417db4aa26d7715f2fe9
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:14:25


Agree with the ordering, changed.


I used your ovx to run a simple virtual network,but it failed with this ERROR OVXError - Error OFPET_BAD_REQUEST OFPBRC_BAD_VENDOR.What is the problem?


Вроде можно вернуть обратно на `private`.


no I didn’t, and maybe is just what I need!
however I realized that I first need to put order to my local structure and than to upload! could you please delete all the files in the repository?

> Il giorno 12 mag 2016, alle ore 10:47, Kyrre Ness Sjøbæk <notifications@github.com> ha scritto:
>
> Watch out: You committed to your local master, which is probably not what you wanted... Always check which branch you are on (with git status) before committing.
>
> By the way, do you know about https://git-scm.com/docs/git-mv <https://git-scm.com/docs/git-mv> ?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub <https://github.com/collamaf/MDISim/commit/7056df03b519b3fb0abec83ac2347992bc49c2d3#commitcomment-17446584>


It's very dangerous to match samples without checking that your matching was successful, for example:

`
stopifnot(all.equal(sampleNames(eset), tolower(substr(subtypes$Name, 1, 12))))
`

Also, note that you could align both the expression data and pdata of eset just by operating on eset itself, for example, after limiting `subtypes` and `eset` only to common samples:

`eset <- eset[, match(lower(substr(subtypes$Name, 1, 12)), sampleNames(eset))]
`


we can use $this->session()


[[WARN@InvokeSet 5/12/2016 4:20:17 PM] Could Not found the target parameter which is named FilePath // BlastBin; BlastDb; R_HOME; Phylip; RepositoryRoot; Rockhopper;
 Java; Perl; Python; ShoalShell; MySQL; RSS; C2; Dev2; Gcc; SMART; STAMP; GCHOST; MPAlignment; FileName; EndRead
[WARN@InitHandle 5/12/2016 4:20:17 PM] Collection IO extension default IO handle has been changes to Microsoft.VisualBasic.CollectionIO+ISave...
[WARN@InitHandle 5/12/2016 4:20:17 PM] Collection IO extension default IO handle has been changes to Microsoft.VisualBasic.CollectionIO+ISave...
[DEBUG 5/12/2016 4:20:17 PM] Start to load csv data....
[DEBUG 5/12/2016 4:20:17 PM] Load data from filestream....
[DEBUG 5/12/2016 4:21:25 PM] Reflector load data into type LANS.SystemsBiology.SequenceModel.NucleotideModels.SimpleSegment
[DEBUG 5/12/2016 4:23:34 PM] [Job Done!]
[DEBUG 5/12/2016 4:23:35 PM] [CSV.Reflector::LANS.SystemsBiology.SequenceModel.NucleotideModels.SimpleSegment]
Load 974278 lines of data from "file:///C:/Xanthomonas/RegPrecise/sites/sites/GCA_000007165.1_ASM716v1_genomic.fna-SiteMASTScan.Csv"! ...................197.911sec
[ERROR 5/12/2016 4:23:42 PM]  @__directInvoke::System.Exception: __directInvoke ---> System.Exception: /Motif.Info /loci C:/Xanthomonas/RegPrecise/sites/sites/GCA_00
0007165.1_ASM716v1_genomic.fna-SiteMASTScan.Csv /motifs C:/Xanthomonas/Motif_PWM /gff C:/Xanthomonas/genbank/gffs/GCA_000007165.1_ASM716v1_genomic.gff /atg-dist 350
/out C:/Xanthomonas/RegPrecise/sites/sites-gffs/-GCA_000007165.1_ASM716v1_genomic.fna-SiteMASTScan.genomics_context.csv ---> System.Reflection.TargetInvocationExcept
ion: Exception has been thrown by the target of an invocation. ---> System.ArgumentException: An item with the same key has already been added.
   at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
   at System.Linq.Enumerable.ToDictionary[TSource,TKey,TElement](IEnumerable`1 source, Func`2 keySelector, Func`2 elementSelector, IEqualityComparer`1 comparer)
   at System.Linq.Enumerable.ToDictionary[TSource,TKey,TElement](IEnumerable`1 source, Func`2 keySelector, Func`2 elementSelector)
   at LANS.SystemsBiology.Assembly.NCBI.GenBank.TabularFormat.GFF.TrySetMetaData(String[] s_Data, GFF& Gff) in F:\GCModeller.Core\Bio.Assembly\Assembly\NCBI\Database
\Genbank\TabularFormat\FeatureBriefs\GFF\GFF.vb:line 213
   at LANS.SystemsBiology.Assembly.NCBI.GenBank.TabularFormat.GFF.LoadDocument(String Path) in F:\GCModeller.Core\Bio.Assembly\Assembly\NCBI\Database\Genbank\Tabular
Format\FeatureBriefs\GFF\GFF.vb:line 197
   at MEME.CLI.MotifInfo(CommandLine args) in F:\GCModeller\GCI Project\Cli Tools\MEME\CLI\MotifHits.vb:line 394
   --- End of inner exception stack trace ---
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
   at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at Microsoft.VisualBasic.CommandLine.Reflection.EntryPoints.APIEntryPoint.__directInvoke(Object[] callParameters, Object target, Boolean Throw) in F:\VisualBasic_
AppFramework\Microsoft.VisualBasic.Architecture.Framework\CommandLine\Reflection\EntryPoints\APIEntryPoint.vb:line 144
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---


Looks good to me too. Great work!


Also I wonder, what will happen if we change double to long in your test.


My stance on that was the solver will error out for these reasons, so we might as well stop the user in their tracks before then.


Because functions are first class citizens you can do something like this if you want:
```
my_d = e3_sort_dictionaries.Dict
(my_d({'a':0, 'b':2}), my_d({'a':0, 'b':2}), True)
```


_WwwwooooooowwwW_ (complete sarcasm if you didn't notice :P)


You are welcome. 👍


【備忘】
インストールの直前で、mininet.node.OVSSwitch のデフォルト引数 datapath='kernel' を 'user' に置換して、users pace mode をデフォルトにする


Using `__cmp__` would also mean less testing :)


Old habits die hard! single quotes are for characters, double quotes for char arrays!


@ramakrishna-n : Where is this variable set ?


I am not sure that you wanted to select these, it does not select the placeholder, rather the elements that have placeholder


Ignorez mon précédent commentaire, j'ai trouvé ...
En fait il faut arrêter le paquet dans le gestionnaire de paquet syno et redémarrer pour que ça fonctionne.
Si on effectue un restart à partir de l'interface de couchpotato l'ajout du plugin n'est pas pris en compte.


In the actual exercise, `_quick_sort` is run with arguments like `[({'a':1}, 0), ({'b':2}, 1)]` so a tests with tuples would also be nice.


add_symlinks_to_openstudio_standards_gem (asparke2) - i386-Windows-7-VisualStudio-12: Tests Failed (2140 of 2406 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.94%25-red.svg)


I am surprised that there is no separation at all of subtypes on the PCA plot, but I think it could be because the samples are not correctly aligned between the subtype labels and the gene expression?


Automatic build report for commit d20218e2e812b237ef2eea2fe660e2d0095cd820:

[![Unit Tests](https://img.shields.io/badge/unittests-97%20/%2097-brightgreen.svg)](#)
[![PyLint](https://img.shields.io/badge/pylint-9.96-brightgreen.svg)](#)
[![Documentation](https://img.shields.io/badge/doc-passed-brightgreen.svg)](#)


:+1:  Very nice, didn't know you can use it like this.


You may consider using this repository as a "playground", and once you're happy with how it works, just delete it from GitHub (or if possible, rename) and create a new one with the same name.

Remember that you then have to also clone your local copies (and forks) again, since the URL will be the same, but the repository very different.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1642 of 1642 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.96%25-green.svg)


Ok, I see. I thought they were only checking compatibility vs. full profile. But the GL_BGRA example is an important argument.
Then I think this patch does improve a lot the function.


Just wondering, why `h=370`, just to get three clusters I think?


BTW. I was wondering if we should list the changes made in our zotonic deps like z_stdlib, mochiweb and friends in our release notes.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


max_period: The vacancy can only last for a period of 6 months.


it seems a good strategy, I’ll come to you when it is the moment! thanks!
> Il giorno 12 mag 2016, alle ore 10:53, Kyrre Ness Sjøbæk <notifications@github.com> ha scritto:
>
> You may consider using this repository as a "playground", and once you're happy with how it works, just delete it from GitHub (or if possible, rename) and create a new one with the same name.
>
> Remember that you then have to also clone your local copies (and forks) again, since the URL will be the same, but the repository very different.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub <https://github.com/collamaf/MDISim/commit/7056df03b519b3fb0abec83ac2347992bc49c2d3#commitcomment-17446673>


Ditto.


The `h=370` cut creates 3 clusters in the plot when I compiled your document.


Nothing more than I tend to prefer it, there isn't a particular scenario that drives me one way or the other, I just like knowing what my values are because they are what they are when I set it.


@trentm The rationale behind a `sync` option was based on my understanding of what the same option provides for the `DeleteVm`'s VMAPI endpoint:

* The ability to do bulk deletes of VMs without having to keep a connection to the server for the duration of the delete process wen `sync === false`.
* The ability to force a synchronous delete when implementing support for tools that expect synchronous operations, e.g the API that supports `docker rm`.

But I may be missing something, and I may be misunderstanding your question.


min_message_one: Please enter at least {{ limit }} character.
-s
singular


Where can I download the .exe now ?


how about using alpine linux and coming down from 184 mb for base image to 5 mb :)


Hi,

checked out your project and tested it with some SJ links. But then an error occures. Here is the debug output:

12.05.2016 08:52:32	INFO	Activating Accounts...
345	12.05.2016 08:52:32	INFO	Activating Plugins...
346	12.05.2016 08:52:32	INFO	Starting builtin webserver: 0.0.0.0:8000
347	12.05.2016 08:52:32	WARNING	ADDON AntiStandby: Unable to change system power state | [Errno 2] No such file or directory
348	12.05.2016 08:52:32	WARNING	ADDON AntiStandby: Unable to change display power state | [Errno 2] No such file or directory
349	12.05.2016 08:52:33	INFO	ADDON XFileSharing: Auto-discover new hosters
350	12.05.2016 08:52:33	INFO	ADDON UpdateManager: pyLoad is up to date!
351	12.05.2016 08:52:33	INFO	ADDON XFileSharing: Auto-discover new crypters
352	12.05.2016 08:52:33	INFO	pyLoad is up and running
353	12.05.2016 08:52:39	INFO	ADDON ClickNLoad: Proxy listening on 0.0.0.0:9666
354	12.05.2016 08:52:51	INFO	Decrypting starts: ul_aced-gomorrha-s02e01-480p.html
355	12.05.2016 08:52:52	WARNING	CRYPTER SerienJunkies[1]: Plugin may be unstable
356	12.05.2016 08:52:52	INFO	CRYPTER SerienJunkies[1]: Grabbing link info...
357	12.05.2016 08:52:52	INFO	CRYPTER SerienJunkies[1]: Link name: ul_aced-gomorrha-s02e01-480p.html
358	12.05.2016 08:52:52	INFO	CRYPTER SerienJunkies[1]: Link size: N/D
359	12.05.2016 08:52:52	INFO	CRYPTER SerienJunkies[1]: Link status: queued
360	12.05.2016 08:52:52	INFO	CRYPTER SerienJunkies[1]: Processing url: http://download.serienjunkies.org/f-6bfe23c056fc0a93/ul_aced-gomorrha-s02e01-480p.html
361	12.05.2016 08:52:53	ERROR	Decrypting failed: ul_aced-gomorrha-s02e01-480p.html | Bad server response: 400 Bad Request
362	12.05.2016 08:53:28	INFO	Decrypting starts: ul_aced-gomorrha-s02e01-480p.html
363	12.05.2016 08:53:29	WARNING	CRYPTER SerienJunkies[1]: Plugin may be unstable
364	12.05.2016 08:53:29	INFO	CRYPTER SerienJunkies[1]: Grabbing link info...
365	12.05.2016 08:53:29	INFO	CRYPTER SerienJunkies[1]: Link name: ul_aced-gomorrha-s02e01-480p.html
366	12.05.2016 08:53:29	INFO	CRYPTER SerienJunkies[1]: Link size: N/D
367	12.05.2016 08:53:29	INFO	CRYPTER SerienJunkies[1]: Link status: queued
368	12.05.2016 08:53:29	INFO	CRYPTER SerienJunkies[1]: Processing url: http://download.serienjunkies.org/f-6bfe23c056fc0a93/ul_aced-gomorrha-s02e01-480p.html
369	12.05.2016 08:53:29	ERROR	Decrypting failed: ul_aced-gomorrha-s02e01-480p.html | Bad server response: 400 Bad Request

Can you explain this ?


1. Последняя строчка перезапишет номер, даже есть он null. Тебе нужно это поведение ?
2. Подобных комментариев буть не должно. Лучше стереть, чем такое делать.


already_used: This name is already in use.


I think this commit is breaking something.

![screen shot 2016-05-12 at 10 53 41](https://cloud.githubusercontent.com/assets/1442700/15209245/4dac2c04-1830-11e6-9d0a-091107ad100e.png)