@tisto Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.openid/4/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/openid/__init__.py:0:1: C101 Coding magic comment not found
plone/app/openid/__init__.py:0:1: I001 isort found changes, run it on the file
plone/app/openid/__init__.py:4:1: E402 module level import not at top of file
plone/app/openid/__init__.py:5:40: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public
plone/app/openid/config.py:0:1: C101 Coding magic comment not found
plone/app/openid/setuphandlers.py:0:1: C101 Coding magic comment not found
plone/app/openid/setuphandlers.py:0:1: I001 isort found changes, run it on the file
plone/app/openid/setuphandlers.py:13:13: E225 missing whitespace around operator
plone/app/openid/setuphandlers.py:18:5: T001 print statement found.
plone/app/openid/setuphandlers.py:18:18: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:19:33: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:20:29: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:20:45: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:24:8: E225 missing whitespace around operator
plone/app/openid/setuphandlers.py:24:31: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:25:11: E225 missing whitespace around operator
plone/app/openid/setuphandlers.py:26:5: F841 local variable 'interfaces' is assigned to but never used
plone/app/openid/setuphandlers.py:26:15: E225 missing whitespace around operator
plone/app/openid/setuphandlers.py:28:13: E225 missing whitespace around operator
plone/app/openid/setuphandlers.py:31:18: E225 missing whitespace around operator
plone/app/openid/setuphandlers.py:31:24: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:32:23: E225 missing whitespace around operator
plone/app/openid/setuphandlers.py:32:29: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:35:13: T001 print statement found.
plone/app/openid/setuphandlers.py:35:26: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:35:48: S001 found %s formatter
plone/app/openid/setuphandlers.py:36:21: E127 continuation line over-indented for visual indent
plone/app/openid/setuphandlers.py:36:43: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:42:80: E501 line too long (88 > 79 characters)
plone/app/openid/setuphandlers.py:44:80: E501 line too long (96 > 79 characters)
plone/app/openid/setuphandlers.py:46:13: T001 print statement found.
plone/app/openid/setuphandlers.py:46:26: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:59:35: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:62:1: W391 blank line at end of file
plone/app/openid/testing.py:0:1: I001 isort found changes, run it on the file
plone/app/openid/testing.py:24:10: Q000 Remove bad quotes.
plone/app/openid/tests/__init__.py:0:1: C101 Coding magic comment not found
plone/app/openid/tests/__init__.py:0:1: I001 isort found changes, run it on the file
plone/app/openid/tests/__init__.py:1:1: W391 blank line at end of file
plone/app/openid/tests/test_view.py:0:1: C101 Coding magic comment not found
plone/app/openid/tests/test_view.py:0:1: I001 isort found changes, run it on the file
plone/app/openid/tests/test_view.py:2:80: E501 line too long (91 > 79 characters)
plone/app/openid/tests/test_view.py:22:44: Q000 Remove bad quotes.
plone/app/openid/tests/test_view.py:26:14: D001 found assertEquals replace it with assertEqual
plone/app/openid/tests/test_view.py:27:14: D001 found assertEquals replace it with assertEqual
plone/app/openid/tests/test_view.py:33:14: D001 found assertEquals replace it with assertEqual
plone/app/openid/tests/test_view.py:34:14: D001 found assertEquals replace it with assertEqual
plone/app/openid/tests/test_view.py:45:14: D001 found assertEquals replace it with assertEqual
plone/app/openid/tests/test_view.py:46:14: D001 found assertEquals replace it with assertEqual
plone/app/openid/portlets/login.py:0:1: C101 Coding magic comment not found
plone/app/openid/portlets/login.py:0:1: I001 isort found changes, run it on the file
plone/app/openid/portlets/login.py:26:80: E501 line too long (91 > 79 characters)
plone/app/openid/portlets/login.py:39:17: S001 found %s formatter
plone/app/openid/portlets/login.py:42:5: E303 too many blank lines (2)
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.openid/5/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/openid/__init__.py:0:1: C101 Coding magic comment not found
plone/app/openid/__init__.py:6:40: D001 found declarePublic replace it with AccessControl.ClassSecurityInfo.public
plone/app/openid/config.py:0:1: C101 Coding magic comment not found
plone/app/openid/setuphandlers.py:0:1: C101 Coding magic comment not found
plone/app/openid/setuphandlers.py:0:1: I001 isort found changes, run it on the file
plone/app/openid/setuphandlers.py:18:5: T001 print statement found.
plone/app/openid/setuphandlers.py:18:18: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:19:33: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:20:29: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:20:45: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:24:33: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:30:26: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:31:31: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:34:13: T001 print statement found.
plone/app/openid/setuphandlers.py:34:26: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:34:48: S001 found %s formatter
plone/app/openid/setuphandlers.py:35:39: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:47:13: T001 print statement found.
plone/app/openid/setuphandlers.py:47:26: Q000 Remove bad quotes.
plone/app/openid/setuphandlers.py:60:35: Q000 Remove bad quotes.
plone/app/openid/testing.py:0:1: I001 isort found changes, run it on the file
plone/app/openid/testing.py:24:10: Q000 Remove bad quotes.
plone/app/openid/tests/test_view.py:0:1: C101 Coding magic comment not found
plone/app/openid/tests/test_view.py:20:44: Q000 Remove bad quotes.
plone/app/openid/tests/test_view.py:24:14: D001 found assertEquals replace it with assertEqual
plone/app/openid/tests/test_view.py:25:14: D001 found assertEquals replace it with assertEqual
plone/app/openid/tests/test_view.py:31:14: D001 found assertEquals replace it with assertEqual
plone/app/openid/tests/test_view.py:32:14: D001 found assertEquals replace it with assertEqual
plone/app/openid/tests/test_view.py:43:14: D001 found assertEquals replace it with assertEqual
plone/app/openid/tests/test_view.py:44:14: D001 found assertEquals replace it with assertEqual
plone/app/openid/portlets/login.py:0:1: C101 Coding magic comment not found
plone/app/openid/portlets/login.py:0:1: I001 isort found changes, run it on the file
plone/app/openid/portlets/login.py:40:17: S001 found %s formatter
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


два раза? <Private>True</Private>
 +      <Private>False</Private>


API пишется всегда с большими беуквами (всеми)


аналогично


what I mean is:
```
if p.GetId() == peer.GetId() {
    c.Assert(p.GetStoreId(), Equals, peer.GetStoreId())
}
```


Please ensure not to commit this file


но в название локали (не значении) и свойства только первая буква большая (сейчас правильно)


``<dependency>`` や ``<parent>`` はインライン化しておいてください。


somebody please tell me what this does


@NathanW2 you are using nmake


这里注释掉之后，服务器返回错误码之后， 还去尝试执行 Callback.parseNetworkResponse() ，反而使错误难以定位。


hello GitHub


probably?


Fix issue #1


It is probably not a very expensive operation, but given the resulting key will always be the same, wouldn't it be more efficient to keep a static reference to it, instead of recreating the same value with each call?
I don't know how often this builder is meant to be called though.


great fixes :+1:


I think the Assert makes no sense. If we find a Peer with the same Id, it already means we meet an error, no need to check the StoreId.


You want to obfuscate these, else they might be flagged at review time. [NSString stringWithFormat: and splitting up strings in a few parts works great.


这里没有对后台传来的数据进行卸载，后台一个改动，前端就挂一条线，不妥啊


yep, my fault, what I say is for next L64.


Should this be centering the window when the playback actually starts when using `force-window=immediate` (possibly combined with `autofit[-larger]`) ?

If yes, then I don't think it works here (testing with this and the following related commits too - current HEAD - 4aa017e).


The code is a bit clumsy, I know. However, my computer raises a memory-error in case I try to pickle the whole data at once. Max recommended to append to a pickle file (in amounts of data that can be performed by my computer) which I realized in this part of the code.


Me being derpking this days :v: xD


skall this be happiliikkuja.dev


Fix issue #115


Я не понимаю, где сделано так. У Вас есть возможность оставлять замечания к своему коду? Если есть, напишите прямо на строке с кодом, где это.


ok


Is this temporary? Content of tab can not be re-sized because of this.


This looks nice. But I'm seeing a huge degradation in performance compared to ``AnimatedView`` impl. Any idea why that would be?

@hedgerwang @ericvicenti


Normalmente el estilo bibliográfico debería ordenarlo solo...


As mentioned on IRC, I believe this would make more sense in a `clean:` target.


przebirg nie 265258 tylko 700000


The previous patch solves a problem with connection handling, when a "Director" tries to connect with invalid credentials.

This patch improves the output of the status command to not only show that a Director is connected but also the name of the Director, as there could be multiple defined.
It also says "Unknown connection", when the Director is not (yet) known. This happens in the initial phase of the authentication, when a connection exists, but the fd have no information about the Director.


przebieg 265258 tylko 700000


What OS is this? Some older Debian version perhaps?

You could try this: https://developer.pidgin.im/ticket/9439

Probably not a proper fix, but might get you around the issue.


No me dejaba hacerlo automáticamente y resulta que era por un problema de configuración de mi versión.

Por cierto, se pueden hasta 14 páginas, así que no hay problema


Aldo, why you back куегкт multiman.png file instead tools.png?


Oops, closes #1


@OzancanKaratas remember to update your fork, since I've re-added the file.


On Mon, 23 May 2016, Markus Elfring wrote:

>
> -+For instance, if we only wanted to remove call calls to c() but which also
> ++For instance, if we only wanted to remove calls to c() but which also

I don't get it.  This has already been fixed in a later commit.  Why are
you wasting time complaining about it?

julia


On Mon, 23 May 2016, Markus Elfring wrote:

>
> -+or that the statements in between must be present at least once (<+... ...
> +).
> ++or that the statements in between must be present at least once (<+... ...
> +>).

I don't think this text even exists any more.  At least grep doesn't show
it.

julia

>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on
> GitHub[AAesmqLpMCaCpPa1Y67RrzGYXkPhcsbIks5qEVN9gaJpZM4IkOKv.gif]
>
>
>


Love this idea.

You could add a paragraph about how it might be possible with WebRTC. WebTorrent, DHT, that's essentially using the same technique powered by hashes.


Is it meant to be different?  Never had a issue on the past. Has it always
been like this?

On Mon, 23 May 2016 6:02 pm Jürgen Fischer <notifications@github.com> wrote:

> @NathanW2 <https://github.com/NathanW2> you are using nmake
>
> —
> You are receiving this because you were mentioned.
>
>
> Reply to this email directly or view it on GitHub
> <https://github.com/qgis/QGIS/commit/0b6dd352c9124297cb65198c6c0781fec46a8232#commitcomment-17575530>
>


I'm also testing using ninja as a build system because it seems better on
Windows

On Mon, 23 May 2016 6:24 pm Nathan Woodrow <madmanwoo@gmail.com> wrote:

> Is it meant to be different?  Never had a issue on the past. Has it always
> been like this?
>
> On Mon, 23 May 2016 6:02 pm Jürgen Fischer <notifications@github.com>
> wrote:
>
>> @NathanW2 <https://github.com/NathanW2> you are using nmake
>>
>> —
>> You are receiving this because you were mentioned.
>>
>>
>> Reply to this email directly or view it on GitHub
>> <https://github.com/qgis/QGIS/commit/0b6dd352c9124297cb65198c6c0781fec46a8232#commitcomment-17575530>
>>
>


Agreed, and done!
https://github.com/hoglet67/PiTubeDirect/commit/c9035208c2f1de8296668420506c6dc28f06f97d


pas encore dans le frontend ?


I don't understand how this stuff is designed to work (what are `FunctionContext` and `LoggingFunction` objects?) so I'm not sure...


I dug out the information about `rels` files from one of the other manuals when I wrote it, so believe this is correct.  for a file `foo/bar.xml`, the `rels` file is stored at `foo/_rels/bar.xml.rels` I believe.


应用框架


did this work for you? I believe you also need at least netty-tcnative-... it's a dependency for hbase stuff.


Yes, although something should be done with the returned credentials to save them if the request is successful, because `GetCreds` may actually be prompting for *new* creds, not just loading saved creds. Although the `GetCreds` call will complete the auth headers for the passed in request, if that had resulted in a prompt because creds weren't saved yet, this is the only copy of the creds and they should be passed to `SaveCredentials` *if* the response is a successful one. It's important not to just save them in all cases, because that could save incorrect creds and cause them to be reloaded next time too.

So really those creds need to be saved somewhere for calling `SaveCredentials` on a successful response code. See `doHttpRequest` and `handleResponse` in the `httputil` package, which you could just re-use via the exported `Do` method or refactor it some more.

You should probably check out more of that code anyway since it does things like tracing & stats which shouldn't be lost.


ttt


tt


de


Thanks for the info.
I didn't forget the ACID part https://github.com/ACID-Scripts/WOTLK/commit/33988d488ae941bf8db8f841e9bc4f02d56763db


This implies that the `abc` argument is an instantiation of an abstract class? :P


I included it on `assets` to make sure assets rebuild works on any scenario without having to explicitly have to run `clean` before.


Is another small adjustment needed here?

```patch
-+  systematically used, even in Pycaml is already installed locally.
++  systematically used, even if Pycaml is already installed locally.
```


@frederic34
Which version do you use? Did customize the menu?
In the version 3.9.1 the cron menu is in "Modules tools". Moreover this patch does not modify the location of the cron menu entry, it only makes the "Modules tools" visible when the cron module is enabled.


fadfadfadfadfad


Yeah, that should be `type`. It's annoying that you can't specify classes in type hints.


comment


добавлен формат doc


good catch.


@JJ @analca3 ya está reordenado. Voy a echar la mañana mirando a ver errores que corregir. Lo mando para las 1 o así, ¿va?
Graciaaaaaas :dancer:


async =_=


Awesome! Thanks!


@Sway   我不知道为什么用directive的时候老是不对。。能帮我看看么


@dkniffin see https://github.com/mattheworiordan/capybara-screenshot/issues/174.  Looking at this commit, it's not immediately obvious why `mkmf` was added as a requirement here.  I propose removing it, but wanted to check with you in case there was a reason I was not aware of.


@swaylq  我不知道为什么用directive的时候老是不对。。能帮我看看么


In line 338 should be strcat(segment_name, "$Number$"); <- there is missing $ at the end, and generated mpd is wrong, my player cannot play it. Im not sure about 336: strcat(segment_name, "$Time"); but im think its the same


da la ce naiba iti trebuie in programul asta?
nu inteleg ce ai vrut sa faci


зачем?


Karolis Spring. (mapa donde suena Xanadu <3 )
Las esculturas de Búhos de ese lugar son conscientes de hecho la "líder" de las esculturas te pide ayuda.


плюс `*` выстрелит в голову через какое-то время


Is this needed with duplex streams ? This should not be called at all now that your backend can do input.


useCaseDiagramm, Testkriterien, Meetingsprotokolle


You should cap the latency down to 128 frames, because that's the minimum Firefox can deal with, for spec reasons.


netbsd arm generic timer

    arch/arm/cortex/gtmr.c
    arch/arm/cortex/gtmr_intr.h
    arch/arm/cortex/gtmr_var.h

    sys/sys/cdefs.h
    arch/arm/include/asm.h
    arch/arm/include/armreg.h


It find it interesting that [a recent addition was revoked](https://github.com/coccinelle/coccinelle/commit/10b024a36f676feaef136acac6296557e3ddb087 "Added: Generated file parser_cocci_menhir.ml") here.


`*` поправлю позже, это считай хотфикс, чтобы сборка прошла https://travis-ci.org/spbunderhood/spbunderhood.ru/builds/132202507


good


@goldingn Looks like we have test failures on travis after this merge... looking into it now


окай


What are you doing dude


@goldingn all good, just looks like the bioclim data repo is down (AGAIN!)


This should support `(CUBEB_DEVICE_TYP_INPUT | CUBEB_DEVICE_TYPE_OUTPUT)` for `cubeb_device_type`, and return all devices,


@Xebax
here you are in develop branch, this is actually version 4.0


You First need to initialize node js for server side rendering so that server will listen to a port.
     API contains component with which you can add the data(POST)API again you can (DELETE)API will remove the listed item form the specified (JSON file)url


I had to install "to-iso-string" manually, so i would add here also:

"to-iso-string": "0.0.2"


Would the proposed `Sendmessage<TLParam, TWParam>` use reflection internally to handle the most common cases? would this a good thing to submit?


I find it strange that such a change was committed.


Are we doing such things like creating files in unit tests which contain one function and this file is not spec?


cubeb's style is to have a space before and after * for types.


Mentioning the  framework we are working on.


#  Web Tools  available here are build in HTML5 and CSS3 with Bootstrap framework


This is good, I had in mind to refactor it using json_encode as I first focused on get the whole lot to work.
I wanted to close before the evening with something working.

BTW, I'm under the impression that this is just a partial change. Is that on purpose or should I complete and make everything an array json_encoded?


Looks good, can you prepare a PR to https://github.com/kinetiknz/cubeb with the comments addressed ? Then we can uplift the changes along with your build system changes in Gecko.


My bad :hammer:


Yea, it broke our builds. Will you be able to make release today?


Cool


Ya, I've had issues with bioclim since Saturday.  Do they post notices for their server status anywhere?


@just-paja I just did


> I'm also testing using ninja as a build system because it seems better on Windows

It looks also very promising on Linux, just had some troubles when trying it with generating the expression translations IIRC.


When I wrote this, only me and God knew what I was doing, now only God knows.


This is still the wrong collation!

utf8_bin is required for unit tests to pass.