[R/branch_sorter.R:11:64:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/R/branch_sorter.R#L11) *style:* **Put spaces around all infix operators.**
```r
    filename$ordered.edges <- data.table::data.table(table, key="V2")
                                                              ~^~
```
[R/test.R:3:4:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/R/test.R#L3) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:7:4:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/R/test.R#L7) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:8:10:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/R/test.R#L8) *warning:* **Do not use absolute paths.**
```r
  setwd("d:/Peregrine/")
         ^~~~~~~~~~~~~
```
[R/test.R:9:31:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/R/test.R#L9) *warning:* **Do not use absolute paths.**
```r
  testit::assert(file.exists("d:/Peregrine"))
                              ^~~~~~~~~~~~
```
[R/test.R:12:1:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/R/test.R#L12) *style:* **lines should not be more than 80 characters.**
```r
  all_parameters <- Sys.glob("*.RDa") #alternative, but longer: all_parameters <- list.files(pattern = "\\.RDa$", ignore.case=TRUE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:15:13:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/R/test.R#L15) *style:* **Use <-, not =, for assignment.**
```r
  filenames = "all_parameters"
            ^
```
[R/test.R:19:10:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/R/test.R#L19) *warning:* **Do not use absolute paths.**
```r
  setwd("c:/Users/Aline/Cer2016")
         ^~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:21:4:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/R/test.R#L21) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:22:22:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/R/test.R#L22) *style:* **Commas should always have a space after.**
```r
  rng_seeds <- seq(1,4)
                     ^
```
[R/test.R:54:4:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/R/test.R#L54) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:9:4:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/tests/testthat/test-branch_sorter.R#L9) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"brach_length"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:10:4:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/tests/testthat/test-branch_sorter.R#L10) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"taxon_name"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:11:4:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/tests/testthat/test-branch_sorter.R#L11) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"brach_length"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:15:69:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/tests/testthat/test-branch_sorter.R#L15) *style:* **Commas should always have a space after.**
```r
  expected <- df(taxon_name = c("A", "B", "C"), branch_length = c(1,1,2))
                                                                    ^
```
[tests/testthat/test-branch_sorter.R:15:71:](https://github.com/richelbilderbeek/Cer2016/blob/4c190c656e296253de666e9392359a0323702f79/tests/testthat/test-branch_sorter.R#L15) *style:* **Commas should always have a space after.**
```r
  expected <- df(taxon_name = c("A", "B", "C"), branch_length = c(1,1,2))
                                                                      ^
```


I stole the idea from you :)

(You had a default mocks context manager)


apparently, it's when I clicked a symbol in the legend entry. There is no more current layer selected in the legend, although the dock stays enabled. Whenever I change something, it probably looks for the active layer but there is no one.


[R/branch_sorter.R:11:64:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/R/branch_sorter.R#L11) *style:* **Put spaces around all infix operators.**
```r
    filename$ordered.edges <- data.table::data.table(table, key="V2")
                                                              ~^~
```
[R/test.R:3:4:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/R/test.R#L3) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:7:4:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/R/test.R#L7) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:8:10:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/R/test.R#L8) *warning:* **Do not use absolute paths.**
```r
  setwd("d:/Peregrine/")
         ^~~~~~~~~~~~~
```
[R/test.R:9:31:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/R/test.R#L9) *warning:* **Do not use absolute paths.**
```r
  testit::assert(file.exists("d:/Peregrine"))
                              ^~~~~~~~~~~~
```
[R/test.R:12:1:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/R/test.R#L12) *style:* **lines should not be more than 80 characters.**
```r
  all_parameters <- Sys.glob("*.RDa") #alternative, but longer: all_parameters <- list.files(pattern = "\\.RDa$", ignore.case=TRUE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:15:13:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/R/test.R#L15) *style:* **Use <-, not =, for assignment.**
```r
  filenames = "all_parameters"
            ^
```
[R/test.R:19:10:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/R/test.R#L19) *warning:* **Do not use absolute paths.**
```r
  setwd("c:/Users/Aline/Cer2016")
         ^~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:21:4:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/R/test.R#L21) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:22:22:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/R/test.R#L22) *style:* **Commas should always have a space after.**
```r
  rng_seeds <- seq(1,4)
                     ^
```
[R/test.R:54:4:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/R/test.R#L54) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:9:4:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/tests/testthat/test-branch_sorter.R#L9) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"brach_length"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:10:4:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/tests/testthat/test-branch_sorter.R#L10) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"taxon_name"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:11:4:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/tests/testthat/test-branch_sorter.R#L11) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"brach_length"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:15:69:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/tests/testthat/test-branch_sorter.R#L15) *style:* **Commas should always have a space after.**
```r
  expected <- df(taxon_name = c("A", "B", "C"), branch_length = c(1,1,2))
                                                                    ^
```
[tests/testthat/test-branch_sorter.R:15:71:](https://github.com/richelbilderbeek/Cer2016/blob/55bd3252d84869b0411460a08372db9b81d1ab9c/tests/testthat/test-branch_sorter.R#L15) *style:* **Commas should always have a space after.**
```r
  expected <- df(taxon_name = c("A", "B", "C"), branch_length = c(1,1,2))
                                                                      ^
```


[R/branch_sorter.R:11:64:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/R/branch_sorter.R#L11) *style:* **Put spaces around all infix operators.**
```r
    filename$ordered.edges <- data.table::data.table(table, key="V2")
                                                              ~^~
```
[R/test.R:3:4:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/R/test.R#L3) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:7:4:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/R/test.R#L7) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:8:10:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/R/test.R#L8) *warning:* **Do not use absolute paths.**
```r
  setwd("d:/Peregrine/")
         ^~~~~~~~~~~~~
```
[R/test.R:9:31:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/R/test.R#L9) *warning:* **Do not use absolute paths.**
```r
  testit::assert(file.exists("d:/Peregrine"))
                              ^~~~~~~~~~~~
```
[R/test.R:12:1:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/R/test.R#L12) *style:* **lines should not be more than 80 characters.**
```r
  all_parameters <- Sys.glob("*.RDa") #alternative, but longer: all_parameters <- list.files(pattern = "\\.RDa$", ignore.case=TRUE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:15:13:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/R/test.R#L15) *style:* **Use <-, not =, for assignment.**
```r
  filenames = "all_parameters"
            ^
```
[R/test.R:19:10:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/R/test.R#L19) *warning:* **Do not use absolute paths.**
```r
  setwd("c:/Users/Aline/Cer2016")
         ^~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:21:4:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/R/test.R#L21) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:22:22:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/R/test.R#L22) *style:* **Commas should always have a space after.**
```r
  rng_seeds <- seq(1,4)
                     ^
```
[R/test.R:54:4:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/R/test.R#L54) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:9:4:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/tests/testthat/test-branch_sorter.R#L9) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"brach_length"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:10:4:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/tests/testthat/test-branch_sorter.R#L10) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"taxon_name"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:11:4:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/tests/testthat/test-branch_sorter.R#L11) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"brach_length"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:15:69:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/tests/testthat/test-branch_sorter.R#L15) *style:* **Commas should always have a space after.**
```r
  expected <- df(taxon_name = c("A", "B", "C"), branch_length = c(1,1,2))
                                                                    ^
```
[tests/testthat/test-branch_sorter.R:15:71:](https://github.com/richelbilderbeek/Cer2016/blob/078718c324c687459e2578250148396386e27058/tests/testthat/test-branch_sorter.R#L15) *style:* **Commas should always have a space after.**
```r
  expected <- df(taxon_name = c("A", "B", "C"), branch_length = c(1,1,2))
                                                                      ^
```


> Does anyone actually use this?

Not me. I would change option

-a

from

```
Hint all glyphs that are in the history file, or are unhinted.
Has effect only if the history file is being used.
```

to

```
Hint all glyphs that are unhinted.
```

and

-r

from

```
Re-hint glyphs. Glyphs not in the history file will be hinted even
if they already have hints. However, glyphs will not be hinted if
they both have not changed and are in the history file.
```

to

```
Hint all glyphs even if they already have hints. (Removes old hints.)
```

Naturally "all glyphs" with the restrictions of the options -g, -gf, -xg and -xgf, if they are used.


Let's just use `Rails.cache` directly.


commenting here


[R/branch_sorter.R:10:54:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/R/branch_sorter.R#L10) *style:* **Put spaces around all infix operators.**
```r
    edgeorder    <- data.table::data.table(table, key="V2")
                                                    ~^~
```
[R/branch_sorter.R:12:39:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/R/branch_sorter.R#L12) *warning:* **no visible binding for global variable 'V2', Did you mean '^'?**
```r
    edgeorder    <- subset(edgeorder, V2 < (length(filename$tip.label) + 1))
                                      ^~
```
[R/collect_posterior_filenames.R:26:1:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/R/collect_posterior_filenames.R#L26) *style:* **lines should not be more than 80 characters.**
```r
  n_species_trees_samples <- as.numeric(file$parameters$n_species_trees_samples[2])
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/collect_posterior_filenames.R:36:25:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/R/collect_posterior_filenames.R#L36) *style:* **Commas should always have a space after.**
```r
          base_filename,"_", i, "_", j, "_", k, ".trees", sep = ""
                        ^
```
[R/test.R:3:4:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/R/test.R#L3) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:7:4:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/R/test.R#L7) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:8:10:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/R/test.R#L8) *warning:* **Do not use absolute paths.**
```r
  setwd("d:/Peregrine/")
         ^~~~~~~~~~~~~
```
[R/test.R:9:31:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/R/test.R#L9) *warning:* **Do not use absolute paths.**
```r
  testit::assert(file.exists("d:/Peregrine"))
                              ^~~~~~~~~~~~
```
[R/test.R:12:1:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/R/test.R#L12) *style:* **lines should not be more than 80 characters.**
```r
  all_parameters <- Sys.glob("*.RDa") #alternative, but longer: all_parameters <- list.files(pattern = "\\.RDa$", ignore.case=TRUE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:15:13:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/R/test.R#L15) *style:* **Use <-, not =, for assignment.**
```r
  filenames = "all_parameters"
            ^
```
[R/test.R:19:10:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/R/test.R#L19) *warning:* **Do not use absolute paths.**
```r
  setwd("c:/Users/Aline/Cer2016")
         ^~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:21:4:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/R/test.R#L21) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:22:22:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/R/test.R#L22) *style:* **Commas should always have a space after.**
```r
  rng_seeds <- seq(1,4)
                     ^
```
[R/test.R:54:4:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/R/test.R#L54) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:8:5:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/tests/testthat/test-branch_sorter.R#L8) *style:* **Commented code should be removed.**
```r
  # expect_equal(count(names(df),"branch_length"), 1)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:9:4:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/tests/testthat/test-branch_sorter.R#L9) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"taxon_name"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:10:4:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/tests/testthat/test-branch_sorter.R#L10) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"brach_length"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:13:5:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/tests/testthat/test-branch_sorter.R#L13) *style:* **Commented code should be removed.**
```r
  # expect_equal(length(df$taxon_name), 3)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:14:5:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/tests/testthat/test-branch_sorter.R#L14) *style:* **Commented code should be removed.**
```r
  # expect_equal(length(df$branch_length), 3)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:15:5:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/tests/testthat/test-branch_sorter.R#L15) *style:* **Commented code should be removed.**
```r
  # expected <- df(taxon_name = c("A", "B", "C"), branch_length = c(1,1,2))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:16:5:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/tests/testthat/test-branch_sorter.R#L16) *style:* **Commented code should be removed.**
```r
  # expect_equal(df, expected)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-collect_posterior_filenames.R:28:7:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/tests/testthat/test-collect_posterior_filenames.R#L28) *style:* **Commented code should be removed.**
```r
  #   find_path("toy_example_4_2_2_2.trees")
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-collect_posterior_filenames.R:30:5:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/tests/testthat/test-collect_posterior_filenames.R#L30) *style:* **Commented code should be removed.**
```r
  # expected <- sort(expected)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-collect_posterior_filenames.R:31:5:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/tests/testthat/test-collect_posterior_filenames.R#L31) *style:* **Commented code should be removed.**
```r
  # posterior_filenames <- sort(posterior_filenames)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-collect_posterior_filenames.R:32:5:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/tests/testthat/test-collect_posterior_filenames.R#L32) *style:* **Commented code should be removed.**
```r
  # expect_true(posterior_filenames == expected)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-normalized_rooted_branch_score.R:4:5:](https://github.com/richelbilderbeek/Cer2016/blob/4e60096aeba840fd55f7cacaed6481fc08b16058/tests/testthat/test-normalized_rooted_branch_score.R#L4) *style:* **Commented code should be removed.**
```r
#   expect_equal(normalized_rooted_branch_score(c(1), c(1)), 0)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


[R/branch_sorter.R:10:9:](https://github.com/richelbilderbeek/Cer2016/blob/02a14df4fa3b85e59026fd58a51b61b955307be8/R/branch_sorter.R#L10) *warning:* **no visible binding for global variable 'tree1', Did you mean 'trees'?**
```r
  cbind(tree1$edge, tree1$edge.length)
        ^~~~~
```
[R/branch_sorter.R:10:9:](https://github.com/richelbilderbeek/Cer2016/blob/02a14df4fa3b85e59026fd58a51b61b955307be8/R/branch_sorter.R#L10) *warning:* **no visible binding for global variable 'tree1', Did you mean 'trees'?**
```r
  cbind(tree1$edge, tree1$edge.length)
        ^~~~~
```
[R/test.R:3:4:](https://github.com/richelbilderbeek/Cer2016/blob/02a14df4fa3b85e59026fd58a51b61b955307be8/R/test.R#L3) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:7:4:](https://github.com/richelbilderbeek/Cer2016/blob/02a14df4fa3b85e59026fd58a51b61b955307be8/R/test.R#L7) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:8:10:](https://github.com/richelbilderbeek/Cer2016/blob/02a14df4fa3b85e59026fd58a51b61b955307be8/R/test.R#L8) *warning:* **Do not use absolute paths.**
```r
  setwd("d:/Peregrine/")
         ^~~~~~~~~~~~~
```
[R/test.R:9:31:](https://github.com/richelbilderbeek/Cer2016/blob/02a14df4fa3b85e59026fd58a51b61b955307be8/R/test.R#L9) *warning:* **Do not use absolute paths.**
```r
  testit::assert(file.exists("d:/Peregrine"))
                              ^~~~~~~~~~~~
```
[R/test.R:12:1:](https://github.com/richelbilderbeek/Cer2016/blob/02a14df4fa3b85e59026fd58a51b61b955307be8/R/test.R#L12) *style:* **lines should not be more than 80 characters.**
```r
  all_parameters <- Sys.glob("*.RDa") #alternative, but longer: all_parameters <- list.files(pattern = "\\.RDa$", ignore.case=TRUE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:15:13:](https://github.com/richelbilderbeek/Cer2016/blob/02a14df4fa3b85e59026fd58a51b61b955307be8/R/test.R#L15) *style:* **Use <-, not =, for assignment.**
```r
  filenames = "all_parameters"
            ^
```
[R/test.R:19:10:](https://github.com/richelbilderbeek/Cer2016/blob/02a14df4fa3b85e59026fd58a51b61b955307be8/R/test.R#L19) *warning:* **Do not use absolute paths.**
```r
  setwd("c:/Users/Aline/Cer2016")
         ^~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:21:4:](https://github.com/richelbilderbeek/Cer2016/blob/02a14df4fa3b85e59026fd58a51b61b955307be8/R/test.R#L21) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:22:22:](https://github.com/richelbilderbeek/Cer2016/blob/02a14df4fa3b85e59026fd58a51b61b955307be8/R/test.R#L22) *style:* **Commas should always have a space after.**
```r
  rng_seeds <- seq(1,4)
                     ^
```
[R/test.R:54:4:](https://github.com/richelbilderbeek/Cer2016/blob/02a14df4fa3b85e59026fd58a51b61b955307be8/R/test.R#L54) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


hmm maybe you can squash my several commits into one single commit when you merge my branch ? Just asking :) That would avoid so many of my useless commits .

https://github.com/blog/2141-squash-your-commits

maybe @cprudhom has not activated this option ?


Неправиьно делать проверку на тип файла, если он уже загружен на сервер. На сервер должны грузиться только те файлы, которые разршены для загрузки, но не в коем случае нельзя позволять загружать всё что вздумается юзеру, а потом брать на себя ответственность, что он не загрузил какой либо вирус


I would like to see which query is this generating.
Also if we could run an explain on the DB, to see how and which indexes it is using it.


can we add some statsd performance around this `fetch_dependency_from_db` call? I am concern this would be the bottle neck in terms of perf.


@fhnwba you need to sign Plone Contributor Agreement in order to merge this pull request.Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html


can i ask how did you extract it, by a comand or logcat? i did a logcat it's look like using mediatek ril configuration..i am in doubt


`ContainerExecStart` will log a `exec_start` event, so I guess we should log the create too.


@arthurnn I will look into this :+1:


Very nice seems to improve speed may play with  values see how fast


It's right.
And I test the blend mode, it's right too.


滋瓷


尝试


Just to check: you mean you want the name changed? I'll do that.


> Having modelChanded being sometimes a pyqtSignal and sometimes a baseSignal is likely to create confusion.

Indeed it *may* be confusing, but it *shouldn't*,  since duck-typing is essential to python ...

> In my opinion, this optimization is premature: it would only duplicate and complexify the code.

*premature* is the keyword that sets the balance for me. So I agree to remove them (they can be re-added if/when we need them later-on)


Right. That is a good catch.  Thanks!

On Wed, May 11, 2016 at 11:02 PM, Denis Rouzaud <notifications@github.com>
wrote:

> apparently, it's when I clicked a symbol in the legend entry. There is no
> more current layer selected in the legend, although the dock stays enabled.
> Whenever I change something, it probably looks for the active layer but
> there is no one.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
> <https://github.com/qgis/QGIS/commit/54e6eb341092ef59349ed8c7b2513a84d0100afc#commitcomment-17433469>
>


IIRC this fix is performance critical on several platforms. Is it ready for staging yet?


Так получается что у тебя будет не один а два фрагмента на активности) а не один


[Nope :p](https://github.com/Ealhad/kazoo/commit/992312efa3a1dbb6072bdfa07f843b4d35b87c87)


Haven't we all! :)


в имени изображения желательно хранить только имя, а не полный путь, потому что, если тебе вздумается перенести изображения в другую папку, то они уже не будут подгружаться


Why a constraint factory is being implemented? We agreed on implementing factories for the wolf API, not for inner stuff...


sauvegarde du code site mg
attention : index.html a sa propre feuille de style en raison des nombreux calques mais la feuille de style responsive est commune aux autres pages.


thank you vrey much!


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#Vetg0BWKSFuQV3pGriZkpg


нет закрытия тега div, по условию else


Yes, I'll remove it. I just saw the switch thing I commented and thought I could fix it with a factory, but no.
Just ignore it.


yeah but this lib will break if 0.9 is present instead of 1.0 so this would not really help.


add a flag at this version, try to rollback the csv document project to this version


scaffolding will usually create more stuff that what you really need


学习了！Thx


external demo file


Please remove this empty line.


Commented code in commits are usually not a good practice. If you do use it (why it is commented) you should remove it. git will keep the history in case you want to recover old logic or reimplement it. 🍰


Maybe it would be better to safe cast the value to Stream. In this case every type of stream would be acceptable.

var stream = value as Stream;
if( stream != null )
return new StreamContent(stream);


Mybad for authorship, sorry. I didnt took time to read correctly the PR.
Correct author is @robinsch. (well, afaik)


`fcsv` is terrible name, please change it for example to `csv_file`


ну если даже картинки у тебя находятся в этой же директории, где и исходной код php скрипта, то подгружаться они будет, но если их переместить, то логика ломается


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#R4j_7NdyR5uBLGQc_qby3A


How do you think about `<config verbose="yes"/>` or if it fits better `debug="yes"`? From how I understand your code it's just a matter of `if (verbose) {...}` in *printf.cc* and `verbose = config.xml().attribute_value("verbose",  false)` on component construction.


Hey @AsharS - can you explain why these needed to be global? Just curious...


大啊


Ok, esta abordagem funciona. Mas concorda que trabalhar com um array é mais simples? Basta fazer o ajuste do offset do índice.


If I understand correctly what is going on, I'm not sure I like this. Now if the analytic derivative fails, even for one point, you fall back on a numerical derivative automatically and unconditionally. Unless this is expected and desired behaviour I would say this should at least be user configurable.
This might also allow differentiateResiduals to be pure virtual, which is another thing I would like to see here.


Maybe I don't understand your question... "upsert" is documented as "Optional. If set to true, creates a new document when no document matches the query criteria. The default value is false, which does not insert a new document when no match is found.".

When explicitly not checking sync (in this particular case, because no previous modified_ts could be loaded), we believe it is OK to insert a new user (in the dashboard db) when none exist.


This is great... nice fix!


@umanganiello mastiqatzi


That shouldn't be necessary. Can you upload your debug log?


aa


I suggest using base/component.h directly as server.h will be deprecated with 16.05. Then you only need `Component::stack_size` and `Component::construct`.


The problem is we need to block when stopping the monitor, otherwise it might write a final result after we start a new monitor (unlikely though that is). Cancelling a context doesn't block.

I guess we could return both a channel and a `Once` here, but storing two fields when we only need one seems wasteful.


if this is a costly operation (like on that `Log.info` of the past commit), is there a way to extract it lazily?


LUOL


Copy as Override on TES4, that's the way I create a blank plugin when I need a new one :)

By the way, any info regarding CDX files somewhere ?


@skleiner Thanks for testing. I updated the hooks class to match the changes you mentioned.


Fixed. Thanks!


UN-522: Added LBL_New


Verzonden met Boxer

Op 11 mei 2016 15:24 schreef Maarten Fonville <notifications@github.com>:

That shouldn't be necessary. Can you upload your debug log?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

# Begin Open GApps Install Log
------------------------------------------------------------------
            ROM Android version | 6.0.1
                   ROM Build ID | MHC19Q release-keys
          ROM Version increment | a4ef2e3fec
                ROM SDK version | 23
        ROM/Recovery modversion | 13.0-ZNH2K-20160430-STABLE-Sultan-bacon
                Device Recovery | TWRP TugaPower-3.0.2-2
                    Device Name | A0001
                   Device Model | A0001
                    Device Type | phone
                     Device CPU | armeabi-v7a,armeabi
             Installer Platform | arm
                   ROM Platform | arm
           Display Density Used | 480
                   Install Type | Dirty[Data NOT Wiped]
             Smart ART Pre-ODEX | false
Google Camera already installed | false
          FaceUnlock Compatible | true
       Google Camera Compatible | true
      New Camera API Compatible | false[force_api]
       Google Dialer Compatible | false
          Current GApps Version | 20160503
     Current Open GApps Package | stock
          Google Camera version | Legacy
       Installing GApps Version | 20160511
          Installing GApps Type | stock
                    Config Type | exclude
             Using gapps-config | /sdcard/Open-GApps/gapps-config.txt
      Remove Stock/AOSP Browser | true[default]
       Remove Stock/AOSP Camera | false[NO_CameraGoogle]
        Remove Stock/AOSP Email | true[gapps-config]
      Remove Stock/AOSP Gallery | false[gapps-config]
     Remove Stock/AOSP Launcher | true[default]
      Remove Stock/AOSP MMS App | true[default]
     Remove Stock/AOSP Pico TTS | true[default]
         Ignore Google Contacts | false[ContactsGoogle]
           Ignore Google Dialer | false
         Ignore Google Keyboard | false[KeyboardGoogle]
Ignore Google Package Installer | false[PackageInstallerGoogle]
          Ignore Google NFC Tag | false[TagGoogle]
          Ignore Google WebView | false[WebViewGoogle]
         Total System Size (KB) | 1334432
         Used System Space (KB) | 1036652
        Current Free Space (KB) | 297780
   Post Install Free Space (KB) | 285544   << See Calculations Below
------------------------------------------------------------------
# End Open GApps Install Log

WARNING: Google Dialer has/will not be installed as requested. Dialer Framework
must be added to the GApps installation if you want to install the Google
Dialer.

WARNING: Dialer Framework has/will not be installed as requested. Dialer Framework
is NOT compatible with your device. You can override by adding
'ForceDialer' to your gapps-config.

# Begin GApps Size Calculations
------------------------------------------------------------------
  TYPE  |         DESCRIPTION        |      SIZE |   TOTAL
        |         Current Free Space |    297780 |  297780
 Remove |             Existing GApps | +  618848 |  916628
 Remove |             Obsolete Files | +      16 |  916644
 Remove |                    browser | +       0 |  916644
 Remove |            calculatorstock | +       0 |  916644
 Remove |              calendarstock | +       0 |  916644
 Remove |                 clockstock | +       0 |  916644
 Remove |                    cmmusic | +       0 |  916644
 Remove |              cmsetupwizard | +       0 |  916644
 Remove |              contactsstock | +       0 |  916644
 Remove |                      email | +       0 |  916644
 Remove |              exchangestock | +       0 |  916644
 Remove |              keyboardstock | +       0 |  916644
 Remove |                   launcher | +       0 |  916644
 Remove |                        mms | +       0 |  916644
 Remove |      packageinstallerstock | +       0 |  916644
 Remove |                    picotts | +       0 |  916644
 Remove |                   tagstock | +       0 |  916644
 Remove |               webviewstock | +       0 |  916644
Install |                       Core | -   91052 |  825592
Install |           calculatorgoogle | -     944 |  824648
Install |             calendargoogle | -   23108 |  801540
Install |                     chrome | -   57828 |  743712
Install |                clockgoogle | -    6944 |  736768
Install |                 cloudprint | -    3820 |  732948
Install |             contactsgoogle | -    7752 |  725196
Install |                      drive | -   19576 |  705620
Install |                       ears | -      92 |  705528
Install |             exchangegoogle | -    1784 |  703744
Install |                 facedetect | -     540 |  703204
Install |                 faceunlock | -   14012 |  689192
Install |                    fitness | -   19888 |  669304
Install |                  googlenow | -   14924 |  654380
Install |                 googleplus | -   26432 |  627948
Install |                  googletts | -   24800 |  603148
Install |                       keep | -   12204 |  590944
Install |             keyboardgoogle | -   22472 |  568472
Install |                       maps | -   35112 |  533360
Install |                  messenger | -   16872 |  516488
Install |                      music | -   19540 |  496948
Install |     packageinstallergoogle | -    2056 |  494892
Install |                     photos | -   21120 |  473772
Install |                  playgames | -   13900 |  459872
Install |                     search | -   39824 |  420048
Install |                     speech | -   56604 |  363444
Install |                  taggoogle | -     316 |  363128
Install |                   talkback | -    5796 |  357332
Install |              webviewgoogle | -   42208 |  315124
Install |                    youtube | -   20364 |  294760
        |               Buffer Space | -    9216 |  285544
------------------------------------------------------------------
                        Post Install Free Space |  285544
------------------------------------------------------------------

# End GApps Size Calculations

# Begin User's gapps-config
Docs
Slides
Sheets
NewsStand
NewsWidget
Gmail
Hangouts
Books
Movies
CameraGoogle
Email
CMMusic
CMSetupWizard
+Gallery
# End User's gapps-config


What if you are hostile towards the quarg?


It is costly inside, but it's already lazy and if it gets to the metadataExtractor it's cached (both the result or the fail).


Sorry, I replied inmail, with attachements... Hopefully you got them?


hey, fork fork


If pluginSpec equals to "~", installFrom will be equal to pluginSpec ("~") since semver.validRange("~", true) evals to false, and we'll get "Error: Registry returned 404 for GET on https://registry.npmjs.org/PROJECTNAME"


@Zarel


[R/branch_sorter.R:10:9:](https://github.com/richelbilderbeek/Cer2016/blob/9b1d16c6de1e049edaaa3fb9b4a510423169631a/R/branch_sorter.R#L10) *warning:* **no visible binding for global variable 'tree1', Did you mean 'trees'?**
```r
  cbind(tree1$edge, tree1$edge.length)
        ^~~~~
```
[R/branch_sorter.R:10:9:](https://github.com/richelbilderbeek/Cer2016/blob/9b1d16c6de1e049edaaa3fb9b4a510423169631a/R/branch_sorter.R#L10) *warning:* **no visible binding for global variable 'tree1', Did you mean 'trees'?**
```r
  cbind(tree1$edge, tree1$edge.length)
        ^~~~~
```


1.Жарко Кирилл Юрьевич.
2. androidDev


[R/branch_sorter.R:10:9:](https://github.com/richelbilderbeek/Cer2016/blob/d2334c4352d2381a8894f1825adf4546c5630efc/R/branch_sorter.R#L10) *warning:* **no visible binding for global variable 'tree1', Did you mean 'trees'?**
```r
  cbind(tree1$edge, tree1$edge.length)
        ^~~~~
```
[R/branch_sorter.R:10:9:](https://github.com/richelbilderbeek/Cer2016/blob/d2334c4352d2381a8894f1825adf4546c5630efc/R/branch_sorter.R#L10) *warning:* **no visible binding for global variable 'tree1', Did you mean 'trees'?**
```r
  cbind(tree1$edge, tree1$edge.length)
        ^~~~~
```


why not public?


для сборки приложения:
-  установить lightened activator [](https://www.lightbend.com/activator/download)
- выполнить команду `activator clean stage`
- перейти в папку target/universal/stage/bin/
- запустить flyserver


and why static?
As Controller is extended from Component - we can use DI to configure it per app instance


As I see, `$keys` is an array of strings. `implode` will be faster than `Json::encode`


This name isn't very intuitive to me. Maybe make it a bit more verbose?


this is console controller. and this we need only while creating index first time


Good bakery just where all the boat trailers are parked. It's a kind of a treasure hunt to find your place!


Mycket bra!!!


не стоит явно указывать 30, у массива есть свойство length, используйте его


site-specific code detected in core component


@umanganiello smarmelli?


Maybe you should choose a number instead of xyzz ;-)


If === would throw a warning when comparing different types, I think it would be safe to use it wherever possible. But it doesn't, so using === always means: We _imply_ that the data types are equal, and if we were in error about that (e.g. a function returns integer values with data type float for whatever reason, and we compare === 1), then we introduce a hard-to-detect bug.


yep. i keep it in mind. Actually we have no applicable controller in core for this purposes, so finally it will be just remowed


Defining var URL here in custom.js breaks Excel DOwnload Button in Dynamic Table. Excel download does not open and Console shows an error "d.createObjectURL is not a function". In datatables.net/forums someone describes this error and blames a globally defined URL variable. Changing this to _URL fixe the error.


how to run this project as a whole...i am working on vne based on periodic resource demands is this helpful for me ...please reply


D’accord, merci.

Pour l'instant, je suis en période d'examen donc pas vraiment de temps libre pour apprendre à fond. Mais en attendant, je lis le tutoriel https://openclassrooms.com/courses/developpez-votre-site-web-avec-le-framework-symfony et je test l'éditeur de texte https://atom.io/ qui propose des fonctionnalités très intéressante.

@SteeveDroz


This line is incorrect and will break Earth.


This is horribly temporary until we get proper theme configs.


It means whether to add line breaks before and/or after page breaks. Can't really think of a more intuitive name at the moment. In theory this option isn't needed because it can be incorporated in page-breaks by including new line characters.


worked perfectly on the problematic device.


@vladimir-kotikov
I suggest replacing it by :

var installFrom = pluginName;
if (pluginSpec && semver.validRange(pluginSpec, true)) {
    installFrom += '@' + pluginSpec;
}

But since no version has been specified, we'll be calling plugman.fetch on plugin "PLUGINNAME@~" resulting to "Error: No compatible version found: PLUGINNAME@'~'" which is a better error than the previous one.


> yeah but this lib will break if 0.9 is present instead of 1.0 so this would not really help.

Any chance to have BC conditions? If not, it should be pushed on a new major. But for this time, it's to late. ^^


hello world


why do you modify tbb sources here ?


If you could allow both and push it on a new patch version, it may help to solve issues like this one: https://github.com/phpDocumentor/Reflection/issues/95


lrz vm 24GB ram, 2 cores

../Isabelle2016/bin/isabelle build -v -D . -o threads=2

```
Timing Iptables_Semantics_Documentation (2 threads, 4.003s elapsed time, 5.076s cpu time, 0.104s GC time, factor 1.27)
Finished Iptables_Semantics_Documentation (0:00:48 elapsed time, 0:00:49 cpu time, factor 1.02)
Timing OpenFlow (2 threads, 175.607s elapsed time, 318.936s cpu time, 27.644s GC time, factor 1.82)
Finished OpenFlow (0:04:15 elapsed time, 0:06:37 cpu time, factor 1.55)
Timing Iptables_Semantics_Examples (2 threads, 1919.568s elapsed time, 3329.032s cpu time, 217.060s GC time, factor 1.73)
Finished Iptables_Semantics_Examples (0:32:07 elapsed time, 0:55:35 cpu time, factor 1.73)
Timing Iptables_Semantics_Examples_Large1 (2 threads, 6118.175s elapsed time, 11144.876s cpu time, 635.564s GC time, factor 1.82)
Finished Iptables_Semantics_Examples_Large1 (1:42:06 elapsed time, 3:05:52 cpu time, factor 1.82)
Timing Iptables_Semantics_Examples_Large2 (2 threads, 10378.073s elapsed time, 19039.816s cpu time, 1592.816s GC time, factor 1.83)
Finished Iptables_Semantics_Examples_Large2 (2:53:11 elapsed time, 5:17:26 cpu time, factor 1.83)
Timing OpenFlow_Documentation (2 threads, 3.816s elapsed time, 5.476s cpu time, 0.116s GC time, factor 1.44)
Finished OpenFlow_Documentation (0:00:23 elapsed time, 0:00:13 cpu time, factor 0.56)
Timing Routing (2 threads, 25.937s elapsed time, 46.216s cpu time, 1.752s GC time, factor 1.78)
Finished Routing (0:00:33 elapsed time, 0:00:52 cpu time, factor 1.57)
Finished at Mi 11. Mai 17:17:35 CEST 2016
5:36:02 elapsed time, 10:03:14 cpu time, factor 1.79
```


Oh sorry, I've fix this soon. Thanks!


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#Qh5_LrBGTPKUoM6jkaSIGQ


переменные с и photoID нигде не используются


Les "harvesters" remplissent désormais les structures dont l'energie n'est pas au max et plus seulement le "spawn".


Parse error near `ducomentation`.


@allen-ziegenfus thanks...


@friedbunny It's no longer rugged?  😞


@Gkramme it's been tried, and it looks bad.  and adds *tons* of processor load.


Ah, I see. Well, as long as it has documentation in the step declaration that should be fine. I think embossers can also set these margins. Would a left-edge padding make sense, e.g. by spaces?

From: Bert Frees [mailto:notifications@github.com]
Sent: Wednesday, May 11, 2016 15:37
To: daisy/pipeline-mod-braille <pipeline-mod-braille@noreply.github.com>
Cc: Davy Kager <mail@davykager.nl>; Comment <comment@noreply.github.com>
Subject: Re: [daisy/pipeline-mod-braille] Make use of FileFormat in pef:pef2text and pef:store (aee827f)

It means whether to add line breaks before and/or after page breaks. Can't really think of a more intuitive name at the moment. In theory this option isn't needed because it can be incorporated in page-breaks by including new line characters.

—
You are receiving this because you commented.
Reply to this email directly or  <https://github.com/daisy/pipeline-mod-braille/commit/aee827f23990214aede5946393279585fc845992#commitcomment-17433950> view it on GitHub  <https://github.com/notifications/beacon/AC9y8ZoxlCkhgt4hhXx-sTZ7-v59Hdjlks5qAduBgaJpZM4IcFO0.gif>


I already gave the patch. you could have pulled it instead :)

https://github.com/Engimusing/engimusing.github.io/pull/1


вы здесь переопределили присваивание сделанное на строке 46, потому по онлоад будет вызываться только ф-ция theSecond


There were some annoying warnings on Linux builds. Any alternative suggestions?


Ok, it looks like this merge actually caused some problems.  Need to fix how the global logger is iniatialized.

We can close #104 when this is fully fixed.


nope, no attachments. For in the future: make sure you really upload the *debug* log (.tar.gz) and not plain log file.

But I *do* already see what the problem is. You don't have the OnePlusOne with codename `bacon`. You have the `A0001` type, which is a different hardware revision.


well.. pub4game i know you have permission :p, just modify that part.


@sephirot47 :(


I meant "Revise command-line handling framework toward consistency and extension."


Ok, I see ;) Well, on my rom (don't know about others) the dialer also works (tried it before with forcedialer)


Yes, I rather not modify tbb at all except submitting upstream patches.
This repository doesn't even have to contain any tbb sources, continuous integration could go fetch the latest source archive.


This here is a sorta ugly hack. I didn't want to pull in new third-party libraries, so I manually replace the two parts of the HTML that are not valid XML and use the Python built-in XML parser.


Unfortunately these two other signals are not available with QWebEngine.


I didn't figure out how to edit the .ui files, so I edited the .py files manually.


LGTM


For addition of numbers in CLI. when we input strings it gives NaN output. So, instead of NaN output we made to show the message.


Nice.


`goto`로 처리하는 것보다는 것보다는 `throw`나 `assert`, `abort` 등을 사용하는 게 더 좋을 것 같아


여기도 마찬가지


여기도


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#Bo0zc9GxSLmgN6OtQ-5bpA


@dmitry-a-morozov is it possible to push an update on nuget?


this is not a valid CSS value


Thank you @noahmanger ! This was driving me 🍌 🍌


@ChrisLCoray Currently thinking about it. For now, you can set the `CI` environment variable to skip the tabtab install part.

Need to discuss further the idea with @SBoudrias @sindresorhus but I'm thinking of some sort of CLI flags or environment variable to specify a default answer.


Attempted quick fix for the auto save, not tested yet.


[R/branch_sorter.R:10:54:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/R/branch_sorter.R#L10) *style:* **Put spaces around all infix operators.**
```r
    edgeorder    <- data.table::data.table(table, key="V2")
                                                    ~^~
```
[R/branch_sorter.R:12:39:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/R/branch_sorter.R#L12) *warning:* **no visible binding for global variable 'V2', Did you mean '^'?**
```r
    edgeorder    <- subset(edgeorder, V2 < (length(filename$tip.label) + 1))
                                      ^~
```
[R/collect_posterior_filenames.R:10:8:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/R/collect_posterior_filenames.R#L10) *warning:* **no visible binding for global variable 'filename'**
```r
  base_filename <- tools::file_path_sans_ext(basename(filename))
       ^~~~~~~~
```
[R/collect_posterior_filenames.R:12:1:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/R/collect_posterior_filenames.R#L12) *style:* **lines should not be more than 80 characters.**
```r
  n_species_trees_samples <- as.numeric(file$parameters$n_species_trees_samples[2])
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:3:4:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/R/test.R#L3) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:7:4:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/R/test.R#L7) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:8:10:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/R/test.R#L8) *warning:* **Do not use absolute paths.**
```r
  setwd("d:/Peregrine/")
         ^~~~~~~~~~~~~
```
[R/test.R:9:31:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/R/test.R#L9) *warning:* **Do not use absolute paths.**
```r
  testit::assert(file.exists("d:/Peregrine"))
                              ^~~~~~~~~~~~
```
[R/test.R:12:1:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/R/test.R#L12) *style:* **lines should not be more than 80 characters.**
```r
  all_parameters <- Sys.glob("*.RDa") #alternative, but longer: all_parameters <- list.files(pattern = "\\.RDa$", ignore.case=TRUE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:15:13:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/R/test.R#L15) *style:* **Use <-, not =, for assignment.**
```r
  filenames = "all_parameters"
            ^
```
[R/test.R:19:10:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/R/test.R#L19) *warning:* **Do not use absolute paths.**
```r
  setwd("c:/Users/Aline/Cer2016")
         ^~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:21:4:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/R/test.R#L21) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:22:22:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/R/test.R#L22) *style:* **Commas should always have a space after.**
```r
  rng_seeds <- seq(1,4)
                     ^
```
[R/test.R:54:4:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/R/test.R#L54) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:8:5:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/tests/testthat/test-branch_sorter.R#L8) *style:* **Commented code should be removed.**
```r
  # expect_equal(count(names(df),"branch_length"), 1)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:9:4:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/tests/testthat/test-branch_sorter.R#L9) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"taxon_name"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:10:4:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/tests/testthat/test-branch_sorter.R#L10) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"brach_length"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:13:5:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/tests/testthat/test-branch_sorter.R#L13) *style:* **Commented code should be removed.**
```r
  # expect_equal(length(df$taxon_name), 3)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:14:5:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/tests/testthat/test-branch_sorter.R#L14) *style:* **Commented code should be removed.**
```r
  # expect_equal(length(df$branch_length), 3)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:15:5:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/tests/testthat/test-branch_sorter.R#L15) *style:* **Commented code should be removed.**
```r
  # expected <- df(taxon_name = c("A", "B", "C"), branch_length = c(1,1,2))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:16:5:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/tests/testthat/test-branch_sorter.R#L16) *style:* **Commented code should be removed.**
```r
  # expect_equal(df, expected)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-collect_posterior_filenames.R:17:4:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/tests/testthat/test-collect_posterior_filenames.R#L17) *style:* **Commented code should be removed.**
```r
  #parameter_filename2 <- read_file("toy_example_4.RDa")
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-collect_posterior_filenames.R:18:4:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/tests/testthat/test-collect_posterior_filenames.R#L18) *style:* **Commented code should be removed.**
```r
  #parameter_filename2 <- load("toy_example_4.RDa")
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-normalized_rooted_branch_score.R:4:5:](https://github.com/richelbilderbeek/Cer2016/blob/2edbe3fcbe6cd09f3a177fde53fc437c13804c95/tests/testthat/test-normalized_rooted_branch_score.R#L4) *style:* **Commented code should be removed.**
```r
#   expect_equal(normalized_rooted_branch_score(c(1), c(1)), 0)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


[R/branch_sorter.R:10:54:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/R/branch_sorter.R#L10) *style:* **Put spaces around all infix operators.**
```r
    edgeorder    <- data.table::data.table(table, key="V2")
                                                    ~^~
```
[R/branch_sorter.R:12:39:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/R/branch_sorter.R#L12) *warning:* **no visible binding for global variable 'V2', Did you mean '^'?**
```r
    edgeorder    <- subset(edgeorder, V2 < (length(filename$tip.label) + 1))
                                      ^~
```
[R/collect_posterior_filenames.R:10:8:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/R/collect_posterior_filenames.R#L10) *warning:* **no visible binding for global variable 'filename'**
```r
  base_filename <- tools::file_path_sans_ext(basename(filename))
       ^~~~~~~~
```
[R/collect_posterior_filenames.R:12:1:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/R/collect_posterior_filenames.R#L12) *style:* **lines should not be more than 80 characters.**
```r
  n_species_trees_samples <- as.numeric(file$parameters$n_species_trees_samples[2])
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:3:4:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/R/test.R#L3) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:7:4:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/R/test.R#L7) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:8:10:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/R/test.R#L8) *warning:* **Do not use absolute paths.**
```r
  setwd("d:/Peregrine/")
         ^~~~~~~~~~~~~
```
[R/test.R:9:31:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/R/test.R#L9) *warning:* **Do not use absolute paths.**
```r
  testit::assert(file.exists("d:/Peregrine"))
                              ^~~~~~~~~~~~
```
[R/test.R:12:1:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/R/test.R#L12) *style:* **lines should not be more than 80 characters.**
```r
  all_parameters <- Sys.glob("*.RDa") #alternative, but longer: all_parameters <- list.files(pattern = "\\.RDa$", ignore.case=TRUE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:15:13:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/R/test.R#L15) *style:* **Use <-, not =, for assignment.**
```r
  filenames = "all_parameters"
            ^
```
[R/test.R:19:10:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/R/test.R#L19) *warning:* **Do not use absolute paths.**
```r
  setwd("c:/Users/Aline/Cer2016")
         ^~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:21:4:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/R/test.R#L21) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:22:22:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/R/test.R#L22) *style:* **Commas should always have a space after.**
```r
  rng_seeds <- seq(1,4)
                     ^
```
[R/test.R:54:4:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/R/test.R#L54) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:8:5:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/tests/testthat/test-branch_sorter.R#L8) *style:* **Commented code should be removed.**
```r
  # expect_equal(count(names(df),"branch_length"), 1)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:9:4:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/tests/testthat/test-branch_sorter.R#L9) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"taxon_name"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:10:4:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/tests/testthat/test-branch_sorter.R#L10) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"brach_length"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:13:5:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/tests/testthat/test-branch_sorter.R#L13) *style:* **Commented code should be removed.**
```r
  # expect_equal(length(df$taxon_name), 3)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:14:5:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/tests/testthat/test-branch_sorter.R#L14) *style:* **Commented code should be removed.**
```r
  # expect_equal(length(df$branch_length), 3)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:15:5:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/tests/testthat/test-branch_sorter.R#L15) *style:* **Commented code should be removed.**
```r
  # expected <- df(taxon_name = c("A", "B", "C"), branch_length = c(1,1,2))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:16:5:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/tests/testthat/test-branch_sorter.R#L16) *style:* **Commented code should be removed.**
```r
  # expect_equal(df, expected)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-collect_posterior_filenames.R:17:4:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/tests/testthat/test-collect_posterior_filenames.R#L17) *style:* **Commented code should be removed.**
```r
  #parameter_filename2 <- read_file("toy_example_4.RDa")
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-collect_posterior_filenames.R:18:4:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/tests/testthat/test-collect_posterior_filenames.R#L18) *style:* **Commented code should be removed.**
```r
  #parameter_filename2 <- load("toy_example_4.RDa")
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-normalized_rooted_branch_score.R:4:5:](https://github.com/richelbilderbeek/Cer2016/blob/d66a7089498fe6ae3a179b7b6f345757774930b1/tests/testthat/test-normalized_rooted_branch_score.R#L4) *style:* **Commented code should be removed.**
```r
#   expect_equal(normalized_rooted_branch_score(c(1), c(1)), 0)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


Attempt quick fix for issue #1, has not been tested yet.


[R/branch_sorter.R:10:54:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/R/branch_sorter.R#L10) *style:* **Put spaces around all infix operators.**
```r
    edgeorder    <- data.table::data.table(table, key="V2")
                                                    ~^~
```
[R/branch_sorter.R:12:39:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/R/branch_sorter.R#L12) *warning:* **no visible binding for global variable 'V2', Did you mean '^'?**
```r
    edgeorder    <- subset(edgeorder, V2 < (length(filename$tip.label) + 1))
                                      ^~
```
[R/collect_posterior_filenames.R:26:1:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/R/collect_posterior_filenames.R#L26) *style:* **lines should not be more than 80 characters.**
```r
  n_species_trees_samples <- as.numeric(file$parameters$n_species_trees_samples[2])
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/collect_posterior_filenames.R:36:25:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/R/collect_posterior_filenames.R#L36) *style:* **Commas should always have a space after.**
```r
          base_filename,"_", i, "_", j, "_", k, ".trees", sep = ""
                        ^
```
[R/test.R:3:4:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/R/test.R#L3) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:7:4:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/R/test.R#L7) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:8:10:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/R/test.R#L8) *warning:* **Do not use absolute paths.**
```r
  setwd("d:/Peregrine/")
         ^~~~~~~~~~~~~
```
[R/test.R:9:31:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/R/test.R#L9) *warning:* **Do not use absolute paths.**
```r
  testit::assert(file.exists("d:/Peregrine"))
                              ^~~~~~~~~~~~
```
[R/test.R:12:1:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/R/test.R#L12) *style:* **lines should not be more than 80 characters.**
```r
  all_parameters <- Sys.glob("*.RDa") #alternative, but longer: all_parameters <- list.files(pattern = "\\.RDa$", ignore.case=TRUE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:15:13:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/R/test.R#L15) *style:* **Use <-, not =, for assignment.**
```r
  filenames = "all_parameters"
            ^
```
[R/test.R:19:10:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/R/test.R#L19) *warning:* **Do not use absolute paths.**
```r
  setwd("c:/Users/Aline/Cer2016")
         ^~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:21:4:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/R/test.R#L21) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:22:22:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/R/test.R#L22) *style:* **Commas should always have a space after.**
```r
  rng_seeds <- seq(1,4)
                     ^
```
[R/test.R:54:4:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/R/test.R#L54) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:8:5:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/tests/testthat/test-branch_sorter.R#L8) *style:* **Commented code should be removed.**
```r
  # expect_equal(count(names(df),"branch_length"), 1)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:9:4:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/tests/testthat/test-branch_sorter.R#L9) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"taxon_name"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:10:4:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/tests/testthat/test-branch_sorter.R#L10) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"brach_length"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:13:5:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/tests/testthat/test-branch_sorter.R#L13) *style:* **Commented code should be removed.**
```r
  # expect_equal(length(df$taxon_name), 3)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:14:5:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/tests/testthat/test-branch_sorter.R#L14) *style:* **Commented code should be removed.**
```r
  # expect_equal(length(df$branch_length), 3)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:15:5:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/tests/testthat/test-branch_sorter.R#L15) *style:* **Commented code should be removed.**
```r
  # expected <- df(taxon_name = c("A", "B", "C"), branch_length = c(1,1,2))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:16:5:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/tests/testthat/test-branch_sorter.R#L16) *style:* **Commented code should be removed.**
```r
  # expect_equal(df, expected)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-collect_posterior_filenames.R:28:7:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/tests/testthat/test-collect_posterior_filenames.R#L28) *style:* **Commented code should be removed.**
```r
  #   find_path("toy_example_4_2_2_2.trees")
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-collect_posterior_filenames.R:30:5:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/tests/testthat/test-collect_posterior_filenames.R#L30) *style:* **Commented code should be removed.**
```r
  # expected <- sort(expected)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-collect_posterior_filenames.R:31:5:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/tests/testthat/test-collect_posterior_filenames.R#L31) *style:* **Commented code should be removed.**
```r
  # posterior_filenames <- sort(posterior_filenames)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-collect_posterior_filenames.R:32:5:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/tests/testthat/test-collect_posterior_filenames.R#L32) *style:* **Commented code should be removed.**
```r
  # expect_true(posterior_filenames == expected)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-normalized_rooted_branch_score.R:4:5:](https://github.com/richelbilderbeek/Cer2016/blob/e4fb302e14194b14f85f78459f0eddaf7967a34f/tests/testthat/test-normalized_rooted_branch_score.R#L4) *style:* **Commented code should be removed.**
```r
#   expect_equal(normalized_rooted_branch_score(c(1), c(1)), 0)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


Normalement si on fait un `git pull` tant que la branche actuelle est à jour avec  celle du dépôt distant correspondante (tant que l'on a pas fait de modifications donc), il n'y a pas non plus de commit de fusion. Mais j'oublie toujours de le faire.


nice but wrong !


if possible, try to avoid using ids as CSS selectors, use styles instead


@robin-vandaele you are welcome to create a pull request similar to this one ;)


[R/branch_sorter.R:10:54:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/R/branch_sorter.R#L10) *style:* **Put spaces around all infix operators.**
```r
    edgeorder    <- data.table::data.table(table, key="V2")
                                                    ~^~
```
[R/branch_sorter.R:12:39:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/R/branch_sorter.R#L12) *warning:* **no visible binding for global variable 'V2', Did you mean '^'?**
```r
    edgeorder    <- subset(edgeorder, V2 < (length(filename$tip.label) + 1))
                                      ^~
```
[R/test.R:3:4:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/R/test.R#L3) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:7:4:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/R/test.R#L7) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:8:10:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/R/test.R#L8) *warning:* **Do not use absolute paths.**
```r
  setwd("d:/Peregrine/")
         ^~~~~~~~~~~~~
```
[R/test.R:9:31:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/R/test.R#L9) *warning:* **Do not use absolute paths.**
```r
  testit::assert(file.exists("d:/Peregrine"))
                              ^~~~~~~~~~~~
```
[R/test.R:12:1:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/R/test.R#L12) *style:* **lines should not be more than 80 characters.**
```r
  all_parameters <- Sys.glob("*.RDa") #alternative, but longer: all_parameters <- list.files(pattern = "\\.RDa$", ignore.case=TRUE)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:15:13:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/R/test.R#L15) *style:* **Use <-, not =, for assignment.**
```r
  filenames = "all_parameters"
            ^
```
[R/test.R:19:10:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/R/test.R#L19) *warning:* **Do not use absolute paths.**
```r
  setwd("c:/Users/Aline/Cer2016")
         ^~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:21:4:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/R/test.R#L21) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/test.R:22:22:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/R/test.R#L22) *style:* **Commas should always have a space after.**
```r
  rng_seeds <- seq(1,4)
                     ^
```
[R/test.R:54:4:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/R/test.R#L54) *style:* **Commented code should be removed.**
```r
  ## ------------------------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:8:5:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/tests/testthat/test-branch_sorter.R#L8) *style:* **Commented code should be removed.**
```r
  # expect_equal(count(names(df),"branch_length"), 1)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:9:4:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/tests/testthat/test-branch_sorter.R#L9) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"taxon_name"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:10:4:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/tests/testthat/test-branch_sorter.R#L10) *style:* **Commented code should be removed.**
```r
  #expect_equal(count(names(df),"brach_length"), 1)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:13:5:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/tests/testthat/test-branch_sorter.R#L13) *style:* **Commented code should be removed.**
```r
  # expect_equal(length(df$taxon_name), 3)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:14:5:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/tests/testthat/test-branch_sorter.R#L14) *style:* **Commented code should be removed.**
```r
  # expect_equal(length(df$branch_length), 3)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:15:5:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/tests/testthat/test-branch_sorter.R#L15) *style:* **Commented code should be removed.**
```r
  # expected <- df(taxon_name = c("A", "B", "C"), branch_length = c(1,1,2))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-branch_sorter.R:16:5:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/tests/testthat/test-branch_sorter.R#L16) *style:* **Commented code should be removed.**
```r
  # expect_equal(df, expected)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-normalized_rooted_branch_score.R:4:5:](https://github.com/richelbilderbeek/Cer2016/blob/f83d1617b1f21881d510c40d08b008d1f41f4ad9/tests/testthat/test-normalized_rooted_branch_score.R#L4) *style:* **Commented code should be removed.**
```r
#   expect_equal(normalized_rooted_branch_score(c(1), c(1)), 0)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


Instead of updating this everytime a new Google app adds a new permission, you should consider loading the requestedPermissions via PackageManager.

I just now found out about this issue and wrote the following code to create a script to grant GAPPs permissions they needed. The script did not resolve the problem. However, the code I wrote could be useful here. Please check it out and consider granting permissions to all package's that begin with com.google.*

Warning: I'm tired and this code shows it.

```java
/**
 * Finds all denied permission from GAPPS and creates a script to grant permissions.
 * <p/>
 * Sadly, granting permissions (even as root user) seems to not be working.
 * http://stackoverflow.com/a/32619933/1048340
 * <p/>
 * This could still be useful info since it looks like some ROMs are attempting to grant GAPPS permissions in
 * DefaultPermissionGrantPolicy.java
 * <p/>
 * https://github.com/TeamExodus/frameworks_base/commit/9c36be651e83fb039a262682839bd920b033007a
 * <p/>
 * Run this method in a worker thread.
 *
 * @param context
 *     application context
 */
static void attemptFixGappsProblem(Context context) {

  // We will be attempting to write a script to grant permissions to GAPPS.
  StringBuilder script = new StringBuilder("#!/system/bin/sh\n\n");

  PackageManager pm = context.getPackageManager();

  // get all installed apps with info about what permissions they requested.
  List<PackageInfo> packageInfos = pm.getInstalledPackages(PackageManager.GET_PERMISSIONS);

  // Get the hidden method PermissionInfo#protectionToString(int) so we can log info about the requested permission
  Method protectionToString;
  try {
    protectionToString = PermissionInfo.class.getDeclaredMethod("protectionToString", int.class);
    if (!protectionToString.isAccessible()) protectionToString.setAccessible(true);
  } catch (NoSuchMethodException e) {
    throw new RuntimeException(e);
  }

  // loop through all installed apps
  for (PackageInfo packageInfo : packageInfos) {

    String packageName = packageInfo.packageName;
    String appName = null;

    // we are only interested in Gapps or System packages
    if (!packageName.startsWith("com.google.") && !packageName.startsWith("com.android.")) {
      continue;
    }

    if (packageInfo.requestedPermissions == null) {
      // No permissions are requested in the AndroidManifest
      continue;
    }

    // loop through all requested permissions in the AndroidManifest
    for (String permission : packageInfo.requestedPermissions) {

      PermissionInfo permissionInfo;
      try {
        permissionInfo = pm.getPermissionInfo(permission, 0);
      } catch (PackageManager.NameNotFoundException e) {
        Log.i("PERMS", String.format("unknown permission '%s' found in '%s'", permission, packageName));
        continue;
      }

      // convert the protectionLevel to a string (not necessary, but useful info)
      String protLevel = null;
      try {
        protLevel = (String) protectionToString.invoke(null, permissionInfo.protectionLevel);
      } catch (Exception ignored) {
        protLevel = "????";
      }

      // Create the package's context to check if the package has the requested permission
      Context packageContext;
      try {
        packageContext = context.createPackageContext(packageName, 0);
      } catch (PackageManager.NameNotFoundException wtf) {
        continue;
      }

      int ret = packageContext.checkCallingPermission(permission);
      if (ret == PackageManager.PERMISSION_DENIED) {
        if (appName == null) {
          appName = packageInfo.applicationInfo.loadLabel(pm).toString();

          script.append("################################").append("\n");
          script.append("# ").append(appName).append(" [").append(packageName).append("]\n#\n");
        }

        // log info about the denied permission
        Log.i("PERMS", String.format("%s [%s] is denied permission %s (%s)",
            appName, packageName, permission, protLevel));

        script.append("pm grant ").append(packageName).append(" ").append(permission);
        script.append(" # ").append(protLevel).append("\n");
      } else {
        Log.i("PERMS", String.format("%s [%s] has granted permission %s (%s)",
            appName, packageName, permission, protLevel));
      }

    }

  }

  // We got all denied permissions to GAPPS, lets create our script.
  // It will be located in /data/data/[packagename]/files/grant_perms.sh
  File scriptFile = new File(context.getFilesDir(), "grant_perms.sh");
  Log.i("PERMS", "Creating script file...");
  try {
    FileWriter writer = new FileWriter(scriptFile);
    writer.write(script.toString());
    writer.close();
  } catch (IOException e) {
    Log.e("PERMS", "Error creating script file", e);
  }

}
```

Also, see http://stackoverflow.com/questions/37164716/is-it-possible-to-check-if-another-app-has-been-granted-a-permission-on-android


@fenollp yea for me it was not working lemme try again and paste log if a can find that error again. Thank you @lazedo @fenollp for your valuable time and sorry for wasting some of it :p just trying to make a contribution and improve :)


For now just one machine, but yes, it is ready.


aguardando uma interação do usuário


Hi. I noticed that char c is no longer used.
Is ctx.getCharacter(); needed to be invoked before handling the ctx ?


The following code returns false:
`getApplicationContext().getExternalFilesDir(null).mkdirs()`
therefore if `targetFile == getApplicationContext().getExternalFilesDir(null) + "/sample.mp4"` it will fail for no reason.
I would change it to:
`if ((targetFile.getParentFile().mkdirs()
                         && targetFile.createNewFile())
                         || targetFile.exists())`
that way even if `mkdirs()` or `createNewFile()` (because file exists but length == 0) fail, if the file exists we can safely proceed.


Yes, noticed that. It has been changed in the meantime (and merged).


One binary (acipca) don't requires a full libc, the other one (debug-acpica) requires the libc - just for printf and all the special specifiers. Genode::printf is not fit enough for this task and is deprecated anyway, therefore two binaries.


Os dois cálculos das linhas 138 e 139 apresentam dois problemas:

1. São complexos.
2. Tem operações repetidas.

Qualquer alteração na regra de cálculo (ex: deixar de exibir em kilos e exibir em quilates) daria um pouco de dor de cabeça, pois precisaríamos alterar e testar em dois pontos distintos o mesmo tipo de operação.


It's not meant for adding margins, but just to add a single line before and/or after the page break because some embossers expect that.

org.daisy.braille.pef.PEFHandler (which is used in PEF2TextStep) has functionality for adding margins (and also e.g. for aligning PEF pages within the available width of an embosser). So if you really need that we can support additional features named `horizontal-offset` and `vertical-offset` in PEF2TextStep.


Curious why you chose to implement this file in Java?


I'm guessing most of these could be `lateinit val`.


Problem is that 1.0 and 0.9 are not compatible. So supporting both isn't an option at all.

I would highly recommend you to upgrade. I'm not sure why you get an error like you have in #95. If this is because an external library that depends on 1.0.7 I will have a look. We might need to change our version number and remove release 1.1.0


Bigger beast than I'm willing to face for now. Reverted since it breaks integrationtests.


To make it clear we require `_utime_from_header` to be `True`. There is no ambiguity when we read this line about what we expect the variable to be to enter the block.

This might not the case here but this can help to avoid some bugs. If someone later changes the expected type of the variable for example, it is made explicit this line might require a change. Sometimes, it helps when debugging too.

We are fine to not write pythonic code when we think it is easier to read/understand or more explicit/stronger.


Chinese_Simplified
"IDC_STATIC_AUTO_START":"输入目录时的自动转换设置",

(中略)

"IDC_BUTTON_APP_SETTING":"应用设置",
"IDC_BUTTON_CLEAR_OUTPUT_DIR":"重设输出路径",
"IDC_STATIC_ARG_START":"带参数的启动设置",
"IDC_CHECK_ARG_START_AUTO":"启动时开始转换",
"IDC_CHECK_ARG_START_SUCCESS_FINISH":"成功后自动退出",
"IDC_STATIC_INPUT_DIR_FIX":"默认输入文件夹",
"IDC_STATIC_OUTPUT_DIR_FIX":"默认输出文件夹",
"IDC_CHECK_OUTPUT_NO_OVERWIRITE":"输出文件不覆盖",

(中略)

"MessageNoOverwrite":"此位置已经包含同名文件: %s",
"MessageCudaOldDeviceError":"CUDA 组件版本太旧.请使用 rnCompute Capability 2.0 以上版本.",
"OK":"确定",
"Cancel":"取消"


and we do appreciate your contributions.

On Wed, May 11, 2016 at 3:00 PM, Romana <notifications@github.com> wrote:

> @fenollp <https://github.com/fenollp> yea for me it was not working lemme
> try again and paste log if a can find that error again. Thank you @lazedo
> <https://github.com/lazedo> @fenollp <https://github.com/fenollp> for
> your valuable time and sorry for wasting some of it :p just trying to make
> a contribution and improve :)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> <https://github.com/2600hz/kazoo/commit/f9f400565cb7f2195c136cabb2898cc83923633c#commitcomment-17434351>
>


I just started to use it yesterday here - and now it is already too old :-D - yes, i will change it ;-)


Entendi a lógica mas pq vc está se preocupando com o 0 a frente dos primeiros números?


l don't know what worldedit.marker_region[self.player_name] contains.
If self.object is in this table then the problem may be caused by executing entity:remove()
because if an object got "remove"d, it disappears not immediately but after exiting from lua, so the tnt explosion loop punches all objects even if they're already "remove"d by entity:remove()


@Shyam-Chen Thank you, sorry i forgot the update in the protractor conf! :/


pequena duplicação, como podemos melhorar?


Need this a reextracting for the DBC and Maps ?


Could you publish a version for this new feature ?


В качестве внешних ключей не нужно использовать редактируемые пользователям поля.
Нужно сделать первичные ключи с типом int.


Are the dependencies on the debian package wrong? Why install a dev package, and why purge it right afterwards?


You register the Proc object as in instance variable so that it has a reference (is marked) and the GC don't collect it. Am I right?


Chinese_Simplified

`"IDC_STATIC_AUTO_START":"输入目录时的自动转换设置",`

(中略)

```
"IDC_BUTTON_APP_SETTING":"应用设置",
"IDC_BUTTON_CLEAR_OUTPUT_DIR":"重设输出路径",
"IDC_STATIC_ARG_START":"带参数的启动设置",
"IDC_CHECK_ARG_START_AUTO":"启动时开始转换",
"IDC_CHECK_ARG_START_SUCCESS_FINISH":"成功后自动退出",
"IDC_STATIC_INPUT_DIR_FIX":"默认输入文件夹",
"IDC_STATIC_OUTPUT_DIR_FIX":"默认输出文件夹",
"IDC_CHECK_OUTPUT_NO_OVERWIRITE":"输出文件不覆盖",
```

(中略)

```
"MessageNoOverwrite":"此位置已经包含同名文件: %s",
"MessageCudaOldDeviceError":"CUDA 组件版本太旧.请使用 rnCompute Capability 2.0 以上版本.",
"OK":"确定",
"Cancel":"取消"
```


Array -> array
にするとバグる


delete


Yeah, sounds good. Later today I'll go around and localise any of these chat messages


Lightning could only read from global remoteactions. Was resulting in a non visible method error while it was public.


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#AWAbB93OQFuVmnbX40O3pA


Fornecedor Testes


> http://jsfiddle.net/3Lzr26bg/4/ (Fix for chrome)

In Chrome console I get the error:
`(index):66 Uncaught TypeError: Cannot read property 'price' of undefined
`

That occurs because the root node doesn't have any data to pass to the function. So [fix](http://jsfiddle.net/adamjimenez/9Lzfwkg1/) would be to check if `node.data` exists:

```
'columns': [{
        'header': 'Nodes'
      }, {
        'header': 'Price',
        'value': function(node) {
        	if (node.data) {
          	return node.data.price;
          }
        },
        format: function(value) {
          return value && "$" + value;
        }
      }, {
        'header': 'Price in cents',
        'value': function(node) {
        	if (node.data) {
          	return node.data.price * 100;
          }
        },
        format: function(value) {
          return value && value + "¢";
        }
      }]
```


@aguynamedben basically "assume function exists" is a balance between "always do the correct thing" and "usually do the optimal thing"

for a long-running application that mostly touches the same data, the latter is usually better - assume the function has already been created and expect the occasional (harmless) message (error) when we are wrong.


Sorry for the late response:

To install it via [modman](https://github.com/colinmollenhour/modman/), you use ``modman clone https://github.com/quafzi/Inchoo_Adwords``. If you don't want to allow symlinks, you might use the ``--copy`` option to copy the files instead of symlinking them. In a dev environment I recommend you to just enable symlinks.


Нужно сделать таблицу лекарств.
Сделать таблицу связи лекарств и пациентов. В таблице связи указать дополнительно 2 даты: дата начала приема и дата конца приема.


I think so, it will add the folder /Cameras/ containing 14 files of type `*.M2` when extracting maps or vmaps.


Сделать как с лекарствами.


Deodexed the framework folder, extracted classes.dex from HwTelephony.jar, then converted the dex into .class files and finally extracted the source code from the .class file.
However inside the framework jar, there was also a Qualcomn RIL class. I have no idea what it was doing there.


⚠ ⚠ ⚠

as linhas 84 e 86 são quase idênticas, temos que cuidar com a duplicação.

Dica: colocar na condicional apenas o que muda entre pares e ímpares e após isto, executar o restante das instruções (append, attr, etc).

O que você acha? Como melhoraria isto?


Do: koneksi ke database dan membuat pesan/warning
To do: memperbaiki UI
Hambatan: memperbaiki UI dengan desain yang menarik


Избыточно. По прошлой записи в этой же таблице определить можно.


I've never pulled before, I will learn before the next change. :)

Thanks,
Joe

On Wed, May 11, 2016 at 7:45 AM, amitesh-singh <notifications@github.com>
wrote:

> I already gave the patch. you could have pulled it instead :)
>
> #1 <https://github.com/Engimusing/engimusing.github.io/pull/1>
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
> <https://github.com/Engimusing/engimusing.github.io/commit/bd6435d196313050ebc27e6b22e868b5d7d75957#commitcomment-17434075>
>


No, in that case `node` is not the root node (which does have data) but the number 0.


Yes. You're right.


While you are at it check for unlocalized items and blocks as well if you dont mind


手机端卡bug，可能连按多次就这样了。

特技:joy:


Вообще у медиков есть единый классификатор болезней. Наверно имеет смысл диагноз брать из справочника. Но нужно дополнительное поле в комментарием к диагнозу.


How were you using it?


So this is for youtube or vimeo videos? Which types do we currently support?


Ok. Just making sure I wasn't deleting anything that I shouldn't.


Do: memunculkan nama proker (sesuai tujuan yang dipilih) yang akan dihapus
To do: membuat koding untuk menghapus nama proker dan memperbaiki tampilan
Hambatan: membuat koding untuk menghapus nama proker


Note que parte das linhas 96, 97 e 100 são muito parecidas.

Como você melhoraria isto?

Dica: é possível criar uma função que receba o id do elemento pai e o valor do atributo `name` e faça a pesquisa.


原意是想在前端擋掉小數點的輸入，但光用 Range 好像沒有這個效果，還是有其他推薦方式嗎?


OK - thanks for reviewing and testing this, Aleksey.

1. Yes, we can make this assumption on a point-forward basis: we have just one database for each application, so we no longer need USE statements in our upgrade scripts.

2. Yes, we can move the backup functionality into a PowerShell script in the Octopus deployment project. This functionality is easier to modify and manage in PS.


That was actually @Mafii ... On SirNils' computer. :+1: _kek_


Ahhh good point


Hey @PeterBell
@mendelB and I went through the last TTT lab (non-OO, and non-AI) and we want to change it so 1. We use `position` to mean board index and `user_input` to mean the raw input from the user, and 2. DRY is up by adding a helper method `input_to_position` so that the user doesn't have to keep having `.to_i - 1` all over their code. I want to also go filter this change back through all the other labs. Just wanted to get some idea that, 'yes this is good' before working on other labs.
Let us know!


So you were passing cgo flags and you were using this to make a stable target? Can you not use ./vendor/<include|lib|share> ? Can you link me to the repo you were using this with ?