hab mir vorgenommen, sowas nie wieder zu sagen!! :D aber in dem Fall könnte es hinhauen...

Am 4. Mai 2016 16:15:02 MESZ, schrieb Andreas Neumann <notifications@github.com>:
>jo, ich schau mal, wieviel ich heut noch schaffe, denke aber das passt
>mit den flash messages, ist ja nicht so das riesige dinge
>
>
>Am 04/05/16 um 16:13 schrieb magdalena19:
>>
>> jow, dann deinen PR direkt hinterherziehen , oder? Kann ich auch
>> später machen. Dann haben wir schonmal n ganz schönen Schritt im
>> Master gemacht. Die Flash-Message-Sache kann ich auch übernehmen,
>wenn
>> du es nicht mehr schaffst bzw. können wir das auch nöchste Woche
>machen...
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly or view it on GitHub
>>
><https://github.com/magdalena19/lberg-map/commit/828070f7535d9890ff7fe969367156b901568bca#commitcomment-17353021>
>>
>
>
>
>---
>You are receiving this because you commented.
>Reply to this email directly or view it on GitHub:
>https://github.com/magdalena19/lberg-map/commit/828070f7535d9890ff7fe969367156b901568bca#commitcomment-17353057

--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.


I can't merge this commit in. Could you make a pull request so I can do so?


Yesterday I had an issue with the root font, but I have solved using your commit @ciju .
But just in case the versions on NPM and Bower are not updated with this commit.
Thanks


I believe the correct annotation is `@return $this` rather than `@return self`.

This is poorly documented, but `$this`, `self` and `static` in php-doc blocks should work consistenly with the use of the same keywords in the same context.

In other words, `self` refers to the class within which the method was defined, and in this case is always going to refer to `QueryBuilder`, which is probably not what you want.

This can be a problem if you `extend` the `QueryBuilder` class, as inherited (non-overridden) methods will still refer to `QueryBuilder` rather than to your derived class.

Contrast with `$this`, which refers to the type of the instance on which a method is being invoked.


谢谢 辛苦了


Since this method's body isn't key to understanding, could also write it as:

```
def parse(s: String): Option[Int] = Try { s.toInt }.toOption
```

Motivation: there's a lot of text in this post. Judicious cutting might help readability.


Sweet catch https://github.com/dimagi/Vellum/commit/9a4f27e08b9639549051af41f924b5fc89a17a26

Those were bad tests anyways. Should have only been 2, because #form shouldn't show the question you currently have selected


This is also used by [notes](https://github.com/moneyadviceservice/publify/blob/master/app/models/note.rb#L18) and [pages](https://github.com/moneyadviceservice/publify/blob/master/app/models/page.rb#L11) when [generating a short url](https://github.com/moneyadviceservice/publify/blob/master/app/models/content.rb#L78).
This hack breaks these [tests](https://github.com/moneyadviceservice/publify/blob/master/spec/models/note_spec.rb#L51) 💣


make it better


Obs: será necessária a refatoração usando métodos próprios do js (map, filter, reduce)


```
exc_info	You shouldn’t need to format this yourself.	Exception tuple (à la sys.exc_info)
or, if no exception has occurred, None.
```

This indicates that if no exception has ocurred, I get None for traceback data...?

If that is the case, this would defeat my purpose in line 120, where I want to provide a stacktrace even though an Exception was avoided by error checking.


This seems to be the latest revision that works on my computer.


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 90](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=934&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) is now running


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 90](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=934&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:16


@csdg78 separar arquivos  em pastas diferentes.
**js/dist** : arquivos minificados.
**js/src** : arquivos de código.


@{fd30bac4-c4e0-4d3b-873a-34690a56bd86,Ali} blabla


Is https://issues.scala-lang.org/browse/SI-9606 a relevant bug to link to?

I ask because it has a great pull quote:

> Once again we are left with the message that "Scalac occasionally does weird shit that only the high priests understand".


|`line 43-53`|
|---|
@{fd30bac4-c4e0-4d3b-873a-34690a56bd86,Ali} how does upstream determine the user??


@csdg78 separar arquivos  em pastas diferentes.
**css/dist** : arquivos minificados.
**css/src** : arquivos de código.


Thanks @dkayiwa.  Sorry, I wasn't clear--we will need to do a new release but is the release a blocker for the ref app 2.4 release?


I am sorry my english is not to good. i got srum monkey working on a windows 10 machine and i pulled out the srum-db from a windows 10 system and i ran into the following errors:

Converting Table MSysObjects as MSysObjects
Converting Table MSysObjectsShadow as MSysObjectsShadow
Converting Table MSysObjids as MSysObjids
Converting Table MSysLocales as MSysLocales
Converting Table SruDbIdMapTable as SruDbIdMapTable
Converting Table SruDbCheckpointTable as SruDbCheckpointTable
Converting Table {973F5D5C-1D90-4944-BE8E-24B94231A174} as NetworkUsageData
Converting Table {D10CA2FE-6FCF-4F6D-848E-B2E99266FA89} as ApplicationResourceUsageData
Converting Table {97C2CE28-A37B-4920-B1E9-8B76CD341EC5} as {97C2CE28-A37B-4920-B1E9-8B76CD341EC5}
Converting Table {FEE4E14F-02A9-4550-B5CE-5FA2DA202E37} as WindowsPushNotificationData
Converting Table {D10CA2FE-6FCF-4F6D-848E-B2E99266FA86} as EnergyUsageData
Converting Table {DD6636C4-8929-4683-974E-22C046A43763} as NetworkConnectivityData
Converting Table {FEE4E14F-02A9-4550-B5CE-5FA2DA202E37}LT as WindowsPushNotificationDataLT
Traceback (most recent call last):
  File "C:\Users\Student\Desktop\SrumMonkey-master\SrumMonkey.py", line 931, in <module>
    Main()
  File "C:\Users\Student\Desktop\SrumMonkey-master\SrumMonkey.py", line 130, in Main
    rhandler.EnumerateRegistryValues()
  File "C:\Users\Student\Desktop\SrumMonkey-master\SrumMonkey.py", line 381, in EnumerateRegistryValues
    self.INTERFACE_COLUMN_LISTING
  File "C:\Users\Student\Desktop\SrumMonkey-master\SrumMonkey.py", line 808, in CreateTableFromMapping
    field_mapping[field]
KeyError: u'Has Connected'

The Testfiles were perfectly working on my machine.


@csdg78 adicionar linha para identação.


@csdg78 padronizar identação.


@aaronjensen Yeah, that's what I did actually. Thanks for providing some insight on the root of the issue and planning a fix!


to clarify: Update data_exploration/README.md


@csdg78 nova linha.


There is a setting `VCS User Names` in the upsource profile.


curious; this takes a String[] ... when would you pass multiple in? Is there a fixed vocabulary for this?


@csdg78 remover linha.


@jiannis IIRC, since we never made use of any of the other content "types" I was generally working towards getting rid of anything like that with the longer term goal of just having one type of content, "articles", so I could eventually ditch the "type" business and leave us with a just an article model.

Seem to recall I left the back end functionality in place for those things but I'm pretty sure we never actually made use of any of them so I imagine you could just continue along my path of removing all the things and just get rid of the note and page functionality and with that the tests.


@csdg78 identação.


You didn't add any usage of these functions. Did you test it in program ?


I'll make them available package wide and initialize in each file implementation. But that's just a guess right now.


@mogoodrich i do not think we need to make a new release because this is the only commit after the 2.8 release of the module and there ref app 2.4 is not using platform 2.0


> The tricky bit is breaking a paragraph across two pages. I haven't found a way (yet!) to calculate the letter width and make a sensible decision on how many words will fit in the remaining space at the bottom of a page after the complete paragraphs are in place.

We can avoid this wall. There is always the vee-dublew `font-size` on the template CSS to adjust so that the content could scale correctly. I *feel* that design, visual formatting and handling edge cases should be left with the author.


Might be nice to use the splat signature ...

`setNotificationActions(String... notificationActions)`

also, maybe make plural since passing in multiple? Unless we only ever set 1, then could pass in String?


Nope, thank you!


also - can we make this package name "notifications" ?


@csdg78 corrigir identação. Remover linhas excessivas.


@mocchira
``Ubuntu-16.04`` needs this line but others are not necessary.


@Setnea 'ele' and 'ele_list' are unfortunate names of variables


不小心按到貼上或自動完成？


suplimentare, ai scris gresit


Cool, that's what I thought, just double-checking.


My Portfolio page concept. You can see the completed page [here](www.benjaminglock.de)


Well, perfect values, you're the best ;)


Why are you printing a stack trace for a non -exception?

On Wed, May 4, 2016, 10:25 AM Surest Texas <notifications@github.com> wrote:

> exc_info    You shouldn’t need to format this yourself.   Exception tuple (à la sys.exc_info)
> or, if no exception has occurred, None.
>
> This indicates that if no exception has ocurred, I get None for traceback
> data...?
>
> If that is the case, this would defeat my purpose in line 120, where I
> want to provide a stacktrace even though an Exception was avoided by error
> checking.
>
> —
> You are receiving this because you commented.
> Reply to this email directly or view it on GitHub
> <https://github.com/suresttexas00/minecraft-wrapper/commit/210ef24e54e7e284d6eeac36ddb9ef725d9fc62c#commitcomment-17353234>
>


Could we call this interface `InboxNotification` ? does "AEM" and/or "Details" in the name provide any meaningful value?


You seem to have forgotten to remove this method:
```java
public static boolean isUpdateEnabled() {
    return pluginUpdate;
}
```
in Settings.java


@wh33ler Could you confirm if it works again? https://github.com/3lvis/DATASource/releases/tag/5.8.0


Yes, I like that.


Love it!!


"Service" feels a bit ambiguous ... WDYT about "InboxNotificationsManager" ... ? or ... "InboxNotificationSender"


Heh.  Yes, that's very relevant.  Will find a place to add it.


I'm curious what browser/js engine you're using. What version is it?


ものすごく細かい話ですが、foreach 内で fopen, fwrite, fclose をすると、たとえば今回のように 3000行くらいのデータがあると 3000 回 ファイルのオープンとクローズを繰り返す事になるので、この fopen と fclose も foreach の外に出すとより効率の良いプログラムになります。

```php
$fp = fopen($fileName,"r");
$fileName2 = "insert.sql";
$fp2 = fopen($fileName2,"a");

while(($data = fgetcsv($fp,",")) !== FALSE)
{
  ...
  // foreach の中は fwrite のみ
  fwrite($fp2,$sql);
}
fclose($fp2);
fclose($fp);
```
かなりアドバンスドな内容ですが。


Is this just the "message" .. the "details" part is throwing me off. Details makes me think this is metadata ABOUT the message (what are the details about the message)


**UNKNOWN** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 446](http://ci.infinispan.org/viewLog.html?buildId=39223&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for f654d5386aaf32357dc868c10435474145e1dca7
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:18:28


docs-fix-equations-and-heading (michael-okeefe) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2223 of 2223 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@chafey: According to the standard, though (section A.4 in part 5; also see Table A.4-1 in part 5) if the basic offset table isn't included, there should still be an item tag with length 0. Otherwise, how can you know whether the first item is the offset table or an actual fragment?

That being said, it looks like readSequenceItem is also being used to read the end of sequence delimiter in readFragmentsUntil in readEncapsulatedPixelData.js. I'm not sure if that's how the method is meant to be used, as detecting the sequence delimiter is typically done by peeking the tag (see e.g. readSQElementUndefinedLengthExplicit in readSequenceElementExplicit). If readSequenceItem is supposed to be able to be used that way then yeah, we need to move the check out of readSequenceItem because otherwise it'll throw a bunch of false alarms every time it's used to find the end of sequence delimiter.

The intention of this fix was to be able to detect malformed sequences, i.e. ones that don't have an item tag, which caused the parser to get confused and not be able to issue a clear error message. See #34


A more comprehensive read-time state will be written up next once I've gone through the changed dpmrc properly.


The declaration of these deps are required otherwise jetty8 deps will be used


@csdg78 gostei da localização do javascript, parabéns.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.discussion/48/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/discussion/__init__.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/catalog.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/catalog.py:89:17: Q000 Remove bad quotes.
plone/app/discussion/comment.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/comment.py:53:14: E131 continuation line unaligned for hanging indent
plone/app/discussion/comment.py:53:14: Q000 Remove bad quotes.
plone/app/discussion/comment.py:54:14: Q000 Remove bad quotes.
plone/app/discussion/comment.py:55:14: Q000 Remove bad quotes.
plone/app/discussion/comment.py:56:14: Q000 Remove bad quotes.
plone/app/discussion/comment.py:61:14: E131 continuation line unaligned for hanging indent
plone/app/discussion/comment.py:61:14: Q000 Remove bad quotes.
plone/app/discussion/comment.py:62:14: Q000 Remove bad quotes.
plone/app/discussion/comment.py:63:14: Q000 Remove bad quotes.
plone/app/discussion/comment.py:64:14: Q000 Remove bad quotes.
plone/app/discussion/comment.py:65:14: Q000 Remove bad quotes.
plone/app/discussion/comment.py:66:14: Q000 Remove bad quotes.
plone/app/discussion/comment.py:68:28: Q000 Remove bad quotes.
plone/app/discussion/comment.py:207:5: E124 closing bracket does not match visual indentation
plone/app/discussion/comment.py:231:30: Q000 Remove bad quotes.
plone/app/discussion/comment.py:279:5: E129 visually indented line with same indent as next logical line
plone/app/discussion/comment.py:291:30: E127 continuation line over-indented for visual indent
plone/app/discussion/comment.py:349:9: E128 continuation line under-indented for visual indent
plone/app/discussion/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/conversation.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/conversation.py:67:27: Q000 Remove bad quotes.
plone/app/discussion/conversation.py:92:66: E502 the backslash is redundant between brackets
plone/app/discussion/conversation.py:176:16: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:185:12: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:191:12: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:291:8: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:416:13: E129 visually indented line with same indent as next logical line
plone/app/discussion/conversation.py:416:17: P002 found "hasattr", consider replacing it
plone/app/discussion/conversation.py:418:29: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/interfaces.py:126:17: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:152:65: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:157:46: E127 continuation line over-indented for visual indent
plone/app/discussion/interfaces.py:157:46: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:158:38: E127 continuation line over-indented for visual indent
plone/app/discussion/interfaces.py:219:17: E128 continuation line under-indented for visual indent
plone/app/discussion/interfaces.py:220:26: E127 continuation line over-indented for visual indent
plone/app/discussion/interfaces.py:220:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:221:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:222:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:229:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:231:17: E128 continuation line under-indented for visual indent
plone/app/discussion/interfaces.py:232:26: E127 continuation line over-indented for visual indent
plone/app/discussion/interfaces.py:232:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:233:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:234:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:241:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:243:17: E128 continuation line under-indented for visual indent
plone/app/discussion/interfaces.py:244:26: E127 continuation line over-indented for visual indent
plone/app/discussion/interfaces.py:244:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:247:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:248:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:249:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:256:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:258:17: E128 continuation line under-indented for visual indent
plone/app/discussion/interfaces.py:259:26: E127 continuation line over-indented for visual indent
plone/app/discussion/interfaces.py:259:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:262:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:263:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:264:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:272:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:274:17: E128 continuation line under-indented for visual indent
plone/app/discussion/interfaces.py:275:26: E127 continuation line over-indented for visual indent
plone/app/discussion/interfaces.py:275:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:276:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:277:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:278:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:279:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:289:17: E128 continuation line under-indented for visual indent
plone/app/discussion/interfaces.py:290:26: E127 continuation line over-indented for visual indent
plone/app/discussion/interfaces.py:290:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:299:17: E128 continuation line under-indented for visual indent
plone/app/discussion/interfaces.py:300:26: E127 continuation line over-indented for visual indent
plone/app/discussion/interfaces.py:300:26: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:309:19: E127 continuation line over-indented for visual indent
plone/app/discussion/interfaces.py:318:9: E128 continuation line under-indented for visual indent
plone/app/discussion/interfaces.py:321:32: E127 continuation line over-indented for visual indent
plone/app/discussion/interfaces.py:321:32: Q000 Remove bad quotes.
plone/app/discussion/patches.py:0:1: C101 Coding magic comment not found
plone/app/discussion/patches.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/patches.py:23:5: E129 visually indented line with same indent as next logical line
plone/app/discussion/testing.py:0:1: C101 Coding magic comment not found
plone/app/discussion/testing.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/testing.py:12:5: F401 'plone' imported but unused
plone/app/discussion/testing.py:13:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:14:1: B901 blind except: statement
plone/app/discussion/testing.py:15:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:66:14: Q000 Remove bad quotes.
plone/app/discussion/testing.py:78:10: Q000 Remove bad quotes.
plone/app/discussion/testing.py:81:10: Q000 Remove bad quotes.
plone/app/discussion/tool.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tool.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/upgrades.py:0:1: C101 Coding magic comment not found
plone/app/discussion/upgrades.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/vocabularies.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/vocabularies.py:16:5: F401 'plone' imported but unused
plone/app/discussion/vocabularies.py:30:5: F401 'collective' imported but unused
plone/app/discussion/tests/test_catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_catalog.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_catalog.py:77:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:96:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:101:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:109:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_catalog.py:121:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:126:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:130:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_catalog.py:138:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:142:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_catalog.py:149:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:167:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:173:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:183:27: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_catalog.py:184:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:194:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:203:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:234:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:237:30: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_catalog.py:250:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:253:30: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_catalog.py:255:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:283:30: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_catalog.py:292:40: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:305:35: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_catalog.py:306:35: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_catalog.py:319:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:325:30: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:332:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_catalog.py:339:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:339:49: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:345:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_catalog.py:358:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_catalog.py:359:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_catalog.py:418:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:459:30: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_catalog.py:460:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:472:22: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_comment.py:38:27: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:39:27: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:53:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:54:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:55:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:101:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:103:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:109:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:113:27: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:114:27: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:123:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:124:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:136:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:136:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:142:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:142:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:148:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:152:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:154:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comment.py:154:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:158:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:161:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:162:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:181:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:185:28: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comment.py:187:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comment.py:195:27: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:196:27: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:203:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:208:23: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:229:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:231:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:233:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:238:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:239:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:262:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:285:27: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:286:27: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comment.py:302:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:338:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:373:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:381:42: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:389:42: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:397:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:400:28: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comment.py:402:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comment.py:404:28: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comment.py:406:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comment.py:408:28: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comment.py:410:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comment.py:412:28: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comment.py:413:28: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comment.py:415:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comment.py:416:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comments_viewlet.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_comments_viewlet.py:60:36: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comments_viewlet.py:61:37: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comments_viewlet.py:101:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:113:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:149:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:182:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:216:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:300:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:301:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:306:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:311:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:312:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:313:14: E131 continuation line unaligned for hanging indent
plone/app/discussion/tests/test_comments_viewlet.py:313:14: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:323:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:324:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:325:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:365:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comments_viewlet.py:367:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comments_viewlet.py:367:63: S001 found %s formatter
plone/app/discussion/tests/test_comments_viewlet.py:368:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comments_viewlet.py:377:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comments_viewlet.py:408:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_comments_viewlet.py:412:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comments_viewlet.py:444:19: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_comments_viewlet.py:463:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_controlpanel.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_controlpanel.py:35:37: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:41:56: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:43:29: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_controlpanel.py:57:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_controlpanel.py:78:41: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_controlpanel.py:79:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_controlpanel.py:85:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_controlpanel.py:92:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_controlpanel.py:94:5: E265 block comment should start with '# '
plone/app/discussion/tests/test_controlpanel.py:121:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_controlpanel.py:130:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_controlpanel.py:135:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_conversation.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_conversation.py:66:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_conversation.py:72:22: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_conversation.py:157:13: E124 closing bracket does not match visual indentation
plone/app/discussion/tests/test_conversation.py:200:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_conversation.py:213:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_conversation.py:223:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_conversation.py:230:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_conversation.py:238:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_conversation.py:471:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_conversation.py:513:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:518:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:523:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:528:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:585:22: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_conversation.py:587:22: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_conversation.py:595:22: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_conversation.py:597:22: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_conversation.py:605:22: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_conversation.py:607:22: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_conversation.py:677:13: E124 closing bracket does not match visual indentation
plone/app/discussion/tests/test_conversation.py:692:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_conversation.py:694:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_conversation.py:715:22: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_conversation.py:826:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:830:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:835:38: S001 found %s formatter
plone/app/discussion/tests/test_functional.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_functional.py:18:24: E502 the backslash is redundant between brackets
plone/app/discussion/tests/test_functional.py:19:36: E502 the backslash is redundant between brackets
plone/app/discussion/tests/test_indexers.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_indexers.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_indexers.py:44:19: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_indexers.py:45:19: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_indexers.py:52:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:53:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:60:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:61:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:68:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:69:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:78:33: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_indexers.py:88:33: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_indexers.py:90:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_indexers.py:93:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_indexers.py:100:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_indexers.py:102:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_indexers.py:115:27: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_indexers.py:116:27: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_indexers.py:127:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:141:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_indexers.py:154:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_indexers.py:154:49: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:154:55: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:159:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_indexers.py:161:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_indexers.py:163:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_indexers.py:168:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_indexers.py:170:33: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_migration.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_migration.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_migration.py:48:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_migration.py:51:46: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_migration.py:90:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_migration.py:92:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_migration.py:133:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_migration.py:183:9: E122 continuation line missing indentation or outdented
plone/app/discussion/tests/test_migration.py:192:9: E124 closing bracket does not match visual indentation
plone/app/discussion/tests/test_migration.py:243:22: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_moderation_view.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_moderation_view.py:110:61: E502 the backslash is redundant between brackets
plone/app/discussion/tests/test_moderation_view.py:111:54: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:117:61: E502 the backslash is redundant between brackets
plone/app/discussion/tests/test_moderation_view.py:118:54: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:124:61: E502 the backslash is redundant between brackets
plone/app/discussion/tests/test_moderation_view.py:125:54: S001 found %s formatter
plone/app/discussion/tests/test_notifications.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_notifications.py:37:42: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:64:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:86:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:87:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:96:19: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_notifications.py:100:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:128:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:144:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:149:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:174:42: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:184:17: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_notifications.py:222:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:223:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:229:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:233:13: S001 found % formatter
plone/app/discussion/tests/test_tool.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_tool.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_tool.py:40:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_tool.py:40:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_tool.py:41:13: E128 continuation line under-indented for visual indent
plone/app/discussion/tests/test_tool.py:41:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_tool.py:41:15: S001 found %s formatter
plone/app/discussion/tests/test_workflow.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_workflow.py:51:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_workflow.py:55:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_workflow.py:86:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_workflow.py:124:60: E502 the backslash is redundant between brackets
plone/app/discussion/tests/test_workflow.py:125:54: S001 found %s formatter
plone/app/discussion/tests/test_workflow.py:144:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_workflow.py:145:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_workflow.py:194:38: S001 found %s formatter
plone/app/discussion/tests/test_workflow.py:232:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_workflow.py:236:67: E502 the backslash is redundant between brackets
plone/app/discussion/tests/test_workflow.py:237:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_workflow.py:243:65: E502 the backslash is redundant between brackets
plone/app/discussion/tests/test_workflow.py:244:27: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_workflow.py:248:65: E502 the backslash is redundant between brackets
plone/app/discussion/tests/test_workflow.py:249:27: E127 continuation line over-indented for visual indent
plone/app/discussion/browser/captcha.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/captcha.py:64:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/comment.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/comment.py:37:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:37:20: S001 found %s formatter
plone/app/discussion/browser/comment.py:39:41: S001 found %s formatter
plone/app/discussion/browser/comments.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/comments.py:49:14: E131 continuation line unaligned for hanging indent
plone/app/discussion/browser/comments.py:49:14: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:54:14: E131 continuation line unaligned for hanging indent
plone/app/discussion/browser/comments.py:54:14: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:55:14: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:60:14: E131 continuation line unaligned for hanging indent
plone/app/discussion/browser/comments.py:60:14: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:61:14: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:94:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:123:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:124:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:125:42: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:127:1: C901 'CommentForm.handleComment' is too complex (15)
plone/app/discussion/browser/comments.py:134:13: E125 continuation line with same indent as next logical line
plone/app/discussion/browser/comments.py:135:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:136:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:148:9: E122 continuation line missing indentation or outdented
plone/app/discussion/browser/comments.py:149:9: E122 continuation line missing indentation or outdented
plone/app/discussion/browser/comments.py:150:16: E713 test for membership should be 'not in'
plone/app/discussion/browser/comments.py:209:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:210:17: E128 continuation line under-indented for visual indent
plone/app/discussion/browser/comments.py:210:17: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:211:17: E128 continuation line under-indented for visual indent
plone/app/discussion/browser/comments.py:236:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:237:22: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:258:73: E502 the backslash is redundant between brackets
plone/app/discussion/browser/comments.py:259:16: E129 visually indented line with same indent as next logical line
plone/app/discussion/browser/comments.py:299:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:302:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:310:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:318:37: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:358:32: E127 continuation line over-indented for visual indent
plone/app/discussion/browser/comments.py:384:20: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:384:21: S001 found %s formatter
plone/app/discussion/browser/comments.py:396:20: E127 continuation line over-indented for visual indent
plone/app/discussion/browser/comments.py:417:17: S001 found %s formatter
plone/app/discussion/browser/controlpanel.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/controlpanel.py:33:10: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:37:30: E127 continuation line over-indented for visual indent
plone/app/discussion/browser/controlpanel.py:37:30: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:38:30: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:39:30: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:40:30: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:41:30: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:42:30: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:43:30: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:44:30: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:79:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:80:48: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:85:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:86:40: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:86:41: S001 found %s formatter
plone/app/discussion/browser/controlpanel.py:102:46: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:108:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:112:9: E122 continuation line missing indentation or outdented
plone/app/discussion/browser/controlpanel.py:113:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:115:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:119:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:125:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:152:46: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:155:9: E122 continuation line missing indentation or outdented
plone/app/discussion/browser/controlpanel.py:179:35: E712 comparison to True should be 'if cond is True:' or 'if cond:'
plone/app/discussion/browser/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/conversation.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/conversation.py:20:1: C901 'ConversationView.enabled' is too complex (14)
plone/app/discussion/browser/conversation.py:56:13: E129 visually indented line with same indent as next logical line
plone/app/discussion/browser/conversation.py:65:5: E129 visually indented line with same indent as next logical line
plone/app/discussion/browser/migration.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/migration.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/migration.py:37:1: C901 'View.__call__' is too complex (27)
plone/app/discussion/browser/migration.py:44:19: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:48:16: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:79:26: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:81:31: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:82:22: S001 found %s formatter
plone/app/discussion/browser/migration.py:163:25: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:163:26: S001 found %s formatter
plone/app/discussion/browser/migration.py:173:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:173:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:180:74: E502 the backslash is redundant between brackets
plone/app/discussion/browser/migration.py:181:42: E131 continuation line unaligned for hanging indent
plone/app/discussion/browser/migration.py:183:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:183:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:184:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:184:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:185:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:185:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:187:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:188:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:206:21: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:207:31: S001 found %s formatter
plone/app/discussion/browser/migration.py:214:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:217:18: E127 continuation line over-indented for visual indent
plone/app/discussion/browser/migration.py:217:18: S001 found % formatter
plone/app/discussion/browser/migration.py:220:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:222:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:223:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:224:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:226:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:227:13: S001 found % formatter
plone/app/discussion/browser/migration.py:230:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:230:18: S001 found %s formatter
plone/app/discussion/browser/migration.py:231:39: E502 the backslash is redundant between brackets
plone/app/discussion/browser/migration.py:232:17: E128 continuation line under-indented for visual indent
plone/app/discussion/browser/migration.py:233:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:234:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:238:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:239:17: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/moderation.py:99:15: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:100:18: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:139:15: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:140:18: Q000 Remove bad quotes.
plone/app/discussion/browser/traversal.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/traversal.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/traversal.py:32:20: Q000 Remove bad quotes.
plone/app/discussion/browser/validator.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/validator.py:35:5: F811 redefinition of unused 'WrongCaptchaCode' from line 30
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


TeamCity DNN JavaScript Libraries :: CI [Build 164](http://teamcity.engagesoftware.com/viewLog.html?buildId=448&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 164](http://teamcity.engagesoftware.com/viewLog.html?buildId=448&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:9


fyi @bmag this seems to have activated (I won't say caused...) a regression https://github.com/syl20bnr/spacemacs/issues/5978


ghfhfg


Myoldmopar-patch-1 (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2185 of 2185 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


> My preference is to use single quotes unless you need interpolation.

I don't have a strong preference. There is [no difference in performance][2]. The [style guide doesn't specify][1] a quoting character, it just suggests consistency. I think double quotes are more visible, that's the only reason I can come up with.  If you want to switch to single quotes, I'm fine with that. We can use rubocop's `--autocorrect` to make the switch.

[1]: https://github.com/bbatsov/ruby-style-guide#consistent-string-literals
[2]: http://stackoverflow.com/questions/1836467/is-there-a-performance-gain-in-using-single-quotes-vs-double-quotes-in-ruby/1836838#1836838


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.discussion/49/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/discussion/__init__.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/catalog.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/catalog.py:89:17: Q000 Remove bad quotes.
plone/app/discussion/comment.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/comment.py:77:28: Q000 Remove bad quotes.
plone/app/discussion/comment.py:170:40: Q000 Remove bad quotes.
plone/app/discussion/comment.py:172:30: S001 found %s formatter
plone/app/discussion/comment.py:176:48: S001 found %s formatter
plone/app/discussion/comment.py:209:14: D001 found declareProtected replace it with AccessControl.ClassSecurityInfo.protected
plone/app/discussion/comment.py:245:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:254:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:263:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:272:1: E302 expected 2 blank lines, found 1
plone/app/discussion/comment.py:298:21: Q000 Remove bad quotes.
plone/app/discussion/contentrules.py:0:1: C101 Coding magic comment not found
plone/app/discussion/contentrules.py:18:5: E731 do not assign a lambda expression, use a def
plone/app/discussion/contentrules.py:26:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:48:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:59:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:70:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:81:1: E302 expected 2 blank lines, found 1
plone/app/discussion/contentrules.py:92:1: E302 expected 2 blank lines, found 1
plone/app/discussion/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/conversation.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/conversation.py:67:27: Q000 Remove bad quotes.
plone/app/discussion/conversation.py:205:16: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:214:12: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:220:12: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:324:8: E713 test for membership should be 'not in'
plone/app/discussion/conversation.py:453:29: Q000 Remove bad quotes.
plone/app/discussion/events.py:0:1: C101 Coding magic comment not found
plone/app/discussion/events.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/events.py:11:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:33:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:38:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:43:1: E302 expected 2 blank lines, found 1
plone/app/discussion/events.py:48:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/interfaces.py:135:17: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:161:65: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:247:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:262:21: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:280:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:284:23: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:291:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:308:25: Q000 Remove bad quotes.
plone/app/discussion/interfaces.py:390:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:394:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:398:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:402:1: E302 expected 2 blank lines, found 1
plone/app/discussion/interfaces.py:406:1: E302 expected 2 blank lines, found 1
plone/app/discussion/patches.py:0:1: C101 Coding magic comment not found
plone/app/discussion/patches.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/testing.py:0:1: C101 Coding magic comment not found
plone/app/discussion/testing.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/testing.py:13:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:14:1: B901 blind except: statement
plone/app/discussion/testing.py:15:23: Q000 Remove bad quotes.
plone/app/discussion/testing.py:66:14: Q000 Remove bad quotes.
plone/app/discussion/testing.py:78:10: Q000 Remove bad quotes.
plone/app/discussion/testing.py:81:10: Q000 Remove bad quotes.
plone/app/discussion/tool.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tool.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/upgrades.py:0:1: C101 Coding magic comment not found
plone/app/discussion/upgrades.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/vocabularies.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_catalog.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_catalog.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_catalog.py:89:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:107:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:114:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:135:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:142:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:158:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:173:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:191:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:199:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:212:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:224:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:235:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:243:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:250:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:280:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:299:38: S001 found %s formatter
plone/app/discussion/tests/test_catalog.py:307:47: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:347:40: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:380:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:386:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:429:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:436:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:450:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:450:49: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:533:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_catalog.py:578:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_comment.py:55:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:56:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:57:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:106:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:108:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:114:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:130:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:131:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:135:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:136:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:158:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:166:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:179:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:182:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:187:25: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:231:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:262:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:267:23: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:304:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comment.py:329:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:371:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:407:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:442:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:450:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:459:38: S001 found %s formatter
plone/app/discussion/tests/test_comment.py:468:38: S001 found %s formatter
plone/app/discussion/tests/test_comments_viewlet.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_comments_viewlet.py:43:1: F811 redefinition of unused 'IConversation' from line 38
plone/app/discussion/tests/test_comments_viewlet.py:112:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:126:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:134:43: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:135:60: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:137:66: W291 trailing whitespace
plone/app/discussion/tests/test_comments_viewlet.py:180:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:194:59: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:196:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_comments_viewlet.py:236:65: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:281:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:316:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:405:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:406:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:411:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:416:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:417:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:418:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:429:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:430:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:431:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_comments_viewlet.py:487:63: S001 found %s formatter
plone/app/discussion/tests/test_contentrules.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_contentrules.py:6:1: F401 'notify' imported but unused
plone/app/discussion/tests/test_contentrules.py:22:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_contentrules.py:51:24: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:52:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:53:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:54:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:59:5: E303 too many blank lines (2)
plone/app/discussion/tests/test_contentrules.py:117:38: S001 found %s formatter
plone/app/discussion/tests/test_contentrules.py:121:38: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:122:34: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:123:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_contentrules.py:126:9: F841 local variable 'new_re_id' is assigned to but never used
plone/app/discussion/tests/test_contentrules.py:135:35: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_contentrules.py:145:44: E127 continuation line over-indented for visual indent
plone/app/discussion/tests/test_controlpanel.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_controlpanel.py:36:18: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:43:56: Q000 Remove bad quotes.
plone/app/discussion/tests/test_controlpanel.py:92:5: F811 redefinition of unused 'test_edit_comment_enabled' from line 84
plone/app/discussion/tests/test_controlpanel.py:145:5: E265 block comment should start with '# '
plone/app/discussion/tests/test_conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_conversation.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_conversation.py:31:1: B901 blind except: statement
plone/app/discussion/tests/test_conversation.py:91:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:93:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:94:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:95:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:96:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:96:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:97:14: D001 found assertEquals replace it with assertEqual
plone/app/discussion/tests/test_conversation.py:518:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_conversation.py:560:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:565:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:570:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:575:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_conversation.py:969:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:973:38: S001 found %s formatter
plone/app/discussion/tests/test_conversation.py:978:38: S001 found %s formatter
plone/app/discussion/tests/test_events.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_events.py:15:1: E302 expected 2 blank lines, found 0
plone/app/discussion/tests/test_events.py:26:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:29:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:32:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:35:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:40:1: E302 expected 2 blank lines, found 0
plone/app/discussion/tests/test_events.py:81:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:99:1: E302 expected 2 blank lines, found 1
plone/app/discussion/tests/test_events.py:138:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_events.py:151:38: S001 found %s formatter
plone/app/discussion/tests/test_events.py:157:9: F841 local variable 'new_re_id' is assigned to but never used
plone/app/discussion/tests/test_events.py:171:38: S001 found %s formatter
plone/app/discussion/tests/test_functional.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_indexers.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_indexers.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_indexers.py:54:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:55:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:62:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:63:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:70:28: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:71:36: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:110:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_indexers.py:112:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_indexers.py:139:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:140:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:170:35: Q000 Remove bad quotes.
plone/app/discussion/tests/test_indexers.py:170:41: Q000 Remove bad quotes.
plone/app/discussion/tests/test_migration.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_migration.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_migration.py:55:26: Q000 Remove bad quotes.
plone/app/discussion/tests/test_migration.py:68:14: Q000 Remove bad quotes.
plone/app/discussion/tests/test_migration.py:214:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_moderation_view.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_moderation_view.py:111:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:119:38: S001 found %s formatter
plone/app/discussion/tests/test_moderation_view.py:127:38: S001 found %s formatter
plone/app/discussion/tests/test_notifications.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_notifications.py:37:42: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:64:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:86:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:87:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:102:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:130:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:146:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:151:32: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:176:42: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:227:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_notifications.py:228:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:234:13: S001 found % formatter
plone/app/discussion/tests/test_notifications.py:238:13: S001 found % formatter
plone/app/discussion/tests/test_tool.py:0:1: C101 Coding magic comment not found
plone/app/discussion/tests/test_tool.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_tool.py:32:31: Q000 Remove bad quotes.
plone/app/discussion/tests/test_tool.py:42:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_tool.py:43:13: Q000 Remove bad quotes.
plone/app/discussion/tests/test_tool.py:43:15: S001 found %s formatter
plone/app/discussion/tests/test_workflow.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/tests/test_workflow.py:58:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_workflow.py:94:27: Q000 Remove bad quotes.
plone/app/discussion/tests/test_workflow.py:133:38: S001 found %s formatter
plone/app/discussion/tests/test_workflow.py:153:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_workflow.py:154:9: E265 block comment should start with '# '
plone/app/discussion/tests/test_workflow.py:203:38: S001 found %s formatter
plone/app/discussion/browser/captcha.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/captcha.py:64:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/comment.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/comment.py:45:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:45:20: S001 found %s formatter
plone/app/discussion/browser/comment.py:47:41: S001 found %s formatter
plone/app/discussion/browser/comment.py:53:10: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:92:52: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:95:40: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:95:58: Q000 Remove bad quotes.
plone/app/discussion/browser/comment.py:108:1: E265 block comment should start with '# '
plone/app/discussion/browser/comments.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/comments.py:94:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:100:35: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:128:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:129:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:130:42: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:132:1: C901 'CommentForm.handleComment' is too complex (15)
plone/app/discussion/browser/comments.py:141:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:142:32: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:157:16: E713 test for membership should be 'not in'
plone/app/discussion/browser/comments.py:210:53: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:251:19: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:252:22: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:275:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:276:13: W503 line break before binary operator
plone/app/discussion/browser/comments.py:325:39: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:328:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:336:41: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:344:37: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:415:20: Q000 Remove bad quotes.
plone/app/discussion/browser/comments.py:415:21: S001 found %s formatter
plone/app/discussion/browser/comments.py:462:17: S001 found %s formatter
plone/app/discussion/browser/controlpanel.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/controlpanel.py:34:10: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:90:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:91:48: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:96:55: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:97:40: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:97:41: S001 found %s formatter
plone/app/discussion/browser/controlpanel.py:113:46: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:119:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:126:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:128:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:131:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:135:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:141:27: Q000 Remove bad quotes.
plone/app/discussion/browser/controlpanel.py:168:46: Q000 Remove bad quotes.
plone/app/discussion/browser/conversation.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/conversation.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/conversation.py:20:1: B901 blind except: statement
plone/app/discussion/browser/conversation.py:32:1: C901 'ConversationView._enabled_for_archetypes' is too complex (14)
plone/app/discussion/browser/conversation.py:138:12: P002 found "hasattr", consider replacing it
plone/app/discussion/browser/conversation.py:138:29: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/migration.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/migration.py:37:1: C901 'View.__call__' is too complex (32)
plone/app/discussion/browser/migration.py:44:19: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:48:16: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:80:26: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:82:31: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:83:22: S001 found %s formatter
plone/app/discussion/browser/migration.py:181:25: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:181:26: S001 found %s formatter
plone/app/discussion/browser/migration.py:191:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:191:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:205:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:205:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:206:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:206:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:207:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:207:20: S001 found %s formatter
plone/app/discussion/browser/migration.py:209:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:210:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:228:21: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:229:31: S001 found %s formatter
plone/app/discussion/browser/migration.py:237:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:238:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:239:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:239:28: S001 found %s formatter
plone/app/discussion/browser/migration.py:246:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:248:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:249:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:250:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:252:13: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:253:13: S001 found % formatter
plone/app/discussion/browser/migration.py:257:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:257:18: S001 found %s formatter
plone/app/discussion/browser/migration.py:261:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:262:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:266:17: Q000 Remove bad quotes.
plone/app/discussion/browser/migration.py:267:17: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/moderation.py:100:15: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:101:18: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:139:15: Q000 Remove bad quotes.
plone/app/discussion/browser/moderation.py:140:18: Q000 Remove bad quotes.
plone/app/discussion/browser/traversal.py:0:1: C101 Coding magic comment not found
plone/app/discussion/browser/traversal.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/browser/traversal.py:32:20: Q000 Remove bad quotes.
plone/app/discussion/browser/validator.py:0:1: I001 isort found changes, run it on the file
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Does this need to be a principal in AEM? Or can you put any string value here you want?


ty


Great improvements! @juandazapata .


@bradrydzewski looks like you should really start to write changelogs :)


@svetlyak40wt and you should exclude the `vendor` folder as it totally messed up the versioning.


This module cannot be upgraded after this commit. Please fix this as soon as possible.
@pedrobaeza.


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.discussion/50/violations
```
plone/app/discussion/contentrules.py:20:5: E731 do not assign a lambda expression, use a def
plone/app/discussion/browser/comments.py:132:1: C901 'CommentForm.handleComment' is too complex (17)
plone/app/discussion/browser/conversation.py:29:1: C901 'ConversationView._enabled_for_archetypes' is too complex (14)
plone/app/discussion/browser/conversation.py:135:12: P002 found "hasattr", consider replacing it
plone/app/discussion/browser/migration.py:34:1: C901 'View.__call__' is too complex (32)
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


bladiebla


I think that it will be better not to send error but just add the backslash at the end of path


делаю)


Isn’t this going to print the mark-up with the HTML escaped, i.e. `<input …>` rather than `<input …>` ?


Makes sense, although I'm not sure what the error itself would be. Perhaps just return a message.


@Setnea  '//' should be passed as default argument of this function


It seems to break SVG:
`viewBox="0 0 ${size} ${size}”`doesn't work anymore, I have to do `view-box="0 0 ${size} ${size}”`now.
`stroke-width.bind=“strokeWidth”`stays `stroke-width.bind=“strokeWidth”`in the rendered web page and is not computed.


For length: I'm looking for things to cut, but am having trouble.  Would it help to break up the introductory section with headings to make the overall thread clearer?


ARP 패킷을 sending하는 데까지 해 봐라. 지금 코드로는 부족함.


I only left the comment because i got errors while compiling, about improper way of calling the function property_get(), found its definition and left a suggestion for what might be the proper way.

Also, I thought err should be declared before the if(....) statement because I got another error "undefined var err" in the line: ALOGE_IF(....). This way it still exists after the if().


docs-fix-equations-and-heading (michael-okeefe) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


TeamCity DNN JavaScript Libraries :: CI [Build 165](http://teamcity.engagesoftware.com/viewLog.html?buildId=450&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 165](http://teamcity.engagesoftware.com/viewLog.html?buildId=450&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 0:0:10


offset は 10 ですね。
offset は読み飛ばす数と覚えておくと良いかと思います。
つまり 10 件飛ばして、11件目から取得したいので以下のようになります。
```sql
select * from tokyo where address2 = '新宿区' order by code asc limit 10 offset 10;
```
確認の時は小さい数を順番に試すと分かりやすいと思います。
limit 1 offset 0
limit 1 offset 1
など。


I'm still actively working on that plugin, so expect it to change/break itself/fix itself over the next few days.


It's a change different from master.


This commit itself is not a problem (Travis and runbot are correct). Please check your installation.


No.


@ptitle I hope it is ok I pushed directly to master. It was a very silly little typo, which won't change any behaviour ( `length(class(x) == 1)` will always evaluate to `TRUE`, so it hinges on whether `x` is of class `"bammdata"`).

Question: is there any place where being _only_ of class `"bammdata"` matters? I am trying to figure out why the length of the class vector is checked here.


TeamCity DNN JavaScript Libraries :: CI [Build 166](http://teamcity.engagesoftware.com/viewLog.html?buildId=451&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 166](http://teamcity.engagesoftware.com/viewLog.html?buildId=451&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **FAILURE**
Summary: Exit code 1 Build time: 0:0:10


**SUCCESS** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 447](http://ci.infinispan.org/viewLog.html?buildId=39327&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for f654d5386aaf32357dc868c10435474145e1dca7
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:15:34


canot spell exexute


嗯,这么改确实比较简洁一些,那我也尝试用这种方式去改 shapps 里的那些auth了


This has also been fixed in #1523 by changing the type of the properties from `IReadOnlyList` to `List`


How about `questionnaire__submit` or `button--submit` ;)


TeamCity DNN JavaScript Libraries :: CI [Build 167](http://teamcity.engagesoftware.com/viewLog.html?buildId=453&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


It's better to make all changes in the database in the same transaction:
```
dataStore.Update(ctx =>
{
    ctx.Put(userData);
    ctx.Put(workspace);
});
```


TeamCity DNN JavaScript Libraries :: CI [Build 167](http://teamcity.engagesoftware.com/viewLog.html?buildId=453&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:11


You are right - my mistake.  I will add this back in and change readFragmentsUntil() so it doesn't break


⚠ ⚠ ⚠

Apenas verificar `hasOwnProperty` não basta. Preste atenção:

```JavaScript
var mu = { peso: undefined };
mu.hasOwnProperty('peso'); // jabulani
```


Follow up commit e2c275a9f36136d420efcacf72ab2917877f58b6 solves this issue.


Thanks @raix can you please bump the version number so it picks it up... I think this is stopping my proj from picking up this change.


I suppose this question generalizes to: are the specified input types (always) mandatory? If so, should we generally check upon initialization of an AnalysisEngine whether (at least one of) the specified input annotations exist, and throw a ResourceInitializationException if there is not at least one?


This text.txt does not add much