Hmm, on my installation, there is no 5x00 or 443 (`GITLAB_REGISTRY_PORT`) listening ports in `gitlab` container:

```bash
root@b13823c2c0fc:/home/git/gitlab# cat VERSION
8.8.5

root@b13823c2c0fc:/home/git/gitlab# ss -ltn
State      Recv-Q Send-Q        Local Address:Port          Peer Address:Port
LISTEN     0      128               127.0.0.1:8080                     *:*
LISTEN     0      128                       *:80                       *:*
LISTEN     0      128                       *:22                       *:*
LISTEN     0      128                      :::80                      :::*
LISTEN     0      128                      :::22                      :::*
```

Here are the environment variables relevant to Docker Registry passed to my `gitlab` container:

```
GITLAB_REGISTRY_ENABLED: 'true'
GITLAB_REGISTRY_API_URL: http://docker-registry:5000/
GITLAB_REGISTRY_HOST: dockerhub.XXXXXXXX.com
GITLAB_REGISTRY_PORT: '443'
GITLAB_REGISTRY_KEY_PATH: /certs/registry-auth.key
SSL_REGISTRY_KEY_PATH: /certs/registry.key
SSL_REGISTRY_CERT_PATH: /certs/registry.crt
```

Am I missing something?


Shouldn't this be EstatioDomainModule?


Did this break the behavior of using `SENTRY_LOG_LEVEL` with standalone scripts?


@umayavuz Looks like transit was two steps ahead of us. LOL


5711-HVAC-sizing-sim-crash (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1660 of 1660 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.97%25-green.svg)


Could you make `cat /etc/nginx/sites-enabled/gitlab-registry` ?


Shouldn’t this replace the logic in the current `active/1` and `active/2` functions as well?


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#PxeXIwAuSNqub1LYNm2Pyg


74715752-Constant-Flow-Radiant-Heating-Not-Turning-On-Bug (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


74715752-Constant-Flow-Radiant-Heating-Not-Turning-On-Bug (RKStrand) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Excellent! A good way to learn git and markdown at the same time would be to play with the README file.


74715752-Constant-Flow-Radiant-Heating-Not-Turning-On-Bug (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Tests Failed (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


I haven't looked at mdaiter's CPU code but I wrote the GPU code. On a 970M I get 1.2 microseconds per descriptor and 3 billion comparisons per second on the brute-force symmetric matcher. These numbers are assuming you saturate the GPU (easily possible with even one image pair) and exclude transfer overhead (which isnt a major factor regardless).

If I recall there is something in mdaiter's adaptation of the CPU code that causes some unexpected overhead (due to unnecessary allocing & freeing, I think) that increases the time per descriptor by an order of magnitude. 4 seconds for ~15,360 descriptors from each of 11 images is what I saw. I expect this number to come down significantly.

His matching code took just under 30 seconds for all pairs comparison of 11 images (so 55 pairs) with the same ~15,360 descriptors per image (with cross-check).

I have designed but not yet implemented a GPU implementation of the multiple index hashing algorithm for fast exact k-NN search in Hamming space... I can't estimate its relative speed for the matcher, but I do expect it to scale much better.


74715752-Constant-Flow-Radiant-Heating-Not-Turning-On-Bug (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Tests Failed (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


On passe e nvalidate apres la creation des tables.


74715752-Constant-Flow-Radiant-Heating-Not-Turning-On-Bug (RKStrand) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I don't know why it would. It's the same as before, i just removed the default value of `INFO`.


proxy-target-class="true" si on veut pouvoir utiliser directement les classes implementees au lieu des interfaces dans HomePageController et EmployeServiceImpl.


In error handling: `you are not a player` in gameplay messages if you are not playing in this game; `you are not subscribed` if you are neither active player nor spectator.


Oh, then I guess you're falling back to what's set in `LOGGING` in settings?


vb


I see, you changed up this logic a bit. I assume that's the point of this `default_level` now.


Then the situation is getting tricky here. The diagnosis id is passed down from caller of this function, and we have no way to know which new diagnosis to emit.


Yes.  Postgresql doesn't support adding the case-insensitive constraint using lower.  You have to use an index instead.


orverride:


1/ Whats is this shit, with adding klmlmp2rotp when klmlmp2rot is already
parallel? Shoo, shoo. Get rid of that.
2/ Any domain that contains the pole needs to be treated, it's a problem
with finding integration domains in the kernel construction. Either compute
a kernel at the equator, rotate the kernel, and compute the eigenfuctions.
Or, compute a kernel at the equator, compute the eigenfunctions, rotate the
eigenfunctions. Both of these approaches work explicitly in the codes, and
they produce results that have been tested to be numerically similar. Not
identical, and kernel rotation introduces precision differences, as
rotation upon rotation coumpounds roundoff errors.

2016-06-23 12:18 GMT-04:00 Chris Harig <notifications@github.com>:

> klmlmp2rot is already a parallel function. The date suggests Frederik
> changed it 7/11/2012.
>
> Also, I have a question about this rotation in general. Which computation
> cannot be done at the pole? Is it the kernel computation or the eigenvector
> decomposition? I thought it was the latter/both, so I compute
> eigenfunctions at the equator and then rotate them.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/csdms-contrib/slepian_alpha/commit/b7751f40a56b8ab5a229764d3acdfd2dbf48fd0c#commitcomment-17990503>,
> or mute the thread
> <https://github.com/notifications/unsubscribe/AGfGqDf4jj11zfXIAn3W1CmXN4I5Mwggks5qOrHXgaJpZM4I8_Hx>
> .
>

--
Frederik J Simons
www.frederik.net


There is no such file. There is only `gitlab` nginx config.

Here is a part of `config/gitlab.rb`:

```bash
root@b13823c2c0fc:/home/git/gitlab# grep ' registry:' -A 6 config/gitlab.yml
  registry:
    enabled: true    # Enables GitLab Container Registry Defaults to `true`
    host: dockerhub.XXXXXXXXX.com          # registry.example.com
    port:           # 5005
    api_url: http://docker-registry:5000/    # http://localhost:5000/ # internal address to the registry, will be used by GitLab to directly communicate with API
    key: /certs/registry-auth.key       # config/registry.key
    path: /home/git/data/shared/registry
```


you monster!


it'd be great if you could expand on this and say how it's different and why you should use this over that.  otherwise it's kinda a useless comment.


That comment was supposed to say "per @gideonaa #265, change all gather-profile to get-profile for consistency"


Yas.


Thanks for keeping this upto date !!


I suspect this broke something...


it's also used if the user calls setUseCache(false).


because AWAITING_ACCEPT is detected as not correct in the new RateRequestDeskTest


Actually I partially withdraw the complaint. The new method swapped in by refine will have SUPER set up on it, so the original code can be called from inside it and should work as expected. The only problem is access to that code by looking at the model is long and ugly.


Will we need a dialog here? :unamused:


Fixed in PR https://github.com/iNavFlight/inav/pull/308


First ever commit to Master


*deep=deep
(I was too fast)


I don't follow. The refined in method's SUPER should call the parent
class's implementation for the method. That is the intention.  Is that not
so in this commit?

On Thu, 23 Jun 2016, 14:59 Jackson Stone, <notifications@github.com> wrote:

> Actually I partially withdraw the complaint. The new method swapped in by
> refine will have SUPER set up on it, so the original code can be called
> from inside it and should work as expected. The only problem is access to
> that code by looking at the model is long and ugly.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/jacksonic/vjlofvhjfgm/commit/6d3ae0a08abb7a36cda7389d142e38249c24d6f6#commitcomment-17993091>,
> or mute the thread
> <https://github.com/notifications/unsubscribe/AHJP_Su84B5blbgIy69qPP0hpYdx0eSnks5qOtekgaJpZM4I9DyL>
> .
>


*deep=derp
(Sorry about the first comment)


Why the new lines?


Test


@scottleibrand thanks a lot!


This change causes problem with text-align center in personal project, for example.


@guypod FYI this broke all our Docker builds as 'git' is usually not installed as a dependency.


maybe `2015-<span id="copyright-year">2016</span>`


@nmerket HES orientations are different than HPXML orientations (they have an underscore, e.g. `south_west`). For `solar_electric['array_azimuth']` you need to use the same method as for `bldg_about['orientation']`. Yes, we probably should have called the former `array_orrientation`! 😉


Depends on the semantics of *active*.
Do we mean with that that the module is activated (i.e. enabled but might not be running)
Or do we mean that is module is activated *and* running.

Maybe an option is to add `is_running/1` and `is_running/2` ?


No; interface-wise, we should write a highlighted (e.g.) message into the message box and later produce an error sound. We have a `StyledDocument` that allows formatting; for now, simply print it into the box. You might want to add a new function `addError` to `Frame`. For now, it should simply call `addChat`, but in the future, it might print in red bold font.


ASIHPdev3 (shenb) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2262 of 2266 tests passed, 554 test warnings)

 * 558 tests had: AUD diffs.
 * 4 tests had: EIO diffs.
 * 4 tests had: ESO big diffs.
 * 1 test had: MTR small diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: Table big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


It seems like it might make more sense to just use SpecialPathManager directly here, since the core is basically just:

```
    SpecialPathInfo info = spm.getSpecialPahtInfo(...);
    if ( info != null && info.isMetadata())
    {
        ....
    }
```


Yes, the commit is fine as is. Any added convenience feature to get the
original implementation can be done separately, and doesn't have to be part
of the refinement process.

On Thu, Jun 23, 2016 at 3:03 PM adamvy <notifications@github.com> wrote:

> I don't follow. The refined in method's SUPER should call the parent
> class's implementation for the method. That is the intention. Is that not
> so in this commit?
>
> On Thu, 23 Jun 2016, 14:59 Jackson Stone, <notifications@github.com>
> wrote:
>
> > Actually I partially withdraw the complaint. The new method swapped in by
> > refine will have SUPER set up on it, so the original code can be called
> > from inside it and should work as expected. The only problem is access to
> > that code by looking at the model is long and ugly.
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <
> https://github.com/jacksonic/vjlofvhjfgm/commit/6d3ae0a08abb7a36cda7389d142e38249c24d6f6#commitcomment-17993091
> >,
> > or mute the thread
> > <
> https://github.com/notifications/unsubscribe/AHJP_Su84B5blbgIy69qPP0hpYdx0eSnks5qOtekgaJpZM4I9DyL
> >
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/jacksonic/vjlofvhjfgm/commit/6d3ae0a08abb7a36cda7389d142e38249c24d6f6#commitcomment-17993145>,
> or mute the thread
> <https://github.com/notifications/unsubscribe/AIKjMGc-0IOZlbQbSR9Qspk-y3rjHTgJks5qOth-gaJpZM4I9DyL>
> .
>


Ah OK

On Thu, 23 Jun 2016, 15:07 Jackson Stone, <notifications@github.com> wrote:

> Yes, the commit is fine as is. Any added convenience feature to get the
> original implementation can be done separately, and doesn't have to be part
> of the refinement process.
>
> On Thu, Jun 23, 2016 at 3:03 PM adamvy <notifications@github.com> wrote:
>
> > I don't follow. The refined in method's SUPER should call the parent
> > class's implementation for the method. That is the intention. Is that not
> > so in this commit?
> >
> > On Thu, 23 Jun 2016, 14:59 Jackson Stone, <notifications@github.com>
> > wrote:
> >
> > > Actually I partially withdraw the complaint. The new method swapped in
> by
> > > refine will have SUPER set up on it, so the original code can be called
> > > from inside it and should work as expected. The only problem is access
> to
> > > that code by looking at the model is long and ugly.
> > >
> > > —
> > > You are receiving this because you authored the thread.
> > > Reply to this email directly, view it on GitHub
> > > <
> >
> https://github.com/jacksonic/vjlofvhjfgm/commit/6d3ae0a08abb7a36cda7389d142e38249c24d6f6#commitcomment-17993091
> > >,
> > > or mute the thread
> > > <
> >
> https://github.com/notifications/unsubscribe/AHJP_Su84B5blbgIy69qPP0hpYdx0eSnks5qOtekgaJpZM4I9DyL
> > >
> > > .
> > >
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <
> https://github.com/jacksonic/vjlofvhjfgm/commit/6d3ae0a08abb7a36cda7389d142e38249c24d6f6#commitcomment-17993145
> >,
> > or mute the thread
> > <
> https://github.com/notifications/unsubscribe/AIKjMGc-0IOZlbQbSR9Qspk-y3rjHTgJks5qOth-gaJpZM4I9DyL
> >
> > .
> >
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/jacksonic/vjlofvhjfgm/commit/6d3ae0a08abb7a36cda7389d142e38249c24d6f6#commitcomment-17993213>,
> or mute the thread
> <https://github.com/notifications/unsubscribe/AHJP_RFdkgeaQ60H5k-i6h7M505cFJtNks5qOtlfgaJpZM4I9DyL>
> .
>


Thx. Was on my list before I forgot it.


@frol  Did you read my update ?


Heh.  Eventual plan is to build something that uses Git tags to track your planning over time, and @sherson would add his comments and review via pull-request.  Git, Markdown, yaml, rake tasks: Nerd PMPs.


ASIHPdev3 (shenb) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


This is not a perfect solution, as the 1/3d of the page where the search results show up will always be visible (even when you just clicked on a manifest on the front page, and have not searched for anything!)


Sorry to hear that! We're on it, will get it fixed ASAP.


The test above hangs w/o the change. Removing subscribers from `this.subscribers` prevented the array from enumerating through every subscriber on close.


Nice!


'flx' or 'pgb' also needs to be specified.


@leonli96 I just randomly stumbled upon it via a github search actually. Seemed like a cool concept. I am all for saving time as a pentester. Showed this to my team mate and he's coming up with all kinds of crazy ideas for this, so we might all have to get to collaborating to make this a badass tool for the masses!


You fixed the capital S in the hillShade title but miss the double L issue (i.e. it is hillSade not hilShade)


We could just set `this.subscribers = []` before emitting close, or even just leave it untouched, but setting each as `undefined` may be helpful for debugging if some subscribers are having trouble closing for w/e reason.


ahhhh now I remember the link between questions and current chapter... definitely still todo! 🔨


I would not use `npm run build:hot-reload` for tests. Please use `npm run build` or we can create `npm run build:test` if you don't like production webpack config. hot-reload is starting additional npm server on :3000 and this is quite slow :/

Also if you use `npm run build` you should use `webpack-stats-prod.json` in line 14.


Nothing changed:

```bash
root@e4fa15e0293e:/home/git/gitlab# grep ' registry:' -A 6 config/gitlab.yml
  registry:
    enabled: true    # Enables GitLab Container Registry Defaults to `true`
    host: dockerhub.vc.salford-systems.com          # registry.example.com
    port:           # 5005
    api_url: http://docker-registry:5000/    # http://localhost:5000/ # internal address to the registry, will be used by GitLab to directly communicate with API
    key: /certs/registry-auth.key       # config/registry.key
    path: /home/git/data/shared/registry
root@e4fa15e0293e:/home/git/gitlab# env | grep GITLAB_REGISTRY_PORT
root@e4fa15e0293e:/home/git/gitlab# ss -ltn | cat
State      Recv-Q Send-Q        Local Address:Port          Peer Address:Port
LISTEN     0      128               127.0.0.1:8080                     *:*
LISTEN     0      128                       *:80                       *:*
LISTEN     0      128                       *:22                       *:*
LISTEN     0      128                      :::80                      :::*
LISTEN     0      128                      :::22                      :::*
```

Setting `GITLAB_REGISTRY_PORT` to `5500` resulted in the following:

```
root@7c8a73b3c324:/home/git/gitlab# grep ' registry:' -A 6 config/gitlab.yml
  registry:
    enabled: true    # Enables GitLab Container Registry Defaults to `true`
    host: dockerhub.vc.salford-systems.com          # registry.example.com
    port: 5500          # 5005
    api_url: http://docker-registry:5000/    # http://localhost:5000/ # internal address to the registry, will be used by GitLab to directly communicate with API
    key: /certs/registry-auth.key       # config/registry.key
    path: /home/git/data/shared/registry
```

Yet, there is no `gitlab-registry` config.


bump for upcoming cjdnsctl :)


This is covered by https://github.com/resin-io/resin-supervisor/pull/180


I am afraid my knowledge of ES is not good enough. This field is indexed as `map_position.map_position` so perhaps ES was smart enough to be queried with just a `map_position`? It appears indeed that querying with `map_position.map_position` works too.


Why do you remove the complete YSFGateway-Logging?


This souldn't be `.length`. It should be `.numericality` based on validate.js documentation


Used for packaging the game in a Java Jar file.


this was fixable by just nextTicking the destroy. I've updated master and released a patch :)


Could you please provide me with a test case that reproduces the issue?


Ah you use the wrong VERSION you need to use `8.8.5-1`.


Looks like I accidentally pushed my s3 bucket (s3://bernease/wildfire-simulation) to the Github repo. I'll change this back by EOD.


Thanks for this @qiangxue ! 👍


@AvalancheYT I don't believe so, they are not classes as Credits, so I wouldn't see any reason that would be an issue.


Ouch, I use `latest` tag and I assumed it is the same as `8.8.5-1` at the moment. I'm sorry. I'm pulling `8.8.5-1` now.


Epic


I think I've addressed all these issues now - my latest commit is ce28c2d - try running Travis again.


Closes issues #3


Ah, in that case I'd suggest just using a note.


Yargh!! I won't upload this again...)


I had the problem too with the @import 'jeet'; in stylus after that commit.

Yesterday worked fine, but today with a npm install broke.


This code won't work as well. You have to use `gtk_widget_get_allocated_height(self->drawing_area)` to retrieve the height of the drawing area.


Hello
I have tested on 1.14.x


You don't seem to initialize the hash tables anywhere in the code. This will lead to segfaults.


done-ish


I thought jsXXX should not be used for styling... ;-)


Memory leak here. The copied list should be freed after use.


5711-HVAC-sizing-sim-crash (EnergyArchmage) - x86_64-MacOS-10.9-clang: OK (2219 of 2219 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


jsXXX should not be used for styling...


A very bad name for what the function does. Also, I'm not really sure this is the best way to handle this.


Thanks ! I can't spell hillShade apparently (who puts a capital in the middle of a word !) It should be fine now.


I guess that apply for all.

jsXXX should be empty rules at the top of the mcss file and should not be used for css styling even for sub selection. If a sub selection is needed for styling, then that should be a class in itself.


It should be 'reflect-metadata', not 'relect-metadata' :)


Should be `#include <cstdio>` since this is C++


I believe that @lombardi is handling that in one of his PRs


Mine (version of ES) wasn't. I had frequent errors in MLH's part of search_specs regarding the map_position. It looks like the fix remedied this.


And as for the API itself, python will be able to implement a REST API fairly easily. It can use requests from the REST API to talk to the subprocess


I made a PR with that - moving the discussion over there.


@Jhuku Awesome work. Onboarding looks perfect. But I can notice that you are not following the guidelines at all. You need to follow that so that your code is adjustable with everyone in the team with a uniform convention. I would like you to go through guidelines again once. Making changes now will be easy else once the project goes big, it'll be difficult to modify.
These are the rules in guidelines which you have been violating: **Architecture (i** and **v)**, **Nomenclature (i, iii, iv, v)** .
Please update the code soon.


No need to keep code commented: just remove it. If it's ever needed again, git keeps the history for us.


If you're familiar with Node, it may make sense to implement it in that since it's integrated in electron


LGTM


ASIHPdev3 (shenb) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1114 of 1114 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-34.4%25-green.svg)


cool


Variables access specifiers must be mentioned. And the variable name should be more standard and self-explanatory. These ImageView objects can be declared in same line as they are similar to each other.


When this `@todo` gets removed, make sure that this gets reworded something like `Bail out early if there weren't any changes in the alterable fields.` – and pls adhere to the coding standards wrt line length and having a period at the end of the sentence.


121174135-ComputeIntThermalAbsorpFactors-Movable-Insulation-Bugs (RKStrand) - i386-Windows-7-VisualStudio-12: OK (2224 of 2224 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


spelling error, also you don't need to set `true` to a variable here, you can just return `true` (same with the `false` 2 lines down)


cool much better 👍


фигурные скобки лишние :)


I'm working through the code to turn it into airbnb format. I have a linter
that I can use, and I've already made most of the changes.

   - AirBNB format prefers camelCase or UPPER_CASE. Should I change
   variable names to fit? (c_speed_light to C_SPEED_LIGHT or cSpeedLight,
   depending on if it's a const or not) I'm hesitant to do that because it
   seemed like Phil wanted underscore variable names, though we could
   certainly apply it to variables that aren't a part of inputs or outputs.
   - airBNB suggests using *const* or *let* rather than *var*. If it's OK,
   I'll go ahead and make any constants const and anything else let, though if
   there are reasons not to please let me know.
   - Removed spaces inside parenthesis and brackets: A lot of the existing
   code had spaces, so I'm unsure if we want to follow this rule or not. Right
   now I have it without spaces, but we could just as easily keep them.

The Math.PI change is made, thanks.

I'm adding JSDoc commenting before sending a new pull request.

Thanks,
Kenyon

On Wed, Jun 22, 2016 at 6:34 PM, Richard Lee <notifications@github.com>
wrote:

> @KenyonPrater <https://github.com/KenyonPrater> We should agree on a
> common Javascript style, my recommendation is this:
> https://github.com/airbnb/javascript#types
> I'm not sure what text-editor you use, but I have mine autoformat.
>
> Also, you can use Math.PI instead of declaring the constant yourself:
>
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/PI
>
> Next, please follow JSDoc comment formatting:
>
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/PI
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/ucsbdeepspace/laser-propulsion-calculator/commit/5329e8986b6e037f802ed0791508ff2156a6c05e#commitcomment-17980337>,
> or mute the thread
> <https://github.com/notifications/unsubscribe/AHqF5_06ccb5sRpMvakVQl00YsTSS1V3ks5qOeKggaJpZM4I8YCj>
> .
>


Architecture (Rule 5) is violated. onCreate function should call init(), setInit() and setData() functions. Please correct this immediately.


But in theory there should not be a difference between *active* and *running*, right? The idea is that the module manager looks at the database table's `active` column and keeps the module processes in sync with those?


5711-HVAC-sizing-sim-crash (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (2216 of 2217 tests passed, 2 test warnings)

 * 3 tests had: EIO diffs.
 * 2 tests had: AUD diffs.
 * 1 test had: ESO small diffs.
 * 1 test had: MTR small diffs.
 * 1 test had: Table small diffs.
 * 1 test had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: Table big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


а если `@collection.select(&block_filter)`? тогда, подумавши, можно б его  с предыдущим if'ом объединить ;)


@topherfangio are there any other ways to fix this besides using the `-webkit-transform`? It breaks your `position: fixed;` elements within `md-content` due to a webkit [bug](http://stackoverflow.com/questions/27952725/why-doesnt-translatex-work-as-expected-for-fixed-elements-on-ie9-ie10-and-ie1). I use `position: fixed;` to position fabs correctly when they are inside of `md-content`.

I know you can disable it easily. But an alternative fix would be nice if you need to use `position: fixed;`.


The call to `delete` here is the indicator that `fDebugCanvas` is probably best a `unique_ptr`.  Consider using the two-argument constructor for unique_ptr that allows a deleter function.


This PagerAdapter can be made inner class of fragment for easier usage according to Architecture(Rule 4).


Whoa, that's a trick! Nice! Probably it worths some comments about what we're doing here and why. (Basically we're building the form for the parent entity again, copy over the values into it from the comment form, and we're just using that parent entity form for managing all the submit stuff. If I'm understanding this trick properly. :) )


Each color should be referenced from color.xml. Avoid using hardcoded values.


This includes yesterday's fixes in libtorrent :) ?


Fixed with commit 2c5ff54


All the merit would be yours, because it all started with your "rook_end" series for the rook endgame. :-)


If so let me know to make a new build for android and test right away on 5%


74715752-Constant-Flow-Radiant-Heating-Not-Turning-On-Bug (RKStrand) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


oops. dockerinfo.md updated


This commit adds 8va marks (one octave up only for now).

Example Humdrum data:

```
**kern
*clefG2
*M4/4
=1-
16ccLL
16dd
16ee
16ffJJ
16ggLL
16aa
16bb
16cccJJ
16dddLL
16ede
16fff
16gggJJ
16aaaLL
16bbbJ
8ccccJ
=2
16ccLL
16dd
16ee
16ffJJ
16ggLL
16aa
16bb
*8va
16cccJJ
16dddLL
16ede
16fff
16gggJJ
16aaaLL
16bbbJ
8ccccJ
*X8va
==
*-
```

Verovio rendering:

![screen shot 2016-06-23 at 12 40 31 pm](https://cloud.githubusercontent.com/assets/3487289/16317440/04fc71d6-3940-11e6-94ac-03de2e1c8550.png)

Notes:

* The stem of the C7 at the end of m1 should be touching the middle line of the staff.

Here is the MEI output from verovio:

```xml
<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="http://music-encoding.org/schema/3.0.0/mei-all.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>
<?xml-model href="http://music-encoding.org/schema/3.0.0/mei-all.rng" type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?>
<mei xmlns="http://www.music-encoding.org/ns/mei" meiversion="3.0.0">
    <meiHead>
        <fileDesc>
            <titleStmt>
                <title />
            </titleStmt>
            <pubStmt>
                <date>2016-06-23 12:40:17</date>
            </pubStmt>
        </fileDesc>
        <encodingDesc>
            <projectDesc>
                <p>Encoded with Verovio version 0.9.12-dev-b005b99-dirty</p>
            </projectDesc>
        </encodingDesc>
    </meiHead>
    <music>
        <body>
            <mdiv>
                <score>
                    <scoreDef xml:id="scoredef-000000153295172">
                        <staffGrp xml:id="m-000000010623014">
                            <staffDef xml:id="staffdef-000000085115316" clef.shape="G" clef.line="2" meter.count="4" meter.unit="4" n="1" lines="5" />
                        </staffGrp>
                    </scoreDef>
                    <section>
                        <measure xml:id="measure-000000094267148" n="1">
                            <staff xml:id="staff-000000096417469" n="1">
                                <!-- kern: =1-  16ccLL  16dd  16ee  16ffJJ  16ggLL  16aa  16bb  16cccJJ  16dddLL  16ede  16fff  16gggJJ  16aaaLL  16bbbJ  8ccccJ  =2 -->
                                <layer xml:id="layer-000000211993182" n="1">
                                    <beam xml:id="beam-000000079306262">
                                        <note xml:id="note-000000172004190" dur="16" oct="5" pname="c" accid.ges="n" />
                                        <note xml:id="note-000000146684103" dur="16" oct="5" pname="d" accid.ges="n" />
                                        <note xml:id="note-000000008497407" dur="16" oct="5" pname="e" accid.ges="n" />
                                        <note xml:id="note-000000008258604" dur="16" oct="5" pname="f" accid.ges="n" />
                                    </beam>
                                    <beam xml:id="beam-000000074917193">
                                        <note xml:id="note-000000063603876" dur="16" oct="5" pname="g" accid.ges="n" />
                                        <note xml:id="note-000000187737862" dur="16" oct="5" pname="a" accid.ges="n" />
                                        <note xml:id="note-000000012527458" dur="16" oct="5" pname="b" accid.ges="n" />
                                        <note xml:id="note-000000095594242" dur="16" oct="6" pname="c" accid.ges="n" />
                                    </beam>
                                    <beam xml:id="beam-000000119910654">
                                        <note xml:id="note-000000139707433" dur="16" oct="6" pname="d" accid.ges="n" />
                                        <note xml:id="note-000000004210162" dur="16" oct="6" pname="e" accid.ges="n" />
                                        <note xml:id="note-000000107990831" dur="16" oct="6" pname="f" accid.ges="n" />
                                        <note xml:id="note-000000163481663" dur="16" oct="6" pname="g" accid.ges="n" />
                                    </beam>
                                    <beam xml:id="beam-000000145742153">
                                        <note xml:id="note-000000068524425" dur="16" oct="6" pname="a" accid.ges="n" />
                                        <note xml:id="note-000000209289537" dur="16" oct="6" pname="b" accid.ges="n" />
                                        <note xml:id="note-000000165796383" dur="8" oct="7" pname="c" accid.ges="n" />
                                    </beam>
                                </layer>
                            </staff>
                        </measure>
                        <measure xml:id="measure-000000179782140" n="2" right="end">
                            <staff xml:id="staff-000000179332465" n="1">
                                <!-- kern: =2  16ccLL  16dd  16ee  16ffJJ  16ggLL  16aa  16bb  *8va  16cccJJ  16dddLL  16ede  16fff  16gggJJ  16aaaLL  16bbbJ  8ccccJ  *X8va  == -->
                                <layer xml:id="layer-000000047455816" n="1">
                                    <beam xml:id="beam-000000014486461">
                                        <note xml:id="note-000000164066267" dur="16" oct="5" pname="c" accid.ges="n" />
                                        <note xml:id="note-000000092755124" dur="16" oct="5" pname="d" accid.ges="n" />
                                        <note xml:id="note-000000076998114" dur="16" oct="5" pname="e" accid.ges="n" />
                                        <note xml:id="note-000000033659677" dur="16" oct="5" pname="f" accid.ges="n" />
                                    </beam>
                                    <beam xml:id="beam-000000071002080">
                                        <note xml:id="note-000000190054371" dur="16" oct="5" pname="g" accid.ges="n" />
                                        <note xml:id="note-000000076636849" dur="16" oct="5" pname="a" accid.ges="n" />
                                        <note xml:id="note-000000189581398" dur="16" oct="5" pname="b" accid.ges="n" />
                                        <note xml:id="note-000000073077535" dur="16" oct="5" pname="c" accid.ges="n" />
                                    </beam>
                                    <beam xml:id="beam-000000068243109">
                                        <note xml:id="note-000000205680591" dur="16" oct="5" pname="d" accid.ges="n" />
                                        <note xml:id="note-000000069271403" dur="16" oct="5" pname="e" accid.ges="n" />
                                        <note xml:id="note-000000093588543" dur="16" oct="5" pname="f" accid.ges="n" />
                                        <note xml:id="note-000000125630903" dur="16" oct="5" pname="g" accid.ges="n" />
                                    </beam>
                                    <beam xml:id="beam-000000072666671">
                                        <note xml:id="note-000000034794490" dur="16" oct="5" pname="a" accid.ges="n" />
                                        <note xml:id="note-000000031199713" dur="16" oct="5" pname="b" accid.ges="n" />
                                        <note xml:id="note-000000172823200" dur="8" oct="6" pname="c" accid.ges="n" />
                                    </beam>
                                </layer>
                            </staff>
                            <octave xml:id="octave-000000167896555" staff="1" startid="note-000000073077535" endid="note-000000172823200" dis="8" dis.place="above" />
                        </measure>
                    </section>
                </score>
            </mdiv>
        </body>
    </music>
</mei>
```


I'm uploading to maven now, I will let you know


![screen shot 2016-06-23 at 15 46 44](https://cloud.githubusercontent.com/assets/64992/16317563/baea35b4-3959-11e6-9252-5d8d2e793f64.png)


Text and colors should be referenced from strings.xml and color.xml.


I actually set this to 55px instead of default 50 because if you select a frequency > 10000 it will not fit properly within the field.  I think this needs to be changed back to 55px, do you agree ?

![image](https://cloud.githubusercontent.com/assets/15310830/16317575/124569c8-398c-11e6-91f2-f8cfa8a46885.png)


I was just wondering what's better: building the parent entity form here in the validate function _again_ the same way it was built in the alter function, or just store it in a cache somewhere. But I like this approach better: usually comment forms are displayed a factor of about a hundred more than they're actually being submitted, so this caching would eat up more valuable resources than it would save by not building the parent entity form again (but retrieving it from the cache). And I haven't even touched the cache invalidation, which would be really hard.
So let's just keep this, and probably add a comment why we're building the parent entity form _again_.


oh true! Thank you @aldenml always on the ball my friend, I want to be like you when I grow up.


Not really - it could be that a dependency was not available. Then the module is *active* but not running. Same if the module is restarting.

The database shows what modules we want to be active, not what modules are actually running.


74715752-Constant-Flow-Radiant-Heating-Not-Turning-On-Bug (RKStrand) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Выглядит. как модуль  :+1:


Commit message is WRONG!, is GULP not Grunt


But `async ...` returns `Async ()`, which controls cancellation etc. too. Is that not important here?


Hmm, the D7 version does not disturb the user with a message like this: y'know, if the comment got saved, comment.module already informs the user about this fact, so I just don't see the reason for having _another_ green message.


may be better to use a fixed tag or sha rather than downloading master which may change


Colors should be referenced from color.xml. Avoid using hardcoded colors.


Hmm,

```
$ docker run -it sameersbn/gitlab:8.8.5-1 cat VERSION
8.8.5
```

And still no `gitlab-registry` nginx config :(


Haha


Consider using float instead of double to save memory


Good work, works like a charm on the new Laptop (gentoo has 2.7 as last stable...)


TMath::Power(...,2) is less efficient than a multiply


Помнишь, мы говорили, что делать поиск по всему дому - это медленно. Тебе нужно передавать на вход модуля рутовый селектор и все поиски делать относительно него:
```javascript
var rootEl = $(rootQuery);
var inputEl = rootEl.find('input');
...
```


`i`-dependent terms should go outside of the `j` loop.  Consider removing unnecessary square-roots of 2 and `M_PI`.


Texts and colors should be referenced from strings.xml and color.xml. Avoid using hardcoded values.


А что будет, если на странице будет два компонента? ;) По одному ключу уже не выйдет загружать элементы.


Consider using cetlib::square instead of Math::Power(x,2).


Okay, in that case, it makes sense to add those functions.
However, what should the semantics of `activate_await/2` be? Activate and await until it's running?


Oh nevermind, I just found that this got removed by a later commit.


other_equipment (nmerket) - x86_64-MacOS-10.9-clang: OK (2202 of 2219 tests passed, 537 test warnings)

 * 540 tests had: AUD diffs.
 * 3 tests had: EIO diffs.
 * 3 tests had: ESO big diffs.
 * 1 test had: MTR small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.23%25-yellow.svg)


`for (i = 0, len = toDoArray.length; i < len; i++)` будет работать чуть-чуть быстрее.


I appreciate `:rem`, it helped me today get rid of auto-pairing `'` which isn't useful in my environment.

Thank you for the great package!


Just wanted to raise a concern about changing any entity in a _validate_ function, then I realised this has been moved to its proper place: the submit function in a later commit.


Constructors of the algorithms already call `reconfigure`.  So you're reconfiguring twice.


@Psycojoker just for the poc (not tested for the moment)


There are specific detector tests -- if fDetector == "dune35t" ...  eventually should be made more general.


Обычно, обработчики называют по паттерну onAction(): onClick(), onAddItem()  и т.д.


=== лучше чем ==


`soundNode` is only used by `kResourceTypeAudio` so there is no reason to initialise it here, it is unconditionally initialised where it is used.


Unnecessary data members...they're used only in the event loop, so no need to provide them as class members.


#60 @maybeec Now testSpec.ts working correctly with the mockBackend you recommended. But using it for our own services fails :( I have implemented exactly the same as Busses.ts for TestService.ts, and there the test will run fine.
You need to include BussesSpec.ts inside karma.config.ts files, if you want to see the failing behavior.


What is agrevents?


Было бы неплохо как-то отделять паблик методы от приватных. К примеру, можно использовать _ для этого;) init() здесь единственный паблик метод.


I understand that this reverted part of the bug 1203 fix, not 1202?


Use `auto` to shorten lengthy type names.


Такие константы лучше выносить в константы:
```javascript
var _STORE_ID = 'NativeJSToDoList';
```


@fnando should have renamed the file too 🏃


also, if you don't need to access specific items by index, ex: `inventory[2]`
then use `List<CollectableSprite>` instead

in Haxe, on certain platforms, List may be more optimized than Array.
(in Haxe->js though, a List _is_ an Array)


Nope. It's an engine. So `engine.rb`. ¯\\_(ツ)_/¯


FYI, Railtie doesn't add `app/assets/javascripts` to the load path.


So we're yielding out many different dask collections.  How is this used in practice?  Will common use involve multiple reads of the same data?


这是第二个版本么？


注册登录/注册登录.cpp

[笨办法学 Python （第三版）.pdf](https://github.com/SunHanxi/Login/files/329069/Python.pdf)


`ryu.services.protocols.bgp.utils.validation`の`_is_valid_asn`を呼ぶようにしてはいかがでしょうか。


could you be more specific, what other targets fail to link?


In this particular situation this would have the effect that you have multiple confirm dialogs pop open at once so Promis.all isn't helpful here.


I need to think about this some more.... if we are to not use the NO_PARAMS option here, then it should be removed entirely.

However, it looks like an optimization to avoid creating needless empty MultiMaps on every dispatch.

Standby while I analyse a bit more.


There is a note below it stating: `Lastly, I had to add the `runtimes``, which can probably be removed.


ddddfasfd


tried to optimize it w/o actually implementing a full on CIDR trie. prbly
will end up doing that in the long run.

On Wed, Jun 22, 2016 at 6:57 PM, Oliver Keyes <notifications@github.com>
wrote:

> tyop
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/hrbrmstr/iptools/commit/0bc3d75167eee93432faafd8b82e87bb504da106#commitcomment-17978714>,
> or mute the thread
> <https://github.com/notifications/unsubscribe/AAfHtmg_08aCmNFde1a5i-xJcYEhOZQOks5qOb3KgaJpZM4I8TdS>
> .
>


ssdfasdf


fffsdfgadsf


Yes. The owner is used all over in spell effects of course; the issue was rooted in spellEffects and did have something to do with the owner in fact; https://github.com/cmangos/mangos-wotlk/commit/306bea44b190bbe94d6ceee755501220fb1f798e


Good catch, not sure how I missed that.


footer-uprg结束


Fixes #38 as well


fixed ril


foot-dw结束


you probably meant `item.updateHitbox()`
though in this case, maybe inventory items are just for display, so we don't care about collisions for them


メソッド名がパスアトリビュート全般に関しての名前になっておりますが、
処理自体はAS_PATH、AS4_PATHに関するもののみになっております。
`_extract_and_reconstruct_as_path`等の名前ではいかがでしょうか。


Why are symlinks even checksummed? They have no content. They are pointers. Only the pointed to files should be checksummed *if they are tracked by pkg*, and thus it would be redundant to track it again.  Requiring rebuilding packages for symlink hashes is even worse since they don't need hashes to begin with. They serve no purpose.


既然已經有`isBoolean` `isDecimal` `isInterger`了，爲何不來個type呢。


Tweaked check inventory and item checking; added a use item command


@NGorco Why did you comment this array?
Does it break something?


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1667 of 1667 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


細かい話ですが、有効になるのは`to advertise`だけじゃなくて`receive`も含まれると思うので`to advertise`は不要ではないでしょうか。
あとその他の項目を見るとenablesとenableが混在しているのでenablesに統一してはどうでしょうか。
また、その他の項目は`to this neighbor`ではなく`for this neighbor`に統一されております。
```python
        ``enable_for_octet_as_number`` enables Four-Octed AS Number capablity
        for this neighbor. The default is True.
```


Better match sklearn api: http://scikit-learn.org/stable/modules/cross_validation.html#cross-validation


hahaha


Well done ! 👍😃


The jenkins build finally passed, please take a look at my PR.

On Wed, Jun 22, 2016 at 4:38 PM, Henry Cai <hcai@pinterest.com> wrote:

> I re-created another PR, but it still seems hitting some gradle issue:
>
> https://github.com/apache/kafka/pull/1543
> https://builds.apache.org/job/kafka-trunk-git-pr-jdk7/4366/console
>
> On Wed, Jun 22, 2016 at 4:10 PM, Guozhang Wang <notifications@github.com>
> wrote:
>
>> Sometimes it is just transient failure, you can try to close / reopen to
>> trigger a new Jenkins job.
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/HenryCaiHaiying/kafka/commit/29ba7f7738d572952c8b1e25edd32fa42ac38250#commitcomment-17978864>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe/AHCX__ycVLoUC5j9ha-oJlkWzj5Zgtzwks5qOcDngaJpZM4I6QWW>
>> .
>>
>
>


嘿嘿


Github


TAKE A LOOK AT THIS


https://imgur.com/a/s7NSL in pre 22 these still have the 300EU/t


The scikit-learn api yields out indices to select from data, we yield out collections that are already selected. Data dependencies and the resulting graphs are virtually identical, but this is easier to do for more cross-validation strategies.

> How is this used in practice?

New api point for https://github.com/jcrist/dask-learn/blob/master/dklearn/grid_search.py#L122.

Will common use involve multiple reads of the same data?

Without shuffling (chunks are in same order for all cv sets), it should still result in only a single pass over the data with minimal data kept for long periods in the scheduler cache (only test subsets are depended on later, and that's unavoidable. Test sets should also be small ideally). Shuffling poses a problem, because one cv set could have chunk 1000 first, and another could have it last - the scheduler would keep it around for the entire time (which is why shuffling isn't implemented).


MI


その他のCapabilityを踏襲するのであれば、self._protocolに確認しに行くべきではないでしょうか。
実際sessionが切れるたびにどういうBGPSessionが張れているかを保持するのは
BgpProtocolクラスの機能分担になっているかと思います。(BgpProtocolにもcap_four_octet_as_numberを実装されていますし)


Mi


great; download rates aren't much of a problem for me; Quick question: Can you run a Jenkins server on a virtual machine? (I use azure)


this is hillside


holidays ^


OMFG AUTOCORRECT I meany hilarious!


Because there is a `:` in the title, you have to wrap the title in quotes. Otherwise, jekyll gets confused. Annoying little gotcha.


oops the post above was supposed to say
> OMFG AUTOCORRECT I meant hilarious!

And NOT
> OMFG AUTOCORRECT I meany hilarious!


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1667 of 1667 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


yeah


If we have both compression file and uncompression file in one bucket, is there any problem? Like leak upstreamReader?

Better to have cases for such scenario if not have already.


Changed


DOASToZoneHVAC (Nigusse) - i386-Windows-7-VisualStudio-12: OK (2241 of 2241 tests passed, 557 test warnings)

 * 557 tests had: AUD diffs.
 * 4 tests had: BND diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ah, I see! Fortunately these globals are only meant to be used with the `setup_for_endstop_or_probe_move`/`clean_up_after_endstop_or_probe_move` functions, which themselves are supposed to only bookend the top-level functions, and not to ever be nested.


So we hardcode S3_ZIP_CHUNKSIZE?  if yes, please make sure we have a optimized hardcoded chunksize interms of both performance and memory consumption.


any reason to comment out S3DEBUG code?


5 утра...


other than above comments, LGTM


既存に合わせるのであればvalidationの実態はBgpProtocolクラスに実装したほうが機能分担が整理できると思います。


I thought this issue had more to do with the logging-before-shutdown. How does sleeping at *start* time help?

I posted a related question on StackOverflow: http://unix.stackexchange.com/questions/291483/how-to-fix-unit-attribution-of-last-lines-of-systemd-logging-before-exit


`parse_value`、`serialize_value` の順番は気づきませんでした。
修正します！


닉네임에 마우스 커서 갖다대면 가입일 나오게나 해 달라고


@MichaelRix 什么type


`_TWO_OCTET_VALUE_SIZE` は `_FOUR_OCTET_VALUE_SIZE` があるから、
そのペアを用意するだけ用意しよう、と思い定義してました。
使わなさそうなので、削除します。


When `$strValue` is empty string and the column in table is set to `NOT NULL`, this change will cause  column value in postgresql is null, final can not alert column to not null.

Though empty in `NOT NULL` mysql column is nosence, but migration need deal with this problem.

Is there something wrong like said. Or I am miss unstanding.


@abc612008 你學過 python 了居然不知道 type ……蛤蛤蛤


`self._pathattr_map` が `__init__` の中で生成されているだけだと、
インスタンス化した後に、`self.path_attributes` を更新してしまうと、
`self.pathattr_map` と不一致が生じるので、毎回生成してます。

正直、非効率ですが、ユーザが更新した気でいても、
実は更新されて無かった、を防ぐために実装してます。


質問です。
AS番号が2バイトの時は最大値-1で比較していますが、4バイトの時には-1の必要はないのでしょうか？
(調べても最大値が0xffffffffとしてしか出てこなかったですし、元々が-1していたのが間違い？)


Эта стока не должна быть в этом файле. Файл - просто хранилище модуля. Она должна быть либо в app модуле, либо в html, который этот модуль подключает.


Call reserve on hitVec


though if nobody else is using `changeRequestStar()` i'm not 100% it really needs to be its own function


should these be excluded for connext too? they're currently failing because of https://github.com/ros2/rmw_connext/blame/master/rmw_connext_cpp/src/functions.cpp#L1541

e.g. on a recent CI job: http://ci.ros2.org/job/ci_linux/1520/consoleFull
```
16:58:17       Start  8: test_example_add_two_ints_server_add_two_ints_client__rmw_connext_cpp
16:58:17
16:58:17 8: Test command: /home/rosbuild/ci_scripts/venv/bin/python3 "-u" "/home/rosbuild/ci_scripts/ws/install/ament_cmake_test/share/ament_cmake_test/cmake/run_test.py" "/home/rosbuild/ci_scripts/ws/build/rclcpp_examples/test_results/rclcpp_examples/test_example_add_two_ints_server_add_two_ints_client__rmw_connext_cpp.xunit.xml" "--output-file" "/home/rosbuild/ci_scripts/ws/build/rclcpp_examples/ament_cmake_nose/test_example_add_two_ints_server_add_two_ints_client__rmw_connext_cpp.txt" "--env" "RCL_ASSERT_RMW_ID_MATCHES=rmw_connext_cpp" "--command" "/home/rosbuild/ci_scripts/venv/bin/python3" "/usr/bin/nosetests3" "/home/rosbuild/ci_scripts/ws/build/rclcpp_examples/test_add_two_ints_server_add_two_ints_client__rmw_connext_cpp_.py" "--with-xunit" "--xunit-file=/home/rosbuild/ci_scripts/ws/build/rclcpp_examples/test_results/rclcpp_examples/test_example_add_two_ints_server_add_two_ints_client__rmw_connext_cpp.xunit.xml" "--xunit-testsuite-name=rclcpp_examples.nosetests"
16:58:17 8: Test timeout computed to be: 30
16:58:17 8: -- run_test.py: extra environment variables:
16:58:17 8:  - RCL_ASSERT_RMW_ID_MATCHES=rmw_connext_cpp
16:58:17 8: -- run_test.py: invoking following command in '/home/rosbuild/ci_scripts/ws/src/ros2/examples/rclcpp_examples':
16:58:17 8:  - /home/rosbuild/ci_scripts/venv/bin/python3 /usr/bin/nosetests3 /home/rosbuild/ci_scripts/ws/build/rclcpp_examples/test_add_two_ints_server_add_two_ints_client__rmw_connext_cpp_.py --with-xunit --xunit-file=/home/rosbuild/ci_scripts/ws/build/rclcpp_examples/test_results/rclcpp_examples/test_example_add_two_ints_server_add_two_ints_client__rmw_connext_cpp.xunit.xml --xunit-testsuite-name=rclcpp_examples.nosetests
16:58:20 8: [test_executable_1] terminate called after throwing an instance of 'rclcpp::exceptions::RCLError'
16:58:20 8: [test_executable_1]   what():  rcl_service_server_is_available failed: not implemented, at /home/rosbuild/ci_scripts/ws/src/ros2/rmw_connext/rmw_connext_cpp/src/functions.cpp:1541
16:58:20 8: E
16:58:20 8: ======================================================================
16:58:20 8: ERROR: test_add_two_ints_server_add_two_ints_client__rmw_connext_cpp_.test_executabl
```
```
16:58:58 The following tests FAILED:
16:58:58 	  8 - test_example_add_two_ints_server_add_two_ints_client__rmw_connext_cpp (Failed)
16:58:58 	  9 - test_example_add_two_ints_server_add_two_ints_client_async__rmw_connext_cpp (Failed)
16:58:58 	 17 - test_example_add_two_ints_server_add_two_ints_client__rmw_connext_dynamic_cpp (Failed)
16:58:58 	 18 - test_example_add_two_ints_server_add_two_ints_client_async__rmw_connext_dynamic_cpp (Failed)
```


в задании такое выражение `... show( new_filter: true)`. По идее, если просто вызывать как `show( :new_filter)`, то тогда можно легко объединить. Или первый вариант синтаксиса принципиален?


Многие ошибки из первого задания есть и здесь. Так что правь уже здесь. Мы будем развивать эту версия проги ;)


doh! this doesn't call done(), so fails are hidden....


This makes a copy. Better to dereference the iterator where it is used. Might use `auto` to get the type:
  `auto const& clusterHits = *clusIt;`


Usually better to use !empty() than size() > 0


Is `af_get_device_id` in v3.3.0 too? I get an error in that version.


Yes, sorry I can't go amend the mistaken comment now.  But the more
important thing is the commit ID in the extended comment.

PRL

On Thu, Jun 23, 2016 at 3:58 PM, Gale Andrews <notifications@github.com>
wrote:

> I understand that this reverted part of the bug 1203 fix, not 1202?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/audacity/audacity/commit/8d94cd7db5bb66ecd7cfa72388ba56d18079bc21#commitcomment-17994070>,
> or mute the thread
> <https://github.com/notifications/unsubscribe/ALITYe7RZNFH1j-wF2FtSkIOErBvaUvZks5qOuWAgaJpZM4I9Lne>
> .
>


For this condition, try to use the copy from `tj.Pts[ipt].Hits` to `hitVec`.


yes


I don't think this is fixed. my server randomly stops and I have to reboot the terminal. I disabled experience and now I have no more problems.


C++ 666


Consider using
 `unsigned int const` because the value will never change.


Sorry for the delay but seems that this commit make all images on chat windows get (looks) cropped and if you click on "Click here to view full version" you get 'Unauthenticated" error on your browser


Use the built-in utils for margin if possible. E.g. `composes: mv3 from base;`


Almost all of these properties are already either unconditionally set a few lines down, or are not used until another function is called (the fade ones), so don’t need to be set like this; most of this changeset is burning CPU cycles on nothing.

I do see that `pausedAtTick` does not get set if someone calls `play` instead of `waitForPlay`; surprised I did not see any problems with that when testing, as one would think that to be a pretty obvious mistake! That property is probably best set at line 614/623, where it’s already set when `autoPlay` is off. I assume this would fix your audio issues but since I don’t know exactly what they are, it is possible there is another bug somewhere else I suppose :)


The following doc(s) have been deployed to the [1692sitet](https://1692sitet-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/user-dashboard](https://1692sitet-static-docs.pantheonsite.io/docs/user-dashboard)
- [source/docs/assets/images/pantheon-user-dashboard.png](https://github.com/pantheon-systems/documentation/commit/6d79689d80636fb325b4b3e54c57bfd1caebb398/source/docs/assets/images/pantheon-user-dashboard.png)
- [source/docs/assets/images/pantheon-user-dashboard1.png](https://github.com/pantheon-systems/documentation/commit/6d79689d80636fb325b4b3e54c57bfd1caebb398/source/docs/assets/images/pantheon-user-dashboard1.png)
- [style-guide.md](https://github.com/pantheon-systems/documentation/commit/6d79689d80636fb325b4b3e54c57bfd1caebb398/style-guide.md)


Look at why the cast to float is used.


first try


>And as for the API itself, python will be able to implement a REST API fairly easily. It can use requests from the REST API to talk to the subprocess

@ludamad I agree. I have used the [`Flask`](http://flask.pocoo.org/) framework in Python before to create `REST API`s.

Also, @itamblyn wanted a `Streaming API` (just like [Twitter's Streaming APIs](https://dev.twitter.com/streaming/overview)) for `#k@`

>If you're familiar with Node, it may make sense to implement it in that since it's integrated in electron.

Well, I haven't used `NodeJS` before.


good job


The following doc(s) have been deployed to the [nrprotrou](https://nrprotrou-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/new-relic](https://nrprotrou-static-docs.pantheonsite.io/docs/new-relic)


Commit actually made by Abdo from my machine.


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#VhPBhBkUSFai09FGBrJlYQ


Could replace with `Trajectory` holding a `std::vector<unsigned int> HitIndicies` for all `TrajPoints` and the `TrajPoint` would just hold a `iterator` or `index` into `HitIndicies` for where its hits begin.


This plugin speeds coding up a lot.
I usually forget that C-n exists. This is like the fish shell. It pops up the autocompletion instead of relying upon you to check for an autocompletion.


Please add documentation - see above methods for examples


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#WjREkc-qSsS6LMup1QzupA


Silly me. `SSL_REGISTRY_KEY_PATH` and `SSL_REGISTRY_CERT_PATH` are defined as env variables, but they didn't exist, so the check in `/etc/docker-gitlab/runtime/functions`:

```bash
if [[ $GITLAB_REGISTRY_ENABLED == true && -f ${SSL_REGISTRY_CERT_PATH} && -f ${SSL_REGISTRY_KEY_PATH} ]]; then
...
```

just skipped Registry configuration step. It would be easier to troubleshoot such mistakes if the `if` statement is split into two with error message if `GITLAB_REGISTRY_ENABLED == true`, but `SSL_*` files don't exist.


use self.root to find the top node (no need to use a for loop)


This commit was unnecessary...


This would also be promoted to `Trajectory`.


Hi @webermax
nice to see you still trying to improve this mod. Why not check out what I have done since as lots of features have been added and now made to work with v1.10-rc2 and v1.10-rc3.

Also why not contribute some of your stuff back?


If we really want a float, consider using:
 `auto endWire = static_cast<float>(fBlurredClusteringAlg.GlobalWire(clusterHits.back()->WireID()));`


А ты попробуй разные варианты. Я так мыслю, что всё что красиво, минимально и работает — то хорошо.


Next blog topic: "when is it ok to catch `Exception` - when is it not such a great idea after all" ;)


LOL well this is funny.  Your note happened to hit my username and so I just got a notification for this pull commit message.

:-)


Another good topic :) This is a very powerful tool you're using here.


Looks like some prime and juicy material for refactoring. 3 consecutive if blocks ... hmmm


Lol! That's quite funny!
I'm sorry!

--
João Paulo Papa
Department of Computing
São Paulo State University
Av. Eng. Luiz Edmundo Carrijo Coube, 14-01, CEP 17033-360
Bauru, SP, Brazil
Phone/FAX: +55-14-3103 6079
http://wwwp.fc.unesp.br/~papa

> On 23 de jun de 2016, at 17:15, Christopher Gleeson <notifications@github.com> wrote:
>
> LOL well this is funny. Your note happened to hit my username and so I just got a notification for this pull commit message.
>
> :-)
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>


Consider changing the name: endWire is perhaps better as endPosition.


It is part of 3.3.0. What error are you seeing?


instead of using self.metadata.ontology.ontologyclasses.all() which has to grab all the data much of it you don't need try this (this also avoids using a loop and replaces lines 628-629):
ontology_classes = self.metadata.ontology.ontologyclasses.values_list('source', flat=True)


Refs#: 10063


Nice! I see you found that one-liner :)


if so: https://github.com/ros2/examples/compare/disable_client_server_tests_connext


Cool - but I _believe_ that java's `+` uses StringBuilder under the hook.

So this is probably equivalent to `workingDirectory + fileName`.

Not sure, but pretty sure. Just dropping some information here.


think the no-gutter was added to fix a bug with the field becoming disabled after save


That is a true fact.


Agreed. This will get really out of hand as more command line flag options are added. I just wasn't sure yet how to go about simplifying this. I figured there would be a helper method that would get the argument after the flag. Maybe have the flags and the variable that should be set by the value after the flag in a table that can be referenced.


A good sign that your class is doing a lot, is that it's importing a lot. Not always, but it's a clue.


Might even be easier to override the existing CI library. I've done this in the past and it worked well.


github还能聊天呢lol


Denne endringen her gjør at det krasjer hvis man forsøker å bruke LR-splines og inhomogene Dirichletbetingelser, fordi arrayet dirich ikke lengre blir satt, samtitig som man forsøker å dereferere siste element i linje 607 under.
Så her må man enten 1) Få tak i rikitg curve objekt for å legge inn i dirich slik det var før (men nå med støtte for mixed også, vil jeg tro), eller 2) Ta bort aksesseringen av dirich under og flagge at projiserte inhomogene dirichlet-betingelser ikke støttes (code > 0).

Dette må fikses for at Lars skal komme videre med sitt Fracture problem med initiell sprekk.


this .idea folder has nothing to do in your repository :/


Also, will this schedule the initial timeout for metadata / listing files? It looks like metadata / listing files will never timeout with this in place...


Should throw if send is unsuccessful?


Good start though. Nice small methods. Shouldn't be too hard to break up.


@akva2 kan du se på det? Usikker på om det var bevisst at curve var tatt vekk her.


👍  Just need to get some tips in there ;)


I take it you had some merge conflicts, hence the reason for 1 gigantic commit?


а можно как-то сконструировать блок из другого блока? у меня ведь есть блок block_filter. если как то определить новый блок `ext_block = {|m| block_filter.call(m) == filters.valuse.first}`, то потом его можно удобно вызывать и передавать.


May want to check the new manifestos vs the "issue" tracker to see if any can be now closed.


replace `tHits` with `cls.tclhits`


nbinsx * nbinsy in the test on bin in findclusters can be replaced with nbins which has already
been computed.


This commit adds `note@oct.ges` for cases when the notes should be played an octave higher than written.

Not much has changed from the last commit.

Humdrum test data:

```
**kern
*clefG2
*M4/4
=1-
16ccLL
16dd
16ee
16ffJJ
16ggLL
16aa
16bb
16cccJJ
16dddLL
16ede
16fff
16gggJJ
16aaaLL
16bbbJ
8ccccJ
=2
16ccLL
16dd
16ee
16ffJJ
16ggLL
16aa
16bb
*8va
16cccJJ
16dddLL
16ede
16fff
16gggJJ
16aaaLL
16bbbJ
8ccccJ
*X8va
==
*-
```

Verovio rendering:

![screen shot 2016-06-23 at 12 40 31 pm](https://cloud.githubusercontent.com/assets/3487289/16318905/e25b6abe-3945-11e6-82db-74ac40b6b264.png)

MEI output from verovio (with the new `@oct.ges` data):

```xml
<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="http://music-encoding.org/schema/3.0.0/mei-all.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>
<?xml-model href="http://music-encoding.org/schema/3.0.0/mei-all.rng" type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?>
<mei xmlns="http://www.music-encoding.org/ns/mei" meiversion="3.0.0">
    <meiHead>
        <fileDesc>
            <titleStmt>
                <title />
            </titleStmt>
            <pubStmt>
                <date>2016-06-23 13:25:36</date>
            </pubStmt>
        </fileDesc>
        <encodingDesc>
            <projectDesc>
                <p>Encoded with Verovio version 0.9.12-dev-b005b99-dirty</p>
            </projectDesc>
        </encodingDesc>
    </meiHead>
    <music>
        <body>
            <mdiv>
                <score>
                    <scoreDef xml:id="scoredef-000000078400812">
                        <staffGrp xml:id="m-000000102961389">
                            <staffDef xml:id="staffdef-000000029742170" clef.shape="G" clef.line="2" meter.count="4" meter.unit="4" n="1" lines="5" />
                        </staffGrp>
                    </scoreDef>
                    <section>
                        <measure xml:id="measure-000000157213255" n="1">
                            <staff xml:id="staff-000000065316603" n="1">
                                <!-- kern: =1-  16ccLL  16dd  16ee  16ffJJ  16ggLL  16aa  16bb  16cccJJ  16dddLL  16ede  16fff  16gggJJ  16aaaLL  16bbbJ  8ccccJ  =2 -->
                                <layer xml:id="layer-000000197254639" n="1">
                                    <beam xml:id="beam-000000188216841">
                                        <note xml:id="note-000000117038017" dur="16" oct="5" pname="c" accid.ges="n" />
                                        <note xml:id="note-000000177686154" dur="16" oct="5" pname="d" accid.ges="n" />
                                        <note xml:id="note-000000080439163" dur="16" oct="5" pname="e" accid.ges="n" />
                                        <note xml:id="note-000000100061796" dur="16" oct="5" pname="f" accid.ges="n" />
                                    </beam>
                                    <beam xml:id="beam-000000044171490">
                                        <note xml:id="note-000000005144065" dur="16" oct="5" pname="g" accid.ges="n" />
                                        <note xml:id="note-000000127467929" dur="16" oct="5" pname="a" accid.ges="n" />
                                        <note xml:id="note-000000023809901" dur="16" oct="5" pname="b" accid.ges="n" />
                                        <note xml:id="note-000000096809393" dur="16" oct="6" pname="c" accid.ges="n" />
                                    </beam>
                                    <beam xml:id="beam-000000141868948">
                                        <note xml:id="note-000000040327536" dur="16" oct="6" pname="d" accid.ges="n" />
                                        <note xml:id="note-000000039072004" dur="16" oct="6" pname="e" accid.ges="n" />
                                        <note xml:id="note-000000197427062" dur="16" oct="6" pname="f" accid.ges="n" />
                                        <note xml:id="note-000000079663180" dur="16" oct="6" pname="g" accid.ges="n" />
                                    </beam>
                                    <beam xml:id="beam-000000157770804">
                                        <note xml:id="note-000000155850599" dur="16" oct="6" pname="a" accid.ges="n" />
                                        <note xml:id="note-000000095228273" dur="16" oct="6" pname="b" accid.ges="n" />
                                        <note xml:id="note-000000196777289" dur="8" oct="7" pname="c" accid.ges="n" />
                                    </beam>
                                </layer>
                            </staff>
                        </measure>
                        <measure xml:id="measure-000000111086565" n="2" right="end">
                            <staff xml:id="staff-000000160784587" n="1">
                                <!-- kern: =2  16ccLL  16dd  16ee  16ffJJ  16ggLL  16aa  16bb  *8va  16cccJJ  16dddLL  16ede  16fff  16gggJJ  16aaaLL  16bbbJ  8ccccJ  *X8va  == -->
                                <layer xml:id="layer-000000127882369" n="1">
                                    <beam xml:id="beam-000000117351949">
                                        <note xml:id="note-000000085235522" dur="16" oct="5" pname="c" accid.ges="n" />
                                        <note xml:id="note-000000181832427" dur="16" oct="5" pname="d" accid.ges="n" />
                                        <note xml:id="note-000000188384353" dur="16" oct="5" pname="e" accid.ges="n" />
                                        <note xml:id="note-000000140690183" dur="16" oct="5" pname="f" accid.ges="n" />
                                    </beam>
                                    <beam xml:id="beam-000000200412014">
                                        <note xml:id="note-000000211379108" dur="16" oct="5" pname="g" accid.ges="n" />
                                        <note xml:id="note-000000066472604" dur="16" oct="5" pname="a" accid.ges="n" />
                                        <note xml:id="note-000000084072342" dur="16" oct="5" pname="b" accid.ges="n" />
                                        <note xml:id="note-000000174374078" dur="16" oct.ges="6" oct="5" pname="c" accid.ges="n" />
                                    </beam>
                                    <beam xml:id="beam-000000034200927">
                                        <note xml:id="note-000000148359513" dur="16" oct.ges="6" oct="5" pname="d" accid.ges="n" />
                                        <note xml:id="note-000000035075820" dur="16" oct.ges="6" oct="5" pname="e" accid.ges="n" />
                                        <note xml:id="note-000000035057403" dur="16" oct.ges="6" oct="5" pname="f" accid.ges="n" />
                                        <note xml:id="note-000000155014571" dur="16" oct.ges="6" oct="5" pname="g" accid.ges="n" />
                                    </beam>
                                    <beam xml:id="beam-000000002746021">
                                        <note xml:id="note-000000196233304" dur="16" oct.ges="6" oct="5" pname="a" accid.ges="n" />
                                        <note xml:id="note-000000202515395" dur="16" oct.ges="6" oct="5" pname="b" accid.ges="n" />
                                        <note xml:id="note-000000129411634" dur="8" oct.ges="7" oct="6" pname="c" accid.ges="n" />
                                    </beam>
                                </layer>
                            </staff>
                            <octave xml:id="octave-000000049906721" staff="1" startid="note-000000174374078" endid="note-000000129411634" dis="8" dis.place="above" />
                        </measure>
                    </section>
                </score>
            </mdiv>
        </body>
    </music>
</mei>
```


Introduction

This second programming assignment will require you to write an R function that is able to cache potentially time-consuming computations. For example, taking the mean of a numeric vector is typically a fast operation. However, for a very long vector, it may take too long to compute the mean, especially if it has to be computed repeatedly (e.g. in a loop). If the contents of a vector are not changing, it may make sense to cache the value of the mean so that when we need it again, it can be looked up in the cache rather than recomputed. In this Programming Assignment you will take advantage of the scoping rules of the R language and how they can be manipulated to preserve state inside of an R object.

Example: Caching the Mean of a Vector

In this example we introduce the <<- operator which can be used to assign a value to an object in an environment that is different from the current environment. Below are two functions that are used to create a special object that stores a numeric vector and caches its mean.

The first function, makeVector creates a special "vector", which is really a list containing a function to

set the value of the vector
get the value of the vector
set the value of the mean
get the value of the mean
makeVector <- function(x = numeric()) {
        m <- NULL
        set <- function(y) {
                x <<- y
                m <<- NULL
        }
        get <- function() x
        setmean <- function(mean) m <<- mean
        getmean <- function() m
        list(set = set, get = get,
             setmean = setmean,
             getmean = getmean)
}
The following function calculates the mean of the special "vector" created with the above function. However, it first checks to see if the mean has already been calculated. If so, it gets the mean from the cache and skips the computation. Otherwise, it calculates the mean of the data and sets the value of the mean in the cache via the setmean function.

cachemean <- function(x, ...) {
        m <- x$getmean()
        if(!is.null(m)) {
                message("getting cached data")
                return(m)
        }
        data <- x$get()
        m <- mean(data, ...)
        x$setmean(m)
        m
}
Assignment: Caching the Inverse of a Matrix

Matrix inversion is usually a costly computation and there may be some benefit to caching the inverse of a matrix rather than computing it repeatedly (there are also alternatives to matrix inversion that we will not discuss here). Your assignment is to write a pair of functions that cache the inverse of a matrix.

Write the following functions:

makeCacheMatrix: This function creates a special "matrix" object that can cache its inverse.
cacheSolve: This function computes the inverse of the special "matrix" returned by makeCacheMatrix above. If the inverse has already been calculated (and the matrix has not changed), then the cachesolvecacheSolve should retrieve the inverse from the cache.
Computing the inverse of a square matrix can be done with the solve function in R. For example, if X is a square invertible matrix, then solve(X) returns its inverse.

For this assignment, assume that the matrix supplied is always invertible.

In order to complete this assignment, you must do the following:

Fork the GitHub repository containing the stub R files at https://github.com/rdpeng/ProgrammingAssignment2 to create a copy under your own account.
Clone your forked GitHub repository to your computer so that you can edit the files locally on your own machine.
Edit the R file contained in the git repository and place your solution in that file (please do not rename the file).
Commit your completed R file into YOUR git repository and push your git branch to the GitHub repository under your account.
Submit to Coursera the URL to your GitHub repository that contains the completed R code for the assignment.
Grading

This assignment will be graded via peer assessment


Can avoid copy here


Closed #4


this one -- should be nbins


From performance measurements, this was the most time consuming call path.


может так: `ext_block = Proc.new{ |m| block_filter.call(m) == filters.values.first }`


This is the second most time consuming call path in performance measurements


This does not belong to the git, keep it in your local copy only. Also I recommend to use `.env.example` for now, e.q. as a symlink.


Great job! I'm assuming `app.set('json spaces', 2)` is used to prevent the render engine error?


Sorry about that! Never thought that this could actually happen when marking out a function.
I will try to use new methods lol, maybe # will solve this issue!


He is probably using a `center()` mixin to center text.


5711-HVAC-sizing-sim-crash (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2259 of 2259 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Could you please log the return value of this syscall (and the other return values as well, if possible).
This is valuable when you don't know the exact host environment. IE: We might be getting thread creation fails and miss it.


shouldn't line 261 be
while ('undefined' === typeof targetel.getScreenCTM && 'undefined' !== targetel.parentNode) {
or it will always assign targetel to 'undefined'?


por que me mejannn


holasss


Consider replacing the value `cluster.move()` with an appropriate list of arguments to the constructor of `Cluster`.


readme


That there's no function:
`ERROR: ccall: could not find function af_get_device_id in library libaf`


weweeeaass


The center() mixin is called the same thing now as it was 24 hours ago:
https://github.com/mojotech/jeet/blob/v6.1.2/stylus/jeet/_grid.styl


It's a way to automatically prettify JSON arrays.


So Unicode 128169 stands for 'Pile of Poo'...

![screwyou](https://s-media-cache-ak0.pinimg.com/736x/5d/1a/ef/5d1aefc5bf10a898aa863c75357f2fb9.jpg)

cc @nacx


Sorry, I meant that for all @abiquo/developers


dunno what this is, but cool.


I'm not seeing why this setValue() approach is better than adding these to the form itself as a #type of `value`. Could you please teach me why it's better this way? (Pointing me to a similar thing in core as an example would be sufficient.)


First commit for #134


@hubte1g Why?


Could be replaced with `std::vector<recob::Hit> const*`.


IIRC optional parameters have a different syntax in Doxygen – please check the Drupal coding standards for this case.


The following doc(s) have been deployed to the [nrprotrou](https://nrprotrou-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/new-relic](https://nrprotrou-static-docs.pantheonsite.io/docs/new-relic)


This variable is unused, please remove.


s/via there/via the/


вот так, например, работает:
```ruby
def select_movie(filters = {}, &block)

      block_filter = @filter_store[filters.keys.first]

      ext_block = if block_filter
      	            Proc.new{ |m| block_filter.call(m) == filters.values.first }
      	          else
      	            block
      	          end

      filtered_collection = if ext_block
                              @collection.select(&ext_block)
                            else
                              filter(filters).collection
                            end
      filtered_collection.select! { |m| m.price <= @money }
      raise "You don't have enough money" if filtered_collection.empty?
      filtered_collection.max_by{ |a| rand * a.rating }
    end
```


5711-HVAC-sizing-sim-crash (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


totalement d'accord


Please use single quotes for string constants.


@m-unkel not corrected.
![2016-06-24_063803](https://cloud.githubusercontent.com/assets/6318282/16319334/3a27c342-39d6-11e6-980e-b4d0939d900e.png)

Защита паролем успешно удалена. - Password protection successfully removed.

My password - 123456.


Whoops, left my bot token in there. Don't worry though, that one's gone. I regenerated. muiro--


Resolves issue #35


Hi Matt,
Can you comment how this was a bug and what this change changes? Using the Rule constructor without an owner will just assign the Unknown owner id to it in the constructor itself afaik. So what should the owner be here?


why you remove the emitter. Adding new items is alway nice.


_Every_ function in a .module file should have its name prefixed with the module name and an underscore. This rule is to prevent having the same function in different modules, which would cause a PHP error.


ASIHPdev3 (shenb) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1673 of 1674 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.77%25-green.svg)


It didn't help :(


Left my bot token in here. It has been regenerated though.


I've noticed the calculations seem a bit unstable for very small areas (such as those tested here). I think adjusting the tolerance is correct here, although we should possibly look at automatically switching to something like
https://www.mapbox.com/blog/cheap-ruler/
for small area calculation.


Maybe `:create, :update, :destroy` as well?


ASIHPdev3 (shenb) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Project/Redemption/settings.py

"""
Django settings for Redemption project.
Generated by 'django-admin startproject' using Django 1.8.1.
For more information on this file, see
https://docs.djangoproject.com/en/1.8/topics/settings/
For the full list of settings and their values, see
https://docs.djangoproject.com/en/1.8/ref/settings/
"""

# Build paths inside the project like this: os.path.join(BASE_DIR, ...)
import os

BASE_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))

CUSTOM_USER_MODEL = "login.UserProfile" #ADDED FOR CUSTOM USER CLASS

# Quick-start development settings - unsuitable for production
# See https://docs.djangoproject.com/en/1.8/howto/deployment/checklist/

# SECURITY WARNING: keep the secret key used in production secret!
SECRET_KEY = '9b+6!!mcgxui(q&ck%r$ohzrhvke)e=szhft49v4au4)e85srs'

# SECURITY WARNING: don't run with debug turned on in production!
DEBUG = True

ALLOWED_HOSTS = []

# Application definition

INSTALLED_APPS = (
    'django.contrib.admin',
    'django.contrib.auth',
    'django.contrib.contenttypes',
    'django.contrib.sessions',
    'django.contrib.messages',
    'django.contrib.staticfiles',
    'home',
    'wiki',
    'login',
)

MIDDLEWARE_CLASSES = (
    'django.contrib.sessions.middleware.SessionMiddleware',
    'django.middleware.common.CommonMiddleware',
    'django.middleware.csrf.CsrfViewMiddleware',
    'django.contrib.auth.middleware.AuthenticationMiddleware',
    'django.contrib.auth.middleware.SessionAuthenticationMiddleware',
    'django.contrib.messages.middleware.MessageMiddleware',
    'django.middleware.clickjacking.XFrameOptionsMiddleware',
    'django.middleware.security.SecurityMiddleware',
)

ROOT_URLCONF = 'Redemption.urls'

TEMPLATES = [
    {
        'BACKEND': 'django.template.backends.django.DjangoTemplates',
        'DIRS': [os.path.join(BASE_DIR), 'templates'],
        'APP_DIRS': True,
        'OPTIONS': {
            'context_processors': [
                'django.template.context_processors.debug',
                'django.template.context_processors.request',
                'django.contrib.auth.context_processors.auth',
                'django.contrib.messages.context_processors.messages',
            ],
        },
    },
]

WSGI_APPLICATION = 'Redemption.wsgi.application'

# Database
# https://docs.djangoproject.com/en/1.8/ref/settings/#databases

DATABASES = {
    'default': {
        'ENGINE': 'django.db.backends.sqlite3',
        'NAME': os.path.join(BASE_DIR, 'db.sqlite3'),
    }
}

# Internationalization
# https://docs.djangoproject.com/en/1.8/topics/i18n/

LANGUAGE_CODE = 'en-us'

TIME_ZONE = 'UTC'

USE_I18N = True

USE_L10N = True

USE_TZ = True

# Static files (CSS, JavaScript, Images)
# https://docs.djangoproject.com/en/1.8/howto/static-files/

STATIC_URL = '/static/'
 Desktop version


I suppose you don't want to do this but rather instead do this:
```C++
socket.write(parser.positionalArguments().join(' '));
```
or
```C++
socket.write(parser.positionalArguments()[0]);
```
I have a full-qualified reason for this but at 10:42pm I'm far too lazy to type it. Just ask when you don't get my point, but I guess it is very clear what I mean.


Aw man I just did this exact same thing on my computer.


Ups, that was a mistake.


@x1024 every `center` in my project is replaced with j-center.


@sraue @lrusak this may be useful to you, too.


```
    &.-background-split {
        position: relative;

        &-teal-red {
            background-image: url("../images/svg/background-split-teal-red.svg");
            background-position: top center;
            background-size: cover;
            background-repeat: no-repeat;

            +below($tablet) {
                background-image: none;
            }
        }
    }

```

```
.-background-split-teal-red {
  background-image: url("../images/svg/background-split-teal-red.svg");
  background-position: top j-center;
  background-size: cover;
  background-repeat: no-repeat;
}
```


Sure — UNKNOWN_OWNER is a String, so the constructor that gets called is [this one](https://github.com/apache/incubator-joshua/blob/master/src/main/java/org/apache/joshua/decoder/ff/tm/Rule.java#L157), which interprets the last argument as an alignment, not an owner.


great minds think alike? 😛


what is `s`


But, seriously - is there a way to tag which issues we're actively working on?


Variable is of type int.


Could `tjs` be const?


@jpolitz, @sarahkf: this one's debatable.  Do we want to have single-field tuples?  I was hoping to reserve the syntax `LBRACE expr RBRACE` for other purposes...


Consider making the body of this loop a function that gets called with the right arguments. Then it is easier to understand, and also easier to try alternative implementations.


Someone made a book with just king and pawn positions.  That might accelerate your local tuning: https://www.dropbox.com/s/6d27587rngdgfu4/2moves_v1_less_pieces.zip?dl=0

I have tried several hand tunings:
 const int KingCentral[FILE_NB][RANK_NB] = {
    { -5, -4, -3, -2, -2, -3, -4, -5 },
    {  0,  1,  3,  5,  5,  3,  1,  0 },
    {  4,  4,  5,  6,  6,  5,  4,  4 },
    {  2,  3,  3,  5,  5,  3,  3,  2 },
    {  0,  1,  3,  5,  5,  3,  2,  1 },
    { -1,  0,  2,  3,  3,  2,  0, -1 },
    { -3, -1,  0,  0,  0,  0, -1, -3 },
    { -5, -4, -3, -2, -2, -3, -4, -5 }
  };

And
  const int KingCentral[FILE_NB][RANK_NB] = {
    { -5, -4, -3, -2, -2, -3, -4, -5 },
    { -3, -1,  0,  0,  0,  0, -1, -3 },
    { -0,  1,  3,  5,  5,  3,  1,  0 },
    {  0,  1,  3,  5,  5,  3,  1,  0 },
    {  0,  1,  3,  5,  5,  3,  1,  0 },
    { -1,  0,  2,  3,  3,  2,  0, -1 },
    { -3, -1,  0,  0,  0,  0, -1, -3 },
    { -5, -4, -3, -2, -2, -3, -4, -5 }
  };

are the best so far.  Testing at 5,000 to 9,000 games.

Really though, there should be two of these grids one for when we have advantage and one for when we are behind.  When we are ahead we want to be near the 6th rank more often.  When defending we want to be on our third rank more.

And I sort of had a test that supported that hypotheses.  I tested against weaker engines and when I had more weight on the 6th rank and it won more and drew less than using either the master or your first weights.  If it is playing a weaker engine it is more likely to have advantage...so that increased weight of the 6th would be more likely to help.


@ferchofpz because we don't require sorting in the location table. With auto-increment in WeatherEntry each row which represents a day will have consecutive nos. that can be easily sorted.

For others first of all understand why we are doing some ninja work with the API key. It is for preventing accidentally putting file under version control and then pushing it to sites like github where then anybody can see your API Key(big T&C violation).

so in the second step given by @rhtsjz you need to put the line in **global** Gradle properties file i.e. in `[HOME]/.gradle/gradle.properties` (create it if it doesn't exist). Now your API key is safely out of your project and you can't include it in version control even by accident as its completely out of the repository.


It was assigned to Justin. So a) don't work on something that's not assigned to you, or b) if you want to work on something not assigned to you, change the assignments.


or c) pop up in the gitter chatroom and ask if anyone is working on it, and then do b)


DELETE resolv by ceasear code.


Oh shit. No need to apologize - it's just threw an error when I pulled and wanted to make sure you were aware. You're misunderstanding me - I'm not saying to not index titles and only index text blocks. **I'm saying we should index titles at a higher priority (or `boosted`) and also index the text blocks.**


good that we chat about :)


@DRickard Please use $VGER_JAVA instead of hard-coded path - that way, if we need to change things, we only need to update voyager's `.profile.local` instead of every script.

```
voyager@wells:voyager => env | grep VGER | sort
ORA_LOG=/diag/rdbms/vger/VGER/trace
ORACLE_SID=VGER
VGER_BASE=/m1/voyager
VGER_BIN=/m1/voyager/bin/2009.1.1
VGER_GIT_USER=akohler
VGER_JAVA=/usr/local/bin/voyager/java
VGER_PERL=/usr/local/bin/voyager/perl
VGER_SCRIPT=/usr/local/bin/voyager/scripts
VGER_UTIL=/m1/voyager/utility/2009.1.1
```


Name should be prolly `$allowedPatchOperations` or `$applicablePatchOperations` and the usage of the reserved keyword `USE` will be problematic, I suggest `APPLY` instead.


ASIHPdev3 (shenb) - x86_64-MacOS-10.9-clang: OK (2226 of 2227 tests passed, 553 test warnings)

 * 554 tests had: AUD diffs.
 * 1 test had: EIO diffs.
 * 1 test had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: Table big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.96%25-yellow.svg)


No worries. Python it is then.


>tfw you commit but you don't compile beforehand


no, nothing
![image](https://cloud.githubusercontent.com/assets/1320709/16319940/ee012da8-395a-11e6-85b0-10f99c06b36f.png)


@chilijung  What was the reason for removing the zoom behavior? My attempts to use LineZoom have been failing in the master branch and currently I don't see the onZoom prop being called within d3-core anymore


Prolly use just a _single_ patch document instead of several coming from the data provider.


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1685 of 1685 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ah, right! Thanks! Should have looked more closely.


For maintenance, it would be better to always use the smallest scope possible for the variables instead of reusuing them.


It could potentially be because of `libaf` is from an older version. An older `libaf.so` can still pick up newer `libafopencl.so` Can you make sure you don't have multiple versions installed on the system ?


No problem, it didn't get triggered until I had a small case where I actually asked for the alignments on output.

I suppose we could also have fixed this by passing UKNOWN_OWNER_ID, we can switch it if you prefer.


s/Removes and/Removes the/


spring classes added


s/find changes/find the changes/


used[] is used many places -- you could make a linked list of bins that doesn't have to be checked and has entries removed when they are used just to organize this loop, but still maintain used[] for downstream use.


Create a struct type in Go that holds an unexported C.struct_sol_timeout, and use that as the handle type instead of interface{}. With this you get typechecking of those things for free (no problem passing wrong handle to the type when calling remove).


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Looks good!


@PatrickHeneise we just released Snyk@1.16.0, which uses a custom npm package instead of this repository. Can you see if this addresses the problem?


@sarahkf ping on the comments above.  Another comment: why is there a trailing `SEMI` on `tuple-binding`, after the `RBRACE`?  That seems odd to me, could you elaborate?


Please take a look at #482
I tested the stylus code, and it seems to work.


Because the user of intrinsic functions can only be direct calls or invokes. Adding a intrinsic function (like llvm.memset.p0i8.i32 in InitAllocas.cpp) to llvm.compiler.used will cause a assertion fail.


I see the `#workaround` comment on some code below. Was this change of `synced_folder` wanted or it was mistakenly added?


Hi @laa-1-yay ,

I think appropriate place for this will be dagger's AppModule (we can wire-up PicassoProvider there as well)


The following doc(s) have been deployed to the [1674result](https://1674result-static-docs.pantheonsite.io/docs) Multidev environment:
- [source/_views/doc.html](https://github.com/pantheon-systems/documentation/commit/d01f70fde40f76c166ce4594d7fd9418db9c9f8c/source/_views/doc.html)
- [source/docs/assets/css/main.css](https://github.com/pantheon-systems/documentation/commit/d01f70fde40f76c166ce4594d7fd9418db9c9f8c/source/docs/assets/css/main.css)
- [source/docs/guides.md](https://github.com/pantheon-systems/documentation/commit/d01f70fde40f76c166ce4594d7fd9418db9c9f8c/source/docs/guides.md)
- [source/docs/search.html](https://github.com/pantheon-systems/documentation/commit/d01f70fde40f76c166ce4594d7fd9418db9c9f8c/source/docs/search.html)


dipshit you removed the actual fix -.- export EXPERIMENTAL_USE_JAVA8=true would have done the same thing and not look bad too


Timing measurements show most time taken by `push_back` on `std::vector<double>`. Suggest calling `reserve`.


I'll check the case but the alignment was wrong because the no-gutter removes spacing between grid cells


maybe another time...


Can you lint this David? Run `npm run lint-js` or `eslint js/components/manifest-detail/trunacte.js` to see the formatting errors. I think your text editor is way over-indenting.


Nope, totally manual!
It follows [angular js git commit conventions](https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit)


tutorial django rest framework


TeamCity Test Project :: Test Build [Build 250](http://127.0.0.1:8111/viewLog.html?buildId=252&buildTypeId=TestProject_TestBuild) outcome was **SUCCESS**
Summary: Success Build time: 00:00:00
Artifact size changes:


TeamCity Test Project :: Test Build [Build 251](http://127.0.0.1:8111/viewLog.html?buildId=253&buildTypeId=TestProject_TestBuild) outcome was **SUCCESS**
Summary: Success Build time: 00:00:00
Artifact size changes:


TeamCity Test Project :: Test Build [Build 252](http://127.0.0.1:8111/viewLog.html?buildId=254&buildTypeId=TestProject_TestBuild) outcome was **SUCCESS**
Summary: Success Build time: 00:00:00
Artifact size changes:


TeamCity Test Project :: Test Build [Build 253](http://127.0.0.1:8111/viewLog.html?buildId=255&buildTypeId=TestProject_TestBuild) outcome was **SUCCESS**
Summary: Success Build time: 00:00:00
Artifact size changes:
art253: New Artifact


5711-HVAC-sizing-sim-crash (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1109 of 1109 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-34.43%25-green.svg)


The following doc(s) have been deployed to the [1692sitet](https://1692sitet-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/user-dashboard](https://1692sitet-static-docs.pantheonsite.io/docs/user-dashboard)
- [source/docs/assets/images/pantheon-user-dashboard.png](https://github.com/pantheon-systems/documentation/commit/6d79689d80636fb325b4b3e54c57bfd1caebb398/source/docs/assets/images/pantheon-user-dashboard.png)
- [source/docs/assets/images/pantheon-user-dashboard1.png](https://github.com/pantheon-systems/documentation/commit/6d79689d80636fb325b4b3e54c57bfd1caebb398/source/docs/assets/images/pantheon-user-dashboard1.png)
- [style-guide.md](https://github.com/pantheon-systems/documentation/commit/6d79689d80636fb325b4b3e54c57bfd1caebb398/style-guide.md)


Perl and PHP reference, I went there!


Will do.


Add Mikrotik Sysupgrade support


@ckingdon95 That is a good idea. Can you do this? Just use the sha of the current commit in fund.jl here. Let me know if this is unclear.


I was about to comment on the commit that removed this that the C code is definitely used - e.g. see

```
#define MODELFCT1D_NOINT(name, npars) \
  _MODELFCTSPEC_NOINT(name, modelfct1d, integrated_model1d, npars)
#define MODELFCT2D_NOINT(name, npars) \
  _MODELFCTSPEC_NOINT(name, modelfct2d, integrated_model2d, npars)
```

in `sherpa/include/sherpa/model_extension.hh`, although it wasn't clear to me if the Python interface to this code was needed (although I was going to suggest keeping it as it may be useful for template models).

But now I don't have to, as you've added it back!


No, I used Homebrew to install and that was it.


FMI, what does 'exec docker run' do?


Suggest seeing if the algorithm can be reworked to recalcuate the quantities presently being held in `x`, `y` and `w` since the vector growth is taking significant time.


Ooops xD


This one should probably also say "I _have_ ..."


It is kind of confusing that there is a python extension not used as such but imported in another extension.


Was just going through the dj-stripe fork network and noticed this... you'll want to rotate your keys if you haven't already --  a live secret key out in the open is not exactly safe :)


Consider adding something like "This is just a checklist to remind you of the steps to take when opening a new PR."