[Your benchmark job](https://github.com/JuliaLang/julia/commit/dffc06865e647bbbdfed9be0f04d7430ac94dd1c#commitcomment-18332500) has completed - possible performance regressions were detected. A full report can be found [here](https://github.com/JuliaCI/BaseBenchmarkReports/blob/f8b7265d2981b7c2eea60e419e1479e5c99a3b33/daily_2016_7_21/report.md). cc @jrevels


It's Awesome that you are using enum for the maintaining the Direction

-> It would be greate if we can use "PlaceHolderDirection" instead of just direction
-> It must be start with UpperCamelCase, because its a name of CustomDataType :) not a name of literal or identifier

-> I think no need to Use String value type, we can directly compare cases
So,
```
enum direction: String {
    case Up = "up"
    case Down = "down"
}
```
will become
```
enum PlaceHolderDirection {
    case Up
    case Down
}
```


Get Rid of CNAMe


cool!!!


pls delete


126735005-AdaptiveThermostat (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (2240 of 2241 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.96%25-yellow.svg)


Please fix the indention and coding style.


No empty spaces on empty lines.


Instead of using UIImageView we should use UIView,
Because UIImageView is derived from UIView, so super class is always lighter in nature.


Why you have added empty spaces here?


foget password


One empty line is enough.


```scala
0 until queue.totalSubscribers foreach { subscriberId =>
```


Do we have any specific reason for overriding internal property `text` ?


Comment should be more descriptive, e.g. Looks for column n in an hash index.


7/21/16
1:09 am
email kawb2003@gmail.com
1036091029


夏イベは轟沈させないでね；；


No empty lines after last statement of the function.


7/21/16
1:22 am
email kawb2003@gmail.com
1036091029


Humm, I am trying to understand why anything even got changed in that file. It shouldn't have any changes, I will reset it.


not sure if this is the best way, but it did work.


haha, huhu, hihi,
sory sory i dont think sufficient


Why you use negative position numbers?


It doesn't and I should have it deleted from the commit. It was just a local change so I could get vstart.sh to work. I will fix that one).


Hello allen
Dit zijn de eerste stappen in het gebruik van git hub.


is `installed` the json report's way of saying whether or not a formula is installed?


so testers don't have to code product forced-consumption.


Delete CNAME


Again, remove spaces.


yep. I will get rid of it. It shouldn't be part of the commit and I didn't realized it.


Indention style!


File containing the main class.


You should add empty line before return, not after.


Still missing these changes:
1. Remove bbcode from description ([b][/b],[img ][/img],[color][/color], etc..)
2. Remove Blank space between paragraph (paragraph1               paragraph2)


Shouldn't this be E_ASSETREMOVED? I see a bit lower down the event used for move is E_ASSETMOVED


The semantics are OK. But this means we need to transport the commit index in case of a stream. What if we miss a commit index? The subsequent commit will advance the index overwriting the missing commit, right? We need to think this over very carefully.

This one was more of a comment for the commit design up top.


True. I just wanted to be *consistent* everywhere. I will get it checked.


Please indent this condition to make it more readable.


Outstanding todo


:D


instead of creating this function we can use the `didSet{}` or `willSet{}` of the property `enableMaterialPlaceHolder`


Try to maintain InnoDB coding style.


@JBYoshi don't spoil the joke 😅


Why 3 empty lines?


good


We had changes in so many options (all from OPT_INT to INT_U32) and some many changes like this, I wonder how much of rework that would require.


Lo siento no cambie la descripción de phpStorm pero corresponde al anterior commit


Original style is correct, changed not.


Dear Antonio and Tiago,
Is the GDC-related functions included in this updated version? And can I use the code: "devtools::install_github(repo = "BioinformaticsFMRP/TCGAbiolinks")" to install this updated version?
Sincerely,
Zin Wong


A complete proof:
Assumption: max release needed=3

For need k release, k monster is always an exact solution {1,1,...,1}
I only list the sets with sum greater or equal than needed

A. The original model (each monster can be 1 or 2)
need 1: the range is 1~1 monster
Available

need 2: the range is 1~2 monsters
1 monster: {2}
Available

2 monsters:
Available

need 3: the range is 2~3 monsters
2 monsters: {1,2}, {2,2}
Available

3 monsters
Available

B. new model (each monster can be 1, 2, 3)
need 3: the range is 1~3 monsters
1 monster: {3}
Available

2 monsters: {1,2}, {1,3}, {2,2}, {2,3}, {3,3}
The system will accept {1,3}
Failed


One empty line is enough.


Dead code


Here and below correct style is: } (space) else (space) {


we can override the internal property `placeholder` as we did for the `text` in above code
and we can use `didSet{}` or `willSet{}` of the property


@lbdBG Looks like you had a Lua Uppercase Accident.


Shall we have a separate "committer.idx" or just use the "tailer.idx" as the commit index?


Here and below, add descriptive comment why we need to do rebuilt.


Style!


Why you added this here?


The Committer is very much associated with the `PersistentQueue`.

1. We probably want to keep it in the same file.
2. We may also want to make it a member of `PersistentQueue`.

The Committer has no standalone context, right?


InnoDB does not much use MySQL DBUG_ASSERT macro instead ut_ad() for debug asserts and ut_a() for product asserts.


I had it added, just in case we needed to get it from unsigned to signed (which worked pretty well), but:
1) I wasn't even sure if that would be the best place to have it
2) We ended up not using it (at least for now).


Browser support coverage of  `infiniteGrid` is IE7+. So I thank that It not working.
http://naver.github.io/egjs/latest/doc/eg.InfiniteGrid.html


Yes.  Eventually I will remove this `json` object checking completely I think, I'm just trying to be over cautious.


If you're interested in seeing the source code let me know, though I will warn you in advance that it's not too pretty.


For long function parameter lists, I suggest following style:

mem_heap_alloc(heap, (old_table->n_cols +
                                           old_table->n_hash_cols) * sizeof *col_map));

i.e. next line starts from last (


Yes, that is the purpose of this class. I think using static data can be useless here, we can just load the data from configuration file and directly create OperationProcessor object which will start to work.


eliminando el file .apk


Please check the above comments and correct me if I understood the concept in the wrong direction. Feel free to write a comment under my comments, so we can improve the code. :)


Perfect. the MITM bump fixes my issues on Android. Thanks a million!


good


eliminado


We decided to not use `hasOwnProperty`. Is it exception case?


Why wasn't the lock file updated for this as well?
As for today, we face problems when we trigger composer update or try to install another package (as being forced to update).


do you get any feedback from this? swallowing errors is a good way to hide typos...


Style, InnoDB uses braces also on one line statements on conditions.


这里需要增加 </a> 结束。


Indention style: use tabs not spaces.


Seems a bit extreme that the whole file has to be read for the hash and will be re-read for importing, not that I have a better suggestion right now :/


I think that `HTMLElement` is undefined in IE7~8?


:+1: on adding the change hostname section, @StefanScherer


licensing wording is now an issue


Delivery Status:
----------------
|Verify|
|:--|
||
||
||


@hieulq : may be, I was mistaken. I saw those configs in config file, It is not necessary for client.Client() . I will complete NetworkDriver as soon as.


Remove extra empty line.


Function parameter list indention not correct.


whileのsubprocessでapt-getが走ると、並列実行されてしまうことがある模様。


Remove extra empty lines, one is enough.


Where are you taking user input?


Here and below, remove extra empty lines.


Merged


public class


Why this line is marked as changed ?


Empty line not needed.


Well, I did allow one to specify a desired capability (in Java) to force the usage of the old driver. And here one can pass an argument in the constructor to fall back if desired


`brew rm` will print out an error containing the package name.  It looks like this:

```
Error: No such keg: /Users/sabae/.julia/v0.4/Homebrew/deps/usr/Cellar/thisisntapackagename
```


Dead code


This is a specific method for this sample only.


Perhaps a better way to serialize may be to store individual blobs in files with hashes as their filename?

Crazy thought: It may help IPFS integration.


124975981-Outside-Movable-Insulation-Absorptivity-Issue (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


`map` support IE9+.
http://caniuse.com/#search=map


You could add empty line before if.


Indention!


missing brace


Shouldn't need the "desktop" layer. That is in other config files for things that would need different behaviours based on target platform. For this tool you should only need on or off regardless of project target platform(s).


Just looks really immature and unprofessional.

_To elaborate on what happened..._

- You ended up arguing with another team over _THEIR_ server.
- You got blocked from the repo, because past being told by several team members that this wasn't how it was setup for their team, you continued to insist and pollute the issue ticket.
- I'm not saying it was approached appropriately from either side, but noone from Genisys comes over and argues over your commits or approaches to issues on your repo.

This coming from a fly on the wall, I joined the team after to help, hopefully to prevent nonsense like this and to maintain a level of maturity, sanity and objectivity.

I remain objective to this situation; there's point in life where one must hold poise and respect the opposition whether you agree with them or not.  The content in your readme is hardly respectable though and reflects poorly on your team and yourself.  I just thought you should know that.


I'm not really against having names in the file but we standardized against the practice 😄

While there are many reasons open source code usually does not have names (your name will be in the commit forever), I have a very personal one of a very close friend of mine. She was the original author of a script in a well known benchmark suite and left her name in the script, dated 1980. Around 2005, we had a big group meeting here in the valley and all team members were flown in from around the world, including some of our new team members from Bangalore. When we met, one of our guys from Bangalore said: "Oh, you are <name erased for privacy>! I've seen your name as the author of our script. It's dated 1980. You know, I was in 4th grade at that time!!! Ouch, tells you how old you are.


124975981-Outside-Movable-Insulation-Absorptivity-Issue (RKStrand) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


错误提示文字easywechat自身没有处理是吧？


路径变了


good enough I guess


124975981-Outside-Movable-Insulation-Absorptivity-Issue (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


@craigulliott Sorry about that, I’m sure it took a while to figure out. And thanks for the note.


124975981-Outside-Movable-Insulation-Absorptivity-Issue (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


124975981-Outside-Movable-Insulation-Absorptivity-Issue (RKStrand) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


没有，它如果遇到错误的话是直接抛异常


Accepted


i added those for a reason!


Any idea why this test could be failing sometimes?
https://travis-ci.org/qgis/QGIS/jobs/146287260#L1009-L1011


Thanks!!!


@mehalshah I've confirmed that reverting this change and the same check immediately below fixes the regression in which a LevelGroup page which had no answers filled out had a white dot instead of a purple dot after the level was submitted.

It's probably due to the subtlety that such a page has no result value in the summary info, as set up at https://github.com/code-dot-org/code-dot-org/blob/staging/dashboard/app/helpers/users_helper.rb#L175, and rendered to the puzzle page at https://github.com/code-dot-org/code-dot-org/blob/staging/dashboard/app/views/layouts/_header.html.haml#L67

Indeed, I validated that the page demonstrating the issue had the following, with a white dot instead of a purple one for 4184_1:

        "4184": {
            "status": "submitted",
            "result": 100,
            "submitted": true,
            "pages_completed": [-50, null , -50]
        },
        "4184_0": {
            "result": -50,
            "submitted": true
        },
        "4184_1": {
            "submitted": true
        },
        "4184_2": {
            "result": -50,
            "submitted": true
        },


メソッドの分割、例外の処理変更等を行いました。


InfiniteGrid supports IE8+. I will correct API doc. thanks
and I already fixed it. Could you see this [link](https://github.com/naver/egjs/pull/292/files)


Note that there is a *opt-in* mechanism for skipping about 90 slow tests: set the environment variable SKIP_SLOW_TESTS.


TeamCity ReOpenLDAP :: devel [Build 288](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=2575&buildTypeId=ReOpenLDAP_Devel&guest=1) is now running


Thanks for comment hitendra. I will check nd will update soon possible.


Quite nice! This can be used instead of `0 until subscribers map { i => ...}`


Ah I see now.


It is correct because msgid is the human readable English tag (which must be 'Raspberry Pi'). The one thing that can't change is the machine name blackberryPi. If we regenerate the new PO file template using Drupal, you will get the above also.


You're right. and forEach is supported on IE9+
We will discuss this issue.


:+1: :+1: :+1:  = 1000


ok thanks~


I'd use the `._1`, `._2` notation only if it is real simple code. Otherwise I'd would use case extraction. Makes the code a bit easier to understand.

```scala
out.zipWithIndex foreach { case (o, i) => setHandler(o, outHandler(o, i)) }
```


I had that implemented for Ruby, but then when I tested it and saw how much was failing, I took it out. I'm pretty comfortable with taking the stance that MacOS requires Apple's safaridriver.


why would we need to double check the `opt->name` and the value to be set? we should have found the opt by checking the args. see `md_config_t::parse_option()`.


i assume you will remove the changed code before sending the PR, right?


126735005-AdaptiveThermostat (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2275 of 2275 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


到這一個綠燈之後，可以考慮重構了。

因為已經出現三個重複的商業邏輯，if/else if 的關鍵差異只有決定 discount 的算法。


Dead code


126735005-AdaptiveThermostat (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


~sss~


OK, I missed that you have changed the template as well.


Looks good. I remove the ```type``` variable in ```main.cpp``


maybe we can add it back once we need it?


could you add that to the testing wikipage? https://github.com/beetbox/beets/wiki/Testing


What error did you encounter? @omkarmoghe


Function C(latest)


Just simplifying a bit:

```scala
        pending.zipWithIndex foreach { case (isPending, subscriberId) =>
          if (isPending) {
            queue.dequeue(subscriberId) foreach { entry =>
              val index = queue.index(subscriberId)
              pending(subscriberId) = false
              push(out(subscriberId), Event(subscriberId, index, entry))
            }
          }
        }
```


It might worth adding indexes for any and all combination of fields we're using in WHERE clauses, for speed reasons.


On symfony 3 it produces `Unknown "form_enctype" function`


Still need to discuss the commit API and mechanism. But we're very close here.


It might worth adding the other field-specific comment_alter setting here, too: the "hide this field's changes" one.


You're supposed to start throttling *after* the `req->bodyBuffer.feed` call.


I know it is in the wrong folder. I'll move to the right one when I have a working version.


i understand, maybe you can split them into smaller batches? the reasons why i'd recommend smaller commits are

1. for bisecting a regression. if a change involves, for example, only 2 conf vars fails a test, instead of reverting all the changes, we can just revert that one.
1. for helping the reviewers, for example, if i was a developer focusing on rgw, what i need to check is just the commits related to rgw option changes.


You probably want to rename this to `deleteBuffer` as opposed to `deleteElements`.


The order of these two lines is a bit ambiguous for me – but it looks like this will be cleaned up in a later commit anyway.


Also, by convention, if a noArg method has side effects, we add an empty paren. So it should be `deleteBuffer()`.


I give an example below. If you have just a plain query picking up an object by id, and the mutation returns an updated object with the same id, it would be updated in the store automatically.

For the new object, yeah. I can't come up with a good example.


I thought it could be done by listening on the console's keypress, much like it's done with tabs (that way you'd only tab around if it was focused and input was given)


Just for the sake of commenting, you could have written this as a Scala object. No need to change, though.


On my mac without these lines it was ignoring the correct path reported by the pkg_config tool in the $PC_SDL2_INCLUDE_DIRS variable (/opt/local/include/SDL2) and instead using the header files from the SDL1.2 framework (/Library/Frameworks/SDL.framework).

This needs some further testing to make sure I haven't broken linux etc. If so, we can simply repeat the check but without the NO_DEFAULT_PATH setting (it will ignore this repeated check if the libraries were found already).


Ah, now I remember. It wasn't `git add .`, but git add `tests/`. That's why they made it into Git. Stupido.


I couldn't come up with a good wording to show that the latency is significant, without adding too many words or clauses that complicate the sentence. Maybe edit this paragraph with your suggestion?


super, malo je tricky jer je "or". Inace u pravom zivotu, kad imas optional nikad ga nemoj force unwrapati! (zato je i optional) jer moze biti da bude nil i onda ce ti prokinut aplikacija. uvijek gledaj da ga guardas, ako je bas nil onda ga handle u else ili try-catch


Unused vars


#5629-ChillerElectricEIR-AirCooled-condenser-outlet-node-conditions-not-correct (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1683 of 1683 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.01%25-green.svg)


Should "phpunit/phpunit": "^5.4", be under "require-dev"?
"monolog/monolog": "^1.20" Also calls the above as a "require-dev" dependancy


Shouldn't this be an error or at least a log? Why is this getting messages if not receiving?


There is no `$entity` variable here.


@zsxwing would you be willing to commit your `AkkaStreamSuite` to [https://github.com/apache/bahir/streaming-akka/...](https://github.com/apache/bahir/tree/master/streaming-akka/src/test/scala/org/apache/spark/streaming/akka)?

- You could either commit it yourself since you are one of the [Bahir committers](http://bahir.apache.org/community-members/), or,
- I could prepare a PR with you as the commit author and PR co-author.

It would be nice to have this in the first Bahir release. **Thanks for your help!**


Rather check != in an if and early out.


testing


There is no `$subject` variable here.


Determining what gets KeyPressed in Chili is messy because something weird may be focused. chatWindows.visible limits the toggling to when the chat tab is open.


Yes, you can. For now you need to do

```
EndingBoundary *endingStart = new EndingBoundary();
endingStart->SetN(1)
m_system->AddEnding(endingStart);
// then add the measure(s) for the first ending to the _system_
m_system->AddMeasure(measure)
// close the first ending with another boundary
EndingBoundary *endingEnd = new EndingBoundary(endingStart);
m_system->AddEnding(endingEnd);
```

This is because in page-based MEI, endings have to be turned into milestones elements and cannot be a container (the ending contents can be spread over several systems).

However, I would like to change this to something better for the MEI input, which should also be easier for importers. The idea is to load (or create) score-based MEI and then to have a method for converting it to page-based afterwards. This will be more robust than converting while reading. So it will be.

```
Ending *ending = new Ending();
ending->SetN(1)
m_system->AddEnding(ending);
// then add the measure(s) for the first ending to the _ending_
ending->AddMeasure(measure);
```
And then after the import call
```
doc->ConvertToPageBased()
```

I will do it today or in ten days...


added version of user-provided hadoop


Any chance of repetition? If so check if this fragment is already obtained and don't inc bytesReceived_


這樣API的設計是糟糕、沒有彈性的。開不完的API。


Spacing: we can fix it, but you should also fix your encoding first ;-) The repeat bar line should be placed at the end of the second measure of the first ending.


為什麼 method name 會是 195? 但測試案例的內容是 190?


should this be "dashpay/bitcore-build-dash" ?


糟糕的API設計，土法煉鋼。


OK.


作業規定的部分，紅燈、綠燈應該要分開 commit


why should buildServer's be normalized? why test for buildServer != null to determine normalization?
(https://github.com/GitTools/GitVersion/issues/942)


Hi,

When i open this `http://www.hindustantimes.com/india-news/rss-didn-t-kill-gandhi-but-created-an-idelogy-against-him-historians/story-1ZsqUJDoV3jvDPn1RIPNKJ.html` on PC and mobile then its says "To continue reading, we request you to support us by disabling your Ad Blocker"

Please check and fix this problem


To sort
On Jul 21, 2016 11:15 AM, "Anup Kumar Panwar" <notifications@github.com>
wrote:

> Where are you taking user input?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/TheAlgorithms/Python/commit/b1b4bdaecddde492a9cca441b9c236ba16ee1d01#commitcomment-18333311>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ANtCTZeOkADvLMnTYqsyMA1zLrjiEFH1ks5qXwd0gaJpZM4JRdv5>
> .
>


if this is static and final, it will only be instantiated once when the class is loaded. This means that as long as the application is not restarted, the comparison will be done against the initial time. For testing purposes it is ok.


da li bi ovo mogla napisati sa guard i if let i ubaciti u switch statement sa fallthrough?


This stats the blob in the target repository. However, the stat needs to be done in the source repository.


Just added the repeated checks as mentioned above.


Thanks for fixing.


consumed() is not supposed to be used with a zero consumption size. You should use req->bodyChannel.stop() and req->bodyChannel.start() instead, which are designed for what you meant to do.


thank you for the suggestion. I have included `nightly` again


Adding initial readme


@Shelob9  - look at a later commit, I already removed it. Was more an additional test, javascript still verified it. But removed it already.


Not seeing data buffers getting deleted. VectorBuffer doesn't appear to use a SharedPtr, how/when are they destroyed?


@jrderuiter there was no reason. This was in an effort to remove the OSX whitelist. So I included the skip and removed the whitelist, so that every new package will be build on OSX by default. The idea was to incrementally now fix all old packages and build them on OSX as well.


ovdje ti se ponavlja super.introduction() + "I' m a student at \(faculty). My favourite course is " + attendingCourses.first!.aboutCourse() + ...

to bi bilo dobro izdvojiti na pocetku, kako bi recenicu mjenjala samo na jednom mjestu, ovako je mjenjas na 4


Const this in the header, with a comment explaining the delay


It was supposed to be `$this->entity->id()`.


Yeah its not required.


@carolinan As now the check is working correctly. We should be able to change it from WARNING to ERROR. What about changing the message too `$phpcsFile->addError( 'The title tag must not be used. Use add_theme_support( \'title-tag\' ) instead.', $stackPtr, 'NotAllowed' );`

You can also create a PR.


这里的话 traffic 的单位应该是 Byte 吧，那么我觉得应该是
```
       def trafficShow(self,Traffic):
		if Traffic<1024 :
			return str(round((Traffic),2))+"B";

		if Traffic<1024*1024 :
			return str(round((Traffic/1024),2))+"KB";

		return str(round((Traffic/1024/1024),2))+"MB";

```


折扣不是循序 5% 的遞減，這個在需求說明時有特別強調。

不要為了看起來只有一行而去調整它，因為這也是一種浪費。


ostalo je ok. vidim da se trudis sto je pohvalno

molio bih te jos samo, ako vec radite u wipu da commitate playground na git a ne da radite upload text filea


[VintageCaterers 2.zip](https://github.com/chinkugoyal/ProjectsIOS/files/375281/VintageCaterers.2.zip)


MoreDaylightingSensors (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (2226 of 2241 tests passed, 544 test warnings)

 * 556 tests had: AUD diffs.
 * 29 tests had: DXF diffs.
 * 29 tests had: RDD diffs.
 * 8 tests had: Table small diffs.
 * 2 tests had: ERR diffs.
 * 3 tests had: EIO diffs.
 * 12 tests had: Table big diffs.
 * 1 test had: MTD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.33%25-yellow.svg)


這個 foreach 可以直接改成 `var additionalCount = order.Count(x=>x.Quantity > 1);`


126735005-AdaptiveThermostat (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1123 of 1123 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-34.78%25-green.svg)


126735005-AdaptiveThermostat (mjwitte) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


>```
Ending *ending = new Ending();
ending->SetN(1)
m_system->AddEnding(ending);
// then add the measure(s) for the first ending to the _ending_
ending->AddMeasure(measure);
```

That looks good, I tried exactly that before looking into ending.cpp to see that it is not implemented yet :-)

> Spacing: we can fix it, but you should also fix your encoding first ;-) The repeat bar line should be placed at the end of the second measure of the first ending.

Aha. I was cutting and pasting and did not notice that the repeat barline was displayed from the endings.


Dead code


直接寫` Count(x.Quantity >= quantity);` 就可以省掉 Where()


@adiraomj you can see [my comment](https://github.com/siteorigin/siteorigin-north/pull/177#discussion_r71654797) for how we should be handling this custom CSS for the menu breakpoint.


- This commit is not perfect in every cases.
- I just wanted to resolve the issue below:
  - [[HIVE-9233](https://issues.apache.org/jira/browse/HIVE-9223)] HiveServer2 on Tez doesn't support concurrent queries within one session


Yes, you are absolutely correct. Thank you. I will work on that.


Quickly threw together some panels and buttons the get the initial shape of the UI down. None of the buttons do anything yet, but the layout is there at least. The buttons all have accessor methods so we will be able to attach the actionListeners when we are ready for them.

I also modified the .gitignore to ignore some metadata folders that Eclipse uses.


70 SCNs


21/07/16
CHANGES HAVE BEEN MADE TO network3.py FILE.
Run files have been added to easily execute the code


No cleanup of file if object destroyed before completion, will the file handle close automatically on destruction?


Do you mean the `createNewTodoList` example?

I can't understand how the client would understand how the query would resolve to include that specific `TodoList`?


Yeah, I was going to ask you about that. If we already had something that would do that kind of conversion once I didn't see/find any. I will go ahead and remove it then.


是这么玩的吗……


So, this repository is just an example implementation of your HTDSA protocol, right? How would this play out in relation to protocols that send SAML like Google supports?


Oh, sorry I think I misread your comment.

Definitely it makes perfect sense if you *update* an object. It just seems theoretically impossible for a *new* object to appear in a query.


ok


If you had trouble with the border, try making this into a separate class and add to all the boxes that require a border :)


Is there any software for this Forth CPU?


Ah great. Thanks Byron 👍


cool


Sorry, are you referring to line #956? Or the assert (#958)?


Overall: Perfect!

Try adding the border in (Should only take a moment and then you're done!)

Very well done!

This is really quite fundamental and using horizontal centering etc is something that you will use **a lot** and I mean **a lot!**

A deep understanding on this is really important. Lots of experienced developers still struggle with positioning issues, so it pays to really get this down!


"Manager" seems over the top in naming this (and the send equivalent). AssetCacheNetworkFileSender/Receiver?


default debug mode on not off?


LGTM!

(In case you are not familiar with that abbreviation, it stands for _looks good to me_ and it is commonly used in code review comments)


this is comment


Thanks to @valascus!


Move enums to top of protected block


测试


The comments? Yes. I left them there on purpose so during the tests and build, I could have a reference on the changes made. Thanks for looking into that.


Here is where I'm thinking of the commit case and how we should structure the API. One use case is to have separate commits for each of the fan-out flows.

```scala
in ~> transform ~> bcast ~> flow1 ~> commit1 ~> sink1
                                bcast ~> flow2 ~> commit2 ~>sink2
                                bcast ~> flow3 ~> commit3 ~> sink3
```

The other case is one single commit after the merge. But we could use a `PersistentBuffer` and `Broadcast` together for this use case. The third one is auto-commit. Need to think it through a little.


reference to TheCoerLite that is not present in the main repository


The use of two classes here is really good.

It's easy to get into a mess and add specific classes and not notice where there is reusability.

Reusability is a sign of a smart conscientious developer, keep looking at your code at all times to see where you're repeating yourself.

Why is this important:

* It means updates can be made in one place, not in many
* Keeps consistency of your apps
* Makes things "easy to reason about" -> i.e changing things leads to the results you expect, not weird other things

Using repeated styles means you can build up a style guide, which is really important too for consistency and your own sanity. Using the same header styles, paragraph styles etc everywhere is easy when you have styles ready to go.

Love it!


I like it!


I'm really impressed! Absolutely great job. All the comments are really only minor adjustments.


Oh ops xD Did not see this xD


Delivery Status:
----------------
|Verify|
|:--|
||
||
||


I think this commit is wrong. The unhandled handlers are only called if the normal handlers are already called. With this commit you are logging messages twice.


@mvaptisv I consolidated your CSS & JS files so it's easier to keep track of everything!


/div>

 -<script type="text/javascript" src="http://cdnjs.cloudflare.com/ajax/libs/jquery/1.10.2/jquery.min.js"></script>		 +<script type="text/javascript" src="//cdnjs.cloudflare.com/ajax/libs/jquery/1.10.2/jquery.min.js"></script>
  <script type="text/javascript" src="js/picedit.min.js"></script>		  <script type="text/javascript" src="js/picedit.min.js"></script>
  <script type="text/javascript">		  <script type="text/javascript">
  	$(function() {		  	$(function() {


@rkorytkowski am trying to run the rest webservice tests on platform 2.0 and i find that DrugController1_10Test fails because of changes in this commit. First question: i understand why you changed 0 to false for voided. Do you mind throwing some light as to why you changed the concept name from ZZZ to XXXZZZ and reference term code from XXXZZZ to XXX? In other words, would the existing tests not work unless you made these changes to the name and code?


@ZedCee
- Which team? And what server? What the fuck are you talking
- I did not. I just told them that they use the API incorrectly. As example: RedstoneBlock as flowable, generating flowing lava instead of still lava etc. You could be glad that i try to help.
- They do. I removed their inapporative messages of the issue list and only have 1 screenshot somewhere in the telegram group.


Unnecessary else


@mvaptisv It's **really** important to load all CSS & JS in the correct order. Here, if `<script src="js/candytrade.js"></script>` was placed before `<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js"></script>`, the browser wouldn't know what to do with all the `$(whatever)` calls, because `$` hadn't been defined yet, and none of our jQuery would work.


После того как в ветку мастер была смержена ветка f2-1, сделал rebase master на ветке f1-1, при этом в общем репозитории уже была ветка f1-1. В результате для того чтобы запушить локальную ветку f1-1 общий репозиторий, пришлось сначала спулить удаленную (remote) ветку f1-1, смержить ее с локальной веткой f1-1, разрешив конфликт.


accepte


I got rid of these because they were blocking the action buttons. `z-index` is a funky CSS property that sets the third dimension - since these were occupying the same space as the buttons, but had a higher `z-index`, they were preventing our clicks from ever reaching the buttons.


I think you did not notice `commitId` to `commitID`.


Please remove this line.


Outstanding todos


What changes have been made? you should also add the changes to the commit message.


@mvaptisv It's an extremely good idea to wrap all jQuery functions in`$(document).ready(function() {}`, otherwise you get inconsistent & usually broken behavior.


Oh good point, I misunderstood.


不要になった処理はコメントアウトではなく削除してしまって構いません。


the `assert()` above.


Just curious. Why does this not go into vendor?


@rkorytkowski the original code used to search through concept name, drug name, and reference term code. The new code seem to search through concept name and reference term code only, but not drug name. Is this correct? Or is it simply my little knowledge of lucene queries? :)


Также в ветке f1-1 появился https://github.com/bskton/rebase-sample/commit/5546e90c8a98466a4b010e02364c83deec66f4ed - копия коммита https://github.com/bskton/rebase-sample/commit/612ba5d8e34e655c678726878dc0c6b29a8c926c
Т.е. не стоит делать rebase на ветке, которая уже запушена в удаленный репозиторий.


作業中のTODOやメモ書きは、コミットには含めないようにしましょう


Используете merge master вместо rebase master на своей фича-ветке, если хотите подтянуть изменения, которые были уже замержены в master.


Wasn't getting this cleaner/clearer solution when I originally wrote this in python.  When writing the C solution came right out with this.

The stack still overflows even setting the `sys.setrecursionlimit`.  I was going to tamper with `prlimit` but this while-loop is fine too.

Improves the time from ~30s to ~1.5


Adding static page :about


@mvaptisv When you're working with JavaScript, `console.log` is your friend. Not only does it show you that things are working, it saves you *hours* of digging through code looking for things - when you need to pause a script at a certain point & debug, click the log in your console to quickly insert a breakpoint, where you can test stuff out & eventually copy anything that works directly into your JavaScript file. This is literally 90% of what most developers do at their jobs (the other 10% is Googling stuff). Here's a video of it in action: http://take.ms/fTOmi


> The user namespace join may be intended to drop privileges on the other namespace instead of to acquire privileges on the other namespaces.

I don't understand what you're saying. If you want to create a container, then you want to **always** create the user namespace first. Otherwise, you're just making it impossible for the user inside the namespace to do certain operations (even the setup process is limited). Since that's the only logical order to use during creation, joining the user namespace first makes more sense than any other order (technically you could do any order, but `setns` does permission checks based on the user namespace and the pinned user namespace of the namespace you're joining -- if you join the user namespace then you'll always be able to join the other namespaces created under it).


Schickes Ding, sieht gut aus!

Verwende doch für das Icondie Auflösung 512x512px, ist mittlerweile schon bei vielen Add-Ons verbreitet, wie z.B. bei ExtendedInfo.
Dann sind auch die Details besser zu sehen ;)


Any other way leaves the possibility of two different files with identical signatures.

And honestly, it seems pretty quick. Not worth trying to optimize or spend cycles trying to devise an alternative, IMO.


the problem is in main.h

GetBlockHash() const {
return *phashBlock   /// this
}


@mvaptisv I fixed and refactored a bunch of stuff! Check out my inline comments above. You're doing great work so far, this is really coming along!


This is a bad test case. Since how the ticks are currently placed for the time scale, you need a tick for the next time unit (August in this case), otherwise all the July data points would be drawn off the right edge of the chart.


13 SCNs with Highly Predictive Performance


I think init-ing them in the header is a totally fine way to do it (perhaps even preferable)


Why ur code is so hard, mr. Likhodedov?


Delivery Status:
----------------
|Verify|
|:--|
||
||
||


surely is_equal is no better than is_zero?


Hi jim
 I would like to know the difference of MBHD payment and BIP70 payment.
More accurately With Multibit wallet do you use the unconditional MBHD payment?
thank you


little indentation problem here.  no big deal of course.


If they're zero, then it's already handled by C+11 and thus a waste of program space to do it again. We should remove all inits in the header of all files that are setting it to zero.


see note: // use is_equal() because is_zero() is a local class conflict and is_zero() in AP_Math does not belong to a class


這一行可以直接改成
`var total = books.Sum(x=>x.Price);`
不需要先 Select() 再 Sum。

另外，會建議這邊的需求，total 應該只需要用 variable, 看不出來有什麼需求要轉換成 private field or property


yeap


Then Price should be 190.


Using resource to handle data from backend. resource is angular's RESTful API.


Isn't that only true if the object is declared/allocated statically?  If the object is dynamically allocated then it could be anything.


Add  ".typingsrc" to avoid certification issue in Typings.


Ok, done (here and in one more place)


到這一個綠燈會發現，其實 ProcessSale() 的 switch cases 只跟 discount 算法有關。
_total *= 的部分其實在每個 case 裡面都是重複的。

所以應該可以重構調整一下。


fixed in later commit


Dependency Injection.


這個用法是有問題的。

你應該要 new 一個新的 PotterBook instance, 只是它的 version 剛好也是 III。不可以把同一個 instance 加入 orders 裡面兩次，這語意跟作法完全是不同的。一不留意，就會出現大問題。


387行目のToDo 表示設定の処理のように、一時変数は利用せず、
Integer.parseInt(ALEipUtils
          .getPortlet(rundata, context)
          .getPortletConfig()
          .getInitParameter("z1a-rows"))
のように書くと、可読性が増すので良いです。
一時変数を利用しないことで、コードの変更による影響範囲が明確になります。

こうしたコードの書き方の考え方は、「リファクタリング」という分野の本に記載されているので一読の価値アリです


Initial 70 SCNs for Diagnostic Model Construction


that is true, but none of the library stuff does that. Only classes like Location and vector3d that we declare on-the-fly on the stack. All the AP_ stuff is good to go


_booksGroups 是 ICollection, 可以直接用索引子 index, 不需要用 ElementAt(i), 會比較快一些。


@perpetualjourney They are deprecated. They are now included in https://github.com/flowtype/flow-typed/


這一行可以直接用 `Sum(x=>this.getSubtotal(x));` 取代


Hi, Nice job

I try use this engine, but is not working when I use GUI Fritz.. Analysis engine empty..
but this is strong engine..

Rgds,
Rakan


Looks like this broke uploading of haddocks:

```
+mv Cabal/dist/doc/html/Cabal cabal-website/doc/html/Cabal

mv: cannot stat `Cabal/dist/doc/html/Cabal': No such file or directory
```


最後的重構很重要，讓語意更清楚，雖然還有調整空間。


LGTM (looks good to me)


it's just a beginning


...because the haddocks are now in `dist-newstyle/build/Cabal-1.25.0.0/doc/html/Cabal`.


不可以這樣直接加


Probably linked to QT5 keeping attributes in a hash map, with a random hashing, causing different ordering on serialization. Based on http://stackoverflow.com/questions/27378143/qt-5-produce-random-attribute-order-in-xml ,  I added https://github.com/qgis/QGIS/blob/12bb1f7b4a5e188156f10f124daeaeceef0b7eb0/tests/src/core/testqgsogcutils.cpp#L35 that apparently solved the issue that was before fairly reproducable, but it seems that it still fails in a few percent of runs. I'm short of ideas.


Можно его доработать , к примеру [тут](https://github.com/Unact/sencha-common/blob/master/common/src/lib/grid/plugin/RowClipboard.js#L317). Добавить метод validatePaste или что нибудь похожее, которое будет проверять корректность.


Login issue fixed


this is not a proper fix. cppcheck should detect this too.


Thanks. So I think we can switch to the normal version. I assumed that there are additional assertions checked in the normal version.


Такие объекты надо по особому сравнивать через
`new Date(2016, 1, 1).valueOf() == new Date( 2016, 1, 1).valueOf()`
Но вопрос все же остался, зачем два метода?
getValidationText(часть этого  и unique). unique же все равно убирает копии, зачем тут проверка?


converts -> convert


`return` is not a function so there is no need for parentheses. `return number` will be fine.


Thanks for  edit


`/* pretty */true`
^ Cool idea!


В потомках не видел, хотя бы как  [здесь](https://github.com/Unact/sencha-common/blob/master/common/src/lib/singletable/ViewController.js#L92) сделать нужно.

А про валидацию, я в смысле что обычно перед сейвом только валидация нужна и не более, поэтому метод не нужен.


yes, use it in one of my projects


bad name


아래와 같은 에러 2개가 발생함:

```text
error: unknown type name 'main'
error: expected identifier or '('
```


I've been thinking, and it would be better to use Configuration:GetFont in order to get a table, so you could be specifying a lot more than just size, and also to use a string-based name instead of 1, e.g. "small", "large" or something like that.
```
font = Configuration:GetFont("small"),
```

Both should allow for more flexibility/configurability in the long run. Thoughts?


oops :) good catch 👍 will fix asap


The docs just above need a '@param mirror'.


isn't ienumerable enough?


I believe Swiss monetary amounts use apostrophes as thousands separator, but i thought French numbers typically use spaces, if anything. I could be wrong.


Velocityのテンプレートに書く処理としては少し長いので、Javaのメソッドとして実装することを検討したほうが良さそうです。

後々変更があったときに、Javaのメソッドとして実装されているとメンテナンスしやすくなります。


Hi jim
I would like to know the difference of MBHD payment and BIP70 payment.
More accurately With Multibit wallet do you use the unconditional MBHD payment?
thank you


Change SQLite database column type doesn't matter. It accepts no matter integer or text. This is a good news otherwise client SDK must refresh install, which is too bad for existing customers.


I ran doc build on [readthedocs for this branch](https://readthedocs.org/projects/simphony/builds/4218619/) and have the same issue, whilst the master branch passed.  I believe "The documentation should be possible to build without pytables" is no longer true on this branch, when `simphony.io.data_container_description.Data` is dynamically created class.


Why do we need 'had moved' flag at all?


TeamCity ReOpenLDAP :: devel [Build 288](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=2575&buildTypeId=ReOpenLDAP_Devel&guest=1) outcome was **SUCCESS**
Summary: Tests passed Build time: 01:58:47


Unique убирает полные копии. Мне же нужно в сторе найти повторяющиеся записи, а повторы в зависимости от конфига отслеживаются по полному совпадению и по совпадению только идентификаторов.


You said "set a callback on req->bodyBuffer.setBuffersFlushedCallback(), and in the callback resume the input by calling req->bodyChannel.consumed()" though, which put me on this track. The code doc also doesn't say anything about zero not being allowed.


Да, пожалуй, уберу beforeSave


If you throttle before the feed, you have to start remembering the buffer size for the consumption call later on. Instead, according to the code comments, one should be able to "refuse" the buffer and trigger a re-call with a not-fully-consumed size.
I also think the stop/start makes more sense (and in that case you can do it after the feed), so I'll continue on that route. The code doc should be fixed though or at the very least clarified what the intended use of consume is (not clear to me still).


コミット実施


Getting "error: unknown option `sort=version:refname'"


Это будет не совсем в тему для этого плагина - тянуть данные из БД. Он разрабатывался для элементарных действия с буфером обмена, название как бы намекает.


If you want you can try to make cppcheck warn about this. I think it's not too complicated. Look in the file lib/valueflow.cpp in the function valueFlowAfterCondition() .. I believe we should handle "for" conditions better.


The expression on lib/client.js 126 is a tautology and disable to connect to url.
Here is the pull request to fix this.
https://github.com/swagger-api/swagger-js/pull/817


Looks familiar,

http://androidmkab.com/2016/04/09/how-to-add-animated-splash-screen-to-you-android-app-using-android-studio/

Make sure you understand your reference.


Pro-tip: you can use `[ci skip]` anywhere in the commit message body to avoid triggering CI builds for changes that don't touch parts of the codebase exercised by the test suite.


This is really odd


*bump*


So its Fixed? u no dey bed eh....Programmers be like


"obsoletes the" -> "renders obsolete the"


I rebased this time so rip history ;~;


Erick, i am disapointed by you. You should use:
BinList = [<<"foo bar">>, <<>>, <<" baz">>],
<< <<B/binary>> || B <- BinList>>.


By accident, I deleted my feature branch before I could commit and merged. Instead of committing to my master branch (which I should never do), I should've added a new branch, submitted my last edits and merged the branches at the end. I apologize for the mistake and I have learned my lesson of coding at 1am.


versions does not default to -1, it is undefined if not set, thus taking all changes since first tag


AjaxScheduleActionは@Deprecated
に指定されていて、現在利用されていないので、変更しなくても問題は無さそうです


Passes correct value in copy mode.


Are you running an old version of Git ? I believe you must have 2.0 or higher for this to work.


@vladikoff: please `npm publish` since I don't have the needed rights.


We need a way to automatically update year in _p.copyright_ - maybe convert the file to .php and use `<?php echo date("Y"); ?>`


신문 129줄에서 14조에 대한 언급은 필요합니다. 어떤 제한만을 해당시킬 것인지.


Yes, I thought that indexing by string would be smart. Just needs a changeover. I do font in most other places, this control only takes fontsize.


So THAT's the reason for the *_signal boolean


Indeed, fixed in 9111815


I think this one should be here :smiley:


Let's add a class to all the flag images and move the width declaration to css.


And log success/failure


Kind of redundant if/else here. Handle the true case, default to false.


According to [this issue](https://github.com/GoogleCloudPlatform/gcloud-common/issues/147) we should always call it `Stackdriver Logging` to avoid confusion with the main docs.


(Makes sense IMO. Say I'm casting, then I minimize the WT Desktop window, then it hit F8 / pause. It would crash before because `mediaTag` is null. This fixes that bug. I've also seen it happened when the window *isn't* minimized, which I think is a separate bug b/c `state.window.isVisible` is getting out of sync. But we need this fix either way.)


The syntax looks like you should type in just a number, but the logic requires a negative number, it is a bit confusing. I think just typing in an absolute number should be sufficient, since the command name is changes-since. It already is implicitly said that it is historically, and a negative number doesn't make any sense. Add that a positive number does not do anything in this syntax makes it rather confusing. I think the command should just accept an absolute integer.


MoreDaylightingSensors (JasonGlazer) - Win64-Windows-7-VisualStudio-12: OK (2226 of 2241 tests passed, 544 test warnings)

 * 556 tests had: AUD diffs.
 * 29 tests had: DXF diffs.
 * 29 tests had: RDD diffs.
 * 8 tests had: Table small diffs.
 * 2 tests had: ERR diffs.
 * 3 tests had: EIO diffs.
 * 12 tests had: Table big diffs.
 * 1 test had: MTD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.33%25-yellow.svg)


Nope, for n=145 ~ 2^8, for n=100000 ~ 2 ^17. 17 is not so much for JVM.


Infinite loop of map status 0...
Just from what I can read in this commit, nothing will actually function correctly still.


Is the mod id of Forestry actually `forestry`?


This one also.


126735005-AdaptiveThermostat (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1683 of 1683 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.0%25-green.svg)


Why not just assign directly? Is the local var necessary?


Macht Sinn, done.


This one.


Unhandled todo


Doh!  :grinning:


This is *not* equivalent.
You have broken the (obscure) functionality which makes support like `/ \`

If you know a commit is going to make for a hard diff, like here where you introduce a const for every line, then please _only_ do that refactor in one commit, without  doing other things along the way.
I was just about to skip the review of this commit because I thought it was a simple refactor, like the commit message says. It's a good thing I checked more thoroughly.


La PR a déjà été intégrée.
Si tu veux faire cette modif, ouvre une nouvelle PR.
Je ne pense personnellement pas que l'ambiguïté soit suffisamment marquée pour mériter une intervention.


Trust MITM?

It seems "force ssl" is disabled by default - is not that dangerous?


kullandığınız libraryde boş dosya kopyalamayla alakalı bişey göremedim ordaki sorunu bi kaç şekilde aşabilirsiniz. Nasıl yapabilceğinizi konuşup bence bi karar verin o yolda devam edin. örnek olarak boş klasöre bir dosya oluşturup kopyalandıktan sonra silebilirsiniz yada kopyalanacak yere yeni klasör olarak aynı isimde atabilirsiniz. başka alternatiflerde vardır muhtemelen bunları düşünüp size göre en mantıklısını yapın bence. @mustafakuloglu @CBaldemir


yes it should be lowercase `forestry` here


I have problem with conflict between File definition in the FS.h using Spiffy and File.h to record data on a SD card. I replaced your SD.cpp, SD.h and File.h in my project but I couldn't get rid of error. I have the same proble with FatFs and SdFat. Any help to solve it or suggetion to use alternative FAT32 library would be appreciated.


Google login Problem
Bad Token


Unnecessary local string


This naming suffers from the exact same problem as extrusion_width: it's not specific of what the extrusion width is exactly.

This should be named something like `inner_wall_line_width` or simply `wall_line_width_x`


Dead code


Hm... What does _n_ mean then? I thought it was n_th fibonacci number.


Ah no wait.

Is this the line width of the horizontal lines, the diagonal lines, or of all lines in wire printing?


What the beast this 'integration unit tests' is? :)


Ah, thanks!


cvd.js


Nice


I'm fairly sure operator== on Atomic::String already does this


Yep


I can see how that is confusing, though negative numbers are more usual when going backwards.
I added support for positive numbers in 9b8af32.


This one *should* be correct. At least the intention of it was to only show the label on the parent folder item.


In all these cases, perfectly fine to just assert(status == expected) IMO


Well @soupault I think that snippet redirects getitem to getaddr, but this doesn't explain how getaddr is defined...


This naming is a bit confusing. I suggest `primary_extruder_skirt_line_width`. This is about the fact that the skirt is the first thing printed, so the initial extruder. After the skirt with the initial extruder is printed, a skirt will be printed by every other extruder.


You broke GTK3 here.


I somewhat lied. The button layout is 360dp, but 600dp is what the whole layout needs to look good in dual pane.


I just saw ListItem.Title as the value so assumed only show if its !empty. You would def know better than me since I don't even know what this VAR goes to at the moment...


Why this change ?
This makes loading remote textures to fail.


@invisiblek Could you remove those Pokestops that are not lured anymore if the app runs with `-dl`?
It also seems as if the "lure effect" isn't removed, it just gets the "Gone!" in the description.

Besides that: great work, thank you! =)


Yes, @schwabe is right, I can see twice all the mesagges in the Logger.


Its for music list. If you show listitem.label you get the formatted label like track-artist-title or whatever is set in settings. I just want to show title there instead, but need the ``..`` on the parentfolder item.


Please look out for trailing spaces. Visible whitespace in VS should show them


Thanks :)


While it's OK for us to have this in debug mode, this is something, that should not probably go into production mode.


The new custom checkout field is not saved in db!


so weird.  I was watching a thoughtbot video on parameter objects.  I thought "who is that girl doing this episode with joe".  Hit your github and see that you just committed to the dolores landingham thingie.  Which I did, also, about three weeks ago, after winning a micro purchase.   The ruby world is not that big sometimes.


misspelled 'canola'


This commit is dangerous. You say you changed line width of the skin walls to the inner wall line width, but I don't see that in this commit.

As far as I understand the code as it was, this is about an overlap between the skin area and the infill area.
That doesn't have anything to do with the inner walls.


Dead code


@ZedCee Genisys is quite rude. They delete your comments, but what does ClearSky do? Nothing, unless if its someone spamming the issue.


I think this is safe value... will revert this if there are still problem with this


antoooooooooon


``collections.defaultdict(int)['foo']`` is arguably more readable?


nice


Ah... Must remember to check the whole var... Kinda missed the fallback there at the bottom :innocent:


Did you also change the polygon generation such that the inner wall line width is used?
Note that in the next commit (https://github.com/Ultimaker/CuraEngine/commit/5280c9df10c0bb740b1630458286c80686ea665c) you seem to think you are doing that, but made a mistake.

I would rather see the changes of making the skin walls use the inner wall config grouped together, so that I can review whether that change has been done right.


I don't think we should do it this way. We have been working tirelessly to remove guice. Please create a pull based interface for this, so that all the custom name resolvers can be retrieved before we create NetworkService, so it can take them as a ctor arg.


it worked for me, pretty neat! :dancer: thanks!
(it just take pokestops but less is nothing)


La línea 62 y 66 tiene código duplicado.


Oh you did change the polygon generation in https://github.com/Ultimaker/CuraEngine/commit/3825e200a6c41342aa8186c56e1478bfce829eca

Still would be nice to have the commits which pertain to that grouped together in some way, but whatever.


hello everyone in git


@lots0logs No no, packages are downloaded to /INSTALL_DIR/var/cache/pacman/pkg, and then here they're copied to provided caches (one of them being /var/cache/pacman/pkg in the ISO, that's the problem).


Will == not work here?


My English was so poor


コミット


Makes sense. I'll revisit the PR soonish with that.


(13) Dashboard [5]


@jsonn @kientzle  Guys any news on this ?


This shit causes errors, and template can't render, please check it out.

The error is:
Settings matching query does not exist.


failing test for #14


It would be nice if you moved this assignment to below line 700 and used the actual `combine_idx` instead of 0.

I don't think the extrusion width changes over the different infill combines, but it seems more correct to retrieve it from the corresponding config, don't you think?


after more thought this sounds like a good idea :)


Isn't this used in TypeScript 2.0?


That "[" was on purpose, it's a half-closed interval. (To say "we're running the `lo` number, but stopping just before the `hi` one".)


doc-fixes (michael-okeefe) - i386-Windows-7-VisualStudio-12: OK (2241 of 2241 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


What exactly are you talking about?


       该项目源自于参加华为公司举办的“创想杯”比赛，由程皓学长，刘艳学妹和我三人制作，因为在本人自学编程的时光中，开源让我免费获取了很多学习资料与素材，故将自己作品开源，提供大家参考，如有不足之处，请告之，谢谢！

- 本作品使用的引擎为Cocos2d-x 3.8（C++版），IDE使用VS2015，借鉴了以下书本及博客。

- 关东升《 COCOS2D-X实战  C++卷》《 COCOS2D-X实战  工具卷》

- 满硕泉《COCOS2D-X权威指南》

- Renshan：http://shannn.com/archives/586

- 红孩儿的游戏编程之路： http://my.csdn.net/honghaier


Sure it's language/common/model/langtools-classfile, that's it.

This is behaviour that we depend on for every JS deployment in the browser, and in FH.

I don't really mind if we have to add a flag to turn it on, but it has to be possible.


MainWindow was ~700 line, so I put all the system tray code in a new class to reduce a bit the size of MainWindow


@amorphic  That was a while ago, so my memory is vague...

I believe we updated the version of qemu we were using and the migration behaviour changed. Previously, the `migrate` command had blocked until the migration completed and that changed to it returning immediately. That made it necessary to introduce this change to monitor the status until the migration had completed.

That's my memory of it, anyway.


It defaults to 5601 for me, I've created a new pull request.


TeamCity OTA+ :: rvi_sota_server :: ci [Build 546](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=8824&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


Hi,

Can you please bump the version and upload it to the supermarket ?
At that point it's a new artifact for us what we can freeze as the previous 1.0.4 as the content has changed.

Regards,
Jos


Hey, thanks for advise it really helps. Few words about current `class Decoder`:
- I'm running it with my C-Elysee and BSI protocol a little bit different, e.g. swapped left/right lights etc. So I'm going to refactor it to use class based approach with inheritance.
- Also all `Decoder` contain parsing of all information from all devices without any separation. I'm going to create sub modules that will be responsive for BSI, Display, RD45, etc. Sure will make a wrapper that merge all this stuff in one entry point, just for first time and for not breaking UI.
- Now stm32 throwing all messages, it's good for investigation/debug but not very good for normal run. To reduce traffic and CPU load at host machine would be great if you extend firmware and add two features: 1) add possibility to set filter by ids, e.g. by sending `F 123 12 345 <some_id>` and read filter by `F`; 2) add possibility turn on/off the filter, e.g `F+` / `F-`. After it I would refactor `Decoder` classes to parse each ID in separate own method `def` and implement logic by auto discovery all supported IDs by some particular `Decoder`, e.g.
```python
class BSIDecoder(Decoder):
    ...
    def id_0x36(data):
        pass
```

Finally about visualization. Of course  native android app would be great, but it requires knowledge of Android/Java. So I decide to write plugin/skin for Kodi player and actually already started it. There couple of reasons for that
- it can by written on python
- it can be lunched not only at android device but at all platforms, in my case it's raspberry pi
- it fast enough

I hope for collaboration and will make PRs soon.
Thank you.


Yeah, seem like I was running 1.9.4, I will try again when I have updated


@glzjin 我改为 return str(int(traffic)) + "B"; 了，一会儿再连同别的一起放上来


好厉害


forgot it, I will remove this line in my next commit


Can we just use `getter` and `setter` inside `property` ?


pour Les excursions il faut juste 2 excursions de proposé avec un prix


@amw2104 that doesn't look correct, the token shouldn't be present in the path


TeamCity OTA+ :: rvi_sota_server :: ci [Build 546](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=8824&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 183, ignored: 2 Build time: 00:08:23
### Failed tests
```
APIFunTests.test list of vins affected by update: <no details avaliable>

```


`offset` :-1:
`$offset` :+1:


That's so awkward to have components in your routes folder.


@Menci is there any chance you can package a new release soon?


WTF I was thinking. There are at top-**right** and bottom-**right.**


Where do you prefer to put your route / page / screen components?

On Thursday, 21 July 2016, Romain de Wolff <notifications@github.com> wrote:

> That's so awkward to have components in your routes folder.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/kriasoft/react-starter-kit/commit/6553936e693e24a8ac6178f4962af15e0ea87dfd#commitcomment-18335448>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAMCDm4pLSAGXCK5gdk8z4ljPdACWpWBks5qXzidgaJpZM4JRmI_>
> .
>


I fixed this with better naming in 3eaa5da. Also moved drawing contour edges *before* drawing emphasized edges because otherwise emphasized edges clobbered depth buffer and that looked badly.


Should this call Stop?


ok


This is a bit confusing, what about something simpler:
`:param str doc_id: The ID of the document to show.`


@gsstudios,
Can us it is worth using zen I/o by default how it does dori on lg g2?


@ide I am not a git expert, but after that change tags made by bump-oss-version are no longer pushed (also `latest` created manually is not pushed). That means all tags have to be pushed explicitly which can break the CircleCi build since the build starts right after `push <branch_name>` and might be missing `latest`


굿이예요 굿굿굿!


sehr schön!


Well like I said, it *is* possible , except that instead of saying `ceylon copy foo` you'd now say `ceylon copy foo ceylon.language`, is that not possible in these cases? That's why I'd like to see where it's used to see what the best solution would be. Although if you are positive that you want an option for it that's okay too.


Between this and the "Something went wrong" in the AssetCacheManagerNetwork, seems like a message should be either logged in all error cases in the FileSend/ReceiveManager, or stored for reuse in these messages.

Based on other code in Atomic (eg using the FileManager) I'd suggest it happen in the FileSend/ReceiveManager, and just lose the redundant "something went wrong" here.


[Klugscheißmodus ein]
"Downgrade-Angriffe" werden (analog zu "Vault-Version" - btw. sollte das evtl. "Tresor-Version" heißen?) mit Bindestrich geschrieben.
[Klugscheißmodus aus]


I did some nasty hack in `data_container_description` just for building the doc without pytables.  It should work now.


It seems like you've rebased parts of the history of this repository and force-pushed. The last "common" commit is 2d2e701. Did you do that on purpose? Because this causes all kinds of havoc and noise in pull requests (see #158 and #163 for instance) and forks. My `git status` says:

```
On branch master
Your branch and 'upstream/master' have diverged,
and have 114 and 99 different commits each, respectively.
  (use "git pull" to merge the remote branch into yours)
nothing to commit, working tree clean
```

:-/


use port 5353 to avoid bad results
add some new server available within mainland china


This is much cleaner than the switches in other classes that have the handling right in the switch, consider applying this approach to them as well. However you really don't need the local fileName variables here.


@drnextgis добавила https://github.com/nextgis/nextgisweb/commit/ec4c179e173d21ffd2bc3ebbf52defeda6e1d2eb


I just realized that in these boolean properties cases this implementation always fires a property change event because it always provide the negation of the input of value as the old value. However, it conceivable that the method gets called with a value that is identical to the current value. In this case the event shouldn't be fired.

I'll therefore make these boolean cases more similar to the integer and float cases:

```
boolean oldValue = this.fullscreen
this.fullscreen = fullscreen;
propertyChangeSupport.firePropertyChange(FULLSCREEN, oldValue, this.fullscreen);
```


Hm ok, thanks for the heads up. I'll fix this to say to push the tag name. Pushing all `--tags` to a shared repo like RN is almost never right.


decbin does't add leading zero. when converting 5 and 1, you got 101 and 1, then you compare string like this:
1 and 1, 0 and nothing, 5 and nothing. Results are bad.


@mvaptisv This was a gnarly one. Apparently firebase doesn't let you have directory structures, so in order to get the CSS & JS to load properly I had to move them into the root /public/ folder & update the links. (Good thing we consolidated `candytrade.js` and `candytrade.css`, huh? It's getting kinda cozy in there...)

Now everything works at https://candy-trade-app.firebaseapp.com/ and will continue to update every time you `firebase deploy`!


It is possible that removing this line
`options.attributes = [];`
can cause some troubles in "aggregate" Models method
`Model.prototype.aggregate = function(attribute, aggregateFunction, options)` (**1544**).
If options.attribute have been set to null before, it will not be replaced by [] and method push
`options.attributes.push([this.sequelize.fn(aggregateFunction, aggregateColumn), aggregateFunction]);` (**1560**)
will trigger a "Cannot read property 'push' of null".


Why do this?


thx, done


maybe if you share some code?

```cpp

bool initSD(){
  if (SD.begin(SS, 32000000)){
    Serial.print("\n==== SD Card Info ====\n");
    Serial.printf("SD Type: %s FAT%d, Size: %s\n", getSdTypeString(), SD.fatType(), getSizeString(SD.size()).c_str());
    Serial.printf("SD Blocks: total: %d, size: %s\n", SD.totalBlocks(), getSizeString(SD.blockSize()).c_str());
    Serial.printf("SD Clusters: total: %d, blocks: %d, size: %s\n", SD.totalClusters(), SD.blocksPerCluster(), getSizeString(SD.clusterSize()).c_str());
    sd::File entry;
    sd::File dir = SD.open("/");
    dir.rewindDirectory();
    while(true){
      entry = dir.openNextFile();
      if (!entry) break;
      Serial.printf("SD File: %s, type: %s, size: %s\n", entry.name(), (entry.isDirectory())?"dir":"file", getSizeString(entry.size()).c_str());
      entry.close();
    }
    dir.close();
    Serial.println();
    return true;
  } else
    Serial.println("SD Card Not Found!");
  return false;
}
```


Stateless components are always better than Classes, well done!


修改了on/off bug


@bermanmaxim have you seen the "magic" at the end of the file https://github.com/scikit-image/scikit-image/blob/master/skimage/measure/_regionprops.py#L617-L631, especially `setattr` call? :smiley:


1028:0310
1028:0410
This two subsystem id dw1820 can not work with this board-2.bin file .
need to update it .


What was the reason? :C


Interesting, they talk about this in SOLID, they call it "inversion of control". Instead of having a component that has it's dependencies, the dependencies and functions that can change are at a higher level, well done @porfirioribeiro !


TeamCity OTA+ :: rvi_sota_server :: ci [Build 547](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=8839&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


Inversion of control again, well done


Adding the language module to the list requires me to know which version it is. I only want the one that my module depends on.


change some ui


FYI @svinqvmraka


基本画面完成，数据库操作完成。登录，个人信息，聊天，好友列表


Late comment on this commit, did I do the right thing?!


Suggestion:
Backbone model.save() supports receiving an object literal, so you could have the same function "onEdit" that always calls `value => task.save(value)` where value is an object literal. But that's not a problem neither I'm completely right that it is a better solution, just a suggestion for discussion


Well done, ES6 rocks 🎉


@niieani
this commit broke webpack-esnext for windows 10

* **Node Version:**
5.7.0
* **NPM Version:**
3.6.0

**Current behavior:**
App fails with:
```sh
INFO [aurelia] Aurelia Started
aurelia-logging-console.js:24DEBUG [templating] importing resources for app.html ["nav-bar.html"]
aurelia-logging-console.js:24DEBUG [templating] importing resources for nav-bar.html []
bluebird.js:1482 Unhandled rejection Error: Error invoking RouterView. Check the inner error for details.
------------------------------------------------
Inner Error:
Message: key/value cannot be null or undefined. Are you trying to inject/register something that doesn't exist with DI?
...
```


Very interesting, passing all the props down to the component allows to add some features in the future. They talk about this in SOLID too, in the "Open closed principle". This way, if you want to add, example, a click handler for the label, you just have to pass it as a prop and you don't even have to open this file for it to work, got it? Good job!


That was a pretty stupid change, as CI isn’t working anymore. I should rather use the `--silent` option, cf. https://github.com/npm/npm/issues/6124.


In terms of throughput, CFQ is better. I've used zen in the past before and in my experience, it is a pretty good i/o scheduler (however some people prefer CFQ/BFQ).


Good use of npm scripts 😉


TeamCity OTA+ :: rvi_sota_server :: ci [Build 547](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=8839&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 183, ignored: 2 Build time: 00:07:03
### Failed tests
```
APIFunTests.test list of vins affected by update: <no details avaliable>

```


why you update this file
...ges/custom/icu/public/components/modal-compartmentalization/modal-Compartmentalization.js

in fixes instead of circle api?


Very good job! I didn't talked about linting but they are kind of crucial to code style and to detect some simple bugs, well done at adding it to your project


feeling this is not required. Are you saying that `clone` is not doing its job correctly here i.e. creating NEWUSER first ?


ok


this is probably correct, but we can also do it in Go https://github.com/opencontainers/runc/blob/master/libcontainer/container_linux.go

```
// orderNamespacePaths sorts namespace paths into a list of paths that we
// can setns in order.
func (c *linuxContainer) orderNamespacePaths(namespaces map[configs.NamespaceType]string) ([]string, error) {
```


Fixes #2


doc-fixes (michael-okeefe) - Win64-Windows-7-VisualStudio-12: OK (2241 of 2241 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Erm, this may be a backwards compat issue... cc @einarfd @rodrigc


Yeah, it may be risky.
We could update the bump script to do the push with the tags for us...


Did you also try the second proposal from the answer you linked from stackoverflow?


這樣的測試案例呈現的意義，代表呼叫端要傳5本 Book, 只是其他四本 quantity 是 0。代表用起來不好用。


TeamCity OTA+ :: rvi_sota_server :: ci [Build 548](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=8844&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


I noticed you removed the statement about Blue Systems. Would it be better if I reworded it in a different way?


ok je vois ce que tu veux dire :) on vas essayé alors :)


ここは本当はtweet_edit_check.phpに$post_idを持っていきたいであっていますでしょうか？


Hi Lars,

Thanks for your interest, but unfortunately this is still a work in
progress. I only have the alu so far.

Theo

On 21 Jul 2016 7:59 a.m., "Lars Brinkhoff" <notifications@github.com> wrote:

> Is there any software for this Forth CPU?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/flaminggoat/c4fp/commit/21e59a48aea2ad3d57c5c2f5ae382b32225f2409#commitcomment-18333851>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AEytoZyU9sG8jpDZ42fi5ruLKxH_KjpUks5qXxjdgaJpZM4JRgEx>
> .
>


你把Audio的稳定性提高一下就可以了


Ça marche je vais essayé aussi du coup! :)


I can do it in another pull request as it's not related to this topic may be


完成task1的第二题目


這個 foreach 可以直接改成 `totalAmount = _books.Sum(x=>x.Price * x.Quantity);`

另外，C#中 variable 命名通常遵循 Camel 規範，首字母小寫。


DOK COMMENT


不必額外給 .0


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#C0xQmfPfR8uJhXILt_WRHw


class 名稱通常遵循 Pascal 命名規則，首字母大寫。應該把 order 改成 Order


Hey, sorry I never noticed this. You made a fork and GitHub doesn't notify me of this in any way. I've since updated the mod to 1.22 myself.

Should you feel like helping out with anything again, which is great, please make a pull request. That way I get notified :)


TeamCity OTA+ :: rvi_sota_server :: ci [Build 548](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=8844&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Tests failed: 2 (2 new), passed: 161, ignored: 2 Build time: 00:05:35
### Failed tests
```
org.genivi.sota.core.UpdateRequestResourceSpec.accepts new updates with a Client specific format: <no details avaliable>

org.genivi.sota.core.DeviceUpdatesResourceSpec.GET update requests for a device returns a list of PendingUpdateResponse: <no details avaliable>

```


完全亂寫的 production code。

1. 目前只有兩個測試案例，哪裡來其他的數字

2. 190, 270, 320, 375 是 magic number，跟測試案例要帶出來的折扣的 business logic 沒有直接關係。


Ok, good point. I'll add that option then.


6是 magic number....完全是為了兜出來而自己亂加邏輯的寫法。


Well obviously someone forgot to `git add` before committing this. :thought_balloon:


No, I don't think so. Looks a bit fragile as it is not documented in QT docs, but Google shows that some projects use it..


missing variable ${DISTRO} not allows to start service when user with privilege sudo execute install client on Suse


這個 for loop 的寫法也極度糟糕。萬一以後 book name 不是 1~5 怎麼辦？難道要改程式碼？


ExpandObject-MissingSetpoint (lymereJ) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1535 of 1535 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.71%25-green.svg)


Looks good!


You need a space in here, like this: `firstName + " " + lastName`.


I can - give me minute and I will


Wouldn't it be better to use `'unnamed'` or something as the fallback?


@charlieschmidt If you would like to have these changes propagated upstream, please send a pull request. But, before you send a PR, please add a few test cases to validate the functionality. Thanks!


The thing about putting the "s" outside of the `rref` element is that some platforms will turn that into two separate accessible objects and the spoken result will be something like "button link s". :-/

I thought that we had automagic for that to work. Seems we don't. My bad. But I'm not jazzed about turning these into separate accessible objects. And I do think we want to preserve the `rref`. So... I just tried `<rref title="button">buttons</rref>` locally, and it fixed the broken link. Alternatively we could rephrase the sentence so that we can say "two button elements" without it appearing three times in a single sentence. My preference is the former. What do you think?


Great! One note: I prefer to put a space between operators and values/variables, like so: `var output = "My name is " + name;` It's not required, but it's a little easier on the eyes. :)


Haha. Great!


Yeah, looking at the test stuff now, looks like yall use pester, which is new to me so far, but no time like the present (especially since the module repository I manage at work is.... not small)


Well done!


We may scope this error to the if-statement as well.


what does ? do in c#


dasdsad


I realize the "http" is not something you changed, but as long as you're making changes.... Mind turning that into "https"? (Alternatively, I can do it after we commit your changes.)


Great!


Nice!


iteration (Unknown) - x86_64-MacOS-10.10-clang: OK (2403 of 2447 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.2%25-yellow.svg)


Fancy!


Looks like you've read ahead a bit. ;)


develop (Unknown) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2368 of 2447 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.77%25-yellow.svg)


Looking good!


Lots of devices need this....

https://github.com/lj50036/android_device_qcom_common/commit/9f12e8acadd2bedcc0161cdb8cd6a0228b6c94ca


I'm adding task #51 to track this work. Probably get to it tomorrow though.


Looks like it wants you to try the other operations, too.


Haha. Nice!


yes, my regex skillz missed this. Didn't search for `err :=`.


Looks good!


No worries. Maybe I can write a few test cases to validate the functionality. I just created a new branch (https://github.com/PowerShell/PSScriptAnalyzer/tree/ExternalRuleSuppression).  So, if you can send a PR on the branch, I can add the test cases to the branch before merging into development


Or if you can suggest a better workflow to have it merged while I add the test cases please let me know.


develop (Unknown) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


That looks so great! Let's get together on Tuesday and we can see what figure out.


chỗ này ko nên tách như vậy, mà nên là
```
 "sectionInfoH" : {
   "listImages" : ["/img/partner1.png", "/img/partner2.png", "/img/partner3.png", "/img/partner4.png", "/img/partner5.png", "/img/partner6.png", "/img/partner7.png"]
}
```
Loop từng hình ảnh dễ dàng hơn
các thuộc tính khác nếu có bổ sung vào sectionsInfoH cũng dễ dàng hơn


why not make it an emote


Thanks!!!


[inst/scripts/standard-run.R:4:52:](https://github.com/CoGAPS/CoGAPS/blob/e85a89ac2e51bed92a87bddd494631d5ad8b7d86/inst/scripts/standard-run.R#L4) *style:* **Trailing whitespace is superfluous.**
```r
results <- gapsRun(SimpSim.D, SimpSim.S, nFactor=3,
                                                   ^
```


Unless I'm misunderstanding, this both equivalent and a strictly worse approach. By calling delete_hierarchy_references for every root, instead of simply truncating the table, you not only make `roots.count` additional calls, but those calls are much more expensive because they are large subsets of the hierarchy table.


phần menu trong footer (cũng như header) nên kế thừa, sử dụng chung trong menu.json.
Như vậy khi có thay đổi gì, sửa 1 chỗ cho tiện.
Trường hợp trong footer khác trong menu.json, thì mới cân nhắc tách riêng


`dispay` typo


`dispay` typo ("display")


@OldManTigerMask :D It's really just keenant.com, this website generates HTML files.


Link tương đối, ko sử dụng dấu ```/``` phía trước nghe


Why is this called `fortName`. Wouldn't `stopName` be more accurate?


MoreDaylightingSensors (JasonGlazer) - Win64-Windows-7-VisualStudio-12: OK (2228 of 2242 tests passed, 544 test warnings)

 * 557 tests had: AUD diffs.
 * 30 tests had: DXF diffs.
 * 30 tests had: RDD diffs.
 * 8 tests had: Table small diffs.
 * 2 tests had: ERR diffs.
 * 3 tests had: EIO diffs.
 * 13 tests had: Table big diffs.
 * 1 test had: MTD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.38%25-yellow.svg)


Magic numbers from @nvkelso to draw buildings underneath roads. Below z14, roads are drawing on top, but will need more magic numbers from @nvkelso for z15.


Still figuring out transitioning the building footprints, not happy with how it's transitioning in right now :/


This is logging an empty line. Usually happens with crap exceptions that have stack info but no actual message.

Anyways, this is just covering bases to pass tests. It is really hard to find an actual case where we're calling `log.info()` and it somehow gets through.


Interesting idea!

Putting `extra_attributes` in the class method for every tree model might collide with other code, though. I'd shove it into the `_ct` support class to be safe.


It didn't crash, it saved the wrong date. And it's inconsistant with ios implementation


Tách ra nhiều Block rời nhau cũng ko hẳn là tốt, khi sửa đổi phải mò ra từng partials chứa blocks khá bất tiện.

Chỉ tách block cho các trường hợp sau
 + Sử dụng chung giữa nhiều layout, partials, ...
 + dùng {{#each }} để hiển thị nhiều block
 + Block quá lớn (cái này tùy tình huống

@vvthinh @nemesisqp @tungptvn  lưu ý


Make Diablo III Macro


Still needs lots more work transitioning secondary, tertiary and minor roads. Also needs more color work here


Good find.


do trên sectionInfoH thiết lập sai, từ array chuyển sang từng phần tử, khiến cho đoạn code thay vì {{#each}} (phía bên trái) sẽ chuyển thành copy patse nhiều lần ở bên phải.
Cái này cực kì hạn chế, vì code lặp lại nhiều lần, sau này điều chỉnh là sửa rất tốn thời gian
@vvthinh  @nemesisqp @tungptvn @thinnv cực kì lưu ý


I use fortName because the PokeGOAPI calls it fort. If i'm not mistaken when i do .details it gets me a FortDetails. But i can change it


Remove


That should be fixed by #1350.


Now the Ars Antiqua has the same structure of the Ars Nova script.
Ars Antiqua doesn't consider partial imperfection because it doesn't exist in this repertory.

It is really important to run the script correct_ties.py before executing any of the other two scripts (ars-antiqua.py or ars-nova.py), so the mei-file that we use as input for any of these two scripts is correct.


develop (EnergyArchmage) - i386-Windows-7-VisualStudio-12: OK (1684 of 1684 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


We need to think if there is abetter way to pass this flag around, but for now this is a +1


由于下面的这段代码，导致了每次退出都有会有问题，好好研究下怎么回事？
`             'verbs' => [
                 'class' => VerbFilter::className(),
                 'actions' => [
                     'logout' => ['post'],
                 ],
             ],`


This implies that one component cannot get another component's owner. This makes it harder for components to cooperate. For example, suppose component A is passed as an argument to component B and B wants to get the name or transform of A's scene object. This is a perfect reasonable thing to want to do but this change will prohibit it.


This commit is giving me this error

```
2016-07-21 17:42:54,862 [     models] [   INFO] Upserting 1 pokemon
Exception in thread search_thread:
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 810, in __bootstrap_inner
    self.run()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 763, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/Users/bernardoarevalo/Desktop/PokemonGo-Map/pogom/search.py", line 94, in search_loop
    search(args)
  File "/Users/bernardoarevalo/Desktop/PokemonGo-Map/pogom/search.py", line 83, in search
    parse_map(response_dict)
  File "/Users/bernardoarevalo/Desktop/PokemonGo-Map/pogom/models.py", line 132, in parse_map
    bulk_upsert(Pokemon, pokemons)
  File "/Users/bernardoarevalo/Desktop/PokemonGo-Map/pogom/models.py", line 149, in bulk_upsert
    InsertQuery(cls, rows=data.values()[i:min(i+step, num_rows)]).upsert().execute()
  File "/Library/Python/2.7/site-packages/peewee.py", line 3244, in execute
    cursor = self._execute()
  File "/Library/Python/2.7/site-packages/peewee.py", line 2656, in _execute
    return self.database.execute_sql(sql, params, self.require_commit)
  File "/Library/Python/2.7/site-packages/peewee.py", line 3492, in execute_sql
    self.commit()
  File "/Library/Python/2.7/site-packages/peewee.py", line 3316, in __exit__
    reraise(new_type, new_type(*exc_args), traceback)
  File "/Library/Python/2.7/site-packages/peewee.py", line 3485, in execute_sql
    cursor.execute(sql, params or ())
IntegrityError: NOT NULL constraint failed: pokemon.detect_time

```


Wouldn't this continue be outside the if cond?


Remove this file


develop (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (1684 of 1684 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Is this using system pip or the pip in the user's directory? Try to remove the system pip first.


> ダメっていうのは、「起動しない」という意味でしょうか。

ではないです。起動はすると思います。
意図しない挙動にならないか、ということです。

milter manager内では直接使わないように作っているはずですが、たとえば、[g_timeout_add()](https://developer.gnome.org/glib/stable/glib-The-Main-Event-Loop.html#g-timeout-add)はどのイベントループにタイムアウトを設定するかを指定しなくても動くようになっています。このときにデフォルトのイベントループを使います。通常、イベントループは1プロセス（もう少し言うと1スレッド）に1つあれば十分なので、使いやすさ（APIの引数が減る）とユースケースのカバー具合のバランスからいって、妥当な判断だと私は思っています。

milter managerはイベントループのバックエンドが選択可能で、デフォルトのイベントループ「オブジェクト」を用意していないので、milter manager内のイベントループを使うAPIでは明示的にイベントループオブジェクトを指定しています。ただし、デフォルトはGLibのイベントループを使うようになっているので、他のGLibを使うライブラリーとかともいい感じに連携できた方がいいと思っています。（頻度は少ないのでそんなに手間暇はかけたくないですが。）

で、そのとき、他のGLibを使うライブラリーではデフォルトのイベントループを仮定することは自然なことです。GTK+もそうしていていますし、GStreamerもそうしています。このとき、milter managerがデフォルトのイベントループを使っていないと、他のライブラリーが登録したタイムアウトだったりアイドルのコールバックだったりが呼び出されません。

このあたりが意図しない挙動にならない？です。


We talked about using the python version you are using now in virtualenv? did we do that?


auto=meldfrom(arbor elf|Arbor Colossus)
 would be written on the arc runner in the exmaple above


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#NO4ubrHZSBewqDy2Vn90JQ


++ thanks


@gitdudy Hello world


> :memo: forkした子プロセス側で使うやつだからデフォルトコンテキストではない、と判断したはず。あんまり理解できていない箇所だった。

デフォルトのコンテキストを使うかどうかの判断基準は、それが「メインの」イベントループになるかどうかです。子プロセスで「メインの」イベントループになるならデフォルトのコンテキストが適切です。

milter-client.cでは`accept()`するためのイベントループはデフォルトのコンテキストを使っていません。これは、`accept()`は「メインの」イベントループではないからです。「メインの」イベントループはMTAからのmilterプロトコルでの接続を処理するイベントループです。`accpet()`用のイベントループは`accept()`だけ頑張ればよく、そこに、外部からタイムアウトだったりなんなりのイベントを追加することは期待されていません。（`accept()`用のイベントループは専用のスレッドを作ってそのなかで回しています。）


os_2_0_kill_super_build (kbenne) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Correct and fixed.


Constants must be CamelCase in the API


Rules or EgressRules.  Egress is redundant probably - you're not going to add ingress rules to an egress policy.


I'm still hung up on this being EgressFirewall instead of EgressNetworkPolicy.  Can you articulate why Firewall is better than *NetworkPolicy? (we are using *Policy in a lot more places now, so the burden is to justify the difference)


it is very good


Probably need to indicate these are paired, otherwise when there are many of them they will be hard to read.  Better as one line, not two.


There are no implications to letting the policy be changed, correct?


Okay.


done


Yes. I forgot it :( Thanks!


iteration (Unknown) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2368 of 2447 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.77%25-yellow.svg)


Do this in validation in the API, not in clients.  In a degenerate case this could result in a security vulnerability.  Limit to something reasonable that we can grow later, like 50.


Yes, it makes sense.


Have used the online checker at http://pep8online.com/checkresult.


iteration (Unknown) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


os_2_0_kill_super_build (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Can we pick a difference character here?  # already has meaning in URLs and I'd rather avoid the headache of bad client libraries down the road.


Oh fancy. Did you use `gofmt -r` to rewrite as well? :)


Хай помилку теж передає, на всякій


Or perhaps better suited for this, `eg` ([doc](https://github.com/golang/tools/blob/master/refactor/eg/eg.go#L22))

```
go get golang.org/x/tools/cmd/eg
```


I'm also unable to change the bloody ColumnWidth to 0


lgtm


os_2_0_kill_super_build (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg)


Поміняй тут ще роут, і витреш тоді TODO


І тут теж роут поміняй, і витреш тоді TODO


revert wegen https://github.com/VfN-NRW/gluon-firmware-builder/issues/6


instead of this t.close() here is it feasible to employ a `with` over at
```
     try:
         t = tarfile.open(fileobj=pkgfile)
```
which is around line 628


just fyi this commit is very unfinished!


test


That complicates the rest of the function due to error handling.  I thought about it, but decided not to re-indent the entire function to do that.