[R/class-constraint.R:12:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-constraint.R#L12) *style:* **lines should not be more than 80 characters.**
```r
                                # TODO: check that (l|r)hs is in the correct format
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:4:6:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L4) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  for(x in c(var_name, names(bound_subscripts))) {
     ^
```
[R/class-model.R:13:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L13) *style:* **Variable and function names should be all lowercase.**
```r
ObjectiveFunction <- setClass("ObjectiveFunction",
^~~~~~~~~~~~~~~~~
```
[R/class-model.R:53:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L53) *style:* **lines should not be more than 80 characters.**
```r
              bound_exp <- bind_expression(var_name, exp, parent.frame(), list())
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:58:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L58) *style:* **lines should not be more than 80 characters.**
```r
              search_key <- paste0(as.character(bound_exp[3:length(bound_exp)]), collapse = "_")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:84:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L84) *style:* **lines should not be more than 80 characters.**
```r
setGeneric("add_variable", function(model, variable, type = "continuous", lb = -Inf, ub = Inf, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:91:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L91) *style:* **lines should not be more than 80 characters.**
```r
          definition = function(model, variable, type = "continuous", lb = -Inf, ub = Inf, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:102:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L102) *style:* **lines should not be more than 80 characters.**
```r
                         variable_expression = as.expression(substitute(x, list(x = var_name))),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:111:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L111) *style:* **lines should not be more than 80 characters.**
```r
              bound_exp <- bind_expression(var_name, exp, parent.frame(), bound_subscripts)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:115:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L115) *style:* **lines should not be more than 80 characters.**
```r
              subscripts <- lapply(3:length(bound_exp), function(x) as.character(bound_exp[x]))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:116:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L116) *style:* **lines should not be more than 80 characters.**
```r
              bound_subscripts <- bound_subscripts[names(bound_subscripts) %in% subscripts]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:117:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L117) *style:* **lines should not be more than 80 characters.**
```r
              subscripts[subscripts %in% names(bound_subscripts)] <- bound_subscripts
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:122:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L122) *style:* **lines should not be more than 80 characters.**
```r
                                               function(r) all(!is.na(suppressWarnings(as.integer(r)))))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:124:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L124) *style:* **lines should not be more than 80 characters.**
```r
              instances <- apply(candidates, 1, function(row) paste0(as.integer(row), collapse = "_"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:169:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L169) *style:* **lines should not be more than 80 characters.**
```r
              stop("The objective is probably non-linear. Currently, only linear functions are supported.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:186:13:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L186) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
            }, object@variables)
            ^
```
[R/class-model.R:190:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L190) *style:* **lines should not be more than 80 characters.**
```r
            }, mapped_vars, init = list(continuous = 0, integer = 0, binary = 0))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:190:13:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L190) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
            }, mapped_vars, init = list(continuous = 0, integer = 0, binary = 0))
            ^
```
[R/class-model.R:221:24:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L221) *style:* **Use <-, not =, for assignment.**
```r
            parent_env = parent.frame()
                       ^
```
[R/class-model.R:227:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L227) *style:* **lines should not be more than 80 characters.**
```r
                stop("The left-hand-side is probably non-linear. Currently, only linear constraints are supported.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:230:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L230) *style:* **lines should not be more than 80 characters.**
```r
                stop("The right-hand-side is probably non-linear. Currently, only linear constraints are supported.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:233:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L233) *style:* **lines should not be more than 80 characters.**
```r
                stop("Some variable indexes are unbounded left hand expression.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:236:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L236) *style:* **lines should not be more than 80 characters.**
```r
                stop("Some variable indexes are unbounded in the right hand expression.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:240:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L240) *style:* **lines should not be more than 80 characters.**
```r
                                direction = if (direction == "=") "==" else direction)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:245:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-model.R#L245) *style:* **lines should not be more than 80 characters.**
```r
              bound_subscripts <- Filter(function(x) is.integer(x) & length(x) > 0,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-solution.R:10:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-solution.R#L10) *style:* **lines should not be more than 80 characters.**
```r
                                object@status %in% c("infeasible", "unbounded", "optimal") &&
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-solution.R:32:18:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-solution.R#L32) *style:* **Place a space before left parenthesis, except in a function call.**
```r
              for(i in 3:length(ast)) {
                 ^
```
[R/class-solution.R:41:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-solution.R#L41) *style:* **lines should not be more than 80 characters.**
```r
              instance_pattern <- paste0(var_name, "\\[", paste0(idx_pattern, collapse = ","), "\\]")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-solution.R:43:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-solution.R#L43) *style:* **lines should not be more than 80 characters.**
```r
                return(solution@solution[grepl(x = names(solution@solution), pattern = instance_pattern)])
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-solution.R:46:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-solution.R#L46) *style:* **lines should not be more than 80 characters.**
```r
                var_index <- stringr::str_match(names(solution@solution), pattern = instance_pattern)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-solution.R:49:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-solution.R#L49) *style:* **lines should not be more than 80 characters.**
```r
                var_values <- solution@solution[grepl(names(solution@solution), pattern = instance_pattern)]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-solution.R:62:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/class-solution.R#L62) *style:* **lines should not be more than 80 characters.**
```r
                stop("Either variable is not part of the model or you have to specify the indexes.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:7:3:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L7) *warning:* **local variable ‘parent_frame’ assigned but may not be used**
```r
  parent_frame <- parent.frame()
  ^~~~~~~~~~~~
```
[R/helper.R:13:6:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L13) *style:* **Commented code should be removed.**
```r
    #parent.env(binding_env) <- parent_frame
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:14:5:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L14) *warning:* **no visible global function definition for ‘try_eval_exp_rec’**
```r
    try_eval_exp_rec(ast, binding_env)
    ^~~~~~~~~~~~~~~~
```
[R/helper.R:17:16:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L17) *warning:* **no visible global function definition for ‘try_eval_exp_rec’**
```r
    el_eval <- try_eval_exp_rec(el)
               ^~~~~~~~~~~~~~~~
```
[R/helper.R:22:3:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L22) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  }, x = list_of_eval_exps, init = NULL)
  ^
```
[R/helper.R:27:10:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L27) *warning:* **no visible global function definition for ‘bind_variables’**
```r
  ast <- bind_variables(model, expression, environment)
         ^~~~~~~~~~~~~~
```
[R/helper.R:28:10:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L28) *warning:* **no visible global function definition for ‘try_eval_exp_rec’**
```r
  ast <- try_eval_exp_rec(ast)
         ^~~~~~~~~~~~~~~~
```
[R/helper.R:29:3:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L29) *warning:* **no visible global function definition for ‘check_expression’**
```r
  check_expression(model, ast)
  ^~~~~~~~~~~~~~~~
```
[R/helper.R:30:10:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L30) *warning:* **no visible global function definition for ‘standardize_ast’**
```r
  ast <- standardize_ast(ast)
         ^~~~~~~~~~~~~~~
```
[R/helper.R:37:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L37) *style:* **lines should not be more than 80 characters.**
```r
    calling_env <- calling_env[!(names(calling_env) %in% names(model@variables))]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:41:12:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L41) *warning:* **no visible global function definition for ‘try_eval_exp_rec’**
```r
    return(try_eval_exp_rec(ast, calling_env))
           ^~~~~~~~~~~~~~~~
```
[R/helper.R:53:10:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L53) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      for(i in 3:length(ast)) {
         ^
```
[R/helper.R:64:10:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L64) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      for(i in 3:length(ast)) {
         ^
```
[R/helper.R:84:8:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L84) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    for(i in 2:length(the_ast)) {
       ^
```
[R/helper.R:102:21:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L102) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
    new_ast_eval <- try_eval_exp(ast, envir)
                    ^~~~~~~~~~~~
```
[R/helper.R:115:10:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L115) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      for(i in 3:length(le_ast)) {
         ^
```
[R/helper.R:120:8:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L120) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    for(i in 2:length(new_ast)) {
       ^
```
[R/helper.R:124:21:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L124) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
    new_ast_eval <- try_eval_exp(new_ast, envir)
                    ^~~~~~~~~~~~
```
[R/helper.R:137:10:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L137) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      for(i in 2:length(le_ast)) {
         ^
```
[R/helper.R:151:8:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L151) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    for(i in 2:length(ast)) {
       ^
```
[R/helper.R:203:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L203) *style:* **lines should not be more than 80 characters.**
```r
          return(standardize_ast(substitute(-y * x, list(x = ast[[2]], y = multiply))))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:214:25:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L214) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
        new_ast[[2]] <- try_eval_exp(new_ast[[2]])
                        ^~~~~~~~~~~~
```
[R/helper.R:215:25:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L215) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
        new_ast[[3]] <- try_eval_exp(new_ast[[3]])
                        ^~~~~~~~~~~~
```
[R/helper.R:222:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L222) *style:* **lines should not be more than 80 characters.**
```r
          standardize_ast(substitute(x + -1 * y, list(x = ast[[2]], y = ast[[3]])))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:225:43:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L225) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
          new_ast[[2]] <- standardize_ast(try_eval_exp(new_ast[[2]]))
                                          ^~~~~~~~~~~~
```
[R/helper.R:226:43:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L226) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
          new_ast[[3]] <- standardize_ast(try_eval_exp(new_ast[[3]]))
                                          ^~~~~~~~~~~~
```
[R/helper.R:240:2:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L240) *style:* **Commented code should be removed.**
```r
#standardize_ast(substitute(3 * x[1]))
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:241:2:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L241) *style:* **Commented code should be removed.**
```r
#standardize_ast(substitute(3 * (y + x)))
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:242:2:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L242) *style:* **Commented code should be removed.**
```r
#standardize_ast(substitute((y + x) * 3))
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:243:2:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L243) *style:* **Commented code should be removed.**
```r
#standardize_ast(substitute((y - x + z + 10) * 3))
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:244:2:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L244) *style:* **Commented code should be removed.**
```r
#standardize_ast(substitute(((y - x) / 3 + z + 10) * 3))
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:245:2:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L245) *style:* **Commented code should be removed.**
```r
#standardize_ast(substitute(-3 * x[3] - 23))
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:258:36:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L258) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
        left <- extr_coef_internal(try_eval_exp(the_ast[[2]]))
                                   ^~~~~~~~~~~~
```
[R/helper.R:259:37:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L259) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
        right <- extr_coef_internal(try_eval_exp(the_ast[[3]]))
                                    ^~~~~~~~~~~~
```
[R/helper.R:265:25:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L265) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
        the_ast[[2]] <- try_eval_exp(the_ast[[2]])
                        ^~~~~~~~~~~~
```
[R/helper.R:266:25:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L266) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
        the_ast[[3]] <- try_eval_exp(the_ast[[3]])
                        ^~~~~~~~~~~~
```
[R/helper.R:288:55:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L288) *style:* **Commas should always have a space after.**
```r
        stop(paste0("Unexpected operator '", operator,"' found."))
                                                      ^
```
[R/helper.R:313:3:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/R/helper.R#L313) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  }, result$coefficients, init = list())
  ^
```
[tests/testthat/test-helpers.R:16:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/tests/testthat/test-helpers.R#L16) *style:* **lines should not be more than 80 characters.**
```r
  expect_equal(deparse(result), "weights[1L] * x[1L] + weights[2L] * x[2L] + weights[3L] * x[3L]")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helpers.R:32:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/tests/testthat/test-helpers.R#L32) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-model.R:39:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/tests/testthat/test-model.R#L39) *style:* **lines should not be more than 80 characters.**
```r
test_that("global variables do not interfere with variable names in expressions", {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-model.R:202:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/tests/testthat/test-model.R#L202) *style:* **lines should not be more than 80 characters.**
```r
    set_objective(sum_exp(distance_matrix[i, j] * x[i, j], i = 1:cities, j = 1:cities), direction = "min") %>%
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-model.R:205:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/tests/testthat/test-model.R#L205) *style:* **lines should not be more than 80 characters.**
```r
    add_constraint(sum_exp(x[i, j], i = sub_tours[[s]], j = sub_tours[[s]]), "<=", length(sub_tours[s]) - 1, s = 1:length(sub_tours))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-solution.R:26:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/tests/testthat/test-solution.R#L26) *style:* **lines should not be more than 80 characters.**
```r
                             solution = setNames(c(1, 1, 1), c("x[1]", "x[3]", "x[3]")))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-solution.R:51:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/tests/testthat/test-solution.R#L51) *style:* **lines should not be more than 80 characters.**
```r
                  solution = setNames(c(1, 1, 1, 1), c("x[1,1]", "x[1,2]", "x[2,1]", "x[2,2]")))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-solution.R:52:40:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/tests/testthat/test-solution.R#L52) *style:* **Commas should always have a space after.**
```r
  result <- get_solution(solution, x[i,j])
                                       ^
```
[tests/testthat/test-solution.R:68:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/tests/testthat/test-solution.R#L68) *style:* **lines should not be more than 80 characters.**
```r
                              solution = setNames(c(1, 1, 1), c("x[1]", "x[3]", "x[3]")))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-solution.R:92:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/tests/testthat/test-solution.R#L92) *style:* **lines should not be more than 80 characters.**
```r
test_that("export solutions to data.frame in a model with more than one variable", {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-solution.R:123:1:](https://github.com/dirkschumacher/ompr/blob/46c958ed623156ff93453f0e570acd8a1903ad90/tests/testthat/test-solution.R#L123) *style:* **Trailing blank lines are superfluous.**
```r

^
```


After this commit when I try to connect to "127.0.0.1:5901" it says connection refused. After I revert it everything goes back to normal.


should be `ember-glimmer-allow-two-way-reflush`


Hey.

I just compiled the kernel with the older version of the commit and then I made a hacky tweak in hid-core that treats all lenovo devices the same as synaptics. Now my touchpad is working!

Thank you so much for your work on this. I am going to take the 13 commits off the top of your branch and patch my kernel with them. I’ll let you know how it goes.

Thanks!

Leif

> On Jul 8, 2016, at 12:20 PM, Andrew Duggan <notifications@github.com> wrote:
>
> The development/hid-rmi branch actually has a newer version of this commit (e9afe8b <https://github.com/aduggan/linux/commit/e9afe8bdec975cdfa08ca0eee74709641b98bb35>) which was submitted upstream https://lkml.org/lkml/2016/6/24/707 <https://lkml.org/lkml/2016/6/24/707>. This new version also relies on a patch series https://lkml.org/lkml/2016/6/24/700 <https://lkml.org/lkml/2016/6/24/700>, but the development/hid-rmi already has all of those commits applied.
>
> Also, based on the info you provided it sounds like you would need this commit to get hid-rmi to bind to your device f856854 <https://github.com/aduggan/linux/commit/f85685441703f89ed0dae6cb2f0c7cac0b83605b>. If that works for you I can submit it upstream once the hid-rmi changes are accepted.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub <https://github.com/aduggan/linux/commit/8446f962ba918df9aa77ec8e4363e2a51dfbef09#commitcomment-18177305>, or mute the thread <https://github.com/notifications/unsubscribe/ADaaDkCALzd37TpSBCRITqnCclkyIiIyks5qTobNgaJpZM4JHWL5>.
>


More strangely, I checked ICD for instances of string "GL_ATI_meminfo" and there is one instance :confused: so maybe skip the check GLLoader::found_GL_ATI_meminfo ...


:fire:


[R/class-constraint.R:12:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-constraint.R#L12) *style:* **lines should not be more than 80 characters.**
```r
                                # TODO: check that (l|r)hs is in the correct format
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:4:6:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L4) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  for(x in c(var_name, names(bound_subscripts))) {
     ^
```
[R/class-model.R:13:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L13) *style:* **Variable and function names should be all lowercase.**
```r
ObjectiveFunction <- setClass("ObjectiveFunction",
^~~~~~~~~~~~~~~~~
```
[R/class-model.R:53:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L53) *style:* **lines should not be more than 80 characters.**
```r
              bound_exp <- bind_expression(var_name, exp, parent.frame(), list())
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:58:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L58) *style:* **lines should not be more than 80 characters.**
```r
              search_key <- paste0(as.character(bound_exp[3:length(bound_exp)]), collapse = "_")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:84:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L84) *style:* **lines should not be more than 80 characters.**
```r
setGeneric("add_variable", function(model, variable, type = "continuous", lb = -Inf, ub = Inf, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:91:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L91) *style:* **lines should not be more than 80 characters.**
```r
          definition = function(model, variable, type = "continuous", lb = -Inf, ub = Inf, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:102:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L102) *style:* **lines should not be more than 80 characters.**
```r
                         variable_expression = as.expression(substitute(x, list(x = var_name))),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:111:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L111) *style:* **lines should not be more than 80 characters.**
```r
              bound_exp <- bind_expression(var_name, exp, parent.frame(), bound_subscripts)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:115:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L115) *style:* **lines should not be more than 80 characters.**
```r
              subscripts <- lapply(3:length(bound_exp), function(x) as.character(bound_exp[x]))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:116:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L116) *style:* **lines should not be more than 80 characters.**
```r
              bound_subscripts <- bound_subscripts[names(bound_subscripts) %in% subscripts]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:117:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L117) *style:* **lines should not be more than 80 characters.**
```r
              subscripts[subscripts %in% names(bound_subscripts)] <- bound_subscripts
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:122:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L122) *style:* **lines should not be more than 80 characters.**
```r
                                               function(r) all(!is.na(suppressWarnings(as.integer(r)))))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:124:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L124) *style:* **lines should not be more than 80 characters.**
```r
              instances <- apply(candidates, 1, function(row) paste0(as.integer(row), collapse = "_"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:169:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L169) *style:* **lines should not be more than 80 characters.**
```r
              stop("The objective is probably non-linear. Currently, only linear functions are supported.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:186:13:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L186) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
            }, object@variables)
            ^
```
[R/class-model.R:190:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L190) *style:* **lines should not be more than 80 characters.**
```r
            }, mapped_vars, init = list(continuous = 0, integer = 0, binary = 0))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:190:13:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L190) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
            }, mapped_vars, init = list(continuous = 0, integer = 0, binary = 0))
            ^
```
[R/class-model.R:221:24:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L221) *style:* **Use <-, not =, for assignment.**
```r
            parent_env = parent.frame()
                       ^
```
[R/class-model.R:227:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L227) *style:* **lines should not be more than 80 characters.**
```r
                stop("The left-hand-side is probably non-linear. Currently, only linear constraints are supported.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:230:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L230) *style:* **lines should not be more than 80 characters.**
```r
                stop("The right-hand-side is probably non-linear. Currently, only linear constraints are supported.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:233:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L233) *style:* **lines should not be more than 80 characters.**
```r
                stop("Some variable indexes are unbounded left hand expression.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:236:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L236) *style:* **lines should not be more than 80 characters.**
```r
                stop("Some variable indexes are unbounded in the right hand expression.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:240:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L240) *style:* **lines should not be more than 80 characters.**
```r
                                direction = if (direction == "=") "==" else direction)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-model.R:245:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-model.R#L245) *style:* **lines should not be more than 80 characters.**
```r
              bound_subscripts <- Filter(function(x) is.integer(x) & length(x) > 0,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-solution.R:10:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-solution.R#L10) *style:* **lines should not be more than 80 characters.**
```r
                                object@status %in% c("infeasible", "unbounded", "optimal") &&
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-solution.R:32:18:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-solution.R#L32) *style:* **Place a space before left parenthesis, except in a function call.**
```r
              for(i in 3:length(ast)) {
                 ^
```
[R/class-solution.R:41:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-solution.R#L41) *style:* **lines should not be more than 80 characters.**
```r
              instance_pattern <- paste0(var_name, "\\[", paste0(idx_pattern, collapse = ","), "\\]")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-solution.R:43:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-solution.R#L43) *style:* **lines should not be more than 80 characters.**
```r
                return(solution@solution[grepl(x = names(solution@solution), pattern = instance_pattern)])
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-solution.R:46:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-solution.R#L46) *style:* **lines should not be more than 80 characters.**
```r
                var_index <- stringr::str_match(names(solution@solution), pattern = instance_pattern)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-solution.R:49:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-solution.R#L49) *style:* **lines should not be more than 80 characters.**
```r
                var_values <- solution@solution[grepl(names(solution@solution), pattern = instance_pattern)]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/class-solution.R:62:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/class-solution.R#L62) *style:* **lines should not be more than 80 characters.**
```r
                stop("Either variable is not part of the model or you have to specify the indexes.")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:7:3:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L7) *warning:* **local variable ‘parent_frame’ assigned but may not be used**
```r
  parent_frame <- parent.frame()
  ^~~~~~~~~~~~
```
[R/helper.R:13:6:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L13) *style:* **Commented code should be removed.**
```r
    #parent.env(binding_env) <- parent_frame
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:14:5:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L14) *warning:* **no visible global function definition for ‘try_eval_exp_rec’**
```r
    try_eval_exp_rec(ast, binding_env)
    ^~~~~~~~~~~~~~~~
```
[R/helper.R:17:16:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L17) *warning:* **no visible global function definition for ‘try_eval_exp_rec’**
```r
    el_eval <- try_eval_exp_rec(el)
               ^~~~~~~~~~~~~~~~
```
[R/helper.R:22:3:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L22) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  }, x = list_of_eval_exps, init = NULL)
  ^
```
[R/helper.R:27:10:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L27) *warning:* **no visible global function definition for ‘bind_variables’**
```r
  ast <- bind_variables(model, expression, environment)
         ^~~~~~~~~~~~~~
```
[R/helper.R:28:10:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L28) *warning:* **no visible global function definition for ‘try_eval_exp_rec’**
```r
  ast <- try_eval_exp_rec(ast)
         ^~~~~~~~~~~~~~~~
```
[R/helper.R:29:3:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L29) *warning:* **no visible global function definition for ‘check_expression’**
```r
  check_expression(model, ast)
  ^~~~~~~~~~~~~~~~
```
[R/helper.R:30:10:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L30) *warning:* **no visible global function definition for ‘standardize_ast’**
```r
  ast <- standardize_ast(ast)
         ^~~~~~~~~~~~~~~
```
[R/helper.R:37:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L37) *style:* **lines should not be more than 80 characters.**
```r
    calling_env <- calling_env[!(names(calling_env) %in% names(model@variables))]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:41:12:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L41) *warning:* **no visible global function definition for ‘try_eval_exp_rec’**
```r
    return(try_eval_exp_rec(ast, calling_env))
           ^~~~~~~~~~~~~~~~
```
[R/helper.R:53:10:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L53) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      for(i in 3:length(ast)) {
         ^
```
[R/helper.R:64:10:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L64) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      for(i in 3:length(ast)) {
         ^
```
[R/helper.R:84:8:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L84) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    for(i in 2:length(the_ast)) {
       ^
```
[R/helper.R:102:21:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L102) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
    new_ast_eval <- try_eval_exp(ast, envir)
                    ^~~~~~~~~~~~
```
[R/helper.R:115:10:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L115) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      for(i in 3:length(le_ast)) {
         ^
```
[R/helper.R:120:8:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L120) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    for(i in 2:length(new_ast)) {
       ^
```
[R/helper.R:124:21:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L124) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
    new_ast_eval <- try_eval_exp(new_ast, envir)
                    ^~~~~~~~~~~~
```
[R/helper.R:137:10:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L137) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      for(i in 2:length(le_ast)) {
         ^
```
[R/helper.R:151:8:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L151) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    for(i in 2:length(ast)) {
       ^
```
[R/helper.R:203:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L203) *style:* **lines should not be more than 80 characters.**
```r
          return(standardize_ast(substitute(-y * x, list(x = ast[[2]], y = multiply))))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:214:25:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L214) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
        new_ast[[2]] <- try_eval_exp(new_ast[[2]])
                        ^~~~~~~~~~~~
```
[R/helper.R:215:25:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L215) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
        new_ast[[3]] <- try_eval_exp(new_ast[[3]])
                        ^~~~~~~~~~~~
```
[R/helper.R:222:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L222) *style:* **lines should not be more than 80 characters.**
```r
          standardize_ast(substitute(x + -1 * y, list(x = ast[[2]], y = ast[[3]])))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:225:43:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L225) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
          new_ast[[2]] <- standardize_ast(try_eval_exp(new_ast[[2]]))
                                          ^~~~~~~~~~~~
```
[R/helper.R:226:43:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L226) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
          new_ast[[3]] <- standardize_ast(try_eval_exp(new_ast[[3]]))
                                          ^~~~~~~~~~~~
```
[R/helper.R:240:2:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L240) *style:* **Commented code should be removed.**
```r
#standardize_ast(substitute(3 * x[1]))
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:241:2:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L241) *style:* **Commented code should be removed.**
```r
#standardize_ast(substitute(3 * (y + x)))
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:242:2:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L242) *style:* **Commented code should be removed.**
```r
#standardize_ast(substitute((y + x) * 3))
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:243:2:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L243) *style:* **Commented code should be removed.**
```r
#standardize_ast(substitute((y - x + z + 10) * 3))
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:244:2:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L244) *style:* **Commented code should be removed.**
```r
#standardize_ast(substitute(((y - x) / 3 + z + 10) * 3))
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:245:2:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L245) *style:* **Commented code should be removed.**
```r
#standardize_ast(substitute(-3 * x[3] - 23))
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/helper.R:258:36:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L258) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
        left <- extr_coef_internal(try_eval_exp(the_ast[[2]]))
                                   ^~~~~~~~~~~~
```
[R/helper.R:259:37:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L259) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
        right <- extr_coef_internal(try_eval_exp(the_ast[[3]]))
                                    ^~~~~~~~~~~~
```
[R/helper.R:265:25:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L265) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
        the_ast[[2]] <- try_eval_exp(the_ast[[2]])
                        ^~~~~~~~~~~~
```
[R/helper.R:266:25:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L266) *warning:* **no visible global function definition for ‘try_eval_exp’**
```r
        the_ast[[3]] <- try_eval_exp(the_ast[[3]])
                        ^~~~~~~~~~~~
```
[R/helper.R:288:55:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L288) *style:* **Commas should always have a space after.**
```r
        stop(paste0("Unexpected operator '", operator,"' found."))
                                                      ^
```
[R/helper.R:313:3:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/R/helper.R#L313) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
  }, result$coefficients, init = list())
  ^
```
[tests/testthat/test-helpers.R:16:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/tests/testthat/test-helpers.R#L16) *style:* **lines should not be more than 80 characters.**
```r
  expect_equal(deparse(result), "weights[1L] * x[1L] + weights[2L] * x[2L] + weights[3L] * x[3L]")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helpers.R:32:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/tests/testthat/test-helpers.R#L32) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-model.R:39:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/tests/testthat/test-model.R#L39) *style:* **lines should not be more than 80 characters.**
```r
test_that("global variables do not interfere with variable names in expressions", {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-model.R:202:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/tests/testthat/test-model.R#L202) *style:* **lines should not be more than 80 characters.**
```r
    set_objective(sum_exp(distance_matrix[i, j] * x[i, j], i = 1:cities, j = 1:cities), direction = "min") %>%
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-model.R:205:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/tests/testthat/test-model.R#L205) *style:* **lines should not be more than 80 characters.**
```r
    add_constraint(sum_exp(x[i, j], i = sub_tours[[s]], j = sub_tours[[s]]), "<=", length(sub_tours[s]) - 1, s = 1:length(sub_tours))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-solution.R:26:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/tests/testthat/test-solution.R#L26) *style:* **lines should not be more than 80 characters.**
```r
                             solution = setNames(c(1, 1, 1), c("x[1]", "x[3]", "x[3]")))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-solution.R:51:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/tests/testthat/test-solution.R#L51) *style:* **lines should not be more than 80 characters.**
```r
                  solution = setNames(c(1, 1, 1, 1), c("x[1,1]", "x[1,2]", "x[2,1]", "x[2,2]")))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-solution.R:52:40:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/tests/testthat/test-solution.R#L52) *style:* **Commas should always have a space after.**
```r
  result <- get_solution(solution, x[i,j])
                                       ^
```
[tests/testthat/test-solution.R:68:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/tests/testthat/test-solution.R#L68) *style:* **lines should not be more than 80 characters.**
```r
                              solution = setNames(c(1, 1, 1), c("x[1]", "x[3]", "x[3]")))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-solution.R:92:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/tests/testthat/test-solution.R#L92) *style:* **lines should not be more than 80 characters.**
```r
test_that("export solutions to data.frame in a model with more than one variable", {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-solution.R:123:1:](https://github.com/dirkschumacher/ompr/blob/5b08f584f0f3e34c103a6b1d9fa0bb801a72412d/tests/testthat/test-solution.R#L123) *style:* **Trailing blank lines are superfluous.**
```r

^
```


recuerda acomodar esto, no puedo eliminar los archivos de la carpeta de imágenes cuando elimino el registro correspondiente en la base de datos.


@viktorklang Getting rid of PartialFunction entirely by folding it into Function1 is definitely a more reasonable solution than either the status quo or having PartialFunction extended by a Function1 that adds no information and merely serves as a marker trait. The difficulty that I see with your example, though, is that it then puts the onus on the caller to get it right and always use the `_ match { ... }` form or risk MatchError.

The way I see it, an ideal solution would have the following properties: (1) as the library author of foo, I am able to express, via the type system, that I will definitely call `isDefinedAt` or `applyOrElse` and will never call `apply` unguarded, *or* (by typing as Function1) that I will *never* call these. (2) as the caller of foo, I want to know with certainty which case I'm falling into - whether I need to make isDefinedAt maximally performant and can expect match failures to be handled gracefully, or whether I should be expected to handle all inputs in the function that I am passing.

This gets me back to my original suggestion, which is that there be no inheritance relationship whatsoever between Function1 and PartialFunction, but with the insight provided by this discussion, here is a modification; the two traits would simply be:

```
trait Function1[A, B] {
  def apply(a: A): B
}

trait PartialFunction[A, B] {
  def applyOrElse(a: A, b: => B): B
}

object PartialFunction {
  implicit def fromFunction1[A, B](f: Function1[A, B]): PartialFunction[A, B]
}
```


I see. I can't really tell from that facebook/flow commit, but leaving it out seems to resolve our issue.


Okay, I'll try to do what I need to do using simplify_assuming and let you
know how it goes. I'll need to pass in an expression unevaluated (i.e, with
quotes) because it, in general, can't be legally evaluated without the
`assuming` context.

On Fri, Jul 8, 2016 at 2:46 PM, Chung-chieh Shan <notifications@github.com>
wrote:

> Note that simplify_assuming nowadays does significantly more than piping
> kb_to_assumptions to simplify and assuming, so this function is not doing
> that additional part.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/hakaru-dev/hakaru/commit/94cc97cd712cff753ff0152064eedd405cd712bc#commitcomment-18178545>,
> or mute the thread
> <https://github.com/notifications/unsubscribe/ASYo9T1LCbnmn2zZQZmv3TQ-8OvMSy3mks5qTpsfgaJpZM4JIS1x>
> .
>


Make sure the Hamming similarity changes in the range [0,100] with 100 corresponding to identical vectors and decreasing as the difference in vector increases:

Converting to Sparse just to provide a uniform interface for all similarities, sparse vectors in particular and any data structure wrapped around Arrays of Doubles would not quite work. We need to consider underlying Arrays of Bytes for Hamming similarity!

```scala
val sv1 = Vectors.dense(1.0, 0.0, 3.0).toSparse
val sv2 = Vectors.dense(1.0, 0.0, 3.0).toSparse
val sv3 = Vectors.dense(-100.0, 0.0, -300.0).toSparse
```

```bash
scala> HammingDistance.compute(sv1,sv2)
res1: Double = 100.0

scala> HammingDistance.compute(sv1,sv3)
res2: Double = 8.333333333333334
```


* I meant semicolon (I'm very tired)


typeof operator is much faster that using instanceof and/or the terribly slow toString() to detect object class!


iuztfrdfghjklöälkjhgfdsdfghjk


Thanks @unity for the clarification. I saw you've updated the specs.

I will alter the code, but do you think that following sentences: "This will empty the list you picked" and "click the “Sync all users and segments” button below to empty and refill the list" match the described behavior?


You can avoid the derefencing of the global instance since it's already in the context.


Got it, I'll comment out that line.


Me gusto


@hgtonight, good point. The media queries I added can be applied to any responsive theme, but some people may have different max-width preferences, so would that cause an issue if I merged it into the base CSS file?


check last commit


See related: https://github.com/chef/bento/pull/619


my environment expects package.json file there to read dependencies to install.


If simplify_assuming will handle all uses of `assuming`, then I can just
get rid of &assuming.

If the interface to Maple's own `assuming` were correct, I wouldn't need
&assuming. But the interface is flawed because it won't take NULL as the
right operand. It will take the empty list, but it won't take a nonempty
list with valid assumptions. Those two flaws taken together make `assuming`
messy to use in our "knowledge base" format. You can see the hack that I
used for this in the prior edition of NewSLO:-Reparam. I just want a
consistent one-line method to handle all `assuming` cases, including the
case of no assumptions.

On Fri, Jul 8, 2016 at 2:46 PM, Chung-chieh Shan <notifications@github.com>
wrote:

> The interface of this function doesn't seem compatible with the assuming
> that comes with Maple, so I wouldn't say that it's a wrapper and I wouldn't
> name it &assuming.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/hakaru-dev/hakaru/commit/94cc97cd712cff753ff0152064eedd405cd712bc#commitcomment-18178527>,
> or mute the thread
> <https://github.com/notifications/unsubscribe/ASYo9bZUCMnovTP3Ie1Y9Y5eYA46CvBXks5qTpr0gaJpZM4JIS1x>
> .
>


Zrz
Em 18/06/2016 01:39, "sitonmoon" <notifications@github.com> escreveu:

> 404
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/EpicGames/Signup/commit/91dc07dabbca8ad80a3fed5e56335609c2cc9bb7#commitcomment-17922115>,
> or mute the thread
> <https://github.com/notifications/unsubscribe/AMtzN686FS6wSEeDY9UuE-nmHfKV1mZeks5qM3ZxgaJpZM4HZ9P4>
> .
>


Hometask_4 completed


You don't have to use `string_dup` for these constant action strings. In this case
```c++
mjobctl_info->action = "suspend";
```
would be enough.


@lp-- Congrats on this patch!  Since it changes many things, there may be further discussions, and hopefully further Elo.

Regarding the throughput, I agree it is complicated.  Indeed, I went back to the original discussion, where joona also says things aren't as interpretable now
https://github.com/glinscott/fishtest/pull/72


- Maybe talk about foreign keys and cascading.
- Migrations are not just for creating and deleting databases, they're also used to upgrade tables, columns or even tweak the DB schema if new requirements needs to be fulfilled.


122060631Review-use-of-current-density-in-SingleDuctCalcOAMassFlow-#5366 (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2262 of 2262 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


122060631Review-use-of-current-density-in-SingleDuctCalcOAMassFlow-#5366 (lgu1234) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Nit: variable name.


Accidentally sent an "e" as commit message... Here's the short summary:

- Added a "picture" column to "artists" table.
- Whitelist the "picture" attribute in ArtistsController.
- Created a update.json.builder file that renders the updated artist as JSON.
- Converted the artists index table to a grid with image and name for each artist.
- Added holder.js to show a placeholder in both index and show pages for each artist's picture (unless the artist already had one).
- Wrote a script that runs when the show artist page is loading that checks if the artist has a picture, in case it does not have one then download the picture from randomuser.me and save it in database, if the artist has a picture then just show it.
- Disabled CSRF when accessing the API through JSON calls for easier access.


I'll try to improve it but hmr works now


Este otro comentario de prueba


Falta poner validación de solo números y no caracteres


👍

```
Results :

Tests run: 10, Failures: 0, Errors: 0, Skipped: 0
```


Yes.. No.. I think i want to but i dont know how to.. I think there should be a config for that :3


Not sure how big DWG files can be, but long is 32 bit only on Windows 64 bit.


looks like an unnecessary id here!


Calling out ReadPipe at all is weird because it's not the only thing in the case statement. The comment isn't necessary, and is also wrong.


Congrats! @lp-- another feather that will make SF stronger and stronger! We have 2 patches King Tropism and this one which both passed and which are both improvements, so a wonderful week for SF!


sugiero


There's nothing in this code that says GetConfig, ListBuilds et al are actually GET or HEAD routes. This comment isn't necessary, and creates confusion.


dcsdvvvs


ya


inflate创建view树的时候挂了，估计可能还是有东西填错了


This has been properly tested in the OSCommerce store, and works great.


Oops - wrong branch :-)

Fixed the tests by 34d724c6e1524be4807611a953e3a3739e3eaa0b.


"crit aura", "damage aura" and "lifesteal aura" are new attributes which were NOT tested, they should still work tho.


Tested in the CS-Cart demo store, works great.


@lfkdsk 我当时revert了，改动全部备份之后去掉了，都没啥卵用。


honestly this is way too much. Maybe half as much?


What is was before was correct, this last time I tried (with char) caused A LOT of issues with the SP compiler.


laaaaaaaafjal


This is a really good change! :+1:


#5284-EMS-function-RhovFnTdbRhLBnd0C-is-being-parsed-as-RhovFnTdbRh (rraustad) - x86_64-MacOS-10.9-clang: OK (2222 of 2222 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Done.


Agree with Michael. Your contribution  to eval is outstanding!


Congrats!


arm64ではデバイスツリー側での対策忘れないようにね


- You can talk about Eloquent Active Record pattern and state the difference with Data Mapper pattern. I don't know if this is a little bit advanced for this course!


Would this not have undesirable effects on legitimate content that had the word "New" at position 0 in the `Title` field? This is why in my pseudo code in #214 I attempted to check the value of the YML translation value of "New Page", as this is where the CMS gets the string "New Page" from. Not to mention should the "New Page" default string ever change, we'd always be sourcing the value from (presumably) the same YML key.


what thheeeee FUCKKKK !!!! Hör doch auf so eine scheiße tu machen !


One suggestion: the philosophy with projects like this is that normally you don't have the `output` directory in the repository. It makes sense to me because (among other things) you are changing hundreds of output files because of all the knowls and other html chunks. Since the output is generated from the `.mbx` source files, there is no need to include it in version control. It might not matter that much, but I would suggest not versioning the output.


Now that this is alphabetical please keep the order


@Stefano80 , it appears PNPLowerDepth has been hitting its upper bound for quite some time?


Valgrind is not installed by default.

You could install by the structure:
addons:
  apt:
    packages:
    - vagrind


tsc tsc


You will have problem with Travis


You could move this command on CMake, check this: https://github.com/Kurento/kms-cmake-utils/blob/master/CMake/TestHelpers.cmake


👍

See also cc7b6de79d2c986f1cffe951ddc8cf9b47b1e52e (unrelated).


@avit Which PR?

If this bug affects supported versions of Rails, we should fix it. But at the moment, tests are green so I'm unable to determine the validity.


Having looked at the PR, I can see that for whatever the current locale is, if the default non-locale `Title` field's value is "New xxxx", then it will receive the value of the equivalent field of the current locale.

Sorry, I no longer have a setup where I can immediately test this out (I've left Deviate) but AFAIKT this means that if I create a new page, switch to "FR" then _both_ the `Title_fr_FR` and `Title` fields will become populated with identical content.

So how does that help though? I can imagine CMS users seeing FR content in the `Title` field, when in any other CMS locale and thinking to themselves "I didn't add that there...hey Mr Dev..I found a bug!"

If memory serves and re-looking at my original bug report (which with hindsight is not as clear as it could have been, even though I swore it was at the time) I was thinking that if "New Page" existed, where non-default locale content existed also (i.e. basically a page sans a default locale translation) then simply do not show the locale switcher in the front end (and update the docs accordingly). That was what the `iTranslatedInto()` pseudo-code was attempting to demonstrate. Having thought about it more a better a solution would simply be to ensure that the default locale has its `LocaleFilter` field populated...although that does depend on having the `FluentFilteredExtension` applied.

I guess just a bit more background / rationale from you on the fix may help me here :-)


Your copy/paste is gone, and each commit from jgloom-io feat/resources is now also on jgloom dev (git magic)


![giphy 2](https://cloud.githubusercontent.com/assets/846873/16676004/2fa78510-4494-11e6-8fe6-369a8f29a969.gif)


No customize option in the config btw, might have missed that


Notice: Undefined variable: strong


ok fixed


Python code only


Please, how do I get this proyect?


Are the android logo and below legal wording used for China market?

 "Android 机器人是按照由Google 创建和共享 的作品而复制或修改，并根据《知识共享 3.0 署名许可》中所述的条款加以使用的"


中国的产品包装上是否需要出现android 信息？


I think it would be possible to write models as a combination of reactions and arbitrary RHS forms as f = f1 + f2, where f1 is S*r and f2 is your custom RHS. It would save the hassle of having to deal with two separate kinds of models, making things easier on the user, but you'd have to generate and keep track of twice as many sets of functions under the hood, making things harder for the programmer (though the changes should be limited to finalizeModelAnalytic).


Порядок CSS-свойств.
https://css-tricks.com/poll-results-how-do-you-order-your-css-properties/


`padding: 15px 15px 10px;`


#5284-EMS-function-RhovFnTdbRhLBnd0C-is-being-parsed-as-RhovFnTdbRh (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2262 of 2262 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Нужно определить viewport — https://css-tricks.com/snippets/html/responsive-meta-tag/


?ok.  Perhaps you can help me delete that folder? :)

Lynda A. Danielson, Ph.D.
Department of Mathematical & Physical Sciences
The College of Idaho
2112 Cleveland Blvd.
Caldwell, ID   83605
(208) 459-5231
ldanielson@collegeofidaho.edu<https://webmail.collegeofidaho.edu/owa/redir.aspx?C=77e18e26de0b421286efffeb43b99fc4&URL=mailto%3aldanielson%40collegeofidaho.edu>
________________________________
From: Dave Rosoff <notifications@github.com>
Sent: Thursday, July 7, 2016 8:26 PM
To: ladanielson/MAT101
Cc: Lynda Danielson; Author
Subject: Re: [ladanielson/MAT101] output through 2A, started 2B (3bb3bf2)

One suggestion: the philosophy with projects like this is that normally you don't have the output directory in the repository. It makes sense to me because (among other things) you are changing hundreds of output files because of all the knowls and other html chunks. Since the output is generated from the .mbx source files, there is no need to include it in version control. It might not matter that much, but I would suggest not versioning the output.

-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/ladanielson/MAT101/commit/3bb3bf21d22868f0801b4967971991bf5fdaa183#commitcomment-18168348>, or mute the thread<https://github.com/notifications/unsubscribe/AR0Ww4vdCu_Mi2XXGd0rw2KQfv7l7hycks5qTbVugaJpZM4JHq75>.


Hey, I'd be interested to know about the differences you're seeing when rendering on web, if they are due to issues with react-native-web.


Hey, thanks for making this code public. Could you please build the app and release an apk here so we can use it for getting the  colors of any image we want? Thanks in advance


Unfortunately, this ACTS page still seems to be protected. Not sure this is intentional given multiple references to the project that claimed to be public in various presentations, etc... On the other hand, the CMS software (https://gitlab.cern.ch/cms-sw/cmssw) is visible and browse-able.


关于Python学习过程中写的代码


I changed the tests to pass. I was wondering about whether the gem should be agnostic to key type ( string or symbol ) or if it should always return keys as symbols.


Actually if Robin is not yet ready to xsltproc David's `.mbx` files on her own, then I take it back: keep the output. I didn't realize that you could respond via email. You might want to edit your response since your phone number appears in it.


This avoids the issue of really abstract imports

`const PodcastModel = require('../../repositories/sequelize/models/podcast.js');`

vs

`const PodcastModel = require('repositories/sequelize/models/podcast.js');`

Setting node_path environment variable before launching like that tells the process to try discovering modules by first starting in the present working directory and if you cant find it there, then look in the src directory


#5284-EMS-function-RhovFnTdbRhLBnd0C-is-being-parsed-as-RhovFnTdbRh (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


hello


commit时的message可以写意一点，要不阅读你代码的人或者和你一起工作的人，都不知道这次commit干了什么


If we were to simplify this to merely `export NODE_PATH=$(pwd)`

then we have to change the referenced import to

`require('src/repositories/sequelize/models/podcast.js');`

which aint bad.  It's a stylistic choice to do this.


Потерялась иконка http://take.ms/N9oTO


Oh shit you messed up


try to coment


记得加上这个不错 👍


Perfect, thanks.


Много критичных неточностей — http://take.ms/7gG3j


To convert impress(libreoffice) to xml to impress.html


122060631Review-use-of-current-density-in-SingleDuctCalcOAMassFlow-#5366 (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1670 of 1671 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.96%25-green.svg)


0/10 Jolf is much better name than Bob.


Well, I can't change it now.


y naught


@nuttycom I don't see "the onus" as a problem, you already have the onus of terminating, not System.exit-ing, performing useful work with only the required resources etc :)

Having applyOrElse take a call-by-name would be a no-go since that means allocation ( I haven't seen the compiler being smart about that yet, but I stand corrected if that is the case, i.e. passing a Function0 doesn't box)

Also, lifting a F1[A,B] into PF[A,B] means allocations, which also incurs overhead.

One really nice feature with my proposal is that we'd get N-arity "PFs" for Free™
Also, I find the prospect of having `match` be a macro-method on Any much more *conceptually* nicer than having to be a compiler-baked-in thing. :)


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1667 of 1667 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I'd rather not, Riker likes it, and idk how to rename a repo


This is nice, but V4L2_PIX_FMT_XRGB555 is defined first time in the 4.1.15 kernel videodev2.h
From now, do you want to restrict gstreamer-imx to kernel 4.1.15+ ?


Solves #3


Thanks! require's tolerance for badly formed JSON drives me crazy.


This includes 9k+ media files that should not be here. I suggest talking to someone good at git to help clean up this commit


should be `--openstack` here


Doh, the directory to go to is outdated. Will fix.


Here you go :)

OpenGL information. GPU: GeForce GTX 980 Ti/PCIe/SSE2. Vendor: NVIDIA Corporation. Driver: NVIDIA 368.69
INFO: GL_EXT_texture_filter_anisotropic is available
INFO: GL_ARB_gpu_shader5 is available
INFO: GL_ARB_draw_buffers_blend is available
INFO: GL_ARB_viewport_array is available
INFO: GL_ARB_shader_image_load_store is available
INFO: GL_ARB_clear_texture is available
INFO: GL_ARB_get_texture_sub_image is available

Available VRAM:5441MB


113837787-High-Temp-Radiant-Energy-to-Surface-Imbalance (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1669 of 1670 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.96%25-green.svg)


113837787-High-Temp-Radiant-Energy-to-Surface-Imbalance (RKStrand) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


go to repo's settings tab -> type in new name -> click change name


> I'd rather not, Riker likes it,


and [this](http://www.strawpoll.me/10698736/r)


No lo veo como derivado de verbo "jugar". De hecho, las conjugaciones del verbo jugar están ingresadas manualmente debido a que es irregular. Pero sí encontré "jugador" en Adjetivos.txt, línea 6990: `jugador/SGi`. Lo llamativo es la inclusión del prefijo `i` para formar "enjugador", que nada tiene que ver con el significado de "jugador". ¿Se podría colocar `enjugador/GS`, correjir a `jugador/GSw` y eliminar `exjugador`?


though if Bob is acronym maybe at least make it BOB or b.o.b. or B.O.B.


true


Huh, it might be worth trying to run salt with debug mode to see if that provides anything else.


refs #1


Wrong commit message for this file.


Just to quickly make my answers public:

> The blocklist is necessary in the long run. Do you plan to remove for now, and add it back later? We're going to need this for refs blocking.

Yep, but this Blocklist code was never wired to the config or the gateway, and was exclusively used by the API to allow only webui paths, or allow anything in the case of `--unrestricted-api` enabled. For blocking refs, we'll make something that actually does what we want (the Blocklist code here isn't).

> And, further, does this feature work? (it used to i think, but the lack of a test being removed in this PR makes me think it either doesnt work or was never tested properly). If it DOES work in this commit, there may be people using it. This changes the interface (breaks user space)...

There is a test for the blocklist being removed. The blocklist in the context of webui and `--unrestricted-api` did work fine. By removing it, the behaviour of this option is now the default, and actually passing the option has no additional effect. I still left the option itself in place, so that userspace wouldn't break :)


wron commit message for this file...


Improved = increased.

Oh wel...


Looks great, I do agree with vla


FAILED BECAUSE:
Assertion 'add(ostring2,ostring1) == "IV"' failed: add(ostring2,ostring1) == "IIII"


DirectPortAccess is still referenced on line 114 which causes a build failure when trying to use this branch.


need to change the signature too, idem bellow.


Why did you allow `kqueue` and `kevent` for all? The precedent is set by `epoll`, having to manually be added to each executor.


Up!


I did that in the previous commit, stashed it as i didn't get confirmation from you when i pushed, forgot in this! Ouch


@shama: how about a new release?


`stdio.h` defines `stdin` and `stdout` as macros, renaming the struct field, simply because the C standard says they are macros for no apparent reason other to spite you.


sudo_users = {212788475},


I should add VERY interesting!


deleted


Comment created by PyGithub


Comment also created by PyGithub


shit, mixed up all commit messages,


124975981-Outside-Movable-Insulation-Absorptivity-Issue (RKStrand) - i386-Windows-7-VisualStudio-12: OK (2227 of 2229 tests passed, 0 test warnings)

 * 2 tests had: EIO diffs.
 * 2 tests had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 2 tests had: Table big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


protobuf-net 2.1.0 out now as well \o/


woops! I totally copy pasted that without paying attention haha


This moves all business logic to Pubkey Encrypt service. Doing this ensures that no relevant operations take place if our module hasn't been initialized yet.


This change assumes that either the `xmlUrl` will have trailing slash or the file attribute will start with a slash but it can't be assured.
https://github.com/pixijs/pixi.js/blob/dev/src/loaders/bitmapFontParser.js#L105


Assertion 'add(ostring2,ostring1) == "IX"' failed: add(ostring2,ostring1) == "VIV",


I believe you misunderstood me. The CHALLENGE TO UROK Object should be appearing after one uses the head together with the pike at the pile. And the Challenge should deal 10k damage to the targeted Ogre on use.


@viktorklang with respect to "the onus" I think it's reasonable to expect the compiler to help us avoid mistakes wherever it's possible.

The call-by-name suggestion for B was a bit offhand, but now it brings me to the question of, what about something like this?

```
trait PartialFunction[A, B] {
  def provideDefault(default: => B): Function1[A, B]
}
```


@HermesJim quizás puedas incluir en qué sección fue agregado? Sería una información muy valiosa para nosotros.


Available VRAM:1830MB - so I think it works.


Hi Kara, would it nice be to suppress missing control by an option. It should allow us to just update the controls which are found in the group.  Scenario: I get object to update from server which has some audit fields like last modified by which I don't need in a form.


Maybe this
```
            // if there is an xmlUrl now, it needs a trailing slash. Ensure that it does if the string isn't empty.
            if (xmlUrl && xmlUrl.charAt(xmlUrl.length - 1) !== '/') {
                xmlUrl += '/';
            }
```
should be below the curly brace on the line 104?


Good :)

Now remains to know if it will better handle the out of memory case.


should be /s/<subsaidit_title>/<post_id>


Thanks a lot for the prompt fix!
I suppose it will be on 4.0.0 only?


No NPE because we throw?


Hi,

I just tried this out and the good news is that the trackpad works under X!

The bad news is that the trackpoint stick and the hardware mouse buttons stop working. But the keyboard works.

$ pwd
/sys/bus/hid/drivers/hid-rmi

$ ls -l
total 0
lrwxrwxrwx 1 root root    0 Jul  8 10:22 0003:17EF:6085.0001 -> ../../../../devices/pci0000:00/0000:00:14.0/usb1/1-7/1-7:1.0/0003:17EF:6085.0001
lrwxrwxrwx 1 root root    0 Jul  8 10:22 0003:17EF:6085.0002 -> ../../../../devices/pci0000:00/0000:00:14.0/usb1/1-7/1-7:1.1/0003:17EF:6085.0002
lrwxrwxrwx 1 root root    0 Jul  8 10:22 0003:17EF:6085.0003 -> ../../../../devices/pci0000:00/0000:00:14.0/usb1/1-7/1-7:1.2/0003:17EF:6085.0003
--w------- 1 root root 4096 Jul  8 10:22 bind
lrwxrwxrwx 1 root root    0 Jul  8 10:22 module -> ../../../../module/hid_rmi
--w------- 1 root root 4096 Jul  8 10:22 new_id
--w------- 1 root root 4096 Jul  8 10:22 uevent
--w------- 1 root root 4096 Jul  8 10:22 unbind

Unbinding the .0002 device (interface? Not sure of the terminology) seems to not affect any functionality. Unbinding .0003 causes the synaptics trackpad to stop working. Unbinding .0001 causes the keyboard to stop working. That makes me think that .0002 is meant to be the track nub and buttons.

Is the correct solution to have the .0002 bound to the hid-generic driver, or should something else happen?

Thanks.


Hey @caterinap ... I found one problem. sensi_plot needs to recognize that log-transformation was done.
Before we used the formula to plot the regression, but now the senI_plot wont capture the plot transformation because the formula never uses "log(y)" or log(x). We need to store the information from x.transf and y.transf  on intra output in order to use this in sensi_plot.


you don't need to seperate these. The one bigger one should be fine for both


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1687 of 1687 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@smarcet This method has the same name as the DB property `ShowDupesOnProfile` which is causing issues when trying to access the field with `$member->ShowDupesOnProfile` (1st parameter missing, plus, it's a setter, not a getter).

How much impact would there be to change this to `setShowDupesOnProfile`?


that should be server side


["snake people"](http://www.wsj.com/articles/snake-people-invade-the-internet-1439575068) 😉🐍


I thought it would be useful to show more possibilities _along with_ the column name examples - but I agree with what you're saying about what people will use IRL...if the extra stuff is just confusing, we should remove it. Thoughts @bmcbride ?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Good call, this has come up a few times. How do you feel about putting a PR with some tests that ensures this doesn't happen anymore?


@nuttycom The compiler does not warn for non-termination tho ;) or System.exit, or blatant misuse of system resources :)

W.r.t. your updated proposal, it still uses a call-by-name which means extra allocations per call to provideDefault. Perhaps: `provideDefault(default: Function1[Unit, B]): Function1[A, B]`?

Not to repeat myself, my proposal appeals more to me :)

* Unification of Function and PartialFunction
* making `match` a macro-method on Any
* flexibility in totality-checking (_ match { … } vs "partial function literal")
* Almost a drop-in-replacement to current solution
* No added allocation overhead
* Supports N-arity PartialFunctions (iff we extend case-clauses to match on parameter lists)


Did these work for you? See https://github.com/robertohuertasm/vscode-icons/issues/62


Yes but this is non obvious:
* `GET http://127.0.0.1:8080/1.0/kb/bundles?externalKey=foo&includedDeleted=true` will return 200 if foo does not exist (empty list)
* `GET http://127.0.0.1:8080/1.0/kb/bundles?externalKey=foo` will return 404 even if foo does

So the code works because if `included_deleted` is set we return the list (empty or not) and if not then either we threw before or we should have one object in the list.


:clap:


i2c displays also need setup() with new adafruit library


Sure


REASON:
Assertion 'add(ostring1,ostring2) == "IX"' failed: add(ostring1,ostring2) == "IVI", "IX" == "IX"


некоторые нафиг не нужные скобки, почему-то, у меня запросил линтер в Debian-е


The change is in the commit: https://github.com/CCAFS/MARLO/commit/2953f501f4d74a52cbab7b95dd568b7bd2ba4c17


Общий вопрос. Мне комитить код с инвайтами?


unfortunately I'm totally green with tests:/


он не скобки просил, а mix & match && / ||
скобки следовало ставить вокруг `($remove && $remove.length) || 0` для логического группирования операций и облегчения чтения. чисто так


а здесь `Math.floor(offset / limit) + 1`


в принципе хрен редьки.. )) но ок


Not sure if someone has already pointed this out, but this doesn't return a dispatch function (it returns a method or nil).


а... вот он на этом у меня и не сбилдился
ок, ща сделаю


Not sure if someone has already pointed this out, but this actually returns a map of `dispatch values -> methods`.


@beqabeqa473 : http://bearware.dk/?p=667#comments


You're heading int he right direction, but does that code do what this function is supposed to?


@thomasmso
Give the system/OS some buffer time(1 or 2 sec should be sufficient) to stop using the audio channel for the video ad / interruption before the background music will resume via the playAudio fn(system will resume where it left off)


@thomasmso
Allows for the app to receive remote-control events while in background, so when interrupt occurs, the code will execute despite not being foreground app


@jeremeamia What was the reason for splitting this out into its own repository?


Responded


As the guy writes it's a bit confusing that Alt+F4 is no longer Exit. Should I revert the commit?


I have cloned htcondor and attempted:
./configure_uw
make clean
make install

![screenshot from 2016-07-08 14-59-59](https://cloud.githubusercontent.com/assets/6589674/16701482/4dd21562-451d-11e6-87db-123434d8263f.png)

I am using Ubuntu 16.04 can anyone provide a few pointers on how to correct the issue with canl_c and gssapi.h.  I also wonder about the poor man configure, what is missing.


Hello,
I tried this, but label in filter do not translate:

```
status:
        label: Status
        type: group
        conditions: status in (:filtered)
        options:
            budget: plg.name::lang.invoice.tag_budget
            closed: plg.name::lang.invoice.tag_closed
            canceled: plg.name::lang.invoice.tag_canceled
```


Design changes:

1.) Primary & Alternate audio buttons (two buttons instead of the "Enable Alternate Audio" button that toggles on and off).
2.) Change so that clicking on activity panel title bar for Instructions, More Info, and Teacher's Note will close the panel.


The thing that broke previously is not broken now, so I'm cautiously optimistic we can re-land this. Thanks.


lol


Reason:

Expected Result : C
Obtained Result :"LLXIXI"


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.discussion/82/violations
```
plone/app/discussion/conversation.py:0:1: I001 isort found changes, run it on the file
plone/app/discussion/conversation.py:37:1: F811 redefinition of unused 'implementer' from line 36
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


We has several customers at the time that needed to use SNS validator, but did not need to call any of the AWS APIs.


this is changed


this is a line note


this is a line note 2


this commented for the third time


Fixed in master


It was just my opinion, others might find this change useful. Most applications however provide a dedicated keystroke to minimize their window into systray, pressing Alt+F4 therefore seems a bit unusual to me. The old behaviour to minimize the window (alt+Space -> minimize or Win+Down arrow) is still available.

Steffen


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1111 of 1111 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-34.62%25-green.svg)


That should be working correctly now


Maybe we can/should remove `InstrumentedResourceMethodDispatchAdapter` entirely?


this is a test for a paragraph comment


@normanmaurer silly question but why not use the same term single event executor  per group here too?


java-beta installs 1.8.0_76-b04, however 'java' cask installs '1.8.0_92-b14'
https://github.com/caskroom/homebrew-cask/blob/master/Casks/java.rb
Which was the version being installed before the recipe was updated leading to an error if you previously had
`default['java']['jdk_version'] = '8'`


Ok


This setup has a critical flaw. If you are dealing with say, 30,000 files these errors of what couldn't be found are going to get lost very quickly in the output. Unless you increase your terminal scroll history it will be lost entirely. That means the developer needs to know to pipe the output into a file and then grep over that to find the missing files.


This is a really good change! :+1:


Should this assert be uncommented?


Schema error: Use include to include fragments, not a whole schema


:D


That would be modifying the public API so packages like dropwizard that were referencing this class directly would get a `ClassNotFoundException`


@oddcoder check this commits that fix a null dereference and https://github.com/radare/radare2/issues/5274#issuecomment-231338801 to give a proper fix since you are with that code. is that ok if vt.name == NULL to return there or can happen?


All tests OK here. I hope it will work for you as well


still boosted :klappa:


@HocEman


indeed, it does seem the 2nd time is much faster:

```
jaten@crdev ~/go/src/github.com/cockroachdb/cockroach (jaten_httpip_7474) $ build/builder.sh make install
GOPATH set to /go
/go/bin added to PATH
go install -v
github.com/cockroachdb/cockroach/cli/cliflags
github.com/cockroachdb/cockroach/util/encoding
github.com/elastic/gosigar
github.com/cockroachdb/cockroach/roachpb
github.com/cockroachdb/cockroach/storage/engine/rocksdb
github.com/cockroachdb/cockroach/util/stop
github.com/cockroachdb/cockroach/base
github.com/cockroachdb/cockroach/keys
github.com/cockroachdb/cockroach/config
github.com/cockroachdb/cockroach/util/netutil
github.com/cockroachdb/cockroach/util/grpcutil
github.com/cockroachdb/cockroach/rpc
github.com/cockroachdb/cockroach/internal/client
github.com/cockroachdb/cockroach/gossip/resolver
github.com/cockroachdb/cockroach/gossip
github.com/cockroachdb/cockroach/kv
github.com/cockroachdb/cockroach/ts/tspb
github.com/cockroachdb/cockroach/server/status
github.com/cockroachdb/cockroach/storage/storagebase
github.com/cockroachdb/cockroach/server/serverpb
github.com/cockroachdb/cockroach/sql/parser
github.com/cockroachdb/cockroach/sql/sqlbase
github.com/cockroachdb/cockroach/sql/distsql
github.com/cockroachdb/cockroach/sql/sqlutil
github.com/cockroachdb/cockroach/sql
github.com/cockroachdb/cockroach/storage/engine
github.com/cockroachdb/cockroach/storage
github.com/cockroachdb/cockroach/sql/pgwire
github.com/cockroachdb/cockroach/ts
github.com/cockroachdb/cockroach/ui
github.com/cockroachdb/cockroach/server
github.com/cockroachdb/cockroach/cli
github.com/cockroachdb/cockroach
jaten@crdev ~/go/src/github.com/cockroachdb/cockroach (jaten_httpip_7474) $ build/builder.sh make install
GOPATH set to /go
/go/bin added to PATH
go install -v
jaten@crdev ~/go/src/github.com/cockroachdb/cockroach (jaten_httpip_7474) $
```


Hi @poretsky When I switch to landscape on my Nexus 4 with Android 5.1.1 the app crashes with the following exception:
07-08 23:30:43.232 19538-19538/dk.bearware.gui E/AndroidRuntime: FATAL EXCEPTION: main
                                                                 Process: dk.bearware.gui, PID: 19538
                                                                 java.lang.RuntimeException: Binary XML file line #7: You must supply a layout_width attribute.
                                                                     at android.content.res.TypedArray.getLayoutDimension(TypedArray.java:606)
                                                                     at android.view.ViewGroup$LayoutParams.setBaseAttributes(ViewGroup.java:6472)
                                                                     at android.view.ViewGroup$MarginLayoutParams.<init>(ViewGroup.java:6641)
                                                                     at android.widget.RelativeLayout$LayoutParams.<init>(RelativeLayout.java:1243)
                                                                     at android.widget.RelativeLayout.generateLayoutParams(RelativeLayout.java:1083)
                                                                     at android.widget.RelativeLayout.generateLayoutParams(RelativeLayout.java:82)
                                                                     at android.view.LayoutInflater.rInflate(LayoutInflater.java:808)
                                                                     at android.view.LayoutInflater.inflate(LayoutInflater.java:504)
                                                                     at android.view.LayoutInflater.inflate(LayoutInflater.java:414)
                                                                     at android.view.LayoutInflater.inflate(LayoutInflater.java:365)

Also if I view the serveritem-xml file in designer then it complains about the layout height and width not being set.


I think we should show examples of both, just to cover all our corner cases.


(my magic :sparkles: weapon is [ncu](https://www.npmjs.com/package/npm-check-updates) + [lodash4 changelog](https://github.com/lodash/lodash/wiki/Changelog))


124975981-Outside-Movable-Insulation-Absorptivity-Issue (RKStrand) - Win64-Windows-7-VisualStudio-12: OK (2227 of 2229 tests passed, 0 test warnings)

 * 2 tests had: EIO diffs.
 * 2 tests had: ESO big diffs.
 * 1 test had: MTR big diffs.
 * 2 tests had: Table big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


What does this timer do/accomplish?


I could explicitly do that, but I think it's the same thing:
"If the return value is a string it’s converted into a response object with the string as response body, a 200 OK status code and a text/html mimetype."


Not sure Robert. Tested and the issue persists


Had conflicts over here


Escaped =)


@harold I don't know if it has been pointed out already or not.  I do know that comments here in Github like this are not the way the Clojure developers collect suggestions for improvements.  They do that with JIRA instead, here: http://dev.clojure.org/jira/browse/CLJ   You are welcome to create an issue there after creating a free account.


lol remember when we had this class together


I can't get it to use the actual value of null, it uses 'null', which causes a "that's not an int" error. I agree there should be a way to do it, but I can't figure it out =(


113837787-High-Temp-Radiant-Energy-to-Surface-Imbalance (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2262 of 2262 tests passed, 558 test warnings)

 * 558 tests had: ERR diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


We should better keep the `insert_entry` method dumb and leave the policy of how to respond to an out-of-memory condition to the caller. The easiest way would be to throw an exception. Maybe the `Out_of_memory` type could be translated to a class-local exception type that expresses the condition a bit more precise, e.g., by naming it `Mapping_cache_full`. The caller could then respond to the condition by calling `flush_all`. or maybe later by invoking a less rigid eviction strategy.

This would also eliminate the need to propagate any information about the caller to the function as argument (and to include base/log.h) because it would be up to the caller to print the message.


It prevents you from accidentally clicking 'Reset all settings' button and loosing all your settings and profiles.


- Added images to the home footer section to display technologies used on the project.
- Moved the coloring of bar chart rectangles away from CSS and added a color domain in bar chart constructor.
-Adjusted some css styling of page.


I cann't see the screenshots. Is it all right by serverside?


Uh-oh.