And if you set 'use_sim_time`, then you'll get
```
$ rostest test/test_color_based_region_growing_segmentation.test
... logging to /home/k-okada/.ros/log/rostest-kokada-t440s-9334.log
[ROSUNIT] Outputting test results to /home/k-okada/.ros/test_results/jsk_pcl_ros/rostest-test_test_color_based_region_growing_segmentation.xml
[ERROR] [1473440681.185458352, 1467775004.412219891]: subscribe->
[ERROR] [1473440681.464760151, 1467775004.695655302]: subscribe <
[ERROR] [1473440688.689255479, 1467775011.922881369]: subscribe <
Traceback (most recent call last):
  File "/opt/ros/indigo/share/jsk_tools/src/test_topic_published.py", line 61, in <module>
    rostest.run(PKG, NAME, TestTopicPublished, sys.argv)
  File "/opt/ros/indigo/lib/python2.7/dist-packages/rostest/__init__.py", line 145, in rosrun
    result = rosunit.create_xml_runner(package, test_name, result_file).run(suite)
  File "/opt/ros/indigo/lib/python2.7/dist-packages/rosunit/xmlrunner.py", line 233, in run
    test(result)
  File "/usr/lib/python2.7/unittest/suite.py", line 70, in __call__
    return self.run(*args, **kwds)
  File "/usr/lib/python2.7/unittest/suite.py", line 108, in run
    test(result)
  File "/usr/lib/python2.7/unittest/case.py", line 395, in __call__
    return self.run(*args, **kwds)
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/opt/ros/indigo/share/jsk_tools/src/test_topic_published.py", line 56, in test_published
    assert_true(checker.check(), msg)
  File "/opt/ros/indigo/share/jsk_tools/src/jsk_tools/sanity_lib.py", line 81, in check
    rospy.sleep(0.1)
  File "/opt/ros/indigo/lib/python2.7/dist-packages/rospy/timer.py", line 155, in sleep
    raise rospy.exceptions.ROSTimeMovedBackwardsException(time_jump)
rospy.exceptions.ROSTimeMovedBackwardsException: ROS time moved backwards
testtest_color_based_region_growing_segmentation ... ok
```


? no ...

We fix h3 when we have a cleaner system. BUT here : there are a div open and not closed : https://github.com/Shnoulle/LimeSurvey-Shnoulle/commit/0cc1b232005d5c85f2150453657af14dc2c10cf7#diff-c20ef43e3a96eeb453bf49ca0ca4c030L74

This broke html really.


@claudiosmweb just tested with Brazil postcode and it gets saved as `99999-999` in the database.

It would be nice if WC supported both `99999` and `99999-9999` formats for US and saved them as such so they can be used by gateways etc (or at least provided functions that return the postcode in the requested format).

However, I have already scheduled a fix release for Chase Paymentech for next week so we can make sure merchants trying to perform the certification can complete the steps involving ZIP+4 postcodes.

If you guys don't think WooCommerce should handle the formatting, that's fine too, we'll add it to our framework to be used by our other gateways.

Thanks for your help.


Remind : h3 need an h2 need an h1.

And hx system must be in template not in core


Fair point. But we also say "in a way that comes as close as possible." Can think about simpler wording.


@vangheem Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.tiles/41/violations
```
plone/tiles/__init__.py:0:1: I001 isort found changes, run it on the file
plone/tiles/data.py:182:1: C901 'map_to_pairs' is too complex (12)
plone/tiles/data.py:230:1: C901 'encode' is too complex (15)
plone/tiles/data.py:311:1: C901 'decode' is too complex (13)
plone/tiles/directives.py:0:1: I001 isort found changes, run it on the file
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


- rebar3 shell
```erlang
===> Booted zoo
{1,2,30} [fish_keeper   ] is working
1> {1,2,33} [fish_keeper   ] is working
{1,2,36} [fish_keeper   ] is working
{1,2,39} [fish_keeper   ] is working
{1,2,42} [fish_keeper   ] is working
erlang:send(fish_keeper, off_duty).
{1,2,43} [   fish_keeper] terminate by off_duty
off_duty

=ERROR REPORT==== 10-Sep-2016::01:02:43 ===
** Generic server fish_keeper terminating
** Last message in was off_duty
** When Server state == fish_keeper
** Reason for termination ==
** {off_duty,[{zoo_keeper,handle_info,2,
                          [{file,"/Users/zhongwen/github/erlang-rock/restart-strategy/zoo/_build/default/lib/zoo/src/zoo_keeper.erl"},
                           {line,33}]},
              {gen_server,try_dispatch,4,[{file,"gen_server.erl"},{line,615}]},
              {gen_server,handle_msg,5,[{file,"gen_server.erl"},{line,681}]},
              {proc_lib,init_p_do_apply,3,
                        [{file,"proc_lib.erl"},{line,240}]}]}
2> {1,2,43} [fish_keeper   ] is starting

=CRASH REPORT==== 10-Sep-2016::01:02:43 ===
  crasher:
    initial call: zoo_keeper:init/1
    pid: <0.82.0>
    registered_name: fish_keeper
    exception exit: off_duty
      in function  gen_server:terminate/7 (gen_server.erl, line 826)
    ancestors: [zoo_sup,<0.80.0>]
    messages: []
    links: [<0.81.0>]
    dictionary: []
    trap_exit: true
    status: running
    heap_size: 987
    stack_size: 27
    reductions: 303
  neighbours:

=SUPERVISOR REPORT==== 10-Sep-2016::01:02:43 ===
     Supervisor: {local,zoo_sup}
     Context:    child_terminated
     Reason:     off_duty
     Offender:   [{pid,<0.82.0>},
                  {id,fish_keeper},
                  {mfargs,{zoo_keeper,start_link,[fish_keeper]}},
                  {restart_type,transient},
                  {shutdown,1000},
                  {child_type,worker}]

=PROGRESS REPORT==== 10-Sep-2016::01:02:43 ===
          supervisor: {local,zoo_sup}
             started: [{pid,<0.94.0>},
                       {id,fish_keeper},
                       {mfargs,{zoo_keeper,start_link,[fish_keeper]}},
                       {restart_type,transient},
                       {shutdown,1000},
                       {child_type,worker}]
{1,2,44} [fish_keeper   ] is working
{1,2,47} [fish_keeper   ] is working
{1,2,50} [fish_keeper   ] is working
{1,2,53} [fish_keeper   ] is working
{1,2,56} [fish_keeper   ] is working
{1,2,59} [fish_keeper   ] is working
erlang:send(fish_keeper, stop_normal).
{1,3,1} [   fish_keeper] terminate by normal
stop_normal
3> erlang:whereis(fish_keeper).
undefined
```


Ok, we'll make it more clear.


I blame Dan for making me add all of the countdown things again


hi! hao here. might be able to use TypeApplication?


@rickynils is the solution you speak of included as a commit in nixpkgs now? Just curious what that looks like.


Also note that I removed an unnecessary call to clear the map in the constructor.


This looks good for step 2!


This small fix resulted in 2x performance improvement in serialization!
:anguished:


We discussed it under PuppetJs organization https://github.com/PuppetJs/PuppetJs/issues/98 (we suffer for little bit of repolepsy).

Do you have any problems or comments related to this?

(I didn't bring back intervals, so that are just few listeners more) In long term we plan to replace it with proxies.


EMS (brianlball) - x86_64-MacOS-10.10-clang: OK (2292 of 2466 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-92.94%25-yellow.svg)


в wpa_supplicant_overlay тоже надо


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#A_cNAQqhSjG-YeO2jvCHaQ


test_build_branch (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed (1568 of 2080 tests passed, 37 test warnings)

 * 539 tests had: AUD diffs.
 * 530 tests had: EIO diffs.
 * 422 tests had: ESO small diffs.
 * 512 tests had: RDD diffs.
 * 497 tests had: Table big diffs.
 * 360 tests had: MTR small diffs.
 * 420 tests had: BND diffs.
 * 90 tests had: ERR diffs.
 * 116 tests had: ESO big diffs.
 * 76 tests had: MTR big diffs.
 * 4 tests had: SSZ big diffs.
 * 15 tests had: MDD diffs.
 * 35 tests had: MTD diffs.
 * 5 tests had: ZSZ big diffs.
 * 29 tests had: DXF diffs.
 * 1 test had: SSZ small diffs.
 * 1 test had: ZSZ small diffs.
 * 3 tests had: delightin diffs.
 * 3 tests had: delightout diffs.
 * 1 test had: SHD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-75.38%25-red.svg)


<code>


@vangheem Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.tiles/42/violations
```
plone/tiles/__init__.py:0:1: I001 isort found changes, run it on the file
plone/tiles/data.py:188:1: C901 'map_to_pairs' is too complex (12)
plone/tiles/data.py:236:1: C901 'encode' is too complex (15)
plone/tiles/data.py:317:1: C901 'decode' is too complex (13)
plone/tiles/directives.py:0:1: I001 isort found changes, run it on the file
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


I'll download this fork and do some tests. I'll try and hunt down the gremlin that's haunting your code it seems. :P


I can't see why the audio would stop working though... I can put my code AFTER the splash screen but it still won't play the jingle...


去做游戏了吗


test_build_branch (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Keep composer requirements sorted by name


Ok, I think that makes sense. I'll make an issue!


Nice additions!


that's incredible. thanks!


test_build_branch (lefticus) - x86_64-MacOS-10.9-clang: Tests Failed (1532 of 2042 tests passed, 36 test warnings)

 * 536 tests had: AUD diffs.
 * 527 tests had: EIO diffs.
 * 420 tests had: ESO small diffs.
 * 509 tests had: RDD diffs.
 * 495 tests had: Table big diffs.
 * 115 tests had: ESO big diffs.
 * 358 tests had: MTR small diffs.
 * 86 tests had: ERR diffs.
 * 420 tests had: BND diffs.
 * 76 tests had: MTR big diffs.
 * 4 tests had: SSZ big diffs.
 * 15 tests had: MDD diffs.
 * 35 tests had: MTD diffs.
 * 5 tests had: ZSZ big diffs.
 * 28 tests had: DXF diffs.
 * 3 tests had: delightin diffs.
 * 3 tests had: delightout diffs.
 * 1 test had: SSZ small diffs.
 * 1 test had: ZSZ small diffs.
 * 1 test had: SHD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-75.02%25-red.svg)


Is there a reason this has to be statically constructed? Does computing it lazily have noticeable overhead, or security concerns?


crawl script to download movie titles (loop to be entered)


@tamarazuk but if for Brazil postcode saves correct, it's not hard to "fix" it for US ones too.
I don't think the problem is this code here. but I can check.


İp Adresine Göre tahmini konum alıp listelemekte


@scutmason 这个说来话长了，目前创业失败刚踏进失业状态中。因为报酬蛮令人感动所以接了一个游戏外包。
好吧不管怎样，做完这外包还是得找回 Android 的工作。


I saw that you changed some CSS stuff.

The menu bar icon size was tweaked to avoid this effect in Firefox:

![uneven-menu-bars](https://cloud.githubusercontent.com/assets/1425520/18395057/a1d7ee5e-7671-11e6-8535-38ad256e89c5.png)

The bars again look uneven, and they will, except when set to exact sizes.

I've made the bars as a 15x13 png data URI, 3px for each bar and 2px for the spaces. This replaces the font-awesome icon that is not so awesome. About as small as it can go:
```
.fa-bars {
/*	font-size: 10px;
	line-height: .80;
	vertical-align: -20%;*/
}
.fa-bars:before {
  display:block;
  content:url('data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAA8AAAANCAMAAABBwMRzAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAAZQTFRFAAAAAAAApWe5zwAAAAJ0Uk5T/wDltzBKAAAAGUlEQVR42mJgZEAGjAwE+agAkz+w5gEEGAAggABP5U/AbAAAAABJRU5ErkJggg==');
  margin: 0px;
  }
```
Gives us a better looking menu:
![uneven-menu-bars-fix](https://cloud.githubusercontent.com/assets/1425520/18396295/beecc9be-7677-11e6-9693-cd3e7c32be8e.png)


Orz ,刚毕业就去创业，厉害。


Didn't see any declaration of `on_replace: :update` on https://github.com/elixir-ecto/ecto/blob/1eacc2693a0ec7c79a6813bee70c72155136c278/test/ecto/changeset/embedded_no_pk_test.exs, was that on purpose?


Por alguna extraña razón despues de este commit ya no se ven las sessiones que se crean en myCourses :(


所以还不是失败了


Haze: we already put down strict rules about this.  Renaming existing sets isn't going to happen, and for future sets using all the letters for the sake of it will not pass either.  This is just about sets where a few more letters would make an unreadable Eastern European-looking mess into something people can remember and type.

(There's a proposal to rename the Nintendo VS sets to all have a consistent "nvs_" prefix, which this would certainly help with, but that's not guaranteed to happen).


Queda mu bonico, así tan gingerizado       ;)


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#b09hTI6JSDiTo22WLrzqPA


or
```
return if self.checkins....empty?
  true
else
  false
end


OR

```
return self.checkins....empty? ? false : true
```
```


@claudiosmweb @tamarazuk fwiw here, if WC is going to save all 9 digits for the US, I'd love to see them formatted correctly like Brazil postcodes, or be cut off at 5 digits (though saving the additional +4 would be preferred). There are definitely a lot of gateways and  integrations that either expect `99999` or `99999-9999`, and they don't always handle `999999999` to re-format it themselves, so WC is essentially breaking that for no reason.

While we could work around it, we're not the only people that have built integrations for payment gateways or other services 😸  If all digits are going to be saved, imo they should be in an expected format.


Nice, yeah, this method needed a parameter :)


Add `.byebug_history` to your `.gitignore` file


@dkati did you take a look at drivers? They are the same, only difference is the adaption, cm has 3.4 kernel, we have fuse from 3.10 and fs partially ported to 3.18.. I' ve disabled sdcardfs drivers on MM and N for the moment, but i did not have a single issues on both MM and N in these days. Some useful infos about the crash (logs, fs, etc)?


is this a test?


#208 for reference, let's move any further conversation there.


What do you mean? It already checks if unit/initscript exists.


I was a bit disappointed to see web code when I use JSON-Patch server-side and in also in the browser (Aurelia) that handles object changes manually when my models change.

I always thought that having JSON-Patch handle mouse and keyboard triggers was a total hack and gives me some uncertainty as to how it will behave in my own projects. I'd honestly be happier if there was just a wrapper module that handled the keyboard and mouse triggers or if JSON-Patch had a config that kept this stuff off by default.


Is it ok that this like will output nothing in the 'skip_download' case?


Missing deploy


Nice


test


hi


![image](https://cloud.githubusercontent.com/assets/736728/18396645/2d8fb8b8-769b-11e6-89f0-f49611eb3937.png)

9 de setembro :)


slt


lololoolollolo


xD


hoho


I tested with DS-Xtreme. Because with it's LEDs I can tell if the card reset occurs. My current code has a small delay...But you are still using the card reset code from libnds. I will try it with the version in my 1.7 build of NTR Launcher.


missing parentheses around exception types


asdf


asdfasdf


> and they don't always handle 999999999 to re-format it themselves, so WC is essentially breaking that for no reason.

This is bad, for example in Brazil we handle `99999-999`, `99.999-999` and `99999999`. It's always best check first.


Thanks @BergWerkGIS - I see that documented https://github.com/mapbox/node-pre-gyp#6-publish-when-you-want so I'll consider using that in the future.


Better add a comment for the limit too 😊


Consider lazy evaluation using **Stream** until the last stage in the pipeline where you actually need a list.


It's been like that for a while at least. But it is pretty janky.


IMO it is better leaving things undone (broken)  as in an undefined state, which it is when only compile tested by jenkins. Then everybody is aware of what still needs to be done. A comment "// Fixme" at the end of a line it not very helpful


I spooted a misplaced fifo wait command. It's before the fifo init stuff too so that may be why your sound stopped working.


Works great, thank you!


You had this just after fifoinit();

fifoWaitValue32(FIFO_USER_03);

Arm9 is does not have a code on it's end to send a vlue for FIFO_USER_03. But arm7 does (that's later down near the card reset call where it should be. So Arm7 is stuck waiting for a command it will never receive. So arm7 is stuck. That broke everything after that fifo command. Thus sound broke and card reset never occurs which also explains the hang after the splash screen.


closes #1


Closes #1 #4


Yep. that fixed it. It was able to boot my R4 (though my R4 hangs on it's load screen like expected since this isn't based on the alt build).

You only need to remove that erroneous fifo command and your problems should be fixed.


oh... huh... I didn't realize that was still there after my merge...

Normally it would say there was a conflict or something...

Thanks


Ótimo André! Show..


I think it was to make this repo a copy of upstream.


I had the issue that for **sddm** plymouth after-fex got added. It was always true the or if-rule. It only worked as we checked if the file exists. Since we didn't do that in the latest code anymore, the wrong systemd service was added for **sddm**. Now it works.


test_build_branch (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (948 of 948 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.63%25-green.svg)


No problem. :D

I suggest you merge my 1.7 changes. It increases flashcart compatibility drastically. Already got a report from users saying DSTwo boots with it as well as Cyclo DS. Haven not heard yet on RF SDHC clone owners.

1.7 is a simple change from 1.6. I went back to a custom card reset function with a increased delay between power off and on and disabled logo/secure area error checking in the bootloader. :D


Yeah, I was dumb and didn't realize there is an upstream.  I'm thinking maybe it best to close our repo and reopen as a proper fork.


It's nice to avoid deserialization in the scheduler


Jep, makes sense.

Am 09.09.2016 7:45 nachm. schrieb "Rainer Hochecker" <
notifications@github.com>:

> IMO it is better leaving things undone (broken) as in an undefined state,
> which it is when only compile tested by jenkins. Then everybody is aware of
> what still needs to be done. A comment "// Fixme" at the end of a line it
> not very helpful
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/xbmc/xbmc/commit/ba4830514e335a21fd79567e670b70707b9ef683#commitcomment-18966722>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABCfHfItbViuSHbPMsUeCX4uDo_tM0xKks5qoZsmgaJpZM4J4znj>
> .
>


Kind of late, but is there a specific scenario in which we would need trailing whitespace on markdown files?


I'll give that a try then


Working on #8


@claudiosmweb i agree with @bekarice

While WC validities `99999-999`, `99.999-999` and `99999999` for Brazil (likely because all are valid formats), it should be saving it in one format so integrations can always expect to see a specific format and work with it from there.


Yup! These are some of what I meant, but also all the deployment targets.


Great job @lsilvs!! Now it's working properly! Thank you!


Well i dont see it its says no devices found  the same app im curious if there is need of some modifications to the quad or only flash your firmware and you have BLE????


Modifications like hardware stuff


@tamarazuk but we save for Brazil in only one format :P


If we had a lamp to know what camera is online now... Highlight the window with red rectangle via overlay. That overlay would not captured by OBS Studio itself. Possible improvement?


The following doc(s) have been deployed to the [slashzerop](https://slashzerop-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/migrate-wordpress](https://slashzerop-static-docs.pantheonsite.io/docs/migrate-wordpress)


Si estoy entendiendo bien el problema es que la extension del archivo puede ser pdf/PDF/etc. Otra manera es hacer que el match sea case insensitve, se puede hacer pasandole al método search search más abajo la opcion `re.IGNORECASE` o en la misma regexp con la opcion i (`(?i)<regexp>`)


os_2.0_develop_signal_slot_bug (kbenne) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#GxY8d_mxSkyiN3N_GONKOg


Not sure I get the bug here... I am not sure about the guava classes behavior neither, we don't use on android, it's just too big.


@Sami32 I think it's important that if there is information/documentation it is correct and meaningful. I actually prefer no information over wrong information, as wrong information can lead to so much misunderstandings and wasted time. Any references to ```BufferOutputFile.java``` is meaningless to the users for example, and it's meaningless to me too until I read and understand what that class does.


Don't get me wrong. I don't blame anyone, just trying to learn. Eventually it was me who pushed the button on this change :)


verdad no? case insensitive iría mejor. No hay mucha consistencia en la manera de nombrar sus PDF. Hay que esperar lo inesperado.


te animas a hacer un pull request?


This list is ignored. We should at least print a reminder after sending the email.


@claudiosmweb yes, that's what i meant. It does save it one format only as it should 😸  I was suggesting the same for US postcodes. Integrations can expect them to be either `12345` or `12345-1234` and nothing else. Leads to less confusion.


The issue is that the hashcode of your mutable object changes after you put it in the set. So you won't be able to find it anymore. Line 25 will fail.


@xfurry nice to see you again...
all you need is there:
https://github.com/unified-db/Database/issues/130


Got a CTD on second turn:

![image](https://cloud.githubusercontent.com/assets/14372214/18397475/02ebf264-768e-11e6-9ded-f7901c12094d.png)


Need to fix this up. The call 'service_module.get_module_branches.first' is non-detremistic if multiple branches


"An early morning walk is a blessing for the whole day" --Henry David Thoreau


@stephanenicolas @mullender I push another commit removing Guava to be more clear


@tamarazuk problem already solved :P


Ok


En tant que designer, j'aimerais avoir accès au backend du site Web.


Just in time. Thanks!


😱

Valeu @felquis


Note: Change "WCDMA Only" to "WCDMA only" and "WCDMA/GSM preferred" to "GSM/WCDMA preferred"


And why?


Commit 2


should be SBBDefaultCacheDaysBehind?


Не много докапываюсь, но все же... Convert.ToInt32(a[i]) дергать два раза не очень хорошо.


Which list are you referring to? I'm not sure what you mean.


So then maybe it will be useful to mention it when user will enable it so he will expect there is a "side effect" of  STEREO downconverting what right now description in UMS doesn't tell.
E.g. renderers with audio-passthrough can accept any mime/content type (2.0 for 5.1 content) but decoder used is in external receiver which doesn't receive and doesn't need this info.
So user should be warned/informed :)


Nope :-) I said really what I thought. The Statement was fully right.
Keeping it compiled does not mean it is verified and tested.

Am 09.09.2016 8:03 nachm. schrieb "Rainer Hochecker" <
notifications@github.com>:

Don't get me wrong. I don't blame anyone, just trying to learn. Eventually
it was me who pushed the button on this change :)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/xbmc/xbmc/commit/ba4830514e335a21fd79567e670b70707b9ef683#commitcomment-18967012>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABCfHYdV7RGn0EIKRqVlkHnqtVs1gkzXks5qoZ9fgaJpZM4J4znj>
.


I don't actually see assignstartingplots.lua for the CP/CBO/EUI/No-EUI files. Did you include it?


Commit Version 2


Тоже докапываюсь, но... откуда желание объявить все перемнные вначале, да еще и в одной строке? Вроде никто не говорил что на Паскале писал :)


ghbdtn


All right! Automated CIS audit with 277 checks went from 58% failed (baseline) down to 31% failed with ```harden.sh -q```.


Can `fig.asp` compute width from height as well?

We could also go so far as to support `fig.asp` as an override for our own default aspect ratio (~1.6).


I see. Yes, sure the buck won't change ;) good one, but I had never faced it before.


I've got 0x00009086 on previous resume from suspend. I don't know if it is related to installed `0.09 r5`. But now Wireshark work without any additional settings. Thanks!


It's still used here.


This doesn't break anything? Any idea why these `href` assignments exist in the first place?

As a rule, I favor removing commented-out code all together unless there is comment explaining why it's being preserved.


PUL REQUEST!


Just wonder what is the role of these servers? What could be if MITM is played on them?


@atarijeff

Can you explain more why you did the change on line 4270+ (in the new code) above? This is breaking things when there are actually Unicode chars in the filename: https://forums.sagetv.com/forums/showthread.php?p=592336#post592336


Might want to update this selector to use the newly added 'getPageIndexById'


well, when you use the full VP, that file is handled by More Luxuries...since More Luxuries isn't in the Repository I added it into the Repository ...should be a folder called More Luxuries/Lua/AssignStartingPlots.lua


In theory, it shouldn't break anything since typically, click events are what trigger carousel events. However, we won't have a way of knowing until we deploy this to the CMS and test.

I removed these because of an error found in our accessibility testing, but if you think the hrefs should be left in, I can revert this.


WTF???


CM has translations for network choices, so you should use them:
https://github.com/ghsr/build_tools/blob/cm-13.0/patches/packages_services_Telephony.patch


@7172 not really sorry. But you will find enough tutorials online


this is fixed in master, fwiw


`Context()` method was dropped to let people extend `echo.Context` with custom APIs, there was conflict in method and property name `Context` so I had to drop it.  More: https://echo.labstack.com/guide/context

Looking at your failing example:
1. It is the same behavior with older version of `context.go`
2. You are putting it in recursion yourself by setting parent as `echoContext`


Para que funcione el auto load debes correr el comando (una sola vez):
`php composer.phar dump-autoload -o`

Así en lugar de usar requires, nada más le pones un namespace a las clases y composer las incluye automáticamente.

https://getcomposer.org/doc/04-schema.md#autoload


2 Commit
3 Commit


Commit Version 3


os_2.0_develop_signal_slot_bug (kbenne) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


So you should have 3 of AssignStartingPlots.lua now.

1) in CP Lua folder
2) in CBO Lua folder
3) the one that exists in More Luxuries that needs to be overwritten with the new one I created for that one.

#'s 1 and 2 are identical, #3 is if you are using More Luxuries and now accounts for pseudo natural wonders. All are basically one liner changes.


Commit Version 4


Looks like you fixed this, thanks!


Хм, все 5 тестов из папки test она прошла...


And there are even more references for it:
https://github.com/CyanogenMod/android_packages_services_Telephony/blob/cm-13.0/res/values-lt/cm_strings.xml#L109


Agreed.


I have copied those tests from embedded_test, which means that embedded_test has no tests for :update as well. Could you please send a PR that adds tests for both files?


Hopefully that's all clear as mud.


Committing a comment


Not sure why this is here.


No,this patch won't work, cm changed the method of changing network selection.
https://github.com/CyanogenMod/android_packages_services_Telephony/commit/da57833438ed7fdb34164cc5faee0a44054fbb45
https://github.com/CyanogenMod/android_packages_apps_Settings/commit/3a85ba8411921f76c334515180ea060768f007b2
We can't patch only telephony, in that case we need to patch settings too. Instead of patching so many things, this is the best solution.As they support overlaying of network selection via dt now.
https://github.com/CyanogenMod/android_packages_services_Telephony/commit/f4ccdc155fa2929026de150e7666f9f1ed21ba35
I don't care about translations, because keeping translation in mind and breaking other stuffs isn't a good idea. And i don't think, someone is so dumb that he don't understand one letter English word!


range(1, num+1) ?


This breaks the maven build btw.


It looks like `fig.asp` is used by knitr only for computing `fig.height` from `fig.width`; not in the other direction.

Good point re: respecting `fig.asp` when no other figure dimensions are set! I'll make that change as well.


(this was me)


I'd prefer removing them if they're not required, especially if they don't conform to accessibility standard. If nothing breaks, I'm good with change.


>And there are even more references for it:
https://github.com/CyanogenMod/android_packages_services_Telephony/blob/cm-13.0/res/values-lt/cm_strings.xml#L109
These references are for some other purpose. Don't go on words


Thanks for catching that! Fixed in most recent commit.


Photo Uploader


I think ideally we should also ask if "carrier" and "presymptomatic" should be included as well (probably sometimes they should and sometimes they shouldn't. But need to ask someone who knows user req better.


Range.Contains のテストに int.MinValue のケースを入れ忘れた


User Module


Authentication


Main Structure


Thanks! As always you guys are fast!

Note: that url in the commit is a 404


Какова алгоритмическая сложность этого алгоритма?
Можно ли её улучшить?


saw approval from jvoegele
at https://github.com/basho/riak_kv/commit/ff12939bee168cd9aff19d766ecedb0e595bb2b0


merging basho/riak_kv/cuttlefish-commented = ff12939b into borshop-integration-1477-cuttlefish-commented


basho/riak_kv/cuttlefish-commented = ff12939b merged ok, testing candidate = 61fb9c4a


Hi Trystan,
I can create a graph, but when I go to a dashboard to place it, I get the following error:
Notice: Undefined property: stdClass::$name in /var/www/emoncms/Modules/graph/widget/graph_widget.php on line 11


saw approval from jvoegele
at https://github.com/basho/yokozuna/commit/df4a3cd95507bdbe17c38c6ebf3c3c1b8bbae5ac


merging basho/yokozuna/cuttlefish-commented = df4a3cd9 into borshop-integration-675-cuttlefish-commented


basho/yokozuna/cuttlefish-commented = df4a3cd9 merged ok, testing candidate = 50ab4499


test_build_branch (lefticus) - i386-Windows-7-VisualStudio-12: Tests Failed (1536 of 2048 tests passed, 37 test warnings)

 * 539 tests had: AUD diffs.
 * 530 tests had: EIO diffs.
 * 422 tests had: ESO small diffs.
 * 360 tests had: MTR small diffs.
 * 512 tests had: RDD diffs.
 * 497 tests had: Table big diffs.
 * 116 tests had: ESO big diffs.
 * 88 tests had: ERR diffs.
 * 420 tests had: BND diffs.
 * 76 tests had: MTR big diffs.
 * 4 tests had: SSZ big diffs.
 * 15 tests had: MDD diffs.
 * 35 tests had: MTD diffs.
 * 5 tests had: ZSZ big diffs.
 * 29 tests had: DXF diffs.
 * 3 tests had: delightin diffs.
 * 3 tests had: delightout diffs.
 * 1 test had: SSZ small diffs.
 * 1 test had: ZSZ small diffs.
 * 1 test had: SHD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-75.0%25-red.svg)


I like auto!


fixes #17


`window`! `document`!


Ссылки по теме алгоритмической сложности:
https://habrahabr.ru/post/196560/
http://www.diary.ru/~Organon/p44753547.htm?oam#more1


So what purpose does that serve?  There are newlines from `fnl ()`, but no line-break hints.  If you do `v 0 (str "a") ++ v 0 (str "b")`, does that force them onto separate lines?  (I guess this is what's responsible for the strange indentation of a large block, when there's a missing newline...)


这里新截取的这个机器前面板把说明书给挡住了...
物体的放置还是直接用个tween动画让他落下去比较好，不然比较小的物体放开后能看出来是悬浮着的。
（鼠标松开时物体整体变暗并出现在舱室内区域，就是物体上边缘低于舱门上边缘的地方，然后开始下落动作）


ASIHPValidation (shenb) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1759 of 1760 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.9%25-green.svg)


@mbostock
Hi Mike,

Hope you had a great summer. After some extensive work on the TypeScript 2 definitions for D3 v4, I thought, it might be a good idea to have brief demo app for people who want to enjoy all the goodness of your D3 wrapped into light coating of Angular 2. :smile:

The demo app with accompanying repo is intended as an exploration/(self-)learning tool.

A live prototype version is on the following Github Page: [d3-ng2-demo](https://tomwanzek.github.io/d3-ng2-demo/). (Clearly the prototype needs some work on the intro section.)

The source repo is here: [d3-ng2-demo repo](https://github.com/tomwanzek/d3-ng2-demo). (The Readme is still mostly boilerplate from angular-cli.)

The reason I am @ mentioning you with this comment, is two-fold.

For one, as innumerable people have benefited in the past from your Blocks examples, I have chosen to adapt three of them into Angular 2 components (cross-referenced to your originals, for didactic comparison as well). With Angular 2, D3v4 and TypeScript2 fresh out of the gate some sense of steadiness from a well-defined reference point just felt right. So I wanted to pass this approach by you. I sincerely hope you're alright with the underlying philosophy.

Secondly, I intend to link it in the D3 wiki, I thought under Tutorials might be a spot for D3v4 Angular 2.

So, I would be grateful for your take on the matter!!! Cheers.


ASIHPValidation (shenb) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Bugger, forgot to rebase before pusing


If I'm using this in my project, is there any reason I need to A) tell Flow to type check entire library (via [Include]) or B) include the entire library when I compile my bundle (via Babel)?

Mostly, I just want access to types when I import things from the library.


Ah, OK, thanks -- I misread it.


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#SGt_vwadScmImYcnhpbOJg


We could add this back again now that we're ready use this functionality.


I don't actually see the lua files in the repo, however. Mind reuploading them?


This is likely to cause problems when we want to move to Django 1.9. Is there a card to investigate this?


Спасибо!


Because of this, I filed #165.


But note that hook return values are important; callback functions should return `false` to permit the hook to continue processing (e.g. by other registrants), or `true` to interrupt hook processing. Check hook callbacks throughout this plugin to make sure they're returning something -- in this case `false` would be appropriate, for example.


os_2.0_develop_signal_slot_bug (kbenne) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Thank you very much, I have added this in version 5.0.5


Probably not for this problem _specifically_, but there should be one for replacing django-shop (which is one of the major things preventing us from moving past Django 1.8. In any case, I'll make sure one exists now. It was already the case that this app depended on Django<1.9, it just wasn't enforced by the setup.py


I think the deployment targets are needed.


Please consider using the icon I provided at work. It's easily 10x cooler.


As indicated in the commit, here's the sample screenshot:
![screenshot-1](https://cloud.githubusercontent.com/assets/1862162/18399046/2da624e8-7684-11e6-939d-e29f0cc339e7.png)


Not sure if this line will create new branch on git level along with creating branch in object model (don't remember clearly but I think this is the reason I used RepoManager.add_branch_and_push?(module_branch[:branch], {}, base_branch) as well). Will need to double check.
Note: when new version of module is installed we need, on git level and in object model, to create new branch for common module and for service module as well.


Does this really needs to be a global variable? I think local one should be enough.
Probably this is also true for all other variables here


What about the extra bytes at the right edge?


khjkj


Okay which ones are you missing?


The CP/CBO ones.


mmin and fmmin should start with 255 and FLT_MAX, no?


Usually, one would want to introduce a new `<br />` without having to introduce a new `p` at all.

This increases readability for me,
since I usually hit <kbd>enter</kbd> to avoid exceeding a max length in my files and `'  '` if I want a new line


They're included and fine?


It is. I'd probably go for an [inline policy](http://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_managed-vs-inline.html) on the IAM user, which can be created via [`iam:PutUserPolicy`](http://docs.aws.amazon.com/IAM/latest/APIReference/API_PutUserPolicy.html) ([godoc](http://docs.aws.amazon.com/sdk-for-go/api/service/iam/#IAM.PutUserPolicy)). Policy document would look something like:

```
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Action": [ "s3:ListBucket", "s3:GetObject" ],
      "Effect": "Allow",
      "Resource": [ "arn:aws:s3:::my-checkup-bucket", "arn:aws:s3:::my-checkup-bucket/*" ]
    }
  ]
}
```


"Bearstatus" -> "BearStatus"


https://github.com/Iamblichos/Community-Patch-DLL/tree/master/Community%2520Patch/LUA

https://github.com/Iamblichos/Community-Patch-DLL/tree/master/Community%2520Balance%2520Patch/LUA

I'm not sure why GitHub made brand new directories for this....annoying.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 424](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1181&buildTypeId=XbimEssentials_XbimEssentials) is now running


ohhh I see. okay I'll fix. Looks like a naming issue.


@techtonik @hsluoyz Seems to be ok: https://security.stackexchange.com/questions/62420/is-code-signing-with-a-non-ssl-timestamp-unsafe


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 424](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1181&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:58


thanks, this'll work. will pull in tonight.


weed mate, weed.


Line 15: "BearStatus was created by..." -> "The original version of BearStatus was created by..."

Also: "Continuing development...by Ben Weinshel and Jason Shu" -> replace the whole sentence with "The project was maintained by Ben Weinshel '15 and Jason Shu '15"


I'm going to give you the benefit of the doubt and assume that you genuinely don't understand what the scene switcher is for, because your comments are not making any sense whatsoever.

The auto-scene switcher is a tool that streamers can use to define conditions under which certain scenes should be displayed. For example, let's say you're playing League of Legends. LoL has a "launcher" window that is separate from the actual game window, so you might have a scene that shows things while you are in the launcher, and a scene that has things arranged while you are in-game. You might go back and forth between these scenes several times over the course of a stream, and it's annoying to have to remember to switch manually.

The auto-scene switcher can detect what the currently active window is, and you can set it up so that if you're using the launcher, it will display the Launcher scene, and if you're in game, it will display the In-game scene. It can do this without any input from the streamer, leaving them to worry about playing the game and entertaining the audience rather than fiddling with stream production. It's an ease-of-use tool that many streamers find very helpful for producing their streams.

It's not a replacement for the existing scene-switching capabilities, nor does it hide control/information from users in any way. Everything still appears as it always did, but now you have the option to say "If X window is selected, show scene Y". That's it.


Si el audio ya está activado, e intento forzar la activación por las dudas de que esté desactivado, sale por consola el mensaje "Error, el audio ya ha sido inicializado"  y en realidad no hay error,  solo que intento activarlo y ya está activado.   El mensaje debería ser "El audio se encuentra inicializado."
La palabra error crea la sensación de que algo no anda bien, cuando todo está ok.


is `visibility_timeout_second` singular on purpose?


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 425](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1182&buildTypeId=XbimEssentials_XbimEssentials) is now running


With no answer from you I added it myself https://github.com/mistic100/jQuery-QueryBuilder/commit/78fc4c93b1bf7b5cfd18a42f8e344f9ddce63d4b


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#IsyWtG4RRY6EHZzWTCuF3Q


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 425](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1182&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:35


@fichtner your right, done that right away :)


We have them at the project level, we shouldn't repeat them for each target.


I think using `<br/>` is a lot better than an empty space. The trade off is any potential spaces that may be present that isn't really necessary.


Fixes #12


Had so much trouble by this same issue. Googled. Got your article. Found it to be 404. Searched. Searched. Finally this commit. Awaiting :)


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/3919


I think this link is wrong?


I will back soon.


Why is only this line translated?


all tests pass:
success: http://buildbot.bos1/builders/test-yokozuna/builds/1917


Maybe link to https://zulip.com/features/ or https://zulip.com/hello/ or another longer list of features?


I must have downloaded a weird commit. I get the error "Type ParameterEncoding has no member url"


ported from https://github.com/linuxmint/systemd-betsy/commit/f7ab85f1e1169ac1598dfc1fba1c01063840b3c5


Huh? You had to rebase it all the way back to November 2014, almost 2 years ago? I'm also intrigued by the fact that you had no other choice. What were you trying to do that forced you to rebase?

Please tell me it's because you've finally finished that time machine


os_2.0_develop_signal_slot_bug (kbenne) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


HUE BR!


#5770-User-file-generating-many-fancoil-max-iteration-warnings (mjwitte) - x86_64-MacOS-10.9-clang: OK (2322 of 2328 tests passed, 0 test warnings)

 * 6 tests had: EIO diffs.
 * 5 tests had: ESO big diffs.
 * 6 tests had: Table big diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: ESO small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.74%25-yellow.svg)


They're not set in the target from what I can tell in Xcode. They're only set in the project.


I know this is just some experimental work, so if you aren't looking for any feedback let me know and I wont comment anymore.  Just thought I'd point out the license header is the older style and would be good to use the updated version (no years).  Also noticed the missing generic type for the type Class argument.

Am curious if `Realm` (in combo with ClassValue) is meant to replace `ClassInfo`?


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#UfdJ6WMOR1mEL9bzoyZPwg


test_build_branch (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1499 of 1499 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.66%25-green.svg)


Oh okay! I misread the diff then.


Excellent!


Este metodo te devuelve una instancia de la libreria o mejor dicho de la implementacion que se va a utilizar para capturar los eventos de Entrada por botones presionados del usuario. En SDL no encontre como inicializar solamente los eventos de teclado, por eso cuando veas la implementacion, esta inicializado EVENT completo.


Not working since DynmapPlugin#postPlayerJoinQuitToWeb doesn't output anything


We must have one single page to relate installation. I think it must not appear in the doc itself, but on the website directly.
A copy of instructions can be find in a file INSTALL for example.


Oops. Seems I forgot to update my package to **v3.0.10**, sorry! :wink:


En este momento, esta hardcodeado en SDL porque es la unica que tengo. Lo pense de esa manera por si en un futuro tengo que cambiar la libreria o Hacer una propia por el simple hecho de ganar experiencia.


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#JO1BPQ0oR5eDv0SobjfREg


@pb00068
GL with your patch.

It seems we both enjoy tweaking up history stats...it's an interesting area in computer chess.

I like the idea of using an array...I would actually considered this a simplification, since we only need to update the formula at one place, but I am no maintainer.


"Canola" is misspelled.


Se entiende, pero no quiero pensar en hacer cosas estaticas cuando Creo que no vale la pena y directamente prefiero ocupar un poco mas el Stack. Prefiero dejar los metodo estaticos para futuros callbacks en el caso que los necesite.


Ok, pero dónde vas a hacer el delete de este puntero? en algún otro lado del código, donde se recibe el puntero, debe hacerse un delete cuando se cierra el juego.


But the bytes past the edge have random values. They will affect the results.


Why is `uint` now displayed as hex? If a user wants to see the `uint` in hex, can't they just cast to `bytes32`? I think base 10 is much more readable for integers.


Muchas Gracias.
Cuando mencionaste lo de los Destructores en la charla sabia que me los ibas a marcar al toque. Simplemente me olvide de agregarlos.


Could you change this from this:
``
    <string-array name="enabled_networks_except_lte_choices" translatable="false">
    	 <item>@string/network_wcdma_only</item>
    	 <item>@string/network_gsm_only</item>
    	 <item>@string/network_wcdma_pref</item>
    </string-array>
``
To this?:
``
    <string-array name="enabled_networks_except_lte_choices" translatable="false">
    	 <item>@string/preferred_network_mode_wcdma_only_choice</item>
    	 <item>@string/preferred_network_mode_gsm_only_choice</item>
    	 <item>@string/preferred_network_mode_gsm_wcdma_preferred_choice</item>
    </string-array>
``


Oh.. Thanks, didn't notice that. :smile:


+14/09/2016 | Nova Reunião, inicialização do aplicativo. Onde o grupo discutirá á cerca do aperfeiçoamento de wireframe, tais como , o que deve ser melhorado , mudado etc.


remove comment


ditto


magic number should probably be defined as constant somewhere. Maybe `shuup.core.fields`?


No need to iterate yourself, you could just pass it to `new HashMap(HERE)`


can you add a test for the following scenario:
```
buy 2 of a product with a base unit price of 29.264 refund 1 at 29.264 then refund 1 more at 29.264. The order total is 0.01. Should be 0.
```


whats going on here xD


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 426](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1183&buildTypeId=XbimEssentials_XbimEssentials) is now running


As suggested input data is hard coded in BillGeneratorTest class. Please execute this JUnit test for output. The main flow of program is on PointOFSale.java and remaining subprograms are connected to this main program.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 426](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1183&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:30


Bad idea John!


?? License change? ;-)


os_2_0_develop_linux (macumber) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


No, simply no! All those strings are non existing. Those strings are from patches: https://github.com/ghsr/build_tools/blob/cm-13.0/patches/packages_services_Telephony.patch
Things doesn't just work with copy paste. These strings are from inbuilt cm system, tell me one good reason i would change it. (Except that translation stuff that is totally pointless for me). There is no need to patch everything if thing works even without that.


reconfigure semantic, using the wrong @fontpath. created the new directory for now


We had several integer overflows after working with large numbers, but i miss base 10 myself.
I think the best way is to go with a logic which displays hex in case it would be an overflow and base 10 otherwise.


Honestly I dunno why we went with base 16, will revert this. Thanks


Awesome John!


What the hell!?


sorry


test_build_branch (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


`'select'` -> <code>\`select\`</code>


Why you do not use const, as i know it is more effecient memory usage?


Seems reasonable to me. This is going to require discipline on the part of
people adding sets, but that IS what we have the board for-- if someone
needs to be trout-slapped for misuse, it can be done in relatively short
order.

On Fri, Sep 9, 2016 at 10:32 AM, R. Belmont <notifications@github.com>
wrote:

> Haze: we already put down strict rules about this. Renaming existing sets
> isn't going to happen, and for future sets using all the letters for the
> sake of it will not pass either. This is just about sets where a few more
> letters would make an unreadable Eastern European-looking mess into
> something people can remember and type.
>
> (There's a proposal to rename the Nintendo VS sets to all have a
> consistent "nvs_" prefix, which this would certainly help with, but that's
> not guaranteed to happen).
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/mamedev/mame/commit/3291684c2baf8d43c7300e0a2f7fc42b6ee8bcff#commitcomment-18966527>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AI5mX4lFbAcl6BAx8JTMP0DRekPCDJdGks5qoZgVgaJpZM4J49Ta>
> .
>


And why you referencing the same property twice, as i know it is better to create a const for that, or not? Does compiler create single temp variable for his reference or it will two?


Modificación viabilidad financiera de nuestro proyecto
[VIABILIDAD DE COSTOS.docx](https://github.com/carlosbalamba/MIKEBOL/files/464686/VIABILIDAD.DE.COSTOS.docx)


Adding the images for manual-index.adoc


Change "WCDMA Only" to "WCDMA", "WCDMA/GSM preferred" to "GSM/WCDMA" and "GSM only" to "GSM" (I'll close this discussion when you'll do this change)


Offtopic:
By the way, could you add performance profiles?


*could=can


I agree.


Use values from .properties file (there is a DAO fort that). Avoid hard strings when possible.
Sale thing gor line 32.


@kjohnson Not sure where exactly the breakdown happened, but the localization for this string was done as ["with an"](https://github.com/wpninjas/ninja-forms/blob/201b4bcb7badeed8e65641a96bc3357436411462/lang/ninja-forms-ja.po#L29) not "with a". It's affecting display in all languages.

<img width="298" alt="screen shot 2016-09-09 at 2 42 18 pm" src="https://cloud.githubusercontent.com/assets/522158/18400490/c3b6acac-769b-11e6-873d-a5d56bc53c22.png">


No, I won't change until I found a good reason for it.
And,performance profiles is already ported by me, it's even working fine(just need some fine tuning of freqs)
@19ba5323


Now that you say, the expression must also expand that thing "\%.." since expand function handles the escape char and hence outputs a literal '%..'. I would make the changes and add a corresponding test.


Thank you @chapmanb


Added Education


test_build_branch (lefticus) - Win64-Windows-7-VisualStudio-12: Tests Failed (1537 of 2048 tests passed, 37 test warnings)

 * 538 tests had: AUD diffs.
 * 529 tests had: EIO diffs.
 * 422 tests had: ESO small diffs.
 * 511 tests had: RDD diffs.
 * 496 tests had: Table big diffs.
 * 85 tests had: ERR diffs.
 * 115 tests had: ESO big diffs.
 * 419 tests had: BND diffs.
 * 359 tests had: MTR small diffs.
 * 76 tests had: MTR big diffs.
 * 4 tests had: SSZ big diffs.
 * 15 tests had: MDD diffs.
 * 35 tests had: MTD diffs.
 * 29 tests had: DXF diffs.
 * 5 tests had: ZSZ big diffs.
 * 1 test had: SSZ small diffs.
 * 1 test had: ZSZ small diffs.
 * 3 tests had: delightin diffs.
 * 3 tests had: delightout diffs.
 * 1 test had: SHD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-75.05%25-red.svg)


Voy a eliminar el puntero cuando se ejecute el destructor del GameFlow en el que me encuentre.  No esta hecho todavia, pero lo tengo en cuenta.

De todas maneras lo voy a cambiar, Voy a hacer que el GameController tenga las instancias de los Handlers que voy a utilizar. Porque teoricamente, no van a cambiar durante todo el juego, se los voy a pasar por Referencia a los GameModes y cuando se ejecute el Destructor del GameController, libero Memoria.

Pido disculpas por las respuestas que puse antes sobre este tema. No habia leido bien tu comentario.


Gets or sets if  accelerated networking enabled on network interface


LGTM


Person5 edits are a stopgap solution to make sure the files would compile so I could verify the integrity of my gradle build


Ok. Well hopefully it makes new players play more to get items that are harder to find. I just think that whenever you increase challenge on an item (time or money), all the regular players still obtain them because they have the time and money, and you place it out of reach for the new players. Some players will just play more and that makes it fun, but it makes that initial hill into the game harder to climb for new players. I don't want new players to feel like they are getting crushed before they have a chance to learn the game.


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#dXYccezdTG62raHkBQPuEQ


Methods name should almost always begin with a verb (here getRandomNumber).


Dale! todo bien :)


Leaving this method static makes its usées have tout instantiate thé class.


a better name for the argument would be parentClassName, className, or parentClass


No, fixing in a hotfix.


This relies on a pwnixversion prop value that we will set after installing the chroot with pxinstaller and update as needed at the end of chef runs with setprop

Alternatively we can check and set at boot with chrootboot but is kinda overkill


why do you have nothing in this if statement? just use a !=


[Casos de uso extendido Unifsena.docx](https://github.com/Unifsena/Unifsena/files/464707/Casos.de.uso.extendido.Unifsena.docx)


FWIW, the patch is no longer required for 2.8~rc{1,2}, so it seems to have been fixed in the mean time.


The structure is allocated with calloc so all bits are already zero.


This has to be **fixed**. I have to either make a PR to fix this in [webpack/enhanced-resolve](https://github.com/webpack/enhanced-resolve/) or publish [ts-context-loader](https://gist.github.com/IgnusG/da04250adf9e90162692b4982c596c0c) to [npmjs.com](https://www.npmjs.com/). Maybe both...


Nice work @jplsek !


@JoinRajunraftNow,
THE GOLD INT? WHAT IS THAT?


"Pixie's current situation"
pixie is dead


Ah, the amount of gold. Duh.


What?


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#H310rp2ETEKlNTN0OKqsFw


interesting. trying out commenting on first commit


後來會出現 排名亂掉的狀況


@lwahonen I'll only focus on the concrete usecase: Both suggested sources for errors here are covered:

- hWnd is never invalid -- null is always a valid value and retrieves all messages for this thread
- lpMsg is initialized on the java side and so can't be invalid

Do you suggest a change?


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#cuANs5h-Qs6sXiSetpIeFw


mix of " and ' triggers me


f


Ayyy, commit 3000


Probably not needed for ydk-py. Any advantage of having this?


you write truth tests like my grandmother


Thank you.
So much.


dsdasdasd


This, together with `/**` in `autoClosingPairs` below allows to write doc comments easily like this:
![](http://i.imgur.com/0JslYFQ.gif)


별론데요


I played games.


별로네요


inconsistent spaces


These settings allow wrapping selection in brackets/quotes, like this:
![](http://i.imgur.com/96f30nN.gif)
![](http://i.imgur.com/wjYPXnF.gif)
I'm not yet sure whether this is useful or annoying, but I decided to give it a try.


Q&A:

>Tonys-Mac:path2java dc$ git push
error: update_ref failed for ref 'refs/remotes/origin/master': cannot lock ref 'refs/remotes/origin/master': Unable to create '/Users/dc/documents/onedrive/gitplace/path2java/.git/refs/remotes/origin/master.lock': Permission denied

Solution:
Acoording to the error message, git fail to write ' master.lock" into my local repo. I put the local repo of git in my Onedrive folder. It seems that I created the local repo folder with a *sudo*. So the solution is change the permission mode of the folder and add write permission for it.
> sudo chmod -R a+w OneDrive/

Then it works :)


delete


感觉好脆弱啊，不用改到 index.html 吗


thing two


Thanks for the link to the conversation.  I'll look into the references that Riastradh mentions and take a look at the libsodium library (I guess it's [saltine](https://hackage.haskell.org/package/saltine)).  Once I think I understand what needs to be done we can discuss an approach.


ok


@jaswsinc FYI, this was fixed: https://github.com/websharks/woocommerce-intercom-pro/compare/282cb01a24b0...86f8ac436b7f


۳


Should be, yes


Cool. Love the use of `sprintf()` there. Nice!


maybe just add a third argument to UpdateEnmity that is explicitly 0 when called from UPdateEnmityFromCure but defaults to 1 which controls writing to high pc level?


develop (Unknown) - i386-Windows-7-VisualStudio-12: OK (2401 of 2448 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.08%25-yellow.svg)


I do not understand what you're writing. and no useful info for [my website](http://topdoublestrollers.net/)


input_processor_refactor (pshires) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1782 of 1784 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.98%25-green.svg)


Thanks!


following ...


这里需要有一些具体的限制吧。比如是不能打开仓盖


app Fonctionnel


Now that Apex has thermal resistant clothing why are we still making thermal items harder to get? Everyone wears the full ghillie and it has almost no thermal signature.


First commit of the validation service (lacks enum,bits, decimal 64 test cases)


my WPF Practise Demos


Sugiero emepezar con mayuscula


I don't love apple juice.


@DerekRS Sorry since I'm not test that very well it give us some error, So I already make change in this [commit](https://github.com/NanoDesuTranslations/editor/commit/864758ac0cd8db6fb1a624def2368ca053739fa6) Still don't know why comment directives and class directive not working. I'm just following in [here](https://docs.angularjs.org/guide/production)


Looks like a lot of repeated code `if !PreActionCall("NextSplit") {`. Is it possible that action is not called directly, but through some "ActionQueue", which can actually handle this?


Creo que hay un error


The keys for Issues have been added.


dddddddd


- this nonsense text was added by accident - that's a bug (fixed in next commits)


Duno


Shouldn't we remove **LDAP** from these tests and just have **SIMBA_JDBC**
If I do `-g LDAP`, these tests would be called even though I am not using Simba JDBC drivers and just need to run CLI Ldap tests. The group **LDAP** is also used for CLI tests.

https://github.com/Teradata/presto/blob/50e45a0b3dde5f13c253315792b5e593f4e8602f/presto-product-tests/src/main/java/com/facebook/presto/tests/cli/PrestoLdapCliTests.java#L99


I am on React 15.3.1 and this is the error stack:

```
Error: Can't find npm module 'react-addons-pure-render-mixin'. Did you forget to call 'Npm.depends' in package.js within the 'modules-runtime' package?
W20160908-20:48:17.276(-6)? (STDERR)     at Object.Npm.require (/Users/michelherszak/Projects/JavaScript/beta/.meteor/local/build/programs/server/boot.js:198:17)
W20160908-20:48:17.276(-6)? (STDERR)     at options.fallback (packages/modules-runtime/modules-runtime.js:21:1)
W20160908-20:48:17.277(-6)? (STDERR)     at Module.require (packages/modules-runtime/.npm/package/node_modules/install/install.js:88:1)
W20160908-20:48:17.286(-6)? (STDERR)     at Module.Mp.import (/Users/michelherszak/.meteor/packages/modules/.0.7.6.1lcbb77++os+web.browser+web.cordova/npm/node_modules/reify/lib/runtime.js:70:16)
W20160908-20:48:17.286(-6)? (STDERR)     at meteorInstall.node_modules.meteor.react-meteor-data.createContainer.jsx (/Users/michelherszak/Projects/JavaScript/beta/.meteor/local/build/programs/server/packages/react-meteor-data.js:210:256)
W20160908-20:48:17.287(-6)? (STDERR)     at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:153:1)
W20160908-20:48:17.287(-6)? (STDERR)     at require (packages/modules-runtime/.npm/package/node_modules/install/install.js:82:1)
W20160908-20:48:17.287(-6)? (STDERR)     at meteorInstall.node_modules.meteor.react-meteor-data.react-meteor-data.jsx (packages/react-meteor-data/react-meteor-data.jsx:7:25)
W20160908-20:48:17.288(-6)? (STDERR)     at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:153:1)
W20160908-20:48:17.288(-6)? (STDERR)     at require (packages/modules-runtime/.npm/package/node_modules/install/install.js:82:1)
```
The problem seems to come from `react-meteor-data` so I updated it to 0.2.9 but that didn't help.


Shouldn't we remove LDAP from these tests and just have SIMBA_JDBC
If I do -g LDAP, these tests would be called even though I am not using Simba JDBC drivers and just need to run CLI Ldap tests. The group LDAP is also used for CLI tests.

https://github.com/Teradata/presto/blob/50e45a0b3dde5f13c253315792b5e593f4e8602f/presto-product-tests/src/main/java/com/facebook/presto/tests/cli/PrestoLdapCliTests.java#L99


I think we need another VM with Mininet installed, and then we connect Mininet VM with FAST System VM. There will be potential errors, if Mininet is installed in the same VM as FAST System.


I have changed from "reboot now" to just "yes", if you want to reply something make more sense say yes or no


@darkevilmac Size could mean a number of things. Amount is exactly what it is: It's the amount of items in the stack. You may use `size` to refer to the number of unique items in a collection (though I prefer `count`), but this is not a collection. [`item` : stone, `size` : 2] \(or worse, `stackSize`) vs [`item` : stone, `amount` : 2] ?


Causes races for us… https://github.com/grpc/grpc-go/issues/886


I have found the error now as well. It seems that it can not load the native functions from C++. This is really annoying, becuase everything has been ok until now.


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#eXZPhHafQrGGvF8Mlrm2vA


I will investigate this further.


eww, don't use backslash. Wrap the entire condition in parenthesis instead.


That would work.


That's a fair point.

On the other hand there already are observers for `mouseup` and `keyup`, so DOM events are already there.

Eventually we are going to implement ES Proxy instead of DOM event listeners: https://github.com/Starcounter-Jack/JSON-Patch/issues/96


I have installed it and so far no problem. In any case I am a PMO user...


Static analysis complains about this,
I think because brackets were not included.

Is there a case where the graphic will be null?
The user interface is disabled when there isn't an open drawing.


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#aGae6S4dSa2qGXXRe7oTdw


this diff makes me sad.


Thanks for the fix.

But I think it'd be better to raise an AttributeError in this case (so that items without the ISticky interface are not included in the index at all) and change the following line to `return getattr(context, 'sticky', None) or False` so we always get True or False in the index for items that do provide ISticky.


The whole point is to have people gear up without going to the store, where
all the regulars camp.

On Sep 9, 2016 12:49 PM, "tylers-dev" <notifications@github.com> wrote:

> Ok. Well hopefully it makes new players play more to get items that are
> harder to find. I just think that whenever you increase challenge on an
> item (time or money), all the regular players still obtain them because
> they have the time and money, and you place it out of reach for the new
> players. Some players will just play more and that makes it fun, but it
> makes that initial hill into the game harder to climb for new players. I
> don't want new players to feel like they are getting crushed before they
> have a chance to learn the game.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/A3Armory/A3A_A3Wasteland.Altis/commit/47e5948d1bc0e99cf26efe99f71145359adeadf4#commitcomment-18968603>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AI6sJvsuKkUOIJgw-BequxctU6lUR3GGks5qobg3gaJpZM4J4pCE>
> .
>


test_build_branch (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (948 of 948 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.63%25-green.svg)


You can yield many futures at once to parallelize these communications

futures = [self.rpc(addr=w)... for w in ...]
yield futures


kl;k


Yeah, sorry.  The current draft explains how to get it basically working but ultimately the Devise auth pages were sharing the same WebView with the rest of the views after the user was logged in so you could hit the "back" button in the nav bar in the app and it would try to go back to the login screen and give you a Devise "already logged in" notice that you couldn't clear.

After some more research I figured out how to get the authentication piece into a separate WebView so that it doesn't share the same set of views as the rest of the site but does share the same session.

I highly recommend using the Turbolinks iOS demo app as a guide to how to do this but I will try to get this article updated soon on my new findings.

Glad you found my article though! 😄


Please always push to a branch to open a pull request, not directly to `master`. In your local repository, you can do:
```
git checkout -b new_branch
# make changes
git add ...
git commit
git push origin new_branch  # creates a branch on Github
```
Then, head to `https://github.com/JuliaSmoothOptimizers/Optimize.jl` and open a pull request.


hmmm, this is an outdated commit from a few hours ago, not sure how github brought you here. See the PR file changes for current rendition.


I guess this is not the right forum for this discussion, but I wasn't sure if our policy is to check for errors from OS functions. To me, that MSDN bit sounds like the function can return an error, and lists a few examples of possible errors, not all possible errors. Probably you only get an error if the system is running out of memory, the message queue is corrupted or something similarly horrible is happening.


so this test works if you replace `w=1` with `x=x`. This is because we are not actually creating a binding for 'x' at all.


There was some MPs end date Previous deputies list: http://w1.c1.rada.gov.ua/pls/site2/fetch_mps?skl_id=9&pid_id=-3 ago were written test end date


this shouldn't have been stripped,  making note here so I remember to fix it


Are those directories manually renamed in ydk-py?


Yes


What? WHY? WHY DO YOU HAVE UNNEEDED SPACES IN THIS?!?!?!?!?!?


Look at my C++ version for how to code-golf.


`else assert(len(block_dicts) == 0)` ?


EMS (brianlball) - i386-Windows-7-VisualStudio-12: Tests Failed (0 of 2466 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Could this result in flaky behavior depending on the order in which the dict entries are serialized?  Or will it always be deterministically ordered in some way?


It's still bad style


To verify that we don't have a wacky serialization that got blocks with no course key?  I'd be good with that.


Nice test.


Close #3


this broke landing_gear.py in gpkit-models


should have gotten a better score... If we could do it again I could much better model the flow now... sad panda


I expect almost every Swift program to use Dictionary extensively, so this variable will be initialized in every Swift program anyway.  It is not uncommon to use Dictionary or Set early in the program run (the same way NSDictionary is used everywhere).  I also expect this variable to be accessed frequently -- in future, once for every hash value compted.  Thus, I think it is reasonable to perform eager initialization of this variable to remove checks everywhere else in the process.


Note: this respects the old format


They are deterministically ordered by `sort_keys=True`.  That's also required for our hashing to work.


Salaam,

Just a small note. I noticed that this 👇🏼 line in the repo. still has NS although it's written without NS in the README! Maybe you need to edit it in the repo. also? I don't have permission to edit it in the repo.

`Breeze through Date, DateComponents, and TimeInterval`


This has caused me a problem with the bad block table which does use the OOB to store its identifying pattern (see bbt_pattern). The MTD NAND driver (nand_base.c, nand_bbt.c) scans the flash for a BBT (primary and mirror) generally on bootup when U-Boot tries to read the environment from flash. The MTD operation mode used is MTD_OPS_PLACE_OOB by U-Boot (and Linux). For the on-die ECC chip it calls the nand_chip->ecc.read_page function, which you changed from being able to read the OOB to not reading the OOB. Since it expected an OOB it is acting on whatever was in the chip's OOB memory buffer from a possible earlier transaction using raw mode (if any). End result one would normally see is each time U-Boot boots it can't find the BBT and re-scans the entire flash and creates and writes a new one. This adds time and wastes erase cycles.

If you look at the Linux driver, pl353_nand.c, it sets the ecc.read_page = pl353_nand_read_page_raw. This driver has no _nooob function.

U-Boot and the BBT code seems happy now that I reversed this change and put it back to read_page_raw.


I can't test this because your albums.html is broken?
https://bantuist.github.io/album.html


Why was this method added?

The problem with this method is that it ignores the refcount and ref/unref because it results in a call to finish_shutdown(): on_read()=>(deactivated_all_ports()||destroyed_port())=>finish_shutdown()=>gpr_free().

A call to this method deletes the grpc_tcp_server regardless of the current refcount.


...and tested on L127.


this cancels any previously sent shutdown intents so that we can send ours now.


which line? Can you find a link?


Le vendredi 9 septembre 2016 à 07:34 -0700, Enrico a écrit :
> @erikmd Erik, can you explain why top' and lhs' have to be unified by hand here? If I understand it correctly, rewrite [top]equ does it too.

The issue with doing "rewrite [top]equ" alone is that it would keep
all evars (those that are specifically introduced by the under tactic)
uninstantiated, so after using the tactic the user would end up with
several shelved goals for these evars.
I've seen in the ssr refman that not-instantiating existing evars is a
design choice for ssreflect's rewrite (which is an important feature
when doing a sequence of rewritings IIUC), but in my use case doing
"unify top' lhs' with typeclass_instances" beforehand did the trick...


Keep it simple.  Set up data.  Do things.  Make assertions.


@pgkirsch, good news bad news. The new master finds some unneeded substitutions, but I can't find a single version of master which can run this. Did you have a particular branch?


@gaearon Today I saw this trick:

```js
import store from './store';
import actionCreators from './actions';
import { bindActionCreators } from 'redux';
const actions = bindActionCreators(actionCreators, store.dispatch);
export { actions };
export { store };
```

And then no need to bind action creators in `@connect()`.

What do you think about this trick?
Can you spot any downsides?


The first line:
<img width="719" alt="screen shot 2016-09-09 at 11 23 15 pm" src="https://cloud.githubusercontent.com/assets/3218401/18401714/808934ec-76e4-11e6-804b-d4c170b6d885.png">


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#GtALFCZxShCkDXDCDyuLfQ


I have run sweeps of the aircraft model with master previously...


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#e9JHVlmtTFC_Z7mSLcXj_Q


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#csoKHq3WQ-S9E3cEd3TI2A


Yeah I thought I remembered it working as well! I wasn't sure it was the script version of `aircraft.py` that I was running, or this version on the master branch of `gpkit-models`


Fixes #5


Btw you can put this file in `~/.vim/after/syntax/` and then just use stock vim-css-color. That way you don’t need to maintain a fork of the plugin.


The version on `aircraft_improvements` runs great.


Comment JLT!!


initial commit


Dont worry too much about interaction tables yet. Right now, the tables we need are only for holding simple data so we might be able to do some simple stuff


I still can't find any commit on master which can run this commit (302daa6f7132923ebb91e8a7f5bf6ba8b3e800d5) as a script (`python aircraft.py`)


Should probably just be `id`


A name shouldnt be longer than 64 characters


huh weird I thought I ran it on master but maybe I didn't


git url not longer than 1024


git hash not longer than 1024


[R/analysis.R:1:2:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L1) *style:* **Commented code should be removed.**
```r
## Copyright 2016 Christian Diener <mail[at]cdiener.com>
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/analysis.R:29:31:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L29) *style:* **Commas should always have a space after.**
```r
        in_t <- colMeans(v[ti,]) + 1e-6
                              ^
```
[R/analysis.R:33:30:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L33) *style:* **Put spaces around all infix operators.**
```r
        res <- data.table(rid=names(in_t), panel=pname, lfc=lfcs)
                            ~^~
```
[R/analysis.R:33:49:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L33) *style:* **Put spaces around all infix operators.**
```r
        res <- data.table(rid=names(in_t), panel=pname, lfc=lfcs)
                                               ~^~
```
[R/analysis.R:33:60:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L33) *style:* **Put spaces around all infix operators.**
```r
        res <- data.table(rid=names(in_t), panel=pname, lfc=lfcs)
                                                          ~^~
```
[R/analysis.R:60:28:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L60) *style:* **Put spaces around all infix operators.**
```r
    scores <- vector(length=n)
                          ~^~
```
[R/analysis.R:61:41:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L61) *style:* **Put spaces around all infix operators.**
```r
    scores[pws == p] <- abs(w[pws == p])/nr
                                       ~^~
```
[R/analysis.R:62:27:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L62) *style:* **Put spaces around all infix operators.**
```r
    scores[pws != p] <- -1/(n - nh)
                         ~^~
```
[R/analysis.R:62:28:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L62) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    scores[pws != p] <- -1/(n - nh)
                           ^
```
[R/analysis.R:89:52:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L89) *style:* **Put spaces around all infix operators.**
```r
    norm <- replicate(n, ES(p, w, sample(pws), both=TRUE))
                                                  ~^~
```
[R/analysis.R:93:19:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L93) *style:* **Put spaces around all infix operators.**
```r
        nes <- -es/mean(no)
                 ~^~
```
[R/analysis.R:94:29:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L94) *style:* **Put spaces around all infix operators.**
```r
        pval <- sum(no < es)/length(no)
                           ~^~
```
[R/analysis.R:97:18:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L97) *style:* **Put spaces around all infix operators.**
```r
        nes <- es/mean(no)
                ~^~
```
[R/analysis.R:98:29:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L98) *style:* **Put spaces around all infix operators.**
```r
        pval <- sum(no > es)/length(no)
                           ~^~
```
[R/analysis.R:118:36:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L118) *style:* **Commas should always have a space after.**
```r
            xi <- paste0(substr(xi,1,n-1), "...")
                                   ^
```
[R/analysis.R:118:38:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L118) *style:* **Commas should always have a space after.**
```r
            xi <- paste0(substr(xi,1,n-1), "...")
                                     ^
```
[R/analysis.R:118:39:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/analysis.R#L118) *style:* **Put spaces around all infix operators.**
```r
            xi <- paste0(substr(xi,1,n-1), "...")
                                     ~^~
```
[R/exarray.R:1:2:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/exarray.R#L1) *style:* **Commented code should be removed.**
```r
## Copyright 2016 Christian Diener <mail[at]cdiener.com>
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/exarray.R:41:12:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/exarray.R#L41) *style:* **Variable and function names should be all lowercase.**
```r
    return(ExpressionSet(res))
           ^~~~~~~~~~~~~
```
[R/ml.R:1:2:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L1) *style:* **Commented code should be removed.**
```r
## Copyright 2016 Christian Diener <mail[at]cdiener.com>
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ml.R:25:20:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L25) *style:* **Put spaces around all infix operators.**
```r
    mse <- mean(res^2)
                  ~^~
```
[R/ml.R:28:25:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L28) *style:* **Put spaces around all infix operators.**
```r
    mre <- mean(abs(res)/abs(truth))
                       ~^~
```
[R/ml.R:29:23:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L29) *style:* **Put spaces around all infix operators.**
```r
    rsq <- 1 - sum(res^2)/sum((truth - mean(truth))^2)
                     ~^~
```
[R/ml.R:29:26:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L29) *style:* **Put spaces around all infix operators.**
```r
    rsq <- 1 - sum(res^2)/sum((truth - mean(truth))^2)
                        ~^~
```
[R/ml.R:29:31:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L29) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    rsq <- 1 - sum(res^2)/sum((truth - mean(truth))^2)
                              ^
```
[R/ml.R:29:52:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L29) *style:* **Put spaces around all infix operators.**
```r
    rsq <- 1 - sum(res^2)/sum((truth - mean(truth))^2)
                                                  ~^~
```
[R/ml.R:31:10:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L31) *style:* **Put spaces around all infix operators.**
```r
    c(mse=mse, rmse=rmse, mae=mae, mre=mre, rsq=rsq)
        ~^~
```
[R/ml.R:31:20:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L31) *style:* **Put spaces around all infix operators.**
```r
    c(mse=mse, rmse=rmse, mae=mae, mre=mre, rsq=rsq)
                  ~^~
```
[R/ml.R:31:30:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L31) *style:* **Put spaces around all infix operators.**
```r
    c(mse=mse, rmse=rmse, mae=mae, mre=mre, rsq=rsq)
                            ~^~
```
[R/ml.R:31:39:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L31) *style:* **Put spaces around all infix operators.**
```r
    c(mse=mse, rmse=rmse, mae=mae, mre=mre, rsq=rsq)
                                     ~^~
```
[R/ml.R:31:48:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L31) *style:* **Put spaces around all infix operators.**
```r
    c(mse=mse, rmse=rmse, mae=mae, mre=mre, rsq=rsq)
                                              ~^~
```
[R/ml.R:50:8:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L50) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    for(i in 1:ncol(M)) {
       ^
```
[R/ml.R:51:69:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L51) *style:* **Put spaces around all infix operators.**
```r
        newnames <- paste0(nam[i], "x", colnames(M[, i:ncol(M), drop=F]))
                                                                   ~^~
```
[R/ml.R:52:20:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L52) *style:* **Put spaces around all infix operators.**
```r
        x <- M[, i]*M[, i:ncol(M), drop=F]
                  ~^~
```
[R/ml.R:52:40:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/ml.R#L52) *style:* **Put spaces around all infix operators.**
```r
        x <- M[, i]*M[, i:ncol(M), drop=F]
                                      ~^~
```
[R/RcppExports.R:5:11:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/RcppExports.R#L5) *style:* **Only use double-quotes.**
```r
    .Call('prtools_matrix_reduce', PACKAGE = 'prtools', m, idx, factors, method)
          ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/RcppExports.R:5:46:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/RcppExports.R#L5) *style:* **Only use double-quotes.**
```r
    .Call('prtools_matrix_reduce', PACKAGE = 'prtools', m, idx, factors, method)
                                             ^~~~~~~~~
```
[R/RcppExports.R:7:1:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/RcppExports.R#L7) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/zzz.R:1:2:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/R/zzz.R#L1) *style:* **Commented code should be removed.**
```r
## Copyright 2016 Christian Diener <mail[at]cdiener.com>
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_analysis.R:4:24:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_analysis.R#L4) *style:* **Put spaces around all infix operators.**
```r
    v <- matrix(1, nrow=10, ncol=10)
                      ~^~
```
[tests/testthat/test_analysis.R:4:33:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_analysis.R#L4) *style:* **Put spaces around all infix operators.**
```r
    v <- matrix(1, nrow=10, ncol=10)
                               ~^~
```
[tests/testthat/test_analysis.R:7:25:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_analysis.R#L7) *style:* **Put spaces around all infix operators.**
```r
    map <- rep(1:2, each=5)
                       ~^~
```
[tests/testthat/test_analysis.R:11:29:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_analysis.R#L11) *style:* **Put spaces around all infix operators.**
```r
    extra <- data.frame(info=paste0("info", 1:10))
                           ~^~
```
[tests/testthat/test_analysis.R:21:48:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_analysis.R#L21) *style:* **Put spaces around all infix operators.**
```r
    expect_equal(2, length(ES("a", w, pws, both=TRUE)))
                                              ~^~
```
[tests/testthat/test_analysis.R:37:36:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_analysis.R#L37) *style:* **Put spaces around all infix operators.**
```r
    long <- paste(letters, collapse=" ")
                                  ~^~
```
[tests/testthat/test_exarray.R:4:21:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L4) *style:* **Commas should always have a space after.**
```r
    m <- matrix(c(1,1,1,2,2,2,1,1,1,3,3,3), ncol=3, byrow=TRUE)
                    ^
```
[tests/testthat/test_exarray.R:4:23:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L4) *style:* **Commas should always have a space after.**
```r
    m <- matrix(c(1,1,1,2,2,2,1,1,1,3,3,3), ncol=3, byrow=TRUE)
                      ^
```
[tests/testthat/test_exarray.R:4:25:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L4) *style:* **Commas should always have a space after.**
```r
    m <- matrix(c(1,1,1,2,2,2,1,1,1,3,3,3), ncol=3, byrow=TRUE)
                        ^
```
[tests/testthat/test_exarray.R:4:27:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L4) *style:* **Commas should always have a space after.**
```r
    m <- matrix(c(1,1,1,2,2,2,1,1,1,3,3,3), ncol=3, byrow=TRUE)
                          ^
```
[tests/testthat/test_exarray.R:4:29:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L4) *style:* **Commas should always have a space after.**
```r
    m <- matrix(c(1,1,1,2,2,2,1,1,1,3,3,3), ncol=3, byrow=TRUE)
                            ^
```
[tests/testthat/test_exarray.R:4:31:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L4) *style:* **Commas should always have a space after.**
```r
    m <- matrix(c(1,1,1,2,2,2,1,1,1,3,3,3), ncol=3, byrow=TRUE)
                              ^
```
[tests/testthat/test_exarray.R:4:33:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L4) *style:* **Commas should always have a space after.**
```r
    m <- matrix(c(1,1,1,2,2,2,1,1,1,3,3,3), ncol=3, byrow=TRUE)
                                ^
```
[tests/testthat/test_exarray.R:4:35:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L4) *style:* **Commas should always have a space after.**
```r
    m <- matrix(c(1,1,1,2,2,2,1,1,1,3,3,3), ncol=3, byrow=TRUE)
                                  ^
```
[tests/testthat/test_exarray.R:4:37:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L4) *style:* **Commas should always have a space after.**
```r
    m <- matrix(c(1,1,1,2,2,2,1,1,1,3,3,3), ncol=3, byrow=TRUE)
                                    ^
```
[tests/testthat/test_exarray.R:4:39:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L4) *style:* **Commas should always have a space after.**
```r
    m <- matrix(c(1,1,1,2,2,2,1,1,1,3,3,3), ncol=3, byrow=TRUE)
                                      ^
```
[tests/testthat/test_exarray.R:4:41:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L4) *style:* **Commas should always have a space after.**
```r
    m <- matrix(c(1,1,1,2,2,2,1,1,1,3,3,3), ncol=3, byrow=TRUE)
                                        ^
```
[tests/testthat/test_exarray.R:4:49:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L4) *style:* **Put spaces around all infix operators.**
```r
    m <- matrix(c(1,1,1,2,2,2,1,1,1,3,3,3), ncol=3, byrow=TRUE)
                                               ~^~
```
[tests/testthat/test_exarray.R:4:58:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L4) *style:* **Put spaces around all infix operators.**
```r
    m <- matrix(c(1,1,1,2,2,2,1,1,1,3,3,3), ncol=3, byrow=TRUE)
                                                        ~^~
```
[tests/testthat/test_exarray.R:6:13:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L6) *style:* **Variable and function names should be all lowercase.**
```r
    eset <- ExpressionSet(m)
            ^~~~~~~~~~~~~
```
[tests/testthat/test_exarray.R:7:15:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L7) *style:* **Commas should always have a space after.**
```r
    gr <- c(1,1,2,2)
              ^
```
[tests/testthat/test_exarray.R:7:17:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L7) *style:* **Commas should always have a space after.**
```r
    gr <- c(1,1,2,2)
                ^
```
[tests/testthat/test_exarray.R:7:19:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L7) *style:* **Commas should always have a space after.**
```r
    gr <- c(1,1,2,2)
                  ^
```
[tests/testthat/test_exarray.R:9:22:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L9) *style:* **Commas should always have a space after.**
```r
    expect_equal(c(2,3), dim(exprs(red)))
                     ^
```
[tests/testthat/test_exarray.R:10:53:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L10) *style:* **Put spaces around all infix operators.**
```r
    red <- eset_reduce(eset, rownames(m), gr, method="median")
                                                   ~^~
```
[tests/testthat/test_exarray.R:11:22:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L11) *style:* **Commas should always have a space after.**
```r
    expect_equal(c(2,3), dim(exprs(red)))
                     ^
```
[tests/testthat/test_exarray.R:12:53:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L12) *style:* **Put spaces around all infix operators.**
```r
    red <- eset_reduce(eset, rownames(m), gr, method="max")
                                                   ~^~
```
[tests/testthat/test_exarray.R:13:22:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L13) *style:* **Commas should always have a space after.**
```r
    expect_equal(c(2,3), dim(exprs(red)))
                     ^
```
[tests/testthat/test_exarray.R:14:47:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L14) *style:* **Commas should always have a space after.**
```r
    red <- eset_reduce(eset, rownames(m), c(1,1,1,2), method="median")
                                              ^
```
[tests/testthat/test_exarray.R:14:49:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L14) *style:* **Commas should always have a space after.**
```r
    red <- eset_reduce(eset, rownames(m), c(1,1,1,2), method="median")
                                                ^
```
[tests/testthat/test_exarray.R:14:51:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L14) *style:* **Commas should always have a space after.**
```r
    red <- eset_reduce(eset, rownames(m), c(1,1,1,2), method="median")
                                                  ^
```
[tests/testthat/test_exarray.R:14:61:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L14) *style:* **Put spaces around all infix operators.**
```r
    red <- eset_reduce(eset, rownames(m), c(1,1,1,2), method="median")
                                                           ~^~
```
[tests/testthat/test_exarray.R:15:22:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_exarray.R#L15) *style:* **Commas should always have a space after.**
```r
    expect_equal(c(2,3), dim(exprs(red)))
                     ^
```
[tests/testthat/test_ml.R:5:11:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_ml.R#L5) *style:* **Put spaces around all infix operators.**
```r
    y <- x*3 + rnorm(100)
         ~^~
```
[tests/testthat/test_ml.R:10:22:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_ml.R#L10) *style:* **Put spaces around all infix operators.**
```r
    expect_true(all(m>0))
                    ~^~
```
[tests/testthat/test_ml.R:14:24:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_ml.R#L14) *style:* **Put spaces around all infix operators.**
```r
    m <- matrix(1, nrow=20, ncol=20)
                      ~^~
```
[tests/testthat/test_ml.R:14:33:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_ml.R#L14) *style:* **Put spaces around all infix operators.**
```r
    m <- matrix(1, nrow=20, ncol=20)
                               ~^~
```
[tests/testthat/test_ml.R:17:16:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_ml.R#L17) *style:* **Put spaces around all infix operators.**
```r
    ecols <- 20*(20+1)/2
              ~^~
```
[tests/testthat/test_ml.R:17:17:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_ml.R#L17) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    ecols <- 20*(20+1)/2
                ^
```
[tests/testthat/test_ml.R:17:20:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_ml.R#L17) *style:* **Put spaces around all infix operators.**
```r
    ecols <- 20*(20+1)/2
                  ~^~
```
[tests/testthat/test_ml.R:17:23:](https://github.com/cdiener/proliferation/blob/65e2a6e3fcaf133fbca94c3244ecb79ba122ef82/tests/testthat/test_ml.R#L17) *style:* **Put spaces around all infix operators.**
```r
    ecols <- 20*(20+1)/2
                     ~^~
```


this


The `for/list` on line 37 is building a list (of voids and booleans).

The prev. version of the code returned `email` in each iteration of the loop and returned a list of email addresses we called `(mutt ... #:to email ...)` on.


Are these lines nessisary? Id prefer not to define user names in these files in case we change user names


playerid can't be changed, only the rest of the parameters can be.


There is an edit button at the end of the line. I think it appears just to the owner that why I can't edit it. Could you please edit it?