Visual Regression Testing found a difference between new version and the baseline.
Check the diffs [here](http://jenkins.wikia-prod:8080/job/design-system-reference-page-pr-check/525/).
Accept the new baseline [here](http://jenkins.wikia-prod:8080/job/design-system-reference-page-update-baseline/parambuild?branch=WW-329).


So is there a problem or not? All of the included project tests are passing.


Test scripts in Python used port 12022, do we need to change them to 2022? Or we are going to use different ConfD sessions?


Hi Elizabeth, this was a fantastic way to try and reach me, although I wasn't notified by the fork. If you try this approach in the future you should make a pull request and @ include the person to notify them.


Oddziel zmienne przecinkiem.

Zmienne, zawsze powinny być zadeklarowane słówkiem `var`
```
var a = 10;
var b = 20;
```
lub
```
var a = 10,
    b = 20;
```

Kiedy nie ma słówka var, to zawsze tworzona jest zmienna globalna, a to jest niebezpieczne :)


No. We can change C++ tests to use 12022


What?


Looks pretty good -- though, I think the effort should be put into removing TRSRC not the JIT_SRCBASE and JIT_OBJBASE :)


Hallo Albert, vielen Dank für den Hinweis. Das habe ich gleich eingebaut. Wie kommt es, dass du das hier gefunden hast? :) Viele Grüße, Hendrik


iteration (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2361 of 2448 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.45%25-yellow.svg)


LGTM


>Re: _repo_process_pkg_sls
>
>_failed_compile(msg) a good idea to save on repeated code.
>
>L717 Does not look correct, should not contain short_path_name, as you added for the log.error
>

You're correct, the idea here was to pre-build the log message since so much of it was similar, and then call str.format() on it once for the log file, once for the errors list. However, I didn't do this properly. Fixed in 83a5c19a.

>L734 the same looks like errors array has not been set a shorter message without short_path_name

Same, fixed in 07d88a0a.


Ah, that is very useful to know.  Thanks!  Feel free to stay in touch if you ever do find yourself looking to explore new opportunities. :)


If this is crashing, then it's very likely that the very first mixpanel track call is being bypassed (and possibly others), which would be pretty bad because that's how the flow is measured to start with. We probably need to lock/queue to avoid losing that call or the data will be confusing and possibly less useful


Input additional items as we progress in class.


...And a remember or cache table for toLO may be a good idea also.

On Wed, Sep 21, 2016 at 1:01 PM, Carl Love <carl.j.love@gmail.com> wrote:

> Sorry, but I'd need more guidance on that structured type. (I understand
> "structured type", but I don't know where to begin in this case.) As a
> stopgap compromise, I added a remember table to the type. Perhaps a cached
> remember table would be better. Also, I see now that LO(anything) was just
> plain wrong, and I changed it to specfunc(LO).
>
> On Wed, Sep 21, 2016 at 8:23 AM, Jacques Carette <notifications@github.com
> > wrote:
>
>> That's an amusing way to do it. But let's not do that -- please build a
>> proper 'structured type', which does not do any actual computation.
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/hakaru-dev/hakaru/commit/a9e11b68b4dee10cb9e1a519c78a89d919c3b9db#commitcomment-19112718>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/ASYo9YTDw1BdSSAJsbtqJUr64-njtJ3hks5qsSG-gaJpZM4KCvGb>
>> .
>>
>
>


iteration (evanweaver) - x86_64-MacOS-10.10-clang: OK (2378 of 2448 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.14%25-yellow.svg)


a FIFO queue for events would fix the problem, but we should check whether there's a way to have this initialize directly. It's weird that the initialization takes longer than a few msec no?


saw approval from JeetKunDoug
at https://github.com/basho/riak_kv/commit/05866ee3ce0d9d6c8c62742664da6955b9d88932


merging basho/riak_kv/feature-bjs-lager3.2.1 = 05866ee3 into borshop-integration-1484-feature-bjs-lager3.2.1


basho/riak_kv/feature-bjs-lager3.2.1 = 05866ee3 merged ok, testing candidate = 458fe0de


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1765 of 1765 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Good.


129956421-Scalable-Sizing-HTRad-Heat-Crash (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2374 of 2374 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


iteration (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


RE: get_repo_data, you're correct, this was me misreading the code as checking if the winrepo age was less ``< 1``, not ``== -1``. I had made a change elsewhere where we logged differently if the repo metadata was less than one second old, and I conflated the two.

Fixed in cc7f0d12.


@rburkey2005 or @jimlawton, what's the usual approach for transcribing symbols like the division symbols here? Replacing them with symbols of similar intent? (like / in this instance)


How about _"/dvdpos T#P\tStart playback at title T, position P (hh:mm:ss)"_?


We are simply saying that the behavior of that method has been modified.

When the directory is not present:
* old method: it created the expected directory "destination+strPath";
* new method: it creates only the directory "destination".

We've already understood what happened and corrected our codes creating the directory before invoking that method, while it wasn't needed before.

If the tests are passing, you probably haven't tested that case because you assumed the directory must exist before.

I can't say if it's a problem or not: you just have to decide which way that method should work and avoid changing it :-)


Just tested the example setup `http-proxy-middleware/examples/websocket` with 20 active connections without issues.

This issue is probably similar to #108

Would be great if you can create a minimal working setup with `express` or `connect` in which the issue is exposed. (http://stackoverflow.com/help/mcve)


Are the JSON fields also being sorted? E.g. medals_gold, medals_silver, medals_bronze and medals_total under each other in stead of spread within the reply or is that going to be another update / PR? :)


Sure

Cheers,
Russ Vane

> On Sep 21, 2016, at 2:23 PM, Duke <notifications@github.com> wrote:
>
> Lets see if I can accept this
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>


Oops! Our gresource prefix remained same. so it should be

```sh
		cp -t "${_DIR}" \
			"${GTKVER}/gtk.css" \
			"${GTKVER}/gtk-dark.css" \
			"${GTKVER}/gtk.gresource" \
			"${GTKVER}/thumbnail.png"

		cp -t "${_DIR}/dist" \
			"${GTKVER}/dist/gtk.css" \
			"${GTKVER}/dist/gtk-dark.css"
```

Now fixed. :/


Well, I could make it sorted, but I don't see why - it'd just add slightly more time to the request; they're just hashmaps anyway.


Images - Resize


129956421-Scalable-Sizing-HTRad-Heat-Crash (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Do you have local changes to `Garbo.jl` that you haven't pushed? [This line](https://github.com/kpamnany/Garbo.jl/blob/master/src/Garbo.jl#L99 only) only returns a single element so I get
```
ERROR: LoadError: BoundsError: attempt to access 1-element Array{Int64,1} at index [2]
```


`rfc` is only defined in line 194 so this line fails.


if [ "$(pgrep -c $(basename $0))" -gt 2 ]; then


Ignore this, we would have to get rid of this, I just didn't because It doesn't really belong to this refactoring


We probably need to make this change too for option-2


This addresses #36


Fixed in d1711b6


I don't see the point in sorting it. If you collect the data & parse it, you can just call whatever fields you want in whatever order anyways.


@cdysthe Now it should work on all DEs.


I'm testing a cleaned up version of this: https://github.com/chapel-lang/chapel/compare/master...ronawho:fix-privatization-races?expand=1

Like you suggested over mail I think we'll want to add some explicit runtime tests. I think we should have one  or more serial versions that calls with pids that we know will break this, and a parallel stress tests.

For the serial cases I'm thinking something like:

```chapel
// miss the init case
__primitive("chpl_newPrivatizedClass", <whatever>, 1);
```

```chapel
__primitive("chpl_newPrivatizedClass", <whatever>, 0);
// trigger too small of a reallocation
__primitive("chpl_newPrivatizedClass", <whatever>, 2048);
```

and theres's probably a couple of other less extreme variations of that, that we'll want to test.

I also think we can avoid leaking the old privatized arrays, but that'll be something for post-release.

The basic idea would be to do something like

```c
      ...
      tmp = chpl_mem_allocMany(chpl_capPrivateObjects, sizeof(void *),
                               CHPL_RT_MD_COMM_PRV_OBJ_ARRAY, 0, 0);
      tmp2  = chpl_privateObjects;
      chpl_memcpy((void*)tmp, (void*)chpl_privateObjects, (oldCap)*sizeof(void*));
      atomic_store(chpl_privateObjects, tmp);
      chpl_mem_free(tmp2);
      ...
    }
    extern void* chpl_getPrivatizedClass(int64_t i) {
      return atomic_load(chpl_privateObjects)[i];
    }

    // and we'd need a chpl_privatization_exit() to free on program teardown.
```


キー値をvniへ設定していますが、この後vniは使用していないようです。
`_`のほうがよいのではないのでしょうか？


测试合并代码！


you can compile it with theos.

2016-09-21 6:03 GMT+08:00 MarcusTwist <notifications@github.com>:

> Also really interested in this tweak but have no idea how to compile it,
> can it be installed using Cydia if it was compiled and added to a repo?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/xfunforx/XglyphiOS/commit/bdf58092799d32aa53a57f5fb44612ba11339a96#commitcomment-19104941>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ANVDrOjoB8TkiN7q5_BXwqY676GvHHJMks5qsFgvgaJpZM4KABDI>
> .
>


Pinging @samhatoum


And removed 'animation' argument from tree map function, as seems it doesn't work


New here but this line failed to compile, should the GYRO_LPF_256HZ just be set to 0 since the #defines were removed?


I build for dior(xiaomi red mi note LTE), also msm 8x26, the camera can't connect…


LMAO


`%%d3` cell input is a mixture of HTML and JavaScript code, so I can't shoehorn it all into a JavaScript block.

Setting `window.d3` = `d3` got it running on my machine (TM).

Try running the block multiple times. The `%%d3` cell will rarely work the first time you run it, but *should* work on the second.


PS @2ion I asked for your opinion on this back in August: https://github.com/BunsenLabs/bunsen-utilities/commit/db28c2346bb107b20e9a6a56ae2874265dfe7997#commitcomment-18666762
I took your silence as assent...


@gblmarquez I guess this is a mistake? A function inside another... :/


ASIHP-validation1 (shenb) - Win64-Windows-7-VisualStudio-12: OK (2338 of 2339 tests passed, 1 test warnings)

 * 2 tests had: EIO diffs.
 * 1 test had: ESO small diffs.
 * 1 test had: ERR diffs.
 * 1 test had: ESO big diffs.
 * 1 test had: SSZ small diffs.
 * 1 test had: ZSZ small diffs.
 * 1 test had: Table big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.96%25-yellow.svg)


Your IDE is doing something to the code that it removes and messes with the tabs...


이거 동기로 처리되는거죠?


Will fix #1


I've been told that 15 is the brightness of sunlight. Is there a reason this can't be used by mods?


Right right. I'm referring to the stuff below (the script block starting with `_select = d3.select`)

`window.d3` should be fine for most purposes since d3 should be loaded by that time.


I haven't seen any lighting issues before from mods using a light_source of 15 (or the completely-invalid 30, like blox did for some reason). Is there an issue report here somewhere for it?


I don't see the harm in making the change, but I'm unsure that that would fix the issue---as in, I don't see what difference it would make (between using the `d3` local context in the callback and the `d3` global outside of it).

Are you sure that your import error stems from the block being outside of the callback?


`win_dex` beautiful variable name! :+1:


@gblmarquez This should be changed in the client-php repository, not in the nfe-woo one.


Lol, thx I thought so too.

On Tue, Sep 20, 2016, 21:18 Mason Elmore <notifications@github.com> wrote:

> win_dex beautiful variable name! 👍
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/ShivonQ/Solo-Unittest-Dice-Poker/commit/108cab1a22cf090b233fca748ea5cb8d03ec2548#commitcomment-19107186>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AJbeauGkg0NxL67KM25_U4nZMd0ReMgeks5qsJPsgaJpZM4KCVTb>
> .
>


Actually, all updates in this commit was made in the wrong place. :/


@xyting use ValidateAttribute or FluentValidate will better?


The cell code seems to run without it (minus the first-run hiccup), but my point is that your code below (lines 66 - 75) isn't getting run because `<script>` tags are synchronous.

d3 isn't on the page by the time the script block gets executed. Previously when you loaded d3 through a script tag the browser blocked before running the rest of the page. Now that you're loading d3 though AMD that code block won't work.


This is a great idea; makes billing a lot easier!!


Would love to have this working. Seems like there needs to be a mock window object for angular

`20160920-19:24:29.338(-7)? (STDERR) ReferenceError: window is not defined
W20160920-19:24:29.338(-7)? (STDERR)     at meteorInstall.node_modules.angular-mocks.angular-mocks.js (node_modules/angular-mocks/angular-mocks.js:3126:1)
W20160920-19:24:29.338(-7)? (STDERR)     at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:153:1)
W20160920-19:24:29.338(-7)? (STDERR)     at Module.require (packages/modules-runtime/.npm/package/node_modules/install/install.js:82:1)
W20160920-19:24:29.338(-7)? (STDERR)     at Module.Mp.import (/Users/ddoyon/.meteor/packages/modules/.0.7.6.1rr9fy6++os+web.browser+web.cordova/npm/node_modules/reify/lib/runtime.js:70:16)
W20160920-19:24:29.338(-7)? (STDERR)     at meteorInstall.imports.components.todosList.todosList.tests.js (/private/var/folders/ys/6q664rj90zd0h_mvfh6kq2kc0000gp/T/meteor-test-runymw7hs/.meteor/local/build/programs/server/app/app.js:9:14)
W20160920-19:24:29.339(-7)? (STDERR)     at fileEvaluate (packages/modules-runtime/.npm/package/node_modules/install/install.js:153:1)
W20160920-19:24:29.339(-7)? (STDERR)     at require (packages/modules-runtime/.npm/package/node_modules/install/install.js:82:1)
W20160920-19:24:29.339(-7)? (STDERR)     at /private/var/folders/ys/6q664rj90zd0h_mvfh6kq2kc0000gp/T/meteor-test-runymw7hs/.meteor/local/build/programs/server/app/app.js:189:1
W20160920-19:24:29.339(-7)? (STDERR)     at /private/var/folders/ys/6q664rj90zd0h_mvfh6kq2kc0000gp/T/meteor-test-runymw7hs/.meteor/local/build/programs/server/boot.js:292:10
W20160920-19:24:29.340(-7)? (STDERR)     at Array.forEach (native)
=> Exited with code: 1
W20160920-19:24:34.185(-7)? (STDERR) /Users/ddoyon/.meteor/packages/meteor-tool/.1.4.1_1.1h0re2h++os.osx.x86_64+web.browser+web.cordova/mt-os.osx.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:280`


"we're busy", says the guy whose committed code broke a bunch of mods.  Seriously?


Why you did this change?


So, 8.3 doesn't need this any more?


为什么在客户端无法编辑使用，再看看


This sends many, many notifications. The downgrade timer may drop a few ticks from time to time when creeps are still hauling energy to it. Also it will send a warning at 9999, 9998, 9997, etc. Luckily I [specified](http://support.screeps.com/hc/en-us/articles/203016382-Game#notify) that these notifications should send as a batch every 15 minutes.


We're still pre-0.1 and every release has minor breaking changes. That's part of why I wanted to ping the people I know are actually starting to use the code here. I think it's almost done with breaking changes though, so I think we're just about ready for 0.1.


It just occurred to me while tinkering with this, if the `pdata` argument had come first, then one could use member functions directly in the `GeanyPluginFuncs` setup without the need for separate C wrapper boilerplate. It would probably require typedefs for the function pointer types to facilitate type casts. A basic wrapper plugin over a GObject could've looked like this:

```vala
// some gobject in vala, to save typing
namespace Foo {
  public class Plugin {
    bool init(Geany.Plugin p) { return true; }
    void cleanup(Geany.Plugin p) {}
  }
}
```

```c
// the actual plugin implementation
G_MODULE_EXPORT void
geany_load_module (GeanyPlugin *p)
{
  p->info->name = "Foo";
  ...
  p->funcs->init = (GeanyInitFunc) foo_plugin_init;
  p->funcs->cleanup = (GeanyCleanupFunc) foo_plugin_cleanup;
  ...
  GEANY_PLUGIN_REGISTER_FULL (p, 42, foo_plugin_new, g_object_unref);
}
```

I don't know if it can be changed now or some alternative funcs with swapped arguments added, I just thought I'd mention it as I just coded 4 hook functions to do nothing but reverse the arguments to call another C function.


I was at RCL 2 and expecting an upgrade to RCL 3 while I was sleeping. The downgrade timer starts at 10k at level 3, up from 5k at level 2.


merge from master to my repository


I was getting an email every 15 minutes with a lot of notifications, now it should only send one each time the downgrade timer drops below the threshold.


Never use this script


Is there any way to override this heuristic when doing manual placement? IE, I got counter-intuitive results in [this issue](https://github.com/tensorflow/tensorflow/issues/4498#issuecomment-248483967) where a constant node got placed on worker1 even though it was inside "with tf.device(worker2):" block


ご指摘ありがとうございます。分かっていたんですが手を抜いてしまいました。。。
CFで変数渡し出来る様にするとご指摘の通りポータビリティが良くなると思います。


ROM code detection added (by checking CID)


Can I use in "click me"?


groupInterval parameter omitted, should be sent immediately? My account send interval is set to 5 minutes, that may affect this.


I unthinkingly just copy-pasted the code over, forgetting that I need to export the selection global as well. Had to roll it back. Measure twice, cut once.

Have to do something else right now. Will try to get back to this soon, but maybe you'd to pull request it yourself?


See https://github.com/minetest/minetest/issues/3964#issuecomment-246115736
When removing the node infinitely propagating light is created, i don't yet know of a way to fix it, maybe a mod using a voxelmanip to reset lighting.

> whose committed code broke a bunch of mods

What code broke what mods? We solved a widespread and serious bug and added notification to avoid it, there are many other situations where node definition errors will halt the game, it's not unusual.
We are indeed busy and a simple PR could be done by a contributor.


N_LOCKTIMEVERIFY refers to the nLockTime field right?

How would this be a soft fork? Adding a new field to transactions would be a hard fork. Adding a new script opcode could work but isn't the pubkey script generally only checked when spending an input not when checking if a transaction is valid in other terms.


Can I use in prevent repeat click in the link?


ReplaceEPLaunchLite (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1767 of 1767 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.14%25-green.svg)


I should mention for the specific case of Vala, I think you can write something like this:

```vala
// some gobject in vala, to save typing
namespace Foo {
  public class Plugin : Object {
    [CCode(instance_pos=1.1)]
    bool init(Geany.Plugin p) { return true; }
    [CCode(instance_pos=1.1)]
    void cleanup(Geany.Plugin p) {}
  }
}
```

It might work directly in this case.


そうですね。
vni は使って無いので、下記のように修正しました。
`for network in self.networks.values():`

`_` で消しこむよりは、「最初から取らない」というようなイメージです。


ReplaceEPLaunchLite (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


GetInternalVariableBug (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2373 of 2373 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Fixed.


Keeps updating when not in foreground on mobile.


Lisa gives 18k EXP, not 180k


If a mod works before the commit, and fails after, and nothing functional about the mod has actually changed, then by definition the engine broke the mod.  If there are "hundreds" of bad uses of lighting values existed, then that alone was sufficient reason not to throw an error.


GetInternalVariableBug (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


MoreDayliteFollowup (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (2330 of 2338 tests passed, 26 test warnings)

 * 5 tests had: EIO diffs.
 * 1 test had: ESO small diffs.
 * 32 tests had: AUD diffs.
 * 15 tests had: Table small diffs.
 * 8 tests had: Table big diffs.
 * 3 tests had: RDD diffs.
 * 1 test had: ERR diffs.
 * 1 test had: ESO big diffs.
 * 1 test had: SSZ small diffs.
 * 1 test had: ZSZ small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.66%25-yellow.svg)


updating changes to master's base


I was calculating ticksSinceLastAccident every tick anyway, why not just keep that in Memory instead and increment it each tick?


hi test


Sorry for the spam, but a related idea (so I can find it later). We could have a macro like this:

```c
#define GEANY_PLUGIN_REGISTER_OBJECT(plugin, min_api, gtype, ...)  \
  GEANY_PLUGIN_REGISTER_FULL (plugin,                              \
                              min_api,                             \
                              g_object_new (gtype, ##__VA_ARGS__), \
                              g_object_unref)
```

To provide syntax sugar to bind a GObject to the module's lifetime.


I could have removed the first part of this conditional by changing the 0 to 1 when resetting `Memory.ticksSinceLastAccident` on [line 48](https://github.com/sethten/screeps/commit/51e030abd0e488c0cdbc228c078e219a7ebddffb#diff-7a9076d6d94e62c13d641aa71f19ae8eR48), but I think this is more clear.


I could have just executed the body of this conditional regardless, but this more clearly expresses the intent of this code block.


hi test2


a) `#!/bin/bash`, `/usr/bin/env python` as shebang will do the right thing.
b) I don't see how this helps editing scripts? `vim foo` (perhaps double-click in a GUI).
c) Yes I didn't follow all those small changes to this repository. In fact, I've lost track of merlin vs deuterium a while ago.


I accidently wrote that I committed the shell script to start a PHP server, but I actually didn't.


Should always notify "Room controller at level 3 has a downgrade timer at 9000" with the constants set as they are


Only works for RCL 3


with latest master, "make fmu"  and "make pos" auto-complete properly, but
"make posix_sitl_default " shows no autocomplete options

On Tue, Sep 20, 2016 at 6:26 PM Carlo Wood <notifications@github.com> wrote:

> Has this been fixed by #5491 <https://github.com/PX4/Firmware/pull/5491>
> or are there still issues left?
> Thanks. Sorry for the late reaction here, I missed the comments here until
> I (finally!) read my email again :/
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/PX4/Firmware/commit/900026818b772ef848749e366b722817b3fc6fc4#commitcomment-19106405>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACMZPUFieI_OJMyPxr0jkBBWTKqUgWBQks5qsHm0gaJpZM4J-w0Z>
> .
>


개쩐다


님제발


Это не верно. Что бы получпть currentUser в контроллере нужно сделать инджект сессии
```coffescript
sesstion: Ember.inject.service()
```


The heuristic only applies if there are no devices already assigned to the node by the client, so I suspect the problem you're having is elsewhere


merge


dd


Cool, glad to have helped.


Визиты должны сохраняться отдельно а не как вложенные документы вместе с сохранением недвижимости


I'm still working on this, but I wasn't sure how to make a list of undefined amount of lists, so I just used dict for now. Might need to figure that out.


It doesn't install npm. It runs `npm install` which gets all the script deps.

This PR installs nodejs (which has npm in the dependencies): https://github.com/PokemonGoMap/PokemonGo-Map/pull/1217


Right... I think I ended up using char_since_space instead...


`@languages ||= if ...`


good point..


Wait.. so... forexample, if we have 10 lines, and the limit is 4, we just display lines 7, 8, 9, 10??


nightly is 0.6-dev, should add an `- 0.5` line here to test against 0.5 releases


I want to save the stats (seperated) locally in JSON format (to be able to build a history), and decode when needed for example for the views.


Could work too I guess.  Good idea.


Refactor textImage generation


Good catch, thanks.


@jovo [Here's the html](http://docs.neurodata.io/synaptome-stats/Code/Discrimination.html)


Is that hunk related to $SUBJECT ?


hello i downloaded the thenaughtyandthenice.com-master script but in the admin interface gives me error I ptreste help to install thanks
  the link of the admin and site: http://www.karimachat.com/admin/settings


Thanks for letting me know 😄 I'll update accordingly when I get the chance


What is the change for? Without the change the subtask creation is OK. With the change
1) when I change "Parent task" to another issue using issue-ID (e.g. MYPROJECT-123) and select it from the dropbox, the issue-ID is substituded by usual ID.
2) the same in "Related issues" "Issue #" field.

IMHO the change in this file should be reverted.

The addition in lib/issue_ids_controller_patch.rb is fix #2 indeed and I'm ready to accept it.


There's no such thing as a division symbol.  Program labels and variable names in AGC language can contain any character whatsoever.  "1/2JETSV" is the actual variable name.  It is left exactly as-is.


You should be able to anyways?
Pseudocode example in python:
```python
for hero in dict['us']['heroes']['stats']['quickplay']:
  hero['general_stats']['medals_gold']
  hero['general_stats']['medals_silver']
```
etc.


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/3960


Looks like a typo here.


I'm sure you knew that it was part of the label, but others who might read this might not.


To samo co w poprzednim zadaniu.
Zadeklaruj zmienne, aby miały `var` lub po przecinku.


Ah. I understood that. However, there's a division symbol in the comment at the end of the line.


Enables updates for windows xp until 2019


typo, should be `config`


Change is good


Let's give a full link here.


Perse


OK. Tnx.

2016-09-21 19:13 GMT+02:00 Arne Coucheron <notifications@github.com>:

> Yes, this just changes the initial default value to 3G. You can still
> manually change it to LTE.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/CyanogenMod/android_device_samsung_serranoltexx/commit/66ecc719ace9b37ae94cbcc77a99242cfe855ad0#commitcomment-19117170>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AHbIIst-lBtoJJHHq2iCXenSEY8e2EnLks5qsWWfgaJpZM4KCcoY>
> .
>


Zmień kolejność tasków i będzie działać.

'sass','imagemin','browserSync','watch'
https://www.browsersync.io/docs/grunt#grunt-watch


so dev mode changed the api huh? well, the "exception" variable is getting popular, especially in java...


Tv


zmień na images/build
a poza tym usuń folder build u siebie na komputerze

jak wpiszesz git status to powinno być `deleted: images/build`
zrób commit z tymi zmianami i potem będzie jak trzeba


>If population of __opts__['abc'] will always exist and is check that it is an int, then it makes sense to remove the checking. If it does do this, it would be nice if population of __opts__ also had file and dir type to check they are valid for the target platform, then more code could be removed.

L425 refresh = Logic Change to just force vs
(force and (expired_min == 0 or repo_age_sec < expired_min))
expired_min is their because a refresh is a very expensive operation, and some of the code forces a refresh. expired_min this give the user a option to increase performance of their runs by ignoring the force=True. If I had a large number of sls files I would be setting min to 10 minutes, but it needs to default to 0 so it acts like old versions. Call pkg.refresh_db still allows the refresh to happen for users who choose to use expire_min, while debugging sls files. With expired_min set running a state twice in a row would be a lot quicker, or someone who ran one state followed by another separate state.

Are you referring to this (from the original code)?

```python
try:
    expired_min = int(__opts__['winrepo_cache_expire_min'])
except ValueError:
    pass
```

Firstly, since you added default values for these in c0798c1, we can guarantee that they will be populated in the opts dict, because the values in ``DEFAULT_MINION_OPTS`` populate the ``__opts__`` dict when the minion config file is read. With respect to us not enforcing that the type is an integer, the minion will not do that when it starts, but it will log a warning/error in the minion log saying that the types don't match. I didn't want to silently fall back (like the original code did), so I guess the question becomes this: do we want to fallback with an error in the log, or raise an exception and abort the refresh. @UtahDave @damon-atkins what do you think?

>L430 Logic change on debug message which was to indicate an possible issue with the code or use. Change to log more often but not indicate an issue. I was trying to not over log, but point out a possible issue at the same time. Some respects the 60 sec was a bit small, as a typical install would take over a minute. I don't mind either way. And also original I was not going to fix state/pkg.py forcing a refresh all the time, as I was trying it as it effects more than one platform. Since I have fixed state/pkg.py it also reduces the need to point out the issue.

My updating logging displays the age of the file no matter what, so I considered it a compromise. Are you satisfied with it?

>L444 - L448 No return True if the refresh_db worked without errors. Come from a background of believing all functions should return something. Also makes it easier to write tests.

```python
results = refresh_db(saltenv=saltenv, verbose=False, failhard=failhard)
try:
    return not bool(results.get('failed', 0))
except AttributeError:
    return False
```

No, it is returning ``True`` if there were no errors. It's returning ``not bool(results.get('failed', 0))``. If ``failed == 1``, then there was 1 failure, and ``not bool(1)`` is ``False``. No errors mean ``not bool(0)``, which is ``True``. I'll admit this usage is probably too clever and could use some logging to clarify it.


[tests/testthat/test_convert_to_otu_table.R:21:22:](https://github.com/seninp-bioinfo/MetaComp/blob/5599125302272d8fa7534e7dbcf6f7def2eec730/tests/testthat/test_convert_to_otu_table.R#L21) *style:* **Commas should always have a space after.**
```r
expect_that(sum(dat[,1]), equals(1.0))
                     ^
```
[tests/testthat/test_convert_to_otu_table.R:26:2:](https://github.com/seninp-bioinfo/MetaComp/blob/5599125302272d8fa7534e7dbcf6f7def2eec730/tests/testthat/test_convert_to_otu_table.R#L26) *style:* **Commented code should be removed.**
```r
#expect_that(convert_merge_table_to_phyloseq_otu_table("../test_data/nonexistantfile.txt", "class"), throws_error())
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_convert_to_otu_table.R:27:1:](https://github.com/seninp-bioinfo/MetaComp/blob/5599125302272d8fa7534e7dbcf6f7def2eec730/tests/testthat/test_convert_to_otu_table.R#L27) *style:* **lines should not be more than 100 characters.**
```r
expect_that(convert_to_otu_table("../test_data/merged_table.tsv", "non_existent_taxa_level"), throws_error())
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


This is  a test repository


I think it could have been done in Component class, using lombok @Delegates and with more methods from FluentControl.


SQL


This is a test README


This should go in Hive changes


129956421-Scalable-Sizing-HTRad-Heat-Crash (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1194 of 1194 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-36.12%25-green.svg)


This fixes #13


Just copying your code over here so I can format it and give you some comments.
```javascript
var answerSeven = prompt('What came first the ------- or the ---?').toLowerCase();
var saidArray = ['chicken','egg','rhinocerous'];

if (saidArray.indexOf(answerSeven) === -1) {
  alert('I didn\'t necessarily expect you to get this' );
} else {
  alert('stop reading my mind');
}

var myNumber = 9;

do {
  console.log(myNumber);
  var answerEight = prompt('Pick a number 1 through 10');

  if (answerEight < myNumber) {
    alert('too low');
  } else if (answerEight > myNumber) {
    alert('too high');
  } else {
    alert('got em coach');
  }
} while (answerEight != myNumber);
```


removed. Any player can .start the game now (previous commit) using '.start'


Rotation was added in v1.0.23 when I was working against 17 alpha 1.

See:

* 17alpha1 changes: https://github.com/garbear/xbmc/commits/retroplayer-17alpha1/xbmc/addons/kodi-addon-dev-kit/include/kodi/kodi_game_types.h
* 17alpha2 changes: https://github.com/garbear/xbmc/commits/retroplayer-17alpha2/xbmc/addons/kodi-addon-dev-kit/include/kodi/kodi_game_types.h

if it's missing for you, then you weren't rebased on an actual development branch


The line that defined `string_or_regex` above was deleted


Overall looks good!


COMMENT PRAISING YOU FIR YOUR WORK


BO: Add next/previous page link


cc @andrenpaes


Oops!  Couldn't see that for looking!  My apologies.  My opinion would be that if there's no actual ASCII equivalent, it probably should be changed for intent as was suggested, and / is the obvious choice.  And then I personally would add a second comment (say, above it), with my initials, the date, and in upper/lower case -- something that makes it clear that the new comment is itself new -- explaining what had happened.  That's to keep somebody else from coming along later and fixing it the opposite way.


or even replace this by a link to the wiki-page.
So there is only one place to change and the location is always up-to-date (independent from Firmware-release)


is mac not worth testing?


I don't do anything OS specific in my tests -- I only test pure Julia bits.

I think the only benefit would be to see if my dependencies install on OS X also. Ultimately that burden should be on the other packages.

Do people usually keep it on even if the code they are testing isn't platform specific?


Just pushed another commit.


gem 'annotate' должно быть в дев секции гемфайла.


Why does the probability calculation for RTS include a binom.pdf, but none of the others do?


This is applicable in the tests too. When you create the certs, you are creating them in the wrong project. It isnt the GCE_PROJECT (which is the project spinnaker is in) but the project your deploying the resources into.


There's "should be" platform independent vs what actually happens. And your tests probably exercise somewhat different coverage of your dependencies than those dependencies' own tests, though that can often be improved by adding tests to them. If you're not annoyed by the queue, I'd usually leave it on.


Ok cool.

I don't push here quite enough for the queue to bother me that much. I'll flip it back on.


Seems to be the case - I screwed up somehow getting a v25 with half roation.
Thx for the help.

Garrett Brown <notifications@github.com> schrieb am Mi., 21. Sep. 2016 um
22:26 Uhr:

> Rotation was added in v1.0.23 when I was working against 17 alpha 1.
>
> See:
>
>    - 17alpha1 changes:
>    https://github.com/garbear/xbmc/commits/retroplayer-17alpha1/xbmc/addons/kodi-addon-dev-kit/include/kodi/kodi_game_types.h
>    - 17alpha2 changes:
>    https://github.com/garbear/xbmc/commits/retroplayer-17alpha2/xbmc/addons/kodi-addon-dev-kit/include/kodi/kodi_game_types.h
>
> if it's missing for you, then you weren't rebased on an actual development
> branch
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/kodi-game/game.libretro/commit/b9603eb1e3eb98ca917280ea23ad3ec13f1c9e6a#commitcomment-19120113>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AE5zCTYpeecDLApZ7HznykyVSsA-K47Iks5qsZL1gaJpZM4KC7Cd>
> .
>


update_standards_gem (asparke2) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2362 of 2448 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.49%25-yellow.svg)


Can you use UUIDs instead, @taion? Those wouldn't conflict.


fast-forwarding develop-2.2 to borshop-integration-1484-feature-bjs-lager3.2.1 = 458fe0de


This section should be named semantically


Ugh. Let me re-test before you waste more time.


this makes a synonym for the fwd() function. Much easier to explain to kids


Actually this combined with the other timing fix from commit 2843b4c fixes golden 5 and now works properly.


@lots0logs Adding code: `menu { -gtk-image-effect: none; }` ?
https://github.com/shimmerproject/Greybird/blob/master/gtk-3.0/_xfce.scss#L50


You need the ``serialize`` branch of Garbo.jl.


same thing here, create a synonym for the bwd() function


113836013-Swimming-Pool-Evaporation-and-Cover-Issues (RKStrand) - x86_64-MacOS-10.9-clang: OK (2330 of 2334 tests passed, 8 test warnings)

 * 7 tests had: EIO diffs.
 * 8 tests had: ESO small diffs.
 * 4 tests had: ESO big diffs.
 * 1 test had: AUD diffs.
 * 1 test had: MTD diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: RDD diffs.
 * 2 tests had: Table big diffs.
 * 1 test had: ERR diffs.
 * 1 test had: SSZ small diffs.
 * 1 test had: ZSZ small diffs.
 * 2 tests had: MTR small diffs.
 * 1 test had: Table small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg)


Это третий этап: запуск или загрузка


`Typescript` should be `TypeScript`: https://github.com/Unibeautify/unibeautify/blob/master/src/languages.ts#L669


turn_right() and turn_left() allow for an easy way to tell the GoPiGo to turn 90 degrees (or 45, or...)
Code migrated from GoPiGoScratch.py


Change to `TypeScript`: https://github.com/Unibeautify/unibeautify/blob/master/src/languages.ts#L669


А это четвертый этап: выполнение


Sweet! So it just worked out of the box?


Updated my example to "ask" the simulator for the maximum range. A simple testbench going a bit too complex... At least we raised the question on C interfaces. I'm also in favor of not going there, it's important that our test suites can be executed by anyone. These interfaces also brings complexity which we should avoid if we can (I know I failed miserably with that)


That will fit perfectly on my GPU code, I'm using active_pwrlevel as 200MHz and getting a bit UI lag with some heavy launchers. Bumping it to default 320MHz will solve that ;)


I don't see any reason for you to include the changelogs or YML


Actually resolves Wurst-Imperium/Wurst-Client-Bugs#136


Это точный код оригинала, но лучше его немного адаптировать под нашу текущую программу. Сейчас нет разделения на две отдельных функции и нет входных параметров.


The change looks good to me.


This is fantastic as an enumeration as it describes the measuring stick by which we should measure the success of the solution.


update_standards_gem (asparke2) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Нормально.


keep your quotation marks consistent as either single or double quotes


Несовсем так, можно называться 1С:АвтоАджайлер пройдя процудура 1С совместимо.
А 1С-АвтоАджайлер это уже Совместный продукт.


Right, this can be removed from any buildout config that uses zc.buildout 2.x.


Reduce this time, notif stay too long


There are 2 ways to calculate the probability of percentage equal to or greater than the boundary.
The first one is 1 - binomial.cdf(boundary) + binomial.pdf(boundary).
The second one is 1 - binomial.cdf(boundary - 1)
These two methods get same results.
I used the latter to calculate RTS and the former to calculate others.
On 周三, 9月 21, 2016 at 1:33 下午, tmaurer13 <notifications@github.com> wrote:
Why does the probability calculation for RTS include a binom.pdf, but none of the others do?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub [https://github.com/sudatta0993/STAT_215_Project_1/commit/2c945cdc9e0db59f600b4f7d5afc7bcdc15b7960#commitcomment-19120235] , or mute the thread [https://github.com/notifications/unsubscribe-auth/AS5Rvdn41LuxPzPrBi-ag-2HeH96relZks5qsZSqgaJpZM4KDP0W] .


Chia


Sorry. Wrong link. I am on the `serialize` branch and the line seems to be the same
https://github.com/kpamnany/Garbo.jl/blob/serialize/src/Garray.jl#L75


Add orderby pipe


@olivierchatry could you give master a try?


I feel like this might be missing discussion of two types of configuration:

- Pull configuration: configuration which the engine directly queries its parent (app, addon, engine) or host.
- Push configuration: configuration which the engine receives from its parent.

Push config that crosses two levels maybe should be "reexported". Host => addon 1 => addon 2, addon 1 is responsible for configuring addon 2, host for addon 1 only? Unsure. This approach is valuable but also conflicts with your other goal:

>  It should NOT allow conflicting addon configurations within a single container.


ok, works for me


Latest update is causing errors vs version 4.39.1.  Specifically, sonar settings now being flagged as errors:

This setting is not valid the "end" phase in this version of the C# plugin: sonar.log.level
This setting is not valid the "end" phase in this version of the C# plugin: sonar.verbose
This setting is not valid the "end" phase in this version of the C# plugin: sonar.branch
This setting is not valid the "end" phase in this version of the C# plugin: sonar.cs.xunit.reportsPaths
This setting is not valid the "end" phase in this version of the C# plugin: sonar.opencover.reportsPaths

This happens when calling SonarQube end.  Will open an issue and will note the issue number...


We are currently generating random dummy `clientMutationId` values to make our `RANGE_ADD` subscription updates work: https://github.com/edvinerikson/relay-subscriptions/blob/v1.0.0/src/updateStoreData.js#L20-L28. Otherwise we're sending `clientSubscriptionId` though. Does that sound right?


Ok, zmieniłam
Ale dlaczego musiałam usunąć folder build z komputera?
I na czym dokładnie polega działanie browserSync? powinna mi się aktualizować na bieżąco strona w przeglądarce? bo jak wpisuję zmiany w kodzie w edytorze, to nie widzę, żeby ze stroną coś się działo


Nope, slipped through by accident. But it doesn't matter, we have no cpufreq scaling with mainline kernel on A64 now but changing default governor to `schedutil` with 4.7 or above is the way to go since `ondemand` is considered being broken anyway.


На этом уровне лучше отставить оператор if как есть пока что. И внутри его веток делать присваивание значения переменной result.


Thanks for the tip! I'll definitely take a look at that and see what I can incorporate into this project.


@enlight3d The temperature module is implemented here as a first draft. Added cleaned-up example of what you sent me as example and added you to CONTRIBUTORS.md thanks to your help.

I have, however, not tested this module with real hardware yet since I apparently misplaced my BL dongle somewhere. I will test it tomorrow and make some bugfixes then if needed.


@alexBLR pretty sure we don't want the `nargs` option here.  I think we only want the user to specify one file, not zero or more, right?


this is going from the new style (what Pkg.generate creates) to an older style that we only used for a little while, it's better to have the way it was


I see now - the stsci-hst is a metapackage being used to get at stsci.tools here by installing something that pulls it automatically.  I went around this and am just installing stsci.tools from git master and added astroconda as a channel to the conda build to grab hstcal. seems to work now.


Maybe worth revising the error message to make this clearer? (specify ids or a file?)


#2520943-WindowsCalc-Engine_Integration (vidanovic) - x86_64-MacOS-10.9-clang: Tests Failed (1763 of 2333 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-75.57%25-red.svg)


I got these errors from worker.py:

['/Users/stephane/Programmation/fishtest-master/worker/testing/cutechess-cli', '-repeat', '-rounds', '6', '-tournament', 'gauntlet', '-srand', '3751392933', '-resign', 'movecount=3', 'score=400', '-draw', 'movenumber=34', 'movecount=8', 'score=20', '-concurrency', '3', '-openings', u'file=2moves_v1.pgn', u'format=pgn', 'order=random', 'plies=16', '-engine', 'name=stockfish', 'cmd=stockfish', u'option.Hash=8', u'option.Center=7', u'option.InnerMid=6', u'option.InnerLong=-6', u'option.OuterMid=-7', u'option.Outer=7', u'option.OuterLong=-7', u'option.MidEdge=7', u'option.NearEdge=-6', u'option.FarEdge=7', u'option.Corner=-7', '-engine', 'name=base', 'cmd=base', u'option.Hash=8', u'option.Center=-7', u'option.InnerMid=-7', u'option.InnerLong=7', u'option.OuterMid=6', u'option.Outer=-7', u'option.OuterLong=7', u'option.MidEdge=-7', u'option.NearEdge=7', u'option.FarEdge=-6', u'option.Corner=7', '-each', 'proto=uci', 'tc=22.02+0.22', 'option.Threads=1']
('TC limit', 220.23930376850095, 'End time:', datetime.datetime(2016, 9, 21, 22, 50, 40, 221031))
Indexing opening suite...
stockfish doesn't have option Center
stockfish doesn't have option Corner
stockfish doesn't have option FarEdge
stockfish doesn't have option InnerLong
stockfish doesn't have option InnerMid
stockfish doesn't have option MidEdge
stockfish doesn't have option NearEdge
stockfish doesn't have option Outer
stockfish doesn't have option OuterLong
stockfish doesn't have option OuterMid
base doesn't have option Center
base doesn't have option Corner
base doesn't have option FarEdge
base doesn't have option InnerLong
base doesn't have option InnerMid
base doesn't have option MidEdge
base doesn't have option NearEdge
base doesn't have option Outer
base doesn't have option OuterLong
base doesn't have option OuterMid


---
layout: narrative
title: Act 343
author: unknown scribe
source: Soissons, Bibliothèque municipale, MS 7
---


This sort of dynamic injection is something that I would like to get away from:

```
export default Ember.Component.extend({
   value: inject.config('my-app.environment.value')
});
```

Ergonomics of this approach though is fantastic. I'm unconvinced about the microsyntax you've proposed here; if doing this I want it to be a module name to address plus an actual value.

I'd generally like to constrain that it may not be _truly_ dynamic.


I think it makes more sense to do this in the `get_options` method, and error if there's a problem loading the file or getting the ids.  That way `process_items` can just assume everything is good and there are items to process.


We actually had a question before whether this case was still necessary? Are we still supporting any platforms where this is necessary?


That is because the previous version forced to pass parameters to the end call, even if they were not used.
The only parameter used in the end call is `sonar.login`, you should remove the others.
Or use `SonarqubeEnd()` if you haven't the use of `sonar.login`.


I think there are more efficient ways to read a file into a list.  Some good answers on this stack overflow question: http://stackoverflow.com/questions/3277503/how-to-read-a-file-line-by-line-into-a-list-with-python


this doesn't test 0.5 quite yet, but will soon - I need to go submit a PR to Travis and a bunch of PR's to packages


> As children should have no knowledge of there parent

```diff
+ their
- there
```


> addons instantiated within this container from accessing the Host's configuration without knowing its name.

`this.parent.name` or `this._findHost().name` is an escape valve.


Just updated it (twice more), better?


Hi tobozo,

with this memory footprint I was thinking it would be possible to reproduce some of the classic Tetris sounds for in game play, along with the music at startup.

I'm really not sure how to go about it though.

Its a cool sequencer, thanks for sharing.


This z-index is hiding the toolbars when the ring overlay is shown. @m-voloshin Do we actually need this z-index and why?


Nice job man! Well done,


develop (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2403 of 2448 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.16%25-yellow.svg)


I like the unintentional proposal of a `configs` collection.


Thank you @snicolet, this is strange since the bench reported all those options as usual with the csv to put into the test... I'm now trying to understand!


These look really good! They seem to cover all the cases we discussed. Do they all pass?


Heh, please hang on. I'm currently cleaning up Garbo and Garbo.jl so things are in flux.


Oops, thanks!


Fix  #8


new line here


I believe that this code may be in error. I've been experiencing an issue lately where my calibrated needle model flips inappropriately. I just ran the debugger, and found that I have the following two transforms being used for the dot product here:

[30.046057288537074, 81.866301200484003, -3.1759702391088886]
[0, 0, -1]

Which results in a value > 1 and triggers the flipping case. However, the needle is already in the correct orientation and should not be flipped. This actually inverts the shaft to the opposite direction of what it should be.

What is the intuition behind this code? I am afraid I do not understand what is being computed here or why.


yeah, aside from maybe the version numbers (which get populated whenever you first run Pkg.generate and may not be accurate forever) the default generated template should be good for most purposes


So far they're all ok.  They'll need rework as per our discussions about how to store the fact file.  But it's a start.


Cool! Thanks!


Whoops, something weird happened with this commit but hopefully it shouldn't mess things up (apart from the init file...)


This fixes #70 and #72


> Which is ONLY injected into the container of the engine mounted at `/route/to/my-engine`. The same engine, mounted anywhere else, will receive the object from the first example.

It's interesting to me that you're proposing using the container to provide isolation as opposed to a module name. This is inline with how isolation is handled in engines presently (you can literally require assets out of them and it will work if those modules are in `require.entries`). By pushing the API to load these modules (or module) through the container we gain control over whether or not the config is visible.


It finds a row(s) from applications where application's id = id that we try to look for (e.g. here https://github.com/TheSoftwareFactory/experiment-server/blob/database/experiment_server/views/configurationkeys.py#L31 ) and returns result as array. First() returns the first result. In this case there's only one matching row 'cos id is unique so this http://docs.sqlalchemy.org/en/rel_1_0/orm/query.html#sqlalchemy.orm.query.Query.get would be better?


Oh, cool, so you had to implement this to get it to work... looks good to me at a quick glance.

One thing that confused me was how the existing global properties in the configs (like "mirebalais.checkIn.paymentAmounts": "100,75,50,0") were getting set previously.  It looks like this was happening in the MirebalaisHospitalActivator (see the updateGlobalProperty and updateGlobalProperty from config).  I *think* this should be no longer necessary after your improved method--can you test and remove the old code from Mirebalais Activator if it works without it?


Got it! thank you!


--- ... must this ...
+++ ... must include this ...

two lines here

Also, a copyright notice in the code is customary.


same as note in section 4


Why did you do this again?


add sub, mult, div, summ


That was my thinking as well. It also seemed less magical - if we compiled a file and imported it using standard module syntax, I think it would actually be confusing to users who don't know about the build process. "How am I able to import a file that doesn't exist?"

I agree that configurations almost definitely can be statically compiled at build time, in fact I'd like to add that as a requirement. But since they don't actually exist as files, it made sense to let users know that this is something special via using `inject` rather than module imports.


Good suggestion, I've replaced and extended it :)


Wait, so for other investigators and the two outside labs, there's no "1 - " before the binomial. And where does the " - 1" get included in the argument of the binomial? (sorry for all the questions, I'm trying to add this test to the permutation test right now and I want to make sure I don't screw anything up)


It may have been a bug you encountered, I remember something about compilation stuck. Did you try to update the compiler?


TeamCity Glyssen :: Glyssen pull requests [Build *.*.254.dad9bcf02eeb2ad19a81dc17dc9549e8dabe785d](http://build.palaso.org/viewLog.html?buildId=77032&buildTypeId=Glyssen_GlyssenPullRequests) outcome was **UNKNOWN**
Summary: Canceled (Tests passed: 1084, ignored: 16; exit code 1 (new)) Build time: 00:02:26


@miabbott wooohooo :smile:


Replace images links


на счёт подписей ничего не знаю, а для проверять есть https://saucelabs.com/open-source в режиме ручных тестов с любой версией на ваш вкус


I'm just drunk tired, sorry :) it was correct also before :)
now I'm a github noob, so I don't know how to remove the comment!


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#ar7JIrfkTOC8UEsWSbHlbA


@jgw96 review pull request https://github.com/driftyco/ionic2-app-base/pull/67/commits/d57635c1f2c787d1bce3c42df5a08accb0641aa2 in your time.


n


Added a 'logo' image on the top header div.
Added a link on 'The Last of Us' under the 'Favourite Game' heading, linking to the game's website. Also gave this an 'a:hover' css style, to take away the underline when the cursor is hovering over it, in order to show clearly that it is a link.
Added links to the four images in the gallery, each linking to their respective websites.
Added a 'Blog Update' div, and filled it with dummy text.
Added an image in the 'Blog Update' div, and gave it a border.


Started leaving notes in pseudocode


TeamCity Glyssen :: Glyssen pull requests [Build *.*.255.dad9bcf02eeb2ad19a81dc17dc9549e8dabe785d](http://build.palaso.org/viewLog.html?buildId=77033&buildTypeId=Glyssen_GlyssenPullRequests) outcome was **SUCCESS**
Summary: Tests passed: 1286, ignored: 17 Build time: 00:03:13


Could you tell me what is purpose for?


По PEPу "+" разделяется пробелами


@jmaguire1 Note that you overwrote some changes here made by another person. I will fix this, but you need to be more careful.


So many debugging statements here. I will fix but please review your changes better before pushing.


Зря я комменты не закрыл


ist das nur besser? oder ist der alte falsch?


Can you make this more concrete?

> Results in this config object:

 ```js
 {
   "my-engine": {
     //...
   },
   "my-addon": {
     theme: 'blue'
   }
 }
 ```


@snicolet I forgot to commit again after the last edit, from:
`TUNE(Center, InnerMid, InnerLong, OuterMid, Outer, OuterLong, MidEdge, NearEdge, FarEdge, Corner, update_psqt);`
to:
`TUNE(SetRange(-50, 50), Center, InnerMid, InnerLong, OuterMid, Outer, OuterLong, MidEdge, NearEdge, FarEdge, Corner, update_psqt);`
Thank you again for avoiding wasting more resources...


@shale99, spacing fixes have been committed by
adamdickmeiss in https://github.com/folio-org/raml-module-builder/pull/12


Mike, I don't think that's a division symbol. I think it's just a "+".


new line here please :)


new line here please


` super("suntech");
          setSupportedCommands(
                  Command.TYPE_ENGINE_STOP,
                  Command.TYPE_ENGINE_STOP,
                  Command.TYPE_ENGINE_RESUME,
                  Command.TYPE_ALARM_ARM,
                  Command.TYPE_ALARM_DISARM);
      }`


Noted, here and on the extra debug statements I forgot to remove


overall comment


Mike, I don't think that's a division symbol. I think it's just a "+". Those line-printer heads are always doing stuff like this. The (+16) is a common enough notation they used I think.


case Command.TYPE_ALARM_ARM:
                return formatCommand(command, "SA200CMD;{%s};02;Enable2\r", Command.KEY_UNIQUE_ID);
            case Command.TYPE_ALARM_DISARM:
                return formatCommand(command, "SA200CMD;{%s};02;Disable2\r", Command.KEY_UNIQUE_ID);
            default:


外周ループのアンロールは基本的に行いません


Update


Correct, but 3.3.x is built of master, while 3.5.x is built off the V3 spec branch which did not have this until I merged it in.


I've been meaning to make PacketManager an interface, considering all we need is the NGCP Hashing, taken care of by the ABSPacket, we don't need native C++ PacketManager, we can make our own.


awesome, thanks :+1:


The problem is not the damage, I should think. It's the fact that Blizzard hotfixed the trinket RPPM and decided not to tell us what the new hotfixed value is?


Entry_ID pls


The idea is that we always want the toolTipToTool translation in the Shaft coordinate system to point to a specific direction.
Maybe toolTipToToolTranslation3_Shaft should be normalized?


创建了个什么鬼？


so after overflow there be a super big number? may be disallow big numbers in GC.malloc_atomic?


Wow, terrifying.


hmm I think don't think quite agree with this fix. Perhaps the approach should be to fix the bug client side and have the `UploadUrlValidator` check for invalid URL server side. :thought_balloon:


Yay, you made it at last! Congratulations on finishing the 1.0 final release!


Some of this is an abundance of caution — I got in the habit of just adding them before I used them.


This could really use some tests, and it would be nice to try to make `js->clj` hard to use.


128792325-Issue5803 (wfbuhl) - x86_64-MacOS-10.9-clang: OK (2289 of 2324 tests passed, 534 test warnings)

 * 564 tests had: AUD diffs.
 * 119 tests had: ERR diffs.
 * 29 tests had: Table big diffs.
 * 185 tests had: EIO diffs.
 * 28 tests had: ESO small diffs.
 * 14 tests had: ESO big diffs.
 * 1 test had: SSZ small diffs.
 * 4 tests had: ZSZ big diffs.
 * 5 tests had: MTR big diffs.
 * 24 tests had: RDD diffs.
 * 14 tests had: MTR small diffs.
 * 2 tests had: MTD diffs.
 * 2 tests had: Table small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.49%25-yellow.svg)


Why aren't these all `cljify` instead of `js->clj`?


Your document is so well written according to IEEE, that we had no choice than referring it.


I think you should drop `println` in general, but definitely don't do it twice :)


@loechel Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.namedfile/56/violations
```
plone/namedfile/scaling.py:173:1: C901 'DefaultImageScalingFactory.__call__' is too complex (13)
plone/namedfile/utils/__init__.py:176:1: C901 'rotate_image' is too complex (17)
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


MBRBot.dll change is only Coz of Air Defense icon for Weak base option in GUI ! there was no Air Defense icon in MBRBot.dll, so i forced to create that and change dll


OK, this does make sense, and it's certainly nicer than trying to make the keywords, etc manually.


>
/*
 * Copyright 2015 - 2016 Anton Tananaev (anton.tananaev@gmail.com)
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.traccar.protocol;

import org.jboss.netty.bootstrap.ServerBootstrap;
import org.jboss.netty.channel.ChannelPipeline;
import org.jboss.netty.handler.codec.string.StringDecoder;
import org.jboss.netty.handler.codec.string.StringEncoder;
import org.traccar.BaseProtocol;
import org.traccar.CharacterDelimiterFrameDecoder;
import org.traccar.TrackerServer;
import org.traccar.model.Command;

import java.util.List;

public class SuntechProtocol extends BaseProtocol {

    public SuntechProtocol() {
        super("suntech");
        setSupportedCommands(
                Command.TYPE_OUTPUT_CONTROL,
                Command.TYPE_REBOOT_DEVICE,
                Command.TYPE_POSITION_SINGLE,
                Command.TYPE_ENGINE_STOP,
                Command.TYPE_ENGINE_RESUME,
                Command.TYPE_ALARM_ARM,
                Command.TYPE_ALARM_DISARM,

    }

    @Override
    public void initTrackerServers(List<TrackerServer> serverList) {
        serverList.add(new TrackerServer(new ServerBootstrap(), getName()) {
            @Override
            protected void addSpecificHandlers(ChannelPipeline pipeline) {
                pipeline.addLast("frameDecoder", new CharacterDelimiterFrameDecoder(1024, '\r'));
                pipeline.addLast("stringEncoder", new StringEncoder());
                pipeline.addLast("stringDecoder", new StringDecoder());
                pipeline.addLast("objectEncoder", new SuntechProtocolEncoder());
                pipeline.addLast("objectDecoder", new SuntechProtocolDecoder(SuntechProtocol.this));
            }
        });
    }

}


Backticks for multline?  Backticks with no substitution is kind of evil :)


Drop the commented part.


Chapter #2 Homework solutions


/*
 * Copyright 2015 - 2016 Anton Tananaev (anton.tananaev@gmail.com)
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.traccar.protocol;

import org.jboss.netty.bootstrap.ServerBootstrap;
import org.jboss.netty.channel.ChannelPipeline;
import org.jboss.netty.handler.codec.string.StringDecoder;
import org.jboss.netty.handler.codec.string.StringEncoder;
import org.traccar.BaseProtocol;
import org.traccar.CharacterDelimiterFrameDecoder;
import org.traccar.TrackerServer;
import org.traccar.model.Command;

import java.util.List;

public class SuntechProtocol extends BaseProtocol {

    public SuntechProtocol() {
        super("suntech");
        setSupportedCommands(
                Command.TYPE_OUTPUT_CONTROL,
                Command.TYPE_REBOOT_DEVICE,
                Command.TYPE_POSITION_SINGLE,
                Command.TYPE_ENGINE_STOP,
                Command.TYPE_ENGINE_RESUME,
                Command.TYPE_ALARM_ARM,
                Command.TYPE_ALARM_DISARM,

    }

    @Override
    public void initTrackerServers(List<TrackerServer> serverList) {
        serverList.add(new TrackerServer(new ServerBootstrap(), getName()) {
            @Override
            protected void addSpecificHandlers(ChannelPipeline pipeline) {
                pipeline.addLast("frameDecoder", new CharacterDelimiterFrameDecoder(1024, '\r'));
                pipeline.addLast("stringEncoder", new StringEncoder());
                pipeline.addLast("stringDecoder", new StringDecoder());
                pipeline.addLast("objectEncoder", new SuntechProtocolEncoder());
                pipeline.addLast("objectDecoder", new SuntechProtocolDecoder(SuntechProtocol.this));
            }
        });
    }

}


Yeah, that looks more like it to me. Let me revert this change....


Should have been named "Integration of a Block's data and it's visualiztion"


I feel like this might be required only because of `cljs-promises`.  We should investigate and try to fix upstream.


Eh?  This seems like a generally useful utility, and one that shouldn't `println`.  Consider making `f` optional.


Rather do ```effect.ppm_ = -1.5``` I think for now. I'll need to adjust our exporter to blacklist some fields for hotfixing, but that'll take a bit.


Ah, you're addressing my earlier comment here.


>
/*
 * Copyright 2015 - 2016 Anton Tananaev (anton.tananaev@gmail.com)
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.traccar.protocol;

import org.traccar.StringProtocolEncoder;
import org.traccar.helper.Log;
import org.traccar.model.Command;

public class SuntechProtocolEncoder extends StringProtocolEncoder {

    @Override
    protected Object encodeCommand(Command command) {

        switch (command.getType()) {
            case Command.TYPE_REBOOT_DEVICE:
                return formatCommand(command, "SA200CMD;{%s};02;Reboot\r", Command.KEY_UNIQUE_ID);
            case Command.TYPE_POSITION_SINGLE:
                return formatCommand(command, "SA200CMD;{%s};02;StatusReq\r", Command.KEY_UNIQUE_ID);
            case Command.TYPE_OUTPUT_CONTROL:
                if (command.getAttributes().containsKey(Command.KEY_DATA)) {
                    if (command.getAttributes().get(Command.KEY_DATA).equals("1")) {
                        return formatCommand(command, "SA200CMD;{%s};02;Enable{%s}\r",
                                Command.KEY_UNIQUE_ID, Command.KEY_INDEX);
                    } else {
                        return formatCommand(command, "SA200CMD;{%s};02;Disable{%s}\r",
                                Command.KEY_UNIQUE_ID, Command.KEY_INDEX);
                    }
                }
            case Command.TYPE_ENGINE_STOP:
                return formatCommand(command, "SA200CMD;{%s};02;Enable1\r", Command.KEY_UNIQUE_ID);
            case Command.TYPE_ENGINE_RESUME:
                return formatCommand(command, "SA200CMD;{%s};02;Disable1\r", Command.KEY_UNIQUE_ID);
            case Command.TYPE_ALARM_ARM:
                return formatCommand(command, "SA200CMD;{%s};02;Enable2\r", Command.KEY_UNIQUE_ID);
            case Command.TYPE_ALARM_DISARM:
                return formatCommand(command, "SA200CMD;{%s};02;Disable2\r", Command.KEY_UNIQUE_ID);
            default:
                Log.warning(new UnsupportedOperationException(command.getType()));
                break;
        }

        return null;
    }

}


Maybe we want `go-promise`?


Normalizing it won't change the outcome, the check is still for a dot product greater than 0.

I'm not 100% sure I grasp what we're trying to do here, but I'm not sure that using the computed translation is a good idea, because it could be anything depending on the sensor's physical orientation and position with respect to the physical tool tip?


Why bother webpacking this?  Easiest way to get babel working?


take this one out.  it is filePath type


1. why ?
2. do not call GetTokenString() twice, do not copy the whole string into char array just to check first char is '<', do not.


Oh ok, got it 😃


Thanks.  I had already got up to `select /spi@60000100/sd@8` and testing `size`, `read`, `seek` and `write`.  Wasn't sure of the filesystem access method after that, as I still had the CForth SPIFFS words in mind.  I imagine a SPIFFS shim node will expose that layer higher up, without `disk-label`, similar to how `nandflash` works on XO-1.


comment 1


Hi,

I'm using Apache 2.4.23 with mod_passenger (for redmine) which does not work anymore  (it did with Apache 2.2).
Error shown in error_log:
`[Wed Sep 21 23:50:33.729215 2016] [autoindex:error] [pid 3533] [client 192.168.0.205:40690] AH01276: Cannot serve directory /var/lib/redmine/public/: No matching DirectoryIndex (index.html,index.html.var,index.php,index.phtml) found, and server-generated directory index forbidden by Options directive
`
With disabled mod_autoindex (i.e. not loading) it is working as expected  and handled by mod_passenger.

For me it looks like an error in mod_autoindex so I've checked its history here at Github. **This commit breaks it**.

Undoing this change and it is working with enabled mod_autoindex again.
I've checked with mod_passenger 4.0.60 and 5.0.30. Both are not working with this commit.


note: it's also namespace alias, and default alias in PHP < 5.6


113836013-Swimming-Pool-Evaporation-and-Cover-Issues (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2370 of 2374 tests passed, 7 test warnings)

 * 6 tests had: EIO diffs.
 * 7 tests had: ESO small diffs.
 * 1 test had: AUD diffs.
 * 4 tests had: ESO big diffs.
 * 1 test had: MTD diffs.
 * 1 test had: MTR big diffs.
 * 1 test had: RDD diffs.
 * 2 tests had: Table big diffs.
 * 1 test had: ERR diffs.
 * 1 test had: SSZ small diffs.
 * 1 test had: ZSZ small diffs.
 * 2 tests had: MTR small diffs.
 * 1 test had: Table small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg)


Am I missing the PR? Or was this a push straight to master?


The thing is we want the images to use the CDN so this commit basically does the opposite of https://github.com/discourse/discourse/blob/master/app/serializers/basic_category_serializer.rb#L46


129956421-Scalable-Sizing-HTRad-Heat-Crash (RKStrand) - x86_64-MacOS-10.9-clang: OK (2332 of 2334 tests passed, 7 test warnings)

 * 4 tests had: EIO diffs.
 * 2 tests had: ESO big diffs.
 * 2 tests had: MTR small diffs.
 * 1 test had: Table small diffs.
 * 7 tests had: ESO small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg)


The issue is that ``./configure`` tests for each command-line option individually, but ``-fsanitize=cfi`` requires the presence of ``-flto``, and I am not sure how to accommodate that for the moment.

For the record, as of this commit, ``pbpst`` still compiles and functions normally with the CFI sanitizer enabled; only the configure script fails.


Mate, referring to this file: _arch/arm/include/asm/barrier.h_

**dsb(ishst)** doesn't existed, but instead it was listed as **dmb(ishst)**

So I thing we should use **dsb(sy)** for a proper implementation.


Looks like PR58498 in ASF bugzilla.  IIUC This module can't use "" as a handler and expect it to be honored.    I don't think we should revert the quoted revision after a year.


Before introducing this feature the `exportValue` method returned a json string which could be converted to suitable format (generally RB crits but also other).
Now QueryBuilder is hardcoded linked to RB crits only.
I was using the QueryBuilder to build different query than RB crits.
After applying this feature it is not possible any more by using QB directly.
Is it possible to consider returning the json for the `exportValue`?


113836013-Swimming-Pool-Evaporation-and-Cover-Issues (RKStrand) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Tested the gutted version of play_media for a couple of weeks without failure. As long as we are only using the "Default Media Receiver", I am pretty shure we don't need to kill anything.


not my forgetfulness. pls g


Oh, my... thanks for the GCC upgrade and for the gapless exclusion, we already had the LG effects one. Now I understand the point of using stock and its blobs, all kernel effects are there to be used in userspace instead of generic HALs supplied by CAF.


test


Correct. And for performance, we should recognize that lines 1-6 don't need to be processed beforehand (you don't need to worry about that part right now -- processing all the lines and taking the last 4 is fine).

The idea is that our GameState will have a buffer we keep on adding to, and eventually it'll overflow the window. In that case, we want to throw out the oldest text in the Window to make room for the new one. Eventually, the user should be able to scroll through the history as well, so all those lines are preserved in GameState.


129956421-Scalable-Sizing-HTRad-Heat-Crash (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1768 of 1768 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.14%25-green.svg)


develop (mjwitte) - x86_64-MacOS-10.9-clang: OK (1765 of 1765 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


129956421-Scalable-Sizing-HTRad-Heat-Crash (mjwitte) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


The list method has `append()`, as you use later -- you could something like `temp.append([])`


Fixed (also removed the above unset), thanks!


@Biggsen looks good to me. You could run the tests on a branch with jenkins to double check it's all working
@lauratennant happy with the case of the "sign in" ?


@onli See? It works. (Also removed the `index.tpl` for `idea`.)


Pushed straight to master.  Should I have followed a different protocol?

________________________________
From: Forrest <notifications@github.com>
Sent: Wednesday, September 21, 2016 6:01:41 PM
To: streamlink/streamlink
Subject: Re: [streamlink/streamlink] Latest fix to plugin from livestreamer (b420f6c)

Am I missing the PR? Or was this a push straight to master?

-
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<https://github.com/streamlink/streamlink/commit/b420f6c6ad093f6eded617c9bfb989f6316b1bd7#commitcomment-19121544>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AESJ1miv1_4xAOKWCMTBmJdsaibNcN8nks5qsalFgaJpZM4KDU5G>.


:shipit:


Thank you for your fast reply. You are right, it's that issue.
It was my fault, version 5.0.30 is working (4.0.60 not, but thats the point with the empty handler name).
I saw your commit to passenger here on github. All ok ;)


develop (evanweaver) - Win64-Windows-7-VisualStudio-12: OK (2396 of 2448 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.88%25-yellow.svg)