This is vulnerable. What happens if self.oneSecondInPercentage someday is set somewhere else? I propose you set a isLoaded variable in loaded() instead.


Hi, when will this commit available in
`Pkg.add("Gtk")`
? I'm experiencing this bug


But now the rrrr in CRC doesn't roll off the tongue so good any more… :(

Fair enough about a one-char change!


This update also removes an email address leak in page source.


Currently you have to checkout master (Pkg.checkout("Gtk")). It needs someone to tag a release.


제가 폴더는 못 만드나봐요...java폴더 만들어서 넣고 싶었는데...이렇게 됐어요 죄송합니다ㅠㅠ
mail 소스에요


Yes, we should probably not expose this 849bac1.
I think it's a feature to be able to have the boolean undefined if it's undetermined – but not useful in this case.


I forgot the .xcspec here.


second commit......akhila


Danke Keppi!


@alexbruy , I see two zonal statistics item in the toolbox:
![untitled](https://cloud.githubusercontent.com/assets/1728657/19555318/85e767ca-96e6-11e6-9e00-da43fdf7b56f.png)


what the hell that u are using so many empty if statements!!!


New second Pixel constructor:
`Pixel.new(texture, [x = 0], [y = 0], [width = texture width], [height = texture height], [sx = 1], [sy = 1])`

New methods for textured Pixel:
`setTexturePosition(x, y)`
`getTexturePosition() --> x, y`
`setTextureScale(sx, sy)`
`getTextureScale() --> sx, sy`

Improved old method for textured Pixel:
`setDimensions(width, height)`

And getter for it:
`getDimensions() --> width, height`


@81ninja what did you do to save the kerbals and vessels to server? I tried SendVesselUpdate but I only acquire the lock (blaming @godarklight), but I actually have a NRE as well, which could be due to the nonexistent kerbal in the roster. I'll fiddle around this weekend again and try to finish up this thing.


Please fix this so it's a guard pattern instead of an else return;

I can help you with this a bit later.


your commit messages are becoming less and less descriptive lol


Change to isFacingRight


I GUESS NOT?


New Method


@malyw Doesn’t look like it https://drafts.css-houdini.org/


:) Yes, the latter one.
I imagine users can't tell in advance if their code will only run on arrays with some NaN values in them. So it would be beneficial to illustrate a potential drawback or gain in performance in case the same LOC is executed on arrays of same shape but different NaN distributions (i.e. 33% and 0% NaNs).


Ok, will do. Are there any other Linux-specific icon sizes that would be worth adding? Any other resources?


downloading the last 500 games of everybody in the 4545 league goes at about 1 request/minute, amortized over all the delays I get hit with. This makes the API too slow to be useful for this project.

People really like the opening tree, but I can't provide it for the 4545 league because the API is too slow. That's too bad, I'd like to make it work!

I'd be happy to work with you to make my requesets to the API fast enough, but otherwise I'm just going to continue to say that the lichess API is not functional enough to support the lichess opening tree.


noob


Em android *final* conta como constante.


Using the module from caf in the hardware package.


 **UPDATE 18 Oct'16**
  Iniitial implementation includes use of latches - purposly.
  Need to mitigate Latch warnings during synthesis by using if AND else statements rather than only if statements.

  **UPDATE 20 Oct'16**
  To avoid latches, you need to make sure all of your outputs are assigned at all possible branches of the code.

 **Refer to :**
 http://electronics.stackexchange.com/questions/18075/how-to-avoid-latches-during-synthesis
 https://www.doulos.com/knowhow/vhdl_designers_guide/tips/avoid_synthesizing_unwanted_latches/
 https://www.eeweb.com/electronics-forum/removing-latches-generated-from-missing-assignment-in-if-statement
 http://www.edaboard.com/thread314097.html


@simevidas They were moved to the MQ Level 5
https://www.w3.org/blog/CSS/2016/06/23/minutes-telecon-289/
https://github.com/w3c/csswg-drafts/blob/master/mediaqueries/deferred-for-level-5.txt


@sekmiller is this a fix for #3140? If so, can that issue go through QA?


Seems like it's working? Maybe you didn't save / refresh the page before?


Testing the fork file


Yooooo


JK, hardly works well. Seems same as this issue... kinda http://stackoverflow.com/questions/2008126/cgeventpost-possible-bug-when-simulating-keyboard-events


@malyw That’s the plan; either level 5 or some Houdini spec 😊


I think `OnReferenceCountChanged` should have an argument and get result of `Interlocked.Decrement` so it can react to a actual new value without races.


@bcardiff any plans to tag a release soon? :smiley_cat:


Adding the location to the response is useful if you are using the API without the GUI.


yeah,very nice,i want use Flask-login with pymongo,thank you!


Hahaha I get kinda loony with lack of sleep, I'm done with this week


Тут теперь всё хорошо, но я вспомнил что меня беспокоило в прошлый раз. Если мы не присваиваем никакого значения и сразу обращаемся к значению переменной получается ошибка:

```ruby
class One

  extend Acessors

  attr_accessor_with_history :value

end

one = One.new
one.value # => undefined method `last' for nil:NilClass (NoMethodError)
```

Это логично, потому что изначально `instance_variable_get("@#{arg}_history").last` даст нам `nil`. Это можно поправить так: `(instance_variable_get("@#{arg}_history") || []).last`. То же самое у `value_history` метода: `(instance_variable_get("@#{arg}_history") || [])[0..-2]`.

Наконец, если мы присваиваем какое-то значение, например: `one.value = 1`, то в истории у нас будет пустой массив, хотя по идее предыдущее значение `value` было `nil`. Это тоже можно поправить ниже: `instance_variable_set("@#{arg}_history", Array.new(1))`.

Таким образом, код метода после всех дополнений:

```ruby
  def attr_accessor_with_history(*args)
    args.each do |arg|
      # define attr_reader
      define_method(arg) do
        (instance_variable_get("@#{arg}_history") || []).last
      end

      # define attr_write
      define_method("#{arg}=") do |value|
        unless instance_variable_defined?("@#{arg}_history")
          instance_variable_set("@#{arg}_history", Array.new(1))
        end

        instance_variable_get("@#{arg}_history").push(value)
      end

      # define history_reader
      define_method("#{arg}_history") do
        (instance_variable_get("@#{arg}_history") || [])[0..-2]
      end
    end
  end
```


Так намного лучше.


Este es otro texto


Thanks! BitHub has sent payment of  $61.44USD for this commit.


**[unitTests_php_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_php_branches/37420/testReport/) for this commit**


Thank you for the work so far! Please dont forget to make a pull request when you complete it. You dont need to translate everything, you can also make pull requests of partial progresses, so I can be updating more often.  Just do the best for you, take your time ;)


You've hardcoded your own Maven repository location in .classpath...


Thanks!  This is great!


4989-Part2-PIUTstatControl (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1772 of 1772 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.15%25-green.svg)


also added facebook link, and deleted third section in html


4989-Part2-PIUTstatControl (mjwitte) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


nome significativo


I think we would generally:

```
@Value('${spinnaker.redis.port:6379}')
String port
```

and then `Integer.valueOf()` it.

Not sure if @jrefi ran into this but making ^^ change seems reasonable to me.


The function returns true even outside this if block, in short DropEarly always return True


This was useful for getting at the Cause objects for a build, is there another means to do that from a Jenkinsfile in a multi-branch job?


Super neat use of WeakMaps.


@cwkatzmann broke the build.


@sokra could you merge this change to 1.3.2?


Should we use a local copy of normalize.css?


Team


@mattkrick I was thinking we could put different things in this bannerMessage, otherwise it doesn’t render, and there is just a thick band of color for style (it collapses to less height).

- When redirected at the end of a meeting, it mentions all team members getting the summary in their inbox (as seen in the example code).
- When sent as an email, it could have a link to the web browser route “Trouble viewing? View this summary in your browser.” sort of deal.
- One day, when we create an index of meeting summaries, it could have a link back to the index.

Whatcha think?


you can hit the rebuild button in the travis UI, upper right 😄


This case should be relative to `LocationReportRequest.code` instead of `ProvideLocationRequest.code`, as that is the Request received by the server (GMLC), right ?


Still bypassing, allows the sentry turrent to be placed. I believe its an entity as it pulls a morph on removal. Can I edit protection files and expect changes instantly?


@connorshea rack 2 and activesupport 5 require ruby >= 2.2.2. Is GitLab dropping this support to move to rails 5?

We can drop support for ruby <2.2.2 in a v2 release of task_list.


Please disregard earlier comment!


Wowowow, so much nicer


#提出課題　STC_Pmon


Seems that the ModID is incorrect. Can you please hold a turret and type `/ta debug itemClass`?


@nyalldawson yeah and I believe the new behavior is correct. Before the legend node embedded in parent was not correctly detected when using with diagrams - now it is detected and thus the layer group is hidden by default.


item.PortalTurret.name
portalgun.common.item.ItemTurret


Yep, thanks a lot!


See also #264.


Try with the last commit please


You don't have to drop support at all :)

See what I did here: https://gitlab.com/gitlab-org/gitlab_git/merge_requests/99


I would say you should drop < 2.1 support though. I'm trying to get the tests running on GitLab CI and I'm almost there, but now I have to figure out how to get a Docker container with Ruby, Node, and PhantomJS.


4989-Part2-PIUTstatControl (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (2345 of 2345 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I tried, without a reboot. no go, but if it requires a reboot, I will have to wait. The server is pretty full.


@brainslog, the request received by the GMLC is LocationReportRequest, that's correct (ProvideLocationRequest is the one sent by the GMLC)


The installer.vbs file still contains a reference to scummvm.nsi. From the looks of it, we could simply delete the entire file, and remove it's reference from postbuild.cmd, but I'd like a second opinion.


OK - no strong opinions here either way. Users can get the old appearance back by manually adding a group if they want it.


Didn't sync with FTPloy for some reason


You dont need reboot, use `/ta config reload`


You mean github release right? The tag is published and usable in the shard file.


测试数据


still allows for placement.


Okay, then the ModID is wrong (and iChun didn't set a ModID :x ), I'll try to find it.


![](https://github.trello.services/images/mini-trello-icon.png) [Get user/profile info](https://trello.com/c/tleCHOuh/26-get-user-profile-info)


For now it would be fine to leave it on Travis and use something like what carrierwave does: https://github.com/carrierwaveuploader/carrierwave/pull/2026


Great catch @brainslog :)
I missed it... testsuite is working now 👍
Will push the fix right away


In what kind of condition / problem, will it "be safer in Jeffreys prior"?


👍 Thanks for fixing this!


If the pull request looks good you have to accept it. This is how the changes pass the review and get pulled from review branch to master branch.


Need to check for `Date` or `POSIXct` attributes before returning


Shame on me, I looked at tags and didn't see it, fetched my local copy and was there. Sorry for the noise :disappointed:

And thank you for the release!!! :smile:


Shouldn't this be px4fmu_fd?


Indeed. :-) Glad you are helping each other.


We should be able to @Value onto an int (we do it extensively elsewhere)

Did this just manifest via some transitive dependency update? (Eg fiat libs updating spring past 4.1). The world is in flames wrt @Value in a post spring 4.1 world at the moment...


Removing "$GUACAMOLE_HOME" fails if used as mount for Docker volume.


nice test bro
![image](https://cloud.githubusercontent.com/assets/6781440/19583516/fa450bb6-976f-11e6-86c3-212ac46b9097.png)

- [ ] 1232312

- [ 323]1


Add control of "guacd-ssl" guacamole.properties parameter.


Missing `daemon_read.run`?


Have you even tested this that it works?


u suck tbh


As this is being used by multiple people it is better you have some switches to disable the things you added.


![img_0060](https://cloud.githubusercontent.com/assets/5924811/19583571/c9b61e84-9735-11e6-8f32-86e5e9bd592f.JPG)

This pic is from one of the drawings i did to try understand the chess board


BGPPathAttributePmsiTunnel内に定義するように修正します。
BGPPathAttributePmsiTunnel内での定義は
TYPE_NO_TUNNEL_INFOMATION_PRESENT
TYPE_INGRESS_REPLICATION
とし、ryu/services/protocols/bgp/api/prefix.pyでの定義は
PMSI_TUNNEL_TYPE_NO_TUNNEL_INFO
PMSI_TUNNEL_TYPE_INGRESS_REPLICATION
に修正します。


There is an example of using a normal distribution population.

There is also an example of a exponential distribution population.

Each example pulls sample sizes of 10 and 50 and creates a histogram of the results.

The raw code is is files NormDistExample and ExpDistrExample. There is also a formatted R Markdown example as well.


128792325-Issue5803 (wfbuhl) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2202 of 2369 tests passed, 407 test warnings)

 * 436 tests had: AUD diffs.
 * 112 tests had: ERR diffs.
 * 24 tests had: Table big diffs.
 * 61 tests had: EIO diffs.
 * 36 tests had: ESO small diffs.
 * 16 tests had: ESO big diffs.
 * 1 test had: SSZ small diffs.
 * 4 tests had: ZSZ big diffs.
 * 38 tests had: RDD diffs.
 * 25 tests had: Table small diffs.
 * 14 tests had: MTR big diffs.
 * 10 tests had: MTR small diffs.
 * 2 tests had: MTD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-92.95%25-yellow.svg)


Or maybe scratch that, I may have gotten it building...


work on your midterms


no


Using portal.send_request has been depreciated (see #55).
Replace with get/set/cmd


ご指摘のとおりですので、
`:param str ip: IPv4 or IPv6 address string`
に修正します。


Don't forget to use React.component so we don‘t have to override it.


128792325-Issue5803 (wfbuhl) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


sdsd


Can we export the caching functionality to save() and load() functions? If you look at the smoothen function in smooth.py I have lines commented out that show what I was intending to do: load the network if a file in cache_dir with a name matching the function's hash exists, and otherwise train a new network and explicitly calll a save function to save it.


What is the myenv directory for?


PlaceAdForm: boolean studio = true ... as workaround
Can't place an ad on master too


<meta property="og:image" content="http://static1.squarespace.com/static/54b7eb8fe4b089bfadc6da24/t/57d625bb44024343d19f1ad1/1476662850039/?format=1000w"/>


@dpgeorge : FYI. Based on complaint from @kamikaze that it's hard to figure out which port is for pyboard.


We should also standardize indentation -- I think we agreed on 4 spaces last time.


Forgot to update it on the contact page. If only we used Jekyll 😆


The code is very whacky.

It only works when reCaptcha **1.0** is set in the Joomla options. 2.0 doesn't display at all.
It will also only work when "Enable plugins" is set to Yes in JComments, otherwise the old KCaptcha shows up.


yeah, that all sounds good!
I'm struggling to figure out how to wire this thing up...

So we've got 3 ways to see this:
- from a meeting summary index on the team dash `/summary/:summaryId`
- from a just-finished meeting `/summary/:summaryId`
- from an email inbox

Do we want to have the same url for the first 2? Should the one in the meeting have the meeting sidebar & a different url?

Do we need emailSSR, or is that just for testing?

@jordanh can you think of a clever way to fetch the GraphQL query for the client & for the email? I'm thinking before we send the result down to the client, we see if we sent the email yet, and if not, then we call the emails with that super fresh data so we only hit the DB once.


GRRRrrr.  The CI fail here was for GPG format.  That has nothing to do with this change.

CI's are great, until they are not.


Oops, fixed.


emailSSR is just for testing.

For the data side of things, could you write a mutation that:

1. Queries the DB (and probably updates the meeting record that the email has been sent)
2. Generates and sends the email if it hasn't been sent
3. Returns the data from the DB to the client

?


It does fix the issue, thank you!


Awesome !!!! 👍


`mypy` is some kind of WSGI framework  Changed the requirement to the latest version of `mypy-lang`.


Is this more along the lines of what you wanted? ([screenshot](http://prntscr.com/cwxkhk))


2110 ???


yep, the pattern is just awkward to do in cashay right now. Dang ol mutation occurring before the query and what not.


My memory says GPG could be a format with CI problems (sometimes seen). But I might be wrong.


This is a start of a structure that will contain all the common functionality for things like working with paragraphs and tables in a single class rather in every class that can work with paragraphs and tables. Right now there is some overlap between XWPFDocument and XMLContent, particularly in the properties paragraphs, tables, and bodyElements. This will eventually be migrated from XWPFDocument to XMLContent so that the XWPFDocument contains only those methods that are unique to XWPFDocument, and delegates to XMLContent to perform all common functionality.


Thanks @ericbuehl!  The test I ran before must have been using GAX and decoded it before I debugged it.


<img src="img/banner.jpg"


you can remove this if we're going off of RDF types.


If you want to use RDF types, you could create this field in an indexer and set it to true if the user types included the active RDF type. You'd need to write a custom indexer for that.


Make this use `active_user_query` instead, i.e. it always defaults to active users. Then, if you like, check for another parameter, like `params[:q]`, and if that is set to "all" then you could use the original `search` method and return all users, both active and inactive.


try removing this changes and then....


I don't think we need the extra endpoint here. I would leave the index action as it was and have `user_list` always return the list of users you're looking for.


My next commits did not trigger the problem.  It likely is something that we should look at within the -test-full=0   There might be a problem, but it only shows up transiently.  I will test a bit.


You shouldn't need this, unless I'm missing something.


see my comment above... I think we can use only one /users endpoint and control the flow with additional parameters, and default to return only active users.


![screen shot 2016-10-21 at 02 53 49](https://cloud.githubusercontent.com/assets/5924811/19584167/61aeb5b2-973a-11e6-9545-1e1ffd2aeff9.png)

Rook


@krakjoe how about release?


hi hello


I agree. I also dislike this solution. Exactly here NULL is possible only if GTT is creating because in parse.y we assign it explicitly. So it NULL is here it's GTT but for GTT default is rel_global_temp_delete. But if then someone will assign NULL in relationType this place will be wrong automatically. I think it's better to add special nullable option for GTT and check it here. relationType revert as it was.


congratulation!


cek lur


@AlexOreshkevich : This is a good point. However, this check is only executed against the local instance, which gets wiped out after each rebuild. Are you concerned that it may fail within the IDE, if the `target/strongbox*` directories are not wiped out?

The idea of the test is to actually validate that this particular build produced 12 records. These twelve records are:
- 4 build versions of the artifact
- Three sub-artifacts (with classifiers) per version

One way is to get the full timestamp and build number and check that each of them were indeed added.


Stopped [test](http://tests.stockfishchess.org/tests/view/5809d3fd0ebc5910626b9667) because there is a bug: shift operations instead of multiply/divide by a power of 2 only works for unsigned int, not for signed.


@AlexOreshkevich : See comment above.


When trying to resolve #778 I encountered some double compilation issues. It looks like it is a threading  related issue that doesn't properly handle  _draw_model() in src/sas/sasgui/perspectives/fitting/basepage.py:1457 and as a result compilation is triggered twice at the same time.

This seems to be the Windows only problem (regardless if OpenCL is used or not).

The working solution is to add time delay (as in  src/sas/sasgui/perspectives/fitting/basepage.py: 1462).  Reading the code this seems to be the way threading problems are handled in SasView but it looks quite hackish to me.


I see, this now makes more sense. Thanks!


good point, there are more such spots, I'll try to find and mark them


I propose explaining the reason that the object is being shared, e.g. "… and is shared on both screens, because it's queried via a PATCH call in the responses screen to mark it as read, and the response is broadcasted on the event bus as a `DiscussionThreadUpdatedEvent`, which is then used to replace the existing model. A better approach may be to not allow sharing of the objects in an unpredictable manner by always cloning or copying from them, or on the other extreme, having a central memory cache with registered observers so that the objects are always shared."


:-) Cool, that's what I am trying to do atm. See how it goes ...


:tada: gonna steal that! :smile:

Something related I find helpful for cleaning up the local repo:

`git branch --merged | grep -v "\*" | xargs -n 1 git branch -d`


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=27)


nice <3


Shouldn't that rather mean an updated expected result?


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.683.62b9dded771ebd5373f3f8fc9467d368a20c03a5](http://build.palaso.org/viewLog.html?buildId=78709&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 937, ignored: 56 Build time: 00:14:20


Where are policies defined? I guess we'd need a "policies" structure under "aggregator".


*dodani auti
*prilikom klika na start svjetla semafora blinkaju
*rubovi aplikacije i dugmića oblikovani


<!-- Esta todo correcto -->`


现在的状况好像是好像没有实际的Model可以用


for loop Is not required


这里不是很明白？ noqa是什么意思？


Mycket bös. Vad ska man säga?


Fixed in PR https://github.com/wso2/product-emm/pull/324


装了3.2版本的pymongo，执行python new.py时依然报错


So that the code isn't on another branch, I'll just make this change small and obvious so you can fork it however you want.


Hi, I think this commit did a revert of https://github.com/j3k0/cordova-plugin-purchase/commit/40ec181a39f4381b9189e11e3b52bd4217f47bfe , but only on the javascript files.

This makes the subscription purchase flow fail to start.


Maybe add a default command? this commit broke my docker-compose :(

```
CMD ["server"]
```


Absolutely right, however it wasn't working in my environment, and didn't want to spend too much time on it. ;)


Can't you set the value here? I think it would be more intuitive.

`
gtt_table_clause
	: simple_table_name
			{
				$<createRelationNode>$ = newNode<CreateRelationNode>($1);
				$<createRelationNode>$->relationType = Nullable<rel_t>::empty();
			}
		'(' table_elements($2) ')' gtt_ops($2)
			{
				$$ = $2;
				if (!$$->relationType.specified)
					!$$->relationType = rel_global_temp_delete;
			}
	;
`


Hi I experience the same problem in 2.1.2. I included both files with above code in /app/code/Magento than emptied the cache but did not make any difference? So where to apply the above code to get this fix working?
Still getting: Cannot gather stats! Warning!stat(): stat failed for /var/www/html/pub/media/catalog/product/i/m/i0351.jpg when opening a catalog product with missing image! The original image file's nam is img_0351.jpg why is that changed into: i0351.jpg ? I think that's why the path to the image file is not correct anymore? How to fix that (or does the above code solve that as well?).
Will it be better if I manually replace the 2.1.2 files with the Git develop branche?


My last small obvious change so I can see how you fork it later when you have time.


@matehat may I ask why this change occured? I just made changes `re2` -> `re`, ran tests and everything passed.

Was it speed concerns?

In my case the reason we'd like to stick to original `re` is that `re2` make it harder to build the package, e.g. some heavy c++ libs should exist in the system.


Hey @nateberkopec ,

Is there some reason for this redirect? This sometimes causes the error to be displayed in the sentry server.

Would it not be better to just return nil?

Also in a pattern like this `Raven.sys_command("uname -s") || RbConfig::CONFIG["host_os"]` could end up displaying the error of the first command instead of the value of the second.


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.298.62b9dded771ebd5373f3f8fc9467d368a20c03a5](http://build.palaso.org/viewLog.html?buildId=78702&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 949, ignored: 50 Build time: 00:29:25


And faster. 👍


ide yang bagus


It was breaking on some stuff in my case. Now no more problems and it still fits 😄


type удалить, статьи тоже будем отдавать.


forcestereo is about converting mono stream to stereo. This is done on purpose for people with a hearing disability (eg, they can only hear things in one hear)


What are you trying to do from this line?


engine is common keyword for this kind parameter.


Russian Escorts Girls in Delhi
Russian Escorts girls in Gurgaon
Russian Escorts Service in Mahipalpur
Russian Escorts Service in Dwarka
Russian Escorts girls in karol bagh
Russian Escorts Service in Aerocity
Model Russian Escorts Service in Dwarka
Russian Escorts Service in Mahipalpur


Тесты еще тоже нужно добавить. Я пишу сначала тесты, на них .only и после добавляю функционал и тестами его же проверяю, без браузера.


we need to get in sync on this, I need better understanding of cluster aggregation setup.


Collaborator:
Corresponding review in collaborator has been deleted.


Лучше поле type переименовать в format, вдруг будем передовать type для Story


![](https://github.trello.services/images/mini-trello-icon.png) [[doc] Bug 993499 - deploying ceph with salt (edit)](https://trello.com/c/85dQGxAt/2043-doc-bug-993499-deploying-ceph-with-salt-edit)


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=28)


#DOL实例分析&编程
----------------------
##example中各文件的含义：
-----------------------------

src文件夹：各进程（生产者，消费者，处理模块等）的功能定义；文件夹内包含.c和.h两种
文件，就是实现的模块，即*.dol的框架的功能描述；
.xml文件：系统架构即模块连接方式定义；定义模块与模块之间的连接方式；其中proces是
框架，sw_channal是线，connection就是连线的脉络。

----------------------------------------------------------------------------------------------------
##exmaple1分析：
![#.dot1](http://a3.qpic.cn/psb?/V10xhQuy3m7suY/gpmj8eJPIkGQSUQi8PMkCdxLCMAHGKppBzFdI7pB8Tk!/b/dHwBAAAAAAAA&bo=.gHiAAAAAAADBzs!&rf=viewer_4)
如图；生产者和消费者只是发送和接受信号，其中的处理过程在square中做；所以example1只需要在square中处理即可；
![example1](http://a2.qpic.cn/psb?/V10xhQuy3m7suY/LaJEn77w3QGODJ5GZNTvZARwp7tEj956CTvLmuzSlWc!/b/dNwAAAAAAAAA&bo=iANQAgAAAAADAPw!&rf=viewer_4)
一开始example1的迭代次数为2，square中改动迭代次数即可；
##example2分析：
![#.dot2](http://a2.qpic.cn/psb?/V10xhQuy3m7suY/rL*2PQTXAnVhdWh7fkIfEVXdncM9g9eZC.lsIQIvKc4!/b/dNwAAAAAAAAA&bo=SQTCAAAAAAADB60!&rf=viewer_4)
进程定义与example1很类似，只是这里有3个square；因此处理的思路也很清晰，只需要在.xml文件将迭代次数N减1即可；
如图：
![example2](http://a3.qpic.cn/psb?/V10xhQuy3m7suY/ri*4jzrePox6gdlZ5u*9hiFy3s0U39kHHqZYIkE2UtM!/b/dAoBAAAAAAAA&bo=hANQAgAAAAADAPA!&rf=viewer_4)
可以看到N==2，即迭代次数为2；i^4不为i^8;

--------------------------------------------------------------
##example运行结果：
----------------------
### 在虚拟机中打开**terminal**，输入指令:

$	cd dol
$	cd build/bin/main
$	ant -f runexample.xml -Dnumber=1
$	ant -f runexample.xml -Dnumber=2

**在每次改动example之后要删除build并重新编译一次build.zip.xml**

-------------------------------------------------------------------------
##得到最终结果
**example1结果图**
![example1结果图](http://a1.qpic.cn/psb?/V10xhQuy3m7suY/RyJHZnDKDGj08GvPRZu9bh*QqKCdNratuqBN6KQwiv4!/b/dHcBAAAAAAAA&bo=nQJXAgAAAAADAO8!&rf=viewer_4)
---------------------------------------------------------------------------------------------
**example2结果图**
![example2结果图](http://a3.qpic.cn/psb?/V10xhQuy3m7suY/aAk3UU.jPOs99SvxhNA1eljFGnlRmaBy69hpFMWug6A!/b/dNoAAAAAAAAA&bo=oQJWAgAAAAADANI!&rf=viewer_4)
**example2 dot图**
![dot](http://a3.qpic.cn/psb?/V10xhQuy3m7suY/NUrT61NVYa*U8Tly4cq*yAv41IrftoMBQfCtFRAuIXw!/b/dAoBAAAAAAAA&bo=1QJxAAAAAAADB4Q!&rf=viewer_4)
##实验感想
-------------
这次实验本质上不是很难，在嵌入式的框架上也是老师讲过的，实验的处理方法和终端的运行TA上课和课件也有很详细的说明，难度不大；但对于dol的编程有了更深的理解。
----------------------------------------------------------------------------------------------------


Comme en markdown, c'est mieux avec des retours à la ligne plus régulièrement pour éviter les diff illisibles en cas de corrections ;)


May be AdvMinerII could show "missing pipes" too?


👍
один вопрос, почему не формулой?


It does. Just did not write it down.


Вот только давай следующее задание на новой ветке у себя сделай и пушани ее на гитхаб + создай пуллреквест


2782485_HybridModel (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2355 of 2379 tests passed, 550 test warnings)

 * 550 tests had: AUD diffs.
 * 517 tests had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.99%25-yellow.svg)


ARI and Flesch-Kincaid calculations


ok adjusted thermanager to scale values according to attribute. Still doesn't work although thermanager reports correct values now.
https://github.com/oshmoun/thermanager/commit/c66c27720d3a765a5433e1428da3f2b71326d1fb
https://github.com/oshmoun/device-sony-suzuran/commit/50c23eafb0221c23eb6f9191b6caf2866464431d


done


Vu qu'à chaque fois il y a une photo et un texte court, ça vaudrait pas le coup d'utiliser [`<figure>`](https://developer.mozilla.org/fr/docs/Web/HTML/Element/figure) et `<figcaption>` ?


I just mean that "engine" makes no sense for an alarm definition. I suggest that we have two keys under metric_collector: "alarms" with the actual alarm definitions, and "filter" with just the alarm filter definition. And the "engine" would be "afd" in the alarm filter definition.


Missing `let`?


2782485_HybridModel (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Sure.


Solves issue #5


Should not the increment be inside if - if we don't use it why increment?


Comme pour les `project-card`, des `<figure>`, non ?


Thanx a lot then :)


The labelling should not be at this level. It should be at the afd_alarm level in your structure.


Agree, thanks!


添田です。
良いですね。同じ表示処理でも書き方は色々あります。
是非、積極的に色々な機能を使ってみてください！


yes policies are model driven under aggregator.


Тут надо возвращать ошибку, возвращенную из vm_insert_page


Collaborator:
Corresponding review in collaborator has been deleted.


添田です。
文字による比較を実施したいので、aではなく"a"もしくは'a'ですね。


Just commited a patch on master v1.2 that adds the following possibilites:
```
--skip-deletion=initiator
--skip-deletion=target
--skip-deletion=initiator,target
```

As far as I understand your use case, you won't need an extra ACL patch, although you may disable it using the config file if not used.


yes, I cling to the new "alarm/triger" or something like that for top level, and have basically just aggregations of triggers [alarms] in filters?


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=29)


添田です。
こういうのは、良いですね！自分で学習が楽しくできるよう、色々やってみてください。


Solves issue #11


Can you raise a separate issue for that?


添田です。
ここの処理に間違いは無いのですが、課題として1個当たりの値段を出していただきたいので、
そちらを実装してみてください。


And work only in case of GTT. I'll try.


(ios) Add mandatory iOS 10 privacy description


if number of members in rows is less than max_threads then line 79 will make number of chunks equal to 1.


Is there any reason why `IS NOT` is not applied to booleans ?

I am wondering why the following code is not present:
```js
if (columnValue == false) {
  return new ParameterizedSQL(sqlExp + ' IS NOT false');
}
if (columnValue == true) {
  return new ParameterizedSQL(sqlExp + ' IS NOT true');
}
```

As a `null` value is considered falsy.


TeamCity Platform Services :: Environment Manager :: Test Server [Build 252](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35415&buildTypeId=PlatformServices_EnvironmentManager_RunTests) is now running


TeamCity Platform Services :: Environment Manager :: Test Server [Build 253](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35412&buildTypeId=PlatformServices_EnvironmentManager_RunTests) is now running


Yes!  For starters, full image support wouldn't be needed.  Small things like fringe bitmaps would be nice.


ESta nuneva frase no  me mola nada quiza es mejor meter


添田です。
この処理は掛け算の結果を受け取っていないので意味が無いですね。
次の計算で同じ事をやってますので、無くても大丈夫ですよ。


typo


Это не поправляла.


TeamCity Platform Services :: Environment Manager :: Test Server [Build 252](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35415&buildTypeId=PlatformServices_EnvironmentManager_RunTests) outcome was **FAILURE**
Summary: Build Error (new) Build time: 00:01:44


添田です。
こちらは、
　echo $sum.'<br>';
が良いですね。


relate to #26


s/Events/Entities


Для этого метода добавила такой коммент

Что до проверки эекпектед-выражений... Много вопросов к ним у меня)
Я далеко не всегда могу понять - почему оно имеет такой вид)
Пока не покрывала


添田です。
間違いではないのですが、こちらの課題でやっていただきたいのは、１つの変数にAを30個入れる事でした。
なので、$numにAが30個入った状態を実現してみてください。


учла - переселила пару тестов в классы для вариантов - когда тесты и не должны падать


TeamCity Platform Services :: Environment Manager :: Test Server [Build 253](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35412&buildTypeId=PlatformServices_EnvironmentManager_RunTests) outcome was **SUCCESS**
Summary: Tests passed: 523 Build time: 00:04:21


Такие тесты вынесены отдельно - в класс MethodCalledOnEntityWithInvalidLocatorFailsOnTest
Цель - отделить то, что работает точно не так как нам надо


поправила


my god....


添田です。
ここはひっかけ問題なのですが、100より小さくなるまでなので、
　$num>=100
が条件になります。

基本的な処理はきちんと組めていますね！


свои todo с вопросами  про то - где cause и почему его нет - поубирала

глубины глубин - не понимаю
не понимаю - почему так


添田です。
ここのコメント良いですね！
配列の番号が0から始まるというのは、非常に重要なので忘れないでください。


глянь в нашем файлике - где ты комментил мне - там есть линки


This is a first test commit


I think it should be '@if $enable-shadows' instead of '@if $enable-rounded' on line 20


I was being an idiot. I hadn't installed permstruct in Python 3. It is working now. It takes about the same time on `python3 examples/classical_from_Kuszmaul/successful/ex10/ex10.py`, a few seconds, and gets the same number of valid rules. There is less death by overlap which is good. Look forward to seeing if we can fix the bug that would allow us to prune more.

@MurrayT mentioned that instead of using `set(c.down.keys())` in python2 we can use `c.down.viewkeys()`


报错信息？


there is a typo in comment message, there should be "comment" instead of "command"


Uhm you want to modify the first one instead, no? ;)


添田です。
良いですね！2/3/5/7はバラバラにチェックしても良いのですが、
一括で処理できる様にロジックを組んだんですね！


@slyr91 I realize what I did.  I had merged this code with ours, which includes a reading a config file to set the port. Because we don't know the port until you get inside the main method the port binding fails.


添田です。
ここに関してですが、このif文はループの度に実施されてしまいます。
そのため、『その他』が何度も出力されるのではないでしょうか。

その他は、このWhile文を抜けた後に1回だけ表示すると良いですよ。


I think we should modify the cmake script to rename them.


When try to make quick report from Statistic gramplet, get this:
```
95585: ERROR: grampsapp.py: line 140: Unhandled exception
Traceback (most recent call last):
  File "/home/vantu5z/git/gramps/gramps/gui/widgets/grampletpane.py", line 677, in on_button_press
    handle)
  File "/home/vantu5z/git/gramps/gramps/gui/plug/quick/_quickreports.py", line 196, in run_quick_report_by_name
    handle, report, container=container, **kwargs)
  File "/home/vantu5z/git/gramps/gramps/gui/plug/quick/_quickreports.py", line 287, in run_report
    d.open("")
  File "/home/vantu5z/git/gramps/gramps/gui/plug/quick/_textbufdoc.py", line 160, in open
    DisplayBuf(_('Quick View'), self, modal=True)
  File "/home/vantu5z/git/gramps/gramps/gui/plug/quick/_textbufdoc.py", line 58, in __init__
    last_managed_window = document.uistate.gwm.window_tree[-1]
IndexError: list index out of range
```


Jezyk!


Jezyk


@cstockloew This service call matches, and it shouldn't according to instance level restrictions on the profile:
https://github.com/universAAL/security/blob/master/security.authorisator.delegation/src/main/java/org/universAAL/security/authorisator/delegation/DelegationService.java#L98


Co mowi nazwa tej funkcji?
musi byc cos znaczacego, np calculateExcise


添田です。
おしいです！ここのif文では$typeの値をチェックしてください。
　if ($type == true) {
もしくは
　if ($type) {
って感じですね。
いずれも同じ処理です。


spacje i format


Это в каких браузерах работает? Пользователи этого сервиса не очень продвинутые.


TeamCity Platform Services :: Environment Manager :: Test Server [Build 254](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35421&buildTypeId=PlatformServices_EnvironmentManager_RunTests) is now running


Fixed with your suggestion. Thanks @jeef3 !


添田です。
あと、if文の中ですが、trueの場合に2乗していただきたいので、ここが$c * $cで、
elseの方が$cになりますね。


TeamCity Platform Services :: Environment Manager :: Test Server [Build 255](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35418&buildTypeId=PlatformServices_EnvironmentManager_RunTests) is now running


What are you doing?
You didn't even tranversed the list and you are just printing

> print self.head.data # this is wrong!

Please correct it.
If you didn't understood . ping me!


Justify this function?


添田です。
ここでtrueをreturnしていただければ、完了ですｗ


Mozna to skrocic i od razu przy 47 linijce odjac cost


2782485_HybridModel (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1197 of 1197 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-36.13%25-green.svg)


To samo co wyzej


@remicollet can we do a release please (if you haven't heard anything bad) ?


Actually this line came from the original repo, but I tried removing it and using as the [doc shows](https://github.com/seattlerb/minitest#writing-extensions) and it will end up using **both** reporters.


scaladoc/javadoc (might be implemented in .java)


Link to Paradox?


You're in gtt_table_clause, you already had a GLOBAL TEMPORARY TABLE.


TeamCity Platform Services :: Environment Manager :: Test Server [Build 254](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35421&buildTypeId=PlatformServices_EnvironmentManager_RunTests) outcome was **FAILURE**
Summary: Tests failed: 6, passed: 517; build Error Build time: 00:04:29
### Failed tests
```
SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to set schedule tag to "247" to it and its instances too: should return a list of AutoScalingGroup changed that cont: <no details avaliable>

SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to set schedule tag to "247" to it and its instances too: should return a list of ChangedInstances changed that cont: <no details avaliable>

SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to set schedule tag to "247" to it and its instances too: should set schedule tag for the target AutoScalingGroup: <no details avaliable>

SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to set schedule tag to "247" to it and its instances too: should not set schedule tag for any EC2 instance: <no details avaliable>

SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to reset the schedule tag to empty: should set the AutoScalingGroup schedule tag to empty: <no details avaliable>

SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to reset the schedule tag to empty: should set the AutoScalingGroup Instances schedule tags to empty: <no details avaliable>

```


Wow Much correct Such validated code


TeamCity Platform Services :: Environment Manager :: Test Server [Build 255](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35418&buildTypeId=PlatformServices_EnvironmentManager_RunTests) outcome was **FAILURE**
Summary: Tests failed: 6, passed: 517; build Error Build time: 00:04:05
### Failed tests
```
SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to set schedule tag to "247" to it and its instances too: should return a list of AutoScalingGroup changed that cont: <no details avaliable>

SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to set schedule tag to "247" to it and its instances too: should return a list of ChangedInstances changed that cont: <no details avaliable>

SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to set schedule tag to "247" to it and its instances too: should set schedule tag for the target AutoScalingGroup: <no details avaliable>

SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to set schedule tag to "247" to it and its instances too: should not set schedule tag for any EC2 instance: <no details avaliable>

SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to reset the schedule tag to empty: should set the AutoScalingGroup schedule tag to empty: <no details avaliable>

SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to reset the schedule tag to empty: should set the AutoScalingGroup Instances schedule tags to empty: <no details avaliable>

```


This is probably not safe either since you can't guarantee that g_mu is non-zero at this point...


@2m good, only some minor comments for follow up


Ok, will do, later today.


Is/was this confirmed that it exists? Today I see [it does on Trusty and Xenial but not on Wily](http://packages.ubuntu.com/xenial/liburdfdom-headers-dev).


I think the only way to go, unless you want just a factor, is to add an additional internal flag "mg_set_mu_set", which is triggered when MGSetup2KappaMu is parsed...


![](https://github.trello.services/images/mini-trello-icon.png) [test](https://trello.com/c/GkM4fRv7/1-test)


TeamCity Platform Services :: Environment Manager :: Test Server [Build 256](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35425&buildTypeId=PlatformServices_EnvironmentManager_RunTests) is now running


Oh no, I forgot something.
Fixed by editing [this line] (https://github.com/Acquized/ProjectRetile/blob/master/src/main/java/com/github/acquized/retile/i18n/I18n.java#L33) in Commit fcc7d77. [**Please download `Pre Release b` and try again.**](https://github.com/Acquized/ProjectRetile/releases/tag/v1.0.0-PRERELEASEb) Also, please submit a `Issue` and not a Comment on a Commit. Thanks for the Bug Report.


添田です。
間違って無いですが、斬新ですねｗ


@Higginbottom @kslong @smangham c.f. our discussion the other day -- code now only indents if you run make indent.


TeamCity Platform Services :: Environment Manager :: Test Server [Build 257](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35428&buildTypeId=PlatformServices_EnvironmentManager_RunTests) is now running


It won't match `1.1`, is it the expected behaviour?


is this the best way to do this? i think the regex should be a character whitelist versus stripping specific stuff, e.g. `/[^a-z0-9_-]/g`.


I don't think so, @frederikbosch use `^1.0`?


Yep.


Great 👍


TeamCity Platform Services :: Environment Manager :: Test Server [Build 256](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35425&buildTypeId=PlatformServices_EnvironmentManager_RunTests) outcome was **SUCCESS**
Summary: Tests passed: 523 Build time: 00:04:00


TeamCity Platform Services :: Environment Manager :: Test Server [Build 257](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35428&buildTypeId=PlatformServices_EnvironmentManager_RunTests) outcome was **SUCCESS**
Summary: Tests passed: 523 Build time: 00:04:02


@hanxu317317 是的，你可以看我的profile。


@matejhof don't forget to circulate this info among @robotology/icub-support-team in order to get the remaining robots equipped with forearms v2 updated 😉


Wow


Хитренький! Ну уж нет, упрощать себе жизнь таким образом — это недостойно настоящего джедая. А если завтра будет новый файлик, а в нём новый жанр?.. Надо чтобы фильм обращался к своему владельцу (коллекции) и спрашивал, бывают ли такие жанры.


Collaborator:
Corresponding review in collaborator has been deleted.


+My name is Jyothi


not parsing, stripping


Ini Pengetikan Komentar


Good one. Many people don't know about this.


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=30)


Fixes issue #8


Избыточно остроумно. Всё равно же в `post_process` они по одному обрабатываются. Лучше не усложнять а так и написать:
```ruby
@link = movie[:link]
@year = movie[:year].to_i
# ...и т.д.
```
Кстати, если Ruby современной версии (должен быть! 2.1 минимум, лучше 2.2-2.3), то можно вот так (называется keyword arguments):
```ruby
def initialzie(link:, title:, year: .....)
  @link = link
  @year = year.to_i
end
```
(в такой метод можно передать по-прежнему хеш с ключами-символами, и руби сам его распакует в кучу переменных)


you're right, you *might* just get away with this


![](https://github.trello.services/images/mini-trello-icon.png) [Автодополнение локации не должно зависеть от регистра](https://trello.com/c/JtiXfv0X/7--)


![](https://github.trello.services/images/mini-trello-icon.png) [Автодополнение даты не должно зависеть от регистра](https://trello.com/c/9Ts6gydg/8--)


Esta nueva rama voy a ver como funciona


It's not related to the fact we have an SSL certificate, it's only because we host this website on github, which doesn't support SSL on their gh-pages project. As such, we need to use `http` all the time: https won't work, unless we decide to host it somewhere else and handle the certificates ourselves.


Метод лучше читается, если сначала проверяются предусловия, а потом выполняется реальная работа:

```ruby
  unless ...
    raise ...
  end
  # тут else уже не нужен!
  genres.include?(genre)
```

Конструкция наверху может быть переписана например так:
```ruby
raise(....) unless ...

# или так: хотя не все считают это хорошим стилем, но я — да.
GENRES.include?(genre) or raise ....
```
Моя статья про этот последний вариант: http://zverok.github.io/blog/2016-02-23-control-flow.html


You just broke our production app with this "fix". At least bump your minor version instead of pushing it in a patch.


EMS (brianlball) - i386-Windows-7-VisualStudio-12: OK (2316 of 2503 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-92.53%25-yellow.svg)


Лучше без скобок


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=31)


А если `filter(director: 'Francis Ford Coppolla)` или ещё что-нибудь? Хорошо бы более обобщённое решение, как в `sort_by`. И ещё:
* `reduce` тут будет красивше, чем последовательность `select!`
* хорошо бы сразу предусмотреть следующее:
  * что если фильтров несколько?
  * фильтры-паттерны: `year: 1998..2001, director: /coppolla/i` (посмотри метод `===` для этого)


Perhaps point out that these need to be added to `env_keep` in `/etc/sudoers` too?


also all the repos i'm using this in are private and there's much darker magic going on in those

```js
const rects = Array.from(range.getClientRects())
const container = range.commonAncestorContainer
const doc = range.startContainer.ownerDocument
const sc = range.startContainer, so = range.startOffset
const ec = range.endContainer, eo = range.endOffset

const first = sc.nodeType === 3 ? sc :
  sc.childNodes[so] || (!so ? sc : h.nextSkippingChildren(sc))
const pastLast = ec.nodeType === 3 ? h.nextSkippingChildren(ec) :
  ec.childNodes[eo] || h.nextSkippingChildren(ec)

const set = new Set
const w = doc.createTreeWalker(doc, NodeFilter.SHOW_ALL)
for (w.currentNode = first; w.currentNode !== pastLast; w.nextNode()) {
  if (w.currentNode.nodeType === 1) set.add(w.currentNode)
}
for (w.currentNode = first; w.currentNode !== pastLast; w.nextNode()) {
  if (w.currentNode.nodeType !== 1 || set.has(w.currentNode.parentNode)) continue
  for (const r of w.currentNode.getClientRects()) {
    for (let i = rects.length; i--;) {
      const l = rects[i]
      if (l.top !== r.top || l.bottom !== r.bottom || l.left !== r.left || l.right !== r.right) continue
      rects.splice(i, 1)
      break
    }
  }
}
return rects
```


Made some changes inside `restartApp` function, for click on tabs.


the logging level have to be WARNING, not DEBUG here


@cznewt prefers singular :) I don't mind too much. Consistency is always good.


I don't know if you @ooesili still do Go, but I ran into an issue that involves target and/or directory names with space in them. I would just comment here instead of opening an issue, as you might remember I don't like leaving issue open.

- `$*` should be `"$@"` to properly pass each argument to `qfi`, the current one would split those by spaces, which is not what we want.
- L5, `$1` should be wrapped by double-quotes for target name with spaces.

This is only for this wrapper, I don't have other shells.


Missing f option in tar command. Should have been
tar xzf jdk-8u74-linux-x64.tar.gz


![](https://github.trello.services/images/mini-trello-icon.png) [Let user log in with username or email](https://trello.com/c/QfdKxjeJ/111-let-user-log-in-with-username-or-email)


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=32)


![](https://github.trello.services/images/mini-trello-icon.png) [Add message after register successful](https://trello.com/c/IYWdrOwU/112-add-message-after-register-successful)


Changed


uhh...no spell ID and no comment. Guessing you didn't get this one in on this comment, use an amend when you add him.


Fixes issue #10


im not using this repo anymore. I got common device tree!


А обобщённое решение? (`send` пригодится!)
И, к слову, даже если бы оставлять вот такое необобщённое — то много раз повторённая конструкция
```ruby
@movies
        .each_with_object(Hash.new { 0 }) { |m, stats|  (something).each { |name|stats[name] += 1 } }
        .sort
```
...должна сразу интуитивно требовать вынесения и обобщения куда-то ;)


should be: tar xzf ...


Initial commit for Sonarr


See: https://github.com/bruno12mota/graphql-nodejs/pull/2


this is horrible

oh well, at least you have a very similar coding style.

i've used a terrible promise throwing catching thing that i should write about but someone's probably already written about it.


You kept the list ID's in order at least, but within each group using the textfx sort tool would be optimal, because then the whole thing will be by primary key here (list id, then spell id).


```
return fetch()
  .catch(() => {throw 'forget about this error'})
  .then(res => blah)
  .catch(e => { if (e !== 'forget about this error') throw e })
```


Roman numerals should never be in lower case. yes I just nitpicked. `IV` or `4`, don't care which. but `iv` just triggers me as does `iii`


Collaborator:
Corresponding review in collaborator has been deleted.


Yes. I meant this code will work only in needed case and not for all tables.


there's already an `$enable-shadows` check, if you use `@include box-shadow();`


Added Spam bypass


I mean, look at the casing in all the entries before the ones you add. That OCD of mine compels me to nitpick it for nto matching 😢


Added commands for spammer


testing


Why put NULL for guids?


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=33)


Okay, no more compile errors now, but a broken `.so` instead:

```
…/php: symbol lookup error: …/php-ext/http.so: undefined symbol: uidna_IDNToASCII
```


This really can have no influence on play (other than random effects on compiler efficiency), so I doubt this should be run through fishtest.

I also doubt that the maintainers will accept this change, since here and in many other places Stockfish simply relies on the GUI doing the right thing (i.e. adhering to the UCI protocol). But I'll leave that to the maintainers.


what engine has anything to do with the data model of alarming? This is implementation specific.


Strange class name for single choice set :)


Poorly done. NULL values will be changed to 0. In this case it is better not to be lazy and use the
SET @GUID = <value>;

Плохо сделано. NULL значения будут изменены на 0. В этом случае лучше не полениться и использовать
SET @GUID = <значение>;


Wooops! Fixed by a0e9f5fab6c5f55cd1b874654d488d14caeed4c4


Turul should have 2 lists. He'll also need a mob script both to handle his list swap and some functions related to his casts. I'll help the script end of it when the rest is done.
```sql
INSERT INTO `mob_spell_lists` VALUES ('Turul', 163, 157, 1, 255); -- Aero 4
INSERT INTO `mob_spell_lists` VALUES ('Turul', 163, 167, 1, 255); -- Thunder 4
INSERT INTO `mob_spell_lists` VALUES ('Turul', 163, 168, 1, 255); -- Thunder 5
INSERT INTO `mob_spell_lists` VALUES ('Turul', 163, 186, 1, 255); -- Aeroga 3
INSERT INTO `mob_spell_lists` VALUES ('Turul', 163, 196, 1, 255); -- Thundaga 3
INSERT INTO `mob_spell_lists` VALUES ('Turul', 163, 197, 1, 255); -- Thundaga 4
INSERT INTO `mob_spell_lists` VALUES ('Turul', 163, 359, 1, 255); -- Silencega
-- At lower HP Turul will start to cast additional spells
INSERT INTO `mob_spell_lists` VALUES ('Turul_lowHP', 164, 157, 1, 255); -- Aero 4
INSERT INTO `mob_spell_lists` VALUES ('Turul_lowHP', 164, 158, 1, 255); -- Aero 5
INSERT INTO `mob_spell_lists` VALUES ('Turul_lowHP', 164, 167, 1, 255); -- Thunder 4
INSERT INTO `mob_spell_lists` VALUES ('Turul_lowHP', 164, 168, 1, 255); -- Thunder 5
INSERT INTO `mob_spell_lists` VALUES ('Turul_lowHP', 164, 186, 1, 255); -- Aeroga 3
INSERT INTO `mob_spell_lists` VALUES ('Turul_lowHP', 164, 187, 1, 255); -- Aeroga 4
INSERT INTO `mob_spell_lists` VALUES ('Turul_lowHP', 164, 196, 1, 255); -- Thundaga 3
INSERT INTO `mob_spell_lists` VALUES ('Turul_lowHP', 164, 197, 1, 255); -- Thundaga 4
INSERT INTO `mob_spell_lists` VALUES ('Turul_lowHP', 164, 208, 1, 255); -- AoE Tornado
INSERT INTO `mob_spell_lists` VALUES ('Turul_lowHP', 164, 212, 1, 255); -- AoE Burst
INSERT INTO `mob_spell_lists` VALUES ('Turul_lowHP', 164, 252, 1, 255); -- AoE Stun
INSERT INTO `mob_spell_lists` VALUES ('Turul_lowHP', 164, 359, 1, 255); -- Silencega
```


I have the same problem https://github.com/robbyrussell/oh-my-zsh/issues/5560


I don't think that 'fs' key can be represented in an alram because it is not a field of the metrics data model. It is a dimension. Dimensions cannot be declared directly as keys in alarm defintions,


Don't think this can be done, since SCS may be inserted in e.g. CP


This does not change the generated code (unless special compilation options are used such as -fshort-enums), so running a test is unnecessary and thus not the best use of resources.


Better. But have you tested the code(!)? Multiple emojis in one message is still not supported.
And the code can be reduces even more.


TeamCity Platform Services :: Environment Manager :: Test Server [Build 258](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35436&buildTypeId=PlatformServices_EnvironmentManager_RunTests) is now running


Looks good! I sent you an invite to the organization, if you want to help from there 😃


it seems this is required for bootstrap see https://issues.jboss.org/browse/WINDUP-1200


This was removed, but it was correct. The warning was for windows developers.


TeamCity OTA+ :: rvi_sota_server :: migrations container [Build 81](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16098&buildTypeId=ota_plus_RviSotaServer_MigrationsContainer) is now running


так это только настройки, а логики под ними никакой нет пока. Просто реализовано чтение настроек пользователя с сервера перископа, и запись их туда. Т.е. эти настройки вляют только на мобильное приложение пока.


![](https://github.trello.services/images/mini-trello-icon.png) [Buton Call to Action in header](https://trello.com/c/lR6zlwl1/14-buton-call-to-action-in-header)


Again no change in the generated code, so not appropriate for fishtest.

The removal of the condition in next_move() did have an effect on time-critical code which could potentially affect play, so a test was useful in that case.


TeamCity OTA+ :: rvi_sota_server :: migrations container [Build 81](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16098&buildTypeId=ota_plus_RviSotaServer_MigrationsContainer) outcome was **SUCCESS**
Summary: Running Build time: 00:01:17


TeamCity Platform Services :: Environment Manager :: Test Server [Build 259](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35433&buildTypeId=PlatformServices_EnvironmentManager_RunTests) outcome was **UNKNOWN**
Summary: Canceled (Snapshot dependency failed: ... Test Client (new)) Build time: 00:00:00


Class into separate file


Done


Do not use magic strings. Add config file or const instead


Do not use magic strings


do not use magic numbers


What are the pros and cons of this proposal in terms of flexibility and ease of use?


@cybrann and @alexkulya I used NULL to automatically generate the @GUID is simpler and faster in my view!


This is why it's red in the diff. I removed it.


TeamCity Platform Services :: Environment Manager :: Test Server [Build 258](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35436&buildTypeId=PlatformServices_EnvironmentManager_RunTests) outcome was **FAILURE**
Summary: Tests failed: 6, passed: 517; build Error Build time: 00:04:14
### Failed tests
```
SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to set schedule tag to "247" to it and its instances too: should return a list of AutoScalingGroup changed that cont: <no details avaliable>

SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to set schedule tag to "247" to it and its instances too: should return a list of ChangedInstances changed that cont: <no details avaliable>

SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to set schedule tag to "247" to it and its instances too: should set schedule tag for the target AutoScalingGroup: <no details avaliable>

SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to set schedule tag to "247" to it and its instances too: should not set schedule tag for any EC2 instance: <no details avaliable>

SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to reset the schedule tag to empty: should set the AutoScalingGroup schedule tag to empty: <no details avaliable>

SetAutoScalingGroupScheduleCommandHandler:: When an AutoScalingGroup named "sb1-in-Test" exists in "Sandbox" account: and I send a command to reset the schedule tag to empty: should set the AutoScalingGroup Instances schedule tags to empty: <no details avaliable>

```


TeamCity OTA+ :: rvi_sota_server :: ci [Build 1429](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16100&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


I thought gender was for male, female, etc. We would need both an animalId and a petId


Currently we use this:

```yaml
fields:
  fs '/var/lib/nova'
```

@cznewt flattened this, but I agree with you it's not necessary.


Names of vars should communicate their purpose


Yeah, this is returning a bool to make sure that the session user exists, and all its values are there (that comment should be uncommented also)


Best not to ignore errors


![](https://github.trello.services/images/mini-trello-icon.png) [Отображать результат ответа сервере удача/фейл](https://trello.com/c/69XWF3NH/11--)


Thank you for your comment. I will fix this soon!)


css


Yes, but the error returned by the user controller is just "Incorrect email or password", not that an error happened (for some reason) while attempting to set the session user.


@Rocky640 FYI: Even an int division can't be converted into a simple bit-shift IMO when it is signed,
see what following code is producing:

```
 int d = -128;
  int f = 128;

  sync_cout << (d / 256) << "   vs. "  << (d >> 8) << sync_endl;
  sync_cout << (f / 256) << "   vs. "  << (f >> 8) << sync_endl;
```
Output:
0   vs. -1
0   vs. 0


I think class name should start with camel case


My bad! D:


SET @GUID = < value >;
( @GUID+1,


that's the same thing as `fetch().then(res => blah, err => undefined)`


Najvise volim `double b` promenljive.


Let me speak from my heart! Looks not so informative. Need colour coding.


and the dark magic is unfortunately mandatory because of abominations like [Range::getClientRects](https://drafts.csswg.org/cssom-view/#dom-range-getclientrects)


Moja omiljena funkcija je `main` funkcija.


2782485_HybridModel (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1748 of 1772 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.65%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.75%25-green.svg)


![](https://github.trello.services/images/mini-trello-icon.png) [ImpactMapping](https://trello.com/c/ij3Swt3o/5-impactmapping)


Just small feedback, that this could be written as a simple if/else, for readability


2782485_HybridModel (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


![](https://github.trello.services/images/mini-trello-icon.png) [Итог](https://trello.com/c/DTojnZBE/6--)


PWD missing?


macAd**d**resses


@chelmuth: here is the fixup


This is a kang of the following commit: https://github.com/phenomarc/device_samsung_i9100/commit/8b1536686a1220ac0c1281f98aceaa734689dbcc


Should add caturae's lists as well. I did those up fully retail in legions trunk so you only have top coy paste and change the list ID.


Surprise tabs


Estou passando dificuldades em utilizar os vetores, quando eu compilo da uns erro loko sem sentido para min, então vou trocar a forma que armazenamos as arestas e os grafos.
Pelo lado positivo, não precisaremos mais perguntar para o usuario quantos Vertices e Arestas ele vai usar, o unico porem é que o algoritmo vai ficar um pouquinho mais complexo, mas acho que a gente consegue se virar ^^


TeamCity OTA+ :: rvi_sota_server :: ci [Build 1429](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16100&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 248, ignored: 3 Build time: 00:11:58
### Failed tests
```
org.genivi.sota.resolver.daemon.PackageCreatedListenerSpec.saves package to database: <no details avaliable>

```


@Zambom , @fbormann e @matheuslins , essa linha está dando erro em 'Create user admin' e está impedindo outros scripts executarem.

Segue o print do erro.
Aparentemente a variavel não está sendo carregada e gera um erro de sintaxe.
![screenshot from 2016-10-21 09-17-53](https://cloud.githubusercontent.com/assets/18018868/19598116/67ebb6f2-976f-11e6-9cd5-6733a6669de7.png)


seems to be failing for me :(


It is your right. However, the code is better not to use NULL in GUID.


While going through this merge, I realised that the final fort.3 (in case of collisions, of course) will have the following two lines
bb_ho5b1_0 5  %xing 0.0
bb_ho1b1_0 5 -%xing 1.5707963268
where of course the placeholder %xing will be properly substituted. I was wondering what happens to someone who simulate collisions, but uses the default .mask file. I guess that the fort.2 will miss these two lenses and SixTrack will abort...

Since the BB implementation is still under discussion/improvemente, I could temporarily change the implementation, such that if sixdeskenv contains a line like "export xing=185", then the two lines in fort.3 are un-commented, otherwise run_six.sh will keep them commented...


done


I'd write "Error loading devices"


Did you notice that when having this feature, we can't switch between 2G and 3G mobile data?


but  I  can not  access https://s3.amazonaws.com/dl4j-distribution/cifar-small.bin  file  How  can I find this dataset?


Flottur, gaman að fylgjast með þessu! Kallinn kominn í angular2!


For #2


I'd write "no space left **for** new device".


@alexkulya Well I've always used and never had problems with this, as I mentioned above is faster in my view because it generates the @GUID automatically or be random.

Anyway, everyone do what you think is best - anything you can do an update on it! The next time I update some database will try to remember it!

:neckbeard:


this might be better handled with Form Validators?


The same thing I said for the JSON in another patch. I think it is better to expand it in multiple lines to make it readable and allow changes to be easy to track.


@vruge Why did your changes introduce a division by zero for this model? Is that really the intended behaviour? It seems to be a hack to enable here `removeSimpleEquations=allAcausal`.


How so?


ანი აქ შემექმნა პრობლემა, ტექსტს როდესაც მარგინებს ვუწერ მარცხნიდან 15 პიქსელზე რომ ვაშორებ ტექსტი ცდება დაბლა მთლიანად ბოქსს ანუ მთლიანად დაბლა ვარდება, 10 პიქსელი მაქვს გაწერილი ახლა რომ არ ჩავარდეს


Do me a favor..change DSP's [line 26](https://github.com/LegionDark/darkstar/blob/8dd250fb3dd8c8fbe6de599e649337798d96a9d9/sql/mob_spell_lists.sql#L26) :
from **`char(20)`**
to **`varchar(30)`**

Some NM names are longer than 20 and if we keep using NM names we'll hit that char limit eventually. varchar type tells mysql to expand as needed and the number becomes a "default display" rather than a hard limitation.


ვიდოები ერთმანეთის გასწვრივ ვერაა რატომღაც :დ


I actually did that in further commits. I still forgot the license header though. I'll add it


the cipher name is [Kuznyechik](https://en.wikipedia.org/wiki/Kuznyechik):
> The name of the cipher can be translated from Russian as grasshopper, however, the standard explicitly says that the English name for the cipher is Kuznyechik (/kʊznˈɛtʃɪk/). The designers claim that by naming the cipher Kuznyechik they follow the trend of difficult to pronounce algorithm names set up by Rijndael and Keccak.


And also, why use the `+` instead of `--` for the flag?


Released.


great changes, many thanks for this.
I immediately tried Google Drive option, it successfully logs on, creates the folder but after that such an exception occurs :

"[INFO] - URL being requested: https://www.googleapis.com/drive/v3/files?fields=id&alt=json
[ERROR] - Exception occurred 'Logger' object has no attribute 'success' "

I see no files under my Google Drive folder.


I've checked and it doesn't seem that `I` is undefined after the loop. It just keeps the last value it had. e.g.:
`for i:=0 to 100 ;
writeln(i);`
will show 100, i.e. the upper limit of the for loop and the last value it was assigned.
Works even with -O4 optimizations in project options (where the variable should have been completely replaced by an %EAX register - at least I'd have expected that) .


TeamCity OTA+ :: rvi_sota_server :: ci [Build 1430](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16122&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


Funny you should say that we don't need an provider object. Because that's exactly where I went as well when thinking this over last night. I think we do move `barge` and `replicas` to the main object.

I'm thinking we get rid of `provider` altogether. The Barge value should tell us all we need to know.


Couldn't get the Functor and Applicative parsing to work. Need to look into it more.


Instead of testing the array length, it is better to have a constant with this value. It makes the intention clearer and the value becomes explicit.


ghe ;-) nice.


@giacombum Sure... and you know how setup your Travis account, right?


Also, this test should be in the beginning of the function. If you already have the maximum amount, return early and alert the user.


This is where the fatal error is being hit, when running a story and it returns input from the user ("go west").

     array 1 1 or 256 0 typecode &+#!Cn

Which fails, because arref->len != len


Is there a special reason for you to make this loop instead of calling `push` on the array? I think it is better to replace the `for` with a `push` and make a similar modification in `remove` (see my comments there).


:cake:


Obozavam ovakve komentare. Bas su opisni, druze : )


TeamCity OTA+ :: rvi_sota_server :: ci [Build 1430](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16122&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **SUCCESS**
Summary: Tests passed: 271, ignored: 3 Build time: 00:10:12


Similar problem of `add`, why don't you use array operations? Use `slice` instead of this loop.


img


Rewrite this in two blocks, the first changes the `macAddresses` array, the other calls `AppService`.


@jkurz  I've flattened `provider` so that it no longer exists; `barge` is now on the top level along with `replicas`.

@mickeyyawn Added `monitored`.


thanks.


Could be named something like verifyPerson.


Could be named something like verifyCheese.


Could be named something like verifySessionFacts.


Tente usar constantes também para tirar números magicos.


Заголовочный файл


the problem is though, that you have to have a `~/.wakatime.cfg` so that the CLI does not exit with Error 102(?). You might as well skip that whole `wakatime-api-key` variable thing and force the usage of `~/.wakatime.cfg`


Could be something like verifySessionFacts.


Use *final* tambem para tipos descritivos.


Could be named something like verifyFactsWithQuery.


@david roble Why did you set WMVHIGH_PRO a height value of 700 pixels and not 720 as per Microsoft specifications ?
Some PS3 trick ?


TeamCity OTA+ :: rvi_sota_server :: ci [Build 1431](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16127&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


See cdf373ac16c5162181e5568eefaa5aac33bf527e


Tente usar um nome mais significativo que só *exception*.


Tente usar um nome mais significativo que só *exception*. Contei também como tratamento de erros apropriado.


This line is throwing the exception that you just caught, it will blow the application. In case of an error we should either return a valid JSON that signalizes an error, or better yet terminate the request with an error, i.e. call `res.sendStatus(500)`.


[usr_id]_**[login]**_duplicate..
Gute Idee!


TeamCity LabKey :: LabkeyModules15.2 :: CDS postgres 9.4 [Build 73](https://teamcity.labkey.org/viewLog.html?buildId=374026&buildTypeId=LabkeyModules152_CdsPostgres93) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:02


If you use the array operations I mentioned earlier, you can remove this `ng-if`.


For you information: I found out why my original (endgame only) patch failed badly. In pawns.cpp there is the do_king_safety function, which calculates the endgame score as -16 * minKingPawnDistance. If this is correct, I expect your tuned endgame value to get close to 0. For the midgame, the result may be a little bit different, but I think also there it is at least partly covered.


Duplicate line


Thanks, good catch.


Related note to that - I don't think PR branch name is that important. What is important is the titles of the PRs and making sure to `ref #issue` back in a comment. Maybe make this section talk about that instead?

The wip and `-ktoso` seem to be to be a relict of having many people in the same repo - like akka team sometimes worked in the past.


Same here. See my comments below.


good names yeah 👍


And here.


Same here.


Bah fez bastante coisa haha show!


TeamCity OTA+ :: rvi_sota_server :: ci [Build 1431](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16127&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Tests failed: 2 (2 new), passed: 236, ignored: 3 Build time: 00:14:01
### Failed tests
```
org.genivi.sota.core.UpdateServiceSpec.upload spec per device: <no details avaliable>

org.genivi.sota.resolver.daemon.PackageCreatedListenerSpec.saves package to database: <no details avaliable>

```


TeamCity OTA+ :: rvi_sota_server :: ci [Build 1432](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16144&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


Good morning. Your curl version is currently at version 7.47. Could you please update it to 7.50.3? I need to link statically and the current version is throwing an error message, while the new one seems to be fixed. Thanks


Here I move some exit logic out one layer of nesting so as to correctly match the sequence of operations in the original. With this and the next commit I have completed my translation from perl to javascript. I've gained some respect for this twisted logic for it exploited unique features of perl such as evaluation context and default variables and replaced them with obscure features of javascript specifically currying the regex replacement function and inventing my own capture substitution notation in order to match the compact structure of the original.

It took me three days to get to here including one false start I haven't checked in. I mentioned in a previous commit that I don't like this code. But right now I'm feeling a sense of accomplishment having exercised my skills as a translator. [Le Ton beau de Marot](https://en.wikipedia.org/wiki/Le_Ton_beau_de_Marot)


tente tirar operadores ternarios


Great work with opcodes :D


Hi, just heads up on the extraneous whitespace/tab character in `models[i].usb_vendor` (there's more).


Simple merge.


Onde tem operador ternario?


Crap, you're right. I left that in there from when I was messing with `exec` and `system`.


赞


EMS (brianlball) - Win64-Windows-7-VisualStudio-12: Tests Failed (2210 of 2503 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.29%25-red.svg)


no no no, why you do that?


Updated code with review comments.
Removed code for data frames and added extra parameter to accept pattern to be used to split String.
Please review again. Thanks!


TeamCity OTA+ :: rvi_sota_server :: ci [Build 1432](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16144&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 248, ignored: 3 Build time: 00:08:22
### Failed tests
```
org.genivi.sota.core.ImpactResourceSpec.calculates impact for a blacklist item: <no details avaliable>

```


add revise1


We've had quite a few users who went to advanced right away, started messing with settings they didn't fully understand and then blamed Cura for "making bad prints", whereas it was actually a user error.
I agree with sedwards that we need to nudge people slightly into the "simple" mode a bit more.
Having heard those arguments, do you still think the same @nickthetait?


@DavisMiculis  I know about those options. I was wondering if the current condition is a bug or 'by design'?


whoops.  Good catch.  as400ssha1 was stomped on.


modified form local computer.


no need for slicing here. `buf.length - 2`


code review ok!


This was to follow the original instruction where the object was to be called without the 'new' operator. Do you want me to take a different approach or is did I misunderstand the original intent?


Yes, that would be closer to real conditions, but on the other hand, we might miss a fail then if typealias filtering stops working.


ok


Sorry Stephen, looks like y f*cked up. Please see: https://github.com/libuv/libuv/pull/1102


TeamCity Platform Services :: Environment Manager :: Test Server [Build 260](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35457&buildTypeId=PlatformServices_EnvironmentManager_RunTests) is now running


Breaks GraphicImageRenderer and MediaRenderer.


Thanks @nobuti! 👏


hahaha vlw. Mas tenho que melhorar o código em alguns lugares, fiz meio que só pra ve se ia da certo. Mas deu certo hahaha


ok. It is good idea. I remake it during a weekend.


TeamCity Platform Services :: Environment Manager :: Test Server [Build 260](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35457&buildTypeId=PlatformServices_EnvironmentManager_RunTests) outcome was **FAILURE**
Summary: Build Error Build time: 00:01:55


So is that old bug only revealed with #663? If it's so, I suggest keeping that PR there for a while, and proceed with migration to GTK+3 instead (finally).

I already have most packages done, I think only Pluma and Caja are left.


I agree, then branch name is not important. Nowadays github has good overview of branches anyway.


:smile:


See 3f4bd44592db8, release OTW


@raveit65: and yes, all this GTK+3 stuff soon goes to baremetal on at least one of my machines :smile:


同学可以留下联系方式吗，我现在需要一份这个代码跑通的啊。非常感谢。可以加我微信。18310336918


I should be interger. :)


It's actually pulled in by the very next lines ;)
````
        # Temporary fix for https://github.com/NixOS/nixpkgs/issues/18451
        # Remove as soon as upstream gets fixed - marking it:
        # TODO
        # FIXME
        "i8042"
````


Very nice one. Thanks a lot!


Ok. I will fix it.


aaa


Versão final.


Seems that i forgot this files ;) will fix it next week.


I wasn't challenging you here... more trying to learn :-)

Read the docs, this looks good :+1:


Ah yeah, i messed up a bit with logger and forgot to clean it up, thx for pointing out! , will be fixed today on evening, as for now, comment out all logger.success lines in googleDrive.py


Awesomeness ;)


uiuiiuioi


index.html в ссылке класс inner т.к. внутренняя


![](https://github.trello.services/images/mini-trello-icon.png) [span](https://trello.com/c/QNP9t2Fd/20-span)


главная и магазин это ссылки, не ссылка только последняя, т.к. это страница на которой в данном момент находимся


Идея была следующая: как только появляется заказ, время которого скоро истечет, бросаем текущий и бежим к нему. Потом я столкнулся с тем, что бот может не успеть выполнить брошенный заказ. Поэтому я остановился на варианте, когда мы решаем, какой заказ взять, после выполнения предыдущего.


this is extra? wrong commit?


дать класс


TeamCity Platform Services :: Environment Manager :: Test Server [Build 261](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35460&buildTypeId=PlatformServices_EnvironmentManager_RunTests) is now running


onHover and offHover are almost exactly the same; how could we DRY this out?


аналогично пред странице до этого места


let's DRY this if/else statement out too.


этот section удалить он лишний


Versao Final.


обертку можно удалить


this is broken, '?' and '&' are now added twice


лучше slogan или promo


этот заголовок такой же по стилю как подзаголовки в фильтре и подзаголовке слева улчше им всем дать один общий класс


@chelmuth: please add to staging


TeamCity Platform Services :: Environment Manager :: Test Server [Build 261](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35460&buildTypeId=PlatformServices_EnvironmentManager_RunTests) outcome was **SUCCESS**
Summary: Tests passed: 523 Build time: 00:03:55


I digged down a bit and found that out:

Enabling the option for a specific remote:
```
[remote "origin"]
    prune = true
```

Enabling the option as a "catch-all":
```
[fetch]
    prune = true
```

(This has no effect:)
```
[remote]
    prune = true
```


👍 Ship it!


With `yarn` we don't need to prune right?


Just had to comment out one print statement that was printing thousands of lines of output - now the notebook renders on github properly. Got Michele's approval to do this so that the peer reviewers can view our notebook on github!


could all be done in one `npm i` right?


This same change should be reflected in `lib/date_picker/CalendarDay.js`.


TeamCity OTA+ :: rvi_sota_server :: ci [Build 1433](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16151&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


Fixes #4, not #6...


in v2.15.0 now!!


I was trying to isolate all functionality as much as possible.
I found it not a good idea to have to duplicate the string "_slug_preview" over the 2 services because then changing it in the SlugRouter would break the AdminRouteHelper.

It also makes testing the adminroutehelper a bit easier since I can more easily mock whether I'm testing a preview url or not.

 I know not a big deal and I agree I went overboard a bit. Do you think the added complexity of doing it this way is too big?


<!DOCTYPE HTML>

	<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
	<title>I love you</title>

I on

vhvhjvhjvjv


Is it possible to move the `test-utils` into the `__tests__` folder? If there's a default ignore pattern we could use I would really prefer it. Two top level `*test*` directories bothers me 😬


*MORE* 😄


@pdurbin  No. this is a clean up of the file level citation for display in the landing page.


I wrote to lede dev:
_Here to raise your attention to https://github.com/pgid69/bcm63xx-phone projet.

That gui implemented fxs support for some device already supported by
lede/openwrt.

That module work correctly on my device, but to get it working on
openwrt >12 and lede you need to disable CONFIG_SPI_BCM63XX=n  (or at
least mate it to compile as module)

please can you consider to add this project to the feeds?_

and I got this answer:

_You can send PRs to the package feeds here
https://github.com/openwrt/packages
or on the main LEDE git repo https://github.com/lede-project/source

You can send a patch here or a PR on Lede's github to build the spi
driver as a module again or disable it outright if none really needs
that driver anyway (I don't know), and also add these new packages in
default packages for the devices you want.

If it makes sense it will get merged.

You might want to encourage the current package developer to do this, as
he might have not noticed that there is LEDE too now._

What about to include your work into lede?


Tal vez se podría pasar como parámetro solo el TcpClient e internamente obtener el NetworkStream?


I've been going with that pattern on purpose! Less unnecessary whitespace IMO.


je suis vraiment interresser par votre article


Code style: Brackets on new line. Fixed this for you in 0a683ff05e6cf05aaffd0f7ec3296a5661a13b18.


Code style: Indenting with 4 spaces. Fixed this for you in 0a683ff05e6cf05aaffd0f7ec3296a5661a13b18.


Why have you erase constraint_duplicate?
You can also fix build with this commit 19c74de8f6ada4b400120f8f315cd18ef0a03a5f
just add constraint_duplicate in include/linux/perf_event.h in struct perf_event_attr

No?

https://github.com/bizcuite/android_kernel_samsung_smdk4412/commit/19c74de8f6ada4b400120f8f315cd18ef0a03a5f


I'd rather have put this in a more specifically named file, such as `sorting.h`, especially since it is placed in a folder "utils". Oh well.

(Not blocking.)


I also did not manage to create an example code, running in FPC, that leaves the "for" loop counter with some weird value.

*But* various documentation about old Turbo Pascal and Delphi says that the value of the "for" loop counter is undefined after a loop (unless terminated prematurely). E.g. a compiler may perform an optimization to silently perform a "downto" loop instead of upward "to" (only when it can prove that such optimization doesn't change the resulting state). See

* http://courses.cs.vt.edu/~cs3304/Spring04/notes/Chapter-7/tsld026.htm

* https://books.google.pl/books?id=XFaB8rDpUjYC&pg=PA415&lpg=PA415&dq=pascal+for+loop+index+undefined&source=bl&ots=rOsdA5Z1--&sig=qmWa0Z6mBfixCBX3oqYy90OPOkg&hl=en&sa=X&ved=0ahUKEwj_5cD0_OvPAhXBCywKHR5MBHQQ6AEINTAE#v=onepage&q=pascal%20for%20loop%20index%20undefined&f=false

* http://stackoverflow.com/questions/2610900/what-is-the-loop-variable-after-a-for-loop-in-delphi

As for FPC: This was recently discussed in fpc-pascal mailing list in the thread "[fpc-pascal] Using for-loop index variable after loop" : http://lists.freepascal.org/pipermail/fpc-pascal/2016-October/049056.html . Jonas Maebe, one of the compiler developers confirmed that the loop variable should be treated as undefined: http://lists.freepascal.org/pipermail/fpc-pascal/2016-October/049057.html . This was what actually prompted me to add this note to the article:)

And there's an open bug http://bugs.freepascal.org/view.php?id=12508 to actually emit a warning about this.

I don't know whether a related "for" optimization is just not implemented yet in FPC, or whether it's just ultra-difficult to trigger:) The compiler devs didn't say whether such optimization is done *right now*. I guess we could ask, or look in the FPC code:)

In any case, we know that future FPC versions may definitely add such optimization. So it's better to write code with this in mind. And hope that the bug http://bugs.freepascal.org/view.php?id=12508 will be fixed *before* FPC starts to use such optimizations, so we'll get a clear warning in case of undefined behavior:)


@cybrann Nice Job!


Collaborator:
Corresponding review in collaborator has been deleted.


can we change this


what does asdf means


@MauroLuzzatto the 5R1C_ISO_simulator is ready to be tested. Let me know how the results come


awesome


TeamCity OTA+ :: rvi_sota_server :: ci [Build 1433](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16151&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **SUCCESS**
Summary: Tests passed: 261, ignored: 3 Build time: 00:11:16


super !


TeamCity Platform Services :: Environment Manager :: Test Server [Build 262](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35463&buildTypeId=PlatformServices_EnvironmentManager_RunTests) is now running


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=34)


It's here because the function `sort` is in `algorithm` of the standard library.


This also modifies the original vector in `storage.max_print_height_per_extruder`, since you only keep a reference!


Is it possible to have the script in one folder invoke the other (or have both invoke the script if it's in the parent folder)? I don't have a good way of testing it, really.


Oops, this needs to be an array with 3 members, if we don't want any guns, we need to put a 0 here in the first position of the array.   Deleting the weapons line breaks things because the rest of the addon is expecting 3 parameters here and crashing when it only sees 2.


changes


Sure. Just wondering: Wouldn't the enc call itself need this, too? Otherwise the behaviour would be different, wouldn't it?


TeamCity OTA+ :: rvi_sota_server :: ci [Build 1434](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16155&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


Why do you think it doesn't exist for Wily? The page you referenced won't show you any EOL Ubuntu distros.


Oops, this needs to be an array with 3 members, if we don't want any guns, items or backpacks, the array would still need to be 0,0,0

Deleting one of the three numbers breaks things because the rest of the addon is expecting 3 parameters here and crashing when it only sees 2.


TeamCity Platform Services :: Environment Manager :: Test Server [Build 262](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35463&buildTypeId=PlatformServices_EnvironmentManager_RunTests) outcome was **SUCCESS**
Summary: Tests passed: 70 Build time: 00:03:53


(Can take out these quotes and add space after `:`. Not sure why the original code used quotes.)


@fourkbomb


Ok, so extract the route name to a `SlugRouter::ROUTE_PREVIEW` const to reuse it. Testing it would be as easy, just use `$request->attributes->set("_route", SlugRouter::ROUTE_PREVIEW)` before the test. The only downside of this is that you cannot check this before the router matches, so very early in the request flow. The upside — you’re not calling `SlugRouter::match()` multiple times. You could cache the result for each request, btw


Not sure how it would ever come up (OpenBSD?), but might as well fix this `Q` while we're here.


Nice custom adapter 👍


Collaborator:
Corresponding review in collaborator has been deleted.


Sorry for mistake: it's not under AGPLv3+ but under MIT license
(https://gitlab.com/gitlab-org/gitlab-ce/blob/master/LICENSE).
I confised it with Gitorious, which was under AGPLv3+.


Please remove


I'm indenting these, if you don't mind. A line ending in `=` seems broken if you don't. See 5c680b312ba85b0869192cc6b0d684a1ba97c49a.


What is/was Speaker's Square? :P


This will always generate invalid html for radiobuttons!
Take the example design from test: GetParameterGroupDefnTest.rptdesign and you will get:
`<label title="" id="id_paramRadioButtonStatic" for="paramRadioButtonStatic2" +="" "0"="">paramRadioButtonStatic:</label>`

The account creation on eclipse bug is moderated and very slow. I can not reopen the bug or make a comment on 390622.


For some reason GPG signing failed.


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=35)


TeamCity Platform Services :: Environment Manager :: Test Server [Build 263](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35466&buildTypeId=PlatformServices_EnvironmentManager_RunTests) outcome was **UNKNOWN**
Summary: Canceled (Snapshot dependency failed: ... Test Client (new)) Build time: 00:00:01


Fancy!


TeamCity Platform Services :: Environment Manager :: Test Server [Build 264](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35469&buildTypeId=PlatformServices_EnvironmentManager_RunTests) outcome was **UNKNOWN**
Summary: Canceled (Snapshot dependency failed: ... Test Client (new)) Build time: 00:00:00


WTF IS THIS


okay ^^ thanks, i will contact him on his git.


TeamCity OTA+ :: rvi_sota_server :: ci [Build 1434](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16155&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **SUCCESS**
Summary: Tests passed: 272, ignored: 3 Build time: 00:09:07


oh lol!!!!


![Uploading 4.png…]()


Just to be a nitpicker, but if you use start_... as a variable name it gives the feeling that it's a function.
maybe failing_mallocs_enabled is a better one?


TeamCity OTA+ :: rvi_sota_server :: ci [Build 1435](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16157&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


https://en.wikipedia.org/wiki/Iff ;)


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=36)


Can I use java.sql.Time for startTime and endTime ?


But he has not pushed this commit :D


Thanks for adding this! :)


Now that I see this, I'm also very aware that the variable won't be defined in the picoTCP stack itself. Maybe important to mention this in a comment that it should be defined in the main application (in case someone wonders what this awesome CHECK_MEM define does :-)


commentaire


Yes sorry about that i sent out a message about the breaking change.  You have to update your docker-compose.yml to use the new command style.

Lets not any default behaviors, default behavior is for the image to show 'help'


Nice start on that `search-bar` component - right idea


Hi Fourkbomb,

Why have you erase constraint_duplicate? (in Cyanogen Github)
You can also fix build with this commit 19c74de8f6ada4b400120f8f315cd18ef0a03a5f
just add constraint_duplicate in include/linux/perf_event.h in struct perf_event_attr

No?

https://github.com/bizcuite/android_kernel_samsung_smdk4412/commit/19c74de8f6ada4b400120f8f315cd18ef0a03a5f


Please don't run non-functional patch in the framework.   The only thing it will do is hog up resources that are needed for functional patches.


Why this change?


Adapted to Mac


Does the updated notification remove/turn off the LED from the original notification? If it does not, then you could block the LED on updated notifications. Another option may be to run a check to see if the LED from the original notification is still active, if it is, then the updated notification LED should not be blocked.


@SubJunk I was on the way to document it, as it's a missing part, but when i saw that you did create it maybe it's better to have your own words for that ?
Can you give a definition for posterity ? :wink:


This class is used in the Analysis


As this isn't part of the th:fragment, this script isn't actually used by thymeleaf. Secondly, JQuery is already imported in JS util fragment.


Made new PR https://github.com/codecasts/nusoap-php7/pull/3 for safer change discussed


TeamCity Platform Services :: Environment Manager :: Test Server [Build 265](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35472&buildTypeId=PlatformServices_EnvironmentManager_RunTests) is now running


@n-multimedia  wenn og_group rausfällt, ist das $values-array aber auch überflüssig oder? versteh zwar nicht, warum das so was bringt, abre wenns funktioniert, is gut..


Were you going to submit a pull request with this? It's a more complete fix than mine.


Why?


Collaborator:
Corresponding review in collaborator has been deleted.


TeamCity Platform Services :: Environment Manager :: Test Server [Build 266](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35475&buildTypeId=PlatformServices_EnvironmentManager_RunTests) is now running


TeamCity OTA+ :: rvi_sota_server :: ci [Build 1435](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=16157&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Tests failed: 2 (2 new), passed: 245, ignored: 3 Build time: 00:08:22
### Failed tests
```
org.genivi.sota.device_registry.GroupsResourceSpec.match devices to an existing group: <no details avaliable>

org.genivi.sota.device_registry.GroupsResourceSpec.updating system info for device updates group membership: <no details avaliable>

```


TeamCity Platform Services :: Environment Manager :: Test Server [Build 265](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35472&buildTypeId=PlatformServices_EnvironmentManager_RunTests) outcome was **SUCCESS**
Summary: Tests passed: 70 Build time: 00:03:58


Working towards issue #12


Could you add some example how to run eg `survey.hash` runner? I can't wrap my head around it.


This forces the user to choose a-d, and prevents accidents from happening such as a misinput.


TeamCity Platform Services :: Environment Manager :: Test Server [Build 266](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=35475&buildTypeId=PlatformServices_EnvironmentManager_RunTests) outcome was **SUCCESS**
Summary: Tests passed: 70 Build time: 00:03:52


Can concur, I'll just get rid of them


@alexrothenberg: Any idea when we are going to merge the PR #84.


`SQL_DB` depends on _easyloggingpp_ and should be linked to _sqlite3_. That's why the build fails.


This was intentional to have method overloaded. Is it better not to overload methods?


Ya'll are ridiculous 😆


@ThePreviousOne @DSalt @CutsAlexander @Satok16 @Kruton @DSandler @JHam @WangYing1015 @BJBeare @DmitriPlotnikov @RomainGuy @KMonsen @LeonScroggins @JMTrivi @Roubert @Erji44 @Emeles16 @RYPervenche @FahrStuhl @Yassine987

Just to keep your forks' licensing correct, maybe you @all may want to merge this also.


Glad I could interrupt this commit with a diversion of reflection upon the discipline. 😄


TeamCity Code :: 1. Development :: CMS :: Features [Build 62](http://mp-ci.centralus.cloudapp.azure.com/viewLog.html?buildId=10040&buildTypeId=Code_Development_Cms_Features&guest=1) is now running


`GIT_EXECUTABLE` is empty before the _Git_ package is found! (That's why the build fails)


TeamCity Code :: 1. Development :: CMS :: Features [Build 62](http://mp-ci.centralus.cloudapp.azure.com/viewLog.html?buildId=10040&buildTypeId=Code_Development_Cms_Features&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:27


Never mind. I thought there was an `if (!corsFilterEnabled) {}` and then `if (corsFilterEnabled) {}` so I was meaning to rewrite it as `if (corsFilterEnabled) {} else {}`, but now I see they are not at the same level.