@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-borg.localrole/13/violations
```
borg/__init__.py:0:1: C101 Coding magic comment not found
borg/localrole/__init__.py:0:1: C101 Coding magic comment not found
borg/localrole/__init__.py:0:1: I001 isort found changes, run it on the file
borg/localrole/__init__.py:14:80: E501 line too long (90 > 79 characters)
borg/localrole/__init__.py:15:43: E127 continuation line over-indented for visual indent
borg/localrole/__init__.py:15:80: E501 line too long (89 > 79 characters)
borg/localrole/config.py:0:1: C101 Coding magic comment not found
borg/localrole/default_adapter.py:0:1: C101 Coding magic comment not found
borg/localrole/default_adapter.py:0:1: I001 isort found changes, run it on the file
borg/localrole/factory_adapter.py:0:1: C101 Coding magic comment not found
borg/localrole/factory_adapter.py:0:1: I001 isort found changes, run it on the file
borg/localrole/factory_adapter.py:15:63: D001 found directlyProvides replace it with zope.interface.provider
borg/localrole/factory_adapter.py:65:13: D001 found directlyProvides replace it with zope.interface.provider
borg/localrole/factory_adapter.py:66:80: E501 line too long (80 > 79 characters)
borg/localrole/factory_adapter.py:78:13: D001 found directlyProvides replace it with zope.interface.provider
borg/localrole/factory_adapter.py:89:0: P102 docstring does contain unindexed parameters
borg/localrole/interfaces.py:0:1: C101 Coding magic comment not found
borg/localrole/interfaces.py:0:1: I001 isort found changes, run it on the file
borg/localrole/interfaces.py:5:3: Q000 Remove bad quotes.
borg/localrole/interfaces.py:9:3: Q000 Remove bad quotes.
borg/localrole/setuphandlers.py:0:1: C101 Coding magic comment not found
borg/localrole/tests.py:0:1: C101 Coding magic comment not found
borg/localrole/utils.py:0:1: C101 Coding magic comment not found
borg/localrole/utils.py:0:1: I001 isort found changes, run it on the file
borg/localrole/utils.py:25:9: T001 print statement found.
borg/localrole/utils.py:25:23: Q000 Remove bad quotes.
borg/localrole/utils.py:25:24: S001 found %s formatter
borg/localrole/utils.py:35:27: P002 found "hasattr", consider replacing it
borg/localrole/workspace.py:0:1: C101 Coding magic comment not found
borg/localrole/workspace.py:0:1: I001 isort found changes, run it on the file
borg/localrole/workspace.py:9:49: D001 found classImplements replace it with zope.interface.implementer
borg/localrole/workspace.py:20:9: Q000 Remove bad quotes.
borg/localrole/workspace.py:21:18: Q000 Remove bad quotes.
borg/localrole/workspace.py:24:80: E501 line too long (82 > 79 characters)
borg/localrole/workspace.py:25:80: E501 line too long (81 > 79 characters)
borg/localrole/workspace.py:31:80: E501 line too long (90 > 79 characters)
borg/localrole/workspace.py:32:17: S001 found % formatter
borg/localrole/workspace.py:75:42: D001 found classImplements replace it with zope.interface.implementer
borg/localrole/workspace.py:77:15: D001 found classImplements replace it with zope.interface.implementer
borg/localrole/workspace.py:111:80: E501 line too long (99 > 79 characters)
borg/localrole/workspace.py:119:0: P102 docstring does contain unindexed parameters
borg/localrole/workspace.py:247:40: D001 found directlyProvides replace it with zope.interface.provider
borg/localrole/workspace.py:248:13: D001 found directlyProvides replace it with zope.interface.provider
borg/localrole/workspace.py:249:13: D001 found directlyProvides replace it with zope.interface.provider
borg/localrole/workspace.py:355:17: Q000 Remove bad quotes.
borg/localrole/workspace.py:358:34: Q000 Remove bad quotes.
borg/localrole/workspace.py:367:16: P002 found "hasattr", consider replacing it
borg/localrole/workspace.py:403:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
borg/localrole/workspace.py:403:29: Q000 Remove bad quotes.
borg/localrole/workspace.py:424:80: E501 line too long (80 > 79 characters)
borg/localrole/workspace.py:428:80: E501 line too long (84 > 79 characters)
borg/localrole/workspace.py:431:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
borg/localrole/workspace.py:431:29: Q000 Remove bad quotes.
borg/localrole/workspace.py:433:1: C901 'WorkspaceLocalRoleManager.checkLocalRolesAllowed' is too complex (14)
borg/localrole/workspace.py:476:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
borg/localrole/workspace.py:476:29: Q000 Remove bad quotes.
borg/localrole/workspace.py:493:14: D001 found declarePrivate replace it with AccessControl.ClassSecurityInfo.private
borg/localrole/workspace.py:493:29: Q000 Remove bad quotes.
borg/localrole/workspace.py:506:1: D001 found classImplements replace it with zope.interface.implementer
borg/localrole/bbb/interfaces.py:0:1: C101 Coding magic comment not found
borg/localrole/bbb/interfaces.py:0:1: I001 isort found changes, run it on the file
borg/localrole/bbb/interfaces.py:6:1: E302 expected 2 blank lines, found 1
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


To make docker-compose as a single point of configuration changes for flask services.


Yeah, I was being a bit paranoid, though I do think avoiding the `.slice`+`.filter` is worthwhile.


I'd use `!$familyGroups.isEmpty()`


Тег потерял незакрывающую скобку


Whoa - this is a static method? I figured it'd be `$scope.selectedGenes.keys();`

What a weird design choice.


To summarize from IRC plus a few of my thoughts:

- These numbers were calculated by creating multiple test cases and doing some pen-and-paper math to pick constants that satisfied them all based on that I thought was the 'correct' behaviour
- This isn't a linear problem so most PID simulators won't capture the problem properly
    - This also means that PID isn't the best controller for this problem
    - This could be fixed by using percentage based scaling instead of absolute count scaling (would linearize the problem somewhat)
    - This also means that threshold isn't the correct choice either but amazon gets by just fine
- You need to setup your PID simulator with the transfer function of the system
    - This is the main reason your simulator goes wild
    - This problem doesn't have one set transfer function since every service acts differently when its resource count changes
- There are a handful of tests in `tests/` that test just the proportional controller
- There should probably be tests for the whole thing
- This controller could definitely be tuned better

This is what the system looks like when using a simpler system transfer function:
![pid](https://cloud.githubusercontent.com/assets/2931921/19900548/2f144744-a021-11e6-9144-b05ff27c509a.png)

Though really for any ket of Kp, Ki and Kd you can select an infinite number of transfer functions that are optimally controlled with Kp, Ki and Kd (minimum settling time without overshoot).


This is the implicit packaging, so there's no need to specify it.


> So turns out we don't actually need the TMDB ID on Season or Episodes so you can revert if you want and remove the mapping from FavoriteService.js

OK, done.


Here is cs61's variant:
def cycle(f1, f2, f3):
    def ret_fn(n):
        def ret(x):
            i = 0
            while i < n:
                if i % 3 == 0:
                    x = f1(x)
                elif i % 3 == 1:
                    x = f2(x)
                else:
                    x = f3(x)
                i += 1
            return x
        return ret
    return ret_fn


Don't leave dead code hanging around.


I know, I expected that too... and then it turned out that that didn't work, so I had to change it to this. I agree it is a strange design choice.


This list should be a tuple


This error is firing when we skip package build due to _SkipCreatePackage.


Could we get a space behind the comma?


Good point - make use of the Java API for the return value.


If you are concerned about performance of repeatedly accessing length, I saw that you could assign a new variable in the declaration part of the for to specify length and then use that.


@rzelayafavila I think this was from a link that you posted but that I couldn't find quickly.


I do not understand
How can the best feature was eliminated?


lets eat tacos i have no idea what im doing


P.S. Correction: The code fragment in the commit message should read ''keys = Object.keys(desiredObject)'', not "desiredArray", as it does now.


As I've said before, the whole logic is flawed. focus seems to have been on video playback only...


XXXX


зачем return? где ты вычитал такое?


You will also need to install CxxTest, the testing framework.

"sudo apt-get install cxxtest"

Sorry, I didn't anticipate these issues.


Is there an open issue tracking this?


<!-- TAB  img[src="<Copy Path>"]   h1{Обычный заголовок}+p*2(lorem27)  EMMET  p{Простой список}+ul.spisok>li.ok*7>a[href="#"](lorem2)   http://docs.emmet.io/cheat-sheet/  EMMET-->


#1 Functie gemaakt die lijst teruggeeft.


Форматирование поправь - а то будет казаться что ошибка вложенности: ul в 78 строке должен быть на одном уровне с "p" в 777. А строки 74-82 тоже нужно у каждой пробел или два снять. Я так понимаю about-percent это на одном уровне с logo2.


You could also comment out the testing files from the CMakeLists.txt (test.cpp) if you want to build without the unit tests.


Yes, but I mean https://github.com/PhalconEye/phalconeye/blob/0.5.0/core/engine/Behavior/DIBehavior.php#L50


Add location check step to the app.


@jgillis  What it this? Some sort of SWIG internal?


Тут тоже форматирование и... кажется тег то ли не закрыт - который открыт на 65 толи... Почему section закрывается на 72? В чем мысль была?


Hey there Richard,

That guy was me :)

I am curious how you made the install show up in the apps section, can you send me the mxl file you used to do that?  I don’t want to uninstall what I have but would love if it can show up in the apps section.

P.S.  Here is an updated logo I made for the apps section when I was using the ReadyNAS NZBGet.

From: Richard [mailto:notifications@github.com]
Sent: Monday, October 31, 2016 8:43 PM
To: calaba/ReadyNAS-Apps <ReadyNAS-Apps@noreply.github.com>
Cc: jeffhagg <jeffhagg@gmail.com>; Comment <comment@noreply.github.com>
Subject: Re: [calaba/ReadyNAS-Apps] Update README.md (1a096bd)

Hi there,

FYI … one guy found out how to make NZBGet working n 6.6.0 again …

https://community.netgear.com/t5/Community-Add-ons/Install-NZBGet-17-1-on-ReadyNAS-OS-6-6-0-working/td-p/1163293

They obviously changed a packaging rules in 6.6.0 so the old NZBGet app is not anymore compliant with 6.6.0.

ric

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <https://github.com/calaba/ReadyNAS-Apps/commit/1a096bd895e98005ef38bddd9d95bdad84afabae#commitcomment-19642185> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AF56ugeTQ66a-QVNr03FnqLtByl3TzGiks5q5rU6gaJpZM4JX_zy> .  <https://github.com/notifications/beacon/AF56uu6IriV_NM6Vgw87QuGD1DwV8Qqhks5q5rU6gaJpZM4JX_zy.gif>


@shlomitc - You can use 'tryRequire' + not sure about the warning, we do not show it on 'npm test'...


Cool, thanks!


#2 File gemaakt.


Тут br я думаю не нужен - он тут случайно или с умыслом? )


2644021-DOASToMultiAH (wfbuhl) - i386-Windows-7-VisualStudio-12: OK (1772 of 1773 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


I go mad!


I think we should just separate these two samples. The mere existence of this file is confusing users. This comment will probably not fix that.


It isn better replace with a helper function. This was a cheap way to avoid code duplication but fragile


HAProxy is an experimental addition to this project. Nginx has features to perform load balancing and this would be of less importance.


My configs are: [here](http://smokey01.com/peebee/slackocurrent/)


Yeah, I figured out later it was you – send me your email I can send you the Xml files. You need 3 files:

-          Logo.png

-          Config.xml

-          And empty marker file “.localapp”

Then the app will appear in the NAS App list, assuming it is installed under /apps folder (.i.e /apps/nzbget)

Ric.

From: jeffhagg [mailto:notifications@github.com]
Sent: Tuesday, November 01, 2016 11:08 AM
To: calaba/ReadyNAS-Apps <ReadyNAS-Apps@noreply.github.com>
Cc: Richard <calaba@gmail.com>; Comment <comment@noreply.github.com>
Subject: Re: [calaba/ReadyNAS-Apps] Update README.md (1a096bd)

Hey there Richard,

That guy was me :)

I am curious how you made the install show up in the apps section, can you send me the mxl file you used to do that? I don’t want to uninstall what I have but would love if it can show up in the apps section.

P.S. Here is an updated logo I made for the apps section when I was using the ReadyNAS NZBGet.

From: Richard [mailto:notifications@github.com]
Sent: Monday, October 31, 2016 8:43 PM
To: calaba/ReadyNAS-Apps <ReadyNAS-Apps@noreply.github.com <mailto:ReadyNAS-Apps@noreply.github.com> >
Cc: jeffhagg <jeffhagg@gmail.com <mailto:jeffhagg@gmail.com> >; Comment <comment@noreply.github.com <mailto:comment@noreply.github.com> >
Subject: Re: [calaba/ReadyNAS-Apps] Update README.md (1a096bd)

Hi there,

FYI … one guy found out how to make NZBGet working n 6.6.0 again …

https://community.netgear.com/t5/Community-Add-ons/Install-NZBGet-17-1-on-ReadyNAS-OS-6-6-0-working/td-p/1163293

They obviously changed a packaging rules in 6.6.0 so the old NZBGet app is not anymore compliant with 6.6.0.

ric

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <https://github.com/calaba/ReadyNAS-Apps/commit/1a096bd895e98005ef38bddd9d95bdad84afabae#commitcomment-19642185> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AF56ugeTQ66a-QVNr03FnqLtByl3TzGiks5q5rU6gaJpZM4JX_zy> . <https://github.com/notifications/beacon/AF56uu6IriV_NM6Vgw87QuGD1DwV8Qqhks5q5rU6gaJpZM4JX_zy.gif>

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <https://github.com/calaba/ReadyNAS-Apps/commit/1a096bd895e98005ef38bddd9d95bdad84afabae#commitcomment-19651213> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AAR3z-67YfLYYfweZJetnHUzquFmnJsrks5q53_vgaJpZM4JX_zy> .  <https://github.com/notifications/beacon/AAR3z-4XOk6lNwujjdqB6aKUwGw07iiCks5q53_vgaJpZM4JX_zy.gif>


Only the following CSS code needs to be added:

.btn--lowstock {
  background-color: #faa519 !important;
  color: #000 !important;
}


@igrr, http://esp-idf.readthedocs.io/ is now linked directly with https://github.com/espressif/esp-idf/ instead of my temporary fork.


g should be graph iirc


OK, I'll refactor this commit - there are some major issues with it.


The Matrix class is not suppose to know anything about MX


Hey thanks,

My email is:

jeffhagg@gmail.com <mailto:jeffhagg@gmail.com>

in my last e-mail I sent you an updated logo, I am assuming I can use that one to accomplish this.

From: Richard [mailto:notifications@github.com]
Sent: Tuesday, November 1, 2016 11:12 AM
To: calaba/ReadyNAS-Apps <ReadyNAS-Apps@noreply.github.com>
Cc: jeffhagg <jeffhagg@gmail.com>; Comment <comment@noreply.github.com>
Subject: Re: [calaba/ReadyNAS-Apps] Update README.md (1a096bd)

Yeah, I figured out later it was you – send me your email I can send you the Xml files. You need 3 files:

- Logo.png

- Config.xml

- And empty marker file “.localapp”

Then the app will appear in the NAS App list, assuming it is installed under /apps folder (.i.e /apps/nzbget)

Ric.

From: jeffhagg [mailto:notifications@github.com]
Sent: Tuesday, November 01, 2016 11:08 AM
To: calaba/ReadyNAS-Apps <ReadyNAS-Apps@noreply.github.com <mailto:ReadyNAS-Apps@noreply.github.com> >
Cc: Richard <calaba@gmail.com <mailto:calaba@gmail.com> >; Comment <comment@noreply.github.com <mailto:comment@noreply.github.com> >
Subject: Re: [calaba/ReadyNAS-Apps] Update README.md (1a096bd)

Hey there Richard,

That guy was me :)

I am curious how you made the install show up in the apps section, can you send me the mxl file you used to do that? I don’t want to uninstall what I have but would love if it can show up in the apps section.

P.S. Here is an updated logo I made for the apps section when I was using the ReadyNAS NZBGet.

From: Richard [mailto:notifications@github.com]
Sent: Monday, October 31, 2016 8:43 PM
To: calaba/ReadyNAS-Apps <ReadyNAS-Apps@noreply.github.com  <mailto:ReadyNAS-Apps@noreply.github.com%20%3cmailto:ReadyNAS-Apps@noreply.github.com> <mailto:ReadyNAS-Apps@noreply.github.com> >
Cc: jeffhagg <jeffhagg@gmail.com  <mailto:jeffhagg@gmail.com%20%3cmailto:jeffhagg@gmail.com> <mailto:jeffhagg@gmail.com> >; Comment <comment@noreply.github.com  <mailto:comment@noreply.github.com%20%3cmailto:comment@noreply.github.com> <mailto:comment@noreply.github.com> >
Subject: Re: [calaba/ReadyNAS-Apps] Update README.md (1a096bd)

Hi there,

FYI … one guy found out how to make NZBGet working n 6.6.0 again …

https://community.netgear.com/t5/Community-Add-ons/Install-NZBGet-17-1-on-ReadyNAS-OS-6-6-0-working/td-p/1163293

They obviously changed a packaging rules in 6.6.0 so the old NZBGet app is not anymore compliant with 6.6.0.

ric

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <https://github.com/calaba/ReadyNAS-Apps/commit/1a096bd895e98005ef38bddd9d95bdad84afabae#commitcomment-19642185> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AF56ugeTQ66a-QVNr03FnqLtByl3TzGiks5q5rU6gaJpZM4JX_zy> . <https://github.com/notifications/beacon/AF56uu6IriV_NM6Vgw87QuGD1DwV8Qqhks5q5rU6gaJpZM4JX_zy.gif>

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <https://github.com/calaba/ReadyNAS-Apps/commit/1a096bd895e98005ef38bddd9d95bdad84afabae#commitcomment-19651213> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AAR3z-67YfLYYfweZJetnHUzquFmnJsrks5q53_vgaJpZM4JX_zy> . <https://github.com/notifications/beacon/AAR3z-4XOk6lNwujjdqB6aKUwGw07iiCks5q53_vgaJpZM4JX_zy.gif>

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <https://github.com/calaba/ReadyNAS-Apps/commit/1a096bd895e98005ef38bddd9d95bdad84afabae#commitcomment-19651317> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AF56uuRVMOBKdq0kf7mbHFY1rrCdyClzks5q54DugaJpZM4JX_zy> .  <https://github.com/notifications/beacon/AF56uhxZ9tE_XnRi1eymXb8qF1kD3RLFks5q54DugaJpZM4JX_zy.gif>


Well I already installed CxxTest (with brew on Mac) and got this error message despite having installed it.

And I don't want to skip the tests, I want to run them :-)


Yes this is a bug


I'm pretty sure this is shortcut breaks more things that it fixes. I'm getting some pretty ugly renders with it. Even if the frame _width_ hasn't changed content needs to be reflowed when stuffed into the next frame or you get junk output like bad leading, paragraph spacing, unreasonable hyphenation penalties, etc. You can't just assume that _any_ content is safe to push to the next page without reshaping it.


A to nie jest tylko w przypadku kiedy oczekujemy na odpowiedź mysqla?


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.browserlayer/6/violations
```
plone/browserlayer/__init__.py:0:1: C101 Coding magic comment not found
plone/browserlayer/exportimport.py:96:21: Q000 Remove bad quotes.
plone/browserlayer/exportimport.py:102:21: S001 found %s formatter
plone/browserlayer/exportimport.py:115:21: Q000 Remove bad quotes.
plone/browserlayer/exportimport.py:121:21: S001 found %s formatter
plone/browserlayer/layer.py:5:28: D001 found directlyProvides replace it with zope.interface.provider
plone/browserlayer/layer.py:12:31: Q000 Remove bad quotes.
plone/browserlayer/layer.py:29:5: D001 found directlyProvides replace it with zope.interface.provider
plone/browserlayer/testing.py:20:10: Q000 Remove bad quotes.
plone/browserlayer/utils.py:37:24: Q000 Remove bad quotes.
plone/browserlayer/utils.py:37:52: S001 found %s formatter
plone/browserlayer/tests/test_doctest.py:0:1: I001 isort found changes, run it on the file
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Hi, this is Gabriel Weinberg, founder of DuckDuckGo. As you may know, we are a search engine that doesn't track our users at all (https://duckduckgo.com/privacy). This path that is being blocked is one of the only ways we can anonymously improve our product. As we do not collect or share personal information, none is associated with these requests. With that context, would it be possible to remove https://duckduckgo.com/t/ from the list?

Thank you for your consideridation. I can also be reached directly at yegg at duckduckgo.


Okay, i understand my bug. I agree that the array useless

2016-10-31 12:03 GMT+06:00 gelin <notifications@github.com>:

> Do you need to keep ALL of them?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/newAlastor/Formatter/commit/f12070373daa27066e706c67af41db89b79d223e#commitcomment-19628205>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AV283qlS6H2shyNlP27zp0XYUrQNFYStks5q5YSsgaJpZM4KjGRp>
> .
>

--
С уважением,
Максим Гончаров


A span túl általános önmagában, használod pl az article-ben is, csak azért nem láttad a "hatását", mert elgépelted
 + és "spanc"-ot írtál :) Ezért érdemes megmondani, hogy "hol lévő span", ezért létrehoztam egy "title" osztályt.


https://jira.arizona.edu/browse/UAF-3674 for future implementation


This would be better if it was include in the earlier log statement.  Could use https://github.com/lbryio/lbry/blob/master/lbrynet/core/log_support.py#L152


Elgépelted :)


Oh my bad, this is the reader! I read your comment and glossed over the `||` in the `||=`


Nyugodtan lehet 100% . Látható, hogy a designban ez egy különálló, önálló sor, a tartalom addig ér benne, ameddig ér, nincs okunk szűkebbre szabni, csak azért, mert elfér szűkebben is.


Old code didn't, but yea, that's a good idea!


Yes. 2dup takes x1 and x2 in input and generates x1 and x2 in output. x3 is the result of the addition. I will change it, thanks.


Work in progress


Not ready for merge


@yuanzhou Showing some kind of matched string does, but which one and/or merging them raises more questions, and it's probably better to just make a quick judgement and barrel by for now. There is a finite amount of space on the page and anything beyond highlighting the "core" label is likely too much. (Although, I think "properly" merging highlights may be a nice side project.)

Let's take the example of the following search term: _pig part_
Then you have matches on things like:

_part of pigmentation_
_particular pigment_
_particular part of pig_
_part of a particular pig_

Merging all of these becomes a bit of a hassle; and if we even go the way of ngram, the problems get significantly worse.
Again, either somebody else's merge library or the longest/first.


wrong description.
Should be: added action bar with title and color


88c22a6c781f245106118d347f9887550d41a778 ![](http://i.somethingawful.com/forumsystem/emoticons/emot-toot.gif)


Please revert the date. It is the date of release.


+0.5 (pode ignorar esse comentário)


While working on some more tests, I came across a scheduling error that was occurring.

When scheduling a ```section```, the ```instrument-part```s were originally scheduled in sequence.  For example, the second ```instrument-part``` in a ```section``` would not be scheduled until the first ```instrument-part``` was completely queued.  In larger pieces, this was leading to ```note```s being scheduled after they were supposed to already have played.  Since the ```pstream-current-frame``` was already past the beginning frame of the note, the notes were being skipped.

This commit adds concurrency to the scheduling process.  ```pstream-queue-section``` creates threads for each ```instrument-part```, and schedules them in parallel.


Changed in ea3558cb5ba19622a273dce914c03ed0c3defb88


Oh yeah I forgot to mention to pull the changes on the monarch-app, sorry!

Concerning the highlighted fields I went ahead and take the first one
available, we can review that later as you mentioned Seth.

On Tue, Nov 1, 2016 at 11:22 AM, kltm <notifications@github.com> wrote:

> @yuanzhou <https://github.com/yuanzhou> Showing some kind of matched
> string does, but which one and/or merging them raises more questions, and
> it's probably better to just make a quick judgement and barrel by for now.
> There is a finite amount of space on the page and anything beyond
> highlighting the "core" label is likely too much. (Although, I think
> "properly" merging highlights may be a nice side project.)
>
> Let's take the example of the following search term: *pig part*
> Then you have matches on things like:
>
> *part of pigmentation*
> *particular pigment*
> *particular part of pig*
> *part of a particular pig*
>
> Merging all of these becomes a bit of a hassle; and if we even go the way
> of ngram, the problems get significantly worse.
> Again, either somebody else's merge library or the longest/first.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/monarch-initiative/monarch-app/commit/56113758018749b63569bd217575824ea5640104#commitcomment-19651871>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AEHMGAZQT68TIfj-wDm2I9ssnXrrwmTdks5q54NfgaJpZM4KjhLF>
> .
>


finally :+1:


Shouldn't be 2016?


Opps...


2644021-DOASToMultiAH (wfbuhl) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1789 of 1790 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Should it be done in the same way as Spark initialize its interpreter? Just to avoid any future problems.


Nice )


Isso não é uma lista.


@agileknight: I looked at your fork of go-diff and it might be interesting to know that there is now a functionality to display diffs in a terminal like your change does https://godoc.org/github.com/sergi/go-diff/diffmatchpatch#DiffMatchPatch.DiffPrettyText


2644021-DOASToMultiAH (wfbuhl) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Too close to make a difference imo


Probably yes using `Main.initiateSparkSession()` 👍 . This method is available only on scala 2.11 repl, so this seemed as easier fix for both scala versions at the moment ( not sure if scala 2.10 is failing too). I need to test it on both scala versions and do corresponding changes, so proper fix will take more time. Will have a look on it when have the time


Another way to do these:

```html
<nav>
  <a href="/home">Home</a>
  <a href="/music">Music</a>
</nav>
```


Only the following CSS code needs to be added:

.btn--lowstock, .btn--backorder {
  background-color: #faa519 !important;
  color: #000 !important;
}


Is it possible that you don't have permissions for a folder, or something like that?

Have you tried running make as super user? Not sure what else could cause this problem


Although it would be strange for someone to specify either delimitation item as a stop tag, there may be cases where consumers are doing this. The tag == stopTag condition is preserved for backward compatibility with these clients.


The following doc(s) have been deployed to the [terminus1x](https://terminus1x-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/terminus/install](https://terminus1x-static-docs.pantheonsite.io/docs/terminus/install)
- [source/_partials/footer_scripts.html](https://github.com/pantheon-systems/documentation/commit/827aef3c2a81da33503c97ad83e942601460e111/source/_partials/footer_scripts.html)


Only the following CSS code needs to be added:

.btn--backorder {
  background-color: #faa519 !important;
  color: #000 !important;
}


bench: 4832992


I'm testing this out on the Axon 7 preparing it for the Zmax pro any idea why the file I'm trying to overwrite is not working? It overwrites it but the content is empty.


hm.. I haven't seen you tried to join. is this your name on g+?

contact me onhangouts
lordclockan@gmail.com


I don't think we really intend to have this version of the plugin support `171.*`. That's more of a convenience for local development. We should probably drop back to just the current stable version range.


r+


saw approval from jedmccaleb
at https://github.com/QuantozTechnology/stellar-core/commit/f4dbf728479155ed545bcfe36dac8f40f12c6d12


merging QuantozTechnology/stellar-core/add-unzip-work = f4dbf728 into auto


QuantozTechnology/stellar-core/add-unzip-work = f4dbf728 merged ok, testing candidate = 5cb49ba9


@vangheem Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.vocabularies/28/violations
```
plone/app/vocabularies/__init__.py:3:28: D001 found directlyProvides replace it with zope.interface.provider
plone/app/vocabularies/__init__.py:20:13: D001 found directlyProvides replace it with zope.interface.provider
plone/app/vocabularies/principals.py:0:1: C101 Coding magic comment not found
plone/app/vocabularies/principals.py:125:80: E501 line too long (81 > 79 characters)
plone/app/vocabularies/principals.py:129:80: E501 line too long (83 > 79 characters)
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@crosby0320 @jeuscortez @rudyleiva93 @jflores253 @Daniel-Hernandez-1

The pending items are in the todo.txt list.
I was able to fix up the back-end, so we shouldn't have to worry about it anymore. There needs to be improvements as I can transfer any number of dollars between accounts, regardless of the amount that is actually in there. (I end up with negative amounts lol) Once this is fixed I will merge the dev branch with the master again, as the transfer use case is completed. (Still waiting on deposit, withdraw, paybills)

Almost everything else is just stuff we needed last week. On top of this the project can't move forward without these parts.


A more HTML5 way to do this.

```html
<header class="banner">
  <h1>Joshua Martin</h1>
  <h2>Pianist, composer, and writer looking upward</h2>
</header>
```


@akovaski: I looked at your fork of go-diff and it might be interesting to know that deadline is now of type time.Time in the current master, so this change as well as https://github.com/akovaski/go-diff/commit/61b067d91db25b96fae361829283a443c0a1887a is not needed anymore :-)


```swift
@objc func get(path: String, resolve: RCTPromiseResolveBlock, reject: RCTPromiseRejectBlock) {
```


This order won't validate against the schema. (XML Schema is strict about the order of elements.) The previous order was valid.


isso tem mais cara de registro do que dicionário


Wypadek przy pracy xd


```html
<main>
```


I would like to leave this comment for other developers to see. Some of them won't read the schema, so this link would serve a purpose.


@BigNoid Is the double list visible test code too or a solution for something?


Well no, the error was that I was building in the root directory of the repo.
Now that I'm building in a subdirectory it builds successfully.

But I still have some compiler warnings.


isso é um registro


Comment


If you want to see what your master looks like, you can /master after your site main URL and then if you want to see what is in a branch, add /nameofthebranch


também é registro


```css
.navigation {
  ...
}
```


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.subrequest/23/violations
```
plone/subrequest/__init__.py:72:1: C901 'subrequest' is too complex (22)
plone/subrequest/subresponse.py:22:12: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:23:16: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:24:12: P002 found "hasattr", consider replacing it
plone/subrequest/subresponse.py:50:16: P002 found "hasattr", consider replacing it
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@vangheem Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.vocabularies/29/violations
```
plone/app/vocabularies/__init__.py:3:28: D001 found directlyProvides replace it with zope.interface.provider
plone/app/vocabularies/__init__.py:20:13: D001 found directlyProvides replace it with zope.interface.provider
plone/app/vocabularies/principals.py:0:1: C101 Coding magic comment not found
plone/app/vocabularies/principals.py:125:80: E501 line too long (81 > 79 characters)
plone/app/vocabularies/principals.py:129:80: E501 line too long (83 > 79 characters)
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


A design antipattern


[14:38:28] [Server thread/INFO]: Enabling Slapper v1.2.9.7
[14:38:28] [Server thread/CRITICAL]: ParseError: "syntax error, unexpected 'self' (T_STRING), expecting ']'" (EXCEPTION) in "/phar_Slapper-php7_tGWpQbQrvPX_RRH.phar/src/slapper/entities/SlapperBat" at line 26
[14:38:28] [Server thread/INFO]: Disabling Slapper v1.2.9.7


:bomb: it!


@inodb @jiaojiao123 This will fix the "[object Object]" problem when cBioPortal/reactable/#1 is merged


There's  a typo on weekd :)


Collaborator:
A review for this commit was created. [Link to review](http://dev.visitry.org/ui#review:id=115)


```css
.navigation a:hover {
  ...
}
```


`.logo` => `.banner`


Don't need this?


xd


Maybe a relative unit?


Is there any better way to do this, @RyanMarcus?


I have created a separate branch for embedded factsheet feature. Could you perhaps move it there? https://github.com/erasmus-without-paper/ewp-specs-api-institutions/blob/embedded-factsheet/response-example.xml#L51

The reason of having separate branches is to clearly split different discussions and different solutions. The goal is for the master branch to contain only the "most stable" proposals, while others (not necessarily as much stable) would be kept in feature branches. This way, developers will be able to start work on the more stable features, while we are reviewing less stable ones. https://guides.github.com/introduction/flow/

If you're not sure how to do this, then it's also okay to leave it here, for now. I will clean it up later.


sorry should have pushed to another branch!


Thanks


I changed it because Tutorials and Guides can really mean the same thing, and I'd like that section to be mostly straight forward documentation. Feel free to convince me otherwise though :)


This commit drops support for rails 5. Is that intentional?


Nope, thats copy paste. Thx for double check :)
Fixed in https://github.com/BigNoid/Aeon-Nox/commit/d530840f98bcadd4ae5dfa2243ed79cf0ef4d843


r+


`h1` => `.banner h1`


Is this specific order required for it to work?


Add a semicolon :)


Aspect ratio accounted for in orthographic projection


Specifically, calling `t.stream()` seems like a hack. Seems like `.flatmap()` should solve this, but I couldn't get it to.


To share styles and tidy the h1/h2 styles up a bit:

```css
.navigation h1, .navigation h2 {
  ... shared styles here
}

.navigation h1 {
  ... specific styles here
}
```


2644021-DOASToMultiAH (wfbuhl) - Win64-Windows-7-VisualStudio-12: OK (1772 of 1773 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Yep, me too. The timeout wouldn't have actually fixed the issue anyways, it just masked it. Sending a PR, just wanted to make sure it worked first :simple_smile:


See Dokku's Node selection step. To select a node version, specify in `package.json`. This is also documented at [Heroku](https://devcenter.heroku.com/articles/nodejs-support#specifying-a-node-js-version)
```
remote: -----> Installing binaries
remote:        engines.node (package.json):  unspecified
remote:        engines.npm (package.json):   unspecified (use default)
remote:
remote:        Resolving node version (latest stable) via semver.io...
remote:        Downloading and installing node 5.11.1...
remote:        Using default npm version: 3.8.6
```


`p` => `.content p`


Add sane font defaults up here:

```diff
+  font-family: 'Source Serif Pro';
+  font-size: 18pt;
+  font-weight: 100;
```


Might move some of these "sane font defaults" to the `body` tag's styles.


fix in 4b2a02f


Adjusting font spacing like this is a design antipattern.


since the build is passing (except for slightly reduced coverage), I will leave it here on master and continue working on another branch.


@cdecker Hi Christian! Could you please elaborate where did `378` response code come from? I can't find it in any of the `RFCs` ([2810](https://tools.ietf.org/html/rfc2810]), [2811](https://tools.ietf.org/html/rfc2811), [2812](https://tools.ietf.org/html/rfc2812), [2813](https://tools.ietf.org/html/rfc2813)).


Hmm, what does this do?


@casualjim: I looked at your fork of go-diff and it might be interesting to know that this change of yours is partly fixed upstream. The "not escaping" is kind of dictated by other implementations of diff-match-patch. Maybe you could tell me why it is better to not escape the patch?


The following doc(s) have been deployed to the [terminus1x](https://terminus1x-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/terminus/install](https://terminus1x-static-docs.pantheonsite.io/docs/terminus/install)
- [source/_partials/footer_scripts.html](https://github.com/pantheon-systems/documentation/commit/827aef3c2a81da33503c97ad83e942601460e111/source/_partials/footer_scripts.html)


Might do this on your body tag


I see. But constructor name (`cons`) is misleading.
And do we really need actual queue implementation to typecheck a Jolie file?


I have clients reporting problems with rss readers not providing a link when there is not <link> on <item>, is there a problem including the  <link tal:content="item/link" />. This seem to have happened before :-) 96806749d29576cd116db9006e7eb7c96eebe4f4


can you show your roomservice.xml  for me? thank  you  very much. i'm
 building 14.1 now and find msm8974 graphic error


`addLayer function` in ScrollView helps the openSeadragon instance placing the list of images.


maybe, but little steps usually must be more productive


some tests failed:
failure: https://travis-ci.org/stellar/stellar-core/builds/172380567


You need this repo https://github.com/TheMuppets/proprietary_vendor_qcom_binaries


You don't want to use csmt for that blit. You are already in the worker thread.


i try to test 4 variations


Hmm, tutorials and guides shouldn't mean the same thing - different learning styles, structure, etc.  However, we haven't been too consistent with formats and structures on the docs, which will change with the advent of Moi.  Having Docs > *Documentation* isn't helpful, as *Documentation* is essentially everything.  I'd rather see "Guides", which is a doc type that's more in-depth that reference, and yet more direct and less lead-by-thy-student tutorial style.


@Thecakeisgit happy to hear it!


This looks like it would increment i twice, skipping the next argument?


This is really `testWcs`, given its contents.


Fix docstring.


Let's add a text shadow to help visibility:

```css
text-shadow: 1px 2px 15px rgba(0,0,0,0.1);
```


Can you do a PR for the typo?

Cool about `static`, did not know about that!


In SlapperHuman.php self::DATA_LEAD_HOLDER should be self::DATA_LEAD_HOLDER_EID


Do you need all those zeros? Probably not.


@timabbott I think you missed a `)`


ughhh
```scala
> example/testOnly monocle.JsonExample
[info] Compiling 34 Scala sources to /Users/aoino/git/Monocle/example/target/scala-2.12.0-RC2/test-classes...
[error] /Users/aoino/git/Monocle/example/src/test/scala/monocle/JsonExample.scala:44: polymorphic expression cannot be instantiated to expected type;
[error]  found   : [S, A]monocle.Optional[S,A]
[error]     (which expands to)  [S, A]monocle.POptional[S,S,A,A]
[error]  required: monocle.internal.PrismMagnet[JsonExample.this.Json,JsonExample.this.Json,Map[String,JsonExample.this.Json],Map[String,JsonExample.this.Json]]
[error]     (jsObject compose index("age") compose jsNumber).getOption(json) shouldEqual Some(28)
[error]                            ^
[error] /Users/aoino/git/Monocle/example/src/test/scala/monocle/JsonExample.scala:46: polymorphic expression cannot be instantiated to expected type;
[error]  found   : [S, A]monocle.Optional[S,A]
[error]     (which expands to)  [S, A]monocle.POptional[S,S,A,A]
[error]  required: monocle.internal.PrismMagnet[JsonExample.this.Json,JsonExample.this.Json,Map[String,JsonExample.this.Json],Map[String,JsonExample.this.Json]]
[error]     (jsObject compose index("siblings")
[error]                            ^
[error] two errors found
[error] (example/test:compileIncremental) Compilation failed
[error] Total time: 17 s, completed 2016/11/02 4:01:47
```


![](https://github.trello.services/images/mini-trello-icon.png) [Dificuldade do microfone não está influenciando as atividades](https://trello.com/c/Qr6C28vd/50-dificuldade-do-microfone-nao-esta-influenciando-as-atividades)


@eruca: I looked at your fork of go-diff and it might be interesting to know that this got fixed upstream :-)


Disabled event trigger from scroll view (originally used as linking back to single image view)


Toolbox has the method updateTextboxText(""); but not nativeSetTextboxText(""); so i call .updateTextboxText(""); first


Alright convinced :) I'll change it back for now.


saw approval from jedmccaleb
at https://github.com/vogel/stellar-core/commit/e985e3e340bae974c09f537bc1686943a523e9be


merging vogel/stellar-core/accountsdata-alter-table = e985e3e3 into auto


vogel/stellar-core/accountsdata-alter-table = e985e3e3 merged ok, testing candidate = f44b1209


BTW its untested


For complicated objects, it might be better to construct them and then call `self.assertEqual(expected, ...)`


Тег title тут не может идти. Тут идет заголовок страницы. И он не "Хлебные крохи"


The following doc(s) have been deployed to the [terminus1x](https://terminus1x-static-docs.pantheonsite.io/docs) Multidev environment:
- [source/_partials/footer_scripts.html](https://github.com/pantheon-systems/documentation/commit/c126c7b28284cdeec05d3484b300c0ae9bb6d2fd/source/_partials/footer_scripts.html)


Два одинаковых блока
 и
 - оставь только один


Maybe have a short docstring explaining the nature of this test (e.g. "we read in the file in setUpClass, then test each part of the visitInfo separately, to simplify failure reporting")


ew, `-version`.


++ maybe there is more in the help section though?


Блоки
 и
 оберни в общий блок


ouch


I would be surprised if there weren't compiler warnings. I haven't had time to polish all of it so that it's perfect. It's more of proof of concept.


Needs more GG.


sync to upstream


Этот блок идет `<section class="item-title">` идет перед  `<ul class="breadcrumbs">`


Agree.


I don't recall sorry


This has caused the media-bundle to stop functionin due to the get/setParent is longer implemented,
got
[Symfony\Component\Debug\Exception\FatalErrorException]
  Error: Class Symfony\Cmf\Bundle\MediaBundle\Doctrine\Phpcr\Directory contains 1 abstract method and must therefore be declared abstract or implement the remaining
  methods (Symfony\Cmf\Bundle\MediaBundle\HierarchyInterface::getParent)


++ but want @bradleyrichter to test


Shell creation done is not particularly descriptive, please make sure to explain what is being added in the commit message.

For instance, from reading "ShellCreationDone" I cannot tell what has changed in this commit without looking at the tutorial or reading through the source code. Please explain to me what the changes above do in a reply to this.


Got that reg expression from online, and not understand it, but it works well parsing


Hi @fgiaimo, is this change ready for a PR?


Congrats, @christensonjc!


Actually, `test_wcs`, I guess...


`<h1>Набор для путешествий</h1> и <h2><a href="#">Baxter of California</a></h2>` остается только 1 блок `<h1>Набор для путешествий Baxter of California</h1> `


thanks @adelq, will do that


Размечено не верно. Необходимо следующим образом: `<div class="price-item-page"><span class="price-item">2 900 руб.</span><a href="#">Купить</a></div>`


@jnguyenx after I switched to use `documents()`, many labels are highlighted as well.

![capture](https://cloud.githubusercontent.com/assets/195873/19903629/abfbf9ea-a045-11e6-8f6f-e34abdfe1e1e.PNG)

Is this expected?


`<form class="appointment-form" action="https://echo.htmlacademy.ru" method="post">` идет вместо этого блока `<div class="index-content-left">`


can't -> shouldn't / mustn't


ER_FOREIGN_KEY_ON_SYSTEM_VERSIONED was not deleted.


Not sure, we can postulate it later.


Блоки `<div class="index-content-left"> и <div class="catalog">` оберни в общий блок


Wouldn't it be clearer to have priorities increase relative to priority, ie towards a higher number? That way, NoWork would still be 0 and the highest number would be for SynchronousPriority, ie 5.

This would make the rest of of the codebase a bit more readable and simplify double checks like:

```js
if (fiber.pendingWorkPriority === NoWork ||
    fiber.pendingWorkPriority >= priorityLevel) {
  fiber.pendingWorkPriority = priorityLevel;
}
```
Into:
```js
if (fiber.pendingWorkPriority < priorityLevel) {
  fiber.pendingWorkPriority = priorityLevel;
}
```

_Sorry if this has already been proposed; didn't find anything on it by a quick issue search._


label идет после input и связаны они через id и for. `<br> `- не нужны


Форма закрывается ниже. Это всё большая форма с фильтрами


Лишний


We can `create table parent` 1 time instead of 4.


Вместо `</div>` закрывается форма


Лучше .catalog-list


I tried to include all dependencies, that are needed for a production build. For instance we need `grunt-contrib-uglify` and `grunt-contrib-concat` to get the final js files, but we don't necessarily need `grunt-contrib-jshint`. If we see again, I can show you the otherwise resulting problem with heroku. ;-)


Resolves #20


Strange (). This looks better:
```
return mach_read_from_8(field);
```


`<h3 class="item-title"><a href="#"><span class="item-name">Baxter of california</span> Набор для путешествий</a></h3>`


`<div class="price-item-page"><span class="price-item">2 900 руб.</span><a href="#">Купить</a></div>`


Webutviklings oppgave av: Dexter, Oliver, Henrik og Akar.


Rename `row_ins_get_sys_trx_end_from_clust_rec` to `row_ins_get_sys_trx_end`.


Этот блок лишний. Этот класс повесь на `<ul>`, который идет ниже


No need in `err` variable.


test


hmm well, or strip the c++11 stuff


`FIXME` must be fixed.


Ahhh, I'd better update the VPN server with the new PUT supporting code.


naiser dude


2644021-DOASToMultiAH (wfbuhl) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1197 of 1198 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.92%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-36.16%25-green.svg)


Commit should be renamed to:
IB: (0.4) foreign keys for versioned tables (#58)


Aren't arrow functions supported in Node 4?


Seriously me, don't forget this...


error de cuentas de github actualizado en el siguiente commit


Any suggestion? :) PS : they are usually not directly used by the user


Should't the objective C emit api using "with:" instead of "withItems:"
```
[socket emit:@"update" with:@[@{@"amount": @(cur + 2.50)}]];
```


Yes, but it will have too many history fields which will make tests results less easy to read.


@Megabyte918 Yes, :)

BTW Sorry for the late response :D


This is French I think. ;-)


Yeah I guess this is what I mean by https://github.com/babel/babel-preset-env/issues/16 - it's just what we get from the compat-table data


I suggest making a makro for logging, so you don't have to #ifdef all the time


test comment #### section ####


🍺  great!

Could you add any relevant info to the Changelog, please?


The warning is shown in the wallaby console. it's not harmful, but I'll remove it.


Was wondering about that
<img width="100" alt="screen shot 2016-11-01 at 3 25 28 pm" src="https://cloud.githubusercontent.com/assets/588473/19904062/7b2b6628-a047-11e6-9e4c-e46ab9783619.png">

works in most cases so need to account for that somehow


Still me, name error.


>  You are free to submit issues via the Issue tracker on GitHub, we will aim to fix or add any issues you come across.

So... @sainttx I think you forgot to enable the issues in this repo 😋


Discussed before.

We're changing this to be expiration time instead. Won't stay like this.


No need to hurry. I'm still fighting with Travis over this commit ;)


yes ! that good !
i've seen !


Também foi realizado a autenticação do Usuário Logado.
Não está validando permissão do perfil do usuário ainda.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/172388928


Are you sure this works? Doesn't seem to for me...


An emoji 🆖?


But most returns in this file looks like this.


Fixed, thanks for pointing that out!


It's not completely clear for me what you mean, so I think we'll hash this out over a bear sometime soon :)


Cute.


what about doing something like
```php
$lloc = $classOrFunction->getOrException('lloc', 'length');
```
where
```php
function getOrException($name, $collection) {
    $value = $this->get($name);
    if ($value === null) {
        throw new \LogicException('Please enable the ' . $collection . ' (' . $name . ') visitor first');
    }
    return $value;
}
````


fast-forwarding next-db-and-proto to auto = f44b1209


can you make a release with this commit ?
Thanks !


It does call `/donors/count` through this [getSSMDonorCount](https://github.com/icgc-dcc/dcc-portal/commit/d90fc2b509ce955782d0f97fb1b3ca665696fcb1#diff-90def42de7132c979f837c3fe86d0c7cR668) function


Would you please explain the need for this change to me?


Этот блок не нужен, класс можешь назначить для формы


Change the default zoom behavior of OpenSeadragon from single click to double click. This enables the click -> ocr text feature.


VB has me looking at this commit.  There's a bunch of minor little bits of stuff but as you said, "as with many organically-grown things..." :) This, however, I can't make any sense of. It's true that `GetChangeLog` can return `None` but that would not cause an `AttributeError`.  Moreover `GetChangeLog` itself catches *too many* exceptions (eg, it converts a `KeyboardInterrupt` or `SystemExit` into a return of `None`!) so no lower-level `AttributeError` should make it up here in the first place.


It will not work, the variable RUNLEVEL is not defined.


Comentar documentación


Ya it looks like it really only fails one test, `correct precedence`, since the others are non-strict-mode (which babel doesn't compile to) or related to the `new.target` feature which isn't in v4.


@rcoop017 — this is great (pulling the HTML chunks out into tags).

However, the text here isn't actually localizable because **only** the `defaultMessage` string appears in the translation file. So in this case, the translation file's entry will look like:

```JSON
{
  "app.slides.beforeYouBegin.mealEligibility": "{tooltip}  {strong}{tooltip2} "
}
```

So the actual English words aren't present for translation.

In this specific case, the best approach might be to simply wrap the strong text, e.g.:

```html
...
<strong>
  <FormattedMessage defaultMessage="for free of reduced..." />
</strong>
...
```


Running gcc 6.2.1 and cuda 8 I'm getting a error that later versions then gcc 5 aren't supported. Why is this so?

```
[  5%] Building NVCC (Device) object CMakeFiles/nheqminer_cuda_tromp.dir/__/__/cuda_tromp/nheqminer_cuda_tromp_generated_equi_miner.cu.o
nvcc warning : The 'compute_20', 'sm_20', and 'sm_21' architectures are deprecated, and may be removed in a future release (Use -Wno-deprecated-gpu-targets to suppress warning).
In file included from /opt/cuda/include/cuda_runtime.h:78:0,
                 from <command-line>:0:
/opt/cuda/include/host_config.h:119:2: error: #error -- unsupported GNU version! gcc versions later than 5 are not supported!
 #error -- unsupported GNU version! gcc versions later than 5 are not supported!
  ^~~~~
CMake Error at nheqminer_cuda_tromp_generated_equi_miner.cu.o.cmake:207 (message):
  Error generating
  /home/frog/nheqminer/Linux_cmake/nheqminer_cuda_tromp/CMakeFiles/nheqminer_cuda_tromp.dir/__/__/cuda_tromp/./nheqminer_cuda_tromp_generated_equi_miner.cu.o

make[2]: *** [CMakeFiles/nheqminer_cuda_tromp.dir/build.make:290: CMakeFiles/nheqminer_cuda_tromp.dir/__/__/cuda_tromp/nheqminer_cuda_tromp_generated_equi_miner.cu.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:67: CMakeFiles/nheqminer_cuda_tromp.dir/all] Error 2
make: *** [Makefile:84: all] Error 2
````


Update EOD Process


Это не просто стрелки это направление сортировки, .sorting-direction


I don't think there is but I'm not sure that we could do much since there are two 01.00.00 times on that day - I think we did something on another method that similar problem happened where it would attempt to stay in the timezone of the original instance. You can open an issue if you'd like and I can take a look at it.

As for preferring `advance`, that isn't always an option - that's relative whereas `change` is absolute.


Regarding the arrays starting with index _0_ or _1_ - this is where my thinking was going with with my reply early this AM.
Most programming languages I'm familiar with initialize arrays with the first value being stored at _index 0_. _Some_ can be initialized with _index 0_ being equal to the size of the array,  in those cases the first value ends up being stored at _[1]_.
I'm not going to go into more detail regarding the above info as i'm pretty sure your quite knowledgeable regarding the subject - however, should you like me to go into more detail please do not hesitate to ask.

With that being said - that's why I mentioned renamed all the variables to the sequence of 0 & 1.

That way we have  scenario that looks like the following:
serbridgeInit();
 serbridgeStart(**0**, flashConfig.telnet_port**0**, flashDefault.telnet_port**0**mode);
 serbridgeStart(**1**, flashConfig.telnet_port**1**, flashDefault.telnet_port**1**mode);

vs

serbridgeInit();
serbridgeStart(**0**, flashConfig.telnet_port**1**, flashDefault.telnet_port**1**mode);
serbridgeStart(**1**, flashConfig.telnet_port**2**, flashDefault.telnet_port**2**mode);

So a few questions we need to answer.
1) Do we go with the first or second(current) scenario regarding variable names.

2) In regards to this: https://github.com/jeelabs/esp-link/pull/206#issuecomment-257512218
I think a new page should be created for Telnet/Serialbridge settings. A general settings link on the main left side navigation could easily span another tree.

ie:
Home -> Home.html
Wifi -> WIfi.html
Adv. Settings -|
    Telnet/Serial Bridge
    Serial Port
    Debug Options

...etc? I hope this seems clear? Having a hard time explaining this right now for some reason.

I really appreciate the work you've done so far sir - I do plan on getting back at it soon, but alas some unexpected things have kept me somewhat distracted & overly busy in my day to day life.


Это не картинки, мы их нарисуем через CSS


"with None" throws AttributeError.  I verified this by testing.


Внутрь ссылок вместо картинок напиши текст. Ссылкам дай классы


saw approval from jedmccaleb
at https://github.com/vogel/stellar-core/commit/171803e24d7be77bf79751af4c7e87b9418dc271


vogel/stellar-core/remove-dead-code = 171803e2 merged ok, testing candidate = f06f5749


merging vogel/stellar-core/remove-dead-code = 171803e2 into auto


CoooOoOooOL!!


Картинку оберни в ссылку. Картинка ведет на страницу с гостиницей


Collaborator:
A review for this commit was created. [Link to review](http://dev.visitry.org/ui#review:id=116)


deneme


тег h2


span лишний


Why don't to fix the same issue in `README.md` at once? J
In this case it is safe to rewrite history via `--amend` the last commit and push with `--force` flag.


Один класс у всех блоков результатов class="hotel"


Oh good point, so we should just be ok with strict mode


@adufilie I merged the PR, maybe change to specific commit here


Зачем span


It's updated now anyway. :smile:

/me should really automate that


cuda 8 doesnt work with gcc 6 , as it tells you


картинку оберни в ссылку с классом


@duedal same problem here


Oh, I see.  It's because `with` needs to `__enter__` and `__exit__`.

Ewww.


I want to be able to access these specifically the ability to enable/disable NFC


черточки вокруг номера сделаем через CSS


Commit realizado por Maria Helena Pereira e Marcos Silva !!!


@mjordan maybe in the future, don't push directly to master :smile:


Isn't that problematic?
What if someone opens EventSource while you're traversing through the emitters during println?
Shouldn't you use a threadsafe list?


Лучше type="text". С type="date" могут быть проблемы


картинку оберни в ссылку


It looks like babel will throw an error without the es2015 preset for
```js
0 || () => 2
```
anyway (based on repl without es2015 present selected)


Of course, I totally forgot that "editing" in the GUI on master updated master.... sorry, won't happen again.


Since you are just running this at the end of the digest cycle (1ms delay), did you try `$evalAsync` rather than `$timeout`? Protractor still has some issues with `$timeout`, so I think we should at least switch to `$interval`. (https://github.com/angular/protractor/blob/master/docs/timeouts.md)


So the last probability should be `0.04`, but the subsequent REQUIRE would not pass so I tried `0.040000000000000036` and it worked. Note my example J gene file is a little different from the partis J gene file (see comment in file). Any ideas why this happens?


yeah in reality it should check against what babel is able to do although would be more work


Этот класс можешь добавить форме, а сам блок убрать он лишний


список - избыточен. В данном случае input, а рядом с ним label


I wonder if you could use the es compat table as a base-line then apply overrides for cases like this.


Список лишний


@rcoop017 — check out 55e4fecf899dc6acebef9513dc0a96f045573604

Now the translation file's line will look like this (which can be localized):

```JSON
{
  "app.slides.beforeYouBegin.mealEligibility": "for free or reduced price school meal benefits is based on any one of these"
}
```

Some of the other chunks in this file are more challenging (nested lists). I'll work up some examples for those now too.


Hello,

Is this working?

Best regards.


W obu przypadkach. Wysłanie zapytania jak i oczekiwanie na niego trochę trwa. Wszystko co tyczy się I/O powinno być asynchroniczne.

Zrób sobie klasę rozszerzającą Thread. Stwórz w niej BlockingQueue<NCPEvent> z ArrayBlockingQueue<>(1024). W `run()` zrób nieskończoną pętlę `while (true)` która będzie cały czas używać metody `take()` z tej listy (wątek uśpi się gdy lista będzie pusta i obudzi, gdy będzie miała nowe elementy - nie martw się więc o zużycie procesora przez pętlę). Obiekt `NCPEvent` pobierasz metodą (`take()`) i wykonujesz całe to parsowanie nad tymi komentarzami - używa RegEx i parsowanie inta, więc spowalnia główny wątek serwera. Potem w tym samym robisz wysłanie zapytania do bazy.

Stwórz tą klasę przy włączaniu pluginu i zachowaj ją w zmiennej w głównej klasie.

Musisz sobie zrobić jeszcze publiczną metodą dodawania nowych obiektów (`NCPEvent`) do listy. Wykonuj tą metodą zamiast powyższego kodu nad komentarzami w listenerze.

Przykład: https://github.com/iBotSpeak/iBot/blob/master/ibot-core/src/main/java/pl/themolka/ibot/store/DatabaseThread.java


We totally can because it's just a generated file so if compat-table changes it's not affected until we rerun the script + publish


Можно span


trying it again


@martior are you talking about the NewsML feed? if so, please open a new issue.


Hey @ramphis,

No, it was a project that I intended to start on but never got around too. It's just scaffolding at the moment. I should probably take it down if people are searching and finding it.


Zdarza się :P Najlepsza praktyka to taka, żeby w projekcie zawsze ustawiać domyślne wartości, a dopiero na testowym w tym przypadku serwerze mieć rzeczywiste dane.


класс называется .pagintaion


specify the default


(You should join our #development room on slack)


Oh,

I see. It would be great if someone finishes the integration with Nexudus and Wordpress.


Yay!


I don't know much about dottydoc, @felixmulder is who you want ;)


Thanks. I added this to the original repo.


Fixed, see https://github.com/matsengrp/linearham/commit/ecb8c82c7db877c3b0bf70fa487d3e9bcf8daf7e.


Probably unintended?


Added /Windows/Panther/WaSetup.xml (Azure provisioning agent log)


@rcoop017 — this one could be done like this: bf5086379e2c68e7f329bf724de66e5a2072acfd


Hi, why did you remove this? You would have needed to enable Travis CI building for this repository, and it would have worked...


Collaborator:
A review for this commit was created. [Link to review](http://dev.visitry.org/ui#review:id=117)


The following doc(s) have been deployed to the [terminus1x](https://terminus1x-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/terminus/install](https://terminus1x-static-docs.pantheonsite.io/docs/terminus/install)
- [source/_partials/footer_scripts.html](https://github.com/pantheon-systems/documentation/commit/827aef3c2a81da33503c97ad83e942601460e111/source/_partials/footer_scripts.html)


I guess only for completeness, just in case you have aligned you movies before and already have some shifts per frame. Anyway, I think if you use unblur you will use it at the beginning when there are no shifts.


Wait,


I was wondering about that. This does look better.


I don't know much about round-off error in the computer, but these NPadding probabilities in partis files don't seem to add to 1, so I'm wondering if it'll affect us?


Ive had to change this line to the below as the table prefix is been left off of the query:
  $table_prefix = \Config::get('db.default.table_prefix');
  $sql .= ' AS '.$db->quote_identifier($table_prefix.$this->_alias);

An example of the issues I am having:
  http://bin.fuelphp.com/snippet/view/NO


@hoverbear thanks so much, just one small comment above.

Looks awesome and thanks for adding all the instructions around things. We've received feedback that it would help to know what's required in the plan file, in particular.

Thanks!


Good advice. I dont have the time today to code this up, but I'll have a think and work on it either tomorrow or the day after.
Cheers @gpushack !


Damn, I noticed that after my changes to the Sprint effect now the quick kick crashes GZDoom...
I tried to fix it but with no avail... Anyone can fix it? :sob:


close #834


Is this alright?


клик здесь не нужен


Sorry to ask,what's the meaning of "$PATH"


Этот метод нао реализовать используя класс new Select


more love


Are you sure you want to ignore all exceptions? Is there a specific exception you want to ignore?


//*[@id='content']//input[@value='Delete'] - так короче и точнее


//*[@id='content']//input[@value='Enter'] - такой локатор точнее


клик не нужен


Associating with #4 with this commit


поиск сделать внутри метода 1 раз


使用 `getFieldDecorator` 后，即使用户没有输入，也会自动增加 `value=undefined`，所以不能用 `in` 做检测。


//*[@id='LoginForm']/input[@value='Login']


或者我们应该统一语义，`undefined` 视为没有设置，`null` 视为故意置空。


γίνεται δοκιμή!


I still have problem to apply the patch. it is strange that I manually compare the content with the path, seems it should be able to apply. can u repo in your env? I also include my git version here, not sure if it is related.

+++++++ Creating torchenv.cmd luajit.cmd luarocks.cmd cmake.cmd
+++++++ Setup succeed!
+++++++ Updating submodules
+++++++ Installing common lua packages
cl /nologo /MD /O2 -c -Fosrc/lfs.obj -IC:/torch/install/include src/lfs.c
lfs.c
link -dll -def:lfs.def -out:lfs.dll C:/torch/install/lib/lua51.lib src/lfs.obj
Microsoft (R) Incremental Linker Version 14.00.24215.1
Copyright (C) Microsoft Corporation.  All rights reserved.

lfs.obj : warning LNK4197: export 'luaopen_lfs' specified multiple times; using first specification
   Creating library lfs.lib and object lfs.exp
No existing manifest. Attempting to rebuild...
luafilesystem 1.6.3-1 is now installed in C:\torch\install\luarocks\systree (license: MIT/X11)

penlight scm-1 is now installed in C:\torch\install\luarocks\systree (license: MIT/X11)

C:\torch\win-files\patch\lua-cjson.patch:9: trailing whitespace.
            "strncasecmp=strnicmp",
C:\torch\win-files\patch\lua-cjson.patch:23: trailing whitespace.
        fprintf(stderr, "strbuf(%p) reallocs: %d, length: %d, size: %d\n",
C:\torch\win-files\patch\lua-cjson.patch:24: trailing whitespace.
                s, s->reallocs, s->length, s->size);
C:\torch\win-files\patch\lua-cjson.patch:34: trailing whitespace.
        fprintf(stderr, "strbuf(%p) resize: %d => %d\n",
C:\torch\win-files\patch\lua-cjson.patch:35: trailing whitespace.
                s, s->size, newsize);
error: patch failed: lua-cjson-2.1devel-1.rockspec:47
error: lua-cjson-2.1devel-1.rockspec: patch does not apply
error: patch failed: strbuf.c:94
error: strbuf.c: patch does not apply
+++++++ Installation error!

C:\torch>git --version
git version 2.9.2.windows.1


Probably, but at least the sources would be in sync :)


int in=14;
int p=15;
int vector[10]={4,5,6,7,8,9,10,11,12,13};
int a=3;
int jh=3;
int d=14;
int valor=random(4,14);
int cont=1;
void setup()
{
 pinMode(13,OUTPUT);
 pinMode(12,OUTPUT);
 pinMode(11,OUTPUT);
 pinMode(10,OUTPUT);
 pinMode(9,OUTPUT);
 pinMode(8,OUTPUT);
 pinMode(7,OUTPUT);
 pinMode(6,OUTPUT);
 pinMode(5,OUTPUT);
 pinMode(4,OUTPUT);
  pinMode(1,INPUT);
  pinMode(2,INPUT);
  pinMode(3,INPUT);
}

void loop() {
   if(digitalRead(1)==LOW &&digitalRead(2)==HIGH&&digitalRead(3)==LOW)
   {
    while(in>3)
     {
      in=in-2;
     digitalWrite(in,HIGH);
     delay(200);
     digitalWrite(in,LOW);
     delay(200);
     }
     in=14;
   }
  if(digitalRead(1)==LOW &&digitalRead(2)==HIGH&&digitalRead(3)==HIGH)
   {
    while(p>3)
     {
      p=p-2;
     digitalWrite(p,HIGH);
     delay(500);
     digitalWrite(p,LOW);
     delay(500);
     }
     p=15;
   }
  if(digitalRead(1)==HIGH &&digitalRead(2)==HIGH&&digitalRead(3)==LOW)
   {
   while(d>=9&&a<=8)
     {
      d=d-1;
      a=a+1;
     digitalWrite(d,HIGH);
     digitalWrite(a,HIGH);
     delay(500);
     digitalWrite(d,LOW);
     digitalWrite(a,LOW);
     delay(500);
     }
     d=14;
     a=3;
   }
  if(digitalRead(1)==HIGH &&digitalRead(2)==LOW&&digitalRead(3)==HIGH)
   {

     digitalWrite(valor,HIGH);
     delay(500);
     digitalWrite(valor,LOW);
     delay(500);
     valor= random(4,14);
   }
 if(digitalRead(1)==HIGH &&digitalRead(2)==HIGH&&digitalRead(3)==HIGH)
   {
    for(;cont<6;cont++)
    {
    while(jh<=14)
    {
      jh=jh+1;
      digitalWrite(jh,HIGH);
      delay(200);
      digitalWrite(jh,LOW);
      delay(200);
     }
     jh=3;
    }
   }

}


How do you think you could do this in parallel?


If some error occurrs during sending, `outChan` would be probably closed. But `inChan` would remain open, even if connection in all other terms would be closed. Actually it wouldn't, cause `True` is passed, but that was source of bug fixed in TW-56, and now it's `False`. And this implies that `listenRaw` thread would be waiting for data that would never come (cause noone can write into `inChan`). Solution: explicitly close both `inChan`, `outChan`.


why are you using `Wait()` instead of `await' here


Weird connotation. You should not need the`.++`


no way!


![](https://github.trello.services/images/mini-trello-icon.png) [Potential bug identified by a customer:](https://trello.com/c/yxFI2nnb/121-potential-bug-identified-by-a-customer)


just for test


@howard0su I can not reproduce this trailing whitespace problem. My git version is: git version 2.10.1.windows.1
By the way, it looks like your distro is out-of-date according to the console output.


Probably missed this before. But is there a reason we do `Try { rc.response.get }`? Why would the type be a `Try` instead of an `Option`? Perhaps I'll find the answer later in the code.


这是一个测试哈


This doesnt make any sense to me


here comes the dan complaints


Thanks for the clarification!


Add an empty line after the copyright header and before the "package" line.


Add a minimal Javadoc description. Like "Action to instantiate a new instance of views that support it".


φωτογραφίες σχετικές με επαυξημένη πραγματικότητα


rip.


Is this required? If it's not referenced elsewhere, I don't think it's needed, no?

Also for new IDs, you can use "org.eclipse.tracecompass.*". The *linuxtools* ones are old ones that are kept as-is for compatibility.


sorry for commit title, it would be publisher


Should should always be private, with higher-visibility getter and/or setters as required. Let's do better than the fPinAction above ;)


I feel like it would be more straightforward if the menuManager was passed as a method parameter, instead of having the code here do all the dance to get it itself. But if the code for the existing action is already like that, you can leave it this way.


Yes, this looks much better. But if you only care about the materialized value of the `clientConnectionFlowWithPipeline`, you don't need to pass all three in as part of `GraphDSL.create(...)`. Just one is enough. The other two can be `add`ed but that is all not absolutely necessary.  Lets see:

```scala
  Flow.fromGraph(GrapDSL.create(clientConnectionFlowWithPipeline) { implicit b =>
    clientFlow =>
      import GraphDSL.Implicits._
      val toRC = b.add(toRequestContext)
      val fromRC = b.add(fromRequestContext)

      toRC ~> clientFlow ~> fromRC

      FlowShape(toRC.in, fromRC.out)
  })
```


empty line


Ditto here.


Since this is a "utils" class, which means it only contains static methods and no internal state, you can prevent it by being instantiated by doing these things:
* making the class `final`
* adding a empty private default constructor ( `private TmfViewFactory() {}` )


Yes, we do loose the failure details. Perhaps we need to do something about it.


Está tudo errado.


playerFund can be initialPlayerFund


Should be changed to answer B) right?


Everything else looks clear to me. Thanks a ton!


What about using `@NonNullByDefault` on the class, so it prevents all null parameters? Changes the run-time checking into a compile-time checking, which is more robust.


the <div> tags goes inside the body tag.


very nice work :)


Also see [Issue 331](http://github.com/weidai11/cryptopp/issues/331).


you could avoid the internal boolean variable by doing

    return toStringUUID.equals(uuid);


and here just

    return false;


Quite clear and quite straightforward! I noted a few small things, after that I think it should be good for upstream review!


You can just import AcquireGame.AcquireStatistics then there would be no need to do AcquireStatistics. else where in the code.


add


I guess rowMapping is not required here?


FINAL


Use `private static class` for inner classes, unless you have reasons not to.


Should continue the good practice of making all fields private ;)


juego luces


space before the second `+`. Highlight + `Ctrl+Shift+F` should all fix it.


I think this is the correct condition you need to have to check for singleton. Even if one cell is marked then it is not singleton right?
if (!board[row - 1][col].isMarked() || !board[row][col - 1].isMarked() || !board[row][col + 1].isMarked()
				|| !board[row + 1][col].isMarked()))


Typically for static final constants we use ALL_CAPS names. So should be SEPARATOR and UUID.


There's an error here - actual key must be 'pass'!


SeuYacc


You can use `assertEquals()` to compare two values directly. It should work also with null values, so you wouldn't need the if branch above.


empty line


Quick javadoc plz


Keep an empty line between the description and the `@author`


Good catch, would you like to do the fix or shall I?


You can use `/** One-line Javadoc */`, it'll take as much space as a SuppressWarnings ;)


No need to check again that "tile" is not growing, because the flow in the calling method calls isMerging only if it is not growing so this check is redundant.


If a method's implementation it to just call `super.theMethod()`, you don't need to `@Override` it at all. It will call the super-method already.


This doesn't work for builds on Jenkins machines where every test should be isolated for other activity on the box.  See http://platform-jenkins.zenoss.eng/job/ControlCenter/job/develop/job/merge-ui-acceptance/27/ - the `jenkins` user doesn't have permission to create that directory.

The `test_lib.sh` file invoked by `acceptance.sh` called by Jenkins already sets up a directory for SERVICED_ETC_PATH.  So I think what will work here is simplly
```
touch ${SERVICED_ETC_PATH}/logconfig-cli.yaml
```

Does


This is very good, neat implementation.


add a space after the comma


You don't clear the outbound list too? If it's on purpose, please add a comment why, it's something that will raise questions.


You can fix it 👍 . Oh alright I shall try do that. This is still pretty new to me haha


ctrl+shift+f this block


This is good. One thing you can do here is, since you have already checking whether the tile is already dead tile or not in isMerging method you sent the the tile isDeadTile property to true and return false there and here first check whether the tile is already set, if not then check using your validateDeadTile method. Use OR to short circuit here.


Instead of doing `containsKey()` then `get()` on a Map/Multimap, you can just do `get()` and check if the returned value is null. It avoids an extra lookup.

There is however a difference of behaviour between the two if you allow null keys/values. But if you don't allow null key/values (I don't remember if Guava multimaps even allow those, most of their data structures don't), then you can live with just a `get()`.


Won't this samHotelCount should be outside the first for loop?


If you are not gonna use ignoredClass further, you can use `anyMatch()` which returns a boolean directly.


If you've imported `Optional`, you don't need to repeat the full class path.


> Can you do a PR for the typo?

Done: https://github.com/elm-lang/core/pull/746


Yep, that's how it should be since the label is matching the query.

On Tue, Nov 1, 2016 at 12:13 PM, yuanzhou <notifications@github.com> wrote:

> @jnguyenx <https://github.com/jnguyenx> after I switched to use
> documents(), many labels are highlighted as well.
>
> [image: capture]
> <https://cloud.githubusercontent.com/assets/195873/19903629/abfbf9ea-a045-11e6-8f6f-e34abdfe1e1e.PNG>
>
> Is this expected?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/monarch-initiative/monarch-app/commit/56113758018749b63569bd217575824ea5640104#commitcomment-19652736>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AEHMGOxzTlnOWo-q098p23l6gZtuHb8dks5q549egaJpZM4KjhLF>
> .
>


Check.


The EUnit documentation says the following:

> If there is no exception, the result of the macro expression is the atom ok, and the value of BoolExpr is discarded.


Here's a tweak to get the link text localizable ("`Check it out!`"): 71f212834380378e94fa70d660e4ce7448cd83c8

Basically, just replacing the text with another `FormattedMessage` inline.


test db starts out being empty? where is it "seeded"? can we seed the the data right here instead?


The next (final) chunk of this file will use the same strategy, but is more of a doozy.


Thanks!


Something is wrong with
a) your master. It should show Stockfish 8, like your Patch 1 and 2 tests

b) your methodology.
    Testing a +- 1 change on a feature like this
    which usually occur at most once in a position is like measuring noise.

    This is less than 1 centipawn !
    Consider that PawnValueMg   = 188,   PawnValueEg   = 248,
    And then, the final evaluation value is an interpolation between the total mg and eg values of all the features, depending on the remaining material on board. At that point, your +-1 will be almost non-existent.


This slipped through from development. I will revert the change in the morning (and commit it without the export_all).


We'll also have to do the tooltips, of course, but we can do that separately.


It should be `public _cache: CacheService` in `ModelService`'s  constructor.


Only thing missing here is an if statement to text if we're back on desktop.


Should be 5-minute constructives


🚯 remove `console.log`


The new Preferences → Remote tab looks like good progress. :smile:

Sizing is out, but that should be pretty easy to adjust:

![screen shot 2016-11-01 at 19 53 41](https://cloud.githubusercontent.com/assets/406299/19905073/2323de3a-a06d-11e6-9efd-c3879858ce16.png)

As a thought when testing the PUT stuff, these are some curl commands I found useful:

```
$ curl -w "%{http_code}" --cert src/client.crt --cacert src/certs/mlnt.crt \
    -T devcrapdb1.sqlite https://server:5550/username/databasename
```

* `-w "%{http_code}"` - tells curl to print out the http return code (useful)
* `--cert src/client.crt` - gives the path to the combined client cert + it's key (as generated by the dbhub-datagen WebUI)
* `--cacert src/certs/mlnt.crt ` - gives the path to our CA chain files (root CA cert + intermediate cert)
* `-T [filename]` - path to the file to upload
* `https://server:5550/username/databasename` - Server to PUT to.  The initial server implementation of PUT code doesn't understand subdirectories yet.  So, keep everything for a user in their main dir for now.  eg don't do this:
 * `https://server:5550/username/folder1/folder2/folder3/databasename`


@rcoop017 — I realize it's a bit heavy-handed to introduce all this markup for each bit of text, but the upshot is that when it comes time to localize, the person translating doesn't have to know anything about the code or formatting (no HTML, styles, etc.) — just pieces of plain text.


Good point, I made the change : 42f6e0682dcd86e496b08b8c429777b1eef8773a. Thanks :)


Only thing missing here is an if statement to test if we're back on desktop.


I feel like I might have made more work for you... But thanks for looking everything over! These examples really help.


@sig Unless I'm mistaken, this feature is in LMS only and so there is no need to add it to CMS env files.


Btw, feel free to try out incorrect path names and stuff if you want.  In theory the server should (mostly) return reasonable error codes for things it doesn't like.

In theory it should also be reasonably crash resistant already too. I hope. 😀


Not at all! You did the heavy lifting.

I'm sure there will be a few other odd cases we'll run into as well.


I think just for this project, I'll leave the uppercase as opposed to having ALL CAPS in the index. Or is there a better way?


Nope, this makes more sense for translators. I just need these examples to wrap my head around the right way to go through the files.


`254` is a magic number. it should be a defined as a named const.

you can also do `some` nicer syntax.
```
if ( [req.body.title.length, req.body.createdBy.length, req.body.assignedTo.length].some(length => length > MAX_INPUT_LENGTH) ) { ... }
```


i.e. best practice


Yea that iterator deserves more in life than to beg.


hmm why did add these extra margin styles which is overwriting the required ones?


Only thing missing in the resize block is an if statement to test if we're back on desktop.


Hey @timohund, can you fix this typo please?
https://github.com/TYPO3-Solr/ext-solr/pull/628#ref-commit-a6ebe00


do not hardcode the full url. if this app is deployed to a server at http://react-kanban.com
then it will make `POST` requests to `http://localhost:3000/...` which of course will not work.
use a relative path.


True.


++ for me. Problem solved. Thanks @diracdeltas !


Fixed in commit https://github.com/TrinityCore/TrinityCore/commit/28f891df85a6d66f09681419fb24ed9a2e4ba116 (just for future reference).


# Pierwszy sukces! #
I co o tym myślisz @Dabrok ?


should be targeting `header nav .close-nav`, not the span inside.


correction: `@media only screen`


What an amazing color.


How should I handle this if header 1 and 2 are different sizes but both are supposed to be "centered" on the background image?


same correction needed as written above.


@Jester565
I'll be sure to answer those questions next meeting. Yea it's my fault I should have went over the structure of CommProtocol last meeting instead of talking about the projects we are undergoin', lulz. I move too fast in this stuff..


Haskell is amazing.


@Nuppi : check again after commit https://github.com/TrinityCore/TrinityCore/commit/28f891df85a6d66f09681419fb24ed9a2e4ba116 (SQL typo fix).


should be "100%" as a string.


missing semi-colon


so far so good, you need to add "style" in the parenthesis so `$('header nav').removeAttr('style')`. Also watch the element you're targeting, it's not a class.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/172396800


I think something might be missing here. When I check out this branch and run "make test" I get an error. Searched through the makefiles and I can't seem to find a `ct` target.


yea, I'll just make macro:
#define pLogXXX_Debug(fmt, ...) pLogXXX(fmt, ##__VA_ARGS__) Which will be swapped with dummy macro on release builds


Collaborator:
A review for this commit was created. [Link to review](http://dev.visitry.org/ui#review:id=118)


not seeing the styles required on mobile here


Got it.  I'll keep adding questions and examples.  This is more to help me
understand some of the coding done in the library but maybe it will prove
useful to others as I more examples are added.  Also, its fine to go over
our objectives so we know which part of the library we need to focus on.

On Tue, Nov 1, 2016 at 1:13 PM Mario Garcia <notifications@github.com>
wrote:

> @Jester565 <https://github.com/Jester565>
> I'll be sure to answer those questions next meeting. Yea it's my fault I
> should have went over the structure of CommProtocol last meeting instead of
> talking about the projects we are undergoin', lulz. I move too fast in this
> stuff..
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/Jester565/CommColab/commit/7b7a44cfa7e0cf01608d390138b050588ee1ede3#commitcomment-19653664>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AQ3NDNGOVdSX28ylhMQirHXe3yifMFwzks5q551ugaJpZM4KmhnE>
> .
>


@rcoop017 — here's my take on this chunk: 1727b92f4d5a273299a5da3a2fee14e3be9d4156


Glad to see how to write like that in readme.md . Thank you. Merged.


yep, this looks good


should be "100%" as a string


OK, I did not know that.  Thanks for pointing it out.  But if that is true, then the spec you added for `integer_test` (returning `integer()`) is wrong and should be fixed.


Sorry, I accidentally committed & pushed to master. Reverting.


fast-forwarding master to auto = f06f5749


good commit


yeah... i clearly didnt look at the contributors before writing that, sorry


put put


vxv


ok


This change needs to wait until https://github.com/radanalyticsio/oshinko-s2i/pull/43 is merged because it relies on changes in start.sh and also erases the APP_MAIN_CLASS option which was a workaround for no java s2i/templates.


Hmmm Atom doesn't like the syntax of .class tag {}


Done.


@ggrochow remember why we toggled the validator to not be case sensitive?

Was the intention to make searching case insensitive for login?


Actually, you are right. I have reverted the commit.


On the other hand... Probably it's not the best moment to introduce this new workflow, because I will be offline through most of November, and I won't be able to answer questions (nor update the Developers' page). If you're not sure what I mean, then ignore this, and we will talk about it when I'm back.


@rcoop017 — one last thing in this file:

I'm realizing that the `target` attributes of the `Tooltipcomp` tags contain text that needs to be localized (while the actual content of the tooltips live elsewhere).

I'm going to rework the implementation of this component so that the target text can be specified as a child component, which is more idiomatic to React, e.g.

**Old:**
```HTML
<Tooltipcomp id="foo" text={tooltiptext.bar} target="Hover over me" />
```

**New:**
```HTML
<Tooltipcomp id="foo" text={tooltiptext.bar}>
  Hover over me
</Tooltipcomp>
```

Then we can wrap their child target text in `FormattedMessage` tags, e.g.:
```HTML
<Tooltipcomp id="foo" text={tooltiptext.bar}>
  <FormattedMessage ...>
    Hover over me
  </FormattedMessage>
</Tooltipcomp>
```


it's my pleasure :)


Should be 'slash' - good spot, thanks!


![](https://github.trello.services/images/mini-trello-icon.png) [Building scene 1 in renpy](https://trello.com/c/kFCS9Eyj/76-building-scene-1-in-renpy)


?? if you want seed for test db, we can just run db:seed RAILS_ENV=test


To be used with NetBeans: Open with tools >> options >> c/c++ >> import.


I used Ruby (to require the 'Sinatra')
I also used the terminal so I could run the server.


Success! After some cleanup (see last commits) I am able to compile a program for the STM32F427! It still requires the old source folder in the include path, getting rid of that is the next step.


it doesn't matter anyway


yeah, I think this was supposed to make emails case-insensitive unique.
to prevent email collisions that weren't same casing, so that logins didn't get messed with


no i don't want to see. i'm curious why are you logged in assuming there is already a user. that's not a good practice in general


How about adding an option to specify daylight or standard time for this one case where it is unclear if you want to change to the Daylight 1am or the Standard 1am, and give the default as Daylight, so that existing code is unaffected. The option would be ignored except in cases where the given absolute time is not specific enough for the zone of the Time object.


@stefanholek Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.customerize/1/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/customerize/__init__.py:0:1: C101 Coding magic comment not found
plone/app/customerize/__init__.py:0:1: I001 isort found changes, run it on the file
plone/app/customerize/__init__.py:9:19: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/__init__.py:9:21: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/__init__.py:10:18: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/__init__.py:10:20: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/__init__.py:11:5: E124 closing bracket does not match visual indentation
plone/app/customerize/__init__.py:12:1: W391 blank line at end of file
plone/app/customerize/browser.py:0:1: C101 Coding magic comment not found
plone/app/customerize/browser.py:0:1: I001 isort found changes, run it on the file
plone/app/customerize/browser.py:20:80: E501 line too long (82 > 79 characters)
plone/app/customerize/browser.py:25:65: W291 trailing whitespace
plone/app/customerize/browser.py:38:13: E128 continuation line under-indented for visual indent
plone/app/customerize/browser.py:42:45: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/browser.py:42:47: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/browser.py:43:36: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/browser.py:43:38: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/browser.py:43:57: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/browser.py:43:59: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/browser.py:50:54: Q000 Remove bad quotes.
plone/app/customerize/browser.py:60:1: W391 blank line at end of file
plone/app/customerize/registration.py:0:1: C101 Coding magic comment not found
plone/app/customerize/registration.py:0:1: I001 isort found changes, run it on the file
plone/app/customerize/registration.py:2:80: E501 line too long (80 > 79 characters)
plone/app/customerize/registration.py:14:1: E302 expected 2 blank lines, found 1
plone/app/customerize/registration.py:15:80: E501 line too long (81 > 79 characters)
plone/app/customerize/registration.py:23:1: E302 expected 2 blank lines, found 1
plone/app/customerize/registration.py:28:1: E302 expected 2 blank lines, found 1
plone/app/customerize/registration.py:33:15: P002 found "hasattr", consider replacing it
plone/app/customerize/registration.py:51:1: E302 expected 2 blank lines, found 1
plone/app/customerize/registration.py:57:80: E501 line too long (83 > 79 characters)
plone/app/customerize/registration.py:76:1: E302 expected 2 blank lines, found 1
plone/app/customerize/registration.py:78:5: E731 do not assign a lambda expression, use a def
plone/app/customerize/registration.py:78:20: E231 missing whitespace after ','
plone/app/customerize/registration.py:81:18: W601 .has_key() is deprecated, use 'in'
plone/app/customerize/registration.py:84:28: E201 whitespace after '{'
plone/app/customerize/registration.py:84:56: E202 whitespace before '}'
plone/app/customerize/registration.py:85:48: E231 missing whitespace after ','
plone/app/customerize/registration.py:87:1: E302 expected 2 blank lines, found 1
plone/app/customerize/registration.py:91:12: E111 indentation is not a multiple of four
plone/app/customerize/registration.py:91:80: E501 line too long (81 > 79 characters)
plone/app/customerize/registration.py:92:16: E111 indentation is not a multiple of four
plone/app/customerize/registration.py:94:1: E302 expected 2 blank lines, found 1
plone/app/customerize/registration.py:95:13: S001 found %s formatter
plone/app/customerize/registration.py:100:1: E302 expected 2 blank lines, found 1
plone/app/customerize/registration.py:106:25: W291 trailing whitespace
plone/app/customerize/registration.py:113:1: E302 expected 2 blank lines, found 1
plone/app/customerize/registration.py:119:1: E302 expected 2 blank lines, found 1
plone/app/customerize/registration.py:125:1: E302 expected 2 blank lines, found 1
plone/app/customerize/registration.py:132:11: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/registration.py:132:13: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/registration.py:133:13: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/registration.py:133:15: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/registration.py:134:13: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/registration.py:134:15: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/registration.py:135:19: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/registration.py:135:21: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/registration.py:136:13: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/registration.py:136:15: E251 unexpected spaces around keyword / parameter equals
plone/app/customerize/registration.py:138:1: E302 expected 2 blank lines, found 1
plone/app/customerize/registration.py:142:1: W391 blank line at end of file
plone/app/customerize/tool.py:0:1: C101 Coding magic comment not found
plone/app/customerize/tool.py:0:1: I001 isort found changes, run it on the file
plone/app/customerize/tool.py:11:7: E221 multiple spaces before operator
plone/app/customerize/tool.py:23:1: W391 blank line at end of file
plone/app/customerize/tests/__init__.py:0:1: C101 Coding magic comment not found
plone/app/customerize/tests/layer.py:0:1: C101 Coding magic comment not found
plone/app/customerize/tests/layer.py:0:1: I001 isort found changes, run it on the file
plone/app/customerize/tests/layer.py:3:1: E302 expected 2 blank lines, found 1
plone/app/customerize/tests/testDocTests.py:0:1: C101 Coding magic comment not found
plone/app/customerize/tests/testDocTests.py:0:1: I001 isort found changes, run it on the file
plone/app/customerize/tests/testDocTests.py:17:1: E402 module level import not at top of file
plone/app/customerize/tests/testDocTests.py:22:1: E302 expected 2 blank lines, found 1
plone/app/customerize/tests/testDocTests.py:25:1: W293 blank line contains whitespace
plone/app/customerize/tests/testDocTests.py:36:55: S001 found %s formatter
plone/app/customerize/tests/testDocTests.py:45:1: E302 expected 2 blank lines, found 1
plone/app/customerize/tests/testDocTests.py:51:16: E713 test for membership should be 'not in'
plone/app/customerize/tests/testDocTests.py:53:21: E128 continuation line under-indented for visual indent
plone/app/customerize/tests/testDocTests.py:54:21: E128 continuation line under-indented for visual indent
plone/app/customerize/tests/testDocTests.py:55:21: E128 continuation line under-indented for visual indent
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.