Ah je n'avais pas vu cette différence. En effet il y a des fonctions en
doublon je t'en avais parlé : j'ai juste repris en brut les fonctions
d'util.txt de templf/x, il y avait quelques fonctions de même nom mais de
code différents et celles de templx sont renommées _f (pas eu le temps de
creuser en détail).

Pour ces trois modules en plus, il y a des plus et des moins c'est pour ça
qu'il faut encore élaguer, voir qui on garde (des fonctions et des modules
eux-mêmes et du code des modules si on merge un dans l'autre au niveau de
ceux « complets », c'était cette histoire de mettre image=on/off et avoir
un seul module plutôt que 2 pour seulement les photos).

Pour le parents de templf je ne suis pas sûr de vouloir le modifier, à
priori c'est la seule chose que les gens aimaient de templf d'après le
retour de Dominique qui l'utilise : avoir les parents côte à côte « centrés
» autour du mariage, puis en dessous les enfants avec photo. J'aimerais que
les gens puissent se refaire un templf-like avec les modules s'ils le
désirent, pas qu'ils soient trop paumés et abandonne l'utilisation de
GeneWeb à cause de nos changements radicaux sur le template.

– A2

2016-11-07 17:40 GMT+01:00 hgouraud <notifications@github.com>:

> Premières réactions :
>
> dans parents-evolués-photo, je mettrais le heading fer à gauche comme tous
> les autres, et la photo du père %left; plutôt que %right;
> dans frèressoeurs-complet-photo, je conserverais la photo de %self; (à
> corriger à la fois dans frèressoeurs-complet-phot et dans perso-utils -
> test central_index!!)
>
> il semblerait que la fonction half_father fonctionne mal!!
> Dans frèressoeurs-complet, je n’ai que la demi-fratrie maternelle alors
> que dans frèressoeurs-complet-photo j’ai les deux demi frtatries!!
> (j’ai remarié mes parents pour tout tester sur la même fiche!!)
> Ces deux fichiers n’utilisent pas la même méthode pour détecter et exposer
> les demi-fratries!!
>
> A suivre (je disparais 2h)
>
> Henri
> ---
> > Le 7 nov. 2016 à 16:46, A2 <notifications@github.com> a écrit :
> >
> > Use HTML 5 and Bootstrap 4 syntax in default template
> >
> > * Remove templates a-f.
> > * Transform templf/x to new perso_modules.
> > * Complete revamp of menubar.
> > * Fix lot of typo on modules.
> > * Fix lot of W3C HTML5 errors/warnings (with help of @hgouraud).
> > * Fix a few issues in gwd error log (@hgouraud)
> > * Add Font Awesome CDN for icons (this need to be transformed to a local
> CSS/font)
> >
> > --
> > You are receiving this because you were mentioned.
> > Reply to this email directly or view it on GitHub:
> > https://github.com/a2line/geneweb/commit/11e4a483353afe934a3bc39a636051
> 3b2b9c4a83
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/a2line/geneweb/commit/11e4a483353afe934a3bc39a6360513b2b9c4a83#commitcomment-19724803>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AJ3852c79G62eh5E3cVFuJatZXZ5wFIsks5q71R1gaJpZM4KrXKh>
> .
>


5000 new objects in the stg - looks niche, but  not good for frame rate. maybe stgmerge can help?


That's weird comment.


Thanks! 👍


@dkayiwa , no objections as long as things still work on 1.9-1.12 when no legacyui module is present.  This was never a problem prior to legacy UI.


shorter version try/catch + Enum.valueOf("CIRCLE")


Where does the `/a/changes/...` come from?  On my gerrit instance, the REST endpoint is just `$URL/changes/.../revisions/.../review`.  There is no `/a/` prefix.


Very Good


It's not good to allow inconsistent Circle obejct to be created (default consutrctor needs to be hidden)


example of bad comment (sorry to call you out, I'm not trying to be mean). Use Slack, or make an issue on github, or send people emails.


Good that you've tried to modularize logic


example of a good/acceptable comment. It helps to explain the code, so it is helpful for people reading it.


What is your license on this? I would like to use part of it.


Some info on handling clock drift in MPEG-DASH:

ISO_IEC_23009-1_2014
A.8 Encoder clock drift control
Non-alignment between the end of a Representation in one Period and the start time of the next Period may be caused by encoder clock inaccuracy. The client should align the Media Presentation time at each Period start. In addition, significant deviations of the start time of Segments to the media time should be detected and drift-compensating measures may be applied even before the start of the next Period is reached.

ISO_IEC_14496-12_5th
Producer Reference Time Box
Definition
Box Type:	`prft’
Container:	File
Mandatory:	No
Quantity:	Zero or more
The producer reference time box supplies relative wall-clock times at which movie fragments, or files containing movie fragments (such as segments) were produced. When these files are both produced and consumed in real time, this can provide clients with information to enable consumption and production to proceed at equivalent rates, thus avoiding possible buffer overflow or underflow.
This box is related to the next movie fragment box that follows it in bitstream order. It must follow any segment type or segment index box (if any) in the segment, and occur before the following movie fragment box (to which it refers). If a segment file contains any producer reference time boxes, then the first of them shall occur before the first movie fragment box in that segment.
The box contains a time value measured on a clock which increments at the same rate as a UTC-synchronized NTP [RFC 5905] clock, using NTP format. This is associated with a media time for one of the tracks in the movie fragment. That media time should be in the range of times in that track in the associated movie fragment.
Producer reference times should be associated with at most one track.

Syntax
aligned(8) class ProducerReferenceTimeBox extends FullBox(‘prft’, version, 0) {
	unsigned int(32) reference_track_ID;
	unsigned int(64) ntp_timestamp;
	if (version==0) {
		unsigned int(32)	media_time;
	} else {
		unsigned int(64)	media_time;
	}
}
Semantics
reference_track_ID provides the track_ID for the reference track.
ntp_timestamp indicates a UTC time in NTP format corresponding to decoding_time.
media_time corresponds to the same time as ntp_timestamp, but in the time units used for the reference track, and is measured on this media clock as the media is produced.
NOTE 	in most cases this timestamp will not be equal to the timestamp of the first sample of the adjacent segment of the reference track, but it is recommended it be in the range of the segment containing this producer reference time box.


Can someone check this? After that commit, Im no longer able to remove a sandbag or a tank trap. I removed the rightclick on toolbox action for tank traps a while ago so I think both were only scroll action froms vanilla dayz.


walkFileTree would work, but I don't think it lets us take full advantage of the problem's structure.  One trick we can take advantage of is that we know their filenames - it's always `.gitattributes` - and we only care about folders which are parents of the files we're formatting.  I'm inclined to use a trie and iterate over the input files to populate a list of all the tip folders, then we can move toward the root testing for `.gitattributes` along the way.  I've had great luck with [this library](https://github.com/npgall/concurrent-trees#Concurrency_Support) in the past.  If you're up for it I'll let you have it @jbduncan, or if you prefer I can take it.


Dieses Twinery sieht sehr gut aus.
Nun sollten wir und (zu zweit oder zu Dritt? *sadface*) dranmachen ne Grundidee auszuarbeiten.
Will im Febraur anfangen eine Asset-Sammlung zu erstellen  <3


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 1](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1372&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


All should be fine because it is included at https://github.com/openmrs/openmrs-core/blob/1.9.0/webapp/src/main/webapp/WEB-INF/template/include.jsp#L8


Semantically speaking, I object.


Typo here. Check your work and make sure it still compiles. Or double check the diff on github and make sure that you're commit did what you meant to do and then fix your mistakes if you made any. This has been fixed by Dan.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 1](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1372&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:33


Typo still exists


Syntax error here. probably a typo from trying to delete a line or something. This should have been something you noticed right away and fixed, make sure you double check your work. This has been fixed by dan


dfghjklç


@dkayiwa do you know why legacyui complains about it being included twice, yet no problem exists with it being included twice when it is in core?  Perhaps since the URI was the same previously, it didn't complain, but once tags are defined with the same prefix but a different URI, then this is when it complains?


Why not check if `@magisterSchool.url` contains `https://*.magister.net` ?


Maybe it's unlikely to change, but could you make the 3 a constant instead of a hardcoded number?
It's used in a second place and if you change only one of them, you will screw up.


Dude, you added a typo. ????


Looks it failed with 3 spaces.


You can retrieve the basket from the reference number (order number). See `OrderNumberGenerator.basket_id`.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 2](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1373&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


@mseaton you got it. That is exactly the answer! :)
Could also be knowing why it was duplicated here yet it already existed in core?


You should look into Environment Variables for these so as to hide these for anyone not outside your app. At the moment anyone could come along and use these keys to impersonate your app. So you'll want to store the keys elsewhere and not commit this to github ideally


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 2](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1373&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **SUCCESS**
Summary: Running Build time: 00:01:15


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/173952210


test commit comment.


In vasishath's sources used one driver for both devices.


You are free to browse/use the code for personal uses, but you may not distribute the plugin/code as your own.


You are free to browse/use the code for personal use, but you may not distribute this code as plugin as your own. :)


first one


fast-forwarding master to auto = 11d91ffc


Can we somehow change this and not hardcode the library version number?


我说怎么一直不显示呢，最后找到问题所在，不过我是在代码中加了一个函数
`- (void)didAddSubview:(UIView *)subview {

    if ([subview isKindOfClass:NSClassFromString(@"_UIBarBackground")]) {
        [self insertSubview:self.overlay aboveSubview:subview];
    }
}`


Ah, interesting looking library! Reminds me of persistent (functional) collections a bit.

I admit I'm only vaguely familiar with tries, so I'm not terribly confident I could tackle this on my own, thus I'd be happy if you were to take it. :)


is_highlighted should be defined in the calendar xml view not hardcoded.


Same as last commit, should we move the call to `enable_sweep_scheduling` down a couple lines to avoid any potential race conditions?


Yes, figured it right now.
test fixtures are incorrect.
I'll switch to pytest-aiohttp.

What's about build badge?


Thanks @cbenz


Merged to staging. Thanks for spotting this issue before the commit goes to master!


![image](https://cloud.githubusercontent.com/assets/4039449/20067703/2adad05c-a50e-11e6-8b40-aa7244a70362.png)

I guess you need `aiohttp_debugtoolbar` > `aiohttp-debugtoolbar` for both the link and image.


i'd probably throw this into its own render method to make it easier to read. ternary operations are great but encapsulating this in a `#renderActivity` (working title) method


Thanks @pnbt


Must be identical!


Should be fixed with [https://github.com/EternalBlueFlame/Traincraft-5/commit/4904727337198c10bb4000e52bf8489e071d3dec](https://github.com/EternalBlueFlame/Traincraft-5/commit/4904727337198c10bb4000e52bf8489e071d3dec)
To an extent this cant be _fully_ fixed due to the way we handle movement, but this is pretty close.


хмм, чувак, а ты хорош. В 13 лет игрушку написал. При чем не на просто Unity, а на pygame)


the String::valueOf will work


think you probably wanted this to be:

```
$sequence = "";
```


Don't you think that there are 2 almost identical pieces of code?


Instead of packing all this code into a single-clause receive block, could we just do a call to `receive_msg`? I think that would feel a little cleaner.


I'm not sure we can use an array in a resource collector, see https://docs.puppet.com/puppet/4.8/reference/lang_collectors.html#search-expressions

> == (equality search)
>
> This operator is non-symmetric:
>
> The left operand (attribute) must be the name of a resource attribute or the word title (which searches on the resource’s title).
> **The right operand (search key) must be a string, boolean, number, resource reference, or undef. The behavior of arrays and hashes in the right operand is undefined in this version of Puppet**.
> For a given resource, this operator will match if the value of the attribute (or one of the value’s members, if the value is an array) is identical to the search key.
>

I'm pretty sure this approach doesn't restart the service when it's expected


Hi, I too have the same issue."Authorization has been denied for this request". Can you suggest me how to overcome?


Ok no worries; might be worth putting that in as a comment, especially since for a lot of other things you're using official data and not in-game data.

Anyway, sorry for submitting the wrong value and thanks for getting back to me.


aS


Use /* for inline comment, /** is javadoc. You could say:

  /* Check if the [source, signal] tuple is blacklisted. */


Prego!

but... I left out a word. :-o


I adapted your change to hammerhead's QCamera2: https://github.com/airend/android_device_lge_hammerhead/commit/7e7c62eaf9df9f0cab3485f21a2259d8e12e9864 (with the corresponding hardware changes). My issue on N5 is about green artifacts in recorded video, periodic fadeouts with Google Camera, or stable green sidebar with AOSP Camera. Did you happen to encounter anything like this?


Hey, could you please build a new version for Windows with these new optimizations? Thanks a lot if you will. :)


The factory method 'getConverterForClass' is used inside the JaDi Framework.

The factory Itself is basically a collection of typed converters.

AddConverter is called by the user during init; at best before anything else.
This factory should be a main part of the JanusDixie and get added by the JanusDixieBuilder.

It could be part of the interface, but I'd prefer to introduce another interface to differ between different types of factory


Looking into it more, everything is right as far as debug logs can tell me, and its all done in proper methodology according to forge documents, so I think we're gonna need someone with more experience to fix this problem.


[R/create_phyloseq_class.R:43:13:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/create_phyloseq_class.R#L43) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if ( !all((c('TAXA', 'LEVEL')  %in% colnames(utils::read.table(merge_table, header = T))))) {
            ^
```
[R/plot_nmds_analysis.R:64:5:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L64) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
    data.scores.df <- as.data.frame(vegan::scores(data.scores))
    ^~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:73:5:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L73) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
    data.scores.df$samples <- rownames(data.scores.df)
    ^~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:73:40:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L73) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
    data.scores.df$samples <- rownames(data.scores.df)
                                       ^~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:75:5:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L75) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
    data.scores.plot <- dplyr::left_join(data.scores.df, meta_data, on = "samples")
    ^~~~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:75:42:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L75) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
    data.scores.plot <- dplyr::left_join(data.scores.df, meta_data, on = "samples")
                                         ^~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:81:36:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L81) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
      ggplot2::geom_polygon(data = data.scores.plot,
                                   ^~~~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:82:1:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L82) *style:* **lines should not be more than 100 characters.**
```r
                            ggplot2::aes_string(x = data.scores.plot$NMDS1, y = data.scores.plot$NMDS2, fill = shape_grp, group = shape_grp), alpha = 0.30) +
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:82:53:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L82) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
                            ggplot2::aes_string(x = data.scores.plot$NMDS1, y = data.scores.plot$NMDS2, fill = shape_grp, group = shape_grp), alpha = 0.30) +
                                                    ^~~~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:82:81:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L82) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
                            ggplot2::aes_string(x = data.scores.plot$NMDS1, y = data.scores.plot$NMDS2, fill = shape_grp, group = shape_grp), alpha = 0.30) +
                                                                                ^~~~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:84:34:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L84) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
      ggplot2::geom_point(data = data.scores.plot,
                                 ^~~~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:85:1:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L85) *style:* **lines should not be more than 100 characters.**
```r
                          ggplot2::aes_string(x = data.scores.plot$NMDS1, y = data.scores.plot$NMDS2, shape = shape_grp, colour = col_grp),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:85:51:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L85) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
                          ggplot2::aes_string(x = data.scores.plot$NMDS1, y = data.scores.plot$NMDS2, shape = shape_grp, colour = col_grp),
                                                  ^~~~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:85:79:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L85) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
                          ggplot2::aes_string(x = data.scores.plot$NMDS1, y = data.scores.plot$NMDS2, shape = shape_grp, colour = col_grp),
                                                                              ^~~~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:88:1:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L88) *style:* **lines should not be more than 100 characters.**
```r
      ggplot2::geom_text(ggplot2::aes(x = max(data.scores.plot$NMDS1), y = min(data.scores.plot$NMDS2),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:88:47:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L88) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
      ggplot2::geom_text(ggplot2::aes(x = max(data.scores.plot$NMDS1), y = min(data.scores.plot$NMDS2),
                                              ^~~~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:88:80:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L88) *style:* **Words within variable and function names should be separated by '_' rather than '.'.**
```r
      ggplot2::geom_text(ggplot2::aes(x = max(data.scores.plot$NMDS1), y = min(data.scores.plot$NMDS2),
                                                                               ^~~~~~~~~~~~~~~~
```
[R/plot_nmds_analysis.R:89:1:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/plot_nmds_analysis.R#L89) *style:* **lines should not be more than 100 characters.**
```r
                                      label = paste("stress:", round(data.scores$stress, 3), sep = " "), hjust = "inward")) +
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/summary_pheatmap.R:99:1:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/R/summary_pheatmap.R#L99) *style:* **lines should not be more than 100 characters.**
```r
    plots <- pheatmap::pheatmap(as.matrix(phyloseq::otu_table(otables, taxa_are_rows = T)), main = as.character(LEVEL), ...)$gtable
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_plot_nmds_analysis.R:32:1:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/tests/testthat/test_plot_nmds_analysis.R#L32) *style:* **lines should not be more than 100 characters.**
```r
expect_that(plot_nmds_analysis("../test_data/merged_table.tsv", LEVEL = "man", metadata = "../test_data/mock_metadata.tsv", shape_grp = "fac_category",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_plot_nmds_analysis.R:38:1:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/tests/testthat/test_plot_nmds_analysis.R#L38) *style:* **lines should not be more than 100 characters.**
```r
expect_that(plot_nmds_analysis("../test_data/merged_table.csv", LEVEL = "class", metadata = "../test_data/mock_metadata.tsv", shape_grp = "fac_category",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_plot_nmds_analysis.R:43:1:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/tests/testthat/test_plot_nmds_analysis.R#L43) *style:* **lines should not be more than 100 characters.**
```r
expect_that(plot_nmds_analysis("../test_data/merged_table.csv", LEVEL = "class", metadata = "../test_data/mock_metadata.tsv", shape_grp = "fac_category",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_summary_pheatmap.R:37:1:](https://github.com/seninp-bioinfo/MetaComp/blob/12ca8ab8d030627274a0f0c0deab96e10bd8c248/tests/testthat/test_summary_pheatmap.R#L37) *style:* **lines should not be more than 100 characters.**
```r
expect_that(summary_pheatmap("../test_data/merged_table.csv", clustering_distance_cols = "uclidean"), throws_error())
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


Collaborator: Review for this commit was created. [Link to review](http://localhost:8080/ui#review:id=1366)


overall


Этот отступ лучше для li, а не для ссылок.


Well, in this case, I just applied the patch that was submitted in JIRA (as said in the commit message).


Этот селектор означает тот же элемент, что и .main-navigation ul выше по коду, пишите css-свойства в какой-то один селектор, а второй удалите.


you absolutely cannot wrap so many things in try catch. i have said this before. please don't do this.


Submitting the task to Taskcluster failed.
Details:

```js
You do not have sufficient scopes. This request requires you
to have one of the following sets of scopes:
[
  [
    "queue:route:notify.email.dklawren@users.noreply.github.com.on-any",
    "queue:route:notify.irc-channel.#bteam.on-failed",
    "queue:route:notify.irc-channel.#bteam.on-exception",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.914633c099c61e9fff6acb93c98b072c6d91467a"
  ]
]

You only have the scopes:
[
  "assume:repo:github.com/mozilla-bteam/bmo:branch:development",
  "queue:create-task:aws-provisioner-v1/github-worker",
  "queue:define-task:aws-provisioner-v1/b2gtest",
  "queue:route:gaia-taskcluster",
  "queue:route:index.garbage.*",
  "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-development.*",
  "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-master.*",
  "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-upstream-merge.*",
  "queue:route:tc-treeherder.bmo-development.*",
  "queue:route:tc-treeherder.bmo-master.*",
  "queue:route:tc-treeherder.bmo-upstream-merge.*",
  "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.*",
  "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-master.*",
  "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-upstream-merge.*",
  "secrets:get:garbage/*",
  "secrets:set:garbage/*"
]

In other words you are missing scopes from one of the options:
 * Option 0:
    - "queue:route:notify.email.dklawren@users.noreply.github.com.on-any", and
    - "queue:route:notify.irc-channel.#bteam.on-failed", and
    - "queue:route:notify.irc-channel.#bteam.on-exception"
----
errorCode:  InsufficientScopes
statusCode: 403
requestInfo:
  method:   createTask
  params:   {"taskId":"DV-riPp2RIOsXKTafg4GPA"}
  payload:  {
  "provisionerId": "aws-provisioner-v1",
  "workerType": "github-worker",
  "routes": [
    "notify.email.dklawren@users.noreply.github.com.on-any",
    "notify.irc-channel.#bteam.on-failed",
    "notify.irc-channel.#bteam.on-exception",
    "tc-treeherder.v2.mozilla-bteam/bmo-development.914633c099c61e9fff6acb93c98b072c6d91467a"
  ],
  "extra": {
    "github": {
      "env": true,
      "events": [
        "pull_request.opened",
        "pull_request.synchronize",
        "pull_request.reopened",
        "push"
      ]
    },
    "treeherder": {
      "symbol": "San",
      "machine": {
        "platform": "linux64",
        "build": {
          "platform": "linux64"
        }
      }
    }
  },
  "payload": {
    "maxRunTime": 3600,
    "image": "mozillabteam/bmo-ci",
    "command": [
      "runtests.sh"
    ],
    "env": {
      "TEST_SUITE": "sanity",
      "GITHUB_EVENT": "push",
      "GITHUB_BRANCH": "development",
      "GITHUB_BASE_SHA": "d212c453253b7c07f698f5cf1d33205e36da11bb",
      "GITHUB_BASE_BRANCH": "development",
      "GITHUB_HEAD_REPO_URL": "https://github.com/mozilla-bteam/bmo.git",
      "GITHUB_HEAD_USER": "dklawren",
      "GITHUB_HEAD_SHA": "914633c099c61e9fff6acb93c98b072c6d91467a",
      "GITHUB_HEAD_BRANCH": "development",
      "GITHUB_HEAD_USER_EMAIL": "dklawren@users.noreply.github.com"
    },
    "artifacts": {
      "public/runtests_log": {
        "type": "file",
        "path": "/var/log/runtests.log"
      }
    }
  },
  "metadata": {
    "name": "Basic Sanity Tests",
    "description": "Basic Sanity Tests",
    "owner": "dklawren@users.noreply.github.com",
    "source": "https://github.com/mozilla-bteam/bmo.git"
  },
  "created": "2016-11-07T17:32:14.488Z",
  "deadline": "2016-11-08T17:32:14.488Z",
  "taskGroupId": "DV-riPp2RIOsXKTafg4GPA",
  "schedulerId": "taskcluster-github",
  "dependencies": [],
  "requires": "all-completed",
  "priority": "normal",
  "retries": 5,
  "scopes": [],
  "tags": {},
  "expires": "2017-11-08T17:32:14.488Z"
}
  time:     2016-11-07T17:32:14.553Z
details:
{
  "scopesets": [
    [
      "queue:route:notify.email.dklawren@users.noreply.github.com.on-any",
      "queue:route:notify.irc-channel.#bteam.on-failed",
      "queue:route:notify.irc-channel.#bteam.on-exception",
      "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.914633c099c61e9fff6acb93c98b072c6d91467a"
    ]
  ],
  "scopes": [
    "assume:repo:github.com/mozilla-bteam/bmo:branch:development",
    "queue:create-task:aws-provisioner-v1/github-worker",
    "queue:define-task:aws-provisioner-v1/b2gtest",
    "queue:route:gaia-taskcluster",
    "queue:route:index.garbage.*",
    "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-development.*",
    "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-master.*",
    "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-upstream-merge.*",
    "queue:route:tc-treeherder.bmo-development.*",
    "queue:route:tc-treeherder.bmo-master.*",
    "queue:route:tc-treeherder.bmo-upstream-merge.*",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.*",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-master.*",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-upstream-merge.*",
    "secrets:get:garbage/*",
    "secrets:set:garbage/*"
  ]
}
```


Submitting the task to Taskcluster failed.
Details:

```js
You do not have sufficient scopes. This request requires you
to have one of the following sets of scopes:
[
  [
    "queue:route:notify.email.mozilla-bteam@users.noreply.github.com.on-any",
    "queue:route:notify.irc-channel.#bteam.on-failed",
    "queue:route:notify.irc-channel.#bteam.on-exception",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.914633c099c61e9fff6acb93c98b072c6d91467a"
  ]
]

You only have the scopes:
[
  "assume:repo:github.com/mozilla-bteam/bmo:pull-request",
  "queue:create-task:aws-provisioner-v1/github-worker",
  "queue:define-task:aws-provisioner-v1/b2gtest",
  "queue:route:gaia-taskcluster",
  "queue:route:index.garbage.*",
  "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-development.*",
  "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-master.*",
  "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-upstream-merge.*",
  "queue:route:tc-treeherder.bmo-development.*",
  "queue:route:tc-treeherder.bmo-master.*",
  "queue:route:tc-treeherder.bmo-upstream-merge.*",
  "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.*",
  "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-master.*",
  "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-upstream-merge.*",
  "secrets:get:garbage/*",
  "secrets:set:garbage/*"
]

In other words you are missing scopes from one of the options:
 * Option 0:
    - "queue:route:notify.email.mozilla-bteam@users.noreply.github.com.on-any", and
    - "queue:route:notify.irc-channel.#bteam.on-failed", and
    - "queue:route:notify.irc-channel.#bteam.on-exception"
----
errorCode:  InsufficientScopes
statusCode: 403
requestInfo:
  method:   createTask
  params:   {"taskId":"ML9cFUL_T-CKVdv4Wic8gQ"}
  payload:  {
  "provisionerId": "aws-provisioner-v1",
  "workerType": "github-worker",
  "routes": [
    "notify.email.mozilla-bteam@users.noreply.github.com.on-any",
    "notify.irc-channel.#bteam.on-failed",
    "notify.irc-channel.#bteam.on-exception",
    "tc-treeherder.v2.mozilla-bteam/bmo-development.914633c099c61e9fff6acb93c98b072c6d91467a"
  ],
  "extra": {
    "github": {
      "env": true,
      "events": [
        "pull_request.opened",
        "pull_request.synchronize",
        "pull_request.reopened",
        "push"
      ]
    },
    "treeherder": {
      "symbol": "Doc",
      "machine": {
        "platform": "linux64",
        "build": {
          "platform": "linux64"
        }
      }
    }
  },
  "payload": {
    "maxRunTime": 3600,
    "image": "mozillabteam/bmo-ci",
    "command": [
      "runtests.sh"
    ],
    "env": {
      "TEST_SUITE": "docs",
      "GITHUB_EVENT": "pull_request.synchronize",
      "GITHUB_BRANCH": "master",
      "GITHUB_PULL_REQUEST": 8,
      "GITHUB_BASE_REPO_URL": "https://github.com/mozilla-bteam/bmo.git",
      "GITHUB_BASE_USER": "mozilla-bteam",
      "GITHUB_BASE_SHA": "8de8d611eb6d9b872f6c2ff3b0a09d9c62dfe7f3",
      "GITHUB_BASE_BRANCH": "master",
      "GITHUB_BASE_REF": "master",
      "GITHUB_HEAD_REPO_URL": "https://github.com/mozilla-bteam/bmo.git",
      "GITHUB_HEAD_USER": "mozilla-bteam",
      "GITHUB_HEAD_SHA": "914633c099c61e9fff6acb93c98b072c6d91467a",
      "GITHUB_HEAD_BRANCH": "development",
      "GITHUB_HEAD_USER_EMAIL": "mozilla-bteam@users.noreply.github.com"
    },
    "artifacts": {
      "public/runtests_log": {
        "type": "file",
        "path": "/var/log/runtests.log"
      }
    }
  },
  "metadata": {
    "name": "Documentation Build Test",
    "description": "Documentation Build Test",
    "owner": "mozilla-bteam@users.noreply.github.com",
    "source": "https://github.com/mozilla-bteam/bmo.git"
  },
  "created": "2016-11-07T17:32:14.707Z",
  "deadline": "2016-11-08T17:32:14.707Z",
  "taskGroupId": "XDmBatm8R2GHpCYIwsgT4A",
  "schedulerId": "taskcluster-github",
  "dependencies": [],
  "requires": "all-completed",
  "priority": "normal",
  "retries": 5,
  "scopes": [],
  "tags": {},
  "expires": "2017-11-08T17:32:14.707Z"
}
  time:     2016-11-07T17:32:14.758Z
details:
{
  "scopesets": [
    [
      "queue:route:notify.email.mozilla-bteam@users.noreply.github.com.on-any",
      "queue:route:notify.irc-channel.#bteam.on-failed",
      "queue:route:notify.irc-channel.#bteam.on-exception",
      "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.914633c099c61e9fff6acb93c98b072c6d91467a"
    ]
  ],
  "scopes": [
    "assume:repo:github.com/mozilla-bteam/bmo:pull-request",
    "queue:create-task:aws-provisioner-v1/github-worker",
    "queue:define-task:aws-provisioner-v1/b2gtest",
    "queue:route:gaia-taskcluster",
    "queue:route:index.garbage.*",
    "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-development.*",
    "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-master.*",
    "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-upstream-merge.*",
    "queue:route:tc-treeherder.bmo-development.*",
    "queue:route:tc-treeherder.bmo-master.*",
    "queue:route:tc-treeherder.bmo-upstream-merge.*",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.*",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-master.*",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-upstream-merge.*",
    "secrets:get:garbage/*",
    "secrets:set:garbage/*"
  ]
}
```


Submitting the task to Taskcluster failed.
Details:

```js
You do not have sufficient scopes. This request requires you
to have one of the following sets of scopes:
[
  [
    "queue:route:notify.email.dklawren@users.noreply.github.com.on-any",
    "queue:route:notify.irc-channel.#bteam.on-failed",
    "queue:route:notify.irc-channel.#bteam.on-exception",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.914633c099c61e9fff6acb93c98b072c6d91467a"
  ]
]

You only have the scopes:
[
  "assume:repo:github.com/mozilla-bteam/bmo:branch:development",
  "queue:create-task:aws-provisioner-v1/github-worker",
  "queue:define-task:aws-provisioner-v1/b2gtest",
  "queue:route:gaia-taskcluster",
  "queue:route:index.garbage.*",
  "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-development.*",
  "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-master.*",
  "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-upstream-merge.*",
  "queue:route:tc-treeherder.bmo-development.*",
  "queue:route:tc-treeherder.bmo-master.*",
  "queue:route:tc-treeherder.bmo-upstream-merge.*",
  "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.*",
  "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-master.*",
  "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-upstream-merge.*",
  "secrets:get:garbage/*",
  "secrets:set:garbage/*"
]

In other words you are missing scopes from one of the options:
 * Option 0:
    - "queue:route:notify.email.dklawren@users.noreply.github.com.on-any", and
    - "queue:route:notify.irc-channel.#bteam.on-failed", and
    - "queue:route:notify.irc-channel.#bteam.on-exception"
----
errorCode:  InsufficientScopes
statusCode: 403
requestInfo:
  method:   createTask
  params:   {"taskId":"d7dKk-0iQG2z5OhopG1iYQ"}
  payload:  {
  "provisionerId": "aws-provisioner-v1",
  "workerType": "github-worker",
  "routes": [
    "notify.email.dklawren@users.noreply.github.com.on-any",
    "notify.irc-channel.#bteam.on-failed",
    "notify.irc-channel.#bteam.on-exception",
    "tc-treeherder.v2.mozilla-bteam/bmo-development.914633c099c61e9fff6acb93c98b072c6d91467a"
  ],
  "extra": {
    "github": {
      "env": true,
      "events": [
        "pull_request.opened",
        "pull_request.synchronize",
        "pull_request.reopened",
        "push"
      ]
    },
    "treeherder": {
      "symbol": "API",
      "machine": {
        "platform": "linux64",
        "build": {
          "platform": "linux64"
        }
      }
    }
  },
  "payload": {
    "maxRunTime": 3600,
    "image": "mozillabteam/bmo-ci",
    "command": [
      "runtests.sh"
    ],
    "env": {
      "TEST_SUITE": "webservices",
      "GITHUB_EVENT": "push",
      "GITHUB_BRANCH": "development",
      "GITHUB_BASE_SHA": "d212c453253b7c07f698f5cf1d33205e36da11bb",
      "GITHUB_BASE_BRANCH": "development",
      "GITHUB_HEAD_REPO_URL": "https://github.com/mozilla-bteam/bmo.git",
      "GITHUB_HEAD_USER": "dklawren",
      "GITHUB_HEAD_SHA": "914633c099c61e9fff6acb93c98b072c6d91467a",
      "GITHUB_HEAD_BRANCH": "development",
      "GITHUB_HEAD_USER_EMAIL": "dklawren@users.noreply.github.com"
    },
    "artifacts": {
      "public/runtests_log": {
        "type": "file",
        "path": "/var/log/runtests.log"
      },
      "public/httpd_error_log": {
        "type": "file",
        "path": "/var/log/httpd/error_log"
      }
    }
  },
  "metadata": {
    "name": "WebService API Tests",
    "description": "WebService API Tests",
    "owner": "dklawren@users.noreply.github.com",
    "source": "https://github.com/mozilla-bteam/bmo.git"
  },
  "created": "2016-11-07T17:32:14.957Z",
  "deadline": "2016-11-08T17:32:14.957Z",
  "taskGroupId": "Tdi6spBIQT2sDLSnv5r2Hw",
  "schedulerId": "taskcluster-github",
  "dependencies": [],
  "requires": "all-completed",
  "priority": "normal",
  "retries": 5,
  "scopes": [],
  "tags": {},
  "expires": "2017-11-08T17:32:14.957Z"
}
  time:     2016-11-07T17:32:15.008Z
details:
{
  "scopesets": [
    [
      "queue:route:notify.email.dklawren@users.noreply.github.com.on-any",
      "queue:route:notify.irc-channel.#bteam.on-failed",
      "queue:route:notify.irc-channel.#bteam.on-exception",
      "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.914633c099c61e9fff6acb93c98b072c6d91467a"
    ]
  ],
  "scopes": [
    "assume:repo:github.com/mozilla-bteam/bmo:branch:development",
    "queue:create-task:aws-provisioner-v1/github-worker",
    "queue:define-task:aws-provisioner-v1/b2gtest",
    "queue:route:gaia-taskcluster",
    "queue:route:index.garbage.*",
    "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-development.*",
    "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-master.*",
    "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-upstream-merge.*",
    "queue:route:tc-treeherder.bmo-development.*",
    "queue:route:tc-treeherder.bmo-master.*",
    "queue:route:tc-treeherder.bmo-upstream-merge.*",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.*",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-master.*",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-upstream-merge.*",
    "secrets:get:garbage/*",
    "secrets:set:garbage/*"
  ]
}
```


Submitting the task to Taskcluster failed.
Details:

```js
You do not have sufficient scopes. This request requires you
to have one of the following sets of scopes:
[
  [
    "queue:route:notify.email.mozilla-bteam@users.noreply.github.com.on-any",
    "queue:route:notify.irc-channel.#bteam.on-failed",
    "queue:route:notify.irc-channel.#bteam.on-exception",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.914633c099c61e9fff6acb93c98b072c6d91467a"
  ]
]

You only have the scopes:
[
  "assume:repo:github.com/mozilla-bteam/bmo:pull-request",
  "queue:create-task:aws-provisioner-v1/github-worker",
  "queue:define-task:aws-provisioner-v1/b2gtest",
  "queue:route:gaia-taskcluster",
  "queue:route:index.garbage.*",
  "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-development.*",
  "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-master.*",
  "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-upstream-merge.*",
  "queue:route:tc-treeherder.bmo-development.*",
  "queue:route:tc-treeherder.bmo-master.*",
  "queue:route:tc-treeherder.bmo-upstream-merge.*",
  "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.*",
  "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-master.*",
  "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-upstream-merge.*",
  "secrets:get:garbage/*",
  "secrets:set:garbage/*"
]

In other words you are missing scopes from one of the options:
 * Option 0:
    - "queue:route:notify.email.mozilla-bteam@users.noreply.github.com.on-any", and
    - "queue:route:notify.irc-channel.#bteam.on-failed", and
    - "queue:route:notify.irc-channel.#bteam.on-exception"
----
errorCode:  InsufficientScopes
statusCode: 403
requestInfo:
  method:   createTask
  params:   {"taskId":"MvEd7e2cRVawwnGPxlHHFA"}
  payload:  {
  "provisionerId": "aws-provisioner-v1",
  "workerType": "github-worker",
  "routes": [
    "notify.email.mozilla-bteam@users.noreply.github.com.on-any",
    "notify.irc-channel.#bteam.on-failed",
    "notify.irc-channel.#bteam.on-exception",
    "tc-treeherder.v2.mozilla-bteam/bmo-development.914633c099c61e9fff6acb93c98b072c6d91467a"
  ],
  "extra": {
    "github": {
      "env": true,
      "events": [
        "pull_request.opened",
        "pull_request.synchronize",
        "pull_request.reopened",
        "push"
      ]
    },
    "treeherder": {
      "symbol": "API",
      "machine": {
        "platform": "linux64",
        "build": {
          "platform": "linux64"
        }
      }
    }
  },
  "payload": {
    "maxRunTime": 3600,
    "image": "mozillabteam/bmo-ci",
    "command": [
      "runtests.sh"
    ],
    "env": {
      "TEST_SUITE": "webservices",
      "GITHUB_EVENT": "pull_request.synchronize",
      "GITHUB_BRANCH": "master",
      "GITHUB_PULL_REQUEST": 8,
      "GITHUB_BASE_REPO_URL": "https://github.com/mozilla-bteam/bmo.git",
      "GITHUB_BASE_USER": "mozilla-bteam",
      "GITHUB_BASE_SHA": "8de8d611eb6d9b872f6c2ff3b0a09d9c62dfe7f3",
      "GITHUB_BASE_BRANCH": "master",
      "GITHUB_BASE_REF": "master",
      "GITHUB_HEAD_REPO_URL": "https://github.com/mozilla-bteam/bmo.git",
      "GITHUB_HEAD_USER": "mozilla-bteam",
      "GITHUB_HEAD_SHA": "914633c099c61e9fff6acb93c98b072c6d91467a",
      "GITHUB_HEAD_BRANCH": "development",
      "GITHUB_HEAD_USER_EMAIL": "mozilla-bteam@users.noreply.github.com"
    },
    "artifacts": {
      "public/runtests_log": {
        "type": "file",
        "path": "/var/log/runtests.log"
      },
      "public/httpd_error_log": {
        "type": "file",
        "path": "/var/log/httpd/error_log"
      }
    }
  },
  "metadata": {
    "name": "WebService API Tests",
    "description": "WebService API Tests",
    "owner": "mozilla-bteam@users.noreply.github.com",
    "source": "https://github.com/mozilla-bteam/bmo.git"
  },
  "created": "2016-11-07T17:32:15.093Z",
  "deadline": "2016-11-08T17:32:15.093Z",
  "taskGroupId": "LAbPNim6QSS6X83heRju-g",
  "schedulerId": "taskcluster-github",
  "dependencies": [],
  "requires": "all-completed",
  "priority": "normal",
  "retries": 5,
  "scopes": [],
  "tags": {},
  "expires": "2017-11-08T17:32:15.093Z"
}
  time:     2016-11-07T17:32:15.167Z
details:
{
  "scopesets": [
    [
      "queue:route:notify.email.mozilla-bteam@users.noreply.github.com.on-any",
      "queue:route:notify.irc-channel.#bteam.on-failed",
      "queue:route:notify.irc-channel.#bteam.on-exception",
      "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.914633c099c61e9fff6acb93c98b072c6d91467a"
    ]
  ],
  "scopes": [
    "assume:repo:github.com/mozilla-bteam/bmo:pull-request",
    "queue:create-task:aws-provisioner-v1/github-worker",
    "queue:define-task:aws-provisioner-v1/b2gtest",
    "queue:route:gaia-taskcluster",
    "queue:route:index.garbage.*",
    "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-development.*",
    "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-master.*",
    "queue:route:tc-treeherder-stage.v2.mozilla-bteam/bmo-upstream-merge.*",
    "queue:route:tc-treeherder.bmo-development.*",
    "queue:route:tc-treeherder.bmo-master.*",
    "queue:route:tc-treeherder.bmo-upstream-merge.*",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-development.*",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-master.*",
    "queue:route:tc-treeherder.v2.mozilla-bteam/bmo-upstream-merge.*",
    "secrets:get:garbage/*",
    "secrets:set:garbage/*"
  ]
}
```


давай ставить 2 пробела лучше(везде где есть по два класса) - для читабельности лучше.
НО - это не обязательно.  Главное делать одинаково


@Krudor @Shauren I can confirm the crashes, it continuosly does so on login


控制工程基础实验第二次MATLAB分析


overall 2


Что за .login? Не вижу такого класса в разметке.


same thing. don't do this.


Это .user-block, наверное)


логотип, не часть меню


@jethrogb I am a fan :) Want to submit a pull request?


I like it but maybe in public we shouldn't call it this (alas).  How about "wow"?  "superb?"


ты уверен что это каждая отдельная картинка?


.user-block a и .basket - два селктора, которые обозначают один элемент. Оставьте только один.


Since this is only used inside the block below, you could define it there to restrict the scope:

        Object source = signal.getSource();
        if (source != null) {
            boolean isBlackListed = fOutboundSignalBlacklist.get(source).stream()
                    .anyMatch(x -> x.isAssignableFrom(signal.getClass()));
            if (isBlackListed) {
                return;
            }
        }

You could also technically skip the variable entirely and put the stream() operation inside the if(), but I think it's better with the variable for clarity.


otherequip_endusesubcategory (nmerket) - i386-Windows-7-VisualStudio-12: OK (2317 of 2504 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-92.53%25-yellow.svg)


Это свойство задаётся родительскому элементу, в вашем случае - для .user-block.


If we're not using `Index` anymore, should we remove it altogether instead of just adding the underscore?


overall 3


I think it means something like "is a good idea" or even as a "Best Practice"
In any case, this study shows that in order to improve the efficiency of the solution, developers must measure and compare the actual performance of the proposed implementation, and consider the possibility of using different data structures and even languages for our evolutionary algorithm application.

Also measuring the Efficiency is part of the QA of the system.


Use /* for inline comments, applies to the rest of the file too.


shouldn't that be `args[0]`?


Just browsing the checkin I see a logger string that says "Decompressing LSP File"...probably copy/paste error.


if I use the 470K resistor from M0-GND do I still need to connect it to D10 on the nano or I just connect the M1 to D11? thanks for the answer


I guess is better to return a dictionary


This request should be almost in and of script before close log.


ну вот класс "причины" мне нравиться, но можно поставить его не в множественном роде.
Его оставь, а вот про рекомендации я бы подумал.
ещё вот не понятно,  почему у тебя тут элемент ризон, а потом начинается курс какой-то...
и ещё объясни мне все таки чем отличается блок с рекомендациями от ризона и курс ?


same


ещё __ подчеркивания поправь


I'll double check all added file for this !
On 2016-11-07 12:37 PM, alexmonthy wrote:
>
> Use /* for inline comments, applies to the rest of the file too.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/PSRCode/tracecompass/commit/879f54a5281f25247c70803c0047695efde8f7c4#commitcomment-19725811>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABvzMT36bB1BIEpeoHgvGw7ruOyUpwDeks5q72HigaJpZM4Krf4L>.
>

--
Jonathan R. Julien
Efficios


All comments addressed: https://github.com/bitcoinbook/bitcoinbook/commit/6b6655853bab46173a9603b6918081cfdcccca67


map__img or map__image будет лучше , это не карты )


Вот этот и ниже, что за селекторы? Нету же такого в разметке. Спрайт используется, чтобы задать фоновое изображение имеющимся в разметке элементам или псевдоэлементам, как у вас для .login::before сейчас написано.


This has any additional runtime comm interface decls that need to be provided by the specific comm layer implementation.  For example, for comm=ugni it has the network atomics functions that are referenced from the module code.  If no such additional interface thingies exist (such as for gasnet) this file can be left out and the empty one in runtime/include/comm will satisfy the #include in runtime/include/chpl-comm.h.


это не заголовок.
Сделай допустим дивом.
это не смысловая часть сайта


java (like primitive arrays or Buffers).  Space + primitive word.


Ещё background-repeat: no-repeat; нужно сюда добавить.


$coefficient? Don't shorten your variables please


space after cast:

    setPinned((Boolean) value);


It appears `get_lapack_funcs` is not available until scipy 0.12.0.  One option is to drop support for older scipy but 0.12 isn't that old (2013-04-07).

One option is to build our own that calls `lartg` when available otherwise does pure python...


usable


configuracion  y uso de algunas  aplicaciones


Shouldn't we specify proper nice level too?
Although this sets SCHED_RR, seems like nice level will be the default.


This


You changed the branch name...


I assume it is not being automatically generated because of the other error?


No difference between ConvertToDB and ConvertToFile
sendTo method is empty. What should this method do or send?


>{If it wrong:/
Then=so B we}<
Thanks for the use the for sale or withdrawal without notice this communication including attachments may contain information about this and the other hand I have to get back to you soon with more details on the phone with the following document copy document


ありがとうございました

On Mon, Nov 7, 2016 at 11:42 AM, Stephen McIntosh <notifications@github.com>
wrote:

> That's right, sorry. I'll fix it when I get home.
>
> 2016年11月7日(月) 10:55 Joshua Plicque <notifications@github.com>:
>
> > Are these symbols supposed to be :not_in instead of :in?
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub
> > <https://github.com/radicalbear/rad-hoc/commit/
> 42bf7bc33339c74b0c07572be31bc97ba37a2e34#commitcomment-19723907>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/ABp5Xm60vyvoMgsERub-
> QJB00yBmAdqHks5q70oHgaJpZM4KrX5Y>
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/radicalbear/rad-hoc/commit/42bf7bc33339c74b0c07572be31bc97ba37a2e34#commitcomment-19724853>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AG0HkjICowCuFKd8Zs2DMfaQECmjf9_Gks5q71UKgaJpZM4KrX5Y>
> .
>


Please check line 77-81. Insufficiently spaces.


You can use `{@link ...}` inside Javadoc to do hyperlinks to other classes/methods:

    {@link TmfView}  // link to another class
    {@link TmfView#setPinned} // link to a method in another class
    {@link #setPinned}  // link to a method in the current class


rfaUtils.py - good to print all errors in log file.


line 2 comment


"state" is not extremely clear... perhaps "pinned" would be a bit better? It is a bit redundant though... dunno, up to you.


**1. social** ( + не понятно зачем нужен тебе отдельный доп класс для обертки соц кнопок?)
2. модификаторы сделай tw/fb/youtube
3. social-link для каждой отдельной иконки, лучше по моему будет.
Пойми что бэм дает тебе независимость. Часто бывает что соц иконки ставят вверху сайта. в этом случае тебе придется менять уже название класса на хедер линк?
и кстати, а каждая отдельная иконка не может быть отдельная от других?


@arter97 -1 should be default, but it doesn't matter much, since the RR queue is seperate from the regular one and thus the nice value is just relevant between the RR processes.


"documents" --> "document"


подчеркивания


@sainttx Timings v2!


это не курс!


Ahh the hastag was sometyhing i was looking for thanks

On 2016-11-07 12:46 PM, alexmonthy wrote:
>
> You can use |{@link ...}| inside Javadoc to do hyperlinks to other
> classes/methods:
>
> |{@link TmfView} // link to another class {@link TmfView#setPinned} //
> link to a method in another class {@link #setPinned} // link to a
> method in the current class |
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/PSRCode/tracecompass/commit/80f17c484df02330fca3c8c348c595d282b3f7c5#commitcomment-19725932>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABvzMcmUPFQvSpjtoombYD6Oo3YhEhXtks5q72PdgaJpZM4KrgOd>.
>

--
Jonathan R. Julien
Efficios


I thought that args[0] is the self?


maybe "[if] you are adding a tasking model and it will be ..."?


JDOUBLE_BUFFER_TYPE was selected for the check since it's the last one to be loaded?


Ah, that makes sense, thanks.


Ah great. Btw has Motorola released patches on utilizing this?


similar to above, maybe "[If] you are adding a comm layer and it requires ..."?


Let check what is used for the setEnabled from swt:

public void setEnabled(boolean enabled) {

pinned it is ! Or we can leave this as a canary :smile:

On 2016-11-07 12:47 PM, alexmonthy wrote:
>
> "state" is not extremely clear... perhaps "pinned" would be a bit
> better? It is a bit redundant though... dunno, up to you.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/PSRCode/tracecompass/commit/80f17c484df02330fca3c8c348c595d282b3f7c5#commitcomment-19725945>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABvzMS7wON5QTcWuwCVMvYDA0q9naNusks5q72QdgaJpZM4KrgOd>.
>

--
Jonathan R. Julien
Efficios


Why the added parentheses here?


ещё договорились  классы писать первыми а потом все остальное..


I'm presuming this executes faster, should we do this everywhere possible?


@AirwavesMan I can confirm with the latest github repo I can remove both sandbags/tanktraps still.

Remove Hedgehog (Steel)
Remvoe Bagfence

options are present


I'm pretty sure this kind of XREF is literally impossible, so the assertion is still valid.


good ideas! feel free to implement said changes.


rfaUtils.py - there is not verification:
- 42.txt empty file
- no 42.txt file.


Up front here, maybe encourage them to start with a copy of the files for a similar existing layer (gasnet for a comm layer, fifo for a tasking layer, etc.).  That will make things much easier and prevent a lot of errors having to do with putting things in the wrong file and such (which are easy to make otherwise).  Just a sentence or two short paragraph should be enough.


There is no way to do a early return here? Like

    if (!thingEnabled) {
        return;
    }

it would avoid adding yet another level of cyclomatic complexity or w/e that is called...


@chrislovecnm I realize some of the stuff is going to be out of scope for this pull-request. For example, I don't intend to provide support for every vendor in the initial pull. I'm really just doing a brain exercise here, to show everyone how I'm thinking about the usage from a users point of view. I intend to add a "Scope" section to the pull-request description, to note the exact tasks that will be addressed.


Overall looks good and it's nice to have this more generalized.  I just made a few per-line comments, and don't think I need to see it again unless you want me to run through to check the changes for typos.


The other class is final, this one could be too? It doesn't really matter, but might as well have them the same.


oh haha, ill return those rules then


Thx for that, it was my own fault. I missed the crowbar...


"Only the +txid+ of a segwit transaction can be considered immutable by third parties and only if _all_ the inputs of the transaction are segwit inputs." sounds strange to me


Isn't this meant to be `&self->i2c`?


I'll use a translation key in a future commit, but for sure before any release :)


Thanks for the cc - is there a way to have auto-update work with vim plugins that have additional build steps (like ctrlp-cmatcher)?


you can remove this empty line


Rather than just saying `StatusAfter = StatusBefore`, could we actually concretely say that they both equal `{[SP1], []}`?


     if (self->globalSeed > 0) {
          curseed = (self->globalSeed + count * mult) % PYO_RAND_MAX;
      }
 @@ -992,6 +984,7 @@ Server_generateSeed(Server *self, int oid)
      }

      PYO_RAND_SEED = curseed;
 +    printf("set seed to : %u\n", PYO_RAND_SEED);

      return 0;
  }


Don't think so. This was plain old anyway, we revamped it to work on newer android Versions


Ok dunno - I just used this code https://github.com/wrye-bash/wrye-bash/commit/b5af66372d03655fb00e7c8bf4b3f9791b096db2 that I found on your clone - nsi is not a priority for me as I don't know the code and it will suck up too much of my time to grok - I wish someone could rewrite this nsi installer :(


Sunil - is this part of 4.7 or do we have to create a JIRA issue and patches for 4.6/4.7?


Вот здесь нужен либо класс, либо каскад .options-item h3, потому что у вас на страницах h3 используются не только в div class="options-item" и такой селектор по тегу повлияет на h3 в div class="dignitys-description-1", например.


![](https://github.trello.services/images/mini-trello-icon.png) [Scrap club list and events from RA](https://trello.com/c/GlIhnR5a/3-scrap-club-list-and-events-from-ra)


git amend --author='<insert name and email here>'


เพิ่มไฟล์
เดินได้แต่ซ้ายขวา555


See my comment in the STOP BUILDING GENERIC DTS commit


Extending #36


Well I will check it for accuracy and I do plan on making the NSI info for Skyrim SE so most likely that will resolve the issue.  I'll make it for Fallout 3 and Fallout NV as well because it really should be there.


Hello,

I have tried to fix issue related to interdependent method invocations.
Unfortunately this fix does not touch problem with interdependent static method invocations.
Please review commit.


Верхний и нижний отступы поменьше, учитывайте высоту самой строки.


No bo to nie ma szans dzialac.

Czescia klasy moga byc pola albo metody - a Ty dales petle : P

Musisz zrobic inaczej. Chcesz metode ktora bedzie zwracala nazwy uzytkownikow? Tak?

To robisz public (bo bedzie publiczna) List<String> (bo zwraca nazwy uzytkownikow) names() {

//i tutaj zbierasz i zwracasz nazwy uzytkownikow.

}


Sorry, that was a little flip. What I mean is the *encoding* of a direct cross-reference to a generic parameter only works if you can get to the parameter from its DeclContext, and there's no way to do that if the DeclContext is just the file. So something else fishy is going on.


@AirwavesMan happens to the best of us!!


@MrPowerGamerBR I personally prefer v1 so I don't think I'll be updating this


@hurtsky you didnt enabled lz4 compression in your kernel script, why?


library should not contains lockfile.


There were some changes that did not make it in the merge that are causing the crash, I'm guessing Shauren will commit them when he has time.


#7 this is initial part of adding unit tests to the project


Hmmm... I originally intended this function to be more general than just colon function handing... (ie, we could use it for /, or querying the user for something)This kinda breaks that. Maybe we can pass in a historyCallback, that each client can either supply or omit?


I thought this repository was just a mirror of the one on bucardo.org? Did that change recently?


For some reason elastic_search and kafka exit upon docker-compose up


__API Description file syntax error on line 514__: base type 'application/json' is not defined in the document (Autogenerated message from apiary.io)


2383_RefrigPeakDemand (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Hi @ilmari, yes this is now canonical; I think it's been a few months now.


This line is repeated twice?


Ok yep - on  different commit for fallout3/nv as we don't support that on dev yet. Btw this fallout 3/nv I would like to revisit for 308 - the branch with the support contains a lot of warnings, long lines etc that should be smoothed out before merging to dev

And now for the rest of the evening I turn to code a bit, hmmm


Already fixed on my side...


good


В PHP коде поставь одинарные кавычки


this should be sooner in the patch list ! an not related to this patch


Does using a string to evaluate result in a performance penalty?


Is this really needed? From my experience not having it, doesnt degrade performance


Ooh, thanks.
I've renamed all `aiohttp_*` libraries to `aiohttp-*`.
Please report me if you will find the same issue for other lib.


2383_RefrigPeakDemand (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Не нужно сравнивать с nil, как и с true/false, эти значения уже логические, нет смысла сравнивать скажем 1 c nil, т.к. если там 1, то это истина, а если там nil то это ложь без сравнения. Кроме того, у тебя сравнивается только последняя часть,  т.е. `с == nil`. Чтобы сравнить каждое значение, надо 3 сравнения написать.

Но в итоге, у тебя должно быть такое выражение:

`if !a || !b || !c`

Отрицание используем, т.к. условие должно стать истинным, если в одной из переменных nil.

Ну и "вишенка на торте": нет никакого смысла сравнивать с nil вообще, т.к. если у пустой строки вызывать to_f (а именно пустая строка возрващается, если пользователь ничего не ввел), как и у любой другой, отличной от числа строки, то вернется значение 0.0. Т.о. в переменных вообще не может быть nil :-)


This commit overwrites the human vs human test driver.  :desktop_computer:
I propose that we put the AI in its own class, that way it doesn't depend on the existence of WJChess.java which will be deleted when we have the GUI


@zkourouma i made the change here: https://github.com/itorras13/omdbReact/commit/d46575e91d6a7c1e4cfda32cbe612314d1aff4ca . Let me know if that is what you were looking for. Thanks again!


:) Комментарий полезный, но лучше эмоциональный окрас убрать. Оставить по существу:
"В свойстве формата checkbox, если по умолчанию установлено значение да, то его потом невозможно снять."


Are you able to get a stack trace for the error? That's usually the first thing you want to debug something like this, it will tell you specifically what went wrong. If you run the app through Android Studio such that the logging is printed to the console, you should be able to get the stack trace that way. Another option would be to [try one of these methods](http://stackoverflow.com/questions/7841232/java-android-how-to-print-out-a-full-stack-trace) to log the stack trace yourself.


Thx :)


Настрой редактор на отступ ровно в 2 проблела. Причем, именно пробела, а не таба. Т.е. должна быть замена табов на пробелы, т.н. soft tabs. Найди в интернете как сделать soft tabs для твоего редактора


Значение основания, как и стороны не обязательно будет целым


Do we want to leave this as well-formedness, in the long term, or do we want to make it a grammatical error?


@kevmoo did you mean: take a look at the pull request?


А зачем делать if, если уже есть while? Ведь если значение меньше 0, то запустится цикл, а если больше, то не запустится, и if ни на что не влияет. И, кстати, пожалуй, 0 тоже недопустимое значение.


Опять лишний if


Высоат может быть и не целым числом


Должно быть меньше или равно 0


I think provide syntax in general needs an overhaul.

If it doesn't get one, then this is probably one of those things that is more useful as a WF error since the error message can be better.


Дублирование, дважды вычисляешь идеальный вес. Используй переменную и не допускай лишней работы.


@FixFury I'll do that when I get the chance. The reason why I haven't already is because this commit only adds around 500 H/s, and only when you have -n on, which is not very significant.


No, self->i2c is the DAL's object, I need the mbed's object that it wraps.


Почему вычисление корня идет до выяснения того, положителен ли дискриминант? Ведь если D получился отрицательным, то вычисление корня приведет к исключению и все проверки ниже не выполнятся, т.к. программа аварийно завершится


>(http://hwaddress.com/mac-address-range/00-0C-87-00-00-00/00-0C-87-FF-FF-FF) the time to do it in the next few<Arora? I can get the same time as well but it 3 you 12pm you are not in the morning to see the status on the other hand I can get it done by wait do I enter into my top priority mail express shipment advisory committee members to attend this meeting will take place in the morning of the day and time for you to see the attached document and send it in


Вот только здесь нужно вычислять корень из дискриминанта


Кстати, стороны могут быть не целыми.


looks ok to me. can you be more specific?


in that case its enough to add it to the devices.xml as <item>YU5010A</item


Well the way this class is designed at the moment it should not have any state. You never instantiate a `TmfViewFactory`, you just call `TmfViewFactory.something()`.

Adding `final` to a class is an API break (another class somewhere might have been extending). However I don't think removing `final` from an already-final class is one.


Le 07/11/2016 à 13:37, damscot a écrit :
> Salut,
>
> Non j'ai l'impression que avec la version de xsane que j'ai sur ubuntu
> 16.04 (version 0.999). Au lieu de nécessiter en mode multipage un fichier
> avec un nom du type
> /xsane/xsane-multipage-list... il demande un fichier
> /multipageproject/xsane-multipage-list...
> le fichier pdf généré s'appelle multipageproject.pdf à la place de
> xsane.pdf.
>
> quelle version de xsane utilisez-vous dans votre système, il faudrait
> probablement changer les options de la ligne de commande dynamiquement en
> fonction de la version détecté par Laurux.

J'utilise une version 0.998. J'ai cahrgé la 0.999 pour constater le
problème. Cela est maintenant géré sur la dernière mise à jour de git.

Je pense avoir reporté tous vos commits sur Laurux.master (sauf
l'impression des relevés de compte).
Je pense, après la sortie de la version 3.54, qu'il faudrait que
j'utilise git pour faire les mises à jour de vos commits. Ca sera mieux
pour vous,pour moi, et je pense pour tout le monde.

Concernant les relevés de compte j'ai vu que vous aviez ajouté les
fournisseurs. Mais qu'en est-il des sélections globales ou partielles ?

Bien cordialement.

--

Jacky Tripoteau


Стороны могут быть не целыми


![untitled diagram](https://cloud.githubusercontent.com/assets/9655998/20070191/3eea8e94-a4fe-11e6-9bf9-4976679fdbbd.png)

Hice un diagrama de secuencia, si está bien (espero), lo agregan al TP?


on the contrary, I think this is great! The only thing I'd change is calling it ProgressBarContainer instead of ProgressBarArea just so we know that it is introducing state.


Лучше как раз определить сначала какая сторона является гипотенузой, а какие катетами и затем один раз решить уравнение Пифагора.


As long as you do it only once (i.e. at class-definition-time, which typically means “when the script is loaded”) the penalty is negligible.  There won't be any penalty for instantiating objects.


This comment seems to be a cherry-pick artifact, and it is slightly ironic, because the calls are in exactly the wrong order here :)

See #26278


No? It can deal with ABINIT and Wien2k only. For VASP, please check BandsUP.

Thank you
Oleg

> On Nov 7, 2016, at 08:07, young0628 <notifications@github.com> wrote:
>
> Would you like to tell me if FOLD2BLOCH package can deal the band stucture of supercells obtained with VASP?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>


I added a fix for this to my script and amended oldmud0#2 accordingly


@TomyLobo Still using `!` operator instead of `not`


Погоджуюся


это так надо


TeamCity Xbim :: XbimMvdXML :: XbimMvdXML [Build 1](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1374&buildTypeId=Xbim_XbimMvdXML_XbimMvdXML) is now running


`daw dit daw`


@davetoxa это я тестировал)


No, DnD should have LoS disabled. (and it's not a gameobject cast)


@meharryp get hoes.


TeamCity Xbim :: XbimMvdXML :: XbimMvdXML [Build 1](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1374&buildTypeId=Xbim_XbimMvdXML_XbimMvdXML) outcome was **SUCCESS**
Summary: Running Build time: 00:00:33


TODO Why have RaPi references been deleted???


@upegelow this needs a warning that drawn masks are **NOT** recorded...


Dear David,
thank you. Also for fixing the problem with the init-file. I suppose this was the reason `from russpelling import *``didn't work? It seems to work now, when I start python in the terminal. This is how you tested it, right?
Regards,
Ingo


Нужно указать тип параметра


Cherry-pick is more easy to preserve authorship


@fjmolinas hay que ver como abstraer los objetos xtimer_t aquí. El código de LoRaMAC espera llamara a una función TimerStart(TimerEvent_t *obj). Lo mismo para el resto de las funciones :+1:


2383_RefrigPeakDemand (DavidGoldwasser) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


#7 this is initial part of adding unit tests to the project


``query`` is declared ignored in line 151.


Hi @GaneshVarahade apologies, but never saw this comment.  What do you mean?


Hi @cleandersonlobo, what is the issue with the plugin exporting itself as `store`? Is that a required change to have it work with meteor?


Sorry I wanted to make a pull request, but I accidently hit enter and it commited the changes :/ However, while reversing some parts in SceShell I realized the arguments were wrong.


Dear Ingo,

I'm still testing a few details, but yes, the missing __init__.py file was
the reason that the import statement didn't work properly. It was missing
for GitHub-specific reason, which is why I missed it initially, but it
should be okay now.

Best,

David

On Mon, Nov 7, 2016 at 1:30 PM, Ingo Börner <notifications@github.com>
wrote:

> Dear David,
> thank you. Also for fixing the problem with the init-file. I suppose this
> was the reason `from russpelling import *``didn't work? It seems to work
> now, when I start python in the terminal. This is how you tested it, right?
> Regards,
> Ingo
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/ingoboerner/russpelling/commit/65356518ca24bd83b25a93976a7159baf50b8e27#commitcomment-19726613>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AF8b3CiUhWfe6TnzIM-lCNqY1dXnAsdhks5q725TgaJpZM4KrcHN>
> .
>


Fixed in commit d482f969d27c87b18b543562cad40fd45e991210


is this such a good idea?
what if a user uses that passphrase to encrypt their wallet?


число 26 означає кількість літер
n++%keyCount - чергує літери в code і починає з початку,коли закінчуються.


Vous pouvez éviter les requêtes SQL côté Blade en faisant ceci.

```php
['user' => User::with('events')->first()]
```

https://laravel.com/docs/5.3/eloquent-relationships#eager-loading


Hey @lsnyder how's this working out with 5.0?  We're looking to upgrade to 5.0.  Do you think this covers most of the changes in 5.0 or is there a lot more work to be done?


2383_RefrigPeakDemand (DavidGoldwasser) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


thanks!


Укажи тип параметра


@gallais Maybe you can explain a bit more why you do not want to see the unsolved metas when `--allow-unsolved-metas` is set?
I think the flag was originally there to allow test cases with unsolved metas to pass.  I added the functionality to also serialize such files, for working on several files of the same project simultaneously.  For the latter application, one would still like to see the unsolved metas, even though one can ignore them for a while and get back later to solving them.


Aha true, thought it might be a trigger npc or something wonder what caused dnd to dissapear then


Hi, looks good the commit does only contain this readme, not like in the other commit the executables. Don't know what would happen IF you changed  one of the tree executuables, but you would see it in the commit that the mode was changed, at least here in github.  No need for further action and hey, the CI at least covers this ;-)


Hey @SteveShaffer we're actually just starting the transition of some of our routes over to 5.0 so I'll keep you posted if I run into any issues with these updates. One thing I will say is although elastic merged together filters and queries, none of the syntax really changed for them. A lot of the changes above were simply changing the way this module validated the objects (validating filter vs validating query).

Another nice thing about this elastic.js module is it's really easy to add anything you might need!


Thank you 👍  I will update it now


Il modo corretto di passare il secondo parametro sarebbe `uint8_t (*codes)[6]`


google


**Critical**
Update your Readme


lol


Wonderful — thank you!!!


Hi @j3k0. Yes. It was necessary, because store and window.store was as undefined.
I believe the meteor uses the name "store" in your code.
(I'm sorry my english, Google translator)


Così facendo non riesci più a distinguere lo scancode dei modificatori dai tasti normali.


Maybe it is currently only used in unit testing, but according to the backend API it is allowable for `fold_objects` to return `{ok, Acc}`. I think we should support the full API for `fold_objects` if possible, so as to avoid running into any compatibility issues down the line.


When `--no-termination-check` is set, problematic recursive calls are not highlighted anymore, and when `--no-positivity-chek` is set, negative occurrences are not highlighted anymore either. I assumed that the fact that it was not the case for unsolved metas was a bug.


Dude, seriously?

https://languagetool.org/regression-tests/20161104/result_pt_20161104.html
-Portuguese: 4309 total matches
-Portuguese: ø0,11 rule matches per sentence
+Portuguese: 6616 total matches
+Portuguese: ø0,17 rule matches per sentence
-----------------------------------------------------------------------
https://languagetool.org/regression-tests/20161105/result_pt_20161105.html
-Portuguese: 6616 total matches
-Portuguese: ø0,17 rule matches per sentence
+Portuguese: 4421 total matches
+Portuguese: ø0,11 rule matches per sentence


Thanks for adding the underscored variable names here. This is something we rarely do at Basho, and I wish we did it more, because it can really help clarify code in cases like this :)


Укажи тип параметра


@jmesserly yeah – I'm guessing this is still valid for DDC – right?


Questa cosa mi uccide. Non usare il `++` se poi devi usare `-1` sotto, a questo punto incrementa direttamente alla fine.


Why is this removed? @CreeperSeth


Fixes #1


after a longer discussion on irc with jean and craig, the choice is between removing everything as in my comment above

https://github.com/HOST-Oman/scribus/commit/b383d7b62b0a872409ff28e3ddb442721883d375?diff=unified#commitcomment-19720732

or replace the former call to `nextInChain->layoutAll()` with the original recursive call to `nextInChain->layout()`.

personally, i'm for removing the call and make sure outside of `layout()` that you're not updating a frame with invalid frames before itself in the chain.

jean is rather for keeping `nextInChain->layout()` since it makes sure that there are no missed updates.


No aspetta ma così codes non sarebbe 2 dimensionale?


Fixed in https://github.com/aspnet/EntityFramework.Docs/commit/2337fcc6f46c64f4ca9e21153bc9627194696b90


@fjmolinas moví las carpetas a los paths por defecto de lo pkg de RIOT. Así no se mezclan las librerías de timer de LoRa con las de RIOT


Dude, who said we wasn't haha!

(10/10 for the commit comment)


Questa cosa così non mi piace tantissimo. Sarebbe più idiomatico a questo punto includere il codice di `keymap_get_next_code` in `keymap_scan`, e modificare la signature di `keymap_scan` in:
`bool keymap_scan(scancode_t * mods, scancode_t (*codes)[6])`
e fargli ritornare `true` se c'è da effettuare un update.


.-.
Remove:
Everything TO Do With:
 - updateSquares
 - updateTriangles
 - updatePentagons
LEAVE THE updateEnemies.


Укажи типы параметров


What is the reason you deleted these lines?


No no, quella notazione vuol dire semplicemente che codes è un array di 6 uint8_t. E' controintuitiva, lo so, ma che ci vuoi fare


@maxjacobson I also have this in my travis.yml as per the documentation in travis test coverage settings:

```yml
addons:
    code_climate:
        repo_token: d11a38ad...........
```

Will that still work for setting the environment variable `CODECLIMATE_REPO_TOKEN`? Or should we now just set that in travis env vars settings on the website?


Come scritto sopra, questo andrebbe lasciato a 16 bit, con tutte le modifiche del caso alla PR.


Al massimo uint8_t codes[6]... però poi le altre funzioni non possono indicare che ritornano lo stesso array quindi tanto è syntactic sugar all the way senza controlli statici.. e allora tanto vale pointer no?


Добавь док. блок


If it's (c, a, b, d), aren't the column types in Cassandra INTEGER, VARCHAR, BIGINT, DOUBLE? The results are in that order.


That's unfortunate. From what I understood of pex, you should be able to just run them directly. What error do you get? Are you able to run the pex file directly? I'd prefer to keep this change as it allows us to run builds/tests on Travis with python 3.5, and hopefully we can just fix the Windows issue.


`current_code` non esiste, intendevi `codes_num`?


Укажи тип параметра


Убери лишнее


你这commit不够清楚，下次注意点。这个是add examples for stage 1这样


Eh ma non è vero, perchè il ++ va fatto sempre, anche se non entri in quell'if (ma solo se il tasto non era un modificatore) ;) il -1 sotto serve solo per sovrascrivere il valore che hai appena visto se il round prima era diverso, ma comunque quando trovi un tasto trovi un tasto.


I think it's recommended to add an extra set of outer parenthesis around the boolean expression rather than using the line continuation character.


ok, questo si può fare decisamente


It is a Jedi Academy mod: https://rpmod.jediholo.net/


yeah they are immutable since they are part of the jar file


Instead of depend should it be loadbefore so that it can overwrite the files and not just get loaded after they do?


@ariel- Also freezing arrow should be added here ?


If the user guesses the number the first time, then it displays the message "lucky", if not, the standard scenario.


Fixes #7


Suggest adding "Requirement FAILED: " before each of these log messages for requirement failure.

Suggest logging the actual values of '2RE', 'version_RE0', and 'version_RE1' in the log message.


Reference: http://stackoverflow.com/questions/1810083/c-pointers-pointing-to-an-array-of-fixed-size

Questo forza il chiamante a passareun array statico da 6 elementi, il compilatore fa un controllo statico su questa cosa


Cheers I'll make the nesecary changes. How would that mergeAll look like? And if you think it should be fix, is there anyway I can help with that?


Ya `loadbefore` would work better in this case


@carlsverre: yes, see `youcompleteme` for an example – just add a properly named file like this: https://github.com/NixOS/nixpkgs/blob/master/pkgs/misc/vim-plugins/vim2nix/additional-nix-code/youcompleteme


ok


I prefer to have it to reduce disk writes when minimal activity is happening.
I've already had to bin the original MicroSD card NoTrack started life out on when it became corrupted and wouldn't allow any more disk writes


This is not needed anymore, Google fixed it, see line 127 ;)


ebbene si!


Mmh, accetto la tua obiezione ma rimane brutto :D comunque si può lasciare


Giusto, ho revertato al commit dopo


Since we have specialized ranges statically, this optimization might produce different result from non-optimized code when compiling agains old API (e.g. with `-api-version 1.0`)


Frist commit


Si ok, però appunto è un pointer **, nl senso che è un pointer to array statico che decadrebbe ad array.. Quindi poi devi fare tipo (*codes)[i]. Se va bene allora lo faccio..


otherequip_endusesubcategory (nmerket) - Win64-Windows-7-VisualStudio-12: OK (2320 of 2504 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-92.65%25-yellow.svg)


Table 1


Change where?  I believe that this line only appears in the comments.


Ci penso e ti faccio sapere ;)


Just formatting changes


Can we just undo this? It will take a while to do this right and it would be nice if `ipfs add` worked from js until then :)
This tried to make go's pubsub better, and that is not really used atm anyway.


Si ma sicuramente hai ragione te, però forse è meglio che queste change pro le fai tu xD Io per adesso lascio i puntatori e poi nel caso si prova.. Tanto appunto non ho manco provato se compila quindi sicuramente roba da cambiare poi cen'è


Ahora que lo pienso, esta definición y varias más dependen del archivo board.h (interno de Semtech). Quizás la abstracción correcta sería agregar un glue-code entre el board.h de Semtech y el código RIOT que incluya este tipo de funciones (por ejemplo, un archivo platform_board.h que contenga todas las definiciones)


Closes #20


@bzzzm Will cut a new release.


close #18


I did not check but may other platforms also suffer from this regression?


this is true,

before:
![image](https://cloud.githubusercontent.com/assets/14282144/20072070/515c90d0-a527-11e6-8d84-b85d54e10b44.png)

and after:
![image](https://cloud.githubusercontent.com/assets/14282144/20072107/6f800ab0-a527-11e6-9c73-20f4918cedd5.png)

thanks!


First commit


line 26, its just minor typo but I had make issue and doubt this lower f is causing problem.

´message("Caffe_DIR is ${Caffe_DIR}")	#specify Caffe_DIR in /cmake/Modules/findCaffe.cmake´


没写完呢。[tips/01.png](https://github.com/petronny/nonosparks/blob/master/tips/01.png)中最后还有几行的


This is just a comment so it shouldn't cause any problems


Sì sì, lascia pure così, domani si prova

On Mon, Nov 7, 2016, 20:15 Eugenio Bargiacchi <notifications@github.com>
wrote:

> Si ma sicuramente hai ragione te, però forse è meglio che queste change
> pro le fai tu xD Io per adesso lascio i puntatori e poi nel caso si prova..
> Tanto appunto non ho manco provato se compila quindi sicuramente roba da
> cambiare poi cen'è
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/asterix24/svaroskey/commit/67b6a2abca07b41629e3b47369eb1ff182654fdb#commitcomment-19727288>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABHO2h3HTAzLMG4EbM23HqkLKR_xmyJWks5q73jtgaJpZM4KrkdT>
> .
>


In any case I just fixed it


Yarn recommends it actually https://yarnpkg.com/en/docs/migrating-from-npm


Agreed, wanna open a PR with a git-revert?


这堆py挪examples里面去


`:marioentte` should be `:marionette`.


这个挪stages里面


**Code quality - Critical**
1) Why seed your database each time you start the server?
2) since `mocha` is already available in your executable as `_mocha`, you don't need to add the `node_modules` path


Just fetched this commit. I get a test error with Gradle. It says:
`Gradle suite > Gradle test > sage.MediaFileTest.testCreateValidFilename FAILED
    java.lang.AssertionError at MediaFileTest.java:42`


@superjax


Rebase problem


What? You mean `libssl.dll.a`?

BTW. What should MSVC static libraries be named if `libcrypto.lib` is an import-library. IMHO an `_imp.lib` in the name would tell anyone using OpenSSL what a `.lib` file is used for. Thus a **static** library should be named `libcrypto.lib`.


@dkarter either way should work. We didn't change the name of the environment variable that we expect to be set, so as long as it's set, the reporter is happy.

I wanted to offer a follow-up to my earlier comment, by the way. I realized after writing it that it wasn't 100% correct. We're working on an update to our docs (and the docs on Travis CI's website) about this integration to make this more clear.

A more correct version would be:

```yml
script:
  - bundle exec rake
after_success:
  - bundle exec codeclimate-test-reporter
addons:
  code_climate:
    repo_token: d11a38ad...........
```

We want to encourage people to only submit their test results when their tests are passing, because otherwise results can fluctuate over time.


Small tip: `Seq.tabulate(1000) { i => ... }`

But no need to change this!


Could you also add a test for `HiveHash`?


**Code quality**
Have you forgotten you're testing your code? err should be tested and not avoided  😀


Just for completeness sake also hash the row you have generated?


It looks like Mimikyu doesn't have his own Z-Crystal. The Z-Move used in the trailer is Never-Ending Nightmare (already added) and it's the Ghost-type Z-Move - not a Mimikyu-specific one


Why not use `^1.0.0` here? I'm confused.


My work is done here


Update:::
<<>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>><<<<<<<<<<<<<<<<<<<<<<<<>>>>>>>>>>>>>>>>>>

/*
Name: Aziz Aldawk
Date: 11/6/2016
Homework #7.
Action: There is a program written that reads from standard input and keeps
track of words that are read.
*/
#include <iostream>
#include <iomanip>
#include <ctype.h>
#include "string2.cpp"

using namespace std;

const int MAX_WORD_LENGTH = 254;

// The type definition below permits much easier prototyping of
// functions that pass arrays of strings.

char Length[MAX_WORD_LENGTH + 1]; //  + 1 for null terminator.

void WriteWords(String  Word[],
	int     Count[],
	int     TotalWordCount,
	int     DistinctWordCount);

void StoreWord(String  NewWord,
	String  Word[],
	int     Count[],
	int    &TotalWordCount,
	int    &DistinctWordCount,
	int     MaxWordCount);

/***************************  main  ***********************************/

void main()
{
	const  int MAX_WORD_COUNT = 130;

	String  NewWord,
		Word[MAX_WORD_COUNT + 1] = { "", "" };       // ALWAYS allow 1 extra slot!

	int     Count[MAX_WORD_COUNT + 1] = { 0 }, // Initialize array to zeros
		DistinctWordCount = 0,
		TotalWordCount = 0;

	cin >> NewWord;    //get first word.

	while (NewWord.Length() != 0)            //  While NewWord is not null string
	{
		StoreWord(NewWord, Word, Count, TotalWordCount,
			DistinctWordCount, MAX_WORD_COUNT);

		cin >> NewWord; // get the word next.
	}

	WriteWords(Word, Count, TotalWordCount, DistinctWordCount);

}

/***************************  StoreWord   ********************************

DESCRIPTION  Adds a string NewWord (holding up to MAX_WORD_LENGTH
characters) to the end of the array Word.

PARAMETERS   NewWord            The string (array of char) to be added
Word               An array of String (char[MAX_WORD_LENGTH])
DistinctWordCount  The number of different words in the array
TotalWordCount     The total number of word in the file
MaxWordCount       The max number of words that can be stored
in the array Word. If DistinctWordCount ==
MaxWordCount, the function is exited.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -*/
void StoreWord(String  NewWord,
	String  Word[],
	int     Count[],
	int    &TotalWordCount,
	int    &DistinctWordCount,
	int     MaxWordCount)
{
	int i, k = 0;

	while (NewWord < Word[k] && k < DistinctWordCount)
		++k;

	// Assert:  k is NewWord's correct position in the ordered array Word

	if (NewWord == Word[k])  // NewWord is already there
	{
		++Count[k];
		++TotalWordCount;
	}

	else if (DistinctWordCount < MaxWordCount) // Room for a new word
	{
		++DistinctWordCount;  // If this line reached, found new word
		++TotalWordCount;

		for (i = DistinctWordCount - 1; i > k; --i) // Make room for
		{                                             //  NewWord
			(Word[i] = Word[i - 1]);
			Count[i] = Count[i - 1];
		}
		(Word[k] = NewWord); // Store NewWord in array
		Count[k] = 1;
	}
}

/***************************  WriteWords   ********************************

DESCRIPTION  Writes the strings in the array Word to standard output.
The words are left justified. After WORDS_PER_ROW words have
been written a new line is started.

PARAMETERS   Word       An array of String (char[MAX_WORD_LENGTH])
WordCount  The number of words in the array

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -*/
void WriteWords(String  Word[],
	int     Count[],
	int     TotalWordCount,
	int     DistinctWordCount)
{
	const char *Header1 = "    Word          Count | ",
		*Header2 = "                               | ",
		*Separator = "   | ";

	const int WORD_FW = 17;
	const int COUNT_FW = 4;
	const int WORDS_PER_ROW = 3;

	int C;

	cout << "\n\n";

	if (TotalWordCount == 0)
		return;

	for (C = 1; C <= WORDS_PER_ROW; ++C)
		cout << Header1;
	cout << endl;

	for (C = 1; C <= WORDS_PER_ROW; ++C)
		cout << Header2;
	cout << endl;

	int N = 0;

	while (N < DistinctWordCount)
	{
		for (C = 1; C <= WORDS_PER_ROW && N < DistinctWordCount; ++C)
		{
			cout << setiosflags(ios::left) << setw(WORD_FW) << Word[N];
			cout << setiosflags(ios::right) << setw(COUNT_FW) << Count[N];
			cout << Separator;
			cout << resetiosflags(ios::right);
			++N;
		}
		cout << endl;
	}

	cout << "\nTotal    Word Count : " << TotalWordCount << endl;
	cout << "\nDistinct Word Count : " << DistinctWordCount << endl;
}


Fork is now deprecated - the proof of concept has been successfully integrated with the rest of product as of Version 1.2.


This is an example of what you shouldn't do :D
In other words, don't push directly to the repository. Instead submit a PR and wait for a review (but if nobody has time to review, merge yourself).

Perhaps you can break this rule if you need to change a single small thing (such as a typo) to fix a bug.


OK, I'll fix that.

On Mon, Nov 7, 2016 at 11:23 AM, Jason Bean <notifications@github.com>
wrote:

> Just fetched this commit. I get a test error with Gradle. It says:
> Gradle suite > Gradle test > sage.MediaFileTest.testCreateValidFilename
> FAILED java.lang.AssertionError at MediaFileTest.java:42
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/google/sagetv/commit/ca9acb118e307509a828cbb08bd1dbae4d7278c6#commitcomment-19727407>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ANEIDCBKnZsDC7YFtd0-rZ2pgQo9z6MLks5q73q7gaJpZM4Krm4->
> .
>

--
Jeffrey Kardatzke
jkardatzke@google.com
Google, Inc.


Looks like 1.0.3-2 didn't go to central because travis_after_success.sh saw it came from a pull request.  Can we get this up there?  Thanks.


I have a PR for `mergeAll` here https://github.com/ReactiveX/RxPHP/pull/96.

In your case, it would work like this:
```PHP
return Promise::toObservable($this->client->handle(new StreamingRequestCommand(
            $request
        )))->mergeAll()
...
```
Since you're converting a promise to an observable, you can also use `switchLatest()` instead of `mergeAll()` for the time being.

`mergeAll` combines a stream of observables into a streams of values from those observables.
`switchLatest` does the same thing, except that it switches to the last observable that emits and disposes of the previous observable.  Since you're only emitting once, they'll behave the same way.


Sure, added.


Oh I don't think "this.setDirty(true);" is necessary, you can try it out without it


Travis doesn't push to maven central.  I use the mvn release plugin on the side.  I pushed it up last night but I don't know why it wasn't published.  :(


`latest` might be better than `recent`?


Yeah just noticed that and edited my comment but you are too fast! :)


Oh, you're absolutely right, it to augment the visibility, since the super-method is protected. I notice the latest version has an added comment, so it's all good!


@Floris497 Shouldn't this be version 3 ;)

Anyways, thanks for the swift patch.!


The original name didn't have 'default' in it. If ever using as a starting point again, rename a copy to isolinux.cfg


They don't really talk about the end-application vs. reusable module use-case though. Like the article in #321 mentions, the yarn.lock file is not going to be used in the majority of cases, only for us maintainers of `debug` while developing, it seems.


Thanks for the tip @mattkrick !


gyre


Tercera Versión
[New Archivo WinRAR ZIP.zip](https://github.com/josnatmik/Sistema-ventas/files/576462/New.Archivo.WinRAR.ZIP.zip)


I'm honestly trying to think how to republish it outside of the maven release plugin.  Any ideas?


Whoa... why is there a comment in the middle of my code? I don't see where I didn't put a 3?


There were the following issues with your Pull Request

  * A "License" and a "Signed-off-by" trailers are required. See [the guidelines about this](https://github.com/ipfs/community/blob/master/contribution-guidelines.md#a-license-and-a-signed-off-by-trailers-are-required)
  * Subject line should not be more than 80 characters long. See [the guidelines about this](https://github.com/ipfs/community/blob/master/contribution-guidelines.md#subject-line-should-not-be-more-than-80-characters-long)

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
`git commit --amend` can often help you quickly improve the commit message.
[Guidelines](https://github.com/ipfs/community/blob/master/contribution-guidelines.md#commit-messages) and [a script](https://github.com/ipfs/community/blob/master/dev/tools/hooks/setup_commit_msg_hook.sh) are available to help in the long run.
Your feedback on GitCop is welcome on [this issue](https://github.com/ipfs/infrastructure/issues/23).

---
This message was auto-generated by https://gitcop.com


@Spikhalskiy @normanmaurer - IIUC we are using a counter that is shared across all addresses to derive the round robin index. When I think of round robin I think of "each time I want to communicate to a particular logical address (dns, etc...) I rotate the socket which is used". The approach implemented in this behavior will not provide this behavior, and in the pathological case return the same socket for each logical address. I agree what was implemented previously was not "round robin" either, but it's worst case properties, and properties in general are much more predictable. Perhaps we should the behavior before this commit, rename the class, and take another stab at implementing "round robin"?  WDYT


I don't see any problem with that.


don't commit .idea folder and vendors too


@bhaskaryasa
I think `_perishable_token_expires_at` is too generic a name for a variable.
Can you please change it to `_password_token_expires_at`?


Daniel was here


I need to strip the example files down to smaller still, but that may get pushed off.


`printf "Patching CoreDisplay with patch version 3\n` instead of `printf "Patching CoreDisplay with patch version 2\n` ?


cd AdvanSource


why they are public?


Thanks for noticing this! After reviewing the PR that you submitted (#237), I realized that you were addressing a similar, but unique issue compared to PR #238. I've landed #237 in master and backported to 1.11.


Ah. true :) thanks! nice find


Fabric.js getWidth() and getHeight() are strange ...
* Their values are not the same as this.width and this.height
* Also, need to subtract with stroke width to get the real / actual content width / height


@mcostalba
Thanks for fixing this!  I still get the below under MSVC.  I can open a separate issue if you like.
tbprobe.cpp(536): warning C4267: 'initializing': conversion from 'size_t' to 'uint32_t', possible loss of data
tbprobe.cpp(547): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
tbprobe.cpp(582): warning C4244: '=': conversion from 'uint64_t' to '`anonymous-namespace'::Sym', possible loss of data
tbprobe.cpp(983): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data
tbprobe.cpp(1010): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data