[inst/examples/globe/server.R:5:55:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/inst/examples/globe/server.R#L5) *style:* **Commas should always have a space after.**
```r
earth_dark <- list(img=system.file("images/world.jpg",package="threejs"),
                                                      ^
```
[inst/examples/globe/server.R:14:42:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/inst/examples/globe/server.R#L14) *style:* **Commas should always have a space after.**
```r
     world.cities[order(world.cities$pop,decreasing=TRUE)[1:input$N],]
                                         ^
```
[inst/examples/globe/server.R:14:70:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/inst/examples/globe/server.R#L14) *style:* **Commas should always have a space after.**
```r
     world.cities[order(world.cities$pop,decreasing=TRUE)[1:input$N],]
                                                                     ^
```
[inst/examples/globe/server.R:20:38:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/inst/examples/globe/server.R#L20) *style:* **Commas should always have a space after.**
```r
    col <- rainbow(10, start=2.8 / 6,end=3.4 / 6)
                                     ^
```
[inst/examples/globe/server.R:30:26:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/inst/examples/globe/server.R#L30) *style:* **Commas should never have a space before.**
```r
    args <- c(earth_dark , list(lat=v$cities$lat, long=v$cities$long, value=v$value, color=v$color, atmosphere=TRUE))
                        ~^
```
[inst/examples/scatterplot/server.R:15:40:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/inst/examples/scatterplot/server.R#L15) *style:* **Commas should always have a space after.**
```r
    color <- rep(rainbow(input$colors),length.out = nrow(data))
                                       ^
```
[R/globe.R:167:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/globe.R#L167) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(lat) || missing(long))
    ^
```
[R/globe.R:174:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/globe.R#L174) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(i) > 0)
    ^
```
[R/globe.R:177:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/globe.R#L177) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(any(j))
      ^
```
[R/globe.R:183:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/globe.R#L183) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(i) > 0)
    ^
```
[R/globe.R:186:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/globe.R#L186) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(any(j))
      ^
```
[R/globe.R:192:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/globe.R#L192) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(i) > 0) bg <- substr(bg, 1, 7)
    ^
```
[R/globe.R:193:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/globe.R#L193) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(arcs))
    ^
```
[R/globe.R:207:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/globe.R#L207) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(additional_args) > 0) options <- c(options, additional_args)
    ^
```
[R/globe.R:209:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/globe.R#L209) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("bodycolor" %in% names(options))
    ^
```
[R/globe.R:211:20:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/globe.R#L211) *style:* **Commas should always have a space after.**
```r
    i <- grep("^#",options$bodycolor)
                   ^
```
[R/globe.R:212:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/globe.R#L212) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(length(i) > 0) options$bodycolor <- substr(options$bodycolor, 1, 7)
      ^
```
[R/globe.R:214:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/globe.R#L214) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("emissive" %in% names(options))
    ^
```
[R/globe.R:217:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/globe.R#L217) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(length(i) > 0) options$emissive <- substr(options$emissive, 1, 7)
      ^
```
[R/globe.R:219:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/globe.R#L219) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("lightcolor" %in% names(options))
    ^
```
[R/globe.R:222:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/globe.R#L222) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(length(i) > 0) options$lightcolor <- substr(options$lightcolor, 1, 7)
      ^
```
[R/graph.R:144:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L144) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(is.list(g) && "igraph" %in% class(g[[1]]))
    ^
```
[R/graph.R:149:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L149) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(missing(edge.color)) edge.color <- lapply(g, function(x) { ifel(is.null(E(x)$color), NA, E(x)$color) })
      ^
```
[R/graph.R:150:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L150) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(missing(layout)) layout <- lapply(g, function(x) {ifel(is.null(x$layout), layout_with_fr(x, dim=3, niter=50), x$layout)})
      ^
```
[R/graph.R:151:12:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L151) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    else if(is.function(layout)) layout <- lapply(g, layout)
           ^
```
[R/graph.R:152:12:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L152) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    else if(!is.list(layout)) layout <- list(layout)
           ^
```
[R/graph.R:153:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L153) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(missing(vertex.color)) vertex.color <- lapply(g, function(x) ifel(is.null(V(x)$color), "orange", V(x)$color))
      ^
```
[R/graph.R:157:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L157) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!("igraph" %in% class(g))) stop("g must be an igraph object")
      ^
```
[R/graph.R:161:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L161) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(missing(layout)) layout <- list(ifel(is.null(g$layout), layout_with_fr(g, dim=3, niter=50), g$layout))
      ^
```
[R/graph.R:162:12:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L162) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    else if(is.function(layout)) layout <- list(layout(g))
           ^
```
[R/graph.R:163:12:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L163) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    else if(!is.list(layout)) layout <- list(layout)
           ^
```
[R/graph.R:164:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L164) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(missing(vertex.color)) vertex.color <- list(ifel(is.null(V(g)$color), "orange", V(g)$color))
      ^
```
[R/graph.R:165:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L165) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(missing(edge.color)) edge.color <- ifel(is.null(E(g)$color), NA, E(g)$color)
      ^
```
[R/graph.R:168:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L168) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(vertex.size)) vertex.size <- ifel(is.null(V(g)$size), 2, V(g)$size / 7)
    ^
```
[R/graph.R:169:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L169) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(vertex.shape)) vertex.shape <- ifel(is.null(V(g)$shape), "circle", V(g)$shape)
    ^
```
[R/graph.R:170:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L170) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(vertex.label)) vertex.label <- ifel(is.null(V(g)$label), NA, V(g)$label)
    ^
```
[R/graph.R:171:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L171) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(edge.width)) edge.width <- ifel(is.null(E(g)$width), 1, E(g)$width)
    ^
```
[R/graph.R:172:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L172) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(edge.width) > 1)
    ^
```
[R/graph.R:177:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L177) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(edge.alpha))
    ^
```
[R/graph.R:179:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L179) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(length(E(g)) > 1000) edge.alpha <- 0.3
      ^
```
[R/graph.R:181:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L181) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!is.null(E(g)$alpha)) edge.alpha <- E(g)$alpha
      ^
```
[R/graph.R:187:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L187) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!is.list(main)) main <- as.list(main)
    ^
```
[R/graph.R:192:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L192) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("pie" %in% u) pch <- gsub("pie", "@", pch)
    ^
```
[R/graph.R:193:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L193) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("sphere" %in% u) pch <- gsub("sphere", "o", pch)
    ^
```
[R/graph.R:194:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L194) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("square" %in% u) pch <- gsub("square", ".", pch)
    ^
```
[R/graph.R:195:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L195) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("csquare" %in% u) pch <- gsub("csquare", ".", pch)
    ^
```
[R/graph.R:196:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L196) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("rectangle" %in% u) pch <- gsub("rectangle", ".", pch)
    ^
```
[R/graph.R:197:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L197) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("crectangle" %in% u) pch <- gsub("crectangle", ".", pch)
    ^
```
[R/graph.R:198:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L198) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("vrectangle" %in% u) pch <- gsub("vrectangle", ".", pch)
    ^
```
[R/graph.R:203:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L203) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("click" %in% names(opts))
    ^
```
[R/graph.R:208:1:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L208) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/graph.R:212:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L212) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!all(unlist(Map(is.na, edge.color)))) options$lcol <- edge.color
    ^
```
[R/graph.R:213:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/graph.R#L213) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!(length(vertex.label) == 1 && is.na(vertex.label))) options$labels <- vertex.label
    ^
```
[R/scatterplot.R:214:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L214) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(is.matrix(x))
      ^
```
[R/scatterplot.R:218:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L218) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(is.list(x))
    ^
```
[R/scatterplot.R:222:18:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L222) *style:* **Place a space before left parenthesis, except in a function call.**
```r
        ans <- if(is.data.frame(y)) as.matrix(y) else y
                 ^
```
[R/scatterplot.R:233:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L233) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(pch)) pch <- rep("o", NROW)
    ^
```
[R/scatterplot.R:234:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L234) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(pch) != NROW) pch <- rep_len(pch, NROW)
    ^
```
[R/scatterplot.R:238:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L238) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!is.list(color)) color <- list(color)
    ^
```
[R/scatterplot.R:243:39:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L243) *style:* **Commas should always have a space after.**
```r
  bg <- sub("^(#[[:xdigit:]]{6}+).*$","\\1", bg, perl = TRUE)
                                      ^
```
[R/scatterplot.R:289:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L289) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("center" %in% names(options) && options$center) # not yet documented, useful for graph
    ^
```
[R/scatterplot.R:294:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L294) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!("linealpha" %in% names(options))) options$linealpha <- 1
    ^
```
[R/scatterplot.R:295:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L295) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!("alpha" %in% names(options))) options$alpha <- a
    ^
```
[R/scatterplot.R:305:40:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L305) *style:* **Commas should always have a space after.**
```r
    num.ticks <- pmax(1, num.ticks[c(1,3,2)])
                                       ^
```
[R/scatterplot.R:305:42:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L305) *style:* **Commas should always have a space after.**
```r
    num.ticks <- pmax(1, num.ticks[c(1,3,2)])
                                         ^
```
[R/scatterplot.R:313:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L313) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(flip.y) t3 <- t3[length(t3):1]
      ^
```
[R/scatterplot.R:319:9:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L319) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      if(any(i))
        ^
```
[R/scatterplot.R:329:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L329) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!is.null(x.ticklabs)) options$xticklab <- x.ticklabs
      ^
```
[R/scatterplot.R:330:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L330) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!is.null(y.ticklabs)) options$zticklab <- y.ticklabs
      ^
```
[R/scatterplot.R:331:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L331) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!is.null(z.ticklabs)) options$yticklab <- z.ticklabs
      ^
```
[R/scatterplot.R:338:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L338) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("from" %in% names(options))
    ^
```
[R/scatterplot.R:340:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L340) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!("to" %in% names(options))) stop("both from and to must be specified")
      ^
```
[R/scatterplot.R:341:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L341) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!is.list(options$from)) options$from <- list(options$from)
      ^
```
[R/scatterplot.R:342:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L342) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!is.list(options$to)) options$to <- list(options$to)
      ^
```
[R/scatterplot.R:346:9:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L346) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      if(length(a) == 1) a <- list(a)
        ^
```
[R/scatterplot.R:351:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L351) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!("lwd" %in% names(options))) options$lwd <- 1L
      ^
```
[R/scatterplot.R:352:7:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L352) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if("lcol" %in% names(options)) # discard alpha, normalize line colors
      ^
```
[R/scatterplot.R:359:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L359) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(options$from) != length(options$to)) stop("mismatched line from/to animation coordinates")
    ^
```
[R/scatterplot.R:361:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/scatterplot.R#L361) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(N > 0) # not enough vertex positions, replicate as needed
    ^
```
[R/utilities.R:43:23:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/utilities.R#L43) *style:* **Commas should always have a space after.**
```r
  ext <- gsub(".*\\.","", data)
                      ^
```
[R/utilities.R:44:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/utilities.R#L44) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(grepl("^http", data))
    ^
```
[R/utilities.R:53:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/utilities.R#L53) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(nchar(ext) < 1) ext <- "png"
    ^
```
[R/utilities.R:61:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/utilities.R#L61) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(isTRUE(a)) return(b)
    ^
```
[R/utilities.R:76:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/utilities.R#L76) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("igraph" %in% class(g[[1]]))
    ^
```
[R/utilities.R:87:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/utilities.R#L87) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("layout" %in% names(g)) layout <- g$layout
    ^
```
[R/utilities.R:88:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/utilities.R#L88) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("vertex.color" %in% names(g))
    ^
```
[R/utilities.R:94:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/utilities.R#L94) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("edge.color" %in% names(g)) lcol <- gcol(g$edge.color)$color
    ^
```
[R/utilities.R:96:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/utilities.R#L96) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!is.null(ans$cumulative) && !ans$cumulative) ans$cumulative <- NULL
    ^
```
[R/utilities.R:98:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/utilities.R#L98) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!("layout" %in% names(ans))) stop("missing layout")
    ^
```
[R/utilities.R:110:5:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/R/utilities.R#L110) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(is.null(x)) return(list(color=NULL, alpha=NULL))
    ^
```
[tests/threejs.R:11:18:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/tests/threejs.R#L11) *style:* **Commas should always have a space after.**
```r
scatterplot3js(x,y,z, color=rainbow(length(z)))
                 ^
```
[tests/threejs.R:11:20:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/tests/threejs.R#L11) *style:* **Commas should always have a space after.**
```r
scatterplot3js(x,y,z, color=rainbow(length(z)))
                   ^
```
[tests/threejs.R:12:18:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/tests/threejs.R#L12) *style:* **Commas should always have a space after.**
```r
scatterplot3js(x,y,z, color=rainbow(length(z)), axisLabels=c("a", "b", "c"))
                 ^
```
[tests/threejs.R:12:20:](https://github.com/bwlewis/rthreejs/blob/d82dd64cad33c42a48baab0fa0f8df4c7a51eba8/tests/threejs.R#L12) *style:* **Commas should always have a space after.**
```r
scatterplot3js(x,y,z, color=rainbow(length(z)), axisLabels=c("a", "b", "c"))
                   ^
```


Unit test? ;)


`pos.attacks_from<KING>(pos.square<QUEEN>(Us))` is always the 3 - 8 squares adjacent to the queen,
attacked by the opponent or not.
So your QueenFreedom will  always be positive...

Are you missing something ?

I like your idea. Maybe the simpler expression will do the job.
`DistanceRingBB[s][0] & ~pos.pieces(Us)`

or

`DistanceRingBB[s][0] & (b | ~pos.pieces(Us))`


What? CDN???


Thank you very much, it is a great help to have your prompt solution, I am very grateful


I would rephrase "This should be treated as a bug by those cmdlet authors. There is a workaround though, and that is to use splatting ..." as "You could file a bug against those when you come across them, but you can work around it by only passing credentials when you've received them" 😉


Generally, in the past, we've deemed it fine in docblocks to type hint against higher php versions if they have equivalence in lower packages e.g. DateTimeInterface as there is nothing stopping an IDE etc. from saying that an iterable type hint in a docblock means `\DateTime|\DateTimeImmutable`. I'd say the same is true here with `iterable` and `array|\Traversable`.


@iahmad-khan , can you please make a PR based on this commit for 90X/gcc530
@davidlt , there is nothing else to go along with it?


Jeg kigger!


[inst/examples/globe/server.R:5:55:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/inst/examples/globe/server.R#L5) *style:* **Commas should always have a space after.**
```r
earth_dark <- list(img=system.file("images/world.jpg",package="threejs"),
                                                      ^
```
[inst/examples/globe/server.R:14:42:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/inst/examples/globe/server.R#L14) *style:* **Commas should always have a space after.**
```r
     world.cities[order(world.cities$pop,decreasing=TRUE)[1:input$N],]
                                         ^
```
[inst/examples/globe/server.R:14:70:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/inst/examples/globe/server.R#L14) *style:* **Commas should always have a space after.**
```r
     world.cities[order(world.cities$pop,decreasing=TRUE)[1:input$N],]
                                                                     ^
```
[inst/examples/globe/server.R:20:38:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/inst/examples/globe/server.R#L20) *style:* **Commas should always have a space after.**
```r
    col <- rainbow(10, start=2.8 / 6,end=3.4 / 6)
                                     ^
```
[inst/examples/globe/server.R:30:26:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/inst/examples/globe/server.R#L30) *style:* **Commas should never have a space before.**
```r
    args <- c(earth_dark , list(lat=v$cities$lat, long=v$cities$long, value=v$value, color=v$color, atmosphere=TRUE))
                        ~^
```
[inst/examples/scatterplot/server.R:15:40:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/inst/examples/scatterplot/server.R#L15) *style:* **Commas should always have a space after.**
```r
    color <- rep(rainbow(input$colors),length.out = nrow(data))
                                       ^
```
[R/globe.R:167:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/globe.R#L167) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(lat) || missing(long))
    ^
```
[R/globe.R:174:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/globe.R#L174) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(i) > 0)
    ^
```
[R/globe.R:177:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/globe.R#L177) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(any(j))
      ^
```
[R/globe.R:183:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/globe.R#L183) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(i) > 0)
    ^
```
[R/globe.R:186:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/globe.R#L186) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(any(j))
      ^
```
[R/globe.R:192:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/globe.R#L192) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(i) > 0) bg <- substr(bg, 1, 7)
    ^
```
[R/globe.R:193:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/globe.R#L193) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(arcs))
    ^
```
[R/globe.R:207:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/globe.R#L207) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(additional_args) > 0) options <- c(options, additional_args)
    ^
```
[R/globe.R:209:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/globe.R#L209) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("bodycolor" %in% names(options))
    ^
```
[R/globe.R:211:20:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/globe.R#L211) *style:* **Commas should always have a space after.**
```r
    i <- grep("^#",options$bodycolor)
                   ^
```
[R/globe.R:212:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/globe.R#L212) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(length(i) > 0) options$bodycolor <- substr(options$bodycolor, 1, 7)
      ^
```
[R/globe.R:214:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/globe.R#L214) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("emissive" %in% names(options))
    ^
```
[R/globe.R:217:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/globe.R#L217) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(length(i) > 0) options$emissive <- substr(options$emissive, 1, 7)
      ^
```
[R/globe.R:219:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/globe.R#L219) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("lightcolor" %in% names(options))
    ^
```
[R/globe.R:222:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/globe.R#L222) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(length(i) > 0) options$lightcolor <- substr(options$lightcolor, 1, 7)
      ^
```
[R/graph.R:144:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L144) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(is.list(g) && "igraph" %in% class(g[[1]]))
    ^
```
[R/graph.R:149:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L149) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(missing(edge.color)) edge.color <- lapply(g, function(x) { ifel(is.null(E(x)$color), NA, E(x)$color) })
      ^
```
[R/graph.R:150:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L150) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(missing(layout)) layout <- lapply(g, function(x) {ifel(is.null(x$layout), layout_with_fr(x, dim=3, niter=50), x$layout)})
      ^
```
[R/graph.R:151:12:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L151) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    else if(is.function(layout)) layout <- lapply(g, layout)
           ^
```
[R/graph.R:152:12:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L152) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    else if(!is.list(layout)) layout <- list(layout)
           ^
```
[R/graph.R:153:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L153) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(missing(vertex.color)) vertex.color <- lapply(g, function(x) ifel(is.null(V(x)$color), "orange", V(x)$color))
      ^
```
[R/graph.R:157:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L157) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!("igraph" %in% class(g))) stop("g must be an igraph object")
      ^
```
[R/graph.R:161:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L161) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(missing(layout)) layout <- list(ifel(is.null(g$layout), layout_with_fr(g, dim=3, niter=50), g$layout))
      ^
```
[R/graph.R:162:12:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L162) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    else if(is.function(layout)) layout <- list(layout(g))
           ^
```
[R/graph.R:163:12:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L163) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    else if(!is.list(layout)) layout <- list(layout)
           ^
```
[R/graph.R:164:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L164) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(missing(vertex.color)) vertex.color <- list(ifel(is.null(V(g)$color), "orange", V(g)$color))
      ^
```
[R/graph.R:165:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L165) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(missing(edge.color)) edge.color <- ifel(is.null(E(g)$color), NA, E(g)$color)
      ^
```
[R/graph.R:168:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L168) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(vertex.size)) vertex.size <- ifel(is.null(V(g)$size), 2, V(g)$size / 7)
    ^
```
[R/graph.R:169:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L169) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(vertex.shape)) vertex.shape <- ifel(is.null(V(g)$shape), "circle", V(g)$shape)
    ^
```
[R/graph.R:170:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L170) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(vertex.label)) vertex.label <- ifel(is.null(V(g)$label), NA, V(g)$label)
    ^
```
[R/graph.R:171:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L171) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(edge.width)) edge.width <- ifel(is.null(E(g)$width), 1, E(g)$width)
    ^
```
[R/graph.R:172:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L172) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(edge.width) > 1)
    ^
```
[R/graph.R:177:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L177) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(edge.alpha))
    ^
```
[R/graph.R:179:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L179) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(length(E(g)) > 1000) edge.alpha <- 0.3
      ^
```
[R/graph.R:181:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L181) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!is.null(E(g)$alpha)) edge.alpha <- E(g)$alpha
      ^
```
[R/graph.R:187:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L187) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!is.list(main)) main <- as.list(main)
    ^
```
[R/graph.R:192:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L192) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("pie" %in% u) pch <- gsub("pie", "@", pch)
    ^
```
[R/graph.R:193:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L193) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("sphere" %in% u) pch <- gsub("sphere", "o", pch)
    ^
```
[R/graph.R:194:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L194) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("square" %in% u) pch <- gsub("square", ".", pch)
    ^
```
[R/graph.R:195:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L195) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("csquare" %in% u) pch <- gsub("csquare", ".", pch)
    ^
```
[R/graph.R:196:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L196) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("rectangle" %in% u) pch <- gsub("rectangle", ".", pch)
    ^
```
[R/graph.R:197:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L197) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("crectangle" %in% u) pch <- gsub("crectangle", ".", pch)
    ^
```
[R/graph.R:198:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L198) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("vrectangle" %in% u) pch <- gsub("vrectangle", ".", pch)
    ^
```
[R/graph.R:203:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L203) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("click" %in% names(opts))
    ^
```
[R/graph.R:208:1:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L208) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/graph.R:212:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L212) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!all(unlist(Map(is.na, edge.color)))) options$lcol <- edge.color
    ^
```
[R/graph.R:213:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/graph.R#L213) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!(length(vertex.label) == 1 && is.na(vertex.label))) options$labels <- vertex.label
    ^
```
[R/scatterplot.R:214:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L214) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(is.matrix(x))
      ^
```
[R/scatterplot.R:218:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L218) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(is.list(x))
    ^
```
[R/scatterplot.R:222:18:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L222) *style:* **Place a space before left parenthesis, except in a function call.**
```r
        ans <- if(is.data.frame(y)) as.matrix(y) else y
                 ^
```
[R/scatterplot.R:233:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L233) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(missing(pch)) pch <- rep("o", NROW)
    ^
```
[R/scatterplot.R:234:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L234) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(pch) != NROW) pch <- rep_len(pch, NROW)
    ^
```
[R/scatterplot.R:238:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L238) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!is.list(color)) color <- list(color)
    ^
```
[R/scatterplot.R:243:39:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L243) *style:* **Commas should always have a space after.**
```r
  bg <- sub("^(#[[:xdigit:]]{6}+).*$","\\1", bg, perl = TRUE)
                                      ^
```
[R/scatterplot.R:289:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L289) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("center" %in% names(options) && options$center) # not yet documented, useful for graph
    ^
```
[R/scatterplot.R:294:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L294) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!("linealpha" %in% names(options))) options$linealpha <- 1
    ^
```
[R/scatterplot.R:295:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L295) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!("alpha" %in% names(options))) options$alpha <- a
    ^
```
[R/scatterplot.R:305:40:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L305) *style:* **Commas should always have a space after.**
```r
    num.ticks <- pmax(1, num.ticks[c(1,3,2)])
                                       ^
```
[R/scatterplot.R:305:42:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L305) *style:* **Commas should always have a space after.**
```r
    num.ticks <- pmax(1, num.ticks[c(1,3,2)])
                                         ^
```
[R/scatterplot.R:313:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L313) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(flip.y) t3 <- t3[length(t3):1]
      ^
```
[R/scatterplot.R:319:9:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L319) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      if(any(i))
        ^
```
[R/scatterplot.R:329:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L329) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!is.null(x.ticklabs)) options$xticklab <- x.ticklabs
      ^
```
[R/scatterplot.R:330:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L330) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!is.null(y.ticklabs)) options$zticklab <- y.ticklabs
      ^
```
[R/scatterplot.R:331:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L331) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!is.null(z.ticklabs)) options$yticklab <- z.ticklabs
      ^
```
[R/scatterplot.R:338:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L338) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("from" %in% names(options))
    ^
```
[R/scatterplot.R:340:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L340) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!("to" %in% names(options))) stop("both from and to must be specified")
      ^
```
[R/scatterplot.R:341:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L341) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!is.list(options$from)) options$from <- list(options$from)
      ^
```
[R/scatterplot.R:342:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L342) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!is.list(options$to)) options$to <- list(options$to)
      ^
```
[R/scatterplot.R:346:9:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L346) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      if(length(a) == 1) a <- list(a)
        ^
```
[R/scatterplot.R:351:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L351) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!("lwd" %in% names(options))) options$lwd <- 1L
      ^
```
[R/scatterplot.R:352:7:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L352) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if("lcol" %in% names(options)) # discard alpha, normalize line colors
      ^
```
[R/scatterplot.R:359:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L359) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(length(options$from) != length(options$to)) stop("mismatched line from/to animation coordinates")
    ^
```
[R/scatterplot.R:361:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/scatterplot.R#L361) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(N > 0) # not enough vertex positions, replicate as needed
    ^
```
[R/utilities.R:43:23:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/utilities.R#L43) *style:* **Commas should always have a space after.**
```r
  ext <- gsub(".*\\.","", data)
                      ^
```
[R/utilities.R:44:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/utilities.R#L44) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(grepl("^http", data))
    ^
```
[R/utilities.R:53:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/utilities.R#L53) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(nchar(ext) < 1) ext <- "png"
    ^
```
[R/utilities.R:61:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/utilities.R#L61) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(isTRUE(a)) return(b)
    ^
```
[R/utilities.R:76:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/utilities.R#L76) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("igraph" %in% class(g[[1]]))
    ^
```
[R/utilities.R:87:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/utilities.R#L87) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("layout" %in% names(g)) layout <- g$layout
    ^
```
[R/utilities.R:88:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/utilities.R#L88) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("vertex.color" %in% names(g))
    ^
```
[R/utilities.R:94:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/utilities.R#L94) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if("edge.color" %in% names(g)) lcol <- gcol(g$edge.color)$color
    ^
```
[R/utilities.R:96:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/utilities.R#L96) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!is.null(ans$cumulative) && !ans$cumulative) ans$cumulative <- NULL
    ^
```
[R/utilities.R:98:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/utilities.R#L98) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!("layout" %in% names(ans))) stop("missing layout")
    ^
```
[R/utilities.R:110:5:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/R/utilities.R#L110) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(is.null(x)) return(list(color=NULL, alpha=NULL))
    ^
```
[tests/threejs.R:11:18:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/tests/threejs.R#L11) *style:* **Commas should always have a space after.**
```r
scatterplot3js(x,y,z, color=rainbow(length(z)))
                 ^
```
[tests/threejs.R:11:20:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/tests/threejs.R#L11) *style:* **Commas should always have a space after.**
```r
scatterplot3js(x,y,z, color=rainbow(length(z)))
                   ^
```
[tests/threejs.R:12:18:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/tests/threejs.R#L12) *style:* **Commas should always have a space after.**
```r
scatterplot3js(x,y,z, color=rainbow(length(z)), axisLabels=c("a", "b", "c"))
                 ^
```
[tests/threejs.R:12:20:](https://github.com/bwlewis/rthreejs/blob/9bee9a2c4569434a47c2914a8fd20513d6e071d3/tests/threejs.R#L12) *style:* **Commas should always have a space after.**
```r
scatterplot3js(x,y,z, color=rainbow(length(z)), axisLabels=c("a", "b", "c"))
                   ^
```


@gmlewis, I ran into this line (while reviewing #535) as well. After using git blame to land in this PR, and seeing the context, I can tell this is correct.

However, given that it's pretty unusual to do `if err != nil { ...; return something, nil }`, I think it'd be nice to add a comment here explaining why nil error is being returned. That way, when reading this code outside of this PR, it's more clear to the reader that it's correct.


Please revert this commit and double-check this list. It is destructive.


This is only a small part for the websockets support. Due to this additional filtering the connection will not closed so you can send the websocket data. However, there is no websoket proxying for lua-resty-http. (see https://github.com/openresty/lua-resty-websocket)


Pretty sure that's not the case, there might be another reason for the failure...


Не понял что ты хочешь сказать. Скриншот тоже не помогает, так как я не пользуюсь дополнительными програмами для работы с Git и что они показывают мне не понятно.


Nice, that's very tidy.


The only thing to change is that we are changing mix key to "insurance key".


Thanks!  That's the function I was looking for...


Personally, I think this attribute is the thing you really need to explain at this point, rather than how to work around other cmdlet's problems ;-)

In case you don't know -- this is here so that a caller can pass a string and get prompted for the password:  `Set-RemoteRegistryValue ... -Credential "Joel"`


这是一个Bug


ok, I'll try.


@iahmad-khan pick the latest commit: https://github.com/davidlt/zlib/commits/gcc.amd64


test


It's worth explaining what that means: they will think they got real credentials, and will try to log in to something with the Empty creds...


You reverted haxelib to a previous commit.... :(


I figured.  I'm trying to understand how to do it efficiently.  It looks like I need to access the raw socket with ngx.req.socket(true)  and after the upgrade, send/recv chunks as necessary.  I should be able to do this within the context of resty/http.lua but I haven't worked out the details.


Any specific reason to roll your own `sh` tasks instead of using the library-provided ones?


Thanks, failed rebuilds are performed at 5,9,13,17 hundred hours. So hopefully no need to wait for the daily 1am overnight build, as long as fix commits are performed before last failed rebuild check time.


An actual explanation of what this does would be useful. It's not mentioned anywhere else.


Oops, I'm bad at updating the changelog. Looks like someone sent a fix for it :)


@pbauer Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.namedfile/17/violations
```
plone/namedfile/testing.py:18:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/namedfile/scaling.py:173:1: C901 'DefaultImageScalingFactory.__call__' is too complex (15)
plone/namedfile/utils/__init__.py:176:1: C901 'rotate_image' is too complex (17)
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Great job ishotjr!


Oh boy, how important was that?


It's slow going and very mundane. I still have 4 modules to go.


You are casting int to string to check if it is null or empty? This condition will be never true. Simple remove lines 19-22 as unnecessary


Why do you need removeEmptyCatchBlocks?


@pvgenuchten can we map "href" to Layer Properties->Metadata->MetadataUrl ?


I can guess what is NONE, ENC and DEC, but what is EX_LCL and EX_RMT ??? Add comments, please


The only significant commit removed is https://github.com/HaxeFoundation/haxelib/commit/84e4deb0f677e1255a6ed36ecfa75000e9255be8, which is not very critical.


Thanks for fixing. Would it be easy to add a test so it doesn't break again?


Is it correct to map "term" to layer keywords?


Does your minification include angular? I don't see where it gets included in the above. Getting everything down to 223kb would be quite nice. Honestly I've never though about including the CDN stuff, but if the minifier can remove unused bits from the libraries, that would be quite cool.


@soundshed Was the button removed because a fix is very complicated and not planned to be fixed any time soon?


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2049](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=23250&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **SUCCESS**
Summary: Tests passed: 308, ignored: 4 Build time: 00:16:25


MY EYES ARE BLEEDING


Hardcoded database name ? What is it ???


Omg, sorry


True. This is code that won't execute many times though. I'll consider it for the future.


Ok, last time, I promise -- it bugs me to see you say "always add some splatting" -- what you mean is they should handle the case where no Credential was passed to them, by not passing the `[Credential]::Empty` to another cmdlet (which by the way, is why I don't know why we bother with Empty in the first place).

My point is: they need conditional handling of the parameter, so they don't pass it if it wasn't set to a real value **by their caller**.  They can use an `if` around building a hashtable to splat to Invoke-Command, or they could just write:

```posh
if($PSBoundParameters.ContainsKey('Credential')) {
    Invoke-Command -ComputerName:$ComputerName -Credential:$Credential  {
        Set-ItemProperty -Path $using:Path -Name $using:Name -Value $using:Value
    }
} else {
    Invoke-Command -ComputerName:$ComputerName {
        Set-ItemProperty -Path $using:Path -Name $using:Name -Value $using:Value
    }
}
```

Do you need to define "splatting" here?


what about using a hostname that implies failure intend: `http://dns.resolution.falure./` or `http://nonexistent.domain-name.`?


Without messing with stuff like OMS this should follow AOSP default styling which simply is only white in there. On the other hand using the AOSP custom tile mechanism is too limited anyway for what I want this to become. So this might be changed to be more integrated with framework to create a special tile anyway


Example of creating a function based view in Django and storing records in mysql from Django submit button.


In der Tat wollte ich das, ja ;)


Oops, it is sample application, sorry ;)


I need to add this RTC code:

uint8_t rtc_get_year()
{
   outb(0x70, 0x09);
   return inb(0x71);
}

uint8_t rtc_get_month()
{
   outb(0x70, 0x08);
   return inb(0x71);
}

uint8_t rtc_get_day()
{
   outb(0x70, 0x07);
   return inb(0x71);
}

uint8_t rtc_get_weekday()
{
   outb(0x70, 0x06);
   return inb(0x71);
}

uint8_t rtc_get_hour()
{
   outb(0x70, 0x04);
   return inb(0x71);
}

uint8_t rtc_get_minute()
{
   outb(0x70, 0x02);
   return inb(0x71);
}

uint8_t rtc_get_second()
{
   outb(0x70, 0x00);
   return inb(0x71);
}


* requiring the `puppet-lint` registered the `lint` task, even if you override the config still runs
* for latest release of `metadata-json-lint`, 1.0.0, it doesn't look like you can set config rake-style

These were both issues because I didn't want linting to fail the build and block next steps.

Overall I think it's much easier to understand this way - more explicit - if a build breaks we shouldn't have to dig through libs in github to understand what side effects `require`ing them brings.


Awesome! :)


WOW


That leaves only 4 lines left for the actual implementation :-)


[inst/examples/globe/server.R:20:38:](https://github.com/bwlewis/rthreejs/blob/e749cc6ec7dfcb715edbc27ad07a6fda3c9ad105/inst/examples/globe/server.R#L20) *style:* **Commas should always have a space after.**
```r
    col <- rainbow(10, start=2.8 / 6,end=3.4 / 6)
                                     ^
```
[R/globe.R:211:20:](https://github.com/bwlewis/rthreejs/blob/e749cc6ec7dfcb715edbc27ad07a6fda3c9ad105/R/globe.R#L211) *style:* **Commas should always have a space after.**
```r
    i <- grep("^#",options$bodycolor)
                   ^
```
[R/scatterplot.R:243:39:](https://github.com/bwlewis/rthreejs/blob/e749cc6ec7dfcb715edbc27ad07a6fda3c9ad105/R/scatterplot.R#L243) *style:* **Commas should always have a space after.**
```r
  bg <- sub("^(#[[:xdigit:]]{6}+).*$","\\1", bg, perl = TRUE)
                                      ^
```
[R/scatterplot.R:305:40:](https://github.com/bwlewis/rthreejs/blob/e749cc6ec7dfcb715edbc27ad07a6fda3c9ad105/R/scatterplot.R#L305) *style:* **Commas should always have a space after.**
```r
    num.ticks <- pmax(1, num.ticks[c(1,3,2)])
                                       ^
```
[R/scatterplot.R:305:42:](https://github.com/bwlewis/rthreejs/blob/e749cc6ec7dfcb715edbc27ad07a6fda3c9ad105/R/scatterplot.R#L305) *style:* **Commas should always have a space after.**
```r
    num.ticks <- pmax(1, num.ticks[c(1,3,2)])
                                         ^
```
[R/utilities.R:43:23:](https://github.com/bwlewis/rthreejs/blob/e749cc6ec7dfcb715edbc27ad07a6fda3c9ad105/R/utilities.R#L43) *style:* **Commas should always have a space after.**
```r
  ext <- gsub(".*\\.","", data)
                      ^
```
[tests/threejs.R:11:18:](https://github.com/bwlewis/rthreejs/blob/e749cc6ec7dfcb715edbc27ad07a6fda3c9ad105/tests/threejs.R#L11) *style:* **Commas should always have a space after.**
```r
scatterplot3js(x,y,z, color=rainbow(length(z)))
                 ^
```
[tests/threejs.R:11:20:](https://github.com/bwlewis/rthreejs/blob/e749cc6ec7dfcb715edbc27ad07a6fda3c9ad105/tests/threejs.R#L11) *style:* **Commas should always have a space after.**
```r
scatterplot3js(x,y,z, color=rainbow(length(z)))
                   ^
```
[tests/threejs.R:12:18:](https://github.com/bwlewis/rthreejs/blob/e749cc6ec7dfcb715edbc27ad07a6fda3c9ad105/tests/threejs.R#L12) *style:* **Commas should always have a space after.**
```r
scatterplot3js(x,y,z, color=rainbow(length(z)), axisLabels=c("a", "b", "c"))
                 ^
```
[tests/threejs.R:12:20:](https://github.com/bwlewis/rthreejs/blob/e749cc6ec7dfcb715edbc27ad07a6fda3c9ad105/tests/threejs.R#L12) *style:* **Commas should always have a space after.**
```r
scatterplot3js(x,y,z, color=rainbow(length(z)), axisLabels=c("a", "b", "c"))
                   ^
```


Oh Dear! You're absolutely right, thank you, Gerald.


Checkmarx scan results 31 Jan 2017 17:46 UTC +02:00

High
Medium
Low
Info

New
2
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

72a6863c143b9c3024a48a054e9fa68cb5d89f54	@web-flow


ejhehje


Hi Mark, here is the design I was trying to express on Twitter. Note that we're still able to push some business logic out into a pure core, but we're handling the effectful logic (the asynchrony) using an `Async` to mark it as effectful, and taking advantage of the computation expression to get a nice imperative-looking code flow.

```fsharp
let private numReservedSeats = List.sumBy (fun r -> r.Quantity)
let private canAccept capacity reservations reservation =
  numReservedSeats (reservation :: reservations) <= capacity

let withAccepted reservation = { reservation with IsAccepted = true }

(*
val tryAccept :
  (DateTimeOffset -> Reservation list Async) ->
  (Reservation -> int Async) ->
  Reservation ->
  int Async
*)
let tryAccept capacity readReservations createReservation reservation =
  async {
    let! reservations = readReservations reservation.Date
    return!
      if canAccept capacity reservations reservation
        then createReservation (withAccepted reservation)
  }
```


Let's remove the haxelib submodule already.


@AnnaAleksandrowicz  this question is for @giladna


When `core-lib-extns` gets touched next, we should probably remove commented-out bits.


Hi,
-wrong color => possible to have check right in gtpconnection to check if either w or b? Confirmed on eclass that turn does not matter at all

-player_errors => anything to do with the global variables set at the beginning of (I think it's board.py???), if so can we leverage this and edit entire code to follow suit. Therefore maybe we can institute a check in the function for the int.


You can subscribe arbitrary URLs to receive notifications on state change.
That one (:7778) is in the config TOML and corresponds to the port for
haproxy-api, an external service for managing haproxy in a separate
container for purposes of isolation and rolling deploys. If you just want
sidecar you can remove that listener from your config and get clean logs.


@areloch -  This appears to have un-done the changes from my other PR that fixed the net tests. I think its my fault for using revert rather than rebase, but we should still fix it up.


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2050](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=23256&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


Here you changed scope of EngineCallbackGuard. Before the change, raise() was out of this scope.


This commit turned `Lwt_result` from experimental to deprecated, was that intentional?  FWIW, I think `Lwt_result` is convenient to have.


Thx, compilation worked without problems! Will implement the tests here once the code is a bit more organized.


An issue I see here is the following (line 196 of data.rnw):
"However, for this assessment,
f = 0.03 led to a record-high estimate for the 2014 year class (2.5 times larger than the any
other in the time series), resulting in a huge estimated current biomass (Figures 46 and 47)."

It implies that we chose a different base case based on the output biomass. I've edited this and committed (848a236132d325dec0a6dd075c7236d7ebb5f49c).


Just had an idea.....
Create a py file that contains a quick function that "maps" the colors, board states to a number. Then just import that file in each file, then can just use integers and call upon the function anytime we want h00man letters to display


That's more than enough :)

alas, I see the problem still, so this was a false lead after all... :(  Just had a lucky stretch for some test runs, or so it seems... *sigh*


This is not needed, autoprefixer will add it to the final CSS.

https://autoprefixer.github.io/


CVE-2016-10188 has been assigned for this.


I made a mistake in which I confused classes with id's, so I simply changed this.


CVE-2016-10189 has been assigned for this

(see also 30d598ce7cd3f136ee9d7097f39fa9818a272441 for a followup fix)


CVE-2017-5668 has been assigned for this


not used


test


Remember -- you don't have to use Get-Credential.  Because you put that `Credential()` attribute on it, you could just pass a user name (as a reminder of which credentials are needed), and it would prompt you.


There is no reason to have getters and setters for a public field. Furthermore function names shouldn't be ALL CAPS.


😄 thanks -- by the way, I think when linking to the Gallery, it's best to leave the version number off, just `https://www.powershellgallery.com/packages/BetterCredentials`


mioeme e fii w copyright the model of4383733


Checkmarx scan results 31 Jan 2017 17:57 UTC +02:00

High
Medium
Low
Info

New
2
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

72a6863c143b9c3024a48a054e9fa68cb5d89f54	@web-flow


**[unitTests_js_branches run failed](http://jenkins.wikia-prod:8080/job/unitTests_js_branches/37767/testReport/) for this commit**


Nice but... what is 'IINA.v0.0.4-old'?


@keeteean Never animate anything other than `opacity` and `transform`!

Those two will use the GPU which means better performance. Everything else must be recalculated and repainted by the browser.

See: https://medium.com/outsystems-experts/how-to-achieve-60-fps-animations-with-css3-db7b98610108#.nuobzeh8i


What exactly is the point of this commit other than change from one weird design pattern to another?


@keeteean not needed thanks to autoprefixer


Scenario 3:  i assume it still uses the rootfs from SD card, but since just simply judged from login hostname , i am not 100% sure about this.


We lost "Custom" in the theme list for XMB.
I'm not sure where the error lies.


the `resourceOverride` feature is used to replace the html and css imports in `@Component` metadata with empty js files.

The reason to do so is because it is redundant data, it is not being used at runtime anyway since the AOT compiler creates a separate version of it.

If you have a complex setup and you reference images from within a component css then you might run into issues.

I havent checked that deeply, but you can remove this feature for now and you won't have issues.


done


Is it worth mentioning Azure KeyVault or vaultproject.io or other credential storage systems?


This should probably use `self.print()` for DRY, but that requires to factor out `room` and `prefix_len` to avoid calculating them twice


In order to do triple digit days(eg. 206) I had to change the pad( ,2) to a 3 and then it worked fine.


test


Maybe add an owned `StyledString` here? Not sure if that makes sense - you usually would not modify styled text directly, rather use some sort of markup to parse `StyledStr`s from.

For example, for the markup `[highlight]example text[/highlight]` we could parse
```rust
[(
  "example text",
  Style {
    color: ColorStyle::Highlight,
    effect: Effect::Simple
  }
)]
```
where the `str` is a slice into the markup `String`.


@payten bold rails experiment has broken the test site (http://test.archivesspace.org/). That has happened from time to time :smile: but just wanted to let you know so we don't inadvertently have it down for too long.

I'd say (loosely) to date there's been an expectation that master is a functioning branch at all times ... so perhaps something like this would be held in a feature branch until considered ready (that may have been the case here, perhaps?).

Maybe a topic to discuss with @lmcglohon?


It did not break. At all. It's a YouTube side change. You can't be resistant to server side changes you don't have contract with thus you have nothing to test. YouTube is free to make changes any time without notifying anybody. The only thing you can test is a breakage detection that is already tested.


Track shlomiassaf/ngc-webpack#4 for a version with a fix.


id лучше заменить на $this->primaryKey()


You might want to just use $Credential.UserName?


This code should be executed once, just after login, not on every action. Please move it to Login action


сеттер, а метод get проверяется(и вызывается далее)


Yes, you have the right idea how to do it. resty/http.lua should be enough
to do it.

On Tue, Jan 31, 2017 at 5:33 PM, Der Fredder <notifications@github.com>
wrote:

> I figured. I'm trying to understand how to do it efficiently. It looks
> like I need to access the raw socket with ngx.req.socket(true) and after
> the upgrade, send/recv chunks as necessary. I should be able to do this
> within the context of resty/http.lua but I haven't worked out the details.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/zenedge/lua-resty-http/commit/0b46a84f20f677c9e92cbf48990015fed116f264#commitcomment-20680896>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AV0nJnrJ-f89mG7dtbDPkhJwiJfKw-lRks5rX1RdgaJpZM4Lywtk>
> .
>


I'm sorry, but i don't understand - what is this setting for and when\how to use it


The imports above should not be indented. That's bad style.


не проще ли без цикла, просто $conditionsData = $conditionsData? Доп обработки же нету никакой


Try version 1.3.5.


Well, I guess it depends on what you want to do. I wanted to pad days to at least 2 characters, I don't want to display everything with three characters.


@Ljinod en plus de l'id, ça serait bien d'avoir un doctype pour identifier un document


Two "consts" above have give nothing to the patch goal but makes is a lot more large than necessary.
Please, please ! Separate refactoring into another commits !!!


There is. You can override getters, yet not set final fields. The all caps are actually made by my IDE, but I can change that back if need be.


если это поиск одной записи, то нужен limit 1


You probably want to separate elements to animate (as the HTML was before your commit):

    Your text

This way the pipe is always visible. Try applying your `blink` to just the `.pipe` and see if you can get it to flash. *Hint:* take a look at your `@keyframes` syntax (those quotes don't look right!).

You should note that the `-webkit-` prefix only works for Chrome and Safari. For animations you will need that prefix as well as the unprefixed version. See: http://shouldiprefix.com/#animations

Now, for the crux of your issue, you won't be able to animate the `width` of an `inline` element. So, you'll need to make it `inline-block` (which without worrying about specifics too much, you can think of as exactly as it sounds, a hybrid of `inline` and `block`). Also, `width: 100%` doesn't quite mean what you think it does. For a block-level element, this means 100% of my parent container. You probably meant 100% of my "normal" width. In CSS, that's spelled `auto` (`width` is `auto` by default). Unfortunately, you cannot animate from `0%` to `auto`. To remedy this, we use a bit of a hack. We animate `max-width`. This has the effect of constraining the width of an element up until it's "normal" width (`width: auto`), but then it stops. So if an element is 10% the width of its parent, animating `max-width` from 0% to 100% would have it grow from nothing to its full `auto` width in the first 10% of  the animation. The other 90% of the animation would still happen (and take time), but you won't see any visual changes. As a result, depending on the parent and child widths, growing/shrinking with `max-width` won't have the timing that you expect.

It's a bit of a hack, but it's fairly common. If you get stuck, here's an example: http://jsbin.com/varadapodi/1/edit?html,css,output

The other option you have is to use JS (you're looking for `textContent` and `setTimeout` if you want to go this route). This will afford you more precise timing control.


метод вообще без условий? всегда возвращает все записи из таблицы? имхо, обработку where еще бы добавить


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2051](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=23260&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2050](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=23256&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **SUCCESS**
Summary: Tests passed: 309, ignored: 4 Build time: 00:15:18


I forgot to pull.


Yeah I like the 2 digit padding but we needed to also display a 3rd digit if it was there. Anyway to do an if statement for days so that if it is 3 days display those or if it less than that pad it to 2 digits? Sorry I am not a dev or I would help make the change myself. Thanks for your time and contributions!!!!


Il y a une raison de mettre ça en majuscules ?


👍  за static :)


小米推送的文档只会写API，也就是app与SDK互动的接口。集成同一SDK的多个app之间的互动接口，属于SDK的内部实现，一般不会在文档中写出。

这个action是我跟踪出来的，实测有效，但还不够完备。


@lmcglohon  And I think this is a problem for the impending 1.5.3 as we don't want the experimental stuff in that release. We can of course back up to a commit pre experiment and branch / tag from there but may add a bit of crustiness if some additional work is needed for 1.5.3. Not a big deal, just not necessarily ideal :smile:


Si le destinataire a accepté, c'est probablement aussi le bon endroit pour enregistrer son token.


Why the `-y`?


Nah, was just checking how close I could get to `sha1sum` on my box and inlining that huge `innerHash` function helped a bit. Was testing it on the 59 MiB `zig` executable with `time`, i.e. not very scientific.

So I just reran it with `perf`, here are those numbers;
```
Performance counter stats for 'sha1sum -b zig':

        129,825092      task-clock (msec)         #    0,999 CPUs utilized
                 1      context-switches          #    0,008 K/sec
                 0      cpu-migrations            #    0,000 K/sec
                73      page-faults               #    0,562 K/sec
       415 413 373      cycles                    #    3,200 GHz
   <not supported>      stalled-cycles-frontend
   <not supported>      stalled-cycles-backend
     1 301 045 599      instructions              #    3,13  insns per cycle
        18 135 515      branches                  #  139,692 M/sec
            26 574      branch-misses             #    0,15% of all branches

       0,130012411 seconds time elapsed

inline fn innerHash
Performance counter stats for './autotest_release zig':

        159,040484      task-clock (msec)         #    0,986 CPUs utilized
                 9      context-switches          #    0,057 K/sec
                 1      cpu-migrations            #    0,006 K/sec
               908      page-faults               #    0,006 M/sec
       509 001 893      cycles                    #    3,200 GHz
   <not supported>      stalled-cycles-frontend
   <not supported>      stalled-cycles-backend
     1 750 187 419      instructions              #    3,44  insns per cycle
        80 249 402      branches                  #  504,585 M/sec
            10 448      branch-misses             #    0,01% of all branches

       0,161268861 seconds time elapsed

fn innerHash
 Performance counter stats for './autotest_release zig':

        176,030963      task-clock (msec)         #    0,974 CPUs utilized
                 6      context-switches          #    0,034 K/sec
                 1      cpu-migrations            #    0,006 K/sec
               909      page-faults               #    0,005 M/sec
       563 229 812      cycles                    #    3,200 GHz
   <not supported>      stalled-cycles-frontend
   <not supported>      stalled-cycles-backend
     1 857 354 916      instructions              #    3,30  insns per cycle
        82 111 192      branches                  #  466,459 M/sec
             8 445      branch-misses             #    0,01% of all branches

       0,180688123 seconds time elapsed
```


@DavidBadura something is wrong here. packagist is not seeing the 1.0.2 release, and the changelog seems wrong?

https://github.com/simplethings/EntityAuditBundle/compare/v1.0.1...v1.0.2
Looks like #250 was fixed in 1.2.0


@cpovirk looks like this commit message got borked


@vincentchabannes could we parametrize this rather than hard coding the directories ?


Pour de la réplication one-shot ou master-slave, j'imagine que le verbe GET doit suffire.


Ah, you're right. Alright, I'll do a PR here shortly to get that back in
there

On Jan 31, 2017 9:52 AM, "Thomas Dickerson" <notifications@github.com>
wrote:

> @areloch <https://github.com/areloch> - This appears to have un-done the
> changes from my other PR that fixed the net tests. I think its my fault for
> using revert rather than rebase, but we should still fix it up.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/GarageGames/Torque3D/commit/87c9fce3803f557e9d2c97919645f4e0d08e4282#commitcomment-20681241>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACb1JOuVBFOkC-7cNus0fXKDTRfbJifBks5rX1i3gaJpZM4Lyzsg>
> .
>


I think that the text Chris removed was indeed erroneously implying that we didn't like the output biomass so we changed the model.

However, I think that not all of our model selection methods are purely statistical. When we looked at the estimates of the estimated 2014 recruitment at about 40 billion, 2.5 times the next biggest value (the 1980 recruitment), we felt that without having observed this cohort in the survey, there was simply insufficient evidence in the fishery observations at ages 1 and 2 to support these extreme value. I think that it's fair to include that idea in some form if we can come up with a better way to express it than the text that Chris removed.


@SuperFluffy You must not call `.clone_from()` on uninitialized memory :stuck_out_tongue:


oooo saol sadıcım


Pour du master-master, oui, il va falloir. Sinon, je ne pense pas que ce soit nécessaire.


I'm not seeing the update with that line, but it's ok, I have it on my personal copy. Any other changes before we try to submit it for the HW?


@ramonh  Sorry for the spam. No worries. Thanks you for all your efforts! Will try to attend if happens tomorrow. Keep it up. See you. Prosit 2017. Cheers.


Interesting! how you did that?


When two Entities reference each other in their fields, we run into issues. In the case of MassiveMagic, I had MItem and MRecipe.

MItem has a field that references a MRecipe Id. I use a TypeEntityId for that field in the editor.
Same for MRecipe. They have a field referencing a MItem id. I used a TypeEntityId for that field too.

Now, the current system tries to construct the TypeRecipe, has a TypeMItemId which is a TypeTransform of TypeMItem and TypeString. TypeMItem has a inner type which references a TypeRecipeId which in turn is a TypeTransform with TypeMRecipe and TypeString.

And from there, the circuit is complete. What the end of this is, that one of the TypeTransforms  has NULL in the INNER type. By making the getter Overridable a sub-type can override that getter and "Inject" the Type after it is being initialized.

Tl;Dr: The INNER type is (in very special circumstances) not present on creation and needs to be made available through the overriden getter.


> I have jolted down that code in less than a day, and I have yet to design and implement the higher level of the API (I am guessing that it might be twice faster than current in the end).

Just found that the refresh rate for the throughput was higher for `fastqandfurious` than for other, which means that the throughput was underestimated as a decent fraction of the CPU usage was spent updating the display. After correcting that, `fastqandfurious` is now clocking 30% faster than previously reported.


Also, to Andy's comment about finding phi. I can't find it in the list of model output either. In the next (3.30) version of SS, this value will appear in the table of parameters, so that's something to look forward to.


I mean how you chose the word? manually? did you get the whole lex already?


Ты тут внутрь класса передаешь этот же класс или что? Тут ты передаешь данные для компонента, данные мы называем ViewModel


Can you confirm this works without a popup on android 6.0? I removed this because the popup would come up every time even if you selected it to be used by default.


I suggest `PUT /sharings/:id`


loaded all the image data, then saved the concepts list to a file. After that, I used the multi-word concepts for this map.


move the `TrapDaemon.__init__()` method to the top of the class definition.


Good call :P


Yeah, I probably should have replaced the stripped link with something sensible. I figured it didn't provide a lot of extra value, but then arguably I should have just stripped it entirely.


This needs to go.


I suggest `POST /sharings/:id/answer`


I used some very old version of the googleplay_api, and had also problems with the verification there. I stumbled across this: http://bugs.python.org/issue13655 and also this: https://urllib3.readthedocs.io/en/latest/user-guide.html#ssl

I use certifi now, as i need a solution that works on windows too... for *nix systems I would try the paths that are posted here: http://bugs.python.org/issue13655#msg192601


Worked perfectly, thanks 🎉


I suggest `POST /sharings/:id/replicate`


@cjmaxik Please make a pull request.


No problem. Thanks for pointing out the problem.


the performance problem was in the headword finder, not the query, so I reverted the query to what was before. It is nicer!


Да там ориг файлы (http://prntscr.com/e2qe41) , я их откатил.
Теперь снова пытаюсь слиться с твоей веткой ($git merge php-coder/master)?

31 января 2017 г., 20:31 пользователь Vyacheslav Semushin <
notifications@github.com> написал:

> Не понял что ты хочешь сказать. Скриншот тоже не помогает, так как я не
> пользуюсь дополнительными програмами для работы с Git и что они показывают
> мне не понятно.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/php-coder/mystamps/commit/ec5be531ed6157efd203f227f1f574f82b7fda89#commitcomment-20680854>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AVJDAdIrImC-mqpeXNFDnS8kN60AmwzAks5rX1PbgaJpZM4Lw7_h>
> .
>


I'm going to investigate again... I attempted to 'inflate' the buffer by
first pushing clones into it. But two problems:

1. I need to call `clear` on it, because the other stuff is essentially
junk. Do you think this matters?

2. In my simulation I still ran into issues even though I initialized the
data (followed by a clear). Unfortunately I couldn't reproduce that
behavior with this minimal example.

I will try and reproduce my problem even with initialization/inflating of
the buffer.

Thanks for looking!

On Jan 31, 2017 16:13, "bluss" <notifications@github.com> wrote:

> @SuperFluffy <https://github.com/SuperFluffy> You must not call
> .clone_from() on uninitialized memory 😛
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/SuperFluffy/arraydeque/commit/8c052247ba101350b73c8642abb4f553852d3a07#commitcomment-20681679>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAqy-eBNLxRN8asaBIm7bwyNO-d-aQNPks5rX12xgaJpZM4Ly1c1>
> .
>


No spam at all, @geraldb. I highly appreciate your paying attention to these details! It's definitely on tomorrow, so I hope to see you there. 🚀 Prosit 2017 to you too!


I think 'panel.open_url.informative' is clearer


Quand cette route est appellée ? Et par qui ? Ça ne fait pas doublon avec la réception d'une réponse positive ?


@cjmaxik I reverted it for now.


This block was not being executed, because the oid from LooperNG was actually '1.3.6.1.6.3.18.1.3.1000'
It is removed in the next commit


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2051](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=23260&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **SUCCESS**
Summary: Tests passed: 309, ignored: 4 Build time: 00:13:43


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2052](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=23267&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


![](https://github.trello.services/images/mini-trello-icon.png) [ilearn2: fix mod/assign/amd/src/grading_panel.js since it breaks Mailsimulator submit button](https://trello.com/c/REJiGvD2/748-ilearn2-fix-mod-assign-amd-src-grading-panel-js-since-it-breaks-mailsimulator-submit-button)


This ifdef has no endif, at least none i can find^^


Fair enough, I'm not entirely convinced but it makes sense and I trust you looked into it, thanks :)


# Asset Sizes
## firstView sign in
| File | FileSize |
|----------|----------|
 /sign-in|587 B
/bundle.js|185.11 kB
/ba241dabfe.js|4.08 kB
/ba241dabfe.css|668 B
/releases/v4.7.0/css/font-awesome-css.min.css|7.81 kB
/releases/v4.7.0/fonts/fontawesome-webfont.woff2|75.68 kB
/milktronics/beaglegr.am/master/public/fonts/billabong-webfont.woff|49.27 kB
/.ws?v=5|316 B
/favicon.ico|387 B
/.ws?v=5&ns=performstagram-ec72e|435 B

## firstView grid
| File | FileSize |
|----------|----------|

# VisualMetrics
## Metrics Average
| View | Time to First Byte |  Render Started  |  Visualy Completed | SpeedIndex | Load Time |
|----------|----------|:-------------:|------:| ------:|------:|
FirstView  | 620 | 1906 | 2483 | 1937 | 42801 |
RepeatView | 239 | 768 | 958 | 778 | 45061 |
# Waterfall

## firstView
![alt text](http://www.webpagetest.org/results/17/01/31/QE/ZQ7/1_waterfall.png)

## repeatView
![alt text](http://www.webpagetest.org/results/17/01/31/QE/ZQ7/1_2_waterfall.png)

# FilmStrip
## SignIn First View

| 0 milliseconds|
|--------------|
| ![alt text](http://www.webpagetest.org/getfile.php?test=170131_QE_ZQ7&video=video_1&file=frame_0000.jpg)|
| 0|

| 1900 milliseconds|
|--------------|
| ![alt text](http://www.webpagetest.org/getfile.php?test=170131_QE_ZQ7&video=video_1&file=frame_0019.jpg)|
| 94|

| 2500 milliseconds|
|--------------|
| ![alt text](http://www.webpagetest.org/getfile.php?test=170131_QE_ZQ7&video=video_1&file=frame_0025.jpg)|
| 100|

## Grid FirstView

| 0 milliseconds|
|--------------|
| ![alt text](http://www.webpagetest.org/getfile.php?test=170131_QE_ZQ7&video=video_1_2&file=frame_0000.jpg)|
| 100|


It is not causing problems, I am just suspecting that requests to it can be used for tracking purposes. When I tested, blocking the domain `integritystat.com` did not seem to be causing adblock detection, how about on your end?

We are blocking `geektime.co.il/wp-content/embeded-adtional-content/` where they pull ads for now, and also aborts the execution of the script used to pull ads.

Do you know of any other websites which use the same ad network? What we currently know are pocketnow.com and geektime.co.il.


Initialized is not enough - it must also obey ownership semantics. The deque must own the value it calls .clone_from on, it can't be something that has already been `read` out.


Ha!  I thought it was my editor who added the trailing spaces, and I always remove them.


Тут мой косяк - недоглядел. нельзя убирать erase


I think technically `Int32.MinValue` is a valid resource Id.  All of these should default to 0.


Also mind the gap (1 capacity reserved and unused at all times. Can never call clone from on that slot)


Good catch... Added an issue to track it: https://github.com/libretro/RetroArch/issues/4537


Extraneous whitespace.


@adamcheasley Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.api/28/violations
```
src/plone/api/content.py:269:1: C901 'delete' is too complex (15)
src/plone/api/content.py:361:1: C901 '_wf_transitions_for' is too complex (13)
src/plone/api/content.py:426:1: C901 'transition' is too complex (13)
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


на индексе мы собираем классы, которые на вьюхе индекса будут дробиться.
у нас есть Index, он юзает HomeIndexViewModel как класс для данных
на Index.cshtml из HomeIndexViewModel мы берем OtherCitiesPlacesViewModel и даем его OtherCitiesPlacesViewComponent, аналогично и с SearchVM и SearchVC. VC - компонент, VM - класс с данными для этого компонента. На Индексе у нас должен вызываться ThisCityPlacesViewComponent
![untitled](https://cloud.githubusercontent.com/assets/14316169/22473728/729706f6-e7e2-11e6-8f53-03b2160eb8dd.png)


(Which means that I don't see a simple way for neither the full case to overwrite using clone_from either)


Put the semicolon on the previous line.


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 121](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=48377&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **FAILURE**
Summary: Snapshot dependencies failed to start: 2 Build time: 00:00:01


Это что такое? Я не могу понять что ты этим хотел сделать...


Этих файлов не должно оставаться после git reset --hard. Выглядит так будто бы ты забыл указать --hard


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2053](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=23269&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


Why not?


If I understand you correctly, then doing a `push_back(object.clone())`
should allow exactly that?

Maybe the problem is the `Dec<BTreeSet<T>>`? When it's `clone_from`ing it,
is it doing a deep copy?

On Jan 31, 2017 16:22, "bluss" <notifications@github.com> wrote:

> Initialized is not enough - it must also obey ownership semantics. The
> deque must own the value it calls .clone_from on, it can't be something
> that has already been read out.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/SuperFluffy/arraydeque/commit/8c052247ba101350b73c8642abb4f553852d3a07#commitcomment-20681845>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAqy-ax2ctdBTKR9e8RPgqG0gVDxuEZTks5rX1_IgaJpZM4Ly1c1>
> .
>


please be careful with unrelated whitespace changes


@tripy fyi here are the changes for the agent checks :)


Looks ood.


Also added display for the title (without the date appended), the inclusive date, and the bulk date.


That's a good point, I will need to check that! However, the program
already encounters problems way before reaching that last element.

On Jan 31, 2017 16:24, "bluss" <notifications@github.com> wrote:

> Also mind the gap (1 capacity reserved and unused at all times. Can never
> call clone from on that slot)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/SuperFluffy/arraydeque/commit/8c052247ba101350b73c8642abb4f553852d3a07#commitcomment-20681887>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAqy-YvARtFBEBeSb6lZUZ7NkP5VTjEsks5rX2AlgaJpZM4Ly1c1>
> .
>


Why not a union type restriction on these four duplicated defs?


Iversion of last loop violates sorting stability i.e. the same elements in 'values' can be swapped in 'sorted'. It may be crucial when sorted values are keys from some hash map. If it doesn't matter, cumulative frequency stage can be omitted too.


Resolves #23


Thanks! That's clearer indeed.


Finally! Great!


Does `T` need a specifier saying that it implements `IMvxRecyclerViewAdapter`?


Salut. Je sais que ce repo est destiné à la traduction française, mais tu devrais garder README.md comme nom pour que github afiche automatiquement le contenu formaté sur la page d'accueil du repo.


Это вьюмодель для ThisCityPlaceVC. Она отображает одно заведение и находится внутри контейнера ThisCityPlacesVC. Он не редактируемый - этот класс нужен для вьюмоделей компонентов, которые реализуют в себе контейнер и пользователь может настроить отображение всего контейнера. Примером контейнера может быть тот же ThisCityPlacesVC, его вьюмодель должна наследовать этот класс


@nono Ok, je pense du coup faire une structure qui ressemble à ça :
```json
"documents": [
  { "doctype" : "io.cozy.doctype1", "ids" : [ "id1", "id2" ] },
  { "doctype" : "io.cozy.doctype2", "ids" : [ "id3" ] }
]
```

Pour notamment anticiper un partage avec plusieurs doctypes même si je ne sais pas si on aura le cas…


Since this class is carrying around a list of `IDisposables` it should probably also implement `IDisposable`.


Тут правильно - вьюмодель этого компонента должна хранить информацию о настройке, так как ThisCityPlacesVC это контейнер и его можно скрыть/настроить/тд


I should have solved the problem with packagist.

I don't understand you. We don't have a release/branch named 1.2.0. The master will be version 2.0.
But #250 was merged into 1.0 branch and i have created the tag v1.0.2 there. Did I do something wrong?


C'était pour rester cohérent avec le reste du document où j'ai mis les constantes en majuscules (donc pas de réelle raison)


Make it submit instead of submit1


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2054](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=23270&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


Let's track Stderr and Stdout separately - seems like having two `*activityBuffer`s should be fine. Then we'd just need to update `hasTimedOut()` to check both of them.


Если ты посмотришь OtherCitiesPlacesVC, там помещается только 4 OtherCitysPlacesVС в ряд, потому я поставил ограничение. В данном случае мы можем грузить для текущего компонента сколько угодно заведений, они просто будут подстраиваться вниз, как в ВК подстраивается новостная лента


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.27.0-pre-11-g1d96d7f](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=48381&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **SUCCESS**
Summary: Running Build time: 00:00:43


userRegForm


это правильно


Angular etc gets pulled in via bower on line 15:

`gulp.src(bower().concat(libs))`

I'm still using uglify so it won't remove any library bits that aren't being used (as far as I know) and the CDN files are already minified so probably no size saving there. It's more about getting everything into a single file to save on roundtrips over mobile.


I worry about breaking other platforms with this. Can we use something like `#if ! defined <something_defining_musl>` ?


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2052](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=23267&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **SUCCESS**
Summary: Tests passed: 308, ignored: 4 Build time: 00:14:17


To thoroughly confuse you: here "der Rückgabewert"


Почисти лишние пробелы)


Ah, #250 was fixed in 1.0.2 but it's under 1.0.1 in the change log. that's all. (i mistyped 1.0.2 as 1.2.0)

Thanks!


@mpharrigan Do you have a log file output, so I could provide a patch?


Добавить вызовы ThisCityPlaceVC в ThisCityPlacesVC


I have no problem with jessie and `libnss-mysql-bg`.

I only had to fix the query for `memsbygid` as follows:
```diff
- memsbygid   SELECT members \
-             FROM ftp_groups \
-             WHERE gid='%1$u'
+ memsbygid  SELECT SUBSTRING_INDEX(SUBSTRING_INDEX(ftp_groups.members, ',', m.n), ',', -1) AS name \
+            FROM \
+            (SELECT 1 n UNION ALL \
+            SELECT 2 UNION ALL SELECT 3 UNION ALL \
+            SELECT 4 UNION ALL SELECT 5 \
+            ) AS m \
+            INNER JOIN ftp_groups \
+            ON ((CHAR_LENGTH(ftp_groups.members)-CHAR_LENGTH(REPLACE(ftp_groups.members, ',', + ''))) >= m.n-1) \
+            ORDER BY id, n
```

All running smooth using this query.


here action attribute is not required.


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


Добавить > 4 заведений (8 - 12)