:heavy_exclamation_mark: There are 3 visual regressions in this pull request

Please Visit https://github.com to check out these diffs
* screen **Rogue One: a star wars story** on **iPhone6** for **en-US** locale
* screen **star wars episode IV: a new hope** on **iPhone6** for **en-US** locale
* screen **star wars episode IV: a new hope** on **iPhone5** for **en-US** locale

| Diff 1 | Diff 2 | Diff 3 |
| ------------- | ------------- | ------------- |
| [![Image of Diff1](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies/3/3.1/diffs/en-US_iPhone6-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff2](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies/3/3.1/diffs/en-US_iPhone6-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff3](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies/3/3.1/diffs/en-US_iPhone5-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) |


no, it doesn't work


for me at least ;)


i'll push something later


going through tutorial.


Don't Tread on Me/Assets/Scripts/TankMove.cs

Here is a test comment, this is gonna break shit


Screen **star wars episode IV: a new hope** on **iPhone6** for **en-US** locale contains 3 differences

| Screenshot | Review comment |
| --- | --- |
| [![Screenshot](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies/3/3.1/diffs/en-US_iPhone6-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | There are 3 differences in this screen. It has been reviewed as a defect by AppSnap |


Screen **Rogue One: a star wars story** on **iPhone6** for **en-US** locale contains 3 differences

| Screenshot | Review comment |
| --- | --- |
| [![Screenshot](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies/3/3.1/diffs/en-US_iPhone6-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | This is very wrong ! |


Screen **star wars episode IV: a new hope** on **iPhone5** for **en-US** locale contains 2 differences

| Screenshot | Review comment |
| --- | --- |
| [![Screenshot](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies/3/3.1/diffs/en-US_iPhone5-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | There are 2 differences in this screen. It has been reviewed as a defect by AppSnap |


One small bug. `entry['date']` is a string here, and it's saved in DD-MM-YYYY format, which means it won't be sorted by date properly. (Add a task a few years in the past to see this.) I'd recommend either converting the entry dates to python dates, or saving them in YYYY-MM-DD format, to resolve this.


Why not just use `$MAIL_BIN` if you want to get rid of all the `$api_bin = MAIL_BIN`?


I’d vote for match_string being buggy and not match_insensitive.
pos+string.len() is a « buffer overflow » to me. slice has a length of string.len(). pos+string.len() is therefore « out of bounds ».

on rust playground:
fn main() {
    let bla = "abcd";
    let coin = unsafe { bla.slice_unchecked(0,bla.len()) };
    println!("{0}", coin);
    let coin = unsafe { bla.slice_unchecked(1,bla.len()) };
    println!("{0}", coin);
    let coin = unsafe { bla.slice_unchecked(1,bla.len()+1) };
    println!("{0}", coin);
}

gives:
rustc 1.15.1 (021bd294c 2017-02-08)

abcd
bcd
bcd<


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 79](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1482&buildTypeId=Xbim_XbimWebUi_XbimWebUi) is now running


alternative projections for single top and boosted top can easily be added here.

The `projection` python parameter selects which projection is actually calculated on the event.


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 79](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1482&buildTypeId=Xbim_XbimWebUi_XbimWebUi) outcome was **FAILURE**
Summary: Compilation error: Xbim.WeXplorer\Xbim.WeXplorer.csproj (new) Build time: 00:00:34


This commit has been deployed to DEV


**Oops!** It looks like something in this commit broke the build. Please take a look and fix it.

**Warnings:**
`src/content/en/updates/2017/02/navigation-preload.md`: TL;DRs should be H3 and inclue {: .hide-from-toc } Found: ## TL;DR


Standard python grouping with parenthesis is also possible for multiple line imports
https://www.python.org/dev/peps/pep-0328/#rationale-for-parentheses
It is implied that it is preferred to other approaches (at least this is my understanding after reading the linked PEP)


You could do this in one line as a list comprehension 😀
`return sorted(entry['Date'] for entry in current_entries)`

List (and also dict and set comprehensions, because Python is awesome) are basically the best things ever.

http://www.pythonforbeginners.com/basics/list-comprehensions-in-python


Submachine gun has no dash in the name. https://en.wikipedia.org/wiki/Submachine_gun


This commit has been deployed to TEST


My name <3


@byrondevonwall Thanks for the props. I just published version 2.8.6 which contains the logic we had a while back, which should fix this specific problem. Sorry for any inconvenience.


Exercise to the reader: rewrite the construction of search dates and searched_entries as a list comprehension :)


This commit has been deployed to Stagging


You're right, it should.


Why was throws Exception added here?  I dont see where an exception is being raised?


lol @ this


@nguyenhoan , please see the 3 pull requests associated with this ticket for an explanation of the changes.  https://jira.duraspace.org/browse/DS-3456.  This change was applied to 3 releases of DSpace.


the poor braces :(  (Serious tho)


@kd-11 Good commit this ? i have set this for fix Error in SplatterHouse and in works with this, i have Ingame, but only HUD, same Bleach etc


No. The one with v7r11 wasn't built, yet and Phil reverted to v7r8 as far as I can see.


:+1: :100: :grinning:


juan.fraser/01 - Lista Circular/main.cpp

Otra opción en estos casos es usar un "break", que solo sale del bucle. Cuidado con los "early return" que son fuente de bugs muchas veces.


@M94JU24PLI12 @Tati-ana @dk248 Befehl um die Datei in Git Bash auszuführen:
. python_localhost.sh

Die Datei liegt im repository. Ich finde es so einfacher als jedesmal den python Befehl durchzuführen. Python installieren und als Umgebungsvariable einfügen muss man trotzdem noch.


Previous version was right - the correct destination is /etc/glare/glare.conf


Noticed that you only have to **STAGE** the files that you wish to commit.


este doble if se puede reemplazar con un solo "and", asi: if (root == tail && root == element)


Should this comment be updated?


whoops, forgot to take this out ;)


@M94JU24PLI12 @Tati-ana @dk248


Aww, no merge (so no commit points)... ;-)


- NamelessCoder\GizzleGitPlugins\GizzlePlugins\ClonePlugin:000000006a24c5e000000000326f552e:
  - 0: Executing Git clone command: /usr/bin/git clone --depth 1 --single-branch --branch '1.8.6' 'https://github.com/clickstorm/cs_seo.git' /tmp/49e6d294c9a6952eecd2a5d47cde0a2f4176c163/cs_seo
  - NamelessCoder\TYPO3RepositoryGizzle\GizzlePlugins\ExtensionRepositoryReleasePlugin:000000006a24c5fe00000000326f552e:
    - resultCode: 10504
    - resultMessages:
      - 0: Please note that it might take a while (up to an hour) until your extension and the documentation appear on TYPO3.org.
      - version: 1.8.6


@anthonykulis
obviously I solved the previous issue but created another one!!
whenever I run Maze I get an array out of bound error on this line


@HEXcube i hope it your hope :-).
By the way, if you can increase or decrease the opacity if you think the color need to be smoother.


I only updated the PKGBUILD and was waiting for @philmmanjaro to rebuild it with the next patch point rel. I had forgotten about that issue but apparently he still remembered that there was something wrong with v7r11.
I did in fact go through a bunch of older commits but didn't see the ones including v7r11. So I just thought that we had never updated it...


Line 22: added a space before link and end bracket to linke


I did notice that behavior as well -- that the dev requires get installed even when explicitly not in dev mode. Not sure what's up with that.

Sometimes I like to test my code before committing, when I feel like being a responsible developer. But if you just rely on Travis to do that for you, that's fine.
However, the one reason I would include phpunit in require-dev is that if anyone wants to contribute but can't make commits directly to your repo, they can just fork yours, install composer, and they can immediately run your tests to make sure their new code won't break anything -- whether they submit a PR or not.


very welcome @katyhuff =)


Hi!

Forking and changing this is a great idea.

Is it working currently?
I tried a project key like this:

com.my.package%3Amy-project%3A${GIT_BRANCH}

And I'm getting _IllegalCharacterException_ for _$_


All `{$list}` and email arguments _should_ also be put in quotes


@M94JU24PLI12 @Tati-ana @dk248

Wenn ihr nachher die Seite im Browser anschauen wollt müsst ihr http://localhost:8000 eingeben.
Wenn ihr Änderungen in den Dateien vornehmt müsst ihr den Tap schließen und neu öffnen um die Änderungen zu sehen, da der Browser sich die Dateien merkt und beim einfachen Neuladen nicht neu lädt.


is the `MesosUtils`needed here?


This will give a error for old Roms I think


First of all, I don't get if `this` daemon can be in `aliveWithOpts`. I will assume that it's not because it probably could not connect to itself in `walkDaemons`.

(1) **If** the `best daemon` fits into `me` and the `best daemon` is younger than `me`, **then** `I` take over all other daemons clients.
(2) **If** `I` fit into the `best daemon` and the `best daemon` is older than `me`, **then** I give my clients to that daemon.

I'm not really sure in this algorithm.
I seems that it is correct in a sense that daemons cannot kill each other.
However it seems, that it is not always optimal.

For example:
1. daemon A starts with params: maxMem=100, codeCache=50
2. daemon B starts with params: maxMem=200, codeCache=50
3. daemon C starts with params: maxMem=150, codeCache=100
4. A performs election: (1) is false because neither B nor C does not fit into A, (2) is false because both B and C are younger than A.
5. B performs election: (1) is false because neither A nor C does not fit into B, (2) is false because B does not fit into neither A nor C.
6. C performs election: (1) is false because B is better than A and B does not fit into C, (2) is false C does not fit into neither A nor B.
Result: all daemons are alive and well.


Can you give any indication of when these fixes might make their way into the version of the Django on PIP? (Currently 1.10.5 I believe)


Yeah the maths make sense


As you can see from the patch, it will be in Django 1.11. The release schedule is [available on the download page](https://www.djangoproject.com/download/).


A1 Q1


This commit has been deployed to DEPLOY


@rahulravindran2709 I've noted the point about using arrow functions for multi-line functions - didn't know that that was accepted style. Good to know.

As for extracting response and error handling functions, I notice that the split is presumably so that users of fetch can re-use it, but I don't think that lines up with the reason why I created an `ApiService#fetch`.

My intention was for this method to serve as a single point (mandatory) for communicating with the API. Every consumer would be expected to use `ApiService`'s fetch, which would, then return a promise that would do one of:

a. `promiseFromFetch.then(successResponse => doSomething())` OR
b. `promiseFromFetch.catch(errorResponse => handleError())`

This pattern can be seen here: https://github.com/godreams/admin-server/blob/master/src/components/Login.jsx#L31-L41


re-included previously falsely deleted link to projectUpdate, function was fully operational before


Kepp it up brother..


Is this really the correct value here? It seems we get readings up to 7m from the robot. Why is it set to only 1.5m? @cdondrup, do you know?


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2115](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=23886&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


Btw, now `check` can be replaced with `takeIf`


@davidvanlaatum because this method was removed (also for `JellyTemplateConfigProvider`), config-file-provider plugin is not able to migrate the old data to the new datastructure. It is not able to find the old file


Thanks for the quick and concise reply!


*shh bby is ok*


globals no comprendo


develop (macumber) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


-.-

salediablo


Jira ref is actually 523, not 253.


Drat.  I'll fix it.


EMS (brianlball) - i386-Windows-7-VisualStudio-12: Tests Failed (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


Wow you even posted a mergue request! Thanks a lot honestly @trolleycrash


Robert,
The usage says this:
`  -z tier     compact to tier`
`  -t tier...  compact to tiers`

But the code says this:
`        case 'z':`
`            if (mode != UNKNOWN && mode != COMPACT) usage(argv[0]);`
`            desttier = optarg;`
`            mode = COMPACT;`
...
`        case 't':`
`            if (mode != UNKNOWN && mode != COMPACT) usage(argv[0]);`
`            srctiers = strarray_split(optarg, ",", 0);`
`            mode = COMPACT;`

I'll not alter squatter.c, but I suspect you need to change the usage for -t to this:
` -t tier...  compact _from_ tiers`

Cheers,
-nic


:ship:


I'll be able to setup march's holiday sometime next week.


You need to supply a comment string describing the date & release of the commit.


`puppet/` also matches `lib/puppet/`. Which caused me not to commit a lot of files. ;)


![](https://github.trello.services/images/mini-trello-icon.png) [Join GitHub Repo](https://trello.com/c/d0fbMe6B/7-join-github-repo)


Class names should start with an uppercase letter.


@jprotze Does the "libunwind.h" header get installed automatically? When I compiled and installed Clang/LLVM this header wasn't installed and if I compile the OpenMP Runtime stand-alone it fails because it can't find it.

Maybe it needs to be included within:

```
#ifdef OMPT_USE_LIBUNWIND
#endif
```


Hmm. It feels a bit roundabout to create a resource that is only used to set a variable in the Scheduler code, where the original value is already available (there's even a fallback?). The resource is not used in the regular resource limiting part of the Scheduler either.

This change only raises confusion. So 👎 from me.


Need copyright.


I don't get why it is checking that `getClients()` from `this` returns `Good`, but it does not check that `fattest` is `Good`?


Hah.. I think this was from 3 years ago. I'm moving cyder over to my research group repository arfc , so I guess github is re-notifying everyone ever mentioned in the commits?... whoops. :D


:+1:
That was causing a series of issues with several forms, I think.


Please make sure to run scalariform before committing.
(Scalariform gets run if you compile in sbt.)


No need to export this symbol, so redisError


ah okay, whoops. thanks for fixing it up


`:ship:`


How can i help you?..i have installed the CRAHN successfully..i didnt study
much about it

On 9 Feb 2017 10:30 p.m., "israaie" <notifications@github.com> wrote:

> lintreesa can you help me??
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/abdulla-alali/TFRC-CR/commit/0f719ee7c7082275c33706eaa4d882750d7a1483#commitcomment-20822118>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ANUIDHtPabX3miAkm_Up_RXoe6Fke6pPks5ra2k_gaJpZM4IJtwU>
> .
>


I agree with bilderbuchi


I imagine we'll launch a bunch of mongodb servers from the admin script, and let each handler connect to the "local" mongo worker?


develop (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


Add JavaDoc that CellReference ref must define a sheet name or an IllegalArgumentException is thrown,

/**
 * @throws IllegalArgumentException if ref does not define a sheet name to evaluate the formula on.
 */


I'm clear on the point of removing the board specific ifdef. And the comments will be clear (I think) if they state that clock_freq *must* be the actual frequency of STM32_APBx_TIMx_CLKIN. Otherwise the timer freq will not be the sacred 1MHz and no telling what that will break.


however, the files like disk images stay behind. `minishift delete` would delete them... or use `rm -rf ~/.minishift/machines`


Comment is incorrect, no throwing in Go. So what is the actual behavior on failure? Should this return (Connection, error)?


Please remove Java isms.


This code looks quite similar to SWIG_AsVal_int
Why don't we call SWIG_AsVal_int and if it fails with SWIG_TypeError, we try the rest of the code.
Therefore, we get any improvement via swig and the support for other bindings is greatly facilitated, since the SWIG functions are provided for each target languages.


@Anteru comments on the replace method?


Muy bien en general, funciona y pasa todos los tests.
Si te animas ahora agrega el "insertNextTo", que debe insertar un elemento nuevo a continuacion de un puntero a uno existente pasado como parametro. Si haces esto inclui una nueva funcion "testInsertNextTo" con los tests que incluirias para probar ese metodo.
Mas alla de eso, felicitaciones!


you basically have a special case for the first element in the input array (you initialize the output array to have the first elemet of hte input array, and then in your loop you skip the first index). i'm saying you don't need to do that, your loop should handle everything


Awesome, nice one! The more easy to use fly-time Bhyve has with more users looking at it, the better for everyone. I can't wait to try this flavor, already tried it in the original project ;)


ya


Yes, I am currently figuring out how to launch just 1. I did find a way to launch a sharded cluster of mongodb containers, but need to implement it


I have used additional markers to implement replace; thoughts? @Anteru


Is this a printf-like function? If so then please make if PipeAppendf to match Go conventions.


Test to try to view my changes on the site before I pull request


No es necesario el return al final cuando la funcion es "void", porque no devuelve nada.


Again, no throwing in Go. Should this return (Response, error)?


:ship


develop (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png)


yeah I guess it's bad idea if it's not constant. Oh php..


it should be working after few patches in source https://review.lineageos.org/#/c/160158/


Так не годится. Разные контроллеры под разные действия.
Например /tasks/types/2(это id)/delete (метод POST или GET)
Например /tasks/types/2(это id)/update (метод POST)
Например /tasks/types/add (метод POST)


develop (macumber) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


What? No, that's essential!!

> On Feb 10, 2017, at 11:26, Charles Strahan <notifications@github.com> wrote:
>
> @copumpkin I don't suppose this was meant to remain? (echo "FOOOO")
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>


files missing :/
tried commiting from vscode but failed apparently :D


return Collections.unmodifiableList(dvs);

Someone could incorrectly assume that they can modify a workbook by adding or removing items from a returned list. An unmodifiableList reinforces that modifying returned lists is not part of our API (it is for other projects).


Sounds good. No rush, I just wanted to get all of the holidays in there and ready to go.


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2115](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=23886&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **SUCCESS**
Summary: Tests passed: 282, ignored: 3 Build time: 00:19:44


Sure, but you're slicing `self.string`, not `string`. They're different. :)


You'll mostly want to use it via the SqliteDb::prepare() function - which
returns a reusable statement object you can bind params with and use to
iterate through query results one at a time.  And if performance is an
issue - remember to wrap several inserts with a BEGIN and END TRANSACTION.

On Fri, Feb 10, 2017 at 9:22 AM, Katy Huff <notifications@github.com> wrote:

> added @rwcarlsen's sqliteDb class, to try it out.
>
> --
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub:
> https://github.com/arfc/cyder/commit/8948e41d18661efa9958f375ad7355
> d566dd54fc
>


Comple


Whats the reason for not mentioning mingw64, this looks actually like valuable information. Would've helped me like 2 days ago.


Ah yes - whoops. Thanks for spotting that. Had that `source()` statement commented out while I was testing and accidentally overwrote it with a find & replace. Will fix that now.

I think the testing process is great as is. `testthat` is very commonly used and I don't see any problems with the way we have things currently. There are a few other potential approaches (RUnit, testit etc) but I think what we've got is the most standard. All it requires is opening the `test_*.R` script in RStudio and hitting Source, which is super simple and should be learned early on by beginners. One can also automate the tests with testthat's `auto_test()`, which will then re-run tests whenever the main script is edited (& saved), but this isn't really necessary.


=)

On Fri, Feb 10, 2017 at 5:57 PM, Katy Huff <notifications@github.com> wrote:

> Hah.. I think this was from 3 years ago. I'm moving cyder over to my
> research group repository arfc , so I guess github is re-notifying everyone
> ever mentioned in the commits?... whoops. :D
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/arfc/cyder/commit/714556ac9c13fdb8318c4153d571ce3138a966f6#commitcomment-20836433>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABVAEUvD01tyaaJOf4L_KfbgePkA433Nks5rbJcFgaJpZM4L9kNU>
> .
>


`this` daemon is filtered out by the `filter` function passed to the walker.

Seems that you're right, the second condition should be corrected. But at least it looks safer now, so I'd push it through anyway.


Good catch, is fixed and pushed.
Integration of the libunwind-approach into the cmake-workflow is not done yet


Hi Sergei,
I recall you creating a new function that prints all variables in scope to the screen. Is it possible to commit that as well?


check my alias cdp, I use it for same purposes


See in the case 'file' block. You can add this code there also.


hi @mdouchin

i already tried exporting from the table
awesome!

why the export button appears disabled?


BTW, can be slow https://youtrack.jetbrains.com/issue/KT-15491


ahh yes.


Why is this needed at all?


looks good


@jeremyhu: Thanks for the hint!


I don't think you actually need generics here, you can simply say `Class<?> clazz`, because it doesn't need to match any other arguments.


here we might need to check


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.30.1-pre-2-g9358285](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=50292&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **FAILURE**
Summary: Snapshot dependency failed: ... Test Server Build time: 00:00:01


To fix the auto version generation follow these instructions:

- Download [Git for Windows](https://git-for-windows.github.io/)
- Install it and select "run git from windows command prompt"


This was due to `caching_tag_list_on?` not being found as the class methods in cache.rb were not ever added to the model. Suspect that something changed in Rails 5 on how `ActiveRecord::Base.columns` is used. (It was deprecated in 4 and now no longer exists in 5.


Same here, no need for generics on this method. `Class<?>` is better.


code reviewed and approved


👍 Shipped as `v2.0.0`.


why do we need to marshal results? we will only use kafka queue for updates and updates do not return any result


The `Connector` interface is implemented by any Adaptor that supports I2C communication. Examples of a couple Adaptors that implement it would be `platforms/beaglebone` and `platforms/firmata`

The Connector interface is consumed by I2C Drivers. These drivers are currently all in the `i2c` package. Examples would be `BlinkMDriver` and `BMP180Driver`.

Pretty sure this is a valid use of interface here?


Hi Alfredo, I have recently forked this project and got stuck in the same place as you. Something related to db access. I am trying to make it work in the lesser time I have.
I'll let you know when I have it running.

Best regards from Argentina...


`Good` here is the check of the remote call return value. If you `get()` it without checking - it throws.
The results from `registerClient` call on the fattest daemon is not used, therefore is not checked.
And `fattest` itself is already checked in that sense on walking.


Hello, I had some issues when I changed the sprites anchor point, if the anchor point is different to 0 the collision is not exact, I made this change

https://github.com/kittykatattack/bump/blob/master/src/bump.js#L73
https://github.com/kittykatattack/bump/blob/master/src/bump.js#L87

from this
`
return sprite.height * sprite.anchor.x;
return sprite.width * sprite.anchor.y;
`
to this
`
return sprite.height * sprite.anchor.y;
return sprite.width * sprite.anchor.x;
`

Idk if that is a bug but now works well on any anchor position


Unnecessary outer if statement


Nice spot - thanks. It's been ages since I last wrote Java, super rusty! I'll change that now


this is useful when you have redundant writes to improve the reliability of the system.  e.g. you could calculate the same metrics in multiple datacenters and rely on cassandra replication to collate the writes into a consistent view in all datacenters.  that way if a component is down in one datacenter, the other datacenter will still calculate the correct value.


`truthPath` should not be used here.


`truthPath` should be passed to basename.


Move the NPE-avoiding workbook.getSheet.getRow.getCell to its own function to keep the core logic simple. SheetUtil has some similar functions. SheetUtil.getCell(Sheet sheet, int row, int col) works.


I think I was too literal with your previous advice. Actually, perhaps `Config` should be in a separate file, such as `i2c_config.go`. What do you think?


Script simples que ativa o áudio na nova versão do Kali Linux 2016.2


Oops,
This doesn't look like Java.. Did some iOS code sneak into the Android Documentation? 😕


Looking forward to deploying this on our z20 for QA!  :)


it would be better if you named the tables based on the rollup rather than the period or ttl so that you can change your retention policy without migrating data or renaming tables.


Please use proper variable names. `jo` isn't descriptive enough.


Since the config contains a MinDeduplicationDuration field, it should get initialized here.


Refer to comment above


Do we have to use CamelCase name for properties or "size" would work just as well?


newAspectWithDedup


Az!


size, Size, setSize, SiZe all work. It checks the exact method name, and the property name with a case-insensitive check


This is legacy support when we where trying to support old internal solutions. I think we can get rid of this and https://github.com/android-ia/external-mesa/commit/a671b3a959b80f3a2c756cf5ee5ddcc52113f244 and https://github.com/android-ia/external-mesa/commit/995e85e8f5146c1c29dee7df3095a509eba448be#diff-8e6610472811c3e3b70e11545e13a9afR44


please move these two to translation file as well


Is this log statement correct and/or necessary?


It might also be worth mentioning...

Mobile devices model often use a root or home directory that's a UUID provided at install time. Software that operates in a sandbox or walled garden cannot forgo the configuration information, like a hard-coded filsystem path.


Hmm, what if we don't have a setter, just a public final field with a ctor that initializes? I guess reflection doesn't mind final, but want to confirm.


You have to select at least one feature to be able to export data from the selection tool.


getCachedFormulaResultType assumes that the cached value is in sync with the actual value. Might be worth adding an inline comment or JavaDoc about this in case it causes problems.

Code formatting-wise, I'd break this boolean expression into 2 or 3 lines. Store cell.getCellTypeEnum() in a temp variable if needed.


Looks great paul! I merged it but the logos didn't go over... not sure if I'm doing this right at all.


+1, a.k.a., I approve of this commit.


I am not sure your are using the right code

    self.modify_config() is called with either DEFAULT or CUSTOM


All the dedup stuff needs to be handled through persistent storage and not with in-memory state, so that deduplication happens across nodes.


It's hard for constructors. We need the parameter name which is pretty much impossible <Java 8, and tricky in Java 8. I'd love to add this - I much prefer data classes to be immutable, but I don't know a way. Any ideas?


I've simplify this. Check last commits


I approve of everything except the word "whining". "Nagging" would be a better word to use here.


changed the step tolerance


Hey, can you merge/send pull request to the master branch so that it's merged? This was very useful to me as well and I would imagine that it would also be to many more people.

Thanks!


we discussed this, don't use !important


Test line in index.html


If you end up using exactly the same code here as in memQuota, then we should create a utility library somewhere and share this code.


While using this map file for testing in the reference implementation, I noticed a missing curly brace here.


Now empty means DEFAULT


In this checkpoint, you're simply setting up that class. In the next checkpoint, you're introduced to one more concept that will "fix" this method (and class)

Here's the next checkpoint. Read through and let me know if that doesn't answer your question: https://www.bloc.io/users/nam-lu/checkpoints/827?roadmap_section_id=6


Ah its cool, I see them now. Ignore me. Got the desktop app and just trying to figure out what i'm doing.


yes of course, but after selection the button is still off


I think it is a good idea to mimic SWIG output of
SWIG_exception_fail(SWIG_ArgError(res1), "in method '" "SwigPyIterator_decr" "', argument " "1"" of type '" "swig::SwigPyIterator *""'")
It looks like the SWIG macro
%argument_fail(ecode, "$type", $symname, $argnum);
Should do the trick nicely
Also SWIG uses SWIG_CheckState instead of SWIG_IsOK in typecheck typemaps


I've checked both and they appear to be correct. If you can write a test with `StringInput` that proves the opposite, I'll fix it.


I've got Corral/FNAS-X cuz the templates are sweet but end up using vm-bhyve for the most part every day (sweet project and great guy working on it) but I've got 1k FreeNAS 9.x bhyves ready to fire up for testing other projects and it's easy to sling around and run the FreeNAS bhyve elsewhere. If I could wrap em all together or get a standalone app, man, I'd use it constantly.


You can just write:

type poolImpl struct {
  pool.Pool
}

And then in the code below, you can directly call methods on your poolImpl as if it was a pool.Pool. This is basically go's simple version of inheritance.


may be we can even create the ProducerRecord object in updateProducer. I mean just sent the operation. So we can move KafkaLogic away from this runner


please open an issue ;) Can you give steps to reproduce the bug in the issue ?


Definitely do not want to panic.

Panics are reserved for catastrophic programming errors, not as a way to implement Java exceptions in Go.


please find a work around
!important instructions are not welcomed


ok


👎 This is a BC break, it is currently used for example by [Nette Database adapter for Nextras Migrations](https://github.com/nextras/migrations/blob/5dd5e4d365bbbba5d53d02c7e203d68a5a7f1ce9/src/Bridges/NetteDatabase/NetteAdapter.php#L57-L60)


Don't use the name 'this', it's against Go guidelines. Use "p" or "pi".


Nope. Roslyn now maps `full/pdbonly` to `portable` internally.


Oh, you're still on 1.6, what about http://stackoverflow.com/questions/3301635/change-private-static-final-field-using-java-reflection ? I know it's nasty, but better than nothing?


Ok, seems like same process id jobs should come in single batch


Hola, yo también soy argentino!

Lo pude hacer andar al final el proyecto ese (solo la parte del manager).
Lo hice con el anon/anon user/password. También le cambie el "role" de
"anon" a "admin para tener toda la funcionalidad, ahí te paso un screenshot
de la linea que modifique.

No es la solución pero si sirve por lo menos para pasar el login. Tambien
vas a tener que agregar una key para usar la api de google maps en
index.html.

Espero que te sirva esto, saludos.

[image: Imágenes integradas 1][image: Imágenes integradas 3]

2017-02-10 14:19 GMT-03:00 Luis N. Polasek <notifications@github.com>:

> Hi Alfredo, I have recently forked this project and got stuck in the same
> place as you. Something related to db access. I am trying to make it work
> in the lesser time I have.
> I'll let you know when I have it running.
>
> Best regards from Argentina...
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/lpolasek/HubTaxi-Server/commit/5828a502e22efca7d3c00636252156f1867b14e4#commitcomment-20836808>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AR0XWR31xwn5VuTnX8xZNOKVIYgRnKKaks5rbJwigaJpZM4Lx_9H>
> .
>

--
Alfredo Bollati

(249) 154 - 325561

Los Patos 152, Tandil, Buenos Aires, Argentina.


Formatting: break if (condition) { action } into two lines


I do wonder if it's a good idea to never allow the buffer capacity to shrink while a connection is maintained. In the case of [tokio-cassandra](https://github.com/nhellwig/tokio-cassandra), the worst case is the server sends a frame sized at 256MB, but most frames will be significantly below that.
Do you think this is an actual problem - maybe I am making the wrong conclusions - or should there be a way to control this somehow? After all, making estimates about frame sizes can reduce heap-allocations considerably.


#1 has some of these fixes BTW.


From an efficiency perspective, we should think about whether we want to batch requests to redis in some way.

For example, we can accumulate requests for 20ms and send a batch over. This would increase the latency a bit but may improve throughput considerably.


Yeah, I noticed that a bit later.  Sorry for the confusion :)

Pieter Van Gorp, Assistant Professor (UD)
    Information Systems Group, School of Industrial Engineering
    Eindhoven University of Technology (TU/e), The Netherlands
    Phone: +31 40 247 2062, Skype: pvgorp, Fax: +31 40 243 2612
    http://is.ieis.tue.nl/staff/pvgorp/

On Fri, Feb 10, 2017 at 10:22 AM, Stef Schenkelaars <
notifications@github.com> wrote:

> Same here, is already fixed in the master branch. You can even set it with
> an environment var
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/TUe-IS/GameBus-example-integration-Ruby/commit/a2ddfe55b8991fb91857e45ef8704d12d3eed70d#commitcomment-20830191>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ADR5MXYMRGXXheczY31iXoXgBXiO3owfks5rbCxPgaJpZM4L9FiV>
> .
>


Yes, it is. After https://github.com/nette/database/commit/644b587fc548a83899325bdb22b3ee299fe9995f this method is not needed.


Should be returning the error, not throwing a panic...


is Double or double preferable here?


If you have to deal with potentially large frames, you don't want to use
Framed and custom write something for the specific use case. Framed is
really just "easy mode" to get started implementing a transport and isn't
meant to handle all cases.

On Fri, Feb 10, 2017 at 9:32 AM Sebastian Thiel <notifications@github.com>
wrote:

> I do wonder if it's a good idea to never allow the buffer capacity to
> shrink while a connection is maintained. In the case of tokio-cassandra
> <https://github.com/nhellwig/tokio-cassandra>, the worst case is the
> server sends a frame sized at 256MB, but most frames will be significantly
> below that.
> Do you think this is an actual problem - maybe I am making the wrong
> conclusions - or should there be a way to control this somehow? After all,
> making estimates about frame sizes can reduce heap-allocations considerably.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/tokio-rs/tokio-core/commit/b84ef90a98fb010cd075700001ddd98288fce152#commitcomment-20837068>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAAYJNoAjGQuVE529CcyoKWRDDI9Ilbwks5rbJ9CgaJpZM4L9pMc>
> .
>


I was so slow the last few months because I was dreading updating for the upstream changes but after I updated things should go quickly from now on!


This needs to come from the aspect config, not from environment variables. So just make the fields in the config proto.


Shamelessly stolen from #1 but somehow my Git-foo missed the author tag


To be honest, I don't really know. I can try at some point. I know that the laser is projected diagonally on the ground so there must be a limit and the other readings might be errors. When I tried it last time, I got readings of around 3 meters.


No sube las fotos por acá mi mail es bollatialfredo@gmail.com, escribime por ahí y te paso si queres.

Saludos!


Yes, I know but does it really make sense to change the interface? What if in the future you decide to revert the  commit and will need `formatBool` again? Will you change the interface again?


@jglick fixed the author tag for you ;-)


This has a lot in common with Siconos_AsVal_int, no?


fantastic. thank you! looks like this also fixes #863?


On Fri, 2017-02-10 at 09:27 -0800, Hugo Posnic wrote:
> Now empty means DEFAULT

OK - then the function write_config_to_file must be modified to include
a check for only_country == available_countries

if not write the only_country list like

    Custom = country,country

else write

    # Customer =


I'm not familiar with the grsecurity infrastructure but I'm curious about why this didn't work - please let me know if I can help or if you figure out the issue here.


Yea it's pretty nasty, I'd like to avoid doing that because it's not guaranteed it work (see caveats in your link) and it just feels wrong having the library mess with an objects internals rather than the public API - it could lead to some nastiness.

My recommendation for now is to construct the object yourself and generate the constructor args using JFixture when you don't care about them, and manually for the ones you do care about.

I do want to release this for Java 8 and stop supporting Java 6/7, so that might afford us the opportunity to do proper constructor argument name resolution.


Uses Cordova InAppBrowser plugin to open up a browser within the app itself. The following command needs to be run in order for it to be used when developing.
```bash
cordova plugin add cordova-plugin-inappbrowser
```


@throws IllegalArgumentException if ref.getSheetName() is null.


On Fri, 2017-02-10 at 09:27 -0800, Hugo Posnic wrote:
> Now empty means DEFAULT

I think the check can be made earlier,
passing CUSTOM if OnlyCountry != available countries


Let's discuss this during the "reset" topic. My instinct is that it could be hard for debug module to know all this as-is, so I'm for leaning more towards the Human Debugger for understanding the state of the system they're debugging. They will have to know some platform specific thing to resolve the state anyway...


The second `case HERO_SPECIAL` won't be executed. Did you mean something else?


Nice catch! Patching!


I confess I'm not sure how to address your confusion, but I'll try.  Yes, results should be presented, typically in tabular form.  But, as we've discussed, the seeds here each designate different random runs.  Neither the seed in particular nor the individual run is scientifically meaningful, and so separating out the results by random seed is not coherent.  As stated in the original todo, these results should be presented by reporting the average and standard deviation across successful seeds.  By random success rate, I mean ``percentage of seeds for a run on which a patch was found.''  If that's always 100\%, then report 100\%..


oh no


On Fri, 2017-02-10 at 09:27 -0800, Hugo Posnic wrote:
> Now empty means DEFAULT

Like this

    # modify configuration to use default
    if self.config["only_country"] == self.available_countries:
        self.modify_config(DEFAULT)
    else:
        self.modify_config(CUSTOM)


I like this context! Clearly separates target and region.


update npm package if possible.


No, I mean to add a discussion of the heuristic generate and validate approaches that we do not consider, HDRepair in particular (...the subject of the todo).


OK.  But the motivation for making it is separate from the need to evaluate it.  Do you see why I think the evaluation would be stronger if it were also evaluated, or should we discuss it further?


related to #37


I glanced over the comments in the forum.

I remember an issue about pacman-mirrors moving Custom to /var/lib/pacman-mirrors and you commenting about 2 years gone since that change.

How come some still use it?


This is a temporary measure while google reviews our page. Improved pages are welcome to be re-added after the org selection process


Ah perhaps the placement of the todo was confusing, apologies.  The claim my todo is commenting on is that this is the largest dataset considered in previous work on program repair.  Is that claim true?  I understand how many commits/projects we're looking at, I'm asking if we're looking at more of them than other work.


Confused


hee


Very similar to the invite command code. Differences happening in naming and what happens if all checks passed.


Sure.  Include the default.


The unfinished part.


The section about submitting iOS apps to the App Store and IDFA usage was removed in this commit... does this mean the module no-longer uses IDFA?


@rwcarlsen sorry for the notification. This is from 3 years ago. I just moved the repository over to my arfc group repo (so that all future forks don't point to me, but rather point to my research group.). Github is just re-notifying everyone I ever mentioned in the commits.


Nic, yes, thanks! Did you find any other discrepancy between the usage message and the man page?


saw approval from jedmccaleb
at https://github.com/vogel/stellar-core/commit/e7ee8673f604c178fcc53a0e339f81fc4cd7c51a


merging vogel/stellar-core/fix-windows-build = e7ee8673 into auto


vogel/stellar-core/fix-windows-build = e7ee8673 merged ok, testing candidate = 7ac245db


Unfinished and Untested. (2-10-17 12:49)


Ah, I don't mean "evaluating quality" is a contribution, just in the part of the contributions where we mention evaluation of the new technique, include a half a sentence about the fact that we also evaluate quality on a held-out test suite.


Not necessary, will remove it.


sorry for multiple updates the formatting wouldn't fix


Yes, I'm also thinking about splitting it into a utility library. Will do it in the next round.


Of course if it's something you really need you can write your own customisation to do it, the JFixture API is super flexible so it'll let you do that and I'd be happy to help you out with it.


@anthonykulis
 fixed the width and length, as well as the array out of bound error
its working now, off course it will read files with x=wall, f=final, " "=clear


It looks like this commit is empty on GitHub. Is it actually empty?


大神好迅速


Fijate que aca estas dentro del "namespace" de "CircularList", osea dentro de
class CircularList {
   <aca, todavia no cerro la llave de arriba>
}

Cuando usamos el "::", es para refererinos a un namespace. Un namespace es cualquier cosa entre {}.

Ejemplo:

struct Test {
  int function(int x);
}; // cierro el namespace

// uso del "::"
int Test::function(int x) {
}


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.30.1-pre-2-gaa2ca4b](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=50307&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **FAILURE**
Summary: Snapshot dependency failed: ... Test Server Build time: 00:00:01


Because cgo isn't needed to build delve anymore.


Question: we tried the off-the-shelf fault localization, right?  Remind me what the results were?  If I remember correctly it was something like "same results, just took longer/was more noisy", right?


Reverting is really possible, I'd like to test this change long enough to decide whether leave it or revert it.


este erase esta afuera del namespace ListaElement.

Si lo que queres hacer es implementar el erase, lo correcto seria:

void ListaElement::erase(ListElement* element) {
  // codigo aqui.
}


There is not release of this repo, I know it is weird, but lyft is using it... I see it is forked from another [repo](https://github.com/fzzy/radix)  (which has 29 releases), will try with the original one.


Question: Why is this?  Is it because the mutation model favors deletion?


Done.


interesting, may this be bundled by something which wont understand the import syntax correctly?


(I ask because I fear I'm conflating the mutation model with the replacement model in my understanding.)


CompareTag is cheaper than .tag == "..."


Too many empty lines :)


Thanks Andrei!   Andreea now did try building Android with this change. And though it's theoretically possible to use a different library on Android to support this - it introduces major complications and requires some other changes and lots of testing on our side.  Can you please put on hold this enhancement until we investigate the full impact and find solutions? We will try doing this in 4.6 and will confirm if Ok to proceed. Thanks, and my apologies for not adding comments explaining why this deprecated method was still used in JSDK


maybe this could be an introduction to the syntax with context passed in - `yield call([fetched, fetched.json])`?


Do we have any patches that benefited from the replacement model, or the template selection model, rather than the statement-edit model?


overally this should be wrapped in `try/catch` block as it might failt and break your app


Store parent's animator in a field, so you don't have to call GetComponent every time it's needed


Moved the cheaper evaluation to the front


This is not a printf-like function, it is like a queue to store redis commands (i.e., 'INCRBY', 'DECRBY'), which will be executed sequentially. `PipeResponse()` in line 31 will get the result returned from redis.


¿Qué es precisión y qué es constante de desvío?


> but I don't see anything about the other comment.

The other comment is w.r.t. moving `runtime/include/rtmain.c`


Try "selective" as above...

2017-02-10 18:16 GMT+01:00 Pablo García Sánchez <notifications@github.com>:

> Addressing more @JJ comments(not all of them). Also, a name to use instead
> cooperative-coevolutive is still needed
>
> --
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub:
> https://github.com/geneura-papers/2016-HPCA-HPMOON/commit/
> 4a5233453b0ea1885f82df39e54b7a7b1f0f0293
>

--
JJ


ok. SHould I remove the results of the folds as well?


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.30.2](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=50317&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **SUCCESS**
Summary: Running Build time: 00:00:34


Great job! As this program is relatively small it's basically fine to keep everything as functions in one file. For anything much larger though, it'll start to get unwieldy, so I'd recommend splitting these functions out into a set of files containing groups of related functions. It's a good way of making sure your code has separated concerns too - so that UI functions don't do stuff that the data functions should be responsible for, and vice versa. You can also do this via classes and methods in separate files.

It looks like you're starting to get a feel for Python really well, though, and I can already see you've got the hang of some important parts of the language (the 'in' statement, list slicing, docstrings, keyword arguments, etc). Your code definitely feels like Python and not like PHP or JavaScript, which seems to be a common issue when people learn Python after learning other programming languages. Also great job with the regex you wrote!

A great exercise as I mentioned above in the code would be to replace some of the list constructions with list comprehensions. They're a really concise, clean and quick way of constructing lists based on a simple operation. I recommend you stick to an explicit loop for more complex list constructions though - just because you can write a 500-character-long list comprehension doesn't mean you should ;) so just exercise your judgment and if it's getting messy or hard to read then don't hesitate to write it out in full as a for loop. Simple is better than complex, after all 😄


You have to add it in README.md as well


Red line of code is deleted line of code, so code is:
case HERO_MANA:
case HERO_EXPERIENCE:
return 0;


This is turning into one of those "I've repeated myself several times" requests: please typeset language constructs differently from teh surrounding text.  \texttt works.


if buildbot?


(But don't touch this subsection yet, I'm working on it and we'll conflict)


Instead of assigning every Update call the getter when TakeDamage() is called


IMHO it's more logical to have 'Boolean' return type here


this is dumb


Can re remove the space differences?


TakeDamage() depends on the player object. Better design would be:


When I use es6 rather then typescript for angular project and import the detepicker, I got an error that was throwed `moment is not a function`.

I reviewed the file `ng2-bootstrap/src/datepicker/date-formatter.ts` in github whitch in node_module was `ng2-bootstrap/datepicker/date-formatter.js`.

```ts
import * as moment from 'moment';

export class DateFormatter {
  public format(date:Date, format:string):string {
    return moment(date.getTime()).format(format);
  }
}
```

At first, I thought the moment must be an object. Then I was confused it was called as a function in the code.

I try to compile it by babel. It looks like that:

```js
var _moment = require('moment');
var moment = _interopRequireWildcard(_moment);

function _interopRequireWildcard(obj) {
    if (obj && obj.__esModule) {
        return obj;
    } else {
        var newObj = {};
        if (obj != null) {
            for (var key in obj) {
                if (Object.prototype.hasOwnProperty.call(obj, key)) newObj[key] = obj[key];
            }
        }
        newObj.default = obj;
        return newObj;
    }
}

// ...
```

As we could see it should be an object. I was thinking the code maybe wrong. But my another project that use typescript is working while I use the same version.

Then I try to use tsc to compile it. It was compiled as:

```js
var moment = require('moment');

// ...
```

It's different! The moment could be anything the moment module export.

So I think it's better to compatible with typescript and babel:

```ts
// .ts
import * as _moment from 'moment';
const moment = (_moment as any).default || _moment;

// ...
```


CPU = 16MHz, you've set a /256 prescaler, yielding 62,500 Hz. I can believe that 65536 yields *~*0.5Hz :)


remove type?


Let me make sure I understand this patch: it's inserting this code above the old if statement right?  Do you have any sense as to why it leads the test cases to pass?

we should find a way to make the line numbering make sense so it's clear where it aligns with the other code sample.  I'll think about it.


Why not member? And I prefer names like 'merge' for such functions


std='/'


Remove all the other changes and leave the two lines adding that texture format to avoid running into problems with reviewers. Other than that, yes, it is a good fix.


Yes, I can believe that setting OCR1A to 62500 would give you exactly 0.5Hz, and half of that, 31250 would give exactly 1Hz, so plus or minus a bit of interrupt routine, 312 (.5) should give 100Hz, but I'll accept 311 as a valid answer.


FYI, I just pushed todos/questions/edits to this subsection; please address.


Ah, OK. Mike was trying to build the roslyn-ivt branch with a recent Mono build and was running into a csc error that looked like the mapping was not being performed.


Forgot to mention: `feature_server` is now `piqueserver`


URL to open when clicked


@kd-11 Thanks, but there's nothing else, I just keep cleaning the code useless, that's all.
Just to be cleaner.


You forgot in the test matrix too : https://github.com/Behat/Behat/blob/master/.travis.yml#L17-L18


Remove None option.


OK I'll rephrase the original todo more explicitly: Write a sentence that has the following form: "In this subsection, we evaluate X by doing Y."


Open URL in...


The same tab


The word "important", as with "well known", can sound self-satisfied.  You can/should typically just say "previous."


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.30.2-pre-2-g59b8d0d](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=50352&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **SUCCESS**
Summary: Running Build time: 00:00:58


New tab


Да, как-то я небрежно бросил взгляды на файлы. Стоило сделать это поаккуратней.
Вообще тут суть в том, что для тех, кто содержит внутри себя фильтры есть общий код. Конкретно здесь это можно было бы обобщить на вообще произвольные объекты. Просто есть разные активити, которые показывают массив элементов и позволяют его редактировать (добавлять/удалять/изменять).
В итоге я добавил тип как аргумент класса с общим кодом (генерик). 616eb7a8457d8eecd2e76e4a4aeed5895f6cd563


The phrase "real life" is colloquial/casual; try just "real" or "real-world".


Current text is right.


@kd-11 But you have best idea for Name commit and best Name PR ? ^^ i don't sur why name this ^^


Oh thats nice!


You've flopped a few numbers around, here, but yes, I would imagine that 31250/200 * 1.00273790935 = 156.67 ticks would give a 200Hz? sidereal signal.

We pull the prescaler, and we get 256x more resolution, but I see what you did here. Nice work!


- [ ] Add support for custom logo from LC code
- [ ] Settings groups
- [ ] Min-with/min-height
- [ ] Responsive settings for min-w/h, paddings, margins, align


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.30.2-pre-2-gb56d21a](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=50356&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **SUCCESS**
Summary: Running Build time: 00:00:44


@dydzio0614 Sorry, the contrast of my monitor is bad. You are right.


Note that x.x.x.postx is a valid [pep 440](https://www.python.org/dev/peps/pep-0440/#post-releases) version (and why I chose it)


001 is full clock, 100 is /256 prescaler, according to Table 16-5 from the datasheet, reproduced here: http://www.engblaze.com/microcontroller-tutorial-avr-and-arduino-timer-interrupts/ (in the section titled "Configuring and running the timer")


Seriously!  Awesome, can't wait to see this in action \m/.


http://gerrit.aicp-rom.com/#/c/33707/
Spirit is the man :D


Проблема с unsafe кастами состоит немного в другом, там вообще не принципиально, что это штуки, которые хранят фильтры.
Вообще согласен. Сейчас тот факт, что этот класс является базовым, выглядит странно.


Title is fine. As long as its easy to understand and the request is easy to review, you should have no problems getting it merged. Just remember to remove the unnecessary changes to avoid a repeat of last time.


can blow this away, too, just leave an empty loop() function, if we're not otherwise doing anything with it. Or, you could use the delay() to produce a 0.5Hz (solar) pulse on some pin or another (just toggle it in loop() )


Also tried a fix for trying to memoize floats as they lack a hash


single clock tick, baby :)


now its double forking each for no reason (i know that probably docs and tutorials are a little bit outdated and it teaches such constructs), its like an equivalent of:
```javascript
export default function* root() {
	yield [
		fork(function* rate() {
			yield fork(takeEverytHelper, 'RATE_ITEM_ASYNC', rateAsync)
		}),
		fork(function* comment() {
			yield fork(takeEverytHelper, 'COMMENT_ITEM_ASYNC', commentAsync)
		}),
	]
}
```
so this extra layer fork wrap could be avoided

however you could use `spawn` here, as its your root saga - so those 2 tasks become detached - acting like a root task. This has very important implication - if one fails (uncaught error) it wont affect the other one. So it becomes more safe in general if such sub-root tasks can act independently. Then it makes sense to have this one extra layer of task spawning/forking.

In such case there is 'an issue' with cancelling detached tasks, because they are acting like root one simple cancellation on the root wont cause them to cancel, as they are acting in parallel.

Although you do not need probably to cancel your root tasks, as you most likely want to have them active for the life-time of your app. Its might be still good to show the complex solution here. Something like
```javascript
export default function* root() {
	let tasks

	try {
		tasks = yield [
			fork(rate),
			fork(comment),
		]
	} finally {
		if (yield cancelled()) {
			// in future release (v0.15)
			// it will be possible to cancel multiple tasks
			// with yield cancel(...tasks)
			// but for now we need to do it like this
			yield tasks.map(t => cancel(t))
		}
	}
}
```


No, because the results in that section can be aggregated over the folds by summing them, and because variance is explicitly meaningful there, though this is related to the reason I asked for a table rather than a bar graph for the folds.


deleting


Thanks for the cleanup. It needed it. I had all the #ifdef and commented junk in here so that I could remember, 2 years from now, what the heck all the registers and stuff are. But the code is much more "on point" without the extra junk.


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.30.2-pre-19-g583fb0b](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=50360&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **SUCCESS**
Summary: Running Build time: 00:01:05


Stylistically, I prefer "We", since "The authors" is a bit confusing and needlessly third-person.


2 bugs to fix :
1) dans la sidebar la grid sélectionnée se met en couleur (background en rouge) mais quand je change de grid ca met la nouvelle en couleur mais ca laisse l'ancienne aussi en couleur (ce qui faut pas)
2) parfois après un save puis un reload, la mise en page fait n'importe quoi


Why did you remove React Native config?


Shouldn't it already be the default export?


yes, feel free to contribute to the repo, do not hesitate to submit pull requests


while `takeEvery` is rly easy and helpful with API requests there is always a chance that the responses might come not in order, so that should be handled here I think somehow


In python 2.x byte arrays are contained in strings, while in 3.x they are of type bytes.
`data` here is the byte array of the geobuf protobuf.

This is about marshaling data from the string/bytes into a geobuf instance. Nothing to do with JSON at this point.


Uh, I know.  The question asks what *they* cite as related work to their studies, in their papers?


@kd-11 There is no unnecessary modification to it, just a really small code cleanup that is useless, but I see what you're talking about, except that I've already almost everything removed (The Unknown).
I do this just so that it is clearer and cleaner, that's all, I do not see or is the problem: /, it should make sense.
All that remains is the change necessary for me, it seems to me just logical.
Removed from forgetting to make it cleaner, that's all ^^.


Yeah I'll try removing the prescalar and get that going tonight. I'm silly and forgot 0000-FFFF should actually be happening 16 mil / FFFF times a second (244) instead of once per second 😛

Definitely more destructive than I needed to be, just trying to look only at 1-2 numbers to figure out how the arduino timers work, but makes sense now.


This is a common pattern. There are some different approaches within the community depending on if you need any restart logic (restart on async failure, etc). For example, if one of these sagas throws an error that isn't handled and bubbles up to this root saga, all of the sagas started within it will die. So you have to either handle all errors before they get here, or use `spawn` so that the sagas started here don't die when any of them have an error. And it's also possible to do some restart logic for async errors, though it involves some hackiness.


Double, so we can check for null.  Working on other comment edits, thanks for the review.


Added information about meeting with the TA on 10/01/2017


I would prefer to destruct like `const { id, rating } = action.payload` but that's just a personal preference


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.30.2-pre-2-gf6d8e6f](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=50364&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **SUCCESS**
Summary: Running Build time: 00:00:47


@hanwen do you have any update on this? We would like to use the latest version if possible, but are stuck using commit 6fb066875c8002ccd49dbd9a16b522711cb8f59d .


EMS (brianlball) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


Is there any way to get higher freequencyes than 620mhz without the device rebooting?


What are the units on the columns?  Please add to the table (possibly a row between equallydist/probablistic row).


Do you offer a disconnect method? I see you commented it out, is there a reason for it?


> Also, I want to link to other awesome lists that cover topics that this list doesn't cover, such as generators, themes, showcases, etc.

Wait, but then, where is the awesome list that does enumerate hosting, generators, themes, showcases.  To me, these components are incredibly important to curate.

Please reconsider, or, link to a collection of out-of-scope resources.  I'm happy to host that list if need be.


I think you're using color to distinguish them, but bear in mind that many people read papers printed in black and white (as I am currently doing) where the distinctions don't show up.  So: always label things explicitly, and/or use colors whose distinction is visible in grayscale.


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.30.2-pre-3-gd19f3c2](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=50372&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **SUCCESS**
Summary: Running Build time: 00:00:41


Thanks a lot! That's good to know. So I suppose we will start with that, and at some point just make our own once we know what we are doing :)!


bardziej optymalnie jest użyć takiego selektora `$('.nextLink','#carousel-outer')`
Zmienne w JS nazywamy camelCase, klasy/id w html i css zawsze odzielone `-` np. `.next-link`


That's good to know, I learned something new. :)
Right now, I'm only using ``LIGHT``, so it should be fine. I'll probably remove the DOUBLE.

The idea of the ``widgets`` module is not to have a super comprehensive UI library with all possibilities. But instead, more a small collection of useful stuff that can be used in the ``shortcuts`` module for simple dialogs. The idea remains that a more extensive UI toolkit can be build on top of prompt_toolkit. I'm still not sure how much functionality should remain inside. Before merging this branch, I'll probably do a selection of what to keep and what to move outside of prompt_toolkit.

If you think of anything, all ideas/feedback is welcome.


Usually there is a lot to Config so it warrants its own file in many cases. You can move all the code and see how much of it there is. Grouping types with their factory functions and methods can usually solve that problem as well.


wcięcie


it should've been `.opt_bin`, right?


To make this example really robust, you could extract the logic that calls `fetch` into its own helper saga. Within that saga you could have error handling via try/catch, and throw on 4xx and 5xx HTTP responses, maybe special handling for 401 response etc.


`self` is not needed here


`self` is not needed here too


@rsto, please see my pull request #1833


@Byron this sounds like a reasonable change to me, though. The intention was that this always reallocated a new buffer of the *original* capacity, but I think that logic has since been lost as this can grow.

If you'd like to send a PR to fix that up it'd be most welcome!


nie masz data-choice, więc parametr do funkcji playerPick będzie pusty


Can we add a sentence after this list that explains the meaning of just the first one in English, to help the reader parse?  These read to me as three-edit rules.  Am I reading them right?


Note that the remapping works only for explicit debug arguments, if you use simple -debug it does not. Which is bad but don't think we can get that in RC5


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/200432171


Please expand the caption to explain what's going on in a bit more detail, and address the fact that the second sentence is a fragment/incomplete.


Suggestion for the beginning of third sentence.  It currently reads, "Said that,  ".  Would recommend rephrasing as either "That said,  " or "That being said,  "


Thank's, I'll do that.
> How come some still use it?

Because the wiki is outdated.


nie kopiuj z Kodill, bo ci będzie rzucać błędami :)
zamień cudzysłowy


to jest niepotrzebne tutaj


test line comment


Here is a quick search. I think the only thing really missing from these lists is Static Hosts. If you would like to create that list, that would be fine.

https://github.com/planetjekyll/awesome-jekyll
https://github.com/planetjekyll/awesome-jekyll-editors
https://github.com/planetjekyll/awesome-jekyll-plugins
https://github.com/planetjekyll/awesome-jekyll-themes
https://github.com/myles/awesome-static-generators
https://github.com/statictimes/awesome-static
https://github.com/BubuAnabelas/awesome-markdown
https://github.com/mundimark/awesome-markdown


@axic: Where did this go? What shall we use for GPU mining now?


No, Michael the TA added 5 to the starting coordinate of AircraftCarrier to its total length was 6.
1,2,3,4,5,6
when he should have added only 4
1,2,3,4,5


fast-forwarding master to auto = 7ac245db


EMS (brianlball) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


This commit has been deployed to DEV


if we had concrete advice for what to do on mobile that would be awesome.  not sure what to do other than say "mobile is hard"?


ping @philipbelesky not sure if you never ended up pushing this, or if you did something different?


Hi Bjorn,

I'm working with branch i2c_slave trying to communicate an Arduino as master and the ESP8266 as slave.

I writing to ask you if I2C pins are still the same D1&D2, because I can't get it work. Or if the code needs a different approach than the example of Wire library.

Thank you very much for your time,

Regards,
Alejandro


I actually kind of liked this "feature"...


@zachmullen Nice minimal change :+1:


Why are you using libunwind in ompt? I think that the GNU primitives will be enough to get the return address and frame pointer of the caller. We don't want to add a dependence to a third-party unwinding library inside the OpenMP runtime.


This commit has been deployed to TEST


Warning to anybody who has cloned/forked this repo: I just used BFG to rewrite the git history and remove this binary file from git completely.


Add EnderChest to master? #142


Fantastic


EMS (brianlball) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png)


Thanks !


Do I understand you correctly that all these changes mostly affect `pkg/security/admission/admission.go`?


abb doesnt needs jmptable option to improve the bb finding because the algorithm works different. and this option cant be enabled by default because it produces many false positves

> On 07 Feb 2017, at 04:01, Nguyen Anh Quynh <notifications@github.com> wrote:
>
> nice one! at the same time, we should turn on jmptable parsing to discover more BBs, right?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub <https://github.com/radare/radare2/commit/57692834ebf9d503e027c41bda3f39c716ebc1cd#commitcomment-20775273>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3-lv-f9uRtGqhV9wwLBTUAqA-eeAjwks5rZ95sgaJpZM4L4_tR>.
>


ok


It's here: 157229535db6c6ade1479ebb1acda40f3c743390. It works for me. Could you test it too? If everything is fine, I'll release a v3.2.1.


Use onValueChange in NumericInput sample code (#667)

Preview: docs
Coverage: core | datetime


No problem, I'll revert it. I'm working on a way to cache the getActorsSidingWith which should help performance. Currently, when you have 3 or more followers you can clearly see the framerate dip every second as the target lists are updated. That was already the case before your PR I think, but looking at the code reminded me.

If you have some time: there's a "class has no CreatureStats" exception when activating a trap. Not sure when this was introduced but it has to be recent. Apparently onHit() / actorAttacked() are being called with attacker being a non-actor (the trap).


Done.


Hopefully this will help you.

2.3.0 :020 > class Array
2.3.0 :021?>   def baboon
2.3.0 :022?>     length
2.3.0 :023?>     end
2.3.0 :024?>   end
 => :baboon
2.3.0 :025 > [1, 2].baboon
 => 2


Sorry my previous comment was totally off the mark, I missed the fact this was for decoding, not encoding !

In that case six.binary_type would be the right choice, instead of six.string_types.


We still have all the other numbers in history, if we need them back.

 I agree that a cleaner sketch makes it easier to understand :)


If you look at the documentation of __builtin_frame/return_address() they state that calling this function with any argument!=0 is unsafe.

One reason is the optimization -fomit-frame-pointer, which allows the compiler to use the register that usually stores the frame pointer. The built-in functions rely on this register.

If an application is built with optimization, we get nullpointer or crashes for calls with level>0. But according to the OMPT spec we need this level.

Libunwind was one approach of implementing the it in a way that is robust to any optimization.

Also, the use of the built-in functions prevents the omit-frame-pointer optimization for the runtime library, which means a significant optimization penalty, because we loose this register.


@jdubois did you block that guy? how come this commit shows up in our  repo


Nice ! Thanks for this :)


Working on it.


It's fine, implementing it with InsertBefore/After has the usual problems with what if it's called again. For replace though, calling replace another time should throw an error, as should calling replace-after-remove.


It's fine for now :) Let's see what the customers say before we do more design tweaking.


On Fri, 2017-02-10 at 10:43 -0800, Hugo Posnic wrote:
> It's here: 1572295. It works for me. Could you test it too? If
> everything is fine, I'll release a v3.2.1.

You are spot-on

And the formatting of messages - also spot-on - it has annoyed me that
I made such bad formatting - thanks for improving them :)


WTF???


no pondrias el build en la seccion compile??

```
...
compile:
  override:
    - yarn run build
deployment:
...
```


Reminder: we have to clean up the commit messages before merging into master.


I checked master its not there probably its some kind of orphan commit tree


primero creamos los routers de las 3 redes y los ponemos en version 2
creamos una red con dos ordenadores con dhcp, a los cuales le creamos un servidor
DHCP con la ip 192.168.1.5(tambien sera el servidor DNS) y que las ips de los ordenadores
dhcp empiecen a partir de la 10 a los routers les he asignado la 1  a los servidores la 5
creamos un punto de acceso wifi y cojemos dos ordenadores y los configuramos con ips
estaticas y con antena wifi para que puedan conectarse
en la segunda red le asignamos la 2.1  en la cual esta el servidor web creado y y dos ordenadores
con ips fijas, el servidor web tiene puesta su propia ip  y la direccion ip del servidor dns para que tenga acceso
y luego he creado las 2 subredes del ejercicio 1 una con 4 host y otra con 20


Yes it also not on the website.
I don't understand what this is, but as they guy was a scam, I'm really worried here.


Github should have proper security in place I hope


EMS (brianlball) - Win64-Windows-7-VisualStudio-12: OK (2161 of 2201 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.18%25-yellow.png)


Actually, for the return address we use backtrace() which is another GNU extension.
But for the frame address we didn't find a better way then libunwind. And the OMPT spec requires a level>1 if the KMP interface should not change.


[docs] enlarge code font size in props tables (#660)

Preview: docs
Coverage: core | datetime


Can `{$email}` be put in quotes?


develop (macumber) - i386-Windows-7-VisualStudio-12: Tests Failed (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


Seems like he is the founder of the company(Jammatto) in question https://angel.co/jimme-jardine not sure what he was trying to do


Thank you very much for you help. ;)


If I recall correctly, we set this value due to pepper's lense distortion. I believe that I had only up to 1.5m reliable laser scans.
But nevertheless, I think it's a good idea to expose values as these via ros parameters.


Done.


Good job! I think that a function name ST_AsMbTiles would be more intuitive.


Yeah, we are looking at more than any of the other approaches before. The only one close was HDRepair, with 3000 bug fixes, but they remove all bug fixes with more than 2 lines changed. And we do count all those.


Oh thank god yes


Oh, ouch. That means a LOT of projects will be broken.


I would advise you to upgrade to the latest version. Reading streams in that version requires less memory.


aka i liked the previous one


Other people just did like 6 projects (Su), 14 projects (martinez), etc


Assert message says castTo; should be getData?


@estenberg is this not already encoded into the MPF policy?


Ignore!


![](https://github.trello.services/images/mini-trello-icon.png) [@return s popiskem není zbytečný](https://trello.com/c/Hs4az3wj/61-return-a-property-var-s-popiskem-neni-zbytecny)


Indent ignored?


Addresses #34


What about the led_strip pin on J1 as designed? Why pin 5?


addresses #34


I don't see an implementation for this method in Syntax.cpp.  Am I missing it?  I assume it's just wrapping `Data->getParent()`.


Similarly, missing implementation?


We don't need `html`, `head` or `body` tags for this template because they're already in `magazine/base.html`, which this template extends from.

You only need to include `<div class="containerBox">`


That's right - there's no implementation for this yet. I'm using the tests to drive implementations for this patch. There are still a few to do, namely getters in general. Also TODO are adding unit tests for root packaging and maintaining downward strong references. I should have time today to include those in this branch.


Go to file GoogleImagesSearchForm.cs
There you in line 61 you have:
`List<String> images_urls = t.SearchForImages (this._editImageText.Text.Trim());`
It's basically a list of urls to all images, which have been found by my query.
Then I'm simply showing the first image (which can be accessed) from the list:
```
foreach (String image_url in images_urls) {
   Bitmap bitmap = ImageUtil.LoadPicture(image_url);
   if (bitmap != null) { //sometimes the server refuses getting the image directly
      Image image = ImageUtil.ResizeImage(bitmap, pictureBox1, true);
      pictureBox1.Image = image;
      if (bitmap != null) bitmap.Dispose();
      break; //show only one image
   }
}
```
If you need to show more pictures you just need to created more System.Windows.Forms.PictureBox objects and place them on your Form.
Have fun ;)


No, the tool throws up if you try that. `<<<` and beyond is stdin, so the tool is reading it like a file, it doesn't get interpreted like a command until EOL.


sure, `ax.isValidRange` or something?


@amelluk Hardware fault. Timer and DMA conflict


It was working at the time of the merge into upstream branch. Don't know if it works now though.


Does this mean we store a strong reference to each `SyntaxData` key? Can we have a strong reference to the tree and unowned references to the Data in the map instead?


This commit has been deployed to DEV


:+1: That's exactly what I'm thinking.


Can move these styles to this file?

https://github.com/ubyssey/ubyssey-dispatch-theme/blob/magazine/ubyssey/static/src/styles/magazine.scss


This commit has been deployed to TEST


![](https://github.trello.services/images/mini-trello-icon.png) [Implementar multiple bases de base de datos](https://trello.com/c/L0biMw3W/7-implementar-multiple-bases-de-base-de-datos)


URL = Domo


plz don't mention me


Geo-fences are lost during Android phone reboot #395


Thanks a lot for this!


Yes, changed it to return `(Connection, err)`.


Done.


Do not call getDragCaption() two times per component. Implementation of DragCaptionProvider can perform heavy computations in getDragCaption()


Where do I get the generation count information?


поправил щиты
начал делать icetacle


Rabi pls this is php not java. Scalars are lowercase

it should be `string $paypal`


Use Resource instead of ResourceReference


Hello nehon,

as far as i can see you lose the lightMapColor in albedo with your change. You should recheck your commit.

best regards,
Sascha


It turns out that including this on header file causes this check to start failing on Alpine Linux, because it doesn't exist.


Do not add resources directly to state, use setResource of main component


Let's make sure that we update this to use a variable to define the waterwheel speed rather than passing in a hard-coded 1.


Where do we remove obsolete resources? Now we have memory leak on each response from server


Use getters/setters instead of field access


Best. Commit Message. Ever.


@emilsjolander Can these values be animated with Animated? :O


I think we shoud store link to root Connector here in field


Obtain Document once


It takes much longer and finds a patch less often (lower success rate)


Too much dots and braces per line


Rename to VDragCaptionProvider


You need to have a call to: `self.make_base_plot()` here.


Rename to VHasDragCaptionProvider


Just the beginning of the process


Unnecessary method in contract


Remove this ugly headers


mhhh ok will check

Thanks


You can't call a MapFigure method on `ax` because it's a matplotlib object.

Instead: `self.add_ticks_to_axis()` (you don't need to pass self when calling it)


Got it, thanks, and I'm thinking about if there are more items needed in `poolImpl`.


Double underscores here (typo)?


This repo no longer exists - it's just a readme showing people where to go instead.  You'd be better off removing it from the list of next apps


@radical can we work around this in the targets until then?

    <DebugType Condition="'$(DebugSymbols)'=='True' And '$(OS)' != 'Windows_NT'">portable</DebugType>


@jesseschalken See https://3v4l.org/JYIQs. Without the `unset($this->parser);` the script leaks memory as of PHP 7.0.0, even though `xml_parser_free()` is called. This script is based on example #1 given on [xml_set_objects() man page](http://php.net/manual/en/function.xml-set-object.php#refsect1-function.xml-set-object-examples), so I deem it useful to document that behavioral change. Indeed, the note in UPGRADING is overly general – suggestions for improvement are welcome. Perhaps the following would be sufficient:
> xml_set_object() now may require to manually unset […]


не стоит указывать display:none для всех span (это касается вообще всех тегов, которых на странице может  быть больше одного), используй болле точные селекторы


I didn't add this code, but my PhrasesActivity works fine. I'm wondering why, and looking for the difference... *digs herself into code*


I'm aware about all of this kde porting work. I just don't understand the reason to use tool which would be soon removed. And I don't understand why not to use standart cmake scripting. Or are there other plasma5 plasmoids which use kde4-config?


Manish documented all options and defaults on the wiki.  You also know the code.  Go look at it.


But how many commits in Martinez and Su?


This commit broke gina.vim on Windows...

https://ci.appveyor.com/project/lambdalisue/gina-vim/branch/master


Хорошо, но не отображается главная страница по умолчанию.


@philipbelesky I've just directed everyone to the same install page, since those instructions might change and this seems the most generic link.


We do have others, but this is the most obvious "decent looking vs garbage" I found


Maybe it should say this:

"There is at least one file on the file system that does not support advanced overwriting."


json loader goes in webpack 2 by default, we can skip this


Sorry I wasn't aware of this (my fault, I see now that it is written in the wiki).


Shouldn't need to specify `col`


@philipbelesky: This isn't really ideal, but I'm guessing any other catch would require something more involved (_i.e._ detecting which institutions are present), and probably isn't worth it? I put in a critical logger below, so we'll have some idea of if it ever happens.


lo que se me ocurre es que al menos te aseguras un poco mas que estan todas juntas y no desperdigadas por el archivo, pero solo era una sugerencia, va en gustos


ok, let me know when you are done


Should be
```rust
!materialized && self.key_column.is_some()
```


Master branch: new commits are available.


yeah, that's why


ok


Stimmt die logic? Wenn der cotent-type in der map ist, dann ist es kein bild?


`assert_eq!(rows.len(), 1);`


Fixes #5


`Some((n, self.key_column.unwrap())).into_iter().collect()`


I am assuming this would mean changing the data everytime the user changes a season?
Right now we have to use timechart.plot(new_data) to show new data related to the selected season for redrawing. Moving this functionality to constructor would mean either changing timechart.data directly or adding another function for that. Both would still mea. Since, the *change of data* is getting used only in `plot`, I believe keeping plot associated with data is good since other options don't ease up the user interface.


This one is actually good, I'd keep it.


methode muss bleiben wg bc , oder?


It looks like this method failed when it returned the "result" variable, but in this other "patch" it assigns new values to some global variables that aren't being used at the moment, so as long as it doesn't return the results variable, it will pass the tests


getting there, @Chrysostomus :smile:

![](http://imgur.com/oXKtbDA.png)


Bc


Next on the agenda (not in this branch): remove sleeps from stream tests.


Color can be changed or it can't be changed either or it is fine


Kult


переходы по ссылкам реализуются очень просто. Разместим все наши блоки внутри элемента с id="content" и всем нашим блокам назначим класс .content-item. Элемент, который будет отображаться по умолчанию, располагаем в html последним. Тогда стили будут такие:

```css
#content .content-item {
    display: none;
}

#content .content-item:target {
    display: block;
}

#content .content-item:last-child {
    display: block;
}

#content .content-item:target ~ .content-item {
    display: none;
}
```


Tijs, these changes backed out the Zulu time changes I made a few commits back. It appears I will be able to use a function to format the datetime strings in most cases but I don't see how that will help with the TimerUtil.prepareRepeat() case. This is used in repeats with R/<duration>.  There is no expression so the type converter does not come into play.  With your changes, I am no longer seeing the R/-start-date-string/<duration> repeat value returned in Zulu time.   Instead it is being returned with an offset from UTC.  We need the repeat string to be consistent no matter what format, where datetime Strings are in Zulu time.  By not persisting in Zulu time are we not violating rule 3 here, http://apiux.com/2013/03/20/5-laws-api-dates-and-times/
How can we ensure that the R/<duration> repeat string returned is in Zulu format?


Typo?


Given your considerable efforts, it's probably worth incrementing this a bit, and also adding your name on the copyrights...


`canCastleRight()` and `canCastleRight()` only check if the squared are empty, it should also check it the piece on the corner is a rook is valid for castling.


Are you planning on submitting a PR for me to merge?  If so, I can take care of that sort of book-keeping for you when you do.


Let your vagina burn


I forgot to get 2 reviewers


check if it is on the last row and trigger a side effect.


Also, Admin can add Destination Points.
->Destination IDs are auto generated.
->User has to enter Destination Location.
->Clicking Add button will add Destination ID and Locations to the Destination Table.


This causes the whole library to be broken unless you have the imagick extention.


Add some examples... 希ちゃんは可愛いいいい！


Hi, there's a clock instance defined in the process engine configuration which you can override with your own clock instance. By default, the clock instance uses the timezone of the JVM. But you can override the clock instance to use the Zulu time when needed. Does that solve your problem?


https://developer.mozilla.org/ru/docs/Web/API/FormData/get

> Safari
> No support


With Whom to discuss


```rust
Some((n, self.key_column.unwrap())).into_iter().collect()
[(n, self.key_column.unwrap())].iter().cloned().collect()
```


Return promises from each module, not from ECore. It should looks like this: Promise.all(['EConfigurator.init', 'EMiddlewares.init', 'etc...']);
However, you make a good job, keep this way, keep rockin!


Don't we lose some important conceptual clarity by moving from the higher-level mathematical framing of `degree` to the lower-level "physical" framing of `bytes`?


@danielbachhuber I recommend you to see https://github.com/szepeviktor/wordpress-plugin-construction/blob/master/shared-hosting-aid/wp-downloader/wp-downloader.php


Merge pull request #52 from palantir/bd/textshear-2

Preview: docs | dev


@mstreuhofer I'm fixing some more stuff as well... if you like I can push my branch to kvz/bash3boilerplate:fix-lint so that we can collaborate better... or I can rebase ontop of your changes then pull everything in with one PR... just let me know when you're done and what you would like to do.


Короче, с FormData-хаком все постится. Чому без него не постится, и в чем проблема при использовании "отправки одинаковых картинок" - лень разбираться.


dfgfdg


See PR #5339.


Fix readonly & disabled styles for inputs (#652)

Preview: docs
Coverage: core | datetime


i'm done in this PR.
if everybody agrees to the changes you can rebase your branch on mine and just merge yours after. this PR could then be closed.


Speed up tooltips by default (#640)

Preview: docs
Coverage: core | datetime


Added New UI Icons (#665)

Preview: docs
Coverage: core | datetime


I am using rev 124 of Fluxion. Now, when I use it Google doesn't let the page served by Fluxion to appear. In essence, Google blocks Fluion from serving the wi-fi login page and the client, though connected to the Fake AP cannot access the login page. This happened after a "Create a SSL Certificate" option came in Fluxion. Used to work flawlessly before. Does Google recognize the certificate to be incorrect? or fake?. The Google page clearly states "Your connection is not private and hackers are trying to steal your passwords". So, it has made Fluxion useless. I am new ..I don't know if I have posted this at the right place. Please help.


You're modifying this, but everywhere it's called you replace with `opt_security % 8 != 0 || opt_security < 8` instead.  Can you help me follow your logic here?


Хорошо, но можно немного упростить css-код для переключения по ссылкам. Можно всем этим блокам дать один и тот же класс, тогда в стилях не придётся их перечислять по id.


On Fri, 2017-02-10 at 10:55 -0800, Hugo Posnic wrote:
> Thank you very much for you help. ;)

You're welcome


Oh this has hit my sweet spot, Imagine my sisters n I sitten in a circle intensely playing with our FreeNAS minis as we cry out with joy because we are able to quickly spin up and manage several little baby VMs with ease.


What's a canonical way to indent this?


Hi, open an "Issue" for this, please.


I'd avoid the `try`/`except`: if the `http(s)_proxy` variable is set it should be mandatory, I don't think that falling back to a direct connection would be acceptable to someone who explicitly set the environment variable.


`"Can't allocate memory"`


ok..I will try..I don't know how though.


Same grammatical error as above.


The time zone problem was a bug on navitia https://github.com/CanalTP/navitia/issues/1968. Next week navitia will release a new version with the correction :smiley:


Initial


@szepeviktor Mine is less code :)


Are you removing the calls for the sake of performance?  Wouldn't clarity of intent be more valuable in the long run than such a slight optimization?


чтобы пратался первый элемент, нужно изменить порядок элементов в html, и потом воспользоваться селектором в котором будет ~


I am not sure that comparing against `origin/master` is a good idea - that part seems fragile to me.


Makes sense to me. The only weirdness I can imagine is if rack ever gives you string-like objects that don't inherit from String. Seems unlikely though.


Is your goal the elimination of `gmp` as a dependency?  Is this for reasons of avoiding complexity for down-stream consumers of the `libssss`?


It didn't work for me when it didn't have it.


Woho! Great that you found that one and that it got fixed so quickly.


I think I'd prefer an `expect` with a message here. We will almost certainly run into the case where we forget to set the key for a `Base`, and then try to delete, and it'd be nice to get a decent error reminding us of what we did wrong.


Also:
```rust
vec!((n, self.key_column.unwrap())).into_iter().collect()
```


Why the sudden switch to tabs?


FWIW, there's an [RFC](https://github.com/rust-lang/rfcs/issues/542) on providing a `vec!`-like macro for `HashMap`, but it hasn't seen any progress in a while.


Breaking python 2.x, for example in https://travis-ci.org/rg3/youtube-dl/jobs/200397132:
```
Failure: SyntaxError (Non-ASCII character '\xc3' in file /home/travis/build/rg3/youtube-dl/youtube_dl/extractor/facebook.py on line 159, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details (facebook.py, line 159)) ... ERROR
```


Explication du projet


@ktdreyer agreed. i will revisit your approach next week.


Нужно использовать не :active, а :target. Но этого будет ещё не достаточно.
А чтобы иконки были ссылками, их нужно расположить внутри тега <a>.


I have the same demand。
How to make "Scope global" replacement for  "Scope local"?

`func makeDhcpDsConfig() *discoverapi.DatastoreConfigData {
        dsConfig := &discoverapi.DatastoreConfigData{
                Scope:    "**local**",
                Provider: "boltdb",
                Address:  defaultPrefix + "/local-kv.db",
                Config: &store.Config{
                        Bucket: "libnetwork",
                },
        }

        return dsConfig
}`


Damn thought I tested this part. Pr?


Yes, that's why I put the todo here.


Sure!


Consistency between the two lines. Either you use this everywhere, either you don't


** redemo:次modul为RecyclerView分割线等


En el método getNombreNum, "Az" se escribe "As" (con s) y recomendaría cambiar "Quina" por "Reina"


Minor style thing; could you remove the line breaks in the middle of the code?


ok


What about preconditions on text extractor, zoneId...
Don't you check message is not null?


@tombentley this makes the build fail on the CI server (and "wip" as a commit message? was this supposed to get merged?)


It will be good to have comments in this file on the purpose of a function as well as any line/snippet of code which needs further elaboration for others to understand, add any new feature in future.
On a side note, it would be great if a readme file is added with detail as per standard practice.
Something similar to this but not exactly: https://gist.github.com/jxson/1784669
Thank you,


In some cases, it failed, not failed-somthing, user deletes it right after it became failed, then the delete msg get lost by chunter_vm_fsm (unhandled msg after been terminated).

Can I change it from <<"failed-">> to <<"failed">>?


３行目を追加しました


没有联系。在一些有快捷键冲突的网站会默认禁用 nextpage add-on 的快捷键。


:+1: approoved


测试pr


测试成功


One question; adding those commits to frb worked? Or it needs more work to add DUI? @TeamViperOS


Yeah that one was probably a dict key originally or something and I forgot to change it.


I haven't redone the ISS part that translates these objects into DB models, so I can change it. Just requires some more logic on that side than it would this way.


![](https://github.trello.services/images/mini-trello-icon.png) [Reunirse con Andre Muñoz Zamora](https://trello.com/c/ApAMnIpa/1-reunirse-con-andre-munoz-zamora)


Nice copy and paste 👍


@jhuckabee
Could you please publish v0.0.6 to rubygems.org?


Ye boi!


typo


Nice Commit


my pleasure


resolve #3


@CraigHoneyfieldIS , really? I was able to manually test with success, as well as all acceptance tests passing