Casting away constness is not considered good programming style when there is no guarantee or control what can be done with the pointer.
Maybe you should not declare `src_frame` as a pointer to `const` in the first place?


Ah, yes, that makes perfect sense - do you want me to factor out the ConceptServer stuff (and probably the alignment stuff as well) to a Plugin? Probably wouldn't be too bad an idea anyway... not sure if that should be in the core...

Similarly, making a FancyREPL plugin is probably a good idea as well (@tkw1536)?


The caller already did this. Do not duplicate work, but take the `fil_space_t*` as a parameter.


Change the order then? ;)


Citation needed


Yes. CocneptServer is anyway close to being a separate applicataion.

Not sure if the REPL can be plugin-alized. It's probably possible to refactor the Shell class in such a way that the method used for the prompt can overridden by a class from a plugin.
Users who want to use the fancy shell then have to run a different main class, but that's OK, I suppose.


1. Are you sure about this naming convention? At this moment we base on MFBeforeRunTask with extends  BeforeRunTask and "Mainframer Make" is used only for better readability for end user. Changing naming conventions should be in another task.
2. Agreed, probably it will be splitted to two methods. Also class name is not exactly correct.


YARDIM EDEBİLİRSİNİZ


Looks Cool


This should take `const fil_space_t*` as a parameter instead of `crypt_data` and should obviously debug-assert that the `page_size` corresponds to `space->flags`.


We do not need a wrapper function.


The caller should do proper error handling for this case. We should get `fil_space_t*` as a parameter.


No, no, no ... read the commit message

> Since SSLv2 is outdated and insecure it is not linked
> into common ssl distros. So I droped SSLv2 support
> from M2Crypto.

This is what I and other try to advise you: about security reasons the SSLv2 is simply no longer linked into libssl ... in most distros today ... and that is why so often a installation fails with::

`_m2crypto.so: undefined symbol: SSLv2method`


The importlib in 32-bit was missing symbols for some reason.


`crypt_data` is modified here, and it should be declared `@param[in,out]`


No, I don't even use this lib.

I was just unsure about the status of this project, as the badge was removed, but the notice a bit below on L11 still states that the project is looking for maintainers, and issue #412 is still open.


Hi, Ade,

You are close to being done.  You just have a few more steps to complete:

1. In the __init__ method of View, you have to do two instructions:
 a. You need to create at least one turtle to show the display old messages on the screen.  You actually create this turtle somewhere else - in display_msg - but that's not what you want to do.  The reason is that you'll end up making new turtles every time you want to call the display_msg function (which is often).
 b. You need make an instance of the TextBox class and save it to an instance variable.  (That's the other part of the instruction that says, "#Create a TextBox instance and a SendButton instance and store them inside of this instance.")

2. You got started on the msg_received method, but you need to complete it.  You have the right idea to append something to the msg_queue list, but you have to figure out what to append.  The thing you want to append is the string that holds the message you received.

You need one more step in this function: you need to update the display, just like you did in send_msg.

Also, looking at send_msg - you used the "insert" method there to add something to your list, whereas you look like you are going to use append in msg_received.  Both will work, but you should use either one or the other in both places.

3. Your display_msg method has some bugs in it.  I mentioned the first one before (where to create the turtle, which you have named "ade").  Also, display_msg is similar to write_msg in that you are using a turtle to write text.  Make sure that display_msg has all of the important steps that write_msg has to make this work (you are missing one).  Lastly, what are you trying to accomplish on this line
self.ade.write=writer
?
Ask yourself: what is "write" - how do I use it?  If the answer is not "a function that belongs to turtles which I am using to write things to the screen," then you should study how write_msg works some more.

Good job - I'll see you in the evening.

Take care,

Ted


`@param[in,out] crypt_data`


yeah i put back he doc strings as inline text


You probably didn't notice because only the fribidi test apps and FFmpeg's -vf drawtext used those.


> Similarly, making a FancyREPL plugin is probably a good idea as well
> (@tkw1536 <https://github.com/tkw1536>

I would go so far as to just call it mmt-repl and move it into a
separate project then. If available, the default shell should
automatically load the plugin. If not, it should dump out a warning and
fall back to a bare-bones implementation (i.e. the old one).


@peff Thanks. I used to access the mailing list via gmane, but it seems to be down/broken.


there's no difference in compilation between the code in FV and standalone apps. Pages are compiled once on native platforms.


this is a test comment on this bit of code


Do we still need to pass True ?


The function `fil_space_set_crypt_data()` must be defined `static` and the declaration in the .h file must be removed. There are no external callers. Maybe this whole function can be removed?
As far as I can tell, the only legitimate use for this could be when the conversion of an unencrypted tablespace to encrypted is initiated. Otherwise, we should always have the `fil_space_t::crypt_data` initialized when the tablespace file is opened.


[[Bluemix DevOps]](https://console.ng.bluemix.net/devops/toolchains/6a561b64-cd71-40b8-bd3f-2f74a7278518) This commit has been deployed to DEPLOY by [simple-toolchain-1488458840144](https://console.ng.bluemix.net/devops/pipelines/8cfc1e28-863a-475d-8760-c27c8dce3df1)


Hi @leroyo8,

I have just done some testing and I can't reproduce your error. When you set the critical gradient to 0.57 are you putting the value in quotes?

The code is expecting a real number here eg `0.57` rather than `'0.57'` if this isnt the case can you upload your settings.py file here and I will take a look.

Thanks,

Stuart


did you intenionally overwrite the previous NEWS from cmb?


Move the assertion to the start of the function.


we can't capture debug data in live apps without the client agreeing to it, errors could include client or sensitive data. How can you guys make it work?


Flash


these are also tabs.

probably you need to set your editor to spaces instead of tabs.


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2225](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25196&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


# FlashableZipCreator v4.0


Hello, I have a question here.

What is the usefulness of the user object, and I did not see it being used in the "edit_profile.html" template?


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2225](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25196&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:18


Add a FIXME comment that `max_offset` should be removed and instead `space->size` be consulted.


The Dockerfile is sort of interesting.  It is used to build the container but also, to some degree, tells the container how to run.  The ENV entries can be used when building the container or in the CMD directive at the bottom.  It is not really a runtime option, so no, you don't change the version prior to running the container, the ENV in this case is built using the specified version.


We simply have not much development time currently to invest doing the change in how the engine compiles the pages, because it means the server has to compile them on demand (and in a different way) when being served for FV (which we also have no track about, from the server-side so it needs client-side changes too).

Therefore my suggestion is to leave tracking disabled by default. If we want to debug an app (either standalone of via FV) you simply enable debugging (and disable it when you don't need it anymore).


If `space->is_stopping()` we cannot get this far.


Well, you referenced the "rectified" PSR-2 (PSR-2-R) Additions, so I read what it meant, and this is what appears at the beginning of PSR-2-R: https://github.com/php-fig-rectified/fig-rectified-standards/blob/master/PSR-2-R-coding-style-guide.md#1-overview


`ut_ad(!space || space->n_pending_ops > 0)`


xm


Probably, it should just ask the controller for a REPLExtension (new abstract class extending Extension) and if none exists just call to the standard repl.

Even fancier would be to check whenever a loadExtension-Action is called, whether the extension is a replExtension and if it is, switch to that. Then you could start with the standard repl, do an "extension info.kwarc.bla.REPL" and immediately drop into the new REPL :)


The fix is in stable branch, so doesn't need to be in the 7.2 NEWS file.


`ut_ad(space->n_pending_ops > 0);`


Make sense, so it is either on or off for all apps?


I try to explain
we have a 32b architecture and with 1 byte of padding the cast from lys_node to lys_ext structures didn't work and we had segfault.
with this patch everything works fine.
the problem didn't occur with 64b when the compiler adds 4 padding bytes to complete the 64b word.
now everything works as a charm and I have realized that no configurable padding is required
thanks a lot


Object.toString() is exactly that.


`ut_ad(space->n_pending_ops > 0);`
Do we really need the variable `space_id`?


beautiful
outstanding


Injector don't care about compileBeforeRun field anymore.


`ut_ad(state->space->n_pending_ops > 0);`


With the tutorial I have started to try and build up knowledge of how things work so I started with the basics and, if you go further, you will see that I do introduce full triggers in the next lesson.  I agree full triggers is the form users would most likely want to work with but I thought it could be good to understand that under the covers things are represented, and can be manipulated, in pieces.


Revisado ;)

Este estuvo un poco mas simple pero valido entre la temática del bog, tener cuidado con las tildes.
Si es posible porfa replantear la conclusión, tiene muchas ideas que no conectan adecuadamente entre si.


Yeah that's the work around I've gone for, but if you move something else out of `load-image` in a minor change it will break. Therefore I've pinned the version down so I don't automatically take minor updates.

Thanks for your time!


Why do we need 2 parameters here? `space == state->space`, right?


I recommend log4j with severity filtering.


The current commit contains documentation files, widgets, and java code to unload data from RedshiftToS3.
Following points still need to be addressed for this plugin:

1. Unit Testing
2. UI Testing


Bluemix Toolchain ([TraceabilityMicroToolchain6](http://localhost:3100/devops/toolchains/e29db323-b9f3-4114-b9fe-2e8c8fb5a443)): This commit has been deployed to Staging_Micro1488460636102 by GitHub ([catalog-api-toolchain-demo-23fev](https://github.com/jauninb/catalog-api-toolchain-demo-23fev))


Hello, Amir,

You are very close, indeed.

I wonder:

1. What does "displat" mean?
2. How come you kill all of your lovely turtles at the end of your display_msg method?

See you in the evening,

Ted


Minor: can be made immutable by using final.


We usually do not declare pass-by-value parameters as `const`.


testing hello-world.php


Files.exists() is one-line solution :>


I considered doing this and may go back to it.  I wanted to initially get more breadth. And, in the hopes that people sort of go through the tutorial in order, I plan to use other condition types in future examples, in lesson 03 I already introduced Rate condition.

Also, when there is more content I want to create a TOC type page that lists topics covered in the various lessons.


:D ture


It is the improved report version, from my point of view, more convenient for viewing :)


Please file a follow-up 10.1 bug for fixing this and the scrubbing thread.
I think that this function should be removed and these tasks should be part of the normal shutdown or DROP TABLE logic.


The fix is indeed wrong. A new commit with a more extensive refactoring will be provided. Values shouldn't be loaded individually from storage because checking for load errors is too cumbersome. We'll load in larger blocks instead, with proper load error checking. (Ideally this should be done in all loaders, but reworking all that legacy code is painful.)


'Beauty is truth, truth beauty,—that is all
    Ye know on earth, and all ye need to know.'

http://www.bartleby.com/101/625.html


@ibroom on or off per-app. But once is on for an app, it's enabled on both the standalone and FV package.


Hi, Zohar,

You haven't pushed your work to GitHub in a while.  I know you've been working on Laptop 119 - even when you're using a single computer for all your work, it's still a good idea to push to GitHub every time you've made any progress in your code - it's a good way of backing up your work. (You can always go back to an earlier version of your code stored in GitHub, if you want.) I'll copy the steps to push here again:

0.  Save your work in idle3 first (many students forget to do this, and with bad consequences). You can do this by clicking on "File" and then "Save" in idle3, or by typing Ctrl-s, or by pressing F5 (which also runs the code).
1.  Open a terminal (it can be the one you used to run idle3, but if it isn't, make sure you go to the right directory, or folder, by using the cd command - something like cd zohar/meet201617yl1cs-chat
2.  Enter the following four git commands:
    git add --all
    git commit -m "comment"
    git pull
    git push

I'll see you at the session in the evening.

Take care,

Ted


Remove the field `fil_space_t::page_0_crypt_read`. If and only if `space->chain.start->size != 0`, the crypt information will have been read.


Why not just pass `node->space, page` to this function?


Commit 6c5bc203442bdca5966ce09c0e9723380e54ab37 breaks my tests and this commit (3f187ba4e262cf84815f57dfb6bd4b1bf0bed2dd) doesn't fix that.

Traceback that I get:
```
Traceback (most recent call last):
  File "/usr/local/src/tests/develop/bin/salt", line 10, in <module>
    salt_main()
  File "/usr/local/src/tests/develop/local/lib/python2.7/site-packages/salt/scripts.py", line 471, in salt_main
    import salt.cli.salt
  File "/usr/local/src/tests/develop/local/lib/python2.7/site-packages/salt/cli/salt.py", line 11, in <module>
    from salt.utils import parsers, print_cli
  File "/usr/local/src/tests/develop/local/lib/python2.7/site-packages/salt/utils/parsers.py", line 28, in <module>
    import salt.config as config
  File "/usr/local/src/tests/develop/local/lib/python2.7/site-packages/salt/config/__init__.py", line 38, in <module>
    import salt.syspaths
  File "/usr/local/src/tests/develop/local/lib/python2.7/site-packages/salt/syspaths.py", line 78, in <module>
    SHARE_DIR = __generated_syspaths.SHARE_DIR
AttributeError: 'module' object has no attribute 'SHARE_DIR'
```


General ideas are OK.

But it's generally a source of trouble if code contains special cases:
* checking if a specific class is available is bad
* watching for special kinds of extensions being loaded is bad

So that should be avoided.


We actually have this already: https://github.com/VSCodeVim/Vim/blob/master/src/util.ts#L64


It seems that the `git_config_include()` function fails to open `foo` because it is a directory, but it does not bother to tell us.


First of all manipulator have very vague filtering. Because at this moment we can introduce specific configuration to task manipulator, filtering should be done in view layer.
Task manipulator should be only able to inject/restore task in configuration nothing more nothing less.


The clever way to do this is `str.split("").reverse().join("")`


I think `if x then triTrue else triFalse` is clearer.


That's pretty cool :D


The current commit contains documentation files, widgets, and java code to unload data from RedshiftToS3.
Following points still need to be addressed for this plugin:

Unit Testing
UI Testing


Maybe `map (fromBool . getDefined . initial circuit)`?


:heart:


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/2eab9d88-e0bb-4b63-b31b-2e5b3d432d65) This commit has been deployed to DEPLOY by [simple-toolchain-1488461012152](https://console.stage1.ng.bluemix.net/devops/pipelines/cbcb7c24-99a4-4993-ae1a-93bc2f6c8e38)


iOS style :)


#39785 should fix it.


@fr4z3n yes done alredy


I think `_.memoize()` could do what you're doing here.


Just kidding a bit.


TeamCity CI BACKEND :: TEST_CHAIN :: template_ci [Build 309](https://teamcity.forcity.io/viewLog.html?buildId=12544&buildTypeId=TestChain_TemplateCi) outcome was **SUCCESS**
Summary: Tests failed: 1, passed: 2 Build time: 00:00:56


I think that we must increment `sp->n_pending_ops` before releasing the mutex, and invoke `fil_space_release(sp)` afterwards if `sp != NULL`.
I thought I pointed out in a previous review that `sp` could be freed by other threads as soon as `n_pending_ops` reaches 0.


'../../src/app' ?


The set of visited nodes should be a `Set`.


Yes, that will work. I haven't quite got the hang of `.` yet :(


YW @marcphilipp. :)


Hi @jesg
Thanks again for this. Now I found the time to try it out.
But I am not sure how to use it.
I need to pass my white/blacklist as a string. Your implementation seems to expect an array or object, isn't it?
I don't know much about JS, but I guess one could check for a string and then use split on it to get an array to iterate?

I tried this and it works for me:

`blacklist = desiredCapabilities[k].split(",");`
  `  const len = blacklist.length;`
`            for(var i = 0; i < len; i++) {`
 `               pageBlacklist.push(new RegExp(blacklist[i]));`
`            }`

And then I passed something the list seperated by comma

I am using the whole stuff with behat in php-context. So I have my behat.yml and need to write the white/blacklists there


Oh yeah.  Root!


elapse*d*TimeInMs? :) (and evevrywhere in this commit)


Bluemix Toolchain ([TraceabilityMicroToolchain6](http://localhost:3100/devops/toolchains/756cb61b-def0-4fab-86e2-aed60a32d12f)): This commit has been deployed to Staging_Micro1488461449362 by GitHub ([catalog-api-toolchain-demo-23fev](https://github.com/jauninb/catalog-api-toolchain-demo-23fev))


Testing Newq ,masjkdaslkdkasdSdfdsf


Also, make sure you either install salt again or delete the generated `salt/_syspaths.py` created during the previous setup.


Sorry I meant elapsedTimeInMs, my comment was just to add a 'd'


just what i was looking for, great job!!


za spajanje


Added:
* List inventory items
* Create new inventory item


I would be grateful for your help.

I have this LCD cape, it's working, but I want to modify it, my idea is that I'll use the cape to drive a similar LCD with slightly different characteristics.

I have got to the point where I can modify the source file and make the dtbo, I am able to attach and detach overlays but for the moment I am using the physical cape to instigate the overlay as I get a host of errors when I try to add the overlay without the cape. I'm trying to take small steps.

So I have latest image versions fully updated 4.30 and 8.6.

I have updated DTC but it won't compile BB-CAPE-DISP-CT4-00A0.dts so following your other advice I am using make. I make the dtbo and put it in /lib/firmware and reboot.

The cape and display work exactly as before, the changes I have made make no difference.

I can even remove BB-CAPE-DISP-CT4-00A0.dtbo from /lib/firmware entirely but the board still boots and runs the display exactly as before. Slots looks like:

root@beaglebone:/sys/devices/platform/bone_capemgr/slot-0# cat $SLOTS
 0: P---L-   0 BB-CAPE-DISP-CT43,00A0,Embest,BB-CAPE-DISP-CT4
 1: PF----  -1
 2: PF----  -1
 3: PF----  -1

I would really appreciate if you could point me in the right direction.

Many thanks


no make return 0 or break at the last ligne in function ?
a function return always $? !

for break : exit the loop ok but only if is directly in a loop (not in a function in loop)


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2226](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25201&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


@marcosbarbero, no caso de métodos já existentes na interface ele não permite que você sobrescreva para usar Optional.


Yes I know now, it's in the next upgrade. I'm working on it.


i hope this is enough condition to match an operation, since we are not checking result type... as in https://docs.oracle.com/javase/7/docs/api/javax/management/MBeanOperationInfo.html#equals(java.lang.Object) but we need to match console commands with JMX somehow...


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2226](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25201&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:07


Хорошо


Well, I usually read from left to right, that's why I prefer `const T*` (means "this is a const object"). But that's a matter of taste, of course. I learned it so from the Stroustrup book and see it more widespread than the other way, but `objdump` e.g. uses `T const*`.


the fact we look for operation before attributes is not casual, is due to the fact slee is defining mbeans like that. maybe put a comment...


[[Bluemix DevOps]](https://console.ng.bluemix.net/devops/toolchains/2c21b2f1-96a1-4b13-bd2b-4d109989add2) This commit has been deployed to Deploy Stage by [default-toolchain-1488461369094](https://console.ng.bluemix.net/devops/pipelines/6c3f8eab-a39b-46ad-98d1-352ac78b1443)


Another point: If type is first, the next line would read
```c++
int const u = CACHESIZE, v = 2 * CACHESIZE;
```
Looks a bit odd...


When there are a lot of data it takes a lot of time 👎


Ah, also better call `unsafe_get` here since `isnull` has been called manually. Unfortunately, I now realize that function isn't defined on 0.5, so you'll have to define a fallback like this somewhere:
```julia
if !isdefined(Base, :unsafe_get)
    unsafe_get(x::Nullable) = x.value
    unsafe_get(x::Any) = x
end
```


Remove "Struct for retreiving" or at least fix the typo: retrieving


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2227](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25204&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


This looks interesting. Is it only available in Specflow+?


Bluemix Toolchain ([TraceabilityMicroToolchain8](http://localhost:3100/devops/toolchains/93f254e1-d481-4bec-bc08-facefc1fb5a9)): This commit has been deployed to Staging_Micro1488462027043 by GitHub ([catalog-api-toolchain-demo-23fev](https://github.com/jauninb/catalog-api-toolchain-demo-23fev))


Nope,  this is not needed.


This section will be rewritten. But `T` is a free variable.


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2227](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25204&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:16


`/** @return whether the tablespace is about to be dropped or truncated */`


this will stop fragment loading on 'pause', is it really what you want ?
some users are using to 'pause' to let the buffer fill up.


No, but it is not yet released. You have to use a CI-Build version to get it.


We do not have binlog in prepare, as it is not part of the the backup (only datafiles, possibly of different engines, and innodb redo log)


Bluemix Toolchain ([toolchain-load-09a86cf3-56c8-4f42-85db-809b137e99b8-111](https://dev-console.stage1.ng.bluemix.net/devops/toolchains/3662cee1-167b-4ab4-b5d5-3c2d19ed296f)): This commit has been deployed to STAGING by Delivery Pipeline ([catalog-api-toolchain-load-09a86cf3-56c8-4f42-85db-809b137e99b8-111](https://dev-console.stage1.ng.bluemix.net/devops/pipelines/18b84206-8c7c-4a53-97ee-02b5d7a0f996))


Where is this declaration needed and why is `fil_read()` no longer defined as `UNIV_INLINE`? I did not see any added call to `fil_read()`.


Thanks. (I always remove the previous virtualenv). It looks sensible and I'll check it when it's merged.


just wondering why you need to recopy the whole default configuration ? it would be better to only tweak the config key you are overriding


On Thu, Mar 2, 2017 at 5:59 AM Michael.S.G <notifications@github.com> wrote:

> When using the payout/hopper, Payout dispenses two units instead of just
> one.
>

This is just because the payout button is a bit sensitive; the bookkeeping
remains consistent with the credit count. The button can be held down to
dispense more than one credit, and many other medal games just pay out the
entire credit count, so the sensitivity could be original behavior.

AJR


The justification for _id is if you wanted to test first if changing the value of a a field with a unique constraint - not necessarily the primary key - would result in a non-autoincremented table having non-unique values, the only way to test it would be to verify whether the row identifiers are identical or not.


Aha.. because .gitconfig says "include ~/foo" and "git init foo" happens to create ~/foo? I tried this. The first time git_config_include() was called, "foo" was not there, all was well. The second time (in the same git-init), "foo" was already there and fopen happily opens a directory as a file. I got EISDIR on the first get_next_char(), but fgetc() in this function returns EOF though. Which is why on linux it didn't complain anything.

I guess fgetc() on Windows returns something?

Either way we should not open a directory as a file in the first place. Could you please submit a patch? You did all the work and deserve the credit ;-) We can know blame all the things on Jeff! Poor Jeff..


qqqqqq


Remove the assignment and comparison of `zip_size` to `ULINT_UNDEFINED`. It suffices to check `space == NULL`.
After this `if`, define `const ulint zip_size = fsp_flags_get_zip_size(space->flags);`


aaaa


True, I just anted to make it explicit to the end users what are their options if they need to tweak anything


@jralls there is maybe also a minor typo (missing 'open' parenthesis) on your change?
```
File "/home/travis/build/gramps-project/gramps/gramps/gui/widgets/undoableentry.py", line 124
    (event.get_state() & Gdk.ModifierType.SHIFT_MASK)):
                                                      ^
SyntaxError: invalid syntax
```


Use `ULINTPF` and remove the cast.


what happens if we dont match operation,setter or getter?


you can call `hls.loadSource()` before `MEDIA_ATTACHED` event is received. it might help gain some precious milliseconds.


`if (fil_space_t* space = …)`. We must not call `fil_space_release(NULL)`.


Indeed, I will fix it. Thanks!


Check for `space == NULL`.


这是最简单方便的处理方式。。。如果在device tree里设定，还要去build里再定义一个，这里才能调用，况且貌似目前看到的只有加1是默认输出/1000的


By mistake, will fix!


same, you can call `loadSource()` before receiving `MEDIA_ATTACHED` event


Check for `space == NULL`, also in `fil_space_release()`. I would move the whole block inside
`if (fil_space_t* space = fil_space_acquire(space_id)) {`.


I'm just thinking in terms of bandwidth for low connectivity. You advise not to use this, then?


@EinarW 😠 😄


I could actually remove all of this.


这恰恰是优点，而你们抄了缺点。
事实上你们继续跟踪elastic的logstash发展就知道，logstash从2.3版本开始，也改成了filter和output共用一个pipeline worker线程。
类似的还有rsyslog的main queue和action queue设计。
可以说，这才是高性能的恰当做法。


Bluemix Toolchain ([toolchain-load-09a86cf3-56c8-4f42-85db-809b137e99b8-111](https://dev-console.stage1.ng.bluemix.net/devops/toolchains/3662cee1-167b-4ab4-b5d5-3c2d19ed296f)): This commit has been deployed to STAGING by Delivery Pipeline ([ui-toolchain-load-09a86cf3-56c8-4f42-85db-809b137e99b8-111](https://dev-console.stage1.ng.bluemix.net/devops/pipelines/fd03d4e2-801c-43d7-b66b-6516ca9337de))


Add a comment why `fil_space_acquire()` is not being used.


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2228](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25206&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


Thanks. I have been trying to run scenarios in parallel but FeatureContext.Current is static which is causing me problems.


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2228](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25206&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:26


Nice. Let's go here https://github.com/Codeception/VisualCeption/issues/12 to discuss the way the project is going to be maintained


Also add a comment in which way the existence of `table->crypt_data` makes anything easier.
Often, redundant storage of data is only introducing potential inconsistency with no real benefit.


Thanks for the hint. I'll implement this


good catch, thanks Nick.


てｓｔ


Is this actually correct? "ssid" does not exist yet?


(function(){

})


@nfeske, @chelmuth: please add to staging


[[Bluemix DevOps]](https://dev-console.stage1.ng.bluemix.net/devops/toolchains/c234adsf-111) This commit has been deployed to TestEnv


302…, endlich bei allen der gleiche Stand beim Spielstand ;)_


Indeed, on Linux `fopen(directory)` returns a pointer without failing, and reading from it returns `EOF` immediately.

With this patch, the test passes:

```diff
diff --git a/config.c b/config.c
index 3f80a59f1bf..ba2890974a4 100644
--- a/config.c
+++ b/config.c
@@ -163,7 +163,8 @@ static int handle_path_include(const char *path, struct config_include_data *inc
 			    !cf ? "<unknown>" :
 			    cf->name ? cf->name :
 			    "the command line");
-		ret = git_config_from_file(git_config_include, path, inc);
+		ret = is_directory(path) ?
+			0 : git_config_from_file(git_config_include, path, inc);
 		inc->depth--;
 	}
 	strbuf_release(&buf);
```

However. The test is just plain wrong in assuming that it is okay to `[include]path` a directory. It is a user mistake, plain and simple, to include a directory when you want to include a config file instead, and Git should actually error out in that case. And the test needs to be fixed *not* to include a directory.

FWIW it seems that the behavior of `fopen(directory)` is actually undefined. But just because it seems to work as you want on Linux does not imply that it is correct, of course. *At least* the test in question is incorrect.

So not only does the test need to be fixed, I think the code that includes a directory without complaining on some platforms needs to be fixed, too, and there is a third fix that is really required: why on earth does `handle_path_include()` not bother to print an informative error when it failed to open the path in question? And there is probably room for a fourth fix, too: it is *highly* confusing (or misleading, even) to print out a parse error with the incorrect line number.


no need also for the `snd` variable. You can just leave it away. Also the last statement in a function doesn't need a semicolon, better leave it out.

The change rate of `0.01` is very slow for an example, you'll have to wait 1.5 minutes to hear the first change.


You are right this should be only for a `stop` event, not a `pause`


12. Object Oriented Programming in Python.py

good


Are you sure you want 'has' rather than 'depends'?


Test failed, nav bar works on PC but fails on mobile. Color is lost and links do not work.


@gitster just in case you missed it: the config-include-if patch series should not graduate to `next` before this issue is fixed.


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.33.1-pre-8-gb3aad70](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=53082&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **SUCCESS**
Summary: Running Build time: 00:00:42


hi @jarnoh,
followed this patch with great interest as i am always keen on saving space for pdf files and our pdf files heavily use deflate filter. Unluckily I can't make it build on my system; It fails with:
```shell
# only failing command
/bin/bash ./libtool --quiet --mode=compile g++ -g -O2 -Wold-style-cast -Wall -MD -MF libqpdf/build/Pl_Flate.tdep -MP -Iinclude -Ilibqpdf  -c libqpdf/Pl_Flate.cc -o libqpdf/build/Pl_Flate.o; sed -e 's/\.o:/.lo:/' < libqpdf/build/Pl_Flate.tdep > libqpdf/build/Pl_Flate.dep
In file included from libqpdf/Pl_Flate.cc:22:0:
libqpdf/../zopfli/src/zopfli/zlib_container.c: In function 'unsigned int adler32(const unsigned char*, size_t)':
libqpdf/../zopfli/src/zopfli/zlib_container.c:29:63: error: conflicting declaration of C function 'unsigned int adler32(const unsigned char*, size_t)'
 static unsigned adler32(const unsigned char* data, size_t size)
                                                               ^
In file included from libqpdf/Pl_Flate.cc:2:0:
/usr/include/zlib.h:1260:23: note: previous declaration 'uLong adler32(uLong, const Bytef*, uInt)'
 ZEXTERN uLong ZEXPORT adler32 OF((uLong adler, const Bytef *buf, uInt len));
                       ^
/bin/bash: libqpdf/build/Pl_Flate.tdep: No such file or directory
make: *** [libqpdf/build/Pl_Flate.lo] Error 1

```

There is some definitions (at least ```adler32``` function) from zlib.h conflicting with zopfli sources. I don't have C skills to resolve these errors.


[Your benchmark job](https://github.com/JuliaLang/julia/commit/4dbe24538823ab0268885c0cb3a2bac9e3e7cd7f#commitcomment-21118432) has completed - possible performance regressions were detected. A full report can be found [here](https://github.com/JuliaCI/BaseBenchmarkReports/blob/c680e8d895a8e59d257f3ca6bb72b05fde0863c3/4dbe245_vs_3c9d753/report.md). cc @jrevels


no, i don't have a server , how can I create? , i know it's a silly question , but this is my first experience in developpement
tomcat is alredy connected to the netbeans but idk how generate the server


> The test is just plain wrong in assuming that it is okay to [include]path a directory.

Absolutely. I'm planning to resend right at the moment.

There may be something else wrong with Windows though, if I force getc() to return rubbish when opening a directory, I got this

```
fatal: bad config line 1 in file /home/pclouds/foo
```

But when my test failed, it showed that it was parsing ~/.gitconfig instead. Misleading.


@KevinW1998 , look next commits for surprise ;-)


Could this approach be improved?


change this to cards instead of card


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/d672571c-57a6-4495-8b97-b645d6d5953f) This commit has been deployed to STAGING by [ui-toolchain-load-f1be0ae9-9895-4c40-bc6f-4c139c0f69a7-968](https://console.stage1.ng.bluemix.net/devops/pipelines/329826ee-e3d6-4778-93f5-762256508e50)


sure, I will put comments instead of log messages.


Yes, good point


Why []. Should be "Array"


ok its this issue https://github.com/Chrysostomus/manjaro-architect/issues/77#issue-210977564

not fan to have 2 files with same code : if you change in one file == change in the second ?
to maintain is hell

me a had proposed dynamics menus (not sure its possible in this cas)

```
cmd=(DIALOG "Select init:" 0 0 16)
menus=(1 "Option 1"
         2 "Option 2"
         3 "Option 3"
         4 "Option 4")

#  read params "regular/advanced", params enter by laucher
#  modify/delete array menus
# if count(menus) =0 then you can call the work function directly
# or for disk for exemple remove lvm if no lvm partitions

# here dont use a file  ANSWER for view choice :)
choice=$("${cmd[@]}" "${options[@]}" 2>&1 >/dev/tty)
choise="${choise:-0}"   # if cancel , choise is now zero end not ""
# not goog this case !!
case "$choice" in
    0) return 0 ;; # btn cancel
    1)  ;;
    2)  ;;
esac
```

with $choise we have a problem if we delete "Option 3" all $choise are offset but It must be possible to manage this by attaching a function to each menu item (not tested...)
we replace "case" by find in strcture the good function

```
cmd=$menus[$choice][function]
(err=$cmd) || return $err
```


ok, I will throw CommandException, thanks


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/d672571c-57a6-4495-8b97-b645d6d5953f) This commit has been deployed to STAGING by [orders-api-toolchain-load-f1be0ae9-9895-4c40-bc6f-4c139c0f69a7-968](https://console.stage1.ng.bluemix.net/devops/pipelines/43094efe-13db-4c76-8fa3-3c60f5415f63)


It is a sign mismatch. `my_thread_id` is signed. And a better fix would seem to be to change the parameter type to `my_thread_id`.
If we disregard sign mismatches, this change is not necessary. In InnoDB, I would care about sign mismatch.


Original hueta


password should be an env var and should not be a param.


what ?


password should be a global file var and should not be a param.


[[Bluemix DevOps]](https://dev-console.stage1.ng.bluemix.net/devops/toolchains/c234adsf-111) This commit has been deployed to TestEnv


@martin-g Thanks for the report! I created https://github.com/spring-projects/spring-security/issues/4234

Are you interested in submitting a PR?


Definitely a better idea. I did not look up the `ENUM_FLAG` definition.


已经修改，感谢反馈


Agreed.


I'll fix it.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/d672571c-57a6-4495-8b97-b645d6d5953f) This commit has been deployed to STAGING by [catalog-api-toolchain-load-f1be0ae9-9895-4c40-bc6f-4c139c0f69a7-968](https://console.stage1.ng.bluemix.net/devops/pipelines/282950a1-107b-4157-8cda-06e6d1c124ce)


also I think we can return some operationResult for displayResult() later, something like: "Attribute ... was set to value ...".


Haha, i'm still new with github so i'm asking why did you do a fork for that ?
(of course, i've edited my Readme for adding that !)


Bluemix Toolchain ([TraceabilityMicroToolchain15](http://localhost:3100/devops/toolchains/37d34ee4-fa4c-4d42-bcce-5214f9a4ddfc)): This commit has been deployed to Staging_Micro1488463734183 by GitHub ([catalog-api-toolchain-demo-23fev](https://github.com/jauninb/catalog-api-toolchain-demo-23fev))


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/d672571c-57a6-4495-8b97-b645d6d5953f) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-f1be0ae9-9895-4c40-bc6f-4c139c0f69a7-968](https://console.stage1.ng.bluemix.net/devops/pipelines/43094efe-13db-4c76-8fa3-3c60f5415f63)


absolutely, good catch


Sure!


frumos...


mersi


This might still not be optimal. :) There are files with a header size of 29 (so the sample header size is not part of the data), which could in theory provoke a short read warning here. I think the best way is to read xih.size, then read (xih.size - 4) more bytes into the struct, and memset the remaining bytes to 0. But for the time being, this is definitely better than the previous solution.


Maybe also include "$ENV{VK_SDK_PATH}/Lib" and "$ENV{VK_SDK_PATH}/Lib32"?


Visit https://kapigw.test.com


Merci !


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/80f85309-b21b-4556-9a44-b4b97a04e397) This commit has been deployed to STAGING by [ui-toolchain-load-aec80339-6aac-4a79-9213-8d5594220799-502](https://console.stage1.ng.bluemix.net/devops/pipelines/2cbc9230-aa70-4139-8e6f-0cde9ac6ad8f)


Also using `sass main.scss output.css --style compressed` to generate minified css file


cc @Manishearth, @llogiq, @mcarton

Anyone feel like pre-reviewing the guesses RFC before i throw it before the wolves?


Mhh? Where?


> Could you please submit a patch?

No, I am busy with three other things that really require my full attention. The test should be fixed in your patch series, anyway.


Hello, I think the email should be changed to lowercase. See the http://en.gravatar.com/site/implement/images/python/.


test


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/80f85309-b21b-4556-9a44-b4b97a04e397) This commit has been deployed to STAGING by [orders-api-toolchain-load-aec80339-6aac-4a79-9213-8d5594220799-502](https://console.stage1.ng.bluemix.net/devops/pipelines/0894d16b-39b5-4ab8-a2f3-38de7bbf5242)


> when my test failed on Windows, it showed that it was parsing ~/.gitconfig instead. Misleading.

Yes, please look at my analysis: `handle_path_include()` simply returns the return value of `git_config_from_file()`, and that function does not bother printing an error.


at commit c378dee: @nanosoldier `runbenchmarks(ALL, vs = "@3c9d75391c72d7c32eea75ff187ce77b2d5effc8")`

the following commit probably slowed conversions down


You are correct AI_IDN is a glibc thing, but not all glibc's have AI_IDN and when cross-compiling you can't test for it with autoconf (just FYI, I realize you don't use autoconf).

Another FYI, Martin Lambers at the msmtp project used a HAVE_GAI_IDN here:
https://sourceforge.net/p/msmtp/code/ci/c44e1237d47ba51ba3d64ab9a5e94c8c421a69e7/

May I suggest you revert'ish to:
```
#ifdef HAVE_GAI_IDN
    hints.ai_flags |= AI_IDN;
#endif
```
Default to HAVE_GAI_IDN 1, but easily allow to un-define HAVE_GAI_IDN for us that need to.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/80f85309-b21b-4556-9a44-b4b97a04e397) This commit has been deployed to PRODUCTION by [ui-toolchain-load-aec80339-6aac-4a79-9213-8d5594220799-502](https://console.stage1.ng.bluemix.net/devops/pipelines/2cbc9230-aa70-4139-8e6f-0cde9ac6ad8f)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/80f85309-b21b-4556-9a44-b4b97a04e397) This commit has been deployed to STAGING by [catalog-api-toolchain-load-aec80339-6aac-4a79-9213-8d5594220799-502](https://console.stage1.ng.bluemix.net/devops/pipelines/03e6ee63-dc84-4b55-ac24-5c7a69a42110)


Jo, det er det. Men du har sikkert ikke fået opdateret din pluginliste i QGIS. Det gør du et sted under plugin settings.


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.33.1-pre-17-g25aede4](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=53092&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **FAILURE**
Summary: Snapshot dependency failed: ... Test Client Build time: 00:00:04


Look again at the output of your test, and look at this

```
expecting success:
        git init foo &&
        (
                cd foo &&
                echo "[includeIf \"gitdir:foo/\"]path=bar" >>.git/config &&
                echo "[test]one=1" >.git/bar &&
                echo 1 >expect &&
                git config test.one >actual &&
                test_cmp expect actual
        )

fatal: bad config line 1 in file /home/pclouds/w/git/temp/t/trash directory.t1305-config-include/foo
not ok 18 - conditional include, both unanchored
```

Notice that this here shows "file .../foo"


Closes #49


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2229](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25207&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


非常赞的notebook，有没有兴趣一起造轮子。打算用Akka、Scala写一个分布式的类似InfluxDB的东西。

你是工作了还是在读研？


Surround the `INSERT`s with `BEGIN` and `COMMIT`. There is no need to fsync() the redo log after every statement.


Il est important de corriger aussi les fichiers d'exemple appeler par input.

Par exemple, dans le cas présent, https://github.com/maieul/latexhumain/blob/espanol/exemples/premierpas/notions/1.tex (le dossier exemples contient l'ensemnle des exemples, structurer par partie puis par chapitre).


Remove the `exec` and the second `source`.


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2229](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25207&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:53


這邊


我真的不會用這個


Cool


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/d672571c-57a6-4495-8b97-b645d6d5953f) This commit has been deployed to PRODUCTION by [catalog-api-toolchain-load-f1be0ae9-9895-4c40-bc6f-4c139c0f69a7-968](https://console.stage1.ng.bluemix.net/devops/pipelines/282950a1-107b-4157-8cda-06e6d1c124ce)


I found this error
```
ERROR in ./resources/scss/main.scss
Module build failed: ModuleBuildError: Module build failed:
  color: $blue-800;
        ^
      Undefined variable: "$blue-800".
      in /home/nay/php-works/moon/node_modules/primer-alerts/lib/flash.scss (line 6, column 10)
    at /home/nay/php-works/moon/node_modules/webpack/lib/NormalModule.js:141:35
    at /home/nay/php-works/moon/node_modules/loader-runner/lib/LoaderRunner.js:364:11
    at /home/nay/php-works/moon/node_modules/loader-runner/lib/LoaderRunner.js:230:18
    at context.callback (/home/nay/php-works/moon/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at Object.asyncSassJobQueue.push [as callback] (/home/nay/php-works/moon/node_modules/sass-loader/lib/loader.js:51:13)
    at Object.<anonymous> (/home/nay/php-works/moon/node_modules/async/dist/async.js:2237:31)
    at apply (/home/nay/php-works/moon/node_modules/async/dist/async.js:20:25)
    at Object.<anonymous> (/home/nay/php-works/moon/node_modules/async/dist/async.js:56:12)
    at Object.callback (/home/nay/php-works/moon/node_modules/async/dist/async.js:843:16)
    at options.error (/home/nay/php-works/moon/node_modules/node-sass/lib/index.js:294:32)

```


One `perl` interpreter invocation is enough. Remove the `EOF perl;` in the middle.


Uhm, am I supposed to see this API key?


No, it's the maximum batch size. There can never be concurrent dispatches because node code always runs on a single thread so this just clears any backlog from reentrant calls more quickly

> On Mar 2, 2017, at 12:28 AM, Brian Clifton <notifications@github.com> wrote:
>
> Is this the # of concurrent tasks being dispatched? if so, what would happen if the limit was reached (ex: 20 was fairly low- do they queue or cause dispatching to become blocking?)
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/80f85309-b21b-4556-9a44-b4b97a04e397) This commit has been deployed to PRODUCTION by [catalog-api-toolchain-load-aec80339-6aac-4a79-9213-8d5594220799-502](https://console.stage1.ng.bluemix.net/devops/pipelines/03e6ee63-dc84-4b55-ac24-5c7a69a42110)


Why is no failure expected for t2? Is this test supposed to auto-reconnect between each SELECT?


at commit eac77de: @nanosoldier `runbenchmarks(ALL, vs = "@3c9d75391c72d7c32eea75ff187ce77b2d5effc8")`

comprehensions got slower somewhere in here


Hi Valentine,

Good question-- 3.6.0.


Bluemix Toolchain ([TraceabilityMicroToolchain15](http://localhost:3100/devops/toolchains/93184e90-31f7-4724-bb3d-d15045628caa)): This commit has been deployed to Staging_Micro1488464643783 by GitHub ([catalog-api-toolchain-demo-23fev](https://github.com/jauninb/catalog-api-toolchain-demo-23fev))


tjtz


* I added framework: https://github.com/WohlSoft/IniProcessing/commit/0cfc16ccc643413c43d9d4e9b2293b139e04a9a0
* I created the [unit test based on it](https://github.com/WohlSoft/IniProcessing/blob/master/test/validate.cpp) (old utility I renamed to keep it for benchmarking purposes, anyway, it sucks and was made for comparison of performance of QSettings and my own)


Created multidev environment [design-4-drupal#ci-2](https://dashboard.pantheon.io/sites/e45edd44-68ad-4a88-91f2-5209169ae0ec#ci-2).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-2-design-4-drupal.pantheonsite.io/)


merge in from master


Ici, je crois que vous n'avez pas compris la modification que je suggérais.  Puisque le livre s'adresse à des hispanophones, ce paragraphe, n'a plus lieu d'être. L'ajout automatique d'espace ne concerne que le français, pas l'espagnol (si on charche polyglossia avec \setmainlanguage{spanish}, on a pas d'espace.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/80f85309-b21b-4556-9a44-b4b97a04e397) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-aec80339-6aac-4a79-9213-8d5594220799-502](https://console.stage1.ng.bluemix.net/devops/pipelines/0894d16b-39b5-4ab8-a2f3-38de7bbf5242)


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.33.2](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=53114&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **SUCCESS**
Summary: Running Build time: 00:00:54


Este es el primer commit


Remove the `exec` and both `source`. We already wrote the "wait" earlier, and the server should already have crashed.


Part of the reason I needed you to review this -- I noticed that the build produced DLLs without exports. I wasn't sure if this was intended, so I left in the DLL support code I already wrote in hopes that dynamic builds could be enabled with little effort in the future.

Are dynamic/shared builds supported on any platforms? If your supported dynamic build is "export all the symbols" -- the default behavior on Linux -- then we can do that.


typo in the font name, you missed a s when you generated it?


Je viens de corriger cela en 9c2e1c1


@jwilm wheeeee 👍 . One thing: could there be a quirk regarding the width of special characters?

* GNOME Terminal:
![selection_002](https://cloud.githubusercontent.com/assets/522085/23511136/323c4116-ff2a-11e6-880b-1c4297b3b352.png)
* alacritty:
![selection_001](https://cloud.githubusercontent.com/assets/522085/23511156/3d168bd2-ff2a-11e6-83b7-5c27722867f2.png)

Known issue, or should I create a new issue for that?


When would `buf_page_get_gen()` return `err==DB_SUCCESS` and `block=NULL` for `BUF_GET`? I would say never. Keep the condition as is, and add `ut_ad(block || err != DB_SUCCESS)` to each invocation like this.


Hm, that's weird. The reason I changed it was because it seemed from the documentation that at some point they made the gzip reader buffered by default.

I'll try your minimal example above and see what happens.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.1.211.0d8ada0d1b0ca8945c312ceb495ae7726f1a48b5](http://build.palaso.org/viewLog.html?buildId=85389&buildTypeId=bt223) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 3560, ignored: 128 Build time: 00:03:45
### Failed tests
```
SIL.Lift.Tests.dll: SIL.Lift.Tests.Merging.SynchronicMergerTests.WorksWithTempDirectoryOnADifferentVolumne: <no details avaliable>

```


for me this is very wrong - since phpunit 5.4 there is a class  \PHPUnit\Framework\TestCase. Why not using it instead of this workaround. This workaround is not PSR-2 compliant and for the most IDEs it will be a problem to find out which class `MockeryTestCase` extends - that leads to warnings in a good IDE (method assertSame unknown).


Also for `BUF_GET_POSSIBLY_FREED` the only acceptable way to return `block=NULL` is when `err!=DB_SUCCESS`.


Cherry-picked to ponweist/Wannier90@a24da6be0146c14697798485272ed2dfc5b5d777.


I guess you meant to commit this in the #32 issue, not the #33 ?


I thought the same thing! I was expecting it to not make a difference under python 3.


Indent with TABs only, not with TABs + one space.


Reverted at CrowdIn as well.


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.33.2-pre-11-gc260006](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=53120&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **FAILURE**
Summary: Snapshot dependency failed: ... Test Client Build time: 00:00:01


why tho?


odlicno sad samo jos napravi "pull request" da ja to povucem i ujedinim

https://help.github.com/articles/creating-a-pull-request/


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.1.172.0d8ada0d1b0ca8945c312ceb495ae7726f1a48b5](http://build.palaso.org/viewLog.html?buildId=85391&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3536, ignored: 111 Build time: 00:06:55


I cannot quite follow.. a unique constraint would raise a PDO exception if you try to update it "non-unique", wouldn't it?


Bluemix Toolchain ([TraceabilityMicroToolchain15](http://localhost:3100/devops/toolchains/25cad752-e645-4d24-bc56-7211c631881d)): This commit has been deployed to Staging_Micro1488465048568 by GitHub ([catalog-api-toolchain-demo-23fev](https://github.com/jauninb/catalog-api-toolchain-demo-23fev))


@mallardduck Hopefully your use case (7.0 syntax enforced on the 7.1 runtime) is rare, but I get your frustration. You might want to consider forking Phan and updating the composer.json file so that you can continue using it on the automated tests.


Cache the value of `buf_page_get_mutex(bpage)` into a local variable.


These 3 consecutive seq operation * calls scream for a transducer :) I have been meaning to do an overhaul in cyanite using these instead but I am a bit overloaded atm.

Basically these should/could be `(let [xform (comp (map ..) (mapcat ...) (map ...) (remove nil? ...))] (sequence xform coll))` for a single seq (still lazy but no way less allocs), or (into [] xform coll) if we dont' care about lazyness downstream (in that case that should be a **lot** faster but store/query might like it lazy best (unsure)).


Неа, пул потоков тут совсем не нужен. А нужен он в случаях, когда точное количество потоков предсказать заранее невозможно, но в любой момент можно подключить к задаче новый поток.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/1bfd2379-ddaf-4eab-9343-777bb7f39673) This commit has been deployed to STAGING by [ui-toolchain-load-129ad0c4-b1f1-4ad1-80a5-66f04084814c-870](https://console.stage1.ng.bluemix.net/devops/pipelines/d3c9027e-6444-46f3-aab1-f33a0c8f0d59)


[[Bluemix DevOps]](https://console.ng.bluemix.net/devops/toolchains/4a79de64-012c-41c7-9fcc-062101f9ee45) This commit has been deployed to STAGING by [ui-microservices-toolchain-1488464757526](https://console.ng.bluemix.net/devops/pipelines/a9c39759-2d3b-4f9c-82ae-2081d253ba84)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/e79286af-c159-46c8-a972-d57bff0a2405) This commit has been deployed to STAGING by [ui-toolchain-load-4fa0af0b-4ebe-4eb4-9bb0-4433f8749db6-352](https://console.stage1.ng.bluemix.net/devops/pipelines/ddd48963-ccab-4d51-94eb-16dfa4201242)


![](https://github.trello.services/images/mini-trello-icon.png) [Events not working in IE](https://trello.com/c/9ei2hIef/138-events-not-working-in-ie)


![](https://github.trello.services/images/mini-trello-icon.png) [Locations not working in IE](https://trello.com/c/yDj3TQ0j/139-locations-not-working-in-ie)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/127ffb4c-f61f-4f01-b22c-5088e384ebf5) This commit has been deployed to STAGING by [ui-toolchain-load-38c05a76-3c8a-4c4f-93ea-4e526ad5e902-922](https://console.stage1.ng.bluemix.net/devops/pipelines/4c6945d1-457b-4fed-b34d-ec5944dfda6a)


Fat arrow instead of `_this`?


Русский шрифт не видно, имеет смысл перегнать кодировку файла в UTF-8.


Bluemix Toolchain ([TraceabilityMicroToolchain15](http://localhost:3100/devops/toolchains/ff08c7f7-4c68-441c-950f-5da3af0d6f7c)): This commit has been deployed to Staging_Micro1488465243045 by GitHub ([catalog-api-toolchain-demo-23fev](https://github.com/jauninb/catalog-api-toolchain-demo-23fev))


Вообще-то это ярко выраженное нарушение контракта. Можно и исключение выбросить.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/127ffb4c-f61f-4f01-b22c-5088e384ebf5) This commit has been deployed to STAGING by [orders-api-toolchain-load-38c05a76-3c8a-4c4f-93ea-4e526ad5e902-922](https://console.stage1.ng.bluemix.net/devops/pipelines/58a150cd-e7e0-436d-b7ad-81d7b312a253)


To jest lepsze bo masz świadomość, że już więcej do tego nie wócisz.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/e79286af-c159-46c8-a972-d57bff0a2405) This commit has been deployed to STAGING by [orders-api-toolchain-load-4fa0af0b-4ebe-4eb4-9bb0-4433f8749db6-352](https://console.stage1.ng.bluemix.net/devops/pipelines/069b7852-2075-4441-bb08-3327fd865f32)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/1bfd2379-ddaf-4eab-9343-777bb7f39673) This commit has been deployed to STAGING by [orders-api-toolchain-load-129ad0c4-b1f1-4ad1-80a5-66f04084814c-870](https://console.stage1.ng.bluemix.net/devops/pipelines/afdeec56-c723-44db-b3c8-43c728d8b1c8)


looks good


Why does Linux need you to not use C99?  It's over a decade since the last Linux distro to ship without a C99 compiler.  Is it simply that we need to add -std=gnu99 to CFLAGS?  That would be preferable to making the code more error prone.


Niby zmieniłem tylko to w nawiasie czyli **UTF-8** -> **Japanese** ale ok.


Hey Rory, all the minimal examples work for me on both 3.6 and 3.5.1.

Feel free to change it back.

Something still causes umis to fail, but it's not the BufferedReader that fixed it before. I'll try to debug it later. I'm not expecting any new data for a while :p


@thewonderidiot @indy91 I feel as though I've entered some alternate reality in which nothing that I remember and was sure of is correct any longer.  Perhaps it's finally senility setting in.  What I _remember_ is that we had decided that Luminary 99 Rev. 1 is "really" the LUM99R2 that Jim Kernan has been talking about, and that a large part of the reason we thought so was that the ephemeris data in the CONTROLLED CONSTANTS section is the same for Luminary 99 Rev 1, Luminary 116, and Luminary 131.

In fact, I've just finished transcribing and proofing Luminary 116 CONTROLLED CONSTANTS, and I find that while 116 and 131 are indeed identical, the bottom of p. 52 and the entirety of p. 53 is very different from 99 Rev. 1.  What am I missing?

Help!


re @sadhen

在念书，事实上对于数据库一无所知╮(╯_╰)╭

而且对于 scala 的理解停留在 helloworld，恐怕帮不上你呢


Great, thanks for looking into it! Let me know if I can help at all.


> **Akceptuje te zmiany. Niech będzie.**
- Powiedział paweł.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/1bfd2379-ddaf-4eab-9343-777bb7f39673) This commit has been deployed to STAGING by [catalog-api-toolchain-load-129ad0c4-b1f1-4ad1-80a5-66f04084814c-870](https://console.stage1.ng.bluemix.net/devops/pipelines/9fd60ab5-a9ff-4405-9660-c2ec9eae96a8)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/1bfd2379-ddaf-4eab-9343-777bb7f39673) This commit has been deployed to PRODUCTION by [ui-toolchain-load-129ad0c4-b1f1-4ad1-80a5-66f04084814c-870](https://console.stage1.ng.bluemix.net/devops/pipelines/d3c9027e-6444-46f3-aab1-f33a0c8f0d59)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/e79286af-c159-46c8-a972-d57bff0a2405) This commit has been deployed to STAGING by [catalog-api-toolchain-load-4fa0af0b-4ebe-4eb4-9bb0-4433f8749db6-352](https://console.stage1.ng.bluemix.net/devops/pipelines/4b24280c-4f3b-419c-9b6e-4a03f5a7b7e9)


to be confirmed with measurements (of course :))


Работа с матрицами — это как раз тот редкий случай, где переменные `i` и `j` уместны.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/e79286af-c159-46c8-a972-d57bff0a2405) This commit has been deployed to PRODUCTION by [ui-toolchain-load-4fa0af0b-4ebe-4eb4-9bb0-4433f8749db6-352](https://console.stage1.ng.bluemix.net/devops/pipelines/ddd48963-ccab-4d51-94eb-16dfa4201242)


👍🏻 We should make this timeout configurable as well.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/127ffb4c-f61f-4f01-b22c-5088e384ebf5) This commit has been deployed to STAGING by [catalog-api-toolchain-load-38c05a76-3c8a-4c4f-93ea-4e526ad5e902-922](https://console.stage1.ng.bluemix.net/devops/pipelines/a23607a6-97bc-47bc-b6a2-42d5222132c9)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/127ffb4c-f61f-4f01-b22c-5088e384ebf5) This commit has been deployed to PRODUCTION by [ui-toolchain-load-38c05a76-3c8a-4c4f-93ea-4e526ad5e902-922](https://console.stage1.ng.bluemix.net/devops/pipelines/4c6945d1-457b-4fed-b34d-ec5944dfda6a)


[[Bluemix DevOps]](https://console.ng.bluemix.net/devops/toolchains/4a79de64-012c-41c7-9fcc-062101f9ee45) This commit has been deployed to PRODUCTION by [ui-microservices-toolchain-1488464757526](https://console.ng.bluemix.net/devops/pipelines/a9c39759-2d3b-4f9c-82ae-2081d253ba84)


[[Bluemix DevOps]](https://console.ng.bluemix.net/devops/toolchains/4a79de64-012c-41c7-9fcc-062101f9ee45) This commit has been deployed to STAGING by [catalog-api-microservices-toolchain-1488464757526](https://console.ng.bluemix.net/devops/pipelines/7a24bf47-25ff-4992-89bd-1a51ec7b1f2d)


How can this possibly happen? Add assertions:
```
ut_ad(buf_page_get_io_fix(bpage) == BUF_IO_WRITE);
ut_ad(err == DB_SUCCESS);
```
Surely `buf_page_io_complete()` should not return any error (or do much at all) for writes?


Merged, thanks.


Bluemix Toolchain ([TraceabilityMicroToolchain15](http://localhost:3100/devops/toolchains/a18ab6b7-1b0c-411a-9701-a3132c276342)): This commit has been deployed to Staging_Micro1488465442233 by GitHub ([catalog-api-toolchain-demo-23fev](https://github.com/jauninb/catalog-api-toolchain-demo-23fev))


Nickel votre présentation !  Bravo


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/0763dbf7-0fb7-41bc-8eff-76572cd1d282) This commit has been deployed to STAGING by [ui-ms-duringLoad5-1488465312565](https://console.stage1.ng.bluemix.net/devops/pipelines/0511299d-f00b-4e8b-b2b2-1783791d2543)


see  #4159


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/127ffb4c-f61f-4f01-b22c-5088e384ebf5) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-38c05a76-3c8a-4c4f-93ea-4e526ad5e902-922](https://console.stage1.ng.bluemix.net/devops/pipelines/58a150cd-e7e0-436d-b7ad-81d7b312a253)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/e79286af-c159-46c8-a972-d57bff0a2405) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-4fa0af0b-4ebe-4eb4-9bb0-4433f8749db6-352](https://console.stage1.ng.bluemix.net/devops/pipelines/069b7852-2075-4441-bb08-3327fd865f32)


Use `switch (err)` instead of multiple `if`.


The kafka producer sends messages async. By terminating the system directly they will not be sent.


This commit is the cause of #2763 and has to be has to reconsidered...

Why not using super() anyway??

[guide to using super()](https://rhettinger.wordpress.com/2011/05/26/super-considered-super/)


Bluemix Toolchain: This commit has been deployed to TestEnv


We should throw exception.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/1bfd2379-ddaf-4eab-9343-777bb7f39673) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-129ad0c4-b1f1-4ad1-80a5-66f04084814c-870](https://console.stage1.ng.bluemix.net/devops/pipelines/afdeec56-c723-44db-b3c8-43c728d8b1c8)


Kripi


![](https://github.trello.services/images/mini-trello-icon.png) [derp on narrow cards with long title](https://trello.com/c/2j9YGueQ/140-derp-on-narrow-cards-with-long-title)


Although, I checked dash.js and actually if setting a specific flag, you can stop downloading fragments when paused to save a lot of bandwidth. I'm tempted to bring this in the pause event as well


You're doing it wrong... it should be
```document.querySelector('[data-from="fetcher"]').loaded.then(() => render(json));```


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/0763dbf7-0fb7-41bc-8eff-76572cd1d282) This commit has been deployed to STAGING by [catalog-api-ms-duringLoad5-1488465312565](https://console.stage1.ng.bluemix.net/devops/pipelines/09a6c208-5227-4c96-af61-d404335c1ed5)


We don't need this method here at all. We can instantiate gecko inline as a field. This will remove a need for an abstract method as well (as suggested in the previous review).


or maybe remove, I wonder if it could have been something we needed in the beginning when things was shaky?


感觉念书真好


As mentioned - let's not make it an abstract method. It's only needed in one subtype.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/e79286af-c159-46c8-a972-d57bff0a2405) This commit has been deployed to PRODUCTION by [catalog-api-toolchain-load-4fa0af0b-4ebe-4eb4-9bb0-4433f8749db6-352](https://console.stage1.ng.bluemix.net/devops/pipelines/4b24280c-4f3b-419c-9b6e-4a03f5a7b7e9)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/1bfd2379-ddaf-4eab-9343-777bb7f39673) This commit has been deployed to PRODUCTION by [catalog-api-toolchain-load-129ad0c4-b1f1-4ad1-80a5-66f04084814c-870](https://console.stage1.ng.bluemix.net/devops/pipelines/9fd60ab5-a9ff-4405-9660-c2ec9eae96a8)


LGTM


I only tested this code using GCC5 which defaults to C11. As it is the only function using C99 features I'm fine with this change if it means we don't have to mess with jenkins jobs and build scripts.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/127ffb4c-f61f-4f01-b22c-5088e384ebf5) This commit has been deployed to PRODUCTION by [catalog-api-toolchain-load-38c05a76-3c8a-4c4f-93ea-4e526ad5e902-922](https://console.stage1.ng.bluemix.net/devops/pipelines/a23607a6-97bc-47bc-b6a2-42d5222132c9)


Thanks for your review


Jak mogles sprawdzic bez petli? miales w petli wypisywac na konsole kazdy element


[[Bluemix DevOps]](https://console.ng.bluemix.net/devops/toolchains/4a79de64-012c-41c7-9fcc-062101f9ee45) This commit has been deployed to PRODUCTION by [catalog-api-microservices-toolchain-1488464757526](https://console.ng.bluemix.net/devops/pipelines/7a24bf47-25ff-4992-89bd-1a51ec7b1f2d)


Write a test for this. You will have to use no_checkpoint_start.inc, no_checkpoint_end.inc, innodb_flush_log_at_trx_commit=1, and transaction commit/rollback right before kill_mysqld.inc,


OMG, it happened!
![clap](https://cloud.githubusercontent.com/assets/7834475/23511892/69c4ac26-ff67-11e6-8ed1-ddb6e63a40b0.gif)


`object HTMLParagraphElement` to jest obiekt ElementHTML, jak go sprowadzisz do ciagu tekstowego, zeby pokazac w `<input>` to dostaniesz jego nazwe. Wiec musisz sie przeiterowac w petli po wszystkich elementach i wypisac je na konsole. A na konsoli sprawdzic, jaki property przechowuje tekst, ktorego szukasz


> Illegal string offset 'id'

Actually, the brackets are required at `$mapper->{$var}[$key]` otherwise it becomes something different.


Ty to masz zapłon!

czw., 2 mar 2017, 15:41 użytkownik Maja Miarecki <notifications@github.com>
napisał:

> Jak mogles sprawdzic bez petli? miales w petli wypisywac na konsole kazdy
> element
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/Gangrin/rpg_app/commit/d4fdb7f98cab6dd76cc632e02db08208823916f9#commitcomment-21122528>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AQsI0_9I3yoyWBjHuV1b9x0-2zZKdsWyks5rhtUngaJpZM4MLm5H>
> .
>


Primer modificación


generated by github to ensure the redirection to the host domain.


I don't know if it's a good idea to add URL to a develop branch on github in the comment. It might be better to just reference the file relative `./data.ts`


@gabrie-allaigre looks like I have been duplicated ;)


![](https://github.trello.services/images/mini-trello-icon.png) [2 🍅 index template](https://trello.com/c/lbOcSvDj/15-2-index-template)


it is referencing the core not the demos


![](https://github.trello.services/images/mini-trello-icon.png) [add basic style](https://trello.com/c/QhuO32jX/18-add-basic-style)


Thanks for fixing that one.

Just FYI, this time I spotted the following in https://travis-ci.org/znc/znc/jobs/206811317 at the very end:

> All builds passed!
> cp: cannot stat ‘.travis.ssh’: No such file or directory
> /home/travis/build.sh: line 69: ./.travis-generate-docs.sh: No such file or directory
> /home/travis/build.sh: line 70: ./.travis-coverity-scan.py: No such file or directory
> Done. Your build exited with 0.


Ok, I missed that. But then like the import `phovea_core/src/data` might be the better option ;-)


what size should be filter? I  got it right, that "filter" in TF is the same as "filter_shape" in theano?


A URL não deveria estar  na blibliografia?


念书会担心找不到工作。。。


I'm confused. Can you show where in the commits where this was removed? I don't see anything in my last couple commits where I ever touched almeditable.directive.ts. In fact, I still see this change in the master.


did you re-release 1.6.10? or is the changelog incorrect?


concerning data_format - same question, I don't know which type should be applied


I already changed it but thanks for looking out for me!

Sincerely,
Kellen Schmidt

On Mar 2, 2017 3:08 AM, "Bryce Blanton" <notifications@github.com> wrote:

> You should probably change this password if you haven't already.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/kellenschmidt/URL-Shortener/commit/20f92119971c28c81c856e0cd838c9b80f12bee8#commitcomment-21118357>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AKz27Z8ZlJO6oUL7fjwV9kB_vxkqrK2wks5rhocYgaJpZM4MQuQ4>
> .
>


...which happens because the last Travis build is BUILD_TYPE=tarball and so this command is not run in a Git checkout, but inside of `/tmp/znc-something`.


It looks to me that we should cache the value of `fil_node->space->purpose` before releasing `fil_system->mutex`, because after that point, the tablespace could theoretically be dropped.

On a related note, is `bpage` really safe to dereference here?

How do you know that it is a write operation? How do you know that it is an ibuf operation? That is completely unclear to me. And what kind of errors can `buf_page_io_complete()` return for a write operation?

Please write a test for this. Even though writing tests for error handling is a lot of effort, I think that it really pays off by catching really tricky bugs before they reach our users.


close #25


Was changing names recursively. Adding the interactive option seems to fix it.


By shutting down, async kafka messages are not produced


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2230](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25214&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


is it possible to refactor so that the unzipInTmpDir reuses this?


should I also apply things like "get_status", "get_dim" and etc. like it was done in NetworkCNNLayer.py?


Choose GetMyLocation --> Targets --> Build Phases --> Link Binary with Libraries


[[Bluemix DevOps]](https://console.ng.bluemix.net/devops/toolchains/4a79de64-012c-41c7-9fcc-062101f9ee45) This commit has been deployed to STAGING by [orders-api-microservices-toolchain-1488464757526](https://console.ng.bluemix.net/devops/pipelines/e0787c00-d7d8-407a-927f-0ab93155cfb8)


This function is only used by buf0dump.cc. It does not care whether the operation succeeds. So, please change the return type to `void`.


Although spike maul has no official translation, and google doesn't even translate it, if you put `道钉锤` in google search, you can find related advertisements. So I think it is correct.


as fas as sugartensor should be a method for the current class, I have to add its code in here as "@classmethod...", right?


this is practice purpose


Bootloop?


安裝&設定Laravel Tracy debugger


We already have `DB_CORRUPTION` which I think is good enough.


@emilyashley this PR relies on these changes to the story viewer js, which have been merged into MapStory master: https://github.com/MapStory/mapstory/pull/426/files


Hi @Rich86man. It will be a great honor to receive a pull request with yours changes.


Cherry-picked to ponweist/wannier90@b9cf970d7627fc9dcd4bd1f9f5317f8f3310f8cc.


this is wrong, you don't need to use an arrow function here. It doesn't make any sense.


Tomcat won't be sufficient.

Use full application server instead.

I recommend Wildfly, because on this one the project was tested and deployed.

There is one closed issue https://github.com/grzegorzgajda/dicom-viewer/issues/1

which contains information how to configure it.

Please try to follow it first, and in case of any problems write to me without doubt.


@williammcbroom this makes it compatible with using s3pypi with Python 3.x, right? ... if so, could you please create your fix as PR so that a new s3pypi release could be made available, thanks


You don't need to pass an argument, the Read option is parameter-less


Make the error message more specific by saying that it occurs while loading a buffer pool dump. Or omit the error altogether. I guess we are already issuing some other message for the error? One message is enough.


第二个文件


Hi! There is nothing wrong with being a newbie, we all start somewhere.

The first thing you'll want to do is get a different copy of Python.  Wherever you got your current copy, it wasn't compiled with zlib (compression) support; you'll definitely want that!

What Operating System are you using?


Looks like this line snuck in from debugging.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/a569f5c4-d5a1-4e9a-bc73-66d6a2320898) This commit has been deployed to STAGING by [ui-toolchain-load-5f75664a-b6e3-493c-bde0-63f4b9a2e2e8-466](https://console.stage1.ng.bluemix.net/devops/pipelines/96b38094-9d02-41d0-aed4-d4833b0b4dfd)


Shouldn't this be `SsoOpenid::Urls[:sso_openid][:host]`?


Thanks!


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/f054857b-bee7-4171-8351-83bef58bfb21) This commit has been deployed to STAGING by [ui-toolchain-load-4209bdb4-12ee-447f-9b2e-3ec4ef53c24d-138](https://console.stage1.ng.bluemix.net/devops/pipelines/0acac76b-72ba-42eb-a0b3-925a98371836)


Cherry-picked to ponweist/wannier90@10c462d4e46872b9d22b0b57ec6cff0b4d6f8379.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/bca34445-ccbf-46a4-9ff8-c00545f82d36) This commit has been deployed to STAGING by [ui-toolchain-load-2336925d-8605-4123-aae2-49afa52a7426-485](https://console.stage1.ng.bluemix.net/devops/pipelines/ef516db1-1bba-4214-93c1-5583a38cc947)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/7c5ca64c-616d-4aaa-b2e4-baa7b43998fb) This commit has been deployed to STAGING by [ui-toolchain-load-96321bbd-c051-481d-8149-c663ba8565c7-830](https://console.stage1.ng.bluemix.net/devops/pipelines/ae6a7def-a602-4bb6-a03d-3da424c8257f)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/b365a07d-a3bc-4d68-bea6-2b642b1f8c46) This commit has been deployed to STAGING by [ui-toolchain-load-3964b8e3-4a64-4993-8468-4f975a715eae-685](https://console.stage1.ng.bluemix.net/devops/pipelines/d9bf7e67-285b-496d-9b9b-64a49c47cb66)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/b67452b5-6935-4b62-a5c4-4d2d5ce3ba61) This commit has been deployed to STAGING by [ui-toolchain-load-14c1f72c-1799-42ec-8bae-51d1f9bc5053-229](https://console.stage1.ng.bluemix.net/devops/pipelines/db115f77-222e-470c-a413-74719da9f997)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/f8897edb-a913-432b-9431-9dc6c310c2a9) This commit has been deployed to STAGING by [ui-toolchain-load-dce0ecf1-25ec-4d71-ade2-0ce90ec67612-103](https://console.stage1.ng.bluemix.net/devops/pipelines/13f22b92-2156-4367-8dc8-0a679ac5002f)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/6df26fd8-f7da-4107-9635-2c1942caa1d2) This commit has been deployed to STAGING by [ui-toolchain-load-39e801e5-ced0-4dc9-adc6-36ec9fb90cdf-175](https://console.stage1.ng.bluemix.net/devops/pipelines/acb26f2d-bd66-4ae5-a235-dcca34368b5b)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/0ce680e0-6840-4927-90f2-3dc7b8538cae) This commit has been deployed to STAGING by [ui-toolchain-load-15de213b-2ea2-4a91-bf07-506cf657d001-350](https://console.stage1.ng.bluemix.net/devops/pipelines/b86bb732-e1d2-4872-8baa-51c59424a5a7)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/e5c68325-60fd-44d1-a6d5-a13d23eb04a5) This commit has been deployed to STAGING by [ui-toolchain-load-79fafca8-a188-4fc1-971e-52e3382da63a-388](https://console.stage1.ng.bluemix.net/devops/pipelines/82979e38-bd9d-4a47-864b-3e5ef256eb41)


Search the server error log to demonstrate that some messages are being emitted for the corruption.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/f054857b-bee7-4171-8351-83bef58bfb21) This commit has been deployed to STAGING by [orders-api-toolchain-load-4209bdb4-12ee-447f-9b2e-3ec4ef53c24d-138](https://console.stage1.ng.bluemix.net/devops/pipelines/895aebdd-423b-4bbf-82cd-7b477963191e)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/a569f5c4-d5a1-4e9a-bc73-66d6a2320898) This commit has been deployed to STAGING by [orders-api-toolchain-load-5f75664a-b6e3-493c-bde0-63f4b9a2e2e8-466](https://console.stage1.ng.bluemix.net/devops/pipelines/1dceeeb8-2907-4914-9fba-bfbb425b8ed8)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/b365a07d-a3bc-4d68-bea6-2b642b1f8c46) This commit has been deployed to STAGING by [orders-api-toolchain-load-3964b8e3-4a64-4993-8468-4f975a715eae-685](https://console.stage1.ng.bluemix.net/devops/pipelines/f538d471-b93b-4fc6-9775-de001e9164a8)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/7c5ca64c-616d-4aaa-b2e4-baa7b43998fb) This commit has been deployed to STAGING by [orders-api-toolchain-load-96321bbd-c051-481d-8149-c663ba8565c7-830](https://console.stage1.ng.bluemix.net/devops/pipelines/01dceb14-9bcd-4756-aedc-2bb04b987e9f)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/1303545e-09df-4504-bd6e-ff63af77e0ac) This commit has been deployed to STAGING by [orders-api-toolchain-load-9de75ae5-8ffc-4ffe-8482-e665e2b0f83e-739](https://console.stage1.ng.bluemix.net/devops/pipelines/d8ecb7c4-c612-49c3-9cc7-ae0354ca28f3)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/bca34445-ccbf-46a4-9ff8-c00545f82d36) This commit has been deployed to STAGING by [orders-api-toolchain-load-2336925d-8605-4123-aae2-49afa52a7426-485](https://console.stage1.ng.bluemix.net/devops/pipelines/a414f1e8-3750-4a4b-adaf-99c8c8397b21)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/f8897edb-a913-432b-9431-9dc6c310c2a9) This commit has been deployed to STAGING by [orders-api-toolchain-load-dce0ecf1-25ec-4d71-ade2-0ce90ec67612-103](https://console.stage1.ng.bluemix.net/devops/pipelines/a5f25289-c399-4153-9b62-703a5cc65e82)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/b30464bc-8209-4e11-be71-16aa95ed7229) This commit has been deployed to STAGING by [orders-api-toolchain-load-7ee11a1e-9a2d-483e-b81f-0938690c9416-624](https://console.stage1.ng.bluemix.net/devops/pipelines/d2340189-7515-4292-820f-d5e97b3c08df)


There is much that is unknown in these packets...


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/c65de293-dd38-480b-8910-e8ca1579be55) This commit has been deployed to STAGING by [orders-api-toolchain-load-6a532af1-98a2-4e1d-b904-b55e0111d233-713](https://console.stage1.ng.bluemix.net/devops/pipelines/559012b4-5fe8-455b-b630-e814ad228d08)


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2230](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25214&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:06:17


[[Bluemix DevOps]](https://console.ng.bluemix.net/devops/toolchains/4a79de64-012c-41c7-9fcc-062101f9ee45) This commit has been deployed to PRODUCTION by [orders-api-microservices-toolchain-1488464757526](https://console.ng.bluemix.net/devops/pipelines/e0787c00-d7d8-407a-927f-0ab93155cfb8)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/b30464bc-8209-4e11-be71-16aa95ed7229) This commit has been deployed to STAGING by [ui-toolchain-load-7ee11a1e-9a2d-483e-b81f-0938690c9416-624](https://console.stage1.ng.bluemix.net/devops/pipelines/f6200f2a-4a74-4e99-9ca8-eb06436014c4)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/1303545e-09df-4504-bd6e-ff63af77e0ac) This commit has been deployed to STAGING by [ui-toolchain-load-9de75ae5-8ffc-4ffe-8482-e665e2b0f83e-739](https://console.stage1.ng.bluemix.net/devops/pipelines/a0cce10c-cb12-4bfc-89b9-f3cd479863b9)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/b67452b5-6935-4b62-a5c4-4d2d5ce3ba61) This commit has been deployed to STAGING by [orders-api-toolchain-load-14c1f72c-1799-42ec-8bae-51d1f9bc5053-229](https://console.stage1.ng.bluemix.net/devops/pipelines/2722287d-a6e6-4c28-9fb2-948d91f193c9)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/e5c68325-60fd-44d1-a6d5-a13d23eb04a5) This commit has been deployed to STAGING by [orders-api-toolchain-load-79fafca8-a188-4fc1-971e-52e3382da63a-388](https://console.stage1.ng.bluemix.net/devops/pipelines/c115f398-13e9-4052-9031-a702aec528a8)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/eff7d6e8-8bd5-43ac-85f9-29be87133201) This commit has been deployed to STAGING by [ui-toolchain-load-a9435ae1-b717-40f8-99c9-8ed5cbbc1736-163](https://console.stage1.ng.bluemix.net/devops/pipelines/336ee71a-86ed-4bdd-80cd-0b78b1c7db66)


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.750.e65e8b866425e23ec8b3fc47718069fa7ac9d614](http://build.palaso.org/viewLog.html?buildId=85397&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 938, ignored: 57 Build time: 00:13:19


Bluemix Toolchain: This commit has been deployed to TestEnv


Fix issue #5


W linii 17 ustawiasz `minLength` na `2`, a teraz na `0`. Lepiej od razu ustawić to na `0` i usunąć linie 25 - 27.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/eff7d6e8-8bd5-43ac-85f9-29be87133201) This commit has been deployed to STAGING by [orders-api-toolchain-load-a9435ae1-b717-40f8-99c9-8ed5cbbc1736-163](https://console.stage1.ng.bluemix.net/devops/pipelines/2719461c-98d1-4bab-b5e9-e8203c774a0b)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/1303545e-09df-4504-bd6e-ff63af77e0ac) This commit has been deployed to STAGING by [catalog-api-toolchain-load-9de75ae5-8ffc-4ffe-8482-e665e2b0f83e-739](https://console.stage1.ng.bluemix.net/devops/pipelines/7d94082d-e7a6-4490-835d-13b411fca469)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/f054857b-bee7-4171-8351-83bef58bfb21) This commit has been deployed to STAGING by [catalog-api-toolchain-load-4209bdb4-12ee-447f-9b2e-3ec4ef53c24d-138](https://console.stage1.ng.bluemix.net/devops/pipelines/e72e01e6-2827-42cb-b756-326f3e28f5e7)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/a569f5c4-d5a1-4e9a-bc73-66d6a2320898) This commit has been deployed to STAGING by [catalog-api-toolchain-load-5f75664a-b6e3-493c-bde0-63f4b9a2e2e8-466](https://console.stage1.ng.bluemix.net/devops/pipelines/728cc899-f59b-45ca-a532-19aa5713f8ac)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/7c5ca64c-616d-4aaa-b2e4-baa7b43998fb) This commit has been deployed to STAGING by [catalog-api-toolchain-load-96321bbd-c051-481d-8149-c663ba8565c7-830](https://console.stage1.ng.bluemix.net/devops/pipelines/595b226d-a25c-41bb-be9a-32bf914e96ca)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/b365a07d-a3bc-4d68-bea6-2b642b1f8c46) This commit has been deployed to STAGING by [catalog-api-toolchain-load-3964b8e3-4a64-4993-8468-4f975a715eae-685](https://console.stage1.ng.bluemix.net/devops/pipelines/31db5453-5060-450a-856d-eaf95555e35a)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/bca34445-ccbf-46a4-9ff8-c00545f82d36) This commit has been deployed to STAGING by [catalog-api-toolchain-load-2336925d-8605-4123-aae2-49afa52a7426-485](https://console.stage1.ng.bluemix.net/devops/pipelines/de572c9f-4fa6-43ff-aed9-be927dbdbd9f)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/f8897edb-a913-432b-9431-9dc6c310c2a9) This commit has been deployed to STAGING by [catalog-api-toolchain-load-dce0ecf1-25ec-4d71-ade2-0ce90ec67612-103](https://console.stage1.ng.bluemix.net/devops/pipelines/881eb6c0-fa5b-4525-baf7-176efdd7d066)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/0ce680e0-6840-4927-90f2-3dc7b8538cae) This commit has been deployed to STAGING by [orders-api-toolchain-load-15de213b-2ea2-4a91-bf07-506cf657d001-350](https://console.stage1.ng.bluemix.net/devops/pipelines/b2b1a56a-dfa2-49de-909c-6c41cacc8c3c)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/6df26fd8-f7da-4107-9635-2c1942caa1d2) This commit has been deployed to PRODUCTION by [ui-toolchain-load-39e801e5-ced0-4dc9-adc6-36ec9fb90cdf-175](https://console.stage1.ng.bluemix.net/devops/pipelines/acb26f2d-bd66-4ae5-a235-dcca34368b5b)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/f054857b-bee7-4171-8351-83bef58bfb21) This commit has been deployed to PRODUCTION by [ui-toolchain-load-4209bdb4-12ee-447f-9b2e-3ec4ef53c24d-138](https://console.stage1.ng.bluemix.net/devops/pipelines/0acac76b-72ba-42eb-a0b3-925a98371836)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/6df26fd8-f7da-4107-9635-2c1942caa1d2) This commit has been deployed to STAGING by [catalog-api-toolchain-load-39e801e5-ced0-4dc9-adc6-36ec9fb90cdf-175](https://console.stage1.ng.bluemix.net/devops/pipelines/03c7d069-b400-4509-9844-9c8205da489c)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/b30464bc-8209-4e11-be71-16aa95ed7229) This commit has been deployed to STAGING by [catalog-api-toolchain-load-7ee11a1e-9a2d-483e-b81f-0938690c9416-624](https://console.stage1.ng.bluemix.net/devops/pipelines/d712bf0f-4bc6-4e17-a383-46cbab09e710)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/0ce680e0-6840-4927-90f2-3dc7b8538cae) This commit has been deployed to STAGING by [catalog-api-toolchain-load-15de213b-2ea2-4a91-bf07-506cf657d001-350](https://console.stage1.ng.bluemix.net/devops/pipelines/661d37a5-5921-4653-b329-fef3a22ede0d)


I have no idea how it was done there. Do whatever make sense to do. I'm not even sure what `get_status` or `get_dim` is supposed to do or what you mean.

About the current parameters: Some of them are not clear. You also miss some documentation. E.g., what is `n_features`? What is `filter`? What is `d_row`? Better call `conv_stride` just `stride` or `stride` instead. And what is `pool_size`? Is that the filter size? Then call it `filter_size`. What is `pool_stride`? What is `pool_padding`? What is `mode`? So this layer also does pooling? That is the same as in the Theano layer? What is `factor`? Why do you need `dropout`? Dropout is normally already handled by the base layer. What is `force_sample`?

Basically, get motivated from the corresponding arguments to the corresponding TensorFlow functions (like `tf.nn.conv2d` etc.).

Is this layer supposed to do 2D conv? Or is it also 1D and 3D?


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/c65de293-dd38-480b-8910-e8ca1579be55) This commit has been deployed to PRODUCTION by [ui-toolchain-load-6a532af1-98a2-4e1d-b904-b55e0111d233-713](https://console.stage1.ng.bluemix.net/devops/pipelines/674d9f43-8e5e-4067-a094-6b6857f38f43)


I didn't know https://www.sonarqube.org/ before! Sounds nice! 👍


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/e5c68325-60fd-44d1-a6d5-a13d23eb04a5) This commit has been deployed to PRODUCTION by [ui-toolchain-load-79fafca8-a188-4fc1-971e-52e3382da63a-388](https://console.stage1.ng.bluemix.net/devops/pipelines/82979e38-bd9d-4a47-864b-3e5ef256eb41)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/a569f5c4-d5a1-4e9a-bc73-66d6a2320898) This commit has been deployed to PRODUCTION by [ui-toolchain-load-5f75664a-b6e3-493c-bde0-63f4b9a2e2e8-466](https://console.stage1.ng.bluemix.net/devops/pipelines/96b38094-9d02-41d0-aed4-d4833b0b4dfd)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/bca34445-ccbf-46a4-9ff8-c00545f82d36) This commit has been deployed to PRODUCTION by [ui-toolchain-load-2336925d-8605-4123-aae2-49afa52a7426-485](https://console.stage1.ng.bluemix.net/devops/pipelines/ef516db1-1bba-4214-93c1-5583a38cc947)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/f054857b-bee7-4171-8351-83bef58bfb21) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-4209bdb4-12ee-447f-9b2e-3ec4ef53c24d-138](https://console.stage1.ng.bluemix.net/devops/pipelines/895aebdd-423b-4bbf-82cd-7b477963191e)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/f8897edb-a913-432b-9431-9dc6c310c2a9) This commit has been deployed to PRODUCTION by [ui-toolchain-load-dce0ecf1-25ec-4d71-ade2-0ce90ec67612-103](https://console.stage1.ng.bluemix.net/devops/pipelines/13f22b92-2156-4367-8dc8-0a679ac5002f)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/7c5ca64c-616d-4aaa-b2e4-baa7b43998fb) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-96321bbd-c051-481d-8149-c663ba8565c7-830](https://console.stage1.ng.bluemix.net/devops/pipelines/01dceb14-9bcd-4756-aedc-2bb04b987e9f)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/b365a07d-a3bc-4d68-bea6-2b642b1f8c46) This commit has been deployed to PRODUCTION by [ui-toolchain-load-3964b8e3-4a64-4993-8468-4f975a715eae-685](https://console.stage1.ng.bluemix.net/devops/pipelines/d9bf7e67-285b-496d-9b9b-64a49c47cb66)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/e5c68325-60fd-44d1-a6d5-a13d23eb04a5) This commit has been deployed to STAGING by [catalog-api-toolchain-load-79fafca8-a188-4fc1-971e-52e3382da63a-388](https://console.stage1.ng.bluemix.net/devops/pipelines/e751e008-9633-4350-97a7-b96ca1f6cfdf)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/b67452b5-6935-4b62-a5c4-4d2d5ce3ba61) This commit has been deployed to PRODUCTION by [ui-toolchain-load-14c1f72c-1799-42ec-8bae-51d1f9bc5053-229](https://console.stage1.ng.bluemix.net/devops/pipelines/db115f77-222e-470c-a413-74719da9f997)


I don't know. You should read the documentation. The filter size should be configurable of course.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/1303545e-09df-4504-bd6e-ff63af77e0ac) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-9de75ae5-8ffc-4ffe-8482-e665e2b0f83e-739](https://console.stage1.ng.bluemix.net/devops/pipelines/d8ecb7c4-c612-49c3-9cc7-ae0354ca28f3)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/eff7d6e8-8bd5-43ac-85f9-29be87133201) This commit has been deployed to STAGING by [catalog-api-toolchain-load-a9435ae1-b717-40f8-99c9-8ed5cbbc1736-163](https://console.stage1.ng.bluemix.net/devops/pipelines/34f64bda-ec6e-4462-b039-9df7da7d19d6)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/b365a07d-a3bc-4d68-bea6-2b642b1f8c46) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-3964b8e3-4a64-4993-8468-4f975a715eae-685](https://console.stage1.ng.bluemix.net/devops/pipelines/f538d471-b93b-4fc6-9775-de001e9164a8)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/c65de293-dd38-480b-8910-e8ca1579be55) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-6a532af1-98a2-4e1d-b904-b55e0111d233-713](https://console.stage1.ng.bluemix.net/devops/pipelines/559012b4-5fe8-455b-b630-e814ad228d08)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/a569f5c4-d5a1-4e9a-bc73-66d6a2320898) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-5f75664a-b6e3-493c-bde0-63f4b9a2e2e8-466](https://console.stage1.ng.bluemix.net/devops/pipelines/1dceeeb8-2907-4914-9fba-bfbb425b8ed8)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/f8897edb-a913-432b-9431-9dc6c310c2a9) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-dce0ecf1-25ec-4d71-ade2-0ce90ec67612-103](https://console.stage1.ng.bluemix.net/devops/pipelines/a5f25289-c399-4153-9b62-703a5cc65e82)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/b30464bc-8209-4e11-be71-16aa95ed7229) This commit has been deployed to PRODUCTION by [ui-toolchain-load-7ee11a1e-9a2d-483e-b81f-0938690c9416-624](https://console.stage1.ng.bluemix.net/devops/pipelines/f6200f2a-4a74-4e99-9ca8-eb06436014c4)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/bca34445-ccbf-46a4-9ff8-c00545f82d36) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-2336925d-8605-4123-aae2-49afa52a7426-485](https://console.stage1.ng.bluemix.net/devops/pipelines/a414f1e8-3750-4a4b-adaf-99c8c8397b21)


Whatever data format you expect to get there. Normally it's (batch, time, feature), but you can also get it differently. You can see the related code in other layers. You can also just dimshuffle the data such that you have it in whatever way you want it.


idosch, why do you do that like that?

I must say I don't like it. It seems not intuitive for me that the mlxsw_sp_port_mdb_op will bypass if the mid->refcount is 0. I would have kept that check at the caller.

More specifically, I am currently thinking of implementing multicast_disable flag by removing the FDB entries so it seems like I might need to use that function even when refcount != 1

I will change it, unless you say otherwise.


Cherry-picked to ponweist/wannier90@e08657317af41fff7741e65162f62ed07ee242df.


It's not a list it's an associative array.
(Or object for JS or hash map for Ruby.)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/b30464bc-8209-4e11-be71-16aa95ed7229) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-7ee11a1e-9a2d-483e-b81f-0938690c9416-624](https://console.stage1.ng.bluemix.net/devops/pipelines/d2340189-7515-4292-820f-d5e97b3c08df)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/b365a07d-a3bc-4d68-bea6-2b642b1f8c46) This commit has been deployed to PRODUCTION by [catalog-api-toolchain-load-3964b8e3-4a64-4993-8468-4f975a715eae-685](https://console.stage1.ng.bluemix.net/devops/pipelines/31db5453-5060-450a-856d-eaf95555e35a)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/7c5ca64c-616d-4aaa-b2e4-baa7b43998fb) This commit has been deployed to PRODUCTION by [catalog-api-toolchain-load-96321bbd-c051-481d-8149-c663ba8565c7-830](https://console.stage1.ng.bluemix.net/devops/pipelines/595b226d-a25c-41bb-be9a-32bf914e96ca)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/0ce680e0-6840-4927-90f2-3dc7b8538cae) This commit has been deployed to PRODUCTION by [ui-toolchain-load-15de213b-2ea2-4a91-bf07-506cf657d001-350](https://console.stage1.ng.bluemix.net/devops/pipelines/b86bb732-e1d2-4872-8baa-51c59424a5a7)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/f8897edb-a913-432b-9431-9dc6c310c2a9) This commit has been deployed to PRODUCTION by [catalog-api-toolchain-load-dce0ecf1-25ec-4d71-ade2-0ce90ec67612-103](https://console.stage1.ng.bluemix.net/devops/pipelines/881eb6c0-fa5b-4525-baf7-176efdd7d066)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/0ce680e0-6840-4927-90f2-3dc7b8538cae) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-15de213b-2ea2-4a91-bf07-506cf657d001-350](https://console.stage1.ng.bluemix.net/devops/pipelines/b2b1a56a-dfa2-49de-909c-6c41cacc8c3c)


You should not use or add anything from Sugartensor. You don't need that. Just use TensorFlow.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/a569f5c4-d5a1-4e9a-bc73-66d6a2320898) This commit has been deployed to PRODUCTION by [catalog-api-toolchain-load-5f75664a-b6e3-493c-bde0-63f4b9a2e2e8-466](https://console.stage1.ng.bluemix.net/devops/pipelines/728cc899-f59b-45ca-a532-19aa5713f8ac)


I am not sure I understand... It is possible to refactor the code so that the tmp dir creation is shared between the two flows but then the flows diverge. The require statements are different. Then the rest of the flow can be the same. It don't think it makes sense to mess with exports in the zip flow so there is no good way to make the require statements the same.

What I am envisioning is
- create temp dir
- diverge up to the computation of `userScriptMain`
- shared code

Makes sense?


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/eff7d6e8-8bd5-43ac-85f9-29be87133201) This commit has been deployed to PRODUCTION by [ui-toolchain-load-a9435ae1-b717-40f8-99c9-8ed5cbbc1736-163](https://console.stage1.ng.bluemix.net/devops/pipelines/336ee71a-86ed-4bdd-80cd-0b78b1c7db66)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/e5c68325-60fd-44d1-a6d5-a13d23eb04a5) This commit has been deployed to PRODUCTION by [orders-api-toolchain-load-79fafca8-a188-4fc1-971e-52e3382da63a-388](https://console.stage1.ng.bluemix.net/devops/pipelines/c115f398-13e9-4052-9031-a702aec528a8)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/bca34445-ccbf-46a4-9ff8-c00545f82d36) This commit has been deployed to PRODUCTION by [catalog-api-toolchain-load-2336925d-8605-4123-aae2-49afa52a7426-485](https://console.stage1.ng.bluemix.net/devops/pipelines/de572c9f-4fa6-43ff-aed9-be927dbdbd9f)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/f054857b-bee7-4171-8351-83bef58bfb21) This commit has been deployed to PRODUCTION by [catalog-api-toolchain-load-4209bdb4-12ee-447f-9b2e-3ec4ef53c24d-138](https://console.stage1.ng.bluemix.net/devops/pipelines/e72e01e6-2827-42cb-b756-326f3e28f5e7)


TravisCI is not the most appropriate solution to analyze a .NET solution because they don't have Windows environments. As mentioned in https://about.sonarqube.com/get-started/, VSTS is better shaped to help you on that matter. Or you can do manual configuration on AppVeyor.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/6df26fd8-f7da-4107-9635-2c1942caa1d2) This commit has been deployed to PRODUCTION by [catalog-api-toolchain-load-39e801e5-ced0-4dc9-adc6-36ec9fb90cdf-175](https://console.stage1.ng.bluemix.net/devops/pipelines/03c7d069-b400-4509-9844-9c8205da489c)