# Pre-work - *Tip Calculator*

**TipCalculator** is a tip calculator application for iOS.

Submitted by: **Qian Wang**

Time spent: **2** hours spent in total

## User Stories

The following **required** functionality is complete:

* [ X] User can enter a bill amount, choose a tip percentage, and see the tip and total values.
* [x ] Settings page to change the default tip percentage.

The following **optional** features are implemented:
* [ ] UI animations
* [ ] Remembering the bill amount across app restarts (if <10mins)
* [ ] Using locale-specific currency and currency thousands separators.
* [ ] Making sure the keyboard is always visible and the bill amount is always the first responder. This way the user doesn't have to tap anywhere to use this app. Just launch the app and start typing.

The following **additional** features are implemented:

- [ ] List anything else that you can get done to improve the app functionality!

## Video Walkthrough

Here's a walkthrough of implemented user stories:

<img src='http://i.imgur.com/link/to/your/gif/file.gif' title='Video Walkthrough' width='' alt='Video Walkthrough' />

GIF created with [LiceCap](http://www.cockos.com/licecap/).

## Notes

Describe any challenges encountered while building the app.

## License

    Copyright [yyyy] [name of copyright owner]

    Licensed under the Apache License, Version 2.0 (the "License");
    you may not use this file except in compliance with the License.
    You may obtain a copy of the License at

        http://www.apache.org/licenses/LICENSE-2.0

    Unless required by applicable law or agreed to in writing, software
    distributed under the License is distributed on an "AS IS" BASIS,
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
    limitations under the License.


Real Pro.


Why did you do so? It cancels the changes made by me in https://github.com/Netflix/EVCache/commit/98caa2df0138900abad7bf5e8535d6c2e9d5de2f under https://github.com/Netflix/EVCache/pull/28


fixed in https://github.com/opentomb/OpenTomb/commit/dfc4682ef1f8d2235b487e945b5eec874d700475


Copyright Infringement ^^^^^^^^^


Even bigger Copyright Infringement ^^^^^^^^^


Fbpolat.tk


... 做成个文件, 然后getClass().getResource读取吧...


Get the error after starting
loadfile: failed to load C:\maxima-current\wxMaxima\data\wxmathml.lisp
 -- an error. To debug this try: debugmode(true);
loadfile: failed to load C:\maxima-current\wxMaxima\data\wxmathml.lisp
 -- an error. To debug this try: debugmode(true);
After commenting 75 line error has gone.
Maxima branch_5_39_base_131_g65f0aa5_dirty http://maxima.sourceforge.net
using Lisp CLISP 2.49 (2010-07-07)


Thank you very much for the help!


@ryanflorence This branch resolves double-dot relative paths using parent `<Route>`s. I wanted to leave this here in case you wanted to test if this does what you were thinking, but I didn't want to open yet another PR until I knew that this was the approach to relative links that you wanted to take.

This combines both resolving `<Route>`s and `<Link>`s because you had said that you didn't want to add the former without the latter.

I'm sure that you will have a number of questions, but I tried to leave comments explaining most of what is going on. There are still a few small changes that I will probably push, but I would call this a nearly-complete solution.

A few pieces of note:

1. A pathless `<Route>` will return its parent's `match` instead of creating a new object. (Pathless `<Route>`s whose parent `match` is null _do_ create a new `match` object).
2. I keep track of the parent routes' urls in an array. I don't know of a reason why we would care about more than just the parent match urls, so this should be fine for resolving. An alternative approach would be to just have each `match` just keep a reference to its parent `match`. I'll probably test that and see if I prefer one way or the other.
3. I've come to the conclusion that if the parent `match` is `null`, then we should not attempt to resolve a relative path. A warning can be included for people who run into an issue with this, but there just is no good way to try to guess how to resolve when the parent `match` is `null`.


@omaralbeik Looking good!


Got the new_contact_path through "rails route"


ここにコメントを書くことができます。


hi


CBECC-8-5-PriAirCondgSys (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2400 of 2420 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.17%25-yellow.png)


please remember merge to alpha branch.


This line is added from GITHUB


published in version 0.0.2


A few minutes of usage seems fine (17.03 version).


👍  nice


modif distante


przedział za pomocą int


gggg


int zamiast string


int zamiast stringów


修改了几个js的路径


w trakcie ładowania


gdy błąd


@anandkumarpatel Oh, sorry about that. 🙈


It is not a replacement but a refinement of the function. If you were using it in a recommended way then you should not run into an issue. However, there is an issue with Angular 2.x which currently is coupled with Typescript 2.0.x (the latest one is already considered a legacy version).

See the discussions: https://github.com/DefinitelyTyped/DefinitelyTyped/issues/14569, https://github.com/DefinitelyTyped/DefinitelyTyped/issues/14579, https://github.com/DefinitelyTyped/DefinitelyTyped/issues/14811

See the merged PR for Angular 4.x:
https://github.com/angular/angular/pull/13655

I understood the latter discussion right (in the PR or one of the related issues), they accept PRs that backport TypeScript 2.1.x support to Angular 2.x.


jest img :)


nazwa zmiennej - URL


New line


rebuild


+1 for the removal of `__declspec(dllexport)`


javaEE项目peldem的部分代码，使用ssm框架开发


For ease of navigation and convenience's sake, we could link to the conventions (https://github.com/oss-generic/process/blob/master/docs/CodingStandards.md)


wydzielone funkcja


brand new nazwa funkcji ;)


@omaralbeik I have some questions about the Array extensions:

1. Removing `push(element:)` and `pop()`
- `push(element:)` is just another name for append, is that the reason why we're using it?
- Swift already has a `popLast()` method which does the same as `pop()`

I'm for removing them unless they're there for a reason.

2. Is there a reason why of `shuffled` and `withoutDuplicates` are properties and `shuffle()` and `removeDuplicates()` are methods?

- I prefer copying the standard library and their practice of `sort()` and `sorted()`
- I also think it's counter-intuitive that these are properties yet they're not modifying the original instance.

3. Possibly rename:
-  `removeDuplicates()` to `unique()`
- `withoutDuplicates` to `uniqueElements()`

I've been considering adding a counterpart to this method:
- `common()` && `commonElements()`

I'm still thinking about this, I may like removeDuplicates/withoutDuplicates better.


zmiana nazw


testing GH for myself


just test


<link href="http://www.zotero.org/styles/vancouver" rel="self"/>


troll


@LukeTowers The relative link does not seem to work. Could you please fix it?


Oa, xin lỗi anh giờ check mail này mới biết anh có comment.
Class 'code' em xem thì đúng là trường hợp trong markdown anh viết là inline-text hay block thì nó đều nhận là inline hết. Hình như là bug của jekyll thì phải (https://github.com/jekyll/jekyll/issues/3724)
Để em thử sửa ở local xem có được không


Thanks for making the change, but the script shouldn't be blocked, otherwise it causes the delay I mentioned in #71


CBECC-8-5-PriAirCondgSys (kbenne) - x86_64-MacOS-10.10-clang: OK (2386 of 2420 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.6%25-yellow.png)


The sessions is passed here but not used. Still this.sessions is used. Am I missing something?


rly?


Correcting  for https://github.com/rails/rails/issues/28278


Have you tested it?


None of this actually works it seems. Github acts as if it's ignoring the .gitconfig/.gitattributes thing entirely.
I've posted my question on stackoverflow: https://stackoverflow.com/questions/42593395/github-ignore-downstream-configuration-files-in-pull-requests

If it's not obvious, I'm trying to create a simple way of upstream/downstream work after which I can turn Spring-Chobby into a generic version and support different forks (ZK, Evo, BA, etc.) which work by just changing one config file. This ignores the problem independent work with regards to version handling (since commits with VERSION tag produce stables), but for now I'm content with leaving that completely in the hands of ZK.


Не стоит) он берет инфу с информанта)))


From a speed perspective, it definitely makes sense to split the tests.


who are you ?


Beyond1Airloop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1877 of 1878 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.44%25-green.png)


Beyond1Airloop (mjwitte) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


fox lol


mọi người xem cơ sở dữ liệu này đi nhé!


Haha @kwelch I'm experiencing that sadness right now as i just updated to beta7. Breaking it out to render right now, my heart hurts. :P I didn't realize it was undocumented.


math random?


Hello @Asgaros,
Excellent
But...
http://site.ru/forum/?view=thread&id=3&part=1 looks like:
<link rel="canonical" href="http://test.yworld.ru/forum/?view=thread&id=3&part=1" />

And:
http://site.ru/forum/?view=thread&id=3  equal to http://site.ru/forum/?view=thread&id=3&part=1

http://site.ru/forum/?view=thread&id=3&part=1 - The double page and it should be excluded from the rel="canonical"

two options:
1. Remove these pages from the code
2. robots.txt add
Disallow: /*part=1$
Add to FAQ


Same as math_number.


oops


On my machine the interactive content is not interactive. Maybe this script could be useful ^^


额，也可以，下次再添加的时候改吧


but they should probably both be fixed :)


WTF?


Why names are differents?


Good idea. Please use the 'review' feature to add comments. Comments added to commits tend to get lost.


删除多余代码


Why you have removed www links from voxel export dialog? This information was well visible for users.


spelling


Olá @neburpedrosa. O acorde original estava corretamente introduzido com a divisão das silabas:
vi\[D]ver

qual a razão para mudar?


百度前端技术学院/小薇学院任务一


Part of fix for #107


I don't agree here. We can use Copyright statement together with GPL licence
https://www.gnu.org/licenses/gpl-howto.en.html
Stanisław Adaszewski adapted PyMCubes code to work with distance estimation algorithm. He is an author of this code even if it's based on another code. Under referenced link there was further reference to PyMCubes.


What about 3PO's Backtrace? http://j.mp/2mXI74Z


I don't understand the rationale for this change. Now when the user clicks on `Julia`, which appears in the first paragraph of the homepage, s/he gets pointed to... the homepage!


L'image fait 1.5MB! En 3G, il faut poireauter combien de temps pour télécharger 1.5MB?

Enlevez-la, vous gagnez tout et ne perdez rien.


this is fine , go ahead


Final Commit untuk fix print langsung setelah penambahan penjualan


这个项目废了，别看了吧...


![](https://github.trello.services/images/mini-trello-icon.png) [StaticBase és a leszármaztatott osztályok váza](https://trello.com/c/Nryn9FTr/17-staticbase-es-a-leszarmaztatott-osztalyok-vaza)


![](https://github.trello.services/images/mini-trello-icon.png) [DynamicBase és a leszármaztatott osztályok váza](https://trello.com/c/em8E8UWF/18-dynamicbase-es-a-leszarmaztatott-osztalyok-vaza)


This is. Just. A try


rollback


v0.1* Whoops :P


I agree! I just cherry-picked this commit and two others into the backport branch. Hope it worked - it was a bit messy :-)


Actually both `OLS` and `add_constant` are in `statsmodels.api`.

  - https://github.com/statsmodels/statsmodels/blob/master/examples/notebooks/ols.ipynb

The confusing trick is what the *statsmodels* examples/people do: `import statsmodels.api as sm`. Something else would have been clearer, for example: `import statsmodels.api as smapi`

Although they are probably reachable over several different imports.


Needs a publisher ID, I'll send you mine if you ask me. I just didn't want to post mine on github


Corrected (also in the docstrings)


See below


Added missing import (which was in the original samples ... and got lost in translation)


I *merged it* this time. :smile:


Maybe better copy this function to https://github.com/dragome/dragome-sdk/tree/master/dragome-js-jre/src/main/java/com/dragome/utils and rename something like "convertStringValueToObjectByObjectClass"


Right. GRmbl. I really thought I checked that not only twice, but thrice.


We did indeed 😃


agree, there are some refactoring pending like this one, mainly cause conversion functions like this are used in many places


Commented code in VCS?


This would have been true... if you had changed every $sounds with $this->sounds to save it as a class variable.


I think you should consider using some static factory methods like ParserNode.openParen()


![](https://github.trello.services/images/mini-trello-icon.png) [Idő kezelés implementálása](https://trello.com/c/ReHJsAxe/9-ido-kezeles-implementalasa)


Unused portal 1 camera skins? Huh i never knew there was unused camera skins.


Adding overload of train (considering weights)


Placing these types of throw/return on the next line is arguably since there can be mismatch with curly brase version {...}. Better place this on the same line.


I thought you can't commit directly on github.


@DavidLP I guess something like XyTab.update_options() would be nice to re-read the options and re-load the respective tab, right?


Matplotlib snuck in again :-0


It's one way to show that Julia can do recursion well?


CBECC-8-5-PriAirCondgSys (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2354 of 2420 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.27%25-yellow.png)


There is definitely something wrong with your architecture if you should write code like this


for future, please follow commit message format and make commit in separate branch :)


What exactly does this test?


Thanks!


This is great idea to use special exceptions for different stages of compiling


close #12


What about null fields? This is going to be valid state as well?


mdr le nom du commit était ONE


These comments are useless since they are repeat body method


There aren't, I accidentally included the code to let it swap to the Portal 2 dirty skin, so it was loading both P2 skins even though it can't ever use them.


We have a connect method in the helper class, then why we're creating the connection here? Usually, we instantiate the helper once and then use it. Wouldn't be nice if we could initialize the connection in the connect method and assign null to the connection variable in the disconnect method. So that when the connect method is called again, we can create a new connection. This way, we would be able to utilize the same helper instance.


Better return on the same line


Several methods have common structure, extract method


CBECC-8-5-PriAirCondgSys (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png)


Yeah, for now you need to symlink it in from the Marvin32 repo.

https://github.com/floodyberry/Marvin32/blob/master/Marvin32.c

Same for the beagle hash stuff.

Yves

On 4 March 2017 at 00:15, Damian Gryski <notifications@github.com> wrote:

> This is a symlink and not the actual file.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/demerphq/smhasher/commit/6e2211824dcb9be2949ebe6272de6cc1f12932e1#commitcomment-21147682>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAGex7Q-gQat6UbSk_zCQiBorFMD-ChUks5riJ73gaJpZM4MS2w_>
> .
>

--
perl -Mre=debug -e "/just|another|perl|hacker/"


There are a lot of tokens.Lookahead().Tag uses, maybe you can use separate method like LookaheadTag()


To read about Julia you must first read about Julia.


It's for https://github.com/Kademi/keditor/issues/44


1. push and pop are here because many js developers are used to that naming convention, do you suggest to remove them?
2. I prefer to use computed properties if method doesn't have any parameters, I think Apple Swift 3 API design guide lines suggest that also, but not sure.
3. I agree with you, will update them in this release

Areas of focus in 1.6.3:
- Refactor Array and Collection extensions
- Improve String extensions performance
- Improve Date extensions performance
- Remove duplicated extensions in Double, Float and Int extensions to Integer and FloatingPoint extensions
- New macOS extensions
- New Dictionary extensions

Do you think we should add anything else in this release?


CBECC-8-5 (kbenne) - i386-Windows-7-VisualStudio-12: OK (2403 of 2420 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.3%25-yellow.png)


This should not have been deleted.


CBECC-8-5 (kbenne) - x86_64-MacOS-10.10-clang: OK (2386 of 2420 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.6%25-yellow.png)


Thanks @readbeyond!


Наверное всте таки лучше использовать термин отрезок вместо прямой. Не очень понятно, зачем внутри окружности держать отрезок - достаточно радиуса


一些IDE的文件和文件夹， 以及build会产生的target文件夹


peter老师， <LeftNav />这个组件在material ui 0.15.0-beta.1中被改成了<Drawer>
[LeftNav] Rename to Drawer (#3799)


@lilydjwg 这个auto check github tags的功能能不能交给nvchecker实现呢？
叫github_tag什么的。。


Another question is if we should generate `test/blog_test.exs` for the context test or `test/blog/blog_test.exs`. But generally I am ok with namespacing under `my_app` in `test`.


thanks


@hadley is there any reason for passing `con` through as named argument but not `query` (or just calling `NextMethod()` with no named arguments? I'm finding this breaks a lot of dplyr functionality in RSQLServer. I think this is root of https://github.com/imanuelcostigan/RSQLServer/issues/142 and this causes RSQLServer test cases to fail. If I interrupt execution in `sql_render.tbl_sql` and execute `NextMethod()` rather than `NextMethod(con = con)` everything works fine, otherwise error is thrown.


使用版型 => html/LTR/vertical-menu-template/dashboard-ecommerce.html


Remove empty helpers


Missing top-level module documentation comment.


Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem `pronto-flay` should appear before `pronto-rubocop`.


Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem `pronto-jshint` should appear before `pronto-rails_best_practices`.


Freeze mutable objects assigned to constants.


Prefer single-quoted strings when you don't need string interpolation or special symbols.


Try it with hud_scale 0.7


Some background (pun intended) for you @NejcZdovc 😄

The edit above was made to the Brave extension's manifest. When Muon boots up, it loads browser-laptop and then chrome extensions (via this file):
- [Brave extension](https://github.com/brave/browser-laptop/blob/210a328c6f463c6156a90d9eb5e1b5ab56d5d723/app/extensions.js#L409). The source for this is under `app/extensions/brave/`.
- [Sync (new to 0.13.5)](https://github.com/brave/browser-laptop/blob/210a328c6f463c6156a90d9eb5e1b5ab56d5d723/app/extensions.js#L411)
- [WebTorrent](https://github.com/brave/browser-laptop/blob/210a328c6f463c6156a90d9eb5e1b5ab56d5d723/app/extensions.js#L414)

and of course PDF.js and the password manager extensions.

The extension manifest includes a section for [background pages](https://developer.chrome.com/extensions/event_pages) (or when persistence is specified, it's called an event page).  In this case, we're telling the Brave extension to load [idleHandler.js](https://github.com/brave/browser-laptop/blob/210a328c6f463c6156a90d9eb5e1b5ab56d5d723/app/extensions/brave/content/scripts/idleHandler.js).  This script (when loaded) will check if user is idle every 15 minutes. If so, it'll dispatch the `APP_IDLE_STATE_CHANGED` event.

With `persistent: false`, this script was never being loaded and executed. When set to true, it would load and fire the event when idle. I tested by setting the interval to the minimum value allowed (15 - which is 15 seconds).


Ok method is great.


In Linux current 'compiled' form, mcedit.py is not the main program but is imported by a 'bootstrap' file.

The file will be reloaded in subprocesses only if the subprocess code imports the file.
Subprocessing some funtions of the program will be great and will accelerate some parts, but this file shall stay the 'main' process from wich child processes are created/handled.

Anyway, I'll have a look to the bootstrping code for bundles on Linux and try to adapt it.


And more comments


My opinion of server time offset settings.

Server time offset is to used to manual override. How abt like this.

All automatic unless override is on. Make a checkbox?


1. Ok, that makes sense but I think we should avoid functionality that's a duplicate of the
Standard Library.

For example, autocomplete will show pop() and popLast() and I think this could:
a) Confuse some people into thinking they are different
b) Lead to people not being consistent in which they use throughout their program.

2. I'm fine with that as long as we remain consistent. They should both be properties or both methods.

However, I do like this guide by Kotlin on when to use each:
https://kotlinlang.org/docs/reference/coding-conventions.html#functions-vs-properties
I think other places a property would be ideal but since we are modifying a collection this computationally expensive functionality.

3. Nothing new to add.

** Next release **
I'm trying to re-think the Array, Dictionary, and Collection Extensions and add Sequence Extensions so we can try to share as many extensions as possible throughout related types.
(which is the reason I'm asking for your thoughts on the current API)

4. I do need to improve the `shuffle()` / `shuffled()` methods to use the Fisher-Yates algorithm

(will make our friend happy)


Why not puting the custom DNS in /etc/resolv.conf.head actually?
Tail is a fallback built-into the system not nececiting user intervention.
Under normal operation resolv.conf gets info through dhcp (with .tail as fall-back)
Entry of eventual custom DNS, would be pre-appended with .head, taking priority on anything.

Makes sense?


should these definitions be in base?


import OnInit from @angular/core for components


Created multidev environment [ci-example-d8-composer#ci-423](https://dashboard.pantheon.io/sites/c401fd14-f745-4e51-9af2-f30b45146a0c#ci-423).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-423-ci-example-d8-composer.pantheonsite.io/)


Need to fix tests now that OperationModel extends DigDogOperationModel


It'd be nice, but there's a clash of meaning between `trues(A)` and `trues(-4:10)`.  https://github.com/alsam/OffsetArrays.jl/pull/12


Top notch copy-paste 👍


On 4 March 2017 at 00:08, Damian Gryski <notifications@github.com> wrote:

> The define is called ROTR but calls ROTL instead.
>
>
> Fixed in c6ba014c6bae27c1fd67ee71663f375f2091cc63.

Thanks for the eagle eyes Damian!

Yves


CBECC-8-5 (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2352 of 2420 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.19%25-yellow.png)


Great! Will this affect http.sys servers?


Hi, I've seen you forked the repo to make this very single change. Is this an issue when installing the package from PyPI?

If yes, would you mind to [contribute this change](https://github.com/organice/djangocms-maps/pulls) with a PR? Thank you!


This patch broke the build in Factory/Tumbleweed. See here:
https://build.opensuse.org/package/show/openSUSE:Factory/ghc-cmark


This is a bit confusing. Is S1 supposed to be installed on the same box as M1 or C1? Should there be three sentinels in this example (one on each client box) or five (one on the master and replica boxes as well)?


Thanks! @amatsuda


CBECC-8-5 (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png)


@petronny 你把 nvchecker 的结果填在 source 里边不就好了么？nvchecker 得到的版本号在 _G.newver 里。


IMO It's better to call the `WriteBatch::delete_range()` without specifying the default cf name.


Early review: why the extra newline?


Bug solved : Never bind reference to temp object.


Early review: `s1, s2, s3 string` is the same thing.


nit: comments should either be short things that aren't capitalized (and don't end with a period) or they should have both. Please choose :)


extra comment?


原来如此。。


This is a symptom of a limitation in Sulong (exactly as it says; 'Sulong can't store a Truffle object in a native memory address'). Catch me online some time and I will explain how to pin the problem down and then work around it.


Replaces C-style code with std::vector for automated memory management, need to do some benchmark tests for efficiency.


TeamCity NEventStore :: Core :: Build [Build 6.0.0-featute-dotnetcore-tests.52](http://build.prxm.it:8813/viewLog.html?buildId=3714&buildTypeId=NEventStore_CI&guest=1) outcome was **FAILURE**
Summary: Error running GitVersion Build time: 00:00:49


@mittorn why console font scale should be affected by hud_scale?


Freeze mutable objects assigned to constants.


I am not familiar with VUE, I added a simple method to moquilib.js and made text-line support delay in html render mode. maybe VUE mode can use the same generic debounce function.

> 在 2017年3月4日，上午10:01，David E. Jones <notifications@github.com> 写道：
>
> I added a debouncer in the vuet (WebrootVue.js) stuff, but haven't yet in the html render mode stuff. I'd like to avoid as many dependencies as possible, we already have way more than I'd prefer for all the fancy UI widget libraries, and a debouncer is fairly easy to implement without using another library. Anyway, the vuet approach could be used in the JS for the html render mode, or a bit of a variation on it, it's a bit more of a pain there.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.
>


We were experimenting with alpha releases for the JavaScript, but realized yesterday we don't have a good story for the Python side, because the alpha names are incompatible between npm and pypi.  However, we are about to sever the link between the python and npm versions in https://github.com/jupyterlab/jupyterlab/issues/1773, while I'll be doing early next week.


It's not. Thought we could make the var protected and then  make an API


Hi,
There are some issues i found in this search-autocomplete file. If we use this fie to our store.
1)I want to reduce the size of the search bar in design-3 and also search results will come in one page.
2) In our theme all search results come in drop-down list instead of this we want all search results in one page.
3) If i search anything in search bar no results found there and blank page appear.
can you please let me know. How can i solve this problems through code.

Thanks& Regards
Chaithanya


Yes, this is a but in rpmlint: https://bugzilla.suse.com/show_bug.cgi?id=1027577


'dataType' ^


I don't think rectangular footprints are supported. I didn't test though.


CBECC-8-5 (kbenne) - Win64-Windows-7-VisualStudio-12: Tests Failed (2155 of 2420 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-89.05%25-red.png)


Remove whitespace


Modificado de acordo com o solicitado no uri judge.


EP-8-7 (kbenne) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


EP-8-7 (kbenne) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


develop (macumber) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


Remove empty helpers


Missing top-level module documentation comment.


develop (macumber) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


Добавь .gitignore. В git не должно быть привязки к среде разработки.


typo: `DataType`
We can use `shortid` again here. :)


Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem `pronto-flay` should appear before `pronto-rubocop`.


Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem `pronto-jshint` should appear before `pronto-rails_best_practices`.


Freeze mutable objects assigned to constants.


ok, i am trying.


There are still references to RFC 0000 in other places:
https://github.com/maidsafe/rfcs/blob/master/text/0002-name-service/0002-name-service.md#detailed-design
https://safenetwork.wiki/en/RFCs#0000-Unified-structured-data


 ALLOW_WORLD_READABLE_TMPFILES = get_config(p, DEFAULTS, 'allow_world_readable_tmpfiles', None, False, value_type='boolean')
 ALLOW_WORLD_READABLE_TMPFILES = get_config(p, DEFAULTS, 'allow_world_readable_tmpfiles', None, False, value_type='boolean')

 # selinux
 # selinux
-DEFAULT_SELINUX_SPECIAL_FS = get_config(p, 'selinux', 'special_context_filesystems', None, 'fuse, nfs, vboxsf, ramfs', value_type='list')
+DEFAULT_SELINUX_SPECIAL_FS = get_config(p, 'selinux', 'special_context_filesystems', None, 'fuse, nfs, vboxsf, ramfs, 9p', value_type='list')
 DEFAULT_LIBVIRT_LXC_NOSECLABEL = get_config(p, 'selinux', 'libvirt_lxc_noseclabel', 'LIBVIRT_LXC_NOSECLABEL', Fals#


it is right


ok


Hello François,

I have been an ELKS contributor for 2 years now, and I am currently looking backward at all the branches that were not merged by Jody in the master, to see if they contain some valuable stuff that is worth to be considered for next versions.

It looks like you started an interesting work here, related to scheduling. Could you please explain a bit what this consist of ?

MFLD


This will fail if git is not installed!

Taking action because a .git folder exists and running git is 2 different things. You version now has a requirement of git being installed whenever the .git folder exists. Not good.


And I aggree with @buddhi1980 regarding the change in mesh_export_dialog.ui. It should include a reference to the project of @sadaszewski, not just "Powered by PyMCubes". PyMCubes is just a small part. At most, it could include references to both projects.


I had discussed with Taimoor about the unnecessary variable `boolean dbExists`, when we could use directly the method `isDBExists()` .... what do you think Arek, would now be the right time for this nano-refactoring?


Noting here the ubuntu/window package names got mixed (ie:  ubuntu <--> windows), however they are *same* binary file.   Interestingly local commit shows proper **rename,** however didn't preserve during push/merge.

*Local commit*
```
5 files changed, 0 insertions(+), 0 deletions(-)
 rename .../{2.4-add-on-artik-cloud-macos-64.zip => 2.4-add-on-artik-cloud-2.0.0-macos-64.zip} (100%)
 rename .../{2.4-add-on-artik-cloud-ubuntu-32.zip => 2.4-add-on-artik-cloud-2.0.0-ubuntu-32.zip} (100%)
 rename .../{2.4-add-on-artik-cloud-ubuntu-64.zip => 2.4-add-on-artik-cloud-2.0.0-ubuntu-64.zip} (100%)
 rename .../{2.4-add-on-artik-cloud-windows-32.zip => 2.4-add-on-artik-cloud-2.0.0-windows-32.zip} (100%)
 rename .../{2.4-add-on-artik-cloud-windows-64.zip => 2.4-add-on-artik-cloud-2.0.0-windows-64.zip} (100%)
```

*After*  //  note that last 4 binaries are same, filenames mixed during push
```
BIN   ...oud-SDKs/binary/{2.4-add-on-artik-cloud-macos-64.zip → 2.4-add-on-artik-cloud-2.0.0-macos-64.zip}
BIN  ...-SDKs/binary/{2.4-add-on-artik-cloud-windows-64.zip → 2.4-add-on-artik-cloud-2.0.0-ubuntu-32.zip}
BIN  ...-SDKs/binary/{2.4-add-on-artik-cloud-windows-32.zip → 2.4-add-on-artik-cloud-2.0.0-ubuntu-64.zip}
BIN  ...-SDKs/binary/{2.4-add-on-artik-cloud-ubuntu-64.zip → 2.4-add-on-artik-cloud-2.0.0-windows-32.zip}
BIN  ...-SDKs/binary/{2.4-add-on-artik-cloud-ubuntu-32.zip → 2.4-add-on-artik-cloud-2.0.0-windows-64.zip}
```

```
MD5 (2.4-add-on-artik-cloud-2.0.0-macos-64.zip) = 8305870ccb3ba56ee362653a5a904bcd
MD5 (2.4-add-on-artik-cloud-2.0.0-ubuntu-32.zip) = e6abd2eb0cf2f8ed037f31bcc82e2b8e
MD5 (2.4-add-on-artik-cloud-2.0.0-ubuntu-64.zip) = e6abd2eb0cf2f8ed037f31bcc82e2b8e
MD5 (2.4-add-on-artik-cloud-2.0.0-windows-32.zip) = e6abd2eb0cf2f8ed037f31bcc82e2b8e
MD5 (2.4-add-on-artik-cloud-2.0.0-windows-64.zip) = e6abd2eb0cf2f8ed037f31bcc82e2b8e
```


Смотри, тут идёт нарушение принципа разделения логики view и presenter.
View принимает событие и сразу же на него реагирует.
У нас же View лишь прослойка, которая сообщает о всех событиях презентеру. А он уже решает, что с этим делать.

Т.е. должно было быть так:
1) ты навешиваешь листенера на кнопку
2) При клике вызывается метод onRequestNameButtonClick у presenter
3) Презентер в этом методе вызывает метод requestName() у view
4) Внутри этого метода уже вызывается intent

В первом приближении кажется, что это какие-то бесполезные излишки.
Во-первых, это правда :-)
Во-вторых, благодаря LiveTemplates время тратить на этот boilerplate code не приходится. Он сам генерируется
В-третьих, это увеличение сложности архитектуры направлено на гибкость для будущих изменений.
В-четвертых, благодаря StateStrategy реакция на действия пользователя сохраняется при повороте устройства, например. В случае с открытием другой активити это неважно. Но если бы это было связано с изменением UI, то это бы было актуально.


yes


Awesome! Managed a first PR, internet did not explode.
Did not even see there was a dev branch - where work is done. Cool.


Опять же надо было сделать связь с презентером, а не сразу исполнение


Created two files that will display a progress bars.  The first is for the delay before the test begins. The second is to display to progress of the test.  Changes to configure test page and test is running page were to make them work with the two new files.


+market.tabs.offerBook=Offer boook

booooo :)


I guess *technically* we should add a `DataType` variant for this :p


Я бы тут поставил OneExecutionStrategy.
В нашем случае вызов происходит мгновенно после клика. Но если логика в презентере изменится, и метод будет вызываться с задержкой. А если он будет вызван во время поворота экрана, то ничего не произойдёт


need to fix clean-up - will commit again.


I ee wat u do here 3>


Nope. `toString` should give its properties/area


The problem is the paypal plugin uses the paypal sdk that requires SDK 16, but the plugin doesn't set the minSDK to 16, neither documents that minimum 16 is needed for the plugin.
You can add this to your config.xml to set the min SDK to 16 `<preference name="android-minSdkVersion" value="16" />`


use proper parameter names please


Typo: writtern to written


this might be a bit verbose. i would have been ok with rectangle inheriting just an edged shape


you're not using inheritance here. if you build `equals` in `twodimensionalshape` you can simply use polymorphism to determine if any ancestor is equal to another


Added path as a filter for widgets. Useful if we have tvshows separated by source


[tests/testthat.R:2:9:](https://github.com/dirmeier/netReg/blob/e9d512a72a0f5a7e3010d0287b101205049e2e23/tests/testthat.R#L2) *style:* **Variable and function names should be all lowercase.**
```r
library(netReg)
        ^~~~~~
```
[tests/testthat/test_binomial_edgenet.R:1:1:](https://github.com/dirmeier/netReg/blob/e9d512a72a0f5a7e3010d0287b101205049e2e23/tests/testthat/test_binomial_edgenet.R#L1) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test_predict.R:1:1:](https://github.com/dirmeier/netReg/blob/e9d512a72a0f5a7e3010d0287b101205049e2e23/tests/testthat/test_predict.R#L1) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test_util.R:18:19:](https://github.com/dirmeier/netReg/blob/e9d512a72a0f5a7e3010d0287b101205049e2e23/tests/testthat/test_util.R#L18) *style:* **Commas should always have a space after.**
```r
  cv <- cvsets(10,10,23)
                  ^
```
[tests/testthat/test_util.R:18:22:](https://github.com/dirmeier/netReg/blob/e9d512a72a0f5a7e3010d0287b101205049e2e23/tests/testthat/test_util.R#L18) *style:* **Commas should always have a space after.**
```r
  cv <- cvsets(10,10,23)
                     ^
```
[tests/testthat/test_util.R:20:3:](https://github.com/dirmeier/netReg/blob/e9d512a72a0f5a7e3010d0287b101205049e2e23/tests/testthat/test_util.R#L20) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  {
  ^
```
[tests/testthat/test_util.R:22:5:](https://github.com/dirmeier/netReg/blob/e9d512a72a0f5a7e3010d0287b101205049e2e23/tests/testthat/test_util.R#L22) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    {
    ^
```
[tests/testthat/test_util.R:23:1:](https://github.com/dirmeier/netReg/blob/e9d512a72a0f5a7e3010d0287b101205049e2e23/tests/testthat/test_util.R#L23) *style:* **lines should not be more than 80 characters.**
```r
      if (i == j) expect_true(length(setdiff(cv[[i]]$train, cv[[j]]$train)) == 0)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_util.R:23:82:](https://github.com/dirmeier/netReg/blob/e9d512a72a0f5a7e3010d0287b101205049e2e23/tests/testthat/test_util.R#L23) *style:* **Trailing whitespace is superfluous.**
```r
      if (i == j) expect_true(length(setdiff(cv[[i]]$train, cv[[j]]$train)) == 0)
                                                                                ^
```
[tests/testthat/test_util.R:25:6:](https://github.com/dirmeier/netReg/blob/e9d512a72a0f5a7e3010d0287b101205049e2e23/tests/testthat/test_util.R#L25) *style:* **Trailing whitespace is superfluous.**
```r
    }
     ^
```
[tests/testthat/test_util.R:32:3:](https://github.com/dirmeier/netReg/blob/e9d512a72a0f5a7e3010d0287b101205049e2e23/tests/testthat/test_util.R#L32) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
  {
  ^
```
[tests/testthat/test_util.R:34:5:](https://github.com/dirmeier/netReg/blob/e9d512a72a0f5a7e3010d0287b101205049e2e23/tests/testthat/test_util.R#L34) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    {
    ^
```
[tests/testthat/test_util.R:37:6:](https://github.com/dirmeier/netReg/blob/e9d512a72a0f5a7e3010d0287b101205049e2e23/tests/testthat/test_util.R#L37) *style:* **Trailing whitespace is superfluous.**
```r
    }
     ^
```


`fourSidedShape` *is-a* `twodimensionalshape`


again, use proper parameter names


good! try to use the type as well. no need to be cryptic especially if I am polymorphing. I might not know what object I have


Commenting out this line causes load_pkcs12 to fail.


DRY!


ugh. just have `ellipse` inherit `twodimensionalshape`. good idea, you're just thinking too hard for this. thinking too hard leads to inheritance problems.


what is `r`?


use proper parameter names


Greetings,

@pmneila I will adjust the 3rd party dialogue as necessary.
The project file headers are automatically generated, so if you are OK with the GPL header, its convenient for our system.

Regarding tattoos and branding in the GUI, looks like advertising to me.
Instead I suggest we implement a ? button on the export dialog that links to the tutorial.
Even better would be to include a PDF version of the @sadaszewski tutorial for offline/embedded distribution.

Thanks for the input,
coast


It's not the commit that GitHub deserves, it's the commit that GitHub needs.


Literally zero reason to even do this till we're using something provided by it that we can't live without.


good


an `infinitesidedshape *is-a* `twodimensionalshape`


says who? only an ellipse has minorAxis and majorAxis. I can have a blob that has perfect roundness and is not a ellipse. think soda split on table.


A three sided shape is literally a triangle. See how over thinking your problem has led to a wonky domain?


area of what?


Really, I'd replace with: "defines an array of buffers into which outputs will be written. Draw by:"
which is what I put on the website.


After applying this you can do,

```
$ docker-compose build
$ docker-compose up
$ docker-compose exec web /bin/sh
```

Then, in the container:

```
$ rake test TEST=test/.../whatever.rb
```


develop (mjwitte) - Win64-Windows-7-VisualStudio-14: OK (1879 of 1879 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


To help in interim, I've elaborated on what @Hong-Revo describes above.

* I've added a call stack here: https://github.com/imanuelcostigan/RSQLServer/issues/142#issuecomment-284194543
* And then stepped through to show you what triggered the error here: https://github.com/imanuelcostigan/RSQLServer/issues/142#issuecomment-284195031


:cold_sweat:  Sorry for the typo.... I will update this to be consistent with that on the website


@ClarkLindsay. You've got too many things happening here that dont need to be here. Think about it. If a child class shares something with another child class, move it to the parent class. Keep moving it until it cannot be shared by ancestors anymore. I only require `RightTriangle`, `Square`, `Ellipse`, `Rectangle`, and `Square` to be "instantiable". That doesn't mean they have to all have methods written in them that repeat the parent. That kind of defeats the purpose of inheritance. The only methods that need to be written in each of these classes is what is unique to them, eg `toString`. Some of the classes like `Circle` can inherit the `Ellipse` `area` method. It cannot however inherit `perimeter`. Follow that logic for the rest of the classes.

You will also have to make classes that are abstract `abstract`, methods that cannot be derived by the parent but children must implement have to be `abstract`, and classes that cannot be taken any further finalized.


I really, really like this refactoring!

Quick question: Should this class declaration:

`public abstract class BaseFragment<PRESENTER extends Presenter, VIEW extends View> extends Fragment { }`

perhaps be slighly modified to:

`public abstract class BaseFragment<PRESENTER extends Presenter<VIEW>, VIEW extends View> extends Fragment {`

It seems making this changes makes my Android Studio inspection checker happier on the call to `presenter.attachView(this.view)`

Great work tho man..


Одним коммитом всё -- это мощно, конечно :)
Лучше как можно меньше коммиты делать. На то есть много причин. Думаю, сам понимаешь


you only need to demonstrate polymorphism and that you understand it. I personally wouldn't waste your time taking it further unless you wanted to try something out that you didn't know.


`shape1` and `shape2` are of type `String`. How on earth can you tell if they have the same area?


this is a farm management software being developed as a senior project to track health and productivity records as well as physical traits and family relationships to help farmers make informed management decisions in a quick and organized manor.


Здесь всё однозначно. Но лучше писать подробнее. Например, onRequestNameButtonClick()


You do not need to be so verbose on this. You could simply have `Rectangle` inherit `TwoDimensionalShape` for this. If a parallelogram was needed later, it would be easy to refactor.


I should never construct this, hence it needs to be made as so.


thanks


Is comparing NFA's using serialization really trustworthy? NFA has simple recursive structure, so implementing own recursive comparer should not be very challenging.

Anyway, if there is invariant about json (nfa) == json (nfa1) <=> nfa == nfa1, I think you can get more profit by implementing something like `fromJson (String): NFA` method. With that method you can write really nice tests with expected NFA visualization.


This doesn't work. What if I created a parallelogram and didn't write `getArea()`? I would inherit something that give me back 0, always. If you decide to keep `FourSidedShape` and since you cannot begin to solve the area, you should not be implementing it, you should force its descendants to.


Название какое-то неподходящие. Выглядит так, будто View приказывает Presenter что-то делать. У нас же, в MVP, View максимально тупое и только сообщает Presenter-у,  о том, что что-то произошло, а он уже решает, что делать.
Я бы назвал onNameRequestSuccess()


same for the above `area` problem


making this thread-safe soon :tm:


I'm fine with that.

Regards!


Where are the tests?


This is "ok". Since all your descendants will need to write `toString` for the lab requirements, this will be overwritten. Because of so, it is a waste of your time to do so.


Круто, что вынес в отдельный класс, а не городил тут анонимный класс
👍


Extract method returning pair (head,tail)?


nope. **ALL** 2d shapes in this lab require an equals method that checks its area against another. If *ALL* of them do, I can tell that before I even read anymore of your code, that the way you implemented this you will violate DRY


Extract helper method?


@DrEhsan Long time no see. How you been?


He couldn't install VS2015 on his new VM.  This is on a separate branch, so
why not?

On Sat, Mar 4, 2017 at 5:16 PM, TeoTwawki <notifications@github.com> wrote:

> Literally zero reason to even do this till we're using something provided
> by it that we can't live without.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/DarkstarProject/darkstar/commit/c883b00f7d71a5fc3f0551989ad6d567d9f91924#commitcomment-21155145>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABGI_7qwVisSOjDR65iVeoi9sB2aJKT6ks5rif7JgaJpZM4MTQpU>
> .
>


ah thanks ;-)


Violated consistency with variables naming


same as before. I can instantiate this and get bad values. I can inherit this and not implement these methods and get bad values. You have to *force* the child classes to implement this.


same as above


useless


DRY!


scandal


Могут быть проблемы, если кто-то забудет положить аргумент. Тогда params будет пустой и будет краш программы.
Вижу с ходу два пути:
1) Просто проверять на длину params, и если он пуст, то sleep на дефолтное время
2) Воспользоваться тем, что класс неанонимный, и объявить конструктор с аргументом

Второй мне кажется предпочтительнее


NO NO NO. We NEVER use variables like this.


верно


Why do not write all tests in this class by current style? Looks much better than rest of the class


Format?


terrible parameter list. terrible. please spend time thinking about the user of your class. What names would be good for them?


Not accept what?


Могут быть проблемы, если showNexyActivity вызывается с задержкой, а не мгновенно. Если в момент вызова устройство переворачивают, то оно проигнорится


Я бы поставил OneExecutionStrategy


Also, I can instantiate `Triangle`, so this class is wrong for the lab. Think about the domain. Right Triangle, EqualLateral Triangle, etc. There is no need for just Triangle to be available for use.


Тоже самое


no. Specifically out of scope of the project.


out of scope of the project


Actually parser don't need the scanner dependency. Instead pass list of tokens as input.


InvalidState?


if `shape.getArea() == this.getArea()`, then isn't it already `true`? If not, isn't it already `false`? Then why write the extra code when you can just `return shape.getArea() == this.getArea()`?


you cannot do this. You already inherit `toString` from `Object`


showNextActivty -- это гибкая вещь.
Но сделать несколько разных методов для каждого такого вызова.
Тем более, что ты в итоге делаешь startActivityForResult. Что уже не подходит по названию.
А также внутри используешь REQUEST_CODE. И как-то его тогда передавать надо из presenter -- не лучший вариант


private


replace " (double quote) with '' (2x single quote), is this correct that way?


Is there a particular reason why all these are commented out?  I'm writing a new test function, but I'm confused whether I'm should also not do saveCompareScore


Yes, double quotes breaks the array once it parses in JS. In Twitch chat it looks the same.


> it’ll work well for my current _intents_ with this project.
I swear I wasn't trying to make a programming joke there! It really was unintentional.


REQUEST_CODE надо выносить в константу
Если у тебя будет несколько вызовов startForResult для разных активити, то не поймешь потом, откуда результат пришел


Это в константы вынести надо.
И не "f" и "l", а понятней как-то


Change what?


cool! :)

On Sat, Mar 4, 2017 at 7:13 AM Tine Kondo <notifications@github.com> wrote:

> Whoa!
>
> i had truly no idea that was possible on Github !!!
> [image: image]
> <https://cloud.githubusercontent.com/assets/4053092/23579790/53224c5a-00f5-11e7-90a4-7c5fc080261a.png>
>
> I will certainly do!
>
> Cheers
>
> —
>
>
> You are receiving this because you were mentioned.
>
> Reply to this email directly, view it on GitHub
> <https://github.com/tinesoft/ng2-scrollreveal/commit/2c99a65aa379b8f84eedef45acdfff52f431060e#commitcomment-21153384>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AANM6N63JIDLWr3Vj-9XcoMYhNNI_6Bqks5riX-fgaJpZM4MTD1o>
> .
>


@nourelhoda89, you're close, but still a ways off. You are not using the tools available to you such as `abstract`, `final`, etc. You are also not using polymorphism very well, but your close on that. Think about where `area` is required? Is it *all* 2d shapes? So since it is, it makes sense to put it there. Now. you cannot tell ahead of time how to compute that area, but you can guarantee that all 2d shapes can compute it, and hence polymorph into 2d shapes and call `area()`. The same logic applies to `perimeter` and `circumference`. Use paper to draw out the relationships. No one in this class will get it w/o that tool, so no point in banging your head against a wall and waiting on me to respond to a tagged commit because I will just be marking it up again sending you back to the drawing board.


Здесь тоже стоило сделать вызов метода onCommitNameClick у presenter.

В первом приближении кажется, что это какие-то бесполезные излишки.
Во-первых, это правда :slightly_smiling_face:
Во-вторых, благодаря LiveTemplates время тратить на этот boilerplate code не приходится. Он сам генерируется
В-третьих, это увеличение сложности архитектуры направлено на гибкость для будущих изменений.
В-четвертых, благодаря StateStrategy реакция на действия пользователя сохраняется при повороте устройства, например. Это актуально для изменения UI особенно


With method name `releaseResources` this comment can be removed.


Seems not very handy to use start index as -1 instead of 0. Comment of the method adds zero insight why you should start iterator with logically invalid state.


@heidiaclayton @lewismc Please use my full name, Taylor Alexander Brown, for all references to me in our formal work. I can address in a new issue this since this concerns me.


oh I see there are no *-ref.mscx files in that folder.  And I see you are already doing QVERIFY stuff inside, so I guess you're just not bothering with the save compare.  That's fine...I think I've answered my question.  Nevermind.


Honestly, I don't see any method comment in this class that worth actually be there


So your entire fork is to completely discredit this entire program, as if it were all made by you. Okie dokie.


3PO, you tried manio's second patch?
Please try this
[patch4.zip](https://github.com/manio/vdr-plugin-dvbapi/files/819023/patch4.zip)

Thank for you tests. I can't test all, AES works fine with me, but as it turned out, not all. AES is a new standard of key, use in iptv now.


Probably would be better to use separate imports for each class/function


Typo


Inline visited


@vertexodessa Fixed. Thanks!


Similarity of processing DFA and NFA gives hint that maybe we can extract common structure for these classes


This commit breaks veclibfort on my Mac. Any fixes suggested?

```
~/Src/spack ((ed582ce...)) arch-mpich
$ ./bin/spack install veclibfort
==> Installing veclibfort
==> Fetching https://github.com/mcg1969/vecLibFort/archive/0.4.2.tar.gz
######################################################################## 100.0%
==> Staging archive: /Users/barrysmith/Src/spack/var/spack/stage/veclibfort-0.4.2-yhwtrkestcxarpsqiciyizj3gdjhc6zr/0.4.2.tar.gz
==> Created stage in /Users/barrysmith/Src/spack/var/spack/stage/veclibfort-0.4.2-yhwtrkestcxarpsqiciyizj3gdjhc6zr
==> No patches needed for veclibfort
==> Building veclibfort [Package]
==> Executing phase : 'install'
==> Error: AttributeError: 'Spec' object has no attribute 'libs'
/Users/barrysmith/Src/spack/var/spack/repos/builtin/packages/veclibfort/package.py:63, in install:
     53       def install(self, spec, prefix):
     54           if sys.platform != 'darwin':
     55               raise InstallError('vecLibFort can be installed on macOS only')
     56
     57           make('all')
     58           make('PREFIX=%s' % prefix, 'install')
     59
     60           # test
     61           fc = which('fc')
     62           flags = ['-o', 'tester', '-O', 'tester.f90']
  >> 63           flags.extend(spec.libs.ld_flags.split())
     64           fc(*flags)
     65           Executable('./tester')()
```


ready to download the pull


This is the version I handed in for homework.


I had a bad feeling. I went to check on my iPad and there was a typo. Fun times.


commentt on fish


`limit = 10`


yabba dabba dooo


Typo. And what this class actually converts (from->to)?


Actually I expected to see `(1,2,3,4,5,6,7,8,9,10)` here


Some stream-like processing would be nice for this method.


From signature of the method there is no way to guess that method modifies input parameter. Word `check` actually gives no hint what this method does


prefer
```
}
.let{}
```
style


fixed in https://github.com/NixOS/nixpkgs/commit/b588ed95b9a2705a8500d1c5d21d33ab3a5e7971 (not yet in master, but staging)


Is this line really worth separate method?


I definitely saw this code somewhere above


Why do you need cast?


could we use `Observable.take` instead of limit?


If this ever needed to be faster use `On closestPoint Goto ...`.


static-fortran-fix (jasondegraw) - i386-Windows-7-VisualStudio-14: Tests Failed (1878 of 2477 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-75.82%25-red.png)


Could we use StringBuilder() here?


Placing one-line return on the next line seems dangerous since there can be mismatch with curly version {}. I think early return is nice, but on the same line `if (nfaStates.IsNullOrEmpty()) return _stateFactory.CreateEmpty();`


ADDing remote resources not recommended by official documentation


Thanks for the feedback! I will work on changes. Sorry about the varying degrees of "doneness" for the toString methods, they were being revised during the last commit.


Np


Hey, @YamaArashi, are you sure this was an appropriate change?
Both LoadMissableObjects and JumpMoveEffect are at $7132, but LoadMissableObjects is in bank $3 and JumpMoveEffect is in bank $f.

What exactly made you think this was not intended to be LoadMissableObjects?


I think I fixed this last night. Let me clarify.


would u like translate it to portuguese too I could help you and I love ur script, it`s the best one <3


`if set...` seems not very handy (I guess this is mutable method)


Looks good.


It was intended, have you tested it?


Terminals Are Sexy
A curated list of Terminal frameworks, plugins & resources for CLI lovers.

Check out my blog and follow me on Twitter.

Build Status Say Thanks Made With Love GitHub stars

Contents

Terminals Are Sexy
Shells
Base Shells
ZSH
Bash
Git
Fish
Terminal Emulation Applications
Package Managers
Universal
macOS
Linux
FreeBSD
Windows
Text Editors
Tools and Plugins
Communication
Community
Other Sexy Lists
Contributing
Shells

Sexy frameworks, plugins and resources for your sexy shell.

Base Shells
bash - GNU Project's shell (Bourne Again SHell).
zsh - Powerful shell with scripting language.
fish - Smart and user-friendly command line shell.
xonsh - Python-ish, BASHwards-looking shell language and command prompt.
PowerShell - PowerShell is an automation and configuration tool/framework that is optimized for dealing with structured data.
ZSH
oh-my-zsh - A delightful community-driven framework for managing your zsh configuration.
prezto - The configuration framework for Zsh.
zsh-syntax-highlighting - Fish shell like syntax highlighting for Zsh.
antigen - A plugin manager for zsh, inspired by oh-my-zsh and vundle.
antibody - A faster and simpler antigen written in Golang.
pure - Pretty, minimal and fast ZSH prompt.
powerlevel9k - Super flexible awesome powerline ZSH theme.
liquidprompt - A full-featured & carefully designed adaptive prompt for Bash & Zsh.
dotzsh - A community driven framework for zsh.
zgen - A lightweight and simple plugin manager for ZSH.
zplug - A next-generation plugin manager for zsh.
zunit - A powerful unit testing framework for ZSH.
zshdb - A ZSH debugger.
zsh-quickstart-kit - Simple zsh quickstart for using zsh and zgen.
zsh-autosuggestions - Fish-like autosuggestions for zsh.
alf - Alf is an out of this world super fast and configurable framework for zsh.
ant-zsh - Ant-zsh is a tiny and lightweight ZSH configuration environment for special customization needs.
pumice - Pumice is a lightweight plugin manager for zsh.
zeesh - Zeesh is a cross-platform Zsh framework.
zilsh - Zilsh is a zsh config system that aims to appeal more to power-users and follow the simplistic approach of vim-pathogen.
zim - Zim is a Zsh configuration framework with blazing speed and modular extensions.
zoppo - Zoppo is the crippled configuration framework for Zsh.
zpm - ZPM is a plugin manager for zsh similar to vim-plug.
ztanesh - Ztanesh aims to improve your UNIX command line experience and productivity with the the configuration provided by the ztanesh project.
zulu - Zulu is a total environment manager for ZSH 5+.
zsh-pony - Covers customizing ZSH without a framework.
Bash
bash-sensible - An attempt at saner Bash defaults.
bash-powerline - Powerline-style Bash prompt in pure Bash script.
bashtrap - A quick way to spruce up OSX terminal.
liquidprompt - A full-featured & carefully designed adaptive prompt for Bash & Zsh.
hstr - Bash History Suggest Box.
aliases - Contextual, dynamic, organized aliases for the bash shell.
bash-it - Bash-it is a collection of community Bash commands and scripts.


Nice


I agree it would be good to split plume-lib into parts and get each of them into Maven Central.
I've started on this:  some projects appear at https://github.com/plume-lib, but they are not yet in Maven Central.


2 equals method?


@tarelli Not production but development and seems to be working fine. What is the purpose?


resolves issue #12


This is not factory I guess. Something like `registry` or `manager` would be more appropriate


I had to put two because with one it was not working and I found that with two -- was the way to pass the parameters to webpack from npm


Redundant comment?


I was just thinking about using a StringBuilder last night and if that would be more efficient for concatenation.


+# Contribution Guidelines


We could technically do that. If we go that route then we might as well remove the `truncated` argument. It depends how closely we want to follow Kotlin's `joinToString()` convention, which also could use `take()` on a collection or sequence, but JetBrains chose not to...


2014, not 2015 ;-)


This solution very is error-prone


+##Please ensure your pull request adheres to the following guidelines


Why not use method below?


```
[INFO]
[INFO] The arguments passed to webpack are:
[INFO]
[INFO] [ '/Users/matteocantarelli/Documents/Development/GeppettoCasual/org.geppetto.frontend/src/main/webapp/node/node',
[INFO]   '/Users/matteocantarelli/Documents/Development/GeppettoCasual/org.geppetto.frontend/src/main/webapp/node_modules/.bin/webpack',
[INFO]   '--devtool',
[INFO]   'eval' ]
[INFO]
[INFO] The arguments passed to HtmlWebpackPlugin are:
[INFO]
[INFO]
[INFO] The public path (used by the main bundle when including split bundles) is: //geppetto/build/
[INFO]
```

With the latest it's not working anymore, see no parameters passed to htmlwebpack


Getting late here, I'll follow up on these `joinToString()` fixes/enhancements tomorrow. Feel free to hack away at it though while I'm sleeping.


Inline head and tail and return nodes via getters of created transition seems more reliable


Why start from 1? Seems like a bug without any kind of explanation


reverted!


I believe moving iterator to parser state could be enough for eliminating these methods


Commented code in VCS?


Some message in exception will not be redundant


thank you very much.


Better extract variable with appropriate name instead of comment


And i hope to engage in front-end Wed development after graduation


I can't understand terms PositiveClosure and SingleClosure in compiler domain. I think simple `OneOrMore` and `ZeroOrMore` will make more sence


What is -1?


You make this pull request against a forked version of flask-jwt-extended. If you want to re-make it against the maintained version (https://github.com/vimalloc/flask-jwt-extended) I would be more then happy to accept it.

Thanks for contributing! 👍


Nice work


Is there no more elegant way to split string?


Extract method


This should be double checked prior merge. I have earlier made plans using TST000 which contains these tags. So why does it fail to load now?


Comment is confusing


Please file an issue. Discussion here will get lost


The whole method is nice example of refactoring `extract method instead of comment`


有个问题，airline只有在只剩下一个tab的情况才会显示buffer，所以有没有可能将tab和buffer的切换都使用同一套按键映射呢？


@tracyone 我感觉鱼与熊掌不能兼得。所以我选择不使用 tab。


```
0 Demo/turtle/tdemo_two_canvases.py 100644 → 100755
```
It indicates that the file permission mode was changed from `644` to `755`.
Not sure whether this was intentional.


For the record;
package.json file was not updated for the version number. This breaks the installation of his companion https://github.com/igorlino/angular-elevatezoom-plus package
at 1.2.0 version.


I know this isn't clear in the definition of pubdatatype or privdatatype, but as you can't put unencoded binary data in a JSON string, what is "oic.sec.encoding.der"? Is it base-64 encoded or hex-coded?


Actually this is correct because there are 1000 emissions, and the `...` indicates that there are more than 10. Maybe check the Kotlin docs on `joinToString()` and maybe it will make more sense what I'm trying to accomplish...

https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.collections/join-to-string.html


Wrong indentation?


OK - I had this backwards. The CMS is getting the CSR from the Device, not the other way around...


hmm


teste


注释写错，应该是修改图标对其方式


This little line indicate about serious misunderstanding about compiler stages.

You currently develop scanner. Role of this system is getting list of some tokens from string. Scanner has no knowledge about semanitc, type system or target code language.

In general you don't need to explicit cast some values in compiler at all, since this scanner could be used for different language with different tokens (like libs like ANTRL used)

But there is strong assumption that type system of C# has exactly same float as you compiled language, but in general case this is not true.


https://github.com/Scarsz/DiscordSRV/issues/121, not #122


VS2015 isn't supported on Server 2016
This won't  be merged until I talk to KJ about changing anything else in the project anyways.
You should be proud of me for making a new branch :P


This is semantically wrong. The class name describes what kind of object it is. Is "N" a "compass"? No it's not. It is a direction or a point. So merging these this way is just wrong.


If it helps in your scenario, that's a really good start and worth it! I guess for 8% it's better and for 88% it's the same. What I wonder is the other 4% of the users.

What I'm trying to say is that there are different reasons for a connection being perceived as slow (latency vs bandwidth).
I think we should get some good benchmark results to tune min time / max time / default queue size - and decide if this is always good or if a queue size override needs to be available.


Всё отлично сделано. 10


See how this method name looks wrong now. A method name should describe what it returns. It says it returns a "Direction" but it returns a "AsciiCompass".


=D


Are you sure you wanted to push this changeset into master? This branch it going to be released as v1.1, so it's not a good idea to push bigger refactorings now. And I'm not sure if it's good idea to introduce breaking changes on IGridViewDataSet as it is pretty heavily used, maybe it would be better to leave the old properties here for compatibility.


Тут не нужен второй список. Стоило использовать цикл for и метод списка add(index, element)
Который в середину списка вставляет. Ну и, соответственно LinkedList


Prochaine fois ouvre une issue comme tu n'est pas sur :) la commande désirée par le prof est bien Describe :)


Furthermore, consult the changes from commit [Use '%' wildcard in Makefile to simplify generations](https://github.com/0140454/compute-pi/commit/89ab12a144d0ce6d2d3c498e50277fe81c42b8d4)


лишь в функции `lines`? Или я недопонял чего-то?


Тут всё отлично. Ставлю за ДЗ 9,5


more love


Hi Christopher,

I did some further experiments with the kernel module on my pi-top.

First msleep is in msec. You need to change it to 1 instead of 500.

It still does not work reliably on my system. It often reads 0%, which opens a window on the raspbian desktop claiming that the battery is empty. Very annoying!

I have used my home made i2c sniffer to see what’s going on. See the attached file

You can see that my gtk_battery reads only 3 registers every 5 seconds, whereas the kernel module attempts to read a lot of stuff in short intervals. That means if the i2c reliability is not perfect, things will go wrong. If you want to better understand what it does reading the sniffer protocol, look at the manual of the bq40z60, page 107ff.

http://www.ti.com/lit/ug/sluua04c/sluua04c.pdf <http://www.ti.com/lit/ug/sluua04c/sluua04c.pdf>

I believe that unless one finds a way to have a reliable communication, the use of the kernel module will not work well. Maybe we have to wait for the Raspberry Pi 4 and hope that it works better.

I also have a home made i2c protocol analyzer, which could theoretically be used to find out in more detail what’s going wrong. But with that much of traffic on the bus that’s an extremely time consuming task.

Best regards, Rene

********************************
* Data produced by gtk_battery *
********************************

i2c sniffer by rricharz

Acquiring data
Analyzing data, number of transitions = 354
i2c bus activity: * means ACQ = 1 (not ok)
Dev=0B W Data=0D                                          *** Read current capacity
Dev=0B R Data=45 00
Dev=0B W Data=0A                                          *** Read status
Dev=0B R Data=35 7F
Dev=0B W Data=12                                          *** Read remaining time
Dev=0B R Data=49 00*
Time to analyze and display data was 18 msec

****************************************
* Data produced by linux-pitop-battery *
****************************************

i2c sniffer by rricharz

Acquiring data
Analyzing data, number of transitions = 5000
i2c bus activity: * means ACQ = 1 (not ok)
Dev=0B W Data=03
Dev=0B R Data=01 71*
Dev=0B W Data=17
Dev=0B R Data=29 00
Dev=0B W Data=03*
Dev=0B W Data=10
Dev=0B R Data=28 0B*
Dev=0B W Data=09*
Dev=0B R Data=B8 1E
Dev=0B W Data=10
Dev=0B R Data=28 0B*
Dev=0B W Data=03 0B*7F*3F*
Dev=0B W*
Dev=0B W Data=03 0B*7F*3F*
Dev=0B W*
Dev=0B R Data=17 0B*
Dev=0B W Data=03*FF FF
Dev=0B W Data=03*
Dev=0B R Data=01 71*
Dev=0B W Data=03 01*
Dev=0B W Data=0A*
Dev=0B R Data=07 7F
Dev=0B W Data=03*
Dev=0B R Data=17 0B*
Dev=0B W Data=18
Dev=0B R Data=8C 0B
Dev=0B W Data=03 0B*7F*3F*
Dev=0B W*
Dev=0B R Data=17 0B*
Dev=0B W Data=03 0B*7F*3F*
Dev=0B W*Data=42*C1*08
Dev=0B R Data=8C 0B
Dev=0B W Data=03 0B*7F*3F*
Dev=0B W*
Dev=0B W Data=03 0B*7F*3F*
Dev=0B W Data=0D
Dev=0B R Data=47 00
Dev=0B W Data=03 0B*7F*3F*
Dev=0B W Data=0F
Dev=0B R Data=6B 08
Dev=0B W Data=03*
Dev=0B R Data=01 71*
Dev=0B W Data=03*
Dev=0B R Data=17 0B*
Dev=0B W Data=03 01*
Dev=0B W Data=03 0B*7F*3F*
Dev=0B W Data=18
Dev=0B R Data=8C 0B
Dev=0B W Data=03 0B*7F*3F*
Dev=0B W*
Dev=0B W Data=03 0B*7F*3F*
Dev=0B W Data=03*
Dev=0B R Data=01 71*
Dev=0B W Data=03*
Dev=0B W Data=08*
Dev=0B R Data=A8 05*
Dev=0B W Data=10
Dev=0B R Data=28 0B*
Dev=0B W Data=09*
Dev=0B R Data=BA 1E
Dev=0B W Data=12
Dev=0B R Data=59 00*
Dev=0B W Data=03 0B*7F*3F*
Dev=0B W Data=16
Dev=0B R Data=C7 00
Dev=0B W Data=03 0B*7F*3F*
Dev=0B W*
Dev=0B R Data=17 0B*
Dev=0B W Data=13 0B*
Dev=0B W Data=18 0B*
Dev=0B W Data=18
Dev=0B R Data=8C 0B
Dev=0B W Data=13
Dev=0B R Data=FF 7F*
Dev=0B W Data=03*
Dev=0B R Data=01 71*
Dev=0B W Data=03 01 63 16*
Dev=0B R*
Dev=0B W Data=21
Time to analyze and display data was 146 msec

Dev=0B W Data=18 0B*
Dev=0B W Data=12 0B*
Dev=0B W Data=18 0B*
Dev=0B W Data=12 0B*
Dev=0B W Data=18 0B*
Dev=0B W Data=12 0B*
Dev=0B W Data=18 0B*
Dev=0B W Data=12 0B*
Dev=0B W Data=30 17*
Dev=0B W Data=12 0B*
Dev=0B W Data=18 0B*
Dev=0B W Data=12 17
Dev=0B W Data=18 0B*
Dev=0B W Data=12 0B*
Dev=0B W Data=18 0B*
Dev=0B W Data=12 0B*
Dev=0B W Data=18 0B*
Dev=0B W Data=12 0B*
Dev=0B W Data=18 0B*
Dev=0B W Data=25
Dev=0B R Data=59 00*
Dev=0B W Data=18 0B*
Dev=0B W Data=13 0B*A2*83 02*E8
Dev=0B W Data=13 0B*
Dev=0B W Data=18 0B*
Dev=0B W Data=13
Dev=0B R Data=FF 7F*
Dev=0B W Data=18
Dev=0B R Data=8C 0B
Dev=0B W Data=1C 0B*
Dev=0B W Data=03*
Dev=0B R Data=01 71*
Dev=0B W Data=1C
Dev=0B R Data=69 00*
Dev=0B W Data=03*
Dev=0B R Data=01 71*
Dev=0B W Data=03*
Dev=0B W Data=19 0B*
Dev=0B W Data=0F
Dev=0B R Data=6B 08
Dev=0B W Data=19
Dev=0B R Data=D0 1C*
Dev=0B W Data=03 0B*7F*3F*
Dev=0B W*
Dev=0B W Data=19
Dev=0B R Data=D0 1C*
Dev=0B W Data=03
Dev=0B R Data=01 Time to analyze and display data was 153 msec


Nice!


stale som cakal ze `fm3` bude nejaky npm plugin, chvilu mi trvalo kym som zistil ze to je len skratka z freemap3 :)


I'm not sure about this one. Do we do this in other plugins? It may be a little much?


All changes of this kind look great.


FWIW I have observed string join to be very noisy in multiple benchmarks over the last months.


If you are doing this here? What other things in Factions are serializable? Do they have a block comment? I'm thinking we could skip the block comment for this and just place it at the very top above all block comments. This is actually something that is worthy of a group discussion.


You should also implement "Named". That is already a method we have but we are not implementing the interface yet. You should throw it in and add the @Override annotation.


Great idea!


just for testing


I had a look at them with the change, this lead to some changes to ally colours. There are two greenish non-self colours but they are quite different and the worst is only applied in games with more than 10 allies. The rest of the colours are mostly bluish which is ok.


Space or no space?...


не ставьте более одной пустой строки подряд


Мне кажется огонь, если такого рода файлы в корне лежат, лучше в /local/include/ajax/ мне кажется вынести, порядок хотя бы какой-то будет в скриптах, в плане всё что по аяксу дёргается лежит в всегда в одном разделе. Сейчас можно оставить, возможно, на перспективу договорённость что их кидаем в  /local/include/ajax/  или в  /include/ajax/ в зависимости от версии bx.


can it be tested


heh. nice!


Great!


This is a good equals and hash code implementation :)


Contains methods in java usually takes any object. The Generic magic here is not very Java like I think.


странная магия, что тут планировалось? если суть просто в каком-то переписывании данных в новый массив, то это и надо сделать в цикле, а не морфировать данные без нужды


Ah, cool. So now you can combine plots together? I'm guessing that in the counts plot this could also be useful @giacomov


там уже и так один такой аяксовый файл в корне лежит, поэтому в данном случае, это в духе решения


test name does not describe the intent of function


$i для итератора достаточно, в данном случае


дешевле клеить через ., чем парсить строку


ну я обычно кладу SITE_TEMPLATE_PATH/ajax/, например /local/main/ajax/


Хорошо, тогда делаем корректировку, что в дух решения сохраняем, но если делаем с нуля и сами, то кидаем в отдельную папку, лучше в /local/include/ajax/ если такая возможность есть. :)


![](https://github.trello.services/images/mini-trello-icon.png) [Backendv2 - pomiary](https://trello.com/c/6Cwm4HfX/19-backendv2-pomiary)


зачем 3 класса, когда можно обойтись одним?


то же самое


>SITE_TEMPLATE_PATH/ajax/, например /local/main/ajax/
Согласен, тоже вариант хороший.


What is it?


Принципно е хубаво да има по един празен ред на края на файловете


```
       if ($currentIndex > 0){
            echo ', ';
        }
        echo $continentsAnimal;
        $currentIndex++;
```


What is these magic numbers 3,4 5 ??
Can it be extracted into some kind of config??


Yes, much better!


magic numbers


See https://github.com/kyz/libmspack/pull/8 for discussion about it


Ah! Much more elegant 👍


map can be simplified i.e. you should not put any calculation logic here


I'm not sure we want to add translations. This needs to be discussed. Goes for MassiveHat too.


Don't use uppercase for variable naming unless it is a macro.


maybe we could add here an
`sleep (5);`

to less resources consumption :octocat:
thanks for theese great release!


it is not hotel info


@YongSiang94 I think the welcome screen can change to say "Welcome" instead of "Welcome Back" since it's reflected in the Getting Started section?


Defining this variables before using them solves the `Uncaught TypeError` issue I mentioned earlier.


i read in some article that commit messages should be written in present tense, that's why i was doing it like that


You can rewrite with designated initializers in C99. Reference: http://stackoverflow.com/questions/7265583/combine-designated-initializers-and-malloc-in-c99


thanks for the fix


Don't add `output.txt` in GIT repository.


This's very essential changes, man!


Don't add the generated images in GIT repository. Update `.gitignore` to exclude them.


Yes


It is not "remove branch" but "eliminate loops".


Use [git rebase -i](http://zerodie.github.io/blog/2012/01/19/git-rebase-i/) to rework the recent commits.


@nnarhinen - shouldn't that be under a debug switch?


now have 5 alt index pages... but must be renamed index.html.erb to use one.   Have been altering the webserver to satisfy error reports... still working to resolve.


WTF, commited by mistake. Thanks for noticing.


Hi, thanks for the clarification. But I do not fully understand why

>  if you have 3 pieces, you are computing your pawnset 3 times.
>  And if opponent has 4 pieces, you are computing the pawnset 4 times for him.

it really changes the meaning of the idea, and in some cases can turn into confusion


это временно


https://gist.github.com/xnuk/d9f883ede568d97caa158255e4b4d069
@wlzla000 @Nuwanda22


@krzyslom are you using roxygen from CRAN or from github? '1.9999' ending does not look like stable
Version. Please use onyl checked release version from CRAN


哈哈。郎老师,是我助攻的~看到你回复了。


Hi,
I do not know why you received this message.
autostat this is my repository, from my own account.
Maybe you subscribed on all my commits...i do not know exactly. I will try to discover.
I have set of my projects on github. Some of them are working, some of them are frames, some of them - only for learning REACT or smth else.
Particular this project is not working. Maybe I will finish it in future. (this story is about average prices on cars based on nodeJS).
This project was on my machine long time, but this week I decided to put it on github.

>Воскресенье,  5 марта 2017, 12:26 +02:00 от gilix26 <notifications@github.com>:
>
>What is it?
>—
>You are receiving this because you authored the thread.
>Reply to this email directly,  view it on GitHub , or  mute the thread .


Hiding the `_id` field is not available via any schema option, so we're testing the [custom implementation](https://github.com/jozsi/wealthor/blob/71f93f42ee654fcf8049515da56c5c422c78de96/models/wallet.js#L6-L8) of hiding fields.

However, the model tests are basically specs: they are written first, before any implementation is done (which may, or may not provide those options out of the box). Yes, it may cause us to test out of the box options [like `trim`](https://github.com/jozsi/wealthor/blob/71f93f42ee654fcf8049515da56c5c422c78de96/__tests__/wallet.model.js#L36-L38), but on the other side:
- the specs will describe the expected behavior with human language
- it's unlikely that these options would break during minor releases, however they might get removed in future major releases (and I'm planning on adding [Greenkeeper](https://greenkeeper.io/) for automated dependency updates)
- we might move away from Mongoose, but the specs would remain the same


Everything takes longer than expected 💤 🛌 😴


com.gzr.tavern...


ignore me, i'm not drunk enough


We can use posix sems. Just pass `USE_UNNAMED_POSIX_SEMSPHORES=1`


Ehmm, the content container takes the whole screen width now because the `grid-480` class seems to be missing.


no need detele it


i read the gitignore documentation and found that this file contains files that git should ignore


We are using an external library that already has a [list of currencies](https://github.com/smirzaei/currency-formatter/blob/master/currencies.json). Based on the currency code, it can detect it's formatting. It also supports cryptocurrencies (`BTC`). Do we want to support custom formatting options or eventually custom currencies? At the moment we only accept [the currencies from the list](https://github.com/jozsi/wealthor/blob/71f93f42ee654fcf8049515da56c5c422c78de96/models/wallet.js#L26).


@bex1
I think we should find another way to do this, there is probably a good reason for Semantic UI to have margins on `ui.grid`. The proper solution would then be to wrap our components correctly (in other words re-structure our container/wrappers).


Sounds like an enum would be useful ;)


great. thanks!


Russell


KarakTea


This commit makes old show-files incompatible. I learned this the very hard way ;-))
Is there any chance to adapt old show-files  to the new version other than recreating manually?


-the AI just won't play nice with the randomized armor templates, putting it on ice until PDS fixes bugs related to template designs


👍 for changing the prepositions to 'on' :-)


whoops, typo, this is actually a backport of #20255


Yes, with the next one 😆 They changed the behavior silently, I'm watching the GitHub Blog for a good reason... 😒


Thanks for checking this! I was pretty sure that technically the player's health value would be harmless once it has fallen to zero or below, but knowing for sure is better. ;)

However, I don't think that negative health adds *anything* to singleplayer games and I am not going to add a switch for this to the menu. But, my plan is still to enable this in deathmatch games, because I am sure it adds some kind of dynamics there.


Just to add an end users perspective, not only does the Sundtek usb tuner no longer work on the latest kernel update on my ET10K, but wifi, using the RTL8192CU chipset (which used to be 100% reliable) is now almost unusable.


private
+ m-нотация

Должно быть
private String mName;


Another reason for using an accepted list of currencies is to provide [conversion rate support](https://github.com/openexchangerates/money.js#moneyjs--fx) for inter-wallet transactions.


dividing the site parts into separate files makes it more readable and easier to edit than one big file


This was on description too.. fixed!


You can play this game here


ok (Y)


@MarcinKosinski I used the github version. After removing the package, installing the CRAN version and running Check again the RoxygenNote stays at 6.0.1.9000.


# include<bits/stdc++.h>
using namespace std;
int main()
{
    string a="453628",s="";
    int cr=0;
    for(int i=0;i<a.length();i++)
    {
        if(cr==0)
        {
            s+=(a[i]-'0')/2+'0';
            cr=(a[i]-'0')%2;
        }
        else{
            s+=(cr*10+(a[i]-'0'))/2+'0';
            cr=(cr*10+(a[i]-'0'))%2;
        }

    }
    cout<<s;
    return 0;
}


dividing a string of integer by 2


Bluemix Toolchain: This commit has been deployed to US South:user@ibm.com:test


@joydeeproni what's the output when you run these two commands:

```
ruby --version
jekyll --version
```

And do you get this error even when running from a clean repository? In other words, does this error still show up if you do this (lines starting with `$` are commands that you should enter in the terminal):

```
$ ruby --version
ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-darwin14]

$ jekyll --version
jekyll 3.4.1

$ cd /tmp

$ git clone git@github.com:DevTips/Artists-Theme.git
Cloning into 'Artists-Theme'...
remote: Counting objects: 1350, done.
remote: Total 1350 (delta 0), reused 0 (delta 0), pack-reused 1350
Receiving objects: 100% (1350/1350), 12.70 MiB | 1.26 MiB/s, done.
Resolving deltas: 100% (526/526), done.

$ cd Artists-Theme/

$ git status
On branch gh-pages
Your branch is up-to-date with 'origin/gh-pages'.
nothing to commit, working tree clean

$ jekyll serve
Configuration file: /private/tmp/Artists-Theme/_config.yml
Configuration file: /private/tmp/Artists-Theme/_config.yml
            Source: /private/tmp/Artists-Theme
       Destination: /private/tmp/Artists-Theme/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
                    done in 0.625 seconds.
 Auto-regeneration: enabled for '/private/tmp/Artists-Theme'
Configuration file: /private/tmp/Artists-Theme/_config.yml
    Server address: http://127.0.0.1:9000/
  Server running... press ctrl-c to stop.
```


Почему-то git мне предложил обновить чуть ли не весь solution *okayface*. И кодировка в комментах слетела, возможно, из-за Кракена. При внесении изменений в код и последующем запуске вылетает ошибка:

> error LNK1201: error writing to program database 'D:\Text\БГУ\Программирование\Моё\LaserDynamicsModeling\Debug\LaserDynamics.pdb'; check for insufficient disk space, invalid path, or insufficient privilege
При повторном запуске всё нормально. Возможно, солюшн замусорен, можно новый создать (в новом всё нормально пашет).


hi, thanks for the update to 0.15.

I'm having trouble though getting it to work with a google calendar.  This is using a snippet like:

```
[storage work_calendar_remote]
type = "google_calendar"
token_file = "~/.vdirsyncer/google-token-work"
client_id = "xyz"
client_secret = "XYZ"
```

which generates 👍

```
vdirsyncer -vdebug discover work_calendar
debug: Using 1 maximal workers.
Discovering collections for pair work_calendar
work_calendar_local:
debug:   File "/usr/local/Cellar/vdirsyncer/0.15.0/libexec/lib/python3.6/site-packages/vdirsyncer/cli/discover.py", line 204, in _print_collections
debug:     discovered = get_discovered()
debug:   File "/usr/local/Cellar/vdirsyncer/0.15.0/libexec/lib/python3.6/site-packages/vdirsyncer/cli/discover.py", line 133, in get_self
debug:     return self._discovered
debug:   File "/usr/local/Cellar/vdirsyncer/0.15.0/libexec/lib/python3.6/site-packages/vdirsyncer/utils/__init__.py", line 170, in __get__
debug:     obj.__dict__[self.__name__] = result = self.fget(obj)
debug:   File "/usr/local/Cellar/vdirsyncer/0.15.0/libexec/lib/python3.6/site-packages/vdirsyncer/cli/discover.py", line 142, in _discovered
debug:     return handle_storage_init_error(self._cls, self._config)
debug:   File "/usr/local/Cellar/vdirsyncer/0.15.0/libexec/lib/python3.6/site-packages/vdirsyncer/cli/discover.py", line 138, in _discovered
debug:     discovered = list(self._cls.discover(**self._config))
debug:   File "/usr/local/Cellar/vdirsyncer/0.15.0/libexec/lib/python3.6/site-packages/vdirsyncer/storage/dav.py", line 420, in discover
debug:     session, _ = cls.session_class.init_and_remaining_args(**kwargs)
debug:   File "/usr/local/Cellar/vdirsyncer/0.15.0/libexec/lib/python3.6/site-packages/vdirsyncer/storage/dav.py", line 339, in init_and_remaining_args
debug:     return cls(**self_args), remainder
debug:   File "/usr/local/Cellar/vdirsyncer/0.15.0/libexec/lib/python3.6/site-packages/vdirsyncer/storage/google.py", line 41, in __init__
debug:     raise exceptions.UserError('requests-oauthlib not installed')
Warning: Failed to discover collections for work_calendar_remote, use `-vdebug` to see the full traceback.
work_calendar_remote:
error: Unknown error occured: local variable 'discovered' referenced before assignment
error: Use `-vdebug` to see the full traceback.
debug:   File "/usr/local/Cellar/vdirsyncer/0.15.0/libexec/lib/python3.6/site-packages/vdirsyncer/cli/utils.py", line 306, in _worker
debug:     func(wq=self)
debug:   File "/usr/local/Cellar/vdirsyncer/0.15.0/libexec/lib/python3.6/site-packages/vdirsyncer/cli/tasks.py", line 89, in discover_collections
debug:     rv = collections_for_pair(pair=pair, **kwargs)
debug:   File "/usr/local/Cellar/vdirsyncer/0.15.0/libexec/lib/python3.6/site-packages/vdirsyncer/cli/discover.py", line 71, in collections_for_pair
debug:     b_discovered.get_self)
debug:   File "/usr/local/Cellar/vdirsyncer/0.15.0/libexec/lib/python3.6/site-packages/vdirsyncer/cli/discover.py", line 211, in _print_collections
debug:     for args in discovered.values():
error: 1 out of 1 tasks failed.
```

Is the key error `'requests-oauthlib not installed'` ?


Did you remove package with 'remove.packages'?


Yes


Все что выводится пользователю надо выносить в ресурсы.
Там есть специальный синтаксис для вставки.
Например здесь:
`<string name="hello_text">Hello, %1$s !</string>`
В коде:
`mTextView.setText(getString(R.string.hello_text, name))`

getString -- вызывать можно внутри активити или фрагмента

Но здесь есть и другая ошибка. Идеологическая.
В коде презентера не должно быть(в идеале) android зависимых сущностей. TextView -- тем более.

Вторая ошибка, что у тебя presenter слушается View. В MVP же должно быть так:
View только сообщает Presenter о действиях пользователя.
Например:
1) Пользователь кликнул на кнопку
2) View вызывает метод onSomeButtonClick() у презентера
3) Presenter реагирует в этом методе на это действие
4) В простых случаях он сразу вызывает метод showSomething() у View
4*) В более сложных случаях сначала происходит долгое действие в Background, а потом уже вызывается метод у View


[4. Generate Kendo Treeview with local binding.](http://docs.telerik.com/kendo-ui/php/widgets/treeview/local-binding)


#28 was introduced by a (most likely manual) merge gone wrong here.


Лучше вынести в отдельный класс. Тогда код метода будет в одну строчку


Yes I know - well spotted.


Опять же надо было сообщить о клике Presenter, а он уже должен реагировать на событие

Вот пример интерфейсов
http://pastebin.com/ffjYPdL8


On CRAN there is 6.0.1 version
https://cran.r-project.org/web/packages/roxygen2/index.html

Maybe you Have to update project options to use roxygen after reinstallation?


Закомментированный код в коммиты нет смысла добавлять


test


У тебя ведь есть TAG, используй его


afaik, it uses the email git is configured with.

iirc, git commit --amend can reset the user data associated with a commit, not just the commit message. I haven't pulled this yet, so it won't be problematic if you fix it and do a force push, if you want.


يشتغل صح؟


See https://jeweet.net/2016/03/14/vmcam-iptv-softcam
If you have iptv provider with udp multicast and proprietary box called Amino (or other), you can use iptv plugin with vdr. Also you mast know udp addresses of channels. Some provider get m3u playlist, but if no,  need use Wireshark (for example), to search ip range of channels. After that, use my channelscan (for example)
https://bitbucket.org/ua0lnj/channelscan
and scan your udp channels. You can create vdr iptv channels manually of course.
For example, one my channel:
National Geographic HD;Ростелеком:40012040:S=1|P=1|F=UDP|U=239.4.1.204|A=2020:I:0:101=27:110=rus@3,111=eng@3:0:628,618,5601:1:1:4:0
If you can see free iptv, you can try use vmcam.
For start, need compiling vmcam.
https://github.com/macm00v/vmcam
vmcam must compile with openssl <= 1.0.1e, see messages from https://jeweet.net/2016/03/14/vmcam-iptv-softcam
I tryed on ubuntu-server 16.04.02 and fedora-25. On fedora vmcam work as is, but on ubuntu I install openssl-1.0.1e together with 1.0.2.
vmcam config depends of your provider.
If you got working vmcam, you can use it with tvheadend as is. For vdr, need aes support of dvbapi, and aes support for oscam. I wrote 2 patches for oscam
http://www.streamboard.tv/oscam/ticket/4587
http://www.streamboard.tv/oscam/ticket/4588
But it not tested with other CA, because I have not them.

That's all.


done


public abstract class Shape {
    public abstract double getPerimeter();
    public abstract double getArea();

    public boolean isAreasEquals(Shape shape) {
        return this.getArea() == shape.getArea();
    }
}


do we still beed that css ? reiscout_address.css


Oh, I'm sorry for the fuss. I meticulously checked all the changes and they're all OK. So the only possible issue is with this widening of double to float when passing to functions, but that shouldn't happen in practice because of even basic assembly optimizations.


Всё верно. В твоём случае, чтобы не переписывать иерархию, можно просто добавить default метод в интерфейс Shape (в java 8 появились).


المفروض على حسب تجربتي له يحذف و يضيف و يطلع رساله لو في خطا


Раньше, если бы в конструкторе возникло исключение, то память, занимаемая вектором, утекла.


@thinhx2 lol, its need, because if not  you will face with error


An open issue - can be decided in the future


done by u


Bluemix Toolchain: This commit has been deployed to US South:user@ibm.com:test


@DarkmoonRabbit I exported the locales from trinitycore.. maybe you will find some chinese locales for trinitycore .


IComponentContainer & IComponentContainerBuilder will be.


aaaaaaaa


xD


As discussed - Leave as is for now


I don't know much about C++ but, if this builds, the comparison is wrong. It should be mime == "video/avc" .


сначала нам надо получить доступ к i-му элементу ArrayList Q(1), LinkedList Q(n)
затем вставить элемент ArrayList Q(n), LinkedList Q(1)
вроде одинаково получается


Taken


Oh, it was array, then I played with list attributes option and forgot to return.


@lfpino  - I'm trying to replicate this behavior in `rules_scala` repo.
(main motivation is to make sure I have `bazel` available on test_sh runtime)

Can you please help me understand where is this `src/bazel` coming from. I don't see it in `src` directory.

@damienmg @johnynek @ittaiz  - FYI


Fixed, the ending is online 619.


lets add log print here so we will know about this and not silently discard this


Это верно, но сама операция поиска в LinkedList занимает меньше времени чем операция копирования массива.


Definitely, plus framework module not loaded at all.


Plugin has been rejected due to poor namespace. Recommends changing main class to `MCPEPIG\CreativeItemsPlus\Main` instead.


@ozank hocam verdiğiniz örnekte dc motor'un terminal voltaj grafiğine baktığımızda pwm şeklinde kare dalga görüyoruz. Ben dc motorun terminal voltajının pwm'den ziyade dc voltaj olmasını beklerdim. Neden öyle bir voltaj verdik anlamadım, Voltajın kare dalga olarak verilmesi ripple'a yol açmaz mı?


Hehe, yes, that was the first thing I thought of when I missed it.


done


`ap` driven development :scream:


Does this plugin have any advantage over https://poggit.pmmp.io/p/Elytra/1.0?


so now its boots but gps doesnt work. Logcat shows me

E LocSvc_afw: E/const GpsGeofencingInterface* get_geofence_interface(), dlopen for libgeofence.so failed, error = dlopen failed: cannot locate symbol "_ZNK7MsgTask7sendMsgEPK6LocMsg" referenced by "/system/vendor/lib/libgeofence.so"...
but I dont know what I missed

bliss@bliss:~/xenon/vendor/oppo/msm8974-common$ grep -lir '_ZNK7MsgTask7sendMsgEPK6LocMsg' *
proprietary/lib/libloc_api_v02.so
proprietary/vendor/lib/liblbs_core.so
proprietary/vendor/lib/libgeofence.so
proprietary/vendor/lib/libflp.so
bliss@bliss:~/xenon/vendor/xiaomi/cancro$ grep -lir '_ZNK7MsgTask7sendMsgEPK6LocMsg' *
proprietary/lib/libloc_api_v02.so
proprietary/vendor/lib/liblbs_core.so
proprietary/vendor/lib/libgeofence.so
proprietary/vendor/lib/libflp.so


I wonder whether further adjustments of `up_threshold` and `sampling_rate` rate are required as outlined [here](https://forum.armbian.com/index.php?/topic/2869-armbian-for-orangepi-pc2-allwinner-h5/&page=9). Could we use `sysfsutils`/`/etc/sysfs.conf` (am away from any Linux box right now to check myself but will do later)


Sorry, I didn't realize about that. Done!


I just pushed fixes to master. I hope everything is now working back as expected :)
Thanks!


New Branches Creted


Probably for the best, to avoid any issues further along.


i did not understand logic
why you need joins or sql query?
why not eloquent?


After removing this function, unlogin user( when session time is expired) stopped work.


ok)


In line 105 script was ```cd```'ed to ```$assets_dir```. I think we could get away with file check without referencing ```$assets_dir```


貌似还要手动触发一下？


Maintainer override to address security vulnerability.


Thanks


So the application name was set to EasyiVoter which is going to conflict with the project if/when we merge with master, and the classpath for the jar doesn't need to be a local directory.


After update:

"Warning message:
Version of roxygen2 last used with this package is 6.0.1.9000.  You only have version 6.0.1"

In DESCRIPTION number stays at 6.0.1.9000. Maybe we should edit it by hand or go one commit back.


Well, I would set it to 2014 too, but see my comment on top. I don't want to work against the current definition of the end_date attribute of this repository. You can join the discussion at #286


Done in 0c6cd4cca52c722f1fb84ed5897b268eb1d567dd and 9ce077391d2a73b6a4a93020c743f72b7b735b9f.


```
$ shasum d.hatena.ne.jp-asannou-20170226-1.pdf d.hatena.ne.jp-asannou-20170226-2.pdf
6a2cd0570bc6d05cd4777a17925a2095e928582d  d.hatena.ne.jp-asannou-20170226-1.pdf
6a2cd0570bc6d05cd4777a17925a2095e928582d  d.hatena.ne.jp-asannou-20170226-2.pdf
```


@zsrkmyn  这里 track 了两个上游了啦。


小型绘图系统


[Your benchmark job](https://github.com/JuliaLang/julia/commit/23aef0c0e7d628960d7fc29ea2fb5ab78042dcaa#commitcomment-21156430) has completed - possible performance regressions were detected. A full report can be found [here](https://github.com/JuliaCI/BaseBenchmarkReports/blob/f0178841868ed48d981a6c133f22a63a72972c71/23aef0c_vs_3c9d753/report.md). cc @jrevels


I think I have already done all this - and I hope properly - in https://github.com/IARI/ultimate/commit/73daa0c4596b6f83060e6c668c485a76dd0ee015


@vircung that didn't work for me - I think it's because $build_dir is an absolute path, so the cd command has no effect on the if statement


This C++ code finds all answers to problem : VOLVO+FIAT=MOTOR


Interesting idea!  Have a look at perfect6502 which is a port of visual6502's transistor model to C - there's a good chance you can get the same result with not too much effort.


Note: proprietary/vendor/lib/hw/flp.default.so wasnt outdated
todo:
1. replace proprietary/lib/libloc_ds_api.so from bacon
2. check proprietary/bin/loc_launcher


这两个昨天报错了。。。
我今天很忙还没来得及修。。

我稍后会再让lilac打包一遍


we can, but in my case, the extra 'files' were actually invalid. They didn't exist. for example you delete a file and it's still in the DB, no point in logging it in that case.


Hi all,

I tried to build the current master branch with kodi/kodi-cec but it failed because of LibCEC lib issues. Would it be possible that this commit broke the kodi package ? It was working fine with the 2016.11.2 buildroot sources.