The test fails:

java.lang.AssertionError: Yor are NOT logged in expected [true] but found [false]
Expected :true
Actual   :false
 <Click to see difference>

	at org.testng.Assert.fail(Assert.java:94)
	at org.testng.Assert.failNotEquals(Assert.java:496)
	at org.testng.Assert.assertTrue(Assert.java:42)
	at test.MailRuCriticalPathTest.loginMailBox(MailRuCriticalPathTest.java:62)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:85)
	at org.testng.internal.Invoker.invokeMethod(Invoker.java:639)
	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:816)
	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1124)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:125)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:108)
	at org.testng.TestRunner.privateRun(TestRunner.java:774)
	at org.testng.TestRunner.run(TestRunner.java:624)
	at org.testng.SuiteRunner.runTest(SuiteRunner.java:359)
	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:354)
	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:312)
	at org.testng.SuiteRunner.run(SuiteRunner.java:261)
	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1215)
	at org.testng.TestNG.runSuitesLocally(TestNG.java:1140)
	at org.testng.TestNG.run(TestNG.java:1048)
	at org.testng.IDEARemoteTestNG.run(IDEARemoteTestNG.java:72)
	at org.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:127)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147)

You should wait for mail page loading will be completed. Please, fix it


I think you forgot recipes of casings (6 plates + framebox) in the assembler
Also why you did this?


Before:
![image](https://cloud.githubusercontent.com/assets/1058211/23467578/b8b7c346-fe9e-11e6-98a7-909744c7dd10.png)

After:
![image](https://cloud.githubusercontent.com/assets/1058211/23467653/eb158ed6-fe9e-11e6-9f87-ee76dafbd164.png)


TODO: Verify in a test case this actually un-does correctly? Make sure we do not accidently run into this bug again!


See https://github.com/facebook/react-native/pull/12603 for context.


We should really not use `var` anymore since `let` is always better with scoping. Also, `tags.forEach` is even more concise!


Thanks!


There are only `web3.toBigNumber(` changes in this commit.


Commenting for future viewers:
This is the line that fixes FB Messenger/Skype videocall. I honestly have no idea why they would need `proc_stat`, and I know that adding `allow` rules for the `unstrusted_app` context is stupid... but it only works this way.


@pimanac disabling code analysis was my first thought as well. Or at least disabling that rule / using a different rule set


default: if (P[i][p_job_team] == job) SendClientMessage(i, color, va_return(fmat, va_start<3>));


asdgfaf


@curran, it's most likely fine to remove (as I suspect you're right in that it's extraneous markup).  TBH, it's one of the bootstrapisms I strongly dislike is the number of nested and classed divs that we have to sprinkle liberally so much seasoning salt.


Yes, you missed a few steps but nothing mayor. I was pretty sure you'd have gotten them in a next PR.

But the bcmath stuff can be pretty tricky. Most people tend to use < and > and + and what-not but calculations with money are tricky. If I had a penny for every time somebody tried floating point operations on money, and they failed, I would have 5.000000000001 penny ;).

If you see something else that needs fixing, just send in the PR!


Bluemix Toolchain ([microservices-toolchain-demouseremail999](https://dev-console.stage1.ng.bluemix.net/devops/toolchains/2dff92b5-4656-433c-8dc1-85b3d5aa252c)): This commit has been deployed to STAGING by Delivery Pipeline ([ui-microservices-toolchain-demouseremail999](https://dev-console.stage1.ng.bluemix.net/devops/pipelines/c7b6c0cb-489c-4d37-9ee9-71516ff1f38f))


Something is still not working correctly around displaying battery status, can you double check your latest commit, please?


Why not name it `PI_`? `M_PI` makes it collide with system macros.


Мне кажется, или этот тест дублирует первый?


<!doctype>


Why does that not use `std::max` and `std::min`? And above all, why is it `0` and not `0.0`?


Nice, finally.


typo `we` => `were`?


Jep, forgot them. Changing them right now.
My expirience was that the multiblocks where extremely overpriced. Especially Bronze Blast Furnace and Destillation Tower. Changed all (besides fusion) because it was just stupid grinding at that point.


Why was this done and what is preferred course of action for those affected by this change?


In the later log messages, would I need to free all 3 the outs, even the ones that have already been pushed back? ie in the 2nd log message would I just free outs2? or both outs1 and outs2?


There isn't really any comprehensive documentation. @lahwaacz's link is a start, but IIRC there's more. See #2377 for the Chromium stuff.


![](https://github.trello.services/images/mini-trello-icon.png) [add info to readme](https://trello.com/c/srCSNBAo/12-add-info-to-readme)


The remote server returned an error: (401) Unauthorized. This is only error I m getting.


BTW, any idea why this is not triggered by the exception in `Queue.put()`?


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/9630f400-11cc-4e96-aa9f-5a43eca440cc) This commit has been deployed to PRODUCTION by [orders-api-microservices-toolchain-march1](https://console.stage1.ng.bluemix.net/devops/pipelines/4ffb8ae8-d898-4165-aa3d-c1580bffa6b2)


По-моему, мы договорились, что вывод блочной инструкции отображает те изменения, которые произошли в контексте данных. Вывод первого блока подавлен ";", а во втором блоке "x" не изменяется.


but why


@mheagin, just so I don't do this incorrectly, will you refork and make the changes you are mentioning here and we will get that merged. Thanks.


Ouch... why? :(

This is what broke file uploads.

GravityForms has some code that depends on `$_GET['view']` being entry.

Took a while to figure out where the code was and then easy to pinpoint.

So why was this done? What happens if we put it back?


I'm concerned about just backing up the corrupted region and replacing it with an empty one by default. Arbitrarily changing data like that has some potential pitfalls.

What would have happened in the past? I think in many cases the corrupted region would have continued working but would have just "acted weird"? If so, maybe it's better to just continue to throw errors when a region is corrupt and allow the admin to decide what to do.

Or maybe there could be a setting in pocketmine.yml to allow the admin to decide to "Automatically replace corrupted regions with empty ones?" Admins certainly want to know about corrupted regions so they can figure out what to do about it; but instantly replacing them may cause an emergency situation.

In a perfect world, we would have some sort of repair code. Something like McEdit's Repair Regions function. That way after we knew a region was corrupt we could just run the repair command and be fixed up.

I will see if I can find the source code to McEdit to understand how the repair function works. Maybe a plugin is in order.


Bluemix Toolchain: This commit has been deployed to TestEnv


Any particular reason you used doesn't-hang for this test, but not for the rotor-does-not-hang-on-infinite-iterable test?


fixed, thanks


sure :)


Nope. This is mysterious.


hw


asd


明天上线 :p


The biggest problem with our current GWT based UI is that this kinds of stuff are implemented using callback hell pattern (meaning that changing the cluster means that we fire an event. As a reaction someone listens to this and does something (e.g. loads the templates async and sets the selected one). When this is done someone else is listening to it and sets bunch of other properties (e.g. operating system for example but it is fun if it contains custom compatibility version). This change triggers other callbacks which can do some async operations triggering more callbacks. At the and you have 10 operations running in parallel which are touching the same model and are dependent of each other in a very un-obvious way. Reading this code is a pain and maintaining even bigger pain.).

One of the biggest advantages of react+redux+saga is that it can streamline this kinds of code using sagas, generators and immutable store. It is not so visible with this couple of properties but once you will start adding more and more interdependent fields you will hit this issue hard. So, please move this code into a separate saga to be able to utilize all the power of generators and have this code prepared to be clean even with bunch of properties.


one more type :(


In general the code looks very very nice!


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/9630f400-11cc-4e96-aa9f-5a43eca440cc) This commit has been deployed to PRODUCTION by [catalog-api-microservices-toolchain-march1](https://console.stage1.ng.bluemix.net/devops/pipelines/0759196c-05ca-463d-b861-dc92af4559b9)


All good man :) Congrats on the new device! I actually picked up a newer device than the one I work on (galaxy s4), but I kind of get a thrill from hacking the old stuff for some reason!


Remplacer par une constante
```java
final int numberValues = 10_000
```


This code is the final state of the application describe at this chapter : https://developer.android.com/training/basics/firstapp/index.html


Tried the code with this update, PC failed to open the .dll so the entire game stopped functioning. Now I'm beyond installing like 6 different things and I haven't even compiled any of this shit yet.
TBH good work but so much effort to make this work it's not going to be funny for anyone.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/9630f400-11cc-4e96-aa9f-5a43eca440cc) This commit has been deployed to PRODUCTION by [ui-microservices-toolchain-march1](https://console.stage1.ng.bluemix.net/devops/pipelines/24b2922a-9f81-40ba-b93e-005fb09e66f9)


로그가 필요한곳에서 MDC.get 하는게 아니라 , xml 파일에 gtxId 랑 userId 로 정의하면 모든로그에 찍히는형태로 수정해주세요.


need `\n` here and also line 41


It would also be sufficient to have one TusClient per TransloaditClient.


This leaves you with an empty div if you don't define the outerclasses. Wouldn't it be better to include the div in the if statement?


Yep, I'd just made a coding error. I've re-implemented the use of minc_displacement and they give the same (not exact, because minc_displacement generates unsigned short volumes, whereas the grid file produced by antsRegistration have double precision) results are using the _grid_0.mnc files directly.

So in short, false alarm!


I believe the idea is to use tus by default, what do you think @tim-kos and @kvz?


You have mistyped "then"; you have typed "thenw"...


print("Goodbye, World!")


The most annoying 'stupid grinding ' is finding ores in early game. 1st vein of Sn / Sb / Redstone etc.
I agree BBF could be cheaper. But in mid game and later AdvMinerII + crops (or bees) make from 8 up to 40 ingots of primary material from each ore block. So nothing can be too expensive :)


Super, merci de l'info!


Что тут с кодировкой?


тут?


Remove


forget to inc "skipped"


What is the meaning of a negative id?


Fix this


5. Szymon Wołodkowicz 208525


Bluemix Toolchain ([TestToolchain7](https://dev-console.stage1.ng.bluemix.net/toolchains/65e8b6f3-1fac-4f46-b4ab-8cadb655a2c5)): This commit has been deployed to YS1 by GitHub ([Delivery-Pipeline](https://github.com/jerome-lanneluc/Delivery-Pipeline))


At the later log messages you only need to freeReference on the bad sample.

Doing a freeReference on a sample that is also jbeing passed back in the
result list would be a bug - rather like accessing memory that has been
freed.

The three raw samples are independent, so one could have a checksum error
and the others may be OK, so you might as well do a freeReference and then
try to unpack the others.

if(! (checksum==uint16_t(data[8])))

    {
        WLOG(("WatlowCLS208 Bad Checksum: 1"));
        outs1->freeReference();
    }
    else {

        for (unsigned int i = 0; i < 8; i++){

            *douts1++ = (float)_fromBig->int16Value( (data[i])) / 10.0;
        }
        results.push_back(outs1);

    }

I also suggest checking the header of each sample.  As I remember there is
a byte or word indicating which (of the three) samples it is.  The current
Watlow code assumes the samples come in a certain order.  If that changes
for some reason, things will break.

On Wed, Mar 1, 2017 at 8:56 AM, Catherine dewerd <notifications@github.com>
wrote:

> In the later log messages, would I need to free all 3 the outs, even the
> ones that have already been pushed back? ie in the 2nd log message would I
> just free outs2? or both outs1 and outs2?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/ncareol/nidas/commit/dfbaea5bc29f6ecf1b9707ba900d4efce7c9aee8#commitcomment-21106633>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAcA-rctiTcrJTAR06FXdXtU2a3HrVhdks5rhZU5gaJpZM4MOxDX>
> .
>


I changed the typeahead.css file to include the 3 changes as stated above but as I inspect it, they still show and use the original values. I shut the PC off and started again, still the same. Why does it not recognize them? For instance, when hovering, the background-color should be green.
<img width="960" alt="screen shot" src="https://cloud.githubusercontent.com/assets/16246210/23469004/5ff256dc-fe70-11e6-9ec1-6eedfe4a2940.png">


thanks :D


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


I remember that we talked about this, and the problem is that you are putting a lot of pressure in the UI, IO and CPU. The best way to deal with this is, extract the lyrics while creating the playlist, and fetch it from the db when necessary. This way you are only parsing the file once.


hallo


Thats right, but not really easy to change.


1KiB is a quite low number here. It basically says how much data should be sent in one attempt. You usually only want to use a such low number if you want to know the upload progress very accurately, but with the tradeoff of a lower efficiency. It may be useful for you to test a few different values and benchmark their upload time but I suppose you could use values up to a few MiBs here.


Refactor, the queue is lockfree now


Dodalem nowego gita od zera :D


The null return was intentional as coded by LevelX in regards to Starfield of Nyx.  This may indeed need to be added back.  Check here for the reference.
https://github.com/magefree/mage/issues/1259


Yes tus whenever possible. Our projects should prefer our other projects over third party projects/libraries.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/703fe7e1-918b-44b7-9b15-2bbfb8d3f9f4) This commit has been deployed to STAGING by [ui-microservices-toolchain-demouseremail999](https://console.stage1.ng.bluemix.net/devops/pipelines/140c4cb0-38cb-4437-8cd6-408bb477eef6)


Multinomial Logistic Regression


Hi! I think you don't need to reference binaries location. Node will use those installed if called from packages.json.
In fact I could not run postinstall command if not calling them directly from node paths.

`    "postinstall": "sudo webdriver-manager update && bower install"`


Seeing as the 3 samples come squished together in one long sample, if one of the checksums if off, all the subsequent ones will be bogus anyway, because there won't be a way to determine how much of the 1st or 2nd sample was transmitted, so the start of the next one(s) would be ambiguous. If they were arriving as 3 separate samples I'd definitely check which sample it was, but as they aren't, and they do always (as far as the data I've seen) arrive in the same order, I think it'll be fine.


Created multidev environment [ci-example-d8-composer#pr-sshconfi](https://dashboard.pantheon.io/sites/c401fd14-f745-4e51-9af2-f30b45146a0c#pr-sshconfi).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-sshconfi-ci-example-d8-composer.pantheonsite.io/)


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/703fe7e1-918b-44b7-9b15-2bbfb8d3f9f4) This commit has been deployed to PRODUCTION by [ui-microservices-toolchain-demouseremail999](https://console.stage1.ng.bluemix.net/devops/pipelines/140c4cb0-38cb-4437-8cd6-408bb477eef6)


화면 UI에서 봤듯이
시간
분
초
이렇게 각각 설정하고 이미지를 배열에 있는 스트링으로 불러오는군여..


closes #6


后续将进行代码精简化


stylesheet added.


I know there is many iterations on this buttons. So what do you think of moving them to directive? This would make sense to you?


It would be nice to incorporate the ProtocolException and IOException (and maybe even the TransloaditSignatureException) into the TransloaditRequestException class to make the signature less heavy and make it easier for the consumer of this API (because he/she must take care of *all* possible exceptions).


@vabarbosa It now doesn't display the aggregation function (only the selected column name). Is that the expected behavior?


Hopefully the files all have three character file extensions? ;)


sorry about missing those, did some but had more there ...


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/9630f400-11cc-4e96-aa9f-5a43eca440cc) This commit has been deployed to PRODUCTION by [ui-microservices-toolchain-march1](https://console.stage1.ng.bluemix.net/devops/pipelines/24b2922a-9f81-40ba-b93e-005fb09e66f9)


这里写错了，应该是校对完成。


Hahaha that was me playing around, seeing if the '.' in my file extension was causing problems. :) The JavaScript client gets rid of it during escaping, so I wanted to make sure it wasn't the source of my errors. It's not.


Wouldn't this be simpler?

sent=raw_input("Enter the text to be encrypted:")
for i in sent:
	print var[i.upper()]," ",


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2210](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25111&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


coz


[inst/site/test_plot_plotly_assignment_g2.R:193:1:](https://github.com/seninp-bioinfo/MetaComp/blob/d3dc286ef583118bd9306ea7672cc4adc2a8590c/inst/site/test_plot_plotly_assignment_g2.R#L193) *style:* **lines should not be more than 100 characters.**
```r
dd <- data.frame(value = c(seq(0.01, 5, 0.01), seq(5, 100, 5)), x = factor( x = paste(c(1:20)), levels = c(1:20)),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/site/test_plot_plotly_assignment_g2.R:194:1:](https://github.com/seninp-bioinfo/MetaComp/blob/d3dc286ef583118bd9306ea7672cc4adc2a8590c/inst/site/test_plot_plotly_assignment_g2.R#L194) *style:* **lines should not be more than 100 characters.**
```r
                                             y = factor(x = paste(rep(1:26, each = 20)), levels = c(1:26)) )
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/site/test_plot_plotly_assignment_g2.R:195:1:](https://github.com/seninp-bioinfo/MetaComp/blob/d3dc286ef583118bd9306ea7672cc4adc2a8590c/inst/site/test_plot_plotly_assignment_g2.R#L195) *style:* **lines should not be more than 100 characters.**
```r
jet.colors <- colorRampPalette(c("#00007F", "blue", "#007FFF", "cyan","#7FFF7F", "yellow", "#FF7F00", "red", "#7F0000"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/site/test_plot_plotly_assignment_g2.R:195:71:](https://github.com/seninp-bioinfo/MetaComp/blob/d3dc286ef583118bd9306ea7672cc4adc2a8590c/inst/site/test_plot_plotly_assignment_g2.R#L195) *style:* **Commas should always have a space after.**
```r
jet.colors <- colorRampPalette(c("#00007F", "blue", "#007FFF", "cyan","#7FFF7F", "yellow", "#FF7F00", "red", "#7F0000"))
                                                                      ^
```
[inst/site/test_plot_plotly_assignment_g2.R:196:1:](https://github.com/seninp-bioinfo/MetaComp/blob/d3dc286ef583118bd9306ea7672cc4adc2a8590c/inst/site/test_plot_plotly_assignment_g2.R#L196) *style:* **lines should not be more than 100 characters.**
```r
jet.colors <- colorRampPalette(c("darkblue", "blue", "lightblue", "cyan2", "green", "yellow", "orange", "darkorange1", "red"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/merge_gottcha_assignments_count.R:15:1:](https://github.com/seninp-bioinfo/MetaComp/blob/d3dc286ef583118bd9306ea7672cc4adc2a8590c/R/merge_gottcha_assignments_count.R#L15) *style:* **Variable and function names should not be longer than 30 characters.**
```r
merge_gottcha_assignments_count <- function(assignments) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_merge_gottcha2_count_assignments.R:31:11:](https://github.com/seninp-bioinfo/MetaComp/blob/d3dc286ef583118bd9306ea7672cc4adc2a8590c/tests/testthat/test_merge_gottcha2_count_assignments.R#L31) *style:* **Variable and function names should not be longer than 30 characters.**
```r
merged <- merge_gottcha_assignments_count(input)
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/9630f400-11cc-4e96-aa9f-5a43eca440cc) This commit has been deployed to PRODUCTION by [orders-api-microservices-toolchain-march1](https://console.stage1.ng.bluemix.net/devops/pipelines/4ffb8ae8-d898-4165-aa3d-c1580bffa6b2)


Why `Condition*` here if you can use `std::unique_ptr<Condition>&` in the inner scope?


Bluemix Toolchain ([TraceabilityMicroToolchain4](http://localhost:3100/devops/toolchains/08fe0a11-85af-437f-8eb9-565dbda52a94)): This commit has been deployed to Staging_Micro1488385766284 by GitHub ([catalog-api-toolchain-demo-23fev](https://github.com/jauninb/catalog-api-toolchain-demo-23fev))


Same as above. Use `std::unique_ptr<Condition>&` to avoid naking the pointer.


You can possibly save some time (given bootstrap binaries, etc.) by doing `git clone git://github.com/ocaml/ocaml -b 4.05 --depth 1`


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/9630f400-11cc-4e96-aa9f-5a43eca440cc) This commit has been deployed to PRODUCTION by [catalog-api-microservices-toolchain-march1](https://console.stage1.ng.bluemix.net/devops/pipelines/0759196c-05ca-463d-b861-dc92af4559b9)


This is the file that is the example request to the canbus web service.


This comment sounds misleading to me as `myself` will be the next applicant woken up by `unlock()`. Or do I miss something and there's indeed an applicant at the *first* position? I nevertheless put the commit on staging to let the buildbot chew on it.


Added


LGTM


proper use of register save area


no colons (':')


<details>

<summary>No TaskCluster jobs started for this pull request</summary>

```js

The `allowPullRequests` configuration for this repository (in `.takcluster.yml` on the
default branch) does not allow starting tasks for this pull request.
```

</details>


This is not specific enough.


Error Prone still depends on the specific javac we repackage, and their are no immediate plan to change that. But if there are better-supported alternatives to using internal APIs we should migrate, and maybe some day that will make it possible to detach.


@garrettw I just wanted to ask what you think of having a new structure such as this? 🤔 It's not final, I just wanted a more experienced opinion. 😄 (The [`development`](https://github.com/PXgamer/devrant-php/tree/development) branch in general)


This will only show up if there are dependencies missing, but I think that you're right, this may cause problems. If I can find out how to detect whether STDIN is a TTY in python, that would be helpful.


Consider the following type of design to reduce code duplication

https://gist.github.com/jswaro/a21a9762417aff7f4d4ce7416657e6c7


newline


Tabs (sorry, ae uses tabs for indentation)


Closes #10


I would introduce the `timeout` param in a separate commit :+1:


unnecessary, still system imports below


I'm not sure this is the intended response for ENODATA? Can you verify by debug log that it returns FI_ENODATA for the exact condition we are intending to catch?


It may be optional dependency like pyopencl in my case.


We'll probably want a version of this for ourselves to ensure sc-foodcritic-rules are included


recover


Arduino RPM maintaner for Fedora here. I am carrying this patch as well, just wondering if it was ever proposed upstream so we wouldn't need to keep track of its fate at each release


oh! The strtok does fit very nicely into the for construct too! `for (tok = strtok(buf, delim); tok; strtok(NULL, delim) {...}`

I'd like to use a loop like this -- i'll give it a try.


hola amigos realizando pruebas....


Before:
![image](https://cloud.githubusercontent.com/assets/1058211/23470398/8f6ebd7a-fea6-11e6-9b2d-fafe5e272203.png)

After:
![image](https://cloud.githubusercontent.com/assets/1058211/23470341/6b6500e2-fea6-11e6-80aa-9a30de5870ec.png)


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2210](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25111&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Tests failed: 2 (2 new), passed: 262, ignored: 3 Build time: 00:15:11
### Failed tests
```
org.genivi.sota.core.DeviceUpdatesResourceSpec.sets device last seen when device asks for updates: <no details avaliable>

org.genivi.sota.core.DeviceUpdatesResourceSpec.Device GET updates sets last-seen: <no details avaliable>

```


these comments are OK

I *think* I am correct about the following... when you use HTML comments, they ultimately end up in a user's browser. That is fine as long as they do not contain any info you don't want to send to the user's browser.

If you want to make a comment that will *not* ultimately end up in the user's browser:
`{# this is a django template comment #}`


This is definitely going to prevent the app from building


So HTTP.jl actually has chunking built in via the chunked transfer encoding support. Would that work instead of manually chunking the file here? The problem here is that the multipart dict is expecting an IOStream value argument in the Dict.


Removing should do, they are not applicable anymore.


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2211](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25115&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


for sure, have we decided on that gem, etc?


FYI: It came in as a result of the merge-conflict. Kindly clean this up and run the app before you submit the pull request


Irfan Arissandi
5150311074


Some news about project.


@TimSchumi I'm amending this commit to add other changes, would tag you there


Have you reported this issue upstream?


Мопед не совсем мой, но попробую угадать. `fork`/`join` оперируют только sequence flow, эти операции не создают gateway-элементы.


Hello XieJuan,

You shoud be able to compile and use supernmotifs now since i add minor change in the makefile.

The error is due to an old version of GCC (GCC and g++ v4.4) which do not fully support the c++ version 11 (-std=c++11). I updated the makefile to use another common standard (support by old and most recent GCC) c++0x. So, this should your work for you. Further information can be found here
(https://gcc.gnu.org/projects/cxx-status.html#cxx11).<https://gcc.gnu.org/projects/cxx-status.html#cxx11>

Best,

JPG

________________________________
De : xj7757417771 <notifications@github.com>
Envoyé : 1 mars 2017 08:00
À : jpsglouzon/supernmotifs
Cc : Jean-Pierre Sehi Glouzon; Author
Objet : Re: [jpsglouzon/supernmotifs] -opt flaf -O3 (e516502)

Hello JPg,

I compile the software, then make,but it tell me "cc1plus: error: unrecognized command line option "-std=c++11"", it's the version of g++ don't meet the software? My g++ version was 4.4.7 (gcc version 4.4.7 20120313 (Red Hat 4.4.7-3) (GCC)), if there is a suitable version of supernmotifs for me?Thank you.

Best,
XieJuan

-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/jpsglouzon/supernmotifs/commit/e5165026b32e6c2faf0797988c2ffce934afc537#commitcomment-21103779>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AQWbdZplzI4Jvufi9WQeHn5H7YzmxPHMks5rhWv_gaJpZM4MHVky>.


tiny change that allows you to access a notifications options. Can be used to store an URL for example that later opens in the click event. I think the change I did only affects button clicks though?


An empty `div` should be pruned, i.e. `<div></div>`, right? As it stands, it will not


Thanks for merging the changes! We could cleanup all different Reader classes too (I don't believe they are used anymore) but we could as well leave them in for now.


Why?


Is it supposed to be `using the \code{from_zelig_model}` or `using the \code{from_zelig_model} function`? I.e., is `from_zelig_model` a function or a slot?


Also fixes three test failures related to #5779


Fixes #28


it's a function.

Round 2: https://github.com/vincentarelbundock/texreg/commit/672c8de59fd1b0c9fec8c8aae00b7349610d676f


yes....
you are right....


Some of the scripts load the config in, me and Yehonal was discssing this.


It seems like I wanted another Jan 28th this year when I labeled this.


thank you 😉


Created multidev environment [ci-example-d8-composer#pr-sshconfi](https://dashboard.pantheon.io/sites/c401fd14-f745-4e51-9af2-f30b45146a0c#pr-sshconfi).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-sshconfi-ci-example-d8-composer.pantheonsite.io/)


@NoahConnors Max has a good point here. The arcade drive numbers should go from -1 to 1, but the degrees to turn to a gear will probably be from, say -20 to 20.


As explained by Miguel,

> I've requested that Google bot recrawl the site. Once it does, it will see the meta tag and stop indexing. It normally takes a week or so for that to happen. The problem with the quick fix of the robots.txt file is that you can't do that and the meta tag simultaneously. The robots file blocks crawling, so the stop index tag never gets read by the bot.


What windows version are you on? It's possible that for some reason the DLL can't be opened on older versions in which case I can try to fix that.

Anyways, not sure what those "6 different things" are because you need to install rustup and MSVC and that's it.


Checksums mismatches simply state (with some strong certainties) something was altered in transmission. It could be a range of changes:  bit flips ( either in data or checksums), additional or dropped bits or bytes.  Just because there is a checksum issue does not mean the data is all garbage, it usually  means something was corrupt in transmission - potentially the checksum itself may be the culprit, dont just assume bits/bytes were dropped.


Why remove that?


@mashkovskiy добавьте возможность обнаружения позиции пользователя на карте друзьями (из социальных сетей, контактов — на ваше усмотрение). и не забудьте возможность отключить эту опцию)


do you propose that we have system imports and system from imports as one group, looking like the following:

```
import multiprocessing
from os.path import abspath, exists, isfile, join, getmtime
import shutil
from time import sleep
import unittest
```

`isort` rewrites them as

```
import multiprocessing
import shutil
import unittest
from os.path import abspath, exists, getmtime, isfile, join
from time import sleep
```

But then that "group" is now not alpha ordered.
However, afaics, alpha order is not mentioned in the PEP8 style guide wrt imports.


Will require some cleaning up.


Bluemix Toolchain: This commit has been deployed to TestEnv


Hadn't thought of that possibility, I'll add that that. Would I want to return false if any of the 3 were bad, or only if all of the three were bad?


I cannot see those working on w.org previewer : https://www.dropbox.com/s/3n0xixutbtyl7iy/Screenshot%202017-03-01%2017.02.39.png?dl=0 @rodica-andronache


newline


extra line?


Works fine for me:
![image](https://cloud.githubusercontent.com/assets/370329/23471331/f8877566-fe76-11e6-8778-64077cb966fb.png)


THIS IS THE COMMIT WHERE WE TRIED TO FIX THE PROVIDER CHANGING ERROR!!!


currently I mix them up (like the first example). Good to know how `isort` handles this...

Alright then, choose what you like ;) I would though prefer no newline between them, but up to you 👍 :)


Yes. Actually, the `cr_assert` below will report the error code if it's not -FI_ENODATA.

The exact error condition is caught at line 246 in gnix_fabric.c and the user will be warned if this happens but the return value `-FI_EINVAL` that is returned from this is ignored in `__gnix_ep_getinfo`.

The `fi_getinfo` man page doesn't list `-FI_EINVAL` as an error but says the return value may be negative on error. I will update the return value.


Neat! For performance, you may want to add an explicit (positional) constructor to that struct, and to enable cl-lib optimizations (`(cl-declaim (optimize (speed 3) (safety 0)))`)


I thought this should be displayed only if the user is looged in ,as sane default


@sun1x @mynameisjulia I suggest adding not only transmitting information, but also reading with the second device via camera. (Should work at short distances like <5m)


submission accepted


@marcello: Ok should i take it out, or will you ?


Хуй


@BaranovYaroslav чи не хотіли б ви робити проект сумісно з @nikitakirichek (https://github.com/TableBooking/ios-client)? У вас досить схожі юс-кейси й до того ж різні платформи.


lol @jwu910 I like your "on a plane can't push" -- the power of Git, letting you commit even offline.
How's the logic going with your cards? Does it work as intended now?


Hier verbindet sich das nodeMCU mit dem Wifi, verbindet und eine freie IP vom DCP zugewiesen bekommt. Soll verbessert werden: wie kann das NodeMCU eine feste IP anfordern?


The less code the better. Could you please put those constructors inline in the class declaration, trying to put "{ }" on the same line (if 80 lines permits)? You can see how this is done for other constructors in uipcp-normal.hpp


this warning is pretty annoying and doesn't really interfere in any way. Can we remove it?  At the most we need to tell people to install a udev rule file - currently I'm using this one:

```
$ cat /etc/udev/rules.d/10-px4.rules
#26ac:0011
ATTRS{idVendor}=="26AC", ATTRS{idProduct}=="0011", ENV{ID_MM_DEVICE_IGNORE}="1"
```


@BozhkoAlex к шерингу ещё и возможность редактирования листов несколькими пользователями одновременно


So weird...! Sprint devices are CDMA, the right property should be lteOnCdmaDevice, and we set the prop for Sprint here: https://github.com/JDCTeam/android_device_samsung_jf-common/blob/783f3789440660f51612ae113311ed1e33c9d444/init/init_jflte.cpp#L218 like all CDMA variants.. Everything is working fine? Tested network search and network mode too? :)
Uh another thing: i've tried camera patches but unfortunately doesn't work for me, stock and SDcamera video recording is still broken, and the funny thing is that remove MALLOC_SVELTE flag fixes video recording on front camera with SDCamera for me, but the rear camera still crashes when the preview starts


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.33.1-pre-4-g539a0bf](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=53026&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **SUCCESS**
Summary: Running Build time: 00:00:45


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2212](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25121&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


Bluemix Toolchain: This commit has been deployed to TestEnv


ah.. do you think is not ok to display them by default right?


WTF MAN, WHY THAT


didnt try myself.a tester reported that this lteOnCdmaDevice is working...i remember a commit at opt/telephony regarding that though.

About camera...hmmm...really strange.keep in mind that i rebased again from 7.1.0 to 7.1.1 ...can u grab any log :/ ?


for consistency with other parts of the code, could you rename this field as "rib"?


@gastaldi Never trust a caller of a method to do the right thing. :)  The best way to protect against NPEs is to limit the use of nulls.


don't add full tracks


Не билдится. =/

> Err http://us-central1.gce.archive.ubuntu.com/ubuntu/ trusty-updates/main uidmap amd64 1:4.1.5.1-1ubuntu9.2
>
>   503  Service Unavailable [IP: 104.197.100.230 80]
>
> E: Failed to fetch http://us-central1.gce.archive.ubuntu.com/ubuntu/pool/main/s/shadow/uidmap_4.1.5.1-1ubuntu9.2_amd64.deb  503  Service Unavailable [IP: 104.197.100.230 80]
>
> E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
>
> The command "sudo apt-get install uidmap -y" failed and exited with 100 during .
>
> Your build has been stopped.


ToDo


Oh well it fixed it better than me  👍


The content of these files are wrong. Language codes are missing. the ui.en.fr is "special" as it as the key "" instead of the language code. See ui.fr.js for an example.


嗯对的。可以是一个删除加上一个增加，也可以是一个移动。


Could it be that this change introduced a new Bug?
We tried to translate a record which resulted in the following error message:
````
ERROR => "You have an error in your SQL syntax; check the manual that corresponds to y
      our MariaDB server version for the right syntax to use near 'AND tt_content.
      deleted=0' at line 1" (172 chars)
   lastBuiltQuery => "SELECT uid,sys_language_uid FROM tt_content WHERE  AND tt_content.deleted=0" (75 chars)
````
As far as I could trace and understand it the where-clause for workspacesAwareRecordService::get has to be a fully valid where-clause. BackendUtility::deleteClause('tt_content') evaluates to "AND deleted=0" so at the end an SQL-Query like "WHERE  AND tt_content.deleted=0" is executed.


did you see the revamp branch? i think i fixed/changed q lot in there, but vague memories


the code i uploaded is not the code that was meant to be put on this repo. i'll have to redo the merge


After this commit the `tested` job fails to evaluate, which is a channel blocker.
```
$ nix-instantiate nixos/release-combined.nix -A tested --dry-run
trace: warning: The option `services.xserver.desktopManager.kde5' defined in `/home/vcunat/nix/pkgs-1/nixos/modules/installer/cd-dvd/installation-cd-graphical-kde.nix' has been renamed to `services.xserver.desktopManager.plasma5'.
trace: warning: The option `services.xserver.desktopManager.kde5' defined in `/home/vcunat/nix/pkgs-1/nixos/modules/profiles/graphical.nix' has been renamed to `services.xserver.desktopManager.plasma5'.
trace: warning: The option `services.xserver.desktopManager.kde5' defined in `<unknown-file>' has been renamed to `services.xserver.desktopManager.plasma5'.
error:
Failed assertions:
- SDDM auto-login requires that services.xserver.desktopManager.default and
services.xserver.windowMananger.default are set to valid values. The current
default session: none is not valid.
```

ATM I don't see what exactly is wrong, and I'm inclined to revert (for now) unless someone finds a fix soon.


@TanyaOhotnik @olgasaliy добавьте совместное редактирование бюджета


added substring and subarray details


Thanks!


no find_by (which performs a new query), keep find (on enumerable)


remove indent


!quantities[du.id].nil? <---> quantities[du.id]


@whywillywhy take a look at style formatting https://github.com/airbnb/css#formatting
Do not create class name this way "mainPage_Channels", please fix to 'main-page-channels' || 'main-page main-page-channels'.


Unfortunately no, `Resumable.js` requires this kind of manual control so that it can e.g. resume uploading of a large file even after the broswer/client restarts, by negotiating with the server about which chunks have already been uploaded.  E.g. in this case, if the `GET` returns `HTTP 200 OK` for this chunk, we do not `POST` the chunk up again.


[T6A1][T11-A1]Fenyi Ye(Q3)


Ah, good to know, thanks


So while chunked encoding is a way of solving uploading large files, it won't let me implement a `Resumable.js` interface.


@whywillywhy we were spoking about mocking data. I do not see any. Hardcode data in reducer and use from there.


no find_by


[T6A1][T11-A1]Fenyi Ye(Q4)


of changed quite a lot, poco is gone  into an addon, so might not be good for you if you are in an old v of OF


@whywillywhy create a separate file and define there all constants like color, border, font-size etc. And import this file where needed.


Bluemix Toolchain: This commit has been deployed to TestEnv


[T6A1][T11-A1]Fenyi Ye(Q2)


@AnnaSamonenko добавьте интеграцию с  [last.fm](https://www.last.fm/)


@whywillywhy use mock data from reducer


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2212](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25121&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **SUCCESS**
Summary: Tests passed: 308, ignored: 4 Build time: 00:16:28


@whywillywhy use mocked data from reducer


Ouch....  :-( I'm late with this.

I just start to work on similar feature and want to notice what your `--sni` option does not honour `-N,--host-cn` option. Is that expected/reviewed?

Can you provide your use-cases how to use this new option?

My use-cases, which I'm working on:

1) Cloudflare-protected domain, I need to verify cert on my server, not on Cloudflare side.
So, I need to connect to server by IP:PORT, ask for certificate (using SNI ) and do checks.
2) Load-balancer, same ceritificate on several servers.
So, I need to connect each of them by IP:PORT, ask for certificate (using SNI) and do checks.

From my first point of view, solving these requires adding new `--ip` option. In that case `-H host` option will provide SNI value and can be used for `-N,--host-cn` check as already implemented.

Usage: `check_ssl_cert -I 1.2.3.4 -H ssl.example.tld --host-cn`

I had some doubts, is `-H host` and `-I 1.2.3.4` can confuse people? Looks clean enough, but...

With new `--sni` option I'm unable to use `-N, --host-cn` at practice. But, of course, I can use `-n hostname` and will use current implementation in the following way:

`check_ssl_cert -H 1.2.3.4 --sni ssl.example.com -n ssl.example.tld`

That is also looks clean, and already implemented, what outweighs.


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2213](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25124&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2213](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25124&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:18


add `|| Long.TYPE.equals(type)`


@whywillywhy i do not see any usage of variables


@mmwork
### 1.utilファイルの即時関数について
utilファイルは汎用的なメソッド定義するため場所かと思います。
なので、即時関数内で行っている処理がutilファイルに入っているのに違和感を感じました。
この手の処理は無理にメソッド化はせずに、viewファイルの初期化処理（各オブエクトのinitializeメソッド実行時）にそのまま実行してしまってもいい気がしています。
メソッドを作る際は、定義場所やメソッド化の要否を考える癖をつけていきましょう！
無理にメソッド化をしようと思うと可読性を落とすこともあるので、注意が必要です。

### 2.resetBtnメソッドについて
メソッドはプログラムの振る舞い(動き)を表すものなので、resetBtnという命名は修正した方がいいかと思いますー。
また、このresetBtnというメソッド自体必要でしょうか？
ぱっとみ不要に見えたので、resetBtnをコメントアウトして動作確認をしたところ、特に不具合は無いように感じました。
上記ご確認いただけますと幸いです。


I see, single M, double T. Fixed


__API Description file syntax error on line 1__: expected API name, e.g. '# <API Name>' (Autogenerated message from apiary.io)


Is there a general way to check if the udev rule exists?
Can we make adding the udev rule simple in a way that works across most distros?


Oh good. Thanks for the update!


[inst/site/test_plot_plotly_assignment_g2.R:193:1:](https://github.com/seninp-bioinfo/MetaComp/blob/6dcd17d14ab7c7af30d2094c9b2168739d2c7de2/inst/site/test_plot_plotly_assignment_g2.R#L193) *style:* **lines should not be more than 100 characters.**
```r
dd <- data.frame(value = c(seq(0.01, 5, 0.01), seq(5, 100, 5)), x = factor( x = paste(c(1:20)), levels = c(1:20)),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/site/test_plot_plotly_assignment_g2.R:194:1:](https://github.com/seninp-bioinfo/MetaComp/blob/6dcd17d14ab7c7af30d2094c9b2168739d2c7de2/inst/site/test_plot_plotly_assignment_g2.R#L194) *style:* **lines should not be more than 100 characters.**
```r
                                             y = factor(x = paste(rep(1:26, each = 20)), levels = c(1:26)) )
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/site/test_plot_plotly_assignment_g2.R:195:1:](https://github.com/seninp-bioinfo/MetaComp/blob/6dcd17d14ab7c7af30d2094c9b2168739d2c7de2/inst/site/test_plot_plotly_assignment_g2.R#L195) *style:* **lines should not be more than 100 characters.**
```r
jet.colors <- colorRampPalette(c("#00007F", "blue", "#007FFF", "cyan","#7FFF7F", "yellow", "#FF7F00", "red", "#7F0000"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/site/test_plot_plotly_assignment_g2.R:195:71:](https://github.com/seninp-bioinfo/MetaComp/blob/6dcd17d14ab7c7af30d2094c9b2168739d2c7de2/inst/site/test_plot_plotly_assignment_g2.R#L195) *style:* **Commas should always have a space after.**
```r
jet.colors <- colorRampPalette(c("#00007F", "blue", "#007FFF", "cyan","#7FFF7F", "yellow", "#FF7F00", "red", "#7F0000"))
                                                                      ^
```
[inst/site/test_plot_plotly_assignment_g2.R:196:1:](https://github.com/seninp-bioinfo/MetaComp/blob/6dcd17d14ab7c7af30d2094c9b2168739d2c7de2/inst/site/test_plot_plotly_assignment_g2.R#L196) *style:* **lines should not be more than 100 characters.**
```r
jet.colors <- colorRampPalette(c("darkblue", "blue", "lightblue", "cyan2", "green", "yellow", "orange", "darkorange1", "red"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/merge_gottcha_assignments_count.R:15:1:](https://github.com/seninp-bioinfo/MetaComp/blob/6dcd17d14ab7c7af30d2094c9b2168739d2c7de2/R/merge_gottcha_assignments_count.R#L15) *style:* **Variable and function names should not be longer than 30 characters.**
```r
merge_gottcha_assignments_count <- function(assignments) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_merge_gottcha2_count_assignments.R:31:11:](https://github.com/seninp-bioinfo/MetaComp/blob/6dcd17d14ab7c7af30d2094c9b2168739d2c7de2/tests/testthat/test_merge_gottcha2_count_assignments.R#L31) *style:* **Variable and function names should not be longer than 30 characters.**
```r
merged <- merge_gottcha_assignments_count(input)
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


Ну взяли бы одну переменную, зачем два раза одно и тоже делать


![](https://github.trello.services/images/mini-trello-icon.png) [Actualizacion del AddIn de Estandares](https://trello.com/c/YoniTkOJ/4-actualizacion-del-addin-de-estandares)


just
```
p += sizeof(crc);
 eepromConfigSize = p - &__config_start;
return crc == CRC_CHECK_VALUE;


Differenze con windows: no delimitatore #, bensì regola come dovrebbe essere scritta poi sul file che va in build, quindi per esempio
anzichè
       genitore(Padre,Figlio)#
si scrive come chiede prolog
      genitore(Padre,Figlio).


Yeah MSVC needed some visual studio stuff that I hadn't downloaded.
It works now, OOC and chat works again. Although the code (unedited apart from name) is giving a bunch of errors;

[17:53:32] Runtime in unsorted.dm,1610: Unknown encoding received from client: "gb2312". Please report this as a bug.
  proc name: stack trace (/proc/stack_trace)
  usr: Player (Player) (/mob/new_player)
  usr.loc: The floor (8, 81, 2) (/turf/unsimulated/floor)


@wonderchook Here is the commit.


Great!


Hi Miek,

I'm wondering why is it mandatory to run external lookup for the target name if it is not a sub domain of current origin? I think it would be better if we can setup an option between recursive DNS and iterative DNS.

The issue I have is if I don't setup `proxy` middleware in Corefile, it will panic when I only have its CNAME record in zone file.

```
02/Mar/2017:01:02:15 +0800 [PANIC www.atoom.net. A] coredns/middleware/proxy/proxy.go:142 - runtime error: invalid memory address or nil pointer dereference
```

Thanks,
Zhipeng


nice one


@lwrubel check this out!


When writing, you just append CRC (or its inverted value in this case).


Test comment


Hi, is this API free? @temilaj


Such as, telling people to "go fuck yourself" in a code commit.


what about that?


:cry:


Bluemix Toolchain: This commit has been deployed to TestEnv


Added here: https://github.com/whosonfirst/whosonfirst-properties/blob/master/properties/src.md


Вынеси расчёты времени в функцию принта. Чтобы в цикле не тратить на это время. Разница маленькая конечно будет, но всё же не по пацански, мы же считай делаем отметки времени, сразу считать не должны


Before:
![image](https://cloud.githubusercontent.com/assets/1058211/23472615/c5790aae-fead-11e6-8202-ba979b438563.png)

After:
![image](https://cloud.githubusercontent.com/assets/1058211/23472629/d7df9f00-fead-11e6-9402-c46a3f85b288.png)


[inst/site/test_plot_plotly_assignment_g2.R:193:1:](https://github.com/seninp-bioinfo/MetaComp/blob/3846648f5a098db86fa841bbfe95fad2652a6adf/inst/site/test_plot_plotly_assignment_g2.R#L193) *style:* **lines should not be more than 100 characters.**
```r
dd <- data.frame(value = c(seq(0.01, 5, 0.01), seq(5, 100, 5)), x = factor( x = paste(c(1:20)), levels = c(1:20)),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/site/test_plot_plotly_assignment_g2.R:194:1:](https://github.com/seninp-bioinfo/MetaComp/blob/3846648f5a098db86fa841bbfe95fad2652a6adf/inst/site/test_plot_plotly_assignment_g2.R#L194) *style:* **lines should not be more than 100 characters.**
```r
                                             y = factor(x = paste(rep(1:26, each = 20)), levels = c(1:26)) )
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/site/test_plot_plotly_assignment_g2.R:195:1:](https://github.com/seninp-bioinfo/MetaComp/blob/3846648f5a098db86fa841bbfe95fad2652a6adf/inst/site/test_plot_plotly_assignment_g2.R#L195) *style:* **lines should not be more than 100 characters.**
```r
jet.colors <- colorRampPalette(c("#00007F", "blue", "#007FFF", "cyan","#7FFF7F", "yellow", "#FF7F00", "red", "#7F0000"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/site/test_plot_plotly_assignment_g2.R:195:71:](https://github.com/seninp-bioinfo/MetaComp/blob/3846648f5a098db86fa841bbfe95fad2652a6adf/inst/site/test_plot_plotly_assignment_g2.R#L195) *style:* **Commas should always have a space after.**
```r
jet.colors <- colorRampPalette(c("#00007F", "blue", "#007FFF", "cyan","#7FFF7F", "yellow", "#FF7F00", "red", "#7F0000"))
                                                                      ^
```
[inst/site/test_plot_plotly_assignment_g2.R:196:1:](https://github.com/seninp-bioinfo/MetaComp/blob/3846648f5a098db86fa841bbfe95fad2652a6adf/inst/site/test_plot_plotly_assignment_g2.R#L196) *style:* **lines should not be more than 100 characters.**
```r
jet.colors <- colorRampPalette(c("darkblue", "blue", "lightblue", "cyan2", "green", "yellow", "orange", "darkorange1", "red"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/merge_gottcha_assignments_count.R:15:1:](https://github.com/seninp-bioinfo/MetaComp/blob/3846648f5a098db86fa841bbfe95fad2652a6adf/R/merge_gottcha_assignments_count.R#L15) *style:* **Variable and function names should not be longer than 30 characters.**
```r
merge_gottcha_assignments_count <- function(assignments) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_merge_gottcha2_count_assignments.R:31:11:](https://github.com/seninp-bioinfo/MetaComp/blob/3846648f5a098db86fa841bbfe95fad2652a6adf/tests/testthat/test_merge_gottcha2_count_assignments.R#L31) *style:* **Variable and function names should not be longer than 30 characters.**
```r
merged <- merge_gottcha_assignments_count(input)
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


> gb2312

Uh, are you Chinese?

I can add support for that though, when I get back home.


@technomancy Does that package depend on the node package from debian or does it assume it's already installed on the machine?

It looks like to me that this package only [recommends](https://github.com/yarnpkg/yarn/blob/master/resources/debian/control.in#L3) nodejs and doesn't _depend_ on it -- probably so people don't accidentally install the node package from deb if they don't need it?


@jerpelea https://github.com/zachariasmaladroit/android_kernel_sony_msm8994_kitakami_r2/commit/718231809feade0ab4b5b6dd0f8af943fa897169


Above you mean `(E, E'')`, and I think it would be clearer with the definition of `E''` inlined above.


This one...


And this one?


awesome!  Nice work!
> On Feb 28, 2017, at 6:14 PM, adamucho <notifications@github.com> wrote:
>
> Nice got it working !
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub <https://github.com/adamucho/Final-Project/commit/af75ab639967454cc408fc005fad7b8e207127e6#commitcomment-21098415>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACLQwyktnmvgXA4mc_D0g8mY7EdGQO8iks5rhNRygaJpZM4MPGIQ>.
>


В таком случае ты получишь время выполнения только последней итерации, так как каждый раз значение переменной startFor и endFor будут перезаписываться


this whole 3 lines can be cleaned...there is no memsql related code in this repo


Created multidev environment [ci-example-d8-composer#ci-414](https://dashboard.pantheon.io/sites/c401fd14-f745-4e51-9af2-f30b45146a0c#ci-414).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-414-ci-example-d8-composer.pantheonsite.io/)


Is `getPosOffset` wrong in minecarts?


please add localhost:2181...without that tests won't run...this line can be cleaned:
-#zookeeperList = "md-bdadev-122.verizon.com:2181,md-bdadev-119.verizon.com:2181,md-bdadev-138.verizon.com:2181"


How about using JDK's 8 Optional instead?


keep the localhost:9092...test will fail with it.


Tillagd idag


keep localhost:9092 line...tests will fail without it


throw an exception if longValue > Integer.MAX_VALUE


why complain here? you know WTE, you know nexttv - those are the people to force for a update. If you revert they have the time to do something (or not) till eternity.


@thehelix112 we need to clean the memsql block and the zk list with internal ip...the localhost is not a verizon specific ip/port...


This should be a record since its growing so much.


I like that we can use the component's lifecycle hooks to run these actions.

I initially thought that we could store the original protocol in state and use componentWillUnmount to redirect back.

But that obviously won't work because the app will have reloaded. :-(


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2214](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25128&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


I think it's good to be able to define which routes to force without the LoginView needing to know about the redirection.


Hi

I agree either `--ip` or `-I` as suggested in https://github.com/matteocorti/check_ssl_cert/commit/2f3d8bca8a0c60c68bd1b52e77b8f63ca8611a0c#commitcomment-20857084


Mais tout fonctionne jusqu'à la fin pour toi ? Tout s'ajoute correctement, End et Arrows ?


I mean there are no need to make mid & late game multiblocks cheaper.


Oh no I'm not this was just from some player. But I'm not sure if it will affect him or how, just figured you'd want to know of any errors any way.


Missing an indent. You might also want to make this a module function rather than an anonymous function. Might help to do things with guards to clean up a bit.


In the past, your server would have frozen for maybe hours. Trust me, if an error occurs when opening a region, it's junk. That's the only time a replacement will occur.


Missing spaces around operators.


🚢 it!

@rhubert: I prefer tools to not wrap output. My terminal (erm, emacs *shell* buffer) does that just fine, and it complicates parsing output.


This is interesting looking.  I'd like a walk through sometime.


Drops error here

![screen shot 2017-03-01 at 17 44 47 1 mar 2017](https://cloud.githubusercontent.com/assets/7574974/23473053/ce880b92-fea6-11e6-80b3-adce77a082ab.png)


@zzak sorry I forgot to follow up on this--I ended up adding nodesource as an apt repo and explicitly installing their version of `nodejs`. Please note that I have zero experience with either node or yarn, and I welcome review on that; I could be missing something obvious.

https://github.com/circleci/cci-demo-flask/commit/a3977060964cd0752415415d979ca6fe42db1d7e


Apparently Clang is fine with redundant friends, but GCC-on-Travis is very unhappy about it. (Now regretting that I didn't attempt "unfriend" joke in the commit line)


確かにそうですね。コードをみて条件文がたされているのをみてそう訳していましたが、コードを良く見るとたしかに仰るような動きのようです。ありがとうございます。


Sure


I thought we didn't want this?


おお (^^;)


images files for Homework$


@Simanio submission accepted


Unhandled Failure


注釈入れ忘れかと思います。足しておきます。


welcome


This seems to violate point number 5?


Yeah, I'm a newbie at Git, so, sometimes, I'm making such doubts.


@technomancy sweet, i was just curious so I looked at how they build the deb. In the original PR it _was_ a hard dependency weirdly.

Your commit looks :+1: to me!


Hey Dude , You Must review again before this file your upload !


Ha, to be completely honest, those were pretty recent additions. I only wish I had the gumption to revisit and clean up some of these skins.


I'm a bit concerned about all of this.  As we predicted last year via the ML, having a user download a 2MiB+ json document for every page load might not be the best of ideas :-)

A change in storage (mongodb) would be expensive consuming a lot of time to rework things.  The only other option I can think of is an intermediate service that reads the status.json, caches it in memory, then renders a page from that to control how the data is accessed.  That would help prevent the status.json from getting hammered while not requiring a change in design.


Why the -1? And not 0? Seems like adding the -1 is just adding logic for no gain.


Because this your file is Brokend ! you need Fix it , before all people download this file and run it !


attempts to address #101 by consolidating previously (similarly named) macro and removing the hack of using Link.Diameter as the pump index.


Beyond1Airloop (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


I'm a bit concerned about all of this. As we predicted last year via the ML, having a user download a 2MiB+ json document for every page load might not be the best of ideas :-)

A change in storage (mongodb) would be expensive consuming a lot of time to rework things. The only other option I can think of is an intermediate service that reads the status.json, caches it in memory, then renders a page from that to control how the data is accessed. That would help prevent the status.json from getting hammered while not requiring a change in design.


parenthesis?


Пфуй 2 уже стабилен?
Интерфейс не разнесет?
Или еще подождать?


done


Aurélien qui s'égare


For example, you could try this on a test server:
- set world format to anvil
- cd worlds/world/region
- echo "somegarbagedata" > r.0.0.mca
- start server
- tp to 0 128 0
- server freezes, cannot kill process, server writes out tens of gigabytes worth of junk
- end up force-killing the machine


Esto es un comentario


he quitado 2 letras


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2215](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25131&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


This rule works cross distros


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2215](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25131&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:11


You don’t need `pify` here, as `.process` returns [a promise](https://github.com/unifiedjs/unified#returns-6)!


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2216](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25134&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2216](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25134&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:11


Вроде уже не ломает ничего


@Chrysostomus can you please revert this and commit the changes to **util-menu** only? Somehow you have committed an older version of the other files and it's creating some conflicts here ... ;)


<details>

<summary>No TaskCluster jobs started for this pull request</summary>

```js

The `allowPullRequests` configuration for this repository (in `.takcluster.yml` on the
default branch) does not allow starting tasks for this pull request.
```

</details>


А что добавили в кратце?


*WOW*


Incorrect mention I believe. @marcelloceschia :-)


@justawhiteguy


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2217](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25139&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2217](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25139&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:06


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2218](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25142&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


I think I rather remove that diff. The checksum logic is such that retries are done if there is checksum error, and only after some retries and sleeps, backup would give up


@justawhiteguy i updated the readme instructions for installing and running things


Bluemix Toolchain: This commit has been deployed to TestEnv


OK


tnx! fixed in 2.0.6


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2219](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25143&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2214](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25128&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 263, ignored: 3 Build time: 00:16:12
### Failed tests
```
org.genivi.sota.device_registry.DeviceResourceSpec.POST request on 'ping' should update 'lastSeen' field for device.: <no details avaliable>

org.genivi.sota.device_registry.DeviceResourceSpec.First POST request on 'ping' should update 'activatedAt' field for device.: <no details avaliable>

org.genivi.sota.device_registry.DeviceResourceSpec.POST request on ping gets counted: <no details avaliable>

org.genivi.sota.core.DeviceUpdatesResourceSpec.sets device last seen when device asks for updates: <no details avaliable>

org.genivi.sota.core.DeviceUpdatesResourceSpec.Device GET updates sets last-seen: <no details avaliable>

```


@quinnj I feel a fool.  This is all I needed to do.  Of course.


Beyond1Airloop (mjwitte) - x86_64-MacOS-10.9-clang: OK (2462 of 2471 tests passed, 587 test warnings)

 * 587 tests had: AUD diffs.
 * 514 tests had: BND diffs.
 * 10 tests had: EIO diffs.
 * 2 tests had: ESO small diffs.
 * 2 tests had: Table small diffs.
 * 1 test had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.64%25-yellow.png)


lol je l'ai déjà fait tout ça. A mon avis, tu as pas du récupérer toutes mes modifications ... tu as bien pull ?


Uploaded pdf file


@BryanRice800 if the monster is unawakened (4th digit == 0), then it only checks the first 3 digits.
By the way, for new monsters, I used to only look at the monster collection, that would give me the id of all monsters. Otherwise, I'd visit some of the top arena ranked players and see if they have the monster.


**вдогонку** пишется слитно, т.к. наречие


Looks like we forgot to add `keys/equifax_rsa` and `keys/equifax_rsa.pub` to `.gitignore`. @pkarman Wanna submit a PR for that?


Is it valid?


Да, именно. Этот в целом низкоуровневый билдер, но спасает от надобности задавать SequenceFlow вручную.


Return non initialisé dans le cas ou le malloc foire


The structure was not really simplified. Was it smaller?


Why didn't you change the file name accordingly?


Ok pour ça, c'était ça mon gros problème je pense !


Nice !


Remove the dead code.


Aucun check sur ```dst``` et ```src``` avant de déréfencer ?


Just realized it would only work when it's more than one commits behind (because it says commit, not commits)
I'll add that later with something else. Not too important


Ok, je comprend mieux. Merci


This has multiple grammatical errors.
![image](https://cloud.githubusercontent.com/assets/22889346/23473796/bada507e-fe6e-11e6-889f-ea9b01c4a473.png)


How did you did? Summarize in the subject of GIT commit messages.


Ah yes, that would work too! After your last comment, I was worried I'd have to re-architect the multipart stuff, but yes, I did add in the ability to use any IO type, not just IOStreams to be sent as files.


Aucun check sur la validité des pointeurs ```s1``` et ```s2``` ? Et sur la valeur de ```n``` ?


This is not the right way to handle policy warnings. The correct fix is to actually use the new behavior (the old behavior is there for backwards compatibility, *not* as a choice to keep using the old behavior). Policies may be removed in future versions of CMake, leaving only the new behavior.


Niquel, comme ça, j'ai plus besoin de faire ça :
```
Client client = (Client)window.DataSelect.SelectedItem;
window.DataSelect.Text = client.nom + client.prenom;
```


Dans le cas ou t'envoie NULL dans s1 ou s2, tu rentre pas dans la boucle, mais tu déréférence un pointeur NULL dans le return !


Pas de check sur dst, src et len ?


What is "another order"?


If useless du coup, tu return si le malloc foire (Pareil pour le return NULL en bas)


[Uploading Button.py…]()

[Uploading Codes.py…]()
[Uploading Code_to_take_Input.py…]()

[Uploading **Extraction_of_data_from_Linkedin_one_entry.py…]()
[Uploading Extraction_of_data_from_website.py…]()

[Uploading Extraction_of_Stock_Details.py…]()
[Uploading Extraction_of_text_of_Wiki.py…]()
[Uploading Fuzzy_Analysis.py…]()
[Uploading Geography_codes.py…]()
[Uploading Get_Stock.py…]()
[Uploading GUI.py…]()
[Uploading GUI1.py…]()
[Uploading GUI_Exp.py…]()
[Uploading GUI_User_Details.py…]()
[Uploading Import_Statistics.py…]()
[Uploading Membership_for_size.R…]()
[Uploading Membership_Function.R…]()
[Uploading Membership_Function_for_Importance.py…]()
[Uploading Neural_Network.py…]()
[Uploading NLP_Analysis.py…]()
[Uploading nlp_task.py…]()
[Uploading Regex.py…]()
[Uploading Stock.sh…]()
[Uploading Stock_Market_Analysis.py…]()
[Uploading Yahoo_Shares.py…]()


admire /\w


[ Quoting <notifications@github.com> in "Re: [coredns/coredns] Implement ext..." ]
>Hi Miek,
>
>I'm wondering why is it mandatory to run external lookup for the target name if it is not a sub domain of current origin? I think it would be better if we can setup an option between recursive DNS and iterative DNS.

Well, it becomes sort of mandatory when you put coredns up as a recursive
resolver. But there should be a way to say "disable this feature"

>The issue I have is if I don't setup `proxy` middleware in Corefile, it will panic when I only have its CNAME record in zone file.

That's a bug that should be fixed.

>
>```
>02/Mar/2017:01:02:15 +0800 [PANIC www.atoom.net. A] coredns/middleware/proxy/proxy.go:142 - runtime error: invalid memory address or nil pointer dereference
>```
/Miek

--
Miek Gieben


Why not using the existing flann or the wrapper https://github.com/openMVG/openMVG/blob/master/src/openMVG/matching/matcher_kdtree_flann.hpp#L27

PS: Pretty sure that the metric defined there is faster than your L2DistanceSquared_AVX2 since the loop is unrolled
https://github.com/openMVG/openMVG/blob/develop/src/openMVG/matching/metric_avx2.hpp#L27


Понятно, а почему все учебники стараются использовать составное форматирование?


I would like to see this put back in. How about -


> **Tip** Want to see these features as soon as possible? You can download [Insiders](/insiders) and use the features before the monthly release.


crase correta


![](https://github.trello.services/images/mini-trello-icon.png) [Change network spawn](https://trello.com/c/gagsSId9/45-change-network-spawn)


double `be`.
Copy/paste of my own typo 😄


won't this break on IE tho? according to the history it looks like IE requires a loaded audio element in order to set the currentTime.

We might be able t fix this with the `preload` attribute. If you set it to `'none'`, chrome won't open a request. Now whether or not preventing the audio element from preloading will cause the same error in IE remains to be seen.


après avoir essayé sur [https://www.lua.org/cgi-bin/demo](https://www.lua.org/cgi-bin/demo) le code suivant : `print(string.match("domain.tld/bozon/index.php?f=", "index%.php%?p=.*$"))
print(string.match("domain.tld/bozon/index.php?p=login", "index%.php%?p=.*$"))
print(string.match("domain.tld/bozon/index.php?p=&token", "index%.php%?p=.*$"))`
j'ai bien en résultat :
`nil
index.php?p=login
index.php?p=&token
index.php?p=&a`
le regex lua match donc comme il faut par contre pas avec SSOwat. Bogue de SSOwat ou je loupe qqch d'autre ?


Well, the constructor is called just once, so not much overhead to use the keywords.

I had thought about changing the safety level. I timed the code in issue 82 in my repo, and the time was the same as when I had used my hand-rolled vector. Maybe after I have greater confidence in the code we can lower the safety level.


Otherwise LGTM
Thank you!


that'll  take a lot of gumption. i'd wager at least 3-5 lbs.

weren't you guys moving to the more atomic UI elements anyway?


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2218](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25142&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **SUCCESS**
Summary: Tests passed: 308, ignored: 4 Build time: 00:15:50


Testing


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2219](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=25143&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **SUCCESS**
Summary: Tests passed: 282, ignored: 3 Build time: 00:15:39


The following doc(s) have been deployed to the [wordpressc](https://wordpressc-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/guides/wordpress-commandline](https://wordpressc-static-docs.pantheonsite.io/docs/guides/wordpress-commandline)


The status page is showing most of the data from the JSON, so my guess is it is roughly as big as the JSON file, if not larger. This is why I did not go with generating the HTML on the server side.
It just happens that there is lots of data, there is not much we can do about that if we want to show it in a single status page.

Also, the JSON is large only if you rebuild everything. When you trigger a build only of changed packages, it will be much shorter.

Processing the JSON server-side is interesting however, for other reasons: it allows to collect the state from multiple builds, and different architectures, to generate a single agregated datasource. From that we can know when a particuler package last built succesfully, which archs it works on, etc.


Hi Matteo!

Are you want  new `-I` option to appear?

If so, then l create new issue to move all discussions there.

Current implementation is enough for my needs, but if I can help to project, I can implement/test `-I` option.

Please confirm. :)


@eddy-geek I was wondering whether `extract_path_params` should be using the werkzeug [parse_rule](https://github.com/pallets/werkzeug/blob/master/werkzeug/routing.py#L182) function for matching and extracting the `descriptor` and `name`?

```python
>>> from werkzeug.routing import parse_rule
>>> list(parse_rule('/name/<string(length=2):id>/'))
[(None, None, '/name/'), ('string', 'length=2', 'id'), (None, None, '/')]
```


This link won't work since we don't have the `www` subdomain before 1kgenomes. `http://1kgenomes.ga4gh.org`


I think you can simplify this just handling the normal (non-decam community pipeline) case here. So something like
```
calibType = self.getCalibType(filename)
destination_filename = butler.get(calibType + "_filename", info)[0]
...
```

Then the overridden version in obs_decam will contain the more complicated version (I'll leave a comment over there.)


Ah ok. Cool


realizando mas pruebas


Beyond1Airloop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1277 of 1277 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-36.83%25-green.png)


OK


Thank you


Amending, some derps


Congrats!


crase correta


Good


The reason I didnt use text is because its translated to other languages (or should be sometime soon)
Thats why I had it change the numbers to a single # sign and compare them then, thats why I did it that way.

Maybe you can just check for:
```python
check = sickbeard.versionChecker.updater.get_update_url().split('?')[0]
if check in existing['message'] and check in message:
    sickbeard.SITE_MESSAGES[index] = to_add
    return
```


The -1 here confuses me. Also missing spaces around the operator.


why is this commented out?


I think we need to move the logic from copy_new_purge_info to here.


Ok, I'll see if I know how to revert...


Nice!


Are you expecting `OnRenderLoopTick` to be called from multiple threads?


you can simply do
```
git revert d3e88b4681d0cbc61356a6e7ce0800da096563c0
```


same


ничего, изменен в версии 2.0 изменен api  и теперь фиксы идут


@TimSchumi you may review this


Merged into master...


Formatting is weird here. Usually when we break things before the anonymous function it should look like:

```erlang
FoldFun =     fun({OldDocInfo, {UUid, Id, Revs}, {UpdSeq, RAcc, PaAcc, PuAcc}) ->
        case purge_doc(UpdSeq, OldDocInfo, Id, Revs) of
            ...
        end,
    end,
InitAcc = {UpdateSeq, [], [], []},
{_USeq, Replies, Pairs, Purges} = lists:foldl(FoldFun, InitAcc, DocInfosPurges),
```


OK


@blogic, @dangowrt, @nbd168, there seems to be issues with the PCIe driver currently in 4.9.13:
```
mt7620-pci 10140000.pcie: MT7620 PPLL unlock
mt7620-pci: probe of 10140000.pcie failed with error -1
```
I could make it work by replacing it with the K4.4 backport. Maybe [this upstream fix](https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=aaa0bf22cb84c7b29c814f3fcf3951c747b904d6) unearthed a bug on some HW?


& above: same


There's a config:get_integer/3 call you can use instead of list_to_integer.


Интерполяция появилась недавно, учебники писались давно :-) Будем пользоваться свежими технологическими достижениями фреймворка! :-)


Spaces around operators


Formatting. Put the start_key/end_key on their own line indented one level with the closing ] at the same indent as Opts.


Changing `cols <- names(sample.labels)` to `cols <- c(1:length(sample.labels))` corrects a bug in functions: plotReverseCumulatives, exportToBed, plotInterquantileWidth, that affects a *coerced* CAGEset.


done


It occurs to me that we should check if the code exists rather than failing with a function not found error. And if its not found we send a crit or err log message.


IsClientExists would probably be better as just ClientExists.


Good job!


I'd break out the time lag calcuation into its own function. Perhaps as a thing in couch_util that just takes two string times.


There's a simpler method for this called `psutil.cpu_count()`


Please review [PR](https://github.com/dotnet/core-eng/pull/528) for design contract.


We'll want to revisit these log messages for clarity.


Sorry to resurrect this, but who is going to delete this TypeChecker?


Thank! :) I have another question:
What's going on with the dialog in **uefi_bootloader()**?
```
DIALOG " $_InstUefiBtTitle " --menu "$_InstUefiBtBody" 0 0 2 \
      "grub" "-" 2>${PACKAGES}
```
How can ``"systemd-boot")`` be selected at all??


(caught by the static analyzer)


OK


The number of + 1 and - 1 operations around purge sequences is complicated. We should look harder at these as there's a whole saying about off-by-one errors.


`Unable to determine link location from file:` should be localized.


I think you have removed systemd-boot at some point, right? Should we remove it completely or leave it like that for now?


WikiHowSearchResult init with {


It cannot. It is disabled until it is supported. The original had some stuff for different kernels, but our kernels are different. Same thing with syslinux. Its the issue #10 in main repo.


Spaces around operators. Also if your if statements get big then you probably want to look at using a case statement for clarity.


Thanks. Unfortunately I couldn't get it to distribute all videos while satisfying the cache size constraint. Even tried [this binpacking package](https://pypi.python.org/pypi/binpacking), but that also used 101 bins. The last ~50 points weren't important enough to further investigate that stuff ^^'


a negative identifier is an _anonymous_ filter. It should never occur when filters are compiled with Talismane, but for robustness we must handle this case. The question is "is a token filter a single token by default?".


I'd probably just use read_repair as a reference to the operation. Making it plural seems a bit odd.


I would like us support more bootloaders, but I don't see it as high priority issue. We could just jump straight to grub though instead of providing a single choice menu for the time being...


So I will continue with util-base and util-disk, then? Have you done util-desktop more or less and shall I leave that alone for tonight? Or if you just push what you have I can maybe do some more on it.
We don't need a working version immediately...


There's a trailing whitespace here causing make to fail :(


ok, i might be doing something wrong then, i saw that i got the code in source atleast and also in config, maby flags or something is wrong, idk gona check it later, thanks


iOS.

- Al crear un ViewController, tenemos que enlazar una clase con él, la creamos. Tercer icono, show identity inspector. Y tenemos que determinar que es la pantalla inicial en el primer icono.

- Para conectar un botón con la siguiente pantalla, Ctrl y arrastrar hasta la ventana que queramos - Show.

*ELEMENTOS*

Conectamos los elementos con Ctrl a su clase .h

———CLASE .h———

IMAGEVIEW
@property (weak, nonatomic) IBOutlet UIImageView *imagenJohn;
LABEL
@property (weak, nonatomic) IBOutlet UILabel *johnLabel;
BUTTON
@property (weak, nonatomic) IBOutlet UIButton *btnBorrar;
ACCIÓN BUTTON: se le da el nombre del método al que llamará.
- (IBAction)btnActionBorrar:(id)sender;
TEXTFIELD //Para introducir texto
@property (weak, nonatomic) IBOutlet UITextField *textfieldIntroName;
SWITCH
@property (weak, nonatomic) IBOutlet UISwitch *switchControl;
TABLEVIEW CONTROLLER
//Añado la propia tabla a su .h para poder recargarla después, por ejemplo.
@property (strong, nonatomic) IBOutlet UITableView *tabla;

—>VARIABLES GLOBALES EN APPDELEGATE.h<— (Se implementan en su .m)
//Por ejemplo, un array:
@property (nonatomic, retain) NSMutableArray *listaNombres;
—>APPDELEGATE.m<— //Aquí las inicializamos y damos valores o whatever.
self.listaNombres = [[NSMutableArray alloc]init];
[self.listaNombres addObject:@"María"];

—>PARA QUE OTRAS CLASES ACCEDAN A LAS VARIABLES GLOBALES<—
//Deben importarla:
Las demás deben importarla e inicializarla en sus .m:
#import "AppDelegate.h"
//Declarar un objeto que en cada clase se llame distinto, aunque es el mismo (appDel, appDele…):
AppDelegate *appDele;

//Instanciarlo en (void)viewDidLoad{}
appDele = ((AppDelegate*)[[UIApplication sharedApplication]delegate]);
//Hecho esto ya accedemos a sus variables:
[appDele.listaNombres count]; por ejemplo.

———CLASE .m———

Para editar sus atributos en código, en la clase .m:
LABEL
self.johnLabel.text = @"John Wayne"; //Ponemos el texto del Label
//sizeToFit hace que el label se adapte a lo que ocupe el texto introducido.
[self.LabelShowName sizeToFit];
//Font family
[_label_title setFont:[UIFont fontWithName:@"Verdana" size: 16]];

//Color texto y fondo
_DNInombre.textColor = [UIColor blueColor];
_DNIemail.backgroundColor = [UIColor greenColor];
IMAGEVIEW
self.imagenJohn.image = [UIImage imageNamed:@"johnwayne.jpeg"]; //Especificamos el nombre completo de la imagen.
BUTTON
//Texto para el estado normal, hay más estados.
[self.btnGuardar setTitle:@"Mostrar Datos" forState: UIControlStateNormal];
//Color de fondo para el botón
_DNIPpalbtnOutlet.backgroundColor = [UIColor redColor];
TEXTFIELD
self.textfieldIntroName.text; //Para acceded al texto introducido

ARRAY
//Inicializar
 lista = [[NSMutableArray alloc]init];
//Añadir elemento
[lista addObject:_ArrayNames.text];
//Tamaño del array
NSUInteger longitudArray = [lista count];

TABLEVIEW CONTROLLER
//Para recargar el tableview controller al volver hacia atrás de otra vista en la que le hemos añadido datos.
- (void)viewWillAppear:(BOOL)animated{
    [self.tabla reloadData]; //Esta "tabla" es porque la hemos conectado en .h
}

//Los métodos de table que hay que modificar:
- (NSInteger)numberOfSectionsInTableView:(UITableView *)tableView { //Secciones de la tabla
    return 1;
}
//Número de filas que tiene la tabla.
- (NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section {

    return [appDele.listaNombres count];//Aquí lo hacemos de forma dinámica, podemos poner un número fijo.
}
//Lo que contiene cada celda. A este método se le llama tantas veces como filas tenga la tabla.
//En la declaración del método tenemos @"datos", ese datos es el identificador que he dado a la celda en la vista diseño, en atributos-identifier, seleccionándola.

- (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath {
    UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:@"datos" forIndexPath:indexPath];

    // Configure the cell...

    //Decimos qué label está en mi celda. A cada label le hemos dado un número en Tag en la pestaña Atributos-Tag, para ahora poder referirnos a ellos.
    nombres = (UILabel*) [cell viewWithTag:1];
    telefono = (UILabel*) [cell viewWithTag:2];
    email = (UILabel*) [cell viewWithTag:3];

    //Decimos qué datos deben aparecer en cada label.
    nombres.text = [appDele.listaNombres objectAtIndex:indexPath.row];
    telefono.text = [appDele.listaTelefono objectAtIndex:indexPath.row];
    email.text = [appDele.listaeMail objectAtIndex:indexPath.row];
    //Una imagen, por ejemplo
	imagen.image = [UIImage imageNamed:[appDel.listaImagenes objectAtIndex:indexPath.row]];

    return cell;
}
//Para saber el index de la fila que hemos pinchado
- (void) tableView:(UITableView *) tableView didSelectRowAtIndexPath:(nonnull NSIndexPath *)indexPath{

    NSLog(@"Ha seleccionado la fila: %ld",(long)indexPath.row);
    //Aquí le doy el valor del index a una variable global que he creado en AppDelegate.h
    appDel.rowSelected = indexPath.row;
    //Llamo a una vista que quiero abrir
    [self showViewController:detailProduct sender:nil];

}

ALERT
//Inicialización

alertCorrect = [UIAlertController alertControllerWithTitle:@"Mensaje" message:@"Datos añadidos" preferredStyle:UIAlertControllerStyleAlert];

    UIAlertAction *yesButton = [UIAlertAction actionWithTitle:@"OK" style:UIAlertActionStyleDefault handler:^(UIAlertAction * _Nonnull action) {
        //Yes clicked. Aquí manejamos lo que hace al darle al Yes. Si no hacemos nada y solo hay un botón, cierra el alert.
    }];

    [alertCorrect addAction:yesButton]; //Decimos qui el alert tine un button yes. Puede hater un No también, por ejemplo, o ninguno.

//Para llamarlo:
[self presentViewController:alertCorrect animated:YES completion:nil];

VIEWCONTROLLER //Para abrir una vista desde código

UIViewController *listaPpal; //Declaramos un objeto que será el de la pantalla a la que queremos ir
- (void)viewDidLoad {
//El @"ListaPpal" es el identifier que hemos dado en diseño a la vista, tercer icono - identity
listaPpal = [self.storyboard instantiateViewControllerWithIdentifier:@"ListaPpal"];
}
//Para llamarla
[self showViewController:listaPpal sender:nil];

———DECLARACIONES——

STRING

NSString* valorIntroducido = _textFieldIntroNumber.text;

//Unimos los strings para mostrar el nombre completo en una variable:
//Le estamos especificando el formato que tiene con stringWithFormat. Cada %@ es el valor de un campo.
//Tenemos tres %@, para el nombre, apellido1 y apellido2, y se los pasamos en orden a continuación.
NSString *nombreCompleto = [NSString stringWithFormat:@"El nombre completo es %@ %@ %@",
                                self.textfieldIntroName.text,
                                self.textfieldIntroApellido1.text,
                                self.textfieldIntroApellido2.text];
ARRAY
//Dinámico
NSMutableArray *lista;

ALERT
UIAlertController *alertCorrect;

NAVIGATION CONTROLLER
Lo arrastramos al storyboard en nuestra vista. Para añadir un botón al menú que nos incluye en nuestra vista, debe ser un BAR BUTTON ITEM, en el que hay iconos en Atributos-System Item con el dibujo que queramos. Conectaríamos el botón con la vista que queramos, como cualquier otro botón.

—FUNCIONES—

//Función simple void.
-(void)actionBtn2 {}
//Para llamarla:
[self actionBtn2];
//Función cuyo parámetro de salido es un String y de entrada un int:
- (NSString*) formatNumber:(int)value{}
//Llamar a esa función cuyo resultado va a ser un String, pasándole un int:
NSString *resultado = [self formatNumber:contador];

——EXPRESIONES——
//Traza en la consola pasando una variable.
NSLog(@"Entro en actionBtnUnique con %@", _label_title.text);

//De int a String. La d es porque es un dígito.
NSString *resultado = [NSString stringWithFormat:@"%d", value];

//De String a int
int operando1Int = [operando1 intValue];

//Comparar Strings
if([_labelNumber.text isEqualToString:value]){}


I had pushed the changes, but they got reverted now.


У меня нет идей что добавлять!
Поломаю все, а потом буду чинить!
(с) Шагу.


This commit adds a better mapping option to `<space>` elements as well as coloring possibilities for rests to match those of notes.

Example:

Humdrum data:

```
**kern	**color
*M4/4	*
=1	=1
4ryy	.
4c	.
4	.
4d	.
=2	=2
4r@	.
4r	orange
4r@	.
4r	purple
==	==
*-	*-
!!!RDF**kern: @ = marked note color=blue
```

Notice that the first space in the SVG output is encoded in Humdrum as `4ryy` which means an invisible quarter rest (`yy` means the entire token is invisible, while a single `y` would mean the previous component of the token is invisible, such as a forced invisible (i.e. gestural) accidental in `4c#y`).

The second space on beat 3 of the first measure is mapped from `4` in the Humdrum data.  This `4` is a `**recip` value meaning a quarter-note duration.  But the token is neither a note, nor a rest, so it is most usefully mapped to a space in the MEI data.   This will make space elements in Humdrum look cleaner (`4` as opposed to `4ryy`).

The example also shows how to color rests using an `RDF` directive to define a user signifier to mean that the rest (or note) should be given a particular color, and the `**color` spine can be used to apply a wider range of colors to notes/rests in the spine(s) to its left.

This encoding system is also useful for interactive data entry in VHV, where a `**recip` value is usually typed before the pitch or rest information is added to the note.  The newer verovio rendering of unpitched notes is a bit distracting:

(previously it would have been rendered as a note on the top line of the staff).

Conversion to MEI:

```bash
$ ./verovio input.krn -t mei --all-pages --no-layout
```

```xml
<?xml version="1.0" encoding="UTF-8"?>
<?xml-model href="http://music-encoding.org/schema/3.0.0/mei-all.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>
<?xml-model href="http://music-encoding.org/schema/3.0.0/mei-all.rng" type="application/xml" schematypens="http://purl.oclc.org/dsdl/schematron"?>
<mei xmlns="http://www.music-encoding.org/ns/mei" meiversion="3.0.0">
    <meiHead>
        <fileDesc>
            <titleStmt>
                <title />
            </titleStmt>
            <pubStmt />
        </fileDesc>
        <encodingDesc>
            <appInfo>
                <application isodate="2017-03-01T10:28:06" version="0.9.14-dev-e1d1173">
                    <name>Verovio</name>
                    <p>Transcoded from Humdrum</p>
                </application>
            </appInfo>
        </encodingDesc>
        <workDesc>
            <work>
                <titleStmt>
                    <title />
                </titleStmt>
            </work>
        </workDesc>
        <extMeta>
            <frames xmlns:humxml="http://www.humdrum.org/ns/humxml">
                <metaFrame n="14" token="!!!RDF**kern: @ = marked note color=blue" xml:id="loc14">
                    <frameInfo>
                        <startTime float="8" />
                        <frameType>reference</frameType>
                        <referenceKey>RDF**kern</referenceKey>
                        <referenceValue>@ = marked note color=blue</referenceValue>
                    </frameInfo>
                </metaFrame>
            </frames>
        </extMeta>
    </meiHead>
    <music>
        <body>
            <mdiv>
                <score>
                    <scoreDef xml:id="scoredef-0000001112017317">
                        <staffGrp xml:id="staffgrp-0000000210971800">
                            <staffDef xml:id="staffdef-0000000307541403" clef.shape="G" clef.line="2" meter.count="4" meter.unit="4" n="1" lines="5" />
                        </staffGrp>
                    </scoreDef>
                    <section xml:id="section-0000000547776127">
                        <measure xml:id="measure-L3" n="1">
                            <staff xml:id="staff-L3F1N1" n="1">
                                <layer xml:id="layer-L3F1N1" n="1">
                                    <space xml:id="space-L4F1" dur="4" />
                                    <note xml:id="note-L5F1" dur="4" oct="4" pname="c" color="4r">
                                        <accid xml:id="accid-L5F1" accid.ges="n" />
                                    </note>
                                    <space xml:id="space-L6F1" dur="4" />
                                    <note xml:id="note-L7F1" dur="4" oct="4" pname="d" color="4r">
                                        <accid xml:id="accid-L7F1" accid.ges="n" />
                                    </note>
                                </layer>
                            </staff>
                        </measure>
                        <measure xml:id="measure-L8" n="2" right="end">
                            <staff xml:id="staff-L8F1N1" n="1">
                                <layer xml:id="layer-L8F1N1" n="1">
                                    <rest xml:id="rest-L9F1" dur="4" color="blue" />
                                    <rest xml:id="rest-L10F1" dur="4" color="orange" />
                                    <rest xml:id="rest-L11F1" dur="4" color="blue" />
                                    <rest xml:id="rest-L12F1" dur="4" color="purple" />
                                </layer>
                            </staff>
                        </measure>
                    </section>
                </score>
            </mdiv>
        </body>
    </music>
</mei>
```


Bluemix Toolchain: This commit has been deployed to TestEnv


ok no problem! i can see it in the commIt then :)


он просто улучшил работу аддона, а теперь правит, то что сломалось, дальше pfUI будет лучше работать с другими аддонами


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/9630f400-11cc-4e96-aa9f-5a43eca440cc) This commit has been deployed to PRODUCTION by [catalog-api-microservices-toolchain-march1](https://console.stage1.ng.bluemix.net/devops/pipelines/0759196c-05ca-463d-b861-dc92af4559b9)


Doesn't this mean that the store will be created only once when the server starts? Shouldn't we create it again each time for each new request?


Thanks!


yeah pp is the example where it's private.


@marcello: Sorry about that !


```
const comment = (state, action) => {
  switch (action.type) {
    case 'COMMENT_TOGGLE_BOLD ':
      return {
        ...state, //support stage-2
        bold: !state.bold
      }
    default:
      return state
  }
}
```


this should probably be a=2


cool, but as far as UI design goest, I'm not sure everyone will
* know what to do
* know that something can be done
* know what happened or why if they touch accidentally
;->

Also I'd really have liked the buttons for mouse users as well. Leet doesn't mean it can'be userfriendly.


FWIW, I think you have to put multi-word font names inside quotes.


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/9630f400-11cc-4e96-aa9f-5a43eca440cc) This commit has been deployed to PRODUCTION by [ui-microservices-toolchain-march1](https://console.stage1.ng.bluemix.net/devops/pipelines/24b2922a-9f81-40ba-b93e-005fb09e66f9)


I'll recommit fast before going to sleep


at commit c330c12: @nanosoldier `runbenchmarks(ALL, vs = "@3c9d75391c72d7c32eea75ff187ce77b2d5effc8")`


Thank you man! Good night! :)


@douglasbakkum How are you merging pull requests? I like the summary in the commit message :+1:


[[Bluemix DevOps]](https://console.stage1.ng.bluemix.net/devops/toolchains/9630f400-11cc-4e96-aa9f-5a43eca440cc) This commit has been deployed to PRODUCTION by [orders-api-microservices-toolchain-march1](https://console.stage1.ng.bluemix.net/devops/pipelines/4ffb8ae8-d898-4165-aa3d-c1580bffa6b2)


#5922-OutputVariable-Facility-Total-HVAC-Electric-Demand-Power-does-not-show-in-the-rdd (mjwitte) - x86_64-MacOS-10.9-clang: OK (2471 of 2471 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


at commit 419653f: @nanosoldier `runbenchmarks(ALL, vs = "@3c9d75391c72d7c32eea75ff187ce77b2d5effc8")`


Doesn't resolve #1046 and #1617 (at least in 0.4.1). Maybe it should resolve, however in my case allocation still fails and *only* removal of `reserved_ports` does the trick.

Anyways it would be nice to see the reason of particular failure, not just mitigation.


Applied later suggestion (removed condition, do ibuf_delete_for_discarded_space() always instead)


I did not find origin of this specific hunk in Percona tree. It comes from a  huge initial patch 3 years ago. I think it might have to do with percona's ability to handle  backups of old versions, but I'm not sure. I'll remove and we'll see if there are any complaints


Thanks for pointing.
Yes, you're right. Wanna make a PR?


I'd prefer to keep the variable, for this and remove_from_data_dict_if_does_not_exist. At least it gives a descriptive name to variable. it is passed then to a function with 9 parameters, and so if descriptive names are removed, it is very hard to see what are those conditions actually for. The variables will be removed by the compiler optimizer anyway.


Why do u need it bro?


1. FLANN uses pointers instead of indexes to address nodes. Consequently, i) the data structure cannot be trivially uploaded to the GPU, and ii) I do computations with AVX2; adapting FLANN to this would take longer time than writing a new implementation. Also, iii) FLANN uses much more space per node than is necessary, which is cache-unfriendly. This implementation uses 8 bytes per node. iv) I want to experiment with various stuff. Not feasible with FLANN.

2. i) I don't think that branch unrolling has much to say because backward branches (as in loops) are by default predicted as taken, unless the CPU "proves" otherwise by collecting traces. Unrolling may actually make the code slower overall because it takes more space in L1 I-cache. ii) The implementation you linked to seems suboptimal because it does 2x memory loads than is necessary and combines 128/256-bit operations (should be avoided as much as possible). iii) The input data isn't forced to 16-byte alignment meaning that a single memory load may generate multiple hardware memory transactions.


> if you revert and nobody complains anymore you will be stuck with that version.

That's nonsense. How did the 4,.8.3 kernel come into existence?  Who was complaining, and about what, to get that provided?
It's also **totally** irrelevant. Could you please explain why you think continuing to use a kernel that is _demonstrably broken_ is a good idea?