![badge](https://img.shields.io/badge/appsnap-warning-cdb62c.svg) There are 20 visual regressions in this pull request

Please Visit https://github.com to check out these diffs
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale

| Diff 1 | Diff 2 | Diff 3 | Diff 4 | Diff 5 | Diff 6 | Diff 7 | Diff 8 | Diff 9 | Diff 10 | Diff 11 | Diff 12 | Diff 13 | Diff 14 | Diff 15 | Diff 16 | Diff 17 | Diff 18 | Diff 19 | Diff 20 |
| ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- |
| [![Image of Diff1](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone7-back%20to%20Rogue%20on%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff2](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6-back%20to%20Rogue%20on%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff3](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone5-back%20to%20Rogue%20on%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff4](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone7-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff5](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone7-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff6](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff7](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone5-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff8](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone5-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff9](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone7-back%20to%20similar%20movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff10](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff11](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6Plus-back%20to%20Rogue%20on%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff12](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone5-back%20to%20similar%20movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff13](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone5-Similar%20Movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff14](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6-Similar%20Movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff15](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6-back%20to%20similar%20movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff16](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone7-Similar%20Movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff17](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6Plus-Similar%20Movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff18](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6Plus-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff19](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6Plus-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff20](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6Plus-back%20to%20similar%20movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) |


Thank you for your answer.
I just realized it myself and had deleted my comment but you were faster.


Good point. Yes, it makes sense to share the flags between the website and the language app.

Although we probably need to move them over to the docs/_include directory in order for jekyll to find them (a symlink won't work, because as far as I know the jekyll installation used on Github is configured to not follow symlinks), and adapt post_build.sh to copy them from there (same as for the favicon).


![](https://github.trello.services/images/mini-trello-icon.png) [R12. Create CMS2File class to encapsulate information gathered from each file](https://trello.com/c/QTVzhqRk/52-r12-create-cms2file-class-to-encapsulate-information-gathered-from-each-file)


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/d82d830c-d81f-47da-8a0d-926eb78fbb91 "ArtesianBore"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/0b93f73a-9ee8-4e41-844e-8354a83495f8 "ArtesianBore") deployed this commit to [WaterCorp](https://console.ng.bluemix.net/apps/edf111e2-aeba-4007-bcec-c37d2e056c94 "ibm:yp:us-south:dwoo@nz1.ibm.com:WaterCorp")


looks like a lot of changes but did find and replace tabs with 4 spaces. I didn't think it would be an issue since my editor is set to do a tab as 4 spaces, but I replaced them all


@wescande on a eu des problemes ici: quand on fork pas faut bien envoyer 0...


For this line, what kind of object is `nb`? The string name of the notebook doesn't work.


There are a lot of set calls being done with `silent: true`.  Can you look into removing them?  I would rather events get triggered and ignored in the handlers than have an event get inadvertently missed.


// TODO: - Test todo issue


The following doc(s) have been deployed to the [audittaxon](https://audittaxon-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/custom-distribution-updates](https://audittaxon-static-docs.pantheonsite.io/docs/custom-distribution-updates)
- [docs/cygwin-windows](https://audittaxon-static-docs.pantheonsite.io/docs/cygwin-windows)
- [docs/drupal-phpstorm](https://audittaxon-static-docs.pantheonsite.io/docs/drupal-phpstorm)
- [docs/kalabox](https://audittaxon-static-docs.pantheonsite.io/docs/kalabox)
- [docs/local-development](https://audittaxon-static-docs.pantheonsite.io/docs/local-development)
- [docs/local-dns](https://audittaxon-static-docs.pantheonsite.io/docs/local-dns)
- [docs/multidev](https://audittaxon-static-docs.pantheonsite.io/docs/multidev)
- [docs/mysql-access](https://audittaxon-static-docs.pantheonsite.io/docs/mysql-access)
- [docs/reducing-large-repos](https://audittaxon-static-docs.pantheonsite.io/docs/reducing-large-repos)
- [docs/ssh-tunnels](https://audittaxon-static-docs.pantheonsite.io/docs/ssh-tunnels)
- [docs/guides/terminus](https://audittaxon-static-docs.pantheonsite.io/docs/guides/terminus)
- [docs/undo-commits](https://audittaxon-static-docs.pantheonsite.io/docs/undo-commits)
- [docs/upstream-updates](https://audittaxon-static-docs.pantheonsite.io/docs/upstream-updates)
- [docs/videos/kalabox](https://audittaxon-static-docs.pantheonsite.io/docs/videos/kalabox)
- [docs/videos/local](https://audittaxon-static-docs.pantheonsite.io/docs/videos/local)
- [docs/wordpress-phpstorm](https://audittaxon-static-docs.pantheonsite.io/docs/wordpress-phpstorm)
- [source/_partials/topics/develop.html](https://github.com/pantheon-systems/documentation/commit/785bebf1603bd13b2d17616458ba46e6b757d150/source/_partials/topics/develop.html)
- [source/_partials/topics/get-started.html](https://github.com/pantheon-systems/documentation/commit/785bebf1603bd13b2d17616458ba46e6b757d150/source/_partials/topics/get-started.html)
- [source/_partials/topics/go-live.html](https://github.com/pantheon-systems/documentation/commit/785bebf1603bd13b2d17616458ba46e6b757d150/source/_partials/topics/go-live.html)
- [source/_partials/topics/manage.html](https://github.com/pantheon-systems/documentation/commit/785bebf1603bd13b2d17616458ba46e6b757d150/source/_partials/topics/manage.html)
- [source/_partials/topics/performance.html](https://github.com/pantheon-systems/documentation/commit/785bebf1603bd13b2d17616458ba46e6b757d150/source/_partials/topics/performance.html)
- [source/_partials/topics/platform.html](https://github.com/pantheon-systems/documentation/commit/785bebf1603bd13b2d17616458ba46e6b757d150/source/_partials/topics/platform.html)
- [source/_partials/topics/troubleshoot.html](https://github.com/pantheon-systems/documentation/commit/785bebf1603bd13b2d17616458ba46e6b757d150/source/_partials/topics/troubleshoot.html)


I haven't ever used any Lisp dialect to be honest.


![badge](https://img.shields.io/badge/appsnap-warning-cdb62c.svg) There are 20 visual regressions in this pull request

Please Visit https://github.com to check out these diffs
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale

| Diff 1 | Diff 2 | Diff 3 | Diff 4 | Diff 5 | Diff 6 | Diff 7 | Diff 8 | Diff 9 | Diff 10 | Diff 11 | Diff 12 | Diff 13 | Diff 14 | Diff 15 | Diff 16 | Diff 17 | Diff 18 | Diff 19 | Diff 20 |
| ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- |
| [![Image of Diff1](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone5-back%20to%20Rogue%20on%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff2](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6-back%20to%20Rogue%20on%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff3](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff4](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff5](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone5-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff6](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone5-Similar%20Movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff7](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6-back%20to%20similar%20movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff8](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone5-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff9](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone7-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff10](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone7-back%20to%20Rogue%20on%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff11](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone5-back%20to%20similar%20movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff12](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6Plus-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff13](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone7-back%20to%20similar%20movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff14](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6-Similar%20Movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff15](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6Plus-back%20to%20Rogue%20on%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff16](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone7-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff17](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone7-Similar%20Movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff18](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6Plus-back%20to%20similar%20movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff19](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6Plus-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff20](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/2/18/diffs/en-US_iPhone6Plus-Similar%20Movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) |


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1887 of 1887 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


I just saw that you indeed _did_ put the version requirements in this repo: `nbconvert>=5.1.1`. I'd still put it here because it errors if the version is too old.


@benoitjoseph 😑


Although it's working, the URI is not exactly the one I expected. I had made some more changes to the code yesterday thinking the first ones didn't work but then I realized they hadn't been applied to the server so I didn't post the new changes. The changes would probably correct the URI it but I'm thinking that it's working right now so better to leave it alone.


If I draw twice with the UTM Bounding Box, there is an error thrown inside this method.  Looks like the `this.get('usngbb')` comes back undefined and causes everything to derail.


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-203502 "deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-203502") to [prod](https://dev-console.stage1.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "w3ibm:prod:us-south:user@ibm.com:prod"), including this commit


Hey, any particular reason why this piece of code was removed?


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-203512 "deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-203512") to [prod](https://dev-console.stage1.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "w3ibm:prod:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-Prod-20170320-203517 "deployed-2-env-Prod-20170320-203517") to [Prod](https://dev-console.stage1.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "There was a problem retrieving the space name"), including this commit


Do you need this? It's already being imported in your __init__ file


oh, sorry for that, you can just add it back!


No, not at all, the javascript is just client-side. I need to find out how to send the variable to the NodeJS server.


no worries. thanks.


This is a filter which is picked up automatically by Ansible.  It is called in the aws-cloudformation role here - https://github.com/Casecommons/aws-cloudformation/commit/4aec25a10a6e176db953e6145192edf216ca1a03#diff-f6cde241e27958b50b46568cae7b30c3R33


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-204057 "deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-204057") to [prod](https://dev-console.stage1.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "w3ibm:prod:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-204103 "deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-204103") to [prod](https://dev-console.stage1.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "w3ibm:prod:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-Prod-20170320-204106 "deployed-2-env-Prod-20170320-204106") to [Prod](https://dev-console.stage1.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "There was a problem retrieving the space name"), including this commit


forgot to delete


Basically, for the coverage, just keep the target to `es6`.

I realised this by mistake when copying from a boilerplate project that had the target on `es6` in `tsconfig` - if you use a new version of node (v6.9.5) in this case, it is happy with the emitted.

For projects using `tsnode`, I believe you can override the target for the coverage command only.

Let me know if this makes sense, or if you want to see some examples.


thx, makes sense


This is fraud


adding a commit.


Stefan, be careful with changing the indentation. Even though I agree with it, there is code that relies on it that breaks.


The idea of this function is that you don't have to define `cf_stack_inputs` if you follow the naming convention of config_<snake_case_variable>.

So if you have a template with:

```
Parameters:
  ApplicationImageId:
  ...
  ...
  ApplicationInstanceYpte:
  ...
  ...
```

The role will look for `config_application_image_id` and `config_application_instance_type` if you haven't explicitly defined `cf_stack_inputs`

The role will also pick up any defaults you have defined in the template for each parameter, so you don't necessary have to define each template parameter in the `config_xxx` form.


remove


![badge](https://img.shields.io/badge/appsnap-warning-cdb62c.svg) There are 11 visual regressions in this pull request

Please Visit https://github.com to check out these diffs
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale

| Diff 1 | Diff 2 | Diff 3 | Diff 4 | Diff 5 | Diff 6 | Diff 7 | Diff 8 | Diff 9 | Diff 10 | Diff 11 |
| ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- |
| [![Image of Diff1](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/1/20/diffs/en-US_iPhone7-back%20to%20Rogue%20on%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff2](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/1/20/diffs/en-US_iPhone5-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff3](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/1/20/diffs/en-US_iPhone6-back%20to%20Rogue%20on%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff4](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/1/20/diffs/en-US_iPhone6-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff5](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/1/20/diffs/en-US_iPhone6-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff6](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/1/20/diffs/en-US_iPhone5-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff7](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/1/20/diffs/en-US_iPhone7-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff8](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/1/20/diffs/en-US_iPhone7-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff9](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/1/20/diffs/en-US_iPhone6Plus-back%20to%20Rogue%20on%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff10](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/1/20/diffs/en-US_iPhone6Plus-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff11](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/1/20/diffs/en-US_iPhone6Plus-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) |


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-204656 "deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-204656") to [prod](https://dev-console.stage1.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "w3ibm:prod:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-204702 "deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-204702") to [prod](https://dev-console.stage1.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "w3ibm:prod:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-Prod-20170320-204706 "deployed-2-env-Prod-20170320-204706") to [Prod](https://dev-console.stage1.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "There was a problem retrieving the space name"), including this commit


У мене не получилось викликати emp.calculatePay(), а зараз получилось. Я
внесла зміни в git. В реальних проектах використовувати метод шелла чи щоб
не писати цикл в циклі(я знаю це не є добре) використовувати більш просте
сортування?

2017-03-20 22:07 GMT+02:00 vryazh <notifications@github.com>:

> Це, звичайно, суттєво. Просто не добре заради сортування створювати
> статичний метод. Може можно замість
> getSalary(emp)
> викликати
> emp.calculatePay()
>
>
> 20 березня 2017 р. о 22:02 TenishevaN <notifications@github.com> написав:
>
> > private static double getSalary(Calculation calculation) {
> > return calculation.calculatePay();
> > } - цей статичний метод я створила по прикладу з англомовних уроків, там
> > статичний метод. Як можна зробити простіше?
> >
> >
> > Три цикли є в цьому фрагменті кода:
> > "int length = EmployeeList.length;
> > int i;
> > int j;
> > int step;
> > Calculation tmp = EmployeeList[0];
> >
> > for (step = length / 2; step > 0; step /= 2) {
> > for (i = step; i < length; i++) {
> > tmp = EmployeeList[i];
> > for (j = i; j >= step; j -= step) {
> >
> > if (getSalary(tmp) > getSalary(EmployeeList[j - step])) {
> > EmployeeList[j] = EmployeeList[j - step];
> > } else {
> > break;
> > }
> > }
> > EmployeeList[j] = tmp;
> > }
> > }"
> > - це сортування методом шелла, я прочитала, що при цьому методі
> > використовується мінімум памяті та висока швидкість сортування. В
> реальних
> > задачах в java це не суттєво?
> >
> >
> >
> >
> > 2017-03-20 20:27 GMT+02:00 vryazh <notifications@github.com>:
> >
> > > якось дуже складно
> > > тут аж три цикли та статичний метод, що не дужедобре, але правильно
> > >
> > > —
> > > You are receiving this because you authored the thread.
> > > Reply to this email directly, view it on GitHub
> > > <https://github.com/ViktoriyaRyazhska/Lv-230.JavaCore/commit/
> > a2ab08a1ae99d5341eb1e4d5da9049bad31cccc5#commitcomment-21403313>,
> > > or mute the thread
> > > <https://github.com/notifications/unsubscribe-
> > auth/AY_dla019HVnKi1MIvJFQvN-Ok1Of0vNks5rnsUPgaJpZM4Mi1Ts>
> > > .
> > >
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <https://github.com/ViktoriyaRyazhska/Lv-230.JavaCore/commit/
> a2ab08a1ae99d5341eb1e4d5da9049bad31cccc5#commitcomment-21404770>,
> > or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/AVUWc_
> vVJx3ObeA1vNDefyTwdSHksFxYks5rnttTgaJpZM4Mi1Ts>
> > .
> >
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/ViktoriyaRyazhska/Lv-230.JavaCore/commit/a2ab08a1ae99d5341eb1e4d5da9049bad31cccc5#commitcomment-21404851>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AY_dlTVgnomhzQqymfh-xOSzXJAn0S-Rks5rntyBgaJpZM4Mi1Ts>
> .
>


Remove entire file. We don't need it, since we're not doing any integration tests against any postgres database.


Thanks! Do not forget to include <sched.h>. Glibc is not complaining, but others might.


There's a clean `nextSlide` function above which seems to be generic over slide1, slide2, etc. etc. Rather than writing out CSS manually for each slide within your logic (here), perhaps you could put this information onto the slide data itself.


@bosung90 Good job :+1:


Please let me know if you would like the asserts commented out until you
have the right mechanism to turn them on.

On my side I have checked the patch on x86_64-linux, aarch64-linux, and
powerpc-linux.
Do you happen to have instructions on how to run a more extensive set of
tests than "make check"?


Saw a few failures, at least one due to inability to write to `/tmp`


I was unsure of one of the instructions and did not want to delete it. I went ahead and restored it.


This was me. Somehow my change was only available on the qa box. This removes the 1 for 1 mapping of collection in the map_source_resource() function with an overridden method that does the correct job of creating the nested structure under the collection node. Normally not necessary when the collection is set during an OAI harvest, but CDL is an API harvest, so I had to do it manually.


You'll notice that there are some puzzling (and, I think, state-related) bugs related to Leaflet's zoom level which are likely the result of trying to manage these complex state transitions in code.


Of _course_! Brilliant.


Thanks


@lunzhang maybe you can add one for test too, in future it might be useful


Mostly due to BC compliance. Hints can be added where inheritance isn't possible, but we only recently dropped PHP 5 support.


Лучше сделать private static


umm.. okay?
1. What forums?
2. This is just an image, if u want it to replace the current header stuff, then the text needs to become white


Well I had to change it as it was not working properly with 36lts...


А для чего это? Без комментария не понятно


`.?` (like implemented in CoffeeScript) has the tendency to end like `try` in ruby ... Demeters nightmare


Для чего эти заглушки?


Написал комментарии


There were a few tiny bugs which popped up and the buttons kept changing positions as slides changed (likely something could be done in CSS to resolve this), but you successfully loaded external data and filtered it to tell a story. Nicely done.


航宝学姐好厉害


Hey @bsbell21 just saw you were working with this. Any luck getting it up and running? If so, how did it work? Cool stuff--just curious!


Hello @maxee ,

I'm trying to compile the latest version from the branch "dev" and I got the following error:

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':sample'.
> The SDK Build Tools revision (24.0.2) is too low for project ':sample'. Minimum required is 25.0.0

Is this something you can help me with?

Thanks in advance and AMAZING work on this library by keeping it updated.


Why should the prefix be '/'?


This is wrong. If the password is blank. Which is very likely if just updating name, email, etc. It will mess up the customer's password.


Can you please add more values like selectedOptions and unselectedOptions to the scope? I want to add value to the selection when press enter on the input. But need to modify the source file to make it happen (bind data). That will be great to have that function. Thank you.


Константы пишутся заглавными буквами


Huere Scheisse


Хорошо было бы добавить JavaDoc


@quannten24 they could get compressed even further, however to do it effectively, we would have to change to jpg files which would remove the transparent background...


Heh, this is the firs time I ever used it! :)


this is not fixed


@DougGregor Looks great. Happy to see this approved :)


А что будет, если будет ошибка при чтении файла?


zlib-ng already defines conditional Assert() macro which uses two parameters, the first one is the test and the second parameter is the error message to describe what did go wrong. I'm going to add the flag to separately enable just asserts (no trace messages) today, but I don't know when Dead2 will cherry-pick the commit as he is few commits behind again...

The best test is to tar a large directory and then run minigzip -6 on the tarball and try to use both minigzip -d and gunzip to uncompress the file.

Something like:
time ./minigzip -6 test.tar && ls -la test.tar.gz && time ./minigzip -d test.tar.gz
time ./minigzip -6 test.tar && time gunzip test.tar.gz
time gzip -6 test.tar && ls -la test.tar.gz && time ./minigzip -d test.tar.gz
time gzip -6 test.tar && time gunzip test.tar.gz

Take average time of those identical commands and compare times between minigzip -6 and gzip -6, and between minigzip -d and gunzip.

If anyone of the lines fail, then there is something wrong.
File test.tar should be at least 200 MB in size, but we usually use as large as 2 GB file.


I think you can just do
```bash
... && pip install docker-compose virtualenv
```


Typo: `byes` -> `bytes`.


[.jar file](https://github.com/cweitkamp/openhab2-addons/files/856240/org.openhab.binding.avmfritz-2.1.0_20170320-SNAPSHOT.zip)


Actually, I found the issue and solved it.

`apply plugin: 'com.android.application'

android {
    compileSdkVersion 25
    buildToolsVersion '25.0.2'

    defaultConfig {
        applicationId "com.arlib.floatingsearchviewdemo"
        minSdkVersion 14
        targetSdkVersion 25
        versionCode 1
        versionName "1.0"
    }
    buildTypes {
        release {
            minifyEnabled false
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        }
    }
}

dependencies {
    compile fileTree(dir: 'libs', include: ['*.jar'])
    compile project(":library")
    compile 'com.android.support:appcompat-v7:24.2.1'
    compile 'com.android.support:palette-v7:24.2.1'
    compile 'com.android.support:support-v4:24.2.1'
    compile 'com.google.code.gson:gson:2.7'
}
`

Thanks in advance.


If I add keywords to the parameters, they are not recognized, even when they are in the orde of the posional ones. Only positional arguments work.


Pls revert this commit.
I think, that it crashed Satel Integra (and maybe MultiFun)


Do we really want to expand the XML interface at this point?


typo: so.so  -> .so


After the update, I get an error "FFmpeg failed to generate a video thumbnail".


Shareable Link to dashborad?


@gepo Yeah I forgot to remove that in this commit but got it shortly after. ;-)


I have no idea who you are, or why you emailed me. Please stop.


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-210330 "deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-210330") to [prod](https://dev-console.stage1.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "w3ibm:prod:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-210335 "deployed-2-env-w3ibm-prod-us-south-user-ibm.com-prod-20170320-210335") to [prod](https://dev-console.stage1.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "w3ibm:prod:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-Prod-20170320-210338 "deployed-2-env-Prod-20170320-210338") to [Prod](https://dev-console.stage1.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "There was a problem retrieving the space name"), including this commit


Thanks for the idea!
I was thinking we will later add some more protocol-specific logic here (for example when switching to protocol buffers), but if so, we can later also change the name back to `RecommenderClient` (or whatever will suit it best).


i switched to your tree entirely. i cloned it and tried to build with it. it built successfully without the module but once i loaded the module and tried to rebuild with it, it failed. until i reverted this commit here in your tree, then it would build fine on yours


already fixed locally, will push when get home
Thank you


@bd-j this is ready to go, pending Charlie's merging of the nebular branch. remind me what you wanted me to rebase this to? was it the smooth_lsf branch?


Nice!!


Thank you :D
Locally I fixed before, but didn't pushed


What do you mean, "expand"? The `k` was always there.


Ah, thanks for the tip! Making `ts-jest` target es6 seems to fix it: 61b0efc


>.<
no


TG1 finalizado


pooz help me


Enemy already has a property named Shooting


End of test


by time


What module is this?


It makes no sense.  I simply wanted to play with it.  I wouldn't add something like this to a production app.  It was fun to explore.


develop (evanweaver) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


iteration (evanweaver) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


@bridiver I think that might be the case; I can comment out the `mainWindow.show()` call and it still shows (and works) as expected


If you'd like to return the tuple you can use `(Option<V>, Self)`. Rust allows one unsized type in this situation, as long as it's the last one. That's why the `Self` return types above work.


I agree.  Having the server not provide an ID made it pretty ugly.  This is not something I'd do in a production app.


No probs. [Here's another example of this done with ts-node](https://github.com/Izhaki/gefri/commit/30f059184159db0c19a9b4d35aeff8d7b4722935)


pycurl was already here


Yes, if I needed it somewhere else.


@jacobsn Here is my paper. The last few sections I am not so sure about, and neither is 4.5. Let me know your comments. Thanks!


DisplacementVentMgrCoefficients (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1889 of 1889 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.48%25-green.png)


Dude, sorry, I have no idea who you are either, github interpreted an
instance variable as your nickname, so I didn't mean to message you.
Have a good one.

>


Назвал как будущностей-то интерфейс))


DisplacementVentMgrCoefficients (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


#6046-DX-Coil-rating-for-bypass-factor-should-use-volume-converted-to-standard-mass (rraustad) - x86_64-MacOS-10.9-clang: OK (2342 of 2483 tests passed, 14 test warnings)

 * 155 tests had: EIO diffs.
 * 130 tests had: ESO big diffs.
 * 123 tests had: Table big diffs.
 * 22 tests had: ESO small diffs.
 * 7 tests had: MTR small diffs.
 * 22 tests had: Table small diffs.
 * 79 tests had: MTR big diffs.
 * 10 tests had: ERR diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-94.32%25-yellow.png)


delete


@kholmukhamedovme Then FFmpeg failed to generate a video thumbnail.


👏  I attempted something similar [a while back](https://github.com/BarryThePenguin/SparkleShare/blob/travis/.travis.yml)


Hi @shivrai !

I am watching your work for the last weeks. I just wanted to let you know that all of your modifications could be done by setting environment variables. Like this change. If you set `POWERLEVEL9K_VCS_GIT_HOOKS=(vcs-detect-changes git-untracked git-aheadbehind git-stash)`, you achieve the same result as with this commit. Same goes for enabling/disabling segments (look in the docs for `POWERLEVEL9K_LEFT_PROMPT_ELEMENTS`). And for changing the color of segments. That is less obvious, as there is some magic involved, but it is possible to set fore- and background colors for every segment. The rule is `POWERLEVEL9K_<NAME_OF_SEGMENT>_FOREGROUND` (or `BACKGROUND`). For some segments this is a bit different, because they choose their colors based on more information (a.k.a. "state"). Check out the [wiki](https://github.com/bhilburn/powerlevel9k/wiki/Stylizing-Your-Prompt#special-segment-colors).

Thanks. 😉


According to the [heroku doc](https://devcenter.heroku.com/articles/connecting-to-relational-databases-on-heroku-with-java#using-the-spring_datasource_url-in-a-spring-boot-app), we don't have to do anything to connect to the database. Heroku sets the `SPRING_DATASOURCE_*` environment variables, which in turn are picked up by spring boot. As long as we have the postgresql jdbc drivers included in the jar, we should be good.

However, we should have an `applications.properties` in `src/main` with something along the lines of

<pre>
spring.jpa.generate-ddl=true
spring.jpa.hibernate.ddl-auto=create-drop
</pre>


FFmpeg is not our library. It is an external program that you must have.

Video uploads work perfectly and thumbnails get generated for me via FFmpeg. So check your system. It's something wrong with your particular computer.


yeah... nobody realized in nearly 2 years that this doesn't work... I think you forgot to implement this :P


Finally attacking the jsdocs and ran into this bug last week in class. Could 'post modify' a shape to be a predesigned gradient, but couldn’t set the fill/stroke before drawing the shape.
The solution would have been `b.fill(b.gradient("gradient_name"));` – but that's just nasty!

```
b.fill("rad"); // gradient called "rad"
var myRect = b.rect(50, 50, 50, 50);
//myRect.fillColor = "rad"; // post applying gradient
```


del


The dead forum site!


Hey

I gave you push access to the LaserWeb organisation - feel free to fix upstream if you want to!  Welcome to the team!

https://github.com/LaserWeb


hudson


could align the comments with the other ?


какой ещё линк?
у тебя тут див же


Дякую, я зрозумів

>Понедельник, 20 марта 2017, 20:29 +02:00 от vryazh <notifications@github.com>:
>
>це все можна загнати в один цикл
>на великих даних ми будемо мати кращий перфоменс
>—
>You are receiving this because you authored the thread.
>Reply to this email directly,  view it on GitHub , or  mute the thread .


The component should be tested in isolation, similar to what `hello.spec` is doing.


а кавычки где?


кавычки !


вот видишь?
и вложености не надо..


Can you do the exact same thing for 1.11.2 too?


It was an accident due to autoformatting the code.


Woah, keycloak based refactoring :)


it should be if (, you miss the space between if and (.
one line if should always have parenthesis... I don't know why it is still permit...


ну не надо экономить на названиях...
константа должна быть описана хорошо
так не сразу понятно


better leave spaces around =


And also mirror also follows symlinks for upftp


it's ok. I actually fixed the code in parameterize instead of deindentate this code.


@cnuke, @chelmuth: please check, is there a better fix ? The issue may trigger (it's not actually so easy to trigger artifically) when the config/wlan_supplicant.conf is hosted in a fs (ram_fs e.g.)


PxPerfect - http://prntscr.com/emfb8w , http://prntscr.com/emfbec
в мейн все хорошо на главной, а вот хедер и футер плохо
на странице каталога только футер надо править но, если поправишь на главной - станет хорошо и на странице каталога скорее всего


The following doc(s) have been deployed to the [audittaxon](https://audittaxon-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/custom-distribution-updates](https://audittaxon-static-docs.pantheonsite.io/docs/custom-distribution-updates)
- [docs/cygwin-windows](https://audittaxon-static-docs.pantheonsite.io/docs/cygwin-windows)
- [docs/drupal-phpstorm](https://audittaxon-static-docs.pantheonsite.io/docs/drupal-phpstorm)
- [docs/kalabox](https://audittaxon-static-docs.pantheonsite.io/docs/kalabox)
- [docs/local-development](https://audittaxon-static-docs.pantheonsite.io/docs/local-development)
- [docs/local-dns](https://audittaxon-static-docs.pantheonsite.io/docs/local-dns)
- [docs/multidev](https://audittaxon-static-docs.pantheonsite.io/docs/multidev)
- [docs/mysql-access](https://audittaxon-static-docs.pantheonsite.io/docs/mysql-access)
- [docs/reducing-large-repos](https://audittaxon-static-docs.pantheonsite.io/docs/reducing-large-repos)
- [docs/ssh-tunnels](https://audittaxon-static-docs.pantheonsite.io/docs/ssh-tunnels)
- [docs/guides/terminus](https://audittaxon-static-docs.pantheonsite.io/docs/guides/terminus)
- [docs/undo-commits](https://audittaxon-static-docs.pantheonsite.io/docs/undo-commits)
- [docs/upstream-updates](https://audittaxon-static-docs.pantheonsite.io/docs/upstream-updates)
- [docs/videos/kalabox](https://audittaxon-static-docs.pantheonsite.io/docs/videos/kalabox)
- [docs/videos/local](https://audittaxon-static-docs.pantheonsite.io/docs/videos/local)
- [docs/wordpress-phpstorm](https://audittaxon-static-docs.pantheonsite.io/docs/wordpress-phpstorm)
- [source/_partials/topics/develop.html](https://github.com/pantheon-systems/documentation/commit/785bebf1603bd13b2d17616458ba46e6b757d150/source/_partials/topics/develop.html)
- [source/_partials/topics/get-started.html](https://github.com/pantheon-systems/documentation/commit/785bebf1603bd13b2d17616458ba46e6b757d150/source/_partials/topics/get-started.html)
- [source/_partials/topics/go-live.html](https://github.com/pantheon-systems/documentation/commit/785bebf1603bd13b2d17616458ba46e6b757d150/source/_partials/topics/go-live.html)
- [source/_partials/topics/manage.html](https://github.com/pantheon-systems/documentation/commit/785bebf1603bd13b2d17616458ba46e6b757d150/source/_partials/topics/manage.html)
- [source/_partials/topics/performance.html](https://github.com/pantheon-systems/documentation/commit/785bebf1603bd13b2d17616458ba46e6b757d150/source/_partials/topics/performance.html)
- [source/_partials/topics/platform.html](https://github.com/pantheon-systems/documentation/commit/785bebf1603bd13b2d17616458ba46e6b757d150/source/_partials/topics/platform.html)
- [source/_partials/topics/troubleshoot.html](https://github.com/pantheon-systems/documentation/commit/785bebf1603bd13b2d17616458ba46e6b757d150/source/_partials/topics/troubleshoot.html)
- [docs/agency-tips](https://audittaxon-static-docs.pantheonsite.io/docs/agency-tips)
- [docs/change-management](https://audittaxon-static-docs.pantheonsite.io/docs/change-management)
- [docs/custom-upstream](https://audittaxon-static-docs.pantheonsite.io/docs/custom-upstream)
- [docs/delete-site](https://audittaxon-static-docs.pantheonsite.io/docs/delete-site)
- [docs/enable-https-vanity-domain](https://audittaxon-static-docs.pantheonsite.io/docs/enable-https-vanity-domain)
- [docs/guides/collaborative-development](https://audittaxon-static-docs.pantheonsite.io/docs/guides/collaborative-development)
- [docs/managing-edu-plus](https://audittaxon-static-docs.pantheonsite.io/docs/managing-edu-plus)
- [docs/managing-upstreams](https://audittaxon-static-docs.pantheonsite.io/docs/managing-upstreams)
- [docs/organization-dashboard](https://audittaxon-static-docs.pantheonsite.io/docs/organization-dashboard)
- [docs/organization-faq](https://audittaxon-static-docs.pantheonsite.io/docs/organization-faq)
- [docs/organizations](https://audittaxon-static-docs.pantheonsite.io/docs/organizations)
- [docs/priority-enterprise-support](https://audittaxon-static-docs.pantheonsite.io/docs/priority-enterprise-support)
- [docs/running-custom-upstream](https://audittaxon-static-docs.pantheonsite.io/docs/running-custom-upstream)
- [docs/site-access](https://audittaxon-static-docs.pantheonsite.io/docs/site-access)
- [docs/site-owner-faq](https://audittaxon-static-docs.pantheonsite.io/docs/site-owner-faq)
- [docs/sso-organizations](https://audittaxon-static-docs.pantheonsite.io/docs/sso-organizations)
- [docs/team-management](https://audittaxon-static-docs.pantheonsite.io/docs/team-management)
- [docs/vanity-domains](https://audittaxon-static-docs.pantheonsite.io/docs/vanity-domains)


Right, never mind, carry on...


Skill скорее всего лучше эмбедить в StudentInfo, нет смысле хранить его в отдельной коллекции


`chai`


What are we waiting for? Could we do a loop with condition check and count limit? It would allow us to take less time in the good cases and be more reliable in the not so good cases. (Potentially wait longer and provide some sort of timeout waiting for <x> error)


Updated my branch, with my patches rebased on top of your latest one (2a7c3c2)


be污，女装！


![](https://github.trello.services/images/mini-trello-icon.png) [+ - * / Simple Arithmetic Tree](https://trello.com/c/o8Wc3yO3/15-simple-arithmetic-tree)


![](https://github.trello.services/images/mini-trello-icon.png) [Find function name (such as cons) and set as string "Func"](https://trello.com/c/XOUSphVG/26-find-function-name-such-as-cons-and-set-as-string-func)


The spec says that if the certificate cannot be issued at the time of the request, an empty response should be written. Does that ever happen? Certbot does not seem to be able to handle an empty response. So I'm wondering if it's a spec issue or an implementation issue.


Later but I can forward port this after I fix all the things needed in 1.10.2


These before blocks can be one lined.


I don't think this does what you expect.  On Python2, this is equivalent to `str(data)`.  On Python3, this creates a `bytes` object.  Is `data` here a bytearray?


This seems more a warning to me. I'm assuming it would only be printed at startup, so it should not fill the logs. In addition if I have configured the system to use send traffic to an aggregated APIServer and we decide not to; then you better tell me why you didn't.


If you are using an `it do` block you should write a description of what this test does:

```
it 'blehblehbleh' do
  stuff
end
```


just set the background to white and then it shouldnt be a problem. unless you want to  change the background colorAm 20.03.2017 21:57 schrieb Christoph Fricke <notifications@github.com>:@quannten24 they could get compressed even further, however to do it effectively, we would have to change to jpg files which would remove the transparent background...

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.


`0` is truthy in in Ruby, so this will always evaluate to true.  How about `unless User.with_role(:collaborator, bot).empty?` instead?


Yeah, I'm not convinced this is necessary.  Per the docs:

> The buffer parameter must be a Python object which supports the buffer protocol, i.e., a string, an array or the object returned from Inferior.read_memory.


Init Comm


lololo


吼啊，资瓷女装

2017年3月20日(月) 14:34 雾雨魔理沙 <notifications@github.com>:

> be污，女装！
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/ThoughtWorksInc/DeepDarkFantasy/commit/e0f81ac672ef57920e754d3142780da1835f6429#commitcomment-21406558>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA0fI53bqdlUXvVbCyXsrZcOh1BogD4pks5rnvD_gaJpZM4Mintt>
> .
>


Here's the relevant spec:
https://github.com/letsencrypt/acme-spec/blob/master/draft-barnes-acme.md#certificate-issuance

The spec says that if the certificate cannot be issued at the time of the request, the response should be empty. This seems to fail when the response._content is empty. There seems to be a disconnect between the spec and the implementation here.


sorry wrong pull request.


Yes, this looks quite good. I think this should be enough information.


Thanks for the feedback. :-)

Den man. 20. mar. 2017, 22.42 skrev kiryph <notifications@github.com>:

> Yes, this looks quite good. I think this should be enough information.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/lervag/vimtex/commit/8ce186091d8bf4d9b474188c6b9d80878a8a651d#commitcomment-21406687>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA898oaepGW8bmKfdEz6OZ_X029nxl8Yks5rnvLJgaJpZM4MjDWg>
> .
>


![](https://github.trello.services/images/mini-trello-icon.png) [Fix login problems](https://trello.com/c/wy94WD5C/48-fix-login-problems)


ok thanks for checking this, I'll correct it when I've got some time


Sollten wir die defaults in constants verlagern, damit sie nicht woederholt werden?


This is a big deletion of stuff...


Bear in mind that it RepositoryUri, not URL..
Also, this made it to nuget...


develop (macumber) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


Not convinced this is safe. Callers of this API like factory_object_mapping.go seem to rely on the old behavior. Currently if this fails the factory will refresh the client and try again. Now it would move forward with a potentially empty list of group resources. If we do decide to keep this change we could drop the above if statement as we will continue either way.


MultiSpeedFanPower-Part2 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2510 of 2522 tests passed, 0 test warnings)

 * 11 tests had: EIO diffs.
 * 12 tests had: ESO big diffs.
 * 12 tests had: MTR big diffs.
 * 11 tests had: Table big diffs.
 * 2 tests had: ERR diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.52%25-yellow.png)


This fixes #2.


This is a great idea, I love this


Just a Draft


no comma here


@mineo I know it is a long time ago, but what is the purpose of this repeating timer every second if there is no  `timerEvent` defined?


I completely missed that you rewrote this to be much better. Thanks, @sindresorhus ⭐


Wondered why it wasn't working. `User.with_role(:collaborator, bot).any?` is the shortcut for that.


@skhilton: I just pushed another commit that should streamline it, since in the previous version it seemed like two consecutive code blocks were doing almost the same thing. Check that this looks OK.

I also incremented version (in `phydmslib/_metadata.py`) to 2.0.dev1. I then added in the `CHANGELOG.rst` a summary of what we did under that version. We should try to keep tracking changes in that way, and when we feel that it is ready we can make 2.0.dev1 the version 2.0.1 and tag and put on `PyPI`.


@alfonsogarciacaro Bummer, now Fable compiler is crashing with this:
```
Fable server sent: C:/Projects/Fable/src/dotnet/Fable.Core/AST/AST.Common.fs

Process is terminated due to StackOverflowException.
```


Is there a reason why we are bypassing the aggregater in this test?


MultiSpeedFanPower-Part2 (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


I have no idea how to calculate the EXP required for the enchantments.


Couple of minor comments.


@zas I see the explanation in the commit title, but am unclear why this is the solution.

This would appear to put a timer event on the event queue, but without an eventTimer routine it would probably be thrown away. So I guess it is the act of triggering the event queue to be processed that is important here.

I know this was a long time ago, but is this your understanding?


Currently I have no idea what to do


@americanjeff commented in today's test that M:tG often restricts cards by referring to an "attacker" (combat-only) or even referring to specific phases they can be played.

Easy for me to use that in Oz by costing MPs or referring to the active fleet.


Why you creating new variable in memory if you using it only once?


DisplacementVentMgrCoefficients (Myoldmopar) - i386-Windows-7-VisualStudio-14: OK (2485 of 2488 tests passed, 8 test warnings)

 * 9 tests had: AUD diffs.
 * 11 tests had: EIO diffs.
 * 2 tests had: ERR diffs.
 * 2 tests had: ESO big diffs.
 * 2 tests had: MTR big diffs.
 * 2 tests had: SSZ big diffs.
 * 2 tests had: ZSZ big diffs.
 * 3 tests had: Table big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.png)


@Talljoe -- I tried a couple other ways of restricting actions, and this one's (ramping wealth cost) still the most solid.


This allows us to start the game with fleet 1, then add fleet 2 in the next age, etc.  With the game ending after age four, it's easy to see when things are closing out.


Сделал шапку и главное меню, но только на главной странице. Если такой вариант приемлем, то перенесу изменеия и на другие страницы. Не совсем понимаю, как должен вести себя сайт при разрешении выше 1150px. Волнистые линии и блок карты тянутся на весь экран? а Содержимое, включая хедер и футер, остается в макетных размерах? И как делать волнистые линии подскажи))


wat da fok


@iObsidian fuck. I can't believe that typo made it this far 😅 will fix as soon as I'm done at uni


_Nice_! The `var`s had been bugging me too and I was about to submit a PR to update the dependencies 😉


Typo in method name. Also the name is redundant here since `@DataProvider` uses the method name by default.


unbalanced brackets?


Don't need this line either right?


I want to avoid any solution that overrules the user by setting DOCS. If DOCS is not set, the port should install no DOCS.


I see what you mean, been trying to fix it for a few hours now and nothing seems to work!


O que está em cima, é o mesmo que está em baixo.

Arquitetura da informação, esta será sempre um axioma no projeto gasja.

Volte ao dominio e pergunte ao criador.. TDD para os loucos. e um pouco de behat. para consultores.


A little heads up: The partialCached can bite you sometimes.

As the .RSSLink will change, you now end up with only one.


Good catch, thanks.


This commit and the next one take together eliminate the redundancy.


Please commit


I love this commit for reasons I cannot explain.


this id should have an underscore in it.


We should use `stroke-width` css property directly on the SVG element. It'll also enable us to do some transition animations and avoid loading new assets.


CONFIG_BOARDTEMP_WORK is not defined anywhere in your code.


Thanks, I moved numbers to constants in https://github.com/kantoniak/konstruisto/commit/8ffae0ea694050a3cb63d97fff3bd45580a45e51. Code for generator will be removed in two-three weeks (I guess), so I'm not overly attached to it ;)


MultiSpeedFanPower-Part2 (mjwitte) - x86_64-MacOS-10.9-clang: OK (2471 of 2483 tests passed, 0 test warnings)

 * 11 tests had: EIO diffs.
 * 12 tests had: ESO big diffs.
 * 12 tests had: MTR big diffs.
 * 11 tests had: Table big diffs.
 * 2 tests had: ERR diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.52%25-yellow.png)


I only tested with the simplest possible build, but works like a charm!

Is there an automated way to copy over the issues from [quinoa](https://github.com/quinoacomputing/quinoa)?


@21309582 - Thanks for your post and apologize for the delay. [Release notes](https://msdn.microsoft.com/en-us/commandline/wsl/release_notes) have been updated. Specifically `There are no more WSL fixes or features planned for inclusion in the Creators Update to Windows 10. Release notes for WSL will resume in the coming weeks for additions targeting the next major Windows Update.`. Please let us know if this answers your question to your satisfaction or not. I am happy to make it clear otherwise.


Which part did you try to run? I didn't run anything apart from trigger generator after these changes yet. But thanks's for pointing that out. I'll fix it as soon as I get to it. Feel free to submit a PR too if you want.


@raatmarien Did you mean to exclude build.gradle, too? If yours contains sensitive info, I wonder if there's a way to split that into a different file..


I guess you are referring to GnuPG **2.1.19** and not 2.2.19.


@BarryThePenguin nice! I'm having trouble finding MonoMac in the Mac build, but your lines might just be  the fix. :)


![](https://github.trello.services/images/mini-trello-icon.png) [AIScore](https://trello.com/c/YgbVZUnh/15-aiscore)


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/8e51cc81-bde0-494b-b588-fae72da947e1 "login-testapp"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/a6149d61-300a-4e1d-b492-382744c6922e "login-testapp") deployed this commit to [test](https://console.ng.bluemix.net/apps/a2243c68-8c07-41a7-93c7-1547783dd03a "ibm:yp:us-south:nitinstestapp:test")


Contrarily to what I wrote, it's not only modern gcc: see https://gcc.gnu.org/onlinedocs/gcc-2.95.2/gcc_7.html

> Declarations of external variables and functions within a block apply only to the block containing the declaration. In other words, they have the same scope as any other declaration in the same place.
>
> In some other C compilers, a extern declaration affects all the rest of the file even if it happens within a block.
>
> The `-traditional' option directs GNU C to treat all extern declarations as global, like traditional compilers.

What is modern is letting the compilation fail because of extern signature mismatch


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/9f3c190c-f3bb-4d11-ab04-cbd8027ddc7b "toolchain-pet-store-angular2"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/5b51c744-c168-4cd9-bd9e-910f72eee2dd "pipeline-pet-store-angular2") deployed this commit to [dev](https://console.ng.bluemix.net/apps/783b3ee6-a990-4f1c-863e-e6f9f54f8c98 "ibm:yp:us-south:ravichaudhary:dev")


Я правильно понимаю, что будет лучше создать класс Application и переместить массивы объектов из других классов в него?
Все прочие методы во всех классах сделать приватными?
Все остальное также оставить (помимо поправки кода в плане указанных замечаний) или как-то модифицировать?


`str.format` is recommended instead of `%` formatting, and then it's easy to break the line.


Here:

https://github.com/TheScarastic/msm8956/commit/7c0bd972beda5dd8e7258ff9a4389e745771d818#diff-ba1a139305c66bfe5b7d6281e9969d88R157


@alexcjohnson @etpinard  I run into a performance problem here when plotting a very big bar chart. Was there any specific reason for choosing array over map on this sort of "searching" scenario? Thanks!


Same hint again: try to avoid explicit calls to Element on maps. It is not only verbose; Element also creates an explicit copy of the mapped value, while "Map (Index)" and "Map (Cursor)" give effectively a pointer. (See Constant_Reference and Pseudo_Reference in Ada.Containers.Hash_Maps.)

This used to be one of the performance bottlenecks in gnat2why.


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/3f5816c0-f598-4a11-ae94-3acd269445e9 "Intranet Facebook for Coursera"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/d429a898-f16b-411e-9210-060a605bc21c "Intranet Facebook for Coursera") deployed this commit to [SouthDumb](https://console.ng.bluemix.net/apps/26c89a39-7a82-4cd8-b5eb-248903c656a5 "ibm:yp:us-south:BlueDumb:SouthDumb")


The callback *receives* a single argument


Interesting link, I've never seen that before. I actually messed around with a similar approach when I was first figuring this stuff out a few months back. I'll probably take a closer look at some of these techniques, and I'm sure the engine will evolve as more features get tacked on.


There should be a test that actually verifies the database is empty now.


Agent no longer has option to "drop piece". This is because the agent sees the game frame-by-frame and can enact an action of each frame rendering the "drop piece" obsolete for now. I plan to experiment with this at a later point in time.


Added Pausing functionality to temporarily stop training.


In general, iterate with "of" where possible and only with "in" where necessary. Here I think
```for Sym of Global_Symbol_Table loop``` would be enough.


The agent now also saves and loads not just its network weights but also its game parameters (games played, max reward, score, lines cleared) and its replay memory so that we can start and stop training on different machines without losing progress.


Saving functionality.


this is a commit not a release lol


so it fixed the previous commit not release, there was no release


MultiSpeedFanPower-Part2 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1288 of 1288 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-37.47%25-green.png)


Here I suggest to call Insert with extra Boolean argument Inserted (see the Ada maps API). It does just one search in the hash map, while the current code does two (first for Contains, then for Insert).


Fixes #64