Afaik it's a common trick when 2 versions of jQuery are being used. Not sure if this is the case with the game itself, as just one version seems to be included, anyway, it *might* have something to do with the game being embeddable in other websites, who might be using a different jQuery version; needs to be looked into perhaps...


HahA


Seems to contradict with typings info "If the view was created via the "enhance" API, this will be an Element". Now it's never an Element. I was expecting to get reference to enhanced <compose> element using .fragment API but received empty doc fragment due to this change.


yeah didnt have to bother about the patch files because i synced the kernel.org repo and merged the tags/releases
thats shows me directly what gives an conflict and i can check if i want the old or the new code


https://github.com/Fluorohydride/ygopro-pre-script/commit/47f130b6c659f4559ec046011f9ef0406308d226 fixed.


Indeed, that's the case I was mentioning. Might open another issue addressing the usefulness of the jQuery plug-ins (besides jQuery-UI, which is already on the "death row" so to say).


I think, that old "Default sources" list is much more easy to view for user then your new version. Moreover, sources list is the MAIN thing that new user will check, because if he will not found needed source in sources list, then he with great probability just will close page and will go to search another programm, with needed source. That's why Sources list is the MAIN thing in your description. Because all other Grabber featured depends of it. Thats why sources must be organized as list, and that's why this list should be placed on page right below Grabber description, and above all other parts like "features", "languages", etc.


this is a comment


@davePlug It wasn't used very much, increased the size of the json and can very easily be calculated clientside with the existing data.


Are you sure about that?, I thought maybe replacing `id` with `name`: https://www.w3schools.com/tags/att_input_name.asp


Afaik it's a common trick when 2 versions of jQuery are being used. Not sure if this is the case with the game itself, as just one version seems to be included, anyway, it might have something to do with the game being embeddable in other websites, who might be using a different jQuery version; needs to be looked into perhaps...


Here is a test comment.  How do I find it later?


On your machine, are you able to load a file with only one dataset?


oh the other impl prints it when empty?


Please, add comment: obsolete, will be removed if will not be used


Hi,

I try to compile a project with this change and get Error

My Makefile

```bash
h264bitstream/h264_stream.c: In function ‘void read_seq_parameter_set_rbsp(h264_stream_t*, bs_t*)’:
h264bitstream/h264_stream.c:285:96: error: cannot convert ‘int**’ to ‘int*’ for argument ‘2’ to ‘void read_scaling_list(bs_t*, int*, int, int*)’
                                                  &( sps->UseDefaultScalingMatrix4x4Flag[ i ] ) );
                                                                                ^
h264bitstream/h264_stream.c:290:100: error: cannot convert ‘int**’ to ‘int*’ for argument ‘2’ to ‘void read_scaling_list(bs_t*, int*, int, int*)’
                                                  &( sps->UseDefaultScalingMatrix8x8Flag[ i - 6 ] ) );
                                                                                ^
h264bitstream/h264_stream.c: In function ‘void write_seq_parameter_set_rbsp(h264_stream_t*, bs_t*)’:
h264bitstream/h264_stream.c:1172:96: error: cannot convert ‘int**’ to ‘int*’ for argument ‘2’ to ‘void write_scaling_list(bs_t*, int*, int, int*)’
                                                  &( sps->UseDefaultScalingMatrix4x4Flag[ i ] ) );
                                                                                ^
h264bitstream/h264_stream.c:1177:100: error: cannot convert ‘int**’ to ‘int*’ for argument ‘2’ to ‘void write_scaling_list(bs_t*, int*, int, int*)’
                                                  &( sps->UseDefaultScalingMatrix8x8Flag[ i - 6 ] ) );
                                                                                ^
h264bitstream/h264_stream.c: In function ‘void read_debug_seq_parameter_set_rbsp(h264_stream_t*, bs_t*)’:
h264bitstream/h264_stream.c:2059:96: error: cannot convert ‘int**’ to ‘int*’ for argument ‘2’ to ‘void read_debug_scaling_list(bs_t*, int*, int, int*)’
                                                  &( sps->UseDefaultScalingMatrix4x4Flag[ i ] ) );
                                                                                ^
h264bitstream/h264_stream.c:2064:100: error: cannot convert ‘int**’ to ‘int*’ for argument ‘2’ to ‘void read_debug_scaling_list(bs_t*, int*, int, int*)’
                                                  &( sps->UseDefaultScalingMatrix8x8Flag[ i - 6 ] ) );
```

In

```C
void read_scaling_list(bs_t* b, int* scalingList, int sizeOfScalingList, int* useDefaultScalingMatrixFlag );
```

Argument 2 is int* scalingList but you pass int** because ScalingList changed for a Matrix.

My Makefile is

```C
h264bitstream/h264_stream.c h264bitstream/h264_sei.c h264bitstream/h264_avcc.c h264bitstream/h264_nal.c *.cpp ....
```

Thank you.


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2376](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=28139&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


For this it seems it would be better to implement a policy more like cisco or juniper router where if you don't configure a router id it will look for a configured IPv4 address on an existing interface and use that.  This way the router-id could be configured at configure time and it would also work for ipv6 based peers as well.

This should be a separate feature patch if implemented though.


Will it be better to use triple slash directive?

```ts
/// <reference path='./missing-service-worker-typing' />
```

Just don't know what the compiled result likes...


pull request это запрос на слияние веток. Вы делаете запрос на слияние, потом мы его обсуждаем, изменяем, корректируем, а после всего, я принимаю эти изменения и они заливаются либо сами, если нет конфликтов, либо с моим участием и с решением таких конфликтов. Вроде так.


What about:
https://domain.com/transactions

For this case, the $matches is empty (because $uri does not contain '?') and does not pass the Security::clean


@klensy If it is not a problem for me to support both 2.6 and 2.7 then I don't see a problem


I think InternalAggregation prints it if metaData is not null, but it doesn't check for emptyness


@zamakkat How does it fix the issue? Whats happening underneath?


Привет!
1) Тебя самого не смущает такой код?
"if (NO_ERROR == GetInfoFromNTHeader(buffer + dos_header->e_lfanew,
          pe_header,
          &sec_header,
          &imageBase,
&entryPoint)) {"
Не лучше ли бы завести локальную переменную и писать что то типа:
"int result = GetInfoFromNTHeader(buffer + dos_header->e_lfanew,
                                                       pe_header,
                                                       &sec_header,
                                                       &imageBase,
                                                       &entryPoint);
if (NO_ERROR == result)
{"

2)  Разберись со своей функцией:
 GetInfoFromNTHeader( char* headerBufOffset,
                                      IMAGE_NT_HEADERS* pe_header, ...
в качестве первых двух параметров ты ей передаешь абсолютно одинаковые значения. Зачем же тогда их два?! Или это такая задумка на будущее?

3) Вообще я бы даже немного отрефакторил предыдущий код и написал бы так:
struct INFO_FROM_OPTIONAL_HEADER
{
        IMAGE_SECTION_HEADER* sec_header;
        DWORD imageBase;
        DWORD entryPoint;
}
 и далее использовал ее
GetInfoFromNTHeader(pe_header, info_from_opt_hdr);

4) Лучше писать все переменные на новой строчке. Так проще их искать и код нагляднее. То есть вместо:
DWORD imageBase, entryPoint;
писать так:
DWORD imageBase;
DWORD entryPoint;

5) В прошлый раз я указал на ошибку с чтением заголовка. Это значит, что надо было исправить все подобные ошибки в коде, а не поставить заплатку в одном месте. Например, что будет, если в функцию ParseFile придет буфер размером 2, который состоит из двух байтов MZ? Или если файл имеет корректный DOS-заголовок и значение поля e-lfanew равное 0xFFFFFF48?

6) После исправлений можешь переходить к следующей задаче, если будет интересно. Эту уже достаточно замуслолили и с ней все вроде понятно


Based on [String.prototype.endsWith] documentation (https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_O) that is not supported by name browsers. How would you solve that?


В общем, нужно попробовать.


ABC & MicroBee


Em add file trực tiếp vào commit xong send pull request lại nhé, không cần dùng submodule ở đây.


Oh, it's a restriction effect. And the restriction applies when one or more cards are in hand. Ok, just need to read class names. Yay for Java being verbose.


não entendo o porque de adicionar print "", .... esta virgula para poder exibir na mesma linha não faz sentido


Watch your indentation. It's going to be really important going forward. It makes it easier for you to debug your code and for other devs to read it.


unicorn :unicorn: !!!!


Replaced forEach() iteration with reduce()


Тогда исправлю все найденные ошибки, переименую  некоторые строки и сделаю запрос. Надо выяснить как именно делать правильно.


Currently if you do not configure the router-id, ExaBGP does use the local-address for it.


Replaced for...of loop with .map()


@EerieCode https://github.com/Fluorohydride/ygopro-scripts/commit/764d03a2e7d4a21ff25849729539b0e0c7d4ffaa
@VanillaSalt I think we should move this table to aux.


`"HONOR/FRD-L04/HWFRD:7.0/HUAWEIFRD-L04/C567B360:user/release-keys"` are u sure?


Do you mean https://www.mkyong.com/maven/where-is-maven-local-repository/ ?


I want to set the voice volume of the player to whispering.
Instead doing the same stuff than the onSpeakVolumeChangePressed event (setting variables, firing OnSpeakVolume event etc) I let the onSpeakVolumeChangePressed event doing the work by assigning the TF_speak_volume_level to the previous / prior setting.
The player want to whisper? Assign TF_speak_volume_level to yelling so that onSpeakVolumeChangePressed will make him whisper.


This should probably use `{% ... %}` instead of `{{ ... }}`.


local_address should be an IP or None if unset. the string auto, while correct as a configuration option is neither of them (being a string).


The following doc(s) have been deployed to the [upstreamsa](https://upstreamsa-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/custom-upstream](https://upstreamsa-static-docs.pantheonsite.io/docs/custom-upstream)


Replaced for...of loop with filter()


@stamparm I think what they're worried about is argparse in general, it wasn't introduced 2.7 [see here](https://www.google.com/search?site=&source=hp&q=when+was+argparse+introduced+into+python&oq=when+was+argparse+introduced+into+python&gs_l=hp.3..33i21k1.15340.22900.0.23092.43.36.1.0.0.0.337.4832.0j18j7j1.26.0....0...1c.1.64.hp..16.18.3082.0..0j0i131k1j0i20k1j0i22i30k1j33i160k1.ccmZrKW4mTE) so i guess they think it's going to effect them. However I'd really like to see what systems are still using 2.6, and why they haven't updated yet. You can always just download 2.7 and have the PATH be `python27` and keep python 2.6 as `python`


It appears he's using visWrapper for the controllerAs name. {{ icons }} is accessing scope
{{ visWrapper.icons }} is accessing the ctrl's scope
See if that resolves your issue.


I thought so, cause metadata can't be empty in InternalAggregation I think, either null or it has something in it. I am surprised printing it out at all times here fixes the problem though.


Thanks @kennyklee for spotting this.


Looks good!
Thanks.


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2376](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=28139&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **SUCCESS**
Summary: Tests passed: 287, ignored: 3 Build time: 00:13:43


please, rename f to something mnemonic


hi @epsdky , could this bug, https://community.open-emr.org/t/blank-fee-sheet-on-openemr-5-0-0/2730/33?u=stephenwaite,  be related to your work here? thanks


@aszlig Fiiiine


我修改了这里，程序员请注意


How do I find this?


this fixes the zeroes for our particular build for the baseTilt servoes


I didn't check that far to be honest, just wanted to see "how parsing goes" :)

Now I think it is because I extended InternalAggregationTestCase for my parsing tests and it creates an empty Map there. We should change this to reflect the real behavior.


Be very careful leaving whitespace in your code. Inevitably it will lead to merge conflicts. You can trim whitespace in your SublimeText editor by adding this line to Preferences >> Settings >> 'Perferences.sublime-settings -- User' `"trim_trailing_white_space_on_save": true `


(and restore what you did here)


start


"start"


I wasn't able to retrieve PDD puzzles from the code base:

```
cd /tmp/0pdd/pchmielowski/dotfiles && pdd -q -f /tmp/pdd.xml20170407-8458-vkw4ve: 256 (not zero):
/app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd/source.rb:143:in `rescue in puzzles': ["in /tmp/0pdd/pchmielowski/dotfiles/.git_config", #<PDD::Error: @todo found, but puzzle can't be parsed in line #0>] (PDD::Error)
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd/source.rb:141:in `puzzles'
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd.rb:97:in `block (3 levels) in xml'
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd.rb:96:in `each'
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd.rb:96:in `block (2 levels) in xml'
	from /app/vendor/bundle/ruby/2.2.0/gems/nokogiri-1.6.8.1/lib/nokogiri/xml/builder.rb:391:in `call'
	from /app/vendor/bundle/ruby/2.2.0/gems/nokogiri-1.6.8.1/lib/nokogiri/xml/builder.rb:391:in `insert'
	from /app/vendor/bundle/ruby/2.2.0/gems/nokogiri-1.6.8.1/lib/nokogiri/xml/builder.rb:375:in `method_missing'
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd.rb:95:in `block in xml'
	from /app/vendor/bundle/ruby/2.2.0/gems/nokogiri-1.6.8.1/lib/nokogiri/xml/builder.rb:293:in `initialize'
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd.rb:93:in `new'
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd.rb:93:in `xml'
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/bin/pdd:90:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.2.0/bin/pdd:23:in `load'
	from /app/vendor/bundle/ruby/2.2.0/bin/pdd:23:in `<main>'

/app/objects/exec.rb:38:in `run'
/app/objects/git_repo.rb:60:in `xml'
/app/objects/puzzles.rb:46:in `deploy'
/app/objects/job.rb:42:in `proceed'
/app/objects/job_starred.rb:35:in `proceed'
/app/objects/job_recorded.rb:33:in `proceed'
/app/objects/job_emailed.rb:36:in `proceed'
/app/objects/job_commiterrors.rb:36:in `proceed'
/app/objects/job_detached.rb:51:in `block in exclusive'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/timeout.rb:89:in `block in timeout'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/timeout.rb:34:in `block in catch'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/timeout.rb:34:in `catch'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/timeout.rb:34:in `catch'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/timeout.rb:104:in `timeout'
/app/objects/job_detached.rb:49:in `exclusive'
/app/objects/job_detached.rb:39:in `block in proceed'
/app/objects/job_detached.rb:39:in `fork'
/app/objects/job_detached.rb:39:in `proceed'
/app/0pdd.rb:197:in `block in <top (required)>'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1611:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1611:in `block in compile!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:975:in `[]'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:975:in `block (3 levels) in route!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:994:in `route_eval'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:975:in `block (2 levels) in route!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1015:in `block in process_route'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1013:in `catch'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1013:in `process_route'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:973:in `block in route!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:972:in `each'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:972:in `route!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1085:in `block in dispatch!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `block in invoke'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `catch'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `invoke'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1082:in `dispatch!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:907:in `block in call!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `block in invoke'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `catch'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `invoke'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:907:in `call!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:895:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/xss_header.rb:18:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/path_traversal.rb:16:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/json_csrf.rb:18:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/frame_options.rb:31:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-1.6.5/lib/rack/logger.rb:15:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-1.6.5/lib/rack/commonlogger.rb:33:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:219:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:212:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-1.6.5/lib/rack/head.rb:13:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-1.6.5/lib/rack/methodoverride.rb:22:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:182:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:2013:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1487:in `block in call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1787:in `synchronize'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1487:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-1.6.5/lib/rack/handler/webrick.rb:88:in `service'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/webrick/httpserver.rb:138:in `service'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/webrick/httpserver.rb:94:in `run'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/webrick/server.rb:294:in `block in start_thread'
```


I think that was a goof. Internal `hasPath` should be removed. I want to reduce internal helpers even if that means a bit of code duplication.


I could not clearly identify the logic in the filter function. Is this to decide if there is a match based on the join type (e.g. for an inner join to verify that there is a non-null value in both streams)?


tutaj chcesz przekazac tekst guzika czyli musi byc `newElem.innerText = button[i].innerText`;
zmienna `button` przechowuje nasze guziki (swoja droga lepsza nazwa byloby `buttons`)
Jest to tablica, czyli jesli chcemy sie dostac do jej elementu musisz uzywac skladni `button[0]`, `button[1]` itd. (bez spacji ktora u Ciebie byla). Jesli uzywamy w petli to `i-ty` guzik to `button[i]`.
Jak juz mamy guzik to chcemy teraz dostac sie do jego tekstu i robimy to za pomoca `innerText`.
`button[i].innerText` to tekst itego guzika w petli. Mozesz to sprawdzic robiac `console.log(button[i].innerText)`

Widze ze chciales to zrobic funkcja i jest to swietny pomysl ale trzeba poprawic 2 rzeczy:
1. Funkcja powinna byc poza petla `for` - bo w ten sposob za kazdym razem od nowa ja tworzysz - to niepotrzebne.
2. Jesli funkcja bedzie poza petla to musimy do niej przekazac parametr i czyli bedzie wyglac tak:
```
function tekstprzycisku(i) {
...tutaj cale cialo funkcji jak do tej pory
}
```
I pozniej chcemy ja wewnatrz petli wywolac z parametrem
```
tekstprzycisku(i);
```


nie widze zebys gdzies uzywal zmiennej `ourTable`


It will be better to avoid 'Helper' in the name, try to call it something like WebRequstBuilder|Creator etc.


I think the path_base_conc_cdf should be added also in the first part for module1 after if len(argv) == 1:


saw approval from jedmccaleb
at https://github.com/vogel/stellar-core/commit/c314b3e860edc81ed9b797ad7dab6b5106901957


merging vogel/stellar-core/more-merge-tests = c314b3e8 into auto


vogel/stellar-core/more-merge-tests = c314b3e8 merged ok, testing candidate = 64ddda7f


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2377](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=28142&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


Hmm, I can't get the test to pass on old commits where it succeeded on hydra :open_mouth:


would it make sense to split this in 3 different functions for each parameter independently?
this would have the advantage that even if you parse the object multiple times you can reuse it in case some parameters are needed for the other functions


Where is ERROR_DESCRIPTION_MESSAGE_SEND_FAILED_DUE_TO_BLOCKLIST being used?

I converted it to ERROR_DESCRIPTION_MESSAGE_SEND_FAILED_DUE_TO_BLOCK_LIST in https://github.com/WhisperSystems/SignalServiceKit/commit/4f9e053248dd87f59e198be5d00be5b9bd48bfa9


but it should be split only if it make sense


1.

2.


File is in both directories

/etc/apache2/sites-available
/etc/apache2/sites-enabled


锤子


Please add at least one tests to show the correct functionlity


i would be in favor to move the creation of the filter function and the logic to do the creation of the CoProcessFunction in a dedicated method. Otherwise when we will have the other cases, the translate method will become huge!


Kill it with :fire:. When is the earliest this can be removed?


Not sure this is a 'hashing scheme' change; isn't it a 'key scheme' change?


Thanks @beatfactor & @senocular .


That is true - but it makes it easier to react accordingly in the endpoint itself. Once we get connectivity-checks for other services it might make more sense. :)


Isn't that a border? See discussion in #1828


Did you file a bug for this?


These files are part of the wptreport tool and they are unnecessary to the test-results.

The built failed because of these files so I removed them. Let me know if I got it wrong.


This breaks the tree navigation on the breadcrumb. The drop down is not visible anymore because its offset parent (the li) now has ``overflow: hidden``.


Name exceeds maximum length and is cut off most of the time


var


Depends if the await is cancelled when a client cancels the request.


thanks


i think it will bebetter to rename it to something like "query" or "queryResult"


add default MTU (recommend: 1280 - the minimum for ipv6)


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2377](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=28142&buildTypeId=ota_plus_RviSotaServer_Ci) outcome was **SUCCESS**
Summary: Tests passed: 289, ignored: 3 Build time: 00:11:11


Illegal instruction

openwrt CHAOS CALMER (15.05.1, r48532)
Linux route 3.18.23 #1 Sun Jan 31 17:30:06 CET 2016 mips GNU/Linux


@anthonykulis So i started using eclipse as my editor and now it added all these weird files to this? Is this a problem?


dạ vâng ạ

2017-04-07 22:03 GMT+07:00 Quang-Duong Ha <notifications@github.com>:

> Em add file trực tiếp vào commit xong send pull request lại nhé, không cần
> dùng submodule ở đây.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/loglamo/K59_training/commit/6cbaf50ef5ce5ed6c03a28b3ec03a174188f866b#commitcomment-21676989>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ARn5Hejtda-ayg48XfQzDWJ5scUgSNRiks5rtlBSgaJpZM4M3Az6>
> .
>


Agreed. It's not exactly intuitive, and given the kind of functions it's
used with, it'd be better to have it as a constant.

Il 07 apr 2017 5:10 PM, "Mercury233" <notifications@github.com> ha scritto:

> @EerieCode <https://github.com/EerieCode> Fluorohydride/ygopro-scripts@7
> 64d03a
> <https://github.com/Fluorohydride/ygopro-scripts/commit/764d03a2e7d4a21ff25849729539b0e0c7d4ffaa>
> @VanillaSalt <https://github.com/VanillaSalt> I think we should move this
> table to aux.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/Fluorohydride/ygopro-pre-script/commit/92b32074a563af0793b02888f13c411b796caf68#commitcomment-21677118>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AOzmLKy3R8fdhZrj7B2HklbjBjdsDuxTks5rtlHhgaJpZM4M3ANA>
> .
>


While modifying this function, I would suggest replacing the "magic value" `10` in the enclosing loop:
for(unsigned size=1; size<=10; size++)`
by a variable such as `max_length_of_java_int`.


Markkesty..hi...can you post that code so I can learn from it thanks.


I think, your image has not been loaded properly and img is None. Try to plot loaded image.


Sure will Check later


Now it is 470c189874


@Koubek could you look into this if it works for you? For whatever reason the nav-web Dockerfile, specifically the New-WebInstance.ps1 RUN fails with the error

`New-NAVWebServerInstance : Cannot bind parameter 'ClientServicesPort'. Cannot
convert value "_" to type "Microsoft.Dynamics.Nav.Types.ServicePort". Error:
"The  configuration setting cannot be parsed into a valid Int32."
At C:\install\content\Scripts\New-WebInstance.ps1:25 char:92
... esCredentialType NavUserPassword -ClientServicesPort $NAVCLIENTPORT `

but I don't see why. So to test you have to run New-NAVWebServerInstance manually in navall_web_1 but then the WebClient works


unformated code


Be very careful leaving whitespace in your code. Inevitably it will lead to merge conflicts. You can trim whitespace in your SublimeText editor by adding this line to Preferences >> Settings >> 'Preferences.sublime-settings -- User' "trim_trailing_white_space_on_save": true


Glad to see you're keeping things updated ;)


It is. I also abort the request when the UI moves away from the page.


On this commit I made the state `carSelect` as global state of `PlayDos` component. The purpose is to get the value of this state in `game-two-intro`,`game-two-select` and `game-two-play`. i.e. If I select car No1 or 2 or 3, can get this value on the whole `PlayDos` component.


update your .gitignore file to ignore them. They are project info files.
Once you update your .gitignore and commit that, you can then go back,
manually delete those files. Commit again. Eclipse will rebuild them no
worries and they will not be in your repo anymore. :)

On Fri, Apr 7, 2017 at 10:34 AM, Brandonhenk <notifications@github.com>
wrote:

> @anthonykulis <https://github.com/anthonykulis> So i started using
> eclipse as my editor and now it added all these weird files to this? Is
> this a problem?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/Brandonhenk/watch/commit/f910981b7f2e28d69787351b7dea07232485b753#commitcomment-21677574>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA-8MU9AK4-2XbWPiEPbE0RhsON7MmcMks5rtleCgaJpZM4M3DNg>
> .
>


Not critical, but can be simplified to `result?.sessionId ??`


```
type family RefFromResp (a :: Response ix) where
  RefFromResp (References ix) = Sing ix
  RefFromResp (Response _) = ()
```

Might work instead of `Maybe (SResponse ix resp)`?


help!!!!!


It might useful to to be able to set global listening address if you want to say listen for connections on any IP address. (0.0.0.0 or ::). The current implementation however is not ideal though, for one you can only specify one global listening address so you could not configure it to listen on any ipv4 and any ipv6 address. That being said we don't use this feature ourselves currently either.


TeamCity Foo Bar :: Build [Build 8](http://localhost:8111/viewLog.html?buildId=8&buildTypeId=FooBar_Build) is now running


Trailing whitespace.


TeamCity Foo Bar :: Build [Build 8](http://localhost:8111/viewLog.html?buildId=8&buildTypeId=FooBar_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:23


用 mipsle


I suggest wrapping #sendMessage in

```java
RequestBuffer.request(() ->{
    // your code
});
```
and not catching the `RateLimitException`. This will ensure all messages are being transferred in case you get rate limited (too many messages in a timeframe)


It looks like both prod and default properties using same version?


CPU usage by jetty was increased by this commit. Profiler shows a lot of calls to `LOG.isDebugEnabled()` in function `onReadEof`. In previous version that call was cached by final variable "DEBUG".


soon @ToastedBagel soon :)


It should have been %{_bindir}/chroot


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/219726627


Thanks for pointing that out @ChristophHaag ,
We'll add that file. It's a work in progress, but I expect that the plugin should be up and running in a about a week. As you probably saw there were a was a major API change from 1.0.5 to 1.0.6, so we're porting it over.


@OCReactive
i pulled the translations. Thank you for you continuous contribution!


Thanks :)


I agree.

On Fri, Apr 7, 2017 at 10:58 AM, MasterPetrik <notifications@github.com>
wrote:

> I think, that old "Default sources" list is much more easy to view for
> user then your new version. Moreover, sources list is the MAIN thing that
> new user will check, because if he will not found needed source in sources
> list, then he with great probability just will close page and will go to
> search another programm, with needed source. That's why Sources list is the
> MAIN thing in your description. Because all other Grabber featured depends
> of it. Thats why sources must be organized as list, and that's why this
> list should be placed on page right below Grabber description, and above
> all other parts like "features", "languages", etc.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/Bionus/imgbrd-grabber/commit/39710dfdf14a663434ce376fe2e5b645adf069dd#commitcomment-21676889>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AS2t8Pr-74LXnjf0WbDnwX_19IjAtvJLks5rtk8vgaJpZM4M3AcE>
> .
>


Remove the `Maybe` and change `SResponse` to
```
data SResponse ix :: Response ix -> * where
  SResponse  :: SResponse ix ('Response  t)
  SReference :: Sing (i :: ix) -> SResponse ix ('Reference i)
```
Is probably what we want


Not sure what you are suggesting here?


That would depend on your Logger implementation.  Some don't cache their level, others do.


My /advert does not work it comes up with billboards no matter what


fast-forwarding master to auto = 64ddda7f


```csharp
var children = obj["data"]["children"].Select(c =>
{
	try
	{
		return c["data"].ToObject<Stuff>();
	}
	catch (JsonReaderException e)
	{
		Console.Error.WriteLine(e);
		return null;
	}
}).ToList();
```


The static final DEBUG also prevents runtime alteration of the logging level. (which is important when troubleshooting production issues)


FYI, this change is inconsistent with the documentation at https://developers.google.com/protocol-buffers/docs/reference/go-generated#singular-scalar-proto3. ("No helper methods are generated.")

Any chance of making this an `option` setting? For my use case, smaller generated code is better, and `nil`-safe getters aren't important.


Thanks for catching this! I was testing the front matter calls and didn't realize that I committed it. Fixed with #123.


**Whoops!**

There were *10 warnings* that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

**WARNINGS**
[`src/content/en/fundamentals/design-and-ui/media/_code/responsive_embed.html`](https://github.com/Google/WebFundamentals/blame/093f2da07261d1e95c56a944e38d7329e540119a/src/content/en/fundamentals/design-and-ui/media/_code/responsive_embed.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/track.html`](https://github.com/Google/WebFundamentals/blame/093f2da07261d1e95c56a944e38d7329e540119a/src/content/en/fundamentals/design-and-ui/media/_code/track.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/video-main.html`](https://github.com/Google/WebFundamentals/blame/093f2da07261d1e95c56a944e38d7329e540119a/src/content/en/fundamentals/design-and-ui/media/_code/video-main.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/video.md`](https://github.com/Google/WebFundamentals/blame/093f2da07261d1e95c56a944e38d7329e540119a/src/content/en/fundamentals/design-and-ui/media/video.md) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/getting-started/primers/media-source-extensions.md`](https://github.com/Google/WebFundamentals/blame/093f2da07261d1e95c56a944e38d7329e540119a/src/content/en/fundamentals/getting-started/primers/media-source-extensions.md) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/media/video.md#L60`](https://github.com/Google/WebFundamentals/blame/093f2da07261d1e95c56a944e38d7329e540119a/src/content/en/fundamentals/media/video.md#L60) - Line must be at most 100 characters
[`src/content/en/fundamentals/media/video.md#L63`](https://github.com/Google/WebFundamentals/blame/093f2da07261d1e95c56a944e38d7329e540119a/src/content/en/fundamentals/media/video.md#L63) - Line must be at most 100 characters
[`src/content/en/fundamentals/media/video.md#L338`](https://github.com/Google/WebFundamentals/blame/093f2da07261d1e95c56a944e38d7329e540119a/src/content/en/fundamentals/media/video.md#L338) - Line must be at most 100 characters
[`src/content/en/fundamentals/media/video.md#L344`](https://github.com/Google/WebFundamentals/blame/093f2da07261d1e95c56a944e38d7329e540119a/src/content/en/fundamentals/media/video.md#L344) - Line must be at most 100 characters
[`src/content/en/fundamentals/media/video.md#L494`](https://github.com/Google/WebFundamentals/blame/093f2da07261d1e95c56a944e38d7329e540119a/src/content/en/fundamentals/media/video.md#L494) - Line must be at most 100 characters


SECRET = "secretCode"


Also kinda works with the Touch Hold mode implemented in the NDS core. Should note that none of this works when the window size is any non-integer ratio of the original. So maximizing and fullscreen need more adjustments.


I can comment on your commits here - even if they're in a branch.


> Ерунда какая-то, откуда единица, почему единица??
Поставил для тестирования, что бы автор сразу добавлялся, вместе со статьей.


And I can comment on individual changes in a commit like this.  You can point me to this view in three different ways:

- Reference the commit in a comment on the initial issue
- Reference a branch comparison in a comment on the initial issue
- Submit a PR for the branch


*Adapted makefile for AOSiP
Thank god this is all going into gerrit soon...


Yes, I had looked at it, but it was far too many differences to fix on the side without knowing the codebase. Thanks for doing this.


记得加奖励和处罚的具体措施/w\


You are splitting MetaCoins. You are not splitting Ethers then.


Even though the `&` sign will still be rendered it is not semantically correct. Try `&` instead. I posted a link in your slack channel for html characters. Also watch your trailing whitespace. :)


@kiok46  passwords displayed to the whole world!!


Yes, absolutely.


I see `-=` but not `+=`.


It would be better to have a `beforeEach` that redeploys a new Splitter for every `it`.


TeamCity Foo Bar :: Build [Build 9](http://localhost:8111/viewLog.html?buildId=9&buildTypeId=FooBar_Build) is now running


Search


TeamCity Foo Bar :: Build [Build 9](http://localhost:8111/viewLog.html?buildId=9&buildTypeId=FooBar_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:24


аналогічна помилка, як минулого разу. Не потрібно тобі отак робити, створювати свою строку: year + "-" + month + "-" +day
Ти можеш за допомогою year, month і day  виставити дату потрібну, за допомогою Calendar


`.then(txObject =>`.
Look at the event in `txObject.logs[0]`


:P yaar mujhe laga koi nahi dekhega 1-2 din main hata dunga, sala stalker, haha


Just ammend it :P


While experimenting with my test case (1), it turned out that the original relocation type in the '.o' file is not 'R_ARM_REL32', but 'R_ARM_TARGET2'. When linking the shared library, this relocation type gets mapped to 'R_ARM_REL32' by default for our "bare-metal" (arm-none-eabi) target, whereas for a native Linux or FreeBSD target the default mapping is supposed to be 'R_ARM_GOT_PREL'.

The default mapping for 'R_ARM_TARGET2' relocations can be overridden on the ld command line with the '--target2' argument, which can be "abs", "rel" or "got-rel" (2). When I add 'LD_OPT += --target2=got-rel" for the test case library, it can be linked without error and the test succeeds, even though the resulting relocation type in the shared library is not 'R_ARM_GOT_PREL', but "R_ARM_GLOB_DAT'.

But when I make "got-rel" the default mapping for all components, a runtime error occurs in 'init' on the pbxa9 platform with KERNEL=hw:

```
Warning: init -> ep: undefined instruction at ip=0xa30d8
```

The address belongs to a typeinfo object in ld.lib.so and is probably not supposed to be executed:

```
...
000a3098 r typeinfo name for Genode::Xml_attribute::Invalid_syntax
000a30c4 r typeinfo name for Genode::Xml_node::Nonexistent_sub_node
000a30f0 r typeinfo name for Genode::Dataspace
...
```

(1) https://github.com/cproc/genode/commit/aee8f27ab60dbd30f81c959f48e5d234f25ae798
(2) https://sourceware.org/binutils/docs-2.28/ld/ARM.html#ARM


And the replacements happen only in full run, so out-min is correct, the out is wrong.


TeamCity Foo Bar :: Build [Build 10](http://localhost:8111/viewLog.html?buildId=10&buildTypeId=FooBar_Build) is now running


haha


TeamCity Foo Bar :: Build [Build 10](http://localhost:8111/viewLog.html?buildId=10&buildTypeId=FooBar_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:23


Love the commit message and branch name!


I dont know who added this -.-


OK, thanks for the confirmation. I wasn't sure string expressions were always represented as unbounded arrays.


hah trying to do some stuff across machines and this was the easiest way 😄 but it'll get cleaned up soon


Thanks! BitHub has sent payment of  $65.88USD for this commit.


There is a typo in the title


here is the typo


let's explore a permanent storage route, you will lose all userNames every time you restart your server


No need for this keyword here. Yes id should be constant.


Seems like your'e checking twice for a valid username...


Maybe put this behind an individual helper method


I understand it, I will try it next time. Thank you.


Maybe use some form of `traverse` here (indexed) that checks that:
-  all refs that the cmd uses are in scope,
- generate new refs in `Pair IntRef` for each var

This should probably become something like `Gen (Maybe (Untyped' cmd (Pair IntRef)))` which we can then use:
https://github.com/nick8325/quickcheck/issues/159#issuecomment-289930952 to get what we want.


TeamCity Foo Bar :: Build [Build 11](http://localhost:8111/viewLog.html?buildId=11&buildTypeId=FooBar_Build) is now running


TeamCity Foo Bar :: Build [Build 11](http://localhost:8111/viewLog.html?buildId=11&buildTypeId=FooBar_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:22


Yes can be achieved by name attribute. Will need small change in handleChange handler as well.


Let's discuss testing as well


Thanks @michaelkirk I've reverted this change.


Thanks!


TeamCity Foo Bar :: Build [Build 12](http://localhost:8111/viewLog.html?buildId=12&buildTypeId=FooBar_Build) is now running


Sejt! Det her er nytænkning!

Synd committet her var så svært at finde ud fra commit-beskeden alene. ;-)


TeamCity Foo Bar :: Build [Build 12](http://localhost:8111/viewLog.html?buildId=12&buildTypeId=FooBar_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:00:22


config


Let's pass in name, password and have a method first called where we get name, password from the input.


Sorry I could not open the documentation you pointed to. The link did not work. But I am referring to adding this method by polyfill as mentioned [here](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/endsWith#Polyfill)


不知道，尝试一下咯。


an interesting side feature we could explore is a more secure password storage


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


@aditheking Heheheh


You left a print


This seems like something that should no longer apply when you enforce a unique username


Nice!


I appreciate this section ^


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/68a0060b-e991-44f3-acd9-e2a747e3b155 "ravt2017iot01"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/881864dd-e99c-415a-8ea6-343ca0a574f3 "ravt2017iot01") deployed this commit to [dev](https://console.ng.bluemix.net/apps/cbf41f10-fcbb-4723-8e23-3253c14772cb "ibm:yp:us-south:rviaud@cr.ibm.com:dev")


seems like a bad security practice to print out password if we are trying to make this  a secure app ;)


this method returns `bool` now, so this doesn't compile. looks like it should be `return false;`.


accepted


as mentioned before let's consider parsing input before calling signInUser


Actually, I think it's a more user friendly and code clean approach if we take the username -> check if it exists, and then take the password, validate in two seperate prompts


I wonder if we should bold this more 😁


Udated social media


очень много недочетов, плохой юзер експиренс
подходи на практике


I don't know if I mentioned this but when you submit a bug fix could you label it BF: in the commit message so that I can find things more easily. When I create a patch release I need to cherry-pick to a new branch only bug fixes and having the BF: label makes that easier. Thanks!


Need to make sure we add authentication so only admins can see this page


Don't forget to add `.md` extension 😉


Yes, it's pretty clearly a promise so I may do some renaming in a bit.


@bob-carpenter could you tell me in which situations this `if (expr.expression_type() != VOID_T)` would return `True`? For some odd reason that I'm unable to track `integrate_1d(ftft, 0, 1, p);` is getting this error message of "llegal statement beginning with non-void" despite the fact that I set `pass = true;` on `validate_integrate_1d`


😮  Whoops


Clean your prints


sorry about that :/


Créez des pages web interactives avec JavaScript
Activités_1


Usually we add an intro paragraph explaining the motivation for this release, thanking contributors, etc. Would be nice to highlight how React public API hasn't changed for [exactly a year](https://facebook.github.io/react/blog/2016/04/07/react-v15.html) and while we're committed to stability, we also need to move forward together with the community. (You mention stability below but it would be nice to call it out in the intro paragraph.)


Créez des pages web interactives avec JavaScript


You can see my code and related files at
https://drive.google.com/open?id=0B1mkW7rsGhsPVS1nLXFCb1R2ams
Thank you for your help

2017-04-07 16:48 GMT+02:00 Melinda Minch <notifications@github.com>:

> Hmm - what does your code look like? If I can take a look, I might be able
> to help. Is your xml file from zoomify in a place where the script can
> reach it?
>
> Thanks,
> Melinda
>
> > On Apr 7, 2017, at 7:18 AM, arrigo55 <notifications@github.com> wrote:
> >
> > Thank you so much for your very quick answer. I know very well Zoomify,
> but
> > I am quite new of Openseadragon and may be I am doing something wrong. I
> > have copied your html script, adjusted the adrresses for openseadragon.js
> > and for the tiles directory, but I always get the message "Unable to open
> > [object Object]: Unable to load TileSource". Moreover i do not know the
> > meaning of 'type: "zoomifytileservice",'. Can I use the normal
> > openseadragon-bin-2.2.1?
> > Have I to do any change? Thank you in advance for your help.
> > BW
> > Arrigo Capitanio
> >
> > 2017-04-07 10:33 GMT+02:00 Daniel Berthereau <notifications@github.com>:
> >
> > > The most basic one, a simple folder of tiles and the standard
> > > ImageProperties.xml created with the zoomify script.
> > >
> > > —
> > > You are receiving this because you commented.
> > > Reply to this email directly, view it on GitHub
> > > <https://github.com/openseadragon/openseadragon/commit/
> f3198929b08f59387242da04fe9efc8533d797e4#commitcomment-21671188>,
> > > or mute the thread
> > > <https://github.com/notifications/unsubscribe-auth/AJ0YNmhq0wno6e2_
> tSuVNFCQUmJKOUunks5rtfTRgaJpZM4M2lCL>
> > > .
> > >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub <https://github.com/
> openseadragon/openseadragon/commit/f3198929b08f59387242da04fe9efc
> 8533d797e4#commitcomment-21676173>, or mute the thread <
> https://github.com/notifications/unsubscribe-auth/
> AAhcK2RygwNDvYAZnjee3AjaIF-0mZUmks5rtkXNgaJpZM4M2lCL>.
>
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/openseadragon/openseadragon/commit/f3198929b08f59387242da04fe9efc8533d797e4#commitcomment-21676722>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AJ0YNswZvJ3GrWW7W1mJ88kyB0Va2fqLks5rtkyngaJpZM4M2lCL>
> .
>


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/588f383c-31f4-41ff-a07a-b28b3f931c80 "WestFieldServlet"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/c12fb70d-7bd5-49b2-a05b-1c8339e6d87d "WestFieldServlet") deployed this commit to [WestField](https://console.ng.bluemix.net/apps/e24bfad3-2ee1-4f43-8f66-6892de442d14 "ibm:yp:us-south:POT_Org:WestField")


I am not sure if my understanding is 100% correct so correct me if I am wrong.

So what this section of the code is trying to do is overwrite the Rails application default `secrets`  method with it's own. It's doing so by first aliasing the original method, then calling it in the over-written one to avoid infinite recursion.

The issue is (at least from what I understand) is that the load order of gems and application somehow changed, so when this gem is loaded, the `secrets` from the Rails application is not yet loaded, thus the `alias_method` fails with NoMethodError.

The fix just replaces the use of `alias_method` with a call to super which should give the same behavior without trying to initialize based on a method that does not exist at that point of time.


right commit


Author changed


You are the baap of directives. You should have written some directives :\


++- great fix 😄


add @blueprintjs/docs npm shield

Preview: documentation
Coverage: core | datetime


If local-address happens to be IPv4.

My point is it seems better overall to if the router_id is not specified lookup an valid IPv4 from en existing interface and use that one, this would allow the router_id to be detected for ipv6 peers as well as in the case you are using auto detection (which could be for both ipv6 or ipv4). This actually what we do in our own external code for generating config files, and means we don't have to worry about if a peer is using ipv4 or ipv6 addresses.


name_attribute shouldn't be here, it's not something to be set, it's a method for calculation


This page in particular might be better off with unit tests (using webdriver tests instead for integration or behavioral tests)


Nice distribution, whoever has done it! (y)


Accidentally forgot to delete test .csv file before pushing to repo.


Great!

Op vr 7 apr. 2017 17:39 schreef Richard Astbury <notifications@github.com>:

> It is. I also abort the request when the UI moves away from the page.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/OrleansContrib/OrleansDashboard/commit/57fc9fd3d501349c77d83626f9709ebb0dc39e7e#commitcomment-21677633>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAhkV4m2zK4qRnvc3FY9RAeGtklOp-ooks5rtliigaJpZM4M22Sc>
> .
>


Uhhh... take this out for sure


don't need the nil check


This needs to be reverted since it was added in msm8956-common


`@required = !!attributes['required']` is shorter and basically the same thing


omg. will make now
how could i!!!!!!


This is good!


Something I missed earlier... When you want something to show up as default in the input try `placeholder` instead of `value`. When you use value, the user has to delete it before entering their info.


It would be relevant to explain where to download this package, as it does not seem to be in the standard repos of Debian (at least on Jessie).


TeamCity OTA+ :: libats :: ci [Build 38](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=28166&buildTypeId=libats_Ci) is now running


TeamCity OTA+ :: libats :: ci [Build 38](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=28166&buildTypeId=libats_Ci) outcome was **SUCCESS**
Summary: Running Build time: 00:01:06


This is awesome thanks!
Doubleclick on the pallet should choose the color and close the pallet.


l'idéal serait de ne pas avoir ce genre de fichier temporaire après avoir faire tourner ton script.
Soit ne pas les créer, soit les supprimer à la fin


should be `sum.nearestFloat`


Esse guri vai dar bom


Any technical or performance reasons to make these changes - or is it just cosmetic?


Is this change needed anymore since you dropped testing on Rails 3.2?


If there is a good reason to use file-truename, the obvious fix here would be to call it once before the loop.


met tout ça dans des fichiers de paramètres.
Une idée en plus, parfois on veut des courbes en français. Tu peux, dans ce fichier de paramètres, mettre la valeur en français et en anglais


What is the goal of this change? Is there a codemod for this? What happens if you use propTypes for context? (I know what, but it would be nice to mention it because people will ask it.)


Jeg følger med i hvert eneste commit, så beskeden betyder ikke så meget for mig.


We generally avoid experimental syntax unless the doc is specifically about it.


Nit: blank line after imports


strange that it doesn't work.

Note that PHPDoc needs `/**` not `/*`, maybe the annotations parser requires that


v2.1.0-patch1 (jmarrec) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


![](https://github.trello.services/images/mini-trello-icon.png) [ULM:Class](https://trello.com/c/ZiFceZlX/3-ulm-class)


Mode=1 - ну очень читерная штука, выпили бы ты ее!


It is not super clear what changed. Maybe we can use the syntax for highlighting specific lines like we do in the docs?


Nit: semicolons


Je me suis peut être mal exprimé.
Ce à quoi je pensais, c'était:
Si on spécifie un commit, alors on ne tient pas compte du path.
Sinon, on prend en compte le path.

On en rediscute


The hard-coded path might be put in a variable, even if it's still hard-coded for now.
The README (or this script) should explain what to put in this path, if necessary


What if I use React UMD bundle?


Are all your commit messages in the present tense? :laughing:


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/7cb81ef6-9fd6-4e33-949b-899649f7723f "stronglooptraining-toolchain-1491582278228"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/5f2d2a94-da72-4033-8229-ee5892449082 "stronglooptraining-toolchain-1491582278228") deployed this commit to [demo](https://console.ng.bluemix.net/apps/c41b49d0-ecc8-4670-aabe-4abca2b4ffd5 "ibm:yp:us-south:jhspain@us.ibm.com:demo")


As I mentioned, I think we need to keep all new enums values both for Permissions and for the LoanTransactionType. They all are needed for displaying correctly the data that was created in Mambu itself but is viewed on the mobile app.  There are also Mambu features that app doesn't support (accounting, admin, etc.) but for which the enum values need to be known for display purposes.
 I think the correct policy for this in general is:  if the Mambu enum type itself is needed by the Mobile app  (of course only some of them are needed) then all its specific enum values must be also known to mobile.   We can add the actual strings for them later, once they are placed to PhraseApp by Mambu.


Maybe we should use ES5 requires here?


What is a codemod? Worth linking to an explanation.


Is it necessary to add the html, head and body tags?
Aren't they already in the article content inside the ZIM file?


Because it's not necessary for me to say what it does when all the people involved (My class) know what it does. You don't need to comment on all my class work, dude. XD


@jdalton lol thanks for keeping me honest


Looks like you're still hacking at this one. Try to make sure when you are creating naming conventions you are avoiding collisions. By naming your function the same name as what I'm assuming is going to be a string, they are bumping heads and creating errors.


Worth mentioning that we recommend just using arrays with keyed items instead?


У сканера мало зарядов. иногда просто нужно подсветить предметы что лежат под ногами у игрока, а тратить на это дело заряды сканера....


Worth mentioning that 1.1.1 is a drop-in replacement?


My aim was to accomplish this soon, so that i can complete my demo application. Otherwise I'd have wrote something ;)


I don't think this works for the use case. Many people intentionally *don't* want to use Immutable.js because of harder debugging, size, API surface, and other issues. I think we should suggest https://github.com/kolodny/immutability-helper which is a drop-in replacement.


must be return value
```
result = fn(*args, **kwargs)
self.reconnect_all()
return result
```


Is it worth mentioning what happens to ReactPerf?


lol


Right, I left the intro paragraph until the end, couldn't think of what to lead with. I like your suggestion.


Is it worth mentioning we'll be dropping support for `react-with-addons` in 16, and suggest people to migrate from it? Is it worth mentioning addons now have UMD builds, which they didn't before?

Do addons npm packages have their own documentation in READMEs or do we keep docs on React website forever?


Forgot we could do that 👍


valid if Enzyme?


@VoyagerOne I have submitted a new test with that idea.


Be very careful leaving whitespace in your code. Inevitably it will lead to merge conflicts. You can trim whitespace in your SublimeText editor by adding this line to Preferences >> Settings >> 'Preferences.sublime-settings -- User'
`{"trim_trailing_white_space_on_save": true}`


I suppose you use Carthage. See https://github.com/Carthage/Carthage/issues/1867 for some context


>Is there a codemod for this?

I'll try to hack one out this morning :)


OPNÅR CONCIEGGS BEVIDSTHED? CIVILSTATUS? FØLG MED I NÆSTE COMMIT!


А чего не всем привычный Shift ?


@bvaughn is writing one (modification of the `ViewPropTypes` one he created for React Native, I'll add it here when he's done).


переменная напзывается статус а поле стейтмент - исправь


+ напиши доку на русском над этим полем что оно значит


halcon二维码识别有没有做过？


I see no reason why we are moving fields around. This stops that. I have tested this and it works. The last column in my spreadsheet is now staying as the last field in the json file.


Yes, exactly


Gentle preference for a new file -- easier to delete.


What case it's trying to defence against? Why do we need to check if `content_type =~ %r(\Atext/javascript)`?


@nedbat - this is the commit that's causing the doctest vs coverage.py problem...


SixIndepVarTable (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2486 of 2488 tests passed, 594 test warnings)

 * 596 tests had: AUD diffs.
 * 2 tests had: Table big diffs.
 * 1 test had: Table small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.92%25-yellow.png)


nit: maybe swap "to generate" for "when generating" or "while generating"?  The counter itself doesn't generate.


@rachmadaniHaryono can you check https://travis-ci.org/jarun/Buku/jobs/219723921? This is the second time it has happened. If I restart the build it would work. (Cleanup issue???)

I have uploaded the logs at http://paste.ubuntu.com/24335059/ in case it's filed *automatically* when I restart the build.


Also changed Serial speed to 115200 AND added ack support


To fix issue#8


Are we really confident that 100 aliases will be enough?  Can we `panic!` when we violate this to avoid surprising wraparound errors?


Maybe "Fixes an error when using `ReactDOM` together with `ReactDOMServer`"?


Fixed in d8f0118.


Added logo


может быть здесь заюзать java 8 ? :)


waaaww nice T


nice


supposed to be </h3>


looks good!


Надо предусмотреть возможность ментору зарезолвить таск, а потом отказаться от него. Ну, типо он понял что не сможет сейчас помочь и отдаёт его всем.


logo


@lassoan Why not exposing onMasterVolumeNodeChanged and onSegmentationNodeChanged?

In my case, I would like to react at least to master volume node chances since I want to display patient information in quantitative reporting


`Atomic*` is `Sync`, so you could safely just use `&Atomic*`.  Are you introducing the `Rc` simply to not have to track the lifetime?


+/*jslint nodejs: true*/
 +
 +'use strict';
 +
 +var express = require('express'),
 +    port = process.env.PORT || 3000,
 +    app = express();
 +
 +app.get('/example', function(req, res){
 +  res.json({
 +    text: 'This is an example.'
 +  });
 +});
 +
 +if(!module.parent){
 +  app.listen(port, function(){
 +    console.log('Express server listening on port ' + port + '.');
 +  });
 +}


i don't know what i'm reading :)


**Whoops!**

There were *54 warnings* that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

**WARNINGS**
[`src/content/en/fundamentals/design-and-ui/media/_code/breakpoints.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/breakpoints.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/compressive.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/compressive.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/conditional-mq.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/conditional-mq.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/fragment.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/fragment.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/fullscreen.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/fullscreen.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/icon-font.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/icon-font.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/icon-svg.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/icon-svg.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/image-set.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/image-set.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/image-sprite.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/image-sprite.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/media-query-dppx.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/media-query-dppx.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/media.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/media.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/notype.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/notype.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/responsive_embed.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/responsive_embed.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/scripted.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/scripted.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/sizes.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/sizes.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/track.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/track.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/unyt.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/unyt.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/_code/video-main.html`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/_code/video-main.html) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/images.md`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/images.md) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/media/video.md`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/media/video.md) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L43`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L43) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L49`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L49) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L167`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L167) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L170`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L170) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L193`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L193) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L196`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L196) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L263`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L263) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L266`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L266) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L278`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L278) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L307`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L307) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L365`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L365) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L420`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L420) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L421`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L421) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L428`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L428) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L525`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L525) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L528`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L528) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L555`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L555) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L558`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L558) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L586`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L586) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L589`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L589) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L651`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L651) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L654`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L654) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L659`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L659) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L661`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L661) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L683`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L683) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L686`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L686) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L783`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L783) - Line must be at most 100 characters
[`src/content/en/fundamentals/design-and-ui/responsive/images.md#L786`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/design-and-ui/responsive/images.md#L786) - Line must be at most 100 characters
[`src/content/en/fundamentals/getting-started/primers/media-source-extensions.md`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/getting-started/primers/media-source-extensions.md) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/media/video.md#L60`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/media/video.md#L60) - Line must be at most 100 characters
[`src/content/en/fundamentals/media/video.md#L63`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/media/video.md#L63) - Line must be at most 100 characters
[`src/content/en/fundamentals/media/video.md#L338`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/media/video.md#L338) - Line must be at most 100 characters
[`src/content/en/fundamentals/media/video.md#L344`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/media/video.md#L344) - Line must be at most 100 characters
[`src/content/en/fundamentals/media/video.md#L494`](https://github.com/Google/WebFundamentals/blame/5c8613c236d5179d5050cf6975cc652865fa9591/src/content/en/fundamentals/media/video.md#L494) - Line must be at most 100 characters


@brettcannon @nedbat - am I right in reading this as "the test below will not be run when anything that sets a trace function (such as coverage.py) is run. If so, is this ever run? (I mean, I'm guessing CPython's CI measures code coverage?)

I can't reproduce the situation where https://github.com/python/cpython/blame/master/Lib/doctest.py#L1480 is doing anything but setting the trace function to what it was already. @nedbat, in the case of that being a `coverage.CTracer`, could that confuse the tracer into turning itself off?


I'd rather see this patch disabled


SixIndepVarTable (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2526 of 2528 tests passed, 598 test warnings)

 * 600 tests had: AUD diffs.
 * 2 tests had: Table big diffs.
 * 1 test had: Table small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.92%25-yellow.png)


Hello, just wanted to point out that for most events there are convenience event functions, see for example: http://doc.qt.io/qt-5/qwidget.html#resizeEvent or http://doc.qt.io/qt-5/qwidget.html#protected-functions

Would safe some conditions and casts.


tu le fais la il faut juste l'externaliser


Hi, Could you do me a favor to tell how to recognize QRCode which the charset of the context is GB2312? Thank you.


yep


Browsers have _ as default selector. It has map included. But it doesn't work on all browsers


SixIndepVarTable (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


Jeg plejede at være Arto-gift med concieggs, men så lukkede de hjemmesiden.


sjaksjslf


As far as I understood, in this case `res.body` refers to the object that was passed through `json` middleware and `res.text` refers to JSON representation of the object.

But if response is set through `res.send('some str')`, then `res.body` is `{}` and `res.text` is equal to `'some str'` that was actually passed to `res.send()`.

Summing up this and a bit of docs, should i use `res.text` when `Content-Type` header is set to `"text/html"` and `res.body` otherwise?


> the method is determined whether the Javascript is precompiled or compiled at runtime.

I was trying to say something like "how you do this changes based on whether the Javascript is compiled beforehand or at runtime"


Caution! `file!` inherits `make` and `to` from `url!` -- these need to be reviewed!


I don't think this is right, deferLockRelease doesn't close this handle, it opens a new one and closes that.  Unless you want to pass this handle into deferLedgerLockRelease (which doesn't seem worthwhile given the rarity of this path), I think we need to unconditionally close the handle.  Easiest way would be to just do the open/assignment in a try-with-resources.  I'll post a patch later today.


missing breaks


Also switched to Java 1.7 in this commit


I think this is why PUT throughput collapsed? :)


SixIndepVarTable (Myoldmopar) - i386-Windows-7-VisualStudio-14: OK (2494 of 2494 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


`LOG.warn('Unexpected lock mode encountered {}', extensibleInodePath.getLockMode().toString())`


dude, the very first thing you should do (if you're even serious about programming) - is align your code properly


nit: use named constants for the values


Yes, otherwise each task will incur a separate Raft round-trip.


wrong link, it must be [https://git-fork.com/](https://git-fork.com/)


Remove if you don't need it.


why is this line is on the same alignment level with parent "div"?


-6 This is an excellent magic number :)


Should there be a test-suite case for this?


link for convenience https://github.com/ManageIQ/manageiq-content/pull/36/files#diff-abfd4cdf66e8b2eabefa66847006212a


In this particular case there is no difference between using `res.body` or `res.text`. But in case when server returns an object, it is a good practice to perform additional checks on `res.body`, for example `expect(res.body).to.have.property('id')` etc.
So, you are basically right, for simple text use `res.text`, for objects or arrays - `res.body`, I guess.


Still, match the coding style.


oh this is a great change! so much easier to build now


/cc @daliwei


You're right.


Watch your trailing whitespace.


Je ne vois pas ou la taille de l'etiquette dymoc est prise...
sur ma branche si je n'ai pas les données Hauteur/Largeur/MrgHaut/MrgGauche
l'affichage est faux.
Tu as mis ces données ou dans la classe CEtiquettes?


Added space at line 22 column 3


Agreed!


I pushed a revert. Does it fix it for you now?


@gribeill  should we just merge this in and fix any bugs later?


There is no leak of resources by not calling `LedgerHandle.close()`, but if you force the `close()` it will close the ledger itself, fixing the `lastEntry` in the ZK metadata and fencing off the current writer.

This deferral logic is made so that in case the last segment of a ledger is still open, the replication worker will leave 30s for the current writer to switch over to a new bookie (when getting write error on the failed bookie).

After 30s, the replication worker will get through anyway and will fence the ledger and start replication.


nit: it is more efficient to use a `StringBuilder` to `String` ... it does not really matter here as the code path will be dominated by remote IO and the compiler might end doing this optimization for you, but I thought I would point this out anyhow :-)


Didn't know where to post, found 'fix compile issue' and decided to post here.

Downloaded latest angle branch.  Video plugin doesn't build.  I had 19 succeeded, 2 failed, 0 up-to-date, 5 skipped, on build Release solution with android plugins and setup unchecked from build process.

Error is:
fatal error C1083: Cannot open include file: 'Glitch64/OGLEScombiner.h': No such file or directory


If this is empty you can auto-close the tag. And place a newline at the end


TeamCity Code :: 1. Development :: DDK :: Feature [Build 238](http://mp-ci.centralus.cloudapp.azure.com/viewLog.html?buildId=19643&buildTypeId=Code_Development_Ddk_Feature) is now running


Documento con la Introducción, metodología, cronógrama y ejemplos del proyecto.


`<p><form>` n'est pas autorisé par HTML.


TeamCity Code :: 1. Development :: DDK :: Feature [Build 238](http://mp-ci.centralus.cloudapp.azure.com/viewLog.html?buildId=19643&buildTypeId=Code_Development_Ddk_Feature) outcome was **SUCCESS**
Summary: Tests passed: 41 Build time: 00:02:17


Does this allow you to click the bookmark (and fire an event) without triggering the router-link?


thank you for the reply
yes it can be fixed by borderColor: null

but i want border when Medium and High is not 0 ..


TeamCity Code :: 1. Development :: DDK :: Feature [Build 239](http://mp-ci.centralus.cloudapp.azure.com/viewLog.html?buildId=19645&buildTypeId=Code_Development_Ddk_Feature) is now running


@idiot @jamiechong Seeing the same breakage of subsequent function calls.


To design the proposed new system acoording to the desired requirements for the proper operation of convolutional neural networks


Looks like you are trying to grab a jpg file but there are no jpg files in the main directory. You need to prefix the image name with what folder it's in, for example:

large-gallery/2017/april/nameofpic.jpg

Something we can go over.


TeamCity Code :: 1. Development :: DDK :: Feature [Build 239](http://mp-ci.centralus.cloudapp.azure.com/viewLog.html?buildId=19645&buildTypeId=Code_Development_Ddk_Feature) outcome was **SUCCESS**
Summary: Tests passed: 41 Build time: 00:01:17


Getting rid of the leading `/` should make your links work as intended.


Be very careful leaving whitespace in your code. Inevitably it will lead to merge conflicts. You can trim whitespace in your SublimeText editor by adding this line to Preferences >> Settings >> 'Preferences.sublime-settings -- User'
`{"trim_trailing_white_space_on_save": true}`


To implement the developed mobile based application.


SQLite will error at 64.


If we have more users for the session then I think the ID should be just sent with extra parameter and `remoteContext` can just be static `client-session`. `NewClientSessionIdentifier` should be specific to file sending. Everything else should use `SessionManager().GetSession()` directly. Or define some common access point.


To test and validate whether the mobile phone application addresses the stated objectives and implement it.


Something to go over as well. Probably not keep images in the repository but I like how the folders and files were named. Great start.


Watch your whitespace.


TeamCity Market :: INFRA :: Graphouse :: Graphouse on change [Build 3](https://teamcity.yandex-team.ru/viewLog.html?buildId=8326451&buildTypeId=MarketInfra_Graphouse_GraphouseOnChangeOpensource) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 10 Build time: 00:00:23
### Failed tests
```
ru.yandex.market.graphouse.MetricUtilTest.getLastLevelName: <no details avaliable>

```


Yeah, this is the easiest way to give this pseudo-value semantics. It's also what everyone else does (e.g., see the documentation for Rayon).


The major version indicates only API-level compatibility and not ABI compatibility. Maintaining ABI compatability in C++ APIs is certainly feasible but a lot of effort (structure padding, adding extra virtual functions as spare vtable entries, etc) and after attempting long-term ABI compatibility in 1.10, the practice has been explicitly disclaimed (see `doc/abi.rst`). There is some interest in using C++ pimpl idiom to reduce ABI churn, such as #884, but those changes being merged will themselves change the ABI.

You can see in the ABI report https://abi-laboratory.pro/tracker/compat_report/botan/2.0.1/2.1.0/cb814/abi_compat_report.html that the removed symbols are ones that will in 2.1 instead be generated by the C++ compiler. For example the missing`_ZN5Botan3TLS9CallbacksD2Ev` (or demangled `Botan::TLS::Callbacks::~Callbacks()`) is instead defined by `virtual ~Callbacks() = default` in the 2.1 header.

`release_so_abi_rev` should have been increased in 2.1, but I did not consider the possibility that there were ABI changes in the 2.1 release so it didn't happen. It would be good to have a script to automatically compare the symbols between master and some tagged release (rather than waiting for the abi-labs report which only happens after release) so problems of this nature can be detected.


@dberzano fixed the typo and reformatted the test programs with clang-format, i'll make the PR


Make sure you have a consistent indentation throughout your code. Not only will it help you track bugs when your code gets more complicated, but it will also help other devs read your code more easily.


Это я видимо из своего конфига брал - у меня на END стояло )
Согласен насчет дефолта, поменяю.


documentos


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/ca5793b2-cf53-46bb-ba01-8991e675c06c "simple-toolchain-1491579369553"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/18955329-ec54-4838-bb81-1dc1e51daa3d "simple-toolchain-1491579369553") deployed [simple-toolchain-1491579369553](https://github.com/telsdl/simple-toolchain-1491579369553/releases/tag/deploy-ibm-yp-us-south-TELSDL-dev-20170407-173752 "deploy-ibm-yp-us-south-TELSDL-dev-20170407-173752") to [dev](https://console.ng.bluemix.net/apps/1bb35b1d-270e-4416-ade0-fe3117793c9f "ibm:yp:us-south:TELSDL:dev"), including this commit


I would help to have more context here.  `VOID_T` only arises as the return type for a void function, such as

```
  void foo_lp(real y, real mu, real sigma) {
    y ~ normal(10 * mu, sigma / 10);
  }
```

Void functions can be used as statements.  This gives you a way to write functions to increment the log density directly rather than insisting on doing it all through returns.


Watch your indentation.


For the token based auth it would be very cool to not send password/identitytoken at all. Instead request new `RegistryToken` from the client and send it back to daemon. That is more work but I think that should be the end goal.


Why not casting below instead of using this var?


Thanks!


skratka ne vem kaj se je zgodilo... na koncu je šlo skozi...
~~asdf~~


The error probably arises from the parser trying to parse an expression as a standalone function used as a statement.  That only works if the function has a `VOID_T` return type.  You shouldn't have gotten that far in the parse---the problem is that you need to match whatever you intended to match earlier.


Copart Coding Challenge :

Please find the codes for the following branches::

Closest Copart facility
Closest Yard Estimation
License key
Pdf Text extractor
String to Integer


We should log so that user sees if daemon asked passwords for a specific registry.


Much better indentation! Watch your whitespace, though.


settery dla liczb i wyniku troche nadmiarowo - w zadaniu jak kojarzę było trzeba przechować w tablicy, która była atrybutem obiektu historę operacji w formie tekstu - ty w funkcjach niżej robisz echo.
Chyba, że mylę zadania ;)


SixIndepVarTable (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1294 of 1294 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-37.64%25-green.png)


Finds the greatest common factor of two numbers


Be very careful leaving whitespace in your code. Inevitably it will lead to merge conflicts. You can trim whitespace in your SublimeText editor by adding this line to Preferences >> Settings >> 'Preferences.sublime-settings -- User'
`{"trim_trailing_white_space_on_save": true}`


Well, actually ``&`` isn't used as *and* operator but to indicate a reference of the object Visitor -> no space


No space here


No space


Unless you are using some special code... This does not compile... Did you mean GetGetMethod() instead?


Your indentation should be consistent throughout your code. Not only will it make for easier debugging when your code gets more complex, but it will also make for easier reading by other devs.


No you have to add a new line


>I think the "default" output would make sense somewhere like, src/${sourceSet.name}-gen/${language}
You want to get rid of the `outputDir` configuration value in favour of more Java plugin-like configuration?

>When we generate the sources, could we call SourceSet.java(...) to configure it for the generated set?
I'm not 100% clear on the goal with this one. Do you want to set the `srcDir` for the `SourceSet` that we're adding the `umple` source set to at generation time? For example, if we're using the `main` source set, you want to set the `srcDir` for that source set at generation time? I don't think that'll work, we tried doing that before.

Can we zoom out and come up with a list of remaining issues for the plugin? The way I understand it we basically need to beef up the test cases a bit (lower priority) and add support for "convention over configuration"-style support for compiling the generated source files (higher priority because this changes the way the plugin is used). I'm not sure how the second point can be accomplished, because the only place we can configure the Java compilation tasks is inside the `UmpleGenerateTask` after all the configuration information has been read in. When we tried to do this before (we originally tried setting `srcDir` and `dependsOn` inside `UmpleGenerateTask`) we couldn't make it work. It's possible things just weren't "hooked up" correctly... I'll try putting the configuration stuff back inside `UmpleGenerateTask` and see if I can make it work.


It does, yes. Thank you.

On 07 Apr 2017, John Kitchin <notifications@github.com> wrote:

> I pushed a revert. Does it fix it for you now?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.*

--
Jonathan


For capture/refund/void, looks like the key should be the authorization's external key instead the external key of the capture itself because the same set of `order_id` or merchant ref code was used for a payment (including auth and capture). See [here](https://github.com/activemerchant/active_merchant/blob/v1.48.0/lib/active_merchant/billing/gateways/cyber_source.rb#L263)


This should close #3


Watch your whitespace.


Watch your indentation.


Irineu


Thanks for the advice.

If updated my answer.

Thaddeus


 The following implementations are
Decision Tree Algorithm - Python
Naive Bayes Classification - Python
Logistic Regression - Python
Image Compression though K-means Clustering - Java


![](https://github.trello.services/images/mini-trello-icon.png) [ox compiled test-suite](https://trello.com/c/qWE8Xlc6/11-ox-compiled-test-suite)


@stamparm If so - yes.


TeamCity Market :: INFRA :: Graphouse :: Graphouse on change [Build 4](https://teamcity.yandex-team.ru/viewLog.html?buildId=8326560&buildTypeId=MarketInfra_Graphouse_GraphouseOnChangeOpensource) outcome was **SUCCESS**
Summary: Tests passed: 11 Build time: 00:00:23


TeamCity Market :: INFRA :: Graphouse :: Graphouse on change [Build 5](https://teamcity.yandex-team.ru/viewLog.html?buildId=8326561&buildTypeId=MarketInfra_Graphouse_GraphouseOnChangeOpensource) outcome was **SUCCESS**
Summary: Tests passed: 11 Build time: 00:00:22


```ent->car.cir = val / (HZ * BITS_PER_BYTE);```
Делаем
echo +192.168.138.38 31457280 > /proc/net/ipt_ratelimit/limit_out
А получаем:
 cat  /proc/net/ipt_ratelimit/limit_out | grep 192.168.138.38
192.168.138.38 cir 31456000 cbs 5898240 ebs 11796480; tc 0 te 0 last never; conf 0/0 0 bps, rej 0/0

Т.к. 31457280  != 31456000, то скрипты управления сходят с ума в попытке привести полисеры в соответствие с биллингом...


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/ca5793b2-cf53-46bb-ba01-8991e675c06c "simple-toolchain-1491579369553"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/18955329-ec54-4838-bb81-1dc1e51daa3d "simple-toolchain-1491579369553") deployed [simple-toolchain-1491579369553](https://github.com/telsdl/simple-toolchain-1491579369553/releases/tag/deploy-ibm-yp-us-south-TELSDL-dev-20170407-175011 "deploy-ibm-yp-us-south-TELSDL-dev-20170407-175011") to [dev](https://console.ng.bluemix.net/apps/1880e5fc-b366-4d1f-bfd3-838f34d1e1c2 "ibm:yp:us-south:TELSDL:dev"), including this commit


How to update the source file with translations?
I translate polish language for Foris using Weblate (https://hosted.weblate.org/projects/turris/) and new source from master branch commit 597a05d is not available. I mean the guest WiFi network


Note: solution's use of children
function increaseRankBy(n) {
  const rankedLists = document.querySelectorAll('.ranked-list')

  for (let i = 0, l = rankedLists.length; i < l; i++) {
    let children = rankedLists[i].children

    for (let j = 0, k = children.length; j < k; j++) {
      children[j].innerHTML = parseInt(children[j].innerHTML) + n
    }
  }
}


That's what I mean. The settings file in the M2_Home might have the download location configured elsewhere.

I'll give it a try, but suspect it won't fix the initial issue I reported.

Just wanted to pint that out.


Just browsing your repo for the first time...

Looks like some of the JUnit tests are expecting an exception to be thrown.  You're wrapping such code in a try-catch block, but if you're testing that an exception should occur, I think the test always succeeds, since it's caught.

Maybe signal in your tests that you expect an exception as follows. Here's an excerpt from the JUnit Javadoc for @Test():

**The Test annotation supports two optional parameters. The first, expected, declares that a test method should throw an exception. If it doesn't throw an exception or if it throws a different exception than the one declared, the test fails. For example, the following test succeeds:

    @Test(expected=IndexOutOfBoundsException.class) public void outOfBounds() {
       new ArrayList<Object>().get(1);
    }**


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/ca5793b2-cf53-46bb-ba01-8991e675c06c "simple-toolchain-1491579369553"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/18955329-ec54-4838-bb81-1dc1e51daa3d "simple-toolchain-1491579369553") deployed [simple-toolchain-1491579369553](https://github.com/telsdl/simple-toolchain-1491579369553/releases/tag/deploy-ibm-yp-us-south-TELSDL-dev-20170407-175153 "deploy-ibm-yp-us-south-TELSDL-dev-20170407-175153") to [dev](https://console.ng.bluemix.net/apps/85ab5feb-347f-4cd5-95e8-0f9ce5a0b855 "ibm:yp:us-south:TELSDL:dev"), including this commit


Right now you are logging empty objects with this console.log. How could you log the actual keys?


Also-note this solution for deepestChild()

function deepestChild() {
  let node = document.getElementById('grand-node')
  let nextNode = node.children[0]

  while (nextNode) {
    node = nextNode
    nextNode = node.children[0]
  }

  return node
}


Musiałem trochę pokomentować, bo nie mam bazy i po zatwierdzeniu formularza mnie przekierowało

![image](https://cloud.githubusercontent.com/assets/20582006/24812784/d095194c-1bcb-11e7-9ec2-2f1b04580574.png)


nit: typo in `corrsponding`, and instead of "you need to *add*", I would say "you need to *reference*"


Watch your whitespace.


TeamCity Code :: 1. Development :: DDK :: Feature [Build 240](http://mp-ci.centralus.cloudapp.azure.com/viewLog.html?buildId=19654&buildTypeId=Code_Development_Ddk_Feature) is now running


Nie znajdzie Ci użytkownika, bo jeżeli w bazie masz hasło zaszyfowane to ten warunek nie pójdzie.
Wyszukaj tylko po nazwie użytkownika, a potem tak jak to robisz niżej weryfikujesz hasło


TeamCity Code :: 1. Development :: DDK :: Feature [Build 240](http://mp-ci.centralus.cloudapp.azure.com/viewLog.html?buildId=19654&buildTypeId=Code_Development_Ddk_Feature) outcome was **SUCCESS**
Summary: Tests passed: 41 Build time: 00:01:04


Masz gdzieś kod gdzie tworzysz użytkowników?


Added wish list


Fixed in #2109 .


TeamCity Market :: INFRA :: Graphouse :: Graphouse on change [Build 6](https://teamcity.yandex-team.ru/viewLog.html?buildId=8326642&buildTypeId=MarketInfra_Graphouse_GraphouseOnChangeOpensource) outcome was **SUCCESS**
Summary: Tests passed: 11 Build time: 00:00:32


TeamCity Market :: INFRA :: Graphouse :: Graphouse on change [Build 8](https://teamcity.yandex-team.ru/viewLog.html?buildId=8326643&buildTypeId=MarketInfra_Graphouse_GraphouseOnChangeOpensource) outcome was **SUCCESS**
Summary: Tests passed: 11 Build time: 00:00:28


TeamCity Market :: INFRA :: Graphouse :: Graphouse on change [Build 7](https://teamcity.yandex-team.ru/viewLog.html?buildId=8326644&buildTypeId=MarketInfra_Graphouse_GraphouseOnChangeOpensource) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 10 Build time: 00:00:32
### Failed tests
```
ru.yandex.market.graphouse.MetricUtilTest.getLastLevelName: <no details avaliable>

```


actually, this should probably be private to prevent people from overriding... :/


Done.


can someone on here tell me, which of the actionMethod, needed to comment in order to get the output "We don't have any customers yet." please. Thanks in advance. Cheers..


Sure, I have no problem with that... I'll take care of it.


Was the intention to allow more fields to be selected in additional filters? I can only see "Follow" and "Only My", which isn't as useful as it could be. I was expecting to be able to filter by any field in the selected entity. How can that be accomplished? It would make this dashlet way more useful.


"small"


I think we can always fall back to the first theme from the list as the default


also made copyright year dynamic via php


I would strongly recommend decomposing this, to make it clearer exactly what it does (also maybe adding a Javadoc).  Ex.

/** {insert documentation here} */
private void initialize() {
  initializeTitle();
  initializeButton();
  ...etc...
}


for public functions in Java (as well as most private functions), I would recommend using Javadoc format instead.  I.e.:

/** Update function for conversion changes. */

I would also advise


rename to  previewUrl


Shouldn't have this went through a PR ?

It doesn't seem to be used anywhere anyway


for group projects, it is often helpful to add a section to the TODO indicating whose responsibility it is.  At Google, for example, this would be `TODO(khalilsg): Implement....`


Excellent, bwana Victor...


should this be ```thead th```?


as far as I know, `rake release` will do this automatically so there is no point of having such task.


You figured it out!
Nice!