[R/FDAClassifPreprocWrapper.R:12:29:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAClassifPreprocWrapper.R#L12) *style:* **Commas should always have a space after.**
```r
  requirePackages("stringi",default.method = "load")
                            ^
```
[R/FDAClassifPreprocWrapper.R:16:5:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAClassifPreprocWrapper.R#L16) *style:* **Variable or function name should be dotted.case.**
```r
    taskTs = makeFDAClassifTask(data = data, target = target, positive = args$positive)
    ^~~~~~
```
[R/FDAClassifPreprocWrapper.R:17:5:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAClassifPreprocWrapper.R#L17) *style:* **Variable or function name should be dotted.case.**
```r
    taskFa = convertFDATaskToNormalTask(task = taskTs)
    ^~~~~~
```
[R/FDA_feal_twoStepAIC.R:1:1:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDA_feal_twoStepAIC.R#L1) *style:* **Variable or function name should be dotted.case.**
```r
MAGICNumber4TWOSTEPAIC = 163
^~~~~~~~~~~~~~~~~~~~~~
```
[R/FDA_feal_twoStepAIC.R:21:35:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDA_feal_twoStepAIC.R#L21) *style:* **Commas should always have a space after.**
```r
  filename = paste("steplm1", "-",format(Sys.time(), "%b%d%H%M%S"), ".RData" , sep="")
                                  ^
```
[R/FDA_feal_twoStepAIC.R:21:78:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDA_feal_twoStepAIC.R#L21) *style:* **Commas should never have a space before.**
```r
  filename = paste("steplm1", "-",format(Sys.time(), "%b%d%H%M%S"), ".RData" , sep="")
                                                                            ~^
```
[R/FDA_feal_twoStepAIC.R:21:83:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDA_feal_twoStepAIC.R#L21) *style:* **Put spaces around all infix operators (except exponentiation).**
```r
  filename = paste("steplm1", "-",format(Sys.time(), "%b%d%H%M%S"), ".RData" , sep="")
                                                                                ~^~
```
[R/FDA_feal_twoStepAIC.R:35:35:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDA_feal_twoStepAIC.R#L35) *style:* **Commas should always have a space after.**
```r
  filename = paste("steplm2", "-",format(Sys.time(), "%b%d%H%M%S"), ".RData" , sep="")
                                  ^
```
[R/FDA_feal_twoStepAIC.R:35:78:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDA_feal_twoStepAIC.R#L35) *style:* **Commas should never have a space before.**
```r
  filename = paste("steplm2", "-",format(Sys.time(), "%b%d%H%M%S"), ".RData" , sep="")
                                                                            ~^
```
[R/FDA_feal_twoStepAIC.R:35:83:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDA_feal_twoStepAIC.R#L35) *style:* **Put spaces around all infix operators (except exponentiation).**
```r
  filename = paste("steplm2", "-",format(Sys.time(), "%b%d%H%M%S"), ".RData" , sep="")
                                                                                ~^~
```
[R/FDAconvertTask.R:34:5:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAconvertTask.R#L34) *style:* **Variable or function name should be dotted.case.**
```r
    modelSh = do.call(getFDAShapeletFeatures, new.args)
    ^~~~~~~
```
[R/FDAconvertTask.R:88:40:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAconvertTask.R#L88) *style:* **Only use double-quotes.**
```r
  colnames(newdata) = c(target, paste0('V', 1:(ncol(newdata) - 1) ))
                                       ^~~
```
[R/FDAconvertTask.R:107:40:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAconvertTask.R#L107) *style:* **Only use double-quotes.**
```r
  colnames(newdata) = c(target, paste0('V', 1:(ncol(newdata) - 1) ))
                                       ^~~
```
[R/FDAfeatures_FDboost.R:24:111:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_FDboost.R#L24) *style:* **Commas should never have a space before.**
```r
getFDAFDboostFeatures = function(data, target, have.target = TRUE, include.target = FALSE, bsignal.knots =10L ,bsignal.df = 3L) {
                                                                                ~^
```
[R/FDAfeatures_FDboost.R:24:112:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_FDboost.R#L24) *style:* **Commas should always have a space after.**
```r
getFDAFDboostFeatures = function(data, target, have.target = TRUE, include.target = FALSE, bsignal.knots =10L ,bsignal.df = 3L) {
                                                                                ^
```
[R/FDAfeatures_FDboost.R:47:52:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_FDboost.R#L47) *warning:* **Avoid 1:ncol(...) expressions, use seq_len.**
```r
  blrn = FDboost::bsignal(x = as.matrix(data), s = 1:ncol(data), knots = bsignal.knots , degree = bsignal.df)
                                                   ^
```
[R/FDAfeatures_FDboost.R:47:88:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_FDboost.R#L47) *style:* **Commas should never have a space before.**
```r
  blrn = FDboost::bsignal(x = as.matrix(data), s = 1:ncol(data), knots = bsignal.knots , degree = bsignal.df)
                                                                                ~^
```
[R/FDAfeatures_FDboost.R:48:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_FDboost.R#L48) *style:* **Variable or function name should be dotted.case.**
```r
  features_bsignal = mboost::extract(object = blrn, what = "design")  # get the design matrix from base learner
  ^~~~~~~~~~~~~~~~
```
[R/FDAfeatures_FDboost.R:49:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_FDboost.R#L49) *style:* **Variable or function name should be dotted.case.**
```r
  d_fdboost = as.data.frame(features_bsignal)
  ^~~~~~~~~
```
[R/FDAfeatures_fourier.R:44:27:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_fourier.R#L44) *style:* **Commas should always have a space after.**
```r
  ffttrafo = t(apply(data,1, fft))
                          ^
```
[R/FDAfeatures_fourier.R:48:23:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_fourier.R#L48) *style:* **Variable or function name should be dotted.case.**
```r
         amplitude = {fftPA = getFourierAmplitude(fourier.comp = ffttrafo)},
                      ^~~~~
```
[R/FDAfeatures_fourier.R:49:19:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_fourier.R#L49) *style:* **Variable or function name should be dotted.case.**
```r
         phase = {fftPA = getFourierPhase(fourier.comp = ffttrafo)}
                  ^~~~~
```
[R/FDAfeatures_fourier.R:53:5:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_fourier.R#L53) *style:* **Variable or function name should be dotted.case.**
```r
    fftPA = as.data.frame(matrix(fftPA, nrow = 1))
    ^~~~~
```
[R/FDAfeatures_fourier.R:55:5:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_fourier.R#L55) *style:* **Variable or function name should be dotted.case.**
```r
    fftPA = as.data.frame(fftPA)
    ^~~~~
```
[R/FDAfeatures_fpca.R:40:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_fpca.R#L40) *style:* **Variable or function name should be dotted.case.**
```r
  features_fpca = rst$scores
  ^~~~~~~~~~~~~
```
[R/FDAfeatures_fpca.R:41:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_fpca.R#L41) *style:* **Variable or function name should be dotted.case.**
```r
  d_fpca = as.data.frame(features_fpca)
  ^~~~~~
```
[R/FDAfeatures_fpca.R:42:30:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_fpca.R#L42) *style:* **Commas should always have a space after.**
```r
  names(d_fpca) = paste0("V",1:ncol(d_fpca))
                             ^
```
[R/FDAfeatures_fpca.R:42:30:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_fpca.R#L42) *warning:* **Avoid 1:ncol(...) expressions, use seq_len.**
```r
  names(d_fpca) = paste0("V",1:ncol(d_fpca))
                             ^
```
[R/FDAfeatures_multiResNaive.R:46:6:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_multiResNaive.R#L46) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  for(fdn in names(fd.features)){
     ^
```
[R/FDAfeatures_multiResNaive.R:71:36:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_multiResNaive.R#L71) *style:* **Trailing whitespace is superfluous.**
```r
  feat.list = vector("list", n.obs)
                                   ^~
```
[R/FDAfeatures_wavelets.R:39:5:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_wavelets.R#L39) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(inherits(data, "matrix"))
    ^
```
[R/FDAfeatures_wavelets.R:51:18:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_wavelets.R#L51) *style:* **Commas should always have a space after.**
```r
    a = t(data[i,])
                 ^
```
[R/FDAfeatures_wavelets.R:53:42:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/FDAfeatures_wavelets.R#L53) *style:* **Commas should always have a space after.**
```r
    wtdata = rbind(wtdata, unlist(c(wt@W,wt@V[[wt@level]])))
                                         ^
```
[R/RLearner_FDAclassif_kernel.R:30:83:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/RLearner_FDAclassif_kernel.R#L30) *style:* **Commas should always have a space after.**
```r
  learned.model = fda.usc::classif.kernel(group = glearn, fdataobj = data.fdclass,...)
                                                                                ^
```
[R/RLearner_FDAclassif_np.R:31:79:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/RLearner_FDAclassif_np.R#L31) *style:* **Commas should always have a space after.**
```r
  learned.model = fda.usc::classif.np(group = glearn, fdataobj = data.fdclass,...)
                                                                              ^
```
[R/RLearner_FDAregr_fgam.R:19:18:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/RLearner_FDAregr_fgam.R#L19) *warning:* **Unneded concatenation of a constant. Remove the "c" call.**
```r
    properties = c("numerics"),
                 ^
```
[R/RLearner_FDAregr_fgam.R:49:20:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/RLearner_FDAregr_fgam.R#L49) *style:* **Put spaces around all infix operators (except exponentiation).**
```r
    mat.list[[fdn]]=  as.matrix(d[, tdesc$fd.features[[fdn]], drop = FALSE])
                  ~^
```
[R/RLearner_FDAregr_fgam.R:70:6:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/RLearner_FDAregr_fgam.R#L70) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  for(i in 1:num4channel){
     ^
```
[R/RLearner_FDAregr_fgam.R:71:34:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/RLearner_FDAregr_fgam.R#L71) *style:* **Put spaces around all infix operators (except exponentiation).**
```r
    list4mat[[name4channel[[i]]]]=  as.matrix(subset(df, select = channel.list[[i]]))
                                ~^
```
[R/RLearner_FDAregr_fgam.R:78:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/RLearner_FDAregr_fgam.R#L78) *style:* **Variable or function name should be dotted.case.**
```r
  mextra_para  = list(...)
  ^~~~~~~~~~~
```
[R/RLearner_FDAregr_fgam.R:81:67:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/R/RLearner_FDAregr_fgam.R#L81) *style:* **Only use double-quotes.**
```r
  pred = predict(.model$learner.model, newdata = list4mat, type = 'response')
                                                                  ^~~~~~~~~~
```
[tests/testthat/test_FDA_FPCA.R:5:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_FPCA.R#L5) *style:* **Variable or function name should be dotted.case.**
```r
  taskTs = makeFDAClassifTask(data = gp, target = "X1", positive = "1")
  ^~~~~~
```
[tests/testthat/test_FDA_FPCA.R:6:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_FPCA.R#L6) *style:* **Variable or function name should be dotted.case.**
```r
  refData = getTaskData(taskTs, target.extra = TRUE)
  ^~~~~~~
```
[tests/testthat/test_FDA_FPCA.R:9:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_FPCA.R#L9) *style:* **Variable or function name should be dotted.case.**
```r
  f_df = getFDAFPCAFeatures(data = refData$data, target = "X1", have.target = TRUE, include.target = FALSE)
  ^~~~
```
[tests/testthat/test_FDA_Fourier.R:6:61:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Fourier.R#L6) *style:* **Put spaces around all infix operators (except exponentiation).**
```r
  gp = data.frame(v1 = 1:5, v2 = 2:6, v3 = 3:7, v4 = 4:8, X1= as.factor(c(-1,1,1,-1, 1)))
                                                           ~^
```
[tests/testthat/test_FDA_Fourier.R:6:78:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Fourier.R#L6) *style:* **Commas should always have a space after.**
```r
  gp = data.frame(v1 = 1:5, v2 = 2:6, v3 = 3:7, v4 = 4:8, X1= as.factor(c(-1,1,1,-1, 1)))
                                                                             ^
```
[tests/testthat/test_FDA_Fourier.R:6:80:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Fourier.R#L6) *style:* **Commas should always have a space after.**
```r
  gp = data.frame(v1 = 1:5, v2 = 2:6, v3 = 3:7, v4 = 4:8, X1= as.factor(c(-1,1,1,-1, 1)))
                                                                               ^
```
[tests/testthat/test_FDA_Fourier.R:6:82:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Fourier.R#L6) *style:* **Commas should always have a space after.**
```r
  gp = data.frame(v1 = 1:5, v2 = 2:6, v3 = 3:7, v4 = 4:8, X1= as.factor(c(-1,1,1,-1, 1)))
                                                                                ^
```
[tests/testthat/test_FDA_Fourier.R:8:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Fourier.R#L8) *style:* **Variable or function name should be dotted.case.**
```r
  taskTs = makeFDAClassifTask(data = gp, target = "X1", positive = "1")
  ^~~~~~
```
[tests/testthat/test_FDA_Fourier.R:9:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Fourier.R#L9) *style:* **Variable or function name should be dotted.case.**
```r
  refData = getTaskData(taskTs, target.extra = TRUE)
  ^~~~~~~
```
[tests/testthat/test_FDA_Fourier.R:11:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Fourier.R#L11) *style:* **Variable or function name should be dotted.case.**
```r
  taskFa = convertFDATaskToNormalTask(task = taskTs, method = "fourier", pars = list(fft.coeff = "amplitude"))
  ^~~~~~
```
[tests/testthat/test_FDA_Fourier.R:12:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Fourier.R#L12) *style:* **Variable or function name should be dotted.case.**
```r
  faData = getTaskData(taskFa, target.extra = TRUE)
  ^~~~~~
```
[tests/testthat/test_FDA_Fourier.R:13:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Fourier.R#L13) *style:* **Variable or function name should be dotted.case.**
```r
  taskFp = convertFDATaskToNormalTask(task = taskTs, method = "fourier", pars = list(fft.coeff = "phase"))
  ^~~~~~
```
[tests/testthat/test_FDA_Fourier.R:14:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Fourier.R#L14) *style:* **Variable or function name should be dotted.case.**
```r
  fpData = getTaskData(taskFp, target.extra = TRUE)
  ^~~~~~
```
[tests/testthat/test_FDA_Fourier.R:20:35:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Fourier.R#L20) *style:* **Put spaces around all infix operators (except exponentiation).**
```r
  expect_true(all(fpData$data < pi/2 & fpData$data > -pi/2))
                                 ~^~
```
[tests/testthat/test_FDA_Fourier.R:20:57:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Fourier.R#L20) *style:* **Put spaces around all infix operators (except exponentiation).**
```r
  expect_true(all(fpData$data < pi/2 & fpData$data > -pi/2))
                                                       ~^~
```
[tests/testthat/test_FDA_PreprocWrapper.R:4:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_PreprocWrapper.R#L4) *style:* **Variable or function name should be dotted.case.**
```r
  taskFa = convertFDATaskToNormalTask(task = gunpoint.task, method = "fourier",
  ^~~~~~
```
[tests/testthat/test_FDA_PreprocWrapper.R:6:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_PreprocWrapper.R#L6) *style:* **Variable or function name should be dotted.case.**
```r
  taskFp = convertFDATaskToNormalTask(task = gunpoint.task, method = "fourier",
  ^~~~~~
```
[tests/testthat/test_FDA_PreprocWrapper.R:11:60:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_PreprocWrapper.R#L11) *style:* **Only use double-quotes.**
```r
  lrn = makeFDAClassifPreprocWrapper(learner = makeLearner('classif.ranger'))
                                                           ^~~~~~~~~~~~~~~~
```
[tests/testthat/test_FDA_Wavelets.R:6:22:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Wavelets.R#L6) *style:* **Put spaces around all infix operators (except exponentiation).**
```r
  gp = data.frame( X1= as.factor(c(-1,1,1,-1, 1)) ,v1 = 1:5, v2 = 12:16, v3 = 3:7, v4 = 4:8)
                    ~^
```
[tests/testthat/test_FDA_Wavelets.R:6:39:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Wavelets.R#L6) *style:* **Commas should always have a space after.**
```r
  gp = data.frame( X1= as.factor(c(-1,1,1,-1, 1)) ,v1 = 1:5, v2 = 12:16, v3 = 3:7, v4 = 4:8)
                                      ^
```
[tests/testthat/test_FDA_Wavelets.R:6:41:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Wavelets.R#L6) *style:* **Commas should always have a space after.**
```r
  gp = data.frame( X1= as.factor(c(-1,1,1,-1, 1)) ,v1 = 1:5, v2 = 12:16, v3 = 3:7, v4 = 4:8)
                                        ^
```
[tests/testthat/test_FDA_Wavelets.R:6:43:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Wavelets.R#L6) *style:* **Commas should always have a space after.**
```r
  gp = data.frame( X1= as.factor(c(-1,1,1,-1, 1)) ,v1 = 1:5, v2 = 12:16, v3 = 3:7, v4 = 4:8)
                                          ^
```
[tests/testthat/test_FDA_Wavelets.R:6:51:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Wavelets.R#L6) *style:* **Commas should never have a space before.**
```r
  gp = data.frame( X1= as.factor(c(-1,1,1,-1, 1)) ,v1 = 1:5, v2 = 12:16, v3 = 3:7, v4 = 4:8)
                                                 ~^
```
[tests/testthat/test_FDA_Wavelets.R:6:52:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Wavelets.R#L6) *style:* **Commas should always have a space after.**
```r
  gp = data.frame( X1= as.factor(c(-1,1,1,-1, 1)) ,v1 = 1:5, v2 = 12:16, v3 = 3:7, v4 = 4:8)
                                                   ^
```
[tests/testthat/test_FDA_Wavelets.R:8:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Wavelets.R#L8) *style:* **Variable or function name should be dotted.case.**
```r
  taskTs = makeFDAClassifTask(data = gp, target = "X1", positive = "1")
  ^~~~~~
```
[tests/testthat/test_FDA_Wavelets.R:9:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Wavelets.R#L9) *style:* **Variable or function name should be dotted.case.**
```r
  taskW = convertFDATaskToNormalTask(task = taskTs, method = "wavelets", pars = list(filter = "haar"))
  ^~~~~
```
[tests/testthat/test_FDA_Wavelets.R:10:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Wavelets.R#L10) *style:* **Variable or function name should be dotted.case.**
```r
  wData = getTaskData(taskW, target.extra = TRUE)
  ^~~~~
```
[tests/testthat/test_FDA_Wavelets.R:12:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Wavelets.R#L12) *style:* **Variable or function name should be dotted.case.**
```r
  taskWb = convertFDATaskToNormalTask(task = taskTs, method = "wavelets", pars = list( filter = "d4", boundary = "reflection"))
  ^~~~~~
```
[tests/testthat/test_FDA_Wavelets.R:13:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Wavelets.R#L13) *style:* **Variable or function name should be dotted.case.**
```r
  wbData = getTaskData(taskWb, target.extra = TRUE)
  ^~~~~~
```
[tests/testthat/test_FDA_Wavelets.R:19:17:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Wavelets.R#L19) *style:* **Commas should always have a space after.**
```r
    a = t(raw[i,])
                ^
```
[tests/testthat/test_FDA_Wavelets.R:22:34:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Wavelets.R#L22) *style:* **Commas should always have a space after.**
```r
    bb = rbind(bb, unlist(c(wt@W,wt@V[[wt@level]])))
                                 ^
```
[tests/testthat/test_FDA_Wavelets.R:27:17:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Wavelets.R#L27) *style:* **Commas should always have a space after.**
```r
    a = t(raw[i,])
                ^
```
[tests/testthat/test_FDA_Wavelets.R:29:34:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_Wavelets.R#L29) *style:* **Commas should always have a space after.**
```r
    dd = rbind(dd, unlist(c(wt@W,wt@V[[wt@level]])))
                                 ^
```
[tests/testthat/test_FDA_base_nonFDALrnOnFDATask.R:5:10:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_base_nonFDALrnOnFDATask.R#L5) *style:* **Commas should always have a space after.**
```r
  data[1,1] = NA
         ^
```
[tests/testthat/test_FDA_classif_glm.R:13:18:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_classif_glm.R#L13) *style:* **Put spaces around all infix operators (except exponentiation).**
```r
  dat = list("df"=dataf,"x"=mlearn)
                ~^~
```
[tests/testthat/test_FDA_classif_glm.R:13:25:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_classif_glm.R#L13) *style:* **Commas should always have a space after.**
```r
  dat = list("df"=dataf,"x"=mlearn)
                        ^
```
[tests/testthat/test_FDA_classif_glm.R:13:28:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_classif_glm.R#L13) *style:* **Put spaces around all infix operators (except exponentiation).**
```r
  dat = list("df"=dataf,"x"=mlearn)
                          ~^~
```
[tests/testthat/test_FDA_classif_glm.R:19:20:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_classif_glm.R#L19) *style:* **Put spaces around all infix operators (except exponentiation).**
```r
  newdat = list("x"=mtest)
                  ~^~
```
[tests/testthat/test_FDA_classif_glm.R:23:7:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_classif_glm.R#L23) *style:* **Commas should always have a space after.**
```r
  ph[,"label"] = glearn
      ^
```
[tests/testthat/test_FDA_classif_np.R:21:7:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_classif_np.R#L21) *style:* **Commas should always have a space after.**
```r
  ph[,"label"] = glearn
      ^
```
[tests/testthat/test_FDA_classif_shapelets.R:12:54:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_classif_shapelets.R#L12) *style:* **Commas should always have a space after.**
```r
  m = shapeletLib::learnShapeletModel(data = gp[1:50,-1], label = as.factor(gp[1:50,1]))
                                                     ^
```
[tests/testthat/test_FDA_classif_shapelets.R:12:85:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_classif_shapelets.R#L12) *style:* **Commas should always have a space after.**
```r
  m = shapeletLib::learnShapeletModel(data = gp[1:50,-1], label = as.factor(gp[1:50,1]))
                                                                                ^
```
[tests/testthat/test_FDA_classif_shapelets.R:13:58:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_classif_shapelets.R#L13) *style:* **Commas should always have a space after.**
```r
  p1 = predict(object = m, newdata = as.matrix(gp[51:200,-1]))
                                                         ^
```
[tests/testthat/test_FDA_classif_shapelets.R:14:14:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_classif_shapelets.R#L14) *style:* **Commas should always have a space after.**
```r
  levs = c(2,1)
             ^
```
[tests/testthat/test_FDA_featExtract_FDboost.R:4:79:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featExtract_FDboost.R#L4) *style:* **Commas should always have a space after.**
```r
  gp = data.frame(v1 = 1:5, v2 = 2:6, v3 = 3:7, v4 = 4:8, X1 = as.factor(c(-1,1,1,-1, 1)))
                                                                              ^
```
[tests/testthat/test_FDA_featExtract_FDboost.R:4:81:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featExtract_FDboost.R#L4) *style:* **Commas should always have a space after.**
```r
  gp = data.frame(v1 = 1:5, v2 = 2:6, v3 = 3:7, v4 = 4:8, X1 = as.factor(c(-1,1,1,-1, 1)))
                                                                                ^
```
[tests/testthat/test_FDA_featExtract_FDboost.R:4:83:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featExtract_FDboost.R#L4) *style:* **Commas should always have a space after.**
```r
  gp = data.frame(v1 = 1:5, v2 = 2:6, v3 = 3:7, v4 = 4:8, X1 = as.factor(c(-1,1,1,-1, 1)))
                                                                                ^
```
[tests/testthat/test_FDA_featExtract_FDboost.R:5:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featExtract_FDboost.R#L5) *style:* **Variable or function name should be dotted.case.**
```r
  taskTs = makeFDAClassifTask(data = gp, target = "X1", positive = "1")
  ^~~~~~
```
[tests/testthat/test_FDA_featExtract_FDboost.R:6:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featExtract_FDboost.R#L6) *style:* **Variable or function name should be dotted.case.**
```r
  refData = getTaskData(taskTs, target.extra = TRUE)
  ^~~~~~~
```
[tests/testthat/test_FDA_featExtract_FDboost.R:11:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featExtract_FDboost.R#L11) *style:* **Variable or function name should be dotted.case.**
```r
  f_df = getFDAFDboostFeatures(data = refData$data, target = "X1", have.target = TRUE,
  ^~~~
```
[tests/testthat/test_FDA_featextraction_base.R:5:118:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featextraction_base.R#L5) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  d = extractFDAFeatures(data = gp$data, target = getTaskTargetNames(gunpoint.task), method = "wavelets", args = list( filter = "d4", boundary = "reflection"))
                                                                                ^
```
[tests/testthat/test_FDA_featextraction_base.R:21:127:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featextraction_base.R#L21) *style:* **Commas should never have a space before.**
```r
  d = extractMultiFDAFeatures(data = fuel$data, target = getTaskTargetNames(fuelsubset.task), fd.features = tdesc$fd.features , method = "wavelets", args = list( filter = "d4", boundary = "reflection"))
                                                                                ~^
```
[tests/testthat/test_FDA_featextraction_base.R:23:127:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featextraction_base.R#L23) *style:* **Commas should never have a space before.**
```r
  d = extractMultiFDAFeatures(data = fuel$data, target = getTaskTargetNames(fuelsubset.task), fd.features = tdesc$fd.features , method = "fourier", args = list())
                                                                                ~^
```
[tests/testthat/test_FDA_featextraction_base.R:25:127:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featextraction_base.R#L25) *style:* **Commas should never have a space before.**
```r
  d = extractMultiFDAFeatures(data = fuel$data, target = getTaskTargetNames(fuelsubset.task), fd.features = tdesc$fd.features , method = "multiRes", args = list())
                                                                                ~^
```
[tests/testthat/test_FDA_featextraction_base.R:27:127:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featextraction_base.R#L27) *style:* **Commas should never have a space before.**
```r
  d = extractMultiFDAFeatures(data = fuel$data, target = getTaskTargetNames(fuelsubset.task), fd.features = tdesc$fd.features , method = "bsignal", args = list())
                                                                                ~^
```
[tests/testthat/test_FDA_featextraction_base.R:29:127:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featextraction_base.R#L29) *style:* **Commas should never have a space before.**
```r
  d = extractMultiFDAFeatures(data = fuel$data, target = getTaskTargetNames(fuelsubset.task), fd.features = tdesc$fd.features , method = "fpca", args = list())
                                                                                ~^
```
[tests/testthat/test_FDA_featsel_twoStepAIC.R:3:1:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featsel_twoStepAIC.R#L3) *style:* **Variable or function name should be functionCamel.case.**
```r
makeData_art_10 = function(n){
^~~~~~~~~~~~~~~
```
[tests/testthat/test_FDA_featsel_twoStepAIC.R:16:62:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featsel_twoStepAIC.R#L16) *style:* **Trailing whitespace is superfluous.**
```r
  l4c$y = 3 * l4c$x2 - 4 * l4c$x8 + 5 * l4c$x9 + 3 * rnorm(n)
                                                             ^
```
[tests/testthat/test_FDA_featsel_twoStepAIC.R:23:1:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featsel_twoStepAIC.R#L23) *style:* **Variable or function name should be functionCamel.case.**
```r
makeData_art_10_2 = function(n){
^~~~~~~~~~~~~~~~~
```
[tests/testthat/test_FDA_featsel_twoStepAIC.R:36:98:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featsel_twoStepAIC.R#L36) *style:* **Trailing whitespace is superfluous.**
```r
  l4c$y = 3 * (l4c$x2 * l4c$x3 ) * - 4 * (l4c$x8 * l4c$x7) + 5 * (l4c$x9 * l4c$x1) + 3 * rnorm(n)
                                                                                ^
```
[tests/testthat/test_FDA_featsel_twoStepAIC.R:47:78:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featsel_twoStepAIC.R#L47) *style:* **Trailing whitespace is superfluous.**
```r
  mmodel = selectForward2Step(d = regr.train, target = "medv", muffle = TRUE)
                                                                             ^
```
[tests/testthat/test_FDA_featsel_twoStepAIC.R:52:33:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featsel_twoStepAIC.R#L52) *style:* **Commas should always have a space after.**
```r
test_that("regr_twoStepAIC_art",{
                                ^
```
[tests/testthat/test_FDA_featsel_twoStepAIC.R:54:24:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featsel_twoStepAIC.R#L54) *style:* **Commas should always have a space after.**
```r
  regr.train = df[1:40,] # 4 times the feature number
                       ^
```
[tests/testthat/test_FDA_featsel_twoStepAIC.R:55:27:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featsel_twoStepAIC.R#L55) *style:* **Commas should always have a space after.**
```r
  regr.test = df[501:1000,]
                          ^
```
[tests/testthat/test_FDA_featsel_twoStepAIC.R:56:75:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featsel_twoStepAIC.R#L56) *style:* **Trailing whitespace is superfluous.**
```r
  mmodel = selectForward2Step(d = regr.train, target = "y", muffle = TRUE)
                                                                          ^
```
[tests/testthat/test_FDA_featsel_twoStepAIC.R:60:35:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featsel_twoStepAIC.R#L60) *style:* **Commas should always have a space after.**
```r
test_that("regr_twoStepAIC_art_2",{
                                  ^
```
[tests/testthat/test_FDA_featsel_twoStepAIC.R:62:24:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featsel_twoStepAIC.R#L62) *style:* **Commas should always have a space after.**
```r
  regr.train = df[1:40,]
                       ^
```
[tests/testthat/test_FDA_featsel_twoStepAIC.R:63:27:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featsel_twoStepAIC.R#L63) *style:* **Commas should always have a space after.**
```r
  regr.test = df[501:1000,]
                          ^
```
[tests/testthat/test_FDA_featsel_twoStepAIC.R:64:75:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featsel_twoStepAIC.R#L64) *style:* **Trailing whitespace is superfluous.**
```r
  mmodel = selectForward2Step(d = regr.train, target = "y", muffle = TRUE)
                                                                          ^
```
[tests/testthat/test_FDA_featsel_twoStepAIC.R:66:1:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_featsel_twoStepAIC.R#L66) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test_FDA_multiResNaive.R:6:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_multiResNaive.R#L6) *style:* **Variable or function name should be dotted.case.**
```r
  TL  = 200 # length of each time serie instance
  ^~
```
[tests/testthat/test_FDA_multiResNaive.R:7:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_multiResNaive.R#L7) *style:* **Variable or function name should be dotted.case.**
```r
  Ts = replicate(I, rnorm(TL))
  ^~
```
[tests/testthat/test_FDA_multiResNaive.R:9:36:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_multiResNaive.R#L9) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  ngp = extractFDAMultiResFeatures (data = gp, curve.lens = c(100, 100), res.level = 3, shift = 0.5)
                                   ^
```
[tests/testthat/test_FDA_multiResNaive.R:17:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_multiResNaive.R#L17) *style:* **Variable or function name should be dotted.case.**
```r
  TL  = 200 # length of each time serie instance
  ^~
```
[tests/testthat/test_FDA_multiResNaive.R:18:3:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_multiResNaive.R#L18) *style:* **Variable or function name should be dotted.case.**
```r
  Ts = replicate(I, rnorm(TL))
  ^~
```
[tests/testthat/test_FDA_multiResNaive.R:28:41:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_multiResNaive.R#L28) *style:* **Put spaces around all infix operators (except exponentiation).**
```r
  dfn = getMultiFDAMultiResFeatures(data= df, fd.features = fdf)
                                       ~^
```
[tests/testthat/test_FDA_multiResNaive.R:37:40:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_multiResNaive.R#L37) *style:* **Put spaces around all infix operators (except exponentiation).**
```r
  dfn = extractFDAMultiResFeatures(data= df, curve.lens = rep(180,2))
                                      ~^
```
[tests/testthat/test_FDA_multiResNaive.R:37:67:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_FDA_multiResNaive.R#L37) *style:* **Commas should always have a space after.**
```r
  dfn = extractFDAMultiResFeatures(data= df, curve.lens = rep(180,2))
                                                                  ^
```
[tests/testthat/test_Fda_convert_task.R:6:38:](https://github.com/mlr-org/mlr/blob/ef79901be6dd773157d608edd0f1a68459de4171/tests/testthat/test_Fda_convert_task.R#L6) *style:* **Put spaces around all infix operators (except exponentiation).**
```r
  expect_true(nrow(getTaskData(task))== dim(fuel$data)[1])
                                    ~^
```


Yea, I guess it's geo...let's close this. I wrote an easy fix for the certificate pinning in the pull request and am going to use that.


Here is the code from Bootstrap's dropdown.js when attaching the `ontouchstart` listeners where they check to see if the dropdown is in a navbar (i.e. `<b-nav-item-dropdown>` in bootstrap-vue):

```js
  const Selector = {
    DATA_TOGGLE   : '[data-toggle="dropdown"]',
    FORM_CHILD    : '.dropdown form',
    MENU          : '.dropdown-menu',
    NAVBAR_NAV    : '.navbar-nav',
    VISIBLE_ITEMS : '.dropdown-menu .dropdown-item:not(.disabled)'
  }
  // ... snip ...
  if ('ontouchstart' in document.documentElement &&
     !$(parent).closest(Selector.NAVBAR_NAV).length) {
    $('body').children().on('mouseover', null, $.noop)
  }
```

When removing the listeners, they don't bother checking if the dropdown is inside a navbar.

Here is a bit more detail on it:
**previous commit**: https://github.com/twbs/bootstrap/commit/6d64afe508bfd0bcfb5831a9a4708cef4ad88334
**latest commit**: https://github.com/twbs/bootstrap/commit/1f37c536b2691e4a98310982f9b58ede506f11d8


Mistrzostwo!


Potwierdzam. Mistrzostwo.


@deeky666 if you have issues with Satis I'd say try https://packagist.com - but if the issue is self-signed certs, that's probably not gonna help as we don't allow it there either. In this day and age of easy letsencrypt certs, there's really no excuse IMO to use self-signed stuff.


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.282.a113a24ce02c2e647283fa920d2ec3d66ecd7b0e](http://build.palaso.org/viewLog.html?buildId=88412&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3576, ignored: 128 Build time: 00:03:36


@inoriy not an issue. The '^' only matches root.


@Wonderfall tried what? I tried building the latest Dockerfile and also older versions still running on Apline:edge, those raise different errors for nginx needing different libcrypto and libssl versions than available. I'll try to debug that and see if i can get it to work.


TeamCity libpalaso :: palaso-precise64-libpalaso-3.1 Continuous [Build 3.1.236.a113a24ce02c2e647283fa920d2ec3d66ecd7b0e](http://build.palaso.org/viewLog.html?buildId=88414&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3554, ignored: 111 Build time: 00:05:44


Officially RIP.


Ich hab Bruno schon gebeten, sich der Sache anzunehmen, weil ich eben auch keine schnelle Lösung hatte…

Von: meggima [mailto:notifications@github.com]
Gesendet: Dienstag, 25. April 2017 20:21
An: eonum/medcodelogic-frontend <medcodelogic-frontend@noreply.github.com>
Cc: sserena <serena@increations.eu>; Mention <mention@noreply.github.com>
Betreff: Re: [eonum/medcodelogic-frontend] Logo Link (50d6877)

Das funktioniert scheinbar nicht so gut. Wenn man von der Startseite aus einfach auf das Logo klickt, dann ändert die URL auf /sprache/katalog/version und das root-Element verschwindet. Nach zwei weiteren Klicks aus diesem Zustand auf das Logo erscheinen Fehler in der Konsole.

Das Problem ist, dass die MainComponentnicht auf das root-Element weiterleitet. Denn die Parameter der Route ändern ihren Wert ja nicht. Entsprechend wird das subscribe in Zeile 48 von MainComponent nicht ausgeführt. Ich habe leider keine schnelle Lösung gefunden. @sserena <https://github.com/sserena>  oder @brnsnt <https://github.com/brnsnt> : Seht ihr da vielleicht eine gute Lösung für dieses Problem?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <https://github.com/eonum/medcodelogic-frontend/commit/50d68777bf6a3b0bb46dda64887757879217f17d#commitcomment-21901680> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AFxk6v_nstgZiEBRyA2JB_nrgdy8IDiIks5rzjmegaJpZM4NH30y> .  <https://github.com/notifications/beacon/AFxk6hN3mQD3M5xy2ccBO63gtf2f65B9ks5rzjmegaJpZM4NH30y.gif>


@Seldaek I am using Satis because it is about providing company internal repositories. Those are not reachable via public IP so letsencrypt does not help here. It's all about private repositories.


looks like misaligned YAML...


# Pichost
Photo sharing website created using NodeJs, Express and MongoDB

## Current features:
 - Users can sign up, upload images and view profiles

## To be added:
 - Users should be able to send and accept friend requests
 - A news feed of latest photos (both personal and from friends)

Note: Future deployment on OpenStack (for educational purposes)


@fadenb, @grahamc, I don't understand the purpose of this modification. The `up` and `down` commands were embedded in-place into the up and down scripts, i.e. these commands were never executed as separate scripts. Now, after this change, they are written into separate files but then `source`d. This seems like the exact same thing we had before, only more complicated.

Am I missing something?


I can confirm that removing the port allows the connection to go through.

I also get this error:

``

2017-04-25 13:49:16,007: ERROR: Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/sanic/router.py", line 288, in get
    request.headers.get("Host", ''))
  File "/usr/local/lib/python3.6/site-packages/sanic/router.py", line 333, in _get
    raise NotFound('Requested URL {} not found'.format(url))
sanic.exceptions.NotFound: Requested URL 149.56.242.61:5000/favicon.ico not found

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/sanic/app.py", line 382, in handle_request
    handler, args, kwargs = self.router.get(request)
  File "/usr/local/lib/python3.6/site-packages/sanic/router.py", line 291, in get
    return self._get(request.url, request.method, '')
  File "/usr/local/lib/python3.6/site-packages/sanic/router.py", line 333, in _get
    raise NotFound('Requested URL {} not found'.format(url))
sanic.exceptions.NotFound: Requested URL /favicon.ico not found
``


@Noctem I can confirm that removing the port allows the connection to go through.

Afterwards though, I also get this error:

```

2017-04-25 13:49:16,007: ERROR: Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/sanic/router.py", line 288, in get
    request.headers.get("Host", ''))
  File "/usr/local/lib/python3.6/site-packages/sanic/router.py", line 333, in _get
    raise NotFound('Requested URL {} not found'.format(url))
sanic.exceptions.NotFound: Requested URL 149.56.242.61:5000/favicon.ico not found

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/sanic/app.py", line 382, in handle_request
    handler, args, kwargs = self.router.get(request)
  File "/usr/local/lib/python3.6/site-packages/sanic/router.py", line 291, in get
    return self._get(request.url, request.method, '')
  File "/usr/local/lib/python3.6/site-packages/sanic/router.py", line 333, in _get
    raise NotFound('Requested URL {} not found'.format(url))
sanic.exceptions.NotFound: Requested URL /favicon.ico not found
```


may relate to #123


TeamCity libpalaso :: palaso-precise64-libpalaso-3.1 Continuous [Build 3.1.237.b1b99c64026c4d4f6e5b496eadd2b1c16b15c607](http://build.palaso.org/viewLog.html?buildId=88430&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3554, ignored: 111 Build time: 00:06:53


@timpotter87 it seems to be stemming from this:
```
results = await cur.fetchall('''
                 SELECT id, pokemon_id, expire_timestamp, lat, lon, atk_iv, def_iv, sta_iv, move_1, move_2
                 FROM sightings
                 WHERE expire_timestamp > {} AND id > {}
             '''.format(_time(), last_id))
```

python seems to think that the multiline string is 2 arguments instead of 1?


this only pulls a single object from the `statsResponse` array - hence, there is only a single commit being rendered as of this commit.


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/fd18c224-02cc-44bb-add5-d687f18d5023 "weather-app"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/b3ff289f-cd59-4cef-ade4-33e0cc1cd438 "weather-app") deployed [weather-app](https://github.com/robinbobbitt/weather-app/releases/tag/deploy-ibm-yp-us-south-ryehle-us.ibm.com-staging-20170425-185516 "deploy-ibm-yp-us-south-ryehle-us.ibm.com-staging-20170425-185516") to [staging](https://console.ng.bluemix.net/apps/989e27ab-e25b-4454-8405-9ffda1404641 "ibm:yp:us-south:ryehle@us.ibm.com:staging"), including this commit


Bluemix [toolchain](https://dev-console.stage1.ng.bluemix.net/devops/toolchains/c93cc128-978c-45cf-821e-cf1065718a7e "jenkinsGitDemo-dev"): [Jenkins](http://9.37.138.183:8080/ "jiraJenkinsDemo-dev") deployed [jenkinsGitDemo-dev](https://github.com/patrickjoy/jenkinsGitDemo-dev/releases/tag/deploy-ibm-ys1-us-south-patrick.joy1-dev-20170425-185537 "deploy-ibm-ys1-us-south-patrick.joy1-dev-20170425-185537") to [dev](https://console.stage1.ng.bluemix.net/apps/d16b39ab-83b9-4e10-ac10-85bf8ce1a8dd "ibm:ys1:us-south:patrick.joy1:dev"), including this commit


okok mam ndk papa sip


Hi @tobyst64 @danielhjames

Very nice features added. Eventually we should put configuration files under /etc/plegger/ as this is the suggested place in Debian for it to go. We just need to make sure this folder is created at package install time.


TODO Place 'pageSize' in config file


@peti: Hmm, perhaps you are right. It might be possible that I used up/down differently than intended.
I was using them like `up = "/path/to/some/externally/managed/script.sh"`. The script I called tried to use $1 $2 ... to get MTU, IP and so on from OpenVPN and failed. I propably just could have used it like `up = "source /path/to/some/externally/managed/script.sh` or try to embed my whole script.


I was getting a timeout when running the tests until I added the `done();`


I meant, have you tried this image. It would be surprising if the maintainer didn't update php 7.0.x packages as well. Regarding your errors, you cannot fix them at the moment, it's a problem with the nginx package in Alpine Edge.


noted :)


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170425-190016 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170425-190016") to [prod](https://console.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "ibm:yp:us-south:user@ibm.com:prod"), including this commit


This change is breaking on https://github.com/grails/gorm-neo4j/blob/01176dfb763ffa2869e5e5ae6d401437ad3d6ef7/grails-datastore-gorm-neo4j/src/main/groovy/org/grails/datastore/gorm/neo4j/engine/DynamicAssociationSupport.java#L106 giving a NPE. It should do a null check.


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170425-190024 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170425-190024") to [prod](https://console.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "ibm:yp:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-Prod-20170425-190028 "deployed-2-env-Prod-20170425-190028") to [Prod](https://console.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "There was a problem retrieving the space name"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170425-190039 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170425-190039") to [prod](https://console.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "ibm:yp:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testrepo-traceability](https://github.com/idsdev/testrepo-traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170425-190046 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170425-190046") to [prod](https://console.ng.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19 "ibm:yp:us-south:user@ibm.com:prod"), including this commit


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/fd18c224-02cc-44bb-add5-d687f18d5023 "weather-app"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/b3ff289f-cd59-4cef-ade4-33e0cc1cd438 "weather-app") deployed [weather-app](https://github.com/robinbobbitt/weather-app/releases/tag/deploy-ibm-yp-us-south-ryehle-us.ibm.com-prod-20170425-190103 "deploy-ibm-yp-us-south-ryehle-us.ibm.com-prod-20170425-190103") to [prod](https://console.ng.bluemix.net/apps/63cc1e3f-9eb6-4aec-b5ba-64d75dee1a22 "ibm:yp:us-south:ryehle@us.ibm.com:prod"), including this commit


Kollidiert das hier nicht mit l.224 -- "module.require_chanmsg" ?


I think, it's better to make diff against XZs source tree because it includes more up-to-date commits log


I'd think memberships that end on the specified date should be excluded because they are ended.


Updated in 68688bb


Looks good!


Created multidev environment [badcamp-2017#ci-59](https://dashboard.pantheon.io/sites/8d658997-7a61-4db8-9be8-0f16b8b62022#ci-59).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-59-badcamp-2017.pantheonsite.io/)


Да не работает твоя формула, хуево цвета подбирает. В пизду, статичная палитра пизже


Did you see the 2 Println's in here? Just caught my eye. Not a big deal.


Good catch peti, should we revert, then?


You not need `oomphinc/composer-installers-extender`, only `composer/installers`


Yes it seems like Apline:edge is, excuse my choice of words, fucked up. (The libraries it complains about not finding are in /lib, but ldconfig exists with return code 1? What ldconfig am I even using? It seems busybox stopped buildig it? I don't even know anymore.) I'll go ask whoever maintains the Alpine:3.5 image to update their php to 7.0.18 I guess? It's really frustrating as I ran nextcloud 11.0.2 for weeks now and it comes down to either getting php >= 7.0.17 (7.0.16 currently) or kernel >= 3.17 (3.16 on my machine currently) and in my opinion a single container does not justify a kernel upgrade and reboot on a productive server.


This is not the final version, I will upload the final version shortly


Yes, that would simplify.  I was looking at using the state modifiers so split the status actions.  Do you think state modifiers would sit well here?


What do you think about making the class extend `object`, explanation [here](http://stackoverflow.com/questions/15374857/should-all-python-classes-extend-object)


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.415.e65e8b866425e23ec8b3fc47718069fa7ac9d614](http://build.palaso.org/viewLog.html?buildId=88416&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 950, ignored: 51 Build time: 00:26:21


Let me take a look at the assembly graphs and tell you if you can remove it from ref.


Très cool de voir le "build passing" apparaître :)


What do you think about listing the imports one by one to make it easier to read?


This has been reverted


[inst/examples/scatterplot/server.R:10:5:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/inst/examples/scatterplot/server.R#L10) *style:* **Variable or function name should be snake_case.**
```r
    num.ticks <- input$nticks
    ^~~~~~~~~
```
[inst/examples/scatterplot/server.R:11:25:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/inst/examples/scatterplot/server.R#L11) *style:* **Variable or function name should be snake_case.**
```r
    if (num.ticks == 0) num.ticks <- NULL
                        ^~~~~~~~~
```
[inst/examples/scatterplot/server.R:12:10:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/inst/examples/scatterplot/server.R#L12) *style:* **Variable or function name should be snake_case.**
```r
    else num.ticks <- rep(num.ticks, 3)
         ^~~~~~~~~
```
[R/globe.R:158:3:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/globe.R#L158) *style:* **Variable or function name should be snake_case.**
```r
  arcsColor="#99aaff",
  ^~~~~~~~~
```
[R/globe.R:159:3:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/globe.R#L159) *style:* **Variable or function name should be snake_case.**
```r
  arcsHeight=0.4,
  ^~~~~~~~~~
```
[R/globe.R:160:3:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/globe.R#L160) *style:* **Variable or function name should be snake_case.**
```r
  arcsLwd=1,
  ^~~~~~~
```
[R/globe.R:161:3:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/globe.R#L161) *style:* **Variable or function name should be snake_case.**
```r
  arcsOpacity=0.2,
  ^~~~~~~~~~~
```
[R/globe.R:200:3:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/globe.R#L200) *style:* **Variable or function name should be snake_case.**
```r
  arcsHeight <- max(min(arcsHeight, 1), 0.2)
  ^~~~~~~~~~
```
[R/globe.R:201:3:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/globe.R#L201) *style:* **Variable or function name should be snake_case.**
```r
  arcsOpacity <- max(min(arcsOpacity, 1), 0)
  ^~~~~~~~~~~
```
[R/globe.R:239:1:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/globe.R#L239) *style:* **Variable or function name should be snake_case.**
```r
globeOutput <- function(outputId, width = "100%", height = "600px") {
^~~~~~~~~~~
```
[R/globe.R:239:25:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/globe.R#L239) *style:* **Variable or function name should be snake_case.**
```r
globeOutput <- function(outputId, width = "100%", height = "600px") {
                        ^~~~~~~~
```
[R/globe.R:246:1:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/globe.R#L246) *style:* **Variable or function name should be snake_case.**
```r
renderGlobe <- function(expr, env = parent.frame(), quoted = FALSE) {
^~~~~~~~~~~
```
[R/graph.R:64:1:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L64) *style:* **Lines should not be more than 130 characters.**
```r
#' \item{}{ optional a single igraph object with the same number of vertices as \code{g} above (if specified this must be the first entry)}
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/graph.R:68:1:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L68) *style:* **Lines should not be more than 130 characters.**
```r
#' \item{cumulative}{ - optional boolean entry, if \code{TRUE} then vertex positions are added to current plot, default is \code{FALSE}}
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/graph.R:137:21:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L137) *style:* **Variable or function name should be snake_case.**
```r
                    vertex.color, vertex.size, vertex.shape, vertex.label,
                    ^~~~~~~~~~~~
```
[R/graph.R:137:35:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L137) *style:* **Variable or function name should be snake_case.**
```r
                    vertex.color, vertex.size, vertex.shape, vertex.label,
                                  ^~~~~~~~~~~
```
[R/graph.R:137:48:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L137) *style:* **Variable or function name should be snake_case.**
```r
                    vertex.color, vertex.size, vertex.shape, vertex.label,
                                               ^~~~~~~~~~~~
```
[R/graph.R:137:62:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L137) *style:* **Variable or function name should be snake_case.**
```r
                    vertex.color, vertex.size, vertex.shape, vertex.label,
                                                             ^~~~~~~~~~~~
```
[R/graph.R:138:21:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L138) *style:* **Variable or function name should be snake_case.**
```r
                    edge.color, edge.width, edge.alpha,
                    ^~~~~~~~~~
```
[R/graph.R:138:33:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L138) *style:* **Variable or function name should be snake_case.**
```r
                    edge.color, edge.width, edge.alpha,
                                ^~~~~~~~~~
```
[R/graph.R:138:45:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L138) *style:* **Variable or function name should be snake_case.**
```r
                    edge.color, edge.width, edge.alpha,
                                            ^~~~~~~~~~
```
[R/graph.R:148:30:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L148) *style:* **Variable or function name should be snake_case.**
```r
    if (missing(edge.color)) edge.color <- lapply(g, function(x) {
                             ^~~~~~~~~~
```
[R/graph.R:156:32:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L156) *style:* **Variable or function name should be snake_case.**
```r
    if (missing(vertex.color)) vertex.color <- lapply(g, function(x) ifel(is.null(V(x)$color), "orange", V(x)$color))
                               ^~~~~~~~~~~~
```
[R/graph.R:167:32:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L167) *style:* **Variable or function name should be snake_case.**
```r
    if (missing(vertex.color)) vertex.color <- list(ifel(is.null(V(g)$color), "orange", V(g)$color))
                               ^~~~~~~~~~~~
```
[R/graph.R:168:30:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L168) *style:* **Variable or function name should be snake_case.**
```r
    if (missing(edge.color)) edge.color <- ifel(is.null(E(g)$color), NA, E(g)$color)
                             ^~~~~~~~~~
```
[R/graph.R:171:29:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L171) *style:* **Variable or function name should be snake_case.**
```r
  if (missing(vertex.size)) vertex.size <- ifel(is.null(V(g)$size), 2, V(g)$size / 7)
                            ^~~~~~~~~~~
```
[R/graph.R:172:30:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L172) *style:* **Variable or function name should be snake_case.**
```r
  if (missing(vertex.shape)) vertex.shape <- ifel(is.null(V(g)$shape), "circle", V(g)$shape)
                             ^~~~~~~~~~~~
```
[R/graph.R:173:30:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L173) *style:* **Variable or function name should be snake_case.**
```r
  if (missing(vertex.label)) vertex.label <- ifel(is.null(V(g)$label), NA, V(g)$label)
                             ^~~~~~~~~~~~
```
[R/graph.R:174:28:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L174) *style:* **Variable or function name should be snake_case.**
```r
  if (missing(edge.width)) edge.width <- ifel(is.null(E(g)$width), 1, E(g)$width)
                           ^~~~~~~~~~
```
[R/graph.R:178:5:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L178) *style:* **Variable or function name should be snake_case.**
```r
    edge.width <- edge.width[1]
    ^~~~~~~~~~
```
[R/graph.R:182:30:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L182) *style:* **Variable or function name should be snake_case.**
```r
    if (length(E(g)) > 1000) edge.alpha <- 0.3
                             ^~~~~~~~~~
```
[R/graph.R:183:10:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L183) *style:* **Variable or function name should be snake_case.**
```r
    else edge.alpha <- 1
         ^~~~~~~~~~
```
[R/graph.R:184:31:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/graph.R#L184) *style:* **Variable or function name should be snake_case.**
```r
    if (!is.null(E(g)$alpha)) edge.alpha <- E(g)$alpha
                              ^~~~~~~~~~
```
[R/scatterplot.R:180:3:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L180) *style:* **Variable or function name should be snake_case.**
```r
  num.ticks = c(6, 6, 6),
  ^~~~~~~~~
```
[R/scatterplot.R:181:3:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L181) *style:* **Variable or function name should be snake_case.**
```r
  x.ticklabs = NULL,
  ^~~~~~~~~~
```
[R/scatterplot.R:182:3:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L182) *style:* **Variable or function name should be snake_case.**
```r
  y.ticklabs = NULL,
  ^~~~~~~~~~
```
[R/scatterplot.R:183:3:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L183) *style:* **Variable or function name should be snake_case.**
```r
  z.ticklabs = NULL,
  ^~~~~~~~~~
```
[R/scatterplot.R:187:3:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L187) *style:* **Variable or function name should be snake_case.**
```r
  flip.y = TRUE,
  ^~~~~~
```
[R/scatterplot.R:192:3:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L192) *style:* **Variable or function name should be snake_case.**
```r
  cex.symbols = 1,
  ^~~~~~~~~~~
```
[R/scatterplot.R:242:27:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L242) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  x <- lapply(x, function (y) y[, c(1, 3, 2), drop=FALSE])
                          ^
```
[R/scatterplot.R:246:13:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L246) *style:* **Variable or function name should be snake_case.**
```r
    options$axisLabels <- colnames(x[[1]])[1:3]
            ^~~~~~~~~~
```
[R/scatterplot.R:267:30:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L267) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  x <- lapply(x, function(x) (x[, 1:3, drop=FALSE] - rep(mn, each = n)) / (rep(mx - mn, each = n)))
                             ^
```
[R/scatterplot.R:287:49:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L287) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  x <- lapply(x, function(y) as.vector(t(signif (y, signif))))
                                                ^
```
[R/scatterplot.R:294:5:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L294) *style:* **Variable or function name should be snake_case.**
```r
    num.ticks <- pmax(1, num.ticks[c(1, 3, 2)])
    ^~~~~~~~~
```
[R/scatterplot.R:350:3:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L350) *style:* **Variable or function name should be snake_case.**
```r
  N <- length(options$from) - length(options$vertices)
  ^
```
[R/scatterplot.R:412:3:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L412) *style:* **Variable or function name should be snake_case.**
```r
  N <- nrow(e$x)
  ^
```
[R/scatterplot.R:418:3:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L418) *style:* **Variable or function name should be snake_case.**
```r
  M <- nrow(n$x)
  ^
```
[R/scatterplot.R:443:1:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L443) *style:* **Lines should not be more than 130 characters.**
```r
#' @param color Either a single color value or vector of values as long as ‘from’ of line colors; line colors default to interpolating their vertex point colors.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/scatterplot.R:476:1:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L476) *style:* **Variable or function name should be snake_case.**
```r
scatterplotThreeOutput <- function(outputId, width="100%", height="500px") {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/scatterplot.R:476:36:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L476) *style:* **Variable or function name should be snake_case.**
```r
scatterplotThreeOutput <- function(outputId, width="100%", height="500px") {
                                   ^~~~~~~~
```
[R/scatterplot.R:482:1:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/R/scatterplot.R#L482) *style:* **Variable or function name should be snake_case.**
```r
renderScatterplotThree <- function(expr, env = parent.frame(), quoted = FALSE) {
^~~~~~~~~~~~~~~~~~~~~~
```
[tests/threejs.R:3:1:](https://github.com/bwlewis/rthreejs/blob/f1dd25fe0e255b7f31c5a6e31e346da2e1ad2b5b/tests/threejs.R#L3) *style:* **Variable or function name should be snake_case.**
```r
N <- 100
^
```


Здесь всё верно


No


I'd think ended memberships should always be pushed at the end just before voided because callers are less interested in them most of the time.


oki


Added the following:

* Operation descriptions
* Input/output parameters
* Global info such as Contact info and License


Looks good.


`mapping(uint => Merchant) merchants; ` Should probably be.. ` mapping(address => Merchant) merchants;`

`uint[] merchantsIndex; ` is obsolete in current.  Was thinking of having a delete merchant so structuring similar to productsIndex.


Are these supposed to actually appear when something sets terrain? I've literally never seen them before other than when something uses Psystrike...


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.283.b1b99c64026c4d4f6e5b496eadd2b1c16b15c607](http://build.palaso.org/viewLog.html?buildId=88428&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3576, ignored: 128 Build time: 00:03:37


This method is large. And the controller seems to be handling all the email prep work, as well as dictating which flash message to display. I'd try to bring this stuff out - so the method could look something like this:

`contract = Contract.find(params[:contract_id])
  flash[:notice] = invite_users(seperate_users(params))
  redirect_to '/'

  private

  def invite_users(new_users)
     new_users.each do |user|
       if user[0] != ""
          Postmark stuff, etc
          return "Message successfully sent"
       else
          return "Message did not send"
      end
    end
  end
`
or something like this. Also - you may just add in the controllers/concerns folder a `invitable_controller.rb` and include that in this controller. This way the `invite_users(new_users)` method can live in it's own concern. Also this helps because if you ever are going to do other stuff with inviting users, or other invitations, those methods and logic can exist in this concern.


What do you do here @shauren?
I see the same and it supouse fix the problem.


would be nice to use https as scheme here!


This one delete


This initial draft has been approved by the Porject Manager as meeting the requirements for this document. No errors were found and no additions were needed. This is now approved to be the Final Draft of our JCS document.


You are right, I would have been confused by that if I ever tried using the rcon password for anything 👍

If you want to submit a PR for it, feel free but it currently doesn't affect anything so I will continue my 0.15 vanilla fun,


there's maybe potential for improvement in there somewhere probably - because the only difference in actually generated files for some of the (rather simple/limited) tests i've done locally appear to be that minify-first files have some extra new lines in there (and no other differences) - so maybe a few more bytes can be shaved off...

i'll try looking into it some more if/when time permits...


Do you have an example in the form of an image of this update? Thanks. :)
Is it the fix to this? https://github.com/Kagamia/WzComparerR2/commit/394b89438300aa02a8d381900a220a09a4d676f9


Yuval:
Looking at the commit it is impossible to tell which changes you made, could it be that you used windows and windows used it \r\n thingy that ruined the commit? if so, NU NU NU for using Windows. @ravivos @AdiOmari


pre is better