[R/lifx-cloud.R:1:2:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L1) *style:* **Commented code should be removed.**
```r
## SEE Docs: https://api.lifx.com/
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:3:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L3) *style:* **Variable or function name should be snake_case.**
```r
BASE <- "https://api.lifx.com"
^~~~
```
[R/lifx-cloud.R:4:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L4) *style:* **Variable or function name should be snake_case.**
```r
VERSION <- "v1"
^~~~~~~
```
[R/lifx-cloud.R:8:7:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L8) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(is.na(key))stop("No key found")
      ^
```
[R/lifx-cloud.R:12:7:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L12) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(hue < 0 | hue > 360){
      ^
```
[R/lifx-cloud.R:18:7:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L18) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(value < 0 | value > 1){
      ^
```
[R/lifx-cloud.R:24:7:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L24) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(value < 0 | value > 1){
      ^
```
[R/lifx-cloud.R:29:2:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L29) *style:* **Commented code should be removed.**
```r
## kelvin:[2500-9000]  # maar geef boodschap als ook saturation gegeven, slaat
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:31:7:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L31) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(value < 2500 | value > 9000){
      ^
```
[R/lifx-cloud.R:38:16:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L38) *style:* **Trailing whitespace is superfluous.**
```r
# except color.
               ^
```
[R/lifx-cloud.R:43:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L43) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/lifx-cloud.R:51:5:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L51) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(results$status_code != 200)
    ^
```
[R/lifx-cloud.R:58:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L58) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/lifx-cloud.R:60:74:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L60) *style:* **Trailing whitespace is superfluous.**
```r
#' @param selector a string in format '[type]:[value]', where type can be
                                                                         ^
```
[R/lifx-cloud.R:61:73:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L61) *style:* **Trailing whitespace is superfluous.**
```r
#' 'all', 'id', 'label', 'group', 'group_id', 'location', 'location_id',
                                                                        ^
```
[R/lifx-cloud.R:63:34:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L63) *style:* **Trailing whitespace is superfluous.**
```r
#' which needs no value argument.
                                 ^
```
[R/lifx-cloud.R:64:56:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L64) *style:* **Trailing whitespace is superfluous.**
```r
#' @return a list of all lights, status, and properties
                                                       ^
```
[R/lifx-cloud.R:74:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L74) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/lifx-cloud.R:80:17:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L80) *warning:* **no visible global function definition for ‘lights’, Did you mean 'weights'?**
```r
  light_list <- lights(selector = selector)
                ^~~~~~
```
[R/lifx-cloud.R:81:21:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L81) *style:* **Trailing whitespace is superfluous.**
```r
  sapply(light_list,
                    ^
```
[R/lifx-cloud.R:83:14:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L83) *style:* **Place a space before left parenthesis, except in a function call.**
```r
           if(light$color[["saturation"]] > 0)
             ^
```
[R/lifx-cloud.R:89:18:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L89) *style:* **Trailing whitespace is superfluous.**
```r
             else
                 ^
```
[R/lifx-cloud.R:90:32:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L90) *style:* **Trailing whitespace is superfluous.**
```r
               paste("kelvin:",
                               ^
```
[R/lifx-cloud.R:91:46:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L91) *style:* **Trailing whitespace is superfluous.**
```r
                     light$color[["kelvin"]],
                                             ^
```
[R/lifx-cloud.R:93:50:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L93) *style:* **Trailing whitespace is superfluous.**
```r
                     light$brightness * 100, "%",
                                                 ^
```
[R/lifx-cloud.R:100:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L100) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/lifx-cloud.R:106:67:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L106) *style:* **Trailing whitespace is superfluous.**
```r
  results <- POST(paste0(BASE, "/", VERSION, "/lights/", selector,
                                                                  ^
```
[R/lifx-cloud.R:107:42:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L107) *style:* **Trailing whitespace is superfluous.**
```r
                         "/toggle.json"),
                                         ^
```
[R/lifx-cloud.R:109:22:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L109) *warning:* **no visible global function definition for ‘content’, Did you mean 'confint'?**
```r
  jsonlite::fromJSON(content(results, as = "text"))
                     ^~~~~~~
```
[R/lifx-cloud.R:113:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L113) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/lifx-cloud.R:119:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L119) *style:* **Lines should not be more than 80 characters.**
```r
#' @details Not exported because it conflicts with stats::power. see on() and off()
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:122:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L122) *style:* **Lines should not be more than 80 characters.**
```r
  results <- PUT(paste0(BASE, "/", VERSION, "/lights/", selector, "/state.json"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:122:82:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L122) *style:* **Trailing whitespace is superfluous.**
```r
  results <- PUT(paste0(BASE, "/", VERSION, "/lights/", selector, "/state.json"),
                                                                                ^
```
[R/lifx-cloud.R:123:34:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L123) *style:* **Trailing whitespace is superfluous.**
```r
      query = list(power = state,
                                 ^
```
[R/lifx-cloud.R:124:40:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L124) *style:* **Trailing whitespace is superfluous.**
```r
                   duration = duration,
                                       ^
```
[R/lifx-cloud.R:126:22:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L126) *warning:* **no visible global function definition for ‘content’, Did you mean 'confint'?**
```r
  jsonlite::fromJSON(content(results, as = "text"))
                     ^~~~~~~
```
[R/lifx-cloud.R:131:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L131) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/lifx-cloud.R:138:10:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L138) *warning:* **possible error in power("off", selector = selector, duration = duration): unused arguments (selector = selector, duration = duration)**
```r
  power("off", selector = selector, duration = duration)
         ^~~
```
[R/lifx-cloud.R:143:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L143) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/lifx-cloud.R:144:19:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L144) *style:* **Trailing whitespace is superfluous.**
```r
#' power lights on
                  ^
```
[R/lifx-cloud.R:150:10:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L150) *warning:* **possible error in power("on", selector = selector, duration = duration): unused arguments (selector = selector, duration = duration)**
```r
  power("on", selector = selector, duration = duration)
         ^~
```
[R/lifx-cloud.R:155:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L155) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/lifx-cloud.R:159:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L159) *style:* **Lines should not be more than 80 characters.**
```r
#' @param power_on should the light be powered on if it is off? (FALSE just leaves light off)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:161:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L161) *style:* **Lines should not be more than 80 characters.**
```r
#' @details Note that the kelvin temperature ranges from 2700 to 8000. Hue in HSB list is
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:161:90:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L161) *style:* **Trailing whitespace is superfluous.**
```r
#' @details Note that the kelvin temperature ranges from 2700 to 8000. Hue in HSB list is
                                                                                ^
```
[R/lifx-cloud.R:162:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L162) *style:* **Lines should not be more than 80 characters.**
```r
#' a number between 0 and 360, whereas saturation and brightness should be between 0 and 1.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:163:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L163) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/lifx-cloud.R:165:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L165) *style:* **Lines should not be more than 80 characters.**
```r
#'  color("green", "label:desk")   # deep green, brightness untouched on lights labeled 'desk'
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:168:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L168) *style:* **Lines should not be more than 80 characters.**
```r
#'  color("random")                # random hue, maximum saturation, brightness untouched
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:175:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L175) *style:* **Lines should not be more than 80 characters.**
```r
  results <- PUT(paste0(BASE, "/", VERSION, "/lights/", selector, "/state.json"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:175:82:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L175) *style:* **Trailing whitespace is superfluous.**
```r
  results <- PUT(paste0(BASE, "/", VERSION, "/lights/", selector, "/state.json"),
                                                                                ^
```
[R/lifx-cloud.R:176:34:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L176) *style:* **Trailing whitespace is superfluous.**
```r
      query = list(color = color,
                                 ^
```
[R/lifx-cloud.R:177:40:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L177) *style:* **Trailing whitespace is superfluous.**
```r
                   duration = duration,
                                       ^
```
[R/lifx-cloud.R:180:22:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L180) *warning:* **no visible global function definition for ‘content’, Did you mean 'confint'?**
```r
  jsonlite::fromJSON(content(results, as = "text"))
                     ^~~~~~~
```
[R/lifx-cloud.R:185:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L185) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/lifx-cloud.R:187:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L187) *style:* **Lines should not be more than 80 characters.**
```r
#' @param from_color Same syntax as color, defaults to current color (of first bulb in selection)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:190:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L190) *style:* **Lines should not be more than 80 characters.**
```r
#' @param persist should the color persist after the effect? default is FALSE (returns to original color)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:197:65:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L197) *style:* **Trailing whitespace is superfluous.**
```r
breathe <- function(color, from_color = current_color(selector),
                                                                ^
```
[R/lifx-cloud.R:200:34:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L200) *style:* **Trailing whitespace is superfluous.**
```r
  settings <- list(color = color,
                                 ^
```
[R/lifx-cloud.R:208:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L208) *style:* **Lines should not be more than 80 characters.**
```r
  results <- POST(paste0(BASE, "/", VERSION, "/lights/", selector, "/effects/breathe"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:210:22:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L210) *warning:* **no visible global function definition for ‘content’, Did you mean 'confint'?**
```r
  jsonlite::fromJSON(content(results, as = "text"))
                     ^~~~~~~
```
[R/lifx-cloud.R:214:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L214) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/lifx-cloud.R:217:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L217) *style:* **Lines should not be more than 80 characters.**
```r
#' @param duty_cycle Ratio of the period where color is active. Only used for pulse. Defaults to 0.5. Range: 0-1
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:220:68:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L220) *style:* **Trailing whitespace is superfluous.**
```r
pulse <- function(color, from_color = current_color(selector)[[1]],
                                                                   ^
```
[R/lifx-cloud.R:223:34:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L223) *style:* **Trailing whitespace is superfluous.**
```r
  settings <- list(color = color,
                                 ^
```
[R/lifx-cloud.R:231:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L231) *style:* **Lines should not be more than 80 characters.**
```r
  results <- POST(paste0(BASE, "/", VERSION, "/lights/", selector, "/effects/pulse.json"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:233:22:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L233) *warning:* **no visible global function definition for ‘content’, Did you mean 'confint'?**
```r
  jsonlite::fromJSON(content(results, as = "text"))
                     ^~~~~~~
```
[R/lifx-cloud.R:237:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L237) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/lifx-cloud.R:244:71:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L244) *style:* **Trailing whitespace is superfluous.**
```r
  PUT(paste0(BASE, "/", VERSION, "/lights/", selector, "/label.json"),
                                                                      ^
```
[R/lifx-cloud.R:245:34:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L245) *style:* **Trailing whitespace is superfluous.**
```r
      query = list(label = label,
                                 ^
```
[R/lifx-cloud.R:250:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L250) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/lifx-cloud.R:258:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L258) *style:* **Lines should not be more than 80 characters.**
```r
  results <- PUT(paste0(BASE, "/", VERSION, "/scenes/scene_id:", scene_id, "/activate.json"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:258:94:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L258) *style:* **Trailing whitespace is superfluous.**
```r
  results <- PUT(paste0(BASE, "/", VERSION, "/scenes/scene_id:", scene_id, "/activate.json"),
                                                                                ^
```
[R/lifx-cloud.R:259:34:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L259) *style:* **Trailing whitespace is superfluous.**
```r
      query = list(state = state,
                                 ^
```
[R/lifx-cloud.R:260:40:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L260) *style:* **Trailing whitespace is superfluous.**
```r
                   duration = duration,
                                       ^
```
[R/lifx-cloud.R:262:22:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L262) *warning:* **no visible global function definition for ‘content’, Did you mean 'confint'?**
```r
  jsonlite::fromJSON(content(results, as = "text"))
                     ^~~~~~~
```
[R/lifx-cloud.R:266:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L266) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/lifx-cloud.R:272:24:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L272) *warning:* **no visible global function definition for ‘content’, Did you mean 'confint'?**
```r
    jsonlite::fromJSON(content(results, as = "text"))
                       ^~~~~~~
```
[R/lifx-cloud.R:281:44:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L281) *style:* **Trailing whitespace is superfluous.**
```r
#' @return hsbk information for the string.
                                           ^
```
[R/lifx-cloud.R:284:55:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L284) *style:* **Trailing whitespace is superfluous.**
```r
  results <- GET(paste0(BASE, "/", VERSION, "/color"),
                                                      ^
```
[R/lifx-cloud.R:287:22:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L287) *warning:* **no visible global function definition for ‘content’, Did you mean 'confint'?**
```r
  jsonlite::fromJSON(content(results, as = "text"))
                     ^~~~~~~
```
[R/lifx-cloud.R:291:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L291) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/lifx-cloud.R:293:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L293) *style:* **Lines should not be more than 80 characters.**
```r
#' @param power either on or off, defaults to on, makes not sense to shut the light off and change the color
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:299:66:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L299) *style:* **Trailing whitespace is superfluous.**
```r
set_state <- function(selector ="all", power = "on", color= NULL,
                                                                 ^
```
[R/lifx-cloud.R:302:7:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L302) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!is.null(brightness)){brightness <- check_brightness(brightness)}
      ^
```
[R/lifx-cloud.R:302:29:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L302) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    if(!is.null(brightness)){brightness <- check_brightness(brightness)}
                            ^
```
[R/lifx-cloud.R:302:44:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L302) *warning:* **no visible global function definition for ‘check_brightness’**
```r
    if(!is.null(brightness)){brightness <- check_brightness(brightness)}
                                           ^~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:302:72:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L302) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
    if(!is.null(brightness)){brightness <- check_brightness(brightness)}
                                                                       ^
```
[R/lifx-cloud.R:303:7:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L303) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(!is.null(saturation)){brightness <- check_saturation(saturation)}
      ^
```
[R/lifx-cloud.R:303:29:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L303) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    if(!is.null(saturation)){brightness <- check_saturation(saturation)}
                            ^
```
[R/lifx-cloud.R:303:44:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L303) *warning:* **no visible global function definition for ‘check_saturation’**
```r
    if(!is.null(saturation)){brightness <- check_saturation(saturation)}
                                           ^~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:303:72:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L303) *style:* **Closing curly-braces should always be on their own line, unless it's followed by an else.**
```r
    if(!is.null(saturation)){brightness <- check_saturation(saturation)}
                                                                       ^
```
[R/lifx-cloud.R:304:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L304) *style:* **Lines should not be more than 80 characters.**
```r
    #if(grepl("hue", color)){} # extract hue and check for hue:number and check hue.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:304:6:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L304) *style:* **Commented code should be removed.**
```r
    #if(grepl("hue", color)){} # extract hue and check for hue:number and check hue.
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:305:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L305) *style:* **Lines should not be more than 80 characters.**
```r
    result <- PUT(paste0(BASE, "/", VERSION, "/lights/", selector, "/state.json"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:305:83:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L305) *style:* **Trailing whitespace is superfluous.**
```r
    result <- PUT(paste0(BASE, "/", VERSION, "/lights/", selector, "/state.json"),
                                                                                ^
```
[R/lifx-cloud.R:307:37:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L307) *style:* **Put spaces around all infix operators.**
```r
                               color= color,
                                   ~^
```
[R/lifx-cloud.R:310:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L310) *style:* **Lines should not be more than 80 characters.**
```r
                               saturation = saturation, # doesn't work. because needs to be in color.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-cloud.R:315:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L315) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/lifx-cloud.R:316:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-cloud.R#L316) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/lifx-server.R:1:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L1) *style:* **Lines should not be more than 80 characters.**
```r
# ## These functions are designed to work with a local server only, which must be running separately
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:2:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L2) *style:* **Lines should not be more than 80 characters.**
```r
# ## These methods are depricated at this time, see lifx-cloud.R functions instead.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:2:84:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L2) *style:* **Trailing whitespace is superfluous.**
```r
# ## These methods are depricated at this time, see lifx-cloud.R functions instead.
                                                                                ^
```
[R/lifx-server.R:3:2:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L3) *style:* **Trailing whitespace is superfluous.**
```r
#
 ^
```
[R/lifx-server.R:5:5:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L5) *style:* **Commented code should be removed.**
```r
#   results <- GET("http://localhost:56780/lights.json")
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:7:7:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L7) *style:* **Commented code should be removed.**
```r
#     message("LIFX server could not be reached")
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:9:7:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L9) *style:* **Commented code should be removed.**
```r
#     message("ping! LIFX server is active.")
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:11:2:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L11) *style:* **Trailing whitespace is superfluous.**
```r
#
 ^
```
[R/lifx-server.R:13:5:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L13) *style:* **Commented code should be removed.**
```r
#   results <- GET(paste0("http://localhost:56780/lights/", selector))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:14:5:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L14) *style:* **Commented code should be removed.**
```r
#   dat <- RJSONIO::fromJSON(content(results, as="text"))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:16:2:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L16) *style:* **Trailing whitespace is superfluous.**
```r
#
 ^
```
[R/lifx-server.R:17:2:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L17) *style:* **Trailing whitespace is superfluous.**
```r
#
 ^
```
[R/lifx-server.R:19:5:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L19) *style:* **Commented code should be removed.**
```r
#   results <- PUT(paste0("http://localhost:56780/lights/", selector, "/on"))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:21:2:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L21) *style:* **Trailing whitespace is superfluous.**
```r
#
 ^
```
[R/lifx-server.R:23:5:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L23) *style:* **Commented code should be removed.**
```r
#   results <- PUT(paste0("http://localhost:56780/lights/", selector, "/off"))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:25:2:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L25) *style:* **Trailing whitespace is superfluous.**
```r
#
 ^
```
[R/lifx-server.R:26:2:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L26) *style:* **Trailing whitespace is superfluous.**
```r
#
 ^
```
[R/lifx-server.R:28:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L28) *style:* **Lines should not be more than 80 characters.**
```r
#   results <- PUT(paste0("http://localhost:56780/lights/", selector, "/toggle"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:28:5:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L28) *style:* **Commented code should be removed.**
```r
#   results <- PUT(paste0("http://localhost:56780/lights/", selector, "/toggle"))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:30:2:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L30) *style:* **Trailing whitespace is superfluous.**
```r
#
 ^
```
[R/lifx-server.R:31:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L31) *style:* **Lines should not be more than 80 characters.**
```r
# server_color <- function(selector="all", hue, saturation=1, brightness=1, duration=1){
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:32:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L32) *style:* **Lines should not be more than 80 characters.**
```r
#   settings <- RJSONIO::toJSON(list(hue=hue, saturation=saturation, brightness=brightness, duration=duration))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:32:5:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L32) *style:* **Commented code should be removed.**
```r
#   settings <- RJSONIO::toJSON(list(hue=hue, saturation=saturation, brightness=brightness, duration=duration))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:33:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L33) *style:* **Lines should not be more than 80 characters.**
```r
#   results <- PUT(paste0("http://localhost:56780/lights/", selector, "/color"), body=settings, encode="json")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:33:5:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L33) *style:* **Commented code should be removed.**
```r
#   results <- PUT(paste0("http://localhost:56780/lights/", selector, "/color"), body=settings, encode="json")
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:35:2:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L35) *style:* **Trailing whitespace is superfluous.**
```r
#
 ^
```
[R/lifx-server.R:36:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L36) *style:* **Commented code should be removed.**
```r
# # Briefly set light(s) to green, then restore previous setting
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:39:4:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L39) *style:* **Trailing whitespace is superfluous.**
```r
# #
   ^
```
[R/lifx-server.R:41:5:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L41) *style:* **Commented code should be removed.**
```r
#   current <- server_status(selector)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:42:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L42) *style:* **Lines should not be more than 80 characters.**
```r
#   server_color(selector, hue=120, saturation=1, brightness=1, duration=0.1) # duration is speed of change
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:42:5:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L42) *style:* **Commented code should be removed.**
```r
#   server_color(selector, hue=120, saturation=1, brightness=1, duration=0.1) # duration is speed of change
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:44:7:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L44) *style:* **Commented code should be removed.**
```r
#     Sys.sleep(duration)
      ^~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:46:29:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L46) *style:* **Trailing whitespace is superfluous.**
```r
#     server_color(selector,
                            ^
```
[R/lifx-server.R:47:47:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L47) *style:* **Trailing whitespace is superfluous.**
```r
#           hue = current[[1]]$color[["hue"]],
                                              ^
```
[R/lifx-server.R:53:2:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L53) *style:* **Trailing whitespace is superfluous.**
```r
#
 ^
```
[R/lifx-server.R:54:3:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L54) *style:* **Commented code should be removed.**
```r
# # Briefly set light(s) to red
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:57:4:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L57) *style:* **Trailing whitespace is superfluous.**
```r
# #
   ^
```
[R/lifx-server.R:59:5:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L59) *style:* **Commented code should be removed.**
```r
#   current <- server_status(selector)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:60:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L60) *style:* **Lines should not be more than 80 characters.**
```r
#   server_color(selector, hue=1, saturation=1, brightness=1, duration=0.1) # duration is speed of change
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:60:5:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L60) *style:* **Commented code should be removed.**
```r
#   server_color(selector, hue=1, saturation=1, brightness=1, duration=0.1) # duration is speed of change
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:62:7:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L62) *style:* **Commented code should be removed.**
```r
#     Sys.sleep(duration)
      ^~~~~~~~~~~~~~~~~~~
```
[R/lifx-server.R:64:29:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L64) *style:* **Trailing whitespace is superfluous.**
```r
#     server_color(selector,
                            ^
```
[R/lifx-server.R:65:47:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L65) *style:* **Trailing whitespace is superfluous.**
```r
#           hue = current[[1]]$color[["hue"]],
                                              ^
```
[R/lifx-server.R:71:2:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L71) *style:* **Trailing whitespace is superfluous.**
```r
#
 ^
```
[R/lifx-server.R:72:2:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/R/lifx-server.R#L72) *style:* **Trailing whitespace is superfluous.**
```r
#
 ^
```
[tests/testthat/test_inputs.R:8:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/tests/testthat/test_inputs.R#L8) *style:* **Lines should not be more than 80 characters.**
```r
    expect_error(check_saturation(1.1), "saturation needs to be between 0 and 1")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test_inputs.R:9:1:](https://github.com/RMHogervorst/lifxr/blob/6c37fb608513b781baa08a6dfae3b8ababd328af/tests/testthat/test_inputs.R#L9) *style:* **Lines should not be more than 80 characters.**
```r
    expect_error(check_saturation(-0.5), "saturation needs to be between 0 and 1")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


To have listeners active only on specific use cases / parts of an app


yes, fail fast


んー・・・。たぶんみんな直したがるところだと思うので微妙なところです。また同じ変更をする人がいそう。ライブラリのタスクさえ作ってしまえばすぐ対応できるのですが・・・。


とりあえず、現状のinvoke.mdを`/reference/concept`以下に移して、nolinkのままにしておくのがいいですね。


@infotvbcom
http://tvb.c2567.com/ 你们TVB 是不是没人了


In the paper of LargeVis, there's not enough illustration about its visualization.
Is there anything that can help understanding your vis() function, including neg_table and alias_table?


では revert しておくので、`invoke.md` の移動はお願いします


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/8c053ff0-67c4-4f8b-90ec-c669d30aeeff "fleetchaincd"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/bb88b5be-7fc2-49e7-872a-20f7fcf2b106 "fleetchaincd") deployed [fleetchaincd](https://github.com/mamandal/fleetchaincd/releases/tag/deploy-ibm-yp-us-south-mamandal-in.ibm.com-dev-20170428-080656 "deploy-ibm-yp-us-south-mamandal-in.ibm.com-dev-20170428-080656") to [dev](https://console.ng.bluemix.net/apps/63e7bd69-2e2c-4596-8787-c7c45cd05a9c "ibm:yp:us-south:mamandal@in.ibm.com:dev"), including this commit


Sophiroth first test.


```
basepython=NAME-OR-PATH
name or path to a Python interpreter which will be used for creating the virtual environment. default: interpreter used for tox invocation.
```

Which means that it will use the python used to install tox (which can be whatever on the system. Please correct and set it to ``python3``.

@ocelotl


this is part of a refactoring that should take place on the tests.
we would have markers on each test to indicate with which driver(s) to run it. The test runner would trigger the tests for all configurations (today we have to run tests with a mvn profile for each configuration)


Precisely; the picture says 'delayUntilOther'. I'm sorry my comment was phrased badly.  I was asking if you _meant_ the picture to have a _different_ name to the method it annotated?


This is the relevant thread http://lists.jboss.org/pipermail/infinispan-dev/2016-August/016830.html


Created multidev environment [ci-example-d8-composer#ci-550](https://dashboard.pantheon.io/sites/c401fd14-f745-4e51-9af2-f30b45146a0c#ci-550).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-550-ci-example-d8-composer.pantheonsite.io/)


I'm sorry I didn't even double check the content of the picture -_- Thanks for pointing that out, that is indeed a mistake. opened #571 to track that 👍


Looks good to me.  Please update the defect with this commit. I will help you put this into ibm2.3 branch as well later today.


Cool! So that's half a success so far :-)


good


Sehe das gleich wie Leo. Verstehe Jans Gedanken, aber ihr habts ja auch nicht immer durchgezogen


post and categories API


yes. This was introduced while refactoring the tests. We can consider it as transitional state from the old static Components class and a clean config per SF state


If I am correct  `ACM` means `added`, `created` and `modified`. It is possible to make this configurable? Because sometimes we only want to commit some but not all of the files that are modified in one commit.


@bcoca Wait, doesn't this effectively "un-fix" #14430 by undoing your own commit 4ed643be from February?


yes. we should also consider (globally) streams


Code with return@ is rather hard to follow.
I'd either rewrite it as a boolean expression:
```
it !is VarInsnNode ||
isMaskIndex(it, maskStartIndex, masks) && it.opcode == Opcodes.ILOAD ||
isMethodHandleIndex(methodHandlerIndex, it) && it.opcode == Opcodes.ALOAD
```
or extract this lambda to a separate function.


ну с шириной согласен, она лишняя, но если высоту не ставить, то левый блок немного выпадает


I copied that from the existing `extract` and `process` methods, but now that you mention it, I would prefer to change it to `data` everywhere.
What about the name for these methods? I don't particularly like `do_process`. Perhaps call the new methods `process` and `extract` and rename the existing ones to `_process` and `_extract`? For methods I think underscoring usually indicates that the method is a partial or wrapped in another method, right?


@IIvec Actually history stats are supposed to work best a low depths, so I would be stunning if this works. Anyhow lets' see.. ;-)


Created multidev environment [9mobilevn#ci-5](https://dashboard.pantheon.io/sites/fd6210e2-d39f-4cb2-bfbb-e8e7c194dcb1#ci-5).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-5-9mobilevn.pantheonsite.io/)


Created multidev environment [9mobilevn#pr-tan](https://dashboard.pantheon.io/sites/fd6210e2-d39f-4cb2-bfbb-e8e7c194dcb1#pr-tan).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-tan-9mobilevn.pantheonsite.io/)


WARNING: [ContentDescription] [Accessibility] Missing `contentDescription` attribute on image
 Non-textual widgets like ImageViews and ImageButtons should use the `contentDescription` attribute to specify a textual description of the widget such that screen readers and other accessibility tools can adequately describe the user interface.

Note that elements in application screens that are purely decorative and do not provide any content or enable a user action should not have accessibility content descriptions. In this case, just suppress the lint warning with a tools:ignore="ContentDescription" attribute.

Note that for text fields, you should not set both the `hint` and the `contentDescription` attributes since the hint will never be shown. Just set the `hint`. See http://developer.android.com/guide/topics/ui/accessibility/checklist.html#special-cases.


WARNING: [RtlHardcoded] Consider adding `android:layout_marginStart="@dimen/dp_10"` to better support right-to-left layouts
 Using `Gravity#LEFT` and `Gravity#RIGHT` can lead to problems when a layout is rendered in locales where text flows from right to left. Use `Gravity#START` and `Gravity#END` instead. Similarly, in XML `gravity` and `layout_gravity` attributes, use `start` rather than `left`.

For XML attributes such as paddingLeft and `layout_marginLeft`, use `paddingStart` and `layout_marginStart`. *NOTE*: If your `minSdkVersion` is less than 17, you should add *both* the older left/right attributes *as well as* the new start/right attributes. On older platforms, where RTL is not supported and the start/right attributes are unknown and therefore ignored, you need the older left/right attributes. There is a separate lint check which catches that type of error.

(Note: For `Gravity#LEFT` and `Gravity#START`, you can use these constants even when targeting older platforms, because the `start` bitmask is a superset of the `left` bitmask. Therefore, you can use `gravity="start"` rather than `gravity="left|start"`.)


WARNING: [RtlHardcoded] Use "`end`" instead of "`right`" to ensure correct behavior in right-to-left locales
 Using `Gravity#LEFT` and `Gravity#RIGHT` can lead to problems when a layout is rendered in locales where text flows from right to left. Use `Gravity#START` and `Gravity#END` instead. Similarly, in XML `gravity` and `layout_gravity` attributes, use `start` rather than `left`.

For XML attributes such as paddingLeft and `layout_marginLeft`, use `paddingStart` and `layout_marginStart`. *NOTE*: If your `minSdkVersion` is less than 17, you should add *both* the older left/right attributes *as well as* the new start/right attributes. On older platforms, where RTL is not supported and the start/right attributes are unknown and therefore ignored, you need the older left/right attributes. There is a separate lint check which catches that type of error.

(Note: For `Gravity#LEFT` and `Gravity#START`, you can use these constants even when targeting older platforms, because the `start` bitmask is a superset of the `left` bitmask. Therefore, you can use `gravity="start"` rather than `gravity="left|start"`.)


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.781.b4293ff90ed40cd1a6bb10d452ce7bf3c13a8a18](http://build.palaso.org/viewLog.html?buildId=89142&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 938, ignored: 57 Build time: 00:15:10


WARNING: [RtlHardcoded] Consider adding `android:layout_marginStart="@dimen/dp_5"` to better support right-to-left layouts
 Using `Gravity#LEFT` and `Gravity#RIGHT` can lead to problems when a layout is rendered in locales where text flows from right to left. Use `Gravity#START` and `Gravity#END` instead. Similarly, in XML `gravity` and `layout_gravity` attributes, use `start` rather than `left`.

For XML attributes such as paddingLeft and `layout_marginLeft`, use `paddingStart` and `layout_marginStart`. *NOTE*: If your `minSdkVersion` is less than 17, you should add *both* the older left/right attributes *as well as* the new start/right attributes. On older platforms, where RTL is not supported and the start/right attributes are unknown and therefore ignored, you need the older left/right attributes. There is a separate lint check which catches that type of error.

(Note: For `Gravity#LEFT` and `Gravity#START`, you can use these constants even when targeting older platforms, because the `start` bitmask is a superset of the `left` bitmask. Therefore, you can use `gravity="start"` rather than `gravity="left|start"`.)


WARNING: [RtlHardcoded] Consider adding `android:layout_toEndOf="@id/image_item"` to better support right-to-left layouts
 Using `Gravity#LEFT` and `Gravity#RIGHT` can lead to problems when a layout is rendered in locales where text flows from right to left. Use `Gravity#START` and `Gravity#END` instead. Similarly, in XML `gravity` and `layout_gravity` attributes, use `start` rather than `left`.

For XML attributes such as paddingLeft and `layout_marginLeft`, use `paddingStart` and `layout_marginStart`. *NOTE*: If your `minSdkVersion` is less than 17, you should add *both* the older left/right attributes *as well as* the new start/right attributes. On older platforms, where RTL is not supported and the start/right attributes are unknown and therefore ignored, you need the older left/right attributes. There is a separate lint check which catches that type of error.

(Note: For `Gravity#LEFT` and `Gravity#START`, you can use these constants even when targeting older platforms, because the `start` bitmask is a superset of the `left` bitmask. Therefore, you can use `gravity="start"` rather than `gravity="left|start"`.)


WARNING: [RtlHardcoded] Consider adding `android:layout_marginEnd="@dimen/dp_5"` to better support right-to-left layouts
 Using `Gravity#LEFT` and `Gravity#RIGHT` can lead to problems when a layout is rendered in locales where text flows from right to left. Use `Gravity#START` and `Gravity#END` instead. Similarly, in XML `gravity` and `layout_gravity` attributes, use `start` rather than `left`.

For XML attributes such as paddingLeft and `layout_marginLeft`, use `paddingStart` and `layout_marginStart`. *NOTE*: If your `minSdkVersion` is less than 17, you should add *both* the older left/right attributes *as well as* the new start/right attributes. On older platforms, where RTL is not supported and the start/right attributes are unknown and therefore ignored, you need the older left/right attributes. There is a separate lint check which catches that type of error.

(Note: For `Gravity#LEFT` and `Gravity#START`, you can use these constants even when targeting older platforms, because the `start` bitmask is a superset of the `left` bitmask. Therefore, you can use `gravity="start"` rather than `gravity="left|start"`.)


Introducing boost::filesystem as new package dependency is current not an option. Please use a different method to implement this functionality.


```js
if (oldKeywords === newKeywords) {
          pages++;
        } else if (newKeywords !== oldKeywords) {
          $('.lists').children().remove();
          $('.messsage').remove();
          pages = 1;
        }
      ajaxRequest(newKeywords,pages);
```


Thank you for reviewing the changes. I have updated the defect with this commit.


Part of my intention with this new approach to tag skipping was to make the filters themselves agnostic about particular features of the markup format as possible. We could possibly even move the code block regexps to the markup definitions in `markups.rb` in a similar way. Or do you think that would be overdoing it?


Sure, but a single null comparison is not exactly a lot compared to the amount of work the function itself does.
But you are of course free to make a PR with improved code if you want to, so long as it doesn't complicate things too much. I'd see it as nice-to-have, but not something we need, so since the performance improvement would be very small, the cost in code clarity would need to be very low as well.


That should be a static function of the Utility class.


two cascading tank


regression from commit 2965ddf321a7dd3dab62ef850c54ae8d0f1c0e97 ?


It looks like you are performing some work twice here:
1. Extracting mask processing code.
2. Parsing mask processing code into `Condition`s.
Probably that's ok, though.


@MartyLake: this doesn't revert f397576, and the new state is wrong (why did you remove the check on whether `Projucer_jucer_FILE` is defined?)

The code should be
```
if(NOT DEFINED Projucer_jucer_FILE)
  message(FATAL_ERROR "Projucer_jucer_FILE must be defined")
endif()

get_filename_component(Projucer_jucer_FILE
  "${Projucer_jucer_FILE}" REALPATH
  BASE_DIR "${CMAKE_BINARY_DIR}"
)

if(NOT EXISTS "${Projucer_jucer_FILE}")
  message(FATAL_ERROR "${Projucer_jucer_FILE} must exist")
endif()

get_filename_component(Projucer_jucer_DIR "${Projucer_jucer_FILE}" DIRECTORY)
```


Looks like this option has a misleading name, because we already get the deprecation warnings...


I wanted to test the simpler version first, because testing for cases 2 and 3 is more convoluted. But I have now pushed this test: http://tests.stockfishchess.org/tests/view/5902fb7f0ebc59035df34078


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/5e04fc2b-048a-4fe3-9cab-6419f1ce9bda "mfe-dev-fe"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/d2e8d9ea-7a90-487a-a9cd-c822cc6d9891 "mfe-dev-fe") deployed [mfe-dev-be](https://github.com/ilantoren/mfe-dev-be/releases/tag/deploy-ibm-yp-us-south-MyFavoreats-myfavoreats-20170428-082355 "deploy-ibm-yp-us-south-MyFavoreats-myfavoreats-20170428-082355") to [myfavoreats](https://console.ng.bluemix.net/apps/4a80c652-9946-4627-8e17-db91b70a3998 "ibm:yp:us-south:MyFavoreats:myfavoreats"), including this commit


Hi. I've opend it for PHP 5.4 as well.

https://github.com/econea/nusoap/commit/e186238038f83fa8f235a3241917e8df43b12c11

Are there any things/features you would like to?


这里是不是可以直接 module.exports.cb = sync;


`'urrent-page'` is a typo, isn't it?


Did not investigate but seen that as well. Without investigating but my memory the `static_info_tables_*` extensions "extend" the domain model of the base extension and thus declare the exact same namespace, which is probably just plain wrong since it does not match the extension key.

To be done properly, it should extend the base domain model with a mechanism similar to what EXT:news provides.

I do not use the domain model/repository of `static_info_tables` anyway, I really always do my stuff by querying the DB since I always considered those extensions as only providing static data; and as such, I just don't really care about this warning.

But I cannot assess whether this may cause problems with other extensions, I just hope it won't.


It looks like we could have something like
```
fun InsnList.removeAll(insns: Collection<AbstractInsnNode>) { ... }
```
somewhere in JVM BE utils.
We use it really often.


Hi @cnsnyder. You marked this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1444742 as duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=1444714 and I already fixed it in: https://github.com/candlepin/subscription-manager/pull/1607.

This double check seems OK to me and I only want to clarify it :-).


You can wrap in `Ada.Strings.Fixed.Trim (...'Image..., Left)` to make this more readable.


Minor: I'd probably make VarInsnNode a first parameter (for the sake of uniformity, see next function).
Or even convert it to receiver in both cases.


Yep :+1:


The problem is not the null comparison, it's the initialization function it calls. As I said above, the initialization function should only initialize the needed function, not whole functable, as currently the initialization function is run twice if adler32 is used before deflate. When we want to extend the functable, the current code here goes horribly wrong.


@MartyLake: The quotes around `Jucer2CMake` are not useful, since it's a target name, it cannot contain spaces. `PRIVATE` is enough, since there is no target depending on `Jucer2CMake`.


Hi, it would be possible to handle any iso image, whether it comes from a file or not.  You are using the File constructor of the iso9660filesystem.

 Instead, you could use the DataReference constructor.  You would have to implement a DataReference backed by the existing IdentificationRequest, but this doesn't look hard.  Seems like it just provides an InputStream to the file system, which an IdentificationRequest can already do...


The line #231 also needs to be amended.


Ah, this is way better.


By convention we just prefix such identifiers with two underscores, e.g. `__gnat_get_secondary_stack`.
(I guess the double instead of single underscore is needed to avoid clashes with subprograms imported from other languages, e.g. C; and the trailing underscore is redundant anyway.)


@selvanair, that's a commit message for first version which indeed did not revert the value back.

@selvanair, @dsommers, please review this https://github.com/ValdikSS/openvpn-with-patches/commit/fbdacadcd27c3102fda8f23c0d8626d1bf1ba06e


Typo: s/thet/the/


+    @Override
+    public abstract void removeHeader(String name) throws MessagingException;
+
+    @Override
+    public abstract void setBody(Body body) throws MessagingException;
+
     public abstract long getId();

     public abstract String getPreview()


el*i*miniation, not el*u*mination


Hello!

This conflicts with the next option for --port. Will you fix this in your branch? Create a PR? Thanks! 👍


Minor: formatting


ic void setEncoding(String encoding) throws MessagingException {
-        mEncoding  = encoding;
+        if (mEncoding != null && mEncoding.equalsIgnoreCase(encoding)) {
+            return;
+        }
+
+        // The encoding changed, so we need to convert the message
+        if (!MimeUtil.ENC_8BIT.equalsIgnoreCase(mEncoding)) {
+            throw new RuntimeException("Can't convert from encoding: " + mEncoding);
+        }
+
+        try {
+            File newFile = File.createTempFile("body", null, mTempDirectory);
+            OutputStream out = new FileOutputStream(newFile);
+            try {
+                if (MimeUtil.ENC_QUOTED_PRINTABLE.equals(encoding)) {
+                    out = new QuotedPrintableOutputStream(out, false);
+                } else if (MimeUtil.ENC_BASE64.equals(encoding)) {
+                    out = new Base64OutputStream(out);
+                } else {
+                    throw new RuntimeException("Target encoding not supported: " + encoding);
+                }
+
+                InputStream in = getInputStream();
+                try {
+                    IOUtils.copy(in, out);
+                } finally {
+                    in.close();
+                }
+            } finally {
+                out.close();
+            }
+
+            mFile = newFile;
+            mEncoding = encoding;
+        } catch (IOException e) {
+            throw new MessagingException("Unable to convert body", e);


On the first iteration this test is not needed (because both case_statement and case_expression in Ada must have at least one alternative). Incidentally, I recently fixed this in gnat2why, see:
https://github.com/AdaCore/spark2014/commit/f3876cb92364cd76ed7d2134c815842b9defd360


Without this option enabled compilation always fails for deprecated widgets here, instead of **only** warning about.
A better name would be '--disable--deprecated-warnings' (non default), which is the same like --disable-compile in this case ;-)


:+1:

Still have a lot to learn I guesse ! ^^


Don't we depend on all boost::* at the moment?


"not Present (X)" = "Empty (X)"; the latter is shorter and more readable.


Hi, Are you there now?


@mkonicek I'm having trouble getting this working. In the case where I'm passing an image source with an array of images, where do I put the headers?  I assumed I should put one `headers` prop for each image uri in the array.  But that doesn't seem to be working.  Looking at this code it seems that the `source` prop should have headers in the array, next to the images like this:

    <Image source=[{uri: foo}, {uri: bar}, {headers: headers}] ...

Which doesn't look right.


Similar to case_expressions, in enumeration_type_definition the first enumeration_literal_specification is always present. A trivial refactoring will remove useless test on the first iteration.


Release version 2.0.7 with this update.


I should probably add redo to the GUI - it would only apply to the current migration correct? i.e where "Current" would get displayed on the migration list


No, we are selectively using the current required ones and agreed to not extend the dependency on more what we can solve ourselves (i.e. file operations).


Try to throw exception before await Task.Delay(0);


Is Set<BoolExpr> an apropriate return type? It should also be possible to get just one combined BoolExpr...


I really don't see a big problem with people using adler and then running deflate initialize. If you think it is that big of a problem, then we could have a null check in deflateinitialize as well.
I see no reason to split up functableinit now however, it is not that expensive. And running separate functions to do the same from deflateinit would be more expensive (not considering forced inlining), and doing on-demand initialization would surely be even more expensive. Unless we start doing some expensive stuff in functableinit, I see no reason to preemptively optimize that.


IT's also works :)


Hardcoding the 32-bit width of enumeration literals here (and in the following line?) is most likely wrong. If you need something quick, then please make it a named constant. If you want to make it correct, then use Esize/RM_Size of the corresponding enumeration type.


@lasseebert my bad, didn't notice the PR! Completely understand your concerns.


я понимаю, но такие значения в макете


Here also 32-bit is wrong. For example, you can have something like `type T is (A,B,C) with Size => 4;`


Still can not catch.


I suggest changing the suffix to `_Counter`.


Should be named 3.4.6


Исправила замечания в [новом коммите](https://github.com/rureggaeton/ooopproject/commit/828f927a74ae161a83422658901f2731d93818fe)


Right, OK that seems to be because all the values declared in the mmap_attr_t enum type are unsigned so it looks like the compiler chooses to represent `attr` as an unsigned type here, and thus the comparison at line 365 is always true, as you said. I would have expected the compiler to flag this kind of error...

Thanks for reporting this bug. I'll work on a fix.


dmmm


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.424.b4293ff90ed40cd1a6bb10d452ce7bf3c13a8a18](http://build.palaso.org/viewLog.html?buildId=89140&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 950, ignored: 51 Build time: 00:45:12


If you do lazy initialization, you can remove the functable initialization from deflate initialization completely. This speeds up programs that use deflate more than once and also allows optimized functions to be used when inflate is used before deflate. Like I said, first time each functable member is used, the correct alternative is chosen and the initialization stub is replaced with it in the functable.


Не стала убирать доступ по индексу, но для перебора [добавила итератор](https://github.com/rureggaeton/ooopproject/commit/828f927a74ae161a83422658901f2731d93818fe)


Yes, I understand that it is the most important to have good values for low depths and so I experiment a little...
Also, tuned values converged to zero for d < 3. Probably ck=5 was to high there.


zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz


```
class Program
{
  static void Main(string[] args)
  {
	 GoAsync();
	 Console.ReadLine();
  }

  static async Task GoAsync()
  {
	 using (var container = new WindsorContainer())
	 {
		container.Register(
		   Component.For<MyInterceptor>().LifestyleTransient(),
		   Component.For<MyTester>().Interceptors<MyInterceptor>().LifestyleTransient()
		);

		var tester = container.Resolve<MyTester>();
		await tester.Test();
	 }
  }
}

public class MyTester
{
  public virtual async Task<int> Test()
  {
	 throw new NotImplementedException();
	 await Task.Delay(0);
  }
}

public class MyInterceptor : IInterceptor
{
  public async void Intercept(IInvocation invocation)
  {
	 try
	 {
		invocation.Proceed();
	 }
	 catch (Exception e)
	 {
		// The exception is never caught here!
		var x = 10;
		throw;
	 }

	 try
	 {
		await (Task)invocation.ReturnValue;
	 }
	 catch (Exception e)
	 {
		// The exception can caught here!
		var y = 10;
		throw;
	 }

  }
}
```


Fixing the build by pinning the version of NugetPackageVerfiier in https://github.com/aspnet/Coherence-Signed/pull/477. Please revert the version pinning when this is fixed.


isn't there an upstream / official repo for this one ?


Like I said, you are still welcome to make a PR that can be reviewed.


I'm a bit hesitant about this. I think the original method names `extract` and `process` form a clear interface for filters, where the idea is that it is okay to override them. Whereas now, if you override `do_extract` or `do_process`, all of a sudden you start missing the skip logic. What about keeping the original methods (and filter structure), and determining whether a filter should be skipped in the main loop that calls the whole filter chain?


@liewegas
Yes!
I created a commit (https://github.com/myoungwon/ceph/commit/7b322975bec00c16f2c32c085e9961f47aee2098) for step 2 (a rados op to create a redirect).
It would be great if you give me comments.


請改回com.xavier.finit


I thought the policy was to automatically reject PRs that essentially revert commits made by other contributors... Complete rewrite is essentially same as revert or rewind.


redundant?


改回
versionCode 4
versionName "1.0.4"


加回來 不應該delete掉


加回來


Comment on 3fc4b860e0a2c17819934d678decacd914271e5c.

An issue is here!


Here in line 4, there's a spelling mistake!


Comment on 3fc4b860e0a2c17819934d678decacd914271e5c, file READMENOT.md, line 4.

Oh, this'll end up below!!


Comment on 3fc4b860e0a2c17819934d678decacd914271e5c, file README.md, line 8.

Oh, this'll too end up below!!


I has catched it in unit tests.
I suppose that our situation is a bit more complicated. There are an inner interceptor (AuthorizationInterceptor) which throws exception. Can you try this?

BTW, It's very strange that you made intercept method async. As I know Castle Windsor does not support it. Also, making async methods void should be avoided normally.


改回來，我們已經上架google play，id就是com.xavier.finit，無法再改


The call to `Etype` gives you an `Entity_Id`, not just the `Node_Id`. The same two lines below.

Think about `Entity_Id` as inheriting from the `Node_Id` base class (i.e. every entity is a node, but not all nodes are entities). In C++ you would not cast the result of Etype to a base class here.

Unfortunately, this is impossible to enforce, either statically or at runtime, by the Ada subset allowed in the front end. We tried better in gnat2why, where like in gnat2goto full Ada 2012 is allowed, but our attempts are annoying to adopt. Apparently we just need to pay attention ourselves.


改回來


Honestly, this may be overdoing it as you say. If people want a filter to behave differently when it comes to parsing tags, they are free to either monkeypatch the `process` or `extract` method of that filter, of swap out the filter for a custom one. Our job is to make sure the docs are clear on how to do that.


en werkt het vandaag nog?


敢问大哥这个0.5是什么黑科技？


it's not obvious that it disables export. Does it disable friend modules import as well despite of specified friendModules ?


naou toe


hello, I think we could use pre existing functions like
void set_value(float val, out float outval)
{
	outval = val;
}

void set_rgba(vec4 col, out vec4 outcol)
{
	outcol = col;
}


Porque no incrementas ya el valor que te pasa lex?


important commit ;)


There's a rogue `]` here.


I don't understand what you mean by:

> Because sometimes we only want to commit some but not all of the files that are modified in one commit.

If you want to commit some files, you should only add those files to the commit index. lint-staged will only execute tasks on these files.

How would you like to modify this? In order to do what? There is https://github.com/okonet/lint-staged/issues/150 where you can add your input. Here is a bad place to discuss.


OneSignal被刪掉的部分請加回來


- also made potential fix (untested) for solving scrolling with mouse wheel not working on Mac


Try this:

````C#
using System;
using System.Threading.Tasks;
using Castle.DynamicProxy;
using Castle.MicroKernel.Registration;
using Castle.Windsor;

namespace ConsoleApp6
{
    class Program
    {
        static void Main(string[] args)
        {
            GoAsync();
            Console.ReadLine();
        }

        static async Task GoAsync()
        {
            using (var container = new WindsorContainer())
            {
                container.Register(
                    Component.For<MyInterceptor>().LifestyleTransient(),
                    Component.For<MyInterceptor2>().LifestyleTransient(),
                    Component.For<MyTester>().Interceptors<MyInterceptor, MyInterceptor2>().LifestyleTransient()
                );

                var tester = container.Resolve<MyTester>();
                await tester.Test();
            }
        }
    }

    public class MyTester
    {
        public virtual async Task<int> Test()
        {
            await Task.Delay(0);
            return 42;
        }
    }

    public class MyInterceptor : IInterceptor
    {
        public void Intercept(IInvocation invocation)
        {
            try
            {
                invocation.Proceed();
            }
            catch (Exception e)
            {
                // The exception is never caught here!
                var x = 10;
                throw;
            }
        }
    }

    public class MyInterceptor2 : IInterceptor
    {
        public void Intercept(IInvocation invocation)
        {
            throw new Exception("Test exception!!!");
            invocation.Proceed();
        }
    }
}
````


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/7aa8d4f5-ff2c-4bc0-816e-e8c12ec5e984 "Weather"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/f1c09393-28c4-402b-b09e-f2ab981cb756 "Weather") deployed [Weather](https://github.com/pradeep-b/Weather/releases/tag/deploy-ibm-yp-us-south-PradeepB-staging-20170428-085744 "deploy-ibm-yp-us-south-PradeepB-staging-20170428-085744") to [staging](https://console.ng.bluemix.net/apps/774c2c5c-179f-4643-b718-897fc77600f8 "ibm:yp:us-south:PradeepB:staging"), including this commit


do we still have rhino?


There is no such policy, but there has to be a good reason to do so. Currently, I am not so sure there is one, but without benchmarks, there is no way of knowing.
Last time I looked at what you are now suggesting, I did not care for it, but without actual code..
I still don't see any actual problem with the current code, so without any demonstration of an alternative, there is also no decision to make.


Please don't use `0` when you really mean `Empty`.

In typical application `Node_Id` would be a private type and `Empty` would be a private constant, so your code would not compile. In GNAT, AFAIU, `Node_Id` and similar types (e.g. `Name_Id`) are public to avoid problems with inter-dependencies between packages with the "basic" type definitions.


@KostyaSha Thanks! I got the same feedback in the private PR, but this was a late addition so I decided not to trigger (and wait for) all the builds again.


![Április 28. - Péntek](http://ujlipot.vakvarju.com/data/napimenu/24.jpg?v=1493364819)
Húsleves gazdagon
Cheddar sajtos csirkemellel töltött tortilla friss kevert salátával
Somlói galuska


Not a simplification. Please use [0..4] :-)


改回來


@maff: please use also respect the `REDIRECT_` [prefix](http://stackoverflow.com/questions/3050444/when-setting-environment-variables-in-apache-rewriterule-directives-what-causes).

```php
$projectRoot = getenv('PIMOCORE_PROJECT_ROOT') ?: getenv('REDIRECT_PIMOCORE_PROJECT_ROOT') ?: realpath(__DIR__ . '/../..'));

```


Does this error mean something different than the above one? In particular, shouldn't they both throw the same status vector, either (isc_rec_in_limbo) or (isc_trainlim + isc_rec_in_limbo)?


если оставишь див без высоты - он будет по размерам контента, ставишь высоту картинке и получаешь нужный резалт + кое-что про переполнение(попозже покажу)


ошибка дизайнера, привыкай


**Whoops!**

There were *34 warnings* that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

**WARNINGS**
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L8`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L8) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L48`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L48) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L59`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L59) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L78`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L78) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L129`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L129) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L130`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L130) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L131`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L131) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L138`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L138) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L382`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L382) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L420`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L420) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L421`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L421) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L422`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L422) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L423`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L423) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L424`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L424) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L425`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L425) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L426`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L426) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L427`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L427) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L431`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L431) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L432`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L432) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L433`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L433) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L434`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L434) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L435`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L435) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L436`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L436) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L437`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L437) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L438`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L438) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L440`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L440) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L444`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L444) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L445`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L445) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L446`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L446) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L447`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L447) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L472`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L472) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L473`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L473) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L482`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L482) - Line must be at most 100 characters
[`src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L485`](https://github.com/Google/WebFundamentals/blame/782a607b61e37db54877fe8ca53bfd75ce74f9a5/src/content/en/updates/2015/07/interact-with-ble-devices-on-the-web.md#L485) - Line must be at most 100 characters


Oh... indeed. How come our CI didn't catch that? Shouldn't it error during doc generation?


Shows the Radio station name as the artist instead of NULL, this allows for nicer LCD implementations from within Node JS as opposed to running unmanaged python scripts.


One problem with this change is that we have two files named `contributing.md` and `CONTRIBUTING.md` in the root of the source tree. Unfortunately, file systems that are case-insensitive by default, such as HFS+ on macOS, get confused because of this. :/

How about if we either rename `CONTRIBUTING.md` back to `CONTRIBUTING` or rename `contributing.md` to `contribute.md`? The former might be the safer change since the latter changes the URL of a page on the site and may result in dead links.


不該有兩個CodePushDeploymentKey


It can be run for any version that's been migrated. It defaults to the latest but accepts a version param..


Looks like php7 is not considered a sys target for dox: https://github.com/HaxeFoundation/dox/blob/master/gen/ImportAll.hx#L6

That's probably why the package is never explored.


gambas


I suggest to refactor repeated calls to `Component_List`, e.g.

  `Components : constant Node_Id := Component_List (N);`.


Err, this commit actually performs the _exact opposite_ of what the commit title says. woops


Thanks for your quick answer


Trim


Принято сначала указывать связь с промежуточной таблицей, а затем уже `has_many :through`, чтобы было последовательно и очевидно откуда взялась промежуточная связь


`__anonymous_type` ?


Смотри, одна из прелестей Виртуса — он всё конвертирует «сам». То есть строки 26-27 если ты уберёшь — то год всё равно будет целым, рейтинг — дробью и т.д.

Можно добиться того же для полей вида «строка через запятую», для этого надо определить свой типа аттрибута новый: https://github.com/solnic/virtus#custom-coercions

В этом же вся прелесть — декларативно ровно в одном месте определить «что лежит в том аттрибуте» и больше об этом уже не думать.


Not sure i completely got you. Intentions was:
- remove (absulotely wrong) isc_deadlock
- leave isc_trainlim for backward compatibility
- add info about conflicting transaction


Нельзя укзаать связь `has_many :through`, не указав has_many для промежуточной таблицы


`Unbounded_String` is default-initialized to `""` (just like containers are default-initialized as empty); I suggest to remove equivalent explicit initialization.


C#TCP客户端


`Append (Variant_Name, ...)` (because it is more readable and more efficient.


Did you really mean to leave the var_dump line in ?


Yes, it runs, URLError is a part of urllib2


Yes.


closes #11


Just testing you..


@solverat see https://github.com/pimcore/pimcore/commit/e2d8368252f3147a29843562097f47b59c806534


Why on earth does systemd re-implement rm??? No, I don't even want to know :nauseated_face:


Removed now: https://github.com/cubecart/v6/commit/3425f548d3c9edf8db7f4cb8f5811226216f2d21


Comment on 3fc4b860e0a2c17819934d678decacd914271e5c.

An issue is here!


Here in line 4, there's a spelling mistake!


Comment on 3fc4b860e0a2c17819934d678decacd914271e5c, file READMENOT.md, line 4.

Oh, this'll end up below!!


Comment on 3fc4b860e0a2c17819934d678decacd914271e5c, file README.md, line 8.

Oh, this'll too end up below!!


Didn't get much sleep last night will ill child... that's my excuse.


To Read the full version of Technical report
https://drive.google.com/file/d/0B4ZM08EYSoN4SFotQkt4RHdtTEE/view?usp=sharing


No, sorry. I wrote analog tool on golang


open this https://free-s-s-s-s.arukascloud.io/
#18


Fair enough. Once things start working nicely, I'd suggest you look at how Forge handles Biomes in order to have better mod integration. It would be neat to have mod integration built in and whatnot.


Donc TEST 2

Avec pages.php avec :
```
$PAGES['admin.php?op=adminStory']['title']=""; // obligatoirement à vide
$PAGES['admin.php?op=adminStory']['blocs']="0";
$PAGES['admin.php?op=adminStory']['run']="yes";
$PAGES['admin.php?op=adminStory']['TinyMce']='1';
$PAGES['admin.php?op=adminStory']['TinyMce-theme']="full";
$PAGES['admin.php?op=adminStory']['css']="admin.css+";
$PAGES['admin.php?op=adminStory']['TinyMceRelurl']="false";

$PAGES['admin.php?op=Edito_load']['title']=""; // obligatoirement à vide
$PAGES['admin.php?op=Edito_load']['blocs']="0";
$PAGES['admin.php?op=Edito_load']['run']="yes";
$PAGES['admin.php?op=Edito_load']['TinyMce']='1';
$PAGES['admin.php?op=Edito_load']['TinyMce-theme']="full";
$PAGES['admin.php?op=Edito_load']['css']="admin.css+";
$PAGES['admin.php?op=Edito_load']['TinyMceRelurl']="false";

// admin why charge the tiny on each admin page 360k !! ??
$PAGES['admin.php']['title']=""; // obligatoirement à vide
$PAGES['admin.php']['blocs']="0";
$PAGES['admin.php']['run']="yes";
$PAGES['admin.php']['css']="admin.css+";
```

Et le header.php avec :
```
   global $tiny_mce,$tiny_mce_theme,$tiny_mce_relurl;
   if ($tiny_mce) {
      if (array_key_exists($pages_ref,$PAGES)) {
         if (isset($PAGES[$pages_ref]['TinyMce']) || array_key_exists('TinyMce',$PAGES[$pages_ref]) )  {
            $tiny_mce_init=true;
            if (array_key_exists('TinyMce-theme',$PAGES[$pages_ref]))
               $tiny_mce_theme=$PAGES[$pages_ref]['TinyMce-theme'];
            if (array_key_exists('TinyMceRelurl',$PAGES[$pages_ref]))
               $tiny_mce_relurl=$PAGES[$pages_ref]['TinyMceRelurl'];
         } else {
            $tiny_mce_init=false;
            $tiny_mce=false;
         }
      } else {
         $tiny_mce_init=false;
         $tiny_mce=false;
      }
   } else {
      $tiny_mce_init=false;
   }
```

Et pour checker dans le header_after.inc
```
echo '<div class="alert alert-success" role="alert">Pages_Ref : '. $pages_ref.' TinyMce :'.$PAGES[$pages_ref]['TinyMce'].'tinymce-init : '.$tiny_mce_init.'<br />';
print_r($PAGES[$pages_ref]);
echo '</div>';
```
----------------------------------------------------------------
Le resultat est :
http://jireck.free.fr/admin.php?op=adminStory ==> tinymce chargé
http://jireck.free.fr/admin.php ==> tinymce **PAS** chargé
http://jireck.free.fr/admin.php?op=Edito_load ==> tinymce chargé

et  url non mis dans pages.php
http://jireck.free.fr/admin.php?op=MaintForumAdmin ==> tinymce **PAS** chargé
et le  $pages_ref est egale à admin.php

---------------------------------

Donc en declarant dans pages.php (pour l'admin), Toutes les url admin.php?Op=xxx avec tinymce ca devrait etre bon


Looking good! One suggestion for you - instead of this:

`

 +
`

try this:

`<div style="margin-top: 200px">`


s/response/request


Oh. Never seen any breakages when building .deb packages...


So, although the recipe.yaml was updated for reboot patch, but the reboot patch itself still does not work on N3DS, cause of the 11.4 changes on firmlaunch


hva med `if req.Type() == sip.MsgReqCheckin` isteden?


Sorry about that, I was in the middle of including a specific file for logging the interpreter when it enters files. I was having a faff getting the client to stop complaining about the file download and didn't get around to adding the fixed version.


Actually, mypy supports this if you use the version form github master (it was added beginning of March, a week after previous release):
```python
async def g() -> AsyncIterator[bytes]:
    yield 'no way'  # error:  Incompatible types in yield (actual type "str", expected type "bytes")
```


@dkager


I see...
I removed the `]` in ab7c9b32b16bc394ee870d11086e08b05ab507fe.


Ah, I've just updated parts of the German translation at Transifex, but that was probably just after you made this commit. ;-)


Weird


My point was about #2 from your list. Should isc_trainlim be really used in line 5814/5816, in your opinion? If it's incorrect / redundant but preserved just for backward compatibility, then it's ok. If its usage is valid, then shouldn't the first place also raise isc_trainlim before isc_rec_in_limbo, just to be consistent?


`hdr_dom(host) -m reg <regexp>` doesn't work, hdr_dom is already like an alias for `hdr(host) -m dom`.


Children (especially ill ones) will do that for you !  Great to have this fixed though


Annexe pour info si on pars a la chasse au notice, y'en a pleins


Thanks! I will update translations again a bit later, all your translations will be included in version 6.1


Mh, only `integration.pro/integration/pro/ProTests.java` will ever be executed on the module-path, right?

I'll open a new issue for discussion. :)


Done in master.


WARNING: [ContentDescription] [Accessibility] Missing `contentDescription` attribute on image
 Non-textual widgets like ImageViews and ImageButtons should use the `contentDescription` attribute to specify a textual description of the widget such that screen readers and other accessibility tools can adequately describe the user interface.

Note that elements in application screens that are purely decorative and do not provide any content or enable a user action should not have accessibility content descriptions. In this case, just suppress the lint warning with a tools:ignore="ContentDescription" attribute.

Note that for text fields, you should not set both the `hint` and the `contentDescription` attributes since the hint will never be shown. Just set the `hint`. See http://developer.android.com/guide/topics/ui/accessibility/checklist.html#special-cases.


WARNING: [RtlHardcoded] Consider adding `android:layout_marginStart="@dimen/dp_10"` to better support right-to-left layouts
 Using `Gravity#LEFT` and `Gravity#RIGHT` can lead to problems when a layout is rendered in locales where text flows from right to left. Use `Gravity#START` and `Gravity#END` instead. Similarly, in XML `gravity` and `layout_gravity` attributes, use `start` rather than `left`.

For XML attributes such as paddingLeft and `layout_marginLeft`, use `paddingStart` and `layout_marginStart`. *NOTE*: If your `minSdkVersion` is less than 17, you should add *both* the older left/right attributes *as well as* the new start/right attributes. On older platforms, where RTL is not supported and the start/right attributes are unknown and therefore ignored, you need the older left/right attributes. There is a separate lint check which catches that type of error.

(Note: For `Gravity#LEFT` and `Gravity#START`, you can use these constants even when targeting older platforms, because the `start` bitmask is a superset of the `left` bitmask. Therefore, you can use `gravity="start"` rather than `gravity="left|start"`.)


WARNING: [RtlHardcoded] Use "`end`" instead of "`right`" to ensure correct behavior in right-to-left locales
 Using `Gravity#LEFT` and `Gravity#RIGHT` can lead to problems when a layout is rendered in locales where text flows from right to left. Use `Gravity#START` and `Gravity#END` instead. Similarly, in XML `gravity` and `layout_gravity` attributes, use `start` rather than `left`.

For XML attributes such as paddingLeft and `layout_marginLeft`, use `paddingStart` and `layout_marginStart`. *NOTE*: If your `minSdkVersion` is less than 17, you should add *both* the older left/right attributes *as well as* the new start/right attributes. On older platforms, where RTL is not supported and the start/right attributes are unknown and therefore ignored, you need the older left/right attributes. There is a separate lint check which catches that type of error.

(Note: For `Gravity#LEFT` and `Gravity#START`, you can use these constants even when targeting older platforms, because the `start` bitmask is a superset of the `left` bitmask. Therefore, you can use `gravity="start"` rather than `gravity="left|start"`.)


WARNING: [RtlHardcoded] Consider adding `android:layout_marginStart="@dimen/dp_5"` to better support right-to-left layouts
 Using `Gravity#LEFT` and `Gravity#RIGHT` can lead to problems when a layout is rendered in locales where text flows from right to left. Use `Gravity#START` and `Gravity#END` instead. Similarly, in XML `gravity` and `layout_gravity` attributes, use `start` rather than `left`.

For XML attributes such as paddingLeft and `layout_marginLeft`, use `paddingStart` and `layout_marginStart`. *NOTE*: If your `minSdkVersion` is less than 17, you should add *both* the older left/right attributes *as well as* the new start/right attributes. On older platforms, where RTL is not supported and the start/right attributes are unknown and therefore ignored, you need the older left/right attributes. There is a separate lint check which catches that type of error.

(Note: For `Gravity#LEFT` and `Gravity#START`, you can use these constants even when targeting older platforms, because the `start` bitmask is a superset of the `left` bitmask. Therefore, you can use `gravity="start"` rather than `gravity="left|start"`.)