[inst/examples/graph/server.R:10:7:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/inst/examples/graph/server.R#L10) *style:* **Place a space before left parenthesis, except in a function call.**
```r
    if(v == "Labels") v <- V(LeMis)$label
      ^
```
[inst/examples/scatterplot/server.R:10:5:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/inst/examples/scatterplot/server.R#L10) *style:* **Variable or function name should be snake_case.**
```r
    num.ticks <- input$nticks
    ^~~~~~~~~
```
[inst/examples/scatterplot/server.R:11:25:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/inst/examples/scatterplot/server.R#L11) *style:* **Variable or function name should be snake_case.**
```r
    if (num.ticks == 0) num.ticks <- NULL
                        ^~~~~~~~~
```
[inst/examples/scatterplot/server.R:12:10:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/inst/examples/scatterplot/server.R#L12) *style:* **Variable or function name should be snake_case.**
```r
    else num.ticks <- rep(num.ticks, 3)
         ^~~~~~~~~
```
[R/globe.R:158:3:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/globe.R#L158) *style:* **Variable or function name should be snake_case.**
```r
  arcsColor="#99aaff",
  ^~~~~~~~~
```
[R/globe.R:159:3:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/globe.R#L159) *style:* **Variable or function name should be snake_case.**
```r
  arcsHeight=0.4,
  ^~~~~~~~~~
```
[R/globe.R:160:3:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/globe.R#L160) *style:* **Variable or function name should be snake_case.**
```r
  arcsLwd=1,
  ^~~~~~~
```
[R/globe.R:161:3:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/globe.R#L161) *style:* **Variable or function name should be snake_case.**
```r
  arcsOpacity=0.2,
  ^~~~~~~~~~~
```
[R/globe.R:200:3:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/globe.R#L200) *style:* **Variable or function name should be snake_case.**
```r
  arcsHeight <- max(min(arcsHeight, 1), 0.2)
  ^~~~~~~~~~
```
[R/globe.R:201:3:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/globe.R#L201) *style:* **Variable or function name should be snake_case.**
```r
  arcsOpacity <- max(min(arcsOpacity, 1), 0)
  ^~~~~~~~~~~
```
[R/globe.R:239:1:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/globe.R#L239) *style:* **Variable or function name should be snake_case.**
```r
globeOutput <- function(outputId, width = "100%", height = "600px") {
^~~~~~~~~~~
```
[R/globe.R:239:25:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/globe.R#L239) *style:* **Variable or function name should be snake_case.**
```r
globeOutput <- function(outputId, width = "100%", height = "600px") {
                        ^~~~~~~~
```
[R/globe.R:246:1:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/globe.R#L246) *style:* **Variable or function name should be snake_case.**
```r
renderGlobe <- function(expr, env = parent.frame(), quoted = FALSE) {
^~~~~~~~~~~
```
[R/graph.R:68:1:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L68) *style:* **Lines should not be more than 130 characters.**
```r
#' \item{}{ optional a single igraph object with the same number of vertices as \code{g} above (if specified this must be the first entry)}
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/graph.R:72:1:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L72) *style:* **Lines should not be more than 130 characters.**
```r
#' \item{cumulative}{ - optional boolean entry, if \code{TRUE} then vertex positions are added to current plot, default is \code{FALSE}}
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/graph.R:144:21:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L144) *style:* **Variable or function name should be snake_case.**
```r
                    vertex.color, vertex.size, vertex.shape, vertex.label,
                    ^~~~~~~~~~~~
```
[R/graph.R:144:35:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L144) *style:* **Variable or function name should be snake_case.**
```r
                    vertex.color, vertex.size, vertex.shape, vertex.label,
                                  ^~~~~~~~~~~
```
[R/graph.R:144:48:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L144) *style:* **Variable or function name should be snake_case.**
```r
                    vertex.color, vertex.size, vertex.shape, vertex.label,
                                               ^~~~~~~~~~~~
```
[R/graph.R:144:62:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L144) *style:* **Variable or function name should be snake_case.**
```r
                    vertex.color, vertex.size, vertex.shape, vertex.label,
                                                             ^~~~~~~~~~~~
```
[R/graph.R:145:21:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L145) *style:* **Variable or function name should be snake_case.**
```r
                    edge.color, edge.width, edge.alpha,
                    ^~~~~~~~~~
```
[R/graph.R:145:33:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L145) *style:* **Variable or function name should be snake_case.**
```r
                    edge.color, edge.width, edge.alpha,
                                ^~~~~~~~~~
```
[R/graph.R:145:45:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L145) *style:* **Variable or function name should be snake_case.**
```r
                    edge.color, edge.width, edge.alpha,
                                            ^~~~~~~~~~
```
[R/graph.R:155:30:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L155) *style:* **Variable or function name should be snake_case.**
```r
    if (missing(edge.color)) edge.color <- lapply(g, function(x) {
                             ^~~~~~~~~~
```
[R/graph.R:163:32:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L163) *style:* **Variable or function name should be snake_case.**
```r
    if (missing(vertex.color)) vertex.color <- lapply(g, function(x) ifel(is.null(V(x)$color), "orange", V(x)$color))
                               ^~~~~~~~~~~~
```
[R/graph.R:174:32:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L174) *style:* **Variable or function name should be snake_case.**
```r
    if (missing(vertex.color)) vertex.color <- list(ifel(is.null(V(g)$color), "orange", V(g)$color))
                               ^~~~~~~~~~~~
```
[R/graph.R:175:30:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L175) *style:* **Variable or function name should be snake_case.**
```r
    if (missing(edge.color)) edge.color <- ifel(is.null(E(g)$color), NA, E(g)$color)
                             ^~~~~~~~~~
```
[R/graph.R:178:29:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L178) *style:* **Variable or function name should be snake_case.**
```r
  if (missing(vertex.size)) vertex.size <- ifel(is.null(V(g)$size), 2, V(g)$size / 7)
                            ^~~~~~~~~~~
```
[R/graph.R:179:30:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L179) *style:* **Variable or function name should be snake_case.**
```r
  if (missing(vertex.shape)) vertex.shape <- ifel(is.null(V(g)$shape), "circle", V(g)$shape)
                             ^~~~~~~~~~~~
```
[R/graph.R:180:30:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L180) *style:* **Variable or function name should be snake_case.**
```r
  if (missing(vertex.label)) vertex.label <- ifel(is.null(V(g)$label), NA, V(g)$label)
                             ^~~~~~~~~~~~
```
[R/graph.R:181:28:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L181) *style:* **Variable or function name should be snake_case.**
```r
  if (missing(edge.width)) edge.width <- ifel(is.null(E(g)$width), 1, E(g)$width)
                           ^~~~~~~~~~
```
[R/graph.R:185:5:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L185) *style:* **Variable or function name should be snake_case.**
```r
    edge.width <- edge.width[1]
    ^~~~~~~~~~
```
[R/graph.R:189:30:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L189) *style:* **Variable or function name should be snake_case.**
```r
    if (length(E(g)) > 1000) edge.alpha <- 0.3
                             ^~~~~~~~~~
```
[R/graph.R:190:10:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L190) *style:* **Variable or function name should be snake_case.**
```r
    else edge.alpha <- 1
         ^~~~~~~~~~
```
[R/graph.R:191:31:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/graph.R#L191) *style:* **Variable or function name should be snake_case.**
```r
    if (!is.null(E(g)$alpha)) edge.alpha <- E(g)$alpha
                              ^~~~~~~~~~
```
[R/scatterplot.R:180:3:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L180) *style:* **Variable or function name should be snake_case.**
```r
  num.ticks = c(6, 6, 6),
  ^~~~~~~~~
```
[R/scatterplot.R:181:3:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L181) *style:* **Variable or function name should be snake_case.**
```r
  x.ticklabs = NULL,
  ^~~~~~~~~~
```
[R/scatterplot.R:182:3:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L182) *style:* **Variable or function name should be snake_case.**
```r
  y.ticklabs = NULL,
  ^~~~~~~~~~
```
[R/scatterplot.R:183:3:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L183) *style:* **Variable or function name should be snake_case.**
```r
  z.ticklabs = NULL,
  ^~~~~~~~~~
```
[R/scatterplot.R:187:3:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L187) *style:* **Variable or function name should be snake_case.**
```r
  flip.y = TRUE,
  ^~~~~~
```
[R/scatterplot.R:192:3:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L192) *style:* **Variable or function name should be snake_case.**
```r
  cex.symbols = 1,
  ^~~~~~~~~~~
```
[R/scatterplot.R:242:27:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L242) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  x <- lapply(x, function (y) y[, c(1, 3, 2), drop=FALSE])
                          ^
```
[R/scatterplot.R:246:13:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L246) *style:* **Variable or function name should be snake_case.**
```r
    options$axisLabels <- colnames(x[[1]])[1:3]
            ^~~~~~~~~~
```
[R/scatterplot.R:267:30:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L267) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  x <- lapply(x, function(x) (x[, 1:3, drop=FALSE] - rep(mn, each = n)) / (rep(mx - mn, each = n)))
                             ^
```
[R/scatterplot.R:287:49:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L287) *style:* **Remove spaces before the left parenthesis in a function call.**
```r
  x <- lapply(x, function(y) as.vector(t(signif (y, signif))))
                                                ^
```
[R/scatterplot.R:294:5:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L294) *style:* **Variable or function name should be snake_case.**
```r
    num.ticks <- pmax(1, num.ticks[c(1, 3, 2)])
    ^~~~~~~~~
```
[R/scatterplot.R:350:3:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L350) *style:* **Variable or function name should be snake_case.**
```r
  N <- length(options$from) - length(options$vertices)
  ^
```
[R/scatterplot.R:357:5:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L357) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if(!is.null(options$options) && options$options) return(options)
    ^
```
[R/scatterplot.R:415:3:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L415) *style:* **Variable or function name should be snake_case.**
```r
  N <- nrow(e$x)
  ^
```
[R/scatterplot.R:421:3:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L421) *style:* **Variable or function name should be snake_case.**
```r
  M <- nrow(n$x)
  ^
```
[R/scatterplot.R:446:1:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L446) *style:* **Lines should not be more than 130 characters.**
```r
#' @param color Either a single color value or vector of values as long as \code{from} of line colors; line colors default to interpolating their vertex point colors.
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/scatterplot.R:479:1:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L479) *style:* **Variable or function name should be snake_case.**
```r
scatterplotThreeOutput <- function(outputId, width="100%", height="500px") {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/scatterplot.R:479:36:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L479) *style:* **Variable or function name should be snake_case.**
```r
scatterplotThreeOutput <- function(outputId, width="100%", height="500px") {
                                   ^~~~~~~~
```
[R/scatterplot.R:485:1:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/R/scatterplot.R#L485) *style:* **Variable or function name should be snake_case.**
```r
renderScatterplotThree <- function(expr, env = parent.frame(), quoted = FALSE) {
^~~~~~~~~~~~~~~~~~~~~~
```
[tests/threejs.R:3:1:](https://github.com/bwlewis/rthreejs/blob/d25d0e4d8bbc286d215619264207f5921e9c5ccc/tests/threejs.R#L3) *style:* **Variable or function name should be snake_case.**
```r
N <- 100
^
```


Hey Kent! I'm not remotely joking when I get effusive about your checking-in rate... Keep it up fella! But, honestly...
That funky while loop that failed and then turned into a for... with an if... with a break... 🙀


check words in one string in another string

can be improved


Please fix the issue


test commit


@tdamsma I like this splitting approach. How about we merge that and make the example up again ?


Of course, him and Kesseldog. And what was it that he called Dr Hebert? Beardog? Dr Hebert has to be one of the final bosses. Dr Ferguson and Mr Mendence have to be a duo, as well.

I'd be down to do this with you, Garrett, if we got a story from Preston, but I would... rather not do it on the web. In fact, I'd rather shoot my foot than think about Javascript, HTML, and CSS.


It would just be HTML if it was a 2d game, but I see what you mean.


Can hackney 1.8 be used with ExAws?  I'd like to upgrade so that I can also upgrade some other dependencies that require hackney 1.8.


Sorry, just be javascript is what I meant


you're right, it should be in another test (maybe one of the first in form_tests?)


Of course... You could just ignore everything I say. And rightly so. I'm just geeking out over the fact that I appear as a "Contributor" on your project! 🎉 Boom!


ok (still should be private, and in handler section)


If Javascript is intended to be intuitive, I find it to be the exact opposite of what it's meant to be.


init com


Nightly: https://scala-webapps.epfl.ch/jenkins/view/Scala.js/job/scalajs-nightly-0.6.x/8/


@collimas removed Barntrup (and Bad Pyrmont) in #496 with the following reason:
> Removed Barntrup and Bad Pyrmont. The .json files contain lots of invalid and old data and have to be updated. They contained old data of nodes of the Freifunk Lippe community which caused the existence of double entries.

Has this been resolved?


Okay, well we can use another language. So would it be single player or multiplayer?


shouldn't be using 2.7


I guess it would be easier to do single player if it's going to be story-based.


as above


Multiplayer would be a fun challenge though. I would enjoy writing the network code.


#Pull NBA Statistics, using https://www.fantasybasketballnerd.com/fantasy-basketball-api
#Create a drop down menu allowing user to select from list of NBA teams
#Input player code to pull stats from the api
#Create bar/pie graphs showing stat distribution and conversion into total fantasy points/game
#Allow user to select up to 2 players and compare statistics side by side using bar/pie graphs
#Give our recommendation for who is the better player based off statistics pulled from api


why did the numbers drop  to NaN ?


There were the following issues with your Pull Request

  * A "License" and a "Signed-off-by" trailers are required. See [the guidelines about this](https://github.com/ipfs/community/blob/master/contribution-guidelines.md#a-license-and-a-signed-off-by-trailers-are-required)

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
`git commit --amend` can often help you quickly improve the commit message.
[Guidelines](https://github.com/ipfs/community/blob/master/contribution-guidelines.md#commit-messages) and [a script](https://github.com/ipfs/community/blob/master/dev/hooks/setup_commit_msg_hook.sh) are available to help in the long run.
Your feedback on GitCop is welcome on [this issue](https://github.com/ipfs/infrastructure/issues/23).

---
This message was auto-generated by https://gitcop.com


Doesn't it return -1 if the _hashes[_moveNumber] is different? Why is that the same as indicating the player to move is different?


why not using the constant directly ?
I mean in an external js file this wasn't an option, but in a template this seams to be more efficient.


Do you have a preferred way of chatting, not just Github comments? We could all get on that and talk about it, if someone else is interested.


https://www.google.com/search?q=plan+b
So... "mode for the morning after you've been exploited"?
It may well be an apt analogy, but is that the marketing image we want? ISTM this is somehow making a joke at your computer having been raped by the adversary and now you wish to somehow mitigate or recover from that? If so, it seems a bit inconsistent with the discussion in https://github.com/QubesOS/qubes-issues/issues/2163 IMHO (Code of Conduct stating a desire to avoid "The use of sexualized language or imagery and unwelcome sexual attention or advances")
@rootkovska ?


We could make a Slack team which is the same thing as Discord except for working people.


What do you want our team name to be?


from what i see is that pci_unmap_single crashes. desc->ptx_ring[index].data points to a illegal memory segment. ptx_ring may not be correctly initialized or index is wrong


Taut


And yeah slack is great, I am gonna make one for the robotics team.


- собрала билд на прод
- оставила в комментах сборку для разработки (без минификации images)
- удалила плагин svgstore (за ненадобностью)
- удалила ненужные картинки
- пофиксила отображение items в competition_achievement


Hmmm perhaps I should have another return value for hashes being different... I'll have a think about it!


I'm afraid I do not know. Hackney has had several releases with regressions lately, I am in the mode of whitelisting specific versions that people report to work.


corrected localhost


@pa9ey : The funky while loop was infinitely better :)


About the date filter (frontend) yes, i know it is broken in J3.7,

just now by your comment,
i see it is more broken than i remembered

need to study it , and make a fix for it too


Tip: `$ npm version patch && git push origin master --tags && npm publish` 👌


Heyy thank you so much for your reply. It worked! Thanks!!


ufnv


	int Board::Compare(const Board& other)
	{
		int failingSquare = MatchSquares(_board, _other._board);
		if (failingSquare > 0)
			return failingSquare;

		bool playerIsDifferent =
			(_playerToMove == other._playerToMove) &&
			(_hashes[_moveNumber] == other._hashes[_moveNumber]);

		return playerIsDifferent ? -1 : 0;
   	}

	bool MatchSquares(
		const Square * const board1,
		const Square * const board2)
	{
		for (int i = 1; i <= BoardArea; i++)
		{
			if (_board[i - 1] != other._board[i - 1])
				return i;
		}
		return 0;
	}`

I think this is the same but I've not tried compiling it...


@AlexKent3141 Infinitely, huh?

"TBH I don't really understand what happened here. The code is functionally the same..."

Can I quote that at some point? 😉


`--replaygain-track` and `--replaygain-album` options are mutually exclusive. From the code it looks like `track` takes priority if both are enabled at the same time. This behavior should be documented, or perhaps the two options merged into one, e.g. `--replaygain-type=<track|album|none>` .


@patflynn @akerekes


Alright, everyone should get an email invitation.


Jak działa na wszystkich typach bazy to rób pull request :) :+1:


LGTM


Mais tarde iremos buscar todas as informações do app da API heroes-on-express-api.


oh wait, I think the hash comparison is different (I'm not sure I understand why those checks are different)


Not trying to start an SJW bikeshed... just wanted to point out the association that came to mind in case it was an unintentional oversight.


oh! -  i found it now that fastest is actually cpuspeed=max. so I could have put  Newzealandstory in CPU_MaxSpeed.txt instead. I entrust you to know best as I'm a noob :)


Do you mean the file that generates the code into .asm?


Could we add an assert instead?

```
TR_ASSERT(sizeof(J9VMThread.privateFlags) == 8);
```


Unnecessary comment. The below fatal assert already implies this.


@anthonykulis The forced choices suppose to be the standard choices!!
but since we forced the user to choose, by keep asking  until the user choose an option, that initial value would not matter. also I was getting errors for not initializing the choices.


Thanks for updating the `.tool-versions` file. Would you mind if we used erlang 19.3?


AddMeFast,guitarweed@gmail.com,chitarra
Facebook,centromusicalealtosebino@gmail.com,coglione1


this here will be likelly a quick fix (untested) --- dev.h       (Revision 3392)
+++ dev.h       (Arbeitskopie)
@@ -250,7 +250,7 @@
                                SYSADPT_MAX_TID)
 #define MAX_NUM_TX_DESC        1024
 #define MAX_NUM_RX_DESC        (1024 * 16)
-#define MAX_TX_RING_SEND_SIZE  (4 * MAX_NUM_TX_DESC)
+#define MAX_TX_RING_SEND_SIZE  MAX_NUM_TX_DESC
 #define MAX_TX_RING_DONE_SIZE  MAX_NUM_TX_DESC
 #define MAX_RX_RING_SEND_SIZE  MAX_NUM_RX_DESC
 #define MAX_RX_RING_DONE_SIZE  MAX_NUM_RX_DESC


@sserena Kannst Du bitte noch dafür sorgen, dass die Tests wieder laufen? Im Moment gibt es zahlreiche Fehler wie: `Error: No provider for MobileService!`


you cannot use 4 times higher the txdesc area. you did not allocate that much using alloc_dma


Perhaps a small comment of why 5? Or even better a rename of `offset` to `offsetOfConcurrentScavengerActiveByte`


Seems like an unnecessary cast here?


tx_ring_alloc_ndp need to be changed to alloc more space and several other areas need to be fixed to if you want to use 4 times more. since you use max_num_tx_desc for accessing other areas. so please check the usage of this code


No. It is correct. Thanks for your information.


can't be. you get out of bound


It's missing
```
android:layout_above="@+id/bottom_navigation_view"
android:layout_below="@+id/appbar"
```


you alloc max_num_tx_ring_bytes this is correct int size = 4


section.html -(first verision)too much bugs,
index.html - (update section.html ; whitout style css; good html )


I don't understand anything. I've had one too many beers.

Hey! Check out my PR: #1. 😛


but you accessing it with index which is has the same max size. so you get another *4


consider pointer size


Is it or is it not allowed? Whether space has constraints or not, PyDOE is called nonetheless.


@gorhill the issue here is that if you go for example to
`http://www.mediamarkt.de/de/category/_externe-festplatten-462837.html`
clicking on any article will not work.
I don't think a fix via a `redirect` is possible in ths specific case.


forget about pointer. its static. but you still did not allocate enough dma space


@K9Advantix53 I think you want to edit line 126 to accomplish this. Adding the `Enabled: true` parameter is a good idea as well.


holito


This fix causes in issue if the user types in "1." (a number following by a decimal).  Instead of getting "1" like the user would expect, they get 0.


Yup, you're right. Ideally, our transaction external key would match some metadata in the `Requests`, but since we don't have such a mapping, how do you suggest fixing it? :thinking:


Yeah… it was just brainless copy & paste.


this would allocate enough space so that index would not get out of buffer --- tx_ndp.c    (Revision 3392)
+++ tx_ndp.c    (Arbeitskopie)
@@ -27,7 +27,7 @@
 #include "hif/pcie/dev.h"
 #include "hif/pcie/tx_ndp.h"

-#define MAX_NUM_TX_RING_BYTES   (MAX_NUM_TX_DESC * \
+#define MAX_NUM_TX_RING_BYTES   (MAX_TX_RING_SEND_SIZE * \
                                sizeof(struct pcie_tx_desc_ndp))
 #define MAX_NUM_TX_RING_DONE_BYTES (MAX_NUM_TX_DESC * \
                                sizeof(struct tx_ring_done))


Descriptor is 1024. 4096 is the limit to send to firmware.


This commit rewrote the copy constructor too so that it preserves highlight and selection information. The main addition is the IModification interface, which extends from the ICommand interface. This interface is the base for any of the new modification commands, as they are a bit different from the original set of edit mode commands. In this commit I made a basic (and still incomplete) command to surround with double cut as a modification.

I'm going to try and rig up the proper Qt connections so that this command actually displays in the UI. Once I get that working, I'll finish up the undo() and redo() functionality, after which this will hopefully be a suitable base to emulate for the other modification commands. From there, it's a matter of implementing the other commands and quicker than we know it an actual worthwhile program will finally start to peak through all this garbage.


ptx_ring is just allocated for 1024 desc. but you use 4096. do you get it?


This results in a corrupt packet: https://www.dropbox.com/s/vrm8ucto89ib94v/Screenshot%202017-04-26%2017.23.46.png?dl=0


@fpletz someone on #pax is saying that `ssp-buffer-size=4` is redundant with `-fstack-protector-strong`. Do you recall why you added this?


Thanks for the update 👍


Yes. Allocate 1024, 4096 is used to limit the number to firmware.


I think I would use a more conventional loop too...

	// Returns the square (1-based) that doesn't
	// match or 0 if the board matches
	bool MatchSquares(
		const Square * const board1,
		const Square * const board2)
	{
		for (int i = 0; i < BoardArea; i++)
		{
			if (_board[i] != other._board[i])
				return i + 1;
		}
		return 0;
	}


here you allocate 1024 descs
        mem = dma_alloc_coherent(priv->dev,
                                 MAX_NUM_TX_RING_BYTES,
                                 &desc->pphys_tx_ring,
                                 GFP_KERNEL);
        if (!mem)
                goto err_no_mem;
        desc->ptx_ring = (struct pcie_tx_desc_ndp *)mem;

but here you access ptx_ring > 1024
                if (index >= MAX_TX_RING_SEND_SIZE) {
                        wiphy_err(hw->wiphy,
                                  "corruption for index of buffer\n");
                        break;
                }
                skb = desc->tx_vbuflist[index];
                desc->tx_vbuflist[index] = NULL;
                ptx_ring_done->user = 0;
                if (!skb) {
                        wiphy_err(hw->wiphy,
                                  "buffer is NULL for tx done ring\n");
                        break;
                }

                pci_unmap_single(pcie_priv->pdev,
                                 le32_to_cpu(
                                 desc->ptx_ring[index].data),
                                 skb->len,
                                 PCI_DMA_TODEVICE);


you cannot access ptx_ring > 1024 like here in that code. index is > 1024, but desc->ptx_ring is <=1024 allocated


Foi loko. http://olimpiada.ic.unicamp.br/pratique/programacao/nivel2/ResultadoSubmissao


which casts are you referring to?


you forgot this in the new code - can't compile without defining it!


Instead of calling getLocation on document load you could just invoke navigator.gelocation inside c and pass the rest of the logic as an anonymous  function


Closes #5


![image](https://cloud.githubusercontent.com/assets/11786396/25457796/ce8d2660-2ad7-11e7-862d-24934290b31d.png)
Hooray!


Excellent work @phl0 - I couldn't find anything supporting DUE! I didn't look hard enough! Well done!


I will check it. Thanks. The design is allocation 1024, 4096 is used to limit the number. Coding could be wrong.


@hollodotme, fixed =)


Uh, whats going on? With the last the contribution i just wanted to help you out and finish up your skins too with the stuff that were added to the gui already.

I just added some dummys of the new controls and a working help control for the invisible buttons. Beyond that i would have suggested to adopt a slighty modifed xml structure and i put that changes into on single commit, which easily have could been reverted, if your decision were against that.

Overall i would have done that because i tought it could be my job for several reasons:
First it looked like that working on the xml's is maybe not your preferred task you like to do. You are the master of coding in python and adding new functions, whereas i spent many hours with the xml in perspective of a skinner and meanwhile became very familiar with every single line there.
Second i recognized at kodi, that you became a little upset about the exceptions in kodi's log, or even more (thats how it sounded to me) you started to justify, that these exceptions and the new controls are the reason for every single users issue. Although i agree that there were 3 small bugs that had to be fixed indeed, i think your current dismissal to my contributions (which i think is grounded on that), goes to far. Because: 1. I am still here correcting my mistakes or/and improving the code, like i prepared some in my PopupMenu_failsafe branch for you too. 2. In appreciation of the very useful changes i committed to your project in the past. At least myname @thismustbetheplace, which skinning is still in progress and goes another big step forward, was very thankful & enthusiastic about the changes i brought in (like he posted at Kodi). 3. This project has allways been a work in progress.
Third, beside mitigating all the exceptions and your doubts, an updated default and catbar skin template for you and everyone would have prevented any skin and skinning issues in the future too.
Fourth, i take care about anything i bring in.

Another general point of discussion is, do you want progress in cooperation with some endeavoured developers at the price and risk that mabye some old skins doesn't work anymore? I think this is not up to you, but on the skinners to follow your project and adjust there xml's then (Do you remember, i fixed a bug in gui with the result the kjb's needed to be patched, because the skin was misconfigured). Or do you want to keep all old skins working at the price and risk to forestall improvements? Myname would maybe be disappointed too, since he invested a lot of time and passion already. Both would be the best of course, finding the balance is the difficult part.

But at last i just can say i am sad, i had fun to contribute to your great development and thougt we started a fruitful cooperation already, under your leadership of course.
Btw. again, the last mentions were no demands to pull my changes at once, just wanted to report about my current progression and give you the opportunity have a look if you are interested.

I going to leave the branches online for some time, so you can take over one or the other if you like.


Hi, I implemented 480p when I was trying to make a generic patch for half pixel offset issue, like the one Xploder HDTV Player does (at the cost of some flickering)... Then I gave up. Therefore, you can remove it, buddy. No problem on that okay ;-)


Please include this in alpha build only for now. I want to test it on alpha to conform before including it in the production.


Should this be vec(functype)?


Yes, that does not look like something easy to fix.

ABP + EasyPrivacy suffers same issue (fyi @ryanbr).


- New feature: NSFW Channels, now live for everyone.

The still in-development audit logs now have lots more filters and pages!

## Audit log strings
```diff
-        GUILD_SETTINGS_AUDIT_LOGS_GUILD_AFK_TIMEOUT_CHANGE: "Set the afk timeout to **{newValue}** seconds",
+        GUILD_SETTINGS_AUDIT_LOGS_GUILD_AFK_TIMEOUT_CHANGE: "Set the afk timeout to **{newValue}** minutes",
-        GUILD_SETTINGS_AUDIT_LOGS_GUILD_EXPLICIT_CONTENT_FILTER_CHANGE: "Set the explicit content filter to **{newValue}**",
+        GUILD_SETTINGS_FILTER_ACTION: "Filter by Action",
+        GUILD_SETTINGS_FILTER_USER: "Filter by User",
+        GUILD_SETTINGS_FILTER_ALL: "All",
+        GUILD_SETTINGS_ACTION_FILTER_GUILD_UPDATE: "Update Guild",
+        GUILD_SETTINGS_ACTION_FILTER_CHANNEL_CREATE: "Create Channel",
+        GUILD_SETTINGS_ACTION_FILTER_CHANNEL_UPDATE: "Update Channel",
+        GUILD_SETTINGS_ACTION_FILTER_CHANNEL_DELETE: "Delete Channel",
+        GUILD_SETTINGS_ACTION_FILTER_CHANNEL_OVERWRITE_CREATE: "Create Channel Permissions",
+        GUILD_SETTINGS_ACTION_FILTER_CHANNEL_OVERWRITE_UPDATE: "Update Channel Permissions",
+        GUILD_SETTINGS_ACTION_FILTER_CHANNEL_OVERWRITE_DELETE: "Delete Channel Permissions",
+        GUILD_SETTINGS_ACTION_FILTER_MEMBER_KICK: "Kick Member",
+        GUILD_SETTINGS_ACTION_FILTER_MEMBER_PRUNE: "Prune Members",
+        GUILD_SETTINGS_ACTION_FILTER_MEMBER_BAN_ADD: "Ban Member",
+        GUILD_SETTINGS_ACTION_FILTER_MEMBER_BAN_REMOVE: "Unban Member",
+        GUILD_SETTINGS_ACTION_FILTER_MEMBER_UPDATE: "Update Member",
+        GUILD_SETTINGS_ACTION_FILTER_MEMBER_ROLE_UPDATE: "Update Member Roles",
+        GUILD_SETTINGS_ACTION_FILTER_ROLE_CREATE: "Create Role",
+        GUILD_SETTINGS_ACTION_FILTER_ROLE_UPDATE: "Update Role",
+        GUILD_SETTINGS_ACTION_FILTER_ROLE_DELETE: "Delete Role",
+        GUILD_SETTINGS_ACTION_FILTER_INVITE_CREATE: "Create Invite",
+        GUILD_SETTINGS_ACTION_FILTER_INVITE_UPDATE: "Update Invite",
+        GUILD_SETTINGS_ACTION_FILTER_INVITE_DELETE: "Delete Invite",
+        GUILD_SETTINGS_ACTION_FILTER_WEBHOOK_CREATE: "Create Webhook",
+        GUILD_SETTINGS_ACTION_FILTER_WEBHOOK_UPDATE: "Update Webhook",
+        GUILD_SETTINGS_ACTION_FILTER_WEBHOOK_DELETE: "Delete Webhook",
+        GUILD_SETTINGS_ACTION_FILTER_EMOJI_CREATE: "Create Emoji",
+        GUILD_SETTINGS_ACTION_FILTER_EMOJI_UPDATE: "Update Emoji",
+        GUILD_SETTINGS_ACTION_FILTER_EMOJI_DELETE: "Delete Emoji",
```

## Audit log variables
- `AUDIT_LOGS_FETCHED: null,`
`AUDIT_LOGS_FETCH_START: null,`
`AUDIT_LOGS_FETCH_SUCCESS: null,`
`AUDIT_LOGS_FETCH_NEXT_PAGE_START: null,`
`AUDIT_LOGS_FETCH_NEXT_PAGE_SUCCESS: null,`
`AUDIT_LOGS_FILTER_BY_ACTION: null,`
`AUDIT_LOGS_FILTER_BY_USER: null,`
- `AUDIT_LOGS_FETCH_SUCCESS: h,`
` AUDIT_LOGS_FETCH_NEXT_PAGE_SUCCESS: h`
 ```diff
-    t.__esModule = !0, t.UserRequiredActions = t.AuditLogChangeKeys
+    t.__esModule = !0, t.UserRequiredActions = t.AUDIT_LOG_PAGE_LIMIT = t.AuditLogChangeKeys
```
```diff
     }), t.AuditLogActions = {
+        ALL: null,
         GUILD_UPDATE: 1,
         CHANNEL_CREATE: 10,
         CHANNEL_UPDATE: 11,
```
```diff
     }, t.AuditLogActionTypes = (0, E.default)({
+        ALL: null,
         CREATE: null,
         UPDATE: null,
         DELETE: null
```
```diff
     }, t.AuditLogTargetTypes = (0, E.default)({
+        ALL: null,
         GUILD: null,
         CHANNEL: null,
         USER: null,
```
```diff
-    }, t.UserRequiredActions = (0, E.default)({
+    }, t.AUDIT_LOG_PAGE_LIMIT = 50, t.UserRequiredActions = (0, E.default)({
```
- `AUDIT_LOGS_FETCH_START: E,`
`AUDIT_LOGS_FETCH_SUCCESS: _,`
`AUDIT_LOGS_FETCH_NEXT_PAGE_START: l,`
`AUDIT_LOGS_FETCH_NEXT_PAGE_SUCCESS: u,`
`AUDIT_LOGS_FILTER_BY_ACTION: d,`
`AUDIT_LOGS_FILTER_BY_USER: c,`

+ Lots and lots more of the same code related to audit logs.


Puzzle `65-20701973` disappeared, that's why I closed as #65-20701973


Uh, oh. I can no longer cheat my way into that level...


Can you wrap all the logic inside an object?
```
var WeatherManager = {
   init: function()..,
  getWeather: function()...
  //...
};
 document.addEventListener("DOMContentLoaded", WeatherManager.init());
```


can you upload a new browser on the chrome store my school removed it from my computer and I cant find another one


Remove commented code


and why do you use ptx_ring instead of ptx_ring_done?


the index references to ptx_ring_done from what i see here


I am working on an PR. If the request_id (which should be unique) is a new one or matches the current response (if not nil) from the on_demand report api, then we treated it as successful. Otherwise, if the request id has already been used in any of the previous responses / requests, we skip it. Does that make sense?


![](https://github.trello.services/images/mini-trello-icon.png) [[2] Publishing events: enchancements](https://trello.com/c/hoLtH7nB/218-2-publishing-events-enchancements)


`currentWeather.main.temp` should be received as a parameter of this function


This commit produce another error:
@mcardillo55

Traceback (most recent call last):
  File "/home/amarok/.virtualenvs/finance/lib/python3.5/site-packages/yahoo_finance/__init__.py", line 120, in _request
    _, results = response['query']['results'].popitem()
AttributeError: 'NoneType' object has no attribute 'popitem'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/amarok/.virtualenvs/finance/lib/python3.5/site-packages/yahoo_finance/__init__.py", line 124, in _request
    raise YQLQueryError(response['error']['description'])
KeyError: 'error'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/home/amarok/.virtualenvs/finance/lib/python3.5/site-packages/django/core/management/__init__.py", line 363, in execute_from_command_line
    utility.execute()
  File "/home/amarok/.virtualenvs/finance/lib/python3.5/site-packages/django/core/management/__init__.py", line 355, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/amarok/.virtualenvs/finance/lib/python3.5/site-packages/django/core/management/base.py", line 283, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/amarok/.virtualenvs/finance/lib/python3.5/site-packages/django/core/management/base.py", line 330, in execute
    output = self.handle(*args, **options)
  File "/home/amarok/Workspace/Web/finance/finance/management/commands/complete_analysis.py", line 23, in handle
    HistoricalFinanceVariable.objects.store_all_date_and_price()
  File "/home/amarok/Workspace/Web/finance/historical/addons/managers.py", line 87, in store_all_date_and_price
    self.store_date_and_price_yahoo(finance_var, start_date, end_date)
  File "/home/amarok/Workspace/Web/finance/historical/addons/managers.py", line 40, in store_date_and_price_yahoo
    historical_finance_data = finance_client.get_historical(start_date, end_date)
  File "/home/amarok/.virtualenvs/finance/lib/python3.5/site-packages/yahoo_finance/__init__.py", line 343, in get_historical
    result = self._request(query)
  File "/home/amarok/.virtualenvs/finance/lib/python3.5/site-packages/yahoo_finance/__init__.py", line 126, in _request
    raise YQLResponseMalformedError()
yahoo_finance.YQLResponseMalformedError: Response malformed.


I think so - might need a test to convince me though 😼


Dictionary: {'query': {'lang': 'en-US', 'count': 0, 'created': '2017-04-26T21:20:41Z', 'results': None}}


They are different rings.


`EventListener` should be added on document loaded, maybe throw an `addListeners` function


d


new (uncomplete) datascraper *added*
inspired by stu's approach


Nyoom! 🐅


For sending, allocation is 1024, 4096 is used to limit the number to firmware.


PR is on the way :)


**Whoops!**

There were *49 warnings* that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

**WARNINGS**
[`src/content/en/fundamentals/engage-and-retain/push-notifications/common-notification-patterns.md#L4`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/common-notification-patterns.md#L4) - WF Tag `wf_updated_on` must be within the last 7 days.
[`src/content/en/fundamentals/engage-and-retain/push-notifications/common-notification-patterns.md#L260`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/common-notification-patterns.md#L260) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/common-notification-patterns.md#L264`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/common-notification-patterns.md#L264) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/common-notification-patterns.md#L330`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/common-notification-patterns.md#L330) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/common-notification-patterns.md#L357`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/common-notification-patterns.md#L357) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L4`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L4) - WF Tag `wf_updated_on` must be within the last 7 days.
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L78`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L78) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L82`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L82) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L86`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L86) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L91`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L91) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L93`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L93) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L101`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L101) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L103`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L103) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L119`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L119) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L123`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L123) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L150`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L150) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L154`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L154) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L178`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L178) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L182`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L182) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L241`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L241) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L255`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L255) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L296`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L296) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L300`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/display-a-notification.md#L300) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/faq.md#L4`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/faq.md#L4) - WF Tag `wf_updated_on` must be within the last 7 days.
[`src/content/en/fundamentals/engage-and-retain/push-notifications/faq.md#L53`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/faq.md#L53) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/faq.md#L74`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/faq.md#L74) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/good-notification.md`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/good-notification.md) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/engage-and-retain/push-notifications/handling-messages.md#L4`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/handling-messages.md#L4) - WF Tag `wf_updated_on` must be within the last 7 days.
[`src/content/en/fundamentals/engage-and-retain/push-notifications/how-push-works.md#L4`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/how-push-works.md#L4) - WF Tag `wf_updated_on` must be within the last 7 days.
[`src/content/en/fundamentals/engage-and-retain/push-notifications/how-push-works.md#L69`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/how-push-works.md#L69) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/index.md#L5`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/index.md#L5) - WF Tag `wf_updated_on` must be within the last 7 days.
[`src/content/en/fundamentals/engage-and-retain/push-notifications/notification-behaviour.md#L4`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/notification-behaviour.md#L4) - WF Tag `wf_updated_on` must be within the last 7 days.
[`src/content/en/fundamentals/engage-and-retain/push-notifications/notification-behaviour.md#L138`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/notification-behaviour.md#L138) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/notification-behaviour.md#L158`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/notification-behaviour.md#L158) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/notification-behaviour.md#L171`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/notification-behaviour.md#L171) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/notification-behaviour.md#L185`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/notification-behaviour.md#L185) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/permission-ux.md#L4`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/permission-ux.md#L4) - WF Tag `wf_updated_on` must be within the last 7 days.
[`src/content/en/fundamentals/engage-and-retain/push-notifications/permission-ux.md#L48`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/permission-ux.md#L48) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/permission-ux.md#L57`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/permission-ux.md#L57) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/permission-ux.md#L62`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/permission-ux.md#L62) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/permission-ux.md#L106`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/permission-ux.md#L106) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/permission-ux.md#L111`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/permission-ux.md#L111) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/permission-ux.md#L115`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/permission-ux.md#L115) - Line must be at most 100 characters
[`src/content/en/fundamentals/engage-and-retain/push-notifications/permissions-subscriptions.md`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/permissions-subscriptions.md) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/engage-and-retain/push-notifications/sending-messages-with-web-push-libraries.md#L4`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/sending-messages-with-web-push-libraries.md#L4) - WF Tag `wf_updated_on` must be within the last 7 days.
[`src/content/en/fundamentals/engage-and-retain/push-notifications/sending-messages.md`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/sending-messages.md) - Unable to read file, was it deleted?
[`src/content/en/fundamentals/engage-and-retain/push-notifications/subscribing-a-user.md#L4`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/subscribing-a-user.md#L4) - WF Tag `wf_updated_on` must be within the last 7 days.
[`src/content/en/fundamentals/engage-and-retain/push-notifications/web-push-protocol.md#L4`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/web-push-protocol.md#L4) - WF Tag `wf_updated_on` must be within the last 7 days.
[`src/content/en/fundamentals/engage-and-retain/push-notifications/web-push-protocol.md#L456`](https://github.com/Google/WebFundamentals/blame/ac5400c7b086595a0bfe34c11398149e2e66c921/src/content/en/fundamentals/engage-and-retain/push-notifications/web-push-protocol.md#L456) - Line must be at most 100 characters


한줄의 return이지만 { }로 처리하는게 좋습니다.  java convention


Ugh... The picture posted at <https://www.camp-firefox.de/forum/viewtopic.php?p=1035574#p1035574>... One should really not use an _allow_ rule for 3rd-party scripts, this pretty much defeats the purpose of using a blocker.


![](https://github.trello.services/images/mini-trello-icon.png) [Stock Twits - Parse @mentions and convert to links](https://trello.com/c/b3JE3Hke/12-stock-twits-parse-mentions-and-convert-to-links)


Now eMMC works properly: http://sprunge.us/WDHR


I will review the code. Thanks for your information.


### [Codacy](https://www.codacy.com/app/Eeems/PooledWebSocket/commit?cid=89075667) detected an issue:
#### Message: `Generic Object Injection Sink: /src/pooledwebsocket.js: 29
					pool.events[event] || (pool.events[event] = []);

 (security/detect-object-injection)`

#### Occurred on:
+ **Commit**:  9caf2b38ae2346532f1e477f60b8f0ed985ab1b3
+ **File**:    [pooledwebsocket.js](https://github.com/Eeems/PooledWebSocket/blob/9caf2b38ae2346532f1e477f60b8f0ed985ab1b3/pooledwebsocket.js)
+ **LineNum**: [28](https://github.com/Eeems/PooledWebSocket/blob/9caf2b38ae2346532f1e477f60b8f0ed985ab1b3/pooledwebsocket.js#L28)
+ **Code**:    `pool.events[event] || (pool.events[event] = []);`

#### Currently on:
+ **Commit**:  8464b0bdb6c11387613b8d4ab2bf4c5c5cc28164
+ **File**:    [pooledwebsocket.js](https://github.com/Eeems/PooledWebSocket/blob/8464b0bdb6c11387613b8d4ab2bf4c5c5cc28164/pooledwebsocket.js)
+ **LineNum**: [36](https://github.com/Eeems/PooledWebSocket/blob/8464b0bdb6c11387613b8d4ab2bf4c5c5cc28164/pooledwebsocket.js#L36)
     This should be explicitly ignored


Nice fix!


### [Codacy](https://www.codacy.com/app/Eeems/PooledWebSocket/commit?cid=89075667) detected an issue:
#### Message: `Generic Object Injection Sink: /src/pooledwebsocket.js: 30
					pool.events[event].push(fn);

 (security/detect-object-injection)`

#### Occurred on:
+ **Commit**:  9caf2b38ae2346532f1e477f60b8f0ed985ab1b3
+ **File**:    [pooledwebsocket.js](https://github.com/Eeems/PooledWebSocket/blob/9caf2b38ae2346532f1e477f60b8f0ed985ab1b3/pooledwebsocket.js)
+ **LineNum**: [29](https://github.com/Eeems/PooledWebSocket/blob/9caf2b38ae2346532f1e477f60b8f0ed985ab1b3/pooledwebsocket.js#L29)
+ **Code**:    `pool.events[event].push(fn);`

#### Currently on:
+ **Commit**:  8464b0bdb6c11387613b8d4ab2bf4c5c5cc28164
+ **File**:    [pooledwebsocket.js](https://github.com/Eeems/PooledWebSocket/blob/8464b0bdb6c11387613b8d4ab2bf4c5c5cc28164/pooledwebsocket.js)
+ **LineNum**: [37](https://github.com/Eeems/PooledWebSocket/blob/8464b0bdb6c11387613b8d4ab2bf4c5c5cc28164/pooledwebsocket.js#L37)
    This should be explicitly ignored.


![](https://github.trello.services/images/mini-trello-icon.png) [Stock Twits - Convert usernames to links](https://trello.com/c/JAVpHePX/13-stock-twits-convert-usernames-to-links)


Yarn and NPM don't provide what Bower solves. Bower really helps to split the frontend dependencies from the backend ones and until Yarn and/or NPM does this as well, I won't be able to ditch Bower.

Keep in mind that not every project is a SPA or a complex JavaScript app and most websites don't want the complexity of webpack for this trivial task.

Since Yarn dropped bower support (if I didn't miss any new development on this), I feel like this message on the website is misleading.


thats not what i mean

tx_done_ndp you do the following

                index = le32_to_cpu(ptx_ring_done->user);

                pci_unmap_single(pcie_priv->pdev,
                                 le32_to_cpu(
                                 desc->ptx_ring[index].data),
                                 skb->len,
                                 PCI_DMA_TODEVICE);

why do you pci_unmap on ptx_ring instead of ptx_ring_done? in addition the index itself is checked for 4*TX_DESC_SIZE so 4096. but ptx_ring is allocated for only1024.  ->crash since its out of bound access.


If you go through that thread you will find worse.


done!


hola


It's really necessary the ios deployment target bump?


Until you mentioned it, I wasn't aware of this connotation. Where I came from, Plan B is a colloquialism for: "backup plan". I also suggest we don't resort to Google as the final arbiter in interpretation of language ;)


![](https://github.trello.services/images/mini-trello-icon.png) [Commits](https://trello.com/c/5k9sUaij/24-commits)


Hi Sergey,
Ok, i have tried 25.2 now and i do not see this error.  You get it when loading erlang.el i suppose?
Or how do you trigger this error?
Is it possible that you have an non-standard etags.el in your load-path?
xref-etags-location is defined in the etags.el shipped with 25.2.
And erlang.el require etags if it is available.


Hic!

What's `ret`?
@AlexKent3141


@dansiegel
why you replaced pushpopuppageasync on usual prism navigateasync? it seems now as transition to navigation page


Some funny business happened here; this change should not be in the commit history. I have a feeling a conflict happened when rebasing from dev to rel/2.0.0-preview1 and the history was messed up. This is fixed by the next two commits where this change was reverted.


![](https://github.trello.services/images/mini-trello-icon.png) [Stock Twits - convert timestamp to links](https://trello.com/c/LL9VwmQj/14-stock-twits-convert-timestamp-to-links)


If this is "private" state, probably belongs in the objects initializer.


// Returns the square (1-based)

@mbreckon No it doesn't. :)


Strange. I'm really surprised that they use ASCII-8BIT strings for an exception message, but it looks like they do.


Negative. You chose a value. Say 1, 3, 19, doesn't matter. Then inside the
try catch you do work that might update the answer. If the try fails, it
will go into the catch. In some cases you ignore that and do nothing, in
some cases you just print a stack trace. But if it happens, you continue
on, never getting the user choice but using the one you forced upon the
user. In some cases you even possibly cascade that forced choice onto
another option, or possibly even use the previous choice for the next
choice.
On Wed, Apr 26, 2017 at 4:11 PM نور الهدى <notifications@github.com> wrote:

> @anthonykulis <https://github.com/anthonykulis> The forced choices
> suppose to be the standard choices!!
> but since we forced the user to choose, by keep asking until the user
> choose an option, that initial value would not matter. also I was getting
> errors for not initializing the choices.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/nourelhoda89/automobile/commit/e9c1dbd27b5e02c383f72e359c91224a2e9eef3b#commitcomment-21923186>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA-8MTouJXUFS37XlTM5QLkIzbeZYGf2ks5rz7MKgaJpZM4NJKJr>
> .
>


Is there no other available place to store this?


Shouldn't it be `start+k+l` (and not `offser+k+l`)?


Making notes as I read Gecko's implementation:
* for Window/Location, Gecko returns `FilteringWrapper<CrossOriginXrayWrapper, CrossOriginAccessiblePropertiesOnly>::singleton`
* for every other object, Gecko returns `FilteringWrapper<CrossCompartmentSecurityWrapper, Opaque>::singleton`

That means that the wrapper inheritance hierarchies are:
* `FilteringWrapper` -> `CrossOriginXrayWrapper` -> `SecurityXrayDOM` -> `xpc::XrayWrapper` -> `js::CrossCompartmentSecurityWrapper`
* `FilteringWrapper` -> `js::CrossCompartmentSecurityWrapper`

The `Opaque` [policy](https://dxr.mozilla.org/mozilla-central/source/js/xpconnect/wrappers/AccessCheck.h#55-67) denies everything. The `CrossOriginAccessiblePropertiesOnly` [policy](https://dxr.mozilla.org/mozilla-central/source/js/xpconnect/wrappers/AccessCheck.h#86-105) has more specialized behaviour. These are invoked in from the methods in FilteringWrapper - sometimes before (like `enter` and `call`), sometimes after (like `getOwnPropertyDescriptor` and `ownPropertyKeys`).

The opaque wrapper can probably stay relatively straightforward like you've written it, but it definitely needs to inherit from js::CrossCompartmentSecurityWrapper, and we'll need to be sure to set outparameters appropriately


The next issue is that your team copy/paste/hacked your solution. This
means they have all the same issues as you.
On Wed, Apr 26, 2017 at 4:43 PM anthony kulis <anthony.kulis@gmail.com>
wrote:

> Negative. You chose a value. Say 1, 3, 19, doesn't matter. Then inside the
> try catch you do work that might update the answer. If the try fails, it
> will go into the catch. In some cases you ignore that and do nothing, in
> some cases you just print a stack trace. But if it happens, you continue
> on, never getting the user choice but using the one you forced upon the
> user. In some cases you even possibly cascade that forced choice onto
> another option, or possibly even use the previous choice for the next
> choice.
> On Wed, Apr 26, 2017 at 4:11 PM نور الهدى <notifications@github.com>
> wrote:
>
>> @anthonykulis <https://github.com/anthonykulis> The forced choices
>> suppose to be the standard choices!!
>> but since we forced the user to choose, by keep asking until the user
>> choose an option, that initial value would not matter. also I was getting
>> errors for not initializing the choices.
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/nourelhoda89/automobile/commit/e9c1dbd27b5e02c383f72e359c91224a2e9eef3b#commitcomment-21923186>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AA-8MTouJXUFS37XlTM5QLkIzbeZYGf2ks5rz7MKgaJpZM4NJKJr>
>> .
>>
>


asdasdasd


the goal of v2.0 is to completely deprecate the use of the extensions in favor of having it natively handled within the NavigationService's `NavigateAsync` and `GoBackAsync`. There are currently a couple of known bugs in the v2 preview that will be addressed when I have some time to look into it. I would suggest using v1.1 if you are relying on the extensions.


Please revert this update, because included strings coming from installed plugins.


ZzzZZzzzZZZzz


the two `if`s could be grouped,
`if user.email && (post.user.id !== user.id) do`


Learning git?


Tx ring done only contains index.


True... index of the square...


here is an issue related to #991


I will review the code today. Thanks.


So just what I said it could be coding error. I will review the code.


@dansiegel
I've updated on the latest stable xf release and now cannot open popup view via pushpopuppageasync


lkglkjhg


> Where I came from, Plan B is a colloquialism for: "backup plan"

Indeed, and same here, but it's still not the only definition that comes to mind.


@beylkhanovdamir please open an issue with some detail so I can investigate further. Thanks.


Still, Ja, not Jp. Also, deprecations.


Huh? It returns a bool. (So a propositional truth! 😉) Not a square. Not an index.
What am I missing?


Hmm.. Why have this `Option` here?


Oh, I did not understand properly. I am sorry for letting you do it twice. I'll review.


OK


Seems so


Curious to know more about this Mem. Is this to provide a unified interface over various kinds of refs? (Also, as an aside, it would be good to switch over to the new memory model before writing more new code so as to avoid migration effort later.)


@IgorVictor @fgan1 remove debugging log before commit.
how hard is to add an unit test to capture the bug?


No problem - thanks for all the work you are putting in to it!

Sent from my iPhone 📱

> On 26 Apr 2017, at 22:55, Norio Nomura <notifications@github.com> wrote:
>
> Oh, I did not understand properly. I am sorry for letting you do it twice. I'll review.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.
>


Hello rokasbalsys!
Can you upload the code once again? Thanks in advance!

Best regards


Do we need to comprehend this `only_factor` business here in `factorial_config`? Or would it be sufficient to just deal with it in `simulate_factors()`?

Having the `only_factor` filtering here has the potential to improve runtime performance since it only does the `deepcopy(base_config)` lift for the target config index, but this is at the cost of having the feature spread across two functions instead of being encapsulated within one.


hola


merge to david


> I also suggest we don't resort to Google as the final arbiter in interpretation of language ;)

Agreed, especially given the fact that google results are determined in part by who's searching.

---

From the [Wikipedia disambiguation for "Plan B"](https://en.wikipedia.org/wiki/Plan_B):
- Very first link: [Medicine] Plan B, a brand name of levonorgestrel, an emergency contraception drug.
- Very last link: [Other] Contingency plan

Those sections are not sorted alphabetically...


lalala


"Sights" --> "sight"


@tannerflick4 You'd probably be interested in taking a look at my new, revamped system. For now it includes 6 different vendors with a bunch of sub-categories.

I'm also considering making a "barter" system, in which you can try to lower the price using skills/high stats.


Long story short you can't. Just commit the xml and ill update it based on the xml


Not that I'm eager of curiosity or have all that much of a use-case either, but I wonder if at least in theory(no new features are used), a driver signed this way could still be made to load on <W7


the following patch fixes the issue (tested)
--- tx_ndp.c    (Revision 3394)
+++ tx_ndp.c    (Arbeitskopie)
@@ -456,8 +456,7 @@
                }

                pci_unmap_single(pcie_priv->pdev,
-                                le32_to_cpu(
-                                desc->ptx_ring[index].data),
+                                skb->data,
                                 skb->len,
                                 PCI_DMA_TODEVICE);
                tx_info = IEEE80211_SKB_CB(skb);


As I was reviewing this post, I considered the potential association between "Plan B" and emergency contraception. However,  I did not (and still do not) find that potential association to be sufficiently problematic to necessitate changing the name. The use of the phrase "plan B" as a general term to refer to a secondary strategy predates the use of that term to refer to emergency contraception, and the post clearly explains why that term is appropriate in the context of Qubes. As far as I can tell, nothing in the post suggests that the term is being used to draw an analogy to rape or otherwise inappropriately. While it's true that some readers may make the association on their own, I don't see any evidence that a reasonable reader is likely to infer the content of the post to be inappropriate on that basis.

Having said this, it's not clear to me why Paranoid Mode should have two names, nor do I see any particular value in having the name "Plan B," so I wouldn't be opposed to dropping it (unless that value is demonstrated).


The same should be done for libtmux too?


so replace desc->ptx_ring[index].data with skb->data so the correkt skb is used from tx_vbuflist


"Sights" --> "Sight's" ?? (Really not sure about this one)


Quando estamos acostumados com algo de uma maneira, é bem estranho lidarmos com mudanças. Você utiliza um computador com um sistema operacional da Microsoft (Windows) e de repente quando compra um novo, ele vem com o Linux. Você se sente amedrontado não é? Isso é normal. São as mudanças abruptas, mudanças repentinas que transformam o que seria um sonho em um pesadelo.


Mas espere, não é tão ruim assim. A maioria dos sistemas operacionais possuem as mesmas funções que outros, o que muda é seu Layout, esse Layout é o design de como aquilo foi produzido, o rosto do sistema. Existem mudanças maiores, mas isso é no código em que aquele software ou sistema foi escrito, vamos falar sobre isso, chegaremos lá, e pode acreditar, você vai entender tudo perfeitamente.


Bah, that'll teach me for not compiling it. :-) I'm going home.


This also addresses #19 and #20.  Use of Docker is now the recommended way of deploying locally.


That's why I left my comment. I wasn't sure exactly what was happening. So is there a check/log we could add earlier which might hint at why we get to this point. This type of logging has helped isolate some of our most common crashes (not that this is one of them).


@mbreckon No probs. I realised, to late, that it was just a typo really.
#TooBusyWatchingRonnieOnIPlayer


Actually, Postman is moving to a standalone app. https://www.getpostman.com/ would be a better link (and not necessarily a Chrome extension)


Why install stacker_blueprints?


Might also want to have folks do this in a virtualenv


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/7ed4cb41-88dd-483f-8e88-33fb84d3d981 "ProfesorCognitivo"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/3b3c2a6c-fa90-4e9f-b037-3ceaa7548b49 "ProfesorCognitivo") deployed [ProfesorCognitivo](https://github.com/krlaguilar02/ProfesorCognitivo/releases/tag/deploy-ibm-yp-us-south-bjalpizar-dev-20170426-221612 "deploy-ibm-yp-us-south-bjalpizar-dev-20170426-221612") to [dev](https://console.ng.bluemix.net/apps/71e71400-bd03-476c-8e94-8fc8a5f09470 "ibm:yp:us-south:bjalpizar:dev"), including this commit


Might be worth mentioning we use the standard authentication chain found in most AWS clients (http://boto3.readthedocs.io/en/latest/guide/configuration.html)


I agree that those are the tradeoffs.  It seemed wasteful (and maybe a little confusing) to generate all of the configs in `factorial_config()` just to remove all but one of them in `simulate_factors()`.  That said, I'm happy to defer to your preference on this one; the code could become a bit more simple.


My understanding is that making a driver load isn't the issue, but rather the differences in signing required per https://vigem.org/2017/02/05/windows-driver-signing-bullshit/


@edwardleoni i think this needs to be `cavalry_mysql`


You've never mentioned namespace up until this point.  Maybe it's worth moving the environment to before this, and reference it as the 'namespace form the environment'


ALso maybe worth pointing back to the fact you installed stacker_blueprints earlier, etc, once you explain that earlier.


Maybe explain why we have a namespace/what it's used for (namespacing in cloudformation, and the s3 bucket if you don't explicitly configure one).


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/7ed4cb41-88dd-483f-8e88-33fb84d3d981 "ProfesorCognitivo"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/3b3c2a6c-fa90-4e9f-b037-3ceaa7548b49 "ProfesorCognitivo") deployed [ProfesorCognitivo](https://github.com/krlaguilar02/ProfesorCognitivo/releases/tag/deploy-ibm-yp-us-south-bjalpizar-dev-20170426-222007 "deploy-ibm-yp-us-south-bjalpizar-dev-20170426-222007") to [dev](https://console.ng.bluemix.net/apps/71e71400-bd03-476c-8e94-8fc8a5f09470 "ibm:yp:us-south:bjalpizar:dev"), including this commit


Make a note that they'll likely have to change this to something unique since the s3 bucket is named using this namespace as a prefix, and it's like that this one has been used before (and s3 has a single namespace for bucket names)


Ouch, my bad :( I probably did a git add for it accidentally while having an old version checked out? Yes, it was originally typeshed commit 397f998


Seems like Atom has removed whitespaces on it's own


OK


This works but wouldn't it be better to not create the tasks in the first place?

With this we will incur the cost of scheduling 32 tasks when only some of them will actually be doing any work.


https://github.com/CrowdForge/birdmash

nuff said


Did you mean to commit this?


Thanks. I will check it.


The reason we have two names: initially we referred to this as "paranoid mode" (as seen in the ticket), but then I thought maybe "plan b" would be a _less_ loaded name (hehe...) and also more funny (at least for me it sounds reasonably funny due to popular use in action movies, etc), than "paranoid", which to some people might bring connotations with a mental disorder ("paranoia"). I suggested we change the name of the option, but ultimately we decided to keep both names.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.20.7756144b6d1b885166bd1a26fa25393a5b7a2a74](http://build.palaso.org/viewLog.html?buildId=88862&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **FAILURE**
Summary: Compilation error: SIL.Core\SIL.Core.csproj (new) Build time: 00:00:28


TeamCity libpalaso :: palaso-precise64-libpalaso-2.6 Continuous [Build 2.6.1291.7756144b6d1b885166bd1a26fa25393a5b7a2a74](http://build.palaso.org/viewLog.html?buildId=88863&buildTypeId=PalasoPrecise64v26Cont) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:40


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 4.0.19.7756144b6d1b885166bd1a26fa25393a5b7a2a74](http://build.palaso.org/viewLog.html?buildId=88866&buildTypeId=Libpalaso_PalasoPrecise64masterContinuous) outcome was **FAILURE**
Summary: Failed to resolve artifact dependency Build time: 00:00:02


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.297.7756144b6d1b885166bd1a26fa25393a5b7a2a74](http://build.palaso.org/viewLog.html?buildId=88864&buildTypeId=bt223) outcome was **FAILURE**
Summary: Compilation error: SIL.Core\SIL.Core.csproj (new) Build time: 00:00:25


TeamCity libpalaso :: palaso-trusty64-lfmerge Continuous [Build 2.6.282.7756144b6d1b885166bd1a26fa25393a5b7a2a74](http://build.palaso.org/viewLog.html?buildId=88865&buildTypeId=PalasoTrusty64lfmergeContinuous) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:28


how do i delete this line?


TeamCity libpalaso :: palaso-precise64-libpalaso-3.1 Continuous [Build 3.1.249.7756144b6d1b885166bd1a26fa25393a5b7a2a74](http://build.palaso.org/viewLog.html?buildId=88869&buildTypeId=bt322) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:30


been have a scour on the web, found this on the picamera docs,  the overlays for the countdown is buffer intensive.. according to the docs:
_If too many overlays are added, the display output will be disabled and a reboot will generally be required to restore the display. Overlays are composited “on the fly”. Hence, a real-time constraint exists wherein for each horizontal line of HDMI output, the content of all source layers must be fetched, resized, converted, and blended to produce the output pixels.

If enough overlays exist (where “enough” is a number dependent on overlay size, display resolution, bus frequency, and several other factors making it unrealistic to calculate in advance), this process breaks down and video output fails. One solution is to add. dispmanx_offline=1 to /boot/config.txt to force the use of an off-screen buffer. Be aware that this requires more GPU memory and may reduce the update rate_

I've tried the advice of adding   dispmanx_offline=1 to the config.txt and now the   countdown works for 1, 2. misses 3 and comes back on the 2 count of 4.  (where as before it would go black after 2, until the processing png came up. so is defiantly looks like the overlays are the problem
Neill

hope this helps


I'm using a pi 2, maybe time to get a 3


Is this similar to the AG games?


I'm not at all saying the post is offensive, I just wanted to bring attention to the possibility that others may interpret the name of the feature out of context and think it is a tongue-in-cheek joke, and as a result think Qubes is being unprofessional. I just want to avoid a potential future marketing-embarrassment, that's all.

The point has been raised. If you believe it's a non-issue, then I'm happy leaving it as-is too.


+1. Download the [Adcash Swift SDK](https://github.com/adcash/AdcashSwift/raw/master/AdcashSwift.framework.zip) and unzip it.

  Write  Preview

Leave a comment
Attach files by dragging & dropping,  Выбрать файлы selecting them, or pasting from the clipboard.
 Styling with Markdown is supported Add single comment Cancel
  2. Right click on your project in the **Project Navigator** menu and select **Add Files to "name-of-your-project"**:
  ![Alt text](http://i2.wp.com/104.197.107.57/wp-content/uploads/2015/08/install-instructions-2.png)
  3. Select the AdcashSwift.framework you just unzipped and press **Add**. Make sure you choose **Copy items if needed**.


Why do I always miss these conversations?!
I have a home windows computer, but what would be the need of specifically a Windows computer?


 2. Right click on your project in the **Project Navigator** menu and select **Add Files to "name-of-your-project"**:
  ![Alt text](http://i2.wp.com/104.197.107.57/wp-content/uploads/2015/08/install-instructions-2.png)
  3. Select the AdcashSwift.framework you just unzipped and press **Add**. Make sure you choose **Copy items if needed**.


*sigh*.


Alright.
I don't need you to post a before and after.


are AG games still bugged?


See commit 7ec54e47


 2. Right click on your project in the **Project Navigator** menu and select **Add Files to "name-of-your-project"**:
  ![Alt text](http://i2.wp.com/104.197.107.57/wp-content/uploads/2015/08/install-instructions-2.png)


Did you mean `||` or OS X somehow defines `OS_BSD`?


This needs to be changed to KEY_TASK_PLACE_ID


That's be great thank you! In the meanwhile, I've updated the section title.


Are you talking about the calls to `unassign`, `WARNING`, `protect`, `unprotect`? I think I didn't disturb them...


NOTE! The data writing plugin is currently NOT sanitizing inputs. I need to implement that soon.


Not atm, but the way you described the fix seems eerily similar.


XSDDatatype.XSDtime oder XSDDatatype.XSDshort werden angezeigt? Seltsam:


I've been using his locally for sanity checks, we should either remove the image pull policy of never, or update the minikube deploy!


Created new storage_functions.py file


Wow...that `$index` var was a dumb oversight.

And I hadn't seen PHP_EOL before. Nice touches.


@damieng this is landed - you probably want to use this one for the open source people that use linter :)


doesnt sound similar at all to me. all my records show about american girls is it was eventually solved by better emulating the geometry engine busy flags so that the box test will work.


Version analysis for protocol definitions in this commit:

## Diffs

### `C_TEL_CAMP` 1 => 2
```diff
--- a/protocol/C_TEL_CAMP.1.def
+++ b/protocol/C_TEL_CAMP.2.def
@@ -1,1 +1,1 @@
-uint32 unk
+uint32 campId
```


Can we avoid pushing code to the master branch that we haven't tested yet? This is just code taken from some open source project,  we haven't tested it or used it at all in the project. I think it would be best to be adding these things on a new branch and test them there, and if we're happy with how it works then merge that branch with master  :)


why isn't this in StatsBase?


Follow the link to see prototype!


Two new tests failing on Windows after that commit: https://ci.appveyor.com/project/boostorg/build/build/1.0.161/job/9c2fj2u7we18jcy4

core_parallel_actions, core_parallel_multifile_actions_1 and rescan_header


You can pretty much blame it on references to flushed geometry lol. And out of curiosity, how is the terrain rendered? It looks either like a glorified Mode 7-ish heightfield or something done with voxels.


damn, now it's pretty hard for static code analyzers to detect that `Mockable->foo` method is in use.


no when i compiles generateSee.c i produces an error for generates.h header file .then how i can compile .....


![](https://github.trello.services/images/mini-trello-icon.png) [patreon - add membership options, link to site](https://trello.com/c/lPY1DhfW/7-patreon-add-membership-options-link-to-site)


Probably didn't need this whitespace.


Seriously, I ALWAYS miss these conversations.


this returns the number of rows updated. should always be 1 if used correctly in the app.


I wonder if we could find a tone or format that took fewer words and space. In particular, it seems awkward to have fine print in both the body as well as the list of attributes.


@skhilton: For your tests of actual things you are trying to validate, use `self.assertTrue` (or `self.assertFalse`) rather than regular `assert`.

You want a unittest error, not an execution error, if something goes wrong.

https://jeffknupp.com/blog/2013/12/09/improve-your-python-understanding-unit-testing/


OK


Why?


Pretty sure it's PostgreSQL, not PostgresSQL...


Awesome to us slowly converging on styles !

Tx for the review.

I'm happy to update CLog to match


Nahrán semestrální projekt


It seems like install varnish is now dependent on make precompile being successful, should that block use a notifies attribute to execute the install block?


Yeah I just caution against its overuse, or else it starts to lose meaning.
It might be more approriate if you decided that your failure messages should be themed, but they're pretty generic (nothing wrong with that) as is, which is a bit of a disconnect.


I think we can still drop it w/o much problem, given the packages are still in the testing repo ;)

But if we want to do so, then let us also think if we all agree that we want to leave the "paranoid" name, or do we want to change it to something less loaded and more politically correct?


For node code, it is acceptable I think. You just don't want the whole project to have that setting, so you put the configure file closer to the tests in question.


i still think we should force a blank input if it happens to get a null pointer exception.
we arnt actually dealing with the error here...


it's a heightfield thingy, soft-rendered to a BG


Thanks @kensoh ! If you see anything that needs to be added or corrected, please go for it! I just jammed together all the stuff I was seeing on the fediverse, and probably missed some stuff. Many hands make light work and all that...


can I change this file back or does it have to be like this?
as far as i'm concerned I just fixed performance issues without breaking anything


To clarify the change:

I created a user variable that gets assigned once authentication is done, which is then referenced in the '/' root instead of req.user.


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/7ed4cb41-88dd-483f-8e88-33fb84d3d981 "ProfesorCognitivo"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/3b3c2a6c-fa90-4e9f-b037-3ceaa7548b49 "ProfesorCognitivo") deployed [ProfesorCognitivo](https://github.com/krlaguilar02/ProfesorCognitivo/releases/tag/deploy-ibm-yp-us-south-bjalpizar-dev-20170426-232845 "deploy-ibm-yp-us-south-bjalpizar-dev-20170426-232845") to [dev](https://console.ng.bluemix.net/apps/71e71400-bd03-476c-8e94-8fc8a5f09470 "ibm:yp:us-south:bjalpizar:dev"), including this commit


This commit breaks my previously working toolchain configuration. The previous commit 3e25d20 was still ok:

```
> git checkout 2195f25
M	src/java_tools/buildjar/java/com/google/devtools/build/buildjar/javac/BlazeJavacMain.java
Previous HEAD position was 3e25d20... Cleanup SingleJarActionBuilder
HEAD is now at 2195f25... Update to javac9-r4023

> bazel build //src:bazel
.
INFO: Found 1 target...
Target //src:bazel up-to-date:
  bazel-bin/src/bazel
> cd mytest/
> ../bazel-bin/src/bazel build lib --java_toolchain=:testlib-toolchain
Extracting Bazel installation...
.
INFO: Found 1 target...
ERROR: missing input file '@bazel_tools//third_party/java/jdk/langtools:javac-9-dev-r3297-4.jar'.
ERROR: /home/u/.cache/bazel/_bazel_u/425a650790ab9/external/project/BUILD:31:1: @project//:target: missing input file '@bazel_tools//third_party/java/jdk/langtools:javac-9-dev-r3297-4.jar'.
Target //:lib failed to build
```

Toolchain config:

```
java_toolchain(
    name = "testlib-toolchain",
    bootclasspath = ["@bazel_tools//tools/jdk:bootclasspath"],
    encoding = "iso-8859-1",
    extclasspath = ["@bazel_tools//tools/jdk:extdir"],
    forcibly_disable_header_compilation = 0,
    genclass = ["@bazel_tools//tools/jdk:GenClass_deploy.jar"],
    header_compiler = ["@bazel_tools//tools/jdk:turbine_deploy.jar"],
    ijar = ["@bazel_tools//tools/jdk:ijar"],
    javabuilder = ["@bazel_tools//tools/jdk:JavaBuilder_deploy.jar"],
    javac = ["@bazel_tools//third_party/java/jdk/langtools:javac_jar"],
    javac_supports_workers = 1,
    jvm_opts = [
        "-XX:+TieredCompilation",
        "-XX:TieredStopAtLevel=1",
    ],
    misc = [
        "-XDskipDuplicateBridges=true",
    ],
    singlejar = ["@bazel_tools//tools/jdk:SingleJar_deploy.jar"],
    source_version = "8",
    target_version = "8",

    visibility = ["//visibility:public"]
)
```

The issue still persists on current HEAD.


Fix your email address, Vemahk


AMDG

On 04/26/2017 04:54 PM, Arkady Shapkin wrote:
> Two new tests failing on Windows after that commit: https://ci.appveyor.com/project/boostorg/build/build/1.0.161/job/9c2fj2u7we18jcy4
>
> core_parallel_actions, core_parallel_multifile_actions_1 and rescan_header
>

Well, that's embarrassing.  Fix incoming shortly.

In Christ,
Steven Watanabe


good comment


--> [170426 讨论结果 征集外界#刻板印象#语句 · Issue #10 · WangJane1030/Shescoding](https://github.com/WangJane1030/Shescoding/issues/10)


--> [170426 讨论结果 修改“她语言，帮助女孩重拾梦的未来”这段话 · Issue #11 · WangJane1030/Shescoding](https://github.com/WangJane1030/Shescoding/issues/11)


-->[170426 讨论结果 寻找一个更好的结尾 · Issue #12 · WangJane1030/Shescoding](https://github.com/WangJane1030/Shescoding/issues/12)


Is this temporary workaround necessary any more on 1.6.0, given the merging of https://github.com/kubernetes/kubernetes/pull/38334 upstream?


Most definitely, I can work on it on Friday


@wentel opa, mudou o cara errado. Posso restaurar o leitor, ou tem algo do Tabela que vc precisa aqui ?


Can this be simplified to `return 'nsfw' in self.name` ?


What type of error?


Oh no, can you please show me the steps you used to install? We only want to exclude these files from deployments, not from local dev installs.


Related to: backdrop/backdrop-issues#2502


I still think an all time would be nice though :(


Trying to understand the commit process.


Recheck this


### 改动

- 她们的创造力与潜力,远超我们的想象

### 原因

后面的问题有女孩,念起来有点不对


Agreed. I think we removed it for the time being because the office monitor has 4:3 resolution and it wasn't looking great on it :P


The whole Sight/Sights thing is a bit of a mess. According to Gwynneth's styleguide, Sights is the official trademarked term. So if we were super concerned about that (I would be for marketing docs--not sure it matters  as much for API docs), it would have to be "Sights" at every mention. But since so much of the API docs already use "sight" (singular and with a lowercase s), I think we should stick with that. As for this, I could rewrite as "Get the 'Publish' settings for a sight" or something like that.


(?<=\\|\/)lib(?=\\cucumber|\/cucumber)


Do I just change it here? Or do I have to change it after all the other changes I've put in, i.e., a new Commit?


will remove some of the comments left in code


Hello Friend! Can you write more detailed instructions for installing this plugin?


It was either the require to the devDependency morgan or the session: true that made this barf in Heroku.
Most likely it was the require to morgan that didn't exist. ;)


Agreed. I think it needs rework. I just copied it over from a similar section in Get Users (I think). I can try to finesse it better tomorrow.


@aron-bordin opa, pode sim, desculpa hehe


Oopsie :)


I disagree. Just bulk refactor "sight" in those sections to "Sight"

Seth Martin | Smartsheet
Solutions Architect
E: Seth.Martin@Smartsheet.com
D: 425-326-3639

<https://www.smartsheet.com/engage?utm_source=email&utm_medium=signature&utm_campaign=emailEngage>

On Wed, Apr 26, 2017 at 4:49 PM, Kevin Fansler <notifications@github.com>
wrote:

> The whole Sight/Sights thing is a bit of a mess. According to Gwynneth's
> styleguide, Sights is the official trademarked term. So if we were super
> concerned about that (I would be for marketing docs--not sure it matters as
> much for API docs), it would have to be "Sights" at every mention. But
> since so much of the API docs already use "sight" (singular and with a
> lowercase s), I think we should stick with that. As for this, I could
> rewrite as "Get the 'Publish' settings for a sight" or something like that.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/smartsheet-platform/api-docs/commit/bdfdc88652bdf1dabbda7ad017a0a824957e5eb5#commitcomment-21925082>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AF0GSKedlp9CPsgOlHuhEd6KPiYCr0N9ks5rz9gbgaJpZM4NJfCJ>
> .
>


這框架看上去很nb啊……你有沒有試過用這個實現mergesort，從my_start到my_end裏用insertion之後再merge……


This does only take into account valids Lua types like `string`, `number`, `function` and `table` but would probably result in an error when the types are `Image`, `Thread` and such, in those cases it should be `type=ref`.


Are these the document and folder icons? I don't think they need to be in the gitignore


Created multidev environment [badcamp-2017#pr-79-creat](https://dashboard.pantheon.io/sites/8d658997-7a61-4db8-9be8-0f16b8b62022#pr-79-creat).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-79-creat-badcamp-2017.pantheonsite.io/)


either this needs a guard `navigator && ...` OR ideally `isIE10` would be called lazily.

refs #238


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.290.dfb8630db9f4deffc2b59c02d91c457e1581ccfd](http://build.palaso.org/viewLog.html?buildId=88523&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3586, ignored: 128 Build time: 00:05:46


Ideally `isIE10` this would be called lazily inside `getOffsetRectRelativeToArbitraryNode`.

refs #238


TeamCity libpalaso :: palaso-precise64-libpalaso-3.1 Continuous [Build 3.1.242.dfb8630db9f4deffc2b59c02d91c457e1581ccfd](http://build.palaso.org/viewLog.html?buildId=88525&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3564, ignored: 111 Build time: 00:06:36


Created multidev environment [badcamp-2017#pr-67a8f79](https://dashboard.pantheon.io/sites/8d658997-7a61-4db8-9be8-0f16b8b62022#pr-67a8f79).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-67a8f79-badcamp-2017.pantheonsite.io/)


Well Done!


回复


将 ./ 改为 .


syntax error: comma missing


This is not what we want to do for performance reasons, but also because it will cause problem with diffing since SVG element tag names are normalized to include a combination of upper and lower case characters. For example: https://developer.mozilla.org/en-US/docs/Web/SVG/Element/clipPath


被移除高级检测的误杀率有多少？个人认为，如果不是很高的话，为保证拦截率，一定程度的误杀是可以接受的。


笔误更正


hello


確認


@LegitSoulja Not your fault. I did it. I am created a new pr that allows for automatic module installation:

```
Checking Modules
11 Modules need to be installed
Installing Module(s)
[npm] [===============================] 100% Done!
[OpenAgar]Invalid key!, make sure you have the right key! Your id is: 3ApHqMCu8izVa9hDjA8L

```


#4131 XML variable substitution not working for configSections


Congrats!!


Here too :-)


you can add http://cartelmovies.net good site :)


@VoyagerOne no worries, personal reasons is actually good news, not bad. Everything's good here.
Will be here for a week or two longer, then offline for a month or so, then back on again.  Don't assume the worst!


스레드 예제


very nice!


not working

![img_0707](https://cloud.githubusercontent.com/assets/28034120/25416733/af1d4938-2a3f-11e7-8b50-1205507fe75a.PNG)


Double check the naming of this components.


I think this div should have been part of the ProductDetail component. Make sure you practice how to map over arrays to create arrays of components


Just walked by and wanted to leave a comment here.


Hard coding 0 does not seemed elegant...


hmm..let me try it


This breaks macOS build if opengl is not enabled
```
      'TGLIncludes.h' file not found
#include "TGLIncludes.h"
         ^~~~~~~~~~~~~~~
```


刚刚发现了。：-）


@jiegec @geekplux

抱歉现在才看到，是我忽略了通知，还是 github 根本没通知？

这个所谓 cache，跟 Angular 本身没有关系，只是简单暂存上一次搜索结果。

浪费一点用户端的内存，正常使用也就小几百克k，因为每次缓存都是建立在上一次搜索结果基础上，缓存的量是递减的，基本上输入 3~4 个单词就只剩个位数了。而且我对输入的关键字也做了一些简单的过滤：

即便故意输入 `a b c d e f g ...` 也不会造成什么问题，输入 `a b c c c c c c c ...` 缓存的还是 `a b c`，输入 `asdf` 缓存 0。

如果还有什么没考虑到的，被爆了，也是发生在用户端，不影响服务器 😅


Good Morning!


My reply comes here


Here comes a new reply


One more


Here is a reply


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.774.e65e8b866425e23ec8b3fc47718069fa7ac9d614](http://build.palaso.org/viewLog.html?buildId=88539&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 938, ignored: 57 Build time: 00:14:30


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.417.e65e8b866425e23ec8b3fc47718069fa7ac9d614](http://build.palaso.org/viewLog.html?buildId=88527&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 950, ignored: 51 Build time: 00:34:32