@ko1 @nobu Well, you're both well versed in c, and I'm not.  So, please don't expect me to have an opinion...

The patch I previously needed in [`test/socket/test_socket.rb`](https://github.com/ruby/ruby/blob/trunk/test/socket/test_socket.rb#L528)  was

```ruby
  def test_closed_read
    require 'timeout'
    require 'socket'
    bug4390 = '[ruby-core:35203]'
    server = TCPServer.new("localhost", 0)
    serv_thread = Thread.new {server.accept}
    begin sleep(0.1) end until serv_thread.stop?
-   sock = TCPSocket.new("localhost", server.addr[1])
+   sock = TCPSocket.new("localhost", server.addr[1]) ; sock.autoclose = false
    client_thread = Thread.new do
      sock.readline
    end
    begin sleep(0.1) end until client_thread.stop?
    Timeout.timeout(1) do
      sock.close
      sock = nil
      assert_raise(IOError, bug4390) {client_thread.join}
    end
  ensure
    serv_thread.value.close
    server.close
  end
```

Note - When I'm patching test files, I like to, if possible, keep the line numbering the same.

As mentioned, after applying @nobu's patch, I no longer need to patch `test_io.rb` or `test_socket.rb`.  Whether the tests are bad, or other code needs to be changed for Windows/MinGW builds, I don't know.

At least movement is being made toward getting MinGW builds working well, and maybe someday, appveyor could do a MinGW build and full test, rather than an mswin build with partial test.  And I appreciate that movement.  So, thank you.


nice


Hi David,

Sorry for the delay: this message got lost in an inbox overflow for a
little bit.  There's a bit of backround/history in the following; please
excuse the length but I thought it would be good to get this all in one
place, and possibly re-publish on the thespianpy.com site as general
information.

Thespian uses a custom event loop that is similar to the asyncore module
(https://docs.python.org/2/library/asyncore.html), but with a few small
differences.

Thespian does not use asyncio and one of the primary reasons for that is
because the async+coroutine+futures framework in Python is very new
(only added in Python 3.4) and is still undergoing a considerable amount
of changes.  Thespian was intended to support Python versions as old as
2.6 and provide a bit more stability.

One of the problems with these core loops is that they are designed to
make it easy to manage scheduling *within* their domain, but they don't
often have a way to integrate with other solutions very well.

Thespian provides the ability for the Actor to specify a list of sockets
(or on Linux, other file descriptor objects) that the Actor is managing
and it will enter the Actor when any one of those sockets is available
(see "Watching File Descriptors" in the "Thespian Actor Feature
Extensions" section of the Using Thespian document
(http://thespianpy.com/doc/using.html).  This works great if your
library is blocking on sockets/descriptors and you have a way for it to
divulge those to you.  However, this also is a "leaky abstraction"
because there is no guarantee that your ActorSystem supports and is
compatible with this functionality (there are specific Cababilities that
indicate if this is supported for each ActorSystem), so you lose a
degree of flexibility that the Actor model could otherwise provide.

Normally, I'd advise that asyncio and Actors are two different
approaches to the concurrency problem space, and that it would be better
to use just one.  However, when the library uses asyncio, that doesn't
give you as much freedom in that choice.

The asyncio implementation supports different event loop types
(https://docs.python/org/3/library/asyncio-eventloops.html), but the
execution is managed by the asyncio event loop, rather than externally.
Thespian is not written to allow the Actor to be aware of sockets or
file descriptors because that was too high of a level of abstraction
leakage.  Therefore, there's currently no direct method to get this
information to provide to asyncio's SelectorEventLoop.

Aside from the approach you've already tried, I would suggest either:

* Using a short-term Future and .run_until_finished(future) to perform
  iterative work (which still requires the periodic WakeupMessage to
  handle additional asyncio processing, with all of the associated
  unfortunate delays).

* Create another thread and run the asyncio.run_forever() in that
  thread.  You could utilize the SelectorEventLoop in that thraed and
  use a socket to communicate between the two threads.  This is a bit
  complicated, but would probably be more reliable.

Ultimately it might be interesting to investigate whether Thespian could
provide another asyncio event loop implementation that would allow
easier use of asyncio, but aside from the work involved, that approach
would probably need more investigation to ensure that there were no
fundamental conflicts between asyncio and the actor model.

Please let me know your thoughts and where this ends up for you.  I'm
also curious about which library you are trying to use that is
implementing using asyncio.

Regards,
  Kevin

David Asabina writes:

> Hey Kevin, was reading through the source to figure out how to get a
> library integrated that runs on top of asyncio. It seems like you coded
> your custom event loop, but perhaps I misread. How would you go about
> embedding something that runs on asyncio in an actor?
>
> I basically never start the asyncio event loop, but just trigger individual
> steps and the necessary timeout handlers after receiving a `WakeupMessage`
> so I don't really have to "block" the actor.
>
> I hate that solution, because from quick observation it became apparent
> that the package does some extra housekeeping which I didn't mimick. You
> probably already faced this issue hence my question.
>
> Otherwise, I'll figure something out.
>
> On 8 Apr 2017 10:03 PM, "kquick" <notifications@github.com> wrote:
>
>>
>> Hi David,
>>
>> I've merged the godaddy/Thespian and kquick/Thespian on the latter. I
>> will suggest to GoDaddy that they might want to do the same, but I
>> cannot guarantee they will do so. I do plan to continue to merge
>> godaddy repo changes into the kquick repo (unless I disagree with the
>> changes).
>>
>> Thanks for the suggestion, and I hope this helps.
>>
>> Regards,
>> Kevin
>>
>> David Asabina writes:
>>
>> > Hello Kevin,
>> >
>> > Just a few quick ones
>> >
>> > - are all tests passing on `master` right now? On my setup I have a few
>> failing tests on `master`, that is why I'm asking
>> > - if they all pass, which version of Python you are running your tests
>> against?
>> > - are you directly running `py.test` or `tox`?
>> > - it seems like the kquick/Thespian fork is the new home of the project
>> > - if so, will you submit a PR from kquick/Thespian into godaddy/Thespian
>> since there are the fork master branches now contain similar commits under
>> different refs, by different authors which makes tracking both reps harder
>>
>> —
>> You are receiving this because you commented.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/godaddy/Thespian/commit/e666c5f6f89e467a05b94041f26aea0e1728312a#commitcomment-21688264>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AAUeLnDSTY4doCo0fJJn4vqLea-2auPrks5rt-gsgaJpZM4M0juU>
>> .
>>


I would but there's more than one required patch for the audio codec since it requires a bunch of different additions from Intel related to the chipset output clock frequency. Hence it was just easier to do a full build. If someone wants to do a DKMS module for it would be great.


Hope in humanity: -20pt


Why am I still subscribed to this commit?


### Screenshot

![image](https://cloud.githubusercontent.com/assets/1924134/25067735/f5218a16-221a-11e7-9078-53ac889c3869.png)


Lol, this wasn't even my code :laughing:


Woops, see #14


Sparky is now a good time for me to write a menu example?

It will be a basic list menu with the VGA font for text and a solid color background. I will include instructions in the code on how to improve it from there. OK?


Did I forget to push 1.11?


I wasn't able to retrieve PDD puzzles from the code base (if you think that it's a bug on your our side, please submit it to [yegor256/0pdd](https://github.com/yegor256/0pdd/issues)):

```
cd /tmp/0pdd/EnigmaDragons/MegaBuy && pdd -q -f /tmp/pdd.xml20170416-11866-19v5f3m: 256 (not zero):
/app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd/source.rb:143:in `rescue in puzzles': ["in /tmp/0pdd/EnigmaDragons/MegaBuy/MegaBuy/Policies/PolicyPageUI.cs", #<PDD::Error: @todo found, but puzzle can't be parsed in line #9>] (PDD::Error)
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd/source.rb:141:in `puzzles'
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd.rb:97:in `block (3 levels) in xml'
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd.rb:96:in `each'
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd.rb:96:in `block (2 levels) in xml'
	from /app/vendor/bundle/ruby/2.2.0/gems/nokogiri-1.6.8.1/lib/nokogiri/xml/builder.rb:391:in `call'
	from /app/vendor/bundle/ruby/2.2.0/gems/nokogiri-1.6.8.1/lib/nokogiri/xml/builder.rb:391:in `insert'
	from /app/vendor/bundle/ruby/2.2.0/gems/nokogiri-1.6.8.1/lib/nokogiri/xml/builder.rb:375:in `method_missing'
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd.rb:95:in `block in xml'
	from /app/vendor/bundle/ruby/2.2.0/gems/nokogiri-1.6.8.1/lib/nokogiri/xml/builder.rb:293:in `initialize'
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd.rb:93:in `new'
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/lib/pdd.rb:93:in `xml'
	from /app/vendor/bundle/ruby/2.2.0/gems/pdd-0.17.3/bin/pdd:90:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.2.0/bin/pdd:23:in `load'
	from /app/vendor/bundle/ruby/2.2.0/bin/pdd:23:in `<main>'

/app/objects/exec.rb:38:in `run'
/app/objects/git_repo.rb:60:in `xml'
/app/objects/puzzles.rb:46:in `deploy'
/app/objects/job.rb:42:in `proceed'
/app/objects/job_starred.rb:35:in `proceed'
/app/objects/job_recorded.rb:33:in `proceed'
/app/objects/job_emailed.rb:36:in `proceed'
/app/objects/job_commiterrors.rb:36:in `proceed'
/app/objects/job_detached.rb:51:in `block in exclusive'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/timeout.rb:89:in `block in timeout'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/timeout.rb:34:in `block in catch'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/timeout.rb:34:in `catch'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/timeout.rb:34:in `catch'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/timeout.rb:104:in `timeout'
/app/objects/job_detached.rb:49:in `exclusive'
/app/objects/job_detached.rb:39:in `block in proceed'
/app/objects/job_detached.rb:39:in `fork'
/app/objects/job_detached.rb:39:in `proceed'
/app/0pdd.rb:201:in `block in <top (required)>'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1611:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1611:in `block in compile!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:975:in `[]'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:975:in `block (3 levels) in route!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:994:in `route_eval'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:975:in `block (2 levels) in route!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1015:in `block in process_route'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1013:in `catch'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1013:in `process_route'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:973:in `block in route!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:972:in `each'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:972:in `route!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1085:in `block in dispatch!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `block in invoke'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `catch'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `invoke'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1082:in `dispatch!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:907:in `block in call!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `block in invoke'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `catch'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `invoke'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:907:in `call!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:895:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/xss_header.rb:18:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/path_traversal.rb:16:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/json_csrf.rb:18:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/frame_options.rb:31:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-1.6.5/lib/rack/logger.rb:15:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-1.6.5/lib/rack/commonlogger.rb:33:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:219:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:212:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-1.6.5/lib/rack/head.rb:13:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-1.6.5/lib/rack/methodoverride.rb:22:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:182:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:2013:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1487:in `block in call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1787:in `synchronize'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1487:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-1.6.5/lib/rack/handler/webrick.rb:88:in `service'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/webrick/httpserver.rb:138:in `service'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/webrick/httpserver.rb:94:in `run'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/webrick/server.rb:294:in `block in start_thread'
```


:laughing: I don't like to litter the more complex commits with many small additional reformattings. :innocent:


Ok vou prestar mais atenção e melhorar isto, desculpe a demora para
responder o email veio para o meu pessoal ao invés do da cwi

Em 14 de abr de 2017 11:13 PM, "Bernardo Bosak de Rezende" <
notifications@github.com> escreveu:

> esses dois cenários de batalha, apesar de estarem corretos, deveriam estar
> em uma classe de testes de batalha, e não Saint.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/cwi-crescer-2017-1/rafael.barreto/commit/2adb122969c7bdb9ea6c30547820b2007ff870f8#commitcomment-21773408>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AOHGYZ5WSM9HNxRCvRA5i3GepTWBftbWks5rwCfOgaJpZM4M-OR8>
> .
>


I wasn't able to retrieve PDD puzzles from the code base (if you think that it's a bug on your our side, please submit it to [yegor256/0pdd](https://github.com/yegor256/0pdd/issues)):

```
no time information in ""
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/time.rb:252:in `make_time'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/time.rb:364:in `parse'
/app/objects/github_tickets.rb:58:in `submit'
/app/objects/emailed_tickets.rb:37:in `submit'
/app/objects/puzzles.rb:86:in `block in submit'
/app/vendor/bundle/ruby/2.2.0/gems/nokogiri-1.6.8.1/lib/nokogiri/xml/node_set.rb:187:in `block in each'
/app/vendor/bundle/ruby/2.2.0/gems/nokogiri-1.6.8.1/lib/nokogiri/xml/node_set.rb:186:in `upto'
/app/vendor/bundle/ruby/2.2.0/gems/nokogiri-1.6.8.1/lib/nokogiri/xml/node_set.rb:186:in `each'
/app/objects/puzzles.rb:86:in `map'
/app/objects/puzzles.rb:86:in `submit'
/app/objects/puzzles.rb:44:in `deploy'
/app/objects/job.rb:42:in `proceed'
/app/objects/job_starred.rb:35:in `proceed'
/app/objects/job_recorded.rb:33:in `proceed'
/app/objects/job_emailed.rb:36:in `proceed'
/app/objects/job_commiterrors.rb:36:in `proceed'
/app/objects/job_detached.rb:51:in `block in exclusive'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/timeout.rb:89:in `block in timeout'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/timeout.rb:34:in `block in catch'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/timeout.rb:34:in `catch'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/timeout.rb:34:in `catch'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/timeout.rb:104:in `timeout'
/app/objects/job_detached.rb:49:in `exclusive'
/app/objects/job_detached.rb:39:in `block in proceed'
/app/objects/job_detached.rb:39:in `fork'
/app/objects/job_detached.rb:39:in `proceed'
/app/0pdd.rb:201:in `block in <top (required)>'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1611:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1611:in `block in compile!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:975:in `[]'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:975:in `block (3 levels) in route!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:994:in `route_eval'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:975:in `block (2 levels) in route!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1015:in `block in process_route'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1013:in `catch'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1013:in `process_route'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:973:in `block in route!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:972:in `each'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:972:in `route!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1085:in `block in dispatch!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `block in invoke'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `catch'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `invoke'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1082:in `dispatch!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:907:in `block in call!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `block in invoke'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `catch'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1067:in `invoke'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:907:in `call!'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:895:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/xss_header.rb:18:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/path_traversal.rb:16:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/json_csrf.rb:18:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/base.rb:49:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-protection-1.5.3/lib/rack/protection/frame_options.rb:31:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-1.6.5/lib/rack/logger.rb:15:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-1.6.5/lib/rack/commonlogger.rb:33:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:219:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:212:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-1.6.5/lib/rack/head.rb:13:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-1.6.5/lib/rack/methodoverride.rb:22:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:182:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:2013:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1487:in `block in call'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1787:in `synchronize'
/app/vendor/bundle/ruby/2.2.0/gems/sinatra-1.4.7/lib/sinatra/base.rb:1487:in `call'
/app/vendor/bundle/ruby/2.2.0/gems/rack-1.6.5/lib/rack/handler/webrick.rb:88:in `service'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/webrick/httpserver.rb:138:in `service'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/webrick/httpserver.rb:94:in `run'
/app/vendor/ruby-2.2.2/lib/ruby/2.2.0/webrick/server.rb:294:in `block in start_thread'
```


I also got this from the initial exercise source...


Fixed majority of the warnings have i think 5(warnings) left that i have to look into more. Some activity will not look right until i figure out a way around the errors.


ok @MikeStegall the change has been viewed


@briandfoy Yeah seems so, I can merge 1.101 changes, and my non-pushed, but released code into a 1.12 ?


This change is due to `go fmt` (which runs whenever I save a file). It's keeping everything in this struct aligned


TeamCity Market :: INFRA :: Graphouse :: Graphouse on change [Build 75](https://teamcity.yandex-team.ru/viewLog.html?buildId=8425555&buildTypeId=MarketInfra_Graphouse_GraphouseOnChangeOpensource) outcome was **SUCCESS**
Summary: Tests passed: 11 Build time: 00:00:24


What is the right number here? Maybe ~14KB, since that's what TLS seems to be limiting its record sizes to?


Yes, I was thinking the same, but I was way too lazy, or confused with so many other questions, to be able to get to simplifying this :relaxed:


Extreme Lsg once world is loaded


@ianfab Oops, perhaps I should have submitted this as a nonfunctional [-5, 5] or [-10, 10] test.  I forgot to include this change which I had tuned with http://github.com/ddugovic/Stockfish/commit/3ac63bef2960a97c4b87d5fbf760532ab5b1cab4#diff-c74eb33120f9e932f7cfc0be07fa91d2R361 when I tested http://35.161.250.236:6543/tests/view/58efeeb56e23db2fa8081054


排列符号


jk


kk


Sorry, this was for version **2.7** and the spelling errors have already been fixed. :D


#49 - Addresses last bullet point - the one about the capitalization of Visitor


isn't the right number 32kb-1, e.g. maxint?
we can let Golang's socket write() determine how it wants to chunk it


s


life is like a box of chocolate


should this be in IntervalArithmetic.jl ?


Are you sure this  isn't a bug in ekf2. Did you try lpe? Did you try it in real life just walking around? I just want to avoid flipping signs to get the right answer until we know what we did wrong.

I plotted the magnetic declination estimator state from ekf2 in your log.

![image](https://cloud.githubusercontent.com/assets/473772/25067862/6a2b3822-221e-11e7-8bd7-c715ef41ab88.png)

Notice that there is no mag_E component at all. @priseborough, any idea what is going on here?


Base.show ?


WHWWHhaht


@siddharthmishrase26 Recreated using **Static methods** and **Reusing the method** `fibonacciSeries(long n)`
Please feel free suggesting changes. :smile_cat:


Excellent


wonder if these two .dll files could be replaced with the one in the SVP system. hmm
its interesting, would be a nice addition to it all by having SVP support in the internal player.
there is some that use it after all.
https://www.svp-team.com/wiki/SVP:mpv


These should help:

![image](https://cloud.githubusercontent.com/assets/473772/25067934/636117d0-2220-11e7-8241-83e8d8a7b903.png)

![image](https://cloud.githubusercontent.com/assets/473772/25067935/693a8970-2220-11e7-883b-a1bf946a9eeb.png)


This has broken every system that has the capability of loading media. For example, all of neogeo is broken.
"Fatal error: Device Neogeo Memory Card load () failed: file not found."
Can you please do some testing in future?


I don't expect we'll use this much... if at all. I added it because if you want to write some weird custom assertions...
You can write a function `func(t *testing.T, status queue.TaskStatusStructure)` and fetch whatever resources you want to...

For example you might want to make some assertion on the runs of the task... The assertions define here always looks at the last run...


Thank you meleu.  I've been playing around with it all day today.


Lembrando que eu [já escrevi sobre yarn](https://medium.com/@graciano/yarn-o-gerenciador-de-pacotes-do-facebook-a7b8d877794d) falando sobre essas coisas.


The docs for the gzmath library aren't great. So the easiest explanation would be that the Quaternion rotation definition is reversed form what I expected there (we need a negative sign), but if you guys could check i isn't something bigger, would appreciate it.


I don't have any problems with keeping it


@Andrews54757 look at this main-out.

Now I can read and understand this better.


Yeah, fairly standard. You can accept and then edit, or reject the pull
request.

I was guessing what typeof the variable was, which demonstrates why good
code commenting is important.

On 15 Apr 2017 9:55 PM, "Tim" <notifications@github.com> wrote:

> Im familiar with the comment style. It is the same that we use in java at
> uni and at work. Fairly standard everywhere?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/doctorjbeam/todo-list-OO-vanillaJS/commit/b0c2bb369acf67fdb285277ab97774513969164e#commitcomment-21774919>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAQ9BW2rqrMaCJFoi8kuakwfYHbpXjM1ks5rwLAygaJpZM4M-VD->
> .
>


Initial commit


Can*


Check common


Hi Kevin,

Thanks for the response. I have a bunch of actors that connect to a
RabbitMQ broker using pika and perform some work on incoming actor messages
in order to drop something on the RMQ bus.

Replies from RabbitMQ are interpreted and relayed to the sending actor of
the request.

Quite curious to know how you would tackle this issue.

I basically set up a pool of actors that connect to the broker and keep
their connection alive. Upon receiving a message the pool directs it to one
of the available members to process the message (which may involve sending
multiple messages on the RMQ bus and receiving and interpreting the
responses).

The SelectConnection adapter in pika blocks on calling start (this is the
asyncio event loop) which led me to manually step through the eventloop as
I described in my previous post.

On 16 Apr 2017 1:23 AM, "Kevin Quick" <notifications@github.com> wrote:

Hi David,

Sorry for the delay: this message got lost in an inbox overflow for a
little bit. There's a bit of backround/history in the following; please
excuse the length but I thought it would be good to get this all in one
place, and possibly re-publish on the thespianpy.com site as general
information.

Thespian uses a custom event loop that is similar to the asyncore module
(https://docs.python.org/2/library/asyncore.html), but with a few small
differences.

Thespian does not use asyncio and one of the primary reasons for that is
because the async+coroutine+futures framework in Python is very new
(only added in Python 3.4) and is still undergoing a considerable amount
of changes. Thespian was intended to support Python versions as old as
2.6 and provide a bit more stability.

One of the problems with these core loops is that they are designed to
make it easy to manage scheduling *within* their domain, but they don't
often have a way to integrate with other solutions very well.

Thespian provides the ability for the Actor to specify a list of sockets
(or on Linux, other file descriptor objects) that the Actor is managing
and it will enter the Actor when any one of those sockets is available
(see "Watching File Descriptors" in the "Thespian Actor Feature
Extensions" section of the Using Thespian document
(http://thespianpy.com/doc/using.html). This works great if your
library is blocking on sockets/descriptors and you have a way for it to
divulge those to you. However, this also is a "leaky abstraction"
because there is no guarantee that your ActorSystem supports and is
compatible with this functionality (there are specific Cababilities that
indicate if this is supported for each ActorSystem), so you lose a
degree of flexibility that the Actor model could otherwise provide.

Normally, I'd advise that asyncio and Actors are two different
approaches to the concurrency problem space, and that it would be better
to use just one. However, when the library uses asyncio, that doesn't
give you as much freedom in that choice.

The asyncio implementation supports different event loop types
(https://docs.python/org/3/library/asyncio-eventloops.html), but the
execution is managed by the asyncio event loop, rather than externally.
Thespian is not written to allow the Actor to be aware of sockets or
file descriptors because that was too high of a level of abstraction
leakage. Therefore, there's currently no direct method to get this
information to provide to asyncio's SelectorEventLoop.

Aside from the approach you've already tried, I would suggest either:

* Using a short-term Future and .run_until_finished(future) to perform
iterative work (which still requires the periodic WakeupMessage to
handle additional asyncio processing, with all of the associated
unfortunate delays).

* Create another thread and run the asyncio.run_forever() in that
thread. You could utilize the SelectorEventLoop in that thraed and
use a socket to communicate between the two threads. This is a bit
complicated, but would probably be more reliable.

Ultimately it might be interesting to investigate whether Thespian could
provide another asyncio event loop implementation that would allow
easier use of asyncio, but aside from the work involved, that approach
would probably need more investigation to ensure that there were no
fundamental conflicts between asyncio and the actor model.

Please let me know your thoughts and where this ends up for you. I'm
also curious about which library you are trying to use that is
implementing using asyncio.

Regards,
Kevin

David Asabina writes:

> Hey Kevin, was reading through the source to figure out how to get a
> library integrated that runs on top of asyncio. It seems like you coded
> your custom event loop, but perhaps I misread. How would you go about
> embedding something that runs on asyncio in an actor?
>
> I basically never start the asyncio event loop, but just trigger
individual
> steps and the necessary timeout handlers after receiving a `WakeupMessage`
> so I don't really have to "block" the actor.
>
> I hate that solution, because from quick observation it became apparent
> that the package does some extra housekeeping which I didn't mimick. You
> probably already faced this issue hence my question.
>
> Otherwise, I'll figure something out.
>
> On 8 Apr 2017 10:03 PM, "kquick" <notifications@github.com> wrote:
>
>>
>> Hi David,
>>
>> I've merged the godaddy/Thespian and kquick/Thespian on the latter. I
>> will suggest to GoDaddy that they might want to do the same, but I
>> cannot guarantee they will do so. I do plan to continue to merge
>> godaddy repo changes into the kquick repo (unless I disagree with the
>> changes).
>>
>> Thanks for the suggestion, and I hope this helps.
>>
>> Regards,
>> Kevin
>>
>> David Asabina writes:
>>
>> > Hello Kevin,
>> >
>> > Just a few quick ones
>> >
>> > - are all tests passing on `master` right now? On my setup I have a few
>> failing tests on `master`, that is why I'm asking
>> > - if they all pass, which version of Python you are running your tests
>> against?
>> > - are you directly running `py.test` or `tox`?
>> > - it seems like the kquick/Thespian fork is the new home of the project
>> > - if so, will you submit a PR from kquick/Thespian into
godaddy/Thespian
>> since there are the fork master branches now contain similar commits
under
>> different refs, by different authors which makes tracking both reps
harder
>>
>> —
>> You are receiving this because you commented.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/godaddy/Thespian/commit/
e666c5f6f89e467a05b94041f26aea0e1728312a#commitcomment-21688264>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/
AAUeLnDSTY4doCo0fJJn4vqLea-2auPrks5rt-gsgaJpZM4M0juU>
>> .

>>

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/godaddy/Thespian/commit/e666c5f6f89e467a05b94041f26aea0e1728312a#commitcomment-21776963>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUeLi93kzpYgawVqiApmsNwYSoaSXvQks5rwV9xgaJpZM4M0juU>
.


I know this isn't code support - but what would be the best course of action when merging on top of https://github.com/DirtyUnicorns/android_kernel_huawei_angler/commit/b3123d82c3b1063d7234189c77a60ecf0e0e77cd (commit is most definitely merged incorrectly there), with the goal of the least amount of cycles possible.

Would it be better to just move the check after checking to see if we need to free the memory, remove that check entirely, or check directly against policy->last_cpu rather than stats to see if we can break out early (assuming we can even do that)?


What's the difference between a `NullState` and `StateUnknown`?


@nychitman1 Stats will never update if we're null checking before it's set.


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/9c1fa7ec-0edf-40af-a4ea-9bb71fdf8a02 "deskbuddy"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/5e00d304-9915-45e3-aee8-f6e427940b44 "deskbuddy-dev") deployed [deskbuddy-services](https://github.com/tonykambo/deskbuddy-services/releases/tag/deploy-ibm-yp-us-south-akambour-au1.ibm.com-DeskBuddy-dev-20170416-014442 "deploy-ibm-yp-us-south-akambour-au1.ibm.com-DeskBuddy-dev-20170416-014442") to [DeskBuddy-dev](https://console.ng.bluemix.net/apps/6e7f4497-e03e-447a-bd93-c37dabe1b67a "ibm:yp:us-south:akambour@au1.ibm.com:DeskBuddy-dev"), including this commit


Should this be `OldTournamentURLNode` or was `OldTournamentAbsoluteURLNode` accidentally deleted in this commit? I've tried a few different options here but the randomised URLs link still seems to throw an exception.


Thx


@LegitSoulja Srsly? Secret society? What is this?


@MCPEPIG do you want to be my dev?


The name should be "Public Society Since There Is Actually No Secrets On The Internet".


blz mano vey


@LegitSoulja If you want true secrets, learn command line, then I could set up a private git server very easily.


Review approved.  This all looks great!  Excellent work!


Spam comments again :-/


Elég lett volna a swapset felvenni a belső ciklus elé. Ha cseréltél, akkor növeled az értékét. És a kjülső ciklus után kell megnézni, hogy 0-e. Ha 0, akkor break. A tabolásból látszik a pseudocode-ban, hogy hol van a helye.


True, fixed, thanks


Ide swaps = 0


Itt a belső ciklus után a swaps == 0 ellenőrzés.


创建长度为5的学生成绩数组，分别输入成绩，并输出。

//数组

1.创建长度为5的学生成绩数组，分别输入成绩，并输出。

double []score=new double[5];

2.求总分，平均分

3.求最高分和最低分

4.排序

5.给每个学生+5分，最高不能超过100。


The gmchange.creative / spectator and gmchange.others permission are there to allow only staff to be able to change your gamemode.

Also, you aren't checking the command issued, and you can't rely on other plugins not using 'c' or 'spectator' as the first argument.

What exactly are the issues you want to fix?


🤔 Yeah and some people are getting pissed off as people can't type ideas.


hmm... Maybe there should be a projectlatte-ideas


Well, of cause that's why there is a channel called "projectlatte"


I can't do anything though - I'm only the owner of this repo and only have the "Latte" which means I can talk there


J'ai modifié 2/3 trucs, si tu veux ré-integrer ça sur ton repo


I'll ask Lance next time he is on ;)


asdasdasd


asd


Fine maybe an admin should make a new channel called project latte ideas. And hide the dev chat


rip discord


Well this is a lot of comments, I'll ask Victor


@rneher including details to make the table easier to read and use.


use this.setActivityFragment


There you go


A new channel!


Fixed :)


Thanks


AHHH HE'S HERE AS WELL?!


Oh god this comment spam...


I personally think the dev chat should be private but if it stays public that's fine


Wprowadzono Siatkę (Grid) do pliku MainWindow.xaml


Haha Victor I think you should get back to that game 😂😏


`cursor: pointer,
border: 0,
box-shadow: 0px -5px 0px 0px rgba(0,0,0,0.26) inset;`
на `:active {box-shadow:0;}` получишь эффект нажатия

тень примерная, можешь поиграться http://www.cssmatic.com/box-shadow
для более точного результата


I think that's enough comments. I'm locking this... Anything else you want to say?


Before I put the lock on this?


Fine


I'll take that as nothing else to say


Locked!


`width` не ограничиваем для остальных блоков писать не буду, но понятно


предпочтительно возвращать регулярный набор данных, т.е. всегда два значения. Так проще анализировать результат на вызывающей стороне.
Т.е.
```
return x3, None
```
и
```
return None, None
```
для одного и 0 корней соответственно


What? Is this just something logically wrong? I mean changing something from false to true?


маргин у блока `titles` тут убрать


>3.16.7 compiles OK with aufs-3.16
but 3.16.35 produces the compile errors
Perhaps we could ask @sfjro to fix aufs-3.16 given that 3.16 has an EOL of 2020?

>I suppose we could always crowd-fund @sfjro ￼

perhaps not such a silly idea...


Whoops found another thing but just saying before i go accessing this github website on my phone is hard lol


TeamCity DevOpsFinal :: Build [Build 17](http://localhost:9494/viewLog.html?buildId=35&buildTypeId=DevOpsFinal_Build) is now running


TeamCity DevOpsFinal :: Build [Build 17](http://localhost:9494/viewLog.html?buildId=35&buildTypeId=DevOpsFinal_Build) outcome was **SUCCESS**
Summary: Tests passed: 25 Build time: 00:00:25


сделай длину этой линии например `300px`
и она уже не по центру
поэтому правильные стили:
для `title { display: flex; flex-direction: column; align-items: center; }`
элемент не `:before` а `:after` убираем `position: absolute; right; top;` и ставим `margin-top`


It should check for attribute first, as that method wont work for hooks which are defined in sh_hooks


14 - accepted
15 - название переменной `is_crossing` не совсем удачное, т.к. она не булевая. Лучше подойдет, например, `delta`. Кроме того. не понятно почему если `delta` > 0, то Вы возвращаете True. Ведь в этом случае окружности не пересекаются?


I'll send you the spreadsheet in a moment. However in all 3 reference manuals for whole STM32L0 family I see that there is only one interrupt table layout per manual, so there may be no more than 3 variants - one for L0x3, one for L0x2 and one for L0x1. Whether or not a particular chip has particular peripheral doesn't matter. What I mean is that if (I'm making the number up) STM32L011 has no TIM22, there's no problem to have a vector entry for that particular peripheral anyway - this chip won't have anything different there.


16 - accepted. Только я бы добавил сравнение на <=. Т.е. если они одновременно пришли в одну точку, то это означает столкновение. Но это мелочи)


[R/cleanup.R:12:1:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/cleanup.R#L12) *style:* **Variable or function name should be snake_case.**
```r
cleanup.Globals <- function(globals, drop = c("missing", "base-packages"),
^~~~~~~~~~~~~~~
```
[R/cleanup.R:30:11:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/cleanup.R#L30) *warning:* **no visible global function definition for ‘is_base_pkg’**
```r
      if (is_base_pkg(environmentName(where[[name]]))) keep[name] <- FALSE
          ^~~~~~~~~~~
```
[R/cleanup.R:44:11:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/cleanup.R#L44) *warning:* **no visible global function definition for ‘is_internal’**
```r
      if (is_internal(globals[[name]])) keep[name] <- FALSE
          ^~~~~~~~~~~
```
[R/findGlobals.R:17:10:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L17) *warning:* **no visible global function definition for ‘makeUsageCollector’**
```r
    w <- makeUsageCollector(fun, name = "<anonymous>", enterGlobal = enter)
         ^~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:18:21:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L18) *warning:* **no visible global function definition for ‘inject_tracer_to_walker’**
```r
    if (trace) w <- inject_tracer_to_walker(w)
                    ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:19:5:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L19) *warning:* **no visible global function definition for ‘collect_usage_function’**
```r
    collect_usage_function(fun, name = "<anonymous>", w)
    ^~~~~~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:22:12:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L22) *warning:* **no visible global function definition for ‘as_function’, Did you mean 'as.function'?**
```r
    fun <- as_function(expr, envir = envir, ...)
           ^~~~~~~~~~~
```
[R/findGlobals.R:26:10:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L26) *warning:* **no visible global function definition for ‘makeUsageCollector’**
```r
    w <- makeUsageCollector(fun, name = "<anonymous>", enterGlobal = enter)
         ^~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:28:21:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L28) *warning:* **no visible global function definition for ‘inject_tracer_to_walker’**
```r
    if (trace) w <- inject_tracer_to_walker(w)
                    ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:29:1:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L29) *style:* **Trailing whitespace is superfluous.**
```r

^~~~
```
[R/findGlobals.R:30:15:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L30) *warning:* **no visible global function definition for ‘findLocalsList’**
```r
    locals <- findLocalsList(list(expr))
              ^~~~~~~~~~~~~~
```
[R/findGlobals.R:32:5:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L32) *warning:* **no visible global function definition for ‘walkCode’**
```r
    walkCode(expr, w)
    ^~~~~~~~
```
[R/findGlobals.R:50:10:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L50) *warning:* **no visible global function definition for ‘makeUsageCollector’**
```r
    w <- makeUsageCollector(fun, name = "<anonymous>", enterGlobal = enter)
         ^~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:51:21:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L51) *warning:* **no visible global function definition for ‘inject_tracer_to_walker’**
```r
    if (trace) w <- inject_tracer_to_walker(w)
                    ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:52:5:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L52) *warning:* **no visible global function definition for ‘collect_usage_function’**
```r
    collect_usage_function(fun, name = "<anonymous>", w)
    ^~~~~~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:54:12:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L54) *warning:* **no visible global function definition for ‘as_function’, Did you mean 'as.function'?**
```r
    fun <- as_function(expr, envir = envir, ...)
           ^~~~~~~~~~~
```
[R/findGlobals.R:55:10:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L55) *warning:* **no visible global function definition for ‘makeUsageCollector’**
```r
    w <- makeUsageCollector(fun, name = "<anonymous>", enterGlobal = enter)
         ^~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:56:21:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L56) *warning:* **no visible global function definition for ‘inject_tracer_to_walker’**
```r
    if (trace) w <- inject_tracer_to_walker(w)
                    ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:57:5:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L57) *warning:* **no visible global function definition for ‘walkCode’**
```r
    walkCode(expr, w)
    ^~~~~~~~
```
[R/findGlobals.R:101:21:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L101) *warning:* **no visible global function definition for ‘inject_tracer_to_walker’**
```r
    if (trace) w <- inject_tracer_to_walker(w)
                    ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:102:5:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L102) *warning:* **no visible global function definition for ‘collect_usage_function’**
```r
    collect_usage_function(fun, name = "<anonymous>", w)
    ^~~~~~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:104:12:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L104) *warning:* **no visible global function definition for ‘as_function’, Did you mean 'as.function'?**
```r
    fun <- as_function(expr, envir = envir, ...)
           ^~~~~~~~~~~
```
[R/findGlobals.R:108:21:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L108) *warning:* **no visible global function definition for ‘inject_tracer_to_walker’**
```r
    if (trace) w <- inject_tracer_to_walker(w)
                    ^~~~~~~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:109:5:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L109) *warning:* **no visible global function definition for ‘walkCode’**
```r
    walkCode(expr, w)
    ^~~~~~~~
```
[R/findGlobals.R:135:5:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L135) *warning:* **no visible global function definition for ‘mdebug’, Did you mean 'debug'?**
```r
    mdebug(" - expr: <a list of length %d>", length(expr))
    ^~~~~~
```
[R/findGlobals.R:168:5:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L168) *warning:* **no visible global function definition for ‘mdebug’, Did you mean 'debug'?**
```r
    mdebug(" - tweaking expression using function")
    ^~~~~~
```
[R/findGlobals.R:173:23:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L173) *warning:* **no visible binding for global variable ‘find_globals_ordered’**
```r
    find_globals_t <- find_globals_ordered
                      ^~~~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:175:23:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L175) *warning:* **no visible binding for global variable ‘find_globals_conservative’**
```r
    find_globals_t <- find_globals_conservative
                      ^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:177:23:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L177) *warning:* **no visible binding for global variable ‘find_globals_liberal’**
```r
    find_globals_t <- find_globals_liberal
                      ^~~~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:197:7:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L197) *warning:* **no visible global function definition for ‘mdebug’, Did you mean 'debug'?**
```r
      mdebug(" - detected: %s", dQuote(trim(w$message)))
      ^~~~~~
```
[R/findGlobals.R:197:40:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L197) *warning:* **no visible global function definition for ‘trim’, Did you mean 'arima'?**
```r
      mdebug(" - detected: %s", dQuote(trim(w$message)))
                                       ^~~~
```
[R/findGlobals.R:215:3:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L215) *warning:* **no visible global function definition for ‘mdebug’, Did you mean 'debug'?**
```r
  mdebug(" - globals found: [%d] %s", length(globals), hpaste(sQuote(globals)))
  ^~~~~~
```
[R/findGlobals.R:215:56:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L215) *warning:* **no visible global function definition for ‘hpaste’, Did you mean 'paste'?**
```r
  mdebug(" - globals found: [%d] %s", length(globals), hpaste(sQuote(globals)))
                                                       ^~~~~~
```
[R/findGlobals.R:243:20:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L243) *warning:* **no visible global function definition for ‘drop_missing_formals’**
```r
  formals_clean <- drop_missing_formals(formals)
                   ^~~~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:244:13:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L244) *warning:* **no visible global function definition for ‘findLocalsList’**
```r
  locals <- findLocalsList(c(list(body), formals_clean))
            ^~~~~~~~~~~~~~
```
[R/findGlobals.R:248:28:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L248) *warning:* **no visible global function definition for ‘walkCode’**
```r
  for (a in formals_clean) walkCode(a, w)
                           ^~~~~~~~
```
[R/findGlobals.R:250:3:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L250) *warning:* **no visible global function definition for ‘walkCode’**
```r
  walkCode(body, w)
  ^~~~~~~~
```
[R/findGlobals.R:257:3:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L257) *warning:* **local variable ‘args’ assigned but may not be used**
```r
  args <- setdiff(names(f), c("w", "..."))
  ^~~~
```
[R/findGlobals.R:258:3:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L258) *warning:* **local variable ‘title’ assigned but may not be used**
```r
  title <- sprintf("%s():", name)
  ^~~~~
```
[R/findGlobals.R:270:7:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L270) *style:* **Variable or function name should be snake_case.**
```r
    w$startCollectLocals <- function(parnames, locals, ...) { NULL }
      ^~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:273:7:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L273) *style:* **Variable or function name should be snake_case.**
```r
    w$finishCollectLocals <- function(w, ...) { NULL }
      ^~~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:276:7:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L276) *style:* **Variable or function name should be snake_case.**
```r
    w$enterInternal <- function(type, v, e, ...) { NULL }
      ^~~~~~~~~~~~~
```
[R/findGlobals.R:278:1:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L278) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/findGlobals.R:280:20:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L280) *style:* **Trailing whitespace is superfluous.**
```r
    fcn <- w[[key]]
                   ^
```
[R/findGlobals.R:282:12:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L282) *warning:* **no visible global function definition for ‘inject_tracer_to_function’**
```r
    fcn <- inject_tracer_to_function(fcn, key)
           ^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/findGlobals.R:285:1:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/findGlobals.R#L285) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[R/Globals-class.R:16:1:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/Globals-class.R#L16) *style:* **Variable or function name should be snake_case.**
```r
Globals <- function(object = list(), ...) {
^~~~~~~
```
[R/Globals-class.R:66:3:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/Globals-class.R#L66) *warning:* **no visible global function definition for ‘Globals’**
```r
  Globals(x, ...)
  ^~~~~~~
```
[R/Globals-class.R:178:1:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/Globals-class.R#L178) *style:* **Variable or function name should be snake_case.**
```r
unique.Globals <- function(x, ...) {
^~~~~~~~~~~~~~
```
[R/globalsOf.R:62:1:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L62) *style:* **Variable or function name should be snake_case.**
```r
globalsOf <- function(expr, envir = parent.frame(), ...,
^~~~~~~~~
```
[R/globalsOf.R:64:57:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L64) *style:* **Variable or function name should be snake_case.**
```r
                      tweak = NULL, substitute = FALSE, mustExist = TRUE,
                                                        ^~~~~~~~~
```
[R/globalsOf.R:80:5:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L80) *warning:* **no visible global function definition for ‘globalsByName’**
```r
    globalsByName(names, envir = envir, mustExist = mustExist)
    ^~~~~~~~~~~~~
```
[R/globalsOf.R:95:5:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L95) *warning:* **no visible global function definition for ‘mdebug’, Did you mean 'debug'?**
```r
    mdebug(" - recursive scan of preliminary globals ...")
    ^~~~~~
```
[R/globalsOf.R:100:34:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L100) *warning:* **no visible binding for global variable ‘envname’, Did you mean 'unname'?**
```r
    where <- sapply(where, FUN = envname)
                                 ^~~~~~~
```
[R/globalsOf.R:115:9:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L115) *warning:* **no visible global function definition for ‘mdebug’, Did you mean 'debug'?**
```r
        mdebug("   + scanning global #%d (%s) ...", gg, sQuote(names_t[[gg]]))
        ^~~~~~
```
[R/globalsOf.R:130:7:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L130) *warning:* **no visible global function definition for ‘mdebug’, Did you mean 'debug'?**
```r
      mdebug(" - subset of globals to be scanned: [0]")
      ^~~~~~
```
[R/globalsOf.R:133:5:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L133) *warning:* **no visible global function definition for ‘mdebug’, Did you mean 'debug'?**
```r
    mdebug(" - recursive scan of preliminary globals ... DONE")
    ^~~~~~
```
[R/globalsOf.R:159:1:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L159) *style:* **Variable or function name should be snake_case.**
```r
globalsByName <- function(names, envir = parent.frame(), mustExist = TRUE,
^~~~~~~~~~~~~
```
[R/globalsOf.R:159:58:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L159) *style:* **Variable or function name should be snake_case.**
```r
globalsByName <- function(names, envir = parent.frame(), mustExist = TRUE,
                                                         ^~~~~~~~~
```
[R/globalsOf.R:165:3:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L165) *warning:* **no visible global function definition for ‘mdebug’, Did you mean 'debug'?**
```r
  mdebug("- search from environment: %s", sQuote(envname(envir)))
  ^~~~~~
```
[R/globalsOf.R:165:50:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L165) *warning:* **no visible global function definition for ‘envname’, Did you mean 'unname'?**
```r
  mdebug("- search from environment: %s", sQuote(envname(envir)))
                                                 ^~~~~~~
```
[R/globalsOf.R:171:3:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L171) *warning:* **no visible global function definition for ‘mdebug’, Did you mean 'debug'?**
```r
  mdebug("- dotdotdot: %s", needs_dotdotdot)
  ^~~~~~
```
[R/globalsOf.R:177:5:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L177) *warning:* **no visible global function definition for ‘mdebug’, Did you mean 'debug'?**
```r
    mdebug("- locating #%d (%s)", kk, sQuote(name))
    ^~~~~~
```
[R/globalsOf.R:179:5:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L179) *warning:* **no visible global function definition for ‘mdebug’, Did you mean 'debug'?**
```r
    mdebug("  + found in environment: %s", sQuote(envname(env)))
    ^~~~~~
```
[R/globalsOf.R:179:51:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/globalsOf.R#L179) *warning:* **no visible global function definition for ‘envname’, Did you mean 'unname'?**
```r
    mdebug("  + found in environment: %s", sQuote(envname(env)))
                                                  ^~~~~~~
```
[R/packagesOf.R:2:1:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/packagesOf.R#L2) *style:* **Variable or function name should be snake_case.**
```r
packagesOf <- function(...) UseMethod("packagesOf")
^~~~~~~~~~
```
[R/packagesOf.R:13:1:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/packagesOf.R#L13) *style:* **Variable or function name should be snake_case.**
```r
packagesOf.Globals <- function(globals, ...) {
^~~~~~~~~~~~~~~~~~
```
[R/utils.R:19:13:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/utils.R#L19) *warning:* **no visible global function definition for ‘find_base_pkgs’**
```r
  pkgs %in% find_base_pkgs()
            ^~~~~~~~~~~~~~
```
[R/utils.R:25:3:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/utils.R#L25) *warning:* **no visible global function definition for ‘is_base_pkg’**
```r
  is_base_pkg(environmentName(environment(x)))
  ^~~~~~~~~~~
```
[R/walkAST.R:17:1:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/walkAST.R#L17) *style:* **Variable or function name should be snake_case.**
```r
walkAST <- function(expr, atomic = NULL, name = NULL, call = NULL,
^~~~~~~
```
[R/where.R:25:7:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/where.R#L25) *warning:* **no visible global function definition for ‘mdebug’, Did you mean 'debug'?**
```r
      mdebug("  + found in location: %s", sQuote(envname(env)))
      ^~~~~~
```
[R/where.R:25:50:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/where.R#L25) *warning:* **no visible global function definition for ‘envname’, Did you mean 'unname'?**
```r
      mdebug("  + found in location: %s", sQuote(envname(env)))
                                                 ^~~~~~~
```
[R/where.R:31:7:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/where.R#L31) *warning:* **no visible global function definition for ‘mdebug’, Did you mean 'debug'?**
```r
      mdebug("  + failed to located: NULL")
      ^~~~~~
```
[R/where.R:39:3:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/R/where.R#L39) *warning:* **no visible global function definition for ‘mdebug’, Did you mean 'debug'?**
```r
  mdebug("- failed to located: NULL")
  ^~~~~~
```
[tests/dotdotdot.R:150:14:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/tests/dotdotdot.R#L150) *warning:* **no visible global function definition for ‘globalsOf’, Did you mean 'globals'?**
```r
  globals <- globalsOf(expr, dotdotdot = "ignore")
             ^~~~~~~~~
```
[tests/dotdotdot.R:159:14:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/tests/dotdotdot.R#L159) *warning:* **no visible global function definition for ‘globalsOf’, Did you mean 'globals'?**
```r
  globals <- globalsOf(expr, dotdotdot = "return")
             ^~~~~~~~~
```
[tests/dotdotdot.R:173:14:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/tests/dotdotdot.R#L173) *warning:* **no visible global function definition for ‘globalsOf’, Did you mean 'globals'?**
```r
  globals <- globalsOf(expr, dotdotdot = "warn")
             ^~~~~~~~~
```
[tests/dotdotdot.R:187:18:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/tests/dotdotdot.R#L187) *warning:* **no visible global function definition for ‘globalsOf’, Did you mean 'globals'?**
```r
  globals <- try(globalsOf(expr, dotdotdot = "error"))
                 ^~~~~~~~~
```
[tests/dotdotdot.R:199:12:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/tests/dotdotdot.R#L199) *warning:* **no visible global function definition for ‘globalsOf’, Did you mean 'globals'?**
```r
globals <- globalsOf(exprs, dotdotdot = "return")
           ^~~~~~~~~
```
[tests/formulas.R:19:3:](https://github.com/HenrikBengtsson/globals/blob/2837da4188cfbe05c1cb8ff5f304b3fad9402e68/tests/formulas.R#L19) *warning:* **no visible global function definition for ‘map’, Did you mean 'mad'?**
```r
  map(1L, ~ typeof(x + .x))
  ^~~
```


Great 🎉! These should be relocated so removal of them from this class looks good!


посмотрите на возможные конфигурации:
https://videouroki.net/videouroki/conspekty/geom9/18-vzaimnoie-raspolozhieniie-dvukh-okruzhnostiei.files/image007.jpg


нужно убрать свойство `align-items: center`, потому что 2-ой блок по размеру меньше чем остальные и он становится по центру относительно родительского


Is this change intended? In such case why? Or is this a mistake?


16 - accepted. Только я бы добавил сравнение на >=. Т.е. если они одновременно пришли в одну точку, то это тоже означает столкновение. Но это мелочи)


You have changes to the imports in many of the files in this commit. Not only here but in loads of files further down. You need to import the latest IntelliJ settings. I auto optimised all imports recently. You must have a different import rule set.


I'm excited to see everything when its finished


Fix your imports :).


Fix your imports :)


Fix your imports... will stop commenting this now but it goes for all files pretty much.


Расчетные функции не должны печатать. Возвращайте результат вызывающей стороне.
И дискриминант должен вычисляться внутри функции.


в дизайне все описание в три строки, поэтому надо добавить ограничение `max-width: 180px;`


Fix your imports!


It's pretty much just fixing the imports that's required. Otherwise the contents of this commit looks great and all 🎉!


это не `h4` а `div class="list__item-description' потому что это не заголовок, а описание
в остальных `list__item` тоже самое надо поменять


Objective-C


это не `h4` а `div class="list__item-description` потому что это не заголовок, а описание
в остальных `list__item` тоже самое надо поменять


imgsend is missing


Did you import the latest IntelliJ settings? I just optimized imports? This should not happen?


@DIYgod
It still can't work


The implementation is not 100% correct since having bricks is not cost but condition.
Also you may not create inner class for it.

For reference you may look into ArgentSphinx, so your 2nd ability would be:
`
Ability ability2 = new ActivateIfConditionActivatedAbility(Zone.BATTLEFIELD, new
            AddManaOfAnyColorEffect(3), new TapSourceCost(), <CONDITION FOR HAVING COUNTERS>);
`

Wanted to suggest to make such condition more general to be used on other cards but then found we already have one:
`
PermanentHasCounterCondition
`


Missing space after catch


This commit looks great, all in all. Just the imports settings you need to update. And add that space. I had no further feedback other than that this looks great otherwise :).


s/Src/Source/


че за хуйня


Any reason you didn't make the argument names the `posn`, `change`, `previous` terms you used in the comment?


Added description of the repository


delete


You have not updated your import settings?


Commits of this kind are not OK. I can not review if you changed the file endings of the entire file. This should be covered in the tutorials on the main website I think.


логика ясна, но можно просто `.team .title:before { `...`}


jjj


This could be simplified into

 ```
this.todos.forEach(function(aTodo){
      aTodo.completed = !allTrue;
 });
```

But I personally don't mind a little verbosity in exchange for clarity.


да, я думал над этим (добавлять/не добавлять)... ведь это маловероятно, но возможно )


@jeyboy - I am not a big fan of using class << self - it makes code hard to debug.. because you can barely know whether its a class method. You can either use... a module and extend it in a class or use def self.method_name


![badge](https://img.shields.io/badge/appsnap-warning-cdb62c.svg) There are 20 visual regressions in this pull request

Please Visit https://github.com to check out these diffs
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale
* screen **undefined** on **undefined** for **undefined** locale

| Diff 1 | Diff 2 | Diff 3 | Diff 4 | Diff 5 | Diff 6 | Diff 7 | Diff 8 | Diff 9 | Diff 10 | Diff 11 | Diff 12 | Diff 13 | Diff 14 | Diff 15 | Diff 16 | Diff 17 | Diff 18 | Diff 19 | Diff 20 |
| ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- | ------------- |
| [![Image of Diff1](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone5-back%20to%20Rogue%20on%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff2](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone5-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff3](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone6-back%20to%20Rogue%20on%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff4](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone7-back%20to%20Rogue%20on%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff5](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone7-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff6](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone6-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff7](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone6-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff8](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone7-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff9](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone5-back%20to%20similar%20movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff10](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone6Plus-back%20to%20Rogue%20on%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff11](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone5-Similar%20Movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff12](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone5-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff13](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone6-Similar%20Movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff14](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone7-Similar%20Movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff15](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone7-back%20to%20similar%20movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff16](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone6-back%20to%20similar%20movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff17](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone6Plus-star%20wars%20episode%20IV%3A%20a%20new%20hope-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff18](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone6Plus-Rogue%20One%3A%20a%20star%20wars%20story-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff19](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone6Plus-Similar%20Movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) | [![Image of Diff20](https://appsnap.s3-eu-west-1.amazonaws.com/bcojan/movies3/3/23/diffs/en-US_iPhone6Plus-back%20to%20similar%20movies-d41d8cd98f00b204e9800998ecf8427e_thumbnail.png)](http://localhost:3000/diffs/588b0e3db9e9f31f0cb57459/5885f205360140da2e3762ee/588b34f983fa402cd6e9f00a) |


Definitely an annoyance of `forEach`.


True, can we change the default for the case statement just to be StateUnknown? As there is no way that it can become the default.


каждое фото не должно отступать вверх, нужно делать `margin` у `.list`


Elements can have multiple classes--to make this more robust, I think you want to check if the className contains `deleteBtn` (I could be off on exactly how you see if an element with multiple classes has a particular class)


The tertiary statement (`((todoList.todos.length === 1) ? " left!" : " items remaining")`) should have `todoList.countIncomplete() === 1` instead of `todoList.todos.length === 1`--otherwise, after you add 2 or more items, the display will eventually say "1 items remaining".


Broken file endings!?


Broken file endings!? This is not reviewable.


Broken file endings!? This is not reviewable!


переводится как листы, а у тебя тут 1 лист
заменить на list
если лист значит список, а если список значит `ul` а `list__item` тогда `li`  **l**ist__**i**tem  = li
and learn english stupid idiot (c) vice president


changes made


You could already do this with `go test -run TestIntegrationScripts/path/to/test` in fact because its regex you can run also run all tests in one folder.


там вроде маргин в стилях тогда `list__img`


I don't think this is something to be fixed.  The `mesa` attribute was introduced just as a hack in the time where glu was split (upstream) from the rest of mesa – to fix packages that assumed that both are on the same prefix.  The recommended way is to use either `mesa_glu` or `mesa_noglu` directly (note that `_glu` propagates `_noglu` so you don't need both).

I now added a comment at the attribute to make it clear 2065eea42 (that should've been done long time ago).  In the long term I'd prefer neutral naming, perhaps called `opengl` or `libgl`;  I've been thinking of that for a long time, but haven't done it yet.


класс `welcome__header` позиционные стили
класс `header` стили хеадера, тогда дальше элементы `header__logo` и т.д вместо `welcome-header__logo`


add


@eldy Why removing this property. Still used in contructor. Only used in constructor, maybe move to local var in constuctor.


> validation tests can not timeout or desync because they don't run demos or multiplayer games (cmiiaw).

they can and they did because two instances of spring are running in parallel.


[Your benchmark job](https://github.com/JuliaLang/julia/commit/3b0b4ae09461285a04c3aa8bbcae52df003921d3#commitcomment-21777769) has completed - possible performance regressions were detected. A full report can be found [here](https://github.com/JuliaCI/BaseBenchmarkReports/blob/03e3594c21ed2732fe04d3c2eb5c127ef7f327ba/3b0b4ae_vs_eee75d1/report.md). cc @jrevels


Cheers!


5 заголовок?
максимум 3 в редких случаях больше, тут это какой-нибудь `list__label`
или `list__tag`


Ironically you forgot a let**t**er too 😄

Happy easter Sunday :)


не работает вместо `none` использую `0`


There were the following issues with your Pull Request

  * A "License" and a "Signed-off-by" trailers are required. See [the guidelines about this](https://github.com/ipfs/community/blob/master/contribution-guidelines.md#a-license-and-a-signed-off-by-trailers-are-required)

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
`git commit --amend` can often help you quickly improve the commit message.
[Guidelines](https://github.com/ipfs/community/blob/master/contribution-guidelines.md#commit-messages) and [a script](https://github.com/ipfs/community/blob/master/dev/hooks/setup_commit_msg_hook.sh) are available to help in the long run.
Your feedback on GitCop is welcome on [this issue](https://github.com/ipfs/infrastructure/issues/23).

---
This message was auto-generated by https://gitcop.com


Hi.
Forgot to return cpp body)


oh sorry, I missed that


I reckon just leave it how it was before. So have the three `StateUp` (site is accessible), `StateDown` (site is down), and `StateUnknown` (there was a problem and we aren't sure whether the site is up or down - i.e. we aren't connected to the internet) and then when you try to get a string representation just panic as the default case. We *know* that'll never happen, so there's no need to worry about someone trying to get the string representation of an invalid state.

For such an insignificant edge case, I doubt making things more complicated by adding extra states (and tests) is worth it.

That's my thought anyway.


This doesn't work with non-latin. Wuut.


тут лучше использовать класс как модификатор `socials__item_twitter`
и эффект при наведении ужасный
сделай сначала у всех `socials__item` бэкраундр серый как сейчас
а потом при наведении меняй на цвета твиттера, фейсбука и т.д  `.socials__item_twitter:hover { background-color: twitter-color}`


new information should be added in the near feature.


то есть мне убрать input ? дискриминант перенёс в функцию, а вот понять, что вы имеете в ввиду под "Расчетные функции не должны печатать" не могу. Как они не будут печатать, если это необходимо? (я про x1,x2)


ужас


пиздец


The issue is that whenever i try /gamemode c. It says "No perm" which isn't originally from PocketMine itself. The config is fine and still yet to get pass the issue.


и эти все конфигурации надо охватить в нашем задании?


display: flex


No return statement on this line. Build is failing


без него неправильные размеры у tabs посмотри в браузере с display:flex и без него


cursor: pointer;


:first-child { margin-left: 0 }


Hi Neelam, it looks like this function is still a work in progress?


ну а модификаторы зачем в БЭМ
` class="btn btn_green" `
а у первой кнопки тогда `btn btn_orange`
забудь про `>` вообще


Beautiful.


Alternative naming is actually already supported in the passport.use method.
`Authenticator.prototype.use` = function(name, /**/ strategy)`


Thanks! If just added a step for this to my release playbooks at https://github.com/tarsius/elisp-maint.


использовать модификатор, но что бы ты понимал
вложенные селекторы применять не очень хорошо, но если нужно то тут хватило бы просто
`.porftolio__btn .btn`
потом что `>` ожидает найти класс который вложен прямо в родителя, т.е portfolio > btn будет ожидать что прямо в портфолио есть бтн, но там идет ещё мейн а уже потом потфолио__btn
а если писать просто .porftolio .btn  то это значит что где-то в портфолио есть бтн, не важно на каком уровне
если не ясно читай ещё раз что-нибудь про селекторы в интернете, а если и потом не ясно, то спрашивай


Also had this in my mind :smile:


может стоит обойтись без обертки над кнопкой сразу `<button class="btn portfolio__btn "`
если уже делаешь обертку, то это не кнопка а это обертка кнопки, `portfolio__btn-wrapper`


i could not figure out how to redirect the suddirectory to https so i think this will have to wait till later
i think we can release


Correction: the CPU is kryo


`response` плохое название это какой-то отзыв поэтому `comment`  лучше


revert this commit.


test


2016-04-16首页推荐界面完成，提交成功。


@ @tophf #488


TeamCity Trip Planner :: Tripper PR build [Build 2](http://ec2-35-164-15-23.us-west-2.compute.amazonaws.com/viewLog.html?buildId=57&buildTypeId=TripPlanner_TripperPrBuild&guest=1) is now running


reason


TeamCity Trip Planner :: Tripper PR build [Build 2](http://ec2-35-164-15-23.us-west-2.compute.amazonaws.com/viewLog.html?buildId=57&buildTypeId=TripPlanner_TripperPrBuild&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:17


啊


@matanby @slmosl
I did what matan said and now the download is ok.
Thanks Matan.


hello world


Yes we should. but  it may be difficult to update _Ultimaya Tzolkin_ to select correctly.


What on earth is that wall? how does it look so hammer-y?


Can't wait to see it when its finished....


界面截图，同意提交


Change to `True` to make all bombs sticky 😛


Hello,
I do not know why you removed Dense Forest Biome, but I hope to re-add it, this is a very beautiful biome.
pls! :-)


Hi sister, I suppose that you want to have something like this?

```python
import math

figure_name = str(input(‘figure name ‘f))

if figure_name == ‘triangle’:
	a = float(input (‘1 side: ‘))
	b = float(input (‘2 side: ‘))
	c = float(input (‘3 side: ‘))
	if a  +  b  >  c or b + c  > a or c + a > b:
		p  =  (a + b + c)  /  2
		print(p * (p - a) * (p - b) * (p -c) ** 0.5)
	else:
		print(‘Wrong parametrs. A sum of 2 sides is always bigger than a one`s length’)
elif figure_name == ‘rectangle’:
	a = float(input(‘1 side: ‘))
	b = float(input(‘2 side: ‘))
	print(a * b)
else:
	r = float(input(‘radius: ‘)
	print((r ** 2) * math.pi)
```

Sorry for incorrect formatting.


Uff thats not worth, I don´t want a ban or play in window mode anyway I haven't seen C++ yet I tried C in the university but it was so long ago and it's different I guess.

Well It was very nice work with you and you know a lot from this you are very intelligent. Thanks for helping me and for all.


What is `!['text', 'search', 'tel', 'url', 'email', 'password', 'date', 'month', 'week', 'time', 'datetime-local', 'number']` supposed to do? :-)


TeamCity DevOpsFinal :: Build [Build 18](http://localhost:9494/viewLog.html?buildId=36&buildTypeId=DevOpsFinal_Build) is now running


TeamCity DevOpsFinal :: Build [Build 18](http://localhost:9494/viewLog.html?buildId=36&buildTypeId=DevOpsFinal_Build) outcome was **SUCCESS**
Summary: Tests passed: 25 Build time: 00:00:25


@iEnderMan06 - It is a Wall Feature maded by TeamSpen210.


TeamCity DevOpsFinal :: Build [Build 19](http://localhost:9494/viewLog.html?buildId=37&buildTypeId=DevOpsFinal_Build) is now running


Катя!!!!


TeamCity DevOpsFinal :: Build [Build 19](http://localhost:9494/viewLog.html?buildId=37&buildTypeId=DevOpsFinal_Build) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 24 Build time: 00:00:19
### Failed tests
```
com.niall.FormulasTest.testAreaTriangle: junit.framework.AssertionFailedError: expected:<16.0> but was:<6.0>
	at junit.framework.Assert.fail(Assert.java:47)
	at junit.framework.Assert.failNotEquals(Assert.java:282)
	at junit.framework.Assert.assertEquals(Assert.java:101)
	at junit.framework.Assert.assertEquals(Assert.java:108)
	at com.niall.FormulasTest.testAreaTriangle(FormulasTest.java:24)
------- Stdout: -------
AreaTriangle

```


目前这个脚本存在的问题是，运行速度慢，检测椭圆过多等问题


looks fine


TeamCity DevOpsFinal :: Build [Build 20](http://localhost:9494/viewLog.html?buildId=38&buildTypeId=DevOpsFinal_Build) is now running


TeamCity DevOpsFinal :: Build [Build 20](http://localhost:9494/viewLog.html?buildId=38&buildTypeId=DevOpsFinal_Build) outcome was **SUCCESS**
Summary: Tests passed: 25 Build time: 00:00:18


Je ne vois pas bien la différence entre votre lien et mon code, ma classe SithAuthMiddleware représente la classe SimpleMiddleware de la doc et la fonction process_view est également décrite un peu plus bas dans la doc.


Try this:
new SourceHasCounterCondition(CounterType.BRICK, 3, Integer.MAX_VALUE)));


Dev BEE?


Syntax error: missing a comma (`,`) here.


Hm. Ist ja echt irre. Hätte ich nicht mit gerechnet, dass das mal so viel mehr war.
Ich vermute mal, dass danach die Zeit kam in der alle verstärkt sagen "Freifunk geht nicht" und es aus der Liste bekannter WLANs geworfen haben. Die Wachstumskurve vorher war ja auch echt geil.
Ich müsste den Blogpost umformulieren damit die Grafik da korrekt rein passt. Aktuell würde ich lieber noch mal einen weiteren Blogpost machen.


Может быть $_SESSION['password'], $_SESSION['login'];$_SESSION['id'] нужно хранить в базе данных, чтобы они не забывались?


broke compile (on Windows at least) - function is only known to splines lib and q3map2 code, needs to be moved in


Ouuups une erreur rigolote


Je confirme, c'est rigolo


2>C:\GtkRadiant\gtk-2.24.10\include\glib-2.0\glib/gi18n.h(25): fatal error C1083: Cannot open include file: 'libintl.h': No such file or directory


Can be lte -_-


who the f.. r u ?


@quannten24  That could work, right? http://stackoverflow.com/a/34409375/7569889

The other way would be to just use https everywhere. It give an advantage int the google search are I mean how many people are looking at the certificate to check where it is from...


从来没处理过pull request，所以让我学一学git嘛


Source of #5373 this should not have track tower base.


gg @DivyanshDC 👍


@Newlifer, that's okay, friend, don't worry. Everybody can make a mistake.

We will fix that.


thats been fixed btw


Первая фотография большая, стоит ли ей дать отдельный class, остальным фотографиям один общий class, чтобы было легче размечать в CSS в дальнейшем?


Now it sounds lame


Wo steckst du meld dich mal ;)


отправляю пока без правильных кавычек, в следующем пули исправлю


стоит ли использовать другие теги либо b либо span?


![](https://github.trello.services/images/mini-trello-icon.png) [Усовершенствовать форму создания проектов](https://trello.com/c/1EHMBQtZ/16--)


@1978lo 大神求下载

方法


Я исgользовала section либо лучше брать div?


Имеет ли смысл, поместить изображение в <а> чтобы логотип вел на главную?


Что лучше input или button?


@UVLabs thank you this suggestion. I think we can add it on plugin documentation. What do you think?


k


@geelen I don't think this is a safe modification. It's a bit far-fetched, but what about `div&` or `.other-class&`. While it's the wrong way around, I think it did work before.


这是什么


Cause issue https://github.com/luvit/luvit/issues/967, plz revert.


how to set aimspeed ?


Indenting the text by four spaces **and** wrapping it with backticks is not what I think you want :wink:


⚠ ⚠ ⚠

Não é necessário implementar esse método para resolver os exercícios. Lembre-se do exemplo do salário, devemos sempre proteger as informações dos objetos.


the problem is that browsers warn you that the page is insecure since it is just a self signed certificatAm 16.04.2017 14:35 schrieb Christoph Fricke <notifications@github.com>:@quannten24  That could work, right? http://stackoverflow.com/a/34409375/7569889
The other way would be to just use https everywhere. It give an advantage int the google search are I mean how many people are looking at the certificate to check where it is from...

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.


Рекурсивная перезапись файла в файл в обратном порядке


Начал писать код под тест по просьбе Саши, но надо больше входных данных. Коммичу первые десять строк, которые успел написать.


hi, i am looking for some info on hubsan x4 107c+ model. small silver type coil found on the quad...need to know where it needs to placed. Pcb board is having EA 4000017-01 ; V1.1

Anyone can please helpout !

Thanks!


Don't forget to add the sqlite-net-pcl NuGet package to all projects!


здесь давай уберем href="#" из ссылки, так как мы на главной странице сейчас, то переход не нужен


Database initialization and command execution


**2596. Satır-**
Yıllar sonra, yerel yıldız imparatorluğunda en çok aranan suçlulardan biri oldu.

**2615. Satır-**
NAME, küçük yaşta satranç oynamaya ve disk vurmaya teşvik eden mütevazi fakat ayrıcalıklı bir ailede büyüdü.

**2617. Satır-**
Sıkıcı bir öğrenci olarak, gezegeninin resmi değerleri ile hükümetinin politikaları arasındaki çelişkiler konusunda öğretmenlerine meydan okumayı keyifli buldu.


tem como simplificar ainda mais este método.. note que `saint2.perderVida(10)` é chamado duas vezes neste método... como podemos resolver isto?


thanks


legal os testes 👍


Could we preserve the commit history or at least the authors of every file? I would like to provide any help if necessary :)


Then we could try the SO above to secure the admin folder...


On the settings_main.xml the PreferenceScreen tag is asking me for a height and a width, anyone else?


вот в этом списке проверь, не слетело ли выравнивание? В гитхабе как-будто съехали ссылки


This shows up when the story viewer is launched
````
Checking lua scripts... ok
../src/gui/dialogs/story_viewer.cpp:445:59: runtime error: value -25.5 is outside the range of representable values of type 'const unsigned short'
    #0 0x41e581b in gui2::dialogs::story_viewer::draw_callback(gui2::window&) /home/matthias/vcs/github/wesnoth/build/../src/gui/dialogs/story_viewer.cpp:445:59
    #1 0x41f489a in void std::__invoke_impl<void, void (gui2::dialogs::story_viewer::* const&)(gui2::window&), gui2::dialogs::story_viewer*&, gui2::window&>(std::__invoke_memfun_deref, void (gui2::dialogs::story_viewer::* const&)(gui2::window&), gui2::dialogs::story_viewer*&, gui2::window&) /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:227:14
    #2 0x41f46ed in std::result_of<void (gui2::dialogs::story_viewer::* const&(gui2::dialogs::story_viewer*&, gui2::window&))(gui2::window&)>::type std::__invoke<void (gui2::dialogs::story_viewer::* const&)(gui2::window&), gui2::dialogs::story_viewer*&, gui2::window&>(void (gui2::dialogs::story_viewer::* const&)(gui2::window&), gui2::dialogs::story_viewer*&, gui2::window&) /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:250:14
    #3 0x41f44bf in _ZNKSt12_Mem_fn_baseIMN4gui27dialogs12story_viewerEFvRNS0_6windowEELb1EEclIJRPS2_S4_EEEDTclsr3stdE8__invokedtdefpT6_M_pmfspclsr3stdE7forwardIT_Efp_EEEDpOSB_ /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:604:11
    #4 0x41f4315 in void std::_Bind<std::_Mem_fn<void (gui2::dialogs::story_viewer::*)(gui2::window&)> (gui2::dialogs::story_viewer*, std::reference_wrapper<gui2::window>)>::__call<void, gui2::event::dispatcher&, gui2::event::ui_event&&, bool&, bool&, 0ul, 1ul>(std::tuple<gui2::event::dispatcher&, gui2::event::ui_event&&, bool&, bool&>&&, std::_Index_tuple<0ul, 1ul>) /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:933:11
    #5 0x41f40e4 in void std::_Bind<std::_Mem_fn<void (gui2::dialogs::story_viewer::*)(gui2::window&)> (gui2::dialogs::story_viewer*, std::reference_wrapper<gui2::window>)>::operator()<gui2::event::dispatcher&, gui2::event::ui_event, bool&, bool&, void>(gui2::event::dispatcher&, gui2::event::ui_event&&, bool&, bool&) /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:991:17
    #6 0x41f3792 in std::_Function_handler<void (gui2::event::dispatcher&, gui2::event::ui_event, bool&, bool&), std::_Bind<std::_Mem_fn<void (gui2::dialogs::story_viewer::*)(gui2::window&)> (gui2::dialogs::story_viewer*, std::reference_wrapper<gui2::window>)> >::_M_invoke(std::_Any_data const&, gui2::event::dispatcher&, gui2::event::ui_event&&, bool&, bool&) /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:1731:2
    #7 0x33469ba in std::function<void (gui2::event::dispatcher&, gui2::event::ui_event, bool&, bool&)>::operator()(gui2::event::dispatcher&, gui2::event::ui_event, bool&, bool&) const /usr/lib/gcc/x86_64-redhat-linux/6.3.1/../../../../include/c++/6.3.1/functional:2127:14
    #8 0x3346227 in gui2::event::trigger::operator()(std::function<void (gui2::event::dispatcher&, gui2::event::ui_event, bool&, bool&)>, gui2::event::dispatcher&, gui2::event::ui_event, bool&, bool&) const /home/matthias/vcs/github/wesnoth/build/../src/gui/core/event/dispatcher.cpp:144:3
    #9 0x3343698 in bool gui2::event::implementation::fire_event<std::function<void (gui2::event::dispatcher&, gui2::event::ui_event, bool&, bool&)>, gui2::event::trigger>(gui2::event::ui_event, std::vector<std::pair<gui2::widget*, gui2::event::ui_event>, std::allocator<std::pair<gui2::widget*, gui2::event::ui_event> > >&, gui2::widget*, gui2::widget*, gui2::event::trigger) /home/matthias/vcs/github/wesnoth/build/../src/gui/core/event/dispatcher_private.hpp:450:4
    #10 0x331fcb0 in bool gui2::event::fire_event<std::function<void (gui2::event::dispatcher&, gui2::event::ui_event, bool&, bool&)>, gui2::event::trigger>(gui2::event::ui_event, gui2::widget*, gui2::widget*, gui2::event::trigger) /home/matthias/vcs/github/wesnoth/build/../src/gui/core/event/dispatcher_private.hpp:529:9
    #11 0x331cd76 in gui2::event::dispatcher::fire(gui2::event::ui_event, gui2::widget&) /home/matthias/vcs/github/wesnoth/build/../src/gui/core/event/dispatcher.cpp:177:11
    #12 0x211dc4a in gui2::event::sdl_event_handler::draw(bool) /home/matthias/vcs/github/wesnoth/build/../src/gui/core/event/handler.cpp:542:15
    #13 0x211b3bd in gui2::event::sdl_event_handler::handle_event(SDL_Event const&) /home/matthias/vcs/github/wesnoth/build/../src/gui/core/event/handler.cpp
    #14 0x1db39ce in events::pump() /home/matthias/vcs/github/wesnoth/build/../src/events.cpp:619:14
    #15 0x24658b4 in gui2::window::show(bool, unsigned int) /home/matthias/vcs/github/wesnoth/build/../src/gui/widgets/window.cpp:637:4
    #16 0x2161499 in gui2::dialogs::modal_dialog::show(CVideo&, unsigned int) /home/matthias/vcs/github/wesnoth/build/../src/gui/dialogs/modal_dialog.cpp:70:20
    #17 0x3c204b9 in gui2::dialogs::story_viewer::display(storyscreen::controller&, CVideo&) /home/matthias/vcs/github/wesnoth/build/../src/gui/dialogs/story_viewer.hpp:42:28
    #18 0x3c20075 in show_story(CVideo&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, boost::iterator_range<config::const_child_iterator> const&) /home/matthias/vcs/github/wesnoth/build/../src/storyscreen/interface.cpp:53:2
    #19 0x3b9c586 in playsingle_controller::play_scenario(config const&) /home/matthias/vcs/github/wesnoth/build/../src/playsingle_controller.cpp:238:3
    #20 0x32b2e10 in campaign_controller::playsingle_scenario(end_level_data&) /home/matthias/vcs/github/wesnoth/build/../src/game_initialization/playcampaign.cpp:194:36
    #21 0x32b44ef in campaign_controller::play_game() /home/matthias/vcs/github/wesnoth/build/../src/game_initialization/playcampaign.cpp:281:11
    #22 0x20d98d2 in game_launcher::launch_game(game_launcher::RELOAD_GAME_DATA) /home/matthias/vcs/github/wesnoth/build/../src/game_launcher.cpp:949:37
    #23 0x1978540 in do_gameloop(std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > const&) /home/matthias/vcs/github/wesnoth/build/../src/wesnoth.cpp:827:10
    #24 0x1975980 in main /home/matthias/vcs/github/wesnoth/build/../src/wesnoth.cpp:1053:19
    #25 0x7fd187c3a400 in __libc_start_main /usr/src/debug/glibc-2.24-33-ge9e69e4/csu/../csu/libc-start.c:289
    #26 0x189bab9 in _start (/home/matthias/vcs/github/wesnoth/build/wesnoth+0x189bab9)

SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../src/gui/dialogs/story_viewer.cpp:445:59 in

````
I think assigning -1 in
````
void story_viewer::halt_fade_draw()
{
	next_draw_ = 0;
	fade_step_ = -1;
	fading_in_ = not_fading;
}
````
might be the problem here.


i did try that and it just return error 500(server internal error) or it
just reloaded the page indefinitly

On 16/04/2017 14:35, Christoph Fricke wrote:
>
> @quannten24 <https://github.com/quannten24> That could work, right?
> http://stackoverflow.com/a/34409375/7569889
>
> The other way would be to just use https everywhere. It give an
> advantage int the google search are I mean how many people are looking
> at the certificate to check where it is from...
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/christoph-fricke/shpioneers.de/commit/a1e720784a656d43795bb8e25357f73bc602c529#commitcomment-21778305>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AYyb3a_Sif4eoTCksdmRku02EJwVz1izks5rwgsIgaJpZM4M-aOp>.
>


Заебись


![](https://github.trello.services/images/mini-trello-icon.png) [設定開發環境、專案管理](https://trello.com/c/k7fLqA6Q/1--)


пропустила я тут, давай во всех тегах img размеры напишем (width и height), это есть в доп. критериях