[tests/testthat/test-css-svg.R:4:1:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-css-svg.R#L4) *style:* **lines should not be more than 80 characters.**
```r
  ff <- file.path(system.file(package = "rbokeh"), "htmlwidgets/lib/bokehjs/bokeh.min.css")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-css-svg.R:14:3:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-css-svg.R#L14) *style:* **Commented code should be removed.**
```r
# base64enc::base64encode(charToRaw("<svg xmlns=\'http://www.w3.org/2000/svg\'><filter id=\'grayscale\'><feColorMatrix type=\'matrix\' values=\'0.3333 0.3333 0.3333 0 0 0.3333 0.3333 0.3333 0 0 0.3333 0.3333 0.3333 0 0 0 0 0 1 0\'/></filter></svg>"))
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:172:4:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L172) *style:* **Commented code should be removed.**
```r
  ##---------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:217:4:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L217) *style:* **Commented code should be removed.**
```r
  ##---------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:238:1:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L238) *style:* **lines should not be more than 80 characters.**
```r
    ly_bar(variety, yield, color = year, data = lattice::barley, hover = TRUE) %>%
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:272:4:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L272) *style:* **Commented code should be removed.**
```r
  ##---------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:284:1:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L284) *style:* **lines should not be more than 80 characters.**
```r
  d <- data.frame(x = rnorm(1000), y = sample(letters[1:5], 1000, replace = TRUE))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:290:4:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L290) *style:* **Commented code should be removed.**
```r
  ##---------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:338:1:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L338) *style:* **lines should not be more than 80 characters.**
```r
    tool_hover("if(cb_data.index['1d'].indices.length > 0) console.log('1')", "points1") %>%
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:339:1:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L339) *style:* **lines should not be more than 80 characters.**
```r
    tool_hover("if(cb_data.index['1d'].indices.length > 0) console.log('2')", "points2")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:408:4:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L408) *style:* **Commented code should be removed.**
```r
  ##---------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:436:1:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L436) *style:* **lines should not be more than 80 characters.**
```r
  p[[69]] <- grid_plot(figs, same_axes = c(TRUE, FALSE), xlim = c(5, 7), nrow = 2)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:461:4:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L461) *style:* **Commented code should be removed.**
```r
  ##---------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:488:4:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L488) *style:* **Commented code should be removed.**
```r
  ##---------------------------------------------------------
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:534:1:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L534) *style:* **lines should not be more than 80 characters.**
```r
  # wa_cancer <- droplevels(subset(latticeExtra::USCancerRates, state == "Washington"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:534:5:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L534) *style:* **Commented code should be removed.**
```r
  # wa_cancer <- droplevels(subset(latticeExtra::USCancerRates, state == "Washington"))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:535:5:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L535) *style:* **Commented code should be removed.**
```r
  # rownames(wa_cancer) <- NULL
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:536:1:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L536) *style:* **lines should not be more than 80 characters.**
```r
  # wa_cancer <- wa_cancer[, c("LCL95.male", "UCL95.male", "rate.male", "county")]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:536:5:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L536) *style:* **Commented code should be removed.**
```r
  # wa_cancer <- wa_cancer[, c("LCL95.male", "UCL95.male", "rate.male", "county")]
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:537:5:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L537) *style:* **Commented code should be removed.**
```r
  # wa_cancer <- wa_cancer[order(wa_cancer$rate.male, decreasing = TRUE),]
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:538:5:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L538) *style:* **Commented code should be removed.**
```r
  # wa_cancer <- wa_cancer[1:10, ]
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:540:1:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L540) *style:* **lines should not be more than 80 characters.**
```r
    LCL95.male = c(237, 233.1, 266, 219.8, 227.5, 239.7, 245.4, 237.5, 208, 216.2),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:541:1:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L541) *style:* **lines should not be more than 80 characters.**
```r
    UCL95.male = c(466, 471.6, 316.8, 347.2, 303, 283.4, 263.3, 268.1, 300.3, 290.5),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:542:1:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L542) *style:* **lines should not be more than 80 characters.**
```r
    rate.male = c(332, 329.8, 290.5, 276.4, 263, 260.8, 254.2, 252.4, 250.6, 250.3),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:543:1:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L543) *style:* **lines should not be more than 80 characters.**
```r
    county = c("Columbia", "Wahkiakum", "Grays Harbor", "Pend Oreille", "Franklin",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:631:1:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L631) *style:* **lines should not be more than 80 characters.**
```r
    ly_oval(Sepal.Length, Sepal.Width, data = iris, color = Species, alpha = 0.5)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:636:1:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L636) *style:* **lines should not be more than 80 characters.**
```r
  #   ly_patch(Sepal.Length, Sepal.Width, data = iris, color = Species, alpha = 0.5)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:636:7:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L636) *style:* **Commented code should be removed.**
```r
  #   ly_patch(Sepal.Length, Sepal.Width, data = iris, color = Species, alpha = 0.5)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:637:5:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L637) *style:* **Commented code should be removed.**
```r
  # print_model_json(p[[98]], file = fname)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:639:1:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L639) *style:* **lines should not be more than 80 characters.**
```r
  #   ly_patch(Sepal.Length, Sepal.Width, data = iris, color = "blue", alpha = 0.5)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:639:7:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L639) *style:* **Commented code should be removed.**
```r
  #   ly_patch(Sepal.Length, Sepal.Width, data = iris, color = "blue", alpha = 0.5)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:640:5:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L640) *style:* **Commented code should be removed.**
```r
  # print_model_json(p[[99]], file = fname)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:675:5:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L675) *style:* **Commented code should be removed.**
```r
  # tf <- tempfile(fileext = ".png")
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:678:7:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L678) *style:* **Commented code should be removed.**
```r
  #   widget2png(tf)
      ^~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:679:5:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L679) *style:* **Commented code should be removed.**
```r
  # system2("open", tf)
    ^~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:682:3:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L682) *style:* **Commented code should be removed.**
```r
# # sapply(p, length)
  ^~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:685:7:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L685) *style:* **Commented code should be removed.**
```r
#     res <- widget2png(p[[i]], file = tempfile(fileext = ".png"))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:687:9:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L687) *style:* **Commented code should be removed.**
```r
#       message("JS errors for plot ", i)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-figures.R:688:7:](https://github.com/hafen/rbokeh/blob/7ac09b4cb7f8605b6eb133f3796c69d2dcd2bdcf/tests/testthat/test-figures.R#L688) *style:* **Commented code should be removed.**
```r
#     # expect(length(res) == 0, message = paste("JS errors for plot", i))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


script file added


TeamCity libpalaso :: palaso-linux64-master Continuous [Build 4.0.78.05613775b77acd6669bd0a81b2af6197fd727ee5](http://build.palaso.org/viewLog.html?buildId=89695&buildTypeId=Libpalaso_PalasoLinux64masterContinuous) outcome was **FAILURE**
Summary: Tests failed: 147 (147 new), passed: 3362, ignored: 215 Build time: 00:05:17
### Failed tests
```
SIL.Core.Tests.dll: SIL.Tests.CommandLineProcessing.CommandLineRunnerTests.CommandWith10Line_CallbackOption_TimeoutAfter3s: <no details avaliable>

SIL.Core.Tests.dll: SIL.Tests.CommandLineProcessing.CommandLineRunnerTests.CommandWith10Line_NoCallbackOption_Get10LinesSynchronously: <no details avaliable>

SIL.Core.Tests.dll: SIL.Tests.CommandLineProcessing.CommandLineRunnerTests.CommandWith10Line_NoCallbackOption_TimeoutAfter3s: <no details avaliable>

SIL.Windows.Forms.Keyboarding.Tests.dll: SIL.Windows.Forms.Keyboarding.Tests.IbusDefaultEventHandlerTests.CancelPreedit_RangeSelection: <no details avaliable>

SIL.Windows.Forms.Keyboarding.Tests.dll: SIL.Windows.Forms.Keyboarding.Tests.IbusDefaultEventHandlerTests.CancelPreedit_IP: <no details avaliable>

SIL.Windows.Forms.Keyboarding.Tests.dll: SIL.Windows.Forms.Keyboarding.Tests.IbusDefaultEventHandlerTests.Commit_Ipa: <no details avaliable>

SIL.Windows.Forms.Keyboarding.Tests.dll: SIL.Windows.Forms.Keyboarding.Tests.IbusDefaultEventHandlerTests.Commit_IpaTwoCommits_NoSurroundingText: <no details avaliable>

SIL.Windows.Forms.Keyboarding.Tests.dll: SIL.Windows.Forms.Keyboarding.Tests.IbusDefaultEventHandlerTests.Commit_IpaTwoCommits_SurroundingText: <no details avaliable>

SIL.Windows.Forms.Keyboarding.Tests.dll: SIL.Windows.Forms.Keyboarding.Tests.IbusDefaultEventHandlerTests.CommitOrReset_Resets: <no details avaliable>

SIL.Windows.Forms.Keyboarding.Tests.dll: SIL.Windows.Forms.Keyboarding.Tests.IbusDefaultEventHandlerTests.CommitOrReset_Commits: <no details avaliable>

SIL.Windows.Forms.Keyboarding.Tests.dll: SIL.Windows.Forms.Keyboarding.Tests.IbusDefaultEventHandlerTests.Commit_ReplaceAll: <no details avaliable>

##### there are 137 more failed tests, see build details
```


Ah I see.  Looks like Markus tweaked these lines - maybe the expected output of the workers had changed while my branch was diverged.  Or maybe I was just doing the wrong thing to begin with.  However we're still going to want to keep division here, not modulo, to scale the values properly.

I wonder if maybe we need `Math.floor(cv.getUint16(offset + j*pointSize + ...) / div);` there, since for example we could down-scale values like `65535/256 = 255.996`, which doesn't match what we'd extract there if the values were pre-scaled.


Congrats!


TeamCity libpalaso :: palaso-trusty64-lfmerge Continuous [Build 2.6.332.05613775b77acd6669bd0a81b2af6197fd727ee5](http://build.palaso.org/viewLog.html?buildId=89692&buildTypeId=PalasoTrusty64lfmergeContinuous) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 3610, ignored: 111 Build time: 00:05:50
### Failed tests
```
SIL.Windows.Forms.Tests.dll: SIL.Windows.Forms.Tests.ControlExtensionsTests.ControlExtensionsTests.SafeInvoke_DisposedAfterInvokingOnUiThread_InvokedActionDequeued(Throw): <no details avaliable>

```


Are you sure you want this to be a public document?
It may be advantageous to next year's cohort


Yeah I don't think I can make it a private repo without a paid account :/

On 3 May 2017 10:13 am, "Patrick Savill" <notifications@github.com> wrote:

> Are you sure you want this to be a public document?
> It may be advantageous to next year's cohort
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/chelsea0miller/ECEN425_Lego/commit/b1560781ffe1fa5ea1836f75a3d6e8a89676ec12#commitcomment-21991024>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ALYo8xj3AFtbs58dtryWNSDSNi2R07wGks5r16qYgaJpZM4NOwPw>
> .
>


maybe `check_na_matches()` ?


Who made the changes?  You?


I'm still very uncertain about this. I'm also uncomfortable that setting a word as marked sets known that dictionary form of all the definitions. I think most people would assume it works off the definition it thinks the word has, i.e. the one it'd be displaying furigana for.


Hopefully we never need the other matches that it finds. Do you have any insight into whether this might be a problem in the future? Also, good catch.


It looks like there should be newline. Please check your code style https://criu.org/How_to_submit_patches#Edit_the_source_code


*I'd __like__ to add some content*


Good catch! Also, strange issue. I think I'll redefine ['RU', 'IR', 'RH', 'D1'] to occur as a module level variable.


As a student you can get private repositories under the education pack
https://education.github.com/pack/offers


We've discussed that tcp drop option should not touch listening TCP sockets (very important) and should not touch sockets that were created but not connected/binded (minor case, can be not implemented).
So where is it? After updating the code update also all the help messages and patch descriptions to clearly state what this option does and what it doesn't do.


btw i think you can use `(**` and the doc comment will appear in the completion \o/


excessive non-const local var


Looks like it defaults to True (which is what we want) so we can stop worrying about this entirely. I think this might have changed since I last used Django REST Framework.


Hello!

I found how to change the announcement message, but is there a way to customize the color of the message? Currently it's in dark orange and is hard to read.

Thank you!


Oh nice thanks Paddy :) I'll sort that when I get to uni.

On 3 May 2017 10:22 am, "Patrick Savill" <notifications@github.com> wrote:

> As a student you can get private repositories under the education pack
> https://education.github.com/pack/offers
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/chelsea0miller/ECEN425_Lego/commit/b1560781ffe1fa5ea1836f75a3d6e8a89676ec12#commitcomment-21991116>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ALYo83U_6pzjpsyJvVYfvMgw5uNKZz09ks5r16ysgaJpZM4NOwPw>
> .
>


Hola juanchorossi, disculpa la molestia, te consulto, tendrás a mano, algún paso a paso, como para estudiarlo, y ver como me va, lo que estoy necesitando, es un calculador de precio de envió, en función,  si es a sucursal o domicilio, desde ya muchas gracias.
Mario


you don't check that coc_url isn't false


This is hardly a PATCH level change. It breaks all the scripts that depend on `turbolinks:load` firing **after** `DOMContentLoaded`, because in an `async` environment, the listener registration (on the app side) can now happen *after* `@pageLoaded` had already happened.

An example of a script that breaks is this universal on page load script that supports all versions of Turbolinks and no Turbolinks: https://github.com/thredded/thredded/blob/master/app/assets/javascripts/thredded/core/on_page_load.es6

The above will only break in development, because in development the script files are separate.


Thank you very much.


Please revert your changes now !

our disclaimer is verry clear about this:
DO NOT RENAME a resource. Retain the authenticity of it. Everything is designed the way it is for a reason. Do not go behind someone else and redo what someone took the time and effort to do to make everything work.


Looks cool, I like the rationale of matching the behaviour of the commands in C source files. If I were to accept this, I'd want it to include mappings for [[ and ]] that worked similarly, for consistency.


nayoomade khob script haye baghiye ro copy kardia irani :) cloud-hat ro to neveshti akhe ? ahmagha copy paster


The [Pumping Data | Compression](https://www.cryptopp.com/wiki/Pumping_Data#Encryption) example on the wiki encountered a need for the const member function in its `EndOfFile` function.


Eliminar Permanentemente


These dollar signs should not be used (there is no need to change existing functions and field names), but please don't add more with the dollar signs; see http://stackoverflow.com/questions/846585/can-someone-explain-the-dollar-sign-in-javascript#846613


@ralex0 ping


recv returns ENOTCONN even without preliminary call to connect.
So please clarify the need for this connect call.


And add `UnicastOnly on;`


Again why ZDTM_FAMILY is here. Do you test with ipv4 and ipv6? is testing with these 2 protocols metter for your case?


Great work! 👍


Nice that my redesign is used 👍🥇:P


I wondered about those… even found that specific stackoverflow question… but didn't know JMRI's "$" convention… so I just copied the style that was there… Happy to remove them if that's what jmri developers want.
I'll ask again: Is there a JMRI coding style guide?


I am not convinced by your commit message. The possible causes can be enumerated as `cbmc/src/utils/irep_specs/*.json` (using a wildcard, which is allowed in Makefile and is precisely how they are enumerated in `ireps_generator.py`) plus the `ireps_generator.py` itself. Am I wrong?

Also, I wouldn't say that spawning a python interpreter and an SMT solver is "cheap" :)


Mateus, no Python o padrão é com underscore mesmo.


Good catch! If you don't mind, could you add a comment (in the code itself, if possible, otherwise in GitHub) describing the game which encounters this situation?


You can see that in git blame https://github.com/macvim-dev/macvim/blame/master/src/MacVim/mvim
Apparently this `mvim.sh` was modified by @yacoob and me from the original authors' who were already mentioned in the header. I don't care that my name is in the header or not anyway.

@yacoob would you like your name is mentioned in the header?


where did you base these OOVPA on? (you don't want to introduce copies of older/verdund versions)


There have been some changes because saving multiple figures and multiple strategies wouldn't work


oups, yes, fixed. I have just made the push

On 2/5/17 21:13, Paolo Di Tommaso wrote:
> There are three mafft blocks
>
> https://github.com/cbcrg/tcoffee/blob/master/lib/data_headers/tclinkdb.txt#L90-L119
>
>
> p
>
> On Tue, May 2, 2017 at 9:10 PM, Cedric Notredame
> <notifications@github.com>
> wrote:
>
> > which definition?
> >
> >
> > On 2/5/17 20:40, Paolo Di Tommaso wrote:
> > >
> > > Something is wrong is this definition. Why there are three packages
> > > with the same key |mafft| ? it looks it is making crashing the build.
> > >
> > > —
> > > You are receiving this because you authored the thread.
> > > Reply to this email directly, view it on GitHub
> > >
> <https://github.com/cbcrg/tcoffee/commit/236a7afa834c401ffeaafe68e38ce4
> > dfa9245dfd#commitcomment-21987757>,
> > > or mute the thread
> > > <https://github.com/notifications/unsubscribe-auth/
> > AFi9qTqSitHVsGY8wTKhMDG5OB50e1aLks5r13iYgaJpZM4NOhnf>.
> > >
> >
> > --
> > ##########################################
> > Dr Cedric Notredame
> > Group Leader
> > Notredame's lab - Comparative Bioinformatics Group
> > Bioinformatics and Genomics Programme
> > Room 440.03
> >
> > Centre de Regulació Genòmica (CRG)
> > Dr. Aiguader, 88
> > 08003 Barcelona
> > Spain
> >
> > Ph# + 34 93 316 02 71 <+34%20933%2016%2002%2071>
> > Fax# + 34 93 316 00 99 <+34%20933%2016%2000%2099>
> > Mobile# + 34 66 250 47 82
> >
> > email cedric.notredame@crg.eu
> > url www.tcoffee.org
> > blog cedricnotredame.blogspot.com
> > ORC-ID: 0000-0003-1461-0988
> > ###########################################
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> >
> <https://github.com/cbcrg/tcoffee/commit/236a7afa834c401ffeaafe68e38ce4dfa9245dfd#commitcomment-21988303>,
> > or mute the thread
> >
> <https://github.com/notifications/unsubscribe-auth/AAx3SE_xL6QqtI4izPb9nYGwJW9CO5Zlks5r13-ngaJpZM4NOhnf>
> > .
> >
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/cbcrg/tcoffee/commit/236a7afa834c401ffeaafe68e38ce4dfa9245dfd#commitcomment-21988357>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AFi9qR0uFxVBXDsZKS15VnwhCWb5uM1Fks5r14BagaJpZM4NOhnf>.
>

--
##########################################
Dr Cedric Notredame
Group Leader
Notredame's lab - Comparative Bioinformatics Group
Bioinformatics and Genomics Programme
Room 440.03

Centre de Regulació Genòmica (CRG)
Dr. Aiguader, 88
08003 Barcelona
Spain

Ph#     + 34 93 316 02 71
Fax#    + 34 93 316 00 99
Mobile# + 34 66 250 47 82

email   cedric.notredame@crg.eu
url     www.tcoffee.org
blog    cedricnotredame.blogspot.com
ORC-ID: 0000-0003-1461-0988
###########################################


Wow, nicely done! I wonder though: how did you establish that these two functions needed patching?


Please test that your feature doesn't drop sockets listening on 0.0.0.0 ip address.
As I know migration of such server-style services is a major use case for CRIU. I've written email to Pavel with question about this. If he confirms my thought than this comment is valid.


hola


It's an issue with Conflict Desert Storm IIRC.  The vertex buffer creation fails in D3DResource_Register, of all places.  Then it tries to lock and use it.  This function seems to be the source of many issues.


![](https://github.trello.services/images/mini-trello-icon.png) [Crear Endpoints](https://trello.com/c/merdEshB/8-crear-endpoints)


![](https://github.trello.services/images/mini-trello-icon.png) [Realizar procedimientos almacenados (CRUD)](https://trello.com/c/oMAb42z1/7-realizar-procedimientos-almacenados-crud)


+linea 3+++++


It would have been better is this commit was done in multiple separate self-contained steps, instead of commiting it in one go, because now all fixes in here are tightly could to each other, which makes it hard to cherry pick separate changes


It occurs to me that this line could probably just go away entirely, since elsewhere in this commit I delete the reference to it from `mvc-dispatcher-servlet.xml`!


Hi Michael,

This is the branch
https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1364_2

This branch is supposed to propagate system properties of forked jvm to the
XML report. Before it was the Maven process properties and the ones from
forked jvm was ignored however still transferred from forked jvm to
Properties object but left unused.

On Tue, May 2, 2017 at 6:13 PM, Michael Osipov <notifications@github.com>
wrote:

> Ping when you are ready with the new branch.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/maven-surefire/commit/1ca9a35b3fc06b32948105fec1c24e340e974896#commitcomment-21985391>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA_yR-45BLe8D56lG6Cl_xqabBeqtTScks5r11YOgaJpZM4NNMcY>
> .
>


watch indentation here


There have been primarily two developers on the JavaScript, I use the NetBeans defaults but with two character indents to match AngularJS styles. I think Steve Todd prefers tabs. There is some other contributed code with other styles.

I find (in any language that does not require them) using prefixes like $s or _s or type identifiers makes code harder to read.

Randall Wood
Alexandria Software
randall.h.wood@alexandriasoftware.com
http://alexandriasoftware.com

> On May 2, 2017, at 18:36, George Warner <notifications@github.com> wrote:
>
> I wondered about those… even found that specific stackoverflow question… but didn't know JMRI's "$" convention… so I just copied the style that was there… Happy to remove them if that's what jmri developers want.
> I'll ask again: Is there a JMRI coding style guide?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.
>


this looks good, but remove extra spacing at the end of the file.


Yay! Interpolation


<details>

<summary>Submitting the task to TaskCluster failed. Details</summary>

```js

You do not have sufficient scopes. This request requires you
to have one of the following sets of scopes:
[
  [
    "queue:create-task:aws-provisioner-v1/win2012r2-cu"
  ],
  [
    "queue:define-task:aws-provisioner-v1/win2012r2-cu",
    "queue:task-group-id:taskcluster-github/A071aXxyTpur_u4OR3btXw",
    "queue:schedule-task:taskcluster-github/A071aXxyTpur_u4OR3btXw/A071aXxyTpur_u4OR3btXw"
  ]
]

You only have the scopes:
[
  "assume:repo:github.com/mozilla/qbrt:pull-request",
  "queue:create-task:aws-provisioner-v1/github-worker",
  "queue:create-task:aws-provisioner-v1/win2012r2",
  "queue:route:index.garbage.*",
  "secrets:get:garbage/*",
  "secrets:set:garbage/*"
]

In other words you are missing scopes from one of the options:
 * Option 0:
    - "queue:create-task:aws-provisioner-v1/win2012r2-cu"
 * Option 1:
    - "queue:define-task:aws-provisioner-v1/win2012r2-cu", and
    - "queue:task-group-id:taskcluster-github/A071aXxyTpur_u4OR3btXw", and
    - "queue:schedule-task:taskcluster-github/A071aXxyTpur_u4OR3btXw/A071aXxyTpur_u4OR3btXw"
----
method:     createTask
errorCode:  InsufficientScopes
statusCode: 403
time:       2017-05-02T22:48:23.661Z
```

</details>


can you name a few test cases that hit these fallbacks?


what's the effect of the commenting-out of these code blocks?


> I'll ask again: Is there a JMRI coding style guide?

For JavaScript?  No.

A couple things that do exist are on the [developer pages](http://jmri.org/help/en/html/doc/Technical/index.shtml):

- For [code format](http://jmri.org/help/en/html/doc/Technical/RP.shtml) we point to the [Java Code Conventions](http://www.oracle.com/technetwork/java/codeconventions-150003.pdf) that's been pretty standard for a long time. There's some value in conventional Conventions...

- [Code organization](http://jmri.org/help/en/html/doc/Technical/Patterns.shtml), including [Swing code organization](http://jmri.org/help/en/html/doc/Technical/Swing.shtml)

Of course, all this could use a pass of updating and organization....


yeah wtf adam


Yeah, ultimately we're working towards unpatching the Register function entirely


1st Output


This is invalid. I understand now.


I have an alternative proposal presented here:
https://forum.odroid.com/viewtopic.php?f=146&t=26016&start=100#p188661


Shouldn't this land in `types/Reporters`?


This needs to be '<%= @user.email %>'... Remember that in erb, you need the '=' in order for it to render.


Does `validateReporters` mutate `options`? if not, this check will never be reached.


forecast.js:
1) APPID doesn't need to be declared twice
2) the fetchForecast function in that file doesn't do anything. Also you don't need it anyway because you fetch that data in App.js in 'getForecast'


54 additions, 30 deletions.
the 1st patch in the series is clear and short.
this one doesn't change code readability, doesn't delete code.
what's the point in it?


this is slightly different. There are two parts here:
1. Configuration of reporters
2. Implementation of reporters

the first one is a JSON data structure in the shape of `['reporterName, ['otherReporterName', {option: 1}]]`

the second one is reporter implementation methods like `onRunStart, onRunComplete, etc` and their arguments.

I want to clean it up in future diffs though


when executing gnss-sdr on Zedbard, Armadillo needs to be linked to liblapack.so...it's mentionned that liblapack is not mandatory for cross compilation ??


![](https://github.trello.services/images/mini-trello-icon.png) [Remove Frame from existing Animation](https://trello.com/c/qvI1KabU/11-remove-frame-from-existing-animation)


> the listener registration (on the app side) can now happen after @pageLoaded had already happened.

Can you restate this in a different way? I'm not understanding.

`turbolinks:load` can now fire at [step 1](https://www.w3.org/TR/html5/syntax.html#the-end) of the relevant part of the HTML spec, when it previously always fired at step 4. So the only thing this would break (which I acknowledged above) is that if you for some reason depended on a separate `defer`red script being evaluated *before* Turbolinks, that will now break.

I think I understand your application code there, but I don't understand what's breaking. Yes, it may very very slightly change the timing of when your pageload callbacks fire, but again, that should only matter if you have other `defer`ed scripts that you were counting on being executed.


Okay, one that I can remember off hand is Zapper.  I was able to get further along after applying this.


Yes but only if we can create the system for it. Because it will be weird if secularism were to be kep as the national religion if a theocratic government takes power as currently this is no in game way to change the "national" religion. With the current setup, there is no risk of secularism being wrongly attributed.

The cultures are not associated with a particular religion. The text for religion has a #


Oops, I actually forgot to uncomment these, sorry.


TeamCity libpalaso :: palaso-linux64-master Continuous [Build 4.0.79.6f66347250f5e4c8f6da23563304b2570f31b970](http://build.palaso.org/viewLog.html?buildId=89702&buildTypeId=Libpalaso_PalasoLinux64masterContinuous) outcome was **FAILURE**
Summary: Tests failed: 31 (2 new), passed: 3567, ignored: 111 Build time: 00:05:29
### Failed tests
```
SIL.Windows.Forms.WritingSystems.Tests.dll: SIL.Windows.Forms.WritingSystems.Tests.WritingSystemSetupPMTests.Add_DuplicateInList: <no details avaliable>

SIL.Windows.Forms.WritingSystems.Tests.dll: SIL.Windows.Forms.WritingSystems.Tests.WritingSystemSetupPMTests.SetCurrentIndexFromLanguageTag_NotFound_ReturnsTrueAndCurrentIsChanged: <no details avaliable>

SIL.Windows.Forms.Scripture.Tests.dll: SIL.Windows.Forms.Scripture.Tests.ScrPassageControlTest.FilteredListHasBooksInCanonicalOrder: <no details avaliable>

SIL.Windows.Forms.Scripture.Tests.dll: SIL.Windows.Forms.Scripture.Tests.ScrPassageControlTest.FilteredListPreventsDuplicateBooks: <no details avaliable>

SIL.Windows.Forms.Scripture.Tests.dll: SIL.Windows.Forms.Scripture.Tests.ScrPassageControlTest.ResolveReference_IncompleteInFilteredList: <no details avaliable>

SIL.Windows.Forms.Scripture.Tests.dll: SIL.Windows.Forms.Scripture.Tests.ScrPassageControlTest.ResolveReference_IncompleteMultilingScrBooks: <no details avaliable>

SIL.Windows.Forms.Scripture.Tests.dll: SIL.Windows.Forms.Scripture.Tests.ScrPassageControlTest.ResolveReference_IncompleteNotInProject: <no details avaliable>

SIL.Windows.Forms.Scripture.Tests.dll: SIL.Windows.Forms.Scripture.Tests.ScrPassageControlTest.ResolveReference_InvalidBook: <no details avaliable>

SIL.Windows.Forms.Scripture.Tests.dll: SIL.Windows.Forms.Scripture.Tests.ScrPassageControlTest.ResolveReferenceOnEnter: <no details avaliable>

SIL.Windows.Forms.Scripture.Tests.dll: SIL.Windows.Forms.Scripture.Tests.ScrPassageControlTest.ResolveReferenceOnLoseFocus: <no details avaliable>

SIL.Windows.Forms.Scripture.Tests.dll: SIL.Windows.Forms.Scripture.Tests.ScrPassageControlTest.ScrPassageDropDownBehaviorTests: <no details avaliable>

##### there are 21 more failed tests, see build details
```


Don't think that the German culture should be split unless there is a big enough difference between the German cultures to warrant a split.


I deleted bundle.js and ignored both of them. However I don't know how to delete node_modules.


spam bot


What happens if you just do correct.text


изминения


GlazingEnahncementsWinkelmann (lgu1234) - Win64-Windows-7-VisualStudio-14: OK (2495 of 2495 tests passed, 600 test warnings)

Messages:

 * 599 tests had: AUD diffs.
 * 1 test had: EIO diffs.
 * 1 test had: Table small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


@benfry what do you think about @juanmanuel76 comment? Isn't technically true that any access to PGraphics' functions and/or variables should be enclosed between beginDraw/endDraw?


ref #4204


This will improve the test case results. Earlier test case was failing due to logic error


I didn't mean associated in-game, just that's it's a convenient lookup for religions already. So I would stand by my changes above, but change no.3 to make it always possible for moralist and traditional parties, and instead of using the effects from this decision use a new set of effects setting the religion based on culture, with a few exceptions like German.


There is a typo here.
Is `NETHER_WARTS` not `NETHER_WART`


Fixed problem where last note was always a very low/bad sounding one


У меня не получилось отменить локальный коммит через Reset HEAD... Забыл изменить название коммита. Добавил скрипт для отрисовки всех потомков-продуктов, включая продукта-родителя(на случай если потомков не будет)


Branch not tested for running


String interpolation looks nicer
const.py
    LOG_TEXT = "User:%s Original Message: %s Autocorrection: %s"

then here
    LOG_TEXT % (userName, original, new)

Also like 55 for consistency:
"/user/%s" % self.userId


--TO DO NEXT--

- adição da dependência compile 'com.google.firebase:firebase-core:10.0.1' no build.gradle(app)

- declaração do objeto no topo da activity em MainActivity
private FirebaseAnalytics mFirebaseAnalytics;

- inicialização do objeto criado acima, no método oncreate:
mFirebaseAnalytics = FirebaseAnalytics.getInstance(this);

- registro de conteúdo quando ocorrer evento (colocar código  no método public void onClick(View view))

  // [START  event]
                Bundle bundle = new Bundle();
                bundle.putString(FirebaseAnalytics.Param.ITEM_ID, id);
                bundle.putString(FirebaseAnalytics.Param.ITEM_NAME, name);
                bundle.putString(FirebaseAnalytics.Param.CONTENT_TYPE, "image");
                mFirebaseAnalytics.logEvent(FirebaseAnalytics.Event.SELECT_CONTENT, bundle);
  // [END event]


Oh good call! I completely forgot about that.


Initial merge with Kyle's GCM forcing branch


Fixed #18 not #17


Correct is a list, so it would throw an error


```c++
if (opts.tcp_close && ii->ie->state != TCP_LISTEN)
```
So, there is a if on line 428 to skip listening sockets, it should do the thing. Am I wrong?
In order to skip "created but not connected" sockets, I think I should just skip TCP_CLOSE too, right?


@rustgip this should be the same as line 43 below; also, `courseNumber` doesn't make sense in that context, because it is a `Course` object not a `CourseNumber` object. But that doesn't matter


Hi etai!
I'm trying to run your code, I didn't change anything, however "p = model.predict(X_test)" gave me the same value which made the prediction appeared as a straight line. can you please help me with that?


@danielluque13 Hi!
can you please tell me how did you solve the problem with flat prediction?
Thank you


What formatter are you using? (Asking so I stop accidentally committing incorrectly formatted code)


Graph search here for cleanliness

```
path = ['data','alert','subject','sender_type']

for instance in data:
    post(instance)

def post(instance):
    head = instance
    for node in path:
        if node in head:
            head = head[node]
        else:
            return False

    if head != bot:
        # blah blah
        return True
   return False
```


Hi, this commit broke the SDL2 binding because it forgot to update `platformState` within impl_sdl2_common.go. In that file, `scroll` is still defined as `float32`, causing compilation errors.


Thanks for the clarification. There is a problem with using checking for religion via "religion =" which is required for such a system as it doesn't seem to work properly and that such a system would need manual keying in of all the cultures in the decisions which is far too time consuming.


Heads-up: This is causing v0.10.11 to [fail tests on node v0.10.x](https://travis-ci.org/rwaldron/johnny-five/jobs/228093706) because [`Symbol` support wasn't added until node 0.12](http://node.green/#ES2015-built-ins-Symbol).  I think you need to use the check `typeof Symbol !== 'undefined'` to safely check whether `Symbol` exists in the global scope.


I suggest to rename to `annotations` instead, because it's not just dynamic annotations.


As documented here: https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Material.html#NETHER_WARTS

I get the sneaky suspicion there's a lot of people sending PRs without actually trying to compile, run, and test their changes.


Yes, it doesn't add any functionality. But existing code is mixing 2 distinct tasks in 1 function:
1. read data from pb streams
2. restore socket (with some sequence of libsoccr api calls)

It smells. But I can drop this commit, if you think I should.


@clayscode I doubt that. It's probably a DOM object. You can override classes to response to len and iteration however you want.


Since you have used webpack in the past week you are now our official webpack expert


world*


That's me!


@clayscode Yep.

https://seleniumhq.github.io/selenium/docs/api/py/_modules/selenium/webdriver/support/event_firing_webdriver.html#EventFiringWebElement.find_element_by_xpath

returns a WebElement

and text is a property that should strip tags

https://seleniumhq.github.io/selenium/docs/api/py/_modules/selenium/webdriver/remote/webelement.html#WebElement.text


My guess is that on Win32, `R_xlen_t`, `ptrdiff_t` and `int` are all the same type.

I do see this in `stddef.h` for the Rtools MinGW headers:

```
#ifndef __PTRDIFF_TYPE__
#ifdef _WIN64
#define __PTRDIFF_TYPE__ long long int
#else
#define __PTRDIFF_TYPE__ long int
#endif
```

which I think confirms my theory.


I think I may make these liveries a Livery Pack, as there are soooo many!

Thanks for your work @omega13a

If/when I make the livery pack, I'll send you a collab invite, please push there instead.

Kind Regards,
Josh


You should take the latest Gist which uses the asynchronous call.


What I shall do in the meantime would be to change the requirements to select the decision to require monarchies and theocracies. This should help to allow secularism to continue to grow in republics.


Indeed, the javadoc could be improved to specify that it only affects jobs that support this. What I did at this point was just to expose a mechanism that we were already employing with `EntityJobStatus` in some of our jobs but which was not really related to `Entities` (see https://github.com/xwiki/xwiki-platform/commit/183324ea4a59242dcbde4b2e48f428ec61ba0926).

We could:
A) either say that this is a first step in the direction of cancellable jobs (until we come up with a more suited implementation, as you've mentioned), or
B) we could instead say that we don't want to commit to this and that it is doing more harm than good, at which point I would have to revert the change and end up either:
B1) duplicating the same code in the `RestoreJob` (a non-Entity related job) or
B2) not supporting cancellation at all in the `RestoreJob`.


Hold on for a bit - I'm working on an implementation that might solve the problem


Using the deployed contract to run tests is not ideal because your next test will depend on it.
It is better for you to create a new one in a `beforeEach()`.


You should `.sub(gas * tx.gasPrice)`.


I'm going to rename it, thanks for the suggestion.


what do I need to do to fix my folder names and symbolic link?

On Wed, May 3, 2017 at 5:09 AM, Sebastian Jennen <notifications@github.com>
wrote:

> thanks!
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/buddhi1980/mandelbulber2/commit/f01706422d465c1b283ae143402eb634236d0ae5#commitcomment-21986263>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AMLZHLvnWYM0cU5libRkUS30WoJwOS9aks5r12NDgaJpZM4NObBK>
> .
>


The following DOI is real, and contains less-than/greater-than signs: `10.1002/1521-3919(20021101)11:8<823::AID-MATS823>3.0.CO;2-R`

It works when double-quoted thus:  `doi("10.1002/1521-3919(20021101)11:8<823::AID-MATS823>3.0.CO;2-R")`

..but causes an error when quoted literally in `{}`s:

```
<?xml version="1.0" encoding="UTF-8" standalone="yes"?><service-error><status><statusCode>INVALID_INPUT</statusCode><statusText>com.elsevier.agrm.scopus.search.xqueryx.XQueryXException: javax.xml.bind.UnmarshalException
 - with linked exception:
[org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 117; The reference to entity "lt823::AID-MATS823" must end with the ';' delimiter.]</statusText></status></service-error>
```

I think there is more to this than meets the documentation.


This commit also:

- clean up userCatelog that it no longer save selected user id in the reducer. This is uneccessary b/c the current user id can always read from the url.
- clean up the test
- remove test for userCatelog.init()


> So the only thing this would break (which I acknowledged above) is that if you for some reason depended on a separate deferred script being evaluated before Turbolinks, that will now break.

Yes, you understand correctly. Note that this happens to all Rails apps that use async with their `javascript_include_tag`.

In Rails development mode, script files become separate `<script>` tags, and their evaluation order is not guaranteed by the browser.

Whatever initialization code they previously had on `turbolinks:load` will no longer run for those scripts that happened to load before Turbolinks.


@Kagamia I'm getting build errors. `The name 'brush' does not exist in the current context`. Since I am not a coder myself, I depend on you and Kenny because it is easier to understand for the both of you.


The following doc(s) have been deployed to the [laurenkell](https://laurenkell-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/guides/collaborative-development](https://laurenkell-static-docs.pantheonsite.io/docs/guides/collaborative-development)


I'm not sure about it. This macro is used in every socket test. Can be in theory that only ipv6 is supported, but not ipv4? Or some corner cases? Anyway I think it should be more consistent to leave it here.


@RoeiRaz this fix a problem of importing the projects to workspace:
![image](https://cloud.githubusercontent.com/assets/17455055/25643842/a9742ef0-2faa-11e7-8055-fe85ba2b27d6.png)
It does not occur with this version of gradle.


Awesome changes :-) Thanks!


Related to: backdrop/backdrop-issues#2663


Approved. I missed this. Looks good then.
Reading Pavel's emails I think that your idea to ignore connections in TCP_CLOSE state is right.
Please update all the descriptions, add test that checks listening socket.
Also I think there should be some description of "why ignoring TCP_CLOSE and TCP_LISTEN" and "why we use connect that 100% fails"
Commit message is a good place for this.


Teleport packet must be sent at old position (players at new position who cannot currently see the teleporting unit will see it with a CreateObject, rest will see the teleport movement)


@Sunaries  `brush` is declared at [Line 229](https://github.com/KENNYSOFT/WzComparerR2/blob/master/WzComparerR2/CharaSimControl/SetItemTooltipRender.cs#L229), check if it appears in your code. 😆


IIRC this ZDTM_FAMILY macro is specified in compiler command line (in Makefile). So you need to either use ZDTM_FAMILY and specify it in Makefile or remove it as dead code. If you don't specify both ipv6 and ipv4 in Makefile then you still have dead code.


umm not actually, just move the call before the updateposition


Missing semicolon.


I just checked a few distributions:

Arch: 3.3
Ubuntu 17.04: 3.2.4
Fedora 25: third party provided 3.1.5

I didn't bother to check Debian because that automatically loses points for having a stable release mired several years in the past.


As a heads up this is causing some relative URL issues now:

<img width="704" alt="screen shot 2017-05-02 at 7 45 51 pm" src="https://cloud.githubusercontent.com/assets/3890972/25643982/f6323af0-2f70-11e7-9587-4941cc207f22.png">


@mohdshariq1 any luck having it working? do you need some help?


Sure


Scratch that. With proper percent-encoding it works:

`&query=doi(%7B10.1002/1521-3919(20021101)11:8%3C823::AID-MATS823%3E3.0.CO;2-R%7D)`


Minor typo here


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/5122cd9c-b547-4938-866a-b393743689f9 "simple-toolchain-20170502233102612"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/42076661-5b59-4d38-ad7e-4b3e4da80857 "simple-toolchain-googleanalytics") deployed [simple-toolchain-googleanalytics](https://github.com/semonca/simple-toolchain-googleanalytics/releases/tag/deploy-ibm-yp-us-south-smondrag-cr.ibm.com-dev-20170502-235350 "deploy-ibm-yp-us-south-smondrag-cr.ibm.com-dev-20170502-235350") to [dev](https://console.ng.bluemix.net/apps/edce4235-1483-4b8c-a0e8-cd5c33446842 "ibm:yp:us-south:smondrag@cr.ibm.com:dev"), including this commit


@Kagamia Ah, I added your commit of
```//Brush brush = effect.Value.Enabled ? Brushes.White : GearGraphics.GrayBrush2;
var color = effect.Value.Enabled ? Color.White : GearGraphics.GrayColor2;```

^ That doesn't work. Only `Brush brush = effect.Value.Enabled ? Brushes.White : GearGraphics.GrayBrush2;`


The choice of numeric exit status is interesting -- not *wrong* by any means, just unusual in the context of Python. Is the goal being a workalike with the C function by the same name?


<details>

<summary>No TaskCluster jobs started for this pull request</summary>

```js

The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.
```

</details>


I'd probably write `sd_notify(False, {'READY': 1})` -- or amend the interface to accept kwargs so one could use `sd_notify(False, READY=1)`.


Random Forest Model


I think its /usr/bin/true on OSX.  Probably need to s|/bin/true|true to make it work on both.


I wonder if `unset_environment` might make more sense as a keyword argument with a default of False?


Normally, I'd agree, but in this case I was actually following [sd_notify](https://www.freedesktop.org/software/systemd/man/sd_notify.html)


Hmm. stderr is unbuffered by default, so this is rather specifically a stdout-centric issue.


Not sure I understand the discussion, but the rule is no messing with graphics—pixels or otherwise—outside a begin/endDraw block.


@rasky Sorry, forgot that bit. I usually use GLFW so didn't even tried to compile for SDL2, should be OK now with 6011ec6de7eac1f6aaac07ce96441ae58014d3aa.

I'm glad that:
a) someone uses Nuklear;
b) someone uses SDL2 backend.

stay vigilant!


Only ZDTM_IPV6 is conditionally defined in Makefile. Seems that ipv4 is considered to be supported by default (there is no ZDTM_IPV4 at all).

> If you don't specify both ipv6 and ipv4 in Makefile then you still have dead code.

Code above anyway will choose one of the options.


hybrid (EnergyArchmage) - i386-Windows-7-VisualStudio-14: OK (2494 of 2494 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


This should be rectified.


How about mentioning all of them on `about:styles`? I think some of them like notificationItem are not required to create an mockup, yet worth mentioning to let people know that they exist without reading the code.


I change sum before returning it. Would you recommend a better way to this with out using let?


Could this be merged into the have a state religion policy decision? Actually, I can't really tell what this is supposed to do. For countries that start with their majority religion correctly defined, this does nothing. The rest are generally secular and can't take the decision or are non-majority regimes with special exceptions (e.g. Iraq).


would you mind applying a variable here?


This point we are constructing a set of requests and url's. Best practice is having constant values for all the used common elements. This helps while changing the same character for some reason with less refactoring effort and will produce less or no issues while testing.


Used same return type for 2 services as forced by the initial architecture of the product. Noted.


ah, is it done (now) in `faq_format`? 6f3f607dbe0fc111c1086c472f85b4f5a559b3e7


@scchan it's fixed now


This item is not clear. Any way not changed with this CR. Noted and will consider in relevant module refactoring.


Thank you yihui!


Comments added and fancy GUI with pulldowns.  Code added to make pull down seat menu work with previous code.


Do any of these items being printed need to be sanitized before output?


Error log in committed codebase


    <meta charset="UTF-8">
	  <link rel="stylesheet" type="text/css" href="RFTN.css">
    <title> RFTN test site </title>

 Raiders for the Nine

 RFTN facebook

Discord

 Welcome to the clan: Raiders for the Nine. Here you can get information for the clan.

	   Follow @Bungie


fggh


My pleasure!


what is this ?


#2520943-WindowsCalc-Engine_Integration (vidanovic) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1197 of 1197 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-36.05%25-green.png)


oh i know


@findepi  `FieldId` is actually exactly what I need. Unfortunately if I directly query the `columnReferences` map in `Analysis` that still won't do the job because the underlying `Map` is an `IdentityMap`. Instead what I did was create a hacky method that makes a copy of all the key expressions, gets the one that is equal to the one I'm looking for, and then uses that one as the lookup key in the `Map`. Here's the code:
```
Map<Expression, FieldId> columnReferenceFields = analysis.getColumnReferenceFields();
List<Expression> columnReferences = ImmutableList.copyOf(analysis.getColumnReferences());
List<Expression> groupingOrdinals = expression.getGroupingColumns().stream()
                    .map(groupingColumn -> extractGroupingColumnOrdinal(groupingColumn, columnReferences, columnReferenceFields))
                    .map(columnOrdinal -> new LongLiteral(Integer.toString(columnOrdinal)))
                    .collect(toImmutableList());

private static int extractGroupingColumnOrdinal(Expression groupingExpression, List<Expression> columnReferences, Map<Expression, FieldId> columnReferenceFields)
    {
        Expression lookupExpression = columnReferences.get(columnReferences.indexOf(groupingExpression));
        return columnReferenceFields.get(lookupExpression).getFieldIndex();
    }
```
I'm going to add a TODO explaining that this should be removed when `columnReferences` is converted to a linked map. Any better ideas?


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/a1c1f084-c18b-4ecb-99f8-9a9b22da21b5 "FB Face Recognition"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/63e7d3d4-ea51-4079-91c8-7e11b1d3f83b "FB Face Recognition") deployed [FB-Face-Recognition](https://github.com/iris-bot/FB-Face-Recognition/releases/tag/deploy-ibm-yp-us-south-iris-bot-dev-20170502-031554 "deploy-ibm-yp-us-south-iris-bot-dev-20170502-031554") to [dev](https://console.ng.bluemix.net/apps/47bcbc3c-0115-4065-99e5-49b693b7caac "ibm:yp:us-south:iris-bot:dev"), including this commit


What do you think of having an array of locations that it moves between? Integration with the Unity editor/inspector could be like 2 children positions that are thrown into a List<GameObject> public field. Then you wouldn't have to special case switching directions or deal with special math.


Good work


`a C#`, not `aC #`!!!!!


@tfausak it's this guy: https://www.rocketleaguereplays.com/replays/5f9d44b6-400e-284f-d15a-95ac8d5c5b45/


My first commit


![](https://github.trello.services/images/mini-trello-icon.png) [US5 - Look further into new rooting methods](https://trello.com/c/CzcBAScz/2-us5-look-further-into-new-rooting-methods)


can you tell me whats wrong with this function? I can't move on, I get NaN.
pollutantmean <- function(directory, pollutant, id = 1:332) {
    specdata_files_fullnames <- list.files("specdata", full.names = TRUE)
    for (i in 1:332) {
        specdata_dataframe <- data.frame()
        specdata_dataframe <- rbind(specdata_dataframe, read.csv(specdata_files_fullnames[i]))
    }
    as.integer(id)
    specdata_subset <- subset(specdata_dataframe, subset= ID == id)
    if (pollutant == "sulfate") {
        mean(specdata_subset$sulfate, na.rm = TRUE)
    } else if (pollutant == "nitrate") {
        mean(specdata_subset$nitrate, na.rm = TRUE)
    }
}


it's my fault that I do not put enough annotations.


> Тухлый проект по учёбе

лол