@rpatterson Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.testing/5/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/testing/layers.py:0:1: C101 Coding magic comment not found
plone/app/testing/layers.py:5:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:7:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:8:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:9:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:10:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:11:1: I004 isort found an unexpected blank line in imports
plone/app/testing/layers.py:12:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:13:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:14:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:15:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:16:1: I004 isort found an unexpected blank line in imports
plone/app/testing/layers.py:17:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:18:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:19:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:21:1: E302 expected 2 blank lines, found 1
plone/app/testing/layers.py:35:52: E203 whitespace before ','
plone/app/testing/layers.py:36:52: E203 whitespace before ','
plone/app/testing/layers.py:37:52: E203 whitespace before ','
plone/app/testing/layers.py:39:52: E203 whitespace before ','
plone/app/testing/layers.py:40:52: E203 whitespace before ','
plone/app/testing/layers.py:41:52: E203 whitespace before ','
plone/app/testing/layers.py:43:52: E203 whitespace before ','
plone/app/testing/layers.py:44:52: E203 whitespace before ','
plone/app/testing/layers.py:46:52: E203 whitespace before ','
plone/app/testing/layers.py:47:52: E203 whitespace before ','
plone/app/testing/layers.py:48:52: E203 whitespace before ','
plone/app/testing/layers.py:50:52: E203 whitespace before ','
plone/app/testing/layers.py:51:52: E203 whitespace before ','
plone/app/testing/layers.py:52:52: E203 whitespace before ','
plone/app/testing/layers.py:54:52: E203 whitespace before ','
plone/app/testing/layers.py:55:52: E203 whitespace before ','
plone/app/testing/layers.py:56:52: E203 whitespace before ','
plone/app/testing/layers.py:58:52: E203 whitespace before ','
plone/app/testing/layers.py:59:52: E203 whitespace before ','
plone/app/testing/layers.py:61:52: E203 whitespace before ','
plone/app/testing/layers.py:62:52: E203 whitespace before ','
plone/app/testing/layers.py:63:52: E203 whitespace before ','
plone/app/testing/layers.py:64:52: E203 whitespace before ','
plone/app/testing/layers.py:66:52: E203 whitespace before ','
plone/app/testing/layers.py:68:52: E203 whitespace before ','
plone/app/testing/layers.py:70:52: E203 whitespace before ','
plone/app/testing/layers.py:71:52: E203 whitespace before ','
plone/app/testing/layers.py:73:52: E203 whitespace before ','
plone/app/testing/layers.py:74:52: E203 whitespace before ','
plone/app/testing/layers.py:76:52: E203 whitespace before ','
plone/app/testing/layers.py:77:52: E203 whitespace before ','
plone/app/testing/layers.py:79:52: E203 whitespace before ','
plone/app/testing/layers.py:80:52: E203 whitespace before ','
plone/app/testing/layers.py:81:52: E203 whitespace before ','
plone/app/testing/layers.py:83:52: E203 whitespace before ','
plone/app/testing/layers.py:84:52: E203 whitespace before ','
plone/app/testing/layers.py:98:80: E501 line too long (87 > 79 characters)
plone/app/testing/layers.py:131:80: E501 line too long (112 > 79 characters)
plone/app/testing/layers.py:136:80: E501 line too long (96 > 79 characters)
plone/app/testing/layers.py:155:21: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/layers.py:221:17: E128 continuation line under-indented for visual indent
plone/app/testing/layers.py:222:17: E128 continuation line under-indented for visual indent
plone/app/testing/layers.py:223:17: E128 continuation line under-indented for visual indent
plone/app/testing/layers.py:224:17: E128 continuation line under-indented for visual indent
plone/app/testing/layers.py:225:13: E124 closing bracket does not match visual indentation
plone/app/testing/layers.py:247:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/layers.py:249:1: E302 expected 2 blank lines, found 1
plone/app/testing/layers.py:312:1: E302 expected 2 blank lines, found 1
plone/app/testing/layers.py:316:1: E302 expected 2 blank lines, found 1
plone/app/testing/layers.py:326:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/layers.py:326:80: E501 line too long (96 > 79 characters)
plone/app/testing/layers.py:327:25: E221 multiple spaces before operator
plone/app/testing/layers.py:327:80: E501 line too long (94 > 79 characters)
plone/app/testing/layers.py:329:14: E221 multiple spaces before operator
plone/app/testing/layers.py:329:80: E501 line too long (110 > 79 characters)
plone/app/testing/layers.py:330:17: E221 multiple spaces before operator
plone/app/testing/layers.py:330:80: E501 line too long (115 > 79 characters)
plone/app/testing/interfaces.py:0:1: C101 Coding magic comment not found
plone/app/testing/interfaces.py:5:20: Q000 Remove bad quotes.
plone/app/testing/interfaces.py:11:28: E231 missing whitespace after ','
plone/app/testing/__init__.py:0:1: C101 Coding magic comment not found
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_ZSERVER' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_FIXTURE' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_FTP_SERVER' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PloneTestLifecycle' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_INTEGRATION_TESTING' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.FunctionalTesting' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.IntegrationTesting' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PloneFixture' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_FUNCTIONAL_TESTING' imported but unused
plone/app/testing/__init__.py:2:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:3:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:4:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:5:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:7:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:9:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:10:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:11:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:12:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:13:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:14:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:15:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:16:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.quickInstallProduct' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.tearDownMultiPluginRegistration' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.PloneWithPackageLayer' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.applyProfile' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.popGlobalRegistry' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.setRoles' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.ploneSite' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.logout' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.pushGlobalRegistry' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.PloneSandboxLayer' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.login' imported but unused
plone/app/testing/__init__.py:17:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:18:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:19:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:20:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:21:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:22:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:23:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:24:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:25:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:26:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:27:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:28:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:29:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:30:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:31:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:32:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:33:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:34:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:35:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:36:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.PLONE_SITE_ID' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.SITE_OWNER_PASSWORD' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_ID' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.DEFAULT_LANGUAGE' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.PLONE_SITE_TITLE' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_PASSWORD' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_ROLES' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.SITE_OWNER_NAME' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_NAME' imported but unused
plone/app/testing/__init__.py:37:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:38:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:39:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:40:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:41:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:42:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:43:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:44:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:45:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:46:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:47:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:48:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:49:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:50:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:51:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:52:1: F401 'plone.app.testing.cleanup.cleanUpMultiPlugins' imported but unused
plone/app/testing/__init__.py:52:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:53:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:54:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:55:1: I004 isort found an unexpected blank line in imports
plone/app/testing/cleanup.py:0:1: C101 Coding magic comment not found
plone/app/testing/cleanup.py:5:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/cleanup.py:14:5: F401 'Products.PluggableAuthService.zcml' imported but unused
plone/app/testing/cleanup.py:21:80: E501 line too long (83 > 79 characters)
plone/app/testing/cleanup.py:37:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/api.py:0:1: C101 Coding magic comment not found
plone/app/testing/api.py:1:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/api.py:2:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:4:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:8:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:9:1: I004 isort found an unexpected blank line in imports
plone/app/testing/api.py:10:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:11:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:12:1: I004 isort found an unexpected blank line in imports
plone/app/testing/api.py:13:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:14:1: I004 isort found an unexpected blank line in imports
plone/app/testing/api.py:15:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:16:1: I004 isort found an unexpected blank line in imports
plone/app/testing/api.py:17:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:18:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:19:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:20:1: I004 isort found an unexpected blank line in imports
plone/app/testing/api.py:21:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:22:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:23:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:23:30: E271 multiple spaces after keyword
plone/app/testing/api.py:24:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:25:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:26:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:27:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:28:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:29:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:30:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:31:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:32:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:33:1: I001 isort found an import in the wrong position
plone/app/testing/api.py:125:20: E127 continuation line over-indented for visual indent
plone/app/testing/api.py:188:16: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/api.py:281:12: P002 found "hasattr", consider replacing it
plone/app/testing/api.py:284:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/api.py:303:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/api.py:364:30: Q000 Remove bad quotes.
plone/app/testing/api.py:394:1: C901 'DocFileSuite' is too complex (12)
plone/app/testing/api.py:405:9: E129 visually indented line with same indent as next logical line
plone/app/testing/api.py:405:9: P002 found "hasattr", consider replacing it
plone/app/testing/selenium_layers.py:0:1: C101 Coding magic comment not found
plone/app/testing/selenium_layers.py:1:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/selenium_layers.py:3:1: I004 isort found an unexpected blank line in imports
plone/app/testing/selenium_layers.py:4:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:5:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:7:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:8:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:18:13: S001 found module formatter
plone/app/testing/selenium_layers.py:28:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/selenium_layers.py:31:10: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:34:10: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:60:20: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:61:28: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:63:22: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:66:31: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:80:80: E501 line too long (82 > 79 characters)
plone/app/testing/selenium_layers.py:81:80: E501 line too long (86 > 79 characters)
plone/app/testing/selenium_layers.py:82:80: E501 line too long (80 > 79 characters)
plone/app/testing/selenium_layers.py:83:80: E501 line too long (81 > 79 characters)
plone/app/testing/selenium_layers.py:87:30: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:88:42: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:100:17: S001 found module formatter
plone/app/testing/selenium_layers.py:100:27: E228 missing whitespace around modulo operator
plone/app/testing/selenium_layers.py:112:21: Q000 Remove bad quotes.
plone/app/testing/helpers.py:0:1: C101 Coding magic comment not found
plone/app/testing/helpers.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/helpers.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:7:1: I004 isort found an unexpected blank line in imports
plone/app/testing/helpers.py:8:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:9:1: I004 isort found an unexpected blank line in imports
plone/app/testing/helpers.py:10:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:11:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:12:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:13:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:14:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:15:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:112:21: S001 found module formatter
plone/app/testing/helpers.py:306:17: E128 continuation line under-indented for visual indent
plone/app/testing/helpers.py:311:23: Q000 Remove bad quotes.
plone/app/testing/helpers.py:311:23: S001 found module formatter
plone/app/testing/helpers.py:314:13: E128 continuation line under-indented for visual indent
plone/app/testing/helpers.py:394:16: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/helpers.py:422:5: E125 continuation line with same indent as next logical line
plone/app/testing/helpers.py:422:9: E128 continuation line under-indented for visual indent
plone/app/testing/helpers.py:444:30: Q000 Remove bad quotes.
plone/app/testing/helpers.py:446:30: Q000 Remove bad quotes.
plone/app/testing/helpers.py:447:17: E128 continuation line under-indented for visual indent
plone/app/testing/helpers.py:447:17: Q000 Remove bad quotes.
plone/app/testing/mail.py:0:1: C101 Coding magic comment not found
plone/app/testing/mail.py:1:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/mail.py:2:1: I004 isort found an unexpected blank line in imports
plone/app/testing/mail.py:3:1: I001 isort found an import in the wrong position
plone/app/testing/mail.py:4:1: I004 isort found an unexpected blank line in imports
plone/app/testing/mail.py:5:1: I001 isort found an import in the wrong position
plone/app/testing/tests/test_api.py:0:1: C101 Coding magic comment not found
plone/app/testing/tests/test_docfiles.py:0:1: C101 Coding magic comment not found
plone/app/testing/tests/test_docfiles.py:1:1: I001 isort found an import in the wrong position
plone/app/testing/tests/test_docfiles.py:2:1: I001 isort found an import in the wrong position
plone/app/testing/tests/test_docfiles.py:3:1: I004 isort found an unexpected blank line in imports
plone/app/testing/tests/test_docfiles.py:4:1: I001 isort found an import in the wrong position
plone/app/testing/tests/test_docfiles.py:8:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/tests/test_docfiles.py:8:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/tests/test_docfiles.py:24:1: W293 blank line contains whitespace
plone/app/testing/tests/__init__.py:0:1: C101 Coding magic comment not found
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


This is not needed. The module has been already renamed in OpenUpgrade base module.


@rpatterson Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.testing/6/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/testing/tests.py:0:1: C101 Coding magic comment not found
plone/app/testing/tests.py:2:1: I001 isort found an import in the wrong position
plone/app/testing/tests.py:3:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/tests.py:14:5: E265 block comment should start with '# '
plone/app/testing/tests.py:17:5: E265 block comment should start with '# '
plone/app/testing/tests.py:22:1: E122 continuation line missing indentation or outdented
plone/app/testing/bbb.py:0:1: C101 Coding magic comment not found
plone/app/testing/bbb.py:4:1: I001 isort found an import in the wrong position
plone/app/testing/bbb.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/bbb.py:7:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/bbb.py:49:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/bbb.py:63:80: E501 line too long (87 > 79 characters)
plone/app/testing/layers.py:0:1: C101 Coding magic comment not found
plone/app/testing/layers.py:5:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:6:1: I004 isort found an unexpected blank line in imports
plone/app/testing/layers.py:7:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:8:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:9:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:10:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:11:1: I004 isort found an unexpected blank line in imports
plone/app/testing/layers.py:12:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:13:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:14:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:15:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:16:1: I004 isort found an unexpected blank line in imports
plone/app/testing/layers.py:17:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:18:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:19:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:36:48: E203 whitespace before ','
plone/app/testing/layers.py:37:48: E203 whitespace before ','
plone/app/testing/layers.py:38:48: E203 whitespace before ','
plone/app/testing/layers.py:39:48: E203 whitespace before ','
plone/app/testing/layers.py:41:48: E203 whitespace before ','
plone/app/testing/layers.py:43:48: E203 whitespace before ','
plone/app/testing/layers.py:44:48: E203 whitespace before ','
plone/app/testing/layers.py:46:48: E203 whitespace before ','
plone/app/testing/layers.py:47:48: E203 whitespace before ','
plone/app/testing/layers.py:48:48: E203 whitespace before ','
plone/app/testing/layers.py:50:48: E203 whitespace before ','
plone/app/testing/layers.py:51:48: E203 whitespace before ','
plone/app/testing/layers.py:52:48: E203 whitespace before ','
plone/app/testing/layers.py:53:48: E203 whitespace before ','
plone/app/testing/layers.py:55:48: E203 whitespace before ','
plone/app/testing/layers.py:56:48: E203 whitespace before ','
plone/app/testing/layers.py:58:48: E203 whitespace before ','
plone/app/testing/layers.py:59:48: E203 whitespace before ','
plone/app/testing/layers.py:60:48: E203 whitespace before ','
plone/app/testing/layers.py:61:48: E203 whitespace before ','
plone/app/testing/layers.py:62:48: E203 whitespace before ','
plone/app/testing/layers.py:64:48: E203 whitespace before ','
plone/app/testing/layers.py:66:48: E203 whitespace before ','
plone/app/testing/layers.py:67:48: E203 whitespace before ','
plone/app/testing/layers.py:69:48: E203 whitespace before ','
plone/app/testing/layers.py:70:48: E203 whitespace before ','
plone/app/testing/layers.py:72:48: E203 whitespace before ','
plone/app/testing/layers.py:75:48: E203 whitespace before ','
plone/app/testing/layers.py:76:48: E203 whitespace before ','
plone/app/testing/layers.py:130:80: E501 line too long (96 > 79 characters)
plone/app/testing/layers.py:149:21: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/layers.py:249:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/layers.py:331:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/interfaces.py:0:1: C101 Coding magic comment not found
plone/app/testing/__init__.py:0:1: C101 Coding magic comment not found
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_ZSERVER' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_FIXTURE' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_FTP_SERVER' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PloneTestLifecycle' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_INTEGRATION_TESTING' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.FunctionalTesting' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.IntegrationTesting' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PloneFixture' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_FUNCTIONAL_TESTING' imported but unused
plone/app/testing/__init__.py:2:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:3:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:4:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:5:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:7:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:9:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:10:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:11:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:12:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:13:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:14:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:15:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:16:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.quickInstallProduct' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.tearDownMultiPluginRegistration' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.PloneWithPackageLayer' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.applyProfile' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.popGlobalRegistry' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.setRoles' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.ploneSite' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.logout' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.pushGlobalRegistry' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.PloneSandboxLayer' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.login' imported but unused
plone/app/testing/__init__.py:17:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:18:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:19:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:20:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:21:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:22:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:23:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:24:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:25:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:26:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:27:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:28:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:29:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:30:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:31:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:32:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:33:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:34:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:35:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:36:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.PLONE_SITE_ID' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.SITE_OWNER_PASSWORD' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_ID' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.DEFAULT_LANGUAGE' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.PLONE_SITE_TITLE' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_PASSWORD' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_ROLES' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.SITE_OWNER_NAME' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_NAME' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.ROBOT_TEST_LEVEL' imported but unused
plone/app/testing/__init__.py:37:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:38:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:39:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:40:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:41:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:42:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:43:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:44:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:45:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:46:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:47:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:48:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:49:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:50:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:51:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:52:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:53:1: F401 'plone.app.testing.cleanup.cleanUpMultiPlugins' imported but unused
plone/app/testing/__init__.py:53:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:54:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:55:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:56:1: I004 isort found an unexpected blank line in imports
plone/app/testing/cleanup.py:0:1: C101 Coding magic comment not found
plone/app/testing/cleanup.py:5:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/cleanup.py:14:5: F401 'Products.PluggableAuthService.zcml' imported but unused
plone/app/testing/cleanup.py:21:80: E501 line too long (83 > 79 characters)
plone/app/testing/cleanup.py:37:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/selenium_layers.py:0:1: C101 Coding magic comment not found
plone/app/testing/selenium_layers.py:1:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/selenium_layers.py:3:1: I004 isort found an unexpected blank line in imports
plone/app/testing/selenium_layers.py:4:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:5:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:7:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:8:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:18:13: S001 found module formatter
plone/app/testing/selenium_layers.py:28:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/selenium_layers.py:31:10: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:34:10: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:60:20: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:61:28: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:63:22: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:66:31: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:80:80: E501 line too long (82 > 79 characters)
plone/app/testing/selenium_layers.py:81:80: E501 line too long (86 > 79 characters)
plone/app/testing/selenium_layers.py:82:80: E501 line too long (80 > 79 characters)
plone/app/testing/selenium_layers.py:83:80: E501 line too long (81 > 79 characters)
plone/app/testing/selenium_layers.py:87:30: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:88:42: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:100:17: S001 found module formatter
plone/app/testing/selenium_layers.py:100:27: E228 missing whitespace around modulo operator
plone/app/testing/selenium_layers.py:112:21: Q000 Remove bad quotes.
plone/app/testing/helpers.py:0:1: C101 Coding magic comment not found
plone/app/testing/helpers.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/helpers.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:7:1: I004 isort found an unexpected blank line in imports
plone/app/testing/helpers.py:8:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:9:1: I004 isort found an unexpected blank line in imports
plone/app/testing/helpers.py:10:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:11:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:12:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:13:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:14:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:15:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:112:21: S001 found module formatter
plone/app/testing/helpers.py:310:80: E501 line too long (81 > 79 characters)
plone/app/testing/helpers.py:313:27: Q000 Remove bad quotes.
plone/app/testing/helpers.py:313:27: S001 found module formatter
plone/app/testing/helpers.py:316:17: E128 continuation line under-indented for visual indent
plone/app/testing/helpers.py:335:80: E501 line too long (80 > 79 characters)
plone/app/testing/helpers.py:352:9: B901 blind except: statement
plone/app/testing/helpers.py:402:16: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/helpers.py:431:5: E125 continuation line with same indent as next logical line
plone/app/testing/helpers.py:431:9: E128 continuation line under-indented for visual indent
plone/app/testing/helpers.py:453:30: Q000 Remove bad quotes.
plone/app/testing/helpers.py:456:17: Q000 Remove bad quotes.
plone/app/testing/helpers.py:457:17: Q000 Remove bad quotes.
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.testing/7/violations
```
plone/app/testing/layers.py:154:21: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/layers.py:251:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/layers.py:369:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/cleanup.py:39:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/selenium_layers.py:32:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/helpers.py:410:16: D001 found xmlconfig.file( replace it with self.loadZCML(
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@gforcada Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.testing/8/violations
```
plone/app/testing/layers.py:162:21: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/layers.py:259:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/layers.py:375:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/cleanup.py:39:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/selenium_layers.py:32:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/helpers.py:432:16: D001 found xmlconfig.file( replace it with self.loadZCML(
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


@tschorr Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.testing/9/violations
```
plone/app/testing/bbb.py:55:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/layers.py:161:21: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/layers.py:258:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/layers.py:374:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/cleanup.py:39:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/selenium_layers.py:32:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/helpers.py:432:16: D001 found xmlconfig.file( replace it with self.loadZCML(
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Given we break after 100, this assertion is no longer applicable


@mauritsvanrees Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.testing/10/violations
```
plone/__init__.py:0:1: C101 Coding magic comment not found
plone/app/__init__.py:0:1: C101 Coding magic comment not found
plone/app/testing/tests.py:0:1: C101 Coding magic comment not found
plone/app/testing/tests.py:2:1: I001 isort found an import in the wrong position
plone/app/testing/tests.py:3:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/tests.py:14:5: E265 block comment should start with '# '
plone/app/testing/tests.py:17:5: E265 block comment should start with '# '
plone/app/testing/tests.py:22:1: E122 continuation line missing indentation or outdented
plone/app/testing/bbb.py:0:1: C101 Coding magic comment not found
plone/app/testing/bbb.py:4:1: I001 isort found an import in the wrong position
plone/app/testing/bbb.py:6:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/bbb.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/bbb.py:7:1: I001 isort found an import in the wrong position
plone/app/testing/bbb.py:10:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/bbb.py:11:1: E302 expected 2 blank lines, found 1
plone/app/testing/bbb.py:49:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/bbb.py:63:80: E501 line too long (87 > 79 characters)
plone/app/testing/layers.py:0:1: C101 Coding magic comment not found
plone/app/testing/layers.py:5:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:6:1: I004 isort found an unexpected blank line in imports
plone/app/testing/layers.py:10:1: I004 isort found an unexpected blank line in imports
plone/app/testing/layers.py:11:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:12:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:13:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:14:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:15:1: I004 isort found an unexpected blank line in imports
plone/app/testing/layers.py:16:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:17:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:18:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:19:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:20:1: I004 isort found an unexpected blank line in imports
plone/app/testing/layers.py:21:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:22:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:23:1: I001 isort found an import in the wrong position
plone/app/testing/layers.py:25:1: E302 expected 2 blank lines, found 1
plone/app/testing/layers.py:39:52: E203 whitespace before ','
plone/app/testing/layers.py:40:52: E203 whitespace before ','
plone/app/testing/layers.py:41:52: E203 whitespace before ','
plone/app/testing/layers.py:43:52: E203 whitespace before ','
plone/app/testing/layers.py:44:52: E203 whitespace before ','
plone/app/testing/layers.py:45:52: E203 whitespace before ','
plone/app/testing/layers.py:47:52: E203 whitespace before ','
plone/app/testing/layers.py:48:52: E203 whitespace before ','
plone/app/testing/layers.py:50:52: E203 whitespace before ','
plone/app/testing/layers.py:51:52: E203 whitespace before ','
plone/app/testing/layers.py:52:52: E203 whitespace before ','
plone/app/testing/layers.py:54:52: E203 whitespace before ','
plone/app/testing/layers.py:55:52: E203 whitespace before ','
plone/app/testing/layers.py:56:52: E203 whitespace before ','
plone/app/testing/layers.py:58:52: E203 whitespace before ','
plone/app/testing/layers.py:59:52: E203 whitespace before ','
plone/app/testing/layers.py:60:52: E203 whitespace before ','
plone/app/testing/layers.py:62:52: E203 whitespace before ','
plone/app/testing/layers.py:63:52: E203 whitespace before ','
plone/app/testing/layers.py:65:52: E203 whitespace before ','
plone/app/testing/layers.py:66:52: E203 whitespace before ','
plone/app/testing/layers.py:67:52: E203 whitespace before ','
plone/app/testing/layers.py:69:52: E203 whitespace before ','
plone/app/testing/layers.py:71:52: E203 whitespace before ','
plone/app/testing/layers.py:73:52: E203 whitespace before ','
plone/app/testing/layers.py:74:52: E203 whitespace before ','
plone/app/testing/layers.py:76:52: E203 whitespace before ','
plone/app/testing/layers.py:77:52: E203 whitespace before ','
plone/app/testing/layers.py:79:52: E203 whitespace before ','
plone/app/testing/layers.py:80:52: E203 whitespace before ','
plone/app/testing/layers.py:82:52: E203 whitespace before ','
plone/app/testing/layers.py:83:52: E203 whitespace before ','
plone/app/testing/layers.py:84:52: E203 whitespace before ','
plone/app/testing/layers.py:86:52: E203 whitespace before ','
plone/app/testing/layers.py:87:52: E203 whitespace before ','
plone/app/testing/layers.py:101:80: E501 line too long (87 > 79 characters)
plone/app/testing/layers.py:134:80: E501 line too long (112 > 79 characters)
plone/app/testing/layers.py:139:80: E501 line too long (96 > 79 characters)
plone/app/testing/layers.py:158:21: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/layers.py:224:17: E128 continuation line under-indented for visual indent
plone/app/testing/layers.py:225:17: E128 continuation line under-indented for visual indent
plone/app/testing/layers.py:226:17: E128 continuation line under-indented for visual indent
plone/app/testing/layers.py:227:17: E128 continuation line under-indented for visual indent
plone/app/testing/layers.py:228:13: E124 closing bracket does not match visual indentation
plone/app/testing/layers.py:250:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/layers.py:252:1: E302 expected 2 blank lines, found 1
plone/app/testing/layers.py:290:9: E303 too many blank lines (2)
plone/app/testing/layers.py:317:1: E302 expected 2 blank lines, found 1
plone/app/testing/layers.py:321:1: E302 expected 2 blank lines, found 1
plone/app/testing/layers.py:331:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/layers.py:331:80: E501 line too long (96 > 79 characters)
plone/app/testing/layers.py:332:25: E221 multiple spaces before operator
plone/app/testing/layers.py:332:80: E501 line too long (94 > 79 characters)
plone/app/testing/layers.py:334:14: E221 multiple spaces before operator
plone/app/testing/layers.py:334:80: E501 line too long (110 > 79 characters)
plone/app/testing/layers.py:335:17: E221 multiple spaces before operator
plone/app/testing/layers.py:335:80: E501 line too long (115 > 79 characters)
plone/app/testing/interfaces.py:0:1: C101 Coding magic comment not found
plone/app/testing/interfaces.py:5:20: Q000 Remove bad quotes.
plone/app/testing/interfaces.py:11:28: E231 missing whitespace after ','
plone/app/testing/__init__.py:0:1: C101 Coding magic comment not found
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_ZSERVER' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_FIXTURE' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_FTP_SERVER' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PloneTestLifecycle' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_INTEGRATION_TESTING' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.FunctionalTesting' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.IntegrationTesting' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PloneFixture' imported but unused
plone/app/testing/__init__.py:2:1: F401 'plone.app.testing.layers.PLONE_FUNCTIONAL_TESTING' imported but unused
plone/app/testing/__init__.py:2:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:3:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:4:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:5:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:7:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:9:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:10:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:11:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:12:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:13:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:14:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:15:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:16:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.quickInstallProduct' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.tearDownMultiPluginRegistration' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.PloneWithPackageLayer' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.applyProfile' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.popGlobalRegistry' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.setRoles' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.ploneSite' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.logout' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.pushGlobalRegistry' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.PloneSandboxLayer' imported but unused
plone/app/testing/__init__.py:17:1: F401 'plone.app.testing.helpers.login' imported but unused
plone/app/testing/__init__.py:17:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:18:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:19:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:20:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:21:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:22:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:23:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:24:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:25:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:26:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:27:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:28:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:29:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:30:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:31:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:32:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:33:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:34:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:35:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:36:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.PLONE_SITE_ID' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.SITE_OWNER_PASSWORD' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_ID' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.DEFAULT_LANGUAGE' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.PLONE_SITE_TITLE' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_PASSWORD' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_ROLES' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.SITE_OWNER_NAME' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.TEST_USER_NAME' imported but unused
plone/app/testing/__init__.py:37:1: F401 'plone.app.testing.interfaces.ROBOT_TEST_LEVEL' imported but unused
plone/app/testing/__init__.py:37:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:38:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:39:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:40:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:41:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:42:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:43:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:44:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:45:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:46:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:47:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:48:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:49:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:50:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:51:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:52:1: I004 isort found an unexpected blank line in imports
plone/app/testing/__init__.py:53:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:54:1: F401 'plone.app.testing.cleanup.cleanUpMultiPlugins' imported but unused
plone/app/testing/__init__.py:54:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:55:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:56:1: I001 isort found an import in the wrong position
plone/app/testing/__init__.py:57:1: I004 isort found an unexpected blank line in imports
plone/app/testing/cleanup.py:0:1: C101 Coding magic comment not found
plone/app/testing/cleanup.py:5:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/cleanup.py:14:5: F401 'Products.PluggableAuthService.zcml' imported but unused
plone/app/testing/cleanup.py:21:80: E501 line too long (83 > 79 characters)
plone/app/testing/cleanup.py:37:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/selenium_layers.py:0:1: C101 Coding magic comment not found
plone/app/testing/selenium_layers.py:1:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/selenium_layers.py:3:1: I004 isort found an unexpected blank line in imports
plone/app/testing/selenium_layers.py:4:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:5:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:7:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:8:1: I001 isort found an import in the wrong position
plone/app/testing/selenium_layers.py:18:13: S001 found module formatter
plone/app/testing/selenium_layers.py:28:1: E305 expected 2 blank lines after class or function definition, found 1
plone/app/testing/selenium_layers.py:31:10: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:34:10: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:60:20: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:61:28: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:63:22: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:66:31: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:80:80: E501 line too long (82 > 79 characters)
plone/app/testing/selenium_layers.py:81:80: E501 line too long (86 > 79 characters)
plone/app/testing/selenium_layers.py:82:80: E501 line too long (80 > 79 characters)
plone/app/testing/selenium_layers.py:83:80: E501 line too long (81 > 79 characters)
plone/app/testing/selenium_layers.py:87:30: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:88:42: Q000 Remove bad quotes.
plone/app/testing/selenium_layers.py:100:17: S001 found module formatter
plone/app/testing/selenium_layers.py:100:27: E228 missing whitespace around modulo operator
plone/app/testing/selenium_layers.py:112:21: Q000 Remove bad quotes.
plone/app/testing/helpers.py:0:1: C101 Coding magic comment not found
plone/app/testing/helpers.py:4:1: I003 isort expected 1 blank line in imports, found 0
plone/app/testing/helpers.py:6:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:7:1: I004 isort found an unexpected blank line in imports
plone/app/testing/helpers.py:8:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:9:1: I004 isort found an unexpected blank line in imports
plone/app/testing/helpers.py:10:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:11:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:12:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:13:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:14:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:15:1: I001 isort found an import in the wrong position
plone/app/testing/helpers.py:112:21: S001 found module formatter
plone/app/testing/helpers.py:306:17: E128 continuation line under-indented for visual indent
plone/app/testing/helpers.py:311:23: Q000 Remove bad quotes.
plone/app/testing/helpers.py:311:23: S001 found module formatter
plone/app/testing/helpers.py:314:13: E128 continuation line under-indented for visual indent
plone/app/testing/helpers.py:393:16: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/app/testing/helpers.py:421:5: E125 continuation line with same indent as next logical line
plone/app/testing/helpers.py:421:9: E128 continuation line under-indented for visual indent
plone/app/testing/helpers.py:443:30: Q000 Remove bad quotes.
plone/app/testing/helpers.py:445:30: Q000 Remove bad quotes.
plone/app/testing/helpers.py:446:17: E128 continuation line under-indented for visual indent
plone/app/testing/helpers.py:446:17: Q000 Remove bad quotes.
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


I use rsvg_handle_new_from_file with "German ÖÄÜ" and everything works fine.
If i read the file with "File.ReadAllBytes" and pass it to rsvg_handle_new_from_data an error occurs.


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.44.0-pre-5-g3fedf85](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=61197&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **SUCCESS**
Summary: Running Build time: 00:00:57


Issue_#6095 (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2528 of 2528 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Ditto


this should read
```
["https://www.amazon.com/gp/dmusic/cloudplayer/*", "https://music.amazon.com/*"]
```


Remove?


removed as of 62db1337


Thanks for this! My bad.


I would inline these unless we are planning to use the constants elsewhere.


Let's re-assign this TODO to someone (happy to do me)


@taylorotwell

-I pointed A.com's password reset form to B.com's endpoint using B.com's _token.
-B.com received the request and sent an email, but the email still pointed to B.com (5.4.21, before the above change)

Is there another way they are spoofing this?


Start with the D gain.  Slowly raise to max value where you can balance between your hands without oscillating.  Then raise the other two, lowering the D gain as needed to prevent oscillation.   Plan on spending a few hours tuning using trial and error to get the best response while not falling when using the joystick.  Hope that helps!

> On May 9, 2017, at 5:12 AM, ASHKAN <notifications@github.com> wrote:
>
> hi Larry What approach do you propose to determine the PID parameters??
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>


TeamCity Trip Planner :: Tripper PR build [Build 25](http://ec2-35-164-15-23.us-west-2.compute.amazonaws.com/viewLog.html?buildId=121&buildTypeId=TripPlanner_TripperPrBuild&guest=1) is now running


TeamCity Trip Planner :: Tripper PR build [Build 25](http://ec2-35-164-15-23.us-west-2.compute.amazonaws.com/viewLog.html?buildId=121&buildTypeId=TripPlanner_TripperPrBuild&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:44


To be honest, I was wondering why you used an xlColor ptr instead of just a xlColor.


Console output of yahoo_movie.py:

/Users/Carl/work/Project/python-crawler/env/web-crawler/bin/python /Users/Carl/work/Project/python-crawler/web-crawler-practice/003/yahoo_movie.py
{'expectation': '95', 'ch_name': '異形：聖約', 'en_name': 'ALIEN: COVENANT', 'movie_id': '6694', 'poster_url': 'https://s.yimg.com/vu/movies/fp/mpost/66/94/6694.jpg', 'release_date': '2017-05-10', 'intro': '好萊塢傳奇大導雷利史考特（Ridley Scott）將重返經典，再度回歸他過去曾一手打造的超級科幻史詩鉅作《異形》，新作《異形：聖約》（ALIEN:', 'trailer_url': 'https://tw.movies.yahoo.com/video/異形-聖約-全新預告-070158457.html'}
{'expectation': '99', 'ch_name': '亞瑟：王者之劍', 'en_name': 'King Arthur: Legend of the Sword', 'movie_id': '6771', 'poster_url': 'https://s.yimg.com/vu/movies/fp/mpost/67/71/6771.jpg', 'release_date': '2017-05-11', 'intro': '知名導演蓋瑞奇為史詩奇幻動作鉅片《亞瑟：王者之劍》帶來獨特的視覺風格，本片的男主角是查理漢納，這部電影顛覆了石中劍與亞瑟王之間的傳', 'trailer_url': 'https://tw.movies.yahoo.com/video/亞瑟-王者之劍-終極預告-131758943.html'}
{'expectation': '63', 'ch_name': '幸福不設限', 'en_name': 'About Ray', 'movie_id': '5981', 'poster_url': 'https://s.yimg.com/vu/movies/fp/mpost/59/81/5981.jpg', 'release_date': '2017-05-12', 'intro': '摩登家庭媽媽經難唸  三代同堂最抓狂的幸福成年禮 紐約曼哈頓住宅區裡，住著一戶全新定義的現代三代家庭：獨自撫養女兒長大的單', 'trailer_url': 'https://tw.movies.yahoo.com/video/幸福不設限-中文預告-152955192.html'}
{'expectation': '100', 'ch_name': '愛情陷阱', 'en_name': 'The False Secrets', 'movie_id': '6743', 'poster_url': 'https://s.yimg.com/vu/movies/fp/mpost/67/43/6743.jpg', 'release_date': '2017-05-12', 'intro': '改編自大文豪馬里沃的浪漫喜劇《謊心計》 巴黎奧德翁劇院最賣座的舞台劇之一 長相俊帥卻家道中落的窮小子杜蘭（路易．卡瑞', 'trailer_url': ''}
{'expectation': '100', 'ch_name': '心靈小屋', 'en_name': 'The Shack', 'movie_id': '6798', 'poster_url': 'https://s.yimg.com/vu/movies/fp/mpost/67/98/6798.jpg', 'release_date': '2017-05-12', 'intro': '★《最美的安排》絕妙奇遇X《海邊的曼徹斯特》療癒傷痕  溫馨感人暖心首選 ★ 獨霸《紐約時報》暢銷榜70週冠軍 口碑超強小說登上大銀幕', 'trailer_url': 'https://tw.movies.yahoo.com/video/心靈小屋-中文預告-081540326.html'}
{'expectation': '50', 'ch_name': '一個人的收藏', 'en_name': 'My Dear Art', 'movie_id': '6834', 'poster_url': 'https://s.yimg.com/vu/movies/fp/mpost/68/34/6834.jpg', 'release_date': '2017-05-12', 'intro': '童話裡的愛麗絲隨手持懷錶的兔子躍入洞中，來到怪奇繽紛的異境夢遊，《一個人的收藏》正是那隻在前頭狂奔的白兔，領觀眾勇闖當代藝術的綺麗', 'trailer_url': 'https://tw.movies.yahoo.com/video/個人的收藏-中文預告-072630748.html'}
{'expectation': '100', 'ch_name': '媽媽，晚餐吃什麼？', 'en_name': "What's for Dinner, Mom?", 'movie_id': '6842', 'poster_url': 'https://s.yimg.com/vu/movies/fp/mpost/68/42/6842.jpg', 'release_date': '2017-05-12', 'intro': '★ 改編一青妙暢銷原著《我的箱子》、《日本媽媽的臺菜物語》 ★ 聖賽巴斯提安國際影展「美食單元」正式入選 ★ 謳歌台灣料理、一青', 'trailer_url': 'https://tw.movies.yahoo.com/video/媽媽-晚餐吃什麼-中文預告-094916097.html'}
{'expectation': '100', 'ch_name': '海上焰火', 'en_name': 'Fire at Sea', 'movie_id': '6845', 'poster_url': 'https://s.yimg.com/vu/movies/fp/mpost/68/45/6845.jpg', 'release_date': '2017-05-12', 'intro': '★第89屆奧斯卡金像獎最佳紀錄長片提名 ★第66屆柏林影展最高榮譽金熊獎最佳影片 ★第29屆歐洲電影獎最佳紀錄片 蘭佩杜', 'trailer_url': ''}
{'expectation': '75', 'ch_name': '巴黎交易員', 'en_name': 'L’OUTSIDER', 'movie_id': '6856', 'poster_url': 'https://s.yimg.com/vu/movies/fp/mpost/68/56/6856.jpg', 'release_date': '2017-05-12', 'intro': '他在銀行賺到的錢，遠超過父親幾十個勞碌人生… 傑宏來自布列塔尼，他幸運擠身法興銀行，在獲主管同儕欣賞下，搖身成為巴黎交易', 'trailer_url': 'https://tw.movies.yahoo.com/video/巴黎交易員-中文預告-021514643.html'}
{'expectation': '33', 'ch_name': '日韓巨星映畫祭VI：華麗之惡', 'en_name': '\u3000', 'movie_id': '6881', 'poster_url': 'https://s.yimg.com/vu/movies/fp/mpost/68/81/6881.jpg', 'release_date': '2017-05-12', 'intro': '今年邁向第六季的「日韓巨星映畫祭」以「華麗之惡」為題，聚焦在世代更迭下小人物遭遇各種困境的故事；此次集結六部日韓強檔，強化懷舊/當', 'trailer_url': ''}

Process finished with exit code 0


What if attributes[attr] is null/undefined?


Removed fractional symbol offset `tau`and sample rate offset `rate` variables, as they are not used because the phase and frequency offset is now induced by the channel.


There's a few styles in this file that are invalid. Not sure VSCode can catch that.


TeamCity Trip Planner :: Tripper PR build [Build 26](http://ec2-35-164-15-23.us-west-2.compute.amazonaws.com/viewLog.html?buildId=122&buildTypeId=TripPlanner_TripperPrBuild&guest=1) is now running


最後兩個暫時沒用到.


TeamCity Trip Planner :: Tripper PR build [Build 26](http://ec2-35-164-15-23.us-west-2.compute.amazonaws.com/viewLog.html?buildId=122&buildTypeId=TripPlanner_TripperPrBuild&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:34


Hope this file only contains purely share styles. Styles relating to individual components should be added in separate files and imported only in those components.


Issue_#6095 (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


This is the same thing, i.e. this commit does not actually change anything.


Do not merge this commit with master


Even if we don't use it anywhere else, I still think it makes sense to give those numbers a name. It might be a matter of taste, but I like to see what I'm skipping over when I use an offset.


`none` is not an option here.


seperate into two types


Travis CI [build 46](https://travis-ci.org/per1234/test/builds/230392127) has started. Once completed the job reports will be found at:
https://gist.github.com/per1234/5c871fa4db91afea5b8f740c6e62377e#file-travis_ci_job_report_46-2-tsv
(build ID: 230392127)


No space after rgba... `rgba(0, 0, 0, .25)`


No styles relating to element IDs. Add a class to that element and the styles based on that class.


Thanks, just going for worst case scenario so we can backport metrics to Spring 4 and Boot 1.x. I think I'll avoid Tomcat 6 support, however.


19 classes


100 what?


50 what?


Apparently this is sufficient on the compiler side.
The fix just deletes the error from the list of standard errors.
I also improved slightly the comments in core.p4.


Remove the `.jsx` bit.


The client for this is not yet officially supported. I just felt like adding some of the new packets.
Once it is supported there will be a board announcement for sure!


Is this being used anywhere? If not, please remove it.


Same here.


The following doc(s) have been deployed to the [vimswap](https://vimswap-static-docs.pantheonsite.io/docs) Multidev environment:
- [.gitignore](https://github.com/pantheon-systems/documentation/commit/07710526e27a3c7b5afa1072f5f81c0029c7cc84/.gitignore)
- [app/config/sculpin_kernel.yml](https://github.com/pantheon-systems/documentation/commit/b26496b183eb63ef1a5833ea2dfa0c8e1b89c5a8/app/config/sculpin_kernel.yml)


An**t** - typo :)


@MTzukanov I viewed your changes and they make sense for me.

What I noticed is that you well-refactored the test case in order to avoid redundancies and maximise reuse of code.

In literature, some state that, in test cases (and ONLY in test cases), it's generally accepted a certain level of repetition in order to make the code more plain, readable and with as less indirections as possible and I used  this coding style. If you generally prefer a more concise and reusable code (as the production one)  please let me know, and I can easy take it in account for next implementations.


git clone https://github.com/aalvesjr/teste-d.git
cd teste-d
bundle install

./exercicio path/to/testes.csv


I don't quite understand your point on doing this in the context of Physical Server.


Given that they don't take any parameters on initialisation, we could remove these properties completely and call the encrypt and decrypt methods directly on `JWEDirEncrypter` and `JWEDirDecrypter`, e.g. `encrypted = JWEDirEncrypter().encrypt(data, self.cek)`


which ruby


@monsta
This fixes
![mate-polkit-tray-icon](https://cloud.githubusercontent.com/assets/961604/25858291/ab28edfe-34db-11e7-81bc-3dbdb3844f59.png)
with gtk+-3.22/20 if GtkStatusIcon is used.
I am not sure about 3.18/16, but with 3.14 (rhel7) i don't saw this issue.
But using this commit here don't hurt.
From the other 2 commits in master the GtkAlignment commit changes  one line with translation.
The other GtkStock commit should be save to use for a 1.16.1 release.


@dirkhh I was refering to this when talking about "the other helper function" which is doing things (rounding, freedive syntax) differently:
https://github.com/Subsurface-divelog/subsurface/blob/master/core/statistics.c#L239
This one does similar things as your new function in qthelper.cpp but has at least the "more than x days" feature on top. This one is used for info and stats tab currently.

Do you think we should merge these two?
https://github.com/Subsurface-divelog/subsurface/blob/master/core/statistics.c#L239
https://github.com/Subsurface-divelog/subsurface/blob/master/core/qthelper.cpp#L927

Is there any strong need to have this in C or C++ domain or in both?


Note that most of the diff output is un-indenting.


Ligne 17 "Attention ! Les candidats qui passeraient le 1ier tour devront" confirmé par Boboule. Il n'y a pas de changements à faire sur cette ligne.


test


I added it to the __init__ file and the hook works now. I saw the .py file in site_packages so I am not sure why it was not importing for me (I double checked the version and vevn).

By the way, is there a way I can test this hook without making a full blown operator/airflow task? I was using simple salesforce previously, but if I try the same code using the conn_id from airflow, I get an error that there is no query_all.

```
from airflow.contrib.hooks import SalesforceHook
sf = SalesforceHook(conn_id='salesforce_test')

def query_salesforce(query):
    df = sf.query_all(query)
    df = pd.DataFrame(df['records'])
    df = pd.concat([df.drop(['attributes'], axis=1), df['attributes'].apply(pd.Series)], axis=1)
    return df

query_salesforce(query="SELECT Id, Email FROM Contact WHERE CreatedDate >= 2017-05-01T00:00:00.000Z")
```


Sure. Including the `__waitForIdle()` ?


Issue_#6095 (EnergyArchmage) - i386-Windows-7-VisualStudio-14: OK (2494 of 2494 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


I don't remember either.  I started out not even using a map and had a ton of variables in the class.  Then I thought a map would be cleaner.  I was having trouble figuring out the map syntax and copied an example from somewhere else in the code that happened to be using pointers.


This is fine for now, though I think ideally we just fall into the below cases and make the adapter layer work with this API. (We'll need to handle some of the settings and callbacks for example)


Currently, no. In a world where several scripts are all tabs of an ApplicationWindow, maybe. But I'm fine ditching it or defaulting to None or whatever.


new fcomment


@AdamEsterle in your example you're still hitting B.com's endpoint with B.com's domain. The exploit is in hitting B.com's IP with something other than B.com.

Laravel (prior to this patch) will happily use **any** hostname and if the web server is not configured to check the host and simply accepts all incoming requests.

From what I gather the exploit is unlikely to be viable on domain-based multi-tenant applications because they inspect and validate domains by design. Ironically this fix breaks the password reset functionality on such applications.


Remove the leftover `Math.floor`.


Using templates for PV is ~2% faster. One of the issues is that qsearch() and reduction() are also templatized for NodeTYpe, so when we convert search() to a non-template version, then we also convert qsearch and reduction.

Results for 10 tests for each version:

            Base      Test      Diff
    Mean    1413238   1387505   25733
    StDev   10369     11205     8273

p-value: 0.001
speedup: -0.018


Personally I think these 2 lines are too much. Validation happens during creation and there is only 1 field for JVM name so there's no need to display the JVM name again.


Sure. Initially I just blindly wrapped all the bits with as few changes as possible.


Don't hard code the JVM_ROUTE_MAX_LENGTH here - but that's the wrong value to display anyway.
You need to display the property key that would appear in vars.properties - JVM_ROUTE_MAX_LENGTH is the java reference to the key. I think the method is PropertyKeys.JVM_ROUTE_MAX_LENGTH.getPropertyName().


FYI:
Removing templates from search reduce code size from
1,161,728 bytes to 1,138,176 bytes

Also strangely the bench changed.


Again, blindly wrapped the bits. Most parameters to the app just do some setup too, but this parameter to the app calls setGrabWidget


I'd also really like to switch the ColorManagerDialog so that it creates the labels and buttons automatically based on retrieving data from the ColorManagerClass so that when a new color is needed you don't have to manually update the dialog.


yeah he did \o/


After DB creation -
issued:
~/code/olsonpm  cd sqlite-to-rest

and following error came on the screen, could you tell me what is missing here?

olsonpm/sqlite-to-rest   dev  npm install --global olsonpm/sqlite-to-rest                      ✓  2074  10:07:29
npm ERR! git rev-list -n1 master: fatal: ambiguous argument 'master': unknown revision or path not in the working tree.
npm ERR! git rev-list -n1 master: Use '--' to separate paths from revisions, like this:
npm ERR! git rev-list -n1 master: 'git <command> [<revision>...] -- [<file>...]'
npm ERR! git rev-list -n1 master:
npm ERR! git rev-list -n1 master: fatal: ambiguous argument 'master': unknown revision or path not in the working tree.
npm ERR! git rev-list -n1 master: Use '--' to separate paths from revisions, like this:
npm ERR! git rev-list -n1 master: 'git <command> [<revision>...] -- [<file>...]'
npm ERR! git rev-list -n1 master:
npm ERR! git rev-list -n1 master: fatal: ambiguous argument 'master': unknown revision or path not in the working tree.
npm ERR! git rev-list -n1 master: Use '--' to separate paths from revisions, like this:
npm ERR! git rev-list -n1 master: 'git <command> [<revision>...] -- [<file>...]'
npm ERR! git rev-list -n1 master:
npm ERR! Darwin 16.5.0
npm ERR! argv "/usr/local/Cellar/node/7.2.1/bin/node" "/usr/local/bin/npm" "install" "--global" "olsonpm/sqlite-to-rest"
npm ERR! node v7.2.1
npm ERR! npm  v3.10.9
npm ERR! code 128

npm ERR! Command failed: git rev-list -n1 master
npm ERR! fatal: ambiguous argument 'master': unknown revision or path not in the working tree.
npm ERR! Use '--' to separate paths from revisions, like this:
npm ERR! 'git <command> [<revision>...] -- [<file>...]'
npm ERR!
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:


That's not going to work very well.  For this, it would be better to introduce an `EmptyS` constructor to `Spec` (and disallow `S ""` programmatically, not via types).


I figured that'd be the case, but I didn't know why it was there in the first place. When it was all inline with the other stuff, did the existence of the viewer mess up the PathMatching stuff or something?


Llamar $scope.user


Sure


hahaha error xD


어렵군


Añadir el toast "el usuario ha sido registrado'


I tested this change and it works for me. EasyBlog pages are properly displayed without error now.


Travis CI [build 47](https://travis-ci.org/per1234/test/builds/230397968) has started. Once completed the job reports will be found at:
https://gist.github.com/per1234/5c871fa4db91afea5b8f740c6e62377e#file-travis_ci_job_report_47-1-tsv


Añadir toast "no se ha podido registrar el usuario, compruebe los datos"


I am seeing a similar problem but when the ZUp loader option is used and Z-Up is embedded in the model file.  My sense is the original author intended to use the fSign as a float version of the int variable upSign, but perhaps had mistyped the ternary.  The code "float fSign = upSign < 0 ? 1.0f : -1.0f" makes no sense to me and causes the case that we are using to be flipped vertically.  It would probably fix both cases if the initialization of fSign was inverted and this latest commit was reverted.


Testing done: cd similarity_search && cmake . && make && release/bunit

I did uncomment the preprocessor line to skip long running tests, since they were long running and didn't look like they should have any impact.


Añadir el modelo del form $scope.form


My bad, I keep forgetting that job `addons` doesn't get merged to the top-level ones, but replaces it. You simply  need to merge them manually, it's quite simple actually:

1. The top-level `addons` becomes

```
addons:
  apt:
    sources: &base_sources ['ubuntu-toolchain-r-test']
    packages: &base_packages
```
2. Job `addons` gain new entries like so

```
      addons:
        apt:
          packages:
            - *base_packages
            - gcc-<VERSION HERE>
            - g++-<VERSION HERE>
          sources:
            - *base_sources
            - ubuntu-toolchain-r-test
```


I wasn't actually using this one initially, and I only wrapped it because it seemed odd that I'd wrapped all the others and left this alone. But then once it was there, I used it:

https://github.com/andrewkaufman/golaemUtil/blob/docs/doc/source/Tutorials/screengrab.py#L112


I uploaded a new pot file but german translations stys on 100%.
So it might be save to use all commit from master (include translation sync) for a new 1.16.1 release.


TEST


#4 #5


I have released plone.app.contenttypes 1.2.23 for Plone 5.0.
(And plone.app.contenttypes 1.1.2 for Plone 4.3.)


> Do you think we should merge these two?
> https://github.com/Subsurface-divelog/subsurface/blob/master/core/statistics.c#L239 <https://github.com/Subsurface-divelog/subsurface/blob/master/core/statistics.c#L239>
> https://github.com/Subsurface-divelog/subsurface/blob/master/core/qthelper.cpp#L927 <https://github.com/Subsurface-divelog/subsurface/blob/master/core/qthelper.cpp#L927>
> Is there any strong need to have this in C or C++ domain or in both?
>
>

The challenge is getting access to the QString from C - that usually requires a wrapper
function. But careful, these two functions do very different things. One is the duration
of a dive, the other is the duration of a surface interval. That's why there are different
rules...

So no, these two probably shouldn't be merged.

/D


Agreed. This is mostly to get the remainder of the test suite passing now for Chrome.


Just making a change to anchor this branch to me so I can use it for testing a new project on Hackster.io

<iframe frameborder='0' height='327.5' scrolling='no' src='https://www.hackster.io/wyci/use-with-a-chromebook-374e17/embed' width='350'></iframe>


I'll come back to this a bit later and make it work with the adapter layer.


Removing this breaks webpack uglifyjs plugin: https://github.com/webpack-contrib/uglifyjs-webpack-plugin/blob/master/src/index.js
Any idea how to solve this?
Thanks


OK good!

2017-05-09 16:56 GMT+02:00 Maurice-Bams <notifications@github.com>:

> @deoel <https://github.com/deoel>
> Thanks. Mais je sais qu'il y a bien mieux. Ce sera pour bientôt!
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/deoel/php-esis.16.17/commit/759bcf179568a5811d02ff19354146b8562f71c4#commitcomment-22072051>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ALFrYwXy6R8-af1qy42UxaEKWifsZT8nks5r4H6JgaJpZM4NUDEz>
> .
>


I submitted a test:
https://github.com/VoyagerOne/Stockfish/commit/9d958bcd9f7fe77312779400216b201242bcffe7


Maybe its just a matter of how I was using it, but the node selection didn't bother me in practice. I always needed the right node selected anyways for other panes to draw the right scene. But I don't mind passing the node (or set?) in to the method and having it force the selection.


(父)子类&&(类成员)类

继承只存有比较抽象的基类,可访问受保护成员;
子类调用基类方法有二:
1'重载
2'在public区域内声明 using 基类::基类对象名且不含圆括号


c'est quoi ce commit ?


accepted


I see that it's working right now, thank you very much!


Somebody is committing to master... I know, I shouldn't do it either :wink:


Ok, I have just noticed that you are using a linear array scan here where a hardware prefetcher should gets activated, and also array items are small enough to fit in h/w prefetch ahead address bounds. One still can try mitigate a miss on a first access to an array continuous subpart by prefetching its start address on higher level (in callers of this function).


Cool!


Maybe we could improve the test case to check v-for scoped slot and single scoped slot used together ? I'll open a PR to update it.


oops


With `uglify-js 3.x` use `minify()` to perform compression and/or mangling.


I think you need to `plural` and `titleize` here.


Oops. I just noticed I committed these with the wrong git properties. Oh well.


`fun_name(author)` instead?


Issue_#6095 (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1294 of 1294 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-37.65%25-green.png)


@AdSchellevis can you review this? tests ok to improve the reload situation, avoid reconfigure loops, unnecessary filter reload and don't restart VPN anymore in IPv6 PPP cases...

For user comments see https://github.com/opnsense/core/commit/f31964a9dae2f57c4ed9486acc85700c58d74e7b#commitcomment-22067673


Not sure how to fix that without forcing a new push on it :/


This is quite helpful, thank you. It also makes me think, we would need more tests like this in the future, especially as we keep adding spaces.


Great :)


Netty killed the 5.0.0 alpha branch a while back, and purposely no longer active, would def suggest not adding this


Sure. I did see that it failed a test after I submitted the pr. I will look
to update so that it passes those test. I may have some additional changes
as I move my project forward.

On Mon, May 8, 2017 at 6:45 AM, Ramesh Mhetre <notifications@github.com>
wrote:

> Hey, Could you please also check the tests, which are broken for this
> function. Though, I've approved the pull.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/mhetreramesh/flysystem-backblaze/commit/bf934634c47c2204c8cb8832ee79ed67a6025647#commitcomment-22052775>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AOwMum8gN_oWi5y4S3mbIVpL6qLnXSQTks5r3vJbgaJpZM4NTx-D>
> .
>

--
Ken Rowland
kenrowland@mindless.com


revert back


int() избыточен. 50 - это число


I thought the same thing, but it was a quick and easy hack while I update the rest.


nit : Sc whats Sc, avoid abbreviations :)


Issue_#6095 (Nigusse) - x86_64-MacOS-10.9-clang: OK (2488 of 2488 tests passed, 1 test warnings)

Messages:

 * 1 test had: EIO diffs.
 * 1 test had: ESO small diffs.
 * 1 test had: MTR small diffs.
 * 1 test had: Table small diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


@VoyagerOne the bench you report is from an older version of master (a18c2c2c3f38070cb897a8a28cf1d6d45236ded4) have you merged ?


第一次改版


For #1


get_time_string_s(); is today used for info and stats tab for dive duration, accumulated dive duration and surface interval.


@vondele
Crap...I forgot.
Thanks.


```
# grep -r NIX_BUILD_HOOK .
./doc/manual/advanced-topics/distributed-builds.xml:variable <envar>NIX_BUILD_HOOK</envar> to point to a program that Nix
./doc/manual/advanced-topics/distributed-builds.xml:<envar>NIX_BUILD_HOOK</envar> to
./tests/common.sh.in:export NIX_BUILD_HOOK=
```


Indeed the optional here could be removed and instead the result of this class' methods could be wrapped in an optional here (for example): https://github.com/commercetools/commercetools-sync-java/blob/develop/src/main/java/com/commercetools/sync/commons/utils/GenericUpdateActionUtils.java#L66-L68

@andrii-kovalenko-ct Will change it. Thanks!


@nCrazed I know this bug for a lot of time didnt consider it exploit on the laravel side more bad server configuration...

this change can actually break a lot of laravel code out there as I don't know how much are actually changed the config('app.url') as to my knowledge until this point it only used for some artisan command which not everyone used


Could we have disabled those by writing a ``@skipInTravis`` decorator? Or was that a problem with import(s)?


Ok


вы печатаете 10-е число Фибоначчи, а не сумму первых 10 чисел Ф.


Can you fix this link?


TeamCity libpalaso :: palaso-linux64-libpalaso-3.1 Continuous [Build 3.1.333.26b2bf54daf792e17926aa5ca9811fde79e63bab](http://build.palaso.org/viewLog.html?buildId=90446&buildTypeId=bt322) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:37


  // , Incidentally, this seems to also allow an enterprising soul to provide their own custom configuration template.

Is that correct?


<details>

<summary>Submitting the task to TaskCluster failed. Details</summary>

```js

You do not have sufficient scopes. This request requires you
to have one of the following sets of scopes:
[
  [
    "secrets:get:repo:github.com/mozilla-releng/services:branch:taskcluster-rework",
    "queue:create-task:aws-provisioner-v1/releng-task",
    "queue:route:index.project.releng.services.requests.taskcluster-rework.by-timestamp.{{ 0 | $fromNow }}",
    "queue:route:index.project.releng.services.requests.taskcluster-rework.by-revision.568025d0645207a2d6d3887ab115039fc54cb1d5"
  ]
]

You only have the scopes:
[
  "assume:hook-id:project-releng/services-taskcluster-rework-*",
  "assume:repo:github.com/mozilla-releng/services:branch:taskcluster-rework",
  "hooks:modify-hook:project-releng/services-taskcluster-rework-*",
  "queue:create-task:aws-provisioner-v1/github-worker",
  "queue:create-task:aws-provisioner-v1/releng-task",
  "queue:route:index.garbage.*",
  "secrets:get:garbage/*",
  "secrets:get:repo:github.com/mozilla-releng/services:branch:taskcluster-rework",
  "secrets:set:garbage/*"
]

In other words you are missing scopes from one of the options:
 * Option 0:
    - "queue:route:index.project.releng.services.requests.taskcluster-rework.by-timestamp.{{ 0 | $fromNow }}", and
    - "queue:route:index.project.releng.services.requests.taskcluster-rework.by-revision.568025d0645207a2d6d3887ab115039fc54cb1d5"
----
method:     createTask
errorCode:  InsufficientScopes
statusCode: 403
time:       2017-05-09T15:49:36.710Z
```

</details>


Hey! I saw your this definition you wrote. Check this out. You may copy this format in creating your vulnerability definition.

[CVE-2011-3279.zip](https://github.com/amirspiegel/cisco_oval/files/987185/CVE-2011-3279.zip)

Good try though!


TeamCity libpalaso :: palaso-linux64-libpalaso-2.6 Continuous [Build 2.6.1372.26b2bf54daf792e17926aa5ca9811fde79e63bab](http://build.palaso.org/viewLog.html?buildId=90450&buildTypeId=PalasoLinux64v26Cont) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:34


But ... but, git commands become much shorter this way 😆

Alright, I will send PRs next time :smile:


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](https://github.com/phpmyadmin/phpmyadmin/wiki/Developer_guidelines#Indentation) for more information.

Offending files: doc/themes.rst


<details>

<summary>Submitting the task to TaskCluster failed. Details</summary>

```js

You do not have sufficient scopes. This request requires you
to have one of the following sets of scopes:
[
  [
    "secrets:get:repo:github.com/mozilla-releng/services:branch:taskcluster-rework",
    "queue:create-task:aws-provisioner-v1/releng-task",
    "queue:route:index.project.releng.services.*",
    "queue:route:index.project.releng.services.requests.taskcluster-rework.by-timestamp.{{ 0 | $fromNow }}",
    "queue:route:index.project.releng.services.requests.taskcluster-rework.by-revision.c1ec44f36e6b035737c4c21b223c195d80c69da0"
  ]
]

You only have the scopes:
[
  "assume:hook-id:project-releng/services-taskcluster-rework-*",
  "assume:repo:github.com/mozilla-releng/services:branch:taskcluster-rework",
  "hooks:modify-hook:project-releng/services-taskcluster-rework-*",
  "queue:create-task:aws-provisioner-v1/github-worker",
  "queue:create-task:aws-provisioner-v1/releng-task",
  "queue:route:index.garbage.*",
  "secrets:get:garbage/*",
  "secrets:get:repo:github.com/mozilla-releng/services:branch:taskcluster-rework",
  "secrets:set:garbage/*"
]

In other words you are missing scopes from one of the options:
 * Option 0:
    - "queue:route:index.project.releng.services.*", and
    - "queue:route:index.project.releng.services.requests.taskcluster-rework.by-timestamp.{{ 0 | $fromNow }}", and
    - "queue:route:index.project.releng.services.requests.taskcluster-rework.by-revision.c1ec44f36e6b035737c4c21b223c195d80c69da0"
----
method:     createTask
errorCode:  InsufficientScopes
statusCode: 403
time:       2017-05-09T15:51:30.701Z
```

</details>


@fniephaus Did you do this manually or did Squot write it like this? This is not expected to be empty.


TeamCity libpalaso :: palaso-linux64-master Continuous [Build 4.0.129.26b2bf54daf792e17926aa5ca9811fde79e63bab](http://build.palaso.org/viewLog.html?buildId=90451&buildTypeId=Libpalaso_PalasoLinux64masterContinuous) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:26


// , Incidentally, this seems to also allow an enterprising soul to provide their own custom configuration template.

For instance, if I wanted to use ReDiS 4.0 with this module, I could pass in a `redis/redis.conf.4.0.erb`, here, correct?


Travis CI [build 323](https://travis-ci.org/per1234/arduino-ci-script/builds/230397587) has started. Once completed the job reports will be found at:
https://gist.github.com/per1234/2eb6ef47b55f794dd2141a0fd5706219#file-travis_ci_job_report_323-1-tsv


![](https://github.trello.services/images/mini-trello-icon.png) [Migrate to new op code class.](https://trello.com/c/dXybA5Wl/195-migrate-to-new-op-code-class)


There is a way!  I'm about to make another push that's going to change some of the code in this repo.  For some reason, the hook I have here is out of sync with the hook that is included in the main airflow repo.  That's my bad.

However, I created a `sign_in` function which is designed to verify that your connection setup works.  All of the query functions that I have always call `sign_in` before trying to make the query to Salesforce.

`sign_in` also creates a `simple_salesforce.Salesforce` object that you can access directly via the `sf` attribute on the hook you created.

So you could modify the first part of your code to look like this:
```python
# changing the name of the hook object for clarity
hook = SalesforceHook(conn_id="salesforce_test")
hook.sign_in()

def query_salesforce(query):
    # now that we have signed in successfully, we can access the simple_salesforce object directly
    df = hook.sf.query_all(query)
````


TeamCity libpalaso :: fixing-to-fix-palaso-linux64-masterContinuous [Build 4.0.32.26b2bf54daf792e17926aa5ca9811fde79e63bab](http://build.palaso.org/viewLog.html?buildId=90453&buildTypeId=JasonHatesMono) outcome was **FAILURE**
Summary: Exit code 4 Build time: 00:01:06


<details>

<summary>Submitting the task to TaskCluster failed. Details</summary>

```js

String: '0' isn't a time expression
```

</details>


你好大神，宏基4743g的机器有教程吗


Вывод на экран лишний


What a great idea to allow override at the property level
Without chaning too much code this is a super duper fix.
Good job N


should be good now...


@v6 Indeed, you could always set a custom config.

If you do create a 4.0 erb we would appreciate the PR however! 😄


/is this commit meant to be on master already?


Docker image: 496870459963.dkr.ecr.eu-west-1.amazonaws.com/photobox/jenkins-tests:testing_2
Endpoint: http://jenkins-tests-jenkins-testing.k8s-test.photobox.com


TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.133.26b2bf54daf792e17926aa5ca9811fde79e63bab](http://build.palaso.org/viewLog.html?buildId=90449&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3727, ignored: 127 Build time: 00:05:54


<details>

<summary>Submitting the task to TaskCluster failed. Details</summary>

```js

You do not have sufficient scopes. This request requires you
to have one of the following sets of scopes:
[
  [
    "secrets:get:repo:github.com/mozilla-releng/services:branch:taskcluster-rework",
    "queue:create-task:aws-provisioner-v1/releng-task",
    "assume:queue:route:index.project.releng.services.*",
    "queue:route:index.project.releng.services.requests.taskcluster-rework.by-timestamp.2017-05-09T15:55:13.032Z",
    "queue:route:index.project.releng.services.requests.taskcluster-rework.by-revision.ad416a90cbd075a58f854a0ef69990346715f9c6"
  ]
]

You only have the scopes:
[
  "assume:hook-id:project-releng/services-taskcluster-rework-*",
  "assume:repo:github.com/mozilla-releng/services:branch:taskcluster-rework",
  "hooks:modify-hook:project-releng/services-taskcluster-rework-*",
  "queue:create-task:aws-provisioner-v1/github-worker",
  "queue:create-task:aws-provisioner-v1/releng-task",
  "queue:route:index.garbage.*",
  "secrets:get:garbage/*",
  "secrets:get:repo:github.com/mozilla-releng/services:branch:taskcluster-rework",
  "secrets:set:garbage/*"
]

In other words you are missing scopes from one of the options:
 * Option 0:
    - "assume:queue:route:index.project.releng.services.*", and
    - "queue:route:index.project.releng.services.requests.taskcluster-rework.by-timestamp.2017-05-09T15:55:13.032Z", and
    - "queue:route:index.project.releng.services.requests.taskcluster-rework.by-revision.ad416a90cbd075a58f854a0ef69990346715f9c6"
----
method:     createTask
errorCode:  InsufficientScopes
statusCode: 403
time:       2017-05-09T15:55:13.296Z
```

</details>


@TheRoyalBlock #IndentsMatter


This part of code have nothing to do with the note board scroll... Todo : I'll remove it asap


Yes, AFAIR it was not importable... I've tried to add appropriate dependencies or at least mockups, but failed.