[R/children_alt.R:18:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/children_alt.R#L18) *style:* **Variable or function name should be snake_case.**
```r
icd_children_defined_r.icd10cm <- function(x, short_code = icd_guess_short(x), warn = FALSE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/children.R:55:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/children.R#L55) *style:* **Variable or function name should be snake_case.**
```r
icd_children.character <- function(x, ...) {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/children.R:67:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/children.R#L67) *style:* **Variable or function name should be snake_case.**
```r
icd_children.icd9 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~
```
[R/children.R:92:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/children.R#L92) *style:* **Variable or function name should be snake_case.**
```r
icd_children.icd10 <- function(x, short_code = icd_guess_short(x), defined, billable = FALSE, ...) {
^~~~~~~~~~~~~~~~~~
```
[R/children.R:99:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/children.R#L99) *style:* **Variable or function name should be snake_case.**
```r
icd_children.icd10cm <- function(x, short_code = icd_guess_short(x), defined, billable = FALSE, ...) {
^~~~~~~~~~~~~~~~~~~~
```
[R/children.R:139:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/children.R#L139) *style:* **Variable or function name should be snake_case.**
```r
icd_children_defined.icd10cm <- function(x, short_code = icd_guess_short(x), warn = FALSE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/comorbid_alt.R:43:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/comorbid_alt.R#L43) *style:* **Variable and function names should not be longer than 36 characters.**
```r
icd10_comorbid_parent_search_all_at_once <- function(x,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/comorbid.R:40:28:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/comorbid.R#L40) *style:* **Variable or function name should be snake_case.**
```r
"%i9in%" <- function(icd9, icd9Reference) {
                           ^~~~~~~~~~~~~
```
[R/condense.R:36:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/condense.R#L36) *style:* **Variable or function name should be snake_case.**
```r
icd_condense.icd9 <- function(x, short_code = icd_guess_short(x), defined = NULL, warn = TRUE, ...) {
^~~~~~~~~~~~~~~~~
```
[R/condense.R:51:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/condense.R#L51) *style:* **Variable or function name should be snake_case.**
```r
icd_condense.character <- function(x, short_code = icd_guess_short(x), defined = NULL, ...) {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/condense.R:82:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/condense.R#L82) *style:* **Variable or function name should be snake_case.**
```r
  icd9Levels <- levels(x) # NULL if not a factor
  ^~~~~~~~~~
```
[R/convert.R:293:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L293) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_decimal.default <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:306:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L306) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_decimal.icd9 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:314:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L314) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_decimal.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:327:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L327) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_decimal.icd10cm <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:345:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L345) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_short.icd9 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:355:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L355) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_short.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:365:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L365) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_short.icd10cm <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:373:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L373) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_short.default <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:399:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L399) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_parts.icd9 <- function(x, mnr_empty = "") {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:408:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L408) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_parts.icd9 <- function(x, mnr_empty = "") {
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:416:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L416) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_parts.character <- function(x, mnr_empty = "") {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:431:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L431) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_parts.character <- function(x, mnr_empty = "") {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/diff_comorbid.R:59:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/diff_comorbid.R#L59) *style:* **Variable or function name should be snake_case.**
```r
icd_diff_comorbid.list <- function(x, y, all_names = NULL, x_names = NULL,
^~~~~~~~~~~~~~~~~~~~~~
```
[R/diff_comorbid.R:78:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/diff_comorbid.R#L78) *style:* **Variable or function name should be snake_case.**
```r
  common.names <- intersect(x_names, y_names)
  ^~~~~~~~~~~~
```
[R/diff_comorbid.R:80:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/diff_comorbid.R#L80) *style:* **Variable or function name should be snake_case.**
```r
  x.title <- deparse(substitute(x))
  ^~~~~~~
```
[R/diff_comorbid.R:81:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/diff_comorbid.R#L81) *style:* **Variable or function name should be snake_case.**
```r
  y.title <- deparse(substitute(y))
  ^~~~~~~
```
[R/diff_comorbid.R:87:5:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/diff_comorbid.R#L87) *style:* **Variable or function name should be snake_case.**
```r
    only.x <- setdiff(x[[n]], y[[n]])
    ^~~~~~
```
[R/diff_comorbid.R:88:5:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/diff_comorbid.R#L88) *style:* **Variable or function name should be snake_case.**
```r
    only.y <- setdiff(y[[n]], x[[n]])
    ^~~~~~
```
[R/explain-table.R:54:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain-table.R#L54) *style:* **Variable or function name should be snake_case.**
```r
icd_explain_table.default <- function(x, short_code = icd_guess_short(x), condense = FALSE,
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/explain-table.R:69:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain-table.R#L69) *style:* **Variable or function name should be snake_case.**
```r
icd_explain_table.icd9 <- function(...) {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/explain-table.R:76:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain-table.R#L76) *style:* **Variable or function name should be snake_case.**
```r
icd_explain_table.icd10 <- function(...) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/explain-table.R:127:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain-table.R#L127) *style:* **Variable or function name should be snake_case.**
```r
icd_explain_table.icd9cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/explain-table.R:138:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain-table.R#L138) *style:* **Variable or function name should be snake_case.**
```r
icd_explain_table.icd10cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/explain.R:62:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain.R#L62) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.default <- function(x, short_code = icd_guess_short(x), condense = TRUE, brief = FALSE, warn = TRUE, ...) {
^~~~~~~~~~~~~~~~~~~
```
[R/explain.R:74:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain.R#L74) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.list <- function(x, ...) {
^~~~~~~~~~~~~~~~
```
[R/explain.R:81:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain.R#L81) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.icd9 <- function(...) {
^~~~~~~~~~~~~~~~
```
[R/explain.R:88:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain.R#L88) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.icd9cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~
```
[R/explain.R:123:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain.R#L123) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.icd10cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~
```
[R/explain.R:146:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain.R#L146) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.icd10 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~
```
[R/generate_mappings.R:311:18:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/generate_mappings.R#L311) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    c(kids, x) %>% unique %>% icd_sort.icd10
               ~~^
```
[R/generate_mappings.R:391:14:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/generate_mappings.R#L391) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
      c(x) %>% unique %>% icd_sort.icd10
           ~~^
```
[R/generate_sysdata.R:125:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/generate_sysdata.R#L125) *style:* **Variable or function name should be snake_case.**
```r
icd9_generate_all_ <- function(major_fun, short_code = TRUE,
^~~~~~~~~~~~~~~~~~
```
[R/generate_sysdata.R:191:17:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/generate_sysdata.R#L191) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
    rtf_url = c( # FY11,12,13,14 are the same?
                ^
```
[R/guess.R:40:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/guess.R#L40) *style:* **Variable or function name should be snake_case.**
```r
icd_guess_version.icd9 <- function(x, short_code, ...) "icd9" #nocov
^~~~~~~~~~~~~~~~~~~~~~
```
[R/guess.R:45:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/guess.R#L45) *style:* **Variable or function name should be snake_case.**
```r
icd_guess_version.icd10 <- function(x, short_code, ...) "icd10" #nocov
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/guess.R:50:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/guess.R#L50) *style:* **Variable or function name should be snake_case.**
```r
icd_guess_version.factor <- function(x, short_code = NULL, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/guess.R:57:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/guess.R#L57) *style:* **Variable or function name should be snake_case.**
```r
icd_guess_version.character <- function(x, short_code = NULL, n = 10, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/guess.R:100:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/guess.R#L100) *style:* **Variable or function name should be snake_case.**
```r
icd_guess_version.data.frame <- function(x, short_code = NULL, icd_name = get_icd_name(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/parse-comorbid.R:85:11:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-comorbid.R#L85) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    out %>% unlist %>% unique %>% as.icd9 %>% as.icd_short_diag -> icd9_map_ahrq[[cmb]]
        ~~^
```
[R/parse-comorbid.R:85:22:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-comorbid.R#L85) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    out %>% unlist %>% unique %>% as.icd9 %>% as.icd_short_diag -> icd9_map_ahrq[[cmb]]
                   ~~^
```
[R/parse-comorbid.R:85:33:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-comorbid.R#L85) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    out %>% unlist %>% unique %>% as.icd9 %>% as.icd_short_diag -> icd9_map_ahrq[[cmb]]
                              ~~^
```
[R/parse-comorbid.R:146:30:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-comorbid.R#L146) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  icd10_map_ahrq[ahrq_htn] %>% unlist %>% unname -> icd10_map_ahrq[["HTNCX"]]
                           ~~^
```
[R/parse-comorbid.R:147:30:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-comorbid.R#L147) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  icd10_map_ahrq[ahrq_chf] %>% unlist %>% unname -> icd10_map_ahrq[["CHF"]]
                           ~~^
```
[R/parse-comorbid.R:148:32:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-comorbid.R#L148) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  icd10_map_ahrq[ahrq_renal] %>% unlist %>% unname -> icd10_map_ahrq[["RENLFAIL"]]
                             ~~^
```
[R/parse-comorbid.R:212:47:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-comorbid.R#L212) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  icd9_map_quan_deyo %<>% as.icd_short_diag %>% icd9 %>% icd_comorbidity_map
                                            ~~^
```
[R/parse-icd10cm-xml.R:39:7:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-icd10cm-xml.R#L39) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  j %>% xml2::xml_children() %>%
    ~~^
```
[R/parse-icd10cm-xml.R:43:7:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-icd10cm-xml.R#L43) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  j %>% xml2::xml_children() %>% magrittr::extract(chapter_indices) -> chaps
    ~~^
```
[R/parse-icd10cm-xml.R:48:14:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-icd10cm-xml.R#L48) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    c_kids %>% xml2::xml_name() %>% magrittr::equals("section") -> subchap_indices
           ~~^
```
[R/parse-rtf.R:81:21:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L81) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
      code  = out %>% unname %>% icd_decimal_to_short.icd9 %>% icd9cm,
                  ~~^
```
[R/parse-rtf.R:81:32:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L81) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
      code  = out %>% unname %>% icd_decimal_to_short.icd9 %>% icd9cm,
                             ~~^
```
[R/parse-rtf.R:229:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L229) *style:* **Variable or function name should be snake_case.**
```r
  useBytes <- list(...)[["useBytes"]]
  ^~~~~~~~
```
[R/parse-rtf.R:414:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L414) *style:* **Variable or function name should be snake_case.**
```r
  re_fifth_range_V30V39 <- "The following two fifths-digits are for use with the fourth-digit \\.0"
  ^~~~~~~~~~~~~~~~~~~~~
```
[R/parse-rtf.R:415:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L415) *style:* **Variable or function name should be snake_case.**
```r
  re_V30V39_fifth <- "V3[[:digit:]]\\.0[01]$"
  ^~~~~~~~~~~~~~~
```
[R/parse-rtf.R:417:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L417) *style:* **Variable or function name should be snake_case.**
```r
  lines_V30V39 <- grep(re_fifth_range_V30V39, filtered)
  ^~~~~~~~~~~~
```
[R/parse-rtf.R:421:60:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L421) *style:* **Variable or function name should be snake_case.**
```r
    str_pair_match("([[:digit:]])[[:space:]](.*)", ...) -> suffices_V30V39
                                                           ^~~~~~~~~~~~~~~
```
[R/parse-rtf.R:610:11:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L610) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
      v %>%  strsplit("-", fixed = TRUE) %>% unlist -> pair
        ~~^
```
[R/parse-rtf.R:640:10:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L640) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  qual %>% strip %>%
       ~~^
```
[R/parse-rtf.R:647:26:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L647) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
      strsplit(v, "-") %>% unlist %>% as.integer -> pair
                       ~~^
```
[R/parse.R:285:61:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse.R#L285) *style:* **Variable or function name should be snake_case.**
```r
                                               perl = TRUE, useBytes = TRUE) {
                                                            ^~~~~~~~
```
[R/parse.R:348:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse.R#L348) *style:* **Variable or function name should be snake_case.**
```r
fixSubchapterNa <- function(x, start, end) {
^~~~~~~~~~~~~~~
```
[R/ranges.R:70:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L70) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range.character <- function(start, end, short_code = NULL, defined = TRUE, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:95:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L95) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range.icd10cm <- function(start, end, short_code = icd_guess_short(c(start, end)),
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:143:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L143) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range_major.default <- function(start, end) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:153:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L153) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range_major.icd10cm <- function(start, end) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:160:42:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L160) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  se <- as_char_no_warn(c(start, end)) %>% trim %>% toupper
                                       ~~^
```
[R/ranges.R:177:36:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L177) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  unique_mjrs[pos[[1]]:pos[[2]]] %>% as_char_no_warn() %>% as.icd10cm
                                 ~~^
```
[R/ranges.R:182:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L182) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range.icd9 <- function(start, end,
^~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:336:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L336) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range_major.icd9 <- function(start, end, defined = TRUE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:426:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L426) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_minor.icd9 <- function(mnr, is_e = FALSE) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:431:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L431) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_minor.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:42:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L42) *style:* **Variable or function name should be snake_case.**
```r
icd_is_defined.icd9 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~
```
[R/real.R:62:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L62) *style:* **Variable or function name should be snake_case.**
```r
icd_is_defined.icd10cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:78:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L78) *style:* **Variable or function name should be snake_case.**
```r
icd_is_defined.icd10 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~
```
[R/real.R:88:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L88) *style:* **Variable or function name should be snake_case.**
```r
icd_is_defined.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:111:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L111) *style:* **Variable or function name should be snake_case.**
```r
icd_get_defined.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:120:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L120) *style:* **Variable or function name should be snake_case.**
```r
icd_get_defined.icd9 <- function(x, short_code = icd_guess_short(x), billable = FALSE) {
^~~~~~~~~~~~~~~~~~~~
```
[R/real.R:146:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L146) *style:* **Variable or function name should be snake_case.**
```r
icd_is_billable.icd9 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~
```
[R/real.R:157:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L157) *style:* **Variable or function name should be snake_case.**
```r
icd_is_billable.icd10cm <- function(x, short_code = icd_guess_short(x), icd10cm_edition = "2016", ...) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:170:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L170) *style:* **Variable or function name should be snake_case.**
```r
icd_is_billable.icd10 <- function(x, short_code = icd_guess_short(x), icd10cm_edition = "2016", ...) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:179:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L179) *style:* **Variable or function name should be snake_case.**
```r
icd_is_billable.icd9cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:193:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L193) *style:* **Variable or function name should be snake_case.**
```r
icd_is_billable.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:220:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L220) *style:* **Variable or function name should be snake_case.**
```r
icd_get_billable.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:232:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L232) *style:* **Variable or function name should be snake_case.**
```r
icd_get_billable.icd9cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:245:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L245) *style:* **Variable or function name should be snake_case.**
```r
icd_get_billable.icd9 <- function(...) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:275:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L275) *style:* **Variable or function name should be snake_case.**
```r
icd_get_billable.icd10cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:288:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L288) *style:* **Variable or function name should be snake_case.**
```r
icd_get_billable.icd10 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~
```
[R/score.R:76:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/score.R#L76) *style:* **Variable or function name should be snake_case.**
```r
icd_charlson.data.frame <- function(x, visit_name = NULL,
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/score.R:302:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/score.R#L302) *style:* **Variable or function name should be snake_case.**
```r
icd_van_walraven.data.frame <- function(x, visit_name = NULL, return_df = FALSE,
^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sort.R:39:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/sort.R#L39) *style:* **Variable or function name should be snake_case.**
```r
icd_sort.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~
```
[R/sort.R:52:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/sort.R#L52) *style:* **Variable or function name should be snake_case.**
```r
icd_sort.icd10 <- function(x, short_code = NULL, ...) {
^~~~~~~~~~~~~~
```
[R/sort.R:61:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/sort.R#L61) *style:* **Variable or function name should be snake_case.**
```r
icd_sort.icd9 <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~
```
[R/util.R:192:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/util.R#L192) *style:* **Variable or function name should be snake_case.**
```r
get_visit_name.data.frame <- function(x, visit_name = NULL) {
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/util.R:212:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/util.R#L212) *style:* **Variable or function name should be snake_case.**
```r
get_visit_name.matrix <- function(x, visit_name = NULL) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/util.R:281:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/util.R#L281) *style:* **Variable or function name should be snake_case.**
```r
get_non_ASCII <- function(x)
^~~~~~~~~~~~~
```
[R/util.R:286:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/util.R#L286) *style:* **Variable or function name should be snake_case.**
```r
is_non_ASCII <- function(x)
^~~~~~~~~~~~
```
[R/util.R:328:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/util.R#L328) *style:* **Variable or function name should be snake_case.**
```r
chapter_to_desc_range.icd9 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/util.R:334:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/util.R#L334) *style:* **Variable or function name should be snake_case.**
```r
chapter_to_desc_range.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:245:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L245) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:257:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L257) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid.icd10 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~
```
[R/valid.R:274:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L274) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid.icd9 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~
```
[R/valid.R:331:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L331) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid_major.default <- function(x, whitespace_ok = TRUE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:339:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L339) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid_major.icd9 <- function(x, whitespace_ok = TRUE) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:346:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L346) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid_major.icd10 <- function(x, whitespace_ok = TRUE) {
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:370:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L370) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid.icd_comorbidity_map <- function(x, short_code, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:396:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L396) *style:* **Variable or function name should be snake_case.**
```r
icd_get_valid.character <- function(x, short_code = icd_guess_short(x)) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:408:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L408) *style:* **Variable or function name should be snake_case.**
```r
icd_get_valid.icd9 <- function(x, short_code = icd_guess_short(x)) {
^~~~~~~~~~~~~~~~~~
```
[R/valid.R:415:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L415) *style:* **Variable or function name should be snake_case.**
```r
icd_get_valid.icd10 <- function(x, short_code = icd_guess_short(x)) {
^~~~~~~~~~~~~~~~~~~
```
[R/valid.R:422:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L422) *style:* **Variable or function name should be snake_case.**
```r
icd_get_valid.icd10cm <- function(x, short_code = icd_guess_short(x)) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:440:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L440) *style:* **Variable or function name should be snake_case.**
```r
icd_get_invalid.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:454:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L454) *style:* **Variable or function name should be snake_case.**
```r
icd_get_invalid.icd9 <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:461:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L461) *style:* **Variable or function name should be snake_case.**
```r
icd_get_invalid.icd10 <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:469:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L469) *style:* **Variable or function name should be snake_case.**
```r
icd_get_invalid.icd_comorbidity_map <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:490:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L490) *style:* **Variable or function name should be snake_case.**
```r
icd_get_major.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~~
```
[R/valid.R:503:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L503) *style:* **Variable or function name should be snake_case.**
```r
icd_is_major.default <- function(x) {
^~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:514:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L514) *style:* **Variable or function name should be snake_case.**
```r
icd_is_major.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~
```
[R/valid.R:524:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L524) *style:* **Variable or function name should be snake_case.**
```r
icd_is_major.icd10cm <- function(x) {
^~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:531:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L531) *style:* **Variable or function name should be snake_case.**
```r
icd_is_major.icd9 <- function(x) {
^~~~~~~~~~~~~~~~~
```
[tests/testthat/test-class.R:207:19:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-class.R#L207) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  icd9_map_ahrq %>% unclass %>% icd_comorbidity_map -> x
                ~~^
```
[tests/testthat/test-comorbid-maps-icd9.R:176:50:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-comorbid-maps-icd9.R#L176) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                     icd9_map_quan_elix[["DMcx"]] ))
                                                 ^
```
[tests/testthat/test-comorbid-maps-icd9.R:178:50:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-comorbid-maps-icd9.R#L178) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                     icd9_map_quan_elix[["Mets"]] ))
                                                 ^
```
[tests/testthat/test-comorbid-maps-icd9.R:180:45:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-comorbid-maps-icd9.R#L180) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                     icd9_map_elix[["DMcx"]] ))
                                            ^
```
[tests/testthat/test-comorbid-maps-icd9.R:182:45:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-comorbid-maps-icd9.R#L182) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                     icd9_map_elix[["Mets"]] ))
                                            ^
```
[tests/testthat/test-comorbid-maps-icd9.R:183:70:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-comorbid-maps-icd9.R#L183) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_false(any(icd9_map_ahrq[["DM"]] %in% icd9_map_ahrq[["DMcx"]] ))
                                                                     ^
```
[tests/testthat/test-comorbid-maps-icd9.R:184:73:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-comorbid-maps-icd9.R#L184) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_false(any(icd9_map_ahrq[["Tumor"]] %in% icd9_map_ahrq[["Mets"]] ))
                                                                        ^
```
[tests/testthat/test-comorbid-maps-icd9.R:695:32:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-comorbid-maps-icd9.R#L695) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  res_nofactor <- vermont_dx %>% icd_wide_to_long %>% icd9_comorbid_ahrq
                             ~~^
```
[tests/testthat/test-convert.R:24:16:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-convert.R#L24) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_equal( icd_decimal_to_parts.icd9(""), list(mjr = NA_character_, mnr = NA_character_) )
               ^
```
[tests/testthat/test-convert.R:24:94:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-convert.R#L24) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_equal( icd_decimal_to_parts.icd9(""), list(mjr = NA_character_, mnr = NA_character_) )
                                                                                ^
```
[tests/testthat/test-convert.R:197:13:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-convert.R#L197) *style:* **Variable or function name should be snake_case.**
```r
            icd9List <- icd9_map_ahrq #todo SUBSET OR EXTRA MAPPINGS?
            ^~~~~~~~
```
[tests/testthat/test-lints.R:19:38:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-lints.R#L19) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
    "package:devtools" %nin% search() ) {
                                     ^
```
[tests/testthat/test-ranges.R:252:23:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-ranges.R#L252) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_equal_no_icd( ("042" %i9s% "042")[1], "042")
                      ^
```
[tests/testthat/test-score.R:40:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-score.R#L40) *style:* **Variable or function name should be snake_case.**
```r
  c2.inv <- cbind(t(comorbids[2, 2:18]), c(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 2, 2, 2, 2, 3, 6, 6))
  ^~~~~~
```
[tests/testthat/test-score.R:237:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-score.R#L237) *style:* **Variable or function name should be snake_case.**
```r
  c2.inv <- cbind(t(comorbids[2, -1]),
  ^~~~~~
```
[tests/testthat/test-valid.R:392:109:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-valid.R#L392) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_equal(icd9_filter_valid(pts_invalid_mix, short_code = TRUE, invert = FALSE), pts_invalid_mix[c(1, 3 ), ])
                                                                                ^
```


Ottimo! I commenti per questo capitolo sono nello issue #31


The lines that are of the form:

`(eval echo $as_me:<NUMBER>: \"$ac_link\") >&5`

.. are for diagnostic purposes, to show where in configure that text is being echoed from in-case someone needs to go in and investigate why they are not seeing the output they expect.

If you added something to `configure.ac` that caused only a single extra line to be emitted to the very top of `configure` then all those numbers would shift by exactly +1.


@yguo0905 this should indeed be "canonical-kubernetes-tests/logs-gke/kubernetes-gce-e2e-node". @chuckbutler just confirmed to me that historic data is not lost, so it's just a matter of reverting this change.


It was breaking out of the switch case before, which made it go back to the "start" instruction cleaning all the registers.


After further investigation, i dont think we lost anything! Sorry for the scare there, i assure you it scared me pretty well :)

Looks like we just need to get the yaml pointer updated to point back to our location for the CDK entries in gubernator.

https://console.cloud.google.com/storage/browser/canonical-kubernetes-tests/logs/kubernetes-gce-e2e-node/

the clear identifier between the two efforts is the `logs` segment of the path.

i beleive the `logs-gke` to be the path you'r elooking for

whats in `logs` has been our effort unless there's been some encapsulation leakage on our end, which is completely possible. I'll lean on @chrisglass for more info there.


hmmm here's what's going on:

```strace
[pid    67] execve("/usr/local/sbin/node --trace-warnings", ["node --trace-warnings", "/wedeploy-container/node_modules"...], [/* 15 vars */]) = -1 ENOENT (No such file or directory)
[pid    67] execve("/usr/local/bin/node --trace-warnings", ["node --trace-warnings", "/wedeploy-container/node_modules"...], [/* 15 vars */]) = -1 ENOENT (No such file or directory)
[pid    67] execve("/usr/sbin/node --trace-warnings", ["node --trace-warnings", "/wedeploy-container/node_modules"...], [/* 15 vars */]) = -1 ENOENT (No such file or directory)
[pid    67] execve("/usr/bin/node --trace-warnings", ["node --trace-warnings", "/wedeploy-container/node_modules"...], [/* 15 vars */]) = -1 ENOENT (No such file or directory)
[pid    67] execve("/sbin/node --trace-warnings", ["node --trace-warnings", "/wedeploy-container/node_modules"...], [/* 15 vars */]) = -1 ENOENT (No such file or directory)
[pid    67] execve("/bin/node --trace-warnings", ["node --trace-warnings", "/wedeploy-container/node_modules"...], [/* 15 vars */]) = -1 ENOENT (No such file or directory)
[pid    67] write(2, "/usr/bin/env: ", 14/usr/bin/env: ) = 14
[pid    67] write(2, "node --trace-warnings", 21node --trace-warnings) = 21
[pid    67] write(2, ": No such file or directory", 27: No such file or directory) = 27
```


Moet `UNAUTHENTICATED_TOKEN` zijn.


@J-Lambo I'll fix this URL, the one you used just links to a page that shows you the readme instead of the example.


Fixed


quan descargar la carpeta d'aquesta projecte, pot ser no trobar les libreries, s'ha de cambiar "propierties" -> "Configuration Manager" -> "platform" a (Win32) i "Active solution platform" a (x86).


Thanks, I'll check it out.


This seems to conflict with `.defaultValue()`.
```
Exception in thread "main" java.lang.ExceptionInInitializerError
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.exist.start.Main.invokeMain(Main.java:140)
        at org.exist.start.Main.run(Main.java:453)
        at org.exist.start.Main.main(Main.java:64)
Caused by: java.lang.IllegalArgumentException: Having a requried argument and a default value makes no sense
        at se.softhouse.common.guavaextensions.Preconditions2.check(Preconditions2.java:45)
        at se.softhouse.jargo.ArgumentBuilder.defaultValue(ArgumentBuilder.java:344)
        at org.exist.backup.ExportMain.<clinit>(ExportMain.java:93)
        ... 7 more
```


Add generator as it is in other entities


@johnsteele Is this intentionally not renamed to `RHAMT_HOME`?

for 4.0 we renamed the environment variables too


The `_t` suffix indicates a type. These are not types. Please remove it.


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/5f2b938e-d1dc-48d7-b430-8cd186823952 "moviasconnect"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/e7bd51b1-f252-4413-80db-578feb8b7c42 "moviasconnect") deployed [moviasconnect](https://github.com/efmiranda/moviasconnect/releases/tag/deploy-ibm-yp-us-south-movias-dev-20170504-131643 "deploy-ibm-yp-us-south-movias-dev-20170504-131643") to [dev](https://console.ng.bluemix.net/apps/1079c952-4422-430f-866a-49923506fc68 "ibm:yp:us-south:movias:dev"), including this commit


Cookie wird jetzt per Regex ausgelesen, statt einfach nach einem exakten String (der auch noch von anderen HTML Elementen als dem eigentlich relevanten abhängt) zu suchen.
Deutlich eleganter und robuster gegen Layout verschiebungen der Webseite


I see, thanks!


Exercises for my ASD course


@maha107 #31


It's worth to add here also repositories as well for new entities - if they are going to be put in database


![](https://github.trello.services/images/mini-trello-icon.png) [Button for Day events](https://trello.com/c/Ycrcf3DU/15-button-for-day-events)


Ok, though I'm not sure if vals are really needed:
```
kaptTask.mapSource {
    project.fileTree(kaptTask.stubsDir) +
    kotlinCompile.source.filter { it.extension == "java" && !kaptTask.isInsideDestinationDirs(it) }.asFileTree
}
```


Uhh, hold on, aren't these supposed to be `mouse_button<mouse_button_left>`, etc?


Is this already implemented? I noticed the documentation of [1.12.34.1](https://modpagespeed.com/doc/filter-image-optimize#srcsets)

> In addition to optimizing image src attributes, as of 1.12.34.1 PageSpeed will now also optimize images referenced in srcsets. This includes all PageSpeed image optimizations except resizing.

Tried this with 1.12.34.2 but I noticed my srcset images were still left alone. Maybe I'm missing something :)


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/5e04fc2b-048a-4fe3-9cab-6419f1ce9bda "mfe-dev-fe"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/d2e8d9ea-7a90-487a-a9cd-c822cc6d9891 "mfe-dev-fe") deployed [mfe-dev-be](https://github.com/ilantoren/mfe-dev-be/releases/tag/deploy-ibm-yp-us-south-MyFavoreats-myfavoreats-20170504-132034 "deploy-ibm-yp-us-south-MyFavoreats-myfavoreats-20170504-132034") to [myfavoreats](https://console.ng.bluemix.net/apps/4a80c652-9946-4627-8e17-db91b70a3998 "ibm:yp:us-south:MyFavoreats:myfavoreats"), including this commit


Docker image: 496870459963.dkr.ecr.eu-west-1.amazonaws.com/photobox/jenkins-tests:testing_2
Endpoint: http://jenkins-tests-jenkins-testing.k8s-test.photobox.com


No, because the typedefs still wrap `mouse_button`.


`assertKapt3FullyExecuted` looks strange in context of a block where `useKapt3 == false`. It seems useless.


Oh, so they do. Missed that bit.


```kotlin
a +
b
```

is hard to read. And the line is too long without wrapping.


LoeiFy 大大 你好， 非常喜欢你的Diaspora主题，提两点建议，一是主页添加返回顶部按钮  方便用户使用，而是，添加搜索框 方便用户检索  。非常喜欢这个主题，希望能恢复我哦


Well, probably `assertKapt3FullyExecuted` is not an accurate name. I'll rename it to `assertKaptFullyExecuted`.


`used`* @andrii-kovalenko-ct


Can you assert that the substring is actually present before replacing it?


fromghgh


@vincentchabannes we need to add this to the json file ;)


У вас не гарантируется, что в пароле будут И большие И маленькие символы


![](https://github.trello.services/images/mini-trello-icon.png) [BUG: Create alert for "undefined"](https://trello.com/c/3wXmgkLA/48-bug-create-alert-for-undefined)


Puzzle `45-46f15e48` disappeared, that's why I closed as #47


Puzzle `37-8087fd76` discovered and submitted as #49


@yanex right now the function declaration looks like this:
```
private fun CompiledProject.assertKapt3FullyExecuted() {
        if (useKapt3) {
            assertNotContains(":kaptKotlin UP-TO-DATE",
                    ":kaptGenerateStubsKotlin UP-TO-DATE")
        }
}
```
It does not seem that renaming `assertKapt3FullyExecuted` will make any difference :)


What kind of srcsets do you have? IIRC it only supported some basic forms,
and maybe yours are just too cool & sophisticated for it.

On Thu, May 4, 2017 at 9:20 AM, rmcs2002 <notifications@github.com> wrote:

> Is this already implemented? I noticed the documentation of 1.12.34.1
> <https://modpagespeed.com/doc/filter-image-optimize#srcsets>
>
> In addition to optimizing image src attributes, as of 1.12.34.1 PageSpeed
> will now also optimize images referenced in srcsets. This includes all
> PageSpeed image optimizations except resizing.
>
> Tried this with 1.12.34.2 but I noticed my srcset images were still left
> alone. Maybe I'm missing something :)
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pagespeed/mod_pagespeed/commit/428b7e044e753169724e7512804d41cca9c11651#commitcomment-22016344>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ADl1RPbOeSb1hrLqsp9qz5kKHZMldWl2ks5r2dCfgaJpZM4Jbxkd>
> .
>


Wut? It correctly refers to keybase.


ok


In the commit message.


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/5f2b938e-d1dc-48d7-b430-8cd186823952 "moviasconnect"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/e7bd51b1-f252-4413-80db-578feb8b7c42 "moviasconnect") deployed [moviasconnect](https://github.com/efmiranda/moviasconnect/releases/tag/deploy-ibm-yp-us-south-movias-dev-20170504-132911 "deploy-ibm-yp-us-south-movias-dev-20170504-132911") to [dev](https://console.ng.bluemix.net/apps/1079c952-4422-430f-866a-49923506fc68 "ibm:yp:us-south:movias:dev"), including this commit


и раз вы пишете юниттест, неплохо проверять что не только длина правильная, но и содержимое: есть БОЛЬШИЕ, маленькие символы и цифры.


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/5adff52f-3ab3-4aac-ab51-95f5106e12b4 "empty-toolchain-20170504124328120"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/895527db-8ab4-4526-8e06-661c5bdee50c "New-delivery-pipeline") deployed [Cloned-GitHub-repository-for-custom-toolchain-lab](https://github.com/lakeshopper2/Cloned-GitHub-repository-for-custom-toolchain-lab/releases/tag/deploy-ibm-yp-us-south-T-Impact-IBM-Lab-IBM-Montpellier-space-US-South-20170504-132940 "deploy-ibm-yp-us-south-T-Impact-IBM-Lab-IBM-Montpellier-space-US-South-20170504-132940") to [IBM Montpellier space US South](https://console.ng.bluemix.net/apps/ce4f8dc2-cc95-4e6e-a74b-438376efc69e "ibm:yp:us-south:T-Impact IBM Lab:IBM Montpellier space US South"), including this commit


Vad ska man sakna? Förstår inte riktigt vad det här för commit?


@tsvtkv I mislooked the `useKapt3` check. Then 👌


Puzzle `27-93a42626` disappeared, that's why I closed as #37


Puzzle `37-8087fd76` disappeared, that's why I closed as #49


무엇인지 잘 모르겠지만... 좋아보이네요!


The comment is wrong.


triangle 좋네요. pull request 주세요. :-)


comments don't work in json files


Suggestion: Sort it from the "smallest way of contribution to the biggest".
1. Usually it is the most common case,
2. it is better to check existing issues before creation of own pull request.


emergency 좋아요. pull request 주세요. :-)


Guy's,Please add the code


Sorry to hijack, but just out of curiosity: is this change supposed to make string lowercase? Because it does not, 's' expects single (or multi) byte character string parameter, while 'S' expects wide-char string; 's' will cause only one character from wide-char string to be printed - `szProjectName` is LPCWSTR.


emergency와 youtube 모두 좋아요. pull request 주세요. ;-)


EXIST not EXISTS =)


saving dockets to index is removed here?


Docker image: 496870459963.dkr.ecr.eu-west-1.amazonaws.com/photobox/jenkins-tests:testing_2
Endpoint: http://jenkins-tests-jenkins-testing.k8s-test.photobox.com


TeamCity Chorus :: chorus-linux64-master Continuous [Build 2.6.789.4454b5c977b50368ae674382e36cf9616696657c](http://build.palaso.org/viewLog.html?buildId=89966&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 938, ignored: 57 Build time: 00:13:14


That is because while the fix has been merged it has not yet been deployed.


Yes, netty_udp, netty_tcp, and netperf work. Libc checks for non-blocking with ``read_ready`` rather than ``READ_ERR_WOULD_BLOCK`` but yes, ``READ_QUEUED`` should be returned from ``queue_read`` and not the normal ``read``.


I think I remember seeing `self.i2c.readByte(PiStormsCom.PS_KeyPress)` return 60 and 61 instead of 0 and 1, but I can't replicate that experimentally now. In any case, it is only the least-significant bit that matters, and this is how it's [implemented](https://github.com/seth10/PiStorms/blob/mindsensorsUI-improvements/sys/PiStormsCom.py#L838) in PiStormsCom.


probably worth using a while loop for performance.


I think there is not method in which during creation of the process is created also docket. Docket doesn't keep information about processes which are assigned to it.


githubapptesting comment at 7:07


Did you check if this markup works fine on Outlook 2007/2016 windows and Windows 10 Mail ?
AFAICT links wrapping a table won't work there.


I have started making my own device tree, but I accidentally downloaded Android O. I'm wondering if it will work with N blobs.


You are totally right. I verified it in varnishtest. Fixed in c6f8771.


https://github.com/mono/monodevelop/commit/abfc21e47acce2e808072a439b7802856227c436

Done!

<img width="995" alt="00001223" src="https://cloud.githubusercontent.com/assets/264396/25706153/7eea3318-30d7-11e7-85e3-425803b3514a.png">


Which makes me notice: why are all these `UnitalChunk`s in GamePhysics instead of being somewhere in `Data.Drasil.Quantities` ? @szymczdm


For compatibility w/ linux it can't have `--trace-warnings` there (as it supports only a single argument after interpreter):

```
EXECVE(2)               Linux Programmer's Manual              EXECVE(2)

SYNOPSIS
       #include <unistd.h>

       int execve(const char *filename, char *const argv[],
                  char *const envp[]);

DESCRIPTION
       execve()  executes  the program pointed to by filename.  filename
       must be either a binary executable, or a script starting  with  a
       line of the form:

           #! interpreter [optional-arg]
```

differs from the BSD one:

```

EXECVE(2)                   BSD System Calls Manual                  EXECVE(2)

NAME
     execve -- execute a file

SYNOPSIS
     #include <unistd.h>

     int
     execve(const char *path, char *const argv[], char *const envp[]);
...

     An interpreter file begins with a line of the form:

           #! interpreter [arg ...]

```


ahh good idea. I had the default set to n for upstream


sure, we can see what happens


Should I be concerned with using this in my company's code since there is an active component, DirectShowLib, that has a different license (GNU Lesser General Public License, version 2.1) then the license you have listed for this project?


`print D.runtime.threads.grep { it.name =~ /ActiveMQ.*Task-/ }.size()` should do it.


Should this still be commented out? Maybe it should just be deleted?


yeah


Nothing too fancy I think :) Just a Wordpress website. "src" images get rewritten to a CDN but "srcset" images are skipped. Lazyload is working for both src and srcset images.

The documentation for 1.12.34.1 says:

_This includes all PageSpeed image optimizations except resizing._

So I guess maybe it's working how it should? I was hoping I could rewrite all images to the CDN, a lot of images are skipped now.


Vincent, please do not modify the Robot's orientation in the nativeRobot*() methods. The applyModelRotations() method is the source method for the Robot's position and orientation and is used independent of the nativeRobot*() methods in some cases. So, only changing nativeRobots*() will cause issues with applying the orientation of points to the Robot.

I added a method, which the Robot's current orientation in terms of its default orientation, which should work for your robot camera.


This should not show up in this commit. 2nd, the commit title should not be

    Merge branch 'master' of https://github.com/cerner/jwala into ResourcesHistory

If you need to update your branch with changes in master you should do the following

    git pull --rebase origin master
    git rebase master // you should be in your branch, if there are conflicts resolve it in Intellij


test


真的有必要引入第二个网络库吗


Docker image: 496870459963.dkr.ecr.eu-west-1.amazonaws.com/photobox/jenkins-tests:testing_2
Endpoint: http://jenkins-tests-jenkins-testing.k8s-test.photobox.com


@Leinnan Jak będzie coś wartego na forum to wrzucę.


The question seems to be the function " strtok " I use to get input.


Oh. Yep, my bad.


@red-001 um… cough… Who's ip is this?


Hey @snoyer -- for some reason I got a bunch of simultaneous interest in ICC profiles recently, so I just added basic support for them in master. If you have a chance to clone and try it out, would love some feedback on it!


# bootrap项目


[Your benchmark job](https://github.com/JuliaLang/julia/commit/8619307ca94e5a30f5be0a3aaeabf6f64f5a6e7a#commitcomment-22015180) has completed - possible performance regressions were detected. A full report can be found [here](https://github.com/JuliaCI/BaseBenchmarkReports/blob/fb4fef3c1f1e6033915653b18f2a8fa1984f5fca/8619307_vs_6445c82/report.md). cc @jrevels


You mean the two above, `CONFIG_ZONE_DMA` and `CONFIG_INITRAMFS_ROOT_UID`? That's odd, as they were removed by `make oldconfig` when using the 4.4-xbian config at the time of this PR - are you including any additional patches that require these options? I've just checked `make oldconfig` again, using the current `4.4-xbian/linux.arm.conf` on master, and there are no prompts/changes to the config.


@rolandgeider Added USA first and last names


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/5e04fc2b-048a-4fe3-9cab-6419f1ce9bda "mfe-dev-fe"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/d2e8d9ea-7a90-487a-a9cd-c822cc6d9891 "mfe-dev-fe") deployed [mfe-dev-be](https://github.com/ilantoren/mfe-dev-be/releases/tag/deploy-ibm-yp-us-south-MyFavoreats-myfavoreats-20170504-135727 "deploy-ibm-yp-us-south-MyFavoreats-myfavoreats-20170504-135727") to [myfavoreats](https://console.ng.bluemix.net/apps/4a80c652-9946-4627-8e17-db91b70a3998 "ibm:yp:us-south:MyFavoreats:myfavoreats"), including this commit


See my email - the problem here is the limitby ;) which is unnecessary. Grouping is pointless with a single all-aggregate row, as is limitby.


looking for cause of array growth regression, 39cd805 vs 0.5.1
@nanosoldier `runbenchmarks("array", vs = "@6445c82d0060dbe82b88436f0f4371a4ee64d918")`

might need to put the inline_meta's in here after all


looking for cause of array growth regression, 5fc644a vs 0.5.1
@nanosoldier `runbenchmarks("array", vs = "@6445c82d0060dbe82b88436f0f4371a4ee64d918")`


@robinsuri  githubapptesting mention at 7:30


@mrexodia I wrote a plugin just hooked DbgGetStringAt to contains chinese string, this commit make plugin not work any more. Will disasmgetstringatwrapper be export?
I just make my plugin open source, you can check the implement here [https://github.com/lynnux/x64dbg_tol/blob/master/StrrefPatch.cpp#L489](https://github.com/lynnux/x64dbg_tol/blob/master/StrrefPatch.cpp#L489)


Probably can remove resolution part, if we can determine what our resolution will be


magician 좋아요. pull request 주세요. :-)


Huh, some of these regressions look familiar...


OMFG CUSTOM LIBS!!! I wonder how much time it took you to code that....damn this is next level.


thinks


This file should be added to .gitignore rather than checked in. Data doesn't belong in the repo.


Consigliamo di mettere:
indicatori: aule, esercitazioni, insegnamento lezioni

Dopodiché nel metodo getGiudizio fare un foreach( indicatore in indicatori){...}


primera parte


Hey Brianna,

Krizia and I have been working on further styling of this project (which I had initially messaged you back in January but never received a response) through a forked repo I created in case if you ever wanted to integrate the changes here. Here is the link to the gh-pages site: https://interglobalmedia.github.io/civic-tech-projects/ And here is the repo itself: https://github.com/interglobalmedia/civic-tech-projects


This is my first text in index.html


need a `break` here


i think you need using Notepade++


样式


fixes #20


Vogliamo aggiungere .toLowerCase() ai parametri? O va bene così?


img


need to return a status code here.


Unindent by one space.


TeamCity libpalaso :: palaso-linux64-master Continuous [Build 4.0.101.1168095c4cca95e40e57e4982415341591dfde69](http://build.palaso.org/viewLog.html?buildId=89979&buildTypeId=Libpalaso_PalasoLinux64masterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3703, ignored: 111 Build time: 00:05:05


FIXED: NPE occurred when closing the canvas name setting dialog.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.106.1168095c4cca95e40e57e4982415341591dfde69](http://build.palaso.org/viewLog.html?buildId=89983&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3725, ignored: 128 Build time: 00:05:25


I forget, do we need a `response.end()` here?


nit: this `return` statement isn't doing anything, so probably best to leave it out for clarity.


typo here (`restrict_to_last_comment` vs `restrict_to_last_commit`), which causes the restriction to always be false


@Therzok @slluis i reverted the accidental merge of the branch.

There's at least one exception:
```
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.NullReferenceException: Object reference not set to an instance of an object
  at MonoDevelop.SourceEditor.SourceEditorWidget.Dispose () [0x00039] in /Users/alan/Projects/monodevelop/main/src/addins/MonoDevelop.SourceEditor2/MonoDevelop.SourceEditor/SourceEditorWidget.cs:497
  at MonoDevelop.SourceEditor.SourceEditorView.Dispose () [0x00417] in /Users/alan/Projects/monodevelop/main/src/addins/MonoDevelop.SourceEditor2/MonoDevelop.SourceEditor/SourceEditorView.cs:1075
  at MonoDevelop.Ide.Editor.TextEditor.Dispose (System.Boolean disposing) [0x00082] in /Users/alan/Projects/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Editor/TextEditor.cs:974
  at MonoDevelop.Components.Control.OnGtkDestroyed (System.Object sender, System.EventArgs args) [0x00008] in /Users/alan/Projects/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Components/Control.cs:100 ```
And also the texteditor does not render correctly anymore. It looks like this: https://screencast.com/t/JOOyx3lK


DRY: put the file path constant in a string.


cumulative product


EMS (brianlball) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


Вот тут я вижу непонимания асинхронности и промисов.


`getUsers` always returns `undefined` so this return statement is unnecessary and confusing. best to leave it out.


EMS (brianlball) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


TeamCity libpalaso :: fixing-to-fix-palaso-linux64-masterContinuous [Build 4.0.11.1168095c4cca95e40e57e4982415341591dfde69](http://build.palaso.org/viewLog.html?buildId=89981&buildTypeId=JasonHatesMono) outcome was **FAILURE**
Summary: Exit code 6 Build time: 00:04:50


You have an extra `;` here.


The compiler option `-Wframe-larger-than` which is mentioned there for clang is also supported by gcc. I used it for the report shown above. As far as I remember, MS Visual C++ has a default limit of 1 MB for the frame size.

Ray, if the compile problem occurs with code outside of Tesseract, I suggest to use a pointer variable with new / delete instead of allocating it on the stack. This will still save one new / delete operations (3 before patch, 1 after patch with new / delete, 2 before patch, 0 after patch with variable on stack).


I suggest "edit a preference profile" to be consistent with the two descriptions above.
Also make sure other similar descriptions are updated too.


@robinsuri  githubapptesting mentioned at 7:44


Nice 🎉


## Global

| Changed            |   Status |
|:-------------------|---------:|
| `coverage`         |     2.26 |
| `metadata_passing` |    29    |
| `metadata_total`   |    29    |
| `nodes_count`      |   818    |
| `texts_passing`    |    27    |

## Words

| Changed   |   Status |
|:----------|---------:|
| `UNK`     |    -5640 |
| `grc`     |   +46742 |

## Units

| Changed                                                 | Status   |
|:--------------------------------------------------------|:---------|
| `./data/tlg0540/tlg002/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg002/tlg0540.tlg002.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg002/tlg0540.tlg002.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg003/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg003/tlg0540.tlg003.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg003/tlg0540.tlg003.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg004/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg004/tlg0540.tlg004.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg004/tlg0540.tlg004.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg005/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg005/tlg0540.tlg005.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg005/tlg0540.tlg005.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg006/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg006/tlg0540.tlg006.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg006/tlg0540.tlg006.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg007/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg007/tlg0540.tlg007.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg007/tlg0540.tlg007.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg008/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg008/tlg0540.tlg008.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg008/tlg0540.tlg008.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg009/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg009/tlg0540.tlg009.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg009/tlg0540.tlg009.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg010/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg010/tlg0540.tlg010.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg010/tlg0540.tlg010.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg011/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg011/tlg0540.tlg011.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg011/tlg0540.tlg011.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg012/tlg0540.tlg012.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg012/tlg0540.tlg012.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg013/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg013/tlg0540.tlg013.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg013/tlg0540.tlg013.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg014/tlg0540.tlg014.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg014/tlg0540.tlg014.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg015/tlg0540.tlg015.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg015/tlg0540.tlg015.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg016/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg016/tlg0540.tlg016.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg016/tlg0540.tlg016.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg017/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg017/tlg0540.tlg017.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg017/tlg0540.tlg017.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg018/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg018/tlg0540.tlg018.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg018/tlg0540.tlg018.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg019/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg019/tlg0540.tlg019.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg019/tlg0540.tlg019.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg020/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg020/tlg0540.tlg020.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg020/tlg0540.tlg020.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg021/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg021/tlg0540.tlg021.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg021/tlg0540.tlg021.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg022/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg022/tlg0540.tlg022.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg022/tlg0540.tlg022.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg023/tlg0540.tlg023.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg023/tlg0540.tlg023.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg024/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg024/tlg0540.tlg024.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg024/tlg0540.tlg024.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg025/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg025/tlg0540.tlg025.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg025/tlg0540.tlg025.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg026/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg026/tlg0540.tlg026.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg026/tlg0540.tlg026.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg027/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg027/tlg0540.tlg027.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg027/tlg0540.tlg027.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg028/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg028/tlg0540.tlg028.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg028/tlg0540.tlg028.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg029/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg029/tlg0540.tlg029.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg029/tlg0540.tlg029.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg030/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg030/tlg0540.tlg030.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg030/tlg0540.tlg030.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg031/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg032/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg033/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg034/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg002/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg002/tlg0540.tlg002.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg003/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg003/tlg0540.tlg003.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg004/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg004/tlg0540.tlg004.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg005/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg005/tlg0540.tlg005.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg006/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg006/tlg0540.tlg006.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg007/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg007/tlg0540.tlg007.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg008/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg008/tlg0540.tlg008.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg009/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg009/tlg0540.tlg009.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg010/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg010/tlg0540.tlg010.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg011/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg011/tlg0540.tlg011.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg012/tlg0540.tlg012.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg013/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg013/tlg0540.tlg013.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg014/tlg0540.tlg014.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg015/tlg0540.tlg015.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg016/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg016/tlg0540.tlg016.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg017/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg017/tlg0540.tlg017.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg018/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg018/tlg0540.tlg018.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg019/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg019/tlg0540.tlg019.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg020/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg020/tlg0540.tlg020.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg021/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg021/tlg0540.tlg021.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg022/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg022/tlg0540.tlg022.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg023/tlg0540.tlg023.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg024/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg024/tlg0540.tlg024.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg025/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg025/tlg0540.tlg025.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg026/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg026/tlg0540.tlg026.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg027/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg027/tlg0540.tlg027.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg028/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg028/tlg0540.tlg028.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg029/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg029/tlg0540.tlg029.perseus-grc2.xml` | Failing  |
| `./data/tlg0540/tlg030/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg030/tlg0540.tlg030.perseus-grc2.xml` | Failing  |
| `./data/tlg0540/tlg031/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg032/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg033/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg034/__cts__.xml`                     | Passing  |

*[Hook UI build recap](http://ci.perseids.org/repo/PerseusDL/canonical-greekLit/288)*


why this Exception?


looks good, maybe we can pull that one in at an earlier stage then, webgui plugin looks good to me.


EMS (brianlball) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


Why specifacally those items? What if you need others?
You need to parametrize this method, and find checkboxes based on title


if you need counter, use for loop - that's what it for:
`
for(int i = 0; i < attempts; i++)
`


Wouldn't they get the message twice then?


@d3v1c3nv11 , please explain why we need to export USB1_DRV and DEBUGEN GPIO using sysfs ?
There is no point doing that, so i think that you need to remove this part of code.
USB1_DRV GPIO can be changed in DTS.
Please RTFM


What do you mean by troubles of flag usage?


Atom 1.17 (in beta right now) revamps the way panes work, which means the package was broken for beta users. The fix involved using a new Atom API, which means I have to target my package for 1.17+ now.


why did we decide to use `var` here instead of `const`?


Ins't specifying requiredFromConsole false redundant?


is this a symlink?


I see, thanks for the clarification 👍


(here and below)
You can use static method `TimeSpan.FromSeconds(10)` - that's much more readable


Preview does not work for the A6000 for me.
Also confirmed here: https://github.com/gphoto/libgphoto2/issues/93#issuecomment-279762662


@aminalhazwani I do not agree with this change to the structure. Please revert.
I expect people want to find info on a font for a specific platform and probably not knowing the font name. So I would rather have that table be sorted by platform then by Typeface.
In addition, this sorting gives Linux platforms more visibility than matches their usefulness.
(and link to Roboto is broken)
Please feel free to ask me about my intentions when you see something you would have done differently and we'll resolve together.


We usually do `this.addAliases`


Docker image: 496870459963.dkr.ecr.eu-west-1.amazonaws.com/photobox/jenkins-tests:testing_2
Endpoint: http://jenkins-tests-jenkins-testing.k8s-test.photobox.com


Here you specify the default as null again?


it should be, doesn't git support that?


I also agree, but for macOS 10.10.


Missing dot


Stefan, did you followed my 2 links above?


it looks odd in github, but it should work. however the +TARGETS says php.etc.ini and php.lib.ini, but the files are php.etc.ini and php.ini ?


appended rather than inserted


I do not believe that this library will compile with Arduino M0.  It appears that there is a datatype problem.  Please look into this and since I edited a keywords and library.properties files file I may have made a mistake to cause the last error below.  Thanks.

C:\Program Files (x86)\Arduino\portable\packages\arduino\hardware\samd\1.6.15\libraries\SoftwareSerial\SoftwareSerial.cpp: In member function 'void SoftwareSerial::setRX(uint8_t)':

C:\Program Files (x86)\Arduino\portable\packages\arduino\hardware\samd\1.6.15\libraries\SoftwareSerial\SoftwareSerial.cpp:186:24: error: cannot convert 'volatile uint32_t* {aka volatile long unsigned int*}' to 'volatile PORT_IN_Type*' in assignment

   _receivePortRegister = portInputRegister(port);

                        ^

C:\Program Files (x86)\Arduino\portable\packages\arduino\hardware\samd\1.6.15\libraries\SoftwareSerial\SoftwareSerial.cpp: At global scope:

C:\Program Files (x86)\Arduino\portable\packages\arduino\hardware\samd\1.6.15\libraries\SoftwareSerial\SoftwareSerial.cpp:79:6: warning: always_inline function might not be inlinable [-Wattributes]

 void SoftwareSerial::recv()

[keywords.txt](https://github.com/arduino-org/Arduino/files/976423/keywords.txt)


Hi @r-type , can you try upgrading to MAME 0.185?


and they point to the same target file:

    php.etc.ini:/usr/local/etc/php.ini
    php.lib.ini:/usr/local/etc/php.ini


can


EMS (brianlball) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


Also I am wondering if it would make sense to get a visual instead of a name? Possibly even an Mson if we decide to use that later?
This might be overkill, or it could make future additions of Mson easier.
Could a preference profile have an Mson representation?


Using SetUp method you'll have browser restarted after each scenario. You don't need that. Use [OneTimeSetUp] and [OneTimeTearDown]


sospecho que no era necesario cambiar la clase css del botón.
Esto no garantiza que vaya a alinearse a la derecha.

Te recomendaría usar sm-col-NN para ubicar los elementos del formulario (habla con @j1m1 o @carlosaj98 a los que les he estado explicando cómo funciona)


seen


Why async though? Is it slow?


this is funny, can't we use the same template for both targets? :)


@bmuenzenmeyer Do you want it against the `dev-v3` branch or `dev`?


Now they will see nothing if they have no profile? Couldn't this also be used for testing the default?


![](https://github.trello.services/images/mini-trello-icon.png) [Help dialogue does not show in skype](https://trello.com/c/ytYwgbHN/65-help-dialogue-does-not-show-in-skype)


@Nicola1971
For What this ?
Once it was corrected
Https://github.com/modxcms/evolution/pull/767


theoretically this should also get the Type right?


This is a comment on commit


How to import other file formats? I work with Nikon STORM files


TeamCity libpalaso :: palaso-linux64-master Continuous [Build 4.0.102.1168095c4cca95e40e57e4982415341591dfde69](http://build.palaso.org/viewLog.html?buildId=89987&buildTypeId=Libpalaso_PalasoLinux64masterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3703, ignored: 111 Build time: 00:04:35


d


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/588f383c-31f4-41ff-a07a-b28b3f931c80 "WestFieldServlet"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/c12fb70d-7bd5-49b2-a05b-1c8339e6d87d "WestFieldServlet") deployed [westfield](https://github.com/ksleima/westfield/releases/tag/deploy-ibm-yp-us-south-POT_Org-WestField-20170504-142904 "deploy-ibm-yp-us-south-POT_Org-WestField-20170504-142904") to [WestField](https://console.ng.bluemix.net/apps/e24bfad3-2ee1-4f43-8f66-6892de442d14 "ibm:yp:us-south:POT_Org:WestField"), including this commit


Shouldn't this depend on getPreferenceProfileUsed if it has caching features?


Modulo 256 is the same as masking off all but the last 8 bits. Although replacing the int ('c') with an unsigned char instead of an unsigned int would make this unnecessary, it'd blow up when using the stringstream, because std::ostream derived classes behave differently to chars than integers.

Here's a demo http://cpp.sh/6ubuc

Test 1 shows the problem we had (excessive FFs being put in to the serial key)
Test 2 shows the new behaviour
Test 3 (commented out) will cause the cpp.sh to have a bad time if you uncomment it, and if run locally will simply ignore your request for hexidecimal and output raw bytes


@dhimmel Just noticed this commit.  Cool!  Thanks for contacting them.


I really really doubt it should be marked as changed when loading.


![](https://github.trello.services/images/mini-trello-icon.png) [Task to set calendar's language](https://trello.com/c/hdF0pE3M/11-task-to-set-calendar-s-language)


Correct, the A6000 does not support preview.  Refer to this list for preview support: https://www.phaseone.com/en/Products/Software/Capture-One-for-Sony/Supported-Cameras.aspx


commit


If you're doing a lot of these and the variable is not going to be used outside of the scope of the `if`, you could

```cpp
if (auto red_onion = game.RetrieveOnion(game.Spawn("Onion:Red"))) { red_onion->set_position(Vec3{64_f, 0_f, -32_f}); }
```
This keeps the scope of `red_onion` very narrow.


@robinsuri - check it


@dillaman for CoR and all zero parent data, `CopyupRequest::is_copyup_required` which called by `CopyupRequest::should_complete` in state `STATE_READ_FROM_PARENT` (https://github.com/ceph/ceph/blob/master/src/librbd/io/CopyupRequest.cc#L234) should return true, so we should never reach here ?  thanks!


HackeZ，我刚到家，我拉了下代码。
我看到已经分模块了，很赞。
我有两个提示：
1. isFriend 模块是模拟了 99.9% 返回好友，0.1% 返回非好友，也就是说，这里表达的实际上是100%的成功返回，即，都是有返回给 sendMsg 的。。那么，网络请求的 噩梦就是 timeout ，即，sendMsg这里超时，而 isFriend 因为too busy没在规定时间内返回，或者宕机不返回。。这才是 99.9% 成功的正确理解。。
2. 那么 sendMsg 发的go routine 是否可以支持 设置超时，试想，如果go routine 是阻塞耗时的，那么会不会有大量的go routine ? 这个量始终是有限的，不可能让你无限 go routine。。


EMS (brianlball) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png)


no, we can't, the source is used in a dictionary, thus unique.
Normally I would add a symlink from /usr/local/etc/php.ini to /usr/local/lib/php.ini for being a copy, but since both where copies I thought it was better to add both.


test comment


@sebas932 @cgarcia9106 Livestock está mal escrito.


This doesn't look right. setName should simply be a setter right? Then it shouldn't enforce a lock.
I assume setName should never be called when it is locked, so should you rather throw an exception to find the rogue code that is trying to break the rule?


Fixed the typo in +TARGETS (php.lib.ini:/usr/local/etc/php.ini)


you should have separate files for different classes


abc


TeamCity libpalaso :: fixing-to-fix-palaso-linux64-masterContinuous [Build 4.0.12.1168095c4cca95e40e57e4982415341591dfde69](http://build.palaso.org/viewLog.html?buildId=89989&buildTypeId=JasonHatesMono) outcome was **FAILURE**
Summary: Exit code 6 Build time: 00:04:40


Is defensive copying required? Should you perhaps rather do `Collections.unmodifiableList` which is cheaper?


Same as above


Only look at line 1-17. The following variables require the SEM's attention. 1-6 should be self explanatory. Add text that is in all campaigns you want looked at (do not use dashes; that will cause errors. underscores will work though. in highConvMaxCplDsk, highConvMaxCplMob, and highConvMaxCplTab enter the highest cpl you would be willing to pay for consistent conversions for each device type. The script is designed to be run once daily using micro bid changes looking at if-then cpl's in a series of time ranges. Over time, it should achieve an equilibrium, especially in concert with other bidding scripts. 'usePreviousDayData' evaluates if the performance from the day before warranted changes. It requires the CPL be much higher or much lower than the other time frames and is partially in place in case a particular day has a large swing that may need a correction. 'useAllTimeData' is not used for bidding. It is used to avoid the script over-correcting against the historical performance. For example, this portion reduces the bid change if the devices with a long term good cpl have short term negative swings, and bid increases are reduced on devices with great performance short term and bad performance long term. This is the only purpose of the date at the bottom. The format must remain as listed. If an account has had a lot of rebuilding or there were major conversion issues, it is best to set the date some time after that time period so that it is using timely data. 'useVariedDays' uses as an algorithm to determine whether it should apply each bid change. Stronger performance anomalies are weighted more heavily by recent changes. This helps avoid over-correcting and helps reach the equilibrium and stay within that range. The last variable is 'clearAdGroups'. Since the script bids only at the campaign level, and ad group level device bid modifiers take priority over campaign level, this setting looks for ad groups with device modifiers and clears them. The script will not perform at the optimal level otherwise. All calculations are factored to avoid bidding twice on identical data in the same time period. To explain further, a brand new campaign with 6 days of data would fall within the 7 days, 14 days, and 30 days. It is only once there is data from 15 days that the 14 days kicks in, and it is only after 31 days of data that the 30 days kicks in. Also devices without an impression from the day before are not evaluated either as they were assumed to be turned off. Last note. Any of the variables can be turned off by changing the value to false. If the SEM wants to run the script weekly instead of daily, it is best to turn off 'useVariedDays' and 'usePreviousDayData', but that is the only difference.

var campContains1 = 'EnterPortionOfCampaignName';
var campContains2 = 'EnterPortionOfCampaignName';
var campContains3 = 'EnterPortionOfCampaignName';
var campDoesNotContain1 = 'Placeholder';
var campDoesNotContain2 = 'Placeholder';
var campDoesNotContain3 = 'Placeholder';

var highConvMaxCplDsk = 165;
var highConvMaxCplMob = 165;
var highConvMaxCplTab = 165;
var usePreviousDayData = true;
var useAllTimeData = true;
var useVariedDays = true;
var clearAdGroups = true;

var start=new Date("January 01, 2017 00:00:00");


And again. I think you get the idea now 😄


[R/RLearner_classif_rknn.R:25:37:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/R/RLearner_classif_rknn.R#L25) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  c(list(data = z$data, y = z$target ), list(...))
                                    ^
```
[R/RLearner_regr_GPfit.R:42:116:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/R/RLearner_regr_GPfit.R#L42) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  res = GPfit::GP_fit(d$data[, not.const], d$target, corr = list(type = type, power = power, nu = matern_nu_k + 0.5 ), ...)
                                                                                ^
```
[R/RLearner_regr_glm.R:59:69:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/R/RLearner_regr_glm.R#L59) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
    m = stats::glm(f, data = d, control = ctrl, family = family, ... )
                                                                    ^
```
[R/RLearner_regr_glm.R:61:89:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/R/RLearner_regr_glm.R#L61) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
    m = stats::glm(f, data = d, control = ctrl, weights = .weights, family = family, ... )
                                                                                ^
```
[R/RLearner_regr_randomForest.R:149:44:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/R/RLearner_regr_randomForest.R#L149) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  bist = ((1 / se.ntree) - (1 / ntree)) / ( se.boot * se.ntree * (se.ntree - 1)) * bias
                                           ^
```
[R/RLearner_regr_rknn.R:25:37:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/R/RLearner_regr_rknn.R#L25) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  c(list(data = z$data, y = z$target ), list(...))
                                    ^
```
[R/StackedLearner.R:556:50:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/R/StackedLearner.R#L556) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
      m = makeLearner("regr.nnet", predict.type = )
                                                 ^
```
[R/StackedLearner.R:678:25:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/R/StackedLearner.R#L678) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
    neighbour = max.col( -dist.mat - diag(Inf, n))
                        ^
```
[R/selectFeaturesRandom.R:15:30:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/R/selectFeaturesRandom.R#L15) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
    return(rbinom(n, 1, prob) )
                             ^
```
[tests/testthat/test_base_learnerArgsToControl.R:15:22:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/tests/testthat/test_base_learnerArgsToControl.R#L15) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  arg1 = quote(expr = )
                     ^
```
[tests/testthat/test_base_learnerArgsToControl.R:16:22:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/tests/testthat/test_base_learnerArgsToControl.R#L16) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  arg2 = quote(expr = )
                     ^
```
[tests/testthat/test_base_learnerArgsToControl.R:41:24:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/tests/testthat/test_base_learnerArgsToControl.R#L41) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  devmax = quote(expr = )
                       ^
```
[tests/testthat/test_base_measures.R:448:58:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/tests/testthat/test_base_measures.R#L448) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  qsr.test = 1 - mean(rowSums((pred.probs - model.matrix( ~ . + 0, data = as.data.frame(tar.classif)))^2))
                                                         ^
```
[tests/testthat/test_base_tuning.R:25:46:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/tests/testthat/test_base_tuning.R#L25) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
    j = which(pp$cp == cp & pp$minsplit == ms )
                                             ^
```
[tests/testthat/test_classif_logreg.R:22:98:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/tests/testthat/test_classif_logreg.R#L22) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  testCV("classif.logreg", binaryclass.df, binaryclass.target, tune.train = tt, tune.predict = tp )
                                                                                ^
```
[tests/testthat/test_classif_multinom.R:21:98:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/tests/testthat/test_classif_multinom.R#L21) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  testCV("classif.multinom", multiclass.df, multiclass.target, tune.train = tt, tune.predict = tp )
                                                                                ^
```
[tests/testthat/test_classif_naiveBayes.R:16:100:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/tests/testthat/test_classif_naiveBayes.R#L16) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  testCV("classif.naiveBayes", multiclass.df, multiclass.target, tune.train = tt, tune.predict = tp )
                                                                                ^
```
[tests/testthat/test_classif_probit.R:19:98:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/tests/testthat/test_classif_probit.R#L19) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  testCV("classif.probit", binaryclass.df, binaryclass.target, tune.train = tt, tune.predict = tp )
                                                                                ^
```
[tests/testthat/test_classif_qda.R:18:93:](https://github.com/mlr-org/mlr/blob/b3f31ae1856b8d83fa526186ab34ff148e03e194/tests/testthat/test_classif_qda.R#L18) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  testCV("classif.qda", multiclass.df, multiclass.target, tune.train = tt, tune.predict = tp )
                                                                                ^
```


I didn't pay attention to this particular change and merged it after brief runtime test

fixed in 32ad0f0b865904675e644eca2899e13751c10698. I've kept the DEBUGEN change. do we really need it?

@hehopmajieh please update devicetree.


It's an `Entry` that we're not storing anywhere, just so that we can call `.addSetters` once. There might be a better way to do it, especially if this is a common case (e.g. if a lot of CJS modules set `module.exports` to something other than an object).


TeamCity OTA+ :: rvi_sota_server :: ci [Build 2472](http://teamcity.prod01.internal.advancedtelematic.com:8111/viewLog.html?buildId=30886&buildTypeId=ota_plus_RviSotaServer_Ci) is now running


The line below is really smart, this line is simply now required.


Really excited about removing this requirement!


@mmistakes Success! And you where right. The problem was is in the post name indeed, but I also had posts that on top of that, didn't have ```title:``` in their front matter.

While one works without the other, nothing works when there is no ```title:``` tag and no title in the post's file name.  This is Jekyll basics, but nice to know.