[R/children_alt.R:18:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/children_alt.R#L18) *style:* **Variable or function name should be snake_case.**
```r
icd_children_defined_r.icd10cm <- function(x, short_code = icd_guess_short(x), warn = FALSE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/children.R:55:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/children.R#L55) *style:* **Variable or function name should be snake_case.**
```r
icd_children.character <- function(x, ...) {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/children.R:67:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/children.R#L67) *style:* **Variable or function name should be snake_case.**
```r
icd_children.icd9 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~
```
[R/children.R:92:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/children.R#L92) *style:* **Variable or function name should be snake_case.**
```r
icd_children.icd10 <- function(x, short_code = icd_guess_short(x), defined, billable = FALSE, ...) {
^~~~~~~~~~~~~~~~~~
```
[R/children.R:99:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/children.R#L99) *style:* **Variable or function name should be snake_case.**
```r
icd_children.icd10cm <- function(x, short_code = icd_guess_short(x), defined, billable = FALSE, ...) {
^~~~~~~~~~~~~~~~~~~~
```
[R/children.R:139:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/children.R#L139) *style:* **Variable or function name should be snake_case.**
```r
icd_children_defined.icd10cm <- function(x, short_code = icd_guess_short(x), warn = FALSE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/comorbid_alt.R:43:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/comorbid_alt.R#L43) *style:* **Variable and function names should not be longer than 36 characters.**
```r
icd10_comorbid_parent_search_all_at_once <- function(x,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/comorbid.R:40:28:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/comorbid.R#L40) *style:* **Variable or function name should be snake_case.**
```r
"%i9in%" <- function(icd9, icd9Reference) {
                           ^~~~~~~~~~~~~
```
[R/condense.R:36:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/condense.R#L36) *style:* **Variable or function name should be snake_case.**
```r
icd_condense.icd9 <- function(x, short_code = icd_guess_short(x), defined = NULL, warn = TRUE, ...) {
^~~~~~~~~~~~~~~~~
```
[R/condense.R:51:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/condense.R#L51) *style:* **Variable or function name should be snake_case.**
```r
icd_condense.character <- function(x, short_code = icd_guess_short(x), defined = NULL, ...) {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/condense.R:82:3:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/condense.R#L82) *style:* **Variable or function name should be snake_case.**
```r
  icd9Levels <- levels(x) # NULL if not a factor
  ^~~~~~~~~~
```
[R/convert.R:293:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/convert.R#L293) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_decimal.default <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:306:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/convert.R#L306) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_decimal.icd9 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:314:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/convert.R#L314) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_decimal.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:327:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/convert.R#L327) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_decimal.icd10cm <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:345:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/convert.R#L345) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_short.icd9 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:355:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/convert.R#L355) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_short.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:365:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/convert.R#L365) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_short.icd10cm <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:373:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/convert.R#L373) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_short.default <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:399:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/convert.R#L399) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_parts.icd9 <- function(x, mnr_empty = "") {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:408:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/convert.R#L408) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_parts.icd9 <- function(x, mnr_empty = "") {
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:416:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/convert.R#L416) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_parts.character <- function(x, mnr_empty = "") {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:431:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/convert.R#L431) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_parts.character <- function(x, mnr_empty = "") {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/diff_comorbid.R:59:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/diff_comorbid.R#L59) *style:* **Variable or function name should be snake_case.**
```r
icd_diff_comorbid.list <- function(x, y, all_names = NULL, x_names = NULL,
^~~~~~~~~~~~~~~~~~~~~~
```
[R/diff_comorbid.R:78:3:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/diff_comorbid.R#L78) *style:* **Variable or function name should be snake_case.**
```r
  common.names <- intersect(x_names, y_names)
  ^~~~~~~~~~~~
```
[R/diff_comorbid.R:80:3:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/diff_comorbid.R#L80) *style:* **Variable or function name should be snake_case.**
```r
  x.title <- deparse(substitute(x))
  ^~~~~~~
```
[R/diff_comorbid.R:81:3:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/diff_comorbid.R#L81) *style:* **Variable or function name should be snake_case.**
```r
  y.title <- deparse(substitute(y))
  ^~~~~~~
```
[R/diff_comorbid.R:87:5:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/diff_comorbid.R#L87) *style:* **Variable or function name should be snake_case.**
```r
    only.x <- setdiff(x[[n]], y[[n]])
    ^~~~~~
```
[R/diff_comorbid.R:88:5:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/diff_comorbid.R#L88) *style:* **Variable or function name should be snake_case.**
```r
    only.y <- setdiff(y[[n]], x[[n]])
    ^~~~~~
```
[R/explain-table.R:54:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/explain-table.R#L54) *style:* **Variable or function name should be snake_case.**
```r
icd_explain_table.default <- function(x, short_code = icd_guess_short(x), condense = FALSE,
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/explain-table.R:69:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/explain-table.R#L69) *style:* **Variable or function name should be snake_case.**
```r
icd_explain_table.icd9 <- function(...) {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/explain-table.R:76:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/explain-table.R#L76) *style:* **Variable or function name should be snake_case.**
```r
icd_explain_table.icd10 <- function(...) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/explain-table.R:127:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/explain-table.R#L127) *style:* **Variable or function name should be snake_case.**
```r
icd_explain_table.icd9cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/explain-table.R:138:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/explain-table.R#L138) *style:* **Variable or function name should be snake_case.**
```r
icd_explain_table.icd10cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/explain.R:62:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/explain.R#L62) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.default <- function(x, short_code = icd_guess_short(x), condense = TRUE, brief = FALSE, warn = TRUE, ...) {
^~~~~~~~~~~~~~~~~~~
```
[R/explain.R:74:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/explain.R#L74) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.list <- function(x, ...) {
^~~~~~~~~~~~~~~~
```
[R/explain.R:81:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/explain.R#L81) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.icd9 <- function(...) {
^~~~~~~~~~~~~~~~
```
[R/explain.R:88:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/explain.R#L88) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.icd9cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~
```
[R/explain.R:123:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/explain.R#L123) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.icd10cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~
```
[R/explain.R:146:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/explain.R#L146) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.icd10 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~
```
[R/generate_mappings.R:311:18:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/generate_mappings.R#L311) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    c(kids, x) %>% unique %>% icd_sort.icd10
               ~~^
```
[R/generate_mappings.R:391:14:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/generate_mappings.R#L391) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
      c(x) %>% unique %>% icd_sort.icd10
           ~~^
```
[R/generate_sysdata.R:125:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/generate_sysdata.R#L125) *style:* **Variable or function name should be snake_case.**
```r
icd9_generate_all_ <- function(major_fun, short_code = TRUE,
^~~~~~~~~~~~~~~~~~
```
[R/generate_sysdata.R:191:17:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/generate_sysdata.R#L191) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
    rtf_url = c( # FY11,12,13,14 are the same?
                ^
```
[R/guess.R:40:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/guess.R#L40) *style:* **Variable or function name should be snake_case.**
```r
icd_guess_version.icd9 <- function(x, short_code, ...) "icd9" #nocov
^~~~~~~~~~~~~~~~~~~~~~
```
[R/guess.R:45:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/guess.R#L45) *style:* **Variable or function name should be snake_case.**
```r
icd_guess_version.icd10 <- function(x, short_code, ...) "icd10" #nocov
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/guess.R:50:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/guess.R#L50) *style:* **Variable or function name should be snake_case.**
```r
icd_guess_version.factor <- function(x, short_code = NULL, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/guess.R:57:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/guess.R#L57) *style:* **Variable or function name should be snake_case.**
```r
icd_guess_version.character <- function(x, short_code = NULL, n = 10, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/guess.R:100:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/guess.R#L100) *style:* **Variable or function name should be snake_case.**
```r
icd_guess_version.data.frame <- function(x, short_code = NULL, icd_name = get_icd_name(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/parse-comorbid.R:85:11:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-comorbid.R#L85) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    out %>% unlist %>% unique %>% as.icd9 %>% as.icd_short_diag -> icd9_map_ahrq[[cmb]]
        ~~^
```
[R/parse-comorbid.R:85:22:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-comorbid.R#L85) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    out %>% unlist %>% unique %>% as.icd9 %>% as.icd_short_diag -> icd9_map_ahrq[[cmb]]
                   ~~^
```
[R/parse-comorbid.R:85:33:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-comorbid.R#L85) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    out %>% unlist %>% unique %>% as.icd9 %>% as.icd_short_diag -> icd9_map_ahrq[[cmb]]
                              ~~^
```
[R/parse-comorbid.R:146:30:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-comorbid.R#L146) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  icd10_map_ahrq[ahrq_htn] %>% unlist %>% unname -> icd10_map_ahrq[["HTNCX"]]
                           ~~^
```
[R/parse-comorbid.R:147:30:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-comorbid.R#L147) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  icd10_map_ahrq[ahrq_chf] %>% unlist %>% unname -> icd10_map_ahrq[["CHF"]]
                           ~~^
```
[R/parse-comorbid.R:148:32:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-comorbid.R#L148) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  icd10_map_ahrq[ahrq_renal] %>% unlist %>% unname -> icd10_map_ahrq[["RENLFAIL"]]
                             ~~^
```
[R/parse-comorbid.R:212:47:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-comorbid.R#L212) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  icd9_map_quan_deyo %<>% as.icd_short_diag %>% icd9 %>% icd_comorbidity_map
                                            ~~^
```
[R/parse-icd10cm-xml.R:39:7:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-icd10cm-xml.R#L39) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  j %>% xml2::xml_children() %>%
    ~~^
```
[R/parse-icd10cm-xml.R:43:7:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-icd10cm-xml.R#L43) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  j %>% xml2::xml_children() %>% magrittr::extract(chapter_indices) -> chaps
    ~~^
```
[R/parse-icd10cm-xml.R:48:14:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-icd10cm-xml.R#L48) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    c_kids %>% xml2::xml_name() %>% magrittr::equals("section") -> subchap_indices
           ~~^
```
[R/parse-rtf.R:81:21:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-rtf.R#L81) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
      code  = out %>% unname %>% icd_decimal_to_short.icd9 %>% icd9cm,
                  ~~^
```
[R/parse-rtf.R:81:32:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-rtf.R#L81) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
      code  = out %>% unname %>% icd_decimal_to_short.icd9 %>% icd9cm,
                             ~~^
```
[R/parse-rtf.R:229:3:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-rtf.R#L229) *style:* **Variable or function name should be snake_case.**
```r
  useBytes <- list(...)[["useBytes"]]
  ^~~~~~~~
```
[R/parse-rtf.R:414:3:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-rtf.R#L414) *style:* **Variable or function name should be snake_case.**
```r
  re_fifth_range_V30V39 <- "The following two fifths-digits are for use with the fourth-digit \\.0"
  ^~~~~~~~~~~~~~~~~~~~~
```
[R/parse-rtf.R:415:3:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-rtf.R#L415) *style:* **Variable or function name should be snake_case.**
```r
  re_V30V39_fifth <- "V3[[:digit:]]\\.0[01]$"
  ^~~~~~~~~~~~~~~
```
[R/parse-rtf.R:417:3:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-rtf.R#L417) *style:* **Variable or function name should be snake_case.**
```r
  lines_V30V39 <- grep(re_fifth_range_V30V39, filtered)
  ^~~~~~~~~~~~
```
[R/parse-rtf.R:421:60:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-rtf.R#L421) *style:* **Variable or function name should be snake_case.**
```r
    str_pair_match("([[:digit:]])[[:space:]](.*)", ...) -> suffices_V30V39
                                                           ^~~~~~~~~~~~~~~
```
[R/parse-rtf.R:610:11:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-rtf.R#L610) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
      v %>%  strsplit("-", fixed = TRUE) %>% unlist -> pair
        ~~^
```
[R/parse-rtf.R:640:10:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-rtf.R#L640) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  qual %>% strip %>%
       ~~^
```
[R/parse-rtf.R:647:26:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse-rtf.R#L647) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
      strsplit(v, "-") %>% unlist %>% as.integer -> pair
                       ~~^
```
[R/parse.R:285:61:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse.R#L285) *style:* **Variable or function name should be snake_case.**
```r
                                               perl = TRUE, useBytes = TRUE) {
                                                            ^~~~~~~~
```
[R/parse.R:348:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/parse.R#L348) *style:* **Variable or function name should be snake_case.**
```r
fixSubchapterNa <- function(x, start, end) {
^~~~~~~~~~~~~~~
```
[R/ranges.R:70:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/ranges.R#L70) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range.character <- function(start, end, short_code = NULL, defined = TRUE, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:95:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/ranges.R#L95) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range.icd10cm <- function(start, end, short_code = icd_guess_short(c(start, end)),
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:143:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/ranges.R#L143) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range_major.default <- function(start, end) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:153:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/ranges.R#L153) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range_major.icd10cm <- function(start, end) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:160:42:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/ranges.R#L160) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  se <- as_char_no_warn(c(start, end)) %>% trim %>% toupper
                                       ~~^
```
[R/ranges.R:177:36:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/ranges.R#L177) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  unique_mjrs[pos[[1]]:pos[[2]]] %>% as_char_no_warn() %>% as.icd10cm
                                 ~~^
```
[R/ranges.R:182:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/ranges.R#L182) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range.icd9 <- function(start, end,
^~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:336:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/ranges.R#L336) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range_major.icd9 <- function(start, end, defined = TRUE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:426:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/ranges.R#L426) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_minor.icd9 <- function(mnr, is_e = FALSE) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:431:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/ranges.R#L431) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_minor.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:42:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L42) *style:* **Variable or function name should be snake_case.**
```r
icd_is_defined.icd9 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~
```
[R/real.R:62:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L62) *style:* **Variable or function name should be snake_case.**
```r
icd_is_defined.icd10cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:78:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L78) *style:* **Variable or function name should be snake_case.**
```r
icd_is_defined.icd10 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~
```
[R/real.R:88:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L88) *style:* **Variable or function name should be snake_case.**
```r
icd_is_defined.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:111:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L111) *style:* **Variable or function name should be snake_case.**
```r
icd_get_defined.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:120:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L120) *style:* **Variable or function name should be snake_case.**
```r
icd_get_defined.icd9 <- function(x, short_code = icd_guess_short(x), billable = FALSE) {
^~~~~~~~~~~~~~~~~~~~
```
[R/real.R:146:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L146) *style:* **Variable or function name should be snake_case.**
```r
icd_is_billable.icd9 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~
```
[R/real.R:157:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L157) *style:* **Variable or function name should be snake_case.**
```r
icd_is_billable.icd10cm <- function(x, short_code = icd_guess_short(x), icd10cm_edition = "2016", ...) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:170:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L170) *style:* **Variable or function name should be snake_case.**
```r
icd_is_billable.icd10 <- function(x, short_code = icd_guess_short(x), icd10cm_edition = "2016", ...) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:179:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L179) *style:* **Variable or function name should be snake_case.**
```r
icd_is_billable.icd9cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:193:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L193) *style:* **Variable or function name should be snake_case.**
```r
icd_is_billable.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:220:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L220) *style:* **Variable or function name should be snake_case.**
```r
icd_get_billable.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:232:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L232) *style:* **Variable or function name should be snake_case.**
```r
icd_get_billable.icd9cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:245:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L245) *style:* **Variable or function name should be snake_case.**
```r
icd_get_billable.icd9 <- function(...) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:275:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L275) *style:* **Variable or function name should be snake_case.**
```r
icd_get_billable.icd10cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:288:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/real.R#L288) *style:* **Variable or function name should be snake_case.**
```r
icd_get_billable.icd10 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~
```
[R/score.R:76:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/score.R#L76) *style:* **Variable or function name should be snake_case.**
```r
icd_charlson.data.frame <- function(x, visit_name = NULL,
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/score.R:302:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/score.R#L302) *style:* **Variable or function name should be snake_case.**
```r
icd_van_walraven.data.frame <- function(x, visit_name = NULL, return_df = FALSE,
^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sort.R:39:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/sort.R#L39) *style:* **Variable or function name should be snake_case.**
```r
icd_sort.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~
```
[R/sort.R:52:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/sort.R#L52) *style:* **Variable or function name should be snake_case.**
```r
icd_sort.icd10 <- function(x, short_code = NULL, ...) {
^~~~~~~~~~~~~~
```
[R/sort.R:61:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/sort.R#L61) *style:* **Variable or function name should be snake_case.**
```r
icd_sort.icd9 <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~
```
[R/util.R:192:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/util.R#L192) *style:* **Variable or function name should be snake_case.**
```r
get_visit_name.data.frame <- function(x, visit_name = NULL) {
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/util.R:212:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/util.R#L212) *style:* **Variable or function name should be snake_case.**
```r
get_visit_name.matrix <- function(x, visit_name = NULL) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/util.R:281:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/util.R#L281) *style:* **Variable or function name should be snake_case.**
```r
get_non_ASCII <- function(x)
^~~~~~~~~~~~~
```
[R/util.R:286:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/util.R#L286) *style:* **Variable or function name should be snake_case.**
```r
is_non_ASCII <- function(x)
^~~~~~~~~~~~
```
[R/util.R:328:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/util.R#L328) *style:* **Variable or function name should be snake_case.**
```r
chapter_to_desc_range.icd9 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/util.R:334:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/util.R#L334) *style:* **Variable or function name should be snake_case.**
```r
chapter_to_desc_range.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:245:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L245) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:257:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L257) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid.icd10 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~
```
[R/valid.R:274:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L274) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid.icd9 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~
```
[R/valid.R:331:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L331) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid_major.default <- function(x, whitespace_ok = TRUE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:339:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L339) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid_major.icd9 <- function(x, whitespace_ok = TRUE) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:346:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L346) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid_major.icd10 <- function(x, whitespace_ok = TRUE) {
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:370:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L370) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid.icd_comorbidity_map <- function(x, short_code, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:396:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L396) *style:* **Variable or function name should be snake_case.**
```r
icd_get_valid.character <- function(x, short_code = icd_guess_short(x)) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:408:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L408) *style:* **Variable or function name should be snake_case.**
```r
icd_get_valid.icd9 <- function(x, short_code = icd_guess_short(x)) {
^~~~~~~~~~~~~~~~~~
```
[R/valid.R:415:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L415) *style:* **Variable or function name should be snake_case.**
```r
icd_get_valid.icd10 <- function(x, short_code = icd_guess_short(x)) {
^~~~~~~~~~~~~~~~~~~
```
[R/valid.R:422:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L422) *style:* **Variable or function name should be snake_case.**
```r
icd_get_valid.icd10cm <- function(x, short_code = icd_guess_short(x)) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:440:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L440) *style:* **Variable or function name should be snake_case.**
```r
icd_get_invalid.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:454:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L454) *style:* **Variable or function name should be snake_case.**
```r
icd_get_invalid.icd9 <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:461:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L461) *style:* **Variable or function name should be snake_case.**
```r
icd_get_invalid.icd10 <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:469:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L469) *style:* **Variable or function name should be snake_case.**
```r
icd_get_invalid.icd_comorbidity_map <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:490:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L490) *style:* **Variable or function name should be snake_case.**
```r
icd_get_major.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~~
```
[R/valid.R:503:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L503) *style:* **Variable or function name should be snake_case.**
```r
icd_is_major.default <- function(x) {
^~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:514:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L514) *style:* **Variable or function name should be snake_case.**
```r
icd_is_major.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~
```
[R/valid.R:524:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L524) *style:* **Variable or function name should be snake_case.**
```r
icd_is_major.icd10cm <- function(x) {
^~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:531:1:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/R/valid.R#L531) *style:* **Variable or function name should be snake_case.**
```r
icd_is_major.icd9 <- function(x) {
^~~~~~~~~~~~~~~~~
```
[tests/testthat/test-class.R:207:19:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-class.R#L207) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  icd9_map_ahrq %>% unclass %>% icd_comorbidity_map -> x
                ~~^
```
[tests/testthat/test-comorbid-maps-icd9.R:176:50:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-comorbid-maps-icd9.R#L176) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                     icd9_map_quan_elix[["DMcx"]] ))
                                                 ^
```
[tests/testthat/test-comorbid-maps-icd9.R:178:50:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-comorbid-maps-icd9.R#L178) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                     icd9_map_quan_elix[["Mets"]] ))
                                                 ^
```
[tests/testthat/test-comorbid-maps-icd9.R:180:45:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-comorbid-maps-icd9.R#L180) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                     icd9_map_elix[["DMcx"]] ))
                                            ^
```
[tests/testthat/test-comorbid-maps-icd9.R:182:45:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-comorbid-maps-icd9.R#L182) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                     icd9_map_elix[["Mets"]] ))
                                            ^
```
[tests/testthat/test-comorbid-maps-icd9.R:183:70:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-comorbid-maps-icd9.R#L183) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_false(any(icd9_map_ahrq[["DM"]] %in% icd9_map_ahrq[["DMcx"]] ))
                                                                     ^
```
[tests/testthat/test-comorbid-maps-icd9.R:184:73:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-comorbid-maps-icd9.R#L184) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_false(any(icd9_map_ahrq[["Tumor"]] %in% icd9_map_ahrq[["Mets"]] ))
                                                                        ^
```
[tests/testthat/test-comorbid-maps-icd9.R:695:32:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-comorbid-maps-icd9.R#L695) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  res_nofactor <- vermont_dx %>% icd_wide_to_long %>% icd9_comorbid_ahrq
                             ~~^
```
[tests/testthat/test-convert.R:24:16:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-convert.R#L24) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_equal( icd_decimal_to_parts.icd9(""), list(mjr = NA_character_, mnr = NA_character_) )
               ^
```
[tests/testthat/test-convert.R:24:94:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-convert.R#L24) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_equal( icd_decimal_to_parts.icd9(""), list(mjr = NA_character_, mnr = NA_character_) )
                                                                                ^
```
[tests/testthat/test-convert.R:197:13:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-convert.R#L197) *style:* **Variable or function name should be snake_case.**
```r
            icd9List <- icd9_map_ahrq #todo SUBSET OR EXTRA MAPPINGS?
            ^~~~~~~~
```
[tests/testthat/test-lints.R:19:38:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-lints.R#L19) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
    "package:devtools" %nin% search() ) {
                                     ^
```
[tests/testthat/test-ranges.R:252:23:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-ranges.R#L252) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_equal_no_icd( ("042" %i9s% "042")[1], "042")
                      ^
```
[tests/testthat/test-score.R:40:3:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-score.R#L40) *style:* **Variable or function name should be snake_case.**
```r
  c2.inv <- cbind(t(comorbids[2, 2:18]), c(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 2, 2, 2, 2, 3, 6, 6))
  ^~~~~~
```
[tests/testthat/test-score.R:237:3:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-score.R#L237) *style:* **Variable or function name should be snake_case.**
```r
  c2.inv <- cbind(t(comorbids[2, -1]),
  ^~~~~~
```
[tests/testthat/test-valid.R:392:109:](https://github.com/jackwasey/icd/blob/45b53fd9ebd01f4fcfcfdf07193f9281904acd14/tests/testthat/test-valid.R#L392) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_equal(icd9_filter_valid(pts_invalid_mix, short_code = TRUE, invert = FALSE), pts_invalid_mix[c(1, 3 ), ])
                                                                                ^
```


Sorry, my English is bad,
We always play chess every day wearing chess clock,
**we have tried benhur sketch but not match, because there is no pause menu,
Benhur sketch there is only setting the addition of minutes and seconds without any reduce it.
(https://www.youtube.com/watch?v=1cjI9LJNK-s)**
Your sketch is perfect for us, Please perfect your sketh so we can play comfortably using your system,
We are very grateful


哈哈, 开始出来玩了?


Construct Working Robot
Make it drive forward


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/a1c1f084-c18b-4ecb-99f8-9a9b22da21b5 "FB Face Recognition"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/63e7d3d4-ea51-4079-91c8-7e11b1d3f83b "FB Face Recognition") deployed [FB-Face-Recognition](https://github.com/iris-bot/FB-Face-Recognition/releases/tag/deploy-ibm-yp-us-south-iris-bot-dev-20170505-022449 "deploy-ibm-yp-us-south-iris-bot-dev-20170505-022449") to [dev](https://console.ng.bluemix.net/apps/47bcbc3c-0115-4065-99e5-49b693b7caac "ibm:yp:us-south:iris-bot:dev"), including this commit


为什么加了这个注解就可以 Solve the conflict between @Service and @Transactional，一直对注解这块不是很熟悉，有没有人解释下怎么理解


sure


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/4783b745-d26b-41fe-bb56-d39169880c89 "fitchain"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/420a436e-add5-49fe-9817-1556990ec503 "fitchain") deployed [health-blockchain](https://github.com/IBM-Bluemix/health-blockchain/releases/tag/deploy-ibm-yp-us-south-Dev-Advocates-demos-20170505-022653 "deploy-ibm-yp-us-south-Dev-Advocates-demos-20170505-022653") to [demos](https://console.ng.bluemix.net/apps/a40dc60e-7166-458d-af16-edeb22da5c9d "ibm:yp:us-south:Dev-Advocates:demos"), including this commit


close but more like this...

scope :order, -> { order('title asc') }


This version ( or something close to it) should pass LTC 😎 :

```
  r = std::max(DEPTH_ZERO, (r / ONE_PLY - ss->history / 20000) * ONE_PLY);

  if (type_of(moved_piece) == KING)
  {

  if (depth > 3 * ONE_PLY && !inCheck && pos.non_pawn_material() >= 0)
	   r += ONE_PLY;
  else if ( inCheck && pos.non_pawn_material() == 0)
	   r -= ONE_PLY;
  }


Function resetGame is defined inside of the click handler for button, move it out of click handler to avoid unnecessarily redefining the function each time the button is clicked


申博您好，请问是否可以申请在您的指导下与您共同维护此项目？我对此项目非常感兴趣，我给您的gmail邮箱发了邮件，有时间的话请查阅下。谢谢。


@fengyunhe Service是dubbo自定义的注解，Transactional是spring自定义的注解，加Inherited的意思是Service的注解可以继承来自父类的注解标签，应该是有一个依赖的层级关系。


These ones should not be shared either


You really need this import in this file?


Function newGame is never called


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/a1c1f084-c18b-4ecb-99f8-9a9b22da21b5 "FB Face Recognition"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/63e7d3d4-ea51-4079-91c8-7e11b1d3f83b "FB Face Recognition") deployed [FB-Face-Recognition](https://github.com/iris-bot/FB-Face-Recognition/releases/tag/deploy-ibm-yp-us-south-iris-bot-dev-20170505-023414 "deploy-ibm-yp-us-south-iris-bot-dev-20170505-023414") to [dev](https://console.ng.bluemix.net/apps/47bcbc3c-0115-4065-99e5-49b693b7caac "ibm:yp:us-south:iris-bot:dev"), including this commit


Do you really need this import in this file?


Refactor ？


m


啊实打实的


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/a1c1f084-c18b-4ecb-99f8-9a9b22da21b5 "FB Face Recognition"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/63e7d3d4-ea51-4079-91c8-7e11b1d3f83b "FB Face Recognition") deployed [FB-Face-Recognition](https://github.com/iris-bot/FB-Face-Recognition/releases/tag/deploy-ibm-yp-us-south-iris-bot-dev-20170505-024030 "deploy-ibm-yp-us-south-iris-bot-dev-20170505-024030") to [dev](https://console.ng.bluemix.net/apps/47bcbc3c-0115-4065-99e5-49b693b7caac "ibm:yp:us-south:iris-bot:dev"), including this commit


我5月5号生日当天买的第一版 ，~~~~(>_<)~~~~


![](https://github.trello.services/images/mini-trello-icon.png) [UX Meeting](https://trello.com/c/8LrIaRmg/28-ux-meeting)


GlazingEnahncementsWinkelmann (lgu1234) - Win64-Windows-7-VisualStudio-14: OK (2494 of 2497 tests passed, 596 test warnings)

Messages:

 * 599 tests had: AUD diffs.
 * 3 tests had: EIO diffs.
 * 3 tests had: ESO big diffs.
 * 3 tests had: MTR big diffs.
 * 1 test had: Table small diffs.
 * 2 tests had: Table big diffs.

Failures:

regression Test Summary
 * Passed: 597
 * Failed: 3

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.png)


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/a1c1f084-c18b-4ecb-99f8-9a9b22da21b5 "FB Face Recognition"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/63e7d3d4-ea51-4079-91c8-7e11b1d3f83b "FB Face Recognition") deployed [FB-Face-Recognition](https://github.com/iris-bot/FB-Face-Recognition/releases/tag/deploy-ibm-yp-us-south-iris-bot-dev-20170505-024712 "deploy-ibm-yp-us-south-iris-bot-dev-20170505-024712") to [dev](https://console.ng.bluemix.net/apps/47bcbc3c-0115-4065-99e5-49b693b7caac "ibm:yp:us-south:iris-bot:dev"), including this commit


This is in `servant-auth-token-persistent`, not the main library.


最初のコミット


@wdhonor 看看外层容器的高度，还有ViewPager是否是Flex:1


テストコミット


another one that should probably be moved to Tokenizer, given the function's imported from there and the type is from there


Thanks @lbud -> https://github.com/mapbox/glyph-pbf-composite/issues/6


Thanks for the fix, AFA.


This looks wrong.


I think the callback should always be private unless the materializeForSet is shared, then the callback should be shared. What do you think?


#sign-off


These should be hidden or private


Was there actually a case where they were public? Hidden is less visible than shared


Right but it's just a comment.


teste


Maybe it would be better if root was equal to the "current working directory", or a path specified by command line arguments.


Zamiast wywoływać funkcje w warunkach, proponuję umieścić ją za ifami.
Nie bedziesz musiał powielać kodu


I'm writing a Z80 emulator of my own. When calculating the half-carry flag, should you include c from ADC?


Should that be `l:count`?


Created multidev environment [logic-magic#ci-1](https://dashboard.pantheon.io/sites/3e98e69e-c204-4666-b43c-94b523aacf28#ci-1).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-1-logic-magic.pantheonsite.io/)


Aha! I'll merge them.


Yep. Your mistake not mine right? :)


Yes I know but I would like to keep the same code than vscode-textmate. It's helpful when you compare tm4e code with vscode-textmate code.


Won't this fix cause issues when a tile exposes _different_ item handlers on different sides?


Hmm, good point. Gonna revert this fix then...


Thug


Yeah, sorry.  All that `a:` and `l:` got me confused...


Thanks for the update!


Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem `will-paginate-i18n` should appear before `will_paginate`.


Just for demonstration of changes


Why isn't this include_once again?


![](https://github.trello.services/images/mini-trello-icon.png) [Include author name in TopDocs widget of GA](https://trello.com/c/9yKb5aSN/2-include-author-name-in-topdocs-widget-of-ga)


You got rid of the ransomwaretracker.abuse.ch and some other earlier used lists... Are they already in the firehol lists?
Thanks a lot for putting the effort to consolidate the lists, btw.  :+1:


Maybe add some conditions to improve the commanderie.
For example some military buildings, walls, or simply a building number


Nope, you can chain all the way back to the person taking the targeted decision using your FROMs. The amount of FROMs needed depends on how many events away from the original decision you are.
If a targeted decisions launches an event then in that event the decision taker is FROMFROM, the decision recipient is FROM and also ROOT. In the next event the decision taker is then FROMFROMFROM and the recipient is FROMFROM and FROM and so on.
If you end up with lots of events in one chain from a decision then eventually you reach the max depth of using FROMs and PREVs so it is best to save the decisions taker and target as event targets for reference in the latter events. However based on the stuff in the file you committed just chaining FROMs and PREVs should be enough.


thanks for testing, there was a nasty bug in this... https://github.com/opnsense/core/commit/b792c9fb9ee7ce3bacfb564165e2294d81fb53d0

I don't think we can get of the reload, it looks like this is directly tied to ppp-linkup, but the reload can be made less annoying:

https://github.com/opnsense/core/commit/9b4c350efb

Still work to do but it looks like light at the end of the tunnel :)


TeamCity libpalaso :: palaso-linux64-libpalaso-2.6 Continuous [Build 2.6.1362.bd096bfe44832126e42bee7277c512c3c273e76d](http://build.palaso.org/viewLog.html?buildId=90213&buildTypeId=PalasoLinux64v26Cont) outcome was **SUCCESS**
Summary: Tests passed: 3719, ignored: 111 Build time: 00:04:39


Change to .password-change-area


TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.120.bd096bfe44832126e42bee7277c512c3c273e76d](http://build.palaso.org/viewLog.html?buildId=90212&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3741, ignored: 128 Build time: 00:04:56


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/e853ffbe-52ed-439d-9392-c41066e542da "acme-freight-donotdelete"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/c2fe55bf-0085-4586-b01c-b8395765add7 "webui (dev)") deployed [acme-freight-webui](https://github.com/IBM/acme-freight-webui/releases/tag/deploy-ibm-yp-us-south-svennam-us.ibm.com-acme-freight-20170505-201553 "deploy-ibm-yp-us-south-svennam-us.ibm.com-acme-freight-20170505-201553") to [acme-freight](https://console.ng.bluemix.net/apps/fa0ce6c7-b2a5-497c-89ec-af36f745ebc1 "ibm:yp:us-south:svennam@us.ibm.com:acme-freight"), including this commit


Thank you for the quick response!

If I understand the issue you linked, what Clocktown was referring to with "supposed to behave" is https://github.com/nothings/stb/blob/master/stb_image.h#L138, right? Is that behavior is still desired, then there might indeed be a bug in that code. I'll run some tests and submit a pull request if I find something.

I'm using stb_image to load images of different internal formats, and I don't know beforehand which format an image will be so I can't set `req_comp` to anything other than the default. Am I missing something?


Change title to:
Change password | Overcooked.ca


Added round window buttons


okay)


```python
for i,d in enumerate([datax, datay, dataz]) if accel[i] < 30000: d = np.append(d, accel[i])
```
So close!


Also allows a POST for CREATE to be successful.


But they're not "in the future" because of some miscalculation... it is
because the clocks are not in sync

So I don't think it's really a bug.... proper solution would be to send in
the client clock in UTC and adjust the posting time to account for drift.

On Fri, May 5, 2017, 18:32 Barış Soner Uşaklı <notifications@github.com>
wrote:

> If we add this back, new replies show a timeago in the future(usually one
> minute). If we add it back we need to add a hack to subtract ~60 seconds
> from timestamps client side.
>
> —
>
>
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/NodeBB/NodeBB/commit/670a5d9ca01e252e573f11b9cf8d2e80b7ecda73#commitcomment-22035180>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AA4Vgy1hqjYYq9xdSzu3ir3GFnV_lFhFks5r207vgaJpZM4NRDyu>
> .
>
--
*Julian Lam*
*Co-Founder, NodeBB Inc.*
619-341 King Street East, Toronto, ON
M5A 1L1, Canada


Follow up discussed in person is that this commit removed duplicate styles, the real ones should still be at:
https://github.com/mongodb-js/compass-plugin/tree/master/template/styles


Static fieldus klasėj initializina tik vieną kartą, dar prieš sukuriant objektą


+#This Paint Project it based off of Microsoft Paint. It features basic tools for computer art, and some stamps from Elder Scrolls V: Skryim.
+#Coded on Python 3.2, 32 bit. Approx. 80 hours->1200 lines


![](https://github.trello.services/images/mini-trello-icon.png) [Countdown clock for swag-a-thon](https://trello.com/c/J5eWKa2Z/52-countdown-clock-for-swag-a-thon)


Įdėk prekę į krepšelį ir per kitą naršyklę atsidarryk


TeamCity libpalaso :: palaso-linux64-master Continuous [Build 4.0.113.bd096bfe44832126e42bee7277c512c3c273e76d](http://build.palaso.org/viewLog.html?buildId=90215&buildTypeId=Libpalaso_PalasoLinux64masterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3719, ignored: 111 Build time: 00:04:37


looks good


Well, thinking it through again if we did that then if the clock is
drifting the *other* way then it'll also suffer from the same symptom, so
maybe on post render of a new post, if the datetime is greater than
Date.UTC(), set it to Date.UTC().

Hacky but works.

On Fri, May 5, 2017 at 10:16 PM Julian Lam <julian@nodebb.org> wrote:

> But they're not "in the future" because of some miscalculation... it is
> because the clocks are not in sync
>
> So I don't think it's really a bug.... proper solution would be to send in
> the client clock in UTC and adjust the posting time to account for drift.
>
> On Fri, May 5, 2017, 18:32 Barış Soner Uşaklı <notifications@github.com>
> wrote:
>
>> If we add this back, new replies show a timeago in the future(usually one
>> minute). If we add it back we need to add a hack to subtract ~60 seconds
>> from timestamps client side.
>>
>> —
>>
>>
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/NodeBB/NodeBB/commit/670a5d9ca01e252e573f11b9cf8d2e80b7ecda73#commitcomment-22035180>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AA4Vgy1hqjYYq9xdSzu3ir3GFnV_lFhFks5r207vgaJpZM4NRDyu>
>> .
>>
> --
> *Julian Lam*
> *Co-Founder, NodeBB Inc.*
> 619-341 King Street East, Toronto, ON
> M5A 1L1, Canada
>
--
*Julian Lam*
*Co-Founder, NodeBB Inc.*
619-341 King Street East, Toronto, ON
M5A 1L1, Canada


![](https://github.trello.services/images/mini-trello-icon.png) [Permitir jerarquía de GameEntities](https://trello.com/c/fsCFDE3X/45-permitir-jerarquia-de-gameentities)


No — for some reason we use `%1$S` et al. in a lot of strings with multiple placeholders, but it's only necessary when the same word needs to be substituted multiple times in the same string. Using `%S` multiple times just uses the passed order.


The domain should not be hardcored


![](https://github.trello.services/images/mini-trello-icon.png) [Transform Class](https://trello.com/c/jXr8S3PB/44-transform-class)


Wow Sergio D: Eres Grande 👍


TeamCity libpalaso :: palaso-trusty64-lfmerge Continuous [Build 2.6.349.bd096bfe44832126e42bee7277c512c3c273e76d](http://build.palaso.org/viewLog.html?buildId=90214&buildTypeId=PalasoTrusty64lfmergeContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3719, ignored: 111 Build time: 00:13:43


## Global

| Changed            |   Status |
|:-------------------|---------:|
| `coverage`         |     2.52 |
| `metadata_passing` |    29    |
| `metadata_total`   |    29    |
| `nodes_count`      |   950    |
| `texts_passing`    |    33    |

## Words

| Changed   |   Status |
|:----------|---------:|
| `UNK`     |    -5640 |
| `grc`     |   +53817 |

## Units

| Changed                                                 | Status   |
|:--------------------------------------------------------|:---------|
| `./data/tlg0540/tlg002/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg002/tlg0540.tlg002.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg002/tlg0540.tlg002.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg003/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg003/tlg0540.tlg003.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg003/tlg0540.tlg003.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg004/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg004/tlg0540.tlg004.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg004/tlg0540.tlg004.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg005/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg005/tlg0540.tlg005.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg005/tlg0540.tlg005.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg006/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg006/tlg0540.tlg006.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg006/tlg0540.tlg006.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg007/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg007/tlg0540.tlg007.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg007/tlg0540.tlg007.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg008/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg008/tlg0540.tlg008.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg008/tlg0540.tlg008.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg009/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg009/tlg0540.tlg009.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg009/tlg0540.tlg009.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg010/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg010/tlg0540.tlg010.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg010/tlg0540.tlg010.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg011/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg011/tlg0540.tlg011.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg011/tlg0540.tlg011.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg012/tlg0540.tlg012.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg012/tlg0540.tlg012.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg013/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg013/tlg0540.tlg013.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg013/tlg0540.tlg013.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg014/tlg0540.tlg014.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg014/tlg0540.tlg014.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg015/tlg0540.tlg015.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg015/tlg0540.tlg015.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg016/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg016/tlg0540.tlg016.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg016/tlg0540.tlg016.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg017/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg017/tlg0540.tlg017.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg017/tlg0540.tlg017.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg018/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg018/tlg0540.tlg018.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg018/tlg0540.tlg018.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg019/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg019/tlg0540.tlg019.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg019/tlg0540.tlg019.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg020/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg020/tlg0540.tlg020.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg020/tlg0540.tlg020.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg021/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg021/tlg0540.tlg021.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg021/tlg0540.tlg021.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg022/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg022/tlg0540.tlg022.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg022/tlg0540.tlg022.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg023/tlg0540.tlg023.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg023/tlg0540.tlg023.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg024/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg024/tlg0540.tlg024.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg024/tlg0540.tlg024.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg025/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg025/tlg0540.tlg025.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg025/tlg0540.tlg025.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg026/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg026/tlg0540.tlg026.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg026/tlg0540.tlg026.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg027/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg027/tlg0540.tlg027.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg027/tlg0540.tlg027.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg028/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg028/tlg0540.tlg028.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg028/tlg0540.tlg028.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg029/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg029/tlg0540.tlg029.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg029/tlg0540.tlg029.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg030/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg030/tlg0540.tlg030.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg030/tlg0540.tlg030.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg031/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg031/tlg0540.tlg031.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg031/tlg0540.tlg031.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg032/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg032/tlg0540.tlg032.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg032/tlg0540.tlg032.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg033/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg033/tlg0540.tlg033.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg033/tlg0540.tlg033.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg034/__cts__.xml`                     | New      |
| `./data/tlg0540/tlg034/tlg0540.tlg034.perseus-grc1.xml` | Deleted  |
| `./data/tlg0540/tlg034/tlg0540.tlg034.perseus-grc2.xml` | New      |
| `./data/tlg0540/tlg002/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg002/tlg0540.tlg002.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg003/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg003/tlg0540.tlg003.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg004/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg004/tlg0540.tlg004.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg005/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg005/tlg0540.tlg005.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg006/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg006/tlg0540.tlg006.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg007/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg007/tlg0540.tlg007.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg008/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg008/tlg0540.tlg008.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg009/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg009/tlg0540.tlg009.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg010/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg010/tlg0540.tlg010.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg011/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg011/tlg0540.tlg011.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg012/tlg0540.tlg012.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg013/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg013/tlg0540.tlg013.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg014/tlg0540.tlg014.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg015/tlg0540.tlg015.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg016/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg016/tlg0540.tlg016.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg017/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg017/tlg0540.tlg017.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg018/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg018/tlg0540.tlg018.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg019/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg019/tlg0540.tlg019.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg020/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg020/tlg0540.tlg020.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg021/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg021/tlg0540.tlg021.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg022/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg022/tlg0540.tlg022.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg023/tlg0540.tlg023.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg024/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg024/tlg0540.tlg024.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg025/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg025/tlg0540.tlg025.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg026/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg026/tlg0540.tlg026.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg027/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg027/tlg0540.tlg027.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg028/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg028/tlg0540.tlg028.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg029/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg029/tlg0540.tlg029.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg030/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg030/tlg0540.tlg030.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg031/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg031/tlg0540.tlg031.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg032/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg032/tlg0540.tlg032.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg033/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg033/tlg0540.tlg033.perseus-grc2.xml` | Passing  |
| `./data/tlg0540/tlg034/__cts__.xml`                     | Passing  |
| `./data/tlg0540/tlg034/tlg0540.tlg034.perseus-grc2.xml` | Passing  |

*[Hook UI build recap](http://ci.perseids.org/repo/PerseusDL/canonical-greekLit/323)*


Damn, i totally messed up the indentation on that hashmap. Sorry about that!


TeamCity libpalaso :: fixing-to-fix-palaso-linux64-masterContinuous [Build 4.0.22.4b628c4b9f2c37288270f6c778c9e989461f8826](http://build.palaso.org/viewLog.html?buildId=90217&buildTypeId=JasonHatesMono) outcome was **FAILURE**
Summary: Exit code 4 Build time: 00:04:55


Because of https://github.com/vanilla/vanilla/commit/31726be89e274de9a55aba3e11360e3e9d2ccb2a#diff-8a05c730f5b0665f54cefcac279b7eb9R54


These should be disabled by default and enabled by a script which sets the desired bus and chip select.
If you want to have overlays for runtime use with CONFIGFS, maybe we should add a separate repository for those and write a script to automate adding and removing overlays with configfs.


I should have updated the include above instead of removing once on this one.


I think we can just state = new_state then save. Do we need to check the value of new_state before we set?


TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.121.4b628c4b9f2c37288270f6c778c9e989461f8826](http://build.palaso.org/viewLog.html?buildId=90225&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3741, ignored: 128 Build time: 00:08:01


Why is --config here? If I just run pwmetrics I expect the no url provided error to appear. I shouldn't have to know beforehand that the config flag is needed


The Ultimate Question of Life, the Universe, and Everything.


Just a small nit, else the tests look good


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/e853ffbe-52ed-439d-9392-c41066e542da "acme-freight-donotdelete"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/c2fe55bf-0085-4586-b01c-b8395765add7 "webui (dev)") deployed [acme-freight-webui](https://github.com/IBM/acme-freight-webui/releases/tag/deploy-ibm-yp-us-south-svennam-us.ibm.com-acme-freight-20170505-202935 "deploy-ibm-yp-us-south-svennam-us.ibm.com-acme-freight-20170505-202935") to [acme-freight](https://console.ng.bluemix.net/apps/1c60abc5-8514-4790-97de-4b79dca95fd1 "ibm:yp:us-south:svennam@us.ibm.com:acme-freight"), including this commit


For consistency change these tests all to have try catch or the return -> expect error


I want you to consider weather this is better even though it's logically correct. I'd argue that you've now [coupled](https://en.wikipedia.org/wiki/Coupling_(computer_programming)) your code to a line that is not apparently a dependency.


TeamCity libpalaso :: palaso-linux64-libpalaso-3.1 Continuous [Build 3.1.324.4b628c4b9f2c37288270f6c778c9e989461f8826](http://build.palaso.org/viewLog.html?buildId=90219&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3719, ignored: 111 Build time: 00:05:20


Nice catch. Didn't notice this one.


Cool, yesterday I didn't realised that this function was appropriate to use here, addition to my knowledge, thanks :+1:


We are not expecting throwing error here. So trick to make kinda `to.not.throw` is doing this way => `expect(error).to.be.null;`


*[Hook UI build recap](http://ci.perseids.org/repo/PerseusDL/canonical-greekLit/324)*


I got confused with my addon where I just use the raw urls if autoplay is off.
As everything does go through PlayStream to play I think it should look at the stream url to work out the protocol. If it ends with mpd before the # suffix it can just set the inputstream.adaptive properties without looking at the Setting.
That should work as any shortcut or favourite link.
You could pass another parameter to PlayStream for the hls/dash/etc protocol if you really want to be sure it picks the right one.


TeamCity libpalaso :: palaso-linux64-master Continuous [Build 4.0.114.4b628c4b9f2c37288270f6c778c9e989461f8826](http://build.palaso.org/viewLog.html?buildId=90226&buildTypeId=Libpalaso_PalasoLinux64masterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3719, ignored: 111 Build time: 00:04:51


I think we can get rid of the -component now :)

If I were naming the classes for this one, I'd go with
.company-label
.company-label span
And then make the inner `<div>` a `<span>`

Steve would say to break up the padding into padding-top and padding-bottom :)

But, it's good to go.


Created multidev environment [joshuahdiamond#ci-2](https://dashboard.pantheon.io/sites/7078ab8e-f45b-4795-b4a4-4ecf7d8be640#ci-2).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-2-joshuahdiamond.pantheonsite.io/)


Did you need the one I made recently, 0.3.1 ?


symbol_builder should be a method variable not an instance variable because we don't need to keep it
```symbol_builder =  SymbolTableBuilder()```


144935867-User-file-with-RoomAirSettingsAirflowNetwork-is-failing-with-fatal-error-#6086 (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1895 of 1895 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.49%25-green.png)


*[Hook UI build recap](http://ci.perseids.org/repo/PerseusDL/canonical-greekLit/325)*


144935867-User-file-with-RoomAirSettingsAirflowNetwork-is-failing-with-fatal-error-#6086 (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


@pasali eger bu sekilde istedigimiz parametreyi obur tarafa geciyorsak, `cache reference file` gibi bir dosyayi da yollayalim parametre olarak. Bu sekilde o dosyaya bakalim. default olarak: pom.xml olsun ama projeler parametreyi override edebilsin. Misal td icin tazedirekt/pom.xml olsun falan :)


No you're not missing anything, if you set req_comp == 0 then the return value should always be both the value that is implied by the file data, _and_ the number of channels you'll find in the returned pixel array.


Right. But there was a review comment from chris as not to use elements name in class names.


Are these new versions actually fully working with our code (especially NVD3 and D3)???

This is really critical.


Thank you for quick reply!

Does above solution work with DatabaseOperation.DELETE as tearDownOperation?


Yeah, I can see that. Maybe then company-name and then company-name-label. But, what you have is fine.


NVD3, for one, is not :/ too bad really, this breaks very important functionality at the worst possible time.


elaa


@cemo tamam bunuda bir düşüneyim nasıl işimize gelecek şekilde halledebiliriz diye


@djorg83 Please create an issue and explain why missing `use strict` breaks. If possible, a patch will be really helpful too.


TeamCity libpalaso :: palaso-linux64-libpalaso-2.6 Continuous [Build 2.6.1363.4b628c4b9f2c37288270f6c778c9e989461f8826](http://build.palaso.org/viewLog.html?buildId=90228&buildTypeId=PalasoLinux64v26Cont) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 3718, ignored: 111 Build time: 00:09:26
### Failed tests
```
LanguageData.Tests.dll: LanguageData.Tests.GetAndCheckSourcesTests.GetNewSources_Ok: <no details avaliable>

```


TeamCity libpalaso :: palaso-trusty64-lfmerge Continuous [Build 2.6.350.4b628c4b9f2c37288270f6c778c9e989461f8826](http://build.palaso.org/viewLog.html?buildId=90229&buildTypeId=PalasoTrusty64lfmergeContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3719, ignored: 111 Build time: 00:09:53


Oh crap - report charts broken...yet more work!


I did a lot of testing of pivottable...is there something else using it?


lolol


If you have an urgent release then simply ignore these updates for now


Pivot table charts look terrible - totally deranged.


Awesome!


Funny how you seem to be seeing something totally different...perhaps need to rebuild your CSS?
I hjust see 1 small visual glitch with the spectrum pie top cut off


Completes #1


So you will fix all these issues? (Especially the broken layout in pivot table charts?)


As I say, I can only see 1 small issue currently...I did a fair bit of testing, but yes I should look into any issues you report, but if you have an urgent release then simply isolate yourself from them...I am doing big changes


This is looking good so far 👍
One important comment --
I had in mind to use an array-like form item, where the same input name is used for multiple inputs on the page, and the backend code receives an array of all the items, like [here](http://stackoverflow.com/a/7880656/3018033). This approach would allow multiple frontend components to set form values independently, and for each of them to be processed independently by the backend.
```
<input type="hidden" name="json_form_update[]" value="{ key1: {...} }" />
...
<input type="hidden" name="json_form_update[]" value="{ key2: {...} }" />
....
<input type="hidden" name="json_form_update[]" value="{ key3: {...} }" />
```


nice.


TeamCity libpalaso :: palaso-linux64-libpalaso-2.6 Continuous [Build 2.6.1364.0854606dbffce7837bb0317a36aa8060dc4c8f69](http://build.palaso.org/viewLog.html?buildId=90241&buildTypeId=PalasoLinux64v26Cont) outcome was **SUCCESS**
Summary: Tests passed: 3393, ignored: 125 Build time: 00:03:45


EXPECT_EQ(expected, actual)


This is just a starting point, but here are a few links we might want in the footer:

- HUD.gov, of course (https://portal.hud.gov/hudportal/HUD)
- CDBG-DR Program Resources (https://www.hudexchange.info/programs/cdbg-dr/)
- DisasterAssistance.gov (https://www.disasterassistance.gov/)
- DRGR Log-In (https://drgr.hud.gov/drgrsm/login.fcc?TYPE=33554433&REALMOID=06-3cb63685-a1f2-1024-bb25-83d8f1ba0cb3&GUID=&SMAUTHREASON=0&METHOD=GET&SMAGENTNAME=-SM-Xd3mwNjr4OL9Te0epxEIiJgGrEMJ6V9UtQOjzhbBlh6c3MLuW%2fgSS3bf6OxT2rJg&TARGET=-SM-https%3a%2f%2fdrgr%2ehud%2egov%2fDRGRWeb%2f)

Also, here's a link related to DRGR System Access (https://www.hudexchange.info/drgr/drgr-account-registration-or-modification/). I think that's where people need to go if they don't already have a log-in ID. So this should probably be linked from the sign-in bubble (new registration) rather than the footer.


The following doc(s) have been deployed to the [upstreams](https://upstreams-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/private-upstreams](https://upstreams-static-docs.pantheonsite.io/docs/private-upstreams)
- [source/docs/assets/images/edu-upstream-repository.jpg](https://github.com/pantheon-systems/documentation/commit/4240436666b97409b2a4af71ab9fcd5cf83758f5/source/docs/assets/images/edu-upstream-repository.jpg)
- [docs/create-custom-upstream](https://upstreams-static-docs.pantheonsite.io/docs/create-custom-upstream)
- [docs/custom-upstream](https://upstreams-static-docs.pantheonsite.io/docs/custom-upstream)
- [docs/maintain-custom-upstream](https://upstreams-static-docs.pantheonsite.io/docs/maintain-custom-upstream)
- [docs/maintain-private-upstreams](https://upstreams-static-docs.pantheonsite.io/docs/maintain-private-upstreams)
- [source/docs/assets/images/custom-upstream-workflow-chart.png](https://github.com/pantheon-systems/documentation/commit/4748b1174986a782dac24dd56fbfb2c9745c1b54/source/docs/assets/images/custom-upstream-workflow-chart.png)
- [source/docs/assets/images/empty-state-diagram.svg](https://github.com/pantheon-systems/documentation/commit/4748b1174986a782dac24dd56fbfb2c9745c1b54/source/docs/assets/images/empty-state-diagram.svg)
- [source/docs/assets/images/upstreams.png](https://github.com/pantheon-systems/documentation/commit/4748b1174986a782dac24dd56fbfb2c9745c1b54/source/docs/assets/images/upstreams.png)


TeamCity libpalaso :: palaso-trusty64-lfmerge Continuous [Build 2.6.351.f365fa96dddd250f53cadb46697be8e7139d5daf](http://build.palaso.org/viewLog.html?buildId=90242&buildTypeId=PalasoTrusty64lfmergeContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3389, ignored: 124 Build time: 00:05:17


Dodano podzial pracy


We notice that familyCar bean does need to create fourCyl bean. it just need to call its bean method getFourCyl().


It's not about an urgent release - it's about fixing all these issues. If you do that, then fine - but I can't add more work to my heap.

Not sure how long I can hold off merging yours - but I'll try to wait a little bit. How soon do you think you can fix the most?

Pivot table charts is not only the cut off edge - the chart is also too small and in the wrong position, the axis ticks are wrong (they don't adapt to the range as they did), the spectrum form widgets are too close, and the x-axis labels overlap when there are many (they should offset up/down).

The next version of NVD3 wasn't API-compatible, that's why I didn't upgrade - they changed so many things that it will require quite some work in pivottables.

What other major changes are you planning right now?


Thanks. I see, I'll add the `[]` part to the attribute name. What is handling looping through the array of items? As in, is there some kind of mediator (is it the browser?) between the JSONFormDataHandler and the frontend form submission that constructs the array-like set of form data?


I really appreciate the work you put into the exercises as it helps me as I progress through the book will you be stopping on chapter 4 or more chapters are on the way?
Either way thank you.


144488793-Correct-surface-convection-calculation-6037 (lgu1234) - i386-Windows-7-VisualStudio-14: OK (2492 of 2495 tests passed, 0 test warnings)

Messages:

 * 3 tests had: EIO diffs.
 * 3 tests had: ESO big diffs.
 * 3 tests had: MTR big diffs.
 * 1 test had: Table big diffs.
 * 2 tests had: Table small diffs.

Failures:

regression Test Summary
 * Passed: 596
 * Failed: 3

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.png)


This code styles the volume sliders, making them bigger so it's easier to use a touch screen with. It also makes the volume slider look the same on all platforms/OSs.


better late then never;
I've updated the file so the connection will
[db_sqlsrv.zip](https://github.com/Clorith/SQLSRV-DataBase-Class/files/980317/db_sqlsrv.zip)

 take the "CharacterSet" parameter also.
i found it very useful for me since i'm also programming "Hebrew" language websites and databases.


It's handled at the Java servlet level: http://stackoverflow.com/a/30849923/3018033


This is how it looks now:
![screenshot_20170505_230014](https://cloud.githubusercontent.com/assets/1257183/25764168/e0975018-31e6-11e7-835b-a7c7cbcd755b.png)

This is how it should look:
![screenshot_20170505_225935](https://cloud.githubusercontent.com/assets/1257183/25764174/e89cbaf0-31e6-11e7-960f-bced3597df13.png)

Note the y-axis ticks!


Ah, ok.


Is this merged to dev?


![](https://github.trello.services/images/mini-trello-icon.png) [Integrate and write Unit Tests for the api method DELETE_users-id](https://trello.com/c/MdYHW0Te/30-integrate-and-write-unit-tests-for-the-api-method-delete-users-id)


So actually I was mistaken, the square brackets `[]` are not necessary, it's only necessary to call `getParameterValues()` instead of `getParameter()`.


![](https://github.trello.services/images/mini-trello-icon.png) [Integrate and write Unit Tests for the api method POST_Users](https://trello.com/c/VzXUy7Ju/26-integrate-and-write-unit-tests-for-the-api-method-post-users)


unitary_system_performance_multi_speed (nmerket) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


Greetings, I am the maintainer of the package on AUR:

* On the session thing: perhaps it would be good to open an issue on upstream, specially since I havent checked that yet

* On the icon and wallpaper thing, I might need some help since in this case it says that it depends on the distribution on what and how to package it, in the AUR I provide it as vanilla as possible. I am willing to know about how to provide that kind of file but because of the nature of the package I can't promise to put it exactly on AUR, since every user might have a different set and I cannot assume neither a standard set or a user-selected set, so I leave it as close to upstream as possible

* Also if you want to change dependencies (once again I stick to upstream on that one) because of names or because another package already provides that (I use Antergos and I know that package names are different on Mint than Arch and derivatives) you can let me know and I can update the AUR with the needed files


Created multidev environment [joshuahdiamond#ci-3](https://dashboard.pantheon.io/sites/7078ab8e-f45b-4795-b4a4-4ecf7d8be640#ci-3).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-3-joshuahdiamond.pantheonsite.io/)


I will be adding more, I am working on the Game Zone for Chapter 4 and the case studies.  I am teaching myself so it is a slow process.

From: aakindele3 [mailto:notifications@github.com]
Sent: Friday, May 5, 2017 5:00 PM
To: khenry312/Java_Programming_8th <Java_Programming_8th@noreply.github.com>
Cc: Kimberly Henry <kimberly.henry@outlook.com>; Author <author@noreply.github.com>
Subject: Re: [khenry312/Java_Programming_8th] Merge remote-tracking branch 'origin/master' (92bf785)

I really appreciate the work you put into the exercises as it helps me as I progress through the book will you be stopping on chapter 4 or more chapters are on the way?
Either way thank you.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/khenry312/Java_Programming_8th/commit/92bf78592aad9c729add866a6c03253bf29481d0#commitcomment-22038744>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AHfzF04I1p8cr7oFu2K75DRshgpc1_Vhks5r243ogaJpZM4NSat8>.


Also, the half-donut chart doesn't show any on-hover infos anymore (should show a small popup with the data point info).


Notre solution pour vous aider a trouver le bon candidat


Okay, I'll try to do that.


The documentation is awefully unclear and I don't have a Z80 handy to try. I followed the answer [here](http://stackoverflow.com/questions/8868396/gbz80-what-constitutes-a-half-carry).


@Sami32 like I said, compare that with this which is our version: http://universalmediaserver.com/svn/binaries/win32/fonts/fonts.conf


@egonw :  You likely don't want this commit.  I changed the mysql port to 3006 so it could use the MySQL in a ops-docker docker container.


This resolves trickygametools/laura2-dk#1


This cuts the update time in half...


@AXDOOMER Thanks for the explanation :)


unitary_system_performance_multi_speed (nmerket) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png)


I think it is now important to specify `protocol=tcp` for mysql.
Necessary for docker use. Might be optional if accessing on localhost.


Almost
```
10 drops x (32 drops + (Fulfillment size in bytes ÷ 16))
```


This seems to break the ignore feature, as detected by the test added in 81465d3. Thoughts on this? Why should we escape regex special characters in a regular expression? :)


The problem with the y-axis ticks and x-axis labels affects all barcharts, not just spectrum. Otherwise the look okay. Piecharts and breakdowns don't seem to have any problems.

Calendar is not working at all (doesn't even open).


> the half-donut chart doesn't show any on-hover infos anymore (should show a small popup with the data      > point info).

This is one of the things that I had to fix, but was working for me before I pushed


It might not be necessary`[]` at all, in either cases: http://stackoverflow.com/questions/1016272/how-to-post-multiple-record-sets-from-an-html-form-to-jsp-or-a-java-servlet


Right!


Not working here, though.


This was actually on purpose to deal with the fact that the upstream versioning  isn't always consistent. For example, the versioning for 16.05.9 did not have any extra release string info in META, so the `sinfo` binary reported 16.05.9 (not 16.05.9-1). I think it makes more sense to follow semantic versioning.


> The problem with the y-axis ticks and x-axis labels affects all barcharts, not just spectrum

This wasn't something I had noticed, but will look into it now...can reproduce it


Test


> Calendar is not working at all (doesn't even open).

How can I reproduce this?


> Not working here, though.

How can I reproduce this?


Hi , i have already open another issue for the problem of session https://github.com/linuxmint/slick-greeter/issues/25.
 For the dependence i have added a gtk3 dependes and moved imagemagick on makedepends but i think is not necessary .. why for a greeter need depend imagemagick ? and at last for now this is only a test pkg.. if not work how it expected i remove from our overlay ...


settings.L10n.calendar = "Afghan", for instance ;)


TeamCity libpalaso :: palaso-linux64-libpalaso-2.6 Continuous [Build 2.6.1365.dbed79e2fed509172f97165f2a24de07f523019e](http://build.palaso.org/viewLog.html?buildId=90250&buildTypeId=PalasoLinux64v26Cont) outcome was **SUCCESS**
Summary: Tests passed: 3589, ignored: 111 Build time: 00:06:15


I would store these above this lexical score. Something like

```js
const operations = {
  add: function(a,b){ return a + b },
  subtracts: …
}
```
and then

```js
if (buttonValue === '-') {
   operation = operations.subtract
   updateDisplay()
   return
}
```


`Enables loading of gzipped modules.`

I don't think the Lodash v5 call out is needed.
Lodash v5 will be one package that uses gzipped modules but others will be able to as well.


Weird line spacing format from VisualStudio shows everything as changed due to spacing.


For the info-boxes in Spectrum - if I hover over the half-donut, I see no info-box anywhere. Regardless which pivot table, it's the same for all reports. I don't see any JS error either - it's as if the feature wouldn't exist.


FFox52, just to mention it.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.122.dbed79e2fed509172f97165f2a24de07f523019e](http://build.palaso.org/viewLog.html?buildId=90259&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3611, ignored: 128 Build time: 00:04:16


Yup - Chrome in turn shows the info-boxes in spectrum. So it's a FFox-specific problem perhaps.


Am I doing this right?


TeamCity libpalaso :: palaso-linux64-master Continuous [Build 4.0.115.dbed79e2fed509172f97165f2a24de07f523019e](http://build.palaso.org/viewLog.html?buildId=90252&buildTypeId=Libpalaso_PalasoLinux64masterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3589, ignored: 111 Build time: 00:05:35


@vadrevua Design looks a lot better. One thing for the future: I would take a look at https://www.atlassian.com/git/tutorials/undoing-changes#git-revert
This allows you to revert the changes in some commit (so we could remove my Podfile commit for example).

This would allow us to keep our history consistent. If you notice, this branch says it only has 1 commit (even though we made lots of commits in the past)

This isn't a problem now, but keep it in mind for the future. Other than that, looks good, thanks!


🤦
OK, next time for sure.


Fixing link in tooltip.md (#1058)

Preview: documentation
Coverage: core | datetime


@killerwife and @cala I have a few comments / questions.

1st. The following code isn't working:
```c++
for (auto guid : eventData.summonedMagrami)
                if (Creature* pMagrami = instance->GetCreature(guid))
                    if (pMagrami->isAlive()) // dont despawn corpses with loot
                        pMagrami->ForcedDespawn();
```
I have a feeling that we are missing something here. I didn't see anywhere that we are actually adding the summoned creature guids to the eventData vector. Also, should we despawn creatures that are alive and in combat?

2nd. In UDB, the creatures already have faction 16. So this makes the setting of the faction pointless, and also it may break the visual aura change. Any idea if we need to update the DB with a different faction?

Everything else, looks great. Good job. 👍


done.


This is needed to get detailed information when qCritical(), qWarning() or qDebug() is used. In debug mode it's enabled by default, but in release mode has to be enabled manually.


It seems that `wxAutoULong' is a part of IUnknown interface implementation. This can be refactored with DECLARE_IUNKNOWN_METHODS, IMPLEMENT_IUNKNOWN_METHODS macros (ce7788e5), but this doesn't make a difference because they are defined also in oleutils.h.
This IUnknown macros look to be more related to COM than to OLE, so maybe priv/comptr.h would be a better location for this stuff?


by default there is used -O2, so this is needed (I remember that it was an issue at the beginning). We can recheck this.


There are a couple of design issues with this class.

# performance

A static jkeel instance is created at application load time and kept around for the entire lifetime of the client app.

This could be improved with a lazy pattern.

Furthermore, jkeel holds hashmaps of every language in memory at all times. Why keep German loaded if only English is used?
This could ad well be mitigated using a lazy loading pattern for the language files, but even then, ideally only the used strings should be kept in memory. And even those needn't be in memory for ever. I might have used some string in the welcome page or some dialog. Why keep it around after that?
I suggest taking a look at the LoadingCache class from guava.

# style

I do not see the reason for misusing the exception mechanism as control flow when loading a language. This is unnecessarily complex and confusing.

O.


we can delete it


Please do not make it triggered when I make it not triggered.


Awesome!


Why no accessor for softlist entry names?  This makes saving hiscore entries for software and loading cheat files much more complex.


The imports and commented code in MainActivity will be re-added before a merge into master happens.


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/1f4bdb54-fa86-4e06-9530-474d644547f3 "InterConnectDemo-0306"): [Jenkins](http://localhost:4080/job/WeatherAppJinfang-0306 "weather-InterConnectDemo-0306") deployed [weather-InterConnectDemo-0306](https://github.com/jinfangchen/weather-InterConnectDemo-0306/releases/tag/deploy-ibm-yp-us-south-jichen-us.ibm.com-staging-20170505-213601 "deploy-ibm-yp-us-south-jichen-us.ibm.com-staging-20170505-213601") to [staging](https://console.ng.bluemix.net/apps/e14ca4b2-1d88-4eb9-b991-fab475fc4b43 "ibm:yp:us-south:jichen@us.ibm.com:staging"), including this commit


Wotlk has wrong aura. Mob starts out with different faction and is changed mid script. The whole script as was merged in TBC branch 1:1 models a video made by @Grz3s from retail.

https://github.com/cmangos/mangos-wotlk/commit/70c8c8320212a525d67536289375578d424e7895#diff-3b309049a6f7789c88c6e1bea7301b82R142

here its added to events

eventData.summonedMagrami.push_back(pCreature->GetObjectGuid());


TeamCity libpalaso :: fixing-to-fix-palaso-linux64-masterContinuous [Build 4.0.23.dbed79e2fed509172f97165f2a24de07f523019e](http://build.palaso.org/viewLog.html?buildId=90254&buildTypeId=JasonHatesMono) outcome was **FAILURE**
Summary: Exit code 5 Build time: 00:08:23


Ah. Unfortunately, AndroidKeyStore doesn't support Edd25519, and I don't have any concrete plans to add it. I'll note this as a use case to justify its addition.

Until then, I think you'll get more security with hardware-backed RSA keys + SHA1 than with software-only Edd25519 keys.


"you need to use a recent enough version of Cloudera Distribution of Apache Spark 2 release 1 or later" is repetitive -- either "you need to use Cloudera Distribution of Apache Spark 2 release 1 or later" (my preference) or "you need to use a recent enough version of Cloudera Distribution of Apache Spark 2"


<img width="1066" alt="screen shot 2017-05-05 at 2 38 26 pm" src="https://cloud.githubusercontent.com/assets/11221489/25765193/979ba684-31a0-11e7-8d00-e96da7b34579.png">


I would rename this to conformFlowsToPipeline. Unless you intend it to work with any OFMessage


This turned out to be unnecessary - it seems to derive scaling properly from pixmap scale already.


<img width="1066" alt="screen shot 2017-05-05 at 2 39 48 pm" src="https://cloud.githubusercontent.com/assets/11221489/25765230/c8a7fda4-31a0-11e7-8e2c-e5752bef52bd.png">


ditto


I would definitely prefer using primitives in internals like here - no need to generate GC pressure for no good reason. Looking at this particular piece of code however, should we be concerned about possible visibility guarantees ? That applies to the previous version as well - if the success / error can be called asynchronously, from a different thread I assume, how come access to start / stopWatch is not synchronized in any way ?