[R/helper_funs.R:338:7:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/helper_funs.R#L338) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  if ((do_gc >= 1) & (do_gc < 2)) {
      ^
```
[R/sperrorest_error.R:3:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_error.R#L3) *style:* **Lines should not be more than 80 characters.**
```r
#' @description Calculate a variety of accuracy measures from observations and predictions
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sperrorest_error.R:95:18:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_error.R#L95) *warning:* **no visible global function definition for ‘prediction’**
```r
      predobj <- prediction(pred, obs)
                 ^~~~~~~~~~
```
[R/sperrorest_error.R:96:16:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_error.R#L96) *warning:* **no visible global function definition for ‘performance’**
```r
      auroc <- performance(predobj, measure = "auc")@y.values[[1]]
               ^~~~~~~~~~~
```
[R/sperrorest_error.R:146:28:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_error.R#L146) *style:* **Place a space before left parenthesis, except in a function call.**
```r
                mse = mean((obs - pred) ^ 2), mad = mad(obs - pred),
                           ^
```
[R/sperrorest_misc.R:470:13:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_misc.R#L470) *warning:* **no visible global function definition for ‘validate.resampling’**
```r
  stopifnot(validate.resampling(object))
            ^~~~~~~~~~~~~~~~~~~
```
[R/sperrorest_misc.R:575:27:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_misc.R#L575) *warning:* **no visible binding for global variable ‘validate.resampling’**
```r
  valid <- sapply(object, validate.resampling)
                          ^~~~~~~~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:68:20:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L68) *warning:* **no visible global function definition for ‘as.resampling’**
```r
      resampler <- as.resampling(resampler)
                   ^~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:73:19:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L73) *warning:* **no visible global function definition for ‘as.represampling’**
```r
    resampling <- as.represampling(resampling)
                  ^~~~~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:150:15:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L150) *warning:* **no visible global function definition for ‘as.represampling’**
```r
    repres <- as.represampling(repres)
              ^~~~~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:198:12:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L198) *warning:* **no visible global function definition for ‘as.resampling’**
```r
    fac <- as.resampling(fac)
           ^~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:205:17:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L205) *warning:* **no visible global function definition for ‘as.represampling’**
```r
    represmp <- as.represampling(represmp)
                ^~~~~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:459:40:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L459) *style:* **Put spaces around all infix operators.**
```r
      r <- phi[as.character(cnt)] * 180/pi
                                      ~^~
```
[R/sperrorest_resampling.R:472:31:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L472) *style:* **Put spaces around all infix operators.**
```r
      x_delta <- diff(x_range)/nsplit[1]
                             ~^~
```
[R/sperrorest_resampling.R:473:31:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L473) *style:* **Put spaces around all infix operators.**
```r
      y_delta <- diff(y_range)/nsplit[2]
                             ~^~
```
[R/sperrorest_resampling.R:494:7:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L494) *style:* **Variable or function name should be snake_case.**
```r
      x.split <- seq(x_range[1], x_range[2], length = my_nsplit[1] + 1)
      ^~~~~~~
```
[R/sperrorest_resampling.R:495:7:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L495) *style:* **Variable or function name should be snake_case.**
```r
      y.split <- seq(y_range[1], y_range[2], length = my_nsplit[2] + 1)
      ^~~~~~~
```
[R/sperrorest_resampling.R:497:7:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L497) *style:* **Variable or function name should be snake_case.**
```r
      x.split <- seq(x_range[1], x_range[2] + x_delta, by = x_delta)
      ^~~~~~~
```
[R/sperrorest_resampling.R:498:7:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L498) *style:* **Variable or function name should be snake_case.**
```r
      y.split <- seq(y_range[1], y_range[2] + y_delta, by = y_delta)
      ^~~~~~~
```
[R/sperrorest_resampling.R:520:47:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L520) *warning:* **no visible global function definition for ‘as.tilename’**
```r
          tile[sel_x & sel_y] <- as.character(as.tilename(c(ix, iy)))
                                              ^~~~~~~~~~~
```
[R/sperrorest_resampling.R:527:16:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L527) *warning:* **no visible global function definition for ‘get_small_tiles’**
```r
    s_tiles <- get_small_tiles(tile, min_n = min_n, min_frac = min_frac)
               ^~~~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:559:15:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L559) *warning:* **no visible global function definition for ‘as.resampling’**
```r
      tile <- as.resampling(tile)
              ^~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:652:18:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L652) *style:* **Put spaces around all infix operators.**
```r
      p <- x$size/sum(x$size)
                ~^~
```
[R/sperrorest_resampling.R:653:23:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L653) *style:* **Put spaces around all infix operators.**
```r
      return(1 - sum(p^2))
                     ~^~
```
[R/sperrorest_resampling.R:666:15:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L666) *warning:* **no visible global function definition for ‘as.resampling’**
```r
      tile <- as.resampling(tile)
              ^~~~~~~~~~~~~
```
[R/sperrorest_resampling.R:671:19:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest_resampling.R#L671) *warning:* **no visible global function definition for ‘as.represampling’**
```r
    resampling <- as.represampling(resampling)
                  ^~~~~~~~~~~~~~~~
```
[R/sperrorest.R:551:9:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L551) *warning:* **no visible global function definition for ‘plan’, Did you mean 'lag'?**
```r
        plan(par_args$par_option, workers = par_args$par_units)
        ^~~~
```
[R/sperrorest.R:554:9:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L554) *warning:* **no visible global function definition for ‘plan’, Did you mean 'lag'?**
```r
        plan(par_args$par_option, workers = par_args$par_units)
        ^~~~
```
[R/sperrorest.R:599:5:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L599) *warning:* **no visible global function definition for ‘registerDoFuture’**
```r
    registerDoFuture()
    ^~~~~~~~~~~~~~~~
```
[R/sperrorest.R:608:13:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L608) *warning:* **no visible global function definition for ‘makeCluster’**
```r
      cl <- makeCluster(availableCores(), outfile = out_progress, ...)
            ^~~~~~~~~~~
```
[R/sperrorest.R:608:25:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L608) *warning:* **no visible global function definition for ‘availableCores’**
```r
      cl <- makeCluster(availableCores(), outfile = out_progress, ...)
                        ^~~~~~~~~~~~~~
```
[R/sperrorest.R:609:7:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L609) *warning:* **no visible global function definition for ‘plan’, Did you mean 'lag'?**
```r
      plan(cluster, workers = cl)
      ^~~~
```
[R/sperrorest.R:609:12:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L609) *warning:* **no visible binding for global variable ‘cluster’**
```r
      plan(cluster, workers = cl)
           ^~~~~~~
```
[R/sperrorest.R:622:13:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L622) *warning:* **no visible global function definition for ‘makeCluster’**
```r
      cl <- makeCluster(par_args$par_units, outfile = out_progress, ...)
            ^~~~~~~~~~~
```
[R/sperrorest.R:623:7:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L623) *warning:* **no visible global function definition for ‘plan’, Did you mean 'lag'?**
```r
      plan(cluster, workers = cl)
      ^~~~
```
[R/sperrorest.R:623:12:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L623) *warning:* **no visible binding for global variable ‘cluster’**
```r
      plan(cluster, workers = cl)
           ^~~~~~~
```
[R/sperrorest.R:634:7:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L634) *warning:* **no visible global function definition for ‘registerDoFuture’**
```r
      registerDoFuture()
      ^~~~~~~~~~~~~~~~
```
[R/sperrorest.R:635:7:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L635) *warning:* **no visible global function definition for ‘plan’, Did you mean 'lag'?**
```r
      plan(sequential)
      ^~~~
```
[R/sperrorest.R:635:12:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L635) *warning:* **no visible binding for global variable ‘sequential’**
```r
      plan(sequential)
           ^~~~~~~~~~
```
[R/sperrorest.R:646:47:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L646) *warning:* **local variable ‘pooled_pred_train’ assigned but may not be used**
```r
                          pooled_obs_train <- pooled_pred_train <- c()
                                              ^~~~~~~~~~~~~~~~~
```
[R/sperrorest.R:647:46:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L647) *warning:* **local variable ‘pooled_pred_test’ assigned but may not be used**
```r
                          pooled_obs_test <- pooled_pred_test <- c()
                                             ^~~~~~~~~~~~~~~~
```
[R/sperrorest.R:651:25:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L651) *warning:* **local variable ‘current_impo’ assigned but may not be used**
```r
                        current_impo <- resamp[[i]]
                        ^~~~~~~~~~~~
```
[R/sperrorest.R:656:42:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L656) *warning:* **no visible global function definition for ‘map’, Did you mean 'mad'?**
```r
                          current_res <- map(resamp[[i]], unclass)
                                         ^~~
```
[R/sperrorest.R:780:17:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/sperrorest.R#L780) *warning:* **no visible global function definition for ‘transfer_parallel_output’**
```r
  my_res_mod <- transfer_parallel_output(my_res, res, impo, pooled_error)
                ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/summary_functions.R:52:37:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L52) *style:* **Variable or function name should be snake_case.**
```r
                                    na.rm = TRUE, ...) {
                                    ^~~~~
```
[R/summary_functions.R:56:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L56) *style:* **Lines should not be more than 80 characters.**
```r
      err <- lapply(err, function(x) t(sapply(x, function(y) data.frame(train = y$train,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/summary_functions.R:57:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L57) *style:* **Lines should not be more than 80 characters.**
```r
        test = y$test, distance = ifelse(any(names(y) == "distance"), y$distance,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/summary_functions.R:71:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L71) *style:* **Lines should not be more than 80 characters.**
```r
      err <- data.frame(mean = apply(err, 2, function(y) mean(unlist(y), na.rm = na.rm)),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/summary_functions.R:72:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L72) *style:* **Lines should not be more than 80 characters.**
```r
        sd = apply(err, 2, function(y) sd(unlist(y), na.rm = na.rm)), median = apply(err,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/summary_functions.R:78:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L78) *style:* **Lines should not be more than 80 characters.**
```r
      err <- lapply(err, function(x) t(sapply(x, function(y) data.frame(train = y$train,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/summary_functions.R:79:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L79) *style:* **Lines should not be more than 80 characters.**
```r
        test = y$test, distance = ifelse(any(names(y) == "distance"), y$distance,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/summary_functions.R:84:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L84) *style:* **Lines should not be more than 80 characters.**
```r
      err <- lapply(err, function(x) apply(x, 2, function(y) weighted.mean(unlist(y),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/summary_functions.R:91:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L91) *style:* **Lines should not be more than 80 characters.**
```r
      err <- data.frame(mean = sapply(err, mean), sd = sapply(err, sd), median = sapply(err,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/summary_functions.R:103:59:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L103) *style:* **Variable or function name should be snake_case.**
```r
summary.sperrorestreperror <- function(object, level = 0, na.rm = TRUE, ...) {
                                                          ^~~~~
```
[R/summary_functions.R:130:61:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L130) *style:* **Variable or function name should be snake_case.**
```r
summary.sperrorestimportance <- function(object, level = 0, na.rm = TRUE,
                                                            ^~~~~
```
[R/summary_functions.R:133:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L133) *style:* **Lines should not be more than 80 characters.**
```r
  arrdimnames <- list(names(object), names(object[[1]]), rownames(object[[1]][[1]]),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/summary_functions.R:146:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L146) *style:* **Lines should not be more than 80 characters.**
```r
      arr <- data.frame(mean = apply(arr, c(2, 3), mean, na.rm = na.rm), sd = apply(arr,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/summary_functions.R:149:12:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L149) *style:* **Opening curly braces should never go on their own line and should always be followed by a new line.**
```r
    } else { # when does this happen?
           ^
```
[R/summary_functions.R:151:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L151) *style:* **Lines should not be more than 80 characters.**
```r
      arr <- data.frame(mean = apply(arr, 2, mean, na.rm = na.rm), sd = apply(arr, # nocov
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/summary_functions.R:152:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L152) *style:* **Lines should not be more than 80 characters.**
```r
        2, sd, na.rm = na.rm), median = apply(arr, 2, median, na.rm = na.rm), # nocov
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/summary_functions.R:272:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L272) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/summary_functions.R:273:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L273) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/summary_functions.R:274:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/R/summary_functions.R#L274) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-helper-funs.R:18:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L18) *style:* **Lines should not be more than 80 characters.**
```r
  runfolds_single <- runfolds(j = 1, data = ecuador, current_sample = current_sample,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:19:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L19) *style:* **Lines should not be more than 80 characters.**
```r
                              formula = slides ~ dem + slope + hcurv + vcurv + log.carea + cslope,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:20:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L20) *style:* **Lines should not be more than 80 characters.**
```r
                              model_args = list(family = "binomial"), do_try = FALSE, model_fun = glm,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:21:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L21) *style:* **Lines should not be more than 80 characters.**
```r
                              error_fold = TRUE, error_rep = TRUE, imp_permutations = 2,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:22:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L22) *style:* **Lines should not be more than 80 characters.**
```r
                              imp.variables = c("dem", "slope", "hcurv", "vcurv", "log.carea", "cslope"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:23:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L23) *style:* **Lines should not be more than 80 characters.**
```r
                              err_train = TRUE, importance = TRUE, current_res = current_res,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:24:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L24) *style:* **Lines should not be more than 80 characters.**
```r
                              pred.args = list(type = "response"), response = "slides", par_cl = 2,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:25:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L25) *style:* **Lines should not be more than 80 characters.**
```r
                              coords = c("x", "y"), progress = 1, pooled_obs_train = c(),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:44:11:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L44) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
          ^
```
[tests/testthat/test-helper-funs.R:44:22:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L44) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                     ^
```
[tests/testthat/test-helper-funs.R:44:39:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L44) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                      ^
```
[tests/testthat/test-helper-funs.R:44:50:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L44) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                                 ^
```
[tests/testthat/test-helper-funs.R:50:63:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L50) *style:* **Commas should always have a space after.**
```r
    if (!is.null(fac)) pred <- majority_filter(pred, newdata[,fac])
                                                              ^
```
[tests/testthat/test-helper-funs.R:58:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L58) *style:* **Lines should not be more than 80 characters.**
```r
  runfolds_single <- runfolds(j = 1, data = maipo, current_sample = current_sample,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:60:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L60) *style:* **Lines should not be more than 80 characters.**
```r
                              do_try = FALSE, model_fun = lda, pred_fun = lda_predfun,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:61:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L61) *style:* **Lines should not be more than 80 characters.**
```r
                              error_fold = TRUE, error_rep = TRUE, pred.args = list(fac = "field"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:62:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L62) *style:* **Lines should not be more than 80 characters.**
```r
                              err_train = TRUE, importance = FALSE, current_res = current_sample,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:64:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L64) *style:* **Lines should not be more than 80 characters.**
```r
                              coords = c("x", "y"), progress = 1, pooled_obs_train = c(),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:80:71:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L80) *style:* **Commas should always have a space after.**
```r
  mypred_rpart <- function(object, newdata) predict(object, newdata)[,2]
                                                                      ^
```
[tests/testthat/test-helper-funs.R:82:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L82) *style:* **Lines should not be more than 80 characters.**
```r
  runfolds_single <- runfolds(j = 1, data = ecuador, current_sample = current_sample,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:83:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L83) *style:* **Lines should not be more than 80 characters.**
```r
                              formula = slides ~ dem + slope + hcurv + vcurv + log.carea + cslope,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:85:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L85) *style:* **Lines should not be more than 80 characters.**
```r
                              error_fold = TRUE, error_rep = TRUE, imp_permutations = 2, pred_fun = mypred_rpart,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:87:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L87) *style:* **Lines should not be more than 80 characters.**
```r
                              imp.variables = c("dem", "slope", "hcurv", "vcurv", "log.carea", "cslope"),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:88:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L88) *style:* **Lines should not be more than 80 characters.**
```r
                              err_train = TRUE, importance = TRUE, current_res = current_res,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:90:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L90) *style:* **Lines should not be more than 80 characters.**
```r
                              coords = c("x", "y"), progress = 1, pooled_obs_train = c(),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:121:63:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L121) *style:* **Commas should always have a space after.**
```r
    if (!is.null(fac)) pred <- majority_filter(pred, newdata[,fac])
                                                              ^
```
[tests/testthat/test-helper-funs.R:142:3:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L142) *style:* **Variable or function name should be snake_case.**
```r
  imp.one.rep <- readRDS("inst/test-objects/imp.one.rep.rda")
  ^~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:165:3:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L165) *style:* **Variable or function name should be snake_case.**
```r
  imp.one.rep <- readRDS("inst/test-objects/imp.one.rep.rda")
  ^~~~~~~~~~~
```
[tests/testthat/test-helper-funs.R:184:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-helper-funs.R#L184) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-resample.R:10:52:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-resample.R#L10) *style:* **Only use double-quotes.**
```r
                              param = list(strat = 'slides', nstrat = 100))
                                                   ^~~~~~~~
```
[tests/testthat/test-resample.R:12:32:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-resample.R#L12) *style:* **Only use double-quotes.**
```r
  expect_equal(sum(d$slides == 'TRUE'), 100) # == 100
                               ^~~~~~
```
[tests/testthat/test-resample.R:20:55:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-resample.R#L20) *style:* **Only use double-quotes.**
```r
  d <- resample_uniform(ecuador, param = list(strat = 'slides', n = 400))
                                                      ^~~~~~~~
```
[tests/testthat/test-resample.R:28:55:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-resample.R#L28) *style:* **Only use double-quotes.**
```r
  d <- resample_uniform(ecuador, param = list(strat = 'slides', n = 200))
                                                      ^~~~~~~~
```
[tests/testthat/test-sperrorest-resampling.R:17:48:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-resampling.R#L17) *style:* **Only use double-quotes.**
```r
  parti <- partition_cv_strat(ecuador, strat = 'slides', nfold = 5,
                                               ^~~~~~~~
```
[tests/testthat/test-sperrorest-resampling.R:28:44:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-resampling.R#L28) *style:* **Only use double-quotes.**
```r
  parti <- partition_factor(ecuador, fac = 'zclass')
                                           ^~~~~~~~
```
[tests/testthat/test-sperrorest-resampling.R:37:47:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-resampling.R#L37) *style:* **Only use double-quotes.**
```r
  parti <- partition_factor_cv(ecuador, fac = 'zclass', nfold = 5)
                                              ^~~~~~~~
```
[tests/testthat/test-sperrorest-resampling.R:98:63:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-resampling.R#L98) *style:* **Commas should always have a space after.**
```r
  parti <- represampling_tile_bootstrap(ecuador, nsplit = c(4,2),
                                                              ^
```
[tests/testthat/test-sperrorest-resampling.R:107:65:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-resampling.R#L107) *style:* **Commas should always have a space after.**
```r
  parti <- represampling_kmeans_bootstrap(ecuador, nsplit = c(4,2),
                                                                ^
```
[tests/testthat/test-sperrorest-resampling.R:133:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-resampling.R#L133) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-sperrorest-resampling.R:134:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-resampling.R#L134) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[tests/testthat/test-sperrorest-summary.R:213:3:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-summary.R#L213) *style:* **Variable or function name should be snake_case.**
```r
  smry.out <- summary(out)
  ^~~~~~~~
```
[tests/testthat/test-sperrorest-summary.R:231:3:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-summary.R#L231) *style:* **Variable or function name should be snake_case.**
```r
  smry.out <- summary(out)
  ^~~~~~~~
```
[tests/testthat/test-sperrorest-summary.R:241:3:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-summary.R#L241) *style:* **Variable or function name should be snake_case.**
```r
  lda.predfun <- function(object, newdata, fac = NULL) {
  ^~~~~~~~~~~
```
[tests/testthat/test-sperrorest-summary.R:247:5:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-summary.R#L247) *style:* **Variable or function name should be snake_case.**
```r
    majority.filter <- function(x, fac) {
    ^~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest-summary.R:249:11:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-summary.R#L249) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
          ^
```
[tests/testthat/test-sperrorest-summary.R:249:22:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-summary.R#L249) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                     ^
```
[tests/testthat/test-sperrorest-summary.R:249:39:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-summary.R#L249) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                      ^
```
[tests/testthat/test-sperrorest-summary.R:249:50:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-summary.R#L249) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                                 ^
```
[tests/testthat/test-sperrorest-summary.R:271:57:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-summary.R#L271) *style:* **Commas should always have a space after.**
```r
  out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                        ^
```
[tests/testthat/test-sperrorest-summary.R:279:3:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest-summary.R#L279) *style:* **Variable or function name should be snake_case.**
```r
  smry.out <- summary(out)
  ^~~~~~~~
```
[tests/testthat/test-sperrorest.R:46:67:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L46) *style:* **Commas should always have a space after.**
```r
            out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                                  ^
```
[tests/testthat/test-sperrorest.R:60:67:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L60) *style:* **Commas should always have a space after.**
```r
            out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                                  ^
```
[tests/testthat/test-sperrorest.R:74:67:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L74) *style:* **Commas should always have a space after.**
```r
            out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                                  ^
```
[tests/testthat/test-sperrorest.R:95:13:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L95) *style:* **Variable or function name should be snake_case.**
```r
            mypred.rpart <- function(object, newdata) predict(object,
            ^~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:101:13:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L101) *style:* **Variable or function name should be snake_case.**
```r
            mypred.rpart <- function(object, newdata) predict(object,
            ^~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:102:73:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L102) *style:* **Commas should always have a space after.**
```r
                                                              newdata)[,2]
                                                                        ^
```
[tests/testthat/test-sperrorest.R:103:13:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L103) *style:* **Variable or function name should be snake_case.**
```r
            par.nsp.res <- sperrorest(data = ecuador, formula = fo,
            ^~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:135:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L135) *style:* **Lines should not be more than 80 characters.**
```r
                                 par_args = list(par_mode = "foreach", par_units = 2),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:141:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L141) *style:* **Lines should not be more than 80 characters.**
```r
test_that("sperrorest() variable importance with error_rep = F and error_fold = T", {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:226:21:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L226) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                  x[ fac == lev ] <- majority(x[ fac == lev ])
                    ^
```
[tests/testthat/test-sperrorest.R:226:32:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L226) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                  x[ fac == lev ] <- majority(x[ fac == lev ])
                               ^
```
[tests/testthat/test-sperrorest.R:226:49:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L226) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                  x[ fac == lev ] <- majority(x[ fac == lev ])
                                                ^
```
[tests/testthat/test-sperrorest.R:226:60:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L226) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                  x[ fac == lev ] <- majority(x[ fac == lev ])
                                                           ^
```
[tests/testthat/test-sperrorest.R:232:73:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L232) *style:* **Commas should always have a space after.**
```r
              if (!is.null(fac)) pred <- majority_filter(pred, newdata[,fac])
                                                                        ^
```
[tests/testthat/test-sperrorest.R:247:67:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L247) *style:* **Commas should always have a space after.**
```r
            out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                                  ^
```
[tests/testthat/test-sperrorest.R:259:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L259) *style:* **Lines should not be more than 80 characters.**
```r
            expect_equal(names(out$error_rep)[[1]], "train.error") # check for train.error existence
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:262:67:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L262) *style:* **Commas should always have a space after.**
```r
            out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                                  ^
```
[tests/testthat/test-sperrorest.R:267:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L267) *style:* **Lines should not be more than 80 characters.**
```r
                              par_args = list(par_mode = "future", par_units = 2),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:275:67:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L275) *style:* **Commas should always have a space after.**
```r
            out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                                  ^
```
[tests/testthat/test-sperrorest.R:280:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L280) *style:* **Lines should not be more than 80 characters.**
```r
                              par_args = list(par_mode = "future", par_units = 2),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:303:11:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L303) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
          ^
```
[tests/testthat/test-sperrorest.R:303:22:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L303) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                     ^
```
[tests/testthat/test-sperrorest.R:303:39:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L303) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                      ^
```
[tests/testthat/test-sperrorest.R:303:50:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L303) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                                 ^
```
[tests/testthat/test-sperrorest.R:309:63:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L309) *style:* **Commas should always have a space after.**
```r
    if (!is.null(fac)) pred <- majority_filter(pred, newdata[,fac])
                                                              ^
```
[tests/testthat/test-sperrorest.R:323:57:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L323) *style:* **Commas should always have a space after.**
```r
  out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                        ^
```
[tests/testthat/test-sperrorest.R:335:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L335) *style:* **Lines should not be more than 80 characters.**
```r
  expect_equal(names(out$error_rep)[[1]], "train.error") # check for train.error existence
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:339:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L339) *style:* **Lines should not be more than 80 characters.**
```r
test_that("output length of list is correct for error_rep = TRUE and error_fold  = TRUE
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:348:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L348) *style:* **Lines should not be more than 80 characters.**
```r
            mypred.rpart <- function(object, newdata) predict(object, newdata)[, 2]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:348:13:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L348) *style:* **Variable or function name should be snake_case.**
```r
            mypred.rpart <- function(object, newdata) predict(object, newdata)[, 2]
            ^~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:353:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L353) *style:* **Lines should not be more than 80 characters.**
```r
            mypred.rpart <- function(object, newdata) predict(object, newdata)[,2]
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:353:13:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L353) *style:* **Variable or function name should be snake_case.**
```r
            mypred.rpart <- function(object, newdata) predict(object, newdata)[,2]
            ^~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:353:81:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L353) *style:* **Commas should always have a space after.**
```r
            mypred.rpart <- function(object, newdata) predict(object, newdata)[,2]
                                                                                ^
```
[tests/testthat/test-sperrorest.R:354:13:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L354) *style:* **Variable or function name should be snake_case.**
```r
            par.nsp.res <- sperrorest(data = ecuador, formula = fo,
            ^~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:355:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L355) *style:* **Lines should not be more than 80 characters.**
```r
                                      model_fun = rpart, model_args = list(control = ctrl),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:359:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L359) *style:* **Lines should not be more than 80 characters.**
```r
                                      smp_args = list(repetition = 1:2, nfold = 2),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:360:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L360) *style:* **Lines should not be more than 80 characters.**
```r
                                      par_args = list(par_mode = "future", par_units = 2),
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:366:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L366) *style:* **Lines should not be more than 80 characters.**
```r
# par_mode = "apply" variable importance Tue Feb 21 22:15:41 2017 ------------------------------
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:387:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L387) *style:* **Lines should not be more than 80 characters.**
```r
  expect_equal(names(nspres$error_rep)[[1]], "train.auroc") # check for train.auroc for binary response
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:388:1:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L388) *style:* **Lines should not be more than 80 characters.**
```r
  expect_equal(class(nspres$importance[[1]][[1]]), "data.frame") # check for importance object
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:460:11:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L460) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
          ^
```
[tests/testthat/test-sperrorest.R:460:22:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L460) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                     ^
```
[tests/testthat/test-sperrorest.R:460:39:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L460) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                      ^
```
[tests/testthat/test-sperrorest.R:460:50:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L460) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
        x[ fac == lev ] <- majority(x[ fac == lev ])
                                                 ^
```
[tests/testthat/test-sperrorest.R:466:63:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L466) *style:* **Commas should always have a space after.**
```r
    if (!is.null(fac)) pred <- majority_filter(pred, newdata[,fac])
                                                              ^
```
[tests/testthat/test-sperrorest.R:476:3:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L476) *style:* **Variable or function name should be snake_case.**
```r
  res.lda.sp.par <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
  ^~~~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:476:68:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L476) *style:* **Commas should always have a space after.**
```r
  res.lda.sp.par <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                                   ^
```
[tests/testthat/test-sperrorest.R:528:67:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L528) *style:* **Commas should always have a space after.**
```r
            out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                                  ^
```
[tests/testthat/test-sperrorest.R:543:67:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L543) *style:* **Commas should always have a space after.**
```r
            out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                                  ^
```
[tests/testthat/test-sperrorest.R:556:67:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L556) *style:* **Commas should always have a space after.**
```r
            out <- sperrorest(fo, data = maipo, coords = c("utmx","utmy"),
                                                                  ^
```
[tests/testthat/test-sperrorest.R:578:13:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L578) *style:* **Variable or function name should be snake_case.**
```r
            mypred.rpart <- function(object, newdata) predict(object,
            ^~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:584:13:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L584) *style:* **Variable or function name should be snake_case.**
```r
            mypred.rpart <- function(object, newdata) predict(object,
            ^~~~~~~~~~~~
```
[tests/testthat/test-sperrorest.R:585:73:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L585) *style:* **Commas should always have a space after.**
```r
                                                              newdata)[,2]
                                                                        ^
```
[tests/testthat/test-sperrorest.R:586:13:](https://github.com/pat-s/sperrorest/blob/8ad0c18f62f47d2b231dc109828cbd4bcc51e81c/tests/testthat/test-sperrorest.R#L586) *style:* **Variable or function name should be snake_case.**
```r
            par.nsp.res <- sperrorest(data = ecuador, formula = fo,
            ^~~~~~~~~~~
```


Gggr. Sorry. Thought I was pushing to my fork.

Here's the reason for the change:
The function `update_until()` will call `update_frac()` even if `n_steps - int(n_steps)` is 0.0. It only happens if `int(n_steps)` > 0. With anuga, it led to `update()` being called twice for the same timestep:

> Time = 0.0000, delta t = 0.01031304, steps=1 (0s)
> Time = 5.0000, delta t in [0.00757261, 0.01031304], steps=535 (0s)
> **Time = 10.0000, delta t = 0.01030597, steps=486 (0s)**
> **Time = 10.0000, delta t = 0.01030597, steps=1 (0s)**
> Time = 15.0000, delta t = 0.01030597, steps=486 (0s)
> **Time = 20.0000, delta t = 0.01030597, steps=486 (0s)**
> **Time = 20.0000, delta t = 0.01030597, steps=1 (0s)**

It's not obvious that the same thing is happening with the example diffusion model because there is no internal tracking of time but it still advances one too many times.


Does this return need to be inside an else?  The first two `if` statements return `false` if their expectations are met.  Otherwise, you return true.  Instead, could this be:
```
if(enteredCode !== correctCode) {
  return false
}

if(new Date(currentDate) > new Date(expirationDate)) {
  return false
}

return true
```

I found your profile on Turing and was looking through your code :-)


@gcrabbe : o `else` só printava connection closed mas tocava td como se nada tivesse acontecido


Hm, I am a little suspicious of this `.join`.

The helper thread executes function `f` supplied by the user. That means that `f` can very well panic and kill the helper thread. And this will cause a panic in `Drop` here, and panic in drops can escalate to abort.


A lost Git ref, I assume a "push -f" from you.


You are right. Nobody caught this for 3 years...
Fixed in PHP-7.0 and above.


@tych0 this may also need a change in documentation: https://docs.docker.com/engine/installation/linux/linux-postinstall/


There's a problem with this line.


I don't disagree but was just thinking what'll require least effort. There could be a _CONTRIBUTING_ section in the readme or a dedicated file with more info about how to get started and all...


delete!!!


Sorry, my fault, everything seems fine. I was confused by the difference in line counts.


There will probably be a discussion about logging.
I feel like everything should be logged in the traditional ROS way (no explicit file like roslaunch.auth).
Moreover using log levels would probably be important, with all the expected things to be in the verbose/debug, the bad clients requests being as warnings, etc


[![Deploy](https://www.herokucdn.com/deploy/button.svg)](https://heroku.com/deploy?template=https://github.com/Logic-gate/haste-server)

Okay, I tried the redis option--deploying with the redis addon--however, I opted for file type due to the need to add `config-vars` https://devcenter.heroku.com/articles/config-vars which would require some changes to haste.

Also, for deployemnt of heroku, the npm engine needs an upgrade --tested on `1.4.28`

The deploy button above, uses my fork npm engine `1.4.28`


cleanup


wow, didn't know it could affect other cloners :(

thanks for the info.


hey spacehuhn im having issues, everything worked fine when i used your menus and what not it all worked but in the settings of your menus was an option to hide the ssid and now i cant find it in the wifi searches to change anything which is becoming quite frustrating. i have tried reflashing and resetting and what not and im having no luck with anything. please let me know how to fix this. thank you


I know they have very few comments, but that would be pretty good (also easing the pull request process)


I strongly suggest that you don't do this in a model callback. Generally you should keep models focused on storing and exposing data. You may run into problems anywhere else that you're instantiating models outside of your web application (e.g. tests, console, import scripts, etc.).

It may seem duplicative, but I suggest concretely broadcasting in the places where you want to create a message and broadcast. This will save you some common pain down the road.

(this is a super common trap that bites people later on down the line)


First rule of fightclub^Hgithub:  you don't question @jjallaire's code.


Why use a global instead of a self.count ?
This looks pretty ugly ;)


## Comentario del commit!


It's explained in the Wiki FAQ.


@tyzhang1993: I pushed a fix to this code that instead used const references to vector. There is no need to copy this data here and it should be forced to be constant.


Yeah, for example on linux, on [this line](https://github.com/alexcrichton/jobserver-rs/blob/master/src/lib.rs#L588) we could break if the receive `Err(Disconnected)`.


Beyond1Airloop (mjwitte) - x86_64-MacOS-10.9-clang: OK (2491 of 2492 tests passed, 596 test warnings)

Messages:

 * 596 tests had: AUD diffs.
 * 523 tests had: BND diffs.
 * 10 tests had: EIO diffs.
 * 2 tests had: ESO small diffs.
 * 2 tests had: Table small diffs.
 * 2 tests had: RDD diffs.

Failures:

EnergyPlusFixture Test Summary
 * Passed: 468
 * SEGFAULT: 1

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.96%25-yellow.png)


@tych0 when you get the chance can you open up a PR against https://github.com/docker/docker-ce-packaging

specifically, the patch can be applied to https://github.com/docker/docker-ce-packaging/blob/master/deb/common/docker-ce.postinst

i want to open up the PR to discussion with folks to discuss ramifications to documentation and such


I think the recent node-8 / npm-5 update (perhaps the auto-saving of packages with 'npm install') rewrites package.json according to standard style.  This causes a mismatch with the version in the repo.


Again not sure about the logging strategy, Seems like it should just be part of normal rosmaster logging.


Try to use Slf4j, in Lombok, there is a annotation @Slf4j.


On Tue, May 30, 2017 at 02:57:18PM -0700, Andrew Hsu wrote:
> @tych0 when you get the chance can you open up a PR against https://github.com/docker/docker-ce-packaging
>
> specifically, the patch can be applied to https://github.com/docker/docker-ce-packaging/blob/master/deb/common/docker-ce.postinst
>
> i want to open up the PR to discussion with folks to discuss ramifications to documentation and such

Sure, no problem. I'll send a PR shortly.

> --
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub:
> https://github.com/tych0/moby/commit/1eeecee2fe0427b1d861fee41d965992f5de3bb3#commitcomment-22335797


```
Warning: Current Git version is 1.8.5. Option "shallowFetch" is supported on Git >= 1.9.0.
```


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.412.eccd5d6b2226b7f4ecf93eb272325c6fefb3db44](http://build.palaso.org/viewLog.html?buildId=92306&buildTypeId=bt223) outcome was **FAILURE**
Summary: Compilation error: SIL.Core\SIL.Core.csproj (new); compilation error: BuildTaskTests\Palaso.BuildTask.Tests.Helper\Palaso.BuildTask.Tests.Helper.csproj (new) Build time: 00:00:28


import Test instead of writing the whole path


TeamCity libpalaso :: palaso-Linux64-lfmerge Continuous [Build 2.6.444.eccd5d6b2226b7f4ecf93eb272325c6fefb3db44](http://build.palaso.org/viewLog.html?buildId=92300&buildTypeId=PalasoTrusty64lfmergeContinuous) outcome was **FAILURE**
Summary: Exit code 134 (new) Build time: 00:01:29


Correction


nit: use Java convention. Try to avoid "if" without "{}"


144488793-Correct-surface-convection-calculation-6037 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2533 of 2533 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Ah right yes excellent point. I think the relevant unwrap is [this one](https://github.com/alexcrichton/jobserver-rs/commit/4c8a5985e32fa193350f988f6a09804e565f0448#diff-b4aea3e418ccdb71239b96952d9cddb6R581).

I think that business with `Err(Disconnected)` is also legit, I'll push up a fix.


Add more detail explanation on this project. Eg. Provide a wiki link to explain the rule of this game. How to start the problem, and etc.


@deeflorian can you please send me an email?


TeamCity libpalaso :: palaso-win64-master Continuous [Build 4.0.3.eccd5d6b2226b7f4ecf93eb272325c6fefb3db44](http://build.palaso.org/viewLog.html?buildId=92303&buildTypeId=Libpalaso_PalasoWin64masterContinuous) outcome was **UNKNOWN**
Summary: Canceled (Tests passed: 2964, ignored: 102; exit code 1 (new)) Build time: 00:05:17


oh right, forgot about Travis


I think we don't need the class at all. Just Child classes like EsfInvalidStateException would directly have the properties. For example would look like this to me:
public class EsfInvalidStateException: EsfException
{
  public EsfInvalidStateException()  { }

  public string Mapping { get; set; }
  public string Query { get; set; }
  public string Documents { get; set; }
}


TeamCity SayMore :: SayMore pull requests [Build *.*.31.bbe447da7845ef9b6a39fa50fabe442651ccaaf5](http://build.palaso.org/viewLog.html?buildId=92310&buildTypeId=SayMore_SayMorePullRequests) outcome was **FAILURE**
Summary: Failed to resolve artifact dependency Build time: 00:00:25


Ok I think https://github.com/alexcrichton/jobserver-rs/commit/51737cde90b44baf0e12a5b048cbced6e79a5ab7 should do the trick for these issues.


The following doc(s) have been deployed to the [2518bashp](https://2518bashp-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/upstream-updates](https://2518bashp-static-docs.pantheonsite.io/docs/upstream-updates)


Thanks for the heads up. Should be fixed.


144488793-Correct-surface-convection-calculation-6037 (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


![](https://github.trello.services/images/mini-trello-icon.png) [Mpage: Anesthesia](https://trello.com/c/6J4GTNBo/54-mpage-anesthesia)


This method is too long. Look at this  discussion:
https://stackoverflow.com/questions/611304/how-many-lines-of-code-should-a-function-procedure-method-have

Usually 10 to 20 lines in one method is preferable. When you have segments in the method, most probably your method could split to smaller functions.


I'm wondering if we need to differantiate between length validation and json parsing failures but I guess the message itself is enough.


TeamCity libpalaso :: palaso-linux64-master Continuous [Build 4.0.261.eccd5d6b2226b7f4ecf93eb272325c6fefb3db44](http://build.palaso.org/viewLog.html?buildId=92301&buildTypeId=Libpalaso_PalasoLinux64masterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3776, ignored: 111 Build time: 00:09:07


Note that this PR does not introduce them, they were there before.


Ovvero?


TeamCity libpalaso :: palaso-linux64-libpalaso-2.6 Continuous [Build 2.6.1455.eccd5d6b2226b7f4ecf93eb272325c6fefb3db44](http://build.palaso.org/viewLog.html?buildId=92304&buildTypeId=PalasoLinux64v26Cont) outcome was **FAILURE**
Summary: Exit code 134 (new) Build time: 00:00:10


ok


TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.289.eccd5d6b2226b7f4ecf93eb272325c6fefb3db44](http://build.palaso.org/viewLog.html?buildId=92299&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3798, ignored: 128 Build time: 00:09:43


TeamCity libpalaso :: palaso-linux64-libpalaso-3.1 Continuous [Build 3.1.415.eccd5d6b2226b7f4ecf93eb272325c6fefb3db44](http://build.palaso.org/viewLog.html?buildId=92308&buildTypeId=bt322) outcome was **FAILURE**
Summary: Exit code 134 (new) Build time: 00:00:08


TeamCity libpalaso :: palaso-linux64-libpalaso-2.6 Continuous [Build 2.6.1456.ee94cab7edf64639545c552e817a473cc33ed269](http://build.palaso.org/viewLog.html?buildId=92312&buildTypeId=PalasoLinux64v26Cont) outcome was **FAILURE**
Summary: Exit code 134 (new) Build time: 00:00:08


something


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.413.ee94cab7edf64639545c552e817a473cc33ed269](http://build.palaso.org/viewLog.html?buildId=92313&buildTypeId=bt223) outcome was **FAILURE**
Summary: Compilation error: SIL.Core\SIL.Core.csproj (new); compilation error: BuildTaskTests\Palaso.BuildTask.Tests.Helper\Palaso.BuildTask.Tests.Helper.csproj (new) Build time: 00:00:35


With Qt 5 builds OK.
With Qt4:
```
src/base/net/smtp.cpp: In member function ‘QString Net::Smtp::getCurrentDateTime() const’:
src/base/net/smtp.cpp:513:9: error: ‘%+05d’ directive output may be truncated writing between 5 and 10 bytes into a region of size 6 [-Werror=format-truncation=]
```
Have no idea why this did not pop up with Qt5.
Plus trivial changes:
```diff
diff --git a/src/gui/categoryfiltermodel.cpp b/src/gui/categoryfiltermodel.cpp
index ca6048d83..c04acd09b 100644
--- a/src/gui/categoryfiltermodel.cpp
+++ b/src/gui/categoryfiltermodel.cpp
@@ -217,7 +217,7 @@ QVariant CategoryFilterModel::data(const QModelIndex &index, int role) const
     }

     if ((index.column() == 0) && (role == Qt::DisplayRole)) {
-        return QString(QStringLiteral("%1 (%2)"))
+        return QString(QLatin1String("%1 (%2)"))
                 .arg(item->name()).arg(item->torrentsCount());
     }

diff --git a/src/gui/categoryfilterwidget.cpp b/src/gui/categoryfilterwidget.cpp
index 6e8952c8d..f8cfb17fd 100644
--- a/src/gui/categoryfilterwidget.cpp
+++ b/src/gui/categoryfilterwidget.cpp
@@ -239,7 +239,7 @@ void CategoryFilterWidget::addSubcategory()
     const QString subcat = askCategoryName();
     if (subcat.isEmpty()) return;

-    const QString category = QString(QStringLiteral("%1/%2")).arg(currentCategory()).arg(subcat);
+    const QString category = QString(QLatin1String("%1/%2")).arg(currentCategory()).arg(subcat);

     if (BitTorrent::Session::instance()->categories().contains(category))
         QMessageBox::warning(this, tr("Category exists")
```


Hello @miron-kuzniar Thank you for the test 🚀
Remember the review we had about false-positives? This test can could be improved to not pass on faulty printout, like the one having only empty lines. If you will implement it in `miron_counter` branch I'll review in the open pull request. Thank you ✨


Exactly. Though we can defer the actual implementation of the server-side logging or provide only a simplistic initial implementation


@cblappert: I'd like to know too. :-)


Ah, good catch! Thank you, @mperignon.


This is a new TestRepo


@fevangelista That's great idea! Thank you so much!
Actually, I only wanted the absolute value of the largest element, but I had the code in pci in order not to make the FCIIntegrals class too complicated.


Actually 'arity' is the correct word ;)


wsfdsafds


why that change ? This is probably a big deal for them.
To make work, unless it is really necessary for secureROS.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 4.0.290.ee94cab7edf64639545c552e817a473cc33ed269](http://build.palaso.org/viewLog.html?buildId=92320&buildTypeId=Libpalaso_PalasoWin32masterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3799, ignored: 127 Build time: 00:04:53


teste


@larham @melanieplageman @Chibin working with @cjcjameson here and we don't remember the specific logic around which fields are kept and which were removed. Was it based on our IDE giving us feedback about what variables were dead/alive?

For example, we remember the discussion about `_cpu_elapsed` being used but don't remember what the story is with `_p_metrics`. Similarly, we remember why `measures[]` was deleted but don't remember why `p_mem` or `p_memmax` were. `tstart` and `tduration` were semi-fuzzy -- the logic there was that queries_history keeps track of the overall time, and the iterators_history used to show the duration of an iterator, but those two measures aren't connected. So when we remove iterators_history, we don't need `tduration` and `tstart`


I agree. But logging.getLogger() is the ROS way. I just added a namespace roslaunch.auth. I tried to use warn() only when something unexpected happens and mostly use debug() and the occasional info().


- We need to update the documentation, @param client_ip_address
- Can those guys be optional? None


Ok, I see nothing suspicious left in this crate, so you might want to minor bump it and update the Cargo PR.


@param doc


TeamCity libpalaso :: palaso-linux64-master Continuous [Build 4.0.262.ee94cab7edf64639545c552e817a473cc33ed269](http://build.palaso.org/viewLog.html?buildId=92315&buildTypeId=Libpalaso_PalasoLinux64masterContinuous) outcome was **SUCCESS**
Summary: Tests passed: 3776, ignored: 111 Build time: 00:08:18


TeamCity libpalaso :: palaso-linux64-libpalaso-3.1 Continuous [Build 3.1.416.ee94cab7edf64639545c552e817a473cc33ed269](http://build.palaso.org/viewLog.html?buildId=92318&buildTypeId=bt322) outcome was **FAILURE**
Summary: Exit code 134 (new) Build time: 00:00:07


![](https://github.trello.services/images/mini-trello-icon.png) [versioning and cleanup](https://trello.com/c/ISiFmI2L/14-versioning-and-cleanup)


This is for STORE-1730 which is a framework task under STORE-1631


This is a bit of a hack, but not so bad.  The best thing is that it points out some weaknesses in the generation of `GlassBR`, which was not parametrized by all the symbols it actually uses, nor were all those symbols fully created.


The polymorphic image class here looks pretty good, why did you remove it later?


You need to set memory limits for lein, `:jvm-opts ^:replace ["-Xms256m" "-Xmx2g"]`


You probably want to do the test before the call to get_param since get_param might be costly.


Good example to use in some kind of docs that explains why the `initTranslate` is in constructor, while Ionic stuff is in `ionViewDidLoad` (and in `platform.ready()`).


por favor tal


Move before the resolve_name


You should probably replace `filter(_._1.name == name)` with `filter{case (attribute, _) => attribute.name == name}` for a better readability.
Also you should always use `headOption` instead of `head`, because filter could also return nothing.


The following doc(s) have been deployed to the [d8cacheco](https://d8cacheco-static-docs.pantheonsite.io/docs) Multidev environment:
- [docs/drupal-cache](https://d8cacheco-static-docs.pantheonsite.io/docs/drupal-cache)
- [source/docs/assets/images/d8-aggregate-css-js.png](https://github.com/pantheon-systems/documentation/commit/31572750bda83137a8a843bf725e5f87766f92cc/source/docs/assets/images/d8-aggregate-css-js.png)
- [source/docs/assets/images/d8-cache-config.png](https://github.com/pantheon-systems/documentation/commit/31572750bda83137a8a843bf725e5f87766f92cc/source/docs/assets/images/d8-cache-config.png)


what sense this has??
```quote
NOTE: Events will not repeat until the creature exits combat or unless EFLAG_REPEATABLE value is set in Event Flags.
Some events such as EVENT_T_AGGRO, EVENT_T_DEATH, EVENT_T_SPAWNED, and EVENT_T_EVADE cannot repeat even if EFLAG_REPEATABLE value is set.
```


Why does cmake need those changes but travis qt4 and windows qt4 don't? Does it do something different?


Also see [Commit 23448050c0083f02](https://github.com/weidai11/cryptopp/commit/23448050c0083f026bed98b00742dbd4c4ae72eb)


Off by one?


The comment above is now misleading or wrong, correct?


An iterator is an object that allows you to traverse/iterate through the items in an array.

I think here, you are just iterating through the shapes.

We want an iterator: http://pymbook.readthedocs.io/en/latest/igd.html


TeamCity libpalaso :: palaso-Linux64-lfmerge Continuous [Build 2.6.445.ee94cab7edf64639545c552e817a473cc33ed269](http://build.palaso.org/viewLog.html?buildId=92314&buildTypeId=PalasoTrusty64lfmergeContinuous) outcome was **FAILURE**
Summary: Exit code 134 (new) Build time: 00:00:08


move up


I guess I'm confused about how the Git repository works.   When I look at https://github.com/gperftools/gperftools/blob/master/src/pprof , which appears to be the head of the master branch, I see the 10 lines that the diff I see above adds - slightly modified.  When viewing the code at the above URL, I click the Blame button and scroll down to Line 4571 and it appears to be telling me the lines were added by this commit.  It shows a slight modification since then ("Fix symbol resolution on OSX"), but nothing affecting the fundamental problem of merging virtual memory regions that have different file offsets and then using one of those offsets for the entire merged result.  Removing the new lines, making this piece of the code look like it did before this commit, makes the code work for me.

Thanks for the hint about golang pprof.  I'll look into that.


Propose a new guide ([here's how](./docs/new-guides.md))


How do I measure its MD5 value? I figured it might be in the image's header or an attribute to the HDUList class but can't find a reference to it anywhere.


booleans should be without prefix "is"


The "mmc drives" is actually totally useless since the init only checks for the existence of flag-usb-ready. And that file is always created but wait4usb no matter what.

Yes, it's -name 'mmc*'...  It's just that sometimes i forget to copy the very latest version of a file  i'm editing or testing to the woofce tree.

well, i think i'll delete the mmc code again because it's really useless..


up ?


I don't understand the buf length problem. If you refer to the second part, then there is something wrong with qmake build, because `QStringLiteral` is absent in Qt4 and that code parts are not under `#ifdef`.


TODO ?


No any reason to use setters for fields of current class. + No reason to set default vallue. boolean is "false" be dufault


When will this new material be released?


You're declaring largest as a tuple -- which it probably is not (since largestTuple is a tuple).

Let's try to pick a better initial value that is of the correct type.


+ one field boolean killed;


[Check for open source projects with a similar name]


what is the intention of this line?


Well done! 😜 So in case of no category override it will be okay for default + custom stuff to appear in the F4 menu?


add rendering according to booleans from parent class


144488793-Correct-surface-convection-calculation-6037 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1299 of 1299 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-37.71%25-green.png)


why are you returning?

this means if there is a SINGLE bad format, then you will stop execution of this function.

I don't think you want to stop execution just because you receive a malformed input.  You're probably looking fo a different control flow statement.

Take a look at https://docs.python.org/3/tutorial/controlflow.html and try to get familiar with some of these control flow operators.


Good catch, @fredngo!


Looks like all the implementations of MapLoader have a blank constructor... It probably isn't needed so I would either remove them all or none to keep it consistent.


Refer to bug #640


Maybe I'm wrong, but it seems to fix my problem.

To reproduce the issue that I believe this commit fixes, use Flare Gun on Matis and allow the script to run through to the end.
After Matis despawns, respawn him. Matis will be stuck in dead state.


Best way to do this is to create a bat file to run the executable with the option --quick added after the exe call.
You can also CMD into the directory and call the executable that way with the --quick option added after the executable name.


The following doc(s) have been deployed to the [2290termin](https://2290termin-static-docs.pantheonsite.io/docs) Multidev environment:
- [app/config/sculpin_site.yml](https://github.com/pantheon-systems/documentation/commit/13c90a4f09765320338a287b6f2a9fb39a02ad9b/app/config/sculpin_site.yml)
- [source/docs/assets/css/main.css](https://github.com/pantheon-systems/documentation/commit/13c90a4f09765320338a287b6f2a9fb39a02ad9b/source/docs/assets/css/main.css)


I'm curious how this will turn out 👍


It happens koz he is despawned...(not resets itself after spawn)
and yes u're right.. strange that this flag works.. for spawned event.


trop nulle cette ligne vraiment elle est méga nulle


saddfdf


This is intentional and a personal preference as it makes the variable within the string more noticeable. It also means it is easier to spot that double quotes are required otherwise I find the variable can become lost.


Use `pathParts.shift()` to get head of array and use `===` instead of `==`.


⚠  duplicate line

this throws an error and cancels migrations:
```
rake aborted!
StandardError: An error has occurred, all later migrations canceled:

Mysql2::Error: Duplicate column name 'badge_id': ALTER TABLE `users` ADD `badge_id` int(11) DEFAULT 0redstoner.com/db/migrate/20170319193517_add_badge_id_to_users.rb:4:in `change'
```


@tcm0116 The `lastpos` variable is gone, so this line generates a compile error. Can you please fix?


Use `pathParts.shift()` to get new head.


Yes! Please send a PR with that list.


Use shorter arrow function `filter(info => info.name === attrType);`


Nice. For bonus points try to do it using `Array.map`.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/map


see #6


Make sure to test this/these command(s) still work with these changes.


Travis needs a way to know everything is OK, even if one of the containers got an exception in one of their attempts.
The scripts can't return 0 or 1 as they go into while 1; loop, unless they're killed to stop the server..


Or `String.replace`:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace


Beyond1Airloop (mjwitte) - x86_64-MacOS-10.9-clang: OK (2491 of 2492 tests passed, 596 test warnings)

Messages:

 * 596 tests had: AUD diffs.
 * 523 tests had: BND diffs.
 * 8 tests had: EIO diffs.
 * 2 tests had: RDD diffs.

Failures:

EnergyPlusFixture Test Summary
 * Passed: 468
 * SEGFAULT: 1

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.96%25-yellow.png)


This fails when previous filter call has returned nothing. Also please add semicolon at the end.


There is no migration that creates a `badges` table


Can be written in a single line. Please use jquery val(...) instead of native domElement.value assignment (See http://api.jquery.com/val/)


Да, хорошо, но можно просто написать `if type`, поскольку в Ruby всё является истиной как раз, кроме `nil` и `false`.


앗 칭찬 감사합니다! ㅎㅎ 봐주셔서 제가 오히려 더 감사합니다!


Yeah I noticed that and fixed it. It will be changed in the next commit.


This would need to be a tool to do this, I'm unsure why `unused -exported` wouldn't have detected this though, but perhaps I've misunderstood the flag's purpose.


144488793-Correct-surface-convection-calculation-6037 (mjwitte) - i386-Windows-7-VisualStudio-14: OK (2497 of 2499 tests passed, 0 test warnings)

Messages:

 * 2 tests had: EIO diffs.
 * 2 tests had: ESO big diffs.
 * 2 tests had: MTR big diffs.
 * 2 tests had: Table big diffs.

Failures:

regression Test Summary
 * Passed: 597
 * Failed: 2

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.92%25-yellow.png)


Судя по всему, условие метода говорит как раз об обратном, что мы ещё не достигли конечной станции. Поэтому стоит либо оставить имя метода как есть но инвертировать его условие, либо изменить название метода. Я бы выбрал первый вариант.


Line 1387-1403 should be extracted to a own function.


Seems there is a [`stop_dask` method]( http://ipyparallel.readthedocs.io/en/latest/api/ipyparallel.html?highlight=stop_dask#ipyparallel.Client.stop_dask ) for the `ipyparallel.Client` instance that we should have been using to do cleanup instead.


Имеет смысл определить методы: `at_first_station?`, `at_last_station?` или типа того. У тебя уже есть `last_station_reached`, только он наоборот возвращает `true`, если станция конечная не `reached` )


Should be `tb_malloc0(valuesize + 1)`. See [msdn](https://msdn.microsoft.com/en-us/library/windows/desktop/ms724911(v=vs.85).aspx)

> If the data has the REG_SZ, REG_MULTI_SZ or REG_EXPAND_SZ type, the string may not have been stored with the proper terminating null characters. Therefore, even if the function returns ERROR_SUCCESS, the application should ensure that the string is properly terminated before using it; otherwise, it may overwrite a buffer. (Note that REG_MULTI_SZ strings should have two terminating null characters.) One way an application can ensure that the string is properly terminated is to use RegGetValue, which adds terminating null characters if needed.


@fintara thanks, I'd fix it but the code is being developed on my team member's PC, and they aren't installing git for some reason. I'll tell them to use execute 👍


Addressed in PR ( https://github.com/nanshe-org/nanshe_workflow/pull/73 ).


I'd tend to agree, but it was a rework of existing functionality, and
@zippy was hungry for it

On May 30, 2017 22:35, "Timo" <notifications@github.com> wrote:

> This seems like something that should've been in a pull request, not just
> put directly into master.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/metacurrency/holochain/commit/714ba621657940cbfe5b0de4522a8ca89c3c4992#commitcomment-22335551>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAOnvtfZvtg5FjXEG4fwTaKQTqeRreIIks5r_Iu3gaJpZM4Nq4XO>
> .
>


By doing `w->dir = w->R;` we take a pointer to `w->R` and then we do
```.c
scaleArray(w->dir, -1, w->l); /* dir^0 = -R */
```
But this modifies `w->R`. Shouldn't we copy `w->R` into `w->dir` using `memcpy`?


HIGHLY recommend Git Undo from https://www.christianengvall.se/undo-pushed-merge-git/


I believe that this line should be moved *after* line 1177.


Sorry for the lack of commits lately. Been working on a local network to restart the HRCloud platform.

Fingers crossed!!!


Oh absolutely it's a false positive anyway, I straight added it to the exclusion list and moved on. The FF1 specific Vulkan crash though, it's never happened before, I consistently keep an eye on Vulkan developments on ppsspp to see if it will help me get around the very hard frame drops I get (from constant 60 to like 10fps) when casting some magic spells (fire, cure, spells that darken the screen for a moment) on the game and it never crashed when loading before. The weird thing is how it works after running a different game, that didn't happen with 1.41 and 1.42.

Anyway, just to report that, and say thank you very much for your wonderful work.

Regards.


@alphaville Yes, indeed you are right. I will correct it soon


@mistervee , custom_1118_videoosd would still be required, since that is the custom dialog that pops up when you press the settings button on the Video OSD.  While I am not sure all of the options will remain, I am certain that some will, so this one needs to stay or its features need to be incorporated into skin settings and the button needs to be removed from the Video OSD.


Just added what the tutorial said


@alphaville if we move it after line 1177 we should use POWF i think. Otherwise it will be inside the for loop of ls. q^k refers to the main iterations if i am not mistaken.


Agreed, Yes, that newly added line is not required.  Just commented it and ran it and it ran fine.


So, addition of that line didn't make any difference in this unit test execution.