![](https://github.trello.services/images/mini-trello-icon.png) [Digital Watch Commit By Soy 2017-05-04](https://trello.com/c/Ov2AXUEa/19-digital-watch-commit-by-soy-2017-05-04)


👍 @paperlib Adding: raywenderlich.com swift style guide to readme.md.


so...?


Puzzle `35-79647dcf` disappeared, that's why I closed as #44


Puzzle `35-de23b30b` disappeared, that's why I closed as #45


Puzzle `45-46f15e48` discovered and submitted as #47


can this version also be pushed to PyPI?


Cool - three things from me 👍


You are correct -- https://ci.appveyor.com/project/analogdevicesinc/libiio/branch/test_improvements

  iio_attr.obj : error LNK2019: unresolved external symbol _strcasestr referenced in function _main [C:\projects\libiio\build-win32\tests\iio_attr.vcxproj]
  C:\projects\libiio\build-win32\tests\Release\iio_attr.exe : fatal error LNK1120: 1 unresolved externals [C:\projects\libiio\build-win32\tests\iio_attr.vcxproj]

I will fix.


Missing link rel="stylesheet" type="text/css" href="assets/css/style.css"


h


thanks, ok. the "pluginification" of the webgui is a good point to bring this in at the same time (I was actually expecting 17.1.7)


If I remember the discussion - that was the preferred way. Maybe Michael or Lars can comment.


test


Here we simply mark our mojos (all except kapt) as thread-safe. Users confirmed that all related errors has disappeared so we can disable warning.


CRC-5397 - Call the new Alfresco API to Provide document as PDF - Review comments incorporated


@pospispa https://github.com/zetaab/kubernetes.github.io/commit/af7e48dcc382e49595159c9db571fa87cc85e75f


Nice banner @Udara-U3!
By the way, why not using xcf format if those files edited in GIMP?


should be showbalancedue?


can you move this to templates.go, so the template functions are reusable :)


Should be JMA Consulting


Add some description


Change it to joe.murray@jmaconsulting.biz or everyone@jmaconsulting.biz


Change url


Hi Jackie:
Please, can you let me know the syntax for adding <BingMapKey> extension property in Application Definition document.

Thanks,
Sai


stable


4.6 or/and 4.7?


Sehr gut jetzt sind wir startklar :+1:


@matthew-dean

I think this should be revised:
1. we should not add additional overhead for a guesswork of plugin author intentions (a big framework has >.5K function calls so this code basically adds an overhead of never really used >.5K jumps for such framework).
2. even if it *looks* like being a more friendly API - it is *not* actually and only may mislead, e.g. above `pi` example will fail for:
```less
.test-simple {
    @plugin "./plugin/plugin-simple";
    value: 2 * pi(); // uh, oh, panic mode on, Less plugins are useless
}
```

Even if Less code-base is not optimal and above overhead may look like an insignificant increment of the overall compilation time (probably even <1%), this is really what they call "premature pessimization" (not quite justified in this case, imho).

I'd rather suggest to provide some explicit conversion function to perform an automatic conversion of JS types to Less types (`number` to `dimension`, `string` to `quoted`, `boolean` to `keyword(true/false)` etc.), so it will be used only where necessary w/o burdening unrelated stuff.
E.g., a friendly `plugin-simple.js` could be something like:
```js
functions.add('pi', function() {
    return less.type(Math.PI); // no idea of a good function name as always
});
```

I think I could make a PR if you're fine with that.


Thanks a million man
you make my day!


@JIMENOFONSECA: Could you let me know what the mistake in the schedule was? It is important as I am using the same dataset for my work

Cheers

PJ


[Your benchmark job](https://github.com/JuliaLang/julia/commit/d13cb5fe6b8fc0d5d942726d85e584bd06d62512#commitcomment-22013576) has completed - possible performance regressions were detected. A full report can be found [here](https://github.com/JuliaCI/BaseBenchmarkReports/blob/0dc427b0861adec10c3ab1f5b3460ca8c5670d6c/d13cb5f_vs_6445c82/report.md). cc @jrevels


Done, created [a separate review](https://upsource.jetbrains.com/kotlin/review/KOTLIN-CR-939).


My negligence. From this issue: https://github.com/kaitoy/pcap4j/issues/87,Pcap4j will add Npcap native support starting from a [future 2.0 version](https://github.com/kaitoy/pcap4j/commit/58522d9d3b91ba5e28ae84a5cc79d405baa22b6e), which is not released yet. The current latest Pcap4j 1.7.1 doesn't have this feature yet.


No need to put $ sign inside function


looking for cause of array growth regression, 8619307 vs 0.5.1
@nanosoldier `runbenchmarks("array", vs = "@6445c82d0060dbe82b88436f0f4371a4ee64d918")`


After following your advice, I can run "python3 srez_main.py --run demo".succesfully,and get demo1.mp4.
(summary_period to 100 and increased train_time to 120.)
But output in third column   that is generated by the neural net in demo1.mp4 move violently changing to various outputs without stopping.
Is that last correct result?

Another quetion.

There are 5 columns in "srez_sample_output.ping"( an random, non cherry-picked, example ).
How were 5 colums made ?
I think the process which makes 5 columns is like below.

  1. "srez" select 8 pictures randomly  from "ground truth(real face pictures)".
  2. "srez" downscale this selected 8 "ground truth" to 16X16 images,and put them in the first column.
  3. "srez" made 8 images into high-resolution images from 16X16 images by using "a standard bicubic interpolation" , and put them in the second column.
  4. The neural net generate the outputs and put them in third column.
  5. "srez" put "ground truth(real face pictures)" in the right column.
    (But I do not know in detail which .py play each role in this process.)

By the way,how do I change "srez"program when I want to make some particural picture (for instance, my own face picture )which is low resolution into  super-resolution by using "srez"?

 I am sorry to boter you again.


A GIF animation view on Activity

![image](https://cloud.githubusercontent.com/assets/12508109/25702225/92d8862e-3102-11e7-85b1-05838a74df0d.png)


Use jQuery instead of $ sign as you do above for consistency reasons


Doc change for https://github.com/kubernetes/kubernetes/pull/44798

AWS + gce texts changed also because it is not really "random zone"

https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/util.go#L295 "Volumes are generally round-robin-ed across all active zones"


Why need to ignore stdin on Windows?


Depending on the mode the device is operating, device attributes can return -ENODEV. DCXO is such an example.
Dynamically removing attributes was never an option. So this was the preferred behavior.
IIRC -EACCES was never used in such a case.

-Mcihael


@nlyan @XinyuHou Do you guys think this should be a constant? I have a thing about magic numbers.


When does this error occur? Why would you want to translate a message in language that you do not know of?

I'm asking because I think it's generally preferable to have a function raise an error than silently do nothing.


docker image: 496870459963.dkr.ecr.eu-west-1.amazonaws.com/photobox/jenkins-tests:testing_2
endpoint: http://jenkins-tests-jenkins-testing.k8s-test.photobox.com


Here the variables in `assumptions(leftSubProof.conclusion)` need to refer to the same formulas as the variables `assumptions(proof.conclusion)`.  I think the easiest way to do this here is by transporting `assumptions(proof.conclusion)` upwards using the sequent connectors, that is, `proof.getLeftSequentConnect.parent(assumptions(proof.conclusion))`.


The 256?


There should be no reason to restrict to natural numbers here.


For reference here is the where the -ve comes from. See the [M] part.

I like the assembly term interface as it stands because it's reusable - we use it for the MeshVariable_Projection sle.... pretty cool.

![image](https://cloud.githubusercontent.com/assets/13825704/25702127/80aaae04-30c7-11e7-8fce-a883f9440e53.png)


You'll never be able to account generated files from every single OS and IDE that contributors might use. It's foolish to think that every single repo should be ignoring these manually.

IMO, these IDE and OS-level files should be ignored by each developer via their own [global gitignore](https://help.github.com/articles/ignoring-files/#create-a-global-gitignore) files.

That leaves the project-level `.gitignore` for the folders and files that are meant to be in the project, but not in version control, like `phpcs.xml`, `node_modules/`, `vendor/`, `logs/`, `dist/`, `.env` etc.


Yeah.


Maybe we should just rename the tool to ad9361_attr


Hi @mdozmorov - Would you be able to submit these changes as a PR?


It looks like this Commit undoes my pull request I did a week or so ago. Not sure if that was intended...

The reason why I added DoFindCityToLinkResourceTo() for when resources get added by an improvement or building (or found) is because they were not getting linked to that city. For example, if you had say a special building that would place a source of Marble in your territory, it would get added to your inventory, but for some reason the city would not get the wonder production mod. Linking it to the city did this. The reason I chose this function which is somewhat ambiguous is because suppose a resource gets placed by a city on its 3rd ring, but the resource is in the 2nd ring of another one of your cities. It seems more reasonable to place it in the other city rather than the one that built it.

The rest of the other changes are getting rid of an obsolete function and some aesthetic cleanup.

Lemme know.


add vpn10,vpn11,vpn12,vpn13,vpn14,vpn15 for feature use


It's a trivial bitmask op so no. Perhaps change it to "|= 0xFF", but I don't tend to do that in simple cases because it's easy to mistype/miscount the number the number of Fs


http://zlib.net/ChangeLog.txt

zlib has been recently updated:
- 1.2.9 (31 Dec 2016)
- 1.2.10 (2 Jan 2017)
- 1.2.11 (15 Jan 2017)


add keys for fastd


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/20df7868-8160-46df-8609-9becaa90c91c "lo-tool"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/03d16f99-3d38-465d-87e4-05f636d98e71 "lo-tool") deployed [lo-tool](https://github.com/LaurentDC/lo-tool/releases/tag/deploy-ibm-yp-us-south-l.dibocohen-gmail.com-dev-lo-20170504-115801 "deploy-ibm-yp-us-south-l.dibocohen-gmail.com-dev-lo-20170504-115801") to [dev-lo](https://console.ng.bluemix.net/apps/c0baea26-f38b-4e58-865b-77b50ebc636b "ibm:yp:us-south:l.dibocohen@gmail.com:dev-lo"), including this commit


En fråga kring glassnyckeln: när man kommer in till drakrummet så finns ju nyckeln där redan, den har ju blivit initierad med Glass Key som sin Thing i things-arrayn. "Osynliggör" vi den genom att lägga in det i apply() för det rummet?


@olegbl, this change breaks our stetho [network inspections](https://medium.com/@andr3wjack/stetho-with-react-native-87642e5d7131).

Is there no other away around this? I need a way to set the `OkHttpClient` which is being passed into the `NetworkingModule `.

`NetworkingModule` appears to be a final class and can't be subclassed.

And adding another Module to do that seems unlikely to work, and would most likely cause breaking changes if we ever need to update the react version.

What if we add an interface that allows users to provide their own `OkHttpClient` based on the context. Something similar to:

```java
// com/facebook/react/modules/network/OkHttpClientProvider.java
//...

interface OkHttpClientProvider {
  OkHttpClient createNewNetworkModuleClient();
}

// Public setter for setting this.
static OkHttpClientProvider provider;

public static OkHttpClient createClient() {
    if(provider != null) {
      // Use a user defined provider.
      return provider.createNewNetworkModuleClient();
    }
    // No timeouts by default
    OkHttpClient.Builder client = new OkHttpClient.Builder()
      .connectTimeout(0, TimeUnit.MILLISECONDS)
      .readTimeout(0, TimeUnit.MILLISECONDS)
      .writeTimeout(0, TimeUnit.MILLISECONDS)
      .cookieJar(new ReactCookieJarContainer());

    return enableTls12OnPreLollipop(client).build();
  }
//...
```


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.44.0-pre-6-g2eeee24](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=60785&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **SUCCESS**
Summary: Running Build time: 00:01:05


@chelmuth: please add to staging


TeamCity Platform Services :: Environment Manager 2 :: Package [Build 3.44.0-pre-5-g47d2378](http://infra.teamcity.ci.ttldev/viewLog.html?buildId=60789&buildTypeId=PlatformServices_EnvironmentManager2_Package) outcome was **SUCCESS**
Summary: Running Build time: 00:00:52


Aquí un pantallazo:
![2017-05-04 1](https://cloud.githubusercontent.com/assets/23742881/25702583/f385e178-30d1-11e7-8116-a7a3022ac110.png)


@BellatrixBlack http://stackoverflow.com/questions/28671903/hashset-removeall-method-is-surprisingly-slow
investigate this issue.


Hi @alwinruby,
I created a folder where we can commit the code of our pair coding sessions.
I have not experience with git, so let me know If this is not working.
Good weekend!


Added a Tests that shows how a second M-N Entity wich is not reference-equal with the first one but has the same key brings ApplyChanges to throw InvalidOperationException because the first N-M Entity is already attached to the context


Is release version 2.1 as announced by BruceUncle on UltimateAmiga.co.uk included in this?  I find the release name confusing if it is.


@tisto what's different about your blog's RSS as compared to standard Plone's? That would be my first guess. Maybe publish a short test blog post on standard Plone and the same on your blog and compare. I'm looking at this Venus stuff for the first time myself. Maybe I could work with @sneridagh on this if he has time.


This probably fixes issue #1, but needs to be confirmed. We have to fix another `attempt to subtract with overflow' issue first.


You can also use route-model binding here. 🙂


DEPENDS = "qtdeclarative persistence-client-library"


Thanks, now we can see that the Uprising Bots have their own victory poses lol.


The link "http://discord.me/racf" replaced with  ''http://discord.gg/racf" to take advantage of Discord VIP Partner program providing custom link rather than using link provided by "DiscordMe" Service. Also in-line with The Reddit Alpha twitter page which shows the same link. A subtle change but link is direct now.


и этот вариант я тоже пробовал) но как вы увидели, вся загвоздка была в .append`е )
сейчас закомичу с sqrt


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/20df7868-8160-46df-8609-9becaa90c91c "lo-tool"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/03d16f99-3d38-465d-87e4-05f636d98e71 "lo-tool") deployed [lo-tool](https://github.com/LaurentDC/lo-tool/releases/tag/deploy-ibm-yp-us-south-l.dibocohen-gmail.com-dev-lo-20170504-120430 "deploy-ibm-yp-us-south-l.dibocohen-gmail.com-dev-lo-20170504-120430") to [dev-lo](https://console.ng.bluemix.net/apps/92309748-5bbd-462f-9fcc-27a0f7c515a1 "ibm:yp:us-south:l.dibocohen@gmail.com:dev-lo"), including this commit


I think we need a sane fallback to English for messages of which we (or other packages) have no translations. We have something similar in the forms: https://github.com/OneGov/onegov.core/blob/ec5786f38a311c32ebe8c108e999755e25084167/onegov/core/request.py#L274. This might occur for forms in the case of missing Rumansch translations for example.

There are other cases, when we want to return things in English (for example when using the REST interface of onegov.election_day) without using English as a locale for the whole site.

There is now something like a REST interface in onegov.election_day where one can specify the locale so that the errors (of which we mostly all the translations) are returned translated.


changed class names to 0..16


This is the added test, the changes above just happened accidently


Maybe add a comment on where to get your gobject tracker


sample test


@raphaelokon did you run the tests after this?


it is this line that doesn't seem to work - see issue


`s/keynote/keybase/`


for me


This was removed because it was a close duplicate of the code that the `buildCLIArgs()` utility function now does, which is used in the WP-CLI driver elements.

The old driver implementation was building WP-CLI arguments (incorrectly; there were bugs) and then we were passing the same sort of thing to the `wpcli()` method which made not much sense (probably a legacy quirk), so now it's all in one place.

Without testing, I would expect `buildCLIArgs()` to transform your data to `--foo="bar"`.

RE: escaping -- I wanted to stop people accidentally breaking CLI commands with things like nested/unclosed quotes in content such as post titles, and `escapeshellargs` does that.


Well, because we will filter in post-processing now
We need 5.0 for VBS analysis to sync with MIT and hence we decided to keep all jets


take action


Why not `2.6.1`?


[R/get_captions.R:30:1:](https://github.com/soodoku/tuber/blob/c01dd0df15dcb5dd83b23a7c874c86dde8a08863/R/get_captions.R#L30) *style:* **Trailing whitespace is superfluous.**
```r

^~
```


Nice catch!

Could you open a pull-request on my repository with the improvement on `gs` command (https://github.com/alberto2perez/pdf-version-converter/commit/8c5e309c2351b3e5595898dc27ea18c1a87d4ec1)? It will be a pleasure merge it and share the improvement with everyone.

Thank you!


There is not change in the package itself. We just made something wrong when publishing to NPM


I would remove the check completely -E... are errors, we don't need any additional interpretation.
Regardless of what error is returned - if you need to pretty print something simply use strerror(errno)


Good if filtered in post processing.
Thanks


I see. You really should consider installing 'git' and learn the basics.
https://help.github.com/articles/fork-a-repo/#platform-windows is a good start.


Okay, didn’t know about that. Licensing is a PITA sometimes. :) Thanks!


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/c6002db1-5086-47ee-9e57-8a2e56fe9add "simple-toolchain-20170504115955873"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/2c085b55-0879-4d92-8cdd-49731ecc853c "simple-toolchain-20170504115955873") deployed [simple-toolchain-20170504115955873](https://github.com/MathieuLeGuirriec/simple-toolchain-20170504115955873/releases/tag/deploy-ibm-yp-us-south-SopraSteriaMontpellier-Labs-20170504-121334 "deploy-ibm-yp-us-south-SopraSteriaMontpellier-Labs-20170504-121334") to [Labs](https://console.ng.bluemix.net/apps/e3cb64e5-a0e3-415c-982a-e41eb185f9d0 "ibm:yp:us-south:SopraSteriaMontpellier:Labs"), including this commit


looks like this file isn't getting run by Pkg.test, but if it were then you'd need Plots in test/REQUIRE


But now `npm update` isn't updating to the newest release 😕


Do you even need the `/32` in the IP address case?  Is it illegal to do this:

```
host replication replication 10.20.30.40 trust
```

?


Nice ;-)


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/362162fd-d10a-4aa1-9495-94b53941c6d2 "simple-toolchain-gk-v1"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/e62ab81a-edc3-4c41-8a28-6fce04236bd8 "simple-toolchain-gk-v1") deployed [simple-toolchain-gk-v1](https://github.com/gertkornet/simple-toolchain-gk-v1/releases/tag/deploy-ibm-yp-us-south-WeDoDigital-test-space-2-mont--20170504-121614 "deploy-ibm-yp-us-south-WeDoDigital-test-space-2-mont--20170504-121614") to [test space 2 (mont)](https://console.ng.bluemix.net/apps/0e13f55d-ccf1-4a1c-922f-c42cbbdd2e1c "ibm:yp:us-south:WeDoDigital:test space 2 (mont)"), including this commit


alertFields

also, missing docstring param


Docker image: 496870459963.dkr.ecr.eu-west-1.amazonaws.com/photobox/jenkins-tests:testing_2
Endpoint: http://jenkins-tests-jenkins-testing.k8s-test.photobox.com


s/nbits/nbytes


test


thanks for the quick response. Unfortunately I already removed some correlations from the database which made it working again, thus I cannot yet tell if this patch helps or not. I would suggest closing the issue and if it re-appears I will open a new issue.


sometimes it's nice to tell users what is going on, when some errors are expected.


don't use `-O0` in modern GCC; use the dedicated debugging optimisation level, `-Og` instead.  And output more debugging data with `-ggdb3` instead of just `-g`.


建议还是用provider/inject 更直观点，而不是用$parent循环遍历的方式查找；子组件往父组件走可以接着用以前那个emitter啊。vue后面的新特性应该都不会有双向的东西了吧。。毕竟单向数据流是大趋势


Argh.. Updated again.


Bi lahko spremenili še iz Cell Designer v Construct Designer?


@adeas31 Thanks for this nice feature. Is there a reason to hide/show signals on double clicks instead of single clicks? It seems to be more efficient to use single clicks, especially if one wants to hide a bunch of signals.


Ist doch egal, ob `c2` ungerade oder gerade sind. Oder?
@nichtderlehrer


I'm sorry for the trouble 😕


Well, it might be right:D


No problem. Just let us know if there is anything else.


Okay, thanks for clarifying 👍


This was already done in a later commit, but thanks for double checking!

Also BTW, thanks for being such a trooper. I have been cramming everything through because I want it all setup in time for GSoC + JuliaCon with time to spare, but that also means it's a lot of your review time. You've been very helpful.


Much better :)


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/362162fd-d10a-4aa1-9495-94b53941c6d2 "simple-toolchain-gk-v1"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/e62ab81a-edc3-4c41-8a28-6fce04236bd8 "simple-toolchain-gk-v1") deployed [simple-toolchain-gk-v1](https://github.com/gertkornet/simple-toolchain-gk-v1/releases/tag/deploy-ibm-yp-us-south-WeDoDigital-test-space-2-mont--20170504-122059 "deploy-ibm-yp-us-south-WeDoDigital-test-space-2-mont--20170504-122059") to [test space 2 (mont)](https://console.ng.bluemix.net/apps/cbaff185-4daa-4313-bcfa-02d06ede0c4d "ibm:yp:us-south:WeDoDigital:test space 2 (mont)"), including this commit


!add me


I dold this from ignorance
your method is valid too


you can do it directly in 'events' instead


Add settings to exclude models or entire apps.


oh, and this should be in formrenderer I think


@Measy 我找时间再研究下把 两种模式混用有点蛋疼


![](https://github.trello.services/images/mini-trello-icon.png) [Add javadoc](https://trello.com/c/PcUqicf4/85-add-javadoc)


def = def.then...


tranlsation => translation


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/20df7868-8160-46df-8609-9becaa90c91c "lo-tool"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/03d16f99-3d38-465d-87e4-05f636d98e71 "lo-tool") deployed [lo-tool](https://github.com/LaurentDC/lo-tool/releases/tag/deploy-ibm-yp-us-south-l.dibocohen-gmail.com-dev-lo-20170504-122427 "deploy-ibm-yp-us-south-l.dibocohen-gmail.com-dev-lo-20170504-122427") to [dev-lo](https://console.ng.bluemix.net/apps/42b80c06-9b86-4d52-b91d-e91f756c03be "ibm:yp:us-south:l.dibocohen@gmail.com:dev-lo"), including this commit


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/c6002db1-5086-47ee-9e57-8a2e56fe9add "simple-toolchain-20170504115955873"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/2c085b55-0879-4d92-8cdd-49731ecc853c "simple-toolchain-20170504115955873") deployed [simple-toolchain-20170504115955873](https://github.com/MathieuLeGuirriec/simple-toolchain-20170504115955873/releases/tag/deploy-ibm-yp-us-south-SopraSteriaMontpellier-Labs-20170504-122440 "deploy-ibm-yp-us-south-SopraSteriaMontpellier-Labs-20170504-122440") to [Labs](https://console.ng.bluemix.net/apps/4ccfc8ff-cc83-49db-b84f-c246dd2819b7 "ibm:yp:us-south:SopraSteriaMontpellier:Labs"), including this commit


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/7f1ce403-377c-4486-a4ef-f86197726ab4 "simple-toolchain-20170504115439096"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/1cdf1213-9dca-4de8-908a-a5097f3491e6 "simple-toolchain-20170504115439096") deployed [simple-toolchain-20170504115439096](https://github.com/mostfrankly/simple-toolchain-20170504115439096/releases/tag/deploy-ibm-yp-us-south-WeDoDigital-most-frankly-WDDmf-20170504-122454 "deploy-ibm-yp-us-south-WeDoDigital-most-frankly-WDDmf-20170504-122454") to [WDDmf](https://console.ng.bluemix.net/apps/f1fddbe0-3faa-4251-9234-ebf0272452d4 "ibm:yp:us-south:WeDoDigital most frankly:WDDmf"), including this commit


Agreed about an option to disable this. I'm not sure I'd ever use it (unless there's a reason I should be double checking them?)


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/362162fd-d10a-4aa1-9495-94b53941c6d2 "simple-toolchain-gk-v1"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/e62ab81a-edc3-4c41-8a28-6fce04236bd8 "simple-toolchain-gk-v1") deployed [simple-toolchain-gk-v1](https://github.com/gertkornet/simple-toolchain-gk-v1/releases/tag/deploy-ibm-yp-us-south-WeDoDigital-test-space-2-mont--20170504-122540 "deploy-ibm-yp-us-south-WeDoDigital-test-space-2-mont--20170504-122540") to [test space 2 (mont)](https://console.ng.bluemix.net/apps/6f20a564-f628-4096-8929-830579d7be44 "ibm:yp:us-south:WeDoDigital:test space 2 (mont)"), including this commit


This should now be fixed in efc3ec78d0aa5d16985494dc81e3581694857743.


@rossdargan yeah. The value changes once they settle.


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/c6002db1-5086-47ee-9e57-8a2e56fe9add "simple-toolchain-20170504115955873"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/2c085b55-0879-4d92-8cdd-49731ecc853c "simple-toolchain-20170504115955873") deployed [simple-toolchain-20170504115955873](https://github.com/MathieuLeGuirriec/simple-toolchain-20170504115955873/releases/tag/deploy-ibm-yp-us-south-SopraSteriaMontpellier-Labs-20170504-122618 "deploy-ibm-yp-us-south-SopraSteriaMontpellier-Labs-20170504-122618") to [Labs](https://console.ng.bluemix.net/apps/9d0e2ad8-9d82-42aa-8c39-adf714ab97cb "ibm:yp:us-south:SopraSteriaMontpellier:Labs"), including this commit


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/bbd03871-45c1-4377-b52e-3f5e51a59df1 "TravelDevOps"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/2f6d7521-cf8b-4ab7-8574-bc22fb5de0ec "BlueEye") deployed [TravelDevOps](https://github.com/plainfield/TravelDevOps/releases/tag/deploy-ibm-yp-us-south-IBM-PoCs-DevOps-20170504-122618 "deploy-ibm-yp-us-south-IBM-PoCs-DevOps-20170504-122618") to [DevOps](https://console.ng.bluemix.net/apps/095fd8a4-3869-4422-ba85-69b961765d24 "ibm:yp:us-south:IBM PoCs:DevOps"), including this commit


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/20df7868-8160-46df-8609-9becaa90c91c "lo-tool"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/03d16f99-3d38-465d-87e4-05f636d98e71 "lo-tool") deployed [lo-tool](https://github.com/LaurentDC/lo-tool/releases/tag/deploy-ibm-yp-us-south-l.dibocohen-gmail.com-dev-lo-20170504-122628 "deploy-ibm-yp-us-south-l.dibocohen-gmail.com-dev-lo-20170504-122628") to [dev-lo](https://console.ng.bluemix.net/apps/9ebf065a-ed74-4a62-9b80-3ce159e971fe "ibm:yp:us-south:l.dibocohen@gmail.com:dev-lo"), including this commit


@XinyuHou So what does 256 actually mean in this context?


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/2a134605-8230-482a-83f4-a01a5d089899 "simple-toolchain-20170504115758806"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/77f702ee-a67e-4987-b577-8ab67780dba6 "simple-toolchain-20170504115758806") deployed [simple-toolchain-20170504115758806](https://github.com/lakeshopper2/simple-toolchain-20170504115758806/releases/tag/deploy-ibm-yp-us-south-T-Impact-IBM-Lab-IBM-Montpellier-space-US-South-20170504-122640 "deploy-ibm-yp-us-south-T-Impact-IBM-Lab-IBM-Montpellier-space-US-South-20170504-122640") to [IBM Montpellier space US South](https://console.ng.bluemix.net/apps/8fbfe77b-17e3-4343-acb3-20684cef68da "ibm:yp:us-south:T-Impact IBM Lab:IBM Montpellier space US South"), including this commit


So what does 256 actually mean in this context?


Hi ! I'm also working on implementing missing API and features in Kafka.pm (check my branches or the github Network). Are you going to implement new stuff soon? Or can I consider these commits stable and merge them in my branches ? thanks


maybe you should remove existing translation alert (if it exists).  Right now, if someone press click twice, he might have 2 translation alerts


s/desk/pesk/
this is what you get for using the mouse to type


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/362162fd-d10a-4aa1-9495-94b53941c6d2 "simple-toolchain-gk-v1"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/e62ab81a-edc3-4c41-8a28-6fce04236bd8 "simple-toolchain-gk-v1") deployed [simple-toolchain-gk-v1](https://github.com/gertkornet/simple-toolchain-gk-v1/releases/tag/deploy-ibm-yp-us-south-WeDoDigital-test-space-2-mont--20170504-122743 "deploy-ibm-yp-us-south-WeDoDigital-test-space-2-mont--20170504-122743") to [test space 2 (mont)](https://console.ng.bluemix.net/apps/fbbef99e-7c55-48cf-9b1a-0207e9a7b1ff "ibm:yp:us-south:WeDoDigital:test space 2 (mont)"), including this commit


should have a clean body


No, this capability is simply to allow you to load JSON/YAML as part of a Jinja2 expression. For example, previously you were able to specify the vocabulary for a speech recognition supplier like this:
```
- speech_recognition:
    vocab: ["a", "b", "c", ...]
```
or this:
```
- speech_recognition:
    vocab: my_file.json
```
Now you could also do this:
```
- speech_recognition:
    vocab: "{{ load_json('vocab.json') }}"
```
It's just another option to allow for a flexible Kurfile.


ok


[FIX] web: should remove all unused tags when use datepicker
 => [FIX] web: should remove all unused tags when using datepicker

before this fix, a tag is add in body but never removed => before this fix, a tag is added in the body but never removed


uytuiyf


Why SHA1? You have SHA256 listed in the key digests, why not use it? Besides future-proofing against the emergence of a SHA1 second pre-image attack, it will actually be faster on 64-bit devices.


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/7f1ce403-377c-4486-a4ef-f86197726ab4 "simple-toolchain-20170504115439096"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/1cdf1213-9dca-4de8-908a-a5097f3491e6 "simple-toolchain-20170504115439096") deployed [simple-toolchain-20170504115439096](https://github.com/mostfrankly/simple-toolchain-20170504115439096/releases/tag/deploy-ibm-yp-us-south-WeDoDigital-most-frankly-WDDmf-20170504-123243 "deploy-ibm-yp-us-south-WeDoDigital-most-frankly-WDDmf-20170504-123243") to [WDDmf](https://console.ng.bluemix.net/apps/68f317a7-e097-469d-b732-f218a70dc236 "ibm:yp:us-south:WeDoDigital most frankly:WDDmf"), including this commit


missing docstring (returns a jqueryElement)


This works, but you could actually just check to see what digests are supported.  See https://developer.android.com/reference/android/security/keystore/KeyInfo.html


I think we need some consistent way of referring to these things, maybe "language object/call"? Needed in title here, body here, and title of `lang_name()`


@mingwandroid sorry for the dumb question: how do you obtain these values for a new R version?


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/7f1ce403-377c-4486-a4ef-f86197726ab4 "simple-toolchain-20170504115439096"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/1cdf1213-9dca-4de8-908a-a5097f3491e6 "simple-toolchain-20170504115439096") deployed [simple-toolchain-20170504115439096](https://github.com/mostfrankly/simple-toolchain-20170504115439096/releases/tag/deploy-ibm-yp-us-south-WeDoDigital-most-frankly-WDDmf-20170504-123430 "deploy-ibm-yp-us-south-WeDoDigital-most-frankly-WDDmf-20170504-123430") to [WDDmf](https://console.ng.bluemix.net/apps/68f317a7-e097-469d-b732-f218a70dc236 "ibm:yp:us-south:WeDoDigital most frankly:WDDmf"), including this commit


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/7f1ce403-377c-4486-a4ef-f86197726ab4 "simple-toolchain-20170504115439096"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/1cdf1213-9dca-4de8-908a-a5097f3491e6 "simple-toolchain-20170504115439096") deployed [simple-toolchain-20170504115439096](https://github.com/mostfrankly/simple-toolchain-20170504115439096/releases/tag/deploy-ibm-yp-us-south-WeDoDigital-most-frankly-WDDmf-20170504-123434 "deploy-ibm-yp-us-south-WeDoDigital-most-frankly-WDDmf-20170504-123434") to [WDDmf](https://console.ng.bluemix.net/apps/68b8d427-c392-473d-8b93-461b5ab2f031 "ibm:yp:us-south:WeDoDigital most frankly:WDDmf"), including this commit


thats the spirit...


As evidence I'd quote user that uses parallel build actively

(from https://youtrack.jetbrains.com/issue/KT-15050#comment=27-2144507 )
> Piotr Pędziwiatr 04 May 2017, 08:20
> I think that after ~800 succfessful builds I can finally confirm that issue has been fixed :)


missing return (deferred)


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/2a134605-8230-482a-83f4-a01a5d089899 "simple-toolchain-20170504115758806"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/77f702ee-a67e-4987-b577-8ab67780dba6 "simple-toolchain-20170504115758806") deployed [simple-toolchain-20170504115758806](https://github.com/lakeshopper2/simple-toolchain-20170504115758806/releases/tag/deploy-ibm-yp-us-south-T-Impact-IBM-Lab-IBM-Montpellier-space-US-South-20170504-123458 "deploy-ibm-yp-us-south-T-Impact-IBM-Lab-IBM-Montpellier-space-US-South-20170504-123458") to [IBM Montpellier space US South](https://console.ng.bluemix.net/apps/538590f8-585a-4b0f-aed6-4233881305d6 "ibm:yp:us-south:T-Impact IBM Lab:IBM Montpellier space US South"), including this commit


[inst/Hoofdscript.R:47:6:](https://github.com/inbo/dhcurve/blob/cddcb325cd1629a719f986cc5d06cff5763277b0/inst/Hoofdscript.R#L47) *style:* **Commented code should be removed.**
```r
<U+200B>    #!grepl(" (G)", BMS, fixed = TRUE)
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```


Which values?


I'm starting to feel like we should just call them call and people will figure out the link to `lang` by themselves (and also with the terminology section in `?lang`).


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/7f1ce403-377c-4486-a4ef-f86197726ab4 "simple-toolchain-20170504115439096"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/1cdf1213-9dca-4de8-908a-a5097f3491e6 "simple-toolchain-20170504115439096") deployed [simple-toolchain-20170504115439096](https://github.com/mostfrankly/simple-toolchain-20170504115439096/releases/tag/deploy-ibm-yp-us-south-WeDoDigital-most-frankly-WDDmf-20170504-123613 "deploy-ibm-yp-us-south-WeDoDigital-most-frankly-WDDmf-20170504-123613") to [WDDmf](https://console.ng.bluemix.net/apps/dc73a3f4-1b17-4bdb-90d8-877b0ef3c78a "ibm:yp:us-south:WeDoDigital most frankly:WDDmf"), including this commit


@yuyuyu101 @liewegas @tchaikov  Hi, We need cherry-pick this commit to Kraken branch.  I got compile error when I try to compile Kraken.


一个quick update. 😊
我只改了tot_gauss： 400， 1000， 1200
然后试了用clean data或者multi condition data训练模型.
#gmm=1000的时候还不错。但是如果加到1200 ，在multicondi training mode下 在low snr的地方已经变不好了。

我下一步想试试cmvn。刚才试了一下只把no_cmvn=true，training都没问题。但是 decode的时候，报错。我还没有看具体什么问题, 好像找不到speaker了。
我还没有特别看懂kaldi是如果做normalizatrion的。 貌似是不用生成新的feature, 而是生成一个mvn的status, 应该是算出来每个set上面的mean 和variance， 然后等需要归一化的时候在线的归一化feature。我再学习一下 😊

另，在你的stage-1里面，我看到已经用了 steps/compute_cmvn_stats.sh
为什么还要有个stage0 来最normalization 呢？

cleancondi train
testa

testb

tot_gauss
cln
20
15
10
5
0
-5
Avg.0-20

cln
20
15
10
5
0
-5
Avg.0-20
400
2.1
7.46
15.77
34.94
59.87
80.92
92.76
39.792

2.1
5.12
10.84
25.07
50.38
77.73
92.06
33.828
1000
1.94
6.58
15.14
34.95
60.18
80.54
91.98
39.478

1.94
4.61
10.18
24.97
51.4
79.04
92.72
34.04
1200
1.87
6.68
15.14
33.84
58.17
79.81
91.64
38.728

1.87
4.55
10.07
24.56
49.91
77.58
91.46
33.334

multicondi train
testa

testb

tot_gauss
cln
20
15
10
5
0
-5
0-20

cln
20
15
10
5
0
-5
0-20
400
3.45
4.07
5.5
9.21
20.97
52.07
83.86
18.364

3.45
3.94
4.65
7.9
18.62
50.08
84.61
17.038
1000
2.93
3.33
4.73
8.11
19.21
50.72
83.17
17.22

2.93
3.06
4.01
6.77
16.88
48.77
83.8
15.898
1200
2.8
3.25
4.53
8.01
19.22
51.28
83.39
17.258

2.8
2.98
3.85
6.88
17.24
49.84
85.03
16.158

Yang

From: Alex Hung
Sent: Tuesday, May 2, 2017 4:11 PM
To: AlexHung780312/aurora2_egs
Cc: Yang Sun; Comment
Subject: Re: [AlexHung780312/aurora2_egs] 修正Result.txt (06095fa)

有幾個地方可以參考修改
1. 數字辨識比較特殊，有些人是把0-9都獨立建立一個很長的HMM, 例如20個狀態。
另外optional silence的設計也和HTK不同，Kaldi預設的狀態數較多(改data/lang/topo)
2. gmm mixture數量，這份應該比別人的論文設定少很多
3. 補上CMVN
想不到多年前寫的程式這麼坑人OAO
Alex
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/2a134605-8230-482a-83f4-a01a5d089899 "simple-toolchain-20170504115758806"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/77f702ee-a67e-4987-b577-8ab67780dba6 "simple-toolchain-20170504115758806") deployed [simple-toolchain-20170504115758806](https://github.com/lakeshopper2/simple-toolchain-20170504115758806/releases/tag/deploy-ibm-yp-us-south-T-Impact-IBM-Lab-IBM-Montpellier-space-US-South-20170504-123631 "deploy-ibm-yp-us-south-T-Impact-IBM-Lab-IBM-Montpellier-space-US-South-20170504-123631") to [IBM Montpellier space US South](https://console.ng.bluemix.net/apps/879db9a8-e6e9-48fc-add4-86a25cc413c8 "ibm:yp:us-south:T-Impact IBM Lab:IBM Montpellier space US South"), including this commit


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/2a134605-8230-482a-83f4-a01a5d089899 "simple-toolchain-20170504115758806"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/77f702ee-a67e-4987-b577-8ab67780dba6 "simple-toolchain-20170504115758806") deployed [simple-toolchain-20170504115758806](https://github.com/lakeshopper2/simple-toolchain-20170504115758806/releases/tag/deploy-ibm-yp-us-south-T-Impact-IBM-Lab-IBM-Montpellier-space-US-South-20170504-123642 "deploy-ibm-yp-us-south-T-Impact-IBM-Lab-IBM-Montpellier-space-US-South-20170504-123642") to [IBM Montpellier space US South](https://console.ng.bluemix.net/apps/538590f8-585a-4b0f-aed6-4233881305d6 "ibm:yp:us-south:T-Impact IBM Lab:IBM Montpellier space US South"), including this commit


You will have to update Artus as well when updating to this commit (https://github.com/artus-analysis/Artus/commit/2715088b14e64deebd36815f696c768df2d69734)


Lu prova un pò a vedere se index1 da problemi con il db di mysql


`$as_me:25068` and so on.


I mean the number. What is the rationale of the change, does it come from autoconf? How do you obtain it?


TeamCity libpalaso :: palaso-win32-libpalaso-3.1 Continuous [Build 3.1.360.cec9c1f85ed44b611a46de220f947acfee39530f](http://build.palaso.org/viewLog.html?buildId=89947&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3611, ignored: 128 Build time: 00:05:18


Daniel Havlik your emails are not known to GithHb and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/


TeamCity libpalaso :: palaso-linux64-libpalaso-3.1 Continuous [Build 3.1.317.cec9c1f85ed44b611a46de220f947acfee39530f](http://build.palaso.org/viewLog.html?buildId=89948&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3589, ignored: 111 Build time: 00:05:49


Yeah, I think that's fine.


I did not understand the calls to "self.manager.stop()". Why do you need those if all they do is kill the process (which already does not exist anymore or that code would not have been reached)?


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/c6002db1-5086-47ee-9e57-8a2e56fe9add "simple-toolchain-20170504115955873"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/474c269d-ce4d-4621-a218-a80ec57639d6 "Labs-3a-DevOps") deployed [Labs-3a-DevOps](https://github.com/MathieuLeGuirriec/Labs-3a-DevOps/releases/tag/deploy-ibm-yp-us-south-SopraSteriaMontpellier-Labs-20170504-124141 "deploy-ibm-yp-us-south-SopraSteriaMontpellier-Labs-20170504-124141") to [Labs](https://console.ng.bluemix.net/apps/a79374d5-d600-45db-80cb-9d6fe5d203ba "ibm:yp:us-south:SopraSteriaMontpellier:Labs"), including this commit


You'd better not do this
It may cause Multicraft can't read server's status


@alex-ab please consider this last-minute fixup for alex-ab/17_02_libc_net_vbox5. Thanks.


Thanks so much for this one!


done


Can we use modern string formatting? We are trying to be consistent across all middleware, e.g.

"===> STOPPING VM: {1} ID: {2} BHYVE_CODE: {3}".format(self.vm['name'], self.vm['id'], self.bhyve_error)
or
f"===> STOPPING VM: {self.vm['name']} ID: {self.vm['id']} BHYVE_CODE: {self.bhyve_error}"


![](https://github.trello.services/images/mini-trello-icon.png) [Quand le POSTUser Est effectué sur register..Activity faire un retour à la login activity (Attention bien gérer la destruction de l'activité au changement) + Ajout d'un message à l'accueil cf Image](https://trello.com/c/0ip1wati/83-quand-le-postuser-est-effectue-sur-register-activity-faire-un-retour-a-la-login-activity-attention-bien-gerer-la-destruction-de-)


Nevermind that, I got it now, this is to remove the VMSupervisor from Manager and spawn another one.


merged


Bluemix [toolchain](https://console.ng.bluemix.net/devops/toolchains/c6002db1-5086-47ee-9e57-8a2e56fe9add "simple-toolchain-20170504115955873"): [Delivery Pipeline](https://console.ng.bluemix.net/devops/pipelines/474c269d-ce4d-4621-a218-a80ec57639d6 "Labs-3a-DevOps") deployed [Labs-3a-DevOps](https://github.com/MathieuLeGuirriec/Labs-3a-DevOps/releases/tag/deploy-ibm-yp-us-south-SopraSteriaMontpellier-Labs-20170504-124727 "deploy-ibm-yp-us-south-SopraSteriaMontpellier-Labs-20170504-124727") to [Labs](https://console.ng.bluemix.net/apps/a79374d5-d600-45db-80cb-9d6fe5d203ba "ibm:yp:us-south:SopraSteriaMontpellier:Labs"), including this commit


Minor: unnecessary boxing.


However... If you do that, wont it leave dangling tap interfaces on reboot?


Perhaps its simpler/easier if you having the bhyve spawn process in a separate method and run that in a loop? So if the exit code is == 0, you just spawn the same process again with same args?


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 86](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1566&buildTypeId=Xbim_XbimWebUi_XbimWebUi) is now running


hmm, no, don't add the return in the docstring.  Instead, it is better to remove the return in the function definition.  A handler should never return something


either are fine imo, this is just for extra safety if someone somehow deleted or changed color schemes


ok


Those are just unified patch/diff file hunk location identifiers: https://en.wikipedia.org/wiki/Diff_utility

If you make any change to a file and do `diff -urN original new` it will generate these. They are there so the `patch` program where in `original` to apply the changes to transform it into `new`.

The process for regenerating a `configure` file is a bit complicated. The most important thing is that you need to use the exact same versions of autoconf, autoheader and automake that were used to make the original version otherwise you end up with a huge amount of changes, many cosmetic or unrelated to your changes, some of which could break the build, all of which will generate changes to configure that you cannot build upon with further patches or reason about.

With the right versions installed, the process is:

1. `cp configure configure.orig`
2. Modify/patch `configure.ac` or `*.m4` as appropriate.
3. `autoreconf -vfi`
4. `diff -urN configure.orig configure > 0001-some-changes.patch`


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 86](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=1566&buildTypeId=Xbim_XbimWebUi_XbimWebUi) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:28


[FIX] web: unable to open User FormView from Settings


Seems fine like this!


I would split this into two sentences and remove the brackets.


Starting off with spring, great!


@Liuchang0812 you can file a ticket on tracker and follow to process to do the backport.


![](https://github.trello.services/images/mini-trello-icon.png) [LoginActivity gérer le cas si un user n'a pas validé son compte (champ isValid) Ne pas le faire entrer et afficher un message d'erreur.](https://trello.com/c/GaYW7rFL/67-loginactivity-gerer-le-cas-si-un-user-n-a-pas-valide-son-compte-champ-isvalid-ne-pas-le-faire-entrer-et-afficher-un-message-d-er)


![](https://github.trello.services/images/mini-trello-icon.png) [(4) Alle boards in de database hebben attributen (heeft wifi, heeft 8 cores, heeft 16GB ram) en een anonieme of ingelogde bezoeker kan de grote lijst met alle boards filteren door een of meer kenmerken te selecteren en op 'zoek' te klikken](https://trello.com/c/Zr7OAGU3/47-4-alle-boards-in-de-database-hebben-attributen-heeft-wifi-heeft-8-cores-heeft-16gb-ram-en-een-anonieme-of-ingelogde-bezoeker-kan)


good


[R/children_alt.R:18:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/children_alt.R#L18) *style:* **Variable or function name should be snake_case.**
```r
icd_children_defined_r.icd10cm <- function(x, short_code = icd_guess_short(x), warn = FALSE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/children.R:55:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/children.R#L55) *style:* **Variable or function name should be snake_case.**
```r
icd_children.character <- function(x, ...) {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/children.R:67:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/children.R#L67) *style:* **Variable or function name should be snake_case.**
```r
icd_children.icd9 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~
```
[R/children.R:92:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/children.R#L92) *style:* **Variable or function name should be snake_case.**
```r
icd_children.icd10 <- function(x, short_code = icd_guess_short(x), defined, billable = FALSE, ...) {
^~~~~~~~~~~~~~~~~~
```
[R/children.R:99:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/children.R#L99) *style:* **Variable or function name should be snake_case.**
```r
icd_children.icd10cm <- function(x, short_code = icd_guess_short(x), defined, billable = FALSE, ...) {
^~~~~~~~~~~~~~~~~~~~
```
[R/children.R:139:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/children.R#L139) *style:* **Variable or function name should be snake_case.**
```r
icd_children_defined.icd10cm <- function(x, short_code = icd_guess_short(x), warn = FALSE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/comorbid_alt.R:43:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/comorbid_alt.R#L43) *style:* **Variable and function names should not be longer than 36 characters.**
```r
icd10_comorbid_parent_search_all_at_once <- function(x,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/comorbid.R:40:28:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/comorbid.R#L40) *style:* **Variable or function name should be snake_case.**
```r
"%i9in%" <- function(icd9, icd9Reference) {
                           ^~~~~~~~~~~~~
```
[R/condense.R:36:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/condense.R#L36) *style:* **Variable or function name should be snake_case.**
```r
icd_condense.icd9 <- function(x, short_code = icd_guess_short(x), defined = NULL, warn = TRUE, ...) {
^~~~~~~~~~~~~~~~~
```
[R/condense.R:51:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/condense.R#L51) *style:* **Variable or function name should be snake_case.**
```r
icd_condense.character <- function(x, short_code = icd_guess_short(x), defined = NULL, ...) {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/condense.R:82:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/condense.R#L82) *style:* **Variable or function name should be snake_case.**
```r
  icd9Levels <- levels(x) # NULL if not a factor
  ^~~~~~~~~~
```
[R/convert.R:293:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L293) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_decimal.default <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:306:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L306) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_decimal.icd9 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:314:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L314) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_decimal.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:327:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L327) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_decimal.icd10cm <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:345:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L345) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_short.icd9 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:355:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L355) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_short.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:365:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L365) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_short.icd10cm <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:373:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L373) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_short.default <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:399:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L399) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_parts.icd9 <- function(x, mnr_empty = "") {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:408:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L408) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_parts.icd9 <- function(x, mnr_empty = "") {
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:416:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L416) *style:* **Variable or function name should be snake_case.**
```r
icd_short_to_parts.character <- function(x, mnr_empty = "") {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/convert.R:431:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/convert.R#L431) *style:* **Variable or function name should be snake_case.**
```r
icd_decimal_to_parts.character <- function(x, mnr_empty = "") {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/diff_comorbid.R:59:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/diff_comorbid.R#L59) *style:* **Variable or function name should be snake_case.**
```r
icd_diff_comorbid.list <- function(x, y, all_names = NULL, x_names = NULL,
^~~~~~~~~~~~~~~~~~~~~~
```
[R/diff_comorbid.R:78:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/diff_comorbid.R#L78) *style:* **Variable or function name should be snake_case.**
```r
  common.names <- intersect(x_names, y_names)
  ^~~~~~~~~~~~
```
[R/diff_comorbid.R:80:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/diff_comorbid.R#L80) *style:* **Variable or function name should be snake_case.**
```r
  x.title <- deparse(substitute(x))
  ^~~~~~~
```
[R/diff_comorbid.R:81:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/diff_comorbid.R#L81) *style:* **Variable or function name should be snake_case.**
```r
  y.title <- deparse(substitute(y))
  ^~~~~~~
```
[R/diff_comorbid.R:87:5:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/diff_comorbid.R#L87) *style:* **Variable or function name should be snake_case.**
```r
    only.x <- setdiff(x[[n]], y[[n]])
    ^~~~~~
```
[R/diff_comorbid.R:88:5:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/diff_comorbid.R#L88) *style:* **Variable or function name should be snake_case.**
```r
    only.y <- setdiff(y[[n]], x[[n]])
    ^~~~~~
```
[R/explain-table.R:54:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain-table.R#L54) *style:* **Variable or function name should be snake_case.**
```r
icd_explain_table.default <- function(x, short_code = icd_guess_short(x), condense = FALSE,
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/explain-table.R:69:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain-table.R#L69) *style:* **Variable or function name should be snake_case.**
```r
icd_explain_table.icd9 <- function(...) {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/explain-table.R:76:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain-table.R#L76) *style:* **Variable or function name should be snake_case.**
```r
icd_explain_table.icd10 <- function(...) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/explain-table.R:127:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain-table.R#L127) *style:* **Variable or function name should be snake_case.**
```r
icd_explain_table.icd9cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/explain-table.R:138:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain-table.R#L138) *style:* **Variable or function name should be snake_case.**
```r
icd_explain_table.icd10cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/explain.R:62:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain.R#L62) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.default <- function(x, short_code = icd_guess_short(x), condense = TRUE, brief = FALSE, warn = TRUE, ...) {
^~~~~~~~~~~~~~~~~~~
```
[R/explain.R:74:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain.R#L74) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.list <- function(x, ...) {
^~~~~~~~~~~~~~~~
```
[R/explain.R:81:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain.R#L81) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.icd9 <- function(...) {
^~~~~~~~~~~~~~~~
```
[R/explain.R:88:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain.R#L88) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.icd9cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~
```
[R/explain.R:123:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain.R#L123) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.icd10cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~
```
[R/explain.R:146:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/explain.R#L146) *style:* **Variable or function name should be snake_case.**
```r
icd_explain.icd10 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~
```
[R/generate_mappings.R:311:18:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/generate_mappings.R#L311) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    c(kids, x) %>% unique %>% icd_sort.icd10
               ~~^
```
[R/generate_mappings.R:391:14:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/generate_mappings.R#L391) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
      c(x) %>% unique %>% icd_sort.icd10
           ~~^
```
[R/generate_sysdata.R:125:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/generate_sysdata.R#L125) *style:* **Variable or function name should be snake_case.**
```r
icd9_generate_all_ <- function(major_fun, short_code = TRUE,
^~~~~~~~~~~~~~~~~~
```
[R/generate_sysdata.R:191:17:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/generate_sysdata.R#L191) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
    rtf_url = c( # FY11,12,13,14 are the same?
                ^
```
[R/guess.R:40:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/guess.R#L40) *style:* **Variable or function name should be snake_case.**
```r
icd_guess_version.icd9 <- function(x, short_code, ...) "icd9" #nocov
^~~~~~~~~~~~~~~~~~~~~~
```
[R/guess.R:45:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/guess.R#L45) *style:* **Variable or function name should be snake_case.**
```r
icd_guess_version.icd10 <- function(x, short_code, ...) "icd10" #nocov
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/guess.R:50:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/guess.R#L50) *style:* **Variable or function name should be snake_case.**
```r
icd_guess_version.factor <- function(x, short_code = NULL, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/guess.R:57:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/guess.R#L57) *style:* **Variable or function name should be snake_case.**
```r
icd_guess_version.character <- function(x, short_code = NULL, n = 10, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/guess.R:100:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/guess.R#L100) *style:* **Variable or function name should be snake_case.**
```r
icd_guess_version.data.frame <- function(x, short_code = NULL, icd_name = get_icd_name(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/parse-comorbid.R:85:11:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-comorbid.R#L85) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    out %>% unlist %>% unique %>% as.icd9 %>% as.icd_short_diag -> icd9_map_ahrq[[cmb]]
        ~~^
```
[R/parse-comorbid.R:85:22:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-comorbid.R#L85) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    out %>% unlist %>% unique %>% as.icd9 %>% as.icd_short_diag -> icd9_map_ahrq[[cmb]]
                   ~~^
```
[R/parse-comorbid.R:85:33:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-comorbid.R#L85) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    out %>% unlist %>% unique %>% as.icd9 %>% as.icd_short_diag -> icd9_map_ahrq[[cmb]]
                              ~~^
```
[R/parse-comorbid.R:146:30:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-comorbid.R#L146) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  icd10_map_ahrq[ahrq_htn] %>% unlist %>% unname -> icd10_map_ahrq[["HTNCX"]]
                           ~~^
```
[R/parse-comorbid.R:147:30:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-comorbid.R#L147) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  icd10_map_ahrq[ahrq_chf] %>% unlist %>% unname -> icd10_map_ahrq[["CHF"]]
                           ~~^
```
[R/parse-comorbid.R:148:32:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-comorbid.R#L148) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  icd10_map_ahrq[ahrq_renal] %>% unlist %>% unname -> icd10_map_ahrq[["RENLFAIL"]]
                             ~~^
```
[R/parse-comorbid.R:212:47:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-comorbid.R#L212) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  icd9_map_quan_deyo %<>% as.icd_short_diag %>% icd9 %>% icd_comorbidity_map
                                            ~~^
```
[R/parse-icd10cm-xml.R:39:7:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-icd10cm-xml.R#L39) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  j %>% xml2::xml_children() %>%
    ~~^
```
[R/parse-icd10cm-xml.R:43:7:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-icd10cm-xml.R#L43) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  j %>% xml2::xml_children() %>% magrittr::extract(chapter_indices) -> chaps
    ~~^
```
[R/parse-icd10cm-xml.R:48:14:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-icd10cm-xml.R#L48) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
    c_kids %>% xml2::xml_name() %>% magrittr::equals("section") -> subchap_indices
           ~~^
```
[R/parse-rtf.R:81:21:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L81) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
      code  = out %>% unname %>% icd_decimal_to_short.icd9 %>% icd9cm,
                  ~~^
```
[R/parse-rtf.R:81:32:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L81) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
      code  = out %>% unname %>% icd_decimal_to_short.icd9 %>% icd9cm,
                             ~~^
```
[R/parse-rtf.R:229:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L229) *style:* **Variable or function name should be snake_case.**
```r
  useBytes <- list(...)[["useBytes"]]
  ^~~~~~~~
```
[R/parse-rtf.R:414:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L414) *style:* **Variable or function name should be snake_case.**
```r
  re_fifth_range_V30V39 <- "The following two fifths-digits are for use with the fourth-digit \\.0"
  ^~~~~~~~~~~~~~~~~~~~~
```
[R/parse-rtf.R:415:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L415) *style:* **Variable or function name should be snake_case.**
```r
  re_V30V39_fifth <- "V3[[:digit:]]\\.0[01]$"
  ^~~~~~~~~~~~~~~
```
[R/parse-rtf.R:417:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L417) *style:* **Variable or function name should be snake_case.**
```r
  lines_V30V39 <- grep(re_fifth_range_V30V39, filtered)
  ^~~~~~~~~~~~
```
[R/parse-rtf.R:421:60:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L421) *style:* **Variable or function name should be snake_case.**
```r
    str_pair_match("([[:digit:]])[[:space:]](.*)", ...) -> suffices_V30V39
                                                           ^~~~~~~~~~~~~~~
```
[R/parse-rtf.R:610:11:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L610) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
      v %>%  strsplit("-", fixed = TRUE) %>% unlist -> pair
        ~~^
```
[R/parse-rtf.R:640:10:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L640) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  qual %>% strip %>%
       ~~^
```
[R/parse-rtf.R:647:26:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse-rtf.R#L647) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
      strsplit(v, "-") %>% unlist %>% as.integer -> pair
                       ~~^
```
[R/parse.R:285:61:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse.R#L285) *style:* **Variable or function name should be snake_case.**
```r
                                               perl = TRUE, useBytes = TRUE) {
                                                            ^~~~~~~~
```
[R/parse.R:348:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/parse.R#L348) *style:* **Variable or function name should be snake_case.**
```r
fixSubchapterNa <- function(x, start, end) {
^~~~~~~~~~~~~~~
```
[R/ranges.R:70:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L70) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range.character <- function(start, end, short_code = NULL, defined = TRUE, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:95:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L95) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range.icd10cm <- function(start, end, short_code = icd_guess_short(c(start, end)),
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:143:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L143) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range_major.default <- function(start, end) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:153:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L153) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range_major.icd10cm <- function(start, end) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:160:42:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L160) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  se <- as_char_no_warn(c(start, end)) %>% trim %>% toupper
                                       ~~^
```
[R/ranges.R:177:36:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L177) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  unique_mjrs[pos[[1]]:pos[[2]]] %>% as_char_no_warn() %>% as.icd10cm
                                 ~~^
```
[R/ranges.R:182:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L182) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range.icd9 <- function(start, end,
^~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:336:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L336) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_range_major.icd9 <- function(start, end, defined = TRUE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:426:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L426) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_minor.icd9 <- function(mnr, is_e = FALSE) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/ranges.R:431:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/ranges.R#L431) *style:* **Variable or function name should be snake_case.**
```r
icd_expand_minor.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:42:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L42) *style:* **Variable or function name should be snake_case.**
```r
icd_is_defined.icd9 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~
```
[R/real.R:62:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L62) *style:* **Variable or function name should be snake_case.**
```r
icd_is_defined.icd10cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:78:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L78) *style:* **Variable or function name should be snake_case.**
```r
icd_is_defined.icd10 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~
```
[R/real.R:88:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L88) *style:* **Variable or function name should be snake_case.**
```r
icd_is_defined.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:111:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L111) *style:* **Variable or function name should be snake_case.**
```r
icd_get_defined.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:120:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L120) *style:* **Variable or function name should be snake_case.**
```r
icd_get_defined.icd9 <- function(x, short_code = icd_guess_short(x), billable = FALSE) {
^~~~~~~~~~~~~~~~~~~~
```
[R/real.R:146:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L146) *style:* **Variable or function name should be snake_case.**
```r
icd_is_billable.icd9 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~
```
[R/real.R:157:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L157) *style:* **Variable or function name should be snake_case.**
```r
icd_is_billable.icd10cm <- function(x, short_code = icd_guess_short(x), icd10cm_edition = "2016", ...) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:170:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L170) *style:* **Variable or function name should be snake_case.**
```r
icd_is_billable.icd10 <- function(x, short_code = icd_guess_short(x), icd10cm_edition = "2016", ...) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:179:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L179) *style:* **Variable or function name should be snake_case.**
```r
icd_is_billable.icd9cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:193:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L193) *style:* **Variable or function name should be snake_case.**
```r
icd_is_billable.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:220:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L220) *style:* **Variable or function name should be snake_case.**
```r
icd_get_billable.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:232:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L232) *style:* **Variable or function name should be snake_case.**
```r
icd_get_billable.icd9cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:245:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L245) *style:* **Variable or function name should be snake_case.**
```r
icd_get_billable.icd9 <- function(...) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:275:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L275) *style:* **Variable or function name should be snake_case.**
```r
icd_get_billable.icd10cm <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/real.R:288:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/real.R#L288) *style:* **Variable or function name should be snake_case.**
```r
icd_get_billable.icd10 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~~~~~
```
[R/score.R:76:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/score.R#L76) *style:* **Variable or function name should be snake_case.**
```r
icd_charlson.data.frame <- function(x, visit_name = NULL,
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/score.R:302:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/score.R#L302) *style:* **Variable or function name should be snake_case.**
```r
icd_van_walraven.data.frame <- function(x, visit_name = NULL, return_df = FALSE,
^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/sort.R:39:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/sort.R#L39) *style:* **Variable or function name should be snake_case.**
```r
icd_sort.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~
```
[R/sort.R:52:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/sort.R#L52) *style:* **Variable or function name should be snake_case.**
```r
icd_sort.icd10 <- function(x, short_code = NULL, ...) {
^~~~~~~~~~~~~~
```
[R/sort.R:61:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/sort.R#L61) *style:* **Variable or function name should be snake_case.**
```r
icd_sort.icd9 <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~
```
[R/util.R:192:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/util.R#L192) *style:* **Variable or function name should be snake_case.**
```r
get_visit_name.data.frame <- function(x, visit_name = NULL) {
^~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/util.R:212:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/util.R#L212) *style:* **Variable or function name should be snake_case.**
```r
get_visit_name.matrix <- function(x, visit_name = NULL) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/util.R:281:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/util.R#L281) *style:* **Variable or function name should be snake_case.**
```r
get_non_ASCII <- function(x)
^~~~~~~~~~~~~
```
[R/util.R:286:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/util.R#L286) *style:* **Variable or function name should be snake_case.**
```r
is_non_ASCII <- function(x)
^~~~~~~~~~~~
```
[R/util.R:328:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/util.R#L328) *style:* **Variable or function name should be snake_case.**
```r
chapter_to_desc_range.icd9 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/util.R:334:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/util.R#L334) *style:* **Variable or function name should be snake_case.**
```r
chapter_to_desc_range.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:245:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L245) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:257:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L257) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid.icd10 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~~
```
[R/valid.R:274:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L274) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid.icd9 <- function(x, short_code = icd_guess_short(x),
^~~~~~~~~~~~~~~~~
```
[R/valid.R:331:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L331) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid_major.default <- function(x, whitespace_ok = TRUE) {
^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:339:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L339) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid_major.icd9 <- function(x, whitespace_ok = TRUE) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:346:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L346) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid_major.icd10 <- function(x, whitespace_ok = TRUE) {
^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:370:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L370) *style:* **Variable or function name should be snake_case.**
```r
icd_is_valid.icd_comorbidity_map <- function(x, short_code, ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:396:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L396) *style:* **Variable or function name should be snake_case.**
```r
icd_get_valid.character <- function(x, short_code = icd_guess_short(x)) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:408:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L408) *style:* **Variable or function name should be snake_case.**
```r
icd_get_valid.icd9 <- function(x, short_code = icd_guess_short(x)) {
^~~~~~~~~~~~~~~~~~
```
[R/valid.R:415:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L415) *style:* **Variable or function name should be snake_case.**
```r
icd_get_valid.icd10 <- function(x, short_code = icd_guess_short(x)) {
^~~~~~~~~~~~~~~~~~~
```
[R/valid.R:422:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L422) *style:* **Variable or function name should be snake_case.**
```r
icd_get_valid.icd10cm <- function(x, short_code = icd_guess_short(x)) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:440:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L440) *style:* **Variable or function name should be snake_case.**
```r
icd_get_invalid.default <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:454:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L454) *style:* **Variable or function name should be snake_case.**
```r
icd_get_invalid.icd9 <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:461:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L461) *style:* **Variable or function name should be snake_case.**
```r
icd_get_invalid.icd10 <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:469:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L469) *style:* **Variable or function name should be snake_case.**
```r
icd_get_invalid.icd_comorbidity_map <- function(x, short_code = icd_guess_short(x), ...) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:490:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L490) *style:* **Variable or function name should be snake_case.**
```r
icd_get_major.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~~
```
[R/valid.R:503:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L503) *style:* **Variable or function name should be snake_case.**
```r
icd_is_major.default <- function(x) {
^~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:514:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L514) *style:* **Variable or function name should be snake_case.**
```r
icd_is_major.icd10 <- function(x) {
^~~~~~~~~~~~~~~~~~
```
[R/valid.R:524:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L524) *style:* **Variable or function name should be snake_case.**
```r
icd_is_major.icd10cm <- function(x) {
^~~~~~~~~~~~~~~~~~~~
```
[R/valid.R:531:1:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/R/valid.R#L531) *style:* **Variable or function name should be snake_case.**
```r
icd_is_major.icd9 <- function(x) {
^~~~~~~~~~~~~~~~~
```
[tests/testthat/test-class.R:207:19:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-class.R#L207) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  icd9_map_ahrq %>% unclass %>% icd_comorbidity_map -> x
                ~~^
```
[tests/testthat/test-comorbid-maps-icd9.R:176:50:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-comorbid-maps-icd9.R#L176) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                     icd9_map_quan_elix[["DMcx"]] ))
                                                 ^
```
[tests/testthat/test-comorbid-maps-icd9.R:178:50:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-comorbid-maps-icd9.R#L178) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                     icd9_map_quan_elix[["Mets"]] ))
                                                 ^
```
[tests/testthat/test-comorbid-maps-icd9.R:180:45:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-comorbid-maps-icd9.R#L180) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                     icd9_map_elix[["DMcx"]] ))
                                            ^
```
[tests/testthat/test-comorbid-maps-icd9.R:182:45:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-comorbid-maps-icd9.R#L182) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
                     icd9_map_elix[["Mets"]] ))
                                            ^
```
[tests/testthat/test-comorbid-maps-icd9.R:183:70:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-comorbid-maps-icd9.R#L183) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_false(any(icd9_map_ahrq[["DM"]] %in% icd9_map_ahrq[["DMcx"]] ))
                                                                     ^
```
[tests/testthat/test-comorbid-maps-icd9.R:184:73:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-comorbid-maps-icd9.R#L184) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_false(any(icd9_map_ahrq[["Tumor"]] %in% icd9_map_ahrq[["Mets"]] ))
                                                                        ^
```
[tests/testthat/test-comorbid-maps-icd9.R:695:32:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-comorbid-maps-icd9.R#L695) *style:* **`%>%` should always have a space before it and a new line after it, unless the full pipeline fits on one line.**
```r
  res_nofactor <- vermont_dx %>% icd_wide_to_long %>% icd9_comorbid_ahrq
                             ~~^
```
[tests/testthat/test-convert.R:24:16:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-convert.R#L24) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_equal( icd_decimal_to_parts.icd9(""), list(mjr = NA_character_, mnr = NA_character_) )
               ^
```
[tests/testthat/test-convert.R:24:94:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-convert.R#L24) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_equal( icd_decimal_to_parts.icd9(""), list(mjr = NA_character_, mnr = NA_character_) )
                                                                                ^
```
[tests/testthat/test-convert.R:197:13:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-convert.R#L197) *style:* **Variable or function name should be snake_case.**
```r
            icd9List <- icd9_map_ahrq #todo SUBSET OR EXTRA MAPPINGS?
            ^~~~~~~~
```
[tests/testthat/test-lints.R:19:38:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-lints.R#L19) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
    "package:devtools" %nin% search() ) {
                                     ^
```
[tests/testthat/test-ranges.R:252:23:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-ranges.R#L252) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_equal_no_icd( ("042" %i9s% "042")[1], "042")
                      ^
```
[tests/testthat/test-score.R:40:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-score.R#L40) *style:* **Variable or function name should be snake_case.**
```r
  c2.inv <- cbind(t(comorbids[2, 2:18]), c(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 2, 2, 2, 2, 3, 6, 6))
  ^~~~~~
```
[tests/testthat/test-score.R:237:3:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-score.R#L237) *style:* **Variable or function name should be snake_case.**
```r
  c2.inv <- cbind(t(comorbids[2, -1]),
  ^~~~~~
```
[tests/testthat/test-valid.R:392:109:](https://github.com/jackwasey/icd/blob/84f21408e5faf05497bbce7e6915abea204fd233/tests/testthat/test-valid.R#L392) *style:* **Do not place spaces around code in parentheses or square brackets.**
```r
  expect_equal(icd9_filter_valid(pts_invalid_mix, short_code = TRUE, invert = FALSE), pts_invalid_mix[c(1, 3 ), ])
                                                                                ^
```


@skyarkhangel


big tnx 👍


Didn't you mean `max` rather than `min`? From https://github.com/diml/utop/blob/master/src/lib/uTop.mli#L100:

```ocaml
val set_margin_function : (LTerm_geom.size -> int option) -> unit
  (** Margin of the standard and error formatters as a function of the screen size.
      The default is:
      {[
        fun size -> Some (max 80 size.cols)
      ]}
  *)
```


thanks, I will file a ticket if it should be back-ported.


ugh, material class changes.
Don't go breaking backwards compatibility here of all places.


kishor kumar ravi


Lo he preguntado en el foro y por lo visto sí que es necesario así que lo tengo que incluir en el códgo

![2017-05-04 5](https://cloud.githubusercontent.com/assets/23742881/25704534/1d0709fc-30da-11e7-8d5a-a5e062e04d80.png)


this would need to be in test/REQUIRE, if it were getting run by Pkg.test


So I think the problem is that the `RewriteContext` outlives some of the statistics infrastructure in the case of the static file rewriter. So when we try to decrement the counter, some essential stuff already is cleaned up.
Maybe tracking initiated rewrites and calls to `RewriteContext::RewriteDone()` may work instead? We'd have to make sure these are acually paired (so for every call to `RewriteContext::Initiate` there should be exactly one matching call to `RewriteContext::RewriteDone`)

```diff
diff --git a/net/instaweb/rewriter/rewrite_context.cc b/net/instaweb/rewriter/rewrite_context.cc
index 698dc85bb..30406d896 100644
--- a/net/instaweb/rewriter/rewrite_context.cc
+++ b/net/instaweb/rewriter/rewrite_context.cc
@@ -1044,7 +1044,6 @@ RewriteContext::RewriteContext(RewriteDriver* driver,
         Driver()->statistics()->GetUpDownCounter(
             kNumRewriteContextReferenceCount)) {
   DCHECK((driver == NULL) != (parent == NULL));  // Exactly one is non-NULL.
-  num_rewrite_context_ref_count_->Add(1);
   partitions_.reset(new OutputPartitions);
 }

@@ -1052,7 +1051,6 @@ RewriteContext::~RewriteContext() {
   DCHECK_EQ(0, num_predecessors_);
   DCHECK_EQ(0, outstanding_fetches_);
   DCHECK(successors_.empty());
-  num_rewrite_context_ref_count_->Add(-1);
   STLDeleteElements(&nested_);
 }

@@ -1106,6 +1104,7 @@ void RewriteContext::RemoveLastSlot() {
 void RewriteContext::Initiate() {
   CHECK(!started_);
   DCHECK_EQ(0, num_predecessors_);
+  num_rewrite_context_ref_count_->Add(1);
   Driver()->AddRewriteTask(new MemberFunction0<RewriteContext>(
       &RewriteContext::Start, this));
 }
@@ -1949,6 +1948,7 @@ void RewriteContext::NestedRewriteDone(const RewriteContext* context) {
 void RewriteContext::RewriteDone(RewriteResult result, int partition_index) {
   // RewriteDone may be called from a low-priority rewrites thread.
   // Make sure the rest of the work happens in the high priority rewrite thread.
+  num_rewrite_context_ref_count_->Add(-1);
   Driver()->AddRewriteTask(
       MakeFunction(this, &RewriteContext::RewriteDoneImpl,
                    result, partition_index));
```


Yeah I think some miscommunication happened. Those were unrelated tests for the Canonical Distribution of Kubernetes. Which is a completely different effort than whats going on with the GKE/GCE engineers.

We lost a good chunk of historical data there, and really we're kind of wondering what we should do to start republishing results without risking another phaux-paus :)


Fixes issue #158


appnanahacktokeniddownload.html


@fabianfrz will do


Thanks, I missed this nice feature.


Hey, currently this is breaking in http://hub.docker.com/_/node (even w/ debian-based images)

```sh
> magnet build -C config && magnet start -C config

/usr/bin/env: node --trace-warnings: No such file or directory
```


[IMP] qweb: The template name used by "t-call" can be generated from …

=>

[IMP] web: extend qweb to allow dynamic templates in t-call


Woop! Yep: https://github.com/Automattic/wp-calypso/pull/13618

Thanks.


Beyler master'a mergeliyim mi?


pasoev.com


"if false" seriously?


Yes, it's not being tested right now. This was just a quick way to stash this code for testing before it's fully implemented. In a few weeks this will become "a full thing", in which case yes test/REQUIRE will be updated.


* Indeed the third column is the result of the NN. The violent changes are simply the network still learning and having a bad error rate. During the training you can see summary outputs of the current error value. I don't know what _good_ values are for G_Loss and D_Real_Loss. Just again note that the project states it trained for 130,000 batches. I think I currently only did about 500, so I think on a CPU I would need to run non-stop for about a week to get some more decent results. I say non-stop because the current code doesn't reload the last values it stored in the checkpoint when training, so it always starts from scratch.
* Your interpretation of the columns is about right. This is the description in the readme: "From left to right, the first column is the 16x16 input image, the second one is what you would get from a standard bicubic interpolation, the third is the output generated by the neural net, and on the right is the ground truth." For the code you can look at _summarize_progress in srez_train.py.
* I was also a bit surprised to see there was no 'execute' kind of function where after the learning you can provide your own 16x16 image and see what comes out. I'm guessing that for somebody with decent TensorFlow knowledge (or for the original author) this is trivial to write, but for myself I haven't gotten around to it yet to try writing that code.


Due to the concurrency/synchronization constructs that `lazy` adds we should instead use our own lazy init.
```
private var _receive: OptionVal[Receive[T]]
private def receive: Receive[T] = _receive match {
  case OptionVal.None =>
    _receive = createReceive
    _receive
  case OptionVal.Some(r) => r
}


video 39


Are you sure? I am talking about this expression:
```
++(eval echo $as_me:25117: \"$ac_link\") >&5
```

Not this one:
```
+@@ -25082,7 +25097,7 @@
```

Sorry to bother you with this. I hope it is not too stupid, but I never needed to look into autoconf so far.


If you lose the brawl, it'll actually show a victory scene with the NPCs, but I didn't know they just flat out use the same system as conventional heroes.


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.434.4454b5c977b50368ae674382e36cf9616696657c](http://build.palaso.org/viewLog.html?buildId=89952&buildTypeId=bt2) outcome was **FAILURE**
Summary: Tests passed: 950, ignored: 51; exit code 1 Build time: 00:27:02


No … since this is a fork. Would you like to have a PR with this?


Not very sure why; `env` is properly finding `node` in `$PATH`:

```sh
root@2305063eb0e7:/wedeploy-container# echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
root@2305063eb0e7:/wedeploy-container# which node
/usr/local/bin/node
root@2305063eb0e7:/wedeploy-container# which nodejs
/usr/local/bin/nodejs
root@2305063eb0e7:/wedeploy-container# /usr/bin/env node
>
(To exit, press ^C again or type .exit)
```


ouch...


commit is ok


function opinter


I think curly braces are mandatory in VCL


![](https://github.trello.services/images/mini-trello-icon.png) [Less detailed datetime on alert updates](https://trello.com/c/t05rCGkU/49-less-detailed-datetime-on-alert-updates)


should be more specific, https://github.com/JuliaLang/julia/commit/333ad95dca96bcfafc85513c38d266b77cc7ef75
or use Compat.Iterators


I had issues with running phantomjs with karma after packages update.
And chrome solved this problem. I think having chrome/chromium isn't an issue for any developer who wants to test it. And travis integration is working now too.
So, it's ok I think


![](https://github.trello.services/images/mini-trello-icon.png) [#19.01 - Реалізувати MySqlManagerDao](https://trello.com/c/NS0Z7Tii/60-19-01-mysqlmanagerdao)


After presentations this morning come see me about your dependencies.


Docker image: 496870459963.dkr.ecr.eu-west-1.amazonaws.com/photobox/jenkins-tests:testing_2
Endpoint: http://jenkins-tests-jenkins-testing.k8s-test.photobox.com


yes!


That change had impact on the output for http://trac.cppcheck.net/ticket/7868 ...


empty project repository created


This implementation may be a bit naive. the issue is that all the circles gets the new colour not only the new circle.

If we want this feature we'll have to implement a way for the node visualizer to differentiate between the circles