Thank you for the in depth review.

I do not have experience with AWS X-Ray Tracing so I am not sure how it works.

In response:
1. Thank you for your work on this project, its amazing. I am using Lambda for python code, but serverless for deployment. I have experimented on a dockerfile that is based on the python-build but adds the nodejs runtime tarball. I am reviewing this code for security and thought I would share this issue in the public. Based on the amazing work you have done, I can build my own lambda environments so I don't need anything changed, but wanted to raise the issue.
2. My concern before digging any further is that any public source can submit AWS X-Ray data to the account that generated this root/parent combination. It might be nice to see if it works with a fuzzed value instead. e.g. `Root=a-aaaaaaaa-aaaaaaaaaaaaaaaaaaaaaaaa;Parent=aaaaaaaaaaaaaaaa;Sampled=0`
3. Without looking back at this code, I think this is generated by saving the lambda environment
4. I am not concerned about root/parent combinations leaking information (the same as sharing an ARN), but rather that root/parent combinations are an ARN that could accidentally be permissive and receive sensitive data on execution. An example is someone who develops a chrome extension and adds telemetry for javascript errors soon to find that they are flooded in telemetry for javascript errors on every site a user visits.
5. X-Ray appears to be an APM like New Relic APM or DataDog APM so has access to everything
6. (nothing to add)

I forgot about lambci! That's why it sounds familiar. Awesome stuff! I found this particular docker repo because of: https://github.com/UnitedIncome/serverless-python-requirements/blob/master/index.js#L104-L106

```es6
        const image = this.custom().dockerImage
         || `lambci/lambda:build-${runtime}`;
        this.serverless.cli.log(`Docker Image: ${image}`);
```

tl;dr If you have time to test fuzzing these values or finding documentation about how AWS X-Ray works to prove this root/parent just an artifact of that invocation being traced rather than a key to submit X-Ray data that would be awesome and I would be in your debt. I could not find such documentation so I will have to either private fork the docker image or read the AWS X-Ray code/docs further. Again, thanks!!!! This repository is incredibly useful and well-executed!


Map of what? Rename it, name should be more specific


This is more or less... I mean, fewer... an okay commit.


接受关于代码风格的批评, 不过我没有用Eclipse编写这个scala例程. 另外, 请避免引起门户之争. 对于IDE和语言的优劣问题不应该成为这里的讨论重点. 谢谢.


No.  optdone is ensured to `bool` already.  `len` isn't defined for them. (This line was breaking some tests)


I think the method name should be

IsItalicAndAriaHidden

And have the javadoc state that it is for Icon libraries.


@nedtwigg From what I understand of the conversation that occurred in the corresponding issue or PR, one overload of `licenseHeader` is actually allowed? If so, this comment should probably be updated.


and the story of how 48k guilds got spammed


It is definitely a nice to have.  I have thought about this too.  It is a relatively low-pri compared to the other testing priorities.  But will be happy to see this.


You manage 404 code in servlet. We don't need this block here anymore


I found a lot more cases without a space. Try searching for "Scan" in the
resource file.

On Aug 2, 2017 20:41, "Kacper Michajłow" <notifications@github.com> wrote:

> What other cases?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/kasper93/mpc-hc/commit/dc0ed95895dddd467ff36005bad625832a7b5a5c#commitcomment-23440180>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAVVtae59tNBnEKf8uVjPjeJnTwn4KLRks5sULS8gaJpZM4Oqtt7>
> .
>


Good idea.


```
if @resource[:name].is_a?(Hash)
```

needs to be:

```
property.value.is_a?(Array)
```


The following doc(s) have been deployed to the [solrreinde](https://solrreinde-static-docs.pantheonsite.io/docs) Multidev environment:
- [/docs/solr](https://solrreinde-static-docs.pantheonsite.io/docs/solr)


sort of, it is related, the default was for an invalid value so the migration fixes that.


replaced earlier files with a release candidate version for the proof of concept


This is correct. https://github.com/koalaman/shellcheck/wiki/SC2068

Without quotes its wrong
```bash
 $ echo_lines() {   for arg in $@; do echo $arg; done }
 $ echo_lines a b c
a
b
c
 $ echo_lines 'a b' c
a
b
c
```

And with quotes
```bash
$ echo_lines() {   for arg in "$@"; do echo $arg; done;  }
 $ echo_lines a b c
a
b
c
 $ echo_lines 'a b' c
a b
c
```


Thank you based @beane


resolves #417


This appears to have not worked and has removed these options from the linux build as well.


I don't see any other.


i was going to open the issue and saw the commit, but would be interesting test for another feature that all repositories have, what do you think ? maybe the property "repositoryName" ?


we should pass the err and the data to the callback function(cb) like { cb(err,result }
to pass the err to handle it if occurs .


支持全角符号对于公式来说也许有价值, [这位也提到](https://tieba.baidu.com/p/5246905084?pid=110027363531#110027363531). 欢迎新开issue讨论.


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/6b8b7163-1ec8-4616-82fa-aa467a17af03 "storybook-toolchain-v2"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/b84aaac8-8484-4a1e-902a-ebb526eb7998 "storybook-toolchain-v2") deployed [carbon-components-react](https://github.com/carbon-design-system/carbon-components-react/releases/tag/deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-175510 "deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-175510") to [Bluemix Design System](https://console.bluemix.net/apps/6face6ef-4e84-4702-b0ae-850e67702e19?env_id=ibm:yp:us-south "ibm:yp:us-south:chrisdhanaraj_org:Bluemix Design System"), including this commit


I think this is the sort of file that git repos are better off without.
But see if you think inclusion of new file  announcement-sample-file.tex ,
in [master 9d92ea4], is enough to address the problem.


Yup, you are right. They are 3 cases.


@vigneshshanmugam Why do not you use the cache anymore?


На x64 по-моему не проверял


note:
require a module used for node ,in the back-end and for test when testing the fronted functions!!
careful !


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/6b8b7163-1ec8-4616-82fa-aa467a17af03 "storybook-toolchain-v2"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/b84aaac8-8484-4a1e-902a-ebb526eb7998 "storybook-toolchain-v2") deployed [carbon-components-react](https://github.com/carbon-design-system/carbon-components-react/releases/tag/deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-180012 "deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-180012") to [Bluemix Design System](https://console.bluemix.net/apps/94bb6708-16dc-4a63-b787-02351fe0dfa6?env_id=ibm:yp:us-south "ibm:yp:us-south:chrisdhanaraj_org:Bluemix Design System"), including this commit


submit does nothing!
update the page with the data that came from the response => Dom it ^_^


Add width 100% and the AD will be centered


have you tested that the following allocation *won't* get optimized away?
```
function non_fully_hardcoded(x) {
  var obj = {prop: x};
  return obj.prop;
}
```


In this case, find isn't really doing anything.  Bash is going to resolve the *_redmine_backup.tar and pass a list of files to find which is just going to echo them back.  So either ls or find, doesn't really matter.


This replacement of grep with wildcard is a good catch.   Again the ls vs find doesn't matter.


vc


f


脑子一时啥了 改了这个 明天回滚


ممنون ... فعلا چون فقط تمرکز روی تهرانه به همین شکل نمایش دادم اگه تعداد شهرها بیشتر شد جرئیات بیشتری رو در نظر می‌گیرم


This variable was flagged as never being set.  After running a search it does appear like its never set anywhere in this project.
https://github.com/sameersbn/docker-redmine/search?q=config_default_attachments_storage_path&type=Code&utf8=%E2%9C%93


Run here
[http://sandbox.onlinephpfunctions.com/](Compile here)


I think not optional ```session: Session``` could be a better idea. Since, we usually check once in middleware.


changes made


Thanks @deepak-srivastava this does appear to work in conjunction with your changes to the Pcpteams core code.

How do you think this necessary change could be incorporated into core and/or can your extension override or extend this core file?  Please advise.


Anyway, i would merge this change, but it should be removed ASAP.


I noticed that you pulled these out in your PR. I'm not against the change but I wanted to limit this to only the things that your PR needed and that was directly related to all of the weird conditional enabling of stuff.


Although doesSupportNativeDiff is a good descriptive name I find it a bit too phonetically similar to the opposite useNaiveDiff. Nevertheless LGTM


you should take out puts for production code


Hey Vitalik,

Check Gitter. I want to get you on the CBC.


Good idea 👍


I didn't want this to become an omnibus cleanup effort. Changes are limited to the stuff noted above. Again, not against the change, it's just not related to the type marshaling stuff or the stated intent of the patches. Very reasonable to kill this off / clean this up but IMHO it should be in a separate commit.


it "increases the number of posts by one"


I know you hate these MAX things and I agree that they're a bit silly. Should still be in a separate commit and and likely a different PR.


"does not increase after a second click"


**Receipt Template backup on 02/08/2017**
[SalesReceiptTemplate.zip](https://github.com/KITSHarikrishnanSubramani/kits-deadpool-artifacts/files/1194857/SalesReceiptTemplate.zip)


context :back


increases the number of votes by one. <- turn this into a helper


also reused


Two slaps


69/69 commit
69/420 commit message


repeated


Kangers


@nathanchance ah - all is well :)

not sure why that change is missing here locally,

anyway - will re-sync ;)


This text could be modified.


Ah, so if I understand correctly, your only concern is that `Root=1-dc99d00f-c079a84d433534434534ef0d;Parent=91ed514f1e5c03b2;Sampled=0` might be a real value which someone could use to mess with *my* AWS account? (ie, the account that I used to dump the lambda env values from in the first place)

If that's it, then never fear! It's a fake value. The hex digits don't represent anything real – they were just copy/pasted from the log stream name: https://github.com/lambci/docker-lambda/blob/master/base/dump-nodejs43.js#L61 – which, I can't remember if I faked that too, probably did, but in any case the log stream doesn't exist anymore so it's moot.

I got *very* confused by your description of leaking details of a failed build to another AWS account's X-Ray, hence why I thought you might be thinking of LambCI.

Thanks for the concern though!


As a practical matter, it is nearly impossible to find a regex that will work for arbitrary buildscripts.  So for a user exploring a README, I think we point them down a more productive path if we say "you can't put a license header on scripts because there's no package statement" than to say "it is possible to wage a war with regexes if you want to".  If they are determined to fight that war, they will find that it is possible.


what's up with the spaces?


Oh! Of course. I hadn't considered that. Fair enough. :)


five thousand million? :-P

The condition is not "if the object is fully hardcoded", but "if the object doesn't 'escape' (in other words, whether the outside world can actually observe whether an object has been created or not)".


"is assigned to user"


Why was it not an issue when running from the CLI?


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/f253fded-6bed-4235-a7d9-b9dbd736bb6a "UI-yp-SimpleTC0802T141359"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/cccd8868-a675-4c4e-a4dd-187cf7754a0c "UI-yp-SimpleTC0802T141359") deployed [UI-yp-SimpleTC0802T141359](https://github.com/idsb3t1/UI-yp-SimpleTC0802T141359/releases/tag/deploy-ibm-yp-us-south-idsb3t4-us.ibm.com-dev-20170802-181658 "deploy-ibm-yp-us-south-idsb3t4-us.ibm.com-dev-20170802-181658") to [dev](https://console.bluemix.net/apps/c4a511fb-1ac3-41b6-adb1-91dc1c02fc3c?env_id=ibm:yp:us-south "ibm:yp:us-south:idsb3t4@us.ibm.com:dev"), including this commit


IMO, remove this line and mention CRLF directly, no need to explicitly expand CRLF


1000 seems to be quite arbitrary. Why don't we move the button check to the`if (i == period)` section?


I made this change because we'll need to refer to some line numbers in the paper when we finalize on the examples. Also changed style to `tango` because I personally find the default style having too much red text that hurts my eyes ...


I'd suggest to wrap reportmemleak option into {$ifdef debug} additionally


Так почему бы не объявить об этих результатах тут?

> Наш конкурс подошел к концу, в течении нескольких дней я соберу отзывы жюри и объявлю официального победителя!
Я как бы ожидал бы увидеть обещанное объявление результатов. Ну ок. Хотя бы это не было кидаловом.


I modified [v1b above](https://github.com/seredat/karbowanec/commit/231db5270acb2e673a641a1800be910ce345668a#commitcomment-23056659) a little bit to be what I think is best.


The following doc(s) have been deployed to the [2233drupal](https://2233drupal-static-docs.pantheonsite.io/docs) Multidev environment:
- [/docs/drupal-cron](https://2233drupal-static-docs.pantheonsite.io/docs/drupal-cron)


Hallo @FredKruse !
Danke für deine tollen Beiträge. Im gestrigen regression test fiel mir auf, dass auch "Hinzu kam, dass ..." als Fehler erkannt wird. Das ist aber korrekt! Dasselbe Problem (und einige andere) hatte ich vor einiger Zeit als ich die
<rulegroup id="ZUSAMMENGESETZTE_VERBEN" name="auf halten (aufhalten)">
geschrieben habe. Kannst du dir das bitte nochmal ansehen?

Auf http://forum.languagetool.org/t/de-false-positives-and-false-false/1516/241 wurde ein Fehler gemeldet, der vermutlich auch mit einer deiner jüngsten Änderungen im Zusammenhang steht. Kannst du dir das bitte ebenfalls ansehen?


Super, parece que todo esta funcionando ya en python3!!!


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/6b8b7163-1ec8-4616-82fa-aa467a17af03 "storybook-toolchain-v2"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/b84aaac8-8484-4a1e-902a-ebb526eb7998 "storybook-toolchain-v2") deployed [carbon-components-react](https://github.com/carbon-design-system/carbon-components-react/releases/tag/deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-182142 "deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-182142") to [Bluemix Design System](https://console.bluemix.net/apps/ab545254-9cb2-4643-b2c4-46c37cfae66b?env_id=ibm:yp:us-south "ibm:yp:us-south:chrisdhanaraj_org:Bluemix Design System"), including this commit


You had two loops before. Now you have only one. Why?


Ok, not sure what tango style looks like but I do not really care.


You don't need i and inputs. Leave only elem.


Benachmarks:
```
<example>Das ist Unsinn; hinzu kommt, dass es gelogen ist.</example>
                <example>Hinzu kommt, dass es gelogen ist.</example>
                <example>Denn hinzu kommt, dass es gelogen ist.</example>
                <example>Das ist Unsinn; und hinzu kommt, dass es gelogen ist.</example>
                <example>Ich will ihn nicht außen vor lassen.</example>
```


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170802-182433 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170802-182433") to [prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "ibm:yp:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170802-182438 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170802-182438") to [prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "ibm:yp:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-Prod-20170802-182444 "deployed-2-env-Prod-20170802-182444") to [Prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "There was a problem retrieving the space name"), including this commit


All tests passed on travis: https://travis-ci.org/dpkp/kafka-python/builds/211101347

Can you open an issue and provide any more context about what test failures you are seeing?


Yeah, I'll consider it. I kinda regretted pulling it because it took me more than 3 days to make it ready for prime time (fix the layout, support block zoom and keyboard navigation & entry, add sound feedback, eliminate the NoteInput class etc.), and I bet that people will still complain...


Curious to know why buttons are unselectable. This is not accessible via keyboard.


Ah okay, if that's the only reason for using it I'd sooner not. It just seems to be obfuscating the code without reason, especially given we've set the president elsewhere of not using it


I did a 3 day poll on Twitter @Chris-Prime

Also I could literally delete your FactionsPE repo ;)


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/6b8b7163-1ec8-4616-82fa-aa467a17af03 "storybook-toolchain-v2"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/b84aaac8-8484-4a1e-902a-ebb526eb7998 "storybook-toolchain-v2") deployed [carbon-components-react](https://github.com/carbon-design-system/carbon-components-react/releases/tag/deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-182844 "deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-182844") to [Bluemix Design System](https://console.bluemix.net/apps/5f8eb587-5f54-4ea1-8330-d2ebaed2ce33?env_id=ibm:yp:us-south "ibm:yp:us-south:chrisdhanaraj_org:Bluemix Design System"), including this commit


CRONT TAB TIME


Oh, sorry. You have to use for..of loop. Because you have array of html elements.


ok))


It shouldn't be a swallow all exception. If you narrow it down to a specific exception I will accept the pull request.


There are on Duckbox Developers, no more cdk git.


Are you going to break the site again @aspleenic? 😝


indeed but any idea why?


new description


Oh, looks like your build passed. Good work!


@donJusto C'est bizzare, c'est comme si tu as juste fais un copier coller et non validé le pull request


@cristim are these lines taking care of the issue ?  or you want to take care of the logic above?
```
+	if allowedInstanceTypes != "" {
 +		allowed = allowedInstanceTypes
 +	} else {
 +		allowed = allowedInstanceTypesTag
 +	}
```


case = cast :man_facepalming:


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/6b8b7163-1ec8-4616-82fa-aa467a17af03 "storybook-toolchain-v2"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/b84aaac8-8484-4a1e-902a-ebb526eb7998 "storybook-toolchain-v2") deployed [carbon-components-react](https://github.com/carbon-design-system/carbon-components-react/releases/tag/deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-183302 "deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-183302") to [Bluemix Design System](https://console.bluemix.net/apps/b55deb2a-ffe1-4f39-a4c1-941ab71bffb3?env_id=ibm:yp:us-south "ibm:yp:us-south:chrisdhanaraj_org:Bluemix Design System"), including this commit


ok


Yes, I meant `.jp`. Sorry about that.

`jpe?g|jpe` doesn't create a new capture group and is 1 (!) char shorter than `jp(e|g|eg)` (or 3 shorter than `jp(?:e|g|eg)` which is kind of why I've used that.

This regex pattern actually incorporates a huge flaw, now that I look at this again: Python's `re.match()` doesn't require the whole string to be matched, but just from the start until all of the regex pattern is consumed:
The regex "abc" matches, for example, the string "abcandmore". Likewise would `https://example.org/abc.jpgabc` be a positive match for the regex above.


you can use the Switch instide of if  else if else if ,more cleaner!
like
switch(url){
  case: '/'
     break;
case: '/api/uni/?q='
     break;
and so on >>}


No PR for this?


Thanks @grabbou


pls, add a comma after the string...


Woops this is supposed to be an array and not a string


Because it will not hit that code unless a valid reader field is available and we will have an infinite loop.


it's a good practice to pass your errors to the call backs to eventually got handled


I've just gone back to this and the errors don't come up even without that line. This is using [pycodestyle](https://pypi.python.org/pypi/pycodestyle) (previously pep8) - which one are you using?


1 is map, 2 is each ?!


The goal is just to reduce the times we check at the exact moment we need to transition from open to shorted.


Geiler commit Philip!


saw approval from jedmccaleb
at https://github.com/vogel/stellar-core/commit/dc07dad9a12ae117d2d35afdc2ba904c1664f982


merging vogel/stellar-core/fix-history-test = dc07dad9 into auto


vogel/stellar-core/fix-history-test = dc07dad9 merged ok, testing candidate = 4e45f3f3


I'm definitely open to better implementations.  This is a hack. :)


I also try for..of / for..in  in this loop, wtf,but it doesn't work... mb you can show me how it correctly?


Nice. I was about to send you a note on this problem :)


@TriggerSFDC  This for loop is really not necessary. You can do the same in the first for loop itself.


**Luke 4:3** now has a full-stop immediately after the verse number!

`\v 3. Go Tiabolo eka tikinias, wan ba fi nani Atua ba tiki fetu netu is ega hi tea famiena. `


Ok... well I mean he really deserves more credit than I do.

--
Michael Ball
From my iPhone
michaelball.co

> On Aug 2, 2017, at 11:26 AM, Jens Mönig <notifications@github.com> wrote:
>
> Yeah, I'll consider it. I kinda regretted pulling it because it took me more than 3 days to make it ready for prime time (fix the layout, support block zoom and keyboard navigation & entry, add sound feedback, eliminate the NoteInput class etc.), and I bet that people will still complain...
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.
>


I think we can make the jackson libs a regular apoc dependency, hopefully they are not that big.


Adding a comment...what happens now?


should the compatible values go into the `getMongoColl` then you don't have to add it to *each* method.


actually you don't even need the annotation.

> automatic with method signature
_from https://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/converters.html_


👍 Agreed.. would be nice to the library come pre-bundled.


@TriggerSFDC , This for loop is wrong. Because if we are inserting three active contact records for one Account, where are you storing that in the `accIdActiveConMap` variable? Try inserting 3 active contacts for a new Account which does not have any contacts related then it should stop but it won't


we could probably make it static. or only initialize the object mapper if the compatibleValues is passed into the constructor. I think to remember that constructing an ObjectMapper is costly.


Maybe it's just me, but `region` vs `regions` might need clarifying. 😬


usually we prefer to return an empty array/list in this case instead of throwing a 404


What if the object named 'fTreeName' is not a TTree?  How does the previous code 'confuse' python?


@gregory38 The changes so far.


Hi, thanks for writing!

I only have minor changes so far. I can start sending pull requests your
way now, or wait until some larger changes. Which is better for you?

I'm interested in extending your code with a palette reduction feature, to
support "Generate a tessellation of the specified image, with the specified
palette, minimizing error." This would be used for generating code to send
to a vinyl cutter. This will require a little refactoring to change the
pipeline/flow, but it's otherwise fairly straightforward I think.

Thanks,
 -matt

On Wed, Aug 2, 2017 at 2:54 AM, Maurice Tollmien <notifications@github.com>
wrote:

> Hi,
>
> if your changes work (also any further changes), feel free to submit a
> pull request, I will most likely accept it.
> Regards,
> Maurice
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/mrhoten/Delaunay_Triangulation/commit/8c74c4d4431712fafa180723dcdaae53a6c7604e#commitcomment-23432372>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABpskIaGxfFxgPkNHBb8DKoxR3Cv7ECdks5sUEdIgaJpZM4Oq2_U>
> .
>


Oh, yes.


comment on this commit


Hello Taylor,
thank you. I miss interpreted the question, can I still make adjustments? Also apologies for responding late it's midterms week and I am taking 3 summer classes.

Best Regards
Olaoluwa Adesanya
olaolu961@gmail.com

> On Aug 1, 2017, at 2:09 PM, Taylor Garren <notifications@github.com> wrote:
>
> Your solution is very close. Try the following test case: "abacde"
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>


Buahi


I don't think the `json=1` parameter is still useful.
See https://github.com/GeoKretyMap/gkm-api-php/blob/master/gkm/geojson.php


Oops. Apparently I can't use Atom Beautify. Dang it.


yep, super rough docs ATM haha, I should remove that one from here actually


Small miracles


Apparently I removed some empty lines.


```diff
-size=${#array[@]}
-index=$(($RANDOM % $size))
-echo my_hdr User-Agent: ${array[$index]}
+echo my_hdr User-Agent: $[RANDOM%${#array[@]}]
```


what the hell is going on here??


Hi @charliegracie, is this what you are suggesting? It works and we can have one less change in Google Test. The drawback is that it is more verbose and the output is not colored. I can create a PR if you think this is the way to go.


Looks like you are missing a `}` here


Looks like lines 37-39 should be contained in the body of a function, as should lines 42-44


Looks like this is the end bracket for the body of the function that should contain lines 37-39


That's what I thought the behavior was -- imo probably simpler to just accept one format.


While Inserting 3 new contacts for Account with no contacts existing . In accIdActiveConMap  it will create AccountId as key and value will be '0'

While adding Contact to the final list c1. it check for value of Account (it will be 0), goes into loop inserts it and increments the map with 1,  While adding second contact to list C1. it checks for value of Account( It will be 1, as we incremented in previous iteration), goes into loop inserts it and increments the map with 2. While adding 3 contact to list c1, it checks for value of Account(It will be 2) so gets out of it.

So only two contacts with active gets inserted.


These 2 methods look wrong. They shouldn't take any parameter. Instead they should simply return lists of  List<SpaceReference> corresponding to excluded/included spaces.

Then, in the code where you decide whether the checker should be executed or not on a given document you'd simply check if the document reference's space is in the excluded list (if included list is empty). If included list is specified then you'd check if the document reference's space is in the included list.

Also, the include and exclude lists should support regexes.

Examples of excludes:
* wiki:A\.B
* .*:A\.B\..*
* A\.B\.^[^.]

Checking is simple. You'd construct Pattern objects and store them for performance reasons. Then you'd iterate over them and check for a match when compared with the default entity reference serializer output for the document.


@protonspring this test has the wrong bench number.  See http://tests.stockfishchess.org/actions please stop and resubmit.


what happens if you get rid of the white-space characters between the opening and closing tags?


ref aexeagmbh/text-engine#469


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/6b8b7163-1ec8-4616-82fa-aa467a17af03 "storybook-toolchain-v2"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/b84aaac8-8484-4a1e-902a-ebb526eb7998 "storybook-toolchain-v2") deployed [carbon-components-react](https://github.com/carbon-design-system/carbon-components-react/releases/tag/deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-190033 "deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-190033") to [Bluemix Design System](https://console.bluemix.net/apps/9986335e-2647-40cc-857f-4eebfdfba72d?env_id=ibm:yp:us-south "ibm:yp:us-south:chrisdhanaraj_org:Bluemix Design System"), including this commit


U right, fix pushed. Thx


Thanks Vagni


The following doc(s) have been deployed to the [thomasthac](https://thomasthac-static-docs.pantheonsite.io/docs) Multidev environment:
- [/docs/wordpress-sessions](https://thomasthac-static-docs.pantheonsite.io/docs/wordpress-sessions)


Missed a bit here


Amazing to see this all in one place! 🎉 Looks great~

Few suggestions, having gone thru it all:

1. Might want to mention the mix/max values for Lambda memory & timeouts.
2. Perhaps add the supported runtime versions for each language; e.g. Node.js 6.11.2
3. Again, picking on Node as an example, (a) is it possible to change runtime versions; and (b) how? Only saw example for Go.


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/6b8b7163-1ec8-4616-82fa-aa467a17af03 "storybook-toolchain-v2"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/b84aaac8-8484-4a1e-902a-ebb526eb7998 "storybook-toolchain-v2") deployed [carbon-components-react](https://github.com/carbon-design-system/carbon-components-react/releases/tag/deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-190425 "deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-190425") to [Bluemix Design System](https://console.bluemix.net/apps/56f1bbcb-839c-455f-8e1c-3c880ea39aba?env_id=ibm:yp:us-south "ibm:yp:us-south:chrisdhanaraj_org:Bluemix Design System"), including this commit


Was attempting to get the order of abbreviations and acronyms to be based off the acronyms associated with each element in the table, is there currently a function that accesses the acronym of a `commonIdea` directly? @JacquesCarette @szymczdm


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/260320959?utm_source=github_status&utm_medium=notification


could be the tvOS build phase.


excellent choice 🐍


Note to self: How will we be referencing sections when everything is automatically generated? Related to #368.


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/0ec8ba1d-b8b6-4ea3-9011-d207937fb0de "socialmediaanalysis"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/b245b056-c993-4af4-86fb-991c16492f2c "socialmedia-analysis") deployed [socialmedia-analysis](https://github.com/gronders/socialmedia-analysis/releases/tag/deploy-ibm-yp-us-south-Cognitive-POC-dev-20170802-190647 "deploy-ibm-yp-us-south-Cognitive-POC-dev-20170802-190647") to [dev](https://console.bluemix.net/apps/aeb43379-0cbc-4dc9-8bfe-baf6e668e152?env_id=ibm:yp:us-south "ibm:yp:us-south:Cognitive POC:dev"), including this commit


1. handleException func had .to uppercase. Can  do the upper case in calling func.
2. getHRSessionAttributes func still has old session attr.
3. We need to discuss about the use of multiple contexts ( feedback, generic, repeat...)


Don't use StringBuffers, prefer StringBuilders instead, as they're not synchronized


I would have preferred `public static void send(String key, Type value)` to stress the key-value database type.


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/6b8b7163-1ec8-4616-82fa-aa467a17af03 "storybook-toolchain-v2"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/b84aaac8-8484-4a1e-902a-ebb526eb7998 "storybook-toolchain-v2") deployed [carbon-components-react](https://github.com/carbon-design-system/carbon-components-react/releases/tag/deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-190905 "deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-190905") to [Bluemix Design System](https://console.bluemix.net/apps/0a253845-97bd-46c9-aa04-a220aeb8ed06?env_id=ibm:yp:us-south "ibm:yp:us-south:chrisdhanaraj_org:Bluemix Design System"), including this commit


RIP pillow spaces 😔


this not perfect


fast-forwarding master to auto = 4e45f3f3


git commit -m "first commit"
git remote add origin https://github.com/gutentak/github.io.git
git push -u origin master


@lukeed good call, thanks man! I'll add that stuff


Incorrect single quotes around opt[2:]


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/6b8b7163-1ec8-4616-82fa-aa467a17af03 "storybook-toolchain-v2"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/b84aaac8-8484-4a1e-902a-ebb526eb7998 "storybook-toolchain-v2") deployed [carbon-components-react](https://github.com/carbon-design-system/carbon-components-react/releases/tag/deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-191223 "deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-191223") to [Bluemix Design System](https://console.bluemix.net/apps/6fd88d21-e339-4192-a0b2-404bf1c1d3b2?env_id=ibm:yp:us-south "ibm:yp:us-south:chrisdhanaraj_org:Bluemix Design System"), including this commit


@apieceofbart poprawiłem te dwie rzeczy tylko nie mogę ogarną jak zrobić żeby ucinało tekst do połowy a nie od połowy.


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/0ec8ba1d-b8b6-4ea3-9011-d207937fb0de "socialmediaanalysis"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/b245b056-c993-4af4-86fb-991c16492f2c "socialmedia-analysis") deployed [socialmedia-analysis](https://github.com/gronders/socialmedia-analysis/releases/tag/deploy-ibm-yp-us-south-Cognitive-POC-dev-20170802-191241 "deploy-ibm-yp-us-south-Cognitive-POC-dev-20170802-191241") to [dev](https://console.bluemix.net/apps/aeb43379-0cbc-4dc9-8bfe-baf6e668e152?env_id=ibm:yp:us-south "ibm:yp:us-south:Cognitive POC:dev"), including this commit


Thanks for getting around to making this change. I appreciate it.


Shouldn't
` TPZVec <STATE> coord (3,0.);`
be still
` TPZVec <REAL> coord (3,0.);`
, for geometric coordinates won't assume complex values?


❤ too!


Add jdocs to all methods


This did not fix the issue. Could you please check. I have upgraded to 3.6.6 Build 1 no luck.


Yeah that might be less confusing, but I think the common case will be one region, most people aren't geared up for replicated databases etc.


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/0ec8ba1d-b8b6-4ea3-9011-d207937fb0de "socialmediaanalysis"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/b245b056-c993-4af4-86fb-991c16492f2c "socialmedia-analysis") deployed [socialmedia-analysis](https://github.com/gronders/socialmedia-analysis/releases/tag/deploy-ibm-yp-us-south-Cognitive-POC-dev-20170802-191440 "deploy-ibm-yp-us-south-Cognitive-POC-dev-20170802-191440") to [dev](https://console.bluemix.net/apps/aeb43379-0cbc-4dc9-8bfe-baf6e668e152?env_id=ibm:yp:us-south "ibm:yp:us-south:Cognitive POC:dev"), including this commit


The converters are not unit tested, They must be unit tested independently


saw approval from jedmccaleb
at https://github.com/vogel/stellar-core/commit/f6535d8b247b0b58823b5a73f0b9748d79e79952


merging vogel/stellar-core/fix-work-notify = f6535d8b into auto


vogel/stellar-core/fix-work-notify = f6535d8b merged ok, testing candidate = 3be9dde6


Tablas con el agregado de LATAM


Good question, I can't remember why I added it!


When running the code in Python 3.6 at least on my system the code produces an error and I had to remove the decode("utf-8") part, then everything worked again.


You bet! Yeah, I know 2/3 of those is just a matter of relaying AWS info, but in my exp, finding specifics like that in their docs is hard... especially when I need them, haha


Nice date/time system for logging edits


Created multidev environment [jaypeak#ci-115](https://dashboard.pantheon.io/sites/63ccddbd-731f-4f84-badc-3edee2e28541#ci-115).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-115-jaypeak.pantheonsite.io/)


OK, I will do it tomorrow, but you means IsItalicAnd**Not**AriaHidden, right ?


Test


Why do you have this blank space?


HI.
How about uint8_t for variable "channel" and / or "i".
Replace channel with i ?.

pulses_avr.cpp

+  // byte 4-25, channels 0..2047
+  // Range for pulses (channelsOutputs) is [-1024:+1024] for [-100%;100%]
+  // Multi uses [204;1843] as [-100%;100%]
+  for (int i=0; i<MULTI_CHANS; i++) {
+    int channel = i;//g_model.moduleData[port].channelsStart+i;
+    int value = channelOutputs[channel] + 2*PPM_CH_CENTER(channel) - 2*PPM_CENTER;

Sloped_soarer


Forgot to finish this thought.


Great numbers!


Still have to fix the issue where deleting doesn't apply visually until after another page refresh.

Also need to add success notifications.


The idea for these objects to be easily used in test is that they would exist as complete objects...

now it's an interesting point that undefined stuff raises as if you don't specify it in your test and you do use it, myabe your test design is wrong...

at the same time, i might not be testing exactly the part that requires such a field and focusing my test on only the values that matters is great.

Example :
```
def mymethod(client):
    logging.info("here's the client : {}".format(client.address)

    return client.clientid

def test_mymethod():
     assert mymethod(Client(clientid=123)) == 123
```

That would fail because address doesn't exist... while it's impossible case with the real objects... but forcing me to define just for untested logs is obfuscating imho


i'm afraid that this will lock the object to having only these fields and no more

so the case where a resource from a list and from a get is not exactly the same, it will give awkward results...


@Chris-Prime @Sandertv This will be fucking annoying to implement. Every command will need an extra parameter to specify what faction to execute the command for.

Factions is a fast-paced gamemode at times, and typing `/f enemy cunts` is very useful at times she  you want to betray someone. Now you would need to do `/f enemy oneofmyfactions cunts`.

I suppose we could have a command to set the current faction context and we could assign each of our factions to a number, e.g.
```
/f (c/context) 1
/f enemy cunts
/f (c/context) 0
```

But then we run the risk of if one of every being about to attack us. What do I mean?

Faction1: enemy to cunts
Faction2: ally to cunts

Now what the fuck do we do here? Which faction has priority? We could check the context but what if a player enemies someone then pussy's out and changing context to the ally faction?

Answer: **every player fucking whining**

Is this a good idea? Yes. Can we implement it nicely? No


smh kode


FYI @llyzs @ColAngel - Thanks to both of you for your recent contributions :)
If you want to change how your name reads in the file or add an AKA, etc. feel free to update the file or send us a pull request


mind=blown


![](https://github.trello.services/images/mini-trello-icon.png) [CC-37 - Order detailed view](https://trello.com/c/lDGn57NF/28-cc-37-order-detailed-view)


[Jenkins vg tests](http://jenkins.cgcloud.info/job/vg/291/) complete for merge to master.  View the [full report here](http://cgl-pipeline-inputs.s3.amazonaws.com/vg_cgl/vg_ci/jenkins_reports/branch/master/index.html).

10 tests passed, 0 tests failed and 7 tests skipped in 7970 seconds


I presume you have just had Travis set these all as environmental variables for things like the password?


I reckon the problem could come from this line since it adds kivyunittest first in the path before the one added by the `--pythonpath` parameter. Hence the `main.py` from kivyunitest will always be picked up before the `main.py` of the application we're testing against, refs #3


Yeah I went through this thing.sounds good.


I think we can add some extra code over here


This idea would work in a game like GTA V, not Minecraft.


![](https://github.trello.services/images/mini-trello-icon.png) [add drop down for import to select year](https://trello.com/c/S6ySFpNa/28-add-drop-down-for-import-to-select-year)


Make few changes and commit it again.


Nice 👏 Not sure if you got around to the region-globbing, but fits here perfectly


The `RobotMap.networkTable` is deprecated. Use Dashboard.


This commit broke the FreeBSD build: https://builds.cuberite.org/job/Cuberite-FreeBSD-x64-Master/656/


The trailing 0-methods should be protected, I'll add a setter0 tomorrow in AHC for you.


Fixed and pushed.
Thanks Moritz!

Best,
Olvier


TeamCity Code :: 1. Development :: DDK :: Feature [Build 405](http://mp-ci.centralus.cloudapp.azure.com/viewLog.html?buildId=28215&buildTypeId=Code_Development_Ddk_Feature) is now running


nothing, really


Yeah, I think so. Why did you need this change in the first place, @OmarDuran ?


It's really hard work! Well done Turner!


The numpy and scipy formulae could probably changed to build for both by default. See https://github.com/Homebrew/homebrew-core/pull/15726


Huh, are you doing a `no-ff` when merging or using the normal GitHub merge button, @andyperlitch?

If you're merging on GitHub, maybe you're using a feature of GitHub that does a squash or fast forward merge.


TeamCity Code :: 1. Development :: DDK :: Feature [Build 405](http://mp-ci.centralus.cloudapp.azure.com/viewLog.html?buildId=28215&buildTypeId=Code_Development_Ddk_Feature) outcome was **SUCCESS**
Summary: Tests passed: 70 Build time: 00:03:11


Still not a big deal but I find it strange.


Dude die please


assdf


Very well! Thanks!!!


![screen_2017-08-02 12 28 07](https://user-images.githubusercontent.com/18017741/28891432-f06eb712-7776-11e7-9c07-0edfb4b9964a.jpg)


yes, I think something like this should do
 ```
if allowedInstanceTypesTag != "" {
 	allowed = allowedInstanceTypesTag
 	} else {
 		allowed = allowedInstanceTypes
 	}
```


Hi,

Thanks for these fixes. Have you noticed any annotations not rendering? Since I cherry picked this commit, the bug of annotations sticking on the screen has been fixed but some annotations are not rendered.


@jackfengji


Die some more


it's pylint. I think it's the most common and complete tool for python


Created multidev environment [jhall-texascamp-2017-training#ci-3](https://dashboard.pantheon.io/sites/e31c2074-f06f-4b77-af81-6b6a72d8d2b4#ci-3).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-3-jhall-texascamp-2017-training.pantheonsite.io/)


Think, that object from `WeakReference` should be stored in local context and then passed to `f` function, otherwise it can lead to NPE or undesirable null checks inside lambda.
e.g.
```java
T obj; if((obj = ref.get()) != null) f.applyAsDouble(obj)
```


Can you take care of that? I'm far from my laptop for a while. Have been using my phone to check the notifications recently


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/260333036?utm_source=github_status&utm_medium=notification


@sroze quick question: why is the behat.yml gitignored? Just wondering what the reasoning is so I can improve my projects if necessary.


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/b763f569-5e11-41ba-b363-12d773c3070e "secure-container-toolchain-20170802145039600"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/80b396ee-6e5f-4200-b9b9-a3075fcca8df "hello-world-20170802145039600") deployed [docker_deployment](https://github.com/wouteroosterbosch/docker_deployment/releases/tag/deploy-ibm-yp-us-south-RAR_Europe-RAR_Europe-US-20170802-194128 "deploy-ibm-yp-us-south-RAR_Europe-RAR_Europe-US-20170802-194128") to [RAR_Europe-US]( "ibm:yp:us-south:RAR_Europe:RAR_Europe-US"), including this commit


I can't edit


myfib2 <- function(thresh){
  fib.a <- 1
  fib.b <- 1
  cat(fib.a,", ", fib.b,", ", sep = "")
  repeat {
    temp <- fib.a + fib.b
    fib.a <- fib.b
    fib.b <- temp
    cat(fib.b, ", ", sep = "")
    if(fib.b > 150){
      cat("Break now...\n")
      break
    }
  }
}


que bien que aumentamos  ese villano


Good point. 4d38516898f420c6fbafbaa41e729d1eaf5ff797


fast-forwarding master to auto = 3be9dde6


Seriously,after today's lesson I finaly see how they works. They are all simular,but first works faster.
What I need to do with them?


I am using this in config file `/etc/munin/plugin-conf.d/nagiostats`:
```
[nagiostats_*]
user nagios
group nagios
```


Better thread safety.


I still see it, probably because I'm still looking at the same commit and not the later commit... this is why I prefer a PR because it is updated with every following commit.

Next time, use a PR ok? It makes collaborative reviewing a lot easier. :)


good catch


add lesson15


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/6b8b7163-1ec8-4616-82fa-aa467a17af03 "storybook-toolchain-v2"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/b84aaac8-8484-4a1e-902a-ebb526eb7998 "storybook-toolchain-v2") deployed [carbon-components-react](https://github.com/carbon-design-system/carbon-components-react/releases/tag/deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-194727 "deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-194727") to [Bluemix Design System](https://console.bluemix.net/apps/a5b30501-bfc5-46f0-bae0-355a4ecc1cf0?env_id=ibm:yp:us-south "ibm:yp:us-south:chrisdhanaraj_org:Bluemix Design System"), including this commit


j


I have my doubts about this change...


"an instance"? or "the current instance"?


Should these log files have been committed?


Не работает?


Weird that I didn't catch those in my PR. I did a global search, replace for `_each_key. But thanks for fixing it for me! :slightly_smiling_face:


Generalizing this to `IO` caused a downstream ambiguity for me in HTTP.jl:fifobuffer.jl, where I had defined `write(::FIFOBuffer, ::Vector{UInt8})` and `write(::FIFOBuffer, ::AbstractVector{UInt8})`. Maybe it's just weird in my case since I'm defining my own `write` methods for vector types?


I thought we agreed to make this input_length? Why not?


IL y avait un conflit lorsque tu as essayé de validé le pull request. Tous les fichiers n'ont pas pu être mergé.
Je viens de résoudre ce conflit. Essaie de valider à nouveau le pull request


The code I wrote for the _win_ branch was designed to only run from an installed application, I wouldn't recommend merging this into master as your development environment is likely now pretty broken.

Unless you guys are planning on integrating the two , I'd revert this commit.


> rtw5dqG

 NHJHGFTFF

11121
HGRE


![screen_2017-08-02 12 48 30](https://user-images.githubusercontent.com/18017741/28892067-211d304e-7779-11e7-8cb6-77e232f0a2c3.jpg)


* [x] Add `dateline`:
  - https://github.com/HistoryAtState/frus/commit/5ec47d5b4bfdbb3b4fb76f111dc00400252f3d8b


Thanks


90% of that code is from openTX 2.2.0
Original line was
int channel = g_model.moduleData[port].channelsStart+i;
I haven't realized it :D

BR, Martin

On 2 August 2017 at 21:18, sloped-soarer <notifications@github.com> wrote:

> HI.
> How about uint8_t for variable "channel" and / or "i".
> Replace channel with i ?.
>
> pulses_avr.cpp
>
>    - // byte 4-25, channels 0..2047
>    - // Range for pulses (channelsOutputs) is [-1024:+1024] for
>    [-100%;100%]
>    - // Multi uses [204;1843] as [-100%;100%]
>    - for (int i=0; i<MULTI_CHANS; i++) {
>    - int channel = i;//g_model.moduleData[port].channelsStart+i;
>    - int value = channelOutputs[channel] + 2*PPM_CH_CENTER(channel) - 2*
>    PPM_CENTER;
>
> Sloped_soarer
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/Ingwie/OpenAVRc_Dev/commit/0ee062825249da088385b3d731709672e0338f8a#commitcomment-23442151>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ALrx4LC34hsdBlwVkRV9gq5QBghWwKhEks5sUMudgaJpZM4OiVjU>
> .
>


You want to only remove it if it does contain those values, not 'doesnt'  correct?


worked beautifuly! hahaha thanks


@yahor Возможно cache не работает как нужно.
Я давно там в ```rules.md``` сделал изменение, но оно никак на сайте не появится.


Looks like this file was a little out of date. I replaced it with the build.sh from our other repos but I wouldn't mind if I got another set of eyes to check the changes @natemcmaster Looks reasonable to me.


Enable_ChillerHeater_and_CentralHeatPump (jmarrec) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


is there a new feature in ReadableNumbers 0.1.0 you're relying on?


The following doc(s) have been deployed to the [2725standa](https://2725standa-static-docs.pantheonsite.io/docs) Multidev environment:
- [source/_partials/redirects.twig](https://github.com/pantheon-systems/documentation/commit/7cccc60e4498ff13547ca06511fb5b64807e92e9/source/_partials/redirects.twig)


## Joker
este es mi villano feo


### Notas
Entiendo por que agregaste a deshop lo nes


I don't see the point of doing this.


You still need to specify all of the fixtures (usually create a base test case that extends Cake's to put them in). This change allows you to load all fixtures when autoFixtures is false, e.g., in a single test method. You can hit me up in slack if you have questions.


Закоммить хоть какие-то свои попытки, чтобы я видел, как оно не работает. -_-


세종대 | 창의인재 | 컴공, 보안, SW, 데이터 | 20->60명 입니다.


@allenwtl we are using github for bug reports and feature requests. Please, ask questions at our discussion forum: https://discuss.elastic.co/ You can download v5.5.1  at https://www.elastic.co/downloads/elasticsearch


刚回家更何况


ss


Yeah no worries, this is what I am currently doing, was just hoping to save a few lines of code and lots of class extensions :)


A better way would be to do this in the client's `close()` method.


Nitpick: add space here
    catch(
            ^


These radio inputs should have the same name so that they're mutually exclusive.


Looks good. Marking complete.


You should probably do something other than just return. Print the exception, an error message, etc.


#### 上传第一个Swift项目第一版v1.0.0
* 首页添加广告轮播
* 频道页添加双级联动框架
* 我的页面封装了基类，子类只需要继承并根据相应模型添加相应cell


say something


The for attribute on the label has to match the **id** of the input for you to be able to tap the label and focus on the input.


Don't use br tags. Leverage block and inline-block to get the layout you're looking for.


Yikes, sorry about this. Thank you for the report.


`get` is a verb most commonly associated with an accessor method. It'd be good to use a more descriptive verb, such as `promptForUsername()`.


Good job. Make sure to match the label name attribute to the input id attributes. Remember you can also wrap the whole input in it's label like so
```
<label>Name: <input type="text" name="username"/></label>
```


Ah dangit. I won't have time to fix this this week, can someone provide a patch? I guess this definition needs to move to another file where ActiveRecord is actually used.


`private`


这个文件没啥实质性作用，直接删掉这个文件好了 @warmhug


This is an adventure not for the faint hearted


hi, afilini i need a help for this api, you can help me?
my contacts
skype: mathes.santos204
e-mail: mat982005@gmail.com


为啥叫 DatePickerView，叫 Calendar 吧。


@silentcloud 我建议是我们统一对外的引用 入口全部保留 .native.js, .js, 就算这是两个空文件，这两个文件可以 `import DatePickerView  from './DatePickerView' ` 然后 export 出去


不太建议我们去依赖 react native cli 对文件后缀的默认规则。

**这个规则目前只需要在用户侧的入口生效就好了**， 比如 `import Button from 'antd-mobile/lib/button'`


Same comment here as above regarding `finish()` to return to the previous Activity. You might not have encountered the `setResult(...)` method on `Activity` yet, so you might want to read up about that – the gist is:

1. When starting the `IntervalSetup` Activity, use `startForResult(...)` instead of `start(...)`.
2. Before you call `finish` here, call `setResult(Activity.RESULT_OK, data)`, where `data` is a `Bundle` to which you can add whatever data you need to access from the `IntervalSetup` Activity (e.g. the interval).
3. In `IntervalSetup`, override the `onActivityResult(...)` method, check for `RESULT_OK`, and pull the interval out of the `Bundle data` parameter.

That was a very concise form of all the information you need, so let's talk about it in-depth tomorrow 😁.


比如 typescript compile emit declaration file 的时候，他是不去帮你读取 .native 的


ok


@afc163  不同的 https://github.com/ant-design/ant-design-mobile/issues


Formatting needs fixing.


这个入口我测试一下rn，看是不是改下


TeamCity Keyman :: Keyboards :: Test: Pull Requests [Build 17](http://build.palaso.org/viewLog.html?buildId=95382&buildTypeId=Keyboards_TestPullRequests) outcome was **SUCCESS**
Summary: Running Build time: 00:11:49


Create SnakeGamePlay


As mentioned previously, this should be done in `onActivityResult(...)` (paired with `setResult(...)/finish()` – but in cases where you pass an extra through to an Activity, you would normally pull that out in `onCreate()` or `onResume()`. `onRestart()` is almost never used.


没在移动端见到过这种组件展示方式


It's better to use the foreach loop syntax:

    for (ClientMessenger client : clients) {
        client.get(i).sendToClient(msg, username);
    }

This also breaks more easily if you have thread-safety issues.


`private`


```Swift

import Foundation

enum APIError: Error {
    case requestFailed
    case jsonConversionFailure
    case invalidData
    case responseUnsuccessful
    case jsonParsingFailure

    var localizedDescription: String {
        switch self {
        case .requestFailed: return "Request Failed"
        case .invalidData: return "Invalid Data"
        case .responseUnsuccessful: return "Response Unsuccessful"
        case .jsonParsingFailure: return "JSON Parsing Failure"
        case .jsonConversionFailure: return "JSON Conversion Failure"
        }
    }
}

protocol APIClient {
    var session: URLSession { get }
    func fetch<T: JSONDecodable>(with request: URLRequest, parse: @escaping (JSON) -> T?, completion: @escaping (Result<T, APIError>) -> Void)
    func fetch<T: JSONDecodable>(with request: URLRequest, parse: @escaping (JSON) -> [T], completion: @escaping (Result<[T], APIError>) -> Void)
}

extension APIClient {
    typealias JSON = [String: AnyObject]
    typealias JSONTaskCompletionHandler = (JSON?, APIError?) -> Void

    func jsonTask(with request: URLRequest, completionHandler completion: @escaping JSONTaskCompletionHandler) -> URLSessionDataTask {
        let task = session.dataTask(with: request) { data, response, error in

            guard let httpResponse = response as? HTTPURLResponse else {
                completion(nil, .requestFailed)
                return
            }

            if httpResponse.statusCode == 200 {
                if let data = data {
                    do {
                        let json = try JSONSerialization.jsonObject(with: data, options: []) as? [String: AnyObject]
                        completion(json, nil)
                    } catch {
                        completion(nil, .jsonConversionFailure)
                    }
                } else {
                    completion(nil, .invalidData)
                }
            } else {
                completion(nil, .responseUnsuccessful)
            }
        }

        return task
    }

    func fetch<T: JSONDecodable>(with request: URLRequest, parse: @escaping (JSON) -> T?, completion: @escaping (Result<T, APIError>) -> Void) {

        let task = jsonTask(with: request) { json, error in

            DispatchQueue.main.async {
                guard let json = json else {
                    if let error = error {
                        completion(Result.failure(error))
                    } else {
                        completion(Result.failure(.invalidData))
                    }

                    return
                }

                if let value = parse(json) {
                    completion(.success(value))
                } else {
                    completion(.failure(.jsonParsingFailure))
                }
            }
        }

        task.resume()
    }

    func fetch<T: JSONDecodable>(with request: URLRequest, parse: @escaping (JSON) -> [T], completion: @escaping (Result<[T], APIError>) -> Void) {

        let task = jsonTask(with: request) { json, error in

            DispatchQueue.main.async {
                guard let json = json else {
                    if let error = error {
                        completion(Result.failure(error))
                    } else {
                        completion(Result.failure(.invalidData))
                    }

                    return
                }

                let value = parse(json)

                if !value.isEmpty {
                    completion(.success(value))
                } else {
                    completion(.failure(.jsonParsingFailure))
                }
            }
        }

        task.resume()

    }
}

```


thanks I've updated this


Looks good. Thanks for cleaning it up.


This is how I did it in my API Client file


# User Agreement
User agreement of ORYZA

The ecophysiological rice model, ORYZA, embodies our best understanding to date of the biogeochemistry of crop growth, and cycling of carbon, nitrogen, and water in crop field ecosystem.  The primary purpose of the model is to provide a tool for rice ecosystem analysis, test the consistency of data, evaluate the effects of changes in management and climate on rice production, and optimize rice field management.

Evolution of the model will continue with an improved understanding of biogeochemical and plant physiological processes, and other management aspects. The identification of weak areas which the model is yet to quantify adequately is the key to further model development. Ideally, a model application on different cases will lead to the identification of needed research and experimentation.

We value the experiences and comments of our collaborators in using ORYZA and encourage their feedbacks on the current model, as well as insights and suggestions for future model improvement. It would be particularly helpful if users would communicate such feedback, formally or informally, and if possible, share with us documented model applications including manuscripts, papers, procedures, or individual model development.

The copyright of the versions of ORYZA2000 and ORYZA belongs to International Rice Research Institute (IRRI), a non-profit research center of Consultative Group on International Agricultural Research (CGIAR), at Los Baños, Philippines. Any type of publication, a media report and secondary development using ORYZA must acknowledge the model developer(s) and IRRI.

Neither IRRI nor CGIAR, nor any of their employees, warrants or assumes any legal liability or responsibility for the accuracy, completeness, or usefulness of any information, apparatus, product, or process disclosed or represents that its use would not infringe privately owned rights.  Reference to any special commercial products, process, or service by trade-name, trademark, manufacturer, or otherwise, does not necessarily constitute or imply endorsement, recommendation, or favor coming from the IRRI or CGIAR.  The views and opinions of the authors do not necessarily state or reflect those of IRRI or CGIAR and shall not be used for advertising, product endorsement and any commercial purposes.


no


afdasfasdf


testst


should be showNY();


Here, the code can speak for itself. It's better without the comments as it just adds clutter.


I'm making week 5 complete despite the small bug. Looks good.


cool, tnx.


I tried that function but it didn't clear, did I mess up?


Works now :+1:


잘못 커밋


没 没有看到附件。。

Detect完以后用一张黑白图片，白色表示阴影然后扔到ShadowRemoval.PyramidShadowRemovalColorByImg就行了吧。main.py里面是我当时做的流程

文献的话。。当时做这个玩意就很匆忙，看过的只有报告里面写的几个了，其他的给不出来什么。。


You don't need line (since you aren't using `lists` anywhere in this method).


Eh, I think my bad advice was at fault here. Just remove it I guess.


Yeah your account is dead, I'd recommend you contact GitHub support for help...


Right here, you'll need to store a cookie for the authenticated user. Then other controllers can check to see if the cookie is set, which means a user is logged in.


好


Esse json_decref é usado para raiz com json_loads para outras funções apenas compartilha o que sai do json_loads. Poderia ter usado se usasse json_incref.
Valgrind


Thank you


Why not do `new Server(host, port)` as well?


**Whoops!**

There were **10 critical errors** that broke the build and prevented it from being automatically deployed.

There were *4 warnings* that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

**ERRORS**
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L142`](https://github.com/Google/WebFundamentals/blame/0a09354be9e0ed82c41736e0c7301d538cca0067/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L142) - Hard coded language URL in link (`hl=xx`)
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L264`](https://github.com/Google/WebFundamentals/blame/0a09354be9e0ed82c41736e0c7301d538cca0067/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L264) - Do not hard code `developers.google.com` in links.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L272`](https://github.com/Google/WebFundamentals/blame/0a09354be9e0ed82c41736e0c7301d538cca0067/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L272) - Do not hard code `developers.google.com` in links.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L287`](https://github.com/Google/WebFundamentals/blame/0a09354be9e0ed82c41736e0c7301d538cca0067/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L287) - Do not hard code `developers.google.com` in links.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L290`](https://github.com/Google/WebFundamentals/blame/0a09354be9e0ed82c41736e0c7301d538cca0067/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L290) - Do not hard code `developers.google.com` in links.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L300`](https://github.com/Google/WebFundamentals/blame/0a09354be9e0ed82c41736e0c7301d538cca0067/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L300) - Hard coded language URL in link (`hl=xx`)
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L312`](https://github.com/Google/WebFundamentals/blame/0a09354be9e0ed82c41736e0c7301d538cca0067/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L312) - Do not hard code `developers.google.com` in links.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L314`](https://github.com/Google/WebFundamentals/blame/0a09354be9e0ed82c41736e0c7301d538cca0067/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L314) - Do not hard code `developers.google.com` in links.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L316`](https://github.com/Google/WebFundamentals/blame/0a09354be9e0ed82c41736e0c7301d538cca0067/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L316) - Do not hard code `developers.google.com` in links.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L328`](https://github.com/Google/WebFundamentals/blame/0a09354be9e0ed82c41736e0c7301d538cca0067/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L328) - Do not hard code `developers.google.com` in links.

**WARNINGS**
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md`](https://github.com/Google/WebFundamentals/blame/0a09354be9e0ed82c41736e0c7301d538cca0067/src/content/en/fundamentals/accessibility/a11y-for-teams.md) - No `wf_blink_components` field found in metadata. Add if appropriate.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L264`](https://github.com/Google/WebFundamentals/blame/0a09354be9e0ed82c41736e0c7301d538cca0067/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L264) - Line must be at most 100 characters
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L274`](https://github.com/Google/WebFundamentals/blame/0a09354be9e0ed82c41736e0c7301d538cca0067/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L274) - Line must be at most 100 characters
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L280`](https://github.com/Google/WebFundamentals/blame/0a09354be9e0ed82c41736e0c7301d538cca0067/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L280) - Line must be at most 100 characters


#User agreement of ORYZA

The ecophysiological rice model, ORYZA, embodies our best understanding to date of the biogeochemistry of crop growth, and cycling of carbon, nitrogen, and water in crop field ecosystem.  The primary purpose of the model is to provide a tool for rice ecosystem analysis, test the consistency of data, evaluate the effects of changes in management and climate on rice production, and optimize rice field management.

Evolution of the model will continue with the improved understanding of biogeochemical and plant physiological processes, and other management aspects. The identification of weak areas which the model is yet to adequately quantify is the key to further model development. Ideally, the model application in different cases will lead to the identification of needed research and experimentation.

We value the experiences and comments of our collaborators in using ORYZA and encourage their feedbacks on the current model, as well as insights and suggestions for future model improvement. It would be particularly helpful if users would communicate such feedback, formally or informally, and if possible, share with us documented model applications including manuscripts, papers, procedures, or individual model development.

The copyright of ORYZA2000 belongs to International Rice Research Institute (IRRI), a non-profit research center of Consultative Group on International Agricultural Research (CGIAR), at Los Baños, Philippines. Any type of publication, media report and secondary development using ORYZA must acknowledge the model developer(s) and IRRI.

Neither IRRI nor CGIAR, nor any of their employees, warrants or assumes any legal liability or responsibility for the accuracy, completeness, or usefulness of any information, apparatus, product, or process disclosed or represents that its use would not infringe privately owned rights.  Reference to any special commercial products, process, or service by trade-name, trademark, manufacturer, or otherwise, does not necessarily constitute or imply endorsement, recommendation, or favor coming from the IRRI or CGIAR.  The views and opinions of the authors do not necessarily state or reflect those of IRRI or CGIAR and shall not be used for advertising or product endorsement.


so I gave it another go with 1.0.5 and had no luck whatsoever.  I get nothing but errors when I try and do anything with that version, including just trying to upload the arduinoISP sketch to the NANO.  I think it might have something to do with the NANO clone I have.  In order to upload any sketch to these clones I have to use the MINI for the board selection.  I have the official Arduino NANO coming that I ordered a couple days ago.  Hopefully this will fix my problem.  I'm not sure what else to try.   I uploaded a blank sketch to the ATTiny85 today and it must have worked as that didn't send any kind of signal to the receiver after the blank sketch was uploaded.  Immediately after I ran the blink sketch on the tiny and it worked.  But my knowledge is slim on code, I'm assuming that either one of these sketches are only running at 1mhz.  Where if the bootloader is not uploading properly it will still send a IRcode, just not the right one?  As soon as I get the other NANO I will start over and see if this changes.  Does this seem like a worthy try?  Should I be looking for a different problem.  Thanks again for your help.


HyunA


Yes.  `ImageBackground ` supports `imageStyles ` will be more useful.


Looking good!


**Whoops!**

There were **10 critical errors** that broke the build and prevented it from being automatically deployed.

There were *4 warnings* that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

**ERRORS**
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L142`](https://github.com/Google/WebFundamentals/blame/381755edffa7c6a08fdea5e10773cc419833d747/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L142) - Hard coded language URL in link (`hl=xx`)
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L264`](https://github.com/Google/WebFundamentals/blame/381755edffa7c6a08fdea5e10773cc419833d747/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L264) - Do not hard code `developers.google.com` in links.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L272`](https://github.com/Google/WebFundamentals/blame/381755edffa7c6a08fdea5e10773cc419833d747/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L272) - Do not hard code `developers.google.com` in links.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L287`](https://github.com/Google/WebFundamentals/blame/381755edffa7c6a08fdea5e10773cc419833d747/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L287) - Do not hard code `developers.google.com` in links.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L290`](https://github.com/Google/WebFundamentals/blame/381755edffa7c6a08fdea5e10773cc419833d747/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L290) - Do not hard code `developers.google.com` in links.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L300`](https://github.com/Google/WebFundamentals/blame/381755edffa7c6a08fdea5e10773cc419833d747/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L300) - Hard coded language URL in link (`hl=xx`)
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L312`](https://github.com/Google/WebFundamentals/blame/381755edffa7c6a08fdea5e10773cc419833d747/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L312) - Do not hard code `developers.google.com` in links.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L314`](https://github.com/Google/WebFundamentals/blame/381755edffa7c6a08fdea5e10773cc419833d747/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L314) - Do not hard code `developers.google.com` in links.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L316`](https://github.com/Google/WebFundamentals/blame/381755edffa7c6a08fdea5e10773cc419833d747/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L316) - Do not hard code `developers.google.com` in links.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L328`](https://github.com/Google/WebFundamentals/blame/381755edffa7c6a08fdea5e10773cc419833d747/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L328) - Do not hard code `developers.google.com` in links.

**WARNINGS**
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md`](https://github.com/Google/WebFundamentals/blame/381755edffa7c6a08fdea5e10773cc419833d747/src/content/en/fundamentals/accessibility/a11y-for-teams.md) - No `wf_blink_components` field found in metadata. Add if appropriate.
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L264`](https://github.com/Google/WebFundamentals/blame/381755edffa7c6a08fdea5e10773cc419833d747/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L264) - Line must be at most 100 characters
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L274`](https://github.com/Google/WebFundamentals/blame/381755edffa7c6a08fdea5e10773cc419833d747/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L274) - Line must be at most 100 characters
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md#L280`](https://github.com/Google/WebFundamentals/blame/381755edffa7c6a08fdea5e10773cc419833d747/src/content/en/fundamentals/accessibility/a11y-for-teams.md#L280) - Line must be at most 100 characters


This is test space text.


MEEEEEM


**Whoops!**

There were *1 warnings* that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.

**WARNINGS**
[`src/content/en/fundamentals/accessibility/a11y-for-teams.md`](https://github.com/Google/WebFundamentals/blame/8008014f49f3b6e92ca2524771c9a181bc062f78/src/content/en/fundamentals/accessibility/a11y-for-teams.md) - No `wf_blink_components` field found in metadata. Add if appropriate.


This is the funkiest part of the whole thing -- I literally use reflection to hack the page manager and replace the replicator with a fake one that just records the list of things that need replication.  There's no other way to take control over how replication is managed when evoking PageManager operations.


`<!DOCTYPE html>

welcome to my csdn blog!!!

`


make it `[compatibleValues=true/false]`


thanks!


TeamCity Keyman :: Keyboards :: Test: Pull Requests [Build 18](http://build.palaso.org/viewLog.html?buildId=95383&buildTypeId=Keyboards_TestPullRequests) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:27


Just a heads up... You gotta get rid of the whole commit history to really get rid of this stuff.


What is the need to have this class? Are we saving the return queries?


doesn't this belong in LLVM.jl, not here?


好像 else 可以拿掉


Needed for https://github.com/ImageMagick/ImageMagick/issues/578


That happens at the same time during a PR and review process. That way there is overall less time wasted by making things easier to read which in turn helps looking for correctness easier and efficient.

So no, next time we do a proper PR and we do it all at once. :)


Well, I won't bother myself with cosmetic changes to this. Feel free to apply any changes needed.


![screen_2017-08-02 12 57 30](https://user-images.githubusercontent.com/18017741/28892413-694662f4-777a-11e7-93df-357b162d23f1.jpg)
![screen_2017-08-02 12 57 50](https://user-images.githubusercontent.com/18017741/28892416-6acad902-777a-11e7-902a-f571b355153b.jpg)
![screen_2017-08-02 12 58 11](https://user-images.githubusercontent.com/18017741/28892419-6c468ce0-777a-11e7-85ff-f45b4bad5675.jpg)


updated file locations


Created multidev environment [jhall-texascamp-2017-training#ci-4](https://dashboard.pantheon.io/sites/e31c2074-f06f-4b77-af81-6b6a72d8d2b4#ci-4).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-4-jhall-texascamp-2017-training.pantheonsite.io/)


*[Hook UI build recap](http://ci.perseids.org/repo/OpenGreekAndLatin/First1KGreek/2028)*


thank :)


Good Change


OK


Enum would be better as it would be explicit what it was trying to achieve


Enable_ChillerHeater_and_CentralHeatPump (jmarrec) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/0ec8ba1d-b8b6-4ea3-9011-d207937fb0de "socialmediaanalysis"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/b245b056-c993-4af4-86fb-991c16492f2c "socialmedia-analysis") deployed [socialmedia-analysis](https://github.com/gronders/socialmedia-analysis/releases/tag/deploy-ibm-yp-us-south-Cognitive-POC-dev-20170802-201005 "deploy-ibm-yp-us-south-Cognitive-POC-dev-20170802-201005") to [dev](https://console.bluemix.net/apps/aeb43379-0cbc-4dc9-8bfe-baf6e668e152?env_id=ibm:yp:us-south "ibm:yp:us-south:Cognitive POC:dev"), including this commit


This version is good!


`_prevent_stuck` should be only used during evaluation. In training, this will cause collapsing to a single action when training breakout.bin


lgtm


![](https://github.trello.services/images/mini-trello-icon.png) [Improve playback notification](https://trello.com/c/3qQu10NG/19-improve-playback-notification)


*[Hook UI build recap](http://ci.perseids.org/repo/OpenGreekAndLatin/First1KGreek/2029)*


Should import our `CommonModule`, not the Angular's one


commit


If `$sectionBy` type is `string` why not use type hinting? If `int` is also allowed then type should be `mixed` or `string|int`.


Fix indentation


Should save only the `sampling` and `pending` parameters maybe...
`iter`shall have the same meaning as `n_points` right?
Also is `pending` (how many points in total to integrate) different from `n_jobs`?


Hi, because you do not use the libfrost.a library to print strings in the drivers or applications


Dang, something wrong with IDE formatting!


Is this position fine for the `sampling` and `pending` parameters?


I'm working on your project and I need some help with some things


@budnyjj released 0.7.0 and updated the README with the changes :)


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/6b8b7163-1ec8-4616-82fa-aa467a17af03 "storybook-toolchain-v2"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/b84aaac8-8484-4a1e-902a-ebb526eb7998 "storybook-toolchain-v2") deployed [carbon-components-react](https://github.com/carbon-design-system/carbon-components-react/releases/tag/deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-202245 "deploy-ibm-yp-us-south-chrisdhanaraj_org-Bluemix-Design-System-20170802-202245") to [Bluemix Design System](https://console.bluemix.net/apps/f00d3b83-ca0a-4da7-979c-f19680e4e18b?env_id=ibm:yp:us-south "ibm:yp:us-south:chrisdhanaraj_org:Bluemix Design System"), including this commit


Thanks for this!


@mnelson These are big changes.  Are the supporting code changes already in master?


Fix name


## Global

| Changed         |   Status |
|:----------------|---------:|
| `coverage`      |    -0.07 |
| `nodes_count`   |   -97    |
| `texts_passing` |    -1    |

## Words

| Changed   |   Status |
|:----------|---------:|
| `grc`     |   -12992 |

## Units

| Changed                                               | Status   |
|:------------------------------------------------------|:---------|
| `./data/tlg5022/tlg002/tlg5022.tlg002.1st1K-grc1.xml` | Failing  |

*[Hook UI build recap](http://ci.perseids.org/repo/OpenGreekAndLatin/First1KGreek/2033)*


line 211 is redundant


file:///C:/Users/Desarrollo6/Desktop/wilder/index.html
file:///C:/Users/Desarrollo6/Desktop/wilder/index.html


![](https://github.trello.services/images/mini-trello-icon.png) [still-alive v1.3.0](https://trello.com/c/9twUk9Td/19-still-alive-v130)


sort of -- transitive julia v0.6 support


"section.git"?  (line 1172)


Note that the reason this was expanded is that `ide` is no longer in the paper.


Great job!


Haha. I did the same exact change and override the entire component with a custom component in HASS. I'll test your changes.


Started a LiDAR data analysis repository


It seems that systemd uses lower values than the values displayed in ulimit -a.  One value in particular that we saw for xcatd on a large P775 cluster was for open filedescriptors which caused actions to not be performed against some targeted nodes.  Adding the line "LimitNOFILE=16000" in xcatd.service fixed the problem. Can this be added to the xCAT-server shipped xcatd.service file?


I believe that with my timer rewrite, it's not actually possible for a user to time out after sending their choice. `room-battle.js` does not wait for confirmation from the sim, it marks the player as "not waiting for decision" the moment it receives a decision (it treats "invalid switch" from the sim process the same way it treats a Cancel-button press from the user).

I have indeed removed the race condition handling from the choice parser. Race condition handling is not the simulator's job. It doesn't go in `sim/`, it goes in `room-battle.js`, which is where it is now.


Gamma 3.15 looks way better than 2.2 for my test clips. For you 2.2 is good? My clips are very dark, but the highlights are not very detailed. Gamma at 3.15, Exposure at -2 and Lighten at 0.3..0.6 gives often very detailed results for me.
Should we make gamma adjustable in the GUI? Which range would be fine?


Where do I make this changes?


@sjackman https://github.com/Homebrew/homebrew-core/pull/16335


I'd probably split these two into different classes: one `PrependedBookmarkFolder` (add an item to the front of the list) and the other `ConcatenatedBookmarkFolder` (show two folders as if they were one). You have two code paths switching on the enum in every method.


This commit has been mentioned on **Discourse Meta**. There might be relevant details there:

https://meta.discourse.org/t/discourse-canned-replies/48296/88


[R/plotting-helpers.R:907:3:](https://github.com/PredictiveEcology/quickPlot/blob/f4adb27f9152a2a8aaf0836071e85ad6342c72ff/R/plotting-helpers.R#L907) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/plotting-other.R:163:3:](https://github.com/PredictiveEcology/quickPlot/blob/f4adb27f9152a2a8aaf0836071e85ad6342c72ff/R/plotting-other.R#L163) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^~~
```
[R/plotting-other.R:171:3:](https://github.com/PredictiveEcology/quickPlot/blob/f4adb27f9152a2a8aaf0836071e85ad6342c72ff/R/plotting-other.R#L171) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^~~
```
[R/plotting-other.R:175:3:](https://github.com/PredictiveEcology/quickPlot/blob/f4adb27f9152a2a8aaf0836071e85ad6342c72ff/R/plotting-other.R#L175) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^~~
```
[R/plotting-other.R:387:3:](https://github.com/PredictiveEcology/quickPlot/blob/f4adb27f9152a2a8aaf0836071e85ad6342c72ff/R/plotting-other.R#L387) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```


Is it possible to remove all and leave only Tvheadend
Clean TVH_CDK, no Neutrino no Enigma.

Only one bug currently with tvh in moment CI not work


You may also chain both methods to reduce the variables...


`BookmarkRoots.DesktopRoots`.


just re-install with from CRAN with `install.packages("mapview")`


Yeah, that seems reasonable. PrependedNodeBookmarkFolder and PrependedChildrenBookmarkFolder? I feel like those aren't quite right.


If function getActiveElement() returns an undefined value, then getting its property will give an error. So it should be like this: activeElement = ( activeElement && (activeElement.type || activeElement.href) ) && activeElement;


json-editor schema = > multiple of doesn't work well for 0.01   1.11 must be divisble by 0.01 but error validation


It was merged in https://github.com/gocd-contrib/gomatic/pull/28. Is that enough?


It seems we should check also for the length of `$b` to avoid *undefined index* errors..


Should it be `QtGui`

See https://github.com/Kitware/CMake/blob/master/Modules/FindQt4.cmake#L22


what does "SOL" stands for (terms of water)?


hash_equals is only called from hash_compare, which returns false if $a and $b are not the same length, so the check is there it's just in the caller.


To make sure I understand, including `QSslError` is always needed because it forward declare the class/struct used in `onSslErrors` slot ?


there just comments jeez


@Fabrice-TIERCELIN Typo: Stament should be Statement


with the update starting from 31 july and this patch it's working well, no peer down/up


Added in cc4f489492e3936bba0d1559fdd3ec613fe81358


@Ste74 You haven't rebuild this and it fails to install/update due to broken dependency **cursor-breeze**.

BTW the mate-panel layouts work perfectly (at least on my system) and I'm thinking of doing a promo video of showing the new panel layouts and posting it on the forum at "manjaro mate 17.0.2" announcement if it's ok with you.


line break just like in html


solvent, I presume, when I did MDs SOL was the name for water


Wow..
A lot cleaner now


multiple of schema definition still doesn't work for value 1.11 multiple of 0.01 - Validation error


Thanks to peterigz for noticing!


This commit has been mentioned on **Discourse Meta**. There might be relevant details there:

https://meta.discourse.org/t/mini-inline-onebox-support-rfc/66400/18


FYI When updating an existing application to 0.8.0 from 0.7.0 this commit breaks if you have the generated view template from 0.7.0 using svg_tag.


What do you mean by 'identifying' the z index?

I like the transparency though I personally find the scroll cursor irritating.


just kidding; added kitten photo to repository. README stayed unchanged.


For the sake of readability, sometimes it is better to break up dicts onto multiple lines:
```
self.enemy= {
    1: enemies.Orc(elvl),
    2: enemies.Goblin(elvl),
    3: enemies.BadDude(1)
}
```
The location of the {}'s don't matter as much.


from gromacs? but why considering "solvent" as water?


Retarded


BTW, I previously moved the subrevision set to https://github.com/armbian/build/blob/master/lib/configuration.sh#L12 so it probably needs to be removed from there


Damn , i forgot this commit :\ thank you to re ping me 👍 build now


Yes, changes are in master and behind the minor version bump of the 0.5.x release. Apologies for the lack of changelog, I'll add it to my todo.


is this just a cosmetic change?


FWIW the true/false return value inference of success/failure is really the only potential breaking change. The ability to provide outputs is fully backwards compatible with the attr_reader way of doing things.


Just learning!


Yeah. Actually, I didn't meant to push this, I'm not super convinced one is better than the other.


just because I think it's a cool trick, do you know that you can write this as:

```
  .combineLatest(snake$, apples$, (snake, apples) => ({ snake, apples }))
```


Should " be replaced by `?


because it usually is, never seen something else


Btw, I should have mention this earlier but I think Circe already has this can you confirm?


I don't think it's necessary for this---just a habit.


Fun. `version.version`. Should we change to something more readable.


That does not appear to have worked. Still getting this page:
![screen shot 2017-08-02 at 4 58 09 pm](https://user-images.githubusercontent.com/8183594/28894769-e1e964ee-77a3-11e7-833e-37321b83ec7a.png)


prevents bug that… (etc)


this effectively makes country code required though.


This commit has been mentioned on **Discourse Meta**. There might be relevant details there:

https://meta.discourse.org/t/email-in-containing-br-b/67342/3


do you have any test cases for country validation when county is valid?


Noup! it's an XOR! if both are empty all is good.


OMG..... Декораторы.... Я бессилен.... Ей богу не разберусь.
Понятное дело что результат каждой итерации цикла записывается в memo,после чего finaly выдаётся так скажем-задом наперёд с последующим центрированием по формату с указанием предполагаемой ширины,но как это записать?


The exception is catched in zynthian_controller.set_value() method thus forcing the value to be sent via MIDI CC message. Without this lines the standard controllers such as 'volume','FX send','pan','sustain' do not apply their values to the channel during snapshot loading.


By the way how many players can be handled by the emu? someone on RZ mentioned that the performance is an issue that should be addressed. How serious is it, 50, 500, 1500 max?


The alternate solution could be - returning boolean value from zynthian_engine.send_controller_value() and checking it in zynthian_controller.set_value() method.


great!


Right, sorry.  Was typing it on the phone.


I've coded lightweight client (1kb, just winsock) that works like bot, it logs in, auto accepts party invite, walks around, and I was able to connect with 80 clients, no idea about more. As RevEngKal said, thread per client should be changed to poll/select.


FWIW, I changed hash_equals to private so it can't be called from outside the class


Looks good


@mzagaja We’re still pre-1.0, so there will be occasional breaking changes.


Scusami di nuovo, ma quando uno ti parla o ti scrive a cosa pensi? Agli asini che volano? Io ti ho detto di farci un kernel super sicuro e visto che noi usiamo lo zuk z2_plus cosa ce ne facciamo del tuo kernel?
Beh effettivamente quando ti sei sprecato per farcOra visto che non ho voglia di sbattermi mi faccio di nuovo tradurre questo commento e lo metto anche in inglese, cosi tutti possono capire.
Te lo ripeto. Facci il favore di scrivere i tuoi commenti idioti da qualche altra parte.


It's not necessary, but it did catch a copy-paste bug in an example that I wouldn't have noticed otherwise.


I've increased "static" refresh to 5 seconds - when nothing is pressed.
refresh is called on keyboard actions, so players should not feel any difference.


Perfect, thanks!


@dserdyuk i have created a new branch to review the alternative to either, https://github.com/LBNL-UCB-STI/beam/tree/router-either-to-beampath.


Why not `assert()`?

BTW, `assert()` and `require()` do about the same thing. The difference is they're meant to signal hints at (future) code analyzers. Generally (as I understand it), `assert()` for internal conditions and `require()` for user input. I think `require()` in this case because it's all about user input.


Oh, wait I think I got confused.  Now I remember, that is necessary because otherwise compilation doesn't even *show* warnings in doctests right?  Okay, that's important then, let me put that back!


we should be consistent with camel case and dash case.  I guess dash-case is more standard


Update_LEED_Reporting (JasonGlazer) - i386-Windows-7-VisualStudio-14: OK (2576 of 2577 tests passed, 0 test warnings)

Failures:

EnergyPlusFixture Test Summary
 * Passed: 498
 * Failed: 1

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.96%25-yellow.png)


I have a nood question. I have been on youtube for about 20 min already searching, but how do I sync/pull down your version to overwrite mine. I got some messages telling me I must first commit or stash. So I just deleted my file, but it still will not dowload your new version to my local drive.


Wassup People!!


Yeah, that's right. Maybe I should've put a better comment there.


@MythTitans That's interesting. Any idea why this would be used in the network protocol? From what I've read, the reason for using SSO is memory optimization on the client.


Pozdravujem
Pod enigma2 v plugine Stream Cinema a zozname Movies od 0-9 az po Z neide najst ziadne filmy. Ked zadam vyhladat akekykolvek film z abecedy tak vypisuje len I failed
greetings
Under Enigma2 in the Stream Cinema plug-in and the Movies list from 0-9 to the next, no movies can be found. When I go to search any movie from the alphabet I just list I failed
![img_20170802_225433](https://user-images.githubusercontent.com/15214168/28895361-5beba3b8-77d8-11e7-9eec-3066b4d6c2f6.jpg)


лучше без semicolon: `onclick="deleteEmployee()"`


Thanks for this fix. I'd like to use the POST command to turn on the LED.  Let me know if you make any progress on POSTing data to Dweet and using the data in some way (like turning the LED on the board)


Created multidev environment [ci-drops-8#c8-92](https://dashboard.pantheon.io/sites/689219ca-6583-4af8-ab05-2cebf6ef79a0#c8-92).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://c8-92-ci-drops-8.pantheonsite.io/)


Update_LEED_Reporting (JasonGlazer) - x86_64-MacOS-10.9-clang: OK (2569 of 2571 tests passed, 598 test warnings)

Messages:

 * 598 tests had: AUD diffs.
 * 251 tests had: MDD diffs.
 * 255 tests had: MTD diffs.

Failures:

regression Test Summary
 * Passed: 598
 * Failed: 2

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.92%25-yellow.png)


The problem with SFZ is that some of SFZ files should not be loaded directly, because they are included in some 'parent' SFZs with `#include` statement.
We must filter out theese 'child' SFZs from preset list someway, but we should not remove them from disk.


Ops had the same where the cpu options used dashes.


Typo: "there will may"


Bluemix [toolchain](https://dev-console.stage1.bluemix.net/devops/toolchains/723acd35-2682-4df5-a051-003140f6f443 "UI-ys1dev-SimpleTC0802T171430"): [Delivery Pipeline](https://dev-console.stage1.bluemix.net/devops/pipelines/77bea0f9-3a49-430e-9ae1-6e4fdcc99182 "UI-ys1dev-SimpleTC0802T171430") deployed [UI-ys1dev-SimpleTC0802T171430](https://github.com/idsb3t1/UI-ys1dev-SimpleTC0802T171430/releases/tag/deploy-ibm-ys1-us-south-idsb3t3-us.ibm.com-dev-20170802-211755 "deploy-ibm-ys1-us-south-idsb3t3-us.ibm.com-dev-20170802-211755") to [dev](https://console.stage1.bluemix.net/apps/8bb718a3-dbf0-47b2-89b5-f27aceff223c?env_id=ibm:ys1:us-south "ibm:ys1:us-south:idsb3t3@us.ibm.com:dev"), including this commit


When you wrote "-(possible, i kinda like it how it is)Tooltips on cells not instant", I'm tended to agree with you that it is fine as it is whereby tooltips over cells have a slight delay.  This is one of those highly subjective things.  Instant might be too annoying for some people (although I personally would prefer instant).  I would say leave it as is.


хм, `comment = ''`?


Почему? Чисто для красоты, или какой-то смысл есть?


[R/plotting-helpers.R:907:3:](https://github.com/PredictiveEcology/quickPlot/blob/42d1ddc32da27efa5adb81dd698ea50fa144764b/R/plotting-helpers.R#L907) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```
[R/plotting-other.R:163:3:](https://github.com/PredictiveEcology/quickPlot/blob/42d1ddc32da27efa5adb81dd698ea50fa144764b/R/plotting-other.R#L163) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^~~
```
[R/plotting-other.R:171:3:](https://github.com/PredictiveEcology/quickPlot/blob/42d1ddc32da27efa5adb81dd698ea50fa144764b/R/plotting-other.R#L171) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^~~
```
[R/plotting-other.R:175:3:](https://github.com/PredictiveEcology/quickPlot/blob/42d1ddc32da27efa5adb81dd698ea50fa144764b/R/plotting-other.R#L175) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^~~
```
[R/plotting-other.R:387:3:](https://github.com/PredictiveEcology/quickPlot/blob/42d1ddc32da27efa5adb81dd698ea50fa144764b/R/plotting-other.R#L387) *style:* **Trailing whitespace is superfluous.**
```r
#'
  ^
```


Can I just say how ashamed I am of the atrocious spelling of this commit subject?  👎


Can I just say _how_ ashamed I am of the atrocious spelling of this commit subject?


Yes, I'll update it. The implementation capitalizes the value before using it, so it worked anyway.


Типа, оставлять пустую строку? Ок, я ради шутки добавил "без комментариев"
Часто в жизни говорю так


`var` вначале функции, и только один
```js
function bla() {
    var a,
        b = 3,
        c;

    a = 123;
// some code
```


var в цикле плохо, надо в начало функции вынести


Hi, thanks for the fix! But I think you probably forgot about Multi Attack. Also how about normalize boosting moves that is originally normal type? I recall it should not boost the moves that is originally normalize but maybe asking something to confirm on cart again is preferred since I don't have the logs on those part. -fsk


let's rename isUrlInBypassList to isUrlInList or just use .some here


Changes look good to me.


Specific reason this is in the project?


Can we stop having commits directly to dev without PRs?
cc: @ajcvickers @divega


Bluemix [toolchain](https://dev-console.stage1.bluemix.net/devops/toolchains/b59af34f-bb1e-48f9-bfe3-6124c6569f90 "UI-ys1dev-KEEP-TC"): [Delivery Pipeline](https://dev-console.stage1.bluemix.net/devops/pipelines/95b48a85-90ae-4a2a-b138-ea0a6fbc4e6a "UI-ys1dev-KEEP-TC") deployed [UI-ys1dev-KEEP-TC](https://github.com/idsb3t1/UI-ys1dev-KEEP-TC/releases/tag/deploy-ibm-ys1-us-south-idsb3t4-us.ibm.com-dev-20170802-212441 "deploy-ibm-ys1-us-south-idsb3t4-us.ibm.com-dev-20170802-212441") to [dev](https://console.stage1.bluemix.net/apps/ca8a600e-5e2c-4839-a3a8-3b8db4327aff?env_id=ibm:ys1:us-south "ibm:ys1:us-south:idsb3t4@us.ibm.com:dev"), including this commit


This fixes #60, #40, but was never merged back to master.


kwcnkdjc


Yeah. AFAIK, there is no way to access i18n values inside the system keyboard. We can easily wrap these strings into `NSLocalizedStrings` which makes them localizable using standard iOS approach. Probably this is good idea.

And moreover, if we do this, we will have to introduce a way to opt-out this feature (because current `done` exclusivity also works as opt-in trigger).

If you (or someone else) have strong feeling that we need this fuctionality... I would love to review your PR! 😄


nckj


...or
we must check all SFZs and rename the 'childs', removing 'sfz' extension.


в цикле нельзя работать с DOM, надо выносить из цикла


#1912 claims the lack of a trailing semicolon.


This breaks building the demo app, because demos/main/build.gradle includes constants.gradle from wrong path.


Could you open source that client as well? This would be an ideal starting point to write some automated test, that could be run in every build by travis ci like, build server with docker, start docker, run tests against it. Could not only be used to check for bugs, but also for performance measurments. https://www.reddit.com/r/gamedev/comments/1toutc/what_makes_mmo_networking_code_so_difficult/


cc @jeff-da DRY! Always.