Sorry, my mistake.  Just had it fixed.


What's the problem with sync calls? Is it that they block execution?


OK!


Beyond1Airloop-Part2 (mjwitte) - Win64-Windows-7-VisualStudio-14: OK (2748 of 2748 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Can you please provide another implementation with only a simple servlet  not based on springboot ?


Ok, approved new update


Is there a reason you're formulating these comments in unnecessarily combative, accusatory questions?  If you have a suggestion for how I should code this contract, it would save me time if you would state it outright.


Even though it says not just to do this, this is good code, pretty much what I did on mine aswell


Thanks!


Created multidev environment [build-tools-704#ci-1](https://dashboard.pantheon.io/sites/bf6b23f1-1d87-47a1-a008-27b5a5ac9675#ci-1).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-1-build-tools-704.pantheonsite.io/)


Beyond1Airloop-Part2 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1534 of 1534 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-38.34%25-green.svg)


Comentario de prueba...


Excelente


I've been going through our commits and noticed that the addition of the identifier breaks encryption. It looks like the identifier is supposed to be used as part of the key generation process. Because we don't use that value during key generation password validation fails.

You can confirm by generating a PDF with line 2281 (password validation fails) and one with that line commented out (password validation succeeds).

I'm trying to figure out how we might deal with this, but so far am not having any success. I'll keep looking, but we may need to do as was done before and comment out the addition of the file identifier to the PDF source.


Created multidev environment [build-tools-702#ci-1](https://dashboard.pantheon.io/sites/fb6b5eb9-f9c3-4f91-8cd2-62ff8ca79c02#ci-1).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-1-build-tools-702.pantheonsite.io/)


This doesn't cover other cases like `F Y` which would still fail.


Try adding code like :<10s inside your {} to format the strings and place them in a nice neat column


When installing the package with jspm, all additional packages were not installed and only the main plugin was available. I was trying to implement the validation add-on.

Leonardo Schlossmacher

> Am 27.08.2017 um 05:19 schrieb Sebastian Tschan <notifications@github.com>:
>
> The NPM package includes all the front-end files.
> The server implementations are only samples and not part of the plugin itself.
> Which files are you missing that you think should be included?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.
>


<img width="1195" alt="screenshot 2017-08-30 19 37 13" src="https://user-images.githubusercontent.com/47046/29903798-a6f4c536-8dba-11e7-801e-7eb6c0d642cc.png">


try using the count method to just count how many times the word occurs in the split list in the for loop and add that count to a key in the dictionary


>I guess you're /u/OpenEmu on Reddit? Anyway, issues have been enabled now.

Nope, that's me :P


Laravel拼错了


为什么最新版的Badge，触碰上去Title不显示原来的数字了，也没有相关参数配置


There is only one import statement re: Ownable.  You will need to explain what "again" means in this context.


what will happen?


你好，我看了你的 [前端开源项目持续集成三剑客](http://blog.csdn.net/zhangzq86/article/details/55657322) 博客，然后一步一步跟着做下来，都挺顺利的。

但是最后提交 `coverage` `lcov.info` 的时候却显示文件为空。
```
The command "npm run test-ci" exited with 0.
cache.2
store build cache
0.03s
16.06snothing changed, not updating cache
after_script
1.73s$ npm run coveralls
> NetEase-Cloud-Music-Web@1.1.3 coveralls /home/travis/build/shianqi/NetEase-Cloud-Music-Web
> cat ./spec/coverage/lcov/lcov.info | ./node_modules/.bin/coveralls
[error] "2017-08-31T02:16:46.619Z"  'error from lcovParse: ' 'Failed to parse string'
[error] "2017-08-31T02:16:46.623Z"  'input: ' ''
[error] "2017-08-31T02:16:46.624Z"  'error from convertLcovToCoveralls'
/home/travis/build/shianqi/NetEase-Cloud-Music-Web/node_modules/coveralls/bin/coveralls.js:18
        throw err;
        ^
Failed to parse string
```
这是我的项目地址 [NetEase-Cloud-Music-Web](https://github.com/shianqi/NetEase-Cloud-Music-Web)
能否麻烦不忙的时候帮我看看，谢啦


SVM using Scikit


Fixed the logic where regex match adds a new field than replacing the existing one.
Added field mapping


I think you should have another comma: `, or you're using an alias,`


How are the passwords initially set then?  The constructor will have to receive two passwords to compare.  Is your point that there should be two separate password hashes and not rely on the sender?  Is your underlying point as to that that msg.sender can be spoofed so it shouldn't be relied upon as an authentication mechanism?


TeamCity Overdrive :: Test Teamcity 1 :: BuildBranch name: OD-9785 [Build 118](http://192.168.189.131/viewLog.html?buildId=263&buildTypeId=Overdrive_TestTeamcity1_Build) outcome was **FAILURE**

[Jira link https://ankiinc.atlassian.net/browse/od-9785](https://ankiinc.atlassian.net/browse/od-9785)Summary: failure Build time: 00:00:21
Build status is not normal, not calculating artifact size


New change


LocalNodeNetwork (XuanLuoLBL) - i386-Windows-7-VisualStudio-14: OK (2751 of 2754 tests passed, 14 test warnings)

Messages:

 * 13 tests had: AUD diffs.
 * 12 tests had: BND diffs.
 * 1 test had: ESO small diffs.
 * 1 test had: EIO diffs.
 * 1 test had: ESO big diffs.
 * 1 test had: Table big diffs.

Failures:

EnergyPlusFixture Test Summary
 * Passed: 530
 * Failed: 2

regression Test Summary
 * Passed: 605
 * Failed: 1

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.png)


Make what in the constructor?


No, it was a typo.


Created multidev environment [build-tools-710#ci-1](https://dashboard.pantheon.io/sites/0316b026-f5e8-4f18-be0d-6aa322c37551#ci-1).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-1-build-tools-710.pantheonsite.io/)


149930772-SurfacePVZoneMultiplierProblem (rraustad) - x86_64-MacOS-10.9-clang: OK (2748 of 2748 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


## This is a markdown file


Note to self: Should be run in transaction with `key.destroy`


отступы, форматирование всегда проверяй


sorry, now I see your point. If `%process-status` would never be called from LW on Windows, then I think we shouldn't let LW compiler see it on Windows, e.g. use #-os-window on top of the whole function, and the non-existing functions won't be problems at all.


Note to self: Should probably be protected by a mutex


@willyjlee Why not just use the theme_uclashared lang string "help_n_feedback"? Or add it to the Snap theme lang files.


I haven't tried but I can give it a go.


@willyjlee The point of the task is to use the existing configuration setting: custommenuitems


@peterhoeg I use the following alias as a reminder:

```
$ git config alias.backport
cherry-pick -x
```


@willyjlee Why does this need to be upgraded?


Solves Issue #1


Fix links


They are there to check if anything fails on Trusty. Turns out *pretty much everything* fails :) I'm working on this.


**I've remove the calcul.php file & I create the index of script**


Maybe just "Uses `cyberark/ansible-role-conjur` to ...".

In general I think action verbs are better for numbered lists like this, where you are talking about a script that does something for you.

`cyberark/ansible-role-conjur ` could also be a link, I suppose.


Created multidev environment [bitsource-jump2#pr-address](https://dashboard.pantheon.io/sites/f31c73eb-ef2d-4193-b746-34c85f8897ca#pr-address).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-address-bitsource-jump2.pantheonsite.io/)


Note to self: `error.message` does not have a enduser friendly format.


On 31/08/2017 01:02, VZ wrote:
> But these repeated if statements just scream "use a virtual
> function instead" to me...

I would go for virtual functions only to benefit from the open-closed
principle. But this principle is not fulfilled here, because the number
of different behaviours is known and relatively constant. This means
that this is a basic finite state machine, where if/else (or a switch,
for larger number of variants) is a valid solution. The advantage of
this is a simple architecture and locality of code.
That is, virtual functions would not solve any problem here.

Regards,

--
Maciej Sobczak * www.msobczak.com * www.inspirel.com


Is this really the intended status for it() within xdescribe()?

Previously it() specDone inside of xdescribe() will have status 'pending'; now the it() spec is 'disabled'.  Our post-test analysis reporter fails because files with only xdescribe() -- meaning a suite of pending, deliberately deactivated specs -- are now counted as identical with specs filtered out or specs not run because of focusing.  We can no longer allow xdescribe()/xit() but disallow fdescribe()/fit() because we can't distinguish these in the reporter.

In my opinion the status of it() within xdescribe() should always be 'pending'; no dynamics should affect this.


LocalNodeNetwork (XuanLuoLBL) - Win64-Windows-7-VisualStudio-14: OK (2753 of 2755 tests passed, 14 test warnings)

Messages:

 * 13 tests had: AUD diffs.
 * 12 tests had: BND diffs.
 * 1 test had: ESO small diffs.
 * 1 test had: EIO diffs.
 * 1 test had: ESO big diffs.
 * 1 test had: Table big diffs.

Failures:

EnergyPlusFixture Test Summary
 * Passed: 531
 * Failed: 1

regression Test Summary
 * Passed: 605
 * Failed: 1

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.93%25-yellow.png)


Perhaps it would make more sense to just have a `deploy.sh` script, with `ANSIBLE_ENVIRONMENT=$1`/etc. We shouldn't shadow `ENV` or `ENVIRONMENT`, I dunno if Ansible has a convention for the environment variable. If so we should use it.

This change would make the demo flow simpler and match real-world Ansible flows more closely, where you use the same playbooks to target different hosts based on arguments or parameters.

`./deploy.sh staging`, `./deploy.sh production` would be perfect.


I think with ecl on windows it can actually be used. So disabling it on windows altogether would be too much. Not sure. I’d like to leave that decision to @rpgoldman.

While we’re waiting for @fare to comment on the other part of the patch, I can already quote him as
> (:LOAD-TOPLEVEL :EXECUTE) is safe, but it is the implicit default around any toplevel form and thus you never need to specify it explicitly, except possibly to restrict the effects of a surrounding EVAL-WHEN when used inside a macro that may expand to such thing (which would be poor style).

from https://fare.livejournal.com/146698.html


This has since gotten broken again. I think it's due to the card system Google's using for calculated results.


cc @ocornut


Comment on commit 85dcb16, made at 08-31-2017 03:12:30 P.M.. this comment says:
"I am unclear as to what is happening. I have to go over the steps I went through in GitHub Guides.
 Then I will comment further!"


thanks @tjrocha   -- The actual error is duplicate data in the cfg data.  Exposed when we assign a primary key.   Perhaps there is more than one duplicate entry?   I would prefer not to have duplicate code.


Usually this looks more like `roles_path = roles_vendor`. Is there a way to get that path looking nicer like that?

Example: https://github.com/conjurinc/docker-registry-ansible-aws/blob/master/ansible.cfg#L8


Do kitu sa te pytajniki w rombach :<<<


@mrniko just a note that generally bytebufs should be released in try finally blocks otherwise they may cause memory leaks if an exception is thrown.


ResetNodeDataEarlier (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2147 of 2147 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.91%25-green.svg)


@NonSecwitter Yes because with OpenVPN 2.4 it is not needed. OpenVPN 2.4 contains a rewritten service interaction feature which allows the GUI to run as a non-admin user. The management utility had problems and was not being maintained, the person who added that code didn't keep it up.


with all these `../`, the ansible.cfg file should really be in project root.

Example: https://github.com/conjurinc/jenkins/blob/master/ansible.cfg

The `jenkins` repo is an execution, or site, repo in Ansible parlay. So is this demo repo. I tried to follow conventions settings up Jenkins to avoid odd paths and make it easy to work with Docker and docker-compose, maybe you'll find some inspiration there.

`cyberark/ansible-role-conjur` is a role, so that's a different story.


Also got rid of security


ResetNodeDataEarlier (mjwitte) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


We should be able to group target `*-staging`/*_staging` (which one?). Then you could configure this whole shebang in 4 lines.


Created multidev environment [napcs2017#pr-content](https://dashboard.pantheon.io/sites/23095a75-4a68-4e85-ba90-d57a28c216b6#pr-content).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-content-napcs2017.pantheonsite.io/)


Do you plan on having this do something with a secret? Even something simple, just sticking it into the OS keychain/etc would be better than `shell:` and `debug:`.


I am sorry but I have lots of work to do. Try to search for freelancer.


ok. i'll clean the csv and revert/recommit. thanks!


With new ansible versions you can interpolate `hosts: *-staging` I believe. They you can pass in the env with a `-e` param or an ansible env var (i think).

This pattern, matched with host grouping in inventory, allows you to target Ansible hosts in many ways and write less code.


Perhaps we should only have one `foo.yml`, along with ^. What is `foo`?


Should add comment stating the Ignition spec doesn't specify order and its just the implementation that causes `additional-partition-one` to always get number 3 and `additional-partition-two` to always get number 4


is this going to be a real `version` once that ansiblefest branch in the role is merged?


Nice!


Well, the other obvious solution is to use my patch in PR #3 (plus reverting L238-239): it's perfect in the sense that, there's no compiler warning in all platform/LW version combinations. On Windows it doesn't matter if the busyness logic is correct or not, simply because it won't be called by LW on windows.

On `(:LOAD-TOPLEVEL :EXECUTE)`, I personally think it's reasonable for LispWorks to throw a warning when you wrap a `(deftype ..)` into `(eval-when :compile-toplevel)`, after all you can't put everything under `(:compile-toplevel)` and expect nothing abnormal happens.  I don't know ASDF's history on the adoption of `with-upgradability` macro, but it seems meaningless and harmful for `(deftype ..)` forms.  Or you may say LispWorks 6 compiler is not fully ANSI-compliant while LW 7 compiler is much better, then my patch is totally a workaround solution for making LW 6 compiler happy.


Some IDs have `NY` in them, and some have `A` in them.


I think you could do something like this:
```purescript
cubehelix = minColorStops 100 gen (ColorStops b Nil e)
  where
  gen _ = mixCubehelix 1.0 b e
  b = hsl 300.0 0.5 0.0
  e = hsl (-240.0) 0.5 1.0
```


Looks like I forgot to amend the commit I copied over from my CL machine before I ran `git format-patch`, fixing


good call, no need


Grade A translation


Now that I've learned a little about libraries, I feel a little guilty for altering this one.

Should I put my additions in my library?

Or make a separate CommandsLib for everyone to add to?

Or just leave it in here since everyone needs to see that the commands exist?


Do you have to check r won't go negative?


You just want to disable L171 (the assertion). If you disable the call to `svg`, new SVG snapshots will no longer be generated and saved with `npm run test:runtime:generate`.


Maybe all the additions to r should happen before any possible subtractions.


Super!


#6282-SimHVAC-max-iteration-warnings-caused-by-CoilHeatingGasMultiStage (lgu1234) - x86_64-MacOS-10.9-clang: OK (2749 of 2749 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


OutputUnitsRefactor (JasonGlazer) - i386-Windows-7-VisualStudio-14: OK (2749 of 2749 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


cara tá bom mas tá feio :confused:
[Mas ....](https://github.com/meta-sistemas-2017/plataforma-mobilidade/tree/master/Aula-03/Atividade/weslley%20dutra)


geometry_editor (macumber) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


149930772-SurfacePVZoneMultiplierProblem (RKStrand) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I hear you — I'm thinking of the dropdown-menu as being like a replacement for a <select>, whereas the dropdown-panel is something more; something that can contain many elements and configuration details and which you explicitly dismiss. I've got a <form> and a submit/save button in my panel.

> Nested dropdowns represent a decision tree, no matter what they are composed of.
That is just one usecase you are thinking of though


Created multidev environment [stevector-composer#pr-7](https://dashboard.pantheon.io/sites/942ab37c-7915-45dd-8508-5f1fb4fd2d4b#pr-7).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-7-stevector-composer.pantheonsite.io/)


List and Hyperlinks


You could move `owner` into `Owned`.


nevermind. looks like you beat me to it.


Since your mapping is public, this function is redundant.


@mstembera
that is no problem because in line 1000 it is granted that r becomes not negative.
`r = std::max(DEPTH_ZERO, (r / ONE_PLY - ss->statScore / 20000) * ONE_PLY);`


149930772-SurfacePVZoneMultiplierProblem (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2146 of 2146 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.87%25-green.png)


Remove TODOs here and below


This can go into `PullPayment`.


Perhaps have a link to the question's metadata. `bytes32` if possible.


Remove empty line between command.execute and verify


Changed to make it more readable and in line with index.html


Created multidev environment [napcs2017#pr-content](https://dashboard.pantheon.io/sites/23095a75-4a68-4e85-ba90-d57a28c216b6#pr-content).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-content-napcs2017.pantheonsite.io/)


Can I not increase my bet on the same outcome?


Hello


Doesn't work.


LocalNodeNetwork (XuanLuoLBL) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


It is clean and strict, good. But it also means the balance was set twice in this transaction. Perhaps you could do it cheaper?


Currently only works with the older version of youtube.  Go to settings in youtube and select "use old version".


Perhaps the request status is resolved should come here instead of the private function.


Options ?


I don't like the name of the file. Let's call it page_with_multiple_selectable_elements.html


Nice! Don't forget to add the test methods similar to unit test version you did today.


ok


Actually, just look at `_txn.logs`.


@dumbbell @gerhard - my commit originally specified `/bin/sh`, but this one changed it: ab705f8359fada8cc9ccdc72ff638657956f2d06

You may want to ask why @hairyhum made that change.


Nice! I've changed it to your implementation


Don't use sync calls.


Care to submit a PR to nyc?


`assert.strictEqual(blah.toString(10), )` will give more meaningful errors.


Mmmm. I did think about that. But then I wanted a duration of 0 in the constructor to mean no deadline. Perhaps I should just pass a -1 for that then?


Why networkid and port number are same?


Du meinst in Richtung if __name__ == '__main__' ? Macht Sinn :D


You should also add tests for "should not allow an untrusted...".


`/home/ramon/knot/knot-gateway-webui/app/schemas/cloud.js
  5:50  error  Expected line break before `.required`  newline-per-chained-call`

Lint error


I might have paired with @hairyhum on it, in which case we were just testing that CI has our back -which it totally did! 🤖

If anything, this made me trust our tools more, I can only see a win-win here 😉


Cannot pass a negative number in `uint`. I think no deadline is not good. If you insist, just pass `0xffffffffffff...`.


I thought I could just use `this.balance`. What do you make of that?


Using `this.balance` in a utility contract is dangerous. Take the habit of accounting for now.


wha da ya mean it's not nice?


This commit makes things less DRY, but I feel like it's better this way, as the string serves as inline documentation as to what is being asserted, and it makes it easier to arbitrarily change the contents of the profile when subtle changes need to be asserted.


These were a pain to write, and I was scared of the maintenance burden of them.


Of course the other thing that doesn't really make sense, is that the script wrapper starts with the correct shebang (`#!/bin/sh`) and should be marked executable ... so why is this even necessary? 🤔


rails new depot - command for creating project which name is "ddepot"


So one hash to preserve the privacy of the recipient sending the transaction (didn't want it to be obvious that his/her address is an argument).
Second hash so passwords aren't saved on the blockchain in plain form.


This snapshot had to change due to the requirement that JS samples end in `.js` with the text samples fixture.


This also closes #1418


`secrets-users` and `secrets-admins` would be more descriptive here I think. We use that convention in conjurops-policies.


is it security?


This first commit changes everything over to `getProfileFromTextSamples` without changing the following assertions. See the next commit for more changes.


Ah, thanks!


This is now a shared utility.


Grouping these variables makes it much easier to assign them permissions. It also makes the easier to read.

Example: https://github.com/conjurinc/conjurops-policies/blob/master/policy/quay.yml#L8


Ah okay! noted. Thanks :)


Maybe you could indent `\` these more, to make them easier to read?


develop (macumber) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


What is this image? Can we not use `ruby:2.3`?


`\`'s please


@Hainish, https://github.com/EFForg/https-everywhere/pull/12275


[That's odd. I thought that would be in here. There seems to be an absence of a certain ornithilogical piece. A video regarding mass awareness of a certain… avian variety.](https://www.youtube.com/watch?v=7OXVPgu6urw#t=2m12s)


The snapshots and diffs have proved far more ergonomic than my previous test assertions. This drastically lowers the LOC but still provides the same coverage. These tests still feel a bit redundant with the transform tests, but at this time I think they are worth keeping mainly due to the fact that this file is exclusively focused on the call tree.


[Jenkins vg tests](http://jenkins.cgcloud.info/job/vg/418/) complete for merge to master.  View the [full report here](http://cgl-pipeline-inputs.s3.amazonaws.com/vg_cgl/vg_ci/jenkins_reports/branch/master/index.html).

9 tests passed, 0 tests failed and 10 tests skipped in 11043 seconds

Tests produced 3095 warnings. 3088 were for lower-than-expected alignment scores


No more magic numbers.


Hehe. Rookie idea I guess :). Out of interest why is no deadline not good?


Created multidev environment [stevector-composer#dev](https://dashboard.pantheon.io/sites/942ab37c-7915-45dd-8508-5f1fb4fd2d4b#dev).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://dev-stevector-composer.pantheonsite.io/)


I think at this moment, the target presenter is null, then the view is invalid into presenter too.


Thanks Frank, I did not know those were there and I have remove them.

Normally when setting up a new repo it takes some time to figure out a
decent set of ".gitignores" that covers all the random provided by
different operating systems.

--
Jody Garnett

On 31 August 2017 at 05:26, Frank Gasdorf <notifications@github.com> wrote:

> @jodygarnett <https://github.com/jodygarnett> Cloning this repository on
> Windows causes problems while creating resources for {{Icon}} files (are
> they empty??):
> {code}
> error: unable to create file marketing/branding/fonts/MiriamLibre/Icon?:
> Invalid argument
> error: unable to create file marketing/branding/fonts/Sintony/Icon?:
> Invalid argument
> {code}
>
> Are they relevant and used somewhere, how can I deal with this
> cloning-issues?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/OSGeo/osgeo/commit/13695635123c608b2b50c276127f29a619afc318#commitcomment-23998656>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAmbsQ3dzv3RJgTXaJtMuBdk8f9bQUOXks5sdqaIgaJpZM4PIwOm>
> .
>


The commit message has the answer:

> Because the rabbitmq user shell defaults to `/bin/false`, we must
explicitly define a shell when using the `runuser` command

The `rabbitmq` system user has the shell set in `/etc/passwd` to`/bin/false`, so unless we explicitly define a shell, `runuser` will pick the default `rabbitmq` user shell and exit 1, the expected `/bin/false/` behaviour.


I consolidated the configurable profile fixture generators into one file.


Thanks @xavierlepretre ! I think I'm getting the idea now. Absolutely everything as explicit as possible. Always one expected behaviour.


closes #5


There aren't any code changes here, just moving functions into new files.


Hmm. I'm not sure I follow. They are the same as the constructor yes.


I tried to make this less confusing by calling it a gecko profile.


OutputUnitsRefactor (JasonGlazer) - Win64-Windows-7-VisualStudio-14: OK (2749 of 2749 tests passed, 24 test warnings)

Messages:

 * 24 tests had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


moved to `src/test/fixtures/profiles/make-profile.js`


A single hash would have done that too, no?


@lewissbaker FYI, it looks like the same problem exists in the `sync_wait` function you and @GorNishanov helped me write. :-P


![](https://github.trello.services/images/mini-trello-icon.png) [Update to Ubuntu 16.04.3.](https://trello.com/c/yoNQY32j/52-update-to-ubuntu-16043)


![](https://github.trello.services/images/mini-trello-icon.png) [Create python script to generate network configuration file for each node.](https://trello.com/c/7W9pHMsV/37-create-python-script-to-generate-network-configuration-file-for-each-node)


`void_t` is a terrible name, even though it's in the standard
`when_valid` looks like a much better alternative as far as illustrating what it's actually meant for


Because it means there will be Ethers locked. If Bob no longer thinks that the Ether is worth the USD, he will just not do the deal. What can then Alice do with her "lost" Ethers? Unless she can get them back after the deadline.


`Ts` don't need to be named


Wait wtf why wasn't `Search` originally a class??????


The transaction that created the contract is public knowledge. I just look into the transactions and I know what they were. I don't need to be Bob.


This and the last two commits were done to eliminate all outstanding changes, so I could git-filter-branch and remove the webcasdata DB from previous commits on this repo.  It really shouldn't be publicly available.


Not sure that `PAGES_AND_CHILDREN` is a property that is generic enough for a notification filter. It is indeed useful for the ScopeNotificationFilter (which is what we're implementing ATM), but I don't see any use cases of such property in other filters.

For me, if we want to take into account the idea that we'll (probably) get rid of spaces pretty soon, then we should just remove this property and deal with that in the implementation of the ScopeNotificationFilter (it might imply creating a new XClass dedicated for scope preferences like "NotificationFilterPreferenceScopeClass").

@vmassol I do agree on renaming `PAGE` to `DOCUMENT`.

FYI, for now, those filter properties are derived from what is mentioned here : https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-activitystream/xwiki-platform-activitystream-api/src/main/resources/activitystream.hbm.xml#L40


Like !  :+1:


@jingc Can you explain why this was reverted and whether you plan to fix this commit and merge it back in?

I am the author of this commit (through PR #15542). In the future, it would be nice to be notified when one of my commits is reverted. I only happened to become aware of the revert by chance while I was looking through the git history.

cc @shergin who imported my PR.


there's `FATAL_EXPECT_FALSE` and `FATAL_EXPECT_TRUE`


@yfeldblum comments inline


LocalNodeNetwork (XuanLuoLBL) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1541 of 1541 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-38.46%25-green.png)


this was very boring work but im so glad i got it done now


a


So that just disables auto-registration, it still creates a client. I think there is a eureka specific property to disable the client as well.


WTF kind of this commit! can you commit one change at the time or provide change logs.
@EricDavies


Created multidev environment [stevector-composer#pr-11](https://dashboard.pantheon.io/sites/942ab37c-7915-45dd-8508-5f1fb4fd2d4b#pr-11).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-11-stevector-composer.pantheonsite.io/)


lgtm


Good job, thanks for this one!


Storing a pointer but asking for a reference, why?


CLI tests pass on Windows.


I can't remember the one I used but it was just an online tool, sorta like this one I think. https://icomoon.io/app


Created multidev environment [stevector-composer#dev](https://dashboard.pantheon.io/sites/942ab37c-7915-45dd-8508-5f1fb4fd2d4b#dev).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://dev-stevector-composer.pantheonsite.io/)


This occurs more than once, I just didn't want to spam you with comments about the same thing. Can you please check the rest of your code for stylistic comments I made?


Strange how this 0x80 seems to differ from the pattern mentioned above - how's that possible?


I believe this should probably be (*(void * const *)(addr))

The memory dereferenced is const, but the pointer it stores can point to anything.


Nightly and Weekly passed :)


devDependencies?


Did you move everything on the ci namespace? Can you also update the prow readme?


This means Realm will always create spatialAveraging instance, then we don't need two constructors for ABL* classes nor do we need different constructors for SpatialAveraging


closes #77


Not buttonHeld() and buttonClicked(), which don't exist, but instead buttonWasHeld() and buttonWasClicked(). These are effectively now redundant (for the moment)


resume update


Unless you really don't care about this rule, I'm skeptical about changing this setting instead of just ignoring it for a line / block / file (or ignoring a file entirely, if you like).

https://github.com/sasstools/sass-lint#disabling-linters-via-source


I just picked a number for both to have no conflict with other coins.


ContainerInterface тут временно


@locutus2
I c.  Now I wonder if line 966 needs to be checking explicitly.


Probably safer to do a check-sleep loop that waits till the Control Plane's health check endpoint returns 200, would be safer;


Passeando...
Já arrumei :)


Ok.


Created multidev environment [stevector-composer#pr-12](https://dashboard.pantheon.io/sites/942ab37c-7915-45dd-8508-5f1fb4fd2d4b#pr-12).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-12-stevector-composer.pantheonsite.io/)


Perhaps '<canvas>'


Closes issue #6


Hmm, weird that it doesn't complain about the previous chained calls... In the Joi examples, they usually write all validators in one line and I followed it, but it can improve clarity if we put them one below the other, grouping when makes sense.

Let's rewrite these schemas to be (I'll do the same in my patches):
```
  servername: joi
    .string()
    .hostname()
    .required()
  port: joi
    .number()
    .integer().min(1).max(65535)
    .required()
```

I think this way we can scan the file quickly and understand the rules. Do you agree?


?? wtf? <canvas>


Source map tests passed.

Publishing.


guh? canvas in < and >


wtf indeed?


< canvas >


Mind the indentation, because if you put the validators call in the same indent level as the field definition the linter won't complain, but I think it is harder to read.


@alyxrossetti
If we can check to make sure arrangement is always an array like this:

if (typeof arrangement === 'string') {
  arrangement = [arrangement]
}

then we don't have have the "v-if v-else" in the template. Correct?


hahahahahahaha


ok


A real php file.


#2520943-WindowsCalc-Engine_Integration (vidanovic) - i386-Windows-7-VisualStudio-14: OK (3119 of 3124 tests passed, 0 test warnings)

Failures:

EnergyPlusFixture Test Summary
 * Passed: 525
 * Failed: 1

integration Test Summary
 * Passed: 608
 * Failed: 4

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.png)


The addition of `RuntimeException` here may produce a mildly misleading error on line 337, since there is no such class in `ceylon.language`. It might not be worth worry about, though.


I've got a script to auto-generate all the plugins. I'm just waiting for the github rate-limit to calm down before testing it proper: https://github.com/zimbatm/nixpkgs/tree/terraform-update-all


No, they are final fields with initializers, so dataflow refines the type.


creates an set of < svg> and < canvas > elements


what do you mean?...if yu mean taming or riding? .. no


hmm
does not work for me
tested with and without "Auto Self Cast"
but "ALT" Click still works (any ALT-Click -> Left, Right, Middle, 4, 5, ...)


c++17 (lefticus) - x86_64-Linux-Ubuntu-17.04-clang-3.6: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


c++17 (lefticus) - x86_64-Linux-Ubuntu-17.04-clang-3.6-LibC++: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


@CPColin ah, cool, thanks for noticing. Fixed now.


Just so s is anything else but `nullptr`.


If you really want to differentiate them I think the current way is fine.


c++17 (lefticus) - x86_64-Linux-Ubuntu-17.04-clang-3.6-AddressSanitizer: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


c++17 (lefticus) - x86_64-Linux-Ubuntu-17.04-clang-3.6-ThreadSanitizer: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


I prefer explicit annotations on fields. This only works for private final fields and even then we ran into issues with ordering.
Having the explicit annotations there is good documentation, which is why we had them before.


c++17 (lefticus) - x86_64-Linux-Ubuntu-17.04-clang-3.7: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


c++17 (lefticus) - x86_64-Linux-Ubuntu-17.04-clang-3.7-LibC++: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


c++17 (lefticus) - x86_64-Linux-Ubuntu-17.04-gcc-4.9: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


Is following the same and adding you as a collaborator. I must be blind and can't see it. Lol
Thanks. Lol
Jamie.

Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Elisa Beshero-Bondar <notifications@github.com>
Sent: Thursday, August 31, 2017 2:33:58 PM
To: Jamielynn92/Tinkerbell
Cc: Downey, Jamie L; Comment
Subject: Re: [Jamielynn92/Tinkerbell] Update README.md (0cee1f3)

Look on the left side of the page, and click on "Collaborators". You'll be prompted for your GitHub password, but after that you'll be able to add me!

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJamielynn92%2FTinkerbell%2Fcommit%2F0cee1f3ce11b99ca689bc88309593a1f4516e738%23commitcomment-24006528&data=01%7C01%7Cjld195%40pitt.edu%7C7af7f098a4d54bcec5b708d4f09ed874%7C9ef9f489e0a04eeb87cc3a526112fd0d%7C1&sdata=VVGQ0NkUV0xWL%2BNnhHQOy3PuTHY8AroQbZy7q9CP8LQ%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAeBcSaMtKmZgNyoD9HbRj7zvOOTzhTNvks5sdvyWgaJpZM4PIR2r&data=01%7C01%7Cjld195%40pitt.edu%7C7af7f098a4d54bcec5b708d4f09ed874%7C9ef9f489e0a04eeb87cc3a526112fd0d%7C1&sdata=4TccknnH%2FS4mjdETIpLF9LhcK4At6FtR3qr8XdPu0EA%3D&reserved=0>.


c++17 (lefticus) - x86_64-Linux-Ubuntu-17.04-gcc-4.9-NoThreads: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


Nice badge 👍


Strange... working flawlessly on my end. I'll check so more.


c++17 (lefticus) - x86_64-Linux-Ubuntu-17.04-gcc-5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


Wuhuhu, party, celebrations!!


c++17 (lefticus) - x86_64-Linux-Ubuntu-17.04-cppcheck-1.79: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png)


Boolean which specifies not to draw the series bars


c++17 (lefticus) - x86_64-Linux-Ubuntu-17.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png)


@mstembera
That is the capture or promotion branch so we need there the check. Line 1000 is only used for the non captures


@joncampbell123 imfplay makes static sound while playing on my IBM Thinkpad 600e. also i think the adlib shut up makes a poot sound... wwww also when i can (lappy4 needs a keyboard so when it comes in i can do this correctly and not have to worry about slower derpy4) i will do the merging mentioned in the commit wwww


constexpr (lefticus) - x86_64-Linux-Ubuntu-17.04-clang-3.6: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/c54456fd-d03a-48fe-b6d0-2dbf0014c96d "leeloo-acme-freight"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/00016203-b7e3-499c-952a-0471b9b0211e "webui") deployed [acme-freight-webui](https://github.com/leeloo-acme-freight/acme-freight-webui/releases/tag/deploy-ibm-yp-us-south-milbuild-us.ibm.com-leeloo-20170831-214228 "deploy-ibm-yp-us-south-milbuild-us.ibm.com-leeloo-20170831-214228") to [leeloo](https://console.bluemix.net/apps/9ef5f946-b149-4cd6-8163-e198df6790f9?env_id=ibm:yp:us-south "ibm:yp:us-south:milbuild@us.ibm.com:leeloo"), including this commit


Managed to get CSRF working.
I forgot to set withCredentials header for the csrf request, meaning that the session that the token was valid for, was not valid for the API request.


constexpr (lefticus) - x86_64-Linux-Ubuntu-17.04-clang-3.6-LibC++: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


What?


Ok fine, but only because of the way that HTML boolean attributes are weird and indicate (with their presence or absense) *whether* to draw the series bars. Again, this is not a pull request, change it back if you want.


I fixed in this commit https://github.com/dacsang97/unsplash-gallery/commit/5afef160888e94e14a17cab2230d1749cee1700f


Mixin for view + error handler https://github.com/dacsang97/unsplash-gallery/commit/55ac28b8a8f8ad02800d2980974aff78a703ecce


you removed __addedMediaStream support


I find them distracting, but if you feel strongly, feel free to add them back.


i think beter
> /dev/null 2>&1


constexpr (lefticus) - x86_64-Linux-Ubuntu-17.04-clang-3.6-ThreadSanitizer: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


Quebec


How do you know whether somebody intended the strings to be compiler keys or not? Your pull request only said that you change annotations-in-comments into normal ones, not that you also drop annotations you don't like.


constexpr (lefticus) - x86_64-Linux-Ubuntu-17.04-clang-3.7: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


SVG < g >


@joncampbell123 http://www.shikadi.net/camoto is the only thing i found that can do raw2imf


I think you got confused, I replaced `ng-storage` with `ngstorage` in the `webpack.config.js` in this patch.


constexpr (lefticus) - x86_64-Linux-Ubuntu-17.04-clang-3.7-LibC++: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


What is Prolly?


constexpr (lefticus) - x86_64-Linux-Ubuntu-17.04-gcc-4.9: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


constexpr (lefticus) - x86_64-Linux-Ubuntu-17.04-gcc-4.9-NoThreads: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


constexpr (lefticus) - x86_64-Linux-Ubuntu-17.04-gcc-5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.png)


@adamleff no `#hedgpeth if statement`? :P


eu baixei este postscript mais não faço nem ideia como funciona,


I just checked, `angular-messages` in there in the `webpack.config.js`' vendors list.


constexpr (lefticus) - x86_64-Linux-Ubuntu-17.04-cppcheck-1.79: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png)


constexpr (lefticus) - x86_64-Linux-Ubuntu-17.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png)


Spacing issue again. Please correct. 1 tab from opening the tag (<iframe


o plural de query é queries :)


Remove extra line


Yeah, I deployed the build into CI name space


@mstembera
I have measured on my big bench that in the capture or promotion branch the base reduction is zero in around 1% of all cases. So without this check in this 1% cases we would increase the search depth by one ply instead of reducing


The following doc(s) have been deployed to the [styleguide](https://styleguide-static-docs.pantheonsite.io/docs) Multidev environment:
- [/docs/style-guide](https://styleguide-static-docs.pantheonsite.io/docs/style-guide)


Why not just set this to zero in handleBatch()?


doc updated in 751312195ab4b49314926aa46fbdb91489ab867f


/Shrugs


Solves the issue #79 of character's shadows not being rendered.


These things can be subtle indeed!

I'd better go check cppcoro for the same issue...


dedup was eating lots of memory when encountering a transition to next chromosome block:
Max fixed: _dedup.pyx to address this issue
Max improved pairsam_dedup.py to dynamically scale the block size (which is important for datasets with high duplication rate).


@1jr come over to https://gitter.im/AnySoftKeyboard/Lobby


![plot ts_cudatats](https://user-images.githubusercontent.com/24898905/29947203-111c34ba-8ec6-11e7-9ec5-68c7e74ea8db.jpeg)


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/b09e3ee0-bc62-4bd7-bcf6-7b033dada6af "TriAzurUE"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/57bc70fc-3a85-4eb7-a477-d1a67ac25fb2 "TriAzurUE") deployed [TriAzur_code](https://github.com/Doncassino/TriAzur_code/releases/tag/deploy-ibm-yp-eu-gb-TriAzur-TriAzur-20170831-220254 "deploy-ibm-yp-eu-gb-TriAzur-TriAzur-20170831-220254") to [TriAzur](https://console.bluemix.net/apps/11b7850a-b04f-4546-975c-fb2662c615cd?env_id=ibm:yp:eu-gb "ibm:yp:eu-gb:TriAzur:TriAzur"), including this commit


The following doc(s) have been deployed to the [hotfix](https://hotfix-static-docs.pantheonsite.io/docs) Multidev environment:
- [/docs/backups](https://hotfix-static-docs.pantheonsite.io/docs/backups)
- [/docs/drush](https://hotfix-static-docs.pantheonsite.io/docs/drush)


#2520943-WindowsCalc-Engine_Integration (vidanovic) - Win64-Windows-7-VisualStudio-14: OK (3119 of 3124 tests passed, 605 test warnings)

Messages:

 * 606 tests had: AUD diffs.
 * 1 test had: EIO diffs.
 * 1 test had: ESO big diffs.
 * 1 test had: Table small diffs.

Failures:

integration Test Summary
 * Passed: 608
 * Failed: 4

regression Test Summary
 * Passed: 609
 * Failed: 1

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.png)


AHA!
if i **change** the "Key Down" feature: ElvUI -> ActionBars -> Key Down (CheckBox) Rightclick Self-Cast work until Reload.
Does not care if it is enabed or disabled after reload, but need to change the state Checked <> Unchecked and it works...
But just until reload :/


It didn't seem necessary since it didn't need any methods at the time before https://github.com/Zarel/Pokemon-Showdown/commit/31fe2aad7eacdb32a399cabbb594e27776535933


no, is just for proper crash logs because people submit issues with release crash logs which is useless for debug proposes.


You can download the data from here: [https://datamarket.com/data/set/22y1/annual-copper-prices-1800-1997#!ds=22y1&display=line&e=-7lz](url)
(https://datamarket.com/data/export/xls/)


- Updated app targets, Gradle compiler
- Updated app theme to Material
- Updated app icons to Material Icons


LocalNodeNetwork (XuanLuoLBL) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2152 of 2152 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.91%25-green.png)


The shell set in `passwd` should only be used to start a session, interactive or not and `runuser` is basically `exec`-ing an executable file so the shebang should work. Going to do some testing!


![](https://github.trello.services/images/mini-trello-icon.png) [Remove npx from build](https://trello.com/c/WN9DQuzZ/137-remove-npx-from-build)


![](https://github.trello.services/images/mini-trello-icon.png) [Add quokka atom plugin](https://trello.com/c/0F7rY7AC/141-add-quokka-atom-plugin)


![](https://github.trello.services/images/mini-trello-icon.png) [Update Atom  snippet file to use ES6](https://trello.com/c/MbFEmwd4/140-update-atom-snippet-file-to-use-es6)


Great have a ruleset maintainer look at it


This should be `assignmentid` instead.


LocalNodeNetwork (XuanLuoLBL) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


I know, can't they add this to the 3.3.5 branch?


ye that is good


Upper case


TeamCity Graphite :: Deploy [Build 1.0.98.0](http://build.mikeobrien.net/viewLog.html?buildId=3394&buildTypeId=Graphite_Deploy&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 2070 Build time: 00:01:48


pitched_roofs (shorowit) - x86_64-MacOS-10.10-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.png)


TeamCity Keyman :: Keyboards :: Test: Pull Requests [Build 208](http://build.palaso.org/viewLog.html?buildId=96815&buildTypeId=Keyboards_TestPullRequests) outcome was **SUCCESS**
Summary: Running Build time: 00:11:44


Not http://pnwphp.com/ ? ... `name` and `description` look wrong, too


you might want to use "gnu99" instead of "c99" (that allows gcc language extensions)


Dupe of line 15


The "Testing" tab displays all of the installed rulesets of the pico. It used to be the case that all checkboxes were checked, thus showing all of the tests specified by the `__testing` shared map (if any). This had a performance penalty, in that all rulesets were queried for `__testing` even though typically only one was actually going to be used. It also used up a lot of display space, again even though typically only one would be used.

Now, all installed ruleset rids are listed, with unchecked checkboxes. When a developer wishes to use a test defined by a ruleset, she will first check the box beside its rid. At that point in time, the UI will query the ruleset for its `__testing` map and render the query and event tests as before so that ruleset tests can be used.

So long as the developer stays on the "Testing" tab, the UI will query each ruleset at most one time. This includes any ruleset which might not have shared `__testing` to avoid multiple errors being logged


Can you provide context? I don't see that text in the list of deleted
lines in my commit.

On 2017-08-31 02:45 PM, Harold Thétiot wrote:
>
> you removed __addedMediaStream support
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/priologic/easyrtc/commit/55b3030f902f10d40eca00867c539bfc0c141aab#commitcomment-24011061>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACuUh8MjXt-njyM60fMajXyIuveBWkxYks5sdyljgaJpZM4PJanL>.
>


@wjwwood When is the allocated memory of this variable being freed?


[1682 3001](http://pci-ids.ucw.cz/read/PC/1002/6798/16823001) is another thanks


Te lo digo mas lento para que entiendas, tu enviaste la traduccion de la pagina, pero yo no queria que cambie nada. como tu mismo dijiste, "no a todos les agradara la traducción de uno" y andan cambiando. Tu fuiste el que cambio completamente mi traducción de la pagina, si ya no me había metido mas en tu traducción de Dism++, y cada quien por su lado. Tu fueite el que comenzo de nuevo con las quejas y los cambios a la pagina.


Would you recommend vgm or imf?


I will redo this comment on the PR for better visibility...


Ya que con voz no tendia ningun conflicto por que ya no cambie nada más de tu traducción de Dism++, y tu fuiste el primero en incumplir tu palabra sobre los cambios, "no a todos les agradara la traducción de uno".
Espero que ahora lo comprendas.


Correct!  Changes made.


I believe I was just copying the README at the time: https://github.com/thelastpickle/cassandra-reaper/tree/386892c853e6ba7fab4f7296dec3bdaf42539bdb#running-reaper.

Adding the bin/cassandra-reaper script and using that would also wfm.


following instructions here: https://github.com/github/linguist#overrides


_interests you **the** most_?


What the actual fuck is this?


LocalNodeNetwork (XuanLuoLBL) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2779 of 2795 tests passed, 0 test warnings)

 * 13 tests had: AUD diffs.
 * 12 tests had: BND diffs.
 * 1 test had: ESO small diffs.
 * 1 test had: EIO diffs.
 * 1 test had: ESO big diffs.
 * 1 test had: Table big diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.43%25-yellow.svg)


@devoncarew @lukechurch – it'd be good to deploy – just to get this link out...


![](https://github.trello.services/images/mini-trello-icon.png) [Assets Management](https://trello.com/c/h3uoqDVY/16-assets-management)


@killerwife i let you merge this on TBC because i dont know if you pushed db part


Sorry, I missed that.


Stfu

On Aug 31, 2017 5:33 PM, "TheGamingChief" <notifications@github.com> wrote:

> What the actual fuck is this?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/TheGamingChief/OurLifeRPG/commit/269b90fef5dddbd1f8bd6184de19c35baa98c84e#commitcomment-24011993>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ANPBrEVybPKIR4CVUpHaqxiJBUr4i2kpks5sdzTEgaJpZM4PJHAr>
> .
>


Ok, Ill get on it asap.


Is this worth? Did you notes any major performance increasement?


OutputUnitsRefactor (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


kotti de chreck shiro


Naw dude, what are these memes?


OutputUnitsRefactor (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2789 of 2789 tests passed, 24 test warnings)

Messages:

 * 24 tests had: RDD diffs.

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


#6282-SimHVAC-max-iteration-warnings-caused-by-CoilHeatingGasMultiStage (lgu1234) - i386-Windows-7-VisualStudio-14: OK (2749 of 2749 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


:D


Apparently I formatted the config..


why don't we just use this target?


Clearly the best commit ever made


This should fix #2


What is difference after your change?


I think may be you just need to import the DAO files instead of all files as in the DAO file, there is also import of the ticket and factory file?


The following doc(s) have been deployed to the [ilovelampr](https://ilovelampr-static-docs.pantheonsite.io/docs) Multidev environment:
- [source/_partials/redirects.twig](https://github.com/pantheon-systems/documentation/commit/9dd5c1fa341088f866a700a7812808d4fd36636d/source/_partials/redirects.twig)


Removed redundant TTS.isSpeaking check before speaking, since QUEUE_FLUSH handles this.

Segmented lengthy onCreate method into segments handling [listeners,tts,controls] events and inits.

Corrected 0 errors for pitch and speech rate:
- Pitch range is now [0.1-2.0]
- Speech rate is now [0.1-3.0]


It was my bad. I wasn't clear that we needed the search input on the dialog box. Actually, I didn't realize it until testing.


this is good.


very funny


it has the dependency which will eventually generate a sig


this may be not correct. Remember the ticketId of adhocTicket is a string starting with "A".
I think it just need
`this.adhocTicketDAO.recordAdhocTicketEntry(ticketId);`
As it is not defined in the AdhocTicketDAO, maybe you still need
`numberOfCarsParked ++;`


Right now the behavior is hardcoded that the websocket thread is killed when a capacity restricted queue gets full.
But wouldn't it be nice to parameterize what happens on a full queue?
`BiConsumer<BlockingQueue, WebSocketClient>` or maybe something less fancy.
Then you can still bound the queue, so give up if the disconnected shards are over half the total shards, but actually pass in how it should give up.


so there are still calls to pylab everywhere, but I switched the imports at the beginning to `numpy` and `matplotlib.pyplot`. Need to go through and fix this.


@L0FKA

This breaks on El Capitan for me:
```shell
$ readlink -f /Applications/RocksmithCustomSongToolkit.app/
readlink: illegal option -- f
usage: readlink [-n] [file ...]
```


Similar as recordEntry comment?


you might have some early convergence issues if the crossover code defaults to the genome with the greatest fitness


You are a wonderful person and I hope you have a good day


I think the previous version is correct. The new one is the same as the InUse method.


Wow, the types really were quite broken!


This is the same as the Valid method


![](https://github.trello.services/images/mini-trello-icon.png) [Make email address and phone non-required in digital VRN](https://trello.com/c/Smq0ElaZ/120-make-email-address-and-phone-non-required-in-digital-vrn)


To nie działa, bo chwilę wcześniej przypisujesz wartość albo []. Musiałoby być `this.state.employees === null`


this method may not need here, as it is already defined in the seasonTicket file


Interesting. I just tested this myself just now with the option disabled and enabled (Key Down) and both ways it works as its supposed to. Still have issues?


This is, unfortunately, incorrect.  These are not floats, it is supposed to be exactly 1/1000.


OutputUnitsRefactor (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1535 of 1535 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-38.35%25-green.svg)


Similarly, because this is a scaling factor for units, it should be 1000, not 1000.0.

Downstream code should be able to deal with this, rather than changing the model.


[Jenkins vg tests](http://jenkins.cgcloud.info/job/vg/419/) complete for merge to master.  View the [full report here](http://cgl-pipeline-inputs.s3.amazonaws.com/vg_cgl/vg_ci/jenkins_reports/branch/master/index.html).

9 tests passed, 0 tests failed and 10 tests skipped in 10707 seconds

Tests produced 3091 warnings. 3084 were for lower-than-expected alignment scores


OutputUnitsRefactor (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


This is ever so slightly different (because this is really probabilities).  Really, it should be done via an 'invert' function.  But 1.0 is still not right.


This actually should be `propKey in target` since some internal properties of `QueryBuilder` may be undefined at some point.


I believe you had to change the `this.onResize` usages in lifecycle Hooks as well: https://github.com/storybooks/storybook/blob/master/lib/ui/src/modules/ui/components/layout/index.js#L137-L143


TeamCity Keyman :: Keyboards :: Test: Pull Requests [Build 209](http://build.palaso.org/viewLog.html?buildId=96816&buildTypeId=Keyboards_TestPullRequests) outcome was **SUCCESS**
Summary: Running Build time: 00:11:21


This seems unnecessary.  You're probably using an = where pattern matching would not have incurred the need for `Eq`.  It's not so bad, but it does point to a bad habit.


In this case it worth adding the missing enum value

MB_INFO_ELF_SHDR        = 0x020,


The following doc(s) have been deployed to the [ilovelampr](https://ilovelampr-static-docs.pantheonsite.io/docs) Multidev environment:
- [source/_partials/redirects.twig](https://github.com/pantheon-systems/documentation/commit/9dd5c1fa341088f866a700a7812808d4fd36636d/source/_partials/redirects.twig)


@chriswhong (cc @allthesignals), when we fixed these barLabels, looks like I accidentally committed some layout experimentation I was doing at the top of the indicators. It's not big deal, but there are now placeholders in `develop` for the population pyramid and density subsection.


^ relates to #280 and #278.


そうですね! 実際のところ、僕も CI がパスするまでマージするのを待つことがほとんどなので、master ブランチを保護した方が良さそうです🤔


run `script/bump-version.py patch` to bump patch version. It automatically creates a commit


@L0FKA Also, `--no-x86-stack-align` breaks Mono 5.2 on El Capitan for me...
- The `--arch32` is needed
- Either `--optimize=all,-abcrem,-aot,-precomp,-deadce` or `--optimize=sse2,simd,loop,inline` both work
- `--runtime=v4.0.30319` works with or without
- ..but `--no-x86-stack-align` gives an instant segfault.


-1
I fixed win64 but broke macosx64 and linux64...
All those nearly equal platforms files with random int/sqInt types is a calamity


Woo, no more sudo?


お、設定しようと思いましたが、既に設定されているようですね ;)
https://github.com/coderdojo-japan/dojopaas/settings/branches/master


Updating the config as opposed to letting the SDK detect the environment variables results in the following error:


Puzzle `5-15364469` disappeared in [`drop/facade.go`](https://github.com/fxnn/deadbox/blob/master/drop/facade.go), that's why I closed #17.


Puzzle `12-61f995b8` disappeared in [`it/request_test.go`](https://github.com/fxnn/deadbox/blob/master/it/request_test.go), that's why I closed #22.


@jannes-m I've fixed some broken references, however the [@burrough_principles_2015] reference is still missing. Can you fix that?


And why you set them works?


This should be in the else part?


#6282-SimHVAC-max-iteration-warnings-caused-by-CoilHeatingGasMultiStage (lgu1234) - Win64-Windows-7-VisualStudio-14: OK (2749 of 2749 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Also seems like this is not the place where the error is logged


![](https://github.trello.services/images/mini-trello-icon.png) [Tweak subpoena copy to tell people to ignore subpoenas for trial](https://trello.com/c/qCn4j8wO/119-tweak-subpoena-copy-to-tell-people-to-ignore-subpoenas-for-trial)


Cool! Rather than generate repetitive Nix code though, I'd rather factor out the common stuff. The updater would still be good since the hashes and versions would need to be determined, but it always makes me uneasy to codegen repetitive code in a language that can express the repetition natively.


Invalidated PayPal Account keys. Sandbox practice keys.


Invalidated Coinbase keys used for practice


Can we add the same at 2 more places that log "More than one result"


Invalidated practice keys.


For markdown:
1. Add two space at the end of a line to start a new line
2. ~~strike~~ add two ~~ on the sides of words to show the delete line


Preguntar si es necesario chequear si la promo existe en el menú


add mouseFilter and wheelFilter (#3399)

Demo: quicktests | fiddle


There were the following issues with your Pull Request

  * A "License" and a "Signed-off-by" trailers are required. See [the guidelines about this](https://github.com/ipfs/community/blob/master/contribution-guidelines.md#a-license-and-a-signed-off-by-trailers-are-required)

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
`git commit --amend` can often help you quickly improve the commit message.
[Guidelines](https://github.com/ipfs/community/blob/master/contribution-guidelines.md#commit-messages) and [a script](https://github.com/ipfs/community/blob/master/dev/hooks/setup_commit_msg_hook.sh) are available to help in the long run.
Your feedback on GitCop is welcome on [this issue](https://github.com/ipfs/infrastructure/issues/23).

---
This message was auto-generated by https://gitcop.com


DELETE


Just curious, not a big deal for me but shouldn't it be `<literal>true</literal>` instead of just `true` ?


Wewt


Prepare release table-1.24.1 (#1521)

Preview: documentation
Coverage: core | datetime


Wha?


It's not about necessity, it's about readability. A class says "this is a class". A function does not say "this is a class". Do you see the difference?


OutputUnitsRefactor (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2146 of 2146 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.9%25-green.png)


k


I missed this in my review, this actually breaks documented functionality because it reverses the priority order. Adding a PR to fix


complete este campo


wow


resolves #78


GopherCI found **1** issue in the last **2** commits, see: https://gci.gopherci.io/analysis/1003


#6282-SimHVAC-max-iteration-warnings-caused-by-CoilHeatingGasMultiStage (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2789 of 2789 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


address #77


addresses #77


converted to Knockout, not Postal


I can get behind that.


addresses #78


[Jenkins vg tests](http://jenkins.cgcloud.info/job/vg/420/) complete for merge to master.  View the [full report here](http://cgl-pipeline-inputs.s3.amazonaws.com/vg_cgl/vg_ci/jenkins_reports/branch/master/index.html).

9 tests passed, 0 tests failed and 10 tests skipped in 10907 seconds

Tests produced 4771 warnings. 4768 were for lower-than-expected alignment scores


findAndModify requires shard key, for update oplog with _id as the  the query key and without shard key, findAndModify will fail. Also the main difference between findAndModify & update is the return value. Currently the return value is not being used hence changed to use update_one instead.


Remove


add /$ref


So glad I found this guy on youtube! Hope I may find all the files here.


#6282-SimHVAC-max-iteration-warnings-caused-by-CoilHeatingGasMultiStage (lgu1234) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


// esto es una inclusión muy importante


@AlumiuN can you merge this commit into master branch? I think the uppercase letters for files 8-characters or less are some of kind bug Andy introduced, Wolf4SDL v1.7 and revision 262 show them the same way as @linuxwolf6 and the Dev C++ project file still shows them that way too

![screenshot](https://user-images.githubusercontent.com/24834341/29950006-f1b80bc4-8e86-11e7-98ea-c9fd42c4a7dc.png)


Created multidev environment [build-tools-707#ci-2](https://dashboard.pantheon.io/sites/e811bfec-2485-451a-88e8-983c4de3fd92#ci-2).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-2-build-tools-707.pantheonsite.io/)


没看懂，为啥要强转了boolean？


No, my use of the address was based on the assumption that msg.sender could not be spoofed.  That is, it's as much a unique identifier as any given password would be.  If that's not the case, then I assume -- and please confirm this -- that the logic for both passwords should be identical and participant_hash_a should be generated and treated in the same way as participant_hash_b.


No me vengas con que no tengo palabra, "no toque nada de tu traducción". Y tu dices que comente antes, pues te digo que comente de los cambios que hicieste en la traducción de la pagina.


@shivamvinsol
ID and Class are used for styling purpose in CCS file.
Add `data-hook` attribute here and make it a habit to fetch DOM elements in JS file using data attribute only.


四.实现图片懒加载
懒加载的原理：页面中的img元素，如果没有src属性，浏览器就不会发出请求去下载图片，只有通过javascript设置了图片路径，浏览器才会发送请求。
懒加载的原理就是先在页面中把所有的图片统一使用一张占位图进行占位，把正真的路径存在元素的“data-url”,当到了可视区域，再把真正的路径放在src里面


@shivamvinsol Fetch elements using `data` attribute.


TeamCity Keyman :: Keyman Desktop and Keyman Developer :: Test: Pull Requests [Build 10.255.53.261](http://build.palaso.org/viewLog.html?buildId=96764&buildTypeId=KeymanDesktop_TestPullRequests) is now running


TeamCity Keyman :: Keyman iOS :: Test:  Pull Requests [Build 10.255.60](http://build.palaso.org/viewLog.html?buildId=96766&buildTypeId=Keyman_iOS_TestPullRequests) is now running


missing trailing space


See above re: assumption that msg.sender cannot be spoofed.


TeamCity Keyman :: Keyman Mac :: Test: Pull Requests [Build 10.255.261](http://build.palaso.org/viewLog.html?buildId=96767&buildTypeId=Keyman_KeymanMac_PullRequests) outcome was **SUCCESS**
Summary: Running Build time: 00:01:41


TeamCity Keyman :: Keyman iOS :: Test:  Pull Requests [Build 10.255.60](http://build.palaso.org/viewLog.html?buildId=96766&buildTypeId=Keyman_iOS_TestPullRequests) outcome was **SUCCESS**
Summary: Running Build time: 00:02:17


@shivamvinsol We can avoid if else here. Refactor this logic.


Why didn't you just use the fork I used in dex?


@shivamvinsol We can avoid the use of `parseInt` here.


eliminar el nombre


@shivamvinsol This logic can be refactored


TeamCity Keyman :: Keymanweb :: Test: Pull Requests [Build 10.0.63.pull.261](http://build.palaso.org/viewLog.html?buildId=96765&buildTypeId=Keymanweb_TestPullRequests) outcome was **SUCCESS**
Summary: Running Build time: 00:04:36


Pretty sure I have this all figured out. It just comes down on how to implement this effectively. First stage will just be 2-Player support, which is not much different from what GBE+ does now, but eventually 3 and 4 players will be possible once the network interface in GBE+ is re-hauled.


I just checked in a copy test: https://github.com/gilbertchen/duplicacy/commit/37ebbc4736095a3c66e5d885494436988742bca5

There are skipped messages in the output:
```
Source storage set to /Users/chgang/DUPLICACY_TEST_ZONE/TEST_STORAGE
Destination storage set to /Users/chgang/DUPLICACY_TEST_ZONE/SECONDARY_STORAGE
Snapshot integration-tests at revision 1 already exists in the destination storage
Chunk a0d6612111e334644f8ca1d952b43cd195f40a88705d37b2d71c59240b680377 (1/45) exists in the destination
Chunk b6838c5edc9da3dc70d9e2b9c294ea8442aeb88feca8955718984e7619a86223 (2/45) exists in the destination
Copied chunk 0afd310f283a311bf1d5f46763fb9493179df4685ea79d96243a27febb2218fd (3/45)
Copied chunk e1a220903f449e17689688e13815dcd164242e4a32428a8d5ead1f12114b6201 (4/45)
Copied chunk fe64a88a67deb60ea92f16fc62ecab8264aa9fc563d34bf05ba11c59409ba6de (5/45)
Copied chunk 723267d63b888c1e623e416b4c6b7a632e869e1d3519899051cddd17bb62458e (6/45)
Copied chunk 8203971202b5dcbedf64fd9acde67fa6ae3613b872430f269693a6d0a325ca3b (7/45)
Copied chunk fb72836d0f7785afbd91947f725ed2c07cb19ecb1abb3e4e8a82e18ef0b7e27a (8/45)
Chunk b01f04f6311c692312eb29e962e0553e3cb94c5a4a8604a3cb9b8ed6c535ae0e (9/45) exists in the destination
Chunk a580fe6da1c0a587dc594218478c17d5797ea87faaaf0255c3cd2981d724f9ec (10/45) exists in the destination
Chunk ab5b3708bd8ebc5322374153da97853ba0f1fad7877d4aaede78d9ab5c52d6b6 (11/45) exists in the destination
Chunk 1524f5ea0fc30fed5dc1ce11c5a5be79a31957372bbff540dd12d26b6f7a7dd6 (12/45) exists in the destination
Copied chunk cff7615353b1159fb7df88755ae525f222eb58e99bf5050bdc8481813a80b670 (13/45)
Copied chunk 498c6e048870e9a79ae821f730e1b6d380e9a89acf0dfc46d637c22a97e9cede (14/45)
Copied chunk 2bc722ec668adbf3b902ba6327cb8d819463c3d2220078ad8ce3b5d7e8b23ac4 (15/45)
Chunk a0ca51b8decc1096b0fdff1d572e0f0caca5644c313f8c4be0cea6e8e3a0b8f5 (16/45) exists in the destination
Copied chunk 4dd946125967b92e89fb5af3ff1418c9a6c912585f0b3cda50de08ab5a7162f0 (17/45)
Copied chunk e1b136a260a70b4bd98b5ab5171560d95ef85ec0bd9921fba40a2cd6bf798844 (18/45)
Copied chunk a8e660707087cdf7954cc3aec4b07041b12f5d0c9c5f88460ea0d0a5f558c247 (19/45)
Chunk 25629369a7a83ee8d456d1f3a0074c9aab249f013683ccaf1f3fb8a16f916539 (20/45) exists in the destination
Copied chunk a8f4b9ea69b0eb7bbea2039dc6339cfd9e16b9dade43f68b414999f49b4b840c (21/45)
Copied chunk 3a1c55c81d6c889dcb91bdaa9d1159c410b288067476335ff23a3e91752e14b1 (22/45)
Copied chunk 9a73094e4530d0f5c48e05e18521e040fa6243b6880ee47440bd6ac50d39a924 (23/45)
Copied chunk 231a974c6d9f72173bbd9df585995194a6d918c1c0a85535fa0637d60054a4bd (24/45)
Copied chunk 67b60a55fad8bf425538a2b29dea5f26f692a647cb6693dcb21c46bcebe60c75 (25/45)
Copied chunk e06b779580667f8ef1d6aafc00a2f76c67b31c1150e7385b152436c6c1b9460d (26/45)
Copied chunk a6404f38d636ee9c2029b74847af49ad13fa6478eff79b842dc5cdf65a1315f4 (27/45)
Chunk 64897d4a951242b2025760f362de9c78324851ad98578e95e9a95c77f096a3c7 (28/45) exists in the destination
Copied chunk 97b54a1a9b432858022a4899779dc83db66a8efa571b3f7c9d79a75022b5a565 (29/45)
Copied chunk e869ecb1dfe4ebab1d4c239d7b2a6d531030595e427884e464daf0fef82bc159 (30/45)
Copied chunk 0f067589938eedbe826f6a177724e131f9cfad7866be5c675ec90663425909f0 (31/45)
Copied chunk c117b1764843aec9a6b94dae2bf79b25dfa449bb6535168328051d4723fdf710 (32/45)
Chunk 89811fffe3832e500b5c3045a723258a714ee5a111e73b3220b99f0a591dca6a (33/45) exists in the destination
Chunk 60550aba98b462b65fd8bbd11dc9ce1053f404e8d2b321c8717798632e4834b9 (34/45) exists in the destination
Copied chunk aceb64b02070bcd9cd7feac8bca81e2d40eca234d1b09e75ed4a9baebf919a44 (35/45)
Copied chunk 1dc1bb433c8dad2d49e75aba5d09cd0af117e83cd0d0a15f351cc2e1084963c8 (36/45)
Chunk 3d50407d1b873baaed99ee15879784ee39355f3fc19388f983690ee2dfac2991 (37/45) exists in the destination
Chunk 43ec4eb74f439b6f52137de53e17f4433c82159b96465482932e91037d9b0981 (38/45) exists in the destination
Copied chunk 9a0ed5bec19d677e36ce934b8013bf1c0ef61ebf724a260595bd792395bd35e9 (39/45)
Copied chunk be25a45c05871c5cb21007d223ed4ae35f450814ba3cf24a6afb132337f1e85e (40/45)
Copied chunk ee86fccae11700b6ab96caf91c7da4504ce204aac6bdfc73eada668063c1655e (41/45)
Copied chunk f49a8c668d28669c01ea20a1067dd8563d7ce8e8498e606465c4a06c5bbe1cda (42/45)
Copied chunk ea86905d11b4269e74c6eca744bd9c3dfa032f80dfffa31e7c791ed3e5f1a516 (43/45)
Copied chunk 38172e218c15c7c7baff5e286ba034478851890c20447744b5d4402e3d18d3d1 (44/45)
Copied chunk 3dca22833c0493b65e295e630c4ec645f7eaf63eb823ff1152ca7f8f951f5859 (45/45)
Copied snapshot integration-tests at revision 2

```


ResetNodeDataEarlier (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2141 of 2141 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.89%25-green.png)


Typo in query


ResetNodeDataEarlier (mjwitte) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


使用create-react-app来快速搭建开发环境


Would it be possible to add an example of the component under test, in this scenario? I'm still getting errors using this approach, and the error message is just cryptic enough that I can't figure out what's going wrong:
```
Assertion Failed: You specified a quoteless path, `undefined`, to the {{action}} helper which did not resolve to an action name (a string). Perhaps you meant to use a quoted actionName? (e.g. {{action "undefined"}}).```


TeamCity Keyman :: Keyman Desktop and Keyman Developer :: Test: Pull Requests [Build 10.255.53.261](http://build.palaso.org/viewLog.html?buildId=96764&buildTypeId=KeymanDesktop_TestPullRequests) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:14:13


@shivamvinsol Store the new `div` in an instance variable. Then you won't need to return anything from this method.


y


TeamCity Keyman :: Keyman Android :: Test: Pull Requests [Build 10.0.44.pull.261](http://build.palaso.org/viewLog.html?buildId=96768&buildTypeId=KeymanAndroid_TestPullRequests) outcome was **SUCCESS**
Summary: Running Build time: 00:03:27


Y sobre mi nick, por favor tu crees que a las personas comunes que la utilizan Dism++ les interezara algo sobre quienes estan el proyecto. Pero oviamente se daran cuenta de ti ya que tu pusiste tu marca de agua en Dism++.


ddd


@shivamvinsol Variable name should be `options`.


LocalNodeNetwork (XuanLuoLBL) - Win64-Windows-7-VisualStudio-14: OK (2753 of 2754 tests passed, 0 test warnings)

Failures:

EnergyPlusFixture Test Summary
 * Passed: 531
 * Failed: 1

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.96%25-yellow.png)


记录日志


Why using the template here?


v-if="errors && errors.length"


这个文件是不是忘了加进来。。


Defensive checks needed


Good ideas, thanks @xavierlepretre !


Because we shouldn't be trusting branches outside of our ecosystem, if it's removed in the future our builds will break


Antes te aceptaba que te hayas molestado sobre tu traducción del programa Dism++, no tengo nada que decir.
¿Pero sobre la pagina no entiendo por que?, ya que la traduccion de la pagina la hice "yo", ¿o toque tu traduccion de Dims++? pues no.
Y para tu gusto no aceptaron todos los cambios que les propuse.


nitpick: 这里有个比较增加阅读性的方法就是先处理不满足的情况，所以如果
```
if not text:
     return []
````
后面所有的就不用缩进了


Please make a fork of this build because it is the last functional build for Tenchu Z


I don't think there's anything wrong with the method in principle, but the way it was implemented was sharing the same underlying array which is a problem.  The deprecation is to allow it to be removed and a method that copies the array to be introduced in its place.  (It's fine to have it as part of a builder for the immutable bitset, though.)


is it working?


develop (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2162 of 2162 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


来了来啦啊 啊啊啊 啊啊啊


Зачем еще один массив?


Комментарии с мусорным кодом надо убрать


Agreed.  This is helpful functionality to have.


Этот метод нам не нужен. Есть массив `@trains`, который содержит список поездов - просто сделай геттер для него. Как его показать пользователю = задача вызывающего кода, а не этого класса.


Зачем?


Зачем еще сюда дублировать добавление?


Не нужно никаких puts-ов в этом классе


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170831-033633 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170831-033633") to [prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "ibm:yp:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170831-033639 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170831-033639") to [prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "ibm:yp:us-south:user@ibm.com:prod"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-Prod-20170831-033644 "deployed-2-env-Prod-20170831-033644") to [Prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "There was a problem retrieving the space name"), including this commit


Bluemix toolchain: An unknown tool deployed [testRepo-Traceability](https://github.com/idsdev/testRepo-Traceability/releases/tag/deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170831-033654 "deployed-2-env-ibm-yp-us-south-user-ibm.com-prod-20170831-033654") to [prod](https://console.bluemix.net/apps/6e3bc311-c83d-4cd1-a457-99d9a5f20f19?env_id=ibm:yp:us-south "ibm:yp:us-south:user@ibm.com:prod"), including this commit


Избавься от этого массива, тогда не придется из двух мест удалять поезда


develop (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


Сделай метод более гибким - пусть он принимает параметр "тип поездов" и возвращает список всех поездов с таким типом. А вызывающий код уже сможет и кол-во получить, и все что угодно.Для этого тебе поможет метод [select](http://devdocs.io/ruby~2.4/array#method-i-select)


А это что такое?


So if I store uint constant fee = msg.value * 0.15 at the top of the file, then I can just write:

function () payable {
    if (owner.transfer(fee)) {
       LogCommission(fee);
    }
}

correct?


Executing the daily benchmark build, I will reply here when finished:

@nanosoldier `runbenchmarks(ALL, isdaily = true)`


@miya0001 このコミットは、「もらったサーバーは (同じCoderDojoコミュニティとはいえ) 違う団体に勝手に譲渡してよい」という先行事例になるので、危険な香りがします💦 個人的には revert したいです 🙏


Это усложнение. Все станции можно хранить в одном массиве. Первый элемент будет начальной станцией, последний - конечный. Главное не давать их изменить (по условиям они задаются только в конструкторе) - нельзя вставлять новые станции на 1ю/последнюю позиции и нельзя удалять 1ю/последнюю станцию


unlink log file ... does this affect the other logs we do ?


@aCandidMind I have a stale PR for making serialization a first-class citizen #21496 but generally discussion of how serializations concerns should hook into renderings and how an 'ActionSerializer' would look have stalled.

Regarding what to use:

Speaking as a maintainer, AMS is currently on life support. If you don't need JSON:API support. 0.8 or 0.9 might work for you. If you need JSON:API, you should probably look at jsonapi-rb (and the related [jsonapi-suite](https://jsonapi-suite.github.io/jsonapi_suite/)) or JSONAPI::Resources. I have a [dev branch of AMS which is interesting](https://github.com/rails-api/active_model_serializers/blob/13340790c5c162718a6a4fe2f8aa542f8ec3b23e/lib/ams/serializer.rb) and used in production at previous job, and have discussed it in the abstract with Rafael and Sam, but it seems to be the wrong abstraction. Myself, I'm currently looking at what people like about ember-data's architecture, which has commonalities with all of the above.

So, the issues Rails needs to tackle, IMHO:

- Highlight 'that `render json: foo, some_option: :some_value` is intended to be render `application/json` (or `content_type: application/vnd.whatever+json` equivalent) as a result of content negotiation.
  - i.e. most Rails devs consider 'render json: foo` as *the* way to render json, and don't add [renderers by content type ](http://www.benjaminfleischer.com/journey-of-a-media-type-in-rails-part-1)
  - [essentially calls](http://www.benjaminfleischer.com/2015/06/02/understanding-rails-model-serializers/) `render_with_renderer_json(foo, some_option: :some_value)`, which is a method created by `ActionController::Renderers.add :json do .... end`
  - That it makes sense for each mime type, JSON:API, HAL, Siren, etc. to [have their own renderer and parser](https://github.com/rails/rails/pull/23712).
  - That `responders` addressed this issue in an unsatisfactory way and is a useful reference for the problem domain
  - That we may want to encourage devs to stop calling a naked `render json: foo`, and instead rely on content negotiation like `respond_to do |format| format.json { render json: foo } end` which will [return a 415, unsupported media type](https://github.com/rails/rails/pull/26632) if either the request does not have a JSON request header or the route does not configure a 'format'.
- That the request response cycle may include not only rendering concerns (serialization, content type) but routing, e.g. [in JSON:API](https://github.com/rails-api/active_model_serializers/pull/1476/files)
- How much of this should just be in the guides versus new features
- If there's a place for an 'ActionSerializer' like 'ActiveJob', which has a common interface `has_one`, `has_many` etc. and delegates to the actual, configured serializer library
- How much of [`ActiveModel::Serialization`](https://github.com/rails/rails/blob/5-0-stable/activemodel/lib/active_model/serialization.rb) and [`ActiveModel::Serializers::JSON`](https://github.com/rails/rails/blob/5-0-stable/activemodel/lib/active_model/serializers/json.rb) belong in Rails. (See some [summary of the early history of ActiveModel::Serializers](https://github.com/rails-api/active_model_serializers/blob/954cc174fcd04714a4ec7371ef35e335bfa39412/CHANGELOG-prehistory.md))

Apologies to all if my comment spurs more discussion (which I began 😳) on this commit.  Perhaps more discussion is warranted in basecamp?


Oh wow, awesome, had no idea!


Странное название. Чем плохо просто `@stations`?


Метод `route` в классе Route - масло масляное. Список станций и должен называться `stations`.


Не надо никаких puts-ов. Обычного `attr_reader` хватит за глаза


41% faster faster after this change.

A job changed from **04:47:37** to **02:48:16** .


Называй методы понятно, без сокращений.
Я бы рекомендовал всегда вставлять станции перед конечной. Иначе пользователь этого кода может изменить начальную/конечную станции


Сюда должна станция приходить, а не индекс.


Зачем это?


Why using template tag here?


Давай пока обойдемся без проверок и исключений. Это далее в курсе будет


Better condition: v-if="errors && errors.length"


Что за `elsif` без условия?


Зачем это записывать в инстанс переменную?


Если скорость 0 и в метод придет -10, то скорость станет отрицательной


anyone getting this error?
input/drivers_hid/libusb_hid.c:29:10: fatal error: ../input_config.h: No such file or directory
 #include "../input_config.h"
          ^~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:157: obj-unix/input/drivers_hid/libusb_hid.o] Error 1


It seems that the argument name of `rnorm()` are still incorrect. Should not it be `rnorm(sd = 1)`? (not `rnorm(sigma = 1)`)


Никаких puts-ов. Достаточно геттера (attr_reader) для скорости


solo he colaborado.


Pues de lo que dices retoques, antes que tu te metieras en la "correción" de la pagina, yo havia dejado con punto al final en todas las partes de las caracteristicas.


Я б рекомендовал изменение скорости объединить в один метод `change_speed`. Если туда передали положительное значение - это ускорение, иначе - замедление


Никаких puts-ов. Достаточно геттера (attr_reader) для числа вагонов


ResetNodeDataEarlier (mjwitte) - i386-Windows-7-VisualStudio-14: OK (2745 of 2748 tests passed, 4 test warnings)

Messages:

 * 6 tests had: EIO diffs.
 * 4 tests had: ESO small diffs.
 * 3 tests had: Table small diffs.
 * 3 tests had: ERR diffs.
 * 3 tests had: ESO big diffs.
 * 1 test had: AUD diffs.
 * 1 test had: Table big diffs.
 * 2 tests had: MTR small diffs.
 * 1 test had: MTR big diffs.

Failures:

regression Test Summary
 * Passed: 603
 * Failed: 3

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.png)


Hi, This is my first comment!!!


Повсюду ветки без условий, зачем так писать? Если нет условия, то просто `else` пишется


А если сейчас у поезда 0 вагонов?


Непонятное название переменной


Не надо никаких puts-ов


Мы же храним позицию (индекс) станции, зачем еще саму станцию хранить?


Зачем это второй раз делать?


Probbably


Когда поезд помещается на станцию, его нужно записать в массив поездов этой станции (`train_arrives`)


Yup


А если мы на конечной станции и не можем вперед двигаться?


А если мы на начальной станции?


Это тоже движение поезда, так что [коммент актуален](https://github.com/Kristina-D/RubySamurai/commit/640a94f462abc908a258d52c4446bf595ce873ee#commitcomment-23991390)


Нам нужно 3 метода - текущая станция, предыдущая и следующая. Они должны просто возвращать объекты-станции (или nil, если они недоступны) без всякого вывода на экран


Cool stuff!


Here is an example of an inline comment.


@paranoidjk 排除空字符串


hhhh ,わたしぁ　我来了


Class description?


@jauniusb @gadge should i feel guilty of leaving a single unit-test related variable outside that unit test scope in jasmine ? ( otherwise tests fail as storeRandom is 'undefined').
Any nicer ways to handle this ? ( tried beforeAll, beforeEach - but no success )


程式內是對的，comment打錯了
10.(綠燈)PotterShoppingCart價格計算測試_第一二三集買4本_第四五集買2本_最優惠價格為1290
應為
10.(綠燈)PotterShoppingCart價格計算測試_第一二三集買4本_第四五集買2本_最優惠價格為1280


Если метод не содержит никаких изменений, то можно его просто не писать - вызовется метод родителя. Это замечание актуально везде, где тело метода содержит только `super`


1024 is too small?


Hi

I did some study on timezone and jdbc based on the postgresql jdbc driver. There are TIMESTAMP, TIMESTAMPTZ, TIME, TIMETZ, DATE types in SQL land. Date doesn’t have a `with time zone` type. When time related field is stored with a sql type which aware TZ info, It will correctly retrieved, JDBC driver will ignore the `cal` parameter, and use TZ stored in database to construct the return value.

When set parameters, jdbc driver use the `cal`’s timezone to format the milliseconds(time in UTC milliseconds from the epoch) into string, pass the string
to database, database will convert that string and store in a internal format.

When get from result set, jdbc driver use the `cal`s timezone to create an calendar, extract every part from string representation of the timestamp, set every part to the calendar, then use the milliseconds to create a Timestamp.

So If we want the database store the timestamp in another TZ, we should use a timezone different than the default timezone used by java. I think only when database used by other system use another timezone require this setting, for normal systems we should set java and database use same timezone.

According to this behavior, I think java.sql.Time should use same approach as Timestamp.

For java.sql.Date it will be special.
When pass string representation to database, java.sql.Time only pass the time part, and java.sql.Date only pass the date part.
Because it only pass the date part, when pass a cal other then the default java time zone to jdbc, the date part of string representation may shift to other day. That will be stored in database.
When get from result set, it will use midnight of passed in `cal` to create timestamp, then convert the milliseconds to a java.sql.Date in default java timezone.
So it is correct, because lack of time part, we should always use default java timezone to process java.sql.Date.

I am thinking another question. If the user’s timezone differ than the default java timezone, what will happen when user input the date in browser,
If date parsed in the user's timezone when pass to jdbc it will convert to default java timezone, which can cause day shift. I haven’t test if this behavior exists.

—
Yao

Moqui doesn’t use TZ aware sql type. For
> 在 2017年8月30日，下午12:49，David E. Jones <notifications@github.com> 写道：
>
> BTW, I haven't test java.sql.Time fields to see if they need to be handled the same way, a change may be needed for them too. So far we don't use those much at all in the current apps or in mantle-udm so it hasn't been a priority to look into that.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.
>


RN 允许  `<View>false</View>` ?


習慣性從測試程式來產生這邊的方法簽章的殼，並直接保留原本內容的 throw new NotImplementationException() 即可


程式內是對的，comment打錯了
10.(紅燈)PotterShoppingCart價格計算測試_第一二三集買4本_第四五集買2本_最優惠價格為1290
應為
10.(紅燈)PotterShoppingCart價格計算測試_第一二三集買4本_第四五集買2本_最優惠價格為1280


前面只是个判断，放在 dom 去之后就不是 boolean 值了


Make the keys constant before migrating to Gson


Теперь метод `add_vagon` почему-то не принимает параметров. И проверку нужно делать исходя из сравнения типа поезда и типа вагона, а у тебя просто проверяется тип поезда


i merged it boi


not working in L 5.4 will test 5.5 and let you know


Make the variables final. Have a GalleryItemBuilder to instantiate GalleryItem. Get rid of the set methods


可以直接將 `.Where(predicate).Count()` 併成 `.Count(predicate)`


develop (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1534 of 1534 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-38.33%25-green.png)


我理解是这样
```js
var a = '';
var b = 'b';

asset((a && b) === a)
asset((!!a && b) === false)
```


XD 誤會一場, 其實不是這樣子寫的, 已經在下一版改了.....但寫法有點糟~


Нет смысла принимать тип поезда снаружи. У тебя сам класс и отражает тип поезда. Так что либо жестко прописывать тут тип (`@type = :cargo`, в пассажирском по аналогии), либо вообще сделать тип виртаульным атрибутом (т.е. просто методом, который вернет `:cargo`)


I like it. Much better than the one I made.
Looking at the font file, I can see that "Invite" and "Kick" are different from the ones on the picture. In my opinion, those on the picture look better. I also noticed that you included an alternative for "Whisper", using two speech bubble, I like that one too.

Overall amazing, but based on the screenshot you posted at [#75](https://github.com/lemasato/POE-Trades-Companion/issues/75#issuecomment-326144661), it wouldn't look too good on the White skin.
Maybe it would fit better with an alternative version that only use outlines.
On the Path of Exile skin, it looks truly awesome.


這一步已經足以將 discount 重構出來了，越晚做這件事，過程中的 duplicate 就會越多。


This workaround is excellent.

It generates a file like https://gist.github.com/tomfitzhenry/a3ff7b4cc4ec20ba68848682fa7885fd , which I commented to try to make sense of it!


I just did a build and it works.
Do you have JDK8 installed? You may need to change the `JAVA_HOME` variable to point to your JDK installation.


Если для атрибута есть и геттер, и сеттер, лучше записывать их через `attr_accessor`. И подумай на досуге - хочешь ли ты давать полный доступ снаружи класса этим атрибутам? Сейчас у тебя спокойно можно сделать `train.speed = -100`.


А это что такое?


ok


Инастанс переменные на надо "инициализировать". У них итак значения по умолчанию - nil


Используй << для добавления вагонов


wow u actually decreased the readability for line 8


この方法だと、FacilityListの順番に依存してしまいませんでしょうかね・・・。
user_id:5
facility_id:5
のスケジュールでユーザーの方のスケジュール詳細から印刷画面を開くと、
#if(($!{result.Detail.User.UserId.toString()}==$!{record.FacilityId.toString()}) && $velocityCount == 1)
の条件に一致してfacilityの名前が表示されてしまう気が・・・。


@paranoidjk 你在 react 试试就知道了


ユーザーからスケジュール詳細を開く場合

entityid	：297
template：ScheduleDetailScreen
userid：5
view_date：2017-09-04-00-00

ユーザーのスケジュール詳細から印刷画面を開く場合

entityid	：297
template	：ScheduleDetailScreenPrint
userid	：5
view_date	：2017-09-04

設備からスケジュール詳細を開く場合

entityid	：297
facilityid	：3
template	：ScheduleDetailScreen
view_date	：2017-09-04-00-00

設備のスケジュール詳細から印刷画面を開く場合

entityid	：297
template	：ScheduleDetailScreenPrint
userid	：3
view_date	：2017-09-04

という感じのパラメータを渡しているので、設備のスケジュール詳細から印刷画面を開く場合に渡すパラメータを調整するのがよいかと思います。


Сюда лучше поезд передавать. И делать проверку по его атрибутам.
```ruby
def delete_train(train_to_delete)
  trains.delete_if { |train| train.type == train_to_delete.type && train.number == train_to_delete.number }
end
```


Вот методы станций я бы вынес в public. Разве не полезно знать положение поезда?


Adding some debug eprintf(), you will see:

`r2 -d rarun2 program="/bin/cat" arg0="-" input="a b c\n"`

(without any fix)
```
before r_str_argv(): /usr/bin/rarun2 program=/bin/cat arg0=- input=a\ b\ c\\n
after r_str_argv():
(argv[0] = /usr/bin/rarun2
(argv[1] = program=/bin/cat
(argv[2] = arg0=-
(argv[3] = input=a\ b\ c\\n

```

(with this fix)
```
before r_str_argv(): /usr/bin/rarun2 program=/bin/cat arg0=- input=a\ b\ c\\n
after r_str_argv():
(argv[0] = /usr/bin/rarun2
(argv[1] = program=/bin/cat
(argv[2] = arg0=-
(argv[3] = input=a b c\n

```

(with your suggested fix)
```
before r_str_argv(): /usr/bin/rarun2 program=/bin/cat arg0=- input=a\ b\ c\\n
after r_str_argv():
(argv[0] = /usr/bin/rarun2
(argv[1] = program=/bin/cat
(argv[2] = arg0=-
(argv[3] = input=a\ b\ c\n

```

My fix is obviously correct for this, because rarun2 gets what we give to it originally.


Beyond1Airloop-Part2 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2145 of 2145 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.87%25-green.svg)