@esteele Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.discussion/43/violations
```
plone/app/discussion/conversation.py:420:24: C812 missing trailing comma
plone/app/discussion/testing.py:95:33: C812 missing trailing comma
plone/app/discussion/testing.py:118:37: C812 missing trailing comma
plone/app/discussion/testing.py:120:36: C812 missing trailing comma
plone/app/discussion/interfaces.py:62:80: C812 missing trailing comma
plone/app/discussion/interfaces.py:177:31: C812 missing trailing comma
plone/app/discussion/interfaces.py:178:10: C812 missing trailing comma
plone/app/discussion/interfaces.py:183:52: C812 missing trailing comma
plone/app/discussion/interfaces.py:185:23: C812 missing trailing comma
plone/app/discussion/interfaces.py:219:75: C812 missing trailing comma
plone/app/discussion/interfaces.py:233:56: C812 missing trailing comma
plone/app/discussion/interfaces.py:247:22: C812 missing trailing comma
plone/app/discussion/interfaces.py:253:48: C812 missing trailing comma
plone/app/discussion/interfaces.py:263:44: C812 missing trailing comma
plone/app/discussion/interfaces.py:350:47: C812 missing trailing comma
plone/app/discussion/interfaces.py:362:54: C812 missing trailing comma
plone/app/discussion/interfaces.py:369:22: C812 missing trailing comma
plone/app/discussion/comment.py:120:40: C812 missing trailing comma
plone/app/discussion/comment.py:164:80: C812 missing trailing comma
plone/app/discussion/comment.py:178:41: C812 missing trailing comma
plone/app/discussion/comment.py:179:19: C812 missing trailing comma
plone/app/discussion/comment.py:286:19: C812 missing trailing comma
plone/app/discussion/comment.py:290:38: C812 missing trailing comma
plone/app/discussion/comment.py:352:33: C812 missing trailing comma
plone/app/discussion/comment.py:353:14: C812 missing trailing comma
plone/app/discussion/comment.py:355:28: C812 missing trailing comma
plone/app/discussion/comment.py:422:14: C812 missing trailing comma
plone/app/discussion/comment.py:424:28: C812 missing trailing comma
plone/app/discussion/catalog.py:80:80: E501 line too long (86 > 79 characters)
plone/app/discussion/browser/controlpanel.py:37:46: C812 missing trailing comma
plone/app/discussion/browser/controlpanel.py:71:44: C812 missing trailing comma
plone/app/discussion/browser/controlpanel.py:74:39: C812 missing trailing comma
plone/app/discussion/browser/controlpanel.py:95:40: C812 missing trailing comma
plone/app/discussion/browser/controlpanel.py:96:14: C812 missing trailing comma
plone/app/discussion/browser/comments.py:39:38: C812 missing trailing comma
plone/app/discussion/browser/comments.py:46:33: C812 missing trailing comma
plone/app/discussion/browser/comments.py:53:49: C812 missing trailing comma
plone/app/discussion/browser/comments.py:58:39: C812 missing trailing comma
plone/app/discussion/browser/comments.py:178:15: T000 Todo note found.
plone/app/discussion/browser/comments.py:182:16: T000 Todo note found.
plone/app/discussion/browser/comments.py:229:47: C812 missing trailing comma
plone/app/discussion/browser/comments.py:241:34: C812 missing trailing comma
plone/app/discussion/browser/comments.py:244:69: C812 missing trailing comma
plone/app/discussion/browser/comments.py:294:17: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:83:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:91:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:105:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:147:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:154:38: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:163:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:177:38: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:222:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:231:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:244:44: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:251:40: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:280:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:289:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:302:39: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:310:35: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:346:40: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:351:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:394:33: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:441:18: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:457:40: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:535:36: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:588:14: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:593:41: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:600:22: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:606:41: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:617:51: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:630:21: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:634:18: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:638:20: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:656:66: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:665:14: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:692:54: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:693:14: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:726:71: C812 missing trailing comma
plone/app/discussion/tests/test_comments_viewlet.py:740:67: C815 missing trailing comma in Python 3.5+
plone/app/discussion/tests/test_conversation.py:74:34: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:82:33: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:280:34: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:328:34: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:398:11: T000 Todo note found.
plone/app/discussion/tests/test_conversation.py:514:56: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:518:61: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:528:64: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:532:41: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:542:64: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:546:41: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:620:11: T000 Todo note found.
plone/app/discussion/tests/test_conversation.py:628:38: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:634:43: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:638:40: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:646:54: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:670:43: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:683:40: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:689:34: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:849:59: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:854:59: C812 missing trailing comma
plone/app/discussion/tests/test_conversation.py:860:61: C812 missing trailing comma
plone/app/discussion/tests/test_moderation_view.py:82:59: C812 missing trailing comma
plone/app/discussion/tests/test_moderation_view.py:90:59: C812 missing trailing comma
plone/app/discussion/tests/test_moderation_view.py:98:59: C812 missing trailing comma
plone/app/discussion/tests/test_moderation_view.py:184:33: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:73:37: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:85:37: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:89:46: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:94:46: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:141:42: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:156:45: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:163:53: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:167:53: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:171:52: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:178:44: C812 missing trailing comma
plone/app/discussion/tests/test_indexers.py:182:37: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:32:43: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:43:14: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:54:18: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:65:18: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:76:18: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:102:25: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:113:23: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:124:17: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:130:68: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:137:18: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:170:34: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:171:14: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:182:34: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:183:14: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:190:34: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:191:14: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:205:41: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:214:44: C812 missing trailing comma
plone/app/discussion/tests/test_controlpanel.py:221:35: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:50:34: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:51:14: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:64:28: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:66:24: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:128:54: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:222:61: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:264:31: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:265:14: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:273:31: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:274:14: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:284:31: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:285:14: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:290:41: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:296:31: C812 missing trailing comma
plone/app/discussion/tests/test_workflow.py:297:14: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:29:49: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:33:49: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:37:48: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:41:48: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:82:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:84:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:102:66: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:108:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:110:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:119:46: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:131:66: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:137:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:139:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:144:46: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:153:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:155:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:160:46: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:168:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:170:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:188:66: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:195:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:197:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:208:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:210:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:220:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:222:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:231:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:233:42: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:246:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:248:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:275:66: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:280:57: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:281:14: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:295:54: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:300:52: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:301:14: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:333:57: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:334:14: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:360:31: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:365:31: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:370:33: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:385:76: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:392:73: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:393:14: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:399:28: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:419:55: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:434:57: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:441:57: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:447:28: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:462:33: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:480:33: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:555:61: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:557:35: C812 missing trailing comma
plone/app/discussion/tests/test_catalog.py:570:43: C812 missing trailing comma
plone/app/discussion/tests/test_notifications.py:179:41: C812 missing trailing comma
plone/app/discussion/tests/test_notifications.py:222:16: C812 missing trailing comma
plone/app/discussion/tests/test_notifications.py:226:16: C812 missing trailing comma
plone/app/discussion/tests/test_notifications.py:232:16: C812 missing trailing comma
plone/app/discussion/tests/test_notifications.py:238:16: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:71:42: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:82:42: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:91:42: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:112:33: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:124:33: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:160:62: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:168:50: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:176:67: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:184:48: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:194:54: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:203:65: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:233:66: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:240:37: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:242:38: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:246:57: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:257:30: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:265:66: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:293:69: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:297:77: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:301:76: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:309:49: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:333:66: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:374:57: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:411:57: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:447:57: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:456:60: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:465:63: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:474:66: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:479:38: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:483:48: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:487:41: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:492:38: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:497:34: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:499:44: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:504:41: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:509:37: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:511:47: C812 missing trailing comma
plone/app/discussion/tests/test_comment.py:516:44: C812 missing trailing comma
plone/app/discussion/tests/test_functional.py:31:46: C812 missing trailing comma
plone/app/discussion/tests/test_events.py:155:57: C812 missing trailing comma
plone/app/discussion/tests/test_events.py:176:57: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:33:44: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:99:57: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:115:31: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:123:33: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:131:36: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:139:42: C812 missing trailing comma
plone/app/discussion/tests/test_contentrules.py:147:39: C812 missing trailing comma
plone/app/discussion/tests/test_robot.py:26:57: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


Done


Heh


INCIAMOS CON UNA MAQUINA VIRTUAL


I reviewed this commit in detail, and I approve. 👍 🏆 🥇


I seem to had ran into that issue as well. When I used the command I assumed it would automatically unmute once a volume level was chosen. That doesn't seem to be the case!

I changed line 54 to set volume to 0 instead of muting. This way the volume can just turn back up :)
`os.system("python lgtv.py setVolume 0")`

If you want to start HULU, I recommend modifying the plex lines to the following. To find the app id, run "python lgtv.py listApps". Remember to change the "plex" trigger on line 27 to "hulu":
```        elif name == "hulu" and state == True:
            os.system("python lgtv.py startApp [appid]")
            print "Launched Hulu"
        elif name == "hulu" and state == False:
            os.system("python lgtv.py closeApp [appid]")
            print "Closed Hulu"
```

If you want to start your XBOX on HDMI2, add the following lines to the following. Remember to add an "xbox" trigger on line 27.
```
        elif name == "xbox" and state == True:
            os.system("python lgtv.py setInput HDMI_2")
            print "Input set to HDMI 2"
```


RawMangaTranslator/main.py


The following doc(s) have been deployed to the [absolute](https://absolute-static-docs.pantheonsite.io/docs) Multidev environment:
- [/docs/new-relic](https://absolute-static-docs.pantheonsite.io/docs/new-relic)


It's a good habit to make it `public` to clarify intent.


@esteele Jenkins CI reporting about code analysis
See the full report here: http://jenkins.plone.org/job/package-plone.app.iterate/31/violations
```
plone/app/iterate/policy.py:57:45: C812 missing trailing comma
plone/app/iterate/policy.py:66:11: T000 Todo note found.
plone/app/iterate/interfaces.py:321:23: C812 missing trailing comma
plone/app/iterate/interfaces.py:328:22: C812 missing trailing comma
plone/app/iterate/__init__.py:48:78: C812 missing trailing comma
plone/app/iterate/setuphandlers.py:11:27: C812 missing trailing comma
plone/app/iterate/containers.py:72:50: C812 missing trailing comma
plone/app/iterate/containers.py:73:14: C812 missing trailing comma
plone/app/iterate/browser/checkout.py:70:33: C812 missing trailing comma
plone/app/iterate/dexterity/copier.py:75:19: T000 Todo note found.
plone/app/iterate/dexterity/copier.py:165:50: C812 missing trailing comma
plone/app/iterate/tests/test_iterate.py:153:11: T000 Todo note found.
plone/app/iterate/tests/test_iterate.py:288:34: S001 found module formatter
plone/app/iterate/tests/test_doctests.py:19:50: C812 missing trailing comma
plone/app/iterate/tests/test_doctests.py:27:53: C812 missing trailing comma
```
Follow [these instructions](https://github.com/plone/jenkins.plone.org/blob/master/docs/source/run-qa-on-package.rst) to reproduce it locally.


The following doc(s) have been deployed to the [absolute1](https://absolute1-static-docs.pantheonsite.io/docs) Multidev environment:
- [/docs/new-relic](https://absolute1-static-docs.pantheonsite.io/docs/new-relic)


`payable`? What happens to the sent funds?

Suggest adding `public` again. Or, you can try onlyOwner instead and make a modifier like

```
modifier onlyOwner {
  require(msg.sender == owner);
  _;
}

```


I don't think you meant `payable`. What happens to the funds?

Again, `public` to clarify intent.


Does the project still use zita-resampler here? As far as I can see, it has been removed from sanear project. I don't know if MPC-HC itself use it. Regards :)


I think it's time for that. Let me go thru the documentation bits and fix
it against the same issue.

On Aug 27, 2017 7:21 AM, "Viktor Farcic" <notifications@github.com> wrote:

That sounds good. Wanna do a PR?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/vfarcic/docker-flow-proxy/commit/52c55efe5caf93c7f3d52f16e60e9af655288520#commitcomment-23899617>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAfAC1SlXpChHk9C-60S8irk3xo15k5sks5scMuigaJpZM4PDXOE>
.


nice...


neither me..


okay.


I cannot.
I have any token I find log in and leave all guilds to protect the guilds, not the bot owner.
If your bot has its token in public view then you should NOT have a bot in any guild.
Hide your token from github or someone worse than me will find it and run malicious code like excessive api calls that can end up getting you banned from discord, not just your not.

Do yourself a favor, hide your token like your supposed to.


Still needs some fine tuning to make it more beautifully designed.


I did tournament preferences, but not settings, see ddf7ee1efdf538e4c8484f6752c1f8b0fe3109fc.

Could do settings if you're want, I don't think it's hard, I'm just (on further reflection) hesitant about its usefulness, other than the tab director e-mail. Though I accept that the only harm is clutter.


Hi @t800danya! Yes, sorry that I didn't put up a tutorial since I've been mainly focusing on getting it working. Expect one within the next few days as I am traveling right now so I am only able to do a light amount of work. Thank you for your supporT!!


i'm new to this...still learning. lol...btw tnx for updating...


@fengjie0212 Any comment?


It looks like nuget has a bug: https://github.com/NuGet/Home/issues/5809
So to harden it I've added explicit package reference for .net framework target only:
```
<ItemGroup Condition=" '$(TargetFramework)' == 'net46' ">
  <PackageReference Include="NETStandard.Library" Version="2.0.0" />
</ItemGroup>
```


fast版本用iteration方法，用两个queue，利用queue的先进先出特性


hello boy ，what's wrong?


getNumClasses


No, ends of the vector are not the BCs.
This is a long standing problem in this project, `full(A)` cannot be written for BCs which have an additive term like Robin or Neumann. Dirichlet 0 can be fixed though.


Can you clearly document what `full(A)` does in each case? It's confusing to me what the behavior actually is. Since it seems that it cannot get the BCs correct, I think it would be fine if it always returns the stencil, and is clearly documented that is what it's doing.


plz work


what's does this mean？


"silent running" ;)


Ill be very pleased if you end up fixing Thermos 👍


Yeah sure the documentation, I'll just add it above the function in the code. Returning the inner stencil seems to be the best bet for BCs like Neumann and Robin.


cambio autorizado,


Executing the daily benchmark build, I will reply here when finished:

@nanosoldier `runbenchmarks(ALL, isdaily = true)`


there's 0.13.16 too ;)


I don't really care, rite?


this is a bit of a todo xD


RIP berries


This is a horribly hacky way to do things.  I need to convey some kind of "sizedness" to values to figure out how to partition things better.


This isn't exactly wrong but it's not the cleanest way of extracting data from the slice.  It should be cleaned up some more.


“molloc" use false


"molloc" use false.


bueno es una forma de hacerlo.


quita el hello world y vuelvelo a subir


Error


The following doc(s) have been deployed to the [inforollov](https://inforollov-static-docs.pantheonsite.io/docs) Multidev environment:
- [/docs/timeouts](https://inforollov-static-docs.pantheonsite.io/docs/timeouts)


@a-frobot docs-v0.6.0


Resolve


dsfafdaf


<!DOCTYPE html>

  <title>Bootstrap Example</title>
  <meta charset="utf-8">
  <meta name="viewport" content="width=device-width, initial-scale=1">
  <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css">

John's Blog

Home

Friends

Family

Photos

        <input type="text" class="form-control" placeholder="Search Blog..">

          <button class="btn btn-default" type="button">

          </button>

RECENT POSTS

I Love Food

 Post by Jane Dane, Sep 27, 2015.

Food Ipsum

Food is my passion. Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.

RECENT POSTS

Officially Blogging

 Post by John Doe, Sep 24, 2015.

Lorem

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.

Leave a Comment:

      <form role="form">

          <textarea class="form-control" rows="3" required></textarea>

        <button type="submit" class="btn btn-success">Submit</button>
      </form>

2 Comments:

Anja Sep 29, 2015, 9:12 PM

Keep up the GREAT work! I am cheering for you!! Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.

John Row Sep 25, 2015, 8:25 PM

I am so happy for you man! Finally. I am looking forward to read about your trendy life. Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.

1 Comment:

Nested Bro Sep 25, 2015, 8:28 PM

Me too! WOW!

Footer Text


Data Wrangling Exercise 1: Basic Data Manipulation


Unfortunately, there are limitations on using strictly BAT files.

1. I could not get Windows Media Player to play minimized or invisible.
2. I could not get the BAT file to run minimized or invisible.


first commit


hi i have  problem /app.js:5
    consumer_key: config.main.consumer_key,
                             ^

TypeError: Cannot read property 'consumer_key' of undefined

how can i correct this?


always do dis? input plox.


you should avoid to push your `.idea` folder and such IDE specific config directories as they make your project unusable on other systems. For this, you can include a `.gitignore` file in your repo.


this is one single append with faux concatenation inside it because of how the compiler works.


I indented this for visual effect; input?


1k characters seems a reasonable assumption for just adding a bit.


I did this to circumvent warning message `1 commit behind master.` on testing branch...


Fixed calculations


Got it. Fixed!

On Sat, Aug 26, 2017 at 11:16 PM, Vikrant Goel <notifications@github.com>
wrote:

> you should avoid to push your .idea folder and such IDE specific config
> directories as they make your project unusable on other systems. For this,
> you can include a .gitignore file in your repo.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/pragyagoel04/Sockets/commit/aa6f6c887220d277f8396c3659999ff0d8f1942e#commitcomment-23900883>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ANMz5geutEWPY8y9BITS6AxEZz_WTw_sks5scO2zgaJpZM4PDshh>
> .
>


I don't see why you'd call this improvements though in javascript's way of thinking...


That's all I can think of at this point, yeah. I've removed it and it all works fine. Will update.


Was there any particular reason this was taken out? Pointing how important it is if the plugin is being used in an Angular environment.


split() was DEPRECATED in PHP 5.3.0, and REMOVED in PHP 7.0.0.


dddd


Capstone Project-Design


哈哈


おお、こんなことできるのか、これはいい。


After this commit hazzy.ngc does not render properly, and I am not sure why. I think that might be part of the same problem with the arcs.  I will look more into it tomorrow, but I cant think any more now so I am off to bed!


@akihikodaki 文字コード指定って一番最初に書かないといけないのでは・・・？


This has not worked for us.
This triggers the error -
Rendering SLS 'base:jupyter.jupyter' failed: mapping values are not allowed here; line 158
can't intialize anywhere


Hi @jalbatross ! Thank you very much for your reply! Looking forward for your tutorial within next few days!
With the best regards Bogdan.


このために導入したようなもの。


Never add this files in git repo.


No need to add this files in git repo.


Your class is named as an interface UserInterface. Confusing for students.


Also why is user a static field?


そんなことは仕様に書いていない。ただしファイルの最初の1024バイトに含まれていなければならないと規定されている。


Added Load & Get Total


We are teaching them about is a relationship. A extends B then A is B. How is Question a Timestamp?


upVote -> upvote. Its a single word.


includeしているものがうっかりでかくなったりするとあかんし、charset指定前に日本語が入ると動かない処理系があった気がした


Added basic math functions


woot 👍


Bluemix [toolchain](https://dev-console.stage1.bluemix.net/devops/toolchains/25e204c7-064e-44f4-a4a0-69119e7e9909 "UI-ys1dev-SimpleTC0827T005155"): [Delivery Pipeline](https://dev-console.stage1.bluemix.net/devops/pipelines/1d6f88ad-f00c-4114-93ec-e63698933cf5 "UI-ys1dev-SimpleTC0827T005155") deployed [UI-ys1dev-SimpleTC0827T005155](https://github.com/idsb3t1/UI-ys1dev-SimpleTC0827T005155/releases/tag/deploy-ibm-ys1-us-south-idsb3t3-us.ibm.com-dev-20170827-045442 "deploy-ibm-ys1-us-south-idsb3t3-us.ibm.com-dev-20170827-045442") to [dev](https://console.stage1.bluemix.net/apps/2d28c890-5e1b-45d5-ada5-525cedc9cc5a?env_id=ibm:ys1:us-south "ibm:ys1:us-south:idsb3t3@us.ibm.com:dev"), including this commit


Added validation, finished project


Fix #187


No need to add a bufferedReader as  a static field. Initialize it when you need it and close it afterwards.


@valda When you have time, can you look at the FNV and FO3 Wrye Flash for a suitable solution.  LENS has two DNAM records. I tried to cut and paste a Mel_xxx_Distributor() into here but after the changes it told me the element and attribute didn't exist. Because I didn't know what I was doing.  Can you help fix this please?


Bluemix [toolchain](https://dev-console.stage1.bluemix.net/devops/toolchains/b59af34f-bb1e-48f9-bfe3-6124c6569f90 "UI-ys1dev-KEEP-TC"): [Delivery Pipeline](https://dev-console.stage1.bluemix.net/devops/pipelines/95b48a85-90ae-4a2a-b138-ea0a6fbc4e6a "UI-ys1dev-KEEP-TC") deployed [UI-ys1dev-KEEP-TC](https://github.com/idsb3t1/UI-ys1dev-KEEP-TC/releases/tag/deploy-ibm-ys1-us-south-idsb3t4-us.ibm.com-dev-20170827-050109 "deploy-ibm-ys1-us-south-idsb3t4-us.ibm.com-dev-20170827-050109") to [dev](https://console.stage1.bluemix.net/apps/57dcc3b3-f113-4818-a738-324212c39ed9?env_id=ibm:ys1:us-south "ibm:ys1:us-south:idsb3t4@us.ibm.com:dev"), including this commit


I use the `.` prefix to indicate variables that live part of the parent lexical scope (just to remind myself that I need to use `<<-`, not `<-`, to mutate their values).

It's entirely just convention though (there's no real difference between an R identifier that starts with a `.` and one that doesn't)


The spec (ShaderPreset.h) doesn't allow unspecified scales. You should update the spec if we want to allow this.


0.13.15 is enough ;)


Just to clarify... this was a problem with my travis configuration, not with the code :P

This link helped me fix it:
http://ecmendenhall.github.io/blog/blog/2013/05/28/two-travis-ci-solutions/


 `int`だと`null`にできないので、-1や0を入れるのが適切だと思います。
なので、あってます。バッチリです！


I think you misinterpreted what I meant.

class overhead:

```js
class API {
  foo () {}
}
```

transpiles to
```js
"use strict";

var _createClass = function () { function defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ("value" in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } } return function (Constructor, protoProps, staticProps) { if (protoProps) defineProperties(Constructor.prototype, protoProps); if (staticProps) defineProperties(Constructor, staticProps); return Constructor; }; }();

function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }

var API = function () {
  function API() {
    _classCallCheck(this, API);
  }

  _createClass(API, [{
    key: "foo",
    value: function foo() {}
  }]);

  return API;
}();
```

and this

```js
const API = {
  foo () {}
}

```

transpiles to this

```js
"use strict";

var API = {
  foo: function foo() {}
};
```

> Also, since this class does not extend any other class, e.g., the React Component base class, the overhead produced by this approach is outweighed by the clear statement of ownership of the Collection objects by the API class.

Since you don't export your api class, your code delivers a public interface consisting of
```js
import { Projects } from '/imports/api/server'
```
and accessing the collection itself directly.

or just

```js
import '/imports/api/server'
```
and using the meteor methods you defined

which neither of which declare that there is any sense of ownership of the collection by the class.

what I suggested has a public interface consisting of
```js
import projects, { projects as projectsCollection } from '/imports/api/server'
```

which gives you access to the api you defined, direct access to the collection if desired, and access to the meteor methods as well.

If you want a clear statement of ownership, then just use the collection as a property of the api itself.
```js
const api = { projects: Mongo.Collection('projects'), etc... }
export default api
```

But honestly your api users shouldn't need to know of nor care about the collection itself. Just the defined API and what it's input and outputs are.

You are of course free to do as you please. cheers.


Replaced former API keys.


lol by wanting margins you remove `margin`


Bluemix [toolchain](https://console-regional.stage1.ng.bluemix.net/devops/toolchains/1ee3849a-ebc9-4d6f-b00c-874c5fa52734 "UI-ys1int-SimpleTC0827T011756"): [Delivery Pipeline](https://console-regional.stage1.ng.bluemix.net/devops/pipelines/93b83175-6626-49c9-863b-8b0458723997 "UI-ys1int-SimpleTC0827T011756") deployed [UI-ys1int-SimpleTC0827T011756](https://github.com/idsb3t1/UI-ys1int-SimpleTC0827T011756/releases/tag/deploy-ibm-ys1-us-south-idsb3t3-us.ibm.com-dev-20170827-052025 "deploy-ibm-ys1-us-south-idsb3t3-us.ibm.com-dev-20170827-052025") to [dev](https://console.stage1.bluemix.net/apps/dc605189-f73b-4eca-b828-5bbe4df69696?env_id=ibm:ys1:us-south "ibm:ys1:us-south:idsb3t3@us.ibm.com:dev"), including this commit


d


[Your benchmark job](https://github.com/JuliaLang/julia/commit/e89d150c9a1bd45fda40ddba58135aa3ac2f582d#commitcomment-23900592) has completed - possible performance regressions were detected. A full report can be found [here](https://github.com/JuliaCI/BaseBenchmarkReports/blob/3f597b9cb33141ded8c80e95b3926aa58cd6cc6b/daily_2017_8_27/report.md). cc @ararslan


Probably `muparser-2.2.5/build/` can be added to .gitignore. Go for it if you like.


I prefer the older 'route' syntax, but the function is marked for deprecation, so we have to switch to 'choice'.


Please use clang-format with style set to "google" before committing. :)
If you are using emacs this can be done with clang-format package available in elpa/melpa.


Bluemix [toolchain](https://console-regional.stage1.ng.bluemix.net/devops/toolchains/ee7af0c7-eb4b-4808-84ae-65a1ebf892f4 "UI-ys1int-KEEP-TC"): [Delivery Pipeline](https://console-regional.stage1.ng.bluemix.net/devops/pipelines/91fde061-3564-4ded-a29e-3c930cc52871 "UI-ys1int-KEEP-TC") deployed [UI-ys1int-KEEP-TC](https://github.com/idsb3t1/UI-ys1int-KEEP-TC/releases/tag/deploy-ibm-ys1-us-south-idsb3t2-us.ibm.com-dev-20170827-052725 "deploy-ibm-ys1-us-south-idsb3t2-us.ibm.com-dev-20170827-052725") to [dev](https://console.stage1.bluemix.net/apps/9c6303b5-28cd-4878-b65a-83ab6b876fcb?env_id=ibm:ys1:us-south "ibm:ys1:us-south:idsb3t2@us.ibm.com:dev"), including this commit


`cards.get(index1)`だけだと、配ったはずのカードがディーラーの手元に残ってしまいます。
配ったカードは`ArrayList`から削除するようにしましょう。
`index2`のほうも同様です。


If you intend to merge your changes into master/devel later, please use clang-format with style set to "google" before committing your changes. If not, differences in code styles on different systems/editors makes it impossible to read diffs.


Should this be `if (m_speed != 0.0f) m_frameCount += 1;`?


第一个文件


What happens on entering an incorrect choice?


#700 #703 #705


Add comments on what every field means. Like for user // The user who posted the question. etc.


there is nothing wrong with these things actually, appharbor just doesn't .net core 2.0


Yes, my apologies. For some reason, I thought the reference to the comments was to the original discussion in the pull request.

I'll post any further information in the comments on the commit.


Create a class "AbstractNode" or "AbstractEntity" instead of Timestamp, move id, last entry and user etc. all the common fields in that abstract class.


commit


为毛不用 using namespace std;


Add some comments on this class.


unzip and upload to server


Rename this method.. From the name it looks like you are checking if message contains some message, maybe checking for not null.


Return the question created in this method.


Una corrección pequeña pero importante: El estándar de nombres de archivo que usamos indica que tu archivo debe ir en el directorio MedinaAnibal, no AnibalMedina.

Va como reto: ¿Puedes renombrarlo?


Una corrección pequeña pero importante: El estándar de nombres de archivo que usamos indica que tu archivo debe ir en el directorio ReyesAntonio, no AntonioReyes.

Va como reto: ¿Puedes renombrarlo?


When will a question be null in questions?


same comments as QuestionsService.


@afaur  Got rid of constructor and super as per https://medium.com/@joshblack/writing-a-react-component-in-es2015-a0b27e1ed50a


Create interfaces for all services.


Upvote is either on question or on reply.. not both..


`this.open() <= 17`の部分自体が`true`や`false`になります。
つまり、このメソッドは`return this.open() <= 17`のようにもできます。
試してみてください。


As far as I've seen this causes FAST to load default values instead of transferring the history whenever this method is called...


What you mean with usage?


Your are totally right - this has also caused an unintended reconnect each time you navigate back. Fixed in 0aa68223995a233a8aa32bd99f65776a78a26a1a


parameter로 입력한 v0에서 출발해서 모든 Node를 방문할 수 없는 graph의 경우 에러가 나는것으로 확인됩니다.


My reasoning for this being safe is that these properties would be there is if you turned `useMongoClient` off,
which was the only option pre mongoose 4.11.0. So if you were for some reason sending the connection props to the client, this fix wouldn't be the cause. Please report an issue if you have a good reason to think otherwise.


Use true/false for readability. Also apply for the rest.


A promise does not return anything. It either gets resolved, or rejected. You have to use ` resolve(xxxx)` or ` reject(xxxx)`.


Your goal is to be able to cache the inbox content in memory. You miss one important thing here that will be needed in the `if (this.inbox) {` block.


LGTM, need to give it a go to test it.


The image isn't showing because the relative path is incorrect - the image is in the same root folder as your HTML file.


Watch out for indenting inconsistencies - your `h2` is at the same level as the `p` element above it, so it should have the same indent.


Gracias


nO.


Not related to this, but PocketMine-MP GitHub repository has reached 6000 commits.


Applying padding or margin is preferable to using `br` tags in the majority of cases where you might consider using the `br` tag. You can see [here](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/br) - "The HTML <br> element produces a line break in text (carriage-return). It is useful for writing a poem or an address, where the division of lines is significant." - you're really just trying to add additional space between elements here.


reading the explanation should this not rather be
   cost = cost * ....
for the virtual index case ?

Also, assuming you are going to submit a PR (would be very nice! :-), I'd prefer if statements to using the ? operator

thanks!


So how's that new quick assist? ;)


help me to learn python


This file became Controller.py


//sample


85行目の`address.indexOf("@")`と、ここの`address.substring`メソッドだけで実装できます。
`for`文なしの実装を、もう一度考えてみましょう。
（どうしてもわからなければ、直接メンターに聞いてみてください！）


This relative path doesn't need the `../Assignment` portion - you are already at the root folder `Assignment` level so you just need to go to `starter_code/images/RedRocks.jpeg`.


This broke the build, please revert


Nice job using a custom class/inline styling for the `h2` element here - a very common design need is adjusting the width of block heading elements.


i think this is okay


それもそのときになってから考えること。


its okay as well


looks fine to me


this `pass` is redundant


Sorry for taking your time...
What is the advantage of doing this?
Thank you!


Same issue with relative path here - since `portfolio.html` is in the same folder as `index.html` you don't need anything but the file name for the relative path value.


I don't think WorldEditArt does anything with the players at all.


What's all this as I just created my sigmin as I see my browser is being alternated I'm hack ha-ha omg


@a-frobot docs-v0.6.0


I have fix for that


ohai


idk


Ignorar


これまでの課題をまとめて実行するのではなく、これまで扱っていない標準クラスを使う処理を書いてください。
また、その際に経過を記録したログファイルを作成するようにしましょう。
（課題の意味がわからなければ、直接メンターに聞いてください。）

課題で扱っていない標準クラスについては、次のリンクが参考になるかもしれません。
[【Java入門】1分で理解する標準クラスとは？](https://eng-entrance.com/java-basic-string-standardclass)
[標準クラスライブラリ](http://msugai.fc2web.com/java/class/index.html)
[Web開発のためのJava入門 8章：標準クラス](http://www.fujitsu.com/jp/group/fap/services/java-education/course/technology/java-cobol/08-standardclass/)


`<form>`の開始タグもちゃんと書きましょう。


//this is mock


Thanks for fixing this. I had in parallel fixed all of these, but wasn't able to commit, even after merging...


I've tested it and my version works, but is 4 bytes larger in my case.
However I am thinking if we should not surround the whole thing with an atomic block. We handle if interrupts are on or off. This basically means we accept that users print inside interrupts (because arduino by defaults always enables them anyways).

Now if at any time this code gets interrupted and a new byte placed inside the buffer within this interrupt, the head variable might be already outdated and data might be missed. So from my point of view it would make sense to surround the whole code with an atomic block, otherwise we could just drop interrupt support.

Did I miss something?


commentsssss..


@Torlopov-Andrey тогда в `all` надо массивом иницилизировать, а не нулем :)
@MarynaNogtieva вообще это просто рекомендация, т.к. к текущему занятию не относится. В нашем случае вполне и переменная `@@` подойдет, мы ведь хотим собирать все станции в один массив (в том числе и наследники, которых у нас сейчас нет вовсе :) )


Yes, that would trigger the bug that I thought might be the cause, but I'll test it later today and submit a fixed pull request.

The bug is that line 2174:
`		foundService = False`
should be
`		foundService = eServiceReference()`

Error in the copy/paste/modify of the code I extracted from channel zap in the Beyonwiz version of RecordTimer.py.


Да, хороший совет - когда строка является неким "идентификатором", то лучше использовать символ. Например в хэшах ключи часто символами делают.
Но если уж совсем придираться, то я бы вообще не хранил тип как инстанс-переменную. Сам класс и является типом вагона. Так что либо опираться на класс, либо тип сделать виртуальным атрибутом (т.е. методом, который значение возвращает).


Настройка Rubocop - следующее занятие. Там как раз все такие замечания уйдут


Hm, I think you're right, there should be an atomic block around that (and probably also some comments explaining this race condition in both places). Care to prepare a PR? :-)


Also, care to try to reproduce the problem? The easiest way is probably by inserting a bit of delay, simulating an interrupt, or to set up an interrupt that is continuously triggered (which makes the main loop super slow, but at least one instruction will execute between each ISR invocation).


These "chapters" are in most cases very short notes or narratives. Don't want to force a page break between each one.


Допустим у нас общий объем 10, занято 9, а параметром пришло 2. Тогда занятое место превысит допустимый объем


This commit has been mentioned on **Discourse Meta**. There might be relevant details there:

https://meta.discourse.org/t/require-password-for-trusted-user-invites/13750/59


Называй переменные понятно. Пока в коде на начнешь разбираться, неясно что за v


accepted


Не забывай про guard clause - они помогают избежать лишней вложенности
```ruby
return unless block_given?
... # body of method without indentation
```


Вот тут ты преобразовала блок в объект


Нам не обязательно преобразовывать блок в объект. Это лишняя операция. Так делают, когда блок надо прокинуть в другой метод. У тебя же просто надо вызвать блок - для этого есть `yield`. Убери параметр из метода совсем, а тут используй `yield train, index`


Both of your suggestions actually make sense. The first one simplifies the code a bit when waiting for space to free up. However, it does mean that interrupts will be globally disabled for quite some time, also blocking other interrupts, which is problematic. However, instead of using an atomic block, you could probably just disable the UDRIE interrupt (but perhaps only when the buffer is full and not always, since the common case is when the buffer is not full and should be as fast as possible). Not sure if that would end up being smaller or faster, though.

The second suggestion, to disable interrupts during the entire write routine, would indeed make serial printing from ISRs more reliable. It is not currently officially supported, in the sense that it shouldn't infinitely block as it did before, but there are still race conditions that could mess up you output. Your suggestion would, AFAICS, make it completely safe to print from ISRs, but at a performance penalty (write will be slower, but also interrupts will be disabled more often). If this is added, interrupts should certainly be re-enabled when the buffer is full during the busy-wait, which probably complicates the code somewhat again.

I'm not sure if either of these is worth implementing, but it might be interesting to further explore how it would look.


Тут все аналогично станциям - см. [мой коммент](https://github.com/MarynaNogtieva/thinknetica/commit/af1dcf0a72dbb75b1f5da3f6d2e249274ac92175##commitcomment-23902292)


it seems not working ,still wait on grand children, see https://github.com/moby/moby/issues/29700


Done.


Where is the test? :)


Можно было определить у вагонов метод `to_s`. Он используется при преобразовании объекта в строку (например для вывода на экран). В каждом типе вагона задаешь нужный формат (например в пассажирских `"#{type} car, number #{number}, seats: #{seats_number}"`), а тут без всяких условий пишешь `"#{i}: #{car}"` - удобно и лаконично.


Объем и нецелым числом может быть


This is a nice alternative to inheritance.  I like it--well at least it's better than `densely_ordered_preorder`, `densely_ordered_linear_order`, etc...


И зачем это сюда подключать?


Подключения зависимостей описываются в самом верху файла


Модуль Company и должен создавать нам методы для работы с компанией. В чем смысл модуля, который требует в классе дублировать его задачу?


Откуда этот метод возьмется в классе?


Yes, they are!.


Этот метод предполагает, что в классе уже есть сеттер для указания компании. Но ведь создать такой сеттер - как раз задача этого модуля, иначе он бесполезен


814e306 で修正した。


accepted


Принято писать `@@stations << self` - так немного короче


nice work.


Когда нам нужен быстрый и простой доступ по ключу - лучше использовать хэш. Нам как раз нужно получать поезда по их номеру


Используй хэш для хранения, тогда метод сильно проще будет (не надо никаких итераций)


Thank you


Nicely done! Have you checked this is the right order to restore the fields in? And did you notice any improvements as a result from this?


Если у первого поезда номер не совпдает с искомым, метод просто вернет nil.


Hello

Line 331 	RetransmitDelay = delay; should be  dev->RetransmitDelay = delay;   //  correct ?
*.h and *.c struct name: nrf24L01_Dev should be same everywhere, not capital or normal letters // correct ?


This OOVPA might well applicable to earlier xdk versions too - I wish there was an easy way to corroborate that... Do you have any idea on how that might be done? Would you need more patterns for example? (I could try to dig some up...)


Задание к уроку Основы Ruby. Часть 3/train.rb

Во-первых, что за `k`? Я ранее акцентировал внимание, что нужно переменные понятно называть
Во-вторых, что за type? Такой переменной/метода не существует, так что код просто упадет


Отступ поехал


Зачем эти аксессоры?


@zebastian , I have removed optional packages for osx build, because then only generate travis errors. If you want to continue trials with these packages, please create temporary branch.


Сейчас последняя добавленная станция становится конечной в маршруте. А так быть не должно, начальная и конечная станции задаются только при создании маршрута


Почему параметр называется new_station?


Нельзя удалять начальную и конечную станции маршрута


Because r2 -cVppssss was broken

> On 27 Aug 2017, at 03:42, condret <notifications@github.com> wrote:
>
> why?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
>


Откуда взяться текущей станции, если индекс станции еще не задан?


Почему метод называется `add_train`? Разве он поезда добавляет?


Этот метод не поезда удаляет, а вагоны


Если у нас было 0 вагонов, а в метод передали число 1, то число вагонов станет отрицательным


建议和上面的程序统一，在等号的前后加上空格


У маршрута нет метода `station`


Эта ошибка везде в этом классе


#78 Was fixed here


У тебя есть метод `prev_station?`, который проверяет есть ли предыдущая станция. Тут ты в проверке дублируешь его логику. Просто используй его


А зачем нам тут хэш? Нужен просто список станций, без поиска по ключу, так что массив лучше подойдет


Fixes made according to #142


Solution is not compiling. To reproduce take a clone in fresh folder and rebuild the solution. Fix the compilation issue.


Neat. :)


Unused namespaces. There are lot of classes with unused namespaces, please fix the same.


unnecessary space


Так конечно можно делать, но на мой взгляд есть вариант проще:
1. В ридере задавать дефолтное значение
```ruby
def instances
  @instances ||= 0
end
```
2. Аналогично п.1, но делать это в методе register_instance перед инкрементацией


Вот это зря :)


Ты закрыл сеттер для атрибута на уровне класса, так что тут ошибка будет


unnecessary space. Take care of indenting also.


unnecessary spaces.


unnecessary space.


unnecessary spaces


Good work! Two issues I can see are still not fixed here:

(1) When adding points in the Measurement tool, then turning on the Snap to road switch, the routes between the points are calculated, but the distance display between the points and total distance is never updated (i.e. remains the aireal distance)

(2) After closing the Measurement tool via its x button, the map activity's navigation button lower left corner of the map screen) is shown in blue (likely due to the previous Measurement tool's Snap to road route calculations), but of course needs to reflect the real status (usually gray)


Непонятное имя переменной


Такой вариант неплох, но можно сделать красиво без всяких условий - `@taken_space = [@taken_space + v, @volume].min`.


Можно назвать метод `to_s`. Тогда при каждом приведении объекта к строке (например для экранирования) будет использваться описанный тут формат. Можно просто писать `puts wagon`


I'm doing a fair bit of mucking about with the build process via a `.pyxbld` file. Is that different then "control over how your Cython file is compiled"?


See my comment for https://github.com/Proxmark/proxmark3/issues/386 - the $$NF should just be $NF, assuming the "4.1.2-46)" is what we want.


I'd be happy to receive a pull request that further improves the documentation and/or the implementation of pyximport.


По-моему это переусложнение. Я не вижу никаких преимуществ перед хранением в числах (число занятых, общее число мест)


I'm pretty sure this is not correct. Looking at some of my cython projects, the C/C++ file *also* get's placed into the build directory (usually `~/.pyxbld`).


I don't think I'm familliar with how cython *actually* works to write anything coherent. I have enough trouble just figuring out how to persuade cython to build things the way I intend.


Да. То что можно вычислить из других данных надо именно вычислять, а не хранить. Если вычисления являются узким местом, тогда можно подумать о кэшировании и хранении результата, а так - это лишняя морока (данные-то надо актуализировать)


It is not ready yet to be under automatic response I/0


I don't think this is the number of colors. Maybe the number of colums (width) for the GIMP UI to display them.


Why is this here?


If global.helpfile is NULL this causes a segfault.


См. [мой коммент выше](https://github.com/mimoni/ror_full_4/commit/7ec9ef8b19de5e7cbdd1fe4998dc8b7a78aeba2e##commitcomment-23902638)


Не заметил изменений в интерфейсе создания вагонов (теперь надо общий объем / число место указывать). Так же нет возможности через интерфейс занять места или объем


> I have enough trouble just figuring out how to persuade cython to build things the way I intend.

Well, it certainly tends to be easier to follow the normal, well worn-out paths.


Ниже ты все равно переопределяешь метод `type`, так что эта строка бессмысленна


Oops, I meant to send this as a PR.

The change is from:

To:


Т.к. этот метод следует определить в потомках, то стоит вызвать `raise NotImplementedError`, чтоб не забыть об этом


Когда строка служит "идентификатором", следует использовать символы - они как раз для этого созданы


mixing in unrelated whitespace changes and parameter reordering is not recommended though as it makes it harder to see what actually changed.
also, why was SRCFILES not set in lib/Makefile before? is it dead code?


nums1 [m,m+n-1] is empty; sort from large too small will not affect the former numbers. when nums2 finish, nums1 is sorted. when nums1 finish first, push the remain part of num2 to nums1


Ruby - объектный язык. Так что лучше создать класс (например Application), в конструкторе задать все необходимые переменные (массивы), и сделать один публичный метод (например run), который будет выводить меню и обрабатывать ввод пользователя.


Created multidev environment [ci-example-d8-composer#ci-720](https://dashboard.pantheon.io/sites/c401fd14-f745-4e51-9af2-f30b45146a0c#ci-720).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-720-ci-example-d8-composer.pantheonsite.io/)


Может просто `stations`?


У тебя метод выше то же самое делает. Почему его не использовать, вместо того чтоб логику дублировать?


我添加了一条评论


Используй `each.with_index(1)` - первым параметром в блок придет элемент меню, вторым индекс (причем нумерация будет с 1, не надо вручную ее прибавлять)


strncpy


If I were writing a library, sure. Pretty much every case I actually use cython, I'm either writing glue logic to wrap custom hardware during development, or optimize a component of something I've already written in python.

I guess my point is, why is pyximport part of the core distribution if it's not "normal"?


Thanks. Fixed in 00305bd3258724dae191a3e69c9875145469afd5.


I am sorry my comments have been deleted, so I need to rewrite them for the third time!

The reason why combo are only for parameter tweaks is that we don't want a bad/neutral patch to be pulled in by a good one, this in the long term pollutes the code with useless stuff and considering that to remove useless stuff requires statistcially much more effort than to validate a good one, we don't allow combo of general pacthes.

This is already well explained in the fishtest wiki as I poinnted you (before you deleted my comment).


I fixed it!


wrong checksum: https://hydra.nixos.org/build/59468988/nixlog/1


Accepted!


Why not using std::partial_sum ?


May want to return here. It is not necessary with current code, but it might change in future.


restore


See here, for example: https://github.com/syl20bnr/spacemacs/issues/3011


Thanks for sharing! I'm curious why you have to open a new connection every time, is it supposed to be re-used for different call?


300 port seemed to be in use


Hi,

how about creating a PR into coppit/docker-mumble-server, so that this can built automatically?

- Michael


This wouldn't be a problem while using `github-hovercard` extension. But if not, the tooltip isn't visible on hover of last person icon.. can we do anything to make the tooltip open upwards?

![tooltip-not-visible-hover-name](https://user-images.githubusercontent.com/8295888/29748224-795f1226-8b2f-11e7-9fd3-2853449a7756.png)


con esa opcion no lo muestra. hay que poner .LogError , para que te lo genere como error y te  muestre lo que vale esa variable  por consola.El unico problema es que te para el juego.


Addressed in 4c23d059f5ffd08216e6007ddeea0b0850736e6c; thanks.

This might be that `fetchFromGitHub` is not deterministic: the “wrong” hash is obtained on macOS with a case-sensitive file system, whereas the corrected one is obtained on NixOS with ext4 file systems.


Please wrap in to function for render ad provide to users possiblility for redaclare this function and make PR.
For example

`
...
selectedRender(selected, options) { //default declaration
 return this.props.customSelectedRender ? this.props.customSelectedRender(selected, options) : selected.join(", ");
}
...
return selected.length > 0  ? this.selectedRender(selected, options) : this.props.label
...
`


when want to find the maximum subarray up to index i, when should know the maximum up to index i-1;
if the sum end to i-1 is smaller than 0, than just A[i], if is larger than 0,add A[i] to the sum;


In general we have two different issues:
* The TX Interrupt itself occurs while writing
* Another interrupt occurs where the user placed write() code

The 2nd is more problematic and should never happen if possible (user should not print in interrupts). However if we say users should not do that, then I do not see any reason why we do not use just this one:
```cpp
while (i == _tx_buffer_tail);
```

Now if we assume the user can print data inside interrupts, we also have 2 options:
* The user only prints inside the ISR (for debugging)
* The user prints inside the ISR AND user code which runs at the same time

The 2nd option is really mad, as our write() can also get interrupted by another write(). For example if the buffer is full and we empty it, it doesnt mean right after that an interrupt fills it again. The only way to work around this is to completely disable interrupts in write() and possibly other functions(flush, etc.).

The 1st case is the one I am interested in. Because I knew places where you need to debug ISRs and in the end you use the serial only to debug stuff. So this is a good trade off. So we assume write() is safe when called outside interrupts (from write itself), but an ISR could also possibly call write().

You are right that generally disabling interrupts around this `while (i == _tx_buffer_tail)` would make things slow, so we keep it as it is. However we can still further improve the code:

```cpp
while(bit_is_set(*_ucsra, UDRE0));
_tx_udr_empty_irq();
```

Interrupts are disabled at this point, so we need to wait only on the usart to complete. Instead of looping through the whole while and ifs, we can just check for the UDRE bit. The outer loop will always end afterwards.


I was thinking init_pluging(), not init_plugin_info(). And even there it gets called before bitlbee actually initializes global.helpfile, so it seems this won't work this way.


I have followed option 1 (see #15)
I wanted the PR to be done rapidly (before new breaking PR :-) ) so right now there is no way to do bulk processing as I want (same explanation for several cases). Will implement it soon (but after the merge of the PR).


I'm sorry. Hyperlink should by https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221735


please revert this

All other builds are cancelled after one failed

https://ci.appveyor.com/project/DarthGandalf/kvirc/build/0.0.0.0.1-branch-master-build-2377


hello,how can i use the sql to operate the solr index?for example , i want to run the create command,but it have a promblem.


The `releasePublishArtifactsAction` setting does not appear to take effect for multi-project builds - the signing action is not taken, and the subsequent `sonatypeReleaseAll` fails on closing the staging repository. I'd be glad to know if I'm doing something wrong - I've opened https://github.com/xerial/sbt-sonatype/pull/52 to revert the recommendation in the mean time.


`if __number_of_extraction_processes == 1:` should be `if __number_of_extraction_processes != 1:` ?


pyximport has its uses, that's why we ship it. Honestly, I do not care whether we agree on your use cases being less common or not. From my own experience, the library case is the "normal" case, when counting the number of builds and installations, but pyximport is not suitable for that case, and the documentation should make that clear.

If, as you seem to suggest above, you are having trouble making it work for you the way you want, I would not immediately rule out the possibility that *as it is implemented now*, it might not be the best solution for your use case either. I'll just repeat what I already said above: "I'd be happy to receive a pull request that further improves the documentation and/or the implementation of pyximport."


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


- Issue #2080: we are using OpenModelica 1.11 including the related table implementation
- Power peaks due to very high acceleration


Good catch! Fixed in #7


收单


These quote escapes are visible in irc client, why are we adding those?


Some comments inline.
Please move discord-help.txt to 'doc' dir. We also need to install it to a proper location.


This repo  is for linux reference


In the logo its a single word but when referring its Red Hat I guess


Oh, I'm not having issues *now*. I *was* having issues, until I figured out, with some head scratching, a few stack-exchange questions, and a bunch of reading the source how to get a pyxbld file to work.

Really, I have zero complaints at this point, I just don't think I understand any part of the build process well-enough to go in and make changes.


継承したクラスはどこにあるのでしょうか……。


> The 2nd is more problematic and should never happen if possible (user should not print in interrupts). However if we say users should not do that, then I do not see any reason why we do not use just this one:

Well, the current policy is that printing in ISRs is not recommended, but it should be possible for debugging. In practice, this means that things will not break or deadlock, but it is acceptable to drop data or insert random garbage in the stream occasionally. So I do not agree that if *any* support for printing ISRs implies that there should be full support, there's still a balance there.

> The TX Interrupt itself occurs while writing

In this case, I think the current code is already perfect and free of race conditions?

> The 2nd option is really mad, as our write() can also get interrupted by another write(). For example if the buffer is full and we empty it, it doesnt mean right after that an interrupt fills it again. The only way to work around this is to completely disable interrupts in write() and possibly other functions(flush, etc.).

Agreed (except I do not think this is "mad", it is something users might expect to just work).

```
while(bit_is_set(*_ucsra, UDRE0));
_tx_udr_empty_irq();
```

I'm not sure where you envision this code exactly. Could you provide a larger snippet to show where this code will go?


@protonspring
Andy Grant has already mention all relevant points. You should go on to another topic and perhaps returns later (at least a half year) with a fresh mind. Sometimes you get a new idea or come to the conclusion there is not enough potential (you need on average about 1.6 elo gain). I had done for my very first idea the same error until i stopped by a maintainer (and had back then no success).

Please be kind and use resources wisely.
So i approve this test but that is the last one on this sorting topic from you for the next time i will approve.

Good luck!


When i use you code, the error comes like below:
p = subprocess.Popen(['unoconv', '--stdout', input_filename], stdout=subprocess.PIPE)
  File "C:\Python27\lib\subprocess.py", line 710, in __init__
    errread, errwrite)
  File "C:\Python27\lib\subprocess.py", line 958, in _execute_child
    startupinfo)
WindowsError: [Error 2]

---can you help me,what's wrong with this,thank you very much!


Well, making content_buf as *content_buf would do the job fine.


It seems that `dev->` is missing on that line with setting retransmittion delay... and the name of the device structure is `nrf24l01_dev` and its defined in the main header file


Yes, the current code looks okay for this usecase.

My suggestion was:
```cpp
  // If the output buffer is full, there's nothing for it other than to
  // wait for the interrupt handler to empty it a bit
  while (i == _tx_buffer_tail) {
    if (bit_is_clear(SREG, SREG_I)) {
      // Interrupts are disabled, so we'll have to poll the data
      // register empty flag ourselves. If it is set, pretend an
      // interrupt has happened and call the handler to free up
      // space for us.
      while(bit_is_set(*_ucsra, UDRE0));
      _tx_udr_empty_irq();
    } else {
      // nop, the interrupt handler will free up space for us
    }
}
```


I have made a partial rollback to this commit, in 33f7bc3.

I also moved back the hashtab.h, lookupa.h and recycle.h because the README file for ERL mentions that the hash stuff are "globally exported". However, this library's main purpose is not to provide hash functions...


Ah, like that. It looks to make sense, though I'm not sure if there's real advantages. It might be slightly faster to respond to UDRE0 getting set, but this is only in the slow buffer-full case, where a few cycles are unlikely to make a difference. I suspect that the code might be bigger, but I'm not sure about that.


Hi Keisuke, I have tested all passed.


The theory is that if one build fails it's because of a problem with the code that will make the rest of builds fail anyway.

In practice, a build can fail for many other reasons, such as the download of a certain required package failing.

I'd leave this on anyway.


Could you kindly refrain from pushing solutions into this main repository? I opened to notebook to realize that it was filled with answers. The Udacity team could as well prevent students from committing into this central repo


__API Description file syntax error on line 180__: the use of tab(s) '\t' in source data isn't currently supported, please contact makers (Autogenerated message from apiary.io)


https://www.zhihu.com/question/26911239 @zhxing001


People who depend on appveyor builds for kvirc are left hanging because of a change that has no benefits to the project only for the build servers.

At least disable Debug builds because they are broken anyway.


Oh that hurt, it was so much work and pain to get this thing it working.  But 👍


Note though that Lean currently has issues with instance arguments in classes (I think I showed you the problem in Cambridge). The projections and constructor add the instance argument as an explicit IIRC.


Allora ti piace proprio!!! 😄


As duthils suggested


@ianfab
For two month i tried nearly the same but i changed StormDanger too. I tuned the values at 30+0.3 with 100000 games. STC passes fast but LTC failed yellow:

STC: http://tests.stockfishchess.org/tests/view/5940c9d10ebc59035df353ee
LTC: http://tests.stockfishchess.org/tests/view/5940de680ebc59035df353f2

Perhaps you have for luck!


Ugh, wrong message: "Save Baseplate" feature was implemented. Closes #23


`upload` right?


Why do the tests need to be run separately ?


'des américains se sont vus demandés' -> 'des américains se sont vus demander'


duplicate include

#include "KviTalHBox.h"

and
```
CMakeFiles/kvieventeditor.dir/EventEditorWindow.cpp.obj CMakeFiles/kvieventeditor.dir/libkvieventeditor.cpp.obj CMakeFiles/kvieventeditor.dir/kvieventeditor_autogen/moc_compilation.cpp.obj
   Creating library kvieventeditor.lib and object kvieventeditor.exp
moc_compilation.cpp.obj : error LNK2019: unresolved external symbol "protected: void __cdecl EventEditor::setCurrentHandlerEnabled(void)" (?setCurrentHandlerEnabled@EventEditor@@IEAAXXZ) referenced in function "private: static void __cdecl EventEditor::qt_static_metacall(class QObject *,enum QMetaObject::Call,int,void * *)" (?qt_static_metacall@EventEditor@@CAXPEAVQObject@@W4Call@QMetaObject@@HPEAPEAX@Z)
kvieventeditor.dll : fatal error LNK1120: 1 unresolved externals
LINK Pass 1 failed. with 1120
NMAKE : fatal error U1077: '"C:\Program Files (x86)\CMake\bin\cmake.exe"' : return code '0xffffffff'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\nmake.exe"' : return code '0x2'
Stop.
Command exited with code 2
```
event editor is not building


subject is "les technologies modernes des médias"


doesn't fit in the button, and I think "tous" is unnecessary to understand the sentence


doesn't fit in the "Bac à Sable" tab


src for HsPFFP


Why did you change to skip in node and not in the browser?


for sure this broke builds https://ci.appveyor.com/project/DarthGandalf/kvirc/build/0.0.0.0.1-branch-master-build-2378


The NPM package includes all the front-end files.
The server implementations are only samples and not part of the plugin itself.
Which files are you missing that you think should be included?


You are doing awesome bro. Hats off for your work


What happen here? why street disappears? Nothing matchs with the docs here https://ionicframework.com/docs/native/native-geocoder/


Unclear but "pas à pas" seems more correct than "pas-à-pas"
( https://www.google.fr/search?oq="pas-à-pas"+cnrtl )


I cant understand these codes. Anyway, hats off for your great job.


rollback


Это все надо выносить в методы, т.е. внутри when должен быть вызов одного метода, в котором и будет логика действия. А если такой метод получается длинным, то разбивать еще на методы. В идеале, метод должен быть не более 10 строк


Ну во-первых, если у тебя есть сеттре, то его используют так: `train.route = route`. Во-вторых, чтобы ответить почему не работает, нужно больше информации - что именно не работает, какая ошибка в какой момент и т.д. Вариантов может быть много.


Ext4 is also case-sensitve. Do you use `HFS+` or APFS? `HFS+` does unicode normalisation.


Этот метод не вернет поезд, потому что метод each возвращает оригинальную коллекцию. Скорее всего, поэтому и не работает обращение `train.route`, т.к. у теб train - это массив получается. Тут нужно использовать метод select


Метод вернет опять массив станций, а не конкретную станцию, т.к. `each` возвращает оригинальную коллекцию. Используй метод `select`


Тут нужно сравнение на тип вагона. Это должен контроллировать сам класс Train, а не только внешний код. Вагон не того типа не должен добавляться


I'm sorry but the photo is either not uploaded or loading properly. Could you use `[imgur.com](https://imgur.com)`. You can upload photos with out having to sign up.


Так может просто убрать здесь условие `cars >= 0`? К чему оно?


Переменные не нужно инициализировать значением nil. Интерперетатор "просматривает" список всех переменных, которые используются в классе и инициализирует их значением nil автоматически. Поэтому просто используй их, где это нужно, считай, что ruby уже проинициализировал их.


Скобки у условий в ruby обычно не ставятся


Сначала установи эту переменную, а потом используй метод `current_station`, чтобы добавить поезд на нее, вместо обращение к `route.stations[0]`


@lucasart: there is one problem with statistics - nobody ever proved that 95% confidence interval is the best choice. Statistics is an open field, and investigations in statistics are welcome by me. But, I tried to explain to GuardianRM that fishtest is not the right place for his investigations. Marco also pointed his reasons, and I expect that this kind of testing will stop.


Используй метод `current_station` для обращения к текущей станции, затем меняй индекс и снова обращайся к `current_station`, т.к. она вернет уже новую станцию


OK, i will continue in that later


![](https://github.trello.services/images/mini-trello-icon.png) [Basic CSS3 Style setup](https://trello.com/c/USVIT7gw/8-basic-css3-style-setup)


NaN calculation result cause the /hierarchical-clustering/ error


Returns ticket no. when getTicketNo() function is called. Guys please check this.


Initializing the variables for the constructor. @BijayaBasnet @binsub


Thank you


looks good to me


well done


There was no typecast issues and this fix was not necessary but anyway it's a good practice.


@Procrat GTD puts a calendar at its core, for things that have to be done at a certain moment and can only be done then (like appointments). Integrating with existing calendar applications (push and pull) is 'calendar functionality' to me ;-) . Calendar events are important for assembling a daily schedule, are often part of projects (e.g. thesis meetings), or can have associated tasks (e.g. prepare a meeting).


These are a left-over from transforming the C code into plain text. I'll remove them.


if possible, welcome to PR


@GuardianRM combo's are only allowed for [0,4] tests (parameter tweaks). This is a combo of [0,5] tests and that is not allowed. See also the comment of @mcostalba in the other combo thread.


@adarsh0806 I think this must be an error.  I was also looking for the latest version of the project and found this.  The `.ipynb` is also corrupted.


I was using some function which I then removed and it is no longer required. I'll remove it.


Also see [Issue 380](https://github.com/weidai11/cryptopp/issues/380).


Done!


@anonimal,

Small CMake change here. It is mostly superficial, and it should not affect you.


v


This commit is reverting changes to the send_nsca.c from commit https://github.com/NagiosEnterprises/nsca/commit/256abaf03ad0f5b892a697c8201438614f617c19
Was it intended?


Like this?

```c
static void discord_help_init()
{
  int dlen;
  char *df;
  // etc
}
```


@crystallite http://i.imgur.com/bHbce9r.jpg


bug：切换到歌词Tab时，画面应该立即滚动到当前歌词行。


Wow,it's more cool and lagging XD


for markdown image


Dead


Then you'll have #1479


ping @philipbelesky

As discussed: I did a `git grep` and _think_ this should be safe for `prev`: the main use of `Round.prev` is in availability, and also to limit which rounds are taken into account in standings. Since standings only uses preliminary rounds, it should make a difference there; for availability, the new definition is probably more correct.

It breaks `next` though, because the only place where `Round.next` is used is in the round advance, and we want to advance to the round immediately following. Since it's only used in one place, I think I'll just inline it.


I like how you remove the anchor link when it's the page the user is on - very intuitive. I would advise against using `target="blank"` here though, because you generally want to give the user the option to open in a new tab/window unless it would impact the user's experience on the previous page (for example, deleting data on a form). See [here](https://css-tricks.com/use-target_blank/) for more info.


Should be inside of your closing `body` tag above.


Deprecation of `Round.next()` is in d2337d321757c3c7ca8cf7c6a5d802bbb4373291.


Great job with your indenting!


I've never seen the `overline` value for `text-decoration` - just learned something new! You'll find as you go forward that using `border` vs. `text-decoration` is preferred for underlines/overlines because it allows for greater flexibility. For example, I could have this HTML structure:

```
<h1>
  <span>Some text</span>
</h1>
```

Even though the `h1` is a block element, I can style the `span` inside of the `h1` with a border bottom and that border line won't stretch the full length of the `h1`.


I need this feature :D
Any hope to see it merged this year?


I love this cat picture.


The movie dbset is also added in the dbcontext (IdentityModel) as we need to create new table for Movie in database


@amazhang :+1: :hamburger: :fries:


![](https://github.trello.services/images/mini-trello-icon.png) [I would like better error handling in the cron job](https://trello.com/c/aD4i4mDD/21-i-would-like-better-error-handling-in-the-cron-job)


![](https://github.trello.services/images/mini-trello-icon.png) [Set Slack webhook Url in Admin console](https://trello.com/c/lz36OgEh/25-set-slack-webhook-url-in-admin-console)


![](https://github.trello.services/images/mini-trello-icon.png) [Set VPN username and password from the Admin console](https://trello.com/c/WgGEIe5h/20-set-vpn-username-and-password-from-the-admin-console)


Removed the ```*.pyc``` and ```__pycache__``` files in 99f2db217c054ff98f7dfe6086f08fafc03e799e


> The video does not play here though, even after disabling uBO.

No issue to play the video here http://i.imgur.com/YxHubjO.png (confirmed [#p123282](https://forums.lanik.us/viewtopic.php?p=123282#p123282))

> I don't see the bab anti-blocker with your filter ...

My question was why the `bab-defuser.js` filter does not work in this case.
Thank you.


Verificação necessária, parabéns


Updated to add ::list() method with some basic parameters


Porque está printando o e-mail? é algum debug? creio que seja necessário revisar isso!


I'm not sure what's going on here... is all this needed for adapting *mime* lib header values to the types we're using (`CI ByteString`) ?


Aqui também está sendo printado, creio que no próximo commit seja necessário retira-la


Hi Leon,

Thank you for testing. I close the issue.


This Get command does not reference the stop, start or restart commands.


Yea I agree numpy isn't worth it; even if python is slower the data set is small enough that performanec shouldn't be an issue.

It would be a 'nice to have' feature as I think those motion stats pages are a chance where the software can show off to a certain extent. I might see if Viran is interesting in contributing a base algorithm if he has time, or I could (on the back burner) try and give myself a crash course in interpreting matrix operation formula.


Resolves #3


Initial files


Why is that?


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/de742651-8462-4286-b78d-3e94ac013f9f "compromisos"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/0d0e8b6d-930b-40fc-ac1c-2a7d8ad5ef0b "compromisos") deployed [compromisos](https://github.com/eschuler7/compromisos/releases/tag/deploy-ibm-yp-us-south-eschuler-pe.ibm.com-dev-20170828-005151 "deploy-ibm-yp-us-south-eschuler-pe.ibm.com-dev-20170828-005151") to [dev](https://console.bluemix.net/apps/6f3a0e56-815a-41fc-aa5f-5ec09678068d?env_id=ibm:yp:us-south "ibm:yp:us-south:eschuler@pe.ibm.com:dev"), including this commit


This should take care of issue #1


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/de742651-8462-4286-b78d-3e94ac013f9f "compromisos"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/0d0e8b6d-930b-40fc-ac1c-2a7d8ad5ef0b "compromisos") deployed [compromisos](https://github.com/eschuler7/compromisos/releases/tag/deploy-ibm-yp-us-south-eschuler-pe.ibm.com-dev-20170828-005621 "deploy-ibm-yp-us-south-eschuler-pe.ibm.com-dev-20170828-005621") to [dev](https://console.bluemix.net/apps/6f3a0e56-815a-41fc-aa5f-5ec09678068d?env_id=ibm:yp:us-south "ibm:yp:us-south:eschuler@pe.ibm.com:dev"), including this commit


I would make this into a for loop and add this as an if condition.


I would break apart this method into smaller helper methods to make this more readable and not such a big method.


Resolves #8.


There's a fastqc flag(s) that can do what you do here directly. I think it's `--no-zip` and `--output`? check `--help`


Hello Sultan, I noticed this https://github.com/aviraxp/ONEPLUS_MSM8994_KAWORI/commit/ff13dd5ed337974e0a01c0fd30fab3b9d630e72c. This patch is "lockless listeners" which contains 17 patches, and LOS just picked the last one. I am sure there is some race conditions with only this commit.


看了一下代码, 貌似有一个bug ..

+        return float(datetime.datetime.now() - x1)
貌似应该是
        return float(datetime.datetime.now() - __time1)


The issue is probably here, do you mean `out/{sample}_bismark....`?


This rule can take a `context` param, and be called 3 times. I.e. abstract away the `CXX` with `{context}` and snakemake will automatically figure it out.


This rule has confused me, try commenting it out and using the actual output paths directly in the all rule


Nice! I would never test attributes in the real world, but it is good practice for getting used to RSpec


I'll try removing it, I think this was there temporarily, it shouldn't be necessary anymore.


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/de742651-8462-4286-b78d-3e94ac013f9f "compromisos"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/0d0e8b6d-930b-40fc-ac1c-2a7d8ad5ef0b "compromisos") deployed [compromisos](https://github.com/eschuler7/compromisos/releases/tag/deploy-ibm-yp-us-south-eschuler-pe.ibm.com-dev-20170828-010542 "deploy-ibm-yp-us-south-eschuler-pe.ibm.com-dev-20170828-010542") to [dev](https://console.bluemix.net/apps/6f3a0e56-815a-41fc-aa5f-5ec09678068d?env_id=ibm:yp:us-south "ibm:yp:us-south:eschuler@pe.ibm.com:dev"), including this commit


like
`boolean tabletSize = getResources().getBoolean(R.bool.isTablet);` ?
(just found that on stackoverflow)


Seems Chrome requires a service worker to allow it to properly handle its webapps but I don't know how to do this yet so only Microsoft support works as of now.


Thanks, I see now that I shouldn't have written containers those two times. I am still just seeing a white screen when I run yarn though. The only error, besides a bunch of warnings in the console, is:
browser.js:47 Uncaught Error: You must pass a component to the function returned by connect. Instead received undefined
    at invariant (browser.js:40)
    at wrapWithConnect (connectAdvanced.js:101)
    at Object.<anonymous> (VideoTextBoxContainer.js:18)
    at __webpack_require__ (bootstrap e1ca68ddff6dfcefea12:555)
    at fn (bootstrap e1ca68ddff6dfcefea12:86)
    at Object.<anonymous> (App.js:11)
    at __webpack_require__ (bootstrap e1ca68ddff6dfcefea12:555)
    at fn (bootstrap e1ca68ddff6dfcefea12:86)
    at Object.<anonymous> (index.js:3)
    at __webpack_require__ (bootstrap e1ca68ddff6dfcefea12:555)

Do you know understand what went wrong here?
Thanks,
Keenan


Just saw your 2nd comment. Everything works now! Thanks.


Ah yes, sorry my fault.  Just retag and release it.


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/de742651-8462-4286-b78d-3e94ac013f9f "compromisos"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/0d0e8b6d-930b-40fc-ac1c-2a7d8ad5ef0b "compromisos") deployed [compromisos](https://github.com/eschuler7/compromisos/releases/tag/deploy-ibm-yp-us-south-eschuler-pe.ibm.com-dev-20170828-011718 "deploy-ibm-yp-us-south-eschuler-pe.ibm.com-dev-20170828-011718") to [dev](https://console.bluemix.net/apps/6f3a0e56-815a-41fc-aa5f-5ec09678068d?env_id=ibm:yp:us-south "ibm:yp:us-south:eschuler@pe.ibm.com:dev"), including this commit


Version analysis for protocol definitions in this commit:

## Diffs

### `S_EACH_SKILL_RESULT` 2 => 3
```diff
--- a/protocol/S_EACH_SKILL_RESULT.2.def
+++ b/protocol/S_EACH_SKILL_RESULT.3.def
@@ -1,7 +1,5 @@
-# Protocol version 319256 or later
-
 uint64 source
-uint64 id0 # 0 or projectile owner id
+uint64 owner # If non-zero, then source is a projectile and this is the actual source
 uint64 target
 uint32 model
 uint32 skill
@@ -10,7 +8,6 @@
 uint32 id
 int32  time
 uint32 damage
-uint32 damage2 # Need to test if the client actually interprets HP as 64 bits - ignore for now
 uint16 type
 uint16 type2
 uint16 crit
```


xa! loh.


![](https://github.trello.services/images/mini-trello-icon.png) [MODELO DE PRODUCTOS Y MIGRACIÓN DE DATOS](https://trello.com/c/NLMwvsNP/48-modelo-de-productos-y-migraci%C3%B3n-de-datos)


Yes, just got rid of the {}.


Can you push tags on next release?
If you can push tags, I'm happy to read easily diffecence of codes.


well done


The intention for the code here was to ensure that a `100%` progress bar gets printed out even if we run fewer steps than requested. Is that the case? Or do you see the progress bar just suddenly stop at e.g. 40%?


遍历范围改成一半了，排名没动，估计前面一堆查表的

2017-08-25 20:21 GMT+08:00 Lst0621 <notifications@github.com>:

> for(int j = 1; j < i; j++)
>
> 根据对称性，遍历一半就可以了
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/moaiweishui/leetcode/commit/60b59d69b5721521a6a1f205003f978852df560e#commitcomment-23869633>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AZFKe_qjQMDd4WWn5AWi8ldSTWN3p6Bgks5sbrxHgaJpZM4PClzY>
> .
>


Hi,
i face an error with 4.11.0 kernel ! i can not monitoring!
can you please help me
tnx
Sid
![unbenannt](https://user-images.githubusercontent.com/31395337/29756078-12d4a27e-8ba1-11e7-948b-416c954b25fa.JPG)


Oy, stop violating PEP8.


ERROR: [PMD-CPD] 46 lines duplicated.
app/src/main/java/com/framgia/fsalon/screen/billcustomer/BillCustomerPresenter.java


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/de742651-8462-4286-b78d-3e94ac013f9f "compromisos"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/0d0e8b6d-930b-40fc-ac1c-2a7d8ad5ef0b "compromisos") deployed [compromisos](https://github.com/eschuler7/compromisos/releases/tag/deploy-ibm-yp-us-south-eschuler-pe.ibm.com-dev-20170828-013656 "deploy-ibm-yp-us-south-eschuler-pe.ibm.com-dev-20170828-013656") to [dev](https://console.bluemix.net/apps/6f3a0e56-815a-41fc-aa5f-5ec09678068d?env_id=ibm:yp:us-south "ibm:yp:us-south:eschuler@pe.ibm.com:dev"), including this commit


Why do you need to enable my NPARAM re-calculation code?
It seems run_asl_compiler() takes care of sanity checking parameters of Do rather than parameters of run_asl_compiler(), thus it requires unmodified NPARAM.

IMO, it will be good to cleanup sanity check of run_asl_compiler() (find usage() invocation in it), but surely you will need to move some sanity check logics from run_asl_compiler() to a new position prior than invoking run_asl_compiler().


update config


Java01 -  石朋  - https://github.com/pengshipku/shipeng.git


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/de742651-8462-4286-b78d-3e94ac013f9f "compromisos"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/0d0e8b6d-930b-40fc-ac1c-2a7d8ad5ef0b "compromisos") deployed [compromisos](https://github.com/eschuler7/compromisos/releases/tag/deploy-ibm-yp-us-south-eschuler-pe.ibm.com-dev-20170828-014148 "deploy-ibm-yp-us-south-eschuler-pe.ibm.com-dev-20170828-014148") to [dev](https://console.bluemix.net/apps/6f3a0e56-815a-41fc-aa5f-5ec09678068d?env_id=ibm:yp:us-south "ibm:yp:us-south:eschuler@pe.ibm.com:dev"), including this commit


Why do you need to remove OPT=x?
If you do want to do this, you should do this in a separate patch rather than merging this single change into the makefile cleanups.


Version analysis for protocol definitions in this commit:

## Diffs

### `S_INSTANT_DASH` 1 => 2
```diff
--- a/protocol/S_INSTANT_DASH.1.def
+++ b/protocol/S_INSTANT_DASH.2.def
@@ -1,7 +1,6 @@
 uint64 source
-uint32 unk1 # always 0?
-uint32 unk2 # always 0?
-uint32 unk3 # always 0?
+uint64 target
+uint32 unk # always 0?
 float x
 float y
 float z
```


Not necessary


ADEMAS SE ARREGLO LA MIGRACION DE REQUISICIONES CAMBIANDOLE EL TIPO DE "BEIENES" A "BIENES" COMO DEBERIA DE SER


IMO, we should:
install_n32_plus:
  $(MAKE) __install ASLTS_AMLDIR=nopt/64 ASLTS_ASLFLAGS="-oa -r 2"  ASLPLUS=1
install_n32_minus:
  $(MAKE) __install ASLTS_AMLDIR=nopt/64 ASLTS_ASLFLAGS="-oa -r 2"  ASLPLUS=0

Rather than using the special name "target" here.
"target" is a special Makefile terminology and shouldn't be messed up.


Comment 작성


the answer is no, no you don't


no, I copied the zlib source into the project (see previous commit in this branch). The ruby 2.0 to 2.3 devkit-mingw64-* from rubyinstaller doesn't come with zlib (don't bother with railsinstaller, it doesn't add anything useful)

It can't be merged as is, as it will potentially break on other platforms (using the bundled zlib.h but linking to system zlib library). This was just a prototype of how to make it work.


Much simpler than previous, but still I have concerns.
It seems we should move aslversion generation from Makefile to "Do".

See:
Do takes care of our test entry, and aslversion is a part of what is generated in the test, determining the location of the test binaries.
So determining it is a part of the job of "Do", while for "makefiles", they only need a output directory passed from "Do", and aslversion is just a part of the directory name.


I didn't really want to modify the Makefile from libxlsxwriter because then the sync task will break it, but I couldn't see another way to tell it where to find zlib.a


そうですね、不完全なことは自分でも理解はしているので何かしら対応はしておくつもりです。
(自分でも忘れないようにとりあえずissue立てておきます）


定数にするのは自分でも悩んで名前をつけれず終わってしまったのでもう少し考えてみます…。


わかりました、変更しておきます。ありがとうございます。


You do 2 transfers here. You should try to avoid communicating with > 1 third party per function, as you are giving up control every time you call transfer. Instead, the split function should just do some accounting (i.e update a balances mapping). And for the actual transfer, perhaps create a separate function, where a sender can call and get their funds. This way you only talk to 1 third (untrusted) party at a time.


Nice


阿王可以的


Я видел это (и цвет оттуда взял). Но так неинтересно.


dd


I will try after work today, to initialize hyper.py,  I think I would probably spend days, to figure out that I need to replace config :) Thanks !
What do you you mean check point 3, like testing IZNN network or replacing config ?


@mixed
넵 일단 정상 동작하는 부분만 따로 커밋해서 올렸는데 밤 늦게라도 추가 커밋 하겠습니다.


It's somewhat interesting as an experiment but it's for sure not commitable with current fishtest rules.


@nfeske: for you


Upper cases are IMHO normally used for `static final` variables only and not for `final` object instance relevant members.


Same for the other three occurrences.


WARNING: [ContentDescription] [Accessibility] Missing `contentDescription` attribute on image
 Non-textual widgets like ImageViews and ImageButtons should use the `contentDescription` attribute to specify a textual description of the widget such that screen readers and other accessibility tools can adequately describe the user interface.

Note that elements in application screens that are purely decorative and do not provide any content or enable a user action should not have accessibility content descriptions. In this case, just suppress the lint warning with a tools:ignore="ContentDescription" attribute.

Note that for text fields, you should not set both the `hint` and the `contentDescription` attributes since the hint will never be shown. Just set the `hint`. See http://developer.android.com/guide/topics/ui/accessibility/checklist.html#special-cases.


WARNING: [RtlHardcoded] Consider adding `android:layout_alignParentEnd="true"` to better support right-to-left layouts
 Using `Gravity#LEFT` and `Gravity#RIGHT` can lead to problems when a layout is rendered in locales where text flows from right to left. Use `Gravity#START` and `Gravity#END` instead. Similarly, in XML `gravity` and `layout_gravity` attributes, use `start` rather than `left`.

For XML attributes such as paddingLeft and `layout_marginLeft`, use `paddingStart` and `layout_marginStart`. *NOTE*: If your `minSdkVersion` is less than 17, you should add *both* the older left/right attributes *as well as* the new start/right attributes. On older platforms, where RTL is not supported and the start/right attributes are unknown and therefore ignored, you need the older left/right attributes. There is a separate lint check which catches that type of error.

(Note: For `Gravity#LEFT` and `Gravity#START`, you can use these constants even when targeting older platforms, because the `start` bitmask is a superset of the `left` bitmask. Therefore, you can use `gravity="start"` rather than `gravity="left|start"`.)


This is final and equal for every class instance, so add `static`.


You better ask here : https://github.com/pyserial/pyserial
and replace the 'serial' directory with a version that work on XP. Cannot help more, don't own a computer with XP...


Thanks @pablrod , that is super helpful.


Remove


typo


刚看到源码里面有个说明
```c
/* WARNING: Beware that this is linear in the number of outstanding
 * requests! You are probably far better off just calling ares_process()
 * once per second, rather than calling ares_timeout() to figure out
 * when to next call ares_process().
 */
```
因为每个channel里面最多只有两个请求，所以应该也不会有大影响