While running the code, when you set zero-conf to 10 EUR (under Machine settings / cash out), set the sms threshold to 20, and do a 30 USD cash out, it doesn't complete the tx. In the console it prints:

```
2017-08-24T20:33:35.499Z LOG new brain state: pendingIdle
2017-08-24T20:33:35.500Z LOG new brain state: chooseCoin
2017-08-24T20:33:41.534Z LOG new brain state: chooseFiat
2017-08-24T20:33:45.571Z LOG DEBUG: REGISTER PHONE, current state:  chooseFiat
2017-08-24T20:33:45.572Z LOG new brain state: registerPhone
```


It is a feature.


Reverted as changes were not due to recipe fix but in small differences that do not reflect anything


In `Julia`, the type of a mixed list (i.e. [1,"a", true]) would be `Any`. However, for `Any` now, running the function is a little bit slow.


149092157-AERC_updates_to_BSDF (vidanovic) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1529 of 1530 tests passed, 0 test warnings)

Failures:

EnergyPlusFixture Test Summary
 * Passed: 521
 * Failed: 1

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.93%25-yellow.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-39.25%25-green.png)


See my original comment. Swap `parameters.get("enabled").equals("false")` -> `"false".equals(parameters.get("enabled"))"`. Otherwise if parameter `enabled` is absent (which is quite possible) you'll get a NPE.


@nickm319

Since mpi/storage_policy.h is essentially a copy of legion/storage_policy.h, do you think we should consolidate them into one?


No pending explicit migrations.


The following doc(s) have been deployed to the [composer](https://composer-static-docs.pantheonsite.io/docs) Multidev environment:
- [/docs/composer-json](https://composer-static-docs.pantheonsite.io/docs/composer-json)
- [/docs/guides/build-tools](https://composer-static-docs.pantheonsite.io/docs/guides/build-tools)
- [source/docs/assets/images/pr-workflow/github-pr-diagram.png](https://github.com/pantheon-systems/documentation/commit/6f3148691a50e5b434463e38af9a3402b34ea153/source/docs/assets/images/pr-workflow/github-pr-diagram.png)
- [/docs/agency-tips](https://composer-static-docs.pantheonsite.io/docs/agency-tips)
- [/docs/composer-drupal-8](https://composer-static-docs.pantheonsite.io/docs/composer-drupal-8)
- [/docs/custom-upstream](https://composer-static-docs.pantheonsite.io/docs/custom-upstream)
- [/docs/guides/build-tools](https://composer-static-docs.pantheonsite.io/docs/guides/build-tools)
- [/docs/guides/build-tools/extend](https://composer-static-docs.pantheonsite.io/docs/guides/build-tools/extend)
- [/docs/guides/sendgrid](https://composer-static-docs.pantheonsite.io/docs/guides/sendgrid)
- [/docs/nested-docroot](https://composer-static-docs.pantheonsite.io/docs/nested-docroot)
- [/docs/wordpress-best-practices](https://composer-static-docs.pantheonsite.io/docs/wordpress-best-practices)
- [/docs/wordpress-redis](https://composer-static-docs.pantheonsite.io/docs/wordpress-redis)


Still, whether is for plotting bottom, water depth, orvelocities, I doubt that there would always be a significant median values. For me it is obvious that the default colormap should sequential and not divergent... As I said in the previous comment, the divergent colormaps are rather unnecessary for current applications. I'm not that strongly opposed to putting rainbow colors as one of the options, but still I disagree with these as default option.


@dhilipkumars no, I did not run into any errors when installing the chart directly.


@NoctuaNivalis: Wouldn't you get tired of having to write out everything every time and remember the exact phrasing? I'm asking because that was my experience with similar CLI tools, like TaskWarrior. I notice that even people who normally use the terminal for most of what they do, reach for TUI/GUI tools for interacting with Git as well.
Drawings are certainly welcome! :smile:

@iasoon: You can already use Eva as a library. :wink: The question was actually intended as: what kind of UI should I be focussing on first to make Eva attractive for a lot of people?

@Silox: Awesome! I'll have a look at them ASAP!


Can you elaborate on this comment, please?


N.B cc-wrapper conditionally adds ld flags, without `-Wl,` here


N.B. `hardeningLDFlags` unconditionally added here, even if it was already added in cc-wrapper itself. See comment below.


Thanks for the Polybar GPU module! haha


INVALID_HANDLE_VALUE is not a valid HMIDIIN value. Hence this code does not compile with `STRICT` defined (which is the default these days).


Final output from the pipeline.


I noticed that if one is compiling and linking in one step (no `-c` flag to `cc`), then the hardening ld flags are passed twice. I'd think either they'd just be passed to ld, or they'd be passed to `cc` and guarded in `ld-wrapper` under `LDFLAGS_SET`. Is this intended?


@strk , thanks for this test. It will make upgrades much safer.


Should probably be `apiData->message` instead of `message`, does not compile.


Are you certain that `snippets/handle_bluekenue_files.py` is not commited by mistake? Or do you plan to add more code and documentations on the snippets forlder?


Maybe is better to create an issue template, so il will be more evident (example:
https://github.com/AuroraWright/Luma3DS/blob/master/.github/ISSUE_TEMPLATE.md

https://github.com/Robz8/TWLoader/tree/master/.github)


yes I had a few bugs that I caught later (missing labels)
why the spaces have to be removed from end e.g. line 40?


Why are we removing the device in the first place?


Updated isocurvature test to use fiducial planck params, but modulo a lower mass axion and half and half axion and CDM breakdown


See ceylon/ceylon#7220.


Ignore demo script failure for fork PRs (#3390)

Demo: quicktests | fiddle


Added Pull


I'm guessing @gicmo thought it had to be removed/added to be updated.


It is possible to replace:

`*/blockadblock.$script,redirect=fuckadblock.js-3.2.0`
by
`*/blockadblock.$script,domain=~blockadblock.com,redirect=fuckadblock.js-3.2.0`

or

`@@/blockadblock.$script,domain=blockadblock.com`
by
`@@/blockadblock.$script,firstparty,domain=blockadblock.com`

Thank you.


That's just my editor (Atom) - it removes trailing spaces.


Why this values instead of the usual 6/25?


Just a gentle reminder to kindly update this to `google-i18n-address==2.0.2` so it becomes Windows compatible. Thanks <3


Remove this if you don't have anything for it.


UNTESTED:
Digitial Ocean took my test server offline (jerks) for no good reason. Currently fighting with their non-existent support team.... In the meantime, I am setting up a new dev server, which is taking a while. Code pushed to this branch will remain untested until I can have access to such a remote server with email capabilities.


i think we also need #define BT_HOST_IPC_ENABLED


We'll actually do this differently in CP 10, but this is fine for now - although your premium users should be able to see private wikis.


associating with #2


Also, I don't think you really want this to be an instance method, and you shouldn't have to pass @wikis into it


So to actually call this, you would just say:

```
Wiki.public_wikis
```
I would probably rename it to just `public`


This really isn't doing anything atm, but it will in CP 10


I prefer `unless` to `if !`


We shouldn't duplicate the restore logic in this script. If we need a special path to limit to just the component then it should be an additional paramter, but honestly I don't think we even need that. We should just do it with all the tools.


Why wouldn't this just be another PackageReference? Or even better a reference in the inner BuildTools tool-runtime?


Nitpick - it would be `To`, not `Too`


`tf.image.crop_to_bounding_box` ? :)


I actually had a patch
https://github.com/vondele/Stockfish/commit/d218cd56efaf4e0196df62c362b4200e12d75a4c#commitcomment-23853647
that may have turned out differently if promotions were not broken.
The other option(not my vote) seems would be to remove enpassant so that at least our SEE is consistent when it comes to handling special move types.


Is this just a placeholder?


Nice!
The idea was to decouple queue runners from each other. But I think we can refactor in the way you suggest. However you should extract separate class with same logic as in externalExecutorRunner and delegate other runners implementation to it. Because now documentation of external executor runner is misleading and I still want separate queueRunner for each of the processing modes.


See PR https://github.com/NixOS/nixpkgs/pull/28552.


Wow this is awesome well done ✅


149092157-AERC_updates_to_BSDF (vidanovic) - x86_64-MacOS-10.9-clang: OK (2738 of 2744 tests passed, 23 test warnings)

Messages:

 * 29 tests had: EIO diffs.
 * 22 tests had: ESO small diffs.
 * 19 tests had: Table small diffs.
 * 6 tests had: MTR small diffs.
 * 6 tests had: ESO big diffs.
 * 1 test had: SSZ big diffs.
 * 1 test had: ZSZ big diffs.
 * 1 test had: MTR big diffs.
 * 2 tests had: ZSZ small diffs.

Failures:

regression Test Summary
 * Passed: 600
 * Failed: 6

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.png)


Created multidev environment [dgreat#pr-cog](https://dashboard.pantheon.io/sites/41cad7fe-472d-43a9-a470-d391b9622376#pr-cog).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-cog-dgreat.pantheonsite.io/)


This needs to be done via LegacyIndexDefinition I think


This method is used when an instructor adds a user by their username, so we don't want to include real_name in this case. Part of the purpose behind this issue is to prevent a user from getting access to the real name of another user when they shouldn't have access to it.


My thinking was (a) with darker colors there's less contrast with the black text, making it harder to read, and (b) the colors are not actually conveying particularly important information. Number of assignments is already clearly visible on the page; the colors just serve to call attention subtly to more or less busy days. To me, the more intense colors are a bit jarring.

Of course, there's no "right answer," so feel free to change if you'd like. But just as a heads up, I may end up changing certain interface elements again in response to feedback from teachers!


I think it is always true for safe checks (except if the square is also protected by another unpinned pawn, which can be checkd with another test).

However it would not be accurate for kingOnlydefended or undefended

e.g Qg6 against g7 and Kg8. Squares h6 and f6 should not be considered undefended (at least for the pinner  !)


[tests/testthat/test-spelling.R:7:1:](https://github.com/PredictiveEcology/quickPlot/blob/96a5ab6fbd6305faaa7e3e5bff743e1fa6e1a350/tests/testthat/test-spelling.R#L7) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test-spelling.R:11:1:](https://github.com/PredictiveEcology/quickPlot/blob/96a5ab6fbd6305faaa7e3e5bff743e1fa6e1a350/tests/testthat/test-spelling.R#L11) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test-spelling.R:17:1:](https://github.com/PredictiveEcology/quickPlot/blob/96a5ab6fbd6305faaa7e3e5bff743e1fa6e1a350/tests/testthat/test-spelling.R#L17) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test-spelling.R:21:1:](https://github.com/PredictiveEcology/quickPlot/blob/96a5ab6fbd6305faaa7e3e5bff743e1fa6e1a350/tests/testthat/test-spelling.R#L21) *style:* **Trailing whitespace is superfluous.**
```r

^~
```
[tests/testthat/test-spelling.R:25:1:](https://github.com/PredictiveEcology/quickPlot/blob/96a5ab6fbd6305faaa7e3e5bff743e1fa6e1a350/tests/testthat/test-spelling.R#L25) *style:* **Trailing whitespace is superfluous.**
```r

^~
```


Probably, I wanted to get rid of the failing test that this caused for now


Commit :100:  for me :)


Hi back atcha


No need to include real_name here; the combination of user/course/role is unique (and enforced with a database constraint). The `User`'s real name may also differ from the `CoursesUsers` real name (for example, if the latter is `nil`).


This is a "brute force" PowerShell script - meaning there are lots of opportunities to clean it up, make it more efficient, etc.  There are some things that are in there for debugging purposes.  This is the version of the script that is being used as of Aug 24, the day the system first went live sending automated updates to subscribers.


This is fine, but for informational purposes, the EAS protocol explicitly states the format must contain 2 digits.


Instead of adding this method the CoursesUsers model, this should just be added to a new file in db/cleanup (which is for one-off scripts that we want to document in the code base but don't plan to run again after they are used).

If this was staying on CoursesUsers, you'd want to make it a class method rather than an instance method.


Hm, I tried `*/blockadblock.$script,domain=~blockadblock.com,redirect=fuckadblock.js-3.2.0`
before I made this commit and the redirect does not work on my end, the request gets blocked.
To reproduce go to `dawn.com` with default settings.
![dawn](https://user-images.githubusercontent.com/16838044/29689182-8adde766-8922-11e7-8966-c410803774df.PNG)

Now disable `uBO-filters`, add your filter
`*/blockadblock.$script,domain=~blockadblock.com,redirect=fuckadblock.js-3.2.0`
and reload.
![dawn1](https://user-images.githubusercontent.com/16838044/29689327-204b4780-8923-11e7-89a4-b8c1d2a7ea26.PNG)


Unfortunately late, but thanks for the comment @kpengboy. It was pretty naive to assume that the no one had already thought to update the cron job after the `prune` command came out. It's unfortunate the command is so limited in its options though. I agree with you and @chriskuehl on what to do.


You can default this to `nil`, so that no `real_name` parameter needs to be passed from places that don't use it (like `UsersController`, and `MassEnrollmentController` for now).


Also, I remembered about deleting old cron jobs after last night's emails; I'll just purge them with a single puppet trigger on my own environment.


Created multidev environment [build-tools-638#ci-1](https://dashboard.pantheon.io/sites/bda3ce56-218d-4f55-8f1a-a52ed6ce7066#ci-1).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-1-build-tools-638.pantheonsite.io/)


It not final values still experimenting, this values default for ccminer, cost some hashrate (311->300 on 1050Ti) but make Windows much more responsive.


> think I need to specify content-type headers in my requests

No you don't; `Content-Type` is a response header. You need to set the `Accept` header in your requests if you need to distinguish between data and metadata at data object endpoints (however, by default, it'll will just assume you want the data if you don't set the `Accept` header).

https://github.com/wtsi-hgi/irobot#using-the-accept-request-header


Maybe this can be done using a number of System::arraycopy calls


I don't think this is necessary. The factory can default to leaving it `nil`.


The term "safety" is somewhat confusing for this concept imo. AFAICT, it is referring to how safe it is to use the driver ("DriverSafety" makes me think if the driver itself is safe). Maybe the more general "state" or "serviceability" would be clearer.


Created multidev environment [build-tools-639#ci-1](https://dashboard.pantheon.io/sites/f037a71b-4212-419a-9fce-c0cd4ce56860#ci-1).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-1-build-tools-639.pantheonsite.io/)


That won't actually work, you can't cast array of object to another type that way.


You know what? We already have that feature:

```
Push(
    err,
    Push("database", "localhost:123"),
)
```

What is misleading, it's function name. Do we actually use `Push` anywhere?


AddressProblemUnitTests (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2784 of 2784 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


149092157-AERC_updates_to_BSDF (vidanovic) - Win64-Windows-7-VisualStudio-14: Tests Failed (2351 of 2750 tests passed, 134 test warnings)

Messages:

 * 532 tests had: EIO diffs.
 * 358 tests had: ESO big diffs.
 * 166 tests had: ESO small diffs.
 * 192 tests had: Table small diffs.
 * 85 tests had: SSZ big diffs.
 * 240 tests had: ZSZ big diffs.
 * 307 tests had: Table big diffs.
 * 157 tests had: SSZ small diffs.
 * 53 tests had: ERR diffs.
 * 51 tests had: MTR big diffs.
 * 60 tests had: MTR small diffs.
 * 55 tests had: ZSZ small diffs.

Failures:

EnergyPlusFixture Test Summary
 * Passed: 521
 * Failed: 1

regression Test Summary
 * Passed: 211
 * Failed: 398

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-85.49%25-red.png)


Please add the license for the new file added.

the build will fail in sanity https://builds.apache.org/blue/organizations/jenkins/incubator-mxnet/detail/master/236/pipeline/4


`@@/blockadblock.$script,first-party,domain=blockadblock.com`
 breaks disqus, because `http://blockadblock.disqus.com/embed.js` will be blocked


![](https://github.trello.services/images/mini-trello-icon.png) [Create MODBUS protocol for AVR Atmega 128](https://trello.com/c/hFxMSlPm/1-create-modbus-protocol-for-avr-atmega-128)


@sksamuel Why?


AddressProblemUnitTests (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


It looks like someone (@kriszyp) put the domain on Cloudflare at some point:

```
Domain:json-schema.org
Registrar:easyDNS Technologies Inc.
Registration Date:2007-11-20
Expiration Date:2017-11-20
Updated Date:2016-11-22
Status:clientTransferProhibited
clientUpdateProhibited
Name Servers:lara.ns.cloudflare.com
george.ns.cloudflare.com
```

@kriszyp if you did this could you turn on HTTPS through Cloudflare?  Contact me if you have questions (I work at cloudflare, my email is just henry at ...)


Congrats!


z


Oh, It has been deprecated. I'm fucked.


Hm, interesting. I have some local scripts for `cflow`. What were you doing here, @lithp?


@simon3z @zgalor Do you remember what this value vs serialized_value is about?
IIRC it was for very specific policies use case only on EMSes involving Date-valued custom attrs?

@Ladas pointed out this is our biggest table, so having extra column and serialization for only EMS is wasteful...


Sorry about that. I should have had all the ws stuff in `andres-ws`. Faux pas. I rebased `andres-ws` with all the ws specific changes on top of `andres-http-2`.


Got it. Thanks!


Thank you for your time.


AddressProblemUnitTests (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (2744 of 2744 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


@simon3z @zgalor this will change behavior with Ruby 2.4 unifying `Fixnum` into `Integer`.  Nobody knew if that's a problem or not here — can you figure that out, if you know what this serves for?


Created multidev environment [dgreat#pr-cog](https://dashboard.pantheon.io/sites/41cad7fe-472d-43a9-a470-d391b9622376#pr-cog).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-cog-dgreat.pantheonsite.io/)


why not use the mock from the previous line?


@rachmadaniHaryono this commit breaks a lot of test cases. Can you please take a look?


Relevant commit my guy


Could add that `_newOwner != 0`.


first commit


Ooh nice one, it is ok with acceptOwnership.


I don't think the `__` is necessary.


@msloes :+1:


dont put a curly bracket


maybe move userStore creation to test setup method


Fixes issue #260


Created multidev environment [wiegele#ci-60](https://dashboard.pantheon.io/sites/e5d4b65a-3be9-4852-bb2f-7b73d4f5eeaf#ci-60).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-60-wiegele.pantheonsite.io/)


contributes to issue #87, will add up to date events.mat from lab computer tomorrow


149092157-AERC_updates_to_BSDF (vidanovic) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2136 of 2141 tests passed, 0 test warnings)

Failures:

EnergyPlusFixture Test Summary
 * Passed: 521
 * Failed: 1

integration Test Summary
 * Passed: 607
 * Failed: 4

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.77%25-yellow.png) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-71.46%25-green.png)


Added more letters


149092157-AERC_updates_to_BSDF (vidanovic) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png)


Perhaps reuse code from `bind`.


In any case, you would have to make the state change before the transfer.


Oh and don't delete entirely because you want to prevent password reuse.


ArdiArtani Thanks For Your Hard Work
This is possible to change
this link => (https://lh3.googleusercontent.com) to => (https://3.bp.blogspot.com)
The lh3.googleusercontent.com link way not expire and this link was limit to watch.
And 3.bp.blogspot.com no limit fmovies gomives using this link.
can we change the link.
Again Thank For Your Hard Work.


Version analysis for protocol definitions in this commit:

## Diffs

### `S_SPAWN_DROPITEM` 1 => 2
```diff
--- a/protocol/S_SPAWN_DROPITEM.1.def
+++ b/protocol/S_SPAWN_DROPITEM.2.def
@@ -11,5 +11,6 @@
 int32  unk1
 int16  unk2
 uint64 mob
+byte   unk3
 array  owners
 - uint32 id
```


I think we should keep them separate. The partitioning and how we may need to change index spaces later with new features in Legion such as dependent partitioning where E,S,G get interleaved. There might also be a need for runtime-model-specific optimizations here too.

From: Li-Ta Lo <notifications@github.com<mailto:notifications@github.com>>
Reply-To: laristra/flecsi <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Thursday, August 24, 2017 at 2:51 PM
To: laristra/flecsi <flecsi@noreply.github.com<mailto:flecsi@noreply.github.com>>
Cc: First name Last name <nickm@lanl.gov<mailto:nickm@lanl.gov>>, Author <author@noreply.github.com<mailto:author@noreply.github.com>>
Subject: Re: [laristra/flecsi] Topology storage policy optimizations/cleanup. (5f5e2ea)

@nickm319<https://github.com/nickm319>

Since mpi/storage_policy.h is essentially a copy of legion/storage_policy.h, do you think we should consolidate them into one?

-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/laristra/flecsi/commit/5f5e2ea6fc536707585082c33c2d5dbb0e1e5afb#commitcomment-23855206>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGDI_Y6-tdMTOMb9ev_jApZ3hlbAIekfks5sbeJUgaJpZM4PB67s>.


Created multidev environment [badcamp-2017#pr-sponsor](https://dashboard.pantheon.io/sites/8d658997-7a61-4db8-9be8-0f16b8b62022#pr-sponsor).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-sponsor-badcamp-2017.pantheonsite.io/)


What about generating another type of Exception? It may make whitelisting easier?


AddressProblemUnitTests (Myoldmopar) - i386-Windows-7-VisualStudio-14: OK (2744 of 2744 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


Created multidev environment [dgreat#pr-cog](https://dashboard.pantheon.io/sites/41cad7fe-472d-43a9-a470-d391b9622376#pr-cog).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-cog-dgreat.pantheonsite.io/)


Indeed, we need the `Null` type in Base in order to deprecate `Nullable`.


Maybe.
However, I will not continue working on this in the near future.


We need libOpenCL
TODO: Bring it back


good


What does this do?


Seems reasonable to me. I'll look into it soon.


AddressProblemUnitTests (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1530 of 1530 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-38.31%25-green.svg)


We might still succeed by forking the project, applying the change manually in the code and then building the module from there, but it's not on my radar right now to spend time on that, especially seeing as how I can't really test it without a Windows development environment.


AddressProblemUnitTests (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Yes, I think DX / Refactoring changes should be in their own section (at the bottom). They're only relevant to contributors, wheras externally-visible changes might affect users.


its dead b/c you return unconditionally above


(i.e. this code is unreachable)


Why is this commit touching this?


[inst/examples/example_distanceFromEachPoint.R:37:2:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/inst/examples/example_distanceFromEachPoint.R#L37) *style:* **Commented code should be removed.**
```r
#beginCluster(3) # can do parallel
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/examples/example_distanceFromEachPoint.R:40:2:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/inst/examples/example_distanceFromEachPoint.R#L40) *style:* **Commented code should be removed.**
```r
#endCluster() # if beginCluster was run
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/examples/example_spread.R:54:2:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/inst/examples/example_spread.R#L54) *style:* **Commented code should be removed.**
```r
## Interrupt a spread event using iterations - need `returnIndices = TRUE` to
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/examples/example_spread.R:247:2:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/inst/examples/example_spread.R#L247) *style:* **Commented code should be removed.**
```r
## Note: `neighProbs = c(0,1)` forces each active pixel to move to 2 new pixels
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[inst/examples/example_spread.R:248:2:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/inst/examples/example_spread.R#L248) *style:* **Commented code should be removed.**
```r
## (`prob = 0` for 1 neighbour, `prob = 1` for 2 neighbours)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:243:3:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L243) *style:* **Commented code should be removed.**
```r
# ### INCORPORATE RELEVANT PARTS OF THIS OLD INIT FUNCTION INTO INITCOORDS()
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:248:3:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L248) *style:* **Commented code should be removed.**
```r
# #'                      (currently only \code{RasterLayer} or
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:249:3:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L249) *style:* **Commented code should be removed.**
```r
# #'                      \code{SpatialPolygonsDataFrame}) accepted.
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:259:7:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L259) *style:* **Commented code should be removed.**
```r
#     ext <- extent(agentlocation)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:261:9:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L261) *style:* **Commented code should be removed.**
```r
#       #            nonNAs <- !is.na(getvalue(probinit))
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:262:9:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L262) *style:* **Commented code should be removed.**
```r
#       nonNAs <- !is.na(getValues(probinit))
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:263:9:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L263) *style:* **Commented code should be removed.**
```r
#       wh.nonNAs <- which(nonNAs)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:264:9:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L264) *style:* **Commented code should be removed.**
```r
#       #            ProbInit.v <- cumsum(getvalue(probinit)[nonNAs])
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:265:9:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L265) *style:* **Commented code should be removed.**
```r
#       ProbInit.v <- cumsum(getValues(probinit)[nonNAs])
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:267:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L267) *style:* **Commented code should be removed.**
```r
#         ran <- runif(numagents,0,1)
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:268:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L268) *style:* **Commented code should be removed.**
```r
#         fI <- findInterval(ran, ProbInit.v)+1
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:269:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L269) *style:* **Commented code should be removed.**
```r
#         fI2 <- wh.nonNAs[fI]
          ^~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:270:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L270) *style:* **Commented code should be removed.**
```r
#         last.ran <- runif(numagents,0,1)
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:271:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L271) *style:* **Commented code should be removed.**
```r
#         last.fI <- findInterval(last.ran, ProbInit.v)+1
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:272:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L272) *style:* **Commented code should be removed.**
```r
#         last.fI2 <- wh.nonNAs[last.fI]
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:274:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L274) *style:* **Commented code should be removed.**
```r
#         #                va <- getvalue(probinit)[nonNAs]
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:275:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L275) *style:* **Commented code should be removed.**
```r
#         va <- getValues(probinit)[nonNAs]
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:276:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L276) *style:* **Commented code should be removed.**
```r
#         ran <- runif(length(va), 0, 1)
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:277:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L277) *style:* **Commented code should be removed.**
```r
#         fI2 <- wh.nonNAs[ran<va]
          ^~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:279:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L279) *style:* **Commented code should be removed.**
```r
#         last.ran <- runif(length(fI2), 0, 1)
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:280:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L280) *style:* **Commented code should be removed.**
```r
#         last.fI <- findInterval(last.ran, ProbInit.v) + 1
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:281:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L281) *style:* **Commented code should be removed.**
```r
#         last.fI2 <- wh.nonNAs[last.fI]
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:283:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L283) *style:* **Commented code should be removed.**
```r
#         #                last.ran <- runif(length(fI2),0,1)
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:284:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L284) *style:* **Commented code should be removed.**
```r
#         #                last.fI2 <- wh.nonNAs[last.ran<va]
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:287:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L287) *style:* **Commented code should be removed.**
```r
#         position <- xyFromCell(agentlocation,fI2,spatial = TRUE)
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:289:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L289) *style:* **Commented code should be removed.**
```r
#         position <- coordinates(agentlocation)
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:291:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L291) *style:* **Commented code should be removed.**
```r
#         stop("need raster layer or Spatial Points object")
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:293:9:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L293) *style:* **Commented code should be removed.**
```r
#       numagents <- length(position)
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:301:13:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L301) *style:* **Commented code should be removed.**
```r
#           colnames(xy) = c("x", "y")
            ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:302:13:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L302) *style:* **Commented code should be removed.**
```r
#           position <- SpatialPoints(xy)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:303:13:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L303) *style:* **Commented code should be removed.**
```r
#           position <- SpatialPoints(sampleRandom(agentlocation, numagents, xy = TRUE, sp = TRUE))
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:305:13:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L305) *style:* **Commented code should be removed.**
```r
#           sam <- sample(1:length(agentlocation),numagents)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:306:13:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L306) *style:* **Commented code should be removed.**
```r
#           position <- SpatialPoints(agentlocation[sam,])
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:308:13:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L308) *style:* **Commented code should be removed.**
```r
#           stop("need raster layer or Spatial Points object")
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:315:13:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L315) *style:* **Commented code should be removed.**
```r
#           position <- SpatialPoints(agentlocation)
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:317:13:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L317) *style:* **Commented code should be removed.**
```r
#           stop("need raster layer or Spatial Points object")
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:319:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L319) *style:* **Commented code should be removed.**
```r
#         numagents <- length(position)
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:327:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L327) *style:* **Commented code should be removed.**
```r
#         numagents <- length(position)
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:331:7:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L331) *style:* **Commented code should be removed.**
```r
#     stop("Need to provide agentlocation, which can be a map layer")
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:333:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L333) *style:* **Commented code should be removed.**
```r
#   heading1 <- runif(numagents, 0, 360)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:334:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L334) *style:* **Commented code should be removed.**
```r
#   distance <- runif(numagents, 0.1, 10)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:336:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L336) *style:* **Commented code should be removed.**
```r
#   .Object@ID <- as.character(1:numagents)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:337:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L337) *style:* **Commented code should be removed.**
```r
#   .Object@spatial <- position
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:338:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L338) *style:* **Commented code should be removed.**
```r
#   .Object@heading <- heading1
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:339:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L339) *style:* **Commented code should be removed.**
```r
#   .Object@distance <- distance
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/initialize.R:341:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/initialize.R#L341) *style:* **Commented code should be removed.**
```r
#   return(.Object)
    ^~~~~~~~~~~~~~~
```
[R/mapReduce.R:50:38:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/mapReduce.R#L50) *style:* **Variable or function name should be lowerCamelCase.**
```r
  fullRasterVals <- fullRasterVals[, row_number := 1L:.N]
                                     ^~~~~~~~~~
```
[R/mapReduce.R:53:3:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/mapReduce.R#L53) *style:* **Variable or function name should be lowerCamelCase.**
```r
  BsumVec <- reduced[fullRasterVals] # join
  ^~~~~~~
```
[R/neighbourhood.R:112:1:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L112) *style:* **Variable or function name should be lowerCamelCase.**
```r
adj.raw <- function(x = NULL, cells, directions = 8, sort = FALSE, pairs = TRUE,
^~~~~~~
```
[R/neighbourhood.R:114:21:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L114) *style:* **Variable or function name should be lowerCamelCase.**
```r
                    match.adjacent = FALSE, cutoff.for.data.table = 2e3,
                    ^~~~~~~~~~~~~~
```
[R/neighbourhood.R:114:45:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L114) *style:* **Variable or function name should be lowerCamelCase.**
```r
                    match.adjacent = FALSE, cutoff.for.data.table = 2e3,
                                            ^~~~~~~~~~~~~~~~~~~~~
```
[R/neighbourhood.R:117:3:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L117) *style:* **Variable or function name should be lowerCamelCase.**
```r
  J <- NULL
  ^
```
[R/neighbourhood.R:232:13:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L232) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          !((((adj[, "to"] - 1) %% numCell + 1) != adj[, "to"]) | # top or bottom of raster
            ^
```
[R/neighbourhood.R:232:14:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L232) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          !((((adj[, "to"] - 1) %% numCell + 1) != adj[, "to"]) | # top or bottom of raster
             ^
```
[R/neighbourhood.R:232:15:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L232) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          !((((adj[, "to"] - 1) %% numCell + 1) != adj[, "to"]) | # top or bottom of raster
              ^
```
[R/neighbourhood.R:233:1:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L233) *style:* **Lines should not be more than 100 characters.**
```r
              ((adj[, "from"] %% numCol + adj[, "to"] %% numCol) == 1)) # | #right & left edge cells, with neighbours wrapped
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/neighbourhood.R:233:16:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L233) *style:* **Place a space before left parenthesis, except in a function call.**
```r
              ((adj[, "from"] %% numCol + adj[, "to"] %% numCol) == 1)) # | #right & left edge cells, with neighbours wrapped
               ^
```
[R/neighbourhood.R:237:13:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L237) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          !((((adj[, "to"] - 1) %% numCell + 1) != adj[, "to"]) | # top or bottom of raster
            ^
```
[R/neighbourhood.R:237:14:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L237) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          !((((adj[, "to"] - 1) %% numCell + 1) != adj[, "to"]) | # top or bottom of raster
             ^
```
[R/neighbourhood.R:237:15:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L237) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          !((((adj[, "to"] - 1) %% numCell + 1) != adj[, "to"]) | # top or bottom of raster
              ^
```
[R/neighbourhood.R:238:1:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L238) *style:* **Lines should not be more than 100 characters.**
```r
              ((adj[, "from"] %% numCol + adj[, "to"] %% numCol) == 1)) # | #right & left edge cells, with neighbours wrapped
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/neighbourhood.R:238:16:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L238) *style:* **Place a space before left parenthesis, except in a function call.**
```r
              ((adj[, "from"] %% numCol + adj[, "to"] %% numCol) == 1)) # | #right & left edge cells, with neighbours wrapped
               ^
```
[R/neighbourhood.R:248:15:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L248) *style:* **Put spaces around all infix operators.**
```r
        numCol*(adj[whLefRig, "from"] - adj[whLefRig, "to"])
             ~^~
```
[R/neighbourhood.R:248:16:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L248) *style:* **Place a space before left parenthesis, except in a function call.**
```r
        numCol*(adj[whLefRig, "from"] - adj[whLefRig, "to"])
               ^
```
[R/neighbourhood.R:249:20:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L249) *style:* **Place a space before left parenthesis, except in a function call.**
```r
      whBotTop <- ((adj[, "to"] - 1) %% numCell + 1) != adj[, "to"]
                   ^
```
[R/neighbourhood.R:296:13:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L296) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          !((((to - 1) %% numCell + 1) != to) |  #top or bottom of raster
            ^
```
[R/neighbourhood.R:296:14:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L296) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          !((((to - 1) %% numCell + 1) != to) |  #top or bottom of raster
             ^
```
[R/neighbourhood.R:296:15:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L296) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          !((((to - 1) %% numCell + 1) != to) |  #top or bottom of raster
              ^
```
[R/neighbourhood.R:297:1:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L297) *style:* **Lines should not be more than 100 characters.**
```r
              ((from %% numCol + to %% numCol) == 1))# | #right & left edge cells, with neighbours wrapped
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/neighbourhood.R:297:16:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L297) *style:* **Place a space before left parenthesis, except in a function call.**
```r
              ((from %% numCol + to %% numCol) == 1))# | #right & left edge cells, with neighbours wrapped
               ^
```
[R/neighbourhood.R:313:15:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L313) *style:* **Place a space before left parenthesis, except in a function call.**
```r
            !((((to - 1) %% numCell + 1) != to) | ((from %% numCol + to %% numCol) == 1))
              ^
```
[R/neighbourhood.R:313:16:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L313) *style:* **Place a space before left parenthesis, except in a function call.**
```r
            !((((to - 1) %% numCell + 1) != to) | ((from %% numCol + to %% numCol) == 1))
               ^
```
[R/neighbourhood.R:313:17:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L313) *style:* **Place a space before left parenthesis, except in a function call.**
```r
            !((((to - 1) %% numCell + 1) != to) | ((from %% numCol + to %% numCol) == 1))
                ^
```
[R/neighbourhood.R:313:52:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L313) *style:* **Place a space before left parenthesis, except in a function call.**
```r
            !((((to - 1) %% numCell + 1) != to) | ((from %% numCol + to %% numCol) == 1))
                                                   ^
```
[R/neighbourhood.R:318:15:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L318) *style:* **Place a space before left parenthesis, except in a function call.**
```r
            !((((to - 1) %% numCell + 1) != to) | ((from %% numCol + to %% numCol) == 1))
              ^
```
[R/neighbourhood.R:318:16:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L318) *style:* **Place a space before left parenthesis, except in a function call.**
```r
            !((((to - 1) %% numCell + 1) != to) | ((from %% numCol + to %% numCol) == 1))
               ^
```
[R/neighbourhood.R:318:17:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L318) *style:* **Place a space before left parenthesis, except in a function call.**
```r
            !((((to - 1) %% numCell + 1) != to) | ((from %% numCol + to %% numCol) == 1))
                ^
```
[R/neighbourhood.R:318:52:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L318) *style:* **Place a space before left parenthesis, except in a function call.**
```r
            !((((to - 1) %% numCell + 1) != to) | ((from %% numCol + to %% numCol) == 1))
                                                   ^
```
[R/neighbourhood.R:327:22:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L327) *style:* **Place a space before left parenthesis, except in a function call.**
```r
        whBotTop <- ((adj$to - 1) %% numCell + 1) != adj$to
                     ^
```
[R/neighbourhood.R:342:22:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L342) *style:* **Place a space before left parenthesis, except in a function call.**
```r
        whBotTop <- ((adj$to - 1) %% numCell + 1) != adj$to
                     ^
```
[R/neighbourhood.R:854:29:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L854) *style:* **Variable or function name should be lowerCamelCase.**
```r
setGeneric("wrap", function(X, bounds, withHeading) {
                            ^
```
[R/neighbourhood.R:863:25:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L863) *style:* **Variable or function name should be lowerCamelCase.**
```r
  definition = function(X, bounds) {
                        ^
```
[R/neighbourhood.R:880:25:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L880) *style:* **Variable or function name should be lowerCamelCase.**
```r
  definition = function(X, bounds) {
                        ^
```
[R/neighbourhood.R:890:25:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L890) *style:* **Variable or function name should be lowerCamelCase.**
```r
  definition = function(X, bounds) {
                        ^
```
[R/neighbourhood.R:891:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L891) *style:* **Variable or function name should be lowerCamelCase.**
```r
    X <- wrap(X, bounds = extent(bounds))
    ^
```
[R/neighbourhood.R:900:25:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L900) *style:* **Variable or function name should be lowerCamelCase.**
```r
  definition = function(X, bounds) {
                        ^
```
[R/neighbourhood.R:901:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L901) *style:* **Variable or function name should be lowerCamelCase.**
```r
    X <- wrap(X, bounds = extent(bounds))
    ^
```
[R/neighbourhood.R:910:25:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L910) *style:* **Variable or function name should be lowerCamelCase.**
```r
  definition = function(X, bounds) {
                        ^
```
[R/neighbourhood.R:913:7:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L913) *style:* **Variable or function name should be lowerCamelCase.**
```r
      X <- wrap(X, bounds = extent(bounds))
      ^
```
[R/neighbourhood.R:925:25:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L925) *style:* **Variable or function name should be lowerCamelCase.**
```r
  definition = function(X, bounds, withHeading) {
                        ^
```
[R/neighbourhood.R:950:25:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L950) *style:* **Variable or function name should be lowerCamelCase.**
```r
  definition = function(X, bounds, withHeading) {
                        ^
```
[R/neighbourhood.R:951:7:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L951) *style:* **Variable or function name should be lowerCamelCase.**
```r
      X <- wrap(X, bounds = extent(bounds), withHeading = withHeading)
      ^
```
[R/neighbourhood.R:960:25:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L960) *style:* **Variable or function name should be lowerCamelCase.**
```r
  definition = function(X, bounds, withHeading) {
                        ^
```
[R/neighbourhood.R:963:7:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/neighbourhood.R#L963) *style:* **Variable or function name should be lowerCamelCase.**
```r
      X <- wrap(X, bounds = extent(bounds), withHeading = withHeading)
      ^
```
[R/RcppExports.R:67:20:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/RcppExports.R#L67) *style:* **Variable or function name should be lowerCamelCase.**
```r
runifC <- function(N) {
                   ^
```
[R/RcppExports.R:70:1:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/RcppExports.R#L70) *style:* **Trailing blank lines are superfluous.**
```r

^
```
[R/SELES.R:53:23:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/SELES.R#L53) *style:* **Variable or function name should be lowerCamelCase.**
```r
numAgents <- function(N, probInit) {
                      ^
```
[R/spread.R:429:13:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread.R#L429) *style:* **Place a space before left parenthesis, except in a function call.**
```r
        if ((minValue(spreadProb) > 1L) || (maxValue(spreadProb) < 0L) ||
            ^
```
[R/spread.R:434:15:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread.R#L434) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          if (((minValue(spreadProbLater) > 1L) || (maxValue(spreadProbLater) < 0L) ||
              ^
```
[R/spread.R:434:16:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread.R#L434) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          if (((minValue(spreadProbLater) > 1L) || (maxValue(spreadProbLater) < 0L) ||
               ^
```
[R/spread.R:538:8:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread.R#L538) *style:* **Commented code should be removed.**
```r
      #isNASpreadProb <- is.na(spreadProb[])
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/spread.R:540:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread.R#L540) *style:* **Commented code should be removed.**
```r
      #   isNASpreadProb <- is.na(spreadProb[])
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/spread.R:541:11:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread.R#L541) *style:* **Commented code should be removed.**
```r
      #   spreadProb[isNASpreadProb] <- 0L
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/spread.R:783:43:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread.R#L783) *style:* **Place a space before left parenthesis, except in a function call.**
```r
              if (any(circleMaxRadius <= ((n - 1) * res(landscape)[1]))) {
                                          ^
```
[R/spread.R:807:19:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread.R#L807) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          if (any((size + len) > maxSize & size <= maxSize)) {
                  ^
```
[R/spread.R:927:75:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread.R#L927) *style:* **Place a space before left parenthesis, except in a function call.**
```r
            toKeepSR <- !(eventCells[, "id"] %fin% as.numeric(names(which((shouldStop)))))
                                                                          ^
```
[R/spread.R:937:17:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread.R#L937) *style:* **Place a space before left parenthesis, except in a function call.**
```r
            if ((returnDistances | spreadStateExists) & !allowOverlap) {
                ^
```
[R/spread.R:942:41:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread.R#L942) *style:* **Place a space before left parenthesis, except in a function call.**
```r
              notDupsEvents <- notDups[-(1:(nrSpreads - nrPotentials))]
                                        ^
```
[R/spread2.R:532:29:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread2.R#L532) *style:* **Place a space before left parenthesis, except in a function call.**
```r
        whNeedJump <- which(((clusterDT$numRetries + 1) %% 10) == 0)
                            ^
```
[R/spread2.R:532:30:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread2.R#L532) *style:* **Place a space before left parenthesis, except in a function call.**
```r
        whNeedJump <- which(((clusterDT$numRetries + 1) %% 10) == 0)
                             ^
```
[R/spread2.R:621:32:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread2.R#L621) *style:* **Place a space before left parenthesis, except in a function call.**
```r
          effDists <- dists * ((2 - angleQualities[, "angleQuality"]) / 2 *
                               ^
```
[R/spread2.R:699:15:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread2.R#L699) *style:* **Commented code should be removed.**
```r
            # colnamesDtPot <- colnames(dtPotential)
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/spread2.R:700:15:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread2.R#L700) *style:* **Commented code should be removed.**
```r
            # ll <-  lapply(colnamesDtPot, function(x) dtPotential[[x]][!spreadProbNA])
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/spread2.R:701:15:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread2.R#L701) *style:* **Commented code should be removed.**
```r
            # names(ll) <- colnamesDtPot
              ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[R/spread2.R:702:15:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/R/spread2.R#L702) *style:* **Commented code should be removed.**
```r
            # dtPotential <- as.data.table(ll)
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-adj.R:53:38:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-adj.R#L53) *style:* **Place a space before left parenthesis, except in a function call.**
```r
                             if (sum((adjDT - adj2[, colOrd]) ^ 2) == 0) {
                                     ^
```
[tests/testthat/test-adj.R:57:46:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-adj.R#L57) *style:* **Place a space before left parenthesis, except in a function call.**
```r
                               expect_gt(sum((adjDT - adj2[, colOrd]) ^ 2), 0)
                                             ^
```
[tests/testthat/test-examples.R:2:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-examples.R#L2) *style:* **Commented code should be removed.**
```r
#   fns <- ls("package:SpaDES.tools")
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:23:4:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L23) *style:* **Commented code should be removed.**
```r
  #expect_equal(sort(unique(getValues(biomass))), sort(reducedDT$biomass))
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:27:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L27) *style:* **Commented code should be removed.**
```r
#   library(data.table)
    ^~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:28:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L28) *style:* **Commented code should be removed.**
```r
#   library(raster)
    ^~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:31:6:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L31) *style:* **Commented code should be removed.**
```r
#    detach("package:data.table")
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:35:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L35) *style:* **Commented code should be removed.**
```r
#   ras <- raster(extent(0,15,0,15), res=1)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:36:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L36) *style:* **Commented code should be removed.**
```r
#   fullRas <- randomPolygons(ras, numTypes=5, speedup=1, p=0.3)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:37:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L37) *style:* **Commented code should be removed.**
```r
#   names(fullRas) <- "mapcodeAll"
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:38:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L38) *style:* **Commented code should be removed.**
```r
#   uniqueComms <- raster::unique(fullRas)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:42:7:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L42) *style:* **Commented code should be removed.**
```r
#     biomass=rnbinom(length(uniqueComms), mu=4000, 0.4)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:44:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L44) *style:* **Commented code should be removed.**
```r
#   biomass <- rasterizeReduced(reducedDT, fullRas, "biomass")
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:46:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L46) *style:* **Commented code should be removed.**
```r
#   expect_equal(sort(unique(getValues(biomass))), sort(reducedDT$biomass))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:47:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L47) *style:* **Commented code should be removed.**
```r
#   expect_equal(length(unique(getValues(biomass))), length(unique(getValues(fullRas))))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:49:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L49) *style:* **Commented code should be removed.**
```r
#   setkey(reducedDT, biomass)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:50:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L50) *style:* **Commented code should be removed.**
```r
#   communities <- rasterizeReduced(reducedDT, fullRas, "communities")
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:51:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L51) *style:* **Commented code should be removed.**
```r
#   expect_equal(sort(unique(getValues(communities))), sort(reducedDT$communities))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:52:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L52) *style:* **Commented code should be removed.**
```r
#   expect_equal(length(unique(getValues(communities))), length(unique(getValues(fullRas))))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:56:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L56) *style:* **Commented code should be removed.**
```r
#   library(data.table)
    ^~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:57:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L57) *style:* **Commented code should be removed.**
```r
#   library(raster)
    ^~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:60:6:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L60) *style:* **Commented code should be removed.**
```r
#    detach("package:data.table")
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:64:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L64) *style:* **Commented code should be removed.**
```r
#   ras <- raster(extent(0, 15, 0, 15), res = 1)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:65:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L65) *style:* **Commented code should be removed.**
```r
#   fullRas <- randomPolygons(ras, numTypes = 5, speedup = 1, p = 0.3)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:67:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L67) *style:* **Commented code should be removed.**
```r
#   uniqueComms <- raster::unique(fullRas)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:71:7:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L71) *style:* **Commented code should be removed.**
```r
#     biomass=rnbinom(length(uniqueComms), mu = 4000, 0.4)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:73:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L73) *style:* **Commented code should be removed.**
```r
#   biomass <- rasterizeReduced(reducedDT, fullRas, "biomass")
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:75:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L75) *style:* **Commented code should be removed.**
```r
#   setkey(reducedDT, biomass)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:76:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L76) *style:* **Commented code should be removed.**
```r
#   communities <- rasterizeReduced(reducedDT, fullRas, "communities")
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:77:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L77) *style:* **Commented code should be removed.**
```r
#   expect_equal(sort(unique(getValues(communities))), sort(reducedDT$communities))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:81:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L81) *style:* **Commented code should be removed.**
```r
#   library(data.table)
    ^~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:82:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L82) *style:* **Commented code should be removed.**
```r
#   library(raster)
    ^~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:85:6:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L85) *style:* **Commented code should be removed.**
```r
#    detach("package:data.table")
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:89:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L89) *style:* **Commented code should be removed.**
```r
#   ras <- raster(extent(0,15,0,15), res=1)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:90:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L90) *style:* **Commented code should be removed.**
```r
#   fullRas <- randomPolygons(ras, numTypes=5, speedup=1, p=0.3)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:91:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L91) *style:* **Commented code should be removed.**
```r
#   names(fullRas) <- "mapcodeAll"
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:92:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L92) *style:* **Commented code should be removed.**
```r
#   uniqueComms <- raster::unique(fullRas)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:96:7:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L96) *style:* **Commented code should be removed.**
```r
#     biomass=rnbinom(length(uniqueComms), mu=4000, 0.4)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:98:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L98) *style:* **Commented code should be removed.**
```r
#   biomass <- rasterizeReduced(reducedDT, fullRas, "biomass")
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:100:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L100) *style:* **Commented code should be removed.**
```r
#   setkey(reducedDT, biomass)
    ^~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:101:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L101) *style:* **Commented code should be removed.**
```r
#   communities <- rasterizeReduced(reducedDT, fullRas, "communities")
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-mapReduce.R:102:5:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-mapReduce.R#L102) *style:* **Commented code should be removed.**
```r
#   expect_equal(length(unique(getValues(communities))), length(unique(getValues(fullRas))))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-splitRaster.R:151:8:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-splitRaster.R#L151) *style:* **Commented code should be removed.**
```r
      #detach("package:raster")
       ^~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-splitRaster.R:247:4:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-splitRaster.R#L247) *style:* **Commented code should be removed.**
```r
  #expect_equal(min(values(m)), min(values(r))) ## Error: cannot allocate vector of size 4.8 Gb
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-splitRaster.R:266:4:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-splitRaster.R#L266) *style:* **Commented code should be removed.**
```r
  #expect_equal(max(values(m1)), max(values(r)))
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-splitRaster.R:267:4:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-splitRaster.R#L267) *style:* **Commented code should be removed.**
```r
  #expect_equal(min(values(m1)), min(values(r)))
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-spread.R:209:1:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-spread.R#L209) *style:* **Lines should not be more than 100 characters.**
```r
    if (interactive()) Plot(circEdge, addTo = "circs", cols = c("transparent", rainbow(numCircs)[whCirc]))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-spread.R:601:15:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-spread.R#L601) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  expect_true((radius * 1.5) %>=% max(dists[, "dists"]))
              ^
```
[tests/testthat/test-spread2.R:474:1:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-spread2.R#L474) *style:* **Lines should not be more than 100 characters.**
```r
  ##                                    expr       min        lq      mean   median        uq       max neval
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-spread2.R:475:1:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-spread2.R#L475) *style:* **Lines should not be more than 100 characters.**
```r
  ##         iterativeFun(ras, FALSE, n, sp)  3.096979 12.642477  73.02248 35.17520  91.10528  764.4073   300
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-spread2.R:475:4:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-spread2.R#L475) *style:* **Commented code should be removed.**
```r
  ##         iterativeFun(ras, FALSE, n, sp)  3.096979 12.642477  73.02248 35.17520  91.10528  764.4073   300
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-spread2.R:476:1:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-spread2.R#L476) *style:* **Lines should not be more than 100 characters.**
```r
  ##      nonIterativeFun(ras, FALSE, n, sp)  1.509484  6.555565  31.18444 14.91066  42.78317  158.5237   300
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-spread2.R:476:4:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-spread2.R#L476) *style:* **Commented code should be removed.**
```r
  ##      nonIterativeFun(ras, FALSE, n, sp)  1.509484  6.555565  31.18444 14.91066  42.78317  158.5237   300
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-spread2.R:477:1:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-spread2.R#L477) *style:* **Lines should not be more than 100 characters.**
```r
  ##           origSpread(ras, FALSE, n, sp)  5.154006  7.555631  14.87158 11.49005  17.50599  231.5487   300
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-spread2.R:477:4:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-spread2.R#L477) *style:* **Commented code should be removed.**
```r
  ##           origSpread(ras, FALSE, n, sp)  5.154006  7.555631  14.87158 11.49005  17.50599  231.5487   300
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-spread2.R:478:1:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-spread2.R#L478) *style:* **Lines should not be more than 100 characters.**
```r
  ## origSpreadIterations(ras, FALSE, n, sp) 10.754669 51.524368 141.48620 93.61996 169.10808 2110.2683   300
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-spread2.R:478:4:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-spread2.R#L478) *style:* **Commented code should be removed.**
```r
  ## origSpreadIterations(ras, FALSE, n, sp) 10.754669 51.524368 141.48620 93.61996 169.10808 2110.2683   300
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
[tests/testthat/test-spread2.R:702:38:](https://github.com/PredictiveEcology/SpaDES.tools/blob/77d7549a59975148aa9146966cb7b9bf2f99f24f/tests/testthat/test-spread2.R#L702) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  ciCentre[seq_len(ncell(ciCentre))[-(ncell(ciCentre) / 2 - ncol(ciCentre) / 2)]] <- NA_integer_
                                     ^
```


that's a way better idea, thanks


[R/stnd_cor.R:19:33:](https://github.com/soodoku/goji/blob/532908e78d28bd2bab055a55a42066cfb19fddf2/R/stnd_cor.R#L19) *style:* **Put spaces around all infix operators.**
```r
  est_guessed <- total_incorrect/(n_options - 1)
                               ~^~
```
[R/stnd_cor.R:19:34:](https://github.com/soodoku/goji/blob/532908e78d28bd2bab055a55a42066cfb19fddf2/R/stnd_cor.R#L19) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  est_guessed <- total_incorrect/(n_options - 1)
                                 ^
```
[R/stnd_cor.R:20:44:](https://github.com/soodoku/goji/blob/532908e78d28bd2bab055a55a42066cfb19fddf2/R/stnd_cor.R#L20) *style:* **Put spaces around all infix operators.**
```r
  adjusted <- (total_correct - est_guessed)/ length(item)
                                          ~^
```


More seemingly unrelated changes


Much better thanks!


Didn't this happen back in #527 already?


[R/stnd_cor.R:19:43:](https://github.com/soodoku/goji/blob/7d5cf75efa5620ba6e02494f90c5473bcbc5e134/R/stnd_cor.R#L19) *style:* **Put spaces around all infix operators.**
```r
  est_guessed_correctly <- total_incorrect/(n_options - 1)
                                         ~^~
```
[R/stnd_cor.R:19:44:](https://github.com/soodoku/goji/blob/7d5cf75efa5620ba6e02494f90c5473bcbc5e134/R/stnd_cor.R#L19) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  est_guessed_correctly <- total_incorrect/(n_options - 1)
                                           ^
```
[R/stnd_cor.R:20:57:](https://github.com/soodoku/goji/blob/7d5cf75efa5620ba6e02494f90c5473bcbc5e134/R/stnd_cor.R#L20) *style:* **Trailing whitespace is superfluous.**
```r
  est_correct <- (total_correct - est_guessed_correctly)
                                                        ^
```
[R/stnd_cor.R:22:26:](https://github.com/soodoku/goji/blob/7d5cf75efa5620ba6e02494f90c5473bcbc5e134/R/stnd_cor.R#L22) *style:* **Put spaces around all infix operators.**
```r
  adjusted <- est_correct/ length(item)
                        ~^
```


This doesn't seem related to the change


Isn't there a fu_device,has,flag()?


This is related, I've tried the solution however it doesn't appear to work...
https://github.com/PinionTech/winston-s3/pull/6/files


Something screwy is going on, this should have already happened. in #527


Luarocks.loader shouldn't be needed since 5 years ago.


Maybe also have KEY in the define name? Maybe it's not required.


oooh cleaner, thanks didn't know that existed.


primeiro exercicio feito em aula, ainda incompleto


Consider indexing the addresses. And adding the amount.


Why is this just gone, all of a sudden? No real comment from the author on this particular change. I wasn't under the impression that `GET_AVB_INFO` was Talker specific.

This change has propagated all the way into 2017 code, over in the XMOS repos ([see here](https://github.com/xmos/lib_tsn/blob/8d22856a17c8b62536630c4ae8540289a446ea01/lib_tsn/src/1722_1/avb_1722_1_aecp.c#L699-L722)). Since it reports very important status info, like `asCapable`, wouldn't it be worth re-integrating this command?


What's your thinking in the KEY being in there too?


sad reacts only


[R/stnd_cor.R:19:43:](https://github.com/soodoku/goji/blob/ca62dcc18b239af07b583f83dfa46998a281aa08/R/stnd_cor.R#L19) *style:* **Put spaces around all infix operators.**
```r
  est_guessed_correctly <- total_incorrect/(n_options - 1)
                                         ~^~
```
[R/stnd_cor.R:19:44:](https://github.com/soodoku/goji/blob/ca62dcc18b239af07b583f83dfa46998a281aa08/R/stnd_cor.R#L19) *style:* **Place a space before left parenthesis, except in a function call.**
```r
  est_guessed_correctly <- total_incorrect/(n_options - 1)
                                           ^
```
[R/stnd_cor.R:20:57:](https://github.com/soodoku/goji/blob/ca62dcc18b239af07b583f83dfa46998a281aa08/R/stnd_cor.R#L20) *style:* **Trailing whitespace is superfluous.**
```r
  est_correct <- (total_correct - est_guessed_correctly)
                                                        ^
```
[R/stnd_cor.R:22:26:](https://github.com/soodoku/goji/blob/ca62dcc18b239af07b583f83dfa46998a281aa08/R/stnd_cor.R#L22) *style:* **Put spaces around all infix operators.**
```r
  adjusted <- est_correct/ length(item)
                        ~^
```


Cheaper but same result as `uint amount = msg.value / 2;` given how EVM divides.


Created multidev environment [badcamp-2017#pr-label-st](https://dashboard.pantheon.io/sites/8d658997-7a61-4db8-9be8-0f16b8b62022#pr-label-st).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://pr-label-st-badcamp-2017.pantheonsite.io/)


@tchajed Here is the change, I will fix the typo here..


Created multidev environment [badcamp-2017#ci-541](https://dashboard.pantheon.io/sites/8d658997-7a61-4db8-9be8-0f16b8b62022#ci-541).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-541-badcamp-2017.pantheonsite.io/)


I have deployed this commit :shipit:.


Don't worry about "Alice" ... we can use msg.sender for that. The contract only needs to know about Bob and Carol to perform its work.


Created multidev environment [build-tools-648#ci-1](https://dashboard.pantheon.io/sites/1bc251f5-072a-4508-94e2-8d1da5cd6074#ci-1).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-1-build-tools-648.pantheonsite.io/)


Line 21. You're using the fallback and it has all sorts of hidden issues. You should make a dedicated function to avoid confusion. Also, you can pass the Bob/Carol addresses in here instead of the constructor so the contract will work for more than one agreement (re-use).

`function sendSplit(address recipient1, address recipient2) public payable {...}`


Created multidev environment [build-tools-649#ci-1](https://dashboard.pantheon.io/sites/4c8af294-b2ec-4887-b97e-6ef94620f1fa#ci-1).

[![Visit Site](https://raw.githubusercontent.com/pantheon-systems/ci-drops-8/0.1.0/data/img/visit-site-36.png)](https://ci-1-build-tools-649.pantheonsite.io/)


Your payable function talks to three untrusted contracts at the same time. This is a security risk. You should split it up into smaller concerns; one function to receive funds and do some accounting, and another function for people to withdraw their funds from the contract.


It would be bad form to have extra money unaccounted for, so you should return the extra wei to the sender. Fix this concern last, because there is a natural solution when you address the other parts.


AddressProblemUnitTests (Myoldmopar) - Win64-Windows-7-VisualStudio-14: OK (2744 of 2744 tests passed, 0 test warnings)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.png) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.png)


0246,215_02_x25tsi_v0.51.rom appears to have the wrong size (32768 instead of 16384).


This will always be true as it is not a simple type. I have fixed this issue with https://github.com/Microsoft/vscode/commit/905a3081e99a3c40442559c47a57e76945b8cccb. Take a look if you are interested


<img width="964" alt="screenshot 2017-08-24 17 29 05" src="https://user-images.githubusercontent.com/110444/29691649-f442d316-88f9-11e7-9119-f131ee82c78c.png">


<img width="965" alt="screenshot 2017-08-24 17 07 42" src="https://user-images.githubusercontent.com/110444/29691658-fe915d38-88f9-11e7-9462-9a182943abbf.png">


<img width="873" alt="screenshot 2017-08-24 17 17 15" src="https://user-images.githubusercontent.com/110444/29691668-086db7f2-88fa-11e7-98f1-ddde620ac6c4.png">


At a quick glance it might be nice if this came from a data attribute similar to the other URLs so if we change it in Django it cascades through to the javascript as well.


If the `job_id` is only used to build the URL, pass the URL instead I guess?


You should give it its own file. No pun intended.


```== 20170824191049 ImportProductData: migrating ================================
{
             :id => 1,
           :name => "Washed Chinos",
          :image => "https://bonobos-prod-s3.imgix.net/products/26061/original/PNT_WC_GreyDogs_Slim_hero1.jpg?1476915862=&w=1200&auto=format%2Ccompress&dpr=1&q=75&crop=false&fit=clip&w=900&h=1",
    :description => "All-Purpose, 100% Cotton Chinos With Our Signature Curved Waistband For A Better, More Natural Fit. Available In Four Fits, A Full Range Of Colors, And Original Contrast Pocket Liners."
}
#<Product:0x007fce3d0f79f0> {
             :id => 1,
           :name => "Washed Chinos",
    :description => "All-Purpose, 100% Cotton Chinos With Our Signature Curved Waistband For A Better, More Natural Fit. Available In Four Fits, A Full Range Of Colors, And Original Contrast Pocket Liners.",
          :image => "https://bonobos-prod-s3.imgix.net/products/26061/original/PNT_WC_GreyDogs_Slim_hero1.jpg?1476915862=&w=1200&auto=format%2Ccompress&dpr=1&q=75&crop=false&fit=clip&w=900&h=1",
     :created_at => Thu, 24 Aug 2017 20:45:07 UTC +00:00,
     :updated_at => Thu, 24 Aug 2017 20:45:07 UTC +00:00
}
{
             :id => 2,
           :name => "Jetsetter Jeans",
          :image => "https://bonobos-prod-s3.imgix.net/products/26709/original/hjh9u9m0441y5qv9qlg6qvy4owanulkj.jpg?1477944668=&auto=format%2Ccompress&dpr=1&q=75&crop=false&fit=clip&w=400&h=1",
    :description => "Innovative Stretch Denim For First-Class Comfort. Designed To Be Extra Soft And Resilient, They’Re The Most Comfortable Jeans You’Ve Ever Worn."
}
#<Product:0x007fce3cf48758> {
             :id => 2,
           :name => "Jetsetter Jeans",
    :description => "Innovative Stretch Denim For First-Class Comfort. Designed To Be Extra Soft And Resilient, They’Re The Most Comfortable Jeans You’Ve Ever Worn.",
          :image => "https://bonobos-prod-s3.imgix.net/products/26709/original/hjh9u9m0441y5qv9qlg6qvy4owanulkj.jpg?1477944668=&auto=format%2Ccompress&dpr=1&q=75&crop=false&fit=clip&w=400&h=1",
     :created_at => Thu, 24 Aug 2017 20:45:07 UTC +00:00,
     :updated_at => Thu, 24 Aug 2017 20:45:07 UTC +00:00
}
```


Usually, people another `Mortal` contract for that `kill()`.


Also, usually, people add the `onlyOwner` modifier here.


0, 1 or 2 spaces, pick one ;)


```== 20170824191056 ImportInventoryData: migrating ==============================
{
    :product_id => 1,
         :style => "Jet Blues",
         :count => 75,
         :waist => 28,
        :length => 36
}
#<Inventory:0x007fce3d987228> {
            :id => 169,
    :product_id => 1,
         :style => "Jet Blues",
         :waist => 28,
        :length => 36,
         :count => 75,
    :created_at => Thu, 24 Aug 2017 20:45:07 UTC +00:00,
    :updated_at => Thu, 24 Aug 2017 20:45:07 UTC +00:00
}
{
    :product_id => 1,
         :style => "Grey Dogs",
         :count => 46,
         :waist => 28,
        :length => 36
}
#<Inventory:0x007fce3db84378> {
            :id => 170,
    :product_id => 1,
         :style => "Grey Dogs",
         :waist => 28,
        :length => 36,
         :count => 46,
    :created_at => Thu, 24 Aug 2017 20:45:07 UTC +00:00,
    :updated_at => Thu, 24 Aug 2017 20:45:07 UTC +00:00
}
{
    :product_id => 1,
         :style => "Stone Cutters",
         :count => 72,
         :waist => 28,
        :length => 36
}
#<Inventory:0x007fce3c02bb58> {
            :id => 171,
    :product_id => 1,
         :style => "Stone Cutters",
         :waist => 28,
        :length => 36,
         :count => 72,
    :created_at => Thu, 24 Aug 2017 20:45:07 UTC +00:00,
    :updated_at => Thu, 24 Aug 2017 20:45:07 UTC +00:00
}
{
    :product_id => 1,
         :style => "Graham Slackers",
         :count => 5,
         :waist => 28,
        :length => 36
}
#<Inventory:0x007fce3cef2b28> {
            :id => 172,
    :product_id => 1,
         :style => "Graham Slackers",
         :waist => 28,
        :length => 36,
         :count => 5,
    :created_at => Thu, 24 Aug 2017 20:45:07 UTC +00:00,
    :updated_at => Thu, 24 Aug 2017 20:45:07 UTC +00:00
}
{
    :product_id => 4,
         :style => "Blue",
         :count => 53,
         :waist => 28,
        :length => 36
}
#<Inventory:0x007fce3cfe49c8> {
            :id => 336,
    :product_id => 4,
         :style => "Blue",
         :waist => 28,
        :length => 36,
         :count => 53,
    :created_at => Thu, 24 Aug 2017 20:45:07 UTC +00:00,
    :updated_at => Thu, 24 Aug 2017 20:45:07 UTC +00:00
}
== 20170824191056 ImportInventoryData: migrated (0.3404s) =====================


¡Excelente!


Commented out code


[R/stnd_cor.R:20:57:](https://github.com/soodoku/goji/blob/b40f9f1dfee806e632b08b2f79e4d5832c146e76/R/stnd_cor.R#L20) *style:* **Trailing whitespace is superfluous.**
```r
  est_correct <- (total_correct - est_guessed_correctly)
                                                        ^
```


You neatly separated these events into 2 groups. Sounds like you want to take them out into their own contracts, and inherit.


Actually, you may want to keep a hash to the full metadata of the product. Think IPFS hash. So not `name`, but `details`.


First look at these arrays, and I wonder what convolution comes later on.


Ah right here, loop? No. Wrong data structure.


Bluemix [toolchain](https://console-regional.ng.bluemix.net/devops/toolchains/b09e3ee0-bc62-4bd7-bcf6-7b033dada6af "TriAzurUE"): [Delivery Pipeline](https://console-regional.ng.bluemix.net/devops/pipelines/57bc70fc-3a85-4eb7-a477-d1a67ac25fb2 "TriAzurUE") deployed [TriAzur_code](https://github.com/Doncassino/TriAzur_code/releases/tag/deploy-ibm-yp-eu-gb-TriAzur-TriAzur-20170824-223429 "deploy-ibm-yp-eu-gb-TriAzur-TriAzur-20170824-223429") to [TriAzur](https://console.bluemix.net/apps/11b7850a-b04f-4546-975c-fb2662c615cd?env_id=ibm:yp:eu-gb "ibm:yp:eu-gb:TriAzur:TriAzur"), including this commit


![](https://github.trello.services/images/mini-trello-icon.png) [(3) Inserimento della nuova Caccia al tesoro nel DB [3]](https://trello.com/c/4iIODKWa/95-3-inserimento-della-nuova-caccia-al-tesoro-nel-db-3)


![](https://github.trello.services/images/mini-trello-icon.png) [(3) Delinamento Logica Server per la Comunicazione con il DB [2]](https://trello.com/c/XwxD1lXC/90-3-delinamento-logica-server-per-la-comunicazione-con-il-db-2)


What does this do?  It doesn't seem to be used anywhere.  If it did do something it seems like it would be better suited to be a JUnit Rule.


![](https://github.trello.services/images/mini-trello-icon.png) [(1) Inserimento del nuovo Quiz nel DB [1]](https://trello.com/c/J8P1a3qe/107-1-inserimento-del-nuovo-quiz-nel-db-1)


Boom


More out of place changes from the S3 access control change


@v-dobrev - I've run into race conditions with having multiple MPI ranks trying to dump to the same files, when code coverage is enabled.  This page has some info on it - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47618


I think it's time for another **release**:

![pbrt](https://user-images.githubusercontent.com/1074865/29691883-0f9f7eae-8925-11e7-997d-f554c74317bb.png)


<img width="1010" alt="screenshot 2017-08-24 18 26 18" src="https://user-images.githubusercontent.com/110444/29691898-46a8a3b4-88fb-11e7-920f-a25cbb7409cf.png">